Timeline



Oct 18, 2013:

11:47 PM Changeset in webkit [157664] by jinwoo7.song@samsung.com
  • 3 edits
    5 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Remove EFL-specific test expectations that were identical to generic expectations
and rebaseline test cases.

  • platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Removed.
  • platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Removed.
  • platform/efl/compositing/backing/no-backing-for-clip-overhang-expected.txt: Removed.
  • platform/efl/compositing/contents-opaque/hidden-with-visible-child-expected.txt: Removed.
  • platform/efl/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Rebaselined after r154896.
  • platform/efl/svg/batik/paints/gradientLimit-expected.txt: Updating baselines after enabling the subpixel layout.
9:28 PM Changeset in webkit [157663] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Update EFL test expectations.

  • platform/efl/TestExpectations:
8:14 PM Changeset in webkit [157662] by weinig@apple.com
  • 17 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Dan Bernstein.

  • Make the RootInlineBox constructor take a RenderBlockFlow.
  • Move createRootInlineBox, and createAndAppendRootInlineBox to RenderBlockFlow.
  • editing/VisibleUnits.cpp:

(WebCore::absoluteLineDirectionPointToLocalPointInBlock):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::locationIncludingFlipping):
(WebCore::InlineBox::flipForWritingMode):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createRootInlineBox):
(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):
(WebCore::createInlineBoxForRenderer):
(WebCore::RenderBlockFlow::createLineBoxes):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::localSelectionRect):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::localSelectionRect):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::rendererLineBoxes):
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::setContainingRegion):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::lineSnapAdjustment):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::computeCaretRect):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::selectionBottom):
(WebCore::RootInlineBox::blockDirectionPointInLine):
(WebCore::RootInlineBox::blockFlow):
(WebCore::RootInlineBox::closestLeafChildForPoint):
(WebCore::RootInlineBox::removeLineBoxFromRenderObject):
(WebCore::RootInlineBox::extractLineBoxFromRenderObject):
(WebCore::RootInlineBox::attachLineBoxToRenderObject):

  • rendering/RootInlineBox.h:
  • rendering/TrailingFloatsRootInlineBox.h:
  • rendering/svg/RenderSVGText.h:

(WebCore::toRenderSVGText):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::renderSVGText):
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutRootBox):

  • rendering/svg/SVGRootInlineBox.h:
7:37 PM Changeset in webkit [157661] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix FTL build.

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetById):

7:20 PM Changeset in webkit [157660] by fpizlo@apple.com
  • 30 edits
    1 add in trunk/Source

A CodeBlock's StructureStubInfos shouldn't be in a Vector that we search using code origins and machine code PCs
​https://bugs.webkit.org/show_bug.cgi?id=122940

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This accomplishes a number of simplifications. StructureStubInfo is now non-moving,
whereas previously it was in a Vector, so it moved. This allows you to use pointers to
StructureStubInfo. This also eliminates the use of return PC as a way of finding the
StructureStubInfo's. It removes some of the need for the compile-time property access
records; for example the DFG no longer has to save information about registers in a
property access record only to later save it to the stub info.

The main thing is accomplishes is that it makes it easier to add StructureStubInfo's
at any stage of compilation.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::addStubInfo):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::shrinkToFit):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::begin):
(JSC::CodeBlock::end):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):

  • bytecode/CodeOrigin.h:

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isHashTableDeletedValue):
(JSC::CodeOrigin::hash):
(JSC::CodeOriginHash::hash):
(JSC::CodeOriginHash::equal):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:
  • bytecode/StructureStubInfo.h:

(JSC::getStructureStubInfoCodeOrigin):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::PropertyAccessRecord::PropertyAccessRecord):
(JSC::DFG::InRecord::InRecord):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIn):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::PropertyStubCompilationInfo::slowCaseInfo):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/Repatch.cpp:

(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::resetPutByID):

Source/WTF:

Reviewed by Oliver Hunt.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/BagToHashMap.h: Added.

(WTF::toHashMap):

  • wtf/CMakeLists.txt:
6:47 PM Changeset in webkit [157659] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk/Websites/test-results

New flakiness dashboard should support showing the failing tests per builder
​https://bugs.webkit.org/show_bug.cgi?id=123011

Reviewed by Timothy Hatcher.

Added the feature. Also did some refactoring to add this feature.

  • ChangeLog: Added.
  • api/failing-tests.php: Added.
  • api/manifest.php: Removed the code to make maps by id. The work is now done in index.html.
  • api/results.php:
  • common.css: Added. Extracted from index.html.
  • include/test-results.php: Extracted parse_revisions_array and format_result_rows from results.php.
  • index.html:
  • main.css: Added.

(TestResultsView.setAvailableTests): Added.
(TestResultsView.showTooltip): Fixed the code to compute x and y coordinates of the tooltip to take
scrolled positions into account.
(TestResultsView._createTestResultRow): Extracted from _populateTestPane.
(TestResultsView.fetchTest): Added the code to show "Loading..." in the pane while loading the JSON.
(TestResultsView.fetchTests): Respect the doNotUpdateHash flag.
(TestResultsView._populateBuilderPane): Added.
(TestResultsView.fetchFailingTestsForBuilder): Added.
(TestResultsView.updateLocationHash): Serialize builder & builderDays.
(TestResultsView.locationHashChanged): Don't delete existing test panes since that's now done in
loadTestsFromLocationHash.
(TestResultsView.loadTestsFromLocationHash): Take care of both 'tests' and 'builder' components.
(fetchManifest): Setup the UI to select a builder.

5:51 PM Changeset in webkit [157658] by timothy_horton@apple.com
  • 9 edits in trunk/Source

Remote Layer Tree: Double-buffering and minimization of repaints
​https://bugs.webkit.org/show_bug.cgi?id=123043

Reviewed by Simon Fraser.

No new tests, not yet testable.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::ensureBackingStore):
Don't worry about isOpaque with RemoteLayerBackingStore; this is a
optimization that is causing trouble; we can re-add it later.

(PlatformCALayerRemote::setBounds):
Make sure that we will repaint if our bounds change.

  • WebProcess/WebPage/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::bitmap):
Keep a front and back buffer; return the front buffer when being asked for the bitmap.
Keep a Region of repaint areas.

  • WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
Serialize only the front buffer, since the UI process only needs that.

(RemoteLayerBackingStore::setNeedsDisplay):
Store repaint rects instead of always setting the whole layer to be dirty.

(RemoteLayerBackingStore::display):
Paint into the back buffer (copying valid parts over from the front buffer),
then swap it to the front buffer. Use drawLayerContents so we get repaint counters, etc.

  • WebCore.exp.in:

Export one version of drawLayerContents and Region::contains.

  • WebCore.xcodeproj/project.pbxproj:

Expose WebLayer.h as a private header.

  • platform/graphics/mac/WebLayer.h:

Clean up this header, and add a new drawLayerContents that can operate without a CALayer.

  • platform/graphics/mac/WebLayer.mm:

(WebCore::drawLayerContents):
Split drawLayerContents into one method that acquires properties CALayer,
and one that just does the painting.

5:46 PM Changeset in webkit [157657] by andersca@apple.com
  • 4 edits in trunk/Source

Try to fix the Lion build.

Source/WebCore:

  • bindings/objc/ObjCNodeFilterCondition.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
5:09 PM Changeset in webkit [157656] by oliver@apple.com
  • 36 edits in trunk

Spread operator should be performing direct "puts" and not triggering setters
​https://bugs.webkit.org/show_bug.cgi?id=123047

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add a new opcode -- op_put_by_val_directue -- and make use of it in the spread
to array construct. This required a new PutByValDirect node to be introduced to
the DFG. The current implementation simply changes the slow path function that
is called, but in future this could be made faster as it does not need to check
the prototype chain.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDirectPutByVal):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getArrayLengthElimination):
(JSC::DFG::CSEPhase::getByValLoadElimination):
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::clobbersWorld):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasArrayMode):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):
(JSC::DFG::operationPutByValInternal):

  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileContiguousPutByVal):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::compileDirectPutByVal):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePutByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_put_by_val):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

LayoutTests:

Add a new testcase for the setter case. run-javascriptcore-tests hits this with
the llint, baseline, and dfg.

  • js/basic-spread-expected.txt:
  • js/script-tests/basic-spread.js:

(Array):

5:05 PM Changeset in webkit [157655] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[iOS] Export symbol for VM::sharedInstanceExists()
​https://bugs.webkit.org/show_bug.cgi?id=123046

Reviewed by Mark Hahnenberg.

  • runtime/VM.h:
4:57 PM Changeset in webkit [157654] by dbates@webkit.org
  • 8 edits
    2 adds in trunk/Source

[iOS] Upstream WebSafe{GCActivityCallback, IncrementalSweeper}IOS
​https://bugs.webkit.org/show_bug.cgi?id=123049

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • heap/Heap.cpp:

(JSC::Heap::setIncrementalSweeper):

  • heap/Heap.h:
  • heap/HeapTimer.h:
  • heap/IncrementalSweeper.h: Make protected and export CF-variant of constructor.

Removed unused include of header RetainPtr.h. Also forward declare class MarkedBlock
(we include its header in the .cpp file) and remove include for header wtf/HashSet.h
(duplicates the include in the .cpp).

  • heap/MachineStackMarker.h: Export function makeUsableFromMultipleThreads(). We aren't

making use of this now, but we'll make use of it in a subsequent patch.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/WebSafeGCActivityCallbackIOS.h: Added.
  • platform/ios/WebSafeIncrementalSweeperIOS.h: Added.
4:41 PM Changeset in webkit [157653] by andersca@apple.com
  • 573 edits in trunk/Source

Remove spaces between template angle brackets
​https://bugs.webkit.org/show_bug.cgi?id=123040

Reviewed by Andreas Kling.

Source/JavaScriptCore:

  • API/JSCallbackObject.cpp:

(JSC::::create):

  • API/JSObjectRef.cpp:
  • bytecode/CodeBlock.h:

(JSC::CodeBlock::constants):
(JSC::CodeBlock::setConstantRegisters):

  • bytecode/DFGExitProfile.h:
  • bytecode/EvalCodeCache.h:
  • bytecode/Operands.h:
  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::constantRegisters):

  • bytecode/Watchpoint.h:
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/StaticPropertyAnalysis.h:
  • bytecompiler/StaticPropertyAnalyzer.h:
  • dfg/DFGArgumentsSimplificationPhase.cpp:
  • dfg/DFGBlockInsertionSet.h:
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::performCSE):
(JSC::DFG::performStoreElimination):

  • dfg/DFGCommonData.h:
  • dfg/DFGDesiredStructureChains.h:
  • dfg/DFGDesiredWatchpoints.h:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGWorklist.h:
  • heap/BlockAllocator.h:

(JSC::CopiedBlock):
(JSC::MarkedBlock):
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::CopyWorkListSegment):
(JSC::HandleBlock):

  • heap/Heap.h:
  • heap/Local.h:
  • heap/MarkedBlock.h:
  • heap/Strong.h:
  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::decodedCodeMapFor):

  • jit/AssemblyHelpers.h:
  • jit/SpecializedThunkJIT.h:
  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::::parseIfStatement):

  • parser/Parser.h:

(JSC::Scope::copyCapturedVariablesToVector):
(JSC::parse):

  • parser/ParserArena.h:
  • parser/SourceProviderCacheItem.h:
  • profiler/LegacyProfiler.cpp:

(JSC::dispatchFunctionToProfiles):

  • profiler/LegacyProfiler.h:

(JSC::LegacyProfiler::currentProfiles):

  • profiler/ProfileNode.h:

(JSC::ProfileNode::children):

  • profiler/ProfilerDatabase.h:
  • runtime/Butterfly.h:

(JSC::Butterfly::contiguousInt32):
(JSC::Butterfly::contiguous):

  • runtime/GenericTypedArrayViewInlines.h:

(JSC::::create):

  • runtime/Identifier.h:

(JSC::Identifier::add):

  • runtime/JSPromise.h:
  • runtime/PropertyMapHashTable.h:
  • runtime/PropertyNameArray.h:
  • runtime/RegExpCache.h:
  • runtime/SparseArrayValueMap.h:
  • runtime/SymbolTable.h:
  • runtime/VM.h:
  • tools/CodeProfile.cpp:

(JSC::truncateTrace):

  • tools/CodeProfile.h:
  • yarr/YarrInterpreter.cpp:
  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileBody):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):

  • yarr/YarrPattern.h:

Source/WebCore:

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.h:
  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):

  • Modules/geolocation/GeolocationController.h:
  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabaseBackendInterface.h:
  • Modules/indexeddb/IDBEventDispatcher.cpp:

(WebCore::IDBEventDispatcher::dispatch):

  • Modules/indexeddb/IDBEventDispatcher.h:
  • Modules/indexeddb/IDBKey.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBPendingTransactionMonitor.cpp:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

  • Modules/indexeddb/IDBRequest.h:

(WebCore::IDBRequest::onSuccessWithPrefetch):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::dispatchEvent):

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::sortedTrackListForMenu):

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::activeRanges):

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/MediaSourceBase.cpp:

(WebCore::MediaSourceBase::buffered):

  • Modules/mediasource/MediaSourceBase.h:
  • Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::unregisterURL):

  • Modules/mediasource/MediaSourceRegistry.h:
  • Modules/mediasource/SourceBufferList.h:
  • Modules/mediasource/WebKitMediaSource.cpp:

(WebCore::WebKitMediaSource::activeRanges):

  • Modules/mediasource/WebKitMediaSource.h:
  • Modules/mediasource/WebKitSourceBufferList.h:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::scheduledEventTimerFired):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStreamRegistry.h:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::scheduledEventTimerFired):

  • Modules/mediastream/RTCDTMFSender.h:
  • Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::scheduledEventTimerFired):

  • Modules/mediastream/RTCDataChannel.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCStatsResponse.h:

(WebCore::RTCStatsResponse::result):

  • Modules/notifications/Notification.h:
  • Modules/notifications/NotificationCenter.h:
  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::getVoices):

  • Modules/speech/SpeechSynthesis.h:
  • Modules/webaudio/AudioBuffer.h:
  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/AudioNodeOutput.h:
  • Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::setAudioFormat):
(WebCore::MediaStreamAudioSource::consumeAudio):

  • Modules/webaudio/PeriodicWave.h:
  • Modules/webaudio/ScriptProcessorNode.h:
  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/DatabaseBackend.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::origins):

  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::origins):

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::deleteAllDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/SQLStatementBackend.cpp:
  • Modules/webdatabase/SQLTransactionBackend.cpp:
  • Modules/webdatabase/SQLTransactionBackend.h:
  • Modules/webdatabase/SQLTransactionCoordinator.cpp:

(WebCore::SQLTransactionCoordinator::shutdown):

  • Modules/webdatabase/SQLTransactionCoordinator.h:
  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryDataCallback):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveBinaryData):

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processFrame):

  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::didReceiveBinaryData):

  • Modules/websockets/WebSocketExtensionDispatcher.h:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::workerGlobalScopeDidReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::mainThreadSendArrayBuffer):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):

  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache):

  • accessibility/AXObjectCache.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::ariaLabeledByText):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityText::AccessibilityText):

  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSDOMBinding.h:

(WebCore::toRefPtrNativeArray):

  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSMutationCallback.cpp:

(WebCore::JSMutationCallback::call):

  • bindings/js/JSMutationCallback.h:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getAttachedShaders):

  • bindings/js/PageScriptDebugServer.h:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::collectIsolatedContexts):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor):

  • bindings/objc/ObjCNodeFilterCondition.h:
  • bridge/objc/objc_class.h:
  • bridge/runtime_root.cpp:

(JSC::Bindings::RootObject::invalidate):

  • bridge/runtime_root.h:
  • css/BasicShapeFunctions.cpp:

(WebCore::basicShapeForValue):

  • css/CSSBasicShapes.h:

(WebCore::CSSBasicShapePolygon::values):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForFilter):

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::getFontFace):
(WebCore::CSSFontSelector::beginLoadTimerFired):

  • css/CSSFontSelector.h:
  • css/CSSGroupingRule.h:
  • css/CSSImageGeneratorValue.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::adoptSelectorVector):

  • css/CSSParserValues.h:
  • css/CSSPropertySourceData.h:
  • css/CSSRuleList.h:

(WebCore::StaticCSSRuleList::rules):

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::fontLoaded):

  • css/CSSSegmentedFontFace.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::adoptSelectorVector):

  • css/CSSSelectorList.h:
  • css/CSSStyleSheet.h:
  • css/CSSValue.h:

(WebCore::compareCSSValueVector):

  • css/CSSValuePool.h:
  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets):
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):

  • css/DocumentRuleSets.h:
  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchedRuleList):

  • css/ElementRuleCollector.h:
  • css/FontLoader.h:
  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):

  • css/InspectorCSSOMWrappers.h:
  • css/MediaList.cpp:

(WebCore::MediaQuerySet::parse):
(WebCore::MediaList::item):
(WebCore::reportMediaQueryWarningIfNeeded):

  • css/MediaList.h:

(WebCore::MediaQuerySet::queryVector):

  • css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::eval):

  • css/MediaQueryMatcher.h:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):

  • css/PropertySetCSSStyleDeclaration.h:
  • css/RuleSet.cpp:

(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::addRulesFromSheet):

  • css/RuleSet.h:
  • css/SelectorFilter.h:
  • css/StyleInvalidationAnalysis.cpp:

(WebCore::StyleInvalidationAnalysis::analyzeStyleSheet):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getLayeredShorthandValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::styleRulesForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::loadPendingShaders):

  • css/StyleResolver.h:
  • css/StyleRule.cpp:

(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
(WebCore::StyleRuleGroup::StyleRuleGroup):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleSupports::StyleRuleSupports):
(WebCore::StyleRuleRegion::StyleRuleRegion):

  • css/StyleRule.h:

(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleGroup::childRules):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleHost::create):
(WebCore::StyleRuleHost::StyleRuleHost):

  • css/StyleScopeResolver.h:
  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parserAppendRule):
(WebCore::childRulesHaveFailedOrCanceledSubresources):

  • css/StyleSheetContents.h:

(WebCore::StyleSheetContents::childRules):
(WebCore::StyleSheetContents::importRules):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::item):

  • css/StyleSheetList.h:
  • css/WebKitCSSKeyframesRule.h:

(WebCore::StyleRuleKeyframes::keyframes):

  • dom/CheckedRadioButtons.h:
  • dom/ClientRectList.h:
  • dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::nextNode):
(WebCore::ChildNodesLazySnapshot::takeSnapshot):

  • dom/CrossThreadTask.h:
  • dom/Document.cpp:

(WebCore::Document::webkitCancelFullScreen):
(WebCore::Document::webkitExitFullscreen):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):

  • dom/Document.h:
  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::removeMarkers):

  • dom/DocumentMarkerController.h:
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets):
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::styleSheetsUseRemUnits):
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

  • dom/DocumentStyleSheetCollection.h:
  • dom/Element.cpp:

(WebCore::Element::attrNodeList):
(WebCore::Element::webkitGetRegionFlowRanges):

  • dom/Element.h:
  • dom/EventListenerMap.h:
  • dom/EventSender.h:

(WebCore::EventSender::timerFired):

  • dom/IdTargetObserverRegistry.h:
  • dom/MutationCallback.h:
  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::takeRecords):
(WebCore::MutationObserver::deliver):
(WebCore::MutationObserver::deliverAllMutations):

  • dom/MutationObserver.h:
  • dom/MutationObserverRegistration.h:
  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::namedFlows):

  • dom/NamedFlowCollection.h:
  • dom/Node.cpp:

(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

  • dom/Node.h:
  • dom/NodeRareData.h:
  • dom/Range.cpp:

(WebCore::Range::processContents):
(WebCore::Range::processNodes):
(WebCore::Range::processAncestorsAndTheirSiblings):

  • dom/Range.h:
  • dom/ScopedEventQueue.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::reportException):

  • dom/ScriptExecutionContext.h:
  • dom/ScriptedAnimationController.h:
  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

  • editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::removeChildrenInRange):
(WebCore::CompositeEditCommand::deleteInsignificantText):
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

  • editing/CompositeEditCommand.h:
  • editing/EditingStyle.cpp:

(WebCore::htmlElementEquivalents):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement):
(WebCore::htmlAttributeEquivalents):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes):
(WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::styleFromMatchedRulesForElement):

  • editing/Editor.cpp:

(WebCore::Editor::countMatchesForText):

  • editing/Editor.h:
  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::getAncestorsInsideBlock):
(WebCore::InsertParagraphSeparatorCommand::cloneHierarchyUnderNewBlock):
(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.h:
  • editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doApply):
(WebCore::MergeIdenticalElementsCommand::doUnapply):

  • editing/RemoveNodePreservingChildrenCommand.cpp:

(WebCore::RemoveNodePreservingChildrenCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes):

  • editing/SimplifyMarkupCommand.cpp:

(WebCore::SimplifyMarkupCommand::doApply):
(WebCore::SimplifyMarkupCommand::pruneSubsequentAncestorsToRemove):

  • editing/SimplifyMarkupCommand.h:
  • editing/SpellChecker.h:
  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::executeApply):
(WebCore::SplitElementCommand::doUnapply):

  • editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::executeApply):
(WebCore::WrapContentsInDummySpanCommand::doUnapply):

  • editing/mac/AlternativeTextUIController.h:
  • fileapi/FileList.h:
  • history/BackForwardList.h:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::setRedirectURLs):

  • history/HistoryItem.h:
  • history/mac/HistoryItemMac.mm:

(WebCore::HistoryItem::setTransientProperty):

  • html/FormController.h:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::append):

  • html/HTMLCollection.h:
  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::checkValidity):

  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::checkValidity):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):

  • html/HTMLFormElement.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
(WebCore::HTMLMediaElement::platformTextTracks):
(WebCore::HTMLMediaElement::configureTextTrackGroup):

  • html/HTMLMediaElement.h:
  • html/HTMLPlugInImageElement.cpp:
  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setLength):

  • html/MediaController.cpp:

(MediaController::asyncEventTimerFired):

  • html/MediaController.h:
  • html/MediaFragmentURIParser.h:
  • html/ValidationMessage.h:
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getAttachedShaders):

  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLTexture.h:
  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):

  • html/parser/BackgroundHTMLParser.h:

(WebCore::BackgroundHTMLParser::create):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::startBackgroundParser):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLMetaCharsetParser.h:
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):

  • html/parser/HTMLResourcePreloader.h:
  • html/parser/XSSAuditor.h:
  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ensureInsertionPointList):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):

  • html/shadow/ContentDistributor.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu):
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

  • html/shadow/MediaControlElements.h:
  • html/track/InbandGenericTextTrack.h:
  • html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed):

  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::newCuesAvailable):
(WebCore::LoadableTextTrack::newRegionsAvailable):

  • html/track/TextTrackCueList.h:
  • html/track/TextTrackList.cpp:

(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::remove):
(TextTrackList::contains):

  • html/track/TextTrackList.h:
  • html/track/TrackListBase.cpp:

(TrackListBase::asyncEventTimerFired):

  • html/track/TrackListBase.h:
  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::getNewCues):
(WebCore::WebVTTParser::getNewRegions):

  • html/track/WebVTTParser.h:
  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::addToFrontend):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::lineEndings):
(WebCore::ContentSearchUtils::searchInTextByLines):

  • inspector/ContentSearchUtils.h:
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchNode):
(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):

  • inspector/DOMPatchSupport.h:
  • inspector/InjectedScript.cpp:

(WebCore::InjectedScript::getProperties):
(WebCore::InjectedScript::getInternalProperties):
(WebCore::InjectedScript::wrapCallFrames):

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptHost.h:
  • inspector/InspectorAgent.cpp:

(WebCore::InspectorAgent::enable):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorBaseAgent.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::SelectorProfile::toInspectorObject):
(WebCore::UpdateRegionLayoutTask::onTimer):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::getComputedStyleForNode):
(WebCore::InspectorCSSAgent::getAllStyleSheets):
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
(WebCore::InspectorCSSAgent::buildArrayForMatchedRuleList):
(WebCore::InspectorCSSAgent::buildArrayForRegions):
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::RevalidateStyleAttributeTask::onTimer):
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
(WebCore::InspectorDOMAgent::pushNodePathToFrontend):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::getAttributes):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::buildArrayForElementAttributes):
(WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::currentCallFrames):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorHeapProfilerAgent.cpp:

(WebCore::InspectorHeapProfilerAgent::getProfileHeaders):

  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorHistory.h:
  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderObjectHierarchy):
(WebCore::InspectorLayerTreeAgent::gatherLayersUsingRenderLayerHierarchy):

  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::buildArrayForCookies):
(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::searchInResource):
(WebCore::InspectorPageAgent::searchInResources):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getProfileHeaders):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::getProperties):

  • inspector/InspectorRuntimeAgent.h:
  • inspector/InspectorState.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::styleWithProperties):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::lineEndings):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings):

  • inspector/InspectorStyleSheet.h:
  • inspector/InspectorValues.cpp:

(WebCore::InspectorArrayBase::writeJSON):

  • inspector/InspectorValues.h:
  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::reportExecutionContextCreation):

  • inspector/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::buildInspectorArray):

  • inspector/ScriptCallStack.h:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentLoader.cpp:

(WebCore::cancelAll):
(WebCore::setAllDefersLoading):
(WebCore::DocumentLoader::getSubresources):

  • loader/DocumentLoader.h:
  • loader/FormState.h:
  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/ProgressTracker.h:
  • loader/ResourceLoadScheduler.h:
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::getNewCues):
(WebCore::TextTrackLoader::getNewRegions):

  • loader/TextTrackLoader.h:
  • loader/WorkerThreadableLoader.cpp:

(WebCore::workerGlobalScopeDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):
(WebCore::ApplicationCache::dump):

  • loader/appcache/ApplicationCache.h:
  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::getOriginsWithCache):

  • loader/archive/Archive.cpp:

(WebCore::Archive::clearAllSubframeArchives):
(WebCore::Archive::clearAllSubframeArchivesImpl):

  • loader/archive/Archive.h:

(WebCore::Archive::subresources):
(WebCore::Archive::subframeArchives):

  • loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::addAllResources):

  • loader/archive/ArchiveResourceCollection.h:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

  • loader/archive/cf/LegacyWebArchive.h:
  • loader/archive/mhtml/MHTMLParser.h:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.h:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::notifyPendingLoadDecisions):

  • loader/icon/IconDatabase.h:
  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu):

  • page/CaptionUserPreferencesMediaAF.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::didAssociateFormControls):

  • page/Console.h:
  • page/ContentSecurityPolicy.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules):

  • page/DeviceController.cpp:

(WebCore::DeviceController::dispatchDeviceEvent):
(WebCore::DeviceController::fireDeviceEvent):

  • page/DeviceController.h:
  • page/EditorClient.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::handleTouchEvent):

  • page/EventHandler.h:
  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

  • page/Page.cpp:

(WebCore::Page::findStringMatchingRanges):

  • page/Page.h:
  • page/PageGroup.h:
  • page/Performance.cpp:

(WebCore::Performance::webkitGetEntriesByType):
(WebCore::Performance::webkitGetEntriesByName):

  • page/Performance.h:
  • page/PerformanceEntryList.cpp:

(WebCore::PerformanceEntryList::appendAll):

  • page/PerformanceEntryList.h:
  • page/SecurityOriginHash.h:
  • page/SecurityPolicy.cpp:
  • page/SpeechInputResult.h:
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

  • page/animation/AnimationControllerPrivate.h:
  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • page/animation/CompositeAnimation.h:
  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::appendChild):

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::children):

  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

  • page/scrolling/ScrollingThread.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::appendChild):

  • page/scrolling/ScrollingTreeNode.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::syncChildPositions):

  • platform/CrossThreadCopier.cpp:
  • platform/CrossThreadCopier.h:
  • platform/DragData.h:
  • platform/MainThreadTask.h:
  • platform/PODFreeListArena.h:

(WebCore::PODFreeListArena::freeObject):
(WebCore::PODFreeListArena::allocate):

  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree):

  • platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::voiceList):

  • platform/PlatformSpeechSynthesizer.h:
  • platform/RunLoop.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::frameRectsChanged):
(WebCore::ScrollView::clipRectChanged):
(WebCore::ScrollView::setParentVisible):
(WebCore::ScrollView::show):
(WebCore::ScrollView::hide):

  • platform/ScrollView.h:
  • platform/SharedBuffer.h:
  • platform/Supplementable.h:

(WebCore::Supplement::provideTo):
(WebCore::Supplementable::provideSupplement):

  • platform/URL.cpp:

(WebCore::findHostnamesInMailToURL):
(WebCore::encodeHostnames):

  • platform/audio/AudioBus.h:
  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/AudioResampler.h:
  • platform/audio/DynamicsCompressor.h:
  • platform/audio/DynamicsCompressorKernel.h:
  • platform/audio/HRTFDatabase.h:
  • platform/audio/HRTFKernel.h:
  • platform/audio/MultiChannelResampler.h:
  • platform/audio/Reverb.h:
  • platform/audio/ReverbConvolver.h:
  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::copySomeDataFromDataArray):

  • platform/graphics/FloatPolygon.cpp:

(WebCore::FloatPolygon::FloatPolygon):

  • platform/graphics/FloatPolygon.h:
  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::getCachedFontData):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/GlyphMetricsMap.h:

(WebCore::::locatePageSlowCase):

  • platform/graphics/GlyphPageTreeNode.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/PlatformTextTrackMenu.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/WidthCache.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
(WebCore::GraphicsLayerCA::fetchCloneLayers):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/LayerPool.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(PlatformCAAnimation::setValues):

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/cg/SubimageCacheWithTimer.h:
  • platform/graphics/filters/CustomFilterParameterList.h:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/FilterOperations.h:

(WebCore::FilterOperations::operations):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::Texture):
(WebCore::Texture::create):

  • platform/graphics/gpu/Texture.h:
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/transforms/TransformOperations.h:

(WebCore::TransformOperations::operations):

  • platform/ios/PasteboardIOS.mm:

(WebCore::documentFragmentWithRTF):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):

  • platform/mediastream/MediaStreamDescriptor.h:
  • platform/mediastream/MediaStreamSource.h:
  • platform/mediastream/RTCConfiguration.h:
  • platform/network/BlobRegistryImpl.h:
  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::parseCacheHeader):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::clientCerts):
(WebCore::ResourceHandle::createCFURLConnection):

  • platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForNullKey):
(WebCore::::createValueForKey):
(WebCore::cfLocaleCache):

  • plugins/PluginMainThreadScheduler.h:
  • rendering/HitTestResult.h:
  • rendering/InlineFlowBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):

  • rendering/RenderBlock.h:
  • rendering/RenderButton.h:
  • rendering/RenderCounter.cpp:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator):

  • rendering/RenderGrid.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
(WebCore::RenderLayer::rebuildZOrderLists):
(WebCore::RenderLayer::collectLayers):

  • rendering/RenderLayer.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::getRanges):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::setSelection):

  • rendering/RootInlineBox.h:
  • rendering/shapes/PolygonShape.cpp:

(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):

  • rendering/shapes/PolygonShape.h:

(WebCore::PolygonShape::PolygonShape):

  • rendering/shapes/Shape.cpp:

(WebCore::createPolygonShape):
(WebCore::Shape::createShape):

  • rendering/shapes/ShapeInfo.h:
  • rendering/shapes/ShapeInterval.h:
  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::create):
(WebCore::QuotesData::QuotesData):

  • rendering/style/QuotesData.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::requireTransformOrigin):
(WebCore::RenderStyle::applyTransform):

  • rendering/style/StyleGridData.h:
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/SVGResourcesCache.h:
  • storage/StorageEventDispatcher.cpp:

(WebCore::StorageEventDispatcher::dispatchSessionStorageEvents):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEvents):
(WebCore::StorageEventDispatcher::dispatchSessionStorageEventsToFrames):
(WebCore::StorageEventDispatcher::dispatchLocalStorageEventsToFrames):

  • storage/StorageEventDispatcher.h:
  • storage/StorageNamespaceImpl.h:
  • storage/StorageThread.h:
  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::origins):

  • storage/StorageTracker.h:
  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):

  • svg/SVGAnimatedTypeAnimator.cpp:

(WebCore::SVGElementAnimatedProperties::SVGElementAnimatedProperties):
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):

  • svg/SVGAnimatedTypeAnimator.h:
  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::setOfElementsReferencingTarget):
(WebCore::SVGDocumentExtensions::addElementReferencingTarget):
(WebCore::SVGDocumentExtensions::rebuildAllElementReferencesForTarget):

  • svg/SVGDocumentExtensions.h:
  • svg/SVGFontElement.h:
  • svg/SVGGlyphMap.h:
  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::orientTypeAnimated):

  • svg/SVGMarkerElement.h:
  • svg/SVGPathSegList.h:
  • svg/animation/SMILTimeContainer.h:
  • svg/graphics/SVGImageCache.h:
  • svg/graphics/filters/SVGFilterBuilder.h:

(WebCore::SVGFilterBuilder::addBuiltinEffects):

  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:

(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::create):

  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::create):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::create):

  • svg/properties/SVGAttributeToPropertyMap.cpp:

(WebCore::SVGAttributeToPropertyMap::animatedPropertiesForAttribute):

  • svg/properties/SVGAttributeToPropertyMap.h:
  • svg/properties/SVGStaticListPropertyTearOff.h:

(WebCore::SVGStaticListPropertyTearOff::create):

  • svg/properties/SVGTransformListPropertyTearOff.h:

(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):

  • workers/DefaultSharedWorkerRepository.h:
  • workers/WorkerMessagingProxy.h:
  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):

  • xml/XMLHttpRequestProgressEventThrottle.h:
  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::sort):
(WebCore::XPath::NodeSet::traversalSort):

  • xml/XSLStyleSheet.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/mac:

  • History/WebHistory.mm:

(-[WebHistoryPrivate rebuildHistoryByDayIfNeeded:]):

  • History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]):

  • Plugins/Hosted/NetscapePluginHostProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::retain):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::release):
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget):
(WebKit::NetscapePluginInstanceProxy::stopAllStreams):

  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView destroyPlugin]):

  • Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager origins]):

  • Storage/WebStorageManager.mm:

(-[WebStorageManager origins]):

  • WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache originsWithCache]):

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::getClientPasteboardDataForRange):
(WebEditorClient::documentFragmentFromAttributedString):

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::show):
(WebNotificationClient::clearNotifications):

  • WebView/WebArchive.mm:

(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive subresources]):
(-[WebArchive subframeArchives]):

  • WebView/WebDataSource.mm:

(-[WebDataSource subresources]):

  • WebView/WebViewData.h:

Source/WebKit2:

  • UIProcess/mac/WebColorPickerMac.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setProcessSuppressionEnabled):

Source/WTF:

  • wtf/AVLTree.h:
  • wtf/CheckedArithmetic.h:
  • wtf/Compression.h:
  • wtf/Functional.h:

(WTF::R):

  • wtf/HashFunctions.h:
  • wtf/HashIterators.h:
  • wtf/HashSet.h:

(WTF::::contains):

  • wtf/ListHashSet.h:

(WTF::::contains):

  • wtf/RefCountedLeakCounter.cpp:
  • wtf/RetainPtr.h:
  • wtf/SentinelLinkedList.h:

(WTF::::remove):

  • wtf/SizeLimits.cpp:
  • wtf/StreamBuffer.h:
  • wtf/Vector.h:
  • wtf/VectorTraits.h:
  • wtf/WeakPtr.h:

(WTF::WeakReference::create):
(WTF::WeakReference::createUnbound):
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtrFactory::WeakPtrFactory):

  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::add):
(WTF::findString):

  • wtf/text/StringConcatenate.h:
  • wtf/text/StringImpl.h:
  • wtf/text/StringOperators.h:

(WTF::operator+):

4:35 PM Changeset in webkit [157652] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleaning warning messages from StyleResolveTree
​https://bugs.webkit.org/show_bug.cgi?id=123030

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-10-18
Reviewed by Andreas Kling.

No new tests needed.

  • style/StyleResolveTree.cpp:

(WebCore::Style::elementInsideRegionNeedsRenderer):
(WebCore::Style::createRendererIfNeeded):

4:23 PM Changeset in webkit [157651] by beidson@apple.com
  • 13 edits in trunk/Source

Get rid of IDBFactoryBackendLevelDB and IDBTransactionBackendLevelDB in IDBDatabaseBackendLevelDB.
​https://bugs.webkit.org/show_bug.cgi?id=123039

Reviewed by Anders Carlsson.

Source/WebCore:

Add a few concepts to the interfaces to make this work:

  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(WebCore::IDBTransactionBackendInterface::id):
(WebCore::IDBTransactionBackendInterface::IDBTransactionBackendInterface):

Adapt to using Interface ptr’s instead of LevelDB ptr’s:

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::create):
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::createObjectStore):
(WebCore::IDBDatabaseBackendLevelDB::deleteObjectStore):
(WebCore::IDBDatabaseBackendLevelDB::createIndex):
(WebCore::IDBDatabaseBackendLevelDB::deleteIndex):
(WebCore::IDBDatabaseBackendLevelDB::get):
(WebCore::IDBDatabaseBackendLevelDB::put):
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::setIndexesReady):
(WebCore::IDBDatabaseBackendLevelDB::openCursor):
(WebCore::IDBDatabaseBackendLevelDB::count):
(WebCore::IDBDatabaseBackendLevelDB::deleteRange):
(WebCore::IDBDatabaseBackendLevelDB::clear):
(WebCore::IDBDatabaseBackendLevelDB::transactionStarted):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinished):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackendLevelDB::transactionFinishedAndCompleteFired):
(WebCore::IDBDatabaseBackendLevelDB::runIntVersionChangeTransaction):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:

(WebCore::IDBObjectStoreBackendLevelDB::makeIndexWriters):

  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:

(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::abort):
(WebCore::IDBTransactionBackendLevelDB::commit):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::removeIDBDatabaseBackend): Stub out this new interface method.

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
3:57 PM Changeset in webkit [157650] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Remove excess reserved space in ctiTrampoline frames for X86 and X86_64.
​https://bugs.webkit.org/show_bug.cgi?id=123037.

Reviewed by Geoffrey Garen.

  • jit/JITStubsMSVC64.asm:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
2:41 PM Changeset in webkit [157649] by Alexandru Chiculita
  • 9 edits
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: CSS Regions: Add the list of flows in the FrameTreeElement
​https://bugs.webkit.org/show_bug.cgi?id=122924

Reviewed by Timothy Hatcher.

Added code to collect the flows from the backend into the DOMTree object
on the frontend. Added ContentFlow to represent the flows on the frontend
side and created ContentFlowTreeElement to display the flows in the FrameTreeElement.

  • Localizations/en.lproj/localizedStrings.js:
  • Scripts/copy-user-interface-resources.sh:
  • UserInterface/CSSObserver.js:

(WebInspector.CSSObserver.prototype.namedFlowCreated):
(WebInspector.CSSObserver.prototype.namedFlowRemoved):
(WebInspector.CSSObserver.prototype.regionLayoutUpdated):
(WebInspector.CSSObserver.prototype.regionOversetChanged):

  • UserInterface/ContentFlow.js: Added.

(WebInspector.ContentFlow):
(WebInspector.ContentFlow.prototype.get id):
(WebInspector.ContentFlow.prototype.get documentNodeIdentifier):
(WebInspector.ContentFlow.prototype.get name):
(WebInspector.ContentFlow.prototype.get overset):
(WebInspector.ContentFlow.prototype.set overset):

  • UserInterface/ContentFlowIcon.css: Added.

(.content-flow-icon .icon):

  • UserInterface/ContentFlowTreeElement.js: Added.

(WebInspector.ContentFlowTreeElement):

  • UserInterface/DOMTree.js:

(WebInspector.DOMTree):
(WebInspector.DOMTree.prototype.get flowMap):
(WebInspector.DOMTree.prototype.get flowsCount):
(WebInspector.DOMTree.prototype._framePageExecutionContextChanged):
(WebInspector.DOMTree.prototype.requestContentFlowList):
(WebInspector.DOMTree.prototype._isContentFlowInCurrentDocument):
(WebInspector.DOMTree.prototype._contentFlowListWasUpdated):
(WebInspector.DOMTree.prototype._contentFlowWasAdded):
(WebInspector.DOMTree.prototype._contentFlowWasRemoved):

  • UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager._flowPayloadHashKey):
(WebInspector.DOMTreeManager.prototype._buildHighlightConfig):
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
(WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
(WebInspector.DOMTreeManager.prototype.namedFlowCreated):
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
(WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):
(WebInspector.DOMTreeManager.prototype.regionLayoutUpdated):
(WebInspector.DOMTreeManager.prototype.regionOversetChanged):

  • UserInterface/FrameTreeElement.js:

(WebInspector.FrameTreeElement):
(WebInspector.FrameTreeElement.prototype.onpopulate):
(WebInspector.FrameTreeElement.prototype.onexpand):
(WebInspector.FrameTreeElement.prototype._childContentFlowWasAdded):
(WebInspector.FrameTreeElement.prototype._childContentFlowWasRemoved):
(WebInspector.FrameTreeElement.prototype._rootDOMNodeInvalidated):
(WebInspector.FrameTreeElement.prototype._addChildForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._removeChildForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._addTreeElementForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._compareResourceTreeElements):
(WebInspector.FrameTreeElement.prototype._insertResourceTreeElement):
(WebInspector.FrameTreeElement.prototype._parentTreeElementForRepresentedObject):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):

  • UserInterface/Images/ContentFlow.svg: Added.
  • UserInterface/Main.html:
  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):

2:09 PM Changeset in webkit [157648] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] WKBrowsingController accessors crash instead of returning nil
​https://bugs.webkit.org/show_bug.cgi?id=123036

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(autoreleased): Return nil if the object is NULL.

1:53 PM Changeset in webkit [157647] by dino@apple.com
  • 4 edits
    4 adds in trunk

Unable to upload <img src="foo.svg"> as WebGL texture
​https://bugs.webkit.org/show_bug.cgi?id=123035

Reviewed by Tim Horton.

Source/WebCore:

If the HTMLImageElement passed to texture2D is an SVG
image, paint it first into a bitmap buffer and upload that.
Note that the SVG image still needs to have an intrinsic
or explicit size - see how the test case must set width and
height.

I also renamed the cache of ImageBuffers since it is
no longer only being used for video frames.

Test: fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext): Rename m_videoCache to m_generatedImageCache.
(WebCore::WebGLRenderingContext::drawImageIntoBuffer): New method that creates an ImageBuffer
of the appropriate size and renders into that.
(WebCore::WebGLRenderingContext::texImage2D): If we see an SVG image, render it first.
(WebCore::WebGLRenderingContext::videoFrameToImage): Renamed m_generatedImageCache.
(WebCore::WebGLRenderingContext::texSubImage2D): If we see an SVG image, render it first.

  • html/canvas/WebGLRenderingContext.h: Renaming.

LayoutTests:

Test that creates an HTMLImageElement, sets its source
to an SVG file, and then uploads as a WebGLTexture. Based
on the existing WebGL conformance tests.

  • fast/canvas/webgl/resources/red-green.svg: Added.
  • fast/canvas/webgl/resources/tex-image-and-sub-image-2d-with-svg-image.js: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image-expected.txt: Added.
  • fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html: Added.
1:28 PM Changeset in webkit [157646] by cabanier@adobe.com
  • 2 edits in trunk/Tools

Add Rik Cabanier to list of committers
​https://bugs.webkit.org/show_bug.cgi?id=123031

reviewed by Dirk Schulze.

  • Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
1:21 PM Changeset in webkit [157645] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Frequent RELEASE_ASSERT crashes in Structure::checkOffsetConsistency on WebGL swizzler tests
​https://bugs.webkit.org/show_bug.cgi?id=121661

Reviewed by Mark Hahnenberg.

This method shouldn't have been called from the concurrent JIT thread. That's hard to prevent
so I added a return-early check using isCompilationThread().

Here's why this makes sense. Structure has two ways to tell you about the layout of the objects
it is describing: m_offset and the property table. Most structures only have m_offset and report
null for the property table. If the property table is there, it will tell you additional
information and that information subsumes m_offset - but the m_offset is still there. So, when
we have a property table, we have to keep it in sync with the m_offset. There is a bunch of
machinery to do this.

Changing the property table only happens on the main thread.

Because the machinery to change the property table is so complex, especially with respect to
keeping it in sync with m_offset, we have the checkOffsetConsistency method. It's meant to be
called at key points before and after changes to the property table or the offset.

Most clients of Structure who care about object layout, including the concurrent thread, will
want to know m_offset and not the property table. If they want the property table, they will
already be super careful. The concurrent thread has special methods for this, like
Structure::getConcurrently(), which uses fine-grained locking to ensure that it sees a coherent
view of the property table.

Adding locking to checkOffsetConsistency() is probably a bad idea since that method may be
called when the relevant lock is already held. So, we'd have awkward recursive locking issues.

But right now, the concurrent JIT thread may call a method, like Structure::outOfLineCapacity(),
which has a call to checkOffsetConsistency(). The call to checkOffsetConsistency() is there
because we have found that it helps quickly identify situations where the property table and
m_offset get out of sync - mainly because code that changes either of those things will usually
also want to know the outOfLineCapacity(). But Structure::outOfLineCapacity() doesn't *actually*
need the property table; it uses the m_offset. The concurrent JIT is correct to call
outOfLineCapacity(), and is right to do so without holding any locks (since in all cases where
it calls outOfLineCapacity() it has already proven that m_offset is immutable). But because
outOfLineCapacity() calls checkOffsetConsistency(), and checkOffsetConsistency() doesn't grab
locks, and that same structure is having its property table modified by the main thread, we end
up with these spurious assertion failures. FWIW, the structure isn't *actually* having *its*
property table modified - instead what happens is that some downstream structure steals the
property table and then starts adding things to it. The concurrent thread loads the property
table before it's stolen, and hence the badness.

I suspect there are other code paths that lead to the concurrent JIT calling some Structure
method that it is fine and safe to call, but then that method calls checkOffsetConsistency(),
and then you have a possible crash.

The most sensible solution to this appears to be to make sure that checkOffsetConsistency() is
aware of its uselessness to the concurrent JIT thread. This change makes it return early if
it's in the concurrent JIT.

  • runtime/StructureInlines.h:

(JSC::Structure::checkOffsetConsistency):

1:19 PM Changeset in webkit [157644] by beidson@apple.com
  • 10 edits
    3 adds in trunk/Source/WebCore

[GTK] Generate API documentation for GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=121538

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-10-18
Reviewed by Gustavo Noronha Silva.

  • GNUmakefile.am: Initialize gdom_symbol_files variable.
12:17 PM Changeset in webkit [157643] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Remove some Windows specific code from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=123034

Reviewed by Beth Dakin.

  • Platform/PlatformProcessIdentifier.h:
  • Shared/API/c/WKDeclarationSpecifiers.h:
  • UIProcess/API/C/WKNativeEvent.h:
  • UIProcess/API/C/WKPreferencesPrivate.h:
  • config.h:
12:11 PM Changeset in webkit [157642] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

Rubber-banding is often not smooth on infinitely scrolling websites
​https://bugs.webkit.org/show_bug.cgi?id=122985

Reviewed by Simon Fraser.

totalContentsSize is an important part of the calculation for
maximumScrollPosition(). This function is called repeatedly throughout the curve
of a rubber-band to determine the stretch amount. To keep the rubber-band
animation smooth, it should be allowed to finish its animation using the old
totalContentsSize. This patch does that by adding a new variable,
m_totalContentsSizeForRubberBand. This value should almost always be equivalent to
m_totalContentsSize. It will only vary if m_totalContentsSize has changed in the
middle of a rubber-band, and in that case, it will stay equivalent to the old
totalContentSize value until the rubber band animation finishes.

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

  • page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::totalContentsSizeForRubberBand):
(WebCore::ScrollingTreeScrollingNode::setTotalContentsSizeForRubberBand):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::stopSnapRubberbandTimer):
(WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):

10:22 AM Changeset in webkit [157641] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add SPI to disable the garbage collector timer
​https://bugs.webkit.org/show_bug.cgi?id=122921

Add null check to Heap::setGarbageCollectionTimerEnabled() that I inadvertently
omitted.

  • heap/Heap.cpp:

(JSC::Heap::setGarbageCollectionTimerEnabled):

10:11 AM Changeset in webkit [157640] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Mixed content error when accessing webkit.org/team.html over https
​https://bugs.webkit.org/show_bug.cgi?id=123020

Patch by Tibor Meszaros <​tmeszaros@inf.u-szeged.hu> on 2013-10-18
Reviewed by Alexey Proskuryakov.

When the webkit.org/team.html page is accessed over https most browsers report
Mixed Content error, which is caused by the fact that the contributos.json file
is accessed over a plain http connection and not https.

  • team.html:
10:03 AM Changeset in webkit [157639] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Group 64-bit specific and 32-bit specific callOperation implementations.
​https://bugs.webkit.org/show_bug.cgi?id=123024

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-18
Reviewed by Michael Saboff.

This is not a big deal, but could be less confusing when reading the code.

  • jit/JITInlines.h:

(JSC::JIT::callOperation):
(JSC::JIT::callOperationWithCallFrameRollbackOnException):
(JSC::JIT::callOperationNoExceptionCheck):

10:03 AM Changeset in webkit [157638] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Cleanup webkit.org/team.html
​https://bugs.webkit.org/show_bug.cgi?id=123022

Patch by Tibor Meszaros <​tmeszaros@inf.u-szeged.hu> on 2013-10-18
Reviewed by Alexey Proskuryakov.

Removed the annoteWithWikiData function, because data it tries to fetch does not exists.

  • team.html:
9:55 AM Changeset in webkit [157637] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Fix a FlushLiveness problem.
​https://bugs.webkit.org/show_bug.cgi?id=122984

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-18
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • dfg/DFGFlushLivenessAnalysisPhase.cpp:

(JSC::DFG::FlushLivenessAnalysisPhase::process):

LayoutTests:

  • js/regress/script-tests/stepanov_container.js: Added.
  • js/regress/stepanov_container-expected.txt: Added.
  • js/regress/stepanov_container.html: Added.
9:25 AM Changeset in webkit [157636] by msaboff@apple.com
  • 26 edits in trunk/Source/JavaScriptCore

Change native function call stubs to use JIT operations instead of ctiVMHandleException
​https://bugs.webkit.org/show_bug.cgi?id=122982

Reviewed by Geoffrey Garen.

Change ctiVMHandleException to operationVMHandleException. Change all exception operations to
return the catch callFrame and entryPC via vm.callFrameForThrow and vm.targetMachinePCForThrow.
This removed calling convention headaches, fixing ​https://bugs.webkit.org/show_bug.cgi?id=122980
in the process.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JIT.h:
  • jit/JITExceptions.cpp:

(JSC::genericUnwind):

  • jit/JITExceptions.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperationNoExceptionCheck):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_throw):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_throw):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARM64.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsMIPS.h:
  • jit/JITStubsMSVC64.asm:
  • jit/JITStubsSH4.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
  • jit/Repatch.cpp:

(JSC::tryBuildGetByIDList):

  • jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

  • jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):

  • runtime/VM.h:

(JSC::VM::callFrameForThrowOffset):
(JSC::VM::targetMachinePCForThrowOffset):

9:06 AM Changeset in webkit [157635] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Removed the MAC_OS_X_VERSION_MIN_REQUIRED condition from the definition of WK_API_ENABLED.

Rubber-stamped by Anders Carlsson.

  • Shared/API/Cocoa/WKFoundation.h:
9:05 AM Changeset in webkit [157634] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for --no-svg option.
m_svgStyle of RenderStyle is guarded with the ENABLE_SVG flag.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::RenderStyle):

8:23 AM Changeset in webkit [157633] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix J_JITOperation_EAapJ call for MIPS and ARM EABI.
​https://bugs.webkit.org/show_bug.cgi?id=123023

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-18
Reviewed by Michael Saboff.

  • jit/JITInlines.h:

(JSC::JIT::callOperation): EncodedJSValue parameter do not need alignment
using EABI_32BIT_DUMMY_ARG here.

7:52 AM Changeset in webkit [157632] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Cleanup the Modules group in the WebCore.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=123009

Rubberstamped by Antti Koivisto.

  • WebCore.xcodeproj/project.pbxproj:
6:07 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
5:01 AM QtWebKitGardening edited by zarvai@inf.u-szeged.hu
(diff)
4:40 AM WebKitGTK/2.2.x edited by mario@webkit.org
(diff)
4:26 AM Changeset in webkit [157631] by commit-queue@webkit.org
  • 5 edits in trunk

[ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
​https://bugs.webkit.org/show_bug.cgi?id=122970

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-10-18
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Removed an invalid signal to set objects to an unknown state
layout-complete. This signal was originally generated to notify DRT
and WKTR in case of page load complete.
It was replaced by ATK:AtkDocument:load-complete, which is already sent
by AXObjectCache::frameLoadingEventPlatformNotification().

There is no new test since the changes are covered by existing ones
(e.g. accessibility/loading-iframe-sends-notification.html).

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Removed an invalid
signal to set objects to an unknown state layout-complete.

Tools:

Removed an invalid signal to set an object state to layout-complete
that does not exist. It was replaced by ATK:AtkDocument:load-complete.

  • DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:

(axObjectEventListener): Replaced layout-complete with load-complete.
(connectAccessibilityCallbacks): Connect callback to new listener for
ATK:AtkDocument:load-complete.
(disconnectAccessibilityCallbacks): Disconnect callback to new listener
for ATK:AtkDocument:load-complete.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(axObjectEventListener): Replaced layout-complete with load-complete.
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
Connect callback to new listener for ATK:AtkDocument:load-complete.
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
Disconnect callback to new listener for ATK:AtkDocument:load-complete.

3:33 AM Changeset in webkit [157630] by Carlos Garcia Campos
  • 7 edits
    1 add in trunk

[GTK] Generate API documentation for GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=121538

Reviewed by Gustavo Noronha Silva.

.:

  • GNUmakefile.am: Initialize gdom_symbol_files variable.

Source/WebCore:

  • bindings/gobject/GNUmakefile.am: Add a explicit rule for all

.symbols file making them depend on the corresponding header file,
since the .symbols file is generated by the bindings generator.

Tools:

The .symbols file that is now generated for checking GObject DOM
bindings API compatibility while building can also be used to
generate the files needed to produce the gtk-doc
documentation. The new script generate-webkitdom-doc-files can
generate the docs.sgml and sections.txt files from the given list
of .symbols files.

  • gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml

and webkitdomgtk-sections.txt as well as rules to install the
generated WebKitDOMGTK documentation.

  • gtk/generate-gtkdoc:

(webkitdom_docs_html_path): New helper function that returns the
path where the DOM API documentation has been generated.
(get_webkit2_options): Include DOM API docs to the list of xref
dependencies.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Return the gtk-doc options to generate
the DOM API docs.
(get_webkitdom_options.derived_sources_path):
(get_webkitdom_options.src_path):

  • gtk/generate-webkitdom-doc-files: Added.

(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.write_header):
(WebKitDOMDocGenerator.write_section):
(WebKitDOMDocGenerator.write_footer):
(WebKitDOMDocGeneratorDocs):
(WebKitDOMDocGeneratorDocs.write_header):
(write_section):
(write_footer):
(WebKitDOMDocGeneratorSections):
(WebKitDOMDocGeneratorSections.init):
(WebKitDOMDocGeneratorSections._dom_class):
(WebKitDOMDocGeneratorSections._dom_class_decamelize):
(WebKitDOMDocGeneratorSections._symbol_list):
(WebKitDOMDocGeneratorSections.write_section):

3:21 AM Changeset in webkit [157629] by jinwoo7.song@samsung.com
  • 8 edits
    1 add in trunk/LayoutTests

Unreviewed EFL gardening.

  • platform/efl-wk2/TestExpectations: Remove passing testcase.
  • platform/efl/TestExpectations: fast/backgrounds/background-opaque-images-over-color.html is failing.
  • platform/efl/fast/dom/Range/getClientRects-expected.txt: Rebaseline after r152872.
  • platform/efl/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Rebaseline after r152793.
  • platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Added.
  • platform/efl/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Rebaseline after r152911.
  • platform/efl/tables/mozilla/marvin/backgr_index-expected.png: Rebaseline after r152793.
  • platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Rebaseline after r152793.
3:15 AM Changeset in webkit [157628] by mario@webkit.org
  • 3 edits in trunk/Source/WebCore

[ATK] Simplify implementation of atk_text_get_text
​https://bugs.webkit.org/show_bug.cgi?id=122644

Reviewed by Chris Fleizach.

Simplified code so we only call textUnderElement() directly once
and only when needed. Also, moved the specific code for ColorWell
objects up to the beginning of that function, so we don't do any
additional efforts like computing text ranges in those cases.

No new tests are needed, just to make sure that the current layout
and unit tests are still passing, which they are.

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(textForObject): Fixed a issue that got detected while working on
this patch, which was causing a '\n' to be artificially appended
at the end of text controls all the time.
(webkitAccessibleTextGetText): Simplified function.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::doAXStringForRange): Removed
the check that prevents from pass ranges exceeding the limits of
the element's text, since those will be checked anyway when
calling String::substring().

2:17 AM Changeset in webkit [157627] by jinwoo7.song@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r153852.

  • platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt:
  • platform/efl/security/block-test-no-port-expected.txt:
12:37 AM Changeset in webkit [157626] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/W3C/audio/networkState/networkState_during_loadstart.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=123010

  • platform/mac/TestExpectations: Marked as such.
12:29 AM Changeset in webkit [157625] by ap@apple.com
  • 2 edits in trunk/LayoutTests

css3/filters/composited-during-animation-layertree.html sometimes produces empty results
​https://bugs.webkit.org/show_bug.cgi?id=95622

  • platform/mac/TestExpectations: Marking as flaky.
12:17 AM Changeset in webkit [157624] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[GStreamer][GTK] Add GRefPtr::outPtr()
​https://bugs.webkit.org/show_bug.cgi?id=122996

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-10-18
Reviewed by Philippe Normand.

Source/WebCore:

No new tests because this is just simplifying existing code.

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Add GRefPtr specialization for GstToc.
  • platform/graphics/gstreamer/GRefPtrGStreamer.h: Same.
  • platform/graphics/gstreamer/GStreamerGWorld.cpp: Use GRefPtr::outPtr() to simplify code.

(WebCore::GStreamerGWorld::enterFullscreen):
(WebCore::GStreamerGWorld::exitFullscreen):
(WebCore::GStreamerGWorld::removePlatformVideoSink):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Same.

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
(WebCore::MediaPlayerPrivateGStreamer::newTextSample):
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp: Same.

(WebCore::MediaPlayerPrivateGStreamerBase::currentVideoSinkCaps):

  • platform/network/soup/ResourceHandleSoup.cpp: Same.

(WebCore::HostTLSCertificateSet::computeCertificateHash):

Source/WTF:

  • wtf/gobject/GRefPtr.h:

(WTF::GRefPtr::outPtr): Added.

Oct 17, 2013:

10:23 PM Changeset in webkit [157623] by timothy_horton@apple.com
  • 7 edits
    2 adds in trunk/Source/WebKit2

Remote Layer Tree: Proxy layer contents to the UI process
​http://bugs.webkit.org/show_bug.cgi?id=123003

Reviewed by Anders Carlsson.

Proxy layer contents to the UI process. Contents are painted into ShareableBitmaps
for now, and are fully repainted on any invalidation. Also, contents do not respect
any kind of scale or use of contentsRect/etc.

  • Shared/mac/RemoteLayerTreeTransaction.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
Store/encode/decode/dump the new RemoteLayerBackingStore.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
Fix a mistake where contentsRect was getting reset when contentsScale changed.
Set the layer contents when the backing store changes.

  • WebKit2.xcodeproj/project.pbxproj:

Add RemoteLayerBackingStore.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::recursiveBuildTransaction):
Paint while building our transaction, and mark the backing store as changed
if we did any painting.

(PlatformCALayerRemote::ensureBackingStore):
Keep the backing store's properties up-to-date with our layer.

(PlatformCALayerRemote::setNeedsDisplay):
Inform the backing store that it needs to paint.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:
  • WebProcess/WebPage/mac/RemoteLayerBackingStore.h: Added.
  • WebProcess/WebPage/mac/RemoteLayerBackingStore.mm: Added.

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
Encode/decode our ShareableBitmap (via its handle) and size.

(RemoteLayerBackingStore::setNeedsDisplay):
For now, repaint the world.

(RemoteLayerBackingStore::display):
Create a new bitmap if needed, and paint into it.

9:41 PM Changeset in webkit [157622] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed a typo in the definition of WK_API_ENABLED.

  • Shared/API/Cocoa/WKFoundation.h: It’s 101000, not 10100.
9:32 PM Changeset in webkit [157621] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, another ARM64 build fix.

Get rid of andPtr(TrustedImmPtr, blah), since it would take Effort to get it to work
on ARM64 and none of its uses are legit - they should all be using
andPtr(TrustedImm32, blah) anyway.

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM64.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileExceptionHandlers):

8:59 PM Changeset in webkit [157620] by mitz@apple.com
  • 31 edits
    2 adds in trunk/Source/WebKit2

Add and deploy WK_API_ENABLED guards
​https://bugs.webkit.org/show_bug.cgi?id=123008

Reviewed by Darin Adler.

  • Shared/API/Cocoa: Added.
  • Shared/API/Cocoa/WKFoundation.h: Added. Defined WK_API_ENABLED based on whether the

Objective-C API should be enabled in the current configuration.

  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::typeFromObject): Changed to use WK_API_ENABLED.
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode): Ditto.
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode): Ditto.
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode): Ditto.
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode): Ditto.

  • UIProcess/API/mac/WKTypeRefWrapper.h: Ditto.
  • UIProcess/API/mac/WKTypeRefWrapper.mm: Ditto.
  • UIProcess/API/mac/WebKit2.h: Imported WKFoundation.h.
  • WebKit2.xcodeproj/project.pbxproj: Added new Cocoa group in Shared/API. Added

WKFoundation.h as a public header.

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMRangePrivate.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMText.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMText.mm:
  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

8:47 PM Changeset in webkit [157619] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, speculative ARM64 build fix.

move(ImmPtr, blah) is only available in MacroAssembler since that's where blinding is
implemented. So, you have to use TrustedImmPtr in the superclasses.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::store8):
(JSC::MacroAssemblerARM64::branchTest8):

7:43 PM Changeset in webkit [157618] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, speculative ARM build fix.
​https://bugs.webkit.org/show_bug.cgi?id=122890
<rdar://problem/15258624>

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::firstRegister):
(JSC::ARM64Assembler::lastRegister):
(JSC::ARM64Assembler::firstFPRegister):
(JSC::ARM64Assembler::lastFPRegister):

  • assembler/MacroAssemblerARM64.h:
  • assembler/MacroAssemblerARMv7.h:
6:55 PM Changeset in webkit [157617] by ryuan.choi@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip tests which are already passed.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
6:04 PM Changeset in webkit [157616] by jinwoo7.song@samsung.com
  • 3 edits
    4 adds in trunk/LayoutTests

Unreviewed EFL gardening.

  • platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added.
  • platform/efl-wk2/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
  • platform/efl/fast/forms/control-restrict-line-height-expected.png: Rebaseline after r155408.
  • platform/efl/fast/forms/control-restrict-line-height-expected.txt: Rebaseline after r155408.
5:52 PM Changeset in webkit [157615] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Don't add an include for return type of a [Custom] function in generated bindings code
​https://bugs.webkit.org/show_bug.cgi?id=122972

Reviewed by Sam Weinig.

  • bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
4:35 PM Changeset in webkit [157614] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Pass VM instead of JSGlobalObject to JSONObject constructor.
<​https://webkit.org/b/122999>

JSONObject was only use the JSGlobalObject to grab at the VM.
Dodge a few loads by passing the VM directly instead.

Reviewed by Geoffrey Garen.

  • runtime/JSONObject.cpp:

(JSC::JSONObject::JSONObject):
(JSC::JSONObject::finishCreation):

  • runtime/JSONObject.h:

(JSC::JSONObject::create):

4:33 PM Changeset in webkit [157613] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CTTE: RenderMathMLSpace always has a MathMLTextElement.
<​https://webkit.org/b/122992>

The renderer is never anonymous and always has a corresponding
MathMLTextElement. Overload element() with a tighter return type.

Also marked the class FINAL and made most methods private.

Reviewed by Antti Koivisto.

  • rendering/mathml/RenderMathMLSpace.cpp:

(WebCore::RenderMathMLSpace::RenderMathMLSpace):
(WebCore::RenderMathMLSpace::updateFromElement):

  • rendering/mathml/RenderMathMLSpace.h:
4:29 PM Changeset in webkit [157612] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed the JITStackFrame struct
​https://bugs.webkit.org/show_bug.cgi?id=123001

Reviewed by Anders Carlsson.

  • jit/JITStubs.h: JITStackFrame and JITStubArg are unused now, since all

our helper functions obey the C function call ABI.

4:20 PM Changeset in webkit [157611] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

PlatformCALayer constructor should take layer type as an argument
​https://bugs.webkit.org/show_bug.cgi?id=122915

Reviewed by Anders Carlsson.

No new tests, just restoring old code.

Un-do part of the patch for bug 122915; we can't early-return
in the constructor, there's still more work to do.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::PlatformCALayerMac):

4:08 PM Changeset in webkit [157610] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed an unused #define
​https://bugs.webkit.org/show_bug.cgi?id=123000

Reviewed by Anders Carlsson.

  • jit/JITStubs.h: Removed the concept of JITSTACKFRAME_ARGS_INDEX,

since it is unused now. This is a step toward using the C stack.

4:00 PM Changeset in webkit [157609] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Eliminate uses of JITSTACKFRAME_ARGS_INDEX as scratch area for thunks
​https://bugs.webkit.org/show_bug.cgi?id=122973

Reviewed by Michael Saboff.

  • jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator): This was all dead code,
so I removed it.

The code acted as if it needed to pass an argument to
lookupExceptionHandler, and as if it passed that argument to itself
through JITStackFrame. However, lookupExceptionHandler does not take
an argument (other than the default ExecState argument), and the code
did not initialize the thing that it thought it passed to itself!

3:47 PM Changeset in webkit [157608] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

Crash fix for Windows XP.
​https://bugs.webkit.org/show_bug.cgi?id=122790

Patch by Anthony Johnson <​anthony.johnson@flexsim.com> on 2013-10-17
Reviewed by Geoffrey Garen.

  • win/tools/vsprops/common.props:

Replaced stack and heap sizes of zero with blank stack and heap sizes.

3:28 PM Changeset in webkit [157607] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

Run JavaScriptCore tests again on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=122787

Patch by Alex Christensen <​achristensen@webkit.org> on 2013-10-17
Reviewed by Tim Horton.

Source/JavaScriptCore:

  • JavaScriptCore.vcxproj/JavaScriptCore.sln: Added.
  • jit/JITStubsMSVC64.asm: Removed reference to cti_vm_throw unused since r157581.

Tools:

  • Scripts/build-jsc:

(buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.

  • Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
  • Scripts/webkitdirs.pm:

(determineConfigurationForVisualStudio):
(determineConfigurationProductDir):
Build directory should end with bin64 and configuration should end with |x64 on Win64.
(isAppleWinWebKit):
(copyInspectorFrontendFiles):
(setPathForRunningWebKitApp):
Separated WinCairo directories and options from AppleWin.

3:10 PM Changeset in webkit [157606] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Tidied up the Vector<T> move constructor
​https://bugs.webkit.org/show_bug.cgi?id=122998

Reviewed by Anders Carlsson.

  • wtf/Vector.h:

(WTF::::Vector): Don't call swap() "weird". It's the way most std types
implement move constructors.

Do inline this function, so the compiler can optimize away a logical
move into a physical no-op.

3:08 PM Changeset in webkit [157605] by Alexandru Chiculita
  • 3 edits
    2 adds in trunk

Web Inspector: [CSS Regions] Crash when highlighting a node of a flow with no regions
​https://bugs.webkit.org/show_bug.cgi?id=122993

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector-protocol/dom/highlight-flow-with-no-region.html

Even if a named flow has no regions the content of the flow will still have renderer objects created.
Removed the assumption that all renderers inside a RenderFlowThread will always have an enclosing RenderRegion.

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForRendererFragments):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):

LayoutTests:

Added test to check that DOM.highlightNode is not crashing WebCore when the node is inside
a flow with no associated regions.

  • inspector-protocol/dom/highlight-flow-with-no-region-expected.txt: Added.
  • inspector-protocol/dom/highlight-flow-with-no-region.html: Added.
2:45 PM Changeset in webkit [157604] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed restoreArgumentReference (another use of JITStackFrame)
​https://bugs.webkit.org/show_bug.cgi?id=122997

Reviewed by Oliver Hunt.

  • jit/JSInterfaceJIT.h: Removed an unused function. This is a step

toward using the C stack.

2:39 PM Changeset in webkit [157603] by oliver@apple.com
  • 14 edits
    4 deletes in trunk/Source

Remove JITStubCall.h
​https://bugs.webkit.org/show_bug.cgi?id=122991

Reviewed by Geoff Garen.

Happily this is no longer used

  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JIT.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITPropertyAccess.cpp:
  • jit/JITPropertyAccess32_64.cpp:
  • jit/JITStubCall.h: Removed.
2:38 PM Changeset in webkit [157602] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Improve the viewport of some websites like mobilesyrup.com/2013/08/25/moto-x-review/
​https://bugs.webkit.org/show_bug.cgi?id=122995

Patch by Jacky Jiang <​zhajiang@blackberry.com> on 2013-10-17.
Reviewed by George Staikos.
Internally reviewed by George Staikos and Eli Fidler.

JIRA 523949
Force to respect the viewport when there is viewport meta tag but width
is not specified even though the viewport is broken. By doing that, We
want to improve the user experience of some websites that use a reasonable
initial-scale, but have some overly-wide contents

The contents of those websites like mobilesyrup.com/2013/08/25/moto-x-review
should be improved by the contents provider eventually.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::recomputeVirtualViewportFromViewportArguments):

2:38 PM Changeset in webkit [157601] by Antoine Quint
  • 5 edits
    3 adds in trunk/Source/WebInspectorUI

Web Inspector: Go to line keyboard command and dialog
​https://bugs.webkit.org/show_bug.cgi?id=122893

Reviewed by Timothy Hatcher.

Add a text input over source code text editors, centered within the width of the editor
and towards the top of the editor, upon pressing Command+L or Control+G to match the
behavior in Chrome.

  • Localizations/en.lproj/localizedStrings.js:

New localized string "Line Number".

  • UserInterface/GoToLineDialog.css: Added.

Styling for the go-to-line dialog.

  • UserInterface/GoToLineDialog.js: Added.

(WebInspector.GoToLineDialog):
Generate the DOM structure for the dialog.

(WebInspector.GoToLineDialog.prototype.present):
Present the dialog as a child of a parent element. The dialog's text field automatically
gets focus and resets to be empty.

(WebInspector.GoToLineDialog.prototype.dismiss):
Dismiss the dialog if visible, this triggers the goToLineDialogWasDismissed delegate method.

(WebInspector.GoToLineDialog.prototype.handleEvent):
Route the various events registered in the dialog's DOM tree: input, keydown, blur, mousedown
and click.

(WebInspector.GoToLineDialog.prototype._handleInputEvent):
Update the "non-empty" class on the dialog's element depending on the content of the dialog's
text field. If there is content in the text field, this will make the clear icon visible.

(WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
If the Esc. key is pressed when there is text in the dialog's input field, clear the input field.
If no text is in the input field, dismiss the input field. When the Enter key is pressed, we call
the isGoToLineDialogValueValid() method on the delegate to figure out if the text field value is
valid. If it's not, we select the text field value so that it may be easily replaced and play
en error sound. If it's valid, we call the goToLineDialogValueWasValidated() delegate method
and dismiss the dialog.

(WebInspector.GoToLineDialog.prototype._handleBlurEvent):
Dismiss the dialog when its text field loses focus. This ensures that clicking anywhere outside
of the dialog removes it from display.

(WebInspector.GoToLineDialog.prototype._handleMousedownEvent):
Upon pressing the mouse down on the clear icon, select the entire text field content (matches
the behavior of Xcode) and prevent the default event action that would blur the text field
which would dismiss the dialog.

(WebInspector.GoToLineDialog.prototype._handleClickEvent):
Clear the content of the dialog's text field upon clicking on its clear button.

(WebInspector.GoToLineDialog.prototype._clear):
Reset the dialog's text field's value to an empty string and remove the "non-empty" CSS class name
controlling the display of the clear button.

  • UserInterface/Images/CloseWhite.svg: Added.

Variation of the Close.svg icon with a white cross.

  • UserInterface/Main.html:

Link to the newly added resources for GoToLineDialog.

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
Register the Command+L and Control+G keyboard shortcuts to bring up the go-to-line dialog.

(WebInspector.SourceCodeTextEditor.prototype.showGoToLineDialog):
Method called upon pressing the Command+L and Control+G keyboard shorcuts creating an instance
of a GoToDialog if necessary, becoming its delegate and presenting it in the context of the
editor's root element.

(WebInspector.SourceCodeTextEditor.prototype.isGoToLineDialogValueValid):
Delegate method called to validate the line number presently set in the go-to-dialog's text field,
checking it's a number between 1 and the number of lines in the source code.

(WebInspector.SourceCodeTextEditor.prototype.goToLineDialogValueWasValidated):
Delegate method called when the line number set in the go-to-dialog's text field has been validated.
We reveal and select the line at the number provided.

(WebInspector.SourceCodeTextEditor.prototype.goToLineDialogWasDismissed):
Ensure the source code editor regains focus upon dismissing the go-to-dialog.

  • UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype.revealPosition):
Add a new opt-in option to not highlight the revealed position. The code in goToLineDialogValueWasValidated()
sets that new flag to true to avoid an unnecessary highlight on top of the selection.

(WebInspector.TextEditor.prototype.get lineCount):
Expose the lineCount() method on the private CodeMirror instance.

(WebInspector.TextEditor.prototype.focus):
Expose the focus() method on the private CodeMirror instance.

2:29 PM Changeset in webkit [157600] by Antoine Quint
  • 5 edits
    2 deletes in trunk/Source/WebInspectorUI

Web Inspector: logged objects are highlighted in blue
​https://bugs.webkit.org/show_bug.cgi?id=122897

Reviewed by Joseph Pecoraro.

Switch to using the system highlight color for the background selected messages.
Also removing SVG assets no longer needed since we won't be showing white prompt
and result icons anymore as well as a few generated canvas states.

  • UserInterface/Images/UserInputPromptPreviousSelected.svg: Removed.
  • UserInterface/Images/UserInputResultSelected.svg: Removed.
  • UserInterface/LogContentView.css:

(.console-messages:focus .console-item.selected):

  • UserInterface/Main.js:

(WebInspector._generateDisclosureTriangleImages):

2:21 PM Changeset in webkit [157599] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CTTE: RenderMathMLOperator always has a MathMLElement.
<​https://webkit.org/b/122988>

Reviewed by Antti Koivisto.

The renderer is never anonymous and always has a corresponding
MathMLElement. Overload element() with a tighter return type.

Also marked the class FINAL and made most methods private.

2:14 PM Changeset in webkit [157598] by thakis@chromium.org
  • 5 edits in trunk

Fix three bugs in the equals() implementations for css gradients.
​https://bugs.webkit.org/show_bug.cgi?id=122987

Reviewed by Andreas Kling.

  1. Linear gradients were considered equal if the first gradient has no x and y position and the second has no x but does have y.
  2. Same as 1, for radial gradients. (This doesn't happen in practice as CSSParser::parseRadialGradient rejects such input, so no test for this case.)
  3. Radial gradients without x and y position weren't considered equal even if they were.

Source/WebCore:

  • css/CSSGradientValue.cpp:

(WebCore::CSSLinearGradientValue::equals):
(WebCore::CSSRadialGradientValue::equals):

LayoutTests:

Merges ​https://codereview.chromium.org/26147006/

  • cssom/cssvalue-comparison-expected.txt:
  • cssom/cssvalue-comparison.html:
2:07 PM Changeset in webkit [157597] by Antoine Quint
  • 6 edits in trunk/Source

Web Inspector: allow front-end to trigger the system beep sound to signal an error
​https://bugs.webkit.org/show_bug.cgi?id=122955

Reviewed by Timothy Hatcher.

Source/WebCore:

New beep() method exposed on InspectorFrontendHost calling into WebCore's systemBeep().

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::beep):

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

Provide a stub method for the new InspectorFrontendHost.beep() method.

  • UserInterface/InspectorFrontendHostStub.js:

(WebInspector.InspectorFrontendHostStub.prototype.beep):

2:03 PM Changeset in webkit [157596] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

[WK2] Speculative buildfixes for GTK and EFL after r157582.

  • CMakeLists.txt:
  • GNUmakefile.am:
1:51 PM Changeset in webkit [157595] by commit-queue@webkit.org
  • 11 edits
    11 adds in trunk/Source/WebKit2

Refactor stored website data APIs
​https://bugs.webkit.org/show_bug.cgi?id=122781

Patch by Martin Hock <​mhock@apple.com> on 2013-10-17
Reviewed by Brady Eidson.

Add WebOriginDataManager along with corresponding class
WebOriginDataManagerProxy and API WKOriginDataManager.

Currently, the new files are unused.

WKOriginDataManager should subsume the functionality of:
WKApplicationCacheManager, WKCookieManager, WKDatabaseManager,
WKKeyValueStorageManager, WKMediaCacheManager,
WKPluginSiteDataManager, and WKResourceCacheManager.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetOriginDataManager):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKOriginDataManager.cpp: Added.

(WKOriginDataManagerGetTypeID):
(WKOriginDataManagerGetOrigins):
(WKOriginDataManagerDeleteEntriesForOrigin):
(WKOriginDataManagerDeleteAllEntries):
(WKOriginDataManagerStartObservingChanges):
(WKOriginDataManagerStopObservingChanges):
(WKOriginDataManagerSetChangeClient):

  • UIProcess/API/C/WKOriginDataManager.h: Added.
  • UIProcess/WebOriginDataManagerProxy.cpp: Added.

(WebKit::WebOriginDataManagerProxy::supplementName):
(WebKit::WebOriginDataManagerProxy::create):
(WebKit::WebOriginDataManagerProxy::WebOriginDataManagerProxy):
(WebKit::WebOriginDataManagerProxy::~WebOriginDataManagerProxy):
(WebKit::WebOriginDataManagerProxy::contextDestroyed):
(WebKit::WebOriginDataManagerProxy::processDidClose):
(WebKit::WebOriginDataManagerProxy::shouldTerminate):
(WebKit::WebOriginDataManagerProxy::refWebContextSupplement):
(WebKit::WebOriginDataManagerProxy::derefWebContextSupplement):
(WebKit::WebOriginDataManagerProxy::getOrigins):
(WebKit::WebOriginDataManagerProxy::didGetOrigins):
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):
(WebKit::WebOriginDataManagerProxy::deleteAllEntries):
(WebKit::WebOriginDataManagerProxy::startObservingChanges):
(WebKit::WebOriginDataManagerProxy::stopObservingChanges):
(WebKit::WebOriginDataManagerProxy::setChangeClient):
(WebKit::WebOriginDataManagerProxy::didChange):

  • UIProcess/WebOriginDataManagerProxy.h: Added.
  • UIProcess/WebOriginDataManagerProxy.messages.in: Added.
  • UIProcess/WebOriginDataManagerProxyChangeClient.cpp: Added.

(WebKit::WebOriginDataManagerProxyChangeClient::didChange):

  • UIProcess/WebOriginDataManagerProxyChangeClient.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/OriginData/WebOriginDataManager.cpp: Added.

(WebKit::WebOriginDataManager::supplementName):
(WebKit::WebOriginDataManager::WebOriginDataManager):
(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteAllEntries):
(WebKit::WebOriginDataManager::startObservingChanges):
(WebKit::WebOriginDataManager::stopObservingChanges):

  • WebProcess/OriginData/WebOriginDataManager.h: Added.
  • WebProcess/OriginData/WebOriginDataManager.messages.in: Added.
1:36 PM Changeset in webkit [157594] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove PlatformCAAnimation::supportsValueFunction()
​https://bugs.webkit.org/show_bug.cgi?id=122990

Reviewed by Tim Horton.

PlatformCAAnimation::supportsValueFunction always returns true now, so there's no need for it to exist anymore.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
1:08 PM Changeset in webkit [157593] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CTTE: RenderMathMLFenced always has a MathMLInlineContainerElement.
<​https://webkit.org/b/122986>

This renderer is never anonymous and always has a corresponding
MathMLInlineContainerElement. Overload element() with a tighter
return type.

Also marked the class FINAL and made most methods private.

Reviewed by Anders Carlsson.

1:04 PM Changeset in webkit [157592] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Removed a use of JITSTACKFRAME_ARGS_INDEX
​https://bugs.webkit.org/show_bug.cgi?id=122989

Reviewed by Oliver Hunt.

  • jit/JITStubCall.h: Removed an unused function. This is one step closer

to using the C stack.

12:53 PM Changeset in webkit [157591] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Change emit_op_catch to use another method to materialize VM
​https://bugs.webkit.org/show_bug.cgi?id=122977

Reviewed by Oliver Hunt.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch): Use a constant. It removes our dependency
on JITStackFrame. It is also faster and simpler.

12:42 PM Changeset in webkit [157590] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Eliminate emitGetJITStubArg() - dead code
​https://bugs.webkit.org/show_bug.cgi?id=122975

Reviewed by Anders Carlsson.

  • jit/JIT.h:
  • jit/JITInlines.h: Removed unused, deprecated function.
12:22 PM Changeset in webkit [157589] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Comment AffineTransform::xScale() and yScale() to make their meanings clearer
​https://bugs.webkit.org/show_bug.cgi?id=122981

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-10-17
Reviewed by Simon Fraser.

  • platform/graphics/transforms/AffineTransform.h:
12:22 PM Changeset in webkit [157588] by mark.lam@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Eliminate all ASSERT references to OBJECT_OFFSETOF(struct JITStackFrame,...) in JITStubsXXX.h.
​https://bugs.webkit.org/show_bug.cgi?id=122979.

Reviewed by Michael Saboff.

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARM64.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsMIPS.h:
  • jit/JITStubsSH4.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

12:15 PM Changeset in webkit [157587] by vivek.vg@samsung.com
  • 3 edits in trunk/Source/WebCore

Remove unnecessary check for RenderLayer and rename ensureLayer to createLayer in RenderLayerModelObject.
​https://bugs.webkit.org/show_bug.cgi?id=122928

Reviewed by Darin Adler.

No new tests due to code refactoring.

RenderLayerModelObject::styleDidChange invokes the ensureLayer() only in case of !layer().
Again checking for layer existence would be deemed redundant in ensureLayer.
Replacing it with an ASSERT(!m_layer) and also renaming it to createLayer.

Blink review URL: ​https://codereview.chromium.org/27246003/

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::createLayer):
(WebCore::RenderLayerModelObject::styleDidChange):

  • rendering/RenderLayerModelObject.h:
11:57 AM Changeset in webkit [157586] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove saving callFrameRegister to JITStackFrame in JITCompiler::compileFunction()
​https://bugs.webkit.org/show_bug.cgi?id=122974

Reviewed by Geoffrey Garen.

Eliminated unneeded storing to JITStackFrame.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

11:52 AM Changeset in webkit [157585] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of Apple Windows port.

  • platform/win/TestExpectations:
11:51 AM Changeset in webkit [157584] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Remove PlatformCALayerMac workaround for <rdar://problem/7390716>
​https://bugs.webkit.org/show_bug.cgi?id=122983

Reviewed by Simon Fraser.

Remove a workaround for a bug fixed in Lion.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::setSublayers):
(PlatformCALayerMac::removeAllSublayers):
(PlatformCALayerMac::adoptSublayers):

11:33 AM Changeset in webkit [157583] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Blind attempt at gtk-wk2 build fix.

  • GNUmakefile.am:
11:30 AM Changeset in webkit [157582] by beidson@apple.com
  • 9 edits
    3 copies
    8 adds in trunk/Source/WebKit2

Add scaffolding for IDBDatabaseBackends in Web and Database processes
​https://bugs.webkit.org/show_bug.cgi?id=122971

Reviewed by Tim Horton.

This patch:

  • Adds a WebProcessIDBDatabaseBackend
  • Adds a DatabaseProcessIDBDatabaseBackend
  • Establishes the basic messaging between them
  • Actually creates those backends as the result of an indexedDB.open() call from javascript
  • DerivedSources.make:
  • WebKit2.xcodeproj/project.pbxproj:
  • Platform/Logging.h:

Hook up messaging so (Web/Database)ProcessIDBDatabaseBackends can message each other:

  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::establishIDBDatabaseBackend):

  • DatabaseProcess/DatabaseToWebProcessConnection.h:

(WebKit::DatabaseToWebProcessConnection::connection):

  • DatabaseProcess/DatabaseToWebProcessConnection.messages.in: Added.

DatabaseProcess side of an IDBDatabaseBackend:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.cpp:

(WebKit::DatabaseProcessIDBDatabaseBackend::DatabaseProcessIDBDatabaseBackend):
(WebKit::DatabaseProcessIDBDatabaseBackend::~DatabaseProcessIDBDatabaseBackend):
(WebKit::DatabaseProcessIDBDatabaseBackend::openConnection):
(WebKit::DatabaseProcessIDBDatabaseBackend::messageSenderConnection):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h: Added.

(WebKit::DatabaseProcessIDBDatabaseBackend::create):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.messages.in: Added.

WebProcess side of an IDBDatabaseBackend:

  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp: Added.

(WebKit::generateBackendIdentifier):
(WebKit::WebProcessIDBDatabaseBackend::WebProcessIDBDatabaseBackend):
(WebKit::WebProcessIDBDatabaseBackend::~WebProcessIDBDatabaseBackend):
(WebKit::WebProcessIDBDatabaseBackend::openConnection):
(WebKit::WebProcessIDBDatabaseBackend::createObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::deleteObjectStore):
(WebKit::WebProcessIDBDatabaseBackend::createTransaction):
(WebKit::WebProcessIDBDatabaseBackend::close):
(WebKit::WebProcessIDBDatabaseBackend::commit):
(WebKit::WebProcessIDBDatabaseBackend::abort):
(WebKit::WebProcessIDBDatabaseBackend::createIndex):
(WebKit::WebProcessIDBDatabaseBackend::deleteIndex):
(WebKit::WebProcessIDBDatabaseBackend::get):
(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::setIndexKeys):
(WebKit::WebProcessIDBDatabaseBackend::setIndexesReady):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):
(WebKit::WebProcessIDBDatabaseBackend::count):
(WebKit::WebProcessIDBDatabaseBackend::deleteRange):
(WebKit::WebProcessIDBDatabaseBackend::clear):
(WebKit::WebProcessIDBDatabaseBackend::messageSenderConnection):
(WebKit::WebProcessIDBDatabaseBackend::establishDatabaseProcessBackend):

  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h: Added.

(WebKit::WebProcessIDBDatabaseBackend::create):

Basic shared utilities that multiple processes will need going forward:

  • Shared/Databases/IndexedDB/IDBUtilities.cpp:

(WebKit::uniqueDatabaseIdentifier):

  • Shared/Databases/IndexedDB/IDBUtilities.h:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::sharedDatabaseBackendMap):
(WebKit::WebIDBFactoryBackend::open): Actually establish an IDBDatabaseBackend in the DatabaseProcess

when indexedDB.open() is called, even if it does nothing for now.

  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
  • WebProcess/Databases/WebToDatabaseProcessConnection.h:
11:12 AM Changeset in webkit [157581] by msaboff@apple.com
  • 18 edits in trunk/Source/JavaScriptCore

Transition cti_op_throw and cti_vm_throw to a JIT operation
​https://bugs.webkit.org/show_bug.cgi?id=122931

Reviewed by Filip Pizlo.

Moved cti_op_throw to operationThrow. Made the caller responsible for jumping to the
catch handler. Eliminated cti_op_throw_static_error, cti_vm_throw, ctiVMThrowTrampoline()
and their callers as it is now dead code. There is some work needed on the Microsoft X86
callOperation to handle the need to provide space for structure return value.

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_throw):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARM64.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsMIPS.h:
  • jit/JITStubsMSVC64.asm:
  • jit/JITStubsSH4.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
  • jit/JSInterfaceJIT.h:
11:00 AM Changeset in webkit [157580] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] REGRESSION(r156472): scrolling coordinator is always enabled incorrectly.
​https://bugs.webkit.org/show_bug.cgi?id=122958

Patch by Attila Dusnoki <Attila Dusnoki> on 2013-10-17
Reviewed by Tim Horton.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Missing ENABLE(THREADED_SCROLLING) guard added.

10:44 AM Changeset in webkit [157579] by robert@webkit.org
  • 4 edits
    10 adds in trunk

"border-collapse: collapse;" for table removes part of its border (was: Border disappears when close to some elements)
​https://bugs.webkit.org/show_bug.cgi?id=8914

Reviewed by David Hyatt.

Source/WebCore:

The table section's side of a collapsed border won't get painted if there are no cells there to paint it. So instead
of relying solely on cells to paint the collapsed border paint the appropriate section of the border if there's no
cell to take care of it.

Tests: fast/table/paint-section-borders-without-cells-rtl.html

fast/table/paint-section-borders-without-cells-vertical-lr-rtl.html
fast/table/paint-section-borders-without-cells-vertical-lr.html
fast/table/paint-section-borders-without-cells-vertical-rl.html
fast/table/paint-section-borders-without-cells.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintRowGroupBorder):
(WebCore::RenderTableSection::offsetLeftForRowGroupBorder):
(WebCore::RenderTableSection::offsetTopForRowGroupBorder):
(WebCore::RenderTableSection::verticalRowGroupBorderHeight):
(WebCore::RenderTableSection::horizontalRowGroupBorderWidth):
(WebCore::RenderTableSection::paintRowGroupBorderIfRequired):
(WebCore::physicalBorderForDirection):
(WebCore::RenderTableSection::paintObject):

  • rendering/RenderTableSection.h:

LayoutTests:

  • fast/table/paint-section-borders-without-cells-expected.html: Added.
  • fast/table/paint-section-borders-without-cells-rtl-expected.html: Added.
  • fast/table/paint-section-borders-without-cells-rtl.html: Added.
  • fast/table/paint-section-borders-without-cells-vertical-lr-expected.html: Added.
  • fast/table/paint-section-borders-without-cells-vertical-lr-rtl-expected.html: Added.
  • fast/table/paint-section-borders-without-cells-vertical-lr-rtl.html: Added.
  • fast/table/paint-section-borders-without-cells-vertical-lr.html: Added.
  • fast/table/paint-section-borders-without-cells-vertical-rl-expected.html: Added.
  • fast/table/paint-section-borders-without-cells-vertical-rl.html: Added.
  • fast/table/paint-section-borders-without-cells.html: Added.
9:57 AM Changeset in webkit [157578] by Lucas Forschler
  • 5 edits in tags/Safari-538.2/Source/WebKit2

Merged r157561. <rdar://problem/15183901>

9:19 AM Changeset in webkit [157577] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

certain http media tests doesn't receive the expected "Content-Length" header
​https://bugs.webkit.org/show_bug.cgi?id=122965

Patch by Andres Gomez <Andres Gomez> on 2013-10-17
Reviewed by Eric Carlson.

Fixed PHP syntax so "Content-Length" HTTP Header is included in
the response.

  • http/tests/media/resources/serve-video.php:
8:47 AM Changeset in webkit [157576] by fpizlo@apple.com
  • 12 edits
    1 add in trunk/Source

Source/JavaScriptCore: Remove JITStackFrame references in the C Loop LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=122950.

Patch by Mark Lam <​mark.lam@apple.com> on 2013-10-17
Reviewed by Michael Saboff.

  • jit/JITStubs.h:
  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • offlineasm/cloop.rb:

Source/WTF: Introduce WTF::Bag and start using it for InlineCallFrameSet
​https://bugs.webkit.org/show_bug.cgi?id=122941

Reviewed by Geoffrey Garen.

Introduce WTF::Bag, which is basically an allocation pool. No POD restrictions. Does one
malloc per entry. No need to shrink afterwards.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/Bag.h: Added.

(WTF::Bag::Bag):
(WTF::Bag::~Bag):
(WTF::Bag::add):
(WTF::Bag::iterator::iterator):
(WTF::Bag::iterator::operator!):
(WTF::Bag::iterator::operator*):
(WTF::Bag::iterator::operator++):
(WTF::Bag::iterator::operator==):
(WTF::Bag::begin):
(WTF::Bag::end):
(WTF::Bag::isEmpty):

  • wtf/CMakeLists.txt:
8:17 AM Changeset in webkit [157575] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

StyleRuleFoo::mutableProperties() should return a reference.
<​https://webkit.org/b/122962>

The mutableProperties() functions always return objects, so make
them return MutableStylePropertySet&.

Also tweaked the StyleRuleCSSStyleDeclaration constructor to take
references to both the properties and the owner rule since both
are required.

Reviewed by Antti Koivisto.

7:45 AM Changeset in webkit [157574] by hmuller@adobe.com
  • 4 edits in trunk/Source/WebCore

[CSS Shapes] Improve the performance of image valued shapes with large shape-margins
​https://bugs.webkit.org/show_bug.cgi?id=122613

Reviewed by Andreas Kling.

The cost of computing the shape-margin boundary of an image-valued shape-outside
is now proportional to (2 * shape-margin + image.height) rather than
(2 * shape-margin * image.height). The performance improvement comes from skipping
sequences of rounded-rectangle intervals that will not contribute to the final
result. Each non-empty row in the original image contributes one rounded-rectangle
whose corner radius is shape-margin, height is 2 * shape-margin, and width is
2 * shape-margin plus the width of the limits of the intervals on the row.

Renamed private method RasterShape::getIntervals() to intervalsAt() to be a little
more consistent with WebKit naming conventions.

There are no new tests since is just an internal refactoring.

  • rendering/shapes/RasterShape.cpp:

(WebCore::MarginIntervalGenerator::set): Changed the x1,x2 parameters to an IntShapeInterval.
(WebCore::RasterShapeIntervals::contains): Refactor for the getIntervals() => intervalsAt() rename.
(WebCore::RasterShapeIntervals::getIntervalX1Values): Ditto.
(WebCore::RasterShapeIntervals::getIncludedIntervals): Ditto.
(WebCore::RasterShapeIntervals::getExcludedIntervals): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): Performance tuning.

  • rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::intervalsAt): Renamed getIntervals().
(WebCore::RasterShapeIntervals::limitIntervalAt): Return the min/max limits of the intervals at Y.

  • rendering/shapes/ShapeInterval.h:

(WebCore::ShapeInterval::isEmpty): Added.

7:02 AM Changeset in webkit [157573] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GTK] Add URLMediaStream in the build
​https://bugs.webkit.org/show_bug.cgi?id=122833

Reviewed by Carlos Garcia Campos.

  • GNUmakefile.am: Add mediastream/gstreamer in include directories list.
  • GNUmakefile.list.am: Add DOMURLMediaStream files in the build.
6:47 AM Changeset in webkit [157572] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Remove JITStackFrame references in the C Loop LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=122950.

Reviewed by Michael Saboff.

  • jit/JITStubs.h:
  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • offlineasm/cloop.rb:
6:43 AM Changeset in webkit [157571] by mark.lam@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Remove JITStackFrame references in JIT probes.
​https://bugs.webkit.org/show_bug.cgi?id=122947.

Reviewed by Michael Saboff.

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::ProbeContext::dump):

  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssemblerARMv7::ProbeContext::dump):

  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssemblerX86Common::ProbeContext::dump):

  • assembler/MacroAssemblerX86Common.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86Common.h:
  • jit/JITStubsX86_64.h:
5:58 AM Changeset in webkit [157570] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/gtk

Massage the Gtk build.

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::shouldApplyStyle):

5:38 AM Changeset in webkit [157569] by akling@apple.com
  • 24 edits in trunk/Source

Use PassRef for constructing StylePropertySets.
<​https://webkit.org/b/122948>

Make functions that construct StylePropertySets return PassRef
instead of PassRefPtr. Since they never return null, this gets rid
of the extra branch in ~PassRefPtr everywhere.

Also StyleRule* classes now hold a Ref<StylePropertySet>, codifying
the fact that they always have a property set.

Reviewed by Antti Koivisto.

5:15 AM Changeset in webkit [157568] by akling@apple.com
  • 26 edits in trunk/Source/WebCore

DataRef<T> should use Ref<T> internally.
<​https://webkit.org/b/122953>

DataRef is used to hold RenderStyle substructures, and due to the
way style inheritance is implemented, DataRef will always point to
a live object.

Codify this by making DataRef::m_data a Ref, and making all methods
that create substructure objects return PassRef.

Reviewed by Antti Koivisto.

2:02 AM Changeset in webkit [157567] by mihnea@adobe.com
  • 28 edits
    6 adds in trunk

[CSS Regions] Anonymous nested regions
​https://bugs.webkit.org/show_bug.cgi?id=119135

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/table-caption-as-region.html

fast/regions/table-cell-as-region.html

This patch allows any non-replaced block to behave like a region. When an element is styled with the
-webkit-flow-from property, instead of making the renderer a RenderRegion, we let the original
renderer be created the same way and we add a region as an anonymous child for the renderer.
The anonymous block child, modeled by the new RenderNamedFlowFragment class, will be responsible
for the fragmentation of the named flow thread content.

A RenderBlockFlow object will keep a reference to a RenderNamedFlowFragment(RenderRegion) inside its
rare data structures.

Contains code contributed by Catalin Badea.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp: Changed to take the anonymous region into account.

(WebCore::Element::renderRegion):
(WebCore::Element::webkitGetRegionFlowRanges):

  • dom/WebKitNamedFlow.cpp: Ditto.

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):

  • inspector/InspectorOverlay.cpp: Take into account the new model for regions, with an anonymous region inside a block.

(WebCore::buildObjectForRegionHighlight):
(WebCore::buildObjectForElementInfo):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeShapeSize): For a render named flow fragment, there is no need to recompute the shape inside
we can take it from the parent.
(WebCore::RenderBlock::renderName): Make the block that contains a render named flow fragment (region) report RenderRegion.
A future patch that will change this will need to rebase a lot of tests.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::insertedIntoTree): Create the anonymous region if needed (change of -webkit-flow-from determines Node reattach).
(WebCore::RenderBlockFlow::willBeDestroyed): Clean-up the anonymous region if necessary.
(WebCore::RenderBlockFlow::clearFloats): Small style change to make sure that check-webkit-style reports 0 failures on RenderBlockFlow.cpp.
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::styleDidChange): Update the style of the anonymous region too.
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded): Helper function to create the anonymous region
and to add it as a child to the block.
(WebCore::RenderBlockFlow::canHaveChildren):
(WebCore::RenderBlockFlow::canHaveGeneratedChildren):
(WebCore::RenderBlockFlow::namedFlowFragmentNeedsUpdate): Force a layout of the anonymous region if the
parent block has percentage height (similar to RenderBlock::updateBlockChildDirtyBitsBeforeLayout)
(WebCore::RenderBlockFlow::updateLogicalHeight): Update the logical height of anonymous region when the height of parent is updated.
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::renderNamedFlowFragment):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor): Remove the direct creation of RenderRegion objects since they will be
created as anonymous children of block flow objects.

  • rendering/RenderElement.h:

(WebCore::RenderElement::generatingElement): Account for anonymous region if necessary.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent): Take anonymous region into account
and use the anonymous region parent offset/border.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly): Check for style instead of isRenderRegion since
the parent of the anonymous region will get the layer.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::insertedIntoTree): Call RenderBlockFlow method instead.

  • rendering/RenderNamedFlowFragment.cpp: Added. Model the behaviour of the anonymous region.

Has RenderRegion as a base class.
(WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::~RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::setStyleForNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::styleDidChange):
(WebCore::RenderNamedFlowFragment::shouldHaveAutoLogicalHeight):
(WebCore::RenderNamedFlowFragment::maxPageLogicalHeight):

  • rendering/RenderNamedFlowFragment.h: Added.

(WebCore::RenderNamedFlowFragment::isPseudoElementRegion):
(WebCore::RenderNamedFlowFragment::renderName):
(WebCore::toRenderNamedFlowFragment):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isRenderNamedFlowFragmentContainer):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderNamedFlowFragment):

  • rendering/RenderRegion.h:
  • rendering/RenderTableCaption.cpp: Call RenderBlockFlow method instead.

(WebCore::RenderTableCaption::insertedIntoTree):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):
(WebCore::writeRenderRegionList):

  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::shapeSize):

  • style/StyleResolveTree.cpp:

(WebCore::Style::elementInsideRegionNeedsRenderer):

LayoutTests:

Add new tests for making a table-cell and a table-caption a region.
Change expected results for repaint tests of fixed elements since the parent of the region gets layer.

  • fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
  • fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
  • fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
  • fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
  • fast/regions/table-caption-as-region-expected.html: Added.
  • fast/regions/table-caption-as-region.html: Added.
  • fast/regions/table-cell-as-region-expected.html: Added.
  • fast/regions/table-cell-as-region.html: Added.
1:53 AM Changeset in webkit [157566] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build when NUMBER_OF_ARGUMENT_REGISTERS == 4.
​https://bugs.webkit.org/show_bug.cgi?id=122949

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-17
Reviewed by Andreas Kling.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

1:48 AM Changeset in webkit [157565] by mihnea@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a reviewer.

1:06 AM Changeset in webkit [157564] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk

[EFL] Properly expose tables in accessibility
​https://bugs.webkit.org/show_bug.cgi?id=122894

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-17
Reviewed by Chris Fleizach.

Source/WebCore:

All tables should exposed as tables.

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::addChildren):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):

LayoutTests:

Added new accessibility expectations after r153432.

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/accessibility/table-detection-expected.txt: Added.
  • platform/efl-wk2/accessibility/table-one-cell-expected.txt: Added.
  • platform/efl-wk2/accessibility/table-with-rules-expected.txt: Added.
  • platform/efl/accessibility/table-detection-expected.txt: Added.
  • platform/efl/accessibility/table-one-cell-expected.txt: Added.
  • platform/efl/accessibility/table-with-rules-expected.txt: Added.
12:55 AM Changeset in webkit [157563] by akling@apple.com
  • 4 edits in trunk

Make it possible to assign a PassRef to a RefPtr.
<​https://webkit.org/b/122943>

Source/WTF:

We have to use std::move when constructing a RefPtr from a PassRef
since there is no copy constructor for the latter.

Reviewed by Antti Koivisto.

Tools:

Added a small API test for RefPtr=(PassRef) so we know this code
will compile (and work.)

Reviewed by Antti Koivisto.

12:46 AM Changeset in webkit [157562] by commit-queue@webkit.org
  • 3 edits in trunk

[CMAKE] Update code to take advantage of CMake version 2.8.3+.
​https://bugs.webkit.org/show_bug.cgi?id=97516

Patch by Afonso R. Costa Jr. <​afonso.costa@samsung.com> on 2013-10-17
Reviewed by Gyuyoung Kim.

CMake's version was changed to 2.8.3. So, these files below
can be simplified to take advantage of CMake's new version.

  • Source/cmake/FindCairo.cmake: Simplified according to CMake 2.8.3+.
  • Source/cmake/FindGStreamer.cmake: Ditto.
12:28 AM Changeset in webkit [157561] by mrowe@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/15183901> WebKit2 XPC services load the wrong frameworks when running
from the staged frameworks location.

Build the XPC services with DYLD_VERSIONED_FRAMEWORK_PATH when USE_STAGING_INSTALL_PATH
is set to YES. This is necessary because there's no way to specify environment variables
to be used when an XPC service is launched.

Reviewed by Anders Carlsson.

  • Configurations/BaseTarget.xcconfig: Set OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH to contain the

DYLD_VERSIONED_FRAMEWORK_PATH value when USE_STAGING_INSTALL_PATH is YES.

  • Configurations/BaseXPCService.xcconfig: Include OTHER_LDFLAGS_VERSIONED_FRAMEWORK_PATH in the

value of OTHER_LDFLAGS.

  • Configurations/PluginService.32.xcconfig: Ditto.
  • Configurations/PluginService.64.xcconfig: Ditto.
12:22 AM Changeset in webkit [157560] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Too many arguments for format in WebKitWebAudioSourceGStreamer.cpp
​https://bugs.webkit.org/show_bug.cgi?id=122932

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-10-17
Reviewed by Philippe Normand.

No new tests because this just fixes a build warning.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop): Add another %s for the second part of the pad name.

12:20 AM Changeset in webkit [157559] by mark.lam@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Transition remaining op_get* JITStubs to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122925.

Reviewed by Geoffrey Garen.

Transitioning:

cti_op_get_by_id_generic
cti_op_get_by_val
cti_op_get_by_val_generic
cti_op_get_by_val_string

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_get_arguments_length):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_get_arguments_length):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_pname):
(JSC::JIT::privateCompileGetByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_pname):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • runtime/Executable.cpp:

(JSC::setupLLInt): Added some UNUSED_PARAMs to fix the no LLINT build.

  • runtime/Options.cpp:

(JSC::Options::initialize):

Oct 16, 2013:

8:47 PM Changeset in webkit [157558] by fpizlo@apple.com
  • 6 edits in trunk

libllvmForJSC shouldn't call exit(1) on report_fatal_error()
​https://bugs.webkit.org/show_bug.cgi?id=122905
<rdar://problem/15237856>

Source/JavaScriptCore:

Reviewed by Michael Saboff.

Expose the new LLVMInstallFatalErrorHandler() API through the soft linking magic and
then always call it to install something that calls CRASH().

  • llvm/InitializeLLVM.cpp:

(JSC::llvmCrash):
(JSC::initializeLLVMOnce):
(JSC::initializeLLVM):

  • llvm/LLVMAPIFunctions.h:

WebKitLibraries:

Reviewed by Michael Saboff.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
8:36 PM Changeset in webkit [157557] by fpizlo@apple.com
  • 2 edits in trunk/Tools

We need test coverage for just the Baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=122929

Reviewed by Sam Weinig.

Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
variant.

  • Scripts/run-jsc-stress-tests:
8:29 PM Changeset in webkit [157556] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Prototype chain repatching in the polymorphic case fails to check if the receiver is a dictionary
​https://bugs.webkit.org/show_bug.cgi?id=122938

Reviewed by Sam Weinig.

This fixes jsc-layout-tests.yaml/js/script-tests/dictionary-prototype-caching.js.layout-no-llint.

  • jit/Repatch.cpp:

(JSC::tryBuildGetByIDList):

8:10 PM Changeset in webkit [157555] by rniwa@webkit.org
  • 1 edit
    19 adds in trunk

Add a new flakiness dashboard clone
​https://bugs.webkit.org/show_bug.cgi?id=122936

Reviewed by Anders Carlsson.

Added the initial prototype.

  • Websites/test-results: Added.
  • Websites/test-results/.htaccess: Added.
  • Websites/test-results/admin: Added.
  • Websites/test-results/admin/index.php: Added.
  • Websites/test-results/api: Added.
  • Websites/test-results/api/manifest.php: Added.
  • Websites/test-results/api/report.php: Added.
  • Websites/test-results/api/results.php: Added.
  • Websites/test-results/include: Added.
  • Websites/test-results/include/config.json: Added.
  • Websites/test-results/include/db.php: Added.
  • Websites/test-results/include/init-database.sql: Added.
  • Websites/test-results/include/json-shared.php: Added.
  • Websites/test-results/include/test-results.php: Added.
  • Websites/test-results/index.html: Added.
  • Websites/test-results/js: Added.
  • Websites/test-results/js/autocompleter.js: Added.
  • Websites/test-results/js/build.js: Added.
  • Websites/test-results/js/dom.js: Added.
8:01 PM Changeset in webkit [157554] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JIT::appendCall() needs to killLastResultRegister() or equivalent since there's some really bad code that expects it
​https://bugs.webkit.org/show_bug.cgi?id=122937

Reviewed by Geoffrey Garen.

JITStubCall used to do it.

This makes mozilla-tests.yaml/ecma/Statements/12.10-1.js.mozilla-baseline pass.

  • jit/JIT.h:

(JSC::JIT::appendCall):

7:36 PM Changeset in webkit [157553] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Support multiple repositories in submitting results to --results-server-host
​https://bugs.webkit.org/show_bug.cgi?id=122935

Reviewed by Anders Carlsson.

Remoevd --got-revision and added the logic to extract revision information
from multiple repositories as done in run-perf-tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.upload_results):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

7:12 PM Changeset in webkit [157552] by jinwoo7.song@samsung.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r155607.

  • platform/efl-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Added.
  • platform/efl-wk2/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Added.
7:04 PM Changeset in webkit [157551] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/win

Attempt to fix the Windows build after ​http://trac.webkit.org/changeset/157547.

Apparently some *more* Windows code uses setFrame and I missed it.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):

6:58 PM Changeset in webkit [157550] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Windows build after ​http://trac.webkit.org/changeset/157547.

The relevant conversion doesn't happen implicitly.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):

6:54 PM Changeset in webkit [157549] by jinwoo7.song@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r156527.

  • platform/efl/compositing/contents-opaque/hidden-with-visible-text-expected.txt:
  • platform/efl/svg/text/append-text-node-to-tspan-expected.txt:
6:53 PM Changeset in webkit [157548] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Windows build after ​http://trac.webkit.org/changeset/157547.

Apparently some Windows code uses setFrame and I missed it.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):

6:46 PM Changeset in webkit [157547] by timothy_horton@apple.com
  • 13 edits in trunk/Source

Remote Layer Tree: Complete support for simple layer properties
​https://bugs.webkit.org/show_bug.cgi?id=122933

Reviewed by Anders Carlsson.

Add remote layer tree support for maskLayer, contentsRect, contentsScale,
minificationFilter, magnificationFilter, speed, and timeOffset.

No new tests, not yet testable.

  • Shared/mac/RemoteLayerTreeTransaction.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpProperty):
(WebKit::dumpChangedLayers):
Add the new properties.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::toCAFilterType):
(WebKit::RemoteLayerTreeHost::commit):
Apply the new properties.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::setSublayers):
(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Ensure that passed-in sublayers are always also PlatformCALayerRemote instances.
These are ASSERT_WITH_SECURITY_IMPLICATION as we will later unconditionally static_cast
them to PlatformCALayerRemote.

(PlatformCALayerRemote::setMask):
(PlatformCALayerRemote::setContentsRect):
(PlatformCALayerRemote::setMinificationFilter):
(PlatformCALayerRemote::setMagnificationFilter):
(PlatformCALayerRemote::setSpeed):
(PlatformCALayerRemote::setTimeOffset):
(PlatformCALayerRemote::contentsScale):
(PlatformCALayerRemote::setContentsScale):
Remove setFrame, store the new properties.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Remove setFrame, add isRemote, fix pointer side on playerLayer.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setName):
Don't dump the CALayer pointer if we own a PlatformCALayerRemote.

(WebCore::GraphicsLayerCA::recursiveCommitChanges):
Fix the visible tile wash (my fault!), and make it use setPosition and
setBounds instead of setFrame; while more convenient, it is the only
caller of setFrame, so we'll remove it.

  • platform/graphics/ca/PlatformCALayer.h:

(WebCore::PlatformCALayer::isRemote): Added.

  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(nullActionsDictionary):
(toCAFilterType):
(PlatformCALayerMac::synchronouslyDisplayTilesInRect):
(PlatformCALayerMac::playerLayer):
Remove setFrame, fix some pointer sides.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
  • platform/graphics/ca/win/PlatformCALayerWin.h:

Remove setFrame.

6:23 PM Changeset in webkit [157546] by msaboff@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

transition void cti_op_put_by_val* stubs to JIT operations
​https://bugs.webkit.org/show_bug.cgi?id=122903

Reviewed by Geoffrey Garen.

Transitioned cti_op_put_by_val and cti_op_put_by_val_generic to operationPutByVal and
operationPutByValGeneric.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompilePutByVal):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_put_by_val):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JSInterfaceJIT.h:
6:02 PM Changeset in webkit [157545] by oliver@apple.com
  • 16 edits
    3 adds in trunk

Source/JavaScriptCore: Implement ES6 spread operator
​https://bugs.webkit.org/show_bug.cgi?id=122911

Reviewed by Michael Saboff.

Implement the ES6 spread operator

This has a little bit of refactoring to move the enumeration logic out ForOfNode
and into BytecodeGenerator, and then adds the logic to make it nicely callback
driven.

The rest of the logic is just the addition of the SpreadExpressionNode, the parsing,
and actually handling the spread.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitEnumeration):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SpreadExpressionNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createSpreadExpression):

  • parser/Lexer.cpp:

(JSC::::lex):

  • parser/NodeConstructors.h:

(JSC::SpreadExpressionNode::SpreadExpressionNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isSpreadExpression):
(JSC::SpreadExpressionNode::expression):

  • parser/Parser.cpp:

(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):

  • parser/Parser.h:

(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):

  • parser/ParserTokens.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createSpreadExpression):

LayoutTests: Implement spread
​https://bugs.webkit.org/show_bug.cgi?id=122911

Reviewed by Michael Saboff.

Add testcases

  • js/basic-spread-expected.txt: Added.
  • js/basic-spread.html: Added.
  • js/parser-syntax-check-expected.txt:
  • js/script-tests/basic-spread.js: Added.

(f):
(o.f.o.f.o.f.o.f.h.eval.o.h.o.h.o.h.o.h.g):

  • js/script-tests/parser-syntax-check.js:
5:25 PM Changeset in webkit [157544] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source

Unreviewed build fix attempt on EFL port after r157520 and r157523

Source/WebKit2:

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

Removed ArgumentCoder<TransformationMatrix> which caused redefinition build error
in EFL port.

Source/WTF:

  • wtf/PassRef.h: includes <utility>
5:15 PM Changeset in webkit [157543] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add a useLLInt option to jsc
​https://bugs.webkit.org/show_bug.cgi?id=122930

Reviewed by Geoffrey Garen.

  • runtime/Executable.cpp:

(JSC::setupLLInt):
(JSC::setupJIT):
(JSC::ScriptExecutable::prepareForExecutionImpl):

  • runtime/Options.h:
4:57 PM Changeset in webkit [157542] by mhahnenberg@apple.com
  • 1 edit
    1 add in trunk/Source/JavaScriptCore

Build fix.

Forgot to svn add DeferGC.cpp

  • heap/DeferGC.cpp: Added.
4:49 PM Changeset in webkit [157541] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

r157411 fails run-javascriptcore-tests when run with Baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=122902

Reviewed by Mark Hahnenberg.

It turns out that this was a long-standing bug in the DFG PutById repatching logic. It's
not legal to patch if the typeInfo tells you that you can't patch. The old JIT's patching
logic did this right, and the DFG's GetById patching logic did it right; but DFG PutById
didn't. Turns out that there's even a helpful method,
Structure::propertyAccessesAreCacheable(), that will even do all of the checks for you!

  • jit/Repatch.cpp:

(JSC::tryCachePutByID):

4:48 PM Changeset in webkit [157540] by ggaren@apple.com
  • 3 edits in trunk/Websites/webkit.org

Publish SunSpider 1.0.2
​https://bugs.webkit.org/show_bug.cgi?id=122923

Reviewed by Darin Adler.

  • perf/sunspider/sunspider.html:
  • perf/sunspider/versions.html:
4:47 PM Changeset in webkit [157539] by mhahnenberg@apple.com
  • 17 edits in trunk/Source/JavaScriptCore

llint_slow_path_put_by_id can deadlock on a ConcurrentJITLock
​https://bugs.webkit.org/show_bug.cgi?id=122667

Reviewed by Geoffrey Garen.

The issue this patch is attempting to fix is that there are places in our codebase
where we acquire the ConcurrentJITLock for a particular CodeBlock, then we do some
operations that can initiate a garbage collection. Garbage collection then calls
some methods of CodeBlock that also take the ConcurrentJITLock (because they don't
always necessarily run during garbage collection). This causes a deadlock.

To fix this issue, this patch adds a new RAII-style object (DisallowGC) that stores
into a thread-local field that indicates that it is unsafe to perform any operation
that could trigger garbage collection on the current thread. In debug builds,
ConcurrentJITLocker contains one of these DisallowGC objects so that we can eagerly
detect deadlocks.

This patch also adds a new type of ConcurrentJITLocker, GCSafeConcurrentJITLocker,
which uses the DeferGC mechanism to prevent collections from occurring while the
lock is held.

(JSC::DisallowGC::DisallowGC):
(JSC::DisallowGC::~DisallowGC):
(JSC::DisallowGC::isGCDisallowedOnCurrentThread):
(JSC::DisallowGC::initialize):

  • jit/Repatch.cpp:

(JSC::repatchPutByID):
(JSC::buildPutByIdList):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ConcurrentJITLock.h:

(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::~ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::unlockEarly):
(JSC::GCSafeConcurrentJITLocker::GCSafeConcurrentJITLocker):
(JSC::GCSafeConcurrentJITLocker::~GCSafeConcurrentJITLocker):
(JSC::GCSafeConcurrentJITLocker::NoDefer::NoDefer):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSCellInlines.h:

(JSC::allocateCell):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):

  • runtime/Structure.cpp: materializePropertyMapIfNecessary* now has a problem in that it

can start a garbage collection when the GCSafeConcurrentJITLocker goes out of scope, but
before the caller has a chance to use the newly created PropertyTable. The garbage collection
clears the PropertyTable, and then the caller uses it assuming it's valid. To avoid this,
we must DeferGC until the caller is done getting the newly materialized PropertyTable from
the Structure.
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::addPropertyWithoutTransition):
(JSC::Structure::removePropertyWithoutTransition):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):

  • runtime/Structure.h:

(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):

  • runtime/StructureInlines.h:

(JSC::Structure::get):

  • runtime/SymbolTable.h:

(JSC::SymbolTable::find):
(JSC::SymbolTable::end):

4:42 PM Changeset in webkit [157538] by andersca@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove Qt sandbox process code
​https://bugs.webkit.org/show_bug.cgi?id=122920

Reviewed by Geoffrey Garen.

This code was only used by the Qt port, and the other Linux-based ports are using the seccomp based sandbox.

  • Shared/linux/SandboxProcess/SandboxEnvironmentLinux.cpp: Removed.
  • Shared/linux/SandboxProcess/SandboxEnvironmentLinux.h: Removed.
4:36 PM Changeset in webkit [157537] by dbates@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

Add SPI to disable the garbage collector timer
​https://bugs.webkit.org/show_bug.cgi?id=122921

Reviewed by Geoffrey Garen.

Based on a patch by Mark Hahnenberg.

  • API/JSBase.cpp:

(JSDisableGCTimer): Added; SPI function.

  • API/JSBasePrivate.h:
  • heap/BlockAllocator.cpp:

(JSC::createBlockFreeingThread): Added.
(JSC::BlockAllocator::BlockAllocator): Modified to use JSC::createBlockFreeingThread()
to conditionally create the "block freeing" thread depending on the value of
GCActivityCallback::s_shouldCreateGCTimer.
(JSC::BlockAllocator::~BlockAllocator):

  • heap/BlockAllocator.h:

(JSC::BlockAllocator::deallocate):

  • heap/Heap.cpp:

(JSC::Heap::didAbandon):
(JSC::Heap::collect):
(JSC::Heap::didAllocate):

  • heap/HeapTimer.cpp:

(JSC::HeapTimer::timerDidFire):

  • runtime/GCActivityCallback.cpp:
  • runtime/GCActivityCallback.h:

(JSC::DefaultGCActivityCallback::create): Only instantiate a DefaultGCActivityCallback object
when GCActivityCallback::s_shouldCreateGCTimer is true so as to prevent allocating a HeapTimer
object (since DefaultGCActivityCallback ultimately extends HeapTimer).

3:33 PM Changeset in webkit [157536] by commit-queue@webkit.org
  • 15 edits
    3 deletes in trunk

Unreviewed, rolling out r157529.
​http://trac.webkit.org/changeset/157529
​https://bugs.webkit.org/show_bug.cgi?id=122919

Caused score test failures and some build failures. (Requested
by rfong on #webkit).

Source/JavaScriptCore:

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):
(JSC::CallArguments::CallArguments):
(JSC::ForOfNode::emitBytecode):
(JSC::BindingNode::collectBoundIdentifiers):

  • parser/ASTBuilder.h:
  • parser/Lexer.cpp:

(JSC::::lex):

  • parser/NodeConstructors.h:

(JSC::DotAccessorNode::DotAccessorNode):

  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):

  • parser/Parser.h:

(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):

  • parser/ParserTokens.h:
  • parser/SyntaxChecker.h:

LayoutTests:

  • js/basic-spread-expected.txt: Removed.
  • js/basic-spread.html: Removed.
  • js/parser-syntax-check-expected.txt:
  • js/script-tests/basic-spread.js: Removed.
  • js/script-tests/parser-syntax-check.js:
3:28 PM Changeset in webkit [157535] by akling@apple.com
  • 167 edits in trunk/Source/WebCore

Take RenderObjects out of the arena.
<​https://webkit.org/b/122895>

Reviewed by Antti Koivisto.

Stop arena-allocating renderers so we can move forward on improving
render tree memory management. This will also allow rendering code
to take advantage of malloc optimizations.

Line boxes and BiDi runs remain in the arena for now.

3:20 PM Changeset in webkit [157534] by jochen@chromium.org
  • 13 edits
    2 adds in trunk

A page should exit fullscreen mode if it opens a new popup
​https://bugs.webkit.org/show_bug.cgi?id=122865

Reviewed by Jer Noble.

Source/WebKit/blackberry:

If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.

  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::createWindow):

Source/WebKit/efl:

If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::createWindow):

Source/WebKit/gtk:

If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::createWindow):

Source/WebKit/mac:

If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::createWindow):

Source/WebKit/win:

If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::createWindow):

Source/WebKit2:

If a fullscreen page opens a popup, the popup would be hidden and
therefore invisible to the user. To avoid this, exit fullscreen mode
before opening a new window.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

LayoutTests:

  • fullscreen/full-screen-exit-when-popup-expected.txt: Added.
  • fullscreen/full-screen-exit-when-popup.html: Added.
3:17 PM Changeset in webkit [157533] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Speculative fix for test, media/video-canvas-drawing-output.html.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::createImageForTimeInRect):

3:10 PM Changeset in webkit [157532] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove useless architecture specific implementation in DFG.
​https://bugs.webkit.org/show_bug.cgi?id=122917.

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.

With CPU(ARM) && CPU(ARM_HARDFP) architecture, the fallback implementation is fine
as FPRInfo::argumentFPR0 == FPRInfo::returnValueFPR in this case.

  • dfg/DFGSpeculativeJIT.h:
3:02 PM Changeset in webkit [157531] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Blind attempt to fix non-DATABASE_PROCESS builds.

  • WebProcess/WebProcess.cpp:
2:37 PM Changeset in webkit [157530] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused JIT::restoreArgumentReferenceForTrampoline function.
​https://bugs.webkit.org/show_bug.cgi?id=122916.

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-16
Reviewed by Michael Saboff.

This architecture specific function is not used anymore, so get rid of it.

  • jit/JIT.h:
  • jit/JITInlines.h:
2:27 PM Changeset in webkit [157529] by oliver@apple.com
  • 15 edits
    3 adds in trunk

Source/JavaScriptCore: Implement ES6 spread operator
​https://bugs.webkit.org/show_bug.cgi?id=122911

Reviewed by Michael Saboff.

Implement the ES6 spread operator

This has a little bit of refactoring to move the enumeration logic out ForOfNode
and into BytecodeGenerator, and then adds the logic to make it nicely callback
driven.

The rest of the logic is just the addition of the SpreadExpressionNode, the parsing,
and actually handling the spread.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitEnumeration):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SpreadExpressionNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createSpreadExpression):

  • parser/Lexer.cpp:

(JSC::::lex):

  • parser/NodeConstructors.h:

(JSC::SpreadExpressionNode::SpreadExpressionNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isSpreadExpression):
(JSC::SpreadExpressionNode::expression):

  • parser/Parser.cpp:

(JSC::::parseArrayLiteral):
(JSC::::parseArguments):
(JSC::::parseMemberExpression):

  • parser/Parser.h:

(JSC::Parser::getTokenName):
(JSC::Parser::updateErrorMessageSpecialCase):

  • parser/ParserTokens.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createSpreadExpression):

LayoutTests: Implement spread
​https://bugs.webkit.org/show_bug.cgi?id=122911

Reviewed by Michael Saboff.

Add testcases

  • js/basic-spread-expected.txt: Added.
  • js/basic-spread.html: Added.
  • js/parser-syntax-check-expected.txt:
  • js/script-tests/basic-spread.js: Added.

(f):
(o.f.o.f.o.f.o.f.h.eval.o.h.o.h.o.h.o.h.g):

  • js/script-tests/parser-syntax-check.js:
2:20 PM Changeset in webkit [157528] by timothy_horton@apple.com
  • 6 edits in trunk/Source

PlatformCALayer constructor should take layer type as an argument
​https://bugs.webkit.org/show_bug.cgi?id=122915

Reviewed by Simon Fraser.

No new tests, just a minor refactoring.

  • platform/graphics/ca/PlatformCALayer.h:

(WebCore::PlatformCALayer::PlatformCALayer):
Add a LayerType argument.

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::PlatformCALayerMac):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::PlatformCALayerWin):
Use the new LayerType argument, and early-return in the case where we
are wrapping a custom PlatformLayer.
Drive-by un-indent the switch in the Mac version.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::PlatformCALayerRemote):
Use the new LayerType argument.

2:19 PM Changeset in webkit [157527] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remote Layer Tree: Use a default instead of an environment variable
​https://bugs.webkit.org/show_bug.cgi?id=122913

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm:

(-[WKView std::WebKit::]):
Use the default 'WebKit2UseRemoteLayerTreeDrawingArea' instead of
the environment variable 'WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA'
to indicate that WKViews should make RemoteLayerTreeDrawingAreas.

1:47 PM Changeset in webkit [157526] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

1:01 PM Changeset in webkit [157525] by Lucas Forschler
  • 1 copy in tags/Safari-538.2

New Tag.

12:27 PM Changeset in webkit [157524] by beidson@apple.com
  • 19 edits
    4 copies
    2 adds in trunk/Source

Flesh out the DatabaseProcess (and launch it!)
​https://bugs.webkit.org/show_bug.cgi?id=122884

Reviewed by Tim Horton.

Source/WebCore:

  • English.lproj/Localizable.strings: Add a localizable string.
  • WebCore.xcodeproj/project.pbxproj: Export some more headers.

Source/WebKit2:

This patch adds actual process launching and basic messaging infrastructure for the DatabaseProcess.

It still does very little except exist.

Project file stuff:

  • WebKit2.xcodeproj/project.pbxproj:
  • DerivedSources.make:

WebContext owns the DatabaseProcess (much like the NetworkProcess):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureDatabaseProcess):
(WebKit::WebContext::getDatabaseProcessConnection):

  • UIProcess/WebContext.h:

Add a basic DatabaseProcess that - for now - can only return a new Connection for a WebProcess:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/DatabaseProcess.messages.in: Added.

Add an object to represent a single connection to a single WebProcess:

  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::create):
(WebKit::DatabaseToWebProcessConnection::DatabaseToWebProcessConnection):
(WebKit::DatabaseToWebProcessConnection::~DatabaseToWebProcessConnection):
(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::didClose):
(WebKit::DatabaseToWebProcessConnection::didReceiveInvalidMessage):

  • DatabaseProcess/DatabaseToWebProcessConnection.h:

Basic DatabaseProcessProxy with the ability to ask the DatabaseProcess for a connection to hand back to a WebProcess:

  • UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):
(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
(WebKit::DatabaseProcessProxy::didFinishLaunching):

  • UIProcess/Databases/DatabaseProcessProxy.h:
  • UIProcess/Databases/DatabaseProcessProxy.messages.in: Added.

Add an object to represent a WebProcess’s connection to a DatabaseProcess:

  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:

(WebKit::WebToDatabaseProcessConnection::WebToDatabaseProcessConnection):
(WebKit::WebToDatabaseProcessConnection::~WebToDatabaseProcessConnection):
(WebKit::WebToDatabaseProcessConnection::didReceiveMessage):
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::didReceiveInvalidMessage):

  • WebProcess/Databases/WebToDatabaseProcessConnection.h:

(WebKit::WebToDatabaseProcessConnection::create):
(WebKit::WebToDatabaseProcessConnection::connection):

Give WebProcess(Proxy) an accessor for a Web -> Database process connection:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webToDatabaseProcessConnectionClosed):
(WebKit::WebProcess::webToDatabaseProcessConnection):
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection):

  • WebProcess/WebProcess.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getDatabaseProcessConnection):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::open): Access the database process connection to test that it works.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createIDBFactoryBackend): Keep non-DATABASE_PROCESS builds working.

12:04 PM Changeset in webkit [157523] by timothy_horton@apple.com
  • 13 edits in trunk/Source

RemoteLayerTree: Add support for more layer properties and transform layers
​https://bugs.webkit.org/show_bug.cgi?id=122906

Reviewed by Anders Carlsson.

Add support for name, border width, border color, opacity, transform, sublayer transform,
hidden, geometry flipped, double sided, masks to bounds, and opaque layer properties.

Factor layer creation out from layer changes, so that we can create layers of the correct
type. Use this mechanism to create CATransformLayers when handed a LayerTypeTransformLayer.

No new tests, this code is not yet testable.

  • WebCore.exp.in:

Export some TextStream and TransformationMatrix stuff.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

  • Shared/WebCoreArgumentCoders.h:

Add coders for TransformationMatrix.

  • Shared/mac/RemoteLayerTreeTransaction.h:

Add the new LayerChange values.

(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):
LayerProperties::layerChanges should be a LayerChange.

(WebKit::RemoteLayerTreeTransaction::createdLayers):
Expose the list of newly created layers (for RemoteLayerTreeHost's consumption).

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
Add (and support coding) a new LayerCreationProperties struct, which is currently
just a pair of LayerID and PlatformCALayer::LayerType. Additional properties may follow.

(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode all of the new layer properties.
Encode changedProperties as an enum, not an unsigned.

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Encode and decode the list of newly created layers.

(WebKit::RemoteLayerTreeTransaction::setCreatedLayers):
Setter for the list of newly created layers, which comes from the
RemoteLayerTreeContext at commit time.

(WebKit::dumpProperty):
Helper function to dump TransformationMatrix instances.

(WebKit::dumpChangedLayers):
Dump all of the new layer properties.

(WebKit::RemoteLayerTreeTransaction::dump):
Dump the list of newly created layers.

  • UIProcess/mac/RemoteLayerTreeHost.h:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::cgColorFromColor):
Factor out the code to make a CGColor from a WebCore::Color, as we need it
for both border and background color.

(WebKit::RemoteLayerTreeHost::commit):
Create layers before applying changes, using the new list of newly created layers.
When applying changes, ensure that the layer we're interested in was already created.
Rename "sublayer" to "layer", and use dot notation everywhere.
Apply all the new layer properties to the layers.

(WebKit::RemoteLayerTreeHost::getLayer):
(WebKit::RemoteLayerTreeHost::createLayer):
Separate creating a new layer from retrieving it by ID.
Ensure that a layer doesn't already exist when creating it.
Support creating CATransformLayers.

  • WebProcess/WebPage/mac/GraphicsLayerCARemote.h:

Disable accelerated animations, as we don't support proxying animations yet.
This makes GraphicsLayer fall back to software animations, which already work wonderfully remotely.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::PlatformCALayerRemote):
Inform the RemoteLayerTreeContext of the creation of every PlatformCALayerRemote.

(PlatformCALayerRemote::removeFromSuperlayer):
(PlatformCALayerRemote::replaceSublayer):
(PlatformCALayerRemote::adoptSublayers):
Assert when we hit a few critical unimplemented methods that would
leave the layer tree in a broken state.

(PlatformCALayerRemote::isOpaque):
(PlatformCALayerRemote::setOpaque):
(PlatformCALayerRemote::transform):
(PlatformCALayerRemote::setTransform):
(PlatformCALayerRemote::sublayerTransform):
(PlatformCALayerRemote::setSublayerTransform):
(PlatformCALayerRemote::setHidden):
(PlatformCALayerRemote::setGeometryFlipped):
(PlatformCALayerRemote::isDoubleSided):
(PlatformCALayerRemote::setDoubleSided):
(PlatformCALayerRemote::masksToBounds):
(PlatformCALayerRemote::setMasksToBounds):
(PlatformCALayerRemote::setBorderWidth):
(PlatformCALayerRemote::setBorderColor):
(PlatformCALayerRemote::opacity):
(PlatformCALayerRemote::setOpacity):
(PlatformCALayerRemote::setName):
Proxy all of these properties via RemoteLayerTreeTransaction.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:

Add storage for the list of newly created layers.
Use LayerID for the list of destroyed layers.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWasCreated):
Store the ID and type of the newly created layer to be pushed to the UI process later.

(WebKit::RemoteLayerTreeContext::flushLayers):
Push the created and destroyed layers to the transaction *after* flushing
GraphicsLayers, so that any changes to e.g. structural layers will not be missed.

10:35 AM Changeset in webkit [157522] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

During editing, merge inline style with overriding other author styles
​https://bugs.webkit.org/show_bug.cgi?id=122874

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2013-10-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

Inline styles need to override other author styles even on DoNotOverrideValues mode.
So, merge and override inline styles to other author styles before merging them to m_mutableStyle.

Test: editing/deleting/merge-div-with-inline-style.html

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):

LayoutTests:

Add a test for merging inline styles of parents.

  • editing/deleting/merge-div-with-inline-style.html: Added.
  • editing/deleting/merge-div-with-inline-style-expected.txt: Added.
10:26 AM Changeset in webkit [157521] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Transition void cti_op_tear_off* methods to JIT operations for 32 bit.
​https://bugs.webkit.org/show_bug.cgi?id=122899.

Reviewed by Michael Saboff.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
10:18 AM Changeset in webkit [157520] by Darin Adler
  • 13 edits
    1 add in trunk

Add PassRef and createRefCounted so we can improve creation of RefCounted objects
​https://bugs.webkit.org/show_bug.cgi?id=122904

Reviewed by Anders Carlsson.

Source/WTF:

  • GNUmakefile.list.am: Added PassRef.h.
  • WTF.vcxproj/WTF.vcxproj: Ditto.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
  • WTF.xcodeproj/project.pbxproj: Ditto.
  • wtf/CMakeLists.txt: Ditto.
  • wtf/Forward.h: Added PassRef. Also re-sorted and un-indented to match what

the style-checking script expects.

  • wtf/PassRef.h: Added. Includes the createRefCounted function template, which

is analogous to make_unique, but is for reference counted objects, and also
assumes that new will never return null. Also includes an overload of adoptRef
that takes a reference rather than a pointer.

  • wtf/PassRefPtr.h: Include "PassRef.h" so we can share the adopted function.

Got rid of declarations that duplicate ones in there.
(WTF::refIfNotNull): Use nullptr.
(WTF::derefIfNotNull): Use nullptr.
(WTF::PassRefPtr::PassRefPtr): Use nullptr. Added an overload that takes a PassRef.
(WTF::PassRefPtr::operator UnspecifiedBoolType): Use nullptr.
(WTF::PassRefPtr::operator=): Made this deleted instead of compile time assertion.
(WTF::PassRefPtr::PassRefPtr): Made adopting constructor use an adopt tag instead
of an unused boolean.
(WTF::PassRefPtr::leakRef): Use nullptr.
(WTF::adoptRef): Use the adopt tag.

  • wtf/Ref.h: Use Noncopyable instead of rolling our own.

(WTF::Ref::Ref): Add an overload that takes a PassRef.
(WTF::Ref::operator=): Ditto.

  • wtf/RefPtr.h: Removed unneeded forward declaration of PassRefPtr.

(WTF::RefPtr::RefPtr): Use nullptr. Added overload that takes a PassRef.
(WTF::RefPtr::release): Use nullptr.
(WTF::RefPtr::operator UnspecifiedBoolType): Use nullptr.
(WTF::RefPtr::operator=): Added overload that takes a PassRef.
(WTF::RefPtr::clear): Use nullptr.

  • wtf/StdLibExtras.h: Added inline keyword to isPointerTypeAlignmentOkay,

reinterpret_cast_ptr, and make_unique. Seems like a simple oversight that these
were missing before.

Tools:

  • TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
10:11 AM Changeset in webkit [157519] by Darin Adler
  • 2 edits in trunk/Tools

Need tests for RefPtr self-assignment and self-move-assignment.

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
9:57 AM Changeset in webkit [157518] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Emphasis marks has wrong color.
​https://bugs.webkit.org/show_bug.cgi?id=122829

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-16
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/text/text-emphasis.html.

fast/text/text-emphasis-expected.html.

Emphasis color should be set as fill color, not stroke color.

  • rendering/TextPaintStyle.cpp:

(WebCore::updateGraphicsContext):

  • rendering/TextPaintStyle.h:

LayoutTests:

  • fast/text/text-emphasis-expected.html: Added.
  • fast/text/text-emphasis.html: Added.
7:33 AM Changeset in webkit [157517] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Move code for finding rendered character offset to RenderTextLineBoxes
​https://bugs.webkit.org/show_bug.cgi?id=122892

Reviewed by Andreas Kling.

  • rendering/RenderText.cpp:

(WebCore::RenderText::countRenderedCharacterOffsets):
(WebCore::RenderText::containsRenderedCharacterOffset):

Renamed for consistency.

  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::countCharacterOffsets):

This used to be Position::renderedPosition.

6:03 AM Changeset in webkit [157516] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.2.1

Tagging the WebKitGTK+ 2.2.1 release

5:40 AM Changeset in webkit [157515] by akling@apple.com
  • 28 edits in trunk/Source/WebCore

RenderElement::removeChild() should take child as a reference.
<​https://webkit.org/b/122888>

We can't remove a child without a child to remove.

Reviewed by Antti Koivisto.

5:24 AM Changeset in webkit [157514] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Move test for contained caret offset to RenderTextLineBoxes
​https://bugs.webkit.org/show_bug.cgi?id=122887

Reviewed by Andreas Kling.

  • dom/Position.cpp:

(WebCore::Position::renderedOffset):
(WebCore::Position::isCandidate):

Remove isRenderedText, call RenderText::containsCaretOffset instead.

(WebCore::Position::isRenderedCharacter):
(WebCore::Position::rendersInDifferentPosition):

  • dom/Position.h:
  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::containsCharacterOffset):
(WebCore::RenderText::containsCaretOffset):

  • rendering/RenderText.h:
  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::containsOffset):

Combined implementations of Position::isRenderedCharacter and Position::isRenderedText.

  • rendering/RenderTextLineBoxes.h:


Remove containsCaretOffset(), functionality is now in RenderTextLineBoxes::containsOffset.

4:07 AM Changeset in webkit [157513] by jinwoo7.song@samsung.com
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r155998.

  • platform/efl-wk2/compositing/contents-scale/animating-expected.txt: Added.
  • platform/efl-wk2/compositing/contents-scale/scaled-ancestor-expected.txt: Added.
  • platform/efl-wk2/compositing/contents-scale/simple-scale-expected.txt: Added.
  • platform/efl-wk2/compositing/contents-scale/z-translate-expected.txt: Added.
3:34 AM Changeset in webkit [157512] by ryuan.choi@samsung.com
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip the IndexedDB tests for now as the feature is going through substantial
changes that don't ensure constant proper functionality.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:29 AM Changeset in webkit [157511] by akling@apple.com
  • 1 edit
    51 adds in trunk/LayoutTests

Revert Windows-specific expectations shuffling from r157497.
This wasn't wrong either. Shame on me. :|

2:52 AM Changeset in webkit [157510] by jinwoo7.song@samsung.com
  • 7 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r155957.

  • platform/efl/css3/selectors3/html/css3-modsel-179a-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-179a-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-179a-expected.txt:
  • platform/efl/fast/css/pseudo-first-line-border-width-expected.txt:
  • platform/efl/fast/css/word-space-extra-expected.txt:
  • platform/efl/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
2:34 AM Changeset in webkit [157509] by akling@apple.com
  • 26 edits in trunk/Source/WebCore

RenderElement::isChildAllowed() should take const references.
<​https://webkit.org/b/122870>

Reviewed by Anders Carlsson.

The isChildAllowed() functions expect non-null values to be passed,
so enforce this at compile-time.

Reordered some checks to do bit tests before virtual calls.

2:24 AM Changeset in webkit [157508] by akling@apple.com
  • 1 edit
    22 adds in trunk/LayoutTests

Revert Mac-specific expecations shuffling from r157498.
Everything was already in order.

2:23 AM Changeset in webkit [157507] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.1 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
2:18 AM Changeset in webkit [157506] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] video info unset if upstream doesn't query allocation
​https://bugs.webkit.org/show_bug.cgi?id=122834

Reviewed by Gustavo Noronha Silva.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender): If the sink didn't process any allocation
query then use the configured source pad caps and don't rely on
invalid video info.

2:15 AM Changeset in webkit [157505] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] move Logging.h include to GStreamerUtilities.h
​https://bugs.webkit.org/show_bug.cgi?id=122886

Reviewed by Gustavo Noronha Silva.

Include Logging.h from GStreamerUtilities.h so the modules using
the LOG_MEDIA macros don't need to bother, especially for Debug builds.

  • platform/graphics/gstreamer/GStreamerUtilities.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
2:07 AM Changeset in webkit [157504] by Csaba Osztrogonác
  • 6 edits in trunk

[WK2][Efl][CMake] Add support for ENABLE_NETWORK_PROCESS to the build system
​https://bugs.webkit.org/show_bug.cgi?id=110139

Reviewed by Laszlo Gombos.

Original patch by Balazs Kelemen <​kbalazs@webkit.org>

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit2:

  • CMakeLists.txt:
  • PlatformEfl.cmake:
1:51 AM Changeset in webkit [157503] by akling@apple.com
  • 1 edit
    347 deletes in trunk/LayoutTests

Remove EFL-specific test expectations that were identical to generic expectations.
<​https://webkit.org/b/121551>

Reviewed by Antti Koivisto.

  • platform/efl-wk2/webaudio/javascriptaudionode-expected.txt: Removed.
  • platform/efl/compositing/culling/filter-occlusion-blur-expected.txt: Removed.
  • platform/efl/compositing/culling/filter-occlusion-blur-large-expected.txt: Removed.
  • platform/efl/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Removed.
  • platform/efl/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt: Removed.
  • platform/efl/compositing/iframes/composited-iframe-scroll-expected.txt: Removed.
  • platform/efl/compositing/iframes/iframe-content-flipping-expected.txt: Removed.
  • platform/efl/compositing/iframes/repaint-after-losing-scrollbars-expected.txt: Removed.
  • platform/efl/compositing/images/content-image-change-expected.txt: Removed.
  • platform/efl/css1/units/rounding-expected.txt: Removed.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
  • platform/efl/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-circle-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-circle-filter-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-circle-overflow-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-ellipse-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-polygon-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
  • platform/efl/css3/masking/clip-path-rectangle-expected.txt: Removed.
  • platform/efl/editing/deleting/transpose-empty-expected.txt: Removed.
  • platform/efl/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
  • platform/efl/editing/selection/drag-start-event-client-x-y-expected.txt: Removed.
  • platform/efl/fast/backgrounds/bgCompositeCopy-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize01-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize02-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize03-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize04-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize05-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize06-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize07-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize08-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize09-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize10-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize11-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize12-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize13-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/backgroundSize14-expected.txt: Removed.
  • platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/efl/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Removed.
  • platform/efl/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Removed.
  • platform/efl/fast/block/float/008-expected.txt: Removed.
  • platform/efl/fast/block/float/009-expected.txt: Removed.
  • platform/efl/fast/block/float/019-expected.txt: Removed.
  • platform/efl/fast/block/float/034-expected.txt: Removed.
  • platform/efl/fast/block/float/035-expected.txt: Removed.
  • platform/efl/fast/block/float/4145535Crash-expected.txt: Removed.
  • platform/efl/fast/block/float/br-with-clear-2-expected.txt: Removed.
  • platform/efl/fast/block/float/float-forced-below-other-floats-expected.txt: Removed.
  • platform/efl/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
  • platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
  • platform/efl/fast/block/float/float-on-zero-height-line-expected.txt: Removed.
  • platform/efl/fast/block/float/float-overhangs-root-expected.txt: Removed.
  • platform/efl/fast/block/float/narrow-after-wide-expected.txt: Removed.
  • platform/efl/fast/block/float/negative-margin-clear-expected.txt: Removed.
  • platform/efl/fast/block/float/nested-clearance-expected.txt: Removed.
  • platform/efl/fast/block/float/nowrap-clear-min-width-expected.txt: Removed.
  • platform/efl/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Removed.
  • platform/efl/fast/block/float/relative-painted-twice-expected.txt: Removed.
  • platform/efl/fast/block/positioning/003-expected.txt: Removed.
  • platform/efl/fast/block/positioning/004-expected.txt: Removed.
  • platform/efl/fast/block/positioning/005-expected.txt: Removed.
  • platform/efl/fast/block/positioning/006-expected.txt: Removed.
  • platform/efl/fast/block/positioning/007-expected.txt: Removed.
  • platform/efl/fast/block/positioning/008-expected.txt: Removed.
  • platform/efl/fast/block/positioning/009-expected.txt: Removed.
  • platform/efl/fast/block/positioning/010-expected.txt: Removed.
  • platform/efl/fast/block/positioning/011-expected.txt: Removed.
  • platform/efl/fast/block/positioning/012-expected.txt: Removed.
  • platform/efl/fast/block/positioning/013-expected.txt: Removed.
  • platform/efl/fast/block/positioning/014-expected.txt: Removed.
  • platform/efl/fast/block/positioning/015-expected.txt: Removed.
  • platform/efl/fast/block/positioning/017-expected.txt: Removed.
  • platform/efl/fast/block/positioning/018-expected.txt: Removed.
  • platform/efl/fast/block/positioning/019-expected.txt: Removed.
  • platform/efl/fast/block/positioning/020-expected.txt: Removed.
  • platform/efl/fast/block/positioning/021-expected.txt: Removed.
  • platform/efl/fast/block/positioning/022-expected.txt: Removed.
  • platform/efl/fast/block/positioning/023-expected.txt: Removed.
  • platform/efl/fast/block/positioning/024-expected.txt: Removed.
  • platform/efl/fast/block/positioning/026-expected.txt: Removed.
  • platform/efl/fast/block/positioning/027-expected.txt: Removed.
  • platform/efl/fast/block/positioning/029-expected.txt: Removed.
  • platform/efl/fast/block/positioning/030-expected.txt: Removed.
  • platform/efl/fast/block/positioning/032-expected.txt: Removed.
  • platform/efl/fast/block/positioning/033-expected.txt: Removed.
  • platform/efl/fast/block/positioning/034-expected.txt: Removed.
  • platform/efl/fast/block/positioning/035-expected.txt: Removed.
  • platform/efl/fast/block/positioning/036-expected.txt: Removed.
  • platform/efl/fast/block/positioning/037-expected.txt: Removed.
  • platform/efl/fast/block/positioning/038-expected.txt: Removed.
  • platform/efl/fast/block/positioning/039-expected.txt: Removed.
  • platform/efl/fast/block/positioning/040-expected.txt: Removed.
  • platform/efl/fast/block/positioning/041-expected.txt: Removed.
  • platform/efl/fast/block/positioning/042-expected.txt: Removed.
  • platform/efl/fast/block/positioning/043-expected.txt: Removed.
  • platform/efl/fast/block/positioning/044-expected.txt: Removed.
  • platform/efl/fast/block/positioning/045-expected.txt: Removed.
  • platform/efl/fast/block/positioning/046-expected.txt: Removed.
  • platform/efl/fast/block/positioning/048-expected.txt: Removed.
  • platform/efl/fast/block/positioning/049-expected.txt: Removed.
  • platform/efl/fast/block/positioning/050-expected.txt: Removed.
  • platform/efl/fast/block/positioning/062-expected.txt: Removed.
  • platform/efl/fast/block/positioning/complex-positioned-movement-expected.txt: Removed.
  • platform/efl/fast/block/positioning/move-with-auto-width-expected.txt: Removed.
  • platform/efl/fast/block/positioning/negative-rel-position-expected.txt: Removed.
  • platform/efl/fast/block/positioning/relative-overconstrained-expected.txt: Removed.
  • platform/efl/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/efl/fast/block/positioning/static-inline-position-dynamic-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-lr/003-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-lr/004-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-lr/005-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-lr/006-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-rl/003-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-rl/004-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-rl/005-expected.txt: Removed.
  • platform/efl/fast/block/positioning/vertical-rl/006-expected.txt: Removed.
  • platform/efl/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
  • platform/efl/fast/borders/outline-offset-min-assert-expected.txt: Removed.
  • platform/efl/fast/borders/webkit-border-radius-expected.txt: Removed.
  • platform/efl/fast/box-shadow/shadow-tiling-artifact-expected.txt: Removed.
  • platform/efl/fast/box-shadow/single-pixel-shadow-expected.txt: Removed.
  • platform/efl/fast/canvas/canvas-as-image-expected.txt: Removed.
  • platform/efl/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/efl/fast/canvas/canvas-render-layer-expected.txt: Removed.
  • platform/efl/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
  • platform/efl/fast/css/006-expected.txt: Removed.
  • platform/efl/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
  • platform/efl/fast/css/bogus-color-span-expected.txt: Removed.
  • platform/efl/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
  • platform/efl/fast/css/content-dynamic-expected.txt: Removed.
  • platform/efl/fast/css/contentDiv-expected.txt: Removed.
  • platform/efl/fast/css/contentDivWithChildren-expected.txt: Removed.
  • platform/efl/fast/css/contentImage-expected.txt: Removed.
  • platform/efl/fast/css/empty-inline-003-quirksmode-expected.txt: Removed.
  • platform/efl/fast/css/empty-inline-line-height-first-line-expected.txt: Removed.
  • platform/efl/fast/css/empty-inline-line-height-first-line-quirksmode-expected.txt: Removed.
  • platform/efl/fast/css/font-face-multiple-remote-sources-expected.txt: Removed.
  • platform/efl/fast/css/font-face-remote-expected.txt: Removed.
  • platform/efl/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
  • platform/efl/fast/css/last-child-style-sharing-expected.txt: Removed.
  • platform/efl/fast/css/nested-rounded-corners-expected.txt: Removed.
  • platform/efl/fast/css/outline-auto-empty-rects-expected.txt: Removed.
  • platform/efl/fast/css/transition-color-unspecified-expected.txt: Removed.
  • platform/efl/fast/dom/Element/getBoundingClientRect-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Removed.
  • platform/efl/fast/dom/Range/getBoundingClientRect-expected.txt: Removed.
  • platform/efl/fast/dom/Window/window-properties-performance-expected.txt: Removed.
  • platform/efl/fast/dom/attr_dead_doc-expected.txt: Removed.
  • platform/efl/fast/dom/css-cached-import-rule-expected.txt: Removed.
  • platform/efl/fast/dom/css-insert-import-rule-expected.txt: Removed.
  • platform/efl/fast/dom/delete-contents-expected.txt: Removed.
  • platform/efl/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
  • platform/efl/fast/dom/shadow/shadow-contents-event-expected.txt: Removed.
  • platform/efl/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
  • platform/efl/fast/dynamic/001-expected.txt: Removed.
  • platform/efl/fast/dynamic/005-expected.txt: Removed.
  • platform/efl/fast/dynamic/anonymous-block-layer-lost-expected.txt: Removed.
  • platform/efl/fast/dynamic/float-no-longer-overhanging-expected.txt: Removed.
  • platform/efl/fast/dynamic/float-withdrawal-2-expected.txt: Removed.
  • platform/efl/fast/dynamic/floating-to-positioned-2-expected.txt: Removed.
  • platform/efl/fast/dynamic/floating-to-positioned-expected.txt: Removed.
  • platform/efl/fast/dynamic/insertAdjacentElement-expected.txt: Removed.
  • platform/efl/fast/dynamic/staticY-expected.txt: Removed.
  • platform/efl/fast/dynamic/subtree-parent-static-y-expected.txt: Removed.
  • platform/efl/fast/events/document-elementFromPoint-expected.txt: Removed.
  • platform/efl/fast/events/overflow-viewport-renderer-deleted-expected.txt: Removed.
  • platform/efl/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/efl/fast/flexbox/overhanging-floats-removed-expected.txt: Removed.
  • platform/efl/fast/forms/002-expected.txt: Removed.
  • platform/efl/fast/forms/005-expected.txt: Removed.
  • platform/efl/fast/forms/color/input-color-onchange-event-expected.txt: Removed.
  • platform/efl/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
  • platform/efl/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
  • platform/efl/fast/frames/002-expected.txt: Removed.
  • platform/efl/fast/frames/calculate-fixed-expected.txt: Removed.
  • platform/efl/fast/frames/calculate-order-expected.txt: Removed.
  • platform/efl/fast/frames/calculate-percentage-expected.txt: Removed.
  • platform/efl/fast/frames/calculate-relative-expected.txt: Removed.
  • platform/efl/fast/frames/calculate-round-expected.txt: Removed.
  • platform/efl/fast/frames/content-opacity-1-expected.txt: Removed.
  • platform/efl/fast/frames/content-opacity-2-expected.txt: Removed.
  • platform/efl/fast/frames/empty-cols-attribute-expected.txt: Removed.
  • platform/efl/fast/frames/empty-frame-src-expected.txt: Removed.
  • platform/efl/fast/frames/frame-set-whitespace-attributes-expected.txt: Removed.
  • platform/efl/fast/frames/iframe-scaling-with-scroll-expected.txt: Removed.
  • platform/efl/fast/frames/iframe-text-contents-expected.txt: Removed.
  • platform/efl/fast/frames/invalid-expected.txt: Removed.
  • platform/efl/fast/frames/no-frame-borders-expected.txt: Removed.
  • platform/efl/fast/frames/seamless/seamless-inherited-origin-expected.txt: Removed.
  • platform/efl/fast/gradients/background-clipped-expected.txt: Removed.
  • platform/efl/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/efl/fast/images/gray-scale-png-with-color-profile-expected.txt: Removed.
  • platform/efl/fast/images/png-suite/test-expected.txt: Removed.
  • platform/efl/fast/images/repaint-subrect-grid-expected.txt: Removed.
  • platform/efl/fast/images/zoomed-img-size-expected.txt: Removed.
  • platform/efl/fast/inline-block/004-expected.txt: Removed.
  • platform/efl/fast/inline-block/005-expected.txt: Removed.
  • platform/efl/fast/invalid/015-expected.txt: Removed.
  • platform/efl/fast/invalid/table-residual-style-crash-expected.txt: Removed.
  • platform/efl/fast/layers/opacity-stacking-expected.txt: Removed.
  • platform/efl/fast/layers/positioned-inside-root-with-margins-expected.txt: Removed.
  • platform/efl/fast/layers/zindex-ridonkulous-expected.txt: Removed.
  • platform/efl/fast/lists/list-marker-before-content-table-expected.txt: Removed.
  • platform/efl/fast/multicol/break-properties-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
  • platform/efl/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/multicol/span/generated-child-split-flow-crash-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
  • platform/efl/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Removed.
  • platform/efl/fast/overflow/overflow-update-transform-expected.txt: Removed.
  • platform/efl/fast/overflow/position-relative-expected.txt: Removed.
  • platform/efl/fast/overflow/trailing-float-linebox-expected.txt: Removed.
  • platform/efl/fast/overflow/unreachable-content-test-expected.txt: Removed.
  • platform/efl/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
  • platform/efl/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/efl/fast/profiler/apply-expected.txt: Removed.
  • platform/efl/fast/reflections/reflection-with-zoom-expected.txt: Removed.
  • platform/efl/fast/reflections/table-cell-expected.txt: Removed.
  • platform/efl/fast/repaint/background-generated-expected.txt: Removed.
  • platform/efl/fast/repaint/content-into-overflow-expected.txt: Removed.
  • platform/efl/fast/repaint/erase-overflow-expected.txt: Removed.
  • platform/efl/fast/repaint/fixed-tranformed-expected.txt: Removed.
  • platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Removed.
  • platform/efl/fast/repaint/float-new-in-block-expected.txt: Removed.
  • platform/efl/fast/repaint/focus-ring-expected.txt: Removed.
  • platform/efl/fast/repaint/iframe-scroll-repaint-expected.txt: Removed.
  • platform/efl/fast/repaint/inline-block-resize-expected.txt: Removed.
  • platform/efl/fast/repaint/intermediate-layout-position-clip-expected.txt: Removed.
  • platform/efl/fast/repaint/intermediate-layout-position-expected.txt: Removed.
  • platform/efl/fast/repaint/invisible-objects-expected.txt: Removed.
  • platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
  • platform/efl/fast/repaint/layer-visibility-expected.txt: Removed.
  • platform/efl/fast/repaint/layout-state-only-positioned-expected.txt: Removed.
  • platform/efl/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Removed.
  • platform/efl/fast/repaint/overflow-into-content-expected.txt: Removed.
  • platform/efl/fast/repaint/repaint-during-scroll-expected.txt: Removed.
  • platform/efl/fast/repaint/table-col-background-expected.txt: Removed.
  • platform/efl/fast/repaint/table-outer-border-expected.txt: Removed.
  • platform/efl/fast/repaint/table-row-expected.txt: Removed.
  • platform/efl/fast/repaint/table-section-overflow-expected.txt: Removed.
  • platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Removed.
  • platform/efl/fast/repaint/text-emphasis-v-expected.txt: Removed.
  • platform/efl/fast/repaint/transform-disable-layoutstate-expected.txt: Removed.
  • platform/efl/fast/repaint/transform-replaced-shadows-expected.txt: Removed.
  • platform/efl/fast/repaint/transform-rotate-and-remove-expected.txt: Removed.
  • platform/efl/fast/repaint/view-background-from-body-1-expected.txt: Removed.
  • platform/efl/fast/repaint/view-background-from-body-2-expected.txt: Removed.
  • platform/efl/fast/replaced/008-expected.txt: Removed.
  • platform/efl/fast/replaced/percent-height-in-anonymous-block-expected.txt: Removed.
  • platform/efl/fast/replaced/selection-rect-expected.txt: Removed.
  • platform/efl/fast/ruby/position-after-expected.txt: Removed.
  • platform/efl/fast/ruby/ruby-block-style-not-updated-expected.txt: Removed.
  • platform/efl/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Removed.
  • platform/efl/fast/ruby/ruby-inline-style-not-updated-expected.txt: Removed.
  • platform/efl/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Removed.
  • platform/efl/fast/runin/runin-generated-before-content-expected.txt: Removed.
  • platform/efl/fast/sub-pixel/inline-block-with-padding-expected.txt: Removed.
  • platform/efl/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Removed.
  • platform/efl/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Removed.
  • platform/efl/fast/table/024-expected.txt: Removed.
  • platform/efl/fast/table/031-expected.txt: Removed.
  • platform/efl/fast/table/032-expected.txt: Removed.
  • platform/efl/fast/table/auto-100-percent-width-expected.txt: Removed.
  • platform/efl/fast/table/caption-relayout-expected.txt: Removed.
  • platform/efl/fast/table/div-as-col-span-expected.txt: Removed.
  • platform/efl/fast/table/fixed-granular-cols-expected.txt: Removed.
  • platform/efl/fast/table/fixed-with-auto-with-colspan-expected.txt: Removed.
  • platform/efl/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
  • platform/efl/fast/table/growCellForImageQuirk-expected.txt: Removed.
  • platform/efl/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
  • platform/efl/fast/table/height-percent-test-vertical-expected.txt: Removed.
  • platform/efl/fast/table/percent-widths-stretch-expected.txt: Removed.
  • platform/efl/fast/table/percent-widths-stretch-vertical-expected.txt: Removed.
  • platform/efl/fast/table/table-before-child-style-update-expected.txt: Removed.
  • platform/efl/fast/table/table-cell-before-after-content-around-table-block-expected.txt: Removed.
  • platform/efl/fast/table/table-cell-before-after-content-around-table-expected.txt: Removed.
  • platform/efl/fast/table/table-cell-before-after-content-around-table-row-expected.txt: Removed.
  • platform/efl/fast/table/table-row-before-after-content-around-block-expected.txt: Removed.
  • platform/efl/fast/table/table-row-before-after-content-around-table-expected.txt: Removed.
  • platform/efl/fast/table/table-row-before-child-style-update-expected.txt: Removed.
  • platform/efl/fast/table/table-row-outline-paint-expected.txt: Removed.
  • platform/efl/fast/table/table-row-style-not-updated-expected.txt: Removed.
  • platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Removed.
  • platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Removed.
  • platform/efl/fast/table/table-style-not-updated-expected.txt: Removed.
  • platform/efl/fast/table/vertical-align-baseline-readjust-expected.txt: Removed.
  • platform/efl/fast/table/wide-colspan-expected.txt: Removed.
  • platform/efl/fast/table/wide-column-expected.txt: Removed.
  • platform/efl/fast/text/align-center-rtl-spill-expected.txt: Removed.
  • platform/efl/fast/text/emphasis-avoid-ruby-expected.txt: Removed.
  • platform/efl/fast/text/soft-hyphen-4-expected.txt: Removed.
  • platform/efl/fast/text/stripNullFromText-expected.txt: Removed.
  • platform/efl/fast/text/wbr-pre-expected.txt: Removed.
  • platform/efl/fast/text/whitespace/019-expected.txt: Removed.
  • platform/efl/fast/text/whitespace/023-expected.txt: Removed.
  • platform/efl/fast/tokenizer/missing-style-end-tag-1-expected.txt: Removed.
  • platform/efl/fast/tokenizer/missing-style-end-tag-2-expected.txt: Removed.
  • platform/efl/fast/tokenizer/script-after-frameset-expected.txt: Removed.
  • platform/efl/fast/transforms/matrix-01-expected.txt: Removed.
  • platform/efl/fast/transforms/matrix-02-expected.txt: Removed.
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
  • platform/efl/fast/writing-mode/body-direction-propagation-blocked-expected.txt: Removed.
  • platform/efl/fast/writing-mode/body-direction-propagation-expected.txt: Removed.
  • platform/efl/fast/writing-mode/body-writing-mode-propagation-blocked-expected.txt: Removed.
  • platform/efl/fast/writing-mode/body-writing-mode-propagation-expected.txt: Removed.
  • platform/efl/fast/writing-mode/floats-in-block-layout-expected.txt: Removed.
  • platform/efl/fast/writing-mode/inline-direction-positioning-expected.txt: Removed.
  • platform/efl/fast/writing-mode/margin-collapse-expected.txt: Removed.
  • platform/efl/fast/writing-mode/root-lr-basic-expected.txt: Removed.
  • platform/efl/fast/writing-mode/self-collapsing-block-expected.txt: Removed.
  • platform/efl/fullscreen/full-screen-render-inline-expected.txt: Removed.
  • platform/efl/fullscreen/parent-flow-inline-with-block-child-expected.txt: Removed.
  • platform/efl/plugins/iframe-plugin-bgcolor-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug157890-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug222336-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug222467-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug269566-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug277062-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug28933-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug2954-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • platform/efl/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
  • platform/efl/transforms/3d/general/matrix-with-zoom-3d-expected.txt: Removed.
  • platform/efl/transforms/3d/general/transform-origin-z-change-expected.txt: Removed.
  • platform/efl/transitions/transition-end-event-rendering-expected.txt: Removed.
1:48 AM Changeset in webkit [157502] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] Minibrowser can't load child window's location
​https://bugs.webkit.org/show_bug.cgi?id=122485

Patch by Robert Plociennik <​r.plociennik@samsung.com> on 2013-10-16
Reviewed by Gyuyoung Kim.

Source/WebKit2:

EwkView::createNewPage(), which is only called during handling of
Messages::WebPageProxy::CreateNewPage message from WebProcess, no longer passes
the URL to window_create(). As a result, no Messages::WebPage::LoadURL message
is sent back, that would load the same URL twice and effectively cancel any
other scheduled navigation inside WebProcess.

Additionally, since the url parameter in MiniBrowser's implementation of
window_create() is only used internally and is prone to bugs as demonstrated
in r139303 (d7f10c8), it has been removed in favour of explicit calls to
ewk_view_url_set().

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::createNewPage): No longer passes the URL to window_create() impl.

  • UIProcess/API/efl/ewk_view.h: window_create() no longer has the url parameter.
  • UIProcess/API/efl/tests/test_ewk2_window_features.cpp: Test methods updated to

comply with the API change.

(EWK2WindowFeaturesTest::createDefaultWindow): Ditto.
(EWK2WindowFeaturesTest::createWindow): Ditto.

Tools:

  • MiniBrowser/efl/main.c: Now calling window_create() without the url parameter

followed by an explicit call to ewk_view_url_set() where appropriate.

(on_key_down):
(on_window_create):
(window_create):
(elm_main):

1:42 AM Changeset in webkit [157501] by akling@apple.com
  • 1 edit
    299 deletes in trunk/LayoutTests

Remove Gtk-specific test expectations that were identical to generic expectations.
<​https://webkit.org/b/121551>

Reviewed by Antti Koivisto.

  • platform/gtk/css1/units/rounding-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-circle-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-circle-filter-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-circle-overflow-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-ellipse-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-polygon-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
  • platform/gtk/css3/masking/clip-path-rectangle-expected.txt: Removed.
  • platform/gtk/editing/deleting/transpose-empty-expected.txt: Removed.
  • platform/gtk/editing/pasteboard/5761530-1-expected.txt: Removed.
  • platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
  • platform/gtk/editing/selection/doubleclick-crash-expected.txt: Removed.
  • platform/gtk/editing/selection/select-missing-image-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/bgCompositeCopy-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize01-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize02-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize03-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize04-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize05-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize06-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize07-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize08-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize09-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize10-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize11-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize12-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize13-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/backgroundSize14-expected.txt: Removed.
  • platform/gtk/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Removed.
  • platform/gtk/fast/block/basic/fieldset-stretch-to-legend-expected.txt: Removed.
  • platform/gtk/fast/block/basic/quirk-percent-height-grandchild-expected.txt: Removed.
  • platform/gtk/fast/block/float/008-expected.txt: Removed.
  • platform/gtk/fast/block/float/009-expected.txt: Removed.
  • platform/gtk/fast/block/float/019-expected.txt: Removed.
  • platform/gtk/fast/block/float/034-expected.txt: Removed.
  • platform/gtk/fast/block/float/035-expected.txt: Removed.
  • platform/gtk/fast/block/float/4145535Crash-expected.txt: Removed.
  • platform/gtk/fast/block/float/br-with-clear-2-expected.txt: Removed.
  • platform/gtk/fast/block/float/float-forced-below-other-floats-expected.txt: Removed.
  • platform/gtk/fast/block/float/float-on-zero-height-line-expected.txt: Removed.
  • platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Removed.
  • platform/gtk/fast/block/float/narrow-after-wide-expected.txt: Removed.
  • platform/gtk/fast/block/float/negative-margin-clear-expected.txt: Removed.
  • platform/gtk/fast/block/float/nowrap-clear-min-width-expected.txt: Removed.
  • platform/gtk/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Removed.
  • platform/gtk/fast/block/float/relative-painted-twice-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/003-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/004-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/005-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/006-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/007-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/008-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/009-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/010-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/011-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/012-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/013-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/014-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/015-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/017-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/018-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/019-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/020-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/021-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/022-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/023-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/024-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/026-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/027-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/029-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/030-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/032-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/033-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/034-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/035-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/036-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/037-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/038-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/039-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/040-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/041-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/042-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/043-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/044-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/045-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/046-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/048-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/049-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/050-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/062-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/complex-positioned-movement-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/move-with-auto-width-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/negative-rel-position-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/relative-overconstrained-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/static-inline-position-dynamic-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-lr/003-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-lr/004-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-lr/005-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-lr/006-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-rl/003-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-rl/004-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-rl/005-expected.txt: Removed.
  • platform/gtk/fast/block/positioning/vertical-rl/006-expected.txt: Removed.
  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt: Removed.
  • platform/gtk/fast/borders/outline-offset-min-assert-expected.txt: Removed.
  • platform/gtk/fast/borders/webkit-border-radius-expected.txt: Removed.
  • platform/gtk/fast/box-shadow/shadow-tiling-artifact-expected.txt: Removed.
  • platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-as-image-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-bg-expected.txt: Removed.
  • platform/gtk/fast/canvas/canvas-render-layer-expected.txt: Removed.
  • platform/gtk/fast/css-generated-content/table-parts-before-and-after-expected.txt: Removed.
  • platform/gtk/fast/css/006-expected.txt: Removed.
  • platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
  • platform/gtk/fast/css/bogus-color-span-expected.txt: Removed.
  • platform/gtk/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Removed.
  • platform/gtk/fast/css/content-dynamic-expected.txt: Removed.
  • platform/gtk/fast/css/contentDiv-expected.txt: Removed.
  • platform/gtk/fast/css/contentDivWithChildren-expected.txt: Removed.
  • platform/gtk/fast/css/contentImage-expected.txt: Removed.
  • platform/gtk/fast/css/font-face-multiple-remote-sources-expected.txt: Removed.
  • platform/gtk/fast/css/font-face-remote-expected.txt: Removed.
  • platform/gtk/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt: Removed.
  • platform/gtk/fast/css/last-child-style-sharing-expected.txt: Removed.
  • platform/gtk/fast/css/nested-rounded-corners-expected.txt: Removed.
  • platform/gtk/fast/css/outline-auto-empty-rects-expected.txt: Removed.
  • platform/gtk/fast/css/transition-color-unspecified-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Removed.
  • platform/gtk/fast/dom/attr_dead_doc-expected.txt: Removed.
  • platform/gtk/fast/dom/css-cached-import-rule-expected.txt: Removed.
  • platform/gtk/fast/dom/css-insert-import-rule-expected.txt: Removed.
  • platform/gtk/fast/dom/delete-contents-expected.txt: Removed.
  • platform/gtk/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
  • platform/gtk/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
  • platform/gtk/fast/dynamic/001-expected.txt: Removed.
  • platform/gtk/fast/dynamic/005-expected.txt: Removed.
  • platform/gtk/fast/dynamic/anonymous-block-layer-lost-expected.txt: Removed.
  • platform/gtk/fast/dynamic/float-no-longer-overhanging-expected.txt: Removed.
  • platform/gtk/fast/dynamic/float-withdrawal-2-expected.txt: Removed.
  • platform/gtk/fast/dynamic/floating-to-positioned-2-expected.txt: Removed.
  • platform/gtk/fast/dynamic/floating-to-positioned-expected.txt: Removed.
  • platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt: Removed.
  • platform/gtk/fast/dynamic/staticY-expected.txt: Removed.
  • platform/gtk/fast/dynamic/subtree-parent-static-y-expected.txt: Removed.
  • platform/gtk/fast/events/document-elementFromPoint-expected.txt: Removed.
  • platform/gtk/fast/events/event-attribute-expected.txt: Removed.
  • platform/gtk/fast/files/workers/worker-read-blob-async-expected.txt: Removed.
  • platform/gtk/fast/files/workers/worker-read-blob-sync-expected.txt: Removed.
  • platform/gtk/fast/flexbox/flex-hang-expected.txt: Removed.
  • platform/gtk/fast/forms/002-expected.txt: Removed.
  • platform/gtk/fast/forms/005-expected.txt: Removed.
  • platform/gtk/fast/forms/input-placeholder-paint-order-expected.txt: Removed.
  • platform/gtk/fast/forms/textarea/textarea-placeholder-paint-order-expected.txt: Removed.
  • platform/gtk/fast/frames/002-expected.txt: Removed.
  • platform/gtk/fast/frames/calculate-fixed-expected.txt: Removed.
  • platform/gtk/fast/frames/calculate-order-expected.txt: Removed.
  • platform/gtk/fast/frames/calculate-percentage-expected.txt: Removed.
  • platform/gtk/fast/frames/calculate-relative-expected.txt: Removed.
  • platform/gtk/fast/frames/calculate-round-expected.txt: Removed.
  • platform/gtk/fast/frames/content-opacity-1-expected.txt: Removed.
  • platform/gtk/fast/frames/content-opacity-2-expected.txt: Removed.
  • platform/gtk/fast/frames/empty-cols-attribute-expected.txt: Removed.
  • platform/gtk/fast/frames/empty-frame-src-expected.txt: Removed.
  • platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.txt: Removed.
  • platform/gtk/fast/frames/iframe-scaling-with-scroll-expected.txt: Removed.
  • platform/gtk/fast/frames/iframe-text-contents-expected.txt: Removed.
  • platform/gtk/fast/frames/invalid-expected.txt: Removed.
  • platform/gtk/fast/frames/no-frame-borders-expected.txt: Removed.
  • platform/gtk/fast/gradients/background-clipped-expected.txt: Removed.
  • platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Removed.
  • platform/gtk/fast/images/gray-scale-png-with-color-profile-expected.txt: Removed.
  • platform/gtk/fast/images/png-suite/test-expected.txt: Removed.
  • platform/gtk/fast/images/zoomed-img-size-expected.txt: Removed.
  • platform/gtk/fast/inline-block/004-expected.txt: Removed.
  • platform/gtk/fast/inline-block/005-expected.txt: Removed.
  • platform/gtk/fast/invalid/015-expected.txt: Removed.
  • platform/gtk/fast/invalid/table-residual-style-crash-expected.txt: Removed.
  • platform/gtk/fast/layers/opacity-stacking-expected.txt: Removed.
  • platform/gtk/fast/layers/positioned-inside-root-with-margins-expected.txt: Removed.
  • platform/gtk/fast/layers/zindex-ridonkulous-expected.txt: Removed.
  • platform/gtk/fast/multicol/break-properties-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-h-horizontal-bt-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-h-horizontal-tb-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-h-vertical-lr-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-h-vertical-rl-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-v-horizontal-bt-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-v-horizontal-tb-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-v-vertical-lr-expected.txt: Removed.
  • platform/gtk/fast/multicol/pagination-v-vertical-rl-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-lr/break-properties-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-rl/break-properties-expected.txt: Removed.
  • platform/gtk/fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Removed.
  • platform/gtk/fast/overflow/overflow-update-transform-expected.txt: Removed.
  • platform/gtk/fast/overflow/position-relative-expected.txt: Removed.
  • platform/gtk/fast/overflow/trailing-float-linebox-expected.txt: Removed.
  • platform/gtk/fast/overflow/unreachable-content-test-expected.txt: Removed.
  • platform/gtk/fast/parser/innerhtml-with-prefixed-elements-expected.txt: Removed.
  • platform/gtk/fast/parser/style-script-head-test-expected.txt: Removed.
  • platform/gtk/fast/reflections/reflection-with-zoom-expected.txt: Removed.
  • platform/gtk/fast/reflections/table-cell-expected.txt: Removed.
  • platform/gtk/fast/repaint/background-generated-expected.txt: Removed.
  • platform/gtk/fast/repaint/content-into-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/erase-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/fixed-tranformed-expected.txt: Removed.
  • platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.txt: Removed.
  • platform/gtk/fast/repaint/float-new-in-block-expected.txt: Removed.
  • platform/gtk/fast/repaint/focus-ring-expected.txt: Removed.
  • platform/gtk/fast/repaint/inline-block-resize-expected.txt: Removed.
  • platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.txt: Removed.
  • platform/gtk/fast/repaint/intermediate-layout-position-expected.txt: Removed.
  • platform/gtk/fast/repaint/invisible-objects-expected.txt: Removed.
  • platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.txt: Removed.
  • platform/gtk/fast/repaint/layer-visibility-expected.txt: Removed.
  • platform/gtk/fast/repaint/layout-state-only-positioned-expected.txt: Removed.
  • platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Removed.
  • platform/gtk/fast/repaint/overflow-into-content-expected.txt: Removed.
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-col-background-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-outer-border-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-row-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-section-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-two-pass-layout-overpaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/transform-disable-layoutstate-expected.txt: Removed.
  • platform/gtk/fast/repaint/transform-replaced-shadows-expected.txt: Removed.
  • platform/gtk/fast/repaint/transform-rotate-and-remove-expected.txt: Removed.
  • platform/gtk/fast/repaint/view-background-from-body-1-expected.txt: Removed.
  • platform/gtk/fast/repaint/view-background-from-body-2-expected.txt: Removed.
  • platform/gtk/fast/replaced/008-expected.txt: Removed.
  • platform/gtk/fast/replaced/percent-height-in-anonymous-block-expected.txt: Removed.
  • platform/gtk/fast/replaced/selection-rect-expected.txt: Removed.
  • platform/gtk/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.txt: Removed.
  • platform/gtk/fast/table/024-expected.txt: Removed.
  • platform/gtk/fast/table/031-expected.txt: Removed.
  • platform/gtk/fast/table/032-expected.txt: Removed.
  • platform/gtk/fast/table/auto-100-percent-width-expected.txt: Removed.
  • platform/gtk/fast/table/caption-relayout-expected.txt: Removed.
  • platform/gtk/fast/table/div-as-col-span-expected.txt: Removed.
  • platform/gtk/fast/table/fixed-granular-cols-expected.txt: Removed.
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-expected.txt: Removed.
  • platform/gtk/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Removed.
  • platform/gtk/fast/table/growCellForImageQuirk-expected.txt: Removed.
  • platform/gtk/fast/table/growCellForImageQuirk-vertical-expected.txt: Removed.
  • platform/gtk/fast/table/height-percent-test-vertical-expected.txt: Removed.
  • platform/gtk/fast/table/percent-widths-stretch-expected.txt: Removed.
  • platform/gtk/fast/table/percent-widths-stretch-vertical-expected.txt: Removed.
  • platform/gtk/fast/table/table-row-outline-paint-expected.txt: Removed.
  • platform/gtk/fast/table/vertical-align-baseline-readjust-expected.txt: Removed.
  • platform/gtk/fast/table/wide-colspan-expected.txt: Removed.
  • platform/gtk/fast/table/wide-column-expected.txt: Removed.
  • platform/gtk/fast/text/align-center-rtl-spill-expected.txt: Removed.
  • platform/gtk/fast/text/stripNullFromText-expected.txt: Removed.
  • platform/gtk/fast/text/wbr-pre-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/019-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/022-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/023-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/missing-style-end-tag-1-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/missing-style-end-tag-2-expected.txt: Removed.
  • platform/gtk/fast/tokenizer/script-after-frameset-expected.txt: Removed.
  • platform/gtk/fast/transforms/matrix-01-expected.txt: Removed.
  • platform/gtk/fast/transforms/matrix-02-expected.txt: Removed.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Removed.
  • platform/gtk/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/body-direction-propagation-blocked-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/body-direction-propagation-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/body-writing-mode-propagation-blocked-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/body-writing-mode-propagation-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/floats-in-block-layout-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/inline-direction-positioning-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/margin-collapse-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/root-lr-basic-expected.txt: Removed.
  • platform/gtk/fast/writing-mode/self-collapsing-block-expected.txt: Removed.
  • platform/gtk/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
  • platform/gtk/js/dom/global-constructors-attributes-shared-worker-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug157890-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug222336-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug222467-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug269566-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug277062-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug28933-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug2954-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.txt: Removed.
  • platform/gtk/transitions/transition-end-event-rendering-expected.txt: Removed.
1:40 AM Changeset in webkit [157500] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Remove more of the UNINTERRUPTED_SEQUENCE thing
​https://bugs.webkit.org/show_bug.cgi?id=122885

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-16
Reviewed by Andreas Kling.

It was not completely removed by r157481, leading to build failure for sh4 architecture.

  • jit/JIT.h:
  • jit/JITInlines.h:
1:35 AM Changeset in webkit [157499] by akling@apple.com
  • 1 edit
    338 deletes in trunk/LayoutTests

Remove port-specific SVG test expectations that were identical to generic expectations.
<​https://webkit.org/b/121551>

Reviewed by Antti Koivisto.

  • platform/efl/fast/repaint/repaint-svg-after-style-change-expected.txt: Removed.
  • platform/efl/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Removed.
  • platform/efl/svg/as-image/image-respects-pageScaleFactor-change-expected.txt: Removed.
  • platform/efl/svg/as-image/svg-as-image-expected.txt: Removed.
  • platform/efl/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
  • platform/efl/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-in-clip-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-nonzero-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-transform-1-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-with-container-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
  • platform/efl/svg/clip-path/clipper-placement-issue-expected.txt: Removed.
  • platform/efl/svg/css/path-with-shadow-expected.txt: Removed.
  • platform/efl/svg/css/shadow-and-opacity-expected.txt: Removed.
  • platform/efl/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/efl/svg/dom/css-transforms-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-dom-diffuseConstant-attr-expected.txt: Removed.
  • platform/efl/svg/dynamic-updates/SVGFEDiffuseLightingElement-svgdom-surfaceScale-prop-expected.txt: Removed.
  • platform/efl/svg/filters/big-sized-filter-2-expected.txt: Removed.
  • platform/efl/svg/filters/big-sized-filter-expected.txt: Removed.
  • platform/efl/svg/filters/feImage-change-target-id-expected.txt: Removed.
  • platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Removed.
  • platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Removed.
  • platform/efl/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
  • platform/efl/svg/filters/feImage-remove-target-expected.txt: Removed.
  • platform/efl/svg/filters/feMerge-wrong-input-expected.txt: Removed.
  • platform/efl/svg/filters/filter-empty-g-expected.txt: Removed.
  • platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Removed.
  • platform/efl/svg/foreignObject/fO-display-none-expected.txt: Removed.
  • platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Removed.
  • platform/efl/svg/foreignObject/fO-parent-display-none-expected.txt: Removed.
  • platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Removed.
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Removed.
  • platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Removed.
  • platform/efl/svg/hixie/cascade/001-broken-expected.txt: Removed.
  • platform/efl/svg/hixie/data-types/001-expected.txt: Removed.
  • platform/efl/svg/hixie/dynamic/003-expected.txt: Removed.
  • platform/efl/svg/hixie/dynamic/004-expected.txt: Removed.
  • platform/efl/svg/hixie/dynamic/005-expected.txt: Removed.
  • platform/efl/svg/hixie/dynamic/006-expected.txt: Removed.
  • platform/efl/svg/hixie/error/001-expected.txt: Removed.
  • platform/efl/svg/hixie/error/006-expected.txt: Removed.
  • platform/efl/svg/hixie/error/007-expected.txt: Removed.
  • platform/efl/svg/hixie/error/008-expected.txt: Removed.
  • platform/efl/svg/hixie/error/009-expected.txt: Removed.
  • platform/efl/svg/hixie/error/014-expected.txt: Removed.
  • platform/efl/svg/hixie/error/014-test-expected.txt: Removed.
  • platform/efl/svg/hixie/error/015-expected.txt: Removed.
  • platform/efl/svg/hixie/error/016-expected.txt: Removed.
  • platform/efl/svg/hixie/mixed/004-expected.txt: Removed.
  • platform/efl/svg/hixie/mixed/005-expected.txt: Removed.
  • platform/efl/svg/hixie/painting/001-expected.txt: Removed.
  • platform/efl/svg/hixie/processing-model/005-expected.txt: Removed.
  • platform/efl/svg/hixie/rendering-model/001-expected.txt: Removed.
  • platform/efl/svg/hixie/rendering-model/002-expected.txt: Removed.
  • platform/efl/svg/hixie/rendering-model/003a-expected.txt: Removed.
  • platform/efl/svg/hixie/text/001-expected.txt: Removed.
  • platform/efl/svg/hixie/transform/001-expected.txt: Removed.
  • platform/efl/svg/hixie/use/001-expected.txt: Removed.
  • platform/efl/svg/hixie/use/002-expected.txt: Removed.
  • platform/efl/svg/hixie/use/002-test-expected.txt: Removed.
  • platform/efl/svg/hixie/viewbox/001-expected.txt: Removed.
  • platform/efl/svg/hixie/viewbox/002-expected.txt: Removed.
  • platform/efl/svg/hixie/viewbox/003-expected.txt: Removed.
  • platform/efl/svg/hixie/viewbox/004-expected.txt: Removed.
  • platform/efl/svg/overflow/overflow-on-foreignObject-expected.txt: Removed.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Removed.
  • platform/efl/svg/overflow/overflow-on-inner-svg-element-expected.txt: Removed.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
  • platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
  • platform/efl/svg/repaint/repainting-after-animation-element-removal-expected.txt: Removed.
  • platform/efl/svg/text/text-hkern-expected.txt: Removed.
  • platform/efl/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
  • platform/efl/svg/text/text-vkern-expected.txt: Removed.
  • platform/efl/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
  • platform/efl/svg/text/textPathBoundsBug-expected.txt: Removed.
  • platform/efl/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
  • platform/efl/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-image-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-non-integer-scaled-image-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-clip-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-transform-1-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-container-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.txt: Removed.
  • platform/gtk/svg/css/path-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt: Removed.
  • platform/gtk/svg/custom/SVGNumber-interface-expected.txt: Removed.
  • platform/gtk/svg/custom/SVGPoint-interface-expected.txt: Removed.
  • platform/gtk/svg/custom/SVGRect-interface-expected.txt: Removed.
  • platform/gtk/svg/custom/attribute-namespace-check-expected.txt: Removed.
  • platform/gtk/svg/custom/circular-marker-reference-3-expected.txt: Removed.
  • platform/gtk/svg/custom/class-baseValue-expected.txt: Removed.
  • platform/gtk/svg/custom/class-selector-expected.txt: Removed.
  • platform/gtk/svg/custom/clip-path-with-css-transform-1-expected.txt: Removed.
  • platform/gtk/svg/custom/clip-path-with-css-transform-2-expected.txt: Removed.
  • platform/gtk/svg/custom/clip-path-with-transform-expected.txt: Removed.
  • platform/gtk/svg/custom/conditional-processing-outside-switch-expected.txt: Removed.
  • platform/gtk/svg/custom/convolution-crash-expected.txt: Removed.
  • platform/gtk/svg/custom/create-metadata-element-expected.txt: Removed.
  • platform/gtk/svg/custom/createImageElement-expected.txt: Removed.
  • platform/gtk/svg/custom/createelement-expected.txt: Removed.
  • platform/gtk/svg/custom/css-pixels-dpi-expected.txt: Removed.
  • platform/gtk/svg/custom/dasharrayOrigin-expected.txt: Removed.
  • platform/gtk/svg/custom/display-none-expected.txt: Removed.
  • platform/gtk/svg/custom/dynamic-empty-path-expected.txt: Removed.
  • platform/gtk/svg/custom/dynamic-viewBox-expected.txt: Removed.
  • platform/gtk/svg/custom/empty-merge-expected.txt: Removed.
  • platform/gtk/svg/custom/evt-onload-expected.txt: Removed.
  • platform/gtk/svg/custom/fill-opacity-hsl-expected.txt: Removed.
  • platform/gtk/svg/custom/fill-opacity-rgba-expected.txt: Removed.
  • platform/gtk/svg/custom/fill-update-expected.txt: Removed.
  • platform/gtk/svg/custom/fractional-rects-expected.txt: Removed.
  • platform/gtk/svg/custom/glyph-selection-arabic-forms-expected.txt: Removed.
  • platform/gtk/svg/custom/glyph-selection-non-bmp-expected.txt: Removed.
  • platform/gtk/svg/custom/gradient-attr-update-expected.txt: Removed.
  • platform/gtk/svg/custom/gradient-rotated-bbox-expected.txt: Removed.
  • platform/gtk/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt: Removed.
  • platform/gtk/svg/custom/group-opacity-expected.txt: Removed.
  • platform/gtk/svg/custom/hover-default-fill-expected.txt: Removed.
  • platform/gtk/svg/custom/image-with-aspect-ratio-stretch-expected.txt: Removed.
  • platform/gtk/svg/custom/inner-percent-expected.txt: Removed.
  • platform/gtk/svg/custom/inner-svg-hit-test-expected.txt: Removed.
  • platform/gtk/svg/custom/invalid-dasharray-expected.txt: Removed.
  • platform/gtk/svg/custom/invalid-transforms-expected.txt: Removed.
  • platform/gtk/svg/custom/js-update-container-expected.txt: Removed.
  • platform/gtk/svg/custom/js-update-image-and-display-expected.txt: Removed.
  • platform/gtk/svg/custom/js-update-image-and-display2-expected.txt: Removed.
  • platform/gtk/svg/custom/js-update-image-and-display3-expected.txt: Removed.
  • platform/gtk/svg/custom/large-bounding-box-percents-expected.txt: Removed.
  • platform/gtk/svg/custom/marker-empty-path-expected.txt: Removed.
  • platform/gtk/svg/custom/marker-referencePoint-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-changes-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-colorspace-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-excessive-malloc-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-inside-defs-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-on-multiple-objects-expected.txt: Removed.
  • platform/gtk/svg/custom/mask-with-default-value-expected.txt: Removed.
  • platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Removed.
  • platform/gtk/svg/custom/outer-svg-unknown-feature-expected.txt: Removed.
  • platform/gtk/svg/custom/painting-marker-07-f-inherit-expected.txt: Removed.
  • platform/gtk/svg/custom/path-moveto-only-rendering-expected.txt: Removed.
  • platform/gtk/svg/custom/path-update-expected.txt: Removed.
  • platform/gtk/svg/custom/pattern-no-pixelation-expected.txt: Removed.
  • platform/gtk/svg/custom/pattern-scaling-expected.txt: Removed.
  • platform/gtk/svg/custom/pattern-y-offset-expected.txt: Removed.
  • platform/gtk/svg/custom/percentage-rect2-expected.txt: Removed.
  • platform/gtk/svg/custom/poly-identify-expected.txt: Removed.
  • platform/gtk/svg/custom/polyline-hittest-expected.txt: Removed.
  • platform/gtk/svg/custom/polyline-invalid-points-expected.txt: Removed.
  • platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt: Removed.
  • platform/gtk/svg/custom/root-container-opacity-clip-viewBox-expected.txt: Removed.
  • platform/gtk/svg/custom/rootelement-expected.txt: Removed.
  • platform/gtk/svg/custom/rounded-rects-expected.txt: Removed.
  • platform/gtk/svg/custom/sheet-title-expected.txt: Removed.
  • platform/gtk/svg/custom/small-rect-scale-expected.txt: Removed.
  • platform/gtk/svg/custom/subpaths-moveto-only-rendering-expected.txt: Removed.
  • platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
  • platform/gtk/svg/custom/svgpolyparser-extra-space-expected.txt: Removed.
  • platform/gtk/svg/custom/text-gradient-no-content-expected.txt: Removed.
  • platform/gtk/svg/custom/transform-ignore-after-invalid-expected.txt: Removed.
  • platform/gtk/svg/custom/transform-invalid-expected.txt: Removed.
  • platform/gtk/svg/custom/transform-removeAttributeNS-expected.txt: Removed.
  • platform/gtk/svg/custom/transform-scale-parse-expected.txt: Removed.
  • platform/gtk/svg/custom/transform-with-ending-space-expected.txt: Removed.
  • platform/gtk/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Removed.
  • platform/gtk/svg/custom/use-disappears-after-style-update-expected.txt: Removed.
  • platform/gtk/svg/custom/use-empty-reference-expected.txt: Removed.
  • platform/gtk/svg/custom/use-extern-href-expected.txt: Removed.
  • platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Removed.
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt: Removed.
  • platform/gtk/svg/custom/use-recalcStyle-crash-expected.txt: Removed.
  • platform/gtk/svg/custom/use-symbol-overflow-expected.txt: Removed.
  • platform/gtk/svg/custom/viewBox-hit-expected.txt: Removed.
  • platform/gtk/svg/custom/viewport-clip-expected.txt: Removed.
  • platform/gtk/svg/custom/viewport-no-width-height-expected.txt: Removed.
  • platform/gtk/svg/custom/viewport-update-expected.txt: Removed.
  • platform/gtk/svg/custom/viewport-update2-expected.txt: Removed.
  • platform/gtk/svg/custom/visibility-override-clip-expected.txt: Removed.
  • platform/gtk/svg/custom/visibility-override-expected.txt: Removed.
  • platform/gtk/svg/custom/visibility-override-filter-expected.txt: Removed.
  • platform/gtk/svg/custom/visibility-override-mask-expected.txt: Removed.
  • platform/gtk/svg/custom/width-full-percentage-expected.txt: Removed.
  • platform/gtk/svg/custom/xhtml-no-svg-renderer-expected.txt: Removed.
  • platform/gtk/svg/custom/xml-stylesheet-expected.txt: Removed.
  • platform/gtk/svg/filters/big-sized-filter-2-expected.txt: Removed.
  • platform/gtk/svg/filters/big-sized-filter-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-change-target-id-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-remove-target-expected.txt: Removed.
  • platform/gtk/svg/filters/feMerge-wrong-input-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-empty-g-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.txt: Removed.
  • platform/gtk/svg/hixie/cascade/001-broken-expected.txt: Removed.
  • platform/gtk/svg/hixie/data-types/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/004-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/005-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/006-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/006-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/008-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/009-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/014-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/014-test-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/015-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/016-expected.txt: Removed.
  • platform/gtk/svg/hixie/painting/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/processing-model/005-expected.txt: Removed.
  • platform/gtk/svg/hixie/rendering-model/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/rendering-model/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/rendering-model/003a-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/transform/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/use/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/use/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/use/002-test-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/004-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.txt: Removed.
  • platform/gtk/svg/repaint/repainting-after-animation-element-removal-expected.txt: Removed.
  • platform/gtk/svg/text/text-hkern-expected.txt: Removed.
  • platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
  • platform/gtk/svg/text/text-vkern-expected.txt: Removed.
  • platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
  • platform/gtk/svg/text/textPathBoundsBug-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-background-image-tiled-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-object-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Removed.
1:25 AM Changeset in webkit [157498] by akling@apple.com
  • 1 edit
    13 deletes in trunk/LayoutTests

Remove Mac-specific test expectations that were identical to generic expectations.
<​https://webkit.org/b/121551>

Reviewed by Antti Koivisto.

  • platform/mac-lion/css3/filters/composited-during-animation-layertree-expected.txt: Removed.
  • platform/mac-lion/fast/canvas/canvas-scale-shadowBlur-expected.txt: Removed.
  • platform/mac-lion/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Removed.
  • platform/mac-lion/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Removed.
  • platform/mac-lion/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Removed.
  • platform/mac-lion/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
  • platform/mac-lion/http/tests/multipart/policy-ignore-crash-expected.txt: Removed.
  • platform/mac-lion/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Removed.
  • platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Removed.
  • platform/mac-lion/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Removed.
  • platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
  • platform/mac-wk2/http/tests/security/cross-origin-local-storage-wk1-expected.txt: Removed.
  • platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants-expected.txt: Removed.
  • platform/mac/compositing/overflow/clipping-behaviour-change-is-not-propagated-to-descendants2-expected.txt: Removed.
  • platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt: Removed.
1:13 AM Changeset in webkit [157497] by akling@apple.com
  • 1 edit
    39 deletes in trunk/LayoutTests

Remove Windows-specific test expectations that were identical to generic expectations.
<​https://webkit.org/b/121551>

Reviewed by Antti Koivisto.

  • platform/win-7sp0/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
  • platform/win-future/svg/batik/text/textPosition2-expected.txt: Removed.
  • platform/win/css3/filters/effect-reference-expected.txt: Removed.
  • platform/win/css3/filters/effect-reference-hw-expected.txt: Removed.
  • platform/win/editing/deleting/delete-br-009-expected.txt: Removed.
  • platform/win/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
  • platform/win/editing/inserting/insert-3800346-fix-expected.txt: Removed.
  • platform/win/editing/selection/anchor-focus2-expected.txt: Removed.
  • platform/win/editing/selection/anchor-focus3-expected.txt: Removed.
  • platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Removed.
  • platform/win/editing/selection/drag-text-delay-expected.txt: Removed.
  • platform/win/editing/selection/extend-selection-home-end-expected.txt: Removed.
  • platform/win/fast/block/positioning/016-expected.txt: Removed.
  • platform/win/fast/block/positioning/025-expected.txt: Removed.
  • platform/win/fast/block/positioning/fixed-position-stacking-context-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-render-layer-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Removed.
  • platform/win/fast/css/zoom-body-scroll-expected.txt: Removed.
  • platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Removed.
  • platform/win/fast/dom/icon-url-property-expected.txt: Removed.
  • platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Removed.
  • platform/win/fast/events/event-attribute-expected.txt: Removed.
  • platform/win/fast/events/ondragenter-expected.txt: Removed.
  • platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Removed.
  • platform/win/fast/forms/implicit-submission-expected.txt: Removed.
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt: Removed.
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt: Removed.
  • platform/win/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
  • platform/win/fast/media/w3c/test_media_queries-expected.txt: Removed.
  • platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
  • platform/win/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
  • platform/win/http/tests/misc/acid3-expected.txt: Removed.
  • platform/win/media/media-can-play-ogg-expected.txt: Removed.
  • platform/win/media/media-can-play-wav-audio-expected.txt: Removed.
  • platform/win/media/video-colorspace-yuv420-expected.txt: Removed.
  • platform/win/media/video-colorspace-yuv422-expected.txt: Removed.
  • platform/win/media/video-size-intrinsic-scale-expected.txt: Removed.
  • platform/win/plugins/netscape-dom-access-and-reload-expected.txt: Removed.
  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
  • platform/win/svg/custom/pattern-scaling-expected.txt: Removed.
12:32 AM Changeset in webkit [157496] by mrowe@apple.com
  • 3 edits in trunk/Source/WebCore

Fix the build after r157478.

Rubber-stamped by Tim Horton.

Due to the way WebCore.exp.in is used, it can't be used to export a differing set of symbols
for different architectures. We often work around this by tweaking code slightly to avoid
needing to export different symbols. However, in this case the symbol name itself encodes an
architecture-specific detail and there's no clear way to avoid the requirement to export it.

To deal with this case we turn to ld's support for wildcards in the symbol export list.

  • WebCore.exp.in: Use wildcards in place of the number that represents by how much "this"

should be adjusted when calling through the vtable thunk. Also sort the remainder of the file.

  • make-export-file-generator: Don't attempt to verify symbol names that contain wildcard characters.

Oct 15, 2013:

11:56 PM Changeset in webkit [157495] by jae.park@company100.net
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Build fix after r157476.

  • GNUmakefile.am:
11:46 PM Changeset in webkit [157494] by gyuyoung.kim@samsung.com
  • 3 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r155253.

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-10-15

  • platform/efl/fast/forms/formmove3-expected.txt:
  • platform/efl/fast/forms/input-align-image-expected.txt:
  • platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/efl/fast/invalid/003-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug647-expected.txt:
11:35 PM Changeset in webkit [157493] by jinwoo7.song@samsung.com
  • 6 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r155253.

  • platform/efl/fast/forms/formmove3-expected.txt:
  • platform/efl/fast/forms/input-align-image-expected.txt:
  • platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/efl/fast/invalid/003-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug647-expected.txt:
11:17 PM Changeset in webkit [157492] by jinwoo7.song@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r155324.

  • platform/efl/fast/forms/placeholder-position-expected.png:
  • platform/efl/fast/forms/placeholder-position-expected.txt:
9:44 PM Changeset in webkit [157491] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Two more exports for 32-bit build fix.
The duality of CGFloat means that we use a different
version of getRGBA (and the cast operator)
on 32-bit systems.

  • WebCore.exp.in:
9:36 PM Changeset in webkit [157490] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WK2] Make SeccompFilters build again after r156349 and r156353
​https://bugs.webkit.org/show_bug.cgi?id=122872

Patch by Sergio Correia <Sergio Correia> on 2013-10-15
Reviewed by Anders Carlsson.

Source/WebKit2:

  • Shared/linux/SeccompFilters/SeccompBroker.cpp:

(WebKit::SeccompBrokerClient::dispatch): Fix usage of extinct 'create'
methods of ArgumentEncoder/ArgumentDecoder.
(WebKit::SeccompBroker::runLoop): Ditto.

Tools:

  • TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as

failing.

9:32 PM Changeset in webkit [157489] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Get rid of the StructureStubInfo::patch union
​https://bugs.webkit.org/show_bug.cgi?id=122877

Reviewed by Sam Weinig.

Just simplifying code by getting rid of data structures that ain't used no more.

Note that I replace the patch union with a patch struct. This means we say things like
stubInfo.patch.valueGPR instead of stubInfo.valueGPR. I think that this extra
encapsulation makes the code more readable: the patch struct contains just those things
that you need to know to perform patching.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • jit/Repatch.cpp:

(JSC::repatchByIdSelfAccess):
(JSC::replaceWithJump):
(JSC::linkRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::getPolymorphicStructureList):
(JSC::patchJumpToGetByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::tryRepatchIn):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):

9:30 PM Changeset in webkit [157488] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening.

  • platform/efl/TestExpectations: svg/filters/filter-hidden-content.svg is passed after r142955.
9:27 PM Changeset in webkit [157487] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Another shot at a build fix; apparently these
do need exporting for some reason, but are different
on 32-bit.

  • WebCore.exp.in:
9:21 PM Changeset in webkit [157486] by ap@apple.com
  • 18 edits in trunk/Source/WebCore

GenerateIsReachable=ImplContext is confusing
​https://bugs.webkit.org/show_bug.cgi?id=122864

Reviewed by Geoffrey Garen.

Renamed to ImplWebGLRenderingContext.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • html/canvas/EXTDrawBuffers.idl:
  • html/canvas/EXTTextureFilterAnisotropic.idl:
  • html/canvas/OESElementIndexUint.idl:
  • html/canvas/OESStandardDerivatives.idl:
  • html/canvas/OESTextureFloat.idl:
  • html/canvas/OESTextureHalfFloat.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/WebGLCompressedTextureATC.idl:
  • html/canvas/WebGLCompressedTexturePVRTC.idl:
  • html/canvas/WebGLCompressedTextureS3TC.idl:
  • html/canvas/WebGLDebugRendererInfo.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLDepthTexture.idl:
  • html/canvas/WebGLLoseContext.idl:
  • WebCore.xcodeproj/project.pbxproj: While at it, added OESElementIndexUint.idl

to Xcode project.

9:13 PM Changeset in webkit [157485] by jinwoo7.song@samsung.com
  • 6 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r155408.

  • platform/efl/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/efl/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/efl/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/efl/fast/forms/textarea-placeholder-visibility-1-expected.txt:
  • platform/efl/fast/forms/textarea-placeholder-visibility-2-expected.txt:
9:08 PM Changeset in webkit [157484] by jinwoo7.song@samsung.com
  • 3 edits in trunk/Source/WebKit2

Removed argument coders for FloatPoint3D in CoodinatedGraphicsArgumentCoders.
​https://bugs.webkit.org/show_bug.cgi?id=122875

Reviewed by Gyuyoung Kim.

Argument coders for FloatPoint3D is added in WebCoreArgumentCoders after r157478
and it caused redefinition build error in EFL port.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
9:05 PM Changeset in webkit [157483] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; I don't know how to export.
This may not help.

  • WebCore.exp.in:
8:59 PM Changeset in webkit [157482] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

FTL: add support for Int52ToValue and fix putByVal of int52s.
​https://bugs.webkit.org/show_bug.cgi?id=122873

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-15
Reviewed by Filip Pizlo.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileInt52ToValue):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

8:10 PM Changeset in webkit [157481] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Get rid of the UNINTERRUPTED_SEQUENCE thing
​https://bugs.webkit.org/show_bug.cgi?id=122876

Reviewed by Mark Hahnenberg.

It doesn't make sense anymore. We now use the DFG's IC logic, which never needed that.

Moreover, we should resist the temptation to bring anything like this back. We don't
want to have inline caches that only work if the assembler lays out code in a specific
predetermined way.

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

7:19 PM Changeset in webkit [157480] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Baseline JIT should use the DFG GetById IC
​https://bugs.webkit.org/show_bug.cgi?id=122861

Reviewed by Oliver Hunt.

This mostly just kills a ton of code.

Note that this doesn't yet do all of the simplifications that can be done, but it does
kill dead code. I'll have another change to simplify StructureStubInfo's unions and such.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • jit/JIT.h:

(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):

  • jit/JITInlines.h:

(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::callOperation):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_from_scope):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/Repatch.cpp:

(JSC::repatchGetByID):
(JSC::buildGetByIDList):

  • jit/ThunkGenerators.cpp:
  • jit/ThunkGenerators.h:
5:34 PM Changeset in webkit [157479] by dino@apple.com
  • 12 edits in trunk

Add ENABLE_WEB_ANIMATIONS flag
​https://bugs.webkit.org/show_bug.cgi?id=122871

Reviewed by Tim Horton.

Eventually might be ​http://dev.w3.org/fxtf/web-animations/
but this is just engine-internal work at the moment.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
5:20 PM Changeset in webkit [157478] by timothy_horton@apple.com
  • 23 edits
    4 adds
    2 deletes in trunk/Source

Add a PlatformCALayer subclass that proxies its property changes across the process boundary
​https://bugs.webkit.org/show_bug.cgi?id=122773

Reviewed by Anders Carlsson.

PlatformCALayerRemote coordinates with RemoteLayerTreeDrawingArea and friends
to enable cross-process proxying of the hierarchy of compositing layers.

In the Web process, we have GraphicsLayerCARemote, which owns 1+ PlatformCALayerRemote(s).
Unlike PlatformCALayer{Mac, Win}, which own PlatformLayers (CALayer/CACFLayer),
PlatformCALayerRemote stores any changes to its properties in a struct, and keeps track of
which properties have changed since the last commit. Commits are scheduled and performed by
RemoteLayerTreeContext, on RemoteLayerTreeDrawingArea's behalf, and result in
RemoteLayerTreeTransaction encoding said property changes and throwing them across
to the UI process, where RemoteLayerTreeHost applies them to a tree of CALayers kept there.

This code can be enabled by running with the WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA
environment variable set.

No new tests, the new drawing area is not yet testable.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::decode):
(CoreIPC::encode):

  • Shared/WebCoreArgumentCoders.h:

Add argument coders for FloatPoint3D.

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::notePropertiesChanged):
(WebKit::RemoteLayerTreeTransaction::changedLayers):
(WebKit::RemoteLayerTreeTransaction::destroyedLayers):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::dumpChangedLayers):
Add support for background color and anchor point in the layer transaction.
Make layer position a 3D point because that's what it really is.

(WebKit::RemoteLayerTreeTransaction::layerPropertiesChanged):
The logic in layerPropertiesChanged is moved into PlatformCALayerRemote.

  • UIProcess/WebPageProxy.h:

Include PlatformLayer.h; it seems annoying to successfully forward-declare
PlatformLayer because of the difference in definition between Objective-C and C++.
Drive-by un-indent some namespace contents and use OBJC_CLASS.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::sizeDidChange):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didUpdateGeometry):
(WebKit::RemoteLayerTreeDrawingAreaProxy::sendUpdateGeometry):
Send geometry updates to the RemoteLayerTreeDrawingArea.

  • UIProcess/mac/RemoteLayerTreeHost.h:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(nullActionsDictionary):
(WebKit::RemoteLayerTreeHost::commit):
Apply layer property changes to the named sublayer.

(WebKit::RemoteLayerTreeHost::getOrCreateLayer):
Create CALayers instead of GraphicsLayers.
Ensure that they won't perform implicit animations.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):
This should take a PlatformLayer instead of a GraphicsLayer, since we don't have
GraphicsLayers in the UIProcess.

  • WebKit2.xcodeproj/project.pbxproj:

Add GraphicsLayerCARemote and PlatformCALayerRemote, remove RemoteGraphicsLayer.

  • WebProcess/WebPage/mac/RemoteGraphicsLayer.h: Removed.
  • WebProcess/WebPage/mac/RemoteGraphicsLayer.mm: Removed.
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::RemoteLayerTreeContext):
(WebKit::RemoteLayerTreeContext::setRootLayer):
(WebKit::RemoteLayerTreeContext::layerWillBeDestroyed):
(WebKit::RemoteLayerTreeContext::createGraphicsLayer):
(WebKit::RemoteLayerTreeContext::flushLayers):
Build our transaction while flushing; it has no reason to exist outside of that scope.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::graphicsLayerFactory):
(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):
Fix a capitalization typo.
Update the WebPage's (and thus WebCore's) size when updateGeometry() is called.

  • WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp: Added.

(WebKit::GraphicsLayerCARemote::~GraphicsLayerCARemote):
(WebKit::GraphicsLayerCARemote::filtersCanBeComposited):
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
Added. Delegate to PlatformCALayerRemote. Don't allow creation of a
GraphicsLayerCARemote given a PlatformLayer, because with UI process compositing,
there should be no PlatformLayer instances in the Web process.

  • WebProcess/WebPage/mac/GraphicsLayerCARemote.h: Added.
  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp: Added.

(generateLayerID):
Generate a layer ID for identification across processes.

(PlatformCALayerRemote::~PlatformCALayerRemote):
Inform the RemoteLayerTreeContext that we've been destroyed, so it can convey
that information to the UI process and the corresponding CALayer can be destroyed.

(PlatformCALayerRemote::recursiveBuildTransaction):
Recursively accumulate changes in layer state on a RemoteLayerTreeTransaction.

The rest of this file is mostly an empty implementation of PlatformCALayer.
A few properties are implemented so far; see below.

(PlatformCALayerRemote::setSublayers):
(PlatformCALayerRemote::removeAllSublayers):
(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Update our list of sublayers, and note that our children have changed.
recursiveBuildTransaction() will walk our sublayers and record their IDs in the transaction.

(PlatformCALayerRemote::bounds):
(PlatformCALayerRemote::setBounds):
(PlatformCALayerRemote::position):
(PlatformCALayerRemote::setPosition):
(PlatformCALayerRemote::anchorPoint):
(PlatformCALayerRemote::setAnchorPoint):
(PlatformCALayerRemote::backgroundColor):
(PlatformCALayerRemote::setBackgroundColor):
Trivial implementations of basic layer properties, storing the new state in
our LayerProperties struct and noting that they changed in the current commit.
Properties with getters will return the last value that was set on the LayerProperties,
so we don't clear the whole struct at the end of the transaction, just the mask of changed properties.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h: Added.
  • WebCore.exp.in:

Export lots of GraphicsLayerCA stuff so we can inherit from it in WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

Make PlatformCAFilters.h a private header.

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::initialize):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayer::create):
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::initialize):

  • platform/graphics/ca/GraphicsLayerCA.h:

Defer creation of the main PlatformCALayer until just after the constructor is finished
so that GraphicsLayerCA subclasses can successfully override createPlatformCALayer.

  • platform/graphics/ca/PlatformCALayer.h:

(WebCore::PlatformCALayer::platformLayer):
Make platformLayer virtual so that subclasses which don't have PlatformLayers can override.

4:56 PM Changeset in webkit [157477] by roger_fong@apple.com
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

[Windows] Unreviewed gardening of some forms tests.

  • platform/win/fast/forms/search-styled-expected.txt: Added.
  • platform/win/fast/forms/select-writing-direction-natural-expected.txt: Removed.
3:40 PM Changeset in webkit [157476] by beidson@apple.com
  • 4 edits
    2 moves
    2 adds in trunk/Source/WebKit2

Move WebProcess/IndexedDB to WebProcess/Databases/IndexedDB

Rubberstamped by Alexey Proskuryakov.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp: Renamed from Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.cpp.
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h: Renamed from Source/WebKit2/WebProcess/IndexedDB/WebIDBFactoryBackend.h.
3:23 PM Changeset in webkit [157475] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[sh4] Some calls don't match sh4 ABI.
​https://bugs.webkit.org/show_bug.cgi?id=122863

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

3:16 PM Changeset in webkit [157474] by dbates@webkit.org
  • 52 edits
    8 adds in trunk/Source

[iOS] Upstream JavaScriptCore support for ARM64
​https://bugs.webkit.org/show_bug.cgi?id=122762

Source/JavaScriptCore:

Reviewed by Oliver Hunt and Filip Pizlo.

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/ToolExecutable.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARM64Assembler.h: Added.
  • assembler/AbstractMacroAssembler.h:

(JSC::isARM64):
(JSC::AbstractMacroAssembler::Label::Label):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::CachedTempRegister::CachedTempRegister):
(JSC::AbstractMacroAssembler::CachedTempRegister::registerIDInvalidate):
(JSC::AbstractMacroAssembler::CachedTempRegister::registerIDNoInvalidate):
(JSC::AbstractMacroAssembler::CachedTempRegister::value):
(JSC::AbstractMacroAssembler::CachedTempRegister::setValue):
(JSC::AbstractMacroAssembler::CachedTempRegister::invalidate):
(JSC::AbstractMacroAssembler::invalidateAllTempRegisters):
(JSC::AbstractMacroAssembler::isTempRegisterValid):
(JSC::AbstractMacroAssembler::clearTempRegisterValid):
(JSC::AbstractMacroAssembler::setTempRegisterValid):

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):

  • assembler/LinkBuffer.h:
  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::isPtrAlignedAddressOffset):
(JSC::MacroAssembler::pushToSave):
(JSC::MacroAssembler::popToRestore):
(JSC::MacroAssembler::patchableBranchTest32):

  • assembler/MacroAssemblerARM64.h: Added.
  • assembler/MacroAssemblerARMv7.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):

  • disassembler/ARM64/A64DOpcode.cpp: Added.
  • disassembler/ARM64/A64DOpcode.h: Added.
  • disassembler/ARM64Disassembler.cpp: Added.
  • heap/MachineStackMarker.cpp:

(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):

  • heap/Region.h:
  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::debugCall):

  • jit/CCallHelpers.h:
  • jit/ExecutableAllocator.h:
  • jit/FPRInfo.h:

(JSC::FPRInfo::toRegister):
(JSC::FPRInfo::toIndex):
(JSC::FPRInfo::debugName):

  • jit/GPRInfo.h:

(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

  • jit/JITInlines.h:

(JSC::JIT::restoreArgumentReferenceForTrampoline):

  • jit/JITOperationWrappers.h:
  • jit/JITOperations.cpp:
  • jit/JITStubs.cpp:

(JSC::performPlatformSpecificJITAssertions):
(JSC::tryCachePutByID):

  • jit/JITStubs.h:

(JSC::JITStackFrame::returnAddressSlot):

  • jit/JITStubsARM64.h: Added.
  • jit/JSInterfaceJIT.h:
  • jit/Repatch.cpp:

(JSC::emitRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::emitPutReplaceStub):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):

  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):

  • jsc.cpp:

(main):

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::handleHostCall):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter64.asm:
  • offlineasm/arm.rb:
  • offlineasm/arm64.rb: Added.
  • offlineasm/backends.rb:
  • offlineasm/instructions.rb:
  • offlineasm/risc.rb:
  • offlineasm/transform.rb:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::alignCallFrameSizeInBytes):
(JSC::Yarr::YarrGenerator::initCallFrame):
(JSC::Yarr::YarrGenerator::removeCallFrame):
(JSC::Yarr::YarrGenerator::generateEnter):

  • yarr/YarrJIT.h:

Source/WTF:

Reviewed by Oliver Hunt.

  • Configurations/Base.xcconfig:
  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):
(WTF::armV7_dmb):

  • wtf/FastMalloc.cpp:
  • wtf/Platform.h:
  • wtf/dtoa.cpp:
  • wtf/dtoa/utils.h:
  • wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

  • wtf/text/StringImpl.h:
3:05 PM Changeset in webkit [157473] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix 3 operand sub operation in C loop LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=122866.

Reviewed by Geoffrey Garen.

  • offlineasm/cloop.rb:
3:01 PM Changeset in webkit [157472] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/LayoutTests

Merging gardening patch for layout tests.

2:59 PM Changeset in webkit [157471] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/LayoutTests

Merging gardening patch for layout tests.

2:13 PM Changeset in webkit [157470] by rniwa@webkit.org
  • 3 edits
    3 adds in trunk

REGRESSION: Crash in XMLDocumentParser::startElementNs
​https://bugs.webkit.org/show_bug.cgi?id=122817

Reviewed by Darin Adler.

Source/WebCore:

Exit early in startElementNs when listeners and handlers of synchronous events such as load event
removes the inserted node inside parserAppendChild.

Test: fast/parser/xhtml-synchronous-detach-crash.html

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

LayoutTests:

Add a regression test from ​https://chromium.googlesource.com/chromium/blink/+/57afab5d21cccd89f032b9a3e62f3a61c6a0e9c2

  • fast/parser/resources/remove-parent.xhtml: Added.
  • fast/parser/xhtml-synchronous-detach-crash-expected.txt: Added.
  • fast/parser/xhtml-synchronous-detach-crash.html: Added.
2:11 PM Changeset in webkit [157469] by beidson@apple.com
  • 6 edits
    24 adds in trunk/Source/WebKit2

Add a skeleton Database process for future usage by Indexed Database.
​https://bugs.webkit.org/show_bug.cgi?id=122849

Reviewed by Sam Weinig.

This mostly our typical "Add a new process type" boilerplate.

  • Configurations/DatabaseProcess.xcconfig: Added.
  • Configurations/DatabaseService.Development.xcconfig: Added.
  • Configurations/DatabaseService.xcconfig: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2Prefix.h:
  • DatabaseProcess/DatabaseProcess.cpp: Added.

(WebKit::DatabaseProcess::shared):
(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::~DatabaseProcess):
(WebKit::DatabaseProcess::initializeConnection):
(WebKit::DatabaseProcess::shouldTerminate):
(WebKit::DatabaseProcess::didReceiveMessage):
(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):
(WebKit::DatabaseProcess::initializeProcess):
(WebKit::DatabaseProcess::initializeProcessName):
(WebKit::DatabaseProcess::initializeSandbox):

  • DatabaseProcess/DatabaseProcess.h: Added.
  • DatabaseProcess/EntryPoint/mac/LegacyProcess/DatabaseProcessMain.mm: Added.

(DatabaseProcessMain):

  • DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist: Added.
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist: Added.
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist: Added.
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm: Added.

(DatabaseServiceInitializer):

  • DatabaseProcess/mac/DatabaseProcessMac.mm: Added.

(WebKit::DatabaseProcess::initializeProcess):
(WebKit::DatabaseProcess::initializeProcessName):
(WebKit::DatabaseProcess::initializeSandbox):

  • UIProcess/Databases/DatabaseProcessProxy.cpp: Added.

(WebKit::DatabaseProcessProxy::create):
(WebKit::DatabaseProcessProxy::DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::~DatabaseProcessProxy):
(WebKit::DatabaseProcessProxy::getLaunchOptions):
(WebKit::DatabaseProcessProxy::connectionWillOpen):
(WebKit::DatabaseProcessProxy::connectionWillClose):
(WebKit::DatabaseProcessProxy::didReceiveMessage):
(WebKit::DatabaseProcessProxy::didClose):
(WebKit::DatabaseProcessProxy::didReceiveInvalidMessage):
(WebKit::DatabaseProcessProxy::didFinishLaunching):

  • UIProcess/Databases/DatabaseProcessProxy.h: Added.
  • UIProcess/Databases/mac/DatabaseProcessProxyMac.mm: Added.

(WebKit::shouldUseXPC):
(WebKit::DatabaseProcessProxy::platformGetLaunchOptions):

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::processTypeAsString):
(WebKit::ProcessLauncher::getProcessTypeFromString):

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName):
(WebKit::createProcess):

2:08 PM Changeset in webkit [157468] by mhahnenberg@apple.com
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

ObjCCallbackFunctionImpl shouldn't store a JSContext
​https://bugs.webkit.org/show_bug.cgi?id=122531

Reviewed by Geoffrey Garen.

The m_context field in ObjCCallbackFunctionImpl is vestigial and is only incidentally correct
in the common case. It's also no longer necessary in that we can look up the current JSContext
by looking using the globalObject of the callee when the function callback is invoked.

Also added a new test that would cause us to crash previously. The test required making
JSContextGetGlobalContext public API so that clients can obtain a JSContext from the JSContextRef
in C API callbacks.

  • API/JSContextRef.h:
  • API/JSContextRefPrivate.h:
  • API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl):
(JSC::objCCallbackFunctionCallAsFunction):
(objCCallbackFunctionForInvocation):

  • API/WebKitAvailability.h:
  • API/tests/CurrentThisInsideBlockGetterTest.h: Added.
  • API/tests/CurrentThisInsideBlockGetterTest.mm: Added.

(CallAsConstructor):
(ConstructorFinalize):
(ConstructorClass):
(+[JSValue valueWithConstructorDescriptor:inContext:]):
(-[JSContext valueWithConstructorDescriptor:]):
(currentThisInsideBlockGetterTest):

  • API/tests/testapi.mm:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/Debugger.cpp: Had to add some fully qualified names to avoid conflicts with Mac OS X headers.
2:03 PM Changeset in webkit [157467] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build after r157457 for architecture with 4 argument registers.
​https://bugs.webkit.org/show_bug.cgi?id=122860

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupStubArguments134):

1:47 PM Changeset in webkit [157466] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/Source/WebCore

Web Inspector: Remove old frontend localizedStrings.js
​https://bugs.webkit.org/show_bug.cgi?id=122846

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-15
Reviewed by Timothy Hatcher.

  • Configurations/WebCore.xcconfig:
  • English.lproj/localizedStrings.js: Removed.
  • WebCore.xcodeproj/project.pbxproj:

Remove the file and references to it. We no longer need to exclude
localizedString.js from some builds.

1:41 PM Changeset in webkit [157465] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Web Inspector: Remove Windows old front-end related code
​https://bugs.webkit.org/show_bug.cgi?id=122845

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-15
Reviewed by Brent Fulgham.

Source/WebCore:

  • WebCore.vcxproj/copyWebCoreResourceFiles.cmd:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):

1:28 PM Changeset in webkit [157464] by aestes@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit

Expose -[WebPluginPackage bundle] as SPI
​https://bugs.webkit.org/show_bug.cgi?id=122814

Reviewed by Anders Carlsson.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Added WebPluginPackagePrivate.h.

Source/WebKit/mac:

  • Plugins/WebPluginPackage.mm:

(-[WebPluginPackage bundle]): Defined.

  • Plugins/WebPluginPackagePrivate.h: Declared bundle as a method in a

category on NSObject.

1:24 PM Changeset in webkit [157463] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/LayoutTests

Merge r157460.

1:23 PM Changeset in webkit [157462] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/LayoutTests

Merge r157460.

1:20 PM Changeset in webkit [157461] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r157460.
​http://trac.webkit.org/changeset/157460
​https://bugs.webkit.org/show_bug.cgi?id=122858

Mis-skip, test isn't actually failing. (Requested by rfong on
#webkit).

  • platform/wk2/TestExpectations:
1:10 PM Changeset in webkit [157460] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip unexpected flakey test: webaudio/oscillator-sawtooth.html.

  • platform/wk2/TestExpectations:
12:40 PM Changeset in webkit [157459] by Antoine Quint
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: can't select text inside a text node
​https://bugs.webkit.org/show_bug.cgi?id=122828

Reviewed by Timothy Hatcher.

Cancel the default user interaction when a drag action starts if the
element is being edited.

  • UserInterface/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype.onattach):
(WebInspector.DOMTreeElement.prototype.handleEvent):

11:45 AM Changeset in webkit [157458] by commit-queue@webkit.org
  • 117 edits
    4 adds in trunk

Add support for the column-fill property
​https://bugs.webkit.org/show_bug.cgi?id=117693

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-10-15
Reviewed by David Hyatt.

Source/WebCore:

This is only supported in the (new) region based multicol implementation.

With column-fill support, a lot of multicol tests needed an update.
The old implementation behaved as if column-fill were 'auto', but the
initial value is 'balance', so now we need to be explicit about that.
For auto-height tests it doesn't really matter - such multicols are always
balanced anyway.

Tests: fast/multicol/newmulticol/fixed-height-fill-auto.html

fast/multicol/newmulticol/fixed-height-fill-balance.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ColumnFill):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • rendering/RenderMultiColumnBlock.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):

  • rendering/style/StyleMultiColData.h:

LayoutTests:

With column-fill support, a lot of multicol tests needed an update.
The old implementation behaved as if column-fill were 'auto', but the
initial value is 'balance', so now we need to be explicit about that.
For auto-height tests it doesn't really matter - such multicols are always
balanced anyway.

  • compositing/geometry/composited-in-columns.html:
  • fast/block/positioning/offsetLeft-offsetTop-multicolumn-expected.html:
  • fast/block/positioning/offsetLeft-offsetTop-multicolumn.html:
  • fast/borders/border-antialiasing.html:
  • fast/dynamic/float-moved-downwards-for-pagination-expected.html:
  • fast/dynamic/float-moved-downwards-for-pagination.html:
  • fast/dynamic/layer-no-longer-paginated.html:
  • fast/events/document-elementFromPoint.html:
  • fast/line-grid/line-grid-inside-columns.html:
  • fast/line-grid/line-grid-into-columns.html:
  • fast/multicol/break-properties.html:
  • fast/multicol/cell-shrinkback.html:
  • fast/multicol/client-rects.html:
  • fast/multicol/column-count-with-rules.html:
  • fast/multicol/fixed-column-percent-logical-height-orthogonal-writing-mode.html:
  • fast/multicol/flipped-blocks-hit-test.html:
  • fast/multicol/float-paginate-complex.html:
  • fast/multicol/float-paginate-empty-lines.html:
  • fast/multicol/float-paginate.html:
  • fast/multicol/float-truncation.html:
  • fast/multicol/hit-test-above-or-below.html:
  • fast/multicol/hit-test-end-of-column-with-line-height.html:
  • fast/multicol/hit-test-end-of-column.html:
  • fast/multicol/hit-test-float.html:
  • fast/multicol/image-inside-nested-blocks-with-border.html:
  • fast/multicol/layers-in-multicol.html:
  • fast/multicol/layers-split-across-columns.html:
  • fast/multicol/margin-collapse.html:
  • fast/multicol/mixed-opacity-fixed-test.html:
  • fast/multicol/mixed-opacity-test.html:
  • fast/multicol/mixed-positioning-stacking-order.html:
  • fast/multicol/nested-columns.html:
  • fast/multicol/newmulticol/cell-shrinkback-expected.html:
  • fast/multicol/newmulticol/cell-shrinkback.html:
  • fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
  • fast/multicol/newmulticol/fixed-height-fill-auto-expected.html: Added.
  • fast/multicol/newmulticol/fixed-height-fill-auto.html: Added.
  • fast/multicol/newmulticol/fixed-height-fill-balance-expected.html: Added.
  • fast/multicol/newmulticol/fixed-height-fill-balance.html: Added.
  • fast/multicol/newmulticol/float-avoidance-expected.html:
  • fast/multicol/newmulticol/float-avoidance.html:
  • fast/multicol/newmulticol/float-multicol-expected.html:
  • fast/multicol/newmulticol/float-multicol.html:
  • fast/multicol/newmulticol/float-paginate-complex-expected.html:
  • fast/multicol/newmulticol/float-paginate-complex.html:
  • fast/multicol/newmulticol/float-paginate-empty-lines-expected.html:
  • fast/multicol/newmulticol/float-paginate-empty-lines.html:
  • fast/multicol/newmulticol/float-paginate-expected.html:
  • fast/multicol/newmulticol/float-paginate.html:
  • fast/multicol/newmulticol/layers-in-multicol-expected.html:
  • fast/multicol/newmulticol/layers-in-multicol.html:
  • fast/multicol/newmulticol/layers-split-across-columns-expected.html:
  • fast/multicol/newmulticol/layers-split-across-columns.html:
  • fast/multicol/newmulticol/positioned-split-expected.html:
  • fast/multicol/newmulticol/positioned-split.html:
  • fast/multicol/newmulticol/positioned-with-constrained-height-expected.html:
  • fast/multicol/newmulticol/positioned-with-constrained-height.html:
  • fast/multicol/null-lastFloat-in-removeFloatingObjectsBelow.html:
  • fast/multicol/orphans-relayout.html:
  • fast/multicol/overflow-across-columns-percent-height.html:
  • fast/multicol/overflow-across-columns.html:
  • fast/multicol/overflow-content-expected.html:
  • fast/multicol/overflow-content.html:
  • fast/multicol/overflow-unsplittable.html:
  • fast/multicol/pageLogicalOffset-vertical-expected.html:
  • fast/multicol/pageLogicalOffset-vertical.html:
  • fast/multicol/paginate-block-replaced.html:
  • fast/multicol/positioned-outside-of-columns.html:
  • fast/multicol/positioned-split.html:
  • fast/multicol/positive-leading.html:
  • fast/multicol/progression-reverse-overflow-expected.html:
  • fast/multicol/progression-reverse-overflow.html:
  • fast/multicol/progression-reverse.html:
  • fast/multicol/scrolling-overflow.html:
  • fast/multicol/seamless-flowed-through-columns-expected.html:
  • fast/multicol/seamless-flowed-through-columns.html:
  • fast/multicol/table-margin-collapse.html:
  • fast/multicol/table-row-height-increase-expected.html:
  • fast/multicol/table-row-height-increase.html:
  • fast/multicol/table-vertical-align.html:
  • fast/multicol/transform-inside-opacity.html:
  • fast/multicol/unsplittable-inline-block.html:
  • fast/multicol/vertical-lr/break-properties.html:
  • fast/multicol/vertical-lr/column-count-with-rules.html:
  • fast/multicol/vertical-lr/float-multicol.html:
  • fast/multicol/vertical-lr/float-paginate-complex.html:
  • fast/multicol/vertical-lr/float-paginate.html:
  • fast/multicol/vertical-lr/float-truncation.html:
  • fast/multicol/vertical-lr/image-inside-nested-blocks-with-border.html:
  • fast/multicol/vertical-lr/nested-columns.html:
  • fast/multicol/vertical-lr/rules-with-border-before.html:
  • fast/multicol/vertical-lr/unsplittable-inline-block.html:
  • fast/multicol/vertical-rl/break-properties.html:
  • fast/multicol/vertical-rl/column-count-with-rules.html:
  • fast/multicol/vertical-rl/float-avoidance.html:
  • fast/multicol/vertical-rl/float-multicol.html:
  • fast/multicol/vertical-rl/float-paginate-complex.html:
  • fast/multicol/vertical-rl/float-paginate.html:
  • fast/multicol/vertical-rl/float-truncation.html:
  • fast/multicol/vertical-rl/image-inside-nested-blocks-with-border.html:
  • fast/multicol/vertical-rl/nested-columns.html:
  • fast/multicol/vertical-rl/rule-style.html:
  • fast/multicol/vertical-rl/rules-with-border-before.html:
  • fast/multicol/vertical-rl/unsplittable-inline-block.html:
  • fast/multicol/widows-and-orphans.html:
  • fast/regions/region-style-in-columns.html:
  • fast/repaint/multicol-repaint.html:
  • fast/sub-pixel/column-clipping.html:
11:33 AM Changeset in webkit [157457] by msaboff@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

transition void cti_op_* methods to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122617

Reviewed by Geoffrey Garen.

Converted the follow stubs to JIT operations:

cti_handle_watchdog_timer
cti_op_debug
cti_op_pop_scope
cti_op_profile_did_call
cti_op_profile_will_call
cti_op_put_by_index
cti_op_put_getter_setter
cti_op_tear_off_activation
cti_op_tear_off_arguments
cti_op_throw_static_error
cti_optimize

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):
(JSC::CCallHelpers::setupThreeStubArgsGPR):
(JSC::CCallHelpers::setupStubArguments):
(JSC::CCallHelpers::setupStubArguments134):

  • jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_tear_off_activation):
(JSC::JIT::emit_op_tear_off_arguments):
(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):
(JSC::JIT::emit_op_throw_static_error):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_pop_scope):
(JSC::JIT::emit_op_push_name_scope):
(JSC::JIT::emit_op_throw_static_error):
(JSC::JIT::emit_op_debug):
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter_setter):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_index):
(JSC::JIT::emit_op_put_getter_setter):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
11:17 AM Changeset in webkit [157456] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Skip unnecessary null check in RenderText::textLength().
<​https://webkit.org/b/122841>

Reviewed by Antti Koivisto.

RenderText will never have a null String in m_text, so textLength()
can grab at the StringImpl directly, avoiding a null check.

11:16 AM Changeset in webkit [157455] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

FontGenericFamilies should not be ref-counted.
<​https://webkit.org/b/122835>

Reviewed by Anders Carlsson.

FontGenericFamilies is singly-owned by Settings.

11:08 AM Changeset in webkit [157454] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Move RenderBlock::layoutShapeInsideInfo into RenderBlock.cpp
​http://bugs.webkit.org/show_bug.cgi?id=122843

Reviewed by Oliver Hunt.

Historically, layoutShapeInsideInfo was a static function in RenderBlockLineLayout, then it has changed to be a member of RenderBlock,
but at that time it hasn't been moved to RenderBlock.cpp. This patch moves it into RenderBlock.cpp next to the Shapes functions. I removed
an unnecessary CSS_SHAPES #ifdef as well from RenderBlock.cpp.

No new tests, no behavior change.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markShapeInsideDescendantsForLayout):
(WebCore::RenderBlock::layoutShapeInsideInfo):

  • rendering/RenderBlockLineLayout.cpp:
11:05 AM Changeset in webkit [157453] by Darin Adler
  • 7 edits
    3 adds in trunk/Tools

Add some API tests for Vector, RefPtr, and Ref
​https://bugs.webkit.org/show_bug.cgi?id=122840

Reviewed by Andreas Kling.

  • TestWebKitAPI/CMakeLists.txt: Added new files.
  • TestWebKitAPI/GNUmakefile.am: Ditto.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
  • TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
  • TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
  • TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
  • TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
11:03 AM Changeset in webkit [157452] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Introduce const pools in LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=122746

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-15
Reviewed by Michael Saboff.

In current implementation of LLINT for sh4, immediate values outside range -128..127 are
loaded this way:

mov.l .label, rx
bra out
nop
.balign 4
.label: .long immvalue
out:

This change introduces const pools for sh4 implementation to avoid lots of useless branches
and reduce code size. It also removes lines of dirty code, like jmpf and callf.

  • offlineasm/instructions.rb: Remove jmpf and callf sh4 specific instructions.
  • offlineasm/sh4.rb:
10:01 AM Changeset in webkit [157451] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix broken C Loop LLINT build.
​https://bugs.webkit.org/show_bug.cgi?id=122839.

Reviewed by Michael Saboff.

  • dfg/DFGFlushedAt.cpp:
  • jit/JITOperations.h:
9:39 AM Changeset in webkit [157450] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Build fails.
​https://bugs.webkit.org/show_bug.cgi?id=122830

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-15
Reviewed by Brent Fulgham.

  • platform/network/NetworkStorageSessionStub.cpp:

(WebCore::NetworkStorageSession::createPrivateBrowsingSession): Update to new return type.

6:02 AM Changeset in webkit [157449] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

FileIconLoader should not be ref-counted.
<​https://webkit.org/b/122827>

FileIconLoader is singly-owned by FileInputType.

Reviewed by Antti Koivisto.

4:45 AM Changeset in webkit [157448] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderText should cache RenderStyle in locals more.
<​https://webkit.org/b/122823>

Reviewed by Antti Koivisto.

Now that fetching the RenderStyle has to go through the parent,
we should avoid unnecessary loads by caching style() in a local.

4:44 AM Changeset in webkit [157447] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Soup] Unreviewed buildfix after r157445 for ENABLE(NETWORK_PROCESS) builds.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):

4:25 AM Changeset in webkit [157446] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix the GTK+ build after r157445.

  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(didFailProvisionalLoadWithErrorForFrame):

3:24 AM Changeset in webkit [157445] by Csaba Osztrogonác
  • 48 edits
    1 copy
    3 moves
    1 delete in trunk/Source

Move PlatformCertificateInfo to WebCore and make the ResourceResponse primitives work in terms of that platform agnostic object
​https://bugs.webkit.org/show_bug.cgi?id=118520

Reviewed by Anders Carlsson.

Added PlatformCertificateInfo getter and setter to ResourceErrorBase
and ResourceResponseBase so that getting and setting certificates
becomes cross platform.

Changed the existing platform specific certificate getters and setters
of ResourceError and ResourceResponse to use the
PlatformCertificateInfo member.

Original patch by Kwang Yul Seo <​skyul@company100.net>

Source/WebCore:

The following things were fixed by Csaba Osztrogonác:

  • trivial conflicts resolved in WebCore.exp.in, project.pbxproj, NetworkResourceLoader.cpp, WebPageProxy.h, WebFrameLoaderClient.cpp and PlatformEfl.cmake.
  • trivial fix in the new AsynchronousNetworkLoaderClient.cpp
  • style fixed (NULL -> 0 and smaller indentation in WebCoreArgumentCodersSoup.cpp)
  • obsolete change removed from NetworkResourceLoader.cpp
  • unneeded typo removed from ResourceHandleSoup.cpp
  • Fixed the if guard of including RetainPtr.h in PlatformCertificateInfo.h to make Windows build happy.
  • add PlatformCertificateInfoCFNet.cpp with empty constructor and destructor to make Windows build happy.
  • resolved conflict in Source/WebCore/WebCore.xcodeproj/project.pbxproj after r156488
  • renamed KURL to URL after r156550.
  • removed obsolete Qt changes
  • added back initializers for m_soupFlags
  • included gio/gio.h instead of libsoup/soup.h in PlatformCertificateInfo.h
  • removed unused class forward declarations and includes
  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/PlatformCertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.

(WebCore::PlatformCertificateInfo::certificate):
(WebCore::PlatformCertificateInfo::setCertificate):
(WebCore::PlatformCertificateInfo::tlsErrors):
(WebCore::PlatformCertificateInfo::setTLSErrors):

  • platform/network/ResourceErrorBase.h:

(WebCore::ResourceErrorBase::platformCertificateInfo):
(WebCore::ResourceErrorBase::setPlatformCertificateInfo):

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::platformCertificateInfo):
(WebCore::ResourceResponseBase::setPlatformCertificateInfo):

  • platform/network/cf/ResourceResponse.h:
  • platform/network/mac/PlatformCertificateInfoMac.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.

(WebCore::PlatformCertificateInfo::PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::setCertificateChain):
(WebCore::PlatformCertificateInfo::certificateChain):
(WebCore::PlatformCertificateInfo::dump):

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::setCertificateChain):
(WebCore::ResourceResponse::certificateChain):

  • platform/network/soup/PlatformCertificateInfoSoup.cpp:

(WebCore::PlatformCertificateInfo::PlatformCertificateInfo):
(WebCore::PlatformCertificateInfo::~PlatformCertificateInfo):

  • platform/network/soup/ResourceError.h:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::tlsErrors):
(WebCore::ResourceError::setTLSErrors):
(WebCore::ResourceError::certificate):
(WebCore::ResourceError::setCertificate):

  • platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::ResourceError::platformCopy):

  • platform/network/soup/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::soupMessageCertificate):
(WebCore::ResourceResponse::setSoupMessageCertificate):
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):
(WebCore::ResourceResponse::updateFromSoupMessage):

Source/WebKit2:

The following things were fixed by Csaba Osztrogonác:

  • trivial conflicts resolved in WebCore.exp.in, project.pbxproj, NetworkResourceLoader.cpp, WebPageProxy.h, WebFrameLoaderClient.cpp and PlatformEfl.cmake.
  • trivial fix in the new AsynchronousNetworkLoaderClient.cpp
  • style fixed (NULL -> 0 and smaller indentation in WebCoreArgumentCodersSoup.cpp)
  • obsolete change removed from NetworkResourceLoader.cpp
  • unneeded typo removed from ResourceHandleSoup.cpp
  • Fixed the if guard of including RetainPtr.h in PlatformCertificateInfo.h to make Windows build happy.
  • add PlatformCertificateInfoCFNet.cpp with empty constructor and destructor to make Windows build happy.
  • resolve conflict in Source/WebCore/WebCore.xcodeproj/project.pbxproj after r156488
  • rename KURL to URL after r156550.
  • remove obsolete Qt changes
  • added back initializers for m_soupFlags
  • included gio/gio.h instead of libsoup/soup.h in PlatformCertificateInfo.h
  • removed unused class forward declarations and includes
  • GNUmakefile.list.am:
  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/mac/NetworkProcessMac.mm:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):

  • Shared/Authentication/AuthenticationManager.h:
  • Shared/Authentication/AuthenticationManager.messages.in:
  • Shared/Authentication/mac/AuthenticationManager.mac.mm:
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebCertificateInfo.h:

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::decode):
(CoreIPC::::encode):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • Shared/soup/PlatformCertificateInfo.cpp: Removed.
  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • Target.pri:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_tls_info):

  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::useCredential):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

12:02 AM Changeset in webkit [157444] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove redundant Document::getElementById
​https://bugs.webkit.org/show_bug.cgi?id=122813

Reviewed by Andreas Kling.

Merge ​https://chromium.googlesource.com/chromium/blink/+/4e8f1c5316415614b84370c602beae4a1008299f

This function simply calls virtual TreeScope::getElementById and Document inherits from TreeScope.

  • WebCore.exp.in:
  • dom/Document.cpp:
  • dom/Document.h:

Oct 14, 2013:

10:55 PM Changeset in webkit [157443] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

Source/WebCore: in safari,the background-color of input[type="search"] can't work
​https://bugs.webkit.org/show_bug.cgi?id=119967

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.

When input type=search is styled with css background property then
it does not change the background-color of field. Its happening becasue
search field is not counted as styled control. Thus theme ignores the
css background property. With this patch search field is also counted as
styled control so background property reflects on search field.

Test: fast/forms/search/search-field-background-color.html

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isControlStyled):Now search field is also
a styled control.

LayoutTests: in safari ,the background-color of input[type="search"] can't work
​https://bugs.webkit.org/show_bug.cgi?id=119967

Patch by Santosh Mahto <​santosh.ma@samsung.com> on 2013-10-14
Reviewed by Ryosuke Niwa.

Added testcase to verify the background color of search field when
search field is styled with css background property.

  • fast/forms/search/search-field-background-color-expected.txt: Added.
  • fast/forms/search/search-field-background-color.html: Added.
  • platform/mac/fast/forms/search-styled-expected.txt: Rebaselined.
10:06 PM Changeset in webkit [157442] by zoltan@webkit.org
  • 1 edit
    22 moves
    1 add in trunk/LayoutTests

[CSS Shapes] Move shape-inside floats tests into their own subdirectory
​https://bugs.webkit.org/show_bug.cgi?id=122761

Reviewed by Sam Weinig.

I'm going to add some new float tests soon. In order to keep our shapes tests organized,
I'm moving the shape-inside with floating content tests to their own subdirectory.

  • fast/shapes/shape-inside/floats/shape-inside-floats-simple-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-floats-simple.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-floats-simple.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-lower-right-triangle.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-block-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-block-content.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html.
  • fast/shapes/shape-inside/floats/shape-inside-left-float-in-upper-right-triangle-inline-content.html: Renamed from LayoutTests/fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html.
9:08 PM Changeset in webkit [157441] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

EventPath::updateTouchLists traverses through EventPath thrice
​https://bugs.webkit.org/show_bug.cgi?id=122804

Reviewed by Benjamin Poulain.

Instead of traversing through EventPath for each TouchList, traverse through TouchList for every EventContext.
This paves our way to have one-pass traversal over EventPath, and evetually to remove EventContext altogether.

This change should also improve the cache hit rate since all Touch objects tend to be allocated at the same time
but this performance improvement is probably not observable.

  • dom/EventContext.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Added a new constructor that takes Touch and
and TouchListType. We need to store these two values in order to update EventContext later.
(WebCore::EventRelatedNodeResolver::touch): Added,
(WebCore::EventRelatedNodeResolver::touchListType): Added.
(WebCore::addRelatedNodeResolversForTouchList): Extracted from updateTouchListsInEventPath.
(WebCore::EventPath::updateTouchLists): Moved the loop over m_path here. Notice that the outer loop iterates
over m_path instead of touchList as done in updateTouchListsInEventPath. The inner loop goes through resolvers
and adds Touch objects each EventContext as needed.

8:48 PM Changeset in webkit [157440] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Below tests don't be failed anymore after enabling subpixel layout.

fast/spatial-navigation/snav-container-white-space.html
fast/spatial-navigation/snav-fully-aligned-horizontally.html
fast/spatial-navigation/snav-iframe-no-scrollable-content.html

  • platform/efl/TestExpectations:
8:03 PM Changeset in webkit [157439] by mark.lam@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Transition *switch* and *scope* JITStubs to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122757.

Reviewed by Geoffrey Garen.

Transitioning:

cti_op_switch_char
cti_op_switch_imm
cti_op_switch_string
cti_op_resolve_scope
cti_op_get_from_scope
cti_op_put_to_scope

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
7:47 PM Changeset in webkit [157438] by ap@apple.com
  • 16 edits in trunk/Source/WebCore

Don't generate a wasteful isObservable check in isReachableFromOpaqueRoots
​https://bugs.webkit.org/show_bug.cgi?id=122802

Reviewed by Mark Hahnenberg.

  • bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): Don't.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:

Updated results.

6:06 PM Changeset in webkit [157437] by roger_fong@apple.com
  • 5 edits
    1 delete in trunk

Windows select element doesn't draw RTL properly.
​https://bugs.webkit.org/show_bug.cgi?id=122785.

Reviewed by Brent Fulgham.

Problems include the popup items not drawing on the right hand side and
not respecting the direction or the directional override styling of the option.
The selected element (drawn in the actual select element) also doesn't respect
the style settings of the selected menu option.

Tests:
Covered by fast/text/international/pop-up-button-text-alignment-and-direction.html.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):

  • platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Removed.
5:38 PM Changeset in webkit [157436] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: AX: fieldset should have GroupRole and legend should be description.
​https://bugs.webkit.org/show_bug.cgi?id=122534

Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.

Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.

Test: accessibility/fieldset-element.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isHidden):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):

  • accessibility/AccessibilitySlider.h:
  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLFieldSetElement.h:

LayoutTests: Crash in WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>::createBidiRunsForLine
​https://bugs.webkit.org/show_bug.cgi?id=122776

Reviewed by Darin Adler.

  • fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash-expected.txt: Added.
  • fast/text/whitespace/whitespace-and-margin-wrap-after-list-marker-crash.html: Added.
5:35 PM Changeset in webkit [157435] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Adding myself to CC list for some components.

  • Scripts/webkitpy/common/config/watchlist:
5:23 PM Changeset in webkit [157434] by commit-queue@webkit.org
  • 12 edits
    2 adds
    6 deletes in trunk

AX: fieldset should have GroupRole and legend should be description.
​https://bugs.webkit.org/show_bug.cgi?id=122534

Patch by Samuel White <Samuel White> on 2013-10-14
Reviewed by Chris Fleizach.

Source/WebCore:

Changes fieldset to derive AXDescription from legend if one is available. Added
convenience method to AccessibilityObject to fetch element if available.

Test: accessibility/fieldset-element.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::alternativeText):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::element):
(WebCore::AccessibilityObject::isARIAHidden):
(WebCore::AccessibilityObject::isDOMHidden):
(WebCore::AccessibilityObject::defaultObjectInclusion):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isHidden):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::getAttribute):
(WebCore::AccessibilitySlider::valueForRange):
(WebCore::AccessibilitySlider::maxValueForRange):
(WebCore::AccessibilitySlider::minValueForRange):
(WebCore::AccessibilitySlider::setValue):
(WebCore::AccessibilitySlider::inputElement):

  • accessibility/AccessibilitySlider.h:
  • accessibility/mac/AccessibilityObjectMac.mm:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::legend):

  • html/HTMLFieldSetElement.h:

LayoutTests:

legend no longer treated as titleUIElement so removing tests that check this functionality.
Added test to check that legend is used as AXDescription of fieldset if present.

  • accessibility/fieldset-element.html: Added.
  • accessibility/hidden-legend-expected.txt: Removed.
  • accessibility/hidden-legend.html: Removed.
  • accessibility/legend.html: Removed.
  • platform/efl/accessibility/legend-expected.txt: Removed.
  • platform/gtk/accessibility/legend-expected.txt: Removed.
  • platform/mac/accessibility/fieldset-element-expected.txt: Added.
  • platform/mac/accessibility/legend-expected.txt: Removed.
  • platform/mac/accessibility/role-subrole-roledescription-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription.html:
5:05 PM Changeset in webkit [157433] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG PutById IC should use the ConcurrentJITLocker since it's now dealing with IC's that get read by the compiler thread
​https://bugs.webkit.org/show_bug.cgi?id=122786

Reviewed by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStub): Resetting a stub should acquire the lock since this is observable from the thread; but we should only acquire the lock if we're resetting outside of GC.

  • jit/Repatch.cpp:

(JSC::repatchPutByID): Doing the PutById patching should hold the lock.
(JSC::buildPutByIdList): Ditto.

5:02 PM Changeset in webkit [157432] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build fix.

  • WebCore.vcxproj/WebCoreCommon.props:
4:58 PM Changeset in webkit [157431] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Assertion failure in Range::processContentsBetweenOffsets
​https://bugs.webkit.org/show_bug.cgi?id=122777

Reviewed by Darin Adler.

Source/WebCore:

Merge ​https://chromium.googlesource.com/chromium/blink/+/c15de182774c7859c20d97126eb844ae97b792a4

This patch changes ASSERT statements for checking |endOffset| inbound in Range::processContentsBetweenOffsets()
to limit |endOffset|. This is necessary when DOMNodeRemovedFromDocument event handler splits text nodes,
Range::insertNode() on text node, in the range calling Range::deleteContents().

Test: fast/dom/Range/range-delete-contents-mutation-event-crash.html

  • dom/Range.cpp:

(WebCore::Range::processContentsBetweenOffsets):

LayoutTests:

  • fast/dom/Range/range-delete-contents-mutation-event-crash-expected.txt: Added.
  • fast/dom/Range/range-delete-contents-mutation-event-crash.html: Added.
4:36 PM Changeset in webkit [157430] by ap@apple.com
  • 12 edits
    11 adds in trunk

Add an empty window.crypto.webkitSubtle
​https://bugs.webkit.org/show_bug.cgi?id=122778

Reviewed by Mark Hahnenberg.

Source/WebCore:

Tests: security/crypto-subtle-gc-2.html

security/crypto-subtle-gc-3.html
security/crypto-subtle-gc.html

  • DerivedSources.make: Process SubtleCrypto.idl.
  • crypto: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • bindings/js/JSSubtleCryptoCustom.cpp: Added. Empty for now, but we'll certainly

need custom bindings code here.

  • crypto/SubtleCrypto.cpp: Added.

(WebCore::SubtleCrypto::SubtleCrypto):
(WebCore::SubtleCrypto::document):

  • crypto/SubtleCrypto.h: Added.
  • crypto/SubtleCrypto.idl: Added.
  • page/Crypto.cpp:

(WebCore::Crypto::subtle):

  • page/Crypto.h:
  • page/Crypto.idl:

LayoutTests:

  • TestExpectations: The feature isn't enabled anywhere yet, so skipping the new tests.
  • security/crypto-subtle-gc-2-expected.txt: Added.
  • security/crypto-subtle-gc-2.html: Added.
  • security/crypto-subtle-gc-3-expected.txt: Added.
  • security/crypto-subtle-gc-3.html: Added.
  • security/crypto-subtle-gc-expected.txt: Added.
  • security/crypto-subtle-gc.html: Added.
4:30 PM Changeset in webkit [157429] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add FTL support for LogicalNot(string)
​https://bugs.webkit.org/show_bug.cgi?id=122765

Patch by Nadav Rotem <​nrotem@apple.com> on 2013-10-14
Reviewed by Filip Pizlo.

This patch is tested by:
regress/script-tests/emscripten-cube2hash.js.ftl-eager

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):

4:26 PM Changeset in webkit [157428] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove GestureEvent leftovers from WebCore
<​https://webkit.org/b/122780>

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.

  • Removed some remaining references to PlatformGestureEvent, supposed to be removed by r157316
  • TOUCH_ADJUSTMENT should be reworked after GestureEvent feature removal
  • page/EventHandler.cpp:

(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

  • page/EventHandler.h:
  • platform/PlatformEvent.h:
  • platform/ScrollAnimatorNone.cpp:
  • platform/ScrollableArea.h:
4:22 PM Changeset in webkit [157427] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[sh4] Fixes after r157404 and r157411.
​https://bugs.webkit.org/show_bug.cgi?id=122782

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-10-14
Reviewed by Michael Saboff.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JITInlines.h:

(JSC::JIT::callOperation): Add missing SH4_32BIT_DUMMY_ARG.

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_put_by_id): Remove unwanted BEGIN_UNINTERRUPTED_SEQUENCE.

4:17 PM Changeset in webkit [157426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r157366
​http://bugs.webkit.org/show_bug.cgi?id=122783

When TOUCH_AJUSTMENT is enabled build fails due to some
refactors in TextRender functions.

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-10-14
Reviewed by Anders Carlsson.

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::appendContextSubtargetsForNode):

4:08 PM Changeset in webkit [157425] by Alexandru Chiculita
  • 5 edits
    3 adds in trunk

The content of the DOM panel for iframes is not updated until the "onload" event
​https://bugs.webkit.org/show_bug.cgi?id=122653

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/inspector-protocol/loading-iframe-document-node.html

Renamed InspectorDOMAgent::loadEventFired to InspectorDOMAgent::didCommitLoad and moved the call site
from InspectorInstrumentation::loadEventFiredImpl to InspectorInstrumentation::didCommitLoadImpl.
This is to make sure that it will invalidate the content of the iframe as soon as the frame navigates
to a different page. This way the new node can be retrieved as soon as the page has some content, and
not just when the page is fully loaded.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didCommitLoad): Renamed from loadEventFired, as it is now called from
didCommitLoadImpl instead.
(WebCore::InspectorDOMAgent::frameDocumentUpdated): Updated comment to point to the new function name.

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::loadEventFiredImpl): Removed call do InspectorDOMAgent.loadEventFired.
(WebCore::InspectorInstrumentation::didCommitLoadImpl): Added call to InspectorDOMAgent.didCommitLoad.

LayoutTests:

Added test to check that immediately after the scripting context is created, the
inspector already has access to the nodeId of the document of the iframe.

  • http/tests/inspector-protocol/loading-iframe-document-node-expected.txt: Added.
  • http/tests/inspector-protocol/loading-iframe-document-node.html: Added.
  • http/tests/inspector-protocol/resources/slow-test-page.html: Added.
2:59 PM Changeset in webkit [157424] by commit-queue@webkit.org
  • 14 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r157413.
​http://trac.webkit.org/changeset/157413
​https://bugs.webkit.org/show_bug.cgi?id=122779

Appears to have caused frequent crashes (Requested by ap on
#webkit).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/DeferGC.cpp: Removed.
  • heap/DeferGC.h:
  • jit/JITStubs.cpp:

(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ConcurrentJITLock.h:
  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSCellInlines.h:

(JSC::allocateCell):

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):

  • runtime/Structure.h:
2:45 PM Changeset in webkit [157423] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=122774.
<rdar://problem/6138855>.

Reviewed by Brent Fulgham.

Add a field to keep track of hovered over index.
Use index to determine whether or not to use the existing selected index on the mouse down event.

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::PopupMenuWin):
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::wndProc):

  • platform/win/PopupMenuWin.h:
2:41 PM Changeset in webkit [157422] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

COLLECT_ON_EVERY_ALLOCATION causes assertion failures
​https://bugs.webkit.org/show_bug.cgi?id=122652

Reviewed by Filip Pizlo.

COLLECT_ON_EVERY_ALLOCATION wasn't accounting for the new GC deferral mechanism,
so we would end up ASSERTing during garbage collection.

  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::allocateSlowCase):

2:11 PM Changeset in webkit [157421] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, fix the paths so that the test passes.

  • js/regress/put-by-id.html:
2:08 PM Changeset in webkit [157420] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Separate out array iteration intrinsics
​https://bugs.webkit.org/show_bug.cgi?id=122656

Reviewed by Michael Saboff.

Separate out the intrinsics for key and values iteration
of arrays.

This requires moving moving array iteration into the iterator
instance, rather than the prototype, but this is essentially
unobservable so we'll live with it for now.

  • jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):
(JSC::arrayIteratorNextKeyThunkGenerator):
(JSC::arrayIteratorNextValueThunkGenerator):

  • jit/ThunkGenerators.h:
  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):

  • runtime/Intrinsic.h:
  • runtime/JSArrayIterator.cpp:

(JSC::JSArrayIterator::finishCreation):
(JSC::createIteratorResult):
(JSC::arrayIteratorNext):
(JSC::arrayIteratorNextKey):
(JSC::arrayIteratorNextValue):
(JSC::arrayIteratorNextGeneric):

  • runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

1:49 PM Changeset in webkit [157419] by timothy_horton@apple.com
  • 18 edits
    3 adds in trunk/Source

Virtualize PlatformCALayer
​https://bugs.webkit.org/show_bug.cgi?id=122672

Reviewed by Anders Carlsson.

No new tests, just a refactoring.

  • WebCore.exp.in:

setGeometryFlipped is on PlatformCALayerMac now.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Add PlatformCALayer.cpp, PlatformCALayerWin.h, and let VS do its
thing with some other files.

  • WebCore.xcodeproj/project.pbxproj:

Add PlatformCALayer.cpp and PlatformCALayerMac.h.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::platformLayer):
Make a PlatformCALayerWin explicitly.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayer):
Added. Decide whether to make a PlatformCALayer{Mac, Win} based on the platform.
Later, we will decide between other subclasses based on other things.

(WebCore::GraphicsLayerCA::filtersCanBeComposited):
Do the same thing for filtersCanBeComposited.

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setContentsToSolidColor):
(WebCore::GraphicsLayerCA::setContentsToMedia):
(WebCore::GraphicsLayerCA::setContentsToCanvas):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::ensureStructuralLayer):
(WebCore::GraphicsLayerCA::updateContentsImage):
(WebCore::GraphicsLayerCA::updateContentsRects):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
Use createPlatformCALayer instead of PlatformCALayer::create.

  • platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

For now, use the PlatformCALayerMac version of filtersCanBeComposited,
since this code is heavily tied to having CALayers in the Web process.

  • platform/graphics/ca/GraphicsLayerCA.h:

Include PlatformCALayer.h here so we can get the LayerType enum.
(NOTE-to-be-removed: if there's a better way to do this, I'm open to
suggestions; I couldn't puzzle out nested 'enum class' stuff).

Add the createPlatformCALayers.

  • platform/graphics/ca/PlatformCAAnimation.h:

Friend the subclasses too.

  • platform/graphics/ca/PlatformCALayer.cpp: Added.

(WebCore::PlatformCALayer::~PlatformCALayer):
Pull the shared part of the PlatformCALayer destructor out.

  • platform/graphics/ca/PlatformCALayer.h:

(WebCore::PlatformCALayer::platformLayer):
(WebCore::PlatformCALayer::setOwner):
(WebCore::PlatformCALayer::PlatformCALayer):
Virtualize all the things. Move platform specific members to their new subclasses.

  • platform/graphics/ca/mac/PlatformCALayerMac.h: Added.
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

Move the PLATFORM(MAC) implementations from PlatformCALayer to PlatformCALayerMac.

(PlatformCALayer::platformCALayer):
The platformCALayer lookup function is static on PlatformCALayer, so it can't
be moved to the subclasses. It might be a good idea in the future to move towards
a platform-independent mechanism for looking up PlatformCALayers from PlatformLayers,
and to avoid needing to do this as often as we do now.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::CACFLayerTreeHost):

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

Move the PLATFORM(WIN) implementations from PlatformCALayer to PlatformCALayerWin.

(PlatformCALayerWin::create):
(PlatformCALayer::platformCALayer):

  • platform/graphics/ca/win/PlatformCALayerWin.h: Added.
  • platform/graphics/win/GraphicsContext3DWin.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::createLayerForMovie):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::FullscreenVideoController):
Include PlatformCALayerWin.h and explicitly make PlatformCALayerWins here.

1:44 PM Changeset in webkit [157418] by Hugo Parente Lima
  • 3 edits in trunk/Source/WebCore

[cmake] MediaControlsApple is used only by Efl port and is on CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=122772

Reviewed by Anders Carlsson.

  • CMakeLists.txt: Removed MediaControlsApple.cpp
  • PlatformEfl.cmake: Added MediaControlsApple.cpp
1:28 PM Changeset in webkit [157417] by ap@apple.com
  • 6 edits
    2 adds in trunk

window.crypto doesn't preserve custom properties
​https://bugs.webkit.org/show_bug.cgi?id=122770

Reviewed by Mark Hahnenberg.

Source/WebCore:

Test: security/crypto-gc.html

Generate isReachableFromOpaqueRoots that makes Crypto live as long as the document
lives (because that's when it's observable through window object).

  • page/Crypto.cpp:

(WebCore::Crypto::Crypto):
(WebCore::Crypto::~Crypto):
(WebCore::Crypto::document):

  • page/Crypto.h:

(WebCore::Crypto::create):
Made Crypto a ContextDestructionObserver, so that it can report its document to bindings.
Removed ScriptWrappable, because it seems to have served no purpose in this class.

  • page/Crypto.idl: Added GenerateIsReachable. Removed ImplementationLacksVTable,

because the class now has a vtable, and can be checked for bindings integrity.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::crypto): Pass a document when creating

crypto.

LayoutTests:

  • security/crypto-gc-expected.txt: Added.
  • security/crypto-gc.html: Added.
1:11 PM Changeset in webkit [157416] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE: NamedNodeMap always has a corresponding Element.
<​https://webkit.org/b/122769>

Reviewed by Anders Carlsson.

Made NamedNodeMap::m_element a reference and remove an assertion
that it's never null.

12:53 PM Changeset in webkit [157415] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r157408): Crashes in RenderFullScreen::wrapRenderer().

Unreviewed crash fix for these two tests:

  • fullscreen/full-screen-restrictions.html
  • fullscreen/empty-anonymous-block-continuation-crash.html
  • rendering/RenderFullScreen.cpp:

(RenderFullScreen::wrapRenderer):

Get the RenderArena from Document like we did before this patch.

12:35 PM Changeset in webkit [157414] by hmuller@adobe.com
  • 4 edits
    2 adds in trunk

[CSS Shapes] Image valued shape-outside shapes should update the layout after the image has been loaded
​https://bugs.webkit.org/show_bug.cgi?id=122340

Reviewed by Simon Fraser.

Source/WebCore:

Ensure that the an image-valued shape-outside layout is updated after the image has
been loaded.

Test: http/tests/css/css-image-valued-shape.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::imageChanged): Added code for the shape-outside case.
(WebCore::RenderBlock::updateShapeInsideInfoAfterStyleChange): Ditto.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement): Ditto.
(WebCore::RenderElement::setStyle): Ditto.

LayoutTests:

Verify that an image-valued shape-outside layout is updated after the image has been loaded.

  • http/tests/css/css-image-valued-shape-expected.txt: Added.
  • http/tests/css/css-image-valued-shape.html: Added.
12:34 PM Changeset in webkit [157413] by mhahnenberg@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

llint_slow_path_put_by_id can deadlock on a ConcurrentJITLock
​https://bugs.webkit.org/show_bug.cgi?id=122667

Reviewed by Filip Pizlo.

The issue this patch is attempting to fix is that there are places in our codebase
where we acquire the ConcurrentJITLock for a particular CodeBlock, then we do some
operations that can initiate a garbage collection. Garbage collection then calls
some methods of CodeBlock that also take the ConcurrentJITLock (because they don't
always necessarily run during garbage collection). This causes a deadlock.

To fix this issue, this patch adds a new RAII-style object (DisallowGC) that stores
into a thread-local field that indicates that it is unsafe to perform any operation
that could trigger garbage collection on the current thread. In debug builds,
ConcurrentJITLocker contains one of these DisallowGC objects so that we can eagerly
detect deadlocks.

This patch also adds a new type of ConcurrentJITLocker, GCSafeConcurrentJITLocker,
which uses the DeferGC mechanism to prevent collections from occurring while the
lock is held.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/DeferGC.cpp: Added.
  • heap/DeferGC.h:

(JSC::DisallowGC::DisallowGC):
(JSC::DisallowGC::~DisallowGC):
(JSC::DisallowGC::isGCDisallowedOnCurrentThread):
(JSC::DisallowGC::initialize):

  • jit/JITStubs.cpp:

(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/ConcurrentJITLock.h:

(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::~ConcurrentJITLockerBase):
(JSC::ConcurrentJITLockerBase::unlockEarly):
(JSC::GCSafeConcurrentJITLocker::GCSafeConcurrentJITLocker):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

  • runtime/JSCellInlines.h:

(JSC::allocateCell):

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::putSpecificValue):
(JSC::Structure::createPropertyMap):

  • runtime/Structure.h:
12:24 PM Changeset in webkit [157412] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove some silly null checks in Element/NamedNodeMap.
<​https://webkit.org/b/122767>

Reviewed by Darin Adler.

Make shouldIgnoreAttributeCase() take a const Element&, exposing
some unnecessary null checks.

11:39 AM Changeset in webkit [157411] by fpizlo@apple.com
  • 19 edits
    3 adds in trunk

Baseline JIT should use the DFG's PutById IC
​https://bugs.webkit.org/show_bug.cgi?id=122704

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Mostly no big deal, just removing the old Baseline JIT's put_by_id IC support and forcing
that JIT to use the DFG's (i.e. JITOperations) PutById IC.

The only complicated part was that the PutById operations assumed that we first did a
cell speculation, which the baseline JIT obviously won't do. So I changed all of those
slow paths to deal with EncodedJSValue's.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedPutById):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • jit/JIT.h:

(JSC::PropertyStubCompilationInfo::PropertyStubCompilationInfo):
(JSC::PropertyStubCompilationInfo::slowCaseInfo):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperationWrappers.h:
  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/Repatch.cpp:

(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::resetPutByID):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • js/regress/put-by-id-expected.txt: Added.
  • js/regress/put-by-id.html: Added.
  • js/regress/script-tests/put-by-id.js: Added.

(foo):
(bar):

11:29 AM Changeset in webkit [157410] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Build fix after r122737.

  • dom/Node.h: Add explicit WebCore namespace to macro definition to work around

Visual Studio bug.

11:08 AM Changeset in webkit [157409] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

FTL should have an inefficient but correct implementation of GetById
​https://bugs.webkit.org/show_bug.cgi?id=122740

Reviewed by Mark Hahnenberg.

It took some effort to realize that the node->prediction() check in the DFG backends
are completely unnecessary since the ByteCodeParser will always insert a ForceOSRExit
if !prediction.

But other than that this was an easy patch.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetById):

10:55 AM Changeset in webkit [157408] by akling@apple.com
  • 149 edits in trunk/Source/WebCore

Pass Document directly to anonymous renderer constructors.
<​https://webkit.org/b/122752>

Reviewed by Antti Koivisto.

Added separate constructors for creating anonymous renderers that
take a Document& instead of a null Element*/Text*.

Removed setDocumentForAnonymous() and all createAnonymous() helpers.
...and RenderObject::m_node is now a Node&, wohoo!

10:50 AM Changeset in webkit [157407] by mihnea@adobe.com
  • 7 edits
    8 moves
    1 add in trunk/LayoutTests

[CSSRegions] Move style-scoped* tests into fast/regions/style-scoped
​https://bugs.webkit.org/show_bug.cgi?id=122741

Reviewed by Darin Adler.

Move files, adjust TestExpectations.

  • fast/regions/style-scoped/style-scoped-in-flow-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-container-style.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling-multiple-regions.html.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow-override-region-styling.html.
  • fast/regions/style-scoped/style-scoped-in-flow.html: Renamed from LayoutTests/fast/regions/style-scoped-in-flow.html.
  • platform/efl/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
10:16 AM Changeset in webkit [157406] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[WK2][Efl][Soup] Make NetworkProcessMainUnix handle proxy settings.
​https://bugs.webkit.org/show_bug.cgi?id=118388

Reviewed by Carlos Garcia Campos.

Original patch by Kwang Yul Seo <​skyul@company100.net> .

Proxy configuration should honor the no_proxy environment variable
same to WebProcess. It is necessary not to change the current behaviour.
See ​https://bugs.webkit.org/show_bug.cgi?id=91747 for details.

The following things were fixed by Csaba Osztrogonác:

  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:

(WebKit::NetworkProcessMain):
Copied from WebProcessMainEfl.cpp.

9:52 AM Changeset in webkit [157405] by weinig@apple.com
  • 31 edits in trunk/Source/WebCore

CTTE: Add more node conversion helpers
​https://bugs.webkit.org/show_bug.cgi?id=122737

Reviewed by Darin Adler.

  • Factor NODE_TYPE_CASTS into TYPE_CASTS_BASE(ToClassName, FromClassName) to allow for DOCUMENT_TYPE_CASTS.
  • Replace more static_casts<>.
9:42 AM Changeset in webkit [157404] by mark.lam@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Transition misc cti_op_* JITStubs to JIT operations.
​https://bugs.webkit.org/show_bug.cgi?id=122645.

Reviewed by Michael Saboff.

Stubs converted:

cti_op_check_has_instance
cti_op_create_arguments
cti_op_del_by_id
cti_op_instanceof
cti_to_object
cti_op_push_activation
cti_op_get_pnames
cti_op_load_varargs

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.h:

(JSC::JIT::emitStoreCell):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_del_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_del_by_id):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
8:55 AM Changeset in webkit [157403] by Michał Pakuła vel Rutka
  • 9 edits
    31 adds in trunk/LayoutTests

Unreviewed EFL gardening

Added new baselines for tests marked as skipped.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/compositing/overflow/nested-scrolling-expected.txt: Added.
  • platform/efl/compositing/overflow/remove-overflow-crash2-expected.png: Added.
  • platform/efl/compositing/overflow/remove-overflow-crash2-expected.txt: Added.
  • platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
  • platform/efl/editing/unsupported-content/list-delete-001-expected.png:
  • platform/efl/editing/unsupported-content/list-delete-001-expected.txt: Added.
  • platform/efl/editing/unsupported-content/list-delete-003-expected.png:
  • platform/efl/editing/unsupported-content/list-delete-003-expected.txt: Added.
  • platform/efl/editing/unsupported-content/list-type-after-expected.png:
  • platform/efl/editing/unsupported-content/list-type-after-expected.txt: Added.
  • platform/efl/editing/unsupported-content/table-delete-002-expected.png:
  • platform/efl/editing/unsupported-content/table-delete-002-expected.txt: Added.
  • platform/efl/fast/canvas/fill-stroke-clip-reset-path-expected.png: Added.
  • platform/efl/fast/table/click-near-anonymous-table-expected.png: Added.
  • platform/efl/fast/table/click-near-anonymous-table-expected.txt: Added.
  • platform/efl/fast/text/international/arabic-justify-expected.png: Added.
  • platform/efl/fast/text/international/arabic-justify-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-linebreak-001-expected.png: Added.
  • platform/efl/fast/text/international/bidi-linebreak-001-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-linebreak-002-expected.png: Added.
  • platform/efl/fast/text/international/bidi-linebreak-002-expected.txt: Added.
  • platform/efl/fast/text/international/bidi-linebreak-003-expected.png: Added.
  • platform/efl/fast/text/international/bidi-linebreak-003-expected.txt: Added.
  • platform/efl/fast/text/unicode-variation-selector-expected.png: Added.
  • platform/efl/fast/text/unicode-variation-selector-expected.txt: Added.
  • platform/efl/media/video-colorspace-yuv420-expected.png: Added.
  • platform/efl/media/video-colorspace-yuv420-expected.txt: Added.
  • platform/efl/media/video-colorspace-yuv422-expected.png: Added.
  • platform/efl/media/video-colorspace-yuv422-expected.txt: Added.
  • platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.png: Added.
  • platform/efl/svg/as-image/image-respects-deviceScaleFactor-expected.txt: Added.
  • platform/efl/svg/hixie/data-types/002-expected.png: Added.
  • platform/efl/svg/hixie/data-types/002-expected.txt:
  • platform/efl/svg/text/non-bmp-positioning-lists-expected.png: Added.
  • platform/efl/svg/text/non-bmp-positioning-lists-expected.txt: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.png: Added.
  • platform/efl/svg/zoom/text/zoom-hixie-mixed-009-expected.txt:
8:46 AM Changeset in webkit [157402] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Static assertions in WTF::adoptPtr should point to using adoptRef for ref-counted objects
​https://bugs.webkit.org/show_bug.cgi?id=122745

Reviewed by Anders Carlsson.

  • wtf/PassOwnPtr.h:

(WTF::adoptPtr): When the object's type is convertible to the RefCountedBase or ThreadSafeRefCountedBase type,
the static assertion should note that adoptRef should be used instead.

8:45 AM Changeset in webkit [157401] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Reintroduce PassRefPtr<Event> copy in ScopedEventQueue::dispatchEvent
​https://bugs.webkit.org/show_bug.cgi?id=122742

Reviewed by Alexey Proskuryakov.

This is a follow-up to r157219 which introduced a workaround for the GCC's quirky behavior that
was resulting in crashes due to the PassRefPtr<Event> object passed to EventDispatcher::dispatchEvent
being copied and nullified first before retrieving the EventTarget of the Event object wrapped in that
PassRefPtr.

The implementation is now adjusted to first retrieve the pointer to the Event's EventTarget and store
it in a local variable. That variable is then passed as the first parameter to EventDispatcher::dispatchEvent,
and the PassRefPtr<Event> passed directly as the second parameter. Previously the pointer of that PassRefPtr
object was passed in, with a new PassRefPtr being created which would increase the reference count of the
ref-counted object. Passing in the original PassRefPtr avoids the unnecessary reference count increase by creating
a copy. That still nullifies the original PassRefPtr, but that's not a problem anymore.

  • dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::dispatchEvent):

8:34 AM Changeset in webkit [157400] by betravis@adobe.com
  • 4 edits
    4 adds in trunk

[CSS Shapes] Shape-Margin should be animatable
​https://bugs.webkit.org/show_bug.cgi?id=122524

Reviewed by Darin Adler.

Source/WebCore:

Mark content for relayout after shape-margin changes, and add shape-margin
to the list of animatable properties.

Tests: fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html

fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add
shape-margin to the map of animatable CSS properties.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::updateShapeOutsideInfoAfterStyleChange): Compare shape-margins,
and mark dependent content for relayout if they have changed.

LayoutTests:

Test that shape-margin can be set dynamically and content lays out correctly.
Also test that shape-margin can be manipulated through CSS Animations.

  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-dynamic-shape-margin.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-shape-margin-animation.html: Added.
7:17 AM Changeset in webkit [157399] by g.czajkowski@samsung.com
  • 2 edits in trunk/LayoutTests

[EFL] Accessibility gardening
​https://bugs.webkit.org/show_bug.cgi?id=122751

Unreviewed EFL gardening.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-14

  • platform/efl-wk2/TestExpectations: Add bug numbers and marked missing tests.
7:03 AM Changeset in webkit [157398] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't crash after OpenGL robustness reset
​https://bugs.webkit.org/show_bug.cgi?id=122750

Patch by Arvid Nilsson <​anilsson@blackberry.com> on 2013-10-14
Reviewed by George Staikos.

JIRA 517132.
Just log the incident and pretend like nothing happened.

No new tests, we don't have repeatable steps to reproduce a robustness
reset.

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::makeContextCurrent):

6:39 AM Changeset in webkit [157397] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

[EFL] Buildfix after r157393
​https://bugs.webkit.org/show_bug.cgi?id=122749

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-14
Reviewed by Andreas Kling.

Buildfix with error enumeration value 'CSS_FR' not handled in switch.

  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):

6:08 AM Changeset in webkit [157396] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

WebKit Nightlies broken by r157374
​https://bugs.webkit.org/show_bug.cgi?id=122736

Reviewed by Andreas Kling.

Add back a callOnMainThread overload that Safari is using.

  • wtf/MainThread.cpp:

(WTF::callOnMainThread):

  • wtf/MainThread.h:
5:48 AM Changeset in webkit [157395] by gyuyoung.kim@samsung.com
  • 2 edits
    5 adds in trunk/LayoutTests

Unreviewed. EFL Gardening.
Add baselines for new tests which was added by r156767.

  • platform/efl/TestExpectations: Remove tests supported by this commit.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Added.
3:41 AM Changeset in webkit [157394] by mario@webkit.org
  • 4 edits
    1 add in trunk

[EFL] Present replaced objects with 0xFFFC character
​https://bugs.webkit.org/show_bug.cgi?id=122744

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-10-14
Reviewed by Mario Sanchez Prada.

Source/WebCore:

Replaced elements should be emitted in GTK/EFL and
marked their presence with the replacement character.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::textIteratorBehaviorForTextRange):

LayoutTests:

Added new accessibility expectation after r156532.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
3:36 AM Changeset in webkit [157393] by svillar@igalia.com
  • 25 edits
    9 adds in trunk

[CSS Grid Layout] Implement support for <flex>
​https://bugs.webkit.org/show_bug.cgi?id=115362

Reviewed by Andreas Kling.

From Blink r149134, r149480, r149532, r150287 and r156127 by <​jchaffraix@chromium.org>
From Blink r157820 by <​svillar@igalia.com>

Source/WebCore:

Added support for flexible lengths ('fr' unit) in CSS Grid Layout
code. This requires the addition of GridLength class to
encapsulate the knowledge of <flex> to the grid layout code.

Also updated the algorithm that computes the layout. It increases
the value of 1fr based on the grid tracks' usedBreath to fraction
ratio (called normalizedFractionValue). This enables increasing
the fraction value while updating the available space to account
for processed grid tracks. The algorithm stops when we run out of
grid tracks or available space (one grid item has an intrinsic
size too big). This matches the specs to the letter for the known
available space case (both the unknown case and the interaction
with 'span' are left out of this patch).

Tests: fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html

fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html
fast/css-grid-layout/flex-content-resolution-columns.html
fast/css-grid-layout/flex-content-resolution-rows.html

  • GNUmakefile.list.am: Added GridLength.h to the build system.
  • Target.pri: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackBreadth): Replace Length by GridLength.

  • css/CSSGrammar.y.in: Added FR support.
  • css/CSSParser.cpp: Ditto.

(WebCore::CSSParser::parseGridBreadth):
(WebCore::CSSParser::detectNumberToken):

  • css/CSSParserValues.cpp: Added FR support.

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSParserValues.h:

(WebCore::CSSParserString::operator[]):
(WebCore::CSSParserString::equalIgnoringCase):

  • css/CSSPrimitiveValue.cpp: Added FR support.

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):

  • css/CSSPrimitiveValue.h: Added a couple of missing const.

(WebCore::CSSPrimitiveValue::isFlex):

  • css/StyleResolver.cpp: Added FR support.

(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackSize):

  • rendering/RenderGrid.cpp:

(WebCore::GridTrackForNormalization::GridTrackForNormalization):
New helper struct to ease the computation of track breadths with
flexible lengths.
(WebCore::GridTrackForNormalization::operator=):
(WebCore::RenderGrid::computePreferredTrackWidth): Replaced Length by GridLength.
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks): Grow grid lines
having a fraction as the MaxTrackSizingFunction.
(WebCore::RenderGrid::computeUsedBreadthOfMinLength): Replaced Length by GridLength.
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength): Ditto.
(WebCore::sortByGridNormalizedFlexValue):
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Increase
the fraction value while updating the available space to account
for processed grid tracks.
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::distributeSpaceToTracks): Never shrink track sizes.
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):

  • rendering/RenderGrid.h:
  • rendering/style/GridLength.h: Added.

(WebCore::GridLength::GridLength):
(WebCore::GridLength::isLength):
(WebCore::GridLength::isFlex):
(WebCore::GridLength::length):
(WebCore::GridLength::flex):
(WebCore::GridLength::setFlex):
(WebCore::GridLength::operator==):

  • rendering/style/GridTrackSize.h: Replaced Length by GridLength.

(WebCore::GridTrackSize::length):
(WebCore::GridTrackSize::setLength):
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
(WebCore::GridTrackSize::setMinMax):
(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):

LayoutTests:

Added 4 new test cases to test the support for <flex> in CSS Grid
Layout code. Also updated some of the existing ones to check the
support for 'fr' units.

  • fast/css-grid-layout/flex-and-minmax-content-resolution-columns-expected.txt: Added.
  • fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html: Added.
  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt: Added.
  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: Added.
  • fast/css-grid-layout/flex-content-resolution-columns-expected.txt: Added.
  • fast/css-grid-layout/flex-content-resolution-columns.html: Added.
  • fast/css-grid-layout/flex-content-resolution-rows-expected.txt: Added.
  • fast/css-grid-layout/flex-content-resolution-rows.html: Added.
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt:
  • fast/css-grid-layout/grid-dynamic-updates-relayout.html:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
3:33 AM Changeset in webkit [157392] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Broken text rendering when input field has selection.
​https://bugs.webkit.org/show_bug.cgi?id=122716

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-10-14
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/text/text-rendering-with-input-selection.html.

fast/text/text-rendering-with-input-selection-expected.html.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Check that text has selection.

LayoutTests:

  • fast/text/text-rendering-with-input-selection.html: Added.
  • fast/text/text-rendering-with-input-selection-expected.html: Added.
2:43 AM Changeset in webkit [157391] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Unexpected word wrapping for wrapped content then raw content.
​https://bugs.webkit.org/show_bug.cgi?id=121130

Reviewed by Antti Koivisto.

When deciding whether a line is considered empty, we need to check if the current
object is fully responsible for the currently uncommitted width. It helps differentiating
<span></span><span>abcd</span> from <span>a</span><span>bcd</span>, where in the first
case when we hit the second <span> the line is still considered empty, as opposed to the
second example.

Source/WebCore:

Test: fast/css/unexpected-word-wrapping-with-non-empty-spans.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/css/unexpected-word-wrapping-with-non-empty-spans-expected.html: Added.
  • fast/css/unexpected-word-wrapping-with-non-empty-spans.html: Added.
2:16 AM Changeset in webkit [157390] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Be more efficient about passing RenderStyle to attachRenderTree().
<​https://webkit.org/b/122743>

Reviewed by Antti Koivisto.

Have attachRenderTree() and createRendererTreeIfNeeded() pass the
RenderStyle in a PassRefPtr to avoid churning the ref count.

2:00 AM Changeset in webkit [157389] by svillar@igalia.com
  • 6 edits
    2 adds in trunk

[CSS Grid Layout] 2 span positions are not resolved correctly
​https://bugs.webkit.org/show_bug.cgi?id=119717

Reviewed by Andreas Kling.

From Blink r155397 by <​jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-bad-resolution-double-span.html

Two opposite 'span' or 'auto' positions should be resolved using
the auto placement algorithm. We were only checking for the 'auto'
case. This also covers the case of other positions that, according
to the spec, should be treated as 'auto'.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionsFromStyle):

LayoutTests:

Added a new test case to check bad grid items resolution with two
opposite span positions. Also added a real grid container to check
also the resolution code path in some other tests.

  • fast/css-grid-layout/grid-item-area-get-set.html: Added a grid container.
  • fast/css-grid-layout/grid-item-bad-resolution-double-span-expected.txt: Added.
  • fast/css-grid-layout/grid-item-bad-resolution-double-span.html: Added.
  • fast/css-grid-layout/grid-item-end-after-get-set.html: Added a grid container.
  • fast/css-grid-layout/grid-item-start-before-get-set.html: Ditto.
12:58 AM Changeset in webkit [157388] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Use RenderElement instead of RenderObject in more places.
<​https://webkit.org/b/122734>

Reviewed by Antti Koivisto.

Convert some sites to use RenderElement (or type inference) instead
of RenderObject for less branchy code.

Note: See TracTimeline for information about the timeline view.