Timeline



Oct 23, 2013:

11:53 PM Changeset in webkit [157916] by svillar@igalia.com
  • 4 edits
    1 add in trunk

Use a Vector instead of HashSet to computed the orderValues in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=118620

Reviewed by Antti Koivisto.

PerformanceTests:

From Blink r152960 by <ojan@chromium.org>

New performance test for layouts in flexboxes.

  • Layout/flexbox-lots-of-data.html: Added.

Source/WebCore:

Turns out that order is extremelly uncommon so using a Vector is
much less expensive. This also special-cases the much common case
of only having order of value 0 by using Vectors with just one
preallocated member.

Also added the performance test that shows a ~1% win when using a
vector instead of the HashSet.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderIterator::setOrderValues):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):

  • rendering/RenderFlexibleBox.h:
11:43 PM Changeset in webkit [157915] by ChangSeok Oh
  • 6 edits in trunk/Source

Unreviewed build fix since r157823.
FilterOperation::getOperationType() is renamed FilterOperation::type().

Source/WebCore:

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawUsingCustomFilter):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::BitmapTextureGL::applyFilters):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::injectCachedCustomFilterPrograms):

Source/WebKit2:

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):

11:31 PM Changeset in webkit [157914] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Freshly landed webgl-1.0.1 tests are failing.

  • platform/mac/TestExpectations: Mark them as such.
11:25 PM Changeset in webkit [157913] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test plugins/destroy-during-npp-new-object-with-fallback-content.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123250

This is a recent regression.

  • platform/mac/TestExpectations: Marking as such.
11:16 PM Changeset in webkit [157912] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test webaudio/javascriptaudionode-downmix8-2channel-input.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=120148

9:16 PM Changeset in webkit [157911] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on CMake based ports when CMAKE_BUILD_TYPE is not given.

When CMAKE_BUILD_TYPE is empty, FIND command will be failed.

  • CMakeLists.txt:
9:09 PM Changeset in webkit [157910] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Skip tests which are already passed in WebKit1.
https://bugs.webkit.org/show_bug.cgi?id=123200

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-10-23
Reviewed by Gyuyoung Kim.

These tests are passed in wk1 because DRT is supporting setViewModeMediaFeature().
So these are only failed in wk2, but skipped in all cases now.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
8:40 PM Changeset in webkit [157909] by gyuyoung.kim@samsung.com
  • 35 edits in trunk

Integrate css3-images image-orientation with existing EXIF support
https://bugs.webkit.org/show_bug.cgi?id=91566

Reviewed by Beth Dakin.

Source/WebCore:

Original patch by David Barr(davidbarr@chromium.org).

This patch passes an information of image orientation into existing EXIF support functions
(draw() functions of image classes mainly). We need to let the functions to know the information
in order to meet the image-orientation requirement.

Spec: http://dev.w3.org/csswg/css-images-3/#the-image-orientation
The css3-images module specification is at last call.

Test: fast/css/image-orientation/image-orientation.html
Image orientation test is to check if incorrect rotation value can be fixed with correct orientation.

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • page/DragController.cpp:

(WebCore::DragController::doImageDrag):

  • page/Frame.cpp:

(WebCore::Frame::nodeImage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::updateSize):
(WebCore::BitmapImage::sizeRespectingOrientation):
(WebCore::BitmapImage::drawPattern):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::draw):

  • platform/graphics/GradientImage.h:
  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:
  • platform/graphics/blackberry/ImageBlackBerry.cpp:
  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/BitmapImageCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::BufferedImage::draw):

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::BitmapImage::draw):

  • platform/mac/DragImageMac.mm:

(WebCore::createDragImageFromImage):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::draw):

  • svg/graphics/SVGImageForContainer.h:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update export symbols for draw functions.

LayoutTests:

  • fast/css/image-orientation/image-orientation-expected.txt: Fixed wrong description.
  • fast/css/image-orientation/image-orientation.html: Remove a space.
6:41 PM Changeset in webkit [157908] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Tighten typing in SVGInlineTextBox a bit.
<https://webkit.org/b/123238>

Use RenderBoxModelObject& instead of generic RenderObject* in some
places where it happens as a natural consequence of keeping the
original return type from InlineBox::parent()->renderer().

Reviewed by Anders Carlsson.

6:30 PM Changeset in webkit [157907] by gyuyoung.kim@samsung.com
  • 66 edits in trunk/Source/WebCore

Introduce RENDER_OBJECT_TYPE_CASTS to replace manual toFoo() in child render object
https://bugs.webkit.org/show_bug.cgi?id=123150

Reviewed by Andreas Kling.

As a step to let toFoo use TYPE_CASTS_BASE, toRenderFoo() can use it for child render object.
So, this patch introduces RENDER_OBJECT_TYPE_CASTS based on the TYPE_CASTS_BASE. This will
generate plenty more helper functions for render object type cast.

Some unnecessary type casts are fixed by this change.

No new tests, no behavior changes.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderButton.h:
  • rendering/RenderCounter.h:
  • rendering/RenderElement.h:

(WebCore::RenderElement::generatingElement):

  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlowThread.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderFullScreen.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderImage.h:
  • rendering/RenderInline.h:
  • rendering/RenderLayerModelObject.h:
  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderMultiColumnBlock.h:
  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderObject.h:
  • rendering/RenderProgress.h:
  • rendering/RenderQuote.h:
  • rendering/RenderRegion.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderRubyRun.h:
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSearchField.h:
  • rendering/RenderSlider.h:
  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderWidget.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):

  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGViewportContainer.h:
  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):

6:23 PM Changeset in webkit [157906] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

6:21 PM Changeset in webkit [157905] by Lucas Forschler
  • 1 copy in tags/Safari-538.3

New Tag.

6:04 PM Changeset in webkit [157904] by roger_fong@apple.com
  • 2 edits
    1255 adds in trunk/LayoutTests

Forgot to add 1.0.1 conformance tests in r157888.

  • webgl/1.0.1
5:14 PM Changeset in webkit [157903] by andersca@apple.com
  • 1 edit in trunk/Source/WTF/ChangeLog

Tweak ChangeLog.

5:12 PM Changeset in webkit [157902] by Simon Fraser
  • 2 edits
    1 add in trunk/LayoutTests

fast/forms/input-type-text-min-width.html fails on Mavericks.
https://bugs.webkit.org/show_bug.cgi?id=123235

  • platform/mac-mountainlion/TestExpectations: Added.
  • platform/mac/TestExpectations:
5:06 PM Changeset in webkit [157901] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: Make WebKitEFL port work with chromedevtools
https://bugs.webkit.org/show_bug.cgi?id=123017

Patch by Tibor Meszaros <tmeszaros@inf.u-szeged.hu> on 2013-10-23
Reviewed by Gustavo Noronha Silva.

Added /json path and extended the returned JSON format
with the required extra informations

  • UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):

4:50 PM Changeset in webkit [157900] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

Include misspelling dot gap width when centering misspelling dots
https://bugs.webkit.org/show_bug.cgi?id=122365

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-23
Reviewed by Simon Fraser.

Source/WebCore:

When calculating where to place the misspelling dots, we find the
maximum number of full dots that can fit under the misspelled word,
and then center a run of that many dots. However, when we're
centering the run, we are only considering the size of the extra
fractional dot that we cut off. However, the dot image has a "gap"
of transparent pixels (which visually provide tracking for the dots)
which visually appears to be empty space. We should take this gap
space into consideration when centering the run of dots. We also
should make sure that our dots start on integral pixel boundaries
because otherwise we can't set the phase of the dot run properly.

Test: editing/spelling/centering-misspelling-dots.html

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForDocumentMarker):

LayoutTests:

Created a pixel new test where taking this gap width into account when
performing the centering calculation actually changes the location of
where the dots end up. In addition, created a pixel test that misspells
two words next to each other to make sure that the misspelling dots don't
appear under the space between the words.

  • editing/spelling/centering-misspelling-dots-expected.txt: Added.
  • editing/spelling/centering-misspelling-dots.html: Added.
  • platform/mac/editing/spelling/centering-misspelling-dots-expected.png: Added.
  • editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt: Added.
  • editing/spelling/misspelling-dots-dont-extend-beyond-words.html: Added.
  • platform/mac/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.png: Added.
4:23 PM Changeset in webkit [157899] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

SVGFilterBuilder should not be ref-counted.
<https://webkit.org/b/123222>

These objects are singly-owned and do not need ref counting.

Reviewed by Anders Carlsson.

4:01 PM Changeset in webkit [157898] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused IDBBackingStoreLevelDB default constructor.

Rubberstamped by Anders Carlsson.

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
4:01 PM Changeset in webkit [157897] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Remove USE(LOCKFREE_THREADSAFEREFCOUNTED)
https://bugs.webkit.org/show_bug.cgi?id=123228

Reviewed by Geoffrey Garen.

All ports supports USE(LOCKFREE_THREADSAFEREFCOUNTED) now and taking a lock on every ref/deref seems bad.

  • wtf/Atomics.h:
  • wtf/ThreadSafeRefCounted.h:

(WTF::ThreadSafeRefCountedBase::ref):
(WTF::ThreadSafeRefCountedBase::refCount):
(WTF::ThreadSafeRefCountedBase::derefBase):

3:58 PM Changeset in webkit [157896] by ap@apple.com
  • 2 edits in trunk/LayoutTests

ASSERT d->m_defersLoading != defers on detik.com and drive.google.com
https://bugs.webkit.org/show_bug.cgi?id=111902

  • platform/mac/TestExpectations: Remove stale test expectations associated with this

bug, it's been fixed for a long time. Flakiness dashboard concurs.

3:57 PM Changeset in webkit [157895] by alex.christensen@flexsim.com
  • 4 edits in trunk/Source/WebCore

Added Texture Mapper and Coordinated Graphics to Windows build for WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=123215

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Added source files for Texture Mapper to Windows build.

  • WebCore.vcxproj/WebCoreCairo.props:

Added Texture Mapper include directories for WinCairo.

3:50 PM Changeset in webkit [157894] by andersca@apple.com
  • 19 edits in trunk/Source

Remove HAVE_XPC
https://bugs.webkit.org/show_bug.cgi?id=123226

Reviewed by Dan Bernstein.

HAVE_XPC has been true on Mac since Lion, so remove it.

Source/WebKit2:

  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:

(DatabaseServiceInitializer):

  • NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:

(NetworkServiceInitializer):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::Identifier::Identifier):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::platformInitialize):

  • Platform/WorkQueue.h:
  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(PluginServiceInitializer):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
  • UIProcess/Databases/mac/DatabaseProcessProxyMac.mm:

(WebKit::shouldUseXPC):
(WebKit::DatabaseProcessProxy::platformGetLaunchOptions):

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::didFinishLaunchingProcess):

  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::setUpTerminationNotificationHandler):
(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Network/mac/NetworkProcessProxyMac.mm:

(WebKit::shouldUseXPC):
(WebKit::NetworkProcessProxy::platformGetLaunchOptions):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::shouldUseXPC):
(WebKit::PluginProcessProxy::platformGetLaunchOptions):

  • UIProcess/mac/WebProcessProxyMac.mm:

(WebKit::shouldUseXPC):
(WebKit::WebProcessProxy::platformGetLaunchOptions):

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):

Source/WTF:

  • wtf/Platform.h:
3:31 PM Changeset in webkit [157893] by Simon Fraser
  • 356 edits
    355 copies
    121 adds in trunk/LayoutTests

Migrate existing platform/mac layout test results to mac-mountainlion, and add new platform/mac results for Mavericks.

  • platform/mac-mountainlion/accessibility/lists-expected.txt: Copied from LayoutTests/platform/mac/accessibility/lists-expected.txt.
  • platform/mac-mountainlion/canvas/philip/tests/2d.line.join.parallel-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.png.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.png.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.png.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.png.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.png.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.png.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-161-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-23-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-24-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-64-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-68-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/html/css3-modsel-69-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-161-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-161-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-19b-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-19b-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-64-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-64-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.png: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.png.
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt: Copied from LayoutTests/platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt.
  • platform/mac-mountainlion/editing/input/caret-at-the-edge-of-input-expected.txt: Copied from LayoutTests/platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt.
  • platform/mac-mountainlion/editing/inserting/before-after-input-element-expected.png: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.png.
  • platform/mac-mountainlion/editing/inserting/before-after-input-element-expected.txt: Copied from LayoutTests/platform/mac/editing/inserting/before-after-input-element-expected.txt.
  • platform/mac-mountainlion/editing/pasteboard/drop-text-without-selection-expected.png: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.png.
  • platform/mac-mountainlion/editing/pasteboard/drop-text-without-selection-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt.
  • platform/mac-mountainlion/editing/pasteboard/input-field-1-expected.txt: Copied from LayoutTests/platform/mac/editing/pasteboard/input-field-1-expected.txt.
  • platform/mac-mountainlion/editing/selection/3690703-2-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.png.
  • platform/mac-mountainlion/editing/selection/3690703-2-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt.
  • platform/mac-mountainlion/editing/selection/3690703-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.png.
  • platform/mac-mountainlion/editing/selection/3690703-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690703-expected.txt.
  • platform/mac-mountainlion/editing/selection/3690719-expected.png: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.png.
  • platform/mac-mountainlion/editing/selection/3690719-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/3690719-expected.txt.
  • platform/mac-mountainlion/editing/selection/4895428-3-expected.png: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.png.
  • platform/mac-mountainlion/editing/selection/4895428-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4895428-3-expected.txt.
  • platform/mac-mountainlion/editing/selection/4975120-expected.png: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.png.
  • platform/mac-mountainlion/editing/selection/4975120-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/4975120-expected.txt.
  • platform/mac-mountainlion/editing/selection/drag-select-1-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/drag-select-1-expected.txt.
  • platform/mac-mountainlion/editing/selection/replaced-boundaries-3-expected.png: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.png.
  • platform/mac-mountainlion/editing/selection/replaced-boundaries-3-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/replaced-boundaries-3-expected.txt.
  • platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt: Copied from LayoutTests/platform/mac/fast/block/margin-collapse/103-expected.txt.
  • platform/mac-mountainlion/fast/css/continuationCrash-expected.png: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.png.
  • platform/mac-mountainlion/fast/css/continuationCrash-expected.txt: Copied from LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt.
  • platform/mac-mountainlion/fast/css/css2-system-fonts-expected.png: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.png.
  • platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Copied from LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt.
  • platform/mac-mountainlion/fast/css/input-search-padding-expected.png: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.png.
  • platform/mac-mountainlion/fast/css/input-search-padding-expected.txt: Copied from LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt.
  • platform/mac-mountainlion/fast/css/line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/css/line-height-expected.txt.
  • platform/mac-mountainlion/fast/css/text-overflow-input-expected.png: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.png.
  • platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/mac/fast/css/text-overflow-input-expected.txt.
  • platform/mac-mountainlion/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt.
  • platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png.
  • platform/mac-mountainlion/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt.
  • platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png.
  • platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt.
  • platform/mac-mountainlion/fast/dom/isindex-001-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-001-expected.txt.
  • platform/mac-mountainlion/fast/dom/isindex-002-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/isindex-002-expected.txt.
  • platform/mac-mountainlion/fast/dynamic/008-expected.png: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.png.
  • platform/mac-mountainlion/fast/dynamic/008-expected.txt: Copied from LayoutTests/platform/mac/fast/dynamic/008-expected.txt.
  • platform/mac-mountainlion/fast/events/context-no-deselect-expected.txt: Copied from LayoutTests/platform/mac/fast/events/context-no-deselect-expected.txt.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label01-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label02-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.png.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label02-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label03-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.png.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label03-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label04-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.png.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label04-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label05-expected.png: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.png.
  • platform/mac-mountainlion/fast/forms/HTMLOptionElement_label05-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt.
  • platform/mac-mountainlion/fast/forms/basic-inputs-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.png.
  • platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt.
  • platform/mac-mountainlion/fast/forms/basic-selects-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-selects-expected.txt.
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png.
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt.
  • platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.png: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png.
  • platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt.
  • platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt.
  • platform/mac-mountainlion/fast/forms/button-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.png.
  • platform/mac-mountainlion/fast/forms/button-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-align-expected.txt.
  • platform/mac-mountainlion/fast/forms/button-positioned-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.png.
  • platform/mac-mountainlion/fast/forms/button-positioned-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt.
  • platform/mac-mountainlion/fast/forms/button-sizes-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.png.
  • platform/mac-mountainlion/fast/forms/button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-sizes-expected.txt.
  • platform/mac-mountainlion/fast/forms/button-style-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.png.
  • platform/mac-mountainlion/fast/forms/button-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt.
  • platform/mac-mountainlion/fast/forms/button-table-styles-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.png.
  • platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt.
  • platform/mac-mountainlion/fast/forms/button-text-transform-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.png.
  • platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt.
  • platform/mac-mountainlion/fast/forms/button-white-space-expected.png: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.png.
  • platform/mac-mountainlion/fast/forms/button-white-space-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/button-white-space-expected.txt.
  • platform/mac-mountainlion/fast/forms/control-clip-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.png.
  • platform/mac-mountainlion/fast/forms/control-clip-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-expected.txt.
  • platform/mac-mountainlion/fast/forms/control-clip-overflow-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.png.
  • platform/mac-mountainlion/fast/forms/control-clip-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-clip-overflow-expected.txt.
  • platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.png.
  • platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt.
  • platform/mac-mountainlion/fast/forms/encoding-test-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/encoding-test-expected.txt.
  • platform/mac-mountainlion/fast/forms/fieldset-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.png.
  • platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/fieldset-align-expected.txt.
  • platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt.
  • platform/mac-mountainlion/fast/forms/form-element-geometry-expected.png: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.png.
  • platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt.
  • platform/mac-mountainlion/fast/forms/hidden-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/hidden-listbox-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.png.
  • platform/mac-mountainlion/fast/forms/input-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-align-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-bkcolor-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.png.
  • platform/mac-mountainlion/fast/forms/input-appearance-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-bkcolor-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-default-bkcolor-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png.
  • platform/mac-mountainlion/fast/forms/input-appearance-default-bkcolor-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-disabled-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-focus-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.png.
  • platform/mac-mountainlion/fast/forms/input-appearance-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-focus-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-preventDefault-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.png.
  • platform/mac-mountainlion/fast/forms/input-appearance-preventDefault-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-preventDefault-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-readonly-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-selection-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.png.
  • platform/mac-mountainlion/fast/forms/input-appearance-selection-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-selection-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-visibility-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-visibility-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-appearance-width-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.png.
  • platform/mac-mountainlion/fast/forms/input-appearance-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-appearance-width-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-baseline-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-baseline-expected.png.
  • platform/mac-mountainlion/fast/forms/input-button-sizes-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.png.
  • platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-disabled-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.png.
  • platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-double-click-selection-gap-bug-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png.
  • platform/mac-mountainlion/fast/forms/input-double-click-selection-gap-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-field-text-truncated-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.png.
  • platform/mac-mountainlion/fast/forms/input-field-text-truncated-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-field-text-truncated-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-placeholder-visibility-1-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-placeholder-visibility-3-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.png.
  • platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-autoscroll-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.png.
  • platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-dimmed-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-readonly-empty-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-readonly-empty-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-spaces-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-spaces-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-table-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.png.
  • platform/mac-mountainlion/fast/forms/input-table-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-table-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-click-inside-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.png.
  • platform/mac-mountainlion/fast/forms/input-text-click-inside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-inside-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-click-outside-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.png.
  • platform/mac-mountainlion/fast/forms/input-text-click-outside-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-click-outside-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-double-click-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.png.
  • platform/mac-mountainlion/fast/forms/input-text-double-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-double-click-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-drag-down-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.png.
  • platform/mac-mountainlion/fast/forms/input-text-drag-down-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-drag-down-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-option-delete-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-option-delete-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png.
  • platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-self-emptying-click-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-self-emptying-click-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-text-word-wrap-expected.png: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.png.
  • platform/mac-mountainlion/fast/forms/input-text-word-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-text-word-wrap-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-value-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-value-expected.txt.
  • platform/mac-mountainlion/fast/forms/input-width-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/input-width-expected.txt.
  • platform/mac-mountainlion/fast/forms/listbox-bidi-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt.
  • platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.png: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png.
  • platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt.
  • platform/mac-mountainlion/fast/forms/listbox-width-change-expected.png: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.png.
  • platform/mac-mountainlion/fast/forms/listbox-width-change-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/listbox-width-change-expected.txt.
  • platform/mac-mountainlion/fast/forms/menulist-no-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-no-overflow-expected.txt.
  • platform/mac-mountainlion/fast/forms/menulist-option-wrap-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-option-wrap-expected.txt.
  • platform/mac-mountainlion/fast/forms/menulist-restrict-line-height-expected.png: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.png.
  • platform/mac-mountainlion/fast/forms/menulist-restrict-line-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/menulist-restrict-line-height-expected.txt.
  • platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/minWidthPercent-expected.txt.
  • platform/mac-mountainlion/fast/forms/number/number-appearance-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.png.
  • platform/mac-mountainlion/fast/forms/number/number-appearance-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-rtl-expected.txt.
  • platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png.
  • platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt.
  • platform/mac-mountainlion/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt.
  • platform/mac-mountainlion/fast/forms/placeholder-position-expected.png: Copied from LayoutTests/platform/mac/fast/forms/placeholder-position-expected.png.
  • platform/mac-mountainlion/fast/forms/placeholder-pseudo-style-expected.png: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.png.
  • platform/mac-mountainlion/fast/forms/placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt.
  • platform/mac-mountainlion/fast/forms/plaintext-mode-2-expected.png: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.png.
  • platform/mac-mountainlion/fast/forms/plaintext-mode-2-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/plaintext-mode-2-expected.txt.
  • platform/mac-mountainlion/fast/forms/search-cancel-button-style-sharing-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt.
  • platform/mac-mountainlion/fast/forms/search-display-none-cancel-button-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-display-none-cancel-button-expected.txt.
  • platform/mac-mountainlion/fast/forms/search-rtl-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.png.
  • platform/mac-mountainlion/fast/forms/search-rtl-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-rtl-expected.txt.
  • platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.png.
  • platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/search-vertical-alignment-expected.txt.
  • platform/mac-mountainlion/fast/forms/search/search-size-with-decorations-expected.png: Copied from LayoutTests/platform/mac/fast/forms/search/search-size-with-decorations-expected.png.
  • platform/mac-mountainlion/fast/forms/searchfield-heights-expected.png: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.png.
  • platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/searchfield-heights-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.png.
  • platform/mac-mountainlion/fast/forms/select-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-align-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-change-listbox-to-popup-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.png.
  • platform/mac-mountainlion/fast/forms/select-change-listbox-to-popup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-change-popup-to-listbox-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.png.
  • platform/mac-mountainlion/fast/forms/select-change-popup-to-listbox-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-disabled-appearance-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.png.
  • platform/mac-mountainlion/fast/forms/select-disabled-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-disabled-appearance-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-empty-option-height-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-empty-option-height-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-initial-position-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-initial-position-expected.png.
  • platform/mac-mountainlion/fast/forms/select-initial-position-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-initial-position-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
  • platform/mac-mountainlion/fast/forms/select-selected-expected.png: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.png.
  • platform/mac-mountainlion/fast/forms/select-selected-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/select-selected-expected.txt.
  • platform/mac-mountainlion/fast/forms/stuff-on-my-optgroup-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt.
  • platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.png: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.png.
  • platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/tabbing-input-iframe-expected.txt.
  • platform/mac-mountainlion/fast/forms/text-style-color-expected.png: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.png.
  • platform/mac-mountainlion/fast/forms/text-style-color-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/text-style-color-expected.txt.
  • platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.png.
  • platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textAreaLineHeight-expected.txt.
  • platform/mac-mountainlion/fast/forms/textarea-align-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.png.
  • platform/mac-mountainlion/fast/forms/textarea-align-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-align-expected.txt.
  • platform/mac-mountainlion/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt.
  • platform/mac-mountainlion/fast/forms/textarea-scrolled-type-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.png.
  • platform/mac-mountainlion/fast/forms/textarea-scrolled-type-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-scrolled-type-expected.txt.
  • platform/mac-mountainlion/fast/forms/textarea-setinnerhtml-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textarea-setinnerhtml-expected.txt.
  • platform/mac-mountainlion/fast/forms/textfield-focus-ring-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.png.
  • platform/mac-mountainlion/fast/forms/textfield-focus-ring-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-focus-ring-expected.txt.
  • platform/mac-mountainlion/fast/forms/textfield-outline-expected.png: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.png.
  • platform/mac-mountainlion/fast/forms/textfield-outline-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-outline-expected.txt.
  • platform/mac-mountainlion/fast/forms/textfield-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/textfield-overflow-expected.txt.
  • platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.png: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.png.
  • platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/validation-message-appearance-expected.txt.
  • platform/mac-mountainlion/fast/forms/visual-hebrew-text-field-expected.png: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.png.
  • platform/mac-mountainlion/fast/forms/visual-hebrew-text-field-expected.txt: Copied from LayoutTests/platform/mac/fast/forms/visual-hebrew-text-field-expected.txt.
  • platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt: Copied from LayoutTests/platform/mac/fast/frames/take-focus-from-iframe-expected.txt.
  • platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-no-summary4-expected.txt.
  • platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open-javascript-expected.txt.
  • platform/mac-mountainlion/fast/html/details-open2-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open2-expected.txt.
  • platform/mac-mountainlion/fast/html/details-open4-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-open4-expected.txt.
  • platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt.
  • platform/mac-mountainlion/fast/html/details-replace-text-expected.txt: Copied from LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt.
  • platform/mac-mountainlion/fast/lists/dynamic-marker-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/lists/dynamic-marker-crash-expected.txt.
  • platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.png: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.png.
  • platform/mac-mountainlion/fast/overflow/overflow-x-y-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/overflow-x-y-expected.txt.
  • platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt.
  • platform/mac-mountainlion/fast/parser/document-write-option-expected.png: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.png.
  • platform/mac-mountainlion/fast/parser/document-write-option-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/document-write-option-expected.txt.
  • platform/mac-mountainlion/fast/parser/entity-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/entity-comment-in-textarea-expected.txt.
  • platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.png.
  • platform/mac-mountainlion/fast/parser/open-comment-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/parser/open-comment-in-textarea-expected.txt.
  • platform/mac-mountainlion/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt.
  • platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.png: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.png.
  • platform/mac-mountainlion/fast/repaint/subtree-root-skipped-expected.txt: Copied from LayoutTests/platform/mac/fast/repaint/subtree-root-skipped-expected.txt.
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.png.
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt.
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.png: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.png.
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-mixture-expected.txt: Copied from LayoutTests/platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt.
  • platform/mac-mountainlion/fast/selectors/064-expected.png: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.png.
  • platform/mac-mountainlion/fast/selectors/064-expected.txt: Copied from LayoutTests/platform/mac/fast/selectors/064-expected.txt.
  • platform/mac-mountainlion/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt: Copied from LayoutTests/platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt.
  • platform/mac-mountainlion/fast/table/colspanMinWidth-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-expected.txt.
  • platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.png: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.png.
  • platform/mac-mountainlion/fast/table/colspanMinWidth-vertical-expected.txt: Copied from LayoutTests/platform/mac/fast/table/colspanMinWidth-vertical-expected.txt.
  • platform/mac-mountainlion/fast/table/text-field-baseline-expected.txt: Copied from LayoutTests/platform/mac/fast/table/text-field-baseline-expected.txt.
  • platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.png: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png.
  • platform/mac-mountainlion/fast/text/backslash-to-yen-sign-euc-expected.txt: Copied from LayoutTests/platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt.
  • platform/mac-mountainlion/fast/text/drawBidiText-expected.png: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.png.
  • platform/mac-mountainlion/fast/text/drawBidiText-expected.txt: Copied from LayoutTests/platform/mac/fast/text/drawBidiText-expected.txt.
  • platform/mac-mountainlion/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
  • platform/mac-mountainlion/fast/text/international/bold-bengali-expected.txt: Added.
  • platform/mac-mountainlion/fast/text/international/hindi-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt.
  • platform/mac-mountainlion/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png.
  • platform/mac-mountainlion/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt.
  • platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png.
  • platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt.
  • platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.png: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.png.
  • platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt: Copied from LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt.
  • platform/mac-mountainlion/fast/text/updateNewFont-expected.txt: Copied from LayoutTests/platform/mac/fast/text/updateNewFont-expected.txt.
  • platform/mac-mountainlion/fast/transforms/transformed-focused-text-input-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/transformed-focused-text-input-expected.txt.
  • platform/mac-mountainlion/fast/writing-mode/text-orientation-basic-expected.txt: Added.
  • platform/mac-mountainlion/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
  • platform/mac-mountainlion/fonts/cursive-expected.txt: Added.
  • platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.png: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.png.
  • platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt: Copied from LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt.
  • platform/mac-mountainlion/http/tests/xmlhttprequest/head-redirection-expected.txt: Copied from LayoutTests/platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt.
  • platform/mac-mountainlion/media/video-controls-captions-trackmenu-localized-expected.txt: Added.
  • platform/mac-mountainlion/media/video-controls-captions-trackmenu-sorted-expected.txt: Copied from LayoutTests/platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt.
  • platform/mac-mountainlion/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt.
  • platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.png: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.png.
  • platform/mac-mountainlion/platform/mac/fast/text/systemFont-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/systemFont-expected.txt.
  • platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.png: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png.
  • platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt: Copied from LayoutTests/platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt.
  • platform/mac-mountainlion/plugins/mouse-click-plugin-clears-selection-expected.txt: Copied from LayoutTests/platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt.
  • platform/mac-mountainlion/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
  • platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt.
  • platform/mac-mountainlion/svg/custom/use-on-symbol-inside-pattern-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt.
  • platform/mac-mountainlion/svg/hixie/mixed/003-expected.png: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.png.
  • platform/mac-mountainlion/svg/hixie/mixed/003-expected.txt: Copied from LayoutTests/platform/mac/svg/hixie/mixed/003-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug12384-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug12384-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug12384-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug24200-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug26178-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug29326-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug29326-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug30692-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4382-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4382-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug4527-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug55545-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug55545-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug59354-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug68912-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug68912-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug96334-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug96334-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug96334-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug99948-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.png.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug99948-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/bugs/bug99948-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/core/margins-expected.txt.
  • platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.png.
  • platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png.
  • platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt: Copied from LayoutTests/platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt.
  • platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt: Copied from LayoutTests/platform/mac/transforms/2d/zoom-menulist-expected.txt.
  • platform/mac-mountainlion/transforms/3d/general/perspective-non-layer-expected.txt: Copied from LayoutTests/platform/mac/transforms/3d/general/perspective-non-layer-expected.txt.
  • platform/mac-mountainlion/transitions/default-timing-function-expected.txt: Added.
  • platform/mac/accessibility/aria-readonly-expected.txt: Added.
  • platform/mac/accessibility/lists-expected.txt:
  • platform/mac/canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-24-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-64-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-68-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-19b-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-24-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-64-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-64-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-68-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.png:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.png:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.png:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.png:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.png:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.png:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/replaced-boundaries-3-expected.png:
  • platform/mac/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/css/continuationCrash-expected.png:
  • platform/mac/fast/css/continuationCrash-expected.txt:
  • platform/mac/fast/css/css2-system-fonts-expected.png:
  • platform/mac/fast/css/css2-system-fonts-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.png:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.png:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/dynamic/008-expected.png:
  • platform/mac/fast/dynamic/008-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/mac/fast/forms/HTMLOptionElement_label05-expected.png:
  • platform/mac/fast/forms/HTMLOptionElement_label05-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.png:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/basic-selects-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/button-align-expected.png:
  • platform/mac/fast/forms/button-align-expected.txt:
  • platform/mac/fast/forms/button-positioned-expected.png:
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/button-sizes-expected.png:
  • platform/mac/fast/forms/button-sizes-expected.txt:
  • platform/mac/fast/forms/button-style-color-expected.png:
  • platform/mac/fast/forms/button-style-color-expected.txt:
  • platform/mac/fast/forms/button-table-styles-expected.png:
  • platform/mac/fast/forms/button-table-styles-expected.txt:
  • platform/mac/fast/forms/button-text-transform-expected.png:
  • platform/mac/fast/forms/button-text-transform-expected.txt:
  • platform/mac/fast/forms/button-white-space-expected.png:
  • platform/mac/fast/forms/button-white-space-expected.txt:
  • platform/mac/fast/forms/control-clip-expected.png:
  • platform/mac/fast/forms/control-clip-expected.txt:
  • platform/mac/fast/forms/control-clip-overflow-expected.png:
  • platform/mac/fast/forms/control-clip-overflow-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.png:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.png:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.png:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/hidden-listbox-expected.txt:
  • platform/mac/fast/forms/input-align-expected.png:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.png:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.png:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.png:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.png:
  • platform/mac/fast/forms/input-baseline-expected.txt: Added.
  • platform/mac/fast/forms/input-button-sizes-expected.png:
  • platform/mac/fast/forms/input-button-sizes-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.png:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-field-text-truncated-expected.png:
  • platform/mac/fast/forms/input-field-text-truncated-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.png:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.png:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.png:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.png:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.png:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.png:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.png:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-type-text-min-width-actual.png: Added.
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/input-width-expected.txt:
  • platform/mac/fast/forms/listbox-bidi-align-expected.png: Added.
  • platform/mac/fast/forms/listbox-bidi-align-expected.txt:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
  • platform/mac/fast/forms/listbox-width-change-expected.png:
  • platform/mac/fast/forms/listbox-width-change-expected.txt:
  • platform/mac/fast/forms/menulist-no-overflow-expected.txt:
  • platform/mac/fast/forms/menulist-option-wrap-expected.txt:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/mac/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.png:
  • platform/mac/fast/forms/placeholder-position-expected.txt: Added.
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/plaintext-mode-2-expected.png:
  • platform/mac/fast/forms/plaintext-mode-2-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.png:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.png:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/search/search-size-with-decorations-expected.png:
  • platform/mac/fast/forms/search/search-size-with-decorations-expected.txt: Added.
  • platform/mac/fast/forms/searchfield-heights-expected.png:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-align-expected.png:
  • platform/mac/fast/forms/select-align-expected.txt:
  • platform/mac/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/mac/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/mac/fast/forms/select-change-popup-to-listbox-expected.png:
  • platform/mac/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/mac/fast/forms/select-disabled-appearance-expected.png:
  • platform/mac/fast/forms/select-disabled-appearance-expected.txt:
  • platform/mac/fast/forms/select-empty-option-height-expected.txt:
  • platform/mac/fast/forms/select-initial-position-expected.png:
  • platform/mac/fast/forms/select-initial-position-expected.txt:
  • platform/mac/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
  • platform/mac/fast/forms/select-selected-expected.png:
  • platform/mac/fast/forms/select-selected-expected.txt:
  • platform/mac/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.png:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.png:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.png:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textarea-align-expected.png:
  • platform/mac/fast/forms/textarea-align-expected.txt:
  • platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.png:
  • platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.png:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-outline-expected.png:
  • platform/mac/fast/forms/textfield-outline-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.png:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/overflow/overflow-x-y-expected.png:
  • platform/mac/fast/overflow/overflow-x-y-expected.txt:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/mac/fast/parser/document-write-option-expected.png:
  • platform/mac/fast/parser/document-write-option-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.png:
  • platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt: Added.
  • platform/mac/fast/repaint/subtree-root-skipped-expected.png:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.txt: Added.
  • platform/mac/fast/selectors/064-expected.png:
  • platform/mac/fast/selectors/064-expected.txt:
  • platform/mac/fast/spatial-navigation/snav-multiple-select-focusring-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
  • platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/mac/fast/text/drawBidiText-expected.png:
  • platform/mac/fast/text/drawBidiText-expected.txt:
  • platform/mac/fast/text/hyphenate-locale-expected.txt:
  • platform/mac/fast/text/international/cjk-segmentation-expected.txt: Added.
  • platform/mac/fast/text/international/hindi-spacing-expected.txt:
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.png:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/text/updateNewFont-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/mac/http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/http/tests/xmlhttprequest/head-redirection-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
  • platform/mac/media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt: Added.
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
  • platform/mac/platform/mac-wk2/TestExpectations: Added.
  • platform/mac/platform/mac-wk2/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
  • platform/mac/platform/mac-wk2/js/dom/constructor-length-expected.txt: Added.
  • platform/mac/platform/mac-wk2/js/dom/global-constructors-attributes-expected.txt: Added.
  • platform/mac/platform/mac-wk2/webaudio/oscillator-sawtooth-expected.wav: Added.
  • platform/mac/platform/mac/accessibility/form-control-value-settable-expected.txt: Added.
  • platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt: Added.
  • platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Added.
  • platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png: Added.
  • platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Added.
  • platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.png: Added.
  • platform/mac/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Added.
  • platform/mac/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Added.
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.png: Added.
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt: Added.
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Added.
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/platform/mac/fast/loader/file-url-mimetypes-expected.txt: Added.
  • platform/mac/platform/mac/fast/text/systemFont-expected.png:
  • platform/mac/platform/mac/fast/text/systemFont-expected.txt:
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png:
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
  • platform/mac/svg/hixie/mixed/003-expected.png:
  • platform/mac/svg/hixie/mixed/003-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.png:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.png:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.png:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.png:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.png:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.png:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.png:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/mac/tables/mozilla/core/margins-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.png:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/mac/transforms/2d/zoom-menulist-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
  • platform/mac/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png: Added.
3:26 PM Changeset in webkit [157892] by commit-queue@webkit.org
  • 9 edits
    2 copies in trunk

Adding mock class to test RTCDataChannelHandler
https://bugs.webkit.org/show_bug.cgi?id=123205

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-23
Reviewed by Eric Carlson.

Source/WebCore:

Now RTCPeerConnectionHandler-datachannel LayouTest can run properly.
Also updated the expected file, removing the reliable property check (which was removed in the spec)

Existing tests updated.

  • CMakeLists.txt:
  • platform/mediastream/RTCDataChannelHandlerClient.h:
  • platform/mock/RTCDataChannelHandlerMock.cpp: Added.
  • platform/mock/RTCDataChannelHandlerMock.h: Added.
  • platform/mock/RTCNotifiersMock.cpp:

(WebCore::RemoteDataChannelNotifier::RemoteDataChannelNotifier):
(WebCore::RemoteDataChannelNotifier::fire):
(WebCore::DataChannelStateNotifier::DataChannelStateNotifier):
(WebCore::DataChannelStateNotifier::fire):

  • platform/mock/RTCNotifiersMock.h:
  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::createDataChannel):

LayoutTests:

The reliable property was removed in the spec

  • fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
3:18 PM Changeset in webkit [157891] by Lucas Forschler
  • 2 edits in trunk/Tools

Add two more mac bots to the Mavericks Test Queue.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
3:12 PM Changeset in webkit [157890] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Clock should not be ref-counted.
<https://webkit.org/b/123217>

The Clock object is only ever owned by the MediaController,
so remove the ref counting and store it in a std::unique_ptr.

Also slapped the Clock subclasses with FINAL and OVERRIDE.

Reviewed by Anders Carlsson.

2:48 PM Changeset in webkit [157889] by Bem Jones-Bey
  • 3 edits
    20 adds in trunk/LayoutTests

[CSS Shapes] New positioning model: Padding
https://bugs.webkit.org/show_bug.cgi?id=118823

Reviewed by Dirk Schulze.

Tests for floats with shape-outside and padding.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009-expected.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009.html: Added.
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
2:41 PM Changeset in webkit [157888] by roger_fong@apple.com
  • 2 edits
    3759 adds in trunk/LayoutTests

Add 1.0.1 and 1.0.2 WebGL conformance suites to layout tests.
https://bugs.webkit.org/show_bug.cgi?id=123188

Rubberstamped by Dean Jackson.

Skip known 1.0.2 failures and any other unexpected failures for now.

2:15 PM Changeset in webkit [157887] by fpizlo@apple.com
  • 4 edits in trunk

Have a way of dealing with slow tests in run-jsc-stress-tests
https://bugs.webkit.org/show_bug.cgi?id=123221

Tools:

Reviewed by Mark Hahnenberg.

If you add the slow! command to @ then all subsequent plans are prepended to the run list
rather than appended to it. This means that slow tests get queued up first and are less likely
to block completion.

  • Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Mark Hahnenberg.

  • js/regress/script-tests/stepanov_container.js: This test is slow!
2:08 PM BuildingOnMac edited by Simon Fraser
(diff)
2:08 PM Changeset in webkit [157886] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test compositing/regions/floated-region-with-transformed-child.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123220

  • platform/mac/TestExpectations: Marking as such.
2:07 PM BuildingOnMac edited by Simon Fraser
(diff)
2:05 PM Changeset in webkit [157885] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

Fix assertion in DatabaseManager::detailsForNameAndOrigin() to be iOS friendly.
https://bugs.webkit.org/show_bug.cgi?id=123218.

Reviewed by Joseph Pecoraro.

No new tests.

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::detailsForNameAndOrigin):

2:05 PM BuildingOnMac created by Simon Fraser
2:01 PM WikiStart edited by Simon Fraser
(diff)
1:59 PM Changeset in webkit [157884] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Separated USE(CA) from USE(ACCELERATED_COMPOSITING) to prepare WinCairo for accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=123214

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-23
Reviewed by Brent Fulgham.

Source/WebCore:

  • platform/graphics/PlatformLayer.h:

Added TextureMapperPlatformLayer PlatformLayer declaration for WinCairo.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow):
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc):

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:

Added USE(CA) where necessary to compile WinCairo with accelerated compositing.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::delegatedScrollRequested): Added empty function.

  • WebPreferences.cpp:

(WebPreferences::acceleratedCompositingEnabled):
Return true for non-CA ports using accelerated compositing.

  • WebView.cpp:

(WebView::~WebView):
(WebView::sizeChanged):
(WebView::paint):
(WebView::setShouldInvertColors):
(WebView::flushPendingGraphicsLayerChangesSoon):
(WebView::setAcceleratedCompositing):

  • WebView.h:

Added USE(CA) where necessary to compile WinCairo with accelerated compositing.

1:58 PM Changeset in webkit [157883] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Put all uses of LLVM intrinsics behind a single Option
https://bugs.webkit.org/show_bug.cgi?id=123219

Reviewed by Mark Hahnenberg.

  • ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::generateExitThunks):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

  • runtime/Options.h:
1:55 PM Changeset in webkit [157882] by commit-queue@webkit.org
  • 8 edits in trunk/Tools

Explicitly build Win32 or x64 configuration on Windows.
https://bugs.webkit.org/show_bug.cgi?id=123206

Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-23
Reviewed by Brent Fulgham.

  • Scripts/webkitdirs.pm:

(jscPath):
(determineConfigurationForVisualStudio):
(determinePassedConfiguration):
Add |Win32 to the end of 32-bit Visual Studio build configurations.
(safariPath):

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:
  • Scripts/run-api-tests:

(testToolPath):

  • Scripts/run-javascriptcore-tests:

(testapiPath):

  • Scripts/run-regexp-tests:

(testapiPath):

  • Scripts/sunspider-compare-results:

(pathToBuiltJSC):
Use configuration instead of configurationForVisualStudio, which are now always different.

1:51 PM Changeset in webkit [157881] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

Reverted erroneously committed changes from the previous commit.

  • index.html:
1:48 PM Changeset in webkit [157880] by rniwa@webkit.org
  • 3 edits in trunk/Websites/test-results

Clicking on a test name on the new flakiness dashboard should add a new test pane
https://bugs.webkit.org/show_bug.cgi?id=123194

Reviewed by Simon Fraser.

Added a new click handler on each test name inside the builder test view add a new test pane.
Moved the old trac link to a right-arrow inline SVG icon.

Also tweaked the style so that the builder test view looks different from other test panes.

  • index.html:

(TestResultsView._urlFromTest): Extracted from TestResultsView._linkifiedTestName.
(TestResultsView._populateBuilderPane): Fetch the test when its name is clicked.
Added a circled right arrow for the old trac link.

  • main.css: Tweaked the style to move the rounded border around the builder test view to be

around the form controls to clearly differentiate it from a regular test pane.

1:21 PM Changeset in webkit [157879] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix JavaScriptCore build targets following <http://trac.webkit.org/changeset/157864>
(https://bugs.webkit.org/show_bug.cgi?id=123169)

Tell Xcode that the supported platforms for all JavaScriptCore targets are iOS and OS X.

  • Configurations/Base.xcconfig:
1:14 PM Changeset in webkit [157878] by commit-queue@webkit.org
  • 6 edits in trunk

Antialias underlines if they're not axis-aligned
https://bugs.webkit.org/show_bug.cgi?id=123004

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-23
Reviewed by Simon Fraser.

Source/WebCore:

In order to make underlines crisp, GraphicsContext:drawLineForText
modifies the bounds of the underline rect in order to make the rect
device-pixel-aligned, and then turns off antialiasing when drawing
the line. This makes sense when the underline is axis-aligned, but
doesn't when the rect is rotated or skewed. Therefore, we should
only opt-in to this behavior if the underline we're about to draw
is axis-aligned. This requires figuring out whether or not the
current transformation is axis-aligned every time
GraphicsContext::drawLineForText is called, which will incur a small
performance hit. However, this is justified by underlines looking
much better (antialiased) when the context is rotated or skewed.

Tests: svg/custom/foreign-object-skew.html

svg/zoom/page/zoom-foreignObject.html
svg/zoom/text/zoom-foreignObject.html:

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):

LayoutTests:

Updating tests that draw underlines in a non-axis-aligned
GraphicsContext. The expected .png's should show an antialiased
underline. However, underlines which are axis-aligned should still
be unchanged.

  • platform/mac/svg/custom/foreign-object-skew-expected.png:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.png:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.png:
12:13 PM Changeset in webkit [157877] by akling@apple.com
  • 7 edits in trunk/Source

Make more StringImpl construction functions return PassRef.
<https://webkit.org/b/123203>

Knock out a couple more of the StringImpl construction helpers that
always return a non-null StringImpl.

Reviewed by Antti Koivisto.

11:45 AM Changeset in webkit [157876] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove the ifdef to exclude remote layer tree transaction logging
on Lion and before.

Rubber-stamped by Anders Carlsson.

  • Shared/mac/RemoteLayerTreeTransaction.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):

11:42 AM Changeset in webkit [157875] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

LLInt arity check exception processing should start unwinding from caller
https://bugs.webkit.org/show_bug.cgi?id=123209

Reviewed by Oliver Hunt.

Use the caller frame returned from slow_path_call_arityCheck to process exceptions.

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
11:33 AM Changeset in webkit [157874] by mark.lam@apple.com
  • 14 edits
    2 adds in trunk

Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
https://bugs.webkit.org/show_bug.cgi?id=123131.

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: storage/websql/open-database-expand-quota.html

If a webpage tries to create a database that exceeds the database size
quota for that security origin, the WebKit1 quota request mechanism
uses detailsForNameAndOrigin() to get the requested size of the database
(that the webpage is attempting to open) in order to determine whether
to increase the quota or not.

Previously, detailsForNameAndOrigin() relies on the ProposedDatabase
mechanism to provide this size information. This change re-instates the
ProposedDatabase mechanism so that WebKit1 client code that relies on
this behavior will continue to work.

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::ProposedDatabase::ProposedDatabase):
(WebCore::DatabaseManager::ProposedDatabase::~ProposedDatabase):
(WebCore::DatabaseManager::DatabaseManager):
(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):

  • Modules/webdatabase/DatabaseManager.h:

(WebCore::DatabaseManager::ProposedDatabase::origin):
(WebCore::DatabaseManager::ProposedDatabase::details):

Tools:

Updated these files to allow database quotas to grow within a limit for
testing purposes.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(onExceededDatabaseQuota):

  • DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::exceededDatabaseQuota):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didExceedDatabaseQuota):

  • WebKitTestRunner/TestController.cpp:

(WTR::exceededDatabaseQuota):

LayoutTests:

Added a test to exercise growing the database quota within limit.

  • platform/gtk/TestExpectations:
  • storage/websql/open-database-expand-quota-expected.txt: Added.
  • storage/websql/open-database-expand-quota.html: Added.
  • storage/websql/open-database-over-quota-expected.txt:
  • storage/websql/open-database-over-quota.html:
11:27 AM Changeset in webkit [157873] by Simon Fraser
  • 2 edits in trunk/Tools

It's valid to have a build ID of 0.

Reviewed by Tim Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration):

11:22 AM Changeset in webkit [157872] by fpizlo@apple.com
  • 32 edits
    7 adds in trunk/Source

FTL should be able to do some simple inline caches using LLVM patchpoints
https://bugs.webkit.org/show_bug.cgi?id=123164

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This implements GetById inline caches in the FTL using llvm.webkit.patchpoint.

The idea is that we ask LLVM for a nop slide the size of a GetById inline
cache and then fill in the code after LLVM compilation is complete. For now, we
just use the system calling convention for the arguments and return. We also
still make some assumptions about registers that aren't correct. But, most of
the scaffolding is there and this will successfully patch an inline cache.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:
  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::link):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::constNull):
(JSC::FTL::buildCall):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheDescriptor.h: Added.

(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::GetByIdDescriptor::stackmapID):
(JSC::FTL::GetByIdDescriptor::codeOrigin):
(JSC::FTL::GetByIdDescriptor::uid):

  • ftl/FTLInlineCacheSize.cpp: Added.

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):

  • ftl/FTLInlineCacheSize.h: Added.
  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::directGPR):

  • ftl/FTLLocation.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetById):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::call):

  • ftl/FTLSlowPathCall.cpp: Added.

(JSC::FTL::callOperation):

  • ftl/FTLSlowPathCall.h: Added.

(JSC::FTL::SlowPathCall::SlowPathCall):
(JSC::FTL::SlowPathCall::call):
(JSC::FTL::SlowPathCall::key):

  • ftl/FTLSlowPathCallKey.cpp: Added.

(JSC::FTL::SlowPathCallKey::dump):

  • ftl/FTLSlowPathCallKey.h: Added.

(JSC::FTL::SlowPathCallKey::SlowPathCallKey):
(JSC::FTL::SlowPathCallKey::usedRegisters):
(JSC::FTL::SlowPathCallKey::callTarget):
(JSC::FTL::SlowPathCallKey::offset):
(JSC::FTL::SlowPathCallKey::isEmptyValue):
(JSC::FTL::SlowPathCallKey::isDeletedValue):
(JSC::FTL::SlowPathCallKey::operator==):
(JSC::FTL::SlowPathCallKey::hash):
(JSC::FTL::SlowPathCallKeyHash::hash):
(JSC::FTL::SlowPathCallKeyHash::equal):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::directGPR):

  • ftl/FTLStackMaps.h:
  • ftl/FTLState.h:
  • ftl/FTLThunks.cpp:

(JSC::FTL::slowPathCallThunkGenerator):

  • ftl/FTLThunks.h:

(JSC::FTL::Thunks::getSlowPathCallThunk):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

  • jit/GPRInfo.h:
  • jit/JITInlineCacheGenerator.cpp:

(JSC::garbageStubInfo):
(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITByIdGenerator::finalize):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITByIdGenerator::slowPathBegin):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::stackRegisters):
(JSC::RegisterSet::specialRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::allGPRs):
(JSC::RegisterSet::allFPRs):
(JSC::RegisterSet::allRegisters):
(JSC::RegisterSet::dump):

  • jit/RegisterSet.h:

(JSC::RegisterSet::exclude):
(JSC::RegisterSet::numberOfSetRegisters):
(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::isEmptyValue):
(JSC::RegisterSet::isDeletedValue):
(JSC::RegisterSet::operator==):
(JSC::RegisterSet::hash):
(JSC::RegisterSetHash::hash):
(JSC::RegisterSetHash::equal):

  • runtime/Options.h:

Source/WTF:

Reviewed by Mark Hahnenberg.

This needed some better bitvector support, like merging (|=), excluding (&=~),
hashing, and bit counting.

  • wtf/BitVector.cpp:

(WTF::BitVector::setSlow):
(WTF::BitVector::excludeSlow):
(WTF::BitVector::bitCountSlow):
(WTF::BitVector::equalsSlowCase):
(WTF::BitVector::hashSlowCase):
(WTF::BitVector::dump):

  • wtf/BitVector.h:

(WTF::BitVector::merge):
(WTF::BitVector::exclude):
(WTF::BitVector::bitCount):
(WTF::BitVector::BitVector):
(WTF::BitVector::isEmptyValue):
(WTF::BitVector::isDeletedValue):
(WTF::BitVector::isEmptyOrDeletedValue):
(WTF::BitVector::operator==):
(WTF::BitVector::hash):
(WTF::BitVectorHash::hash):
(WTF::BitVectorHash::equal):

  • wtf/HashTraits.h:

(WTF::CustomHashTraits::constructDeletedValue):
(WTF::CustomHashTraits::isDeletedValue):
(WTF::CustomHashTraits::emptyValue):
(WTF::CustomHashTraits::isEmptyValue):

  • wtf/StdLibExtras.h:

(WTF::bitCount):

11:21 AM Changeset in webkit [157871] by Simon Fraser
  • 2 edits in trunk/Tools

Remove Lion bots from the Dashboard.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

11:14 AM Changeset in webkit [157870] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

[cg] Fix the capitalization of kCGImageSourceSkipMetaData (-> Metadata)
https://bugs.webkit.org/show_bug.cgi?id=122918

Reviewed by Anders Carlsson.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::imageSourceOptions):
The capitalization of kCGImageSourceSkipMetaData changed to
kCGImageSourceSkipMetadata in Mountain Lion.

11:13 AM Changeset in webkit [157869] by beidson@apple.com
  • 21 edits
    2 moves in trunk/Source

Make IDBDatabaseBackendLevelDB.cpp be cross platform
https://bugs.webkit.org/show_bug.cgi?id=123027

Attentively reviewed by Dean Jackson.

Source/WebCore:

Move it out of the indexeddb/leveldb directory, and rename it to IDBDatabaseBackendImpl.

Project files:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp.
  • Modules/indexeddb/IDBDatabaseBackendImpl.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h.
  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(WebCore::IDBDatabaseBackendInterface::isIDBDatabaseBackendImpl): Add to support a required cast in LevelDB code.

  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::open):
(WebCore::IDBFactoryBackendLevelDB::maybeCreateTransactionBackend):

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
  • Modules/indexeddb/leveldb/IDBLevelDBCoding.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:

(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::scheduleVersionChangeOperation):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:

(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
10:55 AM Changeset in webkit [157868] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

jitCompileAndSetHeuristics should DeferGCForAWhile
https://bugs.webkit.org/show_bug.cgi?id=123196

Reviewed by Mark Hahnenberg.

This fixes random crashes in V8v7/raytrace. I only see those crashes on exactly one of
my machines. I don't think this is testable; we just need to steadily converge towards
getting our uses of DeferGC to be right and then be careful not to regress. We're not
there yet, obviously.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):

10:50 AM Changeset in webkit [157867] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Fixed a typo.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didChangeBackForwardList):

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:
10:47 AM Changeset in webkit [157866] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py

wkbuild.py fix after r157827.

10:42 AM Changeset in webkit [157865] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WTF

Clean-up in Atomics.h
https://bugs.webkit.org/show_bug.cgi?id=123207

Reviewed by Anders Carlsson.

Atomics.h has two confusing and bit-rotted ifdefs with comments.

The first about CPU(SPARC64) was rendered obsolete when we switched
from exchange_and_add to sync_add_and_fetch.

The second was caused by a wrong definition that apparently only
caused trouble on GCC.

  • wtf/Atomics.h:
10:02 AM Changeset in webkit [157864] by dbates@webkit.org
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

[iOS] Upstream more JavaScriptCore build configuration changes
https://bugs.webkit.org/show_bug.cgi?id=123169

Reviewed by David Kilzer.

  • Configurations/Base.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/iOS.xcconfig: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
9:58 AM Changeset in webkit [157863] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[iOS] Export DefaultGCActivityCallback member functions
https://bugs.webkit.org/show_bug.cgi?id=123175

Reviewed by David Kilzer.

  • runtime/GCActivityCallback.h:
9:56 AM Changeset in webkit [157862] by dbates@webkit.org
  • 4 edits in trunk/Source

[iOS] Upstream more ARMv7s bits
https://bugs.webkit.org/show_bug.cgi?id=123052

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:

Source/WebCore:

Define exported symbol file for armv7s and arm64.

  • Configurations/WebCore.xcconfig:
9:49 AM Changeset in webkit [157861] by mario@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Enable respect image orientation by default
https://bugs.webkit.org/show_bug.cgi?id=122120

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-23
Reviewed by Gustavo Noronha Silva.

Add enable respect image orientation by default in GTK port.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed):

9:38 AM Changeset in webkit [157860] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[CSS Regions] compositing/regions/region-as-layer-in-another-flowthread.html has image failure
https://bugs.webkit.org/show_bug.cgi?id=123193

Patch by Mihai Maerean <Mihai Maerean> on 2013-10-23
Reviewed by Simon Fraser.

Removed overlapping of box-shadows which resulted in flaky results.

  • compositing/regions/region-as-layer-in-another-flowthread-expected.html:
  • compositing/regions/region-as-layer-in-another-flowthread.html:
  • platform/mac/TestExpectations:
9:23 AM Changeset in webkit [157859] by mario@webkit.org
  • 10 edits in trunk

[GTK] Expose image links properly
https://bugs.webkit.org/show_bug.cgi?id=84044

Reviewed by Chris Fleizach.

Tools:

Expose the accessible URL if present, as yet another attribute
for the AccessibilityUIElement wrapper. For coherence with what
the Mac port does (and what you would expect as the output of
the layout test), we strip the absolute URL path for relative
references, if it's the case, leaving the base of the URL path
out of the exposed string.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(attributesOfElement): Print the AXURL, if available.
(AccessibilityUIElement::url): Expose the URL if present. That
is, if the wrapped AtkObject implements AtkHyperlinkImpl.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(attributesOfElement): Print the AXURL, if available.
(WTR::AccessibilityUIElement::url): Expose the URL if present.
That is, if the wrapped AtkObject implements AtkHyperlinkImpl.

LayoutTests:

Rebaseline some tests that would now be printing the new
AXURL string for implementations of AtkHyperlinkImpl.

  • platform/efl-wk1/accessibility/image-link-expected.txt: Updated.
  • platform/efl-wk1/accessibility/image-map2-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/image-link-expected.txt: Ditto.
  • platform/efl-wk2/accessibility/image-map2-expected.txt: Ditto.
  • platform/gtk/accessibility/image-link-expected.txt: Ditto.
  • platform/gtk/accessibility/image-map2-expected.txt: Ditto.
9:16 AM Changeset in webkit [157858] by Simon Fraser
  • 2 edits in trunk/Tools

Remove Lion bots.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:13 AM Changeset in webkit [157857] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] accessibility/self-referencing-aria-labelledby.html is failing
https://bugs.webkit.org/show_bug.cgi?id=121594

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-23
Reviewed by Mario Sanchez Prada.

Source/WebCore:

According to http://www.w3.org/TR/REC-html40/struct/objects.html#edef-IMG
description of image element should be determined by alt attribute, then
if it is empty by title attributte.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetDescription):

LayoutTests:

  • platform/efl/TestExpectations:

accessibility/self-referencing-aria-labelledby.html is now passing

  • platform/gtk/TestExpectations:

accessibility/self-referencing-aria-labelledby.html is now passing

3:55 AM Changeset in webkit [157856] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Tighten animation-driven restyle to operate on Element only.
<https://webkit.org/b/122820>

Text nodes are never directly animated, so we can tighten this code
to work on Element only. This happens naturally since the code was
already working with RenderElement everywhere.

Reviewed by Antti Koivisto.

3:48 AM Changeset in webkit [157855] by akling@apple.com
  • 5 edits in trunk/Source

StringImpl::lower() should return a PassRef.
<https://webkit.org/b/123190>

Test the waters and hack enough of StringImpl to be able to return
a PassRef<StringImpl> from lower().

Also gave String a constructor that takes a PassRef<StringImpl>.

Reviewed by Antti Koivisto.

3:42 AM Changeset in webkit [157854] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

Even more PassRef<RenderStyle>!
<https://webkit.org/b/123147>

Convert more of the WebCore code to use PassRef for RenderStyle
in places where they are known to be non-null.

Re-landing this without region styling since that caused some
assertions last time.

Reviewed by Antti Koivisto.

2:17 AM Changeset in webkit [157853] by mario@webkit.org
  • 5 edits in trunk/Source/WebKit2

[GTK] Add WebKit2 API for TLS errors
https://bugs.webkit.org/show_bug.cgi?id=120160

Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-23
Reviewed by Mario Sanchez Prada.

Revert back to using PlatformCertificateInfo following the rollout
of https://bugs.webkit.org/show_bug.cgi?id=118520.

  • Shared/soup/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):

  • Shared/soup/PlatformCertificateInfo.h:
  • UIProcess/API/gtk/WebKitCertificateInfo.cpp:

(webkitCertificateInfoGetCertificateInfo):

  • UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
1:24 AM Changeset in webkit [157852] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Remote Layer Tree: Implement superlayer, removeFromSuperlayer, replaceSublayer, and adoptSublayers
https://bugs.webkit.org/show_bug.cgi?id=123130

Reviewed by Anders Carlsson.

Implement the remaining layer-hierarchy-manipulation methods.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::PlatformCALayerRemote):
(PlatformCALayerRemote::~PlatformCALayerRemote):
Null out the superlayer back-pointer on our sublayers.

(PlatformCALayerRemote::recursiveBuildTransaction):
Ensure that our children all have us as their superlayer.

(PlatformCALayerRemote::superlayer):
Return the stored superlayer pointer.

(PlatformCALayerRemote::removeFromSuperlayer):
Call removeSublayer on our superlayer, if we have one.

(PlatformCALayerRemote::removeSublayer):
Remove the given layer if it's in our list of sublayers, clear its
reference to us, and note that we'll need to commit hierarchy changes.

(PlatformCALayerRemote::setSublayers):
removeAllSublayers() before setting the new list, to clear superlayer
back-pointers. Children will be protected by the PlatformCALayerList.
Update the new layers' superlayers.

(PlatformCALayerRemote::removeAllSublayers):
Remove each sublayer from its superlayer, then clear our list of children.

(PlatformCALayerRemote::appendSublayer):
(PlatformCALayerRemote::insertSublayer):
Protect the layer from deletion, so that we can remove it from its prior
superlayer before appending or inserting it.

(PlatformCALayerRemote::replaceSublayer):
Find the reference sublayer, if it exists, and replace it with the new one.

(PlatformCALayerRemote::adoptSublayers):
adoptSublayers is really just "set sublayers to this other layer's sublayers".
Since setSublayers already removes layers from the existing superlayer,
we can just go ahead and call it.

(PlatformCALayerRemote::addAnimationForKey):
(PlatformCALayerRemote::removeAnimationForKey):
(PlatformCALayerRemote::animationForKey):
Add some ASSERT_NOT_REACHEDs in animation code.
We ought not get here because we've disabled hardware animations
in GraphicsLayerCARemote.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Add m_superlayer and removeSublayer().

Oct 22, 2013:

11:50 PM Changeset in webkit [157851] by zoltan@webkit.org
  • 6 edits in trunk

Refactor LineBreaker::nextSegmentBreak, add BreakingContext that holds all its state
https://bugs.webkit.org/show_bug.cgi?id=123038

Reviewed by David Hyatt.

Source/WebCore:

I followed Levi's logic on Blink's nextSegmentBreak refactoring (https://chromiumcodereview.appspot.com/25054004).
I mostly did the same changes, but the code is too diverged at this point to just apply that patch on our trunk. The patch
introduces BreakingContext as a separate class. I added new methods for each condition, which were originally located in
nextSegmentBreak. I also removed the goto-s from the code. All the new methods are inline in order to avoid introducing any
performance regression. The change makes the code so much cleaner and understandable.

This change would be the first step of the nextSegmentBreak refactoring, I wanted to keep things in place in RenderBlockLineLayout.cpp
for now, but I'm planning to separate BreakingContext into a new file and do additional changes to make things nicer. I'm tracking
the entire progress under http://webkit.org/b/121261 meta bug.

No new tests, covered by existing tests.

  • I updated 1 expected result, because there was a 1 pixel difference on the result, which I believe comes from a rounding situation.
  • rendering/RenderBlockFlow.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::lineBreak):
(WebCore::BreakingContext::lineBreakRef):
(WebCore::BreakingContext::lineWidth):
(WebCore::BreakingContext::atEnd):
(WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::increment):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::nextCharacter):
(WebCore::BreakingContext::handleText):
(WebCore::textBeginsWithBreakablePosition):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::BreakingContext::handleEndOfLine):
(WebCore::LineBreaker::nextSegmentBreak):

LayoutTests:

  • platform/mac/editing/selection/after-line-wrap-expected.png:
  • platform/mac/editing/selection/after-line-wrap-expected.txt: I updated the test, there was 1 pixel difference on the

output I think I run into a rounding error.

11:03 PM Changeset in webkit [157850] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

Unreviewed build fix attempt on Soup based port after r157842.

WebCore::CertificateInfo was reverted to WebKit::PlatformCertificateInfo.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):

9:42 PM Changeset in webkit [157849] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix attempt on EFL port after r157842.

  • Shared/soup/PlatformCertificateInfo.h: Removed message of merge confliction.
9:16 PM Changeset in webkit [157848] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

Unreviewed, rolling out r157826.
http://trac.webkit.org/changeset/157826
https://bugs.webkit.org/show_bug.cgi?id=123197

Caused some regions tests to assert (Requested by smfr on
#webkit).

  • dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::styleForRenderer):

  • dom/Element.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::setComputedStyle):
(WebCore::ElementRareData::resetComputedStyle):

  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::textWithDirection):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::animate):

  • page/animation/CompositeAnimation.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

  • rendering/RenderElement.h:

(WebCore::RenderElement::setStyleInternal):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
(WebCore::RenderRegion::setObjectStyleInRegion):

  • rendering/RenderRegion.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveLocal):

9:09 PM Changeset in webkit [157847] by ryuan.choi@samsung.com
  • 4 edits in trunk

[EFL] Remove HAVE_GLX macro
https://bugs.webkit.org/show_bug.cgi?id=123191

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/OptionsEfl.cmake: Removed unnecessary HAVE_GLX macro

Source/WebCore:

Since r138313, HAVE(GLX) was replaced to USE(GLX) except in GraphicsSurfaceToken.h.

  • platform/graphics/surfaces/GraphicsSurfaceToken.h:

Replace HAVE(GLX) to USE(GLX)

9:04 PM Changeset in webkit [157846] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build failures after r157842.

  • WebProcess/WebProcess.h: Don't try to #include a file that was deleted.

It won't work.

8:39 PM Changeset in webkit [157845] by mark.lam@apple.com
  • 3 edits in trunk/Source/WebCore

Gardening: fix broken build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=123174.

Not reviewed.

No new tests.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
8:23 PM Changeset in webkit [157844] by beidson@apple.com
  • 18 edits
    2 adds
    2 deletes in trunk/Source

Get rid of IDBObjectStoreBackendLevelDB
https://bugs.webkit.org/show_bug.cgi?id=123174

Reviewed by Tim Horton.

Source/WebCore:

This file was kind of a dumping ground.
Its contents can be merged into IDBBackingStoreInterface and a new IDBIndexWriter class.

Also took the opportunity to do a little bit of RefPtr<> and pointer-vs-reference cleanup.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Removed.
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Removed.
  • Modules/indexeddb/IDBIndexWriter.cpp: Added.

(WebCore::IDBIndexWriter::IDBIndexWriter):
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):

  • Modules/indexeddb/IDBIndexWriter.h: Added.

(WebCore::IDBIndexWriter::create):

  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBDatabaseBackendInterface.h:
  • Modules/indexeddb/IDBMetadata.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
(WebCore::IDBBackingStoreLevelDB::generateKey):
(WebCore::IDBBackingStoreLevelDB::updateKeyGenerator):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::setIndexesReady):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:

(WebCore::IDBTransactionBackendLevelDB::schedulePutOperation):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:

(WebCore::PutOperation::perform):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:

(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
6:52 PM Changeset in webkit [157843] by dino@apple.com
  • 19 edits in trunk/Source

[WebGL] Implement a software rendering option on Mac
https://bugs.webkit.org/show_bug.cgi?id=123177

Reviewed by Tim Horton.

Implement a way to force software OpenGL rendering
for WebGL, via a Setting/Preference.

Source/WebCore:

No new tests. We intentionally hide the capabilities of
the renderer from the content, so you can't test for
this setting. However, manual inspection is pretty
obvious. Just go to a page with a complex shader
such as https://www.shadertoy.com/view/lss3WS.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create): If we're forcing software
rendering, mark the context attributes as such.

  • page/Settings.in: New setting key.
  • platform/graphics/GraphicsContext3D.h: New flag in Attributes.

(WebCore::GraphicsContext3D::Attributes::Attributes):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D): Slight update to the
algorithm that sets a pixel format. If we're forcing software rendering,
obviously we never want to create an accelerated pixel format.

  • platform/graphics/filters/CustomFilterGlobalContext.cpp:

(WebCore::CustomFilterGlobalContext::prepareContextIfNeeded): Set the attribute
here before trying to create the context.

  • platform/graphics/filters/CustomFilterGlobalContext.h: Add a forceSoftwareRendering

flag to prepareContextIfNeeded.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::createCustomFilterEffect): Check the Setting before creating a custom
filter context.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h: New WebKitForceSoftwareWebGLRendering key.
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences forceSoftwareWebGLRendering]):
(-[WebPreferences setForceSoftwareWebGLRendering:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • Shared/WebPreferencesStore.h: New ForceSoftwareWebGLRendering entry.
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetForceSoftwareWebGLRendering):
(WKPreferencesGetForceSoftwareWebGLRendering):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • mac/WebKit2.order:
6:15 PM Changeset in webkit [157842] by andersca@apple.com
  • 50 edits
    3 moves
    1 add
    1 delete in trunk/Source

Revert r157445 since it broke certificates on Mac.
<rdar://problem/15246926&15254017&15269117>

Source/WebCore:

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/ResourceErrorBase.h:
  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/CertificateInfoCFNet.cpp: Removed.
  • platform/network/cf/ResourceResponse.h:
  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::setCertificateChain):
(WebCore::ResourceResponse::certificateChain):

  • platform/network/soup/ResourceError.h:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::tlsErrors):
(WebCore::ResourceError::setTLSErrors):
(WebCore::ResourceError::certificate):
(WebCore::ResourceError::setCertificate):

  • platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::ResourceError::tlsError):
(WebCore::ResourceError::platformCopy):
(WebCore::ResourceError::platformCompare):

  • platform/network/soup/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::soupMessageCertificate):
(WebCore::ResourceResponse::setSoupMessageCertificate):
(WebCore::ResourceResponse::soupMessageTLSErrors):
(WebCore::ResourceResponse::setSoupMessageTLSErrors):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::toSoupMessage):
(WebCore::ResourceResponse::updateFromSoupMessage):

Source/WebKit2:

  • GNUmakefile.list.am:
  • NetworkProcess/AsynchronousNetworkLoaderClient.cpp:

(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):

  • Shared/Authentication/AuthenticationManager.h:
  • Shared/Authentication/AuthenticationManager.messages.in:
  • Shared/Authentication/mac/AuthenticationManager.mac.mm:

(WebKit::AuthenticationManager::tryUsePlatformCertificateInfoForChallenge):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebCertificateInfo.h:

(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::platformCertificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):

  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/PlatformCertificateInfo.h: Renamed from Source/WebCore/platform/network/soup/CertificateInfoSoup.cpp.

(WebKit::PlatformCertificateInfo::certificateChain):

  • Shared/mac/PlatformCertificateInfo.mm: Renamed from Source/WebCore/platform/network/mac/CertificateInfoMac.mm.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):
(WebKit::PlatformCertificateInfo::dump):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • Shared/soup/PlatformCertificateInfo.cpp: Added.

(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::~PlatformCertificateInfo):
(WebKit::PlatformCertificateInfo::encode):
(WebKit::PlatformCertificateInfo::decode):

  • Shared/soup/PlatformCertificateInfo.h: Renamed from Source/WebCore/platform/network/CertificateInfo.h.

(WebKit::PlatformCertificateInfo::certificate):
(WebKit::PlatformCertificateInfo::tlsErrors):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_get_tls_info):

  • UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::useCredential):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

6:03 PM Changeset in webkit [157841] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Mark compositing/regions/region-as-layer-in-another-flowthread.html as an image failure.

  • platform/mac/TestExpectations:
5:55 PM Changeset in webkit [157840] by Simon Fraser
  • 2 edits in trunk/Tools

Dashboard repaints constantly
https://bugs.webkit.org/show_bug.cgi?id=122133

Reviewed by Tim Horton.

Pulsing shadows are really bad for battery life.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:

(.status-line.bad .bubble):
(.status-line.bad .message):

5:48 PM Changeset in webkit [157839] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r157835.
http://trac.webkit.org/changeset/157835
https://bugs.webkit.org/show_bug.cgi?id=123192

broke 32-bit builds (Requested by smfr on #webkit).

Source/WTF:

  • wtf/MediaTime.cpp:

(WTF::signum):

  • wtf/MediaTime.h:

Tools:

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

5:44 PM Changeset in webkit [157838] by rniwa@webkit.org
  • 3 edits in trunk/Websites/test-results

New flakiness dashboard's test pane should show the latest WebKit revision for each builder
https://bugs.webkit.org/show_bug.cgi?id=123189

Reviewed by Simon Fraser.

  • index.html:

(TestResultsView._populateTestPane): Call _createTestResultHeader and _createTestResultRow with
a list of repository information.
(TestResultsView._createTestResultHeader): Optionally creates headers for a list of repositories.
(TestResultsView._createTestResultRow): Add a hyperlinked revision information for each builder.
Also add a hyperlink to file a Bugzilla bug when there is no bug associated with the test already.

  • js/build.js:

(Build.formattedRevision): Extracted from Build.formattedRevisions.
(Build.formattedRevisions):

5:39 PM Changeset in webkit [157837] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Remote Layer Tree: Disable threaded scrolling for RemoteLayerTreeDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=123187

Reviewed by Dean Jackson.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::supportsThreadedScrolling):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

Threaded scrolling doesn't work with remote layer trees yet.
Let the DrawingArea subclass tell WebPage if it supports threaded
scrolling, and make TiledCoreAnimationDrawingArea say that it does.

5:26 PM Changeset in webkit [157836] by akling@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Minor VM* -> VM& cleanups in HashTable and Keywords.
<https://webkit.org/b/123183>

Turn some VM* variables that will never be null into VM&.

Reviewed by Geoffrey Garen.

5:18 PM Changeset in webkit [157835] by jer.noble@apple.com
  • 5 edits in trunk

[WTF] Add a multiplication operator (and a few others) to MediaTime
https://bugs.webkit.org/show_bug.cgi?id=123137

Reviewed by Eric Carlson.

Source/WTF:

Add a multiplication operator and an inequality operator to the
MediaTime class for use by MSE.

  • wtf/MediaTime.cpp:

(WTF::signum): Moved to top of file.
(WTF::MediaTime::operator*): Added.
(WTF::MediaTime::operator!=): Added.

  • wtf/MediaTime.h:

(WTF::operator*): Added non-class version of operator*.

Tools:

Add tests for new MediaTime operators.

  • TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

5:14 PM Changeset in webkit [157834] by jer.noble@apple.com
  • 16 edits in trunk/Source/WebCore

[Media] Refactor supportsType() factory method to take a parameters object.
https://bugs.webkit.org/show_bug.cgi?id=122489

Reviewed by Eric Carlson.

In order to support adding new conditional properties with which to decide
what MediaPlayerPrivate subclass to create, replace the two versions of the
supportsType() factory method with a single one taking a parameters object.

At the same time, add a 'isMediaSource' parameter to that object, allowing
MediaPlayerPrivate subclasses which support the same type and codecs but
which do not both support MediaSource to be distinguised.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::bestMediaEngineForSupportParameters): Renamed from

bestMediaEngineForTypeAndCodecs.

(WebCore::MediaPlayer::nextBestMediaEngine): Added convenience function.
(WebCore::MediaPlayer::loadWithNextMediaEngine): Call nextBestMediaEngine()
(WebCore::MediaPlayer::supportsType): Pass parameter object.
(WebCore::MediaPlayer::networkStateChanged): Call nextBestMediaEngine().

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::supportsType): Handle parameter object.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine): Remove extraneous

extendedSupportsType method.

(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Handle parameter object.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::supportsType): Ditto.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Remove extraneous

extendedSupportsType method.

(WebCore::MediaPlayerPrivateQTKit::supportsType): Handle parameter object.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::supportsType): Ditto.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:
5:12 PM Changeset in webkit [157833] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Merge SVGRenderBlock::styleWillChange() into styleDidChange().
<https://webkit.org/b/123181>

I meant to do this one in r157787, but better late than never.

Reviewed by Geoffrey Garen.

5:08 PM Changeset in webkit [157832] by rniwa@webkit.org
  • 3 edits in trunk/Websites/test-results

Make tables on the new flakiness dashboard sortable
https://bugs.webkit.org/show_bug.cgi?id=123141

Reviewed by Simon Fraser.

Use jquery.tablesorter.js to make test and builder tables sortable. The jquery plugin is already used by run-perf-tests.

  • index.html:

(TestResultsView._populateTestPane): Add tablesorter to the class name and wrap tr's inside a tbody so that tablesorter
could sort them.
(TestResultsView._populateBuilderPane): Ditto.

  • main.css:

(.resultsTable thead): Use cursor: pointer to signify the fact it's clickable.
(.resultsTable th): Don't repeat arrows.
(.resultsTable th.headerSortUp): Inline SVG up arrow.
(.resultsTable th.headerSortDown): Inline SVG down arrow.

5:05 PM Changeset in webkit [157831] by Simon Fraser
  • 8 edits in trunk/Tools

Educate webkitpy about Mavericks.

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._determine_mac_version):

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_os_version):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser):

  • Scripts/webkitpy/port/builders.py:
  • Scripts/webkitpy/port/mac.py:

(MacPort):

  • Scripts/webkitpy/port/mac_unittest.py:

(test_versions):
(test_baseline_search_path):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):
(TestRebaselineExpectations.test_rebaseline_expectations):

5:00 PM Changeset in webkit [157830] by ggaren@apple.com
  • 6 edits in trunk

REGRESSION: if (false === (true && undefined)) console.log("wrong!"); logs "wrong!", shouldn't!
https://bugs.webkit.org/show_bug.cgi?id=123179

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • parser/NodeConstructors.h:

(JSC::LogicalOpNode::LogicalOpNode):

  • parser/ResultType.h:

(JSC::ResultType::forLogicalOp): Don't assume that && produces a boolean.
This is JavaScript (aka Sparta).

LayoutTests:

  • js/dom/branch-fold-correctness.html: Added a test for this case.
4:59 PM Changeset in webkit [157829] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix on EFL port after r157823

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode): renamed getOperationType() to type().

4:59 PM Changeset in webkit [157828] by weinig@apple.com
  • 19 edits in trunk/Source/WebCore

CTTE: Modernize RenderBlock a bit
https://bugs.webkit.org/show_bug.cgi?id=123162

Reviewed by Andreas Kling.

Start threading references through RenderBlock. While we
are here, do some selective modernization as well.

4:55 PM Changeset in webkit [157827] by Stephanie Lewis
  • 2 edits in trunk/Tools

Update the build trigger list for Mavericks.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

4:32 PM Changeset in webkit [157826] by akling@apple.com
  • 15 edits in trunk/Source/WebCore

Even more PassRef<RenderStyle>!
<https://webkit.org/b/123147>

Convert the remaining WebCore code to use PassRef for RenderStyle
wherever they are known to be non-null.

Reviewed by Antti Koivisto.

3:58 PM Changeset in webkit [157825] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r157819.
http://trac.webkit.org/changeset/157819
https://bugs.webkit.org/show_bug.cgi?id=123180

Broke 32-bit builds (Requested by smfr on #webkit).

Source/JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/ToolExecutable.xcconfig:

Source/WebCore:

  • Configurations/WebCore.xcconfig:
3:37 PM Changeset in webkit [157824] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Rename deleteLineBoxTree to deleteLines
https://bugs.webkit.org/show_bug.cgi?id=123176

Reviewed by Andreas Kling.

RenderBlock::deleteLineBoxTree -> RenderBlock::deleteLines
RenderInline::deleteLineBoxTree -> RenderInline::deleteLines

3:33 PM Changeset in webkit [157823] by timothy_horton@apple.com
  • 28 edits in trunk/Source

{ClipPathOperation, FilterOperation}::getOperationType() should not include 'get'
https://bugs.webkit.org/show_bug.cgi?id=123172

Reviewed by Simon Fraser.

No new tests, just a rename.

"get" in WebCore tends to mean that the function has out arguments; these have no arguments.
Rename FilterOperation::getOperationType() to FilterOperation::type().
I noticed that ClipPathOperation had the same mistake, so I fixed it there too.

Removed long and useless list of WebCore files.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::encodeFilterOperation):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):
Adopt the new name.

3:32 PM Changeset in webkit [157822] by Simon Fraser
  • 2 edits in trunk/Tools

Add Mavericks bots to the dashboard.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

3:30 PM Changeset in webkit [157821] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

AX: Add paramAttrs to fetch start and end text markers in a given rect.
https://bugs.webkit.org/show_bug.cgi?id=122164

Patch by Samuel White <Samuel White> on 2013-10-22
Reviewed by Chris Fleizach.

Source/WebCore:

Added ability to fetch end and start text markers inside a given bounds. This gives ScreenReaders
like VoiceOver a way to retrieve the text markers for a specified column of page text.

Test: platform/mac/accessibility/text-marker-for-bounds.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::mainFrame):
(WebCore::AccessibilityObject::topDocument):
(WebCore::AccessibilityObject::visiblePositionForBounds):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper screenToContents:]):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(endTextMarkerForBoundsCallback):
(startTextMarkerForBoundsCallback):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):

LayoutTests:

Added test to ensure end/start text marker for bounds works as
expected. Updated bounds for range test to include new API.

  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/text-marker-for-bounds-expected.txt: Added.
  • platform/mac/accessibility/text-marker-for-bounds.html: Added.
3:07 PM Changeset in webkit [157820] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shapes] Match adjustLogicalLineTopAndLogicalHeightIfNeeded's implementation with Blink's
https://bugs.webkit.org/show_bug.cgi?id=123033

Reviewed by David Hyatt.

In Blink I made this function in a bit different way. This change modifies it
to be identical, which helps a lot in the future cross-merging patches.

No new tests, covered by existing texts.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::adjustLogicalLineTopAndLogicalHeightIfNeeded):

3:02 PM Changeset in webkit [157819] by dbates@webkit.org
  • 5 edits in trunk/Source

[iOS] Upstream more ARMv7s bits
https://bugs.webkit.org/show_bug.cgi?id=123052

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:
  • Configurations/ToolExecutable.xcconfig: Enable CLANG_ENABLE_OBJC_ARC for i386 as I'm

modifying a file in JavaScriptCore/Configurations.

Source/WebCore:

  • Configurations/WebCore.xcconfig:
2:49 PM Changeset in webkit [157818] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Try to fix Mavericks build; use <> for framework include.

  • page/CaptionUserPreferencesMediaAF.cpp:
2:45 PM Changeset in webkit [157817] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebKit2

URTBF after r157803 for !ENABLE(CSS_FILTERS) platforms.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/WebCoreArgumentCoders.cpp:
2:40 PM Changeset in webkit [157816] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

GammaFilterOperation seems to be dead code
https://bugs.webkit.org/show_bug.cgi?id=123173

Reviewed by Simon Fraser.

  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h:

Remove dead code.

2:24 PM Changeset in webkit [157815] by rniwa@webkit.org
  • 3 edits in trunk/Tools

There should be a way to specify additional repository paths in NRWT
https://bugs.webkit.org/show_bug.cgi?id=123135

Reviewed by Alexey Proskuryakov.

Added --additional-repository-name and --additional-repository-path options to NRWT.
These options allow us to submit addtional repository information, such as of Safari's
to the new flakiness dashboard.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/port/base.py:

(Port.repository_paths):

2:23 PM Changeset in webkit [157814] by Lucas Forschler
  • 3 edits in tags/Safari-538.2.1/Source/WebKit/mac

Merged r157753.

2:20 PM Changeset in webkit [157813] by Lucas Forschler
  • 5 edits in tags/Safari-538.2.1/Source

Versioning.

2:18 PM Changeset in webkit [157812] by Lucas Forschler
  • 1 copy in tags/Safari-538.2.1

New Tag.

2:08 PM Changeset in webkit [157811] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py

add mac-mavericks to wkbuild_unittest.py.

2:03 PM Changeset in webkit [157810] by Antti Koivisto
  • 31 edits in trunk/Source/WebCore

Rename some line box functions to be just about lines
https://bugs.webkit.org/show_bug.cgi?id=123168

Reviewed by Dave Hyatt.

firstLineBoxBaseline -> firstLineBaseline
hasInlineBoxChildren -> hasLines

Also use hasLines in a bunch of places where firstLineBox() was used.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

Also use hasRenderedText() instead of firstTextBox()

  • rendering/RenderFullScreen.cpp:


Fix namespace.

1:40 PM Changeset in webkit [157809] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[iOS] Upstream JSLock changes
https://bugs.webkit.org/show_bug.cgi?id=123107

Reviewed by Geoffrey Garen.

  • runtime/JSLock.cpp:

(JSC::JSLock::unlock):
(JSC::JSLock::dropAllLocks): Modified to take a SpinLock, used only on iOS.
(JSC::JSLock::dropAllLocksUnconditionally): Modified to take a SpinLock, used only on iOS. Also
use pre-increment instead of post-increment when we're not using the return value of the instruction.
(JSC::JSLock::grabAllLocks): Modified to take a SpinLock, used only on iOS. Also change
places where we were using post-increment/post-decrement to use pre-increment/pre-decrement,
since we don't use the return value of such instructions.
(JSC::JSLock::DropAllLocks::DropAllLocks): Modified to support releasing all locks unconditionally.
Take a spin lock before releasing all locks on iOS. Also, use nullptr instead of 0.
(JSC::JSLock::DropAllLocks::~DropAllLocks): Take a spin lock before acquiring all locks on iOS.

  • runtime/JSLock.h: Remove extraneous argument name "exec" from DropAllLocks as the data type of

the argument is sufficiently descriptive of its purpose.

1:18 PM Changeset in webkit [157808] by commit-queue@webkit.org
  • 7 edits
    1 copy
    4 adds in trunk/Source/WebCore

Adding Mock class to test RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=122848

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-22
Reviewed by Eric Carlson.

The following tests can be run:

RTCPeerConnection-createAnswer.html
RTCPeerConnection-createOffer.html
RTCPeerConnection-ice.html
RTCPeerConnection-localDescription.html
RTCPeerConnection-remoteDescription.html
RTCPeerConnection-state.html

Tests that require a MediaStream object, by invoking getUserMedia,
are not ready to run yet.

No new tests needed.

  • CMakeLists.txt:
  • platform/mediastream/RTCPeerConnectionHandler.cpp:

(WebCore::createHandler):

  • platform/mediastream/RTCPeerConnectionHandler.h:
  • platform/mediastream/RTCPeerConnectionHandlerClient.h:
  • platform/mock/RTCNotifiersMock.cpp: Added.
  • platform/mock/RTCNotifiersMock.h: Added.
  • platform/mock/RTCPeerConnectionHandlerMock.cpp: Added.
  • platform/mock/RTCPeerConnectionHandlerMock.h: Copied from Source/WebCore/platform/mediastream/RTCPeerConnectionHandler.h.
  • platform/mock/TimerEventBasedMock.h: Added.
  • testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::enableMockRTCPeerConnectionHandler):

  • testing/Internals.h:
1:16 PM Changeset in webkit [157807] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

WebCore::fillWithEmptyClients adopts new empty clients before leaking their pointers
https://bugs.webkit.org/show_bug.cgi?id=122945

Reviewed by Anders Carlsson.

  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients): Store the static empty clients as NeverDestroyed, rather than
adopting the pointer of each heap-allocated object and then immediately leaking that pointer.

1:10 PM Changeset in webkit [157806] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Simplify HRTFDatabaseLoader's load map
https://bugs.webkit.org/show_bug.cgi?id=122944

Reviewed by Eric Carlson.

  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::loaderMap): Return a reference to a NeverDestroyed HashMap that maps sample rates to loaders.
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):

  • platform/audio/HRTFDatabaseLoader.h: Remove the LoaderMap type definition, the private singleton of that type

and the singleton's unused getter.

12:46 PM Changeset in webkit [157805] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/wkbuild.py

add mac-mavericks to the target_platform list.

12:28 PM Changeset in webkit [157804] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Unreviewed, rolling out r157774.
http://trac.webkit.org/changeset/157774
https://bugs.webkit.org/show_bug.cgi?id=123167

causes python test to fail (Requested by smfr on #webkit).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):
(TestExpectations._add_expectations):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):
(_set_up_derived_options):

12:25 PM Changeset in webkit [157803] by timothy_horton@apple.com
  • 14 edits in trunk/Source

Remote Layer Tree: Support hardware accelerated filters
https://bugs.webkit.org/show_bug.cgi?id=123139

Reviewed by Anders Carlsson.

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::ArgumentCoder<Length>::encode):
(CoreIPC::ArgumentCoder<Length>::decode):
Add simple coders for Length.

(CoreIPC::encodeFilterOperation):
(CoreIPC::decodeFilterOperation):
Serialize and deserialize FilterOperations, except for CUSTOM and VALIDATED_CUSTOM.

(CoreIPC::ArgumentCoder<Length>::encode):
(CoreIPC::ArgumentCoder<Length>::decode):
Add coders for FilterOperations that delegate to {en,de}codeFilterOperation
for each operation in the list.

  • Shared/WebCoreArgumentCoders.h:

Drive-by fix indentation.
Expose the Length and FilterOperations coders.

  • Shared/mac/RemoteLayerTreeTransaction.h:

Add FiltersChanged and LayerProperties::filters.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
Encode and decode our FilterOperations.

(WebKit::dumpChangedLayers):
Dump information about the layers' filters.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
Use PlatformCAFilters code to apply a FilterOperations object to our CALayer.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::setFilters):
Replace existing filters with our new set, and note that they've changed.

(PlatformCALayerRemote::copyFiltersFrom):
Not yet implemented. Not critical for this feature, either.

(PlatformCALayerRemote::filtersCanBeComposited):
For now, this is the same as the Mac version.

  • WebCore.exp.in:

Export a variety of filter-related things.

  • platform/graphics/ca/PlatformCAFilters.h:
  • platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::setFilters):

  • platform/graphics/ca/win/PlatformCAFiltersWin.cpp:

(PlatformCAFilters::setFiltersOnLayer):
setFiltersOnLayer should take a PlatformLayer instead of a PlatformCALayer
as its argument, because it doesn't need a PlatformCALayer, and this way
we can share code with the RemoteLayerTreeHost, which only has PlatformLayers
and not PlatformCALayers.

12:16 PM Changeset in webkit [157802] by Lucas Forschler
  • 2 edits in trunk/Tools

Prepare WebKit Buildbot master for Mavericks.
This adds the following bot configurations:

Mavericks Release/Debug builders
Mavericks Release/Debug WK1 Testers
Mavericks Release/Debug WK2 Testers

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
11:46 AM Changeset in webkit [157801] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

cue.text fails for some track element cues
https://bugs.webkit.org/show_bug.cgi?id=81123

Patch by Brendan Long <b.long@cablelabs.com> on 2013-10-22
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-long-captions-file.html

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::parseBytes): Use buffer when we don't have full lines.
(WebCore::WebVTTParser::fileFinished): Force file to finish parsing.
(WebCore::WebVTTParser::hasRequiredFileIdentifier): Simplify due to using String.
(WebCore::WebVTTParser::collectCueText): Don't automatically create cues when we run out of data.
(WebCore::WebVTTParser::collectNextLine): Use buffer.

  • html/track/WebVTTParser.h: Add m_buffer and Finished state.
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::notifyFinished): Call m_parser->fileFinished() when done.

LayoutTests:

  • media/track/captions-webvtt/captions-long.vtt: Added.
  • media/track/track-long-captions-file-expected.txt: Added.
  • media/track/track-long-captions-file.html: Added.
10:33 AM Changeset in webkit [157800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[arm] Add missing setupArgumentsWithExecState() prototypes to fix build.
https://bugs.webkit.org/show_bug.cgi?id=123166

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

10:13 AM Changeset in webkit [157799] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=123161

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-22
Reviewed by Brent Fulgham.

  • rendering/RenderFlowThread.h: Move USE(ACCELERATED_COMPOSITING) guard to expose needed type.
10:08 AM Changeset in webkit [157798] by beidson@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

Add a cross-platform IDBRecordIdentifier
https://bugs.webkit.org/show_bug.cgi?id=123138

Reviewed by Andreas Kling.

Add the cross-platform header:

  • Modules/indexeddb/IDBRecordIdentifier.h: Added.

(WebCore::IDBRecordIdentifier::create):
(WebCore::IDBRecordIdentifier::encodedPrimaryKey):
(WebCore::IDBRecordIdentifier::version):
(WebCore::IDBRecordIdentifier::reset):
(WebCore::IDBRecordIdentifier::IDBRecordIdentifier):

  • WebCore.xcodeproj/project.pbxproj:
  • GNUmakefile.list.am:

Remove the old abstract and LevelDB classes:

  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

Use the cross-platform one everywhere:

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):

  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:

(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):

  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:

(WebCore::PutOperation::perform):

10:04 AM Changeset in webkit [157797] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4][mips][arm] Fix crashes in JSC (32-bit only).
https://bugs.webkit.org/show_bug.cgi?id=123165

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.

  • jit/JITInlines.h:

(JSC::JIT::callOperationNoExceptionCheck): Add missing EABI_32BIT_DUMMY_ARG.
(JSC::JIT::callOperation): The last TrustedImm32(arg3) is a bit overkill for SH4 :)
(JSC::JIT::callOperation): Add missing EABI_32BIT_DUMMY_ARG.
(JSC::JIT::callOperation): Fix tag and payload order for V_JITOperation_EJJJ prototype.

8:51 AM Changeset in webkit [157796] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

REGRESSION(r157690, r157699) Fix architectures using AssemblerBufferWithConstantPool.
https://bugs.webkit.org/show_bug.cgi?id=123092

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.

Impacted architectures are SH4 and ARM_TRADITIONAL.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::buffer):

  • assembler/AssemblerBufferWithConstantPool.h:

(JSC::AssemblerBufferWithConstantPool::flushConstantPool):

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::linkCode):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::buffer):

8:46 AM Changeset in webkit [157795] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

Remove unused stuff in JIT stubs.
https://bugs.webkit.org/show_bug.cgi?id=123155

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Michael Saboff.

  • jit/JITStubs.h:
  • jit/JITStubsARM.h:

(JSC::ctiTrampoline):

  • jit/JITStubsARM64.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsMIPS.h:
  • jit/JITStubsSH4.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
8:45 AM Changeset in webkit [157794] by dbates@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[iOS] Upstream OS-version-specific install paths for JavaScriptCore.framework
https://bugs.webkit.org/show_bug.cgi?id=123115
<rdar://problem/13696872>

Reviewed by Andy Estes.

Based on a patch by Mark Hahnenberg.

Add support for running JavaScriptCore-based apps, built against the iOS 7 SDK, on older versions of iOS.

  • API/JSBase.cpp:
7:50 AM Changeset in webkit [157793] by abucur@adobe.com
  • 18 edits in trunk/Source/WebCore

[CSS Regions] Possible performance regression after r157567
https://bugs.webkit.org/show_bug.cgi?id=123016

Reviewed by Andreas Kling.

The revision 157567 http://trac.webkit.org/changeset/157567 may have regressed
Parser/html5-full-render by ~1.1% and Parser/html-parser by ~2%. These changes
try to optimize the initial patch, based on Andreas Kling's review.

The patch also adds a couple of refactorings that should make the code easier to read:

  • the CSS Shapes functions are now wrapped in a single #if clause
  • the CSS Shapes and CSS Regions pre-layout preparations are wrapped in a helper function

The RenderFlowThread::logicalWidthChangedInRegionsForBlock function is optimized by passing
it information about the state of the relayout children flag. If the flag is true already,
some of the steps are skipped.

Tests: no new tests.

  • dom/Element.cpp:

(WebCore::Element::webkitGetRegionFlowRanges):

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementInfo):

  • rendering/RenderBlock.cpp:

(WebCore::shapeInfoRequiresRelayout):
(WebCore::RenderBlock::updateShapesBeforeBlockLayout):
(WebCore::RenderBlock::computeShapeSize):
(WebCore::RenderBlock::prepareShapesAndPaginationBeforeBlockLayout):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
(WebCore::RenderBlockFlow::ensureRareData):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderElement::isRenderNamedFlowFragmentContainer):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderElement.h:

(WebCore::RenderElement::generatingElement):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):

  • rendering/RenderFlowThread.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

  • style/StyleResolveTree.cpp:

(WebCore::Style::elementInsideRegionNeedsRenderer):

7:43 AM Changeset in webkit [157792] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CSSStyleSheet constructor functions should return PassRef.
<https://webkit.org/b/123156>

Make CSSStyleSheet::create*() return PassRef and tighten some call
sites that were using them. Most callers didn't need any tweaks to
take advantage of PassRef.

Reviewed by Antti Koivisto.

7:43 AM Changeset in webkit [157791] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CTTE: RenderMathMLFraction always has a MathMLInlineContainerElement.
<https://webkit.org/b/123154>

This renderer is never anonymous and always has a corresponding
MathMLInlineContainerElement. Overload element() with a tighter
return type.

Also marked the class FINAL and made most member functions private.

Reviewed by Antti Koivisto.

7:42 AM Changeset in webkit [157790] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

FontGlyphs constructor functions should return PassRef.
<https://webkit.org/b/123159>

Made the two FontGlyphs creator functions return PassRef and tweaked
the FontGlyphsCache in Font.cpp to make more efficient use of it.

Reviewed by Antti Koivisto.

6:45 AM Changeset in webkit [157789] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Add missing lastRegister(), firstFPRegister() and lastFPRegister().
https://bugs.webkit.org/show_bug.cgi?id=123157

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-22
Reviewed by Andreas Kling.

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::lastRegister):
(JSC::SH4Assembler::firstFPRegister):
(JSC::SH4Assembler::lastFPRegister):

6:12 AM Changeset in webkit [157788] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix some more code to use RenderElement instead of RenderObject.
<https://webkit.org/b/123149>

Using RenderElement where possible lets us skip the isRenderElement()
branch in RenderObject::style() and generates much tighter code.

Reviewed by Antti Koivisto.

6:04 AM Changeset in webkit [157787] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Merge SVG renderers' styleWillChange() into styleDidChange().
<https://webkit.org/b/123108>

This work can just as well be done after setting the style.
Three more styleWillChange() overloads gone.

Reviewed by Antti Koivisto.

6:04 AM Changeset in webkit [157786] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CSSValueList constructor functions should return PassRef.
<https://webkit.org/b/123151>

These functions always return objects, and thus can return PassRef.
Also made CSSValueList::createFromParserValueList() take a reference
since that function is only ever called with a non-null value.

Reviewed by Antti Koivisto.

6:03 AM Changeset in webkit [157785] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Avoid parent style ref churn in createTextRendererIfNeeded().
<https://webkit.org/b/123148>

There's no need to take a temporary ref on the parent's RenderStyle
while creating a text renderer. It's not going away, and the text
renderer is not going to participate in ownership afterwards.

Reviewed by Antti Koivisto.

4:57 AM Changeset in webkit [157784] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Build break on ARMv7 after r157209
https://bugs.webkit.org/show_bug.cgi?id=122890

Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-22
Reviewed by Csaba Osztrogonác.

Add framePointerRegister and first/last register helpers for ARM_TRADITIONAL.

  • assembler/ARMAssembler.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::firstRegister):
(JSC::MacroAssemblerARM::lastRegister):
(JSC::MacroAssemblerARM::firstFPRegister):
(JSC::MacroAssemblerARM::lastFPRegister):

3:58 AM Changeset in webkit [157783] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove some unnecessary null checks in RenderElement::setStyle().
<https://webkit.org/b/123146>

After assigning the new style to RenderElement::m_style, we know that
it'll be non-null, so remove all the checking for this.

Reviewed by Antti Koivisto.

3:10 AM Changeset in webkit [157782] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/Source/WebCore

Introduce ACCESSIBILITY_OBJECT_TYPE_CASTS to replace manual toFoo() in accessibility child class
https://bugs.webkit.org/show_bug.cgi?id=123140

Reviewed by Andreas Kling.

As a step to let toFoo use TYPE_CASTS_BASE, DEFINE_TYPE_CASTS can be used for toFoo() in accessibility
child class. The DEFINE_TYPE_CASTS will generate plenty more helper functions for accessibility type cast.

No new tests, no behavior changes.

  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMockObject.h:
  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySVGRoot.h:
  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilitySpinButton.h:
  • accessibility/AccessibilityTable.h:
2:09 AM Changeset in webkit [157781] by commit-queue@webkit.org
  • 21 edits
    3 adds in trunk/Source

[GTK] Add WebKit2 API for TLS errors
https://bugs.webkit.org/show_bug.cgi?id=120160

Patch by Brian Holt <brian.holt@samsung.com> on 2013-10-22
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Added a new constructor for CertificateInfo under Soup.

  • platform/network/CertificateInfo.h:
  • platform/network/soup/CertificateInfoSoup.cpp:

(WebCore::CertificateInfo::CertificateInfo): New constructor using
GTlsCertificateFlags and GTlsCertificate.

Source/WebKit2:

Add a new signal load-failed-with-tls-errors that is emitted with
a WebKitCertificateInfo boxed type to allow users to deal with TLS
errors. A new API is exposed in WebKitWebContext to allow
exceptions for TLS errors on a given host.

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • UIProcess/API/gtk/WebKitCertificateInfo.cpp: Added.

(webkitCertificateInfoGetCertificateInfo):
(webkit_certificate_info_copy):
(webkit_certificate_info_free):
(webkit_certificate_info_get_tls_certificate):
(webkit_certificate_info_get_tls_errors):

  • UIProcess/API/gtk/WebKitCertificateInfo.h: Added.
  • UIProcess/API/gtk/WebKitCertificateInfoPrivate.h: Added.

(_WebKitCertificateInfo::_WebKitCertificateInfo):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_allow_tls_certificate_for_host): Support TLS
exceptions for a given host.

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init): Added new signal.
(webkitWebViewLoadFailedWithTLSErrors): Emit new signal with
WebKitCertificateInfo and host.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/docs/webkit2gtk.types:
  • UIProcess/API/gtk/tests/TestSSL.cpp:

(testLoadFailedWithTLSErrors):
(httpsServerCallback):
(beforeAll): Added new test.

  • UIProcess/API/gtk/webkit2.h:
  • UIProcess/API/gtk/webkit2marshal.list:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::allowSpecificHTTPSCertificateForHost): Send
message to WebProcess to allow a certificate and host pair.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: New message to tell

WebProcess to allow a specific TLS certificate for a given host.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost): Allow
certificate and host pair.

1:39 AM Changeset in webkit [157780] by commit-queue@webkit.org
  • 5 edits
    1 move
    2 deletes in trunk/LayoutTests

[EFL] accessibility/plugin.html passes incorrectly
https://bugs.webkit.org/show_bug.cgi?id=122889

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-10-22
Reviewed by Chris Fleizach.

Sharing test.swf by all existing layout tests accessing it.

  • accessibility/plugin.html:
  • fast/loader/sandboxed-plugin-crash.html:
  • fast/replaced/border-radius-clip.html:
  • fast/replaced/embed-display-none.html:
  • fast/replaced/resources/test.swf: Removed.
  • platform/mac/accessibility/resources/test.swf: Removed.
  • resources/test.swf: Renamed from LayoutTests/fast/loader/resources/test.swf.
1:28 AM Changeset in webkit [157779] by mihnea@adobe.com
  • 8 edits in trunk/Source/WebCore

[CSSRegions] Use RenderStyle::hasFlowFrom when needed
https://bugs.webkit.org/show_bug.cgi?id=122543

Reviewed by David Hyatt.

Rename RenderStyle::hasStyleRegion -> RenderStyle::hasFlowFrom.
Use RenderStyle::hasFlowFrom() helper function instead of directly
checking the value of RenderStyle::regionThread().

No change of functionality, covered by existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::didAttachRenderers):

  • dom/PseudoElement.h:

(WebCore::pseudoElementRendererIsNeeded):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeNormalFlowOnly):

  • rendering/style/RenderStyle.h:
12:32 AM Changeset in webkit [157778] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to make the 32-bit Mac build happy.

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h:

Oct 21, 2013:

10:19 PM Changeset in webkit [157777] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to make the 32-bit Mac build happy.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(setUpPageLoaderClient):

10:16 PM Changeset in webkit [157776] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Add load delegate method for didChangeBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=123136

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didChangeBackForwardList): Added. Calls new delegate method.
(setUpPageLoaderClient): Hook up new client function.

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declare new delegate method.
9:42 PM Changeset in webkit [157775] by rniwa@webkit.org
  • 8 edits
    5 adds in trunk/Websites/test-results

New flakiness dashboard should hyperlink test names, WebKit revisions, and bubbles
https://bugs.webkit.org/show_bug.cgi?id=123134

Reviewed by Stephanie Lewis.

Copied admin.css, admin-header.php, admin-footer.php, builders.php, repositories.php from WebKit Perf Monitor.
(Unfortunately WebKit Perf Monitor hasn't been committed into WebKit repository just yet.)

Updated various parts of index.html to linkify test names, build numbers, and bubbles (to results page).

  • admin/admin.css: Added.
  • admin/builders.php: Added.
  • admin/index.php: Removed the duplicated code now that it uses admin-header.php.
  • admin/repositories.php: Added.
  • api/manifest.php: Use camelCase for blame_url and build_url to be consistent with other JSON properties.

Also exported testCategories from config so that we can linkify test names in the dashboard.

  • include/admin-footer.php: Added.
  • include/admin-header.php: Added.
  • include/config.json: Added test categories. This avoids hard-coding the URL to trac in php/js.
  • include/init-database.sql: Added name and build_url to builders table and category to tests.
  • include/test-results.php: Assume the test category to be LayoutTest for now.
  • index.html:

(TestResultsView): Initialize _builders, _slaves, _repositories, _testCategories as dictionaries as intended.
(TestResultsView.setTestCategories): Added.
(TestResultsView._createResultCell): Dynamically resolve URLs of results page and and build page.
(TestResultsView._populateTestPane): Linkify the test name. Unfortunately we don't have a test object anywhere.
We need to figure out a way to find the test object here eventually. For now, hard-coding "LayoutTest" works.
(TestResultsView._linkifiedTestName): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Takes builderId to set "builder" property on each
result object as it's used by Build class.
(TestResultsView._populateBuilderPane):
(fetchManigest):

  • js/build.js:

(Build.buildUrl): Support $builderName so that we don't have to keep repeating builder names in the database.
(Build.revision): Don't access [0] if revisions[repositoryId] was undefined.

7:17 PM Changeset in webkit [157774] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Run tests as if they are expected to pass when --force is given.
https://bugs.webkit.org/show_bug.cgi?id=112890

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-21
Reviewed by Ryosuke Niwa.

The --force switch of new-run-webkit-tests is now forces all tests to
be run with 'PASS' as expected result.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations.init):
(TestExpectations._add_expectations):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):
(_set_up_derived_options):

7:05 PM Changeset in webkit [157773] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

[WIN] Properly support reverse animations without needing software fallback.
https://bugs.webkit.org/show_bug.cgi?id=85121

Reviewed by Dean Jackson.

Testing is provided by existing animation tests.

  • platform/animation/TimingFunction.h:

(WebCore::CubicBezierTimingFunction::createReversed): Added.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::addAnimation): The early return when performing a reverse or
autoreverse animation is no longer needed.

  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(toCAMediaTimingFunction): Use new reversed function.

  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(toCACFTimingFunction): Ditto.
(PlatformCAAnimation::setTimingFunction): Pass 'reverse' flag.
(PlatformCAAnimation::setTimingFunctions): Ditto.

6:51 PM Changeset in webkit [157772] by rniwa@webkit.org
  • 5 edits in trunk/Websites/test-results

New flakiness dashboard should align results by revision numbers
https://bugs.webkit.org/show_bug.cgi?id=123129

Reviewed by Tim Horton.

  • include/config.json: Specify the default cache time to be 10 minutes.
  • include/json-shared.php: Added Expires and Cache-Control headers. It's configurable via config.json.
  • index.html:

(TestResultsView._createResultCell): Don't put '-' in a result cell without time.
(TestResultsView._populateTestPane): Create an array of build times ordered from the newest to the oldest.
Not that build.time() is the newest commit time among all repository for each result. e.g. if we had
both WebKit and Safari repository information in a given result, the newer of the two will be used.
(TestResultsView._createTestResultHeader): Added.
(TestResultsView._createBuildsAndComputeSlownessOfResults): Extracted from _createTestResultRow so
that _populateTestPane could use Build object before calling _createTestResultRow.
(TestResultsView._createTestResultRow): Takes buildTimes. Insert an empty cell for a build time if
the current row doesn't contain that a result for that build time.
(TestResultsView._populateBuilderPane):

  • main.css: Tweaked the style so that bubbles are aligned vertically without '-'.

(.resultsTable):
(.resultsTable thead th):
(.resultsTable .resultCell):
(.resultsTable a):
(.resultsTable span a):

6:31 PM Changeset in webkit [157771] by mrowe@apple.com
  • 1 edit in trunk/WebKitLibraries/libWebKitSystemInterfaceMavericks.a

Set svn:mime-type on libWebKitSystemInterfaceMavericks.a so that future changes don't generate giant commit emails.

6:27 PM Changeset in webkit [157770] by mrowe@apple.com
  • 9 edits
    1 add in trunk

Add a version of WebKitSystemInterface for Mavericks.

Reviewed by Ryosuke Niwa.

Source/WebKit/mac:

  • Configurations/DebugRelease.xcconfig:

Source/WebKit2:

  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • Scripts/copy-webkitlibraries-to-product-directory:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:

WebKitLibraries:

  • libWebKitSystemInterfaceMavericks.a: Added.
6:25 PM Changeset in webkit [157769] by gyuyoung.kim@samsung.com
  • 33 edits in trunk/Source/WebCore

Use TYPE_CASTS_BASE for CSS_VALUE_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=123126

Reviewed by Andreas Kling.

TYPE_CASTS_BASE was moved to common place to be used by all toFoo().
CSS_VALUE_TYPE_CASTS starts to use it for CSS child value. This change
generates plenty more helper functions for toCSSFooValue().

Additionally, this use support that toWebKitCSSFooValue, which couldn't
use CSS_VALUE_TYPE_CASTS macro.

No new tests, no behavior change.

  • css/CSSAspectRatioValue.h:
  • css/CSSBorderImageSliceValue.h:
  • css/CSSCalculationValue.h:
  • css/CSSCanvasValue.h:
  • css/CSSCrossfadeValue.h:
  • css/CSSCursorImageValue.h:
  • css/CSSFilterImageValue.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontFeatureValue.h:
  • css/CSSFontValue.h:
  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.h:
  • css/CSSGridTemplateValue.h:
  • css/CSSImageSetValue.h:
  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.h:
  • css/CSSLineBoxContainValue.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.h:
  • css/CSSShadowValue.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSUnicodeRangeValue.h:
  • css/CSSValue.h:
  • css/CSSValueList.h:
  • css/CSSVariableValue.h:
  • css/WebKitCSSArrayFunctionValue.h:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSMatFunctionValue.h:
  • css/WebKitCSSMixFunctionValue.h:
  • css/WebKitCSSSVGDocumentValue.h:
  • css/WebKitCSSShaderValue.h:
5:29 PM Changeset in webkit [157768] by joone.hur@intel.com
  • 2 edits in trunk/Source/WebCore

Bad cast with toRenderBoxModelObject in RenderBlock::updateFirstLetter()
https://bugs.webkit.org/show_bug.cgi?id=123013

Reviewed by Andreas Kling.

No new tests because this was reported by Google ClusterFuzz.
https://codereview.chromium.org/25713009/

There is a case that toRenderBoxModelObject causes a crash in RenderBlock::updateFirstLetter()
due to bad cast, so we need to check whether the RenderObject is a RenderBoxModelObject
by running isBoxModelObject() before calling toRenderBoxModelObject.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetter):

5:18 PM Changeset in webkit [157767] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154289. <rdar://problem/15109381>

5:18 PM Changeset in webkit [157766] by beidson@apple.com
  • 10 edits
    2 moves in trunk/Source/WebCore

Make IDBTransactionCoordinatorLevelDB cross platform
https://bugs.webkit.org/show_bug.cgi?id=123124

Enthusiastically reviewed by Tim Horton.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:

Make more methods pure virtual in the interface:

  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

Update the name of the class, and use IDBTransactionBackendInterface instead of IDBTransactionBackendLeveDB:

  • Modules/indexeddb/IDBTransactionCoordinator.cpp: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp.

(WebCore::IDBTransactionCoordinator::create):
(WebCore::IDBTransactionCoordinator::IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::~IDBTransactionCoordinator):
(WebCore::IDBTransactionCoordinator::didCreateTransaction):
(WebCore::IDBTransactionCoordinator::didStartTransaction):
(WebCore::IDBTransactionCoordinator::didFinishTransaction):
(WebCore::IDBTransactionCoordinator::isActive):
(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::doScopesOverlap):
(WebCore::IDBTransactionCoordinator::canRunTransaction):

  • Modules/indexeddb/IDBTransactionCoordinator.h: Renamed from Source/WebCore/Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h.

Update the name of the class elsewhere:

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:

(WebCore::IDBDatabaseBackendLevelDB::transactionCoordinator):

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
4:55 PM Changeset in webkit [157765] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-537.73-branch

Merged r154217. <rdar://problem/15109395>

4:54 PM Changeset in webkit [157764] by dbates@webkit.org
  • 11 edits in trunk/Source

[iOS] Upstream JSGlobalObject::shouldInterruptScriptBeforeTimeout()
https://bugs.webkit.org/show_bug.cgi?id=123045

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • jsc.cpp: Add function pointer for shouldInterruptScriptBeforeTimeout

to global method table.

  • runtime/JSGlobalObject.cpp: Ditto.
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::shouldInterruptScriptBeforeTimeout): Added.

Source/WebCore:

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage): Added.
(WebCore::JSDOMWindowBase::shouldInterruptScript): Extracted comment and assertion
about null Page object into WebCore::shouldInterruptScriptToPreventInfiniteRecursionWhenClosingPage()
so that it can be shared by both this function and JSDOMWindowBase::shouldInterruptScriptBeforeTimeout().
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::shouldInterruptScriptBeforeTimeout): Added.

  • bindings/js/JSWorkerGlobalScopeBase.h:
  • loader/EmptyClients.h: Added isStopping(). We'll land the iOS chrome client implementation

in a subsequent patch.

  • page/ChromeClient.h: Added isStopping().
4:35 PM Changeset in webkit [157763] by Lucas Forschler
  • 16 edits
    5 copies
    4 deletes in branches/safari-537.73-branch/Source

Merged r154183. <rdar://problem/15109466>

4:35 PM Changeset in webkit [157762] by Alexandru Chiculita
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: [CSS Regions] Flows are not loading if you refresh the page several times
https://bugs.webkit.org/show_bug.cgi?id=123123

Reviewed by Joseph Pecoraro.

There was a typo in the code where an exception was thrown because "flowKey" was undefined.

  • UserInterface/DOMTree.js:

(WebInspector.DOMTree.prototype._contentFlowListWasUpdated):

4:28 PM Changeset in webkit [157761] by dbates@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[iOS] Upstream JSC Objective-C API compiler warning fixes
https://bugs.webkit.org/show_bug.cgi?id=123125

Reviewed by Mark Hahnenberg.

Based on a patch by Mark Hahnenberg.

  • API/JSValue.mm:

(-[JSValue toPoint]): Cast to CGFloat to fix some compiler warnings about double narrowing to float.
(-[JSValue toSize]): Ditto.

  • API/tests/testapi.mm: Changed a test that was failing due to overflow of 32-bit NSUInteger on armv7.
4:15 PM Changeset in webkit [157760] by Lucas Forschler
  • 10 edits in branches/safari-537.73-branch/Source/WebKit/mac

Merged r154078. <rdar://problem/15109379>

4:11 PM Changeset in webkit [157759] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r154085. <rdar://problem/15109354>

4:09 PM Changeset in webkit [157758] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r154077. <rdar://problem/15109354>

4:06 PM Changeset in webkit [157757] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r153848. <rdar://problem/15109354>

3:55 PM Changeset in webkit [157756] by andersca@apple.com
  • 4 edits
    2 adds in trunk

Navigation policy callback not called when performing the same fragment navigation twice
https://bugs.webkit.org/show_bug.cgi?id=123121
<rdar://problem/15230466>

Reviewed by Beth Dakin.

Source/WebCore:

There's code in PolicyChecker::checkNavigationPolicy that will call the decision function right away
if the requests are equal, without consulting any policy client. Because of this, make sure to empty out
the last checked request of the document loader when doing a fragment navigation.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):

Tools:

Add a test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
  • TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.

(+[WebKit1FragmentNavigationTestDelegate shared]):
(-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
(-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
(-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
(-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
(TestWebKitAPI::TEST):

3:49 PM Changeset in webkit [157755] by dbates@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[iOS] Mark classes JS{Context, ManagedValue, Value, VirtualMachine} as
available since iOS 7.0
https://bugs.webkit.org/show_bug.cgi?id=123122

Reviewed by Dan Bernstein.

  • API/JSContext.h:
  • API/JSManagedValue.h:
  • API/JSValue.h:
  • API/JSVirtualMachine.h:
3:48 PM Changeset in webkit [157754] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix the Mac 32-bit build.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:
3:46 PM Changeset in webkit [157753] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Remove platform #ifdefs from WebDataSourcePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=123120
<rdar://problem/15275533>

Reviewed by Anders Carlsson.

  • WebView/WebDataSource.mm:

(-[WebDataSource _setAllowToBeMemoryMapped]): Define empty implementation when building without
disk image cache enabled.
(-[WebDataSource setDataSourceDelegate:]): Ditto.
(-[WebDataSource dataSourceDelegate]): Return nullptr when building without disk image cache
enabled on iOS.

  • WebView/WebDataSourcePrivate.h: Removed platform #ifdefs added in

<http://trac.webkit.org/changeset/156918> (https://bugs.webkit.org/show_bug.cgi?id=121985)

3:40 PM Changeset in webkit [157752] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Give up on building RemoteLayerTreeTransaction::dump on Lion, it just won't work.

This definitely ought to fix the build.

  • Shared/mac/RemoteLayerTreeTransaction.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:
  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):

3:25 PM Changeset in webkit [157751] by rniwa@webkit.org
  • 8 edits in trunk/Websites/test-results

New flakiness dashboard show test time, modifiers, and flaky tests
https://bugs.webkit.org/show_bug.cgi?id=123119

Reviewed by Tim Horton.

  • api/failing-tests.php: Manually serialize each row in the results to avoid hitting the memory limit.
  • include/db.php:

(Database::query): Added.
(Database::fetch_next_row): Added.

  • include/init-database.sql: Added modifiers and time columns to results table.
  • include/test-results.php:

(store_test_results): Update start_time and end_time to the union of the new interval and the existing interval.
(recursively_add_test_results): Handle empty $full_name to eliminate the loop over tests in store_test_results.
Also verify that each test name, expected and actual results conform to the specific format to prevent XSS.
Also use insert_row instead of select_or_insert_row to avoid issuing an unnecessary SQL query.
(format_result): Extracted from format_result_rows. Used in failing-tests.php.

  • index.html:

(TestResultsView): Added _currentBuilderFailureType and _currentBuilderDays.
(TestResultsView._createResultCell): Show the test time and the expected result.
(TestResultsView._createTestResultRow): Compute the slowest run and also round time to tenth of second for time
less than 10s or second if it's more than 10s so that the test time will always be shown in two digits.
Also show the bug number and the latest expected result on the left columns after linkifying the bug numbers.
(TestResultsView._matchesFailureType): Added. Determines whether results is of a particular failure type.
(TestResultsView._populateBuilderPane):
(TestResultsView.fetchFailingTestsForBuilder): Store the failure type such as flaky, wrongtestexpectations.
(TestResultsView.updateLocationHash):
(TestResultsView.loadTestsFromLocationHash):
(fetchManifest):

  • js/dom.js:

(element): appendChild if an item is a Node. Otherwise, e.g. integer, create a text node out of toString() call.

  • main.css: Updated styles.
3:21 PM Changeset in webkit [157750] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Maybe a Lion build fix after r157731, part 2.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):

3:11 PM Changeset in webkit [157749] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix; unprotect the declaration of updateSleepDisabling();

  • html/HTMLMediaElement.h:
3:09 PM Changeset in webkit [157748] by mitz@apple.com
  • 9 edits
    4 moves
    12 adds in trunk/Source/WebKit2

[Cocoa] Back/forward list UI process API
https://bugs.webkit.org/show_bug.cgi?id=123109

Reviewed by Darin Adler.

  • CMakeLists.txt: Updated for renames.
  • GNUmakefile.list.am: Ditto.
  • Shared/Cocoa: Added.
  • Shared/Cocoa/WKNSArray.h: Added. WKNSArray is an internal NSArray subclass backed by

a WebKit::ImmutableArray.

  • Shared/Cocoa/WKNSArray.mm: Added.

(+[WKNSArray web_arrayWithImmutableArray:]): Added.
(-[WKNSArray web_initWithImmutableArray:]): Added.
(-[WKNSArray count]): Added.
(-[WKNSArray objectAtIndex:]): Added.
(-[WKNSArray copyWithZone:]): Added.

  • Shared/Cocoa/WKNSObjectExtras.h: Added. Declares a category on NSObject that allows us to

vend WebKit API objects as Objective-C objects.

  • Shared/Cocoa/WKNSObjectExtras.mm: Added.

(-[WKObject initWithAPIObject:]): WKObject is the generic Cocoa wrapper for API objects.
(-[WKObject isEqual:]): Check for equality of the underlying object.
(-[WKObject hash]): Return a pointer to the underlying object.
(-[WKObject description]): Added.
(+[NSObject _web_objectWithAPIObject:]): Added. Returns an appropriate Objective-C object
for the given API object. Currently returns a WKBackForwardListItem for a back/forward list
item and a generic WKObject for all other types.

  • UIProcess/API/C/WKBackForwardList.cpp: Renamed.
  • UIProcess/API/C/WKBackForwardList.h: Renamed.
  • UIProcess/API/C/WKBackForwardListItem.cpp: Renamed.
  • UIProcess/API/C/WKBackForwardListItem.h: Renamed.
  • UIProcess/API/C/WKBackForwardListItemRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.cpp.
  • UIProcess/API/C/WKBackForwardListItemRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardListItem.h.
  • UIProcess/API/C/WKBackForwardListRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.cpp.
  • UIProcess/API/C/WKBackForwardListRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKBackForwardList.h.
  • UIProcess/API/C/WebKit2_C.h: Updated for header renames.
  • UIProcess/API/efl/ewk_back_forward_list.cpp: Updated for rename.
  • UIProcess/API/efl/ewk_back_forward_list_item.cpp: Ditto.
  • UIProcess/API/mac/WKBrowsingContextController.h: Declared backForwardList property.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController backForwardList]): Added this accessor.

  • UIProcess/Cocoa: Added.
  • UIProcess/Cocoa/WKBackForwardList.h: Added.
  • UIProcess/Cocoa/WKBackForwardList.mm: Added.

(toWKBackForwardListItem): Added this helper.
(-[WKBackForwardList currentItem]): Added.
(-[WKBackForwardList backItem]): Added.
(-[WKBackForwardList forwardItem]): Added.
(-[WKBackForwardList itemAtIndex:]): Added.
(-[WKBackForwardList backListCount]): Added.
(-[WKBackForwardList forwardListCount]): Added.
(-[WKBackForwardList backListWithLimit:]): Added.
(-[WKBackForwardList forwardListWithLimit:]): Added.
(-[WKBackForwardList _initWithList:]): Added.

  • UIProcess/Cocoa/WKBackForwardListInternal.h: Added.
  • UIProcess/Cocoa/WKBackForwardListItem.h: Added.
  • UIProcess/Cocoa/WKBackForwardListItem.mm: Added.

(-[WKBackForwardListItem URL]): Added.
(-[WKBackForwardListItem title]): Added.
(-[WKBackForwardListItem originalURL]): Added.
(-[WKBackForwardListItem isEqual:]): Check for equality of the underlying object.
(-[WKBackForwardListItem hash]): Return a pointer to the underlying object
(-[WKBackForwardListItem _initWithItem:]): Added.

  • UIProcess/Cocoa/WKBackForwardListItemInternal.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
3:06 PM Changeset in webkit [157747] by mitz@apple.com
  • 3 edits in trunk/Tools

Style checker should allow a space after the @property keyword
https://bugs.webkit.org/show_bug.cgi?id=123117

Reviewed by Anders Carlsson.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing_for_function_call): Allow a space between @property and the following (

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_spacing_for_fncall): Added a test case.

3:00 PM Changeset in webkit [157746] by mark.lam@apple.com
  • 14 edits in trunk/Source

Avoid JSC debugger overhead unless needed.
https://bugs.webkit.org/show_bug.cgi?id=123084.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • If no breakpoints are set, we now avoid calling the debug hook callbacks.
  • If no break on exception is set, we also avoid exception event debug callbacks.
  • When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
  • debugger/Debugger.cpp:

(JSC::Debugger::Debugger):
(JSC::Debugger::setNeedsExceptionCallbacks):
(JSC::Debugger::setShouldPause):
(JSC::Debugger::updateNumberOfBreakpoints):
(JSC::Debugger::updateNeedForOpDebugCallbacks):

  • debugger/Debugger.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_debug):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_debug):

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter.asm:

Source/WebCore:

No new tests.

  • If no breakpoints are set, we now avoid calling the debug hook callbacks.
  • If no break on exception is set, we also avoid exception event debug callbacks.
  • When we return from the ScriptDebugServer to the JSC::Debugger, we may no longer call the debug hook callbacks if not needed. Hence, the m_currentCallFrame pointer in the ScriptDebugServer may become stale. To avoid this issue, before returning, the ScriptDebugServer will clear its m_currentCallFrame if needsOpDebugCallbacks() is false.
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setPauseOnExceptionsState):
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
(WebCore::ScriptDebugServer::breakProgram):
(WebCore::ScriptDebugServer::stepIntoStatement):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::didReachBreakpoint):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::reset):

Source/WebKit/mac:

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):

2:48 PM Changeset in webkit [157745] by Lucas Forschler
  • 6 edits in branches/safari-537.73-branch/Source

Merged r154067. <rdar://problem/15109373>

2:43 PM Changeset in webkit [157744] by Lucas Forschler
  • 1 edit
    2 copies in branches/safari-537.73-branch/LayoutTests

Merged r153982. <rdar://problem/15109382>

2:42 PM Changeset in webkit [157743] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r153975. <rdar://problem/15109382>

2:39 PM Changeset in webkit [157742] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r153920. <rdar://problem/15109364>

2:36 PM Changeset in webkit [157741] by Lucas Forschler
  • 8 edits
    2 copies in branches/safari-537.73-branch

Merged r153913. <rdar://problem/15109360>

2:33 PM Changeset in webkit [157740] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r153909. <rdar://problem/15109368>

2:31 PM Changeset in webkit [157739] by commit-queue@webkit.org
  • 11 edits in trunk

Grammar markers are not updated when switching between 1x and 2x
https://bugs.webkit.org/show_bug.cgi?id=122146

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-21
Reviewed by Dean Jackson.

Source/WebCore:

When running editing/spelling/grammar-markers-hidpi.html, the 2x
grammar/spelling dot resources are cached. If you then run
editing/spelling/grammar-markers.html without tearing down WebKit,
it re-uses the 2x dots. The difference between the two tests is a call
to testRunner.setBackingScaleFactor().

We create a NSColor from an NSImage, and remember it in a static
variable. However, NSColor inspects the current graphics context to
determine which resolution to use, and then remembers that decision.
Therefore, we want to recreate the NSColor whenever the device pixel
ratio changes. This patch adds a new static function to GraphicsContext
which recreates this NSColor every time the ratio changes.

Tests: editing/spelling/grammar-markers.html

editing/spelling/inline_spelling_markers.html

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):

LayoutTests:

  • platform/mac/editing/spelling/grammar-markers-expected.png:
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png:
  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::makePattern):
(WebCore::GraphicsContext::drawLineForDocumentMarker):

2:26 PM Changeset in webkit [157738] by Lucas Forschler
  • 11 edits
    2 copies in branches/safari-537.73-branch

Merged r153877. <rdar://problem/15109353>

2:26 PM Changeset in webkit [157737] by Brent Fulgham
  • 3 edits in trunk/Source/JavaScriptCore

[WIN] Unreviewed build correction.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Handle new JIT files as C++ implementation sources, not header files.
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
2:22 PM Changeset in webkit [157736] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Use pink layer borders for compositing layers with a contents layer
https://bugs.webkit.org/show_bug.cgi?id=123118

Reviewed by Dean Jackson.

With the existing layer border colors, it's not possible to distinguish an empty
layer from one with solid color, image or video contents. So use a pink color
for those. This makes it easier to diagnose bugs like 122784.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::getDebugBorderInfo):

2:20 PM Changeset in webkit [157735] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebCore

Limit use of display sleep assertion when <video> element is off-screen.
https://bugs.webkit.org/show_bug.cgi?id=123041

Reviewed by Darin Adler.

Use page visibility changes to suspend and resume the use of sleep assertions in
HTMLMediaElement.

Page will propogate the page visibility change notifications to its Documents, which
will further propogate those notifications to registered elements. Upon receiving
these notifications, HTMLMediaElement will release or take a DisplaySleepDisabler
token if necessary.

Also, rename HTMLMediaElement's updateDisableSleep() to updateSleepDisabling() and wrap
the implementation in a PLATFORM(MAC) guard rather than at each call site.

  • dom/Document.cpp:

(WebCore::Document::registerForVisibilityStateCallbacks): Added registration method.
(WebCore::Document::unregisterForVisibilityStateCallbacks): Added unregistration method.
(WebCore::Document::visibilityStateChanged): Call all registered clients.

  • dom/Document.h:
  • dom/Element.h:

(WebCore::Element::visibilityStateChanged): Added default virtual method to be overridden

by subclasses.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Register for the notification, and check the

current status of Document::hidden().

(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister for the notification.
(WebCore::HTMLMediaElement::visibilityStateChanged): Set m_displaySleepDisablingSuspended

and call updateSleepDisabling().

(WebCore::HTMLMediaElement::shouldDisableSleep): Add a check for m_displaySleepDisablingSuspended.

  • html/HTMLMediaElement.h:
  • page/Page.cpp:

(WebCore::Page::setVisibilityState): Pass to every child document.

Rename updateDisableSleep() -> updateSleepDisabling():

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::mediaPlayerRateChanged):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stop):

2:20 PM Changeset in webkit [157734] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Maybe a Lion build fix after r157731.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<):

2:14 PM Changeset in webkit [157733] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

MediaStreamTrack now tracks its own state
https://bugs.webkit.org/show_bug.cgi?id=123025

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Jer Noble.

The spec says that a MediaStreamSource can be shared by different tracks,
so a track must have its own state tracking, synchronizing with its MediaStreamSource when
the underlying MediaStreamSource changes the readyState.
In the old implementation if a user invoked the stop method, its readyState method was still
returning the MediaStreamSource state, which was wrong.
This also adds a setEnabled method, which can be used to set the state of a track when a
remote peer ends it, for instance.

No new tests needed.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::setState):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::ended):
(WebCore::MediaStreamTrack::sourceStateChanged):
(WebCore::MediaStreamTrack::trackDidEnd):

  • Modules/mediastream/MediaStreamTrack.h:
1:59 PM Changeset in webkit [157732] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WTF

Merged r153767. <rdar://problem/15109338>

1:42 PM Changeset in webkit [157731] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Remote Layer Tree: Clean up transaction logging
https://bugs.webkit.org/show_bug.cgi?id=123116

Reviewed by Anders Carlsson.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::RemoteLayerTreeTextStream):
(WebKit::RemoteLayerTreeTextStream::increaseIndent):
(WebKit::RemoteLayerTreeTextStream::decreaseIndent):
(WebKit::RemoteLayerTreeTextStream::writeIndent):
(WebKit::RemoteLayerTreeTextStream::operator<<):
Add some stream operator overrides for various types we need to dump.
Add a notion of current indent to our TextStream subclass to make it
easy to keep track of where we are.

(WebKit::dumpProperty):
Added, hand any arbitrary type to RemoteLayerTreeTransaction.

(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::dump):
Make use of TextStream.

  • WebCore.exp.in:

Export some TextStream functions.

1:31 PM Changeset in webkit [157730] by beidson@apple.com
  • 22 edits in trunk/Source

Transition most use of IDBBackingStoreLevelDB to IDBBackingStoreInterface
https://bugs.webkit.org/show_bug.cgi?id=123105

Reviewed by Anders Carlsson.

Source/WebCore:

Export more required headers:

  • WebCore.xcodeproj/project.pbxproj:

Flesh out many of the pure virtual methods on IDBBackingStoreInterface, as well as
the RecordIdentifier and Cursor classes:

  • Modules/indexeddb/IDBBackingStoreInterface.h:

(WebCore::IDBBackingStoreInterface::RecordIdentifier::~RecordIdentifier):
(WebCore::IDBBackingStoreInterface::Cursor::~Cursor):

Use IDBBackingStoreInterface, IDBBackingStoreInterface::RecordIdentifier, and
IDBBackingStoreInterface::Cursor wherever possible:

  • Modules/indexeddb/IDBFactoryBackendInterface.cpp:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::IndexKeyCursorImpl::clone):
(WebCore::IndexCursorImpl::clone):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::Transaction::Transaction):
(WebCore::IDBBackingStoreLevelDB::Transaction::begin):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

(WebCore::IDBBackingStoreLevelDB::RecordIdentifier::RecordIdentifier):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:

(WebCore::IDBCursorBackendLevelDB::IDBCursorBackendLevelDB):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:

(WebCore::IDBCursorBackendLevelDB::create):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:

(WebCore::IDBDatabaseBackendLevelDB::create):
(WebCore::IDBDatabaseBackendLevelDB::IDBDatabaseBackendLevelDB):
(WebCore::IDBDatabaseBackendLevelDB::backingStore):
(WebCore::IDBDatabaseBackendLevelDB::setIndexKeys):
(WebCore::IDBDatabaseBackendLevelDB::createTransaction):

  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::createTransactionBackend):

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:

(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::verifyIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::addingKeyAllowed):
(WebCore::IDBObjectStoreBackendLevelDB::makeIndexWriters):
(WebCore::IDBObjectStoreBackendLevelDB::generateKey):
(WebCore::IDBObjectStoreBackendLevelDB::updateKeyGenerator):

  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:

(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:

(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):

  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:

(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):

Source/WebKit2:

Stub out a new pure virtual method:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::createTransactionBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
1:18 PM Changeset in webkit [157729] by zoltan@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Shapes][CSS Regions] Don't apply shape-inside when we have multiple auto-height regions and the height is not resolved
https://bugs.webkit.org/show_bug.cgi?id=123103

Reviewed by David Hyatt.

When we have multiple regions with auto-height, the region's height is not resolved from other elements we can't apply the
the shape on the region. This patch prevents to apply the shape and fixes the behavior for these cases.

Source/WebCore:

Test: fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutShapeInsideInfo):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateShapeAndSegmentsForCurrentLineInFlowThread):

LayoutTests:

  • fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-multiple-autoheight-regions.html: Added.
1:16 PM Changeset in webkit [157728] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Remote Layer Tree: Backing store should take contentsScale into account
https://bugs.webkit.org/show_bug.cgi?id=123106

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::ensureBackingStore):
(PlatformCALayerRemote::setNeedsDisplay):
(PlatformCALayerRemote::setContentsScale):
Inform the backing store of the contentsScale, and when it changes.

  • WebProcess/WebPage/mac/RemoteLayerBackingStore.h:

(WebKit::RemoteLayerBackingStore::scale): Added.
(WebKit::RemoteLayerBackingStore::mapToContentCoordinates): Added.

  • WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
(RemoteLayerBackingStore::mapToContentCoordinates):
Factor out flipping so we can use it for repaints in multiple places.

(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Create a buffer scaled up by contentsScale, take the scale into account
when copying clean bits from the front buffer, and apply the scale before
painting into the back buffer.

  • WebCore.exp.in:

Export FloatRect::scale.

1:15 PM Changeset in webkit [157727] by oliver@apple.com
  • 1 edit
    3 adds in trunk/Source/WebInspectorUI

Restore accidentally removed files.

1:10 PM Changeset in webkit [157726] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderScrollbarPart doesn't need styleWillChange().
<https://webkit.org/b/123113>

We will call setInline(false) in styleDidChange(), there's no need
to override styleWillChange() just to do it twice.

Reviewed by Darin Adler.

12:38 PM Changeset in webkit [157725] by commit-queue@webkit.org
  • 29 edits
    20 adds in trunk

[CSS Regions] The layers from the flow thread should be collected under the regions' layers.
https://bugs.webkit.org/show_bug.cgi?id=120457

Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by David Hyatt.

Source/WebCore:

This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review

The composited layers inside the named flow threads are collected as part of the regions (as children of the
GraphicsLayer of the layer that corresponds to the region (which is attached to the parent renderer of
RenderNameFlowFragment)).
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderLayerCompositor::computeRegionCompositingRequirements).

This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because
fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited
that only enables compositing for layers inside flow threads that collect the graphics layers under the regions.

Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under
the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's
parent renderer, not in the region renderer (RenderNamedFlowFragment).

Tests: compositing/regions/crash-transform-inside-region.html

compositing/regions/floated-region-with-transformed-child.html
compositing/regions/move-layer-from-one-region-to-another.html
compositing/regions/propagate-region-box-shadow-border-padding-for-video.html
compositing/regions/propagate-region-box-shadow-border-padding.html
compositing/regions/region-as-layer-in-another-flowthread.html
compositing/regions/transform-transparent-positioned-video-inside-region.html
compositing/regions/transformed-layer-inside-transformed-layer.html
compositing/regions/z-index-update.html
compositing/regions/z-index.html

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::collectsGraphicsLayersUnderRegions):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):

  • rendering/RenderFlowThread.h:
  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::pushRenderFlowThread):

  • rendering/RenderGeometryMap.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::enclosingFlowThreadAncestor):
(WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateLayerBounds): When we calculate the bounds of the RenderView, we ignore those
flow threads that collect the graphics layers under the regions.
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's a flow thread that collects the graphics
layers under the regions
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly if
we are going to collect the composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a container of a css region.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.h:

(WebCore::RenderNamedFlowFragment::layerOwner): When the content inside the region requires the region to have a
layer, the layer will be created on the region's parent renderer instead. This method returns that renderer
holding the layer. The return value may be null.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::collectsGraphicsLayersUnderRegions):

  • rendering/RenderNamedFlowThread.h: m_flowThreadChildList is now allocated through an OwnPtr to keep the render

arena under the size limit.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):

  • rendering/RenderRegion.h:

(WebCore::toRenderRegion):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • WebCore.exp.in: WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions

LayoutTests:

  • compositing/regions/crash-transform-inside-region-expected.html: Added.
  • compositing/regions/crash-transform-inside-region.html: Added.
  • compositing/regions/floated-region-with-transformed-child-expected.html: Added.
  • compositing/regions/floated-region-with-transformed-child.html: Added.
  • compositing/regions/move-layer-from-one-region-to-another-expected.html: Added.
  • compositing/regions/move-layer-from-one-region-to-another.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding-expected.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding-for-video.html: Added.
  • compositing/regions/propagate-region-box-shadow-border-padding.html: Added.
  • compositing/regions/region-as-layer-in-another-flowthread-expected.html: Added.
  • compositing/regions/region-as-layer-in-another-flowthread.html: Added.
  • compositing/regions/transform-transparent-positioned-video-inside-region-expected.html: Added.
  • compositing/regions/transform-transparent-positioned-video-inside-region.html: Added.
  • compositing/regions/transformed-layer-inside-transformed-layer-expected.html: Added.
  • compositing/regions/transformed-layer-inside-transformed-layer.html: Added.
  • compositing/regions/webkit-flow-renderer-layer-compositing-expected.html:
  • compositing/regions/webkit-flow-renderer-layer-compositing.html:
  • compositing/regions/z-index-expected.html: Added.
  • compositing/regions/z-index-update-expected.html: Added.
  • compositing/regions/z-index-update.html: Added.
  • compositing/regions/z-index.html: Added.
  • fast/multicol/mixed-positioning-stacking-order-expected.html:
  • fast/multicol/mixed-positioning-stacking-order.html:
  • fast/repaint/region-painting-composited-element-expected.html:
  • fast/repaint/region-painting-composited-element.html:
  • platform/mac-wk2/TestExpectations:
12:23 PM Changeset in webkit [157724] by oliver@apple.com
  • 10 edits
    3 adds in trunk

Source/JavaScriptCore: Support computed property names in object literals
https://bugs.webkit.org/show_bug.cgi?id=123112

Reviewed by Michael Saboff.

Add support for computed property names to the parser.

  • bytecompiler/NodesCodegen.cpp:

(JSC::PropertyListNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createProperty):
(JSC::ASTBuilder::getName):

  • parser/NodeConstructors.h:

(JSC::PropertyNode::PropertyNode):

  • parser/Nodes.h:

(JSC::PropertyNode::expressionName):
(JSC::PropertyNode::name):

  • parser/Parser.cpp:

(JSC::::parseProperty):
(JSC::::parseStrictObjectLiteral):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::Property::Property):
(JSC::SyntaxChecker::createProperty):
(JSC::SyntaxChecker::operatorStackPop):

LayoutTests: Support expression property names in object literals
https://bugs.webkit.org/show_bug.cgi?id=123112

Reviewed by Michael Saboff.

Add tests

  • js/basic-computed-property-name-expected.txt: Added.
  • js/basic-computed-property-name.html: Added.
  • js/parser-syntax-check-expected.txt:
  • js/script-tests/basic-computed-property-name.js: Added.

(a.string_appeared_here.runTest):

  • js/script-tests/parser-syntax-check.js:
12:02 PM Changeset in webkit [157723] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixing mediastream debug build
https://bugs.webkit.org/show_bug.cgi?id=123104

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-21
Reviewed by Andreas Kling.

No new tests needed.

  • Modules/mediastream/RTCDTMFToneChangeEvent.cpp:

(WebCore::RTCDTMFToneChangeEvent::create):

11:29 AM Changeset in webkit [157722] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Merge RenderListMarker::styleWillChange() into styleDidChange().
<https://webkit.org/b/123098>

If the marker's list-style-type or list-style-position changed, we
need to dirty the layout. Move this logic to styleDidChange() so we
can get rid of one styleWillChange() overload.

Reviewed by Antti Koivisto.

10:04 AM Changeset in webkit [157721] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test media/media-controller-time-clamp.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=123099

  • platform/mac/TestExpectations: Marking as such.
9:53 AM Changeset in webkit [157720] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

[CSS Regions] Fix WHITESPACE issues in the CSS grammar.
https://bugs.webkit.org/show_bug.cgi?id=123082

Patch by Mihai Maerean <Mihai Maerean> on 2013-10-21
Reviewed by Andreas Kling.

This is a port of Rune Lillesveen's patch from https://codereview.chromium.org/25607005

Source/WebCore:

Fix WHITESPACE issues in the CSS grammar.

A single WHITESPACE token consumes consecutive spaces, but does not consume
spaces separated by comments. That means S* and S+ in CSS grammars need to
accept multiple WHITESPACE tokens. Additionally, white spaces are not
mandatory to separate an @-symbol and the rest of the prelude.

Use space non-terminal instead of WHITESPACE for S+ in calc expressions.

Use maybe_space non-terminal instead of WHITESPACE for S* after @-webkit-filter
and @-webkit-region.

Tests: fast/css/calc-comments-allowed.html

fast/regions/webkit-region-syntax-space.html

  • css/CSSGrammar.y.in:

LayoutTests:

  • css3/filters/custom-with-at-rule-syntax/parsing-at-rule-valid-expected.txt:
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-at-rule-valid.js:
  • fast/css/calc-comments-allowed-expected.html: Added.
  • fast/css/calc-comments-allowed.html: Added.
  • fast/regions/webkit-region-syntax-space-expected.txt: Added.
  • fast/regions/webkit-region-syntax-space.html: Added.
8:41 AM Changeset in webkit [157719] by dbates@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Add option so that JSC will crash if it can't allocate executable memory for the JITs
https://bugs.webkit.org/show_bug.cgi?id=123048
<rdar://problem/12856193>

Patch by Michael Saboff <msaboff@apple.com> on 2013-10-21
Reviewed by Geoffrey Garen.

Added new option, called crashIfCantAllocateJITMemory. If this option is true then we crash
when checking the validity of the executable allocator. The default value for this option is
false, but jsc sets it to true when built for iOS to make it straightforward to identify whether
the app can obtain executable memory.

  • jsc.cpp: Explicitly enable crashIfCantAllocateJITMemory on iOS.

(main):

  • runtime/Options.h: Added option crashIfCantAllocateJITMemory.
  • runtime/VM.cpp:

(JSC::enableAssembler): Modified to crash if option crashIfCantAllocateJITMemory
is enabled.

7:02 AM Changeset in webkit [157718] by mario@webkit.org
  • 4 edits in trunk/Source/WebCore

[ATK] Use atk_object_notify_state_change instead of manually emitting signals
https://bugs.webkit.org/show_bug.cgi?id=122968

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-10-21
Reviewed by Mario Sanchez Prada.

Refactor emitting "state-change" event to use atk_object_notify_state_change
instead of using g_signal_emit_by_name.

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleDetach):

  • editing/atk/FrameSelectionAtk.cpp:

(WebCore::maybeEmitTextFocusChange):

2:53 AM Changeset in webkit [157717] by gyuyoung.kim@samsung.com
  • 5 edits in trunk/Source

Make TYPE_CASTS_BASE more flexible
https://bugs.webkit.org/show_bug.cgi?id=122951

Reviewed by Andreas Kling.

TYPE_CASTS_BASE is being used by node|element type casts. However, it is difficult
to be used by other type casts. For instance, CSSValue, Accessibility and so on.
This patch modifies TYPE_CASTS_BASE which can support other type casts.

Besides TYPE_CASTS_BASE body is moved from node.h to Assertions.h.

Source/WebCore:

No new tests, no behavior changes.

  • dom/Document.h:
  • dom/Node.h:

Source/WTF:

  • wtf/Assertions.h:
2:44 AM Changeset in webkit [157716] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Build does not start.
https://bugs.webkit.org/show_bug.cgi?id=123059

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.

The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.

  • Scripts/build-webkit:
2:43 AM Changeset in webkit [157715] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk

Remove .qmake.conf files
https://bugs.webkit.org/show_bug.cgi?id=123091

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Csaba Osztrogonác.

  • .qmake.conf: Removed.
2:32 AM Changeset in webkit [157714] by Csaba Osztrogonác
  • 1 edit
    1 delete in trunk/Source/JavaScriptCore

Remove AllInOneFile.cpp
https://bugs.webkit.org/show_bug.cgi?id=123055

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-21
Reviewed by Csaba Osztrogonác.

  • AllInOneFile.cpp: Removed.
2:31 AM Changeset in webkit [157713] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove qt from generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=123090

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-10-21
Reviewed by Andreas Kling.

  • Scripts/generate-forwarding-headers.pl:
2:00 AM Changeset in webkit [157712] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[Jhbuild] Bump the required Jhbuild revision
https://bugs.webkit.org/show_bug.cgi?id=123089

Reviewed by Carlos Garcia Campos.

  • jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild

due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
in the Jhbuild source so a more recent revision of it should be used.

1:57 AM Changeset in webkit [157711] by zandobersek@gmail.com
  • 4 edits in trunk/Source

[GTK] g-ir-scanner should use the configured C compiler
https://bugs.webkit.org/show_bug.cgi?id=123088

Reviewed by Carlos Garcia Campos.

Source/WebKit/gtk:

  • GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command

via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.

Source/WebKit2:

  • GNUmakefile.am: Pass the C compiler that was detected at configuration to the g-ir-scanner command

via the CC environment variable. This solves the issue of the scanner running the GCC compiler with
the Clang-specific CFLAGS.

12:11 AM Changeset in webkit [157710] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty
https://bugs.webkit.org/show_bug.cgi?id=122097

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

When remove format command is called we pushdown the ancestor style
down to its children. Currently applying inline style to iframe
while pushing down style which causes iframe to be reinserted in tree and
triggres again subframe loading which repeats everytime and finally
crash happens. So we should avoid applying inline style to iframe
element as it doesnot reflect in its content while pushing down style
on it.

And ASSERT call has been removed from setTextDecoration property as
the scenario is perfectly valid case.

Test: editing/execCommand/remove-format-textdecoration-in-iframe.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Return if
element is iframe.

  • editing/EditingStyle.cpp:

(WebCore::StyleChange::setTextDecorationProperty): Remove ASSERT.

LayoutTests:

Added Test cases to verify that crash does not happen in scenario when
remove format command is executed on selection containing the iframe
element and when textdecoration style is defined as !important and
need to pushDown to iframe.

  • editing/execCommand/remove-format-textdecoration-in-iframe-expected.txt: Added.
  • editing/execCommand/remove-format-textdecoration-in-iframe.html: Added.

Oct 20, 2013:

11:08 PM Changeset in webkit [157709] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Update EFL test expectations.

  • platform/efl/TestExpectations: Skip authentication tests that are failing.
10:14 PM Changeset in webkit [157708] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, cleanup a FIXME comment.

  • jit/Repatch.cpp:
9:48 PM Changeset in webkit [157707] by fpizlo@apple.com
  • 19 edits
    3 adds in trunk/Source

StructureStubInfo's usedRegisters set should be able to track all registers, not just the ones that our JIT's view as temporaries
https://bugs.webkit.org/show_bug.cgi?id=123076

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Start preparing for a world in which we are patching code generated by LLVM, which may have
very different register usage conventions than our JITs. This requires us being more explicit
about the registers we are using. For example, the repatching code shouldn't take for granted
that tagMaskRegister holds the TagMask or that the register is even in use.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::numberOfRegisters):
(JSC::MacroAssembler::registerIndex):
(JSC::MacroAssembler::numberOfFPRegisters):
(JSC::MacroAssembler::fpRegisterIndex):
(JSC::MacroAssembler::totalNumberOfRegisters):

  • bytecode/StructureStubInfo.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::usedRegisters):

  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLSaveRestore.cpp:

(JSC::FTL::bytesForGPRs):
(JSC::FTL::bytesForFPRs):
(JSC::FTL::offsetOfGPR):
(JSC::FTL::offsetOfFPR):

  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdGenerator::JITGetByIdGenerator):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/RegisterSet.cpp: Added.

(JSC::RegisterSet::specialRegisters):

  • jit/RegisterSet.h: Added.

(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::set):
(JSC::RegisterSet::clear):
(JSC::RegisterSet::get):
(JSC::RegisterSet::merge):

  • jit/Repatch.cpp:

(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::tryRepatchIn):
(JSC::linkClosureCall):

  • jit/TempRegisterSet.cpp: Added.

(JSC::TempRegisterSet::TempRegisterSet):

  • jit/TempRegisterSet.h:

Source/WTF:

Reviewed by Sam Weinig.

Teach BitVector how to efficiently merge (i.e. bitvector |=).

  • wtf/BitVector.cpp:

(WTF::BitVector::mergeSlow):

  • wtf/BitVector.h:

(WTF::BitVector::merge):
(WTF::BitVector::cleanseInlineBits):

6:02 PM Changeset in webkit [157706] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Update EFL test expectations.

  • platform/efl/TestExpectations: Mark fast/workers/worker-call.html as failure.
3:57 PM Changeset in webkit [157705] by weinig@apple.com
  • 9 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 5)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Antti Koivisto.

  • Move m_lineBoxes to RenderBlockFlow.
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::innerTextIfTruncated):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::isSelfCollapsingBlock):
(WebCore::RenderBlock::removeFromDelayedUpdateScrollInfoSet):
(WebCore::RenderBlock::paintContents):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::hitTestContents):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::inlineBlockBaseline):
(WebCore::RenderBlock::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlock::addFocusRingRects):
(WebCore::RenderBlock::showLineTreeAndMark):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::addOverflowFromInlineChildren):
(WebCore::RenderBlock::hasInlineBoxChildren):
(WebCore::RenderBlock::paintInlineChildren):
(WebCore::RenderBlock::hitTestInlineChildren):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::deleteLineBoxTree):
(WebCore::RenderBlockFlow::hitTestInlineChildren):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
(WebCore::RenderBlockFlow::markLinesDirtyInBlockRange):
(WebCore::RenderBlockFlow::firstLineBoxBaseline):
(WebCore::RenderBlockFlow::inlineBlockBaseline):
(WebCore::RenderBlockFlow::inlineSelectionGaps):
(WebCore::RenderBlockFlow::positionForBox):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::paintInlineChildren):
(WebCore::RenderBlockFlow::relayoutForPagination):
(WebCore::RenderBlockFlow::showLineTreeAndMark):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::lineBoxes):
(WebCore::RenderBlockFlow::firstLineBox):
(WebCore::RenderBlockFlow::lastLineBox):
(WebCore::RenderBlockFlow::firstRootBox):
(WebCore::RenderBlockFlow::lastRootBox):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::addOverflowFromInlineChildren):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):

11:33 AM Changeset in webkit [157704] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Avoid unnecessary vector copy in AnimationController event dispatch.
<https://webkit.org/b/122994>

Use Vector's move constructor instead of making a copy of the pending
events queue and then clearing it.

Reviewed by Simon Fraser.

9:36 AM Changeset in webkit [157703] by beidson@apple.com
  • 11 edits
    1 add in trunk/Source/WebCore

Add abstract IDBBackingStoreInterface, use it to get IDBDatabaseBackendLevelDB closer to going cross-platform
https://bugs.webkit.org/show_bug.cgi?id=123074

Reviewed by Andreas Kling.

  • Modules/indexeddb/IDBBackingStoreInterface.h: Added.

(WebCore::IDBBackingStoreInterface::~IDBBackingStoreInterface):
(WebCore::IDBBackingStoreInterface::Transaction::~Transaction):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

(WebCore::IDBBackingStoreLevelDB::Transaction::reset):
(WebCore::IDBBackingStoreLevelDB::Transaction::levelDBTransactionFrom):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:

(WebCore::IDBCursorBackendLevelDB::deleteFunction):

  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:

(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::verifyIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::writeIndexKeys):
(WebCore::IDBObjectStoreBackendLevelDB::IndexWriter::addingKeyAllowed):

  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:

(WebCore::IDBTransactionBackendLevelDB::backingStoreTransaction):

  • WebCore.xcodeproj/project.pbxproj:
  • GNUmakefile.list.am:
9:12 AM Changeset in webkit [157702] by akling@apple.com
  • 17 edits in trunk/Source

Use PassRef for StyleSheetContents.
<https://webkit.org/b/123083>

Let functions that return newly-constructed StyleSheetContents
objects vend PassRef<StyleSheetContents> instead of PassRefPtr.

Updated functions that take StyleSheetContents in arguments
accordingly. And CSSStyleSheet now has a Ref internally. Woo!

Reviewed by Antti Koivisto.

8:43 AM Changeset in webkit [157701] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

[Cocoa] Loading progress API
https://bugs.webkit.org/show_bug.cgi?id=123069

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKBrowsingContextController.h: Declared estimatedProgress property.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController estimatedProgress]): Added.
(didStartProgress): Added. Calls new delegate method
-browsingContextControllerDidStartProgress:.
(didChangeProgress): Added. Calls new delegate method
-browsingContextController:estimatedProgressChangedTo:.
(didFinishProgress): Added. Calls new delegate method
-browsingContextControllerDidFinishProgress:.
(setUpPageLoaderClient): Hook up new client functions.

  • UIProcess/API/mac/WKBrowsingContextLoadDelegate.h: Declared new delegate methods.
7:14 AM Changeset in webkit [157700] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Removing "unused parameter" compiling warnings from WebKit2 and WebCore
https://bugs.webkit.org/show_bug.cgi?id=123075

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-10-20
Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

  • Modules/mediastream/RTCDTMFToneChangeEvent.cpp:

(WebCore::RTCDTMFToneChangeEvent::create):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(lineAtPositionForAtkBoundary):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):

Source/WebKit2:

  • NetworkProcess/NetworkProcessPlatformStrategies.cpp:

(WebKit::NetworkProcessPlatformStrategies::loadResourceSynchronously):

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetPluginSiteDataManager):

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorUsesWebKitUserInterface):
(WKPreferencesGetInspectorUsesWebKitUserInterface):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPlugins):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetFullScreenClient):
(WKBundlePageWillEnterFullScreen):
(WKBundlePageDidEnterFullScreen):
(WKBundlePageWillExitFullScreen):
(WKBundlePageDidExitFullScreen):

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::clearCacheForHostname):

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteAllEntries):
(WebKit::WebOriginDataManager::startObservingChanges):
(WebKit::WebOriginDataManager::stopObservingChanges):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin):
(WebKit::WebFrameLoaderClient::recreatePlugin):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::canPluginHandleResponse):

4:06 AM Changeset in webkit [157699] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Fix build (broken since r157690).
https://bugs.webkit.org/show_bug.cgi?id=123081

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-20
Reviewed by Andreas Kling.

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::buffer):
(JSC::SH4Assembler::readCallTarget):

3:49 AM Changeset in webkit [157698] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Use PassRef for constructing StyleRules.
<https://webkit.org/b/123072>

Let functions that return newly-constructed StyleRuleFoo objects
vend PassRef<StyleRuleFoo> instead of PassRefPtr.

Since StyleRuleBase::copy() has to return something, we can't rely
on ASSERT_NOT_REACHED() + return nullptr anymore, so I've replaced
those with CRASH(). No call sites actually handled null anyway.

Reviewed by Sam Weinig.

Oct 19, 2013:

10:42 PM Changeset in webkit [157697] by jer.noble@apple.com
  • 9 edits
    1 delete in trunk

Unreviewed roll out of r157695; broke Mac builds.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

  • platform/mac/js/dom/global-constructors-attributes-expected.txt: Removed.
10:40 PM Changeset in webkit [157696] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Simplify TempRegisterSet - it no longer needs to be convertible to a POD since it's no longer going to be a member of a union
https://bugs.webkit.org/show_bug.cgi?id=123079

Reviewed by Geoffrey Garen.

  • jit/TempRegisterSet.h:
9:58 PM Changeset in webkit [157695] by jer.noble@apple.com
  • 9 edits
    1 add in trunk

[MSE] [Mac] Enable MediaSource on the Mac
https://bugs.webkit.org/show_bug.cgi?id=122484

Reviewed by Darin Adler.

Source/WebCore:

Enable ENABLE_MEDIA_SOURCE.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Enable ENABLE_MEDIA_SOURCE.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable ENABLE_MEDIA_SOURCE.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Enable ENABLE_MEDIA_SOURCE.

  • wtf/FeatureDefines.h:

LayoutTests:

  • platform/mac/js/dom/global-constructors-attributes-expected.txt: Added.
9:55 PM Changeset in webkit [157694] by weinig@apple.com
  • 19 edits in trunk/Source/WebCore

CTTE: Tighten up type usage around InputType::innerTextElement()
https://bugs.webkit.org/show_bug.cgi?id=123078

Reviewed by Anders Carlsson.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):

  • html/HTMLElement.h:

(WebCore::HTMLElement::isTextControlInnerTextElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::innerTextElement):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement):

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::hasVisibleTextArea):
(WebCore::HTMLTextFormControlElement::selection):
(WebCore::HTMLTextFormControlElement::innerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks):

  • html/HTMLTextFormControlElement.h:
  • html/InputType.h:

(WebCore::InputType::innerTextElement):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::innerTextElement):

  • html/TextFieldInputType.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerTextElement::renderer):

  • html/shadow/TextControlInnerElements.h:

(WebCore::isTextControlInnerTextElement):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isTextControlInnerBlock):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::innerTextElement):
(WebCore::RenderTextControl::styleDidChange):
(WebCore::RenderTextControl::textBlockLogicalWidth):
(WebCore::RenderTextControl::updateFromElement):
(WebCore::RenderTextControl::computeLogicalHeight):
(WebCore::RenderTextControl::hitInnerTextElement):

  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
(WebCore::RenderTextControlSingleLine::styleDidChange):
(WebCore::RenderTextControlSingleLine::autoscroll):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):

  • rendering/RenderTextControlSingleLine.h:

(WebCore::toRenderTextControlInnerBlock):

9:12 PM Changeset in webkit [157693] by fpizlo@apple.com
  • 11 edits
    1 move in trunk/Source/JavaScriptCore

Rename RegisterSet to TempRegisterSet
https://bugs.webkit.org/show_bug.cgi?id=123077

Reviewed by Dan Bernstein.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/StructureStubInfo.h:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::usedRegisters):

  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdGenerator::JITGetByIdGenerator):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/RegisterSet.h: Removed.
  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):

  • jit/TempRegisterSet.h: Copied from Source/JavaScriptCore/jit/RegisterSet.h.

(JSC::TempRegisterSet::TempRegisterSet):
(JSC::TempRegisterSet::asPOD):
(JSC::TempRegisterSet::copyInfo):

8:51 PM Changeset in webkit [157692] by ap@apple.com
  • 2 edits in trunk/Tools

Mac build fix.

  • DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
8:15 PM Changeset in webkit [157691] by ap@apple.com
  • 11 edits
    3 copies in trunk

Enable webaudio/ tests on DRT/Mac
https://bugs.webkit.org/show_bug.cgi?id=86914

Reviewed by Darin Adler.

Tools:

  • DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
  • DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
  • DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.

There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.

  • DumpRenderTree/TestRunner.cpp:

(setAudioResultCallback):
(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner::audioResult):
(TestRunner::setAudioResult):
The function has a different name and argument type now, updated accordingly.
Changed buffer from std::string to std::vector<char>, because it's more idiomatic.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpAudio): Updated for the new name of audioResult accessor.
(dump): Print the result in the format webkitpy currently expects.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
chunks made no sense.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.

  • DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,

so that "SourceProvider.h" can be found.

LayoutTests:

  • TestExpectations: Moved webaudio/javascriptaudionode here, as garbage collection

issues with it are cross-platform.

  • platform/mac-wk2/TestExpectations: Moved out everything, as there is nothing

WK2 specific about WebAudio.

  • platform/mac/TestExpectations: WebAudio expectations here were just ignored. Replaced

with slightly updated expectations from WK2.

7:07 PM Changeset in webkit [157690] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Restructure LinkBuffer to allow for alternate allocation strategies
https://bugs.webkit.org/show_bug.cgi?id=123071

Reviewed by Oliver Hunt.

The idea is to eventually allow a LinkBuffer to place the code into an already
allocated region of memory. That region of memory could be the nop-slide left behind
by a llvm.webkit.patchpoint.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::buffer):

  • assembler/AssemblerBuffer.h:
  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):
(JSC::LinkBuffer::shrink):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::didFailToAllocate):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::buffer):
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM):

5:24 PM Changeset in webkit [157689] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Adding test case for text-decoration property state change on applying different command
https://bugs.webkit.org/show_bug.cgi?id=123073

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-10-19
Reviewed by Ryosuke Niwa.

This test case verify text-decoration property state on element after
applying editing commands related to text-decoration.

  • editing/style/text-decoration-state-change-expected.txt: Added.
  • editing/style/text-decoration-state-change.html: Added.
5:01 PM Changeset in webkit [157688] by ap@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Some includes in JSC seem to use an incorrect style
https://bugs.webkit.org/show_bug.cgi?id=123057

Reviewed by Geoffrey Garen.

Changed pseudo-system includes to user ones.

  • API/JSContextRef.cpp:
  • API/JSStringRefCF.cpp:
  • API/JSValueRef.cpp:
  • API/OpaqueJSString.cpp:
  • jit/JIT.h:
  • parser/SyntaxChecker.h:
  • runtime/WeakGCMap.h:
4:38 PM Changeset in webkit [157687] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-webkit-tests should submit time and modifiers to the new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123070

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
in the test expectations when this argument is set to true.

4:18 PM Changeset in webkit [157686] by ap@apple.com
  • 3 edits in trunk/Tools

Mac DumpRenderTree builds without NDEBUG even in release mode
https://bugs.webkit.org/show_bug.cgi?id=123066

Reviewed by Dan Bernstein.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/Base.xcconfig:

Use the same pattern as WebCore and WebKitTestRunner.

4:13 PM Changeset in webkit [157685] by fpizlo@apple.com
  • 18 edits
    4 adds in trunk/Source/JavaScriptCore

Baseline JIT and DFG IC code generation should be unified and rationalized
https://bugs.webkit.org/show_bug.cgi?id=122939

Reviewed by Geoffrey Garen.

Introduce the JITInlineCacheGenerator, which takes a CodeBlock and a CodeOrigin plus
some register info and creates JIT inline caches for you. Used this to even furhter
unify the baseline and DFG ICs. In the future we can use this for FTL ICs. And my hope
is that we'll be able to use it for cascading ICs: an IC for some instruction may realize
that it needs to do the equivalent of get_by_id, so with this generator it will be able
to create an IC even though it wasn't associated with a get_by_id bytecode instruction.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::DataLabelCompact::label):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::ecmaMode):

  • dfg/DFGInlineCacheWrapper.h: Added.

(JSC::DFG::InlineCacheWrapper::InlineCacheWrapper):

  • dfg/DFGInlineCacheWrapperInlines.h: Added.

(JSC::DFG::::finalize):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addGetById):
(JSC::DFG::JITCompiler::addPutById):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compile):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::isStrictModeFor):
(JSC::AssemblyHelpers::strictModeFor):

  • jit/GPRInfo.h:

(JSC::JSValueRegs::tagGPR):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITInlineCacheGenerator.cpp: Added.

(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastPathChecks):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::slowPathFunction):

  • jit/JITInlineCacheGenerator.h: Added.

(JSC::JITInlineCacheGenerator::JITInlineCacheGenerator):
(JSC::JITInlineCacheGenerator::stubInfo):
(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITByIdGenerator::reportSlowPathCall):
(JSC::JITByIdGenerator::slowPathJump):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):

  • jit/RegisterSet.h:

(JSC::RegisterSet::set):

2:56 PM Changeset in webkit [157684] by ap@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

APICast.h uses functions from JSCJSValueInlines.h, but doesn't include it
https://bugs.webkit.org/show_bug.cgi?id=123067

Reviewed by Geoffrey Garen.

  • API/APICast.h: Include it.
2:43 PM Changeset in webkit [157683] by weinig@apple.com
  • 20 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Andreas Kling.

  • Fix classes derived from RenderBlockFlow that were still calling up to RenderBlock rather than RenderBlockFlow.
  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::paint):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::computePreferredLogicalWidths):
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintMask):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::styleDidChange):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::nodeAtPoint):

  • rendering/RenderFullScreen.cpp:

(RenderFullScreenPlaceholder::willBeDestroyed):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::styleDidChange):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::styleDidChange):
(WebCore::RenderMultiColumnBlock::updateLogicalWidthAndColumnWidth):
(WebCore::RenderMultiColumnBlock::addChild):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::updateFromElement):

  • rendering/RenderRuby.cpp:

(WebCore::RenderRubyAsBlock::styleDidChange):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::removeChild):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::removeChild):
(WebCore::RenderRubyRun::layout):

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::textAlignmentForLine):
(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):

  • rendering/RenderTableCaption.cpp:

(WebCore::RenderTableCaption::willBeRemovedFromTree):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::willBeRemovedFromTree):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
(WebCore::RenderTableCell::offsetFromContainer):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::styleDidChange):
(WebCore::RenderTableCell::borderLeft):
(WebCore::RenderTableCell::borderRight):
(WebCore::RenderTableCell::borderTop):
(WebCore::RenderTableCell::borderBottom):
(WebCore::RenderTableCell::borderStart):
(WebCore::RenderTableCell::borderEnd):
(WebCore::RenderTableCell::borderBefore):
(WebCore::RenderTableCell::borderAfter):
(WebCore::RenderTableCell::paint):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scrollWidth):
(WebCore::RenderTextControlSingleLine::scrollHeight):
(WebCore::RenderTextControlSingleLine::scrollLeft):
(WebCore::RenderTextControlSingleLine::scrollTop):
(WebCore::RenderTextControlSingleLine::scroll):
(WebCore::RenderTextControlSingleLine::logicalScroll):

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::layout):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layoutContent):
(WebCore::RenderView::addChild):
(WebCore::RenderView::visualOverflowRect):
(WebCore::RenderView::styleDidChange):

  • rendering/svg/RenderSVGBlock.cpp:

(WebCore::RenderSVGBlock::setStyle):
(WebCore::RenderSVGBlock::updateFromStyle):
(WebCore::RenderSVGBlock::willBeDestroyed):
(WebCore::RenderSVGBlock::styleWillChange):
(WebCore::RenderSVGBlock::styleDidChange):

  • rendering/svg/SVGTextQuery.cpp:

(WebCore::flowBoxForRenderer):

2:25 PM Changeset in webkit [157682] by zandobersek@gmail.com
  • 24 edits
    3 adds in trunk/Tools

REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
https://bugs.webkit.org/show_bug.cgi?id=123064

Reviewed by Ryosuke Niwa.

Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.

  • Scripts/webkitpy/common/config/ports.py: Added.

(DeprecatedPort):
(DeprecatedPort.name):
(DeprecatedPort.flag):
(DeprecatedPort.script_path):
(DeprecatedPort.script_shell_command):
(DeprecatedPort.port):
(DeprecatedPort.makeArgs):
(DeprecatedPort.update_webkit_command):
(DeprecatedPort.check_webkit_style_command):
(DeprecatedPort.prepare_changelog_command):
(DeprecatedPort.build_webkit_command):
(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort.run_webkit_unit_tests_command):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_perl_unittests_command):
(DeprecatedPort.run_bindings_tests_command):
(MacPort):
(MacWK2Port):
(MacWK2Port.run_webkit_tests_command):
(WinPort):
(WinPort.run_bindings_tests_command):
(GtkPort):
(GtkPort.build_webkit_command):
(GtkPort.run_webkit_tests_command):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):
(QtPort):
(QtPort.build_webkit_command):
(QtPort.run_webkit_tests_command):
(QtWK2Port):
(QtWK2Port.build_webkit_command):
(QtWK2Port.run_webkit_tests_command):
(EflPort):
(EflPort.build_webkit_command):
(EflWK2Port):
(EflWK2Port.build_webkit_command):

  • Scripts/webkitpy/common/config/ports_mock.py: Added.

(MockPort):
(MockPort.name):
(MockPort.check_webkit_style_command):
(MockPort.update_webkit_command):
(MockPort.build_webkit_command):
(MockPort.prepare_changelog_command):
(MockPort.run_python_unittests_command):
(MockPort.run_perl_unittests_command):
(MockPort.run_javascriptcore_tests_command):
(MockPort.run_webkit_unit_tests_command):
(MockPort.run_webkit_tests_command):
(MockPort.run_bindings_tests_command):

  • Scripts/webkitpy/common/config/ports_unittest.py: Added.

(DeprecatedPortTest):
(DeprecatedPortTest.test_mac_port):
(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_gtk_wk2_port):
(DeprecatedPortTest.test_efl_port):
(DeprecatedPortTest.test_qt_port):
(DeprecatedPortTest.test_qt_wk2_port):

  • Scripts/webkitpy/port/base.py:

(Port._port_flag_for_scripts):
(Port._wk2_port_name):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_build_path):

  • Scripts/webkitpy/port/efl_unittest.py:

(EflPortTest.test_show_results_html_file):

  • Scripts/webkitpy/port/gtk_unittest.py:

(GtkPortTest.test_get_crash_log):

  • Scripts/webkitpy/port/mac_unittest.py:

(test_64bit):

  • Scripts/webkitpy/port/test.py:

(TestPort.virtual_test_suites):

  • Scripts/webkitpy/tool/bot/flakytestreporter.py:

(FlakyTestReporter.init):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout._update_working_copy):

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.run_command):

  • Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue.begin_work_queue):
(CommitQueue.run_command):

  • Scripts/webkitpy/tool/main.py:

(WebKitPatch.init):
(WebKitPatch.deprecated_port):
(WebKitPatch.handle_global_options):

  • Scripts/webkitpy/tool/mocktool.py:

(MockTool.init):
(MockTool.deprecated_port):

  • Scripts/webkitpy/tool/steps/build.py:

(Build.build):

  • Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle.run):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):

  • Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.run):

  • Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:

(PrepareChangeLogForRevert.run):

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

  • Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):

  • Scripts/webkitpy/tool/steps/update.py:

(Update._update_command):

  • Scripts/webkitpy/tool/steps/update_unittest.py:

(UpdateTest.test_update_command_non_interactive):
(UpdateTest.test_update_command_interactive):

2:09 PM Changeset in webkit [157681] by mitz@apple.com
  • 20 edits in trunk/Source/WebKit2

Fix the Mac 32-bit build by reverting r157676, r157678, and r157679.

2:03 PM Changeset in webkit [157680] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL::Location should treat the offset as an addend in the case of a Register location
https://bugs.webkit.org/show_bug.cgi?id=123062

Reviewed by Sam Weinig.

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::forStackmaps):
(JSC::FTL::Location::dump):
(JSC::FTL::Location::restoreInto):

  • ftl/FTLLocation.h:

(JSC::FTL::Location::forRegister):
(JSC::FTL::Location::hasAddend):
(JSC::FTL::Location::addend):

1:56 PM Changeset in webkit [157679] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix the Mac 32-bit build.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:
1:47 PM Changeset in webkit [157678] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

Try to fix the Mac 32-bit build.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/mac/WKViewPrivate.h:
1:26 PM Changeset in webkit [157677] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 3)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Andreas Kling.

  • Move containsNonZeroBidiLevel to RenderBlockFlow.
  • editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::containsNonZeroBidiLevel):

  • rendering/RenderBlockFlow.h:
1:18 PM Changeset in webkit [157676] by mitz@apple.com
  • 14 edits in trunk/Source/WebKit2

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKBrowsingContextController.h: Added WK_API_ENABLED guard. Removed _data

ivar and WKBrowsingContextControllerData class declaration.

  • UIProcess/API/mac/WKBrowsingContextController.mm: Added WK_API_ENABLED guard. Removed

WKBrowsingContextControllerData class and moved _pageRef ivar directly into
WKBrowsingContextController, declaring it in the @implementation. Removed ivar and accessors
for the loadDelegate property, letting the compiler synthesize them.
(-[WKBrowsingContextController dealloc]): Removed indirection via _data.
(-[WKBrowsingContextController _pageRef]): Ditto.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Added WK_API_ENABLED guard.
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
  • UIProcess/API/mac/WKBrowsingContextGroup.h: Added WK_API_ENABLED guard. Removed _data ivar

and WKBrowsingContextGroupData class declaration.

  • UIProcess/API/mac/WKBrowsingContextGroup.mm: Added WK_API_ENABLED guard. Removed

WKBrowsingContextGroupData class and moved _pageGroupRef ivar directly info
WKBrowsingContextGroup, declaring it in the @implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup _pageGroupRef]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Added WK_API_ENABLED guard.
  • UIProcess/API/mac/WKConnection.h: Added WK_API_ENABLED guard. Removed _data ivar and

WKConnectionData class declaration.

  • UIProcess/API/mac/WKConnection.mm: Added WK_API_ENABLED guard. Removed WKConnectionData

class and moved _connectionRef ivar directly into WKConnection, declaring it in the
@implementation. Removed ivar and accessors for the delegate property, letting the compiler
synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.

  • UIProcess/API/mac/WKConnectionInternal.h: Added WK_API_ENABLED guard.
  • UIProcess/API/mac/WKProcessGroup.h: Added WK_API_ENABLED guard. Replaced forward

declaration of WKConnection with an import. Removed _data ivar and WKProcessGroupData class
declaration.

  • UIProcess/API/mac/WKProcessGroup.mm: Added WK_API_ENABLED guard. Removed

WKProcessGroupData class and moved _contextRef ivar directly into WKProcessGroup, declaring
it in the @implementation. Removed ivar and accessors for the delegate property, letting the
compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.

  • UIProcess/API/mac/WKProcessGroupPrivate.h: Added WK_API_ENABLED guard.
1:11 PM Changeset in webkit [157675] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

DFG dominators: document and rename stuff.
https://bugs.webkit.org/show_bug.cgi?id=123056

Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-19
Reviewed by Filip Pizlo.

Documented the code and renamed some variables.

  • dfg/DFGDominators.cpp:

(JSC::DFG::Dominators::compute):
(JSC::DFG::Dominators::pruneDominators):

  • dfg/DFGDominators.h:
12:55 PM Changeset in webkit [157674] by weinig@apple.com
  • 9 edits in trunk/Source/WebCore

Move m_lineBoxes from RenderBlock to RenderBlockFlow (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=122969

Reviewed by Antti Koivisto.

  • Move truncation (e.g. line clamp and ellipse) support to RenderBlockFlow.
  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::EllipsisBox):
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::markupBox):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):

  • rendering/EllipsisBox.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::shouldCheckLines):
(WebCore::RenderBlockFlow::lineAtIndex):
(WebCore::RenderBlockFlow::lineCount):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlockFlow::heightForLineCount):
(WebCore::RenderBlockFlow::clearTruncation):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):

12:55 PM Changeset in webkit [157673] by akling@apple.com
  • 4 edits in trunk

RefPtr::releaseNonNull() incorrectly increments the refcount.
<https://webkit.org/b/123063>

Source/WTF:

Make releaseNonNull() use adoptRef(T&), mirroring release().

Reviewed by Anders Carlsson.

Tools:

Add an API test to verify that no extra refs are added when calling
RefPtr::releaseNonNull().

Reviewed by Anders Carlsson.

9:48 AM Changeset in webkit [157672] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

StyleResolver should deal in PassRef<RenderStyle> where possible.
<https://webkit.org/b/123061>

Make StyleResolver functions that returned or took RenderStyles
by PassRefPtr use PassRef instead where possible.

Reviewed by Anders Carlsson.

9:41 AM Changeset in webkit [157671] by beidson@apple.com
  • 16 edits in trunk/Source/WebCore

Global rename of the class "IDBBackingStore" to "IDBBackingStoreLevelDB"

Rubberstamped by Anders Carlsson (And Andreas Kling wanted to, but he wasn’t around)

  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.cpp:
  • Modules/indexeddb/leveldb/IDBTransactionBackendLevelDBOperations.h:
9:41 AM Changeset in webkit [157670] by ap@apple.com
  • 1 edit
    2 copies
    1 add
    1 delete in trunk/LayoutTests

WebAudio Mac expected results were misplaced - they apply equally to WK1 and WK2.
We didn't notice before because all these tests are disabled on WK1.

  • platform/mac-wk2/webaudio: Removed.
  • platform/mac/webaudio: Added.
  • platform/mac/webaudio/audiobuffersource-playbackrate-expected.wav: Copied from LayoutTests/platform/mac-wk2/webaudio/audiobuffersource-playbackrate-expected.wav.
  • platform/mac/webaudio/codec-tests: Copied from LayoutTests/platform/mac-wk2/webaudio/codec-tests.
  • platform/mac-wk2/webaudio/audiobuffersource-loop-points-expected.wav: Removed.

This test is skipped, because it times out.

7:42 AM Changeset in webkit [157669] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

[WinCairo] Link fails.
https://bugs.webkit.org/show_bug.cgi?id=123019

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-10-19
Reviewed by Darin Adler.

Added empty CertificateInfo implementation for Curl.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • platform/network/curl/CertificateInfoCurl.cpp: Added.

(WebCore::CertificateInfo::CertificateInfo):
(WebCore::CertificateInfo::~CertificateInfo):

7:34 AM Changeset in webkit [157668] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Fix build failure for architectures with 4 argument registers.
https://bugs.webkit.org/show_bug.cgi?id=123060

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-19
Reviewed by Michael Saboff.

Add missing setupArgumentsWithExecState() prototypes for architecture with 4 argument registers.
Remove SH4 specific code no longer needed since callOperation prototype change in r157660.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

7:33 AM Changeset in webkit [157667] by fpizlo@apple.com
  • 3 edits in trunk/Source/WebCore

libWebCoreTestSupport should have explicit exports
https://bugs.webkit.org/show_bug.cgi?id=123053

Reviewed by Oliver Hunt.

No new tests because there is no change in behavior.

  • Configurations/WebCoreTestSupport.xcconfig:
  • testing/js/WebCoreTestSupport.h:
7:26 AM Changeset in webkit [157666] by akling@apple.com
  • 4 edits in trunk/Source

Attempt to get Lion building.

Source/WebKit/mac:

  • WebView/WebDataSource.mm:

Source/WebKit2:

  • UIProcess/mac/WebColorPickerMac.h:
6:58 AM Changeset in webkit [157665] by akling@apple.com
  • 48 edits in trunk/Source

Start passing RenderStyle around with PassRef.
<https://webkit.org/b/123051>

Source/WebCore:

Made the RenderStyle::create methods return PassRef<RenderStyle>
and RenderElement::setStyle take a PassRef<RenderStyle>.

Reviewed by Darin Adler.

Source/WTF:

Added some new PassRef tricks to make this patch possible.

Reviewed by Darin Adler.

  • wtf/PassRef.h:

(WTF::PassRef::get):

Added a get() helper to facilitate writing functions that
construct a new object and call some functions on it before
returning it.

(WTF::PassRef::dropRef):

This will deref() the referenced object and mark the PassRef
as "passed." This is used in code paths where the PassRef is
going to go out of scope with nobody to take it over.

(WTF::PassRef::leakRef):

Renamed takeReference() to leakRef() and made it public so
we don't have to awkwardly sink the PassRef into a Ref for
e.g static locals.

  • wtf/RefPtr.h:

(WTF::RefPtr::releaseNonNull):

Added RefPtr::releaseNonNull() for a convenient way of creating
a PassRef<T> from a RefPtr<T>. This function may only be called
if the RefPtr is known to be non-null.

Note: See TracTimeline for information about the timeline view.