Timeline
Nov 4, 2013:
- 11:55 PM Changeset in webkit [158654] by
-
- 21 edits2 copies4 adds in trunk/Source
IDB: Split backend Cursors and Transactions into their own files
https://bugs.webkit.org/show_bug.cgi?id=123789
Reviewed by Alexey Proskuryakov.
Source/WebCore:
No new tests (Rename, no change in behavior).
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBBackingStoreCursorInterface.h:
(WebCore::IDBBackingStoreCursorInterface::~IDBBackingStoreCursorInterface):
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/IDBBackingStoreTransactionInterface.h: Added.
(WebCore::IDBBackingStoreTransactionInterface::~IDBBackingStoreTransactionInterface):
- Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
- Modules/indexeddb/IDBCursorBackendImpl.h:
(WebCore::IDBCursorBackendImpl::create):
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/IDBIndexWriter.cpp:
(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):
- Modules/indexeddb/IDBIndexWriter.h:
- Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::createCursorBackend):
- Modules/indexeddb/IDBTransactionBackendImpl.h:
- Modules/indexeddb/IDBTransactionBackendInterface.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
- Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.cpp: Added.
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::firstSeek):
(WebCore::IDBBackingStoreCursorLevelDB::advance):
(WebCore::IDBBackingStoreCursorLevelDB::continueFunction):
(WebCore::IDBBackingStoreCursorLevelDB::haveEnteredRange):
(WebCore::IDBBackingStoreCursorLevelDB::isPastBounds):
- Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h: Added.
(WebCore::IDBBackingStoreCursorLevelDB::~IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::compareIndexKeys):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::ObjectStoreKeyCursorImpl::create):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreCursorImpl::create):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp: Added.
(WebCore::IDBBackingStoreTransactionLevelDB::IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::begin):
(WebCore::IDBBackingStoreTransactionLevelDB::commit):
(WebCore::IDBBackingStoreTransactionLevelDB::rollback):
- Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
Source/WebKit2:
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::createCursorBackend):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- 11:09 PM Changeset in webkit [158653] by
-
- 2 edits in trunk/Source/JavaScriptCore
internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778
Unreviewed, remove the other such assertion.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 11:05 PM Changeset in webkit [158652] by
-
- 7 edits in trunk
DumpRenderTree should reset its preferences file on launch
https://bugs.webkit.org/show_bug.cgi?id=29751
Reviewed by Dan Bernstein.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in DRT was through argument domain.
Source/WebKit2:
- UIProcess/mac/WKFullKeyboardAccessWatcher.mm:
(-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in WTR was through argument domain.
Tools:
Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
and CFPreferencesCopyAppValue family of functions, it doesn't work with
CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).
So, now we'll just set defaults in the current application.
- DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
- Delete the defaults.
- Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
- The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
- WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):
Switched to -setValuesForKeysWithDictionary for consistency.
- 11:04 PM Changeset in webkit [158651] by
-
- 2 edits in trunk/Source/WebCore
Do not call setFrameRect on Widget unless its boundaries changed.
https://bugs.webkit.org/show_bug.cgi?id=123781
Reviewed by Andreas Kling.
Call Widget:setFrameRect only when the frame's rect actually changes. It also
cleans up the related weak reference code a bit.
Covered by existing tests.
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
- 10:50 PM Changeset in webkit [158650] by
-
- 77 edits in trunk/Source/WebCore
[webcore/html] remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123740
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Darin Adler.
Removing redundant headers.
- html/BaseDateAndTimeInputType.cpp:
- html/ColorInputType.cpp:
- html/DOMFormData.cpp:
- html/DOMURL.cpp:
- html/DateInputType.cpp:
- html/DateTimeInputType.cpp:
- html/DateTimeLocalInputType.cpp:
- html/FTPDirectoryDocument.cpp:
- html/FileInputType.cpp:
- html/FormController.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAreaElement.cpp:
- html/HTMLCanvasElement.cpp:
- html/HTMLCollection.cpp:
- html/HTMLDetailsElement.cpp:
- html/HTMLDocument.cpp:
- html/HTMLElement.cpp:
- html/HTMLFormControlsCollection.cpp:
- html/HTMLFormElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLInputElement.cpp:
- html/HTMLLegendElement.cpp:
- html/HTMLMapElement.cpp:
- html/HTMLMediaElement.cpp:
- html/HTMLOptionElement.cpp:
- html/HTMLOptionsCollection.cpp:
- html/HTMLPlugInImageElement.cpp:
- html/HTMLProgressElement.cpp:
- html/HTMLSummaryElement.cpp:
- html/HTMLTemplateElement.cpp:
- html/HTMLVideoElement.cpp:
- html/HTMLViewSourceDocument.cpp:
- html/MediaController.cpp:
- html/MediaKeyEvent.cpp:
- html/MonthInputType.cpp:
- html/RangeInputType.cpp:
- html/StepRange.cpp:
- html/TextFieldInputType.cpp:
- html/TimeInputType.cpp:
- html/WeekInputType.cpp:
- html/canvas/CanvasRenderingContext.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
- html/canvas/CanvasStyle.cpp:
- html/canvas/OESVertexArrayObject.cpp:
- html/parser/BackgroundHTMLParser.cpp:
- html/parser/CSSPreloadScanner.cpp:
- html/parser/CompactHTMLToken.cpp:
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLElementStack.cpp:
- html/parser/HTMLFormattingElementList.cpp:
- html/parser/HTMLMetaCharsetParser.cpp:
- html/parser/HTMLParserIdioms.cpp:
- html/parser/HTMLPreloadScanner.cpp:
- html/parser/HTMLTokenizer.cpp:
- html/parser/HTMLTreeBuilder.cpp:
- html/parser/HTMLTreeBuilderSimulator.cpp:
- html/parser/HTMLViewSourceParser.cpp:
- html/parser/TextDocumentParser.cpp:
- html/parser/XSSAuditor.cpp:
- html/shadow/ContentDistributor.cpp:
- html/shadow/InsertionPoint.cpp:
- html/shadow/MediaControlElements.cpp:
- html/shadow/MediaControlsApple.cpp:
- html/shadow/MediaControlsBlackBerry.cpp:
- html/shadow/MediaControlsGtk.cpp:
- html/shadow/SliderThumbElement.cpp:
- html/track/AudioTrack.cpp:
- html/track/InbandGenericTextTrack.cpp:
- html/track/InbandTextTrack.cpp:
- html/track/InbandWebVTTTextTrack.cpp:
- html/track/TextTrack.cpp:
- html/track/TextTrackCueGeneric.cpp:
- html/track/TextTrackList.cpp:
- html/track/TextTrackRegion.cpp:
- html/track/TrackListBase.cpp:
- html/track/VideoTrack.cpp:
- html/track/WebVTTParser.cpp:
- 10:16 PM Changeset in webkit [158649] by
-
- 6 edits in trunk/Source/WebCore
IDB: deleteDatabase() interface should be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=123787
Reviewed by Tim Horton.
No new tests (No behavior change for a tested port).
deleteDatabase now has no return value, but calls back to a bool function:
- Modules/indexeddb/IDBBackingStoreInterface.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::deleteDatabase):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
Refactor to account for the new async deleteDatabase:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseAsync):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- 10:06 PM Changeset in webkit [158648] by
-
- 5 edits in trunk
REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765
Source/JavaScriptCore:
We were leaving a hole of one slot above a new frame when pushing the new frame on
the stack with pushFrame(). This unused slot can contain residual values that will
be marked during GC.
Reviewed by Filip Pizlo.
- interpreter/JSStackInlines.h:
(JSC::JSStack::pushFrame):
LayoutTests:
Reviewed by Filip Pizlo.
Reverted the test expectation changes after fixing the underlying issue.
- TestExpectations:
- platform/wk2/TestExpectations:
- 9:52 PM Changeset in webkit [158647] by
-
- 11 edits2 adds in trunk/Source/WebKit2
Remote Layer Tree: Make LayerTypeCustom remote-host CALayers from the Web process
https://bugs.webkit.org/show_bug.cgi?id=123766
Reviewed by Anders Carlsson.
Put each LayerTypeCustom layer into a CAContext, so that we can
host small CALayer trees (for video, plugins, etc.) from the Web process
to the UI process without proxying their (more complex) content.
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::dump):
Store, encode, and dump the CAContext ID of custom layers.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
Create a CALayerHost with the CAContext ID from the Web process.
- WebKit2.xcodeproj/project.pbxproj:
Add PlatformCALayerRemoteCustom.
- WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:
(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
Call the newly-added custom-layer constructor.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::create):
(PlatformCALayerRemote::PlatformCALayerRemote):
Move the call to layerWasCreated() out to ::create(), so that all of
the constructors for this class and all subclasses have completed
before we call it (so that layerWasCreated() can store the context ID
in the created layer properties object).
(WebKit::PlatformCALayerRemote::hostingContextID):
Should never be reached on the base class, only PlatformCALayerRemoteCustom.
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp: Added.
(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::hostingContextID):
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h: Added.
Add PlatformCALayerRemoteCustom, which owns a LayerHostingContext
which it will use to share a custom CALayer tree with the UI process.
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
Drive-by remove an unnecessary include.
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::layerWasCreated):
Store the CAContext ID with the layer creation properties so it can
be used to create a CALayerHost upon commit in the UI process.
- 9:41 PM Changeset in webkit [158646] by
-
- 2 edits in trunk/Source/JavaScriptCore
internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778
Reviewed by Geoffrey Garen.
This assertion was just wrong: ee do an execute() above the assertion. The assertion
is asserting that if we need a watchpoint (i.e. the best proven structure was not the
current structure) then it must be the future possible structure. But while that may
have been true before execute(), it won't be true after if the PutById was a
transition. Of course, this can only happen in the concurrent JIT in which case the
code would be invalidated anyway since we would only transform the code in a way that
leveraged the lack of a transition if we inserted a watchpoint, in which case we
would realize that the watchpoint had been fired during compilation.
Since this requires concurrent JIT awesomeness, I don't know how to test it.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 9:41 PM Changeset in webkit [158645] by
-
- 2 edits in trunk/Source/WebCore
Add Modules/indexeddb/leveldb to the WebCore.xcodeproj
Rubberstamped by Andreas Kling.
This will make hacking on IDB much easier for Mac developers as they won’t have
to constantly add and then subtract the leveldb subdirectory.
The USE(LEVELDB) flag is still disabled so these files won’t actually build by default.
- WebCore.xcodeproj/project.pbxproj:
- 9:39 PM Changeset in webkit [158644] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG CheckArray(String) should just be a Phantom(String:)
https://bugs.webkit.org/show_bug.cgi?id=123779
Reviewed by Geoffrey Garen.
This should be a speed-up since Phantom(String:) is smart enough to use the string
structure. It should also be a simplification since CheckArray(String) was totally
redundant.
Also FixupPhase was assuming that it may see CheckArray's. That's wrong. It can
create CheckArray's but it won't see them as input since no previous phase can
create them.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
- 9:38 PM Changeset in webkit [158643] by
-
- 2 edits in trunk/Tools
Running FTL tests shouldn't reduce coverage on DFG tests
https://bugs.webkit.org/show_bug.cgi?id=123780
Reviewed by Geoffrey Garen.
- Scripts/run-jsc-stress-tests:
- 9:20 PM Changeset in webkit [158642] by
-
- 2 edits in trunk/Source/WebCore
Address review feedback I forgot to commit in r158641
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls):
- 9:08 PM Changeset in webkit [158641] by
-
- 6 edits in trunk/Source/WebCore
IDB: Make opening/establishing a database asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=123775
Reviewed by Andreas Kling.
No new tests (No behavior change for a tested port).
- Modules/indexeddb/IDBBackingStoreInterface.h: Add getOrEstablishIDBDatabaseMetadata with a callback, removing getIDBDatabaseMetaData, getObjectStores, and createIDBDatabaseMetaData in the process.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::getOrEstablishIDBDatabaseMetadata): Adapted from getIDBDatabaseMetaData,
implement the asynchronous interface in terms of other LevelDB methods, always calling back synchronously.
(WebCore::IDBBackingStoreLevelDB::createIDBDatabaseMetaData):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::create):
(WebCore::IDBDatabaseBackendImpl::openInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::didOpenInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls): Broken off to allow didOpenInternalAsync
to perform open callbacks in the failure case.
(WebCore::IDBDatabaseBackendImpl::openConnection): Always queue open connection calls, then immediately processPendingCalls.
(WebCore::IDBDatabaseBackendImpl::openConnectionInternal): Actually perform open connection calls.
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- 9:04 PM Changeset in webkit [158640] by
-
- 2 edits in trunk/Websites/test-results
Build fix. Update is_flaky when it's NULL.
- public/include/test-results.php:
- 8:12 PM Changeset in webkit [158639] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 8:11 PM Changeset in webkit [158638] by
-
- 1 copy in tags/Safari-537.73.3
New Tag.
- 8:05 PM Changeset in webkit [158637] by
-
- 3 edits in trunk/Websites/test-results
JSON generation on new flakiness dashboard is still too slow
https://bugs.webkit.org/show_bug.cgi?id=123776
Reviewed by Mark Rowe.
- init-database.sql: Added a constraint that result is unique for each (build, test) pair.
- public/include/test-results.php:
(ResultsJSONGenerator::generate): Don't sort results by latest_revision_time since that's done
in the client side anyway.
(update_flakiness_for_build): Don't update is_flaky flag if it's already set to the right value.
- 7:46 PM Changeset in webkit [158636] by
-
- 2 edits in branches/safari-537.60-branch/Tools
Merged r157995. <rdar://problem/15390113>
- 7:45 PM Changeset in webkit [158635] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157815. <rdar://problem/15390113>
- 7:43 PM Changeset in webkit [158634] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157687. <rdar://problem/15390113>
- 7:42 PM Changeset in webkit [158633] by
-
- 3 edits in branches/safari-537.60-branch/Tools
Merged r157553. <rdar://problem/15390113>
- 7:38 PM Changeset in webkit [158632] by
-
- 5 edits in branches/safari-537.60-branch/Tools
Merged r154450. <rdar://problem/15390113>
- 7:31 PM Changeset in webkit [158631] by
-
- 5 edits in trunk/Source/WebCore
CTTE: RenderFrameBase's widget is always a FrameView.
<https://webkit.org/b/123771>
Delete widget() from RenderFrameBase and supplant a childView()
that returns FrameView*. Strip away unnecessary casts and asserts.
Reviewed by Antti Koivisto.
- 6:34 PM Changeset in webkit [158630] by
-
- 3 edits2 adds in trunk
[CSS Regions][CSS Shapes] Content in region doesn't respect shape-outside after initial layout pass
<https://webkit.org/b/114829>
Source/WebCore:
Although we set the size of a shape for shape-outside in RenderBlockFlow::insertFloatingObject based on the
float's size, the actual height of the float is not always resolved at that point. (Look at cases when the shape
has percentage based height or percentage based radius.) ShapeInfo::setShapeSize triggers a layout for 0 height
value, which will be overriden later, when RenderBlockFlow::positionNewFloats sets the actual size of the float (shape).
Thus it doesn't make sense to set the shape's size in insertFloatingObject and run those extra unnecessary layout passes,
since it'll be overriden anyways. I moved the shape size setting logic into RenderBlockFlow::positionNewFloats.
The problem showed up when we had a shape-outside ellipse with percentage based radius, and we inserted the content
with JavaScript into a region flow. The content has been layed out based on the 0 border radius, and relayout hasn't been
triggered when it flew into the flow. This change sets the shape size only when we already have the height of the float,
so the radius(es) can be resolved correctly, thus no unnecessary layout passes will happen and the layout will be correct as well.
Reviewed by David Hyatt.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::insertFloatingObject): Remove setting the size of the shape.
(WebCore::RenderBlockFlow::positionNewFloats): Set the size of the shape here.
LayoutTests:
Reviewed by David Hyatt.
- fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html: Added.
- 6:14 PM Changeset in webkit [158629] by
-
- 2 edits in trunk/Source/WebCore
AX: AXShowMenu doesn't always work.
https://bugs.webkit.org/show_bug.cgi?id=123649
Reviewed by Chris Fleizach.
No new tests, the change occurs in a code path that forces the context menu to show which
locks up DRT if we try to test it (platform menu is shown). The change itself gives the mouse
event handler a chance to handle our platform mouse event BEFORE the event ends up in the show
context menu machinery. This is necessary because without it, the element will not become
focused. Without focus, accessibility shows different/less menu items than a mouse click. The
end result is that context menus shown via accessibility are consistent with menus shown via click.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::showContextMenuAt):
- 5:45 PM Changeset in webkit [158628] by
-
- 3 edits in trunk/Source/WTF
Implement base64url encoding from RFC 4648
https://bugs.webkit.org/show_bug.cgi?id=123767
Reviewed by Sam Weinig.
No tests yet, will be covered by JWK tests for WebCrypto.
- wtf/text/Base64.cpp:
(WTF::base64EncodeInternal):
(WTF::base64Encode):
(WTF::base64URLEncode):
(WTF::base64DecodeInternal):
(WTF::base64Decode):
(WTF::base64URLDecode):
- wtf/text/Base64.h:
(WTF::base64URLEncode):
- 5:45 PM Changeset in webkit [158627] by
-
- 4 edits2 adds in trunk
SMIL timers can still fire after the containing document has been torn down
<https://webkit.org/b/123291>
Reviewed by Darin Adler.
Source/WebCore:
Ensure that the timers get paused when the document is preparing to be torn down.
Test: svg/animations/smil-timers-not-disabled-crash.html
- dom/Document.cpp:
(WebCore::Document::dropChildren):
(WebCore::Document::commonTeardown):
(WebCore::Document::prepareForDestruction):
- dom/Document.h:
LayoutTests:
Add a test that triggers the crash; unfortunately it triggers it after
the test is done, causing the next test to time out or crash.
- svg/animations/smil-timers-not-disabled-crash-expected.txt: Added.
- svg/animations/smil-timers-not-disabled-crash.html: Added.
- 5:37 PM Changeset in webkit [158626] by
-
- 19 edits1 copy in trunk/Source/WebCore
Move duplicate code in TrackPrivate classes to a common base class
https://bugs.webkit.org/show_bug.cgi?id=123619
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-04
Reviewed by Darin Adler.
No new tests because this is just refactoring.
- GNUmakefile.list.am: Add TrackPrivateBase.
- WebCore.vcxproj/WebCore.vcxproj: Same.
- WebCore.vcxproj/WebCore.vcxproj.filters: Same.
- WebCore.xcodeproj/project.pbxproj: Same.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::inbandTrackIndex): Renamed audioTrackIndex() to trackIndex().
(WebCore::AudioTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::AudioTrack::languageChanged): Same.
(WebCore::AudioTrack::willRemove): Same.
- html/track/AudioTrack.h: Update TrackPrivateBaseClient function signatures.
- html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::inbandTrackIndex): Renamed textTrackIndex() to trackIndex().
(WebCore::InbandTextTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::InbandTextTrack::languageChanged): Same.
(WebCore::InbandTextTrack::willRemove): Same.
- html/track/InbandTextTrack.h: Update TrackPrivateBaseClient function signatures.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::inbandTrackIndex): Renamed videoTrackIndex() to trackIndex().
(WebCore::VideoTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::VideoTrack::languageChanged): Same.
(WebCore::VideoTrack::willRemove): Same.
- html/track/VideoTrack.h: Update TrackPrivateBaseClient function signatures.
- platform/graphics/AudioTrackPrivate.h: Remove code that was moved to TrackPrivateBase.
- platform/graphics/InbandTextTrackPrivate.h: Same.
- platform/graphics/InbandTextTrackPrivateClient.h: Same.
- platform/graphics/VideoTrackPrivate.h: Same.
- platform/graphics/TrackPrivateBase.h: Refactored out duplicate code in AudioTrackPrivate, InbandTextTrackPrivate and VideoTrackPrivate.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Renamed textTrackIndex() to trackIndex().
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h: Same.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Renamed audioTrackIndex() to trackIndex().
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Renamed videoTrackIndex() to trackIndex90.
- 5:33 PM Changeset in webkit [158625] by
-
- 2 edits in trunk/Source/WebCore
FrameView destructor is worried about being retained by a renderer.
<https://webkit.org/b/123763>
There's no way we can be in ~FrameView() while also being owned by
a RenderWidget. Remove some overly paranoid code that was making sure
the renderer didn't have a reference on us.
Reviewed by Anders Carlsson.
- 5:33 PM Changeset in webkit [158624] by
-
- 4 edits in trunk
REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions
https://bugs.webkit.org/show_bug.cgi?id=123555
Reviewed by Darin Adler.
Source/WebCore:
No new tests, covered by existing tests.
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseFragments): Don't add a fragment with empty key or value as
they will not processed.
(WebCore::MediaFragmentURIParser::parseNPTFragment): Remove excess whitespace.
LayoutTests:
- TestExpectations: Remove media/media-fragments/TC0054.html and media/media-fragments/TC0061.html.
- 5:31 PM Changeset in webkit [158623] by
-
- 13 edits in trunk/Source/WebCore
Remove code duplications in createFontCustomPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=123706
Reviewed by Darin Adler.
Move OpenTypeSanitizer and WOFF handling from the port specific
implementations in createFontCustomPlatformData() into the only
caller of this function CachedFont::ensureCustomFontData().
Also change the parameter passing the SharedBuffer from a
pointer to a reference since it is never null.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
- platform/graphics/blackberry/FontCustomPlatformData.h:
- platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.h:
- 5:31 PM Changeset in webkit [158622] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 5:28 PM Changeset in webkit [158621] by
-
- 1 copy in tags/Safari-537.60.5
New Tag.
- 5:26 PM Changeset in webkit [158620] by
-
- 2 edits in trunk/Source/WebCore
Fixing MediaStreamDescriptor addSource and addTrack methods
https://bugs.webkit.org/show_bug.cgi?id=123755
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-04
Reviewed by Eric Carlson.
We must store the track and source that is passed as parameter in a RefPtr,
otherwise we will refer to a null pointer.
No new tests needed.
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addSource):
(WebCore::MediaStreamDescriptor::addTrack):
- 5:23 PM Changeset in webkit [158619] by
-
- 7 edits in trunk/Source
Remove PlatformCALayer::playerLayer
https://bugs.webkit.org/show_bug.cgi?id=123764
Reviewed by Sam Weinig.
Source/WebCore:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayerMac::clone):
Remove playerLayer(), fold it into clone().
Source/WebKit2:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
Remove playerLayer().
- 5:12 PM Changeset in webkit [158618] by
-
- 5 edits in branches/safari-537.73-branch/Source/WebCore
Merged r155130. <rdar://problem/15109454>
- 4:47 PM Changeset in webkit [158617] by
-
- 17 edits4 adds in trunk
AX: Mail attachments at the start of an email are not output by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123697
Reviewed by Ryosuke Niwa.
Source/WebCore:
VoiceOver is expecting that "replaced elements" (attachments in a Mail message in this case) to be
represented by the replacement character when asking for a stringForRange.
However, when that replaced element is at the beginning of the document, the logic does not work because
there is a few code places that will take that first Position and advance it forward, not accounting for replaced elements.
When using the TextIterator normally, it does account for these, so that's why it's only affecting as at the beginning of the document.
Also a "replaced element" can be more than just renderer->isReplaced(), hence the externing of the isRendererReplacedElement method
and using that it in pertinent places.
Tests: platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html
platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html
- accessibility/AccessibilityObject.cpp:
(WebCore::replacedNodeNeedsCharacter):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(nsStringForReplacedNode):
- dom/Position.cpp:
(WebCore::Position::isCandidate):
- dom/PositionIterator.cpp:
- dom/Range.cpp:
(WebCore::Range::firstNode):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- editing/TextIterator.h:
LayoutTests:
Add two flavors of this. One where the replaced element has rendered children and one where it does not,
which go down two different code paths.
- platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start-expected.txt: Added.
- platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html: Added.
- platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start-expected.txt: Added.
- platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html: Added.
- 4:46 PM Changeset in webkit [158616] by
-
- 4 edits in trunk/Source/WebKit/wince
Change structure of frame tree in WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=121079
Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-11-04
Reviewed by Darin Adler.
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::createFrame):
- WebView.cpp:
(WebView::createFrame):
- WebView.h:
- 4:46 PM Changeset in webkit [158615] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r154180. <rdar://problem/15387843>
- 4:41 PM Changeset in webkit [158614] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765
Add the test expectation.
- TestExpectations:
- platform/wk2/TestExpectations:
- 4:33 PM Changeset in webkit [158613] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebKit2
Merge change for <rdar://problem/15374298>.
- 4:15 PM Changeset in webkit [158612] by
-
- 6 edits in branches/safari-537.60-branch/Source/WebCore
Merged r157773. <rdar://problem/15387840>
- 4:12 PM Changeset in webkit [158611] by
-
- 7 edits in trunk/Source/WebCore
Use RenderAncestorIterator in a couple of places.
<https://webkit.org/b/123725>
Take the ancestorsOfType<RenderMoo>() thingy out for a spin.
Found a bunch of parent chain walking loops that were really just
looking for the first ancestor renderer of a certain type.
They were a perfect fit for this pattern:
if (auto svgRoot = ancestorsOfType<RenderSVGRoot>(renderer).first())
svgRoot->shakeMoneyMaker();
Quite a bit clearer than the previous:
for (auto ancestor = renderer.parent(); ancestor; ancestor = ancestor->parent()) {
if (ancestor->isSVGRoot())
toRenderSVGRoot(ancestor)->makeMoneyShaker();
}
Reviewed by Antti Koivisto.
- 4:09 PM Changeset in webkit [158610] by
-
- 2 edits in trunk/Source/WebKit2
WKRemoteObjectEncoder should escape keys
https://bugs.webkit.org/show_bug.cgi?id=123761
Reviewed by Tim Horton.
Keys that start with $ will be reserved for use by the coder, so prepend an extra
$ to keys that already start with $ to avoid clashes.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(escapeKey):
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
- 4:05 PM Changeset in webkit [158609] by
-
- 7 edits in branches/safari-537.73-branch/Source/WebCore
Merge r157773
- 4:05 PM Changeset in webkit [158608] by
-
- 3 edits6 adds in trunk
DFG NewArray/NewArrayBuffer shouldn't be constructing with negative indexing
https://bugs.webkit.org/show_bug.cgi?id=123760
<rdar://problem/15356705>
Reviewed by Mark Hahnenberg and Oliver Hunt.
Source/JavaScriptCore:
- dfg/DFGOperations.cpp:
LayoutTests:
- js/dfg-new-array-buffer-while-having-a-bad-time-expected.txt: Added.
- js/dfg-new-array-buffer-while-having-a-bad-time.html: Added.
- js/dfg-new-array-while-having-a-bad-time-expected.txt: Added.
- js/dfg-new-array-while-having-a-bad-time.html: Added.
- js/script-tests/dfg-new-array-buffer-while-having-a-bad-time.js: Added.
(foo):
- js/script-tests/dfg-new-array-while-having-a-bad-time.js: Added.
(foo):
- 3:59 PM Changeset in webkit [158607] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r154180. <rdar://problem/15387809>
- 3:52 PM Changeset in webkit [158606] by
-
- 5 edits1 add in trunk/Source/WebCore
[MSE] Add a SourceBufferPrivateClient interface for platform -> html communication.
https://bugs.webkit.org/show_bug.cgi?id=123373
Reviewed by Eric Carlson.
To enable communication between SourceBuffer and SourceBufferPrivate without introducing
layering violations, add a new interface class SourceBufferPrivateInterface from which
SourceBuffer will inherit.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::SourceBuffer): Set the private's client.
(WebCore::SourceBuffer::~SourceBuffer): Clear the private's client.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Added stub.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Hinno.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasAudio): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasVideo): Ditto.
- Modules/mediasource/SourceBuffer.h:
- WebCore.xcodeproj/project.pbxproj: Add new files to project.
- platform/graphics/SourceBufferPrivate.h:
- platform/graphics/SourceBufferPrivateClient.h: Added.
(WebCore::SourceBufferPrivateClient::~SourceBufferPrivateClient): Empty destructor.
- 3:47 PM Changeset in webkit [158605] by
-
- 8 edits in branches/safari-537.73-branch
Merge r157299
<rdar://problem/15292359>
- 3:44 PM Changeset in webkit [158604] by
-
- 4 edits in branches/safari-537.73-branch/Source
Merged r158602. <rdar://problem/15388203>
- 3:37 PM Changeset in webkit [158603] by
-
- 4 edits in branches/safari-537.60-branch/Source
Merged r158602. <rdar://problem/15373550>
- 3:26 PM Changeset in webkit [158602] by
-
- 4 edits in trunk/Source
../WebKit: [Win] Use VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758
Reviewed by Tim Horton.
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Restore command to
call VersionStamper on final stage of build.
../WTF: [Win] User VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758
Reviewed by Tim Horton.
- WTF.vcxproj/WTFPostBuild.cmd: Add missing command to run VersionStamper.exe.
- 3:15 PM Changeset in webkit [158601] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merge fixes for <rdar://problem/15168240>.
- 3:03 PM Changeset in webkit [158600] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Update WebGeolocationManager to support multiple WebContent processes
https://bugs.webkit.org/show_bug.cgi?id=123658
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-04
Reviewed by Anders Carlsson.
Change WebGeolocationManagerProxy to track which WebProcessProxy needs geolocation.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::disconnectProcess):
WebContext::disconnectProcess does not handle ContextSupplement yet when using multiple
WebContent processes. Add an explicit call for WebGeolocationManagerProxy as a temporary
solution.
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::stopUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebGeolocationManagerProxy.messages.in:
- 2:53 PM Changeset in webkit [158599] by
-
- 27 edits in trunk/Source
[PluginProxy] Add a setting to disable video plugin proxy support in HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=123621
Reviewed by Eric Carlson.
Source/WebCore:
Add a new Setting which will disable the video plugin proxy. Enable support for AVFoundation
in iOS (which requries fixing a few compile errors resulting from classes and methods which
are not available on iOS.
- WebCore.exp.in: Export wkAVAssetResolvedURL.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement): Make conditional upon
new isVideoPluginProxyEnabled() setting.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::createRenderer): Ditto.
(WebCore::HTMLVideoElement::attach): Ditto.
(WebCore::HTMLVideoElement::parseAttribute): Ditto.
(HTMLVideoElement::setDisplayMode): Ditto.
- html/HTMLVideoElement.h:
- page/Settings.cpp:
(WebCore::Settings::setVideoPluginProxyEnabled): Simple setter.
- page/Settings.h:
(WebCore::Settings::isVideoPluginProxyEnabled): Simple getter.
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Conditionally add MediaPlayerPrivateIOS and always add
MediaPlayerPriateAVFoundationObjC.
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::deliverNotification): Add default implementation.
(WebCore::MediaPlayerPrivateInterface::setMediaPlayerProxy): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Use new
HAS_ and USE_ macros instead of MAC_OS_MIN_VERNSION_REQUIRED.
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Use cachedCGColor instead
of CGColorGetConstantColor.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Use CVPixelBuffer pixel
format constant instead of QuickDraw constant.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Draw to intermediary
CGImage on iOS.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
Source/WebKit/mac:
Add a new isVideoPluginProxyEnabled setting.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set isVideoPluginProxyEnabled preference.
(-[WebPreferences isVideoPluginProxyEnabled]): Pass through to Settings.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Set isVideoPluginProxyEnabled preference.
Source/WebKit2:
Add WebKit2 functions for setting then new isVideoPluginProxyEnabled preference.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetVideoPluginProxyEnabled):
(WKPreferencesGetVideoPluginProxyEnabled):
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Source/WTF:
Enable WTF_USE_AVFOUNDATION and add some HAVE_AVFOUNDATION_* defines
to replace the existing MAC_OS_X_VERSION_MIN_REQUIRED macros in
MediaPlayerPrivateAVFoundationObjC.mm.
- wtf/Platform.h:
- 2:50 PM Changeset in webkit [158598] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r158561): fast/block/float/float-append-child-crash.html asserting.
The non-const ancestor iterator was walking siblings, not ancestors.
Rubber-stamped by Antti Koivisto.
- 2:49 PM Changeset in webkit [158597] by
-
- 6 edits in trunk/Source/WebCore
[MSE] [Mac] Disclaim support for MSE in AVFoundation and QTKit engines
https://bugs.webkit.org/show_bug.cgi?id=123593
Reviewed by Eric Carlson.
Immediately fail if asked to load a Media Source in engines which do not support
them.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::load):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):
- 2:39 PM Changeset in webkit [158596] by
-
- 3 edits2 adds in trunk
[CSS Shapes] image valued shape element margin can cause an ASSERT fail
https://bugs.webkit.org/show_bug.cgi?id=123743
Reviewed by Andreas Kling.
Source/WebCore:
When margin-top is specified for a shape's element, the Y coordinates passed
to RasterShapeIntervals::getExcludedIntervals() may be negative. This is
because the incoming logical coordinates are relative to the content or
padding box, depending on the box-sizing property. The RasterShape::getExcludedIntervals()
method now clips the incoming Y coordinates to the shape's bounds before
accessing the shape's intervals.
Test: fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::getExcludedIntervals):
LayoutTests:
Verify that an element with an image valued shape and a non-negative margin
does not cause an assertion failure.
- fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html: Added.
- 2:30 PM Changeset in webkit [158595] by
-
- 7 edits in trunk
More WKRemoteObjectRegistry work
https://bugs.webkit.org/show_bug.cgi?id=123754
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectCoder.h:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder rootObjectDictionary]):
Add a getter for the root object dictionary.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Call _sendMessageWithBody:.
(-[WKRemoteObjectRegistry _sendMessageWithBody:]):
Call WebConnection::postMessage.
Tools:
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
Use the correct bundle test name. Call Util::run.
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
(-[BundleObject sayHello]):
(-[BundleObject testMethodWithString:double:integer:]):
Add BundleObject implementation. Register the bundle object with
the remote object registry. Call _handleMessageWithName:body: on the incoming message.
- 1:56 PM Changeset in webkit [158594] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r158404. <rdar://problem/15371809>
- 1:53 PM Changeset in webkit [158593] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r158061. <rdar://problem/15333281>
- 1:50 PM Changeset in webkit [158592] by
-
- 3 edits2 copies in branches/safari-537.73-branch
Merged r157436. <rdar://problem/15357233>
- 1:46 PM Changeset in webkit [158591] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154897. <rdar://problem/15168237>
- 1:44 PM Changeset in webkit [158590] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154851. <rdar://problem/15366090>
- 1:41 PM Changeset in webkit [158589] by
-
- 3 edits2 copies in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r153087. <rdar://problem/15366093>
- 1:38 PM Changeset in webkit [158588] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154851.
- 1:31 PM Changeset in webkit [158587] by
-
- 11 edits in trunk/Source/WebCore
Make LiveNodeListBase use Elements instead of Nodes
https://bugs.webkit.org/show_bug.cgi?id=123745
Reviewed by Anders Carlsson.
- WebCore.exp.in:
- dom/Element.cpp:
(WebCore::Element::firstElementChild):
(WebCore::Element::lastElementChild):
Switch to correct calls. ElementTraversal::previous and previousChild are no longer equivalent.
- dom/ElementTraversal.h:
(WebCore::::lastWithinTemplate):
(WebCore::::previousTemplate):
Fix ElementTraversal::lastWithin and previous. They had no real clients and didn't work correctly.
With LiveNodeListBase starting to use these they get excellent test coverage.
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::invalidateCache):
- dom/LiveNodeList.h:
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::isElementCacheValid):
(WebCore::LiveNodeListBase::cachedElement):
(WebCore::LiveNodeListBase::cachedElementOffset):
(WebCore::LiveNodeListBase::setCachedElement):
Make the cache Element based.
Switch to Elements in all helpers.
Rename item -> element for clarity.
- dom/NodeIterator.cpp:
(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::updateForNodeRemoval):
This code expected the old inconsistent NodeTraversal::previous behavior where the traversal includes
the root as the last item. Drop the stayWithin parameter and handle the one case where it is needed here.
- dom/NodeTraversal.cpp:
(WebCore::NodeTraversal::last):
(WebCore::NodeTraversal::deepLastChild):
- dom/NodeTraversal.h:
Support ElementTraversal::previous/lastWithin.
(WebCore::NodeTraversal::previous):
This was slightly wrong too.
- html/HTMLCollection.cpp:
(WebCore::previousElement):
(WebCore::lastElement):
(WebCore::LiveNodeListBase::iterateForPreviousElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeListBase::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeListBase::setCachedElement):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::elementBeforeOrAfterCachedElement):
- html/HTMLCollection.h:
(WebCore::HTMLCollection::isEmpty):
(WebCore::HTMLCollection::hasExactlyOneItem):
- 1:28 PM Changeset in webkit [158586] by
-
- 28 edits in trunk/Source
Eliminate HostCall bit from JSC Stack CallerFrame
https://bugs.webkit.org/show_bug.cgi?id=123642
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Replace the HostCallFrame bit or'ed to the CallerFrame value in a CallFrame with
a VM entry sentinel CallFrame. Logically, the VM entry sentinel call frame is
pushed on the stack before the callee frame when calling from native to JavaScript
code. The callee frame's CallerFrame points at the VM entry sentinel call frame
and the VM entry sentinel call frame's CallerFrame points to the real caller.
The VM entry sentinel call frame has a sentinel (1) in the CodeBlock to indicate
its a VM entry sentinel call frame. It's ScopeChain has vm.topCallFrame at the
time of the call. This allows for a complete stack walk as well as walking just
the contiguous JS frames.
The VM entry sentinel call frame and callee frame are currently allocated and
initialized in ExecState::init(), but this initialization will be moved to
ctiTrampoline when we actually move onto the native stack.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::noticeIncomingCall):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::callerFrame):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- interpreter/CallFrame.h:
(JSC::ExecState::frameExtent):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
(JSC::ExecState::init):
(JSC::ExecState::noCaller):
(JSC::ExecState::isVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCallerFrame):
(JSC::ExecState::initializeVMEntrySentinelFrame):
(JSC::ExecState::callerFrameSkippingVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCodeBlock):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::Interpreter::getStackTrace):
- interpreter/Interpreter.h:
(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
- interpreter/JSStack.cpp:
(JSC::JSStack::~JSStack):
- interpreter/JSStackInlines.h:
(JSC::JSStack::getStartOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
- interpreter/Register.h:
(JSC::Register::operator=):
(JSC::Register::callFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::readFrame):
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::print):
- interpreter/VMInspector.cpp:
(JSC::VMInspector::countFrames):
- jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JITOperations.cpp:
- jit/JITStubsARM.h:
(JSC::ctiTrampoline):
- jit/JITStubsARM64.h:
- jit/JITStubsARMv7.h:
(JSC::ctiTrampoline):
- jit/JITStubsMIPS.h:
- jit/JITStubsMSVC64.asm:
- jit/JITStubsSH4.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86_64.h:
- jsc.cpp:
(functionDumpCallFrame):
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::throwException):
Source/WebCore:
Updated JavaScript stack walking as a result of the corresponding changes made in
JavaScriptCore.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::didExecuteProgram):
- 12:15 PM Changeset in webkit [158585] by
-
- 3 edits in trunk/Websites/test-results
Build fixes. In particular, we were missing the code to generate JSONs in report.php :(
- public/api/report.php:
- public/include/test-results.php:
- 12:12 PM Changeset in webkit [158584] by
-
- 41 edits in trunk
[css shapes] Fix support for shape-outside on a float with padding
https://bugs.webkit.org/show_bug.cgi?id=123590
Reviewed by Alexandru Chiculita.
Source/WebCore:
The line top was being improperly converted to the coordinates of the
shape, causing the shape to be positioned incorrectly when the float
had padding. This fixes that problem.
No new tests, covered by updates to existing ones.
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
LayoutTests:
Fix existing tests that depended on the incorrect behavior so that
they are now testing the proper thing. Also fix up the tests to make
them clearer and more robust.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 11:52 AM Changeset in webkit [158583] by
-
- 8 edits3 adds in trunk
JSArrayBufferViews of length 0 allocate 0 CopiedSpace bytes, which is invalid
https://bugs.webkit.org/show_bug.cgi?id=123746
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This patch disallows clients from allocating 0 bytes in CopiedSpace. We enforce this invariant
with an ASSERT in C++ code and a breakpoint in JIT code. Clients who care about 0-byte
allocations (like JSArrayBufferViews) must handle that case themselves, but we don't punish
anybody else for the rare case that somebody decides to allocate a 0-length typed array.
It also makes the allocation and copying cases consistent for CopiedSpace: no 0-byte allocations,
no 0-byte copying.
Also added a check so that JSArrayBufferViews don't try to copy their m_vector backing store when
their length is 0. Also sprinkled several ASSERTs throughout the JSArrayBufferView code to make sure that
when length is 0 m_vector is null.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::tryAllocate):
- runtime/ArrayBuffer.h:
(JSC::ArrayBuffer::create):
- runtime/JSArrayBufferView.cpp:
(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::::visitChildren):
(JSC::::copyBackingStore):
(JSC::::slowDownAndWasteMemory):
LayoutTests:
Added a test to make sure that we don't crash when allocating a typed array with 0 length.
- js/script-tests/typedarray-zero-size.js: Added.
(foo):
- js/typedarray-zero-size-expected.txt: Added.
- js/typedarray-zero-size.html: Added.
- 10:45 AM Changeset in webkit [158582] by
-
- 17 edits6 copies in trunk
Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-generate-key.html
crypto/subtle/hmac-generate-key.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.
- crypto/CryptoAlgorithmAesKeyGenParams.h: Added.
- crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
- crypto/CryptoKey.h:
- crypto/CryptoKeyMac.cpp: Added
Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.
- crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
- crypto/CryptoKeyAES.h:
Added a function that creates AES keys.
- crypto/SubtleCrypto.idl: Added generateKey.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey): Added.
- crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
- crypto/keys/CryptoKeyHMAC.h:
Added a function that creates HMAC keys.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation
ended up in cross-platform file.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
- crypto/subtle/aes-cbc-generate-key.html: Added.
- crypto/subtle/hmac-generate-key-expected.txt: Added.
- crypto/subtle/hmac-generate-key.html: Added.
- crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,
a different exception is raised.
- 10:42 AM Changeset in webkit [158581] by
-
- 4 edits in trunk/Source/WebCore
Revert SetCGFontRenderingMode() build fix for Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=123633
Reviewed by Darin Adler.
Reverts <http://trac.webkit.org/changeset/134380>, which
was a Chromium Mac build fix for <http://trac.webkit.org/changeset/134348>
(https://bugs.webkit.org/show_bug.cgi?id=101787). Chromium doesn't
build against top-of-tree WebKit.
- platform/graphics/mac/FontMac.mm:
(WebCore::Font::drawGlyphs):
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- 10:21 AM Changeset in webkit [158580] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Refactor jumps in baseline JIT to return label after the jump.
https://bugs.webkit.org/show_bug.cgi?id=123734
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-04
Reviewed by Michael Saboff.
Current implementation of jumps in sh4 baseline JIT returns a label on the jump itself
and not after it. This is not correct and leads to issues like infinite loop the DFG
(https://bugs.webkit.org/show_bug.cgi?id=122597 for instance). This refactor fixes this
and also simplifies the link and relink procedures for sh4 jumps.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branchTrue):
(JSC::MacroAssemblerSH4::branchFalse):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::extraInstrForBranch):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::bra):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::relinkJump):
- 10:03 AM Changeset in webkit [158579] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK][WK1] Enable CSS Regions if feature flag is set to TRUE
https://bugs.webkit.org/show_bug.cgi?id=123739
Reviewed by Martin Robinson.
In WK1 CSS Regions were always disabled even if you set the feature flag
ENABLE_CSS_REGIONS to TRUE. Enabling CSS Regions support in that case.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Enable CSS Regions if feautre flag is
set to TRUE.
- 9:37 AM Changeset in webkit [158578] by
-
- 17 edits6 deletes in trunk
Unreviewed, rolling out r158526.
http://trac.webkit.org/changeset/158526
https://bugs.webkit.org/show_bug.cgi?id=123744
it broke the build (Requested by jessieberlin on #webkit).
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesCbcParams):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
- bindings/js/JSSubtleCryptoCustom.cpp:
- crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
- crypto/CryptoKey.cpp:
- crypto/CryptoKey.h:
- crypto/CryptoKeyAES.cpp:
- crypto/CryptoKeyAES.h:
- crypto/CryptoKeyMac.cpp: Removed.
- crypto/SubtleCrypto.idl:
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
- crypto/keys/CryptoKeyHMAC.cpp:
- crypto/keys/CryptoKeyHMAC.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey):
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Removed.
- crypto/subtle/aes-cbc-generate-key.html: Removed.
- crypto/subtle/hmac-generate-key-expected.txt: Removed.
- crypto/subtle/hmac-generate-key.html: Removed.
- crypto/subtle/sha-1-expected.txt:
- 8:08 AM Changeset in webkit [158577] by
-
- 2 edits in trunk/Tools
[EFL] Change ATK version to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123727
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Provided new API to retrieve text at a given offset.
- efl/jhbuild.modules:
- 8:04 AM Changeset in webkit [158576] by
-
- 6 edits in trunk
[EFL] accessibility/textarea-line-for-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112015
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Tools:
Provided implementation for AccessibilityUIElement::lineForIndex().
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::lineForIndex): Implemented.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::lineForIndex): Implemented.
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations: The test is no longer failing.
- platform/efl-wk2/TestExpectations: The test is no longer failing.
- 7:02 AM Changeset in webkit [158575] by
-
- 6 edits in trunk
[EFL] accessibility/button-press-action.html
https://bugs.webkit.org/show_bug.cgi?id=111993
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.
Tools:
Provided an implementation for AccessibilityUIElement::isPressActionSupported.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::isPressActionSupported):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::isPressActionSupported):
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- 6:58 AM Changeset in webkit [158574] by
-
- 2 edits in trunk/Source/WebCore
[Texmap] Remove redundant calls in CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=123737
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-04
Reviewed by Noam Rosenthal.
Removing unused code left after few refactoring patches.
No new tests. Covered by existing ones.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
- 5:01 AM Changeset in webkit [158573] by
-
- 4 edits in trunk/Source/WebCore
CSSPrimitiveValue color constructors should return PassRef.
<https://webkit.org/b/123728>
Make CSSPrimitiveValue::createColor() and the corresponding
CSSValuePool helper functions return PassRef<CSSPrimitiveValue>.
Also made CSSValuePool slightly less stupid when hitting the upper
size limit on the color value cache: instead of throwing out cache
and rebuilding it from scratch, just remove one value at random.
Reviewed by Antti Koivisto.
- 4:55 AM Changeset in webkit [158572] by
-
- 3 edits in trunk/Source/WebCore
Some more RenderChildIterator deployment.
<https://webkit.org/b/123735>
Convert another handful of loops to use childrenOfType<RenderFoo>
iterators, mostly for skipping over uninteresting text renderers.
Reviewed by Antti Koivisto.
- 4:43 AM Changeset in webkit [158571] by
-
- 3 edits in trunk/Source/WebCore
LabelsNodeList always is always rooted at a LabelableElement.
<https://webkit.org/b/123730>
Tighten up LabelsNodeList by enforcing that it's only rooted to
a LabelableElement. Also marked the class FINAL and made its
create() helper return PassRef.
Reviewed by Antti Koivisto.
- 4:40 AM Changeset in webkit [158570] by
-
- 3 edits2 adds in trunk
REGRESSION: RenderStyle is leaked when not creating renderer for display:none
<https://webkit.org/b/123726>
Source/WebCore:
Explicitly drop the RenderStyle reference in RenderElement::createFor
if we decide to not create any renderer.
Reviewed by Antti Koivisto.
Test: fast/css/renderstyle-leak-with-display-none.html
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
LayoutTests:
Reviewed by Antti Koivisto.
- fast/css/renderstyle-leak-with-display-none-expected.txt: Added.
- fast/css/renderstyle-leak-with-display-none.html: Added.
- 4:25 AM Changeset in webkit [158569] by
-
- 65 edits in trunk/Source/WebCore
[webcore/dom] Remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123720
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Andreas Kling.
Removing redundant headers from dom related cpp files.
- dom/Attr.cpp:
- dom/CharacterData.cpp:
- dom/ChildListMutationScope.cpp:
- dom/ChildNodeList.cpp:
- dom/ContainerNode.cpp:
- dom/ContainerNodeAlgorithms.cpp:
- dom/DOMNamedFlowCollection.cpp:
- dom/DatasetDOMStringMap.cpp:
- dom/Document.cpp:
- dom/DocumentEventQueue.cpp:
- dom/DocumentMarkerController.cpp:
- dom/DocumentOrderedMap.cpp:
- dom/DocumentStyleSheetCollection.cpp:
- dom/Element.cpp:
- dom/ElementRareData.cpp:
- dom/Event.cpp:
- dom/EventContext.cpp:
- dom/EventDispatcher.cpp:
- dom/EventTarget.cpp:
- dom/ExceptionBase.cpp:
- dom/FocusEvent.cpp:
- dom/InlineStyleSheetOwner.cpp:
- dom/KeyboardEvent.cpp:
- dom/LiveNodeList.cpp:
- dom/MessageEvent.cpp:
- dom/MessagePort.cpp:
- dom/MouseRelatedEvent.cpp:
- dom/MutationEvent.cpp:
- dom/MutationObserver.cpp:
- dom/MutationObserverInterestGroup.cpp:
- dom/MutationObserverRegistration.cpp:
- dom/MutationRecord.cpp:
- dom/NameNodeList.cpp:
- dom/NamedFlowCollection.cpp:
- dom/NamedNodeMap.cpp:
- dom/Node.cpp:
- dom/NodeIterator.cpp:
- dom/NodeTraversal.cpp:
- dom/PositionIterator.cpp:
- dom/ProcessingInstruction.cpp:
- dom/Range.cpp:
- dom/RegisteredEventListener.cpp:
- dom/ScopedEventQueue.cpp:
- dom/ScriptElement.cpp:
- dom/ScriptRunner.cpp:
- dom/SelectorQuery.cpp:
- dom/ShadowRoot.cpp:
- dom/StyledElement.cpp:
- dom/TagNodeList.cpp:
- dom/Text.cpp:
- dom/TextEvent.cpp:
- dom/TouchEvent.cpp:
- dom/TreeScope.cpp:
- dom/TreeScopeAdopter.cpp:
- dom/TreeWalker.cpp:
- dom/UIEvent.cpp:
- dom/UserActionElementSet.cpp:
- dom/UserTypingGestureIndicator.cpp:
- dom/VisitedLinkState.cpp:
- dom/WebKitNamedFlow.cpp:
- 4:22 AM Changeset in webkit [158568] by
-
- 3 edits in trunk/Source/WebCore
HTMLAllCollection is always rooted at a Document.
<https://webkit.org/b/123724>
Tighten up HTMLAllCollection by making the constructor take a
Document& instead of a ContainerNode&. Drive-by application of
FINAL and PassRef also happened.
Reviewed by Antti Koivisto.
- 4:21 AM Changeset in webkit [158567] by
-
- 10 edits in trunk/Source/WebCore
Make more CSSValue subclass constructors return PassRef.
<https://webkit.org/b/123731>
Make the constructor helpers for the following classes return
PassRef instead of PassRefPtr:
- CSSFontValue
- CSSImageSetValue
- CSSUnicodeRangeValue
- WebKitCSSArrayFunctionValue
- WebKitCSSFilterValue
- WebKitCSSMatFunctionValue
- WebKitCSSMixFunctionValue
- WebKitCSSShaderValue
- WebKitCSSTransformValue
Reviewed by Antti Koivisto.
- 4:16 AM Changeset in webkit [158566] by
-
- 2 edits in trunk/Source/WebCore
Buildfix after r158182 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=123442
Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-04
Reviewed by Csaba Osztrogonác.
Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)
- dom/ScopedEventQueue.h:
- 1:16 AM Changeset in webkit [158565] by
-
- 7 edits in trunk/Websites/test-results
Fix JSON generations on new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123723
Reviewed by Andreas Kling.
Add is_flaky column on results table so that this column can be used to find flaky tests on a given builder
efficiently without having to through results for all tests in PHP. This column is updated in report.php
when a new build is added. Because is_flaky depends on the preceding and succeeding results, we must update
is_flaky flag on results for builds immediately before and after the new build as well.
To see why, suppose we had two consecutive results [PASS] [PASS]. If we were to insert [FAIL] result between
the two, those two results may also turn into flaky results if they were surrounded by [FAIL]. Similarly,
if we had [PASS] [FAIL] and the second result was marked flaky, inserting new [FAIL] must unmark it.
- init-database.sql: Added is_flaky column to results table with an index. Also added an index on
build_revisions.time as many queries filter results by this quantity. Also set the work_mem to 50MB avoid
disk thrashing while sorting results in various queries.
- public/api/failing-tests.php: Handle builder ids as well as names. Call generate() with failure types.
No longer generates *-failing.json since it's a subset of *-wrongexpectations.json to save time.
- public/api/report.php: Rewritten. Calls update_flakiness_after_inserting_build to update is_flaky flags
on the newly added results.
(store_results): Added.
(main): Added.
- public/include/test-results.php:
(ResultsJSONWriter):
(ResultsJSONWriter::add_results_for_test): Renamed from add_results_for_test_if_matches.
(ResultsJSONGenerator::generate): Takes the failure type. Instead of generating JSONs for all failure types
at once, generate one JSON for the specified type. We generate the list of test ids based on the failure type
and query results based on that. This dramatically cuts down the time spent in PHP.
(ResultsJSONGenerator::latest_build): Added.
(ResultsJSONGenerator::write_jsons): Takes single writer now.
(update_flakiness_for_build): Added.
(update_flakiness_after_inserting_build): Added.
- public/index.html:
(TestResultsView._populateBuilderPane): Emulate *-failing.json upon *-wrongexpectations.json.
(TestResultsView.fetchFailingTestsForBuilder): Ditto.
- public/main.css: Minor style tweaks.
(.testResults): Extend the border that wraps the test results as needed.
(.tooltip): Don't wrap text inside tooltips.
- 12:53 AM Changeset in webkit [158564] by
-
- 4 edits in trunk/Source/WebCore
HTMLTableRowsCollection is always rooted at a HTMLTableElement.
<https://webkit.org/b/123721>
Tighten up HTMLTableRowsCollection by making the create() helper
take a HTMLTableElement& and adding a HTMLSelectElement& getter.
Reviewed by Antti Koivisto.
- 12:51 AM Changeset in webkit [158563] by
-
- 4 edits in trunk/Source/WebCore
HTMLNameCollection and friends are always rooted at a Document.
<https://webkit.org/b/123722>
Tighten WindowNameCollection and DocumentNameCollection by making
their constructors take a Document&, and add a slightly better
document() than the one we inherit from LiveNodeListBase.
Also marked the classes FINAL and made create() helpers return
PassRef instead of PassRefPtr.
Reviewed by Antti Koivisto.
- 12:49 AM Changeset in webkit [158562] by
-
- 1 edit11 moves12 deletes in trunk/LayoutTests
Optimize baselines: svg/zoom
Unreviewed; run "webkit-patch optimize-baselines svg/zoom"
- platform/gtk/svg/zoom/page/zoom-background-images-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.png: Removed.
- platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Removed.
- platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
- svg/zoom/page/zoom-background-images-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-background-images-expected.txt.
- svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
- svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt.
- svg/zoom/page/zoom-mask-with-percentages-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt.
- svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
- svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt.
- svg/zoom/page/zoom-svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-image-expected.png.
- svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt.
- svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
- svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
- svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt.
- svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt.
- 12:46 AM Changeset in webkit [158561] by
-
- 13 edits1 add in trunk/Source/WebCore
Add an ancestor renderer iterator.
<https://webkit.org/b/123718>
Add ancestor iterators for renderers, analogous to element ancestor
iterators. They walk the chain of parent renderers, stopping at each
ancestor of a certain type.
Just like child renderer iterators, this requires isRendererOfType()
to be implemented for the targeted renderer class.
You use them like this:
auto frameSets = ancestorsOfType<RenderFrameSet>(*this);
for (auto frameSet = frameSets.begin(), end = frameSets.end(); frameSet != end; ++frameSet)
frameSet->thisOrThat();
To complete the patch, I put them to use in a couple of random places.
Reviewed by Antti Koivisto.
- 12:40 AM Changeset in webkit [158560] by
-
- 2 edits14 moves2 adds11 deletes in trunk/LayoutTests
Optimize baselines: fast/images
Unreviewed; run "webkit-patch optimize-baselines fast/images"
- fast/images/crossfade-client-not-removed-crash-expected.txt:
- fast/images/embed-image-expected.png: Renamed from LayoutTests/platform/efl/fast/images/embed-image-expected.png.
- fast/images/exif-orientation-css-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-css-expected.txt.
- fast/images/exif-orientation-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-expected.txt.
- fast/images/icon-decoding-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/icon-decoding-expected.txt.
- fast/images/image-in-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.png.
- fast/images/image-in-map-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.txt.
- fast/images/imagemap-focus-ring-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt.
- fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/support-broken-image-delegate-expected.txt.
- platform/efl-wk2/fast/images/imagemap-circle-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-circle-focus-ring-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png.
- platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png.
- platform/efl-wk2/fast/images/imagemap-polygon-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-polygon-focus-ring-expected.png.
- platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/gtk/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/gtk/fast/images/embed-image-expected.png: Removed.
- platform/gtk/fast/images/exif-orientation-css-expected.txt: Removed.
- platform/gtk/fast/images/icon-decoding-expected.txt: Removed.
- platform/gtk/fast/images/image-in-map-expected.png: Removed.
- platform/gtk/fast/images/image-in-map-expected.txt: Removed.
- platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
- platform/mac/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
- platform/mac/fast/images/exif-orientation-css-expected.txt: Removed.
- platform/mac/fast/images/exif-orientation-expected.txt: Removed.
- platform/win-7sp0/fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/win/fast/images/support-broken-image-delegate-expected.txt.
- 12:28 AM Changeset in webkit [158559] by
-
- 7 edits in trunk/Source/WebCore
[CSSRegions] Use auto keyword to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=123699
Reviewed by Anders Carlsson.
Start using auto keyword for loops.
Also, since region breaks (forced breaks) can be added only on boxes,
i changed RenderFlowThread::addForcedRegionBreak to use a RenderBox* instead of RenderObject*.
No change in functionality, no new tests.
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::styleDidChange):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::hasCompositingRegionDescendant):
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::updateLayerToRegionMappings):
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):
(WebCore::RenderFlowThread::regionInRange):
(WebCore::RenderFlowThread::checkRegionsWithStyling):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
(WebCore::RenderFlowThread::collectLayerFragments):
(WebCore::RenderFlowThread::fragmentsBoundingBox):
(WebCore::RenderFlowThread::addRegionsVisualEffectOverflow):
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsLayoutOverflow):
(WebCore::RenderFlowThread::clearRegionsOverflow):
- rendering/RenderFlowThread.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::addRegionToList):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::pushDependencies):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
- 12:12 AM GStreamer/GStreamerOnMac edited by
- (diff)
Nov 3, 2013:
- 11:10 PM Changeset in webkit [158558] by
-
- 3 edits in trunk/Source/WebCore
PingLoader objects unnecessarily pass through OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122942
Reviewed by Darin Adler.
There's no need to store new PingLoader objects into an OwnPtr just to leak them out a few lines later
into an unused variable. New objects are created through a new helper method and then left unmanaged as
they're guaranteed to destroy themselves when they receive a response of any kind.
- loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage): Call the new createPingLoader method to spawn the PingLoader.
(WebCore::PingLoader::sendPing): Ditto.
(WebCore::PingLoader::sendViolationReport): Ditto.
(WebCore::PingLoader::createPingLoader): A helper method that creates a new PingLoader object
- loader/PingLoader.h: Declare the new PingLoader::createPingLoader method.
- 11:02 PM MathML 3 testsuite results edited by
- updating msqrt tests 6,7,8 to reflect progress. (diff)
- 10:55 PM MathML 3 testsuite results edited by
- updating mrow test 2 to reflect progress. (diff)
- 10:54 PM Changeset in webkit [158557] by
-
- 7 edits in trunk/Source/WebCore
HTMLOptionsCollection is always rooted at a HTMLSelectElement.
<https://webkit.org/b/123719>
Tighten up HTMLOptionsCollection by making the constructor take
a HTMLSelectElement& and adding a HTMLSelectElement& getter instead
of casting all over the place. Removed now-pointless assertions.
Reviewed by Sam Weinig.
- 10:53 PM MathML 3 testsuite results edited by
- Updated test results for mover 7,8,10,11,12 to reflect progress. (diff)
- 10:50 PM MathML 3 testsuite results edited by
- Updated test results for mover 1-5 to reflect progress. (diff)
- 9:55 PM MathML 3 testsuite results edited by
- Updated mfrac results for tests 2,3, and 4. (diff)
- 8:24 PM Changeset in webkit [158556] by
-
- 3 edits3 adds in trunk
Generated color wheel displays incorrectly (regressed in r155567)
https://bugs.webkit.org/show_bug.cgi?id=123664
Source/JavaScriptCore:
Reviewed by Andreas Kling.
Interestingly, r155567 just "un-broke" the attempt to constant-fold ArithMod, but
that constant folding was just wrong to begin with. There is no evidence that this
constant folding rule is profitable. I'm removing it instead of trying to think
about what it means for it to be correct.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
LayoutTests:
Reviewed by Andreas Kling.
- js/dfg-mod-1-expected.txt: Added.
- js/dfg-mod-1.html: Added.
- js/script-tests/dfg-mod-1.js: Added.
(foo):
- 8:12 PM Changeset in webkit [158555] by
-
- 1 edit66 moves70 deletes in trunk/LayoutTests
Optimize baselines: fast/repaint
Unreviewed; run "webkit-patch optimize-baselines fast/repaint"
- fast/repaint/4774354-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/4774354-expected.txt.
- fast/repaint/absolute-position-changed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/absolute-position-changed-expected.png.
- fast/repaint/block-selection-gap-stale-cache-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-2-expected.png.
- fast/repaint/block-selection-gap-stale-cache-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-expected.png.
- fast/repaint/box-shadow-inset-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt.
- fast/repaint/button-spurious-layout-hint-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/button-spurious-layout-hint-expected.png.
- fast/repaint/canvas-putImageData-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/canvas-putImageData-expected.png.
- fast/repaint/clip-with-layout-delta-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clip-with-layout-delta-expected.txt.
- fast/repaint/content-into-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/content-into-overflow-expected.png.
- fast/repaint/erase-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/erase-overflow-expected.png.
- fast/repaint/fixed-after-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-after-scroll-expected.png.
- fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png.
- fast/repaint/fixed-position-transparency-with-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-position-transparency-with-overflow-expected.png.
- fast/repaint/fixed-scale-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scale-expected.png.
- fast/repaint/fixed-scroll-simple-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scroll-simple-expected.png.
- fast/repaint/fixed-table-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-cell-expected.png.
- fast/repaint/fixed-table-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-expected.png.
- fast/repaint/fixed-table-overflow-zindex-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png.
- fast/repaint/fixed-tranformed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-tranformed-expected.png.
- fast/repaint/float-in-new-block-with-layout-delta-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
- fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
- fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
- fast/repaint/inline-block-resize-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-block-resize-expected.png.
- fast/repaint/inline-horizontal-bt-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-horizontal-bt-overflow-expected.txt.
- fast/repaint/inline-vertical-lr-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.png.
- fast/repaint/inline-vertical-lr-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.txt.
- fast/repaint/inline-vertical-rl-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.png.
- fast/repaint/inline-vertical-rl-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.txt.
- fast/repaint/intermediate-layout-position-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/intermediate-layout-position-clip-expected.png.
- fast/repaint/japanese-rl-selection-clear-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt.
- fast/repaint/japanese-rl-selection-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt.
- fast/repaint/layer-hide-when-needs-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.png.
- fast/repaint/layer-visibility-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-visibility-expected.png.
- fast/repaint/line-in-scrolled-clipped-block-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/line-in-scrolled-clipped-block-expected.txt.
- fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-path-expected.txt.
- fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
- fast/repaint/overflow-clip-subtree-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png.
- fast/repaint/overflow-into-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-into-content-expected.png.
- fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
- fast/repaint/reflection-repaint-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/reflection-repaint-test-expected.txt.
- fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
- fast/repaint/repaint-during-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-expected.png.
- fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt.
- fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png.
- fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
- fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png.
- fast/repaint/scroll-fixed-reflected-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png.
- fast/repaint/scroll-in-clipped-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-clipped-layer-expected.png.
- fast/repaint/scroll-in-fixed-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png.
- fast/repaint/subtree-root-clip-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-2-expected.png.
- fast/repaint/subtree-root-clip-3-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-3-expected.png.
- fast/repaint/subtree-root-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-expected.png.
- fast/repaint/table-cell-vertical-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/table-cell-vertical-overflow-expected.txt.
- fast/repaint/table-col-background-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-col-background-expected.png.
- fast/repaint/table-outer-border-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-outer-border-expected.png.
- fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
- fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
- fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.
- fast/repaint/table-row-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-row-expected.png.
- fast/repaint/table-section-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-section-overflow-expected.png.
- fast/repaint/transform-layout-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/transform-layout-repaint-expected.txt.
- fast/repaint/view-background-from-body-1-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-1-expected.png.
- fast/repaint/view-background-from-body-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-2-expected.png.
- platform/efl-wk2/fast/repaint/selection-after-delete-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-delete-expected.png.
- platform/efl-wk2/fast/repaint/selection-after-remove-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-remove-expected.png.
- platform/efl-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png.
- platform/gtk/fast/repaint/4774354-expected.txt: Removed.
- platform/gtk/fast/repaint/absolute-position-changed-expected.png: Removed.
- platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Removed.
- platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
- platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
- platform/gtk/fast/repaint/canvas-putImageData-expected.png: Removed.
- platform/gtk/fast/repaint/clip-with-layout-delta-expected.txt: Removed.
- platform/gtk/fast/repaint/content-into-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/erase-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-after-scroll-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-scale-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-scroll-simple-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-cell-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-table-overflow-zindex-expected.png: Removed.
- platform/gtk/fast/repaint/fixed-tranformed-expected.png: Removed.
- platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
- platform/gtk/fast/repaint/inline-block-resize-expected.png: Removed.
- platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png: Removed.
- platform/gtk/fast/repaint/layer-visibility-expected.png: Removed.
- platform/gtk/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Removed.
- platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
- platform/gtk/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-into-content-expected.png: Removed.
- platform/gtk/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/reflection-repaint-test-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-expected.png: Removed.
- platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
- platform/gtk/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
- platform/gtk/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Removed.
- platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
- platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/gtk/fast/repaint/table-col-background-expected.png: Removed.
- platform/gtk/fast/repaint/table-outer-border-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
- platform/gtk/fast/repaint/table-row-expected.png: Removed.
- platform/gtk/fast/repaint/table-section-overflow-expected.png: Removed.
- platform/gtk/fast/repaint/transform-layout-repaint-expected.txt: Removed.
- platform/gtk/fast/repaint/view-background-from-body-1-expected.png: Removed.
- platform/gtk/fast/repaint/view-background-from-body-2-expected.png: Removed.
- platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- platform/mac/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/float-overflow-right-expected.txt: Removed.
- platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
- platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
- platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
- 7:21 PM Changeset in webkit [158554] by
-
- 5 edits in trunk
Source/JavaScriptCore: Unreviewed, it is no longer necessary to call DisablePrettyStackTrace.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
WebKitLibraries: Update binary drops to a version that includes my pretty stack trace changes.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 7:01 PM Changeset in webkit [158553] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707
Reviewed by Geoff Garen and Anders Carlsson.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries): Added this accessor.
- 6:57 PM Changeset in webkit [158552] by
-
- 4 edits in trunk/Source/WebKit2
Reverted r158538.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]):
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]):
- Shared/ImmutableArray.h:
- 4:39 PM Changeset in webkit [158551] by
-
- 5 edits in trunk/Source/WebCore
RenderTextFragment: Tighten first-letter logic.
<https://webkit.org/b/123714>
Reviewed by Antti Koivisto.
- editing/TextIterator.cpp:
(WebCore::firstRenderTextInFirstLetter):
Use iterator helper to find first RenderText child.
(WebCore::TextIterator::handleTextNodeFirstLetter):
Tightening through type inference.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
- rendering/RenderTextFragment.h:
The first letter renderer is always a RenderBoxModelObject,
so make the code deal in that instead of RenderObject.
- rendering/RenderChildIterator.h:
(WebCore::RenderChildIteratorAdapter::first):
(WebCore::RenderChildIteratorAdapter::last):
Remove excess ampersands that were keeping this from building.
- 4:35 PM Changeset in webkit [158550] by
-
- 2 edits2 copies12 moves2 adds13 deletes in trunk/LayoutTests
Optimize baselines: fast/forms
Unreviewed; run "webkit-patch optimize-baselines fast/forms"
- fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
- fast/forms/fieldset-with-float-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/fieldset-with-float-expected.txt.
- fast/forms/input-no-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/input-no-renderer-expected.txt.
- fast/forms/label/labelable-elements-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/label/labelable-elements-expected.txt.
- fast/forms/range/slider-thumb-stylability-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/range/slider-thumb-stylability-expected.png.
- fast/forms/select-listbox-multiple-no-focusring-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
- fast/forms/select-overflow-scroll-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-expected.txt.
- fast/forms/select-overflow-scroll-inherited-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-inherited-expected.txt.
- fast/forms/textfield-overflow-by-value-update-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.png.
- fast/forms/textfield-overflow-by-value-update-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.txt.
- platform/efl-wk2/fast/forms/validation-message-appearance-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/validation-message-appearance-expected.png.
- platform/gtk/fast/forms/fieldset-with-float-expected.txt: Removed.
- platform/gtk/fast/forms/input-no-renderer-expected.txt: Removed.
- platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Removed.
- platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Removed.
- platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Removed.
- platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Removed.
- platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.png: Removed.
- platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
- platform/mac/fast/forms/label/labelable-elements-expected.txt: Removed.
- platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Removed.
- platform/win-7sp0/fast/forms/cursor-at-editable-content-boundary-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt.
- platform/win-7sp0/fast/forms/implicit-submission-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt.
- platform/win-7sp0/fast/forms/range/slider-mouse-events-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/range/slider-mouse-events-expected.txt.
- platform/win-7sp0/fast/forms/select-popup-pagekeys-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/select-popup-pagekeys-expected.txt.
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
- 4:15 PM Changeset in webkit [158549] by
-
- 4 edits in trunk/Source/WebCore
CSSPrimitiveValue identifier constructors should return PassRef.
<https://webkit.org/b/123712>
Make CSSPrimitiveValue::createIdentifier() and the corresponding
CSSValuePool helper return PassRef<CSSPrimitiveValue>.
Reviewed by Antti Koivisto.
- 4:13 PM Changeset in webkit [158548] by
-
- 4 edits in trunk/Source/WebCore
Use RenderChildIterator in two more loops.
<https://webkit.org/b/123713>
Switch two more renderer child traversal loops to childrenOfType.
Reviewed by Antti Koivisto.
- 3:43 PM Changeset in webkit [158547] by
-
- 2 edits36 moves2 adds36 deletes in trunk/LayoutTests
Optimize baselines: editing
Unreviewed; run "webkit-patch optimize-baselines editing"
- editing/deleting/delete-3775172-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/deleting/delete-3775172-fix-expected.png.
- editing/deleting/delete-after-span-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-001-expected.txt.
- editing/deleting/delete-after-span-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-002-expected.txt.
- editing/deleting/delete-after-span-ws-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-003-expected.txt.
- editing/deleting/delete-at-start-or-end-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-at-start-or-end-expected.txt.
- editing/deleting/delete-br-002-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt.
- editing/deleting/delete-br-004-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt.
- editing/deleting/delete-br-005-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt.
- editing/deleting/delete-br-006-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt.
- editing/deleting/delete-line-end-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-001-expected.txt.
- editing/deleting/delete-line-end-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-002-expected.txt.
- editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt:
- editing/inserting/insert-3851164-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/inserting/insert-3851164-fix-expected.png.
- editing/selection/5195166-1-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/5195166-1-expected.txt.
- editing/selection/editable-links-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/editable-links-expected.txt.
- editing/selection/focus-body-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/focus-body-expected.txt.
- editing/selection/select-all-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-001-expected.txt.
- editing/selection/select-all-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-002-expected.txt.
- editing/selection/select-all-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-003-expected.txt.
- editing/selection/select-all-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-004-expected.txt.
- editing/selection/unrendered-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-001-expected.txt.
- editing/selection/unrendered-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-002-expected.txt.
- editing/selection/unrendered-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-003-expected.txt.
- editing/selection/unrendered-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-004-expected.txt.
- editing/selection/unrendered-005-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-005-expected.txt.
- editing/undo/5378473-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/5378473-expected.txt.
- editing/undo/undo-misspellings-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/undo-misspellings-expected.txt.
- editing/unsupported-content/table-delete-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-001-expected.txt.
- editing/unsupported-content/table-delete-003-expected.png: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.png.
- editing/unsupported-content/table-delete-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.txt.
- platform/efl-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Renamed from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
- platform/efl/editing/caret/caret-color-expected.txt: Renamed from LayoutTests/editing/caret/caret-color-expected.txt.
- platform/efl/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-3775172-fix-expected.png: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Removed.
- platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Removed.
- platform/gtk/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/gtk/editing/inserting/insert-3851164-fix-expected.png: Removed.
- platform/gtk/editing/selection/editable-links-expected.txt: Removed.
- platform/gtk/editing/selection/focus-body-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-001-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-002-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-003-expected.txt: Removed.
- platform/gtk/editing/selection/select-all-004-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-001-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-002-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-003-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-004-expected.txt: Removed.
- platform/gtk/editing/selection/unrendered-005-expected.txt: Removed.
- platform/mac/editing/deleting/delete-at-start-or-end-expected.txt: Removed.
- platform/mac/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
- platform/mac/editing/inserting/insert-div-010-expected.txt: Renamed from LayoutTests/editing/inserting/insert-div-010-expected.txt.
- platform/mac/editing/selection/5195166-1-expected.txt: Removed.
- platform/mac/editing/style/unbold-in-bold-expected.txt: Renamed from LayoutTests/editing/style/unbold-in-bold-expected.txt.
- platform/mac/editing/undo/5378473-expected.txt: Removed.
- platform/mac/editing/undo/undo-misspellings-expected.txt: Removed.
- platform/mac/editing/unsupported-content/table-delete-001-expected.txt: Removed.
- platform/mac/editing/unsupported-content/table-delete-003-expected.png: Removed.
- platform/mac/editing/unsupported-content/table-delete-003-expected.txt: Removed.
- platform/win-7sp0/editing/selection/collapse-selection-in-bidi-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
- platform/win-7sp0/editing/selection/drag-text-delay-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/drag-text-delay-expected.txt.
- platform/win-7sp0/editing/selection/extend-selection-home-end-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/extend-selection-home-end-expected.txt.
- platform/win/editing/deleting/delete-br-002-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-004-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-005-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-006-expected.txt: Removed.
- platform/win/editing/deleting/delete-br-009-expected.txt: Removed.
- platform/win/editing/inserting/insert-3800346-fix-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus2-expected.txt: Removed.
- platform/win/editing/selection/anchor-focus3-expected.txt: Removed.
- 3:32 PM Changeset in webkit [158546] by
-
- 3 edits55 moves2 adds80 deletes in trunk/LayoutTests
Optimize baselines: tables
Unreviewed; run "webkit-patch optimize-baselines tables"
- platform/gtk/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-3-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug102145-4-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug10269-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug10296-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug103533-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug11321-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug13105-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug14159-3-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug149275-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug1818-6-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug196870-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug222336-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug222467-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug23072-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug23151-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug23994-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug26553-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug269566-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug275625-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug277062-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
- platform/gtk/tables/mozilla/bugs/bug28933-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug3037-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug32447-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug34538-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug56405-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug641-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug75250-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug8032-2-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug8361-expected.png: Removed.
- platform/gtk/tables/mozilla/bugs/bug9024-expected.png: Removed.
- platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Removed.
- platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Removed.
- platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug120107-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1271-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug13169-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug157890-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug196870-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222336-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug222467-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug269566-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug277062-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug28933-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug29314-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug2954-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug56201-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
- platform/mac-mountainlion/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
- platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
- platform/mac/tables/mozilla/core/row_span-expected.txt: Removed.
- platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
- platform/win-future/tables/mozilla/core/bloomberg-expected.txt: Renamed from LayoutTests/tables/mozilla/core/bloomberg-expected.txt.
- platform/win-future/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Renamed from LayoutTests/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt.
- platform/win/tables/mozilla/bugs/bug133756-1-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug133756-2-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug220536-expected.txt: Removed.
- platform/win/tables/mozilla/bugs/bug8858-expected.txt: Removed.
- platform/win/tables/mozilla/core/row_span-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
- platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Removed.
- tables/mozilla/bugs/adforce_imgis_com-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/adforce_imgis_com-expected.txt.
- tables/mozilla/bugs/bug102145-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-1-expected.png.
- tables/mozilla/bugs/bug102145-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-2-expected.png.
- tables/mozilla/bugs/bug102145-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-3-expected.png.
- tables/mozilla/bugs/bug102145-4-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-4-expected.png.
- tables/mozilla/bugs/bug10269-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10269-1-expected.png.
- tables/mozilla/bugs/bug10296-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10296-2-expected.png.
- tables/mozilla/bugs/bug103533-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug103533-expected.png.
- tables/mozilla/bugs/bug11321-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug11321-expected.png.
- tables/mozilla/bugs/bug12908-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug12908-2-expected.png.
- tables/mozilla/bugs/bug13105-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug13105-expected.png.
- tables/mozilla/bugs/bug133756-1-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-1-expected.txt.
- tables/mozilla/bugs/bug133756-2-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-2-expected.txt.
- tables/mozilla/bugs/bug14159-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug14159-3-expected.png.
- tables/mozilla/bugs/bug149275-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug149275-2-expected.txt.
- tables/mozilla/bugs/bug1818-6-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1818-6-expected.png.
- tables/mozilla/bugs/bug196870-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug196870-expected.png.
- tables/mozilla/bugs/bug220536-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug220536-expected.txt.
- tables/mozilla/bugs/bug222336-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222336-expected.png.
- tables/mozilla/bugs/bug222467-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222467-expected.png.
- tables/mozilla/bugs/bug23072-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23072-expected.png.
- tables/mozilla/bugs/bug23151-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23151-expected.txt.
- tables/mozilla/bugs/bug23994-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23994-expected.png.
- tables/mozilla/bugs/bug26553-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug26553-expected.txt.
- tables/mozilla/bugs/bug269566-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug269566-expected.png.
- tables/mozilla/bugs/bug27038-3-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt.
- tables/mozilla/bugs/bug275625-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug275625-expected.png.
- tables/mozilla/bugs/bug277062-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug277062-expected.png.
- tables/mozilla/bugs/bug2886-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt.
- tables/mozilla/bugs/bug28933-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug28933-expected.png.
- tables/mozilla/bugs/bug3037-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-1-expected.png.
- tables/mozilla/bugs/bug3037-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-2-expected.png.
- tables/mozilla/bugs/bug32447-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug32447-expected.png.
- tables/mozilla/bugs/bug34538-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug34538-expected.png.
- tables/mozilla/bugs/bug56405-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug56405-expected.png.
- tables/mozilla/bugs/bug641-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug641-2-expected.png.
- tables/mozilla/bugs/bug75250-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug75250-expected.png.
- tables/mozilla/bugs/bug8032-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8032-2-expected.png.
- tables/mozilla/bugs/bug8361-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8361-expected.png.
- tables/mozilla/bugs/bug8858-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug8858-expected.txt.
- tables/mozilla/bugs/bug9024-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug9024-expected.png.
- tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png.
- tables/mozilla/core/row_span-expected.txt:
- tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt.
- tables/mozilla_expected_failures/bugs/bug128876-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.png.
- tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- tables/mozilla_expected_failures/bugs/bug178855-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug178855-expected.png.
- tables/mozilla_expected_failures/bugs/bug3517-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.png.
- tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt.
- tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt.
- 2:26 PM Changeset in webkit [158545] by
-
- 3 edits in trunk/LayoutTests
Precision errors in Math.cbrt() on GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=123624
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-11-03
Reviewed by Csaba Osztrogonác.
Calculate cube roots of 8 and -8, expecting 2 and -2, respectively. Cube roots of those two
numbers don't contain precision errors on the GTK and EFL ports as is the case with 27 and -27.
- js/math-expected.txt:
- js/script-tests/math.js:
- 2:18 PM Changeset in webkit [158544] by
-
- 3 edits in trunk/Source/WebCore
CSSShadowValue constructor should return PassRef.
<https://webkit.org/b/123711>
Make CSSShadowValue::create() return a PassRef since it will never
return null.
Reviewed by Sam Weinig.
- 2:17 PM Changeset in webkit [158543] by
-
- 3 edits in trunk/Source/WebCore
CSSLineBoxContainValue constructor should return PassRef.
<https://webkit.org/b/123710>
Make CSSLineBoxContainValue::create() return a PassRef since it
will never return null.
Reviewed by Sam Weinig.
- 2:17 PM Changeset in webkit [158542] by
-
- 1 edit5 moves5 deletes in trunk/LayoutTests
Optimize baselines: fast/frames
Unreviewed; run "webkit-patch optimize-baselines fast/frames"
- fast/frames/002-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/002-expected.png.
- fast/frames/empty-cols-attribute-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/empty-cols-attribute-expected.png.
- fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt.
- fast/frames/frame-set-whitespace-attributes-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/frame-set-whitespace-attributes-expected.png.
- fast/frames/no-frame-borders-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/no-frame-borders-expected.png.
- platform/gtk/fast/frames/002-expected.png: Removed.
- platform/gtk/fast/frames/empty-cols-attribute-expected.png: Removed.
- platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Removed.
- platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.png: Removed.
- platform/gtk/fast/frames/no-frame-borders-expected.png: Removed.
- 1:52 PM Changeset in webkit [158541] by
-
- 4 edits in trunk/Source/JavaScriptCore
Assertion failure in non-JIT'ed LLInt on ARM Thumb.
https://bugs.webkit.org/show_bug.cgi?id=97569.
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerCodeRef.h:
- Thumb2 alignment assertions do not apply to the C Loop LLINT because the arguments passed to those assertions are actually OpcodeIDs masquerading as addresses.
- llint/LLIntOfflineAsmConfig.h:
- Some of the #defines belong in the !ENABLE(LLINT_C_LOOP) section. Moving them there.
- llint/LowLevelInterpreter.cpp:
- Keep the compiler happy from some unreferenced C Loop labels.
- 1:32 PM Changeset in webkit [158540] by
-
- 29 edits in trunk/Source/WebCore
LiveNodeLists should have non-null ContainerNode as root
https://bugs.webkit.org/show_bug.cgi?id=123709
Reviewed by Andreas Kling.
After moving ChildNodeList off from LiveNodeList the root is now always at least a ContainerNode.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):
Also these move from Node to ContainerNode to make tighter typing work.
- 1:08 PM Changeset in webkit [158539] by
-
- 1 edit21 moves24 deletes in trunk/LayoutTests
Optimize baselines: fast/table
Unreviewed; run "webkit-patch optimize-baselines fast/table"
- fast/table/022-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/022-expected.txt.
- fast/table/024-expected.png: Renamed from LayoutTests/platform/efl/fast/table/024-expected.png.
- fast/table/031-expected.png: Renamed from LayoutTests/platform/efl/fast/table/031-expected.png.
- fast/table/032-expected.png: Renamed from LayoutTests/platform/efl/fast/table/032-expected.png.
- fast/table/034-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/034-expected.txt.
- fast/table/auto-100-percent-width-expected.png: Renamed from LayoutTests/platform/efl/fast/table/auto-100-percent-width-expected.png.
- fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Renamed from LayoutTests/platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png.
- fast/table/div-as-col-span-expected.png: Renamed from LayoutTests/platform/efl/fast/table/div-as-col-span-expected.png.
- fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt.
- fast/table/giantCellspacing-expected.png: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.png.
- fast/table/giantCellspacing-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.txt.
- fast/table/giantRowspan-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantRowspan-expected.txt.
- fast/table/giantRowspan2-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/giantRowspan2-expected.txt.
- fast/table/percent-widths-stretch-vertical-expected.png: Renamed from LayoutTests/platform/efl/fast/table/percent-widths-stretch-vertical-expected.png.
- fast/table/table-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-before-child-style-update-expected.png.
- fast/table/table-row-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-before-child-style-update-expected.png.
- fast/table/table-row-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-expected.png.
- fast/table/table-row-style-not-updated-with-after-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.png.
- fast/table/table-row-style-not-updated-with-before-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.png.
- fast/table/table-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-style-not-updated-expected.png.
- fast/table/vertical-align-baseline-readjust-expected.png: Renamed from LayoutTests/platform/efl/fast/table/vertical-align-baseline-readjust-expected.png.
- platform/gtk/fast/table/022-expected.txt: Removed.
- platform/gtk/fast/table/024-expected.png: Removed.
- platform/gtk/fast/table/031-expected.png: Removed.
- platform/gtk/fast/table/032-expected.png: Removed.
- platform/gtk/fast/table/034-expected.txt: Removed.
- platform/gtk/fast/table/auto-100-percent-width-expected.png: Removed.
- platform/gtk/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Removed.
- platform/gtk/fast/table/div-as-col-span-expected.png: Removed.
- platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Removed.
- platform/gtk/fast/table/giantCellspacing-expected.png: Removed.
- platform/gtk/fast/table/giantCellspacing-expected.txt: Removed.
- platform/gtk/fast/table/giantRowspan-expected.txt: Removed.
- platform/gtk/fast/table/percent-widths-stretch-vertical-expected.png: Removed.
- platform/gtk/fast/table/table-before-child-style-update-expected.png: Removed.
- platform/gtk/fast/table/table-row-before-child-style-update-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.png: Removed.
- platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.png: Removed.
- platform/gtk/fast/table/table-style-not-updated-expected.png: Removed.
- platform/gtk/fast/table/vertical-align-baseline-readjust-expected.png: Removed.
- platform/mac/fast/table/022-expected.txt: Removed.
- platform/mac/fast/table/giantCellspacing-expected.txt: Removed.
- platform/mac/fast/table/giantRowspan-expected.txt: Removed.
- platform/win/fast/table/giantRowspan-expected.txt: Removed.
- platform/win/fast/table/giantRowspan2-expected.txt: Removed.
- 12:41 PM Changeset in webkit [158538] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707
Reviewed by Geoff Garen.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::entries): Added this accessor.
- 12:19 PM Changeset in webkit [158537] by
-
- 5 edits in trunk/Source/WebCore
Switch createContextualFragment to element iterator
https://bugs.webkit.org/show_bug.cgi?id=123704
Reviewed by Andreas Kling.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
Use type helpers instead of hasTagName
- editing/markup.cpp:
(WebCore::collectElementsToRemoveFromFragment):
(WebCore::removeElementFromFragmentPreservingChildren):
(WebCore::createContextualFragment):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
Use type helpers instead of hasTagName
- html/HTMLTagNames.in:
Generate type helpers for <html>.
- 11:52 AM Changeset in webkit [158536] by
-
- 11 edits in trunk/Source/WebCore
ChildNodeList should not be LiveNodeList
https://bugs.webkit.org/show_bug.cgi?id=123708
Reviewed by Sam Weinig.
ChildNodeList is a poor fit to be a LiveNodeList. It is heavily special-cased. It is also
the only subtype that returns non-Elements thus preventing tightening.
- bindings/js/JSNodeListCustom.cpp:
(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
Support new types.
- dom/ChildNodeList.cpp:
(WebCore::EmptyNodeList::~EmptyNodeList):
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::~ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::childFromFirst):
(WebCore::childFromLast):
(WebCore::ChildNodeList::nodeBeforeCached):
(WebCore::ChildNodeList::nodeAfterCached):
(WebCore::ChildNodeList::item):
(WebCore::ChildNodeList::namedItem):
(WebCore::ChildNodeList::invalidateCache):
Implement the same caching optimizations as LiveNodeList with tighter, less generic code.
- dom/ChildNodeList.h:
Inherit ChildNodeList directly from NodeList.
Add new EmptyNodeList type. This is only ever used if NodeList is requested for a non-container node.
It allows tighter typing in ChildNodeList.
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeList::namedItem):
- dom/LiveNodeList.h:
(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::~LiveNodeListBase):
(WebCore::LiveNodeList::LiveNodeList):
Remove ChildNodeList specific code and branches.
- dom/Node.cpp:
(WebCore::Node::childNodes):
Return EmptyNodeList for non-containers.
- dom/NodeList.h:
(WebCore::NodeList::~NodeList):
(WebCore::NodeList::isLiveNodeList):
(WebCore::NodeList::isChildNodeList):
(WebCore::NodeList::isEmptyNodeList):
For isReachableFromOpaqueRoots.
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::ensureChildNodeList):
(WebCore::NodeListsNodeData::removeChildNodeList):
(WebCore::NodeListsNodeData::ensureEmptyChildNodeList):
(WebCore::NodeListsNodeData::removeEmptyChildNodeList):
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):
EmptyNodeList support.
- html/CollectionType.h:
- html/HTMLCollection.cpp:
(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeListBase::traverseLiveNodeListForwardToOffset):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):
Remove ChildNodeList specific code and branches.
- 10:24 AM Changeset in webkit [158535] by
-
- 14 edits in trunk/Source/JavaScriptCore
FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and stack layout
https://bugs.webkit.org/show_bug.cgi?id=122318
Reviewed by Geoffrey Garen.
This all now works. This patch just updates our implementation to work with LLVM trunk,
and removes all of the old code that tried to do OSR exits and heap accesses without
the benefit of those intrinsics.
In particular:
- StackMaps parsing now uses the new, less compact, but more future-proof, format.
- Remove the ftlUsesStackmaps() option and hard-code ftlUsesStackmaps = true. Remove all code for ftlUsesStackmaps = false, since that was only there for back when we didn't have the intrinsics.
- Remove the other experimental OSR options (useLLVMOSRExitIntrinsic, ftlTrapsOnOSRExit, and FTLOSRExitOmitsMarshalling).
- Remove LowerDFGToLLVM's use of the ExitThunkGenerator since we don't need to generate the exit thunks until after we parse the stackmaps.
- Remove all of the exit thunk and compiler code for the no-stackmaps case.
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::callStackmap):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::parse):
(WTF::printInternal):
- ftl/FTLStackMaps.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
- ftl/FTLThunks.h:
(JSC::FTL::Thunks::getOSRExitGenerationThunk):
- runtime/Options.h:
- 9:51 AM Changeset in webkit [158534] by
-
- 2 edits in trunk/Tools
Add test for ListHashSet::removeLast()
https://bugs.webkit.org/show_bug.cgi?id=121810
Reviewed by Anders Carlsson.
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
- 9:48 AM Changeset in webkit [158533] by
-
- 10 edits in trunk/Source
[WINCE] Replace OwnPtr with GDIObject
https://bugs.webkit.org/show_bug.cgi?id=123670
Reviewed by Anders Carlsson.
Source/WebCore:
- page/win/FrameGdiWin.cpp:
(WebCore::imageFromRect):
- platform/graphics/wince/FontPlatformData.cpp:
(WebCore::FixedSizeFontData::create):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::getScaledFontHandle):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::createPen):
(WebCore::createBrush):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::drawRoundCorner):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawText):
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
- platform/graphics/wince/SharedBitmap.cpp:
(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::draw):
(WebCore::SharedBitmap::clipBitmap):
(WebCore::drawPatternSimple):
(WebCore::SharedBitmap::drawPattern):
(WebCore::SharedBitmap::DCProvider::getDC):
- platform/graphics/wince/SharedBitmap.h:
Source/WebKit/wince:
- WebView.cpp:
(WebView::paint):
(WebView::handlePaint):
- WebView.h:
- 6:55 AM Changeset in webkit [158532] by
-
- 2 edits in trunk/LayoutTests
[EFL][WK1] Some tests of editing/selection fail to render properly
https://bugs.webkit.org/show_bug.cgi?id=117574
Unreviewed, EFL gardening.
These tests are passed in wk1(and wk2), but skipped in wk1.
These tests have been reviewed since those are added.
Now these tests are operating properly, so those need to update the test expectations.
Also 'editing/selection/caret-and-focus-ring.html' is already changed a reason of failure by Bug no.123696
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-03
- platform/efl-wk1/TestExpectations:
- 3:19 AM Changeset in webkit [158531] by
-
- 1 edit36 moves30 deletes in trunk/LayoutTests
Optimize baselines: fast/text
Unreviewed; run "webkit-patch optimize-baselines fast/text"
- fast/text/decorations-transformed-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/decorations-transformed-expected.txt.
- fast/text/fixed-pitch-control-characters-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/fixed-pitch-control-characters-expected.txt.
- fast/text/international/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/001-expected.txt.
- fast/text/international/vertical-text-glyph-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt.
- fast/text/international/vertical-text-metrics-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-metrics-test-expected.txt.
- fast/text/international/wrap-CJK-001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/wrap-CJK-001-expected.txt.
- fast/text/justify-ideograph-complex-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-complex-expected.txt.
- fast/text/justify-ideograph-simple-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-simple-expected.txt.
- fast/text/justify-ideograph-vertical-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-vertical-expected.txt.
- fast/text/selection-painted-separately-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/selection-painted-separately-expected.txt.
- fast/text/soft-hyphen-2-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-2-expected.txt.
- fast/text/soft-hyphen-3-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-3-expected.txt.
- fast/text/stripNullFromText-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stripNullFromText-expected.png.
- fast/text/updateNewFont-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/updateNewFont-expected.txt.
- fast/text/whitespace/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/001-expected.txt.
- fast/text/whitespace/013-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/013-expected.txt.
- fast/text/whitespace/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/014-expected.txt.
- fast/text/whitespace/017-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.png.
- fast/text/whitespace/017-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.txt.
- fast/text/whitespace/029-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.png.
- fast/text/whitespace/029-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.txt.
- fast/text/whitespace/pre-newline-box-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/pre-newline-box-test-expected.txt.
- fast/text/whitespace/tab-character-basics-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/tab-character-basics-expected.txt.
- platform/efl-wk1/fast/text/complex-text-opacity-expected.png: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.png.
- platform/efl-wk1/fast/text/complex-text-opacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.txt.
- platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.png: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png.
- platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt.
- platform/efl-wk2/fast/text/atsui-pointtooffset-calls-cg-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png.
- platform/efl-wk2/fast/text/atsui-rtl-override-selection-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-rtl-override-selection-expected.png.
- platform/efl-wk2/fast/text/atsui-small-caps-punctuation-size-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png.
- platform/efl-wk2/fast/text/hyphenate-character-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-character-expected.png.
- platform/efl-wk2/fast/text/hyphenate-first-word-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-first-word-expected.png.
- platform/efl-wk2/fast/text/hyphenate-limit-before-after-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-before-after-expected.png.
- platform/efl-wk2/fast/text/hyphenate-limit-lines-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-lines-expected.png.
- platform/efl-wk2/fast/text/hyphens-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphens-expected.png.
- platform/efl-wk2/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png.
- platform/gtk/fast/text/decorations-transformed-expected.txt: Removed.
- platform/gtk/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
- platform/gtk/fast/text/international/001-expected.txt: Removed.
- platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
- platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.
- platform/gtk/fast/text/international/wrap-CJK-001-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-complex-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-simple-expected.txt: Removed.
- platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Removed.
- platform/gtk/fast/text/selection-painted-separately-expected.txt: Removed.
- platform/gtk/fast/text/soft-hyphen-2-expected.txt: Removed.
- platform/gtk/fast/text/soft-hyphen-3-expected.txt: Removed.
- platform/gtk/fast/text/stripNullFromText-expected.png: Removed.
- platform/gtk/fast/text/updateNewFont-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/001-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/017-expected.png: Removed.
- platform/gtk/fast/text/whitespace/017-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/029-expected.png: Removed.
- platform/gtk/fast/text/whitespace/029-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/pre-newline-box-test-expected.txt: Removed.
- platform/gtk/fast/text/whitespace/tab-character-basics-expected.txt: Removed.
- platform/mac/fast/text/decorations-transformed-expected.txt: Removed.
- platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
- platform/mac/fast/text/selection-painted-separately-expected.txt: Removed.
- platform/mac/fast/text/soft-hyphen-2-expected.txt: Removed.
- platform/mac/fast/text/soft-hyphen-3-expected.txt: Removed.
- platform/mac/fast/text/whitespace/001-expected.txt: Removed.
- platform/mac/fast/text/whitespace/013-expected.txt: Removed.
- platform/mac/fast/text/whitespace/014-expected.txt: Removed.
- platform/mac/fast/text/whitespace/017-expected.txt: Removed.
- 3:13 AM Changeset in webkit [158530] by
-
- 5 edits in trunk/Source/WebCore
Add helpers for partial descendant traversal to element iterators
https://bugs.webkit.org/show_bug.cgi?id=123703
Reviewed by Andreas Kling.
- dom/ElementAncestorIterator.h:
(WebCore::lineageOfType):
lineageOfType definition didn't match the declaration.
- dom/ElementDescendantIterator.h:
(WebCore::::find):
(WebCore::::from):
Add find and from for getting begin iterator for partial traversals.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::findClosestFormAncestor):
Use them in a few places.
- 1:54 AM Changeset in webkit [158529] by
-
- 3 edits in trunk/Source/WebCore
Inline RenderStyle functions for getting/setting pseudo style bits.
<https://webkit.org/b/123702>
hasPseudoStyle() actually shows up on html5-full-render.html,
and it's pretty crazy to eat the cost of a function call just
to do some basic bit twiddling.
Reviewed by Antti Koivisto.
- 1:41 AM Changeset in webkit [158528] by
-
- 1 edit8 moves1 add5 deletes in trunk/LayoutTests
Optimize baselines: fast/canvas
Unreviewed; run "webkit-patch optimize-baselines fast/canvas"
- fast/canvas/canvas-empty-image-pattern-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-empty-image-pattern-expected.png.
- fast/canvas/canvas-incremental-repaint-2-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-incremental-repaint-2-expected.png.
- fast/canvas/canvas-render-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-render-layer-expected.png.
- fast/canvas/set-colors-expected.txt: Renamed from LayoutTests/platform/efl/fast/canvas/set-colors-expected.txt.
- platform/gtk/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
- platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.png: Removed.
- platform/gtk/fast/canvas/canvas-render-layer-expected.png: Removed.
- platform/gtk/fast/canvas/set-colors-expected.txt: Removed.
- platform/win-7sp0/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-render-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-render-layer-expected.txt.
- platform/win-7sp0/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt.
- platform/win-xp/fast/canvas/set-colors-expected.txt: Removed.
- 1:30 AM Changeset in webkit [158527] by
-
- 77 edits2 deletes in trunk
Remove HTMLMediaElement.initialTime
https://bugs.webkit.org/show_bug.cgi?id=123572
Reviewed by Eric Carlson.
Source/WebCore:
Patch based on one by: philipj@opera.com
Blink review URL: https://codereview.chromium.org/35033002
initialTime has been removed from the HTMLMediaElement.
- bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_html_media_element_get_initial_time):
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl: Removed HTMLMediaElement::initialTime.
LayoutTests:
Blink review URL: https://codereview.chromium.org/35033002
Removed presence of initialTime in the tests.
- media/media-fragments/TC0001-expected.txt:
- media/media-fragments/TC0002-expected.txt:
- media/media-fragments/TC0003-expected.txt:
- media/media-fragments/TC0004-expected.txt:
- media/media-fragments/TC0005-expected.txt:
- media/media-fragments/TC0006-expected.txt:
- media/media-fragments/TC0009-expected.txt:
- media/media-fragments/TC0011-expected.txt:
- media/media-fragments/TC0012-expected.txt:
- media/media-fragments/TC0014-expected.txt:
- media/media-fragments/TC0015-expected.txt:
- media/media-fragments/TC0017-expected.txt:
- media/media-fragments/TC0024-expected.txt:
- media/media-fragments/TC0027-expected.txt:
- media/media-fragments/TC0028-expected.txt:
- media/media-fragments/TC0029-expected.txt:
- media/media-fragments/TC0030-expected.txt:
- media/media-fragments/TC0031-expected.txt:
- media/media-fragments/TC0032-expected.txt:
- media/media-fragments/TC0033-expected.txt:
- media/media-fragments/TC0034-expected.txt:
- media/media-fragments/TC0035-expected.txt:
- media/media-fragments/TC0036-expected.txt:
- media/media-fragments/TC0037-expected.txt:
- media/media-fragments/TC0038-expected.txt:
- media/media-fragments/TC0039-expected.txt:
- media/media-fragments/TC0044-expected.txt:
- media/media-fragments/TC0051-expected.txt:
- media/media-fragments/TC0052-expected.txt:
- media/media-fragments/TC0053-expected.txt:
- media/media-fragments/TC0054-expected.txt:
- media/media-fragments/TC0055-expected.txt:
- media/media-fragments/TC0058-expected.txt:
- media/media-fragments/TC0059-expected.txt:
- media/media-fragments/TC0061-expected.txt:
- media/media-fragments/TC0062-expected.txt:
- media/media-fragments/TC0063-expected.txt:
- media/media-fragments/TC0064-expected.txt:
- media/media-fragments/TC0065-expected.txt:
- media/media-fragments/TC0066-expected.txt:
- media/media-fragments/TC0067-expected.txt:
- media/media-fragments/TC0068-expected.txt:
- media/media-fragments/TC0069-expected.txt:
- media/media-fragments/TC0070-expected.txt:
- media/media-fragments/TC0071-expected.txt:
- media/media-fragments/TC0072-expected.txt:
- media/media-fragments/TC0073-expected.txt:
- media/media-fragments/TC0074-expected.txt:
- media/media-fragments/TC0075-expected.txt:
- media/media-fragments/TC0076-expected.txt:
- media/media-fragments/TC0077-expected.txt:
- media/media-fragments/TC0078-expected.txt:
- media/media-fragments/TC0079-expected.txt:
- media/media-fragments/TC0080-expected.txt:
- media/media-fragments/TC0081-expected.txt:
- media/media-fragments/TC0082-expected.txt:
- media/media-fragments/TC0083-expected.txt:
- media/media-fragments/TC0084-expected.txt:
- media/media-fragments/TC0085-expected.txt:
- media/media-fragments/TC0086-expected.txt:
- media/media-fragments/TC0087-expected.txt:
- media/media-fragments/TC0088-expected.txt:
- media/media-fragments/TC0089-expected.txt:
- media/media-fragments/TC0090-expected.txt:
- media/media-fragments/TC0091-expected.txt:
- media/media-fragments/TC0092-expected.txt:
- media/media-fragments/TC0093-expected.txt:
- media/media-fragments/TC0094-expected.txt:
- media/media-fragments/media-fragments.js:
(canplaythrough): Removed check for initialTime
- media/media-initialTime-expected.txt: Removed.
- media/media-initialTime.html: Removed.
Nov 2, 2013:
- 11:58 PM Changeset in webkit [158526] by
-
- 17 edits2 copies4 adds in trunk
Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669
Reviewed by Dan Bernstein.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-generate-key.html
crypto/subtle/hmac-generate-key.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.
- bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.
- crypto/CryptoAlgorithmAesKeyGenParams.h: Added.
- crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
- crypto/CryptoKey.h:
- crypto/CryptoKeyMac.cpp: Added
Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.
- crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
- crypto/CryptoKeyAES.h:
Added a function that creates AES keys.
- crypto/SubtleCrypto.idl: Added generateKey.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey): Added.
- crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
- crypto/keys/CryptoKeyHMAC.h:
Added a function that creates HMAC keys.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation
ended up in cross-platform file.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.
LayoutTests:
- crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
- crypto/subtle/aes-cbc-generate-key.html: Added.
- crypto/subtle/hmac-generate-key-expected.txt: Added.
- crypto/subtle/hmac-generate-key.html: Added.
- crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,
a different exception is raised.
- 11:50 PM Changeset in webkit [158525] by
-
- 1 edit35 moves2 adds39 deletes in trunk/LayoutTests
Optimize baselines: css3
Unreviewed; run "webkit-patch optimize-baselines css3"
- css3/images/cross-fade-background-size-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-background-size-expected.txt.
- css3/images/cross-fade-blending-expected.png: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.png.
- css3/images/cross-fade-blending-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.txt.
- css3/images/cross-fade-invalidation-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-invalidation-expected.txt.
- css3/images/cross-fade-simple-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-simple-expected.txt.
- css3/images/cross-fade-sizing-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-sizing-expected.txt.
- css3/images/cross-fade-tiled-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-tiled-expected.txt.
- css3/selectors3/html/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-17-expected.png.
- css3/selectors3/html/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-177a-expected.png.
- css3/selectors3/html/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-18c-expected.png.
- css3/selectors3/html/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27a-expected.png.
- css3/selectors3/html/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27b-expected.png.
- css3/selectors3/html/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-61-expected.png.
- css3/selectors3/xhtml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-123b-expected.png.
- css3/selectors3/xhtml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-17-expected.png.
- css3/selectors3/xhtml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-177a-expected.png.
- css3/selectors3/xhtml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-18c-expected.png.
- css3/selectors3/xhtml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27a-expected.png.
- css3/selectors3/xhtml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27b-expected.png.
- css3/selectors3/xhtml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-61-expected.png.
- css3/selectors3/xhtml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-91-expected.png.
- css3/selectors3/xhtml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-92-expected.png.
- css3/selectors3/xml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-123b-expected.png.
- css3/selectors3/xml/css3-modsel-167-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167-expected.png.
- css3/selectors3/xml/css3-modsel-167a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167a-expected.png.
- css3/selectors3/xml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-17-expected.png.
- css3/selectors3/xml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-177a-expected.png.
- css3/selectors3/xml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-18c-expected.png.
- css3/selectors3/xml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27a-expected.png.
- css3/selectors3/xml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27b-expected.png.
- css3/selectors3/xml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-61-expected.png.
- css3/selectors3/xml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-91-expected.png.
- css3/selectors3/xml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-92-expected.png.
- platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.png: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.png.
- platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.txt.
- platform/gtk/css3/images/cross-fade-blending-expected.png: Removed.
- platform/gtk/css3/images/cross-fade-blending-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-invalidation-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-simple-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-sizing-expected.txt: Removed.
- platform/gtk/css3/images/cross-fade-tiled-expected.txt: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-17-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-177a-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-18c-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-27a-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-27b-expected.png: Removed.
- platform/gtk/css3/selectors3/html/css3-modsel-61-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-123b-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-17-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-177a-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-18c-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-27a-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-27b-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-91-expected.png: Removed.
- platform/gtk/css3/selectors3/xhtml/css3-modsel-92-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-123b-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-167-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-167a-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-17-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-177a-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-18c-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-27a-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-27b-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-91-expected.png: Removed.
- platform/gtk/css3/selectors3/xml/css3-modsel-92-expected.png: Removed.
- platform/mac/css3/images/cross-fade-background-size-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-blending-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-invalidation-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-simple-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-sizing-expected.txt: Removed.
- platform/mac/css3/images/cross-fade-tiled-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-expected.txt: Removed.
- platform/win/css3/filters/effect-reference-hw-expected.txt: Removed.
- 11:25 PM Changeset in webkit [158524] by
-
- 1 edit72 moves73 deletes in trunk/LayoutTests
Optimize baselines: css2.1
Unreviewed; run "webkit-patch optimize-baselines css2.1"
- css2.1/20110323/absolute-replaced-height-036-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.png.
- css2.1/20110323/block-non-replaced-height-011-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-011-expected.png.
- css2.1/20110323/block-non-replaced-height-013-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-013-expected.png.
- css2.1/20110323/empty-inline-001-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/empty-inline-001-expected.png.
- css2.1/20110323/replaced-intrinsic-002-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.png.
- css2.1/20110323/replaced-intrinsic-002-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.txt.
- css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt.
- css2.1/t040105-atkeyw-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-00-b-expected.png.
- css2.1/t040105-atkeyw-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-01-b-expected.png.
- css2.1/t040105-atkeyw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-02-b-expected.png.
- css2.1/t040105-atrule-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-00-b-expected.png.
- css2.1/t040105-atrule-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-01-b-expected.png.
- css2.1/t040105-atrule-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-02-b-expected.png.
- css2.1/t040105-atrule-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-03-b-expected.png.
- css2.1/t040105-atrule-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-04-b-expected.png.
- css2.1/t040105-import-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-00-b-expected.png.
- css2.1/t040105-import-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-01-b-expected.png.
- css2.1/t040105-import-10-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-10-b-expected.png.
- css2.1/t0402-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-01-f-expected.png.
- css2.1/t0402-syntax-02-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-02-f-expected.png.
- css2.1/t0402-syntax-03-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-03-f-expected.png.
- css2.1/t0402-syntax-04-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-04-f-expected.png.
- css2.1/t0402-syntax-05-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-05-f-expected.png.
- css2.1/t0402-syntax-06-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-06-f-expected.png.
- css2.1/t040307-syntax-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040307-syntax-01-b-expected.png.
- css2.1/t0505-c16-descendant-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0505-c16-descendant-02-e-expected.png.
- css2.1/t0509-id-sel-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-01-f-expected.png.
- css2.1/t0509-id-sel-syntax-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-02-b-expected.png.
- css2.1/t0511-c21-pseud-link-00-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-00-e-expected.png.
- css2.1/t0511-c21-pseud-link-01-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-01-e-expected.png.
- css2.1/t0511-c21-pseud-link-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-02-e-expected.png.
- css2.1/t0511-c21-pseud-link-03-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-03-e-expected.png.
- css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-focus-ln-00-e-i-expected.png.
- css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-hover-ln-00-e-i-expected.png.
- css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0803-c5504-mrgn-l-02-c-expected.png.
- css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5511-brdr-tw-02-b-expected.png.
- css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5512-brdr-rw-02-b-expected.png.
- css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5513-brdr-bw-02-b-expected.png.
- css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5514-brdr-lw-02-b-expected.png.
- css2.1/t0805-c5515-brdr-w-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5515-brdr-w-02-b-expected.png.
- css2.1/t1001-abs-pos-cb-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.png.
- css2.1/t1001-abs-pos-cb-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.txt.
- css2.1/t1001-abs-pos-cb-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.png.
- css2.1/t1001-abs-pos-cb-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.txt.
- css2.1/t1001-abs-pos-cb-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.png.
- css2.1/t1001-abs-pos-cb-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.txt.
- css2.1/t1001-abs-pos-cb-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.png.
- css2.1/t1001-abs-pos-cb-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.txt.
- css2.1/t1001-abs-pos-cb-05-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.png.
- css2.1/t1001-abs-pos-cb-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.txt.
- css2.1/t1001-abs-pos-cb-06-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.png.
- css2.1/t1001-abs-pos-cb-06-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.txt.
- css2.1/t1001-abs-pos-cb-07-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.png.
- css2.1/t1001-abs-pos-cb-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.txt.
- css2.1/t1001-abs-pos-cb-08-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.png.
- css2.1/t1001-abs-pos-cb-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.txt.
- css2.1/t1001-abs-pos-cb-09-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.png.
- css2.1/t1001-abs-pos-cb-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.txt.
- css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1205-c566-list-stl-01-c-g-expected.txt.
- css2.1/t140201-c532-bgcolor-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c532-bgcolor-01-b-expected.png.
- css2.1/t140201-c533-bgimage-01-b-g-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c533-bgimage-01-b-g-expected.png.
- css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c536-bgpos-01-b-ag-expected.png.
- css2.1/t1508-c527-font-00-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-00-b-expected.txt.
- css2.1/t1508-c527-font-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-01-b-expected.txt.
- css2.1/t1508-c527-font-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-02-b-expected.txt.
- css2.1/t1508-c527-font-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-03-b-expected.txt.
- css2.1/t1508-c527-font-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-04-b-expected.txt.
- css2.1/t1508-c527-font-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-05-b-expected.txt.
- css2.1/t1508-c527-font-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-07-b-expected.txt.
- css2.1/t1508-c527-font-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-08-b-expected.txt.
- css2.1/t1508-c527-font-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-09-b-expected.txt.
- css2.1/t1508-c527-font-10-c-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-10-c-expected.txt.
- platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.png: Removed.
- platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.png: Removed.
- platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.png: Removed.
- platform/gtk/css2.1/20110323/empty-inline-001-expected.png: Removed.
- platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
- platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
- platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
- platform/gtk/css2.1/t040105-atkeyw-00-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atkeyw-01-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atkeyw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-00-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-01-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-02-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-03-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-atrule-04-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-import-00-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-import-01-b-expected.png: Removed.
- platform/gtk/css2.1/t040105-import-10-b-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-01-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-02-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-03-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-04-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-05-f-expected.png: Removed.
- platform/gtk/css2.1/t0402-syntax-06-f-expected.png: Removed.
- platform/gtk/css2.1/t040307-syntax-01-b-expected.png: Removed.
- platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.png: Removed.
- platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.png: Removed.
- platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.png: Removed.
- platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.png: Removed.
- platform/gtk/css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Removed.
- platform/gtk/css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Removed.
- platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Removed.
- platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.txt: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.png: Removed.
- platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.txt: Removed.
- platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Removed.
- platform/gtk/css2.1/t140201-c532-bgcolor-01-b-expected.png: Removed.
- platform/gtk/css2.1/t140201-c533-bgimage-01-b-g-expected.png: Removed.
- platform/gtk/css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Removed.
- platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-01-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-02-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-03-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-08-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-09-b-expected.txt: Removed.
- platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt: Removed.
- platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
- 11:04 PM Changeset in webkit [158523] by
-
- 1 edit14 moves2 adds12 deletes in trunk/LayoutTests
Optimize baselines: fast/dom
Unreviewed; run "webkit-patch optimize-baselines fast/dom"
- fast/dom/HTMLHeadElement/textInHead1-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead1-expected.txt.
- fast/dom/HTMLHeadElement/textInHead2-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead2-expected.txt.
- fast/dom/HTMLHeadElement/textInHead3-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead3-expected.txt.
- fast/dom/HTMLHeadElement/textInHead4-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead4-expected.txt.
- fast/dom/HTMLHeadElement/textInHead5-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead5-expected.txt.
- fast/dom/HTMLMeterElement/meter-element-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt.
- fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt.
- fast/dom/anchor-text-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/anchor-text-expected.txt.
- fast/dom/comment-not-documentElement-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/comment-not-documentElement-expected.txt.
- fast/dom/delete-contents-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/delete-contents-expected.png.
- fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-left-overflow-expected.txt.
- fast/dom/scroll-reveal-top-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-top-overflow-expected.txt.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead1-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead2-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead3-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead4-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLHeadElement/textInHead5-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
- platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
- platform/gtk/fast/dom/anchor-text-expected.txt: Removed.
- platform/gtk/fast/dom/comment-not-documentElement-expected.txt: Removed.
- platform/gtk/fast/dom/delete-contents-expected.png: Removed.
- platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Removed.
- platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Removed.
- platform/win-7sp0/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt.
- platform/win-7sp0/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
- 10:35 PM Changeset in webkit [158522] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Add missing baselines to EFL wk1 TestExpectation.
- platform/efl-wk1/TestExpectations: Need to add new baseline since upgrading base OS.
- 9:13 PM Changeset in webkit [158521] by
-
- 13 edits in trunk
EnforceRange doesn't enforce range of a short
https://bugs.webkit.org/show_bug.cgi?id=123661
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Handle Web IDL short / unsigned short types as per the
specification:
Specifically, we used to treat short / unsigned short as 32bit
integers, which was wrong. We now properly handle them as 16bit
integers.
No new tests, added test cases to js/dom/webidl-type-mapping.html.
- WebCore.exp.in:
- bindings/js/JSDOMBinding.cpp:
(WebCore::toSmallerInt):
(WebCore::toSmallerUInt):
(WebCore::toInt8):
(WebCore::toUInt8):
(WebCore::toInt16):
(WebCore::toUInt16):
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
- testing/TypeConversions.h:
(WebCore::TypeConversions::testShort):
(WebCore::TypeConversions::setTestShort):
(WebCore::TypeConversions::testEnforceRangeShort):
(WebCore::TypeConversions::setTestEnforceRangeShort):
(WebCore::TypeConversions::testUnsignedShort):
(WebCore::TypeConversions::setTestUnsignedShort):
(WebCore::TypeConversions::testEnforceRangeUnsignedShort):
(WebCore::TypeConversions::setTestEnforceRangeUnsignedShort):
- testing/TypeConversions.idl:
Source/WebKit:
Export symbols to fix Windows build.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
LayoutTests:
Extend js/dom/webidl-type-mapping.html layout test to validate
Web IDL type mapping for short / unsigned short.
- js/dom/webidl-type-mapping-expected.txt:
- js/dom/webidl-type-mapping.html:
- 8:25 PM Changeset in webkit [158520] by
-
- 2 edits in trunk/Source/WTF
Fix compilation of DateMath.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=123680
Reviewed by Darin Adler.
- wtf/DateMath.cpp:
(WTF::appendTwoDigitNumber): Help the compiler finding the
correct overload by casting the characters to LChar.
- 8:24 PM Changeset in webkit [158519] by
-
- 6 edits in trunk/Source/WebCore
Cleanup OpenTypeUtilities
https://bugs.webkit.org/show_bug.cgi?id=123686
Reviewed by Darin Adler.
Merge the WinCE specific code into the general Windows code to
make the compilation of WinCE port on WinNT easier.
- platform/graphics/opentype/OpenTypeUtilities.cpp:
(WebCore::renameFont):
(WebCore::renameAndActivateFont):
- platform/graphics/opentype/OpenTypeUtilities.h:
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::createFontCustomPlatformData):
- platform/graphics/wince/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
- 8:19 PM Changeset in webkit [158518] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing getHostCallReturnValue() for MSVC ARM
https://bugs.webkit.org/show_bug.cgi?id=123685
Reviewed by Darin Adler.
- jit/JITStubsARM.h:
- 8:18 PM Changeset in webkit [158517] by
-
- 1 edit26 moves34 deletes in trunk/LayoutTests
Optimize baselines: fast/css
Unreviewed; run "webkit-patch optimize-baselines fast/css"
- fast/css/background-image-with-baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/background-image-with-baseurl-expected.txt.
- fast/css/caption-width-absolute-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-expected.txt.
- fast/css/caption-width-absolute-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt.
- fast/css/caption-width-fixed-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-expected.txt.
- fast/css/caption-width-fixed-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt.
- fast/css/caption-width-relative-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-expected.txt.
- fast/css/caption-width-relative-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt.
- fast/css/font-face-default-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-default-font-expected.txt.
- fast/css/font-face-in-media-rule-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-in-media-rule-expected.txt.
- fast/css/font-size-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-size-negative-expected.txt.
- fast/css/imageTileOpacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/imageTileOpacity-expected.txt.
- fast/css/import_with_baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/import_with_baseurl-expected.txt.
- fast/css/line-height-determined-by-primary-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt.
- fast/css/line-height-font-order-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-font-order-expected.txt.
- fast/css/line-height-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-negative-expected.txt.
- fast/css/max-height-none-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/max-height-none-expected.txt.
- fast/css/min-width-with-spanned-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.png.
- fast/css/min-width-with-spanned-cell-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.txt.
- fast/css/min-width-with-spanned-cell-fixed-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt.
- fast/css/pseudo-first-line-border-width-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/pseudo-first-line-border-width-expected.txt.
- fast/css/replaced-element-implicit-size-expected.png: Renamed from LayoutTests/platform/efl/fast/css/replaced-element-implicit-size-expected.png.
- fast/css/vertical-align-lengths-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/vertical-align-lengths-expected.txt.
- fast/css/visibility-hit-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/visibility-hit-test-expected.txt.
- platform/efl-wk2/fast/css/font-smoothing-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-smoothing-expected.png.
- platform/efl-wk2/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-weight-1-expected.png.
- platform/efl-wk2/fast/css/input-search-padding-expected.png: Renamed from LayoutTests/platform/efl/fast/css/input-search-padding-expected.png.
- platform/gtk/fast/css/background-image-with-baseurl-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-absolute-position-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-fixed-position-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-relative-position-expected.txt: Removed.
- platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
- platform/gtk/fast/css/font-face-in-media-rule-expected.txt: Removed.
- platform/gtk/fast/css/font-size-negative-expected.txt: Removed.
- platform/gtk/fast/css/imageTileOpacity-expected.txt: Removed.
- platform/gtk/fast/css/import_with_baseurl-expected.txt: Removed.
- platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Removed.
- platform/gtk/fast/css/line-height-font-order-expected.txt: Removed.
- platform/gtk/fast/css/line-height-negative-expected.txt: Removed.
- platform/gtk/fast/css/max-height-none-expected.txt: Removed.
- platform/gtk/fast/css/min-width-with-spanned-cell-expected.png: Removed.
- platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
- platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
- platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
- platform/gtk/fast/css/replaced-element-implicit-size-expected.png: Removed.
- platform/gtk/fast/css/vertical-align-lengths-expected.txt: Removed.
- platform/gtk/fast/css/visibility-hit-test-expected.txt: Removed.
- platform/mac/fast/css/caption-width-absolute-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/caption-width-fixed-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/caption-width-relative-position-expected.txt: Removed.
- platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
- platform/mac/fast/css/font-face-default-font-expected.txt: Removed.
- platform/mac/fast/css/font-face-in-media-rule-expected.txt: Removed.
- platform/mac/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
- platform/mac/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
- platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
- platform/win/fast/css/zoom-body-scroll-expected.txt: Removed.
- 8:16 PM Changeset in webkit [158516] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC warning about unary minus operator
https://bugs.webkit.org/show_bug.cgi?id=123674
Reviewed by Darin Adler.
Change some static_cast<> to silence the following warning of Microsoft compiler:
warning C4146: unary minus operator applied to unsigned type, result still unsigned
- jit/Repatch.cpp:
(JSC::emitPutTransitionStub):
- 7:36 PM Changeset in webkit [158515] by
-
- 7 edits in trunk/Source/WebCore
CSSFontFaceSrcValue constructors should return PassRef.
<https://webkit.org/b/123692>
Make functions that return non-null CSSFontFaceSrcValues return
PassRef instead of PassRefPtr. Tweak some call sites to be
slightly more efficient.
Reviewed by Anders Carlsson.
- 7:33 PM Changeset in webkit [158514] by
-
- 17 edits in trunk/Source/WebCore
CSSStyleSheet::contents() should return a reference.
<https://webkit.org/b/123689>
Make CSSStyleSheet::contents() return a StyleSheetContents& instead
of a pointer. The object was already stored in a Ref.
Reviewed by Anders Carlsson.
- 7:14 PM Changeset in webkit [158513] by
-
- 3 edits in trunk/Source/WebCore
CSSReflectValue constructor should return PassRef.
<https://webkit.org/b/123963>
Make CSSReflectValue::create() return a PassRef. Tweak one call
site to be slightly more efficient.
Reviewed by Anders Carlsson.
- 7:12 PM Changeset in webkit [158512] by
-
- 3 edits in trunk/Source/WebCore
CSSFontFeatureValue constructor should return PassRef.
<https://webkit.org/b/123691>
Make CSSFontFeatureValue::create() return PassRef, since it never
returns null. Tweak one call site to be slightly more efficient.
Reviewed by Anders Carlsson.
- 7:04 PM Changeset in webkit [158511] by
-
- 4 edits in trunk/Source/WebCore
Tighten typing in SVGResources::buildCachedResources().
<https://webkit.org/b/123690>
Make this function take a RenderElement&/SVGRenderStyle& pair instead
of a RenderObject*/SVGRenderStyle* pair. Also tweaked the code a bit,
removing ampersands and asserts as appropriate.
Reviewed by Anders Carlsson.
- 6:47 PM Changeset in webkit [158510] by
-
- 2 edits in trunk/Source/JavaScriptCore
Disable LLVM's pretty stack traces, which involve intercepting fatal signals
https://bugs.webkit.org/show_bug.cgi?id=123681
Reviewed by Geoffrey Garen.
- llvm/library/LLVMExports.cpp:
(initializeAndGetJSCLLVMAPI):
- 6:33 PM Changeset in webkit [158509] by
-
- 10 edits1 add in trunk
LLVM assertion failures should funnel into WTF's crash handling
https://bugs.webkit.org/show_bug.cgi?id=123682
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Inside llvmForJSC, we override assertion-related functions and funnel them
into g_llvmTrapCallback(). We also now register a fatal error handler inside
the library and funnel that into g_llvmTrapCallback, and have
initializeAndGetJSCLLVMAPI() take such a callback as an argument.
Inside JSC, we no longer call LLVMInstallFatalErrorHandler() but instead we
pass WTFLogAlwaysAndCrash() as the trap callback for llvmForJSC.
- llvm/InitializeLLVM.cpp:
(JSC::initializeLLVM):
- llvm/InitializeLLVMPOSIX.cpp:
(JSC::initializeLLVMPOSIX):
- llvm/library/LLVMExports.cpp:
(llvmCrash):
(initializeAndGetJSCLLVMAPI):
- llvm/library/LLVMOverrides.cpp:
(raise):
(assert_rtn):
(abort):
- llvm/library/LLVMTrapCallback.h: Added.
Source/WTF:
Reviewed by Geoffrey Garen.
Give JSC some new toys to play with for crash handling.
- wtf/Assertions.cpp:
- wtf/Assertions.h:
Tools:
Reviewed by Geoffrey Garen.
Need to disable LLVM's crash overrides so that we can do our own crash overrides.
- Scripts/configure-llvm:
- 6:30 PM Changeset in webkit [158508] by
-
- 3 edits in trunk/WebKitLibraries
Unreviewed, update binary drops.
These include my LLVMDisablePrettyStackTrace() fix and are built with --enable-crash-overrides=no
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 5:32 PM Changeset in webkit [158507] by
-
- 4 edits in trunk/Source/JavaScriptCore
CodeBlock::jettison() shouldn't call baselineVersion()
https://bugs.webkit.org/show_bug.cgi?id=123675
Reviewed by Geoffrey Garen.
Fix more uses of baselineVersion().
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):
- 5:29 PM Changeset in webkit [158506] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLVM asserts in internal-js-tests.yaml/Octane/stress-tests/mandreel.js
https://bugs.webkit.org/show_bug.cgi?id=123535
Reviewed by Geoffrey Garen.
Use double comparisons for doubles.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::doubleToInt32):
- 4:56 PM Changeset in webkit [158505] by
-
- 6 edits in trunk/Source/WebCore
CSSImageValue constructors should return PassRef.
<https://webkit.org/b/123688>
Make the CSSImageValue::create() helpers return PassRef.
Tightened call sites to avoid null checks and destructor calls.
Reviewed by Anders Carlsson.
- 3:17 PM Changeset in webkit [158504] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation of SynchronousLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=123676
Reviewed by Darin Adler.
Assign a ResourceRequest varibale an empty ResourceRequest instead of 0.
The current solution only works for ports which can create a
ResourceRequest from a pointer, which might not be true for all ports.
- platform/network/SynchronousLoaderClient.cpp:
(WebCore::SynchronousLoaderClient::willSendRequest):
- 2:59 PM Changeset in webkit [158503] by
-
- 2 edits in trunk
[WINCE] Disable export macros
https://bugs.webkit.org/show_bug.cgi?id=123679
Reviewed by Darin Adler.
Avoid useless exports by turning of the export macros
since the WinCE port works as a static library only.
- Source/cmake/OptionsWinCE.cmake:
- 2:58 PM Changeset in webkit [158502] by
-
- 3 edits in trunk/Source/WebCore
Port LoggingWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=123678
Reviewed by Darin Adler.
This makes it easier to use a common list of files
for the different Windows ports later.
- PlatformWin.cmake:
- platform/win/LoggingWin.cpp:
(WebCore::logLevelString):
- 2:56 PM Changeset in webkit [158501] by
-
- 14 edits in trunk/Source/WebKit/wince
Add OVERRIDE keyword to WebCoreSupport classes
https://bugs.webkit.org/show_bug.cgi?id=123672
Reviewed by Darin Adler.
Also align the function parameters with the base classes
and remove useless functions.
- WebCoreSupport/ChromeClientWinCE.cpp:
- WebCoreSupport/ChromeClientWinCE.h:
- WebCoreSupport/ContextMenuClientWinCE.cpp:
- WebCoreSupport/ContextMenuClientWinCE.h:
- WebCoreSupport/DragClientWinCE.cpp:
(WebKit::DragClientWinCE::willPerformDragDestinationAction):
(WebKit::DragClientWinCE::willPerformDragSourceAction):
(WebKit::DragClientWinCE::actionMaskForDrag):
(WebKit::DragClientWinCE::startDrag):
- WebCoreSupport/DragClientWinCE.h:
- WebCoreSupport/EditorClientWinCE.h:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
- WebCoreSupport/FrameLoaderClientWinCE.h:
- WebCoreSupport/FrameNetworkingContextWinCE.h:
- WebCoreSupport/InspectorClientWinCE.cpp:
- WebCoreSupport/InspectorClientWinCE.h:
- WebCoreSupport/PlatformStrategiesWinCE.h:
- 2:56 PM Changeset in webkit [158500] by
-
- 4 edits in trunk/Source/WebKit2
[Cocoa] Wrappers mishandle NULL values in arrays and dictionaries
https://bugs.webkit.org/show_bug.cgi?id=123671
Reviewed by Darin Adler.
- Shared/Cocoa/WKNSArray.mm:
(-[WKNSArray objectAtIndex:]): Represent a NULL object as NSNull.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary objectForKey:]): Represent a NULL value as NSNull.
- Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::get): Added this overload that returns whether the key exists.
- 2:47 PM Changeset in webkit [158499] by
-
- 8 edits in trunk/Source
Fix UnicodeWchar after r157330.
https://bugs.webkit.org/show_bug.cgi?id=123668
Reviewed by Darin Adler.
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::append):
- platform/graphics/wince/FontWinCE.cpp:
(WebCore::generateComponents):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::drawText):
- platform/text/wchar/TextBreakIteratorWchar.cpp:
(WebCore::isCharStop):
(WebCore::isLineStop):
(WebCore::isSentenceStop):
(WebCore::WordBreakIterator::next):
(WebCore::WordBreakIterator::previous):
Source/WTF:
- wtf/unicode/wchar/UnicodeWchar.cpp:
(unorm_normalize):
(u_strFoldCase):
(u_strToLower):
(u_strToUpper):
- wtf/unicode/wchar/UnicodeWchar.h:
(u_foldCase):
(u_isprint):
(u_isspace):
- 2:18 PM Changeset in webkit [158498] by
-
- 7 edits in trunk/Source
Make remaining StringImpl functions return PassRef.
<https://webkit.org/b/123683>
Okay, this seems to work well! Let's go all in and convert the
remaining StringImpl functions to return PassRef<StringImpl> instead
of PassRefPtr where we know that null is never returned.
Reviewed by Anders Carlsson.
- 2:18 PM Changeset in webkit [158497] by
-
- 8 edits in trunk/Source/WebCore
Use RenderChildIterator in a couple of places.
<https://webkit.org/b/123684>
Added isRendererOfType() for RenderBox and RenderBlock and switch
some loops over to using childrenOfType<>. Also sprinkled const
and references on touched code.
Reviewed by Antti Koivisto.
- 2:03 PM Changeset in webkit [158496] by
-
- 3 edits in trunk/Source/WebCore
Manage FileReaderLoader through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123666
Reviewed by Anders Carlsson.
Construct FileReaderLoader objects through std::make_unique and store them in std::unique_ptr.
- fileapi/FileReader.cpp:
(WebCore::FileReader::readInternal):
- fileapi/FileReader.h:
- 12:51 PM Changeset in webkit [158495] by
-
- 10 edits2 adds in trunk/Source/WebCore
Add a child renderer iterator.
<https://webkit.org/b/123662>
Introduce an ElementIterator-style iterator for renderers and put
it to use in a childrenOfType() implementation.
It's used just like the Element iterators:
auto sections = childrenOfType<RenderTableSection>(*this);
for (auto section = sections.begin(), section = sections.end(); section != sections.end(); ++section)
section->thisOrThat();
Just like the DOM counterpart, it relies on a templatized helper:
bool isRendererOfType<T>(const RenderObject&)
This patch puts the iterator to use in a couple of random places.
Reviewed by Antti Koivisto.
- 11:19 AM Changeset in webkit [158494] by
-
- 4 edits12 copies8 adds in trunk
Implement remaining SHA variations for WebCrypto
https://bugs.webkit.org/show_bug.cgi?id=123659
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/sha-224.html
crypto/subtle/sha-256.html
crypto/subtle/sha-384.html
crypto/subtle/sha-512.html
- WebCore.xcodeproj/project.pbxproj:
- crypto/algorithms/CryptoAlgorithmSHA224.cpp: Added.
(WebCore::CryptoAlgorithmSHA224::CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::~CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::create):
(WebCore::CryptoAlgorithmSHA224::identifier):
- crypto/algorithms/CryptoAlgorithmSHA224.h: Added.
- crypto/algorithms/CryptoAlgorithmSHA256.cpp: Added.
(WebCore::CryptoAlgorithmSHA256::CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::~CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::create):
(WebCore::CryptoAlgorithmSHA256::identifier):
- crypto/algorithms/CryptoAlgorithmSHA256.h: Added.
- crypto/algorithms/CryptoAlgorithmSHA384.cpp: Added.
(WebCore::CryptoAlgorithmSHA384::CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::~CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::create):
(WebCore::CryptoAlgorithmSHA384::identifier):
- crypto/algorithms/CryptoAlgorithmSHA384.h: Added.
- crypto/algorithms/CryptoAlgorithmSHA512.cpp: Added.
(WebCore::CryptoAlgorithmSHA512::CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::~CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::create):
(WebCore::CryptoAlgorithmSHA512::identifier):
- crypto/algorithms/CryptoAlgorithmSHA512.h: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
- crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA224::digest):
- crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA256::digest):
- crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA384::digest):
- crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA512::digest):
LayoutTests:
- crypto/subtle/sha-224-expected.txt: Added.
- crypto/subtle/sha-224.html: Added.
- crypto/subtle/sha-256-expected.txt: Added.
- crypto/subtle/sha-256.html: Added.
- crypto/subtle/sha-384-expected.txt: Added.
- crypto/subtle/sha-384.html: Added.
- crypto/subtle/sha-512-expected.txt: Added.
- crypto/subtle/sha-512.html: Added.
- 10:54 AM Changeset in webkit [158493] by
-
- 2 edits in trunk/Source/WebKit2
Fixed release builds.
- Shared/Cocoa/WKNSDictionary.mm:
(-[WKNSDictionary initWithObjects:forKeys:count:]):
- 10:33 AM Changeset in webkit [158492] by
-
- 12 edits in trunk/Source
Various small WinCE build fixes
Source/JavaScriptCore:
- jsc.cpp:
(main):
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::SearchBuffer::append):
- platform/graphics/BitmapImage.h:
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
- platform/graphics/wince/PlatformPathWinCE.h:
- platform/win/PopupMenuWin.h:
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
Source/WebKit/wince:
- WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::transitionToCommittedForNewPage):
- WebView.cpp:
- 10:26 AM Changeset in webkit [158491] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MSVC ARM build after r157581.
- jit/JITStubsARM.h:
- 9:59 AM Changeset in webkit [158490] by
-
- 3 edits in trunk/Source/WTF
StringImpl::upper() should return PassRef.
<https://webkit.org/b/123655>
Make upper() return PassRef<StringImpl>. Spotted and removed some
ref churning in implementations.
Reviewed by Darin Adler.
- 9:42 AM Changeset in webkit [158489] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[Cocoa] Add WKNSDictionary
https://bugs.webkit.org/show_bug.cgi?id=123660
Reviewed by Anders Carlsson.
- Shared/Cocoa/APIObject.mm:
(WebKit::APIObject::newObject): Allocate a WKNSDictionary if the APIObject is a dictionary.
- Shared/Cocoa/WKNSDictionary.h: Added.
(WebKit::wrapper): Added. Returns an ImmutableDictionary’s wrapper as an NSDictionary.
- Shared/Cocoa/WKNSDictionary.mm: Added.
(-[WKNSDictionary dealloc]): Calls the ImmutableDictionary destructor.
(-[WKNSDictionary count]): Added.
(-[WKNSDictionary objectForKey:]): Added.
(-[WKNSDictionary keyEnumerator]): Added.
(-[WKNSDictionary copyWithZone:]): Retains self.
(-[WKNSDictionary _apiObject]): Returns the wrapped ImmutableDictionary.
- WebKit2.xcodeproj/project.pbxproj: Added references to new files.
- 9:04 AM Changeset in webkit [158488] by
-
- 3 edits in trunk/Source/WebKit2
Address some review comments noted in r158463
https://bugs.webkit.org/show_bug.cgi?id=123646
Reviewed by Darin Adler.
- Shared/mac/RemoteLayerBackingStore.mm:
Put our has_include ifs all on one line.
(createIOSurface):
IOSurfaceAlignProperty returns size_t, not unsigned long.
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
Create the frontImage in display() and hand it to drawInContext().
Use the GraphicsContext API instead of CG itself for clearRect().
When using ShareableBitmap, replace m_frontBuffer instead of
having a backBuffer local; the CGImageRef will retain the
ShareableBitmap it references.
Duplicate our drawInContext() calls so we don't have to allocate
a GraphicsContext on the heap in the IOSurface case.
Don't bother clearing frontContext; it'll happen for us at
the appropriate time. Instead, assert that it's still alive after
we drop our reference to the frontImage created from it.
- 7:34 AM Changeset in webkit [158487] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] invalid use of incomplete type 'class WTF::PassOwnPtr<WTF::Vector<unsigned char> >'
https://bugs.webkit.org/show_bug.cgi?id=123601
Reviewed by Carlos Garcia Campos.
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: Explicitly include the PassOwnPtr.h header
as certain configurations on the GTK port don't ensure that the header is included indirectly.
- 3:10 AM Changeset in webkit [158486] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] invalid application of 'sizeof' to incomplete type
https://bugs.webkit.org/show_bug.cgi?id=123502
Patch by Vitaly Katunin <vkatunin@luxoft.com> on 2013-11-02
Reviewed by Carlos Garcia Campos.
- Shared/WebCoreArgumentCoders.cpp:
Nov 1, 2013:
- 11:59 PM Changeset in webkit [158485] by
-
- 17 edits6 copies14 adds in trunk
Add WebCrypto AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123647
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-192-encrypt-decrypt.html
crypto/subtle/aes-cbc-256-encrypt-decrypt.html
crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html
crypto/subtle/aes-cbc-encrypt-decrypt.html
crypto/subtle/aes-cbc-invalid-length.html
crypto/subtle/aes-cbc-wrong-key-class.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::getProperty): Factored out a function to get a property as JSValue.
(WebCore::getHashAlgorithm): Use it.
(WebCore::createAesCbcParams): Added converter for AesCbcParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt): Support AES_CBC.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey): Support all
algorithms, all the new ones just have trivial dictionaries.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey): Ditto.
- bindings/js/JSCryptoOperationData.cpp: Added.
(WebCore::sequenceOfCryptoOperationDataFromJSValue):
(WebCore::cryptoOperationDataFromJSValue):
- bindings/js/JSCryptoOperationData.h: Added.
Moved CryptoOperationData bindings out of JSSubtleCryptoCustom.cpp, so that we
could use them in JSCryptoAlgorithmDictionary.cpp.
- bindings/js/JSDOMPromise.h: (WebCore::PromiseWrapper::reject): Added a specialization
to reject with null result. The spec doesn't actually say how algorithms fail.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt): Added.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Style fix.
- crypto/CryptoAlgorithmAesCbcParams.h: Added.
- crypto/CryptoKey.h:
(WebCore::CryptoKeyClass):
- crypto/keys/CryptoKeyHMAC.h:
(WebCore::asCryptoKeyHMAC):
Added poor man's RTTI, so that we can safely upcast Keys passed fro JavaScript code.
- crypto/CryptoKeyAES.cpp: Added.
(WebCore::CryptoKeyAES::CryptoKeyAES):
(WebCore::CryptoKeyAES::~CryptoKeyAES):
(WebCore::CryptoKeyAES::buildAlgorithmDescription):
- crypto/CryptoKeyAES.h: Added.
(WebCore::asCryptoKeyAES):
AES keys are the same for all algorithms, but they still need to remember the algorithm.
- crypto/SubtleCrypto.idl: Added encrypt/decrypt.
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: Added.
(WebCore::CryptoAlgorithmAES_CBC::CryptoAlgorithmAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::~CryptoAlgorithmAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::create):
(WebCore::CryptoAlgorithmAES_CBC::identifier):
(WebCore::CryptoAlgorithmAES_CBC::importKey):
(WebCore::CryptoAlgorithmAES_CBC::exportKey):
- crypto/algorithms/CryptoAlgorithmAES_CBC.h: Added.
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Added.
(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
Added.
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
Check key class before casting it to CryptoKeyHMAC.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register AES-CBC
on Mac, so that it can be used.
Source/WTF:
- wtf/FixedArray.h: (WTF::FixedArray::data): Added a const version of the function.
- wtf/Vector.h: Added a comment to Vector constructor about how it is different
from std::vector.
LayoutTests:
Part of aes-cbc-encrypt-decrypt.html test was taken from Blink.
- crypto/subtle/aes-cbc-192-encrypt-decrypt-expected.txt: Added.
- crypto/subtle/aes-cbc-192-encrypt-decrypt.html: Added.
- crypto/subtle/aes-cbc-256-encrypt-decrypt-expected.txt: Added.
- crypto/subtle/aes-cbc-256-encrypt-decrypt.html: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt-expected.txt: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt-with-padding.html: Added.
- crypto/subtle/aes-cbc-encrypt-decrypt.html: Added.
- crypto/subtle/aes-cbc-invalid-length-expected.txt: Added.
- crypto/subtle/aes-cbc-invalid-length.html: Added.
- crypto/subtle/aes-cbc-wrong-key-class-expected.txt: Added.
- crypto/subtle/aes-cbc-wrong-key-class.html: Added.
- crypto/subtle/hmac-sign-verify-expected.txt:
- crypto/subtle/hmac-sign-verify.html:
Corrected a description.
- crypto/subtle/resources/common.js: (hexToArrayBuffer): Added a helper.
- 10:01 PM Changeset in webkit [158484] by
-
- 36 edits in trunk/Source/WebCore
SVGRenderStyle accessors should return references.
<https://webkit.org/b/123656>
RenderStyle::svgStyle() and accessSVGStyle() never return null,
so make them return references instead.
This flushed out a myriad of pointless null checks and assertions.
Reviewed by Anders Carlsson.
- 7:28 PM Changeset in webkit [158483] by
-
- 4 edits in trunk/LayoutTests
Update layout test results after CSS calc() simplification
https://bugs.webkit.org/show_bug.cgi?id=123654
Reviewed by Andreas Kling.
r156586 simplified CSS calc expressions.
Update layout test results for calc().
- fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
- fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:
(valueSettingTest):
- platform/efl/TestExpectations: gardening
- 7:24 PM Changeset in webkit [158482] by
-
- 3 edits in trunk/Source/JavaScriptCore
FTL should use a simple optimization pipeline by default
https://bugs.webkit.org/show_bug.cgi?id=123638
Reviewed by Geoffrey Garen.
20% speed-up on imagine-gaussian-blur, when combined with --ftlUsesStackmaps=true.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/Options.h:
- 7:23 PM Changeset in webkit [158481] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: Crashes allocating incredibly large backing store for tiled backing layers
https://bugs.webkit.org/show_bug.cgi?id=123651
Reviewed by Simon Fraser.
- Shared/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
We can't dirty the whole layer if we have no existing front buffer if
we have no paints, because that will lead to layers which were never
setNeedsDisplay()'d getting backing store. Added back an assertion
that will catch this, too.
- 7:13 PM Changeset in webkit [158480] by
-
- 13 edits in trunk/Source
Removing MediaStreamTrackVector and MediaStreamSourceVector typedefs
https://bugs.webkit.org/show_bug.cgi?id=123648
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
Source/WebCore:
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::cloneMediaStreamTrackVector):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::haveTrackWithSource):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::trackVectorForType):
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createMediaStreamSource):
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::create):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):
- platform/mediastream/MediaStreamDescriptor.h:
- platform/mediastream/MediaStreamSource.h:
Source/WebKit/blackberry:
- WebCoreSupport/UserMediaClientImpl.cpp:
(WebCore::toMediaStreamDescriptor):
(WebCore::UserMediaClientImpl::requestUserMedia):
- WebCoreSupport/UserMediaClientImpl.h:
- 7:09 PM Changeset in webkit [158479] by
-
- 4 edits in trunk/Source/WTF
Unreviewed extended attempt at Windows build fix after r158471.
- wtf/text/cf/AtomicStringCF.cpp:
- wtf/text/cf/StringCF.cpp:
- wtf/text/cf/StringImplCF.cpp:
- 6:53 PM Changeset in webkit [158478] by
-
- 2 edits in trunk/Source/WebCore
createFontFaceValue() should be smarter about overgrown cache.
<https://webkit.org/b/123643>
Instead of clearing the whole font-face value cache when it passes
128 entries, just delete one entry at random.
Reviewed by Geoffrey Garen.
- 6:51 PM Changeset in webkit [158477] by
-
- 2 edits in trunk/Source/WebCore
Fixing mac code to use new MediaStreamDescriptor create method
https://bugs.webkit.org/show_bug.cgi?id=123653
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
No new tests needed.
- platform/mediastream/mac/MediaStreamCenterMac.cpp:
(WebCore::MediaStreamCenterMac::createMediaStream):
- 6:50 PM Changeset in webkit [158476] by
-
- 2 edits in trunk/Source/WebCore
Re-use existing RenderStyle local in textWidth().
<https://webkit.org/b/123392>
We already have the RenderStyle cached in a local here, so avoid
getting it from RenderText since that has to go via the parent.
Reviewed by Antti Koivisto.
- 6:49 PM Changeset in webkit [158475] by
-
- 4 edits in trunk/Source/WTF
Unreviewed attempt at Windows build fix after r158471.
- wtf/text/cf/AtomicStringCF.cpp:
- wtf/text/cf/StringCF.cpp:
- wtf/text/cf/StringImplCF.cpp:
- 6:45 PM Changeset in webkit [158474] by
-
- 6 edits in trunk/Source
Make more StringImpl construction helpers return PassRef.
<https://webkit.org/b/123652>
Tweak another handful of StringImpl constructor functions to return
PassRef<StringImpl> instead of PassRefPtr.
Reviewed by Anders Carlsson.
- 6:38 PM Changeset in webkit [158473] by
-
- 6 edits in trunk/Source
Neuter WTF_MAKE_FAST_ALLOCATED in GLOBAL_FASTMALLOC_NEW builds.
<https://webkit.org/b/123639>
Source/JavaScriptCore:
JSC::ParserArenaRefCounted really needed to have the new/delete
operators overridden, in order for JSC::ScopeNode to be able to
choose that "operator new" out of the two it inherits.
Reviewed by Anders Carlsson.
Source/WebCore:
WebCore::TimerBase really needed to have the new/delete operators
overridden, in order for WebCore::SuspendableTimer to be able to
choose that "operator new" out of the two it inherits.
Reviewed by Anders Carlsson.
Source/WTF:
When building with GLOBAL_FASTMALLOC_NEW, we don't need to expand
operator new/delete overrides in every class.
This change makes allocations group up nicely in Instruments,
instead of being split between "WTF::fastMalloc" and "operator new"
depending on whether the class had WTF_MAKE_FAST_ALLOCATED.
Reviewed by Anders Carlsson.
- 6:23 PM Changeset in webkit [158472] by
-
- 2 edits in trunk/Source/WebCore
CSSCanvasValue construction helper should return PassRef.
<https://webkit.org/b/123650>
Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.
Reviewed by Anders Carlsson.
- 6:22 PM Changeset in webkit [158471] by
-
- 11 edits5 moves2 adds in trunk/Source
Move CF/Mac WTF String implementations down into WTF
https://bugs.webkit.org/show_bug.cgi?id=123635
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-01
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/text/AtomicString.h:
- wtf/text/StringImpl.h:
- wtf/text/WTFString.h:
- wtf/text/cf/AtomicStringCF.cpp: Renamed from Source/WebCore/platform/text/cf/AtomicStringCF.cpp.
(WTF::AtomicString::add):
- wtf/text/cf/StringCF.cpp: Renamed from Source/WebCore/platform/text/cf/StringCF.cpp.
(WTF::String::String):
(WTF::String::createCFString):
- wtf/text/cf/StringImplCF.cpp: Renamed from Source/WebCore/platform/text/cf/StringImplCF.cpp.
(garbageCollectionEnabled):
(WTF::StringWrapperCFAllocator::retain):
(WTF::StringWrapperCFAllocator::release):
(WTF::StringWrapperCFAllocator::copyDescription):
(WTF::StringWrapperCFAllocator::allocate):
(WTF::StringWrapperCFAllocator::reallocate):
(WTF::StringWrapperCFAllocator::deallocateOnMainThread):
(WTF::StringWrapperCFAllocator::deallocate):
(WTF::StringWrapperCFAllocator::preferredSize):
(WTF::StringWrapperCFAllocator::create):
(WTF::StringWrapperCFAllocator::allocator):
(WTF::StringImpl::createCFString):
- wtf/text/mac/StringImplMac.mm: Renamed from Source/WebCore/platform/text/mac/StringImplMac.mm.
(WTF::StringImpl::operator NSString *):
- wtf/text/mac/StringMac.mm: Renamed from Source/WebCore/platform/text/mac/StringMac.mm.
(WTF::String::String):
- 6:20 PM Changeset in webkit [158470] by
-
- 3 edits in trunk/Source/WebCore
Removing unnecessary early returns in addTrack, removeTrack and removeRemoteSource methods
https://bugs.webkit.org/show_bug.cgi?id=123644
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::removeRemoteSource):
(WebCore::MediaStream::trackVectorForType):
- Modules/mediastream/MediaStream.h:
- 6:03 PM Changeset in webkit [158469] by
-
- 2 edits in trunk/Source/WebCore
CSSAspectRatioValue construction helper should return PassRef.
<https://webkit.org/b/123645>
Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.
Reviewed by Darin Adler.
- 5:55 PM Changeset in webkit [158468] by
-
- 16 edits8 adds in branches/safari-537.73-branch
Merge r157070
Source/WebCore:
2013-10-04 Ojan Vafai <ojan@chromium.org> and Martin Robinson <mrobinson@igalia.com>
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Reviewed by David Hyatt.
Tests: mathml/presentation/mo-minus.html
mathml/presentation/mo-stacked-glyphs.html
mathml/presentation/mo-stretchy-vertical-bar.html
mathml/very-large-stretchy-operators.html
MathML stretched operators by both modifying the width of the operator
and adding children to the operator node in the render tree.
Instead we make the operator width equal to the widest glyph possible that we use
to represent the operator. Additionally instead of rendering stretchy glyphs via
stacked operator pieces in separate render tree nodes, keep only one node for the
glyph, and use a custom paint method to paint the stacked representation.
With this patch, rendering seems roughly equivalent on Mac and markedly better
on Linux.
- css/mathml.css: Not sure what this line-height:0 was here for, but it caused bugs with the new code
- mathml/MathMLTextElement.cpp: (WebCore::MathMLTextElement::attach): (WebCore): (WebCore::MathMLTextElement::childrenChanged): Need to update the anonymous render tree below <mo> elements when their children change or when the renderer is first attached.
- mathml/MathMLTextElement.h: (MathMLTextElement):
- rendering/mathml/RenderMathMLBlock.cpp: (WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h: Now that the preferred width doesn't depend on the height, we don't need to override computePreferredLogicalWidths at all.
- rendering/mathml/RenderMathMLFenced.cpp: (WebCore::RenderMathMLFenced::makeFences): (WebCore::RenderMathMLFenced::styleDidChange): Need to update the anonymous renderers for the anonymous RenderMathMLOperators.
- rendering/mathml/RenderMathMLOperator.cpp: (WebCore::RenderMathMLOperator::expandedStretchHeight): Store the non-expanded stretch height so that we can detect when the height actually changed.
(WebCore::RenderMathMLOperator::stretchToHeight):
Only update the style on the anonymous render tree since this is called
from RenderMathMLRow::layout
(WebCore::RenderMathMLOperator::styleDidChange):
(WebCore::RenderMathMLOperator::glyphBoundsForCharacter): A helper to get glyph boundaries.
(WebCore::RenderMathMLOperator::glyphHeightForCharacter): Ditto for glyph width.
(WebCore::RenderMathMLOperator::advanceForCharacter): The advance is different from the width,
and we want the width of the operator to be the advance instead of the tight bounding width.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use the max of all possible glyphs
we can use to render this operator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Return the stretched operator height, if appropriate.
(WebCore::RenderMathMLOperator::updateFromElement): We add a child for rendering the non-scaled
version of the glyph.
(WebCore::RenderMathMLOperator::firstCharacterForStretching): Helper to figure out what character
is the character used for stretching operations.
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter): Helper to find an acceptable set
of glyph pieces for stretching characters.
(WebCore::RenderMathMLOperator::updateStyle): Resize the operator to the appropriate height and hide
the child if we are using the stretchy style.
(WebCore::RenderMathMLOperator::firstLineBoxBaseline):
(WebCore::RenderMathMLOperator::paintCharacter): Helper to paint a single character component of the
stretchy glyph.
(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Helper to paint the extender glue between
features of the stretchy glyph.
(WebCore::RenderMathMLOperator::paint): Properly paint stretchy glyphs.
- rendering/mathml/RenderMathMLOperator.h: Update method declarations.
LayoutTests:
2013-10-04 Frédéric Wang <fred.wang@free.fr>
[MathML] Remove RenderTree modification during layout and refactor the StretchyOp code
https://bugs.webkit.org/show_bug.cgi?id=121416
Reviewed by David Hyatt.
Add some reftests for stretchy operators.
- TestExpectations: The remaining MathML pixel tests are broken by this patch.
- LayoutTests/platform/gtk/TestExpectations:
- LayoutTests/platform/mac/TestExpectations:
- LayoutTests/platform/win/TestExpectations:
- mathml/presentation/mo-minus.html: Added.
- mathml/presentation/mo-minus-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs-expected.html: Added.
- mathml/presentation/mo-stacked-glyphs.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar-expected-mismatch.html: Added.
- mathml/presentation/mo-stretchy-vertical-bar.html: Added.
- mathml/very-large-stretchy-operators-expected.txt: Added.
- mathml/very-large-stretchy-operators.html: Added.
- 4:46 PM Changeset in webkit [158467] by
-
- 6 edits2 adds in trunk
Initial implementation of text-decoration-skip ink
https://bugs.webkit.org/show_bug.cgi?id=121806
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-01
Reviewed by Darin Adler.
Source/WebCore:
text-decoration-skip: ink is implemented by the following steps:
- Before drawing any decorations, figure out the bounding box for the decorations that will be drawn
- Create an ImageBuffer with these dimensions
- Draw text into this ImageBuffer with a thicker stroke
- Apply the ImageBuffer as a mask to the context
- Draw decorations like normal
- Clean up
Test: fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::computeLineBoundsAndAntialiasingModeForText): Don't call GraphicsContext::roundToDevicePixels
when painting is disabled
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Pass the TextPainter to paintDecoration
(WebCore::computeUnderlineOffset): Small cleanup
(WebCore::getWavyStrokeControlPointDistance): Pulling out of strokeWavyTextDecoration()
(WebCore::getWavyStrokeStep): Ditto
(WebCore::strokeWavyTextDecoration): Use the previous 2 functions
(WebCore::getSingleDecorationBoundingBox): Pulling out repeated code into a function
(WebCore::getDecorationBoundingBox): Compute the bounding box for an underline which
hasn't been drawn yet
(WebCore::InlineTextBox::paintDecoration): Construct a mask and apply it to the GraphicsContext
- rendering/InlineTextBox.h: paintDecoration needs the TextPainter
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline): Redraw the underline when
text-decoration-skip changes
LayoutTests:
Adding a test which draws a very large "p" with text-decoration-skip:ink. The
viewport is restricted to be just hugging the place where an underline would
intersect the descender of the "p". This should look the same as if there was
no underline at all (because of the skipping underline).
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html: Added.
- 4:38 PM Changeset in webkit [158466] by
-
- 2 edits in trunk/LayoutTests
[CSS Shapes] Fix typo in simple-polygon.js LayoutTest helper
https://bugs.webkit.org/show_bug.cgi?id=123595
Reviewed by Darin Adler.
- fast/shapes/resources/simple-polygon.js:
(generatePolygonContentString): Fixed a typo: the lineHeight parameter generatePolygonContentString() is now lineHeight.
- 4:34 PM Changeset in webkit [158465] by
-
- 4 edits in trunk/Source/WebCore
CSS 'initial' and 'inherit' value constructors should return PassRef.
<https://webkit.org/b/123641>
Make the helpers involved in constructing CSS{Initial,Inherited}Value
all return PassRef instead of PassRefPtr. This avoids generating
pointless null checks at the call sites.
Reviewed by Darin Adler.
- 4:29 PM Changeset in webkit [158464] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebCore
Merged r158334. <rdar://problem/15359442>
- 4:24 PM Changeset in webkit [158463] by
-
- 2 edits2 moves in trunk/Source/WebKit2
Remote Layer Tree: Move RemoteLayerBackingStore to Shared/
https://bugs.webkit.org/show_bug.cgi?id=123646
Reviewed by Darin Adler.
Move RemoteLayerBackingStore to Shared/, since it is
used on both the UI and Web process side of things.
- Shared/mac/RemoteLayerBackingStore.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.h.
- Shared/mac/RemoteLayerBackingStore.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerBackingStore.mm.
- WebKit2.xcodeproj/project.pbxproj:
- 4:24 PM Changeset in webkit [158462] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r158334. <rdar://problem/15359450>
- 3:22 PM Changeset in webkit [158461] by
-
- 25 edits4 deletes in trunk/Source/WebCore
Kill RenderArena.
<https://webkit.org/b/123634>
There are no remaining users of the RenderArena allocator.
Reviewed by Geoffrey Garen.
- 3:14 PM Changeset in webkit [158460] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] WKObject seems to be initializing its target in a thread-safe manner, but really is not
https://bugs.webkit.org/show_bug.cgi?id=123640
Reviewed by Darin Adler.
- Shared/Cocoa/WKObject.mm:
(initializeTargetIfNeeded): Removed misleading incorrect code.
- 3:10 PM Changeset in webkit [158459] by
-
- 8 edits in trunk/Source/JavaScriptCore
OSR exit profiling should be robust against all code being cleared
https://bugs.webkit.org/show_bug.cgi?id=123629
<rdar://problem/15365476>
Reviewed by Michael Saboff.
The problem here is two-fold:
1) A watchpoint (i.e. ProfiledCodeBlockJettisoningWatchpoint) may be fired after we
have cleared the CodeBlock for all or some Executables. This means that doing
codeBlock->baselineVersion() would either crash or return a bogus CodeBlock, since
there wasn't a baseline code block reachable from the Executable anymore. The
solution is that we shouldn't be asking for the baseline code block reachable from
the owning executable (what baselineVersion did), but instead we should be asking
for the baseline version reachable from the code block being watchpointed (basically
what CodeBlock::alternative() did).
2) If dealing with inlined code, baselienCodeBlockForOriginAndBaselineCodeBlock()
may return null, for the same reason as above - we might have cleared the baseline
codeblock for the executable that was inlined. The solution is to just not do
profiling if there isn't a baseline code block anymore.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::baselineAlternative):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
- bytecode/CodeBlockJettisoningWatchpoint.cpp:
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):
- dfg/DFGOSRExitBase.cpp:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::AssemblyHelpers):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::baselineCodeBlockFor):
- 2:29 PM Changeset in webkit [158458] by
-
- 2 edits in trunk/Tools
Teach check-for-webkit-framework-include-consistency to ignore stale iOS Private headers that might exist in build directories due to r158443
https://bugs.webkit.org/show_bug.cgi?id=123636
Reviewed by Andreas Kling.
- Scripts/check-for-webkit-framework-include-consistency:
- 2:28 PM Changeset in webkit [158457] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Create a unique identifier for WebPageGroup if the input name is empty
https://bugs.webkit.org/show_bug.cgi?id=123606
Reviewed by Andreas Kling.
Strengthen the "public" API of page group.
If someone uses WKBrowsingContextGroup with a nil or empty string, the related WKString
would be empty, and all the WKBrowsingContextGroup end up with the same identifier.
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::WebPageGroup):
- 2:26 PM Changeset in webkit [158456] by
-
- 2 edits2 moves in trunk/Source/WebKit2
[Cocoa] Avoid some double-wrapping of strings and URLs
https://bugs.webkit.org/show_bug.cgi?id=123632
Reviewed by Anders Carlsson.
- Shared/API/c/cf/WKStringCF.cpp: Removed.
- Shared/API/c/cf/WKStringCF.mm: Copied from Source/WebKit2/Shared/API/c/cf/WKStringCF.cpp.
(wkNSStringClass): Added this helper.
(WKStringCreateWithCFString): If the passed-in CFString is already wrapping a WebString,
then retain it and return it.
- Shared/API/c/cf/WKURLCF.cpp: Removed.
- Shared/API/c/cf/WKURLCF.mm: Copied from Source/WebKit2/Shared/API/c/cf/WKURLCF.cpp.
(wkNSURLClass): Added this helper.
(WKURLCreateWithCFURL): If the passed-in CFURL is already wrapping a WebURL, then retain it
and return it.
- WebKit2.xcodeproj/project.pbxproj: Updated for renames.
- 2:23 PM Changeset in webkit [158455] by
-
- 5 edits in trunk
AX: Regression: media controls are no longer accessible
https://bugs.webkit.org/show_bug.cgi?id=121990
Patch by James Craig <jcraig@apple.com> on 2013-11-01
Reviewed by Jer Noble.
Source/WebCore:
Updated existing test coverage.
Added ARIA roles, attrs, and labels to the new media controls shadow DOM.
Localization will be handled in http://webkit.org/b/120956
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.UIString):
(Controller.prototype.createControls):
(Controller.prototype.handleLoadStart):
(Controller.prototype.handleError):
(Controller.prototype.handleAbort):
(Controller.prototype.handleSuspend):
(Controller.prototype.handleStalled):
(Controller.prototype.handleWaiting):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.updatePlaying):
LayoutTests:
Removed failure expectation and updated expected render dump output.
- platform/mac/TestExpectations:
- platform/mac/accessibility/media-element-expected.txt:
- 2:06 PM Changeset in webkit [158454] by
-
- 4 edits in trunk/Source/WebKit
[iOS] Make some headers Private
https://bugs.webkit.org/show_bug.cgi?id=123626
Reviewed by Andreas Kling.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig: Exclude iOS Private headers from the Mac build.
- 2:04 PM Changeset in webkit [158453] by
-
- 7 edits in trunk/Source/WebCore
Take BidiRuns out of the arena.
<https://webkit.org/b/123630>
Stop arena-allocating BidiRun objects and use regular new/delete.
With this, there are no remaining clients of RenderArena.
It will be removed in a subsequent patch.
Reviewed by Anders Carlsson.
- 2:00 PM Changeset in webkit [158452] by
-
- 7 edits in trunk
Begin work on encoding argument types
https://bugs.webkit.org/show_bug.cgi?id=123631
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder _encodeInvocation:forKey:]):
Encode argument types in an array.
(-[WKRemoteObjectEncoder _encodedObjectUsingBlock:]):
Add new helper method that encodes an object and returns the dictionary.
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
Implement this in terms of _encodedObjectUsingBlock:.
- Shared/MutableArray.cpp:
(WebKit::MutableArray::append):
- Shared/MutableArray.h:
Change append to take a PassRefPtr.
Tools:
Add another test method.
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
- 1:42 PM Changeset in webkit [158451] by
-
- 9 edits in trunk/Source/WebKit2
Rename InWindowState -> ViewState
https://bugs.webkit.org/show_bug.cgi?id=123584
Rubber stamped by Sam Weinig.
WebPageProxy::setViewState offers the option to wait for a reply. Previously this option
was only available via setIsInWindow, hence the mechanism to wait to the update has
'InWindowState' in method and variable names (i.e.
'WebPageProxy::waitForDidUpdateInWindowState'). Since the mechanism is now applicable to
all ViewState changes, rename to reflect this.
- UIProcess/API/mac/WKView.mm:
(-[WKView endDeferringViewInWindowChangesSync]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::waitForDidUpdateViewState):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::didUpdateViewState):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::didUpdateViewStateTimerFired):
(WebKit::WebPage::setViewState):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::didUpdateViewStateTimerFired):
- 1:15 PM Changeset in webkit [158450] by
-
- 21 edits in trunk
Expose setApplicationCacheOriginQuota via window.internals
https://bugs.webkit.org/show_bug.cgi?id=87838
Patch by Afonso R. Costa Jr. <afonso.costa@samsung.com> on 2013-11-01
Reviewed by Joseph Pecoraro.
Source/WebCore:
Also reset the default origin quota in resetToConsistentState().
- testing/Internals.cpp: Add setApplicationCacheOriginQuota.
(WebCore::Internals::resetToConsistentState): Reset the default origin
quota.
(WebCore::Internals::setApplicationCacheOriginQuota): Added.
- testing/Internals.h: Add setApplicationCacheOriginQuota.
- testing/Internals.idl: Ditto.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add
symbols for setApplicationCacheOriginQuota from Internals.
Tools:
- DumpRenderTree/TestRunner.cpp: Move setApplicationCacheOriginQuota
to window.internals
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h: Ditto.
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setApplicationCacheOriginQuota.
- DumpRenderTree/efl/TestRunnerEfl.cpp: Ditto.
- DumpRenderTree/gtk/TestRunnerGtk.cpp: Ditto.
- DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
- DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Ditto.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
- WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
LayoutTests:
- http/tests/appcache/origin-quota-continued-download-multiple-manifests.html: Updated
to use setApplicationCacheOriginQuota from window.internals
- http/tests/appcache/origin-quota-continued-download.html: Ditto.
- http/tests/appcache/origin-quota.html: Ditto.
- 12:46 PM Changeset in webkit [158449] by
-
- 3 edits in trunk/Source/WebKit2
Remote Layer Tree: Vend layer contents via IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=123600
Reviewed by Anders Carlsson.
Address some review comments from Darin (and subsequently Anders).
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::surface):
No need for .get() here.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
(RemoteLayerBackingStore::ensureBackingStore):
All on one line for readability.
(createIOSurfaceContext):
This 'if' is meaningless.
(createIOSurface):
No need for a RetainPtr here, the dictionary is autoreleased.
(RemoteLayerBackingStore::display):
Snuggle 'context' up next to the other declarations.
- 12:35 PM Changeset in webkit [158448] by
-
- 5 edits in trunk/Source/WebKit2
Don't use the C API in WKRemoteObjectCoder
https://bugs.webkit.org/show_bug.cgi?id=123627
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder init]):
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
- Shared/ImmutableDictionary.h:
- Shared/MutableDictionary.cpp:
(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):
- Shared/MutableDictionary.h:
- 12:18 PM Changeset in webkit [158447] by
-
- 16 edits in trunk
REGRESSION: Crashes in -[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:].
https://bugs.webkit.org/show_bug.cgi?id=123383.
Reviewed by Geoffrey Garen.
Tools:
Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
tests to set appropriate quota settings to exercise quota expansion tests
when needed.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::TestRunner):
(getDatabaseDefaultQuotaCallback):
(getDatabaseMaxQuotaCallback):
(setDatabaseDefaultQuotaCallback):
(setDatabaseMaxQuotaCallback):
(TestRunner::staticValues):
- DumpRenderTree/TestRunner.h:
(TestRunner::databaseDefaultQuota):
(TestRunner::setDatabaseDefaultQuota):
(TestRunner::databaseMaxQuota):
(TestRunner::setDatabaseMaxQuota):
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededDatabaseQuota):
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
- DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::exceededDatabaseQuota):
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didExceedDatabaseQuota):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::TestRunner):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::databaseDefaultQuota):
(WTR::TestRunner::setDatabaseDefaultQuota):
(WTR::TestRunner::databaseMaxQuota):
(WTR::TestRunner::setDatabaseMaxQuota):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
LayoutTests:
Removed an inappropriate assertion in DumpRenderTree/mac/UIDelegate.mm and
added 2 attributes (databaseDefaultQuota and databaseMaxQuota) to allow
tests to set appropriate quota settings to exercise quota expansion tests
when needed.
- storage/websql/open-database-expand-quota.html:
- Set databaseDefaultQuota and databaseMaxQuota as needed for this test.
- storage/websql/open-database-over-quota-expected.txt:
- storage/websql/open-database-over-quota.html:
- Revert the change from r157874 which is no longer needed for this test.
- 12:10 PM Changeset in webkit [158446] by
-
- 2 edits in trunk/Source/WebKit
Reverted r158443. It broke the build.
- WebKit.xcodeproj/project.pbxproj:
- 11:59 AM Changeset in webkit [158445] by
-
- 3 edits in trunk/Source/WTF
HPPA build fixes
https://bugs.webkit.org/show_bug.cgi?id=123625
Original patch from John David Anglin <dave.anglin@bell.net>
Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.
- wtf/Platform.h:
- wtf/dtoa/utils.h:
- 11:48 AM Changeset in webkit [158444] by
-
- 2 edits in trunk/Source/WebKit2
Fix build on non-linux platforms
https://bugs.webkit.org/show_bug.cgi?id=123622
Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- 11:37 AM Changeset in webkit [158443] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Make some headers Private
https://bugs.webkit.org/show_bug.cgi?id=123626
Reviewed by Sam Weinig.
- WebKit.xcodeproj/project.pbxproj:
- 11:30 AM Changeset in webkit [158442] by
-
- 2 edits in trunk/Source/WebCore
Explicitly initialize RefCounted base class in MediaStreamTrack's constructors
https://bugs.webkit.org/show_bug.cgi?id=123620
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-01
Reviewed by Andreas Kling.
No new tests needed.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
- 11:17 AM Changeset in webkit [158441] by
-
- 54 edits in trunk/LayoutTests
[css shapes] Pull in upstream fixes to shape-outside margin and clipping tests
https://bugs.webkit.org/show_bug.cgi?id=123588
Reviewed by Alexandru Chiculita.
Fix some typos in the tests, add better explanation, and generally
make the tests clearer.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-005.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-clipped-006.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-005.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-006.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-007.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-008.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-009.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-013.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-019.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-020.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021-expected.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html:
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 11:13 AM Changeset in webkit [158440] by
-
- 2 edits in trunk/Source/WebInspectorUI
Remove custom Function.prototype.bind() in favor of native version
https://bugs.webkit.org/show_bug.cgi?id=123608
Reviewed by Joseph Pecoraro.
- UserInterface/Utilities.js:
- 11:06 AM Changeset in webkit [158439] by
-
- 2 edits in trunk/Source/WebInspectorUI
Error trying to serialize a color created without an alpha component to RGBA or HSLA
https://bugs.webkit.org/show_bug.cgi?id=123623
Reviewed by Joseph Pecoraro.
Check whether we have .rgba and .hsla ivars before trying to retrieve them to serialize
the color to RGBA or HSLA format.
- UserInterface/Color.js:
(WebInspector.Color.prototype.toString):
- 11:03 AM Changeset in webkit [158438] by
-
- 6 edits in trunk/Source/WebCore
Adding addRemoteTrack and removeRemoteTrack functions to MediaStreamDescriptor and MediaStream
https://bugs.webkit.org/show_bug.cgi?id=123477
Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-01
Reviewed by Eric Carlson.
When the backend report that a remote track has been added or removed by a remote peer, we must be able to add
it to its MediaStream
No new tests needed.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::addTrack): Splitted in two parts that can be used by old addTrack and new addRemoteTrack.
(WebCore::MediaStream::removeTrack): Splitted in two parts that can be used by old removeTrack and new
removeRemoteTrack.
(WebCore::MediaStream::addRemoteSource): Reusing code in new addTrack method.
(WebCore::MediaStream::removeRemoteSource): Refactored.
(WebCore::MediaStream::addRemoteTrack): Added.
(WebCore::MediaStream::removeRemoteTrack): Added.
(WebCore::MediaStream::getTrackVectorForType): Helper method that returns a vector of tracks according to
track's type (Audio or Video).
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
- platform/mediastream/MediaStreamDescriptor.cpp:
(WebCore::MediaStreamDescriptor::addRemoteTrack): Added.
(WebCore::MediaStreamDescriptor::removeRemoteTrack): Added.
- platform/mediastream/MediaStreamDescriptor.h:
- 10:44 AM Changeset in webkit [158437] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] [WK2] Crash in webkitWebViewLoadFailedWithTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=123618
Patch by Brian Holt <brian.holt@samsung.com> on 2013-11-01
Reviewed by Mario Sanchez Prada.
The GOwnPtrSoup header was not included which meant that the
specialization for GOwnPtr<SoupURI> was not used and instead the
default freeOwnedGPtr which calls g_free is used and crashes.
- UIProcess/API/gtk/WebKitWebView.cpp:
- 9:30 AM Changeset in webkit [158436] by
-
- 30 edits6 copies1 move19 adds in trunk
[GStreamer] Support audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=117039
Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-01
Reviewed by Philippe Normand.
Source/WebCore:
Tests: media/track/audio/audio-track-mkv-vorbis-addtrack.html
media/track/audio/audio-track-mkv-vorbis-enabled.html
media/track/audio/audio-track-mkv-vorbis-language.html
media/track/in-band/track-in-band-kate-ogg-addtrack.html
media/track/in-band/track-in-band-srt-mkv-addtrack.html
media/track/video/video-track-mkv-theora-addtrack.html
media/track/video/video-track-mkv-theora-language.html
media/track/video/video-track-mkv-theora-selected.html
- GNUmakefile.list.am: Add audio and video track files.
- PlatformEfl.cmake: Same.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Schedule "change" event.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Same.
- html/track/AudioTrack.cpp:
(WebCore::AudioTrack::setEnabled): Call m_private->setEnabled
(WebCore::AudioTrack::enabledChanged): Added callback.
(WebCore::AudioTrack::labelChanged): Same.
(WebCore::AudioTrack::languageChanged): Same.
(WebCore::AudioTrack::willRemoveAudioTrackPrivate): Use ASSERT_UNUSED for consistence.
- html/track/AudioTrack.h: Add new enabled, label and language callbacks.
- html/track/VideoTrack.cpp:
(WebCore::VideoTrack::setSelected): Call m_private->setEnabled
(WebCore::VideoTrack::selectedChanged): Added callback.
(WebCore::VideoTrack::labelChanged): Same.
(WebCore::VideoTrack::languageChanged): Same.
(WebCore::VideoTrack::willRemoveVideoTrackPrivate): Use ASSERT_UNUSED for consistence.
- html/track/VideoTrack.h: Add new selected, label and language callbacks.
- platform/graphics/AudioTrackPrivate.h:
(WebCore::AudioTrackPrivate::setEnabled): Call m_client->enabledChanged
- platform/graphics/VideoTrackPrivate.h:
(WebCore::VideoTrackPrivate::setSelected): Call m_client->selectedChanged
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer): Add ASSERT(m_pad)
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfTagsChanged): Look at all tag events instead of just the first one.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::mediaPlayerPrivateVideoSinkCapsChangedCallback): Separated callback when caps change from callback when number of videos change.
(WebCore::mediaPlayerPrivateVideoCapsChangeTimeoutCallback): Same.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): Initialize m_videoCapsTimerHandler.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer): Disconnect audio and video tracks and remove callbacks.
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged): Separated callback when caps change from callback when number of videos change.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Create video tracks for each stream.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideoCaps): Separated callback when caps change from callback when number of videos change.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Create audio tracks for each stream.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add audio and video tracks, and a pointer to keep track of the default audio stream.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp: Added.
- platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Added.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Add GRefPtr<GstTagList>
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp: Added, handles tags and "active" property of audio and video tracks.
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Added.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: Added.
- platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Added.
LayoutTests:
- media/content/two-audio-and-video-tracks.mkv: Added.
- media/in-band-tracks.js: Renamed from LayoutTests/media/in-band-cues.js.
(testAddTrack): Tests addtrack events.
(testAttribute): Added "type" parameter so we can use this for audio and video tracks.
(testTextTrackMode): Renamed to make it clear that this only applies to text tracks.
(testCueStyle): Same.
(testTextTrackOrder): Same.
- media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Added.
- media/track/audio/audio-track-mkv-vorbis-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Added.
- media/track/audio/audio-track-mkv-vorbis-enabled.html: Added.
- media/track/audio/audio-track-mkv-vorbis-language-expected.txt: Added.
- media/track/audio/audio-track-mkv-vorbis-language.html: Copied from LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order.html.
- media/track/in-band/track-in-band-kate-ogg-addtrack-expected.txt: Added.
- media/track/in-band/track-in-band-kate-ogg-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/in-band/track-in-band-kate-ogg-cues-added-once.html: Added.
- media/track/in-band/track-in-band-kate-ogg-kind.html: Added.
- media/track/in-band/track-in-band-kate-ogg-language.html: Added.
- media/track/in-band/track-in-band-kate-ogg-mode.html: Added.
- media/track/in-band/track-in-band-kate-ogg-style.html: Added.
- media/track/in-band/track-in-band-kate-ogg-track-order.html: Added.
- media/track/in-band/track-in-band-srt-mkv-addtrack-expected.txt: Added.
- media/track/in-band/track-in-band-srt-mkv-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/in-band/track-in-band-srt-mkv-cues-added-once.html: Added.
- media/track/in-band/track-in-band-srt-mkv-kind.html: Added.
- media/track/in-band/track-in-band-srt-mkv-language.html: Added.
- media/track/in-band/track-in-band-srt-mkv-mode.html: Added.
- media/track/in-band/track-in-band-srt-mkv-style.html: Added.
- media/track/in-band/track-in-band-srt-mkv-track-order.html: Added.
- media/track/video/video-track-mkv-theora-addtrack-expected.txt: Added.
- media/track/video/video-track-mkv-theora-addtrack.html: Copied from LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html.
- media/track/video/video-track-mkv-theora-language-expected.txt: Added.
- media/track/video/video-track-mkv-theora-language.html: Copied from LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order.html.
- media/track/video/video-track-mkv-theora-selected-expected.txt: Added.
- media/track/video/video-track-mkv-theora-selected.html: Added.
- platform/mac/TestExpectations: Ignore audio and video track tests on mac.
- 7:40 AM Changeset in webkit [158435] by
-
- 2 edits in trunk/Source/WebInspectorUI
Remove custom Element.prototype.remove() in favor of native version
https://bugs.webkit.org/show_bug.cgi?id=123607
Reviewed by Timothy Hatcher.
- UserInterface/Utilities.js:
- 7:09 AM Changeset in webkit [158434] by
-
- 3 edits in trunk/Source/WebKit/win
[WIN] Reduce usage of CFSTR() in WebPreferences
https://bugs.webkit.org/show_bug.cgi?id=121827
Reviewed by Brent Fulgham.
This moved the dependency on CF to a few functions only
and is a first step to make it compile without CF.
- WebPreferences.cpp:
- WebPreferences.h:
- 6:57 AM Changeset in webkit [158433] by
-
- 2 edits in trunk/Source/WTF
Buildfix for !USE(ICU_UNICODE) after 156968.
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault):
- 5:48 AM Changeset in webkit [158432] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(INSPECTOR) after 157288.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willDispatchEvent):
- 5:43 AM Changeset in webkit [158431] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Skip webgl tests because EFL port doesn't fully support webgl yet.
- platform/efl/TestExpectations:
- 5:09 AM Changeset in webkit [158430] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. css3 text tests are failing since r158389
- platform/efl/TestExpectations: Add failure tests.
- 4:54 AM Changeset in webkit [158429] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening. Tests passing after r158273 and r158352
and rebaseline needed after r158195.
- platform/gtk/TestExpectations: Removed tests now passing.
- platform/gtk/accessibility/media-element-expected.txt: Rebaseline.
- 3:59 AM Changeset in webkit [158428] by
-
- 13 edits in trunk
[ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation
https://bugs.webkit.org/show_bug.cgi?id=123153
Reviewed by Chris Fleizach.
Source/WebCore:
Remove functions from the AtkText implementation that manually
walk the render tree to compose the text for a exposed objects in
certain cases (e.g. anonymous blocks, text controls).
The reason for this change is that the current implementation
follows an error-prone approach, since by doing things like
manually walking the render tree from here we are not properly
considering all the possible scenarios that might happen when
traversing text. This, however, is a task that is better suited
for the TextIterator, which is already written to consider all
those cases and to emit the proper character in every single
situation: text nodes, replaced objects and so on.
So, by removing all that too specific code (textForObject() and
textForRenderer() mainly) from WebKitAccessibleInterfaceText.cpp
and relying in AccessibilityObject::textUnderElement(), which it
ends up using the TextIterator for certain cases, we have a much
better and robust method of retrieving the text associated with an
instance of AtkObject implementing the AtkText interface.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetText): Removed call to textForObject(), now that
we have just removed that function, together with textForRenderer().
Make AccessibilityRenderObject::textUnderElement() able to deal with
anonymous blocks directly, by creating a range based in the boundaries
defined by the first and last child renderers for that block. This will
make possible to treat an anonymous block as a whole instead of having
to rely in the concatenation of each of its children, as it does now.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement): Added a new code
path to deal with anonymous blocks for text renderers, or when including
all the children is explicitly requested.
Modified TextIterator so text for children of replaced objects are
ignored if we are emmiting the special character for those objects.
- editing/TextIterator.cpp:
(WebCore::TextIterator::handleReplacedElement): Make sure no children are
handled a replaced object if m_emitsObjectReplacementCharacters is set.
- editing/TextIterator.h: Updated m_emitsObjectReplacementCharacters
description to reflect the new behavior.
LayoutTests:
Updated test expectations to properly reflect the new reality when it
comes to exposing replaced objects and anymous blocks.
- platform/gtk/accessibility/table-with-rules-expected.txt: Updated to
print <\n> explicitly for the two instances of <BR> that are present in the
test, that will be included as part of an anonymous block.
- platform/efl/accessibility/table-with-rules-expected.txt: Ditto.
- platform/efl-wk2/accessibility/table-with-rules-expected.txt: Ditto.
- platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt: Updated
expectations not to expect the text of a button to be shown.
- platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Ditto.
- platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt: Ditto.
- platform/gtk/TestExpectations: Removed replaced-objects-in-anonymous-blocks.html
from the list of expected failures, as it's now being properly exposed.
- 12:15 AM Changeset in webkit [158427] by
-
- 6 edits4 copies4 adds in trunk
Add a Mac WebCrypto implementation of HMAC importKey/sign/verify
https://bugs.webkit.org/show_bug.cgi?id=123598
Reviewed by Anders Carlsson.
Source/WebCore:
Test: crypto/subtle/hmac-sign-verify.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSSubtleCryptoCustom.cpp: Added property svn:eol-style.
(WebCore::createAlgorithmFromJSValue):
(WebCore::cryptoOperationDataFromJSValue):
(WebCore::cryptoKeyFormatFromJSValue):
(WebCore::cryptoKeyUsagesFromJSValue):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::importKey):
- crypto/SubtleCrypto.idl:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp: Added.
(WebCore::CryptoAlgorithmHMAC::CryptoAlgorithmHMAC):
(WebCore::CryptoAlgorithmHMAC::~CryptoAlgorithmHMAC):
(WebCore::CryptoAlgorithmHMAC::create):
(WebCore::CryptoAlgorithmHMAC::identifier):
(WebCore::CryptoAlgorithmHMAC::importKey):
(WebCore::CryptoAlgorithmHMAC::exportKey):
- crypto/algorithms/CryptoAlgorithmHMAC.h: Added.
- crypto/keys: Added.
- crypto/keys/CryptoKeyHMAC.cpp: Added.
(WebCore::CryptoKeyHMAC::CryptoKeyHMAC):
(WebCore::CryptoKeyHMAC::~CryptoKeyHMAC):
(WebCore::CryptoKeyHMAC::buildAlgorithmDescription):
- crypto/keys/CryptoKeyHMAC.h: Added.
- crypto/mac/CryptoAlgorithmHMACMac.cpp: Added.
(WebCore::getCommonCryptoAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
(WebCore::CryptoAlgorithmHMAC::generateKey):
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
LayoutTests:
- crypto/subtle/hmac-sign-verify-expected.txt: Added.
- crypto/subtle/hmac-sign-verify.html: Added.
- 12:15 AM Changeset in webkit [158426] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL][WK1] Rendering is broken when scrolled ewk_view_single repeatedly
https://bugs.webkit.org/show_bug.cgi?id=123609
Reviewed by Gyuyoung Kim.
ewk_view_single adds wrong updateRects except last one in scrolls_process,
because previous updateRects are not considered accumulated scrollOffsets.
- ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_scrolls_process):
Merged scrollOffsets to calculate updateRects once.
It will also reduce unnecessary memory copy operations.
Oct 31, 2013:
- 10:13 PM Changeset in webkit [158425] by
-
- 8 edits in trunk
JavaScript parser bug
https://bugs.webkit.org/show_bug.cgi?id=123506
Reviewed by Mark Lam.
Source/JavaScriptCore:
Add ParserState as an abstraction and use that to save and restore
the parser state around nested functions (We'll need to use this in
more places in future). Also fix a minor error typo this testcases
hit.
- parser/Parser.cpp:
(JSC::::parseFunctionInfo):
(JSC::::parseAssignmentExpression):
- parser/Parser.h:
(JSC::Parser::saveState):
(JSC::Parser::restoreState):
LayoutTests:
Update and add tests
- js/dom/assign-expected.txt:
- js/function-toString-parentheses-expected.txt:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 8:28 PM Changeset in webkit [158424] by
-
- 3 edits in trunk/LayoutTests
Update the test expectations for the bug 121452.
fast/frames/lots-of-objects.html and lots-of-iframes.html are timing out everywhere on Mac.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 7:47 PM Changeset in webkit [158423] by
-
- 2 edits in trunk/LayoutTests
Update the Mac test expectation for the mac-future.
- platform/mac/TestExpectations:
- 7:32 PM Changeset in webkit [158422] by
-
- 2 edits in trunk/Source/WebKit
Windows build fix attempt after r158421.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 7:05 PM Changeset in webkit [158421] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: Clean up a few Inspector interfaces
https://bugs.webkit.org/show_bug.cgi?id=123594
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- WebCore.exp.in:
- inspector/InjectedScriptHost.cpp:
- inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgentInterface::name):
- inspector/InspectorConsoleAgent.cpp:
- inspector/InspectorConsoleAgent.h:
(WebCore::InspectorConsoleAgent::enabled):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::profilerEnabled):
- inspector/InspectorController.h:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorDebuggerAgent.h:
(WebCore::InspectorDebuggerAgent::enabled):
- inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::enabled):
- 6:45 PM Changeset in webkit [158420] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 6:42 PM Changeset in webkit [158419] by
-
- 1 copy in tags/Safari-537.73.2
New Tag.
- 6:27 PM Changeset in webkit [158418] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo/review comment from Dan, in http://trac.webkit.org/changeset/158413
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
- 6:16 PM Changeset in webkit [158417] by
-
- 11 edits in trunk/Source
Remote Layer Tree: Vend layer contents via IOSurfaces
https://bugs.webkit.org/show_bug.cgi?id=123600
Reviewed by Anders Carlsson.
- Configurations/WebKit2.xcconfig:
Link WebKit2 against IOSurface.
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::dumpChangedLayers):
Dump the size of the backing store instead of the pointer of its
SharedBitmap, because that's slightly more useful.
- UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
If a layer's backing store uses accelerated drawing, hand the IOSurface
to the CALayer for display.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::PlatformCALayerRemote):
Initialize contentsScale to 1 to match CA. Other properties will follow.
(PlatformCALayerRemote::ensureBackingStore):
Instead of replacing the RemoteLayerBackingStore when its properties
change, allow it to update them on the fly. Replacing them caused
us to throw away repaint rects when the accelerated drawing
flag was flipped.
(PlatformCALayerRemote::acceleratesDrawing):
(PlatformCALayerRemote::setAcceleratesDrawing):
Store the accelerated drawing flag and mark it dirty when it changes.
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- WebProcess/WebPage/mac/RemoteLayerBackingStore.h:
(WebKit::RemoteLayerBackingStore::image):
Rename bitmap() to image() and have it create a CGImageRef from
the ShareableBitmap, ready for direct application to a CALayer.
(WebKit::RemoteLayerBackingStore::surface):
Return a IOSurface ready for direct application to a CALayer.
(WebKit::RemoteLayerBackingStore::acceleratesDrawing):
(WebKit::RemoteLayerBackingStore::hasFrontBuffer):
Return whether or not we have a front buffer/surface.
- WebProcess/WebPage/mac/RemoteLayerBackingStore.mm:
Forward-declare some CGIOSurface SPI.
(RemoteLayerBackingStore::RemoteLayerBackingStore):
(RemoteLayerBackingStore::ensureBackingStore):
Throw away our front image and reset flags if needed.
(RemoteLayerBackingStore::encode):
(RemoteLayerBackingStore::decode):
En/decode the front surface instead of the ShareableBitmap if needed,
using CoreIPC::MachPort. Destroy the port on receipt.
(createIOSurfaceContext):
Create a CGIOSurfaceContext from an IOSurface.
(createIOSurface):
Create an IOSurface of the given size.
(RemoteLayerBackingStore::image):
Return a CGImageRef, if we're not using accelerated drawing.
Moved from the header.
(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
If using accelerated drawing, create and paint into an IOSurface.
Reorganize some code to make the copying-from-the-front-image code
work for both software and IOSurfaces.
Flush the context when completed, to ensure that any asynchronous
painting is complete before we vend the surface to the UI process.
- WebCore.exp.in:
Export sRGBColorSpaceRef.
- WebCore.xcodeproj/project.pbxproj:
Expose GraphicsContextCG.h.
- 6:11 PM Changeset in webkit [158416] by
-
- 3 edits in trunk/Source/WebCore
Remove unused Page::setDebuggerForAllPages
https://bugs.webkit.org/show_bug.cgi?id=123602
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- page/Page.cpp:
- page/Page.h:
- 6:07 PM Changeset in webkit [158415] by
-
- 75 edits3 deletes in trunk/Source
Web Inspector: Remove InspectorState
https://bugs.webkit.org/show_bug.cgi?id=123547
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
- inspector/InspectorAgent.h:
(WebCore::InspectorAgent::create):
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorApplicationCacheAgent.cpp:
(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
- inspector/InspectorApplicationCacheAgent.h:
(WebCore::InspectorApplicationCacheAgent::create):
- inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
- inspector/InspectorBaseAgent.h:
(WebCore::InspectorBaseAgent::InspectorBaseAgent):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
- inspector/InspectorCSSAgent.h:
(WebCore::InspectorCSSAgent::create):
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
- inspector/InspectorCanvasAgent.h:
(WebCore::InspectorCanvasAgent::create):
- inspector/InspectorClient.h:
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
- inspector/InspectorConsoleAgent.h:
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
- inspector/InspectorController.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
- inspector/InspectorDOMAgent.h:
(WebCore::InspectorDOMAgent::create):
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::create):
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
- inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create):
- inspector/InspectorDatabaseAgent.cpp:
(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
- inspector/InspectorDatabaseAgent.h:
(WebCore::InspectorDatabaseAgent::create):
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorHeapProfilerAgent.cpp:
(WebCore::InspectorHeapProfilerAgent::create):
(WebCore::InspectorHeapProfilerAgent::InspectorHeapProfilerAgent):
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
- inspector/InspectorIndexedDBAgent.h:
(WebCore::InspectorIndexedDBAgent::create):
- inspector/InspectorInputAgent.cpp:
(WebCore::InspectorInputAgent::InspectorInputAgent):
- inspector/InspectorInputAgent.h:
(WebCore::InspectorInputAgent::create):
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
- inspector/InspectorLayerTreeAgent.h:
(WebCore::InspectorLayerTreeAgent::create):
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::create):
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::create):
(WebCore::InspectorPageAgent::InspectorPageAgent):
- inspector/InspectorPageAgent.h:
- inspector/InspectorProfilerAgent.cpp:
(WebCore::PageProfilerAgent::PageProfilerAgent):
(WebCore::InspectorProfilerAgent::create):
(WebCore::WorkerProfilerAgent::WorkerProfilerAgent):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::InspectorResourceAgent):
- inspector/InspectorResourceAgent.h:
(WebCore::InspectorResourceAgent::create):
- inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
- inspector/InspectorRuntimeAgent.h:
- inspector/InspectorState.cpp: Removed.
- inspector/InspectorState.h: Removed.
- inspector/InspectorStateClient.h: Removed.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h:
(WebCore::InspectorTimelineAgent::create):
- inspector/InspectorWorkerAgent.cpp:
(WebCore::InspectorWorkerAgent::create):
(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
- inspector/InspectorWorkerAgent.h:
- inspector/PageConsoleAgent.cpp:
(WebCore::PageConsoleAgent::PageConsoleAgent):
- inspector/PageConsoleAgent.h:
(WebCore::PageConsoleAgent::create):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
- inspector/PageDebuggerAgent.h:
- inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::PageRuntimeAgent):
- inspector/PageRuntimeAgent.h:
(WebCore::PageRuntimeAgent::create):
- inspector/WorkerConsoleAgent.cpp:
(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
- inspector/WorkerConsoleAgent.h:
(WebCore::WorkerConsoleAgent::create):
- inspector/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::create):
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
- inspector/WorkerDebuggerAgent.h:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
- inspector/WorkerInspectorController.h:
- inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
- inspector/WorkerRuntimeAgent.h:
(WebCore::WorkerRuntimeAgent::create):
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
Source/WebKit/blackberry:
- WebCoreSupport/InspectorClientBlackBerry.cpp:
- WebCoreSupport/InspectorClientBlackBerry.h:
- 6:01 PM Changeset in webkit [158414] by
-
- 2 edits in trunk/Source/WebKit/win
Compile fix for VS2012.
https://bugs.webkit.org/show_bug.cgi?id=123599
Patch by Alex Christensen <achristensen@webkit.org> on 2013-10-31
Reviewed by Brent Fulgham.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::WebFramePolicyListenerPrivate::WebFramePolicyListenerPrivate):
(WebFrameLoaderClient::cancelPolicyCheck):
(WebFrameLoaderClient::receivedPolicyDecision):
Use nullptr instead of 0 for m_policyFunction, which is a std::function.
- 5:48 PM Changeset in webkit [158413] by
-
- 4 edits3 adds in trunk/Source/WebKit2
Begin stubbing out the WKRemoteObjectCoder NSCoder subclass
https://bugs.webkit.org/show_bug.cgi?id=123596
Reviewed by Tim Horton.
- Shared/API/Cocoa/WKRemoteObject.mm:
(-[WKRemoteObject forwardInvocation:]):
Call through to the WKRemoteObjectRegistry.
- Shared/API/Cocoa/WKRemoteObjectCoder.h: Added.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm: Added.
(-[WKRemoteObjectEncoder init]):
Create a root WKDictionary.
(-[WKRemoteObjectEncoder dealloc]):
Assert that the current dictionary is the root dictionary; that we're back where we started.
(-[WKRemoteObjectEncoder allowsKeyedCoding]):
Return YES.
(-[WKRemoteObjectEncoder encodeObject:forKey:]):
Check that the object is valid and then encode it.
(-[WKRemoteObjectEncoder _encodeInvocation:forKey:]):
Encode the method type string and invocation selector.
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
Create a WKDataRef and add it to the dictionary.
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):
Create a new dictionary and call the block.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Create an encoder and encode the invocation and interface.
- Shared/API/Cocoa/WKRemoteObjectRegistryInternal.h: Added.
Add IPI header.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 5:45 PM Changeset in webkit [158412] by
-
- 2 edits in trunk/Source/JavaScriptCore
FTL Int32ToDouble should handle the forward type check case where you need a recovery
https://bugs.webkit.org/show_bug.cgi?id=123605
Reviewed by Mark Hahnenberg.
If you have a Int32ToDouble that needs to do a type check and it's required to do a
forward exit, then it needs to manually pass in a value recovery for itself in the
OSR exit - since this is one of those forward-exiting nodes that doesn't have a
preceding MovHint.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
- 5:35 PM Changeset in webkit [158411] by
-
- 4 edits2 copies in branches/safari-537.73-branch
Merged r157183. <rdar://problem/15333287>
- 5:31 PM Changeset in webkit [158410] by
-
- 3 edits in trunk/Source/WebKit2
Address review comments.
- Shared/API/Cocoa/WKRemoteObject.h:
- Shared/API/Cocoa/WKRemoteObject.mm:
(-[WKRemoteObject conformsToProtocol:]):
- 5:05 PM Changeset in webkit [158409] by
-
- 5 edits1 add in trunk/Source/WebCore
Split PendingDeleteCall into its own header
https://bugs.webkit.org/show_bug.cgi?id=123597
Reviewed by Beth “Okay I guess so, bro” Dakin.
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
- Modules/indexeddb/IDBDatabaseBackendImpl.h:
- Modules/indexeddb/IDBPendingDeleteCall.h: Added.
(WebCore::IDBPendingDeleteCall::create):
(WebCore::IDBPendingDeleteCall::callbacks):
(WebCore::IDBPendingDeleteCall::IDBPendingDeleteCall):
- 5:01 PM Changeset in webkit [158408] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Convert some InspectorObject member variables to HashSet/HashMap
https://bugs.webkit.org/show_bug.cgi?id=123579
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
Make m_eventListenerBreakpoints and m_xhrBreakpoints HashSet.
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
Make m_javaScriptBreakpoints a HashMap.
- 4:56 PM Changeset in webkit [158407] by
-
- 6 edits1 copy1 add in trunk
Add a WKRemoteObject class
https://bugs.webkit.org/show_bug.cgi?id=123586
Reviewed by Dan Bernstein.
Source/WebKit2:
- Shared/API/Cocoa/WKRemoteObject.h: Added.
- Shared/API/Cocoa/WKRemoteObject.mm: Added.
(-[WKRemoteObject _initWithObjectRegistry:interface:]):
Add designated initializer.
(-[WKRemoteObject conformsToProtocol:]):
Check if the interface protocol conforms to our protocol.
(methodArgumentTypeEncodingForSelector):
Helper function that looks up a method in a given protocol and returns its type encoding.
(-[WKRemoteObject methodSignatureForSelector:]):
Try to find the method argument type encoding for the given selector and return its NSMethodSignature.
(-[WKRemoteObject forwardInvocation:]):
Add stub.
- Shared/API/Cocoa/WKRemoteObjectInterface.mm:
Remove a newline.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry remoteObjectProxyWithInterface:]):
Establish a mapping between interface identifiers and remote object proxies.
- WebKit2.xcodeproj/project.pbxproj:
Tools:
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
(TestWebKitAPI::TEST):
Add a conformsToProtocol: test.
- 4:30 PM Changeset in webkit [158406] by
-
- 19 edits9 copies in tags/Safari-538.4
- 4:23 PM Changeset in webkit [158405] by
-
- 4 edits2 adds in trunk
Correct the elapsedTime calculation in SVG animations
https://bugs.webkit.org/show_bug.cgi?id=119289
Patch by Youenn Fablet <youennf@gmail.com> on 2013-10-31
Reviewed by Brent Fulgham.
Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/338f9badca7fb7880abdb0cecd5f02493c1f7d2e
Source/WebCore:
Test: svg/animations/getCurrentTime-pause-unpause.html
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::elapsed):
(WebCore::SMILTimeContainer::begin):
(WebCore::SMILTimeContainer::pause):
(WebCore::SMILTimeContainer::resume):
(WebCore::SMILTimeContainer::setElapsed):
- svg/animation/SMILTimeContainer.h:
LayoutTests:
- svg/animations/getCurrentTime-pause-unpause-expected.txt: Added.
- svg/animations/getCurrentTime-pause-unpause.html: Added.
- 4:12 PM Changeset in webkit [158404] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Breakpoints in auto-formatted JavaScript editors are not working
https://bugs.webkit.org/show_bug.cgi?id=123589
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
The internal this._ignoreCodeMirrorContentDidChangeEvent flag was being used
in two places that could be nested, meaning the flag was deleted while it
was still expected to be set. Change it instead to a counter, to handle nesting.
- UserInterface/TextEditor.js:
(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype.set string):
(WebInspector.TextEditor.prototype.set formatted):
(WebInspector.TextEditor.prototype._contentChanged):
- 3:57 PM Changeset in webkit [158403] by
-
- 3 edits in tags/Safari-538.4/Source/WebCore
Merged r158391. <rdar://problem/15246606>
- 3:49 PM Changeset in webkit [158402] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL should implement InvalidationPoint in terms of llvm.stackmap
https://bugs.webkit.org/show_bug.cgi?id=113647
Reviewed by Mark Hahnenberg.
This is pretty straightforward now that InvalidationPoint has exactly the semantics
that agree with llvm.stackmap.
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::callStackmap):
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- 3:38 PM Changeset in webkit [158401] by
-
- 9 edits in trunk
Source/JavaScriptCore: Implement basic ES6 Math functions
https://bugs.webkit.org/show_bug.cgi?id=123536
Reviewed by Michael Saboff.
Fairly trivial patch to implement the core ES6 Math functions.
This doesn't implement Math.hypot as it is not a trivial function.
I've also skipped Math.sign as I am yet to be convinced the spec
behaviour is good. Everything else is trivial.
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncACosh):
(JSC::mathProtoFuncASinh):
(JSC::mathProtoFuncATanh):
(JSC::mathProtoFuncCbrt):
(JSC::mathProtoFuncCosh):
(JSC::mathProtoFuncExpm1):
(JSC::mathProtoFuncFround):
(JSC::mathProtoFuncLog1p):
(JSC::mathProtoFuncLog10):
(JSC::mathProtoFuncLog2):
(JSC::mathProtoFuncSinh):
(JSC::mathProtoFuncTanh):
(JSC::mathProtoFuncTrunc):
Source/WTF: Implement basic ES6 Math functions
https://bugs.webkit.org/show_bug.cgi?id=123536
Reviewed by Michael Saboff.
Add basic implementations of necessary methods to MathExtras to
deal with MSVC not supplying them
- wtf/MathExtras.h:
(asinh):
(acosh):
(atanh):
(expm1):
(log1p):
(cbrt):
LayoutTests: Implement ES6 Math functions
https://bugs.webkit.org/show_bug.cgi?id=123536
Reviewed by Michael Saboff.
Add tests for new math functions
- js/Object-getOwnPropertyNames-expected.txt:
- js/math-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/math.js:
- 3:29 PM Changeset in webkit [158400] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL::Location::restoreInto() doesn't handle stack-related registers correctly if you're using it after pushing a new stack frame
https://bugs.webkit.org/show_bug.cgi?id=123591
Reviewed by Mark Hahnenberg.
This gets us to pass more tests with ftlUsesStackmaps.
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::restoreInto):
- ftl/FTLLocation.h:
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationWithStackMapThunkGenerator):
- 3:21 PM Changeset in webkit [158399] by
-
- 8 edits in branches/safari-537.73-branch/Source
Merged r157056. <rdar://problem/15357230>
- 2:59 PM Changeset in webkit [158398] by
-
- 3 edits in trunk/Source/WebCore
Manage line-grid RootInlineBox with unique_ptr.
<https://webkit.org/b/123583>
Use smart pointers for the RenderBlockFlow's optional line-grid box
instead of manual new/delete.
Reviewed by Antti Koivisto.
- 2:50 PM Changeset in webkit [158397] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r156481. <rdar://problem/15168249>
- 2:50 PM Changeset in webkit [158396] by
-
- 18 edits19 moves3 adds in trunk
Enable WebCrypto on Mac
https://bugs.webkit.org/show_bug.cgi?id=123587
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Do it.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Enable it.
- bindings/js/JSCryptoAlgorithmDictionary.cpp: Build fix.
- crypto/CryptoAlgorithmRegistry.cpp: (WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
Special case empty keys to avoid upsetting HashMap.
- crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::create):
Build fix. Can't use make_unique, because constructor is private.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Do it.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: Do it.
LayoutTests:
- TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
Only skipping on specific platforms now.
- crypto: Added.
- crypto/crypto-gc-expected.txt: Copied from LayoutTests/security/crypto-gc-expected.txt.
- crypto/crypto-gc.html: Copied from LayoutTests/security/crypto-gc.html.
- crypto/crypto-random-values-expected.txt: Copied from LayoutTests/security/crypto-random-values-expected.txt.
- crypto/crypto-random-values-limits-expected.txt: Copied from LayoutTests/security/crypto-random-values-limits-expected.txt.
- crypto/crypto-random-values-limits.html: Copied from LayoutTests/security/crypto-random-values-limits.html.
- crypto/crypto-random-values-types-expected.txt: Copied from LayoutTests/security/crypto-random-values-types-expected.txt.
- crypto/crypto-random-values-types.html: Copied from LayoutTests/security/crypto-random-values-types.html.
- crypto/crypto-random-values.html: Copied from LayoutTests/security/crypto-random-values.html.
- crypto/subtle: Added.
- crypto/subtle/argument-conversion-expected.txt: Copied from LayoutTests/security/crypto-subtle-arguments-expected.txt.
- crypto/subtle/argument-conversion.html: Copied from LayoutTests/security/crypto-subtle-arguments.html.
- crypto/subtle/gc-2-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-2-expected.txt.
- crypto/subtle/gc-2.html: Copied from LayoutTests/security/crypto-subtle-gc-2.html.
- crypto/subtle/gc-3-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-3-expected.txt.
- crypto/subtle/gc-3.html: Copied from LayoutTests/security/crypto-subtle-gc-3.html.
- crypto/subtle/gc-expected.txt: Copied from LayoutTests/security/crypto-subtle-gc-expected.txt.
- crypto/subtle/gc.html: Copied from LayoutTests/security/crypto-subtle-gc.html.
- crypto/subtle/resources: Added.
- crypto/subtle/resources/common.js: Copied from LayoutTests/security/resources/common.js.
- crypto/subtle/sha-1-expected.txt: Copied from LayoutTests/security/crypto-subtle-sha1-expected.txt.
- crypto/subtle/sha-1.html: Copied from LayoutTests/security/crypto-subtle-sha1.html.
- security/crypto-gc-expected.txt: Removed.
- security/crypto-gc.html: Removed.
- security/crypto-random-values-expected.txt: Removed.
- security/crypto-random-values-limits-expected.txt: Removed.
- security/crypto-random-values-limits.html: Removed.
- security/crypto-random-values-types-expected.txt: Removed.
- security/crypto-random-values-types.html: Removed.
- security/crypto-random-values.html: Removed.
- security/crypto-subtle-arguments-expected.txt: Removed.
- security/crypto-subtle-arguments.html: Removed.
- security/crypto-subtle-gc-2-expected.txt: Removed.
- security/crypto-subtle-gc-2.html: Removed.
- security/crypto-subtle-gc-3-expected.txt: Removed.
- security/crypto-subtle-gc-3.html: Removed.
- security/crypto-subtle-gc-expected.txt: Removed.
- security/crypto-subtle-gc.html: Removed.
- security/crypto-subtle-sha1-expected.txt: Removed.
- security/crypto-subtle-sha1.html: Removed.
- security/resources/common.js: Removed.
Moved tests from security/ to crypto/.
- 2:29 PM Changeset in webkit [158395] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r154897. <rdar://problem/15168237>
- 2:24 PM Changeset in webkit [158394] by
-
- 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI
Merged r153087. <rdar://problem/15168237>
- 2:15 PM Changeset in webkit [158393] by
-
- 2 edits2 adds in trunk/Tools
build.webkit.org should have a clean build button
https://bugs.webkit.org/show_bug.cgi?id=123559
Reviewed by Darin Adler.
Add a new "clean" forced scheduler. When a build was created by this scheduler, CleanBuildIfScheduled
step executes clean-build script that removes the WebKitBuild directory.
Also added make-passwords-json.py which creates a fake passwords.json from config.json for testing purposes.
- BuildSlaveSupport/build.webkit.org-config/make-passwords-json.py: Added.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CleanBuildIfScheduled): Added.
(CleanBuildIfScheduled.start): Added. Don't do a clean build if if this build wasn't schecueld by
the clean build scheduler.
(DeleteStaleBuildFiles): Added.
(DeleteStaleBuildFiles.start): Added. Don't delete stale build files if this build was scheduled by
the clean build scheduler since everything in the WebKitBuild directory had already been removed.
(Factory.init): Always add CleanBuildIfScheduled. The step itself checks whether to run
clean-build script or hide itself.
(loadBuilderConfig): Added the new clean build scheduler. Also make ForceScheduler future proof; in newer
versions of buildbot, builderNames needs to be a list of regular strings.
- BuildSlaveSupport/clean-build: Added.
- 2:14 PM Changeset in webkit [158392] by
-
- 6 edits in trunk/Source/WebCore
Underline bounds cannot be queried before underline itself is drawn
https://bugs.webkit.org/show_bug.cgi?id=123310
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
Reviewed by Dean Jackson.
GraphicsContext's drawLineForText function is used to draw underlines,
strikethroughs, and overlines. Before drawing the line, this function
modifies the bounds given to it in order to make underlines crisp. However,
this means that it is impossible to know where an underline will be drawn
before drawing it. This patch pulls out this adjustment computation into
GraphicsContext::computeLineBoundsForText, then passes the result to
drawLineForText
Because there should be no observable difference, no tests need to be updated.
- platform/graphics/GraphicsContext.h: Signature of new computeLineBoundsForText
function
- platform/graphics/blackberry/PathBlackBerry.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText): Implement new function
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText): Ditto
(WebCore::GraphicsContext::drawLineForText): Use computeLineBoundsForText
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::computeLineBoundsAndAntialiasingModeForText): Static function that
performs the actual bounds computation
(WebCore::GraphicsContext::computeLineBoundsForText): Calls
computeLineBoundsAndAntialiasingModeForText
(WebCore::GraphicsContext::drawLineForText): Use new function
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::computeLineBoundsForText): Implement new function
- 2:03 PM Changeset in webkit [158391] by
-
- 3 edits in trunk/Source/WebCore
Repro scrolling crash with scrollbars that use setPresentationValue on the
scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=123549
-and corresponding-
<rdar://problem/15246606>
Reviewed by Brady Eidson.
Here's another speculative fix. If a scrollbar was removed, we would not properly
inform the scrolling thread. Instead of checking supportsUpdateOnSecondaryThread()
before calling setScrollbarPaintersFromScrollbars(), check it from within
setScrollbarPaintersFromScrollbars(), and this will allow the ScrollbarPainter to
be properly updated.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
- page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
(WebCore::ScrollingStateScrollingNode::setScrollbarPaintersFromScrollbars):
- 1:13 PM Changeset in webkit [158390] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed typo fix after 158386. (buildfix after r158365)
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler):
- 1:11 PM Changeset in webkit [158389] by
-
- 30 edits4 adds in trunk
Move CSS3 text decoration implementation behind ENABLE(CSS3_TEXT_DECORATION)
https://bugs.webkit.org/show_bug.cgi?id=123541
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
Reviewed by Tim Horton.
Source/WebCore:
Enabled CSS3 text decoration tests
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationStyleFlagsToCSSValue): Mapping internal
representation to a CSSValue
(WebCore::ComputedStyleExtractor::propertyValue): Ditto
- css/CSSParser.cpp: Moving parsing functions behind new flag
(WebCore::isColorPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::addTextDecorationProperty):
(WebCore::CSSParser::parseTextDecorationSkip):
(WebCore::CSSParser::parseTextUnderlinePosition):
- css/CSSParser.h:
- css/CSSPrimitiveValueMappings.h:
- css/CSSPropertyNames.in: Marking the new properties behind new flag
- css/CSSValueKeywords.in: Marking new values behind new flag
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StylePropertyShorthand.cpp:
(WebCore::shorthandForProperty): Move text decoration shorthand
(WebCore::matchingShorthandsForLonghand):
- css/StylePropertyShorthand.h:
- css/StyleResolver.cpp:
(WebCore::isValidVisitedLinkProperty):
(WebCore::StyleResolver::applyProperty):
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformStrokeStyle):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
- platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::createPen):
- rendering/InlineFlowBox.cpp:
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.cpp:
(WebCore::textDecorationStyleToStrokeStyle):
(WebCore::computeUnderlineOffset):
(WebCore::InlineTextBox::paintDecoration):
- rendering/RenderObject.cpp:
(WebCore::decorationColor):
- rendering/RootInlineBox.cpp:
- rendering/RootInlineBox.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- platform/mac/TestExpectations: Enable CSS3 text decoration tests
(since CSS3_TEXT_DECORATION is enabled by default)
- 12:50 PM Changeset in webkit [158388] by
-
- 11 edits in trunk/Source/WebKit2
[WK2] Convert SeccompFilters to using unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122883
Patch by Sergio Correia <Sergio Correia> on 2013-10-31
Reviewed by Darin Adler.
- Shared/linux/SeccompFilters/OpenSyscall.cpp:
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::execute):
- Shared/linux/SeccompFilters/OpenSyscall.h:
- Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SIGSYSHandler):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):
- Shared/linux/SeccompFilters/SigactionSyscall.cpp:
(WebKit::SigactionSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigactionSyscall.h:
- Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp:
(WebKit::SigprocmaskSyscall::createFromContext):
- Shared/linux/SeccompFilters/SigprocmaskSyscall.h:
- Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::SyscallResult::createFromDecoder):
- Shared/linux/SeccompFilters/Syscall.h:
- Shared/linux/SeccompFilters/SyscallPolicy.cpp:
- 12:31 PM Changeset in webkit [158387] by
-
- 7 edits9 adds in trunk
[WebCrypto] Add SHA-1
https://bugs.webkit.org/show_bug.cgi?id=123582
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: security/crypto-subtle-arguments.html
security/crypto-subtle-sha1.html
- WebCore.xcodeproj/project.pbxproj: Added new files.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::createAlgorithmFromJSValue):
(WebCore::sequenceOfCryptoOperationDataFromJSValue):
(WebCore::JSSubtleCrypto::digest):
- crypto/SubtleCrypto.idl:
Added bindings for crypto.digest.
- crypto/algorithms: Added.
- crypto/algorithms/CryptoAlgorithmSHA1.cpp: Added.
- crypto/algorithms/CryptoAlgorithmSHA1.h: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp:
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Register SHA-1.
- crypto/mac/CryptoAlgorithmSHA1Mac.cpp: Added.
(WebCore::CryptoAlgorithmSHA1::digest): Performs the work synchronously, because
otherwise we'd have to copy the data first, which is crazy for something as simple
as hashing. We can change to a dispatch queue later if we find that it's actually
better to copy and do the work asynchronously.
LayoutTests:
- security/resources/common.js: Added from Blink.
(importTestKeys):
(asciiToArrayBuffer):
(printRejectedResult):
(printAcceptedResult):
(failAndFinishJSTest):
- security/crypto-subtle-arguments-expected.txt: Added.
- security/crypto-subtle-arguments.html: Added.
Added tests for how bindings treat crazy arguments. Heavily based on a test from Blink.
- security/crypto-subtle-sha1-expected.txt: Added.
- security/crypto-subtle-sha1.html: Added.
Test that SHA-1 works.
- TestExpectations: Skip these tests everywhere for now.
- 12:22 PM Changeset in webkit [158386] by
-
- 2 edits in trunk/Source/WebCore
One more speculative buildfix after r158365.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::callSuccessHandler):
- 12:20 PM Changeset in webkit [158385] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, really remove CachedTranscendentalFunction.h.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- 12:19 PM Changeset in webkit [158384] by
-
- 22 edits6 adds1 delete in trunk
Remove CachedTranscendentalFunction because caching math functions is an ugly idea
https://bugs.webkit.org/show_bug.cgi?id=123574
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
This is performance-neutral because I also make Math.cos/sin intrinsic. This means that
we gain the "overhead" of actually computing sin and cos but we lose the overhead of
going through the native call thunks.
Caching transcendental functions is a really ugly idea. It works for SunSpider because
that benchmark makes very predictable calls into Math.sin. But I don't believe that this
is representative of any kind of reality, and so for sensible uses of Math.sin/cos all
that this was doing was adding more call overhead and some hashing overhead.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::propagate):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::doDoubleVoting):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/JITOperations.h:
- runtime/CachedTranscendentalFunction.h: Removed.
- runtime/DateInstanceCache.h:
- runtime/Intrinsic.h:
- runtime/MathObject.cpp:
(JSC::MathObject::finishCreation):
(JSC::mathProtoFuncCos):
(JSC::mathProtoFuncSin):
- runtime/VM.h:
Tools:
Reviewed by Mark Hahnenberg.
Make it easier to see that a test doesn't have an -expected file.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/dfg-cos-constant-expected.txt: Added.
- js/dfg-cos-constant.html: Added.
- js/dfg-sin-constant-expected.txt: Added.
- js/dfg-sin-constant.html: Added.
- js/script-tests/dfg-cos-constant.js: Added.
(foo):
- js/script-tests/dfg-sin-constant.js: Added.
(foo):
- 12:17 PM Changeset in webkit [158383] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r158348): Breaks Debug build
https://bugs.webkit.org/show_bug.cgi?id=123562
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-10-31
Reviewed by Brady Eidson.
Remove an unnecessary check that cause compilation failure.
No new tests since this just fixes the build failure.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
- 12:16 PM Changeset in webkit [158382] by
-
- 2 edits in trunk/Source/WebCore
One more speculative buildfix after r158365.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didAddRemoteStream):
- 12:08 PM Changeset in webkit [158381] by
-
- 3 edits in trunk/Source/WebCore
Speculative buildfix after r158365.
- Modules/mediastream/VideoStreamTrack.cpp:
(WebCore::VideoStreamTrack::create):
(WebCore::VideoStreamTrack::VideoStreamTrack):
- Modules/mediastream/VideoStreamTrack.h:
- 12:08 PM Changeset in webkit [158380] by
-
- 2 edits in tags/Safari-538.4/Source/WebCore
Merged r158375. <rdar://problem/15246606>
- 11:47 AM Changeset in webkit [158379] by
-
- 2 edits in trunk/Source/WebCore
Decorated text sometimes does not draw its decorations
https://bugs.webkit.org/show_bug.cgi?id=123539
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
Reviewed by Antti Koivisto.
Decorated text should opt-out of the simple line layout, because
SimpleLineLayout::paintFlow doesn't draw decorations
Fixes fast/css3-text/css3-text-decoration/text-decoration-color.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 11:40 AM Changeset in webkit [158378] by
-
- 4 edits in tags/Safari-538.4/Source/JavaScriptCore
Merged r158341. <rdar://problem/15356238>
- 11:33 AM Changeset in webkit [158377] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Remove last member variable uses of InspectorState from Agents
https://bugs.webkit.org/show_bug.cgi?id=123540
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):
DOMDebuggerAgentState::eventListenerBreakpoints -> m_eventListenerBreakpoints.
DOMDebuggerAgentState::xhrBreakpoints -> m_xhrBreakpoints.
- inspector/InspectorDebuggerAgent.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
DebuggerAgentState::javaScriptBreakpoints -> m_javaScriptBreakpoints.
- inspector/InspectorPageAgent.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::addScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::removeScriptToEvaluateOnLoad):
(WebCore::InspectorPageAgent::didClearWindowObjectInWorld):
PageAgentState::pageAgentScriptsToEvaluateOnLoad -> m_scriptsToEvaluateOnLoad.
This is a lazily created InspectorObject member variable.
- inspector/InspectorResourceAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::disable):
(WebCore::InspectorResourceAgent::setExtraHTTPHeaders):
ResourceAgentState::extraRequestHeaders -> m_extraRequestHeaders.
This is a lazily created InspectorObject member variable.
- 11:29 AM Changeset in webkit [158376] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, one more build fix after r158365.
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- 11:26 AM Changeset in webkit [158375] by
-
- 2 edits in trunk/Source/WebCore
Repro scrolling crash with scrollbars that use setPresentationValue on the
scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=123549
-and corresponding-
<rdar://problem/15246606>
Reviewed by Darin Adler.
Speculative fix. I think if we retain the ScrollbarPainters, we should avoid this
crash.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- 11:18 AM Changeset in webkit [158374] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, MediaStream build fix after r158365.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::clone):
- 11:13 AM Changeset in webkit [158373] by
-
- 4 edits in trunk/Tools
Run tests as if they are expected to pass when --force is given.
https://bugs.webkit.org/show_bug.cgi?id=112890
Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-10-31
Reviewed by Ryosuke Niwa.
The --force switch of new-run-webkit-tests is now forces all tests to
be run with 'PASS' as expected result.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.init):
(TestExpectations._add_expectations):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
(_set_up_derived_options):
- 11:05 AM Changeset in webkit [158372] by
-
- 12 edits in trunk/Source/WebKit2
Change WebPage, WebPageProxy, WebPageCreationParameters to use ViewState
https://bugs.webkit.org/show_bug.cgi?id=123379
Reviewed by Darin Adler.
Visibility state of the Page should be stored and communicated consistently.
Remove individual visibility flags from WebPageProxy, WebPageCreationParameters,
and replace them with a ViewState, and add a ViewState member to WebPage.
Merge together all messages that convey and individual aspect of the ViewState.
Restructure WebPageProxy::viewStateDidChange to break the operation down into
three steps: 1) update m_viewState, 2) send the new ViewState to the WebProcess,
and 3) perform any further work necessary in the UIProcess.
This patch fixes a problem that if the web process crashes m_isVisible &
m_isInWindow in WebPageProxy were not updated, and could have held stale values
on reattach.
In WebPage, add a new message to update the entire ViewState - diff the prior
value against the new one to detect changes, call existing methods accordingly.
- Shared/ViewState.h:
- Add constants 'Reset', 'AllFlags'
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Removed boolean visibility flags, added viewState.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- Constructor calls updateViewState to initialize m_viewState.
(WebKit::WebPageProxy::reattachToWebProcess):
- ViewStaet is not updated while detatched; recalculate.
(WebKit::WebPageProxy::initializeWebPage):
- m_isVisible -> isViewVisible()
(WebKit::WebPageProxy::updateViewState):
- Added, update m_viewState by querying the page client.
(WebKit::WebPageProxy::viewStateDidChange):
- Restructured to use m_viewState, reordered to combine messages.
(WebKit::WebPageProxy::creationParameters):
- Removed boolean visibility flags, added viewState.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isInWindow):
(WebKit::WebPageProxy::isViewVisible):
- Removed boolean visibility flags, added viewState.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- initial state now passed as a ViewState.
(WebKit::WebPage::setIsInWindow):
- Remove code to send reply (this is handled by setViewState).
(WebKit::WebPage::setViewState):
- Set m_viewState - diff from prior & call methods to update.
- WebProcess/WebPage/WebPage.h:
- Added setViewState, m_viewState.
- WebProcess/WebPage/WebPage.messages.in:
- Add SetViewState, remove individual messages.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
- initial state now passed as a ViewState.
- 11:03 AM Changeset in webkit [158371] by
-
- 2 edits in trunk/Tools
2013-10-31 Geoffrey Garen <ggaren@apple.com>
Added Mark Lam as a reviewer.
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 11:02 AM Changeset in webkit [158370] by
-
- 4 edits in trunk/Source/WebKit/win
[WIN] Make WebHistory compile without USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=122010
Reviewed by Brent Fulgham.
Add an alternative code path for !USE(CF) to be able to
compile WebHistory without the CoreFoundation library.
- COMVariantSetter.h: Add support for setting a Vector.
- WebHistory.cpp:
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
- WebHistory.h:
- 10:48 AM Changeset in webkit [158369] by
-
- 4 edits2 adds in trunk
WebPageCreationParameters should be consistent in Window.open
https://bugs.webkit.org/show_bug.cgi?id=123557
Reviewed by Sam Weinig.
When Window.open in called in WebKit2 the WebProcess sends a synchronous request to open
a page (WebPageProxy::createNewPage). The UIProcess creates a WebpageProxy, and responds
with instructions to the WebProcess to create the WebPage. The initial creation state of
the WebPage is communicated to the WebProcess via two routes (firstly an asynchronous
WebProcess::CreateWebPage message, and secondly in the synchronous response from
WebPageProxy::createNewPage). Unfortunately these responses are inconsistent with each
other. The creationParameters() for the page are calculated twice, and since the WKView
will be added to a window between the async message being sent and the synchronous reply
being returned the visibility state of the page can change.
To fix the inconsistency we can set the creation parameters at the point that the
WebPageProxy is instantiated. This will result in a functional change that is web
visible, since the page will initially be opened in a hidden/blurred state, and may
later become visible/focussed. This change is consistent with the direction we want to
evolve in. Whilst we will still probably require a synchronous message from the
WebProcess to the UIProcess on Window.open, we'll probably make this return much earlier
– having just created the WebPageProxy, but avoiding blocking the WebProcess over the
client delegate callback that opens the new window.
This fix results in a layout test result change, due to the change in behavior (page is
created blurred, and becomes focussed, resulting in a focus event being fired – rather
than the window opening directly into a focussed state). This is reported as a
progression (test is broken in WebKit1, fixed in WebKit2 after this change). In reality
the test is actually slightly broken in DRT/test-runner – the test runs differently than
in browser, since there is is no visible main window. In-browser this patch results in
no change in behavior on dom/Window/mozilla-focus-blur.html (the affected test).
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
- call initializeCreationParameters
(WebKit::WebPageProxy::initializeCreationParameters):
- calculate m_creationParameters
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::creationParameters):
- Added m_creationParameters, initializeCreationParameters, creationParameters returns m_creationParameters
LayoutTests:
- platform/mac-wk2/fast/dom/Window: Added.
- platform/mac-wk2/fast/dom/Window/mozilla-focus-blur-expected.txt: Added.
- This test now reports a pass on WebKit2
- 10:41 AM Changeset in webkit [158368] by
-
- 4 edits in trunk/Source/WebCore
Pass an Element by reference to the PseudoElement constructor
https://bugs.webkit.org/show_bug.cgi?id=123576
Reviewed by Andreas Kling.
- dom/Element.cpp:
(WebCore::Element::createPseudoElementIfNeeded):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::PseudoElement):
- dom/PseudoElement.h:
- 10:39 AM Changeset in webkit [158367] by
-
- 2 edits in trunk/Source/WebCore
Fix a mis-merge.
- WebCore.xcodeproj/project.pbxproj: Remove duplicate CryptoAlgorithmRegistryMac.cpp.
- 10:33 AM Changeset in webkit [158366] by
-
- 3 edits4 adds in trunk/Source/WebCore
Add bindings code for crypto algorithm dictionaries
https://bugs.webkit.org/show_bug.cgi?id=123476
Reviewed by Sam Weinig.
JSCryptoAlgorithmDictionary reads the Algorithm, much like JSDictionary does in
simpler cases. We should see about bringing them closer together (perhaps replacing
with autogenerated code).
- crypto/parameters: Added.
- crypto/parameters/CryptoAlgorithmHmacKeyParams.h: Added.
- crypto/parameters/CryptoAlgorithmHmacParams.h: Added.
Added a couple specific dictionaries as an example.
- WebCore.xcodeproj/project.pbxproj: Added JSCryptoAlgorithmDictionary.
- bindings/js/JSCryptoAlgorithmDictionary.cpp: Added.
(WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier):
(WebCore::getHashAlgorithm):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
- bindings/js/JSCryptoAlgorithmDictionary.h: Added.
- 10:26 AM Changeset in webkit [158365] by
-
- 49 edits in trunk/Source/WebCore
Pass ScriptExecutionContext by reference to from the bindings constructors
https://bugs.webkit.org/show_bug.cgi?id=123575
Reviewed by Andreas Kling.
Since we null check the ScriptExecutionContext before creating the c++ class,
we should be passing by reference.
- 10:17 AM Changeset in webkit [158364] by
-
- 2 edits in trunk/Source/WebCore
Paint the input tag of range type on WinCE port.
https://bugs.webkit.org/show_bug.cgi?id=123199
Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-10-31
Reviewed by Brent Fulgham.
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSliderTrack):
(WebCore::RenderThemeWinCE::paintSliderThumb):
- 10:13 AM Changeset in webkit [158363] by
-
- 2 edits7 adds in trunk/Source/WebCore
Add a crypto algorithm abstraction
https://bugs.webkit.org/show_bug.cgi?id=123474
Reviewed by Sam Weinig.
This works slightly differently than WebCrypto implies. We have separate classes
for algorithm and its parameters, while WebCrypto puts them in the same dictionary.
- WebCore.xcodeproj/project.pbxproj: Added new files.
- crypto/CryptoAlgorithm.cpp: Added. As most algorithms don't implement most
operations, default implementations just raise an exception.
- crypto/CryptoAlgorithm.h: Added.
- crypto/CryptoAlgorithmParameters.h: Added. Base class for numerous future parameter
dictionaries, such as HmacParams or HmacKeyParams.
- crypto/CryptoAlgorithmRegistry.cpp: Added.
- crypto/CryptoAlgorithmRegistry.h: Added.
The registry decouples universal bindings code from algorithms that may or may not
be implemented on each platform.
- crypto/mac: Added.
- crypto/mac/CryptoAlgorithmRegistryMac.cpp: Added.
(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms): Algorithms implemented
on Mac will be registered by this function.
- 9:50 AM Changeset in webkit [158362] by
-
- 7 edits in trunk
REGRESSION(r158333): http/tests/xmlhttprequest/response-encoding.html and xmlhttprequest-overridemimetype-content-type-header.html are failing
https://bugs.webkit.org/show_bug.cgi?id=123548
Reviewed by Brady Eidson.
Source/WebCore:
We had code that made sure that cached 200 responses weren't used for conditional
requests. But it didn't work the other way - cached 304 responses got reused for
subsequent unconditional requests!
Adding the test uncovered this bug.
- loader/cache/CachedRawResource.cpp: (WebCore::shouldIgnoreHeaderForCacheReuse):
Should never ignore conditional headers. Code in determineRevalidationPolicy
was already undoing this for conditional requests, but we also shouldn't use
WebCore cache if it holds a 304 response to conditional request.
- loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::determineRevalidationPolicy):
Even though the changed code is only for raw resources, I think that we can never
get a conditional request here any more.
LayoutTests:
- TestExpectations: Unskip tests that used to be affected by response-empty-arraybuffer.html
- http/tests/xmlhttprequest/response-empty-arraybuffer-expected.txt:
- http/tests/xmlhttprequest/response-empty-arraybuffer.html:
Fix a stupid typo. This test actually fully passes.
- 9:28 AM Changeset in webkit [158361] by
-
- 4 edits in trunk/Source/WebCore
CryptoAlgorithmDescriptionBuilder should support producing nested algorithms
https://bugs.webkit.org/show_bug.cgi?id=123461
Reviewed by Darin Adler.
To add a nested algorithm, clone a builder with createEmptyClone(), fill it,
and add it using add().
- bindings/js/JSCryptoAlgorithmBuilder.h:
- crypto/CryptoAlgorithmDescriptionBuilder.h:
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
(WebCore::JSCryptoAlgorithmBuilder::createEmptyClone):
(WebCore::JSCryptoAlgorithmBuilder::add): Keep VM in a local variable for marginally
better performance.
- 8:35 AM Changeset in webkit [158360] by
-
- 12 edits in trunk/Source
[WK2][GTK] enable-media-stream Setting
https://bugs.webkit.org/show_bug.cgi?id=123145
Reviewed by Anders Carlsson.
Source/WebCore:
- page/Settings.in: new mediaStreamEnabled setting.
Source/WebKit2:
- Shared/WebPreferencesStore.h: New MediaStreamEnabled boolean preference.
- UIProcess/API/C/WKPreferences.cpp: MediaStreamEnabled getter and
setter functions.
(WKPreferencesSetMediaStreamEnabled):
(WKPreferencesGetMediaStreamEnabled):
- UIProcess/API/C/WKPreferences.h:
- UIProcess/API/gtk/WebKitSettings.cpp: Add a enable-media-stream
property to the GTK WebKitSettings class. It will act as a facade
to the MediaStreamEnabled preference.
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_media_stream):
(webkit_settings_set_enable_media_stream):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings): Test enable-media-stream websetting.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
Allow WKTR to override the MediaStreamEnabled preference.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Update MediaStreamEnabled
along with the other settings.
- 8:29 AM Changeset in webkit [158359] by
-
- 10 edits in trunk/Source/WebCore
Manage SVGPathByteStream through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123467
Reviewed by Anders Carlsson.
Manage SVGPathByteStream objects through std::unique_ptr. Constructors for the class are made public
so std::make_unique can be used with the class.
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::constructFromString):
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::calculateAnimatedValue):
- svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::createPath):
- svg/SVGAnimatedType.h:
- svg/SVGPathByteStream.h:
(WebCore::SVGPathByteStream::SVGPathByteStream): Takes a const Data object that's then copied.
(WebCore::SVGPathByteStream::copy): Made const.
- svg/SVGPathByteStreamBuilder.cpp: Remove an unnecessary include.
- svg/SVGPathByteStreamBuilder.h: Ditto.
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
- svg/SVGPathElement.h:
- svg/SVGPathUtilities.cpp:
(WebCore::appendSVGPathByteStreamFromSVGPathSeg):
(WebCore::addToSVGPathByteStream):
- 8:29 AM Changeset in webkit [158358] by
-
- 4 edits in trunk/LayoutTests
[EFL] Rebaselining after r158186
https://bugs.webkit.org/show_bug.cgi?id=123571
Unreviewed gardening.
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-10-31
- 7:07 AM Changeset in webkit [158357] by
-
- 2 edits in trunk/Source/WebCore
Removing m_maxDeadCapacity condition in fast path in MemoryCache::prune().
https://bugs.webkit.org/show_bug.cgi?id=115631
Patch by Marcin Bychawski <m.bychawski@samsung.com> on 2013-10-31
Reviewed by Brent Fulgham.
If the m_maxDeadSize and m_deadSize are both 0, the method unnecessairly tries to prune resources.
No new tests, covered by existing ones.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::prune):
- 5:02 AM Changeset in webkit [158356] by
-
- 6 edits in trunk/Source
Web Inspector: Remove stale optional native memory instrumentation protocol params
https://bugs.webkit.org/show_bug.cgi?id=123552
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-10-31
Reviewed by Timothy Hatcher.
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::start):
- inspector/InspectorTimelineAgent.h:
Source/WebInspectorUI:
- UserInterface/InspectorBackendCommands.js:
- 2:14 AM Changeset in webkit [158355] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Undefined references to RenderObject::style() when disabling video support
https://bugs.webkit.org/show_bug.cgi?id=123492
Reviewed by Carlos Garcia Campos.
- platform/gtk/RenderThemeGtk2.cpp: Disabling video support removes indirect inclusion of the RenderElement.h
header, causing undefined references to RenderObject::style(). The RenderElement.h header should be included
instead of RenderObject.h as the former defines the RenderObject::style() inline and also includes the latter.
- platform/gtk/RenderThemeGtk3.cpp: Ditto.
- 1:55 AM Changeset in webkit [158354] by
-
- 1 edit4 adds in trunk/LayoutTests
[EFL] Add baselines for spelling tests added in r157900.
Unreviewed gardening.
- platform/efl/editing/spelling/centering-misspelling-dots-expected.png: Added.
- platform/efl/editing/spelling/centering-misspelling-dots-expected.txt: Added.
- platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.png: Added.
- platform/efl/editing/spelling/misspelling-dots-dont-extend-beyond-words-expected.txt: Added.
- 1:44 AM Changeset in webkit [158353] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Add 5 printing tests to EFL TestExpectations.
EFL port doesn't fully support printing functionality yet.
- platform/efl/TestExpectations:
- 1:38 AM Changeset in webkit [158352] by
-
- 5 edits in trunk
[EFL] accessibility/textbox-role-reports-selection.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112017
Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-10-31
Reviewed by Mario Sanchez Prada.
Source/WebCore:
getSelectionOffsetsForObject() now returns proper start/end offsets for
selections "touching" the object's front border.
No new tests, covered by existing ones.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):
LayoutTests:
Removed failure expectations.
- platform/efl-wk1/TestExpectations: The test is no longer failing.
- platform/efl-wk2/TestExpectations: The test is no longer failing.
- 12:11 AM Changeset in webkit [158351] by
-
- 8 edits in trunk
.: [EFL][GLES] OpenGL should be an optional
https://bugs.webkit.org/show_bug.cgi?id=123399
Reviewed by Noam Rosenthal.
- Source/cmake/OptionsEfl.cmake:
Refactor the check routine of GL dependencies to use OpenGL as optional.
Source/WebCore: [EFL][GLES] OpenGL should be optional
https://bugs.webkit.org/show_bug.cgi?id=123399
Reviewed by Noam Rosenthal.
- CMakeLists.txt: Make OpenGL dependencies as optional.
- PlatformEfl.cmake:
Move OpenGL macro to OptionsEfl.cmake and make Xcomposite and XRender as optional.
- platform/graphics/OpenGLESShims.h:
Removed GL_COLOR_ATTACHMENT0_EXT because it was added to gl2ext.h since r153064
- platform/graphics/surfaces/GraphicsSurfaceToken.h:
Removed wrong GLX guard.
(WebCore::GraphicsSurfaceToken::GraphicsSurfaceToken):
(WebCore::GraphicsSurfaceToken::operator!=):
(WebCore::GraphicsSurfaceToken::isValid):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
Removed unnecessary OpenGLShims.h
