Timeline



Nov 6, 2013:

10:41 PM Changeset in webkit [158826] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

10:39 PM Changeset in webkit [158825] by Lucas Forschler
  • 1 copy in tags/Safari-538.5

New Tag.

10:01 PM Changeset in webkit [158824] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

9:59 PM Changeset in webkit [158823] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.4

New Tag.

9:38 PM Changeset in webkit [158822] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL should support CheckFunction
https://bugs.webkit.org/show_bug.cgi?id=123862

Reviewed by Sam Weinig.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckFunction):

9:26 PM Changeset in webkit [158821] by jer.noble@apple.com
  • 35 edits
    8 copies in trunk/Source/WebCore

[MSE] Add MediaSource extensions to AudioTrack, VideoTrack, and TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=123374

Reviewed by Eric Carlson.

No tests added; tests will be added when Mock implementations are added in a future patch.

Add new partial interfaces for added methods on AudioTrack, TextTrack, and VideoTrack:

  • Modules/mediasource/AudioTrackMediaSource.idl: Add read-only sourceBuffer attribute.
  • Modules/mediasource/TextTrackMediaSource.idl: Ditto.
  • Modules/mediasource/VideoTrackMediaSource.idl: Ditto.
  • Modules/mediasource/AudioTrackMediaSource.h:

(WebCore::AudioTrackMediaSource::sourceBuffer): Added static wrapper around non-static sourceBuffer().

  • Modules/mediasource/TextTrackMediaSource.h:

(WebCore::TextTrackMediaSource::sourceBuffer): Ditto.

  • Modules/mediasource/VideoTrackMediaSource.h:

(WebCore::VideoTrackMediaSource::sourceBuffer): Ditto.

Add support for writable kind & language attributes through a custom setter:

  • bindings/js/JSAudioTrackCustom.cpp:

(WebCore::JSAudioTrack::setKind):
(WebCore::JSAudioTrack::setLanguage):

  • bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrack::setKind):
(WebCore::JSTextTrack::setLanguage):

  • bindings/js/JSVideoTrackCustom.cpp:

(WebCore::JSVideoTrack::setKind):
(WebCore::JSVideoTrack::setLanguage):

  • html/track/AudioTrack.idl:
  • html/track/TextTrack.idl:
  • html/track/VideoTrack.idl:

Add setter methods to the implementation classes:

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setKind):
(WebCore::TextTrack::setLanguage):

  • html/track/TextTrack.h:
  • html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::setKind):
(WebCore::TrackBase::setKindInternal):

  • html/track/TrackBase.h:

(WebCore::TrackBase::setLanguage):
(WebCore::TrackBase::sourceBuffer):
(WebCore::TrackBase::setSourceBuffer):

  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::VideoTrack):
(WebCore::VideoTrack::setKind):
(WebCore::VideoTrack::setLanguage):

  • html/track/VideoTrack.h:

Implement the unimplemented portions of MediaSource and SourceBuffer:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::removeSourceBuffer):

  • Modules/mediasource/MediaSourceBase.cpp:

(WebCore::MediaSourceBase::MediaSourceBase):
(WebCore::MediaSourceBase::setPrivateAndOpen):
(WebCore::MediaSourceBase::setReadyState):
(WebCore::MediaSourceBase::attachToElement):

  • Modules/mediasource/MediaSourceBase.h:

(WebCore::MediaSourceBase::mediaElement):

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::videoTracks):
(WebCore::SourceBuffer::audioTracks):
(WebCore::SourceBuffer::textTracks):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddAudioTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddVideoTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddTextTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidChangeActiveState):

  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediasource/SourceBuffer.idl:

Add new files to the project:

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

And a smorgasbord of other utility changes:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Pass this when attaching.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Ditto.

  • html/HTMLMediaSource.h:
  • html/track/TextTrackList.cpp:

(TextTrackList::item): Make const.

  • html/track/TextTrackList.h:

(WebCore::TextTrackList::lastItem): Added.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::create): Added.
(WebCore::MockSourceBufferPrivate::trackDidChangeEnabled):

9:05 PM Changeset in webkit [158820] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

IC code should handle the call frame register not being the callFrameRegister
https://bugs.webkit.org/show_bug.cgi?id=123865

Reviewed by Geoffrey Garen.

For now, in the FTL, the call frame may be something other than our frame pointer,
since it's an argument passed in according to whatever convention LLVM picks.

This is temporary in two ways - pretty soon the callFrameRegister will be the actual
frame pointer and not some other register, and LLVM will not pass the frame pointer
as an argument to IC's.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdGenerator::JITGetByIdGenerator):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/Repatch.cpp:

(JSC::tryBuildGetByIDList):
(JSC::emitPutTransitionStub):

8:43 PM Changeset in webkit [158819] by mitz@apple.com
  • 2 edits
    1 move in trunk/Source/WebKit2

Moved UIProcess/Cocoa to UIProcess/API/Cocoa.

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/Cocoa: Copied from Source/WebKit2/UIProcess/Cocoa.
  • UIProcess/Cocoa: Removed.
  • UIProcess/Cocoa/WKBackForwardList.h: Removed.
  • UIProcess/Cocoa/WKBackForwardList.mm: Removed.
  • UIProcess/Cocoa/WKBackForwardListInternal.h: Removed.
  • UIProcess/Cocoa/WKBackForwardListItem.h: Removed.
  • UIProcess/Cocoa/WKBackForwardListItem.mm: Removed.
  • UIProcess/Cocoa/WKBackForwardListItemInternal.h: Removed.
  • UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h: Removed.
  • UIProcess/Cocoa/WKNavigationData.h: Removed.
  • UIProcess/Cocoa/WKNavigationData.mm: Removed.
  • UIProcess/Cocoa/WKNavigationDataInternal.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
8:22 PM Changeset in webkit [158818] by akling@apple.com
  • 6 edits
    5 copies
    253 moves
    1 add
    263 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-SVG-1.1

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1"

  • platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Renamed from LayoutTests/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt.
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt.
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt.
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt.
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt.
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt.
  • svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt.
  • svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt.
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt.
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt.
  • svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt.
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt.
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt.
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt.
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt.
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt.
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt.
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt.
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.txt.
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt.
  • svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.txt.
  • svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.txt.
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt.
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt.
  • svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt.
7:53 PM Changeset in webkit [158817] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Gtk][EFL] Fix build after r158759
https://bugs.webkit.org/show_bug.cgi?id=123910

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Gyuyoung Kim.

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::incorporateUpdate): Remove call to flashBackingStoreUpdates().

7:49 PM Changeset in webkit [158816] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Properly null check positionToReveal in ResourceSidebarPanel.prototype.showSourceCode.

https://bugs.webkit.org/show_bug.cgi?id=123921

Reviewed by Joseph Pecoraro.

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):

7:49 PM Changeset in webkit [158815] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Applied background color is not retained after typing a characters
https://bugs.webkit.org/show_bug.cgi?id=117337

Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-11-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

While deleting a selection, only the inheritable style properties
applied on the selection were saved.
Since background color is considered as noninheritable style property,
on deleting the selection, background color set on it was being lost.
Hence on typing in new text, it would not have the applied
background color set.
Fixed by saving editing preoperties that are already in effect
on a selection before deleting it.

Test: editing/style/background-color-retained.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):
Modified as to save EditingPropertiesInEffect on a selection before
deleting it.

LayoutTests:

  • editing/style/background-color-retained-expected.txt: Added.
  • editing/style/background-color-retained.html: Added.

Test to make sure that background color applied on a
selection is retained after deleting the selection.

7:49 PM Changeset in webkit [158814] by rniwa@webkit.org
  • 5 edits
    1 add in trunk/Websites/test-results

New flakiness dashboard should generate JSON in the background process
https://bugs.webkit.org/show_bug.cgi?id=123797

Reviewed by Alexey Proskuryakov.

  • config.json: Add defaultBuildWaitInterval used by process-builds.php.
  • init-database.sql: Add is_process column to builds table so that we can track of "unprocessed" builds.
  • public/admin/process-builds.php: Added.

(process_latest_five_builds): Update flakiness states and generate JSONs for the latest five builds.
We go backwards in the time so that we don't end up infinite looping over a single build that fails.
(main): Call processed_builds with an exponential back off.

  • public/api/report.php:

(store_results): No need to return build or builder ids.
(main): Don't update flakiness states or generate JSONs.

  • public/include/test-results.php:

(add_build): Take the slave name; it doesn't make any sense to create a build without it and later
updating it in store_test_results.
(store_test_results): Once new test results are added, explicitly mark this build as unprocessed.

7:39 PM Changeset in webkit [158813] by akling@apple.com
  • 1 edit
    40 moves
    42 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-I18N

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-I18N"

  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
  • svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt.
  • svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt.
  • svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt.
  • svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-no-markup-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt.
  • svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt.
  • svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt.
  • svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-direction-ltr-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt.
  • svg/W3C-I18N/tspan-direction-rtl-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt.
7:32 PM Changeset in webkit [158812] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

InlineBox: Make paint() and nodeAtPoint() pure virtuals.
<https://webkit.org/b/123937>

...and move the current implementations to InlineElementBox.
All subclasses were already overriding these functions so the move
is completely natural.

Reviewed by Anders Carlsson.

7:30 PM Changeset in webkit [158811] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Nothing should return std::unique_ptr<InlineBox>.
<https://webkit.org/b/123936>

Made RenderBox, RenderLineBreak and RenderListMarker return tightly
typed InlineElementBoxes instead.

Reviewed by Anders Carlsson.

7:26 PM Changeset in webkit [158810] by akling@apple.com
  • 4 edits
    3 copies
    24 moves
    2 adds
    28 deletes in trunk/LayoutTests

Optimize baselines: accessibility

Unreviewed; run "webkit-patch optimize-baselines accessibility"

  • accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt.
  • accessibility/aria-combobox-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-combobox-expected.txt.
  • accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-fallback-roles-expected.txt.
  • accessibility/aria-labelledby-overrides-aria-label-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt.
  • accessibility/aria-menubar-menuitems-expected.txt:
  • accessibility/aria-option-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-option-role-expected.txt.
  • accessibility/aria-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-roles-expected.txt.
  • accessibility/aria-tab-role-on-buttons-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tab-role-on-buttons-expected.txt.
  • accessibility/aria-tables-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tables-expected.txt.
  • accessibility/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-toggle-button-with-title-expected.txt.
  • accessibility/canvas-description-and-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/canvas-description-and-role-expected.txt.
  • accessibility/canvas-fallback-content-expected.txt:
  • accessibility/deleting-iframe-destroys-axcache-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt.
  • accessibility/div-within-anchors-causes-crash-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt.
  • accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt.
  • accessibility/img-alt-tag-only-whitespace-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt.
  • accessibility/notification-listeners-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/notification-listeners-expected.txt.
  • accessibility/paragraph-with-linebreaks-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt.
  • accessibility/svg-image-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/svg-image-expected.txt.
  • accessibility/svg-remote-element-expected.txt:
  • platform/efl-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-attributes-expected.txt.
  • platform/efl-wk1/accessibility/table-detection-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-detection-expected.txt.
  • platform/efl-wk1/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-one-cell-expected.txt.
  • platform/efl-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-sections-expected.txt.
  • platform/efl-wk1/accessibility/table-with-rules-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt.
  • platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Removed.
  • platform/efl/accessibility/canvas-fallback-content-expected.txt: Removed.
  • platform/efl/accessibility/svg-remote-element-expected.txt: Removed.
  • platform/gtk-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt.
  • platform/gtk-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-sections-expected.txt.
  • platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Removed.
  • platform/gtk/accessibility/aria-combobox-expected.txt: Removed.
  • platform/gtk/accessibility/aria-fallback-roles-expected.txt: Removed.
  • platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
  • platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Removed.
  • platform/gtk/accessibility/aria-option-role-expected.txt: Removed.
  • platform/gtk/accessibility/aria-roles-expected.txt: Removed.
  • platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Removed.
  • platform/gtk/accessibility/aria-tables-expected.txt: Removed.
  • platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
  • platform/gtk/accessibility/canvas-description-and-role-expected.txt: Removed.
  • platform/gtk/accessibility/canvas-fallback-content-expected.txt: Removed.
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Removed.
  • platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Removed.
  • platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Removed.
  • platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
  • platform/gtk/accessibility/notification-listeners-expected.txt: Removed.
  • platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Removed.
  • platform/gtk/accessibility/svg-image-expected.txt: Removed.
  • platform/gtk/accessibility/svg-remote-element-expected.txt: Removed.
  • platform/mac/accessibility/aria-fallback-roles-expected.txt: Removed.
  • platform/mac/accessibility/aria-menubar-menuitems-expected.txt: Copied from LayoutTests/accessibility/aria-menubar-menuitems-expected.txt.
  • platform/mac/accessibility/aria-roles-expected.txt: Removed.
  • platform/mac/accessibility/aria-tables-expected.txt: Removed.
  • platform/mac/accessibility/canvas-fallback-content-expected.txt: Copied from LayoutTests/accessibility/canvas-fallback-content-expected.txt.
  • platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
  • platform/mac/accessibility/svg-image-expected.txt: Removed.
  • platform/win-future/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/accessibility/svg-remote-element-expected.txt.
6:47 PM Changeset in webkit [158809] by akling@apple.com
  • 6 edits
    6 copies
    7 moves
    11 adds
    18 deletes in trunk/LayoutTests

Optimize baselines: media

Unreviewed; run "webkit-patch optimize-baselines media"

  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
  • media/media-can-play-webm-expected.txt: Renamed from LayoutTests/platform/efl/media/media-can-play-webm-expected.txt.
  • media/video-controls-visible-audio-only-expected.txt: Renamed from LayoutTests/platform/efl/media/video-controls-visible-audio-only-expected.txt.
  • platform/efl-wk2/media/video-layer-crash-expected.png: Renamed from LayoutTests/platform/efl/media/video-layer-crash-expected.png.
  • platform/efl-wk2/media/video-transformed-expected.png: Renamed from LayoutTests/platform/efl/media/video-transformed-expected.png.
  • platform/efl-wk2/media/video-zoom-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-expected.png.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
  • platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
  • platform/gtk/media/media-can-play-webm-expected.txt: Removed.
  • platform/gtk/media/video-controls-visible-audio-only-expected.txt: Removed.
  • platform/mac/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Copied from LayoutTests/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt.
  • platform/mac/media/video-controls-visible-audio-only-expected.txt: Removed.
  • platform/win-7sp0/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
  • platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
  • platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
  • platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
  • platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
  • platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
  • platform/win/media/media-can-play-ogg-expected.txt: Removed.
  • platform/win/media/video-colorspace-yuv420-expected.txt: Removed.
  • platform/win/media/video-colorspace-yuv422-expected.txt: Removed.
  • platform/win/media/video-size-intrinsic-scale-expected.txt: Removed.
6:02 PM Changeset in webkit [158808] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Remote Layer Tree: RemoteLayerTreeDrawingArea doesn't make layers for fixedpos elements
https://bugs.webkit.org/show_bug.cgi?id=123943

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Make fixed position elements create compositing layers and stacking contexts
in the RemoteLayerTreeDrawingArea just like they do in TiledCoreAnimationDrawingArea.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
Fix the comment, since we have long since achieved this goal.

5:41 PM Changeset in webkit [158807] by dino@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

kTraceBufferLen is unused in default builds
https://bugs.webkit.org/show_bug.cgi?id=123941
<rdar://problem/15409804>

Reviewed by Tim Horton.

kTraceBufferLen is not used in debug.cpp if TRACE_ENABLED is
not defined. This causes a warning in newer builds of clang.
For now, skip warnings on unused variables until we
update from ANGLE.

  • src/compiler/debug.cpp: Add unused-variable ignore pragma.
5:20 PM Changeset in webkit [158806] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Implement enough functionality so that NSURLRequest objects can be decoded
https://bugs.webkit.org/show_bug.cgi?id=123942

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectEncoder requiresSecureCoding]):
Add new method. Return YES.

(-[WKRemoteObjectDecoder decodeValueOfObjCType:at:]):
Add new method. This currently only handles 'i', but we'll add more variants as needed.

(-[WKRemoteObjectDecoder decodeBoolForKey:]):
Get a WebBoolean from the dictionary and return its value.

5:12 PM Changeset in webkit [158805] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Encoded object stream should be sequential
https://bugs.webkit.org/show_bug.cgi?id=123939

Reviewed by Andreas Kling.

Reserve space in the object stream for objects that are to be encoded, otherwise
the object stream will not be sequential.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeToObjectStream):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::entries):

4:48 PM Changeset in webkit [158804] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Allow property list classes to exist in containers
https://bugs.webkit.org/show_bug.cgi?id=123938

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(isContainerClass):
Return whether a given class is a container class.

(propertyListClasses):
Return the set of property list classes.

(allowedArgumentClassesForMethod):
Allow all property list classes for container type arguments.

4:39 PM Changeset in webkit [158803] by dbates@webkit.org
  • 20 edits
    5 adds in trunk

[iOS] Upstream Letterpress effect
https://bugs.webkit.org/show_bug.cgi?id=123932

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Test: platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html

  • Configurations/FeatureDefines.xcconfig: Add feature define ENABLE_LETTERPRESS disabled

by default. We only enable letterpress on iOS.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationFlagsToCSSValue): Add support for CSS value -webkit-letterpress.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTextDecoration): Ditto.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator TextDecoration): Ditto.

  • css/CSSValueKeywords.in: Added CSS value -webkit-letterpress.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/mac/FontMac.mm:

(WebCore::fillVectorWithHorizontalGlyphPositions): Added.
(WebCore::shouldUseLetterpressEffect): Added.
(WebCore::showLetterpressedGlyphsWithAdvances): Added.
(WebCore::showGlyphsWithAdvances): Modified to call showLetterpressedGlyphsWithAdvances()
to show a letterpressed glyph. I also included additional iOS-specific changes.
(WebCore::Font::drawGlyphs):

  • rendering/TextPaintStyle.cpp:

(WebCore::TextPaintStyle::TextPaintStyle):
(WebCore::computeTextPaintStyle): Modified to compute letterpress effect style.
(WebCore::updateGraphicsContext): Modified to apply/unapply letterpress effect drawing mode.

  • rendering/TextPaintStyle.h:
  • rendering/style/RenderStyleConstants.h:

Source/WebKit/mac:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • wtf/FeatureDefines.h:

LayoutTests:

  • platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress-expected.txt: Added.
  • platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html: Added.
  • platform/iphone-simulator/iphone/resources/getComputedStyle-text-decoration-letterpress.js: Added.
4:20 PM Changeset in webkit [158802] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Crash in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873

Reviewed by Sam Weinig.

Moved Ref.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::dragFrom):

4:04 PM Changeset in webkit [158801] by eric.carlson@apple.com
  • 5 edits
    1 add in trunk/LayoutTests

LayoutTests/media/track/track-forced-subtitles-in-band.html always times out
https://bugs.webkit.org/show_bug.cgi?id=123412

Reviewed by Jer Noble.

  • media/content/CC+Subtitles.mov: Added.
  • media/track/track-forced-subtitles-in-band.html: Fail loudly if the caption track menu is

not found by the helper function. Wait for both 'seeked' and 'cuechange' events before
checking activeCues.

  • media/trackmenu-test.js:

(getTrackListElement): Correct the caption menu pseudo-id.
(trackMenuList): Complain when the track menu is not found.

  • platform/mac/TestExpectations: Remove track-forced-subtitles-in-band.html.
4:00 PM Changeset in webkit [158800] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleanup FontMac.mm
https://bugs.webkit.org/show_bug.cgi?id=123928

Reviewed by Andy Estes.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Inline the value of variable isVertical as we
reference it exactly once and its value is sufficiently clear.
(WebCore::Font::drawGlyphs): Remove default case in switch block so that the compiler
checks that all cases are covered. Move definition of platformData to the top of the
function and use it whenever we want to access the platform font data

3:53 PM Changeset in webkit [158799] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed multiple API test failures after r158764.

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(setUpPagePolicyClient): If the delegate isn’t set or doesn’t respond to a selector, respond
with WKFramePolicyListenerUse().

3:08 PM Changeset in webkit [158798] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

[WebGL] We should not allow generateMipMap on compressed textures
https://bugs.webkit.org/show_bug.cgi?id=123915
<rdar://problem/15201274>

Reviewed by Dean Jackson.

Found by existing conformance/extensions/webgl-compressed-texture-s3tc.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::compressedTexImage2D): Set compressed flag.
(WebCore::WebGLRenderingContext::compressedTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::generateMipmap): For Apple builds, check state
of compressed flag and generate appropriate WebGL error if necessary.

  • html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture): Set compressed flag to false by default
(WebCore::WebGLTexture::isCompressed): Added
(WebCore::WebGLTexture::setCompressed): Added

  • html/canvas/WebGLTexture.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::generateMipmap): Switch implementation to use proper
glGenerateMipmaps, rather than the glGenerateMipmapsEXT method.

3:04 PM Changeset in webkit [158797] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Move allowed classes handling to decodeObject
https://bugs.webkit.org/show_bug.cgi?id=123930

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(decodeObjectFromObjectStream):
Pass allowed classes through to decodeObject.

(decodeObject):
Update to take an NSSet of allowed classes. If the set is nil, use the current set.

(-[WKRemoteObjectDecoder decodeObjectOfClasses:forKey:]):
Pass classes to decodeObject.

2:44 PM Changeset in webkit [158796] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Changes to CodeGeneratorInspectorStrings.py should rebuild inspector generated files
https://bugs.webkit.org/show_bug.cgi?id=123925

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-06
Reviewed by Timothy Hatcher.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
2:40 PM Changeset in webkit [158795] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged rr157966. <rdar://problem/15406689>

2:37 PM Changeset in webkit [158794] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r156675. <rdar://problem/15406691>

2:37 PM Changeset in webkit [158793] by oliver@apple.com
  • 14 edits
    9 adds in trunk

Support iteration of the Arguments object
https://bugs.webkit.org/show_bug.cgi?id=123835

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add an ArgumentsIterator object, and associated classes so that we can support
iteration of the arguments object.

This is a largely mechanical patch. The only gnarliness is in the
logic to avoid reifying the Arguments object in for(... of arguments)
scenarios.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnumeration):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::argumentsFuncIterator):

  • runtime/Arguments.h:
  • runtime/ArgumentsIteratorConstructor.cpp: Added.

(JSC::ArgumentsIteratorConstructor::finishCreation):

  • runtime/ArgumentsIteratorConstructor.h: Added.

(JSC::ArgumentsIteratorConstructor::create):
(JSC::ArgumentsIteratorConstructor::createStructure):
(JSC::ArgumentsIteratorConstructor::ArgumentsIteratorConstructor):

  • runtime/ArgumentsIteratorPrototype.cpp: Added.

(JSC::ArgumentsIteratorPrototype::finishCreation):
(JSC::argumentsIteratorPrototypeFuncIterator):
(JSC::argumentsIteratorPrototypeFuncNext):

  • runtime/ArgumentsIteratorPrototype.h: Added.

(JSC::ArgumentsIteratorPrototype::create):
(JSC::ArgumentsIteratorPrototype::createStructure):
(JSC::ArgumentsIteratorPrototype::ArgumentsIteratorPrototype):

  • runtime/CommonIdentifiers.h:
  • runtime/JSArgumentsIterator.cpp: Added.

(JSC::JSArgumentsIterator::finishCreation):

  • runtime/JSArgumentsIterator.h: Added.

(JSC::JSArgumentsIterator::createStructure):
(JSC::JSArgumentsIterator::create):
(JSC::JSArgumentsIterator::next):
(JSC::JSArgumentsIterator::JSArgumentsIterator):

  • runtime/JSArrayIterator.cpp:

(JSC::createIteratorResult):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:

LayoutTests:

Add test cases

  • js/arguments-iterator-expected.txt: Added.
  • js/arguments-iterator.html: Added.
  • js/script-tests/arguments-iterator.js: Added.

(shouldThrow.test):
(testAlias):
(testStrict):
(testReifiedArguments):
(testOverwrittenArguments):
(testNullArguments):
(testNonArrayLikeArguments):

2:37 PM Changeset in webkit [158792] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix EFL build after r158753
https://bugs.webkit.org/show_bug.cgi?id=123923

r158753 renamed WKNavigationData.h as WKNavigationDataRef.h, so
update it in UIProcess/API/efl/ewk_navigation_data_private.h.

Patch by Sergio Correia <Sergio Correia> on 2013-11-06
Reviewed by Csaba Osztrogonác.

  • UIProcess/API/efl/ewk_navigation_data_private.h:
2:31 PM Changeset in webkit [158791] by Lucas Forschler
  • 4 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r154550. <rdar://problem/15406685>

2:29 PM Changeset in webkit [158790] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix the display of query parameters when the value is missing.

https://bugs.webkit.org/show_bug.cgi?id=123920

Reviewed by Joseph Pecoraro.

  • UserInterface/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._createNameValueDataGrid):

2:27 PM Changeset in webkit [158789] by Lucas Forschler
  • 1 edit in branches/safari-537.73-branch/Source/WebInspectorUI/UserInterface/External/CodeMirror/codemirror.js

Merge patch for <rdar://problem/15406685>.

2:08 PM Changeset in webkit [158788] by Alexandru Chiculita
  • 8 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: CSS Regions: When a flow is clicked the content of flow needs to be displayed
https://bugs.webkit.org/show_bug.cgi?id=122927

Reviewed by Joseph Pecoraro.

ContentFlowTreeContentView is now used to display the content nodes of a ContentFlow. It is
very similar to the DOMTreeContentView class, but can handle multiple root nodes.

  • UserInterface/ContentFlowTreeContentView.js: Added.

(WebInspector.ContentFlowTreeContentView):
(WebInspector.ContentFlowTreeContentView.prototype.get selectionPathComponents):
(WebInspector.ContentFlowTreeContentView.prototype.updateLayout):
(WebInspector.ContentFlowTreeContentView.prototype.shown):
(WebInspector.ContentFlowTreeContentView.prototype.hidden):
(WebInspector.ContentFlowTreeContentView.prototype.closed):
(WebInspector.ContentFlowTreeContentView.prototype._selectedNodeDidChange):
(WebInspector.ContentFlowTreeContentView.prototype._pathComponentSelected):
(WebInspector.ContentFlowTreeContentView.prototype._createContentNodeTree):
(WebInspector.ContentFlowTreeContentView.prototype._createContentTrees):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasAdded):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasRemoved):

  • UserInterface/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):

  • UserInterface/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype.ondeselect): We need to remove the selected "dom node"
so that the element is not going to stay selected after the we move to a different DOM tree.

  • UserInterface/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype.selectDOMNode):

  • UserInterface/Main.html:
  • UserInterface/Main.js:

(WebInspector.sidebarPanelForRepresentedObject):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):

2:04 PM Changeset in webkit [158787] by Lucas Forschler
  • 17 edits
    4 copies in branches/safari-537.73-branch

Merged r158617. <rdar://problem/15391030>

1:57 PM Changeset in webkit [158786] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix test case

1:54 PM Changeset in webkit [158785] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove the flaky test expectation after r158720 now that the test is not flaky.

  • platform/mac/TestExpectations:
1:52 PM Changeset in webkit [158784] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Implement more decoding methods
https://bugs.webkit.org/show_bug.cgi?id=123922

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder decodeObjectForKey:]):
Call decodeObjectOfClasses:forKey: passing nil as the classes set.

(-[WKRemoteObjectDecoder decodeInt64ForKey:]):
Try to get a WebUInt64 and return its value.

(-[WKRemoteObjectDecoder decodeDoubleForKey:]):
Try to get a WebDouble and return its value.

(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
Move this method next to the other decoding methods.

(-[WKRemoteObjectDecoder requiresSecureCoding]):
Ditto.

1:39 PM Changeset in webkit [158783] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Disable "unused local typedefs" warning for GCC 4.7
https://bugs.webkit.org/show_bug.cgi?id=123913

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-06
Reviewed by Martin Robinson.

That warning was actually introduced in gcc 4.7.0.
See: http://gcc.gnu.org/gcc-4.7/changes.html

  • wtf/Compiler.h:
1:31 PM Changeset in webkit [158782] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Gtk][EFL] Fix build after r158759
https://bugs.webkit.org/show_bug.cgi?id=123910

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/PageClientImpl.cpp: Remove flashBackingStoreUpdates().
  • UIProcess/API/gtk/PageClientImpl.h: Same.
  • UIProcess/CoordinatedGraphics/WebView.cpp: Same.
  • UIProcess/CoordinatedGraphics/WebView.h: Same.
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Don't call flashBackingStoreUpdates().

1:21 PM Changeset in webkit [158781] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed Mac build fix; include ResourceResponse.

  • Shared/WebNavigationDataStore.h:
1:17 PM Changeset in webkit [158780] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Decode invocation arguments
https://bugs.webkit.org/show_bug.cgi?id=123917

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
Initialize the object stream.

(decodeObjectFromObjectStream):
Check that we're not reading past the end of the stream, then decode the object.

(decodeInvocationArguments):
Decode arguments from the object stream.

(decodeInvocation):
Call decodeInvocationArguments and set up the selector argument.

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):
(WebKit::ImmutableArray::entries):
Constify.

12:56 PM Changeset in webkit [158779] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

[Cocoa] Add -[WKNavigationData response]
https://bugs.webkit.org/show_bug.cgi?id=123918

Reviewed by Sam Weinig.

  • Shared/WebNavigationDataStore.h: Added a ResourceResponse data member.

(WebKit::WebNavigationDataStore::encode): Encode the response.
(WebKit::WebNavigationDataStore::decode): Decode the response.

  • UIProcess/Cocoa/WKNavigationData.h: Declared new property.
  • UIProcess/Cocoa/WKNavigationData.mm:

(-[WKNavigationData response]): Added.

  • UIProcess/WebNavigationData.h:

(WebKit::WebNavigationData::response): Added.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory): Set the response in the data store.

12:49 PM Changeset in webkit [158778] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r158629. <rdar://problem/15391028>

12:49 PM Changeset in webkit [158777] by Bem Jones-Bey
  • 4 edits in trunk/Source/WebCore

Rename region line offset methods
https://bugs.webkit.org/show_bug.cgi?id=123897

Reviewed by Sam Weinig.

Because of the large number of overloads on the line offset methods,
it is very hard to read code using them, which also makes it harder to
move them out of RenderBlock. This patch renames the methods that take
a region as an argument to make it clearer when looking at the code
how the differ from the ones that don't.

No new tests, no behavior change.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLineInRegion):
(WebCore::RenderBlock::logicalRightOffsetForLineInRegion):
(WebCore::RenderBlock::logicalLeftOffsetForLineInRegion):
(WebCore::RenderBlock::startOffsetForLineInRegion):
(WebCore::RenderBlock::endOffsetForLineInRegion):
(WebCore::RenderBlock::availableLogicalWidthForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):

12:49 PM Changeset in webkit [158776] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix the 32-bit build.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):

12:48 PM Changeset in webkit [158775] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

[Cocoa] Add -[WKBrowsingContextController unreachableURL]
https://bugs.webkit.org/show_bug.cgi?id=123909

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.h: Declared unreachableURL property.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::unreachableURL): Added.

  • UIProcess/WebPageProxy.h:
12:38 PM Changeset in webkit [158774] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

HTMLCollection should use CollectionIndexCache
https://bugs.webkit.org/show_bug.cgi?id=123906

Reviewed by Ryosuke Niwa.

More code sharing.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • dom/ChildNodeList.h:
  • dom/CollectionIndexCache.h:

(WebCore::::nodeBeforeCached):
(WebCore::::nodeAfterCached):
(WebCore::::nodeAt):

Add a mechanism for disabling use of backward traversal.

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::collectionCanTraverseBackward):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::iterateForPreviousElement):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::nameShouldBeVisibleInDocumentAll):
(WebCore::firstMatchingChildElement):
(WebCore::nextMatchingSiblingElement):
(WebCore::HTMLCollection::firstElement):
(WebCore::HTMLCollection::traverseForward):
(WebCore::HTMLCollection::collectionFirst):
(WebCore::HTMLCollection::collectionLast):
(WebCore::HTMLCollection::collectionTraverseForward):
(WebCore::HTMLCollection::collectionTraverseBackward):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::collectionCanTraverseBackward):

Disable use of backward traversal for collections that use custom traversal.

12:32 PM Changeset in webkit [158773] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG CheckArray(NonArray) should prove that the child isn't an array
https://bugs.webkit.org/show_bug.cgi?id=123911
<rdar://problem/15202803>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::isArrayType):

LayoutTests:

  • js/dfg-check-array-non-array-expected.txt: Added.
  • js/dfg-check-array-non-array.html: Added.
  • js/script-tests/dfg-check-array-non-array.js: Added.

(foo):
(bar):
(baz):

12:31 PM Changeset in webkit [158772] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode parameters as objects
https://bugs.webkit.org/show_bug.cgi?id=123912

Reviewed by Beth Dakin.

We want to ensure that the objects have the right types when decoded, so just encode them as objects.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation):
(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):

12:27 PM Changeset in webkit [158771] by Lucas Forschler
  • 6 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r154763. <rdar://problem/15401612>

12:23 PM Changeset in webkit [158770] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/LayoutTests

Merged r158766. <rdar://problem/15390971>

12:22 PM Changeset in webkit [158769] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155997. <rdar://problem/15390971>

12:20 PM Changeset in webkit [158768] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/WebKitLibraries

Merged r155996. <rdar://problem/15390971>

12:16 PM Changeset in webkit [158767] by jer.noble@apple.com
  • 2 edits in trunk/Tools

Unreviewed webkitpy unit test fix; update baselines after r158765

  • Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_baseline_search_path):

12:10 PM Changeset in webkit [158766] by Lucas Forschler
  • 2 edits in branches/safari-537.60-branch/LayoutTests

Merged r154392. <rdar://problem/15390971>

11:53 AM Changeset in webkit [158765] by jer.noble@apple.com
  • 2 edits in trunk/Tools

[Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
https://bugs.webkit.org/show_bug.cgi?id=123905

Reviewed by Brent Fulgham.

Now that the mac-lion results have been removed, the win port should fall back to
the mac-mountainlion results.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_baseline_search_path):

11:42 AM Changeset in webkit [158764] by weinig@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Add WKBrowsingContextPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=123904

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

Implement a WKPagePolicyClient in terms of the new WKBrowsingContextPolicyDelegate protocol.

  • UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:

Added.

  • UIProcess/API/mac/WebKit2.h:

Add new #include of WKBrowsingContextPolicyDelegate.h

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

11:23 AM Changeset in webkit [158763] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

WKRemoteObjectInterface should keep track of allowed decodable classes
https://bugs.webkit.org/show_bug.cgi?id=123903

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(allowedArgumentClassesForMethod):
Helper function that returns a vector of sets of allowed classes for each method argument.

(initializeAllowedArgumentClasses):
Iterate over the methods in the protocol, get the extended method type encoding and create an
NSMethodSignature from it. Finally, pass the signature to allowedArgumentClassesForMethod.

(initializeAllowedArgumentClasses):
Call the other initializeAllowedArgumentClasses twice, once for required methods,
and once for optional methods.

(-[WKRemoteObjectInterface initWithProtocol:identifier:]):
Call initializeAllowedArgumentClasses.

(-[WKRemoteObjectInterface _allowedArgumentClassesForSelector:]):
Add new getter.

  • Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h:
11:21 AM Changeset in webkit [158762] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSExport doesn't support constructors
https://bugs.webkit.org/show_bug.cgi?id=123380

Reviewed by Geoffrey Garen.

Needed another linked-on-or-after check for when we're deciding whether
we should copy over init family methods.

Factored out the link time checks into a separate function so that they can be cached.

Factored out the check for init-family method selectors into helper function and changed it to
match the description in the clang docs, namely that there can be underscores at the beginning
and the first letter after 'init' part of the selector (if there is one) must be a capital letter.

Updated tests to make sure we don't treat "initialize" as an init-family method and that we do
treat "_init" as an init-family method.

  • API/JSWrapperMap.h:
  • API/JSWrapperMap.mm:

(isInitFamilyMethod):
(shouldSkipMethodWithName):
(copyMethodsToObject):
(allocateConstructorForCustomClass):
(supportsInitMethodConstructors):

  • API/tests/testapi.mm:

(-[ClassA initialize]):
(-[ClassD initialize]):

11:01 AM Changeset in webkit [158761] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix a Mountain Lion test failure.

NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:

(TestWebKitAPI::TEST):

10:54 AM WebInspector edited by timothy@apple.com
(diff)
10:53 AM Changeset in webkit [158760] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

Add "id" attribute to TextTrack
https://bugs.webkit.org/show_bug.cgi?id=123825

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-id.html

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::addTextTrack): Add emptyString() for track id.

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::AudioTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::AudioTrack::idChanged): Added, set id.

  • html/track/AudioTrack.h: Move m_id to TrackBase.
  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::InbandTextTrack::idChanged): Added, set id.

  • html/track/InbandTextTrack.h: Add idChanged().
  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Add emptyString() for track id.
(WebCore::LoadableTextTrack::id): Override to return the track element's id.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::captionMenuOffItem): Add empty string for track id.
(WebCore::TextTrack::captionMenuAutomaticItem): Add empty string for track id.
(WebCore::TextTrack::TextTrack): Pass id to TrackBase.

  • html/track/TextTrack.h:

(WebCore::TextTrack::create): Add id parameter.

  • html/track/TextTrack.idl: Add id attribute.
  • html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase): Add m_id.

  • html/track/TrackBase.h: Add id attribute / m_id.
  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::VideoTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::VideoTrack::idChanged): Added, set id.

  • html/track/VideoTrack.h: Move m_id to TrackBase.
  • platform/graphics/TrackPrivateBase.h: Add idChanged() callback.

LayoutTests:

  • media/track/track-id-expected.txt: Added.
  • media/track/track-id.html: Added.
10:51 AM Changeset in webkit [158759] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=123902

Reviewed by Tim Horton.

Remove the PageClient::containingWindowGraphicsContext() as well as the
WKPageSetDebugPaintFlags and WKPageGetDebugPaintFlags API functions.

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::searchTheWeb):

10:18 AM Changeset in webkit [158758] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Move array position caching out from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=123895

Reviewed by Darin Adler.

This caching complicates the logic but is used by a single subclass
(HTMLFormControlsCollection) only. The subclass can do the caching itself.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::elementBeforeOrAfterCachedElement):
(WebCore::HTMLCollection::firstElement):

Renamed from traverseFirstElement.

(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::invalidateCache):

Make cache invalidation virtual so we can clear HTMLTableRowsCollection index cache.

(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):

Use traverseForwardToOffset instead traverseNextElement. This allows removal of traverseNextElement.

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::usesCustomForwardOnlyTraversal):

Renamed the enum and the accessor to be more informative.

(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::customElementAfter):

Renamed from virtualItemAfter.

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::findFormAssociatedElement):
(WebCore::HTMLFormControlsCollection::customElementAfter):

Move the array position caching logic here.

(WebCore::HTMLFormControlsCollection::invalidateCache):

  • html/HTMLFormControlsCollection.h:
  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::customElementAfter):

  • html/HTMLTableRowsCollection.h:
10:17 AM Changeset in webkit [158757] by Michał Pakuła vel Rutka
  • 6 edits in trunk

[ATK] accessibility/title-ui-element-correctness.html fails
https://bugs.webkit.org/show_bug.cgi?id=99825

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When calling setAtkRelationSetFromCoreObject a new ATK_LABELLED_BY_RELATION
is added, adding proper label element as a relation. When the document structure
has been changed and a different label should be linked as a relation, current ATK
implementation adds it as a next target on relation's target list, while
WTR/DumpRenderTree implementation takes only first one into account.
This patch adds a new function removing current relations before adding new ones.

Covered by existing tests.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(removeAtkRelationFromRelationSetByType):
(setAtkRelationSetFromCoreObject):

LayoutTests:

Remove failure test expectation for the test fixed by this patch.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
10:12 AM Changeset in webkit [158756] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Promoted WKBrowsingContextHistoryDelegate.h to private.

Rubber-stamped by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
10:00 AM WebInspectorCodingStyleGuide edited by Joseph Pecoraro
(diff)
9:57 AM WebInspectorCodingStyleGuide edited by Alexandru Chiculita
(diff)
9:56 AM WebInspectorCodingStyleGuide created by Alexandru Chiculita
9:43 AM Changeset in webkit [158755] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Media elements wrongly exposed after r158743.

  • platform/gtk/TestExpectations: Added failure expectations.
9:39 AM Changeset in webkit [158754] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk/LayoutTests

[ATK] Providing new table related accessibility expectations after r158742
https://bugs.webkit.org/show_bug.cgi?id=123893

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Chris Fleizach.

New baselines after added missing implementation in r158742.

  • platform/efl-wk1/TestExpectations: Tests are no longer failing.
  • platform/efl-wk2/TestExpectations: Tests are no longer failing.
  • platform/efl-wk2/accessibility/table-attributes-expected.txt: Added.
  • platform/efl-wk2/accessibility/table-sections-expected.txt: Added.
  • platform/efl/accessibility/table-attributes-expected.txt: Added.
  • platform/efl/accessibility/table-sections-expected.txt: Added.
  • platform/gtk-wk2/accessibility/table-attributes-expected.txt: Added.
  • platform/gtk-wk2/accessibility/table-sections-expected.txt: Added.
  • platform/gtk/TestExpectations: Tests are no longer failing.
  • platform/gtk/accessibility/table-attributes-expected.txt: Added.
  • platform/gtk/accessibility/table-sections-expected.txt: Added.
9:36 AM Changeset in webkit [158753] by mitz@apple.com
  • 10 edits
    2 moves
    4 adds in trunk/Source/WebKit2

[Cocoa] History delegate
https://bugs.webkit.org/show_bug.cgi?id=123837

Reviewed by Sam Weinig.

  • Shared/Cocoa/APIObject.mm:

(WebKit::APIObject::newObject): Allocate a WKNavigationData if the object is a
WebNavigationData.

  • Shared/Cocoa/WKNSString.h:

(WebKit::wrapper): Added. Returns a WebString’s wrapper as an NSString.

  • Shared/Cocoa/WKNSURL.h:

(WebKit::wrapper): Added. Returns a WebURL’s wrapper as an NSURL.

  • UIProcess/API/C/WKNavigationData.cpp: Renamed.
  • UIProcess/API/C/WKNavigationData.h: Renamed.
  • UIProcess/API/C/WKNavigationDataRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp.
  • UIProcess/API/C/WKNavigationDataRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.h.
  • UIProcess/API/mac/WKBrowsingContextController.h: Declared historyDelegate property.
  • UIProcess/API/mac/WKProcessGroup.mm:

(didNavigateWithNavigationData): Added history client callback that calls the browsing
context’s history delegate.
(didPerformClientRedirect): Ditto.
(didPerformServerRedirect): Ditto.
(didUpdateHistoryTitle): Ditto.
(setUpHistoryClient): Added.
(-[WKProcessGroup initWithInjectedBundleURL:]): Added call to setUpHistoryClient.
(-[WKProcessGroup dealloc]): Clear the history client.

  • UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h: Added.
  • UIProcess/Cocoa/WKNavigationData.h: Added.
  • UIProcess/Cocoa/WKNavigationData.mm: Added.

(-[WKNavigationData dealloc]): Calls the WebNavigationData destructor.
(-[WKNavigationData title]): Added.
(-[WKNavigationData originalRequest]): Added.
(-[WKNavigationData destinationURL]): Added.
(-[WKNavigationData _apiObject]): Returns the wrapped WebNavigationData.

  • UIProcess/Cocoa/WKNavigationDataInternal.h: Added.

(WebKit::wrapper): Added. Returns a WebNavigationData’s wrapper as a WKNavigationData.

  • WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
9:31 AM WebKitGTK/2.2.x edited by zandobersek@gmail.com
Add two proposed merges for the next 2.2 release. (diff)
9:31 AM Changeset in webkit [158752] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening; Fix expected results for video-seek-with-negative-playback.html,
and modify the test to conform to media test style.

  • media/video-seek-with-negative-playback-expected.txt:
  • media/video-seek-with-negative-playback.html:
9:29 AM Changeset in webkit [158751] by msaboff@apple.com
  • 18 edits
    3 deletes in trunk/Source/JavaScriptCore

Change ctiTrampoline into a thunk
https://bugs.webkit.org/show_bug.cgi?id=123844

Reviewed by Filip Pizlo.

Converted ctiTrampoline and ctiOpThrowNotCaught into thunks named callToJavaScript
and returnFromJavaScript. Cleaned up and in some cases removed JITStubsXXX.h files
after removing ctiTrampoline and ctiOpThrowNotCaught. Added callJavaScriptJITFunction
to VM that is a function pointer to the callToJavaScript thunk.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • jit/JITCode.cpp:

(JSC::JITCode::execute):

  • jit/JITExceptions.cpp:

(JSC::genericUnwind):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARM64.h: Removed.
  • jit/JITStubsARMv7.h:
  • jit/JITStubsMIPS.h: Removed.
  • jit/JITStubsMSVC64.asm:
  • jit/JITStubsSH4.h: Removed.
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
  • jit/JSInterfaceJIT.h:
  • jit/ThunkGenerators.cpp:

(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

  • jit/ThunkGenerators.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
8:48 AM Changeset in webkit [158750] by dbates@webkit.org
  • 7 edits in trunk/Source

Add ENABLE(TEXT_SELECTION)
https://bugs.webkit.org/show_bug.cgi?id=123827

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add compile-time guard, ENABLE(TEXT_SELECTION), to enable or
disable selection painting in WebCore (enabled by default).

On iOS we disable WebCore selection painting and have UIKit
paint the selection.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.

  • rendering/LogicalSelectionOffsetCaches.h:

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
For now, add a ENABLE(TEXT_SELECTION)-guard around an assertion. Added
a FIXME comment to investigate the callers and either move the assertion
to the appropriate callers or structure the code such that we can remove
the assertion.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.

  • rendering/TextPaintStyle.cpp:

(WebCore::computeTextSelectionPaintStyle): Only compute the selection
paint style when TEXT_SELECTION is enabled. Otherwise, return a paint
style identical to the text paint style. Also, substitute nullptr for 0.

Source/WTF:

Enable selection painting by default on all ports except iOS.

  • wtf/FeatureDefines.h:
8:45 AM Changeset in webkit [158749] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unrevewied Windows build fix after r158736; add InlineElementBox.cpp to the RenderingAllInOne.cpp file.

  • rendering/RenderingAllInOne.cpp:
8:38 AM Changeset in webkit [158748] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL should support StringCharCodeAt
https://bugs.webkit.org/show_bug.cgi?id=123854

Reviewed by Sam Weinig.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileStringCharCodeAt):

8:36 AM Changeset in webkit [158747] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix, style() return type is now a reference.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):

8:26 AM Changeset in webkit [158746] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed 32-bit Mac build fix; use an explicit FloatSize -> IntSize conversion function.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):

8:15 AM Changeset in webkit [158745] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

Playing many sounds with HTML5 Audio makes WebKit unresponsive
https://bugs.webkit.org/show_bug.cgi?id=116145

Reviewed by Eric Carlson.

Cache as much information as possible from AVPlayerItem to eliminate unneccesary
calls into AVFoundation.

Add WillChange/DidChange functions to handle the results of KVO notifications
from AVPlayerItem and AVPlayer:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasEnabledAudioDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::presentationSizeDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::durationDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rateDidChange):
(WebCore::itemKVOProperties):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

Instruct the HTMLMediaElement to cache the currentTime value for 5 seconds:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::maximumDurationToCacheMediaTime):

Add and initialize member variables to hold these cached values:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):

Add a new Notification type which can take (and call) a Function object:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification):
(WebCore::MediaPlayerPrivateAVFoundation::Notification::function):

Implement queries in terms of the cached values of AVPlayerItem and AVPlayer
properties:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):

Invalidate the cached currentTime before calling scheduleTimeUpdate so that the
correct movieTime is saved in m_clockTimeAtLastUpdateEvent:

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::setReadyState):

7:54 AM Changeset in webkit [158744] by svillar@igalia.com
  • 18 edits
    4 adds in trunk

[CSS Grid Layout] Add support for named grid areas
https://bugs.webkit.org/show_bug.cgi?id=120045

Reviewed by Andreas Kling.

From Blink r155555, r155850 and r155889 by <jchaffraix@chromium.org>

Source/WebCore:

Added support for named grid areas. Basically a named grid area is
now a valid grid position. The shorthand parsing of grid-area was
split from the grid-{row|column} as the rules for expanding are
slightly different.

Unknown grid area names are treated as 'auto' as per the
specification. This means that for those cases we need to trigger
the auto-placement algorithm.

Tests: fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html

fast/css-grid-layout/grid-item-named-grid-area-resolution.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):
(WebCore::gridMissingGridPositionValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::parseSingleGridAreaLonghand):

  • css/CSSParser.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):

  • css/StyleResolver.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):

  • rendering/style/GridPosition.h:

(WebCore::GridPosition::isNamedGridArea):
(WebCore::GridPosition::setNamedGridArea):
(WebCore::GridPosition::namedGridLine):

LayoutTests:

Added a couple of new tests to check that both known and unknown
named grid areas are properly handled.

Also extended some of the existing tests to use named grid areas
as any other possible grid position.

  • fast/css-grid-layout/grid-item-area-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-area-get-set.html:
  • fast/css-grid-layout/grid-item-bad-named-area-auto-placement-expected.txt: Added.
  • fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html: Added.
  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-named-grid-area-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-item-named-grid-area-resolution.html: Added.
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
  • fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:
6:15 AM Changeset in webkit [158743] by Chris Fleizach
  • 442 edits
    4 adds in trunk

AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Video and audio elements don't appear as distinct objects in the AX hierarchy,
nor are they treated as replaceable objects when emitting the text. We should
treat these characters like attachments, for one. On the Mac platform, we should
also identify them with special subroles.

Tests: platform/mac/accessibility/media-emits-object-replacement.html

platform/mac/accessibility/media-role-descriptions.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isGenericFocusableElement):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

LayoutTests:

Making media elements int replaced elements has the unfortunate side-effect
of causing a new line to be inserted into any test using a <video> or <audio> tag.

  • compositing/video/video-poster-expected.txt:
  • compositing/video/video-reflection-expected.txt:
  • compositing/visibility/visibility-simple-video-layer-expected.txt:
  • fast/css/first-letter-block-form-controls-crash-expected.txt:
  • fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt:
  • fast/forms/form-associated-element-crash3-expected.txt:
  • fast/multicol/renderer-positioned-assert-crash-expected.txt:
  • fast/regions/full-screen-video-from-region-expected.txt:
  • fast/runin/nonblock-runin-expected.txt:
  • fast/spatial-navigation/snav-media-elements-expected.txt:
  • fullscreen/full-screen-crash-offsetLeft-expected.txt:
  • fullscreen/full-screen-no-style-sharing-expected.txt:
  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/video-controls-drag-expected.txt:
  • fullscreen/video-controls-timeline-expected.txt:
  • fullscreen/video-cursor-auto-hide-expected.txt:
  • fullscreen/video-specified-size-expected.txt:
  • http/tests/appcache/video-expected.txt:
  • http/tests/media/pdf-served-as-pdf-expected.txt:
  • http/tests/media/reload-after-dialog-expected.txt:
  • http/tests/media/text-served-as-text-expected.txt:
  • http/tests/media/video-accept-encoding-expected.txt:
  • http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
  • http/tests/media/video-cross-site-expected.txt:
  • http/tests/media/video-error-abort-expected.txt:
  • http/tests/media/video-load-suspend-expected.txt:
  • http/tests/media/video-play-progress-expected.txt:
  • http/tests/media/video-play-stall-before-meta-data-expected.txt:
  • http/tests/media/video-preload-expected.txt:
  • http/tests/media/video-redirect-expected.txt:
  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-served-as-text-expected.txt:
  • http/tests/media/video-throttled-load-metadata-expected.txt:
  • http/tests/misc/empty-urls-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-src-from-remote-expected.txt:
  • http/tests/security/text-track-crossorigin-expected.txt:
  • media/W3C/audio/events/event_canplay-expected.txt:
  • media/W3C/audio/events/event_canplay_manual-expected.txt:
  • media/W3C/audio/events/event_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/audio/events/event_loadeddata-expected.txt:
  • media/W3C/audio/events/event_loadeddata_manual-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/audio/events/event_loadstart-expected.txt:
  • media/W3C/audio/events/event_loadstart_manual-expected.txt:
  • media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_order_canplay_playing-expected.txt:
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/audio/events/event_pause_manual-expected.txt:
  • media/W3C/audio/events/event_play-expected.txt:
  • media/W3C/audio/events/event_play_manual-expected.txt:
  • media/W3C/audio/events/event_playing-expected.txt:
  • media/W3C/audio/events/event_playing_manual-expected.txt:
  • media/W3C/audio/events/event_progress-expected.txt:
  • media/W3C/audio/events/event_progress_manual-expected.txt:
  • media/W3C/audio/events/event_timeupdate-expected.txt:
  • media/W3C/audio/events/event_timeupdate_manual-expected.txt:
  • media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/audio/paused/paused_false_during_play-expected.txt:
  • media/W3C/audio/paused/paused_true_during_pause-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
  • media/W3C/video/error/error_null-expected.txt:
  • media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
  • media/W3C/video/error/error_property_exists-expected.txt:
  • media/W3C/video/events/event_canplay-expected.txt:
  • media/W3C/video/events/event_canplay_manual-expected.txt:
  • media/W3C/video/events/event_canplaythrough-expected.txt:
  • media/W3C/video/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/video/events/event_loadeddata-expected.txt:
  • media/W3C/video/events/event_loadeddata_manual-expected.txt:
  • media/W3C/video/events/event_loadedmetadata-expected.txt:
  • media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/video/events/event_loadstart-expected.txt:
  • media/W3C/video/events/event_loadstart_manual-expected.txt:
  • media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/video/events/event_order_canplay_playing-expected.txt:
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/video/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/video/events/event_pause_manual-expected.txt:
  • media/W3C/video/events/event_play-expected.txt:
  • media/W3C/video/events/event_play_manual-expected.txt:
  • media/W3C/video/events/event_playing-expected.txt:
  • media/W3C/video/events/event_playing_manual-expected.txt:
  • media/W3C/video/events/event_progress-expected.txt:
  • media/W3C/video/events/event_progress_manual-expected.txt:
  • media/W3C/video/events/event_timeupdate-expected.txt:
  • media/W3C/video/events/event_timeupdate_manual-expected.txt:
  • media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/video/networkState/networkState_during_progress-expected.txt:
  • media/W3C/video/networkState/networkState_initial-expected.txt:
  • media/W3C/video/networkState/networkState_property_exists-expected.txt:
  • media/W3C/video/paused/paused_false_during_play-expected.txt:
  • media/W3C/video/paused/paused_true_during_pause-expected.txt:
  • media/W3C/video/preload/preload_property_exists-expected.txt:
  • media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_empty-expected.txt:
  • media/W3C/video/preload/preload_reflects_metadata-expected.txt:
  • media/W3C/video/preload/preload_reflects_no_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_none-expected.txt:
  • media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/video/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/readyState/readyState_initial-expected.txt:
  • media/W3C/video/readyState/readyState_property_exists-expected.txt:
  • media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
  • media/W3C/video/src/src_reflects_no_value-expected.txt:
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg4-supported-expected.txt:
  • media/audio-only-video-intrinsic-size-expected.txt:
  • media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
  • media/before-load-member-access-expected.txt:
  • media/broken-video-expected.txt:
  • media/constructors-expected.txt:
  • media/controls-css-overload-expected.txt:
  • media/controls-drag-timebar-expected.txt:
  • media/controls-layout-direction-expected.txt:
  • media/controls-right-click-on-timebar-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • media/event-attributes-expected.txt:
  • media/media-blocked-by-beforeload-expected.txt:
  • media/media-blocked-by-willsendrequest-expected.txt:
  • media/media-can-play-mpeg-audio-expected.txt:
  • media/media-can-play-mpeg4-video-expected.txt:
  • media/media-can-play-octet-stream-expected.txt:
  • media/media-can-play-type-expected.txt:
  • media/media-can-play-wav-audio-expected.txt:
  • media/media-captions-expected.txt:
  • media/media-captions-no-controls-expected.txt:
  • media/media-controller-expected.txt:
  • media/media-controller-playback-expected.txt:
  • media/media-controller-playbackrate-expected.txt:
  • media/media-controller-time-clamp-expected.txt:
  • media/media-controller-time-constant-expected.txt:
  • media/media-controller-time-expected.txt:
  • media/media-controller-timeupdate-expected.txt:
  • media/media-controller-unpause-expected.txt:
  • media/media-controls-invalid-url-expected.txt:
  • media/media-ended-expected.txt:
  • media/media-extension-with-fragment-expected.txt:
  • media/media-fragments/TC0001-expected.txt:
  • media/media-fragments/TC0002-expected.txt:
  • media/media-fragments/TC0003-expected.txt:
  • media/media-fragments/TC0004-expected.txt:
  • media/media-fragments/TC0005-expected.txt:
  • media/media-fragments/TC0006-expected.txt:
  • media/media-fragments/TC0009-expected.txt:
  • media/media-fragments/TC0011-expected.txt:
  • media/media-fragments/TC0012-expected.txt:
  • media/media-fragments/TC0014-expected.txt:
  • media/media-fragments/TC0015-expected.txt:
  • media/media-fragments/TC0017-expected.txt:
  • media/media-fragments/TC0024-expected.txt:
  • media/media-fragments/TC0027-expected.txt:
  • media/media-fragments/TC0028-expected.txt:
  • media/media-fragments/TC0029-expected.txt:
  • media/media-fragments/TC0030-expected.txt:
  • media/media-fragments/TC0031-expected.txt:
  • media/media-fragments/TC0032-expected.txt:
  • media/media-fragments/TC0033-expected.txt:
  • media/media-fragments/TC0034-expected.txt:
  • media/media-fragments/TC0035-expected.txt:
  • media/media-fragments/TC0036-expected.txt:
  • media/media-fragments/TC0037-expected.txt:
  • media/media-fragments/TC0038-expected.txt:
  • media/media-fragments/TC0039-expected.txt:
  • media/media-fragments/TC0044-expected.txt:
  • media/media-fragments/TC0051-expected.txt:
  • media/media-fragments/TC0052-expected.txt:
  • media/media-fragments/TC0053-expected.txt:
  • media/media-fragments/TC0054-expected.txt:
  • media/media-fragments/TC0055-expected.txt:
  • media/media-fragments/TC0058-expected.txt:
  • media/media-fragments/TC0059-expected.txt:
  • media/media-fragments/TC0061-expected.txt:
  • media/media-fragments/TC0062-expected.txt:
  • media/media-fragments/TC0063-expected.txt:
  • media/media-fragments/TC0064-expected.txt:
  • media/media-fragments/TC0065-expected.txt:
  • media/media-fragments/TC0066-expected.txt:
  • media/media-fragments/TC0067-expected.txt:
  • media/media-fragments/TC0068-expected.txt:
  • media/media-fragments/TC0069-expected.txt:
  • media/media-fragments/TC0070-expected.txt:
  • media/media-fragments/TC0071-expected.txt:
  • media/media-fragments/TC0072-expected.txt:
  • media/media-fragments/TC0073-expected.txt:
  • media/media-fragments/TC0074-expected.txt:
  • media/media-fragments/TC0075-expected.txt:
  • media/media-fragments/TC0076-expected.txt:
  • media/media-fragments/TC0077-expected.txt:
  • media/media-fragments/TC0078-expected.txt:
  • media/media-fragments/TC0079-expected.txt:
  • media/media-fragments/TC0080-expected.txt:
  • media/media-fragments/TC0081-expected.txt:
  • media/media-fragments/TC0082-expected.txt:
  • media/media-fragments/TC0083-expected.txt:
  • media/media-fragments/TC0084-expected.txt:
  • media/media-fragments/TC0085-expected.txt:
  • media/media-fragments/TC0086-expected.txt:
  • media/media-fragments/TC0087-expected.txt:
  • media/media-fragments/TC0088-expected.txt:
  • media/media-fragments/TC0089-expected.txt:
  • media/media-fragments/TC0090-expected.txt:
  • media/media-fragments/TC0091-expected.txt:
  • media/media-fragments/TC0092-expected.txt:
  • media/media-fragments/TC0093-expected.txt:
  • media/media-fragments/TC0094-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-preload-no-delay-loadevent-expected.txt:
  • media/no-autoplay-with-user-gesture-requirement-expected.txt:
  • media/nodesFromRect-shadowContent-expected.txt:
  • media/restore-from-page-cache-expected.txt:
  • media/sources-fallback-codecs-expected.txt:
  • media/track/add-and-remove-track-expected.txt:
  • media/track/audio-track-expected.txt:
  • media/track/opera/interfaces/TextTrack/addCue-expected.txt:
  • media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/align-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/id-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/track-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
  • media/track/text-track-cue-is-reachable-expected.txt:
  • media/track/text-track-is-reachable-expected.txt:
  • media/track/track-active-cues-expected.txt:
  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-track-expected.txt:
  • media/track/track-addtrack-kind-expected.txt:
  • media/track/track-automatic-subtitles-expected.txt:
  • media/track/track-css-all-cues-expected.txt:
  • media/track/track-css-cue-lifetime-expected.txt:
  • media/track/track-css-matching-default-expected.txt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching-lang-expected.txt:
  • media/track/track-css-matching-timestamps-expected.txt:
  • media/track/track-css-property-whitelist-expected.txt:
  • media/track/track-css-user-override-expected.txt:
  • media/track/track-cue-container-rendering-position-expected.txt:
  • media/track/track-cue-empty-text-crash-expected.txt:
  • media/track/track-cue-inline-assertion-crash-expected.txt:
  • media/track/track-cue-mutable-expected.txt:
  • media/track/track-cue-mutable-fragment-expected.txt:
  • media/track/track-cue-negative-timestamp-expected.txt:
  • media/track/track-cue-nothing-to-render-expected.txt:
  • media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-empty-cue-crash-expected.txt:
  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering-on-resize-expected.txt:
  • media/track/track-cue-rendering-rtl-expected.txt:
  • media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
  • media/track/track-cue-rendering-with-padding-expected.txt:
  • media/track/track-cues-cuechange-expected.txt:
  • media/track/track-cues-enter-exit-expected.txt:
  • media/track/track-cues-missed-expected.txt:
  • media/track/track-cues-pause-on-exit-expected.txt:
  • media/track/track-cues-seeking-expected.txt:
  • media/track/track-cues-sorted-before-dispatch-expected.txt:
  • media/track/track-default-attribute-expected.txt:
  • media/track/track-disabled-addcue-expected.txt:
  • media/track/track-disabled-expected.txt:
  • media/track/track-element-load-event-expected.txt:
  • media/track/track-in-band-cues-added-once-expected.txt:
  • media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
  • media/track/track-in-band-expected.txt:
  • media/track/track-in-band-legacy-api-expected.txt:
  • media/track/track-in-band-style-expected.txt:
  • media/track/track-kind-expected.txt:
  • media/track/track-large-timestamp-expected.txt:
  • media/track/track-legacyapi-with-automatic-mode-expected.txt:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-long-captions-file-expected.txt:
  • media/track/track-mode-disabled-crash-expected.txt:
  • media/track/track-mode-expected.txt:
  • media/track/track-mode-not-changed-by-new-track-expected.txt:
  • media/track/track-mode-triggers-loading-expected.txt:
  • media/track/track-remove-active-cue-crash-expected.txt:
  • media/track/track-remove-by-setting-innerHTML-expected.txt:
  • media/track/track-remove-quickly-expected.txt:
  • media/track/track-text-track-cue-list-expected.txt:
  • media/track/track-texttracks-expected.txt:
  • media/track/track-webvtt-tc000-empty-expected.txt:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc010-no-timings-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc023-markup-expected.txt:
  • media/track/track-webvtt-tc024-timestamp-expected.txt:
  • media/track/track-webvtt-tc025-class-markup-expected.txt:
  • media/track/track-webvtt-tc026-voice-expected.txt:
  • media/track/track-webvtt-tc027-empty-cue-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/track/track-word-breaking-expected.txt:
  • media/track/tracklist-is-reachable-expected.txt:
  • media/track/video-track-expected.txt:
  • media/unsupported-rtsp-expected.txt:
  • media/unsupported-tracks-expected.txt:
  • media/video-append-source-expected.txt:
  • media/video-autoplay-expected.txt:
  • media/video-beforeload-remove-source-expected.txt:
  • media/video-buffered-expected.txt:
  • media/video-canvas-drawing-expected.txt:
  • media/video-canvas-drawing-output-expected.txt:
  • media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
  • media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-with-mutation-event-handler-expected.txt:
  • media/video-controls-zoomed-expected.txt:
  • media/video-currentTime-delay-expected.txt:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set2-expected.txt:
  • media/video-delay-load-event-expected.txt:
  • media/video-display-aspect-ratio-expected.txt:
  • media/video-dom-autoplay-expected.txt:
  • media/video-dom-preload-expected.txt:
  • media/video-dom-src-expected.txt:
  • media/video-duration-known-after-eos-expected.txt:
  • media/video-error-does-not-exist-expected.txt:
  • media/video-load-networkState-expected.txt:
  • media/video-load-preload-metadata-expected.txt:
  • media/video-load-preload-none-expected.txt:
  • media/video-load-readyState-expected.txt:
  • media/video-load-require-user-gesture-expected.txt:
  • media/video-loop-expected.txt:
  • media/video-mouse-focus-expected.txt:
  • media/video-muted-expected.txt:
  • media/video-no-autoplay-expected.txt:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-immediately-expected.txt:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-pause-events-expected.txt:
  • media/video-play-pause-exception-expected.txt:
  • media/video-play-require-user-gesture-expected.txt:
  • media/video-playbackrate-expected.txt:
  • media/video-played-collapse-expected.txt:
  • media/video-played-ranges-1-expected.txt:
  • media/video-played-reset-expected.txt:
  • media/video-plays-past-end-of-test-expected.txt:
  • media/video-poster-blocked-by-willsendrequest-expected.txt:
  • media/video-poster-delayed-expected.txt:
  • media/video-poster-expected.txt:
  • media/video-poster-scale-expected.txt:
  • media/video-preload-expected.txt:
  • media/video-replaces-poster-expected.txt:
  • media/video-reverse-play-duration-expected.txt:
  • media/video-seek-after-end-expected.txt:
  • media/video-seek-by-small-increment-expected.txt:
  • media/video-seek-multiple-expected.txt:
  • media/video-seek-no-src-exception-expected.txt:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seekable-expected.txt:
  • media/video-seeking-expected.txt:
  • media/video-set-rate-from-pause-expected.txt:
  • media/video-single-valid-source-expected.txt:
  • media/video-size-expected.txt:
  • media/video-source-error-expected.txt:
  • media/video-source-error-no-candidate-expected.txt:
  • media/video-source-expected.txt:
  • media/video-source-inserted-expected.txt:
  • media/video-source-load-expected.txt:
  • media/video-source-none-supported-expected.txt:
  • media/video-source-type-expected.txt:
  • media/video-src-blob-expected.txt:
  • media/video-src-change-expected.txt:
  • media/video-src-empty-expected.txt:
  • media/video-src-expected.txt:
  • media/video-src-invalid-poster-expected.txt:
  • media/video-src-invalid-remove-expected.txt:
  • media/video-src-none-expected.txt:
  • media/video-src-plus-source-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-set-expected.txt:
  • media/video-src-source-expected.txt:
  • media/video-timeupdate-during-playback-expected.txt:
  • media/video-timeupdate-reverse-play-expected.txt:
  • media/video-volume-expected.txt:
  • media/video-width-height-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/mac/accessibility/media-emits-object-replacement.html: Added.
  • platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
  • platform/mac/accessibility/media-role-descriptions.html: Added.
  • platform/mac/compositing/video/video-object-fit-expected.txt:
  • platform/mac/fullscreen/video-controls-override-expected.txt:
  • platform/mac/media/media-can-play-wav-audio-expected.txt:
  • platform/mac/media/media-can-play-webm-expected.txt:
  • platform/mac/media/video-seek-past-end-paused-expected.txt:
5:55 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
5:55 AM Changeset in webkit [158742] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118969

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.

Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfVisibleCells):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):

5:54 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
5:52 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
3:31 AM Changeset in webkit [158741] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[ATK] accessibility/tabindex-elements-are-accessible.html is failing
https://bugs.webkit.org/show_bug.cgi?id=123884

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.

Added new accessibility expectation file. ATK represents paragraph's role as a ATK_ROLE_PARAGRAPH.

  • platform/efl/TestExpectations: Test is no longer failing.
  • platform/efl/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
  • platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
3:17 AM Changeset in webkit [158740] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Tests failing after r158195

  • platform/gtk/TestExpectations: Added failure expectations.
3:11 AM Changeset in webkit [158739] by rniwa@webkit.org
  • 3 edits
    6 adds in trunk

Notify nodes removal to Range/Selection after dispatching blur and mutation event
https://bugs.webkit.org/show_bug.cgi?id=123880

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/b60576a0560d14f8757e58d55d37b7cefa48a6ac

In willRemoveChildren in ContainerNode.cpp, call Document::nodeChildrenWillBeRemoved after instead of
before dispatching mutation events because we need to update ranges created by those mutation event
listeners. willRemoveChild was fixed in r115686.

Tests: editing/selection/selection-change-in-blur-event-by-remove-children.html

editing/selection/selection-change-in-mutation-event-by-remove-children.html
fast/dom/Range/range-created-during-remove-children.html

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):

LayoutTests:

  • editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt: Added.
  • editing/selection/selection-change-in-blur-event-by-remove-children.html: Added.
  • editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt: Added.
  • editing/selection/selection-change-in-mutation-event-by-remove-children.html: Added.
  • fast/dom/Range/range-created-during-remove-children-expected.txt: Added.
  • fast/dom/Range/range-created-during-remove-children.html: Added.
2:55 AM Changeset in webkit [158738] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Fix out-of-date offset in selection range code in range.surroundContents
https://bugs.webkit.org/show_bug.cgi?id=123871

Source/WebCore:

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707

The code in Range::insertNode assumeed that the start offset of the selection range within its container
doesn't change across a call to insertBefore on the container but this is wrong. This patch recomputes
the start offset when it is used after the insertBefore call.

Test: editing/selection/range-surroundContents-with-preceding-node.html

  • dom/Range.cpp:

(WebCore::Range::insertNode):

LayoutTests:

Reviewed by Andreas Kling.

  • editing/selection/range-surroundContents-with-preceding-node-expected.txt: Added.
  • editing/selection/range-surroundContents-with-preceding-node.html: Added.
2:33 AM Changeset in webkit [158737] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] accessibility/svg-group-element-with-title.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114251

Unreviewed GTK gardening.

Removed failure expectation as the test is passing since r158664.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-06

  • platform/gtk/TestExpectations: The test is no longer failing.
2:26 AM Changeset in webkit [158736] by akling@apple.com
  • 13 edits
    2 adds in trunk/Source/WebCore

Add InlineElementBox and stop instantiating InlineBox directly.
<https://webkit.org/b/123882>

Make the InlineBox constructors protected and add a new class
called InlineElementBox on top. This is somewhat analogous to the
split between RenderText and RenderElement, and allows us to make
renderer() return a far tighter RenderBoxModelObject& instead
of a RenderObject&.

Moved over attachLine(), deleteLine() and extractLine() to start
things off. More things will follow.

Reviewed by Antti Koivisto.

2:21 AM Changeset in webkit [158735] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Change required version of ATK to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123883

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.

Changing a required version of ATK to 2.10.0

  • Source/cmake/OptionsEfl.cmake:
1:32 AM Changeset in webkit [158734] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Seek for video doesn't work when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123791

In MediaPlayerPrivateGStreamer::seek negative playback rate was not taken to account.

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.

Test: media/video-seek-with-negative-playback.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::seek):

LayoutTests: Test for seek not working properly with negative playback rate.
https://bugs.webkit.org/show_bug.cgi?id=123791

Seek method should work properly with negative playback rate.

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.

  • media/video-seek-with-negative-playback.html: Added.
  • media/video-seek-with-negative-playback-expected.txt: Added.
12:19 AM Changeset in webkit [158733] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Reinstate an annoying assertion that I accidentally commented out.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):

12:14 AM Changeset in webkit [158732] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GStreamer] Override label() and language() in Audio and VideoTrackPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=123836

The tests are currently flakey because we only get the label and language if we get
tags after the track client is set.

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Philippe Normand.

No new tests because the tests already exist (this fixes flakeyness).

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Override label() and language() to use m_label and m_language.
  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same.
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Make m_label and m_language protected so they can be used in the functions above.
12:13 AM Changeset in webkit [158731] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test for queries whose leftmost selector matches the root node
https://bugs.webkit.org/show_bug.cgi?id=123877

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/22981c70bf93e8a07ee7b4d68a4522aee21b26ce
so that we won't introduce the regression they had.

  • fast/selectors/querySelector-leftmost-selector-matches-rootNode-expected.txt: Added.
  • fast/selectors/querySelector-leftmost-selector-matches-rootNode.html: Added.
12:09 AM Changeset in webkit [158730] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

RenderBlockFlow should only expose its line boxes as RootInlineBox.
<https://webkit.org/b/123878>

The line boxes attached directly to a RenderBlockFlow are always
RootInlineBox objects, so call sites should always use the tightly
typed firstRootBox() and lastRootBox().

This allows the compiler to devirtualize calls to member functions
of RootInlineBox that are marked FINAL.

Reviewed by Antti Koivisto.

12:05 AM Changeset in webkit [158729] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Assertion failure end < m_runCount in WebCore::BidiRunList<WebCore::BidiRun>::reverseRuns
https://bugs.webkit.org/show_bug.cgi?id=123863

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/cbaa92c763a37d89eeabd01658e522219299290c

Test: fast/text/bidi-reverse-runs-crash.html

  • platform/text/BidiResolver.h:

(WebCore::BidiResolver<Iterator, Run>::createBidiRunsForLine): Don't reverse the runs if there's
nothing to be reversed.

LayoutTests:

  • fast/text/bidi-reverse-runs-crash-expected.txt: Added.
  • fast/text/bidi-reverse-runs-crash.html: Added.
12:02 AM Changeset in webkit [158728] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Address the review comment after r158724.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

Nov 5, 2013:

11:31 PM Changeset in webkit [158727] by Alan Bujtas
  • 3 edits
    1 add in trunk

Widget's position change should not initiate layout, only when its size changes.
https://bugs.webkit.org/show_bug.cgi?id=123860

Reviewed by Andreas Kling.

RenderWidgets initiate unnecessary layouts while scrolling when they are embedded to
overflow:scroll containers. Scroll position change doesn't dirty the render tree
so it should not trigger layout either.

.:

  • ManualTests/layouts-on-renderwidgets-while-scrolling.html: Added.

Source/WebCore:

Manual test added. Unfortunately we can't test against the number of layouts yet.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition):

11:30 PM Changeset in webkit [158726] by rniwa@webkit.org
  • 3 edits
    8 adds in trunk/LayoutTests

Add more tests for formaction, formenctype, formmethod, formnovalidate, and formtarget attributes
https://bugs.webkit.org/show_bug.cgi?id=123876

Reviewed by Andreas Kling.

Merge tests from https://chromium.googlesource.com/chromium/blink/+/5f4ccd416fec39a6878af66e87bda191cc59ea7e
so that we won't introduce regressions they had.

  • fast/forms/formaction-attribute-expected.txt:
  • fast/forms/formaction-attribute.html:
  • fast/forms/formmethod-attribute-input-2-expected.txt: Added.
  • fast/forms/formmethod-attribute-input-2.html: Added.
  • fast/forms/formtarget-attribute-input-2-expected.txt: Added.
  • fast/forms/formtarget-attribute-input-2.html: Added.
  • fast/forms/interactive-validation-formnovalidate-2-expected.txt: Added.
  • fast/forms/interactive-validation-formnovalidate-2.html: Added.
  • fast/forms/mailto/formenctype-attribute-input-2-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-input-2.html: Added.
11:20 PM Changeset in webkit [158725] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Mac Mavericks rebaseline after r158714.

  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
11:11 PM Changeset in webkit [158724] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Use-after-free in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873

Reviewed by Andreas Kling.

Source/WebCore:

Ref the SliderThumbElement since it could go away inside dragFrom.

Test: fast/forms/range/range-type-change-onchange-2.html

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

LayoutTests:

Merge https://chromium.googlesource.com/chromium/blink/+/04a23bfca2d04101a1828d36ff36c29f3a24f34b

  • fast/forms/range/range-type-change-onchange-2-expected.txt: Added.
  • fast/forms/range/range-type-change-onchange-2.html: Added.
10:14 PM Changeset in webkit [158723] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Change the order of conditions to avoid computing rendererIsEditable()
https://bugs.webkit.org/show_bug.cgi?id=123868

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707

When we need both Node::renderer() and Node::rendererIsEditable() conditions to be true to perform
some operation, it is more effective to check for renderer() first, so that if this condition fails
we can avoid unnecessary computation of rendererIsEditable().

  • dom/Position.cpp:

(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

10:02 PM Changeset in webkit [158722] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

simpleUserAgentStyleSheet doesn't have focus ring on anchor element
https://bugs.webkit.org/show_bug.cgi?id=123867

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/08ecc23c4d80be9969918c4baf0ac83dc6cb6cbd

  • css/CSSDefaultStyleSheets.cpp:
10:00 PM Changeset in webkit [158721] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

valueForBorderRadiusShorthand returns wrong values in some case
https://bugs.webkit.org/show_bug.cgi?id=123866

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/0933728126f2db06ab8e945efc98bffa2d42af1c

Because valueForBorderRadiusShorthand misses the followings:

  • showHorizontalBottomRight depends on showHorizontalBottomLeft.
  • showHorizontalTopRight depends on showHorizontalBottomRight (including showHorizontalBottomLeft).

See also http://dev.w3.org/csswg/css-backgrounds/#the-border-radius

Test: fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusShorthandValue):

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-borderRadius-2-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html: Added.
9:50 PM Changeset in webkit [158720] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Flaky Test: transitions/cancel-transition.html
https://bugs.webkit.org/show_bug.cgi?id=114193

Reviewed by Simon Fraser.

Merge https://chromium.googlesource.com/chromium/blink/+/983dbbff6c46b6365540bf1451f25b31d72ce893

  • transitions/cancel-transition.html:
9:21 PM Changeset in webkit [158719] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Protect DOM nodes in IndentOutdentCommand::tryIndentingAsListItem()
https://bugs.webkit.org/show_bug.cgi?id=123861

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/297442eb539a2b764fdad323de79099a70179186 partially.

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Make selectedListItem, previousList, and nextList
RefPtr since they're are used after calling insertNodeBefore.

8:47 PM Changeset in webkit [158718] by akling@apple.com
  • 22 edits in trunk/Source/WebCore

Apply more unique_ptr to line box management.
<https://webkit.org/b/123857>

Make all of the functions that return newly-created line boxes
return them packed up in std::unique_ptrs.

There is one exception in RenderBlockLineLayout where the function
createInlineBoxForRenderer() is inconsistent about the ownership of
the returned object. This will be addressed by a subsequent patch.

We now "release" the line boxes into their various home structures,
so the pointer smartness doesn't go end-to-end just yet.

Reviewed by Anders Carlsson.

8:40 PM Changeset in webkit [158717] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL should support NewObject
https://bugs.webkit.org/show_bug.cgi?id=123849

Reviewed by Oliver Hunt.

  • ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::allocate):

8:38 PM Changeset in webkit [158716] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL should support StringCharAt
https://bugs.webkit.org/show_bug.cgi?id=123855

Reviewed by Oliver Hunt.

This is just like GetByVal for String, so we reuse that code.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):

7:59 PM Changeset in webkit [158715] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix attempt after r158704.

  • FullscreenVideoController.cpp:
7:55 PM Changeset in webkit [158714] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

getComputedStyle(x).lineHeight is affected by zooming
https://bugs.webkit.org/show_bug.cgi?id=123847

Reviewed by Benjamin Poulain.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/7957097afbab2899ababd0d9c8acbf6e3eddb870

Test: fast/css/line-height-zoom-get-computed-style.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::lineHeightFromStyle): Don't round line-height values.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyLineHeight::applyValue): Use the computed value instead of the used value.

LayoutTests:

Cleaned up the test.

  • fast/css/line-height-zoom-get-computed-style-expected.txt: Added.
  • fast/css/line-height-zoom-get-computed-style.html: Added.
  • platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Rebaselined.
7:50 PM Changeset in webkit [158713] by commit-queue@webkit.org
  • 10 edits in trunk

AX: media controls accessibility needs more work
https://bugs.webkit.org/show_bug.cgi?id=123749

Patch by James Craig <jcraig@apple.com> on 2013-11-05
Reviewed by Jer Noble.

Updated some of the control labels/roles to improve accessibility.

  • Volume slider is now keyboard/screenreader accessible.
  • muteButton was a checkbox toggling checked state, now a button that toggles label "mute/unmute"
  • fullscreenButton was a checkbox toggling checked state, now a button that toggles label "display/exit full screen"
  • captionButton was a checkbox, now a popup button that launches the newly accessible menu.

Subtitles menu is now keyboard/screenreader accessible (uses roaming tabindex).
Render dump expectations changed because volume slider is now hidden via...
...opacity/size (to make accessible without hover) instead of display:none.

Updated existing test coverage.

Source/WebCore:

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel .volume-box):
(audio::-webkit-media-controls-panel .volume-box:active):
(audio::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-closed-captions-container .list):
(audio::-webkit-media-controls-closed-captions-container li:focus):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.focusSiblingCaptionItem):
(Controller.prototype.handleCaptionItemKeyUp):

LayoutTests:

  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/controls-styling-strict-expected.txt:
  • platform/mac/media/controls-without-preload-expected.txt:
7:36 PM Changeset in webkit [158712] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Move some plugin-specific code from RenderWidget to RenderEmbeddedObject.
<https://webkit.org/b/123845>

All RenderWidgets representing plugins will be RenderEmbeddedObjects.
Move some of the plugin-specific logic to RenderEmbeddedObject since it
doesn't make sense for all RenderWidgets (frames, embedded documents)
to care about this.

Reviewed by Anders Carlsson.

6:48 PM Changeset in webkit [158711] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843

Reviewed by Tim Horton.

Merge the test fix in https://chromium.googlesource.com/chromium/blink/+/b249d552497c0939d8277360b99dd3c56b0c9659.

  • fast/table/table-cell-offset-width-expected.txt:
  • fast/table/table-cell-offset-width.html:
6:40 PM Changeset in webkit [158710] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843

Reviewed by Tim Horton.

Merge the test from https://chromium.googlesource.com/chromium/blink/+/58a5fac292a5b3f79b00cdc71074fbf8be2ebc2b
so that we'll never introduce the regression they had.

  • fast/table/table-cell-offset-width-expected.txt: Added.
  • fast/table/table-cell-offset-width.html: Added.
6:39 PM Changeset in webkit [158709] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • WebCore.exp.in:
6:15 PM Changeset in webkit [158708] by Alexandru Chiculita
  • 4 edits
    7 adds in trunk

Web Inspector: Moving an element while in the DOMNodeRemoved handler will hide it in the inspector
https://bugs.webkit.org/show_bug.cgi?id=123516

Reviewed by Timothy Hatcher.

Source/WebCore:

InspectorInstrumentation::willRemoveDOMNode was actually calling both willRemoveDOMNodeImpl and
didRemoveDOMNodeImpl, making the DOMAgent unbind the element even if it was still part of the DOM.

Because of that the DOMAgent was sending two events:

  1. When the element was about to be removed, just before JS "DOMNodeRemoved" was triggered.
  2. When the element was actually removed.

Note that inspector's event #2 will not know about the node, as it just removed it from the
internal hashmap, so it will just use a nodeID == 0 for it.

This patch adds a separate call to InspectorInstrumentation::didRemoveDOMNode, just before the
element is about to be removed. The InspectorInstrumentation::willRemoveDOMNode call is now only used
by the DOMDebugger to trigger the DOM breakpoints in the Web Inspector. That feature is not exposed
in the new Inspector UI, but can be used/tested using the protocol directly.

Tests: inspector-protocol/dom-debugger/node-removed.html

inspector-protocol/dom/dom-remove-events.html
inspector-protocol/dom/remove-multiple-nodes.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeBetween):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):

LayoutTests:

Added tests to check that the DOM.childNodeRemoved inspector-protocol message is dispatched
correctly when DOM nodes are moved while inside the "DOMNodeRemoved" event handler.

  • inspector-protocol/dom-debugger/node-removed-expected.txt: Added.
  • inspector-protocol/dom-debugger/node-removed.html: Added. Checking that the DOMDebugger agent

is still sending the node-removed events.

  • inspector-protocol/dom/dom-remove-events-expected.txt: Added.
  • inspector-protocol/dom/dom-remove-events.html: Added. Test with a single DOM remove event.
  • inspector-protocol/dom/remove-multiple-nodes-expected.txt: Added.
  • inspector-protocol/dom/remove-multiple-nodes.html: Added. Test case when multiple children

are removed at once with parentNode.textContent = "String".

6:09 PM Changeset in webkit [158707] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove old unused code for hypothetical LLVM intrinsics
https://bugs.webkit.org/show_bug.cgi?id=123824

Reviewed by Oliver Hunt.

  • ftl/FTLIntrinsicRepository.h:
6:07 PM Changeset in webkit [158706] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should support String character access operations
https://bugs.webkit.org/show_bug.cgi?id=123783

Reviewed by Oliver Hunt.

Implements:

  • string.length


  • string[index]
  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

6:03 PM Changeset in webkit [158705] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on CMake based ports with GLES.

  • CMakeLists.txt:

Added OPENGLES2_LIBRARIES and OPENGLES2_INCLUDE_DIR into the includes and
libraries list.

5:44 PM Changeset in webkit [158704] by timothy_horton@apple.com
  • 9 edits in trunk/Source/WebCore

platformCALayerDeviceScaleFactor should be const
https://bugs.webkit.org/show_bug.cgi?id=123842

Reviewed by Simon Fraser.

  • WebCore.exp.in:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerDeviceScaleFactor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayerClient.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::platformCALayerDeviceScaleFactor):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):
Constify PlatformCALayerClient::platformCALayerDeviceScaleFactor.

5:39 PM Changeset in webkit [158703] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

text-decoration-skip: ink isn't tested with underlines that don't intersect the underlined text
https://bugs.webkit.org/show_bug.cgi?id=123839

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-05
Reviewed by Simon Fraser.

text-decoration-skip: ink uses a mask to determine where the underline can be drawn. Right now,
there is not a test that makes sure that the mask always gets applied to the location
where the underline will get drawn.

  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline.html: Added.
5:26 PM Changeset in webkit [158702] by barraclough@apple.com
  • 3 edits in trunk/Source/WebCore

Subresource loads should not prevent page throttling
https://bugs.webkit.org/show_bug.cgi?id=123757

Reviewed by Alexey Proskuryakov.

The page-is-loading test for inhibiting process supression is currently
too conservative, preventing supression of pages with infinitely loading
resources (commonly XHRs). Instead, just rely on the FrameLoader being
active (with hysteresis).

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::init):
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):

  • loader/SubresourceLoader.h:
    • remove m_activityAssertion from SubresourceLoader.
5:13 PM Changeset in webkit [158701] by timothy_horton@apple.com
  • 5 edits
    4 adds in trunk

[mac] PDFDocumentImage is too big if PDF has a crop box smaller than the media box
https://bugs.webkit.org/show_bug.cgi?id=123840
<rdar://problem/15308765>

Reviewed by Alexey Proskuryakov.

Test: fast/images/pdf-as-image-crop-box.html

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::size):
Use the crop box when determining the size of the image.

(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):

  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/mac/PDFDocumentImageMac.mm:

(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
Get rid of m_mediaBox, since we don't need it anymore.

(WebCore::PDFDocumentImage::drawPDFPage):
PDFKit does the translation by the crop box origin for us;
if we do it additionally, we'll be painting the wrong part of the image.
So, don't do the translation here.

  • fast/images/pdf-as-image-crop-box-expected.html: Added.
  • fast/images/pdf-as-image-crop-box.html: Added.
  • fast/images/resources/green-1x1.pdf: Added.
  • fast/images/resources/red-green-2x2-cropped-to-1x1.pdf: Added.

Add a test that ensures that PDFDocumentImage respects the PDF's crop box.
red-green-2x2-cropped-to-1x1 has a 2"x2" red square with a 1"x1" green
square centered in it, a media box of 2"x2", and a crop box of 1"x1"
offset by 0.5", 0.5". green-1x1 has a 1"x1" green square. The two images
should render the same if the crop box is being respected correctly.

4:58 PM Changeset in webkit [158700] by andersca@apple.com
  • 5 edits
    1 copy in trunk/Source/WebKit2

Begin work on decoding invocations
https://bugs.webkit.org/show_bug.cgi?id=123838

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation):
Declare the type string and selector keys as constants.

(encodeObject):
Make sure to encode the class name for NSInvocations as well.

(decodeInvocation):
Figure out the local and remove method signatures and make sure that they are equal.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(methodArgumentTypeEncodingForSelector):
Helper function that returns the type encoding for a given selector.

(-[WKRemoteObjectInterface _methodSignatureForSelector:]):
Helper function that returns a method signature for the method with the name referred to by selector.

  • Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h: Added.

Add internal header.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):
Pass the right object to the WKRemoteObjectDecoder initializer and decode the invocation.

  • WebKit2.xcodeproj/project.pbxproj:

Add internal header.

3:58 PM Changeset in webkit [158699] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

WKRemoteObjectDecoder should know which interface it's decoding for
https://bugs.webkit.org/show_bug.cgi?id=123833

Reviewed by Andreas Kling.

Move the interface identifier out into the root object body dictionary and make
the encoded invocation a sibling of it. That way we can look up the interface before
creating the decoder.

Also, manage exported objects and interfaces in a separate hash map.

  • Shared/API/Cocoa/WKRemoteObjectCoder.h:
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
(decodeInvocation):
(decodeObject):

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry registerExportedObject:interface:]):
(-[WKRemoteObjectRegistry unregisterExportedObject:interface:]):
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):

3:45 PM Changeset in webkit [158698] by Antti Koivisto
  • 8 edits
    1 add in trunk/Source/WebCore

Factor index cache for NodeLists and HTMLCollections to a class
https://bugs.webkit.org/show_bug.cgi?id=123823

Reviewed by Ryosuke Niwa.

Implement index cache class that can used by NodeLists and HTMLCollections that currently
each have implementations of their own.

This patch also implements ChildNodeList and LiveNodeList using CollectionIndexCache.
HTMLCollection is will be transitioned later.

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::ChildNodeList::item):

The client calls to cache to for indexed and size access.

(WebCore::ChildNodeList::collectionFirst):
(WebCore::ChildNodeList::collectionLast):
(WebCore::ChildNodeList::collectionTraverseForward):
(WebCore::ChildNodeList::collectionTraverseBackward):

Cache calls back to these as needed to do the actual traversal.

(WebCore::ChildNodeList::invalidateCache):

  • dom/ChildNodeList.h:
  • dom/CollectionIndexCache.h: Added.


Templated cache class itself.

(WebCore::::CollectionIndexCache):
(WebCore::::nodeCount):
(WebCore::::nodeBeforeCached):
(WebCore::::nodeAfterCached):
(WebCore::::nodeAt):
(WebCore::::invalidate):

  • dom/LiveNodeList.cpp:

(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForward):
(WebCore::LiveNodeList::collectionFirst):
(WebCore::LiveNodeList::collectionLast):
(WebCore::LiveNodeList::collectionTraverseForward):
(WebCore::LiveNodeList::collectionTraverseBackward):
(WebCore::LiveNodeList::length):
(WebCore::LiveNodeList::item):
(WebCore::LiveNodeList::invalidateCache):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):

3:14 PM Changeset in webkit [158697] by enrica@apple.com
  • 6 edits in trunk

Full width semicolon is wrong in vertical text.
https://bugs.webkit.org/show_bug.cgi?id=123814
<rdar://problem/15312541>

Reviewed by Benjamin Poulain.

Source/WebCore:

The full width semicolon should always be upright.
Adding it to the list of characters that should
ignore rotation.

  • platform/graphics/FontGlyphs.cpp:

(WebCore::shouldIgnoreRotation):

LayoutTests:

Extended the existing test to include the full width
semicolon.

  • platform/mac/fast/text/vertical-no-sideways.html:
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
  • platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt
3:00 PM Changeset in webkit [158696] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add support for decoding NSStrings
https://bugs.webkit.org/show_bug.cgi?id=123829

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject):
(-[WKRemoteObjectDecoder allowsKeyedCoding]):
Always return YES.

(-[WKRemoteObjectDecoder containsValueForKey:]):
Look up the key in the current dictionary.

(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
Try to get the WebData object and return its data + size.

(-[WKRemoteObjectDecoder requiresSecureCoding]):
Return YES.

(checkIfClassIsAllowed):
Check if the class or any of its superclasses are are allowed.

(validateClass):
Call checkIfClassIsAllowed and validate that the class conforms to NSSecureCoding.

(decodeObject):
Get the class name, verify that the class exists and is allowed.
Allocate and initialize an object using initWithCoder:.

(-[WKRemoteObjectDecoder decodeObjectOfClasses:forKey:]):
Set the allowed classes, look up the object in _currentDictionary and call decodeObject.

(-[WKRemoteObjectDecoder allowedClasses]):
Return _allowedClasses.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Declare interfaceIdentifier as a constant.

(-[WKRemoteObjectRegistry _invokeMessageWithBody:]):
Decode the interface identifier.

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::size):
(WebKit::ImmutableDictionary::map):
Make member functions const.

2:51 PM Changeset in webkit [158695] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ObjCCallbackFunctionImpl's NSInvocation shouldn't retain its target or arguments
https://bugs.webkit.org/show_bug.cgi?id=123822

Reviewed by Geoffrey Garen.

Using -retainArguments on ObjCCallbackFunctionImpl's NSInvocation leads to memory leaks.
We should handle retaining/releasing the target ourselves, and we should never retain the arguments.

  • API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl):
(JSC::ObjCCallbackFunctionImpl::name):
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):

2:44 PM Changeset in webkit [158694] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix Mountain Lion Debug bot after r158689

Unreviewed.

It looks like WebGeolocationManagerProxy::stopUpdating() and WebGeolocationManagerProxy::processDidClose()
are racing in some cases, causing the assertion to fail.

That case is handled properly in the last if() branch of WebGeolocationManagerProxy::removeRequester().
This patch remove the overzealous assertion.

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::removeRequester):

2:38 PM Changeset in webkit [158693] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused RenderWidget::notifyWidget().

Rubber-stamped by Anders Carlsson.

2:30 PM Changeset in webkit [158692] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build for architectures with 4 argument registers (broken since r158681).
https://bugs.webkit.org/show_bug.cgi?id=123826

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Michael Saboff.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):
(JSC::CCallHelpers::setupArguments):

2:04 PM Changeset in webkit [158691] by timothy_horton@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Remote Layer Tree: Apply layer changes to LayerTypeCustom layers to the custom layer in the Web process, not to the CALayerHost
https://bugs.webkit.org/show_bug.cgi?id=123818

Reviewed by Anders Carlsson.

Changes to the properties of a PlatformCALayer of type LayerTypeCustom are intended
to affect the custom CALayer; however, we were bundling them up with the transaction
and applying them to the CALayerHost, leading to important properties being lost.

Instead, apply them to the Web-process-side CALayer when building the transaction.

  • Shared/mac/RemoteLayerTreePropertyApplier.h: Added.
  • Shared/mac/RemoteLayerTreePropertyApplier.mm: Added.

(WebKit::cgColorFromColor):
(WebKit::toCAFilterType):
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::disableActionsForLayer):
Move code to apply LayerProperties to a CALayer from RemoteLayerTreeHost.
Move code to disable actions on a CALayer from RemoteLayerTreeHost.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
(WebKit::RemoteLayerTreeHost::createLayer):
Use RemoteLayerTreePropertyApplier.
Hand it a map of LayerID->CALayer so that it can look up related layers
for children and mask layers.

  • WebKit2.xcodeproj/project.pbxproj:

Add RemoteLayerTreePropertyApplier.{h,mm}

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::recursiveBuildTransaction):
Upon commit, apply changes to LayerTypeCustom layers to the platform layer.
Setting children or maskLayer won't work, since we don't know about other raw CALayers.
This is OK, since nothing uses those properties on custom layers.

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp:

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
Disable actions on the root custom layer.

1:21 PM Changeset in webkit [158690] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Begin work on a WKRemoteObjectDecoder object
https://bugs.webkit.org/show_bug.cgi?id=123819

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.h:
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder initWithRootObjectDictionary:]):
Add designated initializer.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
If the message has the expected name and body type, pass it along to -_invokeMessageWithBody:.

(-[WKRemoteObjectRegistry _invokeMessageWithBody:]):
Create a decoder.

1:17 PM Changeset in webkit [158689] by benjamin@webkit.org
  • 18 edits
    5 adds in trunk

[WK2] Add a WebKit2 API for Geolocation's highAccuracy
https://bugs.webkit.org/show_bug.cgi?id=123786

Reviewed by Darin Adler.

Source/WebKit2:

This adds support for highAccuracy Geolocation with WebKit2.

The key is to track which page/requester need what kind of geolocation
in order to change between high and low accuracy as pages run and disappear.

WebGeolocationManager and WebGeolocationManagerProxy have very similar roles
but for different sources:
-WebGeolocationManager tracks which live page require high accuracy geolocation.

When the state changes, it forward the information to the UIProcess.

-WebGeolocationManagerProxy tracks which WebContent processes needs high accuracy.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):
(WebKit::WebGeolocationManagerProxy::setEnableHighAccuracy):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebKit::WebGeolocationManagerProxy::isUpdating):
(WebKit::WebGeolocationManagerProxy::isHighAccuracyEnabled):

  • UIProcess/WebGeolocationManagerProxy.messages.in:
  • UIProcess/WebGeolocationProvider.cpp:

(WebKit::WebGeolocationProvider::setEnableHighAccuracy):

  • UIProcess/WebGeolocationProvider.h:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::setEnableHighAccuracyForPage):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebKit::WebGeolocationManager::isUpdating):
(WebKit::WebGeolocationManager::isHighAccuracyEnabled):

  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:

(WebKit::WebGeolocationClient::setEnableHighAccuracy):

Tools:

Add basic testing for the Geolocation API (start, stop and change accuracy).

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.

(TestWebKitAPI::operator<<):
(TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
(TestWebKitAPI::GeolocationStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
(TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
(TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
(TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
(TestWebKitAPI::setupGeolocationProvider):
(TestWebKitAPI::setupView):
(TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
(TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
(TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::didFinishLoadForFrame):

  • TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
  • TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
  • TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
  • TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
  • WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::GeolocationProviderMock):

1:16 PM Changeset in webkit [158688] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r158678.
http://trac.webkit.org/changeset/158678
https://bugs.webkit.org/show_bug.cgi?id=123820

Causes a new debug assertion failure on the Mavericks test
system. (Requested by bfulgham on #webkit).

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp:

LayoutTests:

  • TestExpectations:
  • mathml/presentation/mo-stretch.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:04 PM Changeset in webkit [158687] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix register allocation inside control flow in GetByVal String
https://bugs.webkit.org/show_bug.cgi?id=123816

Reviewed by Geoffrey Garen.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

1:03 PM Changeset in webkit [158686] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove FTL::LowerDFGToLLVM::compileJSConstant()
https://bugs.webkit.org/show_bug.cgi?id=123817

Reviewed by Geoffrey Garen.

  • ftl/FTLLowerDFGToLLVM.cpp:
12:56 PM Changeset in webkit [158685] by andersca@apple.com
  • 6 edits in trunk

Implement more NSCoder methods
https://bugs.webkit.org/show_bug.cgi?id=123815

Reviewed by Dan Bernstein.

Source/WebKit2:

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject):
Assert that object is not nil.

(createEncodedObject):
Handle nil objects.

(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
Call the right object stream encoding function based on the object type.

(-[WKRemoteObjectEncoder encodeBool:forKey:]):
(-[WKRemoteObjectEncoder encodeInt64:forKey:]):
(-[WKRemoteObjectEncoder encodeDouble:forKey:]):
Create APIObjects and add them to the current dictionary.

Tools:

Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:

(-[BundleObject testMethodWithArray:dictionary:request:]):

  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
11:34 AM Changeset in webkit [158684] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode the class name
https://bugs.webkit.org/show_bug.cgi?id=123813

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject):
Get the Class using -[NSObject classForCoder] and encode its name in the object dictionary.

11:24 AM Changeset in webkit [158683] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Clean up the WKRemoteObjectEncoder code
https://bugs.webkit.org/show_bug.cgi?id=123811

Reviewed by Dan Bernstein.

Add a new object stream array to be used for the non-keyed encoding values
and free functions for encoding values to the object stream. Simplify object encoding
by moving the dictionary creation out into a separate function and ditching the block based methods.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(ensureObjectStream):
Add helper function to create an object stream.

(encodeToObjectStream):
Add overloads for encoding values into the object streams.

(encodeInvocation):
Add helper function for encoding an NSInvocation.

(encodeObject):
Call encodeInvocation if needed, otherwise just use encodeWithCoder:.

(createEncodedObject):
Helper function that sets up a dictionary, encodes the object into the dictionary and then returns the dictionary.

(-[WKRemoteObjectEncoder encodeObject:forKey:]):
Call createEncodedObject.

11:16 AM Changeset in webkit [158682] by reni@webkit.org
  • 4 edits
    2 adds in trunk

ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in WebCore::Document::setTitle
https://bugs.webkit.org/show_bug.cgi?id=122092

Reviewed by Darin Adler.

Source/WebCore:

Remove a bogus assert in Document::setTitle().
m_titleElement can be either of HTMLTitleElement or SVGTitleElement. The assertion was wrong.

Backported from Blink:
https://src.chromium.org/viewvc/blink?revision=158620&view=revision

Test: svg/custom/title-assertion.html

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):

LayoutTests:

  • svg/custom/title-assertion-expected.txt: Added.
  • svg/custom/title-assertion.html: Added.
10:56 AM Changeset in webkit [158681] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

FTL should support PutById
https://bugs.webkit.org/show_bug.cgi?id=123784

Reviewed by Geoffrey Garen.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildCall):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::generateICFastPath):
(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheDescriptor.h:

(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::ecmaMode):
(JSC::FTL::PutByIdDescriptor::putKind):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePutById):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::call):

  • ftl/FTLSlowPathCall.cpp:

(JSC::FTL::callOperation):

  • ftl/FTLSlowPathCall.h:
  • ftl/FTLState.h:
  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ecmaMode):

10:53 AM Changeset in webkit [158680] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GetById->GetByOffset and PutById->PutByOffset folding should mark haveStructures since it may result in structure transition watchpoints
https://bugs.webkit.org/show_bug.cgi?id=123788

Reviewed by Geoffrey Garen.

haveStructures is true if there are any currentlyKnownStructures that have
interesting values, since that's the only time when clobbering needs to do things.
It's a really important compile-time optimization. But that also means that anytime
we might cause currentlyKnownStructures to get set - like when we might insert some
structure transition watchpoints - we need to set haveStructures. We were forgetting
to do that for GetById->GetByOffset and PutById->PutByOffset because, I guess, we
forgot that those might insert structure transition watchpoints.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

10:50 AM Changeset in webkit [158679] by fpizlo@apple.com
  • 3 edits in trunk/Tools

Update ReducedFTL
https://bugs.webkit.org/show_bug.cgi?id=123805

Reviewed by Sam Weinig.

  • Make ReducedFTL build with debug info.


  • Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding memory leaks and attaching a profiler.


  • Reorder the passes so that they match the FTL.


  • Make it possible to change the backend opt level and enable the fast isel.
  • ReducedFTL/ReducedFTL.c:

(usage):
(roundUpSize):
(mmAllocateCodeSection):
(main):

  • ReducedFTL/build.sh:
10:06 AM Changeset in webkit [158678] by mrobinson@webkit.org
  • 10 edits in trunk

[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837

Reviewed by Brent Fulgham.

Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the

normal variant.

LayoutTests:

  • mathml/presentation/mo-stretch.html: Reworked this test to show

stretching of all stretchable characters, which reveals a bug with
the double vertical bar (covered by http://wkbug.com/123543).

  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
10:05 AM Changeset in webkit [158677] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[mips] Make regTx registers match between JSInterfaceJIT and GPRInfo.
https://bugs.webkit.org/show_bug.cgi?id=123807

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Mark Lam.

  • jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):

  • jit/JSInterfaceJIT.h:
10:02 AM Changeset in webkit [158676] by dbates@webkit.org
  • 3 edits
    3 adds in trunk

XSSAuditor should catch reflected srcdoc properties even without a <frame> tag injection

From Blink r160615 by <tsepez@chromium.org>
https://src.chromium.org/viewvc/blink?view=rev&revision=160615

Source/WebCore:

Test: http/tests/security/xssAuditor/iframe-srcdoc-property-blocked.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterIframeToken):

LayoutTests:

  • http/tests/security/xssAuditor/iframe-srcdoc-property-blocked-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-srcdoc-property-blocked.html: Added.
  • http/tests/security/xssAuditor/resources/echo-frame-src.pl: Added.
8:23 AM Changeset in webkit [158675] by Michał Pakuła vel Rutka
  • 2 edits
    6 adds in trunk/LayoutTests

Unreviewed EFL gardening

Add baselines for tests marked as missing.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/css3/masking/mask-luminance-png-expected.txt: Added.
  • platform/efl/fast/css/color-correction-untagged-images-expected.png: Added.
  • platform/efl/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/efl/fast/regions/iframe-html-collected-expected.txt: Added.
  • platform/efl/fast/repaint/hover-pseudo-borders-expected.png: Added.
  • platform/efl/fast/repaint/hover-pseudo-borders-expected.txt: Added.
8:16 AM Changeset in webkit [158674] by Chris Fleizach
  • 8 edits in trunk/Tools

AX: switch DRT AX methods to use nullptr
https://bugs.webkit.org/show_bug.cgi?id=123773

Reviewed by Andreas Kling.

Switch AX related code in DRT and WKTR to use nullptr.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::classList):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::rangeForLine):
(AccessibilityUIElement::rangeForPosition):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::url):
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::previousTextMarker):
(AccessibilityUIElement::nextTextMarker):
(AccessibilityUIElement::stringForTextMarkerRange):
(AccessibilityUIElement::textMarkerRangeForMarkers):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::accessibilityElementForTextMarker):
(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):
(AccessibilityUIElement::supportedActions):
(AccessibilityUIElement::mathPostscriptsDescription):
(AccessibilityUIElement::mathPrescriptsDescription):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::findAccessibleObjectById):
(WTR::AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::classList):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
(WTR::AccessibilityUIElement::pathDescription):
(WTR::AccessibilityUIElement::supportedActions):

8:06 AM Changeset in webkit [158673] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebCore

Delete maketokenizer.
https://bugs.webkit.org/show_bug.cgi?id=115155

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-05
Reviewed by Zoltan Herczeg.

This script was used to generate the old flex based CSS tokenizer. It
was replaced by a custom tokenizer in r106217 but the script wasn't
removed. Since there is no mention of it in the original bug nor any
reference to maketokenizer in our build files, it's probably an
oversight.

Merge from blink:
https://chromium.googlesource.com/chromium/blink/+/2a1c8aaf867f707ccdcd8893446e907e2aa2e1c2

  • css/maketokenizer: Removed.
7:34 AM Changeset in webkit [158672] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r158315): Fix register mixup in JIT::compileOpCall.
https://bugs.webkit.org/show_bug.cgi?id=123799

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Mark Lam.

Changeset r158315 is crashing architectures where JSInterfaceJIT::regT3 is
different from GPRInfo::regT3. This is the case for MIPS architecture.

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

7:33 AM Changeset in webkit [158671] by commit-queue@webkit.org
  • 2 edits in trunk

Remove leftover Qt related things from WebKitMacros.cmake
https://bugs.webkit.org/show_bug.cgi?id=123798

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-05
Reviewed by Anders Carlsson.

  • Source/cmake/WebKitMacros.cmake:
7:32 AM Changeset in webkit [158670] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[mips] Fix build for MIPS platforms.
https://bugs.webkit.org/show_bug.cgi?id=123796

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Michael Saboff.

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::linkCode): Add specific MIPS call to relocateJumps.

  • assembler/MIPSAssembler.h: Remove executableCopy (because of r157690) and set relocateJumps function public.

(JSC::MIPSAssembler::firstRegister):
(JSC::MIPSAssembler::lastRegister):
(JSC::MIPSAssembler::firstFPRegister):
(JSC::MIPSAssembler::lastFPRegister):
(JSC::MIPSAssembler::buffer): Needed since r157690.

  • assembler/MacroAssemblerMIPS.h: Add framePointerRegister.

(JSC::MacroAssemblerMIPS::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameter warning.

7:31 AM Changeset in webkit [158669] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove leftover Qt related things from the flakiness_dashboard
https://bugs.webkit.org/show_bug.cgi?id=123800

Patch by László Langó <laszlo.lango@frontendart.com> on 2013-11-05
Reviewed by Anders Carlsson.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

7:30 AM Changeset in webkit [158668] by mihnea@adobe.com
  • 1 edit
    140 moves
    1 add in trunk/LayoutTests

[CSS Regions] Move cssom related tests into fast/regions/cssom
https://bugs.webkit.org/show_bug.cgi?id=123705

Reviewed by Sam Weinig.

Move tests related to http://dev.w3.org/csswg/css-regions/#cssom_view_and_css_regions into their own folder and adjust paths for resources used in tests.
They test the same functionality: CSSRegions and CSSOM-view.

  • fast/regions/cssom/element-region-overset-state-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-expected.txt.
  • fast/regions/cssom/element-region-overset-state-negative-letter-spacing-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt.
  • fast/regions/cssom/element-region-overset-state-negative-letter-spacing.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-negative-letter-spacing.html.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-expected.txt.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html.
  • fast/regions/cssom/element-region-overset-state-vertical-rl.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl.html.
  • fast/regions/cssom/element-region-overset-state.html: Renamed from LayoutTests/fast/regions/element-region-overset-state.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-rl.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect.html.
  • fast/regions/cssom/flowed-content-transform-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt.
  • fast/regions/cssom/flowed-content-transform-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-content-transform-bounding-client-rect.html.
  • fast/regions/cssom/flowed-inline-content-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-inline-content-bounding-client-rect-expected.txt.
  • fast/regions/cssom/flowed-inline-content-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-inline-content-bounding-client-rect.html.
  • fast/regions/cssom/get-region-flow-ranges-absolute-pos-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-absolute-pos.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-absolute-pos.html.
  • fast/regions/cssom/get-region-flow-ranges-content-nodes-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-content-nodes-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-content-nodes.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-content-nodes.html.
  • fast/regions/cssom/get-region-flow-ranges-display-none-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-display-none-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-display-none.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-display-none.html.
  • fast/regions/cssom/get-region-flow-ranges-empty-regions-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-empty-regions-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-empty-regions.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-empty-regions.html.
  • fast/regions/cssom/get-region-flow-ranges-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-fixed-pos-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-fixed-pos.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-fixed-pos.html.
  • fast/regions/cssom/get-region-flow-ranges-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-horiz-bt.html.
  • fast/regions/cssom/get-region-flow-ranges-inline-only-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-only-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-inline-only.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-only.html.
  • fast/regions/cssom/get-region-flow-ranges-inline-svg-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-svg-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-inline-svg.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-svg.html.
  • fast/regions/cssom/get-region-flow-ranges-text-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-text-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-text-vert-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-vert-lr.html.
  • fast/regions/cssom/get-region-flow-ranges-text.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text.html.
  • fast/regions/cssom/get-region-flow-ranges-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-vert-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-lr.html.
  • fast/regions/cssom/get-region-flow-ranges-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-rl-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-vert-rl.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-rl.html.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html.
  • fast/regions/cssom/get-region-flow-ranges.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges.html.
  • fast/regions/cssom/get-regions-by-content-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-expected.txt.
  • fast/regions/cssom/get-regions-by-content-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-bt-expected.txt.
  • fast/regions/cssom/get-regions-by-content-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-bt.html.
  • fast/regions/cssom/get-regions-by-content-horiz-tb-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-tb-expected.txt.
  • fast/regions/cssom/get-regions-by-content-horiz-tb.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-tb.html.
  • fast/regions/cssom/get-regions-by-content-pseudo-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-pseudo-expected.txt.
  • fast/regions/cssom/get-regions-by-content-pseudo.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-pseudo.html.
  • fast/regions/cssom/get-regions-by-content-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-lr-expected.txt.
  • fast/regions/cssom/get-regions-by-content-vert-lr.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-lr.html.
  • fast/regions/cssom/get-regions-by-content-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-rl-expected.txt.
  • fast/regions/cssom/get-regions-by-content-vert-rl.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-rl.html.
  • fast/regions/cssom/get-regions-by-content.html: Renamed from LayoutTests/fast/regions/get-regions-by-content.html.
  • fast/regions/cssom/get-regions-by-content2-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content2-expected.txt.
  • fast/regions/cssom/get-regions-by-content2.html: Renamed from LayoutTests/fast/regions/get-regions-by-content2.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-multiple-regions.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float.html.
  • fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-inlines-region-in-element-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html.
  • fast/regions/cssom/offsetParent-body-in-flow-thread-expected.txt: Renamed from LayoutTests/fast/regions/offsetParent-body-in-flow-thread-expected.txt.
  • fast/regions/cssom/offsetParent-body-in-flow-thread.html: Renamed from LayoutTests/fast/regions/offsetParent-body-in-flow-thread.html.
  • fast/regions/cssom/offsetParent-in-flow-thread-expected.txt: Renamed from LayoutTests/fast/regions/offsetParent-in-flow-thread-expected.txt.
  • fast/regions/cssom/offsetParent-in-flow-thread.html: Renamed from LayoutTests/fast/regions/offsetParent-in-flow-thread.html.
  • fast/regions/cssom/overset-break-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-expected.txt.
  • fast/regions/cssom/overset-break-nested-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-nested-expected.txt.
  • fast/regions/cssom/overset-break-nested.html: Renamed from LayoutTests/fast/regions/overset-break-nested.html.
  • fast/regions/cssom/overset-break-with-sibling-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-with-sibling-expected.txt.
  • fast/regions/cssom/overset-break-with-sibling.html: Renamed from LayoutTests/fast/regions/overset-break-with-sibling.html.
  • fast/regions/cssom/overset-break.html: Renamed from LayoutTests/fast/regions/overset-break.html.
  • fast/regions/cssom/region-range-for-box-crash-expected.txt: Renamed from LayoutTests/fast/regions/region-range-for-box-crash-expected.txt.
  • fast/regions/cssom/region-range-for-box-crash.html: Renamed from LayoutTests/fast/regions/region-range-for-box-crash.html.
  • fast/regions/cssom/webkit-named-flow-collection-crash-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-crash-expected.txt.
  • fast/regions/cssom/webkit-named-flow-collection-crash.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-crash.html.
  • fast/regions/cssom/webkit-named-flow-collection-empty-getters-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-empty-getters-expected.txt.
  • fast/regions/cssom/webkit-named-flow-collection-empty-getters.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-empty-getters.html.
  • fast/regions/cssom/webkit-named-flow-collection-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-expected.txt.
  • fast/regions/cssom/webkit-named-flow-collection.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection.html.
  • fast/regions/cssom/webkit-named-flow-event-add-to-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-add-to-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow.html.
  • fast/regions/cssom/webkit-named-flow-event-auto-height-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-auto-height-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-auto-height.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-auto-height.html.
  • fast/regions/cssom/webkit-named-flow-event-crash-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-crash-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-crash.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-crash.html.
  • fast/regions/cssom/webkit-named-flow-event-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-no-regions-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-no-regions-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-no-regions.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-no-regions.html.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-dom-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-dom.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom.html.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow.html.
  • fast/regions/cssom/webkit-named-flow-event-target-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-target-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-target.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-target.html.
  • fast/regions/cssom/webkit-named-flow-event-to-null-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-to-null-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-to-null.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-to-null.html.
  • fast/regions/cssom/webkit-named-flow-event.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event.html.
  • fast/regions/cssom/webkit-named-flow-existing-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-existing-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-existing-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-existing-flow.html.
  • fast/regions/cssom/webkit-named-flow-first-empty-region-index-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt.
  • fast/regions/cssom/webkit-named-flow-first-empty-region-index.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index.html.
  • fast/regions/cssom/webkit-named-flow-flow-added-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-flow-added-expected.txt.
  • fast/regions/cssom/webkit-named-flow-flow-added.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-flow-added.html.
  • fast/regions/cssom/webkit-named-flow-get-content-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-content-expected.txt.
  • fast/regions/cssom/webkit-named-flow-get-content.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-content.html.
  • fast/regions/cssom/webkit-named-flow-get-regions-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-expected.txt.
  • fast/regions/cssom/webkit-named-flow-get-regions-pseudo-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-pseudo-expected.txt.
  • fast/regions/cssom/webkit-named-flow-get-regions-pseudo.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-pseudo.html.
  • fast/regions/cssom/webkit-named-flow-get-regions.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions.html.
  • fast/regions/cssom/webkit-named-flow-invalid-name-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-invalid-name-expected.txt.
  • fast/regions/cssom/webkit-named-flow-invalid-name.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-invalid-name.html.
  • fast/regions/cssom/webkit-named-flow-modified-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-modified-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-modified-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-modified-flow.html.
  • fast/regions/cssom/webkit-named-flow-name-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-name-expected.txt.
  • fast/regions/cssom/webkit-named-flow-name.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-name.html.
  • fast/regions/cssom/webkit-named-flow-non-existing-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-non-existing-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-non-existing-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-non-existing-flow.html.
  • fast/regions/cssom/webkit-named-flow-overset-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-overset-expected.txt.
  • fast/regions/cssom/webkit-named-flow-overset.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-overset.html.
  • fast/regions/cssom/webkit-named-flow-removed-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-removed-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-removed-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-removed-flow.html.
  • fast/regions/cssom/webkit-named-flow-same-object-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-same-object-expected.txt.
  • fast/regions/cssom/webkit-named-flow-same-object.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-same-object.html.
7:25 AM Changeset in webkit [158667] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Unbreaking GCC builds.

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement): This inline function is not a template anymore.

6:50 AM Changeset in webkit [158666] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Two tests pass after r158575 and r15856.

  • platform/gtk/TestExpectations: Removed passing tests.
6:35 AM Changeset in webkit [158665] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Make it compile.

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::adoptDocument):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):

5:40 AM Changeset in webkit [158664] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] accessibility/svg-group-element-with-title.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114151

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-05
Reviewed by Mario Sanchez Prada.

Tools:

atk_component_ref_accessible_at_point(), utilized in
AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
accessible child, if one exists, at the coordinate point specified' and not
explicitly return self in case of lack of child elements. This contradicts with
expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
changed to return self regardless of coordinates specified, provided no child
element could be retrieved, effectively mimicing the behaviour of equivalent
Mac implementation in accessibilityHitTest().

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::elementAtPoint): Fixed.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::elementAtPoint): Fixed.

LayoutTests:

Removed failure expectation.

  • platform/efl/TestExpectations: The test is no longer failing.
5:20 AM Changeset in webkit [158663] by Antti Koivisto
  • 25 edits in trunk/Source/WebCore

HTMLCollection should not be NodeList
https://bugs.webkit.org/show_bug.cgi?id=123794

Reviewed by Andreas Kling.

HTMLCollection and NodeList are unrelated types in DOM yet our HTMLCollection inherits NodeList
for code sharing reasons. While some code does get shared the types are sufficiently different
that this results in lots of unnecessary branches, complexity and general awkwardness. Code sharing
can be better achieved by means other than inheritance.

This patch splits HTMLCollection from NodeList by copy-pasting and eliminating resulting redundancies.
Sharing comes later.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::~ClassNodeList):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childrenChanged):
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::registerNodeList):
(WebCore::Document::unregisterNodeList):
(WebCore::Document::registerCollection):
(WebCore::Document::unregisterCollection):
(WebCore::Document::ensureCachedCollection):

Add separate functions and map for registering HTMLCollections.

(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::Element::cachedHTMLCollection):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::rootNode):
(WebCore::isMatchingElement):
(WebCore::LiveNodeList::iterateForPreviousElement):
(WebCore::LiveNodeList::itemBefore):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::LiveNodeList::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeList::traverseLiveNodeListForwardToOffset):
(WebCore::LiveNodeList::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeList::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeList::length):
(WebCore::LiveNodeList::item):
(WebCore::LiveNodeList::elementBeforeOrAfterCachedElement):

This code used to live in HTMLCollection.cpp. Copy-paste here and remove all branches not needed for NodeLists.

(WebCore::LiveNodeList::invalidateCache):

NodeLists have no name caches.

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
(WebCore::LiveNodeList::isRootedAtDocument):
(WebCore::LiveNodeList::type):
(WebCore::LiveNodeList::invalidateCache):
(WebCore::LiveNodeList::setCachedElement):

Merge LiveNodeListBase and LiveNodeList.
Remove fields and code supporting HTMLCollection.

(WebCore::shouldInvalidateTypeOnAttributeChange):

Move to global scope. This function is used both HTMLCollections and LiveNodeLists.

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::~NameNodeList):

  • dom/NameNodeList.h:

(WebCore::NameNodeList::create):

  • dom/Node.cpp:

(WebCore::shouldInvalidateNodeListCachesForAttr):
(WebCore::Document::shouldInvalidateNodeListAndCollectionCaches):
(WebCore::Document::invalidateNodeListAndCollectionCaches):
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestors):
(WebCore::NodeListsNodeData::invalidateCaches):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::addCachedCollection):
(WebCore::NodeListsNodeData::cachedCollection):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::removeCachedCollection):
(WebCore::NodeListsNodeData::isEmpty):
(WebCore::NodeListsNodeData::adoptDocument):
(WebCore::NodeListsNodeData::namedCollectionKey):
(WebCore::NodeListsNodeData::namedNodeListKey):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):

Add separate cache for HTMLCollections.

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList):
(WebCore::TagNodeList::~TagNodeList):

  • dom/TagNodeList.h:

(WebCore::TagNodeList::create):
(WebCore::HTMLTagNodeList::create):

  • html/CollectionType.h:


Remove NodeList types.

  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::rootNode):
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::iterateForPreviousElement):
(WebCore::HTMLCollection::itemBefore):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::HTMLCollection::isLastItemCloserThanLastOrCachedItem):
(WebCore::HTMLCollection::isFirstItemCloserThanCachedItem):
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::elementBeforeOrAfterCachedElement):
(WebCore::HTMLCollection::traverseFirstElement):
(WebCore::HTMLCollection::traverseNextElement):
(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::invalidateIdNameCacheMaps):
(WebCore::HTMLCollection::namedItem):

Remove NodeList specific branches and functions.
LiveNodeListBase functions are now HTMLCollection functions.

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::isRootedAtDocument):
(WebCore::HTMLCollection::invalidationType):
(WebCore::HTMLCollection::type):
(WebCore::HTMLCollection::ownerNode):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::document):
(WebCore::HTMLCollection::overridesItemAfter):
(WebCore::HTMLCollection::isElementCacheValid):
(WebCore::HTMLCollection::cachedElement):
(WebCore::HTMLCollection::cachedElementOffset):
(WebCore::HTMLCollection::isLengthCacheValid):
(WebCore::HTMLCollection::cachedLength):
(WebCore::HTMLCollection::setLengthCache):
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::isItemRefElementsCacheValid):
(WebCore::HTMLCollection::setItemRefElementsCacheValid):
(WebCore::HTMLCollection::rootType):
(WebCore::HTMLCollection::hasNameCache):
(WebCore::HTMLCollection::setHasNameCache):

Copy-paste functions and fields from former LiveNodeListBase.

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::~HTMLNameCollection):

  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::~LabelsNodeList):

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::~RadioNodeList):

  • html/RadioNodeList.h:

(WebCore::RadioNodeList::create):

5:02 AM Changeset in webkit [158662] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Add stubs for missing symbols in dom bindings
https://bugs.webkit.org/show_bug.cgi?id=123663

Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-05
Reviewed by Carlos Garcia Campos.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_head_element_get_profile):
(webkit_dom_html_head_element_set_profile):
(webkit_dom_processing_instruction_get_data):
(webkit_dom_processing_instruction_set_data):

  • bindings/gobject/WebKitDOMCustom.h:
  • bindings/gobject/WebKitDOMCustom.symbols:
2:48 AM Changeset in webkit [158661] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Main thread tasks in ThreadableBlobRegistry should use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=122946

Reviewed by Darin Adler.

The new BlobRegistryContext objects don't have to be adopted into OwnPtr and then have OwnPtr's leaked pointer
passed into the WTF::callOnMainThread call - the pointer to the new heap-allocated object is passed in directly,
with the object ending up being managed by std::unique_ptr in the designated main thread task.

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::registerBlobURLFromTask):
(WebCore::unregisterBlobURLTask):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):

2:17 AM Changeset in webkit [158660] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update a test expected result.
https://bugs.webkit.org/show_bug.cgi?id=123792

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-05
Reviewed by Gyuyoung Kim.

Need to update some length properties in this expected file.
The test expected reseult is mismatched with return-values of eval() method in LayoutTests/resources/js-test-pre.js.

  • platform/efl/js/dom/constructor-length-expected.txt:
1:39 AM Changeset in webkit [158659] by gyuyoung.kim@samsung.com
  • 5 edits in trunk

[CSS] Enable css-image-orientation on EFL and GTK ports.
https://bugs.webkit.org/show_bug.cgi?id=123698

Reviewed by Beth Dakin.

Source/WebCore:

r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
when enabling css-image-orientation. This fixes those wrong implementation as well as enables it on EFL
and GTK ports by default.

Test: fast/css/image-orientation/image-orientation.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::updateSize):

Tools:

r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
and GTK ports by default.

  • Scripts/webkitperl/FeatureList.pm:
1:35 AM Changeset in webkit [158658] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] accessibility/tabindex-elements-are-accessible.html is failing after r158195
https://bugs.webkit.org/show_bug.cgi?id=123741

Unreviewed EFL gardening.

Patch by Artur Moryc <a.moryc@samsung.com> on 2013-11-05

  • platform/efl/TestExpectations: adding failing test
1:29 AM Changeset in webkit [158657] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

RenderEmbeddedObject shouldn't know about fallback content.
<https://webkit.org/b/123781>

Stop caching the presence of fallback (DOM) content in a flag on
RenderEmbeddedObject and have SubframeLoader fetch it directly from
HTMLObjectElement instead.

Also made SubframeLoader::requestObject() take the owner element
by reference since we don't support owner-less embedded objects.

Reviewed by Antti Koivisto.

1:08 AM Changeset in webkit [158656] by calvaris@igalia.com
  • 17 edits
    13 deletes in trunk/Source

[GStreamer] Remove NATIVE_FULLSCREEN_VIDEO support
https://bugs.webkit.org/show_bug.cgi?id=123437

Reviewed by Philippe Normand.

Source/WebCore:

Removed some dead code as no GStreamer port is using the native
fullscreen video support.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake: Removed compilation of deleted files.
  • platform/graphics/MediaPlayer.h: Removed structures related to

GStreamer and NATIVE_FULLSCREEN_VIDEO.

  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp: Removed.
  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.h: Removed.
  • platform/graphics/gstreamer/GStreamerGWorld.cpp: Removed.
  • platform/graphics/gstreamer/GStreamerGWorld.h: Removed.
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Removed

gst/video/video.h include.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformMedia):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Removed code related to GStreamer and NATIVE_FULLSCREEN_VIDEO.

  • platform/graphics/gstreamer/PlatformVideoWindow.h: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowMac.mm: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowNix.cpp: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Removed.
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender):
(webkitVideoSinkNew):

  • platform/graphics/gstreamer/VideoSinkGStreamer.h: Removed code

related to GStreamer and NATIVE_FULLSCREEN_VIDEO.

  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Removed.
  • platform/graphics/gtk/FullscreenVideoControllerGtk.h: Removed.

Source/WebCore/platform/gtk/po:

  • POTFILES.in: Removed FullscreenVideoControllerGtk.cpp.
  • gl.po: Removed appearances of strings of

FullscreenVideoControllerGtk.cpp.

Source/WebKit/efl:

Removed some dead code as no GStreamer port is using the native
fullscreen video support.

  • WebCoreSupport/FullscreenVideoControllerEfl.h: Removed.

Source/WebKit/gtk:

Removed some dead code as no GStreamer port is using the native
fullscreen video support.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientGtk.h: Removed code related to

GStreamer and NATIVE_FULLSCREEN_VIDEO.

12:53 AM Changeset in webkit [158655] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Remove RenderWidget::viewCleared().
<https://webkit.org/b/123777>

This was some ancient hand-waving code from the KHTML era.

It was obviously confused (e.g RenderEmbeddedObject trying to handle
iframe owners, even though that setup is impossible.)

Reviewed by Anders Carlsson.

Nov 4, 2013:

11:55 PM Changeset in webkit [158654] by beidson@apple.com
  • 21 edits
    2 copies
    4 adds in trunk/Source

IDB: Split backend Cursors and Transactions into their own files
https://bugs.webkit.org/show_bug.cgi?id=123789

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (Rename, no change in behavior).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBBackingStoreCursorInterface.h:

(WebCore::IDBBackingStoreCursorInterface::~IDBBackingStoreCursorInterface):

  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBBackingStoreTransactionInterface.h: Added.

(WebCore::IDBBackingStoreTransactionInterface::~IDBBackingStoreTransactionInterface):

  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):

  • Modules/indexeddb/IDBCursorBackendImpl.h:

(WebCore::IDBCursorBackendImpl::create):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBIndexWriter.cpp:

(WebCore::IDBIndexWriter::writeIndexKeys):
(WebCore::IDBIndexWriter::verifyIndexKeys):
(WebCore::IDBIndexWriter::addingKeyAllowed):

  • Modules/indexeddb/IDBIndexWriter.h:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::createCursorBackend):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::GetOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):

  • Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.cpp: Added.

(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::firstSeek):
(WebCore::IDBBackingStoreCursorLevelDB::advance):
(WebCore::IDBBackingStoreCursorLevelDB::continueFunction):
(WebCore::IDBBackingStoreCursorLevelDB::haveEnteredRange):
(WebCore::IDBBackingStoreCursorLevelDB::isPastBounds):

  • Modules/indexeddb/leveldb/IDBBackingStoreCursorLevelDB.h: Added.

(WebCore::IDBBackingStoreCursorLevelDB::~IDBBackingStoreCursorLevelDB):
(WebCore::IDBBackingStoreCursorLevelDB::IDBBackingStoreCursorLevelDB):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::compareIndexKeys):
(WebCore::IDBBackingStoreLevelDB::updateIDBDatabaseVersion):
(WebCore::IDBBackingStoreLevelDB::createObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteObjectStore):
(WebCore::IDBBackingStoreLevelDB::getRecord):
(WebCore::IDBBackingStoreLevelDB::putRecord):
(WebCore::IDBBackingStoreLevelDB::clearObjectStore):
(WebCore::IDBBackingStoreLevelDB::deleteRecord):
(WebCore::IDBBackingStoreLevelDB::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStoreLevelDB::keyExistsInObjectStore):
(WebCore::IDBBackingStoreLevelDB::createIndex):
(WebCore::IDBBackingStoreLevelDB::deleteIndex):
(WebCore::IDBBackingStoreLevelDB::putIndexDataForRecord):
(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::IDBBackingStoreLevelDB::findKeyInIndex):
(WebCore::IDBBackingStoreLevelDB::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStoreLevelDB::keyExistsInIndex):
(WebCore::ObjectStoreKeyCursorImpl::create):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreCursorImpl::create):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreCursor):
(WebCore::IDBBackingStoreLevelDB::openObjectStoreKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexKeyCursor):
(WebCore::IDBBackingStoreLevelDB::openIndexCursor):
(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp: Added.

(WebCore::IDBBackingStoreTransactionLevelDB::IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::begin):
(WebCore::IDBBackingStoreTransactionLevelDB::commit):
(WebCore::IDBBackingStoreTransactionLevelDB::rollback):

  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::createCursorBackend):

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::createCursorBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
11:09 PM Changeset in webkit [158653] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778

Unreviewed, remove the other such assertion.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

11:05 PM Changeset in webkit [158652] by ap@apple.com
  • 7 edits in trunk

DumpRenderTree should reset its preferences file on launch
https://bugs.webkit.org/show_bug.cgi?id=29751

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in DRT was through argument domain.

Source/WebKit2:

  • UIProcess/mac/WKFullKeyboardAccessWatcher.mm:

(-[WKFullKeyboardAccessWatcher retrieveKeyboardUIModeFromPreferences:]):
Further fix reading of AppleKeyboardUIMode - reading it from kCFPreferencesAnyApplication
domain meant that current application's domain was explcitly ignored, and the only
way to override the setting in WTR was through argument domain.

Tools:

Using NSArgumentDomain was not a good idea. While it works with NSUserDefaults
and CFPreferencesCopyAppValue family of functions, it doesn't work with
CFPreferencesCopyValue(..., kCFPreferencesCurrentApplication, ...).

So, now we'll just set defaults in the current application.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
  • Delete the defaults.
  • Removed CFPreferencesSetAppValue calls, as -setValuesForKeysWithDictionary: does the same.
  • The comment about [NSUserDefaults standardUserDefaults] indirectly initializing NSApplication was incorrect.
  • WebKitTestRunner/mac/main.mm: (setDefaultsToConsistentValuesForTesting):

Switched to -setValuesForKeysWithDictionary for consistency.

11:04 PM Changeset in webkit [158651] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Do not call setFrameRect on Widget unless its boundaries changed.
https://bugs.webkit.org/show_bug.cgi?id=123781

Reviewed by Andreas Kling.

Call Widget:setFrameRect only when the frame's rect actually changes. It also
cleans up the related weak reference code a bit.

Covered by existing tests.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

10:50 PM Changeset in webkit [158650] by commit-queue@webkit.org
  • 77 edits in trunk/Source/WebCore

[webcore/html] remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123740

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Darin Adler.

Removing redundant headers.

  • html/BaseDateAndTimeInputType.cpp:
  • html/ColorInputType.cpp:
  • html/DOMFormData.cpp:
  • html/DOMURL.cpp:
  • html/DateInputType.cpp:
  • html/DateTimeInputType.cpp:
  • html/DateTimeLocalInputType.cpp:
  • html/FTPDirectoryDocument.cpp:
  • html/FileInputType.cpp:
  • html/FormController.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAreaElement.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCollection.cpp:
  • html/HTMLDetailsElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLFormControlsCollection.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLInputElement.cpp:
  • html/HTMLLegendElement.cpp:
  • html/HTMLMapElement.cpp:
  • html/HTMLMediaElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/HTMLOptionsCollection.cpp:
  • html/HTMLPlugInImageElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/HTMLSummaryElement.cpp:
  • html/HTMLTemplateElement.cpp:
  • html/HTMLVideoElement.cpp:
  • html/HTMLViewSourceDocument.cpp:
  • html/MediaController.cpp:
  • html/MediaKeyEvent.cpp:
  • html/MonthInputType.cpp:
  • html/RangeInputType.cpp:
  • html/StepRange.cpp:
  • html/TextFieldInputType.cpp:
  • html/TimeInputType.cpp:
  • html/WeekInputType.cpp:
  • html/canvas/CanvasRenderingContext.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasStyle.cpp:
  • html/canvas/OESVertexArrayObject.cpp:
  • html/parser/BackgroundHTMLParser.cpp:
  • html/parser/CSSPreloadScanner.cpp:
  • html/parser/CompactHTMLToken.cpp:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLElementStack.cpp:
  • html/parser/HTMLFormattingElementList.cpp:
  • html/parser/HTMLMetaCharsetParser.cpp:
  • html/parser/HTMLParserIdioms.cpp:
  • html/parser/HTMLPreloadScanner.cpp:
  • html/parser/HTMLTokenizer.cpp:
  • html/parser/HTMLTreeBuilder.cpp:
  • html/parser/HTMLTreeBuilderSimulator.cpp:
  • html/parser/HTMLViewSourceParser.cpp:
  • html/parser/TextDocumentParser.cpp:
  • html/parser/XSSAuditor.cpp:
  • html/shadow/ContentDistributor.cpp:
  • html/shadow/InsertionPoint.cpp:
  • html/shadow/MediaControlElements.cpp:
  • html/shadow/MediaControlsApple.cpp:
  • html/shadow/MediaControlsBlackBerry.cpp:
  • html/shadow/MediaControlsGtk.cpp:
  • html/shadow/SliderThumbElement.cpp:
  • html/track/AudioTrack.cpp:
  • html/track/InbandGenericTextTrack.cpp:
  • html/track/InbandTextTrack.cpp:
  • html/track/InbandWebVTTTextTrack.cpp:
  • html/track/TextTrack.cpp:
  • html/track/TextTrackCueGeneric.cpp:
  • html/track/TextTrackList.cpp:
  • html/track/TextTrackRegion.cpp:
  • html/track/TrackListBase.cpp:
  • html/track/VideoTrack.cpp:
  • html/track/WebVTTParser.cpp:
10:16 PM Changeset in webkit [158649] by beidson@apple.com
  • 6 edits in trunk/Source/WebCore

IDB: deleteDatabase() interface should be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=123787

Reviewed by Tim Horton.

No new tests (No behavior change for a tested port).

deleteDatabase now has no return value, but calls back to a bool function:

  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::deleteDatabase):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:

Refactor to account for the new async deleteDatabase:

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::deleteDatabase):
(WebCore::IDBDatabaseBackendImpl::deleteDatabaseAsync):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:
10:06 PM Changeset in webkit [158648] by msaboff@apple.com
  • 5 edits in trunk

REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765

Source/JavaScriptCore:

We were leaving a hole of one slot above a new frame when pushing the new frame on
the stack with pushFrame(). This unused slot can contain residual values that will
be marked during GC.

Reviewed by Filip Pizlo.

  • interpreter/JSStackInlines.h:

(JSC::JSStack::pushFrame):

LayoutTests:

Reviewed by Filip Pizlo.

Reverted the test expectation changes after fixing the underlying issue.

9:52 PM Changeset in webkit [158647] by timothy_horton@apple.com
  • 11 edits
    2 adds in trunk/Source/WebKit2

Remote Layer Tree: Make LayerTypeCustom remote-host CALayers from the Web process
https://bugs.webkit.org/show_bug.cgi?id=123766

Reviewed by Anders Carlsson.

Put each LayerTypeCustom layer into a CAContext, so that we can
host small CALayer trees (for video, plugins, etc.) from the Web process
to the UI process without proxying their (more complex) content.

  • Shared/mac/RemoteLayerTreeTransaction.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::dump):
Store, encode, and dump the CAContext ID of custom layers.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::createLayer):
Create a CALayerHost with the CAContext ID from the Web process.

  • WebKit2.xcodeproj/project.pbxproj:

Add PlatformCALayerRemoteCustom.

  • WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
Call the newly-added custom-layer constructor.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:
  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::create):
(PlatformCALayerRemote::PlatformCALayerRemote):
Move the call to layerWasCreated() out to ::create(), so that all of
the constructors for this class and all subclasses have completed
before we call it (so that layerWasCreated() can store the context ID
in the created layer properties object).

(WebKit::PlatformCALayerRemote::hostingContextID):
Should never be reached on the base class, only PlatformCALayerRemoteCustom.

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp: Added.

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::hostingContextID):

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h: Added.

Add PlatformCALayerRemoteCustom, which owns a LayerHostingContext
which it will use to share a custom CALayer tree with the UI process.

  • WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:

Drive-by remove an unnecessary include.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::layerWasCreated):
Store the CAContext ID with the layer creation properties so it can
be used to create a CALayerHost upon commit in the UI process.

9:41 PM Changeset in webkit [158646] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

internal-js-tests.yaml/Octane/stress-tests/pdfjs.js.default: ASSERTION FAILED: m_state.forNode(child).m_futurePossibleStructure.isSubsetOf(StructureSet(structure)) at DFGConstantFoldingPhase.cpp:249
https://bugs.webkit.org/show_bug.cgi?id=123778

Reviewed by Geoffrey Garen.

This assertion was just wrong: ee do an execute() above the assertion. The assertion
is asserting that if we need a watchpoint (i.e. the best proven structure was not the
current structure) then it must be the future possible structure. But while that may
have been true before execute(), it won't be true after if the PutById was a
transition. Of course, this can only happen in the concurrent JIT in which case the
code would be invalidated anyway since we would only transform the code in a way that
leveraged the lack of a transition if we inserted a watchpoint, in which case we
would realize that the watchpoint had been fired during compilation.

Since this requires concurrent JIT awesomeness, I don't know how to test it.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

9:41 PM Changeset in webkit [158645] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Add Modules/indexeddb/leveldb to the WebCore.xcodeproj

Rubberstamped by Andreas Kling.

This will make hacking on IDB much easier for Mac developers as they won’t have
to constantly add and then subtract the leveldb subdirectory.

The USE(LEVELDB) flag is still disabled so these files won’t actually build by default.

  • WebCore.xcodeproj/project.pbxproj:
9:39 PM Changeset in webkit [158644] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG CheckArray(String) should just be a Phantom(String:)
https://bugs.webkit.org/show_bug.cgi?id=123779

Reviewed by Geoffrey Garen.

This should be a speed-up since Phantom(String:) is smart enough to use the string
structure. It should also be a simplification since CheckArray(String) was totally
redundant.

Also FixupPhase was assuming that it may see CheckArray's. That's wrong. It can
create CheckArray's but it won't see them as input since no previous phase can
create them.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::checkArray):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):

9:38 PM Changeset in webkit [158643] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Running FTL tests shouldn't reduce coverage on DFG tests
https://bugs.webkit.org/show_bug.cgi?id=123780

Reviewed by Geoffrey Garen.

  • Scripts/run-jsc-stress-tests:
9:20 PM Changeset in webkit [158642] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Address review feedback I forgot to commit in r158641

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls):

9:08 PM Changeset in webkit [158641] by beidson@apple.com
  • 6 edits in trunk/Source/WebCore

IDB: Make opening/establishing a database asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=123775

Reviewed by Andreas Kling.

No new tests (No behavior change for a tested port).

  • Modules/indexeddb/IDBBackingStoreInterface.h: Add getOrEstablishIDBDatabaseMetadata with a callback, removing getIDBDatabaseMetaData, getObjectStores, and createIDBDatabaseMetaData in the process.
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::getOrEstablishIDBDatabaseMetadata): Adapted from getIDBDatabaseMetaData,

implement the asynchronous interface in terms of other LevelDB methods, always calling back synchronously.

(WebCore::IDBBackingStoreLevelDB::createIDBDatabaseMetaData):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::create):
(WebCore::IDBDatabaseBackendImpl::openInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::didOpenInternalAsync): Broken off from openInternal.
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::processPendingOpenCalls): Broken off to allow didOpenInternalAsync

to perform open callbacks in the failure case.

(WebCore::IDBDatabaseBackendImpl::openConnection): Always queue open connection calls, then immediately processPendingCalls.
(WebCore::IDBDatabaseBackendImpl::openConnectionInternal): Actually perform open connection calls.

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:
9:04 PM Changeset in webkit [158640] by rniwa@webkit.org
  • 2 edits in trunk/Websites/test-results

Build fix. Update is_flaky when it's NULL.

  • public/include/test-results.php:
8:12 PM Changeset in webkit [158639] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

8:11 PM Changeset in webkit [158638] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.3

New Tag.

8:05 PM Changeset in webkit [158637] by rniwa@webkit.org
  • 3 edits in trunk/Websites/test-results

JSON generation on new flakiness dashboard is still too slow
https://bugs.webkit.org/show_bug.cgi?id=123776

Reviewed by Mark Rowe.

  • init-database.sql: Added a constraint that result is unique for each (build, test) pair.
  • public/include/test-results.php:

(ResultsJSONGenerator::generate): Don't sort results by latest_revision_time since that's done
in the client side anyway.
(update_flakiness_for_build): Don't update is_flaky flag if it's already set to the right value.

7:46 PM Changeset in webkit [158636] by Lucas Forschler
  • 2 edits in branches/safari-537.60-branch/Tools

Merged r157995. <rdar://problem/15390113>

7:45 PM Changeset in webkit [158635] by Lucas Forschler
  • 3 edits in branches/safari-537.60-branch/Tools

Merged r157815. <rdar://problem/15390113>

7:43 PM Changeset in webkit [158634] by Lucas Forschler
  • 3 edits in branches/safari-537.60-branch/Tools

Merged r157687. <rdar://problem/15390113>

7:42 PM Changeset in webkit [158633] by Lucas Forschler
  • 3 edits in branches/safari-537.60-branch/Tools

Merged r157553. <rdar://problem/15390113>

7:38 PM Changeset in webkit [158632] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Tools

Merged r154450. <rdar://problem/15390113>

7:31 PM Changeset in webkit [158631] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: RenderFrameBase's widget is always a FrameView.
<https://webkit.org/b/123771>

Delete widget() from RenderFrameBase and supplant a childView()
that returns FrameView*. Strip away unnecessary casts and asserts.

Reviewed by Antti Koivisto.

6:34 PM Changeset in webkit [158630] by zoltan@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Regions][CSS Shapes] Content in region doesn't respect shape-outside after initial layout pass
<https://webkit.org/b/114829>

Source/WebCore:

Although we set the size of a shape for shape-outside in RenderBlockFlow::insertFloatingObject based on the
float's size, the actual height of the float is not always resolved at that point. (Look at cases when the shape
has percentage based height or percentage based radius.) ShapeInfo::setShapeSize triggers a layout for 0 height
value, which will be overriden later, when RenderBlockFlow::positionNewFloats sets the actual size of the float (shape).
Thus it doesn't make sense to set the shape's size in insertFloatingObject and run those extra unnecessary layout passes,
since it'll be overriden anyways. I moved the shape size setting logic into RenderBlockFlow::positionNewFloats.

The problem showed up when we had a shape-outside ellipse with percentage based radius, and we inserted the content
with JavaScript into a region flow. The content has been layed out based on the 0 border radius, and relayout hasn't been
triggered when it flew into the flow. This change sets the shape size only when we already have the height of the float,
so the radius(es) can be resolved correctly, thus no unnecessary layout passes will happen and the layout will be correct as well.

Reviewed by David Hyatt.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::insertFloatingObject): Remove setting the size of the shape.
(WebCore::RenderBlockFlow::positionNewFloats): Set the size of the shape here.

LayoutTests:

Reviewed by David Hyatt.

  • fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html: Added.
6:14 PM Changeset in webkit [158629] by Samuel White
  • 2 edits in trunk/Source/WebCore

AX: AXShowMenu doesn't always work.
https://bugs.webkit.org/show_bug.cgi?id=123649

Reviewed by Chris Fleizach.

No new tests, the change occurs in a code path that forces the context menu to show which
locks up DRT if we try to test it (platform menu is shown). The change itself gives the mouse
event handler a chance to handle our platform mouse event BEFORE the event ends up in the show
context menu machinery. This is necessary because without it, the element will not become
focused. Without focus, accessibility shows different/less menu items than a mouse click. The
end result is that context menus shown via accessibility are consistent with menus shown via click.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenuAt):

5:45 PM Changeset in webkit [158628] by ap@apple.com
  • 3 edits in trunk/Source/WTF

Implement base64url encoding from RFC 4648
https://bugs.webkit.org/show_bug.cgi?id=123767

Reviewed by Sam Weinig.

No tests yet, will be covered by JWK tests for WebCrypto.

  • wtf/text/Base64.cpp:

(WTF::base64EncodeInternal):
(WTF::base64Encode):
(WTF::base64URLEncode):
(WTF::base64DecodeInternal):
(WTF::base64Decode):
(WTF::base64URLDecode):

  • wtf/text/Base64.h:

(WTF::base64URLEncode):

5:45 PM Changeset in webkit [158627] by jpfau@apple.com
  • 4 edits
    2 adds in trunk

SMIL timers can still fire after the containing document has been torn down
<https://webkit.org/b/123291>

Reviewed by Darin Adler.

Source/WebCore:

Ensure that the timers get paused when the document is preparing to be torn down.

Test: svg/animations/smil-timers-not-disabled-crash.html

  • dom/Document.cpp:

(WebCore::Document::dropChildren):
(WebCore::Document::commonTeardown):
(WebCore::Document::prepareForDestruction):

  • dom/Document.h:

LayoutTests:

Add a test that triggers the crash; unfortunately it triggers it after
the test is done, causing the next test to time out or crash.

  • svg/animations/smil-timers-not-disabled-crash-expected.txt: Added.
  • svg/animations/smil-timers-not-disabled-crash.html: Added.
5:37 PM Changeset in webkit [158626] by commit-queue@webkit.org
  • 19 edits
    1 copy in trunk/Source/WebCore

Move duplicate code in TrackPrivate classes to a common base class
https://bugs.webkit.org/show_bug.cgi?id=123619

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-04
Reviewed by Darin Adler.

No new tests because this is just refactoring.

  • GNUmakefile.list.am: Add TrackPrivateBase.
  • WebCore.vcxproj/WebCore.vcxproj: Same.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Same.
  • WebCore.xcodeproj/project.pbxproj: Same.
  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::inbandTrackIndex): Renamed audioTrackIndex() to trackIndex().
(WebCore::AudioTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::AudioTrack::languageChanged): Same.
(WebCore::AudioTrack::willRemove): Same.

  • html/track/AudioTrack.h: Update TrackPrivateBaseClient function signatures.
  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::inbandTrackIndex): Renamed textTrackIndex() to trackIndex().
(WebCore::InbandTextTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::InbandTextTrack::languageChanged): Same.
(WebCore::InbandTextTrack::willRemove): Same.

  • html/track/InbandTextTrack.h: Update TrackPrivateBaseClient function signatures.
  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::inbandTrackIndex): Renamed videoTrackIndex() to trackIndex().
(WebCore::VideoTrack::labelChanged): First argument is now a TrackPrivateBase*.
(WebCore::VideoTrack::languageChanged): Same.
(WebCore::VideoTrack::willRemove): Same.

  • html/track/VideoTrack.h: Update TrackPrivateBaseClient function signatures.
  • platform/graphics/AudioTrackPrivate.h: Remove code that was moved to TrackPrivateBase.
  • platform/graphics/InbandTextTrackPrivate.h: Same.
  • platform/graphics/InbandTextTrackPrivateClient.h: Same.
  • platform/graphics/VideoTrackPrivate.h: Same.
  • platform/graphics/TrackPrivateBase.h: Refactored out duplicate code in AudioTrackPrivate, InbandTextTrackPrivate and VideoTrackPrivate.
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Renamed textTrackIndex() to trackIndex().
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h: Same.
  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Renamed audioTrackIndex() to trackIndex().
  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Renamed videoTrackIndex() to trackIndex90.
5:33 PM Changeset in webkit [158625] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

FrameView destructor is worried about being retained by a renderer.
<https://webkit.org/b/123763>

There's no way we can be in ~FrameView() while also being owned by
a RenderWidget. Remove some overly paranoid code that was making sure
the renderer didn't have a reference on us.

Reviewed by Anders Carlsson.

5:33 PM Changeset in webkit [158624] by eric.carlson@apple.com
  • 4 edits in trunk

REGRESSION(r158311): media/media-fragments/TC0054.html and TC0061.html hit assertions
https://bugs.webkit.org/show_bug.cgi?id=123555

Reviewed by Darin Adler.

Source/WebCore:

No new tests, covered by existing tests.

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseFragments): Don't add a fragment with empty key or value as

they will not processed.

(WebCore::MediaFragmentURIParser::parseNPTFragment): Remove excess whitespace.

LayoutTests:

  • TestExpectations: Remove media/media-fragments/TC0054.html and media/media-fragments/TC0061.html.
5:31 PM Changeset in webkit [158623] by Patrick Gansterer
  • 13 edits in trunk/Source/WebCore

Remove code duplications in createFontCustomPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=123706

Reviewed by Darin Adler.

Move OpenTypeSanitizer and WOFF handling from the port specific
implementations in createFontCustomPlatformData() into the only
caller of this function CachedFont::ensureCustomFontData().
Also change the parameter passing the SharedBuffer from a
pointer to a reference since it is never null.

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):

  • platform/graphics/blackberry/FontCustomPlatformData.h:
  • platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/win/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/wince/FontCustomPlatformData.h:
5:31 PM Changeset in webkit [158622] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

5:28 PM Changeset in webkit [158621] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.5

New Tag.

5:26 PM Changeset in webkit [158620] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fixing MediaStreamDescriptor addSource and addTrack methods
https://bugs.webkit.org/show_bug.cgi?id=123755

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-04
Reviewed by Eric Carlson.

We must store the track and source that is passed as parameter in a RefPtr,
otherwise we will refer to a null pointer.

No new tests needed.

  • platform/mediastream/MediaStreamDescriptor.cpp:

(WebCore::MediaStreamDescriptor::addSource):
(WebCore::MediaStreamDescriptor::addTrack):

5:23 PM Changeset in webkit [158619] by timothy_horton@apple.com
  • 7 edits in trunk/Source

Remove PlatformCALayer::playerLayer
https://bugs.webkit.org/show_bug.cgi?id=123764

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::clone):
Remove playerLayer(), fold it into clone().

Source/WebKit2:

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Remove playerLayer().

5:12 PM Changeset in webkit [158618] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155130. <rdar://problem/15109454>

4:47 PM Changeset in webkit [158617] by Chris Fleizach
  • 17 edits
    4 adds in trunk

AX: Mail attachments at the start of an email are not output by VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123697

Reviewed by Ryosuke Niwa.

Source/WebCore:

VoiceOver is expecting that "replaced elements" (attachments in a Mail message in this case) to be
represented by the replacement character when asking for a stringForRange.

However, when that replaced element is at the beginning of the document, the logic does not work because
there is a few code places that will take that first Position and advance it forward, not accounting for replaced elements.
When using the TextIterator normally, it does account for these, so that's why it's only affecting as at the beginning of the document.

Also a "replaced element" can be more than just renderer->isReplaced(), hence the externing of the isRendererReplacedElement method
and using that it in pertinent places.

Tests: platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html

platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::replacedNodeNeedsCharacter):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(nsStringForReplacedNode):

  • dom/Position.cpp:

(WebCore::Position::isCandidate):

  • dom/PositionIterator.cpp:
  • dom/Range.cpp:

(WebCore::Range::firstNode):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • editing/TextIterator.h:

LayoutTests:

Add two flavors of this. One where the replaced element has rendered children and one where it does not,
which go down two different code paths.

  • platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start-expected.txt: Added.
  • platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html: Added.
  • platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start-expected.txt: Added.
  • platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html: Added.
4:46 PM Changeset in webkit [158616] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/wince

Change structure of frame tree in WINCE port.
https://bugs.webkit.org/show_bug.cgi?id=121079

Patch by Zhuang Zhigang <zhuangzg@cn.fujitsu.com> on 2013-11-04
Reviewed by Darin Adler.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::createFrame):

  • WebView.cpp:

(WebView::createFrame):

  • WebView.h:
4:46 PM Changeset in webkit [158615] by Lucas Forschler
  • 2 edits in branches/safari-537.60-branch/Source/WebCore

Merged r154180. <rdar://problem/15387843>

4:41 PM Changeset in webkit [158614] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

REGRESSION(r158586): plugins/refcount-leaks.html fails
https://bugs.webkit.org/show_bug.cgi?id=123765

Add the test expectation.

4:33 PM Changeset in webkit [158613] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebKit2

Merge change for <rdar://problem/15374298>.

4:15 PM Changeset in webkit [158612] by Lucas Forschler
  • 6 edits in branches/safari-537.60-branch/Source/WebCore

Merged r157773. <rdar://problem/15387840>

4:12 PM Changeset in webkit [158611] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Use RenderAncestorIterator in a couple of places.
<https://webkit.org/b/123725>

Take the ancestorsOfType<RenderMoo>() thingy out for a spin.

Found a bunch of parent chain walking loops that were really just
looking for the first ancestor renderer of a certain type.
They were a perfect fit for this pattern:

if (auto svgRoot = ancestorsOfType<RenderSVGRoot>(renderer).first())

svgRoot->shakeMoneyMaker();

Quite a bit clearer than the previous:

for (auto ancestor = renderer.parent(); ancestor; ancestor = ancestor->parent()) {

if (ancestor->isSVGRoot())

toRenderSVGRoot(ancestor)->makeMoneyShaker();

}

Reviewed by Antti Koivisto.

4:09 PM Changeset in webkit [158610] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WKRemoteObjectEncoder should escape keys
https://bugs.webkit.org/show_bug.cgi?id=123761

Reviewed by Tim Horton.

Keys that start with $ will be reserved for use by the coder, so prepend an extra
$ to keys that already start with $ to avoid clashes.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(escapeKey):
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectEncoder _encodeObjectForKey:usingBlock:]):

4:05 PM Changeset in webkit [158609] by Brent Fulgham
  • 7 edits in branches/safari-537.73-branch/Source/WebCore

Merge r157773

4:05 PM Changeset in webkit [158608] by fpizlo@apple.com
  • 3 edits
    6 adds in trunk

DFG NewArray/NewArrayBuffer shouldn't be constructing with negative indexing
https://bugs.webkit.org/show_bug.cgi?id=123760
<rdar://problem/15356705>

Reviewed by Mark Hahnenberg and Oliver Hunt.

Source/JavaScriptCore:

  • dfg/DFGOperations.cpp:

LayoutTests:

  • js/dfg-new-array-buffer-while-having-a-bad-time-expected.txt: Added.
  • js/dfg-new-array-buffer-while-having-a-bad-time.html: Added.
  • js/dfg-new-array-while-having-a-bad-time-expected.txt: Added.
  • js/dfg-new-array-while-having-a-bad-time.html: Added.
  • js/script-tests/dfg-new-array-buffer-while-having-a-bad-time.js: Added.

(foo):

  • js/script-tests/dfg-new-array-while-having-a-bad-time.js: Added.

(foo):

3:59 PM Changeset in webkit [158607] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r154180. <rdar://problem/15387809>

3:52 PM Changeset in webkit [158606] by jer.noble@apple.com
  • 5 edits
    1 add in trunk/Source/WebCore

[MSE] Add a SourceBufferPrivateClient interface for platform -> html communication.
https://bugs.webkit.org/show_bug.cgi?id=123373

Reviewed by Eric Carlson.

To enable communication between SourceBuffer and SourceBufferPrivate without introducing
layering violations, add a new interface class SourceBufferPrivateInterface from which
SourceBuffer will inherit.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Set the private's client.
(WebCore::SourceBuffer::~SourceBuffer): Clear the private's client.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Added stub.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Hinno.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasAudio): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateHasVideo): Ditto.

  • Modules/mediasource/SourceBuffer.h:
  • WebCore.xcodeproj/project.pbxproj: Add new files to project.
  • platform/graphics/SourceBufferPrivate.h:
  • platform/graphics/SourceBufferPrivateClient.h: Added.

(WebCore::SourceBufferPrivateClient::~SourceBufferPrivateClient): Empty destructor.

3:47 PM Changeset in webkit [158605] by dino@apple.com
  • 8 edits in branches/safari-537.73-branch

Merge r157299
<rdar://problem/15292359>

3:44 PM Changeset in webkit [158604] by Lucas Forschler
  • 4 edits in branches/safari-537.73-branch/Source

Merged r158602. <rdar://problem/15388203>

3:37 PM Changeset in webkit [158603] by Lucas Forschler
  • 4 edits in branches/safari-537.60-branch/Source

Merged r158602. <rdar://problem/15373550>

3:26 PM Changeset in webkit [158602] by Brent Fulgham
  • 4 edits in trunk/Source

../WebKit: [Win] Use VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758

Reviewed by Tim Horton.

  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Restore command to

call VersionStamper on final stage of build.

../WTF: [Win] User VersionStamper for official builds
https://bugs.webkit.org/show_bug.cgi?id=123758

Reviewed by Tim Horton.

  • WTF.vcxproj/WTFPostBuild.cmd: Add missing command to run VersionStamper.exe.
3:15 PM Changeset in webkit [158601] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merge fixes for <rdar://problem/15168240>.

3:03 PM Changeset in webkit [158600] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebKit2

[WK2] Update WebGeolocationManager to support multiple WebContent processes
https://bugs.webkit.org/show_bug.cgi?id=123658

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-11-04
Reviewed by Anders Carlsson.

Change WebGeolocationManagerProxy to track which WebProcessProxy needs geolocation.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::disconnectProcess):
WebContext::disconnectProcess does not handle ContextSupplement yet when using multiple
WebContent processes. Add an explicit call for WebGeolocationManagerProxy as a temporary
solution.

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::stopUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):

  • UIProcess/WebGeolocationManagerProxy.h:
  • UIProcess/WebGeolocationManagerProxy.messages.in:
2:53 PM Changeset in webkit [158599] by jer.noble@apple.com
  • 27 edits in trunk/Source

[PluginProxy] Add a setting to disable video plugin proxy support in HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=123621

Reviewed by Eric Carlson.

Source/WebCore:

Add a new Setting which will disable the video plugin proxy. Enable support for AVFoundation
in iOS (which requries fixing a few compile errors resulting from classes and methods which
are not available on iOS.

  • WebCore.exp.in: Export wkAVAssetResolvedURL.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement): Make conditional upon

new isVideoPluginProxyEnabled() setting.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Ditto.

  • html/HTMLMediaElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::createRenderer): Ditto.
(WebCore::HTMLVideoElement::attach): Ditto.
(WebCore::HTMLVideoElement::parseAttribute): Ditto.
(HTMLVideoElement::setDisplayMode): Ditto.

  • html/HTMLVideoElement.h:
  • page/Settings.cpp:

(WebCore::Settings::setVideoPluginProxyEnabled): Simple setter.

  • page/Settings.h:

(WebCore::Settings::isVideoPluginProxyEnabled): Simple getter.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Conditionally add MediaPlayerPrivateIOS and always add

MediaPlayerPriateAVFoundationObjC.

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::deliverNotification): Add default implementation.
(WebCore::MediaPlayerPrivateInterface::setMediaPlayerProxy): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Use new

HAS_ and USE_ macros instead of MAC_OS_MIN_VERNSION_REQUIRED.

(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer): Use cachedCGColor instead

of CGColorGetConstantColor.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Use CVPixelBuffer pixel

format constant instead of QuickDraw constant.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): Draw to intermediary

CGImage on iOS.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:

Source/WebKit/mac:

Add a new isVideoPluginProxyEnabled setting.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set isVideoPluginProxyEnabled preference.
(-[WebPreferences isVideoPluginProxyEnabled]): Pass through to Settings.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Set isVideoPluginProxyEnabled preference.

Source/WebKit2:

Add WebKit2 functions for setting then new isVideoPluginProxyEnabled preference.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetVideoPluginProxyEnabled):
(WKPreferencesGetVideoPluginProxyEnabled):

  • UIProcess/API/C/WKPreferences.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WTF:

Enable WTF_USE_AVFOUNDATION and add some HAVE_AVFOUNDATION_* defines
to replace the existing MAC_OS_X_VERSION_MIN_REQUIRED macros in
MediaPlayerPrivateAVFoundationObjC.mm.

  • wtf/Platform.h:
2:50 PM Changeset in webkit [158598] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r158561): fast/block/float/float-append-child-crash.html asserting.

The non-const ancestor iterator was walking siblings, not ancestors.

Rubber-stamped by Antti Koivisto.

2:49 PM Changeset in webkit [158597] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

[MSE] [Mac] Disclaim support for MSE in AVFoundation and QTKit engines
https://bugs.webkit.org/show_bug.cgi?id=123593

Reviewed by Eric Carlson.

Immediately fail if asked to load a Media Source in engines which do not support
them.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):

2:39 PM Changeset in webkit [158596] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Shapes] image valued shape element margin can cause an ASSERT fail
https://bugs.webkit.org/show_bug.cgi?id=123743

Reviewed by Andreas Kling.

Source/WebCore:

When margin-top is specified for a shape's element, the Y coordinates passed
to RasterShapeIntervals::getExcludedIntervals() may be negative. This is
because the incoming logical coordinates are relative to the content or
padding box, depending on the box-sizing property. The RasterShape::getExcludedIntervals()
method now clips the incoming Y coordinates to the shape's bounds before
accessing the shape's intervals.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::getExcludedIntervals):

LayoutTests:

Verify that an element with an image valued shape and a non-negative margin
does not cause an assertion failure.

  • fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-margin-crash.html: Added.
2:30 PM Changeset in webkit [158595] by andersca@apple.com
  • 7 edits in trunk

More WKRemoteObjectRegistry work
https://bugs.webkit.org/show_bug.cgi?id=123754

Reviewed by Dan Bernstein.

Source/WebKit2:

  • Shared/API/Cocoa/WKRemoteObjectCoder.h:
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectEncoder rootObjectDictionary]):
Add a getter for the root object dictionary.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Call _sendMessageWithBody:.
(-[WKRemoteObjectRegistry _sendMessageWithBody:]):
Call WebConnection::postMessage.

Tools:

  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:

(TestWebKitAPI::TEST):
Use the correct bundle test name. Call Util::run.

  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:

(-[BundleObject sayHello]):
(-[BundleObject testMethodWithString:double:integer:]):
Add BundleObject implementation. Register the bundle object with
the remote object registry. Call _handleMessageWithName:body: on the incoming message.

1:56 PM Changeset in webkit [158594] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r158404. <rdar://problem/15371809>

1:53 PM Changeset in webkit [158593] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r158061. <rdar://problem/15333281>

1:50 PM Changeset in webkit [158592] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537.73-branch

Merged r157436. <rdar://problem/15357233>

1:46 PM Changeset in webkit [158591] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r154897. <rdar://problem/15168237>

1:44 PM Changeset in webkit [158590] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r154851. <rdar://problem/15366090>

1:41 PM Changeset in webkit [158589] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r153087. <rdar://problem/15366093>

1:38 PM Changeset in webkit [158588] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r154851.

1:31 PM Changeset in webkit [158587] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

Make LiveNodeListBase use Elements instead of Nodes
https://bugs.webkit.org/show_bug.cgi?id=123745

Reviewed by Anders Carlsson.

  • WebCore.exp.in:
  • dom/Element.cpp:

(WebCore::Element::firstElementChild):
(WebCore::Element::lastElementChild):

Switch to correct calls. ElementTraversal::previous and previousChild are no longer equivalent.

  • dom/ElementTraversal.h:

(WebCore::::lastWithinTemplate):
(WebCore::::previousTemplate):

Fix ElementTraversal::lastWithin and previous. They had no real clients and didn't work correctly.
With LiveNodeListBase starting to use these they get excellent test coverage.

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeListBase::invalidateCache):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::isElementCacheValid):
(WebCore::LiveNodeListBase::cachedElement):
(WebCore::LiveNodeListBase::cachedElementOffset):
(WebCore::LiveNodeListBase::setCachedElement):

Make the cache Element based.
Switch to Elements in all helpers.
Rename item -> element for clarity.

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::updateForNodeRemoval):

This code expected the old inconsistent NodeTraversal::previous behavior where the traversal includes
the root as the last item. Drop the stayWithin parameter and handle the one case where it is needed here.

  • dom/NodeTraversal.cpp:

(WebCore::NodeTraversal::last):
(WebCore::NodeTraversal::deepLastChild):

  • dom/NodeTraversal.h:


Support ElementTraversal::previous/lastWithin.

(WebCore::NodeTraversal::previous):

This was slightly wrong too.

  • html/HTMLCollection.cpp:

(WebCore::previousElement):
(WebCore::lastElement):
(WebCore::LiveNodeListBase::iterateForPreviousElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeListBase::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeListBase::setCachedElement):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::elementBeforeOrAfterCachedElement):

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::isEmpty):
(WebCore::HTMLCollection::hasExactlyOneItem):

1:28 PM Changeset in webkit [158586] by msaboff@apple.com
  • 28 edits in trunk/Source

Eliminate HostCall bit from JSC Stack CallerFrame
https://bugs.webkit.org/show_bug.cgi?id=123642

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Replace the HostCallFrame bit or'ed to the CallerFrame value in a CallFrame with
a VM entry sentinel CallFrame. Logically, the VM entry sentinel call frame is
pushed on the stack before the callee frame when calling from native to JavaScript
code. The callee frame's CallerFrame points at the VM entry sentinel call frame
and the VM entry sentinel call frame's CallerFrame points to the real caller.
The VM entry sentinel call frame has a sentinel (1) in the CodeBlock to indicate
its a VM entry sentinel call frame. It's ScopeChain has vm.topCallFrame at the
time of the call. This allows for a complete stack walk as well as walking just
the contiguous JS frames.

The VM entry sentinel call frame and callee frame are currently allocated and
initialized in ExecState::init(), but this initialization will be moved to
ctiTrampoline when we actually move onto the native stack.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::noticeIncomingCall):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::callerFrame):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

  • interpreter/CallFrame.h:

(JSC::ExecState::frameExtent):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
(JSC::ExecState::init):
(JSC::ExecState::noCaller):
(JSC::ExecState::isVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCallerFrame):
(JSC::ExecState::initializeVMEntrySentinelFrame):
(JSC::ExecState::callerFrameSkippingVMEntrySentinel):
(JSC::ExecState::vmEntrySentinelCodeBlock):

  • interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::Interpreter::getStackTrace):

  • interpreter/Interpreter.h:

(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):

  • interpreter/JSStack.cpp:

(JSC::JSStack::~JSStack):

  • interpreter/JSStackInlines.h:

(JSC::JSStack::getStartOfFrame):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):

  • interpreter/Register.h:

(JSC::Register::operator=):
(JSC::Register::callFrame):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readFrame):
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::print):

  • interpreter/VMInspector.cpp:

(JSC::VMInspector::countFrames):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JITOperations.cpp:
  • jit/JITStubsARM.h:

(JSC::ctiTrampoline):

  • jit/JITStubsARM64.h:
  • jit/JITStubsARMv7.h:

(JSC::ctiTrampoline):

  • jit/JITStubsMIPS.h:
  • jit/JITStubsMSVC64.asm:
  • jit/JITStubsSH4.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
  • jsc.cpp:

(functionDumpCallFrame):

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::throwException):

Source/WebCore:

Updated JavaScript stack walking as a result of the corresponding changes made in
JavaScriptCore.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::stepOutOfFunction):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::didExecuteProgram):

12:15 PM Changeset in webkit [158585] by rniwa@webkit.org
  • 3 edits in trunk/Websites/test-results

Build fixes. In particular, we were missing the code to generate JSONs in report.php :(

  • public/api/report.php:
  • public/include/test-results.php:
12:12 PM Changeset in webkit [158584] by Bem Jones-Bey
  • 41 edits in trunk

[css shapes] Fix support for shape-outside on a float with padding
https://bugs.webkit.org/show_bug.cgi?id=123590

Reviewed by Alexandru Chiculita.

Source/WebCore:

The line top was being improperly converted to the coordinates of the
shape, causing the shape to be positioned incorrectly when the float
had padding. This fixes that problem.

No new tests, covered by updates to existing ones.

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

LayoutTests:

Fix existing tests that depended on the incorrect behavior so that
they are now testing the proper thing. Also fix up the tests to make
them clearer and more robust.

  • csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-000.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-005.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-006.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-007.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-008.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-009.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000-expected.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
  • csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
11:52 AM Changeset in webkit [158583] by mhahnenberg@apple.com
  • 8 edits
    3 adds in trunk

JSArrayBufferViews of length 0 allocate 0 CopiedSpace bytes, which is invalid
https://bugs.webkit.org/show_bug.cgi?id=123746

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch disallows clients from allocating 0 bytes in CopiedSpace. We enforce this invariant
with an ASSERT in C++ code and a breakpoint in JIT code. Clients who care about 0-byte
allocations (like JSArrayBufferViews) must handle that case themselves, but we don't punish
anybody else for the rare case that somebody decides to allocate a 0-length typed array.
It also makes the allocation and copying cases consistent for CopiedSpace: no 0-byte allocations,
no 0-byte copying.

Also added a check so that JSArrayBufferViews don't try to copy their m_vector backing store when
their length is 0. Also sprinkled several ASSERTs throughout the JSArrayBufferView code to make sure that
when length is 0 m_vector is null.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewTypedArray):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateBasicStorage):

  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::tryAllocate):

  • runtime/ArrayBuffer.h:

(JSC::ArrayBuffer::create):

  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::::visitChildren):
(JSC::::copyBackingStore):
(JSC::::slowDownAndWasteMemory):

LayoutTests:

Added a test to make sure that we don't crash when allocating a typed array with 0 length.

  • js/script-tests/typedarray-zero-size.js: Added.

(foo):

  • js/typedarray-zero-size-expected.txt: Added.
  • js/typedarray-zero-size.html: Added.
10:45 AM Changeset in webkit [158582] by ap@apple.com
  • 17 edits
    6 copies in trunk

Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-generate-key.html

crypto/subtle/hmac-generate-key.html

  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.

  • bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.
  • crypto/CryptoAlgorithmAesKeyGenParams.h: Added.
  • crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
  • crypto/CryptoKey.h:
  • crypto/CryptoKeyMac.cpp: Added

Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.

  • crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
  • crypto/CryptoKeyAES.h:

Added a function that creates AES keys.

  • crypto/SubtleCrypto.idl: Added generateKey.
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::generateKey): Added.

  • crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
  • crypto/keys/CryptoKeyHMAC.h:

Added a function that creates HMAC keys.

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation

ended up in cross-platform file.

  • crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.

LayoutTests:

  • crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
  • crypto/subtle/aes-cbc-generate-key.html: Added.
  • crypto/subtle/hmac-generate-key-expected.txt: Added.
  • crypto/subtle/hmac-generate-key.html: Added.
  • crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,

a different exception is raised.

10:42 AM Changeset in webkit [158581] by dbates@webkit.org
  • 4 edits in trunk/Source/WebCore

Revert SetCGFontRenderingMode() build fix for Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=123633

Reviewed by Darin Adler.

Reverts <http://trac.webkit.org/changeset/134380>, which
was a Chromium Mac build fix for <http://trac.webkit.org/changeset/134348>
(https://bugs.webkit.org/show_bug.cgi?id=101787). Chromium doesn't
build against top-of-tree WebKit.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
10:21 AM Changeset in webkit [158580] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Refactor jumps in baseline JIT to return label after the jump.
https://bugs.webkit.org/show_bug.cgi?id=123734

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-04
Reviewed by Michael Saboff.

Current implementation of jumps in sh4 baseline JIT returns a label on the jump itself
and not after it. This is not correct and leads to issues like infinite loop the DFG
(https://bugs.webkit.org/show_bug.cgi?id=122597 for instance). This refactor fixes this
and also simplifies the link and relink procedures for sh4 jumps.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchDouble):
(JSC::MacroAssemblerSH4::branchTrue):
(JSC::MacroAssemblerSH4::branchFalse):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::extraInstrForBranch):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::bra):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::relinkJump):

10:03 AM Changeset in webkit [158579] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebKit/gtk

[GTK][WK1] Enable CSS Regions if feature flag is set to TRUE
https://bugs.webkit.org/show_bug.cgi?id=123739

Reviewed by Martin Robinson.

In WK1 CSS Regions were always disabled even if you set the feature flag
ENABLE_CSS_REGIONS to TRUE. Enabling CSS Regions support in that case.

  • webkit/webkitwebview.cpp:

(webkit_web_view_update_settings): Enable CSS Regions if feautre flag is
set to TRUE.

9:37 AM Changeset in webkit [158578] by commit-queue@webkit.org
  • 17 edits
    6 deletes in trunk

Unreviewed, rolling out r158526.
http://trac.webkit.org/changeset/158526
https://bugs.webkit.org/show_bug.cgi?id=123744

it broke the build (Requested by jessieberlin on #webkit).

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createAesCbcParams):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):

  • bindings/js/JSSubtleCryptoCustom.cpp:
  • crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
  • crypto/CryptoKey.cpp:
  • crypto/CryptoKey.h:
  • crypto/CryptoKeyAES.cpp:
  • crypto/CryptoKeyAES.h:
  • crypto/CryptoKeyMac.cpp: Removed.
  • crypto/SubtleCrypto.idl:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:
  • crypto/keys/CryptoKeyHMAC.cpp:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::generateKey):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::generateKey):

LayoutTests:

  • crypto/subtle/aes-cbc-generate-key-expected.txt: Removed.
  • crypto/subtle/aes-cbc-generate-key.html: Removed.
  • crypto/subtle/hmac-generate-key-expected.txt: Removed.
  • crypto/subtle/hmac-generate-key.html: Removed.
  • crypto/subtle/sha-1-expected.txt:
8:08 AM Changeset in webkit [158577] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Change ATK version to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123727

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.

Provided new API to retrieve text at a given offset.

  • efl/jhbuild.modules:
8:04 AM Changeset in webkit [158576] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] accessibility/textarea-line-for-index.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112015

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.

Tools:

Provided implementation for AccessibilityUIElement::lineForIndex().

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::lineForIndex): Implemented.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::lineForIndex): Implemented.

LayoutTests:

Removed failure expectations.

  • platform/efl-wk1/TestExpectations: The test is no longer failing.
  • platform/efl-wk2/TestExpectations: The test is no longer failing.
7:02 AM Changeset in webkit [158575] by commit-queue@webkit.org
  • 6 edits in trunk

[EFL] accessibility/button-press-action.html
https://bugs.webkit.org/show_bug.cgi?id=111993

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-04
Reviewed by Mario Sanchez Prada.

Tools:

Provided an implementation for AccessibilityUIElement::isPressActionSupported.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isPressActionSupported):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectations.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
6:58 AM Changeset in webkit [158574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] Remove redundant calls in CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=123737

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-04
Reviewed by Noam Rosenthal.

Removing unused code left after few refactoring patches.

No new tests. Covered by existing ones.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):

5:01 AM Changeset in webkit [158573] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CSSPrimitiveValue color constructors should return PassRef.
<https://webkit.org/b/123728>

Make CSSPrimitiveValue::createColor() and the corresponding
CSSValuePool helper functions return PassRef<CSSPrimitiveValue>.

Also made CSSValuePool slightly less stupid when hitting the upper
size limit on the color value cache: instead of throwing out cache
and rebuilding it from scratch, just remove one value at random.

Reviewed by Antti Koivisto.

4:55 AM Changeset in webkit [158572] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Some more RenderChildIterator deployment.
<https://webkit.org/b/123735>

Convert another handful of loops to use childrenOfType<RenderFoo>
iterators, mostly for skipping over uninteresting text renderers.

Reviewed by Antti Koivisto.

4:43 AM Changeset in webkit [158571] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

LabelsNodeList always is always rooted at a LabelableElement.
<https://webkit.org/b/123730>

Tighten up LabelsNodeList by enforcing that it's only rooted to
a LabelableElement. Also marked the class FINAL and made its
create() helper return PassRef.

Reviewed by Antti Koivisto.

4:40 AM Changeset in webkit [158570] by akling@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION: RenderStyle is leaked when not creating renderer for display:none
<https://webkit.org/b/123726>

Source/WebCore:

Explicitly drop the RenderStyle reference in RenderElement::createFor
if we decide to not create any renderer.

Reviewed by Antti Koivisto.

Test: fast/css/renderstyle-leak-with-display-none.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

LayoutTests:

Reviewed by Antti Koivisto.

  • fast/css/renderstyle-leak-with-display-none-expected.txt: Added.
  • fast/css/renderstyle-leak-with-display-none.html: Added.
4:25 AM Changeset in webkit [158569] by commit-queue@webkit.org
  • 65 edits in trunk/Source/WebCore

[webcore/dom] Remove extra header includes from cpp files.
https://bugs.webkit.org/show_bug.cgi?id=123720

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-11-04
Reviewed by Andreas Kling.

Removing redundant headers from dom related cpp files.

  • dom/Attr.cpp:
  • dom/CharacterData.cpp:
  • dom/ChildListMutationScope.cpp:
  • dom/ChildNodeList.cpp:
  • dom/ContainerNode.cpp:
  • dom/ContainerNodeAlgorithms.cpp:
  • dom/DOMNamedFlowCollection.cpp:
  • dom/DatasetDOMStringMap.cpp:
  • dom/Document.cpp:
  • dom/DocumentEventQueue.cpp:
  • dom/DocumentMarkerController.cpp:
  • dom/DocumentOrderedMap.cpp:
  • dom/DocumentStyleSheetCollection.cpp:
  • dom/Element.cpp:
  • dom/ElementRareData.cpp:
  • dom/Event.cpp:
  • dom/EventContext.cpp:
  • dom/EventDispatcher.cpp:
  • dom/EventTarget.cpp:
  • dom/ExceptionBase.cpp:
  • dom/FocusEvent.cpp:
  • dom/InlineStyleSheetOwner.cpp:
  • dom/KeyboardEvent.cpp:
  • dom/LiveNodeList.cpp:
  • dom/MessageEvent.cpp:
  • dom/MessagePort.cpp:
  • dom/MouseRelatedEvent.cpp:
  • dom/MutationEvent.cpp:
  • dom/MutationObserver.cpp:
  • dom/MutationObserverInterestGroup.cpp:
  • dom/MutationObserverRegistration.cpp:
  • dom/MutationRecord.cpp:
  • dom/NameNodeList.cpp:
  • dom/NamedFlowCollection.cpp:
  • dom/NamedNodeMap.cpp:
  • dom/Node.cpp:
  • dom/NodeIterator.cpp:
  • dom/NodeTraversal.cpp:
  • dom/PositionIterator.cpp:
  • dom/ProcessingInstruction.cpp:
  • dom/Range.cpp:
  • dom/RegisteredEventListener.cpp:
  • dom/ScopedEventQueue.cpp:
  • dom/ScriptElement.cpp:
  • dom/ScriptRunner.cpp:
  • dom/SelectorQuery.cpp:
  • dom/ShadowRoot.cpp:
  • dom/StyledElement.cpp:
  • dom/TagNodeList.cpp:
  • dom/Text.cpp:
  • dom/TextEvent.cpp:
  • dom/TouchEvent.cpp:
  • dom/TreeScope.cpp:
  • dom/TreeScopeAdopter.cpp:
  • dom/TreeWalker.cpp:
  • dom/UIEvent.cpp:
  • dom/UserActionElementSet.cpp:
  • dom/UserTypingGestureIndicator.cpp:
  • dom/VisitedLinkState.cpp:
  • dom/WebKitNamedFlow.cpp:
4:22 AM Changeset in webkit [158568] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

HTMLAllCollection is always rooted at a Document.
<https://webkit.org/b/123724>

Tighten up HTMLAllCollection by making the constructor take a
Document& instead of a ContainerNode&. Drive-by application of
FINAL and PassRef also happened.

Reviewed by Antti Koivisto.

4:21 AM Changeset in webkit [158567] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

Make more CSSValue subclass constructors return PassRef.
<https://webkit.org/b/123731>

Make the constructor helpers for the following classes return
PassRef instead of PassRefPtr:

  • CSSFontValue
  • CSSImageSetValue
  • CSSUnicodeRangeValue
  • WebKitCSSArrayFunctionValue
  • WebKitCSSFilterValue
  • WebKitCSSMatFunctionValue
  • WebKitCSSMixFunctionValue
  • WebKitCSSShaderValue
  • WebKitCSSTransformValue

Reviewed by Antti Koivisto.

4:16 AM Changeset in webkit [158566] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Buildfix after r158182 for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=123442

Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-04
Reviewed by Csaba Osztrogonác.

Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)

  • dom/ScopedEventQueue.h:
1:16 AM Changeset in webkit [158565] by rniwa@webkit.org
  • 7 edits in trunk/Websites/test-results

Fix JSON generations on new flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=123723

Reviewed by Andreas Kling.

Add is_flaky column on results table so that this column can be used to find flaky tests on a given builder
efficiently without having to through results for all tests in PHP. This column is updated in report.php
when a new build is added. Because is_flaky depends on the preceding and succeeding results, we must update
is_flaky flag on results for builds immediately before and after the new build as well.

To see why, suppose we had two consecutive results [PASS] [PASS]. If we were to insert [FAIL] result between
the two, those two results may also turn into flaky results if they were surrounded by [FAIL]. Similarly,
if we had [PASS] [FAIL] and the second result was marked flaky, inserting new [FAIL] must unmark it.

  • init-database.sql: Added is_flaky column to results table with an index. Also added an index on

build_revisions.time as many queries filter results by this quantity. Also set the work_mem to 50MB avoid
disk thrashing while sorting results in various queries.

  • public/api/failing-tests.php: Handle builder ids as well as names. Call generate() with failure types.

No longer generates *-failing.json since it's a subset of *-wrongexpectations.json to save time.

  • public/api/report.php: Rewritten. Calls update_flakiness_after_inserting_build to update is_flaky flags

on the newly added results.
(store_results): Added.
(main): Added.

  • public/include/test-results.php:

(ResultsJSONWriter):
(ResultsJSONWriter::add_results_for_test): Renamed from add_results_for_test_if_matches.
(ResultsJSONGenerator::generate): Takes the failure type. Instead of generating JSONs for all failure types
at once, generate one JSON for the specified type. We generate the list of test ids based on the failure type
and query results based on that. This dramatically cuts down the time spent in PHP.
(ResultsJSONGenerator::latest_build): Added.
(ResultsJSONGenerator::write_jsons): Takes single writer now.
(update_flakiness_for_build): Added.
(update_flakiness_after_inserting_build): Added.

  • public/index.html:

(TestResultsView._populateBuilderPane): Emulate *-failing.json upon *-wrongexpectations.json.
(TestResultsView.fetchFailingTestsForBuilder): Ditto.

  • public/main.css: Minor style tweaks.

(.testResults): Extend the border that wraps the test results as needed.
(.tooltip): Don't wrap text inside tooltips.

12:53 AM Changeset in webkit [158564] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

HTMLTableRowsCollection is always rooted at a HTMLTableElement.
<https://webkit.org/b/123721>

Tighten up HTMLTableRowsCollection by making the create() helper
take a HTMLTableElement& and adding a HTMLSelectElement& getter.

Reviewed by Antti Koivisto.

12:51 AM Changeset in webkit [158563] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

HTMLNameCollection and friends are always rooted at a Document.
<https://webkit.org/b/123722>

Tighten WindowNameCollection and DocumentNameCollection by making
their constructors take a Document&, and add a slightly better
document() than the one we inherit from LiveNodeListBase.

Also marked the classes FINAL and made create() helpers return
PassRef instead of PassRefPtr.

Reviewed by Antti Koivisto.

12:49 AM Changeset in webkit [158562] by akling@apple.com
  • 1 edit
    11 moves
    12 deletes in trunk/LayoutTests

Optimize baselines: svg/zoom

Unreviewed; run "webkit-patch optimize-baselines svg/zoom"

  • platform/gtk/svg/zoom/page/zoom-background-images-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-as-image-expected.png: Removed.
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Removed.
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Removed.
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Removed.
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
  • svg/zoom/page/zoom-background-images-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-background-images-expected.txt.
  • svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt.
  • svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt.
  • svg/zoom/page/zoom-mask-with-percentages-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt.
  • svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.
  • svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt.
  • svg/zoom/page/zoom-svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-as-image-expected.png.
  • svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/page/zoom-svg-float-border-padding-expected.txt.
  • svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Removed.
  • svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
  • svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt.
  • svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Renamed from LayoutTests/platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt.
12:46 AM Changeset in webkit [158561] by akling@apple.com
  • 13 edits
    1 add in trunk/Source/WebCore

Add an ancestor renderer iterator.
<https://webkit.org/b/123718>

Add ancestor iterators for renderers, analogous to element ancestor
iterators. They walk the chain of parent renderers, stopping at each
ancestor of a certain type.

Just like child renderer iterators, this requires isRendererOfType()
to be implemented for the targeted renderer class.

You use them like this:

auto frameSets = ancestorsOfType<RenderFrameSet>(*this);
for (auto frameSet = frameSets.begin(), end = frameSets.end(); frameSet != end; ++frameSet)

frameSet->thisOrThat();

To complete the patch, I put them to use in a couple of random places.

Reviewed by Antti Koivisto.

12:40 AM Changeset in webkit [158560] by akling@apple.com
  • 2 edits
    14 moves
    2 adds
    11 deletes in trunk/LayoutTests

Optimize baselines: fast/images

Unreviewed; run "webkit-patch optimize-baselines fast/images"

  • fast/images/crossfade-client-not-removed-crash-expected.txt:
  • fast/images/embed-image-expected.png: Renamed from LayoutTests/platform/efl/fast/images/embed-image-expected.png.
  • fast/images/exif-orientation-css-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-css-expected.txt.
  • fast/images/exif-orientation-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/exif-orientation-expected.txt.
  • fast/images/icon-decoding-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/icon-decoding-expected.txt.
  • fast/images/image-in-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.png.
  • fast/images/image-in-map-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/image-in-map-expected.txt.
  • fast/images/imagemap-focus-ring-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-zoom-expected.txt.
  • fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/gtk/fast/images/support-broken-image-delegate-expected.txt.
  • platform/efl-wk2/fast/images/imagemap-circle-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-circle-focus-ring-expected.png.
  • platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-expected.png.
  • platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png.
  • platform/efl-wk2/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.png.
  • platform/efl-wk2/fast/images/imagemap-polygon-focus-ring-expected.png: Renamed from LayoutTests/platform/efl/fast/images/imagemap-polygon-focus-ring-expected.png.
  • platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
  • platform/gtk/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
  • platform/gtk/fast/images/embed-image-expected.png: Removed.
  • platform/gtk/fast/images/exif-orientation-css-expected.txt: Removed.
  • platform/gtk/fast/images/icon-decoding-expected.txt: Removed.
  • platform/gtk/fast/images/image-in-map-expected.png: Removed.
  • platform/gtk/fast/images/image-in-map-expected.txt: Removed.
  • platform/gtk/fast/images/imagemap-focus-ring-zoom-expected.txt: Removed.
  • platform/mac/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
  • platform/mac/fast/images/exif-orientation-css-expected.txt: Removed.
  • platform/mac/fast/images/exif-orientation-expected.txt: Removed.
  • platform/win-7sp0/fast/images/support-broken-image-delegate-expected.txt: Renamed from LayoutTests/platform/win/fast/images/support-broken-image-delegate-expected.txt.
12:28 AM Changeset in webkit [158559] by mihnea@adobe.com
  • 7 edits in trunk/Source/WebCore

[CSSRegions] Use auto keyword to clean-up for loops
https://bugs.webkit.org/show_bug.cgi?id=123699

Reviewed by Anders Carlsson.

Start using auto keyword for loops.
Also, since region breaks (forced breaks) can be added only on boxes,
i changed RenderFlowThread::addForcedRegionBreak to use a RenderBox* instead of RenderObject*.

No change in functionality, no new tests.

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::firstEmptyRegionIndex):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::styleDidChange):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoConstrainedPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoOverflowPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsIntoFinalPhase):
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::hasCompositingRegionDescendant):
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::updateLayerToRegionMappings):
(WebCore::RenderFlowThread::updateLogicalWidth):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::repaintRectangleInRegions):
(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
(WebCore::RenderFlowThread::getRegionRangeForBox):
(WebCore::RenderFlowThread::regionInRange):
(WebCore::RenderFlowThread::checkRegionsWithStyling):
(WebCore::RenderFlowThread::objectInFlowRegion):
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout):
(WebCore::RenderFlowThread::markRegionsForOverflowLayoutIfNeeded):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
(WebCore::RenderFlowThread::collectLayerFragments):
(WebCore::RenderFlowThread::fragmentsBoundingBox):
(WebCore::RenderFlowThread::addRegionsVisualEffectOverflow):
(WebCore::RenderFlowThread::addRegionsVisualOverflowFromTheme):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsLayoutOverflow):
(WebCore::RenderFlowThread::clearRegionsOverflow):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::dependsOn):
(WebCore::addRegionToList):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::pushDependencies):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::restoreRegionObjectsOriginalStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):

12:12 AM GStreamer/GStreamerOnMac edited by Philippe Normand
(diff)

Nov 3, 2013:

11:10 PM Changeset in webkit [158558] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

PingLoader objects unnecessarily pass through OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=122942

Reviewed by Darin Adler.

There's no need to store new PingLoader objects into an OwnPtr just to leak them out a few lines later
into an unused variable. New objects are created through a new helper method and then left unmanaged as
they're guaranteed to destroy themselves when they receive a response of any kind.

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage): Call the new createPingLoader method to spawn the PingLoader.
(WebCore::PingLoader::sendPing): Ditto.
(WebCore::PingLoader::sendViolationReport): Ditto.
(WebCore::PingLoader::createPingLoader): A helper method that creates a new PingLoader object

  • loader/PingLoader.h: Declare the new PingLoader::createPingLoader method.
11:02 PM MathML 3 testsuite results edited by ahoos@apple.com
updating msqrt tests 6,7,8 to reflect progress. (diff)
10:55 PM MathML 3 testsuite results edited by ahoos@apple.com
updating mrow test 2 to reflect progress. (diff)
10:54 PM Changeset in webkit [158557] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

HTMLOptionsCollection is always rooted at a HTMLSelectElement.
<https://webkit.org/b/123719>

Tighten up HTMLOptionsCollection by making the constructor take
a HTMLSelectElement& and adding a HTMLSelectElement& getter instead
of casting all over the place. Removed now-pointless assertions.

Reviewed by Sam Weinig.

10:53 PM MathML 3 testsuite results edited by ahoos@apple.com
Updated test results for mover 7,8,10,11,12 to reflect progress. (diff)
10:50 PM MathML 3 testsuite results edited by ahoos@apple.com
Updated test results for mover 1-5 to reflect progress. (diff)
9:55 PM MathML 3 testsuite results edited by ahoos@apple.com
Updated mfrac results for tests 2,3, and 4. (diff)
8:24 PM Changeset in webkit [158556] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Generated color wheel displays incorrectly (regressed in r155567)
https://bugs.webkit.org/show_bug.cgi?id=123664

Source/JavaScriptCore:

Reviewed by Andreas Kling.

Interestingly, r155567 just "un-broke" the attempt to constant-fold ArithMod, but
that constant folding was just wrong to begin with. There is no evidence that this
constant folding rule is profitable. I'm removing it instead of trying to think
about what it means for it to be correct.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

LayoutTests:

Reviewed by Andreas Kling.

  • js/dfg-mod-1-expected.txt: Added.
  • js/dfg-mod-1.html: Added.
  • js/script-tests/dfg-mod-1.js: Added.

(foo):

8:12 PM Changeset in webkit [158555] by akling@apple.com
  • 1 edit
    66 moves
    70 deletes in trunk/LayoutTests

Optimize baselines: fast/repaint

Unreviewed; run "webkit-patch optimize-baselines fast/repaint"

  • fast/repaint/4774354-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/4774354-expected.txt.
  • fast/repaint/absolute-position-changed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/absolute-position-changed-expected.png.
  • fast/repaint/block-selection-gap-stale-cache-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-2-expected.png.
  • fast/repaint/block-selection-gap-stale-cache-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/block-selection-gap-stale-cache-expected.png.
  • fast/repaint/box-shadow-inset-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt.
  • fast/repaint/button-spurious-layout-hint-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/button-spurious-layout-hint-expected.png.
  • fast/repaint/canvas-putImageData-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/canvas-putImageData-expected.png.
  • fast/repaint/clip-with-layout-delta-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/clip-with-layout-delta-expected.txt.
  • fast/repaint/content-into-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/content-into-overflow-expected.png.
  • fast/repaint/erase-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/erase-overflow-expected.png.
  • fast/repaint/fixed-after-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-after-scroll-expected.png.
  • fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-and-absolute-position-scrolled-expected.png.
  • fast/repaint/fixed-position-transparency-with-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-position-transparency-with-overflow-expected.png.
  • fast/repaint/fixed-scale-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scale-expected.png.
  • fast/repaint/fixed-scroll-simple-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-scroll-simple-expected.png.
  • fast/repaint/fixed-table-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-cell-expected.png.
  • fast/repaint/fixed-table-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-expected.png.
  • fast/repaint/fixed-table-overflow-zindex-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-table-overflow-zindex-expected.png.
  • fast/repaint/fixed-tranformed-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/fixed-tranformed-expected.png.
  • fast/repaint/float-in-new-block-with-layout-delta-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/float-in-new-block-with-layout-delta-expected.png.
  • fast/repaint/float-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-expected.txt.
  • fast/repaint/float-overflow-right-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/float-overflow-right-expected.txt.
  • fast/repaint/inline-block-resize-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-block-resize-expected.png.
  • fast/repaint/inline-horizontal-bt-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-horizontal-bt-overflow-expected.txt.
  • fast/repaint/inline-vertical-lr-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.png.
  • fast/repaint/inline-vertical-lr-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-lr-overflow-expected.txt.
  • fast/repaint/inline-vertical-rl-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.png.
  • fast/repaint/inline-vertical-rl-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/inline-vertical-rl-overflow-expected.txt.
  • fast/repaint/intermediate-layout-position-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/intermediate-layout-position-clip-expected.png.
  • fast/repaint/japanese-rl-selection-clear-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt.
  • fast/repaint/japanese-rl-selection-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt.
  • fast/repaint/layer-hide-when-needs-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-hide-when-needs-layout-expected.png.
  • fast/repaint/layer-visibility-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/layer-visibility-expected.png.
  • fast/repaint/line-in-scrolled-clipped-block-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/line-in-scrolled-clipped-block-expected.txt.
  • fast/repaint/moving-shadow-on-path-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-path-expected.txt.
  • fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png.
  • fast/repaint/overflow-clip-subtree-layout-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-clip-subtree-layout-expected.png.
  • fast/repaint/overflow-into-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-into-content-expected.png.
  • fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png.
  • fast/repaint/reflection-repaint-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/reflection-repaint-test-expected.txt.
  • fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • fast/repaint/repaint-during-scroll-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-expected.png.
  • fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt.
  • fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-absolute-layer-with-reflection-expected.png.
  • fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
  • fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-layer-with-reflection-expected.png.
  • fast/repaint/scroll-fixed-reflected-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-fixed-reflected-layer-expected.png.
  • fast/repaint/scroll-in-clipped-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-clipped-layer-expected.png.
  • fast/repaint/scroll-in-fixed-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/scroll-in-fixed-layer-expected.png.
  • fast/repaint/subtree-root-clip-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-2-expected.png.
  • fast/repaint/subtree-root-clip-3-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-3-expected.png.
  • fast/repaint/subtree-root-clip-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/subtree-root-clip-expected.png.
  • fast/repaint/table-cell-vertical-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/table-cell-vertical-overflow-expected.txt.
  • fast/repaint/table-col-background-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-col-background-expected.png.
  • fast/repaint/table-outer-border-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-outer-border-expected.png.
  • fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png.
  • fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
  • fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png.
  • fast/repaint/table-row-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-row-expected.png.
  • fast/repaint/table-section-overflow-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/table-section-overflow-expected.png.
  • fast/repaint/transform-layout-repaint-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/transform-layout-repaint-expected.txt.
  • fast/repaint/view-background-from-body-1-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-1-expected.png.
  • fast/repaint/view-background-from-body-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/view-background-from-body-2-expected.png.
  • platform/efl-wk2/fast/repaint/selection-after-delete-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-delete-expected.png.
  • platform/efl-wk2/fast/repaint/selection-after-remove-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-after-remove-expected.png.
  • platform/efl-wk2/fast/repaint/selection-gap-overflow-scroll-2-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/selection-gap-overflow-scroll-2-expected.png.
  • platform/gtk/fast/repaint/4774354-expected.txt: Removed.
  • platform/gtk/fast/repaint/absolute-position-changed-expected.png: Removed.
  • platform/gtk/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Removed.
  • platform/gtk/fast/repaint/block-selection-gap-stale-cache-expected.png: Removed.
  • platform/gtk/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/button-spurious-layout-hint-expected.png: Removed.
  • platform/gtk/fast/repaint/canvas-putImageData-expected.png: Removed.
  • platform/gtk/fast/repaint/clip-with-layout-delta-expected.txt: Removed.
  • platform/gtk/fast/repaint/content-into-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/erase-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-after-scroll-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-scale-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-scroll-simple-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-table-cell-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-table-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-table-overflow-zindex-expected.png: Removed.
  • platform/gtk/fast/repaint/fixed-tranformed-expected.png: Removed.
  • platform/gtk/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Removed.
  • platform/gtk/fast/repaint/inline-block-resize-expected.png: Removed.
  • platform/gtk/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/intermediate-layout-position-clip-expected.png: Removed.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/layer-hide-when-needs-layout-expected.png: Removed.
  • platform/gtk/fast/repaint/layer-visibility-expected.png: Removed.
  • platform/gtk/fast/repaint/line-in-scrolled-clipped-block-expected.txt: Removed.
  • platform/gtk/fast/repaint/moving-shadow-on-path-expected.txt: Removed.
  • platform/gtk/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
  • platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.png: Removed.
  • platform/gtk/fast/repaint/overflow-into-content-expected.png: Removed.
  • platform/gtk/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
  • platform/gtk/fast/repaint/reflection-repaint-test-expected.txt: Removed.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
  • platform/gtk/fast/repaint/repaint-during-scroll-expected.png: Removed.
  • platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Removed.
  • platform/gtk/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Removed.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Removed.
  • platform/gtk/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Removed.
  • platform/gtk/fast/repaint/scroll-fixed-reflected-layer-expected.png: Removed.
  • platform/gtk/fast/repaint/scroll-in-clipped-layer-expected.png: Removed.
  • platform/gtk/fast/repaint/scroll-in-fixed-layer-expected.png: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-2-expected.png: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-3-expected.png: Removed.
  • platform/gtk/fast/repaint/subtree-root-clip-expected.png: Removed.
  • platform/gtk/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
  • platform/gtk/fast/repaint/table-col-background-expected.png: Removed.
  • platform/gtk/fast/repaint/table-outer-border-expected.png: Removed.
  • platform/gtk/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Removed.
  • platform/gtk/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Removed.
  • platform/gtk/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Removed.
  • platform/gtk/fast/repaint/table-row-expected.png: Removed.
  • platform/gtk/fast/repaint/table-section-overflow-expected.png: Removed.
  • platform/gtk/fast/repaint/transform-layout-repaint-expected.txt: Removed.
  • platform/gtk/fast/repaint/view-background-from-body-1-expected.png: Removed.
  • platform/gtk/fast/repaint/view-background-from-body-2-expected.png: Removed.
  • platform/mac-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
  • platform/mac/fast/repaint/box-shadow-inset-repaint-expected.txt: Removed.
  • platform/mac/fast/repaint/float-overflow-expected.txt: Removed.
  • platform/mac/fast/repaint/float-overflow-right-expected.txt: Removed.
  • platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Removed.
  • platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Removed.
  • platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Removed.
  • platform/mac/fast/repaint/table-cell-vertical-overflow-expected.txt: Removed.
  • platform/win/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Removed.
7:21 PM Changeset in webkit [158554] by fpizlo@apple.com
  • 5 edits in trunk

Source/JavaScriptCore: Unreviewed, it is no longer necessary to call DisablePrettyStackTrace.

  • llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

WebKitLibraries: Update binary drops to a version that includes my pretty stack trace changes.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
7:01 PM Changeset in webkit [158553] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707

Reviewed by Geoff Garen and Anders Carlsson.

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.

  • Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::entries): Added this accessor.

6:57 PM Changeset in webkit [158552] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

Reverted r158538.

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray copyWithZone:]):

  • Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary copyWithZone:]):

  • Shared/ImmutableArray.h:
4:39 PM Changeset in webkit [158551] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

RenderTextFragment: Tighten first-letter logic.
<https://webkit.org/b/123714>

Reviewed by Antti Koivisto.

  • editing/TextIterator.cpp:

(WebCore::firstRenderTextInFirstLetter):

Use iterator helper to find first RenderText child.

(WebCore::TextIterator::handleTextNodeFirstLetter):

Tightening through type inference.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):

  • rendering/RenderTextFragment.h:

The first letter renderer is always a RenderBoxModelObject,
so make the code deal in that instead of RenderObject.

  • rendering/RenderChildIterator.h:

(WebCore::RenderChildIteratorAdapter::first):
(WebCore::RenderChildIteratorAdapter::last):

Remove excess ampersands that were keeping this from building.

4:35 PM Changeset in webkit [158550] by akling@apple.com
  • 2 edits
    2 copies
    12 moves
    2 adds
    13 deletes in trunk/LayoutTests

Optimize baselines: fast/forms

Unreviewed; run "webkit-patch optimize-baselines fast/forms"

  • fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
  • fast/forms/fieldset-with-float-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/fieldset-with-float-expected.txt.
  • fast/forms/input-no-renderer-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/input-no-renderer-expected.txt.
  • fast/forms/label/labelable-elements-expected.txt: Renamed from LayoutTests/platform/gtk/fast/forms/label/labelable-elements-expected.txt.
  • fast/forms/range/slider-thumb-stylability-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/range/slider-thumb-stylability-expected.png.
  • fast/forms/select-listbox-multiple-no-focusring-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-listbox-multiple-no-focusring-expected.txt.
  • fast/forms/select-overflow-scroll-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-expected.txt.
  • fast/forms/select-overflow-scroll-inherited-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/select-overflow-scroll-inherited-expected.txt.
  • fast/forms/textfield-overflow-by-value-update-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.png.
  • fast/forms/textfield-overflow-by-value-update-expected.txt: Renamed from LayoutTests/platform/efl/fast/forms/textfield-overflow-by-value-update-expected.txt.
  • platform/efl-wk2/fast/forms/validation-message-appearance-expected.png: Renamed from LayoutTests/platform/efl/fast/forms/validation-message-appearance-expected.png.
  • platform/gtk/fast/forms/fieldset-with-float-expected.txt: Removed.
  • platform/gtk/fast/forms/input-no-renderer-expected.txt: Removed.
  • platform/gtk/fast/forms/range/slider-thumb-stylability-expected.png: Removed.
  • platform/gtk/fast/forms/select-listbox-multiple-no-focusring-expected.txt: Removed.
  • platform/gtk/fast/forms/select-overflow-scroll-expected.txt: Removed.
  • platform/gtk/fast/forms/select-overflow-scroll-inherited-expected.txt: Removed.
  • platform/gtk/fast/forms/textfield-overflow-by-value-update-expected.png: Removed.
  • platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
  • platform/mac/fast/forms/label/labelable-elements-expected.txt: Removed.
  • platform/mac/fast/forms/textfield-overflow-by-value-update-expected.txt: Removed.
  • platform/win-7sp0/fast/forms/cursor-at-editable-content-boundary-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt.
  • platform/win-7sp0/fast/forms/implicit-submission-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/implicit-submission-expected.txt.
  • platform/win-7sp0/fast/forms/range/slider-mouse-events-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/range/slider-mouse-events-expected.txt.
  • platform/win-7sp0/fast/forms/select-popup-pagekeys-expected.txt: Renamed from LayoutTests/platform/win/fast/forms/select-popup-pagekeys-expected.txt.
  • platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Removed.
4:15 PM Changeset in webkit [158549] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

CSSPrimitiveValue identifier constructors should return PassRef.
<https://webkit.org/b/123712>

Make CSSPrimitiveValue::createIdentifier() and the corresponding
CSSValuePool helper return PassRef<CSSPrimitiveValue>.

Reviewed by Antti Koivisto.

4:13 PM Changeset in webkit [158548] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Use RenderChildIterator in two more loops.
<https://webkit.org/b/123713>

Switch two more renderer child traversal loops to childrenOfType.

Reviewed by Antti Koivisto.

3:43 PM Changeset in webkit [158547] by akling@apple.com
  • 2 edits
    36 moves
    2 adds
    36 deletes in trunk/LayoutTests

Optimize baselines: editing

Unreviewed; run "webkit-patch optimize-baselines editing"

  • editing/deleting/delete-3775172-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/deleting/delete-3775172-fix-expected.png.
  • editing/deleting/delete-after-span-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-001-expected.txt.
  • editing/deleting/delete-after-span-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-002-expected.txt.
  • editing/deleting/delete-after-span-ws-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-after-span-ws-003-expected.txt.
  • editing/deleting/delete-at-start-or-end-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-at-start-or-end-expected.txt.
  • editing/deleting/delete-br-002-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-002-expected.txt.
  • editing/deleting/delete-br-004-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-004-expected.txt.
  • editing/deleting/delete-br-005-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-005-expected.txt.
  • editing/deleting/delete-br-006-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/delete-br-006-expected.txt.
  • editing/deleting/delete-line-end-ws-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-001-expected.txt.
  • editing/deleting/delete-line-end-ws-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/deleting/delete-line-end-ws-002-expected.txt.
  • editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt:
  • editing/inserting/insert-3851164-fix-expected.png: Renamed from LayoutTests/platform/efl/editing/inserting/insert-3851164-fix-expected.png.
  • editing/selection/5195166-1-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/5195166-1-expected.txt.
  • editing/selection/editable-links-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/editable-links-expected.txt.
  • editing/selection/focus-body-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/focus-body-expected.txt.
  • editing/selection/select-all-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-001-expected.txt.
  • editing/selection/select-all-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-002-expected.txt.
  • editing/selection/select-all-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-003-expected.txt.
  • editing/selection/select-all-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/select-all-004-expected.txt.
  • editing/selection/unrendered-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-001-expected.txt.
  • editing/selection/unrendered-002-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-002-expected.txt.
  • editing/selection/unrendered-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-003-expected.txt.
  • editing/selection/unrendered-004-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-004-expected.txt.
  • editing/selection/unrendered-005-expected.txt: Renamed from LayoutTests/platform/efl/editing/selection/unrendered-005-expected.txt.
  • editing/undo/5378473-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/5378473-expected.txt.
  • editing/undo/undo-misspellings-expected.txt: Renamed from LayoutTests/platform/efl/editing/undo/undo-misspellings-expected.txt.
  • editing/unsupported-content/table-delete-001-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-001-expected.txt.
  • editing/unsupported-content/table-delete-003-expected.png: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.png.
  • editing/unsupported-content/table-delete-003-expected.txt: Renamed from LayoutTests/platform/efl/editing/unsupported-content/table-delete-003-expected.txt.
  • platform/efl-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Renamed from LayoutTests/platform/efl/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt.
  • platform/efl/editing/caret/caret-color-expected.txt: Renamed from LayoutTests/editing/caret/caret-color-expected.txt.
  • platform/efl/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-3775172-fix-expected.png: Removed.
  • platform/gtk/editing/deleting/delete-after-span-ws-001-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-after-span-ws-002-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-after-span-ws-003-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt: Removed.
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt: Removed.
  • platform/gtk/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.png: Removed.
  • platform/gtk/editing/selection/editable-links-expected.txt: Removed.
  • platform/gtk/editing/selection/focus-body-expected.txt: Removed.
  • platform/gtk/editing/selection/select-all-001-expected.txt: Removed.
  • platform/gtk/editing/selection/select-all-002-expected.txt: Removed.
  • platform/gtk/editing/selection/select-all-003-expected.txt: Removed.
  • platform/gtk/editing/selection/select-all-004-expected.txt: Removed.
  • platform/gtk/editing/selection/unrendered-001-expected.txt: Removed.
  • platform/gtk/editing/selection/unrendered-002-expected.txt: Removed.
  • platform/gtk/editing/selection/unrendered-003-expected.txt: Removed.
  • platform/gtk/editing/selection/unrendered-004-expected.txt: Removed.
  • platform/gtk/editing/selection/unrendered-005-expected.txt: Removed.
  • platform/mac/editing/deleting/delete-at-start-or-end-expected.txt: Removed.
  • platform/mac/editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Removed.
  • platform/mac/editing/inserting/insert-div-010-expected.txt: Renamed from LayoutTests/editing/inserting/insert-div-010-expected.txt.
  • platform/mac/editing/selection/5195166-1-expected.txt: Removed.
  • platform/mac/editing/style/unbold-in-bold-expected.txt: Renamed from LayoutTests/editing/style/unbold-in-bold-expected.txt.
  • platform/mac/editing/undo/5378473-expected.txt: Removed.
  • platform/mac/editing/undo/undo-misspellings-expected.txt: Removed.
  • platform/mac/editing/unsupported-content/table-delete-001-expected.txt: Removed.
  • platform/mac/editing/unsupported-content/table-delete-003-expected.png: Removed.
  • platform/mac/editing/unsupported-content/table-delete-003-expected.txt: Removed.
  • platform/win-7sp0/editing/selection/collapse-selection-in-bidi-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
  • platform/win-7sp0/editing/selection/drag-text-delay-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/drag-text-delay-expected.txt.
  • platform/win-7sp0/editing/selection/extend-selection-home-end-expected.txt: Renamed from LayoutTests/platform/win/editing/selection/extend-selection-home-end-expected.txt.
  • platform/win/editing/deleting/delete-br-002-expected.txt: Removed.
  • platform/win/editing/deleting/delete-br-004-expected.txt: Removed.
  • platform/win/editing/deleting/delete-br-005-expected.txt: Removed.
  • platform/win/editing/deleting/delete-br-006-expected.txt: Removed.
  • platform/win/editing/deleting/delete-br-009-expected.txt: Removed.
  • platform/win/editing/inserting/insert-3800346-fix-expected.txt: Removed.
  • platform/win/editing/selection/anchor-focus2-expected.txt: Removed.
  • platform/win/editing/selection/anchor-focus3-expected.txt: Removed.
3:32 PM Changeset in webkit [158546] by akling@apple.com
  • 3 edits
    55 moves
    2 adds
    80 deletes in trunk/LayoutTests

Optimize baselines: tables

Unreviewed; run "webkit-patch optimize-baselines tables"

  • platform/gtk/tables/mozilla/bugs/adforce_imgis_com-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug102145-1-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug102145-2-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug102145-3-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug102145-4-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug10269-1-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug10296-2-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug103533-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug11321-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug13105-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug14159-3-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug149275-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug1818-6-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug196870-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug222336-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug222467-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug23072-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug23151-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug23994-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug26553-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug269566-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug275625-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug277062-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
  • platform/gtk/tables/mozilla/bugs/bug28933-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug3037-2-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug32447-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug34538-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug56405-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug641-2-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug75250-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug8032-2-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug8361-expected.png: Removed.
  • platform/gtk/tables/mozilla/bugs/bug9024-expected.png: Removed.
  • platform/gtk/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Removed.
  • platform/gtk/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug128876-expected.png: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug178855-expected.png: Removed.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Removed.
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Removed.
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Removed.
  • platform/gtk/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug120107-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug1271-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug12910-2-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug131020-2-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug13169-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug137388-1-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug137388-3-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug157890-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug1818-3-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug1818-6-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug196870-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug222336-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug222467-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug269566-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug277062-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug28933-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2954-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug56201-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug8032-2-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug9024-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/bugs/bug92647-2-expected.txt: Removed.
  • platform/mac-mountainlion/tables/mozilla/core/col_widths_fix_autoFixPer-expected.txt: Removed.
  • platform/mac/tables/mozilla/bugs/bug27038-3-expected.txt: Removed.
  • platform/mac/tables/mozilla/core/row_span-expected.txt: Removed.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
  • platform/win-future/tables/mozilla/core/bloomberg-expected.txt: Renamed from LayoutTests/tables/mozilla/core/bloomberg-expected.txt.
  • platform/win-future/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Renamed from LayoutTests/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt.
  • platform/win/tables/mozilla/bugs/bug133756-1-expected.txt: Removed.
  • platform/win/tables/mozilla/bugs/bug133756-2-expected.txt: Removed.
  • platform/win/tables/mozilla/bugs/bug220536-expected.txt: Removed.
  • platform/win/tables/mozilla/bugs/bug8858-expected.txt: Removed.
  • platform/win/tables/mozilla/core/row_span-expected.txt: Removed.
  • platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Removed.
  • platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Removed.
  • tables/mozilla/bugs/adforce_imgis_com-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/adforce_imgis_com-expected.txt.
  • tables/mozilla/bugs/bug102145-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-1-expected.png.
  • tables/mozilla/bugs/bug102145-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-2-expected.png.
  • tables/mozilla/bugs/bug102145-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-3-expected.png.
  • tables/mozilla/bugs/bug102145-4-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug102145-4-expected.png.
  • tables/mozilla/bugs/bug10269-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10269-1-expected.png.
  • tables/mozilla/bugs/bug10296-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug10296-2-expected.png.
  • tables/mozilla/bugs/bug103533-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug103533-expected.png.
  • tables/mozilla/bugs/bug11321-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug11321-expected.png.
  • tables/mozilla/bugs/bug12908-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug12908-2-expected.png.
  • tables/mozilla/bugs/bug13105-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug13105-expected.png.
  • tables/mozilla/bugs/bug133756-1-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-1-expected.txt.
  • tables/mozilla/bugs/bug133756-2-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug133756-2-expected.txt.
  • tables/mozilla/bugs/bug14159-3-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug14159-3-expected.png.
  • tables/mozilla/bugs/bug149275-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug149275-2-expected.txt.
  • tables/mozilla/bugs/bug1818-6-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug1818-6-expected.png.
  • tables/mozilla/bugs/bug196870-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug196870-expected.png.
  • tables/mozilla/bugs/bug220536-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug220536-expected.txt.
  • tables/mozilla/bugs/bug222336-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222336-expected.png.
  • tables/mozilla/bugs/bug222467-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug222467-expected.png.
  • tables/mozilla/bugs/bug23072-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23072-expected.png.
  • tables/mozilla/bugs/bug23151-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23151-expected.txt.
  • tables/mozilla/bugs/bug23994-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug23994-expected.png.
  • tables/mozilla/bugs/bug26553-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug26553-expected.txt.
  • tables/mozilla/bugs/bug269566-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug269566-expected.png.
  • tables/mozilla/bugs/bug27038-3-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug27038-3-expected.txt.
  • tables/mozilla/bugs/bug275625-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug275625-expected.png.
  • tables/mozilla/bugs/bug277062-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug277062-expected.png.
  • tables/mozilla/bugs/bug2886-2-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt.
  • tables/mozilla/bugs/bug28933-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug28933-expected.png.
  • tables/mozilla/bugs/bug3037-1-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-1-expected.png.
  • tables/mozilla/bugs/bug3037-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug3037-2-expected.png.
  • tables/mozilla/bugs/bug32447-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug32447-expected.png.
  • tables/mozilla/bugs/bug34538-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug34538-expected.png.
  • tables/mozilla/bugs/bug56405-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug56405-expected.png.
  • tables/mozilla/bugs/bug641-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug641-2-expected.png.
  • tables/mozilla/bugs/bug75250-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug75250-expected.png.
  • tables/mozilla/bugs/bug8032-2-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8032-2-expected.png.
  • tables/mozilla/bugs/bug8361-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug8361-expected.png.
  • tables/mozilla/bugs/bug8858-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla/bugs/bug8858-expected.txt.
  • tables/mozilla/bugs/bug9024-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/bugs/bug9024-expected.png.
  • tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png.
  • tables/mozilla/core/row_span-expected.txt:
  • tables/mozilla/marvin/table_overflow_hidden_td-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt.
  • tables/mozilla_expected_failures/bugs/bug128876-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.png.
  • tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug178855-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug178855-expected.png.
  • tables/mozilla_expected_failures/bugs/bug3517-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/bugs/bug3517-expected.png.
  • tables/mozilla_expected_failures/bugs/bug65372-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.txt.
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png.
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt.
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt.
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt.
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt.
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt: Renamed from LayoutTests/platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt.
2:26 PM Changeset in webkit [158545] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Precision errors in Math.cbrt() on GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=123624

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-11-03
Reviewed by Csaba Osztrogonác.

Calculate cube roots of 8 and -8, expecting 2 and -2, respectively. Cube roots of those two
numbers don't contain precision errors on the GTK and EFL ports as is the case with 27 and -27.

  • js/math-expected.txt:
  • js/script-tests/math.js:
2:18 PM Changeset in webkit [158544] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSShadowValue constructor should return PassRef.
<https://webkit.org/b/123711>

Make CSSShadowValue::create() return a PassRef since it will never
return null.

Reviewed by Sam Weinig.

2:17 PM Changeset in webkit [158543] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSLineBoxContainValue constructor should return PassRef.
<https://webkit.org/b/123710>

Make CSSLineBoxContainValue::create() return a PassRef since it
will never return null.

Reviewed by Sam Weinig.

2:17 PM Changeset in webkit [158542] by akling@apple.com
  • 1 edit
    5 moves
    5 deletes in trunk/LayoutTests

Optimize baselines: fast/frames

Unreviewed; run "webkit-patch optimize-baselines fast/frames"

  • fast/frames/002-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/002-expected.png.
  • fast/frames/empty-cols-attribute-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/empty-cols-attribute-expected.png.
  • fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Renamed from LayoutTests/platform/efl/fast/frames/flattening/frameset-flattening-subframesets-expected.txt.
  • fast/frames/frame-set-whitespace-attributes-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/frame-set-whitespace-attributes-expected.png.
  • fast/frames/no-frame-borders-expected.png: Renamed from LayoutTests/platform/efl/fast/frames/no-frame-borders-expected.png.
  • platform/gtk/fast/frames/002-expected.png: Removed.
  • platform/gtk/fast/frames/empty-cols-attribute-expected.png: Removed.
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Removed.
  • platform/gtk/fast/frames/frame-set-whitespace-attributes-expected.png: Removed.
  • platform/gtk/fast/frames/no-frame-borders-expected.png: Removed.
1:52 PM Changeset in webkit [158541] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Assertion failure in non-JIT'ed LLInt on ARM Thumb.
https://bugs.webkit.org/show_bug.cgi?id=97569.

Reviewed by Geoffrey Garen.

  • assembler/MacroAssemblerCodeRef.h:
  • Thumb2 alignment assertions do not apply to the C Loop LLINT because the arguments passed to those assertions are actually OpcodeIDs masquerading as addresses.
  • llint/LLIntOfflineAsmConfig.h:
  • Some of the #defines belong in the !ENABLE(LLINT_C_LOOP) section. Moving them there.
  • llint/LowLevelInterpreter.cpp:
  • Keep the compiler happy from some unreferenced C Loop labels.
1:32 PM Changeset in webkit [158540] by Antti Koivisto
  • 29 edits in trunk/Source/WebCore

LiveNodeLists should have non-null ContainerNode as root
https://bugs.webkit.org/show_bug.cgi?id=123709

Reviewed by Andreas Kling.

After moving ChildNodeList off from LiveNodeList the root is now always at least a ContainerNode.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):

Also these move from Node to ContainerNode to make tighter typing work.

1:08 PM Changeset in webkit [158539] by akling@apple.com
  • 1 edit
    21 moves
    24 deletes in trunk/LayoutTests

Optimize baselines: fast/table

Unreviewed; run "webkit-patch optimize-baselines fast/table"

  • fast/table/022-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/022-expected.txt.
  • fast/table/024-expected.png: Renamed from LayoutTests/platform/efl/fast/table/024-expected.png.
  • fast/table/031-expected.png: Renamed from LayoutTests/platform/efl/fast/table/031-expected.png.
  • fast/table/032-expected.png: Renamed from LayoutTests/platform/efl/fast/table/032-expected.png.
  • fast/table/034-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/034-expected.txt.
  • fast/table/auto-100-percent-width-expected.png: Renamed from LayoutTests/platform/efl/fast/table/auto-100-percent-width-expected.png.
  • fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Renamed from LayoutTests/platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png.
  • fast/table/div-as-col-span-expected.png: Renamed from LayoutTests/platform/efl/fast/table/div-as-col-span-expected.png.
  • fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt.
  • fast/table/giantCellspacing-expected.png: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.png.
  • fast/table/giantCellspacing-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantCellspacing-expected.txt.
  • fast/table/giantRowspan-expected.txt: Renamed from LayoutTests/platform/efl/fast/table/giantRowspan-expected.txt.
  • fast/table/giantRowspan2-expected.txt: Renamed from LayoutTests/platform/mac/fast/table/giantRowspan2-expected.txt.
  • fast/table/percent-widths-stretch-vertical-expected.png: Renamed from LayoutTests/platform/efl/fast/table/percent-widths-stretch-vertical-expected.png.
  • fast/table/table-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-before-child-style-update-expected.png.
  • fast/table/table-row-before-child-style-update-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-before-child-style-update-expected.png.
  • fast/table/table-row-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-expected.png.
  • fast/table/table-row-style-not-updated-with-after-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.png.
  • fast/table/table-row-style-not-updated-with-before-content-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.png.
  • fast/table/table-style-not-updated-expected.png: Renamed from LayoutTests/platform/efl/fast/table/table-style-not-updated-expected.png.
  • fast/table/vertical-align-baseline-readjust-expected.png: Renamed from LayoutTests/platform/efl/fast/table/vertical-align-baseline-readjust-expected.png.
  • platform/gtk/fast/table/022-expected.txt: Removed.
  • platform/gtk/fast/table/024-expected.png: Removed.
  • platform/gtk/fast/table/031-expected.png: Removed.
  • platform/gtk/fast/table/032-expected.png: Removed.
  • platform/gtk/fast/table/034-expected.txt: Removed.
  • platform/gtk/fast/table/auto-100-percent-width-expected.png: Removed.
  • platform/gtk/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.png: Removed.
  • platform/gtk/fast/table/div-as-col-span-expected.png: Removed.
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt: Removed.
  • platform/gtk/fast/table/giantCellspacing-expected.png: Removed.
  • platform/gtk/fast/table/giantCellspacing-expected.txt: Removed.
  • platform/gtk/fast/table/giantRowspan-expected.txt: Removed.
  • platform/gtk/fast/table/percent-widths-stretch-vertical-expected.png: Removed.
  • platform/gtk/fast/table/table-before-child-style-update-expected.png: Removed.
  • platform/gtk/fast/table/table-row-before-child-style-update-expected.png: Removed.
  • platform/gtk/fast/table/table-row-style-not-updated-expected.png: Removed.
  • platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.png: Removed.
  • platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.png: Removed.
  • platform/gtk/fast/table/table-style-not-updated-expected.png: Removed.
  • platform/gtk/fast/table/vertical-align-baseline-readjust-expected.png: Removed.
  • platform/mac/fast/table/022-expected.txt: Removed.
  • platform/mac/fast/table/giantCellspacing-expected.txt: Removed.
  • platform/mac/fast/table/giantRowspan-expected.txt: Removed.
  • platform/win/fast/table/giantRowspan-expected.txt: Removed.
  • platform/win/fast/table/giantRowspan2-expected.txt: Removed.
12:41 PM Changeset in webkit [158538] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

[Cocoa] Wrappers' -copyWithZone: should copy if the collection is mutable
https://bugs.webkit.org/show_bug.cgi?id=123707

Reviewed by Geoff Garen.

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray copyWithZone:]): If the array is mutable, make a copy.

  • Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary copyWithZone:]): If the dictionary is mutable, make a copy.

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::entries): Added this accessor.

12:19 PM Changeset in webkit [158537] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Switch createContextualFragment to element iterator
https://bugs.webkit.org/show_bug.cgi?id=123704

Reviewed by Andreas Kling.

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):

Use type helpers instead of hasTagName

  • editing/markup.cpp:

(WebCore::collectElementsToRemoveFromFragment):
(WebCore::removeElementFromFragmentPreservingChildren):
(WebCore::createContextualFragment):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::formElementIndex):

Use type helpers instead of hasTagName

  • html/HTMLTagNames.in:


Generate type helpers for <html>.

11:52 AM Changeset in webkit [158536] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

ChildNodeList should not be LiveNodeList
https://bugs.webkit.org/show_bug.cgi?id=123708

Reviewed by Sam Weinig.

ChildNodeList is a poor fit to be a LiveNodeList. It is heavily special-cased. It is also
the only subtype that returns non-Elements thus preventing tightening.

  • bindings/js/JSNodeListCustom.cpp:

(WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):

Support new types.

  • dom/ChildNodeList.cpp:

(WebCore::EmptyNodeList::~EmptyNodeList):
(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::~ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::childFromFirst):
(WebCore::childFromLast):
(WebCore::ChildNodeList::nodeBeforeCached):
(WebCore::ChildNodeList::nodeAfterCached):
(WebCore::ChildNodeList::item):
(WebCore::ChildNodeList::namedItem):
(WebCore::ChildNodeList::invalidateCache):

Implement the same caching optimizations as LiveNodeList with tighter, less generic code.

  • dom/ChildNodeList.h:


Inherit ChildNodeList directly from NodeList.

Add new EmptyNodeList type. This is only ever used if NodeList is requested for a non-container node.
It allows tighter typing in ChildNodeList.

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeListBase::LiveNodeListBase):
(WebCore::LiveNodeListBase::~LiveNodeListBase):
(WebCore::LiveNodeList::LiveNodeList):

Remove ChildNodeList specific code and branches.

  • dom/Node.cpp:

(WebCore::Node::childNodes):

Return EmptyNodeList for non-containers.

  • dom/NodeList.h:

(WebCore::NodeList::~NodeList):
(WebCore::NodeList::isLiveNodeList):
(WebCore::NodeList::isChildNodeList):
(WebCore::NodeList::isEmptyNodeList):

For isReachableFromOpaqueRoots.

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::ensureChildNodeList):
(WebCore::NodeListsNodeData::removeChildNodeList):
(WebCore::NodeListsNodeData::ensureEmptyChildNodeList):
(WebCore::NodeListsNodeData::removeEmptyChildNodeList):
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):

EmptyNodeList support.

  • html/CollectionType.h:
  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isMatchingElement):
(WebCore::LiveNodeListBase::itemBefore):
(WebCore::LiveNodeListBase::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeListBase::traverseLiveNodeListForwardToOffset):
(WebCore::LiveNodeListBase::item):
(WebCore::LiveNodeListBase::itemBeforeOrAfterCachedItem):

Remove ChildNodeList specific code and branches.

10:24 AM Changeset in webkit [158535] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

FTL should use LLVM intrinsics for OSR exit, watchpoints, inline caches, and stack layout
https://bugs.webkit.org/show_bug.cgi?id=122318

Reviewed by Geoffrey Garen.

This all now works. This patch just updates our implementation to work with LLVM trunk,
and removes all of the old code that tried to do OSR exits and heap accesses without
the benefit of those intrinsics.

In particular:

  • StackMaps parsing now uses the new, less compact, but more future-proof, format.


  • Remove the ftlUsesStackmaps() option and hard-code ftlUsesStackmaps = true. Remove all code for ftlUsesStackmaps = false, since that was only there for back when we didn't have the intrinsics.


  • Remove the other experimental OSR options (useLLVMOSRExitIntrinsic, ftlTrapsOnOSRExit, and FTLOSRExitOmitsMarshalling).


  • Remove LowerDFGToLLVM's use of the ExitThunkGenerator since we don't need to generate the exit thunks until after we parse the stackmaps.


  • Remove all of the exit thunk and compiler code for the no-stackmaps case.
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::forStackmaps):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::LowerDFGToLLVM::callStackmap):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

  • ftl/FTLOSRExitCompilationInfo.h:

(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::parse):
(JSC::FTL::StackMaps::parse):
(WTF::printInternal):

  • ftl/FTLStackMaps.h:
  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationThunkGenerator):

  • ftl/FTLThunks.h:

(JSC::FTL::Thunks::getOSRExitGenerationThunk):

  • runtime/Options.h:
9:51 AM Changeset in webkit [158534] by Patrick Gansterer
  • 2 edits in trunk/Tools

Add test for ListHashSet::removeLast()
https://bugs.webkit.org/show_bug.cgi?id=121810

Reviewed by Anders Carlsson.

  • TestWebKitAPI/Tests/WTF/ListHashSet.cpp:

(TestWebKitAPI::TEST):

9:48 AM Changeset in webkit [158533] by Patrick Gansterer
  • 10 edits in trunk/Source

[WINCE] Replace OwnPtr with GDIObject
https://bugs.webkit.org/show_bug.cgi?id=123670

Reviewed by Anders Carlsson.

Source/WebCore:

  • page/win/FrameGdiWin.cpp:

(WebCore::imageFromRect):

  • platform/graphics/wince/FontPlatformData.cpp:

(WebCore::FixedSizeFontData::create):
(WebCore::FontPlatformData::hfont):
(WebCore::FontPlatformData::getScaledFontHandle):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::createPen):
(WebCore::createBrush):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::drawRoundCorner):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawText):

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):

  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::createHandle):
(WebCore::SharedBitmap::draw):
(WebCore::SharedBitmap::clipBitmap):
(WebCore::drawPatternSimple):
(WebCore::SharedBitmap::drawPattern):
(WebCore::SharedBitmap::DCProvider::getDC):

  • platform/graphics/wince/SharedBitmap.h:

Source/WebKit/wince:

  • WebView.cpp:

(WebView::paint):
(WebView::handlePaint):

  • WebView.h:
6:55 AM Changeset in webkit [158532] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Some tests of editing/selection fail to render properly
https://bugs.webkit.org/show_bug.cgi?id=117574

Unreviewed, EFL gardening.

These tests are passed in wk1(and wk2), but skipped in wk1.
These tests have been reviewed since those are added.
Now these tests are operating properly, so those need to update the test expectations.
Also 'editing/selection/caret-and-focus-ring.html' is already changed a reason of failure by Bug no.123696

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-03

  • platform/efl-wk1/TestExpectations:
3:19 AM Changeset in webkit [158531] by akling@apple.com
  • 1 edit
    36 moves
    30 deletes in trunk/LayoutTests

Optimize baselines: fast/text

Unreviewed; run "webkit-patch optimize-baselines fast/text"

  • fast/text/decorations-transformed-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/decorations-transformed-expected.txt.
  • fast/text/fixed-pitch-control-characters-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/fixed-pitch-control-characters-expected.txt.
  • fast/text/international/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/001-expected.txt.
  • fast/text/international/vertical-text-glyph-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt.
  • fast/text/international/vertical-text-metrics-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/vertical-text-metrics-test-expected.txt.
  • fast/text/international/wrap-CJK-001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/wrap-CJK-001-expected.txt.
  • fast/text/justify-ideograph-complex-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-complex-expected.txt.
  • fast/text/justify-ideograph-simple-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-simple-expected.txt.
  • fast/text/justify-ideograph-vertical-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/justify-ideograph-vertical-expected.txt.
  • fast/text/selection-painted-separately-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/selection-painted-separately-expected.txt.
  • fast/text/soft-hyphen-2-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-2-expected.txt.
  • fast/text/soft-hyphen-3-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/soft-hyphen-3-expected.txt.
  • fast/text/stripNullFromText-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stripNullFromText-expected.png.
  • fast/text/updateNewFont-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/updateNewFont-expected.txt.
  • fast/text/whitespace/001-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/001-expected.txt.
  • fast/text/whitespace/013-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/013-expected.txt.
  • fast/text/whitespace/014-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/014-expected.txt.
  • fast/text/whitespace/017-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.png.
  • fast/text/whitespace/017-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/017-expected.txt.
  • fast/text/whitespace/029-expected.png: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.png.
  • fast/text/whitespace/029-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/029-expected.txt.
  • fast/text/whitespace/pre-newline-box-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/pre-newline-box-test-expected.txt.
  • fast/text/whitespace/tab-character-basics-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/whitespace/tab-character-basics-expected.txt.
  • platform/efl-wk1/fast/text/complex-text-opacity-expected.png: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.png.
  • platform/efl-wk1/fast/text/complex-text-opacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/complex-text-opacity-expected.txt.
  • platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.png: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.png.
  • platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt.
  • platform/efl-wk2/fast/text/atsui-pointtooffset-calls-cg-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-pointtooffset-calls-cg-expected.png.
  • platform/efl-wk2/fast/text/atsui-rtl-override-selection-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-rtl-override-selection-expected.png.
  • platform/efl-wk2/fast/text/atsui-small-caps-punctuation-size-expected.png: Renamed from LayoutTests/platform/efl/fast/text/atsui-small-caps-punctuation-size-expected.png.
  • platform/efl-wk2/fast/text/hyphenate-character-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-character-expected.png.
  • platform/efl-wk2/fast/text/hyphenate-first-word-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-first-word-expected.png.
  • platform/efl-wk2/fast/text/hyphenate-limit-before-after-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-before-after-expected.png.
  • platform/efl-wk2/fast/text/hyphenate-limit-lines-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-lines-expected.png.
  • platform/efl-wk2/fast/text/hyphens-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphens-expected.png.
  • platform/efl-wk2/fast/text/midword-break-before-surrogate-pair-2-expected.png: Renamed from LayoutTests/platform/efl/fast/text/midword-break-before-surrogate-pair-2-expected.png.
  • platform/gtk/fast/text/decorations-transformed-expected.txt: Removed.
  • platform/gtk/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
  • platform/gtk/fast/text/international/001-expected.txt: Removed.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/gtk/fast/text/international/vertical-text-metrics-test-expected.txt: Removed.
  • platform/gtk/fast/text/international/wrap-CJK-001-expected.txt: Removed.
  • platform/gtk/fast/text/justify-ideograph-complex-expected.txt: Removed.
  • platform/gtk/fast/text/justify-ideograph-simple-expected.txt: Removed.
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Removed.
  • platform/gtk/fast/text/selection-painted-separately-expected.txt: Removed.
  • platform/gtk/fast/text/soft-hyphen-2-expected.txt: Removed.
  • platform/gtk/fast/text/soft-hyphen-3-expected.txt: Removed.
  • platform/gtk/fast/text/stripNullFromText-expected.png: Removed.
  • platform/gtk/fast/text/updateNewFont-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/001-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/017-expected.png: Removed.
  • platform/gtk/fast/text/whitespace/017-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/029-expected.png: Removed.
  • platform/gtk/fast/text/whitespace/029-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/pre-newline-box-test-expected.txt: Removed.
  • platform/gtk/fast/text/whitespace/tab-character-basics-expected.txt: Removed.
  • platform/mac/fast/text/decorations-transformed-expected.txt: Removed.
  • platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Removed.
  • platform/mac/fast/text/selection-painted-separately-expected.txt: Removed.
  • platform/mac/fast/text/soft-hyphen-2-expected.txt: Removed.
  • platform/mac/fast/text/soft-hyphen-3-expected.txt: Removed.
  • platform/mac/fast/text/whitespace/001-expected.txt: Removed.
  • platform/mac/fast/text/whitespace/013-expected.txt: Removed.
  • platform/mac/fast/text/whitespace/014-expected.txt: Removed.
  • platform/mac/fast/text/whitespace/017-expected.txt: Removed.
3:13 AM Changeset in webkit [158530] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Add helpers for partial descendant traversal to element iterators
https://bugs.webkit.org/show_bug.cgi?id=123703

Reviewed by Andreas Kling.

  • dom/ElementAncestorIterator.h:

(WebCore::lineageOfType):

lineageOfType definition didn't match the declaration.

  • dom/ElementDescendantIterator.h:

(WebCore::::find):
(WebCore::::from):

Add find and from for getting begin iterator for partial traversals.

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):
(WebCore::FrameSelection::currentForm):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::findClosestFormAncestor):

Use them in a few places.

1:54 AM Changeset in webkit [158529] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Inline RenderStyle functions for getting/setting pseudo style bits.
<https://webkit.org/b/123702>

hasPseudoStyle() actually shows up on html5-full-render.html,
and it's pretty crazy to eat the cost of a function call just
to do some basic bit twiddling.

Reviewed by Antti Koivisto.

1:41 AM Changeset in webkit [158528] by akling@apple.com
  • 1 edit
    8 moves
    1 add
    5 deletes in trunk/LayoutTests

Optimize baselines: fast/canvas

Unreviewed; run "webkit-patch optimize-baselines fast/canvas"

  • fast/canvas/canvas-empty-image-pattern-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-empty-image-pattern-expected.png.
  • fast/canvas/canvas-incremental-repaint-2-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-incremental-repaint-2-expected.png.
  • fast/canvas/canvas-render-layer-expected.png: Renamed from LayoutTests/platform/efl/fast/canvas/canvas-render-layer-expected.png.
  • fast/canvas/set-colors-expected.txt: Renamed from LayoutTests/platform/efl/fast/canvas/set-colors-expected.txt.
  • platform/gtk/fast/canvas/canvas-empty-image-pattern-expected.png: Removed.
  • platform/gtk/fast/canvas/canvas-incremental-repaint-2-expected.png: Removed.
  • platform/gtk/fast/canvas/canvas-render-layer-expected.png: Removed.
  • platform/gtk/fast/canvas/set-colors-expected.txt: Removed.
  • platform/win-7sp0/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt.
  • platform/win-7sp0/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt.
  • platform/win-7sp0/fast/canvas/canvas-render-layer-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-render-layer-expected.txt.
  • platform/win-7sp0/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Renamed from LayoutTests/platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt.
  • platform/win-xp/fast/canvas/set-colors-expected.txt: Removed.
1:30 AM Changeset in webkit [158527] by calvaris@igalia.com
  • 77 edits
    2 deletes in trunk

Remove HTMLMediaElement.initialTime
https://bugs.webkit.org/show_bug.cgi?id=123572

Reviewed by Eric Carlson.

Source/WebCore:

Patch based on one by: philipj@opera.com
Blink review URL: https://codereview.chromium.org/35033002

initialTime has been removed from the HTMLMediaElement.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_media_element_get_initial_time):

  • bindings/gobject/WebKitDOMCustom.h:
  • bindings/gobject/WebKitDOMCustom.symbols: Added phony function.
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl: Removed HTMLMediaElement::initialTime.

LayoutTests:

Blink review URL: https://codereview.chromium.org/35033002

Removed presence of initialTime in the tests.

  • media/media-fragments/TC0001-expected.txt:
  • media/media-fragments/TC0002-expected.txt:
  • media/media-fragments/TC0003-expected.txt:
  • media/media-fragments/TC0004-expected.txt:
  • media/media-fragments/TC0005-expected.txt:
  • media/media-fragments/TC0006-expected.txt:
  • media/media-fragments/TC0009-expected.txt:
  • media/media-fragments/TC0011-expected.txt:
  • media/media-fragments/TC0012-expected.txt:
  • media/media-fragments/TC0014-expected.txt:
  • media/media-fragments/TC0015-expected.txt:
  • media/media-fragments/TC0017-expected.txt:
  • media/media-fragments/TC0024-expected.txt:
  • media/media-fragments/TC0027-expected.txt:
  • media/media-fragments/TC0028-expected.txt:
  • media/media-fragments/TC0029-expected.txt:
  • media/media-fragments/TC0030-expected.txt:
  • media/media-fragments/TC0031-expected.txt:
  • media/media-fragments/TC0032-expected.txt:
  • media/media-fragments/TC0033-expected.txt:
  • media/media-fragments/TC0034-expected.txt:
  • media/media-fragments/TC0035-expected.txt:
  • media/media-fragments/TC0036-expected.txt:
  • media/media-fragments/TC0037-expected.txt:
  • media/media-fragments/TC0038-expected.txt:
  • media/media-fragments/TC0039-expected.txt:
  • media/media-fragments/TC0044-expected.txt:
  • media/media-fragments/TC0051-expected.txt:
  • media/media-fragments/TC0052-expected.txt:
  • media/media-fragments/TC0053-expected.txt:
  • media/media-fragments/TC0054-expected.txt:
  • media/media-fragments/TC0055-expected.txt:
  • media/media-fragments/TC0058-expected.txt:
  • media/media-fragments/TC0059-expected.txt:
  • media/media-fragments/TC0061-expected.txt:
  • media/media-fragments/TC0062-expected.txt:
  • media/media-fragments/TC0063-expected.txt:
  • media/media-fragments/TC0064-expected.txt:
  • media/media-fragments/TC0065-expected.txt:
  • media/media-fragments/TC0066-expected.txt:
  • media/media-fragments/TC0067-expected.txt:
  • media/media-fragments/TC0068-expected.txt:
  • media/media-fragments/TC0069-expected.txt:
  • media/media-fragments/TC0070-expected.txt:
  • media/media-fragments/TC0071-expected.txt:
  • media/media-fragments/TC0072-expected.txt:
  • media/media-fragments/TC0073-expected.txt:
  • media/media-fragments/TC0074-expected.txt:
  • media/media-fragments/TC0075-expected.txt:
  • media/media-fragments/TC0076-expected.txt:
  • media/media-fragments/TC0077-expected.txt:
  • media/media-fragments/TC0078-expected.txt:
  • media/media-fragments/TC0079-expected.txt:
  • media/media-fragments/TC0080-expected.txt:
  • media/media-fragments/TC0081-expected.txt:
  • media/media-fragments/TC0082-expected.txt:
  • media/media-fragments/TC0083-expected.txt:
  • media/media-fragments/TC0084-expected.txt:
  • media/media-fragments/TC0085-expected.txt:
  • media/media-fragments/TC0086-expected.txt:
  • media/media-fragments/TC0087-expected.txt:
  • media/media-fragments/TC0088-expected.txt:
  • media/media-fragments/TC0089-expected.txt:
  • media/media-fragments/TC0090-expected.txt:
  • media/media-fragments/TC0091-expected.txt:
  • media/media-fragments/TC0092-expected.txt:
  • media/media-fragments/TC0093-expected.txt:
  • media/media-fragments/TC0094-expected.txt:
  • media/media-fragments/media-fragments.js:

(canplaythrough): Removed check for initialTime

  • media/media-initialTime-expected.txt: Removed.
  • media/media-initialTime.html: Removed.

Nov 2, 2013:

11:58 PM Changeset in webkit [158526] by ap@apple.com
  • 17 edits
    2 copies
    4 adds in trunk

Implement generateKey for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=123669

Reviewed by Dan Bernstein.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-generate-key.html

crypto/subtle/hmac-generate-key.html

  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createAesKeyGenParams): Added bindings for AesKeyGenParams.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Handle
algorithms that generate AES and HMAC keys.

  • bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::generateKey): Added.
  • crypto/CryptoAlgorithmAesKeyGenParams.h: Added.
  • crypto/CryptoKey.cpp: (WebCore::CryptoKey::randomData):
  • crypto/CryptoKey.h:
  • crypto/CryptoKeyMac.cpp: Added

Expose a function that produces random data for symmetric crypto keys. Cross-platform
implementation uses ARC4 code from WTF, while Mac uses a system function that
provides a FIPS validated random number generator.

  • crypto/CryptoKeyAES.cpp: (WebCore::CryptoKeyAES::generate):
  • crypto/CryptoKeyAES.h:

Added a function that creates AES keys.

  • crypto/SubtleCrypto.idl: Added generateKey.
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::generateKey): Added.

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::generateKey): Added.

  • crypto/keys/CryptoKeyHMAC.cpp: (WebCore::CryptoKeyHMAC::generate):
  • crypto/keys/CryptoKeyHMAC.h:

Added a function that creates HMAC keys.

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: Removed generateKey stub, the implementation

ended up in cross-platform file.

  • crypto/mac/CryptoAlgorithmHMACMac.cpp: Ditto.

LayoutTests:

  • crypto/subtle/aes-cbc-generate-key-expected.txt: Added.
  • crypto/subtle/aes-cbc-generate-key.html: Added.
  • crypto/subtle/hmac-generate-key-expected.txt: Added.
  • crypto/subtle/hmac-generate-key.html: Added.
  • crypto/subtle/sha-1-expected.txt: Now that crypto.webkitSubtle.generateKey exists,

a different exception is raised.

11:50 PM Changeset in webkit [158525] by akling@apple.com
  • 1 edit
    35 moves
    2 adds
    39 deletes in trunk/LayoutTests

Optimize baselines: css3

Unreviewed; run "webkit-patch optimize-baselines css3"

  • css3/images/cross-fade-background-size-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-background-size-expected.txt.
  • css3/images/cross-fade-blending-expected.png: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.png.
  • css3/images/cross-fade-blending-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-blending-expected.txt.
  • css3/images/cross-fade-invalidation-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-invalidation-expected.txt.
  • css3/images/cross-fade-simple-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-simple-expected.txt.
  • css3/images/cross-fade-sizing-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-sizing-expected.txt.
  • css3/images/cross-fade-tiled-expected.txt: Renamed from LayoutTests/platform/efl/css3/images/cross-fade-tiled-expected.txt.
  • css3/selectors3/html/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-17-expected.png.
  • css3/selectors3/html/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-177a-expected.png.
  • css3/selectors3/html/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-18c-expected.png.
  • css3/selectors3/html/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27a-expected.png.
  • css3/selectors3/html/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-27b-expected.png.
  • css3/selectors3/html/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/html/css3-modsel-61-expected.png.
  • css3/selectors3/xhtml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-123b-expected.png.
  • css3/selectors3/xhtml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-17-expected.png.
  • css3/selectors3/xhtml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-177a-expected.png.
  • css3/selectors3/xhtml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-18c-expected.png.
  • css3/selectors3/xhtml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27a-expected.png.
  • css3/selectors3/xhtml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-27b-expected.png.
  • css3/selectors3/xhtml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-61-expected.png.
  • css3/selectors3/xhtml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-91-expected.png.
  • css3/selectors3/xhtml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xhtml/css3-modsel-92-expected.png.
  • css3/selectors3/xml/css3-modsel-123b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-123b-expected.png.
  • css3/selectors3/xml/css3-modsel-167-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167-expected.png.
  • css3/selectors3/xml/css3-modsel-167a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-167a-expected.png.
  • css3/selectors3/xml/css3-modsel-17-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-17-expected.png.
  • css3/selectors3/xml/css3-modsel-177a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-177a-expected.png.
  • css3/selectors3/xml/css3-modsel-18c-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-18c-expected.png.
  • css3/selectors3/xml/css3-modsel-27a-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27a-expected.png.
  • css3/selectors3/xml/css3-modsel-27b-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-27b-expected.png.
  • css3/selectors3/xml/css3-modsel-61-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-61-expected.png.
  • css3/selectors3/xml/css3-modsel-91-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-91-expected.png.
  • css3/selectors3/xml/css3-modsel-92-expected.png: Renamed from LayoutTests/platform/efl/css3/selectors3/xml/css3-modsel-92-expected.png.
  • platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.png: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.png.
  • platform/efl-wk1/css3/flexbox/flexbox-baseline-expected.txt: Renamed from LayoutTests/platform/efl/css3/flexbox/flexbox-baseline-expected.txt.
  • platform/gtk/css3/images/cross-fade-blending-expected.png: Removed.
  • platform/gtk/css3/images/cross-fade-blending-expected.txt: Removed.
  • platform/gtk/css3/images/cross-fade-invalidation-expected.txt: Removed.
  • platform/gtk/css3/images/cross-fade-simple-expected.txt: Removed.
  • platform/gtk/css3/images/cross-fade-sizing-expected.txt: Removed.
  • platform/gtk/css3/images/cross-fade-tiled-expected.txt: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-17-expected.png: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-177a-expected.png: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-18c-expected.png: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-27a-expected.png: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-27b-expected.png: Removed.
  • platform/gtk/css3/selectors3/html/css3-modsel-61-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-123b-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-17-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-177a-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-18c-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-27a-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-27b-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-61-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-91-expected.png: Removed.
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-92-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-123b-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-167-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-167a-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-17-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-177a-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-18c-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-27a-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-27b-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-61-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-91-expected.png: Removed.
  • platform/gtk/css3/selectors3/xml/css3-modsel-92-expected.png: Removed.
  • platform/mac/css3/images/cross-fade-background-size-expected.txt: Removed.
  • platform/mac/css3/images/cross-fade-blending-expected.txt: Removed.
  • platform/mac/css3/images/cross-fade-invalidation-expected.txt: Removed.
  • platform/mac/css3/images/cross-fade-simple-expected.txt: Removed.
  • platform/mac/css3/images/cross-fade-sizing-expected.txt: Removed.
  • platform/mac/css3/images/cross-fade-tiled-expected.txt: Removed.
  • platform/win/css3/filters/effect-reference-expected.txt: Removed.
  • platform/win/css3/filters/effect-reference-hw-expected.txt: Removed.
11:25 PM Changeset in webkit [158524] by akling@apple.com
  • 1 edit
    72 moves
    73 deletes in trunk/LayoutTests

Optimize baselines: css2.1

Unreviewed; run "webkit-patch optimize-baselines css2.1"

  • css2.1/20110323/absolute-replaced-height-036-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/absolute-replaced-height-036-expected.png.
  • css2.1/20110323/block-non-replaced-height-011-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-011-expected.png.
  • css2.1/20110323/block-non-replaced-height-013-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/block-non-replaced-height-013-expected.png.
  • css2.1/20110323/empty-inline-001-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/empty-inline-001-expected.png.
  • css2.1/20110323/replaced-intrinsic-002-expected.png: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.png.
  • css2.1/20110323/replaced-intrinsic-002-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-002-expected.txt.
  • css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt.
  • css2.1/t040105-atkeyw-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-00-b-expected.png.
  • css2.1/t040105-atkeyw-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-01-b-expected.png.
  • css2.1/t040105-atkeyw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atkeyw-02-b-expected.png.
  • css2.1/t040105-atrule-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-00-b-expected.png.
  • css2.1/t040105-atrule-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-01-b-expected.png.
  • css2.1/t040105-atrule-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-02-b-expected.png.
  • css2.1/t040105-atrule-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-03-b-expected.png.
  • css2.1/t040105-atrule-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-atrule-04-b-expected.png.
  • css2.1/t040105-import-00-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-00-b-expected.png.
  • css2.1/t040105-import-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-01-b-expected.png.
  • css2.1/t040105-import-10-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040105-import-10-b-expected.png.
  • css2.1/t0402-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-01-f-expected.png.
  • css2.1/t0402-syntax-02-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-02-f-expected.png.
  • css2.1/t0402-syntax-03-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-03-f-expected.png.
  • css2.1/t0402-syntax-04-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-04-f-expected.png.
  • css2.1/t0402-syntax-05-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-05-f-expected.png.
  • css2.1/t0402-syntax-06-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0402-syntax-06-f-expected.png.
  • css2.1/t040307-syntax-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t040307-syntax-01-b-expected.png.
  • css2.1/t0505-c16-descendant-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0505-c16-descendant-02-e-expected.png.
  • css2.1/t0509-id-sel-syntax-01-f-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-01-f-expected.png.
  • css2.1/t0509-id-sel-syntax-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0509-id-sel-syntax-02-b-expected.png.
  • css2.1/t0511-c21-pseud-link-00-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-00-e-expected.png.
  • css2.1/t0511-c21-pseud-link-01-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-01-e-expected.png.
  • css2.1/t0511-c21-pseud-link-02-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-02-e-expected.png.
  • css2.1/t0511-c21-pseud-link-03-e-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0511-c21-pseud-link-03-e-expected.png.
  • css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-focus-ln-00-e-i-expected.png.
  • css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t051103-c21-hover-ln-00-e-i-expected.png.
  • css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0803-c5504-mrgn-l-02-c-expected.png.
  • css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5511-brdr-tw-02-b-expected.png.
  • css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5512-brdr-rw-02-b-expected.png.
  • css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5513-brdr-bw-02-b-expected.png.
  • css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5514-brdr-lw-02-b-expected.png.
  • css2.1/t0805-c5515-brdr-w-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t0805-c5515-brdr-w-02-b-expected.png.
  • css2.1/t1001-abs-pos-cb-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.png.
  • css2.1/t1001-abs-pos-cb-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-01-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-02-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.png.
  • css2.1/t1001-abs-pos-cb-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-02-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-03-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.png.
  • css2.1/t1001-abs-pos-cb-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-03-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-04-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.png.
  • css2.1/t1001-abs-pos-cb-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-04-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-05-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.png.
  • css2.1/t1001-abs-pos-cb-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-05-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-06-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.png.
  • css2.1/t1001-abs-pos-cb-06-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-06-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-07-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.png.
  • css2.1/t1001-abs-pos-cb-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-07-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-08-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.png.
  • css2.1/t1001-abs-pos-cb-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-08-b-expected.txt.
  • css2.1/t1001-abs-pos-cb-09-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.png.
  • css2.1/t1001-abs-pos-cb-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1001-abs-pos-cb-09-b-expected.txt.
  • css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1205-c566-list-stl-01-c-g-expected.txt.
  • css2.1/t140201-c532-bgcolor-01-b-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c532-bgcolor-01-b-expected.png.
  • css2.1/t140201-c533-bgimage-01-b-g-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c533-bgimage-01-b-g-expected.png.
  • css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Renamed from LayoutTests/platform/efl/css2.1/t140201-c536-bgpos-01-b-ag-expected.png.
  • css2.1/t1508-c527-font-00-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-00-b-expected.txt.
  • css2.1/t1508-c527-font-01-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-01-b-expected.txt.
  • css2.1/t1508-c527-font-02-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-02-b-expected.txt.
  • css2.1/t1508-c527-font-03-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-03-b-expected.txt.
  • css2.1/t1508-c527-font-04-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-04-b-expected.txt.
  • css2.1/t1508-c527-font-05-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-05-b-expected.txt.
  • css2.1/t1508-c527-font-07-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-07-b-expected.txt.
  • css2.1/t1508-c527-font-08-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-08-b-expected.txt.
  • css2.1/t1508-c527-font-09-b-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-09-b-expected.txt.
  • css2.1/t1508-c527-font-10-c-expected.txt: Renamed from LayoutTests/platform/efl/css2.1/t1508-c527-font-10-c-expected.txt.
  • platform/gtk/css2.1/20110323/absolute-replaced-height-036-expected.png: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-011-expected.png: Removed.
  • platform/gtk/css2.1/20110323/block-non-replaced-height-013-expected.png: Removed.
  • platform/gtk/css2.1/20110323/empty-inline-001-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.png: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-002-expected.txt: Removed.
  • platform/gtk/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt: Removed.
  • platform/gtk/css2.1/t040105-atkeyw-00-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-atkeyw-01-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-atkeyw-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-atrule-00-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-atrule-01-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-atrule-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-atrule-03-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-atrule-04-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-import-00-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-import-01-b-expected.png: Removed.
  • platform/gtk/css2.1/t040105-import-10-b-expected.png: Removed.
  • platform/gtk/css2.1/t0402-syntax-01-f-expected.png: Removed.
  • platform/gtk/css2.1/t0402-syntax-02-f-expected.png: Removed.
  • platform/gtk/css2.1/t0402-syntax-03-f-expected.png: Removed.
  • platform/gtk/css2.1/t0402-syntax-04-f-expected.png: Removed.
  • platform/gtk/css2.1/t0402-syntax-05-f-expected.png: Removed.
  • platform/gtk/css2.1/t0402-syntax-06-f-expected.png: Removed.
  • platform/gtk/css2.1/t040307-syntax-01-b-expected.png: Removed.
  • platform/gtk/css2.1/t0505-c16-descendant-02-e-expected.png: Removed.
  • platform/gtk/css2.1/t0509-id-sel-syntax-01-f-expected.png: Removed.
  • platform/gtk/css2.1/t0509-id-sel-syntax-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t0511-c21-pseud-link-00-e-expected.png: Removed.
  • platform/gtk/css2.1/t0511-c21-pseud-link-01-e-expected.png: Removed.
  • platform/gtk/css2.1/t0511-c21-pseud-link-02-e-expected.png: Removed.
  • platform/gtk/css2.1/t0511-c21-pseud-link-03-e-expected.png: Removed.
  • platform/gtk/css2.1/t051103-c21-focus-ln-00-e-i-expected.png: Removed.
  • platform/gtk/css2.1/t051103-c21-hover-ln-00-e-i-expected.png: Removed.
  • platform/gtk/css2.1/t0803-c5504-mrgn-l-02-c-expected.png: Removed.
  • platform/gtk/css2.1/t0805-c5511-brdr-tw-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t0805-c5512-brdr-rw-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t0805-c5513-brdr-bw-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t0805-c5514-brdr-lw-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t0805-c5515-brdr-w-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-01-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-02-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-03-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-04-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-05-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-06-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-07-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-08-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.png: Removed.
  • platform/gtk/css2.1/t1001-abs-pos-cb-09-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1205-c566-list-stl-01-c-g-expected.txt: Removed.
  • platform/gtk/css2.1/t140201-c532-bgcolor-01-b-expected.png: Removed.
  • platform/gtk/css2.1/t140201-c533-bgimage-01-b-g-expected.png: Removed.
  • platform/gtk/css2.1/t140201-c536-bgpos-01-b-ag-expected.png: Removed.
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-01-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-02-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-03-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-08-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-09-b-expected.txt: Removed.
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt: Removed.
  • platform/mac/css2.1/t1508-c527-font-00-b-expected.txt: Removed.
11:04 PM Changeset in webkit [158523] by akling@apple.com
  • 1 edit
    14 moves
    2 adds
    12 deletes in trunk/LayoutTests

Optimize baselines: fast/dom

Unreviewed; run "webkit-patch optimize-baselines fast/dom"

  • fast/dom/HTMLHeadElement/textInHead1-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead1-expected.txt.
  • fast/dom/HTMLHeadElement/textInHead2-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead2-expected.txt.
  • fast/dom/HTMLHeadElement/textInHead3-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead3-expected.txt.
  • fast/dom/HTMLHeadElement/textInHead4-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead4-expected.txt.
  • fast/dom/HTMLHeadElement/textInHead5-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLHeadElement/textInHead5-expected.txt.
  • fast/dom/HTMLMeterElement/meter-element-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-expected.txt.
  • fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt.
  • fast/dom/anchor-text-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/anchor-text-expected.txt.
  • fast/dom/comment-not-documentElement-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/comment-not-documentElement-expected.txt.
  • fast/dom/delete-contents-expected.png: Renamed from LayoutTests/platform/efl/fast/dom/delete-contents-expected.png.
  • fast/dom/scroll-reveal-left-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-left-overflow-expected.txt.
  • fast/dom/scroll-reveal-top-overflow-expected.txt: Renamed from LayoutTests/platform/efl/fast/dom/scroll-reveal-top-overflow-expected.txt.
  • platform/gtk/fast/dom/HTMLHeadElement/textInHead1-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLHeadElement/textInHead2-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLHeadElement/textInHead3-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLHeadElement/textInHead4-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLHeadElement/textInHead5-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt: Removed.
  • platform/gtk/fast/dom/anchor-text-expected.txt: Removed.
  • platform/gtk/fast/dom/comment-not-documentElement-expected.txt: Removed.
  • platform/gtk/fast/dom/delete-contents-expected.png: Removed.
  • platform/gtk/fast/dom/scroll-reveal-left-overflow-expected.txt: Removed.
  • platform/gtk/fast/dom/scroll-reveal-top-overflow-expected.txt: Removed.
  • platform/win-7sp0/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt.
  • platform/win-7sp0/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Renamed from LayoutTests/platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt.
10:35 PM Changeset in webkit [158522] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Add missing baselines to EFL wk1 TestExpectation.

  • platform/efl-wk1/TestExpectations: Need to add new baseline since upgrading base OS.
9:13 PM Changeset in webkit [158521] by ch.dumez@samsung.com
  • 13 edits in trunk

EnforceRange doesn't enforce range of a short
https://bugs.webkit.org/show_bug.cgi?id=123661

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Handle Web IDL short / unsigned short types as per the
specification:

Specifically, we used to treat short / unsigned short as 32bit
integers, which was wrong. We now properly handle them as 16bit
integers.

No new tests, added test cases to js/dom/webidl-type-mapping.html.

  • WebCore.exp.in:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::toSmallerInt):
(WebCore::toSmallerUInt):
(WebCore::toInt8):
(WebCore::toUInt8):
(WebCore::toInt16):
(WebCore::toUInt16):

  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):

  • testing/TypeConversions.h:

(WebCore::TypeConversions::testShort):
(WebCore::TypeConversions::setTestShort):
(WebCore::TypeConversions::testEnforceRangeShort):
(WebCore::TypeConversions::setTestEnforceRangeShort):
(WebCore::TypeConversions::testUnsignedShort):
(WebCore::TypeConversions::setTestUnsignedShort):
(WebCore::TypeConversions::testEnforceRangeUnsignedShort):
(WebCore::TypeConversions::setTestEnforceRangeUnsignedShort):

  • testing/TypeConversions.idl:

Source/WebKit:

Export symbols to fix Windows build.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

Extend js/dom/webidl-type-mapping.html layout test to validate
Web IDL type mapping for short / unsigned short.

  • js/dom/webidl-type-mapping-expected.txt:
  • js/dom/webidl-type-mapping.html:
8:25 PM Changeset in webkit [158520] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Fix compilation of DateMath.cpp with MSVC
https://bugs.webkit.org/show_bug.cgi?id=123680

Reviewed by Darin Adler.

  • wtf/DateMath.cpp:

(WTF::appendTwoDigitNumber): Help the compiler finding the
correct overload by casting the characters to LChar.

8:24 PM Changeset in webkit [158519] by Patrick Gansterer
  • 6 edits in trunk/Source/WebCore

Cleanup OpenTypeUtilities
https://bugs.webkit.org/show_bug.cgi?id=123686

Reviewed by Darin Adler.

Merge the WinCE specific code into the general Windows code to
make the compilation of WinCE port on WinNT easier.

  • platform/graphics/opentype/OpenTypeUtilities.cpp:

(WebCore::renameFont):
(WebCore::renameAndActivateFont):

  • platform/graphics/opentype/OpenTypeUtilities.h:
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/wince/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

8:19 PM Changeset in webkit [158518] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Add missing getHostCallReturnValue() for MSVC ARM
https://bugs.webkit.org/show_bug.cgi?id=123685

Reviewed by Darin Adler.

  • jit/JITStubsARM.h:
8:18 PM Changeset in webkit [158517] by akling@apple.com
  • 1 edit
    26 moves
    34 deletes in trunk/LayoutTests

Optimize baselines: fast/css

Unreviewed; run "webkit-patch optimize-baselines fast/css"

  • fast/css/background-image-with-baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/background-image-with-baseurl-expected.txt.
  • fast/css/caption-width-absolute-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-expected.txt.
  • fast/css/caption-width-absolute-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt.
  • fast/css/caption-width-fixed-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-expected.txt.
  • fast/css/caption-width-fixed-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt.
  • fast/css/caption-width-relative-position-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-expected.txt.
  • fast/css/caption-width-relative-position-offset-top-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt.
  • fast/css/font-face-default-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-default-font-expected.txt.
  • fast/css/font-face-in-media-rule-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-face-in-media-rule-expected.txt.
  • fast/css/font-size-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/font-size-negative-expected.txt.
  • fast/css/imageTileOpacity-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/imageTileOpacity-expected.txt.
  • fast/css/import_with_baseurl-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/import_with_baseurl-expected.txt.
  • fast/css/line-height-determined-by-primary-font-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-determined-by-primary-font-expected.txt.
  • fast/css/line-height-font-order-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-font-order-expected.txt.
  • fast/css/line-height-negative-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/line-height-negative-expected.txt.
  • fast/css/max-height-none-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/max-height-none-expected.txt.
  • fast/css/min-width-with-spanned-cell-expected.png: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.png.
  • fast/css/min-width-with-spanned-cell-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-expected.txt.
  • fast/css/min-width-with-spanned-cell-fixed-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt.
  • fast/css/pseudo-first-line-border-width-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/pseudo-first-line-border-width-expected.txt.
  • fast/css/replaced-element-implicit-size-expected.png: Renamed from LayoutTests/platform/efl/fast/css/replaced-element-implicit-size-expected.png.
  • fast/css/vertical-align-lengths-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/vertical-align-lengths-expected.txt.
  • fast/css/visibility-hit-test-expected.txt: Renamed from LayoutTests/platform/efl/fast/css/visibility-hit-test-expected.txt.
  • platform/efl-wk2/fast/css/font-smoothing-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-smoothing-expected.png.
  • platform/efl-wk2/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-weight-1-expected.png.
  • platform/efl-wk2/fast/css/input-search-padding-expected.png: Renamed from LayoutTests/platform/efl/fast/css/input-search-padding-expected.png.
  • platform/gtk/fast/css/background-image-with-baseurl-expected.txt: Removed.
  • platform/gtk/fast/css/caption-width-absolute-position-expected.txt: Removed.
  • platform/gtk/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
  • platform/gtk/fast/css/caption-width-fixed-position-expected.txt: Removed.
  • platform/gtk/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
  • platform/gtk/fast/css/caption-width-relative-position-expected.txt: Removed.
  • platform/gtk/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
  • platform/gtk/fast/css/font-face-in-media-rule-expected.txt: Removed.
  • platform/gtk/fast/css/font-size-negative-expected.txt: Removed.
  • platform/gtk/fast/css/imageTileOpacity-expected.txt: Removed.
  • platform/gtk/fast/css/import_with_baseurl-expected.txt: Removed.
  • platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Removed.
  • platform/gtk/fast/css/line-height-font-order-expected.txt: Removed.
  • platform/gtk/fast/css/line-height-negative-expected.txt: Removed.
  • platform/gtk/fast/css/max-height-none-expected.txt: Removed.
  • platform/gtk/fast/css/min-width-with-spanned-cell-expected.png: Removed.
  • platform/gtk/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
  • platform/gtk/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
  • platform/gtk/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
  • platform/gtk/fast/css/replaced-element-implicit-size-expected.png: Removed.
  • platform/gtk/fast/css/vertical-align-lengths-expected.txt: Removed.
  • platform/gtk/fast/css/visibility-hit-test-expected.txt: Removed.
  • platform/mac/fast/css/caption-width-absolute-position-expected.txt: Removed.
  • platform/mac/fast/css/caption-width-absolute-position-offset-top-expected.txt: Removed.
  • platform/mac/fast/css/caption-width-fixed-position-expected.txt: Removed.
  • platform/mac/fast/css/caption-width-fixed-position-offset-top-expected.txt: Removed.
  • platform/mac/fast/css/caption-width-relative-position-expected.txt: Removed.
  • platform/mac/fast/css/caption-width-relative-position-offset-top-expected.txt: Removed.
  • platform/mac/fast/css/font-face-default-font-expected.txt: Removed.
  • platform/mac/fast/css/font-face-in-media-rule-expected.txt: Removed.
  • platform/mac/fast/css/min-width-with-spanned-cell-expected.txt: Removed.
  • platform/mac/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Removed.
  • platform/mac/fast/css/pseudo-first-line-border-width-expected.txt: Removed.
  • platform/win/fast/css/zoom-body-scroll-expected.txt: Removed.
8:16 PM Changeset in webkit [158516] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix MSVC warning about unary minus operator
https://bugs.webkit.org/show_bug.cgi?id=123674

Reviewed by Darin Adler.

Change some static_cast<> to silence the following warning of Microsoft compiler:
warning C4146: unary minus operator applied to unsigned type, result still unsigned

  • jit/Repatch.cpp:

(JSC::emitPutTransitionStub):

7:36 PM Changeset in webkit [158515] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

CSSFontFaceSrcValue constructors should return PassRef.
<https://webkit.org/b/123692>

Make functions that return non-null CSSFontFaceSrcValues return
PassRef instead of PassRefPtr. Tweak some call sites to be
slightly more efficient.

Reviewed by Anders Carlsson.

7:33 PM Changeset in webkit [158514] by akling@apple.com
  • 17 edits in trunk/Source/WebCore

CSSStyleSheet::contents() should return a reference.
<https://webkit.org/b/123689>

Make CSSStyleSheet::contents() return a StyleSheetContents& instead
of a pointer. The object was already stored in a Ref.

Reviewed by Anders Carlsson.

7:14 PM Changeset in webkit [158513] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSReflectValue constructor should return PassRef.
<https://webkit.org/b/123963>

Make CSSReflectValue::create() return a PassRef. Tweak one call
site to be slightly more efficient.

Reviewed by Anders Carlsson.

7:12 PM Changeset in webkit [158512] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSFontFeatureValue constructor should return PassRef.
<https://webkit.org/b/123691>

Make CSSFontFeatureValue::create() return PassRef, since it never
returns null. Tweak one call site to be slightly more efficient.

Reviewed by Anders Carlsson.

7:04 PM Changeset in webkit [158511] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Tighten typing in SVGResources::buildCachedResources().
<https://webkit.org/b/123690>

Make this function take a RenderElement&/SVGRenderStyle& pair instead
of a RenderObject*/SVGRenderStyle* pair. Also tweaked the code a bit,
removing ampersands and asserts as appropriate.

Reviewed by Anders Carlsson.

6:47 PM Changeset in webkit [158510] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Disable LLVM's pretty stack traces, which involve intercepting fatal signals
https://bugs.webkit.org/show_bug.cgi?id=123681

Reviewed by Geoffrey Garen.

  • llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

6:33 PM Changeset in webkit [158509] by fpizlo@apple.com
  • 10 edits
    1 add in trunk

LLVM assertion failures should funnel into WTF's crash handling
https://bugs.webkit.org/show_bug.cgi?id=123682

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Inside llvmForJSC, we override assertion-related functions and funnel them
into g_llvmTrapCallback(). We also now register a fatal error handler inside
the library and funnel that into g_llvmTrapCallback, and have
initializeAndGetJSCLLVMAPI() take such a callback as an argument.

Inside JSC, we no longer call LLVMInstallFatalErrorHandler() but instead we
pass WTFLogAlwaysAndCrash() as the trap callback for llvmForJSC.

  • llvm/InitializeLLVM.cpp:

(JSC::initializeLLVM):

  • llvm/InitializeLLVMPOSIX.cpp:

(JSC::initializeLLVMPOSIX):

  • llvm/library/LLVMExports.cpp:

(llvmCrash):
(initializeAndGetJSCLLVMAPI):

  • llvm/library/LLVMOverrides.cpp:

(raise):
(assert_rtn):
(abort):

  • llvm/library/LLVMTrapCallback.h: Added.

Source/WTF:

Reviewed by Geoffrey Garen.

Give JSC some new toys to play with for crash handling.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:

Tools:

Reviewed by Geoffrey Garen.

Need to disable LLVM's crash overrides so that we can do our own crash overrides.

  • Scripts/configure-llvm:
6:30 PM Changeset in webkit [158508] by fpizlo@apple.com
  • 3 edits in trunk/WebKitLibraries

Unreviewed, update binary drops.

These include my LLVMDisablePrettyStackTrace() fix and are built with --enable-crash-overrides=no

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
5:32 PM Changeset in webkit [158507] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

CodeBlock::jettison() shouldn't call baselineVersion()
https://bugs.webkit.org/show_bug.cgi?id=123675

Reviewed by Geoffrey Garen.

Fix more uses of baselineVersion().

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):

  • bytecode/CodeBlock.h:
  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:

(JSC::ProfiledCodeBlockJettisoningWatchpoint::fireInternal):

5:29 PM Changeset in webkit [158506] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

LLVM asserts in internal-js-tests.yaml/Octane/stress-tests/mandreel.js
https://bugs.webkit.org/show_bug.cgi?id=123535

Reviewed by Geoffrey Garen.

Use double comparisons for doubles.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::doubleToInt32):

4:56 PM Changeset in webkit [158505] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

CSSImageValue constructors should return PassRef.
<https://webkit.org/b/123688>

Make the CSSImageValue::create() helpers return PassRef.
Tightened call sites to avoid null checks and destructor calls.

Reviewed by Anders Carlsson.

3:17 PM Changeset in webkit [158504] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Fix compilation of SynchronousLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=123676

Reviewed by Darin Adler.

Assign a ResourceRequest varibale an empty ResourceRequest instead of 0.
The current solution only works for ports which can create a
ResourceRequest from a pointer, which might not be true for all ports.

  • platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::willSendRequest):

2:59 PM Changeset in webkit [158503] by Patrick Gansterer
  • 2 edits in trunk

[WINCE] Disable export macros
https://bugs.webkit.org/show_bug.cgi?id=123679

Reviewed by Darin Adler.

Avoid useless exports by turning of the export macros
since the WinCE port works as a static library only.

  • Source/cmake/OptionsWinCE.cmake:
2:58 PM Changeset in webkit [158502] by Patrick Gansterer
  • 3 edits in trunk/Source/WebCore

Port LoggingWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=123678

Reviewed by Darin Adler.

This makes it easier to use a common list of files
for the different Windows ports later.

  • PlatformWin.cmake:
  • platform/win/LoggingWin.cpp:

(WebCore::logLevelString):

2:56 PM Changeset in webkit [158501] by Patrick Gansterer
  • 14 edits in trunk/Source/WebKit/wince

Add OVERRIDE keyword to WebCoreSupport classes
https://bugs.webkit.org/show_bug.cgi?id=123672

Reviewed by Darin Adler.

Also align the function parameters with the base classes
and remove useless functions.

  • WebCoreSupport/ChromeClientWinCE.cpp:
  • WebCoreSupport/ChromeClientWinCE.h:
  • WebCoreSupport/ContextMenuClientWinCE.cpp:
  • WebCoreSupport/ContextMenuClientWinCE.h:
  • WebCoreSupport/DragClientWinCE.cpp:

(WebKit::DragClientWinCE::willPerformDragDestinationAction):
(WebKit::DragClientWinCE::willPerformDragSourceAction):
(WebKit::DragClientWinCE::actionMaskForDrag):
(WebKit::DragClientWinCE::startDrag):

  • WebCoreSupport/DragClientWinCE.h:
  • WebCoreSupport/EditorClientWinCE.h:
  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
(WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
(WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):

  • WebCoreSupport/FrameLoaderClientWinCE.h:
  • WebCoreSupport/FrameNetworkingContextWinCE.h:
  • WebCoreSupport/InspectorClientWinCE.cpp:
  • WebCoreSupport/InspectorClientWinCE.h:
  • WebCoreSupport/PlatformStrategiesWinCE.h:
2:56 PM Changeset in webkit [158500] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

[Cocoa] Wrappers mishandle NULL values in arrays and dictionaries
https://bugs.webkit.org/show_bug.cgi?id=123671

Reviewed by Darin Adler.

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray objectAtIndex:]): Represent a NULL object as NSNull.

  • Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary objectForKey:]): Represent a NULL value as NSNull.

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get): Added this overload that returns whether the key exists.

2:47 PM Changeset in webkit [158499] by Patrick Gansterer
  • 8 edits in trunk/Source

Fix UnicodeWchar after r157330.
https://bugs.webkit.org/show_bug.cgi?id=123668

Reviewed by Darin Adler.

Source/WebCore:

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::append):

  • platform/graphics/wince/FontWinCE.cpp:

(WebCore::generateComponents):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawText):

  • platform/text/wchar/TextBreakIteratorWchar.cpp:

(WebCore::isCharStop):
(WebCore::isLineStop):
(WebCore::isSentenceStop):
(WebCore::WordBreakIterator::next):
(WebCore::WordBreakIterator::previous):

Source/WTF:

  • wtf/unicode/wchar/UnicodeWchar.cpp:

(unorm_normalize):
(u_strFoldCase):
(u_strToLower):
(u_strToUpper):

  • wtf/unicode/wchar/UnicodeWchar.h:

(u_foldCase):
(u_isprint):
(u_isspace):

2:18 PM Changeset in webkit [158498] by akling@apple.com
  • 7 edits in trunk/Source

Make remaining StringImpl functions return PassRef.
<https://webkit.org/b/123683>

Okay, this seems to work well! Let's go all in and convert the
remaining StringImpl functions to return PassRef<StringImpl> instead
of PassRefPtr where we know that null is never returned.

Reviewed by Anders Carlsson.

2:18 PM Changeset in webkit [158497] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Use RenderChildIterator in a couple of places.
<https://webkit.org/b/123684>

Added isRendererOfType() for RenderBox and RenderBlock and switch
some loops over to using childrenOfType<>. Also sprinkled const
and references on touched code.

Reviewed by Antti Koivisto.

2:03 PM Changeset in webkit [158496] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Manage FileReaderLoader through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=123666

Reviewed by Anders Carlsson.

Construct FileReaderLoader objects through std::make_unique and store them in std::unique_ptr.

  • fileapi/FileReader.cpp:

(WebCore::FileReader::readInternal):

  • fileapi/FileReader.h:
12:51 PM Changeset in webkit [158495] by akling@apple.com
  • 10 edits
    2 adds in trunk/Source/WebCore

Add a child renderer iterator.
<https://webkit.org/b/123662>

Introduce an ElementIterator-style iterator for renderers and put
it to use in a childrenOfType() implementation.

It's used just like the Element iterators:

auto sections = childrenOfType<RenderTableSection>(*this);
for (auto section = sections.begin(), section = sections.end(); section != sections.end(); ++section)

section->thisOrThat();

Just like the DOM counterpart, it relies on a templatized helper:

bool isRendererOfType<T>(const RenderObject&)

This patch puts the iterator to use in a couple of random places.

Reviewed by Antti Koivisto.

11:19 AM Changeset in webkit [158494] by ap@apple.com
  • 4 edits
    12 copies
    8 adds in trunk

Implement remaining SHA variations for WebCrypto
https://bugs.webkit.org/show_bug.cgi?id=123659

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/sha-224.html

crypto/subtle/sha-256.html
crypto/subtle/sha-384.html
crypto/subtle/sha-512.html

  • WebCore.xcodeproj/project.pbxproj:
  • crypto/algorithms/CryptoAlgorithmSHA224.cpp: Added.

(WebCore::CryptoAlgorithmSHA224::CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::~CryptoAlgorithmSHA224):
(WebCore::CryptoAlgorithmSHA224::create):
(WebCore::CryptoAlgorithmSHA224::identifier):

  • crypto/algorithms/CryptoAlgorithmSHA224.h: Added.
  • crypto/algorithms/CryptoAlgorithmSHA256.cpp: Added.

(WebCore::CryptoAlgorithmSHA256::CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::~CryptoAlgorithmSHA256):
(WebCore::CryptoAlgorithmSHA256::create):
(WebCore::CryptoAlgorithmSHA256::identifier):

  • crypto/algorithms/CryptoAlgorithmSHA256.h: Added.
  • crypto/algorithms/CryptoAlgorithmSHA384.cpp: Added.

(WebCore::CryptoAlgorithmSHA384::CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::~CryptoAlgorithmSHA384):
(WebCore::CryptoAlgorithmSHA384::create):
(WebCore::CryptoAlgorithmSHA384::identifier):

  • crypto/algorithms/CryptoAlgorithmSHA384.h: Added.
  • crypto/algorithms/CryptoAlgorithmSHA512.cpp: Added.

(WebCore::CryptoAlgorithmSHA512::CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::~CryptoAlgorithmSHA512):
(WebCore::CryptoAlgorithmSHA512::create):
(WebCore::CryptoAlgorithmSHA512::identifier):

  • crypto/algorithms/CryptoAlgorithmSHA512.h: Added.
  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/mac/CryptoAlgorithmSHA224Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA224::digest):

  • crypto/mac/CryptoAlgorithmSHA256Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA256::digest):

  • crypto/mac/CryptoAlgorithmSHA384Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA384::digest):

  • crypto/mac/CryptoAlgorithmSHA512Mac.cpp: Added.

(WebCore::CryptoAlgorithmSHA512::digest):

LayoutTests:

  • crypto/subtle/sha-224-expected.txt: Added.
  • crypto/subtle/sha-224.html: Added.
  • crypto/subtle/sha-256-expected.txt: Added.
  • crypto/subtle/sha-256.html: Added.
  • crypto/subtle/sha-384-expected.txt: Added.
  • crypto/subtle/sha-384.html: Added.
  • crypto/subtle/sha-512-expected.txt: Added.
  • crypto/subtle/sha-512.html: Added.
10:54 AM Changeset in webkit [158493] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed release builds.

  • Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary initWithObjects:forKeys:count:]):

10:33 AM Changeset in webkit [158492] by Patrick Gansterer
  • 12 edits in trunk/Source

Various small WinCE build fixes

Source/JavaScriptCore:

  • jsc.cpp:

(main):

Source/WebCore:

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::append):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • platform/graphics/wince/PlatformPathWinCE.h:
  • platform/win/PopupMenuWin.h:
  • rendering/RenderThemeWinCE.cpp:

(WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::transitionToCommittedForNewPage):

  • WebView.cpp:
10:26 AM Changeset in webkit [158491] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

Fix MSVC ARM build after r157581.

  • jit/JITStubsARM.h:
9:59 AM Changeset in webkit [158490] by akling@apple.com
  • 3 edits in trunk/Source/WTF

StringImpl::upper() should return PassRef.
<https://webkit.org/b/123655>

Make upper() return PassRef<StringImpl>. Spotted and removed some
ref churning in implementations.

Reviewed by Darin Adler.

9:42 AM Changeset in webkit [158489] by mitz@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit2

[Cocoa] Add WKNSDictionary
https://bugs.webkit.org/show_bug.cgi?id=123660

Reviewed by Anders Carlsson.

  • Shared/Cocoa/APIObject.mm:

(WebKit::APIObject::newObject): Allocate a WKNSDictionary if the APIObject is a dictionary.

  • Shared/Cocoa/WKNSDictionary.h: Added.

(WebKit::wrapper): Added. Returns an ImmutableDictionary’s wrapper as an NSDictionary.

  • Shared/Cocoa/WKNSDictionary.mm: Added.

(-[WKNSDictionary dealloc]): Calls the ImmutableDictionary destructor.
(-[WKNSDictionary count]): Added.
(-[WKNSDictionary objectForKey:]): Added.
(-[WKNSDictionary keyEnumerator]): Added.
(-[WKNSDictionary copyWithZone:]): Retains self.
(-[WKNSDictionary _apiObject]): Returns the wrapped ImmutableDictionary.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
9:04 AM Changeset in webkit [158488] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Address some review comments noted in r158463
https://bugs.webkit.org/show_bug.cgi?id=123646

Reviewed by Darin Adler.

  • Shared/mac/RemoteLayerBackingStore.mm:

Put our has_include ifs all on one line.

(createIOSurface):
IOSurfaceAlignProperty returns size_t, not unsigned long.

(RemoteLayerBackingStore::display):
(RemoteLayerBackingStore::drawInContext):
Create the frontImage in display() and hand it to drawInContext().

Use the GraphicsContext API instead of CG itself for clearRect().

When using ShareableBitmap, replace m_frontBuffer instead of
having a backBuffer local; the CGImageRef will retain the
ShareableBitmap it references.

Duplicate our drawInContext() calls so we don't have to allocate
a GraphicsContext on the heap in the IOSurface case.

Don't bother clearing frontContext; it'll happen for us at
the appropriate time. Instead, assert that it's still alive after
we drop our reference to the frontImage created from it.

7:34 AM Changeset in webkit [158487] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[GTK] invalid use of incomplete type 'class WTF::PassOwnPtr<WTF::Vector<unsigned char> >'
https://bugs.webkit.org/show_bug.cgi?id=123601

Reviewed by Carlos Garcia Campos.

  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: Explicitly include the PassOwnPtr.h header

as certain configurations on the GTK port don't ensure that the header is included indirectly.

3:10 AM Changeset in webkit [158486] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] invalid application of 'sizeof' to incomplete type
https://bugs.webkit.org/show_bug.cgi?id=123502

Patch by Vitaly Katunin <vkatunin@luxoft.com> on 2013-11-02
Reviewed by Carlos Garcia Campos.

  • Shared/WebCoreArgumentCoders.cpp:
Note: See TracTimeline for information about the timeline view.