Timeline



Nov 11, 2013:

11:56 PM Changeset in webkit [159098] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remote Layer Tree: Sporadic memory corruption during painting
https://bugs.webkit.org/show_bug.cgi?id=124191

Reviewed by Brady Eidson.

Fix a logic error (flipped the logic, didn't flip the operator)
made in the last version of r158982 that caused some crashes because
it allowed us to overrun the end of cgPaintingRects.

  • Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::drawInContext):

11:56 PM Changeset in webkit [159097] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Un-segment some Vectors.
<https://webkit.org/b/124188>

Turn some SegmentedVectors into Vectors where the final item count
is known at CodeBlock construction time. This removes unnecessary
allocation and indirection.

I've got ~4.5 MB below SegmentedVector<ValueProfile>::ensureSegment
on Membuster3 (peak, before pressure signal) so this should help
take a bit of the edge off there.

Reviewed by Geoffrey Garen.

10:43 PM Changeset in webkit [159096] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159088.
http://trac.webkit.org/changeset/159088
https://bugs.webkit.org/show_bug.cgi?id=124187

It broke the EFL build, because it removed a used function
(rs=thorton) (Requested by Ossy_night on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-11-11

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::urlAtProcessExit):
(WebKit::WebPageProxy::loadStateAtProcessExit):

10:35 PM Changeset in webkit [159095] by beidson@apple.com
  • 7 edits in trunk/Source/WebCore

Make IDBTransaction tasks asynchronous
https://bugs.webkit.org/show_bug.cgi?id=124183

Reviewed by Tim Horton.

This is an almost zero-change in behavior.

The one thing that is different is that previously, IDBTransactionBackends would synchronously
run through their entire set of IDBOperation’s without ever returning control to the runloop.

Now, they start one task and then wait for its completion to schedule the start of the next task.

Change IDBOperation’s perform() to take a completion handler so it can be asynchronous.
Add an IDBSynchronousOperation class to handle "Abort" tasks, which never need to perform i/o
and therefore can be entirely synchronous.

  • Modules/indexeddb/IDBOperation.h:

(WebCore::IDBSynchronousOperation::~IDBSynchronousOperation):

  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::scheduleTask): "Abort tasks" are now IDBSynchronousOperations.
(WebCore::IDBTransactionBackend::abort):
(WebCore::IDBTransactionBackend::taskTimerFired): Instead of running through the entire set of tasks,

perform a single task asynchronously. The completion handler for the task will reset the task timer
to asynchronously start the next task.

  • Modules/indexeddb/IDBTransactionBackend.h:

(WebCore::IDBTransactionBackend::scheduleTask): "Abort tasks" are now IDBSynchronousOperations.

Update all operations to take completion handlers.
For now, perform things synchronously like before, calling the completion handler when complete.

  • Modules/indexeddb/IDBCursorBackend.cpp:

(WebCore::CallOnDestruct::CallOnDestruct): Helper class to make sure completion callbacks are always called perform() exits.
(WebCore::CallOnDestruct::~CallOnDestruct):
(WebCore::IDBCursorBackend::CursorIterationOperation::create):
(WebCore::IDBCursorBackend::CursorAdvanceOperation::create):
(WebCore::IDBCursorBackend::CursorPrefetchIterationOperation::create):
(WebCore::IDBCursorBackend::CursorAdvanceOperation::perform):
(WebCore::IDBCursorBackend::CursorIterationOperation::perform):
(WebCore::IDBCursorBackend::CursorPrefetchIterationOperation::perform):

  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::CallOnDestruct::CallOnDestruct): Helper class to make sure completion callbacks are always called when perform() exits.
(WebCore::CallOnDestruct::~CallOnDestruct):
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::SetIndexesReadyOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):

  • Modules/indexeddb/IDBTransactionBackendOperations.h:

(WebCore::CreateObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::create):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::IDBDatabaseBackend::VersionChangeAbortOperation::create):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::GetOperation::create):
(WebCore::PutOperation::create):
(WebCore::SetIndexesReadyOperation::create):
(WebCore::OpenCursorOperation::create):
(WebCore::CountOperation::create):
(WebCore::DeleteRangeOperation::create):
(WebCore::ClearOperation::create):

10:15 PM Changeset in webkit [159094] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r159077 to make GTK build happy.

  • GNUmakefile.list.am:
8:39 PM Changeset in webkit [159093] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove some unused generated code
https://bugs.webkit.org/show_bug.cgi?id=124179

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-11
Reviewed by Timothy Hatcher.

  • inspector/CodeGeneratorInspectorStrings.py:
8:39 PM Changeset in webkit [159092] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Clean up static_cast<Element*> usage
https://bugs.webkit.org/show_bug.cgi?id=124133

Reviewed by Andreas Kling.

We need to use toFoo cast function instead of static_cast<>. Though there is toElement(),
static_cast<Element*> is still being used.

No new tests, no behavior changes.

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • dom/ElementTraversal.h:

(WebCore::::lastWithinTemplate):
(WebCore::::nextTemplate):
(WebCore::::previousTemplate):

7:28 PM Changeset in webkit [159091] by fpizlo@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Get rid of the lastResultRegister optimization in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=124171

Rubber stamped by Mark Hahnenberg.

The baseline JIT no longer needs amazing throughput. And this optimization has caused
way too many OSR exit bugs. And it constrains how much we can do in the DFG/FTL. So,
I'm getting rid of it.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::convertToForward):

  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):

  • ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::convertToForward):

  • ftl/FTLOSRExit.h:
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::appendCall):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):

  • jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):

  • jit/JITInlines.h:

(JSC::JIT::emitGetFromCallFrameHeaderPtr):
(JSC::JIT::emitGetFromCallFrameHeader32):
(JSC::JIT::emitGetFromCallFrameHeader64):
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitGetVirtualRegisters):
(JSC::JIT::emitPutVirtualRegister):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_new_func):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_catch):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emitResolveClosure):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_init_global_const):

  • jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

5:55 PM Changeset in webkit [159090] by Gustavo Noronha Silva
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r158976): Web Inspector: unable to start docked or dock
https://bugs.webkit.org/show_bug.cgi?id=124148

Reviewed by Timothy Hatcher.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::canAttach): check for a level that is greater than 1 rather than 0
to deny attachment, since 1 is the first level of inspectors.

5:51 PM Changeset in webkit [159089] by andersca@apple.com
  • 8 edits in trunk/Source

FrameFilter can just be an std::function instead
https://bugs.webkit.org/show_bug.cgi?id=124176

Reviewed by Tim Horton.

Source/WebCore:

  • WebCore.exp.in:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/archive/cf/LegacyWebArchive.h:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:

(-[DOMNode webArchiveByFilteringSubframes:]):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::webArchiveData):

5:17 PM Changeset in webkit [159088] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove unused Qt cruft
https://bugs.webkit.org/show_bug.cgi?id=124174

Reviewed by Tim Horton.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:
5:15 PM Changeset in webkit [159087] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

5:13 PM Changeset in webkit [159086] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.6

New Tag.

5:12 PM Changeset in webkit [159085] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.5/safari-537.73-branch

New Tag.

5:08 PM Changeset in webkit [159084] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r158927): curly-braces-escaping.html is broken on Mac WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124164

Reviewed by Alexey Proskuryakov.

Back out the change to use NSSecureCoding for encoding/decoding NSURLRequest and
NSURLResponse objects; turns out the NSURL encoding/decoding doesn't preserve the raw URL bytes.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodePlatformData):
(CoreIPC::decodePlatformData):

4:52 PM Changeset in webkit [159083] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix on CMake Based port since r159077.

  • CMakeLists.txt:
4:50 PM Changeset in webkit [159082] by Simon Fraser
  • 5 edits
    2 adds in trunk

REGRESSION (r155660): box-shadow causes overlay scrollbars to be in the wrong position when element is composited (85647)
https://bugs.webkit.org/show_bug.cgi?id=124090

Source/WebCore:

Reviewed by Beth Dakin.

After r155660 we did fewer layouts, so were left with overlay scrollbars in the
wrong locations because nothing would update them after RenderLayerBacking
computed a new offsetFromRenderer.

First part of the fix is to wean positionOverflowControlsLayers() off of
an absolute offset from the root. Do this by not using Widget::frameRect()
to position the layers, but instead RenderLayer::rectFor{Horizontal|Vertical}Scrollbar
which is what we used to position the scrollbars in the first place.

Second part of the fix is to call positionOverflowControlsLayers() from
RenderLayerBacking::updateGraphicsLayerGeometry() if the offsetFromRenderer
changed.

Test: compositing/overflow/overflow-scrollbar-layer-positions.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::positionOverflowControls):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

  • rendering/RenderLayerBacking.h:

LayoutTests:

Reviewed by Beth Dakin.

Test, but it doesn't actually test the fix until we enable overlay scrollbars
in tests (bug 60716).

  • compositing/overflow/overflow-scrollbar-layer-positions-expected.txt: Added.
  • compositing/overflow/overflow-scrollbar-layer-positions.html: Added.
4:33 PM Changeset in webkit [159081] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Win] m_isCompositeFontReference is uninitialized.
https://bugs.webkit.org/show_bug.cgi?id=124170

Reviewed by Tim Horton.

Initialize value to false, as is done in the other constructors for this data type.

  • platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

4:21 PM Changeset in webkit [159080] by Simon Fraser
  • 2 edits
    1 add in trunk/LayoutTests

Actually land a result for the test that I added (and make it a text test).

  • compositing/tiling/tiled-in-iframe-expected.txt: Added.
  • compositing/tiling/tiled-in-iframe.html:
4:20 PM Changeset in webkit [159079] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

Remote Layer Tree: Implement Page Overlays
https://bugs.webkit.org/show_bug.cgi?id=124165
<rdar://problem/15199056>

Reviewed by Anders Carlsson.

Implement page overlays, very similar to how they work in TiledCoreAnimationDrawingArea,
but manipulating the PlatformCALayer tree instead of the CALayer tree directly.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::outOfTreeLayerWasAdded):
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWillBeRemoved):
(WebKit::RemoteLayerTreeContext::flushLayers):
Add a list of out-of-tree GraphicsLayers which are flushed in addition
to the page's GraphicsLayer tree, and functions to manipulate this list.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

Make RemoteLayerTreeDrawingArea a GraphicsLayerClient, so we can get callbacks
from the GraphicsLayers that drive our page overlays.
Override the relevant page overlay functions.
Add storage for the root layer, view size, and a map of PageOverlay->GraphicsLayer.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
Store the root GraphicsLayer for later use.

(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):
Update the size of the page overlays when the DrawingArea's geometry changes.

(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Update the page overlay settings when necessary.

(WebKit::RemoteLayerTreeDrawingArea::didInstallPageOverlay):
Create a GraphicsLayer for our page overlay, set it up, and parent it.
Inform the RemoteLayerTreeContext that it will need to flush this GraphicsLayer,
since it's not a part of the page's GraphicsLayer tree.

(WebKit::RemoteLayerTreeDrawingArea::didUninstallPageOverlay):
Tear down our page overlay's GraphicsLayer.

(WebKit::RemoteLayerTreeDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::RemoteLayerTreeDrawingArea::setPageOverlayOpacity):
(WebKit::RemoteLayerTreeDrawingArea::paintContents):
(WebKit::RemoteLayerTreeDrawingArea::deviceScaleFactor):

4:19 PM Changeset in webkit [159078] by Lucas Forschler
  • 1 edit in branches/safari-537.73-branch/Tools/ChangeLog

svn auth test.

3:32 PM Changeset in webkit [159077] by andersca@apple.com
  • 7 edits
    2 adds in trunk/Source/WebKit2

Add a FrameLoadState object and begin moving loading related members from WebFrameProxy
https://bugs.webkit.org/show_bug.cgi?id=124163

Reviewed by Beth Dakin.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetFrameLoadState):

  • UIProcess/FrameLoadState.cpp: Added.

(WebKit::FrameLoadState::FrameLoadState):
(WebKit::FrameLoadState::~FrameLoadState):

  • UIProcess/FrameLoadState.h: Added.
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didSameDocumentNavigation):
(WebKit::WebFrameProxy::setUnreachableURL):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::frameLoadState):
(WebKit::WebFrameProxy::loadState):
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
(WebKit::WebFrameProxy::unreachableURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::activeURL):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::loadStateAtProcessExit):

  • WebKit2.xcodeproj/project.pbxproj:
3:31 PM Changeset in webkit [159076] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

[Mac] Characters too close together in complex Arabic text
https://bugs.webkit.org/show_bug.cgi?id=124057

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-11
Reviewed by Darin Adler.

Source/WebCore:

We weren't updating our total width variable with run's initial
advance information, leading to widths that were too narrow.

In addition, while initial advances for runs that aren't the first
run are accounted for by baking in the initial advances into the
previous character's advance, the initial advance for the first run
has to be accounted for in ComplexTextController::offsetForPosition.

Test: fast/text/complex-grapheme-cluster-with-initial-advance.html
Test: fast/text/selection-in-initial-advance-region.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Update
total width variable
(WebCore::ComplexTextController::offsetOfPosition): Account for
the first run's initial advance.

LayoutTests:

complex-grapheme-cluster-with-initial-advance adds a span around a word in some
complex Arabic text, and expects that the word spacing is the same as without the
span.

selection-in-initial-advance-region simulates a mouse drag across a complex text run
with an initial advance. This makes sure that ComplexTextController::offsetForPosition
doesn't crash when there is an initial advance.

  • fast/text/complex-grapheme-cluster-with-initial-advance-expected.html: Added.
  • fast/text/complex-grapheme-cluster-with-initial-advance.html: Added.
  • fast/text/selection-in-initial-advance-region-expected.txt: added
  • fast/text/selection-in-initial-advance-region.html: added
3:29 PM Changeset in webkit [159075] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove #include from test input of the *Messages.in processing scripts.
https://bugs.webkit.org/show_bug.cgi?id=123563

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-11
Reviewed by Darin Adler.

  • Scripts/webkit2/messages_unittest.py:
3:01 PM Changeset in webkit [159074] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove ConstantFoldingPhase's weirdo compile-time optimization
https://bugs.webkit.org/show_bug.cgi?id=124169

Reviewed by Mark Hahnenberg.

It turns out that this compile-time optimization doesn't optimize compile times
anymore. Kill it with fire.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

2:47 PM Changeset in webkit [159073] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix for Win64.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Fixed 64-bit linker symbols.

2:41 PM Changeset in webkit [159072] by beidson@apple.com
  • 7 edits in trunk/Source/WebCore

Make IDBBackingStoreTransaction be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=124168

Reviewed by Tim Horton.

This is necessarily to safely add a fully asynchronous interface into the IDB mechanism.

  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBBackingStoreTransactionInterface.h:
  • Modules/indexeddb/IDBTransactionBackend.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
2:39 PM Changeset in webkit [159071] by Antti Koivisto
  • 9 edits
    2 adds in trunk

End of line whitespace should collapse with white-space:pre-wrap; overflow-wrap:break-word in all cases
https://bugs.webkit.org/show_bug.cgi?id=124158

Source/WebCore:

Reviewed by Dave Hyatt.

If a word just fits the line but the following space overflows we fail to collapse whitespaces
at the end of the line. This happens because with break-word we end up taking word breaking
code path that does not have pre-wrap whitespace handling.

This patch makes the behavior consistent and also matches Firefox.

Test: fast/text/break-word-pre-wrap.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::BreakingContext::handleText):

Don't take the word break code path if we are pre-wrap and the current character is space.
Instead proceed to break the line normally as this is a valid break position.

LayoutTests:

Reviewed by Dave Hyatt.

Added a specific test and updates the test results of some complex tests that demonstrate the same issue.

  • fast/text/break-word-pre-wrap-expected.html: Added.
  • fast/text/break-word-pre-wrap.html: Added.
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt:
2:25 PM Changeset in webkit [159070] by betravis@adobe.com
  • 9 edits
    3 adds in trunk

Web Inspector: [CSS Shapes] Highlight shape-outside when its element is selected in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=124071

Reviewed by Timothy Hatcher.

Source/WebCore:

Adding code to pass computed shape information (path and bounds) to the Inspector overlay
canvas, and the code to display it. The code creates a path based on ShapeInfo's computed
shape. The shape highlight draws whenever an element is highlighted, via selection in
the Inspector elements view.

Test: inspector-protocol/model/highlight-shape-outside.html

  • inspector/InspectorOverlay.cpp:

(WebCore::localPointToRoot): Convert a local point to be relative to the root view.
(WebCore::appendPathCommandAndPoints): Helper for building a single segment's worth
of the overall path.
(WebCore::appendPathSegment): Build a single segment's worth of the overall path.
(WebCore::buildObjectForShapeOutside): Build an object to pass to the Inspector overlay
that represents the shape.
(WebCore::buildObjectForElementInfo): Call buildObjectForShapeOutside and pass the
resulting object along.

  • inspector/InspectorOverlayPage.js:

(pathCommand): Draw a single path command.
(drawPath): Draw the overall path.
(_drawShapeHighlight): Draw the highlight for the given shapeInfo.
(drawNodeHighlight): Call _drawShapeHighlight.

  • rendering/shapes/PolygonShape.h:

(WebCore::PolygonShape::polygon): Expose the underlying vertex information for a
PolygonShape.

  • rendering/shapes/RasterShape.h:
  • rendering/shapes/RectangleShape.h:

(WebCore::RectangleShape::logicalRx): Expose the logical radii for a shape.
(WebCore::RectangleShape::logicalRy): Ditto.

  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::computedShapePhysicalBoundingBox): The physical bounds of a
shape in renderer coordinates.
(WebCore::ShapeInfo::shapeToRendererPoint): Convert shape coordinates to renderer
coordinates.
(WebCore::ShapeInfo::shapeToRendererSize): Ditto.
(WebCore::ShapeInfo::ShapeInfo):

LayoutTests:

Test that the information passed to the Inspector overlay properly corresponds to the
underlying shape. Retrieving the shape highlight information involves a series of
steps and has been abstracted into shape-info-helper.js, which supplies
Inspector.shapeOutsideInfo inside an Inspector test, and the ShapeInfoHelper.runShapesTest
method to begin a test.

  • inspector-protocol/model/highlight-shape-outside-expected.txt: Added.
  • inspector-protocol/model/highlight-shape-outside.html: Added.
  • inspector-protocol/resources/shape-info-helper.js: Added.

(window.ShapeInfoHelper): Exposes ShapeInfoHelper.runShapesTest.

1:46 PM Changeset in webkit [159069] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make bytecode dumping use the right opcode names for inc/dec.

Rubber stamped by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

1:20 PM Changeset in webkit [159068] by ap@apple.com
  • 7 edits
    4 copies in trunk/Source/WebCore

Support WebCrypto KeyPair interface
https://bugs.webkit.org/show_bug.cgi?id=124161

Reviewed by Geoffrey Garen.

No new tests yet, will be tested once generateKey is implemented for any RSA algorithms.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:

Added new files.

  • bindings/js/JSDOMPromise.h: Support returning a key pair via a promise.
  • bindings/js/JSCryptoKeyPairCustom.cpp: Added.

(WebCore::JSCryptoKeyPair::visitChildren):

  • crypto/CryptoKey.idl:

CryptoKey wrapper is reachable through KeyPair, but it doesn't have (or need)
a back pointer.

  • crypto/CryptoKeyPair.cpp: Added.

(WebCore::CryptoKeyPair::CryptoKeyPair):
(WebCore::CryptoKeyPair::~CryptoKeyPair):

  • crypto/CryptoKeyPair.h: Added.

(WebCore::CryptoKeyPair::create):
(WebCore::CryptoKeyPair::publicKey):
(WebCore::CryptoKeyPair::privateKey):

  • crypto/CryptoKeyPair.idl: Added.
1:09 PM Changeset in webkit [159067] by Samuel White
  • 3 edits
    1 move in trunk

AX: support helpText() in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=40194

Reviewed by Chris Fleizach.

Tools:

Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::helpText):

LayoutTests:

Moving layout test back to its original location. Shouldn't be platform specific.

  • accessibility/aria-help.html: Renamed from LayoutTests/platform/mac/accessibility/aria-help.html.
1:05 PM Changeset in webkit [159066] by Michał Pakuła vel Rutka
  • 6 edits in trunk/LayoutTests

Unreviewed EFL gardening

Update test expectations after r158188.

  • platform/efl/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/efl/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/efl/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
  • platform/efl/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/efl/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
1:04 PM Changeset in webkit [159065] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build after r158967
https://bugs.webkit.org/show_bug.cgi?id=124160

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-11
Reviewed by Anders Carlsson.

After r158967, gcc debug builds with "-Werror=type-limits" enabled
fail. This patch fixes it.

  • rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::intervalsAt):

12:57 PM Changeset in webkit [159064] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

DFG Int52 boxing code may clobber the source without telling anyone
https://bugs.webkit.org/show_bug.cgi?id=124137

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::boxInt52): This is called in places where source is expected to be unchanged. We never call this expecting super-amazing codegen. So, preserve the source's value the dumb way (by recovering it mathematically).

  • jit/AssemblyHelpers.h: Document the invariant for boxInt52.
  • jsc.cpp:

(GlobalObject::finishCreation): It's been super annoying that sometimes we say noInline() and sometimes we say neverInlineFunction(). The LayoutTests harnesses ensure that we have something called noInline(), but it's great to also ensure that the shell has it.

LayoutTests:

Reviewed by Mark Hahnenberg.

Write the test as a JSRegress test because we currently need a couple
recompiles to get the bug. JSRegress tests are meant to be longer-running
stress tests and they are usually run with different compilation thresholds, so
that ensures that we will actually hit the relevant code path.

  • js/regress/int52-spill-expected.txt: Added.
  • js/regress/int52-spill.html: Added.
  • js/regress/script-tests/int52-spill.js: Added.

(bar):
(foo):

12:53 PM Changeset in webkit [159063] by oliver@apple.com
  • 9 edits in trunk

ExtJS breaks with modern Array.prototype.values API due to use of with()
https://bugs.webkit.org/show_bug.cgi?id=123440

Reviewed by Beth Dakin.

Source/JavaScriptCore:

As with our attempt to make Arguments use the Array prototype, ExtJS has
a weird dependency on not adding new APIs to core types. In this case
Array.prototype.values. The fix is to remove it, and push for ES6 to drop
the API.

  • runtime/ArrayPrototype.cpp:

LayoutTests:

Update tests for removal of Array.prototype.values, and add test to ensure that
it's gone.

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/array-iterators-expected.txt:
  • js/basic-for-of-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/array-iterators.js:
  • js/script-tests/basic-for-of.js:
12:17 PM Changeset in webkit [159062] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix layout test

11:58 AM Changeset in webkit [159061] by zandobersek@gmail.com
  • 238 edits in trunk/Source/WebCore

Remove the OperationsNotDeletable attribute from most of the WebIDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=124151

Reviewed by Geoffrey Garen.

The OperationsNotDeletable attribute currently doesn't have any effect, but will soon enforce
non-configurability of operations on the interface that uses the attribute. Non-configurability
of operations is the default behavior at the moment, but will be changed to follow the WebIDL
specification which requires that the operations are configurable (i.e. -- in JSC terms -- deletable).
IE and Firefox already exhibit this behavior in the majority of cases, while Chrome and Opera don't.

The attribute remains in use on the Location interface to mimic the Unforgeable attribute which
also makes operations of an interface non-configurable. Unforgeable attribute will be used instead
when support for it will be added to the JSC bindings generator.

  • Modules/battery/BatteryManager.idl:
  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/encryptedmedia/MediaKeys.idl:
  • Modules/gamepad/GamepadList.idl:
  • Modules/geolocation/Geolocation.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/mediacontrols/MediaControlsHost.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/RTCDTMFSender.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/RTCStatsResponse.idl:
  • Modules/networkinfo/NetworkInfoConnection.idl:
  • Modules/notifications/Notification.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/proximity/DeviceProximityEvent.idl:
  • Modules/quota/StorageInfo.idl:
  • Modules/quota/StorageQuota.idl:
  • Modules/speech/SpeechGrammarList.idl:
  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionResult.idl:
  • Modules/speech/SpeechRecognitionResultList.idl:
  • Modules/speech/SpeechSynthesis.idl:
  • Modules/webaudio/AnalyserNode.idl:
  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/PannerNode.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionSync.idl:
  • Modules/websockets/WebSocket.idl:
  • crypto/CryptoKey.idl:
  • crypto/SubtleCrypto.idl:
  • css/CSSHostRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSSupportsRule.idl:
  • css/CSSValueList.idl:
  • css/DOMWindowCSS.idl:
  • css/FontLoader.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/CharacterData.idl:
  • dom/ChildNode.idl:
  • dom/ClientRectList.idl:
  • dom/Clipboard.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMNamedFlowCollection.idl:
  • dom/DOMStringList.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/MutationObserver.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeIterator.idl:
  • dom/NodeList.idl:
  • dom/Range.idl:
  • dom/RangeException.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/TouchList.idl:
  • dom/TreeWalker.idl:
  • dom/UIEvent.idl:
  • dom/WebKitNamedFlow.idl:
  • dom/WheelEvent.idl:
  • fileapi/Blob.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlsCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLVideoElement.idl:
  • html/MediaController.idl:
  • html/RadioNodeList.idl:
  • html/TimeRanges.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/DOMPath.idl:
  • html/canvas/EXTDrawBuffers.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/track/AudioTrackList.idl:
  • html/track/TextTrack.idl:
  • html/track/TextTrackCue.idl:
  • html/track/TextTrackCueList.idl:
  • html/track/TextTrackList.idl:
  • html/track/TextTrackRegionList.idl:
  • html/track/VideoTrackList.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/Crypto.idl:
  • page/DOMSecurityPolicy.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/History.idl:
  • page/Navigator.idl:
  • page/Performance.idl:
  • page/PerformanceEntryList.idl:
  • page/SpeechInputResultList.idl:
  • page/WindowBase64.idl:
  • page/WindowTimers.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • svg/SVGAngle.idl:
  • svg/SVGAnimationElement.idl:
  • svg/SVGColor.idl:
  • svg/SVGCursorElement.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGException.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGGraphicsElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGLengthList.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.idl:
  • svg/SVGMatrix.idl:
  • svg/SVGNumberList.idl:
  • svg/SVGPaint.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGPathSegList.idl:
  • svg/SVGPatternElement.idl:
  • svg/SVGPoint.idl:
  • svg/SVGPointList.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStringList.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTransform.idl:
  • svg/SVGTransformList.idl:
  • workers/DedicatedWorkerGlobalScope.idl:
  • workers/Worker.idl:
  • workers/WorkerGlobalScope.idl:
  • workers/WorkerLocation.idl:
  • xml/DOMParser.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestUpload.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathException.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • xml/XSLTProcessor.idl:
11:49 AM Changeset in webkit [159060] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

Add a testcase for a tiled layer inside an iframe
https://bugs.webkit.org/show_bug.cgi?id=124159

Reviewed by Tim Horton.

Add a test for a tiled compositing layer inside an iframe.

  • compositing/tiling/resources/tiled-layer-tall.html: Added.
  • compositing/tiling/tiled-in-iframe.html: Added.
11:18 AM Changeset in webkit [159059] by andersca@apple.com
  • 10 edits in trunk

Remove block based APIs from the WebKit2 C API
https://bugs.webkit.org/show_bug.cgi?id=124157

Reviewed by Sam Weinig.

Source/WebKit2:

Remove most of the block based C APIs from WebKit2. We want to discourage people from using
them since any C API "objects" captured by blocks won't be implicitly retained which
can lead to dangling pointer bugs.

  • UIProcess/API/C/WKDatabaseManager.cpp:
  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/API/C/WKFrame.cpp:
  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:

Tools:

Update for WK2 changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(dumpSource):
(-[WK2BrowserWindowController dumpSourceToConsole:]):

10:21 AM Changeset in webkit [159058] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.2.2

Tagging the WebKitGTK+ 2.2.2 release

10:21 AM Changeset in webkit [159057] by commit-queue@webkit.org
  • 8 edits
    12 adds in trunk

[CSS Regions] Selection focusNode set to the "region" block, instead of the "source" block
https://bugs.webkit.org/show_bug.cgi?id=120769

Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-11-11
Reviewed by David Hyatt.

Source/WebCore:

When a point hits a Region block, current positionForPoint algorithm determines its
position in the DOM and returns either the start or end offset for such block, since
Region blocks have no children in the DOM.

It's necessary to map the point into Flow Thread coordinates in order to determine
the DOM position of the specific element rendered by the Region.

Top margin, padding and border points should be mapped to the beginning of the Region
block, while bottom points are mapped to the block end. The Left coordinate its just
adjusted to fit in the Flow Thread boundaries, since its not affected by the Flow
direction.

Besides, when inspecting the Flow Thread blocks looking for the last candidate box,
the Region originally associated to the point might be taken into account. Only the
blocks/boxes rendered by the Region are potential candidates.

Tests: fast/regions/selection/position-for-point-1-vert-lr.html

fast/regions/selection/position-for-point-1-vert-rl.html
fast/regions/selection/position-for-point-1.html
fast/regions/selection/position-for-point-vert-lr.html
fast/regions/selection/position-for-point-vert-rl.html
fast/regions/selection/position-for-point.html

  • rendering/RenderBlock.cpp:

(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::positionForPoint):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForPoint): Added.
It just redirects the call to the associated RenderNamedFlowFragment instance.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::mapRegionPointIntoFlowThreadCoordinates): Added.
It performs the coordinates mapping.
(WebCore::RenderRegion::positionForPoint): Added.
It determines the corresponding LayoutPoint in the FlowThread the Region
is associated to, forwarding the call to the RenderBlock class using the
FlowThread's first child block and such new point.

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/resources/helper.js:

(selectContentFromIdToPos):
(selectContentFromIdToPosVert):
(.document.onmouseup):
(onMouseUpLogSelectionAndFocus):

  • fast/regions/selection/position-for-point-1-expected.txt: Added.
  • fast/regions/selection/position-for-point-1-vert-lr-expected.txt: Added.
  • fast/regions/selection/position-for-point-1-vert-lr.html: Added.
  • fast/regions/selection/position-for-point-1-vert-rl-expected.txt: Added.
  • fast/regions/selection/position-for-point-1-vert-rl.html: Added.
  • fast/regions/selection/position-for-point-1.html: Added.
  • fast/regions/selection/position-for-point-expected.txt: Added.
  • fast/regions/selection/position-for-point-vert-lr-expected.txt: Added.
  • fast/regions/selection/position-for-point-vert-lr.html: Added.
  • fast/regions/selection/position-for-point-vert-rl-expected.txt: Added.
  • fast/regions/selection/position-for-point-vert-rl.html: Added.
  • fast/regions/selection/position-for-point.html: Added.
10:19 AM Changeset in webkit [159056] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.2 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
10:14 AM Changeset in webkit [159055] by rgabor@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Fix CPU(ARM_TRADITIONAL) build after r159039.
https://bugs.webkit.org/show_bug.cgi?id=124149

Reviewed by Geoffrey Garen.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::firstRegister):
(JSC::ARMAssembler::lastRegister):
(JSC::ARMAssembler::firstFPRegister):
(JSC::ARMAssembler::lastFPRegister):

  • assembler/MacroAssemblerARM.h:
  • jit/FPRInfo.h:
10:00 AM Changeset in webkit [159054] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit

[Mac] .exp files are not source code
https://bugs.webkit.org/show_bug.cgi?id=124154

Reviewed by Andy Estes.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj: Removed WebKit.iOS.exp from the Compile Sources build

phase.

../WebKit/mac:

  • Configurations/WebKit.xcconfig: Removed WebKit.iOS.exp from

EXCLUDED_SOURCE_FILE_NAMES_macosx.

9:37 AM Changeset in webkit [159053] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[curl] Remove unused includes.
https://bugs.webkit.org/show_bug.cgi?id=120415

Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.

Original patch by 2013-08-28 Tamas Czene <tczene@inf.u-szeged.hu>

  • platform/network/curl/ProxyServerCurl.cpp:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/curl/ResourceHandleManager.cpp:
9:37 AM Changeset in webkit [159052] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

The feeder queue will not feed patches older than one week.
https://bugs.webkit.org/show_bug.cgi?id=107152

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.

The feeder queue will not feed patches older than one week.
Unit test added to this scenario.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries._parse_attachment_ids_request_query):

Handle date parameter.

(BugzillaQueries):
(BugzillaQueries._fetch_attachment_ids_request_query):

Propagate date.

(BugzillaQueries.fetch_attachment_ids_from_review_queue):

Propagate date.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzillaQueries.fetch_attachment_ids_from_review_queue):

Handle date.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(test_request_page_parsing):

Unit test added.

  • Scripts/webkitpy/tool/bot/feeders.py:

(EWSFeeder.feed):

Query patch ids with date parameter (now - 1 week).

9:33 AM Changeset in webkit [159051] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Do not shut down ImageDiff server after every diff during the tests.
https://bugs.webkit.org/show_bug.cgi?id=124140

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.

There was a FIXME: There is no need to shut down the ImageDiff
server after every diff. Shutdown is removed from that point.

  • Scripts/webkitpy/port/image_diff.py:

(ImageDiffer._read):

9:28 AM Changeset in webkit [159050] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

URTBF after r159027 to make Apple Windows build happy.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::sharedBufferGetBytesAtPosition):

2:38 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
2:33 AM Changeset in webkit [159049] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Kill InlineFlowBox::rendererLineBoxes().
<https://webkit.org/b/124141>

We only ever used this to access the RenderLineBoxList for non-root
boxes, and those always have a RenderInline renderer.

Tighten things up by losing the virtual rendererLineBoxes() and
calling RenderInline::lineBoxes() directly.

Reviewed by Antti Koivisto.

2:13 AM Changeset in webkit [159048] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r159042 - [GTK] Crash when printing via javascript in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124043

Reviewed by Martin Robinson.

It happens because the print operation when started by the
WebProcess due to a DOM operation is supposed to be synchronous
and our print operation is always asynchronous. This is currently
handled only in the UI process because other ports print
synchronously in the WebProcess. In the GTK+ port we need to
notify the WebProcess that the print operation should run
synchronously when request by a DOM operation. Together with the
print settings and page setup we now send a print mode that can be
sync or async. When printing in sync mode we run a nested main loop
for the print operation, making sure that print sources have a
higher priority.

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode): Encode the print mode.
(WebKit::PrintInfo::decode): Decode the print mode.

  • Shared/PrintInfo.h: Add PrintMode enum.
  • Shared/gtk/PrintInfoGtk.cpp:

(WebKit::PrintInfo::PrintInfo): Initialize print mode.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted): Do not call endPrinting() when
printing synchronously because WebPageProxy already calls it right
after sending the message to the WebProcess.
(webkitPrintOperationPrintPagesForFrame): Create the PrintInfo
struct with a print mode.
(webkitPrintOperationSetPrintMode): Helper private function to set
the print mode of the print operation.

  • UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPrintFrame): Set sync print mode when printing due
to a UIClient request.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Create a main loop when
printing synchronously.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
print mode.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Finish the
nested main loop when printing synchronously.
(WebKit::WebPrintOperationGtk::print): Run a nested main loop when
printing synchronously.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

(WebKit::WebPrintOperationGtk::printMode): Return the print mode.

2:11 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
2:10 AM Changeset in webkit [159047] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r159041 - [GTK] [WebKit2] Crash when printing to a file via javascript
https://bugs.webkit.org/show_bug.cgi?id=122801

Reviewed by Martin Robinson.

This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):

2:07 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
2:07 AM Changeset in webkit [159046] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r156892 - [GTK] Enable text edition UndoOperations support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=122305

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.

  • GNUmakefile.list.am:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):

  • UIProcess/API/gtk/PageClientImpl.h:
2:05 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:52 AM Changeset in webkit [159045] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WTF

Merge r158445 - HPPA build fixes
https://bugs.webkit.org/show_bug.cgi?id=123625

Original patch from John David Anglin <dave.anglin@bell.net>

Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.

  • wtf/Platform.h:
  • wtf/dtoa/utils.h:
1:50 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:38 AM Changeset in webkit [159044] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Bring the LineFragmentationData back to RootInlineBox.
<https://webkit.org/b/124136>

Now that we have the simple line layout path, almost all the root
line boxes end up with some kind of fragmentation data, so we might
as well put the members back on RootInlineBox and avoid the extra
allocation (and indirection.)

1.74 MB progression on HTML5 spec at <http://whatwg.org/c>

Reviewed by Antti Koivisto.

1:22 AM Changeset in webkit [159043] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r158444 - Fix build on non-linux platforms
https://bugs.webkit.org/show_bug.cgi?id=123622

Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
1:20 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:30 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:30 AM Changeset in webkit [159042] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

[GTK] Crash when printing via javascript in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124043

Reviewed by Martin Robinson.

It happens because the print operation when started by the
WebProcess due to a DOM operation is supposed to be synchronous
and our print operation is always asynchronous. This is currently
handled only in the UI process because other ports print
synchronously in the WebProcess. In the GTK+ port we need to
notify the WebProcess that the print operation should run
synchronously when request by a DOM operation. Together with the
print settings and page setup we now send a print mode that can be
sync or async. When printing in sync mode we run a nested main loop
for the print operation, making sure that print sources have a
higher priority.

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode): Encode the print mode.
(WebKit::PrintInfo::decode): Decode the print mode.

  • Shared/PrintInfo.h: Add PrintMode enum.
  • Shared/gtk/PrintInfoGtk.cpp:

(WebKit::PrintInfo::PrintInfo): Initialize print mode.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted): Do not call endPrinting() when
printing synchronously because WebPageProxy already calls it right
after sending the message to the WebProcess.
(webkitPrintOperationPrintPagesForFrame): Create the PrintInfo
struct with a print mode.
(webkitPrintOperationSetPrintMode): Helper private function to set
the print mode of the print operation.

  • UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPrintFrame): Set sync print mode when printing due
to a UIClient request.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Create a main loop when
printing synchronously.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
print mode.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Finish the
nested main loop when printing synchronously.
(WebKit::WebPrintOperationGtk::print): Run a nested main loop when
printing synchronously.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

(WebKit::WebPrintOperationGtk::printMode): Return the print mode.

12:24 AM Changeset in webkit [159041] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Crash when printing to a file via javascript
https://bugs.webkit.org/show_bug.cgi?id=122801

Reviewed by Martin Robinson.

This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):

Nov 10, 2013:

11:43 PM Changeset in webkit [159040] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[EFL] Layout tests with css1 box properties need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124135

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-10
Reviewed by Gyuyoung Kim.

EFL css1 rebaseline after r101343 for EFL gardening.

  • platform/efl/css1/box_properties/margin_right-expected.txt:
  • platform/efl/css1/box_properties/padding-expected.txt:
  • platform/efl/css1/box_properties/padding_left-expected.txt:
  • platform/efl/css1/box_properties/padding_right-expected.txt:
  • platform/efl/css1/box_properties/padding_top-expected.txt:
11:30 PM Changeset in webkit [159039] by fpizlo@apple.com
  • 26 edits in trunk/Source

Switch FTL GetById/PutById IC's over to using AnyRegCC
https://bugs.webkit.org/show_bug.cgi?id=124094

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This closes the loop on inline caches (IC's) in the FTL. The goal is to have IC's
in LLVM-generated code that are just as efficient (if not more so) than what a
custom JIT could do. As in zero sources of overhead. Not a single extra instruction
or even register allocation pathology. We accomplish this by having two thingies in
LLVM. First is the llvm.experimental.patchpoint intrinsic, which is sort of an
inline machine code snippet that we can fill in with whatever we want and then
modify subsequently. But you have only two choices of how to pass values to a
patchpoint: (1) via the calling convention or (2) via the stackmap. Neither are good
for operands to an IC (like the base pointer for a GetById, for example). (1) is bad
because it results in things being pinned to certain registers a priori; a custom
JIT (like the DFG) will not pin IC operands to any registers a priori but will allow
the register allocator to do whatever it wants. (2) is bad because the operands may
be spilled or may be represented in other crazy ways. You generally want an IC to
have its operands in registers. Also, patchpoints only return values using the
calling convention, which is unfortunate since it pins the return value to a
register a priori. This is where the second thingy comes in: the AnyRegCC. This is
a special calling convention only for use with patchpoints. It means that arguments
passed "by CC" in the patchpoint can be placed in any register, and the register
that gets used is reported as part of the stackmap. It also means that the return
value (if there is one) can be placed in any register, and the stackmap will tell
you which one it was. Thus, patchpoints combined with AnyRegCC mean that you not
only get the kind of self-modifying code that you want for IC's, but you also get
all of the register allocation goodness that a custom JIT would have given you.
Except that you're getting it from LLVM and not a custom JIT. Awesome.

Even though all of the fun stuff is on the LLVM side, this patch was harder than
you'd expect.

First the obvious bits:

  • IC patchpoints now use AnyRegCC instead of the C CC. (CC = calling convention.)


  • FTL::fixFunctionBasedOnStackMaps() now correctly figures out which registers the IC is supposed to use instead of assuming C CC argument registers.


And then all of the stuff that broke and that this patch fixes:

  • IC sizing based on generating a dummy IC (what FTLInlineCacheSize did) is totally bad on x86-64, where various register permutations lead to bizarre header bytes and eclectic SIB encodings. I changed that to have magic constants, for now.


  • Slow path calls didn't preserve the CC return register.


  • Repatch's scratch register allocation would get totally confused if the operand registers weren't one of the DFG-style "temp" registers. And by "totally confused" I mean that it would crash.


  • We assumed that r10 is callee-saved. It's not. That one dude's PPT about x86-64 cdecl that I found on the intertubes was not a trustworthy source of information, apparently.


  • Call repatching didn't know that the FTL does its IC slow calls via specially generated thunks. This was particularly fun to fix: basically, now when we relink an IC call in the FTL, we use the old call target to find the SlowPathCallKey, which tells us everything we need to know to generate (or look up) a new thunk for the new function we want to call.


  • assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::isEmptyValue):
(JSC::MacroAssemblerCodePtr::isDeletedValue):
(JSC::MacroAssemblerCodePtr::hash):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::MacroAssemblerCodePtrHash::hash):
(JSC::MacroAssemblerCodePtrHash::equal):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::codeBlock):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::setInstructionCallingConvention):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::forStackmaps):

  • ftl/FTLLocation.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compilePutById):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLSlowPathCall.cpp:
  • ftl/FTLSlowPathCallKey.h:

(JSC::FTL::SlowPathCallKey::withCallTarget):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::directGPR):
(JSC::FTL::StackMaps::Location::restoreInto):

  • ftl/FTLStackMaps.h:
  • ftl/FTLThunks.h:

(JSC::FTL::generateIfNecessary):
(JSC::FTL::keyForThunk):
(JSC::FTL::Thunks::keyForSlowPathCallThunk):

  • jit/FPRInfo.h:

(JSC::FPRInfo::toIndex):

  • jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::calleeSaveRegisters):

  • jit/RegisterSet.h:

(JSC::RegisterSet::filter):

  • jit/Repatch.cpp:

(JSC::readCallTarget):
(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::resetGetByID):
(JSC::resetPutByID):

  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::lock):

Source/WTF:

Reviewed by Sam Weinig.

I needed to add another set operation, namely filter(), which is an in-place set
intersection.

  • wtf/BitVector.cpp:

(WTF::BitVector::filterSlow):

  • wtf/BitVector.h:

(WTF::BitVector::filter):

10:20 PM Changeset in webkit [159038] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Shrink RenderInline.
<https://webkit.org/b/124134>

Move the "always create line boxes" bit from RenderInline up to
RenderElement. I didn't do this earlier because there were no bits
free on RenderObject but thanks to RenderElement we now have tons!

540 kB progression on HTML5 spec at <http://whatwg.org/c>

Reviewed by Anders Carlsson.

8:58 PM Changeset in webkit [159037] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WTF

[EFL] Build break on Ubuntu 13.10
https://bugs.webkit.org/show_bug.cgi?id=124131

Reviewed by Gyuyoung Kim.

Turned DisallowCType macros off on EFL port because gtest-internal.h uses isspace().

  • wtf/DisallowCType.h: Added !PLATFORM(EFL) guard.
8:02 PM Changeset in webkit [159036] by weinig@apple.com
  • 53 edits in trunk/Source/WebCore

Make childShouldCreateRenderer() take a Node reference
https://bugs.webkit.org/show_bug.cgi?id=124132

Reviewed by Andreas Kling.

The Node passed to childShouldCreateRenderer() is never null.

5:58 PM Changeset in webkit [159035] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSS direction must be reset to ltr on <math> element.
<https://webkit.org/b/124121>

Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-10
Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/direction.html

  • css/mathml.css:

(math): set direction: ltr; on the <math> element.

LayoutTests:

  • mathml/presentation/direction-expected.html: Added.
  • mathml/presentation/direction.html: Added.
4:22 PM Changeset in webkit [159034] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=124124

Reviewed by Anders Carlsson.

Reduce RenderBlockFlow by one word.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:
  • rendering/RenderBlockFlow.h:
4:13 PM Changeset in webkit [159033] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

Cleanup the EFL --minimal build from unused parameters
https://bugs.webkit.org/show_bug.cgi?id=124048

Patch by Tibor Meszaros <mtibor@inf.u-szeged.hu> on 2013-11-10
Reviewed by Gyuyoung Kim.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::createWindow):

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set):

  • ewk/ewk_view.cpp:

(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):

3:32 PM Changeset in webkit [159032] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Use start/end instead of textOffset/textLength for simple text runs
https://bugs.webkit.org/show_bug.cgi?id=124130

Reviewed by Oliver Hunt.

The code reads better this way.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayout.h:

(WebCore::SimpleLineLayout::Run::Run):

  • rendering/SimpleLineLayoutFunctions.h:

(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

2:28 PM Changeset in webkit [159031] by oliver@apple.com
  • 11 edits
    3 moves
    6 adds in trunk

Implement Set iterators
https://bugs.webkit.org/show_bug.cgi?id=124129

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

Add Set iterator classes and implementations

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSSetIterator.cpp: Added.

(JSC::JSSetIterator::finishCreation):
(JSC::JSSetIterator::visitChildren):
(JSC::JSSetIterator::createPair):

  • runtime/JSSetIterator.h: Added.

(JSC::JSSetIterator::createStructure):
(JSC::JSSetIterator::create):
(JSC::JSSetIterator::next):
(JSC::JSSetIterator::JSSetIterator):

  • runtime/SetIteratorConstructor.cpp: Added.

(JSC::SetIteratorConstructor::finishCreation):

  • runtime/SetIteratorConstructor.h: Added.

(JSC::SetIteratorConstructor::create):
(JSC::SetIteratorConstructor::createStructure):
(JSC::SetIteratorConstructor::SetIteratorConstructor):

  • runtime/SetIteratorPrototype.cpp: Added.

(JSC::SetIteratorPrototype::finishCreation):
(JSC::SetIteratorPrototypeFuncIterator):
(JSC::SetIteratorPrototypeFuncNext):

  • runtime/SetIteratorPrototype.h: Added.

(JSC::SetIteratorPrototype::create):
(JSC::SetIteratorPrototype::createStructure):
(JSC::SetIteratorPrototype::SetIteratorPrototype):

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::setProtoFuncKeys):

LayoutTests:

Move Set tests to more sensible location and add iterator tests

  • js/basic-set-expected.txt: Renamed from LayoutTests/js/dom/basic-set-expected.txt.
  • js/basic-set.html: Renamed from LayoutTests/js/dom/basic-set.html.
  • js/script-tests/basic-set.js: Renamed from LayoutTests/js/dom/script-tests/basic-set.js.

(set new):
(otherString.string_appeared_here.set add):
(try.set forEach):
(set forEach):
(set gc):

2:17 PM Changeset in webkit [159030] by Antti Koivisto
  • 9 edits
    10 adds in trunk

Implement white-space property on simple line layout path
https://bugs.webkit.org/show_bug.cgi?id=124122

Source/WebCore:

Reviewed by Andreas Kling.

Support all values of the white-space property and the tab-size property.

Tests: fast/forms/basic-textareas-simple-lines.html

fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html
fast/text/whitespace/pre-wrap-line-test-simple-lines.html
fast/text/whitespace/pre-wrap-long-word-simple-lines.html
fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::isWhitespace):
(WebCore::SimpleLineLayout::skipWhitespaces):
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::measureWord):
(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintDebugBorders):
(WebCore::SimpleLineLayout::paintFlow):

LayoutTests:

Reviewed by Andreas Kling.

The simple line layout produces slightly different runs in some pre-wrap cases compared
to the line box path (with less unnecessary boxes). To keep the test coverage this patch forces the
existing render tree dump based tests to use line boxes. It also adds new ref tests for
the same cases where the test uses the simple line path and the ref is forced on the line box path.
This ensures that the paths produce pixel-identical results.

  • fast/forms/basic-textareas-simple-lines-expected.html: Added.
  • fast/forms/basic-textareas-simple-lines.html: Added.
  • fast/forms/basic-textareas.html:
  • fast/text/embed-at-end-of-pre-wrap-line-simple-lines-expected.html: Added.
  • fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html: Added.
  • fast/text/embed-at-end-of-pre-wrap-line.html:
  • fast/text/whitespace/pre-wrap-line-test-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-line-test-simple-lines.html: Added.
  • fast/text/whitespace/pre-wrap-line-test.html:
  • fast/text/whitespace/pre-wrap-long-word-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-long-word-simple-lines.html: Added. New simple test for overflowing lines which was only covered by the very large basic-textareas.html.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline.html:
12:59 PM Changeset in webkit [159029] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix EFL build after r159027
https://bugs.webkit.org/show_bug.cgi?id=124127

Patch by Sergio Correia <Sergio Correia> on 2013-11-10
Reviewed by Anders Carlsson.

No new tests, build fix.

  • page/Settings.in: Add std to numeric_limits, since we don't have

'using std' directives anymore.

11:50 AM Changeset in webkit [159028] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):

11:32 AM Changeset in webkit [159027] by andersca@apple.com
  • 151 edits in trunk/Source/WebCore

Remove all 'std' using directives from WebCore
https://bugs.webkit.org/show_bug.cgi?id=124125

Reviewed by Sam Weinig.

As per the coding style guidelines.

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/WorkerThreadableLoader.cpp:
  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::loadCache):

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::deadCapacity):
(WebCore::MemoryCache::lruListFor):

  • page/CaptionUserPreferencesMediaAF.cpp:
  • page/Chrome.cpp:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::intervalClampedToMinimum):

  • page/FocusController.cpp:
  • page/Frame.cpp:

(WebCore::Frame::resizePageRectsKeepingRatio):

  • page/PageGroupLoadDeferrer.cpp:
  • page/Settings.cpp:
  • page/animation/AnimationBase.cpp:

(WebCore::solveStepsFunction):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::getTimeToNextEvent):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):

  • platform/DateComponents.cpp:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollContents):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::moveThumb):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::getSomeData):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer):

  • platform/Timer.cpp:

(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::TimerBase::heapPop):
(WebCore::TimerBase::nextUnalignedFireInterval):

  • platform/URL.cpp:

(WebCore::findHostnamesInMailToURL):
(WebCore::portAllowed):

  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::setRate):

  • platform/audio/AudioResamplerKernel.cpp:

(WebCore::AudioResamplerKernel::process):

  • platform/audio/Distance.cpp:

(WebCore::DistanceEffect::gain):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan):

  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::indexFromElevationAngle):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::createForSubject):

  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createInterpolatedKernel):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):

  • platform/audio/Reverb.cpp:
  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::process):

  • platform/cf/URLCF.cpp:
  • platform/graphics/Color.cpp:

(WebCore::makeRGB):
(WebCore::makeRGBA):
(WebCore::colorFloatToRGBAByte):
(WebCore::Color::light):
(WebCore::Color::dark):

  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/FloatQuad.cpp:

(WebCore::min4):
(WebCore::max4):
(WebCore::withinEpsilon):

  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::isZero):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::floatWidthForSimpleText):

  • platform/graphics/FontPlatformData.cpp:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::Radii::expand):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::calculateLobes):
(WebCore::computeSliceSizesFromRadii):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::initCharWidths):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCue):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setOpacity):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
(WebCore::GraphicsLayerCA::setupAnimation):
(WebCore::clampedContentsScaleForScale):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::getTileIndexRangeForRect):
(WebCore::TileController::computeTileCoverageRect):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::computeLineBoundsAndAntialiasingModeForText):

  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):

  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::updateSubRect):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::advance):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText):

  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::duration):

  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:
  • platform/graphics/transforms/MatrixTransformOperation.cpp:
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/TransformOperations.cpp:

(WebCore::TransformOperations::blendByMatchingOperations):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetContentsSize):
(WebCore::ScrollView::platformSetScrollPosition):

  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/ThemeMac.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController incrementVolume]):
(timeToString):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):

  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::textClone):
(WebCore::textLatin1MoveInPrimaryContext):
(WebCore::textLatin1MoveInPriorContext):
(WebCore::textInChunkOrOutOfRange):
(WebCore::textOpenLatin1):
(WebCore::textUTF16MoveInPrimaryContext):
(WebCore::textUTF16MoveInPriorContext):
(WebCore::textOpenUTF16):

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::encode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::encode):

  • platform/text/TextStream.cpp:
  • platform/text/mac/LocaleMac.mm:
  • platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):

  • rendering/FloatingObjects.cpp:

(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/InlineBox.cpp:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeMaxLogicalTop):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
(WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::computeUnderlineOffset):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):
(WebCore::updatePreferredWidth):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::estimateLogicalTopPosition):
(WebCore::RenderBlockFlow::setCollapsedBottomMargin):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
(WebCore::RenderBlockFlow::updateLogicalHeight):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::relayoutForPagination):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::updateLogicalWidthForLeftAlignedBlock):
(WebCore::updateLogicalWidthForRightAlignedBlock):
(WebCore::updateLogicalWidthForCenterAlignedBlock):
(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::tryHyphenating):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::adjustBorderBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::applyVisualEffectOverflow):
(WebCore::RenderBox::addLayoutOverflow):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::setImageSizeForAltText):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::visibleContentRect):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerModelObject.cpp:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::computePreferredLogicalWidths):
(WebCore::RenderListBox::size):
(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollHeight):

  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):
(WebCore::RenderMarquee::computePosition):
(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMediaControls.cpp:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::computeIntrinsicLogicalWidths):
(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderMeter.cpp:
  • rendering/RenderMultiColumnBlock.cpp:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):

  • rendering/RenderNamedFlowFragment.cpp:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::caretMaxOffset):

  • rendering/RenderProgress.cpp:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderRubyBase.cpp:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang):

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::computeControlLogicalHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::logicalWidthFromColumns):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
(WebCore::RenderTableCell::layout):
(WebCore::RenderTableCell::setOverrideLogicalContentHeightFromRowHeight):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect):
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::firstLineBaseline):
(WebCore::RenderTableSection::removeCachedCollapsedBorders):
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButton):

  • rendering/RenderWidget.cpp:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::blockDirectionPointInLine):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::setFontSize):
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/SVGRenderStyle.cpp:
  • rendering/style/ShadowData.cpp:

(WebCore::calculateShadowExtent):

  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGRoot.cpp:
  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::localSelectionRect):

  • svg/SVGAnimatedNumber.cpp:
  • svg/SVGAnimatedNumberOptionalNumber.cpp:
  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::startTimer):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::simpleDuration):
(WebCore::SVGSMILElement::repeatingDuration):
(WebCore::SVGSMILElement::resolveActiveEnd):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::resolveFirstInterval):
(WebCore::SVGSMILElement::resolveNextInterval):
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

  • xml/XMLTreeViewer.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::OffsetBuffer::readOutBytes):

8:59 AM Changeset in webkit [159026] by gyuyoung.kim@samsung.com
  • 23 edits in trunk/Source

[AX] Clean up static_cast<> to cast from AccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=124032

Reviewed by Mario Sanchez Prada.

Source/WebCore:

ACCESSIBILITY_OBJECT_TYPE_CASTS can support more helpful casting functions.
So, we need to use them as much as possible. This patch cleans up all static_cast<> in accessibility.

This patch generates toAccessibilityFoo() in order to replace static_cast<> with it. Below toAccessibilityFoo()
are generated.

  • toAccessibilityARIAGridRow()
  • toAccessibilityImageMapLink()
  • toAccessibilityListBox()
  • toAccessibilityListBoxOption()
  • toAccessibilityMenuListOption()
  • toAccessibilityMenuListPopup()
  • toAccessibilityScrollbar()
  • toAccessibilitySlider()

No new tests, no behavior changes.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):

  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
(WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::addChildren):
(WebCore::AccessibilityMenuList::didUpdateActiveOption):

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListBoxOption):
(WebCore::AccessibilityObject::isSliderThumb):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::addChildScrollbar):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::addChildren):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButton::addChildren):

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(webkitAccessibleSelectionClearSelection):
(webkitAccessibleSelectionSelectAllSelection):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::didUpdateActiveOption):

Source/WebKit/win:

Use toAccessibilityListBox instead of using static_cast<AccessibilityListBox*>.

  • AccessibleBase.cpp:

(AccessibleBase::accSelect):

8:34 AM Changeset in webkit [159025] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Rebaseline bindings tests after r158997.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
6:52 AM Changeset in webkit [159024] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

[GStreamer] Consolidate more code into TrackPrivateBaseGStreamer
https://bugs.webkit.org/show_bug.cgi?id=124020

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-10
Reviewed by Philippe Normand.

No new tests because this is just refactoring.

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer): Don't pass playbin to TrackPrivateBaseGStreamer, and do pass a pointer to "this".
(WebCore::AudioTrackPrivateGStreamer::disconnect): Clear m_playbin().

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Move labelChanged() and languageChanged() to TrackPrivateBaseGStreamer. Move m_playbin to this class (along with disconnect() to clear it).
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp: Move tag handling, pad and index to TrackPrivateBaseGStreamer.

(WebCore::textTrackPrivateEventCallback):
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
(WebCore::InbandTextTrackPrivateGStreamer::disconnect):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp: Add WebKitTextCombinerPad with "tags" property, set in the same was as input-selector's pads.

(webkit_text_combiner_pad_init): Initialize tags to 0.
(webkitTextCombinerPadFinalize): Clear tags.
(webkitTextCombinerPadGetProperty): Handling "tags" property.
(webkitTextCombinerPadEvent): Changed to be a pad event function instead of a pad probe, and now intercepts tags and merges them (like input-selector pads do).
(webkitTextCombinerRequestNewPad): Using WebKitTextCombinerPad instead of just GhostPad.
(webkit_text_combiner_pad_class_init): Setup WebKitTextCombinerPad.

  • platform/graphics/gstreamer/TextCombinerGStreamer.h: Remove superfluous code.
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer): Use "notify::active" so we don't need a playbin, and immediately check for tags after the constructor.
(WebCore::TrackPrivateBaseGStreamer::disconnect): Remove m_playbin.
(WebCore::TrackPrivateBaseGStreamer::getTag): Refactored out from notifyTrackOfTagsChanged.
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged): Simplify using m_owner (so we can call labelChanged() and languageChanged() directly), and use getTag() above.

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Add m_owner to we can access the owning track, and change some functions to match our needs better.

(WebCore::TrackPrivateBaseGStreamer::setActive): Add empty default since InbandTextTrackPrivateGStreamer doesn't need this.

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: Same as AudioTrackPrivateGStreamer.

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::disconnect):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same as AudioTrackPrivateGStreamer.
2:59 AM Changeset in webkit [159023] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

Generate type casting helpers for Widget classes.
<https://webkit.org/b/124120>

Add a WIDGET_TYPE_CASTS macro and replace all the hand-written
toFoo() helpers we had for Widget subclasses. Fixed up a handful
of places that were still using static_cast.

Reviewed by Antti Koivisto.

2:58 AM Changeset in webkit [159022] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused FragmentationDisabler class.
<https://webkit.org/b/124118>

This RAII object was added in r144744 to avoid a crash when using
MathML inside CSS regions. Its only user was removed in r157070.

Reviewed by Antti Koivisto.

2:56 AM Changeset in webkit [159021] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Simplify some is-this-a-MathML-element? checks.
<https://webkit.org/b/124119>

As of r158198, the MathML-ness of an Element is determined by
a Node flag, so there's no need to cast to Element before checking
on this. Simplify accordingly.

Reviewed by Antti Koivisto.

12:57 AM Changeset in webkit [159020] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove RenderTheme::shouldOpenPickerWithF4Key().

Rubber-stamped by Anders Carlsson.

12:39 AM Changeset in webkit [159019] by akling@apple.com
  • 2 edits
    2 copies
    128 moves
    2 adds
    134 deletes in trunk/LayoutTests

Optimize baselines: svg/*

Unreviewed; run "webkit-patch optimize-baselines svg"

  • platform/efl-wk2/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
  • platform/efl/svg/wicd/sizing-flakiness-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-image-expected.png: Removed.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Removed.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
  • platform/gtk/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.png: Removed.
  • platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.png: Removed.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Removed.
  • platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Removed.
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.png: Removed.
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt: Removed.
  • platform/gtk/svg/in-html/by-reference-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Removed.
  • platform/gtk/svg/repaint/filter-repaint-expected.txt: Removed.
  • platform/gtk/svg/repaint/image-href-change-expected.png: Removed.
  • platform/gtk/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Removed.
  • platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.
  • platform/gtk/svg/repaint/text-mask-update-expected.png: Removed.
  • platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Removed.
  • platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Removed.
  • platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-text-query-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-tspans-expected.txt: Removed.
  • platform/gtk/svg/text/ems-display-none-expected.txt: Removed.
  • platform/gtk/svg/text/exs-display-none-expected.txt: Removed.
  • platform/gtk/svg/text/font-size-below-point-five-expected.txt: Removed.
  • platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Removed.
  • platform/gtk/svg/text/scaled-font-expected.txt: Removed.
  • platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Removed.
  • platform/gtk/svg/text/selection-doubleclick-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-2-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-3-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-02-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-03-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-04-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-05-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-06-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-altglyph-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-deco-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-fill-opacity-expected.txt: Removed.
  • platform/gtk/svg/text/text-fonts-01-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-fonts-02-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-gradient-positioning-expected.txt: Removed.
  • platform/gtk/svg/text/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Removed.
  • platform/gtk/svg/text/text-path-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-path-middle-align-expected.txt: Removed.
  • platform/gtk/svg/text/text-spacing-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-03-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-05-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-06-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-07-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-08-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tref-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tselect-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt: Removed.
  • platform/gtk/svg/text/text-tspan-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-ws-01-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-ws-02-t-expected.txt: Removed.
  • platform/gtk/svg/text/tspan-dynamic-positioning-expected.txt: Removed.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
  • platform/gtk/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Removed.
  • platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Removed.
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/mac/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
  • platform/mac/svg/custom/stroked-pattern-expected.txt: Removed.
  • platform/mac/svg/text/selection-tripleclick-expected.txt: Removed.
  • platform/win-future/svg/wicd/sizing-flakiness-expected.txt: Copied from LayoutTests/svg/wicd/sizing-flakiness-expected.txt.
  • platform/win/svg/custom/pattern-scaling-expected.txt: Removed.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt.
  • svg/as-image/svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/as-image/svg-as-image-expected.png.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
  • svg/custom/feDisplacementMap-01-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/feDisplacementMap-01-expected.txt.
  • svg/custom/pattern-skew-transformed-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/pattern-skew-transformed-expected.png.
  • svg/custom/radialGradient-focal-radius-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/radialGradient-focal-radius-expected.txt.
  • svg/custom/simple-text-double-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.png.
  • svg/custom/simple-text-double-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.txt.
  • svg/custom/stroked-pattern-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/stroked-pattern-expected.txt.
  • svg/dom/SVGPathSegList-segment-modification-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt.
  • svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt.
  • svg/dom/SVGRectElement/rect-modify-rx-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGRectElement/rect-modify-rx-expected.png.
  • svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png.
  • svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png.
  • svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png.
  • svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png.
  • svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • svg/foreignObject/fO-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-expected.png.
  • svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/fO-parent-display-changes-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.png.
  • svg/foreignObject/fO-parent-display-changes-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.txt.
  • svg/foreignObject/fO-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-expected.png.
  • svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.png.
  • svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png.
  • svg/foreignObject/svg-document-as-direct-child-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.png.
  • svg/foreignObject/svg-document-as-direct-child-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt.
  • svg/in-html/by-reference-expected.txt: Renamed from LayoutTests/platform/efl/svg/in-html/by-reference-expected.txt.
  • svg/overflow/overflow-on-foreignObject-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-foreignObject-expected.png.
  • svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png.
  • svg/repaint/filter-repaint-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/filter-repaint-expected.txt.
  • svg/repaint/image-href-change-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/image-href-change-expected.png.
  • svg/repaint/inner-svg-change-viewBox-contract-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png.
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt.
  • svg/repaint/text-mask-update-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/text-mask-update-expected.png.
  • svg/stroke/zero-length-path-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt.
  • svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt.
  • svg/text/append-text-node-to-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/append-text-node-to-tspan-expected.txt.
  • svg/text/bidi-embedded-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-embedded-direction-expected.txt.
  • svg/text/bidi-reorder-value-lists-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-reorder-value-lists-expected.txt.
  • svg/text/bidi-text-anchor-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-anchor-direction-expected.txt.
  • svg/text/bidi-text-query-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-query-expected.txt.
  • svg/text/bidi-tspans-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-tspans-expected.txt.
  • svg/text/ems-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/ems-display-none-expected.txt.
  • svg/text/exs-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/exs-display-none-expected.txt.
  • svg/text/font-size-below-point-five-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/font-size-below-point-five-expected.txt.
  • svg/text/modify-text-node-in-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/modify-text-node-in-tspan-expected.txt.
  • svg/text/remove-text-node-from-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-text-node-from-tspan-expected.txt.
  • svg/text/remove-tspan-from-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-tspan-from-text-expected.txt.
  • svg/text/scaled-font-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaled-font-expected.txt.
  • svg/text/scaling-font-with-geometric-precision-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-1-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-2-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-3-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-4-expected.txt.
  • svg/text/select-textLength-spacing-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-1-expected.txt.
  • svg/text/select-textLength-spacing-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-2-expected.txt.
  • svg/text/select-textLength-spacing-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-3-expected.txt.
  • svg/text/select-textLength-spacing-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-4-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt.
  • svg/text/select-x-list-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-1-expected.txt.
  • svg/text/select-x-list-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-2-expected.txt.
  • svg/text/select-x-list-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-3-expected.txt.
  • svg/text/select-x-list-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-4-expected.txt.
  • svg/text/select-x-list-with-tspans-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-1-expected.txt.
  • svg/text/select-x-list-with-tspans-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-2-expected.txt.
  • svg/text/select-x-list-with-tspans-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-3-expected.txt.
  • svg/text/select-x-list-with-tspans-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-4-expected.txt.
  • svg/text/selection-doubleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-doubleclick-expected.txt.
  • svg/text/selection-tripleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-tripleclick-expected.txt.
  • svg/text/small-fonts-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-2-expected.txt.
  • svg/text/small-fonts-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-3-expected.txt.
  • svg/text/small-fonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-expected.txt.
  • svg/text/text-align-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-01-b-expected.txt.
  • svg/text/text-align-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-02-b-expected.txt.
  • svg/text/text-align-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-03-b-expected.txt.
  • svg/text/text-align-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-04-b-expected.txt.
  • svg/text/text-align-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-05-b-expected.txt.
  • svg/text/text-align-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-06-b-expected.txt.
  • svg/text/text-altglyph-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-altglyph-01-b-expected.txt.
  • svg/text/text-deco-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-deco-01-b-expected.txt.
  • svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fill-opacity-expected.txt.
  • svg/text/text-fonts-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-01-t-expected.txt.
  • svg/text/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-02-t-expected.txt.
  • svg/text/text-gradient-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-gradient-positioning-expected.txt.
  • svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-intro-05-t-expected.txt.
  • svg/text/text-midpoint-split-bug-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-midpoint-split-bug-expected.txt.
  • svg/text/text-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-01-b-expected.txt.
  • svg/text/text-path-middle-align-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-middle-align-expected.txt.
  • svg/text/text-spacing-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-spacing-01-b-expected.txt.
  • svg/text/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-01-b-expected.txt.
  • svg/text/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-03-b-expected.txt.
  • svg/text/text-text-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-04-t-expected.txt.
  • svg/text/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-05-t-expected.txt.
  • svg/text/text-text-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-06-t-expected.txt.
  • svg/text/text-text-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-07-t-expected.txt.
  • svg/text/text-text-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-08-b-expected.txt.
  • svg/text/text-tref-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tref-01-b-expected.txt.
  • svg/text/text-tselect-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-01-b-expected.txt.
  • svg/text/text-tselect-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-02-f-expected.txt.
  • svg/text/text-tspan-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tspan-01-b-expected.txt.
  • svg/text/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-01-t-expected.txt.
  • svg/text/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-02-t-expected.txt.
  • svg/text/tspan-dynamic-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/tspan-dynamic-positioning-expected.txt.
  • svg/transforms/text-with-mask-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt.
  • svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
  • svg/wicd/sizing-flakiness-expected.txt:

Nov 9, 2013:

11:28 PM Changeset in webkit [159018] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSValuePool::createFontFamilyValue() should return PassRef.
<https://webkit.org/b/124114>

Unlike createFontFaceValue(), createFontFamilyValue() can never
fail to return an object and thus should return PassRef.

Reviewed by Anders Carlsson.

11:26 PM Changeset in webkit [159017] by akling@apple.com
  • 371 edits in trunk

RenderIFrame should display its name correctly in DRT output.
<https://webkit.org/b/124117>

Source/WebCore:

Nuke an age-old FIXME about making RenderIFrame show its true name
in DRT output. No more "RenderPartObject {IFRAME}"!

Reviewed by Anders Carlsson.

LayoutTests:

Rebaseline results now that RenderIFrame correctly dumps its name
as "RenderIFrame".

Reviewed by Anders Carlsson.

  • compositing/iframes/composited-iframe-scroll-expected.txt:
  • compositing/iframes/iframe-content-flipping-expected.txt:
  • compositing/iframes/nested-iframe-scrolling-expected.txt:
  • fast/css/replaced-element-implicit-size-expected.txt:
  • fast/css/resize-corner-tracking-expected.txt:
  • fast/dom/attr_dead_doc-expected.txt:
  • fast/frames/content-opacity-1-expected.txt:
  • fast/frames/content-opacity-2-expected.txt:
  • fast/frames/iframe-scaling-with-scroll-expected.txt:
  • fast/frames/iframe-text-contents-expected.txt:
  • fast/frames/paint-iframe-background-expected.txt:
  • fast/repaint/4774354-expected.txt:
  • fast/repaint/iframe-scroll-repaint-expected.txt:
  • fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • fast/replaced/percent-height-in-anonymous-block-expected.txt:
  • http/tests/misc/acid3-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
  • platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/efl/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/efl/editing/pasteboard/4631972-expected.txt:
  • platform/efl/editing/selection/4776665-expected.txt:
  • platform/efl/editing/selection/4960137-expected.txt:
  • platform/efl/editing/selection/4975120-expected.txt:
  • platform/efl/editing/selection/drag-in-iframe-expected.txt:
  • platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/efl/editing/selection/iframe-expected.txt:
  • platform/efl/editing/selection/select-all-iframe-expected.txt:
  • platform/efl/fast/block/basic/013-expected.txt:
  • platform/efl/fast/block/positioning/window-height-change-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/efl/fast/flexbox/016-expected.txt:
  • platform/efl/fast/forms/basic-textareas-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/targeted-frame-submission-expected.txt:
  • platform/efl/fast/frames/001-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/efl/fast/frames/frameElement-iframe-expected.txt:
  • platform/efl/fast/frames/iframe-option-crash-expected.txt:
  • platform/efl/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/efl/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/efl/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/frames/viewsource-attribute-expected.txt:
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/efl/fast/images/favicon-as-image-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/efl/fast/replaced/007-expected.txt:
  • platform/efl/fast/replaced/border-radius-clip-expected.txt:
  • platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
  • platform/efl/fast/text/selection-hard-linebreak-expected.txt:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt:
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/efl/http/tests/misc/acid3-expected.txt:
  • platform/efl/http/tests/misc/favicon-as-image-expected.txt:
  • platform/efl/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/efl/http/tests/misc/iframe404-expected.txt:
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/svg/hixie/rendering-model/003-expected.txt:
  • platform/efl/svg/in-html/by-reference-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/gtk/editing/execCommand/find-after-replace-expected.txt:
  • platform/gtk/editing/execCommand/paste-1-expected.txt:
  • platform/gtk/editing/pasteboard/4631972-expected.txt:
  • platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/paste-2-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/4776665-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/select-all-iframe-expected.txt:
  • platform/gtk/fast/block/basic/013-expected.txt:
  • platform/gtk/fast/block/positioning/window-height-change-expected.txt:
  • platform/gtk/fast/css/line-height-overflow-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/gtk/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/gtk/fast/flexbox/016-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/images/favicon-as-image-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/gtk/fast/replaced/007-expected.txt:
  • platform/gtk/fast/replaced/border-radius-clip-expected.txt:
  • platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
  • platform/gtk/fast/text/selection-hard-linebreak-expected.txt:
  • platform/gtk/http/tests/loading/simple-subframe-expected.txt:
  • platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
  • platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/gtk/http/tests/misc/iframe404-expected.txt:
  • platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/gtk/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/hixie/rendering-model/003-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/iphone-simulator/text-autosizing/contenteditable-expected.txt:
  • platform/mac-mountainlion/editing/selection/4975120-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
  • platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/pasteboard/4631972-expected.txt:
  • platform/mac/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/mac/editing/pasteboard/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/mac/editing/selection/4776665-expected.txt:
  • platform/mac/editing/selection/4960137-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-in-iframe-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/selection/iframe-expected.txt:
  • platform/mac/editing/selection/select-all-iframe-expected.txt:
  • platform/mac/fast/block/basic/013-expected.txt:
  • platform/mac/fast/block/positioning/window-height-change-expected.txt:
  • platform/mac/fast/css/line-height-overflow-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/mac/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/mac/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/mac/fast/flexbox/016-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/mac/fast/frames/001-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/mac/fast/frames/frameElement-iframe-expected.txt:
  • platform/mac/fast/frames/iframe-option-crash-expected.txt:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/mac/fast/images/favicon-as-image-expected.txt:
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/repaint/4774354-expected.txt:
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/mac/fast/replaced/007-expected.txt:
  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
  • platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/table/quote-text-around-iframe-expected.txt:
  • platform/mac/fast/text/selection-hard-linebreak-expected.txt:
  • platform/mac/http/tests/loading/simple-subframe-expected.txt:
  • platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/mac/http/tests/misc/acid3-expected.txt:
  • platform/mac/http/tests/misc/favicon-as-image-expected.txt:
  • platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/mac/http/tests/misc/iframe404-expected.txt:
  • platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/mac/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc.html:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt:
  • platform/mac/svg/hixie/rendering-model/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • platform/win-xp/media/media-document-audio-repaint-expected.txt:
  • platform/win/http/tests/misc/acid3-expected.txt:
  • plugins/iframe-plugin-bgcolor-expected.txt:
  • printing/iframe-print-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • tables/mozilla/bugs/bug137388-1-expected.txt:
  • tables/mozilla/bugs/bug137388-2-expected.txt:
  • tables/mozilla/bugs/bug137388-3-expected.txt:
  • tables/mozilla/bugs/bug50695-2-expected.txt:
10:49 PM Changeset in webkit [159016] by mitz@apple.com
  • 6 edits
    2 adds in trunk/Source/WebKit2

Use createCFURLFromBuffer when converting a String to a CFURL
https://bugs.webkit.org/show_bug.cgi?id=124113

Reviewed by Anders Carlsson.

  • Shared/API/c/cf/WKURLCF.mm:

(WKURLCopyCFURL): Replaced some code with a call to createCFURLFromBuffer(), which does the
same thing.

  • Shared/Cocoa/WKNSURLExtras.h: Added.
  • Shared/Cocoa/WKNSURLExtras.mm: Added.

(+[NSURL _web_URLWithWTFString:relativeToURL:]): Added. Returns nil for the null String,
otherwise returns the result of createCFURLFromBuffer().

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to use +_web_URLWithWTFString:relativeToURL:.
(-[WKBackForwardListItem originalURL]): Ditto.

  • UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]): Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
10:45 PM Changeset in webkit [159015] by akling@apple.com
  • 3 edits
    2 copies
    9 moves
    1 add
    13 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-SVG-1.1-SE

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1-SE"

  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/win-future/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
10:42 PM Changeset in webkit [159014] by akling@apple.com
  • 1 edit
    9 moves
    9 deletes in trunk/LayoutTests

Optimize baselines: svg/carto.net

Unreviewed; run "webkit-patch optimize-baselines svg/carto.net"

  • platform/gtk/svg/carto.net/button-expected.txt: Removed.
  • platform/gtk/svg/carto.net/colourpicker-expected.txt: Removed.
  • platform/gtk/svg/carto.net/combobox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/gtk/svg/carto.net/slider-expected.txt: Removed.
  • platform/gtk/svg/carto.net/tabgroup-expected.txt: Removed.
  • platform/gtk/svg/carto.net/textbox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/window-expected.txt: Removed.
  • svg/carto.net/button-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/button-expected.txt.
  • svg/carto.net/colourpicker-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/colourpicker-expected.txt.
  • svg/carto.net/combobox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/combobox-expected.txt.
  • svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
  • svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
  • svg/carto.net/slider-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/slider-expected.txt.
  • svg/carto.net/tabgroup-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/tabgroup-expected.txt.
  • svg/carto.net/textbox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/textbox-expected.txt.
  • svg/carto.net/window-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/window-expected.txt.
10:39 PM Changeset in webkit [159013] by akling@apple.com
  • 1 edit
    10 moves
    10 deletes in trunk/LayoutTests

Optimize baselines: svg/css

Unreviewed; run "webkit-patch optimize-baselines svg/css"

  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/clippath-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/group-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/path-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Removed.
  • platform/gtk/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/text-gradient-shadow-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png.
  • svg/css/clippath-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/clippath-with-shadow-expected.png.
  • svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-example-expected.txt.
  • svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-with-opacity-expected.txt.
  • svg/css/group-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.txt.
  • svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/path-with-shadow-expected.png.
  • svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png.
  • svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png.
  • svg/css/stars-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.txt.
  • svg/css/text-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.txt.
10:37 PM Changeset in webkit [159012] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVGTextMetricsBuilder::walkTree() should take a RenderElement.
<https://webkit.org/b/124105>

Make walkTree() take a RenderElement so we can use the non-virtual
firstChild() internally. All call sites had pointers to compatible
objects already.

Reviewed by Anders Carlsson.

9:48 PM Changeset in webkit [159011] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderMathMLFenced should pass around operators in tighter types.
<https://webkit.org/b/124115>

Store operator renderers in RenderMathMLOperator pointers instead
of passing them around as RenderObject.

Reviewed by Martin Robinson.

9:47 PM Changeset in webkit [159010] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Use RENDER_OBJECT_TYPE_CASTS for more types.
<https://webkit.org/b/124112>

Generate toRenderFoo() type casting helpers for these classes:

  • RenderCombineText
  • RenderDetailsMarker
  • RenderListMarker
  • RenderVideo
  • RenderView

Reviewed by Anders Carlsson.

9:08 PM Changeset in webkit [159009] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

Move MathML type checking virtuals to RenderObject.
<https://webkit.org/b/124111>

Previously, checking the type of a MathML renderer would require
that you first check if it's a RenderMathMLBlock, and then casting
to that type to access the check you really wanted.

This change moves all the isRenderMathMLFoo() virtual functions
to RenderObject. I also made sure all the overloads were private
and marked them OVERRIDE/FINAL as appropriate.

Finally I replaced all the hand-written casting functions with
autogenerated ones using RENDER_OBJECT_TYPE_CASTS.

Reviewed by Anders Carlsson.

8:20 PM Changeset in webkit [159008] by oliver@apple.com
  • 12 edits
    3 moves
    6 adds in trunk

Add Map Iterators
https://bugs.webkit.org/show_bug.cgi?id=124109

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Added new Map iterator implementation. This is a mostly boilerplate patch
however there's a a little bit of additional logic added to the MapData iterator
to deal with the possibility of map mutation between creation of the iterator
and use of it. We'll be able to improve the performance of this substantially
by using intrinsics, however I'm pondering coming up with a better way to define
these thunks without requiring so much duplicated logic.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSMapIterator.cpp: Added.

(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::visitChildren):
(JSC::JSMapIterator::createPair):

  • runtime/JSMapIterator.h: Added.

(JSC::JSMapIterator::createStructure):
(JSC::JSMapIterator::create):
(JSC::JSMapIterator::next):
(JSC::JSMapIterator::JSMapIterator):

  • runtime/MapData.h:

(JSC::MapData::const_iterator::ensureSlot):

  • runtime/MapIteratorConstructor.cpp: Added.

(JSC::MapIteratorConstructor::finishCreation):

  • runtime/MapIteratorConstructor.h: Added.

(JSC::MapIteratorConstructor::create):
(JSC::MapIteratorConstructor::createStructure):
(JSC::MapIteratorConstructor::MapIteratorConstructor):

  • runtime/MapIteratorPrototype.cpp: Added.

(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncIterator):
(JSC::MapIteratorPrototypeFuncNext):

  • runtime/MapIteratorPrototype.h: Added.

(JSC::MapIteratorPrototype::create):
(JSC::MapIteratorPrototype::createStructure):
(JSC::MapIteratorPrototype::MapIteratorPrototype):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):

LayoutTests:

Moved map tests to a more sensible location, and added new iteration tests.

  • js/basic-map-expected.txt: Renamed from LayoutTests/js/dom/basic-map-expected.txt.
  • js/basic-map.html: Renamed from LayoutTests/js/dom/basic-map.html.
  • js/script-tests/basic-map.js: Renamed from LayoutTests/js/dom/script-tests/basic-map.js.

(set shouldBe):
(set var):

7:39 PM Changeset in webkit [159007] by Martin Robinson
  • 7 edits in trunk

[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837

Reviewed by Brent Fulgham.

Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the

normal variant.

LayoutTests:

  • platform/gtk/mathml/presentation/mo-stretch-expected.png: Update to reflect new results.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.
7:36 PM Changeset in webkit [159006] by akling@apple.com
  • 2 edits
    1 copy
    20 moves
    1 add
    22 deletes in trunk/LayoutTests

Optimize baselines: svg/clip-path

Unreviewed; run "webkit-patch optimize-baselines svg/clip-path"

  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-clip-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-container-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • platform/win-future/svg/clip-path/clip-path-pixelation-expected.txt: Copied from LayoutTests/svg/clip-path/clip-path-pixelation-expected.txt.
  • svg/clip-path/clip-in-clip-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-in-clip-expected.png.
  • svg/clip-path/clip-path-clipped-no-content-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png.
  • svg/clip-path/clip-path-pixelation-expected.txt:
  • svg/clip-path/clip-path-recursive-call-by-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.png.
  • svg/clip-path/clip-path-recursive-call-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-expected.png.
  • svg/clip-path/clip-path-text-and-shape-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt.
  • svg/clip-path/clip-path-text-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt.
  • svg/clip-path/clip-path-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-expected.txt.
  • svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt.
  • svg/clip-path/clip-path-use-as-child2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png.
  • svg/clip-path/clip-path-use-as-child3-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png.
  • svg/clip-path/clip-path-use-as-child4-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png.
  • svg/clip-path/clip-path-use-as-child5-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png.
  • svg/clip-path/clip-path-with-container-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-container-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png.
  • svg/clip-path/clip-path-with-invisibile-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png.
  • svg/clip-path/clip-path-with-text-clipped-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt.
  • svg/clip-path/clipper-placement-issue-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clipper-placement-issue-expected.png.
  • svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
  • svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
7:32 PM Changeset in webkit [159005] by akling@apple.com
  • 2 edits
    5 copies
    48 moves
    2 adds
    57 deletes in trunk/LayoutTests

Optimize baselines: svg/hixie

Unreviewed; run "webkit-patch optimize-baselines svg/hixie"

  • platform/efl/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/003-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/004-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/005-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/001-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/007-expected.png: Removed.
  • platform/gtk/svg/hixie/error/008-expected.png: Removed.
  • platform/gtk/svg/hixie/error/009-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/011-expected.png: Removed.
  • platform/gtk/svg/hixie/error/011-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/014-expected.png: Removed.
  • platform/gtk/svg/hixie/error/014-test-expected.png: Removed.
  • platform/gtk/svg/hixie/error/015-expected.png: Removed.
  • platform/gtk/svg/hixie/error/016-expected.png: Removed.
  • platform/gtk/svg/hixie/error/017-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/links/002-expected.png: Removed.
  • platform/gtk/svg/hixie/links/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/mixed/007-expected.png: Removed.
  • platform/gtk/svg/hixie/painting/001-expected.png: Removed.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/004-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/005-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/006-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/processing-model/003-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/004-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/005-expected.png: Removed.
  • platform/gtk/svg/hixie/rendering-model/003a-expected.png: Removed.
  • platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003a-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003b-expected.txt: Removed.
  • platform/gtk/svg/hixie/use/001-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-test-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/001-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/004-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/mac/svg/hixie/cascade/002-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/004-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/005-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/006-expected.txt: Removed.
  • platform/win-future/svg/hixie/perf/007-expected.txt: Copied from LayoutTests/svg/hixie/perf/007-expected.txt.
  • svg/hixie/cascade/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/cascade/002-expected.txt.
  • svg/hixie/dynamic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/002-expected.png.
  • svg/hixie/dynamic/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/003-expected.png.
  • svg/hixie/dynamic/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/004-expected.png.
  • svg/hixie/dynamic/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/005-expected.png.
  • svg/hixie/dynamic/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/006-expected.png.
  • svg/hixie/error/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/001-expected.png.
  • svg/hixie/error/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.png.
  • svg/hixie/error/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.txt.
  • svg/hixie/error/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/003-expected.txt.
  • svg/hixie/error/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/006-expected.png.
  • svg/hixie/error/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/007-expected.png.
  • svg/hixie/error/008-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/008-expected.png.
  • svg/hixie/error/009-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/009-expected.png.
  • svg/hixie/error/010-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.png.
  • svg/hixie/error/010-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.txt.
  • svg/hixie/error/011-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.png.
  • svg/hixie/error/011-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.txt.
  • svg/hixie/error/014-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-expected.png.
  • svg/hixie/error/014-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-test-expected.png.
  • svg/hixie/error/015-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/015-expected.png.
  • svg/hixie/error/016-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/016-expected.png.
  • svg/hixie/error/017-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/017-expected.txt.
  • svg/hixie/intrinsic/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.png.
  • svg/hixie/intrinsic/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.txt.
  • svg/hixie/intrinsic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.png.
  • svg/hixie/intrinsic/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.txt.
  • svg/hixie/links/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.png.
  • svg/hixie/links/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.txt.
  • svg/hixie/mixed/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/mixed/007-expected.png.
  • svg/hixie/painting/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/painting/001-expected.png.
  • svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
  • svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
  • svg/hixie/perf/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/003-expected.txt.
  • svg/hixie/perf/004-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/004-expected.txt.
  • svg/hixie/perf/005-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/005-expected.txt.
  • svg/hixie/perf/006-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/006-expected.txt.
  • svg/hixie/perf/007-expected.txt:
  • svg/hixie/processing-model/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/003-expected.png.
  • svg/hixie/processing-model/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/004-expected.png.
  • svg/hixie/processing-model/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/005-expected.png.
  • svg/hixie/rendering-model/003a-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/rendering-model/003a-expected.png.
  • svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
  • svg/hixie/text/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/002-expected.txt.
  • svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003a-expected.txt.
  • svg/hixie/text/003b-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003b-expected.txt.
  • svg/hixie/use/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/001-expected.png.
  • svg/hixie/use/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-expected.png.
  • svg/hixie/use/002-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-test-expected.png.
  • svg/hixie/viewbox/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/001-expected.png.
  • svg/hixie/viewbox/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/004-expected.png.
  • svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
  • svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt.
5:27 PM Changeset in webkit [159004] by andersca@apple.com
  • 7 edits in trunk/Source

Encode form data using the KeyedEncoder
https://bugs.webkit.org/show_bug.cgi?id=124107

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeEnum):

  • platform/network/FormData.cpp:

(WebCore::encodeElement):
(WebCore::FormData::encode):

  • platform/network/FormData.h:

Source/WebKit2:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeDouble):

  • Shared/cf/KeyedEncoder.h:
3:26 PM Changeset in webkit [159003] by andersca@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove an unused file.

Rubber-stamped by Andreas Kling.

  • WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Removed.
1:41 PM Changeset in webkit [159002] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Modernize CanvasObserverProxy
https://bugs.webkit.org/show_bug.cgi?id=124106

Reviewed by Anders Carlsson.

  • css/CSSCanvasValue.h:
12:59 PM Changeset in webkit [159001] by Patrick Gansterer
  • 101 edits
    7 moves
    1 add in trunk/Source

Move RunLoop from WebCore to WTF
https://bugs.webkit.org/show_bug.cgi?id=116606

Reviewed by Anders Carlsson.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformWin.cmake:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]):

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

  • Misc/WebCache.mm:

(+[WebCache initialize]):

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

  • WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

  • WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

  • WebView/WebView.mm:

(+[WebView initialize]):

  • WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:
  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/mac/DiskCacheMonitor.h:
  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.cpp:
  • PluginProcess/unix/PluginProcessMainUnix.cpp:
  • Shared/ChildProcess.cpp:
  • Shared/ChildProcess.h:
  • Shared/ChildProcessProxy.cpp:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
  • Shared/Plugins/NPObjectProxy.cpp:
  • Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/WKPrintingView.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/ResponsivenessTimer.cpp:
  • UIProcess/ResponsivenessTimer.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
  • WebProcess/Network/WebResourceLoadScheduler.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/EventDispatcher.cpp:
  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:

Source/WTF:

With this change RunLoop can be used in JavaScriptCore too.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PlatformBlackBerry.cmake:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformGTK.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/RunLoop.cpp: Renamed from Source/WebCore/platform/RunLoop.cpp.

(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h: Renamed from Source/WebCore/platform/RunLoop.h.

(WTF::RunLoop::TimerBase::startRepeating):
(WTF::RunLoop::TimerBase::startOneShot):
(WTF::RunLoop::TimerBase::isRepeating):
(WTF::RunLoop::Timer::Timer):
(WTF::RunLoop::Timer::fired):

  • wtf/blackberry/RunLoopBlackBerry.cpp: Renamed from Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):

  • wtf/cf/RunLoopCF.cpp: Renamed from Source/WebCore/platform/cf/RunLoopCF.cpp.

(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::runForDuration):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/efl/RunLoopEfl.cpp: Renamed from Source/WebCore/platform/efl/RunLoopEfl.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/gtk/RunLoopGtk.cpp: Renamed from Source/WebCore/platform/gtk/RunLoopGtk.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::innermostLoop):
(WTF::RunLoop::pushNestedMainLoop):
(WTF::RunLoop::popNestedMainLoop):
(WTF::RunLoop::stop):
(WTF::RunLoop::queueWork):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::clearTimerSource):
(WTF::RunLoop::TimerBase::timerFiredCallback):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/win/RunLoopWin.cpp: Renamed from Source/WebCore/platform/win/RunLoopWin.cpp.

(WTF::RunLoop::RunLoopWndProc):
(WTF::RunLoop::wndProc):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::generateTimerID):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

8:11 AM Changeset in webkit [159000] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Tighten typing in SVGResourcesCycleSolver a bit.
<https://webkit.org/b/124104>

Make the SVGResourcesCycleSolver constructor take a RenderElement&
and a SVGResources&.

While I was in the neighborhood, also converted one loop to use a
renderer iterator instead of walking siblings manually.

Finally used "auto" to clean up some overly wordy loops.

Reviewed by Anders Carlsson.

3:32 AM Changeset in webkit [158999] by akling@apple.com
  • 18 edits in trunk/Source/WebCore

Beat SVGRenderSupport with the RenderElement stick.
<https://webkit.org/b/124102>

Tighten up all the SVGRenderSupport helper functions by making them
take const RenderElements references instead of raw RenderObject
pointers as much as possible.

This tunes up a bunch of branchy style() calls.

The patch looks big but it's mostly mechanical. I just changed the
signatures and then worked backwards until everything built again.

Reviewed by Antti Koivisto.

3:17 AM Changeset in webkit [158998] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

SVGTextLayoutAttributes always has a RenderSVGInlineText.
<https://webkit.org/b/124101>

No SVGTextLayoutAttributes object is without a RenderSVGInlineText
"context" so make context() return a reference.

Reviewed by Antti Koivisto.

3:16 AM Changeset in webkit [158997] by akling@apple.com
  • 13 edits
    2 deletes in trunk/Source/WebCore

Move BindingSecurity stuff under JSDOMBinding umbrella.
<https://webkit.org/b/124099>

We are hitting shouldAllowAccessToDOMWindow() pretty hard on the
demo here: <http://www.jasondavies.com/maps/rotate/>

Putting it together with the rest of the JSDOMBinding code takes
CPU time spent in there from 8.7% to 6.5%. The abstraction was
only used to support alternate JS engines in the past.

Reviewed by Antti Koivisto.

3:14 AM Changeset in webkit [158996] by Antti Koivisto
  • 2 edits in trunk/PerformanceTests

Add subtest for word-break:break-all to Layout/line-layout-simple.html
https://bugs.webkit.org/show_bug.cgi?id=124103

Reviewed by Andreas Kling.

  • Layout/line-layout-simple.html:

Combination "white-space:pre-wrap; word-break:break-all" is common for pure text.

Nov 8, 2013:

11:57 PM Changeset in webkit [158995] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed GTK build fix.

  • GNUmakefile.list.am: Remove redundant build targets.
10:55 PM Changeset in webkit [158994] by fpizlo@apple.com
  • 4 edits
    2 deletes in trunk/Source/JavaScriptCore

Remove dead FTL C ABI support
https://bugs.webkit.org/show_bug.cgi?id=124100

Reviewed by Jer Noble.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • ftl/FTLCArgumentGetter.cpp: Removed.
  • ftl/FTLCArgumentGetter.h: Removed.
  • ftl/FTLOSRExitCompiler.cpp:
  • jit/FPRInfo.h:
10:53 PM Changeset in webkit [158993] by fpizlo@apple.com
  • 3 edits in trunk/WebKitLibraries

Update binary drops to a version that includes new stackmap fixes and exposes the new calling conventions.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
10:27 PM Changeset in webkit [158992] by beidson@apple.com
  • 39 edits
    2 moves
    1 delete in trunk/Source

Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124088

Source/WebCore:

Reviewed by Tim Horton.

Source/WebKit2:

Reviewed by Tim Horton.

This abstraction is no longer meaningful in its current form in WebCore.
The current groundwork for the WK2 DatabaseProcess relied on this abstraction,
but that will be reworked in a future patch.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):
(WebKit::WebIDBFactoryBackend::createCursorBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:

(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):

  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
10:00 PM Changeset in webkit [158991] by commit-queue@webkit.org
  • 12 edits in trunk/LayoutTests

Updating LayoutTests that depend on RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=124097

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Needed to do not throw unwanted exception

  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-state.html:
8:40 PM Changeset in webkit [158990] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r158984.

No needs to include "KeyedEncoder.h".
WebKit/Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:31:26: fatal error: KeyedEncoder.h: No such file or directory

  • WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed #include line.
8:24 PM Changeset in webkit [158989] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

FTL should support Phantom(FinalObject:)
https://bugs.webkit.org/show_bug.cgi?id=124092

Reviewed by Oliver Hunt.

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isType):
(JSC::FTL::LowerDFGToLLVM::isNotType):
(JSC::FTL::LowerDFGToLLVM::speculateFinalObject):

8:20 PM Changeset in webkit [158988] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of the FTL tail call APIs since they are unused
https://bugs.webkit.org/show_bug.cgi?id=124093

Reviewed by Oliver Hunt.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildCall):

  • ftl/FTLOutput.h:
8:17 PM Changeset in webkit [158987] by commit-queue@webkit.org
  • 25 edits in trunk/LayoutTests

Improving readability of LayoutTests in fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=124095

Adding some indentation

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

  • fast/mediastream/MediaStream-add-remove-tracks.html:
  • fast/mediastream/MediaStream-onended.html:
  • fast/mediastream/MediaStreamConstructor.html:
  • fast/mediastream/RTCIceCandidate.html:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-state.html:
  • fast/mediastream/RTCPeerConnection-stats.html:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/RTCPeerConnection.html:
  • fast/mediastream/RTCSessionDescription.html:
  • fast/mediastream/argument-types.html:
  • fast/mediastream/constructors.html:
  • fast/mediastream/enabled.html:
  • fast/mediastream/getusermedia.html:
  • fast/mediastream/no-interface-object.html:
7:40 PM Changeset in webkit [158986] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Reindent JSDOMBinding.h (finally.)

Rubber-stamped by Sam Weinig.

7:24 PM Changeset in webkit [158985] by weinig@apple.com
  • 64 edits in trunk/Source/WebCore

Change collectStyleForPresentationAttribute and related functions to take a MutableStylePropertySet by reference
https://bugs.webkit.org/show_bug.cgi?id=124096

Reviewed by Andreas Kling.

Pass MutableStylePropertySet by reference. It is never null.

5:51 PM Changeset in webkit [158984] by andersca@apple.com
  • 7 edits in trunk/Source

Implement encoding of arrays of objects
https://bugs.webkit.org/show_bug.cgi?id=124091

Reviewed by Beth Dakin.

Source/WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the rest of the members.

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObjects):
Call beginArray, then beginArrayElement/endArrayElement for every element and lastly endArray.

Source/WebKit2:

Add a new array stack and push and pop from it accordingly.

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):

  • Shared/cf/KeyedEncoder.h:
5:44 PM Changeset in webkit [158983] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should support AllocatePropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=124086

Reviewed by Oliver Hunt.

Also rationalized some offsets in the DFG.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):

5:43 PM Changeset in webkit [158982] by timothy_horton@apple.com
  • 13 edits in trunk/Source

Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache
https://bugs.webkit.org/show_bug.cgi?id=123944

Reviewed by Simon Fraser.

Ensure that the tile cache retrieves repaint rects from the tile layer,
not from the tiled backing layer.

Rework RemoteLayerBackingStore painting to fix some rounding issues
that would cause pixel cracks upon repaint, and to speed it up a bit.

  • Shared/mac/RemoteLayerBackingStore.h:

Redefine RepaintRectList because we can't include WebLayer.h here yet.
Remove createBackingStore, which was never implemented.
Remove mapToContentCoordinates, because we don't need it on Mac.

(WebKit::RemoteLayerBackingStore::paintingRects): Added.

  • Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Stop using mapToContentCoordinates.

(RemoteLayerBackingStore::drawInContext):
Use clipping instead of painting the image multiple times.
Never repaint more than the dirty region's bounds.
Don't waste time with all of the drawNativeImage code, just use CG.
Unindent the switch's cases.
Store the rects we're painting so that enumerateRectsBeingDrawn can get them.
Pixel-snap the rects we're painting.
Clip the context before going to paint.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::enumerateRectsBeingDrawn):

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Retrieve the rects currently being painted from our backing store, and
transform them (mostly) according to the CTM, to match the transformation
that will have occurred underneath wkCALayerEnumerateRectsBeingDrawnWithBlock.

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::enumerateRectsBeingDrawn):
Allow the PlatformCALayer to decide how to enumerate rects to paint.

  • WebCore.exp.in:
  • platform/graphics/mac/WebLayer.h:

Add RepaintRectList, remove some unnecessary WebCore::s.

  • platform/graphics/mac/WebLayer.mm:

(WebCore::collectRectsToPaint):
Factor collectRectsToPaint out; it just grabs the rects from
the layer and makes the decision whether to repaint the bounds
of the dirty region or just the subregions.

Move calls to collectRectsToPaint() to callers of drawLayerContents(),
so that TileController can collect rects from the appropriate source
(the Tile layer) and other layers just continue grabbing them from
their relevant layers.

Make sure that the list that comes from collectRectsToPaint() always
has at least one rect in it (appending the clip bounds if we don't
want to repaint subregions) so we can simplify logic in drawLayerContents.

(WebCore::drawLayerContents):
Remove code to support CompositingCoordinatesBottomUp, as it's only
used on Windows, so this Mac-specific code doesn't need to support it.

Simplify logic given that dirtyRects will always be non-empty.

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::platformCALayerPaintContents):
Adopt collectRectsToPaint.

5:29 PM Changeset in webkit [158981] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of the bizarre Darwin/x86-only MacroAssembler::shouldBlindForSpecificArch(uintptr_t) overload
https://bugs.webkit.org/show_bug.cgi?id=124087

Reviewed by Michael Saboff.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlindPointerForSpecificArch):
(JSC::MacroAssembler::shouldBlind):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

5:16 PM Changeset in webkit [158980] by andersca@apple.com
  • 7 edits in trunk/Source

Implement more KeyedEncoder functionality
https://bugs.webkit.org/show_bug.cgi?id=124089

Reviewed by Beth Dakin.

Source/WebCore:

  • bindings/js/SerializedScriptValue.h:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeConditionalObject):

Source/WebKit2:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeFloat):

  • Shared/cf/KeyedEncoder.h:
5:13 PM Changeset in webkit [158979] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

getCueAsHTML() on an empty cue should return a document fragment
https://bugs.webkit.org/show_bug.cgi?id=124084

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-empty-cue-text.html

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the

passed an empty string.

LayoutTests:

  • media/track/track-cue-empty-cue-text-expected.txt: Added.
  • media/track/track-cue-empty-cue-text.html: Added.
4:51 PM Changeset in webkit [158978] by andersca@apple.com
  • 7 edits in trunk/Source

KeyedEncoder should be able to encoder objects
https://bugs.webkit.org/show_bug.cgi?id=124085

Reviewed by Sam Weinig.

Source/WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):
Encode the root object.

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the target.

  • history/HistoryItem.h:

Add new members.

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObject):
Call beginObject, call the functor and then call endObject().

Source/WebKit2:

Add a dictionary stack to KeyedEncoder that's pushed and popped by
beginObject/endObject.

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):

  • Shared/cf/KeyedEncoder.h:
4:42 PM Changeset in webkit [158977] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL should support NewArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=124067

Reviewed by Michael Saboff.

This expanded coverage and revealed some bugs.

This revealed a bug in FTL::OSRExitCompiler where it was assuming that it could save
the framePointer in regT3 even though DFG::reifyInlinedCallFrames() would clobber it.
It turns out that this can be fixed by just completely restoring the stack prior to
doing reifyInlineCallFrames().

I used this as an opportunity to simplify NewArray. That revealed a bug; whenever we say
lowJSValue() in there we need to use ManualOperandSpeculation since we're using it to
rebox values even when we also have to do some speculations. The speculations are done
at the top of compileNewArray().

This also revealed a bug in StringCharAt() for the OOB case.

  • ftl/FTLAbstractHeapRepository.h:

(JSC::FTL::AbstractHeapRepository::forIndexingType):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

4:39 PM Changeset in webkit [158976] by Alexandru Chiculita
  • 4 edits
    2 adds in trunk

Web Inspector: It should be possible to debug the Inspector code
https://bugs.webkit.org/show_bug.cgi?id=124065

Reviewed by Timothy Hatcher.

Source/WebKit2:

When the script is paused, the debugger will pause all the pages in the same PageGroup.
All the Inspector windows were created in the same PageGroup, so pausing one debugger
would stop the other too.

Added WebInspectorPageGroups to manage the PageGroups created for the Inspectors.
The WebInspectors will now use the inspection "level" to figure out which PageGroup to use.
The inspector that debugs the main page will use "WebInspectorPageGroupLevel1",
the second inspector (that debugs the first inspector) will use "WebInspectorPageGroupLevel2" ...

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::shared):
(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorPageGroups::inspectorPageGroupForLevel):
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::inspectorPageGroup):
(WebKit::WebInspectorProxy::isInspectorPage):
(WebKit::WebInspectorProxy::canAttach):

  • UIProcess/WebInspectorProxy.h:

LayoutTests:

Added test to check that a second inspector window can be used to debug the first one.

  • inspector-protocol/debugger/nested-inspectors-expected.txt: Added.
  • inspector-protocol/debugger/nested-inspectors.html: Added.
4:39 PM Changeset in webkit [158975] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

It should be easy to disable blinding on a per-architecture basis
https://bugs.webkit.org/show_bug.cgi?id=124083

Reviewed by Michael Saboff.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::haveScratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::canBlind):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::canBlind):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::haveScratchRegisterForBlinding):

4:32 PM Changeset in webkit [158974] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

4:29 PM Changeset in webkit [158973] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.73.5

New Tag.

4:27 PM Changeset in webkit [158972] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Teach CanvasObserver about references
https://bugs.webkit.org/show_bug.cgi?id=124082

Reviewed by Anders Carlsson.

  • css/CSSCanvasValue.cpp:
  • css/CSSCanvasValue.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
4:25 PM Changeset in webkit [158971] by andersca@apple.com
  • 8 edits
    3 moves
    2 deletes in trunk/Source

Begin stubbing out a KeyedEncoder class in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124079

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:

Add symbol needed by WebCore.

  • WebCore.xcodeproj/project.pbxproj:

Add new header file.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):

  • history/HistoryItem.h:

Add an encodeBackForwardTree overload that takes a KeyedEncoder object. Encode the version.

  • platform/KeyedCoding.h:

Add a KeyedEncoder class that just has a single encodeUInt32 member function for now.

Source/WebKit2:

  • Shared/KeyedEncoder.h: Removed.
  • Shared/cf/KeyedCodingValueCF.cpp: Removed.
  • Shared/cf/KeyedEncoder.cpp: Added.

Remove old keyed encoders.

(WebKit::createDictionary):
Helper function to create a mutable dictionary.
(WebKit::KeyedEncoder::KeyedEncoder):
Create the root dictionary.

(WebKit::KeyedEncoder::encodeUInt32):
Create a CFNumberRef and add it to the dictionary.

  • Shared/cf/KeyedEncoder.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):
Create a KeyedEncoder and encode the history tree.

4:18 PM Changeset in webkit [158970] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore

Rollout r158882. <rdar://problem/15426318>

4:09 PM Changeset in webkit [158969] by beidson@apple.com
  • 20 edits
    1 move
    1 add
    2 deletes in trunk/Source

Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124077

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The abstraction is no longer needed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
  • Modules/indexeddb/IDBTransactionBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
  • Modules/indexeddb/IDBTransactionBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBCursorBackend.cpp:
  • Modules/indexeddb/IDBCursorBackend.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
  • Modules/indexeddb/IDBDatabaseBackendImpl.h:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.h:
  • Modules/indexeddb/IDBTransactionCoordinator.cpp:
  • Modules/indexeddb/IDBTransactionCoordinator.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
3:53 PM Changeset in webkit [158968] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=124075

Reviewed by Beth Dakin.

In r155660 I removed some scrollbar-related layouts when scrollbars
are in overlay mode.

However, ScrollView::updateScrollbars() has a case where we still need
to do multiple pases, related to its "Never ever try to both gain/lose a
scrollbar in the same pass" comment. When we avoid making a new scrollbar
because the other was removed, we need to do another pass to bring the
correct scrollbar back.

Can't test overlay scrollbars in tests.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

3:46 PM Changeset in webkit [158967] by hmuller@adobe.com
  • 4 edits
    4 adds in trunk

[CSS Shapes] Image valued shape-outside that extends vertically into the margin-box is top-clipped
https://bugs.webkit.org/show_bug.cgi?id=123769

Reviewed by Dirk Schulze.

Source/WebCore:

Remove the assumption that Y coordinates are >= 0 from the RasterShapeIntervals class
and correct its computeShapeMarginIntervals() method. The computeShapeMarginIntervals()
method now generates intervals with Y coordinates that begin at the image shape's
bounds.y - shape-margin, which may be less than 0.

The RasterShapeIntervals::intervalsAt() method now offsets its Y coordinate parameter
by the shape-margin. A non-const overload of the method was added to centralize all
access to m_intervalLists.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html

fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html

  • rendering/shapes/RasterShape.cpp:

(WebCore::MarginIntervalGenerator::intervalAt): Don't clip X coordinates to 0 since they can extend into the margin-box.
(WebCore::RasterShapeIntervals::appendInterval): Use the non-const intervalsAt() method.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): See above.

  • rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::RasterShapeIntervals): Added a field for the margin.
(WebCore::RasterShapeIntervals::intervalsAt): Offset y coordinates by the margin; added a non-const overload.

LayoutTests:

Verify that lines overlap a shape-outside that extends into the top of the margin-box
do wrap around the top of the shape as well its side and bottom.

  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html: Added.
3:46 PM Changeset in webkit [158966] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove -webkit-min and -webkit-max from CSS completions
https://bugs.webkit.org/show_bug.cgi?id=124072

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-08
Reviewed by Timothy Hatcher.

-webkit-min and -webkit-max are not implemented in WebCore, despite mentions of it.

  • UserInterface/CSSKeywordCompletions.js:
3:45 PM Changeset in webkit [158965] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Ended event should work also when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123879

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

According to W3C specification playback is ended also when playback rate is
negative and position is the earliest possible position.

Test: media/video-ended-event-negative-playback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

LayoutTests:

Tests if ended event is triggered for audio/video elements after
changing playback rate to negative.

  • media/video-ended-event-negative-playback-expected.txt: Added.
  • media/video-ended-event-negative-playback.html: Added.
3:36 PM Changeset in webkit [158964] by commit-queue@webkit.org
  • 25 edits
    1 add in trunk

Checking for TypeError in RTCPeerConnection object creation
https://bugs.webkit.org/show_bug.cgi?id=124049

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

If invalid parameters are passed on RTCPeerConnection creation we must throw a TypeError exception.
According to the spec it requires a Dictionary argument, the RTCConfiguration, which is mandatory.

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

Existing tests were updated.

  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.idl:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSRTCPeerConnectionCustom.cpp: Added.

(WebCore::JSRTCPeerConnectionConstructor::constructJSRTCPeerConnection):

LayoutTests:

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/RTCPeerConnection.html:
3:24 PM Changeset in webkit [158963] by Bem Jones-Bey
  • 4 edits in trunk/Source/WebCore

Use references instead of pointers to RenderBlockFlow in FloatingObjects and ComputeFloatOffsetAdapter
https://bugs.webkit.org/show_bug.cgi?id=124074

Reviewed by Sam Weinig.

Just a straightforward conversion from const pointers to const references.

Also, remove unneeded argument from FloatingObjects constructor.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::shapeInfoForFloat):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::heightRemaining):

  • rendering/FloatingObjects.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createFloatingObjects):

3:23 PM Changeset in webkit [158962] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Teach SubframeLoader a bit about references
https://bugs.webkit.org/show_bug.cgi?id=124076

Reviewed by Anders Carlsson.

  • html/HTMLAppletElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubframeLoader.h:
3:16 PM Changeset in webkit [158961] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Blind Windows build-fix attempt after r158959

  • WebCore.vcxproj/WebCore.vcxproj:
3:10 PM Changeset in webkit [158960] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.73-branch/Source/WebKit2

Merge r158101.

2:48 PM Changeset in webkit [158959] by beidson@apple.com
  • 22 edits
    2 moves
    1 delete in trunk/Source

Merge IDBCursorBackendInterface and IDBCursorBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124068

Reviewed by Anders Carlsson.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBCursorBackendInterface.h: Removed.
  • Modules/indexeddb/IDBCursorBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
  • Modules/indexeddb/IDBCursorBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBCursor.cpp:
  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBCursorWithValue.cpp:
  • Modules/indexeddb/IDBCursorWithValue.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::createCursorBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
2:42 PM Changeset in webkit [158958] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Modernize FrameLoader a bit
https://bugs.webkit.org/show_bug.cgi?id=124073

Reviewed by Anders Carlsson.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:

Use std::unique_ptrs rather than OwnPtrs.

  • loader/MixedContentChecker.cpp:
  • loader/MixedContentChecker.h:

Switch to hold a Frame& rather than Frame*.

2:11 PM Changeset in webkit [158957] by oliver@apple.com
  • 1 edit
    4 deletes in trunk/Source/JavaScriptCore

Remove more accidentally added files.

2:09 PM Changeset in webkit [158956] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Remove code guarded with ENABLE(STREAM)
https://bugs.webkit.org/show_bug.cgi?id=123667

Reviewed by Anders Carlsson.

Remove ENABLE(STREAM)-guarded code. This was added in the effort to provide Stream API support, but
no port enables the feature and the work on this feature has wound down after the Chromium port forked,
leaving this code unmaintained.

  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
2:04 PM Changeset in webkit [158955] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove a workaround for a bug in malloc on Symbian
https://bugs.webkit.org/show_bug.cgi?id=124069

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):

  • Platform/CoreIPC/ArgumentDecoder.h:
2:01 PM Changeset in webkit [158954] by Bem Jones-Bey
  • 6 edits in trunk/Source/WebCore

RenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode
https://bugs.webkit.org/show_bug.cgi?id=123931

Reviewed by Sam Weinig.

Rewrite nextFloatLogicalBottomBelow to use the placed floats tree for
the search and to not need ShapeOutsideFloatOffsetMode anymore. This
moves almost all of the logic into FloatingObjects, making a small
reduction in the amount that RenderBlockFlow needs to know about the
implementation of FloatingObjects.

In addition, change ComputeFloatOffsetAdapter to take in LayoutUnits
and roundToInt itself so that all of it's callers can be simplified.

No new tests, no new behavior.

  • rendering/FloatingObjects.cpp:

(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::nextLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::nextShapeLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/FloatingObjects.h:
  • rendering/LineWidth.cpp:

(WebCore::LineWidth::fitBelowFloats):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock):
(WebCore::RenderBlockFlow::getClearDelta):

  • rendering/RenderBlockFlow.h:
2:01 PM Changeset in webkit [158953] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r157459. <rdar://problem/15411420>

1:55 PM Changeset in webkit [158952] by Lucas Forschler
  • 15 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r157137. <rdar://problem/15411426>

1:50 PM Changeset in webkit [158951] by matthew_hanson@apple.com
  • 3 edits in tags/Safari-538.5/Source/WebCore

Merge r158923.

1:42 PM Changeset in webkit [158950] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r152867. <rdar://problem/15411424>

1:35 PM Changeset in webkit [158949] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

More build fixes.

  • UIProcess/API/mac/WKBrowsingContextController.mm:
  • UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:22 PM Changeset in webkit [158948] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

More build fixes.

  • UIProcess/API/mac/WKConnection.h:
  • UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:19 PM Changeset in webkit [158947] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

  • Shared/API/Cocoa/WKBrowsingContextHandleInternal.h:
1:17 PM Changeset in webkit [158946] by matthew_hanson@apple.com
  • 2 edits in trunk/Tools

Added myself as a contributor.

1:07 PM Changeset in webkit [158945] by ap@apple.com
  • 2 edits
    5 moves in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=124064
Some WebCrypto files are not in correct directories

Rubber-stamped by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
  • crypto/CryptoAlgorithmAesCbcParams.h: Removed.
  • crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
  • crypto/CryptoKeyAES.cpp: Removed.
  • crypto/CryptoKeyAES.h: Removed.
  • crypto/CryptoKeyMac.cpp: Removed.
  • crypto/keys/CryptoKeyAES.cpp: Copied from Source/WebCore/crypto/CryptoKeyAES.cpp.
  • crypto/keys/CryptoKeyAES.h: Copied from Source/WebCore/crypto/CryptoKeyAES.h.
  • crypto/mac/CryptoKeyMac.cpp: Copied from Source/WebCore/crypto/CryptoKeyMac.cpp.
  • crypto/parameters/CryptoAlgorithmAesCbcParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesCbcParams.h.
  • crypto/parameters/CryptoAlgorithmAesKeyGenParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h.
1:05 PM Changeset in webkit [158944] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Replace alignof with alignof.

Rubber-stamped by Beth Dakin.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::decodeStringText):

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::SimpleArgumentCoder::encode):
(CoreIPC::SimpleArgumentCoder::decode):

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

  • WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeString):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeString):

1:01 PM Changeset in webkit [158943] by ap@apple.com
  • 10 edits
    14 adds
    1 delete in trunk

Implement JWK key import for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=124059

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-import-jwk.html

crypto/subtle/hmac-import-jwk.html
crypto/subtle/import-jwk.html

WebCrypto supports multiple key formats - raw, pkcs8, spki, jwk. The design is that
we'll transform these into parsed KeyData subclasses before passing to algorithms.

CryptoKeySerialization is a base class for handling all these formats.

  • WebCore.xcodeproj/project.pbxproj: Added new files. Removed CryptoKeyFormat.h.


  • bindings/js/JSCryptoKeySerializationJWK.h: Added.
  • bindings/js/JSCryptoKeySerializationJWK.cpp: Added.

(WebCore::getStringFromJSON): A helper. Note that we can rely on the object being
a nice freshly parsed JSON, no getters or anything.
(WebCore::getBooleanFromJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::JSCryptoKeySerializationJWK):
(WebCore::JSCryptoKeySerializationJWK::~JSCryptoKeySerializationJWK):
(WebCore::createHMACParameters): A simple helper.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): WebCrypto API is weird,
you can have algorithm parameters both inside a JWK key and passed as importKey()
arguments. They need to agree, whatever that means for specific serialization's
algorithm options (not all necessarily have a 1-1 matching to WebCrypto).
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Take an intersection of usages.
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable): Only extractable if
both JWK and the caller agree.
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): Verify validity of JWK key.
(WebCore::JSCryptoKeySerializationJWK::keyData): Return an appropriate KeyData
subclass.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::ENUM_CLASS): Moved CryptoKeyFormat here.
(WebCore::cryptoKeyFormatFromJSValue): Added a human readable string to an exception.
(WebCore::JSSubtleCrypto::importKey): Support multiple key formats, not just raw.

  • crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::importKey):
  • crypto/CryptoAlgorithm.h:

Updated signature for importKey to one that makes more sense. Decoding formats all
the way from a binary blob is not something that CryptoAlgorithm subclasses should
do, we now pass a KeyData subclass instead.
Removed exportKey/wrapKey/unwrapKey altogether, because I don't yet know what the
signatures will be.

  • crypto/CryptoKeyData.h: Added.

(WebCore::CryptoKeyData::ENUM_CLASS):
(WebCore::CryptoKeyData::CryptoKeyData):
(WebCore::CryptoKeyData::~CryptoKeyData):
(WebCore::CryptoKeyData::format):
A base class for passing key material to algorithms. Currently, only one type is
supported, that being OctetSequence for secret keys. Keys for RSA and EC are more
complicated, and secret/public ones are different too.

  • crypto/CryptoKeyFormat.h: Removed. There are too many key format classes

confusingly floating around, and this was only needed in one file for parsing.

  • crypto/CryptoKeySerialization.h: Added.

Base class for handling raw/pkcs8/spki/jwk keys.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::importKey):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:

Updated to use CryptoKeyData.

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:

Updated to use CryptoKeyData.

  • crypto/keys/CryptoKeyDataOctetSequence.cpp: Added.

(WebCore::CryptoKeyDataOctetSequence::CryptoKeyDataOctetSequence):
(WebCore::CryptoKeyDataOctetSequence::~CryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeyDataOctetSequence.h: Added.

(WebCore::asCryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeySerializationRaw.cpp: Added.

(WebCore::CryptoKeySerializationRaw::CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::~CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::reconcileAlgorithm):
(WebCore::CryptoKeySerializationRaw::reconcileUsages):
(WebCore::CryptoKeySerializationRaw::reconcileExtractable):
(WebCore::CryptoKeySerializationRaw::keyData):

  • crypto/keys/CryptoKeySerializationRaw.h: Added.

Much code to pass around a Vector<char>.

LayoutTests:

  • crypto/subtle/aes-cbc-import-jwk-expected.txt: Added.
  • crypto/subtle/aes-cbc-import-jwk.html: Added.
  • crypto/subtle/hmac-import-jwk-expected.txt: Added.
  • crypto/subtle/hmac-import-jwk.html: Added.
  • crypto/subtle/import-jwk-expected.txt: Added.
  • crypto/subtle/import-jwk.html: Added.
12:42 PM Changeset in webkit [158942] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add a way to get a WKWebProcessPlugInBrowserContextController from a handle
https://bugs.webkit.org/show_bug.cgi?id=124063

Reviewed by Beth Dakin.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
12:41 PM Changeset in webkit [158941] by oliver@apple.com
  • 1 edit
    2 deletes in trunk/Source/JavaScriptCore

Remove accidentally added files.

12:27 PM Changeset in webkit [158940] by oliver@apple.com
  • 2 edits
    6 adds in trunk/Source/JavaScriptCore

Fix minor (unobservable) bug in ArrayIterator::next()
https://bugs.webkit.org/show_bug.cgi?id=124061

Reviewed by Beth Dakin.

I noticed this while reading the array iterator code. Due to how
ArrayIterator::next() and our enumeration behaviour is implemented
this is not actually a code path that can be hit. But in order to
future proof this it should be correct.

  • runtime/JSArrayIterator.cpp:

(JSC::arrayIteratorNext):

12:22 PM Changeset in webkit [158939] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

More work on WKBrowsingContextHandle
https://bugs.webkit.org/show_bug.cgi?id=124060

Reviewed by Beth Dakin.

Implement -hash and -isEqual: and add -[WKWebProcessPlugInBrowserContextController handle].

  • Shared/API/Cocoa/WKBrowsingContextHandle.mm:

(-[WKBrowsingContextHandle hash]):
(-[WKBrowsingContextHandle isEqual:]):

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(decodeInvocation):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController handle]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
12:06 PM Changeset in webkit [158938] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-538.5/Tools

Unreviewed. Added myself as a committer.

12:03 PM Changeset in webkit [158937] by mark.lam@apple.com
  • 24 edits
    4 adds in trunk/Source

Move breakpoint (and exception break) functionality into JSC::Debugger.
https://bugs.webkit.org/show_bug.cgi?id=121796.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
  • JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

  • ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.

(JSC::Breakpoint::Breakpoint):

  • Breakpoint class to track info for each breakpoint in JSC::Debugger.
  • debugger/Debugger.cpp:

(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope):
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(JSC::Debugger::Debugger):
(JSC::Debugger::detach):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::setPauseOnExceptionsState):
(JSC::Debugger::setPauseOnNextStatement):
(JSC::Debugger::breakProgram):
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::updateCallFrame):
(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):
(JSC::Debugger::currentDebuggerCallFrame):

  • debugger/Debugger.h:
  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):

  • debugger/DebuggerCallFrame.h:
  • debugger/DebuggerPrimitives.h: Added.
  • define SourceID, noSourceID, BreakpointID, and noBreakpointID.

Source/WebCore:

No new tests.

  • In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
  • JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

  • ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/BreakpointID.h: Added.
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::notifyDoneProcessingDebuggerEvents):
(WebCore::ScriptDebugServer::needPauseHandling):
(WebCore::ScriptDebugServer::handleBreakpointHit):
(WebCore::ScriptDebugServer::handleExceptionInBreakpointCondition):
(WebCore::ScriptDebugServer::handlePause):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/SourceID.h: Added.
  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):

  • bindings/js/WorkerScriptDebugServer.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h:

Source/WebKit/mac:

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::handlePause):

11:49 AM Changeset in webkit [158936] by andersca@apple.com
  • 5 edits
    3 copies in trunk/Source/WebKit2

Add A WKBrowsingContextHandle class
https://bugs.webkit.org/show_bug.cgi?id=124058

Reviewed by Sam Weinig.

The WKBrowsingContextHandle class represents a browsing context and can be sent across process boundaries.

  • Shared/API/Cocoa/WKBrowsingContextHandle.h: Added.
  • Shared/API/Cocoa/WKBrowsingContextHandle.mm: Added.

(-[WKBrowsingContextHandle _initWithPageID:]):
(-[WKBrowsingContextHandle encodeWithCoder:]):
(-[WKBrowsingContextHandle initWithCoder:]):
(+[WKBrowsingContextHandle supportsSecureCoding]):

  • Shared/API/Cocoa/WKBrowsingContextHandleInternal.h: Added.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController handle]):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:

(NS_ENUM):

  • WebKit2.xcodeproj/project.pbxproj:
11:45 AM Changeset in webkit [158935] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

InspectorConsoleAgent::didFinishXHRLoading ConsoleMessage should include a column number
https://bugs.webkit.org/show_bug.cgi?id=114316

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-08
Reviewed by Timothy Hatcher.

InspectorConsoleAgent::didFinishXHRLoading creates a ConsoleMessage with a line number,
but it should also include a column number. It looks like ultimately the line number comes from
JSXMLHttpRequest::send, it should also be possible to get the column number at the time.
The column number would be needed by the Web Inspector to jump to the proper place in source code
to show where the XHR originated from.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::SendFunctor::SendFunctor):
(WebCore::SendFunctor::column):
(WebCore::SendFunctor::operator()):
(WebCore::JSXMLHttpRequest::send):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishXHRLoading):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber):
(WebCore::XMLHttpRequest::didFinishLoading):

  • xml/XMLHttpRequest.h:
11:38 AM Changeset in webkit [158934] by Simon Fraser
  • 3 edits
    4 adds in trunk

Left sidebar on cubic-bezier.com flickers
https://bugs.webkit.org/show_bug.cgi?id=123128

Source/WebCore:

Reviewed by Dean Jackson.

The logic that determined whether position:fixed elements outside the viewport
should be composited was incorrect if the fixed element also had a transform.

layer.calculateLayerBounds() only takes into account painted transforms (since they
affect layer bounds). So we need to compute the bounds relative to the layer
itself, then use localToContainerQuad() to map them to document coordinates,
but only to the RenderView so that we don't hit the page scale transform.

Tests: compositing/layer-creation/fixed-position-transformed-into-view.html

compositing/layer-creation/fixed-position-transformed-outside-view.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Dean Jackson.

Tests with transformed, fixed elements which dump the layer tree to see
which layers get composited.

  • compositing/layer-creation/fixed-position-transformed-into-view-expected.txt: Added.
  • compositing/layer-creation/fixed-position-transformed-into-view.html: Added.
  • compositing/layer-creation/fixed-position-transformed-outside-view-expected.txt: Added.
  • compositing/layer-creation/fixed-position-transformed-outside-view.html: Added.
11:37 AM Changeset in webkit [158933] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Make base64url decoding actually work
https://bugs.webkit.org/show_bug.cgi?id=124050

Reviewed by Sam Weinig.

  • wtf/text/Base64.cpp: (WTF::base64DecodeInternal): Don't hardcode knowledge about

alphabet, put it into the map.

11:28 AM Changeset in webkit [158932] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix layout test that was actually testing incorrect behaviour.

11:27 AM Changeset in webkit [158931] by Martin Robinson
  • 9 edits in trunk

[MathML] Center of stretched curly bracket not always vertically centered
https://bugs.webkit.org/show_bug.cgi?id=123715

Reviewed by Brent Fulgham.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
handle the case where two glyph pieces abut.
(WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().

LayoutTests:

because MathML is changing rapidly, but we need it to test these changes.

  • mathml/presentation/mo-stretch.html: Update to show stretching characteristics

of all stretchable glyphs.

  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
11:10 AM Changeset in webkit [158930] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WKRemoteObjectRegistry to WKConnection
https://bugs.webkit.org/show_bug.cgi?id=124054

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKConnection.h:
  • UIProcess/API/mac/WKConnection.mm:

(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

10:47 AM Changeset in webkit [158929] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Map.forEach crashes on deleted values
https://bugs.webkit.org/show_bug.cgi?id=124017

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

MapData iterator did not consider the case of the first entries
being holes. To fix this I've refactored iteration so that we
can perform an initialisation increment on construction, whle
retaining the useful assertion in MapData::const_iterator::operator++

  • runtime/MapData.h:

(JSC::MapData::const_iterator::operator++):
(JSC::MapData::const_iterator::internalIncrement):
(JSC::MapData::const_iterator::const_iterator):

LayoutTests:

Test case

  • js/map-iterate-first-entry-is-a-hole-expected.txt: Added.
  • js/map-iterate-first-entry-is-a-hole.html: Added.
  • js/script-tests/map-iterate-first-entry-is-a-hole.js: Added.

(set map0):

10:30 AM Changeset in webkit [158928] by jer.noble@apple.com
  • 7 edits
    2 adds in trunk

[MSE] Bring SourceBuffer.append up to the most recent spec.
https://bugs.webkit.org/show_bug.cgi?id=123377

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-append-failed.html

Bring the MediaSource append() implementation up to the current spec.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::appendBufferTimerFired):

  • platform/graphics/SourceBufferPrivate.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::evictCodedFrames):
(WebCore::MockSourceBufferPrivate::isFull):

  • platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

  • media/media-source/media-source-append-failed-expected.txt: Added.
  • media/media-source/media-source-append-failed.html: Added.
  • media/media-source/mock-media-source.js:
10:28 AM Changeset in webkit [158927] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode and decode NSURLRequests using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124051

Reviewed by Sam Weinig.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::archiveAndEncodeObject):
(CoreIPC::decodeAndUnarchiveObject):
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

10:25 AM Changeset in webkit [158926] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for ARM architecture.
https://bugs.webkit.org/show_bug.cgi?id=124038

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

  • jit/GPRInfo.h: Remove r11 from the temporary register set, use a free register for

nonPreservedNonReturnGPR and remove obsolete declaration of bucketCounterRegister.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

  • jit/JITOperations.cpp: Frame pointer register is r11 for ARM_TRADITIONAL and

r7 for ARM_THUMB2 instead of r5 since r158883.

10:24 AM Changeset in webkit [158925] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for MIPS architecture.
https://bugs.webkit.org/show_bug.cgi?id=124044

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

  • jit/JITOperations.cpp: Frame pointer register is fp instead of s0 since r158883 for MIPS.
  • jit/ThunkGenerators.cpp: Save and restore the new frame pointer register.

(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

10:03 AM Changeset in webkit [158924] by Chris Fleizach
  • 3 edits in branches/safari-537.73-branch/LayoutTests

Fix up failing layout tests that in branch due to recent accessibility patches.

Unreviewed.

  • media/track/track-in-band-mode-expected.txt:
  • platform/mac/accessibility/listitem-title-expected.txt:
9:55 AM Changeset in webkit [158923] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange + 26
https://bugs.webkit.org/show_bug.cgi?id=124031

Reviewed by Eric Carlson.

WTF::bind() causes errors when given a bare id pointer as a parameter,
when that parameter is casted to a specific NS type pointer (in this
case, a NSArray*) in order to pass it as a parameter to the bound
function.

Instead of passing around bare id pointers, wrap them in RetainPtr<>
objects before passing them to WTF::bind().

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

9:31 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
9:12 AM Changeset in webkit [158922] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win] JavaScript crash in getHostCallReturnValue.
https://bugs.webkit.org/show_bug.cgi?id=124040

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-08
Reviewed by Geoffrey Garen.

  • jit/JITOperations.cpp: Update MSVC assembler code in getHostCallReturnValue according to gcc x86 version.
7:27 AM Changeset in webkit [158921] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests.

  • platform/efl/TestExpectations:
6:57 AM Changeset in webkit [158920] by Antti Koivisto
  • 1 edit
    1 add in trunk/PerformanceTests

Add line layout performance test that exercises more cases
https://bugs.webkit.org/show_bug.cgi?id=124041

Reviewed by Anders Carlsson.

The existing line-layout.html covers the most basic left-aligned case only.
Add a test with more coverage for things that are mostly not yet supported by the simple
line layout path:

  • centered text
  • right aligned text
  • justified text
  • pre
  • white-space:pre-wrap
  • text with simple inlines
  • text with br
  • Layout/line-layout-simple.html: Added.
6:42 AM Changeset in webkit [158919] by commit-queue@webkit.org
  • 6 edits
    5 copies
    3 adds
    5 deletes in trunk/LayoutTests

[GTK] Add new GTK-specific layout test results for vertical text
https://bugs.webkit.org/show_bug.cgi?id=124000

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Rebaselined some expected results for tests that use vertical text.
These tests are now working fine after the fix from Bug 50619.
They have specific results for WebKit2 GTK+ because WebKit1 has a
permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.

  • fast/repaint/japanese-rl-selection-clear-expected.txt:
  • fast/repaint/japanese-rl-selection-repaint-expected.txt:
  • fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • fast/text/international/vertical-text-glyph-test-expected.txt:
  • fast/text/justify-ideograph-vertical-expected.txt:
  • platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
  • platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Removed.
  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-clear-expected.txt.
  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-repaint-expected.txt.
  • platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/fast/text/international/vertical-text-glyph-test-expected.txt.
  • platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/fast/text/justify-ideograph-vertical-expected.txt.
4:53 AM Changeset in webkit [158918] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Templated LChar/UChar paths for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=124035

Reviewed by Andreas Kling.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):

Use a templated function to check for illegal characters.

(WebCore::SimpleLineLayout::skipWhitespaces):

Make a template function.

(WebCore::SimpleLineLayout::textWidth):

Make a template function plus some argument changes.

(WebCore::SimpleLineLayout::createTextRuns):

Template function for creating runs while operating with either LChars or UChar.
Also simplified line breaking and text width measuring logic.

(WebCore::SimpleLineLayout::create):

Pick the template.

  • rendering/break_lines.cpp:
  • rendering/break_lines.h:


Move the implementation to the header (except for the table) so we can use the template
versions directly.

(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

4:16 AM Changeset in webkit [158917] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] accessibility/aria-link-supports-press.html
https://bugs.webkit.org/show_bug.cgi?id=111987

Unreviewed EFL gardening, passes after r158913.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08

  • platform/efl-wk1/TestExpectations: test is no longer failing.
  • platform/efl-wk2/TestExpectations: test is no longer failing.
3:26 AM Changeset in webkit [158916] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[mips] Fix typo (introduced in r158751).
https://bugs.webkit.org/show_bug.cgi?id=124033.

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Csaba Osztrogonác.

  • jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

3:22 AM Changeset in webkit [158915] by Csaba Osztrogonác
  • 4 edits in trunk/Source/JavaScriptCore

[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
https://bugs.webkit.org/show_bug.cgi?id=123891

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

Although patchableBranch32 is implemented in MacroAssemblerARM.h, the used implementation
is the generic one in MacroAssembler.h. This patch fixes it and also implements the
patchableJump() function for CPU(ARM_TRADITIONAL). These specific implementations are
needed for this architecture backend to ensure that these jumps can be relinked.

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::patchableJump):

  • jit/GPRInfo.h: Remove static_cast that are generating warnings in debug builds.

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

2:55 AM Changeset in webkit [158914] by mario@webkit.org
  • 9 edits in trunk

AX: [ATK] <span> elements exposed through ATK when not needed
https://bugs.webkit.org/show_bug.cgi?id=123885

Reviewed by Chris Fleizach.

Source/WebCore:

As per SVN r158195, the way it's decided whether <span> elements
should be ignored or not has slightly changed, causing that the
GTK/EFL ports expose them in cases that they should be ignored,
such as for text elements that neither are focusable (e.g. by
explicitly setting tabindex) nor have a meaningful accessible name
suggesting they should be exposed.

As a result, the flattening that ATK based ports normally do for
this kind of elements (by folding them into their parents) do not
work correctly anymore, making two tests to fail:

platform/gtk/accessibility/spans-paragraphs-and-divs.html
platform/gtk/accessibility/spans.html

This patch encapsulates the part of the logic that affects this in
the computeAccessibilityIsIgnored() method, placing it in a
new method of AccessibilityObject that we can call from ATK's
accessibilityPlatformIncludesObject() to ensure we hide those
<span> elements when they don't fulfill those requirements.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion):
New virtual method encapsulating part of the logic from the function
that computes whether accessibility should be ignored or not.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion):
Override of the new method adding additional checks, as extracted from
the original bits in computeAccessibilityIsIgnored().

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Use the newly added function where we had the original code before.

  • accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make sure <span> elements are ignored if they are not focusable
and they don't have a meaningful accessible name.

LayoutTests:

Removed failure expectations for tests now passing.

  • platform/gtk/TestExpectations: Removed expectations.
2:24 AM Changeset in webkit [158913] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] accessibility/aria-link-supports-press.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98355

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Tools:

Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isPressActionSupported):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectation.

  • platform/gtk/TestExpectations: test is no longer failing.
1:43 AM Changeset in webkit [158912] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[JHBUILD] Jhbuild Makefile build bug workaround
https://bugs.webkit.org/show_bug.cgi?id=123971

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-08
Reviewed by Ryosuke Niwa.

After Jhbuild repository is cloned (for instance when you use
Tools/Scripts/update-webkitefl-libs) it is built from sources.
If you have GREP_OPTIONS grep env variable set (for instance
GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
uses shell grep. For specific GREP_OPTIONS grep output will be
different than expected one by Jhbuild and there is an error
with Jhbuild build. Jhbuild will not be built and then WebKit
source also will not be built. This patch is a workaround to this
issue. It disables GREP_OPTIONS for Jhbuild build time.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

1:06 AM Changeset in webkit [158911] by akling@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add back expectation for test that went missing in r158813.

  • svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
12:16 AM Changeset in webkit [158910] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
https://bugs.webkit.org/show_bug.cgi?id=123990

Reviewed by Philippe Normand.

Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to the
symbols files.

  • bindings/gobject/WebKitDOMEventTarget.symbols:
  • bindings/gobject/webkitdom.symbols:
12:14 AM Changeset in webkit [158909] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Ignore deprecated macros when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=123988

Reviewed by Philippe Normand.

  • gtk/generate-gtkdoc:

(get_common_options): Ignore also WEBKIT_DEPRECATED and
WEBKIT_DEPRECATED_FOR decorators.

12:12 AM Changeset in webkit [158908] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Pass the library namespace to gtkdoc-mkdb
https://bugs.webkit.org/show_bug.cgi?id=123900

Reviewed by Martin Robinson.

This fixes the generation of the index of symbols in the API
documentation.

  • gtk/generate-gtkdoc:

(get_webkit2_options): Define namespace as WebKit.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Define namespace as WebKitDOM.

  • gtk/gtkdoc.py:

(GTKDoc.init): Add namespace option.
(GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.

12:09 AM Changeset in webkit [158907] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=123899

Reviewed by Martin Robinson.

Do not include deprecated API when compiling with
WEBKIT_DISABLE_DEPRECATED option.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:

Nov 7, 2013:

10:08 PM Changeset in webkit [158906] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Enhance SQL journal_mode setting code to be less likely to log an error.
<rdar://problem/15418577> and https://bugs.webkit.org/show_bug.cgi?id=124018

Reviewed by Anders Carlsson.

Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned.
Change the code to handle that.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open): Save the statement result value, and accept SQLITE_OK as a non-error condition.

9:52 PM Changeset in webkit [158905] by gyuyoung.kim@samsung.com
  • 33 edits
    1 copy
    7 adds
    4 deletes in trunk/LayoutTests

[EFL] Layout tests with vertical texts need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=123985

Unreviewed, EFL port needs to do rebaseline since r158848.

  • platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
  • platform/efl/fast/dynamic/text-combine-expected.txt:
  • platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/efl/fast/text/decorations-with-text-combine-expected.txt:
  • platform/efl/fast/text/emphasis-combined-text-expected.txt:
  • platform/efl/fast/text/emphasis-vertical-expected.txt:
  • platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/efl/fast/text/international/text-spliced-font-expected.txt:
  • platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/efl/fast/text/orientation-sideways-expected.txt:
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/efl/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:
9:40 PM Changeset in webkit [158904] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Update an out-dated ASSERT in IconDatabase code.
<rdar://problem/15171118> and https://bugs.webkit.org/show_bug.cgi?id=124030.

Reviewed by Andreas Kling.

With the asynchronous interfaces that have been added and the support for WK2 that has been added,
this ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL): Update an invalid ASSERT.

9:24 PM Changeset in webkit [158903] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

RenderSVGResource helpers should take RenderStyle by const reference.
<https://webkit.org/b/124029>

Take const RenderStyle& instead of RenderStyle* in a few more places
so we can get rid of some ampersands and assertions.

Reviewed by Anders Carlsson.

9:21 PM Changeset in webkit [158902] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/Source/WebCore

[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
https://bugs.webkit.org/show_bug.cgi?id=123984

Reviewed by Mario Sanchez Prada.

As a step to let static_cast<> use TYPE_CASTS_BASE, AccessibilityTableRow|Column|Cell use
ACCESSIBILITY_OBJECT_TYPE_CASTS which can support more helper functions rather than manual
static_cast<>. This change will help to detect bad type casts further.

No new tests, no behavior changes.

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cellForColumnAndRow):

  • accessibility/AccessibilityTableCell.h:
  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::headerObject):

  • accessibility/AccessibilityTableRow.h:
  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(cellAtIndex):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper tableCellParent]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

8:05 PM Changeset in webkit [158901] by mark.lam@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Get rid of the regT* definitions in JSInterfaceJIT.h.
https://bugs.webkit.org/show_bug.cgi?id=123806.

Reviewed by Geoffrey Garen.

JSInterfaceJIT now inherits from GPRInfo and FPRInfo, and relies on them
to provide all the register definitions.

  • jit/GPRInfo.h:

(JSC::GPRInfo::toArgumentRegister):

  • jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITInlines.h:

(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):

  • jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

  • jit/ThunkGenerators.cpp:
7:55 PM Changeset in webkit [158900] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r154375): Image is oriented incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123831

Reviewed by Antonio Gomes.

r154375 made that shouldRespectImageOrientation() isn't used by drawImage().
It causes an image isn't oriented correctly. This patch sets shouldRespectImageOrientation()
value by default.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

7:54 PM Changeset in webkit [158899] by gyuyoung.kim@samsung.com
  • 1 edit
    22 deletes in trunk/LayoutTests

Unreviewed, rolling out r158846.
http://trac.webkit.org/changeset/158846

r158846 was duplicating gardening against r158837.

  • platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
  • platform/efl/http/tests/media/video-cookie-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
  • platform/efl/media/context-menu-actions-expected.txt: Removed.
  • platform/efl/media/media-can-play-flac-audio-expected.txt: Removed.
  • platform/efl/media/media-can-play-webm-expected.txt: Removed.
  • platform/efl/media/media-volume-slider-rendered-below-expected.txt: Removed.
  • platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Removed.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Removed.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Removed.
  • platform/efl/media/track/track-cue-mutable-text-expected.txt: Removed.
  • platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Removed.
  • platform/efl/media/track/track-language-preference-expected.txt: Removed.
  • platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Removed.
  • platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Removed.
  • platform/efl/media/video-controls-fullscreen-volume-expected.txt: Removed.
  • platform/efl/media/video-controls-toggling-expected.txt: Removed.
7:50 PM Changeset in webkit [158898] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123934

Reviewed by Andreas Kling.

Source/WebCore:

RasterShapeIntervals::getExcludedIntervals() was returning an empty
list when the line overlapped any vertical gap in the image. This short-circuit
had been mistakenly copied from getIncludedIntervals(), where it makes sense.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::getExcludedIntervals):

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html: Added.
7:07 PM Changeset in webkit [158897] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Make contents layer borders more visible
https://bugs.webkit.org/show_bug.cgi?id=124025

Reviewed by Tim Horton.

Layer borders for contents layers are impossible to see when the
contentsLayer has the same bounds as its parent; make the contents
layer border 4px thick to make it more visible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setupContentsLayer):

6:57 PM Changeset in webkit [158896] by akling@apple.com
  • 1 edit
    31 moves
    1 add
    36 deletes in trunk/LayoutTests

Optimize baselines: svg/filters

Unreviewed; run "webkit-patch optimize-baselines svg/filters"

  • platform/gtk/svg/filters/animate-fill-expected.png: Removed.
  • platform/gtk/svg/filters/feColorMatrix-default-type-expected.png: Removed.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Removed.
  • platform/gtk/svg/filters/feColorMatrix-values-expected.png: Removed.
  • platform/gtk/svg/filters/feComposite-expected.txt: Removed.
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt: Removed.
  • platform/gtk/svg/filters/feDropShadow-subregion-expected.png: Removed.
  • platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.png: Removed.
  • platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
  • platform/gtk/svg/filters/feGaussianBlur-subregion-expected.png: Removed.
  • platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.png: Removed.
  • platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-change-target-id-expected.png: Removed.
  • platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-remove-target-expected.png: Removed.
  • platform/gtk/svg/filters/feLighting-crash-expected.png: Removed.
  • platform/gtk/svg/filters/feMerge-wrong-input-expected.png: Removed.
  • platform/gtk/svg/filters/filter-empty-g-expected.png: Removed.
  • platform/gtk/svg/filters/filter-hidden-content-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.png: Removed.
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-refresh-expected.png: Removed.
  • platform/gtk/svg/filters/filter-rounding-issues-expected.png: Removed.
  • platform/gtk/svg/filters/filter-width-update-expected.txt: Removed.
  • platform/gtk/svg/filters/filterRes-expected.txt: Removed.
  • platform/gtk/svg/filters/filterRes2-expected.png: Removed.
  • platform/gtk/svg/filters/filteredImage-expected.png: Removed.
  • platform/gtk/svg/filters/sourceAlpha-expected.png: Removed.
  • platform/gtk/svg/filters/sourceAlpha-expected.txt: Removed.
  • platform/mac/svg/filters/feDisplacementMap-expected.txt: Removed.
  • platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
  • platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/filters/filter-hidden-content-expected.txt: Removed.
  • platform/mac/svg/filters/filterRes-expected.txt: Removed.
  • platform/win-future/svg/filters/feImage-reference-svg-primitive-expected.png: Renamed from LayoutTests/svg/filters/feImage-reference-svg-primitive-expected.png.
  • svg/filters/animate-fill-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/animate-fill-expected.png.
  • svg/filters/feColorMatrix-default-type-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-default-type-expected.png.
  • svg/filters/feColorMatrix-offset-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-offset-expected.png.
  • svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-values-expected.png.
  • svg/filters/feComposite-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feComposite-expected.txt.
  • svg/filters/feDisplacementMap-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDisplacementMap-expected.txt.
  • svg/filters/feDropShadow-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-subregion-expected.png.
  • svg/filters/feDropShadow-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png.
  • svg/filters/feDropShadow-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt.
  • svg/filters/feGaussianBlur-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-subregion-expected.png.
  • svg/filters/feGaussianBlur-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png.
  • svg/filters/feGaussianBlur-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt.
  • svg/filters/feImage-change-target-id-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-change-target-id-expected.png.
  • svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt.
  • svg/filters/feImage-remove-target-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-remove-target-expected.png.
  • svg/filters/feLighting-crash-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feLighting-crash-expected.png.
  • svg/filters/feMerge-wrong-input-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feMerge-wrong-input-expected.png.
  • svg/filters/filter-empty-g-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-empty-g-expected.png.
  • svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-hidden-content-expected.txt.
  • svg/filters/filter-on-filter-for-text-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.png.
  • svg/filters/filter-on-filter-for-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.txt.
  • svg/filters/filter-on-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-tspan-expected.txt.
  • svg/filters/filter-refresh-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-refresh-expected.png.
  • svg/filters/filter-rounding-issues-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-rounding-issues-expected.png.
  • svg/filters/filter-width-update-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-width-update-expected.txt.
  • svg/filters/filterRes-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filterRes-expected.txt.
  • svg/filters/filterRes2-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filterRes2-expected.png.
  • svg/filters/filteredImage-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filteredImage-expected.png.
  • svg/filters/sourceAlpha-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.png.
  • svg/filters/sourceAlpha-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.txt.
6:47 PM Changeset in webkit [158895] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode and decode NSURLResponse objects using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124028

Reviewed by Andreas Kling.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

6:43 PM Changeset in webkit [158894] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

InlineFlowBox always has a RenderBoxModelObject, take advantage.
<https://webkit.org/b/124024>

Since InlineFlowBox already has the branch-less renderer() returning
a RenderBoxModelObject&, avoid using InlineBox::boxModelObject()
wherever we have a tightly-typed box. One branch disappears from
every call site.

Deleted boxModelObject() on InlineFlowBox to prevent new code from
calling the less efficient function.

Reviewed by Anders Carlsson.

6:41 PM Changeset in webkit [158893] by akling@apple.com
  • 12 edits in trunk/Source/WebCore

CTTE: Scrolling tree nodes should always have a ScrollingTree&.
<https://webkit.org/b/124022>

Let ScrollingTreeNode and subclasses store the backpointer to the
tree as a ScrollingTree& reference.

Reviewed by Anders Carlsson.

6:22 PM Changeset in webkit [158892] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Move m_destinationID to MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=124026

Reviewed by Andreas Kling.

  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/MessageDecoder.h:

(CoreIPC::MessageDecoder::destinationID):

5:55 PM Changeset in webkit [158891] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should support NewArray
https://bugs.webkit.org/show_bug.cgi?id=124010

Reviewed by Oliver Hunt.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::allocateBasicStorageAndGetEnd):
(JSC::FTL::LowerDFGToLLVM::ArrayValues::ArrayValues):
(JSC::FTL::LowerDFGToLLVM::allocateJSArray):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::storeDouble):

5:54 PM Changeset in webkit [158890] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Get rid of the out-of-line memory attachment type
https://bugs.webkit.org/show_bug.cgi?id=124023

Reviewed by Andreas Kling.

We're only using out-of-line memory for when the message body is too big, so
isolate that code in Connection and get rid of the out of line attachment type.

  • Platform/CoreIPC/Attachment.cpp:

(CoreIPC::Attachment::Attachment):

  • Platform/CoreIPC/Attachment.h:

(CoreIPC::Attachment::port):
(CoreIPC::Attachment::disposition):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createMessageDecoder):

5:42 PM Changeset in webkit [158889] by Simon Fraser
  • 5 edits in trunk/Source

Lots of layers get solid color but transparent contents layers now
https://bugs.webkit.org/show_bug.cgi?id=123537

Source/WebCore:

Reviewed by Tim Horton.

We call rendererBackgroundColor() to determine the layer's background color,
but on most elements this returns the transparent color (a valid color).
This caused us to allocate a contentsLayer, and use the transparent color as its
backgroundColor, which was wasteful.

Fix by only making a background-color layer if the color is not transparent (zero alpha).

Also avoid making a new contents layer on every color change, and make sure that
we don't do implicit animations for backgroundColor, and some other properties
that were omitted by mistake.

Layer tree dumps don't dump content layers, so no way to test easily.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToSolidColor):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(nullActionsDictionary):

Source/WebKit2:

Reviewed by Tim Horton.

Add some properties to the list of things not to implicitly animate.

  • Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::disableActionsForLayer):

5:29 PM Changeset in webkit [158888] by Lucas Forschler
  • 2 edits in tags/Safari-538.5/Source/WebCore

Merge r158869 for <rdar://problem/15406440>.

5:12 PM Changeset in webkit [158887] by roger_fong@apple.com
  • 3 edits in branches/safari-537.60-branch/Source/WebKit

Unreviewed. Windows WebKit makefile fixes.

No need to copy over WebKit.resources.

  • WebKit.vcxproj/WebKit.make:
  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
5:12 PM Changeset in webkit [158886] by Chris Fleizach
  • 6 edits in branches/safari-537.73-branch/LayoutTests

Fix up failing layout tests that referenced wrong paths (due to ToT changes).

Unreviewed.

  • accessibility/negative-tabindex-does-not-expose-label.html:
  • media/track/track-cue-rendering-mode-changed-expected.txt:
  • platform/mac/accessibility/native-list-item-should-not-expose-label.html:
  • platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html:
  • platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html:
5:07 PM Changeset in webkit [158885] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebKit

Unreviewed. Windows WebKit makefile fixes.

No need to copy over WebKit.resources.

  • WebKit.vcxproj/WebKit.make:
  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
3:46 PM Changeset in webkit [158884] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit

Remove a PLATFORM(IOS) from WebKit Private Header
https://bugs.webkit.org/show_bug.cgi?id=124014

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-07
Reviewed by Timothy Hatcher.

Source/WebKit/ios:

  • WebKit.iOS.exp:

Source/WebKit/mac:

Make the previously iOS only WebInspectorDidStartSearchingForNode
and WebInspectorDidStopSearchingForNode notifications non iOS specific.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::didSetSearchingForNode):

  • WebInspector/WebInspector.h:
  • WebInspector/WebInspector.mm:
  • WebKit.exp:
3:45 PM Changeset in webkit [158883] by msaboff@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Change CallFrameRegister to architected frame pointer register
https://bugs.webkit.org/show_bug.cgi?id=123956

Reviewed by Geoffrey Garen.

Changed X86 and ARM variants as well as MIPS to use their respective architected
frame pointer registers. The freed up callFrameRegisteris are made available to
the DFG register allocator. Modified the FTL OSR exit compiler to use a temporary
register as a stand in for the destination callFrameRegister since the FTL frame
pointer register is needed to extract values from the FTL stack.

Reviewed by Geoffrey Garen.

  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/MacroAssemblerMIPS.h:
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::addressFor):

  • jit/GPRInfo.h:

(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

  • jit/JITOperations.cpp:
  • jit/JSInterfaceJIT.h:
  • jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

  • offlineasm/arm.rb:
  • offlineasm/arm64.rb:
  • offlineasm/mips.rb:
  • offlineasm/x86.rb:
3:40 PM Changeset in webkit [158882] by roger_fong@apple.com
  • 2 edits in branches/safari-537.60-branch/Source/JavaScriptCore

Rollout part of r146669 which caused a performance regression.
<rdar://problem/15265457>.

Rubberstamped by Filip Pizlo.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

3:34 PM Changeset in webkit [158881] by Alexandru Chiculita
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CSS Regions: Use a Map object to store the ContentFlows
https://bugs.webkit.org/show_bug.cgi?id=124015

Reviewed by Joseph Pecoraro.

Changed the Object hashmap to a Map based hashmap when storing the flows in DOMTreeManager.

  • UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
(WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):

3:31 PM Changeset in webkit [158880] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove more dead code
https://bugs.webkit.org/show_bug.cgi?id=124016

Reviewed by Beth Dakin.

We're always layer backed now so we never scroll using the PageClient.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::canScrollView):
(WebKit::PageClientImpl::scrollView):

3:26 PM Changeset in webkit [158879] by timothy@apple.com
  • 4 edits in trunk/Source/WebInspectorUI

Fix up some sidebar switching details to make selections persist better.

Translate represented objects between sidebars so the same item can be reselected
as you switch between frames and main reources. Also fix some null checks that are
needed on selectedSidebarPanel.

https://bugs.webkit.org/show_bug.cgi?id=124001

Reviewed by Joseph Pecoraro.

  • UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.treeElementForRepresentedObject): Added. Translate a Frame
representedObject into a main resource representedObject.

  • UserInterface/Main.js:

(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar): Null check selectedSidebarPanel.
(WebInspector._updateNavigationSidebarForCurrentContentView): Fix a logic error to match other code.
allowedNavigationSidebarPanels.length needs to have a length before using contains.
(WebInspector._contentBrowserCurrentContentViewDidChange): Null check selectedSidebarPanel.

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject): Translate a main resource
representedObject into a Frame representedObject.

3:25 PM Changeset in webkit [158878] by Chris Fleizach
  • 23 edits in branches/safari-537.73-branch/LayoutTests

AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Unreviewed.

A number of the rebaselines from the original merge must have failed to apply.
This rebaselines those tests that are failing with the new expected results.

  • fullscreen/full-screen-crash-offsetLeft-expected.txt:
  • fullscreen/full-screen-no-style-sharing-expected.txt:
  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/video-controls-drag-expected.txt:
  • fullscreen/video-controls-override-expected.txt:
  • fullscreen/video-controls-timeline-expected.txt:
  • fullscreen/video-cursor-auto-hide-expected.txt:
  • fullscreen/video-specified-size-expected.txt:
  • media/media-initialTime-expected.txt:
  • media/media-startTime-expected.txt:
  • media/media-volume-slider-rendered-below-expected.txt:
  • media/media-volume-slider-rendered-normal-expected.txt:
  • media/track/track-cue-mutable-text-expected.txt:
  • media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
  • media/video-controls-fullscreen-volume-expected.txt:
  • media/video-controls-toggling-expected.txt:
  • media/video-controls-visible-exiting-fullscreen-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
3:16 PM Changeset in webkit [158877] by rniwa@webkit.org
  • 6 edits in trunk

DOMTokenList::add can add duplicated values if arguments had duplicated values
https://bugs.webkit.org/show_bug.cgi?id=123962

Reviewed by Benjamin Poulain.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/bd3822ad4ae3fc5d8f89f433a7bf04f697334305

In case we do element.classList.add('a', 'a') we need to ensure that we do not add the same token twice.
See http://dom.spec.whatwg.org/#dom-domtokenlist-add

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::add): Make sure filtered tokens are unique among themselves.

LayoutTests:

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:
3:01 PM Changeset in webkit [158876] by Chris Fleizach
  • 2 edits in trunk/Tools

Modify email order list for James Craig so his primary email is first.

  • Scripts/webkitpy/common/config/contributors.json:
2:19 PM Changeset in webkit [158875] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Reproducible crash when using Map (affects Web Inspector)
https://bugs.webkit.org/show_bug.cgi?id=123940

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Trivial fix. Once again we get bitten by attempting to be clever when
growing while adding entries to indexing maps.

Now we simply do a find(), and then add() _after_ we've ensured there is
sufficient space in the MapData list.

  • runtime/MapData.cpp:

(JSC::MapData::add):

LayoutTests:

Add testcases

  • js/map-grow-with-holes-expected.txt: Added.
  • js/map-grow-with-holes.html: Added.
  • js/script-tests/map-grow-with-holes.js: Added.

(get map):

2:08 PM Changeset in webkit [158874] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Remove npr.org specific hack in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=123859

Reviewed by Jer Noble.

Remove the site specific hack added in r57820, it is no longer necessary.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_dispatchingCanPlayEvent.
(HTMLMediaElement::play): Don't special case npr.org.

  • html/HTMLMediaElement.h:
1:56 PM Changeset in webkit [158873] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Attempt to fix the 32-bit build. Virtual thunks seem to have different
symbol names between 32- and 64-bit.

  • WebCore.exp.in:
1:54 PM Changeset in webkit [158872] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't repaint the view when the web process crashes
https://bugs.webkit.org/show_bug.cgi?id=124013

Reviewed by Dan Bernstein.

It's up to each individual port to decide whether the view should be repainted when the web process crashes.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):

1:51 PM Changeset in webkit [158871] by Michał Pakuła vel Rutka
  • 2 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

Unreviewed EFL gardening

Remove failure test expectations from passing tests.

  • platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/fast/repaint/caret-with-transformation-expected.png: Added.
  • platform/efl/fast/repaint/caret-with-transformation-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt.
1:47 PM Changeset in webkit [158870] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in HTMLMediaElement::contextDestroyed
https://bugs.webkit.org/show_bug.cgi?id=123963

Reviewed by Eric Carlson.

Merge https://chromium.googlesource.com/chromium/blink/+/177999cdb34b707465670f0feff723922939f278

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

1:43 PM Changeset in webkit [158869] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Crash at com.apple.WebCore: -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:] + 2084
https://bugs.webkit.org/show_bug.cgi?id=124012

Reviewed by Eric Carlson.

The value of the 'duration' key is a NSConcreteValue wrapping a CMTime, not a NSNumber.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

1:39 PM Changeset in webkit [158868] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash when submitting form in a document with null encoding
https://bugs.webkit.org/show_bug.cgi?id=123975

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/bba01a7fff09e3053ada96ababac2a6e4261fe5f

The CString object which is passed to normalizeLineEndingsToCRLF() can be
a null string. It is created in FormDataList::appendString(), and it
produces a null CString if FormDataList::m_encoding is a null encoding.

Test: fast/forms/form-submit-in-image-document.html

  • platform/text/LineEnding.cpp:

(internalNormalizeLineEndingsToCRLF):

LayoutTests:

  • fast/forms/form-submit-in-image-document-expected.txt: Added.
  • fast/forms/form-submit-in-image-document.html: Added.
1:37 PM Changeset in webkit [158867] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

Use std::function for all policy continuation functions
https://bugs.webkit.org/show_bug.cgi?id=124011

Reviewed by Sam Weinig.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::responseReceived):

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadPostRequest):

  • loader/PolicyCallback.cpp:

(WebCore::PolicyCallback::clear):
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::clearRequest):
(WebCore::PolicyCallback::cancel):

  • loader/PolicyCallback.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):

  • loader/PolicyChecker.h:
1:30 PM Changeset in webkit [158866] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Gtk] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123954

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.

Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.

With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'

  • gtk/jhbuild.modules:
12:49 PM Changeset in webkit [158865] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Use SQLite journal mode WAL (WriteAheadLogging)
https://bugs.webkit.org/show_bug.cgi?id=124009

Reviewed by Anders Carlsson.

WriteAheadLogging journalling is better than the traditional rollback model.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open): Use a PRAGMA to set journal_mode to WAL.

12:26 PM Changeset in webkit [158864] by commit-queue@webkit.org
  • 19 edits in trunk/LayoutTests

[GStreamer] Fix in-band track tests after r158743
https://bugs.webkit.org/show_bug.cgi?id=124007

Add a new line to a bunch of tests to match changes made in r158743.

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Eric Carlson.

  • media/track/audio/audio-track-mkv-vorbis-language-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-addtrack-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-kind-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-language-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-mode-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-style-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt:
  • media/track/in-band/track-in-band-mkv-chapters-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-addtrack-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-kind-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-language-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-mode-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-style-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt:
  • media/track/video/video-track-mkv-theora-language-expected.txt:
  • media/track/video/video-track-mkv-theora-selected-expected.txt:
12:19 PM Changeset in webkit [158863] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Report error on unknown template class usage.
https://bugs.webkit.org/show_bug.cgi?id=123096

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-07
Reviewed by Darin Adler.

Report error when template class is not found in the dictionary.

  • Scripts/webkit2/messages.py:

(class_template_headers):
(class_template_headers.template):

12:17 PM Changeset in webkit [158862] by mark.lam@apple.com
  • 19 edits in trunk/Source

Cosmetic: rename xxxId to xxxID for ScriptId, SourceId, and BreakpointId.
https://bugs.webkit.org/show_bug.cgi?id=123945.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):

  • debugger/DebuggerCallFrame.h:

Source/WebCore:

No new tests.

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionDetails):

  • bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::sourceID):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::pauseIfNeeded):

  • bindings/js/ScriptDebugServer.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::compileScript):
(WebCore::InspectorDebuggerAgent::runScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):
(WebCore::InspectorDebuggerAgent::reset):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/ScriptDebugListener.h:

Source/WebKit/mac:

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::exception):

12:11 PM Changeset in webkit [158861] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk

Avoid invalid cairo matrix when drawing surfaces too small
https://bugs.webkit.org/show_bug.cgi?id=123810

Drawing surfaces too small makes inverse matrix with values too big,
when this happen, cairo context is not valid anymore and it stops to draw anything.

Patch by Cidorvan Leite <cidorvan.leite@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.

Test: fast/canvas/drawImage-with-small-values.html

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):

11:45 AM Changeset in webkit [158860] by Antti Koivisto
  • 9 edits
    2 adds in trunk

Simple line layout crashes with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=124002

Source/WebCore:

Reviewed by Simon Fraser.

Don't use simple line layout for flows using SVG fonts. They crash if kerning is enabled.

Test: fast/text/svg-font-simple-line-crash.html

  • platform/graphics/Font.h:

(WebCore::Font::isSVGFont):

Add isSVGFont() so callers don't need to go via primaryFont().

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::constructTextRun):

  • rendering/RenderBlock.cpp:

(WebCore::constructTextRunInternal):

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Disallow SVG fonts.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::constructTextRun):
(WebCore::SVGTextMetrics::SVGTextMetrics):

  • rendering/svg/SVGTextRunRenderingContext.h:


Get rid of the abstract textRunNeedsRenderingContext in favor of just testing isSVGFont().

LayoutTests:

Reviewed by Simon Fraser.

  • fast/text/svg-font-simple-line-crash-expected.txt: Added.
  • fast/text/svg-font-simple-line-crash.html: Added.
11:34 AM Changeset in webkit [158859] by Simon Fraser
  • 12 edits in trunk/Source/WebCore

Allow customization of the contentsScale of TileController tiles
https://bugs.webkit.org/show_bug.cgi?id=124004

Reviewed by Tim Horton.

On some platorms, zooming out on pages with TiledBacking compositing
layers can cause very high memory use, because the TiledBacking retains
the original page scale while the zoom is in flight, but can be asked
to cover a large area.

Make it possible to reduce memory use in this case by allowing RenderLayerCompositor
to provide an additional scale factor for newly created tiles. Platforms can
then customize this to create low-res tiles when necessary.

  • WebCore.exp.in:
  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::contentsScaleMultiplierForNewTiles):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerContentsScaleMultiplierForNewTiles):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerContentsScaleMultiplierForNewTiles):

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
(WebCore::TileController::setScale):
(WebCore::TileController::createTileLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentsScaleMultiplierForNewTiles):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles):

  • rendering/RenderLayerCompositor.h:
11:33 AM Changeset in webkit [158858] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
https://bugs.webkit.org/show_bug.cgi?id=124006

Rubber stamped by Mark Hahnenberg.

Changed the push() calls to pop().

  • jit/ThunkGenerators.cpp:

(JSC::returnFromJavaScript):

11:23 AM Changeset in webkit [158857] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC)
https://bugs.webkit.org/show_bug.cgi?id=123998

Reviewed by Mark Lam.

Dead code removal. Passing esp as the first "C" argument to a JavaScript
function is no longer needed.

  • jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

11:04 AM Changeset in webkit [158856] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Win build fix after r158855; wrap shapeInfoForFloat() in an ENABLE(CSS_SHAPES) guard.

  • rendering/FloatingObjects.cpp:
10:11 AM Changeset in webkit [158855] by Bem Jones-Bey
  • 6 edits in trunk/Source/WebCore

Refactor logical left/right offset for line methods
https://bugs.webkit.org/show_bug.cgi?id=123898

Reviewed by David Hyatt.

Simplify the logical left/right offset for line methods and their
implementation, including the ComputeFloatOffsetAdapter. This also
reduces the number of line offset methods in RenderBlock.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetAdapter::offset): Add a method to return

the offset instead of using a confusing out parameter.

(WebCore::::shapeOffset): Method to return the offset modified by the

shape delta. Moving the computation to this method allowed for
simplification of the users of ComputeFloatOffsetAdapter.

(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat): Added this

method so that ShapeOutsideFloatOffsetMode isn't needed. Returns the
offset based on the float margin box.

(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat): Ditto.
(WebCore::FloatingObjects::logicalLeftOffset): This now only returns

the offset based on the shape's contour.

(WebCore::FloatingObjects::logicalRightOffset): Ditto.
(WebCore::::heightRemaining): Rename to properly follow the getter

naming convention.

  • rendering/FloatingObjects.h:
  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine): Update to remove

use of ShapeOutsideFloatOffsetMode and heightRemaining.

(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalRightFloatOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine): Ditto.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::logicalLeftOffsetForPositioningFloat):

Positioning a float is the only case where the float margin box
should be used, and also the only case where heightRemaining is
needed. This handles that case.

(WebCore::RenderBlockFlow::logicalRightOffsetForPositioningFloat):

Ditto.

(WebCore::RenderBlockFlow::computeLogicalLocationForFloat): Update to

use logical(Left|Right)OffsetForPositioningFloatOnLine.

(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine): Update to

remove use for ShapeOutsideFloatOffsetMode and heightRemaining.

(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine): Ditto.

  • rendering/RenderBlockFlow.h:
10:05 AM Changeset in webkit [158854] by Alexandru Chiculita
  • 6 edits
    2 adds in trunk

Web Inspector: CSS Regions: Removing a content node of a ContentFlow from the DOM will send a 0 nodeId
https://bugs.webkit.org/show_bug.cgi?id=123577

Source/WebCore:

Reviewed by Timothy Hatcher.

Test: inspector-protocol/model/content-flow-content-removal.html

Do not send unregister events for the content nodes of a flow when the element is not part of the DOM
anymore. We already send an unbind event, so the inspector is already notified that the node was removed.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):

Source/WebInspectorUI:

Reviewed by Timothy Hatcher.

Fixed the content node removal from the content flow.

  • UserInterface/ContentFlowTreeContentView.js:
  • UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload): Registered all the content nodes
in the _contentNodesToFlowsMap.
(WebInspector.DOMTreeManager.prototype._unbind): Added call to _removeContentNodeFromFlowIfNeeded.
(WebInspector.DOMTreeManager.prototype._removeContentNodeFromFlowIfNeeded): Called from _unbind to check
and remove a node from it's parent content flow if needed.
(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):

LayoutTests:

Reviewed by Timothy Hatcher.

Added test to check that the notification that an element was removed from the ContentFlow is handled
correctly in the WebInspector even if the element is not part of the DOM anymore.

  • inspector-protocol/model/content-flow-content-removal-expected.txt: Added.
  • inspector-protocol/model/content-flow-content-removal.html: Added.
9:58 AM Changeset in webkit [158853] by jer.noble@apple.com
  • 13 edits
    27 adds in trunk

[MSE] Add mock MediaSource classes for testing.
https://bugs.webkit.org/show_bug.cgi?id=123322

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/media-source/media-source-addsourcebuffer.html

media/media-source/media-source-append-buffer.html
media/media-source/media-source-canplaythrough.html
media/media-source/media-source-closed.html
media/media-source/media-source-play.html
media/media-source/media-source-track-enabled.html
media/media-source/media-source-tracks.html

Add mock implementation of platform MediaSource classes, allowing ports to test the
MediaSource API without having a platform implementation.

The MockMediaSource will support a byteformat defined in MockBox.h: a simple box-style media
format with an initialization segment containing a number of tracks, followed by a list of
samples.

Add a means to insert a new media engine factory at runtime, so the internals object can add
a MockMediaSourceMediaPlayer:

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayerFactorySupport::callRegisterMediaEngine):

  • platform/graphics/MediaPlayer.h:
  • testing/Internals.cpp:

(WebCore::Internals::initializeMockMediaSource):

  • testing/Internals.h:
  • testing/Internals.idl:

For non-media-source supporting media engines, fail immediately when asked to load a media
source, so that the MockMediaSourceMediaPlayer will be instantiated as a fall-back:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):

Add new files to the project:

  • WebCore.xcodeproj/project.pbxproj:
  • Source/WebCore/WebCore.exp.in:

Update the MediaSource implementation:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::monitorSourceBuffers): Add a link to the spec.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::buffered): Ditto.
(WebCore::SourceBuffer::setTimestampOffset): Ditto.
(WebCore::SourceBuffer::validateInitializationSegment): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Ditto. Also,

bring the implementation up to date with part of the spec.

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Remove "Predicate" from

SampleIsRandomAccessPredicate.

Add utility classes to parse and represent the bytestream supported by the MockMediaSource:

  • platform/mock/mediasource/MockBox.cpp: Added.

(WebCore::MockBox::MockBox):
(WebCore::MockBox::peekType):
(WebCore::MockBox::peekLength):
(WebCore::MockTrackBox::MockTrackBox):
(WebCore::MockTrackBox::type):
(WebCore::MockInitializationBox::MockInitializationBox):
(WebCore::MockInitializationBox::type):
(WebCore::MockSampleBox::MockSampleBox):
(WebCore::MockSampleBox::type):

  • platform/mock/mediasource/MockBox.h: Added.

(WebCore::MockBox::length):
(WebCore::MockBox::type):
(WebCore::MockTrackBox::trackID):
(WebCore::MockTrackBox::codec):
(WebCore::MockTrackBox::kind):
(WebCore::MockInitializationBox::duration):
(WebCore::MockInitializationBox::tracks):
(WebCore::MockSampleBox::presentationTimestamp):
(WebCore::MockSampleBox::decodeTimestamp):
(WebCore::MockSampleBox::duration):
(WebCore::MockSampleBox::trackID):
(WebCore::MockSampleBox::flags):
(WebCore::MockSampleBox::isSync):

Add a MediaPlayerPrivate implementation which uses MockMediaSource:

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp: Added.

(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):
(WebCore::MockMediaPlayerMediaSource::create):
(WebCore::mimeTypeCache):
(WebCore::MockMediaPlayerMediaSource::getSupportedTypes):
(WebCore::MockMediaPlayerMediaSource::supportsType):
(WebCore::MockMediaPlayerMediaSource::MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::~MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::load):
(WebCore::MockMediaPlayerMediaSource::cancelLoad):
(WebCore::MockMediaPlayerMediaSource::play):
(WebCore::MockMediaPlayerMediaSource::pause):
(WebCore::MockMediaPlayerMediaSource::naturalSize):
(WebCore::MockMediaPlayerMediaSource::hasVideo):
(WebCore::MockMediaPlayerMediaSource::hasAudio):
(WebCore::MockMediaPlayerMediaSource::setVisible):
(WebCore::MockMediaPlayerMediaSource::seeking):
(WebCore::MockMediaPlayerMediaSource::paused):
(WebCore::MockMediaPlayerMediaSource::networkState):
(WebCore::MockMediaPlayerMediaSource::readyState):
(WebCore::MockMediaPlayerMediaSource::buffered):
(WebCore::MockMediaPlayerMediaSource::didLoadingProgress):
(WebCore::MockMediaPlayerMediaSource::setSize):
(WebCore::MockMediaPlayerMediaSource::paint):
(WebCore::MockMediaPlayerMediaSource::currentTimeDouble):
(WebCore::MockMediaPlayerMediaSource::durationDouble):
(WebCore::MockMediaPlayerMediaSource::seekDouble):
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):
(WebCore::MockMediaPlayerMediaSource::updateDuration):
(WebCore::MockMediaPlayerMediaSource::setReadyState):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h: Added.

Add a mock implementation of MediaSourcePrivate, which uses MockSourceBuffer:

  • platform/mock/mediasource/MockMediaSourcePrivate.cpp: Added.

(WebCore::MockMediaSourcePrivate::create):
(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::~MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::addSourceBuffer):
(WebCore::MockMediaSourcePrivate::removeSourceBuffer):
(WebCore::MockMediaSourcePrivate::duration):
(WebCore::MockMediaSourcePrivate::setDuration):
(WebCore::MockMediaSourcePrivate::markEndOfStream):
(WebCore::MockMediaSourcePrivate::unmarkEndOfStream):
(WebCore::MockMediaSourcePrivate::readyState):
(WebCore::MockMediaSourcePrivate::setReadyState):
(WebCore::MockMediaSourcePrivate::sourceBufferPrivateDidChangeActiveState):
(WebCore::MockSourceBufferPrivateHasAudio):
(WebCore::MockMediaSourcePrivate::hasAudio):
(WebCore::MockSourceBufferPrivateHasVideo):
(WebCore::MockMediaSourcePrivate::hasVideo):

  • platform/mock/mediasource/MockMediaSourcePrivate.h: Added.

(WebCore::MockMediaSourcePrivate::activeSourceBuffers):
(WebCore::MockMediaSourcePrivate::player):

Add a mock implementation of SourceBufferPrivate, which uses MockBoxes to parse the
bytestream provided by SourceBuffer:

  • platform/mock/mediasource/MockSourceBufferPrivate.cpp: Added.

(WebCore::MockMediaSample::create):
(WebCore::MockMediaSample::~MockMediaSample):
(WebCore::MockMediaSample::MockMediaSample):
(WebCore::MockMediaSample::platformSample):
(WebCore::MockMediaDescription::create):
(WebCore::MockMediaDescription::~MockMediaDescription):
(WebCore::MockMediaDescription::MockMediaDescription):
(WebCore::MockSourceBufferPrivate::create):
(WebCore::MockSourceBufferPrivate::MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::~MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::setClient):
(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::didReceiveInitializationSegment):
(WebCore::MockSourceBufferPrivate::didReceiveSample):
(WebCore::MockSourceBufferPrivate::abort):
(WebCore::MockSourceBufferPrivate::removedFromMediaSource):
(WebCore::MockSourceBufferPrivate::readyState):
(WebCore::MockSourceBufferPrivate::setReadyState):
(WebCore::MockSourceBufferPrivate::hasVideo):
(WebCore::MockSourceBufferPrivate::hasAudio):

  • platform/mock/mediasource/MockSourceBufferPrivate.h: Added.

Create mock implementations of AudioTrackPrivate, VideoTrackPrivate, and TextTrackPrivate
which wrap the MockTrackBox class:

  • platform/mock/mediasource/MockTracks.cpp: Added.
  • platform/mock/mediasource/MockTracks.h: Added.

(WebCore::MockAudioTrackPrivate::create):
(WebCore::MockAudioTrackPrivate::~MockAudioTrackPrivate):
(WebCore::MockAudioTrackPrivate::id):
(WebCore::MockAudioTrackPrivate::MockAudioTrackPrivate):
(WebCore::MockTextTrackPrivate::create):
(WebCore::MockTextTrackPrivate::~MockTextTrackPrivate):
(WebCore::MockTextTrackPrivate::id):
(WebCore::MockTextTrackPrivate::MockTextTrackPrivate):
(WebCore::MockVideoTrackPrivate::create):
(WebCore::MockVideoTrackPrivate::~MockVideoTrackPrivate):
(WebCore::MockVideoTrackPrivate::id):
(WebCore::MockVideoTrackPrivate::MockVideoTrackPrivate):

LayoutTests:

  • media/media-source/media-source-addsourcebuffer-expected.txt: Added.
  • media/media-source/media-source-addsourcebuffer.html: Added.
  • media/media-source/media-source-append-buffer-expected.txt: Added.
  • media/media-source/media-source-append-buffer.html: Added.
  • media/media-source/media-source-canplaythrough-expected.txt: Added.
  • media/media-source/media-source-canplaythrough.html: Added.
  • media/media-source/media-source-closed-expected.txt: Added.
  • media/media-source/media-source-closed.html: Added.
  • media/media-source/media-source-play-expected.txt: Added.
  • media/media-source/media-source-play.html: Added.
  • media/media-source/mock-media-source.js: Added.
  • media/video-test.js:
9:56 AM Changeset in webkit [158852] by Samuel White
  • 4 edits
    2 adds in trunk

AX: DRT AccessibilityUIElement::isFocused methods should be finished.
https://bugs.webkit.org/show_bug.cgi?id=123774

Reviewed by Chris Fleizach.

Tools:

Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isFocused):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::isFocused):

LayoutTests:

Added Mac platform test so we can validate our AccessibilityUIElement convenience method expectations.

  • platform/mac/accessibility/test-convenience-methods-expected.txt: Added.
  • platform/mac/accessibility/test-convenience-methods.html: Added.
9:17 AM Changeset in webkit [158851] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Removed retrieveQMakespecVar function
https://bugs.webkit.org/show_bug.cgi?id=123996

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitdirs.pm:
9:11 AM Changeset in webkit [158850] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Removed QMake related filters
https://bugs.webkit.org/show_bug.cgi?id=123992

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline):
(TestRebaselineExpectations.test_rebaseline_expectations):

9:08 AM WebInspectorCodingStyleGuide edited by Alexandru Chiculita
(diff)
8:21 AM Changeset in webkit [158849] by commit-queue@webkit.org
  • 34 edits
    2 moves in trunk/Source

Changing MediaStreamDescriptor to MediaStreamPrivate
https://bugs.webkit.org/show_bug.cgi?id=123935

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-07
Reviewed by Eric Carlson.

Source/WebCore:

No new tests needed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::ended):
(WebCore::MediaStream::setEnded):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::removeRemoteSource):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::registerURL):
(WebCore::MediaStreamRegistry::unregisterURL):
(WebCore::MediaStreamRegistry::lookupMediaStreamPrivate):

  • Modules/mediastream/MediaStreamRegistry.h:
  • Modules/mediastream/MediaStreamTrack.cpp:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::callSuccessHandler):

  • Modules/mediastream/UserMediaRequest.h:
  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::loadResource):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::toWebMediaStreamPrivate):
(WebCore::MediaPlayerPrivate::lookupMediaStream):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
  • platform/mediastream/MediaStreamCenter.cpp:
  • platform/mediastream/MediaStreamCreationClient.h:
  • platform/mediastream/MediaStreamPrivate.cpp: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp.

(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::addSource):
(WebCore::MediaStreamPrivate::removeSource):
(WebCore::MediaStreamPrivate::addRemoteSource):
(WebCore::MediaStreamPrivate::removeRemoteSource):
(WebCore::MediaStreamPrivate::addRemoteTrack):
(WebCore::MediaStreamPrivate::removeRemoteTrack):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::setEnded):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):

  • platform/mediastream/MediaStreamPrivate.h: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.h.

(WebCore::MediaStreamPrivateClient::~MediaStreamPrivateClient):
(WebCore::MediaStreamPrivate::~MediaStreamPrivate):
(WebCore::MediaStreamPrivate::client):
(WebCore::MediaStreamPrivate::setClient):
(WebCore::MediaStreamPrivate::id):
(WebCore::MediaStreamPrivate::numberOfAudioSources):
(WebCore::MediaStreamPrivate::audioSources):
(WebCore::MediaStreamPrivate::numberOfVideoSources):
(WebCore::MediaStreamPrivate::videoSources):
(WebCore::MediaStreamPrivate::numberOfAudioTracks):
(WebCore::MediaStreamPrivate::audioTracks):
(WebCore::MediaStreamPrivate::numberOfVideoTracks):
(WebCore::MediaStreamPrivate::videoTracks):
(WebCore::MediaStreamPrivate::ended):

  • platform/mediastream/MediaStreamSource.cpp:
  • platform/mediastream/MediaStreamSource.h:
  • platform/mediastream/RTCPeerConnectionHandler.h:
  • platform/mediastream/RTCPeerConnectionHandlerClient.h:
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
  • platform/mediastream/mac/MediaStreamCenterMac.cpp:

(WebCore::MediaStreamCenterMac::createMediaStream):

  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::createMediaStream):

  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::addStream):
(WebCore::RTCPeerConnectionHandlerMock::removeStream):

  • platform/mock/RTCPeerConnectionHandlerMock.h:

Source/WebKit/blackberry:

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::toMediaStreamPrivate):
(WebCore::WebUserMediaRequestClientImpl::requestSucceeded):

7:18 AM Changeset in webkit [158848] by mario@webkit.org
  • 92 edits in trunk

[GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise
https://bugs.webkit.org/show_bug.cgi?id=50619

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-07
Reviewed by Martin Robinson.

Source/WebCore:

Implemented the OPENTYPE_VERTICAL feature for the GTK+ port. It resolves
the 90 degrees rotation problem of CJK characters when displaying
vertical text.

New tests are not required as the existing tests for vertical text will
work properly now.

  • GNUmakefile.list.am: Added OpenTypeVerticalData.cpp and

OpenTypeVerticalData.h to platformgtk_sources.

  • PlatformEfl.cmake: Added OpenTypeVerticalData.cpp.
  • PlatformGTK.cmake: Added OpenTypeVerticalData.cpp.
  • platform/graphics/FontCache.cpp: Originally the HashMap for

OpenTypeVerticalData was designed with FontFileKey as integer in the
Chromium port, which was an unique number provided by Skia. Since other
ports use FontFileKey as string, new generic hash functions had to be
implemented instead of using the specific ones for integers.
(WebCore::FontVerticalDataCacheKeyHash::hash): New hash function for
HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyHash::equal): New function for
comparing hash indexes in the HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyTraits::emptyValue): New function for
giving an empty FontFileKey.
(WebCore::FontVerticalDataCacheKeyTraits::constructDeletedValue): New
function to create a FontFileKey for deleted values.
(WebCore::FontVerticalDataCacheKeyTraits::isDeletedValue): New function
to check if a HashMap entry is available.

  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Added font
orientation as a parameter to the FontPlatformData constructor.

  • platform/graphics/freetype/FontPlatformData.h: Added m_orientation to

store the font orientation and m_horizontalOrientationMatrix to store
the Cairo matrix for horizontal orientation, which can be restored in
setOrientation().
(WebCore::FontPlatformData::FontPlatformData): Added font orientation as
a parameter.
(WebCore::FontPlatformData::orientation): Implemented this function
based on m_orientation.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Added new

helper function rotateCairoMatrixForVerticalOrientation() to rotate the
Cairo matrix in case of vertical orientation.
(WebCore::FontPlatformData::FontPlatformData): Initialized
m_orientation.
(WebCore::FontPlatformData::operator=): Added m_orientation and
m_horizontalOrientationMatrix to the assignment operator.
(WebCore::FontPlatformData::operator==): Added m_orientation to the
equal operator.
(WebCore::FontPlatformData::initializeWithFontFace): Rotated and
translated fonts if orientation is vertical. Also stored the horizontal
Cairo matrix.
(WebCore::FontPlatformData::verticalData): Returned the vertical data
from the font cache.
(WebCore::FontPlatformData::openTypeTable): Loaded the font table into
a shared buffer.
(WebCore::FontPlatformData::setOrientation): Replaced the scaled font
data by rotating fonts according to the new orientation.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformInit): Set the glyph's height and
width according to the font orientation. It also sets EM.
(WebCore::SimpleFontData::platformCreateScaledFontData): Added
orientation to the FontPlatformData constructor.
(WebCore::SimpleFontData::platformWidthForGlyph): Returned the glyph's
width according the orientation.

  • platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

(WebCore::CairoGetGlyphWidthAndExtents): Obtained the character advance
and extents according to the font orientation.

Source/Platform:

Added WebCore/platform/graphics/opentype to the include path.

  • GNUmakefile.am:

Source/WTF:

Enabled OPENTYPE_VERTICAL by default on GTK+ and EFL ports, which are
currently using Freetype.

  • wtf/Platform.h:

Source/WebKit:

Added WebCore/platform/graphics/opentype to the include path.

  • PlatformEfl.cmake:

Source/WebKit2:

Added WebCore/platform/graphics/opentype to the include path.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:

LayoutTests:

Updated existing test results that uses vertical texts.

  • platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Updated.
  • platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.png: Updated.
  • platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Updated.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Updated.
  • platform/gtk/fast/dynamic/text-combine-expected.png: Updated.
  • platform/gtk/fast/dynamic/text-combine-expected.txt: Updated.
  • platform/gtk/fast/html/details-writing-mode-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Updated.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Updated.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Updated.
  • platform/gtk/fast/ruby/base-shorter-than-text-expected.png: Updated.
  • platform/gtk/fast/ruby/base-shorter-than-text-expected.txt: Updated.
  • platform/gtk/fast/text/decorations-with-text-combine-expected.png: Updated.
  • platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Updated.
  • platform/gtk/fast/text/emphasis-combined-text-expected.png: Updated.
  • platform/gtk/fast/text/emphasis-combined-text-expected.txt: Updated.
  • platform/gtk/fast/text/emphasis-vertical-expected.png: Updated.
  • platform/gtk/fast/text/emphasis-vertical-expected.txt: Updated.
  • platform/gtk/fast/text/international/text-combine-image-test-expected.png: Updated.
  • platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Updated.
  • platform/gtk/fast/text/international/text-spliced-font-expected.png: Updated.
  • platform/gtk/fast/text/international/text-spliced-font-expected.txt: Updated.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.png: Updated.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.png: Updated.
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/gtk/fast/text/orientation-sideways-expected.png: Updated.
  • platform/gtk/fast/text/orientation-sideways-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Updated.
  • platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/border-vertical-lr-expected.png: Updated.
  • platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.png: Updated.
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/broken-ideographic-font-expected.png: Updated.
  • platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.png: Updated.
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-selection-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-text-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-selection-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/text-orientation-basic-expected.png: Updated.
  • platform/gtk/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Updated.
  • platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.png: Updated.
  • platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.png: Updated.
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt: Updated.
5:43 AM Changeset in webkit [158847] by mario@webkit.org
  • 1 edit
    2 moves
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening. Expectations are finally the same for
WK1 and WK2 so, besides needing a rebaseline, we now can share them.

  • platform/gtk-wk1/accessibility/table-attributes-expected.txt: Removed.
  • platform/gtk-wk1/accessibility/table-sections-expected.txt: Removed.
  • platform/gtk/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-attributes-expected.txt.
  • platform/gtk/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-sections-expected.txt.
4:51 AM Changeset in webkit [158846] by gyuyoung.kim@samsung.com
  • 1 edit
    26 adds in trunk/LayoutTests

Unreviewed, Add new baselines to EFL port since r158743 as well as do rebaseline.
Because r158743 didn't update EFL port.

  • platform/efl/fullscreen/video-controls-override-expected.txt: Added.
  • platform/efl/http/tests/media/video-cookie-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
  • platform/efl/media/context-menu-actions-expected.txt: Added.
  • platform/efl/media/media-can-play-flac-audio-expected.txt: Added.
  • platform/efl/media/media-can-play-webm-expected.txt: Added.
  • platform/efl/media/media-volume-slider-rendered-below-expected.txt: Added.
  • platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Added.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Added.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Added.
  • platform/efl/media/track/track-cue-mutable-text-expected.txt: Added.
  • platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Added.
  • platform/efl/media/track/track-language-preference-expected.txt: Added.
  • platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Added.
  • platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Added.
  • platform/efl/media/video-controls-fullscreen-volume-expected.txt: Added.
  • platform/efl/media/video-controls-toggling-expected.txt: Added.
4:46 AM Changeset in webkit [158845] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Efl] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123947

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Gyuyoung Kim.

Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.

With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'

  • efl/jhbuild.modules:
4:29 AM Changeset in webkit [158844] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source

[AX] Use toAccessibilityRenderObject() instead of using static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123986

Reviewed by Mario Sanchez Prada.

Though there is toAccessibilityRenderObject(), static_cast<> are being used by many places.
To use toAccessibilityRenderObject() is more helpful to find bad type cast.

No new tests, no behavior changes.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetElement):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

4:10 AM Changeset in webkit [158843] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

[AX] Use toAccessibilityTable() instead of using manual static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123982

Reviewed by Mario Sanchez Prada.

Though there is toAccessibilityTable(), static_cast<> are being used by many places.
We need to use toAccessibilityTable().

No new tests, no behavior changes.

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::addChildren):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(cell):
(cellAtIndex):
(webkitAccessibleTableGetIndexAt):
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper tableParent]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

4:04 AM Changeset in webkit [158842] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

Use tighter InlineBox subtypes in some places.
<https://webkit.org/b/123980>

RenderLineBreak and RenderBox line box wrappers are always going to
be InlineElementBox, so codify this with tighter types. Also made
the various positionLine() functions take tighter reference types.

All the casting to renderer-appropriate box types happens inside of
RenderBlockFlow::computeBlockDirectionPositionsForLine() and
propagates from there.

Reviewed by Antti Koivisto.

3:12 AM Changeset in webkit [158841] by mario@webkit.org
  • 10 edits
    4 adds in trunk

AX: [ATK] Video and audio elements are not properly exposed
https://bugs.webkit.org/show_bug.cgi?id=123894

Reviewed by Chris Fleizach.

Source/WebCore:

Expose <audio> and <video> elements with ATK_ROLE_EMBEDDED, so we
can identify them properly from ATK/AT-SPI based ATs.

Tests: platform/gtk/accessibility/media-controls-panel-title.html

platform/efl/accessibility/media-emits-object-replacement.html
platform/gtk/accessibility/media-emits-object-replacement.html

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole): Add the new mapping.

Tools:

Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.

LayoutTests:

Updated tests and expectations according to the new behavior.

Updated failing test to reflect the new reality.

  • platform/gtk/accessibility/media-element-expected.txt: Updated.

Extended GTK specific test by adding an <audio> element besides
the <video> one and printing all the information about those
related to their media nature.

  • platform/gtk/accessibility/media-controls-panel-title.html: Extended.
  • platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated.

Added new tests for GTK and EFL to check that the replaced
character is being properly emitter for both <video> and <audio>
elements. Inspired in the ones in platform/mac, we use a different
approach here to print the test since we don't have the
textMarkerRangeForElement functionality in our DRT/WKTR, and
because we expect embedded objects to show up in the results in a
GTK/EFL specific way (using the "<obj>" string).

  • platform/efl/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/efl/accessibility/media-emits-object-replacement.html: Added.
  • platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/gtk/accessibility/media-emits-object-replacement.html: Added.

Removed tests with failure expectations that are now passing.

  • platform/gtk/TestExpectations: Removed passing tests.
3:04 AM Changeset in webkit [158840] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash in BitmapImage::destroyDecodedData()
https://bugs.webkit.org/show_bug.cgi?id=116494

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

Merge from https://chromium.googlesource.com/chromium/blink/+/6b6887bf53068f8537908e501fdc7317ad2c6d86

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):

2:53 AM Changeset in webkit [158839] by svillar@igalia.com
  • 6 edits in trunk

[CSS Grid Layout] CSSParser should reject <track-list> without a <track-size>
https://bugs.webkit.org/show_bug.cgi?id=118025

Reviewed by Andreas Kling.

Source/WebCore:

From Blink r152914 by <jchaffraix@chromium.org>

Make sure that we parse at least 1 <track-size> inside each
<track-list>. The old parser code allowed track-lists exclusively
made of <track-name>. The way it was implemented eases the future
addition of parsing for the repeat() function.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackList): ASSERT if we don't find any
<track-size> now that we detect their absence in the parser.

LayoutTests:

Added a new test that verifies that <track-list> exclusively made
of <track-name> are not supported.

  • fast/css-grid-layout/named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/named-grid-line-get-set.html:
2:45 AM Changeset in webkit [158838] by svillar@igalia.com
  • 13 edits in trunk

[CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
https://bugs.webkit.org/show_bug.cgi?id=115401

Reviewed by Andreas Kling.

Source/WebCore:

From Blink r150585 by <jchaffraix@chromium.org>

Added support for 'inherit' and 'initial' special values to
grid-auto-{columns|rows} and grid-definition-{columns|rows}.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): Resolve 'initial' and 'inherit'.

  • rendering/style/RenderStyle.h: Added initialNamedGrid{Column|Row}Lines().
  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData): Initialize m_namedGrid{Column|Row}Lines.

LayoutTests:

Added 'inherit' and 'initial' testing support to existing tests.

  • fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-get-set.html:
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit): New helper function.
(testInitial): Ditto.

  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit): New helper function.
(testInitial): Ditto.

2:36 AM Changeset in webkit [158837] by Michał Pakuła vel Rutka
  • 30 edits in trunk/LayoutTests

Unreviewed gardening

Adjust test expectations after r158743.

  • fullscreen/video-controls-override-expected.txt:
  • http/tests/media/video-cookie-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt:
  • media/context-menu-actions-expected.txt:
  • media/media-can-play-flac-audio-expected.txt:
  • media/media-volume-slider-rendered-below-expected.txt:
  • media/media-volume-slider-rendered-normal-expected.txt:
  • media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt:
  • media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt:
  • media/track/track-cue-mutable-text-expected.txt:
  • media/track/track-cue-rendering-mode-changed-expected.txt:
  • media/track/track-language-preference-expected.txt:
  • media/track/video/video-track-mkv-theora-addtrack-expected.txt:
  • media/video-controls-fullscreen-volume-expected.txt:
  • media/video-controls-toggling-expected.txt:
  • media/video-controls-visible-exiting-fullscreen-expected.txt:
  • media/video-seek-past-end-paused-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
  • platform/efl/media/media-can-play-webm-expected.txt:
2:27 AM Changeset in webkit [158836] by akling@apple.com
  • 1 edit
    35 moves
    35 deletes in trunk/LayoutTests

Optimize baselines: svg/batik

Unreviewed; run "webkit-patch optimize-baselines svg/batik"

  • platform/gtk/svg/batik/filters/feTile-expected.txt: Removed.
  • platform/gtk/svg/batik/filters/filterRegions-expected.txt: Removed.
  • platform/gtk/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/gradientLimit-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt: Removed.
  • platform/gtk/svg/batik/text/smallFonts-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textAnchor-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textAnchor2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textAnchor3-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textDecoration-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textDecoration2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textEffect2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textLayout-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textLayout2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textLength-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPath-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPath2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textPCDATA-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textPosition-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textProperties-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textProperties2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textStyles-expected.txt: Removed.
  • platform/gtk/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt: Removed.
  • platform/gtk/svg/batik/text/xmlSpace-expected.txt: Removed.
  • svg/batik/filters/feTile-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/feTile-expected.txt.
  • svg/batik/filters/filterRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/filterRegions-expected.txt.
  • svg/batik/masking/maskRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/masking/maskRegions-expected.txt.
  • svg/batik/paints/gradientLimit-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/gradientLimit-expected.txt.
  • svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt.
  • svg/batik/paints/patternRegionA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegionA-expected.txt.
  • svg/batik/paints/patternRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-expected.txt.
  • svg/batik/paints/patternRegions-positioned-objects-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt.
  • svg/batik/text/longTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/longTextOnPath-expected.txt.
  • svg/batik/text/smallFonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/smallFonts-expected.txt.
  • svg/batik/text/textAnchor-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor-expected.txt.
  • svg/batik/text/textAnchor2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor2-expected.txt.
  • svg/batik/text/textAnchor3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor3-expected.txt.
  • svg/batik/text/textDecoration-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration-expected.txt.
  • svg/batik/text/textDecoration2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration2-expected.txt.
  • svg/batik/text/textEffect-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect-expected.txt.
  • svg/batik/text/textEffect2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect2-expected.txt.
  • svg/batik/text/textEffect3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect3-expected.txt.
  • svg/batik/text/textFeatures-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textFeatures-expected.txt.
  • svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt.
  • svg/batik/text/textLayout-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout-expected.txt.
  • svg/batik/text/textLayout2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout2-expected.txt.
  • svg/batik/text/textLength-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLength-expected.txt.
  • svg/batik/text/textOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath-expected.txt.
  • svg/batik/text/textOnPath2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath2-expected.txt.
  • svg/batik/text/textOnPath3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath3-expected.txt.
  • svg/batik/text/textOnPathSpaces-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPathSpaces-expected.txt.
  • svg/batik/text/textPCDATA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPCDATA-expected.txt.
  • svg/batik/text/textPosition-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPosition-expected.txt.
  • svg/batik/text/textProperties-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties-expected.txt.
  • svg/batik/text/textProperties2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties2-expected.txt.
  • svg/batik/text/textStyles-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textStyles-expected.txt.
  • svg/batik/text/verticalText-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalText-expected.txt.
  • svg/batik/text/verticalTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalTextOnPath-expected.txt.
  • svg/batik/text/xmlSpace-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/xmlSpace-expected.txt.
2:18 AM Changeset in webkit [158835] by akling@apple.com
  • 7 edits
    6 copies
    10 moves
    1 add
    22 deletes in trunk/LayoutTests

Optimize baselines: svg/as-background-image

Unreviewed; run "webkit-patch optimize-baselines svg/as-background-image"

  • platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/win-future/svg/as-background-image/svg-as-background-1-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-1-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-2-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-2-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-3-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-3-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-4-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-4-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-5-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-5-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-6-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-6-expected.txt.
  • svg/as-background-image/animated-svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt.
  • svg/as-background-image/svg-as-background-1-expected.txt:
  • svg/as-background-image/svg-as-background-2-expected.txt:
  • svg/as-background-image/svg-as-background-3-expected.txt:
  • svg/as-background-image/svg-as-background-4-expected.txt:
  • svg/as-background-image/svg-as-background-5-expected.txt:
  • svg/as-background-image/svg-as-background-6-expected.txt:
  • svg/as-background-image/svg-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.png.
  • svg/as-background-image/svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.txt.
  • svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt.
  • svg/as-background-image/svg-as-background-with-viewBox-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.png.
  • svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt.
  • svg/as-background-image/svg-as-tiled-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.png.
  • svg/as-background-image/svg-as-tiled-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt.
  • svg/as-background-image/svg-width-100p-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.png.
  • svg/as-background-image/svg-width-100p-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt.
2:12 AM Changeset in webkit [158834] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Clean up BidiRun a little bit.
<https://webkit.org/b/123964>

Make BidiRun's member variables private and add accessors for them.
In doing so, codify the following:

  • BidiRun always has a corresponding RenderObject.
  • The inline box is never cleared after being set.

Reviewed by Antti Koivisto.

2:11 AM Changeset in webkit [158833] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

More CSSPrimitiveValue constructors should return PassRef.
<https://webkit.org/b/123953>

Make some more CSSPrimitiveValue constructor helpers (that are
known to never return null) return PassRef instead of PassRefPtr.

Reviewed by Antti Koivisto.

2:08 AM Changeset in webkit [158832] by akling@apple.com
  • 17 edits in trunk/Source/WebCore

Generate type casting helpers for line boxes and use them.
<https://webkit.org/b/123976>

Semi-automatically generate the full set of toFooInlineBox()
helpers with macros instead of having them (partially) hand-coded.
Replaced static_casts with the new helpers across the codebase.

Also made the isFooInlineBox() overrides private since they should
never be called when the type is already known.

Reviewed by Antti Koivisto.

2:04 AM Changeset in webkit [158831] by Chris Fleizach
  • 425 edits
    4 adds in branches/safari-537.73-branch

Merge r158743

Source/WebCore:

2013-11-06 Chris Fleizach <Chris Fleizach>


AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Reviewed by Mario Sanchez Prada.

Video and audio elements don't appear as distinct objects in the AX hierarchy,
nor are they treated as replaceable objects when emitting the text. We should
treat these characters like attachments, for one. On the Mac platform, we should
also identify them with special subroles.

Tests: platform/mac/accessibility/media-emits-object-replacement.html

platform/mac/accessibility/media-role-descriptions.html


  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isGenericFocusableElement):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

LayoutTests:

2013-11-06 Chris Fleizach <Chris Fleizach>

AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Reviewed by Mario Sanchez Prada.

Making media elements int replaced elements has the unfortunate side-effect
of causing a new line to be inserted into any test using a <video> or <audio> tag.

  • compositing/video/video-poster-expected.txt:
  • compositing/video/video-reflection-expected.txt:
  • compositing/visibility/visibility-simple-video-layer-expected.txt:
  • fast/css/first-letter-block-form-controls-crash-expected.txt:
  • fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt:
  • fast/forms/form-associated-element-crash3-expected.txt:
  • fast/multicol/renderer-positioned-assert-crash-expected.txt:
  • fast/regions/full-screen-video-from-region-expected.txt:
  • fast/runin/nonblock-runin-expected.txt:
  • fast/spatial-navigation/snav-media-elements-expected.txt:
  • fullscreen/full-screen-crash-offsetLeft-expected.txt:
  • fullscreen/full-screen-no-style-sharing-expected.txt:
  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/video-controls-drag-expected.txt:
  • fullscreen/video-controls-timeline-expected.txt:
  • fullscreen/video-cursor-auto-hide-expected.txt:
  • fullscreen/video-specified-size-expected.txt:
  • http/tests/appcache/video-expected.txt:
  • http/tests/media/pdf-served-as-pdf-expected.txt:
  • http/tests/media/reload-after-dialog-expected.txt:
  • http/tests/media/text-served-as-text-expected.txt:
  • http/tests/media/video-accept-encoding-expected.txt:
  • http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
  • http/tests/media/video-cross-site-expected.txt:
  • http/tests/media/video-error-abort-expected.txt:
  • http/tests/media/video-load-suspend-expected.txt:
  • http/tests/media/video-play-progress-expected.txt:
  • http/tests/media/video-play-stall-before-meta-data-expected.txt:
  • http/tests/media/video-preload-expected.txt:
  • http/tests/media/video-redirect-expected.txt:
  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-served-as-text-expected.txt:
  • http/tests/media/video-throttled-load-metadata-expected.txt:
  • http/tests/misc/empty-urls-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-src-from-remote-expected.txt:
  • http/tests/security/text-track-crossorigin-expected.txt:
  • media/W3C/audio/events/event_canplay-expected.txt:
  • media/W3C/audio/events/event_canplay_manual-expected.txt:
  • media/W3C/audio/events/event_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/audio/events/event_loadeddata-expected.txt:
  • media/W3C/audio/events/event_loadeddata_manual-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/audio/events/event_loadstart-expected.txt:
  • media/W3C/audio/events/event_loadstart_manual-expected.txt:
  • media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_order_canplay_playing-expected.txt:
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/audio/events/event_pause_manual-expected.txt:
  • media/W3C/audio/events/event_play-expected.txt:
  • media/W3C/audio/events/event_play_manual-expected.txt:
  • media/W3C/audio/events/event_playing-expected.txt:
  • media/W3C/audio/events/event_playing_manual-expected.txt:
  • media/W3C/audio/events/event_progress-expected.txt:
  • media/W3C/audio/events/event_progress_manual-expected.txt:
  • media/W3C/audio/events/event_timeupdate-expected.txt:
  • media/W3C/audio/events/event_timeupdate_manual-expected.txt:
  • media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/audio/paused/paused_false_during_play-expected.txt:
  • media/W3C/audio/paused/paused_true_during_pause-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
  • media/W3C/video/error/error_null-expected.txt:
  • media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
  • media/W3C/video/error/error_property_exists-expected.txt:
  • media/W3C/video/events/event_canplay-expected.txt:
  • media/W3C/video/events/event_canplay_manual-expected.txt:
  • media/W3C/video/events/event_canplaythrough-expected.txt:
  • media/W3C/video/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/video/events/event_loadeddata-expected.txt:
  • media/W3C/video/events/event_loadeddata_manual-expected.txt:
  • media/W3C/video/events/event_loadedmetadata-expected.txt:
  • media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/video/events/event_loadstart-expected.txt:
  • media/W3C/video/events/event_loadstart_manual-expected.txt:
  • media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/video/events/event_order_canplay_playing-expected.txt:
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/video/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/video/events/event_pause_manual-expected.txt:
  • media/W3C/video/events/event_play-expected.txt:
  • media/W3C/video/events/event_play_manual-expected.txt:
  • media/W3C/video/events/event_playing-expected.txt:
  • media/W3C/video/events/event_playing_manual-expected.txt:
  • media/W3C/video/events/event_progress-expected.txt:
  • media/W3C/video/events/event_progress_manual-expected.txt:
  • media/W3C/video/events/event_timeupdate-expected.txt:
  • media/W3C/video/events/event_timeupdate_manual-expected.txt:
  • media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/video/networkState/networkState_during_progress-expected.txt:
  • media/W3C/video/networkState/networkState_initial-expected.txt:
  • media/W3C/video/networkState/networkState_property_exists-expected.txt:
  • media/W3C/video/paused/paused_false_during_play-expected.txt:
  • media/W3C/video/paused/paused_true_during_pause-expected.txt:
  • media/W3C/video/preload/preload_property_exists-expected.txt:
  • media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_empty-expected.txt:
  • media/W3C/video/preload/preload_reflects_metadata-expected.txt:
  • media/W3C/video/preload/preload_reflects_no_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_none-expected.txt:
  • media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/video/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/readyState/readyState_initial-expected.txt:
  • media/W3C/video/readyState/readyState_property_exists-expected.txt:
  • media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
  • media/W3C/video/src/src_reflects_no_value-expected.txt:
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg4-supported-expected.txt:
  • media/audio-only-video-intrinsic-size-expected.txt:
  • media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
  • media/before-load-member-access-expected.txt:
  • media/broken-video-expected.txt:
  • media/constructors-expected.txt:
  • media/controls-css-overload-expected.txt:
  • media/controls-drag-timebar-expected.txt:
  • media/controls-layout-direction-expected.txt:
  • media/controls-right-click-on-timebar-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • media/event-attributes-expected.txt:
  • media/media-blocked-by-beforeload-expected.txt:
  • media/media-blocked-by-willsendrequest-expected.txt:
  • media/media-can-play-mpeg-audio-expected.txt:
  • media/media-can-play-mpeg4-video-expected.txt:
  • media/media-can-play-octet-stream-expected.txt:
  • media/media-can-play-type-expected.txt:
  • media/media-can-play-wav-audio-expected.txt:
  • media/media-captions-expected.txt:
  • media/media-captions-no-controls-expected.txt:
  • media/media-controller-expected.txt:
  • media/media-controller-playback-expected.txt:
  • media/media-controller-playbackrate-expected.txt:
  • media/media-controller-time-clamp-expected.txt:
  • media/media-controller-time-constant-expected.txt:
  • media/media-controller-time-expected.txt:
  • media/media-controller-timeupdate-expected.txt:
  • media/media-controller-unpause-expected.txt:
  • media/media-controls-invalid-url-expected.txt:
  • media/media-ended-expected.txt:
  • media/media-extension-with-fragment-expected.txt:
  • media/media-fragments/TC0001-expected.txt:
  • media/media-fragments/TC0002-expected.txt:
  • media/media-fragments/TC0003-expected.txt:
  • media/media-fragments/TC0004-expected.txt:
  • media/media-fragments/TC0005-expected.txt:
  • media/media-fragments/TC0006-expected.txt:
  • media/media-fragments/TC0009-expected.txt:
  • media/media-fragments/TC0011-expected.txt:
  • media/media-fragments/TC0012-expected.txt:
  • media/media-fragments/TC0014-expected.txt:
  • media/media-fragments/TC0015-expected.txt:
  • media/media-fragments/TC0017-expected.txt:
  • media/media-fragments/TC0024-expected.txt:
  • media/media-fragments/TC0027-expected.txt:
  • media/media-fragments/TC0028-expected.txt:
  • media/media-fragments/TC0029-expected.txt:
  • media/media-fragments/TC0030-expected.txt:
  • media/media-fragments/TC0031-expected.txt:
  • media/media-fragments/TC0032-expected.txt:
  • media/media-fragments/TC0033-expected.txt:
  • media/media-fragments/TC0034-expected.txt:
  • media/media-fragments/TC0035-expected.txt:
  • media/media-fragments/TC0036-expected.txt:
  • media/media-fragments/TC0037-expected.txt:
  • media/media-fragments/TC0038-expected.txt:
  • media/media-fragments/TC0039-expected.txt:
  • media/media-fragments/TC0044-expected.txt:
  • media/media-fragments/TC0051-expected.txt:
  • media/media-fragments/TC0052-expected.txt:
  • media/media-fragments/TC0053-expected.txt:
  • media/media-fragments/TC0054-expected.txt:
  • media/media-fragments/TC0055-expected.txt:
  • media/media-fragments/TC0058-expected.txt:
  • media/media-fragments/TC0059-expected.txt:
  • media/media-fragments/TC0061-expected.txt:
  • media/media-fragments/TC0062-expected.txt:
  • media/media-fragments/TC0063-expected.txt:
  • media/media-fragments/TC0064-expected.txt:
  • media/media-fragments/TC0065-expected.txt:
  • media/media-fragments/TC0066-expected.txt:
  • media/media-fragments/TC0067-expected.txt:
  • media/media-fragments/TC0068-expected.txt:
  • media/media-fragments/TC0069-expected.txt:
  • media/media-fragments/TC0070-expected.txt:
  • media/media-fragments/TC0071-expected.txt:
  • media/media-fragments/TC0072-expected.txt:
  • media/media-fragments/TC0073-expected.txt:
  • media/media-fragments/TC0074-expected.txt:
  • media/media-fragments/TC0075-expected.txt:
  • media/media-fragments/TC0076-expected.txt:
  • media/media-fragments/TC0077-expected.txt:
  • media/media-fragments/TC0078-expected.txt:
  • media/media-fragments/TC0079-expected.txt:
  • media/media-fragments/TC0080-expected.txt:
  • media/media-fragments/TC0081-expected.txt:
  • media/media-fragments/TC0082-expected.txt:
  • media/media-fragments/TC0083-expected.txt:
  • media/media-fragments/TC0084-expected.txt:
  • media/media-fragments/TC0085-expected.txt:
  • media/media-fragments/TC0086-expected.txt:
  • media/media-fragments/TC0087-expected.txt:
  • media/media-fragments/TC0088-expected.txt:
  • media/media-fragments/TC0089-expected.txt:
  • media/media-fragments/TC0090-expected.txt:
  • media/media-fragments/TC0091-expected.txt:
  • media/media-fragments/TC0092-expected.txt:
  • media/media-fragments/TC0093-expected.txt:
  • media/media-fragments/TC0094-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-preload-no-delay-loadevent-expected.txt:
  • media/no-autoplay-with-user-gesture-requirement-expected.txt:
  • media/nodesFromRect-shadowContent-expected.txt:
  • media/restore-from-page-cache-expected.txt:
  • media/sources-fallback-codecs-expected.txt:
  • media/track/add-and-remove-track-expected.txt:
  • media/track/audio-track-expected.txt:
  • media/track/opera/interfaces/TextTrack/addCue-expected.txt:
  • media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/align-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/id-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/track-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
  • media/track/text-track-cue-is-reachable-expected.txt:
  • media/track/text-track-is-reachable-expected.txt:
  • media/track/track-active-cues-expected.txt:
  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-track-expected.txt:
  • media/track/track-addtrack-kind-expected.txt:
  • media/track/track-automatic-subtitles-expected.txt:
  • media/track/track-css-all-cues-expected.txt:
  • media/track/track-css-cue-lifetime-expected.txt:
  • media/track/track-css-matching-default-expected.txt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching-lang-expected.txt:
  • media/track/track-css-matching-timestamps-expected.txt:
  • media/track/track-css-property-whitelist-expected.txt:
  • media/track/track-css-user-override-expected.txt:
  • media/track/track-cue-container-rendering-position-expected.txt:
  • media/track/track-cue-empty-text-crash-expected.txt:
  • media/track/track-cue-inline-assertion-crash-expected.txt:
  • media/track/track-cue-mutable-expected.txt:
  • media/track/track-cue-mutable-fragment-expected.txt:
  • media/track/track-cue-negative-timestamp-expected.txt:
  • media/track/track-cue-nothing-to-render-expected.txt:
  • media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-empty-cue-crash-expected.txt:
  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering-on-resize-expected.txt:
  • media/track/track-cue-rendering-rtl-expected.txt:
  • media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
  • media/track/track-cue-rendering-with-padding-expected.txt:
  • media/track/track-cues-cuechange-expected.txt:
  • media/track/track-cues-enter-exit-expected.txt:
  • media/track/track-cues-missed-expected.txt:
  • media/track/track-cues-pause-on-exit-expected.txt:
  • media/track/track-cues-seeking-expected.txt:
  • media/track/track-cues-sorted-before-dispatch-expected.txt:
  • media/track/track-default-attribute-expected.txt:
  • media/track/track-disabled-addcue-expected.txt:
  • media/track/track-disabled-expected.txt:
  • media/track/track-element-load-event-expected.txt:
  • media/track/track-in-band-cues-added-once-expected.txt:
  • media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
  • media/track/track-in-band-expected.txt:
  • media/track/track-in-band-legacy-api-expected.txt:
  • media/track/track-in-band-style-expected.txt:
  • media/track/track-kind-expected.txt:
  • media/track/track-large-timestamp-expected.txt:
  • media/track/track-legacyapi-with-automatic-mode-expected.txt:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-long-captions-file-expected.txt:
  • media/track/track-mode-disabled-crash-expected.txt:
  • media/track/track-mode-expected.txt:
  • media/track/track-mode-not-changed-by-new-track-expected.txt:
  • media/track/track-mode-triggers-loading-expected.txt:
  • media/track/track-remove-active-cue-crash-expected.txt:
  • media/track/track-remove-by-setting-innerHTML-expected.txt:
  • media/track/track-remove-quickly-expected.txt:
  • media/track/track-text-track-cue-list-expected.txt:
  • media/track/track-texttracks-expected.txt:
  • media/track/track-webvtt-tc000-empty-expected.txt:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc010-no-timings-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc023-markup-expected.txt:
  • media/track/track-webvtt-tc024-timestamp-expected.txt:
  • media/track/track-webvtt-tc025-class-markup-expected.txt:
  • media/track/track-webvtt-tc026-voice-expected.txt:
  • media/track/track-webvtt-tc027-empty-cue-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/track/track-word-breaking-expected.txt:
  • media/track/tracklist-is-reachable-expected.txt:
  • media/track/video-track-expected.txt:
  • media/unsupported-rtsp-expected.txt:
  • media/unsupported-tracks-expected.txt:
  • media/video-append-source-expected.txt:
  • media/video-autoplay-expected.txt:
  • media/video-beforeload-remove-source-expected.txt:
  • media/video-buffered-expected.txt:
  • media/video-canvas-drawing-expected.txt:
  • media/video-canvas-drawing-output-expected.txt:
  • media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
  • media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-with-mutation-event-handler-expected.txt:
  • media/video-controls-zoomed-expected.txt:
  • media/video-currentTime-delay-expected.txt:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set2-expected.txt:
  • media/video-delay-load-event-expected.txt:
  • media/video-display-aspect-ratio-expected.txt:
  • media/video-dom-autoplay-expected.txt:
  • media/video-dom-preload-expected.txt:
  • media/video-dom-src-expected.txt:
  • media/video-duration-known-after-eos-expected.txt:
  • media/video-error-does-not-exist-expected.txt:
  • media/video-load-networkState-expected.txt:
  • media/video-load-preload-metadata-expected.txt:
  • media/video-load-preload-none-expected.txt:
  • media/video-load-readyState-expected.txt:
  • media/video-load-require-user-gesture-expected.txt:
  • media/video-loop-expected.txt:
  • media/video-mouse-focus-expected.txt:
  • media/video-muted-expected.txt:
  • media/video-no-autoplay-expected.txt:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-immediately-expected.txt:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-pause-events-expected.txt:
  • media/video-play-pause-exception-expected.txt:
  • media/video-play-require-user-gesture-expected.txt:
  • media/video-playbackrate-expected.txt:
  • media/video-played-collapse-expected.txt:
  • media/video-played-ranges-1-expected.txt:
  • media/video-played-reset-expected.txt:
  • media/video-plays-past-end-of-test-expected.txt:
  • media/video-poster-blocked-by-willsendrequest-expected.txt:
  • media/video-poster-delayed-expected.txt:
  • media/video-poster-expected.txt:
  • media/video-poster-scale-expected.txt:
  • media/video-preload-expected.txt:
  • media/video-replaces-poster-expected.txt:
  • media/video-reverse-play-duration-expected.txt:
  • media/video-seek-after-end-expected.txt:
  • media/video-seek-by-small-increment-expected.txt:
  • media/video-seek-multiple-expected.txt:
  • media/video-seek-no-src-exception-expected.txt:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seekable-expected.txt:
  • media/video-seeking-expected.txt:
  • media/video-set-rate-from-pause-expected.txt:
  • media/video-single-valid-source-expected.txt:
  • media/video-size-expected.txt:
  • media/video-source-error-expected.txt:
  • media/video-source-error-no-candidate-expected.txt:
  • media/video-source-expected.txt:
  • media/video-source-inserted-expected.txt:
  • media/video-source-load-expected.txt:
  • media/video-source-none-supported-expected.txt:
  • media/video-source-type-expected.txt:
  • media/video-src-blob-expected.txt:
  • media/video-src-change-expected.txt:
  • media/video-src-empty-expected.txt:
  • media/video-src-expected.txt:
  • media/video-src-invalid-poster-expected.txt:
  • media/video-src-invalid-remove-expected.txt:
  • media/video-src-none-expected.txt:
  • media/video-src-plus-source-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-set-expected.txt:
  • media/video-src-source-expected.txt:
  • media/video-timeupdate-during-playback-expected.txt:
  • media/video-timeupdate-reverse-play-expected.txt:
  • media/video-volume-expected.txt:
  • media/video-width-height-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/mac/accessibility/media-emits-object-replacement.html: Added.
  • platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
  • platform/mac/accessibility/media-role-descriptions.html: Added.
  • platform/mac/compositing/video/video-object-fit-expected.txt:
  • platform/mac/fullscreen/video-controls-override-expected.txt:
  • platform/mac/media/media-can-play-wav-audio-expected.txt:
  • platform/mac/media/media-can-play-webm-expected.txt:
  • platform/mac/media/video-seek-past-end-paused-expected.txt:
2:02 AM Changeset in webkit [158830] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build for architectures with 4 argument registers (broken since r158820).
https://bugs.webkit.org/show_bug.cgi?id=123969

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-07
Reviewed by Andreas Kling.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

1:32 AM Changeset in webkit [158829] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Simplify Attr by removing m_specified member variable and setter
https://bugs.webkit.org/show_bug.cgi?id=123965

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/597f44ec928e08820574728889adabc6d8ecd746

m_specified is always true in WebKit so simply return true in Attr::specified().

  • dom/Attr.cpp:

(WebCore::Attr::Attr):

  • dom/Attr.h:
  • dom/Document.cpp:

(WebCore::Document::adoptNode):

1:21 AM Changeset in webkit [158828] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Change git_commit_from_svn_revision() to work in a pure git checkout
https://bugs.webkit.org/show_bug.cgi?id=111668

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-07
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.git_commit_from_svn_revision):

12:05 AM Changeset in webkit [158827] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=123919

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/PageClientImpl.cpp: Remove takeFocus().
  • UIProcess/API/gtk/PageClientImpl.h: Remove takeFocus() and mark methods as OVERRIDE.
Note: See TracTimeline for information about the timeline view.