Timeline
Dec 19, 2013:
- 11:20 PM Changeset in webkit [160898] by
-
- 7 edits in trunk/Source/WebCore
REGRESSION: cnn.com will continue to reveal 1 px of overhang after rubber-banding
at the top
https://bugs.webkit.org/show_bug.cgi?id=126054
Reviewed by Simon Fraser.
This regression was caused by http://trac.webkit.org/changeset/160791 It turns out
that the line of code I removed was not always a no-op. In some instances, like on
cnn.com, it would ensure that our final scroll position after a rubber-band was
not something within the overhang area. It was still wrong in its assumption that
rubber-band is always bouncing back the spot it originated from. So this patch
continues to ignore the rubber-bands origin, and instead finds the nearest point
that is not in the overhang area, and scrolls to that point instead of the origin.
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::adjustScrollPositionToBoundsIfNecessary):
- platform/mac/ScrollAnimatorMac.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::adjustScrollPositionToBoundsIfNecessary):
- platform/mac/ScrollElasticityController.h:
- platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):
- 9:52 PM Changeset in webkit [160897] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Frontend Error when selecting Database folder in Resources Sidebar
https://bugs.webkit.org/show_bug.cgi?id=126029
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-19
Reviewed by Timothy Hatcher.
Treat the DatabaseHostTreeElement tree element like a folder. It pretty much
is a folder, but inherits from StorageTreeElement to share some code there.
- UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
- 8:01 PM Changeset in webkit [160896] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r160847): fast/events/overflowchanged-inside-selection-collapse-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=126037
Reviewed by Anders Carlsson.
Since overflowchanged event is now asynchronous, make the call to testRunner.notifyDone() also asynchronous.
- TestExpectations:
- fast/dynamic/paused-event-dispatch.html:
- 7:49 PM Changeset in webkit [160895] by
-
- 3 edits in trunk/Tools
check-webkit-style mistakenly flags assigning to a dereferenced pointer
https://bugs.webkit.org/show_bug.cgi?id=126041
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-19
Reviewed by Ryosuke Niwa.
When checking for lines like "Foo *bar;", check-webkit-style doesn't make
sure that there is a declaration. This patch makes sure that there is a
declaration in order to flag spacing around asterisks.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_pointer_reference_marker_location):
- 7:48 PM Changeset in webkit [160894] by
-
- 4 edits in trunk/Source/WebCore
Clarify the behavior of composited canvases
https://bugs.webkit.org/show_bug.cgi?id=126042
Reviewed by Tim Horton.
Different platforms composite 2D and 3D canvases in different ways.
"Accelerated 2D" canvases, and WebGL are always set as GraphicsLayer
contents.
"IOSurface" canvases (Mac and iOS-only) get a compositing layer, but
paint into it (because this is fast, and a convenient way to get
synchronization).
So make these behaviors explicit in RenderLayerBacking and RenderLayerCompositor.
No behavior changes on OS X, bug fix on iOS.
- rendering/RenderLayerBacking.cpp:
(WebCore::canvasCompositingStrategy):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::contentChanged):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):
- 7:33 PM Changeset in webkit [160893] by
-
- 41 edits10 adds in branches/jsCStack/Source/JavaScriptCore
FTL should be able to do call ICs
https://bugs.webkit.org/show_bug.cgi?id=125811
Reviewed by Geoffrey Garen.
Add Call/Construct inline caching to the FTL. That part is super easy.
But to make it possible for the FTL (which preserves system ABI callee-save registers
and expects calls to preserve them) to call into non-FTL JSC JITs (which don't preserve
any registers), we need to have some special thunks. That's most of the patch. In
particular, all JITCode's can now give you entrypoints with or without register
preservation and this may mean lazily creating wrapper thunks that preserve registers.
FTL OSR exit may involve exiting into a register restoration thunk and it may also
involve decoding FTL unwind info in order to figure out where registers were preserved.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::operator UnspecifiedBoolType*):
(JSC::MacroAssemblerCodeRef::operator UnspecifiedBoolType*):
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CallLinkInfo.h:
(JSC::CallLinkInfo::CallLinkInfo):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::jitCode):
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):
- ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfCall):
- ftl/FTLInlineCacheSize.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::initializeArityCheckEntrypoint):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):
- ftl/FTLJITCode.h:
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJSCall.cpp: Added.
(JSC::FTL::JSCall::JSCall):
(JSC::FTL::JSCall::emit):
(JSC::FTL::JSCall::link):
- ftl/FTLJSCall.h: Added.
(JSC::FTL::JSCall::stackmapID):
(JSC::FTL::JSCall::operator<):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compilePutById):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::callStackmap):
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLRegisterAtOffset.cpp: Added.
(JSC::FTL::RegisterAtOffset::dump):
- ftl/FTLRegisterAtOffset.h: Added.
(JSC::FTL::RegisterAtOffset::RegisterAtOffset):
(JSC::FTL::RegisterAtOffset::operator!):
(JSC::FTL::RegisterAtOffset::gpr):
(JSC::FTL::RegisterAtOffset::offset):
(JSC::FTL::RegisterAtOffset::operator==):
(JSC::FTL::RegisterAtOffset::operator<):
(JSC::FTL::RegisterAtOffset::getGPR):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Record::parse):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- ftl/FTLState.h:
- ftl/FTLUnwindInfo.cpp: Added.
(JSC::FTL::UnwindInfo::UnwindInfo):
(JSC::FTL::UnwindInfo::~UnwindInfo):
(JSC::FTL::UnwindInfo::parse):
(JSC::FTL::UnwindInfo::dump):
(JSC::FTL::UnwindInfo::find):
(JSC::FTL::UnwindInfo::indexOf):
- ftl/FTLUnwindInfo.h: Added.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCallSlowCase):
- jit/JITCode.cpp:
(JSC::JITCode::hostFunction):
(JSC::JITCodeWithCodeRef::JITCodeWithCodeRef):
(JSC::JITCodeWithCodeRef::~JITCodeWithCodeRef):
(JSC::JITCodeWithCodeRef::executableAddressAtOffset):
(JSC::JITCodeWithCodeRef::dataAddressAtOffset):
(JSC::JITCodeWithCodeRef::offsetOf):
(JSC::JITCodeWithCodeRef::size):
(JSC::JITCodeWithCodeRef::contains):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::~DirectJITCode):
(JSC::DirectJITCode::initializeCodeRef):
(JSC::DirectJITCode::ensureWrappers):
(JSC::DirectJITCode::addressForCall):
(JSC::NativeJITCode::NativeJITCode):
(JSC::NativeJITCode::~NativeJITCode):
(JSC::NativeJITCode::initializeCodeRef):
(JSC::NativeJITCode::addressForCall):
- jit/JITCode.h:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
(JSC::operationLinkFor):
(JSC::operationVirtualFor):
(JSC::operationLinkClosureCallFor):
- jit/RegisterPreservationWrapperGenerator.cpp: Added.
(JSC::registersToPreserve):
(JSC::registerPreservationOffset):
(JSC::generateWrapper):
(JSC::generateRegisterRestoration):
(JSC::registerRestorationThunkGenerator):
- jit/RegisterPreservationWrapperGenerator.h: Added.
- jit/Repatch.cpp:
(JSC::linkSlowFor):
(JSC::linkFor):
(JSC::linkClosureCall):
- jit/Repatch.h:
- jit/ThunkGenerators.cpp:
(JSC::linkForThunkGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkCallThatPreservesRegsThunkGenerator):
(JSC::linkConstructThatPreservesRegsThunkGenerator):
(JSC::linkClosureCallForThunkGenerator):
(JSC::linkClosureCallThunkGenerator):
(JSC::linkClosureCallThatPreservesRegsThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):
(JSC::virtualCallThatPreservesRegsThunkGenerator):
(JSC::virtualConstructThatPreservesRegsThunkGenerator):
- jit/ThunkGenerators.h:
(JSC::linkThunkGeneratorFor):
(JSC::linkClosureCallThunkGeneratorFor):
(JSC::virtualThunkGeneratorFor):
- llint/LLIntEntrypoint.cpp:
(JSC::LLInt::setFunctionEntrypoint):
(JSC::LLInt::setEvalEntrypoint):
(JSC::LLInt::setProgramEntrypoint):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::entryOSR):
(JSC::LLInt::setUpCall):
- llint/LowLevelInterpreter.asm:
- runtime/ArityCheckMode.h: Added.
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/Executable.cpp:
(JSC::ScriptExecutable::installCode):
- runtime/Executable.h:
(JSC::ExecutableBase::entrypointFor):
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor):
(JSC::NativeExecutable::finishCreation):
- runtime/RegisterPreservationMode.h: Added.
- 6:58 PM Changeset in webkit [160892] by
-
- 5 edits in trunk/Source
Versioning.
- 6:55 PM Changeset in webkit [160891] by
-
- 1 copy in tags/Safari-538.10
New Tag.
- 6:38 PM Changeset in webkit [160890] by
-
- 5 edits in branches/jsCStack/Source/JavaScriptCore
CStack: The JIT does not need a slow path stack check.
https://bugs.webkit.org/show_bug.cgi?id=126036.
Reviewed by Geoffrey Garen.
The JIT uses the C stack which is not growable. If we fail a stack
check in the function header, then a stack overflow is imminent, and
there's no need to redo the check in the slow path helper.
Hence, renamed operationStackCheck() to operationThrowStackOverflowError()
and change the JIT and DFG code to use this appropriately.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- 6:01 PM Changeset in webkit [160889] by
-
- 5 edits in branches/safari-537.74-branch/Source
Versioning
- 6:00 PM Changeset in webkit [160888] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception: NavigationSidebarPanel.js: TypeError: undefined is not a function
https://bugs.webkit.org/show_bug.cgi?id=126018
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-19
Reviewed by Timothy Hatcher.
ERROR: TypeError: undefined is not a function (evaluating 'representedObject.saveIdentityToCookie(candidateObjectCookie)')
There are some TreeElements (Folders, and the special Databases Folder)
which do not have a represented object, and would throw an exception
when trying to use saveIdentityToCookie.
We should always provide a saveIdentityToCookie when possible. So just
blacklist the tree element types we know do not have representedObjects,
and where we don't want to save identity. This will continue to throw
exceptions in the future for tree elements that don't have the save
function implemented, but should.
Note that even if a TreeElement is constructed with a null represented
object, it becomes an empty object (representedObject {}). - UserInterface/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
(WebInspector.NavigationSidebarPanel.prototype._isTreeElementWithoutRepresentedObject):
(WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):
- 5:59 PM Changeset in webkit [160887] by
-
- 9 edits in trunk/Source
Web Inspector: Add InspectorFrontendHost.debuggableType to let the frontend know it's backend is JavaScript or Web
https://bugs.webkit.org/show_bug.cgi?id=126016
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-19
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::listingForDebuggable):
- inspector/remote/RemoteInspectorConstants.h:
Include a debuggable type identifier in the debuggable listing,
so the remote frontend can know if it is debugging a Web Page
or JS Context.
Source/WebCore:
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::debuggableType):
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
Expose the debuggableType to the frontend. In WebCore it is always a "web" type.
Source/WebInspectorUI:
- UserInterface/LoadInspectorBackendCommands.js:
If the debuggable target is "web" load both JS and Web backend commands.
Otherwise, we only load the default, js backend commands.
- 5:55 PM Changeset in webkit [160886] by
-
- 1 copy in tags/Safari-537.74.2
New tag.
- 5:54 PM Changeset in webkit [160885] by
-
- 1 delete in tags/Safari-537.74.2
Deleting tag. The tag was copied incorrectly from http://svn.webkit.org/repository/webkit/tags/Safari-537.74.1.
- 5:48 PM Changeset in webkit [160884] by
-
- 1 copy in tags/Safari-537.74.2
New Tag.
- 5:45 PM Changeset in webkit [160883] by
-
- 5 edits in branches/safari-537.74-branch/Source
Versioning
- 5:41 PM Changeset in webkit [160882] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][iOS] Enable multiprocess by default
https://bugs.webkit.org/show_bug.cgi?id=126030
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-19
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup initWithInjectedBundleURL:]):
- 5:39 PM Changeset in webkit [160881] by
-
- 4 edits1 add in trunk/Source
Add an utility class to simplify generating function calls
https://bugs.webkit.org/show_bug.cgi?id=125972
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Split branchTest32 in two functions: test32AndSetFlags and branchOnFlags.
This is done to allow code where the flags are set, multiple operation that
do not modify the flags occur, then the flags are used.
This is used for function calls to test the return value while discarding the
return register.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::test32AndSetFlags):
(JSC::MacroAssemblerX86Common::branchOnFlags):
(JSC::MacroAssemblerX86Common::branchTest32):
Source/WebCore:
FunctionCall is a little helper class to make function calls from the JIT
in 3 or 4 lines.
FunctionCall takes a StackAllocator, a RegisterAllocator and a function pointer.
When the call is generated, the helper saves the registers as necessary, aligns
the stack, does the call, restores the stack, and restore the registers.
- cssjit/FunctionCall.h: Added.
(WebCore::FunctionCall::FunctionCall):
(WebCore::FunctionCall::setFunctionAddress):
(WebCore::FunctionCall::setFirstArgument):
(WebCore::FunctionCall::call):
(WebCore::FunctionCall::callAndBranchOnCondition): Most test functions used
with FunctionCall return a boolean. When the boolean is the sole purpose of the function
call, this provides an easy way to branch on the boolean without worrying about registers.
The return register is tested first, then all the saved registers are restored from the stack
(which can include the return register), finally the flags are used for a jump.
(WebCore::FunctionCall::prepareAndCall):
(WebCore::FunctionCall::cleanupPostCall):
(WebCore::FunctionCall::saveAllocatedRegisters):
(WebCore::FunctionCall::restoreAllocatedRegisters):
- WebCore.xcodeproj/project.pbxproj:
- cssjit/FunctionCall.h: Added.
(WebCore::FunctionCall::FunctionCall):
(WebCore::FunctionCall::setFunctionAddress):
(WebCore::FunctionCall::setFirstArgument):
(WebCore::FunctionCall::call):
(WebCore::FunctionCall::callAndBranchOnCondition):
(WebCore::FunctionCall::prepareAndCall):
(WebCore::FunctionCall::cleanupPostCall):
(WebCore::FunctionCall::saveAllocatedRegisters):
(WebCore::FunctionCall::restoreAllocatedRegisters):
- 5:18 PM Changeset in webkit [160880] by
-
- 4 edits in trunk/Source/WebCore
Begin stubbing out the KeyedDecoder class
https://bugs.webkit.org/show_bug.cgi?id=126031
Reviewed by Andreas Kling.
KeyedDecoder is going to be the new way to decode back forward trees.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::decodeBackForwardTree):
- history/HistoryItem.h:
- platform/KeyedCoding.h:
(WebCore::KeyedDecoder::~KeyedDecoder):
- 4:52 PM Changeset in webkit [160879] by
-
- 23 edits2 adds in trunk
DOM bindings should use thisValue for attributes
https://bugs.webkit.org/show_bug.cgi?id=126011
Reviewed by Antti Koivisto.
Source/WebCore:
Make all standard DOM attributes use the thisValue instead
of the slot object. This requires using a dynamic cast in
the attribute getters. Happily for normal uses this a single
indirect load and pointer compare, and we were already doing
it for many attributes.
Alas it's too expensive to do this on the window object still
due to the proxy indirection that intercepts global variable
access. I'll correct this in a follow on patch (bug 126013).
A number of custom getters have also been updated to use the
thisValue and full type checks.
This patch still leaves the index and generic named getters
on the slot based model as fixing these cases requires more
complicated changes.
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback):
(WebCore::cssPropertyGetterCallback):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginElementPropertyGetter):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::jsTestCustomNamedGetterConstructor):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::jsTestEventTargetConstructor):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::jsTestExceptionName):
(WebCore::jsTestExceptionConstructor):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::jsTestGenerateIsReachableConstructor):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::jsTestInterfaceConstructorImplementsStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorImplementsStaticAttr):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
(WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceConstructor):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerConstructor):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::jsTestNamedConstructorConstructor):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::jsTestNodeConstructor):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr):
(WebCore::jsTestObjConstructorStaticStringAttr):
(WebCore::jsTestObjConstructorTestSubObj):
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::jsTestObjEnumAttr):
(WebCore::jsTestObjByteAttr):
(WebCore::jsTestObjOctetAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjLongAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjAnyAttribute):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjStrictFloat):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::jsTestObjAttribute):
(WebCore::jsTestObjAttributeWithReservedEnumType):
(WebCore::jsTestObjConstructor):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::jsTestOverloadedConstructorsConstructor):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsImmutableSerializedScriptValue):
(WebCore::jsTestTypedefsConstructorTestSubObj):
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsAttrWithSetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithSetterException):
(WebCore::jsTestTypedefsConstructor):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::jsattributeReadonly):
(WebCore::jsattributeConstructor):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::jsreadonlyConstructor):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::lengthGetter):
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::lengthGetter):
LayoutTests:
- js/dom/dom-attributes-on-mismatch-type.html: Added.
- js/dom/dom-attributes-on-mismatch-type-expected.txt: Added.
- 4:49 PM Changeset in webkit [160878] by
-
- 10 edits in trunk/Source/JavaScriptCore
Put write barriers in the right places in the baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=125975
Reviewed by Filip Pizlo.
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
(JSC::JIT::emitArrayProfilingSite):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_enter):
(JSC::JIT::emitSlow_op_enter):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_enter):
(JSC::JIT::emitSlow_op_enter):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitPutGlobalProperty):
(JSC::JIT::emitPutGlobalVar):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_init_global_const):
(JSC::JIT::checkMarkWord):
(JSC::JIT::emitWriteBarrier):
(JSC::JIT::privateCompilePutByVal):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitPutGlobalProperty):
(JSC::JIT::emitPutGlobalVar):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_init_global_const):
- jit/Repatch.cpp:
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::repatchPutByID):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
- 4:48 PM Changeset in webkit [160877] by
-
- 11 edits in trunk/Source
Remove WebFilterEvaluator wrappers from WebKitSystemInterface
https://bugs.webkit.org/show_bug.cgi?id=126028
Reviewed by Anders Carlsson.
Source/WebCore:
It's overkill to pipe access to WebFilterEvaluator through
WebKitSystemInterface. Instead, include WebFilterEvaluator.h when it
exists and re-declare WebFilterEvaluator when it doesn't.
WebKitSystemInterface used to soft-link WebContentAnalysis.framework
since OS X 10.7 didn't contain this framework. Since we no longer
support 10.7, we can now directly link against the framework.
- Configurations/WebCore.xcconfig: Add /System/Library/PrivateHeaders
to the system framework search path at both compile and link time so
that we can find WebContentAnalysis.framework.
- WebCore.exp.in: Don't export removed symbols.
- WebCore.xcodeproj/project.pbxproj: Added WebContentAnalysis.framework
to the 'Link Binary With Libraries' build phase.
- platform/mac/ContentFilterMac.mm: Included WebFilterEvaluator.h when
it exists and re-declared WebFilterEvaluator when it doesn't.
(WebCore::ContentFilter::ContentFilter): Directly called a method on
m_platformContentFilter rather than going through WKSI.
(WebCore::ContentFilter::isEnabled): Ditto.
(WebCore::ContentFilter::addData): Ditto.
(WebCore::ContentFilter::finishedAddingData): Ditto.
(WebCore::ContentFilter::needsMoreData): Ditto.
(WebCore::ContentFilter::didBlockData): Ditto.
- platform/mac/WebCoreSystemInterface.h: Removed function pointers for
calling into WKSI.
- platform/mac/WebCoreSystemInterface.mm: Ditto.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Don't INIT() removed function pointers.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Don't INIT() removed function pointers.
- 4:42 PM Changeset in webkit [160876] by
-
- 5 edits in trunk
Implement ArrayBuffer.isView
https://bugs.webkit.org/show_bug.cgi?id=126004
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Test coverage in webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSArrayBufferConstructor::finishCreation): Add 'isView' to object constructor.
(JSC::arrayBufferFuncIsView): New method.
LayoutTests:
- webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
Correct test for 'isView' to actually check for 'isView' function.
- 4:39 PM Changeset in webkit [160875] by
-
- 2 edits in trunk/LayoutTests
Layout Test plugins/destroy-during-npp-new.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=126027
- plugins/destroy-during-npp-new.html: Streamlined the test a little bit to see
what changes, if anything. There should be no effect on what is tested.
- 4:38 PM Changeset in webkit [160874] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix call operationStackCheck to check the proper stack
https://bugs.webkit.org/show_bug.cgi?id=126026
Unreviewed change suggested by Geoff Garen post landing.
Change from using codeBlock->stackPointerOffset to using codeBlock->frameRegisterCount()
to caclulate the needed stack space.
- jit/JITOperations.cpp:
- 4:23 PM Changeset in webkit [160873] by
-
- 4 edits in branches/safari-537.74-branch/Source/WebCore
Merge r159463: <rdar://problems/15701094>
- 4:22 PM Changeset in webkit [160872] by
-
- 5 edits1 delete in trunk/Source/WebKit2
Remove WKContentViewPrivate.h, WKContentView.h is private now
https://bugs.webkit.org/show_bug.cgi?id=125981
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-19
Reviewed by Dan Bernstein.
There is no need for a separate header, WKContentView has become an implementation
detail of WKView.
- UIProcess/API/ios/WKContentView.h:
- UIProcess/API/ios/WKContentViewInternal.h:
- UIProcess/API/ios/WKContentViewPrivate.h: Removed.
- UIProcess/API/ios/WKView.mm:
- 4:22 PM Changeset in webkit [160871] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix call operationStackCheck to check the proper stack
https://bugs.webkit.org/show_bug.cgi?id=126026
Reviewed by Mark Lam.
Changed operationStackCheck() to check the appropriate stack based on the
compile flag ENABLE(LLINT_CLOOP).
- jit/JITOperations.cpp:
- 4:14 PM Changeset in webkit [160870] by
-
- 2 edits in branches/safari-537.74-branch/LayoutTests
Merge r160826: <rdar://problems/15701133>
- 4:09 PM Changeset in webkit [160869] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix broken C loop LLINT build.
https://bugs.webkit.org/show_bug.cgi?id=126024.
Reviewed by Oliver Hunt.
- runtime/VM.h:
- 4:05 PM Changeset in webkit [160868] by
-
- 2 edits in branches/safari-537.74-branch/Source/WebCore
Merge r160791: <rdar://problems/15694289>
- 3:37 PM Changeset in webkit [160867] by
-
- 6 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix call eval in baseline JIT
https://bugs.webkit.org/show_bug.cgi?id=126020
Reviewed by Geoffrey Garen.
Added code to properly set and restore the stack pointer around the call to
operationCallEval. Due to the state the stack is in when the exception check
in the call is done, I changed callOperationWithCallFrameRollbackOnException()
to be callOperationNoExceptionCheck() and check for an exception after the
caller's stack has been restored. Changed operationCallEval() to take a second
argument for the execCallee, given that we always pass the caller's exec as the
first arguement.
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITInlines.h:
(JSC::JIT::callOperationNoExceptionCheck):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- 3:32 PM Changeset in webkit [160866] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r160515): Frequent assertion failures on printing/print-close-crash.html
https://bugs.webkit.org/show_bug.cgi?id=126014
Rolled out r160515 while Chris is investigating. Added FIXME comments in other
places where we use this pattern.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
- 3:24 PM Changeset in webkit [160865] by
-
- 1 edit2 adds in trunk/LayoutTests
Test that text-decoration-skip: ink is the same as regular underlines if no descenders
https://bugs.webkit.org/show_bug.cgi?id=125985
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-19
Reviewed by Simon Fraser.
If there are no descenders in the underlined text, using the text-decoration-skip: ink
CSS property should behave as if it wasn't specified (and the underline is a normal one)
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders-expected.html: Added.
- fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink-no-descenders.html: Added.
- 3:23 PM Changeset in webkit [160864] by
-
- 3 edits in trunk/Tools
check-webkit-style marks rvalue references as violations
https://bugs.webkit.org/show_bug.cgi?id=126000
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-19
Reviewed by Ryosuke Niwa.
Previously, check-webkit-style was making sure that any line with "&&" had
spaces around it. However, we can now legitimately use "&&" without a previous
space when declaring an rvalue reference. This patch relaxes this check.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_for_binary_ops):
- 3:22 PM Changeset in webkit [160863] by
-
- 3 edits in trunk/Tools
check-webkit-style marks auto return types for functions as violations
https://bugs.webkit.org/show_bug.cgi?id=125999
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-12-19
Reviewed by Ryosuke Niwa.
If a function declaration ends with a "->" followed by a non whitespace
string, don't mark as an invalid "{" on its own line
- Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_brace_at_begin_of_line):
- 3:14 PM Changeset in webkit [160862] by
-
- 3 edits in trunk/Source/WebKit2
Add WebKit2 API for clearing the back-forward list
https://bugs.webkit.org/show_bug.cgi?id=126005
Patch by Ricky Mondello <Ricky Mondello> on 2013-12-19
Reviewed by Anders Carlsson.
- UIProcess/API/C/WKBackForwardListRef.cpp:
(WKBackForwardListClear): Call through to the back-forward list's
clear().
- UIProcess/API/C/WKBackForwardListRef.h: Declare new API.
- 2:41 PM Changeset in webkit [160861] by
-
- 5 edits in trunk/Source/WebKit2
One more URTBF to make GTK build happy after r160853.
- UIProcess/API/gtk/WebKitDownloadClient.cpp:
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle):
- UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:
(webkitResponsePolicyDecisionCreate):
- UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h:
- 2:08 PM Changeset in webkit [160860] by
-
- 2 edits in trunk/Source/WebKit2
URTBF for GTK after r160853.
- GNUmakefile.list.am:
- 2:07 PM Changeset in webkit [160859] by
-
- 2 edits in trunk/Tools
[WinCairo] More GStreamer preparations.
Unreviewed.
- WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
- 2:04 PM Changeset in webkit [160858] by
-
- 2 edits in trunk/Tools
Add Apple Mavericks perf bot.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 1:55 PM Changeset in webkit [160857] by
-
- 3 edits2 copies in branches/safari-537.74-branch
Merge r160819: <rdar://problems/15701133>
- 1:52 PM Changeset in webkit [160856] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix attempt after r160853
- CMakeLists.txt: Change WebURLResponse.cpp to APIURLResponse.cpp.
- 1:38 PM Changeset in webkit [160855] by
-
- 6 edits in trunk
Final preparations for GStreamer on Windows.
https://bugs.webkit.org/show_bug.cgi?id=125958
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-19
Reviewed by Benjamin Poulain.
Source/WTF:
- WTF.vcxproj/WTFDebugWinCairo.props:
- WTF.vcxproj/WTFReleaseWinCairo.props:
Include WinCairo.props.
- wtf/Platform.h:
Use GLib and GStreamer on WinCairo with video.
WebKitLibraries:
- win/tools/vsprops/FeatureDefinesCairo.props:
Removed duplicate ENABLE_VIDEO_TRACK definition.
- 1:36 PM Changeset in webkit [160854] by
-
- 2 edits in branches/safari-537.74-branch/Tools
Merge r160726
2013-12-17 Brent Fulgham <Brent Fulgham>
[Win] Revise filter-build-webkit to deal with Windows build logs
https://bugs.webkit.org/show_bug.cgi?id=125866
Reviewed by David Kilzer.
Enhance the script to accept a 'platform' argument. When platform
'win' is provided, use processing for the Windows build file format.
Otherwise, process the files as normal.
- Scripts/filter-build-webkit: (usageAndExit): Add a 'platform' argument (shouldIgnoreLine): When platform == 'win' use the new Windows rules for processing the build file.
- 1:32 PM Changeset in webkit [160853] by
-
- 10 edits2 moves in trunk/Source/WebKit2
[WK2] Rename WebURLResponse to API::URLResponse
https://bugs.webkit.org/show_bug.cgi?id=125910
Reviewed by Andreas Kling.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
- Shared/API/c/WKURLResponse.cpp:
(WKURLResponseGetTypeID):
- Shared/API/c/mac/WKURLResponseNS.mm:
(WKURLResponseCreateWithNSURLResponse):
- Shared/APIURLRequest.cpp:
- Shared/APIURLResponse.cpp: Copied from Source/WebKit2/Shared/WebURLResponse.cpp.
(API::URLResponse::URLResponse):
(API::URLResponse::encode):
(API::URLResponse::decode):
- Shared/APIURLResponse.h: Copied from Source/WebKit2/Shared/WebURLResponse.h.
(API::URLResponse::create):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebURLResponse.cpp: Removed.
- Shared/WebURLResponse.h: Removed.
- UIProcess/WebDownloadClient.cpp:
(WebKit::WebDownloadClient::didReceiveResponse):
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForResponse):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
- 1:15 PM Changeset in webkit [160852] by
-
- 3 edits in trunk/Source/WebCore
Use CascadedProperties for page and keyframe style resolution as well.
<https://webkit.org/b/125997>
Port StyleResolver's styleForKeyframe() and styleForPage() over to
the new property cascading code. Neither of them care about !important
or matched properties caches, so the code is very simple.
Removed the old applyMatchedProperties and applyProperties code with
low/high priority passes.
Reviewed by Antti Koivisto.
- 12:42 PM Changeset in webkit [160851] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation to fast/dynamic/paused-event-dispatch.html
while I investigate.
- 11:49 AM Changeset in webkit [160850] by
-
- 15 edits in trunk
Unreviewed, rolling out r160842.
http://trac.webkit.org/changeset/160842
https://bugs.webkit.org/show_bug.cgi?id=126003
broke accessibility/loading-iframe-updates-axtree.html
(Requested by ap on #webkit).
Tools:
- DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::makeJSAccessibilityUIElement):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement::platformUIElement):
LayoutTests:
- accessibility/deleting-iframe-destroys-axcache.html:
- accessibility/loading-iframe-updates-axtree-expected.txt:
- accessibility/loading-iframe-updates-axtree.html:
- accessibility/non-data-table-cell-title-ui-element.html:
- platform/gtk/accessibility/roles-exposed-expected.txt:
- platform/gtk/accessibility/roles-exposed.html:
- platform/mac-wk2/TestExpectations:
- platform/mac/accessibility/search-predicate-expected.txt:
- platform/mac/accessibility/search-predicate.html:
- platform/mac/accessibility/search-when-element-starts-in-table-expected.txt:
- platform/mac/accessibility/search-when-element-starts-in-table.html:
- 11:42 AM Changeset in webkit [160849] by
-
- 2 edits in trunk/Source/WebCore
tryAddEventListener uses local PassRefPtr<>
https://bugs.webkit.org/show_bug.cgi?id=126001
Reviewed by Daniel Bates.
- dom/Node.cpp:
(WebCore::tryAddEventListener): Put PassRefPtr<EventListener> parameter into a local RefPtr
because it is sometimes used twice.
- 11:32 AM Changeset in webkit [160848] by
-
- 4 edits in trunk/Tools
get_test_baseline should get Host from test_config
https://bugs.webkit.org/show_bug.cgi?id=125989
Patch by Dániel Bátyai <Dániel Bátyai> on 2013-12-19
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/commands/rebaselineserver.py:
(TestConfig.init):
(RebaselineServer._prepare_config):
- Scripts/webkitpy/tool/servers/rebaselineserver.py:
(get_test_baselines):
- Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(get_test_config):
- 11:10 AM Changeset in webkit [160847] by
-
- 9 edits2 adds in trunk
overflowchanged event could cause a crash
https://bugs.webkit.org/show_bug.cgi?id=125978
Reviewed by Tim Horton.
Source/WebCore:
Made the event asynchrnous by re-using Document's event queuing ability. Also removed
the infrastructure to queue up events in FrameView.
Test: fast/events/overflowchanged-inside-selection-collapse-crash.html
- dom/Document.cpp:
(WebCore::Document::recalcStyle):
(WebCore::Document::enqueueOverflowEvent):
- dom/Document.h:
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::~FrameView):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateOverflowStatus):
- page/FrameView.h:
- rendering/RenderBlock.cpp:
(WebCore::OverflowEventDispatcher::~OverflowEventDispatcher):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
LayoutTests:
Add a regression test.
- fast/events/overflowchanged-inside-selection-collapse-crash-expected.txt: Added.
- fast/events/overflowchanged-inside-selection-collapse-crash.html: Added.
- 11:10 AM Changeset in webkit [160846] by
-
- 2 edits in trunk/Tools
Don't check VSINSTALLDIR when looking for Visual Studio install directory.
https://bugs.webkit.org/show_bug.cgi?id=125998.
Reviewed by Alexey Proskuryakov.
- Scripts/webkitdirs.pm:
(visualStudioInstallDir):
Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
- 10:58 AM Changeset in webkit [160845] by
-
- 2 edits in trunk/Source/WebCore
Fix the Windows build after <http://trac.webkit.org/changeset/160841>
(https://bugs.webkit.org/show_bug.cgi?id=125879)
Add ENABLE(CACHE_PARTITIONING)-guard around call to ResourceRequest::setCachePartition()
as this function is only compiled when building with cache partitioning enabled.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::addImageToCache):
- 10:46 AM Changeset in webkit [160844] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Upstream WebCore/accessibility changes
https://bugs.webkit.org/show_bug.cgi?id=125925
Reviewed by Chris Fleizach.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::visiblePositionForPoint): Opt out of code when building for iOS.
- 10:25 AM Changeset in webkit [160843] by
-
- 3 edits in trunk/Source/WebCore
[WinCairo] Compile fix for VS2013 when using ACCELERATED_COMPOSITING.
https://bugs.webkit.org/show_bug.cgi?id=124866
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-19
Reviewed by Darin Adler.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
- platform/graphics/TiledBackingStore.h:
Added constructor overload to avoid compile errors
from using MSVC's make_unique as a default parameter.
- 10:14 AM Changeset in webkit [160842] by
-
- 15 edits in trunk
[ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
https://bugs.webkit.org/show_bug.cgi?id=125854
Reviewed by Chris Fleizach.
Tools:
Ensure we don't ever create instances of AccessibilityUIElement
wrapping invalid platform-specific accessibility objects in DRT,
both for consistency with what WKTR does (so we avoid situations
where some tests fail in WK2 and not in WK1) and also to avoid
overlooking tests that might not be checking the right thing.
- DumpRenderTree/AccessibilityUIElement.cpp:
(AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
nullPtr if the platformUIElement() is not a valid one.
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement::platformUIElement): Added const modifier.
LayoutTests:
Updated tests and expectations to keep them passing after the
change done in DRT, without changing their actual purpose.
- platform/gtk/accessibility/roles-exposed.html: Make sure we
print "AXRole: (no element)" when accessibilityElementByID() does
not return a valid object, not to confuse it with cases where the
returned string for the role is an empty string.
- platform/gtk/accessibility/roles-exposed-expected.txt: Update
test expectations to reflect the "AXRole: (no element)" string
that is now being exposed. Also, replace the (wrongly added) PASS
expectations with FAIL for rowgroups, which are currently not
being exposed for ATK either.
- accessibility/deleting-iframe-destroys-axcache.html: Just
consider the first and third sons of the accessibility object for
the body (instead of the grandsons), so the test can run both in
Mac, where sons and grandsons are exposed, and ATK, where only
sons are exposed (no StaticText objects exposed there).
- accessibility/non-data-table-cell-title-ui-element.html: Use
accessibilityElementById() to get the accessibility object for the
"skip" table header instead of navigating with childAtIndex(),
since the hierarchy is not the same for Mac and ATK based ports.
- accessibility/loading-iframe-updates-axtree.html: Use the new
web area inside the iframe to compare against the old one, instead
of doing it the other way around, to avoid calling isEqual for an
undefined value (the old web area).
- accessibility/loading-iframe-updates-axtree-expected.txt:
Removed line comparing the old and new web areas inside the iframe.
- platform/mac/accessibility/search-predicate.html: Do not rely on
shouldBe() together with the string "AXRole: " when asking for the
role of objects that should no longer be in the accessibility
tree, and use shouldBeUndefined() instead.
- platform/mac/accessibility/search-when-element-starts-in-table.html: Ditto.
- platform/mac/accessibility/search-predicate-expected.txt: Update
expectations according to the usage of shouldBeUndefined().
- platform/mac/accessibility/search-when-element-starts-in-table-expected.txt: Ditto.
- platform/mac-wk2/TestExpectations: Add search-when-element-starts-in-table.html
here, since it does not return an undefined object in WebKit2 when
the search query should return no results (see bug 125996).
- 10:10 AM Changeset in webkit [160841] by
-
- 35 edits in trunk/Source/WebCore
[iOS] Upstream WebCore/loader changes
https://bugs.webkit.org/show_bug.cgi?id=125879
Reviewed by Darin Adler.
- WebCore.exp.in: Added symbols for MemoryCache::{addImageToCache, removeImageFromCache}().
- loader/DocumentLoader.cpp:
(WebCore::areAllLoadersPageCacheAcceptable): Added.
(WebCore::DocumentLoader::DocumentLoader): Initialize m_subresourceLoadersArePageCacheAcceptable.
(WebCore::DocumentLoader::stopLoading): Modified to conditionally call areAllLoadersPageCacheAcceptable().
(WebCore::DocumentLoader::handleSubstituteDataLoadSoon): Modified to query FrameLoader::loadsSynchronously()
whether to load substitute data immediately or to schedule a load.
(WebCore::DocumentLoader::responseReceived): Modified to create a content filer when the response protocol
is either HTTP or HTTPS, assuming content filtering is enabled.
(WebCore::DocumentLoader::dataReceived): Modified to call DocumentLoader::setContentFilterForBlockedLoad()
as appropriate.
(WebCore::DocumentLoader::clearMainResourceLoader): Added PLATFORM(IOS)-guarded code. Also added a
FIXME comment to remove the PLATFORM(IOS)-guard once we upstream the iOS changes to ResourceRequest.h.
(WebCore::DocumentLoader::setResponseMIMEType): Added; guard by PLATFORM(IOS). Also added FIXME comment.
(WebCore::DocumentLoader::startLoadingMainResource): Added PLATFORM(IOS)-guarded code. Also added a
FIXME comment to remove the PLATFORM(IOS)-guard once we upstream the iOS changes to ResourceRequest.h.
I also substituted static NeverDestroyed<> for DEFINE_STATIC_LOCAL.
(WebCore::DocumentLoader::setContentFilterForBlockedLoad): Added; guarded by USE(CONTENT_FILTERING).
(WebCore::DocumentLoader::handleContentFilterRequest): Added; guarded by USE(CONTENT_FILTERING) and PLATFORM(IOS).
Also added a FIXME comment to remove the PLATFORM(IOS) guard inside its function body once we upstream
file ContentFilterIOS.mm and implement ContentFilter::requestUnblockAndDispatchIfSuccessful() for Mac.
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::setResponse): Added; guard by PLATFORM(IOS). Also added a FIXME comment as
this method seems to violate the encapsulation of DocumentLoader.
(WebCore::DocumentLoader::subresourceLoadersArePageCacheAcceptable): Added.
(WebCore::DocumentLoader::documentURL): Added; returns the URL of the document resulting from the DocumentLoader.
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument): Added iOS-specific code to create a PDF document.
- loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::openDateTimeChooser): Opt out of compiling this code for iOS. Also substituted
nullptr for 0.
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameProgressTracker::~FrameProgressTracker):
(WebCore::FrameLoader::FrameLoader): Initialize m_loadsSynchronously.
(WebCore::FrameLoader::initForSynthesizedDocument): Added; guarded by PLATFORM(IOS). Also added FIXME comment.
(WebCore::FrameLoader::checkCompleted): Added iOS-specific code with FIXME comment.
(WebCore::FrameLoader::willLoadMediaElementURL): Added iOS-specific code.
(WebCore::FrameLoader::stopForUserCancel): Added iOS-specific code and FIXME comment.
(WebCore::FrameLoader::commitProvisionalLoad): Added iOS-specific code and FIXME comment.
(WebCore::FrameLoader::transitionToCommitted): Opt out of ENABLE(TOUCH_EVENTS) logic when building for iOS.
(WebCore::FrameLoader::didFirstLayout): Added iOS-specific code.
(WebCore::FrameLoader::connectionProperties): Added; guarded by PLATFORM(IOS).
(WebCore::createWindow): Added iOS-specific code and FIXME comment.
- loader/FrameLoader.h:
(WebCore::FrameLoader::setLoadsSynchronously): Added.
(WebCore::FrameLoader::loadsSynchronously): Added.
- loader/FrameLoaderClient.h:
- loader/HistoryController.cpp:
(WebCore::HistoryController::restoreScrollPositionAndViewState): Opt out of scroll position logic when building for iOS.
(WebCore::HistoryController::replaceCurrentItem): Added.
- loader/HistoryController.h:
- loader/PlaceholderDocument.h: Changed access control of constructor from private to protected and removed the FINAL
keyword from the class so that we can subclass PlaceholderDocument on iOS.
- loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy): Added USE(QUICK_LOOK)- and USE(CONTENT_FILTERING)-guarded code.
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::shouldUsePurgeableMemory): Added; guarded by PLATFORM(IOS).
- loader/ResourceBuffer.h:
- loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchWillSendRequest): Added USE(QUICK_LOOK)-guarded code.
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Added iOS-specific code.
(WebCore::ResourceLoadScheduler::scheduleLoad): Ditto.
(WebCore::ResourceLoadScheduler::remove): Added iOS-specific code with FIXME comment.
(WebCore::ResourceLoadScheduler::crossOriginRedirectReceived): Added null-check for variable oldHost. Also added
iOS-specific code.
(WebCore::ResourceLoadScheduler::servePendingRequests): Added iOS-specific code.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Ditto.
(WebCore::ResourceLoader::willSendRequest): Ditto.
(WebCore::ResourceLoader::connectionProperties): Added; guarded by PLATFORM(IOS).
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::startLoading): Added; guarded by PLATFORM(IOS).
(WebCore::ResourceLoader::iOSOriginalRequest): Added; iOS-specific.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin): Added iOS-specific code.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create): Ditto.
(WebCore::SubresourceLoader::startLoading): Added; guarded by PLATFORM(IOS).
(WebCore::SubresourceLoader::didFinishLoading): Added iOS-specific code.
(WebCore::SubresourceLoader::willCancel): Ditto.
(WebCore::SubresourceLoader::notifyDone): Ditto.
(WebCore::SubresourceLoader::releaseResources): Ditto.
- loader/SubresourceLoader.h:
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::loadCacheGroup): Added iOS-specific code.
(WebCore::ApplicationCacheStorage::loadManifestHostHashes): Ditto.
(WebCore::ApplicationCacheStorage::cacheGroupForURL): Ditto.
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL): Ditto.
(WebCore::ApplicationCacheStorage::calculateQuotaForOrigin): Ditto.
(WebCore::ApplicationCacheStorage::calculateUsageForOrigin): Ditto.
(WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache): Ditto.
(WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin): Ditto.
(WebCore::ApplicationCacheStorage::executeSQLCommand): Ditto.
(WebCore::ApplicationCacheStorage::verifySchemaVersion): Ditto.
(WebCore::ApplicationCacheStorage::openDatabase): Ditto.
(WebCore::ApplicationCacheStorage::executeStatement): Ditto.
(WebCore::ApplicationCacheStorage::store): Ditto.
(WebCore::ApplicationCacheStorage::storeUpdatedType): Ditto.
(WebCore::ApplicationCacheStorage::ensureOriginRecord): Ditto.
(WebCore::ApplicationCacheStorage::loadCache): Ditto.
(WebCore::ApplicationCacheStorage::remove): Ditto.
(WebCore::ApplicationCacheStorage::empty): Ditto.
(WebCore::ApplicationCacheStorage::storeCopyOfCache): Ditto.
(WebCore::ApplicationCacheStorage::manifestURLs): Ditto.
(WebCore::ApplicationCacheStorage::cacheGroupSize): Ditto.
(WebCore::ApplicationCacheStorage::deleteCacheGroup): Ditto.
(WebCore::ApplicationCacheStorage::vacuumDatabaseFile): Ditto.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::CachedImage): Added.
(WebCore::CachedImage::imageSizeForRenderer): Added iOS-specific code.
(WebCore::CachedImageManual::CachedImageManual): Added; guarded by USE(CF). Also added FIXME comment to incorporate
the functionality of this class into CachedImage and to remove the USE(CF)-guard once we make MemoryCache::addImageToCache()
platform-independent.
(WebCore::CachedImageManual::mustRevalidateDueToCacheHeaders): Added; guarded by USE(CF).
- loader/cache/CachedImage.h: Removed FINAL keyword from class so that we can define derived class CachedImageManual.
(WebCore::CachedImage::isManual): Added; guarded by USE(CF). Also added FIXME comment.
(WebCore::CachedImageManual::addFakeClient): Added; guarded by USE(CF).
(WebCore::CachedImageManual::removeFakeClient): Added; guarded by USE(CF).
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load): Added iOS-specific code.
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::loadDone): Added argument shouldPerformPostLoadActions, defaults to true. Modified
to conditionally call performPostLoadActions() with respect to the argument shouldPerformPostLoadActions.
(WebCore::CachedResourceLoader::preload): Added iOS-specific code.
(WebCore::CachedResourceLoader::checkForPendingPreloads): Ditto.
- loader/cache/CachedResourceLoader.h:
- loader/cache/MemoryCache.cpp:
(WebCore::memoryCache):
(WebCore::MemoryCache::add): Added iOS-specific code.
(WebCore::MemoryCache::revalidationFailed): Ditto.
(WebCore::MemoryCache::resourceForRequest): Ditto.
(WebCore::MemoryCache::addImageToCache): Added; guarded by USE(CF). Also added FIXME comment.
(WebCore::MemoryCache::removeImageFromCache): Added; guarded by USE(CF). Also added FIXME comment.
(WebCore::MemoryCache::pruneLiveResources): Modified to take argument shouldDestroyDecodedDataForAllLiveResources.
(WebCore::MemoryCache::pruneLiveResourcesToSize): Modified to take argument shouldDestroyDecodedDataForAllLiveResources,
defaults to false. When this argument is true we destroy the decoded data for all live resources from the memory cache.
Such functionality is useful when the system is running low on memory.
(WebCore::MemoryCache::evict): Added iOS-specific code.
- loader/cache/MemoryCache.h:
- loader/cf/SubresourceLoaderCF.cpp:
(WebCore::SubresourceLoader::didReceiveDataArray): Actually make this code compile. In particular, there is no
method called sendDataToResource on SubresourceLoader or in its class hierarchy.
- loader/mac/DocumentLoaderMac.cpp:
(WebCore::DocumentLoader::schedule): This method has an empty implementation when building for iOS.
(WebCore::DocumentLoader::unschedule): Ditto.
- platform/graphics/BitmapImage.h: Exposed decodedSize() to access the decoded size of the bitmap image.
This functionality is used in MemoryCache::addImageToCache().
- 10:03 AM Changeset in webkit [160840] by
-
- 2 edits in trunk/LayoutTests
platform/mac/editing/attributed-string tests all flakily assert
https://bugs.webkit.org/show_bug.cgi?id=123029
- platform/mac/TestExpectations: Marked as flakily asserting.
- 9:51 AM Changeset in webkit [160839] by
-
- 2 edits in trunk/Source/WebCore
Build fix for platforms which do not define -[AVSampleBufferAudioRenderer muted].
Rubber-stamped by Eric Carlson.
To work around platforms with broken AVSampleBufferAudioRenderer headers, just
declare only those functions we need, and update isAvalable to bail out early if
those methods are not present.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
- 9:50 AM Changeset in webkit [160838] by
-
- 2 edits in trunk/Source/WTF
WTF, JavaScriptCore fails to build with trunk clang: operators new, new[],
delete, delete[] cannot be declared inline
https://bugs.webkit.org/show_bug.cgi?id=124186
<rdar://problem/15644039>
Reviewed by Geoffrey Garen and Anders Carlsson.
Following <http://llvm.org/viewvc/llvm-project?view=revision&revision=193044>
(http://llvm.org/bugs/show_bug.cgi?id=17591>), Clang emits warnings when
operator new, delete are inlined. Such definitions cannot be inline per
replacement.functions (17.6.4.6/3) of the C++ standard. For now,
disable these warnings instead of exporting these functions.
- wtf/FastMalloc.h:
- 9:40 AM Changeset in webkit [160837] by
-
- 5 edits in trunk/Source/WebCore
Improve "bad parent" and "bad child list" assertions in line boxes
https://bugs.webkit.org/show_bug.cgi?id=125656
Reviewed by Sam Weinig.
- rendering/InlineBox.cpp:
(WebCore::InlineBox::root): Use parent() function with assertions rather than
using m_parent function, which skips the assertions.
- rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyTextBoxes): Call invalidateParentChildLists
if we are in the optimized document-destruction code path and destroying children
without removing them from their parents.
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::invalidateParentChildLists): Added.
- rendering/RenderTextLineBoxes.h: Added invalidateParentChildLists.
- 9:32 AM Changeset in webkit [160836] by
-
- 2 edits in trunk/Source/WebCore
<rdar://problem/15696824> [CFNetwork] Loading stops at server redirects
https://bugs.webkit.org/show_bug.cgi?id=125984
Reviewed by Anders Carlsson.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::willSendRequest): If the client uses async callbacks, call its
willSendRequestAsync callback instead if willSendRequest.
- 9:22 AM Changeset in webkit [160835] by
-
- 21 edits in branches/jsCStack/Source/JavaScriptCore
Clarified stack maintainence code
https://bugs.webkit.org/show_bug.cgi?id=125979
Reviewed by Phil Pizlo.
Our idiom is:
- frameRegisterCount() is the distance between BP and SP
- stackPointerOffset() is frameRegisterCount() converted to a stack offset
- Stack checks don't need to check the stack used by C helper functions, since our reserved host zone will cover that.
- assembler/MaxFrameExtentForSlowPathCall.h: Reverted some pieces of
<http://trac.webkit.org/changeset/160745>. We don't consider our
callee's saved PC and BP a part of our stack frame because they lie
beneath our SP.
- bytecode/CodeBlock.cpp:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::stackPointerOffset): New helper function. Lots of
callers were duplicating this, so I made a helper function.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::parseBlock): Fixed a bug in the calculation
of m_parameterSlots. Within our stack frame, we don't reserve space for
our callee's saved PC and BP, so we don't need to add them to
m_parameterSlots.
- dfg/DFGGraph.cpp:
- dfg/DFGGraph.h:
(JSC::DFG::Graph::stackPointerOffset): New helper function. Lots of
callers were duplicating this, so I made a helper function.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::adjustAndJumpToTarget):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::topOfFrameInternal): Use the new helper function, so
everybody calculates SP the same way. This removes the two idiosyncratic
places that reserved extra space for our callee's CallerFrameAndPCSize.
- interpreter/JSStack.h:
- interpreter/JSStackInlines.h:
(JSC::JSStack::entryCheck):
(JSC::JSStack::pushFrame):
(JSC::JSStack::grow): Changed the interface here to accept a top-of-stack
pointer instead of a past-the-end pointer. The engine no longer computes
a past-the-end pointer, so this is more convenient.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::stackPointerOffsetFor): Use the helper function, fixing a bug
where, incorrectly, we subtracted out maxFrameExtentForSlowPathCall.
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOperations.cpp: Use the helper function, so everybody does this
calculation the same way.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions): Reverted some pieces of
<http://trac.webkit.org/changeset/160745>, as above.
- llint/LLIntEntrypoint.cpp:
- llint/LLIntEntrypoint.h:
(JSC::LLInt::stackPointerOffsetFor): Helper function, as above.
- llint/LowLevelInterpreter.asm: Reverted some pieces of
<http://trac.webkit.org/changeset/160745>, as above.
- 9:11 AM Changeset in webkit [160834] by
-
- 2 edits in trunk/Source/WTF
WTF fails to compile with gcc 4.8.2 and -Werror=array-bounds
https://bugs.webkit.org/show_bug.cgi?id=125936
Reviewed by Anders Carlsson.
- wtf/dtoa/double-conversion.cc: Use a unsigned instead of int on buffer_pos type.
- 8:30 AM Changeset in webkit [160833] by
-
- 4 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Regressions in WebView's contentScaleFactor/contentPosition
https://bugs.webkit.org/show_bug.cgi?id=125943
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-19
Reviewed by Noam Rosenthal.
When WebView::pageDidRequestScroll is called it is scaling position requested
to scroll before store it as contentPosition, that is not necessary since WebView
already stores the requested contentScaleFactor so it's able to do that internally
when needed, what simplifies the API and improves the readability of webview's code.
This patch reverts changes from https://bugs.webkit.org/show_bug.cgi?id=118548, which
was causing some regressions in contentScaleFactor/contentPosition related stuff.
Besides that WebView::pageDidRequestScroll calls viewClient callback with the wrong
position (different from the position stored in WebView).
- UIProcess/API/efl/EwkView.cpp:
(EwkView::scrollBy):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::pageDidRequestScroll):
- UIProcess/efl/PageViewportControllerClientEfl.cpp:
(WebKit::PageViewportControllerClientEfl::setViewportPosition):
- 8:21 AM Changeset in webkit [160832] by
-
- 2 edits in trunk/Source/WTF
Delete RVCT related code parts.
https://bugs.webkit.org/show_bug.cgi?id=125626
Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-12-19
Reviewed by Csaba Osztrogonác.
- wtf/Compiler.h: follow-up fix for r160648, remove an unnecessary comment.
- 7:48 AM Changeset in webkit [160831] by
-
- 10 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Remove "AndAlloc" from sizeAndAllocFrameForVarargs and friends
https://bugs.webkit.org/show_bug.cgi?id=125980
Reviewed by Mark Lam.
Renamed sizeAndAllocFrameForVarargs to sizeFrameForVarargs along with
removing "and alloc" from all related callers. This was done because
sizeAndAllocFrameForVarargs, didn't really allocate but just sized the
new call frame.
- interpreter/Interpreter.cpp:
(JSC::sizeFrameForVarargs):
- interpreter/Interpreter.h:
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- 7:24 AM Changeset in webkit [160830] by
-
- 2 edits in trunk/Source/WebCore
CascadedProperties: Deferred properties should have inline capacity.
<https://webkit.org/b/125994>
Give CascadedProperties::m_deferredProperties an inline capacity
of 8 to sidestep malloc churn (0.2% of HTML5-8266 profile.)
Reviewed by Antti Koivisto.
- 5:59 AM Changeset in webkit [160829] by
-
- 2 edits in trunk/Source/WebCore
Two small refinements to matched properties cache.
<https://webkit.org/b/125992>
- Avoid computing the matched properties hash if we're banned from using the cache anyway.
- When adding a new entry to the cache, use move semantics to avoid creating a transient copy of all the data.
Reviewed by Antti Koivisto.
- 4:15 AM Changeset in webkit [160828] by
-
- 2 edits in trunk/Source/WebCore
CascadedProperties should use a bitset to track property presence.
<https://webkit.org/b/125991>
Avoid zeroing out a bunch of memory in the CascadedProperties ctor
by using a bitset to track whether each property is present in the
cascaded set.
Reviewed by Antti Koivisto.
- 1:20 AM Changeset in webkit [160827] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix description of parameters in Page.setGeolocationOverride
https://bugs.webkit.org/show_bug.cgi?id=125983
Reviewed by Joseph Pecoraro.
No new tests, no changes in behavior.
- inspector/protocol/Page.json:
Dec 18, 2013:
- 11:19 PM Changeset in webkit [160826] by
-
- 2 edits in trunk/LayoutTests
Rebaseline the test I added in r160819.
- svg/text/select-text-inside-non-static-position-expected.txt:
- 11:01 PM Changeset in webkit [160825] by
-
- 4 edits in trunk/Source/WebCore
[MSE][Mac] Add AVSampleBufferRendererSynchronizer support.
https://bugs.webkit.org/show_bug.cgi?id=125954
Reviewed by NOBODY (OOPS!).
Instead of slaving all the various renderer's CMTimebases to one master timebase,
use AVSampleBufferRenderSynchronizer, which essentially does the same thing.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::CMTimebaseEffectiveRateChangedCallback): Added; call effectiveRateChanged().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC): Set up
the synchronizer and all the observers.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC): Tear down
the same.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable): Require the
AVSampleBufferRenderSynchronizer class.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal): Convert Clock -> Synchronizer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pauseInternal): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::paused): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setRateDouble): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::destroyLayer): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::effectiveRateChanged): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeDisplayLayer): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer): Ditto.
Drive-by fix; audio samples can't be subdivided, and video samples are
rarely combined, so remove the call to CMSampleBufferCallForEachSample:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::didProvideMediaDataForTrackID):
- 10:12 PM Changeset in webkit [160824] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Rename functions in JSStack to fit WebKit Coding Style.
https://bugs.webkit.org/show_bug.cgi?id=125974.
Reviewed by Filip Pizlo.
This is a purely cosmetic change. There are no semantic changes.
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::gatherConservativeRoots):
(JSC::JSStack::sanitizeStack):
- interpreter/JSStack.h:
(JSC::JSStack::baseOfStack):
- interpreter/JSStackInlines.h:
(JSC::JSStack::topOfFrameFor):
(JSC::JSStack::topOfStack):
(JSC::JSStack::startOfFrameFor):
(JSC::JSStack::entryCheck):
(JSC::JSStack::pushFrame):
(JSC::JSStack::popFrame):
(JSC::JSStack::shrink):
(JSC::JSStack::installFence):
(JSC::JSStack::validateFence):
(JSC::JSStack::installTrapsAfterFrame):
- 8:47 PM Changeset in webkit [160823] by
-
- 2 edits in trunk/WebKitLibraries
[WinCairo] Unreviewed build fix after r160798.
- win/tools/vsprops/FeatureDefinesCairo.props:
Removed ENABLE_MEDIA_CONTROLS_SCRIPT definition for now.
- 8:30 PM Changeset in webkit [160822] by
-
- 3 edits in trunk/Source/JavaScriptCore
DelayedReleaseScope is in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=125876
Reviewed by Geoffrey Garen.
The DelayedReleaseScope needs to be around the free list sweeping in MarkedAllocator::tryAllocateHelper.
This location gives us a good safe point between getting ready to allocate (i.e. identifying a non-empty
free list) and doing the actual allocation (popping the free list).
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::addBlock):
- runtime/JSCellInlines.h:
(JSC::allocateCell):
- 7:48 PM Changeset in webkit [160821] by
-
- 8 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Fix baseline to DFG JIT OSR.
https://bugs.webkit.org/show_bug.cgi?id=125969.
Reviewed by Filip Pizlo.
- Change operationOptimize() to return a tuple of OSR target address and new topOfFrame value (as opposed to just the OSR target address).
- Change emitEnterOptimizationCheck() and emitSlow_op_loop_hint() to emit code to set the stackPointer with the returned topOfFrame value if we take the OSR path.
- jit/JIT.cpp:
(JSC::JIT::emitEnterOptimizationCheck):
- jit/JIT.h:
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- runtime/Options.h:
- 7:13 PM Changeset in webkit [160820] by
-
- 2 edits in trunk/Source/WebCore
CSS: Fall back to cache-less cascade when encountering explicitly inherited value.
<https://webkit.org/b/125968>
When encountering an explicitly inherited value for a property that's not
"statically inherited", drop out of the matched properties cache path
immediately instead of waiting for some coincidence to trigger it later on.
Fixes 3 asserting table tests:
- fast/table/border-collapsing/cached-69296.html
- tables/mozilla/bugs/bug27038-3.html
- tables/mozilla_expected_failures/marvin/backgr_border-table-row-group.html
Reviewed by Antti Koivisto.
- 7:09 PM Changeset in webkit [160819] by
-
- 3 edits2 adds in trunk
Crash in WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches
https://bugs.webkit.org/show_bug.cgi?id=125970
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by containingBlockForAbsolutePosition returning a non-RenderBlock render object.
Fixed the bug by obtaining its containg block.
Also changed the return type of containingBlockForFixedPosition, containingBlockForAbsolutePosition,
containingBlockForObjectInFlow from RenderElement to RenderBlock as all callers of these functions
had assumed the return value to be an instance of RenderBlock.
Test: svg/text/select-text-inside-non-static-position.html
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
LayoutTests:
Added a regression test.
- svg/text/select-text-inside-non-static-position-expected.txt: Added.
- svg/text/select-text-inside-non-static-position.html: Added.
- 6:33 PM Changeset in webkit [160818] by
-
- 15 edits3 adds in trunk/Source/WebKit2
WebKit2 View Gestures: Move WebProcess-side geometry collection into its own class
https://bugs.webkit.org/show_bug.cgi?id=125967
Reviewed by Anders Carlsson.
Move the messages dispatched by ViewGestureController that grab geometry
from the WebProcess out of the DrawingArea and into ViewGestureGeometryCollector.
This class will grow when smart magnification is implemented.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
Remove BeginTransientZoom() message.
- DerivedSources.make:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/mac/ViewGestureController.cpp:
(WebKit::ViewGestureController::didCollectGeometryForMagnificationGesture):
(WebKit::ViewGestureController::handleMagnificationGesture):
- UIProcess/mac/ViewGestureController.h:
- UIProcess/mac/ViewGestureController.messages.in:
Make use of ViewGestureGeometryCollector and rename didBeginTransientZoom to didCollectGeometryForMagnificationGesture.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp: Added.
(WebKit::ViewGestureGeometryCollector::ViewGestureGeometryCollector):
(WebKit::ViewGestureGeometryCollector::~ViewGestureGeometryCollector):
(WebKit::ViewGestureGeometryCollector::collectGeometryForMagnificationGesture):
- WebProcess/WebPage/ViewGestureGeometryCollector.h: Added.
- WebProcess/WebPage/ViewGestureGeometryCollector.messages.in: Added.
Move the code to collect the visible content rect and return it to the ViewGestureController into its own class.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
Move m_pageID to the top of WebPage's initialization list so that
it can be safely used from other members' constructors.
Add a ViewGestureGeometryCollector member and construct it.
- 6:29 PM Changeset in webkit [160817] by
-
- 2 edits in trunk/Source/WebCore
Don't waste cycles on zeroing every CascadedProperties::Property.
<https://webkit.org/b/125966>
The CascadedProperties constructor already zeroes out the whole
property array. Move the memset() to setDeferred() which is the only
other place we create a Property.
Brought to you by Instruments.app. Profile your code today!
Reviewed by Antti Koivisto.
- 6:22 PM Changeset in webkit [160816] by
-
- 4 edits in trunk/Source
Unreviewed cmake build fix for GTK+.
Source/WebKit:
- PlatformGTK.cmake: add missing include directory.
Source/WebKit2:
- PlatformGTK.cmake: fix paths for files that were moved.
- 6:21 PM Changeset in webkit [160815] by
-
- 4 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Stop threading callFrameRegister through LLIntSlowCalls
https://bugs.webkit.org/show_bug.cgi?id=125964
Reviewed by Geoffrey Garen.
Removed the general restoring of the call frame registers (cfr) after the return
from a LLInt slow calls. In most cases, the "exec" value of the LLInt slow
path return pair is set to 0. For llint_slow_path_call/construct and
llint_slow_path_size_and_alloc_frame_for_varargs the execCallee is returned in
the "exec" value. When an exception happens in a slow path handler we return 0,
because the llint_throw_from_slow_path_trampoline path will properly unwind by
making a slow call that will invoke genericUnwind() to do the real unwinding.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
- 5:55 PM Changeset in webkit [160814] by
-
- 4 edits in trunk/Source/WebCore
[CSS Shapes] Simplify the BoxShape implementation
https://bugs.webkit.org/show_bug.cgi?id=125548
Reviewed by Andreas Kling.
Reduce BoxShape's footprint by about 2/3rds. Instead of caching the
FloatRoundedRects which represent a BoxShape's shape-padding and shape-margin
boundaries, compute them as needed.
No new tests, this is just an internal refactoring.
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::shapeMarginLogicalBoundingBox): Now just computes the bounding box rect.
(WebCore::BoxShape::shapePaddingLogicalBoundingBox): Ditto.
(WebCore::BoxShape::shapeMarginBounds): Removed the caching logic.
(WebCore::BoxShape::shapePaddingBounds): Ditto.
(WebCore::BoxShape::getExcludedIntervals): Use the computed margin bounds, instead of the cached one.
(WebCore::BoxShape::getIncludedIntervals): Ditto (padding bounds).
- rendering/shapes/BoxShape.h:
(WebCore::BoxShape::BoxShape): Simplified the constructor.
- rendering/shapes/Shape.cpp:
(WebCore::createBoxShape):
(WebCore::Shape::createShape):
- 5:39 PM Changeset in webkit [160813] by
-
- 2 edits in trunk/Source/WebKit2
MessageReceiverMap::addMessageReceiver should assert that destinationID is not zero
https://bugs.webkit.org/show_bug.cgi?id=125965
Reviewed by Tim Horton.
- Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::addMessageReceiver):
- 5:35 PM Changeset in webkit [160812] by
-
- 5 edits in trunk
[GTK][CMake] make libjavascriptcoregtk a public shared library again
https://bugs.webkit.org/show_bug.cgi?id=125512
Reviewed by Martin Robinson.
.:
- CMakeLists.txt: make JavaScriptCore always be a shared library for the GTK+ port.
- Source/cmake/WebKitHelpers.cmake: make -fvisibility=hidden not be applied for GTK+,
visibility of some symbols is required for threading to be initialized properly by
WebKit2 processes, and we will rely on a linker script that will be added later on,
for production builds.
Source/JavaScriptCore:
- CMakeLists.txt: use target type instead of SHARED_CORE to decide whether
JavaScriptCore is a shared library, since it's always shared for GTK+ regardless
of SHARED_CORE.
- 5:22 PM Changeset in webkit [160811] by
-
- 12 edits in trunk
Deprecate some WKMutableDictionary functions
https://bugs.webkit.org/show_bug.cgi?id=125962
Reviewed by Tim Horton.
Source/WebKit2:
- Shared/API/c/WKDeprecatedFunctions.cpp:
(WKDictionaryIsMutable):
(WKDictionaryAddItem):
(WKDictionaryRemoveItem):
- Shared/API/c/WKMutableDictionary.cpp:
- Shared/API/c/WKMutableDictionary.h:
Tools:
- TestWebKitAPI/PlatformUtilities.cpp:
(TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
(TestWebKitAPI::didAssociateFormControls):
- TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
(TestWebKitAPI::WillLoadTest::willLoadURLRequest):
(TestWebKitAPI::WillLoadTest::willLoadDataRequest):
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::createMouseMessageBody):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::createKeyDownMessageBody):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::continuousMouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::setTouchPointRadius):
(WTR::EventSendingController::touchStart):
(WTR::EventSendingController::touchMove):
(WTR::EventSendingController::touchEnd):
(WTR::EventSendingController::touchCancel):
(WTR::EventSendingController::clearTouchPoints):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::setMockGeolocationPosition):
(WTR::InjectedBundle::setCustomPolicyDelegate):
(WTR::InjectedBundle::setVisibilityState):
(WTR::InjectedBundle::queueLoad):
(WTR::InjectedBundle::queueLoadHTMLString):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::updateThreadedScrollingForCurrentTest):
(WTR::updateLayoutType):
(WTR::TestInvocation::invoke):
- 5:14 PM Changeset in webkit [160810] by
-
- 5 edits in trunk/Source/WebCore
[MSE][Mac] Add AVSampleBufferAudioRenderer support.
https://bugs.webkit.org/show_bug.cgi?id=125905
Reviewed by Eric Carlson.
On platforms which support AVSampleBufferAudioRenderer, add support
for playback of audio CMSampleBufferRefs generated by AVStreamDataParser.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isAvailable): Require AVSampleBufferAudioRenderer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVolume): Pass through to every audio renderer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setMuted): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer): Slave the renderer's
timebase to the master clock.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC): Drive by fix; initialize
m_enabledVideoTrackID.
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC): Call destroyRenderers().
(WebCore::callProcessCodedFrameForEachSample): Drive by fix; convert the bool return to an OSErr.
(WebCore::SourceBufferPrivateAVFObjC::destroyRenderers): Added; flush and destroy the audio
renderers.
(WebCore::SourceBufferPrivateAVFObjC::removedFromMediaSource): Call destroyRenderers().
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled): Enable or disable the audio
renderer in response.
(WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples): Added audio
specific version.
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::isReadyForMoreSamples): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::didBecomeReadyForMoreSamples): Ditto.
(WebCore::SourceBufferPrivateAVFObjC::notifyClientWhenReadyForMoreSamples): Ditto.
- 4:52 PM Changeset in webkit [160809] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Allow the web process plug-in to intercept resource requests
https://bugs.webkit.org/show_bug.cgi?id=125959
Reviewed by Anders Carlsson.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Declared new
delegate method.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(willSendRequestForFrame): Implemented this WKBundlePageResourceClient callback by calling
the load delegate.
(setUpResourceLoadClient): Added. Initializes the resource load client with the above
function.
(-[WKWebProcessPlugInBrowserContextController setLoadDelegate:]): Added calls to initialize
and clear the resource load client.
- 4:48 PM Changeset in webkit [160808] by
-
- 9 edits in branches/jsCStack/Source/JavaScriptCore
CStack: Fix LLINT to baseline JIT OSR.
https://bugs.webkit.org/show_bug.cgi?id=125957.
Reviewed by Michael Saboff.
- In LLINT prologue code, when taking the OSR path, we don't actually need the OSR slow path function to return the new stackPointer value. Instead, the OSR prep code in the prologue needs to restore the previous sp because we are going to jump to the prologue of the target codeBlock, which will assume that the stack pointer to be pointing to the top of the caller frame.
To do this, we simply set stackPointer to the "new" callFrameRegister
before we pop the "old" callFrame address into the callFrameRegister.
- In the LLINT checkSwitchToJITForLoop() macro, if we're going to take the OSR path, we'll need to set the stackPointer to the new topOfFrame for the target codeBlock. Hence, we make llint_loop_osr return exec->topOfFrame() for this purpose.
- Previously, CallFrame::topOfFrame() (renamed from CallFrame::frameExtent()) would return the address of the slot past the top of the frame. It now returns the slot at the top of the frame as it should.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::topOfFrameInternal):
- interpreter/CallFrame.h:
(JSC::ExecState::topOfFrame):
- interpreter/JSStack.cpp:
(JSC::JSStack::disableErrorStackReserve):
- interpreter/JSStackInlines.h:
(JSC::JSStack::getTopOfFrame):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 4:42 PM Changeset in webkit [160807] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Remove leftover code from InspectorController after r108965
https://bugs.webkit.org/show_bug.cgi?id=125956
Reviewed by Joseph Pecoraro.
No new tests, no changes in behavior.
- inspector/InspectorController.h: PostWorkerNotificationToFrontendTask was removed in r108965.
- 4:33 PM Changeset in webkit [160806] by
-
- 3 edits in trunk/Source/WebCore
CSS: Add a property cascading pass to style application.
<https://webkit.org/b/125213>
Add an intermediate pass to style application where we cascade all
style properties to figure out their final values before starting
to build RenderStyles.
This opens up various opportunities for further optimization.
Reviewed by Antti Koivisto.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::CascadedProperties::Property::Property):
(WebCore::StyleResolver::CascadedProperties::CascadedProperties):
(WebCore::StyleResolver::CascadedProperties::property):
(WebCore::StyleResolver::CascadedProperties::set):
(WebCore::StyleResolver::CascadedProperties::addStyleProperties):
(WebCore::StyleResolver::CascadedProperties::addMatches):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
Added. CascadedProperties is something of a container class
that takes CSS property/value/linkMatchType as input and boils
them down to the final values that will actually be used.
Most properties are poked into an unfancy array where latest
is greatest (unless !important, of course.) Some properties are
queued up to be applied in parse order, more on that below.
(WebCore::StyleResolver::applyCascadedProperties):
(WebCore::StyleResolver::applyMatchedProperties):
The brains of this patch. applyMatchedProperties() now creates
a CascadedProperties and uses it to figure out the final values
and uses applyCascadedProperties() to apply them. Deferred
properties (parse order) are applied last.
We may discover during property application that we won't be
able to use a matched properties cache item. This happens if
the effective zoom or font changes. If that happens, we start
the process over, now with the cache disabled. This may need
some optimization work.
(WebCore::extractDirectionAndWritingMode):
Directional properties ending in e.g -before or -after depend on
the direction and writing mode in effect, so we must begin with
resolving those properties before doing the full cascade.
This is done by simply walking the set of matched properties and
manually applying '-webkit-writing-mode' and 'direction'.
If this starts showing up in profiles, we can easily cache some
of the information in e.g RuleData to avoid the traversal here.
(WebCore::elementTypeHasAppearanceFromUAStyle):
To determine whether a form element is styled beyond the default
UA style sheet, StyleResolver caches the border and background
values from RenderStyle after applying the UA style sheet.
Those values are then compared against after all style is applied
and if some (platform-dependent) values differ, the element is
considered "styled."
This really only affects elements with -webkit-appearance values
in the default UA style sheet, so this function determines if an
element should take the goofy slow path for this.
(WebCore::shouldApplyPropertyInParseOrder):
(WebCore::StyleResolver::CascadedProperties::setDeferred):
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
Some CSS properties will write to the same RenderStyle fields when
applied, so in order to maintain previous behavior, we must apply
them in the order they were parsed.
We accomplish this by keeping an ordered queue of such properties
to apply separately after all the other properties.
(WebCore::StyleResolver::CascadedProperties::setPropertyInternal):
Helper for poking values into a CascadedProperties::Property.
- css/StyleResolver.h:
(WebCore::StyleResolver::state):
Expose the StyleResolver::State so CascadedProperties can access it.
- 4:10 PM Changeset in webkit [160805] by
-
- 3 edits1 add in trunk/Tools
[GTK] [CMake] Add support for building GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=125766
Reviewed by Gustavo Noronha Silva.
- CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
- GtkLauncher/CMakeLists.txt: Added.
- GtkLauncher/main.c: Support including the CMake config file.
- 4:04 PM Changeset in webkit [160804] by
-
- 8 edits3 adds in trunk
[GTK] [CMake] Add support for building WebKit1
https://bugs.webkit.org/show_bug.cgi?id=116377
Reviewed by Gustavo Noronha Silva.
.:
- Source/cmake/OptionsGTK.cmake: Turn off some features that do not build properly
for WebKit1 and stop using the version script which we haven't implemented yet. Turn
on WebKit1.
Source/WebCore:
- PlatformGTK.cmake: Add a missing source required by WebKit1 to
the WebCore build.
Source/WebKit:
- CMakeLists.txt: Updated WebCore include directory list for WebKitGTK+ and
added BUILDING_WEBKIT to the list of defines.
- PlatformGTK.cmake: Added.
Source/WebKit/gtk:
- GNUmakefile.am: Switch to using the templates for building the GObject enums.
- webkit/webkitenumtypes.cpp.template: Added.
- webkit/webkitenumtypes.h.template: Added.
- 3:50 PM Changeset in webkit [160803] by
-
- 5 edits3 copies in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125941
Add Obj C API for injected bundle PageGroup class.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-12-18
Reviewed by Dan Bernstein.
Add Obj C API (WKWebProcessPlugInPageGroup) for injected bundle PageGroup class. And add APIs to
expose the main frame and page group from WKWebProcessPlugInBrowsingContextController.
- Shared/Cocoa/APIObject.mm:
(API::Object::newObject): Create wrapper object for InjectedPageGroup object.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h: Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm: Added.
(-[WKWebProcessPlugInPageGroup identifier]):
(-[WKWebProcessPlugInPageGroup dealloc]):
(-[WKWebProcessPlugInPageGroup API::]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroupInternal.h: Added.
(WebKit::wrapper):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h: Add API to expose the main frame and page group
for WKWebPocessPlugInBrowserContextController.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController mainFrame]):
(-[WKWebProcessPlugInBrowserContextController pageGroup]):
- 3:33 PM Changeset in webkit [160802] by
-
- 4 edits in trunk/Source/WebCore
[CSS Shapes] Simplify RectangleShape implementation
https://bugs.webkit.org/show_bug.cgi?id=125536
Reviewed by Andreas Kling.
Instead of caching an instance of a private FloatRoundedRect (ish) class for
RectangleShape's shape-margin and shape-padding bounds, we just compute
the FloatRect and radii as needed. This reduces the classes footprint a little
and it simplifies the implementation.
Removed the private RectangleShape::ShapeBounds class and made its
cornerInterceptForWidth() method a static function. Added members for
the RectangleShape constructor args, and private getters for their properties.
There are no new tests because this is just an internal refactoring.
- rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::shapePaddingBounds):
(WebCore::RectangleShape::shapeMarginBounds):
(WebCore::ellipseXIntercept):
(WebCore::ellipseYIntercept):
(WebCore::RectangleShape::getExcludedIntervals):
(WebCore::RectangleShape::getIncludedIntervals):
(WebCore::cornerInterceptForWidth):
(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):
(WebCore::RectangleShape::buildPath):
- rendering/shapes/RectangleShape.h:
(WebCore::RectangleShape::RectangleShape):
(WebCore::RectangleShape::rx):
(WebCore::RectangleShape::ry):
(WebCore::RectangleShape::x):
(WebCore::RectangleShape::y):
(WebCore::RectangleShape::width):
(WebCore::RectangleShape::height):
- rendering/shapes/Shape.cpp:
(WebCore::createCircleShape): Renamed this internal function (it was createShapeCircle) because it was inconsistent.
(WebCore::createEllipseShape): Ditto.
(WebCore::Shape::createShape):
- 3:25 PM Changeset in webkit [160801] by
-
- 2 edits in trunk/Source/WebKit2
PDFPlugin: Never make a NSEventType = 0
https://bugs.webkit.org/show_bug.cgi?id=125955
Reviewed by Dan Bernstein.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::getEventTypeFromWebEvent):
Make getEventTypeFromWebEvent return its NSEventType as an out arg, and
make the return value represent whether or not we set it.
(WebKit::PDFPlugin::nsEventForWebMouseEvent):
(WebKit::PDFPlugin::handleKeyboardEvent):
Make use of getEventTypeFromWebEvent.
- 3:23 PM Changeset in webkit [160800] by
-
- 4 edits1 add in trunk/Source
Add a simple stack abstraction for x86_64
https://bugs.webkit.org/show_bug.cgi?id=125908
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::addPtrNoFlags):
Add an explicit abstraction for the "lea" instruction. This is needed
by the experimental JIT to have add and substract without changing the flags.
This is useful for function calls to test the return value, restore the registers,
then branch on the flags from the return value.
Source/WebCore:
StackAllocator provides an abstraction to make it hard to make mistakes and protects from obvious
issues at runtime.
The key roles of StackAllocators are:
-Provide the necessary stack alignment for function calls (only x86_64 stack for now).
-Provide ways to save registers on the stack, restore or discard them as needed.
-Crash at runtime if an operation would obviously cause a stack inconsistency.
The way simple inconsistencies are detected is through the StackReference object
returned whenever something is added on the stack.
The object keeps a reference to the offset of what has been pushed. When the StackReference
is used to recover the register, if the offset is different, there is a missmatch between
push() and pop() after the object was pushed.
- cssjit/StackAllocator.h: Added.
(WebCore::StackAllocator::StackReference::StackReference):
(WebCore::StackAllocator::StackReference::operator unsigned):
(WebCore::StackAllocator::StackAllocator):
(WebCore::StackAllocator::~StackAllocator):
(WebCore::StackAllocator::push):
(WebCore::StackAllocator::pop):
(WebCore::StackAllocator::alignStackPreFunctionCall):
(WebCore::StackAllocator::unalignStackPostFunctionCall):
Those helpers provide a simple way to have a valid stack prior to a function call.
Since StackAllocator knows the offset and the platform rules, it can adjust the stack
if needed for x86_64.
(WebCore::StackAllocator::discard): Discard a single register or the full stack.
(WebCore::StackAllocator::combine): combining stacks is the way to solve branches
where the stack is used differently in each case.
To do that, the stack is first copied to A and B. Each branch works on its own
StackAllocator copy, then the two copies are linked together to the original stack.
The copies ensure the local consistency in each branch, linking the copies ensure global
consistencies and that both branches end in the same stack state.
(WebCore::StackAllocator::offsetToStackReference): Helper function to access the stack by address
through its StackReference.
(WebCore::StackAllocator::reset):
- 3:12 PM Changeset in webkit [160799] by
-
- 2 edits in trunk
[GTK][CMake] Use thin archives if building on Linux, only way to get non-shared-core debug builds
https://bugs.webkit.org/show_bug.cgi?id=125951
Reviewed by Martin Robinson.
- Source/cmake/OptionsGTK.cmake: append T for thin archives to the flags passed to ar,
also use u, which is used in the autotools build (it avoids adding a file twice).
- 3:11 PM Changeset in webkit [160798] by
-
- 13 edits3 adds in trunk
[WinCairo] Preparation for GStreamer on Windows.
https://bugs.webkit.org/show_bug.cgi?id=125946
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-18
Reviewed by Brent Fulgham.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
Use new GStreamer property sheets for WinCairo.
- WebCore.vcxproj/WebCoreCairo.props:
Include GStreamer directory.
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
Use new GStreamer property sheets for WinCairo.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Fixed 64-bit symbols, added GStreamer symbol.
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
Use new GStreamer property sheets for WinCairo.
Tools:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
Use new GStreamer property sheets for WinCairo.
- win/DLLLauncher/DLLLauncherMain.cpp:
(modifyPath):
(wWinMain):
Prepend GStreamer bin directory to path if it exists.
WebKitLibraries:
- win/tools/vsprops/FeatureDefinesCairo.props:
Added ENABLE_MEDIA_CONTROLS_SCRIPT and ENABLE_VIDEO_TRACK for DerivedSources.make.
- win/tools/vsprops/GStreamer32.props: Added.
- win/tools/vsprops/GStreamer64.props: Added.
- win/tools/vsprops/GStreamerCommon.props: Added.
- 3:05 PM Changeset in webkit [160797] by
-
- 2 edits in trunk
[GTK][CMake] Remove binary size optimizations we do not use in the autotools build
https://bugs.webkit.org/show_bug.cgi?id=125947
Reviewed by Martin Robinson.
- Source/cmake/OptionsGTK.cmake: remove the relevant flags.
- 2:50 PM Changeset in webkit [160796] by
-
- 31 edits4 adds in trunk/Source
DFG should have a separate StoreBarrier node
https://bugs.webkit.org/show_bug.cgi?id=125530
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This is in preparation for GenGC. We use a separate StoreBarrier node instead of making them implicitly
part of other nodes so that it's easier to run analyses on them, e.g. for the StoreBarrierElisionPhase.
They are inserted during the fixup phase. Initially they do not generate any code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractHeap.h:
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::isKnownNotCell):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberizeForAllocation):
(JSC::DFG::clobberize):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants): Whenever we insert new nodes that require StoreBarriers,
we have to add those new StoreBarriers too. It's important to note that AllocatePropertyStorage and
ReallocatePropertyStorage nodes require their StoreBarriers to come after them since they allocate first,
which could cause a GC, and then store the resulting buffer into their JSCell, which requires the barrier.
If we ever require that write barriers occur before stores, we'll have to split these nodes into
AllocatePropertyStorage + StoreBarrier + PutPropertyStorage.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):
- dfg/DFGNode.h:
(JSC::DFG::Node::isStoreBarrier):
- dfg/DFGNodeType.h:
- dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):
(JSC::DFG::SpeculativeJIT::genericWriteBarrier): The fast path write barrier check. It loads the
byte that contains the mark bit of the object.
(JSC::DFG::SpeculativeJIT::storeToWriteBarrierBuffer): If the fast path check fails we try to store the
cell in the WriteBarrierBuffer so as to avoid frequently flushing all registers in order to make a C call.
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::osrWriteBarrier): More barebones version of the write barrier to be executed
during an OSR exit into baseline code. We must do this so that the baseline JIT object and array profiles
are properly cleared during GC.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
- dfg/DFGStoreBarrierElisionPhase.cpp: Added. New DFG phase that does block-local elision of redundant
StoreBarriers. Every time a StoreBarrier on a particular object is executed, a bit is set indicating that
that object doesn't need any more StoreBarriers.
(JSC::DFG::StoreBarrierElisionPhase::StoreBarrierElisionPhase):
(JSC::DFG::StoreBarrierElisionPhase::couldCauseGC): Nodes that could cause a GC reset the bits for all of the
objects known in the current block.
(JSC::DFG::StoreBarrierElisionPhase::allocatesFreshObject): A node that creates a new object automatically
sets the bit for that object since if a GC occurred as the result of that object's allocation then that
object would not need a barrier since it would be guaranteed to be a young generation object until the
next GC point.
(JSC::DFG::StoreBarrierElisionPhase::noticeFreshObject):
(JSC::DFG::StoreBarrierElisionPhase::getBaseOfStore):
(JSC::DFG::StoreBarrierElisionPhase::shouldBeElided):
(JSC::DFG::StoreBarrierElisionPhase::elideBarrier):
(JSC::DFG::StoreBarrierElisionPhase::handleNode):
(JSC::DFG::StoreBarrierElisionPhase::handleBlock):
(JSC::DFG::StoreBarrierElisionPhase::run):
(JSC::DFG::performStoreBarrierElision):
- dfg/DFGStoreBarrierElisionPhase.h: Added.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::flushWriteBarrierBuffer):
- heap/Heap.h:
(JSC::Heap::writeBarrier):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::offsetOfMarks):
- heap/WriteBarrierBuffer.cpp: Added. The WriteBarrierBuffer buffers a set of JSCells that are awaiting
a pending WriteBarrier. This buffer is used by the DFG to avoid the overhead of calling out to C repeatedly
to invoke a write barrier on a single JSCell. Instead the DFG has inline code to fill the WriteBarrier buffer
until its full, and then to call out to C to flush it. The WriteBarrierBuffer will also be flushed prior to
each EdenCollection.
(JSC::WriteBarrierBuffer::WriteBarrierBuffer):
(JSC::WriteBarrierBuffer::~WriteBarrierBuffer):
(JSC::WriteBarrierBuffer::flush):
(JSC::WriteBarrierBuffer::reset):
(JSC::WriteBarrierBuffer::add):
- heap/WriteBarrierBuffer.h: Added.
(JSC::WriteBarrierBuffer::currentIndexOffset):
(JSC::WriteBarrierBuffer::capacityOffset):
(JSC::WriteBarrierBuffer::bufferOffset):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- runtime/VM.h:
Source/WTF:
- wtf/Platform.h: Added an #define for ENABLE(GGC) which will be used for landing things related to GenGC.
- 2:02 PM Changeset in webkit [160795] by
-
- 2 edits in trunk/Source/WebKit2
WKRemoteObjectRegistry should invoke invocations
https://bugs.webkit.org/show_bug.cgi?id=125945
Reviewed by Tim Horton.
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):
- 1:36 PM Changeset in webkit [160794] by
-
- 2 edits3 deletes in trunk/Tools
Remove now useless test.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
- TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
- 1:08 PM Changeset in webkit [160793] by
-
- 2 edits in trunk/Source/WebCore
Refactor CodeGeneratorJS - Move attribute function creation out of getOwnPropertyName guard
https://bugs.webkit.org/show_bug.cgi?id=125940
Reviewed by Simon Fraser.
This is just a huge block move of code out from behind the
ImplementationOverridesGetOwnProperty guard.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- 1:03 PM Changeset in webkit [160792] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Frequent ASSERT(hasOneRef()) in SharedBuffer::releasePurgeableBuffer
https://bugs.webkit.org/show_bug.cgi?id=125939
Reviewed by Simon Fraser.
r146082 fixed these assertions by not making a purgeable buffer if a SharedBuffer
has multiple refs, but the check was put in ResourceBuffer::createPurgeableBuffer
instead of down in SharedBuffer::createPurgeableBuffer.
This is fine for most WebKit ports, because ResourceBuffer::createPurgeableBuffer
is the only caller of SharedBuffer::createPurgeableBuffer, but causes trouble for
not-quite-yet-upstreamed iOS SharedBuffer code, which adds another caller
of SharedBuffer::createPurgeableBuffer.
Push the early-return down into SharedBuffer::createPurgeableBuffer to ensure
that all callers are protected from creating a purgeable buffer if the SharedBuffer
has previously been vended elsewhere.
No new tests, has no effect on the current Open Source tree.
- loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::createPurgeableBuffer):
- platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::createPurgeableBuffer):
- 12:58 PM Changeset in webkit [160791] by
-
- 2 edits in trunk/Source/WebCore
Starting a momentum scroll while rubber banding can cause scrolling to jump back
when the rubberband snaps
https://bugs.webkit.org/show_bug.cgi?id=119507
-and corresponding-
<rdar://problem/14655893>
Reviewed by Simon Fraser.
This line of code was added with the very first implementation of rubber-banding.
As far as I can tell, it was always a belt-and-suspenders line of code that is a
no-op in all normal rubber-banding. In this J-shaped scrolling case, this line of
code is what causes the bug to occur because this line of code assumes that your
rubber-band is always trying to take you back to the origin.
- platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):
- 12:50 PM Changeset in webkit [160790] by
-
- 4 edits in trunk
Fix page visibility api test, initialization in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=125933
Reviewed by Anders Carlsson.
The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
(introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setVisibilityState):
- Fix regression, accidentally removed a '!'.
Tools:
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::TEST_F):
- Running a test on WebKit1 twice is not the same as running it on WebKit2!
- 12:40 PM Changeset in webkit [160789] by
-
- 4 edits2 adds in trunk
AX: make aria-hidden=false work with subtrees
https://bugs.webkit.org/show_bug.cgi?id=125592
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When a hidden object uses aria-hidden=false, that needs to apply to
the entire sub-tree (not just the object with aria-hidden on it as it does now).
Enabling this had the side effect of exposing non-rendered text nodes, so there's
some extra checks to ensure we don't include those elements in this cases.
Test: accessibility/aria-hidden-false-works-in-subtrees.html
- accessibility/AXObjectCache.cpp:
(WebCore::isNodeAriaVisible):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
LayoutTests:
- platform/mac/accessibility/aria-hidden-false-works-in-subtrees-expected.txt: Added.
- accessibility/aria-hidden-false-works-in-subtrees.html: Added.
- 12:37 PM Changeset in webkit [160788] by
-
- 2 edits in trunk/Source/WebKit2
Fix 32-bit build.
- Shared/API/Cocoa/RemoteObjectRegistry.mm:
(WebKit::RemoteObjectRegistry::invokeMethod):
- 12:20 PM Changeset in webkit [160787] by
-
- 11 edits1 copy1 move1 add in trunk/Source/WebKit2
Make WKObjectRegistry objects be per page
https://bugs.webkit.org/show_bug.cgi?id=125937
Reviewed by Andreas Kling.
Remove WKObjectRegistry from WKConnection. Also, add a C++ object that is in charge
of actually sending and receiving messages.
- DerivedSources.make:
- Shared/API/Cocoa/RemoteObjectRegistry.h: Added.
- Shared/API/Cocoa/RemoteObjectRegistry.messages.in: Added.
- Shared/API/Cocoa/RemoteObjectRegistry.mm: Added.
(WebKit::RemoteObjectRegistry::RemoteObjectRegistry):
(WebKit::RemoteObjectRegistry::~RemoteObjectRegistry):
(WebKit::RemoteObjectRegistry::sendInvocation):
(WebKit::RemoteObjectRegistry::invokeMethod):
- Shared/API/Cocoa/WKRemoteObjectRegistry.mm:
(-[WKRemoteObjectRegistry _initWithMessageSender:IPC::]):
(-[WKRemoteObjectRegistry _invalidate]):
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[WKRemoteObjectRegistry WebKit::]):
(-[WKRemoteObjectRegistry _invokeMethod:]):
- Shared/API/Cocoa/WKRemoteObjectRegistryInternal.h:
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController remoteObjectRegistry]):
- UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:
- UIProcess/API/Cocoa/WKConnection.h:
- UIProcess/API/Cocoa/WKConnection.mm:
(didReceiveMessage):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController remoteObjectRegistry]):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
- 12:12 PM Changeset in webkit [160786] by
-
- 2 edits in trunk/Source/WebCore
Simplify bindings codegen for adding getOwnPropertySlot overrides
https://bugs.webkit.org/show_bug.cgi?id=125934
Reviewed by Alexey Proskuryakov.
Simple refactoring no change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(InstanceOverridesGetOwnPropertySlot):
(PrototypeOverridesGetOwnPropertySlot):
(GenerateHeader):
(GenerateImplementation):
- 12:08 PM WebKitGTK/2.2.x edited by
- (diff)
- 12:05 PM Changeset in webkit [160785] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: media/video-buffered.html
https://bugs.webkit.org/show_bug.cgi?id=116277
- platform/mac/TestExpectations: Mark it as such.
- 11:54 AM Changeset in webkit [160784] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: getHostCallReturnValue shouldn't pop the callFrame
https://bugs.webkit.org/show_bug.cgi?id=125931
Reviewed by Geoffrey Garen.
Since getHostCallReturnValue() is called after a call to a slow path
function and the return from the slow patch pops the call frame there is
no need for getHostCallReturnValue() to pop the frame.
Removed the popping of the call frame getHostCallReturnValue() for all CPU platforms.
- jit/JITOperations.cpp:
- 11:46 AM Changeset in webkit [160783] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Exceptions in LLIntSlowPaths shouldn't pop call frame
https://bugs.webkit.org/show_bug.cgi?id=125932
Reviewed by Mark Lam.
Removed the unwinding of the call frame in LLINT_CALL_RETURN().
Since llint_slow_path_handle_exception will unwind to the proper callFrame
via genericUnwind() there is no need for the frame to be unwound in
llint slow paths.
- llint/LLIntSlowPaths.cpp:
- 11:42 AM Changeset in webkit [160782] by
-
- 2 edits in trunk/Source/WebCore
AudioSessionManagerMac.cpp: kLowPowerVideoBufferSize unused before OS X 10.9
https://bugs.webkit.org/show_bug.cgi?id=125935
Patch by Conrad Shultz <Conrad Shultz> on 2013-12-18
Reviewed by Jer Noble.
- platform/audio/mac/AudioSessionManagerMac.cpp:
Add MAC_OS_X_VERSION_MIN_REQUIRED >= 1090 guard.
- 11:41 AM Changeset in webkit [160781] by
-
- 3 edits in trunk/Source/WebKit2
API to set a favicon
https://bugs.webkit.org/show_bug.cgi?id=125892
Patch by Conrad Shultz <Conrad Shultz> on 2013-12-18
Reviewed by Brian Weinstein.
- UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseSetIconDataForIconURL):
Call WebIconDatabase::setIconDataForIconURL().
- UIProcess/API/C/WKIconDatabase.h:
Declare WKIconDatabaseSetIconDataForIconURL().
- 11:26 AM Changeset in webkit [160780] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Some basic DebuggerAgent cleanup
https://bugs.webkit.org/show_bug.cgi?id=125901
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-18
Reviewed by Timothy Hatcher.
- inspector/InspectorDebuggerAgent.h:
Remove virtual from not really virtual method.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::enable):
(WebCore::InspectorDebuggerAgent::disable):
Use member variable instead of private function.
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
Inline the three lines from the private function.
- 10:59 AM Changeset in webkit [160779] by
-
- 3 edits2 adds in trunk
REGRESSION (r155536): Broken error recovery in @media at-rule
https://bugs.webkit.org/show_bug.cgi?id=125637
Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2013-12-18
Reviewed by Darin Adler.
Source/WebCore:
Error recovery in @media is broken if any of its rules misses the opening '{'.
The problem is that when the parser recognises the mistake it removes only the last
WHITESPACE token instead of the whole selector and tries to recover the selector again.
it swallows everything until it finds the next opening bracket. thats why the '}' brackets
of both subrules and even the @media rule are ignored, and the whole @media will be
considered invalid. By joining the selector and its trailing whitespace the error recovery
ignores the bad selector only and keep the @media rule.
Test: fast/css/media-error-recovery.html
- css/CSSGrammar.y.in:
LayoutTests:
Test with broken @media rule.
- fast/css/media-error-recovery-expected.txt: Added.
- fast/css/media-error-recovery.html: Added.
- 10:50 AM Changeset in webkit [160778] by
-
- 13 edits2 adds in trunk
AX: WebKit not sending AXMenuClosed notification
https://bugs.webkit.org/show_bug.cgi?id=125783
Reviewed by Mario Sanchez Prada.
Source/WebCore:
When an object with a role=menu is removed, we need to send out a notification informing that the menu has closed.
This means detecting the right kind of destruction event for an element, because we do not want to
send this notification when the entire cache is being torn down.
Test: platform/mac/accessibility/aria-menu-closed-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::remove):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::document):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::detach):
- accessibility/AccessibilityNodeObject.h:
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::detach):
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::detach):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::detach):
- accessibility/AccessibilityScrollView.h:
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):
LayoutTests:
- platform/mac/accessibility/aria-menu-closed-notification-expected.txt: Added.
- platform/mac/accessibility/aria-menu-closed-notification.html: Added.
- 10:32 AM Changeset in webkit [160777] by
-
- 2 edits in trunk/Source/WebCore
Do not create cue subtree just to delete it
https://bugs.webkit.org/show_bug.cgi?id=125904
Reviewed by Jer Noble.
No new tests, covered by existing tests.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::setIsActive): Return early if display tree is NULL.
(WebCore::TextTrackCue::removeDisplayTree): Ditto.
- 10:30 AM Changeset in webkit [160776] by
-
- 2 edits in trunk/Source/WebKit2
Fix Dictionary encoding
https://bugs.webkit.org/show_bug.cgi?id=125930
Reviewed by Andreas Kling.
Encode the HashMap size as a 64-bit unsigned integer.
- Shared/UserData.cpp:
(WebKit::UserData::encode):
- 10:26 AM Changeset in webkit [160775] by
-
- 6 edits in trunk/Source/WebCore
Remove JSInlineGetOwnPropertySlot attribute as it is no longer necessary
https://bugs.webkit.org/show_bug.cgi?id=125875
Reviewed by Brady Eidson.
Tested this on dromaeo and acid3 (the original reason for this attribute)
and it no longer provided any benefit. This makes it easier to reason about
creation of getOwnPropertySlot during binding generation.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- dom/Document.idl:
- dom/Element.idl:
- dom/Node.idl:
- 10:14 AM Changeset in webkit [160774] by
-
- 5 edits4 adds in trunk
Fix ASSERTION FAILED in WebCore::SVGLengthContext::determineViewport
https://bugs.webkit.org/show_bug.cgi?id=120284
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-18
Reviewed by Philip Rogers.
Source/WebCore:
Added handling of root <svg> elements.
Blink merge: https://chromium.googlesource.com/chromium/blink/+/a7dedf81eb7008276bb6854f0e46465e039788f8
SVGLengthContext::determineViewport() currently asserts that we're not
resolving lengths for the topmost element, but there's nothing to
prevent such calls.
The patch updates determineViewport() to handle root elements geracefully
(using their current viewport). It also changes the signature slightly
to operate directly on a FloatSize, reducing some of the boiler-plate
client code.
Tests: svg/custom/svg-length-value-handled.svg
svg/dom/svg-root-lengths.html
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::convertValueFromUserUnitsToPercentage):
(WebCore::SVGLengthContext::convertValueFromPercentageToUserUnits):
(WebCore::SVGLengthContext::determineViewport):
- svg/SVGLengthContext.h:
- svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::platformApplySoftware):
LayoutTests:
Added tests of handling root <svg> elements.
Blink merge: https://chromium.googlesource.com/chromium/blink/+/a7dedf81eb7008276bb6854f0e46465e039788f8
- svg/custom/svg-length-value-handled-expected.txt: Added.
- svg/custom/svg-length-value-handled.svg: Added.
Tests whether root svg elements sizes are handled.
- svg/dom/svg-root-lengths-expected.txt: Added.
- svg/dom/svg-root-lengths.html: Added.
Tests the correct handling of root svg elements sizes.
- 10:07 AM Changeset in webkit [160773] by
-
- 3 edits in trunk/Tools
Should not have identifiers with underscores in them, especially not leading underscores.
https://bugs.webkit.org/show_bug.cgi?id=125847
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-18
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_identifier_name_in_declaration):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_runtime_selfinit):
(WebKitStyleTest.test_names):
- 10:06 AM Changeset in webkit [160772] by
-
- 3 edits in trunk/Tools
False webkit-check-style warnings on *.
https://bugs.webkit.org/show_bug.cgi?id=125915
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-18
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_pointer_reference_marker_location):
- 10:02 AM Changeset in webkit [160771] by
-
- 5 edits in trunk
Additional refinement in MathMLSelectElement toggle implementation
https://bugs.webkit.org/show_bug.cgi?id=125785
Reviewed by Andreas Kling.
Source/WebCore:
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::defaultEventHandler): Call setDefaultHandled
so this will be handled by only one element.
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents): Return true
only when action is set to toggle, since other select elements will not
respond to mouse click events.
(WebCore::MathMLSelectElement::toggle): Simplified code a bit and gave
local a clearer variable name.
LayoutTests:
- mathml/presentation/maction-toggle-expected.html: Updated incorrect expected
result, which expected an already-handled event to be re-handled by a parent
element during the bubbling process.
- mathml/presentation/maction-toggle.html: Ditto.
- 9:27 AM Changeset in webkit [160770] by
-
- 10 edits in trunk
2013-12-18 Rob Buis <rob.buis@samsung.com>
[CSS Shapes] Implement interpolation between keywords in basic shapes
https://bugs.webkit.org/show_bug.cgi?id=125108
Reviewed by Simon Fraser.
Allow blending for all center coordinates since top/left and bottom/right default to correct
Length values of 0% and 100%. For mixed keyword and value positions compute the length's used
for blending to percentages. This is possible since we compute the reference box bounds given the
renderer.
- page/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): Pass additional RenderBox parameter.
- rendering/style/BasicShapes.cpp: (WebCore::BasicShape::canBlend): Don't check circle/ellipse center anymore, but do check that both shapes use the same reference box. (WebCore::BasicShape::referenceBoxSize): Compute box dimension depending on reference box. (WebCore::BasicShapeCenterCoordinate::lengthForBlending): Convert to percentage for Bottom/Right. (WebCore::BasicShapeRectangle::blend): (WebCore::DeprecatedBasicShapeCircle::blend): (WebCore::BasicShapeCircle::blend): (WebCore::DeprecatedBasicShapeEllipse::blend): (WebCore::BasicShapeEllipse::blend): (WebCore::BasicShapePolygon::blend): (WebCore::BasicShapeInsetRectangle::blend): (WebCore::BasicShapeInset::blend):
- rendering/style/BasicShapes.h: (WebCore::BasicShapeCenterCoordinate::blend): Use new lengthForBlending.
- 9:26 AM Changeset in webkit [160769] by
-
- 4 edits in trunk/Tools
prepare-ChangeLog doesn't handle templates properly
https://bugs.webkit.org/show_bug.cgi?id=125853
Patch by Dániel Bátyai <Dániel Bátyai> on 2013-12-18
Reviewed by Daniel Bates.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp):
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
(Class110<TemplateClass>::func36):
- 8:54 AM Changeset in webkit [160768] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 8:52 AM Changeset in webkit [160767] by
-
- 1 copy in tags/Safari-537.60.12
New Tag.
- 7:51 AM Changeset in webkit [160766] by
-
- 3 edits2 adds in trunk
CSS: Null-pointer dereference with negative 'orphans' value.
https://bugs.webkit.org/show_bug.cgi?id=125924
Patch by Dániel Bátyai <Dániel Bátyai> on 2013-12-18
Reviewed by Andreas Kling.
Source/WebCore:
orphans and widows should be positive integer.
spec link:
http://www.w3.org/TR/CSS2/page.html#propdef-orphans
Backported from Blink: https://codereview.chromium.org/108663009
Test: fast/css/negative-orphans-crash.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
LayoutTests:
Test with negative orphans value.
- fast/css/negative-orphans-crash-expected.txt: Added.
- fast/css/negative-orphans-crash.html: Added.
- 7:05 AM Changeset in webkit [160765] by
-
- 2 edits in trunk/Source/WebCore
Make more computed style helpers return values by PassRef.
<https://webkit.org/b/125923>
Tighten yet another handful of CSS computed style helper functions
to return their CSSValues by PassRef where we never return null.
Reviewed by Antti Koivisto.
- 7:04 AM Changeset in webkit [160764] by
-
- 3 edits in trunk/Source/WebCore
Use range for syntax in Frame and FrameView.
<https://webkit.org/b/125922>
Convert code in Frame and FrameView to use C++11's range for syntax.
Reviewed by Antti Koivisto.
- 7:02 AM Changeset in webkit [160763] by
-
- 9 edits in trunk/Source/WebCore
RenderElement-ize adjustForAbsoluteZoom() and friends.
<https://webkit.org/b/125921>
Make adjustForAbsoluteZoom() take a const RenderElement& instead
of a RenderObject* so we can avoid the extra branch in style().
All call sites already had RenderElements.
Reviewed by Antti Koivisto.
- 6:18 AM Changeset in webkit [160762] by
-
- 5 edits in trunk
AX: HTML spec change indicates @aria-required should trump @required on any element
https://bugs.webkit.org/show_bug.cgi?id=122145
Reviewed by Mario Sanchez Prada.
Source/WebCore:
aria-required should win over the native "required" attribute.
Updated tests: accessibility/aria-required.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isRequired):
LayoutTests:
- accessibility/aria-required-expected.txt:
- accessibility/aria-required.html:
- 5:56 AM Changeset in webkit [160761] by
-
- 1 copy in releases/WebKitGTK/webkit-2.3.3
Tagging the WebKitGTK+ 2.3.3 release
- 5:23 AM Changeset in webkit [160760] by
-
- 9 edits in trunk/LayoutTests
Unreviewed EFL gardening
Rebaseline tests after r160715.
- platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.png:
- platform/efl/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
- platform/efl/fast/backgrounds/background-position-parsing-expected.png:
- platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
- platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:
- platform/efl/fast/block/float/016-expected.png:
- platform/efl/fast/block/float/016-expected.txt:
- 4:27 AM Changeset in webkit [160759] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and Versions.m4 for 2.3.3 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.3.3.
- 4:24 AM Changeset in webkit [160758] by
-
- 9 edits in trunk/Source
Unreviewed. Fix make distcheck.
Source/JavaScriptCore:
- GNUmakefile.am:
Source/ThirdParty/ANGLE:
- GNUmakefile.am:
Source/WebCore:
- GNUmakefile.am:
- GNUmakefile.list.am:
Source/WebKit2:
- GNUmakefile.list.am:
- 4:01 AM Changeset in webkit [160757] by
-
- 2 edits in trunk/Source/WebCore
[soup] Fix unused parameter warnings in ResourceHandleSoup.
https://bugs.webkit.org/show_bug.cgi?id=125918
Patch by Dániel Bátyai <Dániel Bátyai> on 2013-12-18
Reviewed by Martin Robinson.
Comment out the method parameters to avoid the warnings.
No tests required.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveData):
- 3:41 AM Changeset in webkit [160756] by
-
- 10 edits in trunk/Tools
Move expectation parsing out of the constructor of TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=125439
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-18
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
(LayoutTestRunnerTests.test_update_summary_with_result):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_look_for_new_crash_logs):
- Scripts/webkitpy/layout_tests/lint_test_expectations.py:
(lint):
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectations.suffixes_for_expectations):
(TestExpectations.init):
(TestExpectations):
(TestExpectations.parse_generic_expectations):
(TestExpectations.parse_default_port_expectations):
(TestExpectations.parse_override_expectations):
(TestExpectations.parse_all_expectations):
- Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(parse_exp):
(SkippedTests.check):
(SkippedTests.test_skipped_entry_dont_exist):
- Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
(run_results):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations._model):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest._update_expectations_file):
(RebaselineExpectations._update_expectations_files):
(RebaselineExpectations._tests_to_rebaseline):
- 1:08 AM WebKitGTK/2.2.x edited by
- (diff)
Dec 17, 2013:
- 11:37 PM Changeset in webkit [160755] by
-
- 3 edits2 adds in trunk
[MSE] Periodically monitor source buffers.
https://bugs.webkit.org/show_bug.cgi?id=125898
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-monitor-source-buffers.html
The MSE spec requires that the SourceBuffer Monitoring step is run
periodically during playback. No specific update interval is specified
so we will re-use the existing HTMLMediaElement playback progress
timer to signal the media source monitoring.
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::playbackProgressTimerFired):
LayoutTests:
- media/media-source/media-source-monitor-source-buffers-expected.txt: Added.
- media/media-source/media-source-monitor-source-buffers.html: Added.
- 10:49 PM Changeset in webkit [160754] by
-
- 8 edits in trunk/Source/WebCore
[MSE] Add per-track signalling between SourceBuffer and SourceBufferPrivate.
https://bugs.webkit.org/show_bug.cgi?id=125899
Reviewed by Eric Carlson.
To accommodate the future addition of audio support to MSE in the Mac
port, add the concept of trackIDs to the communication between
SourceBuffer and SourceBufferPrivate.
The following virtual methods now take a trackID parameter:
- platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::isReadyForMoreSamples):
(WebCore::SourceBufferPrivate::stopAskingForMoreSamples):
(WebCore::SourceBufferPrivate::notifyClientWhenReadyForMoreSamples):
- platform/graphics/SourceBufferPrivateClient.h:
(WebCore::SourceBufferPrivateClient::sourceBufferPrivateDidBecomeReadyForMoreSamples):
Update overridden methods in subclasses:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidBecomeReadyForMoreSamples):
- Modules/mediasource/SourceBuffer.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::isReadyForMoreSamples):
- platform/mock/mediasource/MockSourceBufferPrivate.h:
Change the logic in provideMediaData to update a single TrackBuffer
rather than iterating over all of them:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):
(WebCore::SourceBuffer::appendBufferTimerFired):
(WebCore::SourceBuffer::provideMediaData):
- 10:27 PM Changeset in webkit [160753] by
-
- 12 edits in trunk/Source/WebCore
Web Inspector: Remove InspectorAgent::hasFrontend
https://bugs.webkit.org/show_bug.cgi?id=125907
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-17
Reviewed by Timothy Hatcher.
Remove InspectorAgent::hasFrontend only used by
InspectorInstrumentation::collectingHTMLParseErrors. However,
following the single callers of that, the result is unused
in the HTMLDocumentParser and HTMLTreeBuilder. So remove
more stale / unused code.
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::createParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
- html/parser/HTMLDocumentParser.h:
(WebCore::HTMLDocumentParser::create):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
- html/parser/HTMLTreeBuilder.h:
(WebCore::HTMLTreeBuilder::create):
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::TextDocumentParser):
- inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
- inspector/InspectorAgent.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- 10:24 PM Changeset in webkit [160752] by
-
- 5 edits in trunk/Source/WebCore
Web Inspector: Some basic InjectedScriptHost cleanup
https://bugs.webkit.org/show_bug.cgi?id=125902
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-17
Reviewed by Timothy Hatcher.
Remove InjectedScriptHost::scriptDebugServer. Nobody accesses
the ScriptDebugServer through the injected script host. This
also lets us remove the reference to the DebuggerAgent.
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptHost.h:
(WebCore::InjectedScriptHost::init):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
- 10:22 PM Changeset in webkit [160751] by
-
- 10 edits3 deletes in trunk
Web Inspector: Remove InspectorFrontendHost.setInjectedScriptForOrigin
https://bugs.webkit.org/show_bug.cgi?id=125906
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-17
Reviewed by Timothy Hatcher.
Source/WebCore:
Remove stale code related to a since removed feature,
Inspector extensions. This allows us to remove a number
of entry points into InspectorAgent.
- inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent):
(WebCore::InspectorAgent::willDestroyFrontendAndBackend):
- inspector/InspectorAgent.h:
(WebCore::InspectorAgent::create):
Remove setInjectedScriptForOrigin and InjectedScript management.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
- inspector/InspectorController.h:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
Remove the API and calling through InspectorController.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didClearWindowObjectInWorldImpl):
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Remove now unnecessary calls into InspectorAgent.
LayoutTests:
- http/tests/inspector/injected-script-for-origin-expected.txt: Removed.
- http/tests/inspector/injected-script-for-origin.html: Removed.
- http/tests/inspector/resources/injected-script-for-origin-frame.html: Removed.
- 10:04 PM Changeset in webkit [160750] by
-
- 10 edits in trunk/Source/WebKit2
[GTK] Build fix after r160737
Unreviewed.
Rename WebURLRequest to API::URLRequest
- GNUmakefile.list.am:
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
(didReceiveWebViewMessageFromInjectedBundle):
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
(webkitNavigationPolicyDecisionCreate):
- UIProcess/API/gtk/WebKitNavigationPolicyDecisionPrivate.h:
- UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:
(webkitResponsePolicyDecisionCreate):
- UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request):
- UIProcess/API/gtk/WebKitWindowProperties.cpp:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(willSendRequestForFrame):
- 9:37 PM Changeset in webkit [160749] by
-
- 6 edits1 add in trunk
Fix TimeRanges::intersectWith
https://bugs.webkit.org/show_bug.cgi?id=118802
Source/WebCore:
Test: TestWebKitAPI/Tests/WebCore/TimeRanges.cpp.
Reviewed by Eric Carlson.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- html/TimeRanges.cpp:
(TimeRanges::invert):
(TimeRanges::intersectWith):
Merge
https://chromium.googlesource.com/chromium/blink/+/f557582b6c6283a8b165514f52d01cfd98130e85
Tools:
Reviewed by Eric Carlson.
Add unit tests for WebCore/TimeRanges.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
(TestWebKitAPI::ToString):
(TestWebKitAPI::TEST):
- 8:32 PM Changeset in webkit [160748] by
-
- 3 edits2 adds in trunk
ASSERT setting pseudoID with registered DOMSubtreeModified listener
https://bugs.webkit.org/show_bug.cgi?id=125900
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: fast/dom/attribute-set-before-element-in-tree.html
- dom/Node.cpp:
(WebCore::Node::dispatchSubtreeModifiedEvent): Return early if the node does not have a
parent and does not have a DOMSubtreeModified listener.
LayoutTests:
- fast/dom/attribute-set-before-element-in-tree-expected.txt: Added.
- fast/dom/attribute-set-before-element-in-tree.html: Added.
- 8:18 PM Changeset in webkit [160747] by
-
- 7 edits in trunk/Source/WebCore
Remove dead code for reflected attributes from audio, video, and track elements
https://bugs.webkit.org/show_bug.cgi?id=125838
Reviewed by Eric Carlson.
Merge https://chromium.googlesource.com/chromium/blink/+/310514e2f0fd934975b841d463bad0cd62e6fd64
Where [Reflect] is used in the IDL, the getters and setters in C++ are
only for internal convenience, and these were unused.
- html/HTMLMediaElement.cpp:
- html/HTMLMediaElement.h:
- html/HTMLTrackElement.cpp:
- html/HTMLTrackElement.h:
- html/HTMLVideoElement.cpp:
- html/HTMLVideoElement.h:
- 7:45 PM Changeset in webkit [160746] by
-
- 5 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix varargs calls to work on C stack
https://bugs.webkit.org/show_bug.cgi?id=125903
Reviewed by Filip Pizlo.
Fixed up the stack pointer after the sizeAndAllocFrameForVarargs() has been called in both the
LLInt and baseline JIT code. Adjusted the callee frame calculations in sizeAndAllocFrameForVarargs()
and compileLoadVarargs() to create aligned callee frames.
- interpreter/Interpreter.cpp:
(JSC::sizeAndAllocFrameForVarargs):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- llint/LowLevelInterpreter.asm:
- 7:38 PM Changeset in webkit [160745] by
-
- 11 edits in branches/jsCStack/Source/JavaScriptCore
frameRegisterCount() should include maxFrameExtentForSlowPathCall.
https://bugs.webkit.org/show_bug.cgi?id=125881.
Reviewed by Geoffrey Garen, Michael Saboff, and Filip Pizlo.
- assembler/MaxFrameExtentForSlowPathCall.h:
- Added CallerFrameAndPCSize to all the maxFrameExtentForSlowPathCall values.
- bytecode/VirtualRegister.h:
(JSC::VirtualRegister::offsetInBytes):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::frameRegisterCount):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::frameRegisterCountFor):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- Adjusted maxFrameExtentForSlowPathCall values for CallerFrameAndPCSize.
- llint/LLIntEntrypoint.cpp:
(JSC::LLInt::frameRegisterCountFor):
- llint/LowLevelInterpreter.asm:
- Adjusted maxFrameExtentForSlowPathCall values for CallerFrameAndPCSize.
- 7:25 PM Changeset in webkit [160744] by
-
- 3 edits in trunk/Tools
Botwatcher's dashboard ceases to update itself after a while
https://bugs.webkit.org/show_bug.cgi?id=125885
Reviewed by Timothy Hatcher.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
Removed code that checked for the view being hidden. It's none of model's business.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
(BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
We now stop the timer for hidden views.
(BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
- 6:16 PM Changeset in webkit [160743] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix on EFL port after r160737
Rename WebURLRequest to API::URLRequest
- CMakeLists.txt:
- UIProcess/API/efl/ewk_url_request_private.h:
- 6:00 PM Changeset in webkit [160742] by
-
- 7 edits in trunk/Source
Rename "canRubberBands" to "canRubberBand"
https://bugs.webkit.org/show_bug.cgi?id=125897
Reviewed by Anders Carlsson.
Rename "canRubberBands" to "canRubberBand" in various places.
Source/WebCore:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::setCanRubberBandState):
- page/scrolling/ScrollingTree.h:
Source/WebKit2:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebPage/EventDispatcher.messages.in:
- 5:28 PM Changeset in webkit [160741] by
-
- 3 edits in trunk/Tools
Fix the 32-bit build.
- MiniBrowser/MiniBrowserWebProcessPlugIn.h:
- MiniBrowser/MiniBrowserWebProcessPlugIn.m:
- 5:05 PM Changeset in webkit [160740] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2 View Gestures: Fix the shadow layer restore-from-overpinched animation
https://bugs.webkit.org/show_bug.cgi?id=125884
Reviewed by Anders Carlsson.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Set to-values on the right animations.
(WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
We don't need to explicitly set the shadow path, because PlatformCALayer::setBounds does it for us now.
- 4:57 PM Changeset in webkit [160739] by
-
- 5 edits2 adds in trunk
[MSE] Update duration after appending samples, per spec.
https://bugs.webkit.org/show_bug.cgi?id=125703
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-duration-after-append.html
After appending a sample, update the MediaSource duration if the sample's
presentation end time is greater than the existing duration.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::setDuration): Notify the MediaPlayer.
LayoutTests:
- media/media-source/media-source-duration-after-append-expected.txt: Added.
- media/media-source/media-source-duration-after-append.html: Added.
- 4:56 PM Changeset in webkit [160738] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Null-deref in CMSampleBufferIsRandomAccess().
https://bugs.webkit.org/show_bug.cgi?id=125698
Reviewed by Sam Weinig.
If a given CMSampleBufferRef does not have a sample attachments array (which is unlikely, but
possible), CMSampleBufferGetAttachmentsArray() will return a null value.
Additionally, the CMSampleBuffer documentation states that "samples are assumed to be sync
samples by default", so the absence of an attachment array (or the absense of a
kCMSampleAttachmentKey_NotSync entry in any of the attachment dictionaries) indicates the
sample is sync.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::CMSampleBufferIsRandomAccess):
- 4:54 PM Changeset in webkit [160737] by
-
- 22 edits2 moves in trunk/Source/WebKit2
[WK2] Rename WebURLRequest to API::URLRequest
https://bugs.webkit.org/show_bug.cgi?id=125886
Reviewed by Anders Carlsson.
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
- Shared/API/c/WKURLRequest.cpp:
(WKURLRequestGetTypeID):
(WKURLRequestCreateWithWKURL):
(WKURLRequestSetDefaultTimeoutInterval):
- Shared/API/c/mac/WKURLRequestNS.mm:
(WKURLRequestCreateWithNSURLRequest):
- Shared/APIString.h:
- Shared/APIURLRequest.cpp: Copied from Source/WebKit2/Shared/WebURLRequest.cpp.
(API::URLRequest::URLRequest):
(API::URLRequest::defaultTimeoutInterval):
(API::URLRequest::setDefaultTimeoutInterval):
(API::URLRequest::encode):
(API::URLRequest::decode):
- Shared/APIURLRequest.h: Copied from Source/WebKit2/Shared/WebURLRequest.h.
(API::URLRequest::create):
- Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebURLRequest.cpp: Removed.
- Shared/WebURLRequest.h: Removed.
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKDownload.cpp:
(WKDownloadCopyRequest):
- UIProcess/API/C/WKNavigationDataRef.cpp:
(WKNavigationDataCopyOriginalRequest):
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadRequest:userData:]):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadURLRequest):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPolicyClient.cpp:
(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForResponse):
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::createNewPage):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
- WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
- WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:
(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
- 4:24 PM Changeset in webkit [160736] by
-
- 3 edits6 adds in trunk/Tools
Give the MiniBrowser a bundle
https://bugs.webkit.org/show_bug.cgi?id=125882
Reviewed by Sam Weinig.
- MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
- MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
- MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
(-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
- MiniBrowser/mac/Bundle/Info.plist: Added.
- MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
- 4:20 PM Changeset in webkit [160735] by
-
- 2 edits in branches/safari-537.74-branch/Source/JavaScriptCore
Merge the patch attached to <rdar://problem/15684269>
- 4:16 PM Changeset in webkit [160734] by
-
- 3 edits2 adds in trunk
Video element's width and height content attributes should not influence intrinsic width and height
https://bugs.webkit.org/show_bug.cgi?id=125822
Reviewed by Darin Adler.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/022ce34efb5b70cb964c3ca29f23c8980ffaef05
The width/height content attributes already influence specified style via
HTMLVideoElement::collectStyleForPresentationAttribute, to also influence the intrinsic size has never
been part of the spec: http://www.w3.org/TR/2013/WD-html51-20130528/embedded-content-0.html#dom-dim-width
The test case passes in Firefox Nightly and IE11 Release Preview, but fails in Opera Presto, which has
no default intrinsic size.
Test: media/video-intrinsic-width-height.html
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::calculateIntrinsicSize):
LayoutTests:
- media/video-intrinsic-width-height-expected.txt: Added.
- media/video-intrinsic-width-height.html: Added.
- 4:15 PM Changeset in webkit [160733] by
-
- 72 edits3 adds in trunk/Source
[iOS] Upstream WebCore/html changes
https://bugs.webkit.org/show_bug.cgi?id=125765
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- html/Autocapitalize.cpp: Added.
- html/Autocapitalize.h: Added. Also, added FIXME comment to forward declare AtomicString once we upstream
more of the iOS port.
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::handleDOMActivateEvent): Opt out of code when building for iOS.
- html/BaseDateAndTimeInputType.cpp:
(WebCore::BaseDateAndTimeInputType::isKeyboardFocusable): Added; iOS-specific.
- html/BaseDateAndTimeInputType.h:
- html/FileInputType.cpp:
(WebCore::FileInputType::FileInputType): Added iOS-specific code.
(WebCore::FileInputType::~FileInputType): Opt out of code when building for iOS. Also, added FIXME comment.
(WebCore::FileInputType::requestIcon): Ditto.
(WebCore::FileInputType::filesChosen): Added; iOS-specific.
(WebCore::FileInputType::displayString): Added; iOS-specific.
(WebCore::FileInputType::receiveDroppedFiles): Guarded code with ENABLE(DRAG_SUPPORT).
- html/FileInputType.h:
- html/FormController.cpp:
(WebCore::FormController::formElementsCharacterCount): Added.
- html/FormController.h:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::updateWidget): Opt out of code when building for iOS.
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::computePath): Changed argument datatype from RenderElement* to RenderObject*.
Also, added FIXME comment to fix this up once we upstream iOS's DOMUIKitExtensions.{h, mm}.
(WebCore::HTMLAreaElement::computeRect): Ditto.
- html/HTMLAreaElement.h:
- html/HTMLAttributeNames.in: Added attributes ongesture{start, change, end}, autocorrect, autocapitalize,
data-youtube-id, onwebkit{currentplaybacktargetiswirelesschanged, playbacktargetavailabilitychanged}, webkit-playsinline,
x-webkit-airplay, and x-webkit-wirelessvideoplaybackdisabled.
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::scrollLeft): Added iOS-specific code.
(WebCore::HTMLBodyElement::scrollTop): Ditto.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::HTMLCanvasElement): Added iOS-specific code and FIXME comment.
(WebCore::HTMLCanvasElement::createImageBuffer): Added iOS-specific code.
- html/HTMLCanvasElement.h: Added iOS-specific code and FIXME comment.
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument): Added argument isSynthesized (default to false), which is
passed through to Document::Document(), to create a synthesized document.
- html/HTMLDocument.h:
(WebCore::HTMLDocument::createSynthesizedDocument): Added.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::collectStyleForPresentationAttribute): Added iOS-specific code.
(WebCore::populateEventNameForAttributeLocalNameMap): Ditto.
(WebCore::HTMLElement::willRespondToMouseMoveEvents): Added; iOS-specific.
(WebCore::HTMLElement::willRespondToMouseWheelEvents): Added; iOS-specific.
(WebCore::HTMLElement::willRespondToMouseClickEvents): Added; iOS-specific.
- html/HTMLElement.h:
- html/HTMLFormControlElement.cpp: Added FIXME comment to share more code with class HTMLFormElement.
(WebCore::HTMLFormControlElement::autocorrect): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormControlElement::setAutocorrect): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormControlElement::autocapitalizeType): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormControlElement::autocapitalize): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormControlElement::setAutocapitalize): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp: Added FIXME comment to share more code with class HTMLFormControlElement.
(WebCore::HTMLFormElement::submitImplicitly): Modified to code to allow implicit submission of multi-input
forms only if Settings::allowMultiElementImplicitSubmission() returns true. Such behavior is expected by older
iOS apps. Also, changed datatype of variable submissionTriggerCount from int to unsigned because it represents
a non-negative value.
(WebCore::HTMLFormElement::autocorrect): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormElement::setAutocorrect): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormElement::autocapitalizeType): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormElement::autocapitalize): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
(WebCore::HTMLFormElement::setAutocapitalize): Added; guarded by PLATFORM(IOS_AUTOCORRECT_AND_AUTOCAPITALIZE).
- html/HTMLFormElement.h:
- html/HTMLFormElement.idl: Added iOS-specific attributes: autocorrect and autocapitalize.
- html/HTMLIFrameElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::displayString): Added; guarded by PLATFORM(IOS).
(WebCore::HTMLInputElement::dateType): Added; guarded by PLATFORM(IOS).
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl: Added iOS-specific attributes: autocorrect and autocapitalize.
- html/HTMLLabelElement.cpp:
(WebCore::HTMLLabelElement::willRespondToMouseClickEvents): Added iOS-specific code.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Added iOS-specific code and FIXME comment.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Added iOS-specific code.
(WebCore::HTMLMediaElement::parseMediaPlayerAttribute): Added; iOS-specific.
(WebCore::HTMLMediaElement::parseAttribute): Added iOS-specific code.
(WebCore::HTMLMediaElement::insertedInto): Ditto.
(WebCore::HTMLMediaElement::load): Ditto.
(WebCore::HTMLMediaElement::prepareForLoad): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::play): Ditto.
(WebCore::HTMLMediaElement::playInternal): Ditto.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
(WebCore::HTMLMediaElement::setVolumne): Opt out of code when building for iOS.
(WebCore::HTMLMediaElement::setMuted): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Added iOS-specific code.
(WebCore::HTMLMediaElement::updateVolume): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Ditto.
(WebCore::HTMLMediaElement::userCancelledLoad): Added iOS-specific code and FIXME comment.
(WebCore::HTMLMediaElement::resume): Added iOS-specific comment. See <rdar://problem/9751303>.
(WebCore::HTMLMediaElement::deliverNotification): Added iOS-specific code.
(WebCore::HTMLMediaElement::getPluginProxyParams): Added iOS-specific code. Also, changed src() to getNonEmptyURLAttribute()
in the non-iOS code as their doesn't exist a method called src in this class or its superclasses.
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLMediaElement::mediaPlayerPlaybackTargetAvailabilityChanged): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLMediaElement::addEventListener): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLMediaElement::removeEventListener): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLMediaElement::enterFullscreen): Added iOS-specific code.
(WebCore::HTMLMediaElement::exitFullscreen): Ditto.
(WebCore::HTMLMediaElement::createMediaPlayer): Added ENABLE(IOS_AIRPLAY)-guarded code.
(WebCore::HTMLMediaElement::userRequestsMediaLoading): Added; guarded by PLATFORM(IOS).
(WebCore::HTMLMediaElement::shouldUseVideoPluginProxy): Use dot operator instead of dereference operator (->)
when accessing Document::settings().
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Added ENABLE(PLUGIN_PROXY_FOR_VIDEO)-guarded code.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::userGestureRequiredToShowPlaybackTargetPicker): Added; guarded by ENABLE(IOS_AIRPLAY).
- html/HTMLMediaElement.idl: Added ENABLE_IOS_AIRPLAY-guarded attributes and functions:webkitCurrentPlaybackTargetIsWireless,
onwebkit{currentplaybacktargetiswirelesschanged, playbacktargetavailabilitychanged}, and webkitShowPlaybackTargetPicker().
- html/HTMLMetaElement.cpp:
(WebCore::HTMLMetaElement::process): Added iOS-specific code.
- html/HTMLObjectElement.cpp:
(WebCore::shouldNotPerformURLAdjustment): Added; iOS-specific.
(WebCore::HTMLObjectElement::parametersForPlugin): Modified to call shouldNotPerformURLAdjustment() when
building for iOS.
- html/HTMLPlugInElement.h:
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::createRenderer): Added iOS-specific code.
(WebCore::HTMLPlugInImageElement::createShadowIFrameSubtree): Added; iOS-specific.
- html/HTMLPlugInImageElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::usesMenuList): Added iOS-specific code.
(WebCore::HTMLSelectElement::createRenderer): Ditto.
(WebCore::HTMLSelectElement::childShouldCreateRenderer): Ditto.
(WebCore::HTMLSelectElement::willRespondToMouseClickEvents): Added; iOS-specific.
(WebCore::HTMLSelectElement::updateListBoxSelection): Added iOS-specific code.
(WebCore::HTMLSelectElement::scrollToSelection): Ditto.
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Opt out of code when building for iOS.
(WebCore::HTMLSelectElement::defaultEventHandler): Added iOS-specific code.
- html/HTMLSelectElement.h:
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::willRespondToMouseClickEvents): Added; iOS-specific.
- html/HTMLTextAreaElement.h:
- html/HTMLTextAreaElement.idl: Added iOS-specific attributes: autocorrect and autocapitalize.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::select): Added iOS-specific code and FIXME comment.
(WebCore::HTMLTextFormControlElement::setSelectionRange): Opt out of code when building for iOS.
(WebCore::HTMLTextFormControlElement::hidePlaceholder): Added; guarded by PLATFORM(IOS).
(WebCore::HTMLTextFormControlElement::showPlaceholderIfNecessary): Added; guarded by PLATFORM(IOS).
- html/HTMLTextFormControlElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::createRenderer): Fix up call to HTMLMediaElement::createRenderer().
(WebCore::HTMLVideoElement::parseAttribute): Added iOS-specific code.
(WebCore::HTMLVideoElement::supportsFullscreen): Ditto.
(WebCore::HTMLVideoElement::webkitWirelessVideoPlaybackDisabled): Added; guarded by ENABLE(IOS_AIRPLAY).
(WebCore::HTMLVideoElement::setWebkitWirelessVideoPlaybackDisabled): Added; guarded by ENABLE(IOS_AIRPLAY).
- html/HTMLVideoElement.h:
- html/HTMLVideoElement.idl: Added ENABLE_IOS_AIRPLAY-guarded attribute: webkitWirelessVideoPlaybackDisabled.
- html/ImageDocument.cpp:
(WebCore::ImageDocument::createDocumentStructure): Added iOS-specific code.
(WebCore::ImageDocument::scale): Ditto.
(WebCore::ImageDocument::resizeImageToFit): Ditto.
(WebCore::ImageDocument::imageClicked): Ditto.
(WebCore::ImageDocument::imageFitsInWindow): Ditto.
(WebCore::ImageDocument::windowSizeChanged): Ditto.
- html/InputType.cpp:
(WebCore::InputType::dateType): Added; guarded by PLATFORM(IOS).
(WebCore::InputType::isKeyboardFocusable): Added iOS-specific code.
(WebCore::InputType::displayString): Added; guarded by PLATFORM(IOS).
- html/InputType.h:
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure): Added iOS-specific code.
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleTouchEvent): Ditto.
(WebCore::RangeInputType::disabledAttributeChanged): Added; iOS-specific.
- html/RangeInputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::addSearchResult): Opt out of code when building for iOS.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::isKeyboardFocusable): Added iOS-specific code.
- html/TextFieldInputType.h:
- html/WebAutocapitalize.h: Added.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::createImageData): Added iOS-specific code.
(WebCore::CanvasRenderingContext2D::getImageData): Ditto.
- html/parser/HTMLConstructionSite.h:
(WebCore::HTMLConstructionSite::isTelephoneNumberParsingEnabled): Added; guarded by PLATFORM(IOS).
- html/parser/HTMLParserScheduler.h:
(WebCore::HTMLParserScheduler::checkForYieldBeforeToken): Added iOS-specific code.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink): Added; guarded by PLATFORM(IOS).
(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers): Added; guarded by PLATFORM(IOS).
(WebCore::disallowTelephoneNumberParsing): Added; guarded by PLATFORM(IOS).
(WebCore::shouldParseTelephoneNumbersInNode): Added; guarded by PLATFORM(IOS).
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody): Added iOS-specific code.
- html/parser/HTMLTreeBuilder.h:
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement): Guarded member initialization of m_controls with ENABLE(VIDEO_TRACK). Also added UNUSED_PARAM(event) when building with
VIDEO_TRACK disabled.
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Added UNUSED_PARAM(event) when
building with VIDEO_TRACK disabled.
- html/shadow/MediaControls.h:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::SliderThumbElement): Added iOS-specific code.
(WebCore::SliderThumbElement::dragFrom): Opt out of code when building for iOS.
(WebCore::SliderThumbElement::willDetachRenderers): Added iOS-specific code.
(WebCore::SliderThumbElement::exclusiveTouchIdentifier): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::setExclusiveTouchIdentifier): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::clearExclusiveTouchIdentifier): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::findTouchWithIdentifier): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::handleTouchStart): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::handleTouchMove): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::handleTouchEndAndCancel): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::didAttachRenderers): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::handleTouchEvent): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::shouldAcceptTouchEvents): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::registerForTouchEvents): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::unregisterForTouchEvents): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
(WebCore::SliderThumbElement::disabledAttributeChanged): Added; guarded by ENABLE(TOUCH_EVENTS) && PLATFORM(IOS).
- html/shadow/SliderThumbElement.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Opt out of code when building for iOS.
- html/shadow/TextControlInnerElements.h:
- page/Settings.in: Added setting allowMultiElementImplicitSubmission to enable/disable multi-input implicit form
submission (disabled by default). Also added FIXME comment to rename this setting to allowMultiElementImplicitFormSubmission
once we upstream the iOS changes to WebView.mm.
Source/WTF:
Defined ENABLE_IOS_AUTOCORRECT_AND_AUTOCAPITALIZE, enabled by default on iOS.
- wtf/FeatureDefines.h:
- 4:12 PM Changeset in webkit [160732] by
-
- 37 edits in trunk/Source
DatabaseProcess: Pipe through object store IDs and transaction mode for "openTransaction"
https://bugs.webkit.org/show_bug.cgi?id=125872
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Make these enums into enum classes.
Add const maximums for each enum class that might be serialized to allow for conversion later:
- Modules/indexeddb/IndexedDB.h:
Add cross-thread copying for these new enum classes.
- platform/CrossThreadCopier.cpp:
(WebCore::::copy):
- platform/CrossThreadCopier.h:
Adopt the new enum classes throughout the rest of WebCore:
- Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::stringToDirection):
(WebCore::IDBCursor::directionToString):
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBCursorBackend.cpp:
(WebCore::IDBCursorBackend::deleteFunction):
- Modules/indexeddb/IDBCursorBackend.h:
(WebCore::IDBCursorBackend::value):
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::createObjectStore):
(WebCore::IDBDatabaseBackend::deleteObjectStore):
(WebCore::IDBDatabaseBackend::createIndex):
(WebCore::IDBDatabaseBackend::deleteIndex):
(WebCore::IDBDatabaseBackend::get):
(WebCore::IDBDatabaseBackend::put):
(WebCore::IDBDatabaseBackend::setIndexKeys):
(WebCore::IDBDatabaseBackend::openCursor):
(WebCore::IDBDatabaseBackend::deleteRange):
(WebCore::IDBDatabaseBackend::clearObjectStore):
(WebCore::IDBDatabaseBackend::transactionStarted):
(WebCore::IDBDatabaseBackend::transactionFinished):
(WebCore::IDBDatabaseBackend::transactionFinishedAndAbortFired):
(WebCore::IDBDatabaseBackend::transactionFinishedAndCompleteFired):
(WebCore::IDBDatabaseBackend::createTransaction):
(WebCore::IDBDatabaseBackend::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackend::deleteDatabase):
- Modules/indexeddb/IDBDatabaseBackend.h:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::setResultCursor):
(WebCore::IDBRequest::onSuccess):
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::create):
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::stringToMode):
(WebCore::IDBTransaction::modeToString):
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::PutOperation::perform):
- Modules/indexeddb/IDBTransactionCoordinator.cpp:
(WebCore::IDBTransactionCoordinator::processStartedTransactions):
(WebCore::IDBTransactionCoordinator::canRunTransaction):
- Modules/indexeddb/IDBVersionChangeEvent.h:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::newVersion):
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::get):
(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::count):
(WebCore::IDBServerConnectionLevelDB::deleteRange):
(WebCore::IDBServerConnectionLevelDB::cursorPrefetchIteration):
- WebCore.exp.in:
Source/WebKit2:
Pipe through the objectStoreIDs and mode:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::openTransaction):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
Rework postTransactionOperation to take a pre-made AsyncTask to allow for different
transaction operation function signatures:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::openTransaction): Pipe through the objectStoreIDs and mode:
(WebKit::UniqueIDBDatabase::beginTransaction):
(WebKit::UniqueIDBDatabase::commitTransaction):
(WebKit::UniqueIDBDatabase::resetTransaction):
(WebKit::UniqueIDBDatabase::rollbackTransaction):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
Pipe through the objectStoreIDs and mode:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::establishTransaction):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- Platform/Logging.h: Add an IDB logging channel.
- Shared/AsyncTask.h:
(WebKit::createAsyncTask): Add a 3-argument variant.
- Shared/WebCrossThreadCopier.cpp:
(WebCore::::copy): Add a Vector<int64_t> copier.
- Shared/WebCrossThreadCopier.h:
Add logging throughout currently implemented methods:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::openTransaction): Pipe through the objectStoreIDs and mode.
(WebKit::WebIDBServerConnection::didOpenTransaction):
(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::didBeginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::didCommitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::didResetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::didRollbackTransaction):
- 3:42 PM Changeset in webkit [160731] by
-
- 19 edits in trunk
Remove PageVisibilityStateUnloaded
https://bugs.webkit.org/show_bug.cgi?id=125869
Reviewed by Anders Carlsson.
This is not currently supported by WebKit, remove this enum value.
We can always add this back later if/when we add support for this state.
Source/WebCore:
- page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
- page/PageVisibilityState.h:
- removed PageVisibilityStateUnloaded
Source/WebKit/mac:
- WebView/WebView.mm:
(core):
(kit):
- WebView/WebViewPrivate.h:
- removed PageVisibilityStateUnloaded/WebPageVisibilityStateUnloaded
Source/WebKit2:
- Shared/API/c/WKPageVisibilityTypes.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toPageVisibilityState):
- removed PageVisibilityStateUnloaded/kWKPageVisibilityStateUnloaded
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setPageVisibility):
- TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
(TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageVisibility):
- remove test for visibility state "unloaded"; this is no longer supported (it never really was).
LayoutTests:
- fast/events/page-visibility-transition-test-expected.txt:
- fast/events/page-visibility-transition-test.html:
- remove test for visibility state "unloaded"; this is no longer supported (it never really was).
- 3:30 PM Changeset in webkit [160730] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Introduce a maxFrameExtentForSlowPathCallInRegisters value.
https://bugs.webkit.org/show_bug.cgi?id=125877.
Reviewed by Michael Saboff.
Sometimes, we need this max frame extent value in units of Registers.
So, might as well provide it at the source.
- assembler/MaxFrameExtentForSlowPathCall.h:
- 2:19 PM Changeset in webkit [160729] by
-
- 2 edits in trunk/LayoutTests
Sanitize skip entries for pop-up menu tests.
Pop-up menus are native controls on Mac, and block test progress when opened.
- platform/mac/TestExpectations: Combined entries for these tests together, and
updated comments.
- 1:52 PM Changeset in webkit [160728] by
-
- 10 edits2 adds in trunk
[GTK] [CMake] Build the plugin process against GTK+ 2
https://bugs.webkit.org/show_bug.cgi?id=116374
Reviewed by Gustavo Noronha Silva.
.:
- Source/cmake/FindGDK2.cmake: Added.
- Source/cmake/FindGTK2.cmake: Added.
- Source/cmake/OptionsGTK.cmake: Look for GTK2 and GDK2.
- Source/cmake/WebKitMacros.cmake: Abstract WebKit2 IPC generation here so it
can be shared between the WebKit2 library and the plugin process.
Source/WebCore:
- PlatformGTK.cmake: Split off the GTK+-dependent sources into
libWebCorePlatformGTK and compile libWebCorePlatformGTK2 when
WebKit2 is enabled.
Source/WebKit2:
- CMakeLists.txt: Use the new GENERATE_WEBKIT2_MESSAGE_SOURCES macro so we
can share messaging file generation with the plugin process.
- PlatformGTK.cmake: Add more files to the plugin process source list. Properly
generate message sources, add the appropriate include paths, defines, and libraries
for the plugin process.
Tools:
- TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
libraries required for WebCore unit tests.
- 1:30 PM Changeset in webkit [160727] by
-
- 7 edits in trunk/Source/WebKit2
Back out r159982
https://bugs.webkit.org/show_bug.cgi?id=125870
<rdar://problem/15598485>
Reviewed by Dan Bernstein.
Looks like r159982 caused intermittent crashes. Back it out for now.
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
- UIProcess/WebPageGroup.cpp:
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
- UIProcess/WebProcessProxy.h:
- 1:20 PM Changeset in webkit [160726] by
-
- 2 edits in trunk/Tools
[Win] Revise filter-build-webkit to deal with Windows build logs
https://bugs.webkit.org/show_bug.cgi?id=125866
Reviewed by David Kilzer.
Enhance the script to accept a 'platform' argument. When platform
'win' is provided, use processing for the Windows build file format.
Otherwise, process the files as normal.
- Scripts/filter-build-webkit:
(usageAndExit): Add a 'platform' argument
(shouldIgnoreLine): When platform == 'win' use the new Windows
rules for processing the build file.
- 1:18 PM Changeset in webkit [160725] by
-
- 5 edits in trunk/Source
Compile fix for WebGL on Windows without GRAPHICS_SURFACE.
https://bugs.webkit.org/show_bug.cgi?id=125867
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-17
Reviewed by Martin Robinson.
Source/WebCore:
- platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createOffScreenSurface):
Protect reference to EGLOffScreenSurface with USE(GRAPHICS_SURFACE).
Source/WTF:
- wtf/FeatureDefines.h:
Removed unused ENABLE_GLIB_SUPPORT macro.
- wtf/Platform.h:
Don't use GRAPHICS_SURFACE for WebGL on Windows.
- 12:48 PM Changeset in webkit [160724] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test update for Windows.
- platform/win/TestExpectations: Exclude a few more media-based
test files.
- 12:34 PM Changeset in webkit [160723] by
-
- 2 edits in trunk/LayoutTests
Layout Test webaudio/delaynode-max-default-delay.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=121646
- platform/mac/TestExpectations: Marking as such.
- 12:22 PM Changeset in webkit [160722] by
-
- 3 edits in trunk/Tools
Update style checker now that ENUM_CLASS is gone
https://bugs.webkit.org/show_bug.cgi?id=125864
Reviewed by Anders Carlsson.
- Scripts/webkitpy/style/checkers/cpp.py:
(_EnumState.process_clean_line):
(check_braces):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(NoNonVirtualDestructorsTest.test_enum_casing.Foo):
(NoNonVirtualDestructorsTest.test_enum_casing):
(NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
(NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
(WebKitStyleTest.test_braces.CPP11EnumClass):
- 12:13 PM Changeset in webkit [160721] by
-
- 3 edits6 adds in trunk
[CSS Regions] Positioned elements in regions get clipped if they fall outside the region
https://bugs.webkit.org/show_bug.cgi?id=117120
Reviewed by Mihnea Ovidenie.
Source/WebCore:
Fixed the computing of the box decorations clip rect when having statically positioned
elements inside positioned elements. The existing algorithm computed the rect in a loop
running up the containing block chain and only checked for positioned elements before
starting the loop. If a positioned elements was found in the middle of a loop (as would
be the case with a positioned element parenting a non-positioned element), it was not
correctly handled.
Also changed it so the clip is only performed in the fragmentation direction as that was
the original purpose of this method.
Tests: fast/regions/absolute-in-relative-overflow.html
fast/regions/static-in-relative-overflow.html
fast/regions/sticky-border-overflow.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
LayoutTests:
Added tests for the correct painting of the borders of differently positioned elements overflowing regions.
- fast/regions/absolute-in-relative-overflow-expected.html: Added.
- fast/regions/absolute-in-relative-overflow.html: Added.
- fast/regions/static-in-relative-overflow-expected.html: Added.
- fast/regions/static-in-relative-overflow.html: Added.
- fast/regions/sticky-border-overflow-expected.html: Added.
- fast/regions/sticky-border-overflow.html: Added.
- 12:11 PM Changeset in webkit [160720] by
-
- 4 edits4 deletes in trunk
Unreviewed, rolling out r160717.
http://trac.webkit.org/changeset/160717
https://bugs.webkit.org/show_bug.cgi?id=125863
New tests are failing, and possibly broke an existing test
(Requested by ap on #webkit).
Source/WebCore:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::collectFixedPositionedLayers):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
LayoutTests:
- fast/regions/repaint/fixed-in-named-flow-cb-changed-expected.txt: Removed.
- fast/regions/repaint/fixed-in-named-flow-cb-changed.html: Removed.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2-expected.txt: Removed.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2.html: Removed.
- 12:10 PM Changeset in webkit [160719] by
-
- 3 edits2 adds in trunk
Invalid dir attributes should resolve to ltr
https://bugs.webkit.org/show_bug.cgi?id=125830
Source/WebCore:
Reviewed by Darin Adler.
Merge https://chromium.googlesource.com/chromium/blink/+/2d592d1c998bec9438e421e1ce1ee6caba05a884
The dir attribute should resolve to direction: ltr by default when the attribute value is
"not in a defined state": http://www.w3.org/TR/2013/WD-html51-20130528/dom.html#the-directionality
Test: fast/dom/HTMLElement/set-and-clear-dir-attribute.html
- html/HTMLElement.cpp:
(WebCore::isLTROrRTLIgnoringCase): Extracted from HTMLElement::directionality.
(WebCore::HTMLElement::collectStyleForPresentationAttribute):
(WebCore::HTMLElement::directionality):
LayoutTests:
Reviewed by Darin Adler.
- fast/dom/HTMLElement/set-and-clear-dir-attribute-expected.txt: Added.
- fast/dom/HTMLElement/set-and-clear-dir-attribute.html: Added.
- 11:46 AM Changeset in webkit [160718] by
-
- 2 edits in trunk/Source/WebKit2
Fixed an assertion failure seen running some mixed-content tests.
https://bugs.webkit.org/show_bug.cgi?id=125862
Reviewed by Alexey Proskuryakov.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::didDisplayOrRunInsecureContent): Removed an assertion about the URL
of the main frame when dealing with a notification that could have come from any frame.
- 10:46 AM Changeset in webkit [160717] by
-
- 4 edits4 adds in trunk
[CSSRegions] Incorrect repaint of fixed element with transformed parent
https://bugs.webkit.org/show_bug.cgi?id=125756
Reviewed by Darin Adler.
Source/WebCore:
When collecting the layers for fixed positioned elements with named flow
as a containing block, use layers collection at named flow layer level
instead of relying on the positioned elements collection.
Modified also FlowThreadController::collectFixedPositionedLayers function
to always return the layers sorted by z-index, as this operation was always
done at the call sites.
Tests: fast/regions/repaint/fixed-in-named-flow-cb-changed.html
fast/regions/repaint/fixed-in-named-flow-cb-changed2.html
- rendering/FlowThreadController.cpp:
(WebCore::compareZIndex):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
LayoutTests:
Add tests for a fixed positioned element with a parent that:
- dynamically gets a transform, in which case the fixed positioned element should be positioned
relative to its parent
- dynamically loses its transform, in which case the fixed positioned element should be positioned
relative to the view.
- fast/regions/repaint/fixed-in-named-flow-cb-changed-expected.txt: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed.html: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2-expected.txt: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2.html: Added.
- 10:45 AM Changeset in webkit [160716] by
-
- 3 edits in trunk/Source/WTF
[Win] Fixed linker error with GStreamer.
https://bugs.webkit.org/show_bug.cgi?id=124861
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-17
Reviewed by Martin Robinson.
- wtf/gobject/GOwnPtr.cpp:
(WTF::GError):
- wtf/gobject/GOwnPtr.h:
Added WTF_EXPORT_PRIVATE to freeOwnedGPtr<GError> declaration and definition.
- 10:38 AM Changeset in webkit [160715] by
-
- 5 edits in trunk
REGRESSION(r159166?): fast/block/float/float-with-fractional-height-vertical-lr.html, fast/block/float/float-with-fractional-height.html are failing
https://bugs.webkit.org/show_bug.cgi?id=124506
Reviewed by Dirk Schulze.
Source/WebCore:
Floor the endpoints of the floating object interval to keep the old
behavior until a better fix can be created.
No new tests, fixes regression in existing tests.
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::intervalForFloatingObject):
LayoutTests:
Remove lines for tests that have been fixed by this patch.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 10:25 AM Changeset in webkit [160714] by
-
- 3 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Fix callee frame access in virtualForThunkGenerator when we don't emit prologue code
https://bugs.webkit.org/show_bug.cgi?id=125828
Not yet reviewed.
Added helpers to access the callee frame using the stack pointer taking into account that
the caller frame hasn't been pushed onto the stack.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitPutToCallFrameHeaderBeforePrologue):
(JSC::AssemblyHelpers::emitPutPayloadToCallFrameHeaderBeforePrologue):
(JSC::AssemblyHelpers::emitPutTagToCallFrameHeaderBeforePrologue):
- jit/ThunkGenerators.cpp:
(JSC::virtualForThunkGenerator):
- 10:14 AM Changeset in webkit [160713] by
-
- 2 edits in trunk/Source/WebCore
[Win] Visual Studio workaround for compiling WebGL.
https://bugs.webkit.org/show_bug.cgi?id=125808
Reviewed by Darin Adler.
- platform/graphics/GraphicsContext3D.cpp:
Don't inline outermost function to prevent Visual Studio crash.
- 10:08 AM Changeset in webkit [160712] by
-
- 12 edits in trunk
[ATK] Expose accessibility objects for <dl>, <dt> and <dd>
https://bugs.webkit.org/show_bug.cgi?id=125857
Reviewed by Chris Fleizach.
Source/WebCore:
Map description lists to the newly introduced ATK roles
ATK_ROLE_DESCRIPTION_LIST, ATK_ROLE_DESCRIPTION_TERM and
ATK_ROLE_DESCRIPTION_VALUE, introduced in ATK 2.11.4.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Do the right mapping.
(webkitAccessibleGetRole): Update call to atkRole, now that it
receives an AccessibilityObject* as parameter.
Tools:
Add mappings to DRT & WKTR for the newly exposed roles, and
increase the version of ATK used by the internal jhbuild.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
LayoutTests:
Update test to update expectations.
- platform/gtk/accessibility/roles-exposed-expected.txt:
- platform/gtk/accessibility/roles-exposed.html:
Updated test expectations for other test using description lists.
- platform/efl-wk1/accessibility/lists-expected.txt:
- platform/efl-wk2/accessibility/lists-expected.txt:
- platform/gtk/accessibility/lists-expected.txt:
- 9:56 AM Changeset in webkit [160711] by
-
- 6 edits4 adds in trunk
Ensure inferred mrows for msqrt, mstyle, merror, mphantom and math.
https://bugs.webkit.org/show_bug.cgi?id=124841
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-12-17
Reviewed by Darin Adler.
Source/WebCore:
Tests: mathml/presentation/inferred-mrow-baseline.html
mathml/presentation/inferred-mrow-stretchy.html
- css/mathml.css: make merror, mphantom and mstyle behave like an mrow.
(mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot, merror, mphantom, mstyle):
(math, mrow, mfenced, msqrt, mroot, merror, mphantom, mstyle):
- mathml/MathMLInlineContainerElement.cpp: ditto
(WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/mathtags.in: ditto
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::paint): fix failure in mathml/presentation/phantom.html now that phantom can stretch operators.
LayoutTests:
- mathml/presentation/inferred-mrow-baseline-expected.txt: Added.
- mathml/presentation/inferred-mrow-baseline.html: Added.
- mathml/presentation/inferred-mrow-stretchy-expected.txt: Added.
- mathml/presentation/inferred-mrow-stretchy.html: Added.
- 9:40 AM Changeset in webkit [160710] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Add properties related to the user agent string
https://bugs.webkit.org/show_bug.cgi?id=125856
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared new properties.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController applicationNameForUserAgent]): Added accessor.
(-[WKBrowsingContextController setApplicationNameForUserAgent:]): Ditto.
(-[WKBrowsingContextController customUserAgent]): Ditto.
(-[WKBrowsingContextController setCustomUserAgent:]): Ditto.
- 9:27 AM Changeset in webkit [160709] by
-
- 2 edits in trunk/LayoutTests
[Win] Temporarily disable mediate tests to get bots green.
- platform/win/TestExpectations: Turn off additional media-related
tests. These will be reactivated soon.
- 8:58 AM Changeset in webkit [160708] by
-
- 5 edits33 moves4 adds1 delete in trunk/LayoutTests
[CSS Regions] Move regions tests from fast/repaint into fast/regions
https://bugs.webkit.org/show_bug.cgi?id=78786
Reviewed by Dirk Schulze.
Moved regions repaint tests from fast/repaint into fast/regions/repaint.
Moved regions repaint tests from fast/regions into fast/regions/repaint.
Adjusted paths, TestExpectations.
- fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt: Renamed from LayoutTests/fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt.
- fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html: Renamed from LayoutTests/fast/regions/element-in-named-flow-absolute-from-fixed.html.
- fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt: Renamed from LayoutTests/fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt.
- fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html: Renamed from LayoutTests/fast/regions/element-in-named-flow-fixed-from-absolute.html.
- fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt: Renamed from LayoutTests/fast/regions/element-inflow-fixed-from-outflow-static-expected.txt.
- fast/regions/repaint/element-inflow-fixed-from-outflow-static.html: Renamed from LayoutTests/fast/regions/element-inflow-fixed-from-outflow-static.html.
- fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt: Renamed from LayoutTests/fast/regions/element-outflow-static-from-inflow-fixed-expected.txt.
- fast/regions/repaint/element-outflow-static-from-inflow-fixed.html: Renamed from LayoutTests/fast/regions/element-outflow-static-from-inflow-fixed.html.
- fast/regions/repaint/fixed-in-named-flow-scroll-expected.txt: Renamed from LayoutTests/fast/regions/fixed-in-named-flow-scroll-expected.txt.
- fast/regions/repaint/fixed-in-named-flow-scroll.html: Renamed from LayoutTests/fast/regions/fixed-in-named-flow-scroll.html.
- fast/regions/repaint/increasing-region-content-height-expected.txt: Renamed from LayoutTests/fast/repaint/increasing-region-content-height-expected.txt.
- fast/regions/repaint/increasing-region-content-height.html: Renamed from LayoutTests/fast/repaint/increasing-region-content-height.html.
- fast/regions/repaint/japanese-rl-selection-repaint-in-regions.html: Renamed from LayoutTests/fast/repaint/japanese-rl-selection-repaint-in-regions.html.
- fast/regions/repaint/line-flow-with-floats-in-regions.html: Added.
- fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions.html: Renamed from LayoutTests/fast/repaint/overflow-flipped-writing-mode-block-in-regions.html.
- fast/regions/repaint/region-painting-composited-element-expected.html: Renamed from LayoutTests/fast/repaint/region-painting-composited-element-expected.html.
- fast/regions/repaint/region-painting-composited-element.html: Renamed from LayoutTests/fast/repaint/region-painting-composited-element.html.
- fast/regions/repaint/region-painting-in-composited-view-expected.html: Renamed from LayoutTests/fast/repaint/region-painting-in-composited-view-expected.html.
- fast/regions/repaint/region-painting-in-composited-view.html: Renamed from LayoutTests/fast/repaint/region-painting-in-composited-view.html.
- fast/regions/repaint/region-painting-invalidation.html: Renamed from LayoutTests/fast/repaint/region-painting-invalidation.html.
- fast/regions/repaint/region-painting-via-layout.html: Renamed from LayoutTests/fast/repaint/region-painting-via-layout.html.
- fast/regions/repaint/repaint-regions-overflow-expected.txt: Renamed from LayoutTests/fast/repaint/repaint-regions-overflow-expected.txt.
- fast/regions/repaint/repaint-regions-overflow.html: Renamed from LayoutTests/fast/repaint/repaint-regions-overflow.html.
- fast/repaint/line-flow-with-floats-in-regions.html: Removed.
- platform/efl/TestExpectations:
- platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Renamed from LayoutTests/platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt.
- platform/gtk/TestExpectations:
- platform/mac/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Renamed from LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png.
- platform/mac/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Renamed from LayoutTests/platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt.
- platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.png: Renamed from LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.png.
- platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Renamed from LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt.
- platform/mac/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png: Renamed from LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.png.
- platform/mac/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Renamed from LayoutTests/platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt.
- platform/mac/fast/regions/repaint/region-painting-invalidation-expected.png: Renamed from LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.png.
- platform/mac/fast/regions/repaint/region-painting-invalidation-expected.txt: Renamed from LayoutTests/platform/mac/fast/repaint/region-painting-invalidation-expected.txt.
- platform/mac/fast/regions/repaint/region-painting-via-layout-expected.png: Renamed from LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.png.
- platform/mac/fast/regions/repaint/region-painting-via-layout-expected.txt: Renamed from LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 8:55 AM Changeset in webkit [160707] by
-
- 4 edits in trunk
Source/WebKit/win: [WinCairo] Compile fixes for GStreamer on Windows.
https://bugs.webkit.org/show_bug.cgi?id=124867
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-17
Reviewed by Philippe Normand.
- WebView.cpp:
(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):
GStreamer in WebKit does not support fullscreen, so
I added #if !USE(GSTREAMER) to the fullscreen code to get it to compile.
Tools: [WinCairo] Adding support for GStreamer and GLib.
https://bugs.webkit.org/show_bug.cgi?id=124867
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-17
Reviewed by Philippe Normand.
- WinLauncher/WinLauncher.cpp:
(wWinMain):
Added g_main_context_iteration in main event loop.
- 8:18 AM Changeset in webkit [160706] by
-
- 3 edits in trunk/Tools
Fix for C++ should have the & or * beside the type not the variable name check.
https://bugs.webkit.org/show_bug.cgi?id=125846
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-17
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_pointer_reference_marker_location):
- 7:22 AM Changeset in webkit [160705] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
[GTK] Some ANGLE headers missing from dist
https://bugs.webkit.org/show_bug.cgi?id=125782
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-12-17
Reviewed by Carlos Garcia Campos.
- GNUmakefile.am: add a few headers that were missing from the build,
causing build failures when the system headers were incompatible.
- 7:06 AM Changeset in webkit [160704] by
-
- 4 edits in trunk
[NIX] Enable full debug builds by having ar creating thin archives
https://bugs.webkit.org/show_bug.cgi?id=125850
Reviewed by Csaba Osztrogonác.
By default, CMake uses ar to generate libWebCore.a with cr parameters
(do not warn if the library has to be created, and replace existing
files in the archive). That results in a very large file, and ar fails
with sizes over 4GB.
.:
Previously, debug builds on NIX were overriding CFLAGS in order to reduce
the size of the WebCore library. Once that ar creates thin archives, overriding
CFLAGS is no longer needed.
- Source/cmake/OptionsNix.cmake: Remove CFLAGS override for debug builds.
Source/WebCore:
By using thin archives (the T option of ar), the generated
libWebCore.a is much smaller, and can be successfully archived. As a
result, we can generate a full debug build. This patch is based on Xan
López's webkit.org/b/110580.
- PlatformNix.cmake: Instruct cmake to invoke ar with T option.
- 5:30 AM Changeset in webkit [160703] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix armv7 and sh4 builds.
https://bugs.webkit.org/show_bug.cgi?id=125848
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-12-17
Reviewed by Csaba Osztrogonác.
- assembler/ARMv7Assembler.h: Include limits.h for INT_MIN.
- assembler/SH4Assembler.h: Include limits.h for INT_MIN.
- 5:30 AM Changeset in webkit [160702] by
-
- 3 edits in trunk/LayoutTests
[GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
https://bugs.webkit.org/show_bug.cgi?id=116971
Unreviewed. Moving test expectation to the right place, as this is
an issue that actually affects both to Webkit1 and Webkit2.
- platform/gtk-wk2/TestExpectations: Removed expectation.
- platform/gtk/TestExpectations: Added expectation.
- 4:26 AM Changeset in webkit [160701] by
-
- 1 edit6 deletes in trunk/LayoutTests
[CSSRegions] Remove left-over test expectations in fast/regions/layers
https://bugs.webkit.org/show_bug.cgi?id=125841
Reviewed by Dirk Schulze.
The original tests were removed part of https://bugs.webkit.org/show_bug.cgi?id=121828
and added back as expectations only when https://bugs.webkit.org/show_bug.cgi?id=118665
landed.
They should be removed.
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
- 4:03 AM Changeset in webkit [160700] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Update GObject DOM symbols file after r160336.
- bindings/gobject/webkitdom.symbols: Add new methods exposed for
VideoPlaybackQuality.
- 2:43 AM Changeset in webkit [160699] by
-
- 3 edits6 adds in trunk
Fix hit testing for divs with a hierarchy of css transformed and non-transformed elements
https://bugs.webkit.org/show_bug.cgi?id=124777
Patch by Mihai Maerean <Mihai Maerean> on 2013-12-17
Reviewed by Darin Adler.
Source/WebCore:
After bug #124647, the hit test will still behave incorrectly for transformed divs with non
transformed siblings that are all inside a transformed element (tested by the
hover-rotated-with-children-negative-z.html layout test).
The fix is to not take zOffset into account during hit-testing when child layers are in the
same 3D rendering context. Only when preserve3d is true, should hit-testing compute the
zOffset of the layers with transformations and, when two layers overlap, to return the layer
with the highest zOffset.
The patch includes the work of a.renevier from https://codereview.chromium.org/79943002/
Tests: transforms/3d/hit-testing/hover-rotated-with-children-negative-z.html
transforms/3d/hit-testing/negative-zoffset-hit-test.html
transforms/3d/hit-testing/overlapping-layers-hit-test.html
- rendering/RenderLayer.cpp:
(WebCore::computeZOffset):
(WebCore::RenderLayer::hitTestLayer):
LayoutTests:
- transforms/3d/hit-testing/hover-rotated-with-children-negative-z.html: Added.
- transforms/3d/hit-testing/hover-rotated-with-children-negative-z-expected.txt: Added.
- transforms/3d/hit-testing/negative-zoffset-hit-test.html: Added.
- transforms/3d/hit-testing/negative-zoffset-hit-test-expected.txt: Added.
- transforms/3d/hit-testing/overlapping-layers-hit-test.html: Added.
- transforms/3d/hit-testing/overlapping-layers-hit-test-expected.txt: Added.
- 2:41 AM Changeset in webkit [160698] by
-
- 2 edits in trunk/Source/WebCore
Remove a few more guards mistakenly added in r160367
Reviewed by Martin Robinson.
r160367 was too liberal in hiding APIs from the GObject DOM bindings.
- Modules/battery/NavigatorBattery.idl: Expose NavigatorBattery.
- 2:39 AM Changeset in webkit [160697] by
-
- 4 edits2 adds in trunk/Source
Add a simple register allocator to WebCore for x86_64
https://bugs.webkit.org/show_bug.cgi?id=125771
Reviewed by Geoffrey Garen.
Source/WebCore:
Add a brain dead register allocator to simplify the use of registers
when writting code generators.
RegisterAllocator has two purposes:
-make it easy to name registers properly.
-make it hard to reuse a register accidentally.
A helper class LocalRegister is also defined to provide an easy
way to work with registers within a C++ scope. For example:
LocalRegister elementPointer(allocator);
assembler.load(address, elementPointer);
RegisterAllocator makes no attempt at optimizing register allocations, but it reduces
implicit dependencies by returning used register at the end of the queue, making it less
likely they will be reused before their last instruction is executed.
The current implementation only support unix x86_64, it only uses caller saved registers.
- WebCore.xcodeproj/project.pbxproj:
- cssjit/RegisterAllocator.h: Added.
(WebCore::RegisterAllocator::allocateRegister): Provides any available register.
To restrict runtime exploitation of compiler bugs, the method crashes in release
if the register pool is empty.
(WebCore::RegisterAllocator::reserveRegister): Reserve a particular register.
(WebCore::RegisterAllocator::returnRegister): Return a previously allocated or reserved register.
(WebCore::RegisterAllocator::allocatedRegisters):
(WebCore::LocalRegister::LocalRegister):
(WebCore::LocalRegister::~LocalRegister):
(WebCore::LocalRegister::operator JSC::MacroAssembler::RegisterID):
(WebCore::RegisterAllocator::RegisterAllocator):
Source/WTF:
- wtf/Platform.h: Add a new flag "CSS_SELECTOR_JIT" to guard
an experimental JIT compiler in WebCore.
Dec 16, 2013:
- 11:48 PM Changeset in webkit [160696] by
-
- 20 edits in trunk/Source/WebKit2
Add layer hosting mode to ViewState
https://bugs.webkit.org/show_bug.cgi?id=125803
Unreviewed - reverting last commit - might have broken tests. :-(
- Shared/ViewState.h:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::viewWillMoveToAnotherWindow):
(WebKit::PageClientImpl::viewLayerHostingMode):
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::layerHostingModeDidChange):
- UIProcess/PageClient.h:
(WebKit::PageClient::viewLayerHostingMode):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::viewStateDidChange):
(WebKit::WebPageProxy::initializeCreationParameters):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::layerHostingMode):
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::layerHostingModeDidChange):
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::resumePainting):
(WebKit::DrawingArea::setLayerHostingMode):
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::scalePage):
(WebKit::WebPage::setDeviceScaleFactor):
(WebKit::WebPage::setActive):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::setWindowIsVisible):
(WebKit::WebPage::windowAndViewFramesChanged):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::layerHostingMode):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setLayerHostingMode):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::sendComplexTextInputToPlugin):
(WebKit::WebPage::setLayerHostingMode):
- 11:46 PM Changeset in webkit [160695] by
-
- 20 edits in trunk/Source/WebKit2
Add layer hosting mode to ViewState
https://bugs.webkit.org/show_bug.cgi?id=125803
Reviewed by Anders Carlsson.
When the view state of the page is updated the layer mode may also
change. Currently this is passed by a separate message, remove this
and fold it into ViewState.
Previously the setLayerHostingMode message would be passed to the
DrawingArea, which would inform the WebPage. Since the WebPage is
passed the SetVisibilityState messgae reverse this.
WebPageProxy had a policy of only updating the hosting mode when
visible - the value is sticky whilst the view is not visible. Make
this policy explicit in the PageClientImpl, rather then implicit
from the flow control.
- Shared/ViewState.h:
- Added ViewState::IsLayerWindowServerHosted.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- removed layerHostingMode.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::isLayerWindowServerHosted):
(WebKit::PageClientImpl::viewWillMoveToAnotherWindow):
- viewLayerHostingMode -> isLayerWindowServerHosted, added m_layerHostingMode.
- UIProcess/DrawingAreaProxy.h:
- removed layerHostingModeDidChange.
- UIProcess/PageClient.h:
- viewLayerHostingMode -> isLayerWindowServerHosted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- removed m_layerHostingMode.
(WebKit::WebPageProxy::updateViewState):
- added IsLayerWindowServerHosted.
(WebKit::WebPageProxy::viewStateDidChange):
- changes to ViewState::IsInWindow implies ViewState::IsLayerWindowServerHosted may change too.
- remove special handling (separate message) for LayerHostingMode.
(WebKit::WebPageProxy::initializeCreationParameters):
- removed m_layerHostingMode.
- UIProcess/WebPageProxy.h:
- removed m_layerHostingMode.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
- removed layerHostingModeDidChange.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setLayerHostingMode):
(WebKit::DrawingArea::didUpdate):
- setLayerHostingMode takes a LayerHostingMode.
- WebProcess/WebPage/DrawingArea.messages.in:
- SetLayerHostingMode is no longer a message.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- removed m_layerHostingMode.
(WebKit::WebPage::setViewState):
- handle ViewState::IsLayerWindowServerHosted.
(WebKit::WebPage::setLayerHostingMode):
- moved from ~Mac.mm (matching other ViewState setters), calls to DrawingArea.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::layerHostingMode):
- layerHostingMode queries m_viewState, removed m_layerHostingMode.
- WebProcess/WebPage/ios/WebPageIOS.mm:
- removed setLayerHostingMode.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setLayerHostingMode):
- setLayerHostingMode takes a LayerHostingMode, WebPage now calls to DrawingArea.
- WebProcess/WebPage/mac/WebPageMac.mm:
- removed setLayerHostingMode.
- 10:09 PM Changeset in webkit [160694] by
-
- 9 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Need an implementation of sanitizeStack for C stack
https://bugs.webkit.org/show_bug.cgi?id=125719
Reviewed by Geoffrey Garen.
Implemented sanitizeStackForVM() as a LLInt stub. It clears memory beyond
the top of stack through the last stack top, which is stored in the VM.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- heap/Heap.cpp:
(JSC::Heap::markRoots):
- interpreter/JSStack.cpp:
(JSC::JSStack::sanitizeStack):
- llint/LowLevelInterpreter.asm:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::sanitizeStackForVM):
- runtime/VM.h:
(JSC::VM::lastStackTop):
(JSC::VM::setLastStackTop):
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMEntryScope.h:
- 8:12 PM Changeset in webkit [160693] by
-
- 10 edits11 adds in trunk
Checking RTCPeerConnection signalingState before setting local/remoteDescription
https://bugs.webkit.org/show_bug.cgi?id=125655
Reviewed by Eric Carlson.
Before setting a session description RTCPeerConnection must check if it is in valid state for that SDP type.
Source/WebCore:
New tests: fast/mediastream/RTCPeerConnection-have-local-answer.html
fast/mediastream/RTCPeerConnection-have-local-offer.html
fast/mediastream/RTCPeerConnection-have-local-pranswer.html
fast/mediastream/RTCPeerConnection-have-remote-offer.html
fast/mediastream/RTCPeerConnection-have-remote-pranswer.html
fast/mediastream/RTCPeerConnection-stable.html
Modified: fast/mediastream/RTCPeerConnection-remoteDescription.html
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::checkStateForLocalDescription): Checks if the current state of RTCPeerConnection is
valid for the local SDP that is being set.
(WebCore::RTCPeerConnection::checkStateForRemoteDescription): Checks if the current state of RTCPeerConnection
is valid for the remote SDP that is being set.
(WebCore::RTCPeerConnection::setLocalDescription): Now calls checkStateForLocalDescription prior to set the
local SDP.
(WebCore::RTCPeerConnection::setRemoteDescription): Now Calls checkStateForRemoteDescription prior to set the
remote SDP.
- Modules/mediastream/RTCPeerConnection.h:
- platform/mock/RTCNotifiersMock.cpp: Adding new class to notify RTCPeerConnection about a signaling state
change: SignalingStateNotifier.
(WebCore::SignalingStateNotifier::SignalingStateNotifier):
(WebCore::SignalingStateNotifier::fire):
- platform/mock/RTCNotifiersMock.h:
- platform/mock/RTCPeerConnectionHandlerMock.cpp:
(WebCore::RTCPeerConnectionHandlerMock::signalingStateFromSDP): Defines the new state that RTCPeerConnection
should be, according the SDP that is being set.
(WebCore::RTCPeerConnectionHandlerMock::setLocalDescription): Calls signalingStateFromSDP, in order to get the
new signaling state and notify RTCPeerConnection object.
(WebCore::RTCPeerConnectionHandlerMock::setRemoteDescription): Ditto.
- platform/mock/RTCPeerConnectionHandlerMock.h:
LayoutTests:
- fast/mediastream/RTCPeerConnection-have-local-answer.html: Added.
- fast/mediastream/RTCPeerConnection-have-local-offer-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-have-local-offer.html: Added.
- fast/mediastream/RTCPeerConnection-have-local-pranswer-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-have-local-pranswer.html: Added.
- fast/mediastream/RTCPeerConnection-have-remote-offer-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-have-remote-offer.html: Added.
- fast/mediastream/RTCPeerConnection-have-remote-pranswer-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-have-remote-pranswer.html: Added.
- fast/mediastream/RTCPeerConnection-remoteDescription-expected.txt:
- fast/mediastream/RTCPeerConnection-remoteDescription.html:
- fast/mediastream/RTCPeerConnection-stable-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-stable.html: Added.
- 7:48 PM Changeset in webkit [160692] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Remove unused contentAnchor SPI from WKView
https://bugs.webkit.org/show_bug.cgi?id=125826
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _setDrawingAreaSize:]):
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- 7:06 PM Changeset in webkit [160691] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed build fix for 64-bit.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Corrected 64-bit linker symbols.
- 6:56 PM Changeset in webkit [160690] by
-
- 2 edits in trunk/Source/WebCore
Revert a mysterious and inexplicable part of http://trac.webkit.org/changeset/160685
- platform/KeyedCoding.h:
(WebCore::KeyedEncoder::encodeEnum):
(WebCore::KeyedEncoder::encodeObject):
(WebCore::KeyedEncoder::encodeConditionalObject):
(WebCore::KeyedEncoder::encodeObjects):
- 6:43 PM Changeset in webkit [160689] by
-
- 2 edits in trunk/Tools
Add my Samsung email address.
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 6:43 PM Changeset in webkit [160688] by
-
- 3 edits in trunk/Source/JavaScriptCore
Avoid indirect function calls for custom getters
https://bugs.webkit.org/show_bug.cgi?id=125821
Reviewed by Mark Hahnenberg.
Rather than invoking a helper function to perform an indirect call
through a function pointer, just have the JIT call the function directly.
Unfortunately this only works in JSVALUE64 at the moment as there
is not an obvious way to pass two EncodedJSValues uniformly over
the various effected JITs.
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):
- jit/Repatch.cpp:
(JSC::generateProtoChainAccessStub):
(JSC::tryBuildGetByIDList):
- 6:27 PM Changeset in webkit [160687] by
-
- 19 edits1 delete in trunk/Source
Remove EnumClass.h from WTF
https://bugs.webkit.org/show_bug.cgi?id=125820
Reviewed by Darin Adler.
Source/WebCore:
Replace uses of ENUM_CLASS with real enum class declarations.
- Modules/webdatabase/DatabaseBasicTypes.h:
- Modules/webdatabase/DatabaseError.h:
- Modules/webdatabase/SQLTransactionState.h:
- bindings/js/JSSubtleCryptoCustom.cpp:
- bindings/js/SerializedScriptValue.cpp:
- crypto/CryptoAlgorithmIdentifier.h:
- crypto/CryptoAlgorithmParameters.h:
- crypto/CryptoKey.h:
- crypto/CryptoKeyData.h:
- crypto/CryptoKeyType.h:
- crypto/keys/CryptoKeyDataRSAComponents.h:
- inspector/InspectorTimelineAgent.h:
Source/WTF:
All compilers we build on now support real strongly typed enums, so we can remove the ENUM_CLASS version.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CheckedArithmetic.h:
- wtf/EnumClass.h: Removed.
- 6:16 PM Changeset in webkit [160686] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2 View Gestures: Pinching beyond the extremes doesn't animate back to the min/max
https://bugs.webkit.org/show_bug.cgi?id=125750
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Remove some accidentally included commented out code.
- 6:12 PM Changeset in webkit [160685] by
-
- 7 edits in trunk/Source
WebKit2 View Gestures: Pinching beyond the extremes doesn't animate back to the min/max
https://bugs.webkit.org/show_bug.cgi?id=125750
Reviewed by Simon Fraser.
When you let go of a pinch where you exceeded the maximum or minimum scale,
the view should animate back to the limit instead of snapping back.
- UIProcess/mac/ViewGestureController.cpp:
(WebKit::ViewGestureController::endMagnificationGesture):
Unscrolling the scaled origin here is wrong; we should send the same
value for 'origin' for commitTransientZoom that we do for adjustTransientZoom.
The drawing area can deal with transforming that however it needs to call scalePage().
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::beginTransientZoom):
Drive-by use WebPage::mainFrameView().
(WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
Update the shadow layer's bounds, position, and shadow path while zooming,
instead of hiding it.
(WebKit::transientZoomSnapAnimationForKeyPath):
Create a CABasicAnimation that stays applied to its target when it finishes,
lasts for a quarter second, and uses the ease-in-ease-out timing function.
(WebKit::constrainZoomOriginForFrameView):
When we land a transient zoom, there may be overhang areas (linen, in the case of Mac)
visible. During the commit animation, we should move the RenderView layer appropriately
so that the page covers the entire view and there are no overhang areas visible.
Adapt some code from ScrollableArea to constrain the zoom origin to do so.
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Animate the RenderView layer's transform, and the shadow layer's bounds, position, and path.
When they complete, apply the zoom via scalePage() and flush the layer tree (otherwise there
can be a flash between removing the animations and the next flush with the new scale).
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
Move the code to land the transient zoom (via scalePage) and to put the shadow back
in the state WebCore left it out into its own function, so it can be called both from the
animation completion callback and from the short-circuit in the case where we don't need to animate.
- WebCore.exp.in:
Export a few things so WebKit2 can use them.
- 6:02 PM Changeset in webkit [160684] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed. Fix GTK+ build after r160653.
Renamed WebData to API::Data
- GNUmakefile.list.am: Added APIData.cpp and APIData.h
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestReadCallback):
- UIProcess/API/gtk/WebKitWebResource.cpp:
- UIProcess/API/gtk/WebKitWebView.cpp:
- 6:00 PM Changeset in webkit [160683] by
-
- 8 edits in trunk/Source
Fix some whitespace issues in inspector code
https://bugs.webkit.org/show_bug.cgi?id=125814
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-16
Reviewed by Darin Adler.
Source/JavaScriptCore:
- inspector/protocol/Debugger.json:
- inspector/protocol/Runtime.json:
- inspector/scripts/CodeGeneratorInspector.py:
(Generator.process_command):
Source/WebCore:
- inspector/protocol/DOM.json:
- inspector/protocol/DOMStorage.json:
- inspector/protocol/Timeline.json:
- 5:36 PM Changeset in webkit [160682] by
-
- 10 edits2 deletes in trunk/Source/WebCore
Web Inspector: Use JSC::SourceID and JSC::BreakpointID instead of WebCore dups
https://bugs.webkit.org/show_bug.cgi?id=125818
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-12-16
Reviewed by Mark Lam.
Remove the WebCore typedefs of JSC types. Prefer JSC namespace
prefixed types throughout WebCore's Inspector code.
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/BreakpointID.h: Removed.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
- bindings/js/ScriptDebugServer.h:
- bindings/js/SourceID.h: Removed.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):
- inspector/InspectorDebuggerAgent.h:
- inspector/ScriptDebugListener.h:
- 5:35 PM Changeset in webkit [160681] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][iOS] WKView sends unscaled scroll position to WKContentView
https://bugs.webkit.org/show_bug.cgi?id=125819
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-16
Reviewed by Anders Carlsson.
WKView was sending untransformed scroll coordinates to WKContentView. The scroll position
seen by WebKit was wrong when the content is scaled.
- UIProcess/API/ios/WKView.mm:
(-[WKView _didScroll]):
(-[WKView scrollViewDidEndDragging:willDecelerate:]):
(-[WKView scrollViewDidEndDecelerating:]):
(-[WKView scrollViewDidScrollToTop:]):
- 5:33 PM Changeset in webkit [160680] by
-
- 8 edits in trunk/Source/JavaScriptCore
Add some missing functions to MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=125809
Reviewed by Oliver Hunt.
- assembler/AbstractMacroAssembler.h:
- assembler/AssemblerBuffer.h:
- assembler/LinkBuffer.cpp:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::storePtr):
(JSC::MacroAssembler::andPtr):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::and64):
(JSC::MacroAssemblerARM64::branchTest8):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branchTest8):
- assembler/X86Assembler.h:
- 5:32 PM Changeset in webkit [160679] by
-
- 40 edits in trunk/Source/WebCore
[iOS] Upstream WebCore/dom changes
https://bugs.webkit.org/show_bug.cgi?id=125646
Reviewed by David Kilzer.
- WebCore.exp.in: Added symbol ZN7WebCore8Settings17setLayoutIntervalEi and removed symbol
ZN7WebCore24cLayoutScheduleThresholdE.
- dom/ActiveDOMObject.h: Add suspension reason DocumentWillBePaused.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument): Opt-out of ENABLE(VIDEO) logic when
building for iOS.
- dom/DeviceMotionClient.h: Made class non-copyable.
(WebCore::DeviceMotionClient::DeviceMotionClient): Added;
- dom/DeviceMotionController.cpp: Added FIXME comment to reconcile iOS and OpenSource differences.
(WebCore::DeviceMotionController::suspendUpdates): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceMotionController::resumeUpdates): Added; guarded by PLATFORM(IOS).
- dom/DeviceMotionController.h: Added FIXME comment to reconcile iOS and OpenSource differences.
- dom/DeviceOrientationClient.h: Made class non-copyable.
(WebCore::DeviceOrientationClient::DeviceOrientationClient): Added.
- dom/DeviceOrientationController.cpp: Added FIXME comment to reconcile iOS and OpenSource differences.
(WebCore::DeviceOrientationController::DeviceOrientationController):
(WebCore::DeviceOrientationController::suspendUpdates): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationController::resumeUpdates): Added; guarded by PLATFORM(IOS).
- dom/DeviceOrientationController.h: Added FIXME comment to reconcile iOS and OpenSource differences.
- dom/DeviceOrientationData.cpp:
(WebCore::DeviceOrientationData::create): Added; iOS-specific. Added FIXME comment.
(WebCore::DeviceOrientationData::DeviceOrientationData): Added iOS-specific code.
(WebCore::DeviceOrientationData::compassHeading): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationData::compassAccuracy): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationData::canProvideCompassHeading): Added; guarded by PLATFORM(IOS).
(WebCore::DeviceOrientationData::canProvideCompassAccuracy): Added; guarded by PLATFORM(IOS).
- dom/DeviceOrientationData.h:
- dom/DeviceOrientationEvent.idl: Added iOS-specific code.
- dom/Document.cpp: Moved constant cLayoutScheduleThreshold to Settings.cpp and renamed it
layoutScheduleThreshold towards allowing a port to configure the layout interval.
(WebCore::Document::Document): Added optional argument isSynthesized, defaults false.
(WebCore::Document::~Document): Added iOS-specific code to destroy the device motion
and device orientation controllers.
(WebCore::Document::didBecomeCurrentDocumentInFrame): Added iOS-specific code with FIXME comment.
(WebCore::Document::prepareForDestruction): Added iOS-specific touch event code.
(WebCore::Document::removeAllEventListeners): Ditto.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Added; compiles to an empty function on
non-iOS port.
(WebCore::Document::suspendActiveDOMObjects): Modified to call platformSuspendOrStopActiveDOMObjects().
(WebCore::Document::resumeActiveDOMObjects): Ditto.
(WebCore::Document::stopActiveDOMObjects): Added.
(WebCore::Document::implicitClose): Modified to query Settings::layoutInterval().
(WebCore::Document::minimumLayoutDelay): Ditto.
(WebCore::Document::processViewport): Added iOS-specific code.
(WebCore::Document::updateViewportArguments): Ditto.
(WebCore::setParserFeature): Added; guarded by PLATFORM(IOS).
(WebCore::Document::processFormatDetection): Added; guarded by PLATFORM(IOS).
(WebCore::Document::processWebAppOrientations): Added; guarded by PLATFORM(IOS).
(WebCore::Document::isTelephoneNumberParsingEnabled): Added; guarded by PLATFORM(IOS).
(WebCore::Document::setIsTelephoneNumberParsingAllowed): Added; guarded by PLATFORM(IOS).
(WebCore::Document::isTelephoneNumberParsingAllowed): Added; guarded by PLATFORM(IOS).
(WebCore::Document::initSecurityContext): Added iOS-specific code.
(WebCore::Document::suspendScheduledTasks): Added; guarded by PLATFORM(IOS).
(WebCore::Document::deviceMotionController): Added; iOS-specific.
(WebCore::Document::deviceOrientationController): Added; iOS-specific.
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Added iOS-specific code.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Added iOS-specific code.
- dom/Document.h: Register gesture events gesture{change, end, start}; guarded by ENABLE(IOS_GESTURE_EVENTS).
(WebCore::Document::isSynthesized): Added.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Added.
- dom/Document.idl:
- dom/DocumentMarker.h: Added iOS-specific changes. We should look to reconcile the differences between
iOS and OpenSource. See <rdar://problem/11306422>.
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(WebCore::DocumentMarker::DocumentMarker): Added; iOS-specific.
(WebCore::DocumentMarker::alternatives): Added; iOS-specific.
(WebCore::DocumentMarker::setAlternative): Added; iOS-specific.
(WebCore::DocumentMarker::metadata): Added; iOS-specific.
(WebCore::DocumentMarker::setMetadata): Added; iOS-specific.
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::addDictationPhraseWithAlternativesMarker):
(WebCore::DocumentMarkerController::addDictationResultMarker):
(WebCore::DocumentMarkerController::shiftMarkers):
- dom/DocumentMarkerController.h:
- dom/Element.cpp:
(WebCore::Element::focus): Add iOS-specific workaround for <rdar://problem/6699741>.
- dom/Element.h: Register gesture events gesture{change, end, start}; guarded by ENABLE(IOS_GESTURE_EVENTS).
- dom/EventContext.cpp: Opt-out of ENABLE(TOUCH_EVENTS)-guarded code when building the iOS port.
- dom/EventContext.h: Ditto.
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver::EventRelatedNodeResolver): Ditto.
(WebCore::EventDispatcher::dispatchEvent): Ditto.
(WebCore::EventPath::EventPath): Ditto.
- dom/EventNames.h: Added events webkit{currentplaybacktargetiswirelesschanged, playbacktargetavailabilitychanged}
and gesture{change, end, start}.
- dom/EventNames.in: Added event names GestureEvent and WebKitPlaybackTargetAvailabilityEvent conditioned on
the macro defines ENABLE_IOS_GESTURE_EVENTS and ENABLE_IOS_AIRPLAY.
- dom/MouseRelatedEvent.cpp:
(WebCore::contentsScrollOffset): Added iOS-specific code.
(WebCore::MouseRelatedEvent::MouseRelatedEvent): Ditto.
- dom/Node.cpp:
(WebCore::Node::willBeDeletedFrom): Ditto.
(WebCore::Node::isDescendantOf): Fixed style issue in function prototype; moved '*' to the left side.
(WebCore::Node::isDescendantOrShadowDescendantOf): Added.
(WebCore::tryAddEventListener): Added iOS-specific code; also added FIXME comment.
(WebCore::tryRemoveEventListener): Ditto.
(WebCore::Node::dispatchEvent): Opt-out of ENABLE(TOUCH_EVENTS)-guarded code when building the iOS port.
(WebCore::Node::defaultEventHandler): Added iOS-specific code.
(WebCore::Node::willRespondToMouseMoveEvents): Added iOS-specific code; also added FIXME comment.
(WebCore::Node::willRespondToMouseClickEvents): Added iOS-specific code; also added FIXME comment.
(WebCore::Node::willRespondToMouseWheelEvents): Added.
- dom/Node.h:
- dom/Position.h:
(WebCore::operator<): Added.
(WebCore::operator>): Added.
(WebCore::operator>=): Added.
(WebCore::operator<=): Added.
- dom/Range.cpp:
(WebCore::Range::create): Added iOS-specific code; also added FIXME comment.
(WebCore::intervalsSufficientlyOverlap): Added; guarded by PLATFORM(IOS).
(WebCore::printRects): Added; guarded by PLATFORM(IOS).
(WebCore::adjustLineHeightOfSelectionRects): Added; guarded by PLATFORM(IOS).
(WebCore::coalesceSelectionRects): Added; guarded by PLATFORM(IOS).
(WebCore::Range::collectSelectionRects): Added; guarded by PLATFORM(IOS).
- dom/Range.h:
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Added iOS-specific code.
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Ditto.
- dom/TreeScope.cpp:
(WebCore::nodeFromPoint): Ditto.
- dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes): Ditto.
(WebCore::setViewportFeature): Added iOS-specific code.
(WebCore::finalizeViewportArguments): Added; iOS-specific.
- dom/ViewportArguments.h:
- dom/make_names.pl: Added support to find the path to gcc with respect to the environment
variable SDKROOT.
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::suspend):
- page/Settings.cpp:
(WebCore::Settings::Settings): Initialize setting m_layoutInterval to layoutScheduleThreshold.
(WebCore::Settings::setLayoutInterval): Added.
- page/Settings.h:
(WebCore::Settings::layoutInterval): Added.
- 5:12 PM Changeset in webkit [160678] by
-
- 14 edits in trunk/Source/WebKit2
DatabaseProcess: Plumb through messaging for the 4 basic transaction operations
https://bugs.webkit.org/show_bug.cgi?id=125816
Reviewed by Alexey Proskuryakov.
The messaging begins and ends in the WebProcess:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::didBeginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::didCommitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::didResetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::didRollbackTransaction):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
It travels from the WebProcess to the DatabaseProcess connection:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::beginTransaction):
(WebKit::DatabaseProcessIDBConnection::commitTransaction):
(WebKit::DatabaseProcessIDBConnection::resetTransaction):
(WebKit::DatabaseProcessIDBConnection::rollbackTransaction):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
It travels from the connection to the appropriate UniqueIDBDatabase:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::openTransaction):
(WebKit::UniqueIDBDatabase::beginTransaction):
(WebKit::UniqueIDBDatabase::commitTransaction):
(WebKit::UniqueIDBDatabase::resetTransaction):
(WebKit::UniqueIDBDatabase::rollbackTransaction):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::didCompleteTransactionOperation):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::beginBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::commitBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::rollbackBackingStoreTransaction):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
The UniqueIDBDatabase object performs the operation with the backing store:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::establishTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::beginTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::commitTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::resetTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::rollbackTransaction):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
And the SQLite backing store calls the appropriate method on the SQLite transaction:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
(WebKit::SQLiteIDBTransaction::begin): Stubbed for now.
(WebKit::SQLiteIDBTransaction::commit): Ditto.
(WebKit::SQLiteIDBTransaction::reset): Ditto.
(WebKit::SQLiteIDBTransaction::rollback): Ditto.
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
- 4:55 PM Changeset in webkit [160677] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the Windows build after r160672.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::PlatformCALayerWin):
- platform/graphics/ca/win/PlatformCALayerWin.h:
- 4:44 PM Changeset in webkit [160676] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed build fix on EFL port after r160653
Rename WebData to API::Data
- CMakeLists.txt: Added APIData.cpp to include list.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):
- UIProcess/soup/WebSoupRequestManagerProxy.cpp:
(WebKit::WebSoupRequestManagerProxy::didHandleURIRequest):
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequestData):
(WebKit::WebSoupRequestManagerProxy::didReceiveURIRequest):
- UIProcess/soup/WebSoupRequestManagerProxy.h:
- 4:35 PM Changeset in webkit [160675] by
-
- 4 edits in trunk/Source/WebKit2
WKView.magnification should include magnification due to the active gesture
https://bugs.webkit.org/show_bug.cgi?id=125813
Reviewed by Simon Fraser.
Make WKView.magnification respect active pinch-zoom gestures.
- UIProcess/API/mac/WKView.mm:
(-[WKView magnification]):
If we have a ViewGestureController, defer to it for the current magnification.
- UIProcess/mac/ViewGestureController.cpp:
(WebKit::ViewGestureController::magnification):
Return either the current pinch-zoom magnification, if we're in the middle of a gesture,
or the pageScaleFactor, if we're not.
- UIProcess/mac/ViewGestureController.h:
- 4:29 PM Changeset in webkit [160674] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Correct typo that added a '\' at the
end of a line of the file.
- 4:24 PM Changeset in webkit [160673] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Remove the constraint that highlight rects must be smaller than the scrollview bounds
https://bugs.webkit.org/show_bug.cgi?id=125812
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-16
Reviewed by Dan Bernstein.
Currently, _scrollView is never set on WKInteractionView and all highlight rects are discarded.
Eventually, the constraint rect should be computed from the useful area of ScrollView and the scale
of the document. In the meantime, the constraint code is just causing troubles.
The issue is tracked by <rdar://problem/15673655>.
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
- 4:13 PM Changeset in webkit [160672] by
-
- 19 edits in trunk/Source
Apply overhang shadow and linen to UI-side layers
https://bugs.webkit.org/show_bug.cgi?id=125807
Source/WebCore:
Reviewed by Tim Horton.
With UI-side compositing, we need to apply the overhang shadow and linen
background to layers in the UI process. Achieve this by setting a "custom
appearance" flag on layers that need a shadow or linen background, and
migrating this flag to the UI process. Static functions on ScrollbarThemeMac
are exposed to do the actual setting.
- WebCore.exp.in: Export ScrollbarThemeMac and GraphicsLayerCA functions.
- WebCore.xcodeproj/project.pbxproj: ScrollbarThemeMac.h and ScrollbarThemeComposite.h
need to be Private.
- platform/graphics/GraphicsLayer.cpp: Initialize m_customAppearance.
(WebCore::GraphicsLayer::GraphicsLayer):
- platform/graphics/GraphicsLayer.h: Getter/setter for CustomAppearance.
(WebCore::GraphicsLayer::setCustomAppearance):
(WebCore::GraphicsLayer::customAppearance):
- platform/graphics/ca/GraphicsLayerCA.cpp: Update CustomAppearanceChanged as
we do other properties.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateCustomAppearance):
(WebCore::GraphicsLayerCA::setCustomAppearance):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/mac/PlatformCALayerMac.h:
- platform/graphics/ca/mac/PlatformCALayerMac.mm: When we have a custom
appearance, use ScrollbarThemeMac functions to update the layer. Ensure
that if the bounds change, we update the shadow (whose path depends on the bounds).
(PlatformCALayerMac::PlatformCALayerMac):
(PlatformCALayerMac::clone):
(PlatformCALayerMac::setBounds):
(PlatformCALayerMac::requiresCustomAppearanceUpdateOnBoundsChange):
(PlatformCALayerMac::updateCustomAppearance):
- platform/mac/ScrollbarThemeMac.h: Export some static functions.
- platform/mac/ScrollbarThemeMac.mm: Change code to use static functions.
(WebCore::ScrollbarThemeMac::setUpOverhangAreaBackground):
(WebCore::ScrollbarThemeMac::removeOverhangAreaBackground):
(WebCore::ScrollbarThemeMac::setUpOverhangAreaShadow):
(WebCore::ScrollbarThemeMac::removeOverhangAreaShadow):
(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents):
(WebCore::ScrollbarThemeMac::setUpContentShadowLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition): No need to call
setUpContentShadowLayer() now when size changes; PlatformCALayer takes
care of that.
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers): Now set
custom appearance via GraphicsLayer.
Source/WebKit2:
Reviewed by Tim Horton.
With UI-side compositing, we need to apply the overhang shadow and linen
background to layers in the UI process. Achieve this by setting a "custom
appearance" flag on layers that need a shadow or linen background, and
migrating this flag to the UI process. Static functions on ScrollbarThemeMac
are exposed to do the actual setting.
- Shared/mac/RemoteLayerTreePropertyApplier.mm:
(WebKit::updateCustomAppearance): Use ScrollbarThemeMac to update the
appearance.
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
- Shared/mac/RemoteLayerTreeTransaction.h:
- Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(PlatformCALayerRemote::setBounds): If the bounds change, also set the
CustomAppearanceChanged bit so that the UI side updates the shadow bounds
(done here because the UI side is not stateful).
(PlatformCALayerRemote::requiresCustomAppearanceUpdateOnBoundsChange):
(PlatformCALayerRemote::customAppearance):
(PlatformCALayerRemote::updateCustomAppearance):
- WebProcess/WebPage/mac/PlatformCALayerRemote.h:
- 4:06 PM Changeset in webkit [160671] by
-
- 18 edits in trunk/Source
Source/JavaScriptCore: [Win] Remove dead code after conversion to VS2013
https://bugs.webkit.org/show_bug.cgi?id=125795
Reviewed by Darin Adler.
- API/tests/testapi.c: Remove local nan implementation
Source/WebCore: [Win] Remove dead code after converstion to VS2013
https://bugs.webkit.org/show_bug.cgi?id=125795
Reviewed by Darin Adler.
- WebCorePrefix.h: Remove VS2012 include kludge.
- loader/FTPDirectoryParser.cpp: Remove gmtime workaround code.
- page/DOMWindow.cpp: Remove older pointer-based open implementation.
- page/DOMWindow.h: Ditto
- platform/text/TextEncodingRegistry.cpp:
(WebCore::TextEncodingNameHash::equal): Remove optimization bug workaround
- testing/Internals.cpp:
(WebCore::Internals::openDummyInspectorFrontend): Remove compiler workaround
Source/WebKit: [Win] Remove dead code after conversion to VS2013
https://bugs.webkit.org/show_bug.cgi?id=125795
Reviewed by Darin Adler.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Remove unused function exports.
Source/WTF: [Win] Remove dead code after conversion to VS2013
https://bugs.webkit.org/show_bug.cgi?id=125795
Reviewed by Darin Adler.
- wtf/Assertions.h: Include <inttypes.h> now that it exists.
- wtf/Compiler.h: Update compiler checks for VS2013, and
enable support for NEVER_INLINE
- wtf/HashFunctions.h:
(WTF::PtrHash::hash): Remove compiler workaround.
- wtf/MathExtras.h: Remove C99 functions that are now supplied
by the MS runtime library.
- wtf/Platform.h: Remove old MSVC support flags.
- wtf/StdLibExtras.h: Remove old MSVC workaround code.
- 4:01 PM Changeset in webkit [160670] by
-
- 7 edits18 adds in trunk
Cache getters and custom accessors on the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=125602
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Support caching of custom getters and accessors on the prototype chain.
This is relatively trivial and just requires a little work compared to
the direct access mode as we're under more register pressure.
- bytecode/StructureStubInfo.h: Removed the unsued initGetByIdProto as it was confusing to still have it present.
- jit/Repatch.cpp:
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
Tools:
Make sure bencher scripts also make noInline exist
- Scripts/bencher:
LayoutTests:
Added a bunch of new tests
- js/regress/chain-custom-getter-expected.txt: Added.
- js/regress/chain-custom-getter.html: Added.
- js/regress/chain-getter-access-expected.txt: Added.
- js/regress/chain-getter-access.html: Added.
- js/regress/proto-custom-getter-expected.txt: Added.
- js/regress/proto-custom-getter.html: Added.
- js/regress/proto-getter-access-expected.txt: Added.
- js/regress/proto-getter-access.html: Added.
- js/regress/resources/regress-pre.js: Made sure that noInline always exists (either using testRunner.neverInlineFunction or a no-op function if nothing else is available)
- js/regress/script-tests/chain-custom-getter.js: Added.
(foo):
- js/regress/script-tests/chain-getter-access.js: Added.
(o.get value):
(foo):
- js/regress/script-tests/proto-custom-getter.js: Added.
(foo):
- js/regress/script-tests/proto-getter-access.js: Added.
(o.get value):
(foo):
- js/regress/script-tests/simple-custom-getter.js: Added.
(cycles.30000.numberObject.Number.foo):
- js/regress/script-tests/simple-getter-access.js: Added.
(o.get value):
(foo):
- js/regress/simple-custom-getter-expected.txt: Added.
- js/regress/simple-custom-getter.html: Added.
- js/regress/simple-getter-access-expected.txt: Added.
- js/regress/simple-getter-access.html: Added.
- 3:54 PM Changeset in webkit [160669] by
-
- 10 edits in trunk/Source/WebCore
[iOS] Upstream WebCore/history changes
https://bugs.webkit.org/show_bug.cgi?id=125769
Reviewed by Darin Adler.
- history/BackForwardClient.h:
- history/BackForwardList.cpp:
(WebCore::BackForwardList::current): Added; guard by PLATFORM(IOS). Also added FIXME comment.
(WebCore::BackForwardList::setCurrent): Added; guard by PLATFORM(IOS). Also added FIXME comment.
(WebCore::BackForwardList::clearAllPageCaches): Added; guarded by PLATFORM(IOS).
- history/BackForwardList.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Added iOS-specific code.
(WebCore::CachedFrame::CachedFrame): Ditto.
- history/CachedPage.cpp:
(WebCore::CachedPage::restore): Ditto.
- history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem): Ditto.
- history/HistoryItem.h:
(WebCore::HistoryItem::scale): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::scaleIsInitial): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setScale): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::viewportArguments): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setViewportArguments): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::bookmarkID): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setBookmarkID): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::sharedLinkUniqueIdentifier): Added; guarded by PLATFORM(IOS).
(WebCore::HistoryItem::setSharedLinkUniqueIdentifier): Added; guarded by PLATFORM(IOS).
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision): Added iOS-specific code.
(WebCore::logCanCachePageDecision): Ditto.
(WebCore::PageCache::canCachePageContainingThisFrame): Ditto.
(WebCore::PageCache::canCache): Ditto.
(WebCore::PageCache::pruneToCapacityNow): Added.
- history/PageCache.h:
- 3:25 PM Changeset in webkit [160668] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Upstream WebCore/svg changes
https://bugs.webkit.org/show_bug.cgi?id=125784
Reviewed by Darin Adler.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::willRespondToMouseClickEvents): Added.
- svg/SVGAElement.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseAttribute): Added attribute listeners for touch{cancel, end, move, start},
and gesture{change, end, start}.
- 3:23 PM Changeset in webkit [160667] by
-
- 15 edits2 copies1 add in trunk/Source/WebKit2
DatabaseProcess: Implement openTransaction()
https://bugs.webkit.org/show_bug.cgi?id=125794
Reviewed by Darin Adler.
This patch hooks up all of the necessary infrastructure to open a uniquely
identified transaction in the DatabaseProcess backing store.
The transaction itself is not yet functional.
Add openTransaction messaging to the WebProcess side:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::isClosed):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::didOpenTransaction):
(WebKit::WebIDBServerConnection::deleteObjectStore):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
Add openTransaction messaging to the DatabaseProcess side:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::openTransaction):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
Add a hashable identifier that represents a connection/transactionID pair:
- DatabaseProcess/IndexedDB/IDBTransactionIdentifier.h: Added.
(WebKit::IDBTransactionIdentifier::IDBTransactionIdentifier):
(WebKit::IDBTransactionIdentifier::isolatedCopy):
(WebKit::IDBTransactionIdentifier::isEmpty):
(WebKit::IDBTransactionIdentifier::hash):
(WebKit::IDBTransactionIdentifier::operator==):
(WebKit::IDBTransactionIdentifier::isHashTableDeletedValue):
(WebKit::IDBTransactionIdentifierHash::hash):
(WebKit::IDBTransactionIdentifierHash::equal):
(WebKit::IDBTransactionIdentifierHashTraits::isEmptyValue):
Allow that identifier to be cross-thread copied:
- Shared/WebCrossThreadCopier.cpp:
(WebCore::::copy):
- Shared/WebCrossThreadCopier.h:
Ask the backing store to open this uniquely identified transaction:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::openTransaction):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::didOpenBackingStoreTransaction):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
Add the backing store implementation for opening a transaction:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::establishTransaction):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
Object to represent the backing store transaction itself, to be used in future patches:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:
(WebKit::SQLiteIDBTransaction::SQLiteIDBTransaction):
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
(WebKit::SQLiteIDBTransaction::create):
(WebKit::SQLiteIDBTransaction::identifier):
- WebKit2.xcodeproj/project.pbxproj:
- 2:59 PM Changeset in webkit [160666] by
-
- 4 edits in branches/jsCStack/Source
Merged r160665 from trunk.
2013-12-16 Mark Lam <mark.lam@apple.com>
Change slow path result to take a void* instead of a ExecState*.
https://bugs.webkit.org/show_bug.cgi?id=125802.
Reviewed by Filip Pizlo.
This is in preparation for C Stack OSR entry work that is coming soon.
In the OSR entry case, we'll be returning a topOfFrame pointer value
instead of the ExecState*.
- offlineasm/cloop.rb:
- runtime/CommonSlowPaths.h: (JSC::encodeResult): (JSC::decodeResult):
- 2:52 PM Changeset in webkit [160665] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change slow path result to take a void* instead of a ExecState*.
https://bugs.webkit.org/show_bug.cgi?id=125802.
Reviewed by Filip Pizlo.
This is in preparation for C Stack OSR entry work that is coming soon.
In the OSR entry case, we'll be returning a topOfFrame pointer value
instead of the ExecState*.
- offlineasm/cloop.rb:
- runtime/CommonSlowPaths.h:
(JSC::encodeResult):
(JSC::decodeResult):
- 2:51 PM Changeset in webkit [160664] by
-
- 4 edits in trunk
Fix crash when trying to load a null HTML string
https://bugs.webkit.org/show_bug.cgi?id=125801
Reviewed by Dan Bernstein.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadString):
Check that the string is not null before calling is8Bit(). Also, Use the latin1 encoding for
8-bit strings, since Latin 1 strings are not necessarily valid UTF-8 strings.
Tools:
- TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
(TestWebKitAPI::TEST_F):
Update test results.
- 2:41 PM Changeset in webkit [160663] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Cache partitioning asserts when associated NSURLRequest is nil
https://bugs.webkit.org/show_bug.cgi?id=125716
Reviewed by Darin Adler.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
- 2:17 PM Changeset in webkit [160662] by
-
- 6 edits in trunk/Source/WebKit2
[Cocoa] Expose whether the page contains only secure content
https://bugs.webkit.org/show_bug.cgi?id=125758
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController hasOnlySecureContent]): Added a getter that calls
PageLoadState::hasOnlySecureContent.
- UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h: Declared new property.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::commitChanges): Notify observers of hasOnlySecureContent() changes.
(WebKit::PageLoadState::reset): Reset hasInsecureContent in the uncommitted state.
(WebKit::PageLoadState::hasOnlySecureContent): Added. Returns true if there is no insecure
content and the URL is an HTTPS URL.
(WebKit::PageLoadState::didCommitLoad): Set hasInsecureContent to false in the uncommitted
state.
(WebKit::PageLoadState::didDisplayOrRunInsecureContent): Set hasInsecureContent to true in
the uncommitted state.
- UIProcess/PageLoadState.h:
(WebKit::PageLoadState::Data::Data): Added hasInsecureContent member.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame): Call
PageLoadState::didDisplayOrRunInsecureContent and commit the change before calling out to
the client.
(WebKit::WebPageProxy::didRunInsecureContentForFrame): Ditto.
- 2:07 PM Changeset in webkit [160661] by
-
- 3 edits2 adds1 delete in trunk/Source/WebKit2
[WK2] The NetworkProcess tries to load SecItemShim.dylib on iOS
https://bugs.webkit.org/show_bug.cgi?id=125800
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-16
Reviewed by Dan Bernstein.
Give the NetworkService its own Info.plist configured without the Shim.
- Configurations/NetworkService.xcconfig:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist: Renamed from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist.
- WebKit2.xcodeproj/project.pbxproj:
- 1:31 PM Changeset in webkit [160660] by
-
- 7 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: Eliminate topOfStack parameter from callToJavaScript() and callToNativeFunction()
https://bugs.webkit.org/show_bug.cgi?id=125791
Reviewed by Geoffrey Garen.
Eliminated topOfStack from the callToJavaScript() and callToNativeFunction() calling chains.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
- jit/JITCode.cpp:
(JSC::JITCode::execute):
- jit/JITCode.h:
- jit/JITStubs.h:
- llint/LLIntThunks.h:
- llint/LowLevelInterpreter.asm:
- 1:26 PM Changeset in webkit [160659] by
-
- 4 edits in trunk/Source
DatabaseProcess: Fix a few bugs with opening an IDB connection
https://bugs.webkit.org/show_bug.cgi?id=125798
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::processPendingCalls): As the comment says, we should only
early return when there *are* pending delete calls. The logic here was backwards,
preventing the backend from ever getting to processPendingOpenCalls().
Source/WebKit2:
Database metadata always needs a non-zero database identifier, unique at runtime.
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::generateDatabaseId):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):
- 1:23 PM Changeset in webkit [160658] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
CStack Branch: REGRESSION(r160600) ASSERT failure in Heap::collect()
https://bugs.webkit.org/show_bug.cgi?id=125789
Reviewed by Geoffrey Garen.
Restored the shouldCollect() check so we don't collect on start up.
Eliminated the Options::disableGC() check since it is part of the
isDeferred() check.
- heap/Heap.cpp:
(JSC::Heap::collectIfNecessaryOrDefer):
- 12:47 PM Changeset in webkit [160657] by
-
- 4 edits1 add in trunk/Source/WebKit2
UserData should encode and decode API::Data objects
https://bugs.webkit.org/show_bug.cgi?id=125799
Reviewed by Beth Dakin.
- Shared/APIData.cpp: Added.
(API::Data::encode):
(API::Data::decode):
- Shared/APIData.h:
- Shared/UserData.cpp:
(WebKit::UserData::encode):
(WebKit::UserData::decode):
- WebKit2.xcodeproj/project.pbxproj:
- 12:46 PM Changeset in webkit [160656] by
-
- 7 edits in branches/jsCStack/Source/JavaScriptCore
Fix exception handling for the baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=125736.
Reviewed by Geoffrey Garen.
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
Removed some unneeded code.
- Removed use of the oldCodeBlock variable which is only a copy of the codeBlock variable. There is no longer any reason to use a copy. Just use codeBlock directly instead.
- There's no need to set VM::topCallFrame. The UnwindFunctor automatically updates the incoming callFrame pointer reference to the frame that should be catching / handling the exception, and that is adequate for what we need.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
- Restored sp.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_catch):
- jit/ThunkGenerators.cpp:
(JSC::nativeForGenerator):
Fixed 2 issues:
- After returning from a native / host function, the thunk did not pop the native / host frame before executing exception handling code. This resulted in the VM trying to "unwind" the native / host frame which is not possible, and crashes ensue.
- After returning from a native / host function and discovering the need to handle an exception, the thunk was wrongly popping a non-existant return address off the stack. This caused the callerFrame pointer of the current frame to be popped off the stack, and havoc ensues.
- llint/LowLevelInterpreter32_64.asm:
- Updated to match exception handling code in LowLevelInterpreter64.asm.
- runtime/VM.h:
- Removed dead code.
- 12:44 PM Changeset in webkit [160655] by
-
- 43 edits in trunk
Fixed Win64 build on VS2013.
https://bugs.webkit.org/show_bug.cgi?id=125753
Patch by Alex Christensen <achristensen@webkit.org> on 2013-12-16
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
Added correct PlatformToolset for 64-bit builds.
Source/ThirdParty/ANGLE:
- ANGLE.vcxproj/libGLESv2.vcxproj:
- ANGLE.vcxproj/preprocessor.vcxproj:
- ANGLE.vcxproj/translator_common.vcxproj:
- ANGLE.vcxproj/translator_glsl.vcxproj:
- ANGLE.vcxproj/translator_hlsl.vcxproj:
Added correct PlatformToolset for 64-bit builds.
Source/WebCore:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCoreTestSupport.vcxproj:
Added correct PlatformToolset for 64-bit builds.
Source/WebInspectorUI:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
Added 64-bit configuration.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Use new 64-bit WebInspectorUI configurations.
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
Added correct PlatformToolset for 64-bit builds.
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
Added correct PlatformToolset for 64-bit builds.
Tools:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- win/record-memory/record-memory.vcxproj:
Added correct PlatformToolset for 64-bit builds.
- 12:41 PM Changeset in webkit [160654] by
-
- 4 edits in trunk/Tools
Add a menu option to MiniBrowser to enable UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=125793
Reviewed by Anders Carlsson.
Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
- MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
to toggle UI-side compositing.
- MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController validateMenuItem:]):
(-[WK2BrowserWindowController isUISideCompositingEnabled]):
(-[WK2BrowserWindowController toggleUISideCompositing:]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
Adjust the window title to indicate whether the window is using UI-side compositing.
- 12:21 PM Changeset in webkit [160653] by
-
- 31 edits1 move in trunk/Source/WebKit2
Rename WebData to API::Data
https://bugs.webkit.org/show_bug.cgi?id=125797
Reviewed by Beth Dakin.
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(-[WKRemoteObjectEncoder encodeBytes:length:forKey:]):
(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
- Shared/API/c/WKData.cpp:
(WKDataGetTypeID):
(WKDataCreate):
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/mac/WKWebArchive.cpp:
(WKWebArchiveCopyData):
- Shared/API/c/mac/WKWebArchiveResource.cpp:
(WKWebArchiveResourceCopyData):
- Shared/APIData.h: Renamed from Source/WebKit2/Shared/WebData.h.
(API::Data::createWithoutCopying):
(API::Data::create):
(API::Data::~Data):
(API::Data::bytes):
(API::Data::size):
(API::Data::dataReference):
(API::Data::Data):
(API::Data::fastFreeBytes):
- Shared/Cocoa/WKNSData.h:
(WebKit::wrapper):
- Shared/Cocoa/WKNSData.mm:
(-[WKNSData dealloc]):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebArchive.cpp:
(WebKit::WebArchive::create):
(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::data):
- Shared/WebArchive.h:
- Shared/WebArchiveResource.cpp:
(WebKit::WebArchiveResource::create):
(WebKit::WebArchiveResource::WebArchiveResource):
(WebKit::WebArchiveResource::data):
- Shared/WebArchiveResource.h:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
- UIProcess/API/mac/WKPrintingView.mm:
(pageDidDrawToPDF):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::createData):
(WebKit::DownloadProxy::didFail):
(WebKit::DownloadProxy::didCancel):
- UIProcess/Downloads/DownloadProxy.h:
(WebKit::DownloadProxy::resumeData):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):
- UIProcess/WebPageProxy.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
- UIProcess/WebUIClient.h:
- UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleCreateWKDataFromUInt8Array):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::createWebDataFromUint8Array):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadDataImpl):
- 11:57 AM Changeset in webkit [160652] by
-
- 8 edits in trunk/Source/WebCore
Package up some data about scrollability into a struct for use in the scrolling tree
https://bugs.webkit.org/show_bug.cgi?id=125792
Reviewed by Beth Dakin.
Both scrolling state nodes and scrolling nodes share a set of parameters
relating to scrollability and rubberbanding, so package them into a struct
for re-use. Send the struct wholesale to the scrolling thread.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollableAreaParameters::ScrollableAreaParameters): New struct.
(WebCore::ScrollableAreaParameters::operator==):
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Reordering.
(WebCore::ScrollingStateScrollingNode::setScrollOrigin): Moved.
(WebCore::ScrollingStateScrollingNode::setScrollableAreaParameters): Set the parameters all at once.
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
- page/scrolling/ScrollingStateScrollingNode.h: Getters access the struct. Reorder member variables.
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::scrollOrigin):
(WebCore::ScrollingTreeScrollingNode::horizontalScrollElasticity):
(WebCore::ScrollingTreeScrollingNode::verticalScrollElasticity):
(WebCore::ScrollingTreeScrollingNode::hasEnabledHorizontalScrollbar):
(WebCore::ScrollingTreeScrollingNode::hasEnabledVerticalScrollbar):
(WebCore::ScrollingTreeScrollingNode::canHaveScrollbars):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm: Removed setScrollParametersForNode().
(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated): Set the params in this
function. Reordering.
- 11:23 AM Changeset in webkit [160651] by
-
- 45 edits in trunk/Source/WebCore
CTTE: Convert more of SVG to use references
https://bugs.webkit.org/show_bug.cgi?id=125762
Patch by Sam Weinig <sam@webkit.org> on 2013-12-16
Reviewed by Darin Adler.
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::imageChanged):
- rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):
- rendering/svg/RenderSVGResource.h:
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::removeClientFromCache):
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
(WebCore::RenderSVGResourceContainer::markAllClientLayersForInvalidation):
(WebCore::RenderSVGResourceContainer::markClientForInvalidation):
(WebCore::RenderSVGResourceContainer::removeClient):
- rendering/svg/RenderSVGResourceContainer.h:
- rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::removeClientFromCache):
- rendering/svg/RenderSVGResourceGradient.h:
- rendering/svg/RenderSVGResourceMarker.cpp:
(WebCore::RenderSVGResourceMarker::removeClientFromCache):
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::removeClientFromCache):
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::removeClientFromCache):
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceSolidColor.h:
(WebCore::RenderSVGResourceSolidColor::removeClientFromCache):
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::invalidateResourcesOfChildren):
- rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::removeClientFromCache):
- rendering/svg/SVGResources.h:
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientLayoutChanged):
(WebCore::SVGResourcesCache::clientStyleChanged):
(WebCore::SVGResourcesCache::clientWasAddedToTree):
(WebCore::SVGResourcesCache::clientWillBeRemovedFromTree):
(WebCore::SVGResourcesCache::clientDestroyed):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::applyResultsToTarget):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::notifyFinished):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::childrenChanged):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::invalidateFilterPrimitiveParent):
- svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidate):
(WebCore::SVGFilterPrimitiveStandardAttributes::primitiveAttributeChanged):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::invalidateMPathDependencies):
(WebCore::SVGPathElement::pathSegListChanged):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged):
(WebCore::SVGSVGElement::setupInitialView):
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::svgAttributeChanged):
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::svgAttributeChanged):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::svgAttributeChanged):
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::svgAttributeChanged):
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::svgAttributeChanged):
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged):
- 11:08 AM Changeset in webkit [160650] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r160645.
http://trac.webkit.org/changeset/160645
https://bugs.webkit.org/show_bug.cgi?id=125787
Change breaks test-webkitpy (Requested by bfulgham on
#webkit).
- Scripts/prepare-ChangeLog:
(get_selector_line_ranges_for_css):
- 10:17 AM Changeset in webkit [160649] by
-
- 3 edits in trunk/Tools
[ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
https://bugs.webkit.org/show_bug.cgi?id=124610
Reviewed by Mark Rowe.
- WebKitLauncher/WebKitNightlyEnabler.m:
(enableWebKitNightlyBehaviour):
Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
- WebKitLauncher/main.m:
(main):
Include both libasancrashreporter and the nightly enabler to
the list of libraries to insert.
- 10:15 AM WebKitGTK/2.2.x edited by
- (diff)
- 10:10 AM Changeset in webkit [160648] by
-
- 13 edits in trunk/Source
Delete RVCT related code parts.
https://bugs.webkit.org/show_bug.cgi?id=125626
Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.
Source/JavaScriptCore:
- assembler/ARMAssembler.cpp:
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::cacheFlush):
- assembler/MacroAssemblerARM.cpp:
(JSC::isVFPPresent):
- jit/JITStubsARM.h:
- jit/JITStubsARMv7.h:
Source/WebKit/blackberry:
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
Source/WTF:
- wtf/Assertions.h:
- wtf/Compiler.h:
- wtf/FastMalloc.h:
- wtf/Platform.h:
- 10:04 AM Changeset in webkit [160647] by
-
- 3 edits in trunk/Tools
Resolve inconsistant style warning caused by r160319.
https://bugs.webkit.org/show_bug.cgi?id=125772
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_for_extra_new_line_at_eof):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_newline_at_eof):
(CppStyleTest.test_extra_newlines_at_eof):
- 10:01 AM Changeset in webkit [160646] by
-
- 3 edits in trunk/Tools
Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
https://bugs.webkit.org/show_bug.cgi?id=125780
Patch by Eva Balazsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.
- Scripts/webkitpy/port/mock_drt.py:
(main):
(parse_options):
(MockDRT.write_test_output):
- Scripts/webkitpy/port/mock_drt_unittest.py:
(MockDRTTest.assertTest):
(MockDRTTest.test_reftest_mismatch):
- 9:58 AM Changeset in webkit [160645] by
-
- 2 edits in trunk/Tools
prepare-Changelog treats CSS keyframes as mismatched parentheses.
https://bugs.webkit.org/show_bug.cgi?id=125435
Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-16
Reviewed by Darin Adler.
- Scripts/prepare-ChangeLog:
(get_selector_line_ranges_for_css):
- 9:55 AM Changeset in webkit [160644] by
-
- 6 edits2 adds in trunk
[CSS Shapes] Add support for the computing the included intervals for a BoxShape
https://bugs.webkit.org/show_bug.cgi?id=124605
Reviewed by Andreas Kling.
Source/WebCore:
Setting shape-inside to content-box now works.
Changed FloatRoundedRect::xInterceptsAtY() to include the bottom edge of
the rectangle and to check for the special cases where any or all of the
corner radii are empty.
Test: fast/shapes/shape-inside/shape-inside-content-box.html
- platform/graphics/FloatRoundedRect.cpp:
(WebCore::FloatRoundedRect::xInterceptsAtY):
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getIncludedIntervals): Replaced the stub implementation with logic that's similar to getExcludedIntervals().
- rendering/shapes/ShapeInfo.cpp:
(WebCore::::computedShape): Removed a meaningless assert.
- rendering/shapes/ShapeInsideInfo.cpp:
(WebCore::ShapeInsideInfo::isEnabledFor):
LayoutTests:
Check that shape-inside:content-box works with and without border radii.
- fast/shapes/shape-inside/shape-inside-content-box-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-content-box.html: Added.
- 9:01 AM Changeset in webkit [160643] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning in files including DrawingAreaProxy.h
https://bugs.webkit.org/show_bug.cgi?id=125778
Reviewed by Anders Carlsson.
Remove unused parameters from method declaration.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::adjustTransientZoom):
(WebKit::DrawingAreaProxy::commitTransientZoom):
- 8:45 AM Changeset in webkit [160642] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
PrettyPatch.rb doesn't handle diffs where lines matching /--/ are missing properly
https://bugs.webkit.org/show_bug.cgi?id=54928
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-12-16
Reviewed by Adam Roben.
PrettyPatch will now check if the next line after /--- / matches /+++ /, and if not,
then it's just a normal line
- PrettyPatch/PrettyPatch.rb:
- 8:18 AM Changeset in webkit [160641] by
-
- 8 edits in trunk
[ATK] Expose accessibility objects for more WAI-ARIA roles
https://bugs.webkit.org/show_bug.cgi?id=125596
Reviewed by Chris Fleizach.
Source/WebCore:
Exposed accessibility objects with the proper AtkRoles, some of
them to be provided by the next stable release of ATK.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Add mappings to DRT & WKTR for the newly exposed roles.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Update test to update expectations.
- platform/gtk/accessibility/roles-exposed-expected.txt:
- platform/gtk/accessibility/roles-exposed.html:
- 8:04 AM Changeset in webkit [160640] by
-
- 5 edits1 add in trunk
Fix QuickTime plug-in replacement scripting bugs
https://bugs.webkit.org/show_bug.cgi?id=125717
Reviewed by Sam Weinig.
Source/WebCore:
No new tests, existing test updated.
- Modules/plugins/QuickTimePluginReplacement.js:
(Replacement): Change to "" to avoid "Empty character constant" warning when creating
Derived Sources.
(Replacement.prototype.createVideoElement): Handle qtsrc attribute. Remember base url.
(Replacement.prototype.setURL): Resolve urls relative to base.
LayoutTests:
- plugins/quicktime-plugin-replacement-expected.txt:
- plugins/quicktime-plugin-replacement.html: Update to test 'qtsrc' attribute, and to check
that relative urls are resolved correctly.
- plugins/resources/yellow.mov: Added.
- 8:00 AM Changeset in webkit [160639] by
-
- 2 edits in trunk/Source/WebCore
Catch callers who forget to use initializeStyle
https://bugs.webkit.org/show_bug.cgi?id=125763
Reviewed by Andreas Kling.
A recent fix was because a caller used setStyle first rather than using
initializeStyle. This patch adds an assertion to catch cases where we do
that so we see the mistake right away instead of indirectly later.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle): Simplified an assertion.
(WebCore::RenderElement::setStyle): Added an assertion that m_hasInitializedStyle
is true, with an exception for RenderView, which needs to be created before we
have the correct style computed for it (at least for now). Also broke out an
assertion that was using &&, since we would prefer to know which clause failed,
making separate assertions more useful than a combined assertion.
- 7:58 AM Changeset in webkit [160638] by
-
- 8 edits in trunk
[ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
https://bugs.webkit.org/show_bug.cgi?id=125594
Reviewed by Chris Fleizach.
Source/WebCore:
Exposed accessibility objects with checkmenuitem role with the
proper AtkRole, to be provided by the next stable release of ATK.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Add mappings to DRT & WKTR for checkmenuitem role.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Update test to update expectations.
- platform/gtk/accessibility/roles-exposed-expected.txt:
- platform/gtk/accessibility/roles-exposed.html:
- 7:17 AM Changeset in webkit [160637] by
-
- 9 edits in trunk
[ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
https://bugs.webkit.org/show_bug.cgi?id=125587
Reviewed by Chris Fleizach.
Source/WebCore:
Exposed accessibility objects with article role with the proper
AtkRole, to be provided by the next stable release of ATK.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
Tools:
Add mappings to DRT & WKTR for article roles.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Update test to unskip article objects and update expectations.
- accessibility/aria-mappings-expected.txt:
- platform/gtk/accessibility/roles-exposed-expected.txt:
- platform/gtk/accessibility/roles-exposed.html:
- 7:08 AM Changeset in webkit [160636] by
-
- 2 edits in trunk/Tools
[FTL] Allow EFL to build FTL with the build-jsc script.
https://bugs.webkit.org/show_bug.cgi?id=125774
Patch by Dániel Bátyai <Dániel Bátyai> on 2013-12-16
Reviewed by Zoltan Herczeg.
- Scripts/build-jsc:
- 6:56 AM Changeset in webkit [160635] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix GTK+ build after r160549.
- GNUmakefile.am: Fix the include paths to make sure we include
the WebKit2 config.h file when building libWebKit2Platform.
- 5:19 AM Changeset in webkit [160634] by
-
- 2 edits in trunk/Tools
Add myself as a committer
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 4:08 AM Changeset in webkit [160633] by
-
- 6 edits in trunk
[CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items
https://bugs.webkit.org/show_bug.cgi?id=123994
Reviewed by Andreas Kling.
From Blink r159189 by <jchaffraix@chromium.org>
Source/WebCore:
There was no definition in the specs for the intrinsic / preferred
logical widths on the grid element. The following was proposed to
the WG and later accepted:
- The sum of the grid tracks' UsedBreadth is the minimum logical width
- The sum of the grid tracks' MaxBreadth is the maximum logical width
http://lists.w3.org/Archives/Public/www-style/2013Oct/0054.html
for more information.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
- rendering/RenderGrid.h:
LayoutTests:
Extended the test case to include spanning grid items.
- fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
- fast/css-grid-layout/grid-preferred-logical-widths.html:
- 3:15 AM Changeset in webkit [160632] by
-
- 7 edits in trunk/Source/WebKit2
[GTK] can't build from trunk: WebKitCookieManager: 'WebString' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=125759
Reviewed by Carlos Garcia Campos.
Renamed WebString to API::String after r160608.
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkitCookieManagerGetDomainsWithCookiesCallback):
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkit_file_chooser_request_get_mime_types):
(webkit_file_chooser_request_get_mime_types_filter):
(webkit_file_chooser_request_get_selected_files):
- UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:
(webkit_form_submission_request_get_text_fields):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_web_extensions_directory):
(webkit_web_context_prefetch_dns):
- UIProcess/API/gtk/WebKitWebViewGroup.cpp:
(toAPIArray):
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
(webkitWebExtensionDidReceiveMessage):
Dec 15, 2013:
- 10:53 PM Changeset in webkit [160631] by
-
- 4 edits2 adds in trunk
Add support for maction@toggle
https://bugs.webkit.org/show_bug.cgi?id=120059
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-12-15
Reviewed by Chris Fleizach.
Source/WebCore:
Test: mathml/presentation/maction-toggle.html
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::getSelectedChildAndIndex):
(WebCore::MathMLSelectElement::updateSelectedChild):
(WebCore::MathMLSelectElement::defaultEventHandler):
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents):
(WebCore::MathMLSelectElement::toggle):
- mathml/MathMLSelectElement.h:
LayoutTests:
- mathml/presentation/maction-toggle-expected.html: Added.
- mathml/presentation/maction-toggle.html: Added.
- 10:39 PM Changeset in webkit [160630] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2 View Gestures: Can't pinch in past the maximum scale
https://bugs.webkit.org/show_bug.cgi?id=125749
Reviewed by Anders Carlsson.
Pinching in past the maximum scale should result in the zoom resisting, but continuing.
- UIProcess/mac/ViewGestureController.cpp:
(WebKit::resistanceForDelta):
Clean up the logic and apply resistance to pinching in past the maximum.
(WebKit::ViewGestureController::handleMagnificationGesture):
(WebKit::ViewGestureController::endMagnificationGesture):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
- 10:34 PM Changeset in webkit [160629] by
-
- 2 edits in trunk/Source/WebCore
More nullptr in RenderElement
https://bugs.webkit.org/show_bug.cgi?id=125764
Reviewed by Andreas Kling.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::uncachedFirstLineStyle):
(WebCore::RenderElement::updateShapeImage):
(WebCore::RenderElement::destroyLeftoverChildren):
(WebCore::RenderElement::findNextLayer):
Use nullptr in a few more places.
- 9:56 PM Changeset in webkit [160628] by
-
- 20 edits17 adds1 delete in trunk
REGRESSION: 2x regression on Dromaeo DOM query tests
https://bugs.webkit.org/show_bug.cgi?id=125377
Reviewed by Filip Pizlo.
PerformanceTests:
Added a micro-benchmark for updating a named property on document.
- Bindings/update-name-getter.html: Added.
- Skipped:
Source/JavaScriptCore:
The bug was caused by JSC not JIT'ing property access on "document" due to its type info having
HasImpureGetOwnPropertySlot flag.
Fixed the bug by new type info flag NewImpurePropertyFiresWatchpoints, which allows the baseline
JIT to generate byte code for access properties on an object with named properties (a.k.a.
custom name getter) in DOM. When a new named property appears on the object, VM is notified via
VM::addImpureProperty and fires StructureStubClearingWatchpoint added during the repatch.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt): Take the slow path if we have any object with impure
properties in the prototype chain.
(JSC::GetByIdStatus::computeForChain): Ditto.
- jit/Repatch.cpp:
(JSC::repatchByIdSelfAccess): Throw away the byte code when a new impure property is added on any
object in the prototype chain via StructureStubClearingWatchpoint.
(JSC::generateProtoChainAccessStub): Ditto.
(JSC::tryCacheGetByID):
(JSC::tryBuildGetByIDList):
(JSC::tryRepatchIn): Ditto.
- runtime/JSTypeInfo.h: Added NewImpurePropertyFiresWatchpoints.
(JSC::TypeInfo::newImpurePropertyFiresWatchpoints): Added.
- runtime/Operations.h:
(JSC::normalizePrototypeChainForChainAccess): Don't exit early if VM will be notified of new
impure property even if the object had impure properties.
- runtime/Structure.h:
(JSC::Structure::takesSlowPathInDFGForImpureProperty): Added. Wraps hasImpureGetOwnPropertySlot and
asserts that newImpurePropertyFiresWatchpoints is true whenever hasImpureGetOwnPropertySlot is true.
- runtime/VM.cpp:
(JSC::VM::registerWatchpointForImpureProperty): Added.
(JSC::VM::addImpureProperty): Added. HTMLDocument calls it to notify JSC of a new impure property.
- runtime/VM.h:
Source/WebCore:
The bug was caused by JSC not JIT'ing property accesses on document because of its having
custom named getter (named properties). This resulted in resolution of methods on document
such as getElementById to happen inside the interpreter.
Fixed the bug by using the new JSC type info flag which tells JSC to JIT property access on
document, and then notifying JSC whenever a new named property appeared on document.
Tests: js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html
js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html
js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html
js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html
- bindings/js/JSDOMBinding.cpp:
(WebCore::addImpureProperty): Wraps VM::addImpureProperty.
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Added the support for NewImpurePropertyFiresWatchpoints.
- bindings/scripts/IDLAttributes.txt: Ditto.
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::addDocumentNamedItem): Calls addImpureProperty.
- html/HTMLDocument.idl: Added NewImpurePropertyFiresWatchpoints.
LayoutTests:
Added more regression tests for throwing away byte code when a new named property appears.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-expected: Rebaselined.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.html: Fixed the test to use dfgShouldBe.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt: Added.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-2.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-3.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-expected.txt: Added.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html: Added.
- js/dom/script-tests/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps.js: Removed.
- 8:58 PM Changeset in webkit [160627] by
-
- 5 edits2 adds in trunk/Tools
Refactor option handling in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=123185
Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-15
Reviewed by Darin Adler.
Option handling is refactored (according to the FIXME) that allows
to automatically generate the help message.
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/GNUmakefile.am:
- WebKitTestRunner/Options.cpp: Added.
(WTR::Options::Options):
(WTR::handleOptionTimeout):
(WTR::handleOptionNoTimeout):
(WTR::handleOptionNoTimeoutAtAll):
(WTR::handleOptionVerbose):
(WTR::handleOptionGcBetweenTests):
(WTR::handleOptionPixelTests):
(WTR::handleOptionPrintSupportedFeatures):
(WTR::handleOptionComplexText):
(WTR::handleOptionAcceleratedDrawing):
(WTR::handleOptionRemoteLayerTree):
(WTR::handleOptionUnmatched):
(WTR::OptionsHandler::OptionsHandler):
(WTR::Option::Option):
(WTR::Option::matches):
(WTR::OptionsHandler::parse):
(WTR::OptionsHandler::printHelp):
- WebKitTestRunner/Options.h: Added.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 8:04 PM Changeset in webkit [160626] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Expose the certificate chain for the main frame
https://bugs.webkit.org/show_bug.cgi?id=125760
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKBrowsingContextController.h: Declared certificateChain property.
- UIProcess/API/Cocoa/WKBrowsingContextController.mm:
(-[WKBrowsingContextController certificateChain]): Added this getter, which calls through
to WebFrameProxy::certificateInfo.
- 7:28 PM Changeset in webkit [160625] by
-
- 2 edits in trunk/Source/WebCore
[WIn] Unreviewed build fix after r160599
- rendering/RenderMediaControls.cpp:
(WebCore::determineState): RenderObject::theme now returns
a reference.
- 6:28 PM Changeset in webkit [160624] by
-
- 3 edits2 deletes in trunk/Source
Source/WebCore: [Win] Unreviewed build fix
The build system continues to attempt to build QTMovieWin, even
though it is excluded from the build solution. I'm actually
removing the project files to prevent this.
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Removed.
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.filters: Removed.
Source/WebKit: [Win] Unreviewed build fix.
- WebKit.vcxproj/WebKit.sln: Remove reference to QTMovieWin,
which we do not wish to build.
- 2:34 PM Changeset in webkit [160623] by
-
- 5 edits in trunk
[CSS Shapes] shape-outside animation does not handle 'auto' well
https://bugs.webkit.org/show_bug.cgi?id=125700
Reviewed by Dirk Schulze.
Source/WebCore:
Handle the case where we are blending/animating with a null ShapeValue due to 'auto'.
Adapted LayoutTests/fast/shapes/shape-outside-floats/shape-outside-animation.html for testing this.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
LayoutTests:
Test a shape-outside animation where one keyframe uses 'auto'.
- fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt:
- fast/shapes/shape-outside-floats/shape-outside-animation.html:
- 1:13 PM Changeset in webkit [160622] by
-
- 57 edits in trunk/Source/WebKit/mac
[iOS] Upstream changes to WebKit Public and Private headers
https://bugs.webkit.org/show_bug.cgi?id=125745
Reviewed by Dan Bernstein.
- Configurations/WebKit.xcconfig: Ignore headers that are completely
excluded on iOS. This prevents empty headers from being installed into
the iOS SDK.
- DOM/WebDOMOperationsPrivate.h: Upstream iOS changes.
- History/WebBackForwardListPrivate.h: Ditto.
- History/WebHistoryItem.h: Ditto.
- History/WebHistoryItemPrivate.h: Ditto.
- Misc/WebCache.h: Ditto.
- Misc/WebIconDatabase.h: Ditto.
- Misc/WebIconDatabasePrivate.h: Ditto.
- Misc/WebKitNSStringExtras.h: Ditto.
- Misc/WebLocalizableStrings.h: Ditto.
- Misc/WebNSEventExtras.h: Ditto.
- Misc/WebNSFileManagerExtras.h: Ditto.
- Misc/WebNSPasteboardExtras.h: Ditto.
- Misc/WebNSURLExtras.h: Ditto.
- Misc/WebNSViewExtras.h: Ditto.
- Misc/WebNSWindowExtras.h: Ditto.
- Panels/WebPanelAuthenticationHandler.h: Ditto.
- Plugins/WebPlugin.h: Ditto.
- Plugins/WebPluginContainer.h: Ditto.
- Plugins/WebPluginContainerPrivate.h: Ditto.
- Plugins/WebPluginDatabase.h: Ditto.
- Plugins/WebPluginPrivate.h: Ditto.
- Plugins/WebPluginViewFactory.h: Ditto.
- Plugins/WebPluginsPrivate.h: Ditto.
- Storage/WebDatabaseManagerPrivate.h: Ditto.
- WebCoreSupport/WebApplicationCache.h: Ditto.
- WebCoreSupport/WebJavaScriptTextInputPanel.h: Ditto.
- WebCoreSupport/WebKeyGenerator.h: Ditto.
- WebCoreSupport/WebSecurityOriginPrivate.h: Ditto.
- WebView/WebDashboardRegion.h: Ditto.
- WebView/WebDataSource.h: Ditto.
- WebView/WebDataSourcePrivate.h: Ditto.
- WebView/WebDocument.h: Ditto.
- WebView/WebDocumentPrivate.h: Ditto.
- WebView/WebDynamicScrollBarsView.h: Ditto.
- WebView/WebEditingDelegate.h: Ditto.
- WebView/WebEditingDelegatePrivate.h: Ditto.
- WebView/WebFormDelegate.h: Ditto.
- WebView/WebFrameLoadDelegate.h: Ditto.
- WebView/WebFramePrivate.h: Ditto.
- WebView/WebFrameView.h: Ditto.
- WebView/WebFrameViewPrivate.h: Ditto.
- WebView/WebHTMLRepresentation.h: Ditto.
- WebView/WebHTMLView.h: Ditto.
- WebView/WebHTMLViewPrivate.h: Ditto.
- WebView/WebPolicyDelegate.h: Ditto.
- WebView/WebPreferenceKeysPrivate.h: Ditto.
- WebView/WebPreferences.h: Ditto.
- WebView/WebPreferencesPrivate.h: Ditto.
- WebView/WebRenderLayer.h: Ditto.
- WebView/WebResourceLoadDelegatePrivate.h: Ditto.
- WebView/WebResourcePrivate.h: Ditto.
- WebView/WebUIDelegate.h: Ditto.
- WebView/WebUIDelegatePrivate.h: Ditto.
- WebView/WebView.h: Ditto.
- WebView/WebViewPrivate.h: Ditto.
- 1:08 PM Changeset in webkit [160621] by
-
- 8 edits in trunk/Source
[iOS] Upstream changes to FeatureDefines.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=125742
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 10:27 AM Changeset in webkit [160620] by
-
- 3 edits in trunk/Tools
32-bit build fix.
- TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
- TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
- 10:16 AM Changeset in webkit [160619] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for 32-bit clients.
- UIProcess/API/Cocoa/WKBrowsingContextLoadDelegate.h:
- 8:40 AM Changeset in webkit [160618] by
-
- 4 edits2 adds in trunk
Crash in CSSImageGeneratorValue and RenderScrollbar
https://bugs.webkit.org/show_bug.cgi?id=125702
Reviewed by Alexey Proskuryakov.
Source/WebCore:
This crash had two causes at two different levels. The crash fixes both.
At the RenderScrollbar level, we were setting up a new renderer, a
RenderScrollbarPart, and never calling initializeStyle. This meant that
we did not do proper style setup, which meant we did not end up calling
CSSImageGeneratorValue::addClient and so had a removeClient that was not
properly balanced by an addClient. This is the primary bug.
At the CSSImageGeneratorValue level, the addClient and removeClient
functions were not properly handling possibly-mismatched calls. It was
easy to fix the functions to work even if the calls are not perfectly
matched up, which makes the consequences of a missed addClient call
much less dire, no longer messing up reference counting. Fixing this
mitigates the risk if we made this same mistake elsewhere, although I
could not find any other places with some quick searches.
Test: fast/css/scrollbar-image-crash.html
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::addClient): Only call ref if this will
add the first client.
(WebCore::CSSImageGeneratorValue::removeClient): Only call deref if this
removes the last client. Also added an assertion that can fire if we call
removeClient without first calling addClient, which is illegal. However,
the function handles that case without over-deref'ing itself.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart): Simplify the logic for
needRenderer a bit. Use initializeStyle rather than setStyle when first
creating the RenderScrollbarPart. Also use add and take properly so we
don't do extra hash lookups the old code did with get/set and get/remove.
LayoutTests:
- fast/css/scrollbar-image-crash-expected.txt: Added.
- fast/css/scrollbar-image-crash.html: Added.
- 4:48 AM Changeset in webkit [160617] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix after r160608.
- UIProcess/WebGrammarDetail.cpp:
(WebKit::WebGrammarDetail::WebGrammarDetail):
(WebKit::WebGrammarDetail::guesses):
- UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::guessesForWord):
