Timeline



Feb 10, 2014:

11:48 PM Changeset in webkit [163867] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163799 - [GTK] Create the inspector view using the same web process as the inspected page
https://bugs.webkit.org/show_bug.cgi?id=128539

Reviewed by Martin Robinson.

  • UIProcess/API/C/gtk/WKView.cpp:

(WKViewCreate): Pass nullptr as the related page.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Add related page argument and pass it
to webkitWebViewBaseCreateWebPage() instead of nullptr.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Pass
m_page as related page to webkitWebViewBaseCreate().

11:48 PM Changeset in webkit [163866] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r163856.
http://trac.webkit.org/changeset/163856
https://bugs.webkit.org/show_bug.cgi?id=128585

The build fix depends on r163848, which has been reverted
(Requested by notbenjamin on #webkit).

  • UIProcess/ios/TextCheckerIOS.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

11:42 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
11:35 PM Changeset in webkit [163865] by Carlos Garcia Campos
  • 65 edits
    4 deletes in releases/WebKitGTK/webkit-2.4

Merge r163797 - [GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=127554

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Use GUniqueOutPtr instead of GOwnPtr.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::handleMessage):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleMessage):

  • platform/glib/BatteryProviderUPower.cpp:

(BatteryProviderUPower::startUpdating):

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::getTag):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::loadResourceSharedBuffer):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::setURIList):

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::readFromFile):

  • platform/gtk/GamepadsGtk.cpp:

(WebCore::GamepadDeviceGtk::readCallback):

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::handlePreeditChanged):

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillDataObjectFromDropData):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::systemFont):

  • platform/gtk/SharedBufferGtk.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

  • platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::credentialForChallengeAsyncReadyCallback):

  • platform/network/soup/GOwnPtrSoup.cpp: Removed.
  • platform/network/soup/GOwnPtrSoup.h: Removed.
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::redirectSkipCallback):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::addFileToSoupMessageBody):
(WebCore::createSoupRequestAndMessageForHandle):
(WebCore::readCallback):

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::connectedCallback):
(WebCore::readReadyCallback):

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::httpProxy):

Source/WebKit/gtk:

Use GUniqueOutPtr instead of GOwnPtr.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoad):

  • WebCoreSupport/TextCheckerClientGtk.cpp:
  • webkit/webkitdownload.cpp:

(webkit_download_open_stream_for_uri):
(webkit_download_set_destination_uri):
(webkit_download_received_data):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_path):

  • webkit/webkitwebview.cpp:

(webkit_web_view_expose_event):

Source/WebKit2:

Use GUniqueOutPtr instead of GOwnPtr.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(gotFaviconCallback):

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

Source/WTF:

GUniqueOutPtr is a simplified version of GOwnPtr for the cases
where we need the address of the contained pointer. GUniqueOutPtr
uses GUniquePtr to free the contained object and to release the
container pointer. The API is very simple to make sure this is
only used when outPtr() is needed. It can't be constructed with a
pointer, and there's not method to set a new pointer. Another
difference with the old GOwnPtr is that outPtr() can be used
multiple times, because it frees any pointer previously set.

  • GNUmakefile.list.am:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformGTK.cmake:
  • wtf/gobject/GOwnPtr.cpp: Removed.
  • wtf/gobject/GOwnPtr.h: Removed.
  • wtf/gobject/GUniquePtr.h:

(WTF::GUniqueOutPtr::GUniqueOutPtr):
(WTF::GUniqueOutPtr::~GUniqueOutPtr):
(WTF::GUniqueOutPtr::outPtr):
(WTF::GUniqueOutPtr::reset):
(WTF::GUniqueOutPtr::release):
(WTF::GUniqueOutPtr::operator*):
(WTF::GUniqueOutPtr::operator->):
(WTF::GUniqueOutPtr::get):
(WTF::GUniqueOutPtr::operator!):
(WTF::GUniqueOutPtr::operator UnspecifiedBoolType):

Tools:

Use GUniqueOutPtr instead of GOwnPtr.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/EventSender.cpp:

(createKeyPressEvent):

  • TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:

(TestWebKitAPI::returnOutChar):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:

(testInspectorServerPageList):
(openRemoteDebuggingSession):
(sendIncompleteRequest):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(testWebExtensionWindowObjectCleared):
(testWebExtensionIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewRunJavaScript):
(testWebViewSave):
(testWebViewPageVisibility):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:

(isStyleSheetInjectedForURLAtPath):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
  • TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):

  • TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
  • TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:

(WebKitTestBus::run):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(resourceGetDataCallback):
(WebViewTest::keyStroke):
(onSnapshotReady):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

10:37 PM Changeset in webkit [163864] by beidson@apple.com
  • 4 edits in trunk

IndexedDB assertion at IDBTransactionBackend::~IDBTransactionBackend()
https://bugs.webkit.org/show_bug.cgi?id=128341

Reviewed by Maciej Stachowiak.

Source/WebCore:

  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::~IDBTransactionBackend): "Finished" is not the only

valid value here - In WK2, "Unused" is also valid. Update the ASSERT.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Reenable the indexeddb tests that are known to pass.
10:32 PM Changeset in webkit [163863] by ap@apple.com
  • 17 edits in trunk/Source

Add hooks for wrapping CryptoKeys in SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=128567

Reviewed by Anders Carlsson.

Source/WebCore:

  • bindings/js/SerializedScriptValue.cpp: Changed SerializedScriptValue to serialize

wrapped keys. Added a version number to crypto key serialization.

  • dom/Document.cpp:

(WebCore::Document::wrapCryptoKey):
(WebCore::Document::unwrapCryptoKey):

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::wrapCryptoKey):
(WebCore::ChromeClient::unwrapCryptoKey):
Hand wrapping/unwrapping over to client code.

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::wrapCryptoKey):
(WebCore::WorkerGlobalScope::unwrapCryptoKey):

  • workers/WorkerGlobalScope.h:

Not implemented in workers. SubtleCrypto is currently not exposed in workers. It used
to be possible in WebKit implementation to post a CryptoKey to a worker anyway,
but this doesn't work any more.

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::wrapCryptoKey):
(WebChromeClient::unwrapCryptoKey):
Dummy implementation, to be filled in later.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::wrapCryptoKey):
(WebKit::WebPageProxy::unwrapCryptoKey):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::wrapCryptoKey):
(WebKit::WebChromeClient::unwrapCryptoKey):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Dummy implementation, to be filled in later.

10:21 PM Changeset in webkit [163862] by mitz@apple.com
  • 7 edits
    2 moves
    2 adds in trunk/Source/WebKit2

Stop using PLATFORM(MAC) in WebKit2/platform except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128513

Reviewed by Dean Jackson.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::waitForSyncReply): Changed PLATFORM(MAC) to PLATFORM(COCOA) around use of
RunLoop::runForDuration, matching the guard around that function.

  • Platform/Logging.cpp: Deleted unused definition of logLevelString.
  • Platform/Module.cpp:

(WebKit::Module::Module): Changed PLATFORM(MAC) to USE(CF).

  • Platform/Module.h: Changed PLATFORM(MAC) to USE(CF), since the “Mac” implementation is

just a CFBundle-based implementation.

  • Platform/PlatformProcessIdentifier.h: Changed PLATFORM(MAC) to PLATFORM(COCOA). Arguably

this should be OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK).

  • Platform/cf: Added.
  • Platform/cf/ModuleCF.cpp: Renamed from Platform/mac/ModuleMac.mm. This file did not

contain any Objective-C code.

  • Platform/foundation: Added.
  • Platform/foundation/LoggingFoundation.mm: Renamed from Platform/mac/Logging.mac.mm.
  • Platform/mac/Logging.mac.mm: Removed.
  • Platform/mac/ModuleMac.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj: Updated for renames.
10:20 PM Changeset in webkit [163861] by ap@apple.com
  • 2 edits in trunk/LayoutTests

svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html and svg/css/font-face-crash.html
frequently assert in ComplexTextController::offsetForPosition
https://bugs.webkit.org/show_bug.cgi?id=119747

  • platform/mac/TestExpectations: Skipped the latter test in debug builds.
10:17 PM Changeset in webkit [163860] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Unreviewed, rolling out r163848.
http://trac.webkit.org/changeset/163848
https://bugs.webkit.org/show_bug.cgi?id=128580

Caused a lot of crashes on tests (Requested by ap on #webkit).

  • Shared/APIString.h:
  • UIProcess/TextChecker.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::checkSpellingOfString):
(WebKit::WebPageProxy::checkGrammarOfString):

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

9:43 PM Changeset in webkit [163859] by msaboff@apple.com
  • 5 edits in trunk/Source

Re-enable ARM Thumb2 disassembler
https://bugs.webkit.org/show_bug.cgi?id=128577

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Changed signature of tryToDisassemble() to match updates.
Fixed typo in disassembler.

  • disassembler/ARMv7/ARMv7DOpcode.cpp:
  • disassembler/ARMv7Disassembler.cpp:

(JSC::tryToDisassemble):

Source/WTF:

Added definition of WTF_USE_ARMV7_DISASSEMBLER back to Platform.h

  • wtf/Platform.h:
9:24 PM Changeset in webkit [163858] by ChangSeok Oh
  • 6 edits in trunk/Source/WebCore

Support ANGLE_instanced_arrays for linux
https://bugs.webkit.org/show_bug.cgi?id=127465

Reviewed by Martin Robinson.

Support the instanced drawing WebGL extension, ANGLE_instanced_arrays for linux platform.
This is a following patch for r162565. Relevant opengl APIs are exposed
for WebGLRenderingContext to access them.

Covered by fast/canvas/webgl/angle-instanced-arrays.html

  • html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::supported):

  • platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

  • platform/graphics/OpenGLShims.h:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension):

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::drawArraysInstanced):
(WebCore::GraphicsContext3D::drawElementsInstanced):
(WebCore::GraphicsContext3D::vertexAttribDivisor):

9:17 PM Changeset in webkit [163857] by beidson@apple.com
  • 4 edits in trunk

IDB: storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html fails
<rdar://problem/16033286> and https://bugs.webkit.org/show_bug.cgi?id=128574

Reviewed by Maciej Stachowiak.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::getRecordFromBackingStore): If there is no value in an object-store get,

don’t return *any* results.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Add the test (still skipped for now due to unrelated reasons).
9:09 PM Changeset in webkit [163856] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the iOS build after r163848

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-10

  • UIProcess/ios/TextCheckerIOS.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

8:48 PM Changeset in webkit [163855] by mark.lam@apple.com
  • 6 edits in trunk/Source

Source/JavaScriptCore: Removing limitation on JSLock's lockDropDepth.
<https://webkit.org/b/128570>

Reviewed by Geoffrey Garen.

Now that we've switched to using the C stack, we no longer need to limit
the JSLock::lockDropDepth to 2.

For C loop builds which still use the separate JSStack, the JSLock will
enforce ordering for re-grabbing the lock after dropping it. Re-grabbing
must occur in the reverse order of the dropping of the locks.

Ordering is achieved by JSLock::dropAllLocks() stashing away the
JSLock:: m_lockDropDepth in its DropAllLocks instance's m_dropDepth
before unlocking the lock. Subsequently, JSLock::grabAllLocks() will
ensure that JSLocks::m_lockDropDepth equals its DropAllLocks instance's
m_dropDepth before allowing the lock to be re-grabbed. Otherwise, it
will yield execution and retry again later.

Note: because JSLocks::m_lockDropDepth is protected by the JSLock's
mutex, grabAllLocks() will optimistically lock the JSLock before doing
the check on m_lockDropDepth. If the check fails, it will unlock the
JSLock, yield, and then relock it again later before retrying the check.
This ensures that m_lockDropDepth remains under the protection of the
JSLock's mutex.

  • runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/JSLock.h:

(JSC::JSLock::DropAllLocks::setDropDepth):
(JSC::JSLock::DropAllLocks::dropDepth):

Source/WebCore: Removing limitation on JSLock’s lockDropDepth.
<https://webkit.org/b/128570>

Reviewed by Geoffrey Garen.

No new tests.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):

  • platform/ios/wak/WebCoreThread.mm:

(SendDelegateMessage):
(WebThreadRunOnMainThread):

  • No longer need to specify AlwaysDropLocks, because DropAllLocks is now always unconditional.
6:47 PM Changeset in webkit [163854] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Clean up MarkupAccumulator::appendCharactersReplacingEntities
https://bugs.webkit.org/show_bug.cgi?id=128440

Reviewed by Ryosuke Niwa.

Some cleanup:
-Remove the copied code for the loops. Instead, use a template with the loop

parametrized by the characters type.

-Move EntityDescription from the header to the implementation.
-Make the 5 substitution strings compile-time literals. Replacement is not hot enough

to justify the static here.

  • editing/MarkupAccumulator.cpp:

(WebCore::appendCharactersReplacingEntitiesInternal):
(WebCore::MarkupAccumulator::appendCharactersReplacingEntities):

  • editing/MarkupAccumulator.h:
6:46 PM Changeset in webkit [163853] by benjamin@webkit.org
  • 11 edits
    1 add in trunk/Source/WebCore

Add a few pseudo type to the selector compiler through function calls
https://bugs.webkit.org/show_bug.cgi?id=128514

Reviewed by Dean Jackson.

Certain pseudo type checkers rely on virtual function calls. Since those types
are uncommon, and this code generator cannot currently make virtual function calls,
the checker are added by generating a function call to a wrapper function.

To avoid code duplication between SelectorChecker and the compiler, all the relevant checking
code has been moved to a common header, SelectorCheckerTestFunctions.h.
SelectorChecker still inline the functions, while the SelectorCompiler generate local static functions
and generate calls to them as needed.

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h: Added.

(WebCore::isAutofilled):
(WebCore::isDefaultButtonForForm):
(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):
(WebCore::isInvalid):
(WebCore::isOptionalFormControl):
(WebCore::isRequiredFormControl):
(WebCore::isValid):
(WebCore::matchesReadOnlyPseudoClass):
(WebCore::matchesReadWritePseudoClass):
(WebCore::shouldAppearIndeterminate):
(WebCore::matchesFullScreenPseudoClass):
(WebCore::matchesFutureCuePseudoClass):
(WebCore::matchesPastCuePseudoClass):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoType):
(WebCore::SelectorCompiler::nonConstTestFunctionWrapper):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementFunctionCallTest):

  • dom/Element.h:

(WebCore::Element::isValidFormControlElement):

  • dom/Node.h:

(WebCore::Node::toInputElement):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isValidFormControlElement):

  • html/HTMLFormControlElement.h:
6:45 PM Changeset in webkit [163852] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Make it possible to run tests with --llvmSimpleOpt=false
https://bugs.webkit.org/show_bug.cgi?id=128571

Reviewed by Mark Lam.

This also makes it so all run functions for the FTL are safe to call with FTL disabled,
because they do their own $enableFTL check.

  • Scripts/run-jsc-stress-tests:
6:41 PM Changeset in webkit [163851] by fpizlo@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

FTL should support ToThis
https://bugs.webkit.org/show_bug.cgi?id=127751

Reviewed by Oliver Hunt.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileToThis):

  • tests/stress/to-this-polymorphic.js: Added.

(foo):

6:41 PM Changeset in webkit [163850] by benjamin@webkit.org
  • 13 edits
    8 adds in trunk

Add the basic infrastructure to compile attributes matching in selectors
https://bugs.webkit.org/show_bug.cgi?id=128484

Reviewed by Gavin Barraclough.

Source/WebCore:

Tests: fast/selectors/querySelector-attribute-match-with-child-backtracking.html

fast/selectors/querySelector-long-attribute-match-with-child-backtracking.html
fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking.html
fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking.html

Add the infrastructure to match attributes. This only add basic support for the 'Set' match
type, the other match types will have to be built on top.

  • cssjit/RegisterAllocator.h:

(WebCore::RegisterAllocator::availableRegisterCount):
(WebCore::RegisterAllocator::allocateRegister):
(WebCore::RegisterAllocator::deallocateRegister):
(WebCore::RegisterAllocator::reserveCalleeSavedRegisters):
(WebCore::RegisterAllocator::restoreCalleeSavedRegisters):
(WebCore::RegisterAllocator::allocatedRegisters):
(WebCore::RegisterAllocator::RegisterAllocator):
(WebCore::RegisterAllocator::~RegisterAllocator):
In the worst case, matching attributes can take up to 10 registers. On x86_64, we have
8 caller-saved registers. The extra 2 registers are simply added by taking callee-saved registers.

RegisterAllocator is modified to know support saving and restoring callee saved registers.
The list of available registers is changed from a vector to a HashSet because the registers
are removed from arbitrary locations in restoreCalleeSavedRegisters(). The m_allocatedRegisters
remain a vector since the allocation/release pattern remain ordered.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):

(WebCore::SelectorCompiler::minimumRegisterRequirements):
This new utility finds the minimum number of registers needed to compile the input. In most
cases we have plenty enough. In rare cases we need to saved a few registers to the stack.

(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementDataMatching):
(WebCore::SelectorCompiler::testIsHTMLFlagOnNode):
(WebCore::SelectorCompiler::canMatchStyleAttribute):

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSynchronizeStyleAttribute):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSynchronizeAllAnimatedSVGAttribute):
The style attribute and certain SVG attributes can be modified lazily. In those cases,
the element needs to be updated before querying the attributes.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributesMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching):
Generate the attribute matching. For each CSSSelector matching an attribute, we generate
a loop over all the attributes of the element, maching the particular CSSSelector.
This makes no attempt at grouping related queries since those do not seem to happen a lot
in practice.

  • dom/Attribute.h:

(WebCore::Attribute::nameMemoryOffset):
(WebCore::Attribute::nameMatchesFilter):
(WebCore::Attribute::matches):

  • dom/ElementData.h:

(WebCore::ElementData::isUniqueFlag):
(WebCore::ElementData::arraySizeAndFlagsMemoryOffset):
(WebCore::ElementData::styleAttributeIsDirtyFlag):
(WebCore::ElementData::animatedSVGAttributesAreDirtyFlag):
(WebCore::ElementData::arraySizeOffset):
(WebCore::ShareableElementData::attributeArrayMemoryOffset):
(WebCore::UniqueElementData::attributeVectorMemoryOffset):

  • dom/Node.h:

(WebCore::Node::flagIsHTML):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::synchronizeStyleAttributeInternal):

  • dom/StyledElement.h:

(WebCore::StyledElement::synchronizeStyleAttributeInternal):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeAllAnimatedSVGAttribute):
(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):

  • svg/SVGElement.h:

Source/WTF:

  • wtf/Vector.h:

(WTF::VectorBufferBase::bufferMemoryOffset):
(WTF::Vector::sizeMemoryOffset):
(WTF::Vector::dataMemoryOffset):
Expose the memory offsets of Vector::size() and the memory buffer pointer for the JIT.

LayoutTests:

Tests the various cases requiring more register than what is available from the caller-saved pool.

  • fast/selectors/querySelector-attribute-match-with-child-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-attribute-match-with-child-backtracking.html: Added.
  • fast/selectors/querySelector-long-attribute-match-with-child-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-long-attribute-match-with-child-backtracking.html: Added.
  • fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-long-multiple-attribute-match-with-child-backtracking.html: Added.
  • fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-multiple-attribute-match-with-child-backtracking.html: Added.
6:29 PM Changeset in webkit [163849] by beidson@apple.com
  • 11 edits in trunk

IDB: storage/indexeddb/mozilla/indexes.html fails
<rdar://problem/16031590> and https://bugs.webkit.org/show_bug.cgi?id=128563

Reviewed by Tim Horton.

Source/WebCore:

Tested by storage/indexeddb/mozilla/indexes.html (and probably others)

  • Modules/indexeddb/IDBGetResult.h:

(WebCore::IDBGetResult::IDBGetResult): Add a constructor that takes an IDBKeyData argument.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): If there’s no keyPath then skip the injection step.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::getRecordFromBackingStore): Pass the cursor type to the backing store.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord): If it’s a key-only cursor,

return only the key result.

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::getIndexStatement): Fix index statement selection so ascending, unique cursors sort correctly.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Add the test (still skipped for now due to unrelated reasons).
6:12 PM Changeset in webkit [163848] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Remove a couple of deprecatedCharacters() from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128569

Reviewed by Andreas Kling.

  • Shared/APIString.h:
  • UIProcess/TextChecker.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::checkSpellingOfString):
(WebKit::WebPageProxy::checkGrammarOfString):

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):

6:11 PM Changeset in webkit [163847] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Speed up DatasetDOMStringMap::item() when the element has multiple attributes
https://bugs.webkit.org/show_bug.cgi?id=128058

Reviewed by Darin Adler.

Accessing data attributes by name through DatasetDOMStringMap involes the conversion
from JavaScript property name to attribute name (done with propertyNameMatchesAttributeName()).

When there is a single data attribute, that method is efficient. When there are several attributes,
comparing names character by character becomes a bottleneck.

This patch add an efficent path for this case: instead of converting the attribute name on the fly,
the JavaScript property name is converted to an attribute name so that it can compared by its
AtomicStringImpl pointer.

This method puts a lot more pressure on convertPropertyNameToAttributeName()'s speed. The method was
improved accordingly to compensate for its new caller.

When enumerating multiple attributes by name, this patch provides about 80% speedup.
I could not measure any slow down on the simple cases.

  • dom/DatasetDOMStringMap.cpp:

(WebCore::convertPropertyNameToAttributeName):
(WebCore::DatasetDOMStringMap::item):

  • dom/ElementData.h:

(WebCore::AttributeIteratorAccessor::attributeCount):

5:56 PM Changeset in webkit [163846] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Address the review comments for r163825.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition):
(WebCore::positionForIndex):

5:46 PM Changeset in webkit [163845] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Try to fix the 32-bit build.

  • WebCore.exp.in:
5:45 PM Changeset in webkit [163844] by fpizlo@apple.com
  • 388 edits
    1 copy
    1 add in trunk/Source

Rename Operations.h to JSCInlines.h
https://bugs.webkit.org/show_bug.cgi?id=128543

Source/JavaScriptCore:

Rubber stamped by Geoffrey Garen.

Well, what this actually does is it splits Operations.h into a real Operations.h that
actually contains "operations", and JSCInlines.h, which serves the role of being an
inlines umbrella.

  • API/JSBase.cpp:
  • API/JSCTestRunnerUtils.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • API/JSClassRef.cpp:
  • API/JSContext.mm:
  • API/JSContextRef.cpp:
  • API/JSManagedValue.mm:
  • API/JSObjectRef.cpp:
  • API/JSScriptRef.cpp:
  • API/JSValue.mm:
  • API/JSValueRef.cpp:
  • API/JSWeakObjectMapRefPrivate.cpp:
  • API/JSWrapperMap.mm:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/LinkBuffer.cpp:
  • bindings/ScriptFunctionCall.cpp:
  • bindings/ScriptObject.cpp:
  • bytecode/ArrayAllocationProfile.cpp:
  • bytecode/ArrayProfile.cpp:
  • bytecode/BytecodeBasicBlock.cpp:
  • bytecode/CallLinkInfo.cpp:
  • bytecode/CallLinkStatus.cpp:
  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlockJettisoningWatchpoint.cpp:
  • bytecode/CodeOrigin.cpp:
  • bytecode/ExecutionCounter.cpp:
  • bytecode/GetByIdStatus.cpp:
  • bytecode/LazyOperandValueProfile.cpp:
  • bytecode/MethodOfGettingAValueProfile.cpp:
  • bytecode/PreciseJumpTargets.cpp:
  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
  • bytecode/PutByIdStatus.cpp:
  • bytecode/SamplingTool.cpp:
  • bytecode/SpecialPointer.cpp:
  • bytecode/SpeculatedType.cpp:
  • bytecode/StructureStubClearingWatchpoint.cpp:
  • bytecode/UnlinkedCodeBlock.cpp:
  • bytecode/ValueRecovery.cpp:
  • bytecompiler/BytecodeGenerator.cpp:
  • bytecompiler/NodesCodegen.cpp:
  • debugger/Debugger.cpp:
  • debugger/DebuggerActivation.cpp:
  • debugger/DebuggerCallFrame.cpp:
  • dfg/DFGAbstractHeap.cpp:
  • dfg/DFGAbstractValue.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:
  • dfg/DFGArithMode.cpp:
  • dfg/DFGArrayMode.cpp:
  • dfg/DFGAtTailAbstractState.cpp:
  • dfg/DFGAvailability.cpp:
  • dfg/DFGBackwardsPropagationPhase.cpp:
  • dfg/DFGBasicBlock.cpp:
  • dfg/DFGBinarySwitch.cpp:
  • dfg/DFGBlockInsertionSet.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCFAPhase.cpp:
  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCPSRethreadingPhase.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGCapabilities.cpp:
  • dfg/DFGClobberSet.cpp:
  • dfg/DFGClobberize.cpp:
  • dfg/DFGCommon.cpp:
  • dfg/DFGCommonData.cpp:
  • dfg/DFGCompilationKey.cpp:
  • dfg/DFGCompilationMode.cpp:
  • dfg/DFGConstantFoldingPhase.cpp:
  • dfg/DFGCriticalEdgeBreakingPhase.cpp:
  • dfg/DFGDCEPhase.cpp:
  • dfg/DFGDesiredIdentifiers.cpp:
  • dfg/DFGDesiredStructureChains.cpp:
  • dfg/DFGDesiredTransitions.cpp:
  • dfg/DFGDesiredWatchpoints.cpp:
  • dfg/DFGDesiredWeakReferences.cpp:
  • dfg/DFGDesiredWriteBarriers.cpp:
  • dfg/DFGDisassembler.cpp:
  • dfg/DFGDominators.cpp:
  • dfg/DFGDriver.cpp:
  • dfg/DFGEdge.cpp:
  • dfg/DFGFailedFinalizer.cpp:
  • dfg/DFGFinalizer.cpp:
  • dfg/DFGFixupPhase.cpp:
  • dfg/DFGFlushFormat.cpp:
  • dfg/DFGFlushLivenessAnalysisPhase.cpp:
  • dfg/DFGFlushedAt.cpp:
  • dfg/DFGGraph.cpp:
  • dfg/DFGGraphSafepoint.cpp:
  • dfg/DFGInPlaceAbstractState.cpp:
  • dfg/DFGInvalidationPointInjectionPhase.cpp:
  • dfg/DFGJITCode.cpp:
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITFinalizer.cpp:
  • dfg/DFGJumpReplacement.cpp:
  • dfg/DFGLICMPhase.cpp:
  • dfg/DFGLazyJSValue.cpp:
  • dfg/DFGLivenessAnalysisPhase.cpp:
  • dfg/DFGLongLivedState.cpp:
  • dfg/DFGLoopPreHeaderCreationPhase.cpp:
  • dfg/DFGMinifiedNode.cpp:
  • dfg/DFGNaturalLoops.cpp:
  • dfg/DFGNode.cpp:
  • dfg/DFGNodeFlags.cpp:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
  • dfg/DFGOSREntry.cpp:
  • dfg/DFGOSREntrypointCreationPhase.cpp:
  • dfg/DFGOSRExit.cpp:
  • dfg/DFGOSRExitBase.cpp:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:
  • dfg/DFGOSRExitCompilerCommon.cpp:
  • dfg/DFGOSRExitJumpPlaceholder.cpp:
  • dfg/DFGOSRExitPreparation.cpp:
  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.cpp:
  • dfg/DFGPlan.cpp:
  • dfg/DFGPredictionInjectionPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGResurrectionForValidationPhase.cpp:
  • dfg/DFGSSAConversionPhase.cpp:
  • dfg/DFGSSALoweringPhase.cpp:
  • dfg/DFGSafepoint.cpp:
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • dfg/DFGStackLayoutPhase.cpp:
  • dfg/DFGStoreBarrierElisionPhase.cpp:
  • dfg/DFGStrengthReductionPhase.cpp:
  • dfg/DFGThreadData.cpp:
  • dfg/DFGThunks.cpp:
  • dfg/DFGTierUpCheckInjectionPhase.cpp:
  • dfg/DFGToFTLDeferredCompilationCallback.cpp:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
  • dfg/DFGTypeCheckHoistingPhase.cpp:
  • dfg/DFGUnificationPhase.cpp:
  • dfg/DFGUseKind.cpp:
  • dfg/DFGValidate.cpp:
  • dfg/DFGValueSource.cpp:
  • dfg/DFGVariableAccessDataDump.cpp:
  • dfg/DFGVariableEvent.cpp:
  • dfg/DFGVariableEventStream.cpp:
  • dfg/DFGVirtualRegisterAllocationPhase.cpp:
  • dfg/DFGWatchpointCollectionPhase.cpp:
  • dfg/DFGWorklist.cpp:
  • ftl/FTLAbstractHeap.cpp:
  • ftl/FTLAbstractHeapRepository.cpp:
  • ftl/FTLExitValue.cpp:
  • ftl/FTLLink.cpp:
  • ftl/FTLLowerDFGToLLVM.cpp:
  • ftl/FTLOSREntry.cpp:
  • ftl/FTLOSRExit.cpp:
  • ftl/FTLOSRExitCompiler.cpp:
  • ftl/FTLSlowPathCall.cpp:
  • heap/BlockAllocator.cpp:
  • heap/CodeBlockSet.cpp:
  • heap/ConservativeRoots.cpp:
  • heap/CopiedSpace.cpp:
  • heap/CopyVisitor.cpp:
  • heap/DeferGC.cpp:
  • heap/GCThread.cpp:
  • heap/GCThreadSharedData.cpp:
  • heap/HandleSet.cpp:
  • heap/HandleStack.cpp:
  • heap/Heap.cpp:
  • heap/HeapStatistics.cpp:
  • heap/HeapTimer.cpp:
  • heap/IncrementalSweeper.cpp:
  • heap/JITStubRoutineSet.cpp:
  • heap/MachineStackMarker.cpp:
  • heap/MarkStack.cpp:
  • heap/MarkedAllocator.cpp:
  • heap/MarkedBlock.cpp:
  • heap/MarkedSpace.cpp:
  • heap/SlotVisitor.cpp:
  • heap/SuperRegion.cpp:
  • heap/Weak.cpp:
  • heap/WeakBlock.cpp:
  • heap/WeakHandleOwner.cpp:
  • heap/WeakSet.cpp:
  • heap/WriteBarrierBuffer.cpp:
  • heap/WriteBarrierSupport.cpp:
  • inspector/InjectedScript.cpp:
  • inspector/InjectedScriptBase.cpp:
  • inspector/JSGlobalObjectScriptDebugServer.cpp:
  • inspector/JSInjectedScriptHost.cpp:
  • inspector/ScriptArguments.cpp:
  • inspector/ScriptCallStackFactory.cpp:
  • interpreter/AbstractPC.cpp:
  • interpreter/CallFrame.cpp:
  • interpreter/Interpreter.cpp:
  • interpreter/JSStack.cpp:
  • interpreter/ProtoCallFrame.cpp:
  • interpreter/StackVisitor.cpp:
  • interpreter/VMInspector.cpp:
  • jit/ArityCheckFailReturnThunks.cpp:
  • jit/AssemblyHelpers.cpp:
  • jit/ClosureCallStubRoutine.cpp:
  • jit/ExecutableAllocator.cpp:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/GCAwareJITStubRoutine.cpp:
  • jit/HostCallReturnValue.cpp:
  • jit/JIT.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCall.cpp:
  • jit/JITCall32_64.cpp:
  • jit/JITCode.cpp:
  • jit/JITDisassembler.cpp:
  • jit/JITExceptions.cpp:
  • jit/JITInlineCacheGenerator.cpp:
  • jit/JITInlines.h:
  • jit/JITOperations.cpp:
  • jit/JITOperationsMSVC64.cpp:
  • jit/JITStubRoutine.cpp:
  • jit/JITStubs.cpp:
  • jit/JITThunks.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp:
  • jit/RegisterPreservationWrapperGenerator.cpp:
  • jit/RegisterSet.cpp:
  • jit/Repatch.cpp:
  • jit/TempRegisterSet.cpp:
  • jit/ThunkGenerators.cpp:
  • jsc.cpp:
  • llint/LLIntExceptions.cpp:
  • llint/LLIntSlowPaths.cpp:
  • llint/LowLevelInterpreter.cpp:
  • parser/Lexer.cpp:
  • parser/Nodes.cpp:
  • parser/Parser.cpp:
  • parser/ParserArena.cpp:
  • parser/SourceCode.cpp:
  • parser/SourceProvider.cpp:
  • parser/SourceProviderCache.cpp:
  • profiler/LegacyProfiler.cpp:
  • profiler/ProfileGenerator.cpp:
  • profiler/ProfilerBytecode.cpp:
  • profiler/ProfilerBytecodeSequence.cpp:
  • profiler/ProfilerBytecodes.cpp:
  • profiler/ProfilerCompilation.cpp:
  • profiler/ProfilerCompiledBytecode.cpp:
  • profiler/ProfilerDatabase.cpp:
  • profiler/ProfilerOSRExit.cpp:
  • profiler/ProfilerOSRExitSite.cpp:
  • profiler/ProfilerOrigin.cpp:
  • profiler/ProfilerOriginStack.cpp:
  • profiler/ProfilerProfiledBytecodes.cpp:
  • runtime/ArgList.cpp:
  • runtime/Arguments.cpp:
  • runtime/ArgumentsIteratorPrototype.cpp:
  • runtime/ArrayBuffer.cpp:
  • runtime/ArrayBufferNeuteringWatchpoint.cpp:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanPrototype.cpp:
  • runtime/CallData.cpp:
  • runtime/CodeCache.cpp:
  • runtime/CommonSlowPaths.cpp:
  • runtime/CommonSlowPathsExceptions.cpp:
  • runtime/Completion.cpp:
  • runtime/ConstructData.cpp:
  • runtime/DateConstructor.cpp:
  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:
  • runtime/Error.cpp:
  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorPrototype.cpp:
  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/GetterSetter.cpp:
  • runtime/Identifier.cpp:
  • runtime/IntendedStructureChain.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSArgumentsIterator.cpp:
  • runtime/JSArray.cpp:
  • runtime/JSArrayBuffer.cpp:
  • runtime/JSArrayBufferConstructor.cpp:
  • runtime/JSArrayBufferPrototype.cpp:
  • runtime/JSArrayBufferView.cpp:
  • runtime/JSBoundFunction.cpp:
  • runtime/JSCInlines.h: Copied from Source/JavaScriptCore/runtime/Operations.h.
  • runtime/JSCell.cpp:
  • runtime/JSDataView.cpp:
  • runtime/JSDataViewPrototype.cpp:
  • runtime/JSDateMath.cpp:
  • runtime/JSFunction.cpp:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/JSLock.cpp:
  • runtime/JSNameScope.cpp:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSONObject.cpp:
  • runtime/JSObject.cpp:
  • runtime/JSPropertyNameIterator.cpp:
  • runtime/JSPropertyNameIterator.h:
  • runtime/JSProxy.cpp:
  • runtime/JSScope.cpp:
  • runtime/JSSegmentedVariableObject.cpp:
  • runtime/JSString.cpp:
  • runtime/JSStringJoiner.cpp:
  • runtime/JSSymbolTableObject.cpp:
  • runtime/JSTypedArrayConstructors.cpp:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrays.cpp:
  • runtime/JSVariableObject.cpp:
  • runtime/JSWithScope.cpp:
  • runtime/JSWrapperObject.cpp:
  • runtime/LiteralParser.cpp:
  • runtime/Lookup.cpp:
  • runtime/MathObject.cpp:
  • runtime/NameConstructor.cpp:
  • runtime/NameInstance.cpp:
  • runtime/NamePrototype.cpp:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeErrorPrototype.cpp:
  • runtime/NumberConstructor.cpp:
  • runtime/NumberObject.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/ObjectPrototype.cpp:
  • runtime/Operations.cpp:
  • runtime/Operations.h:
  • runtime/PropertyDescriptor.cpp:
  • runtime/PrototypeMap.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpCache.cpp:
  • runtime/RegExpCachedResult.cpp:
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpMatchesArray.cpp:
  • runtime/RegExpObject.cpp:
  • runtime/RegExpPrototype.cpp:
  • runtime/SimpleTypedArrayController.cpp:
  • runtime/SmallStrings.cpp:
  • runtime/SparseArrayValueMap.cpp:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StringConstructor.cpp:
  • runtime/StringObject.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/StringRecursionChecker.cpp:
  • runtime/Structure.cpp:
  • runtime/StructureChain.cpp:
  • runtime/StructureRareData.cpp:
  • runtime/SymbolTable.cpp:
  • runtime/TestRunnerUtils.cpp:
  • runtime/VM.cpp:
  • testRegExp.cpp:

Source/WebCore:

Rubber stamped by Geoffrey Garen.

No new tests because no change in behavior.

  • ForwardingHeaders/runtime/JSCInlines.h: Added.
  • bindings/js/JSCryptoAlgorithmBuilder.cpp:
  • bindings/js/JSCryptoKeySerializationJWK.cpp:
  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMGlobalObject.h:
  • bindings/js/JSDictionary.h:
  • bindings/js/JSMessagePortCustom.cpp:
  • bindings/js/JSMessagePortCustom.h:
  • bindings/js/JSNodeFilterCondition.h:
  • bindings/js/SerializedScriptValue.cpp:
  • bindings/js/WebCoreTypedArrayController.cpp:
  • bridge/c/c_utility.h:
  • bridge/jsc/BridgeJSC.h:
  • dom/CustomEvent.cpp:
  • dom/Node.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLImageLoader.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/WebConsoleAgent.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FilterEffect.cpp:
  • testing/MockCDM.cpp:
  • xml/XMLHttpRequest.cpp:

Source/WebKit2:

Rubber stamped by Geoffrey Garen.

  • Shared/linux/WebMemorySamplerLinux.cpp:
  • UIProcess/WebContext.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
5:41 PM Changeset in webkit [163843] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Removes the inline assert from SpeculativeJIT's ReallocatePropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=128566

Patch by Matthew Mirman <mmirman@apple.com> on 2014-02-10
Reviewed by Filip Pizlo.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

5:33 PM Changeset in webkit [163842] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Rename getRecordMap to computeRecordMap.

Rubber stamped by Michael Saboff.

"get" is such a weird prefix. It implies a getter. We don't prefix our getters with
anything in WebKit. Also, this isn't a getter. It actually does work to transform
the stackmaps into a hashmap. So, computeRecordMap is a much better name.

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::computeRecordMap):

  • ftl/FTLStackMaps.h:
5:31 PM Changeset in webkit [163841] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

ReallocatePropertyStorage in FTL
https://bugs.webkit.org/show_bug.cgi?id=128352

Patch by Matthew Mirman <mmirman@apple.com> on 2014-02-10
Reviewed by Filip Pizlo.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileReallocatePropertyStorage):

  • tests/stress/ftl-reallocatepropertystorage.js: Added.

(foo):

5:20 PM Changeset in webkit [163840] by dino@apple.com
  • 14 edits in trunk

Update aspect-ratio property to have constraining keywords
https://bugs.webkit.org/show_bug.cgi?id=128262

Reviewed by Simon Fraser.

Source/WebCore:

Add support for "from-dimensions" and "from-intrinsic"
property values to "-webkit-aspect-ratio". I also changed
the default value from "none" to "auto", because "none" doesn't
make sense any more.

Covered by enhancing existing tests.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): New keywords.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAspectRatio): Support new keywords.

  • css/CSSValueKeywords.in: Add from-dimensions and from-intrinsic.
  • css/DeprecatedStyleBuilder.cpp: This now has to handle the new

values. I also changed "none" to "auto".
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):

  • rendering/style/RenderStyle.h: hasAspectRatio is now aspectRatioType

and indicates one of the three keywords, or a specified number.

  • rendering/style/RenderStyleConstants.h: New enum.
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

Add tests for new from-intrinsic and from-dimensions
property values.

  • fast/css/aspect-ratio-inheritance-expected.txt:
  • fast/css/aspect-ratio-inheritance.html:
  • fast/css/aspect-ratio-parsing-tests-expected.txt:
  • fast/css/aspect-ratio-parsing-tests.html:
5:10 PM Changeset in webkit [163839] by benjamin@webkit.org
  • 7 edits in trunk/Source

[WK2] Add support for image document viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=128565

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-10
Reviewed by Simon Fraser.

Source/WebCore:

Add proper default settings for displaying images.

  • WebCore.exp.in:
  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::imageDocumentParameters):
(WebCore::ViewportConfiguration::textDocumentParameters):

  • page/ViewportConfiguration.h:

Source/WebKit2:

  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::screenToWindow):
(WebKit::PageClientImpl::windowToScreen):
Add the implementation for ImageDocument.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
Use the right default settings when dealing with image documents.

4:47 PM Changeset in webkit [163838] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fail FTL compilation if the required stack is too big
https://bugs.webkit.org/show_bug.cgi?id=128560

Reviewed by Filip Pizlo.

Added StackSize struct to FTLStackMaps and populated it. Added and updated
related dump functions. Use the stack size found at the end of the compilation
to compare against the value of a new option, llvmMaxStackSize. We fail the
compile if the function's stack size is greater than llvmMaxStackSize.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::StackSize::parse):
(JSC::FTL::StackMaps::StackSize::dump):
(JSC::FTL::StackMaps::parse):
(JSC::FTL::StackMaps::dump):
(JSC::FTL::StackMaps::dumpMultiline):
(JSC::FTL::StackMaps::getStackSize):

  • ftl/FTLStackMaps.h:
  • runtime/Options.h:
4:24 PM Changeset in webkit [163837] by Simon Fraser
  • 7 edits in trunk/Source/WebKit2

Show a debug tile map indicator for UI-side compositing
https://bugs.webkit.org/show_bug.cgi?id=128553

Reviewed by Tim Horton.

Implement a tiled scrolling indicator for UI-side compositing.

The indicator is created by making another RemoteLayerTreeHost,
and decoding the transaction in it a second time to create a cloned
layer tree. In that clone commit, we modify some layer properties to
make things easier to see.

The cloned layer tree is hosted in the root layer of the main
RemoteLayerTreeHost.

RemoteLayerTreeHost was changed to not need a pointer to the WebPageProxy,
which it only used in the "root layer changed" case; instead, it now just
returns a bool from updateLayerTree() in that situation.

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp: Explanatory comment.
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::setExposedRect):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicatorPosition):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorScale):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):
(WebKit::RemoteLayerTreeDrawingAreaProxy::showDebugIndicator):

  • UIProcess/mac/RemoteLayerTreeHost.h:

(WebKit::RemoteLayerTreeHost::rootLayer):
(WebKit::RemoteLayerTreeHost::setIsDebugLayerTreeHost):
(WebKit::RemoteLayerTreeHost::isDebugLayerTreeHost):

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::RemoteLayerTreeHost):
(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::createLayer):

4:24 PM Changeset in webkit [163836] by Simon Fraser
  • 4 edits in trunk/Source/WebKit2

Put a delegatesScrolling flag on WebPageProxy so that the UI process knows when scrolling is delegated
https://bugs.webkit.org/show_bug.cgi?id=128429

Reviewed by Sam Weinig.

Add delegatesScrolling() which defaults to false, but is set to true for iOS
by WKContentView.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setDelegatesScrolling):
(WebKit::WebPageProxy::delegatesScrolling):

4:20 PM Changeset in webkit [163835] by Lucas Forschler
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r162486.

4:19 PM Changeset in webkit [163834] by zoltan@webkit.org
  • 1 edit
    1 add in trunk/PerformanceTests

[CSS Shapes] Add initial performance tests for polygon shape
https://bugs.webkit.org/show_bug.cgi?id=128554

Reviewed by Ryosuke Niwa.

This patch adds performance testing for simple polygon shape-outside.
The Shapes performance tests directory is skipped by default.

  • Layout/Shapes/ShapeOutsideSimplePolygon.html: Added.
4:17 PM Changeset in webkit [163833] by Lucas Forschler
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r158870.

4:08 PM Changeset in webkit [163832] by Lucas Forschler
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r154036.

4:03 PM Changeset in webkit [163831] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-537.75-branch

Merged r156082.

3:59 PM Changeset in webkit [163830] by Lucas Forschler
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Merged r153507.

3:55 PM Changeset in webkit [163829] by mark.lam@apple.com
  • 4 edits in trunk/LayoutTests

REGRESSION(r163660-r163664): js/dom/stack-trace.html fails.
<https://webkit.org/b/128544>

Reviewed by Alexey Proskuryakov.

The failing test is fragile. The test intends to test a recursion pattern
i.e. the top of the stack trace should show a repeated cycle of certain
function calls. However, the test makes a faulty assumption about which
function in that recursion pattern will be the one that overflows the
stack.

The fix is to make the test check for repetition of that recursion pattern
instead of making a specific assumption as to which function within that
recursion pattern will overflow the stack.

(stackTraceLineFor):

  • refactored this code to generated the stack trace line out of printStack.

(printStack):

  • updated to use stackTraceLineFor.

(dumpPattern):

  • utility function to dump the recursion pattern being matched.

(matchesPatternAtLine):
(matchPattern):
(checkStackForPattern):

  • utility functions for testing if the stack trace matches the expected recursion pattern. The pattern is an array of stack trace lines that we should see repeated in the stack trace starting from the top.

The top line of the stack trace may match any line in the pattern.
Thereafter, subsequent lines much patch lines in the pattern starting
with the line after the first match. When we run out of pattern lines,
we'll go back to the first pattern line and continue the matching test
until we run out of stack trace lines to match.

If any mismatch is found, the test fails.

  • js/dom/stack-trace-expected.txt:
  • updates baseline for expected results.
3:48 PM Changeset in webkit [163828] by b.long@cablelabs.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r163816.

  • GNUmakefile.list.am: Remove HTMLMediaSource.h and HTMLMediaSource.cpp
3:40 PM Changeset in webkit [163827] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-537.75-branch

Merged r158676.

3:34 PM Changeset in webkit [163826] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL WebKit2 build fix after r163816.

  • CMakeLists.txt: Remove HTMLMediaSource.cpp
3:05 PM Changeset in webkit [163825] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLTextFormControlElement::setSelectionRange shouldn't use VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=128478

Reviewed by Darin Adler.

Added positionForIndex to compute Position given a selection index. This function doesn't
synchronously trigger like visiblePositionForIndex.

Also added assertions in visiblePositionForIndex and visiblePositionForIndex to make sure
they are inverse of one another.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange): Use positionForIndex. Also removed
the now tautological assertions since we would never create a position outside the inner text
element.

(WebCore::HTMLTextFormControlElement::indexForVisiblePosition): Fixed the bug where this
function could return a selection index beyond innerTextElement in some types of input
elements such as search fields. fast/forms/search-disabled-readonly.html hits the newly
added assertion without this change. Note we can't use visiblePositionForIndex here as that
would result in a mutual recursion with the assertion in visiblePositionForIndex.

(WebCore::HTMLTextFormControlElement::visiblePositionForIndex): Added an assertion.

(WebCore::positionForIndex): Added. It's here with prototype at the beginning of the file
so that it's right next to HTMLTextFormControlElement::innerText() where we do a similar
DOM traversal to obtain the inner text value.

2:58 PM Changeset in webkit [163824] by ap@apple.com
  • 2 edits in trunk/LayoutTests

svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html frequently asserts
in ComplexTextController::offsetForPosition
https://bugs.webkit.org/show_bug.cgi?id=119747

  • platform/mac/TestExpectations: Skipped it in debug builds.
2:55 PM Changeset in webkit [163823] by jpfau@apple.com
  • 4 edits
    5 adds in trunk

Disable access to application cache when in private browsing
https://bugs.webkit.org/show_bug.cgi?id=128426

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: http/tests/security/appcache-in-private-browsing.html

http/tests/security/appcache-switching-private-browsing.html

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::cacheForMainRequest):
(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
(WebCore::ApplicationCacheGroup::update):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

LayoutTests:

  • http/tests/security/appcache-in-private-browsing-expected.txt: Added.
  • http/tests/security/appcache-in-private-browsing.html: Added.
  • http/tests/security/appcache-switching-private-browsing-expected.txt: Added.
  • http/tests/security/appcache-switching-private-browsing.html: Added.
  • http/tests/security/resources/frame-for-appcache-in-private-browsing.html: Added.
2:46 PM Changeset in webkit [163822] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Move animation tests that have similar failing behavior in debug builds together,
and mark them as passing in release.

  • platform/mac/TestExpectations:
2:30 PM Changeset in webkit [163821] by barraclough@apple.com
  • 17 edits in trunk

Remove WKPageSetVisibilityState
https://bugs.webkit.org/show_bug.cgi?id=128551

Reviewed by Anders Carlsson.

Source/WebKit2:

Made prerender state automatic. We should move this further
up into WebCore, but this requires refactoring for the Page
construction order.

  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPageSetVisibilityState):

  • deprecated.
  • UIProcess/API/C/WKPage.cpp:
    • removed WKPageSetVisibilityState.
  • UIProcess/API/C/WKPage.h:
    • removed WKPageSetVisibilityState.
  • UIProcess/WebPageProxy.cpp:
    • removed setVisibilityStatePrerender.
  • UIProcess/WebPageProxy.h:
    • removed setVisibilityStatePrerender.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • removed setVisibilityStatePrerender.
  • When creating a Page, automatically set the prerender state.
  • WebProcess/WebPage/WebPage.h:
    • removed setVisibilityStatePrerender.
  • WebProcess/WebPage/WebPage.messages.in:
    • removed SetVisibilityStatePrerender.

Tools:

  • TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:

(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):

  • visibilityState of offs-creen WKView is automatically prerender.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::setHidden):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setPageVisibility):
(WTR::TestRunner::resetPageVisibility):

  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

  • removed calls to WKPageSetVisibilityState.
2:27 PM Changeset in webkit [163820] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Change JSLock::dropAllLocks() and friends to use lock() and unlock().
<https://webkit.org/b/128451>

Reviewed by Geoffrey Garen.

Currently, JSLock's dropAllLocks(), dropAllLocksUnconditionally(), and
grabAllLocks() implement locking / unlocking by duplicating the code from
lock() and unlock(). Instead, they should just call lock() and unlock().

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::unlock):

  • Modified lock() and unlock() into a version that takes an entry count to lock / unlock. The previous lock() and unlock() now calls these new versions with an entry count of 1.

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):

  • Delegate to unlock() and lock() instead of duplicating the lock / unlock code.
  • There a some differences with calling lock() instead of duplicating its code in grabAllLock() i.e. lock() does the following additional work:
  1. lock() does a re-entry check that is not needed by grabAllLocks(). However, this is effectively a no-op since we never own the JSLock before calling grabAllLocks().
  1. set VM stackPointerAtVMEntry.
  2. update VM stackLimit and reservedZoneSize.
  3. set VM lastStackTop. These 3 steps are just busy work which are also effective no-ops because immediately after lock() returns, grabAllLocks() will write over those values with their saved versions in the threadData.
  • runtime/JSLock.h:
2:24 PM Changeset in webkit [163819] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Flaky Test: animations/play-state-suspend.html
https://bugs.webkit.org/show_bug.cgi?id=50959

  • platform/mac/TestExpectations: Marked it as such.
2:19 PM Changeset in webkit [163818] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

IDB: storage/indexeddb/mozilla/object-store-remove-values.html fails
<rdar://problem/16029319> and https://bugs.webkit.org/show_bug.cgi?id=128487

Missed one piece of review feedback before landing.

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):

2:15 PM Changeset in webkit [163817] by beidson@apple.com
  • 10 edits in trunk

IDB: storage/indexeddb/mozilla/object-store-remove-values.html fails
<rdar://problem/16029319> and https://bugs.webkit.org/show_bug.cgi?id=128487

Reviewed by Tim Horton.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Update logging.
(WebKit::DatabaseProcessIDBConnection::deleteDatabase): If deleteDatabase succeeds,

also disconnect from the UniqueIDBDatabase so it can be cleaned up properly.

(WebKit::DatabaseProcessIDBConnection::close): New message from the WebProcess to handle

clean closures.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::shutdown): Move most of the cleanup to didShutdownBackingStore.
(WebKit::UniqueIDBDatabase::didShutdownBackingStore): Execute all remaining mainThreadTasks

(as they represent real results from the backing store thread).

(WebKit::UniqueIDBDatabase::deleteDatabase): Add an ASSERT.
(WebKit::UniqueIDBDatabase::performNextMainThreadTask): Call through to performNextMainThreadTaskWithoutAdoptRef.
(WebKit::UniqueIDBDatabase::performNextMainThreadTaskWithoutAdoptRef): Execute a task,

returning true if there are more tasks left to execute.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite): Properly

handle JSC cleanup.

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::close): Implement this.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Add the now-passing test (skipped because of unrelated flakiness in IDB tests)
2:08 PM Changeset in webkit [163816] by jer.noble@apple.com
  • 23 edits
    1 add
    2 deletes in trunk/Source/WebCore

[MSE] Fix layering violations in MediaSource
https://bugs.webkit.org/show_bug.cgi?id=128546

Reviewed by Eric Carlson.

Code in Modules should be considered part of html/ and should have the
same layering properties. Get rid of HTMLMediaSource (which was intended
to allow Modules/mediasource to be considered part of platform/) and add
a new client interface allowing communication from platform/ ->
Modules/mediasource.

Replace HTMLMediaSource -> MediaSourcePrivateClient:

  • html/HTMLMediaSource.cpp: Removed.
  • html/HTMLMediaSource.h: Removed.
  • platform/graphics/MediaSourcePrivateClient.h: Added.

(WebCore::MediaSourcePrivateClient::~MediaSourcePrivateClient):

Move registry support from HTMLMediaSource -> MediaSource.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setRegistry): Moved from HTMLMediaSource.cpp.

  • Modules/mediasource/MediaSource.h:

(WebCore::MediaSource::lookup): Ditto.

Update references to HTMLMediaSource -> MediaSource:

  • Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::MediaSourceRegistry):

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

  • html/HTMLMediaElement.h:

Update references to HTMLMediaSource -> MediaSourcePrivateClient:

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::load):
(WebCore::MediaPlayer::load): Ditto.
(WebCore::MediaPlayer::loadWithNextMediaEngine):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/MediaSourceGStreamer.cpp:

(WebCore::MediaSourceGStreamer::open):

  • platform/graphics/gstreamer/MediaSourceGStreamer.h:
  • platform/graphics/ios/MediaPlayerPrivateIOS.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::load):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::load):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
2:04 PM Changeset in webkit [163815] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

  • heap/UnconditionalFinalizer.h:
  • runtime/SymbolTable.h:
1:57 PM Changeset in webkit [163814] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebKit2

[iOS][WK2] Add empty definition for an API allowing clients to define obscured edges over the scrollview
https://bugs.webkit.org/show_bug.cgi?id=128396

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-10
Reviewed by Simon Fraser.

ObscuredInset defines the area of the scrollview unusable for positioning content.
The API is unused in this patch.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _obscuredInset]):
(-[WKWebView _setObscuredInset:]):
(-[WKWebView _commitObscuredInset]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _obscuredInset]):
(-[WKView _setObscuredInset:]):
(-[WKView _commitObscuredInset]):

1:45 PM Changeset in webkit [163813] by Bem Jones-Bey
  • 2 edits in trunk/Websites/webkit.org

Change tools.html to say Xcode 5 is required to build
https://bugs.webkit.org/show_bug.cgi?id=128545

Reviewed by Andreas Kling.

The Mac port doesn't build with Xcode 4.6 anymore, so update to tell
people to get Xcode 5. It looks like Xcode 5 doesn't have the command
line tools in the downloads pane anymore, so direct folks to use
xcode-select to install the command line tools as well.

  • building/tools.html:
1:43 PM Changeset in webkit [163812] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update License copyrights in minified JavaScript
https://bugs.webkit.org/show_bug.cgi?id=128547

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-10
Reviewed by Timothy Hatcher.

  • Scripts/copy-user-interface-resources.sh:
1:37 PM Changeset in webkit [163811] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Web Inspector: add test for hitting breakpoints from functions called via console
https://bugs.webkit.org/show_bug.cgi?id=126845

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-10
Reviewed by Timothy Hatcher.

  • inspector-protocol/debugger/hit-breakpoint-from-console-expected.txt: Added.
  • inspector-protocol/debugger/hit-breakpoint-from-console.html: Added.
1:37 PM Changeset in webkit [163810] by ap@apple.com
  • 5 edits in trunk/Source/WebCore

Remove some unused functions from SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Oliver Hunt.

Removed functions that used Deprecated::ScriptValue

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValue):
(WebCore::deserializeIDBValueBuffer):

  • bindings/js/SerializedScriptValue.cpp:
  • bindings/js/SerializedScriptValue.h:
1:11 PM Changeset in webkit [163809] by enrica@apple.com
  • 2 edits in trunk/Source/WTF

copyShortASCIIString crashes on iOS after r163793.
https://bugs.webkit.org/show_bug.cgi?id=128548.

Reviewed by Alexey Proskuryakov.

Adding null check.

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::copyShortASCIIString):

12:39 PM Changeset in webkit [163808] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Make the Identifier::add() family return PassRef<StringImpl>.
<https://webkit.org/b/128542>

This knocks one branch off of creating an Identifier from another
string source.

Reviewed by Oliver Hunt.

  • runtime/Identifier.cpp:

(JSC::Identifier::add):
(JSC::Identifier::add8):
(JSC::Identifier::addSlowCase):

  • runtime/Identifier.h:

(JSC::Identifier::add):

  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):

12:18 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
12:07 PM Changeset in webkit [163807] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed test fix.

  • platform/graphics/cg/GraphicsContextCG.cpp: m_pixelSnappingFactor was not set to 1.

(WebCore::GraphicsContext::platformInit):

11:59 AM Changeset in webkit [163806] by mhahnenberg@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Handling of opaque roots is wrong in EdenCollections
https://bugs.webkit.org/show_bug.cgi?id=128210

Reviewed by Geoffrey Garen.

Forgot to svn add the regression tests for this bug.

  • js/generational-opaque-roots-expected.txt: Added.
  • js/script-tests/generational-opaque-roots.js: Added.
11:43 AM Changeset in webkit [163805] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Skip indexeddb tests for now until somebody can explore 128341.
https://bugs.webkit.org/show_bug.cgi?id=128341

  • platform/mac-wk2/TestExpectations:
11:39 AM Changeset in webkit [163804] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unnecessary spinLock in JSLock.
<https://webkit.org/b/128450>

Reviewed by Filip Pizlo.

The JSLock's mutex already provides protection for write access to
JSLock's internal state. The only JSLock state that needs to be read
from any thread including threads that don't own the JSLock is
m_ownerThread, which is used in currentThreadIsHoldingLock() to do an
ownership test on the lock.

It is safe for other threads to read from m_ownerThread because they
only need to know whether its value matches their own thread id
(provided by WTF::currentThread()).

Here are the scenarios for how the ownership test can go:

  1. The JSLock has just been initialized and is not owned by any thread.

In this case, m_ownerThread will be 0 and will not match any thread's
thread id. The checking thread will know that it needs to lock the
JSLock before using the VM.

  1. The JSLock was previously locked, but now is unlocked.

When we unlock it in JSLock::unlock(), the owner thread clears
m_ownerThread to 0. Hence, this case is the same as (1) above.

  1. The JSLock is locked by Thread A. Thread B is checking ownership.

In this case, m_ownerThread will contains the Thread A's thread id.
Thread B will see that the thread id does not match its own and will
proceed to block on the JSLock's mutex to wait for its turn to use
the VM.

With Weak Memory Ordering architectures, Thread A's thread id may
not get written out to memory before Thread B inspects m_ownerThread.
However, though Thread B may not see Thread A's thread id in
m_ownerThread, it will see 0 which is the last value written to it
before the JSLock mutex was unlocked. The mutex unlock would have
executed a memory fence which would have flushed the 0 to
m_ownerThread in memory. Hence, Thread B will know that it does not
own the lock.

Apart from removing the unneeded spin lock code, I also changed the
JSLock code to use currentThreadIsHoldingLock() and setOwnerThread()
instead of accessing m_ownerThread directly.

  • runtime/JSLock.cpp:

(JSC::JSLock::JSLock):

(JSC::JSLock::lock):

  • Removed spinLock but left the indentation as is to keep the diff to a minimum for better readability. Will unindent in a subsequent patch.

(JSC::JSLock::unlock):

  • Before unlocking the mutex, clear m_ownerThread to indicate that the lock is no longer owned.

(JSC::JSLock::currentThreadIsHoldingLock):

  • Removed the check of m_lockCount for determining ownership. Checking m_ownerThread is sufficient.

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):

  • Renamed local locksToDrop to the better name droppedLockCount.
  • Clear m_ownerThread since we're unlocking the JSLock.

(JSC::JSLock::grabAllLocks):

  • Removed unneeded lock ownership test for lock re-entry case because grabAllLocks() is never used to re-enter a locked JSLock.

(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/JSLock.h:

(JSC::JSLock::setOwnerThread):

11:32 AM Changeset in webkit [163803] by fpizlo@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Unbreak ChangeLog after r163802

11:27 AM HackingWebInspector edited by Brian Burg
Update to use new paths, webkit-patch, etc (diff)
11:26 AM Changeset in webkit [163802] by fpizlo@apple.com
  • 91 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out http://trac.webkit.org/changeset/163796

The change was not justified in any way and it has a net negative effect on the code.

  • dfg/DFGAbstractInterpreter.h:
  • dfg/DFGAbstractValue.h:
  • dfg/DFGAdjacencyList.h:
  • dfg/DFGArgumentPosition.h:
  • dfg/DFGArgumentsSimplificationPhase.cpp:
  • dfg/DFGArrayMode.cpp:
  • dfg/DFGArrayifySlowPathGenerator.h:
  • dfg/DFGAtTailAbstractState.h:
  • dfg/DFGAvailability.h:
  • dfg/DFGBackwardsPropagationPhase.cpp:
  • dfg/DFGBasicBlock.h:
  • dfg/DFGBasicBlockInlines.h:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCFAPhase.cpp:
  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCPSRethreadingPhase.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
  • dfg/DFGCapabilities.cpp:
  • dfg/DFGCapabilities.h:
  • dfg/DFGClobberize.h:
  • dfg/DFGCommonData.cpp:
  • dfg/DFGConstantFoldingPhase.cpp:
  • dfg/DFGCriticalEdgeBreakingPhase.cpp:
  • dfg/DFGDCEPhase.cpp:
  • dfg/DFGDominators.h:
  • dfg/DFGDriver.cpp:
  • dfg/DFGDriver.h:
  • dfg/DFGFixupPhase.cpp:
  • dfg/DFGFlushLivenessAnalysisPhase.cpp:
  • dfg/DFGGenerationInfo.h:
  • dfg/DFGGraph.cpp:
  • dfg/DFGGraph.h:
  • dfg/DFGInPlaceAbstractState.cpp:
  • dfg/DFGInPlaceAbstractState.h:
  • dfg/DFGInlineCacheWrapperInlines.h:
  • dfg/DFGInvalidationPointInjectionPhase.cpp:
  • dfg/DFGJITCode.h:
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGJITFinalizer.cpp:
  • dfg/DFGJITFinalizer.h:
  • dfg/DFGLICMPhase.cpp:
  • dfg/DFGLivenessAnalysisPhase.cpp:
  • dfg/DFGLoopPreHeaderCreationPhase.cpp:
  • dfg/DFGMinifiedNode.h:
  • dfg/DFGNaturalLoops.h:
  • dfg/DFGNode.cpp:
  • dfg/DFGNode.h:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
  • dfg/DFGOSREntry.cpp:
  • dfg/DFGOSREntrypointCreationPhase.cpp:
  • dfg/DFGOSRExit.cpp:
  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitBase.cpp:
  • dfg/DFGOSRExitCompilationInfo.h:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:
  • dfg/DFGOSRExitJumpPlaceholder.cpp:
  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:
  • dfg/DFGPlan.h:
  • dfg/DFGPredictionInjectionPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGResurrectionForValidationPhase.cpp:
  • dfg/DFGSSAConversionPhase.cpp:
  • dfg/DFGSSALoweringPhase.cpp:
  • dfg/DFGSaneStringGetByValSlowPathGenerator.h:
  • dfg/DFGSlowPathGenerator.h:
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • dfg/DFGStackLayoutPhase.cpp:
  • dfg/DFGStoreBarrierElisionPhase.cpp:
  • dfg/DFGStrengthReductionPhase.cpp:
  • dfg/DFGThunks.cpp:
  • dfg/DFGTierUpCheckInjectionPhase.cpp:
  • dfg/DFGTypeCheckHoistingPhase.cpp:
  • dfg/DFGUnificationPhase.cpp:
  • dfg/DFGValidate.h:
  • dfg/DFGValueSource.h:
  • dfg/DFGVariableAccessData.h:
  • dfg/DFGVariableAccessDataDump.cpp:
  • dfg/DFGVariableEvent.h:
  • dfg/DFGVariableEventStream.h:
  • dfg/DFGVirtualRegisterAllocationPhase.cpp:
  • dfg/DFGWatchpointCollectionPhase.cpp:
  • dfg/DFGWorklist.cpp:
11:25 AM Changeset in webkit [163801] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for crashing tests.

  • platform/efl-wk2/TestExpectations:
11:03 AM WikiStart edited by Brian Burg
fix Web Inspector link names (diff)
10:59 AM Changeset in webkit [163800] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Add API for accessing session ephemerality from a page bundle
https://bugs.webkit.org/show_bug.cgi?id=128410

Patch by Martin Hock <mhock@apple.com> on 2014-02-10
Reviewed by Alexey Proskuryakov.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageIsUsingEphemeralSession):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::isUsingEphemeralSession):

  • WebProcess/WebPage/WebPage.h:
10:54 AM Changeset in webkit [163799] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Create the inspector view using the same web process as the inspected page
https://bugs.webkit.org/show_bug.cgi?id=128539

Reviewed by Martin Robinson.

  • UIProcess/API/C/gtk/WKView.cpp:

(WKViewCreate): Pass nullptr as the related page.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Add related page argument and pass it
to webkitWebViewBaseCreateWebPage() instead of nullptr.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage): Pass
m_page as related page to webkitWebViewBaseCreate().

10:51 AM Changeset in webkit [163798] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r163660-r163664): js/dom/stack-trace.html fails
https://bugs.webkit.org/show_bug.cgi?id=128544

10:22 AM Changeset in webkit [163797] by Carlos Garcia Campos
  • 65 edits
    4 deletes in trunk

[GLIB] Add GUniqueOutPtr and use it instead of GOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=127554

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Use GUniqueOutPtr instead of GOwnPtr.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::handleMessage):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::handleMessage):

  • platform/glib/BatteryProviderUPower.cpp:

(BatteryProviderUPower::startUpdating):

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::getTag):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::loadResourceSharedBuffer):

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::setURIList):

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::readFromFile):

  • platform/gtk/GamepadsGtk.cpp:

(WebCore::GamepadDeviceGtk::readCallback):

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::handlePreeditChanged):

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillDataObjectFromDropData):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::systemFont):

  • platform/gtk/SharedBufferGtk.cpp:

(WebCore::SharedBuffer::createWithContentsOfFile):

  • platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::credentialForChallengeAsyncReadyCallback):

  • platform/network/soup/GOwnPtrSoup.cpp: Removed.
  • platform/network/soup/GOwnPtrSoup.h: Removed.
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::redirectSkipCallback):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::addFileToSoupMessageBody):
(WebCore::createSoupRequestAndMessageForHandle):
(WebCore::readCallback):

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::connectedCallback):
(WebCore::readReadyCallback):

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::httpProxy):

Source/WebKit/gtk:

Use GUniqueOutPtr instead of GOwnPtr.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidFailLoad):

  • WebCoreSupport/TextCheckerClientGtk.cpp:
  • webkit/webkitdownload.cpp:

(webkit_download_open_stream_for_uri):
(webkit_download_set_destination_uri):
(webkit_download_received_data):

  • webkit/webkitwebplugin.cpp:

(webkit_web_plugin_get_path):

  • webkit/webkitwebview.cpp:

(webkit_web_view_expose_event):

Source/WebKit2:

Use GUniqueOutPtr instead of GOwnPtr.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(processPendingIconsForPageURL):
(webkit_favicon_database_get_favicon):

  • UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback):

  • UIProcess/API/gtk/WebKitWebView.cpp:

(gotFaviconCallback):

  • UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::getCacheDiskFreeSize):

Source/WTF:

GUniqueOutPtr is a simplified version of GOwnPtr for the cases
where we need the address of the contained pointer. GUniqueOutPtr
uses GUniquePtr to free the contained object and to release the
container pointer. The API is very simple to make sure this is
only used when outPtr() is needed. It can't be constructed with a
pointer, and there's not method to set a new pointer. Another
difference with the old GOwnPtr is that outPtr() can be used
multiple times, because it frees any pointer previously set.

  • GNUmakefile.list.am:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformGTK.cmake:
  • wtf/gobject/GOwnPtr.cpp: Removed.
  • wtf/gobject/GOwnPtr.h: Removed.
  • wtf/gobject/GUniquePtr.h:

(WTF::GUniqueOutPtr::GUniqueOutPtr):
(WTF::GUniqueOutPtr::~GUniqueOutPtr):
(WTF::GUniqueOutPtr::outPtr):
(WTF::GUniqueOutPtr::reset):
(WTF::GUniqueOutPtr::release):
(WTF::GUniqueOutPtr::operator*):
(WTF::GUniqueOutPtr::operator->):
(WTF::GUniqueOutPtr::get):
(WTF::GUniqueOutPtr::operator!):
(WTF::GUniqueOutPtr::operator UnspecifiedBoolType):

Tools:

Use GUniqueOutPtr instead of GOwnPtr.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/EventSender.cpp:

(createKeyPressEvent):

  • TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:

(TestWebKitAPI::returnOutChar):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:

(testInspectorServerPageList):
(openRemoteDebuggingSession):
(sendIncompleteRequest):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(testWebExtensionWindowObjectCleared):
(testWebExtensionIsolatedWorld):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewRunJavaScript):
(testWebViewSave):
(testWebViewPageVisibility):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:

(isStyleSheetInjectedForURLAtPath):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
  • TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
  • TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):

  • TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:

(TestWebKitAPI::doKeyStroke):

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
  • TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:

(WebKitTestBus::run):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(resourceGetDataCallback):
(WebViewTest::keyStroke):
(onSnapshotReady):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown):

10:20 AM Changeset in webkit [163796] by commit-queue@webkit.org
  • 91 edits in trunk/Source/JavaScriptCore

Remove extra includes from DFG
https://bugs.webkit.org/show_bug.cgi?id=126983

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-02-10
Reviewed by Andreas Kling.

  • dfg/DFGAbstractInterpreter.h:
  • dfg/DFGAbstractValue.h:
  • dfg/DFGAdjacencyList.h:
  • dfg/DFGArgumentPosition.h:
  • dfg/DFGArgumentsSimplificationPhase.cpp:
  • dfg/DFGArrayMode.cpp:
  • dfg/DFGArrayifySlowPathGenerator.h:
  • dfg/DFGAtTailAbstractState.h:
  • dfg/DFGAvailability.h:
  • dfg/DFGBackwardsPropagationPhase.cpp:
  • dfg/DFGBasicBlock.h:
  • dfg/DFGBasicBlockInlines.h:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCFAPhase.cpp:
  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCPSRethreadingPhase.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
  • dfg/DFGCapabilities.cpp:
  • dfg/DFGCapabilities.h:
  • dfg/DFGClobberize.h:
  • dfg/DFGCommonData.cpp:
  • dfg/DFGConstantFoldingPhase.cpp:
  • dfg/DFGCriticalEdgeBreakingPhase.cpp:
  • dfg/DFGDCEPhase.cpp:
  • dfg/DFGDominators.h:
  • dfg/DFGDriver.cpp:
  • dfg/DFGDriver.h:
  • dfg/DFGFixupPhase.cpp:
  • dfg/DFGFlushLivenessAnalysisPhase.cpp:
  • dfg/DFGGenerationInfo.h:
  • dfg/DFGGraph.cpp:
  • dfg/DFGGraph.h:
  • dfg/DFGInPlaceAbstractState.cpp:
  • dfg/DFGInPlaceAbstractState.h:
  • dfg/DFGInlineCacheWrapperInlines.h:
  • dfg/DFGInvalidationPointInjectionPhase.cpp:
  • dfg/DFGJITCode.h:
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGJITFinalizer.cpp:
  • dfg/DFGJITFinalizer.h:
  • dfg/DFGLICMPhase.cpp:
  • dfg/DFGLivenessAnalysisPhase.cpp:
  • dfg/DFGLoopPreHeaderCreationPhase.cpp:
  • dfg/DFGMinifiedNode.h:
  • dfg/DFGNaturalLoops.h:
  • dfg/DFGNode.cpp:
  • dfg/DFGNode.h:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
  • dfg/DFGOSREntry.cpp:
  • dfg/DFGOSREntrypointCreationPhase.cpp:
  • dfg/DFGOSRExit.cpp:
  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitBase.cpp:
  • dfg/DFGOSRExitCompilationInfo.h:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:
  • dfg/DFGOSRExitJumpPlaceholder.cpp:
  • dfg/DFGOperations.cpp:
  • dfg/DFGPhase.h:
  • dfg/DFGPlan.h:
  • dfg/DFGPredictionInjectionPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGResurrectionForValidationPhase.cpp:
  • dfg/DFGSSAConversionPhase.cpp:
  • dfg/DFGSSALoweringPhase.cpp:
  • dfg/DFGSaneStringGetByValSlowPathGenerator.h:
  • dfg/DFGSlowPathGenerator.h:
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • dfg/DFGStackLayoutPhase.cpp:
  • dfg/DFGStoreBarrierElisionPhase.cpp:
  • dfg/DFGStrengthReductionPhase.cpp:
  • dfg/DFGThunks.cpp:
  • dfg/DFGTierUpCheckInjectionPhase.cpp:
  • dfg/DFGTypeCheckHoistingPhase.cpp:
  • dfg/DFGUnificationPhase.cpp:
  • dfg/DFGValidate.h:
  • dfg/DFGValueSource.h:
  • dfg/DFGVariableAccessData.h:
  • dfg/DFGVariableAccessDataDump.cpp:
  • dfg/DFGVariableEvent.h:
  • dfg/DFGVariableEventStream.h:
  • dfg/DFGVirtualRegisterAllocationPhase.cpp:
  • dfg/DFGWatchpointCollectionPhase.cpp:
  • dfg/DFGWorklist.cpp:
10:09 AM Changeset in webkit [163795] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

[iOS][wk2] WebKit2 View Gestures (Swipe): Forward swipe gesture
https://bugs.webkit.org/show_bug.cgi?id=128523
<rdar://problem/16020378>

Reviewed by Darin Adler.

We can't install the gesture recognizer on a view that's going to be
reparented during the swipe, because the gesture will be cancelled.
Install the recognizer on the WKView and move the WKView's scrollview
child around instead.

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
We'll install the gesture recognizer on the WKView, but swipe the scrollview.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController initWithViewGestureController:gestureRecognizerView:]):
Clarify that WKSwipeTransitionController gets handed only the view to install the gesture recognizer on.
(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
Use public enum values so we can get rid of one private header.

(WebKit::ViewGestureController::installSwipeHandler):
Separate out the gesture recognizer view from the one that gets swiped.

(WebKit::ViewGestureController::beginSwipeGesture):
Record a snapshot before beginning the swipe. This is important for the back-then-forward
swipe case, and matches the behavior of the Mac implementation.

(WebKit::ViewGestureController::endSwipeGesture):

  • UIProcess/mac/ViewGestureController.h:

Slight geometry adjustments due to the change in targetted view.

10:02 AM Changeset in webkit [163794] by fpizlo@apple.com
  • 5 edits in trunk/Source

JSC environment variables should override other mechanisms for setting options
https://bugs.webkit.org/show_bug.cgi?id=128511

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • runtime/Options.cpp:

(JSC::Options::setOption):

  • runtime/Options.h:

Source/WebKit2:

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

9:58 AM Changeset in webkit [163793] by Darin Adler
  • 29 edits in trunk/Source/WebCore

Automatically generate isRendererOfType in RENDER_OBJECT_TYPE_CASTS
https://bugs.webkit.org/show_bug.cgi?id=128520

Reviewed by Andreas Kling.

  • rendering/RenderObject.h: Updated the RENDER_OBJECT_TYPE_CASTS macro so

that it generates isRendererOfType specializations as well as type casts
and also have the type casts use the isRendererOfType function. The macro
also now uses an argument name of "renderer" and allows for a predicate
that is more than just a single function call (see RenderTextFragment.h).

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderCounter.h:
  • rendering/RenderElement.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderLayerModelObject.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRubyRun.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLToken.h:
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGText.h:

Removed specialization of isRendererOfType, since the RENDER_OBJECT_TYPE_CASTS
macro handles that now. Also removed some unneeded semicolons.

  • rendering/RenderTextFragment.h: Use RENDER_OBJECT_TYPE_CASTS instead of

hand written casts, now that it can handle a non-trivial predicate.

  • rendering/RenderCombineText.h:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderVideo.h:
  • rendering/RenderView.h:
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLScripts.h:
  • rendering/mathml/RenderMathMLSpace.h:

Removed unneeded semicolons.

9:46 AM Changeset in webkit [163792] by Darin Adler
  • 8 edits in trunk/Source

Stop using String::deprecatedCharacters to call WTF::Collator
https://bugs.webkit.org/show_bug.cgi?id=128517

Source/JavaScriptCore:

Reviewed by Alexey Proskuryakov.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncLocaleCompare): Use the default constructor for Collator, which now
gives the default locale collation rules. Use the new arguments for Collator::collate, which
are now StringView. These two changes together eliminate the need for a separate helper function.

Source/WebCore:

Reviewed by Alexey Proskuryakov.

  • xml/XSLTUnicodeSort.cpp:

(WebCore::xsltUnicodeSortFunction): Create the collator in a single line using the
new constructor that takes a shouldSortLowercaseFirst boolean. Use the new
collateUTF8 function instead of upconverting UTF-8 strings to UTF-16 as the old code did.

Source/WTF:

WTF passes ICU’s deprecated ULOC_REQUESTED_LOCALE to ucol_getLocaleByType()
rdar://problem/15183390

Reviewed by Alexey Proskuryakov.

This patch fixes both bugs above by reworking WTF::Collator.

  • wtf/unicode/Collator.h: Fixed formatting. Got rid of the Collator::Result type,

since the collator uses the same return value scheme as strcmp and as ICU; an int
will do for the return type. Simplified the support for UCONFIG_NO_COLLATION by
using a separate copy of the class definition. (We should check if anyone needs
UCONFIG_NO_COLLATION support, and remove it if not.) Changed the lower-first flag
from a separate function to a constructor argument. Changed the arguments to
the collate function to StringView. Added a collate UTF8 function. Changed the
m_collate data member to no longer be mutable since we no longer allocate it lazily.

  • wtf/unicode/CollatorDefault.cpp:

(WTF::Collator::collate): Rewrote to be simpler.
(WTF::Collator::collateUTF8): Added. Converts from UTF-8 to a String and then calls
the collate function above.

  • wtf/unicode/icu/CollatorICU.cpp: Added a FIXME about the fact that this file

has the wrong name and location. Since we always use ICU, there's no need to mention
it in the file name.
(WTF::copyASCIIString): Added.
(WTF::copyDefaultLocale): Added.
(WTF::resolveDefaultLocale): Added. Maps null locale to a default on Mac and iOS,
since on those platforms ICU does not use the correct default locale when passed null.
(WTF::localesMatch): Added.
(WTF::Collator::Collator): Moved most of the code from createCollator here.
Simplified it by storing the collator configuration along with the collator in globals.
(WTF::Collator::~Collator): Moved most of the code from releaseCollator here.
(WTF::getIndexLatin1): Added.
(WTF::moveLatin1): Added.
(WTF::hasNextLatin1): Added.
(WTF::hasPreviousLatin1): Added.
(WTF::currentLatin1): Added.
(WTF::nextLatin1): Added.
(WTF::previousLatin1): Added.
(WTF::getStateLatin1): Added.
(WTF::setStateLatin1): Added.
(WTF::createLatin1Iterator): Added. Uses the functions above to make a UCharIterator
that works for a WTF::StringView-style Latin-1 string.
(WTF::createIterator): Added. Uses either createLatin1Iterator or uiter_setString to
make a UCharIterator that works for a WTF::StringView.
(WTF::Collator::collate): Changed to use ucol_strcollIter.
(WTF::createIteratorUTF8): Added. Uses uiter_setUTF8.
(WTF::Collator::collateUTF8): Added. Like collate, but for null-terminated UTF-8 strings.

9:37 AM Changeset in webkit [163791] by fpizlo@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/workers/dedicated-worker-lifecycle
https://bugs.webkit.org/show_bug.cgi?id=128537

9:06 AM Changeset in webkit [163790] by fpizlo@apple.com
  • 2 edits in trunk/PerformanceTests/SunSpider

Unreviewed, revert the accidental change from r163789.

  • tests/v8-v6/v8-deltablue.js:
9:04 AM Changeset in webkit [163789] by fpizlo@apple.com
  • 7 edits
    2 adds in trunk

<1/100 probability FTL failure: v8-v6/v8-deltablue.js.ftl-eager: Exception: TypeError: undefined is not an object (evaluating 'c.isInput')
https://bugs.webkit.org/show_bug.cgi?id=128278

Reviewed by Mark Hahnenberg.

Fix another FTL flake due to bytecode liveness corner cases. Hopefully it's the last
one.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Make sure that inside a constructor, the 'this' result is always set. This makes it easier to unify the treatment of 'this' for OSR exit: we just say that it's always live.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode): Assume that 'this' is live. We were already sort of doing this for calls because the callsite would claim it to be live. But we didn't do it for constructors. It's true that *at the callsite* 'this' won't be live, but inside the inlined constructor, it almost certainly will be.

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run): I just noticed this benign bug. We should only return 'true' if we actually injected checks.

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub): Make it easier to just dump disassembly for FTL OSR exits.

  • runtime/Options.h: Ditto.
  • tests/stress/inlined-constructor-this-liveness.js: Added.

(Foo):
(foo):

  • tests/stress/inlined-function-this-liveness.js: Added.

(bar):
(foo):

8:53 AM Changeset in webkit [163788] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary comment lines.
https://bugs.webkit.org/show_bug.cgi?id=127894

Patch by Changhun Kang <temoochin@company100.net> on 2014-02-10
Reviewed by Darin Adler.

No new tests. No change in behavior.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeRequest):

8:50 AM Changeset in webkit [163787] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Actually register those DFG::Safepoints
https://bugs.webkit.org/show_bug.cgi?id=128521

Reviewed by Mark Hahnenberg.

No test because GC + thread + JIT = ???.

  • dfg/DFGSafepoint.cpp:

(JSC::DFG::Safepoint::~Safepoint):
(JSC::DFG::Safepoint::begin):

8:02 AM Changeset in webkit [163786] by commit-queue@webkit.org
  • 3 edits in trunk

Add the CSS_SHAPE_INSIDE to CMake feature list
https://bugs.webkit.org/show_bug.cgi?id=128530

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2014-02-10
Reviewed by Gyuyoung Kim.

CSS_SHAPE_INSIDE flag was added in r163333,
this patch is adding this flag to CMake feature list.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:
7:41 AM Changeset in webkit [163785] by mihnea@adobe.com
  • 1 edit
    4 adds in trunk/LayoutTests

[CSSRegions] Add tests for scrolling composited content
https://bugs.webkit.org/show_bug.cgi?id=128527

Reviewed by Andrei Bucur.

Add tests take simulate scrolling in the context of regions and composited content:

  1. scroll an empty region that is composited
  2. scroll a region that displays composited content
  • compositing/regions/composited-content-fixed-region-scrolled-expected.txt: Added.
  • compositing/regions/composited-content-fixed-region-scrolled.html: Added.
  • compositing/regions/fixed-empty-region-scrolled-expected.txt: Added.
  • compositing/regions/fixed-empty-region-scrolled.html: Added.
7:00 AM Changeset in webkit [163784] by Carlos Garcia Campos
  • 11 edits in releases/WebKitGTK/webkit-2.4

Merge r163781 - [GTK] Add API to create a webview related to another one
https://bugs.webkit.org/show_bug.cgi?id=128498

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add webkit_web_view_new_with_related_view() to create a new
WebView sharing the same web process as the given one.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView): Use the given related
WebView to pass a related WebPageProxy to webkitWebViewBaseCreateWebPage().

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Pass the related web view to webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty):
(webkit_web_view_class_init): Add related-view construct-only property.
(webkit_web_view_new_with_related_view): New public method to
create a web view with a related one.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Pass nullptr as related page to webkitWebViewBaseCreateWebPage().
(webkitWebViewBaseCreateWebPage): Use the given related
WebPageProxy to initialize the web page configuration.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewCreate): Use webkit_web_view_new_with_related_view() when
creating a new web view for window.open().

  • TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(testMultiprocessWebViewCreateReadyClose): Add test case to check
that window.open() works when creating the new WebView related to
the existing one, and that no new web process is spawned when
using webkit_web_view_new_with_related_view().
(beforeAll):

6:55 AM Changeset in webkit [163783] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163671 - Simplify web page creation
https://bugs.webkit.org/show_bug.cgi?id=128425

Reviewed by Andreas Kling.

Add a WebPageConfiguration class and stick the page group, preferences, session etc there
instead of adding more and more parameters to the WebPageProxy constructor.

Make WebContext::createWebPage fill in the missing pieces in the WebPageConfiguration object.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
6:22 AM Changeset in webkit [163782] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.4

Merge r163698 - [GTK] Make process model names properly meaningful
https://bugs.webkit.org/show_bug.cgi?id=128389

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-02-08
Reviewed by Carlos Garcia Campos.

The name WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
is misleading because there are situations in which web views may
share the same web process even when multi-process mode is enabled;
for example when opening a related view and both interact using JS.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_process_model):
(webkit_web_context_get_process_model):
Update names of WebKitProcessModel enum values.

  • UIProcess/API/gtk/WebKitWebContext.h:

Ditto.

Tools:

  • MiniBrowser/gtk/main.c:

(main):
Update usage of WebKitProcessModel enum values.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(beforeAll):
Ditto.

6:19 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
6:18 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
5:46 AM Changeset in webkit [163781] by Carlos Garcia Campos
  • 11 edits in trunk

[GTK] Add API to create a webview related to another one
https://bugs.webkit.org/show_bug.cgi?id=128498

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add webkit_web_view_new_with_related_view() to create a new
WebView sharing the same web process as the given one.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextCreatePageForWebView): Use the given related
WebView to pass a related WebPageProxy to webkitWebViewBaseCreateWebPage().

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Pass the related web view to webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty):
(webkit_web_view_class_init): Add related-view construct-only property.
(webkit_web_view_new_with_related_view): New public method to
create a web view with a related one.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Pass nullptr as related page to webkitWebViewBaseCreateWebPage().
(webkitWebViewBaseCreateWebPage): Use the given related
WebPageProxy to initialize the web page configuration.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.

Tools:

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewCreate): Use webkit_web_view_new_with_related_view() when
creating a new web view for window.open().

  • TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(testMultiprocessWebViewCreateReadyClose): Add test case to check
that window.open() works when creating the new WebView related to
the existing one, and that no new web process is spawned when
using webkit_web_view_new_with_related_view().
(beforeAll):

5:16 AM Changeset in webkit [163780] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

If not running on Mac, build-webkit should not print Safari related output
https://bugs.webkit.org/show_bug.cgi?id=127169

Patch by Eva Balazsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2014-02-10
Reviewed by Darin Adler.

  • Scripts/build-webkit:

(writeCongrats):

  • Scripts/webkitdirs.pm:

(isAppleWebKit):
(isAppleMacWebKit):
(isAppleWinWebKit):
(launcherName):

5:04 AM Changeset in webkit [163779] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL] Spelling unit tests should use ecore_main_loop_iterate()
https://bugs.webkit.org/show_bug.cgi?id=127427

Patch by Lukasz Bialek <l.bialek@samsung.com> on 2014-02-10
Reviewed by Gyuyoung Kim.

r148670 gets rid of EFL's idlers in a favor of timers to load languages.
ecore_main_loop_iterate() can be used now.

Add function that loads spellchecking languages and waits for loading
to be finished:

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::waitForLanguageLoading):

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

Apply added function to tests that should wait for languages to be loaded:

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(EWK2TextCheckerTest::resetCallbacksExecutionStats):
(TEST_F):

5:02 AM Changeset in webkit [163778] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser: During text search, make navigation through list of matched words circular
https://bugs.webkit.org/show_bug.cgi?id=128463

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-10
Reviewed by Carlos Garcia Campos.

Initialize search options to WEBKIT_FIND_OPTIONS_WRAP_AROUND to make navigation
circular.

  • MiniBrowser/gtk/BrowserSearchBar.c:

(doSearch):

3:41 AM Changeset in webkit [163777] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Fix EFL build with INSPECTOR disabled
https://bugs.webkit.org/show_bug.cgi?id=125064

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-02-10
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

  • inspector/InjectedScriptManager.h:
  • inspector/ScriptDebugServer.cpp:
  • inspector/agents/InspectorAgent.h:
  • inspector/scripts/CodeGeneratorInspectorStrings.py:

(Inspector):

Source/WebCore:

  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/PageScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp:
  • bindings/js/WorkerScriptDebugServer.h:
  • inspector/PageInjectedScriptManager.h:
3:25 AM Changeset in webkit [163776] by commit-queue@webkit.org
  • 4 edits in trunk

Code cleanup: Remove BUILDING_ON / TARGETING definitions.
https://bugs.webkit.org/show_bug.cgi?id=128242

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-10
Reviewed by Brent Fulgham.

The BUILDING_ON_* and TARGETING_* macros have not been used for a while.
According to the FIXME: they are removed.

Source/WTF:

  • wtf/Platform.h:

Tools:

  • DumpRenderTree/config.h:
1:31 AM Changeset in webkit [163775] by Carlos Garcia Campos
  • 28 edits
    3 copies in releases/WebKitGTK/webkit-2.4

Merge r163749 - [GTK] Enable touch features
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsGTK.cmake: set ENABLE_TOUCH_EVENTS to 1 if building with GTK+.

Source/WebCore: [GTK] Add touch-events related code to build
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Tests in fast/events/touch have been enabled on GTK+ now that touch
support is implemented, and thus all expected bits are there.

  • platform/gtk/GtkTouchContextHelper.cpp:
  • platform/gtk/GtkTouchContextHelper.h: Add helper object to track all touchpoints, handy

when creating WebTouchEvents.

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • bindings/gobject/GNUmakefile.am: Add touch related code and idls to build, those are

necessary now that GTK+ implements touch events.

Source/WebKit/gtk: [GTK] Allow building with touch events enabled
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Even though WebKit1 GTK code doesn't implement touch events,
Fix build if ENABLE_TOUCH_EVENTS is present for WK2.

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::needTouchEvents): Add empty stub

Source/WebKit2: [GTK] Implement support touch events
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

In GTK+ >= 3.4.0, GdkEventTouch is available to inform about multitouch events. Use these to implement
touch events on this platform. If a touch is left unhandled and is the "pointer emulating" one, mouse
events will be generated as a fallback.

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • Shared/gtk/NativeWebTouchEventGtk.cpp:
  • Shared/NativeWebTouchEvent.h:

(WebKit::NativeWebTouchEvent::nativeEvent):
(WebKit::NativeWebTouchEvent::touchContext): Add GTK+ implementation of NativeWebTouchEvent.

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::touchPhaseFromEvents):
(WebKit::WebEventFactory::createWebTouchEvent): Add methods to generate WebTouchEvents out
of GdkEventTouch events, a GtkTouchContextHelper object is used to hold information about all current
touches, in order to build information about all individual touchpoints.

  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Implement pointer emulation. If a touch event was unhandled
in DOM and pertains to the touch sequence that emulates pointer events. The event gets transformed to its
mouse event counterpart and handled by the widget again.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize): Listen for touch events
(webkitWebViewBaseTouchEvent):
(webkit_web_view_base_class_init): Add implementation for the touch_events() handler, this merely
lets the pageProxy handle the NativeWebTouchEvent we create to wrap the GdkEvent received.

Tools: [GTK] Enable touch features
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::updateEventCoordinates):
(WTR::EventSenderProxy::createTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::sendUpdatedTouchEvents):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::setTouchModifier): Implement touch event proxying.

LayoutTests: [GTK] Enable touch features
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

  • platform/gtk/TestExpectations: remove fast/events/touch
  • platform/gtk-wk2/TestExpectations: Add new expectations on

fast/events/touch events.

1:08 AM Changeset in webkit [163774] by zandobersek@gmail.com
  • 4 edits in trunk

Fix a few mistakes that landed with r163749.

Rubber-stamped by Carlos Garcia Campos.

Source/WebCore:

  • platform/gtk/GtkTouchContextHelper.cpp:

(WebCore::GtkTouchContextHelper::handleEvent): When handling GDK_TOUCH_BEGIN, the assertion
should ensure that the sequence-to-event map doesn't yet contain pairs with the specific
sequence as the key.

Tools:

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::addTouchPoint): Avoid using the GUniquePtr<GdkEvent> after it's been moved
into the event vector since moving it invalidates the variable.

12:32 AM Changeset in webkit [163773] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Tools

Merge r163375 - [Automake] Add missing $(feature_defines) when generating InjectedBundle bindings
https://bugs.webkit.org/show_bug.cgi?id=128170

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-04
Reviewed by Carlos Garcia Campos.

  • WebKitTestRunner/GNUmakefile.am: Add missing $(feature_defines) when

generating the InjectedBundle bindings. So the various ENABLE_* defines
are available there.

12:28 AM Changeset in webkit [163772] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Tools

Merge r163373 - [GTK] Ensure generated events have given modifiers GDK understands
https://bugs.webkit.org/show_bug.cgi?id=128171

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-04
Reviewed by Carlos Garcia Campos.

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::webkitModifiersToGDKModifiers): Move around
(WTR::EventSenderProxy::createMouseButtonEvent):

12:27 AM Changeset in webkit [163771] by mihnea@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

[CSS Regions] Fix Propagating Border and Padding for Inline Replaced Elements Flowed in Regions
https://bugs.webkit.org/show_bug.cgi?id=123143

Reviewed by Andrei Bucur.

Add test to make sure that outlines and borders are properly painted for inline replaced
transformed elements, having margins and paddings, displayed in region.

  • compositing/regions/inline-replaced-transformed-in-region-expected.html: Added.
  • compositing/regions/inline-replaced-transformed-in-region.html: Added.
12:23 AM Changeset in webkit [163770] by ddkilzer@apple.com
  • 6 edits in trunk/Source/WebCore

Add type-safe casts for ContentData subclasses
<http://webkit.org/b/128510>

Reviewed by Darin Adler.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImages):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setContent):

  • Switch to toFooContentData() methods.
  • rendering/style/ContentData.h:
  • Define toFooContentData() methods.
  • Extract FooContentData::equals() methods so that the toFooContentData() methods can be used.
12:15 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
12:13 AM Changeset in webkit [163769] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163748 - Unreviewed, rolling out r162768.
http://trac.webkit.org/changeset/162768
https://bugs.webkit.org/show_bug.cgi?id=128495

Causes crashes on GTK WK2 in three fast/forms tests.
(Requested by zdobersek on #webkit).

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

12:10 AM Changeset in webkit [163768] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r163435 - MediaPlayerPrivateGStreamerBase should have virtual destructor
https://bugs.webkit.org/show_bug.cgi?id=128238

Reviewed by Carlos Garcia Campos.

MediaPlayerPrivateGStreamer inherit MediaPlayerPrivateGStreamerBase.
So MediaPlayerPrivateGStreamerBase should have virtual destructor.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Made destructor as virtual.
12:04 AM Changeset in webkit [163767] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163292 - Fix wrong mix of fcntl commands and flags
https://bugs.webkit.org/show_bug.cgi?id=127842

Reviewed by Darin Adler.

We are mixing the commands to set file descriptor and file status
flags in a couple of fcntl() calls. FD_CLOEXEC must be set using
F_SETFD, and the access mode flags (O_RDONLY, O_WRONLY, O_RDWR)
with F_SETFL.

This combines patches by Guillem Jover and Sergio Correia.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::readBytesFromSocket):

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::createHandle):

12:04 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)

Feb 9, 2014:

11:59 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
11:41 PM Changeset in webkit [163766] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit

Stop relinking WebKit on every build.

  • WebKit.xcodeproj/project.pbxproj: Fix the case on an input file for the Generate Export Files

script phase so it will run only when the inputs change rather than on every build.

11:23 PM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
11:21 PM Changeset in webkit [163765] by fpizlo@apple.com
  • 16 edits
    7 adds in trunk/Source/JavaScriptCore

GC blocks on FTL and then badness
https://bugs.webkit.org/show_bug.cgi?id=128291

Reviewed by Oliver Hunt.

Introduce the notion of a DFG::Safepoint, which allows you to unlock the rightToRun
mutex for your JIT thread, while supplying the GC with all of the information it would
need to scan you at that moment in time. The default way of using this is
DFG::GraphSafepoint, where you just supply the Graph. There's a lot of machinery in
this patch just to make the Graph scannable.

We then use DFG::GraphSafepoint in just two places for now: (1) while initializing LLVM
and (2) while invoking LLVM' optimizer and backend.

This is a 30% speed-up on Octane/typescript and a 10% speed-up on Octane/gbemu. 2-3%
speed-up overall on Octane.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::visitChildren):

  • dfg/DFGGraph.h:
  • dfg/DFGGraphSafepoint.cpp: Added.

(JSC::DFG::GraphSafepoint::GraphSafepoint):
(JSC::DFG::GraphSafepoint::~GraphSafepoint):

  • dfg/DFGGraphSafepoint.h: Added.
  • dfg/DFGOperations.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPlan.h:
  • dfg/DFGSafepoint.cpp: Added.

(JSC::DFG::Safepoint::Safepoint):
(JSC::DFG::Safepoint::~Safepoint):
(JSC::DFG::Safepoint::add):
(JSC::DFG::Safepoint::begin):
(JSC::DFG::Safepoint::visitChildren):

  • dfg/DFGSafepoint.h: Added.
  • dfg/DFGScannable.h: Added.

(JSC::DFG::Scannable::Scannable):
(JSC::DFG::Scannable::~Scannable):

  • dfg/DFGThreadData.cpp: Added.

(JSC::DFG::ThreadData::ThreadData):
(JSC::DFG::ThreadData::~ThreadData):

  • dfg/DFGThreadData.h: Added.
  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::visitChildren):
(JSC::DFG::Worklist::runThread):

  • dfg/DFGWorklist.h:
  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • heap/SlotVisitor.h:
  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::appendUnbarrieredReadOnlyPointer):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyValue):

10:02 PM Changeset in webkit [163764] by commit-queue@webkit.org
  • 12 edits
    6 adds
    3 deletes in trunk

-webkit-clip-path should support fill, stroke, view-box keywords
https://bugs.webkit.org/show_bug.cgi?id=128393

Source/WebCore:

Patch by Dirk Schulze <dschulze@chromium.org> on 2014-02-09
Reviewed by Dean Jackson.

CSS Masking uses the keywords fill, stroke and view-box for SVG shapes.
This patch updates the parser, style resolver and SVG implementation of
the prefixed clip-path property.

Remove the unexposed and obsolete keyword bounding-box.

Tests: svg/clip-path/clip-path-shape-fill-expected.svg

svg/clip-path/clip-path-shape-fill.svg
svg/clip-path/clip-path-shape-stroke-expected.svg
svg/clip-path/clip-path-shape-stroke.svg
svg/clip-path/clip-path-shape-view-box-expected.svg
svg/clip-path/clip-path-shape-view-box.svg

  • css/CSSParser.cpp: Parse fill, stroke, view-box. Remove bounding-box.

(WebCore::isBoxValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LayoutBox):

  • css/CSSValueKeywords.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue):

  • rendering/RenderLayer.cpp:

(WebCore::computeReferenceBox):

  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::setShapeSize):
(WebCore::ShapeInfo::logicalTopOffset):
(WebCore::ShapeInfo::logicalLeftOffset):

  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/SVGRenderingContext.cpp: Use different reference boxes per keyword.

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

Patch by Dirk Schulze <krit@webkit.org> on 2014-02-09
Reviewed by Dean Jackson.

Update or add new tests for changed clip-path keywords.

  • css3/masking/clip-path-circle-bounding-box.html: Removed.
  • fast/masking/parsing-clip-path-shape.html:
  • platform/mac/css3/masking/clip-path-circle-bounding-box-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-circle-bounding-box-expected.txt: Removed.
  • svg/clip-path/clip-path-shape-fill-expected.svg: Added.
  • svg/clip-path/clip-path-shape-fill.svg: Added.
  • svg/clip-path/clip-path-shape-stroke-expected.svg: Added.
  • svg/clip-path/clip-path-shape-stroke.svg: Added.
  • svg/clip-path/clip-path-shape-view-box-expected.svg: Added.
  • svg/clip-path/clip-path-shape-view-box.svg: Added.
9:40 PM Changeset in webkit [163763] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

[WebGL] Remove state restorer code
https://bugs.webkit.org/show_bug.cgi?id=128516

Reviewed by Dirk Schulze.

I'm not sure what the point of the WebGLStateRestorer class was. It was
always constructed with a false parameter, and then wasn't even retained
in local scope (so wouldn't have worked anyway). Meanwhile there were
also LOTS of calls to cleanupAfterGraphicsCall, the majority of which
were a no-op. I replaced the handful of cleanupAfterGraphicsCall(true)
with the call to markContextChanged().

  • html/canvas/OESVertexArrayObject.cpp:

(WebCore::OESVertexArrayObject::bindVertexArrayOES):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::attachShader):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::bindBuffer):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::bindRenderbuffer):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::blendColor):
(WebCore::WebGLRenderingContext::blendEquation):
(WebCore::WebGLRenderingContext::blendEquationSeparate):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::blendFuncSeparate):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::clearColor):
(WebCore::WebGLRenderingContext::clearDepth):
(WebCore::WebGLRenderingContext::clearStencil):
(WebCore::WebGLRenderingContext::colorMask):
(WebCore::WebGLRenderingContext::compileShader):
(WebCore::WebGLRenderingContext::compressedTexImage2D):
(WebCore::WebGLRenderingContext::compressedTexSubImage2D):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::cullFace):
(WebCore::WebGLRenderingContext::depthFunc):
(WebCore::WebGLRenderingContext::depthMask):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::detachShader):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateDrawArrays):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::validateDrawElements):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::finish):
(WebCore::WebGLRenderingContext::flush):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::frontFace):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getBufferParameter):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getProgramInfoLog):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
(WebCore::WebGLRenderingContext::getShaderInfoLog):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::hint):
(WebCore::WebGLRenderingContext::lineWidth):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::pixelStorei):
(WebCore::WebGLRenderingContext::polygonOffset):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::releaseShaderCompiler):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::sampleCoverage):
(WebCore::WebGLRenderingContext::scissor):
(WebCore::WebGLRenderingContext::shaderSource):
(WebCore::WebGLRenderingContext::stencilFunc):
(WebCore::WebGLRenderingContext::stencilFuncSeparate):
(WebCore::WebGLRenderingContext::stencilMask):
(WebCore::WebGLRenderingContext::stencilMaskSeparate):
(WebCore::WebGLRenderingContext::stencilOp):
(WebCore::WebGLRenderingContext::stencilOpSeparate):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texParameter):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::uniform1f):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2f):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2i):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3f):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3i):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4f):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4i):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
(WebCore::WebGLRenderingContext::useProgram):
(WebCore::WebGLRenderingContext::validateProgram):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
(WebCore::WebGLRenderingContext::viewport):
(WebCore::WebGLRenderingContext::vertexAttribfImpl):
(WebCore::WebGLRenderingContext::vertexAttribfvImpl):
(WebCore::WebGLRenderingContext::drawArraysInstanced):
(WebCore::WebGLRenderingContext::drawElementsInstanced):

  • html/canvas/WebGLRenderingContext.h:
9:40 PM Changeset in webkit [163762] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused layer owner from WebGLLayer
https://bugs.webkit.org/show_bug.cgi?id=128512

Reviewed by Dirk Schulze.

The m_layerOwner and ObjC category were not
used anywhere.

  • platform/graphics/mac/WebGLLayer.h:
  • platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer display]):

8:10 PM Changeset in webkit [163761] by ryuan.choi@samsung.com
  • 10 edits
    2 deletes in trunk/Source

[EFL] Remove PageClientEfl
https://bugs.webkit.org/show_bug.cgi?id=128508

Reviewed by Andreas Kling.

Source/WebCore:

PageClientEfl was introduced for accelerated compositing of WebKit1, but
it's bad idea because it's layer violation.
Indeed, it has never been used since introduced.

  • platform/Widget.h: Back to PlatformPageClient to Evas_Object.
  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

Removed empty method which use PageClientEfl.

  • platform/graphics/efl/GraphicsContext3DPrivate.h: Ditto.

Source/WebKit:

  • PlatformEfl.cmake: Removed PageClientEfl.cpp

Source/WebKit/efl:

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

Removed dependencies of PageClientEfl.
(WebCore::AcceleratedCompositingContext::initialize):

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::platformPageClient):

  • WebCoreSupport/PageClientEfl.cpp: Removed.
  • WebCoreSupport/PageClientEfl.h: Removed.
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

6:51 PM Changeset in webkit [163760] by fpizlo@apple.com
  • 181 edits in trunk/Source/JavaScriptCore

Never include *Inlines.h files in interface headers, and never include *Inlines.h when you could include Operations.h instead
https://bugs.webkit.org/show_bug.cgi?id=128505

Reviewed by Mark Hahnenberg and Oliver Hunt.

  • API/JSContextRef.cpp:
  • assembler/LinkBuffer.cpp:
  • bytecode/ArrayProfile.cpp:
  • bytecode/BytecodeBasicBlock.cpp:
  • bytecode/BytecodeLivenessAnalysisInlines.h:
  • bytecode/CallLinkInfo.cpp:
  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
  • bytecode/CodeBlockJettisoningWatchpoint.cpp:
  • bytecode/ExecutionCounter.cpp:
  • bytecode/MethodOfGettingAValueProfile.cpp:
  • bytecode/PreciseJumpTargets.cpp:
  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp:
  • bytecode/SamplingTool.cpp:
  • bytecode/SpecialPointer.cpp:
  • bytecode/StructureStubClearingWatchpoint.cpp:
  • debugger/DebuggerCallFrame.cpp:
  • dfg/DFGAbstractHeap.cpp:
  • dfg/DFGAbstractValue.cpp:
  • dfg/DFGArgumentsSimplificationPhase.cpp:
  • dfg/DFGArithMode.cpp:
  • dfg/DFGArrayMode.cpp:
  • dfg/DFGAtTailAbstractState.cpp:
  • dfg/DFGAvailability.cpp:
  • dfg/DFGBackwardsPropagationPhase.cpp:
  • dfg/DFGBasicBlock.cpp:
  • dfg/DFGBinarySwitch.cpp:
  • dfg/DFGBlockInsertionSet.cpp:
  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGCFAPhase.cpp:
  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCPSRethreadingPhase.cpp:
  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGCapabilities.cpp:
  • dfg/DFGClobberSet.cpp:
  • dfg/DFGClobberize.cpp:
  • dfg/DFGCommon.cpp:
  • dfg/DFGCommonData.cpp:
  • dfg/DFGCompilationKey.cpp:
  • dfg/DFGCompilationMode.cpp:
  • dfg/DFGConstantFoldingPhase.cpp:
  • dfg/DFGCriticalEdgeBreakingPhase.cpp:
  • dfg/DFGDCEPhase.cpp:
  • dfg/DFGDesiredIdentifiers.cpp:
  • dfg/DFGDesiredStructureChains.cpp:
  • dfg/DFGDesiredTransitions.cpp:
  • dfg/DFGDesiredWatchpoints.cpp:
  • dfg/DFGDisassembler.cpp:
  • dfg/DFGDisassembler.h:
  • dfg/DFGDominators.cpp:
  • dfg/DFGEdge.cpp:
  • dfg/DFGFailedFinalizer.cpp:
  • dfg/DFGFinalizer.cpp:
  • dfg/DFGFixupPhase.cpp:
  • dfg/DFGFlushFormat.cpp:
  • dfg/DFGFlushLivenessAnalysisPhase.cpp:
  • dfg/DFGFlushedAt.cpp:
  • dfg/DFGGraph.cpp:
  • dfg/DFGInPlaceAbstractState.cpp:
  • dfg/DFGInvalidationPointInjectionPhase.cpp:
  • dfg/DFGJITCode.cpp:
  • dfg/DFGJITCompiler.cpp:
  • dfg/DFGJITCompiler.h:
  • dfg/DFGJITFinalizer.cpp:
  • dfg/DFGJumpReplacement.cpp:
  • dfg/DFGLICMPhase.cpp:
  • dfg/DFGLazyJSValue.cpp:
  • dfg/DFGLivenessAnalysisPhase.cpp:
  • dfg/DFGLongLivedState.cpp:
  • dfg/DFGLoopPreHeaderCreationPhase.cpp:
  • dfg/DFGMinifiedNode.cpp:
  • dfg/DFGNaturalLoops.cpp:
  • dfg/DFGNode.cpp:
  • dfg/DFGNodeFlags.cpp:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
  • dfg/DFGOSREntry.cpp:
  • dfg/DFGOSREntrypointCreationPhase.cpp:
  • dfg/DFGOSRExit.cpp:
  • dfg/DFGOSRExitBase.cpp:
  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler32_64.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:
  • dfg/DFGOSRExitCompilerCommon.cpp:
  • dfg/DFGOSRExitJumpPlaceholder.cpp:
  • dfg/DFGOSRExitPreparation.cpp:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPhase.cpp:
  • dfg/DFGPlan.cpp:
  • dfg/DFGPredictionInjectionPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGResurrectionForValidationPhase.cpp:
  • dfg/DFGSSAConversionPhase.cpp:
  • dfg/DFGSSALoweringPhase.cpp:
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • dfg/DFGStackLayoutPhase.cpp:
  • dfg/DFGStoreBarrierElisionPhase.cpp:
  • dfg/DFGStrengthReductionPhase.cpp:
  • dfg/DFGThunks.cpp:
  • dfg/DFGTierUpCheckInjectionPhase.cpp:
  • dfg/DFGToFTLDeferredCompilationCallback.cpp:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
  • dfg/DFGTypeCheckHoistingPhase.cpp:
  • dfg/DFGUnificationPhase.cpp:
  • dfg/DFGUseKind.cpp:
  • dfg/DFGValidate.cpp:
  • dfg/DFGValueSource.cpp:
  • dfg/DFGVariableAccessDataDump.cpp:
  • dfg/DFGVariableEvent.cpp:
  • dfg/DFGVariableEventStream.cpp:
  • dfg/DFGVirtualRegisterAllocationPhase.cpp:
  • dfg/DFGWatchpointCollectionPhase.cpp:
  • dfg/DFGWorklist.cpp:
  • disassembler/Disassembler.cpp:
  • ftl/FTLLink.cpp:
  • ftl/FTLOSRExitCompiler.cpp:
  • ftl/FTLSlowPathCall.cpp:
  • ftl/FTLThunks.cpp:

(JSC::FTL::slowPathCallThunkGenerator):

  • heap/BlockAllocator.cpp:
  • heap/CodeBlockSet.cpp:
  • heap/ConservativeRoots.cpp:
  • heap/DeferGC.cpp:
  • heap/GCThread.cpp:
  • heap/GCThreadSharedData.cpp:
  • heap/HeapTimer.cpp:
  • heap/IncrementalSweeper.cpp:
  • heap/JITStubRoutineSet.cpp:
  • heap/MachineStackMarker.cpp:
  • heap/MarkStack.cpp:
  • heap/MarkedAllocator.cpp:
  • heap/MarkedSpace.cpp:
  • heap/SuperRegion.cpp:
  • heap/Weak.cpp:
  • heap/WeakHandleOwner.cpp:
  • heap/WeakSet.cpp:
  • heap/WriteBarrierBuffer.cpp:
  • heap/WriteBarrierSupport.cpp:
  • inspector/ScriptCallStackFactory.cpp:
  • interpreter/AbstractPC.cpp:
  • interpreter/JSStack.cpp:
  • interpreter/ProtoCallFrame.cpp:
  • interpreter/VMInspector.cpp:
  • jit/ArityCheckFailReturnThunks.cpp:
  • jit/AssemblyHelpers.cpp:
  • jit/ExecutableAllocator.cpp:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/GCAwareJITStubRoutine.cpp:
  • jit/HostCallReturnValue.cpp:
  • jit/JITDisassembler.cpp:
  • jit/JITDisassembler.h:
  • jit/JITExceptions.cpp:
  • jit/JITInlines.h:
  • jit/JITOperations.cpp:
  • jit/JITOperationsMSVC64.cpp:
  • jit/JITStubRoutine.cpp:
  • jit/JITStubs.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp:
  • jit/RegisterPreservationWrapperGenerator.cpp:
  • jit/RegisterSet.cpp:
  • jit/Repatch.cpp:
  • jit/TempRegisterSet.cpp:
  • jsc.cpp:
  • parser/Lexer.cpp:
  • parser/Parser.cpp:
  • parser/ParserArena.cpp:
  • parser/SourceCode.cpp:
  • parser/SourceProvider.cpp:
  • parser/SourceProviderCache.cpp:
  • profiler/ProfileGenerator.cpp:
  • runtime/Arguments.cpp:
  • runtime/ArgumentsIteratorPrototype.cpp:
  • runtime/CommonSlowPathsExceptions.cpp:
  • runtime/JSArgumentsIterator.cpp:
  • runtime/JSFunction.cpp:
  • runtime/JSGlobalObjectFunctions.cpp:
  • runtime/ObjectConstructor.cpp:
  • runtime/Operations.h:
  • runtime/VM.cpp:
5:09 PM Changeset in webkit [163759] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, don't mark isHostFunction() inline in the header file because that really confuses EFL.

  • runtime/JSFunction.h:
4:26 PM Changeset in webkit [163758] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS][wk2] ASSERT(WebThreadIsCurrent()) in [WebDisplayLinkHandler handleDisplayLink:]
https://bugs.webkit.org/show_bug.cgi?id=128490

Reviewed by Simon Fraser.

  • platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(-[WebDisplayLinkHandler handleDisplayLink:]):
[WebDisplayLinkHandler handleDisplayLink:] has an ASSERT(WebThreadIsCurrent()).

We don't use the Web Thread in WebKit2, but it looks like isMainThread()
does the right thing (main thread if web thread is disabled, web thread
otherwise), so use that instead.

3:52 PM Changeset in webkit [163757] by andersca@apple.com
  • 17 edits in trunk/Source

Add WTF_MAKE_FAST_ALLOCATED to more classes
https://bugs.webkit.org/show_bug.cgi?id=128506

Reviewed by Andreas Kling.

Source/JavaScriptCore:

  • bytecode/UnlinkedInstructionStream.h:
  • runtime/SymbolTable.h:
  • runtime/WriteBarrier.h:

Source/WebCore:

  • dom/Node.h:
  • dom/ScriptElement.h:
  • loader/ImageLoader.h:
  • loader/cache/CachedResourceClient.h:
  • platform/TreeShared.h:
  • platform/graphics/GlyphMetricsMap.h:
  • rendering/InlineBox.h:
  • rendering/RenderLayer.h:
  • rendering/RenderObject.h:

Source/WTF:

  • wtf/Bag.h:
  • wtf/ListHashSet.h:
3:32 PM Changeset in webkit [163756] by mhahnenberg@apple.com
  • 4 edits
    2 adds in trunk/Source/JavaScriptCore

Objective-C API NSDate conversion is off by 1000x (ms vs s)
https://bugs.webkit.org/show_bug.cgi?id=128386

Reviewed by Michael Saboff.

  • API/JSValue.mm:

(valueToObjectWithoutCopy):
(valueToDate):
(objectToValueWithoutCopy):

  • API/tests/DateTests.h: Added.
  • API/tests/DateTests.mm: Added.

(+[DateTests NSDateToJSDateTest]):
(+[DateTests JSDateToNSDateTest]):
(+[DateTests roundTripThroughJSDateTest]):
(+[DateTests roundTripThroughObjCDateTest]):

  • API/tests/testapi.mm:

(checkResult):

1:33 PM Changeset in webkit [163755] by akling@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Pass VM instead of ExecState to JSCell::fastGetOwnProperty().
<https://webkit.org/b/128497>

Knocks off a couple of instructions.

Reviewed by Anders Carlsson.

  • dfg/DFGOperations.cpp:
  • jit/JITOperations.cpp:

(JSC::getByVal):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

  • runtime/JSCell.h:
  • runtime/JSCellInlines.h:

(JSC::JSCell::fastGetOwnProperty):

1:32 PM Changeset in webkit [163754] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce ref churn in ChildNodesLazySnapshot iteration.
<https://webkit.org/b/128492>

Add a missing release() in ChildNodesLazySnapshot::nextNode()
so we don't have to churn the ref count.

Reviewed by Sam Weinig.

  • dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::nextNode):

1:31 PM Changeset in webkit [163753] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce ref churn in ChildInsertionNotifier.
<https://webkit.org/b/128494>

All callers of notifyNodeInsertedIntoDocument() already hold a strong
reference on the Node, so there's no need to ref it again inside.

Reviewed by Anders Carlsson.

  • dom/ContainerNodeAlgorithms.h:

(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):

10:47 AM Changeset in webkit [163752] by andersca@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Convert some JSC code over to std::mutex
https://bugs.webkit.org/show_bug.cgi?id=128500

Reviewed by Dan Bernstein.

  • API/JSVirtualMachine.mm:

(wrapperCacheMutex):
(+[JSVMWrapperCache addWrapper:forJSContextGroupRef:]):
(+[JSVMWrapperCache wrapperForJSContextGroupRef:]):

  • heap/GCThreadSharedData.h:
  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::mergeOpaqueRoots):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::containsOpaqueRootTriState):

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::registerDebuggable):
(Inspector::RemoteInspector::unregisterDebuggable):
(Inspector::RemoteInspector::updateDebuggable):
(Inspector::RemoteInspector::sendMessageToRemoteFrontend):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::xpcConnectionFailed):
(Inspector::RemoteInspector::pushListingSoon):
(Inspector::RemoteInspector::receivedIndicateMessage):

  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
(Inspector::RemoteInspectorDebuggableConnection::closeFromDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::close):
(Inspector::RemoteInspectorDebuggableConnection::sendMessageToBackend):

  • jit/ExecutableAllocator.cpp:

(JSC::DemandExecutableAllocator::DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::~DemandExecutableAllocator):
(JSC::DemandExecutableAllocator::bytesAllocatedByAllAllocators):
(JSC::DemandExecutableAllocator::bytesCommittedByAllocactors):
(JSC::DemandExecutableAllocator::dumpProfileFromAllAllocators):
(JSC::DemandExecutableAllocator::allocatorsMutex):

4:11 AM Changeset in webkit [163751] by zandobersek@gmail.com
  • 15 edits in trunk/Source/WebCore

Manage ShadowData through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128466

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr to manage ShadowData objects.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::PropertyWrapperShadow::PropertyWrapperShadow):
(WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setTextShadow):
(WebCore::RenderStyle::setBoxShadow):

  • rendering/style/RenderStyle.h:
  • rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setShadow):

  • rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleShadowSVGData::StyleShadowSVGData):

  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::setNext):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):

  • rendering/style/StyleRareNonInheritedData.h:
3:39 AM Changeset in webkit [163750] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fix modifiers on EventSenderProxy::keyDown
https://bugs.webkit.org/show_bug.cgi?id=128496

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::keyDown): do not attempt to doubly transform modifiers
into GTK+ ones.

2:55 AM Changeset in webkit [163749] by commit-queue@webkit.org
  • 28 edits
    3 copies in trunk

.: [GTK] Enable touch features
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsGTK.cmake: set ENABLE_TOUCH_EVENTS to 1 if building with GTK+.

Source/WebCore: [GTK] Add touch-events related code to build
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Tests in fast/events/touch have been enabled on GTK+ now that touch
support is implemented, and thus all expected bits are there.

  • platform/gtk/GtkTouchContextHelper.cpp:
  • platform/gtk/GtkTouchContextHelper.h: Add helper object to track all touchpoints, handy

when creating WebTouchEvents.

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • bindings/gobject/GNUmakefile.am: Add touch related code and idls to build, those are

necessary now that GTK+ implements touch events.

Source/WebKit/gtk: [GTK] Allow building with touch events enabled
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

Even though WebKit1 GTK code doesn't implement touch events,
Fix build if ENABLE_TOUCH_EVENTS is present for WK2.

  • WebCoreSupport/ChromeClientGtk.h:

(WebKit::ChromeClient::needTouchEvents): Add empty stub

Source/WebKit2: [GTK] Implement support touch events
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

In GTK+ >= 3.4.0, GdkEventTouch is available to inform about multitouch events. Use these to implement
touch events on this platform. If a touch is left unhandled and is the "pointer emulating" one, mouse
events will be generated as a fallback.

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • Shared/gtk/NativeWebTouchEventGtk.cpp:
  • Shared/NativeWebTouchEvent.h:

(WebKit::NativeWebTouchEvent::nativeEvent):
(WebKit::NativeWebTouchEvent::touchContext): Add GTK+ implementation of NativeWebTouchEvent.

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::touchPhaseFromEvents):
(WebKit::WebEventFactory::createWebTouchEvent): Add methods to generate WebTouchEvents out
of GdkEventTouch events, a GtkTouchContextHelper object is used to hold information about all current
touches, in order to build information about all individual touchpoints.

  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithTouchEvent): Implement pointer emulation. If a touch event was unhandled
in DOM and pertains to the touch sequence that emulates pointer events. The event gets transformed to its
mouse event counterpart and handled by the widget again.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize): Listen for touch events
(webkitWebViewBaseTouchEvent):
(webkit_web_view_base_class_init): Add implementation for the touch_events() handler, this merely
lets the pageProxy handle the NativeWebTouchEvent we create to wrap the GdkEvent received.

Tools: [GTK] Enable touch features
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

  • WebKitTestRunner/EventSenderProxy.h:
  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::updateEventCoordinates):
(WTR::EventSenderProxy::createTouchEvent):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::sendUpdatedTouchEvents):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::setTouchModifier): Implement touch event proxying.

LayoutTests: [GTK] Enable touch features
https://bugs.webkit.org/show_bug.cgi?id=98931

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-09
Reviewed by Carlos Garcia Campos.

  • platform/gtk/TestExpectations: remove fast/events/touch
  • platform/gtk-wk2/TestExpectations: Add new expectations on

fast/events/touch events.

2:31 AM Changeset in webkit [163748] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r162768.
http://trac.webkit.org/changeset/162768
https://bugs.webkit.org/show_bug.cgi?id=128495

Causes crashes on GTK WK2 in three fast/forms tests.
(Requested by zdobersek on #webkit).

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

2:28 AM WebKitGTK/2.4.x edited by zandobersek@gmail.com
Add the rollout in r163748 to the list of necessary merges. (diff)
12:58 AM Changeset in webkit [163747] by zandobersek@gmail.com
  • 13 edits in trunk/Source/WebCore

Switch the rest of CSS code from OwnPtr over to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128471

Reviewed by Andreas Kling.

Replace the remaining uses of OwnPtr in the CSS code with std::unique_ptr, covering
the CSSParser, CSSParserSelector and CSSSelector classes and a few additional, closely related classes.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseDeclaration):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::markSupportsRuleHeaderStart):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSParser.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):
(WebCore::CSSParserSelector::~CSSParserSelector):
(WebCore::CSSParserSelector::adoptSelectorVector):
(WebCore::CSSParserSelector::insertTagHistory):
(WebCore::CSSParserSelector::appendTagHistory):
(WebCore::CSSParserSelector::prependTagSelector):

  • css/CSSParserValues.h:

(WebCore::CSSParserSelector::releaseSelector):
(WebCore::CSSParserSelector::setTagHistory):
(WebCore::CSSParserSelector::clearTagHistory):

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::setSelectorList):

  • css/CSSSelector.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::adoptSelectorVector):

  • css/CSSSelectorList.h:
  • css/CSSValueList.cpp:
  • css/StyleRule.cpp:

(WebCore::StyleRuleRegion::StyleRuleRegion):

  • css/StyleRule.h:

(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRuleRegion::create):

12:33 AM Changeset in webkit [163746] by zandobersek@gmail.com
  • 8 edits in trunk/Source/WebCore

Manage MutationObserverInterestGroup through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128468

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr for managing MutationObserverInterestGroup objects.

  • css/PropertySetCSSStyleDeclaration.cpp:
  • dom/CharacterData.cpp:

(WebCore::CharacterData::dispatchModifiedEvent):

  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::ChildListMutationAccumulator):

  • dom/ChildListMutationScope.h:

(WebCore::ChildListMutationAccumulator::hasObservers):

  • dom/Element.cpp:

(WebCore::Element::willModifyAttribute):

  • dom/MutationObserverInterestGroup.cpp:

(WebCore::MutationObserverInterestGroup::createIfNeeded):

  • dom/MutationObserverInterestGroup.h:

(WebCore::MutationObserverInterestGroup::createForChildListMutation):
(WebCore::MutationObserverInterestGroup::createForCharacterDataMutation):
(WebCore::MutationObserverInterestGroup::createForAttributesMutation):

12:19 AM Changeset in webkit [163745] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r163737.
http://trac.webkit.org/changeset/163737
https://bugs.webkit.org/show_bug.cgi?id=128491

Caused 8+ tests to fail on Mavericks and Mountain Lion bots
(Requested by rniwa on #webkit).

  • runtime/JSString.h:

(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):
(JSC::SmallStrings::SmallStrings):

12:18 AM Changeset in webkit [163744] by zandobersek@gmail.com
  • 22 edits in trunk/Source/WebCore

Manage MessagePort, MessagePortChannel and friends through std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128467

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr to manage MessagePort, MessagePortArray, MessagePortChannel
and MessagePortChannelArray objects.

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • dom/MessageEvent.cpp:

(WebCore::MessageEvent::MessageEvent):
(WebCore::MessageEvent::initMessageEvent):

  • dom/MessageEvent.h:

(WebCore::MessageEvent::create):

  • dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):
(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::entangle):
(WebCore::MessagePort::dispatchMessages):
(WebCore::MessagePort::disentanglePorts):
(WebCore::MessagePort::entanglePorts):

  • dom/MessagePort.h:
  • dom/MessagePortChannel.h:
  • dom/default/PlatformMessagePortChannel.cpp:

(WebCore::PlatformMessagePortChannel::EventData::EventData):
(WebCore::MessagePortChannel::createChannel):
(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):

  • dom/default/PlatformMessagePortChannel.h:

(WebCore::PlatformMessagePortChannel::EventData::channels):

  • page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
(WebCore::DOMWindow::postMessage):

  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::postMessage):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerConnectTask::create):
(WebCore::SharedWorkerConnectTask::SharedWorkerConnectTask):
(WebCore::SharedWorkerConnectTask::performTask):
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
(WebCore::SharedWorkerScriptLoader::notifyFinished):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::DefaultSharedWorkerRepository::connectToWorker):

  • workers/DefaultSharedWorkerRepository.h:
  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::createConnectEvent):

  • workers/SharedWorkerRepository.cpp:

(WebCore::SharedWorkerRepository::connect):

  • workers/SharedWorkerRepository.h:
  • workers/Worker.cpp:

(WebCore::Worker::postMessage):

  • workers/WorkerGlobalScopeProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerGlobalScopeTask::create):
(WebCore::MessageWorkerGlobalScopeTask::MessageWorkerGlobalScopeTask):
(WebCore::MessageWorkerGlobalScopeTask::performTask):
(WebCore::MessageWorkerTask::create):
(WebCore::MessageWorkerTask::MessageWorkerTask):
(WebCore::MessageWorkerTask::performTask):
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:

Feb 8, 2014:

11:29 PM Changeset in webkit [163743] by akling@apple.com
  • 2 edits in trunk/Tools

Let Instruments time profiler run until tests finish.
<https://webkit.org/b/128488>

Pass "-T 0" to iprofiler to ensure that we get a time profile of the
entire performance test run instead of just the first 10 seconds.

Reviewed by Brady Eidson.

  • Scripts/webkitpy/common/system/profiler.py:

(IProfiler.attach_to_pid):

10:08 PM Changeset in webkit [163742] by beidson@apple.com
  • 4 edits in trunk

IDB: storage/indexeddb/mozilla/object-cursors.html fails
<rdar://problem/16020585> and https://bugs.webkit.org/show_bug.cgi?id=128479

Reviewed by Dan Bernstein.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata): Update the IndexInfo

table schema to allow for indexes with the same id/name as previous indexes.
But with different object stores, of course.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Enable the test.
10:07 PM Changeset in webkit [163741] by beidson@apple.com
  • 5 edits in trunk

IDB: storage/indexeddb/mozilla/index-prev-no-duplicate.html fails
<rdar://problem/16018918> and https://bugs.webkit.org/show_bug.cgi?id=128444

Reviewed by Dan Bernstein.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::getIndexStatement): Return different statements for unique cursors that will

sort the values in reverse of the cursor direction, matching expected IndexedDB behavior.

(WebKit::SQLiteIDBCursor::establishStatement):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord): Insert the values as

strings since we need the collation function to be called for proper sorting.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Enable the test.
9:48 PM Changeset in webkit [163740] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

Build fix after r163739.

  • WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame collapseSelection]):
(-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):

8:58 PM Changeset in webkit [163739] by rniwa@webkit.org
  • 21 edits in trunk/Source

Cleanup the interface of FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=128481

Reviewed by Andreas Kling.

Source/WebCore:

Removed FrameSelection::end() as intended in r163232, and the stale declaration of
paintDragCaret() which was supposed to be removed when we extracted DragCaretController.

Renamed caretRenderer() to caretRendererWithoutUpdatingLayout() to clarify the contract
as the only caller of this function is RenderBlock::paintCaret. Also renamed bounds()
to selectionBounds() to make it more easily identifiable / grep'able.

In addition, made recomputeCaretRect() and invalidateCaretRect() private.

  • WebCore.exp.in:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::caretRendererWithoutUpdatingLayout):
(WebCore::FrameSelection::selectionBounds):
(WebCore::FrameSelection::revealSelection):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::setCaretVisible):

  • page/DragController.cpp:

(WebCore::dragLocForSelectionDrag):

  • page/FrameSnapshotting.cpp:

(WebCore::snapshotSelection):

  • page/win/FrameWin.cpp:

(WebCore::imageFromSelection):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret):

  • testing/Internals.cpp:

(WebCore::Internals::selectionBounds):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::selectionRectangle):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::rectangleForSelection):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _lookUpInDictionaryFromMenu:]):
(-[WebHTMLView selectionRect]):
(-[WebHTMLView selectionImageRect]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::selectionRect):

Source/WebKit2:

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::getFindIndicatorBitmapAndRect):
(WebKit::FindController::drawRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions):

8:31 PM Changeset in webkit [163738] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted part of r163734, because the assertion it enabled still fails when running
loader/load-defer-resume-crash.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::dataReceived):

7:51 PM Changeset in webkit [163737] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Simplify single character substrings in JSC
https://bugs.webkit.org/show_bug.cgi?id=128483

Reviewed by Andreas Kling.

With the recent work to make StringImpl occupy less space, it is actually more
efficient to allocate a single character string that it is to use createSubstringSharingImpl!

  • runtime/JSString.h:

(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):
(JSC::SmallStrings::SmallStrings):

7:36 PM Changeset in webkit [163736] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

EFL build fix after r163729.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version):

6:56 PM Changeset in webkit [163735] by Brian Burg
  • 11 edits
    8 adds in trunk/Source/WebInspectorUI

Web Inspector: show probe sets for script content views in the details sidebar
https://bugs.webkit.org/show_bug.cgi?id=128333

Reviewed by Timothy Hatcher.

This patch adds a new details sidebar for showing the probes associated with any
breakpoint in the currently visible source file. Each probe set (corresponding to
multiple actions of single breakpoint) gets its own ProbeSetDetailsSection. The
section contains a custom DataGrid subclass to display probe data, and some icons
for clearing samples, deleting the probe, and adding a new probe expression.

The table containing probe data keeps its columns in sync with the probe set's
probe expressions. To support this, DataGrid has been further refactored to support
removing columns, and inserting columns (rather than only appending). With this
capability, probe columns are removed and re-inserted when the expression changes.

The availability of the probe details sidebar is controlled by providing the
probe sets matching the script content view's resource URL as supplemental
represented objects.

Lastly, added the utility EventListenerSet class. This holds a set of event listeners
that should be added and removed together, and takes care of binding thisObject
according to whether the event emitter is a Node or WebInspector.Object.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/BreakpointActionView.js:

(WebInspector.BreakpointActionView):
(WebInspector.BreakpointActionView.prototype._removeAction): Renamed from removeButtonClicked.
(WebInspector.BreakpointActionView.prototype._codeMirrorBlurred): Change the behavior
of CodeMirror-backed editors for probe and evaluate expression actions. If the expression
consists entirely of trimmable whitespace, then delete the action rather than saving it.

  • UserInterface/DataGrid.js:

(WebInspector.DataGrid): Copy over the column data into a map inside insertColumn() instead.
(WebInspector.DataGrid.prototype.insertColumn): Renamed from addColumn. It now takes an
optional insertionIndex argument and splices the column before the element at that index.
Also, convert code to use EventListenerSet for adding/removing per-column event listeners.

(WebInspector.DataGrid.prototype.removeColumn): Added. It splices the column out.
(WebInspector.DataGridNode.prototype.isEventWithinDisclosureTriangle): Whitespace.

  • UserInterface/EventListenerSet.js: Added.

(WebInspector.EventListenerSet):
(WebInspector.EventListenerSet.prototype.register):
(WebInspector.EventListenerSet.prototype.unregister):
(WebInspector.EventListenerSet.prototype.install):
(WebInspector.EventListenerSet.prototype.uninstall):

  • UserInterface/Images/NavigationItemProbes.pdf: Added.
  • UserInterface/LayerTreeDataGrid.js:

(WebInspector.LayerTreeDataGrid.prototype._updateChildren): Fix a missing column.get().

  • UserInterface/Main.html: Add new JavaScript and CSS files.
  • UserInterface/Main.js:

(WebInspector.contentLoaded): Add the probe details sidebar.

  • UserInterface/ProbeDetailsSidebarPanel.css: Added.

(.sidebar > .panel.probes > .navigation-bar):
(.sidebar > .panel.probes > .content):
(.details-section.probe-set .options > .probe-add):
(.details-section.probe-set .options > .probe-clear-samples):
(.details-section.probe-set .options > .probe-remove):
(.details-section.probe-set .options > input):
(.panel.probes ::-webkit-scrollbar):
(.panel.probes ::-webkit-scrollbar-track):
(.panel.probes ::-webkit-scrollbar-thumb):
(.panel.probes ::-webkit-scrollbar-corner):
(.popover .probe-popover):
(.popover .probe-popover input):

  • UserInterface/ProbeDetailsSidebarPanel.js: Added.

(WebInspector.ProbeDetailsSidebarPanel):
(WebInspector.ProbeDetailsSidebarPanel.prototype.get inspectedProbeSets):
(WebInspector.ProbeDetailsSidebarPanel.prototype._probeSetAdded):

  • UserInterface/ProbeManager.js: Remove unused probeSetForBreakpoint function.
  • UserInterface/ProbeSet.js: Fix erroneous uses of probe.identifier instead of probe.id.

(WebInspector.ProbeSet.prototype.removeProbe):
(WebInspector.ProbeSet.prototype._sampleCollected):

  • UserInterface/ProbeSetDataGrid.css: Added.

(.details-section.probe-set .data-grid .data-container tr.past-value td):
(.details-section.probe-set .data-grid > .data-container td.unknown-value):
(.details-section.probe-set .data-grid .data-container tr.revealed.highlighted):
(@-webkit-keyframes blink-frame-highlight):
(100%):
(.details-section.probe-set .data-grid .data-container tr.separator):
(.details-section.probe-set .data-grid > .data-container tr.data-updated):
(@-webkit-keyframes blink-probe-frame):
(.details-section.probe-set .data-grid .data-container .selected .section *):
(.details-section.probe-set .data-grid .data-container .selected td.unknown-value):
(.details-section.probe-set .data-grid .data-container .section):
(.details-section.probe-set .data-grid th):
(.details-section.probe-set .data-grid th:not(:last-child)):
(.details-section.probe-set .data-grid td):

  • UserInterface/ProbeSetDataGrid.js: Added.

(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype.closed):
(WebInspector.ProbeSetDataGrid.prototype._setupProbe):
(WebInspector.ProbeSetDataGrid.prototype._teardownProbe):
(WebInspector.ProbeSetDataGrid.prototype._setupData):
(WebInspector.ProbeSetDataGrid.prototype._teardownData):
(WebInspector.ProbeSetDataGrid.prototype._updateNodeForFrame.else.sortFunction):
(WebInspector.ProbeSetDataGrid.prototype._updateNodeForFrame.else.set node):
(WebInspector.ProbeSetDataGrid.prototype._dataFrameInserted):
(WebInspector.ProbeSetDataGrid.prototype._dataSeparatorInserted):
(WebInspector.ProbeSetDataGrid.prototype._probeExpressionChanged.get var):

  • UserInterface/ProbeSetDataGridNode.js: Added.

(WebInspector.ProbeSetDataGridNode):
(WebInspector.ProbeSetDataGridNode.prototype.get element):
(WebInspector.ProbeSetDataGridNode.prototype.get data):
(WebInspector.ProbeSetDataGridNode.prototype.set frame):
(WebInspector.ProbeSetDataGridNode.prototype.get frame):
(WebInspector.ProbeSetDataGridNode.prototype.createCellContent):
(WebInspector.ProbeSetDataGridNode.prototype.updateCellsFromFrame):
(WebInspector.ProbeSetDataGridNode.prototype.updateCellsForSeparator):

  • UserInterface/ProbeSetDataTable.js:

(WebInspector.ProbeSetDataTable.prototype.removeProbe): Fix a typo in for..of loop refactor.

  • UserInterface/ProbeSetDetailsSection.js: Added.

(WebInspector.ProbeSetDetailsSection):
(WebInspector.ProbeSetDetailsSection.prototype.closed):
(WebInspector.ProbeSetDetailsSection.prototype._probeSetPositionTextOrLink):
(WebInspector.ProbeSetDetailsSection.prototype._addProbeButtonClicked):
(WebInspector.ProbeSetDetailsSection.prototype._removeButtonClicked):
(WebInspector.ProbeSetDetailsSection.prototype._clearSamplesButtonClicked):

  • UserInterface/TextResourceContentView.js:

(WebInspector.TextResourceContentView):
(WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
Add probe sets whose breakpoint matches the represented object's URL.
(WebInspector.TextResourceContentView.prototype._probeSetsChanged): Tell listeners
to re-fetch supplementalRepresentedObjects when probe sets are added or removed.

6:37 PM Changeset in webkit [163734] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Remove outdated workarounds in DocumentLoader::dataReceived
https://bugs.webkit.org/show_bug.cgi?id=128465

Reviewed by Andreas Kling.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::dataReceived):

5:43 PM Changeset in webkit [163733] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Baseline JIT uses the wrong version of checkMarkWord in emitWriteBarrier
https://bugs.webkit.org/show_bug.cgi?id=128474

Reviewed by Michael Saboff.

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):

5:21 PM Changeset in webkit [163732] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

Remove some unused functions from SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Oliver Hunt.

Removed more unused code, particularly in API helpers. Renamed one serialize()
function to create(), because it does the same thing as other create() functions.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/js/SerializedScriptValue.h:
5:13 PM Changeset in webkit [163731] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove use of PLATFORM(MAC) from WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=128476

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:46 PM Changeset in webkit [163730] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Rename a field and some variables in JSLock to better describe what they contain.
<https://webkit.org/b/128475>

Reviewed by Oliver Hunt.

  • runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/JSLock.h:
4:01 PM Changeset in webkit [163729] by beidson@apple.com
  • 4 edits in trunk

IDB: storage/indexeddb/mozilla/versionchange-abort.html fails
<rdar://problem/16018887> and https://bugs.webkit.org/show_bug.cgi?id=128442

Reviewed by Dan Bernstein.

Source/WebCore:

Tested by storage/indexeddb/mozilla/versionchange-abort.html (and probably others)

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::version): If the version is NoIntVersion, return DefaultIntVersion to script.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Enable the test. Also add all the other storage/indexeddb/mozilla test with expectations as they are what I’m focusing on right now.
4:00 PM Changeset in webkit [163728] by beidson@apple.com
  • 8 edits in trunk

IDB: storage/indexeddb/mozilla/cursors.html fails
<rdar://problem/16017998> and https://bugs.webkit.org/show_bug.cgi?id=128423

Reviewed by Dan Bernstein.

Source/WebCore:

Tested by storage/indexeddb/mozilla/cursors.html (And probably others)

  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::OpenCursorOperation::perform): Distinguish between an error while opening the cursor

and opening a cursor that points to no records.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::internalAdvanceOnce): Store the primary key for object store cursors.
(WebKit::SQLiteIDBCursor::iterate): We’re not supposed to check for equality to the target key.

Depending on the direction of the cursor we should check for the next highest or next lowest key.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Unskip storage/indexeddb/mozilla/cursors.html.

Revert the change to storage/indexeddb/mozilla/clear.html as it is now clear how a
null cursor might be returned from openCursor:

  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/resources/clear.js:
3:31 PM Changeset in webkit [163727] by andersca@apple.com
  • 5 edits in trunk/Source

Stop using getCharactersWithUpconvert in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=128457

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Change substituteBackreferencesSlow to take StringViews and use a StringBuilder instead of upconverting
if the source or replacement strings area 16-bit.

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):

Source/WTF:

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::append):
Add a new overload that takes a StringView.

  • wtf/text/StringView.h:

(WTF::StringView::find):
Add new find member function.

2:29 PM Changeset in webkit [163726] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Remove unused ChromeClient::layoutUpdated().
<https://webkit.org/b/128470>

Nobody listens for this callback anymore so remove it.

Reviewed by Anders Carlsson.

  • page/Chrome.cpp:
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/FrameView.cpp:

(WebCore::FrameView::layout):

2:26 PM Changeset in webkit [163725] by mitz@apple.com
  • 71 edits in trunk/Source/WebCore

Stop using PLATFORM(MAC) in WebCore except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128464

Reviewed by Anders Carlsson.

  • Modules/webaudio/AudioContext.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::AudioContext::constructCommon):

  • accessibility/AccessibilityNodeObject.cpp: Ditto.

(WebCore::AccessibilityNodeObject::visibleText):

  • accessibility/AccessibilityObject.h: Ditto.
  • accessibility/AccessibilityRenderObject.cpp: Ditto.

(WebCore::AccessibilityRenderObject::clickPoint):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::addChildren):

  • accessibility/AccessibilityRenderObject.h: Ditto.
  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::platform): Made it explicit that this function returns
"mac" when built for iOS.

  • bindings/js/ScriptController.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::ScriptController::ScriptController):

  • bindings/js/ScriptController.h: Ditto.
  • crypto/CryptoKey.cpp: Changed PLATFORM(MAC) to OS(DARWIN) && !PLATFORM(EFL) &&

!PLATFORM(GTK) when checking for whether to use CoreCrypto.

  • crypto/keys/CryptoKeyRSA.h: Ditto.
  • dom/Clipboard.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • dom/Document.cpp: Ditto.

(WebCore::Document::implicitClose):

  • dom/KeyboardEvent.h: Ditto.
  • editing/Editor.cpp: Ditto.

(WebCore::Editor::cut):
(WebCore::Editor::copy):
(WebCore::Editor::copyImage):

  • editing/Editor.h: Ditto.
  • editing/FrameSelection.h: Ditto.
  • editing/TypingCommand.cpp: Ditto.

(WebCore::TypingCommand::typingAddedToOpenCommand):

  • history/HistoryItem.h: Ditto.
  • html/HTMLMediaElement.cpp: Ditto.

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLMediaElement.h: Ditto.
  • html/HTMLPlugInElement.cpp: Ditto.

(WebCore::registeredPluginReplacements):

  • html/HTMLPlugInImageElement.cpp: Ditto.

(WebCore::HTMLPlugInImageElement::setDisplayState):

  • html/HTMLSelectElement.cpp: Ditto.

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • html/shadow/MediaControlElements.cpp: Ditto.

(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):

  • html/shadow/MediaControlElements.h: Ditto.
  • inspector/InspectorIndexedDBAgent.cpp: Ditto.
  • loader/CookieJar.cpp: Ditto.
  • loader/DocumentLoader.cpp: Ditto.

(WebCore::DocumentLoader::dataReceived):

  • loader/DocumentLoader.h: Ditto.

(WebCore::DocumentLoader::didTellClientAboutLoad):

  • loader/EmptyClients.h: Ditto.
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadArchive): Added !PLATFORM(IOS) around Mac-only workaround.
(WebCore::FrameLoader::defaultObjectContentType): Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebCore::FrameLoader::subresourceCachePolicy): Ditto.

  • loader/ResourceBuffer.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around functions that

are implemented using Foundation.

  • loader/ResourceLoadScheduler.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::ResourceLoadScheduler::scheduleLoad):

  • loader/ResourceLoader.cpp: Ditto.

(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):

  • loader/ResourceLoader.h: Ditto.
  • loader/archive/cf/LegacyWebArchive.cpp: Ditto.
  • loader/cache/CachedResource.cpp: Changed PLATFORM(MAC) to USE(FOUNDATION) around function

that is implemented using other USE(FOUNDATION)-guarded code.

  • loader/cache/CachedResource.h: Ditto.
  • page/Chrome.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • page/ChromeClient.h: Ditto.
  • page/ContextMenuClient.h: Ditto.
  • page/ContextMenuController.cpp: Ditto.

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendFontSubMenu):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

  • page/DragClient.h: Ditto.
  • page/DragController.cpp: Ditto.

(WebCore::dragLocForDHTMLDrag):
(WebCore::dragLocForSelectionDrag):
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):

  • page/EditorClient.h: Ditto.
  • page/EventHandler.cpp: Ditto.

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::logicalScrollRecursively):
(WebCore::EventHandler::clearDragState):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):

  • page/EventHandler.h: Ditto.
  • page/FrameView.cpp: Ditto.

(WebCore::FrameView::layout):

  • page/Page.h: Ditto.
  • page/Settings.cpp: Ditto.
  • page/Settings.h: Ditto.
  • page/scrolling/ScrollingCoordinator.cpp: Ditto.
  • page/scrolling/ScrollingCoordinator.h: Ditto.
  • page/scrolling/ScrollingStateNode.h: Removed unused #include.
  • page/scrolling/ScrollingThread.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::ScrollingThread::createThreadIfNeeded):

  • page/scrolling/ScrollingThread.h: Ditto.
  • platform/network/cf/ResourceRequest.h: Added !PLATFORM(IOS) around

applyWebArchiveHackForMail.

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::applyWebArchiveHackForMail): Ditto.

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::applyWebArchiveHackForMail): Ditto.

  • plugins/PluginViewNone.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA)
  • rendering/RenderBox.cpp: Ditto.

(WebCore::RenderBox::logicalScroll):

  • rendering/RenderLayerBacking.cpp: Ditto.

(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):

  • rendering/RenderMenuList.h: Ditto.
  • rendering/RenderText.cpp: Ditto.

(WebCore::RenderText::previousOffsetForBackwardDeletion):

  • rendering/break_lines.cpp: Removed unused #include.
  • testing/js/WebCoreTestSupport.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • xml/XSLStyleSheetLibxslt.cpp: Changed PLATFORM(MAC) to OS(DARWIN) && !PLATFORM(EFL) &&

!PLATFORM(GTK) around soft-linking libxslt.

  • xml/XSLTExtensions.cpp: Ditto.
  • xml/XSLTProcessorLibxslt.cpp: Ditto.
  • xml/XSLTUnicodeSort.cpp: Ditto.
2:20 PM Changeset in webkit [163724] by akling@apple.com
  • 19 edits in trunk/Source

Remove unused ChromeClient::formStateDidChange().
<https://webkit.org/b/128469>

Nobody listens for this callback anymore so remove it and stop
spamming no-op virtual dispatches in forms code.

Reviewed by Anders Carlsson.

  • html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):

  • html/HTMLFormControlElementWithState.cpp:
  • html/HTMLFormControlElementWithState.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::setValue):
(WebCore::HTMLInputElement::setValueFromRenderer):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::selectOption):

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateValue):
(WebCore::HTMLTextAreaElement::setValueCommon):

  • loader/EmptyClients.h:
  • page/ChromeClient.h:
2:11 PM Changeset in webkit [163723] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: Find evaluates attributes in a case sensitive manner
https://bugs.webkit.org/show_bug.cgi?id=128405

Patch by Chris J. Shull <chrisjshull@gmail.com> on 2014-02-08
Reviewed by Timothy Hatcher.

Source/WebCore:

Changed matchesAttribute to ignore case.

Updated existing test with additional cases:
inspector-protocol/dom/dom-search.html

  • inspector/InspectorNodeFinder.cpp:

(WebCore::InspectorNodeFinder::matchesAttribute):

LayoutTests:

Added checks for searches where capitalization in the attributes did not match the capitalization in the search. Also fleshed out other search types with checks for valid capitalization differences.

  • inspector-protocol/dom/dom-search-expected.txt:
  • inspector-protocol/dom/resources/dom-search-queries.js:
2:05 PM Changeset in webkit [163722] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused FrameLoaderClient::dispatchWillOpenSocketStream().
<https://webkit.org/b/128472>

Nobody listens for this callback anymore so remove it.

Reviewed by Anders Carlsson.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::willOpenSocketStream):

  • loader/FrameLoaderClient.h:
1:40 PM Changeset in webkit [163721] by rniwa@webkit.org
  • 8 edits in trunk/Source/WebCore

Split UserTriggered into FireSelectEvent and RevealSelection for selection options
https://bugs.webkit.org/show_bug.cgi?id=128441

Reviewed by Darin Adler.

Split UserTriggered by FireSelectEvent and RevealSelection for selection options.

Also added defaultSetSelectionOptions() to abstract away the default options.

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):

  • editing/Editor.cpp:

(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::moveTo):
(WebCore::FrameSelection::setSelectionByMouseIfDifferent): UserTriggered | DoNotRevealSelection
is replaced by FireSelectEvent.
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): Check options & FireSelectEvent
instead of options & UserTriggered.
(WebCore::FrameSelection::setSelection): Check options & RevealSelection instead of
options & UserTriggered && !(options & DoNotRevealSelection).
(WebCore::FrameSelection::prepareForDestruction):
(WebCore::FrameSelection::setBase):
(WebCore::FrameSelection::setExtent):
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::defaultSetSelectionOptions): Added.

  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::doApply):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::selectionChanged): Renamed the argument.

  • html/HTMLTextFormControlElement.h:
12:58 PM Changeset in webkit [163720] by mitz@apple.com
  • 1 edit in trunk/Source/ThirdParty/gtest/xcode/gtest.xcodeproj

Added project.xcworkspace to the svn:ignore property of gtest.xcodeproj.

12:10 PM Changeset in webkit [163719] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

Move TreeScope, IdTargetObserverRegistry to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127276

Reviewed by Andreas Kling.

Replace uses of OwnPtr in the TreeScope and IdTargetObserverRegistry classes with std::unique_ptr.

  • dom/IdTargetObserverRegistry.cpp:

(WebCore::IdTargetObserverRegistry::addObserver):

  • dom/IdTargetObserverRegistry.h:

(WebCore::IdTargetObserverRegistry::IdTargetObserverRegistry):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::destroyTreeScopeData):
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::labelElementForId):

  • dom/TreeScope.h:

(WebCore::TreeScope::shouldCacheLabelsByForAttribute):

12:02 PM Changeset in webkit [163718] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

Slight CTTE in PingLoader
https://bugs.webkit.org/show_bug.cgi?id=128462

Reviewed by Dan Bernstein.

PingLoader always wants a non-null frame.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::sendPings):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::continueAfterPingLoader):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::createPingLoader):
(WebCore::PingLoader::PingLoader):

  • loader/PingLoader.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestImage):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

11:58 AM Changeset in webkit [163717] by mitz@apple.com
  • 38 edits in trunk

Remove client-drawn highlights (-webkit-highlight, WebHTMLHighlighter)
https://bugs.webkit.org/show_bug.cgi?id=128456

Reviewed by Anders Carlsson.

Source/WebCore:

Updated fast/css/getComputedStyle and svg/css results.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Removed CSSPropertyWebKitHighlight case.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Ditto.

  • css/CSSPropertyNames.in: Removed -webkit-highlight.
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Removed
CSSPropertyWebKitHighlight handler.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): Removed CSSPropertyWebKitHighlight case.

  • page/Chrome.cpp: Removed customHighlightRect and paintCustomHighlight.
  • page/ChromeClient.h: Ditto.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Removed painting custom highlight.

  • rendering/InlineTextBox.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns): Removed adding overflow for custom
highlights.

  • rendering/RenderBox.cpp: Removed paintCustomHighlight.
  • rendering/RenderBox.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced): Removed painting custom highlight.

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint): Ditto.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Ditto.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint): Ditto.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint): Ditto.

  • rendering/RootInlineBox.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout): Removed highlight comparison.

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Removed initializer.
(WebCore::StyleRareInheritedData::operator==): Removed highlight comparison.

  • rendering/style/StyleRareInheritedData.h: Removed highlight member variable.

Source/WebInspectorUI:

  • UserInterface/CSSKeywordCompletions.js: Removed -webkit-highlight.

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: Removed customHighlightRect and paintCustomHighlight.
  • WebView/WebHTMLView.mm:

(-[WebHTMLViewPrivate dealloc]): Removed highlighters ivar.
(-[WebHTMLViewPrivate clear]): Ditto.

  • WebView/WebHTMLViewInternal.h: Removed declaration.
  • WebView/WebHTMLViewPrivate.h: Removed WebHTMLHighlighter protocol and method declarations.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: Removed customHighlightRect and

paintCustomHighlight.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
10:37 AM Changeset in webkit [163716] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

One more build fix fix.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):

10:35 AM Changeset in webkit [163715] by mitz@apple.com
  • 6 edits in trunk/Source

Source/WebCore: More (and more correct) iOS build fix after r163712.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):

  • page/ios/FrameIOS.mm:

(WebCore::Frame::wordsInCurrentParagraph):

Source/WebKit/mac: iOS build fix after r163712.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm:
10:06 AM Changeset in webkit [163714] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix after r163712

  • page/ios/FrameIOS.mm:

(WebCore::Frame::indexCountOfWordPrecedingSelection):
(WebCore::Frame::wordsInCurrentParagraph):

9:08 AM Changeset in webkit [163713] by zandobersek@gmail.com
  • 12 edits
    18 adds
    19 deletes in trunk/LayoutTests

Convert current MHTML tests into reftests
https://bugs.webkit.org/show_bug.cgi?id=116443

Reviewed by Andreas Kling.

Convert the current set of MHTML tests into reference tests. Reference files are copied from the *_original files
where available (with the *_original files removed) or from the source markup and code that's stored in the archive.
Both the archives and the reference files are adjusted to now dump pixel output instead of text.

  • mhtml/check_domain-expected.html: Added.
  • mhtml/check_domain-expected.txt: Removed.
  • mhtml/check_domain.mht:
  • mhtml/frame_4.html_original: Removed.
  • mhtml/multi_frames.html_original: Removed.
  • mhtml/multi_frames_binary-expected.html: Added.
  • mhtml/multi_frames_binary-expected.txt: Removed.
  • mhtml/multi_frames_binary.mht:
  • mhtml/multi_frames_ie-expected.html: Added.
  • mhtml/multi_frames_ie-expected.txt: Removed.
  • mhtml/multi_frames_ie.mht:
  • mhtml/multi_frames_unmht-expected.html: Added.
  • mhtml/multi_frames_unmht-expected.txt: Removed.
  • mhtml/multi_frames_unmht.mht:
  • mhtml/page_with_css_and_js_ie-expected.html: Copied from LayoutTests/mhtml/page_with_css_and_js.html_original.
  • mhtml/page_with_css_and_js_ie-expected.txt: Removed.
  • mhtml/page_with_css_and_js_ie.mht:
  • mhtml/page_with_css_and_js_unmht-expected.html: Renamed from LayoutTests/mhtml/page_with_css_and_js.html_original.
  • mhtml/page_with_css_and_js_unmht-expected.txt: Removed.
  • mhtml/page_with_css_and_js_unmht.mht:
  • mhtml/page_with_image.html_original: Removed.
  • mhtml/page_with_image_ie-expected.html: Added.
  • mhtml/page_with_image_ie-expected.txt: Removed.
  • mhtml/page_with_image_ie.mht:
  • mhtml/page_with_image_unmht-expected.html: Added.
  • mhtml/page_with_image_unmht-expected.txt: Removed.
  • mhtml/page_with_image_unmht.mht:
  • mhtml/resources/frame_0.html: Renamed from LayoutTests/mhtml/frame_0.html_original.
  • mhtml/resources/frame_1.html: Renamed from LayoutTests/mhtml/frame_1.html_original.
  • mhtml/resources/frame_2.html: Renamed from LayoutTests/mhtml/frame_2.html_original.
  • mhtml/resources/frame_4.html: Added.
  • mhtml/resources/hide_image.css: Added.

(#secondDiv):

  • mhtml/resources/remove_image_script.js: Added.

(onLoad):

  • mhtml/resources/style.css: Copied from LayoutTests/mhtml/shared_buffer_bug.mht.

(h1):

  • mhtml/shared_buffer_bug-expected.html: Added.
  • mhtml/shared_buffer_bug-expected.txt: Removed.
  • mhtml/shared_buffer_bug.mht:
  • mhtml/simple_page_ie-expected.html: Copied from LayoutTests/mhtml/simple_page.html_original.
  • mhtml/simple_page_ie-expected.txt: Removed.
  • mhtml/simple_page_ie.mht:
  • mhtml/simple_page_unmht-expected.html: Renamed from LayoutTests/mhtml/simple_page.html_original.
  • mhtml/simple_page_unmht-expected.txt: Removed.
  • mhtml/simple_page_unmht.mht:
8:32 AM Changeset in webkit [163712] by Darin Adler
  • 51 edits
    2 copies in trunk/Source

Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
https://bugs.webkit.org/show_bug.cgi?id=128233

Reviewed by Anders Carlsson.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp: Removed unneeded TextIterator.h include.
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling): Updated to use StringView for checkSpelling.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetSpelling): Changed to take a StringView.
(AXAttributedStringAppendText): Ditto.
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Pass StringView.

  • editing/Editor.cpp:

(WebCore::Editor::misspelledWordAtCaretOrRange): Pass StringView.
(WebCore::Editor::misspelledSelectionString): Ditto.
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Ditto.

  • editing/TextCheckingHelper.cpp:

(WebCore::findGrammaticalErrors): Renamed this function. Changed to use StringView.
(WebCore::findMisspellings): Use StringView.
(WebCore::TextCheckingHelper::findFirstMisspelling): Ditto. Also separated out assertions
that were asserting multiple things with &&.
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar): Ditto.
(WebCore::TextCheckingHelper::findFirstGrammarDetail): Ditto.
(WebCore::TextCheckingHelper::findFirstBadGrammar): Ditto.
(WebCore::TextCheckingHelper::isUngrammatical): Ditto.
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange): Ditto.
(WebCore::checkTextOfParagraph): Ditto.

  • editing/TextCheckingHelper.h: Made TextCheckingParagraph::text public. Deleted

TextCheckingParagraph::textDeprecatedCharacters. Added comments about additional
TextCheckingParagraph refinements. Changed checkTextOfParagraph to take a client
reference instead of pointer and StringView instead of characters pointer with length.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::appendTextToStringBuilder): Use data members directly,
rather than using functions, since we already checked m_textCharacters for null.
(WebCore::CharacterIterator::string): Use text() instead of characters().
(WebCore::WordAwareIterator::WordAwareIterator): Removed initialization of
m_previousText now that it's a StringView rather than a pointer.
(WebCore::WordAwareIterator::advance): Use TextIterator::text instead of
TextIterator::characters. Also added a FIXME about a fundamental problem
with the implementation of this class!
(WebCore::WordAwareIterator::length): Updated for m_previousText change.
(WebCore::WordAwareIterator::text): Replaced WordAwareIterator::characters with this.
(WebCore::SearchBuffer::append): Changed to take a StringView.
(WebCore::SearchBuffer::prependContext): Ditto.
(WebCore::SearchBuffer::isWordStartMatch): Use StringView.
(WebCore::SearchBuffer::search): Ditto.
(WebCore::findPlainText): Ditto.

  • editing/TextIterator.h: Added TextIterator::text that returns a StringView, and

renamed TextIterator::characters to TextIterator::deprecatedTextIteratorCharacters
(easy to search for in source code). Added SimplifiedBackwardsTextIterator::text
and removed SimplifiedBackwardsTextIterator::characters. Added CharacterIterator::text,
and removed CharacterIterator::characters. Added WordAwareIterator::text and removed
WorkdAwareIterator::characters. Changed WordAwareIterator data members to use StringView.

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::appendTrailingWhitespace): Use TextIterator::text instead
of TextIterator::characters.

  • editing/VisibleUnits.cpp:

(WebCore::previousBoundary): Updated to use StringView.
(WebCore::nextBoundary): Ditto.
(WebCore::startWordBoundary): Ditto.
(WebCore::startOfWord): Ditto.
(WebCore::endWordBoundary): Ditto.
(WebCore::endOfWord): Fixed formatting.
(WebCore::previousWordPositionBoundary): Updated to use StringView.
(WebCore::previousWordPosition): Fixed formatting and got rid of local variable.
(WebCore::nextWordPositionBoundary): Updated to use StringView.
(WebCore::nextWordPosition): Fixed formatting and got rid of local variable.
(WebCore::inSameLine): Fixed formatting.
(WebCore::isStartOfLine): Ditto.
(WebCore::isEndOfLine): Ditto.
(WebCore::absoluteLineDirectionPointToLocalPointInBlock): Changed to take a reference.
(WebCore::previousLinePosition): Fixed formatting chand changed to pass a reference.
(WebCore::nextLinePosition): Ditto.
(WebCore::startSentenceBoundary): Updated to use StringView and got rid of a local.
(WebCore::startOfSentence): Fixed formatting.
(WebCore::endSentenceBoundary): Updated to use StringView and got rid of a local.
(WebCore::endOfSentence): Fixed formatting.
(WebCore::previousSentencePositionBoundary): Updated to use StringView and got rid of
a local.
(WebCore::previousSentencePosition): Ditto.
(WebCore::nextSentencePositionBoundary): Ditto.
(WebCore::nextSentencePosition): Fixed formatting.
(WebCore::endOfParagraph): Ditto.
(WebCore::inSameParagraph): Ditto.
(WebCore::isStartOfParagraph): Ditto.
(WebCore::isEndOfParagraph): Ditto.
(WebCore::inSameBlock): Ditto.
(WebCore::isStartOfBlock): Ditto.
(WebCore::isEndOfBlock): Ditto.
(WebCore::startOfDocument): Ditto.
(WebCore::endOfDocument): Ditto.
(WebCore::inSameDocument): Ditto.
(WebCore::isStartOfDocument): Ditto.
(WebCore::isEndOfDocument): Ditto.
(WebCore::isEndOfEditableOrNonEditableContent): Ditto.

  • loader/EmptyClients.h: Use StringView.
  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]): Use StringView.

  • platform/text/TextBoundaries.cpp:

(WebCore::endOfFirstWordBoundaryContext): Use StringView and unsigned.
(WebCore::startOfLastWordBoundaryContext): Ditto.

  • platform/text/TextBoundaries.h: Change interfaces to use StringView,

and in some cases, unsigned instead of int. All call sites were better off
with unsigned.

  • platform/text/TextCheckerClient.h: Use StringView.
  • platform/text/mac/TextBoundaries.mm: Changed conditionals to say

USE(APPKIT) instead of PLATFORM(IOS), since that's the real issue.
(WebCore::isSkipCharacter): Tweaked formatting.
(WebCore::isWhitespaceCharacter): Ditto.
(WebCore::isWordDelimitingCharacter): Ditto, also removed local variable.
(WebCore::isSymbolCharacter): Ditto.
(WebCore::tokenizerForString): Ditto.
(WebCore::findSimpleWordBoundary): Use StringView. Also changed to mostly
use unsigned instead of int.
(WebCore::findComplexWordBoundary): Use StringView. Also restructured to
be much more readable, with early returns and such.
(WebCore::findWordBoundary): Use StringView and unsigned.
(WebCore::findEndWordBoundary): Removed redudant copy of the findWordBoundary
function and changed this to just call findWordBoundary. The reason this
function exists is to optimize this case for some non-Mac, non-iOS platforms.
We can always do that for Mac and/or iOS later if we like.
(WebCore::findNextWordFromIndex): Use StringView. Also use wordBreakIterator
instead of using UBreakIterator directly so we get a cached iterator instead
of creating and destroying a new one each time this function is called.

  • bindings/objc/DOMUIKitExtensions.mm: Removed unneeded includes.
  • dom/Element.cpp: Ditto.
  • dom/PositionIterator.cpp: Ditto.
  • editing/ApplyBlockElementCommand.cpp: Ditto.
  • editing/IndentOutdentCommand.cpp: Ditto.
  • editing/InsertListCommand.cpp: Ditto.
  • editing/markup.cpp: Ditto.
  • html/HTMLElement.cpp: Ditto.
  • html/HTMLTextAreaElement.cpp: Ditto.
  • page/Frame.cpp: Ditto.
  • rendering/RenderTextControl.cpp: Ditto.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::checkSpellingOfString): Use StringView.
(WebCore::EditorClientEfl::checkGrammarOfString): Ditto.

  • WebCoreSupport/EditorClientEfl.h: Ditto.

Source/WebKit/gtk:

  • WebCoreSupport/TextCheckerClientGtk.cpp:

(WebKit::TextCheckerClientGtk::checkSpellingOfString): Use StringView.
(WebKit::TextCheckerClientGtk::checkGrammarOfString): Ditto.

  • WebCoreSupport/TextCheckerClientGtk.h: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h: Made most data members private. Moved inlines

for iOS out of the class definition. Fixed formatting. Added missing virtual keyword.
Changed interfaces to use StringView.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::checkTextOfParagraph): Use the new StringView::createNSStringWithoutCopying
function instead of a similar function that was local in this file.
(WebEditorClient::ignoreWordInSpellDocument): Tweaked formatting.
(WebEditorClient::checkSpellingOfString): Changed to take a StringView.
(WebEditorClient::checkGrammarOfString): Ditto.

  • WebView/WebTextIterator.mm:

(-[WebTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.
(-[WebTextIterator currentText]): Convert a the text to an NSString with TextIterator::text
instead of with TextIterator::characters/length.

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::checkSpellingOfString): Use StringView.
(WebEditorClient::checkGrammarOfString): Ditto.

  • WebCoreSupport/WebEditorClient.h: Ditto.

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::checkSpellingOfString): Use StringView.
(WebKit::EditorClientWinCE::checkGrammarOfString): Ditto.

  • WebCoreSupport/EditorClientWinCE.h: Ditto.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.mm:

(-[WKDOMTextIterator currentTextPointer]): Call TextIterator::deprecatedTextIteratorCharacters.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::checkSpellingOfString): Use StringView.
(WebKit::WebEditorClient::checkGrammarOfString): Ditto.

  • WebProcess/WebCoreSupport/WebEditorClient.h: Ditto.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj: Added new source files.
  • wtf/text/StringView.h: Added operator[], createCFStringWithoutCopying, and

createNSStringWithoutCopying.

  • wtf/text/cf/StringViewCF.cpp:

(WTF::StringView::createCFStringWithoutCopying): Added.

  • wtf/text/mac/StringViewObjC.mm:

(WTF::StringView::createNSString): Added.
(WTF::StringView::createNSStringWithoutCopying): Added.

8:14 AM Changeset in webkit [163711] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Add stdlib include file to fix ImageDiff build with libc++
https://bugs.webkit.org/show_bug.cgi?id=128454

Patch by Rajaram Gaunker <zimbabao@gmail.com> on 2014-02-08
Reviewed by Darin Adler.

  • ImageDiff/gtk/ImageDiff.cpp:
2:33 AM Changeset in webkit [163710] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<https://webkit.org/b/128452> Don't duplicate the list of input files for postprocess-headers.sh

Reviewed by Dan Bernstein.

  • postprocess-headers.sh: Pull the list of headers to process out of the environment.
2:03 AM Changeset in webkit [163709] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the iOS build.

  • API/WebKitAvailability.h: Skip the workarounds specific to OS X when we're building for iOS.
1:26 AM Changeset in webkit [163708] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Build break in WebKitWebViewBase.cpp::webkitWebViewBaseCreateWebPage
https://bugs.webkit.org/show_bug.cgi?id=128449

Patch by Piotr Grad <p.grad@samsung.com> on 2014-02-08
Reviewed by Carlos Garcia Campos.

Parameter passed to context->createWebPage was inproper.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreateWebPage):

1:01 AM Changeset in webkit [163707] by mrowe@apple.com
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

<https://webkit.org/b/128448> Fix use of availability macros on recently-added APIs

Reviewed by Dan Bernstein.

  • API/JSContext.h: Remove some #ifs.
  • API/JSManagedValue.h: Ditto.
  • API/WebKitAvailability.h: #define the macros that availability macros mentioning

newer OS X versions would expand to when building on older OS versions.

  • JavaScriptCore.xcodeproj/project.pbxproj: Call the new postprocess-headers.sh.
  • postprocess-headers.sh: Extracted from the Xcode project. Updated to remove content

from headers based on the MAC_OS_X_VERSION_MIN_REQUIRED macro, and to
process WebKitAvailability.h.

12:53 AM Changeset in webkit [163706] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove two unused function declarations.

Scrub "highQualityRepaintTimerFired" declarations from RenderImage
and RenderBoxModelObject since they're not actually defined.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderImage.h:
12:50 AM Changeset in webkit [163705] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CTTE: SVGTRefTargetEventListener is always owned by SVGTRefElement.
<https://webkit.org/b/128432>

Tighten up the relationship between SVGTRefElement and its internal
event listener helper by storing the listener in a Ref, and making
the listeners backpointer to the element be a reference.

Reviewed by Anders Carlsson.

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefTargetEventListener::create):
(WebCore::SVGTRefTargetEventListener::SVGTRefTargetEventListener):
(WebCore::SVGTRefTargetEventListener::operator==):
(WebCore::SVGTRefTargetEventListener::handleEvent):
(WebCore::SVGTRefElement::SVGTRefElement):

  • svg/SVGTRefElement.h:
12:48 AM Changeset in webkit [163704] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Devirtualize RenderBlockFlowRareData.
<https://webkit.org/b/128427>

This class had a virtual destructor for no reason. Removing it
shrinks RenderBlockFlowRareData by 8 bytes.

Reviewed by Anders Carlsson.

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::~RenderBlockFlowRareData):

12:45 AM Changeset in webkit [163703] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Use renderer iterators in two more places.
<https://webkit.org/b/128371>

Reviewed by Antti Koivisto.

  • dom/Position.cpp:

(WebCore::Position::primaryDirection):

Use lineageOfType instead of walking the parent chain.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::insertOnlyThisLayer):

Use childrenOfType instead of walking the children.

12:42 AM Changeset in webkit [163702] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

Font size-related preference values should be CGFloats backed by doubles
https://bugs.webkit.org/show_bug.cgi?id=128445

Reviewed by Filip Pizlo.

  • Shared/WebPreferencesStore.h: Changed minimumFontSize, minimumLogicalFontSize,

defaultFontSize, and defaultFixedFontSize into double-value preferences.

  • UIProcess/API/Cocoa/WKPreferences.h: Changed minimumFontSize into CGFloat.
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences minimumFontSize]): Changed return type.
(-[WKPreferences setMinimumFontSize:]): Changed parameter type.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Changed to use double getters.

12:36 AM Changeset in webkit [163701] by akling@apple.com
  • 5 edits in trunk

Remove unused ENABLE(REPAINT_THROTTLING) flag.
<https://webkit.org/b/128329>

Reviewed by Antti Koivisto.

.:

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WTF:

  • wtf/FeatureDefines.h:
12:27 AM Changeset in webkit [163700] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSLock should not "restore" VM stack values if it did not re-grab locks.
<https://webkit.org/b/128447>

Reviewed by Geoffrey Garen.

In the existing code, if DropAllLocks is instantiate with DontAlwaysDropLocks
in a thread that does not own the JSLock, then a bug will manifest where:

  1. The DropAllLocks constructor will save the VM's stackPointerAtEntry, lastStackTop, and reservedZoneSize even though it will not drop the JSLock.
  2. The DropAllLocks destructor will restore those 3 values to the VM even though the JSLock will not grab its internal lock.

The former only causes busy work but does not impact correctness. The latter
however, will corrupt those 3 VM values which belong to the thread that
actually owns the JSLock.

The fix is to only save the values when the JSLock will actually drop its
internal lock, and only restore the values if it did re-grab the internal lock.

  • runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):

  • Moved the saving of VM stack values to dropAllLocks() and dropAllLocksUnconditionally().

(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • Moved the restoring of VM stack values to grabAllLocks().
12:26 AM Changeset in webkit [163699] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser: Matched words of a searched text are not highlighted after reopening search bar
https://bugs.webkit.org/show_bug.cgi?id=128380

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-08
Reviewed by Carlos Garcia Campos.

When open the search bar, perform last search if there is any.

  • MiniBrowser/gtk/BrowserSearchBar.c:

(browser_search_bar_open):

12:25 AM Changeset in webkit [163698] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] Make process model names properly meaningful
https://bugs.webkit.org/show_bug.cgi?id=128389

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-02-08
Reviewed by Carlos Garcia Campos.

The name WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
is misleading because there are situations in which web views may
share the same web process even when multi-process mode is enabled;
for example when opening a related view and both interact using JS.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_process_model):
(webkit_web_context_get_process_model):
Update names of WebKitProcessModel enum values.

  • UIProcess/API/gtk/WebKitWebContext.h:

Ditto.

Tools:

  • MiniBrowser/gtk/main.c:

(main):
Update usage of WebKitProcessModel enum values.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(beforeAll):
Ditto.

12:24 AM Changeset in webkit [163697] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] build-webkit script always generate-gtk-doc even if '--disable-gtk-doc' param is passed
https://bugs.webkit.org/show_bug.cgi?id=128376

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-08
Reviewed by Carlos Garcia Campos.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

12:21 AM Changeset in webkit [163696] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Build break in WebKitSettings
https://bugs.webkit.org/show_bug.cgi?id=128446

Patch by Piotr Grad <p.grad@samsung.com> on 2014-02-08
Reviewed by Ryosuke Niwa.

Argument for WebPreferences::create was missing

  • UIProcess/API/gtk/WebKitSettings.cpp:

(_WebKitSettingsPrivate::_WebKitSettingsPrivate):

Feb 7, 2014:

10:56 PM Changeset in webkit [163695] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Don't throw away code if there is code on the worklists
https://bugs.webkit.org/show_bug.cgi?id=128443

Reviewed by Joseph Pecoraro.

If we throw away compiled code and there is code currently being JITed then the JIT
will get confused after it resumes: it will see a code block that had claimed to belong
to an executable except that it doesn't belong to any executables anymore.

  • dfg/DFGWorklist.h:

(JSC::DFG::Worklist::isActive):

  • heap/Heap.cpp:

(JSC::Heap::deleteAllCompiledCode):

9:59 PM Changeset in webkit [163694] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed EFL WebKit2 build fix after r163671.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView): Use WebPageConfiguration in creating WebPage.

9:33 PM Changeset in webkit [163693] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[ASan] Use new/delete in PODFreeListArena
<http://webkit.org/b/128437>

Reviewed by Oliver Hunt.

  • platform/PODFreeListArena.h:

(WebCore::PODFreeListArena::allocateObject): Use new when
ADDRESS_SANITIZER is defined.
(WebCore::PODFreeListArena::freeObject): Use delete when
ADDRESS_SANITIZER is defined.

9:27 PM Changeset in webkit [163692] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Merge updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance
https://bugs.webkit.org/show_bug.cgi?id=128439

Reviewed by Anders Carlsson.

FrameSelection::selectAll had a superfluous call to updateSelectionCachesIfSelectionIsInsideTextFormControl
because it wasn't setting UserTriggered option to avoid revealing selection.

Call setSelection with UserTriggered and recently added DoNotRevealSelection option and merge
updateSelectionCachesIfSelectionIsInsideTextFormControl into setSelectionWithoutUpdatingAppearance.

Also rename local variables in setSelectionWithoutUpdatingAppearance, newSelection to
newSelectionPossiblyWithoutDirection and s to newSelection so that they're self explanatory.

In addition, we now update the input element's selection caches before calling
selectFrameElementInParentIfFullySelected but this should be fine because selection cannot simultaneously
select the entire document and be inside a text form control.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::selectAll):

9:06 PM Changeset in webkit [163691] by fpizlo@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

GC should safepoint the DFG worklist in a smarter way rather than just waiting for everything to complete
https://bugs.webkit.org/show_bug.cgi?id=128297

Reviewed by Oliver Hunt.

This makes DFG worklist threads have a rightToRun lock that gives them the ability to
be safepointed by the GC in much the same way as you'd expect from a fully
multithreaded VM.

The idea is that the worklist threads's roots are the DFG::Plan. They only touch those
roots when holding the rightToRun lock. They currently grab that lock to run the
compiler, but relinquish it when accessing - and waiting on - the worklist.

  • bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):

  • dfg/DFGCompilationKey.cpp:

(JSC::DFG::CompilationKey::visitChildren):

  • dfg/DFGCompilationKey.h:
  • dfg/DFGDesiredStructureChains.cpp:

(JSC::DFG::DesiredStructureChains::visitChildren):

  • dfg/DFGDesiredStructureChains.h:
  • dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::visitChildren):
(JSC::DFG::DesiredTransitions::visitChildren):

  • dfg/DFGDesiredTransitions.h:
  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::visitChildren):

  • dfg/DFGDesiredWeakReferences.h:
  • dfg/DFGDesiredWriteBarriers.cpp:

(JSC::DFG::DesiredWriteBarrier::visitChildren):
(JSC::DFG::DesiredWriteBarriers::visitChildren):

  • dfg/DFGDesiredWriteBarriers.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::visitChildren):

  • dfg/DFGPlan.h:
  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::suspendAllThreads):
(JSC::DFG::Worklist::resumeAllThreads):
(JSC::DFG::Worklist::visitChildren):
(JSC::DFG::Worklist::runThread):
(JSC::DFG::Worklist::threadFunction):

  • dfg/DFGWorklist.h:

(JSC::DFG::numberOfWorklists):
(JSC::DFG::worklistForIndexOrNull):

  • heap/CodeBlockSet.h:
  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::collect):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::visitChildren):

  • runtime/IntendedStructureChain.h:
  • runtime/VM.cpp:

(JSC::VM::~VM):
(JSC::VM::prepareToDiscardCode):

7:54 PM Changeset in webkit [163690] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

EFL build fix attempt after r163662.

  • Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::encodeIDBKey):

7:50 PM Changeset in webkit [163689] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

FrameSelection's destructor shouldn't notify accessibility
https://bugs.webkit.org/show_bug.cgi?id=128421

Reviewed by Benjamin Poulain.

Extracted setSelectionWithoutUpdatingAppearance out of setSelection and called it in prepareForDestruction
instead of setting DoNotUpdateAppearance option. This new function doesn't reveal selection or notify
accessibility code in addition to not updating appearance.

Note that all implementations of notifyAccessibilityForSelectionChange in FrameSelectionAtk.cpp and
FrameSelectionMac.mm exit early when the selection type is not caret or either start or end is null,
which is already the case inside FrameSelection's destructor. In addition, revealSelection is never called
when selection change was not triggered by user so there should be no behavioral change from this patch.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::prepareForDestruction):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange): Added the trivial implementation in the case
accessibility is disabled to tidy up call sites.

7:11 PM Changeset in webkit [163688] by rniwa@webkit.org
  • 61 adds in trunk/Websites/perf.webkit.org

Merge database-common.js and utility.js into run-tests.js.

Reviewed by Matthew Hanson.

Now that run-tests is the only node.js script, merged database-common.js and utility.js into it.
Also moved init-database.sql out of the database directory and removed the directory entirely.

  • database: Removed.
  • database/database-common.js: Removed.
  • database/utility.js: Removed.
  • init-database.sql: Moved from database/init-database.sql.
  • run-tests.js:

(connect): Moved from database-common.js.
(pathToDatabseSQL): Extracted from pathToLocalScript.
(pathToTests): Moved from database-common.js.
(config): Ditto.
(TaskQueue): Ditto.
(SerializedTaskQueue): Ditto.
(main):
(initializeDatabase):
(TestEnvironment.it):
(TestEnvironment.queryAndFetchAll):
(sendHttpRequest):

7:11 PM Changeset in webkit [163687] by mrobinson@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for the GTK+ CMake build

  • PlatformGTK.cmake: VTTCue.idl was unintentionally added to the list of GObject DOM bindings

output files. Remove it.

7:01 PM Changeset in webkit [163686] by krit@webkit.org
  • 4 edits in trunk

Per CSSOM, computed rect() function values must be comma separated
https://bugs.webkit.org/show_bug.cgi?id=128401

Reviewed by Simon Fraser.

Updated tests.

  • css/Rect.h:

(WebCore::Rect::generateCSSString):

6:52 PM Changeset in webkit [163685] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unify JSLock implementation for iOS and non-iOS ports.
<https://webkit.org/b/128409>

Reviewed by Michael Saboff.

The iOS and non-iOS implementations of dropAllLocks(),
dropAllLocksUnconditionally(), and grabAllLocks() effectively do the
same work. The main difference is that the iOS implementation acquires
the JSLock spin lock in the DropAllLocks class while the other ports
acquire it when it calls JSLock::lock() and unlock().

The other difference is that the iOS implementation will only increment
m_locksDropDepth if it actually drops locks, whereas other ports will
increment it unconditionally. Analogously, iOS decrements the depth only
when needed while other ports will decrement it unconditionally when
re-grabbing locks.

We can unify the 2 implementations by having both use the iOS
implementation for a start.

  • runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):
(JSC::JSLock::grabAllLocks):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

6:51 PM Changeset in webkit [163684] by barraclough@apple.com
  • 4 edits in trunk/Source/WebKit2

Add better comments to code that boosts the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=128431

Rubber stamped by Tim Horton

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:

(WebKit::XPCServiceEventHandler):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):

6:42 PM Changeset in webkit [163683] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):

6:39 PM Changeset in webkit [163682] by zoltan@webkit.org
  • 2 edits
    2 adds in trunk/PerformanceTests

[CSS Shapes] Add initial performance tests for inset shape
https://bugs.webkit.org/show_bug.cgi?id=128378

Reviewed by Ryosuke Niwa.

  • Layout/Shapes/ShapeOutsideContentBox.html: Move js to shapes.js.
  • Layout/Shapes/ShapeOutsideInset.html: Added.
  • Layout/Shapes/resources/shapes.js: Added.

(.):

6:38 PM Changeset in webkit [163681] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Pass the preferences through from the WKWebViewConfiguration object
https://bugs.webkit.org/show_bug.cgi?id=128430

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKPreferences.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
Don't return nil if [super init] returns a valid object.

(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):
Change this property to be unsigned.

  • UIProcess/API/Cocoa/WKPreferencesInternal.h:

Use @package.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
Set up a WebKit::WebPageConfiguration and use the new -[WKView initWithFrame:context:configuration:] method.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
Set the preferences.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:context:configuration:]):
Add a new initializer that takes a WebContext and a WebPageConfiguration.

(-[WKView _registerDraggedTypes]):
This shouldn't be in the private category.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
Call the new initializer.

  • UIProcess/API/mac/WKViewInternal.h:
6:28 PM Changeset in webkit [163680] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the WebKit2 build after r163671.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

6:25 PM Changeset in webkit [163679] by barraclough@apple.com
  • 16 edits in trunk

Remove isInitialState flag from Page::setViewState
https://bugs.webkit.org/show_bug.cgi?id=128428

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
    • removed isInitialState.
  • page/Page.cpp:

(WebCore::Page::setViewState):

  • removed isInitialState.

(WebCore::Page::setIsVisible):

  • removed isInitialState.

(WebCore::Page::setIsVisibleInternal):

  • removed isInitialState.
  • page/Page.h:
    • removed isInitialState.

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(ewk_view_visibility_state_set):

  • don't pass isInitialState to setViewState.

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setPageVisibility):

  • don't pass isInitialState to setViewState.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _updateVisibilityState]):
(-[WebView _setIsVisible:]):
(-[WebView _setVisibilityState:isInitialState:]):
(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

  • don't pass isInitialState to setViewState.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • don't pass isInitialState to setViewState.

(WebKit::WebPage::reinitializeWebPage):

  • if the viewState changes this should fire a visibility event.

(WebKit::WebPage::setViewState):

  • merged with setViewStateInternal.
  • WebProcess/WebPage/WebPage.h:
    • removed setViewStateInternal.

LayoutTests:

  • fast/events/page-visibility-iframe-delete-test.html:
  • fast/events/page-visibility-iframe-move-test.html:
    • resetPageVisibility will now cause additional visibiliy events to fire; clean up the event listeners to avoid this affecting the test results.
6:23 PM Changeset in webkit [163678] by Lucas Forschler
  • 13 edits in tags/Safari-538.16.3

Merged r163674.

6:19 PM Changeset in webkit [163677] by Simon Fraser
  • 6 edits in trunk/Source

Encode requestedScrollPosition on ScrollingStateScrollingNodes to send to the UI process
https://bugs.webkit.org/show_bug.cgi?id=128416

Source/WebCore:

Reviewed by Tim Horton.

Change requestedScrollPosition() to be a FloatPoint, and export
ScrollingStateScrollingNode::setRequestedScrollPosition(WebCore::FloatPoint const&, bool)
for WK2.

  • WebCore.exp.in:
  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):

  • page/scrolling/ScrollingStateScrollingNode.h:

Source/WebKit2:

Reviewed by Tim Horton.

Encode and decode requestedScrollPosition() and requestedScrollPositionRepresentsProgrammaticScroll(),
which can't use the macros because the setter takes both arguments.

The UI process needs this to notice programmatic scrolls.

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):

6:19 PM Changeset in webkit [163676] by Simon Fraser
  • 7 edits in trunk/Source/WebKit2

Add typesafe casts for DrawingAreaProxy classes
https://bugs.webkit.org/show_bug.cgi?id=128419

Reviewed by Andreas Kling.

Add typesafe casts, and use one in RemoteScrollingCoordinatorProxy::layerTreeHost().

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::layerTreeHost):

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
6:12 PM Changeset in webkit [163675] by Beth Dakin
  • 12 edits in trunk

Should get rid of TileController's CoverageForSlowScrolling mode
https://bugs.webkit.org/show_bug.cgi?id=128339

Reviewed by Simon Fraser.

Source/WebCore:

This patch gets rid of CoverageForSlowScrolling in the TileController. It also
makes sure that margin tiles are properly invalidated on pages with slow repaint
objects that cause slow scrolling.

When we invalidate because of slow scrolling, don’t clip the update rect to the
layer bounds.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsSlowPath):

Call new RenderObject paint function repaintSlowRepaintObject() instead of the
more-generic repaint().
(WebCore::FrameView::repaintSlowRepaintObjects):

Remove CoverageForSlowScrolling.

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):

  • rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):

Handle repainting a slow repaint object. Don’t clip when we shouldn’t, use the
RenderView’s backgroundRect as a repaintRect when this is the root background
since that will take the extended background rect into consideration.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintSlowRepaintObject):

  • rendering/RenderObject.h:

LayoutTests:

Slow scrolling no longer creates tiles of a different size.

  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
6:11 PM Changeset in webkit [163674] by fpizlo@apple.com
  • 13 edits in trunk

More FTL build scaffolding
https://bugs.webkit.org/show_bug.cgi?id=128330

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • llvm/library/LLVMAnchor.cpp:

Source/WebCore:

The FTL already has tests.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/Platform.h:

Tools:

  • Scripts/copy-webkitlibraries-to-product-directory:
6:02 PM Changeset in webkit [163673] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Move allowsBackForwardNavigationGestures back to private because apparently our build systems are broken.

  • UIProcess/API/Cocoa/WKView.h:
  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

6:01 PM Changeset in webkit [163672] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

iOS port needs to clear VM::stackPointerAtVMEntry when it drops locks.
<https://webkit.org/b/128424>

Reviewed by Geoffrey Garen.

The iOS code path for dropping locks differ from the non-iOS code path
in that it (iOS) does not clear m_vm->stackPointerAtVMEntry nor reset the
VM stack limit. This is now fixed by copying that snippit from
JSLock::unlock().

  • runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::dropAllLocksUnconditionally):

5:57 PM Changeset in webkit [163671] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Simplify web page creation
https://bugs.webkit.org/show_bug.cgi?id=128425

Reviewed by Andreas Kling.

Add a WebPageConfiguration class and stick the page group, preferences, session etc there
instead of adding more and more parameters to the WebPageProxy constructor.

Make WebContext::createWebPage fill in the missing pieces in the WebPageConfiguration object.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
5:49 PM Changeset in webkit [163670] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Touch Minibrowser for a hopeful build fix.

  • MiniBrowser/mac/WK2BrowserWindowController.m:
5:25 PM Changeset in webkit [163669] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix. Wrong section of the file.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):

5:10 PM Changeset in webkit [163668] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] The WebPageProxy's copy of pageScaleFactor is not update when the scale is changed from the viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=128415

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):
The scale needs to be updated through WebPage::scalePage().

5:09 PM Changeset in webkit [163667] by ap@apple.com
  • 3 edits in trunk/Source/WebCore

Remove some unused functions from SerializedScriptValue
https://bugs.webkit.org/show_bug.cgi?id=128407

Reviewed by Anders Carlsson.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):

  • bindings/js/SerializedScriptValue.h:
4:58 PM Changeset in webkit [163666] by timothy_horton@apple.com
  • 18 edits
    1 add in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Support for iOS
https://bugs.webkit.org/show_bug.cgi?id=128363
<rdar://problem/15194194>

Reviewed by Anders Carlsson.

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::renderTreeSize):
(WebKit::RemoteLayerTreeTransaction::setRenderTreeSize):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Send the render tree size along with remote layer tree commits,
so that we can act upon it (to hide snapshots) in the UI process
in sync with layer commits.

  • UIProcess/API/Cocoa/WKViewPrivate.h:

We want allowsBackForwardNavigationGestures for both platforms.

  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::takeViewSnapshot):

  • UIProcess/API/ios/WKContentView.h:
  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _takeViewSnapshot]):

  • UIProcess/API/ios/WKContentViewInternal.h:

Plumb snapshotting through to WKViewIOS.

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView allowsBackForwardNavigationGestures]):
Create/destroy the gesture controller when we turn on/off back-forward swipe.
Tell WebPageProxy to save snapshots if swipe is enabled.

(-[WKView contentView:didCommitLayerTree:]):
Forward the current transaction's render tree size to ViewGestureController.

(-[WKView takeViewSnapshotForContentView:]):
Snapshot the view. This is not the best SPI to use, we should consider
using one of those which returns an IOSurface and plumbing it through
to ViewSnapshotStore, but all of our PageClient abstraction makes that annoying.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::recordNavigationSnapshot):
Record snapshots on iOS as well.

  • UIProcess/ios/ViewGestureControllerIOS.mm: Added.

(-[WKSwipeInteractiveTransitionDelegate initWithViewGestureController:WebKit::swipingView:]):
(-[WKSwipeInteractiveTransitionDelegate WebKit::ViewGestureController::directionForTransition:]):
(-[WKSwipeInteractiveTransitionDelegate startInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate shouldBeginInteractiveTransition:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKSwipeInteractiveTransitionDelegate interactiveTransition:gestureRecognizer:shouldReceiveTouch:]):
(-[WKSwipeInteractiveTransitionDelegate gestureRecognizerForInteractiveTransition:WithTarget:action:]):
(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::~ViewGestureController):
(WebKit::ViewGestureController::installSwipeHandler):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):
(WebKit::ViewGestureController::endSwipeGesture):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
(WebKit::ViewGestureController::removeSwipeSnapshot):

  • UIProcess/mac/ViewGestureController.h:

Add iOS-specific methods, and don't include all of the Mac-specific code.
We can move towards sharing more logic in the future.

  • UIProcess/mac/ViewGestureController.messages.in:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):

  • UIProcess/mac/ViewSnapshotStore.h:
  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):
(WebKit::ViewSnapshotStore::snapshotAndRenderTreeSize):
Make ViewSnapshotStore build/work without IOSurface.

  • WebKit2.xcodeproj/project.pbxproj:
4:55 PM Changeset in webkit [163665] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed superflous JSLock::entryStackPointer field.
<https://webkit.org/b/128413>

Reviewed by Geoffrey Garen.

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):

  • runtime/JSLock.h:
4:46 PM Changeset in webkit [163664] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Revert workaround committed in http://trac.webkit.org/r163595.
<https://webkit.org/b/128408>

Reviewed by Geoffrey Garen.

Now that we have fixed the bugs in JSLock's stack limit adjusments
in https://bugs.webkit.org/show_bug.cgi?id=128406, we can revert the
workaround in r163595.

  • API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):

  • API/tests/testapi.js:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):

  • runtime/VM.h:
4:37 PM Changeset in webkit [163663] by andersca@apple.com
  • 6 edits
    1 copy in trunk/Source/WebKit2

Implement more of WKPreferences
https://bugs.webkit.org/show_bug.cgi?id=128411

Reviewed by Tim Horton.

Give WKPreferences an underlying WebKit::WebPreferences object, add a minimumFontSize preference
and make sure that WKWebView's initializer creates a WKPreferences object if the configuration doesn't specify one.

  • UIProcess/API/Cocoa/WKPreferences.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
(-[WKPreferences minimumFontSize]):
(-[WKPreferences setMinimumFontSize:]):

  • UIProcess/API/Cocoa/WKPreferencesInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKPreferences.mm.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/WebPageProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
4:30 PM Changeset in webkit [163662] by beidson@apple.com
  • 21 edits in trunk

IDB: Some Mozilla cursor mutation tests fail
<rdar://problem/16011680> and https://bugs.webkit.org/show_bug.cgi?id=128374

Reviewed by Sam Weinig.

Source/WebCore:

Tested by:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html
storage/indexeddb/mozilla/cursor-mutation.html

The previous comment about LevelDB was wrong.
Apparently calling onSuccess() with a null SharedBuffer means the cursor reached the end.
Update to distinguish between an error and reaching the end:

  • Modules/indexeddb/IDBCursorBackendOperations.cpp:

(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

Add a new IDBKey type - Maximum - To be used in comparisons between keys.
This will allow the DatabaseProcess to operate on the range of all keys:

  • Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::compare):

  • Modules/indexeddb/IDBKey.h:
  • Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::IDBKeyData):
(WebCore::IDBKeyData::maybeCreateIDBKey):
(WebCore::IDBKeyData::isolatedCopy):
(WebCore::IDBKeyData::encode):
(WebCore::IDBKeyData::decode):
(WebCore::IDBKeyData::compare):
(WebCore::IDBKeyData::loggingString):

  • Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::minimum):
(WebCore::IDBKeyData::maximum):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::idbKeyToJSValue):

Remove an unused callback:

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBRequest.h:

Source/WebKit2:

After a SQLite statement is prepared, stepping it will not pick up any subsequent changes
to the object store.

By keeping track of the current record we’re looking at in the object store and being told
that the object store changed its contents, we can reset the statement to pick up where it
left off but with the new object store contents.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::putRecordInBackingStore): Tell the backing store to notify

its cursors that the object store changed its records.

(WebKit::UniqueIDBDatabase::deleteRangeInBackingStore): Ditto.

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::notifyCursorsOfChanges): Tell the transaction

to notify its cursors that the object store changed its records.

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:

(WebKit::SQLiteIDBTransaction::notifyCursorsOfChanges): Tell the relevant cursors that their

object store changed its records.

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.h:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::SQLiteIDBCursor):
(WebKit::getIndexStatement): All statements now have a lower and upper range. By default we bind

IDBKey::Minimum to the lower range and IDBKey::Maximum to the upper range.

(WebKit::getObjectStoreStatement): Ditto.
(WebKit::SQLiteIDBCursor::establishStatement):
(WebKit::SQLiteIDBCursor::createSQLiteStatement):
(WebKit::SQLiteIDBCursor::objectStoreRecordsChanged): Set the flag indicating the statement

needs to be reset and rebound.

(WebKit::SQLiteIDBCursor::resetAndRebindStatement):
(WebKit::SQLiteIDBCursor::bindArguments): Factored out to be shared between statement prepare()

and statement reset().

(WebKit::SQLiteIDBCursor::advance):
(WebKit::SQLiteIDBCursor::advanceOnce): If the statement needs to be reset, do so before advancing it.
(WebKit::SQLiteIDBCursor::internalAdvanceOnce): In a few cases, tell advanceOnce that it needs to

try again because it is on a missing record or is repeating a record.

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

(WebKit::SQLiteIDBCursor::objectStoreID):

Make sure Maximum and Minimum keys are never sent across IPC, as that doesn’t make sense:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<IDBKeyData>::encode):
(IPC::ArgumentCoder<IDBKeyData>::decode):

LayoutTests:

  • platform/mac-wk2/TestExpectations: Add two tests that now pass.
4:24 PM Changeset in webkit [163661] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix bug in stack limit adjustments in JSLock.
<https://webkit.org/b/128406>

Reviewed by Geoffrey Garen.

  1. JSLock::unlock() was only clearing the VM::stackPointerAtEntry when m_vm->stackPointerAtVMEntry == entryStackPointer. FYI, entryStackPointer is a field in JSLock.

When DropAllLocks::~DropAllLocks() will call JSLock::grabAllLocks()
to relock the JSLock, JSLock::grabAllLocks() will set a new
entryStackPointer value. Thereafter, DropAllLocks::~DropAllLocks() will
restore the saved VM::stackPointerAtEntry, which will now defer from
the JSLock's entryStackPointer value.

It turns out that when m_vm->stackPointerAtVMEntry was initialized,
it was set to whatever value entryStackPointer is set to. At no time
do we ever expect the 2 values to differ. The only time it differs is
when this bug manifests.

The fix is to remove the entryStackPointer field in JSLock and its uses
altogether.

  1. DropAllLocks was unconditionally clearing VM::stackPointerAtEntry in its constructor instead of letting JSLock::unlock() do the clearing.

However, DropAllLocks will not actually drop locks if it isn't required
to (e.g. when alwaysDropLocks is DontAlwaysDropLocks), and when we've
already drop locks once (i.e. JSLock::m_lockDropDepth is not 0).

We should not have cleared VM::stackPointerAtEntry here if we don't
actually drop the locks.

  • runtime/JSLock.cpp:

(JSC::JSLock::unlock):
(JSC::JSLock::DropAllLocks::DropAllLocks):

4:19 PM Changeset in webkit [163660] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

iOS build fix.

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initializeLookupTable]):
(-[WebElementDictionary _image]):
(-[WebElementDictionary _imageRect]):

4:16 PM Changeset in webkit [163659] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

CGContextGetUserSpaceToDeviceSpaceTransform returns the wrong value on Windows.
https://bugs.webkit.org/show_bug.cgi?id=128395.

Rubberstamped by Zalan Bujtas.

The call essentially returns 0 and causes an assertion failure when running many layout tests.

  • platform/graphics/cg/GraphicsContextCG.cpp: Don't make the call on Windows. We default to 1.

(WebCore::GraphicsContext::platformInit):

4:07 PM Changeset in webkit [163658] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix.

  • platform/PlatformKeyboardEvent.h: Fixed a typo.
3:37 PM Changeset in webkit [163657] by mitz@apple.com
  • 104 edits in trunk/Source/WebCore

Stop using PLATFORM(MAC) in WebCore/platform except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128404

Reviewed by Anders Carlsson.

  • Configurations/WebCore.xcconfig: Removed KeyEventMac.mm from

EXCLUDED_SOURCE_FILE_NAMES_iphoneos, because that file contains !PLATFORM(IOS) guards.
Removed WheelEventMac.mm from the same definition, because that file no longer exists.

  • platform/ContentFilter.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • platform/ContextMenu.h: Ditto.
  • platform/ContextMenuItem.h: Ditto.
  • platform/Cursor.cpp: Ditto.
  • platform/Cursor.h: Ditto.
  • platform/DragData.cpp: Ditto.
  • platform/DragImage.cpp: Ditto.
  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): Changed PLATFORM(MAC) to USE(CF) && !PLATFORM(WIN).

  • platform/LocalizedStrings.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::contextMenuItemTagSearchWeb):

  • platform/LocalizedStrings.h: Ditto.
  • platform/MIMETypeRegistry.cpp: Ditto.

(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/PasteboardStrategy.h: Ditto.
  • platform/PlatformKeyboardEvent.h: Ditto.
  • platform/PlatformMenuDescription.h: Ditto.
  • platform/PlatformSpeechSynthesizer.h: Ditto.
  • platform/PlatformWheelEvent.h: Ditto.

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/SchemeRegistry.cpp: Ditto.

(WebCore::localURLSchemes):
(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal):
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely):

  • platform/ScrollAnimator.cpp: Ditto.

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollAnimator.h: Ditto.
  • platform/ScrollView.cpp: Ditto.
  • platform/ScrollView.h: Ditto.
  • platform/ScrollbarThemeComposite.h: Ditto.
  • platform/SharedBuffer.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSData-related

code.

  • platform/URL.h: Changed PLATFORM(MAC) to USE(FOUNDATION) around NSURL-related code.
  • platform/Widget.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • platform/Widget.h: Ditto.
  • platform/audio/AudioSession.cpp: Changed !PLATFORM(MAC) && !PLATFORM(IOS) to

!PLATFORM(COCOA).

  • platform/audio/HRTFElevation.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • platform/audio/MediaSessionManager.cpp: Ditto.
  • platform/audio/mac/AudioSessionMac.cpp: Updated comment.
  • platform/audio/mac/MediaSessionManagerMac.cpp: Removed PLATFORM(MAC) from Cocoa-only file.
  • platform/cf/SharedBufferCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION) and updated

comment.

  • platform/cf/URLCF.cpp: Changed !PLATFORM(MAC) to !USE(FOUNDATION).
  • platform/graphics/BitmapImage.h: Changed one instance of PLATFORM(MAC) to
USE(CG)
USE(APPKIT), and another to PLATFORM(COCOA).
  • platform/graphics/DisplayRefreshMonitor.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):

  • platform/graphics/DisplayRefreshMonitor.h: Ditto.
  • platform/graphics/FloatPoint.h: Collapsed nested #ifs into a single #if.
  • platform/graphics/FloatRect.h: Ditto.
  • platform/graphics/FloatSize.h: Ditto.
  • platform/graphics/Font.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • platform/graphics/Font.h: Ditto.
  • platform/graphics/FontCache.cpp: Ditto.

(WebCore::FontCache::getFontData):

  • platform/graphics/FontCache.h: Ditto. Also removed redundant friend class declaration.
  • platform/graphics/FontGlyphs.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::FontGlyphs::glyphDataAndPageForCharacter):

  • platform/graphics/GlyphPage.h: Ditto.
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/Image.h: Changed PLATFORM(MAC) to USE(APPKIT) around use of NSImage.

Changed another PLATFORM(MAC) to PLATFORM(COCOA).

  • platform/graphics/IntRect.h: Collapsed nested #ifs into a single #if.
  • platform/graphics/IntSize.h: Ditto.
  • platform/graphics/MediaPlayer.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).

(WebCore::installedMediaEngines):
(WebCore::MediaPlayer::supportsType):

  • platform/graphics/SimpleFontData.cpp: Ditto.

(WebCore::SimpleFontData::nonSyntheticItalicFontData):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):

  • platform/graphics/SimpleFontData.h: Ditto.
  • platform/graphics/TiledBacking.h: Ditto.
  • platform/graphics/ca/GraphicsLayerCA.cpp: Ditto.

(WebCore::GraphicsLayerCA::filtersCanBeComposited):
(WebCore::GraphicsLayerCA::createPlatformCALayer):

  • platform/graphics/ca/LayerFlushScheduler.h: Ditto.
  • platform/graphics/ca/PlatformCAAnimation.h: Ditto.
  • platform/graphics/ca/PlatformCAFilters.h: Ditto.
  • platform/graphics/ca/PlatformCALayer.h: Ditto.
  • platform/graphics/cg/BitmapImageCG.cpp: Ditto.
  • platform/graphics/cg/GraphicsContextCG.cpp: Ditto.

(WebCore::GraphicsContext::setAllowsFontSmoothing):

  • platform/graphics/cg/GraphicsContextPlatformPrivateCG.h: Ditto.
  • platform/graphics/cg/ImageBufferCG.cpp: Ditto.
  • platform/graphics/cg/ImageBufferDataCG.h: Ditto.
  • platform/graphics/cg/ImageCG.cpp: Ditto.
  • platform/graphics/cg/ImageSourceCG.cpp: Ditto.

(WebCore::ImageSource::setData):

  • platform/graphics/cg/ImageSourceCG.h: Ditto.
  • platform/graphics/cg/PathCG.cpp: Ditto.

(WebCore::Path::platformAddPathForRoundedRect):

  • platform/graphics/cg/PatternCG.cpp: Ditto.
  • platform/graphics/gpu/DrawingBuffer.h: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovieView): Removed PLATFORM(MAC) guards, since
this file is only used on Mac and iOS.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): Changed the GL_EXT_draw_buffers check to
match the implementation.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: Changed PLATFORM(MAC) to

PLATFORM(COCOA).

  • platform/mac/KeyEventMac.mm: Added !PLATFORM(IOS).
  • platform/mac/PlatformEventFactoryMac.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • platform/mac/WebCoreSystemInterface.h: Ditto. Removed redundant check for PLATFORM(MAC).
  • platform/mac/WebCoreSystemInterface.mm: Removed redundant check for PLATFORM(MAC).
platform/network/Credential.h: Changed PLATFORM(IOS)
PLATFORM(MAC) to PLATFORM(COCOA).
  • platform/network/NetworkStateNotifier.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
  • platform/network/NetworkStorageSession.h: Ditto.
  • platform/network/NetworkingContext.h: Ditto.
  • platform/network/ProtectionSpace.cpp: Ditto.

(WebCore::ProtectionSpace::receivesCredentialSecurely):

  • platform/network/ResourceHandle.cpp: Ditto.

(WebCore::ResourceHandle::clearAuthentication):
(WebCore::ResourceHandle::shouldContentSniffURL):

  • platform/network/ResourceHandle.h: Ditto.
  • platform/network/ResourceHandleClient.cpp: Ditto.
  • platform/network/ResourceHandleClient.h: Ditto.
  • platform/network/ResourceHandleInternal.h: Ditto.

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/ResourceRequestBase.cpp: Ditto.
  • platform/network/cf/AuthenticationCF.h: Ditto.
  • platform/network/cf/CookieStorageCFNet.cpp: Ditto.
  • platform/network/cf/CredentialStorageCFNet.cpp: Ditto.
  • platform/network/cf/FormDataStreamCFNet.cpp: Ditto.
  • platform/network/cf/NetworkStorageSessionCFNet.cpp: Ditto.

(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):

  • platform/network/cf/ResourceError.h: Ditto.
  • platform/network/cf/ResourceHandleCFNet.cpp: Ditto.

(WebCore::ResourceHandle::createCFURLConnection):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
  • platform/network/cf/ResourceRequest.h: Ditto.

(WebCore::ResourceRequest::ResourceRequest):

  • platform/network/cf/ResourceRequestCFNet.cpp: Ditto.

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):

  • platform/network/cf/ResourceResponse.h: Ditto.
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):

  • platform/network/mac/ResourceResponseMac.mm: Ditto.
  • platform/posix/FileSystemPOSIX.cpp: Changed PLATFORM(MAC) to OS(DARWIN) &&

!PLATFORM(EFL) && !PLATFORM(GTK).

  • platform/text/TextBoundaries.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
3:26 PM Changeset in webkit [163656] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Make it possible for each web page to have different preferences
https://bugs.webkit.org/show_bug.cgi?id=128403

Reviewed by Tim Horton.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setDatabasePath):

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::setPreferences):
(WebKit::WebPageProxy::preferencesDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::~WebPreferences):
(WebKit::WebPreferences::addPage):
(WebKit::WebPreferences::removePage):
(WebKit::WebPreferences::update):
(WebKit::WebPreferences::updatePrivateBrowsingValue):
(WebKit::WebPreferences::anyPagesAreUsingPrivateBrowsing):

  • UIProcess/WebPreferences.h:
3:07 PM Changeset in webkit [163655] by rniwa@webkit.org
  • 7 edits
    3 deletes in trunk

Revert r154384 and r154674 as they broke selection rect computations for text with ligatures.

Source/WebCore:

  • platform/graphics/Font.cpp:

(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::getGlyphsAndAdvancesForSimpleText):
(WebCore::Font::selectionRectForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):

  • platform/graphics/GlyphBuffer.h:
  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):

  • platform/graphics/WidthIterator.h:

LayoutTests:

  • fast/text/partial-textruns-expected.html: Removed.
  • fast/text/partial-textruns.html: Removed.
  • fast/text/resources/PTS55F-webfont.ttf: Removed.
3:03 PM Changeset in webkit [163654] by benjamin@webkit.org
  • 10 edits in trunk/Source

[WK2] Add support for text document viewport configuration
https://bugs.webkit.org/show_bug.cgi?id=128359

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Source/WebCore:

Define a set of ViewportParameters suitable for displaying text documents.
Add a documents class for text document to differentiate them from other type of documents.

  • WebCore.exp.in:
  • dom/Document.h:

(WebCore::Document::isTextDocument):

  • html/TextDocument.cpp:

(WebCore::TextDocument::TextDocument):

  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::ViewportConfiguration):
(WebCore::ViewportConfiguration::webpageParameters):
(WebCore::ViewportConfiguration::plainTextParameters):

  • page/ViewportConfiguration.h:

Source/WebKit2:

When a text document is being loaded, use the plainText viewport parameters.

  • UIProcess/API/ios/WKContentView.h:
  • UIProcess/API/ios/WKContentView.mm:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

3:02 PM Changeset in webkit [163653] by Lucas Forschler
  • 2 edits in tags/Safari-538.16.3/Source/JavaScriptCore

Merged r163342.

3:01 PM Changeset in webkit [163652] by Lucas Forschler
  • 5 edits in tags/Safari-538.16.3/Source

Versioning.

3:01 PM Changeset in webkit [163651] by Bem Jones-Bey
  • 2 edits in trunk/Source/WebCore

FloatingObject::unsafeClone should not copy m_originatingLine
https://bugs.webkit.org/show_bug.cgi?id=128381

Reviewed by Andreas Kling.

Copying the originatingLine allows to break the invariant that the
floating object must only contain lines that are owned by the renderer
it is attached to.

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::unsafeClone):

2:56 PM Changeset in webkit [163650] by Lucas Forschler
  • 1 copy in tags/Safari-538.16.3

New Tag.

2:32 PM Changeset in webkit [163649] by b.long@cablelabs.com
  • 41 edits
    3 copies
    2 moves
    2 adds in trunk

Update TextTrack API to current spec
https://bugs.webkit.org/show_bug.cgi?id=122218

Refactoring VTTCue out of TextTrackCue.

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-vttcue.html

  • CMakeLists.txt: Add VTTCue and rename RenderTextTrackCue to RenderVTTCue.
  • DerivedSources.cpp: Same.
  • DerivedSources.make: Same.
  • GNUmakefile.list.am: Same.
  • PlatformGTK.cmake: Same.
  • WebCore.vcxproj/WebCore.vcxproj: Same.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Same.
  • WebCore.xcodeproj/project.pbxproj: Same.
  • bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::toJS): Use VTTCue DOM wrapper for VTTCue and its subclasses.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Convert to VTTCue as needed.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Same.

  • html/HTMLMediaElement.h: Only print cue.text in debug output if the cue type has a .text attribute
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Convert to VTTCue as needed, and fix TextTrackCueBox to VTTCueBox.
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Convert to VTTCue as needed.

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::addGenericCue): Use refactored VTTCue attributes.

  • html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::newCuesParsed): Use VTTCue's constructor instead of deprecated TextTrackCue constructor.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::setMode): Convert to VTTCue as needed.
(WebCore::TextTrack::hasCue): Make this function only accept VTTCues, since it's only used for them anyway, and convert existing cues to VTTCues as needed.

  • html/track/TextTrack.h: Same as hasCue above.
  • html/track/TextTrackCue.cpp: Refactor a lot of code out. Everything that was removed went to VTTCue.cpp.

(WebCore::TextTrackCue::create): For backwards compatibility, just call VTTCue::create().
(WebCore::TextTrackCue::TextTrackCue): Refactor a lot of code out.
(WebCore::TextTrackCue::~TextTrackCue): Same.
(WebCore::TextTrackCue::didChange): Same.
(WebCore::TextTrackCue::setIsActive): Same.

  • html/track/TextTrackCue.h: Same.
  • html/track/TextTrackCue.idl: Remove VTTCue attributes and add custom toJS function.
  • html/track/TextTrackCueGeneric.cpp: Use VTTCue instead of TextTrackCue.
  • html/track/TextTrackCueGeneric.h: Same.
  • html/track/VTTCue.cpp: Copied from Source/WebCore/html/track/TextTrackCue.cpp.
  • html/track/VTTCue.h: Copied from Source/WebCore/html/track/TextTrackCue.h.
  • html/track/VTTCue.idl: Copied from Source/WebCore/html/track/TextTrackCue.idl.
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::getNewCues): Use VTTCue instead of TextTrackCue.

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsStyleSheetOverride): Use VTTCueBox instead of TextTrackCueBox.

  • rendering/RenderVTTCue.cpp: Renamed from Source/WebCore/rendering/RenderTextTrackCue.cpp. Changed to use VTTCue instead of TextTrackCue.
  • rendering/RenderVTTCue.h: Renamed from Source/WebCore/rendering/RenderTextTrackCue.h. Changed to use VTTCue instead of TextTrackCue.
  • rendering/RenderingAllInOne.cpp: Rename RenderTextTrackCue to RenderVTTCue.

LayoutTests:

  • js/dom/constructor-length.html: Add VTTCue constructor.
  • platform/efl/js/dom/global-constructors-attributes-expected.txt: Same.
  • platform/efl/js/dom/constructor-length-expected.txt: Same.
  • js/dom/global-constructors-attributes-expected.txt: Same.
  • platform/gtk-wk2/js/dom/constructor-length-expected.txt: Same.
  • platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Same.
  • platform/gtk/js/dom/constructor-length-expected.txt: Same.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt: Same.
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Same.
  • platform/mac/js/dom/constructor-length-expected.txt: Same.
  • platform/mac/js/dom/global-constructors-attributes-expected.txt: Same.
  • platform/win/js/dom/global-constructors-attributes-expected.txt: Same.
  • media/track/track-cues-cuechange-expected.txt: Cues are of type VTTCue now.
  • media/track/track-cues-enter-exit-expected.txt: Same.
  • media/track/track-vttcue-expected.txt: Test VTTCue interface.
  • media/track/track-vttcue.html: Same.
  • media/video-test.js:

(testExpected): Add "instanceof" as a valid operator.

2:31 PM Changeset in webkit [163648] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[iOS] Eliminate race between XPC connection queue and Notification queue
https://bugs.webkit.org/show_bug.cgi?id=128384

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-07
Reviewed by Timothy Hatcher.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
Create the queue to use for RemoteInspector xpc connection
management and the connection itself.

  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
Use the passed in queue instead of creating one for itself.

2:27 PM Changeset in webkit [163647] by barraclough@apple.com
  • 5 edits in trunk/Source

Should report user input to PageThrottler
https://bugs.webkit.org/show_bug.cgi?id=128398

Reviewed by Tim Horton.

Make sure we wake from AppNap if there is user interaction.

Source/WebCore:

  • page/PageThrottler.h:

(WebCore::PageThrottler::didReceiveUserInput):
(WebCore::PageThrottler::pluginDidEvaluate):

  • added, these call reportInterestingEvent()

Source/WebKit2:

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

  • reportInterestingEvent() -> pluginDidEvaluate()
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::wheelEvent):
(WebKit::WebPage::keyEvent):

  • call didReceiveUserInput()
2:12 PM Changeset in webkit [163646] by dino@apple.com
  • 3 edits in trunk/Source/WebKit2

WebGL doesn't update with remotely hosted layers
https://bugs.webkit.org/show_bug.cgi?id=128390

Reviewed by Simon Fraser.

PlatformCALayerRemote was intercepting the setNeedsDisplay calls to
WebGL layers, and thus causing them to not draw. Fix this by adding an
override in PlatformCALayerRemoteCustom to check if it is a WebGLLayer
and call setNeedsDisplay directly.

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::setNeedsDisplay):

2:01 PM Changeset in webkit [163645] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2] Fitler touch events only based on touch start
https://bugs.webkit.org/show_bug.cgi?id=128354

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-07
Reviewed by Simon Fraser.

Touch Events track their target, we should not test the touch regions
again after a touch sequence starts.

This patch adds a boolean flag to know if we are sending events to the WebProcess
(m_isTrackingTouchEvents). The flag is updated every time a touch sequence starts.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::shouldStartTrackingTouchEvents):
(WebKit::WebPageProxy::handleTouchEvent):

  • UIProcess/WebPageProxy.h:
1:42 PM Changeset in webkit [163644] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Simplify WebPreferences creation inside WebPageGroup
https://bugs.webkit.org/show_bug.cgi?id=128392

Reviewed by Andreas Kling.

Always create a WebPreferences object when creating the web page group.
This is another step towards letting WebPageProxy manage web preferences.

  • UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):

  • UIProcess/WebPageGroup.h:
1:39 PM Changeset in webkit [163643] by barraclough@apple.com
  • 2 edits in trunk/Source/WebKit2

Reenable AppNap
https://bugs.webkit.org/show_bug.cgi?id=128394

Reviewed by Tim Horton.

  • Shared/WebPreferencesStore.h:
    • pageVisibilityBasedProcessSuppressionEnabled shoud default to true.
1:23 PM Changeset in webkit [163642] by k.czech@samsung.com
  • 2 edits in trunk/Tools

Build fix after r163632

Unreviewed EFL build fix

Added empty stub to WKTR to not break EFL build.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

1:17 PM Changeset in webkit [163641] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for 32-bit iOS.

Use magic ? values to allow the exported symbol to be different on 32- and 64-bit builds.

  • WebCore.exp.in:
12:14 PM Changeset in webkit [163640] by timothy_horton@apple.com
  • 2 edits
    1 move in trunk/Source/WebKit2

Rename ViewGestureController.mm to ViewGestureControllerMac.mm
https://bugs.webkit.org/show_bug.cgi?id=128387

Reviewed by Anders Carlsson.

As a precursor to having a second nearly completely divergent
ViewGestureController implementation for iOS.

  • UIProcess/mac/ViewGestureControllerMac.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.mm.
  • WebKit2.xcodeproj/project.pbxproj:

Rename ViewGestureController.mm to ViewGestureControllerMac.mm.
Unfortunately, since we're not renaming the class, the header
has to keep its name (and will be the recipient of a giant #if in a later
patch), because the message receiver generated code will try to import
ViewGestureController.h (without the Mac suffix).

11:59 AM Changeset in webkit [163639] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r160628): LLint does not appear to handle impure get own property properly
https://bugs.webkit.org/show_bug.cgi?id=127943

Reviewed by Filip Pizlo.

Make sure the LLINT doesn't attempt to cache property
access on structures with impureGetOwnPropertySlot set.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

11:57 AM Changeset in webkit [163638] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Convert ProgressTracker to std::chrono
https://bugs.webkit.org/show_bug.cgi?id=128377

Reviewed by Andreas Kling.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):

  • loader/ProgressTracker.h:
11:49 AM Changeset in webkit [163637] by Brian Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Clean up DataGrid and add table columns incrementally
https://bugs.webkit.org/show_bug.cgi?id=128332

Reviewed by Timothy Hatcher.

Miscellaneous improvements to DataGrid to make it more maintainable.
In particular, it now uses a Map to store column settings, and the
construction sequence has been simplified so that it is safe to add
columns at the end of the constructor (or any later time).

DataGrid stores a bunch of settings per-column, but before this was done
by both storing properties on the provided column objects as well as
keeping several columnIdentifier-keyed maps for properties like group
and hidden.

Improve code readability by using for..of loops, destructuring assignment,
Node.createElement, and updating variable names. All variables that refer
to DOM nodes now have a Element suffix to distinguish them from model objects.

  • UserInterface/DataGrid.js:

(.sortDataGrid):
(WebInpector.DataGrid): Create all DOM elements before populating columns.
Remove redundant objects for storing per-column values. Copy column settings
into a map rather than mutating the passed-in JSON-like settings data structure.

(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.get length):
(WebInspector.DataGrid.prototype.updateLayout):
(WebInspector.DataGrid.prototype.get scrollContainer):
(WebInspector.DataGrid.prototype.isScrolledToLastRow):
(WebInspector.DataGrid.prototype.scrollToLastRow):
(WebInspector.DataGrid.prototype._positionResizerElements):
(WebInspector.DataGrid.prototype.addCreationNode):
(WebInspector.DataGrid.prototype.):
(WebInspector.DataGrid.prototype.sortNodes):
(WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
(WebInspector.DataGrid.prototype._clickInHeaderCell):
(WebInspector.DataGrid.prototype.isColumnSortColumn):
(WebInspector.DataGrid.prototype.headerTableHeader):
(WebInspector.DataGrid.prototype._copyTextForDataGridNode):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.createCells):
(WebInspector.DataGridNode.prototype.createCell.get var):
(WebInspector.DataGridNode.prototype.elementWithColumnIdentifier):
(WebInspector.DataGridNode.prototype._attach):

  • UserInterface/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters.scopeBar.this.columns.get scopeBar):
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):

11:43 AM Changeset in webkit [163636] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Copying a WebPreferences object should be done through a member function
https://bugs.webkit.org/show_bug.cgi?id=128385

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreateCopy):

  • UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::copy):

  • UIProcess/WebPreferences.h:
11:10 AM Changeset in webkit [163635] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WebPageGroup::setPreferences should set the preferences on all pages in the group
https://bugs.webkit.org/show_bug.cgi?id=128383

Reviewed by Alexey Proskuryakov.

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::setPreferences):

10:53 AM Changeset in webkit [163634] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

32-bit build fix.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):

10:46 AM Changeset in webkit [163633] by commit-queue@webkit.org
  • 50 edits in trunk

[CSS Background Blending] Unprefix the -webkit-background-blend-mode property

https://bugs.webkit.org/show_bug.cgi?id=128270

Patch by Mihai Tica <mitica@adobe.com> on 2014-02-07
Reviewed by Dean Jackson.

Source/WebCore:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

Source/WebInspectorUI:

  • UserInterface/CSSKeywordCompletions.js: Refactor -webkit-background-blend-mode to background-blend-mode.

LayoutTests:

This patch consist of unprefixing the -webkit-background-blend-mode.
The property now changes to background-blend-mode.

  • css3/compositing/background-blend-mode-background-attachement-fixed-expected.html:
  • css3/compositing/background-blend-mode-background-attachement-fixed.html:
  • css3/compositing/background-blend-mode-background-clip-content-box-expected.html:
  • css3/compositing/background-blend-mode-background-clip-content-box.html:
  • css3/compositing/background-blend-mode-background-clip-padding-box-expected.html:
  • css3/compositing/background-blend-mode-background-clip-padding-box.html:
  • css3/compositing/background-blend-mode-background-origin-border-box-expected.html:
  • css3/compositing/background-blend-mode-background-origin-border-box.html:
  • css3/compositing/background-blend-mode-background-position-percentage-expected.html:
  • css3/compositing/background-blend-mode-background-position-percentage.html:
  • css3/compositing/background-blend-mode-background-repeat-no-repeat-expected.html:
  • css3/compositing/background-blend-mode-background-repeat-no-repeat.html:
  • css3/compositing/background-blend-mode-background-size-contain-expected.html:
  • css3/compositing/background-blend-mode-background-size-contain.html:
  • css3/compositing/background-blend-mode-background-size-cover-expected.html:
  • css3/compositing/background-blend-mode-background-size-cover.html:
  • css3/compositing/background-blend-mode-crossfade-image.html:
  • css3/compositing/background-blend-mode-data-uri-svg-image.html:
  • css3/compositing/background-blend-mode-default-value.html:
  • css3/compositing/background-blend-mode-different-image-formats.html:
  • css3/compositing/background-blend-mode-gif-color-2.html:
  • css3/compositing/background-blend-mode-gif-color.html:
  • css3/compositing/background-blend-mode-gradient-color.html:
  • css3/compositing/background-blend-mode-gradient-gradient.html:
  • css3/compositing/background-blend-mode-gradient-image.html:
  • css3/compositing/background-blend-mode-image-color.html:
  • css3/compositing/background-blend-mode-image-image.html:
  • css3/compositing/background-blend-mode-image-svg.html:
  • css3/compositing/background-blend-mode-multiple-background-layers.html:
  • css3/compositing/background-blend-mode-property-expected.txt:
  • css3/compositing/background-blend-mode-property-parsing-expected.txt:
  • css3/compositing/background-blend-mode-separate-layer-declaration.html:
  • css3/compositing/background-blend-mode-single-layer-no-blending.html:
  • css3/compositing/background-blend-mode-svg-color.html:
  • css3/compositing/background-blend-mode-svg.html:
  • css3/compositing/background-blend-mode-tiled-layers.html:
  • css3/compositing/blend-mode-layers.html:
  • css3/compositing/effect-background-blend-mode-stacking.html:
  • css3/compositing/effect-background-blend-mode-tiled.html:
  • css3/compositing/effect-background-blend-mode.html:
  • css3/compositing/script-tests/background-blend-mode-property-parsing.js:

(testBlendModeRule):

  • css3/compositing/script-tests/background-blend-mode-property.js:

(testblendmode):

10:43 AM Changeset in webkit [163632] by Samuel White
  • 20 edits
    2 adds in trunk

AX: Find and select text with respect to insertion point using accessibility API.
https://bugs.webkit.org/show_bug.cgi?id=128026

Reviewed by Chris Fleizach.

Source/WebCore:

Added facilities to support semi-ambiguous text selection through the accessibility API. All
requests are handled with respect to the current selection. The requests are disambiguated in
WebCore using passed parameters such as: SelectStringAfterSelection , ..Before.., ..ClosestTo...,
etc. Callers can also supply an array of strings to select and the closest that matches the
disambiguation criteria will be used.

Test: platform/mac/accessibility/select-text.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::rangeClosestToRange):
(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection):
(WebCore::AccessibilityObject::selectionRange):
(WebCore::AccessibilityObject::selectText):
(WebCore::AccessibilityObject::frame):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilitySelectTextCriteria::AccessibilitySelectTextCriteria):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilitySelectTextCriteriaForCriteriaParameterizedAttribute):
(-[WebAccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

  • dom/Position.cpp:

(WebCore::Position::positionCountBetweenPositions):

  • dom/Position.h:

Tools:

Added method to AccessibilityUIElement to enable testing of accessibility text selection.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(selectTextWithCriteriaCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::selectTextWithCriteria):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(selectTextParameterizedAttributeForCriteria):
(AccessibilityUIElement::selectTextWithCriteria):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::selectTextWithCriteria):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::selectTextWithCriteria):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::selectTextParameterizedAttributeForCriteria):
(WTR::AccessibilityUIElement::selectTextWithCriteria):

LayoutTests:

Tests that text selection via the accessibility API works as expected.

  • platform/mac/accessibility/bounds-for-range-expected.txt:
  • platform/mac/accessibility/select-text-expected.txt: Added.
  • platform/mac/accessibility/select-text.html: Added.
10:37 AM Changeset in webkit [163631] by Bem Jones-Bey
  • 3 edits in trunk/Source/WebCore

FloatingObject m_paginationStrut should be LayoutUnit
https://bugs.webkit.org/show_bug.cgi?id=119808

Reviewed by Andreas Kling.

Make the paginationStrut in FloatingObject have the same type as all
of the other paginationStruts in the code.

  • rendering/FloatingObjects.h:

(WebCore::FloatingObject::paginationStrut):
(WebCore::FloatingObject::setPaginationStrut):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::positionNewFloatOnLine):

10:32 AM Changeset in webkit [163630] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] WKRemoteObjectInterface doesn’t support aribtrary argument classes
https://bugs.webkit.org/show_bug.cgi?id=128368

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKRemoteObjectInterface.h: Declared new methods.
  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(propertyListClasses): Removed NSNull, which is not really a property list class.
(classesForSelectorArgument): Added helper function.
(-[WKRemoteObjectInterface classesForSelector:argumentIndex:]): Added.
(-[WKRemoteObjectInterface setClasses:forSelector:argumentIndex:]): Added.

10:32 AM Changeset in webkit [163629] by mitz@apple.com
  • 8 edits
    4 adds in trunk/Source/WebKit2

[Cocoa] API::FrameHandle has a generic wrapper
https://bugs.webkit.org/show_bug.cgi?id=128366

Reviewed by Anders Carlsson.

Added WKFrameHandle.

  • Shared/API/Cocoa/WKFrameHandle.h: Added.
  • Shared/API/Cocoa/WKFrameHandle.mm: Added.

(-[WKFrameHandle dealloc]): Calls the API::FrameHandle destructor.
(-[WKFrameHandle isEqual:]): Checks for frame ID equality.
(-[WKFrameHandle hash]): Returns the frame ID.
(-[WKFrameHandle _frameID]): Ditto.
(-[WKFrameHandle copyWithZone:]): Retains self.
(+[WKFrameHandle supportsSecureCoding]): Returns YES.
(-[WKFrameHandle initWithCoder:]): Decodes the frame ID and constructs an API::FrameHandle
with it.
(-[WKFrameHandle encodeWithCoder:]): Encodes the frame ID.
(-[WKFrameHandle _apiObject]): Returns the wrapped API::FrameHandle.

  • Shared/API/Cocoa/WKFrameHandleInternal.h: Added.

(WebKit::wrapper): Added. Returns an API::FrameHandle’s wrapper as a WKFrameHandle.

  • Shared/APIFrameHandle.cpp:

(API::FrameHandle::create): Changed to return a PassRefPtr.

  • Shared/APIFrameHandle.h: Made the constructor public for -[WKFrameHandle initWithCoder:].
  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Allocate a WKFrameHandle if the object is an API::FrameHandle.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Declared handle property.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(+[WKWebProcessPlugInFrame lookUpFrameFromHandle:]): Added. Calls WebProcess::webFrame to
look up a frame with the given handle’s frame ID.
(-[WKWebProcessPlugInFrame handle]): Added. Returns a new handle with the frame’s ID.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrameInternal.h: Updated #import.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h: Added.
10:31 AM Changeset in webkit [163628] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] WKWebProcessPlugInNodeHandle methods leak and may crash
https://bugs.webkit.org/show_bug.cgi?id=128365

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(+[WKWebProcessPlugInNodeHandle nodeHandleWithJSValue:inContext:]): Null-check the result
of InjectedBundleNodeHandle::getOrCreate, and autorelease the return value.
(-[WKWebProcessPlugInNodeHandle htmlIFrameElementContentFrame]): Null-check the result of
InjectedBundleNodeHandle::htmlIFrameElementContentFrame, and autorelease the return value.

10:26 AM Changeset in webkit [163627] by beidson@apple.com
  • 20 edits in trunk

IDB: storage/indexeddb/create-index-with-integer-keys.html fails
<rdar://problem/16002857> and https://bugs.webkit.org/show_bug.cgi?id=128316

Reviewed by Geoff Garen.

Source/WebCore:

Tested by storage/indexeddb/create-index-with-integer-keys.html (and probably some others)

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update): Update createIDBKeyFromScriptValueAndKeyPath usage.
(WebCore::IDBCursor::setValueReady): Update createIDBKeyFromScriptValueAndKeyPath usage.

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put): Update usage of binding utilities.

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Update createIDBKeyFromScriptValueAndKeyPath usage.

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath): Changed to take an ExecState*.
(WebCore::deserializeIDBValueBuffer): Added new version that starts with ExecState* and Vector<uint8_t>

instead of RequestState and SharedBuffer.

(WebCore::generateIndexKeysForValue): Moved from IDBObjectStore.cpp and changed to take an ExecState*

  • bindings/js/IDBBindingUtilities.h:

Added new blob fetcher that works with uint8_t buffers:

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::getColumnBlobAsVector):

  • platform/sql/SQLiteStatement.h:
  • WebCore.exp.in:

Source/WebKit2:

Update Vector<char> to Vector<uint8_t> throughout:

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:

Update Vector<char> to Vector<uint8_t> throughout:

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::advanceOnce):

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:

(WebKit::SQLiteIDBCursor::currentValueBuffer):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex): Create a script value from the value data, use

generateIndexKeysForValue to get the index keys, and then write the resulting index records.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putIndexRecord): Call through to uncheckedPutIndexRecord.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord): Version of putIndexRecord that doesn’t

validate the transaction or its mode.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor): Update Vector<char> to Vector<uint8_t>.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor): Ditto.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor): Ditto.

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

LayoutTests:

  • platform/mac-wk2/TestExpectations: Enable the test.
10:20 AM Changeset in webkit [163626] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

childShouldCreateRenderer should return false for the mspace element
https://bugs.webkit.org/show_bug.cgi?id=128325

Patch by Frédéric Wang <fred.wang@free.fr> on 2014-02-07
Reviewed by Chris Fleizach.

Source/WebCore:

The mspace element can not have children so this makes its
childShouldCreateRenderer always return false.

Test: mathml/presentation/mspace-children.html

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::childShouldCreateRenderer):

LayoutTests:

Add tests to ensure that the mspace element does not have renderer
children.

  • mathml/presentation/mspace-children-expected.png: Added.
  • mathml/presentation/mspace-children-expected.txt: Added.
  • mathml/presentation/mspace-children.html: Added.
  • platform/mathml/presentation/mspace-children-expected.txt: Added.
9:45 AM Changeset in webkit [163625] by commit-queue@webkit.org
  • 90 edits in trunk

[CSS Grid Layout] Rename grid-definition-{columns|rows} to match the new syntax
https://bugs.webkit.org/show_bug.cgi?id=127989

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-02-07
Reviewed by Andreas Kling.

In the latest WD, grid-definition-{columns|rows} were renamed to grid-template-{columns|rows}.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

  • fast/css-grid-layout/auto-content-resolution-columns.html:
  • fast/css-grid-layout/auto-content-resolution-rows.html:
  • fast/css-grid-layout/breadth-size-resolution-grid.html:
  • fast/css-grid-layout/calc-resolution-grid-item.html:
  • fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
  • fast/css-grid-layout/flex-content-resolution-columns.html:
  • fast/css-grid-layout/flex-content-resolution-rows.html:
  • fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
  • fast/css-grid-layout/grid-auto-columns-rows-update.html:
  • fast/css-grid-layout/grid-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-auto-flow-update.html:
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-dynamic-updates-relayout.html:
  • fast/css-grid-layout/grid-element-border-grid-item.html:
  • fast/css-grid-layout/grid-element-border-padding-grid-item.html:
  • fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:
  • fast/css-grid-layout/grid-element-change-columns-repaint.html:
  • fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:
  • fast/css-grid-layout/grid-element-change-rows-repaint.html:
  • fast/css-grid-layout/grid-element-empty-row-column.html:
  • fast/css-grid-layout/grid-element-min-max-width.html:
  • fast/css-grid-layout/grid-element-padding-grid-item.html:
  • fast/css-grid-layout/grid-element-padding-margin.html:
  • fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
  • fast/css-grid-layout/grid-element-repeat-get-set.html:
  • fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
  • fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
  • fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
  • fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
  • fast/css-grid-layout/grid-item-change-column-repaint.html:
  • fast/css-grid-layout/grid-item-change-row-repaint.html:
  • fast/css-grid-layout/grid-item-margin-resolution.html:
  • fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
  • fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
  • fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
  • fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
  • fast/css-grid-layout/grid-item-negative-position-resolution.html:
  • fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-item-order-paint-order.html:
  • fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
  • fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
  • fast/css-grid-layout/grid-item-spanning-resolution.html:
  • fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
  • fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
  • fast/css-grid-layout/grid-preferred-logical-widths.html:
  • fast/css-grid-layout/implicit-columns-auto-resolution.html:
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/implicit-rows-auto-resolution.html:
  • fast/css-grid-layout/minmax-fixed-logical-height-only.html:
  • fast/css-grid-layout/minmax-fixed-logical-width-only.html:
  • fast/css-grid-layout/minmax-max-content-resolution-columns.html:
  • fast/css-grid-layout/minmax-max-content-resolution-rows.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
  • fast/css-grid-layout/minmax-spanning-resolution-columns.html:
  • fast/css-grid-layout/minmax-spanning-resolution-rows.html:
  • fast/css-grid-layout/named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/named-grid-line-get-set.html:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/non-grid-columns-rows-get-set.html:
  • fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
  • fast/css-grid-layout/non-grid-element-repeat-get-set.html:
  • fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/non-named-grid-line-get-set.html:
  • fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
  • fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
  • fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
  • fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
  • fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
  • fast/css-grid-layout/percent-resolution-grid-item.html:
  • fast/css-grid-layout/place-cell-by-index.html:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridTemplatesValues):
(testGridTemplatesSetJSValues):
(testNonGridTemplatesSetJSValues):
(checkGridTemplatesSetJSValues):
(testGridTemplatesSetBadJSValues):

  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

  • ietestcenter/css3/grid/display-grid-001-expected.htm:
9:43 AM Changeset in webkit [163624] by dino@apple.com
  • 2 edits in trunk/LayoutTests

animations/suspend-resume-animation.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=128379

Marking it as such.

  • platform/mac/TestExpectations:
8:11 AM Changeset in webkit [163623] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Remove test expectations after r163586 and skip two http tests.

  • platform/efl-wk2/TestExpectations:
4:02 AM Changeset in webkit [163622] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: DocumentThreadableLoader always has a Document.
<https://webkit.org/b/128364>

DocumentThreadableLoader always has an "owner" Document, so store
that as a reference instead of a pointer. Removed some unnecessary
assertions exposed by this change.

Reviewed by Antti Koivisto.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadResourceSynchronously):
(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightFailure):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::securityOrigin):

  • loader/DocumentThreadableLoader.h:
  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

3:44 AM Changeset in webkit [163621] by Manuel Rego Casasnovas
  • 3 edits in trunk/Tools

[GTK] Disable gtk-doc in EWS
https://bugs.webkit.org/show_bug.cgi?id=128370

Reviewed by Carlos Garcia Campos.

Disable gtk-doc generation in EWS due to http://webkit.org/b/128369.

  • Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.

2:52 AM Changeset in webkit [163620] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] editing/style/block-style-005.html failing
https://bugs.webkit.org/show_bug.cgi?id=114612

Patch by Lukasz Bialek <l.bialek@samsung.com> on 2014-02-07
Reviewed by Ryosuke Niwa.

After r148378 editing/style/block-style-005.htm test stopped passing.
Number of "moveSelectionByLineCommand" is changed to 4 to match intended
test behaviour. Test is confirmed to pass in EFL and GTK ports now.

  • editing/style/block-style-005.html:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
2:49 AM Changeset in webkit [163619] by mihnea@adobe.com
  • 7 edits
    1 delete in trunk/LayoutTests

[CSSRegions] Remove style-scoped tests
https://bugs.webkit.org/show_bug.cgi?id=128361

Reviewed by Andrei Bucur.

Remove tests combining style-scoped and regions. The support was removed from code base
and the tests were skipped from a long time.

  • fast/regions/style-scoped/style-scoped-in-flow-expected.html: Removed.
  • fast/regions/style-scoped/style-scoped-in-flow-override-container-style-expected.html: Removed.
  • fast/regions/style-scoped/style-scoped-in-flow-override-container-style.html: Removed.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-expected.html: Removed.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions-expected.html: Removed.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling-multiple-regions.html: Removed.
  • fast/regions/style-scoped/style-scoped-in-flow-override-region-styling.html: Removed.
  • fast/regions/style-scoped/style-scoped-in-flow.html: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
2:44 AM Changeset in webkit [163618] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Vector-effect updates require a re-layout
https://bugs.webkit.org/show_bug.cgi?id=127553

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

As noted in the stale SVGRenderStyle::diff() comment, now that layout() observes vector-effect
we need to trigger a re-layout on attribute changes.

Merged from Blink: https://src.chromium.org/viewvc/blink?revision=152570&view=revision

Source/WebCore:

Tests: svg/custom/non-scaling-stroke-update-expected.svg

svg/custom/non-scaling-stroke-update.svg

  • rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::diff):

LayoutTests:

  • svg/custom/non-scaling-stroke-update-expected.svg: Added.
  • svg/custom/non-scaling-stroke-update.svg: Added.
2:21 AM Changeset in webkit [163617] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebCore

Renaming isTableElement() to isRenderedTable() as per the FIXME comment
https://bugs.webkit.org/show_bug.cgi?id=127769

Patch by Laszlo Vidacs <lvidacs.u-szeged@partner.samsung.com> on 2014-02-07
Reviewed by Andreas Kling.

Rename method and use IsTable() instead of local type checking.

  • dom/Position.cpp:

(WebCore::Position::parentAnchoredEquivalent):
(WebCore::Position::upstream):
(WebCore::Position::downstream):
(WebCore::Position::isCandidate):

  • dom/PositionIterator.cpp:

(WebCore::PositionIterator::isCandidate):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):
(WebCore::CompositeEditCommand::moveParagraphWithClones):

  • editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):

  • editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • editing/htmlediting.cpp:

(WebCore::firstInSpecialElement):
(WebCore::lastInSpecialElement):
(WebCore::isRenderedTable):

  • editing/htmlediting.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):

2:10 AM Changeset in webkit [163616] by ChangSeok Oh
  • 3 edits in trunk/LayoutTests

Unreviewed GTK port gardening

  • platform/gtk-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
1:20 AM Changeset in webkit [163615] by g.czajkowski@samsung.com
  • 5 edits in trunk/LayoutTests

Verify misspellings after lines merge/split asynchronously
https://bugs.webkit.org/show_bug.cgi?id=128305

Reviewed by Ryosuke Niwa.

Adapt two spelling tests to use asynchronous spellchecking.

  • editing/spelling/script-tests/spelling-backspace-between-lines.js:

(testTwoLinesMisspellings):
(testMisspellingsAfterLineMergeUsingDelete):
(testMisspellingsAfterLineMergeUsingForwardDelete):
Group test cases into separated methods.
Use shouldBeEqualToString to compare strings.
Add newly created div elements instead of overriding
the previous one in order that non DumpRenderTree users
can see what has been tested.

  • editing/spelling/spelling-backspace-between-lines-expected.txt:
  • editing/spelling/spelling-linebreak-expected.txt:
  • editing/spelling/spelling-linebreak.html:
12:32 AM Changeset in webkit [163614] by jinwoo7.song@samsung.com
  • 6 edits in trunk

[EFL][WK2] WebView should be able to configure to set fixed layout
https://bugs.webkit.org/show_bug.cgi?id=128300

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Currently, webview is created by setting fixed layout as true and there is no way to change the setting.
But some applications may do not want to use fixed layout so I'd like to add ewk APIs to configure to it.

  • UIProcess/API/efl/ewk_view.cpp:

(EWKViewCreate): Do not set to use fixed layout as default.
(ewk_view_layout_fixed_set):
(ewk_view_layout_fixed_get):

  • UIProcess/API/efl/ewk_view.h: Add ewk APIs to set fixed layout.
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main): Add command argument option to use fixed layout.

Feb 6, 2014:

11:23 PM Changeset in webkit [163613] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r163612.

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
10:37 PM Changeset in webkit [163612] by beidson@apple.com
  • 23 edits in trunk/Source

IDB: Remove the entirely unnecessary "Value Key" concept
https://bugs.webkit.org/show_bug.cgi?id=128360

Reviewed by Dan Bernstein.

Source/WebCore:

No new tests (No change in behavior)

All cursor operations were set up to pass a value key parameter around, but it was:
1 - Entirely unused
2 - The same thing that the primary key is supposed to be

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBCursorBackend.cpp:

(WebCore::IDBCursorBackend::updateCursorData):
(WebCore::IDBCursorBackend::clear):

  • Modules/indexeddb/IDBCursorBackend.h:
  • Modules/indexeddb/IDBCursorBackendOperations.cpp:

(WebCore::CursorAdvanceOperation::perform):
(WebCore::CursorIterationOperation::perform):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::OpenCursorOperation::perform):

  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::openCursor):
(WebCore::IDBServerConnectionLevelDB::cursorAdvance):
(WebCore::IDBServerConnectionLevelDB::cursorIterate):

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:

Source/WebKit2:

All cursor operations were set up to pass a value key parameter around, but it was:
1 - Entirely unused
2 - The same thing that the primary key is supposed to be

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didOpenCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didAdvanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::didIterateCursorInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::SQLiteIDBCursor::advanceOnce): Clean this logic up to not need temporaries,

and also to save the correct primary key (previously the 'value key')

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
10:32 PM Changeset in webkit [163611] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix on GTK build since r163597

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseUpdatePreferences):

9:38 PM Changeset in webkit [163610] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Need a ObjC SPI to get the process identifier for web process.
https://bugs.webkit.org/show_bug.cgi?id=128356

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-02-06
Reviewed by Dan Bernstein.

Add a SPI for WKBrowsingContextController to return the process identifier of web
process in the current page.

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController processIdentifier]):

  • UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:
9:14 PM Changeset in webkit [163609] by ryuan.choi@samsung.com
  • 6 edits in trunk/Source/WebKit2

Unreviewed build fix on EFL build since r163597

preferences() changed return type from pointer to reference.

  • UIProcess/API/efl/ewk_settings.cpp:

(EwkSettings::preferences):
(ewk_settings_fullscreen_enabled_set):
(ewk_settings_fullscreen_enabled_get):
(ewk_settings_javascript_enabled_set):
(ewk_settings_javascript_enabled_get):
(ewk_settings_loads_images_automatically_set):
(ewk_settings_loads_images_automatically_get):
(ewk_settings_developer_extras_enabled_set):
(ewk_settings_developer_extras_enabled_get):
(ewk_settings_file_access_from_file_urls_allowed_set):
(ewk_settings_file_access_from_file_urls_allowed_get):
(ewk_settings_frame_flattening_enabled_set):
(ewk_settings_frame_flattening_enabled_get):
(ewk_settings_dns_prefetching_enabled_set):
(ewk_settings_dns_prefetching_enabled_get):
(ewk_settings_encoding_detector_enabled_set):
(ewk_settings_encoding_detector_enabled_get):
(ewk_settings_preferred_minimum_contents_width_set):
(ewk_settings_preferred_minimum_contents_width_get):
(ewk_settings_offline_web_application_cache_enabled_set):
(ewk_settings_offline_web_application_cache_enabled_get):
(ewk_settings_scripts_can_open_windows_set):
(ewk_settings_scripts_can_open_windows_get):
(ewk_settings_local_storage_enabled_set):
(ewk_settings_local_storage_enabled_get):
(ewk_settings_plugins_enabled_set):
(ewk_settings_plugins_enabled_get):
(ewk_settings_default_font_size_set):
(ewk_settings_default_font_size_get):
(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):
(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):
(ewk_settings_spatial_navigation_enabled_set):
(ewk_settings_spatial_navigation_enabled_get):
(EwkSettings::setDefaultTextEncodingName):

  • UIProcess/API/efl/ewk_settings_private.h:

(EwkSettings::EwkSettings):

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::preferencesDidChange):

8:11 PM Changeset in webkit [163608] by Joseph Pecoraro
  • 2 edits in trunk

[iOS] make should build WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128351

Reviewed by Daniel Bates.

  • Source/Makefile:
7:12 PM Changeset in webkit [163607] by gyuyoung.kim@samsung.com
  • 4 edits
    2 adds in trunk/LayoutTests

Add a test case for navigator.isProtocolHandlerRegistered
https://bugs.webkit.org/show_bug.cgi?id=128302

Reviewed by Anders Carlsson.

Add a test case for navigator.isProtocolHandlerRegistered. This new test will
check if "navigator.isProtocolHandlerRegistered" throws the proper exceptions
and returns a proper state of handler.

Currently, this function is only supported by EFL WK1 port.

  • fast/dom/is-protocol-handler-registered-expected.txt: Added.
  • fast/dom/is-protocol-handler-registered.html: Added.
  • platform/efl-wk2/TestExpectations: Skip this test.
  • platform/gtk/TestExpectations: ditto.
  • platform/mac/TestExpectations: ditto.
7:10 PM Changeset in webkit [163606] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.17.1/Source/JavaScriptCore

Merged r163595.

7:04 PM Changeset in webkit [163605] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.17.1/Source

Versioning.

7:02 PM Changeset in webkit [163604] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.17.1

New tag.

6:41 PM Changeset in webkit [163603] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in MiniBrowser when using Command-W to close a WK2 window
https://bugs.webkit.org/show_bug.cgi?id=128355
<rdar://problem/16008531>

Reviewed by Simon Fraser.

Don't set the API clients to nullptr when closing the page, just create new empty ones instead.
Too much code depends on the clients never being null.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

6:30 PM Changeset in webkit [163602] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[wk2] iOS should use accelerated drawing by default, except in the simulator
https://bugs.webkit.org/show_bug.cgi?id=128140
<rdar://problem/15974171>

Reviewed by Anders Carlsson.

  • Shared/WebPreferencesStore.h:

Turn full-page accelerated drawing on for iOS, except the simulator which doesn't support it.
Turn canvas accelerated drawing on for all platforms except the iOS simulator, for the same reason.
The defaults remain the same for non-iOS platforms.

6:29 PM Changeset in webkit [163601] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Fix DoYouEvenBench after r163429.

  • Scripts/webkitpy/performance_tests/perftest.py:
6:19 PM Changeset in webkit [163600] by commit-queue@webkit.org
  • 17 edits
    6 adds in trunk/Source

Add support for AVKit fullscreen to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128143

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-02-06
Reviewed by Simon Fraser.

Source/WebCore:

Rename overloaded functions to prevent ambiguous template parameter
compile error in generated code.

Rename overloaded exitFullscreen to exitFullscreenWithCompletionHandler.
Rename overloaded enterFullscreen to enterFullscreenWithCompletionHandler.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController exitFullscreen]):

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::enterFullscreenWithCompletionHandler):
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::exitFullscreenWithCompletionHandler):
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):

  • platform/ios/WebVideoFullscreenModelMediaElement.h:

Source/WebKit2:

Add WebVideoFullscreenManager and WebVideoFullscreenManagerProxy that implement
WebVideoFullscreenModel and WebVideoFullscreenInterface.

  • DerivedSources.make:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

initialize member m_videoFullscreenManager

(WebKit::WebPageProxy::videoFullscreenManager):

add accessor for videoFullscreenManager

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebVideoFullscreenManagerProxy.cpp: Added.

(WebKit::WebVideoFullscreenManagerProxy::create):
(WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy):
(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy):

add basic creation for object.

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):
(WebKit::WebVideoFullscreenManagerProxy::requestExitFullScreen):
(WebKit::WebVideoFullscreenManagerProxy::play):
(WebKit::WebVideoFullscreenManagerProxy::pause):
(WebKit::WebVideoFullscreenManagerProxy::togglePlayState):
(WebKit::WebVideoFullscreenManagerProxy::seekToTime):
(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen):

implement WebVideoFullscreenModel to send IPC message.

  • UIProcess/WebVideoFullscreenManagerProxy.h: Added.
  • UIProcess/WebVideoFullscreenManagerProxy.messages.in: Added.

this interface closely matches WebVideoFullscreenInterface

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::supportsFullscreenForNode):
(WebKit::WebChromeClient::enterFullscreenForNode):
(WebKit::WebChromeClient::exitFullscreenForNode):

Forward these requests onto the videoFullscreenManager

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::videoFullscreenManager):

accessor for m_videoFullscreenManager

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebVideoFullscreenManager.cpp: Added.

(WebKit::WebVideoFullscreenManager::create):
(WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager):
(WebKit::WebVideoFullscreenManager::~WebVideoFullscreenManager):

add basic creation for object.

(WebKit::WebVideoFullscreenManager::supportsFullscreen):
(WebKit::WebVideoFullscreenManager::enterFullscreenForNode):
(WebKit::WebVideoFullscreenManager::exitFullscreenForNode):

implement interface called by WebChromeClient

(WebKit::WebVideoFullscreenManager::setDuration):
(WebKit::WebVideoFullscreenManager::setCurrentTime):
(WebKit::WebVideoFullscreenManager::setRate):
(WebKit::WebVideoFullscreenManager::setVideoDimensions):
(WebKit::WebVideoFullscreenManager::setVideoLayer):
(WebKit::WebVideoFullscreenManager::setVideoLayerID):
(WebKit::WebVideoFullscreenManager::enterFullscreen):
(WebKit::WebVideoFullscreenManager::exitFullscreen):

implement WebVideoFullscreenInterface to send IPC message.

  • WebProcess/WebVideoFullscreenManager.h: Added.
  • WebProcess/WebVideoFullscreenManager.messages.in: Added.

this interface closely matches WebVideoFullscreenModel

6:18 PM Changeset in webkit [163599] by jpfau@apple.com
  • 4 edits in trunk

loadSubframe can return null in SubframeLoader::loadOrRedirectSubframe
https://bugs.webkit.org/show_bug.cgi?id=128344

Reviewed by Ryosuke Niwa.

Source/WebCore:

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadOrRedirectSubframe):

LayoutTests:

6:16 PM Changeset in webkit [163598] by Lucas Forschler
  • 5 edits in tags/Safari-538.16.2/Source/JavaScriptCore

Merged r163595.

6:12 PM Changeset in webkit [163597] by andersca@apple.com
  • 13 edits in trunk/Source/WebKit2

Begin work on making preferences per page instead of per page group
https://bugs.webkit.org/show_bug.cgi?id=128349

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPageGroup.cpp:

(WKPageGroupGetPreferences):

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(WKPageIsURLKnownHSTSHost):

  • UIProcess/API/mac/WKView.mm:

(-[WKView _preferencesDidChange]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createWebPage):

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::setAttachedWindowHeight):
(WebKit::WebInspectorProxy::setAttachedWindowWidth):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::shouldOpenAttached):

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::preferences):

  • UIProcess/WebPageGroup.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::isProcessSuppressible):
(WebKit::WebPageProxy::canShowMIMEType):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::preferences):
(WebKit::WebPageProxy::setPreferences):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::windowFrameDidChange):
(WebKit::WebInspectorProxy::platformAttach):

6:04 PM Changeset in webkit [163596] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Use child iterator in HTMLDetailsElement::findMainSummary().
<https://webkit.org/b/128335>

Reviewed by Antti Koivisto.

  • html/HTMLDetailsElement.h:
  • html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::findMainSummary):

6:03 PM Changeset in webkit [163595] by msaboff@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Workaround REGRESSION(r163195-r163227): Crash beneath NSErrorUserInfoFromJSException when installing AppleInternal.mpkg
https://bugs.webkit.org/show_bug.cgi?id=128347

Reviewed by Geoffrey Garen.

Added a flag to VM class called m_ignoreStackLimit that disables stack limit checks.
We set this flag in JSContextGroupCreate() and JSGlobalContextCreateInGroup().

Disabled stack overflow tests in testapi.js since it uses these paths.

THis patch will be reverted as part of a comprehensive solution to the problem.

  • API/JSContextRef.cpp:

(JSContextGroupCreate):
(JSGlobalContextCreateInGroup):

  • API/tests/testapi.js:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::updateStackLimitWithReservedZoneSize):

  • runtime/VM.h:

(JSC::VM::ignoreStackLimit):

6:01 PM Changeset in webkit [163594] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Add missing &.

  • css/StyleInvalidationAnalysis.cpp:

(WebCore::shouldDirtyAllStyle):

6:01 PM Changeset in webkit [163593] by Lucas Forschler
  • 3 edits in tags/Safari-538.16.2/Source/WebCore

Rollout r163558.

5:58 PM Changeset in webkit [163592] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

Check selectors exactly when invalidating style
https://bugs.webkit.org/show_bug.cgi?id=128321

Reviewed by Andreas Kling.

Selectors are now really fast to match with the JIT. Take advantage of this by invalidating
the document style exactly when a new stylesheet arrives (instead of using heuristics).

This reduces need for large style recalculations in some common cases.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):

  • css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::hasMatchedRules):

  • css/RuleSet.h:

(WebCore::RuleSet::hasShadowPseudoElementRules):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

  • css/SelectorChecker.h:


Add new mode where all pseudo elements match so we can invalidate their element.

  • css/StyleInvalidationAnalysis.cpp:

(WebCore::shouldDirtyAllStyle):
(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::invalidateStyleRecursively):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):

Switch to real selector checker.

  • css/StyleInvalidationAnalysis.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):

  • css/StyleResolver.h:

(WebCore::StyleResolver::mediaQueryEvaluator):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):

5:57 PM Changeset in webkit [163591] by barraclough@apple.com
  • 15 edits in trunk/Source

Remove ChildProcess::m_activeTasks
https://bugs.webkit.org/show_bug.cgi?id=128342

Reviewed by Anders Carlson.

Currently we funnel a number of different user activities
to a single UserActivity object, which requires a call down
from WebCore to WebKit2. Split these out so we can track
them separately.

Source/WebCore:

  • page/ChromeClient.h:
    • removed [inc|dec]rementActivePageCount
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

  • incrementActivePageCount -> beginActivity

(WebCore::PageThrottler::~PageThrottler):

  • decrementActivePageCount -> endActivity

(WebCore::PageThrottler::throttlePage):

  • decrementActivePageCount -> endActivity

(WebCore::PageThrottler::unthrottlePage):

  • incrementActivePageCount -> beginActivity
  • page/PageThrottler.h:
    • Added m_pageActivity.

Source/WebKit2:

  • PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):

  • added m_connectionActivity.
  • PluginProcess/PluginProcess.h:

(WebKit::PluginProcess::connectionActivity):

  • added m_connectionActivity.
  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::didReceiveSyncMessage):
(WebKit::WebProcessConnection::destroyPlugin):
(WebKit::WebProcessConnection::createPlugin):

  • use connectionActivity
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

  • use a separate UserActivity for Java.
  • Shared/ActivityAssertion.cpp:

(WebKit::ActivityAssertion::ActivityAssertion):
(WebKit::ActivityAssertion::~ActivityAssertion):

  • Shared/ActivityAssertion.h:
    • ChildProcess -> UserActivity
  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::ChildProcess):

  • Shared/ChildProcess.h:
    • remove m_activeTasks.

(WebKit::ChildProcess::processSuppressionEnabled):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
    • removed [inc|dec]rementActivePageCount
5:56 PM Changeset in webkit [163590] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

+[JSContext currentCallee] should return the currently executing JS function
https://bugs.webkit.org/show_bug.cgi?id=122621

Reviewed by Geoffrey Garen.

It would be useful if there was a +[JSContext currentObject] API which was
callable from ObjC API callbacks. Its purpose would be to allow convenient
access to the JSValue wrapper for the currently-executing block callback.

  • API/JSContext.h:
  • API/JSContext.mm:

(+[JSContext currentCallee]):
(-[JSContext beginCallbackWithData:calleeValue:thisValue:argumentCount:arguments:]):

  • API/JSContextInternal.h:
  • API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsFunction):
(JSC::objCCallbackFunctionCallAsConstructor):

  • API/tests/testapi.mm:
5:55 PM Changeset in webkit [163589] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r163558.
http://trac.webkit.org/changeset/163558
https://bugs.webkit.org/show_bug.cgi?id=128350

Breaks scrolling on certain websites (Requested by bfulgham on
#webkit).

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

  • page/WheelEventDeltaTracker.h:
5:33 PM Changeset in webkit [163588] by psolanki@apple.com
  • 3 edits
    1 add in trunk/Source/WebKit2

[iOS] WebKit2 can't access the GPU
https://bugs.webkit.org/show_bug.cgi?id=128345
<rdar://problem/15976084>

Reviewed by Tim Horton.

Add an entitlement to allow web process to access GPU.

  • Configurations/WebContent-iOS.entitlements: Added.
  • Configurations/WebContentService.Development.xcconfig:
  • Configurations/WebContentService.xcconfig:
5:30 PM Changeset in webkit [163587] by psolanki@apple.com
  • 5 edits in trunk/Source/WebKit2

[iOS][WebKit2] Remove JoinExistingSession from plist
https://bugs.webkit.org/show_bug.cgi?id=128318
<rdar://problem/15971612>

Reviewed by Tim Horton.

Remove JoinExistingSession key that is not available on iOS.

  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
5:29 PM Changeset in webkit [163586] by Chris Fleizach
  • 5 edits in trunk/Source/WebCore

AX: Crash in WebCore::AXObjectCache::computedObjectAttributeCache
https://bugs.webkit.org/show_bug.cgi?id=128310

Reviewed by Alexey Proskuryakov.

Be more careful about using axObjectCache() directly since it can return null.
I audited the usage cases of this method and ensured the ptr was not null in cases
where I thought we might get hit by this.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::parentObject):
(WebCore::AccessibilityNodeObject::menuForMenuButton):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
(WebCore::AccessibilityObject::findMatchingObjects):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
(WebCore::AccessibilityObject::axObjectCache):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
(WebCore::AccessibilityObject::accessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
(WebCore::AccessibilityRenderObject::nodeIsTextControl):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
(WebCore::AccessibilityRenderObject::observableObject):
(WebCore::AccessibilityRenderObject::textChanged):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::addChildScrollbar):
(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

5:21 PM Changeset in webkit [163585] by zoltan@webkit.org
  • 6 edits
    2 adds in trunk

[CSS Shapes] Rounded Insets Let Content Overlap Shape
https://bugs.webkit.org/show_bug.cgi?id=127852

Reviewed by Bem Jones-Bey.

Source/WebCore:

Using LengthSize to FloatSize conversion from LengthSize.h lead to miscalculated
inset border radius, when the border radius was defined by percentages. This patch
fixes the behavior and removes the incorrect conversion.

Test: fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html

  • css/LengthFunctions.cpp:

(WebCore::floatSizeForLengthSize): Add new helper function for LengthSize to FloatSize conversion.

  • css/LengthFunctions.h:
  • platform/LengthSize.h: Remove floatSize conversion.
  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape): Use new helper function to calculate the right with for the inset border radius.

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-rounded-inset-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-rounded-inset.html: Added.
5:18 PM Changeset in webkit [163584] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix iOS builds after r163574

  • API/JSManagedValue.h:
5:17 PM Changeset in webkit [163583] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

5:13 PM Changeset in webkit [163582] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.15

New Tag.

5:00 PM Changeset in webkit [163581] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Regenerate JSTestObj now that ScriptArguments moved. Generator knows what to do.

Rubber-stamped by Zalan Bujtas.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):

4:58 PM Changeset in webkit [163580] by Lucas Forschler
  • 2 edits in branches/safari-537.60-branch/Source/WebKit/win

Merged r163557.

4:54 PM Changeset in webkit [163579] by jpfau@apple.com
  • 6 edits
    6 adds in trunk

Make adoption agency use the task queue
https://bugs.webkit.org/show_bug.cgi?id=109445

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: fast/parser/adoption-agency-crash-01.html

fast/parser/adoption-agency-crash-02.html
fast/parser/adoption-agency-crash-03.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
(WebCore::executeInsertTask):
(WebCore::executeReparentTask):
(WebCore::executeInsertAlreadyParsedChildTask):
(WebCore::executeTakeAllChildrenTask):
(WebCore::executeTask):
(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::executeQueuedTasks):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::reparent):
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild):
(WebCore::HTMLConstructionSite::takeAllChildren):
(WebCore::HTMLConstructionSite::fosterParent):

  • html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSiteTask::HTMLConstructionSiteTask):
(WebCore::HTMLConstructionSiteTask::oldParent):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

LayoutTests:

  • TestExpectations:
  • fast/parser/adoption-agency-crash-01-expected.txt: Added.
  • fast/parser/adoption-agency-crash-01.html: Added.
  • fast/parser/adoption-agency-crash-02-expected.txt: Added.
  • fast/parser/adoption-agency-crash-02.html: Added.
  • fast/parser/adoption-agency-crash-03-expected.txt: Added.
  • fast/parser/adoption-agency-crash-03.html: Added.
4:51 PM Changeset in webkit [163578] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _remoteObjectRegistry]):

4:50 PM Changeset in webkit [163577] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the setter definition from r163514.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-06

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
4:42 PM Changeset in webkit [163576] by mhahnenberg@apple.com
  • 20 edits
    1 copy in trunk/Source

Heap::writeBarrier shouldn't be static
https://bugs.webkit.org/show_bug.cgi?id=127807

Reviewed by Geoffrey Garen.

Currently it looks up the Heap in which to fire the write barrier by using
the cell passed to it. Almost every call site already has a reference to the
VM or the Heap itself. It seems wasteful to look it up all over again.

Source/JavaScriptCore:

(JSC::CopyWriteBarrier::set):

  • heap/Heap.cpp:

(JSC::Heap::writeBarrier):

  • heap/Heap.h:

(JSC::Heap::writeBarrier):

  • jit/JITOperations.cpp:
  • jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::set):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

  • runtime/Arguments.h:
  • runtime/JSWeakMap.cpp:
  • runtime/MapData.cpp:

(JSC::MapData::ensureSpaceForAppend):

  • runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

  • runtime/Structure.h:
  • runtime/WriteBarrier.h:
  • runtime/WriteBarrierInlines.h: Added.

Source/WebCore:

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

4:33 PM Changeset in webkit [163575] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit

Unreviewed Windows Build Fix after r163568.

Remove old symbol export. It is now const. Waiting for bot to produce new symbol.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
4:29 PM Changeset in webkit [163574] by mhahnenberg@apple.com
  • 7 edits
    1 add in trunk/Source/JavaScriptCore

JSManagedValue should automatically call removeManagedReference:withOwner: upon dealloc
https://bugs.webkit.org/show_bug.cgi?id=124053

Reviewed by Geoffrey Garen.

  • API/JSManagedValue.h:
  • API/JSManagedValue.mm:

(+[JSManagedValue managedValueWithValue:andOwner:]):
(-[JSManagedValue initWithValue:]):
(-[JSManagedValue dealloc]):
(-[JSManagedValue didAddOwner:]):
(-[JSManagedValue didRemoveOwner:]):

  • API/JSManagedValueInternal.h: Added.
  • API/JSVirtualMachine.mm:

(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):

  • API/WebKitAvailability.h:
  • API/tests/testapi.mm:

(-[TextXYZ click]):

4:29 PM Changeset in webkit [163573] by ljaehun.lim@samsung.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, fix build error on 64bit debug build

Apply static_cast<long long> to int64_t variable when '%lli' is used.

  • Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::clearObjectStore):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setActive):

4:28 PM Changeset in webkit [163572] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] Remove duplicate call to RunLoop::initializeMainRunLoop
https://bugs.webkit.org/show_bug.cgi?id=128328

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-06
Reviewed by Dan Bernstein.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithFrame:configuration:]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

4:25 PM Changeset in webkit [163571] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/Source/WebKit/win

Merge r163557.

2014-02-06 Brent Fulgham <Brent Fulgham>

[Win] Correct IME Regression after r141479
https://bugs.webkit.org/show_bug.cgi?id=128323
<rdar://problem/15952986>

Reviewed by Tim Horton.

  • WebView.cpp: (WebView::updateSelectionForIME): Refactoring flipped the meaning of the test used to select the resetIME case. Corrected for behavior of new cancel method.
4:03 PM Changeset in webkit [163570] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add support for multiple sources for AutoInstaller
https://bugs.webkit.org/show_bug.cgi?id=124848

Patch by Jozsef Berta <jberta.u-szeged@partner.samsung.com> on 2014-02-06
Reviewed by Ryosuke Niwa.

The autoinstaller in the webkitpy currently fails if the download source of a package is unavailable.
This patch adds support for multiple sources to the script. The sources are provided in three environment variables.
If it exists, the script will look at a local cache. If not, it will try to download the package from the original url.
If it fails, it gets a mirror from the corresponding environment variable.(One for sourceforge.org and one for pypi.python.org)

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._copy_unpackaged_files_from_local_cache): If the package is not packaged in its original form,
this method will copy it to the scratch directory. Otherwise it would be deleted from the cache, which we do not want.
(AutoInstaller._prepare_package): If the package is not zipped or tarred, and the file is in the cache, the
_copy_unpackaged_files_from_local_cache function is called.
(AutoInstaller._parse_colon_separated_mirrors_from_env): This will read the mirrors from the environment variables if possible,
and prepares them for further use.
(AutoInstaller):
(AutoInstaller._replace_domain_with_next_mirror): If the original download url fails, it is replaced by a mirror provided
in the environment variables. The function identifies the original source, and replaces it with a mirror. If it can't be done,
the return url will be None, indicating that no mirrors are provided, or none of them could be reached.
(AutoInstaller._download_to_stream): The timeout for one try is now limited to 30 seconds. Without this, the script waited for
roughly 4 minutes before retrying. After three failiures the script will try to switch to a mirror.
(AutoInstaller._check_package_in_local_autoinstall_cache): This method searches the cache for the currently downloaded module.
If it's found there, its path is returned.
(AutoInstaller._download): Before downloading the module, it is looked up in the cache. If it's not found there,
the script will continue with the download, and cache the module.

3:45 PM Changeset in webkit [163569] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

[iOS] Set UIProcess pid in WebProcess initialization for Remote Inspector
https://bugs.webkit.org/show_bug.cgi?id=128338

Reviewed by Sam Weinig.

  • WebProcess/ios/WebProcessIOS.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:45 PM Changeset in webkit [163568] by Joseph Pecoraro
  • 135 edits
    3 copies
    15 moves
    10 adds
    2 deletes in trunk

Web Inspector: Add Console support to JSContext Inspection
https://bugs.webkit.org/show_bug.cgi?id=127941

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:

Add new files.

  • inspector/agents/InspectorConsoleAgent.cpp: Renamed from Source/WebCore/inspector/InspectorConsoleAgent.cpp.
  • inspector/agents/InspectorConsoleAgent.h: Added.

New agent moved from WebCore. Rename a method to work in JS only context.

  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
Instantiate ConsoleAgent.

  • inspector/agents/JSGlobalObjectConsoleAgent.h: Copied from Source/WebCore/inspector/PageInjectedScriptHost.h.
  • inspector/agents/JSGlobalObjectConsoleAgent.cpp: Copied from Source/WebCore/inspector/PageInjectedScriptHost.h.

(Inspector::JSGlobalObjectConsoleAgent::JSGlobalObjectConsoleAgent):
(Inspector::JSGlobalObjectConsoleAgent::setMonitoringXHREnabled):
(Inspector::JSGlobalObjectConsoleAgent::addInspectedNode):
(Inspector::JSGlobalObjectConsoleAgent::addInspectedHeapObject):
JSGlobalObject implementation.

  • inspector/agents/JSGlobalObjectDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::JSGlobalObjectDebuggerAgent):
(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):
Use ConsoleAgent to report logs.

  • inspector/ConsoleMessage.cpp: Renamed from Source/WebCore/inspector/ConsoleMessage.cpp.
  • inspector/ConsoleMessage.h: Renamed from Source/WebCore/inspector/ConsoleMessage.h.
  • inspector/ConsoleTypes.h: Copied from Source/WebCore/inspector/ConsoleAPITypes.h.
  • inspector/IdentifiersFactory.cpp: Renamed from Source/WebCore/inspector/IdentifiersFactory.cpp.
  • inspector/IdentifiersFactory.h: Renamed from Source/WebCore/inspector/IdentifiersFactory.h.
  • inspector/ScriptArguments.cpp: Renamed from Source/WebCore/inspector/ScriptArguments.cpp.
  • inspector/ScriptArguments.h: Renamed from Source/WebCore/inspector/ScriptArguments.h.
  • inspector/ScriptCallFrame.cpp: Renamed from Source/WebCore/inspector/ScriptCallFrame.cpp.
  • inspector/ScriptCallFrame.h: Renamed from Source/WebCore/inspector/ScriptCallFrame.h.
  • inspector/ScriptCallStack.cpp: Renamed from Source/WebCore/inspector/ScriptCallStack.cpp.
  • inspector/ScriptCallStack.h: Renamed from Source/WebCore/inspector/ScriptCallStack.h.
  • inspector/ScriptCallStackFactory.cpp: Renamed from Source/WebCore/bindings/js/ScriptCallStackFactory.cpp.
  • inspector/ScriptCallStackFactory.h: Renamed from Source/WebCore/bindings/js/ScriptCallStackFactory.h.
  • inspector/protocol/Console.json: Renamed from Source/WebCore/inspector/protocol/Console.json.
  • inspector/scripts/generate-combined-inspector-json.py:

Source/WebCore:

  • Move InspectorConsoleAgent and dependencies to JavaScriptCore and into the Inspector namespace.
  • Update Console Message enum types to enum classes and update all users to the new, simpler names.
  • Since we are updating addConsoleMessage callsites anyways, add ASCIILiteral where appropriate.
  • Add WebConsoleAgent base of Page/Worker ConsoleAgent to implement what could not be pushed into JavaScriptCore.
  • CMakeLists.txt:
  • DerivedSources.make:
  • ForwardingHeaders/inspector/ConsoleMessage.h: Added.
  • ForwardingHeaders/inspector/ConsoleTypes.h: Added.
  • ForwardingHeaders/inspector/IdentifiersFactory.h: Added.
  • ForwardingHeaders/inspector/ScriptArguments.h: Added.
  • ForwardingHeaders/inspector/ScriptCallFrame.h: Added.
  • ForwardingHeaders/inspector/ScriptCallStack.h: Added.
  • ForwardingHeaders/inspector/ScriptCallStackFactory.h: Added.
  • ForwardingHeaders/inspector/agents/InspectorConsoleAgent.h: Added.
  • GNUmakefile.am:
  • GNUmakefile.list.am:

Add / remove files from builds.

  • inspector/WebConsoleAgent.h:
  • inspector/WebConsoleAgent.cpp: Added.

(WebCore::WebConsoleAgent::WebConsoleAgent):
(WebCore::WebConsoleAgent::setMonitoringXHREnabled):
(WebCore::WebConsoleAgent::frameWindowDiscarded):
(WebCore::WebConsoleAgent::didFinishXHRLoading):
(WebCore::WebConsoleAgent::didReceiveResponse):
(WebCore::WebConsoleAgent::didFailLoading):
(WebCore::WebConsoleAgent::addInspectedHeapObject):
Implement what could not be pushed down into JavaScriptCore.

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::webConsoleAgent):
(WebCore::InstrumentingAgents::setWebConsoleAgent):
Hold a WebConsoleAgent instead of InspectorConsoleAgent.

  • Modules/indexeddb/IDBCursor.cpp:
  • Modules/indexeddb/IDBDatabase.cpp:
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/quota/DOMWindowQuota.cpp:

(WebCore::DOMWindowQuota::webkitStorageInfo):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::setPanningModel):

  • Modules/webdatabase/DatabaseBase.cpp:

(WebCore::DatabaseBase::logErrorMessage):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::logErrorMessage):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
(WebCore::WebSocket::close):
(WebCore::WebSocket::setBinaryType):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):
(WebCore::WebSocketChannel::didFailSocketStream):

  • Modules/websockets/WebSocketHandshake.cpp:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContextConstructor::constructJSAudioContext):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

  • bindings/scripts/test/JS/JSTestObj.cpp:
  • css/CSSParser.cpp:

(WebCore::CSSParser::logError):

  • css/MediaList.cpp:

(WebCore::addResolutionWarningMessageToConsole):

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::addMessage):

  • dom/Document.h:
  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):
(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptExecutionContext.h:
  • dom/ViewportArguments.cpp:

(WebCore::viewportErrorMessageLevel):
(WebCore::reportViewportWarning):

  • fileapi/Blob.cpp:
  • fileapi/WebKitBlobBuilder.cpp:
  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::printWarningToConsole):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

  • inspector/CommandLineAPIHost.cpp:
  • inspector/CommandLineAPIHost.h:

(WebCore::CommandLineAPIHost::init):

  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorConsoleAgent.h: Removed.
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleTimeStamp):
(WebCore::InspectorInstrumentation::addProfile):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameWindowDiscardedImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::isConsoleAssertMessage):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::consoleCountImpl):
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
(WebCore::InspectorInstrumentation::consoleAgentEnabled):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorLayerTreeAgent.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • inspector/InspectorTimelineAgent.cpp:
  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):

  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::clearMessages):
(WebCore::PageConsoleAgent::addInspectedNode):

  • inspector/PageConsoleAgent.h:
  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

  • inspector/PageInjectedScriptHost.h:
  • inspector/PageInjectedScriptManager.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::WebConsoleAgent::~WebConsoleAgent):

  • inspector/WorkerConsoleAgent.cpp:

(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
(WebCore::WorkerConsoleAgent::addInspectedNode):

  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::breakpointActionLog):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::reportLocalLoadFailed):
(WebCore::FrameLoader::handleBeforeUnloadEvent):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::createWindow):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::corsPolicyPreventedLoad):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):
(WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/ChromeClient.h:
  • page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::debug):
(WebCore::Console::error):
(WebCore::Console::log):
(WebCore::Console::warn):
(WebCore::Console::dir):
(WebCore::Console::dirxml):
(WebCore::Console::table):
(WebCore::Console::clear):
(WebCore::Console::trace):
(WebCore::Console::assertCondition):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):

  • page/Console.h:
  • page/ConsoleTypes.h: Removed.
  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):
(WebCore::ContentSecurityPolicy::logToConsole):

  • page/DOMSecurityPolicy.cpp:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
(WebCore::DOMWindow::close):
(WebCore::DOMWindow::printErrorMessage):

  • page/DOMWindow.h:
  • page/EventSource.cpp:

(WebCore::EventSource::didReceiveResponse):
(WebCore::EventSource::didFailAccessControlCheck):

  • page/PageConsole.cpp:

(WebCore::PageConsole::printMessageSourceAndLevelPrefix):
(WebCore::PageConsole::addMessage):

  • page/PageConsole.h:
  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

  • platform/CrossThreadCopier.h:
  • rendering/shapes/ShapeInfo.cpp:

(WebCore::checkShapeImageOrigin):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):
(WebCore::SVGDocumentExtensions::reportWarning):
(WebCore::SVGDocumentExtensions::reportError):

  • testing/Internals.cpp:

(WebCore::Internals::consoleMessageArgumentCounts):

  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::SharedWorkerGlobalScope::logExceptionToConsole):

  • workers/SharedWorkerGlobalScope.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerMessagingProxy.cpp:
  • workers/WorkerReportingProxy.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::logConsoleError):
(WebCore::XMLHttpRequest::send):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):

Source/WebInspectorUI:

  • UserInterface/InspectorJSBackendCommands.js:
  • UserInterface/InspectorWebBackendCommands.js:

ConsoleAgent moved to JavaScript section.

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::addMessageToConsole):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(stringForMessageSource):
(stringForMessageLevel):
(WebChromeClient::addMessageToConsole):

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

  • inspector-protocol/page/deny-X-FrameOption-expected.txt:

Update with better line/column numbers now.

3:29 PM Changeset in webkit [163567] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add preferences property to WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=128337

Reviewed by Sam Weinig.

Also use RetainPtr for processClass and preferences so we won't leak them.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration processClass]):
(-[WKWebViewConfiguration setProcessClass:]):
(-[WKWebViewConfiguration preferences]):
(-[WKWebViewConfiguration setPreferences:]):

3:24 PM Changeset in webkit [163566] by benjamin@webkit.org
  • 2 edits
    1 delete in trunk/Tools

Remove run-test-webkit-api
https://bugs.webkit.org/show_bug.cgi?id=118145

Reviewed by Csaba Osztrogonác.

Having two scripts doing the same thing is confusing. There are also cases failing
on run-test-webkit-api since it does not restart a new process for each test.

  • Scripts/run-test-webkit-api: Removed.
  • Scripts/webkitdirs.pm:
3:06 PM Changeset in webkit [163565] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Convert a parameter to PassRefPtr
https://bugs.webkit.org/show_bug.cgi?id=128327

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-06
Reviewed by Timothy Hatcher.

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addProfile):

  • inspector/InspectorInstrumentation.h:
2:40 PM Changeset in webkit [163564] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add a remoteObjectRegistry property to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128331

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView resizeSubviewsWithOldSize:]):
(-[WKWebView _remoteObjectRegistry]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
2:04 PM Changeset in webkit [163563] by andersca@apple.com
  • 5 edits
    3 copies in trunk/Source/WebKit2

Add WKNavigationResponse class
https://bugs.webkit.org/show_bug.cgi?id=128326

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKFrameInfo.mm:

(-[WKFrameInfo initWithWebFrameProxy:WebKit::]):

  • UIProcess/API/Cocoa/WKFrameInfoInternal.h:
  • UIProcess/API/Cocoa/WKNavigationResponse.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm.
  • UIProcess/API/Cocoa/WKNavigationResponse.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm.

(-[WKNavigationResponse frame]):
(-[WKNavigationResponse setFrame:]):
(-[WKNavigationResponse response]):
(-[WKNavigationResponse setResponse:]):

  • UIProcess/API/Cocoa/WKNavigationResponseInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h.
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):

  • WebKit2.xcodeproj/project.pbxproj:
1:53 PM Changeset in webkit [163562] by oliver@apple.com
  • 41 edits in trunk

Push DOM attributes into the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=127969

Reviewed by Mark Lam.

Source/WebCore:

This patch does the actual work of moving dom attributes up the
prototype chain. There are still a few class and edge cases
where we can't do this without impacting existing behaviour,
but they can be fixed separately in later patches.

  • bindings/js/JSDOMBinding.h:

(WebCore::getStaticPropertySlotEntryWithoutCaching):
(WebCore::getStaticPropertySlotEntryWithoutCaching<JSDOMWrapper>):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(HasComplexGetOwnProperty):
(ConstructorShouldBeOnInstance):
(AttributeShouldBeOnInstance):
(InstanceAttributeCount):
(PrototypeAttributeCount):
(InstanceOverridesGetOwnPropertySlot):
(PrototypeOverridesGetOwnPropertySlot):
(GenerateAttributesHashTable):
(GenerateImplementation):

LayoutTests:

Update layout test results

  • fast/dom/wrapper-classes-expected.txt:
  • js/dom/constructor-attributes-expected.txt:
  • js/dom/dom-static-property-for-in-iteration-expected.txt:
  • js/dom/script-tests/constructor-attributes.js:
1:35 PM Changeset in webkit [163561] by Lucas Forschler
  • 3 edits in tags/Safari-538.16.2/Source/WebCore

Merged r163558.

1:24 PM Changeset in webkit [163560] by akling@apple.com
  • 38 edits
    29 deletes in trunk

Remove display:run-in support.
<https://webkit.org/b/127874>
<rdar://problem/15926949>

Source/WebCore:

Remove support for the "run-in" display type. Blink recently removed
this and Gecko never supported in the first place.

Rubber-stamped by Anders Carlsson.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSValueKeywords.in:
  • css/StyleResolver.cpp:

(WebCore::equivalentBlockDisplay):
(WebCore::doesNotInheritTextDecoration):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::renderName):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::shouldCheckLines):
(WebCore::getHeightForLineCount):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):
(WebCore::RenderElement::destroyLeftoverChildren):

  • rendering/RenderFileUploadControl.cpp:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateFromStyle):
(WebCore::RenderInline::renderName):
(WebCore::RenderInline::clippedOverflowRectForRepaint):

  • rendering/RenderListBox.cpp:
  • rendering/RenderListBox.h:
  • rendering/RenderMenuList.cpp:
  • rendering/RenderMenuList.h:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderProgress.cpp:
  • rendering/RenderProgress.h:
  • rendering/RenderSlider.cpp:
  • rendering/RenderSlider.h:
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle):

  • rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

Rubber-stamped by Anders Carlsson.

  • UserInterface/CSSKeywordCompletions.js:
  • UserInterface/External/CodeMirror/css.js:

LayoutTests:

Rubber-stamped by Anders Carlsson.

  • editing/undo/undo-after-event-edited.html:
  • fast/css-generated-content/generated-runin-expected.html: Removed.
  • fast/css-generated-content/generated-runin.html: Removed.
  • fast/lists/parent-box-not-box-crash-expected.txt: Removed.
  • fast/lists/parent-box-not-box-crash.html: Removed.
  • fast/multicol/span/runin-continuation-crash-expected.txt: Removed.
  • fast/multicol/span/runin-continuation-crash.html: Removed.
  • fast/runin/001.html: Removed.
  • fast/runin/002.html: Removed.
  • fast/runin/crash-when-reparent-sibling-expected.txt: Removed.
  • fast/runin/crash-when-reparent-sibling.html: Removed.
  • fast/runin/generated-content-crash-expected.png: Removed.
  • fast/runin/generated-content-crash-expected.txt: Removed.
  • fast/runin/generated-content-crash.html: Removed.
  • fast/runin/generated.html: Removed.
  • fast/runin/generated2.html: Removed.
  • fast/runin/generated3.html: Removed.
  • fast/runin/generated4.html: Removed.
  • fast/runin/input-text-runin-expected.txt: Removed.
  • fast/runin/input-text-runin.html: Removed.
  • fast/runin/insert-before-run-in-expected.png: Removed.
  • fast/runin/insert-before-run-in-expected.txt: Removed.
  • fast/runin/insert-before-run-in.html: Removed.
  • fast/runin/move-run-in-original-position-crash-expected.png: Removed.
  • fast/runin/move-run-in-original-position-crash-expected.txt: Removed.
  • fast/runin/move-run-in-original-position-crash.html: Removed.
  • fast/runin/nonblock-runin-expected.txt: Removed.
  • fast/runin/nonblock-runin.html: Removed.
  • fast/runin/progress-run-in-crash-expected.txt: Removed.
  • fast/runin/progress-run-in-crash.html: Removed.
  • fast/runin/run-in-after-run-in-expected.png: Removed.
  • fast/runin/run-in-after-run-in-expected.txt: Removed.
  • fast/runin/run-in-after-run-in.html: Removed.
  • fast/runin/run-in-layer-not-removed-crash-expected.txt: Removed.
  • fast/runin/run-in-layer-not-removed-crash.html: Removed.
  • fast/runin/run-in-parent-add-child-expected.png: Removed.
  • fast/runin/run-in-parent-add-child-expected.txt: Removed.
  • fast/runin/run-in-parent-add-child.html: Removed.
  • fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Removed.
  • fast/runin/run-in-parent-block-child-add-and-intrude-expected.txt: Removed.
  • fast/runin/run-in-parent-block-child-add-and-intrude.html: Removed.
  • fast/runin/run-in-parent-block-child-add-expected.png: Removed.
  • fast/runin/run-in-parent-block-child-add-expected.txt: Removed.
  • fast/runin/run-in-parent-block-child-add.html: Removed.
  • fast/runin/runin-between-list-marker-and-before-content-expected.png: Removed.
  • fast/runin/runin-between-list-marker-and-before-content-expected.txt: Removed.
  • fast/runin/runin-between-list-marker-and-before-content.html: Removed.
  • fast/runin/runin-continuations-crash-expected.txt: Removed.
  • fast/runin/runin-continuations-crash.html: Removed.
  • fast/runin/runin-div-before-child-expected.png: Removed.
  • fast/runin/runin-div-before-child-expected.txt: Removed.
  • fast/runin/runin-div-before-child.html: Removed.
  • fast/runin/runin-generated-before-content-expected.png: Removed.
  • fast/runin/runin-generated-before-content-expected.txt: Removed.
  • fast/runin/runin-generated-before-content.html: Removed.
  • fast/runin/runin-into-div-with-float-child-expected.png: Removed.
  • fast/runin/runin-into-div-with-float-child-expected.txt: Removed.
  • fast/runin/runin-into-div-with-float-child.html: Removed.
  • fast/runin/runin-not-go-into-float-expected.png: Removed.
  • fast/runin/runin-not-go-into-float-expected.txt: Removed.
  • fast/runin/runin-not-go-into-float.html: Removed.
  • fast/runin/runin-remove-child-simple-expected.txt: Removed.
  • fast/runin/runin-remove-child-simple.html: Removed.
  • fast/runin/runin-reparent-crash-expected.txt: Removed.
  • fast/runin/runin-reparent-crash.html: Removed.
  • fast/runin/runin-sibling-inline-expected.txt: Removed.
  • fast/runin/runin-sibling-inline.html: Removed.
  • fast/runin/runin-table-before-child-expected.png: Removed.
  • fast/runin/runin-table-before-child-expected.txt: Removed.
  • fast/runin/runin-table-before-child.html: Removed.
  • fast/runin/select-runin-expected.txt: Removed.
  • fast/runin/select-runin.html: Removed.
  • fast/runin/textarea-runin-expected.txt: Removed.
  • fast/runin/textarea-runin.html: Removed.
  • fast/table/form-with-table-style.html: Removed.
  • platform/efl/fast/runin/001-expected.png: Removed.
  • platform/efl/fast/runin/001-expected.txt: Removed.
  • platform/efl/fast/runin/002-expected.png: Removed.
  • platform/efl/fast/runin/002-expected.txt: Removed.
  • platform/efl/fast/runin/generated-expected.png: Removed.
  • platform/efl/fast/runin/generated-expected.txt: Removed.
  • platform/efl/fast/runin/generated2-expected.png: Removed.
  • platform/efl/fast/runin/generated2-expected.txt: Removed.
  • platform/efl/fast/runin/generated3-expected.png: Removed.
  • platform/efl/fast/runin/generated3-expected.txt: Removed.
  • platform/efl/fast/runin/generated4-expected.png: Removed.
  • platform/efl/fast/runin/generated4-expected.txt: Removed.
  • platform/efl/fast/runin/runin-generated-before-content-expected.png: Removed.
  • platform/gtk/fast/runin/001-expected.png: Removed.
  • platform/gtk/fast/runin/001-expected.txt: Removed.
  • platform/gtk/fast/runin/002-expected.png: Removed.
  • platform/gtk/fast/runin/002-expected.txt: Removed.
  • platform/gtk/fast/runin/generated-content-crash-expected.png: Removed.
  • platform/gtk/fast/runin/generated-expected.png: Removed.
  • platform/gtk/fast/runin/generated-expected.txt: Removed.
  • platform/gtk/fast/runin/generated2-expected.png: Removed.
  • platform/gtk/fast/runin/generated2-expected.txt: Removed.
  • platform/gtk/fast/runin/generated3-expected.png: Removed.
  • platform/gtk/fast/runin/generated3-expected.txt: Removed.
  • platform/gtk/fast/runin/generated4-expected.png: Removed.
  • platform/gtk/fast/runin/generated4-expected.txt: Removed.
  • platform/gtk/fast/runin/insert-before-run-in-expected.png: Removed.
  • platform/gtk/fast/runin/move-run-in-original-position-crash-expected.png: Removed.
  • platform/gtk/fast/runin/run-in-after-run-in-expected.png: Removed.
  • platform/gtk/fast/runin/run-in-parent-add-child-expected.png: Removed.
  • platform/gtk/fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Removed.
  • platform/gtk/fast/runin/run-in-parent-block-child-add-expected.png: Removed.
  • platform/gtk/fast/runin/runin-between-list-marker-and-before-content-expected.png: Removed.
  • platform/gtk/fast/runin/runin-div-before-child-expected.png: Removed.
  • platform/gtk/fast/runin/runin-generated-before-content-expected.png: Removed.
  • platform/gtk/fast/runin/runin-into-div-with-float-child-expected.png: Removed.
  • platform/gtk/fast/runin/runin-not-go-into-float-expected.png: Removed.
  • platform/gtk/fast/runin/runin-table-before-child-expected.png: Removed.
  • platform/mac/fast/runin/001-expected.png: Removed.
  • platform/mac/fast/runin/001-expected.txt: Removed.
  • platform/mac/fast/runin/002-expected.png: Removed.
  • platform/mac/fast/runin/002-expected.txt: Removed.
  • platform/mac/fast/runin/generated-expected.png: Removed.
  • platform/mac/fast/runin/generated-expected.txt: Removed.
  • platform/mac/fast/runin/generated2-expected.png: Removed.
  • platform/mac/fast/runin/generated2-expected.txt: Removed.
  • platform/mac/fast/runin/generated3-expected.png: Removed.
  • platform/mac/fast/runin/generated3-expected.txt: Removed.
  • platform/mac/fast/runin/generated4-expected.png: Removed.
  • platform/mac/fast/runin/generated4-expected.txt: Removed.
  • platform/win/fast/runin/nonblock-runin-expected.txt: Removed.
1:20 PM Changeset in webkit [163559] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Remove leftover cruft from scoped stylesheet implementation.
<https://webkit.org/b/128139>

Kill some pointless non-null checks that were left behind by the
removed <style scoped> code. Also pruned outdated comments and
FIXME's about such scopes.

Reviewed by Antti Koivisto.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::addRulesFromSheet):

  • css/RuleSet.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::checkRegionStyle):

12:43 PM Changeset in webkit [163558] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

Wheel events don't latch to inner scrollable elements
https://bugs.webkit.org/show_bug.cgi?id=128225

Reviewed by Beth Dakin.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent): Identify the case
where we have hit the end of a scroll, and treat that as a
valid 'handled' case. If the scroll event is just starting,
treat end-of-scroll as unhandled so the parent element can
handle things.

  • page/WheelEventDeltaTracker.h:

(WebCore::WheelEventDeltaTracker::isFirstWheelEvent): Added.

12:38 PM Changeset in webkit [163557] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit/win

[Win] Correct IME Regression after r141479
https://bugs.webkit.org/show_bug.cgi?id=128323
<rdar://problem/15952986>

Reviewed by Tim Horton.

  • WebView.cpp:

(WebView::updateSelectionForIME): Refactoring flipped the meaning of the test used
to select the resetIME case. Corrected for behavior of new cancel method.

12:22 PM Changeset in webkit [163556] by commit-queue@webkit.org
  • 20 edits
    1 delete in trunk/Source

Unreviewed, rolling out r163542.
http://trac.webkit.org/changeset/163542
https://bugs.webkit.org/show_bug.cgi?id=128324

Caused many assertion failures (Requested by ap on #webkit).

Source/JavaScriptCore:

(JSC::CopyWriteBarrier::set):

  • heap/Heap.cpp:

(JSC::Heap::writeBarrier):

  • heap/Heap.h:

(JSC::Heap::writeBarrier):

  • jit/JITOperations.cpp:
  • jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::set):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

  • runtime/Arguments.h:
  • runtime/JSWeakMap.cpp:
  • runtime/MapData.cpp:

(JSC::MapData::ensureSpaceForAppend):

  • runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

  • runtime/Structure.h:
  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::set):
(JSC::WriteBarrierBase::setMayBeNull):
(JSC::WriteBarrierBase::setEarlyValue):
(JSC::WriteBarrierBase<Unknown>::set):

  • runtime/WriteBarrierInlines.h: Removed.

Source/WebCore:

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

12:17 PM Changeset in webkit [163555] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Replace ’ with ' to silence the check-for-webkit-framework-include-consistency script.

  • UIProcess/API/Cocoa/WKWebView.h:
12:05 PM Changeset in webkit [163554] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add backForwardList property to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128320

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView backForwardList]):

12:00 PM Changeset in webkit [163553] by commit-queue@webkit.org
  • 14 edits
    4 adds in trunk

Do not draw multi-characters <mi> in italic.
https://bugs.webkit.org/show_bug.cgi?id=44208

Patch by Frédéric Wang <fred.wang@free.fr> on 2014-02-06
Reviewed by Chris Fleizach.

Source/WebCore:

This test prevents multi-char <mi> to be drawn in italic and prepare
further improvements to MathML token and mfenced elements (bugs 124838
and bug 99620).

Test: mathml/presentation/tokenElements-dynamic.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/mathml.css:

(mi, mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot, merror, mphantom, mstyle, menclose):

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::didAttachRenderers):
(WebCore::MathMLTextElement::childrenChanged):
(WebCore::MathMLTextElement::createElementRenderer):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLToken):

  • rendering/mathml/RenderMathMLToken.cpp: Added.

(WebCore::RenderMathMLToken::RenderMathMLToken):
(WebCore::RenderMathMLToken::addChild):
(WebCore::RenderMathMLToken::createWrapperIfNeeded):
(WebCore::RenderMathMLToken::updateTokenContent):
(WebCore::RenderMathMLToken::updateStyle):
(WebCore::RenderMathMLToken::styleDidChange):
(WebCore::RenderMathMLToken::updateFromElement):

  • rendering/mathml/RenderMathMLToken.h: Added.

(WebCore::RenderMathMLToken::element):
(WebCore::RenderMathMLToken>):

LayoutTests:

Add tests for single-char/multi-char <mi> elements, the mathvariant
attribute and MathML token elements dynamically modified.

  • mathml/presentation/attributes-mathvariant-expected.html:
  • mathml/presentation/attributes-mathvariant.html:
  • mathml/presentation/tokenElements-dynamic-expected.html: Added.
  • mathml/presentation/tokenElements-dynamic.html: Added.
  • mathml/presentation/tokenElements-mathvariant-expected.html:
  • mathml/presentation/tokenElements-mathvariant.html:
11:34 AM Changeset in webkit [163552] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shapes] Simplify BasicShapeInset creation
https://bugs.webkit.org/show_bug.cgi?id=128314

Reviewed by David Hyatt.

Introduce convertToLengthSize helper function in order to simplify and make BasicShapeInset more readable.

No new tests, no behavior change.

  • css/BasicShapeFunctions.cpp:

(WebCore::convertToLengthSize):
(WebCore::basicShapeForValue):

11:26 AM Changeset in webkit [163551] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

The source frame request is not the same thing as the original request
https://bugs.webkit.org/show_bug.cgi?id=128317

Reviewed by Andreas Kling.

Grab the source frame URL From the WebFrameProxy object.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::frameInfoFromWebFrameProxy):
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

10:54 AM Changeset in webkit [163550] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Windows build.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

10:45 AM Changeset in webkit [163549] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Make 32bit pass the correct this value to custom getters
https://bugs.webkit.org/show_bug.cgi?id=128313

Reviewed by Mark Lam.

Now that the custom getter calling convetion uses a single register
for the slot base we can easily pass the correct |thisValue| instead
of simply relying on the thisValue not be relevant to existing
custom getters. This also means that 32bit can call custom getters
directly.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/Repatch.cpp:

(JSC::generateProtoChainAccessStub):
(JSC::tryBuildGetByIDList):

10:20 AM Changeset in webkit [163548] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Fix a copy/paste mistake in TestExpectations.

  • platform/mac/TestExpectations:
10:13 AM Changeset in webkit [163547] by svillar@igalia.com
  • 16 edits
    9 copies
    1 add in trunk

[CSS Grid Layout] getComputedStyle() is wrong for grid-definition-{columns|rows}
https://bugs.webkit.org/show_bug.cgi?id=127033

Reviewed by Andreas Kling.

Source/WebCore:

Tests: fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html

fast/css-grid-layout/non-grid-columns-rows-get-set.html
fast/css-grid-layout/non-grid-element-repeat-get-set.html
fast/css-grid-layout/non-named-grid-line-get-set.html

According to the specs getComputedStyle() should return the used
values instead of the resolved values for compatibility with early
implementations. This means that grid-definition-{columns|rows}
are now layout dependent as we need to compute the used values for
grid track sizes.

Updated the outcome of existing tests and added a bunch of new
ones that check the behavior of the different properties outside
grid containers.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::specifiedValueForGridTrackSize):
(WebCore::valueForGridTrackList):
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeUsedBreadthOfMinLength):
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength):
(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::gridTrackSize):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
(WebCore::RenderGrid::growGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::RenderGrid::findChildLogicalPosition):

  • rendering/RenderGrid.h:

LayoutTests:

Updated the expected results of many tests, as we should expect
the used values instead of the resolved ones when asking for
getComputedStyle().

  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
  • fast/css-grid-layout/grid-element-repeat-get-set.html:
  • fast/css-grid-layout/named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/named-grid-line-get-set.html:
  • fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt.
  • fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt.
  • fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple.html.
  • fast/css-grid-layout/non-grid-columns-rows-get-set.html: Copied from LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set.html.
  • fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt: Copied from LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set-expected.txt.
  • fast/css-grid-layout/non-grid-element-repeat-get-set.html: Copied from LayoutTests/fast/css-grid-layout/grid-element-repeat-get-set.html.
  • fast/css-grid-layout/non-named-grid-line-get-set-expected.txt: Copied from LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt.
  • fast/css-grid-layout/non-named-grid-line-get-set.html: Added.
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridDefinitionsValues):
(checkGridDefinitionsSetJSValues):

  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js: Copied from LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js.

(testInherit):
(testInitial):

  • fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js: Copied from LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js.

(testInherit):
(testInitial):

10:10 AM Changeset in webkit [163546] by Lucas Forschler
  • 5 edits in tags/Safari-538.16.2/Source/WebKit2

Merged r163504.

10:08 AM Changeset in webkit [163545] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Modernize CrossOriginPreflightResultCache
https://bugs.webkit.org/show_bug.cgi?id=128309

Reviewed by Antti Koivisto.

Use std::chrono::steady_clock instead of currentTime() for determining when
cache items expire, Use std::unique_ptr instead of OwnPtr, use NeverDestroyed,
get rid of unnecessary container typedefs now that we have auto. Finally,
de-indent the entire class declaration.

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
(WebCore::parseAccessControlMaxAge):
(WebCore::CrossOriginPreflightResultCacheItem::parse):
(WebCore::CrossOriginPreflightResultCacheItem::allowsRequest):
(WebCore::CrossOriginPreflightResultCache::shared):
(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/CrossOriginPreflightResultCache.h:

(WebCore::CrossOriginPreflightResultCacheItem::CrossOriginPreflightResultCacheItem):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

10:08 AM Changeset in webkit [163544] by ap@apple.com
  • 2 edits in trunk/LayoutTests

editing/caret/caret-color.html is flaky on WK2
https://bugs.webkit.org/show_bug.cgi?id=128315

  • platform/mac-wk2/TestExpectations: Marked it as such.
10:04 AM Changeset in webkit [163543] by commit-queue@webkit.org
  • 4 edits
    9 adds in trunk

Menclose with no notation attribute does not display anything.
https://bugs.webkit.org/show_bug.cgi?id=127889

Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2014-02-06
Reviewed by Chris Fleizach.

Source/WebCore:

Menclose with no notation attribute should behave same as menclose with
notation attribute with value as longdiv. By default the division
symbol should be displayed. For empty and invalid notation attribute
nothing should be displayed.

Tests: mathml/presentation/menclose-notation-default-longdiv.html

mathml/presentation/menclose-notation-invalid-empty.html

  • mathml/MathMLMencloseElement.h:
  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::paint):
Added style for menclose with no notation attribute and handled this
condition in paint also where for longdiv we are explicitly drawing
the division symbol.

LayoutTests:

  • mathml/presentation/menclose-notation-default-longdiv.html: Added.
  • mathml/presentation/menclose-notation-invalid-empty-expected.html: Added.
  • mathml/presentation/menclose-notation-invalid-empty.html: Added.
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Added.
  • platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
  • platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Added.
  • platform/mac/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
  • platform/mac/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Added.

Added new test cases to test the functionality of menclose with no
notation attribute, invalid and empty notation attribute.

9:59 AM Changeset in webkit [163542] by mhahnenberg@apple.com
  • 20 edits
    1 add in trunk/Source

Heap::writeBarrier shouldn't be static
https://bugs.webkit.org/show_bug.cgi?id=127807

Reviewed by Geoffrey Garen.

Currently it looks up the Heap in which to fire the write barrier by using
the cell passed to it. Almost every call site already has a reference to the
VM or the Heap itself. It seems wasteful to look it up all over again.

Source/JavaScriptCore:

(JSC::CopyWriteBarrier::set):

  • heap/Heap.cpp:

(JSC::Heap::writeBarrier):

  • heap/Heap.h:

(JSC::Heap::writeBarrier):

  • jit/JITOperations.cpp:
  • jit/JITWriteBarrier.h:

(JSC::JITWriteBarrierBase::set):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

  • runtime/Arguments.h:
  • runtime/JSWeakMap.cpp:
  • runtime/MapData.cpp:

(JSC::MapData::ensureSpaceForAppend):

  • runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

  • runtime/Structure.h:
  • runtime/WriteBarrier.h:
  • runtime/WriteBarrierInlines.h: Added.

Source/WebCore:

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

9:55 AM Changeset in webkit [163541] by ap@apple.com
  • 2 edits in trunk/LayoutTests

media/video-load-preload-metadata.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=128312

  • platform/mac/TestExpectations: Marked it as such.
9:50 AM Changeset in webkit [163540] by Lucas Forschler
  • 5 edits in tags/Safari-538.16.2

Merged r163481.

9:49 AM Changeset in webkit [163539] by commit-queue@webkit.org
  • 8 edits
    2 copies
    1 delete in trunk/Tools

Unreviewed, rolling out r163530.
http://trac.webkit.org/changeset/163530
https://bugs.webkit.org/show_bug.cgi?id=128311

It broke run-gtk-tests (Requested by Ossy on #webkit).

  • efl/common.py: Copied from Tools/gtk/jhbuildrc.

(script_path):
(top_level_path):

  • efl/jhbuildrc:
  • gtk/common.py:

(script_path):
(top_level_path):

  • gtk/find-make-dist-errors:

(get_missing_headers):

  • gtk/generate-gtkdoc:

(get_webkit2_options):
(get_webkit1_options.src_path):
(get_webkit1_options):
(get_webkitdom_options.src_path):
(get_webkitdom_options):

  • gtk/generate-inspector-gresource-manifest.py:
  • gtk/jhbuildrc:
  • jhbuild/jhbuildrc_common.py: Removed.
  • nix/common.py: Copied from Tools/nix/jhbuildrc.

(script_path):
(top_level_path):

  • nix/jhbuildrc:
9:42 AM Changeset in webkit [163538] by beidson@apple.com
  • 14 edits in trunk

IDB: storage/indexeddb/mozilla/clear.html fails
<rdar://problem/15997155> and https://bugs.webkit.org/show_bug.cgi?id=128282

Reviewed by David Kilzer.

Source/WebCore:

Covered by storage/indexeddb/mozilla/clear.html (and probably others)

Update the value deserializer to take into account whether or not there was an IDBKey:

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValueBuffer):

  • bindings/js/IDBBindingUtilities.h:
  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Call the new form of deserializeIDBValueBuffer.

  • Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::clearObjectStore): Update logging.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setActive): Update logging.

  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::commit): Fix ASSERTs to reflect multi-process worlds.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::openTransaction): Update logging.

  • DatabaseProcess/IndexedDB/sqlite/SQLiteIDBTransaction.cpp:

(WebKit::SQLiteIDBTransaction::commit): Update ASSERT.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Enable this test.

Update the test for (what I can only assume are) changes in the spec:

  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/resources/clear.js:

(areWeClearYet):

9:29 AM Changeset in webkit [163537] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Re-enable simple line layout on non-Mac platforms
https://bugs.webkit.org/show_bug.cgi?id=123338

Reviewed by Anders Carlsson.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

9:03 AM Changeset in webkit [163536] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Use std::chrono functions in dispatchFunctionsFromMainThread()
https://bugs.webkit.org/show_bug.cgi?id=128308

Reviewed by Antti Koivisto.

  • wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread):

8:50 AM Changeset in webkit [163535] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for tests crashing after r162816.

  • platform/efl-wk2/TestExpectations:
8:45 AM Changeset in webkit [163534] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use system default compiler instead of gcc, as final fall through.
https://bugs.webkit.org/show_bug.cgi?id=126773

Patch by Koop Mast <kwm@FreeBSD.org> on 2014-02-06
Reviewed by Alexey Proskuryakov.

  • dom/make_names.pl:
8:29 AM Changeset in webkit [163533] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

No need to enterFullscreen() when already in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=128276

Reviewed by Jer Noble.

No new tests, this is just cleanup.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlayState): Don't call enterFullscreen() if already there.
(WebCore::HTMLMediaElement::enterFullscreen): Return early if m_isFullscreen is already true.

7:24 AM Changeset in webkit [163532] by d.nomiyama@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
6:42 AM Changeset in webkit [163531] by stavila@adobe.com
  • 4 edits
    2 adds in trunk

[CSS Regions] Null dereference applying animation with CSS regions
https://bugs.webkit.org/show_bug.cgi?id=128218

Reviewed by Andrei Bucur.

Source/WebCore:

The first issue (the null dereference) was caused by the checkForZoomChange method
not guarding against a null parentStyle parameter, as the checkForGenericFamilyChange
method does, which in the crashing scenario is called just before the faulty
checkForZoomChange method.
The second issue was an assert which was caused by the fact that detaching is performed
in a certain situation if the element has a renderer or if it's inside a named flow.
However, when reattaching and asserting the element has no renderer, the
"inside named flow" condition was no longer considered.

Test: fast/regions/animation-element-in-region-flowed-to-other-thread.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::checkForZoomChange):

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachChildren):

LayoutTests:

Added test for crash caused by using animations with DOM children of regions flowed
into another flow thread.

  • fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html: Added.
  • fast/regions/animation-element-in-region-flowed-to-other-thread.html: Added.
5:41 AM Changeset in webkit [163530] by commit-queue@webkit.org
  • 8 edits
    1 add
    2 deletes in trunk/Tools

Extract common parts from jhbuildrc files.
https://bugs.webkit.org/show_bug.cgi?id=125986

Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2014-02-06
Reviewed by Csaba Osztrogonác.

  • efl/common.py: Removed.
  • efl/jhbuildrc:
  • gtk/common.py:

(binary_build_path):

  • gtk/find-make-dist-errors:

(get_missing_headers):

  • gtk/generate-gtkdoc:

(get_webkit2_options):
(get_webkit1_options.src_path):
(get_webkit1_options):
(get_webkitdom_options.src_path):
(get_webkitdom_options):

  • gtk/generate-inspector-gresource-manifest.py:
  • gtk/jhbuildrc:
  • jhbuild/jhbuildrc_common.py: Added.

(script_path):
(top_level_path):
(init):

  • nix/common.py: Removed.
  • nix/jhbuildrc:
2:50 AM Changeset in webkit [163529] by g.czajkowski@samsung.com
  • 6 edits in trunk/LayoutTests

Verify copy/paste of misspellings asynchronously
https://bugs.webkit.org/show_bug.cgi?id=128246

Reviewed by Ryosuke Niwa.

Refactoring two spelling tests that use copy/paste to be able to
verify spelling markers asynchronously.
Additionally, use evalAndLog() to make test expectation more readable.
Fix the description according to the tests.

Start off verifying whether spelling marker is available when continuous spell
checking (spellcheck attribute, respectively) is on.
Without this test case, the tests passed even spellchecking
or copy/paste were not implemented (EFL).

  • editing/spelling/spellcheck-paste-continuous-disabled-expected.txt:
  • editing/spelling/spellcheck-paste-continuous-disabled.html:

Remove unnecessary spellcheck=true attribute. It's default value and we
do not manipulate it at all.
Add destination element where paste operation is performed.

  • editing/spelling/spellcheck-paste-disabled-expected.txt:
  • editing/spelling/spellcheck-paste-disabled.html:
  • platform/efl/TestExpectations:

Mark spellcheck-paste-continuous-disabled.html as failing since EFL does not
implement copy/paste feature.

2:05 AM Changeset in webkit [163528] by commit-queue@webkit.org
  • 5 edits in trunk

Create a HTMLUnknownElement when using createElement('image')
https://bugs.webkit.org/show_bug.cgi?id=125896

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-02-06
Reviewed by Antti Koivisto.

Source/WebCore:

Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/fd8a7b65f3300fb9245db24d5ed240c80b7f76ad

  • html/HTMLTagNames.in:

LayoutTests:

  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
1:42 AM Changeset in webkit [163527] by commit-queue@webkit.org
  • 6 edits
    6 adds in trunk

[XHR] Ensure response return null when error flag is set for blob and arraybuffer
https://bugs.webkit.org/show_bug.cgi?id=127050

Patch by Youenn Fablet <youennf@gmail.com> on 2014-02-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Added a check in JSXMLHttpRequest::response to ensure response return null when error flag is set for blob and arraybuffer
This check also applies to document and json response types (no change in behavior for those types but code path change)
Added assertions in the related XMLHttpRequest blob and array buffer getters
Minor code clean-up.
The test cases check all four response types in case of timeout and abort

Tests: http/tests/xmlhttprequest/onabort-response-getters.html

http/tests/xmlhttprequest/ontimeout-response-getters.html

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::response):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didCacheResponseJSON):
(WebCore::XMLHttpRequest::responseXML):
(WebCore::XMLHttpRequest::responseBlob):
(WebCore::XMLHttpRequest::responseArrayBuffer):

LayoutTests:

Added test cases that check XHR response in case of timeout and abort for arraybuffer, blob, document and json.

  • fast/files/script-tests/xhr-response-blob.js: updated to expect null for blob response in case of XHR requesting a file that does not exist

(.xhr.onreadystatechange):
(.xhr.onerror):
(.xhr.onload):
(.xhr.onloadend):
(testBlob):

  • fast/files/xhr-response-blob-expected.txt:
  • http/tests/resources/load-then-wait.cgi: Added (similar to load-and-stall except that it sends the whole document and then wait for some time before completing the response).
  • http/tests/xmlhttprequest/onabort-response-getters-expected.txt: Added.
  • http/tests/xmlhttprequest/onabort-response-getters.html: Added.
  • http/tests/xmlhttprequest/ontimeout-response-getters-expected.txt: Added.
  • http/tests/xmlhttprequest/ontimeout-response-getters.html: Added.
1:01 AM Changeset in webkit [163526] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Fix the build after r163516 for !ENABLE(ASYNC_SCROLLING) platforms
https://bugs.webkit.org/show_bug.cgi?id=128299

Reviewed by Antti Koivisto.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleTouchEvent):

12:38 AM Changeset in webkit [163525] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix after r163520, remove Andrei from committers list, because
he is reviewer now, and webkit-patch doesn't like duplicated entries.

  • Scripts/webkitpy/common/config/contributors.json:
12:23 AM Changeset in webkit [163524] by barraclough@apple.com
  • 11 edits in trunk/Source

Change Page, FocusController to use ViewState
https://bugs.webkit.org/show_bug.cgi?id=126533

Reviewed by Tim Horton.

These classes currently maintain a set of separate fields to represent the view state;
combine these into a single field, and allow WebPage to send the combined update rather
than individual changes.

Maintain existing interface for WebKit1 clients.

Source/WebCore:

  • WebCore.exp.in:
    • Added WebCore::setViewState, removed WebCore::setIsVisuallyIdle.
  • page/FocusController.cpp:

(WebCore::FocusController::FocusController):

  • Initialize combined m_viewState.

(WebCore::FocusController::setFocused):

  • Calls setViewState.

(WebCore::FocusController::setFocusedInternal):

  • setFocused -> setFocusedInternal.

(WebCore::FocusController::setViewState):

  • Added, update all ViewState flags.

(WebCore::FocusController::setActive):

  • Calls setViewState.

(WebCore::FocusController::setActiveInternal):

  • setActive -> setActiveInternal.

(WebCore::FocusController::setContentIsVisible):

  • Calls setViewState.

(WebCore::FocusController::setContentIsVisibleInternal):

  • setContentIsVisible -> setContentIsVisibleInternal.
  • page/FocusController.h:

(WebCore::FocusController::isActive):
(WebCore::FocusController::isFocused):
(WebCore::FocusController::contentIsVisible):

  • Implemented in terms of ViewState.
  • page/Page.cpp:

(WebCore::Page::Page):

  • Initialize using PageInitialViewState.

(WebCore::Page::setIsInWindow):

  • Calls setViewState.

(WebCore::Page::setIsInWindowInternal):

  • setIsInWindow -> setIsInWindowInternal.

(WebCore::Page::setIsVisuallyIdleInternal):

  • setIsVisuallyIdle -> setIsVisuallyIdleInternal.

(WebCore::Page::setViewState):

  • Added, update all ViewState flags, including FocusController.

(WebCore::Page::setIsVisible):

  • Calls setViewState.

(WebCore::Page::setIsVisibleInternal):

  • setIsVisible -> setIsVisibleInternal.

(WebCore::Page::visibilityState):

  • m_isVisible -> isVisible()

(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

  • m_isVisible -> isVisible()
  • page/Page.h:

(WebCore::Page::isVisible):
(WebCore::Page::isInWindow):

  • Implemented in terms of ViewState.

(WebCore::Page::scriptedAnimationsSuspended):

  • Combined member fields into ViewState::Flags.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _windowWillOrderOnScreen:]):
(-[WebView _windowWillOrderOffScreen:]):

  • remove calls to FocusController::setContentIsVisible, these are redundant (this is handled when page visibility is set).

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • Combined separate calls to Page::setViewState.

(WebKit::WebPage::updateIsInWindow):

  • Simplied from setIsInWindow.

(WebKit::WebPage::setViewState):

  • Combined separate calls to Page::setViewState.
  • WebProcess/WebPage/WebPage.h:
    • Declare updateIsInWindow.
12:03 AM Changeset in webkit [163523] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

12:00 AM Changeset in webkit [163522] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.17

New tag.

Note: See TracTimeline for information about the timeline view.