Timeline



Feb 25, 2014:

11:53 PM Changeset in webkit [164703] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r164578 - [GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
https://bugs.webkit.org/show_bug.cgi?id=129245

Reviewed by Sergio Villar Senin.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Call FullscreenManager::requestExitFullScreen() directly.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
11:43 PM Changeset in webkit [164702] by benjamin@webkit.org
  • 22 edits
    5 adds in trunk/Source/WebKit2

[iOS][WK2] Split the rects/scale updates in 3 internally consistent groups
https://bugs.webkit.org/show_bug.cgi?id=129354

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-25
Reviewed by Sam Weinig.

During scaling, the scale and rect of UIScrollView, WebPageProxy, DrawingAreaProxy,
DrawingArea and WebPage were in completely inconsistent states.

Some of those disconnect were temporary (like when setting the rect and scale in two different
messages), some were lasting the time of a tile update (like the UIProcess view of the scale).
This was causing various visual glitches.

To fix this, all the updates from the UIProcess are funneled through a single path and the values
are split into 3 different groups/types.
When updating the scale/rects, the UIProcess sends the new information to the WebProcess on a queue
through ViewUpdateDispatcher. There, the updates are accumulated until the MainThread is available.
Once the main thread is "unblocked" from the previous frame, all the data are updated at once from
the last known state in ViewUpdateDispatcher. The new tiles are created for the new converage information
and they are sent to the UIProcess.

At any point, there are 3 types of scale and rects used for different purpose:
-In the UIProcess, there is the UIScrollView scale and rects which represent the "true" state or what

is currently on screen.
That information is mirrored into WebPageProxy for the other classes needing it like DrawingAreaProxy.

-In the WebProcess, there is the last known state. That state is always lagging a little behind the "true"

state.

-Back in the UIProcess, we have the tile states that is attached to RemoteLayerTreeTransaction. It is used

to setup the rendering.

With this change, there are two paths for updating the page scale factor:
-The UI drives the change, the updates goes WKWebView->WKContentView->WebPageProxy->ViewUpdateDispatcher

->WebPage->RemoteLayerTreeDrawingArea->RemoteLayerTreeDrawingAreaProxy->WKContentView->WKWebView.

-If changes in the content force scaling parameters, the updates goes: WebPage->RemoteLayerTreeDrawingArea

->RemoteLayerTreeDrawingAreaProxy->WKContentView->WKWebView.

The two kind of updates frequently conflicts during loading. We differentiate those through the flag
scaleWasSetByUIProcess passed with the updates. In cases of conflicts, the user always wins.

  • DerivedSources.make:
  • Scripts/webkit2/messages.py:

(struct_or_class):

  • Shared/VisibleContentRectUpdateInfo.cpp: Added.

(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):

  • Shared/VisibleContentRectUpdateInfo.h: Added.

(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::exposedRect):
(WebKit::VisibleContentRectUpdateInfo::unobscuredRect):
(WebKit::VisibleContentRectUpdateInfo::scale):
(WebKit::operator==):

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::scaleWasSetByUIProcess):
(WebKit::RemoteLayerTreeTransaction::setScaleWasSetByUIProcess):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView contentView:didCommitLayerTree:WebKit::]):
(-[WKWebView _didFinishScrolling]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewDidZoom:]):
(-[WKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _updateVisibleContentRectsWithStableState:]):
(-[WKWebView _setObscuredInsets:]):
(-[WKWebView _endInteractiveObscuredInsetsChange]):

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _updateVisibleContentRects]):

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::setCustomFixedPositionRect):

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::updateDebugIndicator):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::displayedContentScale):
(WebKit::WebPageProxy::exposedContentRect):
(WebKit::WebPageProxy::unobscuredContentRect):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):
(-[WKContentView didFinishScrolling]):
(-[WKContentView didZoomToScale:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateVisibleContentRects):

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::scaledExposedRect):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorScale):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/ViewUpdateDispatcher.cpp: Added.

(WebKit::ViewUpdateDispatcher::create):
(WebKit::ViewUpdateDispatcher::ViewUpdateDispatcher):
(WebKit::ViewUpdateDispatcher::~ViewUpdateDispatcher):
(WebKit::ViewUpdateDispatcher::initializeConnection):
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):

  • WebProcess/WebPage/ViewUpdateDispatcher.h: Added.
  • WebProcess/WebPage/ViewUpdateDispatcher.messages.in: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::scalePage):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::scaleWasSetByUIProcess):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::tapHighlightAtPosition):
(WebKit::WebPage::updateVisibleContentRects):
(WebKit::WebPage::willStartUserTriggeredZooming):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:
11:35 PM Changeset in webkit [164701] by Mihai Maerean
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

10:52 PM Changeset in webkit [164700] by fred.wang@free.fr
  • 6 edits
    4 adds in trunk

Add support for minsize/maxsize attributes.
https://bugs.webkit.org/show_bug.cgi?id=122567

Reviewed by Chris Fleizach.

Source/WebCore:

This change implements the minsize/maxsize attributes of the mo element.
We also switch stretch sizes from int to LayoutUnit to improve accuracy.

Tests: mathml/presentation/stretchy-minsize-maxsize-dynamic.html

mathml/presentation/stretchy-minsize-maxsize.html

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::SetOperatorProperties):
(WebCore::RenderMathMLOperator::stretchTo):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

Add some reftests for the minsize/maxsize attributes of the mo element.

  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • mathml/presentation/stretchy-minsize-maxsize-dynamic-expected.html: Added.
  • mathml/presentation/stretchy-minsize-maxsize-dynamic.html: Added.
  • mathml/presentation/stretchy-minsize-maxsize-expected.html: Added.
  • mathml/presentation/stretchy-minsize-maxsize.html: Added.
10:43 PM Changeset in webkit [164699] by mihnea@adobe.com
  • 5 edits in trunk/Source/WebCore

[CSSRegions] Small clean-up of flow threads accelerated compositing code
https://bugs.webkit.org/show_bug.cgi?id=129312

Reviewed by Andrei Bucur.

Some clean-up for the code used for regions in accelerated compositing functionality:

  1. Rename updateRenderFlowThreadLayersIfNeeded -> updateFlowThreadsLayerToRegionMappingsIfNeeded

as the function updates the mapping between the flow threads layers and their corresponding regions

  1. Remove RenderLayerCompositor::updateRenderFlowThreadLayersIfNeeded and move the code in place

at call site since the function body does not require a dedicated function.

No new functionality, no new tests.

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateFlowThreadsLayerToRegionMappingsIfNeeded):
Now that the regions are always layers, we do not need to iterate backwards.

  • rendering/FlowThreadController.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):

  • rendering/RenderLayerCompositor.h:
10:24 PM Changeset in webkit [164698] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Subpixel rendering: Ensure consistent border painting width.
https://bugs.webkit.org/show_bug.cgi?id=129259

Reviewed by Simon Fraser.

Border edges are painted as (semi)independent rectangles. When snapping an edge rectangle
to device pixels, its painted dimensions depend on its size and its fractional position.
Specific combination of position and border width can result in painting edges sized differently.
Using device snapped border width to calculate inner/outer rectangles helps to maintain
uniform border width.

Currently not testable.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::shouldRender):
(WebCore::BorderEdge::presentButInvisible):
(WebCore::BorderEdge::widthForPainting):
(WebCore::BorderEdge::getDoubleBorderStripeWidths):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::calculateSideRect):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::calculateSideRectIncludingInner):

10:23 PM Changeset in webkit [164697] by Alan Bujtas
  • 15 edits in trunk/Source/WebCore

Subpixel layout: Remove explicit static_cast<LayoutUnit> conversions.
https://bugs.webkit.org/show_bug.cgi?id=129359

Reviewed by Simon Fraser.

No testable change in behavior.

  • css/LengthFunctions.cpp:

(WebCore::minimumValueForLength):

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintFillLayer):

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::logicalLeftVisualOverflow):
(WebCore::InlineFlowBox::logicalRightVisualOverflow):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeColumnCountAndWidth):
(WebCore::getBPMWidth):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForBorderFit):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):

  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

  • rendering/RenderTable.h:

(WebCore::RenderTable::borderSpacingInRowDirection):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::preferredContentLogicalWidth):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::resolveLengthAttributeForSVG):

10:01 PM Changeset in webkit [164696] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Build fixes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
9:03 PM Changeset in webkit [164695] by bshafiei@apple.com
  • 5 edits in branches/safari-537.75-branch/Source

Versioning.

8:33 PM Changeset in webkit [164694] by bshafiei@apple.com
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

8:19 PM Changeset in webkit [164693] by bshafiei@apple.com
  • 1 copy in tags/Safari-537.60.16

New tag.

7:51 PM Changeset in webkit [164692] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix for OS X after r164690

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-25

  • WebCore.exp.in:
7:23 PM Changeset in webkit [164691] by andersca@apple.com
  • 12 edits
    4 moves in trunk/Source

Rename WebCore::VisitedLinkProvider to WebCore::VisitedLinkStore
https://bugs.webkit.org/show_bug.cgi?id=129357

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/VisitedLinkState.cpp:

(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • loader/HistoryController.cpp:

(WebCore::addVisitedLink):

  • page/DefaultVisitedLinkStore.cpp: Renamed from Source/WebCore/page/DefaultVisitedLinkProvider.cpp.

(WebCore::DefaultVisitedLinkStore::create):
(WebCore::DefaultVisitedLinkStore::DefaultVisitedLinkStore):
(WebCore::DefaultVisitedLinkStore::~DefaultVisitedLinkStore):
(WebCore::DefaultVisitedLinkStore::isLinkVisited):
(WebCore::DefaultVisitedLinkStore::addVisitedLink):

  • page/DefaultVisitedLinkStore.h: Renamed from Source/WebCore/page/DefaultVisitedLinkProvider.h.
  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::visitedLinkStore):

  • page/Page.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::visitedLinkStore):

  • page/PageGroup.h:
  • page/VisitedLinkStore.cpp: Renamed from Source/WebCore/page/VisitedLinkProvider.cpp.

(WebCore::VisitedLinkStore::VisitedLinkStore):
(WebCore::VisitedLinkStore::~VisitedLinkStore):

  • page/VisitedLinkStore.h: Renamed from Source/WebCore/page/VisitedLinkProvider.h.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebVisitedLinkProvider.h:
7:05 PM Changeset in webkit [164690] by enrica@apple.com
  • 15 edits
    2 adds in trunk/Source

[WebKit2] Form controls handling.
https://bugs.webkit.org/show_bug.cgi?id=129344
<rdar://problem/16053643>

Reviewed by Simon Fraser and Joseph Pecoraro.

../WebCore:

Adding some exports.

  • WebCore.exp.in:

../WebKit2:

This is the step toward adding support for
form controls iOS style. It adds the logic to
select the appropriate keyboard type based on the
element type and introduces the AssistedNodeInformation
structure used currently for the keyboard type selection
and that will be used to populate pickers and popovers.
It also provides information to enable/disable next/previous
buttons in the accessory view.

  • Scripts/webkit2/messages.py:

(struct_or_class):

  • Shared/AssistedNodeInformation.cpp: Added.

(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):

  • Shared/AssistedNodeInformation.h: Added.

(WebKit::AssistedNodeInformation::AssistedNodeInformation):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::startAssistingNode):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView _updateAccessory]):
(toUITextAutocapitalize):
(-[WKContentView textInputTraits]):
(-[WKContentView assistedNodeInformation]):
(-[WKContentView _startAssistingNode:]):
(-[WKContentView _stopAssistingNode]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::startAssistingNode):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAssistableNode):
(WebKit::hasFocusableNode):
(WebKit::WebPage::getAssistedNodeInformation):
(WebKit::WebPage::elementDidFocus):

6:50 PM Changeset in webkit [164689] by commit-queue@webkit.org
  • 1 edit
    5 adds
    4 deletes in trunk/LayoutTests

Web Inspector: Port some profiler tests to inspector-protocol
https://bugs.webkit.org/show_bug.cgi?id=129353

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-25
Reviewed by Timothy Hatcher.

  • inspector-obsolete/profiler/cpu-profiler-parameterless-profile-end-crash-expected.txt: Removed.
  • inspector-obsolete/profiler/cpu-profiler-parameterless-profile-end-crash.html: Removed.
  • inspector-obsolete/profiler/cpu-profiler-profiling-without-inspector-expected.txt: Removed.
  • inspector-obsolete/profiler/cpu-profiler-profiling-without-inspector.html: Removed.
  • inspector-protocol/profiler/console-profile-expected.txt: Added.
  • inspector-protocol/profiler/console-profile.html: Added.
  • inspector-protocol/profiler/console-profileEnd-parameterless-expected.txt: Added.
  • inspector-protocol/profiler/console-profileEnd-parameterless.html: Added.
6:28 PM Changeset in webkit [164688] by Brent Fulgham
  • 3 edits in branches/safari-537.60-branch/Source/WebCore

Merge r164660

2014-02-25 Brent Fulgham <Brent Fulgham>

[Win] Gracefully recover from missing 'naturalSize' parameter for media
https://bugs.webkit.org/show_bug.cgi?id=129278

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add declaration for missing function call.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::createMetadataKeyNames): (WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus): Don't treat missing 'naturalSize' as a fatal error. (WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged): Handle case of asset track not being available yet. (WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): If the 'naturalSize' is empty, use the Player Item's 'presentationSize' instead. (WebCore::AVFWrapper::processNotification): Add missing handler for duration changed.
6:12 PM Changeset in webkit [164687] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Web Inspector: CRASH when evaluating in console of JSContext RWI with disabled breakpoints.
<https://webkit.org/b/128766>

Reviewed by Geoffrey Garen.

Make the JSLock::grabAllLocks() work the same way as for the C loop LLINT.
The reasoning is that we don't know of any clients that need unordered
re-entry into the VM from different threads. So, we're enforcing ordered
re-entry i.e. we must re-grab locks in the reverse order of dropping locks.

The crash in this bug happened because we were allowing unordered re-entry,
and the following type of scenario occurred:

  1. Thread T1 locks the VM, and enters the VM to execute some JS code.
  2. On entry, T1 detects that VM::m_entryScope is null i.e. this is the first time it entered the VM. T1 sets VM::m_entryScope to T1's entryScope.
  3. T1 drops all locks.
  1. Thread T2 locks the VM, and enters the VM to execute some JS code. On entry, T2 sees that VM::m_entryScope is NOT null, and therefore does not set the entryScope.
  2. T2 drops all locks.
  1. T1 re-grabs locks.
  2. T1 returns all the way out of JS code. On exit from the outer most JS function, T1 clears VM::m_entryScope (because T1 was the one who set it).
  3. T1 unlocks the VM.
  1. T2 re-grabs locks.
  2. T2 proceeds to execute some code and expects VM::m_entryScope to be

NOT null, but it turns out to be null. Assertion failures and
crashes ensue.

With ordered re-entry, at step 6, T1 will loop and yield until T2 exits
the VM. Hence, the issue will no longer manifest.

  • runtime/JSLock.cpp:

(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):

  • runtime/JSLock.h:

(JSC::JSLock::DropAllLocks::dropDepth):

5:45 PM Changeset in webkit [164686] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

VisitedLinkProvider should be refcounted
https://bugs.webkit.org/show_bug.cgi?id=129351

Reviewed by Sam Weinig.

  • UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::create):
(WebKit::VisitedLinkProvider::~VisitedLinkProvider):

  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidFinishLaunching):
(WebKit::WebContext::disconnectProcess):
(WebKit::WebContext::addVisitedLinkHash):

  • UIProcess/WebContext.h:
5:27 PM Changeset in webkit [164685] by Samuel White
  • 7 edits in trunk

Add accessibility search predicate support for AXOutlines
https://bugs.webkit.org/show_bug.cgi?id=123748

Reviewed by Chris Fleizach.

Source/WebCore:

Added new AXOutlineSearchKey to support finding elements with aria role=tree.

No new tests, updated existing search-predicate.html test to cover AXOutlineSearchKey.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):

  • accessibility/AccessibilityObject.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilitySearchKeyMap):

LayoutTests:

Updated test to validate support for AXOutlineSearchKey (elements with aria role=tree).

  • platform/mac/accessibility/search-predicate-expected.txt:
  • platform/mac/accessibility/search-predicate.html:
5:06 PM Changeset in webkit [164684] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Make WebContext handle populating visited links
https://bugs.webkit.org/show_bug.cgi?id=129348

Reviewed by Tim Horton.

This makes it possible to decouple VisitedLinkProvider from WebContext.

  • UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::VisitedLinkProvider):
(WebKit::VisitedLinkProvider::processDidFinishLaunching):

  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidFinishLaunching):

  • UIProcess/WebContext.h:
5:03 PM Changeset in webkit [164683] by mark.lam@apple.com
  • 10 edits in trunk/Source

Need to initialize VM stack data even when the VM is on an exclusive thread.
<https://webkit.org/b/129265>

Not reviewed.

Source/JavaScriptCore:

Relanding r164627 now that <https://webkit.org/b/129341> is fixed.

  • API/APIShims.h:

(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::shouldDropAllLocks):

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::addCurrentThread):

  • runtime/JSLock.cpp:

(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):

  • runtime/JSLock.h:

(JSC::JSLock::hasExclusiveThread):
(JSC::JSLock::exclusiveThread):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::hasExclusiveThread):
(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):
(JSC::VM::currentThreadIsHoldingAPILock):

Source/WebCore:

No new tests.

Relanding r164627 now that <https://webkit.org/b/129341> is fixed.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

4:44 PM Changeset in webkit [164682] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

DrawingAreaProxy is using WebCore's Timer
https://bugs.webkit.org/show_bug.cgi?id=129347
<rdar://problem/16078133>

Reviewed by Tim Horton.

Use a RunLoop::Timer instead.

  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::DrawingAreaProxy):
(WebKit::DrawingAreaProxy::exposedRectChangedTimerFired):

  • UIProcess/DrawingAreaProxy.h:
4:38 PM Changeset in webkit [164681] by andersca@apple.com
  • 5 edits
    4 copies in trunk/Source/WebKit2

Add WKVisitedLinkProvider
https://bugs.webkit.org/show_bug.cgi?id=129343

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKVisitedLinkProvider.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
  • UIProcess/API/Cocoa/WKVisitedLinkProvider.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
  • UIProcess/API/Cocoa/WKVisitedLinkProviderInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
  • UIProcess/API/Cocoa/WKVisitedLinkProviderPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.h.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration visitedLinkProvider]):
(-[WKWebViewConfiguration setVisitedLinkProvider:]):

  • WebKit2.xcodeproj/project.pbxproj:
4:12 PM Changeset in webkit [164680] by Brent Fulgham
  • 3 edits in branches/safari-537.75-branch/Source/WebCore

Merge r164660

2014-02-25 Brent Fulgham <Brent Fulgham>

[Win] Gracefully recover from missing 'naturalSize' parameter for media
https://bugs.webkit.org/show_bug.cgi?id=129278

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add declaration for missing function call.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: (WebCore::createMetadataKeyNames): (WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus): Don't treat missing 'naturalSize' as a fatal error. (WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged): Handle case of asset track not being available yet. (WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): If the 'naturalSize' is empty, use the Player Item's 'presentationSize' instead. (WebCore::AVFWrapper::processNotification): Add missing handler for duration changed.
3:53 PM Changeset in webkit [164679] by mark.lam@apple.com
  • 2 edits in trunk/Source/WebCore

JSDOMPromise methods should acquire VM lock before calling into JS.
<https://webkit.org/b/129341>

Reviewed by Geoffrey Garen.

No new tests.

  • bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DeferredWrapper::resolve<String>):
(WebCore::DeferredWrapper::resolve<bool>):
(WebCore::char>>):
(WebCore::DeferredWrapper::reject<String>):

3:28 PM Changeset in webkit [164678] by andersca@apple.com
  • 7 edits in trunk/Source

Simplify visited link style invalidation
https://bugs.webkit.org/show_bug.cgi?id=129340

Reviewed by Dan Bernstein.

Source/WebCore:

Get rid of the static Page::allVisitedStateChanged and Page::visitedStateChanged
member functions and add functions to invalidate all styles on a single page or the style
for a single link hash on a single page.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::invalidateStylesForAllLinks):
(WebCore::Page::invalidateStylesForLink):

  • page/Page.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::addVisitedLink):
(WebCore::PageGroup::removeVisitedLink):
(WebCore::PageGroup::removeVisitedLinks):

Source/WebKit2:

  • UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::addVisitedLink):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):

3:17 PM Changeset in webkit [164677] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Remove unused ThreadSpecificInspectorCounters.
<https://webkit.org/b/129337>

We were keeping count of all the JS event listeners in every thread
to support an old Chromium feature that's no longer relevant.

Removing this gets rid of expensive thread-local storage lookups.

Reviewed by Anders Carlsson.

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):

  • inspector/InspectorCounters.cpp:
  • inspector/InspectorCounters.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::setDOMCounters):

  • inspector/protocol/Timeline.json:
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):

  • platform/ThreadGlobalData.h:
3:03 PM Changeset in webkit [164676] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/WebKitLibraries

Unreviewed build fix.

  • win/tools/vsprops/production.props: Production build needs to have 'OFFICIAL_BUILD' set

in the environment for build sub-processes.

3:02 PM Changeset in webkit [164675] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/Source/WTF

Unreviewed build fix.

  • WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py: Handle unset 'WEBKIT_LIBRARIES' properly

since this is expected to be unset in the production build environmenet.

2:31 PM Changeset in webkit [164674] by lvidacs.u-szeged@partner.samsung.com
  • 3 edits
    8 adds in trunk

display:table with padding and/or borders in border-box calculates height incorrectly
https://bugs.webkit.org/show_bug.cgi?id=126576

Reviewed by David Hyatt.

Based on blink issue https://codereview.chromium.org/25206002/

Source/WebCore:

Tests: fast/box-sizing/css-table-collapse.html

fast/box-sizing/css-table-no-collapse.html
fast/box-sizing/table-collapse.html
fast/box-sizing/table-no-collapse.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalHeightUsing):

LayoutTests:

  • fast/box-sizing/css-table-collapse-expected.txt: Added.
  • fast/box-sizing/css-table-collapse.html: Added.
  • fast/box-sizing/css-table-no-collapse-expected.txt: Added.
  • fast/box-sizing/css-table-no-collapse.html: Added.
  • fast/box-sizing/table-collapse-expected.txt: Added.
  • fast/box-sizing/table-collapse.html: Added.
  • fast/box-sizing/table-no-collapse-expected.txt: Added.
  • fast/box-sizing/table-no-collapse.html: Added.
2:18 PM Changeset in webkit [164673] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Inline caching in the FTL on ARM64 should "work"
https://bugs.webkit.org/show_bug.cgi?id=129334

Reviewed by Mark Hahnenberg.

Gets us to the point where simple tests that use inline caching are passing.

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::shrink):

  • ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):
(JSC::FTL::sizeOfCall):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

  • ftl/FTLThunks.cpp:

(JSC::FTL::osrExitGenerationThunkGenerator):

  • jit/GPRInfo.h:
  • offlineasm/arm64.rb:
1:42 PM Changeset in webkit [164672] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Fix build.

Remove VisitedLinkStrategy.

  • NetworkProcess/NetworkProcessPlatformStrategies.cpp:
  • NetworkProcess/NetworkProcessPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
1:37 PM Changeset in webkit [164671] by ap@apple.com
  • 2 edits in trunk/LayoutTests

inspector-protocol/page/deny-X-FrameOption.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=129331

1:35 PM Changeset in webkit [164670] by andersca@apple.com
  • 18 edits
    1 delete in trunk/Source

Get rid of VisitedLinkStrategy
https://bugs.webkit.org/show_bug.cgi?id=129324

Reviewed by Dan Bernstein.

Source/WebCore:

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::PlatformStrategies):

  • platform/VisitedLinkStrategy.h: Removed.

Source/WebKit/efl:

  • WebCoreSupport/PlatformStrategiesEfl.cpp:

(PlatformStrategiesEfl::getPluginInfo):

  • WebCoreSupport/PlatformStrategiesEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

  • WebCoreSupport/PlatformStrategiesGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

Source/WebKit/win:

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::getPluginInfo):

  • WebCoreSupport/WebPlatformStrategies.h:
1:29 PM Changeset in webkit [164669] by ap@apple.com
  • 42 edits
    2 deletes in trunk/Source

Rolling out http://trac.webkit.org/changeset/164611, because it broke
WebKit2.PrivateBrowsingPushStateNoHistoryCallback API test

The change was for:

Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=129141
Create SessionID class

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=129141
Create SessionID class

1:24 PM Changeset in webkit [164668] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION: All inspector-protocol/model very frequently assert in IDBRequest::~IDBRequest
https://bugs.webkit.org/show_bug.cgi?id=129328

inspector-protocol/indexeddb/basics.html fails
https://bugs.webkit.org/show_bug.cgi?id=129327

1:18 PM Changeset in webkit [164667] by commit-queue@webkit.org
  • 10 edits in trunk/Source

Unreviewed, rolling out r164627.
http://trac.webkit.org/changeset/164627
https://bugs.webkit.org/show_bug.cgi?id=129325

Broke SubtleCrypto tests (Requested by ap on #webkit).

Source/JavaScriptCore:

  • API/APIShims.h:

(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::shouldDropAllLocks):

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::addCurrentThread):

  • runtime/JSLock.cpp:

(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
(JSC::JSLock::grabAllLocks):

  • runtime/JSLock.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::currentThreadIsHoldingAPILock):

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

1:10 PM Changeset in webkit [164666] by mitz@apple.com
  • 8 edits
    1 add in trunk/Source/WebKit2

[Cocoa] Add delegate method for customizing actions on activated elements
https://bugs.webkit.org/show_bug.cgi?id=129290

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Added. Declared new delegate method.
  • UIProcess/API/Cocoa/_WKActivatedElementInfo.h:

(_WKActivatedElementType): Defined enum of element types.

  • UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:

(-[_WKActivatedElementInfo _initWithType:URL:location:title:rect:]): Added type parameter
to the initializer, used to set the new type property.

  • UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h:
  • UIProcess/Cocoa/UIClient.h:
  • UIProcess/Cocoa/UIClient.mm:

(WebKit::UIClient::setDelegate): Initialize webViewActionsForElementDefaultActions member
of m_delegateMethods.
(WebKit::UIClient::actionsForElement): Added. Calls out to the new delegate method if
implemented. Otherwise returns the default actions.

  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]): Use new _elementInfo ivar
instead of creating element info here.
(-[WKActionSheetAssistant showImageSheet]): Create element info here and assign it to
_elementInfo ivar if presenting a sheet. Call the UI client to get custom actions.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.
(-[WKActionSheetAssistant cleanupSheet]): Clear _elementInfo ivar.

  • WebKit2.xcodeproj/project.pbxproj: Added reference to WKUIDelegatePrivate.h.
12:56 PM Changeset in webkit [164665] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

DefaultVisitedLinkProvider can just call into the page group directly
https://bugs.webkit.org/show_bug.cgi?id=129320

Reviewed by Andreas Kling.

  • page/DefaultVisitedLinkProvider.cpp:

(WebCore::DefaultVisitedLinkProvider::isLinkVisited):
(WebCore::DefaultVisitedLinkProvider::addVisitedLink):

12:55 PM Changeset in webkit [164664] by Michał Pakuła vel Rutka
  • 2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix attempt after r164562

  • CMakeLists.txt: Added WebVisitedLinkProvider.cpp.
12:48 PM Changeset in webkit [164663] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARM64 rshift64 should be an arithmetic shift
https://bugs.webkit.org/show_bug.cgi?id=129323

Reviewed by Mark Hahnenberg.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::rshift64):

12:42 PM Changeset in webkit [164662] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Unreviewed, rolling out r164638.
http://trac.webkit.org/changeset/164638
https://bugs.webkit.org/show_bug.cgi?id=129321

Broke Windows build. (Requested by bfulgham on #webkit).

  • dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):

  • dom/Element.cpp:

(WebCore::ensureAttrNodeListForElement):
(WebCore::Element::attributes):

  • dom/ElementIteratorAssertions.h:

(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::create):
(WebCore::ElementRareData::setAttributeMap):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::create):
(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet):

  • dom/MutationObserverRegistration.h:
  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::create):
(WebCore::NamedNodeMap::NamedNodeMap):

  • dom/Node.cpp:

(WebCore::Node::ensureRareData):
(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::create):
(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeMutationObserverData::create):
(WebCore::NodeMutationObserverData::NodeMutationObserverData):
(WebCore::NodeRareData::create):
(WebCore::NodeRareData::clearNodeLists):
(WebCore::NodeRareData::ensureNodeLists):
(WebCore::NodeRareData::ensureMutationObserverData):
(WebCore::NodeRareData::NodeRareData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

12:29 PM Changeset in webkit [164661] by eric.carlson@apple.com
  • 14 edits in trunk/Source/WebCore

[iOS] Show status image when playing video to external device
https://bugs.webkit.org/show_bug.cgi?id=129277

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleEvent): Restructure the code so it is possible to handle events

that target the video element which aren't in the HandledVideoEvents array.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.currentPlaybackTargetIsWireless): webkitCurrentPlaybackTargetIsWireless

is an attribute, not a function.

(ControllerIOS.prototype.updateWirelessPlaybackStatus): Fix style.
(ControllerIOS.prototype.updateWirelessTargetAvailable): Ditto.
(ControllerIOS.prototype.updateProgress): Ditto.
(ControllerIOS.prototype.handleWrapperTouchStart): Show the controls if the wireless status

display is touched.

(ControllerIOS.prototype.handleFullscreenButtonClicked): Fix style
(ControllerIOS.prototype.handleWirelessPlaybackChange): Ditto.
(ControllerIOS.prototype.handleWirelessTargetAvailableChange):
(ControllerIOS.prototype.handleWirelessPickerButtonClicked): Ditto. Stop even propagation.

Move "playback target" logic into HTMLMediaSession.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call media session.
(WebCore::HTMLMediaElement::loadResource): Tell media session to apply media player

restrictions now that it has a url.

(WebCore::HTMLMediaElement::invalidateCachedTime): Only log when cached time is not

already invalie.

(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Call media session.
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged): Ditto.
(WebCore::HTMLMediaElement::addEventListener): Ditto.
(WebCore::HTMLMediaElement::removeEventListen): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
(WebCore::HTMLMediaElement::createMediaPlayer): Ditto.

  • html/HTMLMediaSession.cpp:

(WebCore::restrictionName): Log new WirelessVideoPlaybackDisabled restriction.
(WebCore::HTMLMediaSession::showingPlaybackTargetPickerPermitted): Return false if there

is no page, or if wireless playback is disabled.

(WebCore::HTMLMediaSession::currentPlaybackTargetIsWireless): New, logic from HTMLMediaElement.
(WebCore::HTMLMediaSession::showPlaybackTargetPicker): Ditto.
(WebCore::HTMLMediaSession::hasWirelessPlaybackTargets): Ditto.
(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Ditto.
(WebCore::HTMLMediaSession::setWirelessVideoPlaybackDisabled): Ditto.
(WebCore::HTMLMediaSession::setHasPlaybackTargetAvailabilityListeners): Ditto.
(WebCore::HTMLMediaSession::applyMediaPlayerRestrictions): New, apply media player specific

restriction.

  • html/HTMLMediaSession.h:

Move "playback target" logic into HTMLMediaSession.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute): Call media session.
(WebCore::HTMLVideoElement::webkitWirelessVideoPlaybackDisabled): Call media session.

  • platform/audio/MediaSessionManager.h:

(WebCore::MediaSessionManager::showPlaybackTargetPicker): New method, does nothing in base class.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::showPlaybackTargetPicker): Add non-functional stub.

Implement wireless playback control and status API.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Dispatch TargetIsWirelessChanged.
(WebCore::MediaPlayerPrivateAVFoundation::playbackTargetIsWirelessChanged): Pass through to

media element.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize

m_allowsWirelessVideoPlayback.

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Remove "externalPlaybackActive" observer.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): Fix broken logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Add "externalPlaybackActive" observer,

set initial wireless playback.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Fix broken logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::isCurrentPlaybackTargetWireless): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessVideoPlaybackDisabled): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackTargetIsWirelessDidChange): New.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Deal with

externalPlaybackActive.

11:47 AM Changeset in webkit [164660] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Win] Gracefully recover from missing 'naturalSize' parameter for media
https://bugs.webkit.org/show_bug.cgi?id=129278

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Add declaration for

missing function call.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::assetStatus): Don't treat missing 'naturalSize'
as a fatal error.
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged): Handle case of asset track
not being available yet.
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged): If the 'naturalSize' is empty,
use the Player Item's 'presentationSize' instead.
(WebCore::AVFWrapper::processNotification): Add missing handler for duration changed.

11:10 AM Changeset in webkit [164659] by svillar@igalia.com
  • 50 edits in trunk

[CSS Grid Layout] Add ENABLE flag
https://bugs.webkit.org/show_bug.cgi?id=129153

Reviewed by Simon Fraser.

.:

Added the ENABLE_CSS_GRID_LAYOUT feature flag to the cmake and
autotools build systems. The feature is disabled by default for
production builds.

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: added ENABLE_CSS_GRID_LAYOUT feature flag.

Source/WebCore:

Added ENABLE_CSS_GRID_LAYOUT feature flag.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSGridTemplateAreasValue.cpp:
  • css/CSSGridTemplateAreasValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSParser.h:
  • css/CSSParserMode.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

  • css/CSSPropertyNames.in:
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty):
(WebCore::matchingShorthandsForLonghand):

  • css/StyleResolver.cpp:

(WebCore::equivalentBlockDisplay):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::applyProperty):

  • css/StyleResolver.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

  • rendering/RenderGrid.cpp:
  • rendering/RenderGrid.h:
  • rendering/style/GridCoordinate.h:
  • rendering/style/GridLength.h:
  • rendering/style/GridPosition.h:
  • rendering/style/GridTrackSize.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleAllInOne.cpp:
  • rendering/style/StyleGridData.cpp:
  • rendering/style/StyleGridData.h:
  • rendering/style/StyleGridItemData.cpp:
  • rendering/style/StyleGridItemData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

Added ENABLE_CSS_GRID_LAYOUT feature flag.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Added ENABLE_CSS_GRID_LAYOUT feature flag.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
all ports for developer builds.

  • Scripts/webkitperl/FeatureList.pm:
10:53 AM Changeset in webkit [164658] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r164652.

  • GNUmakefile.list.am: Add WebVisitedLinkProvider build targets.
10:38 AM WebKitOrgShortLinks created by Brian Burg
10:34 AM WikiStart edited by Brian Burg
syntax is hard (diff)
10:33 AM Changeset in webkit [164657] by Dániel Bátyai
  • 2 edits in trunk/Tools

Added myself as a committer.

Unreviewed.

  • Scripts/webkitpy/common/config/contributors.json:
10:33 AM WikiStart edited by Brian Burg
Start an index of all the webkit.org/shortlinks (diff)
10:24 AM Changeset in webkit [164656] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[EME][Mac] Fix a few issues in CDMSessionMediaSourceAVFObjC.
https://bugs.webkit.org/show_bug.cgi?id=129310

Reviewed by Eric Carlson.

Only send a 'keyerror' event if an actual error code was returned, not just
when no key was added:

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::addKeyTimerFired):

The 'length' parameter to a typed ArrayBufferView is the number of entries
in the array, not the byte length:

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):

The return value of streamingContentKeyRequestDataForApp:contentIdentifier:trackId:options:error
is autoreleased; do not wrap it in an adoptNS:

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::update):

10:18 AM Changeset in webkit [164655] by thiago.lacerda@openbossa.org
  • 2 edits
    1 add in trunk/Source/WebCore

[MediaStream] Adding mock implementation of UserMediaClient
https://bugs.webkit.org/show_bug.cgi?id=129274

Reviewed by Eric Carlson.

  • platform/mock/UserMediaClientMock.h: Added.

(WebCore::UserMediaClientRequestNotifier::UserMediaClientRequestNotifier):

  • testing/Internals.cpp:

(WebCore::Internals::Internals):

9:57 AM Changeset in webkit [164654] by rniwa@webkit.org
  • 16 edits in trunk/Source/WebCore

Tighten bitfields in live NodeLists and HTMLCollections
https://bugs.webkit.org/show_bug.cgi?id=129300

Reviewed by Geoffrey Garen.

Reduce the number of bits used for m_rootType and m_type in LiveNodeList.
Also use enum class for LiveNodeList types. We keep "Type" suffix not to
confuse old-ish compilers.

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::ClassNodeList):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::collectionFirst):
(WebCore::LiveNodeList::collectionTraverseForward):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::NameNodeList):

  • dom/NameNodeList.h:

(WebCore::NameNodeList::create):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::namedNodeListKey):

  • dom/TagNodeList.cpp:

(WebCore::HTMLTagNodeList::HTMLTagNodeList):

  • dom/TagNodeList.h:

(WebCore::TagNodeList::create):
(WebCore::HTMLTagNodeList::create):

  • html/HTMLCollection.h:
  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::LabelsNodeList):

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):

  • html/RadioNodeList.h:

(WebCore::RadioNodeList::create):

9:53 AM Changeset in webkit [164653] by msaboff@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JIT Engines use the wrong stack limit for stack checks
https://bugs.webkit.org/show_bug.cgi?id=129314

Reviewed by Filip Pizlo.

Change the Baseline and DFG code to use VM::m_stackLimit for stack limit checks.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • runtime/VM.h:

(JSC::VM::addressOfStackLimit):

9:48 AM Changeset in webkit [164652] by andersca@apple.com
  • 8 edits
    2 adds in trunk/Source

Make it possible to set the visited link provider on a per page basis
https://bugs.webkit.org/show_bug.cgi?id=129288

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:

Export symbols needed by WebKit2.

  • WebCore.xcodeproj/project.pbxproj:

Make VisitedLinkProvider a private header.

  • page/Page.cpp:

(WebCore::Page::Page):
Take the visited link provider from the PageClients object.

(WebCore::Page::visitedLinkProvider):
If the page has a visited link provider set, return it.

  • page/Page.h:

Add VisitedLinkProvider to Page and PageClients.

Source/WebKit2:

Add WebVisitedLinkProvider which just calls the web process.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebVisitedLinkProvider.cpp: Added.

(WebKit::WebVisitedLinkProvider::create):
(WebKit::WebVisitedLinkProvider::WebVisitedLinkProvider):
(WebKit::WebVisitedLinkProvider::~WebVisitedLinkProvider):
(WebKit::WebVisitedLinkProvider::isLinkVisited):
(WebKit::WebVisitedLinkProvider::addVisitedLink):

  • WebProcess/WebPage/WebVisitedLinkProvider.h: Added.
9:47 AM Changeset in webkit [164651] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Unreviewed, roll out http://trac.webkit.org/changeset/164493.

It causes crashes, apparently because it's removing too many barriers. I will investigate
later.

  • bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):

  • bytecode/SpeculatedType.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):

  • dfg/DFGNode.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isNotNully):
(JSC::FTL::LowerDFGToLLVM::isNully):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):

9:15 AM Changeset in webkit [164650] by Brent Fulgham
  • 2 edits in branches/safari-537.60-branch/Source/WTF

Merge r152973

2013-07-22 Brent Fulgham <Brent Fulgham>

[Windows] Unreviewed build fix.

  • WTF.vcxproj/WTFGenerated.make: Stop triggering a "Build All" when things have not changed.
8:10 AM Changeset in webkit [164649] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[New Multicolumn] -webkit-column-break-inside:avoid doesn't work
https://bugs.webkit.org/show_bug.cgi?id=129299

Patch by Morten Stenshorne <mstensho@opera.com> on 2014-02-25
Reviewed by Andrei Bucur.

Source/WebCore:

adjustForUnsplittableChild() simply forgot to check whether we
were inside flow thread based multicol.

Test: fast/multicol/newmulticol/avoid-column-break-inside.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForUnsplittableChild):

LayoutTests:

  • fast/multicol/newmulticol/avoid-column-break-inside-expected.html: Added.
  • fast/multicol/newmulticol/avoid-column-break-inside.html: Added.
7:08 AM Changeset in webkit [164648] by tgergely.u-szeged@partner.samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Moved myself to the list of committers.

  • Scripts/webkitpy/common/config/contributors.json:
6:53 AM Changeset in webkit [164647] by pmolnar.u-szeged@partner.samsung.com
  • 2 edits in trunk/Tools

Move myself to the committers list.

Unreviewed.

  • Scripts/webkitpy/common/config/contributors.json:
6:51 AM Changeset in webkit [164646] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

[CSSRegions] Remove unused function RenderFlowThread::regionForCompositedLayer
https://bugs.webkit.org/show_bug.cgi?id=129303

Reviewed by Andrei Bucur.

Cleanup, no funtionality change, no new tests.

  • rendering/RenderFlowThread.h:
6:48 AM Changeset in webkit [164645] by llango.u-szeged@partner.samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
6:07 AM Changeset in webkit [164644] by Manuel Rego Casasnovas
  • 3 edits in trunk/Tools

Unreviewed, rolling out r164639.
http://trac.webkit.org/changeset/164639
https://bugs.webkit.org/show_bug.cgi?id=129302

gtk-doc still have problems in EWS (Requested by rego on
#webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2014-02-25

  • Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command):
(GtkWK2Port.build_webkit_command):

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest.test_gtk_wk2_port):

5:31 AM Changeset in webkit [164643] by g.czajkowski@samsung.com
  • 7 edits
    3 adds
    9 deletes in trunk/LayoutTests

Refactoring inline_spelling_markers.html to use asynchronous spellchecking
https://bugs.webkit.org/show_bug.cgi?id=127284

Reviewed by Ryosuke Niwa.

Use asynchronous text checking in inline-spelling-markers.html and
inline-spelling-markers-hidpi.html

Rename the test to inline-spelling-markers.html to match the naming convention.

  • editing/spelling/inline-spelling-markers-expected.txt: Added.

Make cross platform text expectation by dumping spelling/grammar markers
instead of whole tree which in terms of spellchecking says nothing.

  • editing/spelling/inline-spelling-markers.html: Added.

Remove unnecessary new lines from div elements so position of markers can be given from 0.
Activate text checking by adding a word separator so WebKit starts performing spell and grammar
checking. Selection change does not invoke grammar checking unless we start editing the input
element's content.

  • platform/efl/editing/spelling/inline_spelling_markers-expected.png: Removed.
  • platform/efl/editing/spelling/inline_spelling_markers-expected.txt: Removed.
  • platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Removed.
  • platform/gtk/editing/spelling/inline_spelling_markers-expected.txt: Removed.
  • platform/mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
  • platform/mac/editing/spelling/inline_spelling_markers-expected.txt: Removed.

Those are not needed as pixel tests don't introduce anything special here.
Let's keep them in hidpi test only.

  • editing/spelling/inline-spelling-markers-hidpi-expected.txt:
  • editing/spelling/inline-spelling-markers-hidpi.html:

Apply changes from inline-spelling-markers.html

  • platform/mac/editing/spelling/inline-spelling-markers-hidpi-expected.png: Added.
  • platform/efl/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.
  • platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Removed.

Remove wrong baselines due to missing grammar markers.

  • platform/efl-wk2/TestExpectations:
  • platform/gtk/TestExpectations:

Mark inline-spelling-markers.html and its hidpi version as failures
since EFL and GTK do not implement grammar checking.

  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:

Mark inline-spelling-markers.html and its hidpi version as failures
due to missing TextChecker::requestCheckingOfString() implementation.

5:27 AM WebKitGTK/2.4.x edited by desrt@desrt.ca
BSD DFG JIT PLZ (diff)
4:44 AM Changeset in webkit [164642] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

PrettyPatch.rb should be more descriptive for "git diff -M" styled patches
https://bugs.webkit.org/show_bug.cgi?id=125514

Patch by Jozsef Berta <jberta.u-szeged@partner.samsung.com> on 2014-02-25
Reviewed by Csaba Osztrogonác.

  • PrettyPatch/PrettyPatch.rb: PrettyPatch.rb is modified to show which file was renamed or moved.
2:33 AM Changeset in webkit [164641] by stavila@adobe.com
  • 1 edit
    4 adds in trunk/LayoutTests

[CSS Regions] scrollIntoView for elements flowed into regions
https://bugs.webkit.org/show_bug.cgi?id=129151

Reviewed by Mihnea Ovidenie.

Added tests for scrollIntoView on elements flowed inside regions.

  • fast/regions/scroll-into-view-expected.html: Added.
  • fast/regions/scroll-into-view-relative-expected.html: Added.
  • fast/regions/scroll-into-view-relative.html: Added.
  • fast/regions/scroll-into-view.html: Added.
2:16 AM Changeset in webkit [164640] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Blending] -webkit-mix-blend-mode should force transform-style: flat.
https://bugs.webkit.org/show_bug.cgi?id=126158

Patch by Mihai Tica <mitica@adobe.com> on 2014-02-25
Reviewed by Mihnea Ovidenie.

Source/WebCore:

As stated in the http://www.w3.org/TR/css3-transforms/#propdef-transform-style, an element with blending
should force transform-style: flat.

Test: css3/compositing/blend-mode-transform-style.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): If blending is detected, set transform-style to flat.

LayoutTests:

For an element with -webkit-mix-blend-mode, test that the value of -webkit-transform-style computes to flat.

  • css3/compositing/blend-mode-transform-style-expected.txt: Added.
  • css3/compositing/blend-mode-transform-style.html: Added.
2:05 AM Changeset in webkit [164639] by Manuel Rego Casasnovas
  • 3 edits in trunk/Tools

[GTK] Re-enable gtk-doc in EWS
https://bugs.webkit.org/show_bug.cgi?id=128369

Reviewed by Carlos Garcia Campos.

Enable again gtk-doc generation in EWS once bug #128417 has been fixed.

  • Scripts/webkitpy/common/config/ports.py:

(GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
(GtkWK2Port.build_webkit_command): Ditto.

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port): Ditto.
(DeprecatedPortTest.test_gtk_wk2_port): Ditto.

12:47 AM Changeset in webkit [164638] by zandobersek@gmail.com
  • 12 edits in trunk/Source/WebCore

Move to using std::unique_ptr for Element, Node and related classes
https://bugs.webkit.org/show_bug.cgi?id=129058

Reviewed by Anders Carlsson.

Replace uses of OwnPtr and PassOwnPtr in Element, Node and the related
classes with std::unique_ptr and move semantics.

  • dom/ContainerNode.h:

(WebCore::ChildNodesLazySnapshot::takeSnapshot):
(WebCore::ChildNodesLazySnapshot::hasSnapshot):

  • dom/Element.cpp:

(WebCore::ensureAttrNodeListForElement):
(WebCore::Element::attributes):

  • dom/ElementIteratorAssertions.h:

(WebCore::ElementIteratorAssertions::ElementIteratorAssertions):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::setAttributeMap):

  • dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::observedSubtreeNodeWillDetach):
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet):

  • dom/MutationObserverRegistration.h:
  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::NamedNodeMap):

  • dom/Node.cpp:

(WebCore::Node::ensureRareData):
(WebCore::Node::didMoveToNewDocument):
(WebCore::Node::ensureEventTargetData):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::unregisterMutationObserver):
(WebCore::Node::notifyMutationObserversNodeWillDetach):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::NodeListsNodeData):
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::clearNodeLists):
(WebCore::NodeRareData::ensureNodeLists):
(WebCore::NodeRareData::ensureMutationObserverData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

12:19 AM Changeset in webkit [164637] by akling@apple.com
  • 16 edits
    3 deletes in trunk/Source

Prune dead code for Web Inspector memory instrumentation.
<https://webkit.org/b/129286>

Source/WebCore:

This was leftover code from Chromium's inspector. It's not used by
today's WebKit inspector.

Reviewed by Sam Weinig.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorController.h:
  • inspector/InspectorMemoryAgent.cpp: Removed.
  • inspector/InspectorMemoryAgent.h: Removed.
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/protocol/Memory.json: Removed.

Source/WebInspectorUI:

Reviewed by Sam Weinig.

  • UserInterface/Protocol/InspectorWebBackendCommands.js:
12:09 AM Changeset in webkit [164636] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix for case-sensitive filesystems.

  • WebProcess/ios/WebVideoFullscreenManager.cpp:
12:08 AM Changeset in webkit [164635] by Chris Fleizach
  • 9 edits
    2 adds in trunk

AX: Support abbr, acronym
https://bugs.webkit.org/show_bug.cgi?id=128860

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Expose the data in <abbr>, <acronym> and <th abbr=""> as an
alternateTextValue() parameter.

Test: platform/mac/accessibility/abbr-acronym-tags.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasTagName):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::alternateTextValue):
(WebCore::AccessibilityObject::supportsAlternateTextValue):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::alternateTextValue):
(WebCore::AccessibilityRenderObject::supportsAlternateTextValue):

  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::alternateTextValue):
(WebCore::AccessibilityTableCell::supportsAlternateTextValue):

  • accessibility/AccessibilityTableCell.h:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetAlternateTextValue):
(AXAttributedStringAppendText):
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

  • platform/mac/accessibility/abbr-acronym-tags-expected.txt: Added.
  • platform/mac/accessibility/abbr-acronym-tags.html: Added.

Feb 24, 2014:

11:51 PM Changeset in webkit [164634] by Carlos Garcia Campos
  • 8 edits in trunk

[GTK] Mark view source mode methods as deprecated
https://bugs.webkit.org/show_bug.cgi?id=128920

Reviewed by Martin Robinson.

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp: Mark set/get_view_source_mode as

deprecated in the documentation.

  • webkit/webkitwebview.h: Add deprecation guards.

Source/WebKit2:

Mark WEBKIT_VIEW_MODE_SOURCE as deprecated in documentation and
only show warnings when set_view_mode is used with WEBKIT_VIEW_MODE_SOURCE.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_set_view_mode):
(webkit_web_view_get_view_mode):

  • UIProcess/API/gtk/WebKitWebView.h:

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(beforeAll): Remove view mode test.

11:49 PM Changeset in webkit [164633] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Stop looking for plug-in profiles in /S/L/Sandbox/Profiles
https://bugs.webkit.org/show_bug.cgi?id=129262
<rdar://problem/16149420>

Reviewed by Sam Weinig.

Remove unused code.

  • Shared/Plugins/mac/PluginSandboxProfile.mm:

(WebKit::pluginSandboxProfileDirectory):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfile):

11:30 PM Changeset in webkit [164632] by mrobinson@webkit.org
  • 16 edits in trunk

[GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
https://bugs.webkit.org/show_bug.cgi?id=128417

Reviewed by Carlos Garcia Campos.

.:

  • Source/cmake/OptionsGTK.cmake: Define the paths to the pkgconfig files here, so that they

may one day be used in the webkitdom config file generation.

Source/WebCore:

  • bindings/gobject/GNUmakefile.am: Generate a config file for webkitdom documentation generation.

Source/WebKit:

  • PlatformGTK.cmake: Correct the definition of WebKitGTK_ENUM_GENERATION_HEADERS and generate

a gtkdoc-webkitgtk.cfg file to be used by generate-gtkdoc.

Source/WebKit/gtk:

  • GNUmakefile.am: Generate a config file for generate-gtkdoc.

Source/WebKit2:

  • GNUmakefile.am: Generate a config file for generate-gtkdoc.
  • PlatformGTK.cmake: Ditto.

Tools:

  • gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
  • gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from

a makefile. This allows accepting a header list from the build system, which can be used
to dynamically build a list of ignored files. We can ignore any source file that doesn't
have a corresponding header file on the header list.

  • gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just

source directories to gtkdoc-scan.

11:13 PM Changeset in webkit [164631] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix build.

10:59 PM Changeset in webkit [164630] by oliver@apple.com
  • 20 edits
    3 adds in trunk

Spread operator has a bad time when applied to call function
https://bugs.webkit.org/show_bug.cgi?id=128853

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Follow on from the previous patch the added an extra slot to
op_call_varargs (and _call, _call_eval, _construct). We now
use the slot as an offset to in effect act as a 'slice' on
the spread subject. This allows us to automatically retain
all our existing argument and array optimisatons. Most of
this patch is simply threading the offset around.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::getArgumentByVal):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::sizeFrameForVarargs):
(JSC::loadVarargs):

  • interpreter/Interpreter.h:
  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

  • jit/JIT.h:
  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • runtime/Arguments.cpp:

(JSC::Arguments::copyToArguments):

  • runtime/Arguments.h:
  • runtime/JSArray.cpp:

(JSC::JSArray::copyToArguments):

  • runtime/JSArray.h:

LayoutTests:

Test case all the things!

  • js/regress/call-spread-call-expected.txt: Added.
  • js/regress/call-spread-call.html: Added.
  • js/regress/script-tests/call-spread-call.js: Added.

(testFunction):
(test2):
(test3):

10:46 PM Changeset in webkit [164629] by timothy@apple.com
  • 19 edits in trunk/Source/WebInspectorUI

Switch from prefixed CSS gradient to unprefixed.

https://bugs.webkit.org/show_bug.cgi?id=129279

Reviewed by Andreas Kling.

  • UserInterface/Views/BreakpointActionView.css:

(.breakpoint-action-append-button):
(.breakpoint-action-remove-button):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):

  • UserInterface/Views/CompletionSuggestionsView.css:

(.completion-suggestions-container > .item:active):

  • UserInterface/Views/DashboardView.css:

(.toolbar .dashboard):

  • UserInterface/Views/DataGrid.css:

(.data-grid th):
(.data-grid table.data):
(.data-grid th.sortable:not(.mouse-over-collapser):active):
(.data-grid th.sort-ascending, .data-grid th.sort-descending):
(.data-grid th.sortable.sort-ascending:not(.mouse-over-collapser):active, .data-grid th.sortable.sort-descending:not(.mouse-over-collapser):active):
(body.window-inactive .data-grid th.sort-descending):

  • UserInterface/Views/DetailsSection.css:

(.details-section > .header):
(.details-section .details-section > .header):

  • UserInterface/Views/DividerNavigationItem.css:

(.navigation-bar .item.divider):

  • UserInterface/Views/FindBanner.css:

(.find-banner > button:active:not(:disabled)):

  • UserInterface/Views/Main.css:

(#split-content-browser > .navigation-bar):

  • UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .overflow-shadow):
(.navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):

  • UserInterface/Views/ProbeSetDataGrid.css:

(.details-section.probe-set .data-grid > .data-container td.unknown-value):
(.details-section.probe-set .data-grid th):

  • UserInterface/Views/RadioButtonNavigationItem.css:

(.navigation-bar .item.radio.button.text-only.selected):

  • UserInterface/Views/TextEditor.css:

(.text-editor .bouncy-highlight):

  • UserInterface/Views/TimelineContentView.css:

(.content-view.timeline > .view-container > .timeline-view > .data-grid table.data):

  • UserInterface/Views/TimelineDataGrid.css:

(.timeline-data-grid-tree-outline .item:hover):

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .header > .divider):

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.timeline > .title-bar):
(.sidebar > .panel.timeline > .content > .stripe-background):

  • UserInterface/Views/Toolbar.css:

(body:not(.mac-platform) .toolbar):
(body.docked.mac-platform.mavericks .toolbar):

9:45 PM Changeset in webkit [164628] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

32-bit build fix.

  • UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction elementActionWithType:customTitle:]):

8:44 PM Changeset in webkit [164627] by mark.lam@apple.com
  • 10 edits in trunk/Source

Need to initialize VM stack data even when the VM is on an exclusive thread.
<https://webkit.org/b/129265>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

We check VM::exclusiveThread as an optimization to forego the need to do
JSLock locking. However, we recently started piggy backing on JSLock's
lock() and unlock() to initialize VM stack data (stackPointerAtVMEntry
and lastStackTop) to appropriate values for the current thread. This is
needed because we may be acquiring the lock to enter the VM on a different
thread.

As a result, we ended up not initializing the VM stack data when
VM::exclusiveThread causes us to bypass the locking activity. Even though
the VM::exclusiveThread will not have to deal with the VM being entered
on a different thread, it still needs to initialize the VM stack data.
The VM relies on that data being initialized properly once it has been
entered.

With this fix, we push the check for exclusiveThread down into the JSLock,
and handle the bypassing of unneeded locking activity there while still
executing the necessary the VM stack data initialization.

  • API/APIShims.h:

(JSC::APIEntryShim::APIEntryShim):
(JSC::APICallbackShim::shouldDropAllLocks):

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::addCurrentThread):

  • runtime/JSLock.cpp:

(JSC::JSLockHolder::JSLockHolder):
(JSC::JSLockHolder::init):
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSLock::unlock):
(JSLock::currentThreadIsHoldingLock):
(JSLock::dropAllLocks):
(JSLock::grabAllLocks):

  • runtime/JSLock.h:

(JSC::JSLock::exclusiveThread):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):
(JSC::VM::currentThreadIsHoldingAPILock):

Source/WebCore:

No new tests.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • Added an assertion to ensure that we are holding the JSLock.
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

  • Updated to use the new VM::setExclusiveThread().
8:00 PM Changeset in webkit [164626] by mitz@apple.com
  • 5 edits
    6 adds in trunk/Source/WebKit2

[Cocoa] Start adding API for customizing actions on activated elements
https://bugs.webkit.org/show_bug.cgi?id=129284

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/_WKActivatedElementInfo.h: Added. Includes the public interface of what

was WKElementActionInfo.

  • UIProcess/API/Cocoa/_WKActivatedElementInfo.m: Added.

(-[_WKActivatedElementInfo _initWithURL:location:title:rect:]): Moved and renamed internal
initializer from WKElementActionInfo.
(-[_WKActivatedElementInfo dealloc]): Moved from WKElementActionInfo.
(-[_WKActivatedElementInfo _boundingRect]): Added private accessor.
(-[_WKActivatedElementInfo _interactionLocation]): Ditto.

  • UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h: Added.
  • UIProcess/API/Cocoa/_WKElementAction.h: Added.

(_WKElementActionType): Moved from WKActionSheet.h and turned into a proper NS_ENUM.

  • UIProcess/API/Cocoa/_WKElementAction.mm: Added.

(-[_WKElementAction _initWithTitle:actionHandler:type:]): Moved and renamed internal
initializer from WKActionSheet.mm.
(-[_WKElementAction dealloc]): Moved from WKActionSheet.mm.
(+[_WKElementAction elementActionWithTitle:actionHandler:]): Moved and renamed.
(copyElement): Moved from WKActionSheet.mm.
(saveImage): Ditto.
(addToReadingList): Ditto.
(+[_WKElementAction elementActionWithType:customTitle:]): Moved and renamed.
(+[_WKElementAction elementActionWithType:]): Ditto.
(-[_WKElementAction _runActionWithElementInfo:view:]): Moved from WKActionSheet.mm.

  • UIProcess/API/Cocoa/WKElementActionInternal.h: Added.
  • UIProcess/ios/WKActionSheet.h: Removed declarations that were moved elsewhere.
  • UIProcess/ios/WKActionSheet.mm: Removed code that was moved elsewhere.
  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files. Changed the Objective-C

class name check to allow _WK as a class name prefix.

7:34 PM Changeset in webkit [164625] by dino@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed. This file should not be marked as executable (copied in from ANGLE).

  • include/KHR/khrplatform.h:
7:33 PM Changeset in webkit [164624] by andersca@apple.com
  • 16 edits
    2 copies in trunk

Add a DefaultVisitedLinkProvider and route visited link actions through it
https://bugs.webkit.org/show_bug.cgi?id=129285

Reviewed by Dan Bernstein.

Source/WebCore:

DefaultVisitedLinkProvider currently just forwards everything to the visited link strategy,
but will soon take over the responsibilities of visited link handling from PageGroup.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/VisitedLinkState.cpp:

(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • loader/HistoryController.cpp:

(WebCore::addVisitedLink):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::updateForClientRedirect):
(WebCore::HistoryController::updateForSameDocumentNavigation):
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

  • page/DefaultVisitedLinkProvider.cpp: Copied from Source/WebCore/page/VisitedLinkProvider.h.

(WebCore::DefaultVisitedLinkProvider::create):
(WebCore::DefaultVisitedLinkProvider::DefaultVisitedLinkProvider):
(WebCore::DefaultVisitedLinkProvider::~DefaultVisitedLinkProvider):
(WebCore::DefaultVisitedLinkProvider::isLinkVisited):
(WebCore::DefaultVisitedLinkProvider::addVisitedLink):

  • page/DefaultVisitedLinkProvider.h: Copied from Source/WebCore/page/VisitedLinkProvider.h.
  • page/Page.cpp:

(WebCore::Page::visitedLinkProvider):

  • page/Page.h:
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::visitedLinkProvider):

  • page/PageGroup.h:
  • page/VisitedLinkProvider.h:

Tools:

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate applicationDidFinishLaunching:]):
Set a shared history so we'll get visited link tracking.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController awakeFromNib]):
Set a group name.

7:00 PM Changeset in webkit [164623] by timothy@apple.com
  • 7 edits in trunk/Source/WebInspectorUI

Fix the missing navigation bar in the Debugger sidebar panel.

Sorting the CSS resources caused specificity issue.

https://bugs.webkit.org/show_bug.cgi?id=129251

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger > .content):
(.sidebar > .panel.navigation.debugger > .navigation-bar):

  • UserInterface/Views/LayoutTimelineView.css:

(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.layout .item .subtitle):

  • UserInterface/Views/NetworkTimelineView.css:

(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.network .item .subtitle):

  • UserInterface/Views/ResourceSidebarPanel.css:

(.sidebar > .panel.navigation.resource > .empty-content-placeholder):
(.sidebar > .panel.navigation.resource > .search-bar):
(.sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):

  • UserInterface/Views/ScriptTimelineView.css:

(.sidebar > .panel.navigation.timeline.timeline-content-view-showing .navigation-sidebar-panel-content-tree-outline.script .item .subtitle):

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .status-bar):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(.sidebar > .panel.navigation.timeline > .title-bar):
(.sidebar > .panel.navigation.timeline > .title-bar.timelines):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(.sidebar > .panel.navigation.timeline > .timelines-content):
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item .icon):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected .close-button):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):nth-child(even)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):not(:first-child)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button:active):
(.sidebar > .panel.navigation.timeline > .empty-content-placeholder):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content):
(.sidebar > .panel.navigation.timeline > .content > .stripe-background):
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background):

6:59 PM Changeset in webkit [164622] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Use RetainPtrs for two WKContentView data members
https://bugs.webkit.org/show_bug.cgi?id=129276

Reviewed by Benjamin Poulain.

The UITextInputTraits were leaked. Fix with RetainPtr goodness.

Rename the obscure _accessory to _formAccessoryView and
make it a RetainPtr.

Rearrange the data members of the WKContentView class extension
for better packing and readability.

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):
(-[WKContentView inputAccessoryView]):
(-[WKContentView _updateAccessory]):
(-[WKContentView textInputTraits]):

6:40 PM Changeset in webkit [164621] by Simon Fraser
  • 13 edits
    2 moves
    1 delete in trunk/Source/WebKit2

Remove WKInteractionView, move code into WKContentView
https://bugs.webkit.org/show_bug.cgi?id=129275

Reviewed by Benjamin Poulain.

WKInteractionView as an interim solution as WebKit2 on iOS was being
brought up, and should be removed.

Move its code into a category on WKContentView, mostly unchanged. The
WKContentView (WKInteraction) categroy now implements the various protocols
that WKInteractionView implemented.

WKContentView is not an API class, so no longer has WK_API_CLASS, and can
have implementation-related data members. WKContentViewInternal.h is removed.

WKContentView now exposes a WebPageProxy* rather than a WKPageRef.

Other changes: WKActionSheetAssistant no longer stores a WebPageProxy,
getting it from the WKContentView instead.

WKAutoCorrectionData and InteractionInformationAtPosition are stored via unique_ptr
to reduce class size, and avoid having to expose their details in the header.

  • Configurations/WebKit2.xcconfig:
  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView setAllowsBackForwardNavigationGestures:]):
(-[WKView pageRef]):
(-[WKView _pageExtendedBackgroundColor]):
(-[WKView _setBackgroundExtendsBeyondPage:]):
(-[WKView _backgroundExtendsBeyondPage]):

  • UIProcess/ios/PageClientImplIOS.mm:
  • UIProcess/ios/WKActionSheet.h:
  • UIProcess/ios/WKActionSheet.mm:

(-[WKActionSheet initWithView:]):
(+[WKElementAction customElementActionWithTitle:actionHandler:]):
(copyElement):
(saveImage):
(+[WKElementAction standardElementActionWithType:customTitle:]):
(-[WKElementAction runActionWithElementInfo:view:]):

  • UIProcess/ios/WKActionSheetAssistant.h:
  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant initWithView:]):
(-[WKActionSheetAssistant dealloc]):
(-[WKActionSheetAssistant initialPresentationRectInHostViewForSheet]):
(-[WKActionSheetAssistant presentationRectInHostViewForSheet]):
(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]):
(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
(-[WKActionSheetAssistant cleanupSheet]):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::]):
(-[WKContentView dealloc]):
(-[WKContentView page]):
(-[WKContentView isAssistingNode]):
(-[WKContentView didFinishScrolling]):
(-[WKContentView willStartZoomOrScroll]):
(-[WKContentView willStartUserTriggeredScroll]):
(-[WKContentView willStartUserTriggeredZoom]):
(-[WKContentView didZoomToScale:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _didCommitLayerTree:WebKit::]):

  • UIProcess/ios/WKContentViewInteraction.h: Renamed from Source/WebKit2/UIProcess/ios/WKInteractionView.h.
  • UIProcess/ios/WKContentViewInteraction.mm: Renamed from Source/WebKit2/UIProcess/ios/WKInteractionView.mm.

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView positionInformation]):
(-[WKContentView setInputDelegate:]):
(-[WKContentView inputDelegate]):
(-[WKContentView isEditable]):
(-[WKContentView canBecomeFirstResponder]):
(-[WKContentView resignFirstResponder]):
(-[WKContentView _webTouchEventsRecognized:]):
(inflateQuad):
(-[WKContentView _webTouchEvent:WebKit::preventsNativeGestures:]):
(-[WKContentView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
(-[WKContentView _cancelLongPressGestureRecognizer]):
(-[WKContentView _didScroll]):
(-[WKContentView _requiresKeyboardResetOnReload]):
(-[WKContentView gestureRecognizer:canPreventGestureRecognizer:]):
(-[WKContentView gestureRecognizer:canBePreventedByGestureRecognizer:]):
(isSamePair):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _showImageSheet]):
(-[WKContentView _showLinkSheet]):
(-[WKContentView _showDataDetectorsSheet]):
(-[WKContentView _actionForLongPress]):
(-[WKContentView ensurePositionInformationIsUpToDate:]):
(-[WKContentView _updatePositionInformation]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _cancelInteraction]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsInAssistedNode:]):
(-[WKContentView webSelectionRects]):
(-[WKContentView _highlightLongPressRecognized:]):
(-[WKContentView _longPressRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
(-[WKContentView _twoFingerDoubleTapRecognized:]):
(-[WKContentView _twoFingerPanRecognized:]):
(-[WKContentView _attemptClickAtLocation:]):
(-[WKContentView useSelectionAssistantWithMode:]):
(-[WKContentView clearSelection]):
(-[WKContentView _positionInformationDidChange:]):
(-[WKContentView _willStartScrollingOrZooming]):
(-[WKContentView _willStartUserTriggeredScrollingOrZooming]):
(-[WKContentView _didEndScrollingOrZooming]):
(-[WKContentView inputAccessoryView]):
(-[WKContentView supportedPasteboardTypesForCurrentSelection]):
(-[WKContentView _addShortcut:]):
(-[WKContentView _promptForReplace:]):
(-[WKContentView replace:]):
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView _resetShowingTextStyle:]):
(-[WKContentView _performAction:]):
(-[WKContentView copy:]):
(-[WKContentView cut:]):
(-[WKContentView paste:]):
(-[WKContentView select:]):
(-[WKContentView selectAll:]):
(-[WKContentView toggleBoldface:]):
(-[WKContentView toggleItalics:]):
(-[WKContentView toggleUnderline:]):
(-[WKContentView _showTextStyleOptions:]):
(-[WKContentView _showDictionary:]):
(-[WKContentView _define:]):
(toWKGestureType):
(toUIWKGestureType):
(toWKSelectionTouch):
(toUIWKSelectionTouch):
(toWKGestureRecognizerState):
(toUIGestureRecognizerState):
(toUIWKSelectionFlags):
(toWKHandlePosition):
(selectionChangedWithGesture):
(selectionChangedWithTouch):
(-[WKContentView _didUpdateBlockSelectionWithTouch:WebKit::withFlags:WebKit::growThreshold:shrinkThreshold:]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(-[WKContentView changeBlockSelectionWithTouchAt:withSelectionTouch:forHandle:]):
(-[WKContentView autocorrectionData]):
(-[WKContentView requestAutocorrectionRectsForString:withCompletionHandler:]):
(-[WKContentView textFirstRect]):
(-[WKContentView textLastRect]):
(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):
(-[WKContentView accessoryDone]):
(-[WKContentView accessoryTab:]):
(-[WKContentView accessoryAutoFill]):
(-[WKContentView accessoryClear]):
(-[WKContentView _updateAccessory]):
(-[WKContentView textInRange:]):
(-[WKContentView replaceRange:withText:]):
(-[WKContentView selectedTextRange]):
(-[WKContentView caretRectForPosition:]):
(-[WKContentView selectionRectsForRange:]):
(-[WKContentView setSelectedTextRange:]):
(-[WKContentView hasMarkedText]):
(-[WKContentView markedText]):
(-[WKContentView markedTextRange]):
(-[WKContentView markedTextStyle]):
(-[WKContentView setMarkedTextStyle:]):
(-[WKContentView setMarkedText:selectedRange:]):
(-[WKContentView unmarkText]):
(-[WKContentView beginningOfDocument]):
(-[WKContentView endOfDocument]):
(-[WKContentView textRangeFromPosition:toPosition:]):
(-[WKContentView positionFromPosition:offset:]):
(-[WKContentView positionFromPosition:inDirection:offset:]):
(-[WKContentView comparePosition:toPosition:]):
(-[WKContentView offsetFromPosition:toPosition:]):
(-[WKContentView tokenizer]):
(-[WKContentView positionWithinRange:farthestInDirection:]):
(-[WKContentView characterRangeByExtendingPosition:inDirection:]):
(-[WKContentView baseWritingDirectionForPosition:inDirection:]):
(-[WKContentView setBaseWritingDirection:forRange:]):
(-[WKContentView firstRectForRange:]):
(-[WKContentView closestPositionToPoint:]):
(-[WKContentView closestPositionToPoint:withinRange:]):
(-[WKContentView characterRangeAtPoint:]):
(-[WKContentView deleteBackward]):
(-[WKContentView insertText:]):
(-[WKContentView hasText]):
(-[WKContentView textInputTraits]):
(-[WKContentView interactionAssistant]):
(-[WKContentView webSelectionAssistant]):
(-[WKContentView selectionRange]):
(-[WKContentView rectForNSRange:]):
(-[WKContentView _markedTextNSRange]):
(-[WKContentView selectedDOMRange]):
(-[WKContentView setSelectedDOMRange:affinityDownstream:]):
(-[WKContentView replaceRangeWithTextWithoutClosingTyping:replacementText:]):
(-[WKContentView rectContainingCaretSelection]):
(-[WKContentView requiresKeyEvents]):
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
(-[WKContentView setBottomBufferHeight:]):
(-[WKContentView automaticallySelectedOverlay]):
(-[WKContentView selectionGranularity]):
(-[WKContentView insertDictationResult:withCorrectionIdentifier:]):
(-[WKContentView metadataDictionariesForDictationResults]):
(-[WKContentView previousUnperturbedDictationResultBoundaryFromPosition:]):
(-[WKContentView nextUnperturbedDictationResultBoundaryFromPosition:]):
(-[WKContentView moveBackward:]):
(-[WKContentView moveForward:]):
(-[WKContentView characterBeforeCaretSelection]):
(-[WKContentView wordContainingCaretSelection]):
(-[WKContentView wordRangeContainingCaretSelection]):
(-[WKContentView setMarkedText:]):
(-[WKContentView hasContent]):
(-[WKContentView selectAll]):
(-[WKContentView textColorForCaretSelection]):
(-[WKContentView fontForCaretSelection]):
(-[WKContentView hasSelection]):
(-[WKContentView isPosition:atBoundary:inDirection:]):
(-[WKContentView positionFromPosition:toBoundary:inDirection:]):
(-[WKContentView isPosition:withinTextUnit:inDirection:]):
(-[WKContentView rangeEnclosingPosition:withGranularity:inDirection:]):
(-[WKContentView takeTraitsFrom:]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingKeyboard]):
(-[WKContentView _startAssistingNode]):
(-[WKContentView _stopAssistingNode]):
(-[WKContentView _selectionChanged]):
(-[WKContentView shouldIgnoreWebTouch]):
(-[WKContentView isAnyTouchOverActiveArea:]):
(-[WKTextRange _isCaret]):
(-[WKTextRange _isRanged]):
(+[WKTextRange textRangeWithState:isRange:isEditable:startRect:endRect:selectionRects:selectedTextLength:]):
(-[WKTextRange dealloc]):
(-[WKTextRange description]):
(-[WKTextRange start]):
(-[WKTextRange end]):
(-[WKTextRange isEmpty]):
(-[WKTextRange isEqual:]):
(+[WKTextPosition textPositionWithRect:]):
(-[WKTextPosition isEqual:]):
(-[WKTextPosition description]):
(-[WKTextSelectionRect initWithWebRect:]):
(-[WKTextSelectionRect dealloc]):
(+[WKTextSelectionRect textSelectionRectsWithWebRects:]):
(-[WKTextSelectionRect rect]):
(-[WKTextSelectionRect writingDirection]):
(-[WKTextSelectionRect range]):
(-[WKTextSelectionRect containsStart]):
(-[WKTextSelectionRect containsEnd]):
(-[WKTextSelectionRect isVertical]):
(+[WKAutocorrectionRects autocorrectionRectsWithRects:lastRect:]):
(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):
(-[WKAutocorrectionContext dealloc]):

  • UIProcess/ios/WKContentViewInternal.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
6:02 PM Changeset in webkit [164620] by fpizlo@apple.com
  • 26 edits
    8 adds in trunk

FTL should do polymorphic PutById inlining
https://bugs.webkit.org/show_bug.cgi?id=129210

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg and Oliver Hunt.

This makes PutByIdStatus inform us about polymorphic cases by returning an array of
PutByIdVariants. The DFG now has a node called MultiPutByOffset that indicates a
selection of multiple inlined PutByIdVariants.

MultiPutByOffset is almost identical to MultiGetByOffset, which we added in
http://trac.webkit.org/changeset/164207.

This also does some FTL refactoring to make MultiPutByOffset share code with some nodes
that generate similar code.

1% speed-up on V8v7 due to splay improving by 6.8%. Splay does the thing where it
sometimes swaps field insertion order, creating fake polymorphism.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::dump):

  • bytecode/PutByIdStatus.h:

(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::isSimple):
(JSC::PutByIdStatus::numVariants):
(JSC::PutByIdStatus::variants):
(JSC::PutByIdStatus::at):
(JSC::PutByIdStatus::operator[]):

  • bytecode/PutByIdVariant.cpp: Added.

(JSC::PutByIdVariant::dump):
(JSC::PutByIdVariant::dumpInContext):

  • bytecode/PutByIdVariant.h: Added.

(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::kind):
(JSC::PutByIdVariant::isSet):
(JSC::PutByIdVariant::operator!):
(JSC::PutByIdVariant::structure):
(JSC::PutByIdVariant::oldStructure):
(JSC::PutByIdVariant::newStructure):
(JSC::PutByIdVariant::structureChain):
(JSC::PutByIdVariant::offset):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::emitPrototypeChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::emitPutById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::putByOffsetStoreElimination):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:
  • dfg/DFGNode.cpp:

(JSC::DFG::MultiPutByOffsetData::writesStructures):
(JSC::DFG::MultiPutByOffsetData::reallocatesStorage):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::hasMultiPutByOffsetData):
(JSC::DFG::Node::multiPutByOffsetData):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileReallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::loadProperty):
(JSC::FTL::LowerDFGToLLVM::storeProperty):
(JSC::FTL::LowerDFGToLLVM::addressOfProperty):
(JSC::FTL::LowerDFGToLLVM::storageForTransition):
(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::reallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::emitStoreBarrier):

  • tests/stress/fold-multi-put-by-offset-to-put-by-offset.js: Added.
  • tests/stress/multi-put-by-offset-reallocation-butterfly-cse.js: Added.
  • tests/stress/multi-put-by-offset-reallocation-cases.js: Added.

LayoutTests:

Reviewed by Mark Hahnenberg and Oliver Hunt.

Add a microbenchmark for polymorphic PutById.

  • js/regress/polymorphic-put-by-id-expected.txt: Added.
  • js/regress/polymorphic-put-by-id.html: Added.
  • js/regress/script-tests/polymorphic-put-by-id.js: Added.

(foo):

5:59 PM Changeset in webkit [164619] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WKProcessPool should use secondary processes + network process
https://bugs.webkit.org/show_bug.cgi?id=129282

Reviewed by Simon Fraser.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool initWithConfiguration:]):

5:41 PM Changeset in webkit [164618] by andersca@apple.com
  • 6 edits
    2 adds in trunk/Source/WebKit

Add WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=129280

Reviewed by Dan Bernstein.

Source/WebKit:

Add new files.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

This is a first step towards getting rid of page groups in WebCore. The idea is that
everything that is per page group in WebCore will be per page. In order to retain WebKit1 compatibility
WebViewGroup is going to take over more and more responsibility from WebCore::PageGroup.

  • WebCoreSupport/WebViewGroup.h: Added.
  • WebCoreSupport/WebViewGroup.mm: Added.

(webViewGroups):
(WebViewGroup::getOrCreate):
(WebViewGroup::WebViewGroup):
(WebViewGroup::~WebViewGroup):
(WebViewGroup::addWebView):
(WebViewGroup::removeWebView):

  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(-[WebView _close]):
(-[WebView setGroupName:]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:
4:40 PM Changeset in webkit [164617] by commit-queue@webkit.org
  • 19 edits in trunk/Source

WK2 AVKit fullscreen doesn't display video.
https://bugs.webkit.org/show_bug.cgi?id=128564

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-02-24
Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.exp.in:

Export WebCore::PlatformCALayer::platformCALayer()

  • platform/ios/WebVideoFullscreenInterface.h:
  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:

Remove SetVideoLayerID().

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setVideoLayer):
Wrap make video layer look like an AVAVPlayerLayer with WebAVPlayerLayer

  • platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::setMediaElement):
Pass along the videoLayer before borrowing it so the interface will be ready to
catch the transaction that removes it.

Source/WebKit2:

  • Shared/mac/RemoteLayerTreeTransaction.h:

Add a property to track video layer pending fullscreen.

(WebKit::RemoteLayerTreeTransaction::isVideoLayerIDPendingFullscreen):
(WebKit::RemoteLayerTreeTransaction::addVideoLayerIDPendingFullscreen):
Add a property to track video layer pending fullscreen.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Encode and decode m_videoLayerIDsPendingFullscreen.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):
Let WebVideoFullscreenManagerProxy see the RemoteLayerTreeTransaction.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.cpp:

(WebKit::WebVideoFullscreenManagerProxy::didCommitLayerTree):
Look for video layer pending fullscreen on the transaction to initiate
fullscreen.

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):
Start looking for the video layer pending fullscreen in the transaction.

(WebKit::WebVideoFullscreenManagerProxy::enterFullscreen):
Override to prevent fullscreen from happening before the layer
is pending fullscreen.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.h:
  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:

Pass a more specific videoLayerID in SetVideoLayerID,
i.e. WebCore::GraphicsLayer::PlatformLayerID.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):
Move webPage specific transaction building here, including,
giving WebVideoFullscreenManager a chance to modify the transaction.

  • WebProcess/WebPage/WebPage.h:

Add willCommitLayerTree();

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
(PlatformCALayerRemoteCustom::~PlatformCALayerRemoteCustom):
Make and break the connection from CALayer to PlatformCALayerRemoteCustom,
the same way it is done for PlatformCALayerMac.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
Move WebPage specific transaction building into WebPage::willCommitLayerTree.

  • WebProcess/ios/WebVideoFullscreenManager.cpp:

(WebKit::WebVideoFullscreenManager::willCommitLayerTree):
addVideoLayerIDPendingFullscreen on RemoteLayerTreeTransaction when needed.

(WebKit::WebVideoFullscreenManager::setVideoLayer):
Pass along the video layerID.

  • WebProcess/ios/WebVideoFullscreenManager.h:

Add willCommitLayerTree() and remove setVideoLayerID().
Add a member to retain the unparented PlatformCALayer.

4:29 PM Changeset in webkit [164616] by Samuel White
  • 3 edits
    2 adds in trunk

AX: AccessibilityObject::findMatchingObjects should never include 'this' in results.
https://bugs.webkit.org/show_bug.cgi?id=129243

Reviewed by Chris Fleizach.

Source/WebCore:

Fix removes the container object from the search results when searching backwards. This
makes backwards & forwards search results consistent with each other.

Test: platform/mac/accessibility/search-predicate-container-not-included.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::findMatchingObjects):

LayoutTests:

Added test to ensure that the container you are searching in can never be a search result.

  • platform/mac/accessibility/search-predicate-container-not-included-expected.txt: Added.
  • platform/mac/accessibility/search-predicate-container-not-included.html: Added.
4:08 PM Changeset in webkit [164615] by Samuel White
  • 3 edits
    2 adds in trunk

AX: findMatchingObjects backwards start position inconsistent with forwards start position when startObject == nullptr.
https://bugs.webkit.org/show_bug.cgi?id=129266

Reviewed by Chris Fleizach.

Source/WebCore:

When searching forward with no start object, the first thing considered is the first child of
the container. However, when searching backwards with no start object nothing in the container
is considered; this basically negates the search. This patch makes backwards searching without
a start object start from the last child of the container to match forward search expectations.

Test: platform/mac/accessibility/search-predicate-start-not-specified.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::findMatchingObjects):

LayoutTests:

Added test to ensure that searching backward & forward without a start object produces similar
results. Backward will begin from the end of the container and forward will begin from the start.

  • platform/mac/accessibility/search-predicate-start-not-specified-expected.txt: Added.
  • platform/mac/accessibility/search-predicate-start-not-specified.html: Added.
3:25 PM Changeset in webkit [164614] by akling@apple.com
  • 15 edits
    5 deletes in trunk/Source/WebCore

Prune dead code for Web Inspector canvas instrumentation.
<https://webkit.org/b/129269>

This was leftover code from Chromium's inspector. It's not used by
today's WebKit inspector.

Reviewed by Timothy Hatcher.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • inspector/InjectedScriptCanvasModule.cpp: Removed.
  • inspector/InjectedScriptCanvasModule.h: Removed.
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCanvasAgent.cpp: Removed.
  • inspector/InspectorCanvasAgent.h: Removed.
  • inspector/InspectorCanvasInstrumentation.h: Removed.
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::didBeginFrame):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):

  • inspector/InstrumentingAgents.h:
3:10 PM Changeset in webkit [164613] by zoltan@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Shapes] Adjust lineTop position to the next available wrapping location at shape-outsides
https://bugs.webkit.org/show_bug.cgi?id=128693

Reviewed by David Hyatt.

Source/WebCore:

When we don't have space next to the floating container, but we have space inside the floating-container next
to the defined shape-outside, we should wrap around the shape-outside. This patch fixes the behavior both for
cases when there is no space to fit at the first line, and for the additional lines cases.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjustment.html

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):

  • rendering/line/LineWidth.cpp:

(WebCore::availableWidthAtOffset):
(WebCore::LineWidth::updateLineDimension): Added new helper.
(WebCore::isWholeLineFit): Added new helper.
(WebCore::LineWidth::wrapNextToShapeOutside): Added new helper.
(WebCore::LineWidth::fitBelowFloats): Add optional parameter for the function.

  • rendering/line/LineWidth.h:

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjustment-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjustment.html: Added.
2:57 PM Changeset in webkit [164612] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC regressions after r164494
https://bugs.webkit.org/show_bug.cgi?id=129272

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-02-24
Reviewed by Mark Lam.

  • offlineasm/x86.rb: Only avoid reverse opcode (fdivr) for Windows.
2:48 PM Changeset in webkit [164611] by commit-queue@webkit.org
  • 42 edits
    2 copies in trunk/Source

Create SessionID value-style class for session IDs.
https://bugs.webkit.org/show_bug.cgi?id=129141

Source/WebCore:

Patch by Martin Hock <mhock@apple.com> on 2014-02-24
Reviewed by Brady Eidson.

  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Page.cpp: Add SessionID member.

(WebCore::Page::Page):
(WebCore::Page::sessionID): Retrieve sessionID or use settings if not set.

  • page/Page.h:

(WebCore::Page::setSessionID):

  • page/SessionID.h: Session ID class consisting solely of its uint64_t session ID.

(WebCore::SessionID::SessionID):
(WebCore::SessionID::isValid): Not empty.
(WebCore::SessionID::isEphemeral):
(WebCore::SessionID::sessionID):
(WebCore::SessionID::operator==): Value-based equality.
(WebCore::SessionID::operator!=):
(WebCore::SessionID::emptySessionID): Zero value also used for HashTraits emptyValue.
(WebCore::SessionID::defaultSessionID):
(WebCore::SessionID::legacyPrivateSessionID):

  • page/SessionIDHash.h:

(WTF::SessionIDHash::hash): Just the casted session ID (low order bytes)
(WTF::SessionIDHash::equal):
(WTF::HashTraits<WebCore::SessionID>::emptyValue): Equal to emptySessionID.
(WTF::HashTraits<WebCore::SessionID>::constructDeletedValue): -1 value.
(WTF::HashTraits<WebCore::SessionID>::isDeletedValue):

Source/WebKit2:

The below changes deal solely with mechanical changes to use the SessionID value class instead of uint64_t except where noted.

Patch by Martin Hock <mhock@apple.com> on 2014-02-24
Reviewed by Brady Eidson.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):

  • Shared/Network/NetworkResourceLoadParameters.h:
  • Shared/SessionTracker.cpp:

(WebKit::staticSessionMap):
(WebKit::storageSessionToID):
(WebKit::SessionTracker::sessionMap):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::sessionID):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):

  • Shared/SessionTracker.h: Move code to SessionID class.
  • Shared/WebCoreArgumentCoders.cpp: Add encode and decode for SessionID.

(IPC::ArgumentCoder<SessionID>::encode):
(IPC::ArgumentCoder<SessionID>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

  • UIProcess/APISession.cpp:

(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::isEphemeral):
(API::Session::getID):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebPage/WebPage.cpp: Move sessionID to Page to allow WebCore to access it.

(WebKit::WebPage::WebPage):
(WebKit::WebPage::sessionID):
(WebKit::WebPage::isUsingEphemeralSession):
(WebKit::WebPage::setSessionID):
(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
2:48 PM Changeset in webkit [164610] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

[WinCairo] Disable ANGLE build on WinCairo port.

  • WebKit.vcxproj/WebKit.sln:
2:29 PM Changeset in webkit [164609] by commit-queue@webkit.org
  • 28 edits in trunk

[CSS Grid Layout] handle undefined RemainingSpace in computeUsedBreadthOfGridTracks algorithm
https://bugs.webkit.org/show_bug.cgi?id=128372

Patch by Javier Fernandez <jfernandez@igalia.com> on 2014-02-24
Reviewed by David Hyatt.

From Blink r165692 by <svillar@igalia.com>

Source/WebCore:

The spec defines a different code path for the computeUsedBreadthOfGridTracks algorithm
http://dev.w3.org/csswg/css-grid/#function-ComputeUsedBreadthOfGridTracks.

Basically the track breadth is different when the available size is undefined and thus,
cannot be taken into account during the computations.
The available size is undefined whenever the height is auto or the grid element has a
shrink-to-fit behavior.

It was also renamed the function to match the specs so the function name starts with
'compute' instead of 'computed'.

No new tests, but added new cases to some of them.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::gridElementIsShrinkToFit):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::layoutGridItems):

  • rendering/RenderGrid.h:

LayoutTests:

Adapt tests to consider also cases for undefined RemainingSpace.

  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows-expected.txt:
  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
  • fast/css-grid-layout/flex-content-resolution-rows-expected.txt:
  • fast/css-grid-layout/flex-content-resolution-rows.html:
  • fast/css-grid-layout/grid-auto-columns-rows-update-expected.txt:
  • fast/css-grid-layout/grid-auto-columns-rows-update.html:
  • fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt:
  • fast/css-grid-layout/grid-dynamic-updates-relayout.html:
  • fast/css-grid-layout/grid-item-addition-track-breadth-update-expected.txt:
  • fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
  • fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt:
  • fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
  • fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt:
  • fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
  • fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt:
  • fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
  • fast/css-grid-layout/implicit-position-dynamic-change-expected.txt:
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/minmax-max-content-resolution-rows-expected.txt:
  • fast/css-grid-layout/minmax-max-content-resolution-rows.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows-expected.txt:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
  • fast/css-grid-layout/minmax-spanning-resolution-rows-expected.txt:
  • fast/css-grid-layout/minmax-spanning-resolution-rows.html:
2:21 PM Changeset in webkit [164608] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed pre-emptive build fix.

  • WebCore.vcxproj/WebCoreCommon.props: Add replay directory to include path.
2:14 PM Changeset in webkit [164607] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WTF

Disabled WebGL on WinCairo.

Unreviewed.

  • wtf/FeatureDefines.h:

Removed ENABLE_WEBGL definition for WinCairo port.
WebGL has not worked on WinCairo since r163079
and it was not compiling with a recent ANGLE update.

1:59 PM Changeset in webkit [164606] by beidson@apple.com
  • 9 edits
    1 copy in trunk/Source/WebCore

Break out ImageControls style into an external stylesheet
https://bugs.webkit.org/show_bug.cgi?id=129273

Reviewed by Jer Noble.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • css/CSSDefaultStyleSheets.h:
  • html/shadow/mac/ImageControlsRootElementMac.cpp:

(WebCore::ImageControlsRootElementMac::maybeCreate):

  • html/shadow/mac/imageControlsMac.css:

(.x-webkit-imagemenu):
(.x-webkit-imagemenu:hover):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsScript):
(WebCore::RenderTheme::imageControlsStyleSheet):

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::imageControlsStyleSheet):

1:35 PM Changeset in webkit [164605] by Simon Fraser
  • 1 edit
    2 deletes in trunk/Source/WebKit2

Remove PDFViewController.*, which is unused
https://bugs.webkit.org/show_bug.cgi?id=129270

Reviewed by Tim Horton.

  • UIProcess/mac/PDFViewController.h: Removed.
  • UIProcess/mac/PDFViewController.mm: Removed.
1:15 PM Changeset in webkit [164604] by timothy@apple.com
  • 4 edits in trunk/Source/WebInspectorUI

Give non-Mac platforms a default toolbar background so it isn't just white.

https://bugs.webkit.org/show_bug.cgi?id=129260

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Style the boby with platform classes.

  • UserInterface/Base/Utilities.js:

(String.prototype.contains): Added.

  • UserInterface/Views/Toolbar.css:

(body.docked .toolbar, body:not(.mac-platform) .toolbar): Added. Default toolbar background.
(body.docked.mac-platform.mavericks .toolbar, body.docked.mac-platform.mountain-lion): Added.
(body.mac-platform:not(.docked) .toolbar .item.button > .label): Only apply to Mac.

1:10 PM Changeset in webkit [164603] by andersca@apple.com
  • 14 edits
    7 copies
    1 move in trunk/Source/WebKit2

Rename WKProcessClass to WKProcessPool
https://bugs.webkit.org/show_bug.cgi?id=129268

Reviewed by Dan Bernstein.

Stage this rename by adding back WKProcessClass and WKProcessClassConfiguration as subclasses of the renamed classes.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • UIProcess/API/Cocoa/WKProcessClass.h:
  • UIProcess/API/Cocoa/WKProcessClass.mm:
  • UIProcess/API/Cocoa/WKProcessClassConfiguration.h:
  • UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:
  • UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h:
  • UIProcess/API/Cocoa/WKProcessClassPrivate.h:
  • UIProcess/API/Cocoa/WKProcessPool.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.h.
  • UIProcess/API/Cocoa/WKProcessPool.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm.

(-[WKProcessPool init]):
(-[WKProcessPool initWithConfiguration:]):
(-[WKProcessPool dealloc]):
(-[WKProcessPool description]):
(-[WKProcessPool configuration]):
(-[WKProcessPool API::]):
(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):

  • UIProcess/API/Cocoa/WKProcessPoolConfiguration.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.h.
  • UIProcess/API/Cocoa/WKProcessPoolConfiguration.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.mm.

(-[WKProcessPoolConfiguration _injectedBundleURL]):
(-[WKProcessPoolConfiguration _setInjectedBundleURL:]):
(-[WKProcessPoolConfiguration description]):
(-[WKProcessPoolConfiguration copyWithZone:]):

  • UIProcess/API/Cocoa/WKProcessPoolConfigurationPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfigurationPrivate.h.
  • UIProcess/API/Cocoa/WKProcessPoolInternal.h: Renamed from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassInternal.h.

(WebKit::wrapper):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassPrivate.h.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration description]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration processPool]):
(-[WKWebViewConfiguration setProcessPool:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationToBeRemoved.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassPrivate.h.

(-[WKWebViewConfiguration setProcessClass:]):
(-[WKWebViewConfiguration processClass]):

  • UIProcess/API/mac/WKView.mm:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):

  • WebKit2.xcodeproj/project.pbxproj:
1:00 PM Changeset in webkit [164602] by thiago.lacerda@openbossa.org
  • 28 edits in trunk

[WebRTC] Validating RTCConfiguration according to the spec
https://bugs.webkit.org/show_bug.cgi?id=129182

Reviewed by Eric Carlson.

Spec states that:

  • iceServers should not be an empty list
  • the entry in the configuration dictionary is "urls", instead of "url"
  • urls can be either a list or a string

Fixing all that in RTCConfiguration validation when creating a RTCPeerConnection

Source/WebCore:

Existing tests were updated.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::appendIceServer): Added.
(WebCore::processIceServer): Added.
(WebCore::RTCPeerConnection::parseConfiguration):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-expected.txt:
  • fast/mediastream/RTCPeerConnection-have-local-answer.html:
  • fast/mediastream/RTCPeerConnection-have-local-offer.html:
  • fast/mediastream/RTCPeerConnection-have-local-pranswer.html:
  • fast/mediastream/RTCPeerConnection-have-remote-offer.html:
  • fast/mediastream/RTCPeerConnection-have-remote-pranswer.html:
  • fast/mediastream/RTCPeerConnection-ice-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-stable.html:
  • fast/mediastream/RTCPeerConnection-state-expected.txt:
  • fast/mediastream/RTCPeerConnection-state.html:
  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/RTCPeerConnection.html:
12:53 PM Changeset in webkit [164601] by Simon Fraser
  • 2 edits
    10 moves in trunk/Source/WebKit2

Move non-API files out of WebKit2/UIProcess/API/mac
https://bugs.webkit.org/show_bug.cgi?id=129267

Reviewed by Anders Carlsson.

  • UIProcess/mac/FindIndicatorWindow.h: Renamed from Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.h.
  • UIProcess/mac/FindIndicatorWindow.mm: Renamed from Source/WebKit2/UIProcess/API/mac/FindIndicatorWindow.mm.
  • UIProcess/mac/PDFViewController.h: Renamed from Source/WebKit2/UIProcess/API/mac/PDFViewController.h.
  • UIProcess/mac/PDFViewController.mm: Renamed from Source/WebKit2/UIProcess/API/mac/PDFViewController.mm.
  • UIProcess/mac/WKPrintingView.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKPrintingView.h.
  • UIProcess/mac/WKPrintingView.mm: Renamed from Source/WebKit2/UIProcess/API/mac/WKPrintingView.mm.
  • UIProcess/mac/WKTextInputWindowController.h: Renamed from Source/WebKit2/UIProcess/API/mac/WKTextInputWindowController.h.
  • UIProcess/mac/WKTextInputWindowController.mm: Renamed from Source/WebKit2/UIProcess/API/mac/WKTextInputWindowController.mm.
  • WebKit2.xcodeproj/project.pbxproj:
12:51 PM Changeset in webkit [164600] by stavila@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Regions] Relative positioned elements overflowing the region do not get painted into the next tile
https://bugs.webkit.org/show_bug.cgi?id=129254

Reviewed by Antti Koivisto.

Source/WebCore:

The painting of the region's layer should not be aborted so early if the region's fragment shouldn't be painted
because that would prevent all the layer's children from being painted.

Another problem this patch addresses is that clipping should also be performed when the clip rect is empty,
which is what happens when painting in a tile in which the flowed element would normally be painted
if it wasn't clipped by the region.

Test: fast/regions/content-relative-next-tile.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):

LayoutTests:

Added test for the painting across tiles of relative positioned elements flowed into regions.

  • fast/regions/content-relative-next-tile-expected.html: Added.
  • fast/regions/content-relative-next-tile.html: Added.
12:31 PM Changeset in webkit [164599] by Simon Fraser
  • 2 edits
    16 moves in trunk/Source/WebKit2

Move non-API files in the API/ios directory out to UIProcess/ios
https://bugs.webkit.org/show_bug.cgi?id=129264

Reviewed by Anders Carlsson.

  • UIProcess/ios/PageClientImplIOS.h: Renamed from Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.h.
  • UIProcess/ios/PageClientImplIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/PageClientImplIOS.mm.
  • UIProcess/ios/WKActionSheet.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKActionSheet.h.
  • UIProcess/ios/WKActionSheet.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKActionSheet.mm.
  • UIProcess/ios/WKContentViewInternal.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKContentViewInternal.h.
  • UIProcess/ios/WKGeolocationProviderIOS.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKGeolocationProviderIOS.h.
  • UIProcess/ios/WKGeolocationProviderIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKGeolocationProviderIOS.mm.
  • UIProcess/ios/WKInteractionView.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKInteractionView.h.
  • UIProcess/ios/WKInteractionView.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKInteractionView.mm.
  • UIProcess/ios/WKScrollView.h: Renamed from Source/WebKit2/UIProcess/API/ios/WKScrollView.h.
  • UIProcess/ios/WKScrollView.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKScrollView.mm.
  • WebKit2.xcodeproj/project.pbxproj:
12:18 PM Changeset in webkit [164598] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Rename PageClientImplIOS::m_view to m_contentView
https://bugs.webkit.org/show_bug.cgi?id=129124

Reviewed by Benjamin Poulain.

Simple rename of m_view to m_contentView in preparation for
also holding onto the WKView.

  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::processDidExit):
(WebKit::PageClientImpl::didRelaunchProcess):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::interpretKeyEvent):
(WebKit::PageClientImpl::positionInformationDidChange):
(WebKit::PageClientImpl::selectionDidChange):
(WebKit::PageClientImpl::screenToRootView):
(WebKit::PageClientImpl::rootViewToScreen):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer):
(WebKit::PageClientImpl::takeViewSnapshot):
(WebKit::PageClientImpl::didGetTapHighlightGeometries):
(WebKit::PageClientImpl::didCommitLayerTree):
(WebKit::PageClientImpl::startAssistingNode):
(WebKit::PageClientImpl::stopAssistingNode):

11:43 AM Changeset in webkit [164597] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r164438): [GTK] Tests /webkit2/WebKitWebView/tls-errors-policy and /webkit2/WebKitWebContext/uri-scheme fail
https://bugs.webkit.org/show_bug.cgi?id=129252

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-02-24
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitPrivate.cpp: Manage error values generated by the user application and not present in WebCore

(toWebKitError):
(toWebCoreError):

11:23 AM Changeset in webkit [164596] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

REGRESSION(r164438): [GTK] Tests /WebKitGtk/testcontextmenu, /WebKitGtk/testmimehandling, /WebKitGtk/testloading assert in Debug build
https://bugs.webkit.org/show_bug.cgi?id=129256

Patch by Enrique Ocaña González <eocanha@igalia.com> on 2014-02-24
Reviewed by Carlos Garcia Campos.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: Manage error values not present in WebCore

(WebKit::toWebKitNetworkError):

11:13 AM Changeset in webkit [164595] by mitz@apple.com
  • 2 edits in trunk/Tools

iOS build fix after r164577.

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):

11:05 AM Changeset in webkit [164594] by commit-queue@webkit.org
  • 45 edits in trunk/Source

Get rid of the unused 'immediate' parameters from repaint related functions
https://bugs.webkit.org/show_bug.cgi?id=129111

Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Simon Fraser.

Removing the 'immediate' parameters from repaint related functions - accoring
to the FIXME in RenderView::repaintViewRectangle() - since they have no effect.

Source/WebCore:

No new tests are necessary because there is no behavior change

  • dom/Element.cpp:

(WebCore::Element::setActive):

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::invalidateRootView):
(WebCore::Chrome::invalidateContentsAndRootView):
(WebCore::Chrome::invalidateContentsForSlowScroll):

  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp:

(WebCore::Frame::tiledBackingStorePaintEnd):

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::shouldUpdate):

  • page/FrameView.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollContents):
(WebCore::ScrollView::scrollContentsSlowPath):
(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::updateOverhangAreas):
(WebCore::ScrollView::addPanScrollIcon):
(WebCore::ScrollView::removePanScrollIcon):
(WebCore::ScrollView::platformRepaintContentRectangle):

  • platform/ScrollView.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::repaintLayerRectsForImage):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):

  • rendering/RenderLayer.h:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintSlowRepaintObject):

  • rendering/RenderObject.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):

  • rendering/RenderRegion.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintViewRectangle):
(WebCore::RenderView::flushAccumulatedRepaintRegion):
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers):

  • rendering/RenderView.h:
  • svg/graphics/SVGImageChromeClient.h:

Source/WebKit/efl:

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::invalidateContents):
(WebCore::ChromeClientEfl::invalidateRootView):
(WebCore::ChromeClientEfl::invalidateContentsAndRootView):
(WebCore::ChromeClientEfl::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::invalidateRootView):
(WebKit::ChromeClient::invalidateContentsAndRootView):
(WebKit::ChromeClient::invalidateContentsForSlowScroll):

  • WebCoreSupport/ChromeClientGtk.h:

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
(WebChromeClient::invalidateContentsForSlowScroll):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::invalidateRootView):
(WebKit::ChromeClientWinCE::invalidateContentsAndRootView):
(WebKit::ChromeClientWinCE::invalidateContentsForSlowScroll):
(WebKit::ChromeClientWinCE::scroll):

  • WebCoreSupport/ChromeClientWinCE.h:
10:49 AM Changeset in webkit [164593] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/16059894> Update AppleConnect sandbox profile for XPC process names.

Patch by Ivan Krstić, reviewed and landed by me.

  • Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
10:34 AM Changeset in webkit [164592] by krit@webkit.org
  • 2 edits
    6 moves
    30 adds
    20 deletes in trunk/LayoutTests

Transform more clip-path pixel tests to reference tests
https://bugs.webkit.org/show_bug.cgi?id=129230

Reviewed by Andreas Kling.

  • svg/clip-path/clip-path-content-use-007-expected.svg: Added.
  • svg/clip-path/clip-path-content-use-007.svg: Added.
  • svg/clip-path/clip-path-css-transform-003-expected.svg: Added.
  • svg/clip-path/clip-path-css-transform-003.svg: Added.
  • svg/clip-path/clip-path-css-transform-004-expected.svg: Added.
  • svg/clip-path/clip-path-css-transform-004.svg: Added.
  • svg/clip-path/clip-path-document-change-assert-expected.txt: Renamed from LayoutTests/svg/custom/clip-path-document-change-assert-expected.txt.
  • svg/clip-path/clip-path-document-change-assert.html: Renamed from LayoutTests/svg/custom/clip-path-document-change-assert.html.
  • svg/clip-path/clip-path-dom-child-changes-expected.svg: Added.
  • svg/clip-path/clip-path-dom-child-changes.svg: Added.
  • svg/clip-path/clip-path-dom-clippathunits-expected.svg: Added.
  • svg/clip-path/clip-path-dom-clippathunits.svg: Added.
  • svg/clip-path/clip-path-dom-href-expected.svg: Added.
  • svg/clip-path/clip-path-dom-href.svg: Added.
  • svg/clip-path/clip-path-dom-id-expected.svg: Added.
  • svg/clip-path/clip-path-dom-id.svg: Added.
  • svg/clip-path/clip-path-negative-scale-expected.svg: Added.
  • svg/clip-path/clip-path-negative-scale.svg: Added.
  • svg/clip-path/clip-path-no-content-004-expected.svg: Added.
  • svg/clip-path/clip-path-no-content-004.svg: Added.
  • svg/clip-path/clip-path-on-marker-001-expected.svg: Added.
  • svg/clip-path/clip-path-on-marker-001.svg: Added.
  • svg/clip-path/clip-path-on-marker-002-expected.svg: Added.
  • svg/clip-path/clip-path-on-marker-002.svg: Added.
  • svg/clip-path/clip-path-on-marker-003-expected.svg: Added.
  • svg/clip-path/clip-path-on-marker-003.svg: Added.
  • svg/clip-path/clip-path-recursion-001-expected.svg: Renamed from LayoutTests/svg/custom/circular-clip-path-references-crash-expected.svg.
  • svg/clip-path/clip-path-recursion-001.svg: Renamed from LayoutTests/svg/custom/circular-clip-path-references-crash.svg.
  • svg/clip-path/clip-path-recursion-002-expected.svg: Added.
  • svg/clip-path/clip-path-recursion-002.svg: Added.
  • svg/clip-path/clip-path-shape-stroke-expected.svg:
  • svg/clip-path/clip-path-with-transform-expected.svg: Added.
  • svg/clip-path/clip-path-with-transform.svg: Added.
  • svg/clip-path/mask-nested-clip-path-010-expected.svg: Renamed from LayoutTests/svg/custom/clamped-masking-clipping-expected.svg.
  • svg/clip-path/mask-nested-clip-path-010.svg: Renamed from LayoutTests/svg/custom/clamped-masking-clipping.svg.
  • svg/custom/clip-mask-negative-scale-expected.txt: Removed.
  • svg/custom/clip-mask-negative-scale.svg: Removed.
  • svg/custom/clip-path-child-changes-expected.txt: Removed.
  • svg/custom/clip-path-child-changes.svg: Removed.
  • svg/custom/clip-path-href-changes-expected.txt: Removed.
  • svg/custom/clip-path-href-changes.svg: Removed.
  • svg/custom/clip-path-id-changes-expected.txt: Removed.
  • svg/custom/clip-path-id-changes.svg: Removed.
  • svg/custom/clip-path-referencing-use.svg: Removed.
  • svg/custom/clip-path-referencing-use2.svg: Removed.
  • svg/custom/clip-path-units-changes-expected.txt: Removed.
  • svg/custom/clip-path-units-changes.svg: Removed.
  • svg/custom/clip-path-with-css-transform-1-expected.txt: Removed.
  • svg/custom/clip-path-with-css-transform-1.svg: Removed.
  • svg/custom/clip-path-with-css-transform-2-expected.txt: Removed.
  • svg/custom/clip-path-with-css-transform-2.svg: Removed.
  • svg/custom/clip-path-with-transform-expected.txt: Removed.
  • svg/custom/clip-path-with-transform.svg: Removed.
  • svg/custom/empty-clip-path.svg: Removed.
  • svg/custom/recursive-clippath.svg: Removed.
  • svg/masking/mask-negative-scale.svg: Added.
  • svg/masking/mast-negative-scale-expected.svg: Added.
10:32 AM Changeset in webkit [164591] by krit@webkit.org
  • 1 edit
    36 deletes in trunk/LayoutTests

Transform more clip-path pixel tests to reference tests
https://bugs.webkit.org/show_bug.cgi?id=129230

Reviewed by Andreas Kling.

Remove unnecessary pixel test results.

  • platform/efl/svg/custom/clip-mask-negative-scale-expected.png: Removed.
  • platform/gtk/svg/custom/clip-mask-negative-scale-expected.png: Removed.
  • platform/gtk/svg/custom/clip-mask-negative-scale-expected.txt: Removed.
  • platform/gtk/svg/custom/clip-path-child-changes-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-href-changes-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-id-changes-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-referencing-use-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-referencing-use-expected.txt: Removed.
  • platform/gtk/svg/custom/clip-path-referencing-use2-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
  • platform/gtk/svg/custom/clip-path-units-changes-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-with-css-transform-1-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-with-css-transform-2-expected.png: Removed.
  • platform/gtk/svg/custom/clip-path-with-transform-expected.png: Removed.
  • platform/gtk/svg/custom/empty-clip-path-expected.png: Removed.
  • platform/gtk/svg/custom/empty-clip-path-expected.txt: Removed.
  • platform/gtk/svg/custom/recursive-clippath-expected.png: Removed.
  • platform/gtk/svg/custom/recursive-clippath-expected.txt: Removed.
  • platform/mac/svg/custom/clip-mask-negative-scale-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-child-changes-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-display-none-child-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-display-none-child-expected.txt: Removed.
  • platform/mac/svg/custom/clip-path-href-changes-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-id-changes-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-referencing-use-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-referencing-use-expected.txt: Removed.
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt: Removed.
  • platform/mac/svg/custom/clip-path-units-changes-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-with-css-transform-1-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-with-css-transform-2-expected.png: Removed.
  • platform/mac/svg/custom/clip-path-with-transform-expected.png: Removed.
  • platform/mac/svg/custom/empty-clip-path-expected.png: Removed.
  • platform/mac/svg/custom/empty-clip-path-expected.txt: Removed.
  • platform/mac/svg/custom/recursive-clippath-expected.png: Removed.
  • platform/mac/svg/custom/recursive-clippath-expected.txt: Removed.
10:15 AM Changeset in webkit [164590] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WTF

Turn GenGC on for 32-bit systems
https://bugs.webkit.org/show_bug.cgi?id=128824

Reviewed by Geoffrey Garen.

  • wtf/Platform.h:
9:07 AM Changeset in webkit [164589] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

[ASan] Remove methods from ignore list that no longer cause crashes
<http://webkit.org/b/129257>

Reviewed by Anders Carlsson.

  • asan/webkit-asan-ignore.txt: Remove old methods.
9:05 AM Changeset in webkit [164588] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove single quote characters from Web Inspector JavaScript files
https://bugs.webkit.org/show_bug.cgi?id=129253

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-24
Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

(WebInspector.openURL):

  • UserInterface/Views/CookieStorageContentView.js:

(WebInspector.cookieDomainMatchesResourceDomain):

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingComitted):
(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
(WebInspector.DOMTreeElement.prototype._startEditingTagName):

  • UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype._ondragover):

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.addPlaceholderNode):

7:52 AM Changeset in webkit [164587] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Code cleanup: remove leftover ENABLE(WORKERS) macros and support.
https://bugs.webkit.org/show_bug.cgi?id=129255

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Csaba Osztrogonác.

Source/JavaScriptCore:

ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

ENABLE_WORKERS macro was removed in r159679, but r161589 added back some occurrences.
Support is now also removed from xcconfig files.

No new tests needed.

  • Configurations/FeatureDefines.xcconfig:
  • platform/ThreadGlobalData.cpp:
  • platform/ThreadGlobalData.h:
  • platform/Timer.h:

(WebCore::TimerBase::isActive):

  • platform/ios/wak/WebCoreThread.mm:

(RunWebThread):
(StartWebThread):

Source/WebKit/mac:

ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

ENABLE_WORKERS macro was removed in r159679.
Support is now also removed from xcconfig files.

  • Configurations/FeatureDefines.xcconfig:
7:47 AM Changeset in webkit [164586] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake] Get rid of "FIXME: The Blackberry port ..." from WebCore/CmakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=129152

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Gyuyoung Kim.

  • CMakeLists.txt:
7:45 AM Changeset in webkit [164585] by commit-queue@webkit.org
  • 9 edits
    1 add
    1 delete in trunk/Tools

Extract common parts from jhbuildrc files.
https://bugs.webkit.org/show_bug.cgi?id=125986

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-02-24
Reviewed by Csaba Osztrogonác.

Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.

  • Scripts/run-gtk-tests:

(TestRunner._setup_testing_environment):

  • efl/common.py: Removed.
  • efl/jhbuildrc:
  • gtk/check-gdom-symbols:
  • gtk/common.py:

(binary_build_path):
(get_build_path):

  • gtk/find-make-dist-errors:

(get_missing_headers):

  • gtk/generate-gtkdoc:

(get_webkit2_options):
(get_webkit1_options.src_path):
(get_webkit1_options):
(get_webkitdom_options.src_path):
(get_webkitdom_options):

  • gtk/generate-inspector-gresource-manifest.py:
  • gtk/jhbuildrc:
  • jhbuild/jhbuildrc_common.py: Added.

(script_path):
(top_level_path):
(init):

7:42 AM WebKitGTK/2.4.x edited by desrt@desrt.ca
add a patch for backport (diff)
7:24 AM Changeset in webkit [164584] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Wrong active context when destroying GL objects.
https://bugs.webkit.org/show_bug.cgi?id=129244

Patch by Iago Toral Quiroga <itoral@igalia.com> on 2014-02-24
Reviewed by Martin Robinson.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::invalidate): make context current before destroying GL objects.

7:06 AM Changeset in webkit [164583] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

Remove unused error.h header.
https://bugs.webkit.org/show_bug.cgi?id=126774

Patch by Koop Mast <kwm@FreeBSD.org> on 2014-02-24
Reviewed by Anders Carlsson.

This header doesn't exists on FreeBSD. According to
https://www.gnu.org/software/gnulib/manual/html_node/error_002eh.html
the function that this header implements are not present in the file.
So there isn't any need for this header.

  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:
7:03 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
4:19 AM Changeset in webkit [164582] by Manuel Rego Casasnovas
  • 2 edits in trunk/Tools

Unreviewed. Fix code indentation and spacing.

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-02-24

  • Scripts/webkitpy/style/checkers/js.py:

(SingleQuoteChecker.check):

3:24 AM Changeset in webkit [164581] by ddkilzer@apple.com
  • 8 edits in trunk/Source

Remove redundant setting in FeatureDefines.xcconfig

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:14 AM Changeset in webkit [164580] by ddkilzer@apple.com
  • 4 edits in trunk/Source/ThirdParty/ANGLE

ANGLE: Stop using unsafe strcpy method
<http://webkit.org/b/129237>
<rdar://problem/11077580>

Reviewed by Dean Jackson.

  • include/GLSLANG/ShaderLang.h:
  • Drive-by fix for header documentation.
  • src/compiler/translator/ShaderLang.cpp:

(ShGetInfoLog):
(ShGetObjectCode):

  • src/libGLESv2/Program.cpp:

(gl::InfoLog::append):

  • Switch to use strncpy(), and explicitly set NULL terminator at the end of the buffer.
2:02 AM Changeset in webkit [164579] by commit-queue@webkit.org
  • 5 edits
    9 adds in trunk

[CSS Blending] An element having -webkit-mix-blend-mode should only blend with the contents of the parent stacking context
https://bugs.webkit.org/show_bug.cgi?id=129154

Patch by Mihai Tica <mitica@adobe.com> on 2014-02-24
Reviewed by Dean Jackson.

Source/WebCore:

The blending operation of an element having -webkit-mix-blend-mode should be restricted to the parent stacking context.
This change isolates blending, preventing it from blending with other underlying elements besides the parent stacking context.

Tests: css3/compositing/blend-mode-isolated-group-1.html

css3/compositing/blend-mode-isolated-group-2.html
css3/compositing/blend-mode-isolated-group-3.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Initialize added members to false.
(WebCore::RenderLayer::updateBlendMode): Check if a blend mode was set or unset. If so, set the m_updateParentStackingContextShouldIsolateBlendingDirty to true.
(WebCore::RenderLayer::updateParentStackingContextShouldIsolateBlending): Traverse to the parent stacking context and update the
m_isolatesBlending member accordingly.

  • rendering/RenderLayer.h:
  • Add isolatesBlending() as a condition for creating a transparency layer in the paintsWithTransparency method.
  • Add m_updateParentStackingContextShouldIsolateBlendingDirty member.
  • Add m_isolatesBlending member and getter.
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements): Call updateParentStackingContextShouldIsolateBlending.

LayoutTests:

Test that isolation is performed for blending, in other words, an element having -webkit-mix-blend-mode is blending with the
contents of the parent stacking context, but not with any of the underlying content.

  • css3/compositing/blend-mode-isolated-group-1.html: Added.
  • css3/compositing/blend-mode-isolated-group-2.html: Added.
  • css3/compositing/blend-mode-isolated-group-3.html: Added.
  • platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-isolated-group-1-expected.txt: Added.
  • platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-isolated-group-2-expected.txt: Added.
  • platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-isolated-group-3-expected.txt: Added.
1:31 AM Changeset in webkit [164578] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
https://bugs.webkit.org/show_bug.cgi?id=129245

Reviewed by Sergio Villar Senin.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Call FullscreenManager::requestExitFullScreen() directly.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
1:31 AM Changeset in webkit [164577] by k.czech@samsung.com
  • 13 edits
    2 adds in trunk

[ATK] Wrong selected element at a given index in a list box.
https://bugs.webkit.org/show_bug.cgi?id=129039

Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/select-element-at-index.html

The selected element at a given index was wrong. One should be considered among the
all children of a list box, not only selected ones.

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(core):
(listObjectForSelection):
(optionFromList):
(optionFromSelection):
(webkitAccessibleSelectionRefSelection):

Tools:

Added missing implementation and proposed some new function for testing selection
in a list boxes.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(setSelectedChildAtIndexCallback):
(removeSelectionAtIndexCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::setSelectedChildAtIndex):
(AccessibilityUIElement::removeSelectionAtIndex):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::selectedChildrenCount):
(AccessibilityUIElement::selectedChildAtIndex):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::setSelectedChildAtIndex):
(WTR::AccessibilityUIElement::removeSelectionAtIndex):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedChildrenCount):
(WTR::AccessibilityUIElement::setSelectedChildAtIndex):
(WTR::AccessibilityUIElement::removeSelectionAtIndex):

LayoutTests:

Proposed test that checks whether correct element at a given index is retrieved.
Also testing some other scenarios such as removing selection from rows, counting all
selected rows and setting selection.

  • accessibility/select-element-at-index-expected.txt: Added.
  • accessibility/select-element-at-index.html: Added.
  • platform/mac/TestExpectations: Skipping test in Mac, missing implementation.

Feb 23, 2014:

9:29 PM Changeset in webkit [164576] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/16144508> [iOS] Some definitions of INSTALL_PATH don’t account for INSTALL_PATH_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=129241

Reviewed by Mark Rowe.

  • Configurations/Base.xcconfig: Define INSTALL_PATH here in terms of INSTALL_PATH_ACTUAL.
  • Configurations/BaseLegacyProcess.xcconfig: Define only INSTALL_PATH_ACTUAL.
  • Configurations/BaseTarget.xcconfig: Simplify the definition of

NORMAL_WEBKIT2_FRAMEWORKS_DIR, now that it shouldn’t include SDKROOT for the Simulator.

  • Configurations/BaseXPCService.xcconfig: Define only INSTALL_PATH_ACTUAL.
  • Configurations/WebKit2.xcconfig: Ditto.
6:24 PM Changeset in webkit [164575] by Brent Fulgham
  • 11 edits in trunk/Source/ThirdParty/ANGLE

[WinCairo] Unreviewed build fix after r164565.

  • ANGLE.vcxproj/libEGL.vcxproj: Use correct path to files.
  • ANGLE.vcxproj/libGLESv2.vcxproj: Ditto.
  • ANGLE.vcxproj/libGLESv2.vcxproj.filters: Ditto.
  • ANGLE.vcxproj/preprocessor.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_common.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_common.vcxproj.filters: Ditto.
  • ANGLE.vcxproj/translator_glsl.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_glsl.vcxproj.filters: Ditto.
  • ANGLE.vcxproj/translator_hlsl.vcxproj: Ditto.
  • ANGLE.vcxproj/translator_hlsl.vcxproj.filters: Ditto.
6:11 PM Changeset in webkit [164574] by dino@apple.com
  • 4 edits in trunk

[WebGL] Allow ANGLE to initialize unused varyings
https://bugs.webkit.org/show_bug.cgi?id=129240
<rdar://problem/15203342>

Reviewed by Sam Weinig.

Source/WebCore:

Covered by: conformance/glsl/misc/shaders-with-varyings.html

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
Add SH_INIT_VARYINGS_WITHOUT_STATIC_USE to compiler flags.

LayoutTests:

Unskip conformance/glsl/misc/shaders-with-varyings.html.

  • platform/mac/TestExpectations:
6:01 PM Changeset in webkit [164573] by weinig@apple.com
  • 8 edits in trunk/Source

Update FeatureDefines.xcconfig

Rubber-stamped by Anders Carlsson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
5:59 PM Changeset in webkit [164572] by dino@apple.com
  • 4 edits in trunk/Source

Sort the project file with sort-Xcode-project-file.

Rubber-stamped by Sam Weinig.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
5:54 PM Changeset in webkit [164571] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Add C-SPI to enable/disable telephone number detection
https://bugs.webkit.org/show_bug.cgi?id=129239

Reviewed by Dean Jackson.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTelephoneNumberParsingEnabled):
(WKPreferencesGetTelephoneNumberParsingEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
5:43 PM Changeset in webkit [164570] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix incorrectly commented out code.

  • platform/TelephoneNumberDetector.h:
5:35 PM Changeset in webkit [164569] by weinig@apple.com
  • 3 edits
    2 adds in trunk/Source/WebCore

Extract platform specific parts of telephone number detection
https://bugs.webkit.org/show_bug.cgi?id=129238

Reviewed by Dean Jackson.

  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers):
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody):

  • platform/TelephoneNumberDetector.h: Added.
  • platform/cocoa/TelephoneNumberDetectorCocoa.cpp: Added.

(WebCore::TelephoneNumberDetector::phoneNumbersScanner):
(WebCore::TelephoneNumberDetector::isSupported):
(WebCore::TelephoneNumberDetector::find):
Move code to TelephoneNumberDetector.

5:23 PM Changeset in webkit [164568] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/Source

Change a url parameter type with URL in NavigatorContentUtils
https://bugs.webkit.org/show_bug.cgi?id=129202

Reviewed by Sam Weinig.

It would be good if we use *URL* for url parameters instead of using String.

Merge from blink. https://src.chromium.org/viewvc/blink?view=rev&revision=165458.

Source/WebCore:

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::verifyCustomHandlerURL):
(WebCore::NavigatorContentUtils::registerProtocolHandler):
(WebCore::NavigatorContentUtils::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtils::unregisterProtocolHandler):

  • Modules/navigatorcontentutils/NavigatorContentUtilsClient.h:

Source/WebKit/efl:

  • WebCoreSupport/NavigatorContentUtilsClientEfl.cpp:

(WebCore::NavigatorContentUtilsClientEfl::registerProtocolHandler):
(WebCore::NavigatorContentUtilsClientEfl::isProtocolHandlerRegistered):
(WebCore::NavigatorContentUtilsClientEfl::unregisterProtocolHandler):

  • WebCoreSupport/NavigatorContentUtilsClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/NavigatorContentUtilsClientGtk.cpp:

(WebKit::NavigatorContentUtilsClient::registerProtocolHandler):

  • WebCoreSupport/NavigatorContentUtilsClientGtk.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebNavigatorContentUtilsClient.h:

(WebKit::WebNavigatorContentUtilsClient::isProtocolHandlerRegistered):
(WebKit::WebNavigatorContentUtilsClient::unregisterProtocolHandler):

4:58 PM Changeset in webkit [164567] by dino@apple.com
  • 1 edit
    197 adds in trunk/Source/ThirdParty/ANGLE

Missing files from previous commit.

4:51 PM Changeset in webkit [164566] by mitz@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Removed -Wno-format-y2k from WARNING_CFLAGS

Rubber-stamped by Sam Weinig.

  • Configurations/Base.xcconfig:
4:43 PM Changeset in webkit [164565] by dino@apple.com
  • 51 edits
    192 deletes in trunk/Source

Update ANGLE to 836bd2176e5607b14846cf1fbc5932dbc91318f4
https://bugs.webkit.org/show_bug.cgi?id=129232

Reviewed by Brent Fulgham.

Source/ThirdParty/ANGLE:

I also reapplied some of our changes from previous updates, including disabling the clang deprecation
warnings in some files, adding the Apple note about license and defining YY_NO_INPUT.

Huge list of source changes omitted.

Source/WebCore:

New files added, derived sources compiled directly, and generated
steps removed for both EFL and GTK, with much-needed help from
Sergio Correia.

  • CMakeLists.txt:
  • GNUMakefile.am:
3:43 PM Changeset in webkit [164564] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Move RenderMathMLMenclose.h/cpp to the right place in the Xcode project and sort.

Rubber-stamped by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
3:37 PM Changeset in webkit [164563] by weinig@apple.com
  • 14 edits in trunk/Source

Move telephone number detection behind its own ENABLE macro
https://bugs.webkit.org/show_bug.cgi?id=129236

Reviewed by Dean Jackson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:
  • html/parser/HTMLConstructionSite.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody):

  • html/parser/HTMLTreeBuilder.h:

Use ENABLE(TELEPHONE_NUMBER_DETECTION).

  • platform/mac/SoftLinking.h:

Remove PLATOFORM(IOS) from SOFT_LINK_PRIVATE_FRAMEWORK_OPTIONAL, it is not iOS specific.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Add ENABLE_TELEPHONE_NUMBER_DETECTION.

2:44 PM Changeset in webkit [164562] by commit-queue@webkit.org
  • 6 edits in trunk

[GTK] Fix build after Web Inspector code reorganization (r164543)
https://bugs.webkit.org/show_bug.cgi?id=129231

Patch by Diego Pino García <Diego Pino Garcia> on 2014-02-23
Reviewed by Dean Jackson.

Source/WebInspectorUI:

  • GNUmakefile.am:

Modify paths to Web Inspector code.

Source/WebKit2:

  • PlatformGTK.cmake:

Modify paths to Web Inspector code.

Tools:

  • gtk/generate-inspector-gresource-manifest.py:

Modify paths to Web Inspector code.

1:43 PM Changeset in webkit [164561] by graouts@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: color picker sliders aren't laid out correctly
https://bugs.webkit.org/show_bug.cgi?id=129234

Reviewed by Joseph Pecoraro.

While it's unclear to me what happened, the "position" property for the color picker sliders
wasn't being computed as expected and used relative positioning. I assume this is related to
r164543 when the order of CSS files changed.

  • UserInterface/Views/Slider.css:

(.slider):

1:41 PM Changeset in webkit [164560] by mrobinson@webkit.org
  • 3 edits in trunk/Tools

[GTK] generate-gtkdoc should use argparse
https://bugs.webkit.org/show_bug.cgi?id=128418

Reviewed by Carlos Garcia Campos.

  • gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters

to all functions, and guard the main routine with a name == main check.

1:39 PM Changeset in webkit [164559] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

[GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
https://bugs.webkit.org/show_bug.cgi?id=129191

Reviewed by Anders Carlsson.

  • DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory

for the GTK+ DumpRenderTree build. We could manually construct this path, but the
name of the directory is "lib" and not "libs". Instead we should use the CMake
variable specifically assigned to this task.

10:48 AM Changeset in webkit [164558] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Refine DFG+FTL inlining and compilation limits
https://bugs.webkit.org/show_bug.cgi?id=129212

Reviewed by Mark Hahnenberg.

Allow larger functions to be DFG-compiled. Institute a limit on FTL compilation,
and set that limit quite high. Institute a limit on inlining-into. The idea here is
that large functions tend to be autogenerated, and code generators like emscripten
appear to leave few inlining opportunities anyway. Also, we don't want the code
size explosion that we would risk if we allowed compilation of a large function and
then inlined a ton of stuff into it.

This is a 0.5% speed-up on Octane v2 and almost eliminates the typescript
regression. This is a 9% speed-up on AsmBench.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::noticeIncomingCall):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGCapabilities.h:

(JSC::DFG::isSmallEnoughToInlineCodeInto):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLState.h:

(JSC::FTL::shouldShowDisassembly):

  • runtime/Options.h:
10:06 AM Changeset in webkit [164557] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

[ASan] Add JSC::DFG::prepareOSREntry() to ignore list
<http://webkit.org/b/129209>

Reviewed by Geoffrey Garen.

  • asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the

ignore list to make ASan builds usable again. Follow-up
investigation is tracked by <rdar://problem/16055903>.

8:25 AM Changeset in webkit [164556] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Subpixel rendering: Fix bleed avoidance subpixel calculation.
https://bugs.webkit.org/show_bug.cgi?id=129225

Reviewed by Simon Fraser.

static_cast<LayoutUnit>(int value) only produces the desired result when subpixel is off.

Currently not testable.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::getBackgroundRoundedRect):
(WebCore::shrinkRectByOneDevicePixel):
(WebCore::RenderBoxModelObject::borderInnerRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::backgroundRoundedRectAdjustedForBleedAvoidance):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderBoxModelObject.h:
8:22 AM Changeset in webkit [164555] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Subpixel rendering: Add devicepixel based computation to BorderEdge class.
https://bugs.webkit.org/show_bug.cgi?id=129224

Reviewed by Simon Fraser.

To produce correct width (and type) results, BorderEdge class needs to take device pixel ratio into account.

Currently not testable.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::BorderEdge::BorderEdge):
(WebCore::BorderEdge::obscuresBackgroundEdge):
(WebCore::BorderEdge::getDoubleBorderStripeWidths): this does not always produce the same
result as before, but the sum of inner and outer is not different.
(WebCore::BorderEdge::borderWidthInDevicePixel):
(WebCore::RenderBoxModelObject::getBorderEdgeInfo):

6:30 AM UpdatingANGLE edited by dino@apple.com
(diff)

Feb 22, 2014:

9:44 PM Changeset in webkit [164554] by mitz@apple.com
  • 25 edits in trunk/Source

REGRESSION (r164507): Crash beneath JSGlobalObjectInspectorController::reportAPIException at facebook.com, twitter.com, youtube.com
https://bugs.webkit.org/show_bug.cgi?id=129227

Reviewed by Eric Carlson.

Reverted r164507.

Source/JavaScriptCore:

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

  • API/JSValue.mm:

(valueToArray):
(valueToDictionary):

  • API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):

  • inspector/ConsoleMessage.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/ScriptCallStack.cpp:
  • inspector/ScriptCallStack.h:
  • inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
(Inspector::createScriptCallStackFromException):

  • inspector/ScriptCallStackFactory.h:
  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):

  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):

Source/WebCore:

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

  • page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):

  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

  • UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):

5:38 PM Changeset in webkit [164553] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Remove some unreachable code (-Wunreachable-code)
https://bugs.webkit.org/show_bug.cgi?id=129220

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-22
Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • API/tests/testapi.c:

(EvilExceptionObject_convertToType):

  • disassembler/udis86/udis86_decode.c:

(decode_operand):

Source/WebCore:

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndTag):
The only tricky case. Here there was a break inside the
#if, but not the #else, and a break after the #endif.
Remove the break inside the #if, and always use the
break after the #endif.

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::modeToString):

  • bindings/js/JSTrackCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::functionForUniform):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:

(WebKit::toAPI):

3:59 PM Changeset in webkit [164552] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Letterpress effect disabled for synthetic italic
https://bugs.webkit.org/show_bug.cgi?id=129218
<rdar://problem/15997846>

Reviewed by Dan Bernstein.

There was no need to guard against synthetic italics and letterpress.

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): Remove !useLetterpressEffect from conditional.

3:56 PM Changeset in webkit [164551] by weinig@apple.com
  • 10 edits in trunk/Source

Expose phase and momentum phase as SPI on DOMWheelEvent
<rdar://problem/16110871>
https://bugs.webkit.org/show_bug.cgi?id=129184

Reviewed by Anders Carlsson.

../WebCore:

  • WebCore.exp.in:

Export core(DOMWheelEvent).

  • WebCore.xcodeproj/project.pbxproj:

Make DOMWheelEventInternal.h available in WebKit.

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

  • dom/WheelEvent.cpp:

(WebCore::determineDeltaMode):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEvent::initWebKitWheelEvent):
Move PlatformWheelEvent -> DOMWheelEvent conversion to DOMWheelEvent.

  • dom/WheelEvent.h:

(WebCore::WheelEvent::create):
(WebCore::WheelEvent::phase):
(WebCore::WheelEvent::momentumPhase):
Store phase and momentumPhase on the WheelEvent.

../WebKit/mac:

  • DOM/WebDOMOperations.mm:

(toNSEventPhase):
(-[DOMWheelEvent _phase]):
(-[DOMWheelEvent _momentumPhase]):

  • DOM/WebDOMOperationsPrivate.h:

Expose _phase and _momentumPhase as SPI.

  • MigrateHeaders.make:

Make DOMWheelEventInternal.h to WebKit.

2:39 PM Changeset in webkit [164550] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] WKUIDelegate.h is a project header
https://bugs.webkit.org/show_bug.cgi?id=129215

Reviewed by Anders Carlsson.

  • WebKit2.xcodeproj/project.pbxproj: Make it a public header.
12:03 PM Changeset in webkit [164549] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, ARMv7 build fix.

  • assembler/ARMv7Assembler.h:
11:55 AM Changeset in webkit [164548] by fpizlo@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

It should be possible for a LinkBuffer to outlive the MacroAssembler and still be useful
https://bugs.webkit.org/show_bug.cgi?id=124733

Reviewed by Oliver Hunt.

This also takes the opportunity to de-duplicate some branch compaction code.

  • assembler/ARM64Assembler.h:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::buffer):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::storage):
(JSC::AssemblerBuffer::grow):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::executableOffsetFor):
(JSC::LinkBuffer::applyOffset):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::link):

  • assembler/MacroAssemblerARMv7.h:
10:44 AM Changeset in webkit [164547] by mitz@apple.com
  • 11 edits in trunk/Source/WebKit2

<rdar://problem/12500358> [Cocoa] Development variants of XPC services should not be installed in WebKit2.framework/XPCServices
https://bugs.webkit.org/show_bug.cgi?id=129197

Reviewed by Sam Weinig.

  • Configurations/BaseXPCService.xcconfig: Made INSTALL_PATH vary based on

WK_XPC_SERVICE_VARIANT. For the Development variant, use an install path outside the
framework. Note that engineering builds using the build action continue to have the
Development variants copied into the framework by a script build phase.

  • Configurations/DatabaseService.Development.xcconfig: Set WK_XPC_SERVICE_VARIANT.
  • Configurations/DatabaseService.xcconfig: Ditto.
  • Configurations/NetworkService.Development.xcconfig: Ditto.
  • Configurations/NetworkService.xcconfig: Ditto.
  • Configurations/PluginService.32.xcconfig: Ditto.
  • Configurations/PluginService.64.xcconfig: Ditto.
  • Configurations/PluginService.Development.xcconfig: Ditto.
  • Configurations/WebContentService.Development.xcconfig: Ditto.
  • Configurations/WebContentService.xcconfig: Ditto.
10:10 AM Changeset in webkit [164546] by ap@apple.com
  • 11 edits in trunk

Rename JWK key_ops values from wrap/unwrap to wrapKey/unwrapKey
https://bugs.webkit.org/show_bug.cgi?id=129121

Reviewed by Sam Weinig.

Source/WebCore:

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Updated to newer names.
(WebCore::addUsagesToJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::serialize): rsa-oaep-key-manipulation test
started ot fail, because RSA-OAEP with 2048 bit key and sha-1 can only encrypt
214 bytes, and the new longer names made JSON serialization slightly longer.
Compensate by not doing any indentation in JSON.

LayoutTests:

  • crypto/subtle/aes-export-key-expected.txt:
  • crypto/subtle/aes-export-key.html:
  • crypto/subtle/jwk-export-use-values-expected.txt:
  • crypto/subtle/jwk-export-use-values.html:
  • crypto/subtle/jwk-import-use-values-expected.txt:
  • crypto/subtle/jwk-import-use-values.html:
  • crypto/subtle/rsa-oaep-key-manipulation-expected.txt:
  • crypto/subtle/rsa-oaep-key-manipulation.html:
9:50 AM Changeset in webkit [164545] by timothy@apple.com
  • 1 edit in trunk/LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js

Fix tests.

9:48 AM Changeset in webkit [164544] by timothy@apple.com
  • 2 edits in trunk

Fix production builds and tests.

9:33 AM Changeset in webkit [164543] by timothy@apple.com
  • 5 edits
    416 moves
    5 adds
    7 deletes in trunk/Source/WebInspectorUI

Organize WebInspectorUI/UserInterface into sub-directories.

https://bugs.webkit.org/show_bug.cgi?id=129194

Rubber-stamped by Joseph Pecoraro.

  • Scripts/copy-user-interface-resources.sh: Fix Image URLs and Protocol paths.
  • UserInterface/Base: Added.
  • UserInterface/Controllers: Added.
  • UserInterface/Images: Added.
  • UserInterface/Main.html: Updated.
  • UserInterface/Models Added.
  • UserInterface/Protocol Added.
  • UserInterface/Views: Added.
9:31 AM Changeset in webkit [164542] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Revert r164434 since it actually broke ASan builds
<http://webkit.org/b/128871>

  • Configurations/WebKit.xcconfig: This caused -asan-blacklist to

be included twice on every compiler command, which caused clang
to error out.

8:06 AM Changeset in webkit [164541] by timothy@apple.com
  • 16 edits
    13 adds in trunk

Add inspection user interface for IndexedDB.

https://bugs.webkit.org/show_bug.cgi?id=129162

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):

  • UserInterface/IndexedDatabase.js: Added.

(WebInspector.IndexedDatabase):
(WebInspector.IndexedDatabase.prototype.get name):
(WebInspector.IndexedDatabase.prototype.get securityOrigin):
(WebInspector.IndexedDatabase.prototype.get host):
(WebInspector.IndexedDatabase.prototype.get version):
(WebInspector.IndexedDatabase.prototype.get objectStores):
(WebInspector.IndexedDatabase.prototype.saveIdentityToCookie):

  • UserInterface/IndexedDatabaseEntryDataGridNode.js: Added.

(WebInspector.IndexedDatabaseEntryDataGridNode):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.get entry):
(WebInspector.IndexedDatabaseEntryDataGridNode.prototype.createCellContent):

  • UserInterface/IndexedDatabaseHostTreeElement.js: Added.

(WebInspector.IndexedDatabaseHostTreeElement):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get name):
(WebInspector.IndexedDatabaseHostTreeElement.prototype.get categoryName):

  • UserInterface/IndexedDatabaseObjectStore.js: Added.

(WebInspector.IndexedDatabaseObjectStore):
(WebInspector.IndexedDatabaseObjectStore.prototype.get name):
(WebInspector.IndexedDatabaseObjectStore.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStore.prototype.get autoIncrement):
(WebInspector.IndexedDatabaseObjectStore.prototype.get parentDatabase):
(WebInspector.IndexedDatabaseObjectStore.prototype.get indexes):
(WebInspector.IndexedDatabaseObjectStore.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStore.prototype.establishRelationship):

  • UserInterface/IndexedDatabaseObjectStoreContentView.css: Added.

(.content-view.indexed-database-object-store > .data-grid):
(.content-view.indexed-database-object-store > .data-grid td .section .header):
(.content-view.indexed-database-object-store > .data-grid td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid td .section .header .title):
(.content-view.indexed-database-object-store > .data-grid table.data):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(even)):
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(odd)):
(.content-view.indexed-database-object-store > .data-grid table.data tr.filler):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .section.expanded .header::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li.parent.expanded::before):
(.content-view.indexed-database-object-store > .data-grid :focus tr.selected td .properties-tree li *):

  • UserInterface/IndexedDatabaseObjectStoreContentView.js: Added.

(WebInspector.IndexedDatabaseObjectStoreContentView.displayKeyPath):
(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.closed):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.saveToCookie):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.updateLayout):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._reset):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._dataGridScrolled):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData.processEntries):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):

  • UserInterface/IndexedDatabaseObjectStoreIndex.js: Added.

(WebInspector.IndexedDatabaseObjectStoreIndex):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get name):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get keyPath):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get unique):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get multiEntry):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.get parentObjectStore):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.saveIdentityToCookie):
(WebInspector.IndexedDatabaseObjectStoreIndex.prototype.establishRelationship):

  • UserInterface/IndexedDatabaseObjectStoreIndexTreeElement.js: Added.

(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement):
(WebInspector.IndexedDatabaseObjectStoreIndexTreeElement.prototype.get objectStoreIndex):

  • UserInterface/IndexedDatabaseObjectStoreTreeElement.js: Added.

(WebInspector.IndexedDatabaseObjectStoreTreeElement):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.get objectStore):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseObjectStoreTreeElement.prototype.onpopulate):

  • UserInterface/IndexedDatabaseTreeElement.js: Added.

(WebInspector.IndexedDatabaseTreeElement):
(WebInspector.IndexedDatabaseTreeElement.prototype.get indexedDatabase):
(WebInspector.IndexedDatabaseTreeElement.prototype.oncollapse):
(WebInspector.IndexedDatabaseTreeElement.prototype.onpopulate):

  • UserInterface/Main.html:
  • UserInterface/Main.js:

(WebInspector.sidebarPanelForRepresentedObject):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
(WebInspector.ResourceSidebarPanel.prototype._indexedDatabaseWasAdded):
(WebInspector.ResourceSidebarPanel.prototype._storageCleared):

  • UserInterface/StorageManager.js:

(WebInspector.StorageManager):
(WebInspector.StorageManager.prototype.initialize):
(WebInspector.StorageManager.prototype.processData):
(WebInspector.StorageManager.prototype.requestIndexedDatabaseData):
(WebInspector.StorageManager.prototype._mainResourceDidChange):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabaseNames):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processDatabase):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStore):
(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processObjectStoreIndex):
(WebInspector.StorageManager.prototype._securityOriginDidChange):

  • UserInterface/URLUtilities.js:

(parseSecurityOrigin):

LayoutTests:

  • http/tests/inspector-protocol/resources/InspectorTest.js:

(InspectorTest.initializeInspectorModels): Add IndexedDatabase models and StorageManager.

  • inspector-protocol/indexeddb/basics-expected.txt: Added.
  • inspector-protocol/indexeddb/basics.html: Added.
7:29 AM Changeset in webkit [164540] by graouts@webkit.org
  • 4 edits
    2 moves
    1 add in trunk/Source/WebInspectorUI

Web Inspector: allow drag-to-adjust on angle input of gradients editor
https://bugs.webkit.org/show_bug.cgi?id=129095

Reviewed by Timothy Hatcher.

Rename CodeMirrorDragToAlterNumberController to CodeMirrorDragToAdjustNumberController and move
the core logic of a drag-to-adjust behavior out of it to a new generic class DragToAdjustController.
We use this new class from CodeMirrorGradientEditingController to provide drag-to-adjust behavior
in the angle input field of the gradient editor and also as a supporting object for the CodeMirror-
specific class.

  • UserInterface/CodeMirrorDragToAdjustNumberController.css: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.css.

(.CodeMirror.drag-to-adjust .CodeMirror-lines):

  • UserInterface/CodeMirrorDragToAdjustNumberController.js: Added.

Removed the UI logic and use the new DragToAdjustController as a supporting object instead. We implement
the various DragToAdjustController delegate methods in order to customize its behavior to work within the
context of a CodeMirror editor, specifically to prevent activation when the editor is read-only and to
prevent adjustment when the hovered token isn't a number.

(WebInspector.CodeMirrorDragToAdjustNumberController):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.get enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerActiveStateChanged):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeActivated):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanBeAdjusted):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerDidReset):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):

  • UserInterface/CodeMirrorGradientEditingController.css:

(.gradient-editing-controller > label.drag-to-adjust > input):

  • UserInterface/CodeMirrorGradientEditingController.js:

Adopt the new DragToAdjustController to make the angle input field value adjustable by dragging.

(WebInspector.CodeMirrorGradientEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorGradientEditingController.prototype.dragToAdjustControllerWasAdjustedByAmount):
(WebInspector.CodeMirrorGradientEditingController.prototype._handleInputEvent):
(WebInspector.CodeMirrorGradientEditingController.prototype._angleInputValueDidChange):

  • UserInterface/DragToAdjustController.js: Renamed from Source/WebInspectorUI/UserInterface/CodeMirrorDragToAlterNumberController.js.

New DragToAdjustController class exposing only the core UI logic of a drag-to-adjust behavior in the context
of a DOM element, exposing a few delegation methods to customize the controller's behavior:

  • dragToAdjustControllerActiveStateChanged() notifies that the .active property has changed, allowing bringup

and cleanup work to be performed.

  • dragToAdjustControllerDidReset() notifies that the various tracking states of the controller have been reset

allowing other state objects used by clients to be cleared.

  • dragToAdjustControllerCanBeActivated() is used to check whether the controller may enter the active state upon

first hovering the target element.

  • dragToAdjustControllerCanBeAdjusted() is used to check whether adjustment can be performed at the moment when

the user actually is about to engage in a drag-to-adjust interaction.

  • dragToAdjustControllerCanAdjustObjectAtPoint() is used to check whether the object at the provided point (mouse

location) is an adjustable value.

  • dragToAdjustControllerWasAdjustedByAmount() notifies that there is a new amount to add to the current value

following a drag-to-adjust interaction.

(WebInspector.DragToAdjustController):
(WebInspector.DragToAdjustController.prototype.get element):
(WebInspector.DragToAdjustController.prototype.set element):
(WebInspector.DragToAdjustController.prototype.set enabled):
(WebInspector.DragToAdjustController.prototype.get active):
(WebInspector.DragToAdjustController.prototype.set active):
(WebInspector.DragToAdjustController.prototype.reset):
(WebInspector.DragToAdjustController.prototype.handleEvent):
(WebInspector.DragToAdjustController.prototype._setDragging):
(WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
(WebInspector.DragToAdjustController.prototype._modifiersDidChange):
(WebInspector.DragToAdjustController.prototype._mouseMoved):
(WebInspector.DragToAdjustController.prototype._mouseWasPressed):
(WebInspector.DragToAdjustController.prototype._mouseWasDragged):
(WebInspector.DragToAdjustController.prototype._mouseWasReleased):

  • UserInterface/Main.html:

Link in new source files.

5:58 AM Changeset in webkit [164539] by krit@webkit.org
  • 1 edit
    114 deletes in trunk/LayoutTests

Replace svg/clip-path pixel tests by reference tests
https://bugs.webkit.org/show_bug.cgi?id=129177

Patch by Dirk Schulze <krit@webkit.org> on 2014-02-21
Rubber-stamped by Ryosuke Niwa.

This patch removes all pixel tests.

  • platform/efl/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-text-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-evenodd-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-nonzero-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/gtk/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/gtk/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-clip-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-child-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-childs-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-clipped-nonzero-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-css-transform-1-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-css-transform-2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-evenodd-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-nonzero-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-objectBoundingBox-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-clipped-use-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-and-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-g-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-and-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-on-svg-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-text-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-text-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-transform-1-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-transform-2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-userSpaceOnUse-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-container-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.png: Removed.
  • platform/mac/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • platform/mac/svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Removed.
  • platform/mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Removed.
  • platform/mac/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Removed.
  • svg/clip-path/clip-in-clip-expected.png: Removed.
  • svg/clip-path/clip-in-clip-expected.txt: Removed.
  • svg/clip-path/clip-in-clip.svg: Removed.
  • svg/clip-path/clip-in-mask-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-objectBoundingBox-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-objectBoundingBox.svg: Removed.
  • svg/clip-path/clip-in-mask-userSpaceOnUse-expected.txt: Removed.
  • svg/clip-path/clip-in-mask-userSpaceOnUse.svg: Removed.
  • svg/clip-path/clip-in-mask.svg: Removed.
  • svg/clip-path/clip-path-child-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-child-clipped.svg: Removed.
  • svg/clip-path/clip-path-childs-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-childs-clipped.svg: Removed.
  • svg/clip-path/clip-path-clipped-evenodd-twice-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-evenodd-twice.svg: Removed.
  • svg/clip-path/clip-path-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • svg/clip-path/clip-path-clipped-no-content-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-no-content.svg: Removed.
  • svg/clip-path/clip-path-clipped-nonzero-expected.txt: Removed.
  • svg/clip-path/clip-path-clipped-nonzero.svg: Removed.
  • svg/clip-path/clip-path-clipped.svg: Removed.
  • svg/clip-path/clip-path-css-transform-1-expected.txt: Removed.
  • svg/clip-path/clip-path-css-transform-1.svg: Removed.
  • svg/clip-path/clip-path-css-transform-2-expected.txt: Removed.
  • svg/clip-path/clip-path-css-transform-2.svg: Removed.
  • svg/clip-path/clip-path-evenodd-expected.txt: Removed.
  • svg/clip-path/clip-path-evenodd-nonzero-expected.txt: Removed.
  • svg/clip-path/clip-path-evenodd-nonzero.svg: Removed.
  • svg/clip-path/clip-path-evenodd.svg: Removed.
  • svg/clip-path/clip-path-nonzero-evenodd-expected.txt: Removed.
  • svg/clip-path/clip-path-nonzero-evenodd.svg: Removed.
  • svg/clip-path/clip-path-nonzero-expected.txt: Removed.
  • svg/clip-path/clip-path-nonzero.svg: Removed.
  • svg/clip-path/clip-path-objectBoundingBox-expected.txt: Removed.
  • svg/clip-path/clip-path-objectBoundingBox.svg: Removed.
  • svg/clip-path/clip-path-on-clipped-use-expected.txt: Removed.
  • svg/clip-path/clip-path-on-clipped-use.svg: Removed.
  • svg/clip-path/clip-path-on-g-and-child-expected.txt: Removed.
  • svg/clip-path/clip-path-on-g-and-child.svg: Removed.
  • svg/clip-path/clip-path-on-g-expected.txt: Removed.
  • svg/clip-path/clip-path-on-g.svg: Removed.
  • svg/clip-path/clip-path-on-svg-and-child-expected.txt: Removed.
  • svg/clip-path/clip-path-on-svg-and-child.svg: Removed.
  • svg/clip-path/clip-path-on-svg-expected.txt: Removed.
  • svg/clip-path/clip-path-on-svg.svg: Removed.
  • svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • svg/clip-path/clip-path-pixelation.svg: Removed.
  • svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • svg/clip-path/clip-path-recursive-call-by-child-expected.txt: Removed.
  • svg/clip-path/clip-path-recursive-call-by-child.svg: Removed.
  • svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • svg/clip-path/clip-path-recursive-call-expected.txt: Removed.
  • svg/clip-path/clip-path-recursive-call.svg: Removed.
  • svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • svg/clip-path/clip-path-text-and-shape.svg: Removed.
  • svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • svg/clip-path/clip-path-text-and-stroke.svg: Removed.
  • svg/clip-path/clip-path-text-expected.txt: Removed.
  • svg/clip-path/clip-path-text.svg: Removed.
  • svg/clip-path/clip-path-transform-1-expected.txt: Removed.
  • svg/clip-path/clip-path-transform-1.svg: Removed.
  • svg/clip-path/clip-path-transform-2-expected.txt: Removed.
  • svg/clip-path/clip-path-transform-2.svg: Removed.
  • svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • svg/clip-path/clip-path-tspan-and-stroke.svg: Removed.
  • svg/clip-path/clip-path-use-as-child-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child.svg: Removed.
  • svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child2-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child2.svg: Removed.
  • svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child3-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child3.svg: Removed.
  • svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child4-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child4.svg: Removed.
  • svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • svg/clip-path/clip-path-use-as-child5-expected.txt: Removed.
  • svg/clip-path/clip-path-use-as-child5.svg: Removed.
  • svg/clip-path/clip-path-userSpaceOnUse-expected.txt: Removed.
  • svg/clip-path/clip-path-userSpaceOnUse.svg: Removed.
  • svg/clip-path/clip-path-with-container-expected.png: Removed.
  • svg/clip-path/clip-path-with-container-expected.txt: Removed.
  • svg/clip-path/clip-path-with-container.svg: Removed.
  • svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • svg/clip-path/clip-path-with-different-unittypes-expected.txt: Removed.
  • svg/clip-path/clip-path-with-different-unittypes.svg: Removed.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.txt: Removed.
  • svg/clip-path/clip-path-with-different-unittypes2.svg: Removed.
  • svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • svg/clip-path/clip-path-with-invisibile-child-expected.txt: Removed.
  • svg/clip-path/clip-path-with-invisibile-child.svg: Removed.
  • svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • svg/clip-path/clip-path-with-text-clipped.svg: Removed.
  • svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • svg/clip-path/clipper-placement-issue-expected.txt: Removed.
  • svg/clip-path/clipper-placement-issue.svg: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-different-unitTypes-expected.txt: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-different-unitTypes.svg: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • svg/clip-path/deep-nested-clip-in-mask-panning.svg: Removed.
  • svg/clip-path/deep-nested-clip-in-mask.svg: Removed.
  • svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt: Removed.
  • svg/clip-path/nested-clip-in-mask-image-based-clipping.svg: Removed.
  • svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt: Removed.
  • svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping.svg: Removed.
  • svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt: Removed.
  • svg/clip-path/nested-clip-in-mask-path-based-clipping.svg: Removed.
2:21 AM Changeset in webkit [164538] by fred.wang@free.fr
  • 5 edits in trunk

Only skip stretchy operators when determining the stretch height.
https://bugs.webkit.org/show_bug.cgi?id=126842

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code only takes into account non-mo children for the computation of the stretch size. This change includes non-stretchy mo in that computation. A new test is added into mathml/presentation/stretchy-depth-height.html.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

  • mathml/presentation/stretchy-depth-height.html: Add a test with non-stretchy mo siblings.
2:14 AM Changeset in webkit [164537] by fred.wang@free.fr
  • 4 edits
    2 adds in trunk

Implement asymmetric/symmetric stretching of vertical operators.
https://bugs.webkit.org/show_bug.cgi?id=124827.

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code stretches vertical operators asymmetrically by default. This patch takes into account the symmetric attribute or the symmetric property of the operator dictionary to stretch operators symmetrically.

Test: mathml/presentation/stretchy-depth-height-symmetric.html

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::updateStyle):

LayoutTests:

Add a new test to verify the symmetric property of operators (either implicit by the operator dictionary or explicit via an mo attribute).

  • LayoutTests/platform/mac/mathml/presentation/mo-stretch-expected.txt: rebased.
  • mathml/presentation/stretchy-depth-height-symmetric-expected.txt: Added.
  • mathml/presentation/stretchy-depth-height-symmetric.html: Added.
2:08 AM Changeset in webkit [164536] by fred.wang@free.fr
  • 8 edits
    2 adds in trunk

Bug 119043 - Large stretch size error for MathML operators.
https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLTable):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

  • mathml/presentation/stretchy-depth-height-expected.txt: Added.
  • mathml/presentation/stretchy-depth-height.html: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:57 AM Changeset in webkit [164535] by fred.wang@free.fr
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r164534.
http://trac.webkit.org/changeset/164534
https://bugs.webkit.org/show_bug.cgi?id=119043

missing tests

Source/WebCore:

  • rendering/RenderObject.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::expandedStretchHeight):
(WebCore::RenderMathMLOperator::stretchToHeight):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

  • mathml/presentation/stretchy-depth-height-expected.txt: Removed.
  • mathml/presentation/stretchy-depth-height.html: Removed.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:50 AM Changeset in webkit [164534] by fred.wang@free.fr
  • 8 edits
    2 adds in trunk

Bug 119043 - Large stretch size error for MathML operators.
https://bugs.webkit.org/show_bug.cgi?id=119043

Reviewed by Chris Fleizach.

Source/WebCore:

The MathML code used some arbitrary gOperatorExpansion factor for the
stretch size and 2/3 1/2 constants for the baseline. This change tries
to consider height/depth of siblings of the stretchy operator so that
the stretchy operator now matches its target.

Test: mathml/presentation/stretchy-depth-height.html

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLTable):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::findAcceptableStretchyCharacter):
(WebCore::RenderMathMLOperator::updateStyle):
(WebCore::RenderMathMLOperator::firstLineBaseline):
(WebCore::RenderMathMLOperator::computeLogicalHeight):

  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::layout):

LayoutTests:

This adds a test to check that the depth/height of stretchy operators match the maximum of their siblings. This also fixes the reference of mo-stretch.html to ignore the stretch error.

  • mathml/presentation/stretchy-depth-height-expected.txt: Added.
  • mathml/presentation/stretchy-depth-height.html: Added.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:23 AM Changeset in webkit [164533] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL WK2 gardening. Skip a webgl test because of crashing.
Besides a bug is filed and assigned to those crash tests.

  • platform/efl-wk2/TestExpectations:

Feb 21, 2014:

11:24 PM Changeset in webkit [164532] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

REGRESSION(r164412): Pixel cracks when zooming in to any web content.
https://bugs.webkit.org/show_bug.cgi?id=129195

Reviewed by Simon Fraser.

Integral clipping of the repaint rect was prematurely removed in RenderLayerBacking::paintContents().
Repaint rects needs a uniform, device pixel precise clipping across the painting flow including RenderLayer,
RenderView and TileController.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):

11:20 PM Changeset in webkit [164531] by krit@webkit.org
  • 5 edits
    128 adds in trunk/LayoutTests

Replace svg/clip-path pixel tests by reference tests
https://bugs.webkit.org/show_bug.cgi?id=129177

Reviewed by Dean Jackson.

New reference tests for SVG clip-path.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • svg/clip-path/clip-path-clip-expected.svg: Added.
  • svg/clip-path/clip-path-clip-nested-twice-expected.svg: Added.
  • svg/clip-path/clip-path-clip-nested-twice.svg: Added.
  • svg/clip-path/clip-path-clip-rule-001-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-001.svg: Added.
  • svg/clip-path/clip-path-clip-rule-002-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-002.svg: Added.
  • svg/clip-path/clip-path-clip-rule-003-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-003.svg: Added.
  • svg/clip-path/clip-path-clip-rule-004-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-004.svg: Added.
  • svg/clip-path/clip-path-clip-rule-005-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-005.svg: Added.
  • svg/clip-path/clip-path-clip-rule-006-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-006.svg: Added.
  • svg/clip-path/clip-path-clip-rule-007-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-007.svg: Added.
  • svg/clip-path/clip-path-clip-rule-008-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-008.svg: Added.
  • svg/clip-path/clip-path-clip-rule-009-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-009.svg: Added.
  • svg/clip-path/clip-path-clip-rule-010-expected.svg: Added.
  • svg/clip-path/clip-path-clip-rule-010.svg: Added.
  • svg/clip-path/clip-path-clip.svg: Added.
  • svg/clip-path/clip-path-content-clip-001-expected.svg: Added.
  • svg/clip-path/clip-path-content-clip-001.svg: Added.
  • svg/clip-path/clip-path-content-clip-002-expected.svg: Added.
  • svg/clip-path/clip-path-content-clip-002.svg: Added.
  • svg/clip-path/clip-path-content-clip-003-expected.svg: Added.
  • svg/clip-path/clip-path-content-clip-003.svg: Added.
  • svg/clip-path/clip-path-content-invisible-expected.svg: Added.
  • svg/clip-path/clip-path-content-invisible.svg: Added.
  • svg/clip-path/clip-path-content-syling-expected.svg: Added.
  • svg/clip-path/clip-path-content-syling.svg: Added.
  • svg/clip-path/clip-path-content-use-001-expected.svg: Added.
  • svg/clip-path/clip-path-content-use-001.svg: Added.
  • svg/clip-path/clip-path-content-use-002-expected.svg: Added.
  • svg/clip-path/clip-path-content-use-002.svg: Added.
  • svg/clip-path/clip-path-content-use-003-expected.svg: Added.
  • svg/clip-path/clip-path-content-use-003.svg: Added.
  • svg/clip-path/clip-path-content-use-004-expected.svg: Added.
  • svg/clip-path/clip-path-content-use-004.svg: Added.
  • svg/clip-path/clip-path-content-use-005-expected.svg: Added.
  • svg/clip-path/clip-path-content-use-005.svg: Added.
  • svg/clip-path/clip-path-content-use-006-expected.svg: Added.
  • svg/clip-path/clip-path-content-use-006.svg: Added.
  • svg/clip-path/clip-path-css-transform-001-expected.svg: Added.
  • svg/clip-path/clip-path-css-transform-001.svg: Added.
  • svg/clip-path/clip-path-css-transform-002-expected.svg: Added.
  • svg/clip-path/clip-path-css-transform-002.svg: Added.
  • svg/clip-path/clip-path-invalid-expected.svg: Added.
  • svg/clip-path/clip-path-invalid.svg: Added.
  • svg/clip-path/clip-path-no-content-001-expected.svg: Added.
  • svg/clip-path/clip-path-no-content-001.svg: Added.
  • svg/clip-path/clip-path-no-content-002-expected.svg: Added.
  • svg/clip-path/clip-path-no-content-002.svg: Added.
  • svg/clip-path/clip-path-no-content-003-expected.svg: Added.
  • svg/clip-path/clip-path-no-content-003.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-001-expected.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-001.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-002-expected.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-002.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-003-expected.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-003.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-004-expected.svg: Added.
  • svg/clip-path/clip-path-objectboundingbox-004.svg: Added.
  • svg/clip-path/clip-path-on-g-001-expected.svg: Added.
  • svg/clip-path/clip-path-on-g-001.svg: Added.
  • svg/clip-path/clip-path-on-g-002-expected.svg: Added.
  • svg/clip-path/clip-path-on-g-002.svg: Added.
  • svg/clip-path/clip-path-on-g-003-expected.svg: Added.
  • svg/clip-path/clip-path-on-g-003.svg: Added.
  • svg/clip-path/clip-path-on-g-004-expected.svg: Added.
  • svg/clip-path/clip-path-on-g-004.svg: Added.
  • svg/clip-path/clip-path-on-g-005-expected.svg: Added.
  • svg/clip-path/clip-path-on-g-005.svg: Added.
  • svg/clip-path/clip-path-on-svg-001-expected.svg: Added.
  • svg/clip-path/clip-path-on-svg-001.svg: Added.
  • svg/clip-path/clip-path-on-svg-002-expected.svg: Added.
  • svg/clip-path/clip-path-on-svg-002.svg: Added.
  • svg/clip-path/clip-path-on-use-001-expected.svg: Added.
  • svg/clip-path/clip-path-on-use-001.svg: Added.
  • svg/clip-path/clip-path-on-use-002-expected.svg: Added.
  • svg/clip-path/clip-path-on-use-002.svg: Added.
  • svg/clip-path/clip-path-precision-001-expected.svg: Added.
  • svg/clip-path/clip-path-precision-001.svg: Added.
  • svg/clip-path/clip-path-text-001-expected.svg: Added.
  • svg/clip-path/clip-path-text-001.svg: Added.
  • svg/clip-path/clip-path-text-002-expected.svg: Added.
  • svg/clip-path/clip-path-text-002.svg: Added.
  • svg/clip-path/clip-path-text-003-expected.svg: Added.
  • svg/clip-path/clip-path-text-003.svg: Added.
  • svg/clip-path/clip-path-text-004-expected.svg: Added.
  • svg/clip-path/clip-path-text-004.svg: Added.
  • svg/clip-path/clip-path-text-005-expected.svg: Added.
  • svg/clip-path/clip-path-text-005.svg: Added.
  • svg/clip-path/clip-path-userspaceonuse-001-expected.svg: Added.
  • svg/clip-path/clip-path-userspaceonuse-001.svg: Added.
  • svg/clip-path/mask-nested-clip-path-001-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-001.svg: Added.
  • svg/clip-path/mask-nested-clip-path-002-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-002.svg: Added.
  • svg/clip-path/mask-nested-clip-path-003-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-003.svg: Added.
  • svg/clip-path/mask-nested-clip-path-004-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-004.svg: Added.
  • svg/clip-path/mask-nested-clip-path-005-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-005.svg: Added.
  • svg/clip-path/mask-nested-clip-path-006-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-006.svg: Added.
  • svg/clip-path/mask-nested-clip-path-007-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-007.svg: Added.
  • svg/clip-path/mask-nested-clip-path-008-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-008.svg: Added.
  • svg/clip-path/mask-nested-clip-path-009-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-009.svg: Added.
  • svg/clip-path/mask-nested-clip-path-panning-001-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-panning-001.svg: Added.
  • svg/clip-path/mask-nested-clip-path-panning-002-expected.svg: Added.
  • svg/clip-path/mask-nested-clip-path-panning-002.svg: Added.
  • svg/clip-path/mask-objectboundingbox-content-clip-expected.svg: Added.
  • svg/clip-path/mask-objectboundingbox-content-clip-transform-expected.svg: Added.
  • svg/clip-path/mask-objectboundingbox-content-clip-transform.svg: Added.
  • svg/clip-path/mask-objectboundingbox-content-clip.svg: Added.
  • svg/clip-path/mask-userspaceonuse-content-clip-expected.svg: Added.
  • svg/clip-path/mask-userspaceonuse-content-clip-transform-expected.svg: Added.
  • svg/clip-path/mask-userspaceonuse-content-clip-transform.svg: Added.
  • svg/clip-path/mask-userspaceonuse-content-clip.svg: Added.
10:56 PM Changeset in webkit [164530] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Mac build fix after r164529.

Replace the string-to-array algorithm with a archictecture-independant
one.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):

10:17 PM Changeset in webkit [164529] by jer.noble@apple.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[EME] Add a CDMSession for MediaPlayerPrivateMediaSourceAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=129166

Reviewed by Eric Carlson.

Add a new CDMSession, cerated by MediaPlayerPrivateMediaSourceAVFObjC allowing
media-source-backed media elements to play protected content.

Add a new CDMSessionMediaSourceAVFObjC class:

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h: Added.

(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm: Added.

(WebCore::CDMSessionMediaSourceAVFObjC::CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest): Do not actually generate a

key request until the certificate data has been added via update();

(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): No-op.
(WebCore::CDMSessionMediaSourceAVFObjC::update): If no certificate data has yet been

added, assume the incoming message contains it.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine): Add supportsKeySystem.
(WebCore::keySystemIsSupported): Use "com.apple.fps.2_0" to distinguish from the not-media-source scheme.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType): Check the keySystem type.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsKeySystem): Added.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createSession): Added, pass through to MediaSourcePrivate.

  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::createSession): Added.
(WebCore::MediaSourcePrivateAVFObjC::sourceBufferKeyNeeded): Pass through to MediaPlayer.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVStreamDataParserListener streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID:]):

Added, pass through to SourceBufferPrivate.

(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID): Remember

which track is requesting the key, and pass the request to MediaSourcePrivate.

Add new files to the project.

  • WebCore.xcodeproj/project.pbxproj:
10:07 PM Changeset in webkit [164528] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify contains seemingly accidental unreachable code
https://bugs.webkit.org/show_bug.cgi?id=129193

Reviewed by Joseph Pecoraro.

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): Fix the accidental code.

9:05 PM Changeset in webkit [164527] by Brent Fulgham
  • 14 edits in trunk/Source

Extend media support for WebVTT sources
https://bugs.webkit.org/show_bug.cgi?id=129156

Reviewed by Eric Carlson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::outOfBandTrackSources): Added.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::outOfBandTrackSources): Added.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::outOfBandTrackSources): Added.

  • platform/graphics/PlatformTextTrack.h:

(WebCore::PlatformTextTrack::create): Update for new constructor signature.
(WebCore::PlatformTextTrack::createOutOfBand): Added.
(WebCore::PlatformTextTrack::url): Added.
(WebCore::PlatformTextTrack::isDefault): Added.
(WebCore::PlatformTextTrack::PlatformTextTrack): Revised to take new URL and
'isDefault' arguments.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::mediaDescriptionForKind): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation about any
WebVTT tracks supplied by the web page.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMediaSelectionOptions): Filter out any out-of-band
WebVTT tracks returned by the media engine to avoid double-counting tracks.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Add new feature define for AVF_CAPTIONS
8:09 PM Changeset in webkit [164526] by rniwa@webkit.org
  • 23 edits in trunk

Inner text element should not use -webkit-user-modify
https://bugs.webkit.org/show_bug.cgi?id=129035

Reviewed by Andreas Kling.

Source/WebCore:

To eliminate the internal use of -webkit-user-modify, use contenteditable attribute in the inner text elements
instead of manually inspecting disabled-ness and readonly-ness in RenderTextControl.

Unfortunately, we still have to manually set UserModify value in RenderTextControl::adjustInnerTextStyle since
RenderTextControl::styleDidChange creates RenderStyle for its inner text from scratch via createInnerTextStyle.

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::disabledStateChanged): Don't use childrenOfType iterator which asserts that DOM
isn't mutated during the traversal since we now set contenteditable attribute inside disabledStateChanged via
updateFromControlElementsAncestorDisabledStateUnder.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseAttribute): Extracted readOnlyAttributeChanged out of this function so
that HTMLTextFormControl could override it to call updateInnerTextElementEditability.
(WebCore::HTMLFormControlElement::readOnlyAttributeChanged): Ditto.

  • html/HTMLFormControlElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didAddUserAgentShadowRoot): Call updateInnerTextElementEditability after creating
shadow DOM for the current input type.
(WebCore::HTMLInputElement::updateType): Ditto.
(WebCore::HTMLInputElement::parseAttribute): Ditto.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot): Call updateInnerTextElementEditability.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::disabledStateChanged): Added to update contenteditable attribute since
the editability of the inner text element depends on disabled-ness of the element.
(WebCore::HTMLTextFormControlElement::readOnlyAttributeChanged): Ditto for the readonly-ness of the element.
(WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability): Added.

  • html/HTMLTextFormControlElement.h:
  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::adjustInnerTextStyle): Use the inner text element's presentationAttributeStyle() to
compute the appropriate EUserModify value instead of hard-coding it here.

  • rendering/RenderTextControl.h:

LayoutTests:

Rebaselined tests as the user agent shadow DOM of input and textarea elements now have contenteditable attribute.

  • editing/input/paste-text-ending-with-interchange-newline-expected.txt:
  • editing/inserting/5607069-2-expected.txt:
  • editing/inserting/5607069-3-expected.txt:
  • editing/pasteboard/copy-image-with-alt-text-expected.txt:
  • editing/pasteboard/copy-null-characters-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/selection/dump-as-markup-expected.txt:
  • editing/selection/dump-as-markup-form-text-expected.txt:
  • fast/forms/suggested-value-after-setvalue-expected.txt:
  • fast/forms/suggested-value-expected.txt:
  • fast/parser/object-with-textarea-fallback-expected.txt:
7:56 PM Changeset in webkit [164525] by ChangSeok Oh
  • 4 edits in trunk/Source/WebCore

[GTK] Support WEBGL_draw_buffers extension.
https://bugs.webkit.org/show_bug.cgi?id=129143

Reviewed by Dean Jackson.

Support the WEBGL_draw_buffers WebGL extension for gtk port. Relevant opengl APIs
are exposed for WebGLRenderingContext to access them properly.

Covered by fast/canvas/webgl/webgl-draw-buffers.html

  • platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

  • platform/graphics/OpenGLShims.h:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension):
(WebCore::Extensions3DOpenGL::drawBuffersEXT):

7:53 PM Changeset in webkit [164524] by ChangSeok Oh
  • 4 edits in trunk/Source/WebCore

Mac port uses ANGLE_instanced_arrays related apis through those in GraphicsContext3DCommon.cpp
https://bugs.webkit.org/show_bug.cgi?id=128803

Reviewed by Dean Jackson.

Merge mac port implementation of ANGLE_instanced_arrays into common code.

No new tests, no functionality changed.

  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::drawArraysInstanced):
(WebCore::Extensions3DOpenGL::drawElementsInstanced):
(WebCore::Extensions3DOpenGL::vertexAttribDivisor):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::vertexAttribDivisor):

7:39 PM Changeset in webkit [164523] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WebKit2] Keyboard appears every time a link is tapped after searching Google
<rdar://problem/16072563>.

Reviewed by Benjamin Poulain.

We need to stop assisting the node if we have
navigated to a different page.

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _didCommitLoadForMainFrame]):

7:15 PM Changeset in webkit [164522] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

Made WKWebView implement all WKContentViewDelegate methods.

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeViewSnapshotForContentView:]): Moved from WKViewIOS.mm.

  • UIProcess/API/ios/WKContentView.h: Made all protocol methods required.
  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]): Removed code
to set self as the delegate on the content view.

7:14 PM Changeset in webkit [164521] by mmaxfield@apple.com
  • 5 edits
    2 adds in trunk

After copy and paste, cursor may appear to be above the bottom of content
https://bugs.webkit.org/show_bug.cgi?id=129167

Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a clear:both to the end of content.

I can't handle the case of the cursor appearing above the bottom of
absolutely positioned divs (of the case of floats inside absolutely
positioned divs) because you can't know where the bottom of a div
will end up being rendered (it is affected by things like browser
window width and text size settings). Therefore, the only case I
can handle is the case where there is a floating div in the same
level as the document itself.

Test: editing/pasteboard/copy-paste-inserts-clearing-div.html

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::isFloating):

  • editing/EditingStyle.h:
  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator):
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::createMarkupInternal):

LayoutTests:

Makes sure that the clearing div is inserted.

  • editing/pasteboard/copy-paste-inserts-clearing-div-expected.txt: Added.
  • editing/pasteboard/copy-paste-inserts-clearing-div.html: Added.
6:58 PM Changeset in webkit [164520] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix after r164505

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update exports

definition for TreeScope::getElementById.

6:45 PM Changeset in webkit [164519] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS Media] Wireless target UI
https://bugs.webkit.org/show_bug.cgi?id=129189
<rdar://problem/15349928>
<rdar://problem/16100060>

Reviewed by Eric Carlson.

Implement a prototype UI for wireless playback targets. The UI
doesn't currently work, but can be simulated via a class variable
in ControllerIOS.

  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-panel button): Reset the default style of
button elements, to avoid getting a border.
(audio::-webkit-media-controls-wireless-playback-status): Holds the UI showing
the user that the media is playing on another target.
(audio::-webkit-media-controls-wireless-playback-status.hidden):
(audio::-webkit-media-controls-wireless-playback-picker-button): The button to
trigger selection of targets.
(audio::-webkit-media-controls-wireless-playback-picker-button.active):
(audio::-webkit-media-controls-panel): This needs to be position absolute for
the wireless playback status to fill the viewport.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Check for targets.
(ControllerIOS.prototype.addVideoListeners):
(ControllerIOS.prototype.removeVideoListeners):
(ControllerIOS.prototype.UIString): New method to return localized strings (with
a FIXME).
(ControllerIOS.prototype.shouldHaveAnyUI): Needs to display if there is a wireless
target.
(ControllerIOS.prototype.currentPlaybackTargetIsWireless):
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Create the status content,
replacing the device name if it is available.
(ControllerIOS.prototype.updateWirelessTargetAvailable):
(ControllerIOS.prototype.createControls):
(ControllerIOS.prototype.configureInlineControls):
(ControllerIOS.prototype.handleWirelessPlaybackChange):
(ControllerIOS.prototype.handleWirelessTargetAvailableChange):
(ControllerIOS.prototype.handleWirelessPickerButtonClicked):

5:58 PM Changeset in webkit [164518] by Brian Burg
  • 10 edits
    789 moves
    32 adds
    8 deletes in trunk/LayoutTests

Move unported Web Inspector tests to LayoutTests/inspector-obsolete
https://bugs.webkit.org/show_bug.cgi?id=129183

Rubber-stamped by Timothy Hatcher.

Move inspector/ to inspector-obsolete/.
Move http/tests/inspector/ to inspector-obsolete/http-tests/.
Fold http/tests/inspector-enabled/ into inspector-obsolete/http-tests/.

I have elided about 1100 lines of rename Changelog spew;
no filenames have been altered in this reorganization.

Remove mentions of obsolete tests from TestExpectations. Remove skips
for inspector-obsolete/ from port-specific expectations, and just
put it in the generic expectations file.

Remove inspector-protocol/heap-profiler tests, as they are obsolete.

  • TestExpectations:
    • inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt: Removed.
  • inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html: Removed.
  • inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt: Removed.
  • inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html: Removed.
  • inspector-protocol/heap-profiler/resources/heap-snapshot-common.js: Removed.
  • inspector-protocol/heap-profiler/resources/page-with-function.html: Removed.
  • inspector-protocol/heap-profiler/take-heap-snapshot-expected.txt: Removed.
  • inspector-protocol/heap-profiler/take-heap-snapshot.html: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win-xp/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
5:03 PM Changeset in webkit [164517] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/16073882> Please add _AbandonCoalition key to plugin XPC service Info.plist

Anders Carlsson.

  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
4:31 PM Changeset in webkit [164516] by jpfau@apple.com
  • 6 edits in trunk

[Mac] Cache callbacks for cache partitioning may be passed null
https://bugs.webkit.org/show_bug.cgi?id=129175

Reviewed by Brady Eidson.

Source/WebKit2:

  • WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):

WebKitLibraries:

  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMavericks.a:
  • libWebKitSystemInterfaceMountainLion.a:
4:28 PM Changeset in webkit [164515] by Brian Burg
  • 1 edit
    356 deletes in trunk/LayoutTests

Web Inspector: remove old inspector tests that cannot be ported
https://bugs.webkit.org/show_bug.cgi?id=129168

Reviewed by Timothy Hatcher.

Remove many tests that were specific to the old inspector user interface.
These cannot be ported either because they were specific to the UI, or
they test features that no longer exist in the Web Inspector.

  • inspector/audits/audits-panel-functional-expected.txt: Removed.
  • inspector/audits/audits-panel-functional.html: Removed.
  • inspector/audits/audits-panel-noimages-functional-expected.txt: Removed.
  • inspector/audits/audits-panel-noimages-functional.html: Removed.
  • inspector/audits/audits-test.js: Removed.
  • inspector/audits/resources/audits-script1.js: Removed.
  • inspector/audits/resources/audits-script2.js: Removed.
  • inspector/audits/resources/audits-style1.css: Removed.
  • inspector/console/command-line-api-getEventListeners-expected.txt: Removed.
  • inspector/console/command-line-api-getEventListeners.html: Removed.
  • inspector/console/console-big-array-expected.txt: Removed.
  • inspector/console/console-big-array.html: Removed.
  • inspector/console/console-clear-expected.txt: Removed.
  • inspector/console/console-clear.html: Removed.
  • inspector/console/console-dirxml-expected.txt: Removed.
  • inspector/console/console-dirxml.html: Removed.
  • inspector/console/console-filter-test-expected.txt: Removed.
  • inspector/console/console-filter-test.html: Removed.
  • inspector/console/console-format-collections-expected.txt: Removed.
  • inspector/console/console-format-collections.html: Removed.
  • inspector/console/console-format-expected.txt: Removed.
  • inspector/console/console-format-style-expected.txt: Removed.
  • inspector/console/console-format-style-whitelist-expected.txt: Removed.
  • inspector/console/console-format-style-whitelist.html: Removed.
  • inspector/console/console-format-style.html: Removed.
  • inspector/console/console-format-table-expected.txt: Removed.
  • inspector/console/console-format-table.html: Removed.
  • inspector/console/console-format.html: Removed.
  • inspector/console/console-trim-long-urls-expected.txt: Removed.
  • inspector/console/console-trim-long-urls.html: Removed.
  • inspector/cookie-parser-expected.txt: Removed.
  • inspector/cookie-parser.html: Removed.
  • inspector/cookie-resource-match-expected.txt: Removed.
  • inspector/cookie-resource-match.html: Removed.
  • inspector/curl-command-expected.txt: Removed.
  • inspector/curl-command.html: Removed.
  • inspector/database-table-name-excaping-expected.txt: Removed.
  • inspector/database-table-name-excaping.html: Removed.
  • inspector/datagrid-autosize-expected.txt: Removed.
  • inspector/datagrid-autosize.html: Removed.
  • inspector/debugger/breakpoint-manager-listeners-count-expected.txt: Removed.
  • inspector/debugger/breakpoint-manager-listeners-count.html: Removed.
  • inspector/debugger/callstack-placards-discarded-expected.txt: Removed.
  • inspector/debugger/callstack-placards-discarded.html: Removed.
  • inspector/debugger/content-providers-expected.txt: Removed.
  • inspector/debugger/content-providers.html: Removed.
  • inspector/debugger/debug-inlined-scripts-expected.txt: Removed.
  • inspector/debugger/debug-inlined-scripts.html-disabled: Removed.
  • inspector/debugger/debugger-expand-scope-expected.txt: Removed.
  • inspector/debugger/debugger-expand-scope.html: Removed.
  • inspector/debugger/debugger-proto-property-expected.txt: Removed.
  • inspector/debugger/debugger-proto-property.html: Removed.
  • inspector/debugger/debugger-script-preprocessor-expected.txt: Removed.
  • inspector/debugger/debugger-script-preprocessor.html: Removed.
  • inspector/debugger/debugger-step-into-event-listener-expected.txt: Removed.
  • inspector/debugger/debugger-step-into-event-listener.html: Removed.
  • inspector/debugger/disable-script-expected.txt: Removed.
  • inspector/debugger/disable-script.html: Removed.
  • inspector/debugger/dom-breakpoints-expected.txt: Removed.
  • inspector/debugger/dom-breakpoints.html: Removed.
  • inspector/debugger/dynamic-script-tag-expected.txt: Removed.
  • inspector/debugger/dynamic-script-tag.html: Removed.
  • inspector/debugger/dynamic-scripts-expected.txt: Removed.
  • inspector/debugger/dynamic-scripts.html: Removed.
  • inspector/debugger/error-in-watch-expressions-expected.txt: Removed.
  • inspector/debugger/error-in-watch-expressions.html: Removed.
  • inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
  • inspector/debugger/event-listener-breakpoints.html: Removed.
  • inspector/debugger/file-system-project-mapping-expected.txt: Removed.
  • inspector/debugger/file-system-project-mapping.html: Removed.
  • inspector/debugger/linkifier-expected.txt: Removed.
  • inspector/debugger/linkifier.html: Removed.
  • inspector/debugger/live-edit-breakpoints-expected.txt: Removed.
  • inspector/debugger/live-edit-breakpoints.html: Removed.
  • inspector/debugger/live-edit-expected.txt: Removed.
  • inspector/debugger/live-edit.html: Removed.
  • inspector/debugger/mutation-observer-suspend-while-paused-expected.txt: Removed.
  • inspector/debugger/mutation-observer-suspend-while-paused.html: Removed.
  • inspector/debugger/navigator-view-expected.txt: Removed.
  • inspector/debugger/navigator-view.html: Removed.
  • inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
  • inspector/debugger/network-uisourcecode-provider.html: Removed.
  • inspector/debugger/properties-special-expected.txt: Removed.
  • inspector/debugger/properties-special.html: Removed.
  • inspector/debugger/resource-script-mapping-expected.txt: Removed.
  • inspector/debugger/resource-script-mapping.html: Removed.
  • inspector/debugger/reveal-execution-line-expected.txt: Removed.
  • inspector/debugger/reveal-execution-line.html: Removed.
  • inspector/debugger/script-extract-outline-expected.txt: Removed.
  • inspector/debugger/script-extract-outline.html: Removed.
  • inspector/debugger/script-formatter-breakpoints-expected.txt: Removed.
  • inspector/debugger/script-formatter-breakpoints.html: Removed.
  • inspector/debugger/script-formatter-console-expected.txt: Removed.
  • inspector/debugger/script-formatter-console.html: Removed.
  • inspector/debugger/script-snippet-model-expected.txt: Removed.
  • inspector/debugger/script-snippet-model.html: Removed.
  • inspector/debugger/scripts-panel-expected.txt: Removed.
  • inspector/debugger/scripts-panel.html: Removed.
  • inspector/debugger/scripts-sorting-expected.txt: Removed.
  • inspector/debugger/scripts-sorting.html: Removed.
  • inspector/debugger/selected-call-frame-after-formatting-source-expected.txt: Removed.
  • inspector/debugger/selected-call-frame-after-formatting-source.html: Removed.
  • inspector/debugger/set-breakpoint-expected.txt: Removed.
  • inspector/debugger/set-breakpoint.html: Removed.
  • inspector/debugger/source-frame-count-expected.txt: Removed.
  • inspector/debugger/source-frame-count.html: Removed.
  • inspector/debugger/source-frame-expected.txt: Removed.
  • inspector/debugger/source-frame.html: Removed.
  • inspector/debugger/step-through-event-listeners-expected.txt: Removed.
  • inspector/debugger/step-through-event-listeners.html: Removed.
  • inspector/debugger/ui-source-code-display-name-expected.txt: Removed.
  • inspector/debugger/ui-source-code-display-name.html: Removed.
  • inspector/debugger/ui-source-code-expected.txt: Removed.
  • inspector/debugger/ui-source-code.html: Removed.
  • inspector/debugger/watch-expressions-panel-switch-expected.txt: Removed.
  • inspector/debugger/watch-expressions-panel-switch.html: Removed.
  • inspector/debugger/watch-expressions-preserve-expansion-expected.txt: Removed.
  • inspector/debugger/watch-expressions-preserve-expansion.html: Removed.
  • inspector/debugger/xhr-breakpoints-expected.txt: Removed.
  • inspector/debugger/xhr-breakpoints.html: Removed.
  • inspector/dom-statistics-expected.txt: Removed.
  • inspector/dom-statistics.html-disabled: Removed.
  • inspector/editor/brace-matcher-expected.txt: Removed.
  • inspector/editor/brace-matcher.html: Removed.
  • inspector/editor/editor-test.js: Removed.
  • inspector/editor/highlighter-basics-expected.txt: Removed.
  • inspector/editor/highlighter-basics.html: Removed.
  • inspector/editor/highlighter-chunk-limit-expected.txt: Removed.
  • inspector/editor/highlighter-chunk-limit.html: Removed.
  • inspector/editor/highlighter-long-line-expected.txt: Removed.
  • inspector/editor/highlighter-long-line.html: Removed.
  • inspector/editor/highlighter-paste-in-comment-expected.txt: Removed.
  • inspector/editor/highlighter-paste-in-comment.html: Removed.
  • inspector/editor/highlighter-test.js: Removed.
  • inspector/editor/indentation-expected.txt: Removed.
  • inspector/editor/indentation.html: Removed.
  • inspector/editor/text-editor-brace-highlighter-expected.txt: Removed.
  • inspector/editor/text-editor-brace-highlighter.html: Removed.
  • inspector/editor/text-editor-char-to-coordinates-expected.txt: Removed.
  • inspector/editor/text-editor-char-to-coordinates.html: Removed.
  • inspector/editor/text-editor-formatter-expected.txt: Removed.
  • inspector/editor/text-editor-formatter.html: Removed.
  • inspector/editor/text-editor-highlight-api-expected.txt: Removed.
  • inspector/editor/text-editor-highlight-api.html: Removed.
  • inspector/editor/text-editor-highlight-token-expected.txt: Removed.
  • inspector/editor/text-editor-highlight-token.html: Removed.
  • inspector/editor/text-editor-home-button-expected.txt: Removed.
  • inspector/editor/text-editor-home-button.html: Removed.
  • inspector/editor/text-editor-line-breaks-expected.txt: Removed.
  • inspector/editor/text-editor-line-breaks.html: Removed.
  • inspector/editor/text-editor-long-line-expected.txt: Removed.
  • inspector/editor/text-editor-long-line.html: Removed.
  • inspector/editor/text-editor-model-expected.txt: Removed.
  • inspector/editor/text-editor-model.html: Removed.
  • inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Removed.
  • inspector/editor/text-editor-remove-chunks-from-dom.html: Removed.
  • inspector/editor/text-editor-selection-expected.txt: Removed.
  • inspector/editor/text-editor-selection-to-search-expected.txt: Removed.
  • inspector/editor/text-editor-selection-to-search.html: Removed.
  • inspector/editor/text-editor-selection.html: Removed.
  • inspector/editor/text-editor-show-whitespace-expected.txt: Removed.
  • inspector/editor/text-editor-show-whitespace.html: Removed.
  • inspector/editor/text-editor-smart-braces-expected.txt: Removed.
  • inspector/editor/text-editor-smart-braces.html: Removed.
  • inspector/editor/text-editor-token-at-position-expected.txt: Removed.
  • inspector/editor/text-editor-token-at-position.html: Removed.
  • inspector/editor/text-editor-type-over-decoration-expected.txt: Removed.
  • inspector/editor/text-editor-type-over-decoration.html: Removed.
  • inspector/editor/text-editor-undo-redo-expected.txt: Removed.
  • inspector/editor/text-editor-undo-redo.html: Removed.
  • inspector/editor/text-editor-word-jumps-expected.txt: Removed.
  • inspector/editor/text-editor-word-jumps.html: Removed.
  • inspector/elements/breadcrumb-updates-expected.txt: Removed.
  • inspector/elements/breadcrumb-updates.html: Removed.
  • inspector/elements/delete-from-document-expected.txt: Removed.
  • inspector/elements/delete-from-document.html: Removed.
  • inspector/elements/edit-dom-actions-expected.txt: Removed.
  • inspector/elements/edit-dom-actions.html: Removed.
  • inspector/elements/elements-delete-inline-style-expected.txt: Removed.
  • inspector/elements/elements-delete-inline-style.html: Removed.
  • inspector/elements/elements-img-tooltip-expected.txt: Removed.
  • inspector/elements/elements-img-tooltip.html: Removed.
  • inspector/elements/elements-inspect-iframe-from-different-domain-expected.txt: Removed.
  • inspector/elements/elements-inspect-iframe-from-different-domain.html: Removed.
  • inspector/elements/elements-panel-limited-children-expected.txt: Removed.
  • inspector/elements/elements-panel-limited-children.html: Removed.
  • inspector/elements/elements-panel-rewrite-href-expected.txt: Removed.
  • inspector/elements/elements-panel-rewrite-href.html: Removed.
  • inspector/elements/elements-panel-selection-on-refresh-expected.txt: Removed.
  • inspector/elements/elements-panel-selection-on-refresh.html: Removed.
  • inspector/elements/elements-panel-structure-expected.txt: Removed.
  • inspector/elements/elements-panel-structure.html: Removed.
  • inspector/elements/elements-panel-xhtml-structure-expected.txt: Removed.
  • inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Removed.
  • inspector/elements/event-listener-sidebar-expected.txt: Removed.
  • inspector/elements/event-listener-sidebar.html: Removed.
  • inspector/elements/event-listeners-about-blank-expected.txt: Removed.
  • inspector/elements/event-listeners-about-blank.html: Removed.
  • inspector/elements/expand-recursively-expected.txt: Removed.
  • inspector/elements/expand-recursively.html: Removed.
  • inspector/elements/hide-shortcut-expected.txt: Removed.
  • inspector/elements/hide-shortcut.html: Removed.
  • inspector/elements/iframe-load-event-expected.txt: Removed.
  • inspector/elements/iframe-load-event.html: Removed.
  • inspector/elements/insert-node-collapsed-expected.txt: Removed.
  • inspector/elements/insert-node-collapsed.html: Removed.
  • inspector/elements/insert-node-expected.txt: Removed.
  • inspector/elements/insert-node.html: Removed.
  • inspector/elements/modify-chardata-expected.txt: Removed.
  • inspector/elements/modify-chardata.html: Removed.
  • inspector/elements/move-node-expected.txt: Removed.
  • inspector/elements/move-node.html: Removed.
  • inspector/elements/node-xpath-expected.txt: Removed.
  • inspector/elements/node-xpath.xhtml: Removed.
  • inspector/elements/remove-node-expected.txt: Removed.
  • inspector/elements/remove-node.html: Removed.
  • inspector/elements/resources/iframe-load-event-iframe-1.html: Removed.
  • inspector/elements/resources/iframe-load-event-iframe-2.html: Removed.
  • inspector/elements/resources/iframe-load-event-iframe.js: Removed.
  • inspector/elements/resources/user-properties.js: Removed.
  • inspector/elements/set-html-via-resource-expected.txt: Removed.
  • inspector/elements/shadow-dom-modify-chardata-expected.txt: Removed.
  • inspector/elements/shadow-dom-modify-chardata.html: Removed.
  • inspector/elements/shadow-root-expected.txt: Removed.
  • inspector/elements/shadow-root.html: Removed.
  • inspector/elements/undo-dom-edits-2-expected.txt: Removed.
  • inspector/elements/undo-dom-edits-2.html: Removed.
  • inspector/elements/undo-dom-edits-expected.txt: Removed.
  • inspector/elements/undo-dom-edits.html: Removed.
  • inspector/elements/update-shadowdom-expected.txt: Removed.
  • inspector/elements/update-shadowdom.html: Removed.
  • inspector/elements/user-properties-expected.txt: Removed.
  • inspector/elements/user-properties.html: Removed.
  • inspector/evaluate-in-page-expected.txt: Removed.
  • inspector/evaluate-in-page.html: Removed.
  • inspector/extensions/extensions-api-expected.txt: Removed.
  • inspector/extensions/extensions-api.html: Removed.
  • inspector/extensions/extensions-audits-api-expected.txt: Removed.
  • inspector/extensions/extensions-audits-api.html: Removed.
  • inspector/extensions/extensions-audits-content-script-expected.txt: Removed.
  • inspector/extensions/extensions-audits-content-script.html: Removed.
  • inspector/extensions/extensions-audits-expected.txt: Removed.
  • inspector/extensions/extensions-audits-tests.js: Removed.
  • inspector/extensions/extensions-audits.html: Removed.
  • inspector/extensions/extensions-console-expected.txt: Removed.
  • inspector/extensions/extensions-console.html: Removed.
  • inspector/extensions/extensions-eval-content-script-expected.txt: Removed.
  • inspector/extensions/extensions-eval-content-script.html: Removed.
  • inspector/extensions/extensions-eval-expected.txt: Removed.
  • inspector/extensions/extensions-eval.html: Removed.
  • inspector/extensions/extensions-events-expected.txt: Removed.
  • inspector/extensions/extensions-events.html: Removed.
  • inspector/extensions/extensions-network-expected.txt: Removed.
  • inspector/extensions/extensions-network.html: Removed.
  • inspector/extensions/extensions-panel-expected.txt: Removed.
  • inspector/extensions/extensions-panel.html: Removed.
  • inspector/extensions/extensions-reload-expected.txt: Removed.
  • inspector/extensions/extensions-reload.html: Removed.
  • inspector/extensions/extensions-resources-expected.txt: Removed.
  • inspector/extensions/extensions-resources.html: Removed.
  • inspector/extensions/extensions-sidebar-expected.txt: Removed.
  • inspector/extensions/extensions-sidebar.html: Removed.
  • inspector/extensions/resources/abe.png: Removed.
  • inspector/extensions/resources/audits-style1.css: Removed.
  • inspector/extensions/resources/test-script.js: Removed.
  • inspector/file-mapping-expected.txt: Removed.
  • inspector/file-mapping.html: Removed.
  • inspector/file-system-mapping-expected.txt: Removed.
  • inspector/file-system-mapping.html: Removed.
  • inspector/file-system-project-expected.txt: Removed.
  • inspector/file-system-project.html: Removed.
  • inspector/filtered-item-selection-dialog-filtering-expected.txt: Removed.
  • inspector/filtered-item-selection-dialog-filtering.html: Removed.
  • inspector/inspector-backend-commands-generation-expected.txt: Removed.
  • inspector/inspector-backend-commands-generation.html: Removed.
  • inspector/map-expected.txt: Removed.
  • inspector/map.html: Removed.
  • inspector/network-status-non-http-expected.txt: Removed.
  • inspector/network-status-non-http.html: Removed.
  • inspector/profiler/canvas-profiler-test.js: Removed.
  • inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases-expected.txt: Removed.
  • inspector/profiler/canvas2d/canvas-has-uninstrumented-canvases.html: Removed.
  • inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt: Removed.
  • inspector/profiler/canvas2d/canvas-replay-log-grid.html: Removed.
  • inspector/profiler/canvas2d/canvas-stack-trace-expected.txt: Removed.
  • inspector/profiler/canvas2d/canvas-stack-trace.html: Removed.
  • inspector/profiler/canvas2d/canvas2d-api-changes-expected.txt: Removed.
  • inspector/profiler/canvas2d/canvas2d-api-changes.html: Removed.
  • inspector/profiler/canvas2d/canvas2d-gradient-capturing-expected.txt: Removed.
  • inspector/profiler/canvas2d/canvas2d-gradient-capturing.html: Removed.
  • inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics-expected.txt: Removed.
  • inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html: Removed.
  • inspector/profiler/heap-snapshot-comparison-dom-groups-change-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-comparison-dom-groups-change.html: Removed.
  • inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-comparison-show-all.html: Removed.
  • inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-comparison-show-next.html: Removed.
  • inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-comparison-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-containment-show-all.html: Removed.
  • inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-containment-show-next.html: Removed.
  • inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-containment-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-dominators-show-all.html: Removed.
  • inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Removed.
  • inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-dominators-show-next.html: Removed.
  • inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-dominators-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-get-profile-crash-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-get-profile-crash.html: Removed.
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: Removed.
  • inspector/profiler/heap-snapshot-loader-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-loader.html: Removed.
  • inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Removed.
  • inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-summary-retainers-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-retainers.html: Removed.
  • inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-show-all.html: Removed.
  • inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-show-next.html: Removed.
  • inspector/profiler/heap-snapshot-summary-show-ranges-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-show-ranges.html: Removed.
  • inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-sorting-fields-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-sorting-fields.html: Removed.
  • inspector/profiler/heap-snapshot-summary-sorting-instances-expected.txt: Removed.
  • inspector/profiler/heap-snapshot-summary-sorting-instances.html: Removed.
  • inspector/profiler/heap-snapshot-summary-sorting.html: Removed.
  • inspector/profiler/heap-snapshot-test.js: Removed.
  • inspector/profiler/heap-snapshot.html: Removed.
  • inspector/profiler/resources/image.jpeg: Removed.
  • inspector/profiler/selector-profiler-url-expected.txt: Removed.
  • inspector/profiler/selector-profiler-url.html: Removed.
  • inspector/profiler/webgl/webgl-profiler-api-changes-expected.txt: Removed.
  • inspector/profiler/webgl/webgl-profiler-api-changes.html: Removed.
  • inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Removed.
  • inspector/profiler/webgl/webgl-profiler-get-error.html: Removed.
  • inspector/progress-bar-expected.txt: Removed.
  • inspector/progress-bar.html: Removed.
  • inspector/snippet-storage-expected.txt: Removed.
  • inspector/snippet-storage.html: Removed.
  • inspector/styles/commit-selector-expected.txt: Removed.
  • inspector/styles/commit-selector.html: Removed.
  • inspector/styles/css-live-edit-expected.txt: Removed.
  • inspector/styles/css-live-edit.html: Removed.
  • inspector/styles/edit-inspector-stylesheet-expected.txt: Removed.
  • inspector/styles/edit-inspector-stylesheet.html: Removed.
  • inspector/styles/edit-value-with-trimmed-url-expected.txt: Removed.
  • inspector/styles/edit-value-with-trimmed-url.html: Removed.
  • inspector/styles/force-pseudo-state-expected.txt: Removed.
  • inspector/styles/force-pseudo-state.html: Removed.
  • inspector/styles/inactive-properties-expected.txt: Removed.
  • inspector/styles/inactive-properties.html: Removed.
  • inspector/styles/lazy-computed-style-expected.txt: Removed.
  • inspector/styles/lazy-computed-style.html: Removed.
  • inspector/styles/media-emulation-expected.txt: Removed.
  • inspector/styles/media-emulation.html: Removed.
  • inspector/styles/media-queries-expected.txt: Removed.
  • inspector/styles/media-queries.html: Removed.
  • inspector/styles/metrics-box-sizing-expected.txt: Removed.
  • inspector/styles/metrics-box-sizing.html: Removed.
  • inspector/styles/paste-property-expected.txt: Removed.
  • inspector/styles/paste-property.html: Removed.
  • inspector/styles/perform-undo-perform-of-mergable-action-expected.txt: Removed.
  • inspector/styles/perform-undo-perform-of-mergable-action.html: Removed.
  • inspector/styles/protocol-css-regions-commands-expected.txt: Removed.
  • inspector/styles/protocol-css-regions-commands.html: Removed.
  • inspector/styles/selector-line-expected.txt: Removed.
  • inspector/styles/selector-line.html: Removed.
  • inspector/styles/show-user-agent-styles-expected.txt: Removed.
  • inspector/styles/show-user-agent-styles.html: Removed.
  • inspector/styles/styles-add-new-rule-expected.txt: Removed.
  • inspector/styles/styles-add-new-rule.html: Removed.
  • inspector/styles/styles-cancel-editing-expected.txt: Removed.
  • inspector/styles/styles-cancel-editing.html: Removed.
  • inspector/styles/styles-change-node-while-editing-expected.txt: Removed.
  • inspector/styles/styles-change-node-while-editing.html: Removed.
  • inspector/styles/styles-commit-editing-expected.txt: Removed.
  • inspector/styles/styles-commit-editing.html: Removed.
  • inspector/styles/styles-edit-property-after-invalid-rule-expected.txt: Removed.
  • inspector/styles/styles-edit-property-after-invalid-rule.html: Removed.
  • inspector/styles/styles-update-from-js-expected.txt: Removed.
  • inspector/styles/styles-update-from-js.html: Removed.
  • inspector/styles/styles-url-linkify-expected.txt: Removed.
  • inspector/styles/styles-url-linkify.html: Removed.
  • inspector/styles/svg-style-expected.txt: Removed.
  • inspector/styles/svg-style.xhtml: Removed.
  • inspector/styles/up-down-numerics-and-colors-expected.txt: Removed.
  • inspector/styles/up-down-numerics-and-colors.html: Removed.
  • inspector/styles/updates-during-dom-traversal-expected.txt: Removed.
  • inspector/styles/updates-during-dom-traversal.html: Removed.
  • inspector/styles/updates-throttled-expected.txt: Removed.
  • inspector/styles/updates-throttled.html: Removed.
  • inspector/styles/url-color-swatch-expected.txt: Removed.
  • inspector/styles/url-color-swatch.html: Removed.
  • inspector/styles/variables/css-variables-expected.txt: Removed.
  • inspector/styles/variables/css-variables.html: Removed.
  • inspector/styles/vendor-prefixes-expected.txt: Removed.
  • inspector/styles/vendor-prefixes.html: Removed.
  • inspector/syntax-highlight-css-expected.txt: Removed.
  • inspector/syntax-highlight-css.html: Removed.
  • inspector/syntax-highlight-html-expected.txt: Removed.
  • inspector/syntax-highlight-html.html: Removed.
  • inspector/syntax-highlight-javascript-expected.txt: Removed.
  • inspector/syntax-highlight-javascript.html: Removed.
  • inspector/syntax-highlight.js: Removed.
  • inspector/tabbed-editors-history-expected.txt: Removed.
  • inspector/tabbed-editors-history.html: Removed.
  • inspector/tabbed-pane-max-tab-width-calculation-expected.txt: Removed.
  • inspector/tabbed-pane-max-tab-width-calculation.html: Removed.
  • inspector/tabbed-pane-tabs-to-show-expected.txt: Removed.
  • inspector/tabbed-pane-tabs-to-show.html: Removed.
  • inspector/timeline-dfs-expected.txt: Removed.
  • inspector/timeline-dfs.html: Removed.
  • inspector/timeline/timeline-coalescing-expected.txt: Removed.
  • inspector/timeline/timeline-coalescing.html: Removed.
  • inspector/timeline/timeline-enum-stability-expected.txt: Removed.
  • inspector/timeline/timeline-enum-stability.html: Removed.
  • inspector/uisourcecode-revisions-expected.txt: Removed.
  • inspector/uisourcecode-revisions.html: Removed.
  • inspector/user-metrics-expected.txt: Removed.
  • inspector/user-metrics.html: Removed.
  • inspector/utilities-highlight-results-expected.txt: Removed.
  • inspector/utilities-highlight-results.html: Removed.
  • inspector/version-controller-expected.txt: Removed.
  • inspector/version-controller.html: Removed.
  • inspector/view-css-expected.txt: Removed.
  • inspector/view-css.html: Removed.
  • inspector/view-events-expected.txt: Removed.
  • inspector/view-events.html: Removed.
  • inspector/workspace-mapping-expected.txt: Removed.
  • inspector/workspace-mapping.html: Removed.
4:13 PM Changeset in webkit [164514] by jer.noble@apple.com
  • 14 edits
    3 copies
    1 move
    1 add
    1 delete in trunk/Source/WebCore

Make a generic CDMPrivateMediaPlayer and move its CDMSession into platform/.
https://bugs.webkit.org/show_bug.cgi?id=129164

Reviewed by Eric Carlson.

Move the session created by CDMPrivateAVFoundation into platform, and rename
CDMPrivateAVFoundation to CDMPrivateMediaPlayer. Future media engines who want
to support a keysystem from within the media engine can create their own
CDMSession as part of the MediaPlayerPrivate interface.

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::installedCDMFactories):
(WebCore::CDM::createSession):

  • Modules/encryptedmedia/CDM.h:
  • Modules/encryptedmedia/CDMPrivate.h:
  • Modules/encryptedmedia/MediaKeySession.cpp:
  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/CDMPrivateAVFoundation.mm: Removed.
  • Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.cpp.

(WebCore::CDMPrivateMediaPlayer::supportsKeySystem):
(WebCore::CDMPrivateMediaPlayer::supportsKeySystemAndMimeType):
(WebCore::CDMPrivateMediaPlayer::supportsMIMEType):
(WebCore::CDMPrivateMediaPlayer::createSession):

  • Modules/encryptedmedia/CDMPrivateMediaPlayer.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.h.

(WebCore::CDMPrivateMediaPlayer::create):
(WebCore::CDMPrivateMediaPlayer::~CDMPrivateMediaPlayer):
(WebCore::CDMPrivateMediaPlayer::cdm):
(WebCore::CDMPrivateMediaPlayer::CDMPrivateMediaPlayer):

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/CDMSession.h: Extracted from CDMPrivateAVFoundation.h.

(WebCore::CDMSessionClient::~CDMSessionClient):
(WebCore::CDMSession::CDMSession):
(WebCore::CDMSession::~CDMSession):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::createSession):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::createSession):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.h.

(WebCore::CDMSessionAVFoundationObjC::~CDMSessionAVFoundationObjC):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateAVFoundation.mm.

(WebCore::CDMSessionAVFoundationObjC::CDMSessionAVFoundationObjC):
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
(WebCore::CDMSessionAVFoundationObjC::releaseKeys):
(WebCore::CDMSessionAVFoundationObjC::update):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createSession):

  • testing/MockCDM.cpp:

(WebCore::MockCDMSession::setClient):
(WebCore::MockCDM::createSession):

  • testing/MockCDM.h:
4:12 PM Changeset in webkit [164513] by jer.noble@apple.com
  • 13 edits in trunk/Source/WebCore

Add a supportsKeySystem media engine factory parameter.
https://bugs.webkit.org/show_bug.cgi?id=129161

Reviewed by Eric Carlson.

Add a new parameter to the MediaPlayerFactory to allow registered media
engines to be queried for keySystem support:

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayerFactory::MediaPlayerFactory):
(WebCore::MediaPlayer::supportsKeySystem):

  • platform/graphics/MediaPlayer.h:

Support this new field in MediaPlayerPrivateAVFoundationObjC:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

Add an empty field for SupportsKeySystem to the remaining media engines:

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::registerMediaEngine):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::registerMediaEngine):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::registerMediaEngine):

  • platform/graphics/ios/MediaPlayerPrivateIOS.mm:

(WebCore::MediaPlayerPrivateIOS::registerMediaEngine):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::registerMediaEngine):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):

4:10 PM Changeset in webkit [164512] by commit-queue@webkit.org
  • 8 edits
    1 delete in trunk

Web Inspector: Replace binarySearch with lowerBound and upperBound functions
https://bugs.webkit.org/show_bug.cgi?id=118609

Patch by Chi Wai Lau <clau@apple.com> on 2014-02-21
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

This makes insertionIndexForObjectInListSortedByFunction work in O(log(n)) time instead of O(n).

  • UserInterface/BinarySearch.js: Removed.
  • UserInterface/Main.html:
  • UserInterface/Utilities.js:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

LayoutTests:

  • inspector/utilities-expected.txt:
  • inspector/utilities.html:
4:05 PM Changeset in webkit [164511] by dbates@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

[Win] fast/table/col-and-colgroup-offsets.html - offsetHeight differs from Mac results
https://bugs.webkit.org/show_bug.cgi?id=129179

The test col-and-colgroup-offsets.html is failing on the Apple Win Debug (Tests) bot due
to platform-specific numeric differences in the computed offsetHeight of the table cells.
For now, I am landing Windows-specific expected results as the behavior tested by the test
is correct despite the numerical differences. I'll further investigate the Window-specific
difference in <https://bugs.webkit.org/show_bug.cgi?id=129179>.

  • platform/win/fast/table/col-and-colgroup-offsets-expected.txt: Added.
4:01 PM Changeset in webkit [164510] by Brian Burg
  • 11 edits
    1 delete in trunk

Web Inspector: animate breakpoint tree elements when probe samples are received
https://bugs.webkit.org/show_bug.cgi?id=128334

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/BreakpointIcons.css: Removed, rules migrated to the following file.
  • UserInterface/BreakpointTreeElement.css: When we want to animateon top of the

static icon, we set the icon image as the icon element's background, and animate
a span on top of the icon element.

(.breakpoint-exception-icon .icon): Moved.
(.breakpoint-generic-line-icon .icon):
(.breakpoint-generic-line-icon .icon > span): Added.
(.data-updated.breakpoint-generic-line-icon .icon > span): Added.

  • UserInterface/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement): Rewrite event listener add/remove to use EventListenerSet.
(WebInspector.BreakpointTreeElement.prototype.ondetach): Override to unregister the instance's listeners.
(WebInspector.BreakpointTreeElement.prototype._addProbeSet): Added.
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet): Added.
(WebInspector.BreakpointTreeElement.prototype._probeSetAdded): Added.
(WebInspector.BreakpointTreeElement.prototype._probeSetRemoved): Added.
Add/remove listeners when probe sets change.

(WebInspector.BreakpointTreeElement.prototype._samplesCleared): Listeners should follow
the active data table.

(WebInspector.BreakpointTreeElement.prototype._dataUpdated): Run the animation when probe data changes.
(WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange): Fix a listener leak.

  • UserInterface/Main.html: Remove BreakpointIcons.css.
  • UserInterface/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline .item .icon): give icons
'position: relative' so child spans can be absolutely positioned.

  • UserInterface/ProbeDetailsSidebarPanel.js: Get probeSet out of the event data

container. The probe set used to be passed as the data container itself.
(WebInspector.ProbeDetailsSidebarPanel.prototype._probeSetAdded):

  • UserInterface/ProbeManager.js:

(WebInspector.ProbeManager.prototype._breakpointActionsChanged.set get knownProbeIdentifiers):
(WebInspector.ProbeManager.prototype._breakpointActionsChanged):
(WebInspector.ProbeManager.prototype.get _probeSetForBreakpoint.set this):

  • UserInterface/ProbeSet.js:

(WebInspector.ProbeSet.prototype.clearSamples): include the old data table as the SamplesCleared event data.

  • UserInterface/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype._probeSetsChanged):

LayoutTests:

Adjust probe manager tracing listeners to access the correct data container property.

  • inspector-protocol/resources/probe-helper.js:

(ProbeHelper.installTracingListeners):

3:44 PM Changeset in webkit [164509] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix WebCore's internals after r164505

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-21

  • testing/Internals.cpp:

(WebCore::Internals::findEditingDeleteButton): The call became ambiguous after r164505.

3:38 PM Changeset in webkit [164508] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit2

[iOS][WK2] Update the visible content rects on zoom
https://bugs.webkit.org/show_bug.cgi?id=129174

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-21
Reviewed by Simon Fraser.

Generalize _updateVisibleContentRects to also act during the zoom and not only at the end.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewDidZoom:]):

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView scrollViewDidZoom:]):

3:35 PM Changeset in webkit [164507] by Joseph Pecoraro
  • 25 edits in trunk/Source

Web Inspector: JSContext inspection should report exceptions in the console
https://bugs.webkit.org/show_bug.cgi?id=128776

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

When JavaScript API functions have an exception, let the inspector
know so it can log the JavaScript and Native backtrace that caused
the exception.

Include some clean up of ConsoleMessage and ScriptCallStack construction.

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

  • API/JSValue.mm:

(reportExceptionToInspector):
(valueToArray):
(valueToDictionary):

  • API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
When seeing an exception, let the inspector know there was an exception.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
(Inspector::JSGlobalObjectInspectorController::reportAPIException):
Log API exceptions by also grabbing the native backtrace.

  • inspector/ScriptCallStack.h:
  • inspector/ScriptCallStack.cpp:

(Inspector::ScriptCallStack::firstNonNativeCallFrame):
(Inspector::ScriptCallStack::append):
Minor extensions to ScriptCallStack to make it easier to work with.

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):
Provide better default information if the first call frame was native.

  • inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::extractSourceInformationFromException):
(Inspector::createScriptCallStackFromException):
Perform the handling here of inserting a fake call frame for exceptions
if there was no call stack (e.g. a SyntaxError) or if the first call
frame had no information.

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):

  • inspector/ConsoleMessage.h:
  • inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):

  • inspector/ScriptCallStackFactory.h:
  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):

  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):
ConsoleMessage cleanup.

Source/WebCore:

Include some clean up of ConsoleMessage and ScriptCallStack construction.

Covered by existing tests.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Simplify code now that createStackTraceFromException handles it.

  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
ScriptCallStack can give us the first non-native callframe.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

  • page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):

  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

  • UserInterface/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.ConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
Provide better handling for "[native code]" and legacy "undefined"
call frame URLs. Never linkify these. Also, when showing a link
for an exception, always use the first non-native call frame as
the link location.

3:30 PM Changeset in webkit [164506] by dfarler@apple.com
  • 4 edits in trunk/Tools

Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=128622

Reviewed by Simon Fraser.

With this change, we now have layout tests running in both DumpRenderTree
and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
simulator.

  • Scripts/old-run-webkit-tests:

In general, make any specific reference to DumpRenderTree
able to refer to WebKitTestRunner wherever possible:

  • Rename functions to remove DRT-specific naming.
  • Name FIFOs after the tool that is being used.

-- Clean up FIFO creation code
Other necessary changes:

  • Allow use of an ios-sim-wk2 platform.
  • Clean up platform hierarchy creation where the simulator platform behavior differed.
  • WebKitTestRunner/TestController.cpp:

Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
(WTR::TestController::TestController):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

Copy the injected bundle into the app bundle.

2:47 PM Changeset in webkit [164505] by benjamin@webkit.org
  • 18 edits in trunk/Source

jsDocumentPrototypeFunctionGetElementById should not create an AtomicString for the function argument
https://bugs.webkit.org/show_bug.cgi?id=128893

Reviewed by Darin Adler.

Source/WebCore:

The declaration of TreeScope::getElementById() was taking an AtomicString as the parameter.
Because of this, all the call sites manipulating String were creating and keeping alive an AtomicString
to make the call.

This had two negative consequences:
-The call sites were ref-ing the ID's atomic string for no reason.
-When there is no ID associated with the input string, an atomic string was created for the sole

purpose of failing the query. Since IDs are stored as AtomicString, if there is not an existing
AtomicString for the input, there is no reason to query anything.

  • WebCore.exp.in:
  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString): Update this after the rename.

  • bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:

Now that there are two overloads for TreeScope::getElementById(), the conversion from NSString*
is ambiguous. I add the keyword ObjCExplicitAtomicString to force an explicit conversion to AtomicString.

  • dom/Document.idl:
  • dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById):
When getting an AtomicString, the case of a empty string is not important, use isNull() instead.
When getting a String, get the corresponding AtomicString if any and use that for getting the element.

  • dom/TreeScope.h:
  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
Solve the ambiguous call.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):
This is a wonderful candidate for substringSharingImpl. The substring does not survive the call since
the new getElementById never create any AtomicString.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):
It looks like there are opportunities to get faster here, Ryosuke should have a look.

  • svg/SVGSVGElement.h:
  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):
Unrelated cleanup: noStyleMessage was useless.

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::pageNumberForElementById): Remove the explicit conversion to use the right overload.

Source/WTF:

AtomicString::find() is a special case optimized for the JavaScript bindings. The method can only
be called under specific conditions.
The method is renamed to findStringWithHash().

The new AtomicString::find is generic and does not require any propery on the input.

  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::findStringWithHash):
(WTF::AtomicString::findSlowCase):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::find):

2:38 PM Changeset in webkit [164504] by dbates@webkit.org
  • 6 edits
    2 adds in trunk

COL element in table has 0 for offsetWidth
https://bugs.webkit.org/show_bug.cgi?id=15277

Reviewed by David Hyatt.

Source/WebCore:

Implements offset{Left, Top, Width, Height} for table columns and column groups
per section Extensions to the HTMLElement Interface of the CSSOM View spec,
<http://www.w3.org/TR/cssom-view/#extensions-to-the-htmlelement-interface> (Draft 17 December 2013).

For now, we fail almost all of the offset{Height, Top} sub-tests in the included test
for the separate border model as we need to fix <https://bugs.webkit.org/show_bug.cgi?id=128988>.

Test: fast/table/col-and-colgroup-offsets.html

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable): Initialize cached column offset top and offset height.
We cache these offsets since they are the same for all columns in the table.
(WebCore::RenderTable::invalidateCachedColumns): Clear cached effective column index map.
(WebCore::RenderTable::invalidateCachedColumnOffsets): Added.
(WebCore::RenderTable::layout): Invalidate cached column offsets as the location or height
of one or more sections may have changed.
(WebCore::RenderTable::updateColumnCache): Modified to build effective column index map.
(WebCore::RenderTable::effectiveIndexOfColumn): Added.
(WebCore::RenderTable::offsetTopForColumn): Added.
(WebCore::RenderTable::offsetLeftForColumn): Added.
(WebCore::RenderTable::offsetWidthForColumn): Added.
(WebCore::RenderTable::offsetHeightForColumn): Added.

  • rendering/RenderTable.h: Make isTableColumnGroupWithColumnChildren() const.
  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::offsetLeft): Added; turns around and calls RenderTable::offsetLeftForColumn().
(WebCore::RenderTableCol::offsetTop): Added; turns around and calls RenderTable::offsetTopForColumn().
(WebCore::RenderTableCol::offsetWidth): Added; turns around and calls RenderTable::offsetWidthForColumn().
(WebCore::RenderTableCol::offsetHeight): Added; turns around and calls RenderTable::offsetHeightForColumn().

  • rendering/RenderTableCol.h:

LayoutTests:

Added test to ensure that offset{Left, Top, Width, Height} return correct results
for table columns and column groups.

For now, we fail almost all of the offset{Height, Top} sub-tests for the separate
border model as we need to fix <https://bugs.webkit.org/show_bug.cgi?id=128988>.

  • fast/table/col-and-colgroup-offsets-expected.txt: Added.
  • fast/table/col-and-colgroup-offsets.html: Added.
2:37 PM Changeset in webkit [164503] by oliver@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Add extra space to op_call and related opcodes
https://bugs.webkit.org/show_bug.cgi?id=129170

Reviewed by Mark Lam.

No change in behaviour, just some refactoring to add an extra
slot to the op_call instructions, and refactoring to make similar
changes easier in future.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
2:34 PM Changeset in webkit [164502] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for iOS after r164498.

Unreviewed.

  • platform/graphics/ios/MediaPlayerPrivateIOS.mm:

(WebCore::MediaPlayerPrivateIOS::buffered):

2:33 PM Changeset in webkit [164501] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Disallow the use of -webkit-user-modify on shadow pseudo elements
https://bugs.webkit.org/show_bug.cgi?id=129144

Reviewed by Geoffrey Garen.

Completely disallow -webkit-user-modify on user agent (builtin) pseudo elements.

We've already had rules to do this in html.css but just hard code it into the engine
in order to eliminate the all uses of -webkit-user-modify in html.css.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/html.css:

(input::-webkit-textfield-decoration-container):
(input::-webkit-clear-button):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
(input[type="file"]::-webkit-file-upload-button):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
(input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):
(::-webkit-validation-bubble-heading):
(::-webkit-validation-bubble-arrow):
(::-webkit-validation-bubble-arrow-clipper):
(meter::-webkit-meter-inner-element):
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
(progress::-webkit-progress-inner-element):
(progress::-webkit-progress-bar):
(progress::-webkit-progress-value):

2:27 PM Changeset in webkit [164500] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

gatherFromOtherThread() needs to align the sp before gathering roots.
<https://webkit.org/b/129169>

Reviewed by Geoffrey Garen.

The GC scans the stacks of other threads using MachineThreads::gatherFromOtherThread().
gatherFromOtherThread() defines the range of the other thread's stack as
being bounded by the other thread's stack pointer and stack base. While
the stack base will always be aligned to sizeof(void*), the stack pointer
may not be. This is because the other thread may have just pushed a 32-bit
value on its stack before we suspended it for scanning.

The fix is to round the stack pointer up to the next aligned address of
sizeof(void*) and start scanning from there. On 64-bit systems, we will
effectively ignore the 32-bit word at the bottom of the stack (top of the
stack for stacks growing up) because it cannot be a 64-bit pointer anyway.
64-bit pointers should always be stored on 64-bit aligned boundaries (our
conservative scan algorithm already depends on this assumption).

On 32-bit systems, the rounding is effectively a no-op.

  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddSpan):

  • Hardened somne assertions so that we can catch misalignment issues on release builds as well.
  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::gatherFromOtherThread):

2:26 PM Changeset in webkit [164499] by Joseph Pecoraro
  • 2 edits in trunk/Tools

run-webkit-httpd fails to find httpd configuation file.

Reviewed by Ryosuke Niwa.

  • Scripts/webkitperl/httpd.pm:

(getHTTPDConfigPathForTestDirectory):

2:04 PM Changeset in webkit [164498] by eric.carlson@apple.com
  • 41 edits
    2 adds in trunk

Fix TimeRanges layering violations
https://bugs.webkit.org/show_bug.cgi?id=128717

Reviewed by NOBODY (OOPS!).

Source/WebCore:

No new tests, no functionality changed.

  • CMakeLists.txt:
  • GNUmakefile.list.am: Add PlatformTimeRanges.
  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::buffered): TimeRanges -> PlatformTimeRanges.

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): TimeRanges* -> TimeRanges&.

  • WebCore.exp.in: Update for signature changes.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj: Add PlatformTimeRanges.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::percentLoaded): Create TimeRanges from PlatformTimeRanges.
(WebCore::HTMLMediaElement::buffered): Ditto.
(WebCore::HTMLMediaElement::seekable): Ditto.

  • html/MediaController.cpp:

(MediaController::buffered): TimeRanges* -> TimeRanges&.
(MediaController::seekable): Ditto.
(MediaController::played): Ditto.

Move all of the logic into PlatformTimeRanges. Change API to take TimeRanges& instead of TimeRanges*.

  • html/TimeRanges.cpp:

(WebCore::TimeRanges::create): Move to .cpp from .h.
(WebCore::TimeRanges::TimeRanges): Initialize the PlatformTimeRanges member variable.
(WebCore::TimeRanges::start): Passthrough to PlatformTimeRanges.
(WebCore::TimeRanges::end): Ditto.
(WebCore::TimeRanges::invert): Ditto.
(WebCore::TimeRanges::copy): Ditto.
(WebCore::TimeRanges::intersectWith): Ditto.
(WebCore::TimeRanges::unionWith): Ditto.
(WebCore::TimeRanges::length): Ditto.
(WebCore::TimeRanges::add): Ditto.
(WebCore::TimeRanges::contain): Ditto.
(WebCore::TimeRanges::find): Ditto.
(WebCore::TimeRanges::nearest): Ditto.
(WebCore::TimeRanges::totalDuration): Ditto.

  • html/TimeRanges.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::buffered): TimeRanges -> PlatformTimeRanges.
(WebCore::MediaPlayer::buffered): Ditto.
(WebCore::MediaPlayer::seekable): Ditto.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/MediaSourcePrivateClient.h:
  • platform/graphics/PlatformTimeRanges.cpp: Added.
  • platform/graphics/PlatformTimeRanges.h: Added.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::buffered): TimeRanges -> PlatformTimeRanges.
(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Drive-by fix to log

FunctionType notifications. ASSERT when passed an unknown notification.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges): TimeRanges -> PlatformTimeRanges.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekable): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered): Ditto.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered): Ditto.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/ios/MediaPlayerPrivateIOS.h:
  • platform/graphics/ios/MediaPlayerPrivateIOS.mm:

(WebCore::MediaPlayerPrivateIOS::buffered): Ditto.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::buffered): Ditto.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::buffered): Ditto.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
  • platform/graphics/wince/MediaPlayerPrivateWinCE.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::buffered): Ditto.
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime): Ditto.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: TimeRanges::create(void) for Internals.

Tools:

  • TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.

(TestWebKitAPI::TEST):

1:56 PM Changeset in webkit [164497] by enrica@apple.com
  • 18 edits in trunk/Source

Support WebSelections in WK2 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=127015
<rdar://problem/15211964>

Reviewed by Benjamin Poulain.

../WebCore:

Adding some exports.

  • WebCore.exp.in:

../WebKit2:

This is the remaining work on block selections for iOS in WK2.
Once a block selection has been created with a long press gesture
on a selectable area, we can interact with it by touching the four
handles at the top, right, bottom and left side of the selection box.
Expanding or shrinking a block selection requires finding the next/previous
block in the direction of the movement, depending on the handle we
are interacting with.
Every time a new block is selected, we compute the thresholds required
to trigger another block change. The thresholds are sent back to the
UIProcess that will use this information to decide when to activate
the new selection, either bigger or smaller.
This patch also fixes a bug in selectWithTwoTouches where the points
were not mapped to the active frame.

  • Shared/ios/WKGestureTypes.h:
  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didUpdateBlockSelectionWithTouches):

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _didUpdateBlockSelectionWithTouches:withFlags:growThreshold:shrinkThreshold:]):

  • UIProcess/API/ios/WKContentViewInternal.h:
  • UIProcess/API/ios/WKInteractionView.h:
  • UIProcess/API/ios/WKInteractionView.mm:

(-[WKInteractionView hasSelectablePositionAtPoint:]):
(-[WKInteractionView clearSelection]):
(toWKHandlePosition):
(-[WKInteractionView _didUpdateBlockSelectionWithTouches:WebKit::withFlags:WebKit::growThreshold:shrinkThreshold:]):
(-[WKInteractionView changeBlockSelectionWithTouchAt:withSelectionTouch:forHandle:]):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateBlockSelectionWithTouches):
(WebKit::WebPageProxy::didUpdateBlockSelectionWithTouches):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::rangeForBlockAtPoint):
(WebKit::WebPage::selectWithGesture):
(WebKit::distanceBetweenRectsForPosition):
(WebKit::rectsEssentiallyTheSame):
(WebKit::containsRange):
(WebKit::unionDOMRanges):
(WebKit::computeEdgeCenter):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):
(WebKit::shouldExpand):
(WebKit::WebPage::changeBlockSelection):
(WebKit::WebPage::updateBlockSelectionWithTouches):
(WebKit::WebPage::clearSelection):
(WebKit::WebPage::selectWithTwoTouches):
(WebKit::WebPage::getPositionInformation):

1:52 PM Changeset in webkit [164496] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Added a GetMyArgumentsLengthSafe and added a speculation check.
https://bugs.webkit.org/show_bug.cgi?id=129051

Patch by Matthew Mirman <mmirman@apple.com> on 2014-02-21
Reviewed by Filip Pizlo.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):

1:29 PM Changeset in webkit [164495] by benjamin@webkit.org
  • 9 edits in trunk

'mouseenter' mouse compat event not fired when listeners for touch events
https://bugs.webkit.org/show_bug.cgi?id=128534

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-21
Reviewed by Andreas Kling.

Source/WebCore:

The code dispatching mouseenter and mouseleave events was making the assumption that
only mouse move would cause Document::updateHoverActiveState.

This is not true in some cases. In the case of this bug, the first touch handler sets
the hover state. From there, the code handling enter/leave is in an inconsistent state.

This patch changes the delivery of mouse enter/leave events to be done through the regular
processing of mouse events. The update is done with the mouseover and mouseout events.

  • dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):
(WebCore::Document::updateHoverActiveState):

  • dom/Document.h:
  • page/EventHandler.cpp:

(WebCore::nearestCommonHoverAncestor):
(WebCore::hierarchyHasCapturingEventListeners):
(WebCore::EventHandler::updateMouseEventTargetNode):

LayoutTests:

The existing tests for mouseenter/mouseleave had very poor readability which made them
useless for debugging.
This updates them to log what cause the events, and log all the events everywhere on the page.

  • fast/events/mouseenter-mouseleave-capture-expected.txt:
  • fast/events/mouseenter-mouseleave-capture.html:
  • fast/events/mouseenter-mouseleave-expected.txt:
  • fast/events/mouseenter-mouseleave.html:
1:26 PM Changeset in webkit [164494] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win][LLINT] Many JSC stress test failures.
https://bugs.webkit.org/show_bug.cgi?id=129155

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-02-21
Reviewed by Michael Saboff.

Intel syntax has reversed operand order compared to AT&T syntax, so we need to swap the operand order, in this case on floating point operations.
Also avoid using the reverse opcode (e.g. fdivr), as this puts the result at the wrong position in the floating point stack.
E.g. "divd ft0, ft1" would translate to fdivr st, st(1) (Intel syntax) on Windows, but this puts the result in st, when it should be in st(1).

  • offlineasm/x86.rb: Swap operand order on Windows.
12:37 PM Changeset in webkit [164493] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DFG write barriers should do more speculations
https://bugs.webkit.org/show_bug.cgi?id=129160

Reviewed by Mark Hahnenberg.

Replace ConditionalStoreBarrier with the cheapest speculation that you could do
instead.

Miniscule speed-up on some things. It's a decent difference in code size, though.

  • bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):

  • bytecode/SpeculatedType.h:

(JSC::isNotCellSpeculation):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):
(JSC::DFG::FixupPhase::insertPhantomCheck):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateOther):
(JSC::DFG::Node::shouldSpeculateNotCell):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compareEqObjectOrOtherToObject):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::isNotOther):
(JSC::FTL::LowerDFGToLLVM::isOther):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
(JSC::FTL::LowerDFGToLLVM::speculateOther):
(JSC::FTL::LowerDFGToLLVM::speculateNotCell):

12:37 PM Changeset in webkit [164492] by jhoneycutt@apple.com
  • 3 edits
    2 adds in trunk

Crash reloading page with position: fixed content
https://bugs.webkit.org/show_bug.cgi?id=129119
<rdar://problem/16127090>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::removeDestroyedNodes):
Check the node's ID against the latched node's ID before the node is
removed from the tree.

LayoutTests:

  • platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html: Added.
12:18 PM Changeset in webkit [164491] by Joseph Pecoraro
  • 25 edits in trunk/Source

Revert r164486, causing a number of test failures.

Source/JavaScriptCore:

Unreviewed rollout.

Source/WebCore:

Unreviewed rollout.

Source/WebInspectorUI:

Unreviewed rollout.

11:51 AM WebInspectorTests created by Brian Burg
explain how inspector protocol tests work
11:48 AM Changeset in webkit [164490] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Revive SABI (aka shouldAlwaysBeInlined)
https://bugs.webkit.org/show_bug.cgi?id=129159

Reviewed by Mark Hahnenberg.

This is a small Octane speed-up.

  • jit/Repatch.cpp:

(JSC::linkFor): This code was assuming that if it's invoked then the caller is a DFG code block. That's wrong, since it's now used by all of the JITs.

11:38 AM Changeset in webkit [164489] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

StyleResolver::loadPendingImage() should take a reference to StylePendingImage
<http://webkit.org/b/129021>

Reviewed by Brent Fulgham.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImage): Change pendingImage
parameter to a reference.
(WebCore::StyleResolver::loadPendingShapeImage): Update to use
references.
(WebCore::StyleResolver::loadPendingImages): Ditto.

  • css/StyleResolver.h:

(WebCore::StyleResolver::loadPendingImage): Change pendingImage
parameter to a reference.

11:28 AM Changeset in webkit [164488] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Make sure to invoke the completion handler for JS alerts
https://bugs.webkit.org/show_bug.cgi?id=129158

Reviewed by Alexey Proskuryakov.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

11:17 AM Changeset in webkit [164487] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
https://bugs.webkit.org/show_bug.cgi?id=128422

Patch by Diego Pino García <Diego Pino Garcia> on 2014-02-21
Reviewed by Joseph Pecoraro.

  • Scripts/webkitpy/style/checkers/js.py:

(JSChecker.init):
(JSChecker.check):
(SingleQuoteChecker):
(SingleQuoteChecker.init):
(SingleQuoteChecker.check):

  • Scripts/webkitpy/style/checkers/js_unittest.py:

(JSTestCase.assertError.error_for_test):
(JSTestCase.assertError):
(JSTestCase.test_no_error):
(JSTestCase.test_error):

11:14 AM Changeset in webkit [164486] by Joseph Pecoraro
  • 25 edits in trunk/Source

Web Inspector: JSContext inspection should report exceptions in the console
https://bugs.webkit.org/show_bug.cgi?id=128776

Source/JavaScriptCore:

Reviewed by Timothy Hatcher.

When JavaScript API functions have an exception, let the inspector
know so it can log the JavaScript and Native backtrace that caused
the exception.

Include some clean up of ConsoleMessage and ScriptCallStack construction.

  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):

  • API/JSValue.mm:

(reportExceptionToInspector):
(valueToArray):
(valueToDictionary):

  • API/JSValueRef.cpp:

(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
When seeing an exception, let the inspector know there was an exception.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
(Inspector::JSGlobalObjectInspectorController::reportAPIException):
Log API exceptions by also grabbing the native backtrace.

  • inspector/ScriptCallStack.h:
  • inspector/ScriptCallStack.cpp:

(Inspector::ScriptCallStack::firstNonNativeCallFrame):
(Inspector::ScriptCallStack::append):
Minor extensions to ScriptCallStack to make it easier to work with.

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):
Provide better default information if the first call frame was native.

  • inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::extractSourceInformationFromException):
(Inspector::createScriptCallStackFromException):
Perform the handling here of inserting a fake call frame for exceptions
if there was no call stack (e.g. a SyntaxError) or if the first call
frame had no information.

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage):
(Inspector::ConsoleMessage::autogenerateMetadata):

  • inspector/ConsoleMessage.h:
  • inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):

  • inspector/ScriptCallStackFactory.h:
  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::enable):
(Inspector::InspectorConsoleAgent::addMessageToConsole):
(Inspector::InspectorConsoleAgent::count):

  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::breakpointActionLog):
ConsoleMessage cleanup.

Source/WebCore:

Include some clean up of ConsoleMessage and ScriptCallStack construction.

Covered by existing tests.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Simplify code now that createStackTraceFromException handles it.

  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):
ScriptCallStack can give us the first non-native callframe.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::buildInitiatorObject):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::breakpointActionLog):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):

  • page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):

  • page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):

Source/WebInspectorUI:

Reviewed by Timothy Hatcher.

  • UserInterface/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._shouldHideURL):
(WebInspector.ConsoleMessageImpl.prototype._firstNonNativeCallFrame):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
Provide better handling for "[native code]" and legacy "undefined"
call frame URLs. Never linkify these. Also, when showing a link
for an exception, always use the first non-native call frame as
the link location.

11:12 AM WikiStart edited by Brian Burg
add web inspector tests link (diff)
8:51 AM Changeset in webkit [164485] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Fixing the !ENABLE(SVG_FONTS) build
https://bugs.webkit.org/show_bug.cgi?id=129150

Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-02-21
Reviewed by Anders Carlsson.

No new tests required.

  • svg/SVGAltGlyphElement.cpp:
  • svg/SVGAltGlyphElement.h:
  • svg/svgtags.in:
8:45 AM Changeset in webkit [164484] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Modernize JSGlobalLock and JSLockHolder
https://bugs.webkit.org/show_bug.cgi?id=129105

Reviewed by Michael Saboff.

Use std::mutex and std::thread::id where possible.

  • runtime/JSLock.cpp:

(JSC::GlobalJSLock::GlobalJSLock):
(JSC::GlobalJSLock::~GlobalJSLock):
(JSC::GlobalJSLock::initialize):
(JSC::JSLock::JSLock):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):

  • runtime/JSLock.h:
7:53 AM Changeset in webkit [164483] by graouts@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: scrollbar may appear when selecting a stop in gradient editor
https://bugs.webkit.org/show_bug.cgi?id=129149

Reviewed by Timothy Hatcher.

Ensure the angle input is not focused as we update the size of the gradient editor's
popover content since, if it were, it'd make a scrollbar appear as we animate the
popover's frame to fit its new content.

  • UserInterface/CodeMirrorGradientEditingController.js:

(WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):

7:29 AM Changeset in webkit [164482] by stavila@adobe.com
  • 23 edits in trunk/Source/WebCore

[CSS Regions] Use the named-flow-specific object RenderNamedFlowFragment instead of the generic RenderRegion whenever possible
https://bugs.webkit.org/show_bug.cgi?id=128599

Reviewed by Andrei Bucur.

Use the named flow specific RenderNamedFlowFragment instead of the generic RenderRegion, whenever possible.
Move named flow specific methods from RenderRegion to RenderNamedFlowFragment.

No new tests required.

  • dom/Element.cpp:

(WebCore::Element::renderNamedFlowFragment):
(WebCore::Element::webkitRegionOverset):
(WebCore::Element::webkitGetRegionFlowRanges):

  • dom/Element.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForRegions):

  • rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::getRanges):

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::updateWritingMode):
(WebCore::compareRenderNamedFlowFragments):
(WebCore::addFragmentToList):
(WebCore::RenderNamedFlowThread::addFragmentToNamedFlowThread):
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::removeRegionFromThread):
(WebCore::RenderNamedFlowThread::computeOversetStateForRegions):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
(WebCore::RenderNamedFlowThread::getRanges):
(WebCore::RenderNamedFlowThread::checkRegionsWithStyling):
(WebCore::RenderNamedFlowThread::clearRenderObjectCustomStyle):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderReplica.cpp:

(WebCore::RenderReplica::paint):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

3:26 AM Changeset in webkit [164481] by abucur@adobe.com
  • 4 edits
    14 adds in trunk

[CSS Regions] Regions don't paint correctly in new-multicol elements
https://bugs.webkit.org/show_bug.cgi?id=120711

Reviewed by David Hyatt.

Source/WebCore:

This patch implements basic support for regions inside multi-column elements.
Currently, the painting and hit-testing logic of CSS Regions is not aware of
enclosing multi-column elements. The change is integrated at a layer level by
making use of the pre-computed layer fragments during the painting and hit-testing
phases for regions.

There are limitations such that self painting layers found inside the named flow
thread layer will not be correctly processed because they don't go through the
layer fragment collection step. This is not trivial to implement because the enclosing
pagination layer provided by the multi-column element is not visibile from inside
the named flow thread layer and they reside in different coordinate systems.

A side effect of this patch is the fix of regions incorrect clipping in certain
cases (when both a region and its container clip their overflow, the region's
content is visible outside the container).

Tests: fast/regions/region-clipping.html

fast/regions/regions-in-multicol-bt.html
fast/regions/regions-in-multicol-hover-overflow.html
fast/regions/regions-in-multicol-hover.html
fast/regions/regions-in-multicol-lr.html
fast/regions/regions-in-multicol-rl.html
fast/regions/regions-in-multicol.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::paintFlowThreadIfRegionForFragments):
(WebCore::RenderLayer::hitTestFlowThreadIfRegionForFragments):

  • rendering/RenderLayer.h:

LayoutTests:

Add tests for regions in multi-column elements and a test that verifies
regions are correctly clipped by their containers when both have hidden
overflow.
For the non horizontal-tb writing modes tests there's no overflow after the
last region because it's not rendered correctly yet in a new column.

  • fast/regions/region-clipping-expected.html: Added.
  • fast/regions/region-clipping.html: Added.
  • fast/regions/regions-in-multicol-bt-expected.html: Added.
  • fast/regions/regions-in-multicol-bt.html: Added.
  • fast/regions/regions-in-multicol-expected.html: Added.
  • fast/regions/regions-in-multicol-hover-expected.html: Added.
  • fast/regions/regions-in-multicol-hover-overflow-expected.html: Added.
  • fast/regions/regions-in-multicol-hover-overflow.html: Added.
  • fast/regions/regions-in-multicol-hover.html: Added.
  • fast/regions/regions-in-multicol-lr-expected.html: Added.
  • fast/regions/regions-in-multicol-lr.html: Added.
  • fast/regions/regions-in-multicol-rl-expected.html: Added.
  • fast/regions/regions-in-multicol-rl.html: Added.
  • fast/regions/regions-in-multicol.html: Added.
1:19 AM Changeset in webkit [164480] by commit-queue@webkit.org
  • 46 edits in trunk

[CSS Blending] Refactor -webkit-blend-mode to -webkit-mix-blend-mode
https://bugs.webkit.org/show_bug.cgi?id=128805

Patch by Mihai Tica <mitica@adobe.com> on 2014-02-21
Reviewed by Dean Jackson.

Source/WebCore:

The spec defines the mix-blend-mode property. This means that the
prefixed version should be -webkit-mix-blend-mode, instead of
-webkit-blend-mode.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

LayoutTests:

The spec defines the mix-blend-mode property. This means that the
prefixed version should be -webkit-mix-blend-mode, instead of
-webkit-blend-mode. Update all tests accordingly.

  • css3/compositing/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer.html:
  • css3/compositing/blend-mode-layers.html:
  • css3/compositing/blend-mode-overflow.html:
  • css3/compositing/blend-mode-parent-of-composited-blended-has-layer.html:
  • css3/compositing/blend-mode-property-expected.txt:
  • css3/compositing/blend-mode-property-parsing-expected.txt:
  • css3/compositing/blend-mode-property-parsing-invalid-expected.txt:
  • css3/compositing/blend-mode-reflection.html:
  • css3/compositing/blend-mode-simple-composited.html:
  • css3/compositing/blend-mode-simple.html:
  • css3/compositing/blend-mode-with-composited-descendant-should-have-layer.html:
  • css3/compositing/resources/red-circle.svg:
  • css3/compositing/script-tests/blend-mode-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/compositing/script-tests/blend-mode-property-parsing.js:

(testBlendModeRule):

  • css3/compositing/script-tests/blend-mode-property.js:

(testblendmode):

  • css3/compositing/svg-blend-color-burn.html:
  • css3/compositing/svg-blend-color-dodge.html:
  • css3/compositing/svg-blend-color.html:
  • css3/compositing/svg-blend-darken.html:
  • css3/compositing/svg-blend-difference.html:
  • css3/compositing/svg-blend-exclusion.html:
  • css3/compositing/svg-blend-hard-light.html:
  • css3/compositing/svg-blend-hue.html:
  • css3/compositing/svg-blend-layer-blend.html:
  • css3/compositing/svg-blend-layer-clip-path.html:
  • css3/compositing/svg-blend-layer-filter.html:
  • css3/compositing/svg-blend-layer-mask.html:
  • css3/compositing/svg-blend-layer-opacity.html:
  • css3/compositing/svg-blend-layer-shadow.html:
  • css3/compositing/svg-blend-lighten.html:
  • css3/compositing/svg-blend-luminosity.html:
  • css3/compositing/svg-blend-multiply-alpha.html:
  • css3/compositing/svg-blend-multiply.html:
  • css3/compositing/svg-blend-normal.html:
  • css3/compositing/svg-blend-overlay.html:
  • css3/compositing/svg-blend-saturation.html:
  • css3/compositing/svg-blend-screen.html:
  • css3/compositing/svg-blend-soft-light.html:
  • transitions/blendmode-transitions-expected.txt:
  • transitions/blendmode-transitions.html:
12:57 AM Changeset in webkit [164479] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Bindings tests rebaseline after r164473.

  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj mutablePoint]):
(-[DOMTestObj immutablePoint]):
(-[DOMTestObj mutablePointFunction]):
(-[DOMTestObj immutablePointFunction]):

  • bindings/scripts/test/ObjC/DOMTestTypedefs.mm:

(-[DOMTestTypedefs immutablePointFunction]):

12:29 AM Changeset in webkit [164478] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Remove removed symbol from exports list.

  • WebCore.exp.in:
Note: See TracTimeline for information about the timeline view.