Timeline



Jul 31, 2014:

10:02 PM EFLWebKit edited by ryuan.choi@samsung.com
(diff)
10:00 PM Changeset in webkit [171909] by ryuan.choi@samsung.com
  • 2 edits in trunk

[EFL] Bump ewebkit version to 1.11
​https://bugs.webkit.org/show_bug.cgi?id=135487

Reviewed by Gyuyoung Kim.

  • Source/cmake/OptionsEfl.cmake: Bump version numbers.
9:07 PM Changeset in webkit [171908] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop
​https://bugs.webkit.org/show_bug.cgi?id=135490

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.stopCapturing):
Immediately stop the recording without waiting for an event from the backend.
This makes the Web Inspector UI feel responsive to the user stopping the recording.
This also matches behavior before r171195.

8:42 PM Changeset in webkit [171907] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove shadowPseudoId() override from the shadow media controls
​https://bugs.webkit.org/show_bug.cgi?id=135474

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-31
Reviewed by Eric Carlson.

Small cleanup.

  • html/shadow/MediaControlElementTypes.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::MediaControlPanelElement):
(WebCore::MediaControlPanelEnclosureElement::MediaControlPanelEnclosureElement):
(WebCore::MediaControlOverlayEnclosureElement::MediaControlOverlayEnclosureElement):
(WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement):
(WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement):
(WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement):
(WebCore::MediaControlPanelMuteButtonElement::MediaControlPanelMuteButtonElement):
(WebCore::MediaControlVolumeSliderMuteButtonElement::MediaControlVolumeSliderMuteButtonElement):
(WebCore::MediaControlPlayButtonElement::MediaControlPlayButtonElement):
(WebCore::MediaControlOverlayPlayButtonElement::MediaControlOverlayPlayButtonElement):
(WebCore::MediaControlSeekForwardButtonElement::MediaControlSeekForwardButtonElement):
(WebCore::MediaControlSeekBackButtonElement::MediaControlSeekBackButtonElement):
(WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement):
(WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement):
(WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
(WebCore::MediaControlClosedCaptionsContainerElement::MediaControlClosedCaptionsContainerElement):
(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement):
(WebCore::MediaControlTimelineElement::MediaControlTimelineElement):
(WebCore::MediaControlPanelVolumeSliderElement::MediaControlPanelVolumeSliderElement):
(WebCore::MediaControlFullscreenVolumeSliderElement::MediaControlFullscreenVolumeSliderElement):
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
(WebCore::MediaControlFullscreenVolumeMinButtonElement::MediaControlFullscreenVolumeMinButtonElement):
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::MediaControlFullscreenVolumeMaxButtonElement):
(WebCore::MediaControlTimeRemainingDisplayElement::MediaControlTimeRemainingDisplayElement):
(WebCore::MediaControlCurrentTimeDisplayElement::MediaControlCurrentTimeDisplayElement):
(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement):
(WebCore::MediaControlPanelElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelEnclosureElement::shadowPseudoId): Deleted.
(WebCore::MediaControlOverlayEnclosureElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimelineContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlVolumeSliderContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlStatusDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelMuteButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlVolumeSliderMuteButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPlayButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlOverlayPlayButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlSeekForwardButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlSeekBackButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlRewindButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlReturnToRealtimeButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlToggleClosedCaptionsButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlClosedCaptionsContainerElement::shadowPseudoId): Deleted.
(WebCore::MediaControlClosedCaptionsTrackListElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimelineElement::shadowPseudoId): Deleted.
(WebCore::MediaControlPanelVolumeSliderElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeSliderElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Deleted.
(WebCore::MediaControlTextTrackContainerElement::textTrackContainerElementShadowPseudoId): Deleted.
(WebCore::MediaControlTextTrackContainerElement::shadowPseudoId): Deleted.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::MediaControls):
(WebCore::MediaControls::shadowPseudoId): Deleted.

  • html/shadow/MediaControls.h:
7:20 PM Changeset in webkit [171906] by ryuan.choi@samsung.com
  • 4 edits in trunk

[EFL][WK2] MiniBrower comes to crash when combo box is pressed
​https://bugs.webkit.org/show_bug.cgi?id=135378

Reviewed by Gyuyoung Kim.

Source/WebKit2:
Added doxygen comment of popup_menu_show/popup_menu_hide not to confuse the usage.

  • UIProcess/API/efl/ewk_view.h:

Tools:
"clicked" signal of elm_menu is emitted after EwkView calls popup_menu_hide
and removes Ewk_Popup_Menu instance.

  • MiniBrowser/efl/main.c:

(on_popup_menu_show):
(on_popup_menu_discarded): Deleted.

6:26 PM Changeset in webkit [171905] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for platforms where we should have automaticallyAdjustsContentInsets but it isn't public yet

  • platform/mac/ScrollViewMac.mm:
6:26 PM Changeset in webkit [171904] by clopez@igalia.com
  • 4 edits in trunk

[EFL] Add support for building with Geoclue2.
​https://bugs.webkit.org/show_bug.cgi?id=135455

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/OptionsEfl.cmake: Add gio-unix if ENABLE_GEOLOCATION

is set.

Source/WebCore:
No new tests required, no new functionality.

  • PlatformEfl.cmake: Generate derived sources for Geoclue2Interface

and include gio-unix path.

6:15 PM Changeset in webkit [171903] by Brent Fulgham
  • 3 edits
    1 add in trunk

[Win] Use RC_PROJECTBUILDVERSION as build portion of version
​https://bugs.webkit.org/show_bug.cgi?id=135478

Reviewed by David Kilzer.

Tools:
Add new test suite for the version-stamp program.

  • Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Added.

WebKitLibraries:

  • win/tools/scripts/version-stamp.pl: Check environment for

RC_PROJECTBUILDVERSION, and use it for the build portion of
the file version resource. Otherwise, use the VERSION_BUILD
value we calculated from the version string.

6:01 PM Changeset in webkit [171902] by mitz@apple.com
  • 3 edits in trunk/Tools

Reverted r171893, because it broke http/tests/appcache/different-https-origin-resource-main.html,
which loads HTTPS content without calling the delegate.

Rubber-stamped by Alexey Proskuryakov.

  • WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

5:53 PM Changeset in webkit [171901] by ryuan.choi@samsung.com
  • 3 edits
    1 delete in trunk/Source/WebKit2

[EFL] remove ewk_defines.h
​https://bugs.webkit.org/show_bug.cgi?id=135456

Reviewed by Gyuyoung Kim.

  • UIProcess/API/efl/ewk_context_menu.h:
  • UIProcess/API/efl/ewk_context_menu_item.h: Moved the declaration from ewk_defines.h
  • UIProcess/API/efl/ewk_defines.h: Removed.
5:50 PM Changeset in webkit [171900] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed typo correction (and build fix).

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Use correct
property name (_fullScreenIsEnabled -> _fullScreenEnabled)

5:39 PM Changeset in webkit [171899] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit2

Unreviewed typo correction.
​https://bugs.webkit.org/show_bug.cgi?id=135482

Rename '_fullScreenIsEnabled' -> '_fullScreenEnabled'

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _fullScreenEnabled]): Added
(-[WKPreferences _fullScreenIsEnabled]): Deleted.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
5:26 PM Changeset in webkit [171898] by Beth Dakin
  • 2 edits in trunk/LayoutTests

platform/mac/fast/scrolling/scroll-select-bottom-test.html failing on Mavericks
(after 171891?)
​https://bugs.webkit.org/show_bug.cgi?id=135485

Skipping this test for now to allow some time to investigate the failure.

  • platform/mac/TestExpectations:
5:15 PM Changeset in webkit [171897] by Brent Fulgham
  • 5 edits in trunk

MiniBrowser Should Support Fullscreen Videos in WebKit2 Mode
​https://bugs.webkit.org/show_bug.cgi?id=135482

Reviewed by Simon Fraser.

Source/WebKit2:

Add accessors for the missing Fullscreen API so that MiniBrowser
can use them.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _fullScreenIsEnabled]): Added.
(-[WKPreferences _setFullScreenEnabled:]): Added.

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h: Add accessor for

Fullscreen mode.

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]): Activate the Fullscreen
feature.

4:55 PM Changeset in webkit [171896] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

Subpixel rendering: Region painting needs to take subpixel accumulation into account.
​https://bugs.webkit.org/show_bug.cgi?id=135469

Similar to non-region painting, when the context is translated, we need to propagate
the subpixel difference so that renderers get snapped to the same position as if they
were not part of a region.

Reviewed by Simon Fraser.

Covered by existing tests/not testable (webkit.org/b/135470)

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
4:52 PM Changeset in webkit [171895] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Video in an <embed> has a bad aspect ratio when in fullscreen mode.
​https://bugs.webkit.org/show_bug.cgi?id=135481

Reviewed by Simon Fraser.

Do not change the gravity of our AVPlayerLayer when in full screen mode; its gravity
is controlled by setVideoFullscreenGravity(), and should not be affected by style changes.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity):

4:17 PM Changeset in webkit [171894] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline recording is not working inspecting iOS 7 and earlier
​https://bugs.webkit.org/show_bug.cgi?id=135466

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

Start / stop capturing for older backends that won't emit start / stop events.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackend.Agent.prototype.hasEvent):
Provide a way to check if an event is supported.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.stopCapturing):
Fallback to starting and stopping capturing manually if the backend
does not provide the events.

3:56 PM Changeset in webkit [171893] by ap@apple.com
  • 3 edits in trunk/Tools

[Mac, iOS] Remove -setAllowsAnyHTTPSCertificate calls
​https://bugs.webkit.org/show_bug.cgi?id=135472

Reviewed by Dan Bernstein.

We now handle server trust challenges, and don't need such hacks.

  • WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

3:45 PM Changeset in webkit [171892] by Beth Dakin
  • 1 edit
    1 add in trunk/LayoutTests

Test failure fix. I accidentally removed this file that is still used by another
test in the directory.

  • platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html: Added.
3:32 PM Changeset in webkit [171891] by Beth Dakin
  • 15 edits
    5 moves
    1 add in trunk

Hit-testing broken in WebKit 1 views with AppKit's contentInsets
​https://bugs.webkit.org/show_bug.cgi?id=135434
-and corresponding-
<rdar://problem/17850323>

Reviewed by Benjamin Poulain.

Source/WebCore:
AppKit's contentInsets are factored into scroll positions and mouse positions, but
in WebCore, we generally want all of those things to be factored out so that, for
example, the scroll position of a document pinned to the top is the same whether
or not there is a contentInset. So to fix hit-testing in WebKit 1 views with
contentInsets, this patch factors the inset out or into of all coordinate
conversion methods just like we do for the WebKit2 contentInset.

This patch also adds the ability to test WK1 platformContentInsets with
window.internals, and it re-names convertFromRenderer to
convertFromRendererToContainingView and also re-names convertToRenderer to
convertFromContainingViewToRenderer.

ScrollView::topContentInset() takes an optional parameter indicating whether the
caller wants the WebCore::Page contentInset or the platform content inset. It’s
necessary to distinguish between these cases because there is a lot of code that
only wants the WebCore::Page contentInset since that feature is actually
implemented in WebCore as opposed to being implemented at the platform level.

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::topContentInset):

For layout test purposes, set the platforTopContentInset here if there is a
platformWidget().
(WebCore::FrameView::topContentInsetDidChange):

Re-named functions, also all coordinate conversion functions call
topContentInset(ManualOrPlatformContentInset)
(WebCore::FrameView::convertFromContainingViewToRenderer):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::convertFromRenderer): Deleted.
(WebCore::FrameView::convertToRenderer): Deleted.

  • page/FrameView.h:
  • page/Page.cpp:

(WebCore::Page::setTopContentInset):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::documentScrollOffsetRelativeToViewOrigin):
(WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin):
(WebCore::ScrollView::contentsToRootView):
(WebCore::ScrollView::rootViewToTotalContents):
(WebCore::ScrollView::contentsToWindow):
(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):

  • platform/ScrollView.h:

(WebCore::ScrollView::topContentInset):

  • platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):

Implement new platform inset-related functions using AppKit's implementation.

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformTopContentInset):
(WebCore::ScrollView::platformSetTopContentInset):

When we set the scroll position for the documentView, we have to factor the inset
back into the WebCore scroll position.
(WebCore::ScrollView::platformSetScrollPosition):

Re-named functions.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::convertFromScrollbarToContainingView):
(WebCore::RenderLayer::convertFromContainingViewToScrollbar):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::convertFromScrollbarToContainingView):
(WebCore::RenderListBox::convertFromContainingViewToScrollbar):

Source/WebKit2:
Re-named functions.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::convertFromScrollbarToContainingView):
(WebKit::PDFPlugin::convertFromContainingViewToScrollbar):

LayoutTests:
These hit-testing related contentInset tests will now work for mac on wk1 on
Yosemite and wk2.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/tiled-drawing/content-inset-hit-testing-expected.txt: Removed.
  • platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame-expected.txt: Removed.
  • platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame.html: Removed.
  • platform/mac-wk2/tiled-drawing/content-inset-hit-testing.html: Removed.
  • platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html: Removed.
  • platform/mac/fast/events/content-inset-hit-testing-expected.txt: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-expected.txt.
  • platform/mac/fast/events/content-inset-hit-testing-in-frame-expected.txt: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame-expected.txt.
  • platform/mac/fast/events/content-inset-hit-testing-in-frame.html: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing-in-frame.html.
  • platform/mac/fast/events/content-inset-hit-testing.html: Copied from platform/mac-wk2/tiled-drawing/content-inset-hit-testing.html.
  • platform/mac/fast/events/resources: Added.
  • platform/mac/fast/events/resources/iframe-to-hit-test.html: Copied from platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html.
3:07 PM Changeset in webkit [171890] by dino@apple.com
  • 6 edits in trunk/Source/WebCore

Default buttons do not pulse in OS X 10.10
​https://bugs.webkit.org/show_bug.cgi?id=135447
<rdar://problem/17875896>

Reviewed by Dan Bernstein.

OS X Yosemite does not have the animated pulsing default
buttons seen in previous releases. We don't need to have
a timer in RenderButton constantly triggering repaints.

  • platform/mac/ThemeMac.mm:

(WebCore::paintButton): No need to advance the animation.

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::styleDidChange): Ask the theme if it
should advance the animation.

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::defaultButtonHasAnimation): Virtual function
indicating if the button needs to repaint.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::defaultButtonHasAnimation): Provide platform
specific result on Yosemite and above.

3:06 PM Changeset in webkit [171889] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

DOM::renderedImageForcingBlackText returns an image with the wrong logical size on 2x displays
​https://bugs.webkit.org/show_bug.cgi?id=135442
<rdar://problem/17614632>

Reviewed by Simon Fraser.

  • bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
Scale the NSImage size by the device scale factor,
similar to what we did for drag images in r167403.
Ideally this scaling would happen in the code that
generates the images, but this is a much larger change
with much more regression potential.

2:56 PM Changeset in webkit [171888] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSCell::classInfo() belongs in JSCellInlines.h.
<​https://webkit.org/b/135475>

Reviewed by Mark Hahnenberg.

  • runtime/JSCellInlines.h:

(JSC::JSCell::classInfo):

  • runtime/JSDestructibleObject.h:

(JSC::JSCell::classInfo): Deleted.

2:48 PM Changeset in webkit [171887] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Various SSO services need the networking process to be able to spoof its bundle id
​https://bugs.webkit.org/show_bug.cgi?id=135468
<rdar://problem/17864139>

Reviewed by Alexey Proskuryakov.

Just add the entitlement required to allow the sandbox to let this happen.

  • Configurations/Network-iOS.entitlements:
2:38 PM Changeset in webkit [171886] by betravis@adobe.com
  • 18 edits in trunk

[CSS Font Loading] Rename document.fontloader to document.fonts
​https://bugs.webkit.org/show_bug.cgi?id=135393

Reviewed by Bem Jones-Bey.

Source/WebCore:
The most recent version of the specification has renamed
document.fontloader to document.fonts. This change updates the
names in WebCore and LayoutTests.

Fixed up existing tests under LayoutTests/fast/css/fontloader-*
and LayoutTests/http/webfont/fontloader-*

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::notifyFontLoader):
(WebCore::CSSFontFace::notifyLoadingDone):

  • dom/Document.cpp:

(WebCore::Document::fonts):
(WebCore::Document::fontloader): Deleted.

  • dom/Document.h:
  • dom/Document.idl:
  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

LayoutTests:
Update tests to use the new document.fonts name.

  • fast/css/fontloader-download-error.html:
  • fast/css/fontloader-events.html:
  • fast/css/fontloader-loadingdone.html:
  • fast/css/fontloader-multiple-faces-download-error-expected.txt:
  • fast/css/fontloader-multiple-faces-download-error.html:
  • fast/css/fontloader-multiple-faces-expected.txt:
  • fast/css/fontloader-multiple-faces.html:
  • fast/css/fontloader-multiple-families-expected.txt:
  • fast/css/fontloader-multiple-families.html:
  • http/tests/webfont/fontloader-loading-attribute-expected.txt:
  • http/tests/webfont/fontloader-loading-attribute.html:
2:00 PM Changeset in webkit [171885] by jonowells@apple.com
  • 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Sync button look and feel with Xcode updates.
​https://bugs.webkit.org/show_bug.cgi?id=135445

Reviewed by Timothy Hatcher.

Update styles to match recent changes to Xcode text-only
buttons, the navigation bar, and search fields. Include
older style rules for older Mac platforms.

  • UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.text-only):
(body.mac-platform.legacy .navigation-bar .item.button.text-only):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .navigation-bar):
(.sidebar > .panel.details.css-style > .content):
(body.mac-platform.legacy .sidebar > .panel.details.css-style > .content):

  • UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger > .content):
(body.mac-platform.legacy .sidebar > .panel.navigation.debugger > .content):

  • UserInterface/Views/DividerNavigationItem.css:

(.navigation-bar .item.divider):
(body.mac-platform.legacy .navigation-bar .item.divider):

  • UserInterface/Views/FilterBar.css:

(.filter-bar):
(body.mac-platform.legacy .filter-bar):
(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):

  • UserInterface/Views/LogContentView.css:

(.search-bar.log-search-bar > input[type="search"]):
(@media reader):
(.log-search-bar > input): Deleted.

  • UserInterface/Views/Main.css:

(#split-content-browser > .navigation-bar):
(body.mac-platform.legacy #split-content-browser > .navigation-bar):

  • UserInterface/Views/NavigationBar.css:

(.navigation-bar):
(body.mac-platform.legacy .navigation-bar):
(.navigation-bar .item):
(body.mac-platform.legacy .navigation-bar .item):

  • UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .content):
(body.mac-platform.legacy .sidebar > .panel.navigation > .content):

  • UserInterface/Views/QuickConsole.css:

(.quick-console):
(body.mac-platform.legacy .quick-console):

  • UserInterface/Views/RadioButtonNavigationItem.css:

(.navigation-bar .item.radio.button.text-only:hover):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only:hover):
(.navigation-bar .item.radio.button.text-only.selected):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected):
(.navigation-bar .item.radio.button.text-only:active):
(.navigation-bar .item.radio.button.text-only.selected:active):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected:active):

  • UserInterface/Views/ResourceSidebarPanel.css:

(.sidebar > .panel.navigation.resource > .empty-content-placeholder):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .empty-content-placeholder):
(.sidebar > .panel.navigation.resource > .search-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .search-bar):
(.sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):
(body.mac-platform.legacy .sidebar > .panel.navigation.resource > .search-bar > input[type="search"]):

  • UserInterface/Views/ScopeBar.css:

(.scope-bar > li):
(body.mac-platform.legacy .scope-bar > li):
(.scope-bar > li:hover):
(body.mac-platform.legacy .scope-bar > li:hover):
(.scope-bar > li.selected):
(.scope-bar > li:active):
(body.mac-platform.legacy .scope-bar > li:active):
(.scope-bar > li.selected:active):
(body.mac-platform.legacy .scope-bar > li.selected:active):

  • UserInterface/Views/SearchBar.css:

(.search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar > input[type="search"]):
Update styles and apply older styles to legacy Mac platforms.

1:22 PM Changeset in webkit [171884] by dburkart@apple.com
  • 7 copies in branches/safari-537.78-branch/LayoutTests

Merge in missing LayoutTests from merge of r169475 -> r171377.

1:19 PM Changeset in webkit [171883] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/WebKitLibraries

Merge r171870. <rdar://problem/17872507>

12:50 PM Changeset in webkit [171882] by abucur@adobe.com
  • 4 edits
    2 adds in trunk

REGRESSION: Search highlight is broken in RTL multicolumn content
​https://bugs.webkit.org/show_bug.cgi?id=135452

Reviewed by Simon Fraser.

Source/WebCore:
The offsets for elements inside RTL multi-column elements are incorrectly computed because
the columns don't calculate their left position according to the writing direction.

The patch extracts the column position computation in two helper functions (for top and left)
so they can be used when needed in different parts of the code. In our case, the |columnLogicalLeft|
function should be used inside |columnTranslationForOffset|.

Test: fast/multicol/content-bounding-box-rtl.html

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::columnLogicalLeft): Return the logical left of a column relative to the set.
(WebCore::RenderMultiColumnSet::columnLogicalTop): Return the logical top of a column relative to the set.
(WebCore::RenderMultiColumnSet::columnRectAt): Split the code between columnLogicalLeft and columnLogicalTop.
(WebCore::RenderMultiColumnSet::collectLayerFragments): Make code clearer by adding a new line.
(WebCore::RenderMultiColumnSet::columnTranslationForOffset): Use columnLogicalLeft instead of duplicating logic.

  • rendering/RenderMultiColumnSet.h:

LayoutTests:
A test that verifies the bounding boxes for content inside a RTL multi-column element are correctly computed:

  • for static elements
  • for relative positioned elements
  • for absolutely positioned elements
  • fast/multicol/content-bounding-box-rtl-expected.txt: Added.
  • fast/multicol/content-bounding-box-rtl.html: Added.
12:47 PM Changeset in webkit [171881] by Brian Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: MessageDispatcher should not synchronously dispatch all backend messages
​https://bugs.webkit.org/show_bug.cgi?id=135427

Reviewed by Timothy Hatcher.

The frontend dispatches all queued messages from the backend synchronously, even if there are
hundreds of messages, or even if some of the messages take a long time (>10ms) to process.

This patch adds a time limit to the frontend's message dispatcher. If the time limit is exceeded
when processing the message queue, unhandled messages remain in the queue and the dispatcher goes
to sleep until the next run loop (obtained by a new setTimeout).

This has the effect of removing stutters when the message queue has hundreds of small messages.
The outliers are still the same since some single messages can take over 200ms to be handled.

This patch also improves performance logging in InspectorBackend so that it is easier to see
message handling times and their distribution among run loop turns.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass): Add a new diagnostic flag that warns about slow message handling.
(InspectorBackendClass.prototype._dispatchCallback.get if): Improve logging.
(InspectorBackendClass.prototype._dispatchCallback): Improve logging.
(InspectorBackendClass.prototype._dispatchEvent): Improve logging.

  • UserInterface/Protocol/MessageDispatcher.js:

(WebInspector.dispatchNextQueuedMessageFromBackend): Keep track of a time limit for message
dispatching, and set a new timeout if we exceed the time limit.

12:21 PM Changeset in webkit [171880] by ap@apple.com
  • 4 edits in trunk/Tools

media/track/add-and-remove-track.html and media/media-fragments/TC0001.html are flaky
on Mac WK2 EWS, asserting under TestRunner::removeAllWebNotificationPermissions
​https://bugs.webkit.org/show_bug.cgi?id=135418

Reviewed by Anders Carlsson.

This was only happening in shared web process mode, because WKBundlePostMessage
has different behavior then. When there is no process, the message is dropped on
the floor in multiple process mode, but it's stored to be delivered after launch
in shared process mode.

So, calling resetStateToConsistentValues() resulted in storing a Reset bundle message
that was delivered immediately after launch, when there was nothing to reset.

We don't actually need to reset anything at this point, as the previous call has
already reset everything UI process side, and web process is brand new. All we need
is to reattach the page to a process, as invoke() expects one to exist.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::reattachPageToWebProcess):
  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
12:21 PM Changeset in webkit [171879] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-600.1.4.2/Source

Merge r171866. <rdar://problem/17872676>

12:17 PM Changeset in webkit [171878] by Lucas Forschler
  • 2 edits in tags/Safari-600.1.2.5/WebKitLibraries

Merge r171870. <rdar://problem/17872507>

12:17 PM Changeset in webkit [171877] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source

Merge r171866. <rdar://problem/17872676>

12:13 PM Changeset in webkit [171876] by Lucas Forschler
  • 5 edits in tags/Safari-600.1.2.5/Source

Versioning.

12:08 PM Changeset in webkit [171875] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.2.5

New Tag.

12:03 PM Changeset in webkit [171874] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.4.2

New Tag.

11:59 AM Changeset in webkit [171873] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebKit2

Merge r171829. <rdar://problem/17824833>

11:53 AM Changeset in webkit [171872] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171851. <rdar://problem/17719026>

11:20 AM Changeset in webkit [171871] by mhodovan.u-szeged@partner.samsung.com
  • 7 edits in trunk/Source/WebCore

Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength
​https://bugs.webkit.org/show_bug.cgi?id=135377

Reviewed by Darin Adler.

The FractionConversion argument in CSSPrimitiveValue::convertToLength
doesn't seem to actually have a purpose. It is for converting numbers
into Length(x * 100, Percent), but this case shouldn't be reachable.
The original patch introducing it doesn't shed any light either:
[​https://bugs.webkit.org/show_bug.cgi?id=74913

This patch removes the now unused FractionConversion argument. Note
that we can probably also merge the two Fixed conversions, as the
two only differ in clamping large numbers (probably unintended).

No new tests.

  • css/CSSCalculationValue.cpp:

(WebCore::determineCategory):

  • css/CSSParser.cpp:

(WebCore::parseTransformTranslateArguments):
(WebCore::parseTranslateTransformValue):
(WebCore::parseTransformArguments): Deleted.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClip::convertToLength):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::convertToIntLength):
(WebCore::StyleResolver::convertToFloatLength):

  • css/TransformFunctions.cpp:

(WebCore::convertToFloatLength):

11:00 AM Changeset in webkit [171870] by Brent Fulgham
  • 2 edits in trunk/WebKitLibraries

[Win] Fix build failure when using 5-tuple build versions.
​https://bugs.webkit.org/show_bug.cgi?id=135464
<rdar://problem/17872507>

Reviewed by David Kilzer.

  • win/tools/scripts/version-stamp.pl: Modify the environment for

the VersionStamper sub-process to work around bug in that tool.

10:42 AM Changeset in webkit [171869] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Right edge of Timeline Record button does not work
​https://bugs.webkit.org/show_bug.cgi?id=135444

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

When hovering the record button we would show the status text, however
because the left edge of the status text box would overlap the right
edge of the record button causing completely unexpected behavior.

Position the status text correctly so that it never overlaps the record
button. 5px to match the left margin of the record button, and another
2px for some padding between the button and text.

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):

10:40 AM Changeset in webkit [171868] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix uninitialized scalar variable
​https://bugs.webkit.org/show_bug.cgi?id=135461

Patch by Przemyslaw Kuczynski <​p.kuczynski@samsung.com> on 2014-07-31
Reviewed by Alexey Proskuryakov.

If fopen fails, returned ApplicationMemoryStats structure will be uninitialized

  • Shared/linux/WebMemorySamplerLinux.cpp:

(WebKit::sampleMemoryAllocatedForApplication): Initialized applicationStats.

10:37 AM Changeset in webkit [171867] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Build warning in webkit/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp
​https://bugs.webkit.org/show_bug.cgi?id=135414

Patch by Tanay C <​tanay.c@samsung.com> on 2014-07-31
Reviewed by Csaba Osztrogonác.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::putToScopeCommon):removed unused parameter from function definition

10:34 AM Changeset in webkit [171866] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Web Inspector: console.profile missing profile information
​https://bugs.webkit.org/show_bug.cgi?id=135432

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-31
Reviewed by Timothy Hatcher.

Source/WebCore:
By switching console.profile to start/stop the timeline we would
not have a chance to recompile JS functions with profiling information.
This used to work because whenever the inspector was open we would
have profiling information enabled. Go back to that behavior.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::profilerEnabled):
Instead of checking if the timeline agent has started, check if the
timeline agent has been created. Going back to the normal behavior
of always having profiling information when the inspector is open.

  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didCreateFrontendAndBackend):
Recompile initializing the timeline agent to include profiling information.

(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
Recompile destrying the timeline agent, only if needed.

(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
Using a boolean to track nested calls would not give expected
behavior when un-nesting. Switch to a counter to ensure that
as we start profiling in the outermost level we then stop
profiling at that same level and not inside an inner nesting.

Source/WebInspectorUI:

  • UserInterface/Models/ScriptTimelineRecord.js:

Delete the payload information as soon as it has been processed.
It is no longer needed anymore and can be garbage collected.

10:24 AM Changeset in webkit [171865] by betravis@adobe.com
  • 9 edits in trunk/LayoutTests

[CSS Font Loading] Test expectations should show success
​https://bugs.webkit.org/show_bug.cgi?id=135420

Reviewed by Bem Jones-Bey.

Modify the expected files to represent success, and skip
the tests until the feature is enabled.

  • TestExpectations: Skip the tests.
  • fast/css/fontloader-download-error-expected.txt:
  • fast/css/fontloader-events-expected.txt:
  • fast/css/fontloader-loadingdone-expected.txt:
  • fast/css/fontloader-multiple-faces-download-error-expected.txt:
  • fast/css/fontloader-multiple-faces-expected.txt:
  • fast/css/fontloader-multiple-families-expected.txt:
  • http/tests/webfont/fontloader-loading-attribute-expected.txt:
10:20 AM Changeset in webkit [171864] by bshafiei@apple.com
  • 7 edits in tags/Safari-600.1.3.3/Source

Roll out r171647. <rdar://problem/17315168>

10:18 AM Changeset in webkit [171863] by bshafiei@apple.com
  • 5 edits
    9 deletes in tags/Safari-600.1.3.3

Roll out r171661. <rdar://problem/17315237>

10:16 AM Changeset in webkit [171862] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Refactor EventHandler to call ScrollAnimator::handleWheelEvent for overflow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=135195

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-07-31
Reviewed by Beth Dakin.

ScrollableArea::handleWheelEvent is not currently being used to handle wheel events for overflow scrolling; it instead directly invokes ScrollableArea::scroll.
In order to expose wheel phases on Mac, the PlatformWheelEvent itself should propagate down to ScrollableArea, not just the scroll granularity, direction and
multiplier required by ScrollableArea::scroll. With this patch, PlatformWheelEvent will be "shipped" along with the WheelEvent.

No new tests, since behavior should not have changed.

  • page/EventHandler.cpp:

(WebCore::didScrollInScrollableAreaForSingleAxis): Calls ScrollableArea::scroll directly using WheelEvent's data. Used to handle programmatic WheelEvents, e.g. from JavaScript.
(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis): Finds the correct ScrollableArea and attempts to scroll it using the information contained in the WheelEvent via ScrollableArea::handleWheelEvent
(WebCore::EventHandler::defaultWheelEventHandler): Updated to use handleWheelEventInAppropriateEnclosingBoxForSingleAxis instead of scrollNode.
(WebCore::scrollNode): Deleted.

  • rendering/RenderListBox.h: Made RenderListBox::scroll public so it can be invoked from EventHandler::handleWheelEventInAppropriateEnclosingBoxForSingleAxis.
  • rendering/RenderNamedFlowThread.cpp: Refactored to let EventHandler update nextScrollBlock in the case of isRenderNamedFlowThread().

(WebCore::RenderNamedFlowThread::fragmentFromRenderBoxAsRenderBlock):

  • rendering/RenderNamedFlowThread.h:
10:15 AM Changeset in webkit [171861] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Clean up the WebKit build from unused parameter warning in Webkit2/WebProcess module
​https://bugs.webkit.org/show_bug.cgi?id=135413

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-07-31
Reviewed by Darin Adler.

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManager::deleteAllEntries):

10:11 AM Changeset in webkit [171860] by Chris Fleizach
  • 7 edits in trunk/Source/WebKit2

AX: iOS: Crash accessing m_page in WKAccessibilityPageObject
​https://bugs.webkit.org/show_bug.cgi?id=134617

Reviewed by Darin Adler.

Provide a way to detach a WK2 WebPage object so that it can uninitialize other pointers, like the accessibility object.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::platformDetach):

  • WebProcess/WebPage/gtk/WebPageGtk.cpp:

(WebKit::WebPage::platformDetach):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformDetach):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformDetach):

9:45 AM Changeset in webkit [171859] by mitz@apple.com
  • 4 edits in trunk

[WK2] Regression tests can't load HTTPS pages with NetworkProcess due to self-signed certificate
​https://bugs.webkit.org/show_bug.cgi?id=115282

Reviewed by Sam Weinig.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true for any
local host server trust protection space.
(WTR::TestController::didReceiveAuthenticationChallengeInFrame): Respond with a non-empty
credential to server trust challenges.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Removed the exceptions listed under this bug.
9:43 AM Changeset in webkit [171858] by mitz@apple.com
  • 5 edits in trunk/Source

Source/WebCore: WebCore part of: Server trust authentication challenges aren’t sent to the navigation delegate
​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::receivedCredential): Don’t try to change the persistence of
credentials used for server trust, because the platform doesn’t support persistence values
other than Session for server trust.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::receivedCredential): Ditto.

Source/WebKit2: WebKit part of: Server trust authentication challenges aren’t sent to the navigation delegate
​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame):
Return true for server trust protection spaces if the delegate implements
-webView:didReceiveAuthenticationChallenge:completionHandler:.
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): Removed
an assertion that is no longer true due to the above.

9:41 AM Changeset in webkit [171857] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix building with the OS X 10.9 SDK while targeting OS X 10.8.

  • platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toCredentialPersistence):

9:24 AM Changeset in webkit [171856] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[webkitpy] Make diff_text generate correct diff if there is no newline at the end of file
​https://bugs.webkit.org/show_bug.cgi?id=135381

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-07-31
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/port/base.py:

(Port.diff_text):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_diff_text):

9:16 AM Changeset in webkit [171855] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted r171854, because it broke building with the OS X 10.8 SDK.

  • platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toCredentialPersistence):

9:07 AM Changeset in webkit [171854] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix building with the OS X 10.9 SDK while targeting OS X 10.8.

  • platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toCredentialPersistence):

8:58 AM Changeset in webkit [171853] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Update test expectations for crashing tests.

  • platform/efl/TestExpectations:
8:21 AM Changeset in webkit [171852] by fpizlo@apple.com
  • 1 edit
    1 add in trunk/Source/JavaScriptCore

NewFunctionExpression and NewFunctionNoCheck should setHaveStructures(true)
​https://bugs.webkit.org/show_bug.cgi?id=135430

Reviewed by Mark Hahnenberg.

We already handled this correctly after the ftlopt merge, but it's useful to have the test.

  • tests/stress/new-function-expression-has-structures.js: Added.

(foo.f):
(foo.f.prototype.f):
(foo):

8:08 AM Changeset in webkit [171851] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(??): [iOS] Disabling MediaPlaybackRequiresUserGesture does not remove user gesture requirement for entering full screen.
​https://bugs.webkit.org/show_bug.cgi?id=135443

Reviewed by Dean Jackson.

Allow full screen mode to be entered without a user gesture if the gesture requirement for media playback
has been unset.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

7:05 AM Changeset in webkit [171850] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.1 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.5.1.
6:43 AM Changeset in webkit [171849] by abucur@adobe.com
  • 3 edits
    6 adds in trunk

2014-07-31 Andrei Bucur <​abucur@adobe.com>

[CSS Multicolumn] Clear the lines when switching to multi-column layout
​https://bugs.webkit.org/show_bug.cgi?id=135127

Reviewed by Alexandru Chiculita.

Source/WebCore:

When switching an element to multi-column layout it becomes a container of block
children. When this happens the existing line boxes must be deleted in addition
to clearing the hasInlineChildren flag.

Tests: fast/multicol/inline-container-to-multicol.html

fast/multicol/inline-container-to-multicol-float.html
fast/multicol/inline-container-to-multicol-positioned.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createMultiColumnFlowThread):

LayoutTests:

Tests that verifies lines are correctly cleared when an element is switched to
multi-column layout.

  • fast/multicol/inline-container-to-multicol-expected.txt: Added.
  • fast/multicol/inline-container-to-multicol.html: Added.
  • fast/multicol/inline-container-to-multicol-float-expected.txt: Added.
  • fast/multicol/inline-container-to-multicol-float.html: Added.
  • fast/multicol/inline-container-to-multicol-positioned-expected.txt: Added.
  • fast/multicol/inline-container-to-multicol-positioned.html: Added.
6:18 AM Changeset in webkit [171848] by Carlos Garcia Campos
  • 5 edits in trunk

Unreviewed. Fix GTK+ make distcheck.

Source/WebKit2:

  • Shared/InteractionInformationAtPosition.h: Only include

WebCore/SelectionRect.h for IOS.

Tools:

  • gtk/make-dist.py:

(ensure_version_if_possible): Use 4.0 instead of 3.0 as binary
version to find the pkg-config file.

  • gtk/manifest.txt: Add missing resource to the tarball.
5:27 AM Changeset in webkit [171847] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] make distcheck is building from sources dir instead of dist dir
​https://bugs.webkit.org/show_bug.cgi?id=135457

Reviewed by Philippe Normand.

  • gtk/make-dist.py:

(Distcheck.configure): Use dist_dir as source dir.
(Distcheck.check): Pass dist_dir to configure().

2:16 AM Changeset in webkit [171846] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Bump binary version for 2.6
​https://bugs.webkit.org/show_bug.cgi?id=133724

Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsGTK.cmake: Bump binary version to 4.0 and

update library version numbers.

Source/WebKit2:

instrospection commands and make them depend on GTK+-3.0.

1:41 AM Changeset in webkit [171845] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Do not include files that are not in git in the tarball
​https://bugs.webkit.org/show_bug.cgi?id=134804

Reviewed by Philippe Normand.

Skip all files in the source tree that are not under version control
except for files added from the build dir like the documentation.

  • gtk/make-dist.py:

(Directory.init): Initialize the list of files under control version.
(Directory.list_cms_files): Helper function to list all files
under the control version for the current source root.
(Directory.should_skip_file): Return True for files that are not
under control version only when the source root is also under
control version.
(Directory.get_files): Filter the files also using should_skip_file().

12:36 AM Changeset in webkit [171844] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

Speculative Windows build fixery, part II.

This seems to indicate that adding the globalObjectTable to the exports file
was the wrong idea:

1>WebKit.exp : error LNK2001: unresolved external symbol "struct JSC::HashTable const JSC::globalObjectTable" (?globalObjectTable@JSC@@3UHashTable@1@B)

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Jul 30, 2014:

11:51 PM Changeset in webkit [171843] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Speculative Windows build fix.

Try to dllimport the dllexported global object HashTable.

  • jsc.cpp:
  • testRegExp.cpp:
11:17 PM Changeset in webkit [171842] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

11:06 PM Changeset in webkit [171841] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.6

New Tag.

10:49 PM Changeset in webkit [171840] by Lucas Forschler
  • 10 edits
    2 copies in branches/safari-600.1-branch

Merged r171825.

10:40 PM Changeset in webkit [171839] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171802. <rdar://problem/17199364>

10:38 PM Changeset in webkit [171838] by akling@apple.com
  • 10 edits in trunk/Source

PropertyName's internal string is always atomic.
<​https://webkit.org/b/135451>

Source/JavaScriptCore:
Now that we've merged the JSC::Identifier and WTF::AtomicString tables,
we know that any string that's an Identifier is guaranteed to be atomic.

A PropertyName can be either an Identifier or a PrivateName, and the
private names are also guaranteed to be atomic internally.

Make PropertyName vend AtomicStringImpl* instead of StringImpl*.

Reviewed by Benjamin Poulain.

  • runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(JSC::PropertyName::uid):
(JSC::PropertyName::publicName):

Source/WebCore:
Use PropertyName::publicName() directly instead of taking the slow route
through AtomicString::findStringWithHash().

These strings are always atomic, and findStringWithHash() would trudge
through a full hash lookup just to discover that indeed, they are!

Reviewed by Benjamin Poulain.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::findAtomicString): Deleted.

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::canGetItemsForName):
(WebCore::JSHTMLDocument::nameGetter):

Source/WTF:
Remove AtomicString::findStringWithHash() since nobody uses it anymore.

Reviewed by Benjamin Poulain.

  • wtf/text/AtomicString.cpp:

(WTF::findString): Deleted.
(WTF::AtomicString::findStringWithHash): Deleted.

  • wtf/text/AtomicString.h:
8:36 PM Changeset in webkit [171837] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171829. <rdar://problem/17824833>

8:19 PM Changeset in webkit [171836] by benjamin@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a layout test for Geolocation's request queueing for hidden pages
​https://bugs.webkit.org/show_bug.cgi?id=135402

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Zalan Bujtas.

Sam added the queueing feature in r171188. This patch adds a layout test
for the simplest case.

  • fast/dom/Geolocation/requestQueuingForHiddenPage-expected.txt: Added.
  • fast/dom/Geolocation/requestQueuingForHiddenPage.html: Added.
8:18 PM Changeset in webkit [171835] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

ElementRuleCollector: group the shadow tree code
​https://bugs.webkit.org/show_bug.cgi?id=135410

Reviewed by Andreas Kling.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):
Little cleanup: group the shadow tree rule collection in the same block.

8:17 PM Changeset in webkit [171834] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Cleanup DetailsMarkerControl
​https://bugs.webkit.org/show_bug.cgi?id=135429

Reviewed by Andreas Kling.

Remove the override of shadowPseudoId(). This is a simple type of shadowId,
it should use the generic pseudo() path.

Move DetailsMarkerControl::create() out-of-line. One could justify inlining the constructor,
inlining the ::create() function has little value.

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::create):
(WebCore::DetailsMarkerControl::DetailsMarkerControl):
(WebCore::DetailsMarkerControl::rendererIsNeeded):
(WebCore::DetailsMarkerControl::shadowPseudoId): Deleted.
(WebCore::DetailsMarkerControl::summaryElement): Deleted.

  • html/shadow/DetailsMarkerControl.h:

(WebCore::DetailsMarkerControl::create): Deleted.

8:16 PM Changeset in webkit [171833] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove UploadButtonElement::shadowPseudoId()
​https://bugs.webkit.org/show_bug.cgi?id=135435

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic pseudo() path instead of a custom shadowPseudoId().

  • html/FileInputType.cpp:

(WebCore::UploadButtonElement::create):
(WebCore::UploadButtonElement::createForMultiple):
(WebCore::UploadButtonElement::UploadButtonElement):
Set the type in the common constructor instead of the call sites.
(WebCore::UploadButtonElement::shadowPseudoId): Deleted.

  • html/FileInputType.h:
8:16 PM Changeset in webkit [171832] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove SpinButtonElement::shadowPseudoId
​https://bugs.webkit.org/show_bug.cgi?id=135436

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic pseudo.

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::SpinButtonElement):
(WebCore::SpinButtonElement::shadowPseudoId): Deleted.

  • html/shadow/SpinButtonElement.h:
8:15 PM Changeset in webkit [171831] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Clean up YouTubeEmbedShadowElement
​https://bugs.webkit.org/show_bug.cgi?id=135437

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

  • html/shadow/YouTubeEmbedShadowElement.cpp:

(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement): Deleted.
This is unused in WebCore.

(WebCore::YouTubeEmbedShadowElement::shadowPseudoId): Deleted.
Use the generic pseudo path instead of a custom shadowPseudoId.

  • html/shadow/YouTubeEmbedShadowElement.h:
8:14 PM Changeset in webkit [171830] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove shadowPseudoId() from InputFieldSpeechButtonElement and SearchFieldCancelButtonElement
​https://bugs.webkit.org/show_bug.cgi?id=135438

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-30
Reviewed by Andreas Kling.

Use the generic path.

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement):
(WebCore::SearchFieldCancelButtonElement::shadowPseudoId): Deleted.
(WebCore::InputFieldSpeechButtonElement::shadowPseudoId): Deleted.

  • html/shadow/TextControlInnerElements.h:
7:19 PM Changeset in webkit [171829] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (WK2 iOS): Inline editing for Chinese and Japanese keyboards does not work in Safari.
​https://bugs.webkit.org/show_bug.cgi?id=135449
<rdar://problem/17824833>

Reviewed by Benjamin Poulain.

The WebProcess sends the notification that the gesture modified the phrase boundary,
but the flag was not being converted properly, therefore we failed to notify
the text input system that a change had occurred.

  • UIProcess/ios/WKContentViewInteraction.mm:

(toUIWKSelectionFlags):

6:48 PM Changeset in webkit [171828] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.1.3.41/Source

Versioning.

6:46 PM Changeset in webkit [171827] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.3.41

New tag.

6:13 PM Changeset in webkit [171826] by aestes@apple.com
  • 25 edits in trunk/Source

USE(CONTENT_FILTERING) should be ENABLE(CONTENT_FILTERING)
​https://bugs.webkit.org/show_bug.cgi?id=135439

Reviewed by Tim Horton.

We now support two different platform content filters, and will soon support a mock content filter (as part of
webkit.org/b/128858). This makes content filtering a feature of WebKit, not just an adoption of a third-party
library. ENABLE() is the correct macro to use for such a feature.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::dataReceived):

  • loader/DocumentLoader.h:
  • loader/FrameLoaderClient.h:
  • platform/ContentFilter.h:
  • platform/ios/ContentFilterIOS.mm:
  • platform/mac/ContentFilterMac.mm:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

  • wtf/Platform.h:
3:54 PM Changeset in webkit [171825] by matthew_hanson@apple.com
  • 10 edits
    1 copy
    2 adds in tags/Safari-600.1.2.4

Merge r171798. <rdar://problem/17849033>

3:26 PM Changeset in webkit [171824] by akling@apple.com
  • 226 edits
    2 deletes in trunk/Source

Static hash tables no longer need to be coupled with a VM.
<​https://webkit.org/b/135421>

Source/JavaScriptCore:
Now that the static hash tables are using char instead of StringImpl,
it's no longer necessary to make them per-VM.

This patch removes the hook in ClassInfo for providing your own static
hash table getter. Everyone now uses ClassInfo::staticPropHashTable.
Most of this patch is tweaking ClassInfo construction sites to pass one
less null pointer.

Also simplified Lookup.h to stop requiring ExecState/VM to access the
static hash tables.

Reviewed by Geoffrey Garen.

  • API/JSAPIWrapperObject.mm:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • API/ObjCCallbackFunction.mm:
  • bytecode/UnlinkedCodeBlock.cpp:
  • create_hash_table:
  • debugger/DebuggerScope.cpp:
  • inspector/JSInjectedScriptHost.cpp:
  • inspector/JSInjectedScriptHostPrototype.cpp:
  • inspector/JSJavaScriptCallFrame.cpp:
  • inspector/JSJavaScriptCallFramePrototype.cpp:
  • interpreter/CallFrame.h:

(JSC::ExecState::arrayConstructorTable): Deleted.
(JSC::ExecState::arrayPrototypeTable): Deleted.
(JSC::ExecState::booleanPrototypeTable): Deleted.
(JSC::ExecState::dataViewTable): Deleted.
(JSC::ExecState::dateTable): Deleted.
(JSC::ExecState::dateConstructorTable): Deleted.
(JSC::ExecState::errorPrototypeTable): Deleted.
(JSC::ExecState::globalObjectTable): Deleted.
(JSC::ExecState::jsonTable): Deleted.
(JSC::ExecState::numberConstructorTable): Deleted.
(JSC::ExecState::numberPrototypeTable): Deleted.
(JSC::ExecState::objectConstructorTable): Deleted.
(JSC::ExecState::privateNamePrototypeTable): Deleted.
(JSC::ExecState::regExpTable): Deleted.
(JSC::ExecState::regExpConstructorTable): Deleted.
(JSC::ExecState::regExpPrototypeTable): Deleted.
(JSC::ExecState::stringConstructorTable): Deleted.
(JSC::ExecState::promisePrototypeTable): Deleted.
(JSC::ExecState::promiseConstructorTable): Deleted.

  • jsc.cpp:
  • parser/Lexer.h:

(JSC::Keywords::isKeyword):
(JSC::Keywords::getKeyword):

  • runtime/Arguments.cpp:
  • runtime/ArgumentsIteratorConstructor.cpp:
  • runtime/ArgumentsIteratorPrototype.cpp:
  • runtime/ArrayBufferNeuteringWatchpoint.cpp:
  • runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlot):

  • runtime/ArrayIteratorConstructor.cpp:
  • runtime/ArrayIteratorPrototype.cpp:
  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlot):

  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanObject.cpp:
  • runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlot):

  • runtime/ClassInfo.h:

(JSC::ClassInfo::hasStaticProperties):
(JSC::ClassInfo::propHashTable): Deleted.

  • runtime/ConsolePrototype.cpp:
  • runtime/CustomGetterSetter.cpp:
  • runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlot):

  • runtime/DateInstance.cpp:
  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlot):

  • runtime/Error.cpp:
  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlot):

  • runtime/ExceptionHelpers.cpp:
  • runtime/Executable.cpp:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionPrototype.cpp:
  • runtime/GetterSetter.cpp:
  • runtime/InternalFunction.cpp:
  • runtime/JSAPIValueWrapper.cpp:
  • runtime/JSActivation.cpp:
  • runtime/JSArgumentsIterator.cpp:
  • runtime/JSArray.cpp:
  • runtime/JSArrayBuffer.cpp:
  • runtime/JSArrayBufferConstructor.cpp:
  • runtime/JSArrayBufferPrototype.cpp:
  • runtime/JSArrayBufferView.cpp:
  • runtime/JSArrayIterator.cpp:
  • runtime/JSBoundFunction.cpp:
  • runtime/JSConsole.cpp:
  • runtime/JSDataView.cpp:
  • runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::getOwnPropertySlot):

  • runtime/JSFunction.cpp:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlot):

  • runtime/JSMap.cpp:
  • runtime/JSMapIterator.cpp:
  • runtime/JSNameScope.cpp:
  • runtime/JSNotAnObject.cpp:
  • runtime/JSONObject.cpp:

(JSC::JSONObject::getOwnPropertySlot):

  • runtime/JSObject.cpp:

(JSC::getClassPropertyNames):
(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::findPropertyHashEntry):
(JSC::JSObject::reifyStaticFunctionsForDelete):

  • runtime/JSObject.h:
  • runtime/JSPromise.cpp:
  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::getOwnPropertySlot):

  • runtime/JSPromiseDeferred.cpp:
  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::getOwnPropertySlot):

  • runtime/JSPromiseReaction.cpp:
  • runtime/JSPropertyNameIterator.cpp:
  • runtime/JSProxy.cpp:
  • runtime/JSSet.cpp:
  • runtime/JSSetIterator.cpp:
  • runtime/JSString.cpp:
  • runtime/JSTypedArrayConstructors.cpp:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrays.cpp:
  • runtime/JSVariableObject.cpp:
  • runtime/JSWeakMap.cpp:
  • runtime/JSWithScope.cpp:
  • runtime/Lookup.cpp:

(JSC::HashTable::createTable):

  • runtime/Lookup.h:

(JSC::HashTable::initializeIfNeeded):
(JSC::HashTable::entry):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):
(JSC::lookupPut):

  • runtime/MapConstructor.cpp:
  • runtime/MapData.cpp:
  • runtime/MapIteratorConstructor.cpp:
  • runtime/MapIteratorPrototype.cpp:
  • runtime/MapPrototype.cpp:
  • runtime/MathObject.cpp:
  • runtime/NameConstructor.cpp:
  • runtime/NameInstance.cpp:
  • runtime/NamePrototype.cpp:

(JSC::NamePrototype::getOwnPropertySlot):

  • runtime/NativeErrorConstructor.cpp:
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):

  • runtime/NumberObject.cpp:
  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlot):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlot):

  • runtime/ObjectPrototype.cpp:
  • runtime/PropertyTable.cpp:
  • runtime/RegExp.cpp:
  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlot):

  • runtime/RegExpMatchesArray.cpp:
  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):

  • runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlot):

  • runtime/SetConstructor.cpp:
  • runtime/SetIteratorConstructor.cpp:
  • runtime/SetIteratorPrototype.cpp:
  • runtime/SetPrototype.cpp:
  • runtime/SparseArrayValueMap.cpp:
  • runtime/StrictEvalActivation.cpp:
  • runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlot):

  • runtime/StringObject.cpp:
  • runtime/StringPrototype.cpp:
  • runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::freezeTransition):
(JSC::ClassInfo::hasStaticSetterOrReadonlyProperties):

  • runtime/StructureChain.cpp:
  • runtime/StructureRareData.cpp:
  • runtime/SymbolTable.cpp:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):

  • runtime/VM.h:
  • runtime/WeakMapConstructor.cpp:
  • runtime/WeakMapData.cpp:
  • runtime/WeakMapPrototype.cpp:
  • testRegExp.cpp:

Source/WebCore:
Update for JSC::ClassInfo changes.

Remove the JSNoStaticTables mode for IDL code generation, which was used to
ensure that each VM had its own unique copy of certain static tables.
This was used for interfaces that could be used in workers, and now there's
no need to manually annotate these things anymore.

Also remove the DOMObjectHashTableMap class that was only used for this.

Reviewed by Geoffrey Garen.

  • Modules/indexeddb/IDBAny.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBCursorWithValue.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLError.idl:
  • Modules/webdatabase/SQLException.idl:
  • Modules/webdatabase/SQLResultSet.idl:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionSync.idl:
  • Modules/websockets/CloseEvent.idl:
  • Modules/websockets/WebSocket.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMObjectHashTableMap.cpp: Removed.
  • bindings/js/DOMObjectHashTableMap.h: Removed.
  • bindings/js/JSDOMBinding.cpp:

(WebCore::getHashTableForGlobalData): Deleted.

  • bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching):

  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::put):

  • bindings/js/JSDOMWindowShell.cpp:
  • bindings/js/JSImageConstructor.cpp:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):

  • bindings/js/JSWorkerGlobalScopeBase.cpp:
  • bindings/js/WebCoreJSClientData.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
(GenerateConstructorHelperMethods):
(hashTableAccessor): Deleted.
(prototypeHashTableAccessor): Deleted.
(constructorHashTableAccessor): Deleted.

  • bindings/scripts/IDLAttributes.txt:
  • bridge/c/CRuntimeObject.cpp:
  • bridge/c/c_instance.cpp:
  • bridge/objc/ObjCRuntimeObject.mm:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.mm:
  • bridge/runtime_array.cpp:
  • bridge/runtime_method.cpp:
  • bridge/runtime_object.cpp:
  • crypto/CryptoKey.idl:
  • css/CSSFontFaceLoadEvent.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMStringList.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/ProgressEvent.idl:
  • fileapi/Blob.idl:
  • fileapi/File.idl:
  • fileapi/FileError.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • html/DOMURL.idl:
  • page/EventSource.idl:
  • page/WorkerNavigator.idl:
  • workers/DedicatedWorkerGlobalScope.idl:
  • workers/SharedWorkerGlobalScope.idl:
  • workers/WorkerGlobalScope.idl:
  • workers/WorkerLocation.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestProgressEvent.idl:
  • xml/XMLHttpRequestUpload.idl:

Source/WebKit/mac:
Reviewed by Geoffrey Garen.

  • Plugins/Hosted/ProxyInstance.mm:
  • Plugins/Hosted/ProxyRuntimeObject.mm:

Source/WebKit2:
Reviewed by Geoffrey Garen.

  • WebProcess/Plugins/Netscape/JSNPMethod.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:
3:20 PM Changeset in webkit [171823] by Lucas Forschler
  • 5 edits in branches/safari-537.78-branch/Source

Versioning.

3:19 PM Changeset in webkit [171822] by Lucas Forschler
  • 1 copy in tags/Safari-537.78.2

New Tag.

3:05 PM Changeset in webkit [171821] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-600.1.2.4/Source

Versioning.

2:53 PM Changeset in webkit [171820] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.2.4

New Tag.

2:46 PM Changeset in webkit [171819] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: ProbeSetDetailsSection should not create live location links for unresolved breakpoints
​https://bugs.webkit.org/show_bug.cgi?id=135367

Reviewed by Timothy Hatcher.

Regenerate the source code link whenever the breakpoint resolved status changes. If it is
resolved, then we can create a live location link that respects source maps.

  • UserInterface/Views/ProbeSetDetailsSection.js:

(WebInspector.ProbeSetDetailsSection):
(WebInspector.ProbeSetDetailsSection.prototype._updateLinkElement): Added.
(WebInspector.ProbeSetDetailsSection.prototype._probeSetPositionTextOrLink): Deleted.

2:34 PM Changeset in webkit [171818] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Merging platforms mixes baselines and targets into reported data
​https://bugs.webkit.org/show_bug.cgi?id=135260

Reviewed by Geoffrey Garen.

Make sure two test configurations we're merging are of the same type (e.g. baseline, target, current).
Otherwise, we'll erroneously mix up runs for baseline, target, and current (reported values).

  • public/admin/platforms.php:
2:28 PM Changeset in webkit [171817] by psolanki@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

Move iphone-simulator test results landed in r171094 to the correct directory.

  • platform/ios-sim/fast/events/ontouchstart-active-selector-expected.txt: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector-expected.txt.
  • platform/ios-sim/fast/events/ontouchstart-active-selector.html: Renamed from LayoutTests/platform/iphone-simulator/fast/events/ontouchstart-active-selector.html.
2:03 PM Changeset in webkit [171816] by mitz@apple.com
  • 5 edits
    2 deletes in trunk/Source/WebKit2

Get rid of the WKNSURLProtectionSpace wrapper
​https://bugs.webkit.org/show_bug.cgi?id=135425

Reviewed by Sam Weinig.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Don’t allocate WKNSURLProtectionSpace wrappers.

  • Shared/Cocoa/WKNSURLProtectionSpace.h: Removed.
  • Shared/Cocoa/WKNSURLProtectionSpace.mm: Removed.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(canAuthenticateAgainstProtectionSpaceInFrame): Get the NSURLProtectionSpace from the
WebCore::ProtectionSpace in the WebProtectionSpace.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Removed references to removed files.
1:55 PM Changeset in webkit [171815] by Lucas Forschler
  • 5 edits in branches/safari-537.78-branch/Source

Fix Versioning.

1:45 PM Changeset in webkit [171814] by Lucas Forschler
  • 7 edits
    1 copy in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171790. <rdar://problem/17848962>

1:44 PM Changeset in webkit [171813] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171787. <rdar://problem/17852395>

1:40 PM Changeset in webkit [171812] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171786. <rdar://problem/17852407>

1:36 PM Changeset in webkit [171811] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-600.1-branch

Merged r171785. <rdar://problem/17851910>

1:33 PM Changeset in webkit [171810] by Lucas Forschler
  • 6 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171783. <rdar://problem/17848773>

1:31 PM Changeset in webkit [171809] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171766. <rdar://problem/17824645>

1:29 PM Changeset in webkit [171808] by Lucas Forschler
  • 11 edits in branches/safari-600.1-branch/Source

Merged r171749. <rdar://problem/15917314>

1:26 PM Changeset in webkit [171807] by Lucas Forschler
  • 8 edits
    2 copies in branches/safari-600.1-branch

Merged r171718. <rdar://problem/17824793>

1:15 PM Changeset in webkit [171806] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source

Versioning.

1:13 PM Changeset in webkit [171805] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.4.1

New Tag.

12:56 PM Changeset in webkit [171804] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171766. <rdar://problem/17824645>

12:50 PM Changeset in webkit [171803] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171702. <rdar://problem/16828238>

12:40 PM Changeset in webkit [171802] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/17199364> [Mac] Popup button arrows appear on the left, underlapping text, when the UI layout direction is right-to-left
​https://bugs.webkit.org/show_bug.cgi?id=135426

Reviewed by Dean Jackson.

No test, because the UI layout direction in the test harness is always left-to-right.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::popupButton): Forced the user interface layout direction of the
NSPopUpButtonCell to left-to-right. Added a FIXME about how we could make this vary based on
the direction of the <select>, though that would require additional changes elsewhere.

11:56 AM Changeset in webkit [171801] by mitz@apple.com
  • 25 edits in trunk/Source

Source/WebCore: Made Credential hold onto an NSURLCredential when needed.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

No change in functionality.

  • WebCore.exp.in: Updated.
  • platform/network/Credential.h: Removed definition of CERTIFICATE_CREDENTIALS_SUPPORTED,

which is not used anymore.

  • platform/network/CredentialBase.h:

(WebCore::CredentialBase::encodingRequiresPlatformData): Added a base implementation that
returns false.

  • platform/network/cf/AuthenticationCF.cpp:

Changed to use the Credential constructor that takes an CFURLCredential, and the new
cfCredential member function. Made the createCF and core functions Windows-only and
therefore removed the CERTIFICATE_CREDENTIALS_SUPPORTED code from them.

  • platform/network/cf/AuthenticationCF.h:
  • platform/network/cf/CredentialStorageCFNet.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage): Changed to construct a Credential
from a CFURLCredential.
(WebCore::CredentialStorage::saveToPersistentStorage): Changed to use the new cfCredential
member function.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto to both.
(WebCore::ResourceHandle::receivedCredential): Ditto.

  • platform/network/cocoa/CredentialCocoa.h:

Replaced the m_identity, m_certificates and m_type member variables with an m_nsCredential
one holding onto an NSURLCredential. Declared constructors from and getters for
NSURLCredential and CFURLCredentialRef.
(WebCore::Credential::encodingRequiresPlatformData): Override that checks the
NSURLCredential if necessary.

  • platform/network/cocoa/CredentialCocoa.mm:

(WebCore::toNSURLCredentialPersistence): New helper function.
(WebCore::toCredentialPersistence): Ditto.
(WebCore::Credential::Credential): Defined constructors to create or take an
NSURLCredential.
(WebCore::Credential::cfCredential): Added.
(WebCore::Credential::nsCredential): Added. Returns nil for the empty credential.
(WebCore::Credential::isEmpty): Changed to check m_nsCredential.
(WebCore::Credential::platformCompare): Changed to compare m_nsCredential if needed.
(WebCore::Credential::encodingRequiresPlatformData): Returns true if the credential is not
a user and a password.

  • platform/network/mac/AuthenticationMac.h: Removed mac and core functions for Credential.
  • platform/network/mac/AuthenticationMac.mm:

(-[WebCoreAuthenticationClientAsChallengeSender useCredential:forAuthenticationChallenge:]):
Changed to use Credential constructor that takes an NSURLCredential.
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Ditto. Also use the
nsCredential getter.

  • platform/network/mac/CredentialStorageMac.mm:

(WebCore::CredentialStorage::getFromPersistentStorage): Use new Credential constructor.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Ditto. Also use the
nsCredential getter.
(WebCore::ResourceHandle::receivedCredential): Ditto.

Source/WebKit/mac: Updated for changes to the WebCore::Credential API.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

  • Misc/WebDownload.mm:

(-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]): Use new nsCredential
getter.

  • Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo): Ditto.

Source/WebKit2: Updated for changes to the WebCore::Credential API.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

  • Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::receivedCredential):Use new Credential::nsCredential getter.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Credential>::encode): If encoding the credential requires encoding the
platform data, do that.
(IPC::ArgumentCoder<Credential>::decode): If platform data was encoded, decode it.

  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<Credential>::encodePlatformData): Archive the NSURLCredential.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Unarchive it.

  • UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:

(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]): Use
Credential constructor that takes an NSURLCredential.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): Ditto.

9:49 AM Changeset in webkit [171800] by dfarler@apple.com
  • 1 edit
    15 adds in trunk/Tools

iOS Simulator LayoutTestRelay
​https://bugs.webkit.org/show_bug.cgi?id=135269

Reviewed by David Kilzer.

  • LayoutTestRelay/Configurations/Base.xcconfig: Added.
  • LayoutTestRelay/Configurations/DebugRelease.xcconfig: Added.
  • LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj: Added.
  • LayoutTestRelay/LayoutTestRelay/LTPipeRelay.h: Added.
  • LayoutTestRelay/LayoutTestRelay/LTPipeRelay.m: Added.

(-[LTPipeRelay inPipePath]):
(-[LTPipeRelay outPipePath]):
(-[LTPipeRelay errorPipePath]):
(-[LTPipeRelay outputStream]):
(-[LTPipeRelay initWithPrefix:]):
(-[LTPipeRelay setup]):
(-[LTPipeRelay tearDown]):
(-[LTPipeRelay connect]):
(-[LTPipeRelay disconnect]):
(-[LTPipeRelay createFIFOs]):
(-[LTPipeRelay destroyFIFOs]):
(-[LTPipeRelay relayStream:]):
(-[LTPipeRelay stream:handleEvent:]):

  • LayoutTestRelay/LayoutTestRelay/LTRelay.h: Added.
  • LayoutTestRelay/LayoutTestRelay/LTRelayController.h: Added.
  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m: Added.

(-[LTRelayController uniqueAppPath]):
(-[LTRelayController uniqueAppURL]):
(-[LTRelayController uniqueAppIdentifier]):
(-[LTRelayController processName]):
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
(-[LTRelayController readFileHandle:]):
(-[LTRelayController receivedStandardOutputData:]):
(-[LTRelayController receivedStandardErrorData:]):
(-[LTRelayController disconnected]):
(-[LTRelayController connected]):
(-[LTRelayController crashWithMessage:]):
(-[LTRelayController launchSimulator]):
(-[LTRelayController bootDevice]):
(-[LTRelayController createUniqueApp]):
(-[LTRelayController killApp]):
(-[LTRelayController launchApp]):
(-[LTRelayController start]):

  • LayoutTestRelay/LayoutTestRelay/main.m: Added.

(usage):
(getTestingSimDevice):
(getRequiredStringArgument):
(getRemainderArguments):
(main):

  • LayoutTestRelay/Makefile: Added.
  • Tools/Scripts/build-layouttestrelay: Added.
9:35 AM Changeset in webkit [171799] by svillar@igalia.com
  • 3 edits in trunk/Source/WebCore

[GTK] Build depends on OpenGL ES
​https://bugs.webkit.org/show_bug.cgi?id=135289

Reviewed by Martin Robinson.

Guard the OpenGL ES code with USE(OPENGL_ES_2).

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLES.h:
9:35 AM Changeset in webkit [171798] by Brent Fulgham
  • 11 edits
    1 add in trunk

[Win] Modify version numbering scheme to support 5-tuple versions
​https://bugs.webkit.org/show_bug.cgi?id=135400
<rdar://problem/17849033>

Reviewed by David Kilzer.

Source/JavaScriptCore:

new version-stamp.pl script to version JavaScriptCore.dll.

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Use the new

version-stamp.pl script to version JavaScriptCore.dll.

Source/WTF:

  • WTF.vcxproj/WTFPostBuild.cmd: Use new version-stamp.pl script

to version WTF.dll.

  • WTF.vcxproj/WTFPreBuild.cmd: Make sure we have created the

appropriate version resource during builds.

Tools:
Update test cases to recognize that we can only support Major
values from 0-65535, Minor values from 0-64, Tiny values from 0-999,
Micro values from 0-64, and Nano values from 0-999.

  • Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Update

test expectations for physical limits.

WebKitLibraries:
Revise the auto-version.pl script so that it generates a set of packed
version tuples that allow us to map 5-tuple versions into something
that will work with Windows' 3-tuple version structure.

  • win/tools/scripts/auto-version.pl:

(packTwoValues): Added,
(splitVersion): Revised to return packed combination of minor-tiny and
micro-nano to be used as "MINOR" and "TINY" portion of version.
(splitBuildMajorVersion): Deleted.

  • win/tools/scripts/version-stamp.pl: Added.
9:23 AM Changeset in webkit [171797] by stavila@adobe.com
  • 4 edits in trunk/Source/WebCore

Member name collision in RenderView and SelectionSubtreeRoot
​https://bugs.webkit.org/show_bug.cgi?id=135233

Reviewed by Mihnea Ovidenie.

The selectionStart/End members in RenderView have been renamed to fix confusion caused by the fact that
RenderView inherits SelectionSubtreeRoot, which also has the same selectionStart/End members.

No new tests required, no new functionality.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):

  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::getSelection):

  • rendering/RenderView.h:
3:52 AM Changeset in webkit [171796] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] REGRESSION(r171742): Test /webkit2/WebKitWebView/disallow-modal-dialogs fails
​https://bugs.webkit.org/show_bug.cgi?id=135412

Reviewed by Philippe Normand.

The problem is that WebPageProxy::setUIClient() calls
setCanRunModal() with the value of m_uiClient->canRunModal() which
is always true for us. We override that manually by calling
setCanRunModal() depending on the WebKitSettings. In r171742,
webkitWebViewUpdateSettings(), the method that overrides
setCanRunModal(), was moved before attachUIClientToView(), so the
value set by WebPageProxy::setUIClient() is the last one and takes
precedence. We need to make sure webkitWebViewUpdateSettings() is
always called after attachUIClientToView().

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Move webkitWebViewUpdateSettings()
call after attachUIClientToView() and add a comment to not forget
about it again.

12:47 AM Changeset in webkit [171795] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[TexMap] Move TextureMapperLayer::textureMapper() definition into the header
​https://bugs.webkit.org/show_bug.cgi?id=135384

Reviewed by Martin Robinson.

Move the definitions of TextureMapperLayer::textureMapper() and TextureMapperLayer::rootLayer()
into the TextureMapperLayer header. This makes both functions inline-able, removing unnecessary
calling overhead in GraphicsLayerTextureMapper::flushCompositingState() and
GraphicsLayerTextureMapper::updateBackingStoreIfNeeded().

TextureMapperLayer::rootLayer() now also returns a reference.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::rootLayer): Deleted.
(WebCore::TextureMapperLayer::textureMapper): Deleted.

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::textureMapper):
(WebCore::TextureMapperLayer::rootLayer):

12:47 AM Changeset in webkit [171794] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] GLib tests fail with recent GTK+ due to runtime warning about deprecated properties
​https://bugs.webkit.org/show_bug.cgi?id=135411

Reviewed by Sergio Villar Senin.

Recent versions of GTK+ now warn at runtime when a deprecated
property or signal is used. A diagnostic mode was added that is
enabled by default, but that can be disabled by setting
G_ENABLE_DIAGNOSTIC=0. Runtime warnings are considered test
failures by gtester, so we need to run the tests with the
diganostic mode disabled.

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:

(main):

12:45 AM Changeset in webkit [171793] by zandobersek@gmail.com
  • 2 edits in trunk

[CMake] Bump the minimum required version
​https://bugs.webkit.org/show_bug.cgi?id=135382

Reviewed by Gyuyoung Kim.

  • CMakeLists.txt: Bump the minimum required version to 2.8.11 after

we introduced usage of target_include_directories().

12:06 AM Changeset in webkit [171792] by Carlos Garcia Campos
  • 11 edits
    3 deletes in trunk

[GTK] Remove WebKitCertificateInfo from WebKit2GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=134830

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:
It was added to make the API more convenient but it has ended up
making it more complicated. WebKitWebView::load-failed-with-tls-errors
now receives a GTlsCertificate + GTlsCertificateFlags and
webkit_web_context_allow_tls_certificate_for_host() receives a GTlsCertificate
since the errors are not actually needed. This makes the API more
consistent with the existing method webkit_web_view_get_tls_info().

  • PlatformGTK.cmake: Remove files from compilation.
  • UIProcess/API/gtk/WebKitCertificateInfo.cpp: Removed.
  • UIProcess/API/gtk/WebKitCertificateInfo.h: Removed.
  • UIProcess/API/gtk/WebKitCertificateInfoPrivate.h: Removed.
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_allow_tls_certificate_for_host):

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_class_init):
(webkitWebViewLoadFailedWithTLSErrors):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
  • UIProcess/API/gtk/webkit2.h:

Tools:
Update the SSL test for the API changes.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(testLoadFailedWithTLSErrors):

Jul 29, 2014:

11:16 PM Changeset in webkit [171791] by jinwoo7.song@samsung.com
  • 10 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening. Rebaseline tests after r170418.

  • platform/efl/mathml/opentype/horizontal-expected.txt:
  • platform/efl/mathml/opentype/horizontal-munderover-expected.txt:
  • platform/efl/mathml/opentype/large-operators-expected.txt:
  • platform/efl/mathml/opentype/vertical-expected.txt:
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.png:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/roots-expected.png:
  • platform/efl/mathml/presentation/roots-expected.txt:
10:42 PM Changeset in webkit [171790] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: 80% of time during recording is spent creating source code locations for profile nodes
​https://bugs.webkit.org/show_bug.cgi?id=135399

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Profiling the inspector while recording a timeline, a significant amount of
time was spent creating SourceCodeLocation objects for profiling information
and call frames. A lot of this data was eagerly being processed, even though
it would not immediately be presentable to the user.

This makes two significant changes. We create a LazySourceCodeLocation class
which does as little as possible until display information is requested. We
also lazily convert the profiler payload data to a Profile object, so the
processing is only done if you drill into the Script specific timeline.

This results in a significant performance improvement in the overview view.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype._callFramesFromPayload.createCallFrame):
(WebInspector.TimelineManager.prototype._callFramesFromPayload):
(WebInspector.TimelineManager.prototype._profileFromPayload.profileNodeFromPayload): Deleted.
(WebInspector.TimelineManager.prototype._profileFromPayload.profileNodeCallFromPayload): Deleted.
(WebInspector.TimelineManager.prototype._profileFromPayload): Deleted.
Do not eagerly process profile payloads. Instead pass the payload to ScriptTimelineRecords.
Likewise create callframes with lazy source code locations to do the minimum amount of work.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord):
(WebInspector.ScriptTimelineRecord.prototype.get profile):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeFromPayload):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeCallFromPayload):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
Only when the profile is asked do we process the profiler payload information.
This defer the processing until at least the user drills into the Script timeline.

  • UserInterface/Main.html:

Add the new class and ensure SourceCodeLocation is available beforehand.

  • UserInterface/Models/LazySourceCodeLocation.js: Added.

(WebInspector.LazySourceCodeLocation):
(WebInspector.LazySourceCodeLocation.prototype.isEqual):
(WebInspector.LazySourceCodeLocation.prototype.get sourceCode):
(WebInspector.LazySourceCodeLocation.prototype.set sourceCode):
(WebInspector.LazySourceCodeLocation.prototype.get formattedLineNumber):
(WebInspector.LazySourceCodeLocation.prototype.get formattedColumnNumber):
(WebInspector.LazySourceCodeLocation.prototype.formattedPosition):
(WebInspector.LazySourceCodeLocation.prototype.hasFormattedLocation):
(WebInspector.LazySourceCodeLocation.prototype.hasDifferentDisplayLocation):
(WebInspector.LazySourceCodeLocation.prototype.resolveMappedLocation):
(WebInspector.LazySourceCodeLocation.prototype._lazyInitialization):
Only when display information is requested will we perform extra processing.
For basic information we do not need to check for formatted (pretty-printed) info.

  • UserInterface/Models/SourceCode.js:

(WebInspector.SourceCode.prototype.createLazySourceCodeLocation):
Provide an explict create function for lazy source codes.

  • UserInterface/Models/SourceCodeLocation.js:

(WebInspector.SourceCodeLocation.prototype.set sourceCode):
(WebInspector.SourceCodeLocation.prototype.get displaySourceCode):
(WebInspector.SourceCodeLocation.prototype.get displayLineNumber):
(WebInspector.SourceCodeLocation.prototype.get displayColumnNumber):
(WebInspector.SourceCodeLocation.prototype.hasMappedLocation):
(WebInspector.SourceCodeLocation.prototype.setSourceCode):
(WebInspector.SourceCodeLocation.prototype.resolveMappedLocation):
(WebInspector.SourceCodeLocation.prototype._makeChangeAndDispatchChangeEventIfNeeded):
(WebInspector.SourceCodeLocation.prototype._resolveMappedLocation): Deleted.
Include two protected functions which LazySourceCodeLocation overrides.

9:49 PM Changeset in webkit [171789] by dfarler@apple.com
  • 5 edits
    1 add in trunk/Tools

Add knowledge of the iOS Simulator to webkitpy
​http://bugs.webkit.org/show_bug.cgi?id=133963

Reviewed by Simon Fraser.

  • Scripts/webkitdirs.pm:

(argumentsForConfiguration): Add --ios-sim*

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

--runtime and --device-type args added.

  • Scripts/webkitpy/port/base.py:
  • Scripts/webkitpy/port/driver.py: Add simulator driver.

(IOSSimulatorDriver): Added.

  • Scripts/webkitpy/port/factory.py: Add simulator platform.
  • Scripts/webkitpy/port/ios.py: Added.
9:26 PM Changeset in webkit [171788] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL] Do not initialize g_type system explicitly in the ewk_init()
​https://bugs.webkit.org/show_bug.cgi?id=135407

Reviewed by Gyuyoung Kim.

EFL build requires glib version 2.38 but g_type_init() has been deprecated
since version 2.36. As the type system is initialized automatically since
version 2.36, we do not need to call g_type_init() in the ewk_init().

​https://developer.gnome.org/gobject/unstable/gobject-Type-Information.html#g-type-init

  • UIProcess/API/efl/ewk_main.cpp:

(ewk_init):

9:17 PM Changeset in webkit [171787] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Only compute full ProfileNode times if needed - Legacy Profiler
​https://bugs.webkit.org/show_bug.cgi?id=135406

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Full ProfileNode times are only used by the Legacy Profiler. The new profile
information in the Scripts Timelines currently never uses the pass. We should
avoid calculating it if we never use it.

  • UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode.prototype.get startTime):
(WebInspector.ProfileNode.prototype.get endTime):
(WebInspector.ProfileNode.prototype.get selfTime):
(WebInspector.ProfileNode.prototype.get totalTime):
(WebInspector.ProfileNode.prototype.establishRelationships):
(WebInspector.ProfileNode.prototype._computeTotalTimes):

9:00 PM Changeset in webkit [171786] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce forced layouts in TimelineOverview
​https://bugs.webkit.org/show_bug.cgi?id=135405

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Remove another forced layout. The scroll container won't
change size unless the ContentView itself resized. Make the
distinction between a layout update due to a resize and
normal events (scale changes, etc) and only calculate
element sizes then.

  • UserInterface/Views/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype.updateLayout):

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.updateLayoutForResize):

8:51 PM Changeset in webkit [171785] by akling@apple.com
  • 3 edits
    2 adds in trunk

Crash when using 'em' units to specify font-size inside animation keyframe.
<​https://webkit.org/b/135395>
<rdar://problem/17851910>

Source/WebCore:
We'd forgotten to initialize the "parent style" when resolving keyframe
styles, and this led to a crash in length conversion where the code
assumes a parent style will be present.

To keep this fix minimal, simply make the "parent style" a clone of the
base element style.

Reviewed by Simon Fraser.

Test: fast/animation/keyframe-with-font-size-in-em-units.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):

LayoutTests:
Add a reduced test case to cover this bug.

Reviewed by Simon Fraser.

  • fast/animation/keyframe-with-font-size-in-em-units-expected.txt: Added.
  • fast/animation/keyframe-with-font-size-in-em-units.html: Added.
8:48 PM Changeset in webkit [171784] by Brian Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: breakpoints are always speculatively resolved when restored from local storage
​https://bugs.webkit.org/show_bug.cgi?id=135396

Reviewed by Timothy Hatcher.

A longstanding quirk/optimization in the frontend is that we immediately set a breakpoint
as resolved if the breakpoint was successfully set in the backend. This ensures that clicking in
the gutter immediately produces a resolved breakpoint with only one round-trip.

However, not all breakpoints should be speculatively resolved, because the corresponding resource
may not be loaded yet. This situation causes problems for code that assumes a resolved breakpoint
also has a valid sourceCodeLocation.sourceCode.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.restoreBreakpointsSoon): Don't leak the variable to global scope.
(WebInspector.DebuggerManager):
(WebInspector.DebuggerManager.prototype.speculativelyResolveBreakpoint):
(WebInspector.DebuggerManager.prototype.addBreakpoint): Speculatively resolve here if requested
using the success callback passed to _setBreakpoint.

(WebInspector.DebuggerManager.prototype.didSetBreakpoint): Emit simulated
Debugger.breakpointResolved events since they are only sent by the backend when a script is parsed.

(WebInspector.DebuggerManager.prototype._setBreakpoint):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded): Request speculative resolve.

5:30 PM Changeset in webkit [171783] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Eliminate more forced layouts during timeline recordings
​https://bugs.webkit.org/show_bug.cgi?id=135397

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-29
Reviewed by Timothy Hatcher.

Instead of computing the secondsPerPixel in each overview graph,
we can ask the overview view itself which has a cached value.
The computation used to force a layout, now it doesn't need to.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:
  • UserInterface/Views/NetworkTimelineOverviewGraph.js:
  • UserInterface/Views/ScriptTimelineOverviewGraph.js:
  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):

  • UserInterface/Views/TimelineOverviewGraph.js:

(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.get timelineOverview):
(WebInspector.TimelineOverviewGraph.prototype.set timelineOverview):

5:17 PM Changeset in webkit [171782] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION [WebKit2 iOS]: Cannot add shortcut to user dictionary from non editable content.
​https://bugs.webkit.org/show_bug.cgi?id=135392
<rdar://problem/17760073>

Reviewed by Benjamin Poulain.

Adding a shortcut to the user dictionary needs to be available in non editable content too.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _addShortcut:]):

5:15 PM Changeset in webkit [171781] by Lucas Forschler
  • 5 edits in tags/Safari-600.1.3.40/Source

Versioning.

5:11 PM Changeset in webkit [171780] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.3.40

New Tag.

4:23 PM Changeset in webkit [171779] by bshafiei@apple.com
  • 5 edits
    9 copies in tags/Safari-600.1.3.3

Merged r171661. <rdar://problem/17315237>

4:16 PM Changeset in webkit [171778] by bshafiei@apple.com
  • 7 edits in tags/Safari-600.1.3.3/Source

Merged r171647. <rdar://problem/17315168>

4:08 PM Changeset in webkit [171777] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.1.3.3/Source

Versioning.

4:05 PM Changeset in webkit [171776] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.3.3

New tag.

4:01 PM Changeset in webkit [171775] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

WKPDFView paints rotated pages squished
​https://bugs.webkit.org/show_bug.cgi?id=135401
<rdar://problem/17173916>

Reviewed by Simon Fraser.

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _computePageAndDocumentFrames]):
[page size] returns the crop box's size, ignoring rotation.
[page cropBoxAccountForRotation] respects rotation, but otherwise returns the same size.
UIPDFPageView will respect rotation when painting, so we
should make sure that it is given an aspect ratio that also
respects rotation, so that the page isn't squished.

3:52 PM Changeset in webkit [171774] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

3:46 PM Changeset in webkit [171773] by matthew_hanson@apple.com
  • 3 edits
    4 deletes in branches/safari-600.1.4-branch

r171675. <rdar://problem/17826572>

3:41 PM Changeset in webkit [171772] by ap@apple.com
  • 5 edits in trunk

fast/borders/border-radius-on-subpixel-position-non-hidpi.html fails on Retina machines
​https://bugs.webkit.org/show_bug.cgi?id=135398

Reviewed by Zalan Bujtas.

Tools:

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::updateWindowScaleForTest):

"hidpi-" should be at the start. This allows "hidpi-" in both file and directory names.

  • DumpRenderTree/mac/DumpRenderTree.mm: (changeWindowScaleIfNeeded): Same fix.

For some reason, I wasn't seeing this test fail on WK1 even without the fix, not
sure why.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Let's try to unskip the test, maybe this was

the actual reason for it to appear failing?

3:41 PM Changeset in webkit [171771] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.5

New Tag.

3:40 PM Changeset in webkit [171770] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Rollout r171702. <rdar://problem/16828238>

3:38 PM Changeset in webkit [171769] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Rollout r171703. <rdar://problem/17833422>

3:35 PM Changeset in webkit [171768] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source/WebCore

Rollout r171708. <rdar://problem/17844894>

2:49 PM Changeset in webkit [171767] by mmirman@apple.com
  • 3 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Added SkipTopScope coverage to FTL

2:41 PM Changeset in webkit [171766] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] REGRESSION(r171526): PDF documents fail to load in WebKit1 with disk image caching enabled
​https://bugs.webkit.org/show_bug.cgi?id=135359
<rdar://problem/17824645>

Reviewed by Darin Adler.

r171526 broke the case where we have a memory mapped file from the DiskImageCache in the
SharedBuffer. In such a case, m_buffer is empty and createCFData() returned an
WebCoreSharedBufferData with an empty buffer.

Fix this by taking the easy route of bringing back the old code for the disk image cache
file backed case. In the long run we probably want to remove the iOS specific disk image
cache anyway.

Review also uncovered another bug in r171526 where we were balancing an Objective-C alloc
with a CFRelease which is incorrect when running under GC. Fix that by using adoptNS along
with adoptCF which is what the code did before.

No new tests because the bug only occurs on device and we can't run tests on device yet.

  • platform/mac/SharedBufferMac.mm:

(-[WebCoreSharedBufferData initWithDiskImageSharedBuffer:]):
(-[WebCoreSharedBufferData length]):
(-[WebCoreSharedBufferData bytes]):
(WebCore::SharedBuffer::createCFData):

2:25 PM Changeset in webkit [171765] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171748. <rdar://problem/17356958>

2:03 PM Changeset in webkit [171764] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171711. <rdar://problem/17756281>

2:03 PM Changeset in webkit [171763] by mhahnenberg@apple.com
  • 7 edits in branches/ftlopt/Source/JavaScriptCore

Support for-in in the FTL
​https://bugs.webkit.org/show_bug.cgi?id=134140

Reviewed by Filip Pizlo.

  • dfg/DFGSSALoweringPhase.cpp:

(JSC::DFG::SSALoweringPhase::handleNode):

  • ftl/FTLAbstractHeapRepository.cpp:
  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileHasIndexedProperty):
(JSC::FTL::LowerDFGToLLVM::compileHasGenericProperty):
(JSC::FTL::LowerDFGToLLVM::compileHasStructureProperty):
(JSC::FTL::LowerDFGToLLVM::compileGetDirectPname):
(JSC::FTL::LowerDFGToLLVM::compileGetEnumerableLength):
(JSC::FTL::LowerDFGToLLVM::compileGetStructurePropertyEnumerator):
(JSC::FTL::LowerDFGToLLVM::compileGetGenericPropertyEnumerator):
(JSC::FTL::LowerDFGToLLVM::compileGetEnumeratorPname):
(JSC::FTL::LowerDFGToLLVM::compileToIndexString):

2:00 PM Changeset in webkit [171762] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebKit2

Merge r171709. rdar://problem/16988887>

1:59 PM Changeset in webkit [171761] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171708. <rdar://problem/17844894>

1:57 PM Changeset in webkit [171760] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171703. <rdar://problem/17833422>

1:56 PM Changeset in webkit [171759] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171702. <rdar://problem/16828238>

1:54 PM Changeset in webkit [171758] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source/WebCore

Merge r171700. <rdar://problem/17844901>

1:36 PM Changeset in webkit [171757] by matthew_hanson@apple.com
  • 2 edits
    2 copies in branches/safari-600.1.4-branch/Source/JavaScriptCore

Merge r171689. <rdar://problem/17844890>

1:33 PM Changeset in webkit [171756] by ap@apple.com
  • 2 edits in trunk/Tools

PPT: run-webkit-tests doesn't upload crash logs to bots
​https://bugs.webkit.org/show_bug.cgi?id=135391

Reviewed by Joseph Pecoraro.

  • WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):

Not a fix to be proud of, but better than not having it work at all.

1:32 PM Changeset in webkit [171755] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1.4-branch/Source/JavaScriptCore

Merge r171688. <rdar://problem/17364180>

1:26 PM Changeset in webkit [171754] by matthew_hanson@apple.com
  • 3 edits
    4 copies in branches/safari-600.1.4-branch

Merge r171675. <rdar://problem/17826572>

1:08 PM Changeset in webkit [171753] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF for !ENABLE(DATABASE_PROCESS) platforms.

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManager::deleteAllEntries):

12:34 PM Changeset in webkit [171752] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

VisitedLinkState::determineLinkState should take a reference
​https://bugs.webkit.org/show_bug.cgi?id=135375

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-29
Reviewed by Sam Weinig.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initElement):

  • dom/VisitedLinkState.h:

(WebCore::VisitedLinkState::determineLinkState):

12:00 PM Changeset in webkit [171751] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source

Versioning.

11:57 AM Changeset in webkit [171750] by matthew_hanson@apple.com
  • 1 copy in branches/safari-600.1.4-branch

New Branch.

10:37 AM Changeset in webkit [171749] by beidson@apple.com
  • 11 edits in trunk/Source

Make WKOriginDataManager actually operate on IndexedDatabases.
​https://bugs.webkit.org/show_bug.cgi?id=135346

Reviewed by Sam Weinig (and David Kilzer and Alex Christensen)

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::getIndexedDatabaseOrigins):
(WebKit::DatabaseProcess::doGetIndexedDatabaseOrigins):
(WebKit::removeAllDatabasesForOriginPath): Utility to delete all database files for the given origin path

that have been modified between the given dates.

(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigin):
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesForOrigin):
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::deleteAllIndexedDatabaseEntries):
(WebKit::DatabaseProcess::doDeleteAllIndexedDatabaseEntries):

  • DatabaseProcess/DatabaseProcess.h:
  • Shared/WebCrossThreadCopier.cpp:

(WebCore::SecurityOriginData>::copy):

  • Shared/WebCrossThreadCopier.h:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::getOrigins):
(WebKit::WebOriginDataManagerProxy::didGetOrigins):
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):
(WebKit::WebOriginDataManagerProxy::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManagerProxy::deleteAllEntries):

  • WebProcess/OriginData/WebOriginDataManager.cpp:

(WebKit::WebOriginDataManager::getOrigins): Pipe IDB requests through to the DatabaseProcess.
(WebKit::WebOriginDataManager::deleteEntriesForOrigin): Ditto.
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates): Ditto.
(WebKit::WebOriginDataManager::deleteAllEntries): Ditto.

10:23 AM Changeset in webkit [171748] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Unreviewed, rolling out r171704.
​https://bugs.webkit.org/show_bug.cgi?id=135389

Broke two IndexedDB tests (Requested by ap on #webkit).

Reverted changeset:

"IDB transactions never reset if the Web Process ends before
cleaning up"
​https://bugs.webkit.org/show_bug.cgi?id=135218
​http://trac.webkit.org/changeset/171704

9:40 AM Changeset in webkit [171747] by mitz@apple.com
  • 7 edits
    2 adds in trunk/Source/WebCore

Moved the Cocoa-specific parts of CredentialBase into a Cocoa-specific Credential class.
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Alexey Proskuryakov.

No change in functionality.

  • WebCore.exp.in: Updated for functions moved in the class hierarchy.
  • WebCore.xcodeproj/project.pbxproj: Added CredentialCocoa.{h,mm}.
  • platform/network/Credential.h: For Cocoa, include CredentialCocoa.h instead of the generic

class.
(WebCore::Credential::Credential): Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED code.

  • platform/network/CredentialBase.cpp:

(WebCore::CredentialBase::CredentialBase): Changed to use emptyString instead of "", removed
#if CERTIFICATE_CREDENTIALS_SUPPORTED code.
(WebCore::CredentialBase::isEmpty): Ditto.
(WebCore::CredentialBase::compare): Renamed operator== to this, removed
#if CERTIFICATE_CREDENTIALS_SUPPORTED code, but changed the end to call platformCompare.
(WebCore::CredentialBase::identity): Deleted.
(WebCore::CredentialBase::certificates): Deleted.
(WebCore::CredentialBase::type): Deleted.

  • platform/network/CredentialBase.h: Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED members.

(WebCore::CredentialBase::platformCompare): Added a base implementation that returns true.
(WebCore::operator==): Changed to use CredentialBase::compare.

  • platform/network/cocoa/CredentialCocoa.h: Added.

(WebCore::Credential::Credential):

  • platform/network/cocoa/CredentialCocoa.mm: Added.

(WebCore::Credential::Credential): Moved the constructor that takes an identity and
certificates here.
(WebCore::Credential::isEmpty): Moved here.
(WebCore::Credential::identity): Ditto.
(WebCore::Credential::certificates): Ditto.
(WebCore::Credential::type): Ditto.
(WebCore::Credential::platformCompare): Moved the code that compares client-certificate
credentials here.

  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac): Removed #if CERTIFICATE_CREDENTIALS_SUPPORTED guards in this Cocoa-only
file.
(WebCore::core): Ditto.

8:47 AM Changeset in webkit [171746] by dbates@webkit.org
  • 11 edits in trunk/Source

Use WTF::move() instead of std::move() to help ensure move semantics
​https://bugs.webkit.org/show_bug.cgi?id=135351

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):

Source/WebCore:

  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):

Source/WebKit2:

  • UIProcess/API/Cocoa/_WKSessionState.mm:

(-[_WKSessionState _initWithSessionState:]):

  • UIProcess/API/gtk/WebKitUserContent.cpp:

(toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::mouseEvent):

Source/WTF:

  • wtf/HashTable.h:

(WTF::KeyTraits>::HashTable):

8:11 AM Changeset in webkit [171745] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
​https://bugs.webkit.org/show_bug.cgi?id=135385

Reviewed by Andrei Bucur.

Source/WebCore:
When a region-based multicolumn element is displayed and hit tested in a region,
we have to disable the named flow region information not only for painting,
but also for hit-testing. This is a follow-up for ​https://bugs.webkit.org/show_bug.cgi?id=132121,
which provided the fix for painting.

Test: fast/regions/assert-hit-test-multicol-in-region.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestLayer):

LayoutTests:

  • fast/regions/assert-hit-test-multicol-in-region-expected.txt: Added.
  • fast/regions/assert-hit-test-multicol-in-region.html: Added.
7:51 AM Changeset in webkit [171744] by Alan Bujtas
  • 8 edits
    1 add in trunk/Source/WebCore

Cleanup RenderSelectionInfoBase/RenderSelectionInfo/RenderBlockSelectionInfo.
​https://bugs.webkit.org/show_bug.cgi?id=135326

Reviewed by Darin Adler.

  1. Move implementation to RenderSelectInfo.cpp
  2. RenderSelectionInfoBase/RenderSelectionInfo/RenderBlockSelectionInfo take Render* reference.
  3. Remove unused functions.
  4. Add RenderSelectionInfoBase::repaintRectangle()

No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSelectionInfo.cpp: Added.

(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase):
(WebCore::RenderSelectionInfoBase::repaintRectangle):
(WebCore::RenderSelectionInfo::RenderSelectionInfo):
(WebCore::RenderSelectionInfo::repaint):
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo):
(WebCore::RenderBlockSelectionInfo::repaint):

  • rendering/RenderSelectionInfo.h:

(WebCore::RenderSelectionInfo::collectedSelectionRects):
(WebCore::RenderSelectionInfoBase::RenderSelectionInfoBase): Deleted.
(WebCore::RenderSelectionInfoBase::object): Deleted.
(WebCore::RenderSelectionInfo::RenderSelectionInfo): Deleted.
(WebCore::RenderSelectionInfo::repaint): Deleted.
(WebCore::RenderSelectionInfo::rects): Deleted.
(WebCore::RenderBlockSelectionInfo::RenderBlockSelectionInfo): Deleted.
(WebCore::RenderBlockSelectionInfo::repaint): Deleted.
(WebCore::RenderBlockSelectionInfo::block): Deleted.

  • rendering/RenderView.cpp:

(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):

7:35 AM Changeset in webkit [171743] by psolanki@apple.com
  • 20 edits in trunk/Source

Get SharedBuffer.h out of ResourceBuffer.h (and a few other places)
​https://bugs.webkit.org/show_bug.cgi?id=131782

Original patch by Tim Horton.
Reviewed by Darin Adler.

Source/WebCore:
No new tests because no functional changes.

  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBCursorBackend.h:
  • loader/ios/DiskImageCacheIOS.h:

Forward declare SharedBuffer in headers.

  • Modules/indexeddb/IDBRequest.cpp:
  • loader/cache/CachedImage.cpp:
  • loader/icon/IconLoader.cpp:
  • loader/ios/DiskImageCacheIOS.mm:
  • loader/cache/MemoryCache.cpp:
  • loader/mac/ResourceBuffer.mm:

Include SharedBuffer.h in implementation files.

  • Modules/notifications/Notification.h:
  • loader/appcache/ApplicationCacheGroup.h:

Remove unnecessary includes.

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::adoptSharedBuffer):

  • loader/ResourceBuffer.h:

Out-of-line adoptSharedBuffer so that the PassRefPtr doesn't require including SharedBuffer.h.

  • platform/graphics/opentype/OpenTypeMathData.cpp:
  • platform/graphics/opentype/OpenTypeMathData.h:

Out-of-line destructor to avoid requiring SharedBuffer.h for the RefPtr.
Forward-declare SharedBuffer in the header, include in implementation.

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:
  • WebProcess/Network/NetworkProcessConnection.cpp:

Include SharedBuffer.h in implementation files.

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:

Un-indent namespace and remove SharedBuffer forward-declaration.

5:42 AM Changeset in webkit [171742] by commit-queue@webkit.org
  • 18 edits
    4 deletes in trunk

[GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=133729

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-07-29
Reviewed by Carlos Garcia Campos.

Removes WebKitWebViewGroup, effectively reverting the changes
introduced by r149117. The motivation for WebKitWebViewGroup
was using the user style sheet injection API, which has been
moved into WebKitUserContentManager, rendering it unneeded.

Source/WebKit2:

  • PlatformGTK.cmake: Remove WebKitWebViewGroup source files

from the build.

  • UIProcess/API/C/gtk/WKView.cpp:

(WKViewCreate): Accomodate for changes in the signature of
webkitWebViewBaseCreate().

  • UIProcess/API/gtk/WebKitSettings.cpp: Update API documentation.
  • UIProcess/API/gtk/WebKitWebContext.cpp: Remove the default web

view group from WebKitWebContext.
(webkitWebContextCreatePageForWebView): Allow passing a
WebPreferences object at construction.
(webkitWebContextGetDefaultWebViewGroup): Deleted.

  • UIProcess/API/gtk/WebKitWebContextPrivate.h: Ditto.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewUpdateSettings): Use WebPageProxy::setPreferences()
directly. Handle the case when webkit_web_view_set_settings()
is called on construction by doing an early-return.
(webkitWebViewConstructed): Call webkitWebViewUpdateSettings()
after creating the internal WebPageProxy object.
(webkitWebViewSetProperty): Removed "group" property, added
"settings" property.
(webkitWebViewGetProperty): Ditto.
(webkitWebViewDispose): Do not disconnect signal handler for
the (now unexistant) WebKitWebViewGroup.
(webkit_web_view_class_init): Removed "group" property, added
"settings" property.
(webkitWebViewHandleAuthenticationChallenge): Access the
WebKitWebSettings directly.
(webkit_web_view_new_with_related_view): Make new views share
settings with their related view.
(webkit_web_view_new_with_settings): Added.
(webkit_web_view_set_settings): Access the settings directly in
the WebKitWebView.
(webkit_web_view_get_settings): Ditto.
(webkit_web_view_set_zoom_level): Ditto.
(webkit_web_view_get_zoom_level): Ditto.
(webkitWebViewSettingsChanged): Deleted.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Deleted.
(webkit_web_view_new_with_group): Deleted.
(webkit_web_view_get_group): Deleted.

  • UIProcess/API/gtk/WebKitWebView.h: Removed API methods related

to WebKitWebViewGroup.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseCreate): Allow passing a WebPreferences object
for constructing the WebPageProxy.
(webkitWebViewBaseUpdatePreferences): Instead of going through
the page group, use WebPageProxy::preferences() directly.
(webkitWebViewBaseCreateWebPage): Allow passing a WebPreferences
object for constructing the WebPageProxy.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Update the

prototypes of the internal functions.

  • UIProcess/API/gtk/WebKitWebViewGroup.cpp: Removed.
  • UIProcess/API/gtk/WebKitWebViewGroup.h: Removed.
  • UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Removed.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Change public API

bits in the documentation.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Ditto.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Ditto.
  • UIProcess/API/gtk/webkit2.h: Removed WebKitWebViewGroup.h header.
  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Accomodate for changes in the signature of
webkitWebViewBaseCreate().

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Remove tests

for WebKitWebViewGroup.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewSettings):
Restore the assertions that check that settings objects are
released. Add test for webkit_web_view_new_with_settings().

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Removed.
4:41 AM Changeset in webkit [171741] by commit-queue@webkit.org
  • 3 edits in trunk

[EFL][GTK] Remove ACCELERATED_COMPOSITING compile flag
​https://bugs.webkit.org/show_bug.cgi?id=135376

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-07-29
Reviewed by Gyuyoung Kim.

ACCELERATED_COMPOSITING was changed to the mandatory code after r163079.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
4:35 AM Changeset in webkit [171740] by Carlos Garcia Campos
  • 12 edits in trunk

Implement webkit_web_view_load_string() in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=134735

Reviewed by Sergio Villar Senin.

Source/WebKit2:
Add webkit_web_view_load_bytes() that receives a GBytes to load
random data in the web view using the given MIME-Type, encoding
and base URL.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(releaseGBytes):
(webkit_web_view_load_bytes):

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt:

Tools:
Add /webkit2/WebKitWebView/load-bytes test case and simplify
TestDOMXPathNSResolver by using webkit_web_view_load_bytes()
instead of a soup server just to sent the Content-type header.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:

(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(serverCallback): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:

(testLoadBytes):
(beforeAll):

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:

(LoadTrackingTest::loadBytes):

  • TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::loadBytes):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1:52 AM Changeset in webkit [171739] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171721. <rdar://problem/17836658>

1:50 AM Changeset in webkit [171738] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171720. <rdar://problem/17838230>

1:49 AM Changeset in webkit [171737] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r171716. <rdar://problem/17835401>

1:47 AM Changeset in webkit [171736] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171711. <rdar://problem/17756281>

1:45 AM Changeset in webkit [171735] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171709. <rdar://problem/16988887>

1:41 AM Changeset in webkit [171734] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171708. <rdar://problem/17768371>

1:38 AM Changeset in webkit [171733] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171706. <rdar://problem/17295639>

1:36 AM Changeset in webkit [171732] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r171704. <rdar://problem/17356958>

1:34 AM Changeset in webkit [171731] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171703. <rdar://problem/17833422>

1:32 AM Changeset in webkit [171730] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171702. <rdar://problem/16828238>

1:29 AM Changeset in webkit [171729] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source/WebCore

Merged r171700. <rdar://problem/15317278>

1:27 AM Changeset in webkit [171728] by Lucas Forschler
  • 2 edits
    2 copies in branches/safari-600.1-branch/Source/JavaScriptCore

Merged r171689. <rdar://problem/17509889>

1:23 AM Changeset in webkit [171727] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/JavaScriptCore

Merged r171688. <rdar://problem/17364180>

1:18 AM Changeset in webkit [171726] by Lucas Forschler
  • 3 edits
    4 copies in branches/safari-600.1-branch

Merged r171675. <rdar://problem/17826572>

1:12 AM Changeset in webkit [171725] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
​https://bugs.webkit.org/show_bug.cgi?id=135237

Reviewed by Martin Robinson.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h: The boxSize parameter of the

addAnimation() method must be of the same type as the parameter in the base class
declaration -- a const FloatSize reference. Only then is the base virtual method
actually overriden.

12:52 AM Changeset in webkit [171724] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL] Alpha value of ewk_view_bg_color_set is not working
​https://bugs.webkit.org/show_bug.cgi?id=135333

Reviewed by Gyuyoung Kim.

evas_object_image_alpha_set should be called for the transparent evas object.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::handleEvasObjectColorSet):
(EwkView::setBackgroundColor): Checked the alpha value of object and called evas_object_image_alpha_set.

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_bg_color_set): Moved the logic to EwkView.

Jul 28, 2014:

11:57 PM Changeset in webkit [171723] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix.

  • WebCore.exp.in:
9:22 PM Changeset in webkit [171722] by mitz@apple.com
  • 7 edits
    1 copy
    1 move in trunk/Source/WebCore

Introduced CredentialBase and made Credential derive from it
Work towards fixing ​https://bugs.webkit.org/show_bug.cgi?id=135327

Reviewed by Darin Adler.

No change in functionality.

  • CMakeLists.txt: Updated for source file rename.
  • WebCore.exp.in: Changed to export CredentialBase symbols.
  • WebCore.vcxproj/WebCore.vcxproj: Updated for source file rename and new header.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/network/Credential.cpp: Renamed to CredentialBase.cpp.
  • platform/network/Credential.h: Defined Credential to derive from CredentialBase.
  • platform/network/CredentialBase.cpp: Renamed Credential.cpp to this. Updated for the new

name.

  • platform/network/CredentialBase.h: Copied from Credential.h, renamed the class to

CredentialBase, and made the constructors protected.

9:17 PM Changeset in webkit [171721] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Incorrectly sized TimelineDataGrid event bubble
​https://bugs.webkit.org/show_bug.cgi?id=135371

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-28
Reviewed by Timothy Hatcher.

Previously the secondsPerPixel calculation was relying on an element
that may not be sized yet. This was resulting in a visibleWidth of 0
and resulted in secondsPerPixel being Infinity. Fortunately, the
graph data source already knows the secondsPerPixel so we can just
ask it. Getting the correct value and eliminating forced layouts.

  • UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.get secondsPerPixel):

  • UserInterface/Views/TimelineDataGridNode.js:
9:14 PM Changeset in webkit [171720] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce work creating the initial WebInspector.TimelineRecordBar
​https://bugs.webkit.org/show_bug.cgi?id=135373

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-28
Reviewed by Timothy Hatcher.

Eliminate a bit of extra work creating TimelineRecordBars. Previously
the constructor would setup an empty list of records, and then we would
immediately after replace them. Now just set them in the constructor.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:

(WebInspector.LayoutTimelineOverviewGraph.prototype.updateLayout.createBar):
(WebInspector.LayoutTimelineOverviewGraph.prototype.updateLayout):

  • UserInterface/Views/NetworkTimelineOverviewGraph.js:

(WebInspector.NetworkTimelineOverviewGraph.prototype.updateLayout.createBar):
(WebInspector.NetworkTimelineOverviewGraph.prototype.updateLayout):

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout.createBar):
(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):

  • UserInterface/Views/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode.prototype.refreshGraph.createBar):

7:11 PM Changeset in webkit [171719] by tgergely.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

BuildFix: JavaScriptCore/bytecode/StructureSet.h:262:77: warning.
​https://bugs.webkit.org/show_bug.cgi?id=135287

Reviewed by Darin Adler.

The set() method tries to use a part of the old value (the reservedFlag bit) which
was not defined when the constructor is called. Initialize m_pointer to 0 explicitely.

  • bytecode/StructureSet.h:

(JSC::StructureSet::StructureSet):

6:45 PM Changeset in webkit [171718] by Alan Bujtas
  • 8 edits
    2 adds in trunk

REGRESSION(r164133): Selection disappears after scrolling on nytimes.com
​https://bugs.webkit.org/show_bug.cgi?id=135361

Reviewed by Ryosuke Niwa.

Ensure that when a RenderElement, part of the current selection is removed,
we recalculate and update the selection soon after layout.

Source/WebCore:
Test: fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setNeedsSelectionUpdate):
(WebCore::FrameSelection::didLayout): didLayout name reflects its functionality better.
(WebCore::FrameSelection::layoutDidChange): Deleted.

  • editing/FrameSelection.h: : move some functions to private.
  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::removeChildInternal):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):

LayoutTests:

  • fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed-expected.html: Added.
  • fast/dynamic/selection-gets-cleared-when-part-of-it-gets-removed.html: Added.
6:03 PM Changeset in webkit [171717] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

5:58 PM Changeset in webkit [171716] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Unexpected dark border on selected but window inactive timeline
​https://bugs.webkit.org/show_bug.cgi?id=135360

Update the border-top colors for the item adjacent to the selected item.

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):

5:56 PM Changeset in webkit [171715] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

Web process crash causes UI process to die with an assertion failure in Connection::exceptionSourceEventHandler
​https://bugs.webkit.org/show_bug.cgi?id=135366

Reviewed by Dan Bernstein.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::exceptionSourceEventHandler): Remove the assertion since it frequently fires during
normal development with debug builds.

5:51 PM Changeset in webkit [171714] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-600.1.3.2/Source

Versioning.

5:11 PM Changeset in webkit [171713] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-600.1.3.2/Source

Merge r171635. <rdar://problem/17782407>

5:02 PM Changeset in webkit [171712] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.3.2

New Tag.

4:57 PM Changeset in webkit [171711] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[Media iOS] Touching play button feels unresponsive
​https://bugs.webkit.org/show_bug.cgi?id=135370
<rdar://problem/17756281>

Reviewed by Simon Fraser.

Add an :active rule that shows a slightly darker button when touched.

  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-start-playback-button:active):

4:52 PM Changeset in webkit [171710] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable Copy Row in Timelines DataGrids, it does not currently provide value
​https://bugs.webkit.org/show_bug.cgi?id=135364

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-28
Reviewed by Timothy Hatcher.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGridNode):
(WebInspector.DataGridNode.prototype.get copyable):
(WebInspector.DataGridNode.prototype.set copyable):

  • UserInterface/Views/TimelineDataGridNode.js:

(WebInspector.TimelineDataGridNode):

4:47 PM Changeset in webkit [171709] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS WK2] WKWebView sometime tries to change the size of a null DrawingAreaProxy
​https://bugs.webkit.org/show_bug.cgi?id=135368
<rdar://problem/16988887>

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-28
Reviewed by Simon Fraser.

We should never assume DrawingAreaProxy exists in the API invoked by the clients
of WKWebView. There are at least two cases where the DrawingAreaProxy is null:
-In some path on initialization.
-After a crash.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
We can safely null check and skip setting the size. If the call was skipped,
the size is set on DrawingAreaProxy initialization by querying the current
size through the page client.

4:14 PM Changeset in webkit [171708] by beidson@apple.com
  • 5 edits in trunk/Source/WebCore

REGRESSION(168376): Standalone images pasted to Outlook 2011 don't display
<rdar://problem/17768371> and ​https://bugs.webkit.org/show_bug.cgi?id=135363

Reviewed by Tim Horton.

Outlook isn’t prepared to handle the resource load callbacks when sent synchronously.

r168376 was an optimization that we no longer need, so the simplest fix is to roll it out.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::WebContentReader::readImage):

  • loader/archive/ArchiveResource.cpp:

(WebCore::ArchiveResource::ArchiveResource):

  • loader/archive/ArchiveResource.h:

(WebCore::ArchiveResource::setShouldLoadImmediately): Deleted.
(WebCore::ArchiveResource::shouldLoadImmediately): Deleted.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

3:47 PM Changeset in webkit [171707] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.4

New Tag.

3:32 PM Changeset in webkit [171706] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebKit2

Disable tagged strings for the plugin process.
​https://bugs.webkit.org/show_bug.cgi?id=135354
<rdar://problem/17295639>.

Patch by Alexey Proskuryakov and Roger Fong.

Reviewed by Anders Carlsson.

  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToReExecService):

3:29 PM Changeset in webkit [171705] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] JIT::assertStackPointerOffset() crashes on ARM64
​https://bugs.webkit.org/show_bug.cgi?id=135316

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-07-28
Reviewed by Geoffrey Garen.

JIT::assertStackPointerOffset() does a compare between an arbitrary register
and the stack pointer. This was not supported by the ARM64 assembler.

There are no variation that can take a stack pointer for Xd. There is one version of subs
that can take a stack pointer, but only for the Xn: the shift+extend one.
To solve the problem, I changed cmp to swap the registers if necessary, and I fixed
the implementation of sub.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::sub):
In the generic sub(reg, reg), I added assertions to catch the condition that cannot be generated
with either version of sub.

In sub(with shift), I remove the weird special case for SP. First, it was quite misleading because
the Rd case only works if "setflag == false". The other confusing part is going to addSubtractShiftedRegister()
gives you a reduce shift range, which could create subtle bug that only appear when SP is used.

Since I removed the weird case, I need to differentiate between the sub() that support SP, and the one that does
not elsewhere. That is why that branch has moved to the generic sub(reg, reg). Since at that point we know
the shift value must be zero, it is safe to call either variant.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::branch64):
With the changes described above, we can now use SP for the left register. What do we do if the rightmost
register is SP?

For the case of JIT::assertStackPointerOffset(), the comparison is Equal so the order really does not matter,
we just switch the registers before generating the instruction.

For the generic case, just move the value of SP to a GPR before doing the CMP.

3:26 PM Changeset in webkit [171704] by jpfau@apple.com
  • 5 edits in trunk/Source/WebKit2

IDB transactions never reset if the Web Process ends before cleaning up
​https://bugs.webkit.org/show_bug.cgi?id=135218

Reviewed by Darin Adler.

  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::didClose):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::didCompleteTransactionOperation):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::didEstablishTransaction):
(WebKit::UniqueIDBDatabase::didResetTransaction):
(WebKit::UniqueIDBDatabase::resetAllTransactions):
(WebKit::UniqueIDBDatabase::finalizeRollback):
(WebKit::UniqueIDBDatabase::absoluteDatabaseDirectory):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::rollbackTransaction):

3:19 PM Changeset in webkit [171703] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: m_heap->vm()->currentThreadIsHoldingAPILock()
​https://bugs.webkit.org/show_bug.cgi?id=135352

Reviewed by Oliver Hunt.

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::ensureReplacementScriptInjected): This should be taking a
JSLock like its sibling methods do (e.g. installReplacement).

3:18 PM Changeset in webkit [171702] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

<embed> videos flashes constantly while playing inline on iPad, making it unwatchable
​https://bugs.webkit.org/show_bug.cgi?id=135356
<rdar://problem/16828238>

Reviewed by Simon Fraser.

The shadow tree for media controls is scheduling style recalc. The general silliness of
HTMLPlugInImageElement::willRecalcStyle/willDetachRenderers is turning those into render
tree reconstructions causing flicker.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):

Don't do the forced renderer reconstruction if there is no style change for the element
or its ancestors. This way recalcs scheduled by the shadow tree don't trigger the widget
update code path.

2:58 PM Changeset in webkit [171701] by Brent Fulgham
  • 1 edit in trunk/Source/WebCore/ChangeLog

[Mac, iOS] Paint-on closed captions get out-of-order in Safari
​https://bugs.webkit.org/show_bug.cgi?id=135332
<rdar://problem/15317278>

Reviewed by Jer Noble.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): If the
number of active cues is greater than the current set of CSS boxes representing
the cues, throw away the CSS boxes and re-layout all the cues.

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::addGenericCue): Add some logging.
(WebCore::InbandGenericTextTrack::removeGenericCue): Ditto.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::isOrderedBefore): Revise ordering rules so that we put
newer cues earlier in the layout order so they are drawn towards the bottom
of the screen. Only do this for Generic captions.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Adjust logging
messages.
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues): Add logging.

2:58 PM Changeset in webkit [171700] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

[Mac, iOS] Paint-on closed captions get out-of-order in Safari
​https://bugs.webkit.org/show_bug.cgi?id=135332
<rdar://problem/15317278>

Reviewed by Brent Fulgham.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): If the
number of active cues is greater than the current set of CSS boxes representing
the cues, throw away the CSS boxes and re-layout all the cues.

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::addGenericCue): Add some logging.
(WebCore::InbandGenericTextTrack::removeGenericCue): Ditto.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::isOrderedBefore): Revise ordering rules so that we put
newer cues earlier in the layout order so they are drawn towards the bottom
of the screen. Only do this for Generic captions.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Adjust logging
messages.
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues): Add logging.

2:55 PM Changeset in webkit [171699] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-600.1.2.3/Source/JavaScriptCore

Merge r171680. <rdar://problem/17830040>

2:50 PM Changeset in webkit [171698] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.2.3

New tag.

2:48 PM Changeset in webkit [171697] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/JavaScriptCore

Merge r171680. <rdar://problem/17834136>

2:47 PM Changeset in webkit [171696] by Brian Burg
  • 2 edits in trunk/Source/WTF

Should not export symbols for base64Encode inline adapter methods
​https://bugs.webkit.org/show_bug.cgi?id=135355

Unreviewed build fix.

Fixes the build break introduced by r171682, where a base64Encode
inline adapter method was used in another header, thus creating
multiple definitions of it (and problems with with weak symbols).

  • wtf/text/Base64.h: Remove WTF_EXPORT_PRIVATE for inlined methods.
2:47 PM Changeset in webkit [171695] by andersca@apple.com
  • 2 edits in branches/safari-600.1-branch/LayoutTests

Update test expectations.

  • platform/mac/TestExpectations:
2:07 PM Changeset in webkit [171694] by Brian Burg
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r171682.

  • replay/EncodedValue.h: Don't mark the inlined Vector<char> specialization

as an exported symbol.

1:48 PM Changeset in webkit [171693] by dbates@webkit.org
  • 4 edits in trunk/Tools

Add support for running the Clang static analyzer when building WebKit and JSC
​https://bugs.webkit.org/show_bug.cgi?id=134955

Reviewed by Brent Fulgham.

  • Scripts/build-jsc: Added command line options -[no]-analyze (disabled by default).
  • Scripts/build-webkit: Add --analyze command line option to build-webkit to enable

running the Clang static analyzer.

  • Scripts/webkitdirs.pm:

(XcodeStaticAnalyzerOption): Added.

1:44 PM Changeset in webkit [171692] by akling@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION (r160806): CSS zoom property doesn't work on anything inside anchors.
<​https://webkit.org/b/135344>
<rdar://problem/17759577>

Source/WebCore:
When DeprecatedStyleBuilder applies the CSS zoom property (ApplyPropertyZoom)
it first resets the "effective zoom" by calling RenderStyle::setEffectiveZoom().

This mechanism was not resistent to being called multiple times, due to the
optimization in RenderStyle::setZoom() to avoid copy-on-writing the shared data
when setting some property to the already-set value.

The bug would happen in this sequence:

ApplyPropertyZoom:

  • setEffectiveZoom(1);
  • setZoom(2); this updates the effective zoom

ApplyPropertyZoom:

  • setEffectiveZoom(1);
  • setZoom(2); this doesn't update the effective zoom

When we run the second setZoom(2); call, the RenderStyle's zoom value is 2
already and we'll early return without updating the effective zoom.

This change moves the updating of the effective zoom in setZoom() to take place
before the early return due to overwriting with the same value.

Note: the fact that we're apply the zoom property twice is an inefficiency that
we should figure out a way to avoid in the future.

Reviewed by Simon Fraser.

Test: fast/css/zoom-inside-link.html

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setZoom):

LayoutTests:
Reviewed by Simon Fraser.

  • fast/css/zoom-inside-link-expected.html: Added.
  • fast/css/zoom-inside-link.html: Added.
1:43 PM Changeset in webkit [171691] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

REGRESSION: JSObjectSetPrototype() does not work on result of JSGetGlobalObject()
​https://bugs.webkit.org/show_bug.cgi?id=135322

Reviewed by Oliver Hunt.

The prototype chain of the JSProxy object should match that of the JSGlobalObject.

This is a separate but related issue with JSObjectSetPrototype which doesn't correctly
account for JSProxies. I also audited the rest of the C API to check that we correctly
handle JSProxies in all other situations where we expect a JSCallbackObject of some sort
and found some SPI calls (JSObject*PrivateProperty) that didn't behave correctly when
passed a JSProxy.

I also added some new tests for these cases.

  • API/JSObjectRef.cpp:

(JSObjectSetPrototype):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):

  • API/JSWeakObjectMapRefPrivate.cpp:
  • API/tests/CustomGlobalObjectClassTest.c:

(globalObjectSetPrototypeTest):
(globalObjectPrivatePropertyTest):

  • API/tests/CustomGlobalObjectClassTest.h:
  • API/tests/testapi.c:

(main):

1:41 PM Changeset in webkit [171690] by betravis@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Font Loading] Update Font Loading Code
​https://bugs.webkit.org/show_bug.cgi?id=135340

Reviewed by Antti Koivisto.

Update the Font Loading code to build again, as trunk has evolved
since the feature was originally written. Mostly, this requires
updating the code to work with the new Font representation.

The original tests were enabled only for the Chromium port.
They will need to be updated when the feature is enabled by default.

  • WebCore.xcodeproj/project.pbxproj: Add missing files.
  • css/FontLoader.cpp: Update to new Font representation.

(WebCore::LoadFontCallback::createFromParams):
(WebCore::LoadFontCallback::~LoadFontCallback):
(WebCore::FontLoader::loadFont):
(WebCore::FontLoader::checkFont):
(WebCore::applyPropertyToCurrentStyle):
(WebCore::FontLoader::resolveFontStyle):

1:41 PM Changeset in webkit [171689] by fpizlo@apple.com
  • 2 edits
    2 adds in trunk/Source/JavaScriptCore

Make sure that we don't use non-speculative BooleanToNumber for a speculative Branch
​https://bugs.webkit.org/show_bug.cgi?id=135350
<rdar://problem/17509889>

Reviewed by Mark Hahnenberg and Oliver Hunt.

If we have an exiting node that uses a conversion node, then that exiting node
needs to have a Phantom after it for the the original node. But we can't do that
for Branch because ​https://bugs.webkit.org/show_bug.cgi?id=126778.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::clearPhantomsAtEnd):

  • tests/stress/branch-check-int32-on-boolean-to-number-untyped.js: Added.

(foo):
(test):

  • tests/stress/branch-check-number-on-boolean-to-number-untyped.js: Added.

(foo):
(test):

1:38 PM Changeset in webkit [171688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSContext Inspector: crash when using step-into
​https://bugs.webkit.org/show_bug.cgi?id=135345

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-28
Reviewed by Timothy Hatcher.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::stepInto):
Null check m_listener since it may not be set.

1:03 PM Changeset in webkit [171687] by dfarler@apple.com
  • 7 edits in trunk/Tools

Allow for multiple DumpRenderTree and WebKitTestRunner instances in the iOS Simulator
​https://bugs.webkit.org/show_bug.cgi?id=135272

Reviewed by Simon Fraser.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree): Remove hard-coding of FIFO paths.
(-[DumpRenderTree applicationDidEnterBackground:]): Create background task.
(DumpRenderTreeMain): Set DumpRenderTree as UIApplication delegate.

  • DumpRenderTree/mac/DumpRenderTreeMac.h: bgTask ivar.
  • Scripts/old-run-webkit-tests: Update FIFO paths for ORWT.
  • WebKitTestRunner/TestController.cpp: Remove hard-coding of FIFO paths.
  • WebKitTestRunner/ios/TestControllerIOS.mm: Move dup2 calls to platformInitialize
  • WebKitTestRunner/ios/mainIOS.mm: bgTask ivar.

(-[WebKitTestRunnerApp applicationDidEnterBackground:]): Create background task.
(main): Set WebKitTestRunnerApp as UIApplication delegate.

12:59 PM Changeset in webkit [171686] by dfarler@apple.com
  • 1 edit
    1 add in trunk/Tools

ImageDiff builds for the simulator when running iOS layout tests
​https://bugs.webkit.org/show_bug.cgi?id=135270

Reviewed by Simon Fraser.

  • Scripts/build-imagediff: Added.
12:35 PM Changeset in webkit [171685] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Let WheelEvent wrap a PlatformWheelEvent
​https://bugs.webkit.org/show_bug.cgi?id=135244

WheelEvent now wraps a PlatformWheelEvent. m_directionInvertedFromDevice, as well as m_phase and m_momentumPhase
have been removed, since the information is redundant in PlatformWheelEvent. Note that deltaX and deltaY have
NOT been replaced, since we need double precision instead of float precision.

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-07-28
Reviewed by Beth Dakin.

No new tests, since behavior should not have changed.

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):

  • dom/WheelEvent.h:

(WebCore::WheelEvent::wheelEvent): Returns a non-null pointer to the PlatformWheelEvent iff WheelEvent was initialized by PlatformWheelEvent.
(WebCore::WheelEvent::webkitDirectionInvertedFromDevice): Updated to use PlatformWheelEvent.
(WebCore::WheelEvent::phase): Updated to use PlatformWheelEvent.
(WebCore::WheelEvent::momentumPhase): Updated to use PlatformWheelEvent.

12:31 PM Changeset in webkit [171684] by Brian Burg
  • 6 edits in trunk/Source/JavaScriptCore

Web Replay: auto-decoding of parameterized vector's elements is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=135343

Reviewed by Timothy Hatcher.

Fix an incorrect type argument in EncodingTraits<Vector<T>>::encodeValue
that was using the element's decoded type as the type parameter to
EncodedValue::append<T>. It should instead be the raw type T. This
causes problems when encoding Vector<RefPtr<T>>, as it later tries to
use encoding traits for RefPtr<T> rather than for T.

Fix incorrect generated encoding traits argument for vectors of
RefCounted objects. Updated test to cover this scenario.

  • replay/scripts/CodeGeneratorReplayInputs.py:

(Type.encoding_type_argument):
(VectorType.type_name):
(VectorType):
(VectorType.encoding_type_argument):
(Generator.generate_input_encode_implementation):
(Generator.generate_input_decode_implementation):

  • replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.cpp:
  • replay/scripts/tests/expected/generate-input-with-vector-members.json-TestReplayInputs.h:
  • replay/scripts/tests/generate-input-with-vector-members.json: Updated.
12:22 PM Changeset in webkit [171683] by Brian Burg
  • 5 edits in trunk/Source/JavaScriptCore

Web Replay: incorrect serialization code generated for enum classes inside class scope
​https://bugs.webkit.org/show_bug.cgi?id=135342

Reviewed by Timothy Hatcher.

If an enum class is defined inside of a class scope, then the enum class
cannot be forward-declared and the relevant header should be included.
Some generated code used incorrectly-scoped enum values in this situation.

  • replay/scripts/CodeGeneratorReplayInputs.py:

(Generator.generate_includes.declaration.is):
(Generator.generate_enum_trait_implementation.is):
(Generator.generate_enum_trait_implementation):

Tests:

  • replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.cpp: Rebaselined.
  • replay/scripts/tests/expected/generate-enums-with-same-base-name.json-TestReplayInputs.h: Rebaselined.
  • replay/scripts/tests/generate-enums-with-same-base-name.json: Add enum

class types to this test case.

12:21 PM Changeset in webkit [171682] by Brian Burg
  • 3 edits in trunk/Source/JavaScriptCore

Web Replay: vectors of characters should be base64-encoded
​https://bugs.webkit.org/show_bug.cgi?id=135341

Reviewed by Timothy Hatcher.

Without this specialization, encode/decode methods try to create an
array of single characters in JSON, rather than treating the
vector as a binary blob.

  • replay/EncodedValue.cpp:

(JSC::EncodingTraits<Vector<char>>::encodeValue): Added.
(JSC::EncodingTraits<Vector<char>>::decodeValue): Added.

  • replay/EncodedValue.h:
12:02 PM Changeset in webkit [171681] by zoltan@webkit.org
  • 3 edits in trunk/LayoutTests

[CSS3-Text] Update text-expectations after r171677

Unreviewed.

  • fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt:
  • fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt:
10:40 AM Changeset in webkit [171680] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed build fix.

  • JavaScriptCore.vcxproj/JavaScriptCore.proj: Switch from the 'Rebuild' target for MSBuild

builds to the 'Build' target to avoid a spurious 'clean' in between build steps.

9:09 AM Changeset in webkit [171679] by matthew_hanson@apple.com
  • 6 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merge r171645. <rdar://problem/17818693>

9:02 AM Changeset in webkit [171678] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed 'merge' fix.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

Correct line endings to allow EWS merges again.

8:05 AM Changeset in webkit [171677] by zoltan@webkit.org
  • 10 edits in trunk

[CSS3-Text] Adjust text-justify implementation to the latest spec
​https://bugs.webkit.org/show_bug.cgi?id=135317

Reviewed by Darin Adler.

Source/WebCore:
Text-justify no longer accepts the following values: Inter-ideograph, inter-
cluster, and kashida. This patch removes them and updates the tests as well.

[1] ​http://dev.w3.org/csswg/css-text-3/#propdef-text-justify

Updated existing tests.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify):

  • css/CSSValueKeywords.in:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

  • fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify-inherited.js:
  • fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify.js:
6:19 AM Changeset in webkit [171676] by abucur@adobe.com
  • 8 edits
    2 adds in trunk

REGRESSION (r169105): Crash in selection
​https://bugs.webkit.org/show_bug.cgi?id=134303

Patch by Radu Stavila <​stavila@adobe.com> on 2014-07-28
Reviewed by Mihnea Ovidenie.

Source/WebCore:

When splitting the selection between different subtrees, all subtrees must have their selection cleared before
starting to apply the new selection. Otherwise, when selecting objects in a named flow thread and going up
its containing block chain, we can end up in the view's selection root, which has not yet been updated and so
we get inconsistent data.

To achieve this goal, the selection update was split into a "clear" and an "apply" method. The updateSelectionForSubtrees
method first iterates through all subtrees and performs the "clear" method and then starts all over again
and performs the "apply" method.

Test: fast/regions/selection/crash-deselect.html

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderSelectionInfo.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection):
(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::updateSelectionForSubtrees): Added, clears and re-applies selection for all selection subtrees.
(WebCore::RenderView::clearSubtreeSelection): Added, clears selection and returns previously selected information.
(WebCore::RenderView::applySubtreeSelection): Added, updates the selection status of all objects inside the selection tree, compares old and new data and repaints accordingly.
(WebCore::RenderView::setSubtreeSelection): Deleted.

  • rendering/RenderView.h:
  • rendering/SelectionSubtreeRoot.cpp:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot):

  • rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionSubtreeRoot::OldSelectionData::OldSelectionData):

LayoutTests:

Added test for the crash that occurred in some cases when selecting.

Reviewed by NOBODY (OOPS!).

  • fast/regions/selection/crash-deselect-expected.txt: Added.
  • fast/regions/selection/crash-deselect.html: Added.
2:48 AM Changeset in webkit [171675] by Yusuke Suzuki
  • 3 edits
    4 adds in trunk

CSS: Fix :visited behavior for SubSelectors
​https://bugs.webkit.org/show_bug.cgi?id=135324

Reviewed by Benjamin Poulain.

Disable :visited match for the selectors that has SubSelectors.

Source/WebCore:

Tests: fast/history/nested-visited-test-complex.html

fast/history/sibling-visited-test-complex.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

LayoutTests:
This isSubSelector (context.firstSelectorOfTheFragment == context.selector) is intended to
check relation != CSSSelector::SubSelector.
But since this value belongs to the previous selector and it is tested inside the branch that checks
the next selector isn't SubSelector relation != CSSSelector::SubSelector,
this only matches when the previous selector doesn't has SubSelectors.

  • fast/history/nested-visited-test-complex-expected.txt: Added.
  • fast/history/nested-visited-test-complex.html: Added.
  • fast/history/sibling-visited-test-complex-expected.txt: Added.
  • fast/history/sibling-visited-test-complex.html: Added.
1:41 AM Changeset in webkit [171674] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Followup fix after r171594
​https://bugs.webkit.org/show_bug.cgi?id=135048

Patch by Renato Nagy <​nagy.renato@stud.u-szeged.hu> on 2014-07-28
Reviewed by Csaba Osztrogonác.

  • Scripts/sort-export-file: Removed extra newlines from help.

Jul 27, 2014:

11:50 PM Changeset in webkit [171673] by psolanki@apple.com
  • 6 edits in trunk/Source/WebKit

Remove unused preference keys
​https://bugs.webkit.org/show_bug.cgi?id=135280

Reviewed by Darin Adler.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences _setPageCacheSize:]): Deleted.
(-[WebPreferences _pageCacheSize]): Deleted.
(-[WebPreferences _setObjectCacheSize:]): Deleted.
(-[WebPreferences _objectCacheSize]): Deleted.

  • WebView/WebPreferencesPrivate.h:

Source/WebKit/win:

  • WebPreferenceKeysPrivate.h:
11:47 PM Changeset in webkit [171672] by ryuan.choi@samsung.com
  • 1 edit
    1 delete in trunk/Source/WebCore

Remove GraphicsSurfaceGLX.cpp
​https://bugs.webkit.org/show_bug.cgi?id=135279

Reviewed by Darin Adler.

GraphicsSurfaceGLX.cpp is not used since Qt dropped and Efl port changed at r146458

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp: Removed.
7:28 PM Changeset in webkit [171671] by Bruno de Oliveira Abinader
  • 3 edits
    2 adds in trunk

Support for :enabled selector on Anchor & Area elements
​https://bugs.webkit.org/show_bug.cgi?id=134826

Reviewed by Darin Adler.

Source/WebCore:
Updates the PseudoClassEnabled selector checker to check for Anchor & Area
elements with a 'href' attribute.

Spec: ​http://html.spec.whatwg.org/#selector-enabled

Test: fast/css/css-selector-enabled-links.html

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isEnabled): Added check for anchor & area elements.

LayoutTests:
Added tests for :enabled CSS selector on Anchor & Area elements.

  • fast/css/css-selector-enabled-links-expected.txt: Added.
  • fast/css/css-selector-enabled-links.html: Added.
7:24 PM Changeset in webkit [171670] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-600.1.3.1/Source/WebKit2

Merge r171663. <rdar://problem/17818308>

7:16 PM Changeset in webkit [171669] by matthew_hanson@apple.com
  • 5 edits in tags/Safari-600.1.3.1/Source

Versioning.

7:09 PM Changeset in webkit [171668] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.3.1

New Tag.

7:08 PM Changeset in webkit [171667] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[GTK] Keep non-DATABASE_PROCESS build
​https://bugs.webkit.org/show_bug.cgi?id=135321

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-07-27
Reviewed by Gyuyoung Kim.

This is the patch for r171622 in non-DATABASE_PROCESS builds.
Change sendToDatabaseProcessRelaunchingIfNecessary to support non-DATABASE_PROCESS implementation.

  • CMakeLists.txt:
  • UIProcess/WebContext.h:

(WebKit::WebContext::sendToDatabaseProcessRelaunchingIfNecessary):

7:02 PM Changeset in webkit [171666] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed build fix on the EFL port

Build break because of -Werror=return-type

  • bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::oldStructureForTransition):

  • dfg/DFGValueStrength.h:

(JSC::DFG::merge):

5:48 PM Changeset in webkit [171665] by matthew_hanson@apple.com
  • 5 edits
    9 copies in branches/safari-600.1-branch

Merge r171661. <rdar://problem/17315237>

5:45 PM Changeset in webkit [171664] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1-branch/Source/WebKit2

Merge r171663. <rdar://problem/17818308>

4:36 PM Changeset in webkit [171663] by barraclough@apple.com
  • 5 edits in trunk/Source/WebKit2

Don't rely on reading applicationState from within DidEnterBackground/WillEnterForeground
​https://bugs.webkit.org/show_bug.cgi?id=135329
rdar://problem/17818308

Reviewed by Sam Weinig.

API may not be stable.

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewVisible):

  • changed to use -[WKContentView isBackground]
  • UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager init]):

  • split notification handlers

(-[WKProcessAssertionBackgroundTaskManager _applicationWillEnterForeground:]):
(-[WKProcessAssertionBackgroundTaskManager _applicationDidEnterBackground:]):
(-[WKProcessAssertionBackgroundTaskManager _applicationDidEnterBackgroundOrWillEnterForeground:]): Deleted.

  • Assume application is background is after DidEnterBackground, and not after WillEnterForeground
  • UIProcess/ios/WKContentView.h:
    • added isBackground.
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView initWithFrame:context:configuration:webView:]):

  • check applicationState at init.

(-[WKContentView isBackground]):

  • accessor

(-[WKContentView _applicationDidEnterBackground:]):
(-[WKContentView _applicationWillEnterForeground:]):

  • update isBackground
4:35 PM Changeset in webkit [171662] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

[REGRESSION][ftlopt merge][32-bit] stress/prune-multi-put-by-offset-replace-or-transition-variant.js.dfg-eager hits an assertion in SpeculativeJIT::silentSavePlanForGPR
​https://bugs.webkit.org/show_bug.cgi?id=135323

Reviewed by Oliver Hunt.

SpeculativeJIT::silentSavePlanForGPR likes to believe that if a node is a constant,
then it's a constant that can be represented using that node's current DataFormat.
This doesn't work if the constant had been filled as a JSValue, and then one of the
fillSpeculateBlah() methods had speculated that it's of some type that the constant
isn't. Unless fillSpeculateBlah() specifically defends against this case, we'll have
a constant that claims to have a contradictory data format.

This patch fixes such a bug in the 32-bit fillSpeculateCell(). The 64-bit
fillSpeculateCell() appears to not have this bug, but I added a similar defense
mechanism anyway just in case, since this is one of those mistakes that keeps
reappearing.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

4:33 PM Changeset in webkit [171661] by dbates@webkit.org
  • 5 edits
    9 adds in trunk

[WK2] Crash when accessing window.localStorage after calling window.close()
​https://bugs.webkit.org/show_bug.cgi?id=135328
<rdar://problem/17315237>

Reviewed by Sam Weinig.

Source/WebCore:
Fixes an issue where accessing local storage for the first time after calling window.close()
causes a crash.

For now, we should disallow accessing local storage after calling window.close() regardless of
whether it's the first access to local storage as this seems like a bad idiom to support. Note,
this represents a change in behavior from WebKit1. If such usage of window.localStorage turns
out to be reasonable then we can visit this decision again in <​https://bugs.webkit.org/show_bug.cgi?id=135330>.

Tests: storage/domstorage/localstorage/access-storage-after-window-close.html

storage/domstorage/localstorage/access-storage-then-set-value-in-storage-after-window-close.html
storage/domstorage/localstorage/set-value-in-storage-after-window-close.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::localStorage): Modified to only return the cached local storage or
create a new local storage so long as the page isn't being closed. Also, substitute nullptr
for 0.
(WebCore::DOMWindow::close): Call Page::setIsClosing() to mark that the page is closing.

  • page/Page.cpp:

(WebCore::Page::Page): Initialize m_isClosing to false.

  • page/Page.h:

(WebCore::Page::setIsClosing): Added.
(WebCore::Page::isClosing): Added.

LayoutTests:
Added test by Andy Estes, LayoutTests/storage/domstorage/localstorage/access-storage-after-window-close.html,
to ensure that we don't crash when accessing local storage for the first time after calling window.close().

Additionally added tests that ensure that updates to local storage are ignored after calling
window.close() regardless of whether local storage was accessed before the call to window.close().

  • storage/domstorage/localstorage/access-storage-after-window-close-expected.txt: Added.
  • storage/domstorage/localstorage/access-storage-after-window-close.html: Added.
  • storage/domstorage/localstorage/access-storage-then-set-value-in-storage-after-window-close-expected.txt: Added.
  • storage/domstorage/localstorage/access-storage-then-set-value-in-storage-after-window-close.html: Added.
  • storage/domstorage/localstorage/resources/access-storage-close-window-and-set-value-in-storage.html: Added.
  • storage/domstorage/localstorage/resources/close-window-and-access-storage.html: Added.
  • storage/domstorage/localstorage/resources/close-window-and-set-value-in-storage.html: Added.
  • storage/domstorage/localstorage/set-value-in-storage-after-window-close-expected.txt: Added.
  • storage/domstorage/localstorage/set-value-in-storage-after-window-close.html: Added.
4:14 PM Changeset in webkit [171660] by fpizlo@apple.com
  • 93 edits
    54 adds
    3 deletes in trunk

Merge r170090, r170092, r170129, r170141, r170161, r170215, r170275, r170375, r170376, r170382, r170383, r170399, r170436, r170489, r170490, r170556 from ftlopt.

Source/JavaScriptCore:

This fixes the previous mismerge and adds test coverage for the thing that went wrong.

Additional changes listed here:

  • jsc.cpp:

(functionHasCustomProperties): Expose a way of checking hasCustomProperties(), which the DOM relies on. The regression I previously introduced was because this didn't work right. Now we can test it!

  • runtime/Structure.cpp:

(JSC::Structure::Structure): This was supposed to be setDidTransition(true); the last merge had it set to false.

  • tests/stress/has-custom-properties.js: Added. This test failed with the mismerge.

2014-06-27 Michael Saboff <​msaboff@apple.com>


Unreviewed build fix after r169795.


Fixed ASSERT for 32 bit build.


  • dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):


2014-06-24 Saam Barati <​sbarati@apple.com>


Web Inspector: debugger should be able to show variable types
​https://bugs.webkit.org/show_bug.cgi?id=133395


Reviewed by Filip Pizlo.


Increase the amount of type information the VM gathers when directed
to do so. This initial commit is working towards the goal of
capturing, and then showing (via the Web Inspector) type information for all
assignment and load operations. This patch doesn't have the feature fully
implemented, but it ensures the VM has no performance regressions
unless the feature is specifically turned on.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h: (JSC::computeUsesForBytecodeOffset): (JSC::computeDefsForBytecodeOffset):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::finalizeUnconditionally):
  • bytecode/CodeBlock.h:
  • bytecode/Instruction.h:
  • bytecode/TypeLocation.h: Added. (JSC::TypeLocation::TypeLocation):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitMove): (JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity): (JSC::BytecodeGenerator::emitPutToScope): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitPutByVal):
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::isProfilingTypesWithHighFidelity):
  • bytecompiler/NodesCodegen.cpp: (JSC::PostfixNode::emitResolve): (JSC::PrefixNode::emitResolve): (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode): (JSC::ConstDeclNode::emitCodeSingle): (JSC::ForInNode::emitBytecode):
  • heap/Heap.cpp: (JSC::Heap::collect):
  • inspector/agents/InspectorRuntimeAgent.cpp: (Inspector::InspectorRuntimeAgent::getRuntimeTypeForVariableInTextRange):
  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/protocol/Runtime.json:
  • jsc.cpp: (GlobalObject::finishCreation): (functionDumpTypesForAllVariables):
  • llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): (JSC::LLInt::putToScopeCommon):
  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • runtime/HighFidelityLog.cpp: Added. (JSC::HighFidelityLog::initializeHighFidelityLog): (JSC::HighFidelityLog::~HighFidelityLog): (JSC::HighFidelityLog::recordTypeInformationForLocation): (JSC::HighFidelityLog::processHighFidelityLog): (JSC::HighFidelityLog::actuallyProcessLogThreadFunction):
  • runtime/HighFidelityLog.h: Added. (JSC::HighFidelityLog::HighFidelityLog):
  • runtime/HighFidelityTypeProfiler.cpp: Added. (JSC::HighFidelityTypeProfiler::getTypesForVariableInRange): (JSC::HighFidelityTypeProfiler::getGlobalTypesForVariableInRange): (JSC::HighFidelityTypeProfiler::getLocalTypesForVariableInRange): (JSC::HighFidelityTypeProfiler::insertNewLocation): (JSC::HighFidelityTypeProfiler::getLocationBasedHash):
  • runtime/HighFidelityTypeProfiler.h: Added.
  • runtime/Options.h:
  • runtime/Structure.cpp: (JSC::Structure::toStructureShape):
  • runtime/Structure.h:
  • runtime/SymbolTable.cpp: (JSC::SymbolTable::SymbolTable): (JSC::SymbolTable::cloneCapturedNames): (JSC::SymbolTable::uniqueIDForVariable): (JSC::SymbolTable::uniqueIDForRegister): (JSC::SymbolTable::globalTypeSetForRegister): (JSC::SymbolTable::globalTypeSetForVariable):
  • runtime/SymbolTable.h: (JSC::SymbolTable::add): (JSC::SymbolTable::set):
  • runtime/TypeSet.cpp: Added. (JSC::TypeSet::TypeSet): (JSC::TypeSet::getRuntimeTypeForValue): (JSC::TypeSet::addTypeForValue): (JSC::TypeSet::removeDuplicatesInStructureHistory): (JSC::TypeSet::seenTypes): (JSC::TypeSet::dumpSeenTypes): (JSC::StructureShape::StructureShape): (JSC::StructureShape::markAsFinal): (JSC::StructureShape::addProperty): (JSC::StructureShape::propertyHash): (JSC::StructureShape::leastUpperBound): (JSC::StructureShape::stringRepresentation):
  • runtime/TypeSet.h: Added. (JSC::StructureShape::create): (JSC::TypeSet::create):
  • runtime/VM.cpp: (JSC::VM::VM): (JSC::VM::getTypesForVariableInRange): (JSC::VM::updateHighFidelityTypeProfileState): (JSC::VM::dumpHighFidelityProfilingTypes):
  • runtime/VM.h: (JSC::VM::isProfilingTypesWithHighFidelity): (JSC::VM::highFidelityLog): (JSC::VM::highFidelityTypeProfiler): (JSC::VM::nextLocation): (JSC::VM::getNextUniqueVariableID):


2014-06-26 Mark Lam <​mark.lam@apple.com>


Remove unused instantiation of the WithScope structure.
<​https://webkit.org/b/134331>


Reviewed by Oliver Hunt.


The WithScope structure instance is the VM is unused, and is now removed.


  • runtime/VM.cpp: (JSC::VM::VM):
  • runtime/VM.h:


2014-06-25 Mark Hahnenberg <​mhahnenberg@apple.com>


Structure bit fields should have a consistent format
​https://bugs.webkit.org/show_bug.cgi?id=134307


Reviewed by Filip Pizlo.


Currently we use C-style bit fields for a number of member variables in Structure to save space.
This makes it difficult to load these fields in the JIT. We should instead use our own bitfield
format to make it easy to load and test these variables in JIT code.


  • runtime/JSObject.cpp: (JSC::JSObject::putDirectNonIndexAccessor): (JSC::JSObject::reifyStaticFunctionsForDelete):
  • runtime/Structure.cpp: (JSC::StructureTransitionTable::contains): (JSC::StructureTransitionTable::get): (JSC::StructureTransitionTable::add): (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::addPropertyTransition): (JSC::Structure::despecifyFunctionTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::freezeTransition): (JSC::Structure::preventExtensionsTransition): (JSC::Structure::takePropertyTableOrCloneIfPinned): (JSC::Structure::nonPropertyTransition): (JSC::Structure::flattenDictionaryStructure): (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::pin): (JSC::Structure::allocateRareData): (JSC::Structure::cloneRareDataFrom): (JSC::Structure::getConcurrently): (JSC::Structure::putSpecificValue): (JSC::Structure::getPropertyNamesFromStructure): (JSC::Structure::visitChildren): (JSC::Structure::checkConsistency):
  • runtime/Structure.h: (JSC::Structure::isExtensible): (JSC::Structure::isDictionary): (JSC::Structure::isUncacheableDictionary): (JSC::Structure::propertyAccessesAreCacheable): (JSC::Structure::previousID): (JSC::Structure::setHasGetterSetterPropertiesWithProtoCheck): (JSC::Structure::setContainsReadOnlyProperties): (JSC::Structure::disableSpecificFunctionTracking): (JSC::Structure::objectToStringValue): (JSC::Structure::setObjectToStringValue): (JSC::Structure::setPreviousID): (JSC::Structure::clearPreviousID): (JSC::Structure::previous): (JSC::Structure::rareData): (JSC::Structure::didTransition): Deleted. (JSC::Structure::hasGetterSetterProperties): Deleted. (JSC::Structure::hasReadOnlyOrGetterSetterPropertiesExcludingProto): Deleted. (JSC::Structure::setHasGetterSetterProperties): Deleted. (JSC::Structure::hasNonEnumerableProperties): Deleted. (JSC::Structure::staticFunctionsReified): Deleted. (JSC::Structure::setStaticFunctionsReified): Deleted.
  • runtime/StructureInlines.h: (JSC::Structure::setEnumerationCache): (JSC::Structure::enumerationCache): (JSC::Structure::checkOffsetConsistency):


2014-06-24 Mark Lam <​mark.lam@apple.com>


[ftlopt] Renamed DebuggerActivation to DebuggerScope.
<​https://webkit.org/b/134273>


Reviewed by Michael Saboff.


  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • debugger/DebuggerActivation.cpp: Removed.
  • debugger/DebuggerActivation.h: Removed.
  • debugger/DebuggerScope.cpp: Copied from ../../trunk/Source/JavaScriptCore/debugger/DebuggerActivation.cpp. (JSC::DebuggerScope::DebuggerScope): (JSC::DebuggerScope::finishCreation): (JSC::DebuggerScope::visitChildren): (JSC::DebuggerScope::className): (JSC::DebuggerScope::getOwnPropertySlot): (JSC::DebuggerScope::put): (JSC::DebuggerScope::deleteProperty): (JSC::DebuggerScope::getOwnPropertyNames): (JSC::DebuggerScope::defineOwnProperty): (JSC::DebuggerActivation::DebuggerActivation): Deleted. (JSC::DebuggerActivation::finishCreation): Deleted. (JSC::DebuggerActivation::visitChildren): Deleted. (JSC::DebuggerActivation::className): Deleted. (JSC::DebuggerActivation::getOwnPropertySlot): Deleted. (JSC::DebuggerActivation::put): Deleted. (JSC::DebuggerActivation::deleteProperty): Deleted. (JSC::DebuggerActivation::getOwnPropertyNames): Deleted. (JSC::DebuggerActivation::defineOwnProperty): Deleted.
  • debugger/DebuggerScope.h: Copied from ../../trunk/Source/JavaScriptCore/debugger/DebuggerActivation.h. (JSC::DebuggerScope::create): (JSC::DebuggerActivation::create): Deleted.
  • runtime/VM.cpp: (JSC::VM::VM):
  • runtime/VM.h:


2014-06-24 Filip Pizlo <​fpizlo@apple.com>


[ftlopt] PutByIdFlush can also be converted to a PutByOffset so don't assert otherwise
​https://bugs.webkit.org/show_bug.cgi?id=134265


Reviewed by Geoffrey Garen.


More assertion fallout from the PutById folding work.


  • dfg/DFGNode.h: (JSC::DFG::Node::convertToPutByOffset):


2014-06-24 Filip Pizlo <​fpizlo@apple.com>


[ftlopt] GC should notify us if it resets to_this
​https://bugs.webkit.org/show_bug.cgi?id=128231


Reviewed by Geoffrey Garen.


  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeList.json:
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): (JSC::CodeBlock::finalizeUnconditionally):
  • bytecode/Instruction.h:
  • bytecode/ToThisStatus.cpp: Added. (JSC::merge): (WTF::printInternal):
  • bytecode/ToThisStatus.h: Added.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):


2014-06-24 Filip Pizlo <​fpizlo@apple.com>


[ftlopt] StructureAbstractValue::onlyStructure() should return nullptr if isClobbered()
​https://bugs.webkit.org/show_bug.cgi?id=134256


Reviewed by Michael Saboff.


This isn't testable right now (i.e. it's benign) but we should get it right anyway. The
point is to be able to precisely model what goes on in the snippets of code between a
side-effect and an InvalidationPoint.


This patch also cleans up onlyStructure() by delegating more work to
StructureSet::onlyStructure().


  • dfg/DFGStructureAbstractValue.h: (JSC::DFG::StructureAbstractValue::onlyStructure):


2014-06-24 Filip Pizlo <​fpizlo@apple.com>


[ftlopt][REGRESSION] PutById AI is introducing watchable structures without watching them
​https://bugs.webkit.org/show_bug.cgi?id=134260


Reviewed by Geoffrey Garen.


This was causing loads of assertion failures in debug builds.


  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):


2014-06-21 Filip Pizlo <​fpizlo@apple.com>


[ftlopt] Fold GetById/PutById to MultiGetByOffset/GetByOffset or MultiPutByOffset/PutByOffset, which implies handling non-singleton sets
​https://bugs.webkit.org/show_bug.cgi?id=134090


Reviewed by Oliver Hunt.


This pretty much finishes off the work to eliminate the special-casing of singleton
structure sets by making it possible to fold GetById and PutById to various polymorphic
forms of the ByOffset nodes.


  • bytecode/GetByIdStatus.cpp: (JSC::GetByIdStatus::computeForStubInfo): (JSC::GetByIdStatus::computeFor):
  • bytecode/GetByIdStatus.h:
  • bytecode/PutByIdStatus.cpp: (JSC::PutByIdStatus::computeFor):
  • bytecode/PutByIdStatus.h:
  • bytecode/PutByIdVariant.h: (JSC::PutByIdVariant::constantChecks):
  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants): (JSC::DFG::ConstantFoldingPhase::emitPutByOffset): (JSC::DFG::ConstantFoldingPhase::addChecks):
  • dfg/DFGNode.h: (JSC::DFG::Node::convertToMultiGetByOffset): (JSC::DFG::Node::convertToMultiPutByOffset):
  • dfg/DFGSpeculativeJIT64.cpp: Also convert all release assertions to DFG assertions in this file, because I was hitting some of them while debugging. (JSC::DFG::SpeculativeJIT::fillJSValue): (JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull): (JSC::DFG::SpeculativeJIT::emitCall): (JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal): (JSC::DFG::SpeculativeJIT::fillSpeculateInt32Strict): (JSC::DFG::SpeculativeJIT::fillSpeculateInt52): (JSC::DFG::SpeculativeJIT::fillSpeculateDouble): (JSC::DFG::SpeculativeJIT::fillSpeculateCell): (JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): (JSC::DFG::SpeculativeJIT::compileLogicalNot): (JSC::DFG::SpeculativeJIT::emitBranch): (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGStructureAbstractValue.h: (JSC::DFG::StructureAbstractValue::set):


2014-06-19 Filip Pizlo <​fpizlo@apple.com>


[ftlopt] StructureSet::onlyStructure() should return nullptr if it's not a singleton (instead of asserting)
​https://bugs.webkit.org/show_bug.cgi?id=134077


Reviewed by Sam Weinig.


This makes StructureSet and StructureAbstractValue more consistent and fixes a debug assert
in the abstract interpreter.


  • bytecode/StructureSet.h: (JSC::StructureSet::onlyStructure):


2014-06-18 Filip Pizlo <​fpizlo@apple.com>


DFG AI and constant folder should be able to precisely prune MultiGetByOffset/MultiPutByOffset even if the base structure abstract value is not a singleton
​https://bugs.webkit.org/show_bug.cgi?id=133918


Reviewed by Mark Hahnenberg.


This also adds pruning of PutStructure, since I basically had no choice but
to implement such logic within MultiPutByOffset.


Also adds a bunch of PutById cache status dumping to bytecode dumping.


  • bytecode/GetByIdVariant.cpp: (JSC::GetByIdVariant::dumpInContext):
  • bytecode/GetByIdVariant.h: (JSC::GetByIdVariant::structureSet):
  • bytecode/PutByIdVariant.h: (JSC::PutByIdVariant::oldStructure):
  • bytecode/StructureSet.cpp: (JSC::StructureSet::filter): (JSC::StructureSet::filterArrayModes):
  • bytecode/StructureSet.h:
  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
  • dfg/DFGAbstractValue.cpp: (JSC::DFG::AbstractValue::changeStructure): (JSC::DFG::AbstractValue::contains):
  • dfg/DFGAbstractValue.h: (JSC::DFG::AbstractValue::couldBeType): (JSC::DFG::AbstractValue::isType):
  • dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants): (JSC::DFG::ConstantFoldingPhase::emitGetByOffset): (JSC::DFG::ConstantFoldingPhase::emitPutByOffset): (JSC::DFG::ConstantFoldingPhase::addBaseCheck):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::freezeStrong):
  • dfg/DFGGraph.h:
  • dfg/DFGStructureAbstractValue.h: (JSC::DFG::StructureAbstractValue::operator=):
  • ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
  • tests/stress/fold-multi-get-by-offset-to-get-by-offset-without-folding-the-structure-check.js: Added. (foo): (fu): (bar): (baz): (.bar): (.baz):
  • tests/stress/fold-multi-put-by-offset-to-put-by-offset-without-folding-the-structure-check.js: Added. (foo): (fu): (bar): (baz): (.bar): (.baz):
  • tests/stress/prune-multi-put-by-offset-replace-or-transition-variant.js: Added. (foo): (fu): (bar): (baz): (.bar): (.baz):


2014-06-18 Mark Hahnenberg <​mhahnenberg@apple.com>


Remove CompoundType and LeafType
​https://bugs.webkit.org/show_bug.cgi?id=134037


Reviewed by Filip Pizlo.


We don't use them for anything. We'll replace them with a generic CellType type for all
the objects that are JSCells, aren't JSObjects, and for which we generally don't care about
their JSType at runtime.


  • llint/LLIntData.cpp: (JSC::LLInt::Data::performAssertions):
  • runtime/ArrayBufferNeuteringWatchpoint.cpp: (JSC::ArrayBufferNeuteringWatchpoint::createStructure):
  • runtime/Executable.h: (JSC::ExecutableBase::createStructure): (JSC::NativeExecutable::createStructure):
  • runtime/JSPromiseDeferred.h: (JSC::JSPromiseDeferred::createStructure):
  • runtime/JSPromiseReaction.h: (JSC::JSPromiseReaction::createStructure):
  • runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure):
  • runtime/JSType.h:
  • runtime/JSTypeInfo.h: (JSC::TypeInfo::TypeInfo):
  • runtime/MapData.h: (JSC::MapData::createStructure):
  • runtime/PropertyMapHashTable.h: (JSC::PropertyTable::createStructure):
  • runtime/RegExp.h: (JSC::RegExp::createStructure):
  • runtime/SparseArrayValueMap.cpp: (JSC::SparseArrayValueMap::createStructure):
  • runtime/Structure.cpp: (JSC::Structure::Structure):
  • runtime/StructureChain.h: (JSC::StructureChain::createStructure):
  • runtime/StructureRareData.cpp: (JSC::StructureRareData::createStructure):
  • runtime/SymbolTable.h: (JSC::SymbolTable::createStructure):
  • runtime/WeakMapData.h: (JSC::WeakMapData::createStructure):


2014-06-17 Filip Pizlo <​fpizlo@apple.com>


[ftlopt] PutStructure and PhantomPutStructure shouldn't leave the world in a clobbered state
​https://bugs.webkit.org/show_bug.cgi?id=134002


Reviewed by Mark Hahnenberg.


The effect of this bug was that if we had a PutStructure or PhantomPutStructure then any
JSConstants would be in a Clobbered state, so we wouldn't take advantage of our knowledge
of the structure if that structure was watchable.


Also kill PhantomPutStructure.


  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): (JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransition): (JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransitions):
  • dfg/DFGClobberize.h: (JSC::DFG::clobberize):
  • dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
  • dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::visitChildren):
  • dfg/DFGNode.h: (JSC::DFG::Node::hasTransition):
  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate):
  • dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute):
  • dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile):
  • dfg/DFGStructureAbstractValue.cpp: (JSC::DFG::StructureAbstractValue::observeTransition): (JSC::DFG::StructureAbstractValue::observeTransitions):
  • dfg/DFGValidate.cpp: (JSC::DFG::Validate::validate):
  • dfg/DFGWatchableStructureWatchingPhase.cpp: (JSC::DFG::WatchableStructureWatchingPhase::run):
  • ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile):
  • ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::compileNode): (JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure): Deleted.


2014-06-17 Filip Pizlo <​fpizlo@apple.com>


[ftlopt] DFG put_by_id should inline accesses with a slightly polymorphic base
​https://bugs.webkit.org/show_bug.cgi?id=133964


Reviewed by Mark Hahnenberg.


  • bytecode/PutByIdStatus.cpp: (JSC::PutByIdStatus::appendVariant): (JSC::PutByIdStatus::computeForStubInfo):
  • bytecode/PutByIdVariant.cpp: (JSC::PutByIdVariant::oldStructureForTransition): (JSC::PutByIdVariant::writesStructures): (JSC::PutByIdVariant::reallocatesStorage): (JSC::PutByIdVariant::attemptToMerge): (JSC::PutByIdVariant::attemptToMergeTransitionWithReplace): (JSC::PutByIdVariant::dumpInContext):
  • bytecode/PutByIdVariant.h: (JSC::PutByIdVariant::PutByIdVariant): (JSC::PutByIdVariant::replace): (JSC::PutByIdVariant::transition): (JSC::PutByIdVariant::structure): (JSC::PutByIdVariant::oldStructure):
  • dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handlePutById): (JSC::DFG::ByteCodeParser::parseBlock):
  • dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants): (JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::visitChildren):
  • dfg/DFGNode.cpp: (JSC::DFG::MultiPutByOffsetData::writesStructures): (JSC::DFG::MultiPutByOffsetData::reallocatesStorage):
  • ftl/FTLAbbreviations.h: (JSC::FTL::getLinkage):
  • ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset): (JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol):

Source/WebCore:

This fixes the previous mismerge and adds test coverage for the thing that went wrong.
Also, this adds some helpers for making it easier to inspect JavaScript values.

  • testing/Internals.cpp:

(WebCore::Internals::description):

  • testing/Internals.h:
  • testing/Internals.idl:

2014-07-25 Mark Lam <​mark.lam@apple.com>


[ftlopt] Renamed DebuggerActivation to DebuggerScope.
<​https://webkit.org/b/134273>


Reviewed by Michael Saboff.


No new tests.


  • ForwardingHeaders/debugger/DebuggerActivation.h: Removed.
  • Removed because this is not used.

Source/WebKit/mac:

2014-07-25 Mark Lam <​mark.lam@apple.com>


[ftlopt] Renamed DebuggerActivation to DebuggerScope.
<​https://webkit.org/b/134273>


Reviewed by Michael Saboff.


  • WebView/WebScriptDebugDelegate.mm:
  • Removed unneeded #include.

Source/WTF:

  • wtf/text/WTFString.h:

LayoutTests:

  • js/regress/fold-get-by-id-to-multi-get-by-offset-expected.txt: Added.
  • js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int-expected.txt: Added.
  • js/regress/fold-get-by-id-to-multi-get-by-offset-rare-int.html: Added.
  • js/regress/fold-get-by-id-to-multi-get-by-offset.html: Added.
  • js/regress/fold-multi-get-by-offset-to-get-by-offset-expected.txt: Added.
  • js/regress/fold-multi-get-by-offset-to-get-by-offset.html: Added.
  • js/regress/fold-multi-get-by-offset-to-poly-get-by-offset-expected.txt: Added.
  • js/regress/fold-multi-get-by-offset-to-poly-get-by-offset.html: Added.
  • js/regress/fold-multi-put-by-offset-to-poly-put-by-offset-expected.txt: Added.
  • js/regress/fold-multi-put-by-offset-to-poly-put-by-offset.html: Added.
  • js/regress/fold-multi-put-by-offset-to-put-by-offset-expected.txt: Added.
  • js/regress/fold-multi-put-by-offset-to-put-by-offset.html: Added.
  • js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset-expected.txt: Added.
  • js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.html: Added.
  • js/regress/fold-put-by-id-to-multi-put-by-offset-expected.txt: Added.
  • js/regress/fold-put-by-id-to-multi-put-by-offset.html: Added.
  • js/regress/fold-put-structure-expected.txt: Added.
  • js/regress/fold-put-structure.html: Added.
  • js/regress/hoist-poly-check-structure-effectful-loop-expected.txt: Added.
  • js/regress/hoist-poly-check-structure-effectful-loop.html: Added.
  • js/regress/hoist-poly-check-structure-expected.txt: Added.
  • js/regress/hoist-poly-check-structure.html: Added.
  • js/regress/put-by-id-replace-and-transition-expected.txt: Added.
  • js/regress/put-by-id-replace-and-transition.html: Added.
  • js/regress/put-by-id-slightly-polymorphic-expected.txt: Added.
  • js/regress/put-by-id-slightly-polymorphic.html: Added.
  • js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset-rare-int.js: Added.

(foo):
(fu):
(bar):
(.bar):
(Number):

  • js/regress/script-tests/fold-get-by-id-to-multi-get-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):
(Number):

  • js/regress/script-tests/fold-multi-get-by-offset-to-get-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

  • js/regress/script-tests/fold-multi-get-by-offset-to-poly-get-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

  • js/regress/script-tests/fold-multi-put-by-offset-to-poly-put-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

  • js/regress/script-tests/fold-multi-put-by-offset-to-put-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

  • js/regress/script-tests/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

  • js/regress/script-tests/fold-put-by-id-to-multi-put-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

  • js/regress/script-tests/fold-put-structure.js: Added.

(foo):
(fu):
(bar):
(.bar):

  • js/regress/script-tests/hoist-poly-check-structure-effectful-loop.js: Added.

(foo):
(test):

  • js/regress/script-tests/hoist-poly-check-structure.js: Added.

(foo):
(test):

  • js/regress/script-tests/put-by-id-replace-and-transition.js: Added.
  • js/regress/script-tests/put-by-id-slightly-polymorphic.js: Added.
2:07 PM Changeset in webkit [171659] by matthew_hanson@apple.com
  • 7 edits in branches/safari-600.1-branch/Source/WebKit2

Merge r171651. <rdar://problem/17682120>

11:45 AM Changeset in webkit [171658] by matthew_hanson@apple.com
  • 7 edits in branches/safari-600.1-branch/Source

Merge r171647. <rdar://problem/17315168>

11:42 AM Changeset in webkit [171657] by matthew_hanson@apple.com
  • 3 edits
    2 copies in branches/safari-600.1-branch

Merge r171640. <rdar://problem/17812921>

11:37 AM Changeset in webkit [171656] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Merge r171635. <rdar://problem/17782407>

11:33 AM Changeset in webkit [171655] by matthew_hanson@apple.com
  • 9 edits
    1 copy in branches/safari-600.1-branch

Merge r171626. <rdar://problem/17730536>

11:30 AM Changeset in webkit [171654] by matthew_hanson@apple.com
  • 8 edits
    2 copies in branches/safari-600.1-branch

Merge r171624. <rdar://problem/17715503>

11:19 AM Changeset in webkit [171653] by matthew_hanson@apple.com
  • 4 edits in branches/safari-600.1-branch/Source/WebCore

Merge r171616. <rdar://problem/17736875>

10:58 AM Changeset in webkit [171652] by matthew_hanson@apple.com
  • 3 edits
    3 copies in branches/safari-600.1-branch

Merge r171609. <rdar://problem/17043792>

10:25 AM Changeset in webkit [171651] by enrica@apple.com
  • 7 edits in trunk/Source/WebKit2

[WebKit2 iOS]Add support for caret movement for the 3rd party keyboard protocol.
​https://bugs.webkit.org/show_bug.cgi?id=135325
<rdar://problem/17682120>

Reviewed by Sam Weinig.

WKContentView now implements moveByOffset to support the
protocol for 3rd party keyboards.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView moveByOffset:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::moveSelectionByOffset):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::moveSelectionByOffset):

Note: See TracTimeline for information about the timeline view.