Timeline
Aug 10, 2014:
- 11:34 PM Changeset in webkit [172385] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT
https://bugs.webkit.org/show_bug.cgi?id=135760
Reviewed by Philippe Normand.
The problem is that the threading initialization is failing
because there are two copies of WTF, one in libjavascriptcoregtk
and the other in libwebkit2gtk. When WebKit2 is initialized in the
UI process, JSC::initializeThreading() is called first and then
WTF::initializeMainThread(). The former is calling
ThreadIdentifierData::initializeOnce() initializing the
ThreadIdentifierData::m_key symbol in libjavascriptcoregtk, while
the latter is using the ThreadIdentifierData API from libwebkit2gtk
that hasn't been initialized.
- CMakeLists.txt: Do not add WTF to the list of WebKit2 libraries,
WebKit2 already depends on JavaScriptCore that already links to WTF.
- 9:22 PM Changeset in webkit [172384] by
-
- 2 edits1 delete in trunk/Source/WebCore
Remove inputSpeech.png
https://bugs.webkit.org/show_bug.cgi?id=135771
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-10
Reviewed by Andreas Kling.
- Resources/inputSpeech.png: Removed.
- WebCore.xcodeproj/project.pbxproj:
- 6:26 PM Changeset in webkit [172383] by
-
- 9 edits in trunk/Source
Yelp phone number highlights often disappear
https://bugs.webkit.org/show_bug.cgi?id=135789
<rdar://problem/17971057>
Reviewed by Brady Eidson.
Since selectedTelephoneNumberRangesChanged doesn't provide an associated
Frame, an incoming selectedTelephoneNumberRangesChanged from a subframe
would overwrite ServicesOverlayController's cached (and potentially active)
telephone number highlights.
This happens a lot on Yelp, because they have many subframes which are
doing layout on a regular basis.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Adjust to the new (lack of) arguments.
- WebProcess/WebPage/ServicesOverlayController.h:
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
Adjust logging; we can revisit it later.
(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
When building phone number highlights, walk the Frame tree and retrieve
them from all of the Editors.
(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
(WebKit::ServicesOverlayController::telephoneNumberRangesForFocusedFrame):
(WebKit::ServicesOverlayController::determineActiveHighlight):
(WebKit::ServicesOverlayController::handleClick):
Retrieve the detected telephone number ranges from the focused frame
when combining telephone numbers with selection services.
This ensures that we don't show combined phone number highlights from other frames.
- editing/Editor.cpp:
(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::clearDataDetectedTelephoneNumbers): Deleted.
- editing/Editor.h:
(WebCore::Editor::detectedTelephoneNumberRanges):
- page/EditorClient.h:
(WebCore::EditorClient::selectedTelephoneNumberRangesChanged):
Cache and expose detected telephone number ranges on Editor.
Change selectedTelephoneNumberRangesChanged to take no arguments; it's
just a notification now.
- 6:23 PM Changeset in webkit [172382] by
-
- 3 edits in trunk/Source/WebKit2
Refactor ServiceOverlayController in preparation for fading between highlights
https://bugs.webkit.org/show_bug.cgi?id=135787
<rdar://problem/17935736>
Reviewed by Brady Eidson.
Rework ServicesOverlayController so that we always keep a set of generic
"potential highlights", which are refcounted Highlight objects and
wrap a DDHighlightRef, as well as a type (Selection or TelephoneNumber),
Range (only used in the case of TelephoneNumber), and potentially more
things in the future (like, say, fade state!).
We eagerly update the list of potential highlights when the selection or set
of detected telephone numbers changes, and use this information to install
or uninstall the page overlay as needed.
When we need to recompute the "active" highlight from this set (for example,
we need to handle a mouse event or paint the highlight), we look through
the set of potential highlights and decide. This moves the "active" highlight
decision logic into one small and confined place.
- WebProcess/WebPage/ServicesOverlayController.h:
(WebKit::ServicesOverlayController::Highlight):
Add the new aforementioned refcounted Highlight class.
Rename m_lastHoveredHighlightChangeTime to m_lastActiveHighlightChangeTime.
Make m_webPage a reference.
The rest is just added/removed/adjusted functions for the refactoring.
(WebKit::TelephoneNumberData::TelephoneNumberData): Deleted.
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::Highlight::createForSelection):
(WebKit::ServicesOverlayController::Highlight::createForTelephoneNumber):
Create Highlights for the two different highlight types.
(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::willMoveToWebPage):
Our WebPage pointer is always valid because it owns us; don't clear it.
We need to keep it around so that we can uninstall the overlay and
install it again later, anyway.
(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
When selection rects or detected telephone numbers change, rebuild potential highlights.
This will have the side-effect of installing the overlay if needed.
(WebKit::ServicesOverlayController::mouseIsOverHighlight):
Make this function take a Highlight instead of a DDHighlightRef.
(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
Make this function take a Highlight instead of a DDHighlightRef.
(WebKit::ServicesOverlayController::drawHighlight):
Make this function take a Highlight instead of a DDHighlightRef.
There's no reason to do the translation separately from the layer blit,
also allowing us to avoid the StateSaver.
(WebKit::ServicesOverlayController::drawRect):
drawRect now always paints the active highlight, instead of duplicating
logic about which highlight should be active.
Also, it will update the active highlight before painting.
We no longer need to re-determine whether the active highlight's phone
number range is still a valid phone number range, because we rebuild
the potential highlights whenever the set of phone number ranges changes.
(WebKit::ServicesOverlayController::clearActiveHighlight):
Mostly an adoption of new names.
(WebKit::ServicesOverlayController::removeAllPotentialHighlightsOfType):
Run through the list of potential highlights and remove any of the given type.
The two highlight building functions use this helper to clear the old ones before building.
(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
(WebKit::ServicesOverlayController::buildSelectionHighlight):
Rebuild the list of potential highlights, replacing all highlights of
the given type with new ones.
(WebKit::ServicesOverlayController::hasRelevantSelectionServices):
Factor out the code that decides whether our current selection is
viable for servicing based on whether we have plain-text and/or rich-text services.
(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
When rebuilding potential highlights, if we have no potential highlights at all,
uninstall the page overlay; we don't need mouse tracking and don't need to
paint anything. This improves memory use and compositing performance significantly,
where previously we were leaving the overlay up forever after creating it.
If we have either detected telephone numbers or relevant selection services,
create and install the overlay if it doesn't already exist.
(WebKit::ServicesOverlayController::createOverlayIfNeeded):
This just moved from elsehwere, except that it now uses FadeMode::DoNotFade.
It doesn't make sense to fade on install/uninstall (which happens even before hover)
but not on changing the active highlight; fading will be re-addressed in the next patch.
(WebKit::ServicesOverlayController::highlightsAreEquivalent):
Determine whether two highlights are equivalent. While we may have
created a new Highlight at rebuild time, if two telephone number
highlights have equivalent ranges, there's no need to 'transition' to the new one.
(WebKit::ServicesOverlayController::determineActiveHighlight):
Run through the list of services, and try to find one that is hovered.
We prefer telephone number highlights to selection highlights, and
we will never make a selection highlight active if it is both
not serviceable and there are no telephone numbers to show in the combined menu.
This is the centralized location for determination of which highlight
should be considered active. If the active highlight changed, update
the time since last change and cancel the mouse-down tracking.
(WebKit::ServicesOverlayController::mouseEvent):
Adjust some comments to be more explanatory.
A bunch of code moved out of here and into determineActiveHighlight.
(WebKit::ServicesOverlayController::handleClick):
Adjust to take a reference and use Highlight instead of DDHighlightRef.
- 4:35 PM WebInspectorCodingStyleGuide edited by
- formatting (diff)
- 4:32 PM WebInspectorCodingStyleGuide edited by
- i promise to document promises (diff)
- 3:54 PM WebInspectorTests edited by
- bugfixes (diff)
- 3:50 PM WebInspectorTests edited by
- add notes about debugging tests; add notes about model tests (diff)
- 1:12 PM Changeset in webkit [172381] by
-
- 5 edits in trunk
Destructuring assignment in a var declaration list incorrectly consumes subsequent variable initialisers
https://bugs.webkit.org/show_bug.cgi?id=135773
Reviewed by Michael Saboff.
Source/JavaScriptCore:
We should be using parseAssignment expression in order to get the correct
precedence.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVarDeclarationList):
LayoutTests:
Add new tests.
- js/destructuring-assignment-expected.txt:
- js/script-tests/destructuring-assignment.js:
- 1:07 PM Changeset in webkit [172380] by
-
- 5 edits in trunk
JSC Lexer is allowing octals 08 and 09 in strict mode functions
https://bugs.webkit.org/show_bug.cgi?id=135704
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-08-10
Reviewed by Oliver Hunt.
Return syntax error ("Decimal integer literals with a leading zero are
forbidden in strict mode") if a number starts with 0 and is followed
by a digit.
- parser/Lexer.cpp:
(JSC::Lexer<T>::lex):
- 3:25 AM Changeset in webkit [172379] by
-
- 12 edits3 deletes in trunk/Source
Web Inspector: new glyphs are visible on OS X 10.9 builds
https://bugs.webkit.org/show_bug.cgi?id=135743
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
- UserInterface/Images/Legacy/UserInputPrompt.svg: Removed.
- UserInterface/Images/Legacy/UserInputPromptPrevious.svg: Removed.
- UserInterface/Images/Legacy/UserInputResult.svg: Removed.
Removed images that were not used.
- UserInterface/Views/DashboardContainerView.css:
(body.mac-platform.legacy .dashboard-container .advance-arrow):
- UserInterface/Views/DebuggerDashboardView.js:
(WebInspector.DebuggerDashboardView):
- UserInterface/Views/FolderIcon.css:
(body.mac-platform.legacy .folder-icon .icon):
- UserInterface/Views/HierarchicalPathComponent.css:
(body.mac-platform.legacy .hierarchical-path-component > .selector-arrows):
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
Use legacy images.
- UserInterface/Views/NavigationSidebarPanel.css:
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected .subtitle):
Fix color for selected subtitle.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
Use legacy images.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Use 10100 instead of 1090 for the version.
- 1:45 AM Changeset in webkit [172378] by
-
- 2 edits in trunk/Source/WTF
Update HashTable's operator= after r172167 per review comments
- wtf/HashTable.h:
Update the type as suggested by Darin.
- 12:30 AM Changeset in webkit [172377] by
-
- 4 edits1 move in trunk
[GTK] REGRESSION(r166239): The ld version script is not being used
https://bugs.webkit.org/show_bug.cgi?id=135694
Reviewed by Martin Robinson.
.:
Move the symbols filter file from Tools/gtk to Source/cmake and rename
it as gtksymbols.filter. Also updated it, since some of the symbols
exported were renamed.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/gtksymbols.filter: Renamed from Tools/gtk/symbols.filter.
Source/WebKit2:
- CMakeLists.txt: Add VERSION_SCRIPT to WebKit2 link flags if present.
- 12:09 AM Changeset in webkit [172376] by
-
- 2 edits in trunk
[GTK] Child processes should be installed in a versioned directory
https://bugs.webkit.org/show_bug.cgi?id=135754
Reviewed by Gustavo Noronha Silva.
Define LIBEXEC_INSTALL_DIR as
${CMAKE_INSTALL_FULL_LIBEXECDIR}/webkitgtk-${WEBKITGTK_API_VERSION}
so that the child processes are installed in $libexec/webkitgtk-4.0.
This makes it possible to install 2.6 in parallel to older versions.
- Source/cmake/OptionsGTK.cmake:
Aug 9, 2014:
- 9:34 PM Changeset in webkit [172375] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: TimelineManager should reuse empty recordings
https://bugs.webkit.org/show_bug.cgi?id=135749
Reviewed by Timothy Hatcher.
Check whether the recording is empty before creating a new one.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._loadNewRecording):
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.isEmpty):
(WebInspector.TimelineRecording.prototype.unloaded):
- 6:04 PM Changeset in webkit [172374] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r172301): Combined phone number highlight doesn't appear if rich content is selected and we have no rich content services
https://bugs.webkit.org/show_bug.cgi?id=135785
<rdar://problem/17969843>
Reviewed by Brady Eidson.
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::drawSelectionHighlight):
We can't early return in the rich-content-but-no-rich-services case
if we have telephone numbers in the selection, because we want to offer
them up in the combined menu.
- UIProcess/mac/WebContextMenuProxyMac.mm:
If we end up with no menu, because there were no services available,
make a fresh one that we can fill with combined telephone number items.
- 5:48 PM Changeset in webkit [172373] by
-
- 3 edits2 adds in trunk
Subpixel rendering: Transforms on non-compositing layers leave bits behind when the box boundaries changes.
https://bugs.webkit.org/show_bug.cgi?id=135786
Reviewed by Simon Fraser.
Since we don't control the transformed context painting's snapping strategy, our best bet to fully
include the transformed box when requesting for repaint is to use enclosing.
Pixelsnapping doesn't work here for all cases. For example, a scaled box at 0.8px can be anti-aliased painted
both at 0.5px and 1px, while with pixelsnapping we'd expect it to be painted starting from 1px;
Source/WebCore:
Test: fast/repaint/hidpi-transform-on-subpixel-repaintrect.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeRectForRepaint): enclose the result of the transform.
LayoutTests:
- fast/repaint/hidpi-transform-on-subpixel-repaintrect-expected.txt: Added.
- fast/repaint/hidpi-transform-on-subpixel-repaintrect.html: Added.
Aug 8, 2014:
- 11:50 PM Changeset in webkit [172372] by
-
- 17 edits in trunk/Source
REGRESSION: Inspector crashes when debugger is paused and injected scripts access window.screen().
<https://webkit.org/b/135656>
Not reviewed.
Rolling out r170680 which was merged to ToT in r172129.
Source/JavaScriptCore:
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::evaluate):
(JSC::DebuggerCallFrame::invalidate):
- debugger/DebuggerCallFrame.h:
- debugger/DebuggerScope.cpp:
(JSC::DebuggerScope::DebuggerScope):
(JSC::DebuggerScope::finishCreation):
(JSC::DebuggerScope::visitChildren):
(JSC::DebuggerScope::className):
(JSC::DebuggerScope::getOwnPropertySlot):
(JSC::DebuggerScope::put):
(JSC::DebuggerScope::deleteProperty):
(JSC::DebuggerScope::getOwnPropertyNames):
(JSC::DebuggerScope::defineOwnProperty):
(JSC::DebuggerScope::next): Deleted.
(JSC::DebuggerScope::invalidateChain): Deleted.
(JSC::DebuggerScope::isWithScope): Deleted.
(JSC::DebuggerScope::isGlobalScope): Deleted.
(JSC::DebuggerScope::isFunctionScope): Deleted.
- debugger/DebuggerScope.h:
(JSC::DebuggerScope::create):
(JSC::DebuggerScope::Iterator::Iterator): Deleted.
(JSC::DebuggerScope::Iterator::get): Deleted.
(JSC::DebuggerScope::Iterator::operator++): Deleted.
(JSC::DebuggerScope::Iterator::operator==): Deleted.
(JSC::DebuggerScope::Iterator::operator!=): Deleted.
(JSC::DebuggerScope::isValid): Deleted.
(JSC::DebuggerScope::jsScope): Deleted.
(JSC::DebuggerScope::begin): Deleted.
(JSC::DebuggerScope::end): Deleted.
- inspector/JSJavaScriptCallFrame.cpp:
(Inspector::JSJavaScriptCallFrame::scopeType):
(Inspector::JSJavaScriptCallFrame::scopeChain):
- inspector/JavaScriptCallFrame.h:
(Inspector::JavaScriptCallFrame::scopeChain):
- inspector/ScriptDebugServer.cpp:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::debuggerScopeStructure): Deleted.
- runtime/JSObject.h:
(JSC::JSObject::isWithScope): Deleted.
- runtime/JSScope.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WebCore:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::attachDebugger):
- 7:37 PM Changeset in webkit [172371] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Do not initialize g_type in WebProcessMain::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=135700
Reviewed by Gyuyoung Kim.
Inspired by r171788.
Glib since 2.36 itself initializes g_type_init.
- WebProcess/efl/WebProcessMainEfl.cpp:
- 6:14 PM Changeset in webkit [172370] by
-
- 2 edits in trunk/Tools
Unbreak webkitpy unit tests by checking for the existence of the image diff template
file before trying to open it (as the tests do for results.html).
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):
- 6:12 PM Changeset in webkit [172369] by
-
- 2 edits in trunk/Source/WebKit2
Build fix for 32-bit.
- UIProcess/mac/ServicesController.mm:
(WebKit::ServicesController::ServicesController):
Don't dynamically refresh services in 32-bit apps. It's not possible
to write a 32-bit app with the Modern API, so this doesn't matter.
- 5:23 PM Changeset in webkit [172368] by
-
- 3 edits2 adds in trunk
Load the layout test result image diff HTML from a file, rather than having it inline in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=135780
Reviewed by Dan Bates.
Tools:
Pull the HTML for the image diff file into a separate file, for easier hackability.
- Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.write_image_diff_files):
LayoutTests:
Add image-diff-template.html and expected result (crazy, but this is what we do
for results.html too).
- fast/harness/image-diff-template-expected.txt: Added.
- fast/harness/image-diff-template.html: Added.
- 5:00 PM Changeset in webkit [172367] by
-
- 3 edits in trunk/Source/WebCore
Implement long mouse press over links. Part of 135257 - Add long mouse press gesture.
https://bugs.webkit.org/show_bug.cgi?id=135476
Patch by Peyton Randolph <prandolph@apple.com> on 2014-08-08
Reviewed by Tim Horton.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear): Clear long press state.
(WebCore::EventHandler::handleMousePressEvent): Start the long-press if the mouse press is a left
mouse press over a link.
(WebCore::EventHandler::eventMayStartDrag): We cannot start a drag if we've recognized a long press.
(WebCore::EventHandler::handleMouseReleaseEvent):
If we didn't recognize a long press, cancel the long press.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress):
Begin the long mouse press by kicking off a timer. If the timer fires before the long press is
cancelled, the long press is recognized.
(WebCore::EventHandler::recognizeLongMousePress): Added. Trigger the long-press and disable other
actions like dragging.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress): Added. Cancel the long press by
clearing related state.
(WebCore::EventHandler::clearLongMousePressState): Added. Clear long press state.
(WebCore::EventHandler::handleLongMousePressMouseMovedEvent): Added. Cancel the long press if
the mouse moves outside a specified hysteresis interval.
(WebCore::EventHandler::handleMouseMoveEvent): Ask handleLongMousePressMouseMovedEvent whether to
return early and not update hovers, cursors, drags, etc.
(WebCore::EventHandler::dragHysteresisExceeded): Factor out the hysteresis bounds check into
mouseHysteresisExceeded().
(WebCore::EventHandler::handleDrag): Cancel long press upon starting drag.
(WebCore::EventHandler::mouseHysteresisExceeded): Added. General hysteresis function that takes an
arbitrary mouse movement threshold. Factored out from dragHysteresisExceeded.
- page/EventHandler.h:
- 4:27 PM Changeset in webkit [172366] by
-
- 6 edits in trunk/Source/WebKit2
[mac] Dynamically update serviceability when the set of services changes
https://bugs.webkit.org/show_bug.cgi?id=135738
<rdar://problem/17533459>
Reviewed by Brady Eidson.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
Adopt the new universal refreshExistingServices.
(WebKit::WebContext::refreshExistingServices): Deleted.
- UIProcess/WebContext.h:
Remove WebContext::refreshExistingServices; there's no need for it.
- UIProcess/mac/ServicesController.h:
- UIProcess/mac/ServicesController.mm:
Fix the build with only public headers by including NSSharingService.h itself.
Place the NSSharingServicePicker (Details) category outside the #ifdef.
Forward-declare and possibly import NSExtension SPI.
(WebKit::ServicesController::ServicesController):
Register a callback to be notified whenever the set of services changes.
When this occurs, call refreshExistingServices. We let refreshExistingServices
coalesce updates because these notifications can come in small batches.
(WebKit::ServicesController::refreshExistingServices):
Dispatch changes in service availability to all processes in all contexts.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Adjust the referenced rdar:// and call ServicesController::refreshExistingServices
instead of the now-removed WebContext:: variant. We can't remove this
yet because our services state can still be stale because NSServiceSharingPicker
can still sometimes lie about the current service state immediately after a change occurs;
once that is fixed, we should get rid of this as well as the refresh in Web Process creation.
- 4:24 PM Changeset in webkit [172365] by
-
- 3 edits3 adds in trunk
[WK2] Scrolling does not work inside nested frames
https://bugs.webkit.org/show_bug.cgi?id=135775
<rdar://problem/17959896>
Reviewed by Tim Horton.
Source/WebCore:
r169733 added an "isMainFrame" check in AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged.
However we have to rebuild the non-fast-scrollable region when any subframe changes,
even a deeply nested one. So always rebuild it, starting from the root frame.
Fixes scrolling on nested framesets like http://www.opengl.org/sdk/docs/man3/.
Test: platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
LayoutTests:
Nested frameset test that dumps the scrolling tree.
- platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html: Added.
- platform/mac-wk2/tiled-drawing/scrolling/frames/resources/frameset-frame.html: Added.
- 4:15 PM Changeset in webkit [172364] by
-
- 2 edits in trunk/Source/WebKit2
Clients that request the selection services menu after WebKit2 will get one with different metrics than otherwise
https://bugs.webkit.org/show_bug.cgi?id=135765
<rdar://problem/17962180>
Reviewed by Brady Eidson.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
The menu is cached between clients, but we make adjustments to it.
We should copy it before adjusting.
- 4:14 PM Changeset in webkit [172363] by
-
- 1 copy in tags/Safari-600.1.4.9
Re-create tag part 2.
- 4:13 PM Changeset in webkit [172362] by
-
- 1 delete in tags/Safari-600.1.4.9
Re-create tag part 1.
- 4:09 PM Changeset in webkit [172361] by
-
- 1 copy in tags/Safari-600.1.4.9
Re-create tag part 2.
- 4:08 PM Changeset in webkit [172360] by
-
- 1 delete in tags/Safari-600.1.4.9
Re-create tag part 1.
- 3:49 PM Changeset in webkit [172359] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 3:45 PM Changeset in webkit [172358] by
-
- 1 copy in tags/Safari-600.1.4.9/safari-600.1.4-branch
New Tag
- 2:12 PM Changeset in webkit [172357] by
-
- 12 edits in trunk/Source/WebCore
[CSS Shapes] Refactor getExcludedIntervals since only one LineSegment is ever returned
https://bugs.webkit.org/show_bug.cgi?id=135757
Reviewed by Zoltan Horvath.
The interface for getExcludedIntervals was designed when shape-inside
was still a thing, and it was possible for a line in a shape to have
multiple segments. shape-outside can only have one segment per line,
so this refactors the code to simplify and reflect that reality.
No new test, no behavior change.
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::getExcludedInterval):
(WebCore::BoxShape::getExcludedIntervals): Deleted.
- rendering/shapes/BoxShape.h:
- rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::getExcludedInterval):
(WebCore::PolygonShape::getExcludedIntervals): Deleted.
- rendering/shapes/PolygonShape.h:
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShape::getExcludedInterval):
(WebCore::RasterShape::getExcludedIntervals): Deleted.
- rendering/shapes/RasterShape.h:
- rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::getExcludedInterval):
(WebCore::RectangleShape::getExcludedIntervals): Deleted.
- rendering/shapes/RectangleShape.h:
- rendering/shapes/Shape.h:
(WebCore::LineSegment::LineSegment):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::logicalLeftOffset):
(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):
(WebCore::ShapeOutsideInfo::computeSegmentsForLine): Deleted.
- rendering/shapes/ShapeOutsideInfo.h:
- 1:59 PM Changeset in webkit [172356] by
-
- 1 copy in tags/Safari-600.1.4.9
New Tag.
- 1:21 PM Changeset in webkit [172355] by
-
- 6 edits in trunk/Source
Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr
https://bugs.webkit.org/show_bug.cgi?id=135726
Reviewed by Timothy Hatcher.
Source/WebCore:
Add a bridge so that InspectorTest can synchronously log to the console.
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::unbufferedLog): Added.
- inspector/InspectorFrontendHost.h:
- inspector/InspectorFrontendHost.idl:
Source/WebInspectorUI:
Added a flag for debugging inspector tests which will synchronously log messages.
This avoids failure modes that prevent logging from being added to the test page.
- UserInterface/Base/Test.js:
(InspectorTest.debugLog):
(InspectorTest.addResult):
- 1:09 PM Changeset in webkit [172354] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 1:04 PM Changeset in webkit [172353] by
-
- 2 edits in trunk/Tools
Gardening: fix Windows build after r172259.
Not reviewed.
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::addMockSpeechInputResult): Deleted.
(TestRunner::setMockSpeechInputDumpRect): Deleted.
(TestRunner::startSpeechInput): Deleted.
- 1:00 PM Changeset in webkit [172352] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: When Switching Recordings, the UI datagrids do not update to match selection
https://bugs.webkit.org/show_bug.cgi?id=135764
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-08
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineSidebarPanel.js:
When changing the activeContentView trigger an update of the datagrids by
re-applying the filter, which will be different now that the view is different.
- 12:53 PM Changeset in webkit [172351] by
-
- 6 edits in trunk
Adjustments to CueBox CSS Width calculations.
https://bugs.webkit.org/show_bug.cgi?id=135759
<rdar://problem/17954473>.
Reviewed by Eric Carlson.
This is a followup patch that addresses some of the test failures caused by r172224.
These tests were skipped in r172253.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateActiveCuesFontSize):
Tell the cue boxes that they need to be updated when the font size specified in the user prefs changes.
Cap width to 100%, calculate max-width in percentages instead of pixels.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
(WebCore::VTTCue::setFontSize):
Remove some unnecessary code that doesn't actually work.
Make sure to tell cuebox that it needs to be updated.
Unskip tests media/track/track-cue-rendering-horizontal.html and media/track/track-cue-rendering-rtl.html.
- 12:33 PM Changeset in webkit [172350] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception opening Web Inspector - TypeError: undefined is not a function - candidateObjectCookie.every
https://bugs.webkit.org/show_bug.cgi?id=135762
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-08
Reviewed by Timothy Hatcher.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
Fix a typo, the wrong object was being used.
- 12:20 PM Changeset in webkit [172349] by
-
- 4 edits in trunk
make clean does not work in OpenSource, fails in WebKitLibraries
https://bugs.webkit.org/show_bug.cgi?id=135734
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-08
Reviewed by David Kilzer.
Tools:
- Scripts/copy-webkitlibraries-to-product-directory:
Add a --clean switch that removes possible WebKitSystemInterface
and LLVM libraries and headers that may have been copied to the
product directory.
WebKitLibraries:
- Makefile:
Add a "clean" target that runs copy-webkitlibraries-to-product-dir
with the new --clean switch.
- 11:55 AM Changeset in webkit [172348] by
-
- 20 edits in trunk/Source/WebCore
Clean up image subsampling code, make it less iOS-specific
https://bugs.webkit.org/show_bug.cgi?id=134916
Reviewed by Dean Jackson.
Compile the image subsampling code on both Mac and iOS, and make it more platform
neutral in general. Add a setting to allow it to be enabled on Mac for testing.
The most significant changes are in ImageSourceCG and BitmapImageCG. CG's ImageSource
is no longer stateful with respect to subsampling; its functions take a SubsamplingLevel
when appropriate. CG's BitmapImage now determines which level of subsampling to use
for a given frame, storing the subsampling level in the frame data. It can replace
an aggressively subsampled frame with a less subsampled frame if necessary.
To reduce the chances of subsampling affecting rendering, BitmapImage::size() now
always returns the non-subsampled size; subsampling is strictly internal to BitmapImage.
BitmapImage::draw() takes care of scaling the srcRect for subsampled images.
iOS had a code path that enabled caching of frame metadata in BitmapImage without
actually decoding the frame; make this cross-platform.
Fix a couple of issues in the original pathc: remove a log, and ImageSource::allowSubsamplingOfFrameAtIndex()
return false.
- WebCore.exp.in: Changed signature for GraphicsContext::drawNativeImage().
- WebCore.xcodeproj/project.pbxproj: Added ImageSource.cpp, which is not built
for Cocoa but useful for reference.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::imageSizeForRenderer): Remove iOS-specific subsampling code.
(WebCore::CachedImage::createImage): Call setAllowSubsampling() on the image if we
can get to Settings (m_loader is null for image documents).
(WebCore::CachedImage::currentFrameKnownToBeOpaque): This forced decode always
caused creation of the non-subsampled image, so remove it. There's no reason to
eagerly decode the frame here.
- loader/cache/CachedImage.h: Fix comment.
- page/Settings.cpp: Add defaultImageSubsamplingEnabled, true for iOS and false for Mac.
- page/Settings.in: Added imageSubsamplingEnabled.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::BitmapImage): Init some more things. Default m_allowSubsampling to
true for iOS to catch images created in code paths where we can't get to Settings.
(WebCore::BitmapImage::haveFrameAtIndex): Handy helper.
(WebCore::BitmapImage::cacheFrame): Now takes the subsampling level and whether to cache
just metadata, or also the frame.
(WebCore::BitmapImage::didDecodeProperties): No need to store originalSize.
(WebCore::BitmapImage::updateSize): When we get the size for the first time, call
determineMinimumSubsamplingLevel() to choose a reasonable subsampling level which takes
platform-specific limits into account.
(WebCore::BitmapImage::dataChanged): Comment.
(WebCore::BitmapImage::ensureFrameIsCached): Take ImageFrameCaching into account.
(WebCore::BitmapImage::frameAtIndex): Choose a subsampling level given the scale,
then determine if we can use the currently cached frame, or whether we should resample.
(WebCore::BitmapImage::frameIsCompleteAtIndex): Caching m_isComplete is now done when caching
frame metadata.
(WebCore::BitmapImage::frameDurationAtIndex):
(WebCore::BitmapImage::frameHasAlphaAtIndex): The 'true' return is the safe return value.
(WebCore::BitmapImage::frameOrientationAtIndex): Caching m_orientation is now done when caching
frame metadata.
(WebCore::BitmapImage::cacheFrameInfo): Deleted.
(WebCore::BitmapImage::originalSize): Deleted.
(WebCore::BitmapImage::originalSizeRespectingOrientation): Deleted.
(WebCore::BitmapImage::currentFrameSize): Deleted.
(WebCore::BitmapImage::ensureFrameInfoIsCached): Deleted.
- platform/graphics/BitmapImage.h:
(WebCore::FrameData::FrameData):
- platform/graphics/GraphicsContext.h: No need to pass a scale param now.
- platform/graphics/ImageSource.cpp: Non-Cocoa changes.
(WebCore::ImageSource::subsamplingLevelForScale):
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex):
(WebCore::ImageSource::size):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
- platform/graphics/ImageSource.h: No longer stores subsampling state.
(WebCore::ImageSource::isSubsampled): Deleted.
- platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):
- platform/graphics/cg/BitmapImageCG.cpp:
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage): Init more members.
(WebCore::BitmapImage::determineMinimumSubsamplingLevel): Choose a minimum subsampling
level for the platform (subsample until the image area falls under a threshold).
(WebCore::BitmapImage::checkForSolidColor): Don't bother decoding frames if the image
is not 1x1. Also take care not to decode a non-subsampled image.
(WebCore::BitmapImage::draw): The actual bug fix is here; remove logic that
computed srcRectForCurrentFrame from m_size and m_originalSize; for some callers
srcRect was computed using the pre-subsampled size, and for others it was the subsampled size.
Instead, scale srcRect by mapping between the non-subsampled size, and the size of the CGImageRef
which is affected by subsampling.
(WebCore::BitmapImage::copyUnscaledFrameAtIndex):
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage): Remove #ifdeffed code.
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): No more weird scaling!
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::draw):
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource):
(WebCore::createImageSourceOptions): Helper that always returns a new CFDictionaryRef.
(WebCore::imageSourceOptions): If not subsampling, return the cached CFDictionaryRef, otherwise
make a new options dict and return it.
(WebCore::ImageSource::subsamplingLevelForScale): Helper that returns a subsampling level
between 0 and 3 given a scale.
(WebCore::ImageSource::isSizeAvailable): SkipMetadata is a default value for the param now.
(WebCore::ImageSource::allowSubsamplingOfFrameAtIndex): We turn off subsampling for progressive
JPEGs because of a bug, so need this to know if a frame should be subsampled.
(WebCore::ImageSource::frameSizeAtIndex): The looping to find a subsampling level is now in BitmapImageCG.
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::size): Always use a subsampling level of 0 for size().
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex): The caller mapped a scale to a level.
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameBytesAtIndex):
(WebCore::ImageSource::imageSourceOptions): Deleted.
(WebCore::ImageSource::originalSize): Deleted.
- platform/graphics/mac/ImageMac.mm:
(WebCore::BitmapImage::invalidatePlatformData): 0 -> nullptr
- platform/graphics/wince/ImageWinCE.cpp:
(WebCore::BitmapImage::determineMinimumSubsamplingLevel):
- 11:28 AM Changeset in webkit [172347] by
-
- 4 edits4 deletes in branches/safari-600.1-branch
Merged r172332.
- 11:13 AM Changeset in webkit [172346] by
-
- 16 edits in trunk
Progress towards using CMake on Mac.
https://bugs.webkit.org/show_bug.cgi?id=135662
Reviewed by Laszlo Gombos.
- CMakeLists.txt:
.:
Mavericks has a flex version of "flex 2.5.35 Apple(flex-31)" which CMake doesn't like on Mac.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Added features that are needed by the Mac port.
- Source/cmake/OptionsMac.cmake:
Enable CSS_IMAGE_SET based on FeatureDefines.h.
Disable the FTL with CMake for now.
- Source/cmake/OptionsEFL.cmake:
- Source/cmake/OptionsGTK.cmake:
Enable subpixel layout to not conflict with FeatureDefines.h
Source/WebCore:
Added necessary include directories and idls.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
Moved ImageSource.cpp and image-decoders to platform CMake files because they are not used on mac.
- PlatformMac.cmake:
Corrected some sources.
- config.h:
Added workaround for not using prefix headers with CMake.
- platform/graphics/ANGLEWebKitBridge.h:
Compile fix to find ANGLE headers while using CMake.
- platform/graphics/FormatConverter.h:
- platform/mac/NSScrollerImpDetails.h:
Removed unnecessary config.h includes.
- 10:41 AM Changeset in webkit [172345] by
-
- 3 edits in trunk
Undo some erroneous changes to the Xcode scheme files from r172259.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
- 9:19 AM Changeset in webkit [172344] by
-
- 2 edits in trunk/Source/WebKit2
Services overlay dropdown is often in the wrong place with zoomed pages or horizontal scrolling
https://bugs.webkit.org/show_bug.cgi?id=135755
<rdar://problem/17907752>
Reviewed by Brady Eidson.
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::establishHoveredTelephoneHighlight):
(WebKit::ServicesOverlayController::maybeCreateSelectionHighlight):
DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection adjusts the
location of the button based on the visible rect, trying to keep the button visible.
We're handing it the wrong visible rect, though, not taking scrolling into account.
This leads to pages that scroll horizontally showing the button on the left
even if there's space for it on the right, or sometimes not showing it at all.
Instead, provide the actual main FrameView visible rect; the same coordinate
space that the highlight rects are provided in.
- 9:18 AM Changeset in webkit [172343] by
-
- 2 edits in trunk/Source/WebKit2
Additional items added to selection services menus are misaligned
https://bugs.webkit.org/show_bug.cgi?id=135747
<rdar://problem/17933167>
Reviewed by Brady Eidson.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Use NSSharingServicePickerStyleRollover for the rollover image services menu;
use NSSharingServicePickerStyleTextSelection for the selection services menu.
Set NSMenu's showsStateColumn to YES for selection services menus, so that
other items added to the menu line up correctly.
Remove an unncessary .get()
- 5:57 AM Changeset in webkit [172342] by
-
- 7 edits in trunk/Source/WebKit2
[EFL] Remove unnecessary ewk_private.h includes
https://bugs.webkit.org/show_bug.cgi?id=135753
Reviewed by Gyuyoung Kim.
Neither the below file uses the functionality from ewk_private.h.
- UIProcess/API/efl/ewk_context.cpp:
- UIProcess/API/efl/ewk_context_menu_item.cpp:
- UIProcess/API/efl/ewk_cookie_manager.cpp:
- UIProcess/API/efl/ewk_navigation_policy_decision.cpp:
- UIProcess/API/efl/ewk_popup_menu_item.cpp:
- UIProcess/API/efl/ewk_view.cpp:
- 2:31 AM Changeset in webkit [172341] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Do not use GtkWindow:resize-grip-visible with recent GTK+ versions
https://bugs.webkit.org/show_bug.cgi?id=135699
Reviewed by Philippe Normand.
Resize grips support have been removed from GTK+ since 3.13.4, the
API has been deprecated and does nothing.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetToplevelOnScreenWindow):
(resizeWebKitWebViewBaseFromAllocation):
- 1:17 AM Changeset in webkit [172340] by
-
- 4 edits in trunk
[CMake] Drop the required version of CMake down to 2.8.8
https://bugs.webkit.org/show_bug.cgi?id=135713
Reviewed by Alex Christensen.
.:
- CMakeLists.txt: Require CMake 2.8.8.
Source/WebCore:
- CMakeLists.txt: Use set_property() to set INCLUDE_DIRECTORIES for
the ANGLESupport library. This avoids using target_include_directories()
which requires CMake 2.8.11.
- 1:09 AM Changeset in webkit [172339] by
-
- 3 edits in trunk/Tools
commit-log-message has extra blank line at the top of pre-populated message
https://bugs.webkit.org/show_bug.cgi?id=135744
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-08
Reviewed by Csaba Osztrogonác.
Do not add a blank leading line in single ChangeLog commit messages.
- Scripts/commit-log-editor:
(createCommitMessage):
- Scripts/webkitpy/common/checkout/checkout_unittest.py:
(test_commit_message_for_one_reviewed_changelog):
(test_commit_message_for_one_rollout_changelog):
- 12:46 AM Changeset in webkit [172338] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer][1.4] Caps negotiation failure in playback pipeline
https://bugs.webkit.org/show_bug.cgi?id=135607
Reviewed by Carlos Garcia Campos.
Ensure the capsfilters used in front of interleave negotiate their
caps correctly with audioconvert which requires audio buffers with
interleaved layout.
No new tests, existing webaudio tests will cover this change once
we bump our JHBuild moduleset to GStreamer 1.4.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(getGStreamerMonoAudioCaps):
- 12:05 AM Changeset in webkit [172337] by
-
- 5 edits in trunk/Source/WebInspectorUI
REGRESSION(r172094): timeline views are blank after reloading in some situations
https://bugs.webkit.org/show_bug.cgi?id=135742
Reviewed by Timothy Hatcher.
Address various bugs that cause the wrong timeline content views to appear when
starting a recording by reloading the inspected page. Fix other small oversights
that were encountered in the sidebar-based view state restoration code.
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.saveIdentityToCookie): Add a dummy implementation.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.treeElementMatchesCookie):
This code erroneously matches any tree element whose represented object's
saveIdentityToCookie function produces an empty cookie.
- UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._showTimelineView): Add an assertion
that will find mismatches between represented objects of the TimelineContentView
and TimelineViews.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.restoreStateFromCookie): Don't call
the superclass's implementation, since we do not want to perform a relaxed match
against any of our tree elements. The only thing that can be restored across reopen
is a selected timeline tree element, which is already handled by this override.
Aug 7, 2014:
- 11:57 PM Changeset in webkit [172336] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix accidental always true comparison
https://bugs.webkit.org/show_bug.cgi?id=135741
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-07
Reviewed by Timothy Hatcher.
Remove accidental "!" that would always cause this comparison to succeed.
- UserInterface/Views/OverviewTimelineView.js:
(WebInspector.OverviewTimelineView.prototype.updateLayout):
- 11:56 PM Changeset in webkit [172335] by
-
- 4 edits4 deletes in tags/Safari-600.1.8
Merged r172332. <rdar://problem/17848141>
- 11:56 PM Changeset in webkit [172334] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Timeline Filter Bars are not appearing at all
https://bugs.webkit.org/show_bug.cgi?id=135740
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-07
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline.has-non-default-filter > .navigation-bar-container):
(.data-grid.timeline > .navigation-bar-container > .navigation-bar):
(body.mac-platform.legacy .data-grid.timeline > .navigation-bar-container > .navigation-bar):
Update the positioning and height for non-legacy because the console is now taller.
- UserInterface/Views/ScopeBar.js:
(WebInspector.ScopeBar.prototype.hasNonDefaultItemSelected):
Helper to know if there is a non-default filter.
- UserInterface/Views/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):
(WebInspector.TimelineDataGrid.prototype._scopeBarSelectedItemsDidChange):
Update scope bar visibility. If non-default we want to always show it.
(WebInspector.TimelineDataGrid.prototype._updateScopeBarForcedVisibility):
If there is a non-default filter, force showing the bar.
- 11:53 PM Changeset in webkit [172333] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector
https://bugs.webkit.org/show_bug.cgi?id=135745
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-07
Reviewed by Timothy Hatcher.
When restoring breakpoints when the inspector is initializing, do not
let setting these breakpoints automatically enable breakpoints. We should
respect the setting in this case.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.restoreBreakpointsSoon):
(WebInspector.DebuggerManager):
- 11:50 PM Changeset in webkit [172332] by
-
- 4 edits4 deletes in trunk
Unreviewed, rolling out r172291.
https://bugs.webkit.org/show_bug.cgi?id=135748
broke background-attachment-fixed with backround-size-contain
(e.g. iCloud.com) (Requested by thorton on #webkit).
Reverted changeset:
"Fixed backgrounds don't paint in blurred inset areas"
https://bugs.webkit.org/show_bug.cgi?id=135712
http://trac.webkit.org/changeset/172291
- 11:48 PM Changeset in webkit [172331] by
-
- 3 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Combine and minify Esprima
https://bugs.webkit.org/show_bug.cgi?id=135728
Reviewed by Joseph Pecoraro.
- Scripts/combine-resources.pl:
- Scripts/copy-user-interface-resources.pl:
- UserInterface/External/Esprima/LICENSE: Added.
- 9:49 PM Changeset in webkit [172330] by
-
- 5 edits in branches/safari-600.1-branch/Source
Versioning.
- 9:43 PM Changeset in webkit [172329] by
-
- 1 copy in tags/Safari-600.1.8
New Tag.
- 9:28 PM Changeset in webkit [172328] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172287. <rdar://problem/17949615>
- 9:27 PM Changeset in webkit [172327] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r172322. <rdar://problem/17954293>
- 8:51 PM Changeset in webkit [172326] by
-
- 3 edits2 adds in trunk
Subpixel rendering: Border thickness and length flooring can result empty borders
due to losing precision during multiple float <-> LayoutUnit conversions.
https://bugs.webkit.org/show_bug.cgi?id=135686
Reviewed by Simon Fraser.
The combination of losing precision and flooring the border thickness/length to avoid
empty border rect drawing can lead to false positives of missing borders.
This patch moves empty border checking right before painting where we can safely use round
instead of floor.
Source/WebCore:
Tests: fast/borders/hidpi-border-width-flooring.html
- rendering/RenderObject.cpp:
(WebCore::drawBorderLineRect):
(WebCore::drawBorderLine):
(WebCore::RenderObject::drawLineForBoxSide):
LayoutTests:
- fast/borders/hidpi-border-width-flooring-expected.html: Added.
- fast/borders/hidpi-border-width-flooring.html: Added.
- 7:40 PM Changeset in webkit [172325] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Build break with mpegts since r167025
https://bugs.webkit.org/show_bug.cgi?id=135737
Reviewed by Gyuyoung Kim.
- PlatformEfl.cmake: Added includes and libraries about MPEG-TS
- 7:29 PM Changeset in webkit [172324] by
-
- 4 edits in trunk/Source/JavaScriptCore
Create a more generic way for VMEntryScope to notify those interested that it will be destroyed
https://bugs.webkit.org/show_bug.cgi?id=135358
Patch by Saam Barati <sbarati@apple.com> on 2014-08-07
Reviewed by Geoffrey Garen.
When VMEntryScope is destroyed, and it has a flag set indicating that the
Debugger needs to recompile all functions, it calls Debugger::recompileAllJSFunctions.
This flag is only used by Debugger to have VMEntryScope notify it when the
Debugger is safe to recompile all functions. This patch will substitute this
Debugger-specific recompilation flag with a list of callbacks that are notified
when the outermost VMEntryScope dies. This creates a general purpose interface
for being notified when the VM stops executing code via the event of the outermost
VMEntryScope dying.
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::setEntryScopeDidPopListener):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMEntryScope.h:
(JSC::VMEntryScope::setRecompilationNeeded): Deleted.
- 6:37 PM Changeset in webkit [172323] by
-
- 3 edits1 copy in tags/Safari-600.1.4.8/Source/WebCore
Revert the rollout of r172244. <rdar://problem/17939895>
- 6:17 PM Changeset in webkit [172322] by
-
- 2 edits in trunk/Source/WebKit2
[Services with UI] Action menu does not appear if selection includes both text and an image
https://bugs.webkit.org/show_bug.cgi?id=135731
<rdar://problem/17837491>
Reviewed by Dean Jackson.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
Initialize hasRichContentServices with the cached value.
- 6:16 PM Changeset in webkit [172321] by
-
- 2 edits in tags/Safari-600.1.4.8/Source/WebCore
Revert the rollout of r172197. <rdar://problem/17855327>
- 5:50 PM Changeset in webkit [172320] by
-
- 2 edits in tags/Safari-600.1.4.8/Source/WebCore
Roll out r172244. <rdar://problem/17939895>
- 5:42 PM Changeset in webkit [172319] by
-
- 3 edits1 delete in tags/Safari-600.1.4.8/Source/WebCore
Roll out r172197. <rdar://problem/17855327>
- 5:38 PM Changeset in webkit [172318] by
-
- 6 edits7 deletes in trunk/LayoutTests
Get rid of SCRIPTED_SPEECH
https://bugs.webkit.org/show_bug.cgi?id=135729
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-07
Reviewed by Brent Fulgham.
- fast/events/constructors/speech-recognition-error-constructor-expected.txt: Removed.
- fast/events/constructors/speech-recognition-error-constructor.html: Removed.
- fast/events/constructors/speech-recognition-event-constructor-expected.txt: Removed.
- fast/events/constructors/speech-recognition-event-constructor.html: Removed.
- fast/speech/scripted/basics-expected.txt: Removed.
- fast/speech/scripted/basics.html: Removed.
- fast/speech/scripted/navigate-away-expected.txt: Removed.
- fast/speech/scripted/navigate-away-iframe-expected.txt: Removed.
- fast/speech/scripted/navigate-away-iframe.html: Removed.
- fast/speech/scripted/navigate-away.html: Removed.
- fast/speech/scripted/speechgrammar-basics-expected.txt: Removed.
- fast/speech/scripted/speechgrammar-basics.html: Removed.
- fast/speech/scripted/speechrecognition-basics-expected.txt: Removed.
- fast/speech/scripted/speechrecognition-basics.html: Removed.
- fast/speech/scripted/speechrecognition-errors-expected.txt: Removed.
- fast/speech/scripted/speechrecognition-errors.html: Removed.
- fast/speech/scripted/speechrecognitionerror-basics-expected.txt: Removed.
- fast/speech/scripted/speechrecognitionerror-basics.html: Removed.
- fast/speech/scripted/start-exception-expected.txt: Removed.
- fast/speech/scripted/start-exception.html: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/fast/speech/speech-bidi-rendering-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/fast/speech/speech-bidi-rendering-expected.png: Removed.
- platform/mac/fast/speech/speech-bidi-rendering-expected.txt: Removed.
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 5:35 PM Changeset in webkit [172317] by
-
- 3 edits in trunk/Source/WebCore
HTML <sub> and <sup> elements do not work in some 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=135736
Reviewed by Tim Horton.
RootInlineBox::verticalPositionForBox() had some implicit conversions between
LayoutUnit and int that caused overflow, and resulted in different comparison
behavior with an int constant in different architectures, since overflow behavior
is undefined.
Specifically, VerticalPositionCache was written in terms of ints with a special
0x80000000 "not found" value. However, 0x80000000 was being assigned to
a LayoutUnit, which multiplies by 64 causing overflow. The result was then
compared again with 0x80000000 which could pass or fail depending on overflow
behavior.
Fix by converting VerticalPositionCache to use LayoutUnits, and to have a bool
return value with a result out param, instead of a special return value.
Not easily testable, since the difference does not show in DRT output,
and a ref test would be flakey.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::ascentAndDescentForBox):
- rendering/VerticalPositionCache.h:
(WebCore::VerticalPositionCache::get):
(WebCore::VerticalPositionCache::set):
- 5:32 PM Changeset in webkit [172316] by
-
- 19 edits27 deletes in trunk/Source
Get rid of SCRIPTED_SPEECH
https://bugs.webkit.org/show_bug.cgi?id=135729
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-07
Reviewed by Brent Fulgham.
- Configurations/FeatureDefines.xcconfig:
../WebCore:
- Configurations/FeatureDefines.xcconfig:
- Modules/speech/SpeechGrammar.cpp: Removed.
- Modules/speech/SpeechGrammar.h: Removed.
- Modules/speech/SpeechGrammar.idl: Removed.
- Modules/speech/SpeechGrammarList.cpp: Removed.
- Modules/speech/SpeechGrammarList.h: Removed.
- Modules/speech/SpeechGrammarList.idl: Removed.
- Modules/speech/SpeechRecognition.cpp: Removed.
- Modules/speech/SpeechRecognition.h: Removed.
- Modules/speech/SpeechRecognition.idl: Removed.
- Modules/speech/SpeechRecognitionAlternative.cpp: Removed.
- Modules/speech/SpeechRecognitionAlternative.h: Removed.
- Modules/speech/SpeechRecognitionAlternative.idl: Removed.
- Modules/speech/SpeechRecognitionClient.h: Removed.
- Modules/speech/SpeechRecognitionController.cpp: Removed.
- Modules/speech/SpeechRecognitionController.h: Removed.
- Modules/speech/SpeechRecognitionError.cpp: Removed.
- Modules/speech/SpeechRecognitionError.h: Removed.
- Modules/speech/SpeechRecognitionError.idl: Removed.
- Modules/speech/SpeechRecognitionEvent.cpp: Removed.
- Modules/speech/SpeechRecognitionEvent.h: Removed.
- Modules/speech/SpeechRecognitionEvent.idl: Removed.
- Modules/speech/SpeechRecognitionResult.cpp: Removed.
- Modules/speech/SpeechRecognitionResult.h: Removed.
- Modules/speech/SpeechRecognitionResult.idl: Removed.
- Modules/speech/SpeechRecognitionResultList.cpp: Removed.
- Modules/speech/SpeechRecognitionResultList.h: Removed.
- Modules/speech/SpeechRecognitionResultList.idl: Removed.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled): Deleted.
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Deleted.
- bindings/js/JSDictionary.h:
- dom/EventNames.in:
- dom/EventTargetFactory.in:
../WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
../WebKit2:
- Configurations/FeatureDefines.xcconfig:
../WTF:
- wtf/FeatureDefines.h:
- 5:25 PM Changeset in webkit [172315] by
-
- 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r172312
- 5:19 PM Changeset in webkit [172314] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r172313
- 5:15 PM Changeset in webkit [172313] by
-
- 2 edits in trunk/Source/WebInspectorUI
Fix regression where tree outline keyboard navigation is broken.
https://bugs.webkit.org/show_bug.cgi?id=135718
Reviewed by Joseph Pecoraro.
- UserInterface/Views/TreeOutline.js:
(TreeElement.prototype.revealed): Fix the check for currentAncestor.hidden.
- 5:08 PM Changeset in webkit [172312] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Filter bar text and icon are positioned too low and tight
https://bugs.webkit.org/show_bug.cgi?id=135723
Reviewed by Joseph Pecoraro.
- UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]):
(.filter-bar > input[type="search"]::-webkit-search-decoration):
- UserInterface/Views/SearchBar.css:
(.search-bar > input[type="search"]):
- 4:44 PM Changeset in webkit [172311] by
-
- 7 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r172307
- 4:43 PM Changeset in webkit [172310] by
-
- 2 edits in trunk/Tools
[Win] Unreviewed gardening.
Have 'Assemble Build Logs' step work properly for DebugSuffix target
(both 32-bit and 64-bit).
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
- 4:35 PM Changeset in webkit [172309] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed gardening.
Don't build the JSFileException and JSFileReaderSync files in 64-bit; they are already part
of DerivedObjects.cpp.
- WebCore.vcxproj/WebCore.vcxproj: Exclude JSFileException and JSFileReaderSync to avoid
multiple definitions of symbols.
- 4:34 PM Changeset in webkit [172308] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged patch from <rdar://problem/17952779>
- 4:29 PM Changeset in webkit [172307] by
-
- 7 edits in trunk/Source/WebKit2
setCustomSwipeViews inside didChangeBackForwardList client callback is ignored
https://bugs.webkit.org/show_bug.cgi?id=135633
<rdar://problem/17926507>
Reviewed by Sam Weinig.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChangeBackForwardList):
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::clearCustomSwipeViews): Deleted.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::clearCustomSwipeViews): Deleted.
WebKit clears the set of custom swipe views at the end of WebPageProxy::didChangeBackForwardList,
*after* calling into the client. This means that if the client wants to setCustomSwipeViews in
didChangeBackForwardList, it won't be respected.
Since there's only one client of this SPI, let's just stop clearing the list of custom swipe
views in WebKit and leave that totally up to the client.
- 4:26 PM Changeset in webkit [172306] by
-
- 2 edits in tags/Safari-600.1.2.9/Source/WebCore
Merge patch from <rdar://problem/17952463>.
- 4:24 PM Changeset in webkit [172305] by
-
- 5 edits in tags/Safari-600.1.2.9/Source
Versioning.
- 4:22 PM Changeset in webkit [172304] by
-
- 1 copy in tags/Safari-600.1.2.9
New Tag.
- 4:21 PM Changeset in webkit [172303] by
-
- 17 edits in branches/safari-600.1-branch/Source
Merged r172301
- 4:08 PM Changeset in webkit [172302] by
-
- 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r172289
- 4:08 PM Changeset in webkit [172301] by
-
- 17 edits in trunk/Source
[Services with UI] Action menu does not appear if selection includes both text and an image.
https://bugs.webkit.org/show_bug.cgi?id=135731
<rdar://problem/17837491>
Reviewed by Brady Eidson.
Source/WebCore:
When collecting selection rects via SelectionRectGatherer we should also note if the selection
contains non text elements. This way the Notifier class can send that information to ServicesOverlayController
to properly handle the highlight for the service.
- editing/SelectionRectGatherer.cpp:
(WebCore::SelectionRectGatherer::SelectionRectGatherer):
(WebCore::SelectionRectGatherer::Notifier::~Notifier):
(WebCore::SelectionRectGatherer::clearAndCreateNotifier):
- editing/SelectionRectGatherer.h:
(WebCore::SelectionRectGatherer::setTextOnly):
(WebCore::SelectionRectGatherer::isTextOnly):
- page/EditorClient.h:
(WebCore::EditorClient::selectionRectsDidChange):
- rendering/RenderView.cpp:
(WebCore::RenderView::applySubtreeSelection):
Source/WebKit2:
Adding a new setting to ServicesController to communicate to the WebProcess if
there are services installed that can handle a combination of text and images.
This way ServicesOverlayController can decide if it appropriate to show the hightlight
based on the type of selection (text only or non text only). This information is retrieved
when the selection rects are collected by SelectionGatherer and used by
SelectionGatherer::Notifier to communicate the selection change.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
- Shared/WebProcessCreationParameters.h:
- UIProcess/mac/ServicesController.h:
(WebKit::ServicesController::hasRichContentServices):
- UIProcess/mac/ServicesController.mm:
(WebKit::ServicesController::ServicesController):
(WebKit::ServicesController::refreshExistingServices):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::selectionRectsDidChange):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/ServicesOverlayController.h:
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::drawSelectionHighlight):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setEnabledServices):
- WebProcess/WebProcess.h:
(WebKit::WebProcess::hasRichContentServices):
- WebProcess/WebProcess.messages.in:
- 4:06 PM Changeset in webkit [172300] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r172285
- 4:02 PM Changeset in webkit [172299] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r172263
- 4:02 PM Changeset in webkit [172298] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed gardening.
- WebKit.vcxproj/WebKit/WebKitCommon.props: Add $(DebugSuffix) to libraries so
that the DebugSuffix target works properly.
- 3:59 PM Changeset in webkit [172297] by
-
- 91 edits7 copies14 deletes in branches/safari-600.1-branch/Source
Merged r172241
- 3:47 PM Changeset in webkit [172296] by
-
- 10 edits in trunk/Source/ThirdParty/ANGLE
[Win] Unreviewed gardening.
DebugSuffix targets should use our debugsuffix property sheet, and
will therefore build to the proper output location with the proper
suffix tags.
Also, we must use the WebKit_Libraries environment variable, not a set
of relative paths to the property sheets.
- ANGLE.vcxproj/libEGL.vcxproj: Use 'debugsuffix.props' sheet.
- ANGLE.vcxproj/libGLESv2.vcxproj: Ditto.
- ANGLE.vcxproj/preprocessor.vcxproj: Ditto.
- ANGLE.vcxproj/translator_common.vcxproj: Ditto.
- ANGLE.vcxproj/translator_glsl.vcxproj: Ditto.
- ANGLE.vcxproj/translator_hlsl.vcxproj: Ditto.
- ANGLE.vcxproj/libEGLCommon.props: Use $(DebugSuffix) endings.
- ANGLE.vcxproj/libGLESv2Common.props: Ditto.
- ANGLE.vcxproj/translatorCommon.props: Output to 'lib' folder,
not 'bin' folder. These are libraries!
- 3:34 PM Changeset in webkit [172295] by
-
- 4 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172293
- 3:30 PM Changeset in webkit [172294] by
-
- 4 edits5 copies in branches/safari-600.1-branch
Merged r172291
- 3:27 PM Changeset in webkit [172293] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Parental Controls content filter is mistakenly enabled for HTTP responses
https://bugs.webkit.org/show_bug.cgi?id=135730
Reviewed by Brady Eidson.
On the Mac, the WebFilterEvaluator (Parental Controls) content filter should only be enabled for HTTPS
responses. During iOS upstreaming we mistakenly enabled it for HTTP responses as well, and this causes HTTP
responses to be filtered twice -- once by the Parental Controls HTTP proxy and once by WebCore. Revert to the
pre-upstreaming behavior and only enable the content filter for HTTPS responses.
No new tests. Content filtering is not testable from WebKit.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived): Passed the response to ContentFilter::canHandleResponse().
- platform/ContentFilter.h:
- platform/mac/ContentFilterMac.mm:
(WebCore::ContentFilter::canHandleResponse): Renamed from isEnabled(). Checks the response's scheme on Mac to
determine whether WebFilterEvaluator should be used.
(WebCore::ContentFilter::isEnabled): Deleted.
- 3:26 PM Changeset in webkit [172292] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172275
- 3:25 PM Changeset in webkit [172291] by
-
- 4 edits10 adds in trunk
Fixed backgrounds don't paint in blurred inset areas
https://bugs.webkit.org/show_bug.cgi?id=135712
Reviewed by Simon Fraser.
Source/WebCore:
Background geometry calculations for fixed background need to use the larger
visible rect.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
Unfortunately for this test to be valid in WK2, it needs to be run from the
platform/mac-wk2/tiled-drawing directory so that tiled drawing is enabled. So
there are two copies of the test so that we can get coverage for WK1 and WK2.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/fast: Added.
- platform/mac-wk1/fast/backgrounds: Added.
- platform/mac-wk1/fast/backgrounds/resources: Added.
- platform/mac-wk1/fast/backgrounds/resources/green.png: Added.
- platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment-expected.html: Added.
- platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment.html: Added.
- platform/mac-wk2/tiled-drawing/resources/green.png: Added.
- platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-expected.html: Added.
- platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment.html: Added.
- platform/mac/fast/backgrounds/resources: Added.
- 3:22 PM Changeset in webkit [172290] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172231
- 3:21 PM Changeset in webkit [172289] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Dashboard error and warning icons should be filled when enabled
https://bugs.webkit.org/show_bug.cgi?id=135725
Reviewed by Joseph Pecoraro.
- UserInterface/Images/ErrorsEnabled.svg:
- UserInterface/Images/IssuesEnabled.svg:
- 3:20 PM Changeset in webkit [172288] by
-
- 4 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172228
- 3:17 PM Changeset in webkit [172287] by
-
- 2 edits in trunk/Source/WebCore
[EME][Mac] Error codes returned by AVSampleBufferDisplayLayer are negative; clip when passed to JavaScript as doubles.
https://bugs.webkit.org/show_bug.cgi?id=135710
Reviewed by Brent Fulgham.
Return the absolute value of the error codes returned by AVSampleBufferDisplayLayer, so that the conversion from
unsigned -> double does not clip due to the (converted) value being greater than 253.
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
- 3:16 PM Changeset in webkit [172286] by
-
- 5 edits in branches/safari-600.1-branch/Source/WebCore
Merge r172224
- 3:14 PM Changeset in webkit [172285] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dashboard contents shift when window changes active state
https://bugs.webkit.org/show_bug.cgi?id=135724
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-07
Reviewed by Timothy Hatcher.
The container was getting a 1px border when inactive and none when active.
Give it a transparent border when active so contents don't change size.
- UserInterface/Views/DashboardContainerView.css:
(.toolbar .dashboard-container):
- 3:11 PM Changeset in webkit [172284] by
-
- 8 edits in trunk/Source/WebKit2
[EFL] Fix several warnings of doxygen
https://bugs.webkit.org/show_bug.cgi?id=135643
Reviewed by Gyuyoung Kim.
- UIProcess/API/efl/ewk_context_menu_item.h: Removed /info which is not doxygen keyword and unnecessary to the user.
- UIProcess/API/efl/ewk_cookie_manager.h: Fixed parameter name.
- UIProcess/API/efl/ewk_form_submission_request.h: Removed # from Eina_List because doxygen may not know the EFL structures.
- UIProcess/API/efl/ewk_page_group.h: Fixed to match with parameter name.
- UIProcess/API/efl/ewk_settings.h: Fixed wrong keyword and parameter name.
- UIProcess/API/efl/ewk_text_checker.h: Ditto.
- UIProcess/API/efl/ewk_view.h:
- Used escape string for the tag.
- Used @code, @endcode for media query example.
- 3:10 PM Changeset in webkit [172283] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172257
- 3:08 PM Changeset in webkit [172282] by
-
- 2 edits in trunk/Source/JavaScriptCore
SpeculateInt32Operand is sometimes used in a 64-bit context, which has undefined behavior
https://bugs.webkit.org/show_bug.cgi?id=135722
Reviewed by Filip Pizlo.
We should be using SpeculateStrictInt32Operand instead.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 3:07 PM Changeset in webkit [172281] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172244
- 2:50 PM Changeset in webkit [172280] by
-
- 2 edits in tags/Safari-600.1.4.8/Source/WebCore
Merge r172275. <rdar://problem/17886686>
- 2:49 PM Changeset in webkit [172279] by
-
- 7 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r172238
- 2:47 PM Changeset in webkit [172278] by
-
- 3 edits1 copy in branches/safari-600.1-branch/Source/WebCore
Merged r172197
- 2:43 PM Changeset in webkit [172277] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r172275. <rdar://problem/17886686>
- 2:40 PM Changeset in webkit [172276] by
-
- 5 edits in branches/safari-600.1-branch/Source
Merged r172191
- 2:39 PM Changeset in webkit [172275] by
-
- 2 edits in trunk/Source/WebCore
Sometimes Gmail cannot load messages, particularly on refresh ("...the application ran into an unexpected error...")
https://bugs.webkit.org/show_bug.cgi?id=135688
<rdar://problem/17886686>
Reviewed by Alexey Proskuryakov.
Fixes an issue where gmail.com may fail to load the list of messages. In particular, a SQLTransactionCallback
function may not be executed and hence Gmail will not display the list of messages and
will subsequently display an error message.
When a WebKit client defers loading of a page (e.g. -[WebView setDefersCallbacks:YES]), WebCore
may still load the main resource, say if substitute data is available for it, and defer executing
tasks, such as a SQLTransactionCallback function, by appending such tasks to the end of the list
of pending tasks for the associated Document. This list of pending tasks is never processed when
a client subsequently allows loading (e.g. -[WebView setDefersCallbacks:NO])). Therefore, we never
execute a SQLTransactionCallback function that was deferred.
Ideally WebCore would defer loading of substitute data when a WebKit client requests that loading
be deferred and hence a SQLTransactionCallback function would be deferred as a consequence of the
lack of JavaScript script execution (since substitute data wasn't loaded and hence any JavaScript
script contained in the substitute data that initiates a SQL transaction isn't executed). For now,
it's sufficient to only defer executing tasks when either there are existing pending tasks or the
page defers loading and active DOM objects in the document are suspended (e.g. Document::suspendActiveDOMObjects() was called).
- dom/Document.cpp:
(WebCore::Document::postTask):
- 2:37 PM Changeset in webkit [172274] by
-
- 2 edits in branches/safari-600.1-branch
Merged r172183
- 2:33 PM Changeset in webkit [172273] by
-
- 5 edits in branches/safari-600.1-branch
Merged r172027
- 2:31 PM Changeset in webkit [172272] by
-
- 5 edits in branches/safari-600.1-branch
Merged r172005
- 2:28 PM Changeset in webkit [172271] by
-
- 5 edits in branches/safari-600.1-branch
Merged r171997
- 2:26 PM Changeset in webkit [172270] by
-
- 5 edits2 copies in branches/safari-600.1-branch
Merged r171996
- 2:23 PM Changeset in webkit [172269] by
-
- 1 copy in tags/Safari-600.1.4.8
New Tag.
- 2:23 PM Changeset in webkit [172268] by
-
- 1 delete in tags/Safari-600.1.4.8
Delete the Safari-600.1.4.8 tag.
- 2:20 PM Changeset in webkit [172267] by
-
- 1 edit1 copy in tags/Safari-600.1.2.8/Source/WebInspectorUI
Merge r172262.
- 2:19 PM Changeset in webkit [172266] by
-
- 3 edits2 copies in branches/safari-600.1-branch
Merged r171994
- 2:19 PM Changeset in webkit [172265] by
-
- 1 delete in tags/Safari-600.1.4.8/safari-600.1.4-branch
SVN hang caused double tagging.
- 2:18 PM Changeset in webkit [172264] by
-
- 3 edits in trunk/LayoutTests
http/tests/security/cross-frame-access-enumeration.html fails after FTLOPT merge.
<https://webkit.org/b/135708>
Reviewed by Mark Hahnenberg.
- TestExpectations:
- http/tests/security/cross-frame-access-enumeration-expected.txt:
- re-baselined the test results.
- 2:10 PM Changeset in webkit [172263] by
-
- 2 edits in trunk/Source/WebInspectorUI
Fix reference to missing CloseTimeline.svg image.
Rubber-stamped by Joseph Pecoraro.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.createTimelineTreeElement): Use CloseLarge.svg instead.
- 2:09 PM Changeset in webkit [172262] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
[Win] Unreviewed build fix.
Add a WebInspectorUI.proj file for use with MSBuild utility.
- WebInspectorUI.vcxproj/WebInspectorUI.proj: Added.
- 2:08 PM Changeset in webkit [172261] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI
Merged r172217
- 2:06 PM Changeset in webkit [172260] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172215
- 2:04 PM Changeset in webkit [172259] by
-
- 62 edits50 deletes in trunk
Get rid of INPUT_SPEECH
https://bugs.webkit.org/show_bug.cgi?id=135672
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-07
Reviewed by Andreas Kling.
.:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- Modules/speech/SpeechSynthesis.cpp:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setSpeechInputEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::speechInputEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled): Deleted.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in:
- css/html.css:
(input::-webkit-input-speech-button): Deleted.
- dom/Element.h:
(WebCore::Element::isInputFieldSpeechButtonElement): Deleted.
- dom/EventNames.in:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::speechButtonElement): Deleted.
(WebCore::HTMLInputElement::isSpeechEnabled): Deleted.
- html/HTMLInputElement.h:
- html/HTMLInputElement.idl:
- html/InputType.cpp:
(WebCore::InputType::shouldRespectListAttribute):
(WebCore::InputType::shouldRespectSpeechAttribute): Deleted.
- html/InputType.h:
(WebCore::InputType::speechButtonElement): Deleted.
- html/NumberInputType.cpp:
(WebCore::NumberInputType::shouldRespectSpeechAttribute): Deleted.
- html/NumberInputType.h:
- html/PasswordInputType.cpp:
(WebCore::PasswordInputType::shouldRespectSpeechAttribute): Deleted.
- html/PasswordInputType.h:
- html/SearchInputType.cpp:
(WebCore::SearchInputType::shouldRespectSpeechAttribute): Deleted.
- html/SearchInputType.h:
- html/TelephoneInputType.cpp:
(WebCore::TelephoneInputType::shouldRespectSpeechAttribute): Deleted.
- html/TelephoneInputType.h:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::needsContainer):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):
(WebCore::TextFieldInputType::speechButtonElement): Deleted.
- html/TextFieldInputType.h:
- html/TextInputType.cpp:
(WebCore::TextInputType::shouldRespectSpeechAttribute): Deleted.
- html/TextInputType.h:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): Deleted.
(WebCore::InputFieldSpeechButtonElement::~InputFieldSpeechButtonElement): Deleted.
(WebCore::InputFieldSpeechButtonElement::create): Deleted.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): Deleted.
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Deleted.
(WebCore::InputFieldSpeechButtonElement::setState): Deleted.
(WebCore::InputFieldSpeechButtonElement::speechInput): Deleted.
(WebCore::InputFieldSpeechButtonElement::didCompleteRecording): Deleted.
(WebCore::InputFieldSpeechButtonElement::didCompleteRecognition): Deleted.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Deleted.
(WebCore::InputFieldSpeechButtonElement::willAttachRenderers): Deleted.
(WebCore::InputFieldSpeechButtonElement::willDetachRenderers): Deleted.
(WebCore::InputFieldSpeechButtonElement::startSpeechInput): Deleted.
(WebCore::InputFieldSpeechButtonElement::stopSpeechInput): Deleted.
- html/shadow/TextControlInnerElements.h:
(WebCore::toInputFieldSpeechButtonElement): Deleted.
- page/SpeechInput.cpp: Removed.
- page/SpeechInput.h: Removed.
- page/SpeechInputClient.h: Removed.
- page/SpeechInputEvent.cpp: Removed.
- page/SpeechInputEvent.h: Removed.
- page/SpeechInputEvent.idl: Removed.
- page/SpeechInputListener.h: Removed.
- page/SpeechInputResult.cpp: Removed.
- page/SpeechInputResult.h: Removed.
- page/SpeechInputResult.idl: Removed.
- page/SpeechInputResultList.cpp: Removed.
- page/SpeechInputResultList.h: Removed.
- page/SpeechInputResultList.idl: Removed.
- platform/ThemeTypes.h:
- rendering/RenderInputSpeech.cpp: Removed.
- rendering/RenderInputSpeech.h: Removed.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustInputFieldSpeechButtonStyle): Deleted.
(WebCore::RenderTheme::paintInputFieldSpeechButton): Deleted.
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
Source/WebInspectorUI:
- UserInterface/Models/CSSKeywordCompletions.js:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- PlatformGTK.cmake:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
(addMockSpeechInputResultCallback): Deleted.
(setMockSpeechInputDumpRectCallback): Deleted.
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addMockSpeechInputResult): Deleted.
(TestRunner::setMockSpeechInputDumpRect): Deleted.
(TestRunner::startSpeechInput): Deleted.
LayoutTests:
- fast/forms/input-user-modify.html:
- fast/speech/bubble-position-expected.txt: Removed.
- fast/speech/bubble-position-scrolled-expected.txt: Removed.
- fast/speech/bubble-position-scrolled.html: Removed.
- fast/speech/bubble-position.html: Removed.
- fast/speech/change-focus-expected.txt: Removed.
- fast/speech/change-focus.html: Removed.
- fast/speech/input-appearance-numberandspeech.html: Removed.
- fast/speech/input-appearance-searchandspeech.html: Removed.
- fast/speech/input-appearance-speechbutton.html: Removed.
- fast/speech/input-onspeechchange-event-expected.txt: Removed.
- fast/speech/input-onspeechchange-event.html: Removed.
- fast/speech/input-ontextinput-event-expected.txt: Removed.
- fast/speech/input-ontextinput-event.html: Removed.
- fast/speech/input-readonly-and-disabled-expected.txt: Removed.
- fast/speech/input-readonly-and-disabled.html: Removed.
- fast/speech/input-text-language-tag-expected.txt: Removed.
- fast/speech/input-text-language-tag.html: Removed.
- fast/speech/input-text-speechbutton-expected.txt: Removed.
- fast/speech/input-text-speechbutton.html: Removed.
- fast/speech/input-text-speechstart-expected.txt: Removed.
- fast/speech/input-text-speechstart.html: Removed.
- fast/speech/intrinsic-input-width-with-speech-border-padding-expected.txt: Removed.
- fast/speech/intrinsic-input-width-with-speech-border-padding.html: Removed.
- fast/speech/speech-bidi-rendering.html: Removed.
- fast/speech/speech-button-ignore-generated-events-expected.txt: Removed.
- fast/speech/speech-button-ignore-generated-events.html: Removed.
- fast/speech/speech-input-result-list-not-enough-arguments-expected.txt: Removed.
- fast/speech/speech-input-result-list-not-enough-arguments.html: Removed.
- fast/speech/speech-input-scripting-expected.txt: Removed.
- fast/speech/speech-input-scripting.html: Removed.
- fast/speech/speech-style-on-non-speech-elements-expected.txt: Removed.
- fast/speech/speech-style-on-non-speech-elements.html: Removed.
- platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
- platform/gtk/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
- platform/ios-sim/fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
- platform/ios-sim/fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
- platform/ios-sim/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
- 2:03 PM Changeset in webkit [172258] by
-
- 7 edits in branches/safari-600.1-branch
Merged r172213
- 2:01 PM Changeset in webkit [172257] by
-
- 2 edits in trunk/Source/WebCore
Create UTF-8 string from in-band VTT cues
https://bugs.webkit.org/show_bug.cgi?id=135716
Reviewed by Brent Fulgham.
Tests will be added in https://bugs.webkit.org/show_bug.cgi?id=135717.
- platform/graphics/ISOVTTCue.cpp:
(WebCore::ISOBox::peekString): Call String::fromUTF8 because we know that VTT is always
UTF-8.
- 2:01 PM Changeset in webkit [172256] by
-
- 1 copy in tags/Safari-600.1.4.8/safari-600.1.4-branch
New Tag
- 2:00 PM Changeset in webkit [172255] by
-
- 1 copy in tags/Safari-600.1.4.8
New Tag
- 1:56 PM Changeset in webkit [172254] by
-
- 8 edits in branches/safari-600.1-branch/Source
Merged r172202
- 1:56 PM Changeset in webkit [172253] by
-
- 2 edits in trunk/LayoutTests
Gardening: Mark some tests as failing to green the bots.
<https://webkit.org/b/135720>
Not reviewed.
- 1:53 PM Changeset in webkit [172252] by
-
- 3 edits in branches/safari-600.1-branch/Source/WebKit2
Merged r172200
- 1:51 PM Changeset in webkit [172251] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r172244. <rdar://problem/17939895>
- 1:51 PM Changeset in webkit [172250] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172195
- 1:50 PM Changeset in webkit [172249] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected
https://bugs.webkit.org/show_bug.cgi?id=135372
Reviewed by Timothy Hatcher.
Constrain move selection window dragging to the ruler bounds
based on the mouse down position on the drag window.
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype._handleMouseDown):
(WebInspector.TimelineRuler.prototype._handleMouseMove):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
- 1:49 PM Changeset in webkit [172248] by
-
- 14 edits in branches/safari-600.1-branch/Source
Merged r172193
- 1:47 PM Changeset in webkit [172247] by
-
- 3 edits2 copies in branches/safari-600.1-branch
Merged r172183
- 1:44 PM Changeset in webkit [172246] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172179
- 1:41 PM Changeset in webkit [172245] by
-
- 15 edits in branches/safari-600.1-branch/Source
Merged r172172
- 1:41 PM Changeset in webkit [172244] by
-
- 2 edits in trunk/Source/WebCore
Disable implicit animations on video layer.
https://bugs.webkit.org/show_bug.cgi?id=135679
Reviewed by Eric Carlson.
Disable implicit animations on AVPlayerLayer except when setting fullscreen frame.
This prevents unwanted animations.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): disable implicit animations
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame): allow implicit animations while changing fullscreen frame.
- 1:37 PM Changeset in webkit [172243] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Versioning.
- 1:33 PM Changeset in webkit [172242] by
-
- 3 edits2 copies in branches/safari-600.1-branch
Merged r172160
- 1:31 PM Changeset in webkit [172241] by
-
- 91 edits45 copies8 moves8 adds6 deletes in trunk/Source
Web Inspector: Update glyphs to be more like Xcode 6
https://bugs.webkit.org/show_bug.cgi?id=135705
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/Base/ImageUtilities.js:
(platformImagePath): Added.
(generateEmbossedImages.generateImage):
Bump the base image version. Helper function. Use isLegacyMacOS.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector._updateDockNavigationItems):
(WebInspector._generateDisclosureTriangleImages):
Use new images and add legacy path. Remove the shadow.
- UserInterface/Images: Updated images.
- UserInterface/Images/Legacy: Added. Moved legacy images here.
- UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section):
(body.mac-platform.legacy .style-declaration-section + .style-declaration-section):
(.style-declaration-section.last-in-group):
(.style-declaration-section.last-in-group + .style-declaration-section):
Use a consistent gray for borders.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content > .pseudo-classes):
Use a consistent gray for borders.
- UserInterface/Views/ContentBrowser.js:
(WebInspector.ContentBrowser):
Use new images and add legacy path.
- UserInterface/Views/ControlToolbarItem.css:
(.toolbar .item.control):
(body.mac-platform.legacy .toolbar .item.control):
(.toolbar .item.control:hover):
(body.mac-platform.legacy .toolbar .item.control:hover):
Adjust the opacity for controls.
- UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView):
Use new images and add legacy path.
- UserInterface/Views/DataGrid.css:
(.data-grid tr.selected):
Use a consistent gray for borders.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.get _generateSortIndicatorImagesIfNeeded):
Use new images and add legacy path. Remove the shadow.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
Use new images and add legacy path.
- UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default > .item):
(body.mac-platform.legacy .toolbar .dashboard.default > .item):
(body.mac-platform.legacy .toolbar .dashboard.default > .resourcesCount > img):
(body.mac-platform.legacy .toolbar .dashboard.default > .time > img):
(body.mac-platform.legacy .toolbar .dashboard.default > .logs > img):
(body.mac-platform.legacy .toolbar .dashboard.default > .resourcesSize > img):
(body.mac-platform.legacy .toolbar .dashboard.default > .errors > img):
(body.mac-platform.legacy .toolbar .dashboard.default > .errors.enabled > img):
(body.mac-platform.legacy .toolbar .dashboard.default > .issues > img):
(body.mac-platform.legacy .toolbar .dashboard.default > .issues.enabled > img):
Use new images and add legacy path.
- UserInterface/Views/DetailsSection.css:
(.details-section):
(.details-section .details-section:first-child):
(body.mac-platform.legacy .details-section > .header):
(.details-section > .content > .group):
(.details-section > .content > .group:nth-child(even) > .row.simple:first-child > *):
(body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *):
Use a consistent gray for borders.
- UserInterface/Views/FilterBar.css:
(body.mac-platform.legacy .filter-bar > input[type="search"]::-webkit-search-decoration):
Use new images and add legacy path.
- UserInterface/Views/FindBanner.css:
(.find-banner):
Use a consistent gray for borders.
- UserInterface/Views/FindBanner.js:
(WebInspector.FindBanner.prototype._generateButtonsGlyphsIfNeeded):
Add legacy path.
- UserInterface/Views/FrameTreeElement.js:
(WebInspector.FrameTreeElement.prototype.updateStatusForMainFrame):
Use new images and add legacy path.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
Use new images and add legacy path.
- UserInterface/Views/Main.css:
(#split-content-browser):
Use a consistent gray for borders.
- UserInterface/Views/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .overflow-shadow):
(body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow):
(.sidebar > .panel.navigation > .overflow-shadow.top):
(body.mac-platform.legacy .sidebar > .panel.navigation > .overflow-shadow.top):
(.sidebar > .panel.navigation > .empty-content-placeholder):
(body.mac-platform.legacy .sidebar > .panel.navigation > .empty-content-placeholder):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected .disclosure-button):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected.expanded .disclosure-button):
(.navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected):
Adjust the styles to make the selected item use white text and icons only when focused.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype._generateDisclosureTrianglesIfNeeded):
Remove the shadow from the disclosure triangles. Make the overflow shadow not fade.
- UserInterface/Views/ProbeDetailsSidebarPanel.css:
(.details-section.probe-set .options > .probe-clear-samples):
(.details-section.probe-set .options > .probe-remove):
(.details-section.probe-set .options > .probe-add):
(body.mac-platform.legacy .details-section.probe-set .options > .probe-clear-samples):
(body.mac-platform.legacy .details-section.probe-set .options > .probe-remove):
(body.mac-platform.legacy .details-section.probe-set .options > .probe-add):
Tweak size and position of icons and use legacy paths.
- UserInterface/Views/QuickConsole.css:
(.quick-console):
Adjust padding to match filter bar height.
- UserInterface/Views/ResourceSidebarPanel.css:
(.sidebar > .panel.navigation.resource > .search-bar):
Adjust height.
- UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
(.sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule img):
Use a consistent gray for borders. Don't bold the New Rule label.
- UserInterface/Views/ScriptContentView.js:
(WebInspector.ScriptContentView):
Use new images and add legacy path.
- UserInterface/Views/Sidebar.css:
(.sidebar.left):
(.sidebar.right):
Use a consistent gray for borders.
- UserInterface/Views/TextContentView.js:
(WebInspector.TextContentView):
Use new images and add legacy path.
- UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView):
Use new images and add legacy path.
- UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView):
Use new images and add legacy path.
- UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th):
(.data-grid.timeline th.sortable:active):
(.data-grid.timeline th.sort-descending):
Fix a regression with the gradient background showing in legacy mode.
- UserInterface/Views/TimelineIcons.css:
(body.mac-platform.legacy .network-icon .icon):
(body.mac-platform.legacy .network-icon.large .icon):
(body.mac-platform.legacy .colors-icon .icon):
(body.mac-platform.legacy .colors-icon.large .icon):
Added legacy versions of these icons.
- UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:active):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph:hover):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording:hover):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.forced):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .status-bar > .record-glyph.recording.forced):
(.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):
Update the styles for the recording button and close button.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.createTimelineTreeElement):
Use TreeElementStatusButton instead of a styled image.
- UserInterface/Views/TreeElementStatusButton.css:
(.item > .status > .status-button > svg path.filled):
(body.mac-platform.legacy .item > .status > .status-button > svg path.filled):
(:focus .item.selected > .status > .status-button > svg path.filled):
(.item > .status > .status-button > svg path.stroked):
(body.mac-platform.legacy .item > .status > .status-button > svg path.stroked):
(:focus .item.selected > .status > .status-button > svg path.stroked):
(.item.selected > .status > .status-button:active):
(.item > .status > .status-button.disabled):
Updated selectors and styles to work with stroke or fill.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Added new images.
Source/WebKit/mac:
- Resources/Dock.pdf: Added.
- Resources/DockLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
- WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController window]): Use new images.
Source/WebKit2:
- Resources/DockBottom.pdf: Added.
- Resources/DockBottomLegacy.pdf: Copied from Source/WebKit/mac/Resources/Dock.pdf.
- Resources/DockRight.pdf: Added.
- Resources/DockRightLegacy.pdf: Copied from Source/WebKit2/Resources/DockRight.pdf.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::createInspectorWindow): Use new images.
- WebKit2.xcodeproj/project.pbxproj: Added new images.
- 1:30 PM Changeset in webkit [172240] by
-
- 7 edits in branches/safari-600.1.4-branch/Source/WebKit2
Merge r172238. <rdar://problem/17940220>
- 1:29 PM Changeset in webkit [172239] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172159
- 1:27 PM Changeset in webkit [172238] by
-
- 7 edits in trunk/Source/WebKit2
WebContent needs access to HSTS database due to some networking still being performed in process
https://bugs.webkit.org/show_bug.cgi?id=135711
<rdar://17940220>
Reviewed by Alexey Proskuryakov.
Simple patch in the same theme as the equivalent network process
extension. Provide an extension that covers the WebContent specific
HSTS file and consume it on launch.
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
- UIProcess/WebContext.h:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::webContentHSTSDatabasePath):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 1:26 PM Changeset in webkit [172237] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r172151
- 1:21 PM Changeset in webkit [172236] by
-
- 3 edits4 copies in branches/safari-600.1-branch
Merge r172112
- 1:20 PM Changeset in webkit [172235] by
-
- 8 edits in trunk/Source
Source/WebCore:
Provide methods to clear undesired references to HistoryItems that have been removed from the back/forard list.
https://bugs.webkit.org/show_bug.cgi?id=135634
<rdar://problem/17388461>
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2014-08-07
Reviewed by Brady Eidson.
No new tests. Would require an API test that also needs an httpd, which we don't currently support.
- WebCore.exp.in:
Added export for Page::clearPreviousItemFromAllPages.
- loader/HistoryController.cpp:
(WebCore::HistoryController::clearPreviousItem):
Clear m_previousItem and iterate over children recursively calling clearPreviousItem().
The m_previousItem is cleared for the target HistoryController, and all of its descendents.
- loader/HistoryController.h:
Declared HistoryController::clearPreviousItem.
- page/Page.cpp:
(WebCore::Page::clearPreviousItemFromAllPages):
Iterate over each page in the web process, checking if the previous item of
the HistoryController for the main frame is the same as the item being removed. If so, the
frameTree is traversed and each associated HistoryController has its m_previousItem cleared.
- page/Page.h:
Declared Page::clearPreviousItemFromAllPages.
Source/WebKit2:
Clear the m_previousItem member of HistoryControllers when it matches the HistoryItem being removed.
https://bugs.webkit.org/show_bug.cgi?id=135634
<rdar://problem/17388461>
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2014-08-07
Reviewed by Brady Eidson.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::removeItem):
Call WebCore::Page::clearPreviousItemFromAllPages() for each item removed from
the back/forward list to ensure the page URL is released from IconDatabase.
- 1:19 PM Changeset in webkit [172234] by
-
- 3 edits1 copy in branches/safari-600.1.4-branch/Source/WebCore
Merge r172197. <rdar://problem/17855327>
- 1:15 PM Changeset in webkit [172233] by
-
- 5 edits in branches/safari-600.1.4-branch/Source
Merge r172191. <rdar://problem/17895138>
- 1:08 PM Changeset in webkit [172232] by
-
- 3 edits2 copies in branches/safari-600.1.4-branch
Merge r172183. <rdar://problem/17908085>
- 1:04 PM Changeset in webkit [172231] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix attempt #2 following r172224.
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
- 1:01 PM Changeset in webkit [172230] by
-
- 4 edits in branches/safari-600.1-branch/Source
Merge r172035
- 12:55 PM Changeset in webkit [172229] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r172006. <rdar://problem/17947503>
- 12:53 PM Changeset in webkit [172228] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix following r172224.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
- html/track/VTTCue.h:
- 12:52 PM Changeset in webkit [172227] by
-
- 8 edits in tags/Safari-600.1.2.8/Source
Merged r172202. <rdar://problem/17946619>
- 12:50 PM Changeset in webkit [172226] by
-
- 5 edits in tags/Safari-600.1.2.8/Source
Versioning.
- 12:44 PM Changeset in webkit [172225] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r172219.
Caused some /fast/workers tests to fail; will investigate
offline.
Reverted changeset:
"Sometimes Gmail cannot load messages, particularly on refresh
("...the application ran into an unexpected error...")"
https://bugs.webkit.org/show_bug.cgi?id=135688
http://trac.webkit.org/changeset/172219
- 12:34 PM Changeset in webkit [172224] by
-
- 5 edits in trunk/Source/WebCore
Increase width of caption container if a larger font size is selected from user prefs.
https://bugs.webkit.org/show_bug.cgi?id=135677.
Reviewed by Brent Fulgham.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay):
Upon creation of a VTTCueBox make sure to supply the font size set by the user prefs.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
Increase the width of the cue box based on user prefs font size selection.
- html/track/VTTCue.h:
Keep track of the font size set in the user prefs for use when the cue boxes are created.
(WebCore::VTTCueBox::setFontSizeFromCaptionUserPrefs):
- html/track/VTTCue.cpp:
(WebCore::VTTCueBox::applyCSSProperties):
Increase the width of the cue box based on user prefs font size selection.
(WebCore::VTTCue::getDisplayTree):
(WebCore::VTTCue::setFontSize):
If the font size set is important then we don't want to use the font size set by user prefs, set it to 0.
- 12:33 PM Changeset in webkit [172223] by
-
- 1 copy in tags/Safari-600.1.2.8
New Tag.
- 12:28 PM Changeset in webkit [172222] by
-
- 2 edits in trunk/LayoutTests
Gardening: Mark test as failing in TestExpectations until the issue can be investigated.
<https://webkit.org/b/135708>
Not reviewed.
- 12:17 PM Changeset in webkit [172221] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r172220.
- css/SelectorChecker.cpp:
(WebCore::hasScrollbarPseudoElement):
Use ASSERT_UNUSED instead of just ASSERT.
- 11:55 AM Changeset in webkit [172220] by
-
- 9 edits4 adds in trunk
Compile scrollbar pseudoclass css selectors.
https://bugs.webkit.org/show_bug.cgi?id=135242
Reviewed by Benjamin Poulain.
Source/WebCore:
Tests: scrollbars/corner-resizer-window-inactive.html
scrollbars/scrollbar-selectors.html
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
Changed assertion because there are pseudo-elements selectors that return CannotCompileAnything now, which
make SimpleSelectorCheckers.
Add scrollbar, scrollbarPart, and document to the CheckingContext and compile scrollbar pseudo-element selectors.
- css/SelectorChecker.cpp:
(WebCore::hasScrollbarPseudoElement):
Added. Logic moved from matchRecursively to be easier to read and to add assertions.
context.scrollbar is always non-null when dynamicPseudo is SCROLLBAR_CORNER.
(WebCore::SelectorChecker::matchRecursively):
Moved logic to hasScrollbarPseudoElement.
(WebCore::SelectorChecker::checkOne):
checkScrollbarPseudoClass accesses the document through the element now.
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
- css/SelectorCheckerTestFunctions.h:
(WebCore::scrollbarMatchesEnabledPseudoClass):
(WebCore::scrollbarMatchesDisabledPseudoClass):
(WebCore::scrollbarMatchesHoverPseudoClass):
(WebCore::scrollbarMatchesActivePseudoClass):
(WebCore::scrollbarMatchesHorizontalPseudoClass):
(WebCore::scrollbarMatchesVerticalPseudoClass):
(WebCore::scrollbarMatchesDecrementPseudoClass):
(WebCore::scrollbarMatchesIncrementPseudoClass):
(WebCore::scrollbarMatchesStartPseudoClass):
(WebCore::scrollbarMatchesEndPseudoClass):
(WebCore::scrollbarMatchesDoubleButtonPseudoClass):
(WebCore::scrollbarMatchesSingleButtonPseudoClass):
(WebCore::scrollbarMatchesNoButtonPseudoClass):
(WebCore::scrollbarMatchesCornerPresentPseudoClass):
Move scrollbar selector logic from SelectorChecker.cpp to SelectorCheckerTestFunctions.h
For window-inactive pseudo classes, we now access the document through the element instead of as a separate parameter.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::appendUnoptimizedPseudoClassWithContext):
(WebCore::SelectorCompiler::addScrollbarPseudoClassType):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::isScrollbarPseudoElement):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
Call functions for unoptimized pseudo classes that require a context.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateContextFunctionCallTest):
Added. Similar to generateElementFunctionCallTest, but the CheckingContext pointer is stored on the stack instead of a dedicated register.
- cssjit/SelectorCompiler.h:
Added scrollbar, scrollbarPart, and document to the CheckingContext.
(WebCore::SelectorCompiler::CheckingContext::document):
Added method to access the document in a way that is syntactically equal to SelectorCheckingContext.
This way, the template functions in SelectorCheckerTestFunctions.h can be compiled with both context types,
but the context types store the document differently.
LayoutTests:
- platform/wk2/TestExpectations:
Don't run corner-resizer-window-inactive-expected in WK2 because testRunner.setWindowIsKey doesn't work with WK2.
- scrollbars/corner-resizer-window-inactive-expected.html: Added.
- scrollbars/corner-resizer-window-inactive.html: Added.
- scrollbars/scrollbar-selectors-expected.txt: Added.
- scrollbars/scrollbar-selectors.html: Added.
- 11:46 AM Changeset in webkit [172219] by
-
- 2 edits in trunk/Source/WebCore
Sometimes Gmail cannot load messages, particularly on refresh ("...the application ran into an unexpected error...")
https://bugs.webkit.org/show_bug.cgi?id=135688
<rdar://problem/17886686>
Reviewed by Maciej Stachowiak.
Fixes an issue where gmail.com may fail to load the list of messages. In particular, a SQLTransactionCallback
function may not be executed and hence Gmail will not display the list of messages and
will subsequently display an error message.
When a WebKit client defers loading of a page (e.g. -[WebView setDefersCallbacks:YES]), WebCore
may still load the main resource, say if substitute data is available for it, and defer executing
tasks, such as a SQLTransactionCallback function, by appending such tasks to the end of the list
of pending tasks for the associated Document. This list of pending tasks is never processed when
a client subsequently allows loading (e.g. -[WebView setDefersCallbacks:NO])). Therefore, we never
execute a SQLTransactionCallback function that was deferred.
Ideally WebCore would defer loading of substitute data when a WebKit client requests that loading
be deferred and hence a SQLTransactionCallback function would be deferred as a consequence of the
lack of JavaScript script execution (since substitute data wasn't loaded and hence any JavaScript
script contained in the substitute data that initiates a SQL transaction isn't executed). For now,
it's sufficient to only defer executing tasks when either there are existing pending tasks or the
active DOM objects for the document are suspended (e.g. Document::suspendActiveDOMObjects() was called).
- dom/Document.cpp:
(WebCore::Document::postTask):
- 11:23 AM Changeset in webkit [172218] by
-
- 3 edits2 adds in trunk
border-radius on html does not render properly.
https://bugs.webkit.org/show_bug.cgi?id=135706
Reviewed by Simon Fraser.
Ensure that background is initialized when border-radius is present.
Source/WebCore:
Test: fast/borders/border-radius-on-html.html
- rendering/RenderView.cpp:
(WebCore::rendererObscuresBackground):
LayoutTests:
- fast/borders/border-radius-on-html-expected.html: Added.
- fast/borders/border-radius-on-html.html: Added.
- 10:57 AM Changeset in webkit [172217] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: DebuggerManager sends spurious setBreakpointsActive commands when setting a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=135674
Reviewed by David Kilzer.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.set breakpointsEnabled): Fix a typo.
- 10:29 AM Changeset in webkit [172216] by
-
- 4 edits in trunk
for-in is failing fast/dom/dataset-xhtml.xhtml and dataset.html tests
https://bugs.webkit.org/show_bug.cgi?id=135681
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
- runtime/Structure.cpp:
(JSC::Structure::canCacheGenericPropertyNameEnumerator): We were checking the entire
prototype chain for overridesGetPropertyNames, but we were neglecting to check the
base object's Structure. D'oh!
LayoutTests:
Removed the two failing tests from the TestExpectations list since they pass now!
- 10:20 AM Changeset in webkit [172215] by
-
- 2 edits in trunk/Source/WebCore
Random resource replacement on beta.icloud.com
https://bugs.webkit.org/show_bug.cgi?id=135685
<rdar://problem/17937975>
Reviewed by Alexey Proskuryakov.
Revert the performance optimization in r170499. It turns out we could get a delayed disk
cache notification for a resource that has since been changed in WebCore. In such a case, we
were replacing the newer resource data with the older disk cached resource data. This was
happening for cached POST content on beta.icloud.com. Fix this by forcing a memcmp of data
contents before replacing it which is what we used to do before.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData):
- 9:37 AM Changeset in webkit [172214] by
-
- 3 edits in trunk/Tools
The support directory shouldn't be skipped unconditionally in test import
https://bugs.webkit.org/show_bug.cgi?id=135660
Reviewed by Ryosuke Niwa.
The 'DIRS_TO_SKIP' should only be skipped when in the root directory
of the test repo, as that's the only time they are special. In
addition, instead of hardcoding .hg and .git as special, skip all
directories that begin with '.', just like with files that begin with '.'.
In order to make this work, the root directory must always be
passed in, so the interface to the script has been changed to take the
root directory, and if one wants to only import a subset of the tests,
a new -t option can be used to limit the tests imported.
- Scripts/webkitpy/w3c/test_importer.py:
(main): Remove repo_dir command line argument.
(parse_args): Add -t option and set expected non-option args to 1.
(TestImporter.init): Remove repo_dir.
(TestImporter.do_import): Handle the varying number of import
directories.
(TestImporter.should_keep_subdir): Helper for find_importable_tests to
determine if a subdirectory should be skipped.
(TestImporter.find_importable_tests): Filter directories using new
helper.
(TestImporter.import_tests): Remove use of repo_dir.
(TestImporter.setup_destination_directory): Unused, Deleted.
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Update for
new API.
(TestImporterTest.test_import_dir_with_no_tests): Ditto.
- 9:23 AM Changeset in webkit [172213] by
-
- 7 edits in trunk
[Mac, iOS] Captions are appearing multiple times during repeated video play through
https://bugs.webkit.org/show_bug.cgi?id=135680
Source/WebCore:
<rdar://problem/17926802>
Reviewed by Eric Carlson.
Test: media/track/track-in-band-cues-added-once.html
Revert TextTrackCueGeneric::isOrderedBefore logic to its original form, and add
a new 'isOrderedBeforeDuringDisplay' for the special case of displaying captions.
- html/shadow/MediaControlElements.cpp:
(WebCore::compareCueIntervalForDisplay): Added helper function.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Use the new
'isOrderedBeforeDuringDisplay' to order the cues for display.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::isOrderedBeforeDuringDisplay): Added. This just
calls the existing 'isOrderedBefore' method.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore): Revert to logic used
prior to r171700.
(WebCore::TextTrackCueGeneric::isOrderedBeforeDuringDisplay): New method that
implements the behavior in r171700.
- html/track/TextTrackCueGeneric.h:
LayoutTests:
<rdar://problem/17926802>
Reviewed by Eric Carlson.
Reactivate the 'track-in-band-cues-added-once.html' test. We would have caught
this bug immediately if the test had been enabled.
- platform/mac/TestExpectations: Turn 'track-in-band-cues-added-once.html' back
on.
- 9:06 AM Changeset in webkit [172212] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Taking a paused video full screen flashes black at beginning of animation.
https://bugs.webkit.org/show_bug.cgi?id=135668
Reviewed by Eric Carlson.
When entering fullscreen, the full screen window will momentarily occlude the browser
window, causing a visiblity change notification. To avoid flickering when client buffering
is disabled, throttle calls to updateClientDataBuffering by delaying those calls for a
short period.
- platform/audio/MediaSession.cpp:
(WebCore::MediaSession::MediaSession):
(WebCore::MediaSession::clientWillPausePlayback):
(WebCore::MediaSession::visibilityChanged):
(WebCore::MediaSession::clientDataBufferingTimerFired):
(WebCore::MediaSession::updateClientDataBuffering):
- platform/audio/MediaSession.h:
- 7:58 AM Changeset in webkit [172211] by
-
- 13 edits in trunk
[GTK] Use WebKitNavigationAction also for WebKitNavigationPolicyDecision
https://bugs.webkit.org/show_bug.cgi?id=135695
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
WebKitNavigationAction was introduced to extend WebKitWebView::create signal
and its API is mostly duplicated in WebKitNavigationPolicyDecision.
Use WebKitNavigationAction insternally in WebKitNavigationPolicyDecision and
deprecated all the duplicated API in favor of a single property navigation-action.
- UIProcess/API/gtk/WebKitDefines.h: Remove unused macro
WEBKIT_OBSOLETE and add WEBKIT_DEPRECATED and WEBKIT_DEPRECATED_FOR.
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
(_WebKitNavigationPolicyDecisionPrivate::~_WebKitNavigationPolicyDecisionPrivate):
Free the WebKitNavigationAction.
(webkitNavigationPolicyDecisionGetProperty): Add getter for
navigation-action and use WebKitNavigationAction in all other getters.
(webkit_navigation_policy_decision_class_init): Add navigation-action
property and deprecated all others except frame-name.
(webkit_navigation_policy_decision_get_navigation_action): Return the WebKitNavigationAction.
(webkit_navigation_policy_decision_get_navigation_type): Use WebKitNavigationAction.
(webkit_navigation_policy_decision_get_mouse_button): Ditto.
(webkit_navigation_policy_decision_get_modifiers): Ditto.
(webkit_navigation_policy_decision_get_request): Ditto.
(webkitNavigationPolicyDecisionCreate):
(webkitNewWindowPolicyDecisionCreate):
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.h:
- UIProcess/API/gtk/WebKitNavigationPolicyDecisionPrivate.h:
- UIProcess/API/gtk/WebKitPolicyClient.cpp: Use a custom
PolicyClient class so that we receive a NavigationActionData in
the callbacks.
(attachPolicyClientToView):
(toWebKitNavigationType): Deleted.
(decidePolicyForNavigationAction): Deleted.
(decidePolicyForNewWindowAction): Deleted.
(decidePolicyForResponse): Deleted.
- UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:
(webkitResponsePolicyDecisionCreate):
- UIProcess/API/gtk/WebKitResponsePolicyDecisionPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
deprecated symbols.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
Tools:
Use WebKitNavigationAction API.
- MiniBrowser/gtk/BrowserWindow.c:
(webViewDecidePolicy):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
(testNavigationPolicy):
- 7:11 AM Changeset in webkit [172210] by
-
- 2 edits in trunk/Source/WebCore
ASSERT in Document::unregisterCollection reloading apple.com
https://bugs.webkit.org/show_bug.cgi?id=135168
Reviewed by Andreas Kling.
- dom/Document.cpp:
(WebCore::Document::unregisterCollection): This assertion was failing
because the passed-in HTMLCollection was not invalidated for a non-related
attribute, but was instead unregistered during destruction, at which point
the m_collectionsInvalidatedAtDocument HashSet was empty.
The assertion could be trivially reduced into checking that the HashSet is
empty when it was moved out of in Document::invalidateNodeListAndCollectionCaches(),
but that just checks that the move semantics on HashSet work properly. Removing
a non-existent element from a HashSet is harmless, so the assertion can be removed
completely.
- 6:06 AM Changeset in webkit [172209] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for failing tests.
- platform/efl/TestExpectations:
- platform/efl/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Rebaseline after r172136.
- 5:38 AM Changeset in webkit [172208] by
-
- 4 edits in trunk/Source/WebKit2
Move Soup specific code out of WebCoreArgumentCoders.cpp
https://bugs.webkit.org/show_bug.cgi?id=135665
Reviewed by Anders Carlsson.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceRequest>::decode):
(IPC::ArgumentCoder<ResourceError>::encode):
(IPC::ArgumentCoder<ResourceError>::decode):
- Shared/WebCoreArgumentCoders.h:
Soup is the only client for this code. Move it to *Soup.cpp
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
(IPC::ArgumentCoder<ResourceError>::encodePlatformData):
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):
- 5:08 AM Changeset in webkit [172207] by
-
- 1 edit2 moves1 add in trunk/LayoutTests
Move multicol tests into fast/regions/multicol.
https://bugs.webkit.org/show_bug.cgi?id=135693
Patch by Iulia Tamas <tamas@adobe.com> on 2014-08-07
Reviewed by Andrei Bucur.
File Move Patch. Created the fast/regions/multicol folder. Moved the region tests testing multicol
in the fast/regions/multicol folder.
- fast/regions/multicol/multicol-as-region-prevented-expected.html: Renamed from LayoutTests/fast/regions/multicol-as-region-prevented-expected.html.
- fast/regions/multicol/multicol-as-region-prevented.html: Renamed from LayoutTests/fast/regions/multicol-as-region-prevented.html.
- 3:20 AM Changeset in webkit [172206] by
-
- 2 edits in trunk/Tools
[GTK] Test /webkit2/WebKitUserContentManager/injected-script fails
https://bugs.webkit.org/show_bug.cgi?id=135696
Reviewed by Sergio Villar Senin.
Don't assume the JavaScript result is always a valid pointer. In case of JavaScript
exception (that happens when testing the script hasn't been injected) the JavaScript
result is NULL.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
(isScriptInjectedForURLAtPath):
- 1:14 AM Changeset in webkit [172205] by
-
- 4 edits in trunk
[GTK] Disable IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=135692
Reviewed by Carlos Garcia Campos.
.:
- Source/cmake/OptionsGTK.cmake:
Tools:
- Scripts/webkitperl/FeatureList.pm:
Aug 6, 2014:
- 11:23 PM Changeset in webkit [172204] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: breakpoint resolved state should not depend on all breakpoints being enabled
https://bugs.webkit.org/show_bug.cgi?id=135517
Reviewed by Joseph Pecoraro.
Previously, Breakpoint.resolved returned false if all breakpoints were disabled, even if
the breakpoint had an associated SourceCode. This was a weird hack to make it easier to
style breakpoint widgets. This made it hard for other code to deal with resolved
breakpoints that were also disabled, or SourceCodeLocations that resolve and unresolve.
This patch removes that consideration and fixes style update code to manually check if all
breakpoints are being suppressed.
The code now enforces that a Breakpoint must have a SourceCode before it can be resolved.
(As a performance optimization when loading the initial frame tree, we sometimes we give
Breakpoints a SourceCode before the debugger officially says that the breakpoint has been
resolved. Thus, it's possible to be unresolved with a SourceCode, but not vice-versa.)
This patch also adds a few guards where we assumed a SourceCodeLocation had a SourceCode.
- UserInterface/Controllers/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype.set breakpointsEnabled): Remove spurious
ResolvedStateDidChange events.
(WebInspector.DebuggerManager.prototype.breakpointResolved): Set the breakpoint's SourceCode
if it has not been set already by DebuggerManager.associateBreakpointsWithSourceCode.
- UserInterface/Models/Breakpoint.js:
(WebInspector.Breakpoint.prototype.get resolved):
(WebInspector.Breakpoint.prototype.set resolved.isSpecialBreakpoint):
(WebInspector.Breakpoint.prototype.set resolved): Add an assertion.
- UserInterface/Models/SourceCodeLocation.js: Add guards for SourceCode.
(WebInspector.SourceCodeLocation.prototype.populateLiveDisplayLocationTooltip):
- UserInterface/Views/BreakpointTreeElement.js: Account for DebuggerManager.breakpointsEnabled.
(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype._updateStatus):
- UserInterface/Views/ProbeSetDetailsSection.js:
(WebInspector.ProbeSetDetailsSection.prototype._updateLinkElement): Loosen the assertion.
- UserInterface/Views/SourceCodeTextEditor.js: Account for DebuggerManager.breakpointsEnabled.
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.close):
(WebInspector.SourceCodeTextEditor.prototype._breakpointStatusDidChange):
(WebInspector.SourceCodeTextEditor.prototype._breakpointsEnabledDidChange):
(WebInspector.SourceCodeTextEditor.prototype._updateBreakpointStatus):
- UserInterface/Views/TextEditor.js: Account for DebuggerManager.breakpointsEnabled.
- 11:14 PM Changeset in webkit [172203] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: ReplayManager should unpause and suppress breakpoints before capturing/replaying
https://bugs.webkit.org/show_bug.cgi?id=135608
Reviewed by Timothy Hatcher.
It is jarring when the debugger pauses during capturing or replaying. For now, we should suppress
all breakpoints during capturing or replaying, and restore breakpoint enabled state when
capturing finishes, when replaying finishes, or during temporary replay pauses.
In the future, the debugger will be selectively enabled during playback to seek to specific
breakpoint hits. This is tracked in https://bugs.webkit.org/show_bug.cgi?id=135663.
- UserInterface/Controllers/ReplayManager.js:
(WebInspector.ReplayManager.prototype.startCapturing.result):
(WebInspector.ReplayManager.prototype.replayToPosition.result):
(WebInspector.ReplayManager.prototype.replayToCompletion.result):
(WebInspector.ReplayManager.prototype.captureStopped):
(WebInspector.ReplayManager.prototype.playbackPaused):
(WebInspector.ReplayManager.prototype.playbackFinished):
(WebInspector.ReplayManager.prototype._changeSegmentState):
(WebInspector.ReplayManager.prototype._suppressBreakpointsAndResumeIfNeeded):
- 10:12 PM Changeset in webkit [172202] by
-
- 8 edits in trunk/Source
Source/WebCore:
[Win] Correct build errors when WebGL Disabled
https://bugs.webkit.org/show_bug.cgi?id=135687
Unreviewed build fix.
- WebCore.vcxproj/WebCore.vcxproj: Don't build Cairo files
when building CG.
- platform/graphics/GLContext.cpp: Correct use of 3D_GRAPHICS macro.
- platform/graphics/GraphicsContext3DPrivate.cpp: Ditto.
- platform/graphics/opengl/GLPlatformContext.cpp: Ditto.
- platform/graphics/opengl/GLPlatformSurface.cpp: Ditto.
Source/WebInspectorUI:
[Win] Build fix.
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: DebugSuffix target was missing
proper path settings for final output.
- 9:19 PM Changeset in webkit [172201] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix on non Cocoa port since r172172
- platform/text/TextEncodingRegistry.cpp:
(WebCore::defaultTextEncodingNameForSystemLanguage):
- platform/text/TextEncodingRegistry.h:
- 7:58 PM Changeset in webkit [172200] by
-
- 3 edits in trunk/Source/WebKit2
Services overlay flashes a lot; should have some hysteresis before showing overlay
https://bugs.webkit.org/show_bug.cgi?id=135683
<rdar://problem/16878039>
Reviewed by Simon Fraser.
Don't show the highlight until it's been 200ms since the last change
in selection or change in which highlight is hovered, whichever was more recent.
- WebProcess/WebPage/ServicesOverlayController.h:
- WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::selectionRectsDidChange):
Keep track of when the selection last changed.
(WebKit::ServicesOverlayController::drawTelephoneNumberHighlightIfVisible):
Make establishHoveredTelephoneHighlight take a bool instead of Boolean.
(WebKit::ServicesOverlayController::mouseIsOverHighlight):
Factor mouseIsOverHighlight out of establishHoveredTelephoneHighlight and drawHighlight.
(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
Return the amount of time until the highlight should be shown; this is
the maximum of (the difference between the last selection change and the timeout)
and (the difference between the last change in which highlight is hovered and the timeout).
Telephone number highlights are shown immediately, because they are already stable
by virtue of being expanded to include the entire telephone number.
(WebKit::ServicesOverlayController::repaintHighlightTimerFired):
(WebKit::ServicesOverlayController::drawHighlight):
If the highlight shouldn't be shown yet (because we haven't hit the two timeouts),
schedule a timer to repaint us around when we will hit the timeouts.
(WebKit::ServicesOverlayController::establishHoveredTelephoneHighlight):
(WebKit::ServicesOverlayController::mouseEvent):
Don't allow mouseUp to trigger the menu if we shouldn't be showing the overlay yet.
- 7:43 PM Changeset in webkit [172199] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] www.france24.com doesn't always load the page, sections stay white
https://bugs.webkit.org/show_bug.cgi?id=135684
<rdar://problem/17931712>
Reviewed by Tim Horton.
It's possible for a UIScrollView for overflow to move between one scrolling tree node
and another. When this happens, we need to avoid unconditionally clearing the delegate
on the node that's being destroyed, because the new node will already have set the
UIScrollView delegate to its own delegate.
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::~ScrollingTreeOverflowScrollingNodeIOS):
- 5:59 PM Changeset in webkit [172198] by
-
- 2 edits in trunk/LayoutTests
Gardening: adding failed tests to TestExpectations.
<https://webkit.org/b/135681>
Not reviewed.
- 5:58 PM Changeset in webkit [172197] by
-
- 3 edits1 add in trunk/Source/WebCore
[iOS] Make document marker assets not specific to particular scale factors
https://bugs.webkit.org/show_bug.cgi?id=135671
Reviewed by Simon Fraser.
No new tests.
- WebCore.xcodeproj/project.pbxproj:
- platform/ios/wak/WKGraphics.mm:
(imageResourcePath):
(WKGraphicsCreateImageFromBundleWithName):
- 5:48 PM Changeset in webkit [172196] by
-
- 4 edits in trunk/Source/JavaScriptCore
Gardening: fix for build failure on EFL bots.
Not reviewed.
- runtime/EnumerationMode.h:
(JSC::shouldIncludeJSObjectPropertyNames):
(JSC::modeThatSkipsJSObject):
- runtime/JSCell.cpp:
(JSC::JSCell::getEnumerableLength):
- runtime/JSCell.h:
- 5:45 PM Changeset in webkit [172195] by
-
- 2 edits in trunk/Source/WebCore
Services menu doesn't show up after you defocus/refocus the Safari window.
https://bugs.webkit.org/show_bug.cgi?id=135678
<rdar://problem/17929247>
Reviewed by Tim Horton.
In setSelection we create a SelectionRectGatherer::Notifier object that will notify
SelectionOverlayController about changes to the selection rects.
Upon creation, the list of selections rects is cleared, since it is populated by
the code that collects the selection rects. That code is never called
when setSelection won't change the selection, which the case when the window is
activated. The fix consists in postponing the SelectionRectGatherer::Notifier object
creation until we know for sure that the selection is indeed going to change.
- rendering/RenderView.cpp:
(WebCore::RenderView::setSelection):
- 5:40 PM Changeset in webkit [172194] by
-
- 17 edits in trunk
ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED is not used anywhere. Remove it.
https://bugs.webkit.org/show_bug.cgi?id=135675
Reviewed by Sam Weinig.
.:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 5:32 PM Changeset in webkit [172193] by
-
- 14 edits in trunk/Source
IDB transactions never reset if the Web Process ends before cleaning up
https://bugs.webkit.org/show_bug.cgi?id=135218
Source/WebCore:
Reviewed by David Kilzer.
No new tests (Covered by existing tests).
- Modules/indexeddb/IDBServerConnection.h: Add sync versions of reset/rollback.
- Modules/indexeddb/IDBTransactionBackend.cpp:
(WebCore::IDBTransactionBackend::abort): Call the sync versions.
Source/WebKit2:
Reviewed by Darin Adler and David Kilzer.
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::didReceiveMessage):
(WebKit::DatabaseToWebProcessConnection::didReceiveSyncMessage): Added.
(WebKit::DatabaseToWebProcessConnection::didClose):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::resetTransactionSync): Added
Wait until the reset is complete before sending the sync reply.
(WebKit::DatabaseProcessIDBConnection::rollbackTransactionSync): Added.
Ditto.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
Keep track of all in progress transactions and make sure they’re cleaned up
whenever a connection to a WebProcess is broken:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::unregisterConnection):
(WebKit::UniqueIDBDatabase::didCompleteTransactionOperation):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::didEstablishTransaction):
(WebKit::UniqueIDBDatabase::didResetTransaction):
(WebKit::UniqueIDBDatabase::resetAllTransactions):
(WebKit::UniqueIDBDatabase::finalizeRollback):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::rollbackTransaction):
Add sync versions of reset/rollback:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::resetTransactionSync):
(WebKit::WebIDBServerConnection::rollbackTransactionSync):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- 5:19 PM Changeset in webkit [172192] by
-
- 34 edits10 adds in trunk
Implement parsing for CSS scroll snap points
https://bugs.webkit.org/show_bug.cgi?id=134301
Source/JavaScriptCore:
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-06
Reviewed by Dean Jackson.
- Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
Source/WebCore:
Provided support for parsing -webkit-scroll-snap-* properties, i.e. type, points-x, points-y, destination, and coordinates.
The exact syntax of the scroll snap CSS properties follow the W3C spec at http://dev.w3.org/csswg/css-snappoints/
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-06
Reviewed by Dean Jackson.
Tests: css3/scroll-snap/scroll-snap-property-parsing.html,
css3/scroll-snap/scroll-snap-property-computed-style.html
- CMakeLists.txt: Added StyleScrollSnapPoints.h, StyleScrollSnapPoints.cpp
- Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
- WebCore.vcxproj/WebCore.vcxproj: Added StyleScrollSnapPoints.h, StyleScrollSnapPoints.cpp
- WebCore.vcxproj/WebCore.vcxproj.filters: Added StyleScrollSnapPoints.h, StyleScrollSnapPoints.cpp
- WebCore.xcodeproj/project.pbxproj: Added StyleScrollSnapPoints.h, StyleScrollSnapPoints.cpp, LengthRepeat.h
- css/CSSCalculationValue.cpp: Support for LengthRepeat
(WebCore::hasDoubleValue):
- css/CSSComputedStyleDeclaration.cpp: Support for showing computed style for snap point properties.
(WebCore::scrollSnapDestination):
(WebCore::scrollSnapPoints):
(WebCore::scrollSnapCoordinates):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp: Support for parsing snap point properties.
(WebCore::isValidKeywordPropertyAndValue): handle snap point type
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue): Added support for parsing snap points.
(WebCore::CSSParser::parseNonElementSnapPoints): Helper for parsing snap points-x/y.
(WebCore::CSSParser::parseScrollSnapDestination): Helper for parsing snap point destinations.
(WebCore::CSSParser::parseScrollSnapCoordinate): Helper for parsing snap point coordinates.
- css/CSSParser.h: Support for parsing snap point properties.
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
- css/CSSPrimitiveValue.cpp:
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getLengthRepeatValue):
(WebCore::CSSPrimitiveValue::formatNumberForcustomCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isLengthRepeat):
(WebCore::CSSPrimitiveValue::getLengthRepeatValue):
- css/CSSPrimitiveValueMappings.h: Added converters for snap point type properties.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ScrollSnapType):
- css/CSSPropertyNames.in: Added relevant snap point property names.
- css/CSSValueKeywords.in: Added "proximity", "mandatory" and "elements".
- css/LengthRepeat.h: Added to represent values of repeat(<length>)
(WebCore::LengthRepeat::create):
(WebCore::LengthRepeat::cloneForCSSOM):
(WebCore::LengthRepeat::interval):
(WebCore::LengthRepeat::setInterval):
(WebCore::LengthRepeat::equals):
(WebCore::LengthRepeat::cssText):
(WebCore::LengthRepeat::LengthRepeat):
- css/StyleResolver.cpp: Support for handling snap point properties
(WebCore::StyleResolver::applyProperty):Updated switch case to build snap-point-related style data
- rendering/style/RenderStyle.h: Added methods to access and modify snap point data
- rendering/style/RenderStyleConstants.h: Added scroll snap type flags.
- rendering/style/StyleAllInOne.cpp: Added StyleScrollSnapPoints.cpp
- rendering/style/StyleRareNonInheritedData.cpp: Added initiazing for m_scrollSnapPoints, updated equality check
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h: Added field for StyleScrollSnapPoints
- rendering/style/StyleScrollSnapPoints.cpp: Added. Wrapper for basic snap point data structures.
(WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints):
(WebCore::StyleScrollSnapPoints::copy):
(WebCore::StyleScrollSnapPoints::operator==):
- rendering/style/StyleScrollSnapPoints.h: Added.
(WebCore::StyleScrollSnapPoints::create):
(WebCore::StyleScrollSnapPoints::defaultRepeatOffset): Creates a new Length representing the default repeat value of repeat(100%)
(WebCore::StyleScrollSnapPoints::defaultDestinationOffset): Creates a new Length representing a default destination value (0px)
(WebCore::StyleScrollSnapPoints::operator!=):
Source/WebInspectorUI:
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-06
Reviewed by Dean Jackson.
- UserInterface/Models/CSSKeywordCompletions.js: Added snap point property keywords, such as mandatory, proximity, elements, and repeat.
Source/WebKit/mac:
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-06
Reviewed by Dean Jackson.
- Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
Source/WebKit2:
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-06
Reviewed by Dean Jackson.
- Configurations/FeatureDefines.xcconfig: Added ENABLE_CSS_SCROLL_SNAP
LayoutTests:
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-06
Reviewed by Dean Jackson.
Tests that parsing -webkit-scroll-snap-* properties behaves as expected.
- css3/scroll-snap/scroll-snap-property-computed-style-expected.txt: Expected text output of below test.
- css3/scroll-snap/scroll-snap-property-computed-style.html: Tests that scroll snap properties are correctly displayed via getComputedStyle.
- css3/scroll-snap/scroll-snap-property-computed-style.js: Script for above test.
(testComputedScrollSnapRule):
- css3/scroll-snap/scroll-snap-property-parsing-expected.txt: Expected text output of below test.
- css3/scroll-snap/scroll-snap-property-parsing.html: Tests that scroll snap properties are correctly parsed.
- css3/scroll-snap/scroll-snap-property-parsing.js: Script for above test.
(testScrollSnapRule):
- 5:16 PM Changeset in webkit [172191] by
-
- 5 edits in trunk/Source
[iOS] Subresources referenced in converted QuickLook documents sometimes fail to load
https://bugs.webkit.org/show_bug.cgi?id=135676
Reviewed by David Kilzer.
Source/WebCore:
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::setQuickLookHandle):
(WebCore::DocumentLoader::quickLookHandle):
Source/WebKit2:
QuickLookHandle needs to stay alive in order for its NSURLProtocol to service subresource loads originating
from the converted HTML document. Some of these loads happen dynamically after the main resource finishes
loading, so we cannot tie the lifetime of the QuickLookHandle to that of the main resource's ResourceLoader.
Instead, give ownership of the QuickLookHandle to DocumentLoader.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo): Stored the created QuickLookHandle in DocumentLoader.
(WebKit::WebResourceLoader::didReceiveData): Accessed DocumentLoader's QuickLookHandle.
(WebKit::WebResourceLoader::didFinishResourceLoad): Ditto.
(WebKit::WebResourceLoader::didFailResourceLoad): Ditto.
(WebKit::WebResourceLoader::didReceiveResource): Ditto.
- WebProcess/Network/WebResourceLoader.h: Removed m_quickLookHandle.
- 5:15 PM Changeset in webkit [172190] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: fix for build failure on GTK bots.
Not reviewed.
- runtime/FunctionHasExecutedCache.cpp:
- #include <limits.h> for UINT_MAX's definition.
- 5:09 PM Changeset in webkit [172189] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: fix for build failure on EFL bots.
Not reviewed.
- jit/JITInlines.h:
(JSC::JIT::emitLoadForArrayMode):
- 4:54 PM Changeset in webkit [172188] by
-
- 4 edits in trunk/Source/JavaScriptCore
Gardening: adding missing build file changes from the FTLOPT merge at r172176.
Not reviewed.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 4:49 PM Changeset in webkit [172187] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed build fix attempt since r172184
- CMakeLists.txt: Removed TypeLocation.cpp
- 4:33 PM Changeset in webkit [172186] by
-
- 2 edits in trunk
Unreviewed build fix: Make includes semicolon in assignment.
- Makefile.shared: Remove a ;
- 4:22 PM Changeset in webkit [172185] by
-
- 4 edits in trunk/Source/JavaScriptCore
Gardening: adding missing build file changes from r171510.
<https://webkit.org/b/134860>
Not reviewed.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 4:11 PM Changeset in webkit [172184] by
-
- 3 edits in trunk/Source/JavaScriptCore
Gardening: adding missing build file changes from r170490.
<https://webkit.org/b/133395>
Not reviewed.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- 4:05 PM Changeset in webkit [172183] by
-
- 3 edits2 adds in trunk
REGRESSION (r168119): Album flipping animation doesn’t work
https://bugs.webkit.org/show_bug.cgi?id=132801
Source/WebCore:
<rdar://problem/16878497>, <rdar://problem/17908085>
Reviewed by Dean Jackson.
In r168119 I avoided creating backing store for backface-visibility:hidden unless
some ancestor was 3d-transformed. However, when starting transitions or animations
that apply transforms, we don't do a layout, and therefore don't update the RenderLayer
flags that mark an ancestor as having a transform. This broke various content which
used backface-visibility:hidden for "flip" animations.
Make a low-risk fix that looks for the pattern of CSS properties used for flipping,
making a compositing layer for backface-visibility:hidden if the stacking context element
has transform-style: preserve-3d.
Test: compositing/backing/backface-visibility-flip.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForBackfaceVisibility):
LayoutTests:
Reviewed by Dean Jackson.
Test that starts a transform animation and dumps layers.
- compositing/backing/backface-visibility-flip-expected.txt: Added.
- compositing/backing/backface-visibility-flip.html: Added.
- 4:04 PM Changeset in webkit [172182] by
-
- 6 edits in trunk/Source/WebCore
Consolidate logic for calculating scrollbar page step size
https://bugs.webkit.org/show_bug.cgi?id=135670
Reviewed by Simon Fraser.
Consolidate the calculation of the scroll step size into a single place.
Improve the handling of sub-pixel layout behavior by performing proper
rounding on the fractional scroll ranges.
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance): Switch to Scrollbar::pageStep method.
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent): Ditto.
- platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars): Ditto.
- platform/Scrollbar.h:
(WebCore::Scrollbar::pageStep): Added.
(WebCore::Scrollbar::pageStepDelta): Added.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout): Switch to Scrollbar method.
- 3:52 PM Changeset in webkit [172181] by
-
- 2 edits in trunk/Source/JavaScriptCore
Silence a debug assertion.
Reviewed by Mark Hahnenberg.
- runtime/JSPropertyNameEnumerator.h:
(JSC::JSPropertyNameEnumerator::cachedStructure):
- 2:53 PM Changeset in webkit [172180] by
-
- 14 edits in trunk/Source/WebCore
Web Replay: dispatch timing information should be stored out-of-line in a replay segment
https://bugs.webkit.org/show_bug.cgi?id=135295
Reviewed by Timothy Hatcher.
We need to save a timestamp for each event loop input so that replay can
simulate the original user and network delays. Currently that timestamp
is stored on each EventLoopInput instance.
This patch stores timestamp data in a separate vector attached to the segment.
The event loop input class is now immutable, and new auxiliary data can be added
without adding members to the EventLoopInput class.
As part of the refactoring, InputCursors now keep a reference to the relevant
session segment instead of a reference to their input storage. InputCursors can
be created directly, instead of through ReplaySessionSegment.
No new tests. No behavior was changed.
- inspector/InspectorReplayAgent.cpp:
(WebCore::buildInspectorObjectForInput): Don't send the timestamp with the input.
(WebCore::buildInspectorObjectForSegment):
- inspector/protocol/Replay.json: Remove optional timestamp field for ReplayInput.
- replay/CapturingInputCursor.cpp:
(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::create):
(WebCore::CapturingInputCursor::storeInput): Save event loop input timings here.
- replay/CapturingInputCursor.h:
- replay/EventLoopInput.h:
(WebCore::EventLoopInputBase::EventLoopInputBase): Deleted.
(WebCore::EventLoopInputBase::timestamp): Deleted.
(WebCore::EventLoopInputBase::setTimestamp): Deleted.
- replay/EventLoopInputDispatcher.cpp: Use a struct for dispatch information.
(WebCore::EventLoopInputDispatcher::EventLoopInputDispatcher):
(WebCore::EventLoopInputDispatcher::dispatchInputSoon):
(WebCore::EventLoopInputDispatcher::dispatchInput):
- replay/EventLoopInputDispatcher.h:
- replay/FunctorInputCursor.h:
(WebCore::FunctorInputCursor::forEachInputInQueue):
(WebCore::FunctorInputCursor::FunctorInputCursor):
- replay/ReplayController.cpp:
(WebCore::ReplayController::createSegment):
(WebCore::ReplayController::loadSegmentAtIndex):
(WebCore::ReplayController::unloadSegment): Deleted.
(WebCore::ReplayController::startPlayback): Deleted.
- replay/ReplaySessionSegment.cpp:
(WebCore::ReplaySessionSegment::createCapturingCursor): Deleted.
(WebCore::ReplaySessionSegment::createReplayingCursor): Deleted.
(WebCore::ReplaySessionSegment::createFunctorCursor): Deleted.
- replay/ReplaySessionSegment.h:
(WebCore::ReplaySessionSegment::storage):
(WebCore::ReplaySessionSegment::eventLoopTimings):
- replay/ReplayingInputCursor.cpp:
(WebCore::ReplayingInputCursor::ReplayingInputCursor):
(WebCore::ReplayingInputCursor::create):
(WebCore::ReplayingInputCursor::uncheckedLoadInput):
(WebCore::ReplayingInputCursor::loadEventLoopInput): Added. This method collates
and returns the next event loop input with its associated dispatch information.
- replay/ReplayingInputCursor.h:
- 2:51 PM Changeset in webkit [172179] by
-
- 2 edits in trunk/Source/WebCore
Document-relative overlays disappear after doing page-cache navigations
https://bugs.webkit.org/show_bug.cgi?id=135669
<rdar://problem/17929171>
Reviewed by Simon Fraser.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):
When navigating from one page to another, the document-relative overlay
layer is moved from the layer tree of the RenderLayerCompositor of the
first RenderView to the layer tree of the RenderLayerCompositor of the
new RenderView, upon layer tree construction.
When going "back" via a page cache navigation, we don't rebuild the
layer tree, and just assume that it is in a valid state.
However, the document-relative overlay layer was *moved*, and as such,
needs to be moved back. To do this, reattach the document-relative
overlay layer whenever the root layer attachment of a RenderLayerCompositor
changes, which will happen in the right order when going back to a cached page.
- 2:48 PM Changeset in webkit [172178] by
-
- 1 copy in tags/Safari-600.1.4.7
New Tag.
- 2:43 PM Changeset in webkit [172177] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix 32-bit build.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileHasIndexedProperty):
- 2:32 PM Changeset in webkit [172176] by
-
- 130 edits18 adds2 deletes in trunk/Source
Merge r171389, r171495, r171508, r171510, r171605, r171606, r171611, r171614, r171763 from ftlopt.
Source/JavaScriptCore:
2014-07-28 Mark Hahnenberg <mhahnenberg@apple.com>
Support for-in in the FTL
https://bugs.webkit.org/show_bug.cgi?id=134140
Reviewed by Filip Pizlo.
- dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::handleNode):
- ftl/FTLAbstractHeapRepository.cpp:
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::compileNode): (JSC::FTL::LowerDFGToLLVM::compileHasIndexedProperty): (JSC::FTL::LowerDFGToLLVM::compileHasGenericProperty): (JSC::FTL::LowerDFGToLLVM::compileHasStructureProperty): (JSC::FTL::LowerDFGToLLVM::compileGetDirectPname): (JSC::FTL::LowerDFGToLLVM::compileGetEnumerableLength): (JSC::FTL::LowerDFGToLLVM::compileGetStructurePropertyEnumerator): (JSC::FTL::LowerDFGToLLVM::compileGetGenericPropertyEnumerator): (JSC::FTL::LowerDFGToLLVM::compileGetEnumeratorPname): (JSC::FTL::LowerDFGToLLVM::compileToIndexString):
2014-07-25 Mark Hahnenberg <mhahnenberg@apple.com>
Remove JSPropertyNameIterator
https://bugs.webkit.org/show_bug.cgi?id=135066
Reviewed by Geoffrey Garen.
It has been replaced by JSPropertyNameEnumerator.
- JavaScriptCore.order:
- bytecode/BytecodeBasicBlock.cpp: (JSC::isBranch):
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h: (JSC::computeUsesForBytecodeOffset): (JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode):
- bytecode/PreciseJumpTargets.cpp: (JSC::getJumpTargetsForBytecodeOffset):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetPropertyNames): Deleted. (JSC::BytecodeGenerator::emitNextPropertyName): Deleted.
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp:
- interpreter/Register.h:
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_pnames): Deleted. (JSC::JIT::emit_op_next_pname): Deleted.
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_pnames): Deleted. (JSC::JIT::emit_op_next_pname): Deleted.
- jit/JITOperations.cpp:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_pname): Deleted. (JSC::JIT::emitSlow_op_get_by_pname): Deleted.
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_by_pname): Deleted. (JSC::JIT::emitSlow_op_get_by_pname): Deleted.
- llint/LLIntOffsetsExtractor.cpp:
- llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
- runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): Deleted. (JSC::JSPropertyNameIterator::create): Deleted. (JSC::JSPropertyNameIterator::destroy): Deleted. (JSC::JSPropertyNameIterator::get): Deleted. (JSC::JSPropertyNameIterator::visitChildren): Deleted.
- runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): Deleted. (JSC::JSPropertyNameIterator::size): Deleted. (JSC::JSPropertyNameIterator::setCachedStructure): Deleted. (JSC::JSPropertyNameIterator::cachedStructure): Deleted. (JSC::JSPropertyNameIterator::setCachedPrototypeChain): Deleted. (JSC::JSPropertyNameIterator::cachedPrototypeChain): Deleted. (JSC::JSPropertyNameIterator::finishCreation): Deleted. (JSC::Register::propertyNameIterator): Deleted. (JSC::StructureRareData::enumerationCache): Deleted. (JSC::StructureRareData::setEnumerationCache): Deleted.
- runtime/Structure.cpp: (JSC::Structure::addPropertyWithoutTransition): (JSC::Structure::removePropertyWithoutTransition):
- runtime/Structure.h:
- runtime/StructureInlines.h: (JSC::Structure::setEnumerationCache): Deleted. (JSC::Structure::enumerationCache): Deleted.
- runtime/StructureRareData.cpp: (JSC::StructureRareData::visitChildren):
- runtime/StructureRareData.h:
- runtime/VM.cpp: (JSC::VM::VM):
2014-07-25 Saam Barati <sbarati@apple.com>
Fix 32-bit build breakage for type profiling
https://bugs.webkit.org/process_bug.cgi
Reviewed by Mark Hahnenberg.
32-bit builds currently break because global variable IDs for high
fidelity type profiling are int64_t. Change this to intptr_t so that
it's 32 bits on 32-bit platforms and 64 bits on 64-bit platforms.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::scopeDependentProfile):
- bytecode/TypeLocation.h:
- runtime/SymbolTable.cpp: (JSC::SymbolTable::uniqueIDForVariable): (JSC::SymbolTable::uniqueIDForRegister):
- runtime/SymbolTable.h:
- runtime/TypeLocationCache.cpp: (JSC::TypeLocationCache::getTypeLocation):
- runtime/TypeLocationCache.h:
- runtime/VM.h: (JSC::VM::getNextUniqueVariableID):
2014-07-25 Mark Hahnenberg <mhahnenberg@apple.com>
Reindent PropertyNameArray.h
https://bugs.webkit.org/show_bug.cgi?id=135067
Reviewed by Geoffrey Garen.
- runtime/PropertyNameArray.h: (JSC::RefCountedIdentifierSet::contains): (JSC::RefCountedIdentifierSet::size): (JSC::RefCountedIdentifierSet::add): (JSC::PropertyNameArrayData::create): (JSC::PropertyNameArrayData::propertyNameVector): (JSC::PropertyNameArrayData::PropertyNameArrayData): (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::vm): (JSC::PropertyNameArray::add): (JSC::PropertyNameArray::addKnownUnique): (JSC::PropertyNameArray::operator[]): (JSC::PropertyNameArray::setData): (JSC::PropertyNameArray::data): (JSC::PropertyNameArray::releaseData): (JSC::PropertyNameArray::identifierSet): (JSC::PropertyNameArray::canAddKnownUniqueForStructure): (JSC::PropertyNameArray::size): (JSC::PropertyNameArray::begin): (JSC::PropertyNameArray::end): (JSC::PropertyNameArray::numCacheableSlots): (JSC::PropertyNameArray::setNumCacheableSlotsForObject): (JSC::PropertyNameArray::setBaseObject): (JSC::PropertyNameArray::setPreviouslyEnumeratedLength):
2014-07-23 Mark Hahnenberg <mhahnenberg@apple.com>
Refactor our current implementation of for-in
https://bugs.webkit.org/show_bug.cgi?id=134142
Reviewed by Filip Pizlo.
This patch splits for-in loops into three distinct parts:
- Iterating over the indexed properties in the base object.
- Iterating over the Structure properties in the base object.
- Iterating over any other enumerable properties for that object and any objects in the prototype chain.
It does this by emitting these explicit loops in bytecode, using a new set of bytecodes to
support the various operations required for each loop.
- API/JSCallbackObjectFunctions.h: (JSC::JSCallbackObject<Parent>::getOwnNonIndexPropertyNames):
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h: (JSC::computeUsesForBytecodeOffset): (JSC::computeDefsForBytecodeOffset):
- bytecode/CallLinkStatus.h: (JSC::CallLinkStatus::CallLinkStatus):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): (JSC::CodeBlock::CodeBlock):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitGetByVal): (JSC::BytecodeGenerator::emitComplexPopScopes): (JSC::BytecodeGenerator::emitGetEnumerableLength): (JSC::BytecodeGenerator::emitHasGenericProperty): (JSC::BytecodeGenerator::emitHasIndexedProperty): (JSC::BytecodeGenerator::emitHasStructureProperty): (JSC::BytecodeGenerator::emitGetStructurePropertyEnumerator): (JSC::BytecodeGenerator::emitGetGenericPropertyEnumerator): (JSC::BytecodeGenerator::emitNextEnumeratorPropertyName): (JSC::BytecodeGenerator::emitToIndexString): (JSC::BytecodeGenerator::pushIndexedForInScope): (JSC::BytecodeGenerator::popIndexedForInScope): (JSC::BytecodeGenerator::pushStructureForInScope): (JSC::BytecodeGenerator::popStructureForInScope): (JSC::BytecodeGenerator::invalidateForInContextForLocal):
- bytecompiler/BytecodeGenerator.h: (JSC::ForInContext::ForInContext): (JSC::ForInContext::~ForInContext): (JSC::ForInContext::isValid): (JSC::ForInContext::invalidate): (JSC::ForInContext::local): (JSC::StructureForInContext::StructureForInContext): (JSC::StructureForInContext::type): (JSC::StructureForInContext::index): (JSC::StructureForInContext::property): (JSC::StructureForInContext::enumerator): (JSC::IndexedForInContext::IndexedForInContext): (JSC::IndexedForInContext::type): (JSC::IndexedForInContext::index): (JSC::BytecodeGenerator::pushOptimisedForIn): Deleted. (JSC::BytecodeGenerator::popOptimisedForIn): Deleted.
- bytecompiler/NodesCodegen.cpp: (JSC::ReadModifyResolveNode::emitBytecode): (JSC::AssignResolveNode::emitBytecode): (JSC::ForInNode::tryGetBoundLocal): (JSC::ForInNode::emitLoopHeader): (JSC::ForInNode::emitMultiLoopBytecode): (JSC::ForInNode::emitBytecode):
- debugger/DebuggerScope.h:
- dfg/DFGAbstractHeap.h:
- dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp: (JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h: (JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp: (JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGHeapLocation.cpp: (WTF::printInternal):
- dfg/DFGHeapLocation.h:
- dfg/DFGNode.h: (JSC::DFG::Node::hasHeapPrediction): (JSC::DFG::Node::hasArrayMode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h: (JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile):
- jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): (JSC::JIT::privateCompileSlowCases):
- jit/JIT.h: (JSC::JIT::compileHasIndexedProperty): (JSC::JIT::emitInt32Load):
- jit/JITInlines.h: (JSC::JIT::emitDoubleGetByVal): (JSC::JIT::emitLoadForArrayMode): (JSC::JIT::emitContiguousGetByVal): (JSC::JIT::emitArrayStorageGetByVal):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_enumerable_length): (JSC::JIT::emit_op_has_structure_property): (JSC::JIT::emitSlow_op_has_structure_property): (JSC::JIT::emit_op_has_generic_property): (JSC::JIT::privateCompileHasIndexedProperty): (JSC::JIT::emit_op_has_indexed_property): (JSC::JIT::emitSlow_op_has_indexed_property): (JSC::JIT::emit_op_get_direct_pname): (JSC::JIT::emitSlow_op_get_direct_pname): (JSC::JIT::emit_op_get_structure_property_enumerator): (JSC::JIT::emit_op_get_generic_property_enumerator): (JSC::JIT::emit_op_next_enumerator_pname): (JSC::JIT::emit_op_to_index_string):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_enumerable_length): (JSC::JIT::emit_op_has_structure_property): (JSC::JIT::emitSlow_op_has_structure_property): (JSC::JIT::emit_op_has_generic_property): (JSC::JIT::privateCompileHasIndexedProperty): (JSC::JIT::emit_op_has_indexed_property): (JSC::JIT::emitSlow_op_has_indexed_property): (JSC::JIT::emit_op_get_direct_pname): (JSC::JIT::emitSlow_op_get_direct_pname): (JSC::JIT::emit_op_get_structure_property_enumerator): (JSC::JIT::emit_op_get_generic_property_enumerator): (JSC::JIT::emit_op_next_enumerator_pname): (JSC::JIT::emit_op_to_index_string):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::emitDoubleLoad): (JSC::JIT::emitContiguousLoad): (JSC::JIT::emitArrayStorageLoad): (JSC::JIT::emitDoubleGetByVal): Deleted. (JSC::JIT::emitContiguousGetByVal): Deleted. (JSC::JIT::emitArrayStorageGetByVal): Deleted.
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emitContiguousLoad): (JSC::JIT::emitDoubleLoad): (JSC::JIT::emitArrayStorageLoad): (JSC::JIT::emitContiguousGetByVal): Deleted. (JSC::JIT::emitDoubleGetByVal): Deleted. (JSC::JIT::emitArrayStorageGetByVal): Deleted.
- llint/LowLevelInterpreter.asm:
- parser/Nodes.h:
- runtime/Arguments.cpp: (JSC::Arguments::getOwnPropertyNames):
- runtime/ClassInfo.h:
- runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
- runtime/EnumerationMode.h: Added. (JSC::shouldIncludeDontEnumProperties): (JSC::shouldExcludeDontEnumProperties): (JSC::shouldIncludeJSObjectPropertyNames): (JSC::modeThatSkipsJSObject):
- runtime/JSActivation.cpp: (JSC::JSActivation::getOwnNonIndexPropertyNames):
- runtime/JSArray.cpp: (JSC::JSArray::getOwnNonIndexPropertyNames):
- runtime/JSArrayBuffer.cpp: (JSC::JSArrayBuffer::getOwnNonIndexPropertyNames):
- runtime/JSArrayBufferView.cpp: (JSC::JSArrayBufferView::getOwnNonIndexPropertyNames):
- runtime/JSCell.cpp: (JSC::JSCell::getEnumerableLength): (JSC::JSCell::getStructurePropertyNames): (JSC::JSCell::getGenericPropertyNames):
- runtime/JSCell.h:
- runtime/JSFunction.cpp: (JSC::JSFunction::getOwnNonIndexPropertyNames):
- runtime/JSGenericTypedArrayViewInlines.h: (JSC::JSGenericTypedArrayView<Adaptor>::getOwnNonIndexPropertyNames):
- runtime/JSObject.cpp: (JSC::getClassPropertyNames): (JSC::JSObject::hasOwnProperty): (JSC::JSObject::getOwnPropertyNames): (JSC::JSObject::getOwnNonIndexPropertyNames): (JSC::JSObject::getEnumerableLength): (JSC::JSObject::getStructurePropertyNames): (JSC::JSObject::getGenericPropertyNames):
- runtime/JSObject.h:
- runtime/JSPropertyNameEnumerator.cpp: Added. (JSC::JSPropertyNameEnumerator::create): (JSC::JSPropertyNameEnumerator::JSPropertyNameEnumerator): (JSC::JSPropertyNameEnumerator::finishCreation): (JSC::JSPropertyNameEnumerator::destroy): (JSC::JSPropertyNameEnumerator::visitChildren):
- runtime/JSPropertyNameEnumerator.h: Added. (JSC::JSPropertyNameEnumerator::createStructure): (JSC::JSPropertyNameEnumerator::propertyNameAtIndex): (JSC::JSPropertyNameEnumerator::identifierSet): (JSC::JSPropertyNameEnumerator::cachedPrototypeChain): (JSC::JSPropertyNameEnumerator::setCachedPrototypeChain): (JSC::JSPropertyNameEnumerator::cachedStructure): (JSC::JSPropertyNameEnumerator::cachedStructureID): (JSC::JSPropertyNameEnumerator::cachedInlineCapacity): (JSC::JSPropertyNameEnumerator::cachedStructureIDOffset): (JSC::JSPropertyNameEnumerator::cachedInlineCapacityOffset): (JSC::JSPropertyNameEnumerator::cachedPropertyNamesLengthOffset): (JSC::JSPropertyNameEnumerator::cachedPropertyNamesVectorOffset): (JSC::structurePropertyNameEnumerator): (JSC::genericPropertyNameEnumerator):
- runtime/JSProxy.cpp: (JSC::JSProxy::getEnumerableLength): (JSC::JSProxy::getStructurePropertyNames): (JSC::JSProxy::getGenericPropertyNames):
- runtime/JSProxy.h:
- runtime/JSSymbolTableObject.cpp: (JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
- runtime/PropertyNameArray.cpp: (JSC::PropertyNameArray::add): (JSC::PropertyNameArray::setPreviouslyEnumeratedProperties):
- runtime/PropertyNameArray.h: (JSC::RefCountedIdentifierSet::contains): (JSC::RefCountedIdentifierSet::size): (JSC::RefCountedIdentifierSet::add): (JSC::PropertyNameArray::PropertyNameArray): (JSC::PropertyNameArray::add): (JSC::PropertyNameArray::addKnownUnique): (JSC::PropertyNameArray::identifierSet): (JSC::PropertyNameArray::canAddKnownUniqueForStructure): (JSC::PropertyNameArray::setPreviouslyEnumeratedLength):
- runtime/RegExpObject.cpp: (JSC::RegExpObject::getOwnNonIndexPropertyNames): (JSC::RegExpObject::getPropertyNames): (JSC::RegExpObject::getGenericPropertyNames):
- runtime/RegExpObject.h:
- runtime/StringObject.cpp: (JSC::StringObject::getOwnPropertyNames):
- runtime/Structure.cpp: (JSC::Structure::getPropertyNamesFromStructure): (JSC::Structure::setCachedStructurePropertyNameEnumerator): (JSC::Structure::cachedStructurePropertyNameEnumerator): (JSC::Structure::setCachedGenericPropertyNameEnumerator): (JSC::Structure::cachedGenericPropertyNameEnumerator): (JSC::Structure::canCacheStructurePropertyNameEnumerator): (JSC::Structure::canCacheGenericPropertyNameEnumerator): (JSC::Structure::canAccessPropertiesQuickly):
- runtime/Structure.h:
- runtime/StructureRareData.cpp: (JSC::StructureRareData::visitChildren): (JSC::StructureRareData::cachedStructurePropertyNameEnumerator): (JSC::StructureRareData::setCachedStructurePropertyNameEnumerator): (JSC::StructureRareData::cachedGenericPropertyNameEnumerator): (JSC::StructureRareData::setCachedGenericPropertyNameEnumerator):
- runtime/StructureRareData.h:
- runtime/VM.cpp: (JSC::VM::VM):
- runtime/VM.h:
2014-07-23 Saam Barati <sbarati@apple.com>
Make improvements to Type Profiling
https://bugs.webkit.org/show_bug.cgi?id=134860
Reviewed by Filip Pizlo.
I improved the API between the inspector and JSC. We no longer send one huge
string to the inspector. We now send structured data that represents the type
information that JSC has collected. I've also created a beginning implementation
of a type lattice that allows us to resolve a display name for a type that
consists of a single word.
I created a data structure that knows which functions have executed. This
solves the bug where types inside an un-executed function will resolve
to the type of the enclosing expression of that function. This data
structure may also be useful later if the inspector chooses to create a UI
around showing which functions have executed.
Better type information is gathered for objects. StructureShape now
represents an object's prototype chain. StructureShape also collects
the constructor name for an object.
Expression ranges are now zero indexed.
Removed some extraneous methods.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::scopeDependentProfile):
- bytecode/CodeBlock.h:
- bytecode/TypeLocation.h: (JSC::TypeLocation::TypeLocation):
- bytecode/UnlinkedCodeBlock.cpp: (JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedCodeBlock.h: (JSC::UnlinkedFunctionExecutable::highFidelityTypeProfilingStartOffset): (JSC::UnlinkedFunctionExecutable::highFidelityTypeProfilingEndOffset):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitHighFidelityTypeProfilingExpressionInfo):
- bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitHighFidelityTypeProfilingExpressionInfo): Deleted.
- heap/Heap.cpp: (JSC::Heap::collect):
- inspector/agents/InspectorRuntimeAgent.cpp: (Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets): (Inspector::InspectorRuntimeAgent::getRuntimeTypeForVariableAtOffset): Deleted.
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/protocol/Runtime.json:
- runtime/Executable.cpp: (JSC::ScriptExecutable::ScriptExecutable): (JSC::ProgramExecutable::ProgramExecutable): (JSC::FunctionExecutable::FunctionExecutable): (JSC::ProgramExecutable::initializeGlobalProperties):
- runtime/Executable.h: (JSC::ScriptExecutable::highFidelityTypeProfilingStartOffset): (JSC::ScriptExecutable::highFidelityTypeProfilingEndOffset):
- runtime/FunctionHasExecutedCache.cpp: Added. (JSC::FunctionHasExecutedCache::hasExecutedAtOffset): (JSC::FunctionHasExecutedCache::insertUnexecutedRange): (JSC::FunctionHasExecutedCache::removeUnexecutedRange):
- runtime/FunctionHasExecutedCache.h: Added. (JSC::FunctionHasExecutedCache::FunctionRange::FunctionRange): (JSC::FunctionHasExecutedCache::FunctionRange::operator==): (JSC::FunctionHasExecutedCache::FunctionRange::hash):
- runtime/HighFidelityLog.cpp: (JSC::HighFidelityLog::processHighFidelityLog): (JSC::HighFidelityLog::actuallyProcessLogThreadFunction): Deleted.
- runtime/HighFidelityLog.h: (JSC::HighFidelityLog::recordTypeInformationForLocation):
- runtime/HighFidelityTypeProfiler.cpp: (JSC::HighFidelityTypeProfiler::logTypesForTypeLocation): (JSC::HighFidelityTypeProfiler::insertNewLocation): (JSC::HighFidelityTypeProfiler::getTypesForVariableAtOffsetForInspector): (JSC::descriptorMatchesTypeLocation): (JSC::HighFidelityTypeProfiler::findLocation): (JSC::HighFidelityTypeProfiler::getTypesForVariableInAtOffset): Deleted. (JSC::HighFidelityTypeProfiler::getGlobalTypesForVariableAtOffset): Deleted. (JSC::HighFidelityTypeProfiler::getLocalTypesForVariableAtOffset): Deleted.
- runtime/HighFidelityTypeProfiler.h: (JSC::QueryKey::QueryKey): (JSC::QueryKey::isHashTableDeletedValue): (JSC::QueryKey::operator==): (JSC::QueryKey::hash): (JSC::QueryKeyHash::hash): (JSC::QueryKeyHash::equal): (JSC::HighFidelityTypeProfiler::functionHasExecutedCache): (JSC::HighFidelityTypeProfiler::typeLocationCache):
- runtime/Structure.cpp: (JSC::Structure::toStructureShape):
- runtime/Structure.h:
- runtime/TypeLocationCache.cpp: Added. (JSC::TypeLocationCache::getTypeLocation):
- runtime/TypeLocationCache.h: Added. (JSC::TypeLocationCache::LocationKey::LocationKey): (JSC::TypeLocationCache::LocationKey::operator==): (JSC::TypeLocationCache::LocationKey::hash):
- runtime/TypeSet.cpp: (JSC::TypeSet::getRuntimeTypeForValue): (JSC::TypeSet::addTypeForValue): (JSC::TypeSet::seenTypes): (JSC::TypeSet::doesTypeConformTo): (JSC::TypeSet::displayName): (JSC::TypeSet::allPrimitiveTypeNames): (JSC::TypeSet::allStructureRepresentations): (JSC::TypeSet::leastCommonAncestor): (JSC::StructureShape::StructureShape): (JSC::StructureShape::addProperty): (JSC::StructureShape::propertyHash): (JSC::StructureShape::leastCommonAncestor): (JSC::StructureShape::stringRepresentation): (JSC::StructureShape::inspectorRepresentation): (JSC::StructureShape::leastUpperBound): Deleted.
- runtime/TypeSet.h: (JSC::StructureShape::setConstructorName): (JSC::StructureShape::constructorName): (JSC::StructureShape::setProto):
- runtime/VM.cpp: (JSC::VM::dumpHighFidelityProfilingTypes): (JSC::VM::getTypesForVariableAtOffset): Deleted. (JSC::VM::updateHighFidelityTypeProfileState): Deleted.
- runtime/VM.h: (JSC::VM::isProfilingTypesWithHighFidelity): (JSC::VM::highFidelityTypeProfiler):
2014-07-23 Filip Pizlo <fpizlo@apple.com>
Fix debug build.
- bytecode/CallLinkStatus.h: (JSC::CallLinkStatus::CallLinkStatus):
2014-07-20 Filip Pizlo <fpizlo@apple.com>
[ftlopt] Phantoms in SSA form should be aggressively hoisted
https://bugs.webkit.org/show_bug.cgi?id=135111
Reviewed by Oliver Hunt.
In CPS form, Phantom means three things: (1) that the children should be kept alive so long
as they are relevant to OSR (due to a MovHint), (2) that the children are live-in-bytecode
at the point of the Phantom, and (3) that some checks should be performed. In SSA, the
second meaning is not used but the other two stay.
The fact that a Phantom that is used to keep a node alive could be anywhere in the graph,
even in a totally different basic block, complicates some SSA transformations. It's not
possible to just jettison some successor, since tha successor could have a Phantom that we
care about.
This change rationalizes how Phantoms work so that:
1) Phantoms keep children alive so long as those children are relevant to OSR. This is true
in both CPS and SSA. This was true before and it's true now.
2) Phantoms are used for live-in-bytecode only in CPS. This was true before and it's true
now, except that now we also don't bother preserving the live-in-bytecode information
that Phantoms convey, when we are in SSA.
3) Phantoms may incidentally have checks, but in cases where we only want checks, we now
use Check instead of Phantom. Notably, DCE phase has dead nodes decay to Check, not
Phantom.
The biggest part of this change is that in SSA, we canonicalize Phantoms:
- All Phantoms are replaced with Check nodes that include only those edges that have checks.
- Nodes that were the children of any Phantoms have a Phantom right after them.
For example, the following code:
5: ArithAdd(@1, @2)
6: ArithSub(@5, @3)
7: Phantom(Int32:@5)
would be turned into the following:
5: ArithAdd(@1, @2)
8: Phantom(@5) @5 was the child of a Phantom, so we create a new Phantom right after
@5. This is the only Phantom we will have for @5.
6: ArithSub(@5, @3)
7: Check(Int32:@5) We replace the Phantom with a Check; in this case since Int32: is
a checking edge, we leave it.
This is a slight speed-up across the board, presumably because we now do a better job of
reducing the size of the graph during compilation. It could also be a fluke, though. The
main purpose of this is to unlock some other work (like CFG simplification in SSA). It will
become a requirement to run phantom canonicalization prior to some SSA phases. None of the
current phases need it, but future phases probably will.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDCEPhase.cpp: (JSC::DFG::DCEPhase::run): (JSC::DFG::DCEPhase::findTypeCheckRoot): (JSC::DFG::DCEPhase::countEdge): (JSC::DFG::DCEPhase::fixupBlock): (JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):
- dfg/DFGEdge.cpp: (JSC::DFG::Edge::dump):
- dfg/DFGEdge.h: (JSC::DFG::Edge::isProved): (JSC::DFG::Edge::needsCheck): Deleted.
- dfg/DFGNodeFlags.h:
- dfg/DFGPhantomCanonicalizationPhase.cpp: Added. (JSC::DFG::PhantomCanonicalizationPhase::PhantomCanonicalizationPhase): (JSC::DFG::PhantomCanonicalizationPhase::run): (JSC::DFG::performPhantomCanonicalization):
- dfg/DFGPhantomCanonicalizationPhase.h: Added.
- dfg/DFGPhantomRemovalPhase.cpp: (JSC::DFG::PhantomRemovalPhase::run):
- dfg/DFGPhantomRemovalPhase.h:
- dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl):
- ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::lowJSValue): (JSC::FTL::LowerDFGToLLVM::speculateObjectOrOther):
2014-07-22 Filip Pizlo <fpizlo@apple.com>
[ftlopt] Get rid of structure checks as a way of checking if a function is in fact a function
https://bugs.webkit.org/show_bug.cgi?id=135146
Reviewed by Oliver Hunt.
This greatly simplifies our closure call optimizations by taking advantage of the type
bits available in the cell header.
- bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::visitWeak):
- bytecode/CallLinkStatus.cpp: (JSC::CallLinkStatus::CallLinkStatus): (JSC::CallLinkStatus::computeFor): (JSC::CallLinkStatus::dump):
- bytecode/CallLinkStatus.h: (JSC::CallLinkStatus::CallLinkStatus): (JSC::CallLinkStatus::executable): (JSC::CallLinkStatus::structure): Deleted.
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::emitFunctionChecks):
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::observeUseKindOnNode):
- dfg/DFGSafeToExecute.h: (JSC::DFG::SafeToExecuteEdge::operator()):
- dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::checkArray): (JSC::DFG::SpeculativeJIT::speculateCellTypeWithoutTypeFiltering): (JSC::DFG::SpeculativeJIT::speculateCellType): (JSC::DFG::SpeculativeJIT::speculateFunction): (JSC::DFG::SpeculativeJIT::speculateFinalObject): (JSC::DFG::SpeculativeJIT::speculate):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGUseKind.cpp: (WTF::printInternal):
- dfg/DFGUseKind.h: (JSC::DFG::typeFilterFor): (JSC::DFG::isCell):
- ftl/FTLCapabilities.cpp: (JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp: (JSC::FTL::LowerDFGToLLVM::compileCheckExecutable): (JSC::FTL::LowerDFGToLLVM::speculate): (JSC::FTL::LowerDFGToLLVM::isFunction): (JSC::FTL::LowerDFGToLLVM::isNotFunction): (JSC::FTL::LowerDFGToLLVM::speculateFunction):
- jit/ClosureCallStubRoutine.cpp: (JSC::ClosureCallStubRoutine::ClosureCallStubRoutine): (JSC::ClosureCallStubRoutine::markRequiredObjectsInternal):
- jit/ClosureCallStubRoutine.h: (JSC::ClosureCallStubRoutine::structure): Deleted.
- jit/JIT.h: (JSC::JIT::compileClosureCall): Deleted.
- jit/JITCall.cpp: (JSC::JIT::privateCompileClosureCall): Deleted.
- jit/JITCall32_64.cpp: (JSC::JIT::privateCompileClosureCall): Deleted.
- jit/JITOperations.cpp:
- jit/Repatch.cpp: (JSC::linkClosureCall):
- jit/Repatch.h:
Source/WebCore:
2014-08-06 Mark Hahnenberg <mhahnenberg@apple.com>
Refactor our current implementation of for-in
https://bugs.webkit.org/show_bug.cgi?id=134142
Reviewed by Filip Pizlo.
No new tests.
This patch splits for-in loops into three distinct parts:
- Iterating over the indexed properties in the base object.
- Iterating over the Structure properties in the base object.
- Iterating over any other enumerable properties for that object and any objects in the prototype chain.
It does this by emitting these explicit loops in bytecode, using a new set of bytecodes to
support the various operations required for each loop.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getEnumerableLength): (WebCore::JSDOMWindow::getStructurePropertyNames): (WebCore::JSDOMWindow::getGenericPropertyNames):
- bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader):
- bridge/runtime_array.cpp: (JSC::RuntimeArray::getOwnPropertyNames):
Source/WebKit2:
2014-08-06 Mark Hahnenberg <mhahnenberg@apple.com>
Refactor our current implementation of for-in
https://bugs.webkit.org/show_bug.cgi?id=134142
Reviewed by Filip Pizlo.
- WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::invalidate): Fixed an invalid ASSERT that was crashing in debug builds.
- 2:09 PM Changeset in webkit [172175] by
-
- 15 edits in branches/safari-600.1.4-branch/Source
Merge r172172. <rdar://problem/17862892>
- 1:38 PM Changeset in webkit [172174] by
-
- 4 edits in trunk
Set DSYMUTIL_NUM_THREADS to the number of logical cores
https://bugs.webkit.org/show_bug.cgi?id=135655
Reviewed by Mark Rowe.
.:
- Makefile.shared: Export DSYMUTIL_NUM_THREADS.
Tools:
- Scripts/webkitdirs.pm:
(buildXCodeProject): Set before calling xcodebuild.
- 1:25 PM Changeset in webkit [172173] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merge r172025. <rdar://problem/17715503>
- 1:25 PM Changeset in webkit [172172] by
-
- 15 edits in trunk/Source
REGRESSION (WebKit2): iOS Safari default encoding doesn't follow system language
https://bugs.webkit.org/show_bug.cgi?id=135667
<rdar://problem/17862892>
Reviewed by Anders Carlsson.
Source/WebCore:
Moved a function that computes default encoding from WebKit to WebCore, so that
it could be shared with WebKit2.
- WebCore.exp.in:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/text/TextEncodingRegistry.cpp:
(WebCore::defaultTextEncodingNameForSystemLanguage):
- platform/text/TextEncodingRegistry.h:
Source/WebKit/mac:
- WebView/WebPreferences.mm: (+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]):
Moved implementation to WebCore, so that it can be shared with WebKit2.
- WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h: Compute the actual proper default, don't
hardcode it to ISO-8859-1 hoping that someone else will correct it later.
- Shared/WebPreferencesStore.cpp: Added an include for WebPreferencesDefinitions.h
macro expansion to compile.
- UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::createWithLegacyDefaults):
Added a FIXME.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):
We now use WKGetWebDefaultCFStringEncoding in WebCore, so it needs to be initialized.
- 1:23 PM Changeset in webkit [172171] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r172159. <rdar://problem/17869353>
- 1:19 PM Changeset in webkit [172170] by
-
- 1 edit in branches/safari-537.78-branch/Source/WebCore/ChangeLog
Fixup ChangeLog from merge r169475 -> 171377
- 1:15 PM Changeset in webkit [172169] by
-
- 2 edits in branches/safari-600.1.4-branch/Source/WebCore
Merge r172151. <rdar://problem/17869353>
- 1:12 PM Changeset in webkit [172168] by
-
- 4 edits in branches/safari-600.1.4-branch/Source
Merge r172035. <rdar://problem/17869353>
- 1:12 PM Changeset in webkit [172167] by
-
- 2 edits in trunk/Source/WTF
HashTable based classes leak a lot
https://bugs.webkit.org/show_bug.cgi?id=135638
Reviewed by Darin Adler.
- wtf/HashTable.h:
The operator= taking a rvalue reference was never freeing the memory allocated
for the table of the left hand side object.
This patch fixes the leaks by doing an alloc+swap with a new object.
The object temp gets the reference to m_table, and destroys it in the regular destructor
when going out of scope.
Kudos to Pratik Solanki for finding the leaks.
- 1:09 PM Changeset in webkit [172166] by
-
- 3 edits4 copies in branches/safari-600.1.4-branch
Merge r172112. <rdar://problem/17802174>
- 12:21 PM Changeset in webkit [172165] by
-
- 3 edits in trunk/Source/WebCore
Remove unused RenderBox::reflectionBox().
<https://webkit.org/b/135661>
Reviewed by Antti Koivisto.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionBox): Deleted.
- rendering/RenderBox.h:
- 11:54 AM Changeset in webkit [172164] by
-
- 2 edits in tags/Safari-600.1.7/Source/WebCore
Merge r172025. <rdar://problem/17715503>
- 11:48 AM Changeset in webkit [172163] by
-
- 2 edits in trunk/Websites/webkit.org
[Win] Build error when OFFICIAL_BUILD != 1.
https://bugs.webkit.org/show_bug.cgi?id=135613
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-08-06
Reviewed by Alex Christensen.
Added python installation as a required step before building on Windows.
- building/tools.html:
- 11:32 AM Changeset in webkit [172162] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r172094): tests fail because Inspector test harness does not include UIString
https://bugs.webkit.org/show_bug.cgi?id=135658
Reviewed by Joseph Pecoraro.
- UserInterface/Base/Test.js:
(WebInspector.contentLoaded): Fix brace placement.
(WebInspector.UIString): Added. This is the identity function during testing.
- 11:30 AM Changeset in webkit [172161] by
-
- 4 edits in trunk/Source
Web Inspector: convert ReplayManager to a promise-based API
https://bugs.webkit.org/show_bug.cgi?id=135249
Reviewed by Timothy Hatcher.
Source/WebCore:
Fix some assertions to match ReplayController's preconditions.
- inspector/InspectorReplayAgent.cpp:
(WebCore::InspectorReplayAgent::replayToPosition):
(WebCore::InspectorReplayAgent::replayToCompletion):
Source/WebInspectorUI:
Convert replay commands to an asynchronous, promise-based API. This addresses
two problems with a synchronous replay API: clients can only use the synchronous
API if session and segment state are exactly correct, and trying to change state
to match this requirement requires chaining multiple commands and events.
The asynchronous API allows clients to issue replay commands with impunity,
as long as they can be unambiguously handled. For example, issuing
pausePlayback() while capturing is not allowed, but issuing startCapturing()
while replaying is allowed. The API also hides implementation details that
are not important, such as steps to unpause or temporarily disable the debugger.
This patch also cleans up uses of promises, such as adding error re-throwing.
It adds return type annotations to public ReplayManager asynchronous methods.
- UserInterface/Controllers/ReplayManager.js:
(WebInspector.ReplayManager.catch):
(WebInspector.ReplayManager):
(WebInspector.ReplayManager.prototype.createSession):
(WebInspector.ReplayManager.prototype.switchSession):
(WebInspector.ReplayManager.prototype.startCapturing):
(WebInspector.ReplayManager.prototype.stopCapturing):
(WebInspector.ReplayManager.prototype.replayToPosition):
(WebInspector.ReplayManager.prototype.replayToCompletion):
(WebInspector.ReplayManager.prototype.sessionCreated.catch): re-throw.
(WebInspector.ReplayManager.prototype.segmentCompleted.catch): re-throw.
(WebInspector.ReplayManager.prototype.segmentCompleted.catch): re-throw.
(WebInspector.ReplayManager.prototype.segmentUnloaded.catch): re-throw.
(WebInspector.ReplayManager.prototype.sessionCreated.catech): re-throw.
- 11:25 AM Changeset in webkit [172160] by
-
- 3 edits2 adds in trunk
[Mac] Unable to scroll to bottom of nested scrollable areas
https://bugs.webkit.org/show_bug.cgi?id=135637
<rdar://problem/17910241>
Reviewed by Zalan Bujtas.
Source/WebCore:
Test: platform/mac/fast/scrolling/scroll-latched-nested-div.html
Avoid truncating the fractional portion of scroll ranges.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollbarsAfterLayout): Round
the LayoutUnit values for scroll width and height rather than
truncating.
LayoutTests:
- platform/mac/fast/scrolling/scroll-latched-nested-div-expected.txt: Added.
- platform/mac/fast/scrolling/scroll-latched-nested-div.html: Added.
- 11:18 AM Changeset in webkit [172159] by
-
- 2 edits in trunk/Source/WebCore
[iOS] QuickLook returns an invalid MIME type for some documents
https://bugs.webkit.org/show_bug.cgi?id=135651
Reviewed by David Kilzer.
r172151 ensured that we ignore QuickLook delegate messages after an error, but neglected to do so for
connectionDidFinishLoading:. Do not call ResourceLoader::didFinishLoading() if an error has occurred.
- platform/network/ios/QuickLook.mm:
(-[WebResourceLoaderQuickLookDelegate connectionDidFinishLoading:]):
- 10:59 AM Changeset in webkit [172158] by
-
- 5 edits2 adds in trunk
Web Inspector: protocol command invocations should return a promise if no callback is supplied
https://bugs.webkit.org/show_bug.cgi?id=130702
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
This allows the trailing Agent.command.promise(args) to be dropped in favor of just
Agent.command(args). It should make it a bit easier to convert code to use promises.
Test: LayoutTests/inspector/protocol-promise-result.html
- UserInterface/Controllers/ReplayManager.js: Drop use of .promise().
- UserInterface/Controllers/TimelineManager.js: Drop use of .promise().
(WebInspector.TimelineManager.prototype.startCapturing):
- UserInterface/Protocol/InspectorBackend.js:
(.callable): Redirect to the promise entry point if the last argument isn't a function.
(InspectorBackend.Command.create):
LayoutTests:
Addd a test for recieving protocol command results through an explicit callback,
via the .promise() entry point, and via an implicitly created promise.
- inspector/protocol-promise-result-expected.txt: Added.
- inspector/protocol-promise-result.html: Added.
- 10:57 AM Changeset in webkit [172157] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r172155.
https://bugs.webkit.org/show_bug.cgi?id=135659
ChangeLog and commit message are wrong (Requested by estes on
#webkit).
Reverted changeset:
"Unreviewed, rolling out r172145."
https://bugs.webkit.org/show_bug.cgi?id=135657
http://trac.webkit.org/changeset/172155
- 10:53 AM Changeset in webkit [172156] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix
- rendering/TextPainter.cpp: Used incorrect variable name
- 10:46 AM Changeset in webkit [172155] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r172145.
https://bugs.webkit.org/show_bug.cgi?id=135657
caused 1 API test to fail (Requested by zalan on #webkit).
Reverted changeset:
"Cleanup InlineTextBox::paintSelection and
::localSelectionRect."
https://bugs.webkit.org/show_bug.cgi?id=135631
http://trac.webkit.org/changeset/172145
Patch by Commit Queue <commit-queue@webkit.org> on 2014-08-06
- 10:44 AM Changeset in webkit [172154] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r172145.
https://bugs.webkit.org/show_bug.cgi?id=135657
caused 1 API test to fail (Requested by zalan on #webkit).
Reverted changeset:
"Cleanup InlineTextBox::paintSelection and
::localSelectionRect."
https://bugs.webkit.org/show_bug.cgi?id=135631
http://trac.webkit.org/changeset/172145
- 10:35 AM Changeset in webkit [172153] by
-
- 3 edits2 adds in trunk
Text-shadow with (0, 0) offset and radius = 0 is ugly
https://bugs.webkit.org/show_bug.cgi?id=135357
Reviewed by Darin Adler.
Source/WebCore:
Instead, check for this kind of shadow and don't draw it.
Test: fast/text/empty-shadow.html
- rendering/TextPainter.cpp:
(WebCore::isEmptyShadow): Does a shadow match these criteria?
(WebCore::paintTextWithShadows): If so, don't draw it.
LayoutTests:
Check that this kind of shadow ends up invisible.
- fast/text/empty-shadow-expected.html: Added
- fast/text/empty-shadow.html: Added
- 10:27 AM Changeset in webkit [172152] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARM] Incorrect handling of Unicode characters
https://bugs.webkit.org/show_bug.cgi?id=135380
Reviewed by Darin Adler.
Removed erroneous fast case from stringFromUTF(), since it assumed that
char is always implemented as signed.
- jsc.cpp:
(stringFromUTF):
- 10:23 AM Changeset in webkit [172151] by
-
- 2 edits in trunk/Source/WebCore
[iOS] QuickLook returns an invalid MIME type for some documents
https://bugs.webkit.org/show_bug.cgi?id=135651
Reviewed by David Kilzer.
In some cases QuickLook indicates a failure by returning a nil MIME type in -[QLPreviewConverter previewResponse]
rather than calling connection:didFailWithError:. Calling ResourceLoader::didReceiveResponse() with a response
containing a nil MIME type leads to a crash.
Stop loading the resource and display an error page if QuickLook cannot provide a MIME type for the converted response.
No new tests. QuickLook is not testable from WebKit.
- platform/network/ios/QuickLook.mm:
(-[WebResourceLoaderQuickLookDelegate _sendDidReceiveResponseIfNecessary]): Called ResourceLoader::didFail() if
MIME type was nil. Called ResourceLoader::didReceiveResponse() otherwise.
(-[WebResourceLoaderQuickLookDelegate connection:didReceiveDataArray:]): Called -_sendDidReceiveResponseIfNecessary.
(-[WebResourceLoaderQuickLookDelegate connection:didReceiveData:lengthReceived:]): Ditto.
(-[WebResourceLoaderQuickLookDelegate connection:didFailWithError:]): Ditto.
- 9:02 AM Changeset in webkit [172150] by
-
- 1 edit4 moves1 add in trunk/LayoutTests
[CSSRegions] Move full screen tests into fast/regions/fullscreen
https://bugs.webkit.org/show_bug.cgi?id=135650
Reviewed by Andrei Bucur.
Move files and adjust paths accordingly.
- fast/regions/fullscreen/full-screen-video-from-region-expected.txt: Renamed from LayoutTests/fast/regions/full-screen-video-from-region-expected.txt.
- fast/regions/fullscreen/full-screen-video-from-region.html: Renamed from LayoutTests/fast/regions/full-screen-video-from-region.html.
- fast/regions/fullscreen/full-screen-video-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/full-screen-video-in-region-crash-expected.txt.
- fast/regions/fullscreen/full-screen-video-in-region-crash.html: Renamed from LayoutTests/fast/regions/full-screen-video-in-region-crash.html.
- 8:44 AM Changeset in webkit [172149] by
-
- 7 edits in trunk/Source
[JSC] Build fix for FTL on EFL after ftlopt merge
https://bugs.webkit.org/show_bug.cgi?id=135565
Reviewed by Mark Lam.
Source/JavaScriptCore:
Adding an enable guard for native inlining, since it now requires the bitcode
emitted from Clang, and we don't have a good way of creating it from other compilers.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- ftl/FTLState.h:
Source/WTF:
Added ENABLE(FTL_NATIVE_CALL_INLINING).
- wtf/Platform.h:
- 8:09 AM Changeset in webkit [172148] by
-
- 1 edit4 moves3 adds2 deletes in trunk/LayoutTests
[CSSRegions] Move parsing tests into fast/regions/parsing
https://bugs.webkit.org/show_bug.cgi?id=135649
Reviewed by Andrei Bucur.
Move files and adjust file paths.
- fast/regions/parsing/webkit-flow-from-parsing-expected.txt: Renamed from LayoutTests/fast/regions/webkit-flow-from-parsing-expected.txt.
- fast/regions/parsing/webkit-flow-from-parsing.html: Added.
- fast/regions/parsing/webkit-flow-into-parsing-expected.txt: Renamed from LayoutTests/fast/regions/webkit-flow-into-parsing-expected.txt.
- fast/regions/parsing/webkit-flow-into-parsing.html: Renamed from LayoutTests/fast/regions/webkit-flow-into-parsing.html.
- fast/regions/parsing/webkit-region-fragment-parsing-expected.txt: Renamed from LayoutTests/fast/regions/webkit-region-fragment-parsing-expected.txt.
- fast/regions/parsing/webkit-region-fragment-parsing.html: Added.
- fast/regions/webkit-flow-from-parsing.html: Removed.
- fast/regions/webkit-region-fragment-parsing.html: Removed.
- 8:07 AM Changeset in webkit [172147] by
-
- 9 edits in trunk
[GTK] Add support for user scripts to WebKitUserContentManager
https://bugs.webkit.org/show_bug.cgi?id=134738
Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-08-06
Reviewed by Carlos Garcia Campos.
Add support for user scripts, to complement the user style sheet
support already present in WebKitUserContentManager. Most of the
moving parts are already present, so this just adds a boxed type
for user scripts (WebKitUserScript) and the corresponding methods
to add and remove scripts from the WebKitUserContentManager.
Source/WebKit2:
- UIProcess/API/gtk/WebKitUserContent.cpp: Add a WebKitUserScript
boxed type and its corresponding methods and enums.
(toUserScriptInjectionTime): Needed to convert
WebKitUserScriptInjectionTime values into its WebCore counterparts.
(_WebKitUserScript::_WebKitUserScript): Added.
(_WebKitUserScript::referenceCount): Ditto.
(webkit_user_script_ref):
(webkit_user_script_unref):
(webkit_user_script_new):
(webkitUserScriptGetUserScript): Internal method to obtain the
boxed WebCore::UserScript value.
- UIProcess/API/gtk/WebKitUserContent.h: Add the new public API
methods.
- UIProcess/API/gtk/WebKitUserContentManager.cpp: Implement the
methods for adding and removing user scripts.
(webkit_user_content_manager_add_script):
(webkit_user_content_manager_remove_all_scripts):
- UIProcess/API/gtk/WebKitUserContentManager.h: Add the new public
API methods.
- UIProcess/API/gtk/WebKitUserContentPrivate.h: Add the definition
for the new private function.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the
new public methods in the API documentation.
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
Add test case for injected user scripts.
(isScriptInjectedForURLAtPath):
(removeOldInjectedContentAndResetLists):
(testUserContentManagerInjectedStyleSheet):
(testUserContentManagerInjectedScript):
(beforeAll):
(removeOldInjectedStyleSheetsAndResetLists): Deleted.
- 8:06 AM Changeset in webkit [172146] by
-
- 3 edits2 adds in trunk
REGRESSION (r163382): Overflow hidden for inner elements breaks blurring
https://bugs.webkit.org/show_bug.cgi?id=135318
Reviewed by Zalan Bujtas.
Source/WebCore:
For elements with border radius, clipping must be applied using clipRoundedRect.
This regressed in r163382, when normal clipping started being applied also
for elements having border radius.
Test: fast/filter-image/clipped-filter.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::restoreClip):
LayoutTests:
Added test for filter applied on an element overflowing its parent, which has overflow:hidden.
- fast/filter-image/clipped-filter-expected.html: Added.
- fast/filter-image/clipped-filter.html: Added.
- 8:04 AM Changeset in webkit [172145] by
-
- 3 edits in trunk/Source/WebCore
Cleanup InlineTextBox::paintSelection and ::localSelectionRect.
https://bugs.webkit.org/show_bug.cgi?id=135631
Reviewed by Darin Adler.
Covered by existing tests.
- rendering/InlineTextBox.cpp: Ideally these 2 functions should share some more code.
(WebCore::InlineTextBox::localSelectionRect): Local coordinates should not be snapped/enclosed.
This change could potentially break some selections. Should that be the case, they need to be addressed
separately.
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection): Minor cleanup.
- rendering/InlineTextBox.h:
- 8:01 AM Changeset in webkit [172144] by
-
- 7 edits in trunk
[GTK] Be able to disable gtk2 dependency
https://bugs.webkit.org/show_bug.cgi?id=135505
Reviewed by Gustavo Noronha Silva.
.:
Add ENABLE_PLUGIN_PROCESS_GTK2 compile option. GTK+2 is only
required when it's enabled. It's enabled by default.
- Source/cmake/OptionsGTK.cmake:
Source/WebCore:
Do not build WebCorePlatformGTK2 when ENABLE_PLUGIN_PROCESS_GTK2
is OFF.
- PlatformGTK.cmake:
Source/WebKit2:
- PlatformGTK.cmake: Only build WebKitPluginProcess2 when
ENABLE_PLUGIN_PROCESS_GTK2 is ON.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Do not try to launch
WebKitPluginProcess2 executable when ENABLE_PLUGIN_PROCESS_GTK2 is OFF.
- 6:45 AM Changeset in webkit [172143] by
-
- 2 edits in trunk/Source/WebCore
Gardening: fix bindings test breakage for for r170564 merged in r172129.
<https://webkit.org/b/134333>
Not reviewed.
No new tests.
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
- 6:36 AM Changeset in webkit [172142] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] Rename translation domain to WebKit2GTK-4.0
https://bugs.webkit.org/show_bug.cgi?id=135646
Reviewed by Carlos Garcia Campos.
- CMakeLists.txt:
- 4:13 AM Changeset in webkit [172141] by
-
- 1 edit8 moves in trunk/LayoutTests
[CSSRegions] Move selection tests under fast/regions/selection
https://bugs.webkit.org/show_bug.cgi?id=135641
Reviewed by Andrei Bucur.
Move selection related tests under fast/regions/selection.
- fast/regions/selection/selection-gaps-paint-crash-expected.txt: Renamed from LayoutTests/fast/regions/selection-gaps-paint-crash-expected.txt.
- fast/regions/selection/selection-gaps-paint-crash.html: Renamed from LayoutTests/fast/regions/selection-gaps-paint-crash.html.
- fast/regions/selection/selection-in-overflow-expected.html: Renamed from LayoutTests/fast/regions/selection-in-overflow-expected.html.
- fast/regions/selection/selection-in-overflow-hit-testing-expected.html: Renamed from LayoutTests/fast/regions/selection-in-overflow-hit-testing-expected.html.
- fast/regions/selection/selection-in-overflow-hit-testing.html: Renamed from LayoutTests/fast/regions/selection-in-overflow-hit-testing.html.
- fast/regions/selection/selection-in-overflow.html: Renamed from LayoutTests/fast/regions/selection-in-overflow.html.
- fast/regions/selection/selection-in-text-after-overflow-hit-testing-expected.html: Renamed from LayoutTests/fast/regions/selection-in-text-after-overflow-hit-testing-expected.html.
- fast/regions/selection/selection-in-text-after-overflow-hit-testing.html: Renamed from LayoutTests/fast/regions/selection-in-text-after-overflow-hit-testing.html.
- 4:00 AM Changeset in webkit [172140] by
-
- 1 edit4 moves in trunk/LayoutTests
[CSSRegions] Move auto-height tests into fast/regions/auto-size
https://bugs.webkit.org/show_bug.cgi?id=135645
Reviewed by Andrei Bucur.
- fast/regions/auto-size/region-height-auto-to-defined-expected.txt: Renamed from LayoutTests/fast/regions/region-height-auto-to-defined-expected.txt.
- fast/regions/auto-size/region-height-auto-to-defined.html: Renamed from LayoutTests/fast/regions/region-height-auto-to-defined.html.
- fast/regions/auto-size/region-height-defined-to-auto-expected.txt: Renamed from LayoutTests/fast/regions/region-height-defined-to-auto-expected.txt.
- fast/regions/auto-size/region-height-defined-to-auto.html: Renamed from LayoutTests/fast/regions/region-height-defined-to-auto.html.
- 3:50 AM Changeset in webkit [172139] by
-
- 2 edits in trunk/Tools
[GTK] run-launcher --gtk still fails
https://bugs.webkit.org/show_bug.cgi?id=135642
Patch by Philippe Normand <pnormand@igalia.com> on 2014-08-06
Reviewed by Carlos Garcia Campos.
The perl interpreter is confused by the combination of string
concatenation and a ternary in the same line. Using a separate
variable to determine the library file extension fixes this issue.
- Scripts/webkitdirs.pm:
(builtDylibPathForName): Use an intermediate variable, it's more
readable and unambiguous.
- 3:10 AM Changeset in webkit [172138] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed typo correction.
- bindings/scripts/CodeGeneratorJS.pm: removed unnecessary space.
(GenerateImplementation):
