Timeline



Aug 14, 2014:

9:24 PM Changeset in webkit [172621] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove two unused Range functions.
<https://webkit.org/b/135944>

Reviewed by Geoffrey Garen.

  • dom/Range.cpp:

(WebCore::Range::maxStartOffset): Deleted.
(WebCore::Range::maxEndOffset): Deleted.

  • dom/Range.h:
9:10 PM Changeset in webkit [172620] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Preserve editing style for -webkit-tap-highlight-color on all ports that enable ENABLE_TOUCH_EVENTS
https://bugs.webkit.org/show_bug.cgi?id=135963

Reviewed by Andy Estes.

Currently we only preserve the CSS property -webkit-tap-highlight-color during editing operations
for iOS. Instead we should preserve it for all ports that enable ENABLE_TOUCH_EVENTS as this CSS
property isn't specific to iOS.

Also added FIXME comment with regards to the CSS property -webkit-composition-fill-color.

  • editing/EditingStyle.cpp:
9:06 PM Changeset in webkit [172619] by benjamin@webkit.org
  • 8 edits
    8 adds in trunk

CSS JIT: compile the :empty pseudo class
https://bugs.webkit.org/show_bug.cgi?id=135958

Reviewed by Andreas Kling.

Source/WebCore:

Compile :empty, nothing fancy.

Tests: fast/selectors/empty-basics.html

fast/selectors/empty-long-adjacent-backtracking.html
fast/selectors/empty-adjacent-style-update.html
fast/selectors/empty-style-update.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::jumpIfElementIsNotEmpty):
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmpty):
(WebCore::SelectorCompiler::setElementStyleFromContextIsAffectedByEmptyAndUpdateRenderStyleIfNecessary):
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmptyAndUpdateRenderStyleIfNecessary):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsEmpty):

  • dom/CharacterData.h:

(WebCore::CharacterData::dataMemoryOffset):

  • dom/ContainerNode.h:

(WebCore::ContainerNode::firstChildMemoryOffset):

  • dom/Node.h:

(WebCore::Node::flagIsText):

Source/WTF:

  • wtf/text/StringImpl.h:

(WTF::StringImpl::lengthMemoryOffset):

LayoutTests:

Add some test coverage, :empty had very little testing.

The test empty-adjacent-style-update expose some problems with style update,
I will look into them separately.

  • fast/selectors/empty-adjacent-style-update-expected.txt: Added.
  • fast/selectors/empty-adjacent-style-update.html: Added.
  • fast/selectors/empty-basics-expected.txt: Added.
  • fast/selectors/empty-basics.html: Added.
  • fast/selectors/empty-long-adjacent-backtracking-expected.txt: Added.
  • fast/selectors/empty-long-adjacent-backtracking.html: Added.
  • fast/selectors/empty-style-update-expected.txt: Added.
  • fast/selectors/empty-style-update.html: Added.
8:22 PM Changeset in webkit [172618] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Allocate the whole RegExpMatchesArray backing store up front.
<https://webkit.org/b/135217>

We were using the generic array backing store allocation path for
RegExpMatchesArray which meant starting with 4 slots and then growing
it dynamically as we append. Since we always know the final number of
entries up front, allocate a perfectly-sized backing store right away.

~2% progression on Octane/regexp.

Reviewed by Geoffrey Garen.

  • runtime/JSArray.h:

(JSC::createArrayButterflyWithExactLength):

  • runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::create):

5:30 PM Changeset in webkit [172617] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Dragging Undocked inspector by window title has broken behavior
https://bugs.webkit.org/show_bug.cgi?id=135950

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

On Mac ports where we the inspector content goes everywhere, window dragging behavior
still exists for the top 22px of the window. So don't do our JavaScript based window
dragging for this special region.

  • UserInterface/Models/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.Modifier.get CommandOrControl):
(WebInspector.KeyboardShortcut.prototype.get displayName):
Instead of calling a host function, use the value already in the frontend.

5:21 PM Changeset in webkit [172616] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebCore

Implement scroll snapping animations on Mac
https://bugs.webkit.org/show_bug.cgi?id=135768

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-14
Reviewed by Beth Dakin.

Implementing the scroll snap animations required for snapping in both overflow and mainframe areas on Mac.
Since we receive a series of discrete wheel events, we need to predict the distance we need to traverse,
compute the appropriate snap point, and then compute an animation curve to that location. The snap animations
are split into two types: snapping, which handles letting go of the trackpad with zero velocity, and gliding,
which handles flick gestures. In both cases, sinusoidal curves are used to ease animation to the target
location. In the former case, the initial velocity is low, and increases to a maximum value during the middle
of the animation before decreasing to 0. In the latter case, the curve is computed such that the initial
velocity matches the user's scroll velocity, and the final velocity matches a lower final velocity that is
somewhat arbitrarily computed. (See the FIXME in AxisScrollSnapOffsets::initializeGlideParameters). How the
equations and constants were chosen is described in greater detail in the comments above
AxisScrollSnapOffsets::computeGlideDelta and AxisScrollSnapOffsets::computeSnapDelta. Note that the final
velocity should ideally be equal to 0. However, with this particular curve, this caused the animation to feel
too slow near the snap point.

No tests, since there is no observable change in behavior. Tests will be included when iOS and Mac scrolling
areas hook into this code.

  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::closestSnapOffset): Computes the closest snap offset given velocity and prdicted destination.

  • page/scrolling/AxisScrollSnapOffsets.h:
  • platform/mac/AxisScrollSnapAnimator.h: Added.

(WebCore::AxisScrollSnapAnimatorClient::~AxisScrollSnapAnimatorClient):

  • platform/mac/AxisScrollSnapAnimator.mm: Added.

(WebCore::toWheelEventStatus): Converts a pair of PlatformWheelEventPhases to a WheelEventStatus.
(WebCore::projectedInertialScrollDistance): Attempts to predict the distance covered by the inertial scrolling phase.
(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
(WebCore::AxisScrollSnapAnimator::handleWheelEvent): Updates the internal state of the AxisScrollSnapAnimator, given a PlatformWheelEvent
(WebCore::AxisScrollSnapAnimator::shouldOverrideWheelEvent): Determines whether or not we should override a wheel event given the animator's internal state.
(WebCore::AxisScrollSnapAnimator::scrollSnapAnimationUpdate): Updates a single loop of the scroll snapping animation.
(WebCore::AxisScrollSnapAnimator::beginScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::computeSnapDelta): See comments for more information.
(WebCore::AxisScrollSnapAnimator::computeGlideDelta): See comments for more information.
(WebCore::AxisScrollSnapAnimator::initializeGlideParameters):
(WebCore::AxisScrollSnapAnimator::pushInitialWheelDelta):
(WebCore::AxisScrollSnapAnimator::averageInitialWheelDelta):
(WebCore::AxisScrollSnapAnimator::clearInitialWheelDeltaWindow):

5:18 PM Changeset in webkit [172615] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Split console toggle button wrong - Images/Images/SplitToggleUp.svg does not exist
https://bugs.webkit.org/show_bug.cgi?id=135957

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
Wrong image path passed to platformImagePath.

4:59 PM Changeset in webkit [172614] by commit-queue@webkit.org
  • 39 edits in trunk/Source

Allow high fidelity type profiling to be enabled and disabled.
https://bugs.webkit.org/show_bug.cgi?id=135423

Patch by Saam Barati <sbarati@apple.com> on 2014-08-14
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • Merged op_put_to_scope_with_profile and op_get_from_scope_with_profile into op_profile_types_with_high_fidelity by adding extra arguments to the opcode.
  • Altered SymbolTable to use less memory by adding a rare data structure for type profiling.
  • Created an interface to turn on and off type profiling from the Web Inspector.
  • Refactored how entries are written to HighFidelityLog to make it easier to inline when generating machine code.
  • Implemented op_profile_types_with_high_fidelity in the baseline JIT by inlining the process of writing to the log and doing a small amount of type inference optimizations.
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::scopeDependentProfile): Deleted.

  • bytecode/CodeBlock.h:
  • bytecode/TypeLocation.h:

(JSC::TypeLocation::TypeLocation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity):
(JSC::BytecodeGenerator::emitGetFromScopeWithProfile): Deleted.
(JSC::BytecodeGenerator::emitPutToScopeWithProfile): Deleted.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ThisNode::emitBytecode):
(JSC::ResolveNode::emitBytecode):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitResolve):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::TypeRecompiler::operator()):
(Inspector::recompileAllJSFunctionsForTypeProfiling):
(Inspector::InspectorRuntimeAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorRuntimeAgent::enableHighFidelityTypeProfiling):
(Inspector::InspectorRuntimeAgent::disableHighFidelityTypeProfiling):
(Inspector::InspectorRuntimeAgent::setHighFidelityTypeProfilingEnabledState):

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend):

  • inspector/protocol/Runtime.json:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_types_with_high_fidelity):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_types_with_high_fidelity):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::getFromScopeCommon): Deleted.
(JSC::LLInt::putToScopeCommon): Deleted.

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/HighFidelityLog.cpp:

(JSC::HighFidelityLog::initializeHighFidelityLog):
(JSC::HighFidelityLog::~HighFidelityLog):
(JSC::HighFidelityLog::processHighFidelityLog):

  • runtime/HighFidelityLog.h:

(JSC::HighFidelityLog::LogEntry::structureIDOffset):
(JSC::HighFidelityLog::LogEntry::valueOffset):
(JSC::HighFidelityLog::LogEntry::locationOffset):
(JSC::HighFidelityLog::recordTypeInformationForLocation):
(JSC::HighFidelityLog::logEndPtr):
(JSC::HighFidelityLog::logStartOffset):
(JSC::HighFidelityLog::currentLogEntryOffset):

  • runtime/HighFidelityTypeProfiler.cpp:

(JSC::HighFidelityTypeProfiler::logTypesForTypeLocation):
(JSC::descriptorMatchesTypeLocation):

  • runtime/HighFidelityTypeProfiler.h:
  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):
(JSC::SymbolTable::cloneCapturedNames):
(JSC::SymbolTable::prepareForHighFidelityTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForRegister):
(JSC::SymbolTable::globalTypeSetForRegister):
(JSC::SymbolTable::globalTypeSetForVariable):

  • runtime/SymbolTable.h:

(JSC::SymbolTable::add):
(JSC::SymbolTable::set):

  • runtime/TypeLocationCache.cpp:

(JSC::TypeLocationCache::getTypeLocation):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::getRuntimeTypeForValue):
(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::allPrimitiveTypeNames):
(JSC::TypeSet::addTypeForValue): Deleted.

  • runtime/TypeSet.h:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::nextTypeLocation):
(JSC::VM::enableHighFidelityTypeProfiling):
(JSC::VM::disableHighFidelityTypeProfiling):
(JSC::VM::dumpHighFidelityProfilingTypes):

  • runtime/VM.h:

(JSC::VM::nextLocation): Deleted.

Source/WebCore:

PageRuntimeAgent and WorkerRuntimeAgent now call their super
class's (InspectorRuntimeAgent) implementation of willDestroyFrontendAndBackend
to give InspectorRuntimeAgent a chance to recompile all JavaScript
functions, if necessary, for type profiling.

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):

  • inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):

4:50 PM Changeset in webkit [172613] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

4:43 PM Changeset in webkit [172612] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.10

New Tag.

3:59 PM Changeset in webkit [172611] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172609. <rdar://problem/18023620>

3:56 PM Changeset in webkit [172610] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch

Merged r172604. <rdar://problem/18022221>

3:22 PM Changeset in webkit [172609] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Correct build when DerivedSources location not supplied by build environment
https://bugs.webkit.org/show_bug.cgi?id=135954
<rdar://problem/18023620>

Reviewed by Joseph Pecoraro.

The DerivedSourcesDirectory is not always defined, depending on what
solution is being used to build this project. Instead, just define
it directly, since we already know where it needs to go.

Also:

  1. Stop redirecting the copy output to NUL so I can see if this fails in the future.
  2. Make sure the target directory exists before copying to it.
  • WebCore.vcxproj/copyForwardingHeaders.cmd: Properly specify

the directories for copying the JS file.

2:39 PM Changeset in webkit [172608] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

Fixed a bmalloc crash seen on the EWS bot
https://bugs.webkit.org/show_bug.cgi?id=135955

Reviewed by Andreas Kling.

  • bmalloc/Syscall.h: Some CG APIs vm_copy their input buffers. If the

input buffer is a malloc region, that region will get marked Copy-On-Write
by the kernel. Calls to madvise() for COW regions fail and return EINVAL
on older OS X's. In 10.10, they still fail, but they do not return
EINVAL.

So, we can only ASSERT that our syscalls succeed starting with 10.10.

2:36 PM Changeset in webkit [172607] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS3-Text] Cosmetics on RenderBlockFlow::textAlignmentForLine
https://bugs.webkit.org/show_bug.cgi?id=135940

Reviewed by Darin Adler.

Processing the not CSS3_TEXT case first, and removing an extra whitespace after r172524.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::textAlignmentForLine):

2:34 PM Changeset in webkit [172606] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Avoid re-binding the same function over and over
https://bugs.webkit.org/show_bug.cgi?id=135949

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype._startAutoCapturing):
(WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
(WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
Stash a bound copy of the function once, and reuse it.

2:17 PM Changeset in webkit [172605] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

Fixed the bmalloc build
https://bugs.webkit.org/show_bug.cgi?id=135953

Reviewed by Andreas Kling.

  • bmalloc.xcodeproj/project.pbxproj: Marked a few headers as private.

These headers are used, so they must be available outside the project.

2:09 PM Changeset in webkit [172604] by Brent Fulgham
  • 5 edits in trunk

[Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
https://bugs.webkit.org/show_bug.cgi?id=135948
<rdar://problem/18022221>

Reviewed by David Kilzer.

Tools:

  • Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests

for RC_ProjectBuildVersion.

WebKitLibraries:

  • win/tools/scripts/auto-version.pl:

(splitVersion): Use RC_ProjectBuildVersion (or RC_PROJECTBUILDVERSION) if set
in the environment as the 'Build Version', unless the multi-tuple version
supplied by RC_ProjectSourceVersion already has a fourth component.

  • win/tools/scripts/version-stamp.pl: Check for RC_ProjectBuildVersion and

use it in preference to RC_PROJECTBUILDVERSION.

2:04 PM Changeset in webkit [172603] by mhock@apple.com
  • 3 edits
    3 adds in trunk

IndexedDB should respect SchemeRegistry's database access setting.
https://bugs.webkit.org/show_bug.cgi?id=135890
<rdar://problem/17989469>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: storage/indexeddb/open-db-private-browsing.html

  • Modules/indexeddb/IDBFactory.cpp:

LayoutTests:

  • storage/indexeddb/open-db-private-browsing-expected.txt: Added.
  • storage/indexeddb/open-db-private-browsing.html: Added. Simple test to open database in private browsing mode.
  • storage/indexeddb/resources/open-db-private-browsing.js: Added.
1:58 PM Changeset in webkit [172602] by dfarler@apple.com
  • 2 edits in trunk/Tools

[iOS] run-webkit-tests runs webkit-build-directory on every test
https://bugs.webkit.org/show_bug.cgi?id=135409

Reviewed by Daniel Bates.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init): Cache Mac build directory.
(IOSSimulatorPort.relay_path): Use cached build directory.
(IOSSimulatorPort._path_to_image_diff): Use cached build directory.

1:40 PM Changeset in webkit [172601] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
https://bugs.webkit.org/show_bug.cgi?id=135946

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

Each TimelineContentView was listening for the TimelineManager's start/stop
capturing events. However, only the active recording could possibly update.
Likewise, if a pre-existing recording started and stopped we did not properly
stop in the case where we were waiting for an event to update the current time,
which would result in an infinite rAF loop of no updates.

  • UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.unloaded):
When a timeline recording is unloaded trigger an event.

  • UserInterface/Views/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
Assert we were not already waiting.

(WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
Properly handle the case of starting/stoping an already existing recording
without a new event coming in.

(WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
(WebInspector.TimelineContentView.prototype._recordingReset):
Convert to a boolean instead of deleting state.

(WebInspector.TimelineContentView.prototype._recordingUnloaded):
Stop listening to timeline manager events that no longer affect unloaded recordings.

12:46 PM Changeset in webkit [172600] by yoav@yoav.ws
  • 2 edits in trunk/Source/WebCore

srcset with w descriptor doesn't behave as expected when sizes is not supported.
https://bugs.webkit.org/show_bug.cgi?id=135935

Reviewed by Dean Jackson.

In current implementation, if sizes is not supported, when authors would write
markup such as <img src=fallback.jpg srcset="100px.jpg 100w, 400px.jpg 400w">
the first candidate in srcset would be picked, regardless of its dimensions
That is likely to be confusing for authors.
Dropping these "not yet supported" candidates is likely to be less confusing,
and will result in the "fallback.jpg" candidate being picked.

No new tests since this change only concerns builds that are built
with the PICTURE_SIZES compile flag turned off.

  • html/parser/HTMLSrcsetParser.cpp:

(WebCore::parseDescriptors):
Drop candidates that include either 'w' or 'h' descriptors when the
sizes feature is not supported.

12:38 PM Changeset in webkit [172599] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Make inherited style and parent renderer references
https://bugs.webkit.org/show_bug.cgi?id=135857

Reviewed by Andreas Kling.

We don't recurse into non-rendered subtrees anymore so they can't be null.
Also stop using Element::renderStyle() as it differs from e->renderer().style() in
some rare cases (that should be fixed).

  • style/StyleResolveTree.cpp:

(WebCore::Style::RenderTreePosition::parent):
(WebCore::Style::RenderTreePosition::RenderTreePosition):
(WebCore::Style::RenderTreePosition::canInsert):
(WebCore::Style::RenderTreePosition::insert):
(WebCore::Style::RenderTreePosition::computeNextSibling):
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::styleForElement):
(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::textRendererIsNeeded):
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::resetStyleForNonRenderedDescendants):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):

12:28 PM Changeset in webkit [172598] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Update scope resolution to assume that the parent activation is always there
https://bugs.webkit.org/show_bug.cgi?id=135947

Reviewed by Andreas Kling.

Another incremental step in removing the idea of lazily created
activations.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitResolveClosure):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitResolveClosure):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
11:54 AM Changeset in webkit [172597] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

[Forms] We should share RenderStyle object for optgroup and option element
https://bugs.webkit.org/show_bug.cgi?id=88405

Reviewed by Andreas Kling.

We can remove this special case now.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):

11:36 AM Changeset in webkit [172596] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[Services with UI] Selection services don't work inside <iframes>.
https://bugs.webkit.org/show_bug.cgi?id=135941
<rdar://problem/17957690>

Reviewed by Tim Horton.

Need to map the selection rectangles using the correct FrameView.
When handling the click, we must use the selection from the focused frame.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::buildSelectionHighlight):
(WebKit::ServicesOverlayController::handleClick):

11:17 AM Changeset in webkit [172595] by mrowe@apple.com
  • 6 edits in trunk/Source

<https://webkit.org/b/135909> Move helper applications out of the root of the framework.

As described in <https://developer.apple.com/library/mac/technotes/tn2206/>, for bundles containing
a Versions directory there may be no other content at the top level of the bundle other than symlinks.
Upcoming changes to code signing will prevent bundles that violate this rule from being signed.

Reviewed by Sam Weinig.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Add the symlink to WebKitPluginHost.app in the Versions/A

directory of the framework rather than at the top level.

Source/WebKit2:

  • Configurations/Base.xcconfig: Define a configuration setting that points to the content directory

of the framework. On OS X this is Versions/A. On iOS, where frameworks are shallow, this is the top level.

  • Configurations/BaseLegacyProcess.xcconfig: Install the legacy processes in the content directory

of the framework.

  • WebKit2.xcodeproj/project.pbxproj: Copy the legacy processes into the content directory of the

framework during engineering builds. Generate symlinks for the legacy processes to their locations
in Versions/Current. This is necessary because -[NSBundle pathForAuxiliaryExecutable:] only looks
at the top level of the framework wrapper.

11:07 AM Changeset in webkit [172594] by oliver@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Create activations eagerly
https://bugs.webkit.org/show_bug.cgi?id=135942

Reviewed by Geoffrey Garen.

Prepare to rewrite activation objects into a more
sane implementation. Step 1 is reverting to eager
creation of the activation object. This results in
a 1.35x regression in earley, but otherwise has a
minimal performance impact.

The earley regression is being tracked by bug #135943

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitPushWithScope):
(JSC::BytecodeGenerator::emitPushCatchScope):
(JSC::BytecodeGenerator::createActivationIfNecessary): Deleted.

  • bytecompiler/BytecodeGenerator.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_create_activation):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_create_activation):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
10:59 AM Changeset in webkit [172593] by achristensen@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit

Unreviewed. Removing empty directories.

  • qt: Removed.
  • qt/declarative: Removed.
  • qt/docs: Removed.
  • qt/docs/webkitsnippets: Removed.
  • qt/examples: Removed.
  • qt/tests: Removed.
  • qt/tests/MIMESniffing: Removed.
  • qt/tests/benchmarks: Removed.
  • qt/tests/qgraphicswebview: Removed.
  • qt/tests/qwebelement: Removed.
  • qt/tests/qwebframe: Removed.
  • qt/tests/qwebhistory: Removed.
  • qt/tests/qwebpage: Removed.
  • qt/tests/qwebsecurityorigin: Removed.
  • qt/tests/qwebview: Removed.
10:52 AM Changeset in webkit [172592] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2GTK - WebKitWebProcess assertion fails when dragging and dropping a file into the view
https://bugs.webkit.org/show_bug.cgi?id=127576

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-14
Reviewed by Carlos Garcia Campos.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction): Assume read access
to any file that has been dragged into the web view when compiling for
GTK, since we don't support sandbox extensions.

10:49 AM Changeset in webkit [172591] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Remove nonRendererStyle
https://bugs.webkit.org/show_bug.cgi?id=135938

Reviewed by Andreas Kling.

It is used to support styling of non-renderer option elements. We have a better
mechanism for this, Element::computedStyle().

  • dom/Element.cpp:

(WebCore::Element::resetComputedStyle):
(WebCore::Element::willResetComputedStyle):

Add a virtual callback for computed style reset.

  • dom/Element.h:
  • dom/Node.h:

(WebCore::Node::nonRendererStyle): Deleted.

  • dom/NodeRenderStyle.h:

(WebCore::Node::renderStyle):

renderStyle() now always matches renderer()->style()

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
(WebCore::HTMLOptGroupElement::isFocusable):
(WebCore::HTMLOptGroupElement::didAttachRenderers): Deleted.
(WebCore::HTMLOptGroupElement::willDetachRenderers): Deleted.
(WebCore::HTMLOptGroupElement::updateNonRenderStyle): Deleted.
(WebCore::HTMLOptGroupElement::nonRendererStyle): Deleted.
(WebCore::HTMLOptGroupElement::customStyleForRenderer): Deleted.

  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isFocusable):

Use computedStyle.

(WebCore::HTMLOptionElement::willResetComputedStyle):
(WebCore::HTMLOptionElement::didAttachRenderers): Deleted.
(WebCore::HTMLOptionElement::willDetachRenderers): Deleted.
(WebCore::HTMLOptionElement::updateNonRenderStyle): Deleted.
(WebCore::HTMLOptionElement::nonRendererStyle): Deleted.
(WebCore::HTMLOptionElement::customStyleForRenderer): Deleted.
(WebCore::HTMLOptionElement::didRecalcStyle): Deleted.

  • html/HTMLOptionElement.h:
  • rendering/RenderMenuList.cpp:

(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):

Use computedStyle.

9:39 AM Changeset in webkit [172590] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172584. <rdar://problem/18015428>

9:37 AM Changeset in webkit [172589] by Lucas Forschler
  • 1 edit in branches/safari-600.1-branch/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css

Merge patch from <rdar://problem/18016176>.

9:27 AM Changeset in webkit [172588] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172506. <rdar://problem/17810998>

9:21 AM Changeset in webkit [172587] by commit-queue@webkit.org
  • 4 edits in trunk

Add support for ppc, ppc64, ppc64le, s390, s390x into the CMake build
https://bugs.webkit.org/show_bug.cgi?id=135937

Patch by Tomas Popela <tpopela@redhat.com> on 2014-08-14
Reviewed by Carlos Garcia Campos.

  • CMakeLists.txt:
9:08 AM Changeset in webkit [172586] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

Initialize a separate variable (TestWTF_SOURCES) with the list of files
that are built into the TestWTF executable and move it above the platform-specific
config file inclusion. This makes it possible to add platform-specific files to that
list (e.g. GUniquePtr.cpp for the GTK port).

Rubber-stamped by Carlos Garcia Campos.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/PlatformGTK.cmake:
9:06 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
8:58 AM Changeset in webkit [172585] by clopez@igalia.com
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Update expectations with new identified failures and flakiness.
  • platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt: Rebaseline after r172517.
  • platform/gtk/fast/ruby/ruby/ruby-base-merge-block-children-crash-2-expected.png: Removed. File was in wrong path.
  • platform/gtk/fast/ruby/ruby/ruby-base-merge-block-children-crash-2-expected.txt: Removed. File was in wrong path.
  • platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Rebaseline after r172136.
  • platform/gtk/scrollbars/scrollbar-selectors-expected.txt: Added. Rebaseline after r172220.
8:13 AM Changeset in webkit [172584] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[MSE] Altering the quality of a YouTube video will cause the video to distort and display an error message
https://bugs.webkit.org/show_bug.cgi?id=135931

Reviewed by Eric Carlson.

When removing samples from the TrackBuffer's sample map, also remove those samples from the
TrackBuffer's decode queue. Otherwise, removed samples may persist in the decode queue and
either break sync-sample dependencies or cause decoding artifacts.

Pull the code which removes samples from a track buffer into its own utility function, and
use this function both from removeCodedFrames(), and also when samples are removed due to
overlapping appends in sourceBufferPrivateDidReceiveSample(). In order to reference
TrackBuffers outside of SourceBuffer (and in the static removeSamplesFromTrackBuffer()
function), make TrackBuffer a public forward declaration.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBuffer::removeCodedFrames):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

  • Modules/mediasource/SourceBuffer.h:
7:44 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
6:10 AM Changeset in webkit [172583] by Carlos Garcia Campos
  • 3 edits in trunk

[GTK] REGRESSION(r171598, CMake): Introspection files are installed at the wrong path
https://bugs.webkit.org/show_bug.cgi?id=135934

Reviewed by Gustavo Noronha Silva.

Since r171598 gir files are installed under $datadir/webkitgtk-4.0/gir-1.0/.
The gir files should installed in $datadir/gir-1.0/ together with all other
gir files. We don't need to install introspection files in a versioned
directory because their filenames already contain the binary version. But before
r171598, the files were only installed to the right directory if the
gobject-instrospection pkg-config file was in the same prefix than the one we
wanted to install, because the gir and typelibs directories were extracted from
the pkg-config file. We should define INTROSPECTION_INSTALL_GIRDIR and
INTROSPECTION_INSTALL_TYPELIBDIR in OptionsGTK.cmake based on $datadir and $libdir
like we do in the autotools build.

  • Source/cmake/FindGObjectIntrospection.cmake: Do not define

INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.

  • Source/cmake/OptionsGTK.cmake: Define

INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.

4:13 AM Changeset in webkit [172582] by mihnea@adobe.com
  • 1 edit
    8 moves
    1 add in trunk/LayoutTests

[CSSRegions] Move svg tests into fast/regions/svg
https://bugs.webkit.org/show_bug.cgi?id=135883

Reviewed by Andrei Bucur.

Move tests and adjust paths accordingly.

  • fast/regions/svg/svg-doc-fragment-not-collected-expected.html: Renamed from LayoutTests/fast/regions/svg-doc-fragment-not-collected-expected.html.
  • fast/regions/svg/svg-doc-fragment-not-collected.html: Renamed from LayoutTests/fast/regions/svg-doc-fragment-not-collected.html.
  • fast/regions/svg/svg-element-not-collected-expected.html: Renamed from LayoutTests/fast/regions/svg-element-not-collected-expected.html.
  • fast/regions/svg/svg-element-not-collected.html: Renamed from LayoutTests/fast/regions/svg-element-not-collected.html.
  • fast/regions/svg/svg-root-element-collected-expected.txt: Renamed from LayoutTests/fast/regions/svg-root-element-collected-expected.txt.
  • fast/regions/svg/svg-root-element-collected.html: Renamed from LayoutTests/fast/regions/svg-root-element-collected.html.
  • fast/regions/svg/symbol-in-named-flow-crash-expected.txt: Renamed from LayoutTests/fast/regions/symbol-in-named-flow-crash-expected.txt.
  • fast/regions/svg/symbol-in-named-flow-crash.svg: Renamed from LayoutTests/fast/regions/symbol-in-named-flow-crash.svg.
3:31 AM Changeset in webkit [172581] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] WebKit DOM documentation (webkitdomgtk) not installed after make install
https://bugs.webkit.org/show_bug.cgi?id=135836

Reviewed by Philippe Normand.

  • Source/PlatformGTK.cmake: Add install command to also install

the GObject DOM bindings API docs.

2:35 AM Changeset in webkit [172580] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

ImageBufferDataCairo.h is missing header guards
https://bugs.webkit.org/show_bug.cgi?id=135933

Reviewed by Philippe Normand.

  • platform/graphics/cairo/ImageBufferDataCairo.h:

Add the missing head guards to avoid problems when re-inclusion occurs.

2:33 AM Changeset in webkit [172579] by zandobersek@gmail.com
  • 2 edits in trunk

Unreviewed. In r165709 I mistakenly appended the -fno-exceptions
and -fno-strict-aliasing compiler flags to CMAKE_CXX_FLAGS and then
re-set CMAKE_C_FLAGS with the new string. The two flags should really
be appended to CMAKE_C_FLAGS and the same variable re-set with the
new string.

  • Source/cmake/OptionsCommon.cmake:
1:49 AM Changeset in webkit [172578] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix JSC::ARM64Assembler::LinkRecord::RealTypes
https://bugs.webkit.org/show_bug.cgi?id=135906

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-08-14
Reviewed by Michael Saboff.

JSC::ARM64Assembler::LinkRecord::RealTypes::m_compareRegister is defined
to occupy 5 bits but JSC::ARM64Assembler::RegisterID needs 6 bits. So,
increase the size of the bit field and also reorganize the struct to
better align with word boundaries.

  • assembler/ARM64Assembler.h:

Aug 13, 2014:

10:09 PM Changeset in webkit [172577] by dbates@webkit.org
  • 2 edits in trunk/Source/bmalloc

Attempt to fix the build following <http://trac.webkit.org/changeset/172576>
(https://bugs.webkit.org/show_bug.cgi?id=135895)

Substitute PerThreadStorage<T>::initSharedKeyIfNeeded() for initSharedKeyIfNeeded() in
implementation of PerThread<T>::getFastCase().

  • bmalloc/PerThread.h:

(bmalloc::PerThread<T>::getFastCase):

10:00 PM Changeset in webkit [172576] by dbates@webkit.org
  • 3 edits in trunk/Source/bmalloc

Make bmalloc::PerThread work without C++ thread local storage
https://bugs.webkit.org/show_bug.cgi?id=135895

Reviewed by Geoffrey Garen.

Implement support for building bmalloc without C++ thread local storage.

  • bmalloc/BPlatform.h: Remove macro define BPLATFORM_IOS_SIMULATOR. Added macro function

BCOMPILER_SUPPORTS() and macro define BCOMPILER_SUPPORTS_CXX_THREAD_LOCAL that can be used
to determine whether the compiler supports C++ thread local storage.

  • bmalloc/PerThread.h:

(bmalloc::PerThreadStorage::get): Modified to call pthread_getspecific() when building
without C++ thread local storage.
(bmalloc::PerThreadStorage::initSharedKeyIfNeeded): Added.
(bmalloc::PerThreadStorage::init): Moved logic to initialize shared Pthread key from here to
PerThreadStorage::initSharedKeyIfNeeded().
(bmalloc::PerThread<T>::getFastCase): Modified to call PerThreadStorage::initSharedKeyIfNeeded()
before querying PerThreadStorage::get() when building without C++ thread local storage so as to
ensure that the shared key has been initialized.
(_pthread_setspecific_direct): Deleted.
(_pthread_getspecific_direct): Deleted.

9:25 PM Changeset in webkit [172575] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172546. <rdar://problem/17998929>

9:23 PM Changeset in webkit [172574] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172539. <rdar://problem/17998706>

9:21 PM Changeset in webkit [172573] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172538. <rdar://problem/17665229>

9:18 PM Changeset in webkit [172572] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-600.1-branch

Merged r172534. <rdar://problem/17942035>

9:16 PM Changeset in webkit [172571] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172533. <rdar://problem/18009039>

9:15 PM Changeset in webkit [172570] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172531. <rdar://problem/18008775>

9:13 PM Changeset in webkit [172569] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172530. <rdar://problem/18008584>

9:11 PM Changeset in webkit [172568] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172528. <rdar://problem/17982341>

9:10 PM Changeset in webkit [172567] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172527. <rdar://problem/17999511>

9:07 PM Changeset in webkit [172566] by Lucas Forschler
  • 9 edits in branches/safari-600.1-branch/Source

Merged r172526. <rdar://problem/18005074>

9:05 PM Changeset in webkit [172565] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172525. <rdar://problem/17997324>

9:03 PM Changeset in webkit [172564] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172515. <rdar://problem/17997717>

9:01 PM Changeset in webkit [172563] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172512. <rdar://problem/17982275>

8:59 PM Changeset in webkit [172562] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172507. <rdar://problem/17979262>

8:57 PM Changeset in webkit [172561] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch/Source

Merged r172501. <rdar://problem/17992795>

8:55 PM Changeset in webkit [172560] by Lucas Forschler
  • 12 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172500. <rdar://problem/17986556>

8:53 PM Changeset in webkit [172559] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172498. <rdar://problem/17996339>

8:49 PM Changeset in webkit [172558] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172497. <rdar://problem/17994679>

8:47 PM Changeset in webkit [172557] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172488. <rdar://problem/17994473>

8:45 PM Changeset in webkit [172556] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172484. <rdar://problem/17582099>

8:43 PM Changeset in webkit [172555] by Lucas Forschler
  • 7 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172483. r<rdar://problem/17935736>

8:41 PM Changeset in webkit [172554] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172395. <rdar://problem/17837670>

8:38 PM Changeset in webkit [172553] by Lucas Forschler
  • 9 edits in branches/safari-600.1-branch/Source

Merged r172383. <rdar://problem/17971057>

8:19 PM Changeset in webkit [172552] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172382. <rdar://problem/17935736>

8:12 PM Changeset in webkit [172551] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI/UserInterface/Views

Merge patch for <rdar://problem/17999231>.

7:53 PM Changeset in webkit [172550] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add ARM64 support to CMake-based builds
https://bugs.webkit.org/show_bug.cgi?id=135912

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-08-13
Reviewed by Gyuyoung Kim.

This patch ensures that CMake does not fail with Unknown CPU error when
building for ARM64.

  • CMakeLists.txt:
7:52 PM Changeset in webkit [172549] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[EFL] Bump up and patch dependencies to allow building for aarch64
https://bugs.webkit.org/show_bug.cgi?id=135885

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-08-13
Reviewed by Gyuyoung Kim.

The currently used versions of pixman, libffi, glib, glib-networking,
and fontconfig fail to configure for aarch64, so they are bumped up to
the latest stable version.

Gstreamer-plugins-base configures for aarch64 but incorrectly recogizes
ARM NEON assembly support, so it is patched with a change that has been
accepted by upstream.

  • efl/jhbuild.modules:
  • efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Added.
6:22 PM Changeset in webkit [172548] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Enable CSS_SCROLL_SNAP for iOS
https://bugs.webkit.org/show_bug.cgi?id=135915

Turn on CSS_SCROLL_SNAP for iOS and the iOS simulator.

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-13
Reviewed by Tim Horton.

  • Configurations/FeatureDefines.xcconfig:
6:13 PM Changeset in webkit [172547] by jonowells@apple.com
  • 1 edit
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: eslint configuration should be stored as .eslintrc
https://bugs.webkit.org/show_bug.cgi?id=135916

.eslintrc file added to allow for ESLint solutions, within editors and otherwise,
to be automatically configured based on the WebKit JavaScript coding style. The
initial file is incomplete.

Reviewed by Joseph Pecoraro.

  • .eslintrc: Added.
  • External/.eslintrc: Added.
5:39 PM Changeset in webkit [172546] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[Services with UI] Use a longer delay duration for editable content.
https://bugs.webkit.org/show_bug.cgi?id=135918
<rdar://problem/17998929>

Reviewed by Tim Horton.

Use a 1 second delay for selections in editable content.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):

5:23 PM Changeset in webkit [172545] by Simon Fraser
  • 2 edits
    1 add in trunk/LayoutTests

Land correct results for compositing/fixed-image-loading.html on WK1 and WK2.

  • compositing/fixed-image-loading-expected.txt:
  • platform/mac-wk2/compositing/fixed-image-loading-expected.txt: Added.
5:23 PM Changeset in webkit [172544] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Missing semicolon after console.assert in TimelineSidebarPanel.js
https://bugs.webkit.org/show_bug.cgi?id=135917

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TimelineSidebarPanel.js:
5:16 PM Changeset in webkit [172543] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebCore

Compute and store snap point positions
https://bugs.webkit.org/show_bug.cgi?id=135268

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-13
Reviewed by Simon Fraser.

Working towards implementing a way to extract snap positions (i.e. LayoutUnits) from the parsed snap point properties from CSS,
as well as a way of storing the information. Supports both mainframe and overflow scrolling.

No changes in behavior. I will write tests when I implement snapping for iOS and Mac.

  • WebCore.xcodeproj/project.pbxproj:
  • page/FrameView.cpp:

(WebCore::FrameView::updateSnapOffsets): Invokes the static routine in AxisScrollSnapOffsets to update snap offsets for mainframe.

  • page/FrameView.h:
  • page/scrolling/AxisScrollSnapOffsets.cpp: Added.

(WebCore::appendAndSortChildSnapOffsets):
(WebCore::updateFromStyle):
(WebCore::updateSnapOffsetsForScrollableArea): Update the ScrollableArea's snap axes.

  • page/scrolling/AxisScrollSnapOffsets.h: Added.
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::setHorizontalSnapOffsets):
(WebCore::ScrollableArea::setVerticalSnapOffsets):
(WebCore::ScrollableArea::clearHorizontalSnapOffsets): Resets the unique_ptr for horizontal snap points.
(WebCore::ScrollableArea::clearVerticalSnapOffsets): Resets the unique_ptr for vertical snap points.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::horizontalSnapOffsets): Returns a pointer to the ScrollableArea's horizontal snap points.
(WebCore::ScrollableArea::verticalSnapOffsets): Returns a pointer to the ScrollableArea's vertical snap points.
(WebCore::ScrollableArea::updateSnapOffsets):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateSnapOffsets): Invokes the static routine in AxisScrollSnapOffsets to update snap offsets for an overflow area.

  • rendering/RenderLayer.h:
4:55 PM Changeset in webkit [172542] by mrowe@apple.com
  • 9 edits in trunk

<https://webkit.org/b/135911> WebKit should build on Yosemite with the public SDK.

Reviewed by Darin Adler.

Source/WebCore:

  • rendering/RenderThemeMac.mm: Fix the forward-declaration of NSServicesRolloverButtonCell.

Source/WebKit/mac:

  • Misc/WebSharingServicePickerController.mm: Forward-declare some details related to NSSharingServicePicker.

Source/WebKit2:

  • Platform/IPC/mac/ImportanceAssertion.h: Forward-declare the new assertion functions we use.
  • UIProcess/mac/WebContextMenuProxyMac.mm: Forward-declare some details related to NSSharingServicePicker.

Tools:

  • DumpRenderTree/mac/TextInputController.m: Don't use extern "C" in a non-C++ file.
4:35 PM Changeset in webkit [172541] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):

3:53 PM Changeset in webkit [172540] by achristensen@apple.com
  • 17 edits in trunk

Progress towards CMake on Mac.
https://bugs.webkit.org/show_bug.cgi?id=135819

Reviewed by Laszlo Gombos.

.:

  • Source/cmake/OptionsMac.cmake:

Disable some more features temporarily to get CMake working.

  • Source/cmake/WebKitMacros.cmake:

Added an extension parameter to GENERATE_BINDINGS to allow ObjC bindings to generate .mm files.

Source/JavaScriptCore:

  • CMakeLists.txt:

Add the remote inspector headers to the forwarding headers list.

Source/WebCore:

  • CMakeLists.txt:

Include derived sources directory, which is needed by Apple ports.
Separated svg and non-svg idls for ObjC bindings.
Don't build the new gamepad API right now. It's causing naming conflicts and it's not done.
Process CSSUnknownRule.idl.

  • PlatformGTK.cmake:

Added cpp as the extension of the generated bindings.

  • PlatformMac.cmake:

Include more directories and sources.
Add forwarding headers.
Generate ObjC bindings.

  • bindings/objc/DOMUIKitExtensions.mm:

Moved config.h to recognize the PLATFORM macro.

  • bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces):
(GenerateInterface):
Added some workarounds for CMake.

  • bindings/scripts/IDLAttributes.txt:

Added missing attribute names.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

Added PLATFORM(IOS) to protect IOS_AIRPLAY code.

  • platform/mac/PasteboardMac.mm:

Added necessary DRAG_SUPPORT protection.

  • platform/text/mac/TextCodecMac.cpp:

Moved config.h to recognize the PLATFORM macro.

Tools:

  • WebKitTestRunner/CMakeLists.txt:

Added new cpp parameter for the extension of the generated files.

3:30 PM Changeset in webkit [172539] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Opening Web Inspector causes a large amount of sandbox violations
https://bugs.webkit.org/show_bug.cgi?id=135908

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

  • WebProcess/com.apple.WebProcess.sb.in:

Permit the WebContent process to create file read extensions for the
system WebInspectorUI.framework which the Network process can already
read anyways.

3:15 PM Changeset in webkit [172538] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE] Replacing existing samples with overlapping new samples will cause playback to stutter.
https://bugs.webkit.org/show_bug.cgi?id=135902

Reviewed by Eric Carlson.

Only mark the TrackBuffer as needing re-enqueueing if the samples removed by overlapping samples
themselves overlap with potentially enqueued but not yet displayed frames.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

2:39 PM Changeset in webkit [172537] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix the test result for MountainLion and Mavericks, which don't composite fixed position.

  • compositing/fixed-image-loading-expected.txt:
2:06 PM Changeset in webkit [172536] by akling@apple.com
  • 20 edits in trunk/Source/WebCore

CSSValueList should never contain null values.
<https://webkit.org/b/135887>

It's not legal for a CSSValueList to contain null CSSValues, so make
it store a Vector of Ref<CSSValue> internally instead.

This allows the compiler to avoid emitting a number of null checks.
It will also allow a future patch to make CSSValueList vend CSSValue&
instead of CSSValue*.

Most of the patch is fixing up things on their way into a CSSValueList
to not be null at the call site, now that append() and prepend() are
taking PassRef instead of PassRefPtr.

Reviewed by Sam Weinig.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):

  • css/BasicShapeFunctions.h:
  • css/CSSBorderImage.cpp:

(WebCore::createBorderImageValue):

  • css/CSSBorderImage.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForImageSliceSide):
(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):
(WebCore::valueForNinePieceImage):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::ComputedStyleExtractor::valueForFilter):
(WebCore::specifiedValueForGridTrackSize):
(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::scrollSnapCoordinates):
(WebCore::createTimingFunctionValue):
(WebCore::fillSourceTypeToCSSValue):
(WebCore::contentToCSSValue):
(WebCore::shapePropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForShorthandProperties):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForSidesShorthand):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForGridShorthand):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSParser.cpp:

(WebCore::createPrimitiveValuePair):
(WebCore::parseTranslateTransformValue):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::createPrimitiveStringValue):
(WebCore::CSSParser::addFillValue):
(WebCore::CSSParser::parseNonElementSnapPoints):
(WebCore::CSSParser::parseScrollSnapDestination):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::addAnimationValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseQuotes):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseAnimationProperty):
(WebCore::CSSParser::parseGridPosition):
(WebCore::CSSParser::parseGridTemplateRowsAndAreas):
(WebCore::CSSParser::parseGridLineNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):
(WebCore::CSSParser::parseBasicShapeAndOrBox):
(WebCore::CSSParser::parseFontVariant):
(WebCore::CSSParser::parseTransform):
(WebCore::CSSParser::parseBuiltinFilterArguments):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::parseTextEmphasisStyle):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::wrapValueInCommaSeparatedList):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::CSSValueList):
(WebCore::CSSValueList::removeAll):
(WebCore::CSSValueList::hasValue):
(WebCore::CSSValueList::copy):
(WebCore::CSSValueList::customCSSText):
(WebCore::CSSValueList::equals):
(WebCore::CSSValueList::addSubresourceStyleURLs):
(WebCore::CSSValueList::hasFailedOrCanceledSubresources):

  • css/CSSValueList.h:

(WebCore::CSSValueList::item):
(WebCore::CSSValueList::itemWithoutBoundsCheck):
(WebCore::CSSValueList::append):
(WebCore::CSSValueList::prepend):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::paintOrder):

  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parsePaintOrder):

  • editing/EditingStyle.cpp:

(WebCore::mergeTextDecorationValues):

  • editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::srcValue):

  • svg/SVGLength.cpp:

(WebCore::SVGLength::toCSSPrimitiveValue):

  • svg/SVGLength.h:
1:31 PM Changeset in webkit [172535] by achristensen@apple.com
  • 1 edit
    2 deletes in trunk/Source/WebCore

Removed dead plugins code.
https://bugs.webkit.org/show_bug.cgi?id=135862

Reviewed by Alexey Proskuryakov.

  • plugins/PluginDataNone.cpp: Removed.
  • plugins/mac: Removed.
  • plugins/mac/PluginPackageMac.cpp: Removed.
  • plugins/mac/PluginViewMac.mm: Removed.
1:21 PM Changeset in webkit [172534] by Simon Fraser
  • 3 edits
    2 adds in trunk

[WK1] A fixed-position <img> may not show on page load
https://bugs.webkit.org/show_bug.cgi?id=135893

Reviewed by Tim Horton.

Source/WebCore:

A position:fixed image could fail to display because we didn't make a
compositing layer for it under some circumstances. This can happen if
RenderLayerCompositor::requiresCompositingForPosition() runs before the
image is loaded, in which cause the layer is zero-sized, so does not get
composited.

When the image loads, there was no code path that ensured that compositing
would be re-evaluated (unlike size changes due to style updates). Fix by
having RenderLayer::contentChanged() also check for ImageChanged.

Test: compositing/fixed-image-loading.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::contentChanged):

LayoutTests:

Test with a position:fixed image. Note that the test has to force layout
early on to test the bug.

  • compositing/fixed-image-loading-expected.txt: Added.
  • compositing/fixed-image-loading.html: Added.
1:14 PM Changeset in webkit [172533] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Inline DataGrid inside details sidebar has double thick top border with legacy styles
https://bugs.webkit.org/show_bug.cgi?id=135894

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

  • UserInterface/Views/DetailsSection.css:

(body.mac-platform.legacy .details-section:not(.collapsed) .data-grid.inline):
In legacy styles the details-section header always has a 1px bottom border.
In all styles, an inline data grid had a 1px border everywhere. So, handle
this specific case by removing the top border of an inline data grid
that is inside an expanded details section.

12:43 PM Changeset in webkit [172532] by dbates@webkit.org
  • 8 edits in trunk/Source

[iOS] Make JavaScriptCore and bmalloc build with the public SDK
https://bugs.webkit.org/show_bug.cgi?id=135848

Reviewed by Geoffrey Garen.

Source/bmalloc:

  • bmalloc/BPlatform.h: Added macro BPLATFORM_IOS_SIMULATOR, which evaluates to true

when building for the iOS Simulator.

  • bmalloc/PerThread.h: Use pthread_machdep.h code path when building for iOS Simulator

using the public SDK.
(_pthread_setspecific_direct): Added; only defined when building for the iOS Simulator
using the public SDK.
(_pthread_getspecific_direct): Added; only defined when building for the iOS Simulator
using the public SDK.

Source/JavaScriptCore:

  • API/JSBase.h: Declare NSMap functions with external linkage when building for iOS without the

header <Foundation/NSMapTablePriv.h>.

  • inspector/remote/RemoteInspector.mm: Define XPC functions with external linkage when building

without the system header <xpc/xpc.h>.

  • inspector/remote/RemoteInspectorXPCConnection.h: Define xpc_connection_t and xpc_object_t when building

without the system header <xpc/xpc.h>.

  • inspector/remote/RemoteInspectorXPCConnection.mm: Declare XPC functions with external linkage when

building without without the system header <xpc/xpc.h>.
(Inspector::RemoteInspectorXPCConnection::closeOnQueue): Fix code style; use nullptr instead of NULL.
(Inspector::RemoteInspectorXPCConnection::sendMessage): Ditto.

12:25 PM Changeset in webkit [172531] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "No Filter Results" view only shows once, does not show again
https://bugs.webkit.org/show_bug.cgi?id=135892

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
We were checking at the wrong level for a parent. Check if the root
placeholder element has a parent or not.

12:12 PM Changeset in webkit [172530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Incorrect border colors in event listeners sections in details sidebar
https://bugs.webkit.org/show_bug.cgi?id=135891

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

  • UserInterface/Views/DetailsSection.css:

(.details-section .details-section > .header):
(.details-section .details-section:not(.collapsed) > .header):
Remove box-shadow and replace with a bottom border.

(body.mac-platform.legacy .details-section .details-section.collapsed > .header):
(.details-section .details-section.collaspsed > .header): Deleted.
Collapsed was spelled incorrectly so this was not applying properly before.
But correct this for legacy because legacy still uses a box-shadow.

12:05 PM Changeset in webkit [172529] by Bem Jones-Bey
  • 5 edits in trunk/Source/WebCore

Refactor ShapeOutsideInfo so it isn't mutated for each line
https://bugs.webkit.org/show_bug.cgi?id=135781

Reviewed by Zoltan Horvath.

Encapsulate the per line state into a ShapeOutsideDeltas object.
updateDeltasForContainingBlockLine has been renamed to
computeDeltasForContainingBlockLine, and it returns an instance of the
ShapeOutsideDeltas object for that line. This object is cached, but
none of the functionality of ShapeOutsideInfo is dependant on any line
specific data anymore.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):

Update to take a FloatingObject reference because the FloatingObject cannot be null.

(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

Ditto.

(WebCore::ComputeFloatOffsetAdapter<FloatTypeValue>::collectIfNeeded): Pass FloatingObject to

updateOffsetIfNeeded as a reference, since it cannot be null.

(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):

Use ShapeOutsideDeltas object to calculate the offset and take the FloatingObject as a
reference.

(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

Ditto.

(WebCore::shapeInfoForFloat): Deleted.

  • rendering/line/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Update to use ShapeOutsideDeltas object.

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computeDeltasForContainingBlockLine): Return a ShaoeOutsideDeltas object

instead of storing line specific data in instance variables.

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine): Deleted.

  • rendering/shapes/ShapeOutsideInfo.h:
12:03 PM Changeset in webkit [172528] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Avoid making new active service overlay highlights while the mouse is down
https://bugs.webkit.org/show_bug.cgi?id=135872
<rdar://problem/17982341>

Reviewed by Enrica Casucci.

  • WebProcess/WebPage/ServicesOverlayController.h:
  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
(WebKit::ServicesOverlayController::mouseEvent):
If the mouse is pressed or it's been less than 200ms since the mouse went up,
don't allow the highlight to change. We apply the mouse-is-pressed rule to telephone
number highlights as well, unlike the rest of the hysteresis logic.

12:00 PM Changeset in webkit [172527] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline Close buttons can use polish for new and legacy styles
https://bugs.webkit.org/show_bug.cgi?id=135870

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-13
Reviewed by Timothy Hatcher.

  • UserInterface/Images/Legacy/Close.svg:

Ensure this has fill colors in tree selections.

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .timelines-content .close-button):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
Size the close-button for the top overviews differently in new styles (14x14) and legacy (12x12).

11:58 AM Changeset in webkit [172526] by timothy@apple.com
  • 9 edits in trunk/Source

Web Inspector: Workaround a NSWindow change to the title bar.
https://bugs.webkit.org/show_bug.cgi?id=135880

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector._updateToolbarHeight): Don't call in legacy mode.

  • UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
(.toolbar .dashboard):
Drive-by fix some errant drop-shadows. The transparent border was pushing the inset top
drop shadow down when it shouldn't. Remove duplicate background and shadow.

  • UserInterface/Views/Main.css:

(body): Set the background white, never needs to be transparent now.
(body.mac-platform.legacy:not(.docked)): Set background to transparent when not docked in legacy.
(body.docked.bottom): Update border color.
(body.docked.right): Ditto.
(body.docked.bottom.mac-platform.legacy): Keep old border color.
(body.docked.right.mac-platform.legacy): Ditto.

  • UserInterface/Views/Toolbar.css:

(.toolbar): Set a default border and background gradient.
(body.window-inactive .toolbar): No gradient but use a solid color when inactive.
(body.mac-platform:not(.legacy):not(.docked) .toolbar): Padding on the top for the title bar.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical): Account for title bar height.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-and-label-vertical.small-size): Ditto.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.icon-only): Ditto.
(body.mac-platform:not(.legacy):not(.docked) .toolbar.label-only): Ditto.
(body.mac-platform.legacy .toolbar): No inset shadow in legacy when not docked.
(body.mac-platform.legacy.docked .toolbar): Restore legacy border color.
(body.mac-platform.legacy:not(.docked) .toolbar .item.button > .label): Only disable sub-pixel antialiasing on legacy!
(body.mac-platform.legacy.window-inactive .toolbar): Restore legacy border color.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::setToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.
(-[WebInspectorWindowController init]): Only call setDrawsBackground: on 10.9 and earlier.
(-[WebInspectorWindowController window]): Set titlebarAppearsTransparent on 10.10.
Only call border thickness APIs on 10.9 and earlier.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Set titlebarAppearsTransparent on 10.10.
Only call border thickness APIs on 10.9 and earlier.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Only call setDrawsBackground: on 10.9 and earlier.
(WebKit::WebInspectorProxy::platformSetToolbarHeight): Only call setContentBorderThickness: on 10.9 and earlier.

11:51 AM Changeset in webkit [172525] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Restore Helvetica as the dashboard font in legacy mode
https://bugs.webkit.org/show_bug.cgi?id=135886

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DefaultDashboardView.css:

(body.mac-platform.legacy .toolbar .dashboard.default > .item):

11:00 AM Changeset in webkit [172524] by zoltan@webkit.org
  • 4 edits
    2 adds in trunk

[CSS3-Text] Add rendering support for the none value of text-justify property
https://bugs.webkit.org/show_bug.cgi?id=135349

Reviewed by David Hyatt.

Source/WebCore:

Spec: http://dev.w3.org/csswg/css-text-3/#valdef-text-justify.none

Test: fast/css3-text/css3-text-justify/text-justify-none.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

LayoutTests:

  • fast/css3-text/css3-text-justify/text-justify-none-expected.html: Added.
  • fast/css3-text/css3-text-justify/text-justify-none.html: Added.
  • platform/mac/TestExpectations:
10:24 AM Changeset in webkit [172523] by eric.carlson@apple.com
  • 6 edits
    2 adds in trunk

Media document sends incorrect referer header
https://bugs.webkit.org/show_bug.cgi?id=135839

Reviewed by Jer Noble.

Source/WebCore:

Test: http/tests/media/media-document-referer.html

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::MediaDocumentParser): Stash referrer.
(WebCore::MediaDocumentParser::createDocumentStructure): Set outgoing referrer.
(WebCore::MediaDocument::MediaDocument): Stash referrer.

  • html/MediaDocument.h:

LayoutTests:

  • http/tests/media/media-document-referer-expected.txt: Added.
  • http/tests/media/media-document-referer.html: Added.
  • http/tests/media/resources/video-referer-check-referer.php: Take expected referer as a

parameter instead of hard coding it.

  • http/tests/media/video-referer.html: Pass referer to loader script.
8:45 AM Changeset in webkit [172522] by mihnea@adobe.com
  • 2 edits
    50 moves
    1 add in trunk/LayoutTests

[CSSRegions] Move scrolling tests under fast/regions/scrolling
https://bugs.webkit.org/show_bug.cgi?id=135881

Reviewed by Andrei Bucur.

  • fast/regions/scrolling/scroll-into-view-expected.html: Renamed from LayoutTests/fast/regions/scroll-into-view-expected.html.
  • fast/regions/scrolling/scroll-into-view-relative-expected.html: Renamed from LayoutTests/fast/regions/scroll-into-view-relative-expected.html.
  • fast/regions/scrolling/scroll-into-view-relative.html: Renamed from LayoutTests/fast/regions/scroll-into-view-relative.html.
  • fast/regions/scrolling/scroll-into-view.html: Renamed from LayoutTests/fast/regions/scroll-into-view.html.
  • fast/regions/scrolling/scrollable-first-region-expected.html: Renamed from LayoutTests/fast/regions/scrollable-first-region-expected.html.
  • fast/regions/scrolling/scrollable-first-region.html: Renamed from LayoutTests/fast/regions/scrollable-first-region.html.
  • fast/regions/scrolling/scrollable-last-region-expected.html: Renamed from LayoutTests/fast/regions/scrollable-last-region-expected.html.
  • fast/regions/scrolling/scrollable-last-region.html: Renamed from LayoutTests/fast/regions/scrollable-last-region.html.
  • fast/regions/scrolling/scrollable-paragraph-unsplittable-expected.html: Renamed from LayoutTests/fast/regions/scrollable-paragraph-unsplittable-expected.html.
  • fast/regions/scrolling/scrollable-paragraph-unsplittable.html: Renamed from LayoutTests/fast/regions/scrollable-paragraph-unsplittable.html.
  • fast/regions/scrolling/scrollable-region-content-size-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-horiz-bt-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-horiz-bt-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-horiz-bt.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-horiz-bt.html.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-horiz-bt-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-horiz-bt-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-horiz-bt.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-horiz-bt.html.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-vert-rl-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-vert-rl-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-vert-rl.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow-vert-rl.html.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-no-overflow.html.
  • fast/regions/scrolling/scrollable-region-content-size-relative-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-relative-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-relative.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-relative.html.
  • fast/regions/scrolling/scrollable-region-content-size-vert-rl-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vert-rl-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-vert-rl.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vert-rl.html.
  • fast/regions/scrolling/scrollable-region-content-size-vertical-lr-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vertical-lr-expected.html.
  • fast/regions/scrolling/scrollable-region-content-size-vertical-lr.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size-vertical-lr.html.
  • fast/regions/scrolling/scrollable-region-content-size.html: Renamed from LayoutTests/fast/regions/scrollable-region-content-size.html.
  • fast/regions/scrolling/scrollable-region-scrollable-absolute-content-background-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background-expected.html.
  • fast/regions/scrolling/scrollable-region-scrollable-absolute-content-background.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-absolute-content-background.html.
  • fast/regions/scrolling/scrollable-region-scrollable-content-background-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content-background-expected.html.
  • fast/regions/scrolling/scrollable-region-scrollable-content-background.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content-background.html.
  • fast/regions/scrolling/scrollable-region-scrollable-content-expected.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content-expected.html.
  • fast/regions/scrolling/scrollable-region-scrollable-content.html: Renamed from LayoutTests/fast/regions/scrollable-region-scrollable-content.html.
  • fast/regions/scrolling/scrollable-regions-hit-testing-inside-expected.html: Renamed from LayoutTests/fast/regions/scrollable-regions-hit-testing-inside-expected.html.
  • fast/regions/scrolling/scrollable-regions-hit-testing-inside.html: Renamed from LayoutTests/fast/regions/scrollable-regions-hit-testing-inside.html.
  • fast/regions/scrolling/scrollable-single-region-bt-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-bt-expected.html.
  • fast/regions/scrolling/scrollable-single-region-bt.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-bt.html.
  • fast/regions/scrolling/scrollable-single-region-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-expected.html.
  • fast/regions/scrolling/scrollable-single-region-lr-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-lr-expected.html.
  • fast/regions/scrolling/scrollable-single-region-lr.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-lr.html.
  • fast/regions/scrolling/scrollable-single-region-relative-element-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-relative-element-expected.html.
  • fast/regions/scrolling/scrollable-single-region-relative-element.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-relative-element.html.
  • fast/regions/scrolling/scrollable-single-region-rl-expected.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-rl-expected.html.
  • fast/regions/scrolling/scrollable-single-region-rl.html: Renamed from LayoutTests/fast/regions/scrollable-single-region-rl.html.
  • fast/regions/scrolling/scrollable-single-region.html: Renamed from LayoutTests/fast/regions/scrollable-single-region.html.
  • fast/regions/scrolling/wheel-scroll-abspos-expected.html: Renamed from LayoutTests/fast/regions/wheel-scroll-abspos-expected.html.
  • fast/regions/scrolling/wheel-scroll-abspos.html: Renamed from LayoutTests/fast/regions/wheel-scroll-abspos.html.
  • fast/regions/scrolling/wheel-scroll-expected.html: Renamed from LayoutTests/fast/regions/wheel-scroll-expected.html.
  • fast/regions/scrolling/wheel-scroll.html: Renamed from LayoutTests/fast/regions/wheel-scroll.html.
  • fast/regions/scrolling/wheel-scrollable-single-region-expected.html: Renamed from LayoutTests/fast/regions/wheel-scrollable-single-region-expected.html.
  • fast/regions/scrolling/wheel-scrollable-single-region.html: Renamed from LayoutTests/fast/regions/wheel-scrollable-single-region.html.
  • platform/gtk/TestExpectations: Fix path for previously moved tests.
7:31 AM Changeset in webkit [172521] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

Make check-webkit-style run sort-export-file
https://bugs.webkit.org/show_bug.cgi?id=135877

Patch by Renato Nagy <nagy.renato@stud.u-szeged.hu> on 2014-08-13
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/style/checker.py:

(_all_categories):
(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checkers/exportfile.py: Added.

(ExportFileChecker):
(ExportFileChecker.init):
(ExportFileChecker.check):

  • Scripts/webkitpy/style/checkers/exportfile_unittest.py: Added.

(handle_style_error):
(MockErrorHandler):
(MockErrorHandler.init):
(MockErrorHandler.turn_off_line_filtering):
(MockErrorHandler.call):
(ExportFileTest):
(ExportFileTest.setUp):
(ExportFileTest.tearDown):
(ExportFileTest.test_sorted):
(ExportFileTest.test_non_sorted):
(ExportFileTest.test_parse_error):

6:12 AM Changeset in webkit [172520] by ryuan.choi@samsung.com
  • 7 edits in trunk/Source/WebKit2

[EFL] Add API to set application name for the user agent
https://bugs.webkit.org/show_bug.cgi?id=135640

Reviewed by Gyuyoung Kim.

Add ewk_application_name_for_user_agent_set to make default user agent string
with application name which application passes.
It's useful for application to set only application information without knowledge
of legacy user agent components.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::setApplicationNameForUserAgent):

  • UIProcess/API/efl/EwkView.h:

(EwkView::applicationNameForUserAgent):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_application_name_for_user_agent_set):
(ewk_view_application_name_for_user_agent_get):

  • UIProcess/API/efl/ewk_view.h:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::standardUserAgent):

5:10 AM Changeset in webkit [172519] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Tools

[EFL] Sets the persistent storage for cookies in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=135875

Reviewed by Gyuyoung Kim.

In case of EWK_COOKIE_ACCEPT_POLICY_ALWAYS, sets the persistent storage
for non-session cookies can be stored persistently.

  • MiniBrowser/efl/main.c:

(elm_main):

4:41 AM EFLWebKit edited by gyuyoung.kim@samsung.com
(diff)
4:38 AM EFLWebKitBuildBots edited by gyuyoung.kim@samsung.com
(diff)
4:36 AM EFLWebKitBuildBots edited by gyuyoung.kim@samsung.com
(diff)
4:20 AM Changeset in webkit [172518] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

Don't recurse into non-rendered subtrees when computing style
https://bugs.webkit.org/show_bug.cgi?id=135844

Reviewed by Andreas Kling.

Rebase.

  • http/tests/security/video-poster-cross-origin-crash-expected.txt:
  • platform/mac/fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt:
3:13 AM Changeset in webkit [172517] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Don't recurse into non-rendered subtrees when computing style
https://bugs.webkit.org/show_bug.cgi?id=135844

Reviewed by Andreas Kling.

  • style/StyleResolveTree.cpp:

(WebCore::Style::resetStyleForNonRenderedDescendants):

Do a simple reset of the style dirty bits and any computed style in non-renderer subtrees.

(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveTree):

Don't recurse into descendants if the element does not create a renderer.
We didn't compute style anyway in such subtrees.

Aug 12, 2014:

11:44 PM Changeset in webkit [172516] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[CMAKE] WebProcess shouldn't need to explicitly link to JavaScriptCore and WebCore
https://bugs.webkit.org/show_bug.cgi?id=135832

Reviewed by Gyuyoung Kim.

Linking to WebKit2 should be enough, like Network and Plugin processes.

  • CMakeLists.txt:
9:15 PM Changeset in webkit [172515] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline record content view close button does not work after scrolling, invisible scrollbar
https://bugs.webkit.org/show_bug.cgi?id=135863

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

A workaround is to not have position:relative content inside of
scrollable region. Turns out this was only done in two places,
and I do not see any absolutely positioned content in navigation
sidebar content tree outlines. This also fixes clicking on the
reload button if you've scrolled the Resources sidebar.

  • UserInterface/Views/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline .children): Deleted.
(.navigation-sidebar-panel-content-tree-outline .item): Deleted.

9:07 PM Changeset in webkit [172514] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused variable in Platform.js
https://bugs.webkit.org/show_bug.cgi?id=135869

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

  • UserInterface/Base/Platform.js:
8:53 PM Changeset in webkit [172513] by mmaxfield@apple.com
  • 7 edits
    2 adds in trunk

Elements whose contents start with an astral Unicode symbol disappear when CSS ::first-letter is applied to them
https://bugs.webkit.org/show_bug.cgi?id=135756

Reviewed by Darin Adler.

Source/WebCore:

The previous code assumed that all "characters" are exactly 1 16-bit code unit wide. Instead, use numCharactersInGraphemeClusters().

This patch also modifies the signature of numCharactersInGraphemeClusters() to take a StringView instead
of a string, which will avoid a copy.

Test: css1/pseudo/firstletter-surrogate.html

  • platform/text/TextBreakIterator.cpp:

(WebCore::numCharactersInGraphemeClusters): Update numCharactersInGraphemeClusters() to take a StringView.

  • platform/text/TextBreakIterator.h: Ditto.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::createFirstLetterRenderer): Use numCharactersInGraphemeClusters() to determine the length
of the first letter, rather than assuming it has length of 1 code unit
(WebCore::RenderBlock::updateFirstLetter): Add a FIXME comment.

Source/WTF:

Add a method to StringView which passes through contains() to find().

  • wtf/text/StringView.h:

(WTF::StringView::contains):

LayoutTests:

Make sure the pseudoclass matches manually wrapping a <span> around the character.

  • css1/pseudo/firstletter-surrogate-expected.html: Added.
  • css1/pseudo/firstletter-surrogate.html: Added.
8:02 PM Changeset in webkit [172512] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Document-relative page overlays drop some mouse events with non-zero top content inset
https://bugs.webkit.org/show_bug.cgi?id=135871
<rdar://problem/17982275>

Reviewed by Beth Dakin.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::mouseEvent):
Convert the mouse position into document-relative coordinates; the bounds()
already are! This way, we can actually compare them without being wrong sometimes.

7:35 PM Changeset in webkit [172511] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=135845

Reviewed by Andy Estes.

Towards building the iOS WebKit port using the public SDK, remove the logic
added to build-webkit to build projects WebKitSystemInterface and
WebKitAdditions when building the iOS WebKit port.

  • Scripts/build-webkit:
7:33 PM Changeset in webkit [172510] by dbates@webkit.org
  • 2 edits in trunk/Source/bmalloc

BPLATFORM(IOS) always evaluates to false
https://bugs.webkit.org/show_bug.cgi?id=135843

Reviewed by Geoffrey Garen.

Fix typo in definition of BPLATFORM() and include system header TargetConditionals.h
(when building on an Apple platform) so that BPLATFORM(X) evaluates to true when
building for platform X. In particular, so that BPLATFORM(IOS) evaluates to true when
building for iOS.

As a side effect of this change, the change made in <http://trac.webkit.org/changeset/167289>
will be honored and iOS will assume a VM page size of 16kB (again) instead of 4kB.

  • bmalloc/BPlatform.h:
5:13 PM Changeset in webkit [172509] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix after r172504

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing

symbol exports.

4:45 PM Changeset in webkit [172508] by psolanki@apple.com
  • 2 edits in trunk/Source/WTF

Enable didReceiveDataArray callback on Mac
https://bugs.webkit.org/show_bug.cgi?id=135554
<rdar://problem/9170731>

Reviewed by Andreas Kling.

Enable WTF_USE_NETWORK_CFDATA_ARRAY_CALLBACK for all Cocoa platforms so that we use the same
code path for Mac and iOS.

  • wtf/Platform.h:
4:40 PM Changeset in webkit [172507] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[MSE][Mac] Seeking to the very beginning of a buffered range stalls video playback
https://bugs.webkit.org/show_bug.cgi?id=135865

Reviewed by Eric Carlson.

AVSampleBufferRenderSynchronizer will report a current time of about 100ms or so before
the destination seek time when seeking. It does this in order to pre-roll the synchronized
audio renderer, but this can lead to playback stalling when MediaSource::monitorSourceBuffers()
looks at the media element's current time and determines that the current time is 100ms before
any buffered samples.

Clamp the value of currentMediaTime() to, at a minimum, the last requested seek time. This was
the suggested course of action from <rdar://problem/17789374>.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

4:37 PM Changeset in webkit [172506] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[MSE] YouTube will lose audio, video after seeking backwards to an unbuffered range.
https://bugs.webkit.org/show_bug.cgi?id=135855

Reviewed by Eric Carlson.

When seeking into an unbuffered or partially buffered range, we will unconditionally pass samples to the
decode queue even if there exist large gaps between those samples. Subsequently, the decoder will not
notify us that it has become ready for new samples until playback reaches those later samples and the samples
are discarded.

When sending samples to be decoded in provideMediaData(), stop if there exists a large gap in the sample timeline.
Do this by tracking the last enqueued decode end time, and look to see if the next sample's decode time indicates
a gap of greater than 1 second.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::TrackBuffer::TrackBuffer): Initialize lastEnqueuedDecodeEndTime.
(WebCore::SourceBuffer::seekToTime): Set needsReenqueueing, in case samples do not yet exist in the trackBuffer

sufficient to re-enqueue for the destination time, so that re-enqueueing will occur after the next append.

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Check against lastEnqueuedDecodeEndTime, rather than

lastEnqueuedPresentationTime before adding samples to the decodeQueue.

(WebCore::SourceBuffer::provideMediaData): Stop when we reach a large gap between samples.
(WebCore::SourceBuffer::reenqueueMediaForTime): Set or clear lastEnqueuedDecodeEndTime based on whether we

have appended any non-displaying samples after flushing.

4:15 PM Changeset in webkit [172505] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r172494.
https://bugs.webkit.org/show_bug.cgi?id=135864

asserting on bots (Requested by kling on #webkit).

Reverted changeset:

"Don't recurse into non-rendered subtrees when computing
style"
https://bugs.webkit.org/show_bug.cgi?id=135844
http://trac.webkit.org/changeset/172494

4:13 PM Changeset in webkit [172504] by mmaxfield@apple.com
  • 6 edits
    2 adds in trunk

Fonts forced to use non synthetic italics might be laid out with the incorrect baseline
https://bugs.webkit.org/show_bug.cgi?id=135403

Reviewed by Darin Adler.

Source/WebCore:

When italics is specified on a font, and the font isn't coming from the cache, we ask
the SimpleFontData to provide a non-synthetic-italic version of itself. Our current
implementation doesn't preserve whether or not the SimpleFontData includes vertical
glyphs (glyphs that are not rotated when drawn in the vertical writing mode), which
determines which baseline we use to lay out the text. By passing "false" to
the isTextOrientationFallback argument to SimpleFontData::create(), we preserve this
hasVerticalGlyphs flag.

Test: fast/text/international/synthesized-italic-vertical-latin-double.html

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData):

  • testing/Internals.cpp:

(WebCore::Internals::invalidateFontCache): Add "invalidateFontCache" to window.internals.

  • testing/Internals.h: Ditto.
  • testing/Internals.idl: Ditto.

LayoutTests:

Laying out the same string twice (where there is a cache collision) should be rendered
the same as laying out similar strings (where there is no cache collision).

  • fast/text/international/synthesized-italic-vertical-latin-double-expected.html: Added.
  • fast/text/international/synthesized-italic-vertical-latin-double.html: Added.
4:11 PM Changeset in webkit [172503] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Source/JavaScriptCore:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.
https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LONG_MOUSE_PRESS feature flag.

Source/WebCore:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.
https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

This patch adds a runtime switch for the Long Mouse Press Gesture and initially sets the feature flag
to false. It also removes the ENABLE_LONG_MOUSE_PRESS feature flag as the runtime switch now guards
its functionality.

  • Configurations/FeatureDefines.xcconfig: Remove LONG_MOUSE_PRESS feature flag.
  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::clear): Remove feature flag.
(WebCore::EventHandler::handleMousePressEvent): Ditto.
(WebCore::EventHandler::eventMayStartDrag): Ditto.
(WebCore::EventHandler::handleMouseReleaseEvent):
Perform event iff long mouse presses are enabled.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress): Ditto.
(WebCore::EventHandler::recognizeLongMousePress): Ditto.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress): Ditto.
(WebCore::EventHandler::handleMouseMoveEvent): Remove feature flag.
(WebCore::EventHandler::handleDrag): Ditto.
(WebCore::EventHandler::mouseMovementExceedsThreshold): Ditto.

  • page/EventHandler.h:
  • page/Settings.in: Add longMousePressEnabled setting, initially false.

Source/WebKit/mac:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture.
https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

  • Configurations/FeatureDefines.xcconfig:

Remove LONG_MOUSE_PRESS feature flag.

Source/WebKit2:
Runtime switch for long mouse press gesture. Part of 135257 - Add long mouse press gesture
https://bugs.webkit.org/show_bug.cgi?id=135682

Patch by Peyton Randolph <prandolph@apple.com> on 2014-08-12
Reviewed by Tim Horton.

  • Configurations/FeatureDefines.xcconfig: Remove LONG_MOUSE_PRESS feature flag.
  • Shared/WebPreferencesDefinitions.h:

Add LongMousePressEnabled preference, initially false.

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLongMousePressEnabled): Added.
(WKPreferencesGetLongMousePressEnabled): Added.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Reflect the WebKit long mouse press setting in WebCore.

3:50 PM Changeset in webkit [172502] by psolanki@apple.com
  • 6 edits in trunk/Source

Cached file backed resources don't make it to the Web Process when NETWORK_CFDATA_ARRAY_CALLBACK is enabled
https://bugs.webkit.org/show_bug.cgi?id=135727
<rdar://problem/17947880>

Reviewed by Darin Adler.

Source/WebCore:

Add SharedBuffer::existingCFData() which returns CFDataRef if it has one. Refactor
this code out of createCFData().

  • WebCore.exp.in:
  • platform/SharedBuffer.h:
  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::existingCFData): Added.
(WebCore::SharedBuffer::createCFData):

Source/WebKit2:

tryGetShareableHandleFromSharedBuffer() assumed that we have a file backed resource only if
we had a CFDataRef (platformData()) in SharedBuffer. This is wrong when we use the data
array callbacks since the file backed buffer could be in the data array. Instead of relying
on hasPlatformData(), explicitly ask the SharedBuffer to give us a CFDataRef if it has one
so that SharedBuffer can take care of the data array case.

  • NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

3:48 PM Changeset in webkit [172501] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Small region (~1px tall) where you get the selection button instead of the phone number overlay
https://bugs.webkit.org/show_bug.cgi?id=135852
<rdar://problem/17992795>

Reviewed by Enrica Casucci.

  • WebProcess/WebPage/ServicesOverlayController.h:
  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight):
(WebKit::ServicesOverlayController::determineActiveHighlight):
If our new active highlight is a selection highlight that is completely contained
by one of the phone number highlights, we'll make the phone number highlight active
even if it's not hovered. This fixes the case where the selection highlight
(a subset of a telephone number) is slightly taller than the telephone number
highlight, and can be hovered without hovering the phone number highlight

  • WebCore.exp.in:
3:43 PM Changeset in webkit [172500] by ap@apple.com
  • 12 edits in trunk/Source/WebKit2

REGRESSION: WebContent process has a sandbox extension for the entirety of user's temp directory
https://bugs.webkit.org/show_bug.cgi?id=135853
<rdar://problem/17986556>

Reviewed by Oliver hunt.

Move extensions recently added for iOS benefit under PLATFORM(IOS). Removed some
dead code while at it (child processes don't need actual paths, they only need
sandbox extensions in most cases).

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::ensureNetworkProcess):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::openGLCacheDirectory): Deleted.
(WebKit::WebContext::networkingHSTSDatabasePath): Deleted.

  • UIProcess/WebContext.h:
  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::containerTemporaryDirectory): Deleted.
(WebKit::WebContext::platformDefaultNetworkingHSTSDatabasePath): Deleted.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::containerTemporaryDirectory): Deleted.
(WebKit::WebContext::platformDefaultNetworkingHSTSDatabasePath): Deleted.

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::openGLCacheDirectory):
(WebKit::WebContext::parentBundleDirectory):
(WebKit::WebContext::networkingHSTSDatabasePath):
(WebKit::WebContext::platformDefaultOpenGLCacheDirectory): Deleted.
(WebKit::WebContext::platformDefaultNetworkingHSTSDatabasePath): Deleted.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

3:43 PM Changeset in webkit [172499] by achristensen@apple.com
  • 8 edits in trunk/Source

Generate header detection headers for CMake on Windows.
https://bugs.webkit.org/show_bug.cgi?id=135807

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

  • CMakeLists.txt:

Include the derived sources directory to find WTF/WTFHeaderDetection.h.

Source/WebCore:

  • CMakeLists.txt:
  • PlatformWin.cmake:

Generate and include a stub WebCoreHeaderDetection.h.

Source/WTF:

  • wtf/CMakeLists.txt:
  • wtf/PlatformWin.cmake:

Generate and include a stub WTFHeaderDetection.h.

3:42 PM Changeset in webkit [172498] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r172424): Extra menu header in combined telephone number menu when no phone paired
https://bugs.webkit.org/show_bug.cgi?id=135854
<rdar://problem/17996339>

Reviewed by Enrica Casucci.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):
Get all the menu items ahead of time, and only add the shared header
if there are any telephone number menu items.

3:32 PM Changeset in webkit [172497] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash at com.apple.WebKit.WebContent at com.apple.WebKit: WebKit::expandForGap
https://bugs.webkit.org/show_bug.cgi?id=135859
<rdar://problem/17994679>

Reviewed by Tim Horton.

expandForGap made the assumption that the selection rects were always three.
This was not true even before http://trac.webkit.org/changeset/172395 but
was more likely to happen after that change.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::expandForGap):

3:30 PM Changeset in webkit [172496] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Make sure that begin time cannot be greater than SMILTime::indefiniteValue unintentionally.
https://bugs.webkit.org/show_bug.cgi?id=135838

Patch by Renata Hodovan <rhodovan.u-szeged@partner.samsung.com> on 2014-08-12
Reviewed by Darin Adler.

Source/WebCore:

When WebCore::SVGSMILElement::resolveInterval creates a SMILTime begin
node for a SMILInterval, then it only checks if the value of begin is
indefinite or unresolved but misses the case if it is between these two
reference values.

This is a backport of my fix in Blink: https://codereview.chromium.org/406263002/.

Test: svg/animations/animateMotion-crash-with-large-begin-time.html

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::parseOffsetValue):
(WebCore::SVGSMILElement::parseClockValue):

LayoutTests:

  • svg/animations/animateMotion-crash-with-large-begin-time-expected.txt: Added.
  • svg/animations/animateMotion-crash-with-large-begin-time.html: Added.
2:59 PM Changeset in webkit [172495] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Revert a change that wasn't meant to be a part of r172482.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):

2:31 PM Changeset in webkit [172494] by Antti Koivisto
  • 5 edits in trunk

Don't recurse into non-rendered subtrees when computing style
https://bugs.webkit.org/show_bug.cgi?id=135844

Reviewed by Andreas Kling.
Source/WebCore:

  • style/StyleResolveTree.cpp:

(WebCore::Style::resetStyleForNonRenderedDescendants):

Do a simple reset of the style dirty bits and any computed style in non-rendered subtrees.

(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveTree):

Don't recurse into descendants if the element does not create a renderer.
We didn't compute style anyway in such subtrees.

LayoutTests:


Rebase.

  • http/tests/security/video-poster-cross-origin-crash-expected.txt:
  • platform/mac/fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt:
1:58 PM Changeset in webkit [172493] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-600.1.9/Source/WebKit2

Rollout 172395. <rdar://problem/17837670>

1:56 PM Changeset in webkit [172492] by matthew_hanson@apple.com
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Rollout172395. <rdar://problem/17837670>

1:53 PM Changeset in webkit [172491] by Yusuke Suzuki
  • 2 edits in trunk/Tools

[GTK] Adds dependency for GnuTLS 3.0+ explicitly in gtk/install-dependencies
https://bugs.webkit.org/show_bug.cgi?id=135850

Reviewed by Philippe Normand.

After r172433, GTK port requires GnuTLS 3.0+. In this time, libgnutls-dev is 2.x in
Ubuntu(trusty) and Debian(sid). So added libgnutls28-dev explicitly.

  • gtk/install-dependencies:
1:48 PM Changeset in webkit [172490] by matthew_hanson@apple.com
  • 3 edits
    1 copy in tags/Safari-600.1.9

Merge r171903. <rdar://problem/17885078>

1:46 PM Changeset in webkit [172489] by matthew_hanson@apple.com
  • 3 edits
    1 copy in branches/safari-600.1-branch

Merge r171903. <rdar://problem/17885078>

1:43 PM Changeset in webkit [172488] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview
https://bugs.webkit.org/show_bug.cgi?id=135849

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

Click events on elements in the graph container (event bubbles) or
in the scroll container (bottom 16px) were becoming the event targets.
As siblings of the ruler, the dispatch would not go through the ruler.
The ruler was supposed to be overlaying everything in the overview,
so give the ruler a z-index so it really is overlaying elements.

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler):

1:37 PM Changeset in webkit [172487] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Remove isInCanvasSubtree bit
https://bugs.webkit.org/show_bug.cgi?id=135837

Reviewed by Andreas Kling.

The logic to update this bit is in a wrong place and it is not clear it does
the right thing in all cases. Also the optimization doesn't seem necessary,
the focus code is not that hot.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::getOrCreate):

  • dom/Element.cpp:

(WebCore::Element::isFocusable):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
(WebCore::Element::setIsInCanvasSubtree): Deleted.
(WebCore::Element::isInCanvasSubtree): Deleted.

  • dom/Element.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::isInCanvasSubtree): Deleted.
(WebCore::ElementRareData::setIsInCanvasSubtree): Deleted.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isKeyboardFocusable):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::willAttachRenderers): Deleted.

  • html/HTMLCanvasElement.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::attachRenderTree):

1:29 PM Changeset in webkit [172486] by matthew_hanson@apple.com
  • 5 edits in branches/safari-600.1-branch/Source

Versioning.

1:16 PM Changeset in webkit [172485] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-600.1.9

New Tag.

1:03 PM Changeset in webkit [172484] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't show the combined menu if there are no services available
https://bugs.webkit.org/show_bug.cgi?id=135846
<rdar://problem/17582099>

Reviewed by Enrica Casucci.

  • WebProcess/WebPage/ServicesOverlayController.h:

Add a FIXME.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::determineActiveHighlight):
Don't allow a selection Highlight to become active if there is no
service available to handle it. Previously we showed the combined menu
with just phone numbers in it if any were detected.

12:31 PM Changeset in webkit [172483] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit2

Add a fade transition to services highlights
https://bugs.webkit.org/show_bug.cgi?id=135829
<rdar://problem/17935736>

Reviewed by Enrica Casucci.

Add a smooth fade to highlight installation and uninstallation.
To do so, we make each highlight paint into its own small layer.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::layer):

  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/PageOverlayController.cpp:

(WebKit::PageOverlayController::layerForOverlay):

  • WebProcess/WebPage/PageOverlayController.h:

Expose the GraphicsLayer on PageOverlay.

  • WebProcess/WebPage/ServicesOverlayController.h:

(WebKit::ServicesOverlayController::Highlight::layer):
(WebKit::ServicesOverlayController::activeHighlight):
(WebKit::ServicesOverlayController::webPage):
(WebKit::ServicesOverlayController::Highlight::Highlight): Deleted.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::Highlight::createForSelection):
(WebKit::ServicesOverlayController::Highlight::createForTelephoneNumber):
(WebKit::ServicesOverlayController::Highlight::Highlight):
Highlights now own a GraphicsLayer, which are later installed
as sublayers of the ServicesOverlayController's PageOverlay layer.
These layers are sized and positioned according to the DDHighlight's bounds.

(WebKit::ServicesOverlayController::Highlight::~Highlight):
(WebKit::ServicesOverlayController::Highlight::invalidate):
ServicesOverlayController will invalidate any remaining highlights
when it is torn down, so they can clear their backpointers.

(WebKit::ServicesOverlayController::Highlight::notifyFlushRequired):
Forward flush notifications to the DrawingArea.

(WebKit::ServicesOverlayController::Highlight::paintContents):
Paint the DDHighlight into the layer. Translation is done by the layer position,
so we zero the bounds origin when painting.

(WebKit::ServicesOverlayController::Highlight::deviceScaleFactor):
Forward the deviceScaleFactor so that things are painted at the right scale.

(WebKit::ServicesOverlayController::Highlight::fadeIn):
(WebKit::ServicesOverlayController::Highlight::fadeOut):
Apply a fade animation to the layer.

(WebKit::ServicesOverlayController::Highlight::didFinishFadeOutAnimation):
When the fade completes, unparent the layer, unless it has become active again.

(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::~ServicesOverlayController):
Invalidate all highlights, so they can clear their backpointers.

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
Make remainingTimeUntilHighlightShouldBeShown act upon a particular highlight
instead of always the active highlight.

(WebKit::ServicesOverlayController::determineActiveHighlightTimerFired): Rename.

(WebKit::ServicesOverlayController::drawRect):
drawRect is no longer called and will no longer do anything; all of the
painting is done in sublayers.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
Ensure that phone number Highlights stay stable even while the selection
changes, by comparing the underlying Ranges and keeping around old Highlights
that match the new ones. This enables us to e.g. fade in while changing
the selection within a phone number.

(WebKit::ServicesOverlayController::buildSelectionHighlight):
(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
(WebKit::ServicesOverlayController::createOverlayIfNeeded):
Don't call setNeedsDisplay; the overlay doesn't have backing store.
Instead, call determineActiveHighlight, which will install/uninstall
highlights as necessary.

(WebKit::ServicesOverlayController::determineActiveHighlight):
Apply fade in/fade out to the overlays.
Keep track of which highlight we're going to activate, until the hysteresis
delay is up, then actually make it active/parent it/fade it in.
We now will have no active highlight between the fade out of the previous one
and the fade in of the new one (during the hysteresis delay).

(WebKit::ServicesOverlayController::mouseEvent):
The overlay now will not become active until the delay is up, so we don't
need to check it again here.

(WebKit::ServicesOverlayController::handleClick):
(WebKit::ServicesOverlayController::didCreateHighlight):
(WebKit::ServicesOverlayController::willDestroyHighlight):
(WebKit::ServicesOverlayController::repaintHighlightTimerFired): Deleted.
(WebKit::ServicesOverlayController::drawHighlight): Deleted.

12:12 PM Changeset in webkit [172482] by aestes@apple.com
  • 26 edits
    8 deletes in trunk/Source

[iOS] Get rid of iOS.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=135809

Reviewed by Joseph Pecoraro.

All iOS.xcconfig did was include AspenFamily.xcconfig, so there's no need for the indirection.

Source/bmalloc:

  • Configurations/Base.xcconfig:
  • Configurations/iOS.xcconfig: Removed.
  • bmalloc.xcodeproj/project.pbxproj:

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/iOS.xcconfig: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj:

Source/ThirdParty:

  • gtest/xcode/Config/General.xcconfig:
  • gtest/xcode/Config/iOS.xcconfig: Removed.
  • gtest/xcode/gtest.xcodeproj/project.pbxproj:

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj:
  • Configurations/Base.xcconfig:
  • Configurations/iOS.xcconfig: Removed.

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/iOS.xcconfig: Removed.
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/iOS.xcconfig: Removed.

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • Configurations/iOS.xcconfig: Removed.
  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

  • Configurations/Base.xcconfig:
  • Configurations/iOS.xcconfig: Removed.
  • WTF.xcodeproj/project.pbxproj:
11:52 AM Changeset in webkit [172481] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Adjust max-width of cues based on text alignment when cue size is expanded.
https://bugs.webkit.org/show_bug.cgi?id=135823.

Reviewed by Brent Fulgham.

All units are in percentages.
If we are left aligned the max cue width is the 100 minus the cue position.
If we are right aligned the max cue width is the cue position.
If we are centered the max cue width is just 100.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

  • html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

10:50 AM Changeset in webkit [172480] by Lucas Forschler
  • 3 edits
    1 delete in tags/Safari-600.1.8.1/Source/WebCore

Rollout r172278. <rdar://problem/17981175>

10:47 AM Changeset in webkit [172479] by Lucas Forschler
  • 5 edits in tags/Safari-600.1.8.1/Source

Versioning.

10:38 AM Changeset in webkit [172478] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.8.1

New Tag.

10:34 AM Changeset in webkit [172477] by Lucas Forschler
  • 2 edits
    1 delete in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172436. <rdar://problem/17987726>

10:32 AM Changeset in webkit [172476] by Lucas Forschler
  • 10 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172435. <rdar://problem/17987681>

10:29 AM Changeset in webkit [172475] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172432. <rdar://problem/16709018>

10:17 AM Changeset in webkit [172474] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172471. <rdar://problem/17990895>

10:11 AM Changeset in webkit [172473] by Lucas Forschler
  • 3 edits
    1 delete in branches/safari-600.1-branch/Source/WebCore

Merged r172399. <rdar://problem/17971237>

9:32 AM Changeset in webkit [172472] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[GStreamer] playback rate is rounded to integer
https://bugs.webkit.org/show_bug.cgi?id=135802

Patch by Fabien Vallée <fvallee@connected-labs.com> on 2014-08-12
Reviewed by Philippe Normand.

Source/WebCore:

Test: media/video-ended-event-slow-motion-playback.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setRate):

LayoutTests:

add test to ensure playback is actually working
in slow motion (playback rate = 0.5): Player
should reach EOS and dispatch ended event.

  • media/video-ended-event-slow-motion-playback-expected.txt: Added.
  • media/video-ended-event-slow-motion-playback.html: Added.
9:06 AM Changeset in webkit [172471] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r17425

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Remove

unused 'currentTime' declaration from header file. This is now fully implemented
in platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h.

8:06 AM Changeset in webkit [172470] by Lucas Forschler
  • 26 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172399. <rdar://problem/17971237>

8:03 AM Changeset in webkit [172469] by Lucas Forschler
  • 12 edits
    3 deletes in branches/safari-600.1-branch/Source

Merged r172379. <rdar://problem/17955579>

7:25 AM Changeset in webkit [172468] by Lucas Forschler
  • 9 edits in branches/safari-600.1-branch

Merged r172425. <rdar://problem/17476923>

7:22 AM Changeset in webkit [172467] by Lucas Forschler
  • 6 edits in branches/safari-600.1-branch/Source

Merged r172424. <rdar://problem/17936880>

7:20 AM Changeset in webkit [172466] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172428. <rdar://problem/17912361>

7:18 AM Changeset in webkit [172465] by Lucas Forschler
  • 6 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172422. <rdar://problem/17912361>

7:11 AM Changeset in webkit [172464] by Lucas Forschler
  • 4 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172421. <rdar://problem/17961164>

7:06 AM Changeset in webkit [172463] by Lucas Forschler
  • 4 edits
    7 copies in branches/safari-600.1-branch

Merged r172417. <rdar://problem/17848141>

7:04 AM Changeset in webkit [172462] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172406. <rdar://problem/17981554>

7:01 AM Changeset in webkit [172461] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172404. <rdar://problem/17979844>

6:58 AM Changeset in webkit [172460] by Lucas Forschler
  • 8 edits in branches/safari-600.1-branch/Source

Merged r172397. <rdar://problem/17983299>

6:56 AM Changeset in webkit [172459] by Lucas Forschler
  • 1 edit
    1 copy in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172262. <rdar://problem/17983299>

6:51 AM Changeset in webkit [172458] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172395. <rdar://problem/17837670>

6:43 AM Changeset in webkit [172457] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172374. <rdar://problem/17969843>

6:42 AM Changeset in webkit [172456] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-600.1-branch

Merged r172373. <rdar://problem/17952364>

6:40 AM Changeset in webkit [172455] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172369. <rdar://problem/17533459>

6:38 AM Changeset in webkit [172454] by Lucas Forschler
  • 6 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172366. <rdar://problem/17533459>

6:36 AM Changeset in webkit [172453] by Lucas Forschler
  • 3 edits
    3 copies in branches/safari-600.1-branch

Merged r172365. <rdar://problem/17959896>

6:32 AM Changeset in webkit [172452] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172364. <rdar://problem/17962180>

6:30 AM Changeset in webkit [172451] by Lucas Forschler
  • 5 edits in branches/safari-600.1-branch

Merged r172351. <rdar://problem/17961164>

6:25 AM Changeset in webkit [172450] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172344. <rdar://problem/17907752>

6:23 AM Changeset in webkit [172449] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172343. <rdar://problem/17933167>

6:22 AM Changeset in webkit [172448] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172336. <rdar://problem/17955491>

6:20 AM Changeset in webkit [172447] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172333. <rdar://problem/17955768>

6:15 AM Changeset in webkit [172446] by Lucas Forschler
  • 8 edits in branches/safari-600.1-branch/Source

Merged r172235. <rdar://problem/17388461>

5:07 AM Changeset in webkit [172445] by g.czajkowski@samsung.com
  • 4 edits
    1 move in trunk/Source/WebKit2

[EFL] Rename ewk_private.h to EwkDebug.h
https://bugs.webkit.org/show_bug.cgi?id=135797

Reviewed by Gyuyoung Kim.

ewk_private.h contains only debug macros alllowing
logging.

  • UIProcess/API/efl/EwkView.cpp:
  • UIProcess/API/efl/ewk_main.cpp:
  • UIProcess/efl/EwkDebug.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
  • UIProcess/efl/ViewClientEfl.cpp:
4:42 AM Changeset in webkit [172444] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r172442 - [GTK] The plugins metadata cache doesn't work if the user cache directory doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=135834

Reviewed by Philippe Normand.

Make sure the user cache directory exists. If creating the
directory fails for whatever reason, do not try to save the cache
to disk.

  • UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::updatePluginInfo):

4:29 AM Changeset in webkit [172443] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Dont allocate GCond in VideoSinkGStreamer.cpp dynamically.

Rubber-stamped by Carlos Garcia Campos.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(_WebKitVideoSinkPrivate::_WebKitVideoSinkPrivate): Move the
g_cond_init() and gst_video_info_init() calls here.
(_WebKitVideoSinkPrivate::~_WebKitVideoSinkPrivate): Move the
g_cond_clear() call here.
(webkit_video_sink_init):
(webkitVideoSinkTimeoutCallback):
(webkitVideoSinkRender):
(unlockBufferMutex):
(webkit_video_sink_class_init):
(webkitVideoSinkDispose): Deleted. Not required anymore.

3:55 AM Changeset in webkit [172442] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] The plugins metadata cache doesn't work if the user cache directory doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=135834

Reviewed by Philippe Normand.

Make sure the user cache directory exists. If creating the
directory fails for whatever reason, do not try to save the cache
to disk.

  • UIProcess/Plugins/gtk/PluginInfoCache.cpp:

(WebKit::PluginInfoCache::PluginInfoCache):
(WebKit::PluginInfoCache::updatePluginInfo):

3:39 AM Changeset in webkit [172441] by zandobersek@gmail.com
  • 7 edits in trunk/Source

Clean up GMutexLocker
https://bugs.webkit.org/show_bug.cgi?id=135833

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Don't dynamically allocate GMutex objects. Update GMutexLocker
initializations to pass in a GMutex reference, not a pointer.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(_WebKitVideoSinkPrivate::_WebKitVideoSinkPrivate): Initialize the GMutex.
(_WebKitVideoSinkPrivate::~_WebKitVideoSinkPrivate): Clear the GMutex.
(webkit_video_sink_init):
(webkitVideoSinkRender):
(webkitVideoSinkDispose):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived):
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

Source/WTF:

Place the GMutexLocker into the WTF namespace. There's no need for this
class to use FastMalloc since it's always allocated on the stack. The
constructor and class now operate on a GMutex reference. There's little
need for an additional inline specifier for methods defined in the header.
The mutex() method is removed as it was not used. m_val is renamed to a
more descriptive m_locked and is made a boolean.

  • wtf/gobject/GMutexLocker.h:

(WTF::GMutexLocker::GMutexLocker):
(WTF::GMutexLocker::~GMutexLocker):
(WTF::GMutexLocker::lock):
(WTF::GMutexLocker::unlock):
(WebCore::GMutexLocker::GMutexLocker): Deleted.
(WebCore::GMutexLocker::~GMutexLocker): Deleted.
(WebCore::GMutexLocker::lock): Deleted.
(WebCore::GMutexLocker::unlock): Deleted.
(WebCore::GMutexLocker::mutex): Deleted.

3:36 AM Changeset in webkit [172440] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Make GRefPtr move-able
https://bugs.webkit.org/show_bug.cgi?id=135801

Reviewed by Carlos Garcia Campos.

Add move constructor and move assignment operator for GRefPtr.

  • wtf/gobject/GRefPtr.h:

(WTF::GRefPtr::GRefPtr):
(WTF::=):

2:35 AM Changeset in webkit [172439] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Subtle-crypto feature off by default and add a new configure flag to enable it
https://bugs.webkit.org/show_bug.cgi?id=135798

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-12
Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsGTK.cmake: Makes SUBTLE_CRYPTO flag off by default.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Adds new flag --subtle-crypto to

toggle SUBTLE_CRYPTO feature.

1:25 AM Changeset in webkit [172438] by ryuan.choi@samsung.com
  • 2 edits
    1 add in trunk/Tools

[EFL] Disable ecore logs about bad fd
https://bugs.webkit.org/show_bug.cgi?id=135831

Reviewed by Gyuyoung Kim.

ecore checks EBADF and prints the warnings.
But, it looks noise in layout test because it's not webkit issue.
This patch disables it until we found right solution.

  • efl/jhbuild.modules:
  • efl/patches/ecore_remove_warnings.patch: Added.
1:22 AM Changeset in webkit [172437] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser: Enhance the application to use download directory selector.
https://bugs.webkit.org/show_bug.cgi?id=135791

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-08-12
Reviewed by Gyuyoung Kim.

Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the
user.

  • MiniBrowser/efl/main.c:

(on_download_request):

1:16 AM Changeset in webkit [172436] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: GoToLine dialog clear text button looks poor
https://bugs.webkit.org/show_bug.cgi?id=135828

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

Legacy/CloseWhite.svg was not used, but in the case where the white
close button is needed the thicker bars looks better. Re-use the
Legacy image as the default CloseWhite.svg.

  • UserInterface/Images/CloseWhite.svg:
  • UserInterface/Images/Legacy/CloseWhite.svg: Removed.
1:12 AM Changeset in webkit [172435] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Easier Way to go back to the Timeline Overviews
https://bugs.webkit.org/show_bug.cgi?id=135827

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-12
Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:

Added new tooltip UIString.

  • UserInterface/Images/Close.svg:
  • UserInterface/Images/CloseLarge.svg:
  • UserInterface/Images/Legacy/Close.svg:

Add "stroked" class so the buttons can fill with white on selected rows.
Also re-center the non-legacy images horizontally.

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.set status):
Do not recreate elements if the status did not change.

  • UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView):
(WebInspector.LayoutTimelineView.prototype._treeElementDeselected):
(WebInspector.LayoutTimelineView.prototype._treeElementSelected):
(WebInspector.LayoutTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.LayoutTimelineView.prototype._closeStatusButtonClicked):

  • UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView):
(WebInspector.NetworkTimelineView.prototype._treeElementDeselected):
(WebInspector.NetworkTimelineView.prototype._treeElementSelected):
(WebInspector.NetworkTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.NetworkTimelineView.prototype._closeStatusButtonClicked):

  • UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype._treeElementDeselected):
(WebInspector.OverviewTimelineView.prototype._treeElementSelected):
(WebInspector.OverviewTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.OverviewTimelineView.prototype._closeStatusButtonClicked):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView):
(WebInspector.ScriptTimelineView.prototype._treeElementDeselected):
(WebInspector.ScriptTimelineView.prototype._treeElementSelected):
(WebInspector.ScriptTimelineView.prototype._updateTreeElementWithCloseButton):
(WebInspector.ScriptTimelineView.prototype._closeStatusButtonClicked):
Provide select/deselect handlers to show/hide the close status bar button
when selecting a row that shows a non-Timeline content view. Currently the
only content views the tree elements can show are Resource views, so the
tooltip is the same everywhere.

1:06 AM Changeset in webkit [172434] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Allow reading CoreGraphics debugging preferences
https://bugs.webkit.org/show_bug.cgi?id=135821
<rdar://problem/11219259>

Reviewed by Darin Adler.

  • WebProcess/com.apple.WebProcess.sb.in:
1:03 AM Changeset in webkit [172433] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds dependency on GnuTLS 3.0+ for the implementation of subtle crypto algorithms
https://bugs.webkit.org/show_bug.cgi?id=133317

.:

GnuTLS is already an indirect dependency through libsoup -> glib-networking.

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-12
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

  • Source/cmake/OptionsGTK.cmake: Adds search for required GnuTLS package

Source/WebCore:

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-12
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

  • PlatformGTK.cmake: Adds GnuTLS libs and included dirs to WebCore targets
12:56 AM Changeset in webkit [172432] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Expect to see top level JavaScript function profiler details for event handlers in timeline
https://bugs.webkit.org/show_bug.cgi?id=132109

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._processPendingRecords): Don't promote root node children if
there is only one child.

12:49 AM Changeset in webkit [172431] by Philippe Normand
  • 9 edits
    2 deletes in trunk/Source/WebCore

[WebAudio] FFTFrame is cluttered with dead code
https://bugs.webkit.org/show_bug.cgi?id=135751

Reviewed by Eric Carlson.

Cleaned up unused FFTFrame implementations from the tree. If the
FFMPEG or IPP versions are needed later on again this patch can be
rolled out.

No new tests, the code removed was disabled on all ports.

  • platform/audio/Biquad.cpp:

(WebCore::Biquad::Biquad):
(WebCore::Biquad::~Biquad):
(WebCore::Biquad::process):
(WebCore::Biquad::reset):
(WebCore::Biquad::setNormalizedCoefficients):

  • platform/audio/Biquad.h:
  • platform/audio/DirectConvolver.cpp:

(WebCore::DirectConvolver::DirectConvolver):
(WebCore::DirectConvolver::process):
(WebCore::DirectConvolver::reset):

  • platform/audio/DirectConvolver.h:
  • platform/audio/FFTFrame.h:
  • platform/audio/FFTFrameStub.cpp:
  • platform/audio/ffmpeg/FFTFrameFFMPEG.cpp: Removed.
  • platform/audio/ipp/FFTFrameIPP.cpp: Removed.
  • platform/audio/mac/FFTFrameMac.cpp:
12:42 AM Changeset in webkit [172430] by g.czajkowski@samsung.com
  • 6 edits
    1 add in trunk

[EFL] Prevent the client from creating ewk_view when EWebkit is not initialized
https://bugs.webkit.org/show_bug.cgi?id=135606

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Similarly to EFL modules (eina, evas etc.), application using EWebKit
has to initialize it using ewk_init().

Do not allow the client to create ewk_view if ewk_init has not been called.
Add an appropriate logs warning the client about wrong APIs usage.

  • UIProcess/API/efl/ewk_main.cpp: Add EwkMain class to control ewk lifetime.

(WebKit::EwkMain::EwkMain):
(WebKit::EwkMain::shared):
(WebKit::EwkMain::~EwkMain): Add logs when the client forgot to destroy EWebkit.
(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):
(ewk_init):
(ewk_shutdown):

  • UIProcess/API/efl/ewk_main_private.h: Added.

(WebKit::EwkMain::isInitialized):
(WebKit::EwkMain::logDomainId):

  • UIProcess/API/efl/ewk_private.h:
  • UIProcess/API/efl/ewk_view.cpp:

(EWKViewCreate):
Prevent the client from creating ewk_view when ewk_init() has not been called.

Tools:

TestWebKitAPI does not initialize EWebkit using ewk_init()
which is not recommended.

  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::createEcoreEvas):
Renamed from initEcoreEvas() since it doesn't not initialize
ecore evas.

(TestWebKitAPI::PlatformWebView::PlatformWebView):
Call ewk_init() that initalizes all EFL modules needed by EWebKit
instead of ecore_evas_init() only.

(TestWebKitAPI::PlatformWebView::~PlatformWebView):
Call ewk_shutdown() to finalize EWebkit.
(TestWebKitAPI::initEcoreEvas): Deleted.

Aug 11, 2014:

8:20 PM Changeset in webkit [172429] by msaboff@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Eliminate {push,pop}CalleeSaves in favor of individual pushes & pops
https://bugs.webkit.org/show_bug.cgi?id=127155

Reviewed by Geoffrey Garen.

Eliminated the offline assembler instructions {push,pop}CalleeSaves as well as the
ARM64 specific {push,pop}LRAndFP and replaced them with individual push and pop
instructions. Where the registers referenced by the added push and pop instructions
are not part of the offline assembler register aliases, used a newly added "emit"
offline assembler instruction which takes a string literal and outputs that
string as a native instruction.

  • llint/LowLevelInterpreter.asm:
  • offlineasm/arm.rb:
  • offlineasm/arm64.rb:
  • offlineasm/ast.rb:
  • offlineasm/cloop.rb:
  • offlineasm/instructions.rb:
  • offlineasm/mips.rb:
  • offlineasm/parser.rb:
  • offlineasm/sh4.rb:
  • offlineasm/transform.rb:
  • offlineasm/x86.rb:
8:01 PM Changeset in webkit [172428] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Mac build.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
6:23 PM Changeset in webkit [172427] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4-branch/Source

Versioning.

6:19 PM Changeset in webkit [172426] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.10

New tag.

6:12 PM Changeset in webkit [172425] by Brent Fulgham
  • 9 edits in trunk

[Mac, iOS] Some media content never reaches full 'loaded' state
https://bugs.webkit.org/show_bug.cgi?id=135814
<rdar://problem/17476923>

Reviewed by Jer Noble.

Source/WebCore:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::duration): Change to a wrapper that just calls
the durationDouble method and narrows to a float.
(WebCore::MediaPlayerPrivateAVFoundation::durationDouble): Revised version of duration
that works with doubles.
(WebCore::MediaPlayerPrivateAVFoundation::currentTime): Wrapper that calls the
currentTimeDouble method and narrows to a float.
(WebCore::MediaPlayerPrivateAVFoundation::seekWithTolerance): Use durationDouble for
comparison with passed 'time' argument (which is a double).
(WebCore::MediaPlayerPrivateAVFoundation::didEnd): Use 'currentTimeDouble' so we can
cache the double precision version of this value.
(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): Use 'durationDouble' since
the rest of the calculation is in terms of doubles.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformDuration): Convert to 'double'. All
uses of this method are internal to the MediaPlayerPrivateAVFoundation* files.
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTimeDouble): Switch from float implementation.
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTime): Deleted. (Moved to parent class)

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Convert to 'double'. All
uses of this method are internal to the MediaPlayerPrivateAVFoundation* files.
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTimeDouble): Switch from floating implementation.
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime): Deleted. (Moved to parent class)

LayoutTests:

  • platform/mac/media/video-seek-past-end-paused-expected.txt: Rebaseline

result for new rounding behavior.

6:04 PM Changeset in webkit [172424] by enrica@apple.com
  • 6 edits in trunk/Source

Improve look and feel of combined service menu..
https://bugs.webkit.org/show_bug.cgi?id=135824
<rdar://problem/17936880>

Reviewed by Tim Horton.
Source/WebCore:

Adding some localizable strings.

  • English.lproj/Localizable.strings:

Source/WebKit2:


When showing the combined menu, list the phone numbers first,
grouped under a common header, followed by the entries relative
to the services.

  • Platform/mac/MenuUtilities.h:
  • Platform/mac/MenuUtilities.mm:

(WebKit::menuItemTitleForTelephoneNumberGroup):
(WebKit::menuItemForTelephoneNumber):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

6:00 PM Changeset in webkit [172423] by bshafiei@apple.com
  • 6 edits in branches/safari-600.1.4-branch/Source/WebCore

Merged r172422. <rdar://problem/17912361>

5:36 PM Changeset in webkit [172422] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

[iOS] <video> element requests are missing session cookies; sometimes persistant cookies.
https://bugs.webkit.org/show_bug.cgi?id=135816

Reviewed by Alexey Proskuryakov.

On iOS, the AVFoundation framework will copy appropriate cookies for the requested URL across to the
mediaserverd process. For WebKit2, the WebProcess does not have access to session cookies for the
current browsing session. When creating an AVURLAsset, fetch the appropriate cookies for the requested
URL, and pass them into AVURLAsset in the options dictionary.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerGetRawCookies): Call CookieJar's equivalent method.

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getRawCookies): Pass to HTMLMediaElement.

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerGetRawCookies):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::toNSHTTPCookie): Convert a WebCore Cookie -> NSHTTPCookie.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Fetch cookies for the requested

URL, and if successful, add them to the AVURLAsset options dictionary.

5:15 PM WebInspectorCodingStyleGuide edited by Brian Burg
How to document promise fulfillment values (diff)
5:13 PM Changeset in webkit [172421] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebCore

Adjustments to CueBox CSS Width calculations Part 2.
https://bugs.webkit.org/show_bug.cgi?id=135820
<rdar://problem/17954473>.

Reviewed by Brent Fulgham.

Two adjustments made:
a) The default font size used was incorrect. It is not just 10px,
but should be based off a percentage of the video size.
b) The top/left CSS property needs to be adjusted appropriately if the cue
is center aligned and we change the cue's size such that the cue remains centered.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

  • html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

  • html/track/VTTCue.h: Remove unnecessary constant.
4:41 PM Changeset in webkit [172420] by Brian Burg
  • 5 edits
    2 copies
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: show a replay dashboard when capturing or replaying
https://bugs.webkit.org/show_bug.cgi?id=135170

Reviewed by Timothy Hatcher.

This patch adds a replay dashboard with record/play/pause buttons. It
is shown automatically when the user starts capturing an execution from
the replay menu in the Timelines sidebar panel.

  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector._captureDidStart):

  • UserInterface/Controllers/DashboardManager.js:

(WebInspector.DashboardManager):

  • UserInterface/Images/ReplayPauseButton.svg: Added.
  • UserInterface/Images/ReplayPlayButton.svg: Added.
  • UserInterface/Images/ReplayRecordingButton.svg: Added.
  • UserInterface/Main.html:
  • UserInterface/Models/ReplayDashboard.js: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.

(WebInspector.ReplayDashboard):

  • UserInterface/Views/DashboardView.js:

(WebInspector.DashboardView):

  • UserInterface/Views/ReplayDashboardView.css: Copied from Source/WebInspectorUI/UserInterface/Controllers/DashboardManager.js.

(.toolbar .dashboard.replay):
(.toolbar .dashboard.replay div.navigation-bar):
(.toolbar .dashboard.replay .item.button > .glyph):
(.toolbar.label-only .dashboard.replay .item.button > .glyph):

  • UserInterface/Views/ReplayDashboardView.js: Added.

(WebInspector.ReplayDashboardView):
(WebInspector.ReplayDashboardView.prototype._captureButtonItemClicked):
(WebInspector.ReplayDashboardView.prototype._replayButtonItemClicked):
(WebInspector.ReplayDashboardView.prototype._captureStarted):
(WebInspector.ReplayDashboardView.prototype._captureStopped):
(WebInspector.ReplayDashboardView.prototype._playbackStarted):
(WebInspector.ReplayDashboardView.prototype._playbackPaused):
(WebInspector.ReplayDashboardView.prototype._playbackFinished):

4:40 PM Changeset in webkit [172419] by mitz@apple.com
  • 2 edits in trunk/Tools

Added an update-webkit option to update the auxiliary libraries or not.
Part of https://bugs.webkit.org/show_bug.cgi?id=135815

Reviewed by Tim Horton.

  • Scripts/update-webkit: Added --[no-]auxiliary-libs option, which defaults to yes unless

an Internal directory exists alongside the WebKit root directory.

4:26 PM Changeset in webkit [172418] by Bem Jones-Bey
  • 2 edits in trunk/Tools

Remove hg changeset from w3c-import.log
https://bugs.webkit.org/show_bug.cgi?id=135735

Reviewed by Ryosuke Niwa.

Since the csswg's test suite is now accessible via github and it is
possible to push changes by creating github pull requests, the hg
changeset makes less sense, as many people will just use a clone of
the git repo. There isn't an obvious thing to replace it with, so
might as well remove it for now instead of having it just be set to
UNKNOWN in imports.

This also adds a pointer to the github repo in the generated comments
in the w3c-import.log.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.init): Remove changeset handling.
(TestImporter.do_import): Ditto.
(TestImporter.write_import_log): Ditto.
(TestImporter.load_changeset): Deleted.

4:03 PM Changeset in webkit [172417] by Beth Dakin
  • 4 edits
    12 adds in trunk

Fixed backgrounds don't paint in blurred inset areas
https://bugs.webkit.org/show_bug.cgi?id=135712

Reviewed by Simon Fraser.

Source/WebCore:

Background geometry calculations for fixed background need to use the larger
visible rect.

The first version of this patch caused a regression because it universally
adjusted the value for top to account for the inset whether or not the
viewportRect location was adjusted for the same. This version fixes that — those
two changes go hand-in-hand.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/fast: Added.
  • platform/mac-wk1/fast/backgrounds: Added.
  • platform/mac-wk1/fast/backgrounds/resources: Added.
  • platform/mac-wk1/fast/backgrounds/resources/green.png: Added.
  • platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment-expected.html: Added.
  • platform/mac-wk1/fast/backgrounds/top-content-inset-fixed-attachment.html: Added.
  • platform/mac-wk2/tiled-drawing/resources/green-blue.png: Added.
  • platform/mac-wk2/tiled-drawing/resources/green.png: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-body-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-body.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-expected.html: Added.
  • platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment.html: Added.
3:30 PM Changeset in webkit [172416] by Lucas Forschler
  • 8 edits in tags/Safari-600.1.2.10/Source

Merged r172397. <rdar://problem/17978299>

3:28 PM Changeset in webkit [172415] by Lucas Forschler
  • 5 edits in tags/Safari-600.1.2.10/Source

Versioning.

3:25 PM Changeset in webkit [172414] by Lucas Forschler
  • 1 copy in tags/Safari-600.1.2.10

New Tag.

3:00 PM Changeset in webkit [172413] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Re-landing r172401 with fixed test.
<https://webkit.org/b/135782>

Not reviewed.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ForInContext::ForInContext):
(JSC::ForInContext::base):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitMultiLoopBytecode):

  • tests/stress/for-in-tests.js:
2:25 PM Changeset in webkit [172412] by Brian Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: DebuggerManager commands should return promises
https://bugs.webkit.org/show_bug.cgi?id=135690

Reviewed by Timothy Hatcher.

Convert the existing debugger commands to return promises. This
requires separately waiting for protocol command's promise to be
fulfilled, as well as waiting for the appropriate DebuggerManager
event. If the protocol command promise is rejected, tear down the
single-fire event listener.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.pause):
(WebInspector.DebuggerManager.prototype.resume):
(WebInspector.DebuggerManager.prototype.stepOver):
(WebInspector.DebuggerManager.prototype.stepInto):
(WebInspector.DebuggerManager.prototype.stepOut):

  • UserInterface/Controllers/ReplayManager.js: Use the promise-based API.

(WebInspector.ReplayManager.prototype._suppressBreakpointsAndResumeIfNeeded):

2:16 PM Changeset in webkit [172411] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Report run id's in api/runs.php for the new dashboard UI
https://bugs.webkit.org/show_bug.cgi?id=135813

Reviewed by Andreas Kling.

Include run_id in the generated JSON.

  • public/api/runs.php:

(fetch_runs_for_config): Don't sort results by time since that has been done in the front end for ages now.
(format_run):

1:48 PM Changeset in webkit [172410] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Merging platforms mixes baselines and targets into reported data
https://bugs.webkit.org/show_bug.cgi?id=135260

Reviewed by Andreas Kling.

When merging two platforms, move test configurations of a different type (baseline, target)
as well as of different metric (Time, Runs).

Also avoid fetching the entire table of runs just to see if there are no remaining runs.
It's sufficient to detect one such test_runs object.

  • public/admin/platforms.php:

(merge_platforms):

1:42 PM Changeset in webkit [172409] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Pass inherited style only when resolving tree style
https://bugs.webkit.org/show_bug.cgi?id=135799

Reviewed by Andreas Kling.

No need to pass around the style parent element.

  • dom/ContainerNode.h:

(WebCore::ContainerNode::childShouldCreateRenderer): Deleted.

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::RenderTreePosition::parent):
(WebCore::Style::nextSiblingRenderer):
(WebCore::Style::RenderTreePosition::RenderTreePosition):
(WebCore::Style::RenderTreePosition::computeNextSibling):
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::styleForElement):
(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::textRendererIsNeeded):
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::attachTextRenderer):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveTextNode):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::childShouldCreateRenderer): Deleted.

Implement this in SVGSVGElement::rendererIsNeeded instead.

  • svg/SVGDocument.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::rendererIsNeeded):

1:24 PM Changeset in webkit [172408] by Yusuke Suzuki
  • 7 edits
    4 adds in trunk

CSS JIT: support :scope
https://bugs.webkit.org/show_bug.cgi?id=135733

Reviewed by Benjamin Poulain.

Implement :scope for CSS JIT. It introduces scope field to CheckingContext
and it makes CheckingContext more similar to SelectorChecker::SelectorCheckingContext.
And since :scope requires CheckingContext, QueryingRules can accept SelectorCheckerWithCheckingContext.

Source/WebCore:

Tests: fast/selectors/querySelector-scope-filtered-root.html

fast/selectors/scope-works-as-root.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::shouldUseRenderStyleFromCheckingContext):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::loadCheckingContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):

  • cssjit/SelectorCompiler.h:

(WebCore::SelectorCompiler::CheckingContext::CheckingContext):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithCheckingContext):
(WebCore::SelectorDataList::execute):

  • dom/SelectorQuery.h:

LayoutTests:

  • fast/selectors/querySelector-scope-filtered-root-expected.txt: Added.
  • fast/selectors/querySelector-scope-filtered-root.html: Added.

Searching root node of querySelectorAll is filtered to id node, but :scope root node should not be changed.

  • fast/selectors/scope-works-as-root-expected.html: Added.
  • fast/selectors/scope-works-as-root.html: Added.

:scope in stylesheet works as :root.

1:07 PM Changeset in webkit [172407] by Lucas Forschler
  • 3 edits in branches/safari-600.1-branch/Source/WebInspectorUI

Merged r172403. <rdar://problem/17979472>.

1:07 PM Changeset in webkit [172406] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Add Private WKPreferences API for developer extras (show inspector)
https://bugs.webkit.org/show_bug.cgi?id=135811

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-11
Reviewed by Timothy Hatcher.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _developerExtrasEnabled]):
(-[WKPreferences _setDeveloperExtrasEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
1:00 PM Changeset in webkit [172405] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r172401.
https://bugs.webkit.org/show_bug.cgi?id=135812

Failing stress/for-in-tests.js
http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK1%20%28Tests%29/builds/7945/steps
/jscore-test/logs/stdio (Requested by mlam on #webkit).

Reverted changeset:

"for-in optimization should also make sure the base matches
the object being iterated"
https://bugs.webkit.org/show_bug.cgi?id=135782
http://trac.webkit.org/changeset/172401

12:50 PM Changeset in webkit [172404] by timothy@apple.com
  • 3 edits in trunk/Source/WebCore

Web Inspector: console.profile shouldn't stop auto-recorded profiles
https://bugs.webkit.org/show_bug.cgi?id=135810

Reviewed by Joseph Pecoraro.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::start): Added. Call internalStart. Set m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::stop): Added. Calls internalStop. Clear m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::internalStart): Renamed from start.
(WebCore::InspectorTimelineAgent::internalStop): Renamed from stop.
(WebCore::InspectorTimelineAgent::startFromConsole): Use internalStart.
(WebCore::InspectorTimelineAgent::stopFromConsole): Use internalStop. Only stop if !m_enabledFromFrontend.
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent): Initialize m_enabledFromFrontend.

  • inspector/InspectorTimelineAgent.h: Added m_enabledFromFrontend.
12:22 PM Changeset in webkit [172403] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Update folder icons
https://bugs.webkit.org/show_bug.cgi?id=135808

Reviewed by Joseph Pecoraro.

  • UserInterface/Images/FolderGeneric.png: Updated.
  • UserInterface/Images/FolderGeneric@2x.png: Updated.
12:19 PM Changeset in webkit [172402] by Brian Burg
  • 8 edits in trunk/Source/JavaScriptCore

Web Inspector: use type builders to construct high fidelity type information payloads
https://bugs.webkit.org/show_bug.cgi?id=135803

Reviewed by Timothy Hatcher.

Due to some typos in the protocol file, the code had worked with raw objects
rather than with type builders. Convert to using builders.

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/protocol/Runtime.json: Fix 'item' for 'items'; true for 'true'.
  • runtime/HighFidelityTypeProfiler.cpp:

(JSC::HighFidelityTypeProfiler::getTypesForVariableAtOffsetForInspector):

  • runtime/HighFidelityTypeProfiler.h:
  • runtime/TypeSet.cpp:

(JSC::TypeSet::allStructureRepresentations):
(JSC::StructureShape::stringRepresentation):
(JSC::StructureShape::inspectorRepresentation):

  • runtime/TypeSet.h:
11:59 AM Changeset in webkit [172401] by mhahnenberg@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

for-in optimization should also make sure the base matches the object being iterated
https://bugs.webkit.org/show_bug.cgi?id=135782

Reviewed by Geoffrey Garen.

If we access a different base object with the same index, we shouldn't try to randomly
load from that object's backing store.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::ForInContext::ForInContext):
(JSC::ForInContext::base):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitMultiLoopBytecode):

  • tests/stress/for-in-tests.js:
11:47 AM Changeset in webkit [172400] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Unreviewed gardening.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Display files in

proper folder categories..

11:43 AM Changeset in webkit [172399] by timothy@apple.com
  • 26 edits in trunk/Source/WebInspectorUI

Web Inspector: DataGrid and its clients are a cluster-cuss of styles
https://bugs.webkit.org/show_bug.cgi?id=135788

Clean up DataGrid and its subclasses and client styles.

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/ApplicationCacheFrameContentView.css:

(.content-view.application-cache-frame > .data-grid):

  • UserInterface/Views/CookieStorageContentView.css:

(.content-view.cookie-storage > .data-grid):

  • UserInterface/Views/DOMStorageContentView.css:

(.content-view.dom-storage > .data-grid):

  • UserInterface/Views/DOMTreeDataGrid.css:

(.dom-tree-data-grid .data-grid):
(.dom-tree-data-grid .name-column .icon):

  • UserInterface/Views/DOMTreeDataGrid.js:

(WebInspector.DOMTreeDataGrid):

  • UserInterface/Views/DataGrid.css:

(.data-grid):
(.data-grid table):
(.data-grid .data-container):
(.data-grid.inline):
(.data-grid th):
(.data-grid :-webkit-any(th, td):not(:last-child)):
(.data-grid th.sortable:active):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending)):
(.data-grid table.data):
(.data-grid td):
(.data-grid:focus tr.selected td:not(:last-child)):
(body.mac-platform.legacy .data-grid:focus tr.selected td:not(:last-child)):
(.data-grid :-webkit-any(th, td) > div):
(.data-grid th:-webkit-any(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid th.sort-ascending > div:first-child::after):
(.data-grid th.sort-descending > div:first-child::after):
(.data-grid td .subtitle):
(.data-grid td .subtitle::before):
(.data-grid:focus tr.selected td .subtitle):
(.data-grid td.error):
(.data-grid tr.selected td.error):
(.data-grid td .icon):
(.data-grid td .go-to-arrow):
(.data-grid tr:-webkit-any(.selected, :hover) .go-to-arrow):

  • UserInterface/Views/DatabaseContentView.css:

(.storage-view):

  • UserInterface/Views/DatabaseTableContentView.css:

(.content-view.database-table > .data-grid):

  • UserInterface/Views/DetailsSection.css:

(.details-section > .content .data-grid):

  • UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:

(.content-view.indexed-database-object-store > .data-grid):

  • UserInterface/Views/LayerTreeDataGridNode.js:

(WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
(WebInspector.LayerTreeDataGridNode.prototype._updateNameCellData):

  • UserInterface/Views/LayerTreeSidebarPanel.css:

(.layer-tree.panel .data-grid):
(.layer-tree.panel .name-column .icon):
(.layer-tree.panel tr.reflection .name-column .icon):
(.layer-tree.panel tr.pseudo-element .name-column .icon):
(.layer-tree.panel .name-column .reflection):
(.layer-tree.panel tr.selected .name-column .reflection):
(.layer-tree.panel .bottom-bar):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar):
(.layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree.panel .bottom-bar > div):
(body.mac-platform.legacy .layer-tree-popover):

  • UserInterface/Views/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel):
(WebInspector.LayerTreeSidebarPanel.prototype._buildLayerInfoSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildDataGridSection):
(WebInspector.LayerTreeSidebarPanel.prototype._buildBottomBar):
(WebInspector.LayerTreeSidebarPanel.prototype._updateMetrics):

  • UserInterface/Views/LegacyJavaScriptProfileView.css:

(.content-view.profile-view > .data-grid):

  • UserInterface/Views/LegacyProfileView.css:
  • UserInterface/Views/LogContentView.css:

(.console-message .bubble):

  • UserInterface/Views/NetworkTimelineView.css:

(.timeline-view.network > .data-grid):

  • UserInterface/Views/OverviewTimelineView.css:

(.timeline-view.overview > .timeline-ruler > .header):
(.timeline-view.overview > .data-grid):

  • UserInterface/Views/OverviewTimelineView.js:
  • UserInterface/Views/ProbeDetailsSidebarPanel.css:

(.details-section.probe-set .options > .probe-add):
(.popover .probe-popover):

  • UserInterface/Views/ProbeSetDataGrid.css:

(.details-section.probe-set .data-grid tr.past-value td):
(.details-section.probe-set .data-grid > td.unknown-value):
(.details-section.probe-set .data-grid tr.revealed.highlighted):
(.details-section.probe-set .data-grid tr.separator):
(.details-section.probe-set .data-grid > tr.data-updated):
(.details-section.probe-set .data-grid .selected .section *):
(.details-section.probe-set .data-grid .selected td.unknown-value):
(.details-section.probe-set .data-grid .section):

  • UserInterface/Views/QuickConsole.css:

(.quick-console):

  • UserInterface/Views/TimelineDataGrid.css:

(.data-grid.timeline th):
(.data-grid.timeline > .navigation-bar-container > .navigation-bar):

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .header):
(.timeline-ruler > .header > .divider):

11:39 AM Changeset in webkit [172398] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JIT should use full 64-bit stores for jsBoolean and jsNull
https://bugs.webkit.org/show_bug.cgi?id=135784

Reviewed by Michael Saboff.

This guarantees that we set the high bits of the register with the correct tag.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_structure_property):
(JSC::JIT::emit_op_next_enumerator_pname):

11:23 AM Changeset in webkit [172397] by Brent Fulgham
  • 8 edits in trunk/Source

[Win] Adjust build script for Windows production build.
https://bugs.webkit.org/show_bug.cgi?id=135806
<rdar://problem/17978299>

Reviewed by Timothy Hatcher.

../JavaScriptCore:

in WebInspectorUI build.

../WebCore:

  • WebCore.vcxproj/copyForwardingHeaders.cmd: Copy file needed

for WebInspectorUI build.

../WebInspectorUI:

  • WebInspectorUI.vcxproj/WebInspectorUI.make: Make sure target for

xcopy operation exists.

  • WebInspectorUI.vcxproj/WebInspectorUI.proj: Don't create directories

we don't need, make sure the target location exists before we build.

  • WebInspectorUI.vcxproj/build-webinspectorui.pl: Make sure that

production builds get the intermediary command files from the
right place.

11:10 AM Changeset in webkit [172396] by Brian Burg
  • 5 edits
    5 adds in trunk

Web Inspector: Add a helper to avoid leaking single-fire event listeners in Promise chains
https://bugs.webkit.org/show_bug.cgi?id=135772

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

A common pattern when working with promise chains is to convert an event
handler into a promise by using a single-fire event listener with the
resolve continuation as the callback. This is fine if the event fires;
if it doesn't fire, then the event emitter permanently keeps a reference to the
this-object and the callback.

This patch adds EventListener, a proxy object for events that can be manipulated
from multiple promise callback functions. If a promise is rejected, the catch
block can disconnect any event listeners set up earlier in the promise chain.

This patch also reimplements EventListenerSet to use multiple EventListeners,
since they share the same logic to uniformly handle Inspector and DOM events.

Test: inspector/event-listener.html
Test: inspector/event-listener-set.html

  • UserInterface/Base/EventListener.js: Added.

(WebInspector.EventListener):
(WebInspector.EventListener.prototype.this._callback):
(WebInspector.EventListener.prototype.connect):
(WebInspector.EventListener.prototype.disconnect):

  • UserInterface/Base/EventListenerSet.js: Update license block.

(WebInspector.EventListenerSet.prototype.register):
(WebInspector.EventListenerSet.prototype.install):
(WebInspector.EventListenerSet.prototype.uninstall):

  • UserInterface/Main.html: Include EventListener.
  • UserInterface/Test.html: Include EventListener and EventListenerSet.

LayoutTests:

  • inspector/event-listener-expected.txt: Added.
  • inspector/event-listener-set-expected.txt: Added.
  • inspector/event-listener-set.html: Added.
  • inspector/event-listener.html: Added.
10:52 AM Changeset in webkit [172395] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[Services with UI] Action menu arrow hit testing is sometimes wrong.
https://bugs.webkit.org/show_bug.cgi?id=135776
<rdar://problem/17837670>

Reviewed by Brady Eidson.

There was a problem in the algorithm that stitches together the selection rectangles
to be given to Data Detectors API.
This change adds a new function that stiches together all the rects contributing to the
first line, all the rects contributing to the last line and all the ones in the middle.
This way we can have a maximum of 3 non overlapping rectangles.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::stitchRects):
(WebKit::compactRectsWithGapRects):

3:40 AM Changeset in webkit [172394] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r172393.
https://bugs.webkit.org/show_bug.cgi?id=135796

discussion needed about GnuTLS version bump on the bots
(Requested by philn on #webkit).

Reverted changeset:

https://bugs.webkit.org/show_bug.cgi?id=133317
http://trac.webkit.org/changeset/172393

3:23 AM Changeset in webkit [172393] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds dependency on GnuTLS 3.0+ for the implementation of subtle crypto algorithms
https://bugs.webkit.org/show_bug.cgi?id=133317

.:

GnuTLS is already an indirect dependency through libsoup -> glib-networking.

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

  • Source/cmake/OptionsGTK.cmake: Adds search for required GnuTLS package

Source/WebCore:

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

No new tests since no new functionality has been added.

  • PlatformGTK.cmake: Adds GnuTLS libs and included dirs to WebCore targets
3:07 AM Changeset in webkit [172392] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix since r172385.

  • PlatformEfl.cmake:
3:04 AM Changeset in webkit [172391] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK] Fix debug build after r172389.

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Rubber-stamped by Philippe Normand.

  • crypto/gtk/CryptoKeyRSAGtk.cpp:

(WebCore::CryptoKeyRSA::exportData): Remove spurious ASSERT from
stub. It will be added back along with the real implementation of
the method.

2:48 AM Changeset in webkit [172390] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed fix after r172348.

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage): Initialize m_minimumSubsamplingLevel to 0.

1:59 AM Changeset in webkit [172389] by commit-queue@webkit.org
  • 6 edits
    11 adds in trunk

[GTK] Adds stubs for all subtle crypto algorithm implemntations
https://bugs.webkit.org/show_bug.cgi?id=133316

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2014-08-11
Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsGTK.cmake: Add ENABLE_SUBTLE_CRYPTO option
  • Source/cmake/WebKitFeatures.cmake: Add ENABLE_SUBTLE_CRYPTO option
  • Source/cmakeconfig.h.cmake: Define ENABLE_SUBTLE_CRYPTO

Source/WebCore:

No new tests since no new functionality has been added.

  • CMakeLists.txt: Add subtle crypto 'algorithms' and 'parameters' dirs to WebCore incuded dirs
  • PlatformGTK.cmake: Add subtle crypto sources to WebCore target
  • crypto/gtk/CryptoAlgorithmAES_CBCGtk.cpp: Added.

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmAES_KWGtk.cpp: Added.

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmHMACGtk.cpp: Added.

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/gtk/CryptoAlgorithmRSAES_PKCS1_v1_5Gtk.cpp: Added.

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmRSASSA_PKCS1_v1_5Gtk.cpp: Added.

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/gtk/CryptoAlgorithmRSA_OAEPGtk.cpp: Added.

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/gtk/CryptoAlgorithmRegistryGtk.cpp: Added.

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/gtk/CryptoDigestGtk.cpp: Added.

(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):

  • crypto/gtk/CryptoKeyRSAGtk.cpp: Added.

(WebCore::CryptoKeyRSA::CryptoKeyRSA):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::~CryptoKeyRSA):
(WebCore::CryptoKeyRSA::restrictToHash):
(WebCore::CryptoKeyRSA::isRestrictedToHash):
(WebCore::CryptoKeyRSA::keySizeInBits):
(WebCore::CryptoKeyRSA::buildAlgorithmDescription):
(WebCore::CryptoKeyRSA::exportData):
(WebCore::CryptoKeyRSA::generatePair):

  • crypto/gtk/SerializedCryptoKeyWrapGtk.cpp: Added.

(WebCore::getDefaultWebCryptoMasterKey):
(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):

  • crypto/keys/CryptoKeyRSA.h:
1:49 AM Changeset in webkit [172388] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.5.2

WebKitGTK+ 2.5.2

1:05 AM Changeset in webkit [172387] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.5.2.
12:29 AM Changeset in webkit [172386] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ make distcheck.

  • gtk/manifest.txt: Remove Source/WebCore/Resources/inputSpeech.png.

Aug 10, 2014:

11:34 PM Changeset in webkit [172385] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] No IPC messages are sent when building WebKitGTK+ with VERSION_SCRIPT
https://bugs.webkit.org/show_bug.cgi?id=135760

Reviewed by Philippe Normand.

The problem is that the threading initialization is failing
because there are two copies of WTF, one in libjavascriptcoregtk
and the other in libwebkit2gtk. When WebKit2 is initialized in the
UI process, JSC::initializeThreading() is called first and then
WTF::initializeMainThread(). The former is calling
ThreadIdentifierData::initializeOnce() initializing the
ThreadIdentifierData::m_key symbol in libjavascriptcoregtk, while
the latter is using the ThreadIdentifierData API from libwebkit2gtk
that hasn't been initialized.

  • CMakeLists.txt: Do not add WTF to the list of WebKit2 libraries,

WebKit2 already depends on JavaScriptCore that already links to WTF.

9:22 PM Changeset in webkit [172384] by commit-queue@webkit.org
  • 2 edits
    1 delete in trunk/Source/WebCore

Remove inputSpeech.png
https://bugs.webkit.org/show_bug.cgi?id=135771

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-08-10
Reviewed by Andreas Kling.

  • Resources/inputSpeech.png: Removed.
  • WebCore.xcodeproj/project.pbxproj:
6:26 PM Changeset in webkit [172383] by timothy_horton@apple.com
  • 9 edits in trunk/Source

Yelp phone number highlights often disappear
https://bugs.webkit.org/show_bug.cgi?id=135789
<rdar://problem/17971057>

Reviewed by Brady Eidson.

Since selectedTelephoneNumberRangesChanged doesn't provide an associated
Frame, an incoming selectedTelephoneNumberRangesChanged from a subframe
would overwrite ServicesOverlayController's cached (and potentially active)
telephone number highlights.

This happens a lot on Yelp, because they have many subframes which are
doing layout on a regular basis.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::selectedTelephoneNumberRangesChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.h:

Adjust to the new (lack of) arguments.

  • WebProcess/WebPage/ServicesOverlayController.h:
  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
Adjust logging; we can revisit it later.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
When building phone number highlights, walk the Frame tree and retrieve
them from all of the Editors.

(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
(WebKit::ServicesOverlayController::telephoneNumberRangesForFocusedFrame):
(WebKit::ServicesOverlayController::determineActiveHighlight):
(WebKit::ServicesOverlayController::handleClick):
Retrieve the detected telephone number ranges from the focused frame
when combining telephone numbers with selection services.
This ensures that we don't show combined phone number highlights from other frames.

  • editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers):
(WebCore::Editor::clearDataDetectedTelephoneNumbers): Deleted.

  • editing/Editor.h:

(WebCore::Editor::detectedTelephoneNumberRanges):

  • page/EditorClient.h:

(WebCore::EditorClient::selectedTelephoneNumberRangesChanged):
Cache and expose detected telephone number ranges on Editor.
Change selectedTelephoneNumberRangesChanged to take no arguments; it's
just a notification now.

6:23 PM Changeset in webkit [172382] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Refactor ServiceOverlayController in preparation for fading between highlights
https://bugs.webkit.org/show_bug.cgi?id=135787
<rdar://problem/17935736>

Reviewed by Brady Eidson.

Rework ServicesOverlayController so that we always keep a set of generic
"potential highlights", which are refcounted Highlight objects and
wrap a DDHighlightRef, as well as a type (Selection or TelephoneNumber),
Range (only used in the case of TelephoneNumber), and potentially more
things in the future (like, say, fade state!).

We eagerly update the list of potential highlights when the selection or set
of detected telephone numbers changes, and use this information to install
or uninstall the page overlay as needed.

When we need to recompute the "active" highlight from this set (for example,
we need to handle a mouse event or paint the highlight), we look through
the set of potential highlights and decide. This moves the "active" highlight
decision logic into one small and confined place.

  • WebProcess/WebPage/ServicesOverlayController.h:

(WebKit::ServicesOverlayController::Highlight):
Add the new aforementioned refcounted Highlight class.
Rename m_lastHoveredHighlightChangeTime to m_lastActiveHighlightChangeTime.
Make m_webPage a reference.
The rest is just added/removed/adjusted functions for the refactoring.

(WebKit::TelephoneNumberData::TelephoneNumberData): Deleted.

  • WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::Highlight::createForSelection):
(WebKit::ServicesOverlayController::Highlight::createForTelephoneNumber):
Create Highlights for the two different highlight types.

(WebKit::ServicesOverlayController::ServicesOverlayController):
(WebKit::ServicesOverlayController::willMoveToWebPage):
Our WebPage pointer is always valid because it owns us; don't clear it.
We need to keep it around so that we can uninstall the overlay and
install it again later, anyway.

(WebKit::ServicesOverlayController::selectionRectsDidChange):
(WebKit::ServicesOverlayController::selectedTelephoneNumberRangesChanged):
When selection rects or detected telephone numbers change, rebuild potential highlights.
This will have the side-effect of installing the overlay if needed.

(WebKit::ServicesOverlayController::mouseIsOverHighlight):
Make this function take a Highlight instead of a DDHighlightRef.

(WebKit::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
Make this function take a Highlight instead of a DDHighlightRef.

(WebKit::ServicesOverlayController::drawHighlight):
Make this function take a Highlight instead of a DDHighlightRef.
There's no reason to do the translation separately from the layer blit,
also allowing us to avoid the StateSaver.

(WebKit::ServicesOverlayController::drawRect):
drawRect now always paints the active highlight, instead of duplicating
logic about which highlight should be active.
Also, it will update the active highlight before painting.
We no longer need to re-determine whether the active highlight's phone
number range is still a valid phone number range, because we rebuild
the potential highlights whenever the set of phone number ranges changes.

(WebKit::ServicesOverlayController::clearActiveHighlight):
Mostly an adoption of new names.

(WebKit::ServicesOverlayController::removeAllPotentialHighlightsOfType):
Run through the list of potential highlights and remove any of the given type.
The two highlight building functions use this helper to clear the old ones before building.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
(WebKit::ServicesOverlayController::buildSelectionHighlight):
Rebuild the list of potential highlights, replacing all highlights of
the given type with new ones.

(WebKit::ServicesOverlayController::hasRelevantSelectionServices):
Factor out the code that decides whether our current selection is
viable for servicing based on whether we have plain-text and/or rich-text services.

(WebKit::ServicesOverlayController::didRebuildPotentialHighlights):
When rebuilding potential highlights, if we have no potential highlights at all,
uninstall the page overlay; we don't need mouse tracking and don't need to
paint anything. This improves memory use and compositing performance significantly,
where previously we were leaving the overlay up forever after creating it.

If we have either detected telephone numbers or relevant selection services,
create and install the overlay if it doesn't already exist.

(WebKit::ServicesOverlayController::createOverlayIfNeeded):
This just moved from elsehwere, except that it now uses FadeMode::DoNotFade.
It doesn't make sense to fade on install/uninstall (which happens even before hover)
but not on changing the active highlight; fading will be re-addressed in the next patch.

(WebKit::ServicesOverlayController::highlightsAreEquivalent):
Determine whether two highlights are equivalent. While we may have
created a new Highlight at rebuild time, if two telephone number
highlights have equivalent ranges, there's no need to 'transition' to the new one.

(WebKit::ServicesOverlayController::determineActiveHighlight):
Run through the list of services, and try to find one that is hovered.
We prefer telephone number highlights to selection highlights, and
we will never make a selection highlight active if it is both
not serviceable and there are no telephone numbers to show in the combined menu.
This is the centralized location for determination of which highlight
should be considered active. If the active highlight changed, update
the time since last change and cancel the mouse-down tracking.

(WebKit::ServicesOverlayController::mouseEvent):
Adjust some comments to be more explanatory.
A bunch of code moved out of here and into determineActiveHighlight.

(WebKit::ServicesOverlayController::handleClick):
Adjust to take a reference and use Highlight instead of DDHighlightRef.

4:35 PM WebInspectorCodingStyleGuide edited by Brian Burg
formatting (diff)
4:32 PM WebInspectorCodingStyleGuide edited by Brian Burg
i promise to document promises (diff)
3:54 PM WebInspectorTests edited by Brian Burg
bugfixes (diff)
3:50 PM WebInspectorTests edited by Brian Burg
add notes about debugging tests; add notes about model tests (diff)
1:12 PM Changeset in webkit [172381] by oliver@apple.com
  • 5 edits in trunk

Destructuring assignment in a var declaration list incorrectly consumes subsequent variable initialisers
https://bugs.webkit.org/show_bug.cgi?id=135773

Reviewed by Michael Saboff.

Source/JavaScriptCore:

We should be using parseAssignment expression in order to get the correct
precedence.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVarDeclarationList):

LayoutTests:

Add new tests.

  • js/destructuring-assignment-expected.txt:
  • js/script-tests/destructuring-assignment.js:
1:07 PM Changeset in webkit [172380] by commit-queue@webkit.org
  • 5 edits in trunk

JSC Lexer is allowing octals 08 and 09 in strict mode functions
https://bugs.webkit.org/show_bug.cgi?id=135704

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-08-10
Reviewed by Oliver Hunt.

Return syntax error ("Decimal integer literals with a leading zero are
forbidden in strict mode") if a number starts with 0 and is followed
by a digit.

  • parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

3:25 AM Changeset in webkit [172379] by timothy@apple.com
  • 12 edits
    3 deletes in trunk/Source

Web Inspector: new glyphs are visible on OS X 10.9 builds
https://bugs.webkit.org/show_bug.cgi?id=135743

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

  • UserInterface/Images/Legacy/UserInputPrompt.svg: Removed.
  • UserInterface/Images/Legacy/UserInputPromptPrevious.svg: Removed.
  • UserInterface/Images/Legacy/UserInputResult.svg: Removed.

Removed images that were not used.

  • UserInterface/Views/DashboardContainerView.css:

(body.mac-platform.legacy .dashboard-container .advance-arrow):

  • UserInterface/Views/DebuggerDashboardView.js:

(WebInspector.DebuggerDashboardView):

  • UserInterface/Views/FolderIcon.css:

(body.mac-platform.legacy .folder-icon .icon):

  • UserInterface/Views/HierarchicalPathComponent.css:

(body.mac-platform.legacy .hierarchical-path-component > .selector-arrows):

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
Use legacy images.

  • UserInterface/Views/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline:focus .item.selected .subtitle):
Fix color for selected subtitle.

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
Use legacy images.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController window]): Use 10100 instead of 1090 for the version.

Source/WebKit2:

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Use 10100 instead of 1090 for the version.

1:45 AM Changeset in webkit [172378] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Update HashTable's operator= after r172167 per review comments

  • wtf/HashTable.h:

Update the type as suggested by Darin.

12:30 AM Changeset in webkit [172377] by Carlos Garcia Campos
  • 4 edits
    1 move in trunk

[GTK] REGRESSION(r166239): The ld version script is not being used
https://bugs.webkit.org/show_bug.cgi?id=135694

Reviewed by Martin Robinson.

.:

Move the symbols filter file from Tools/gtk to Source/cmake and rename
it as gtksymbols.filter. Also updated it, since some of the symbols
exported were renamed.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/gtksymbols.filter: Renamed from Tools/gtk/symbols.filter.

Source/WebKit2:

  • CMakeLists.txt: Add VERSION_SCRIPT to WebKit2 link flags if present.
12:09 AM Changeset in webkit [172376] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Child processes should be installed in a versioned directory
https://bugs.webkit.org/show_bug.cgi?id=135754

Reviewed by Gustavo Noronha Silva.

Define LIBEXEC_INSTALL_DIR as
${CMAKE_INSTALL_FULL_LIBEXECDIR}/webkitgtk-${WEBKITGTK_API_VERSION}
so that the child processes are installed in $libexec/webkitgtk-4.0.
This makes it possible to install 2.6 in parallel to older versions.

  • Source/cmake/OptionsGTK.cmake:
Note: See TracTimeline for information about the timeline view.