Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 18, 2014:

11:12 PM Changeset in webkit [172745] by bshafiei@apple.com

• 3 edits in branches/safari-600.1.4.11-branch/Source/WebCore

Merged r172317. <rdar://problem/18052514>

10:10 PM Changeset in webkit [172744] by commit-queue@webkit.org

• 31 edits
  3 adds in trunk/Source

Unreviewed, rolling out r172736.
​https://bugs.webkit.org/show_bug.cgi?id=136060

Caused 14% PLT regressions (Requested by rniwa on #webkit).

Reverted changeset:

"Remove PurgeableBuffer since it is not very useful any more"
​https://bugs.webkit.org/show_bug.cgi?id=135939
​http://trac.webkit.org/changeset/172736

10:04 PM Changeset in webkit [172743] by dburkart@apple.com

• 5 edits in branches/safari-600.1-branch/Source

Bump versioning

9:41 PM Changeset in webkit [172742] by commit-queue@webkit.org

• 4 edits
  3 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r172741.
​https://bugs.webkit.org/show_bug.cgi?id=136058

This change is breaking PLT. (Requested by mlam on #webkit).

Reverted changeset:

"REGRESSION(r172401): for-in optimization no longer works at
all"
​https://bugs.webkit.org/show_bug.cgi?id=136056
​http://trac.webkit.org/changeset/172741

7:48 PM Changeset in webkit [172741] by fpizlo@apple.com

• 4 edits
  3 adds in trunk/Source/JavaScriptCore

REGRESSION(r172401): for-in optimization no longer works at all
​https://bugs.webkit.org/show_bug.cgi?id=136056

Reviewed by Mark Hahnenberg.

This is a partial roll-out of r172401. It turns out that the fix wasn't actually fixing a
real bug (since it's fine to use op_get_direct_pname on the wrong base because it has a
structure check) and it was actually breaking the entire for-in optimization (since there is
no way that we can statically prove that the base matches, because the base we see is a
newly created temporary, and anyway doing it right would be really hard in our bytecode
because it's 3AC form).

But, I added a new test for the problem, and kept the original test. Both the old test and
the new test prove that r172401 wasn't fixing what it thought it was fixing. To the extent
that it resolved crashes it was because it just disabled the for-in optimization entirely.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::pushIndexedForInScope):
(JSC::BytecodeGenerator::pushStructureForInScope):

• bytecompiler/BytecodeGenerator.h:

(JSC::ForInContext::ForInContext):
(JSC::StructureForInContext::StructureForInContext):
(JSC::IndexedForInContext::IndexedForInContext):
(JSC::ForInContext::base): Deleted.

• bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitMultiLoopBytecode):

• tests/stress/for-in-base-reassigned.js: Added.
• tests/stress/for-in-base-reassigned-later.js: Added.
• tests/stress/for-in-base-reassigned-later-and-change-structure.js: Added.

7:46 PM Changeset in webkit [172740] by benjamin@webkit.org

• 2 edits in trunk/LayoutTests

Mark shape-image-threshold-001.html as crashing in debug

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-08-18

• TestExpectations:

The test css3/shapes/shape-outside/values/shape-image-threshold-001.html systematically assert
in debug. Skip the results until the author investigate.

7:31 PM Changeset in webkit [172739] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Gardening: build fix for non-Mac builds after r172737.
​https://bugs.webkit.org/show_bug.cgi?id=135750

Not reviewed.

• CMakeLists.txt:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:

6:04 PM Changeset in webkit [172738] by Simon Fraser

• 7 edits in trunk/Source

Provide default implementations of all GraphicsLayerClient methods
​https://bugs.webkit.org/show_bug.cgi?id=136054

Reviewed by Tim Horton.
Source/WebCore:

Make none of the functions in GraphicsLayerClient pure virtual, since in many cases
subclasses don't need to provide their own implementations.

• platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::notifyAnimationStarted):
(WebCore::GraphicsLayerClient::notifyFlushRequired):
(WebCore::GraphicsLayerClient::paintContents):

• rendering/RenderLayerCompositor.h:

Source/WebKit2:

Remove overrides which are no longer required.

• WebProcess/WebPage/PageOverlayController.h:
• WebProcess/WebPage/ServicesOverlayController.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

5:55 PM Changeset in webkit [172737] by fpizlo@apple.com

• 15 edits
  2 moves in trunk/Source/JavaScriptCore

REGRESSION(r172129): ftlopt branch merge made performance tests flakey crash
​https://bugs.webkit.org/show_bug.cgi?id=135750

Reviewed by Mark Lam.

This was caused by a rather embarrassing oversight in how the DFG tracks structures: we
could sometimes perform an optimization that requires a structure to be alive but forget to
ensure that the structure is actually kept alive. In particular, any watchpoint-based
optimizations involve setting watchpoints even if the code that got optimized is eventually
deleted because it is unreachable. All such optimizations would leave behind something in
the IR to tell us that we are interested in the structure and that therefore it should be
kept alive. But, IR can be deleted if it is unreachable.

The solution is to ensure that as soon as the DFG is made aware of a structure, it adds it
to the set of weak references.

• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setOSREntryValue):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::normalizeClarity):
(JSC::DFG::AbstractValue::assertIsRegistered):
(JSC::DFG::AbstractValue::assertIsWatched): Deleted.

• dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::assertIsRegistered):
(JSC::DFG::AbstractValue::assertIsWatched): Deleted.

• dfg/DFGCommon.h:
• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

• dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::addLazily):
(JSC::DFG::DesiredWeakReferences::contains):
(JSC::DFG::DesiredWeakReferences::reallyAdd):
(JSC::DFG::DesiredWeakReferences::visitChildren):

• dfg/DFGDesiredWeakReferences.h:
• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::registerFrozenValues):
(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::registerStructure):
(JSC::DFG::Graph::assertIsRegistered):
(JSC::DFG::Graph::assertIsWatched): Deleted.

• dfg/DFGGraph.h:
• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGStructureAbstractValue.cpp:

(JSC::DFG::StructureAbstractValue::assertIsRegistered):
(JSC::DFG::StructureAbstractValue::assertIsWatched): Deleted.

• dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::assertIsRegistered):
(JSC::DFG::StructureAbstractValue::assertIsWatched): Deleted.

• dfg/DFGStructureRegistrationPhase.cpp: Copied from Source/JavaScriptCore/dfg/DFGWatchableStructureWatchingPhase.cpp.

(JSC::DFG::StructureRegistrationPhase::StructureRegistrationPhase):
(JSC::DFG::StructureRegistrationPhase::run):
(JSC::DFG::StructureRegistrationPhase::registerStructures):
(JSC::DFG::StructureRegistrationPhase::registerStructure):
(JSC::DFG::performStructureRegistration):
(JSC::DFG::WatchableStructureWatchingPhase::WatchableStructureWatchingPhase): Deleted.
(JSC::DFG::WatchableStructureWatchingPhase::run): Deleted.
(JSC::DFG::WatchableStructureWatchingPhase::tryWatch): Deleted.
(JSC::DFG::performWatchableStructureWatching): Deleted.

• dfg/DFGStructureRegistrationPhase.h: Copied from Source/JavaScriptCore/dfg/DFGWatchableStructureWatchingPhase.h.
• dfg/DFGWatchableStructureWatchingPhase.cpp: Removed.
• dfg/DFGWatchableStructureWatchingPhase.h: Removed.

4:25 PM Changeset in webkit [172736] by psolanki@apple.com

• 31 edits
  3 deletes in trunk/Source

Remove PurgeableBuffer since it is not very useful any more
​https://bugs.webkit.org/show_bug.cgi?id=135939

Reviewed by Geoffrey Garen.

Source/WebCore:

The usefulness of having purgeable memory for cached resources has diminished now that
WebKit uses file backed resources when possible. Since this is read only memory, it is in
essence "purgeable". Having the PurgeableBuffer code adds additional complexity that we
don't need. e.g. on my Mac, I am not seeing any entry for "WebCore purgeable data" when I
run vmmap against the web processes that I have running. It is used on iOS, however even
there much of the purgeable memory we create gets replaced by file backed memory once we get
the notification from CFNetwork.

No new tests because no functional changes.

• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorPageAgent.cpp:

(WebCore::prepareCachedResourceBuffer):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresource):

• loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::hasPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::setShouldUsePurgeableMemory): Deleted.
(WebCore::ResourceBuffer::createPurgeableBuffer): Deleted.
(WebCore::ResourceBuffer::releasePurgeableBuffer): Deleted.

• loader/ResourceBuffer.h:
• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):

• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::sheetText):
(WebCore::CachedCSSStyleSheet::destroyDecodedData):

• loader/cache/CachedCSSStyleSheet.h:
• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::image):
(WebCore::CachedImage::imageForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
(WebCore::CachedImage::destroyDecodedData):
(WebCore::CachedImage::canUseDiskImageCache):

• loader/cache/CachedImage.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClientToSet):
(WebCore::CachedResource::isSafeToMakePurgeable): Deleted.
(WebCore::CachedResource::makePurgeable): Deleted.
(WebCore::CachedResource::isPurgeable): Deleted.
(WebCore::CachedResource::wasPurged): Deleted.

• loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceBuffer):
(WebCore::CachedResource::purgePriority): Deleted.

• loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):
(WebCore::CachedScript::destroyDecodedData):

• loader/cache/CachedScript.h:
• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::resourceForRequestImpl):
(WebCore::MemoryCache::pruneDeadResourcesToSize):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::TypeStatistic::addResource):
(WebCore::MemoryCache::dumpStats):
(WebCore::MemoryCache::dumpLRULists):
(WebCore::MemoryCache::makeResourcePurgeable): Deleted.

• loader/cache/MemoryCache.h:

(WebCore::MemoryCache::TypeStatistic::TypeStatistic):
(WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction): Deleted.

• platform/PurgePriority.h: Removed.
• platform/PurgeableBuffer.h: Removed.
• platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):
(WebCore::SharedBuffer::size):
(WebCore::SharedBuffer::data):
(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::clear):
(WebCore::SharedBuffer::copy):
(WebCore::SharedBuffer::getSomeData):
(WebCore::SharedBuffer::adoptPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::createPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::releasePurgeableBuffer): Deleted.

• platform/SharedBuffer.h:

(WebCore::SharedBuffer::hasPurgeableBuffer): Deleted.
(WebCore::SharedBuffer::shouldUsePurgeableMemory): Deleted.

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::SharedBuffer):

• platform/mac/PurgeableBufferMac.cpp: Removed.
• platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

• platform/soup/SharedBufferSoup.cpp:

Source/WebKit/mac:

• Misc/WebCache.mm:

(+[WebCache statistics]):

Source/WebKit/win:

• WebCache.cpp:

(WebCache::statistics):

Source/WebKit2:

• WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):

Source/WTF:

• wtf/Platform.h: Remove ENABLE_PURGEABLE_MEMORY define.
• wtf/VMTags.h: Remove VM tags used by WebCore for cached resource purgeable memory.

4:22 PM Changeset in webkit [172735] by psolanki@apple.com

• 2 edits in trunk/Source/WebCore

Use modern for loop instead of iterators in SharedBufferCF.cpp
​https://bugs.webkit.org/show_bug.cgi?id=136000

Reviewed by Andreas Kling.

• platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::copySomeDataFromDataArray):
(WebCore::SharedBuffer::maybeAppendDataArray): Use auto& instead of auto for less RetainPtr/refcount churn.

4:20 PM Changeset in webkit [172734] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix ASSERT in ARM64's JSC::GPRInfo::debugName
​https://bugs.webkit.org/show_bug.cgi?id=136050

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-18
Reviewed by Darin Adler.

Remove cast of GPRReg to unsigned to prevent signed/unsigned comparison
error.

• jit/GPRInfo.h:

(JSC::GPRInfo::debugName):

4:10 PM Changeset in webkit [172733] by commit-queue@webkit.org

• 2 edits
  405 adds in trunk/LayoutTests

[CSS Shapes] Import the CSS Shapes W3C test suite
​https://bugs.webkit.org/show_bug.cgi?id=135921

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2014-08-18
Reviewed by Bem Jones-Bey.

This patch contains the imported CSS Shapes W3C test suite
brought in and converted to WebKit style using
Tools/Scripts/impoart-w3c-tests.

• TestExpectations:
• css3/shapes/shape-outside-invalid-001-expected.txt: Added.
• css3/shapes/shape-outside-invalid-001.html: Added.
• css3/shapes/shape-outside-invalid-circle-000-expected.txt: Added.
• css3/shapes/shape-outside-invalid-circle-000.html: Added.
• css3/shapes/shape-outside-invalid-circle-001-expected.txt: Added.
• css3/shapes/shape-outside-invalid-circle-001.html: Added.
• css3/shapes/shape-outside-invalid-circle-002-expected.txt: Added.
• css3/shapes/shape-outside-invalid-circle-002.html: Added.
• css3/shapes/shape-outside-invalid-circle-003-expected.txt: Added.
• css3/shapes/shape-outside-invalid-circle-003.html: Added.
• css3/shapes/shape-outside-invalid-ellipse-001-expected.txt: Added.
• css3/shapes/shape-outside-invalid-ellipse-001.html: Added.
• css3/shapes/shape-outside-invalid-ellipse-002-expected.txt: Added.
• css3/shapes/shape-outside-invalid-ellipse-002.html: Added.
• css3/shapes/shape-outside-invalid-ellipse-003-expected.txt: Added.
• css3/shapes/shape-outside-invalid-ellipse-003.html: Added.
• css3/shapes/shape-outside-invalid-ellipse-004-expected.txt: Added.
• css3/shapes/shape-outside-invalid-ellipse-004.html: Added.
• css3/shapes/shape-outside-invalid-ellipse-005-expected.txt: Added.
• css3/shapes/shape-outside-invalid-ellipse-005.html: Added.
• css3/shapes/shape-outside-invalid-ellipse-006-expected.txt: Added.
• css3/shapes/shape-outside-invalid-ellipse-006.html: Added.
• css3/shapes/shape-outside-invalid-inset-001-expected.txt: Added.
• css3/shapes/shape-outside-invalid-inset-001.html: Added.
• css3/shapes/shape-outside-invalid-inset-002-expected.txt: Added.
• css3/shapes/shape-outside-invalid-inset-002.html: Added.
• css3/shapes/shape-outside-invalid-inset-003-expected.txt: Added.
• css3/shapes/shape-outside-invalid-inset-003.html: Added.
• css3/shapes/shape-outside-invalid-inset-004-expected.txt: Added.
• css3/shapes/shape-outside-invalid-inset-004.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-002-expected.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-002.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-003-expected.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-003.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-004-expected.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-004.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-006-expected.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-006.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-007-expected.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-007.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-008-expected.html: Added.
• css3/shapes/shape-outside/shape-box/shape-outside-box-008.html: Added.
• css3/shapes/shape-outside/shape-box/w3c-import.log: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-001.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-002.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-003.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-linear-gradient-004.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-001.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-002.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-003.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004-expected.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/shape-outside-radial-gradient-004.html: Added.
• css3/shapes/shape-outside/shape-image/gradients/w3c-import.log: Added.
• css3/shapes/shape-outside/shape-image/shape-image-000-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-000.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-001-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-001.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-002-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-002.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-003-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-003.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-004-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-004.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-005-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-005.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-012-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-012.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-013-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-013.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-014-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-014.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-015-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-015.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-016-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-016.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-017-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-017.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-018-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-018.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-019-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-019.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-020-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-020.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-021-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-021.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-022-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-022.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-023-expected.html: Added.
• css3/shapes/shape-outside/shape-image/shape-image-023.html: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.png: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle-20.svg: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.png: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle-50.svg: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.png: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle-70.svg: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle.jpg: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle.png: Added.
• css3/shapes/shape-outside/shape-image/support/left-half-rectangle.svg: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle-20.png: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle-50.png: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.png: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle-70.svg: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle.gif: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle.jpg: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle.png: Added.
• css3/shapes/shape-outside/shape-image/support/right-half-rectangle.svg: Added.
• css3/shapes/shape-outside/shape-image/support/w3c-import.log: Added.
• css3/shapes/shape-outside/shape-image/w3c-import.log: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-013.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-014.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-015.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-016.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-017.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-018.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-019.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-020.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-021.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-022.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-024.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-025.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-026.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-027.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-028.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-029.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-030.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/shape-outside-circle-031.html: Added.
• css3/shapes/shape-outside/supported-shapes/circle/w3c-import.log: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-013.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-014.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-015.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-016.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-017.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-018.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-019.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-020.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-021.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-022.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-023.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-024.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-025.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-030.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/shape-outside-ellipse-031.html: Added.
• css3/shapes/shape-outside/supported-shapes/ellipse/w3c-import.log: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-010.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-011.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-012.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-013.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-014.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/shape-outside-inset-015.html: Added.
• css3/shapes/shape-outside/supported-shapes/inset/w3c-import.log: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-007.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-008.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-009.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-010.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-011.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-012.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-013.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-014.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-015.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-016.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017-expected.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/shape-outside-polygon-017.html: Added.
• css3/shapes/shape-outside/supported-shapes/polygon/w3c-import.log: Added.
• css3/shapes/shape-outside/supported-shapes/support/rounded-rectangle.js: Added.

(ellipseXIntercept):
(scanConvertRoundedRectangleOutside):
(genLeftRoundedRectFloatShapeOutsideRefTest):
(getRoundedRectLeftEdge):
(genRightRoundedRectFloatShapeOutsideRefTest):

• css3/shapes/shape-outside/supported-shapes/support/subpixel-utils.js: Added.

(SubPixelLayout):
(SubPixelLayout.):

• css3/shapes/shape-outside/supported-shapes/support/test-utils.js: Added.

(verifyTextPoints):

• css3/shapes/shape-outside/values/shape-image-threshold-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-image-threshold-000.html: Added.
• css3/shapes/shape-outside/values/shape-image-threshold-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-image-threshold-001.html: Added.
• css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-image-threshold-002.html: Added.
• css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-image-threshold-003.html: Added.
• css3/shapes/shape-outside/values/shape-margin-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-margin-000.html: Added.
• css3/shapes/shape-outside/values/shape-margin-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-margin-001.html: Added.
• css3/shapes/shape-outside/values/shape-margin-002-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-margin-002.html: Added.
• css3/shapes/shape-outside/values/shape-margin-003-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-margin-003.html: Added.
• css3/shapes/shape-outside/values/shape-margin-004-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-margin-004.html: Added.
• css3/shapes/shape-outside/values/shape-margin-005-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-margin-005.html: Added.
• css3/shapes/shape-outside/values/shape-outside-box-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-box-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-001.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-002-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-002.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-003.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-004-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-004.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-005-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-005.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-006.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-007.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-008.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-009-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-009.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-010-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-010.html: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-011-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-circle-011.html: Added.
• css3/shapes/shape-outside/values/shape-outside-computed-shape-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-computed-shape-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-computed-shape-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-computed-shape-001.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-001.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-002-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-002.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-003.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-004.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-005.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-006.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-007.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-008.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-009-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-009.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-010-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-010.html: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-011-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-ellipse-011.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-001.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-002-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-002.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-003-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-003.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-004-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-004.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-005.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-006.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-007.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-008-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-008.html: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-009-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-inset-009.html: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-001.html: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-002-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-002.html: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-003.html: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-004-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-004.html: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-005-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-005.html: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-006-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-polygon-006.html: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-arguments-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-arguments-001-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-arguments-001.html: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-box-pair-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-inherit-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-inherit-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-initial-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-initial-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-none-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-none-000.html: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-notation-000-expected.txt: Added.
• css3/shapes/shape-outside/values/shape-outside-shape-notation-000.html: Added.
• css3/shapes/shape-outside/values/support/parsing-utils.js: Added.

(ParsingUtils):
(ParsingUtils.):

• css3/shapes/shape-outside/values/support/w3c-import.log: Added.
• css3/shapes/shape-outside/values/w3c-import.log: Added.
• css3/shapes/spec-examples/shape-outside-001-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-001.html: Added.
• css3/shapes/spec-examples/shape-outside-002-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-002.html: Added.
• css3/shapes/spec-examples/shape-outside-003-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-003.html: Added.
• css3/shapes/spec-examples/shape-outside-004-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-004.html: Added.
• css3/shapes/spec-examples/shape-outside-005-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-005.html: Added.
• css3/shapes/spec-examples/shape-outside-006-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-006.html: Added.
• css3/shapes/spec-examples/shape-outside-007-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-007.html: Added.
• css3/shapes/spec-examples/shape-outside-008-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-008.html: Added.
• css3/shapes/spec-examples/shape-outside-010-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-010.html: Added.
• css3/shapes/spec-examples/shape-outside-011-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-011.html: Added.
• css3/shapes/spec-examples/shape-outside-012-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-012.html: Added.
• css3/shapes/spec-examples/shape-outside-013-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-013.html: Added.
• css3/shapes/spec-examples/shape-outside-014-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-014.html: Added.
• css3/shapes/spec-examples/shape-outside-015-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-015.html: Added.
• css3/shapes/spec-examples/shape-outside-016-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-016.html: Added.
• css3/shapes/spec-examples/shape-outside-017-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-017.html: Added.
• css3/shapes/spec-examples/shape-outside-018-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-018.html: Added.
• css3/shapes/spec-examples/shape-outside-019-expected.html: Added.
• css3/shapes/spec-examples/shape-outside-019.html: Added.
• css3/shapes/spec-examples/support/circle-no-shadow.png: Added.
• css3/shapes/spec-examples/support/circle-shadow.png: Added.
• css3/shapes/spec-examples/support/rounded-triangle.svg: Added.
• css3/shapes/spec-examples/support/w3c-import.log: Added.
• css3/shapes/spec-examples/w3c-import.log: Added.
• css3/shapes/w3c-import.log: Added.

3:42 PM Changeset in webkit [172732] by dburkart@apple.com

• 4 edits in branches/safari-600.1-branch

Merged r172680. <rdar://problem/18049780>

3:39 PM Changeset in webkit [172731] by dburkart@apple.com

• 5 edits in branches/safari-600.1-branch/Source/WebKit2

Merged r172660. <rdar://problem/18049780>

3:16 PM Changeset in webkit [172730] by Antti Koivisto

• 9 edits in trunk/Source/WebCore

Tighten RenderCounter typing
​https://bugs.webkit.org/show_bug.cgi?id=136049

Reviewed by Andreas Kling.

RenderObject* -> RenderElement&

• rendering/CounterNode.cpp:

(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::create):
(WebCore::showTreeAndMark):

• rendering/CounterNode.h:

(WebCore::CounterNode::owner):

• rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::parentOrPseudoHostElement):
(WebCore::previousSiblingOrParent):
(WebCore::areRenderersElementsSiblings):
(WebCore::nextInPreOrder):
(WebCore::planCounter):
(WebCore::findPlaceForCounter):
(WebCore::makeCounterNode):
(WebCore::RenderCounter::originalText):
(WebCore::destroyCounterNodeWithoutMapRemoval):
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::RenderCounter::destroyCounterNode):
(WebCore::RenderCounter::rendererRemovedFromTree):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererSubtreeAttached):
(WebCore::RenderCounter::rendererStyleChanged):
(showCounterRendererTree):

• rendering/RenderCounter.h:
• rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):
(WebCore::RenderElement::styleDidChange):
(WebCore::RenderElement::willBeDestroyed):

• rendering/RenderElement.h:

(WebCore::RenderElement::hasCounterNodeMap):
(WebCore::RenderElement::setHasCounterNodeMap):

Move CounterNodeMap to RenderElement from RenderObject.

• rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

• rendering/RenderObject.h:

(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::hasCounterNodeMap): Deleted.
(WebCore::RenderObject::setHasCounterNodeMap): Deleted.

3:03 PM Changeset in webkit [172729] by commit-queue@webkit.org

• 19 edits in trunk/Source

Expose long mouse press WebKit API. Part of 135257 - Add long mouse press gesture
​https://bugs.webkit.org/show_bug.cgi?id=136048

Patch by Peyton Randolph <​prandolph@apple.com> on 2014-08-18
Reviewed by Dan Bernstein.

This patch exposes long mouse press API callbacks in both the injected bundle and on the UI process
through their respective page UI clients. The callbacks are modeled off of the mouseDidMoveOverElement
callback. Like the mouseDidMoveOverElement callback, these callbacks allow the bundle to pass
information to the UI process via a userData out parameter.

Source/WebCore:

• page/Chrome.cpp:

(WebCore::Chrome::didBeginTrackingPotentialLongMousePress): Added.
(WebCore::Chrome::didRecognizeLongMousePress): Added.
(WebCore::Chrome::didCancelTrackingPotentialLongMousePress): Added.

• page/Chrome.h:
• page/ChromeClient.h:

(WebCore::ChromeClient::didBeginTrackingPotentialLongMousePress): Added.
(WebCore::ChromeClient::didRecognizeLongMousePress): Added.
(WebCore::ChromeClient::didCancelTrackingPotentialLongMousePress): Added.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
Pass the press hit test result to kick off the long mouse press.
(WebCore::EventHandler::beginTrackingPotentialLongMousePress): Notify the chrome.
(WebCore::EventHandler::recognizeLongMousePress): Ditto.
(WebCore::EventHandler::cancelTrackingPotentialLongMousePress):
Ditto. Also opportunistically remove a runtime switch check to see if long pressing is enabled. The
runtime switch check was only triggered when long pressing was disabled in the middle of a long press.

• page/EventHandler.h:

Source/WebKit2:

• UIProcess/API/APIUIClient.h:

(API::UIClient::didBeginTrackingPotentialLongMousePress): Added.
(API::UIClient::didRecognizeLongMousePress): Added.
(API::UIClient::didCancelTrackingPotentialLongMousePress): Added.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/API/C/WKPageUIClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::WebPageProxy::didRecognizeLongMousePress): Added.
(WebKit::WebPageProxy::didCancelTrackingPotentialLongMousePress): Added.

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:

(API::InjectedBundle::PageUIClient::didBeginTrackingPotentialLongMousePress): Added.
(API::InjectedBundle::PageUIClient::didRecognizeLongMousePress): Added.
(API::InjectedBundle::PageUIClient::didCancelTrackingPotentialLongMousePress): Added.

• WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
• WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Added.

(WebKit::InjectedBundlePageUIClient::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::InjectedBundlePageUIClient::didRecognizeLongMousePress): Added.
(WebKit::InjectedBundlePageUIClient::didCancelTrackingPotentialLongMousePress): Added.

• WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress): Added.
(WebKit::WebChromeClient::didRecognizeLongMousePress): Added.
(WebKit::WebChromeClient::didCancelTrackingPotentialLongMousePress): Added.

• WebProcess/WebCoreSupport/WebChromeClient.h:

2:44 PM Changeset in webkit [172728] by mitz@apple.com

• 3 edits in trunk/Tools

Added an update-webkit option to override the ../Internal check.
Part of ​https://bugs.webkit.org/show_bug.cgi?id=135815

Reviewed by Tim Horton.

• Scripts/update-webkit:

Added an explicit --internal option to control updating ../Internal, defaulting to whether
../Internal exists.
(runSvnUpdate): Moved to webkitdirs.pm.
(runGitUpdate): Ditto.

• Scripts/webkitdirs.pm:

(runSvnUpdateAndResolveChangeLogs): Moved runSvnUpdate from update-webkit and renamed to this.
(runGitUpdate): Moved from update-webkit.

2:33 PM Changeset in webkit [172727] by akling@apple.com

• 4 edits
  2 adds in trunk

REGRESSION(r168256): JSString can get 8-bit flag wrong when re-using AtomicStrings.
<​https://webkit.org/b/133574>
<rdar://problem/18051847>

Source/JavaScriptCore:

The optimization that resolves JSRopeStrings into an existing
AtomicString (to save time and memory by avoiding StringImpl allocation)
had a bug that it wasn't copying the 8-bit flag from the AtomicString.

This could lead to a situation where a 16-bit StringImpl containing
only 8-bit characters is sitting in the AtomicString table, is found
by the rope resolution optimization, and gives you a rope that thinks
it's all 8-bit, but has a fiber with 16-bit characters.

Resolving that rope will then yield incorrect results.

This was all caught by an assertion, but very hard to reproduce.

Test: js/dopey-rope-with-16-bit-propertyname.html

Reviewed by Darin Adler.

• runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeToAtomicString):
(JSC::JSRopeString::resolveRopeToExistingAtomicString):

• runtime/JSString.h:

(JSC::JSString::setIs8Bit):
(JSC::JSString::toExistingAtomicString):

LayoutTests:

Add a tests that creates a 16-bit AtomicString with only 8-bit characters,
then tiers up into baseline JIT and uses that string as part of a rope-within-a-rope
and serializes that rope to get an incorrect concatenation.

Reviewed by Darin Adler.

• js/dopey-rope-with-16-bit-propertyname-expected.txt: Added.
• js/dopey-rope-with-16-bit-propertyname.html: Added.

2:14 PM Changeset in webkit [172726] by psolanki@apple.com

• 2 edits in trunk/Tools

Make update-webkit more lenient for pure git svn repositories
​https://bugs.webkit.org/show_bug.cgi?id=135805

Reviewed by Oliver Hunt.

Make the call to git fetch be non fatal. If you have a pure git svn repository, then the
call to git fetch will fail and update-webkit will abort. The purpose of r72966 was to
provide an optimization when you have a git repository setup. We should not fail if the
git setup does not have svn-remote.svn.fetch set.

• Scripts/update-webkit:

(runGitUpdate):

2:14 PM Changeset in webkit [172725] by commit-queue@webkit.org

• 6 edits in trunk/Source

Fix unintentional integer overflow before widen
​https://bugs.webkit.org/show_bug.cgi?id=135463

Patch by Przemyslaw Kuczynski <​p.kuczynski@samsung.com> on 2014-08-18
Reviewed by Oliver Hunt.

Overflowing expression is evaluated using operands arithmetic but then is used in
context which expects an wider integer type. To avoid overflow at least one operand
has to be representative of the wider type.

Source/WebCore:

• loader/FTPDirectoryParser.cpp:

(WebCore::parseOneFTPLine): Changed strtoul to strtoull.

• loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::incrementProgress): Added static_cast to long long.

• platform/efl/FileSystemEfl.cpp:

(WebCore::getVolumeFreeSizeForPath): Added static_cast to uint64_t.

Source/WebKit2:

• WebProcess/soup/WebProcessSoup.cpp:

(WebKit::getMemorySize): Added long long literal.

2:11 PM Changeset in webkit [172724] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Fix resource leak in unclosed file descriptor handles
​https://bugs.webkit.org/show_bug.cgi?id=135458

Patch by Przemyslaw Kuczynski <​p.kuczynski@samsung.com> on 2014-08-18
Reviewed by Oliver Hunt.

Leaving descriptor unclosed will cause the resources associated with the open
file description never be freed (they are freed on closing the last descriptor
refering to the underlying file).

• Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector): Closed newStdout descriptor.
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector): Closed m_savedStdout descriptor.

1:58 PM Changeset in webkit [172723] by vivek.vg@samsung.com

• 5 edits
  2 adds in trunk

Implement CanvasRenderingContext2D direction attribute
​https://bugs.webkit.org/show_bug.cgi?id=135878

Reviewed by Darin Adler.

Source/WebCore:

The attribute, 'direction', represents the text directionality.
This is an important attribute for the bi-directional text within the CanvasRenderingContext2D.
The allowed set of values are 'rtl', 'ltr' and 'inherit'.

Specification URL: ​http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#dom-context-2d-direction

Test: fast/canvas/canvas-direction.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::inheritedDirection):
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::reset):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::direction):
(WebCore::CanvasRenderingContext2D::setDirection):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

• html/canvas/CanvasRenderingContext2D.h:
• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

• fast/canvas/canvas-direction-expected.txt: Added.
• fast/canvas/canvas-direction.html: Added.

1:54 PM Changeset in webkit [172722] by commit-queue@webkit.org

• 4 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Introduce an inspector Abstract Syntax Tree.
​https://bugs.webkit.org/show_bug.cgi?id=135763

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-18
Reviewed by Joseph Pecoraro.

This patch adds an Abstract Syntax Tree to the Web inspector.
This syntax tree is modeled off the Esprima.js syntax tree
which complies with the Mozilla Parser API:
​https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Parser_API
Script is the owner of the Web Inspector syntax tree, and has an API
for accessing its syntax tree property.

• UserInterface/External/Esprima/esprima.js:
• UserInterface/Main.html:
• UserInterface/Models/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback):
(WebInspector.Script.prototype._resolveResource):
(WebInspector.Script.prototype._makeSyntaxTree):

• UserInterface/Models/ScriptSyntaxTree.js: Added.

(WebInspector.ScriptSyntaxTree):
(WebInspector.ScriptSyntaxTree.prototype.get parsedSuccessfully):
(WebInspector.ScriptSyntaxTree.prototype.forEachNode):
(WebInspector.ScriptSyntaxTree.prototype.):
(WebInspector.ScriptSyntaxTree.prototype.filter):
(WebInspector.ScriptSyntaxTree.prototype.filterForNodesInRange):
(WebInspector.ScriptSyntaxTree.prototype.filterByRange):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
(WebInspector.ScriptSyntaxTree.prototype.updateTypes):
(WebInspector.ScriptSyntaxTree.prototype._defaultParserState):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._recurseArray):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):

1:52 PM Changeset in webkit [172721] by benjamin@webkit.org

• 11 edits
  6 adds in trunk

The style is not updated correctly when the pseudo class :empty is applied on anything but the rightmost element
​https://bugs.webkit.org/show_bug.cgi?id=135999

Reviewed by Antti Koivisto.

Source/WebCore:

In Element's checkForEmptyStyleChange(), the style invalidation was only considering the invalidation of the element
for which the subtree has changed. When the pseudo class :empty is used with a sibling combinator (e.g. foo:empty+bar),
we were never invalidating the style of the element on which the selector applies.

This patch fixes the issue by invalidating the whole subtree rooted at the parent if the :empty rules applies
to siblings. A new flag "styleOfSiblingsAffectedByEmpty" is introduced to cover this case.

SelectorChecker just sets the flag all the time if any sibling rule exists.
This is overkill but that code is just there for non-jit cases.

SelectorCompiler does a better job and only sets the flag if matching anything else than the rightmost element.
There is a case not optimized, :empty with descendant (e.g. foo:empty>bar). Those cases are useless in practice,
it is not worth optimizing them.

Tests: fast/css/pseudo-element-updates-on-empty.html

fast/selectors/not-empty-adjacent-style-update.html
fast/selectors/not-empty-style-update.html

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::fragmentMatchesTheRightmostElement):
shouldUseRenderStyleFromCheckingContext() is renamed fragmentMatchesTheRightmostElement() because
it is now also used by generateElementIsEmpty() in a context where the Context's style is irrelevant.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsActive):
(WebCore::SelectorCompiler::setStyleOfSiblingsAffectedByEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsFirstChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsHovered):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsLastChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsOnlyChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::shouldUseRenderStyleFromCheckingContext): Deleted.
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmptyAndUpdateRenderStyleIfNecessary): Deleted.

• dom/Element.cpp:

(WebCore::checkForEmptyStyleChange):
(WebCore::Element::setStyleOfSiblingsAffectedByEmpty):
(WebCore::Element::rareDataStyleOfSiblingsAffectedByEmpty):

• dom/Element.h:

(WebCore::Element::styleOfSiblingsAffectedByEmpty):

• dom/ElementRareData.h:

(WebCore::ElementRareData::styleOfSiblingsAffectedByEmpty):
(WebCore::ElementRareData::setStyleOfSiblingsAffectedByEmpty):
(WebCore::ElementRareData::ElementRareData):

LayoutTests:

• fast/css/pseudo-element-updates-on-empty-expected.html: Added.
• fast/css/pseudo-element-updates-on-empty.html: Added.
• fast/selectors/empty-adjacent-style-update-expected.txt:
• fast/selectors/empty-adjacent-style-update.html:
• fast/selectors/empty-style-update-expected.txt:
• fast/selectors/empty-style-update.html:
• fast/selectors/not-empty-adjacent-style-update-expected.txt: Copied from LayoutTests/fast/selectors/empty-adjacent-style-update-expected.txt.
• fast/selectors/not-empty-adjacent-style-update.html: Copied from LayoutTests/fast/selectors/empty-adjacent-style-update.html.
• fast/selectors/not-empty-style-update-expected.txt: Copied from LayoutTests/fast/selectors/empty-style-update-expected.txt.
• fast/selectors/not-empty-style-update.html: Copied from LayoutTests/fast/selectors/empty-style-update.html.

1:41 PM Changeset in webkit [172720] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Mac] Unreviewed merge correction.

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompleteWheelEvent): Revert an
unintended change from r172705.

1:25 PM Changeset in webkit [172719] by aestes@apple.com

• 2 edits in trunk/Source/WebKit/ios

Fix the iOS build after r172709.

• WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

12:52 PM Changeset in webkit [172718] by aestes@apple.com

• 1 edit
  1 delete in trunk/LayoutTests

Remove a test inadvertently landed in r172709.

• fast/loader/redirect-to-invalid-url-using-javascript-disallowed-after-load.html: Removed.

12:11 PM Changeset in webkit [172717] by commit-queue@webkit.org

• 7 edits in trunk/Source/JavaScriptCore

The parser should generate AST nodes the var declarations with no initializers
​https://bugs.webkit.org/show_bug.cgi?id=135545

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-18
Reviewed by Geoffrey Garen.

Currently, JSC's parser ignores variable declarations
that have no assignment initializer value because all
variables are implicitly assigned to undefined. But,
type profiling needs an AST node to be generated for these
empty variable declarations because it needs to be able to
profile their text locations and to see that their type
is undefined.

• bytecompiler/NodesCodegen.cpp:

(JSC::EmptyVarExpression::emitBytecode):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createEmptyVarExpression):

• parser/NodeConstructors.h:

(JSC::EmptyVarExpression::EmptyVarExpression):

• parser/Nodes.h:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVarDeclarationList):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createEmptyVarExpression):

12:07 PM Changeset in webkit [172716] by Bem Jones-Bey

• 2 edits in trunk/Source/WebCore

Small cleanup for ShapeOutsideDeltas
​https://bugs.webkit.org/show_bug.cgi?id=136043

Reviewed by Zoltan Horvath.

Remove explicit initializtion of LayoutUnit members and explicitly
size the boolean flags so they pack properly.

No new tests, no behavior change.

• rendering/shapes/ShapeOutsideInfo.h:

11:55 AM Changeset in webkit [172715] by Simon Fraser

• 2 edits in trunk/Tools

Enable Web Inspector in MiniBrowser WK2 windows
​https://bugs.webkit.org/show_bug.cgi?id=136045

Reviewed by Tim Horton.

Set the pref to enable developer extras for all WK2 windows.

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

11:24 AM Changeset in webkit [172714] by dburkart@apple.com

• 4 edits in tags/Safari-600.1.10.2

Merged r172680. <rdar://problem/18049780>

11:23 AM Changeset in webkit [172713] by dburkart@apple.com

• 5 edits in tags/Safari-600.1.10.2/Source/WebKit2

Merged r172660. <rdar://problem/18049780>

11:21 AM Changeset in webkit [172712] by dburkart@apple.com

• 5 edits in tags/Safari-600.1.10.2/Source

Bump versioning.

11:18 AM Changeset in webkit [172711] by krit@webkit.org

• 20 edits
  2 adds in trunk

calc() doesn't work for SVG CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=136026

Reviewed by Andreas Kling.

Source/WebCore:

Make calc() work on SVG CSS properties as well. stroke-width and
stroke-dashoffset used SVGLength. SVGLength doesn't work together with
cross units length arguments like % and px (just returns 0 in these
cases). I moved these properties over to Length. All modified files
beside to SVGCSSParser are related to this switch.

Test: svg/css/parse-calc-length.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

• css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::svgPropertyValue):

• css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

• css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• rendering/style/RenderStyle.h:
• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setStrokeWidth):
(WebCore::SVGRenderStyle::setStrokeDashOffset):
(WebCore::SVGRenderStyle::strokeWidth):
(WebCore::SVGRenderStyle::strokeDashOffset):
(WebCore::SVGRenderStyle::initialStrokeDashOffset): Deleted.
(WebCore::SVGRenderStyle::initialStrokeWidth): Deleted.

• rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleStrokeData::StyleStrokeData):

• rendering/style/SVGRenderStyleDefs.h:
• rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::strokeWidth):

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::strokeBoundingBox):

• rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::applyStrokeStyleToContext):

• rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeStyle):

• svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::valueForLength):

LayoutTests:

Test calc() on length properties for SVG.

• svg/css/getComputedStyle-basic-expected.txt:
• svg/css/parse-calc-length-expected.txt: Added.
• svg/css/parse-calc-length.html: Added.

10:55 AM Changeset in webkit [172710] by dburkart@apple.com

• 1 copy in tags/Safari-600.1.10.2

Tagging

10:48 AM Changeset in webkit [172709] by aestes@apple.com

• 13 edits
  12 adds
  10 deletes in trunk

REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
​https://bugs.webkit.org/show_bug.cgi?id=136010

Reviewed by Darin Adler.

Source/WebCore:

r167856 caused WebKit to stop scheduling certain kinds of navigations (window.location changes, meta-refresh,
and some calls to window.open) when the request URL is invalid. Adobe.com performs one of these navigations to
an invalid URL with an external scheme (aam:), relying on Safari's navigation policy delegate to ignore the
navigation and launch the external app registered to handle aam: URLs. Since the navigation is no longer
scheduled, the policy delegate is never executed and the external app never launches.

Instead of not scheduling the navigation, allow it to proceed until the client's policy delegate has executed
and made a decision. Only disallow the navigation if the policy delegate told WebKit to proceed with the load.
This exposes these navigations to clients via the policy delegate and via willPerformClientRedirectToURL and
didCancelClientRedirectForFrame on the frame load delegate.

To constrain this check only to the navigation types covered by r167856, only two NavigationSchedulers
(ScheduledRedirect and ScheduledLocationChange) enable the invalid URL check.

Note that r167856 also caused an iOS regression, and this was resolved in r170120 by adding a linked-on-or-after
check and a WebCore setting. Since the iOS regression is also resolved by the approach described above, this
patch reverts r170120 (but keeps some of its tests).

Tests: fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html

fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/window-open-to-invalid-url-disallowed.html

• WebCore.exp.in: Updated the symbol FrameLoader::loadFrameRequest.
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::changeLocation): Added an AllowNavigationToInvalidURL argument; passed down to urlSelected.
(WebCore::FrameLoader::urlSelected): Added an AllowNavigationToInvalidURL argument; passed down to loadFrameRequest.
(WebCore::FrameLoader::loadURLIntoChildFrame): Passed AllowNavigationToInvalidURL::Yes to loadURL.
(WebCore::FrameLoader::loadFrameRequest): Added an AllowNavigationToInvalidURL argument; passed down to loadURL and loadPostRequest.
(WebCore::FrameLoader::loadURL): Added an AllowNavigationToInvalidURL argument; passed down to continueLoadAfterNewWindowPolicy and loadWithNavigationAction.
(WebCore::FrameLoader::loadPostRequest): Ditto.
(WebCore::FrameLoader::load): Passed AllowNavigationToInvalidURL::Yes to continueLoadAfterNewWindowPolicy.
(WebCore::FrameLoader::loadWithNavigationAction): Added an AllowNavigationToInvalidURL argument; passed down to loadWithDocumentLoader.
(WebCore::FrameLoader::loadWithDocumentLoader): Added an AllowNavigationToInvalidURL argument; passed down to continueLoadAfterNavigationPolicy.
(WebCore::FrameLoader::reloadWithOverrideEncoding): Passed AllowNavigationToInvalidURL::Yes to loadWithDocumentLoader.
(WebCore::FrameLoader::reload): Ditto.
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

Added an AllowNavigationToInvalidURL argument; if its value is No and the request's URL is invalid, do not continue.
Added a FIXME about calling clientRedirectCancelledOrFinished on non-quick redirect cancellations.

(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Added an AllowNavigationToInvalidURL argument; passed down to loadWithNavigationAction.
(WebCore::FrameLoader::loadDifferentDocumentItem): Passed AllowNavigationToInvalidURL::Yes to either loadWithDocumentLoader or loadWithNavigationAction.

• loader/FrameLoader.h:
• loader/FrameLoaderTypes.h: Defined AllowNavigationToInvalidURL to have values of Yes and No.
• loader/NavigationScheduler.cpp:

(WebCore::ScheduledRedirect::fire): Passed AllowNavigationToInvalidURL::No to FrameLoader::changeLocation.
(WebCore::ScheduledLocationChange::fire): Ditto.
(WebCore::NavigationScheduler::shouldScheduleNavigation): Removed the URL::isValid check.
(WebCore::NavigationScheduler::scheduleLocationChange): Passed AllowNavigationToInvalidURL::No to FrameLoder::changeLocation during fragment navigations.

• page/ContextMenuController.cpp:

(WebCore::openNewWindow): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.

• page/Settings.in: Removed allowNavigationToInvalidURL.

Source/WebKit/mac:

• Misc/WebKitVersionChecks.h: Removed WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
• WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]): Passed AllowNavigationToInvalidURL::Yes to FrameLoader::loadFrameRequest.

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Reverted the linked-on-or-after check added in r170120 since it's no longer necessary.

LayoutTests:

Removed tests that verified the behavior of setAllowNavigationToInvalidURL(true), which no longer exists:

• fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Removed.
• fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Removed.
• fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Removed.
• fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Removed.

Added tests that verify the policy delegate is executed on some navigations to invalid URLs:

• fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Added.
• fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Added.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Added.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Added.
• fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Added.
• fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Added.

Renamed some existing tests added in r170120, modified them to log willPerformClientRedirectToURL and
didCancelClientRedirectForFrame, and added a test to verify navigations in existing frames via window.open:

• fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt.
• fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript.html.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html.
• fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Added.
• fast/loader/window-open-to-invalid-url-disallowed.html: Added.

10:08 AM Changeset in webkit [172708] by bshafiei@apple.com

• 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

10:08 AM Changeset in webkit [172707] by commit-queue@webkit.org

• 11 edits in trunk

Completed iterator can be revived by adding more than one new entry to the target object
​https://bugs.webkit.org/show_bug.cgi?id=129993

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-08-18
Reviewed by Oliver Hunt.

Source/JavaScriptCore:

When iterator reaches end, finish iterator.

• runtime/JSMapIterator.h:

(JSC::JSMapIterator::finish):

• runtime/JSSetIterator.h:

(JSC::JSSetIterator::finish):

• runtime/MapData.h:

(JSC::MapData::const_iterator::finish): set index of iterator to max
Int32.

• runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototypeFuncNext):

• runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototypeFuncNext):

LayoutTests:

Test a Map or Set iterator should remain dead after using it.

• js/basic-map-expected.txt:
• js/basic-set-expected.txt:
• js/script-tests/basic-map.js:

(set var):
(set map):

• js/script-tests/basic-set.js:

(keys.set keys):
(set add.set add):

10:02 AM Changeset in webkit [172706] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Fix keyTimes list length of from/to/by animations.
​https://bugs.webkit.org/show_bug.cgi?id=136037

Patch by Renata Hodovan <​rhodovan.u-szeged@partner.samsung.com> on 2014-08-18
Reviewed by Darin Adler.

Source/WebCore:

For from/to/by animations, the length of keyTimes and keyPoints
attribute if are specified must be equal and must have at least
2 values.

This is backport of my fix in Blink: ​https://codereview.chromium.org/453243003/

Test: svg/animations/invalid-keytime-number-crash.html

• svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::startedActiveInterval):

LayoutTests:

• svg/animations/invalid-keytime-number-crash-expected.txt: Added.
• svg/animations/invalid-keytime-number-crash.html: Added.

9:51 AM Changeset in webkit [172705] by Brent Fulgham

• 4 edits in trunk/Source/WebCore

[Mac] Follow-up to r136040 based on Darin Adler's comments.

Pass Widget* as a Widget&, since it can never be null.

• page/EventHandler.cpp:

(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
(WebCore::EventHandler::handleWheelEvent):

• page/EventHandler.h:
• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompleteWheelEvent):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):

9:35 AM Changeset in webkit [172704] by Bem Jones-Bey

• 2 edits in trunk/Websites/webkit.org

Remove people that have left Adobe from Security Contact list
​https://bugs.webkit.org/show_bug.cgi?id=135256

Reviewed by Alexey Proskuryakov.

• security/security-group-members.html:

8:54 AM Changeset in webkit [172703] by Brent Fulgham

• 4 edits in trunk/Source/WebCore

[Mac] Gesture scrolls don't work in the WebKit1 clients after scrolling a non-scrollable iFrame
​https://bugs.webkit.org/show_bug.cgi?id=136029
<rdar://problem/17767169>

Reviewed by Maciej Stachowiak.

This is difficult to test in our layout tests, since it relies on specific host application
behavior.

If the platform widget is a frame view (IFrame), and we are in WebKit1, 'passWheelEventToWidget'
has already called 'scrollWheel' on the underlying platform widget. We need to return true in
this case to avoid getting multiple copies of the scrollWheel event sent to the platform widget.

• page/EventHandler.cpp:

(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Revise default stub to
accept a Widget* argument.
(WebCore::EventHandler::handleWheelEvent):

• page/EventHandler.h:
• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent): Check for WK1 case and
return 'true' when the underlying NSScrollView has been issues a scrollWheel event.

3:01 AM Changeset in webkit [172702] by zandobersek@gmail.com

• 1 edit
  1 add in trunk/LayoutTests

Unreviewed GTK gardening. Adding a GTK-specific baseline
that's required after changes in r172620.

• platform/gtk/editing/pasteboard/onpaste-text-html-expected.txt: Added.

2:52 AM Changeset in webkit [172701] by commit-queue@webkit.org

• 3 edits in trunk/Tools

master.cfg should handle special return codes of run-perf-tests
​https://bugs.webkit.org/show_bug.cgi?id=135974

Patch by Renato Nagy <​nagy.renato@stud.u-szeged.hu> on 2014-08-18
Reviewed by Ryosuke Niwa.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunAndUploadPerfTests.getText2):

• BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

(RunAndUploadPerfTestsTest):
(RunAndUploadPerfTestsTest.assertResults):
(RunAndUploadPerfTestsTest.test_tests_failed):
(RunAndUploadPerfTestsTest.test_build_bad_build):
(RunAndUploadPerfTestsTest.test_build_bad_source_json):
(RunAndUploadPerfTestsTest.test_build_bad_marge):
(RunAndUploadPerfTestsTest.test_build_bad_failed_uploading):
(RunAndUploadPerfTestsTest.test_build_bad_preparation):

1:16 AM Changeset in webkit [172700] by g.czajkowski@samsung.com

• 2 edits in trunk/Source/WebKit2

[EFL] ewk_init() is sufficient to initialize EFL components
​https://bugs.webkit.org/show_bug.cgi?id=136036

Reviewed by Gyuyoung Kim.

Developers do not have to initialize EFL components as ewk_init()
already does it.

• UIProcess/API/efl/ewk_intro.h:

12:35 AM Changeset in webkit [172699] by aestes@apple.com

• 8 edits
  1 move
  10 adds
  11 deletes in trunk

Revert r172697.

It made several webarchive layout tests flaky and didn't have the correct behavior for non-quick redirects.

Source/WebCore:

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

• loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation):

• page/Settings.in:

Source/WebKit/mac:

• Misc/WebKitVersionChecks.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

• fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
• fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Added.
• fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
• fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Added.
• fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
• fast/loader/disallow-redirect-to-invalid-url-using-javascript.html: Added.
• fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
• fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html: Added.
• fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Removed.
• fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Removed.
• fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Removed.
• fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Removed.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Removed.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Removed.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Removed.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Removed.
• fast/loader/resources/redirect-to-invalid-url-using-javascript.html: Added.
• fast/loader/resources/redirect-to-invalid-url-using-meta-refresh.html: Added.
• fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Removed.
• fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Removed.
• fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Removed.
• fast/loader/window-open-to-invalid-url-disallowed.html: Removed.

Aug 17, 2014:

11:03 PM Changeset in webkit [172698] by zandobersek@gmail.com

• 4 edits in trunk

[CMake] Optimization-disabling compiler flags should be appended to CMAKE_C(XX)_FLAGS_RELEASE
​https://bugs.webkit.org/show_bug.cgi?id=135980

Reviewed by Martin Robinson.

CMAKE_C(XX)_FLAGS_RELEASE variables usually contain the -On flag which
overrides any other disabled optimization that was prepended to these
variables or was added to the CMAKE_C(XX)_FLAGS variables which CMake
lists first in the final list of compilation flags.

To avoid -On re-enabling optimizations that we'd like to keep disabled,
the specific compiler flags must be appended to CMAKE_C(XX)_FLAGS_RELEASE.

• Source/cmake/OptionsCommon.cmake:
• Source/cmake/OptionsEfl.cmake: Also do the appending with CMAKE_SHARED_LINKER_FLAGS_RELEASE.
• Source/cmake/OptionsGTK.cmake:

9:37 PM Changeset in webkit [172697] by aestes@apple.com

• 8 edits
  12 adds
  10 deletes in trunk

REGRESSION (r167856): adobe.com no longer able to launch Create Cloud app using a URL with a custom scheme
​https://bugs.webkit.org/show_bug.cgi?id=136010

Reviewed by Darin Adler.

Source/WebCore:

r167856 caused WebKit to stop scheduling certain kinds of navigations (window.location changes, meta-refresh,
and some calls to window.open) when the request URL is invalid. Adobe.com performs one of these navigations to
an invalid URL with an external scheme (aam:), relying on Safari's navigation policy delegate to ignore the
navigation and launch the external app registered to handle aam: URLs. Since the navigation is no longer
scheduled, the policy delegate is never executed and the external app never launches.

Instead of not scheduling the navigation, allow it to proceed until the client's policy delegate has executed
and made a decision. Only disallow the navigation if the policy delegate told WebKit to proceed with the load.
This exposes these navigations to clients via the policy delegate and via willPerformClientRedirectToURL and
didCancelClientRedirectForFrame on the frame load delegate.

Note that r167856 also caused an iOS regression, and this was resolved in r170120 by adding a linked-on-or-after
check and a WebCore setting. Since the iOS regression is also resolved by the approach described above, this
patch reverts r170120 (but keeps some of its tests).

Tests: fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html

fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html
fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html
fast/loader/window-open-to-invalid-url-calls-policy-delegate.html
fast/loader/window-open-to-invalid-url-disallowed.html

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Do not continue if the navigation will be a redirect
to an invalid URL.

• loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation): Resumed scheduling navigations to invalid URLs.

• page/Settings.in: Removed the allowNavigationToInvalidURL setting.

Source/WebKit/mac:

Reverted the linked-on-or-after check added in r170120 since it is no longer necessary.

• Misc/WebKitVersionChecks.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

Removed tests that verified the behavior of setAllowNavigationToInvalidURL(true), which no longer exists:

• fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Removed.
• fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Removed.
• fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Removed.
• fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Removed.

Added tests that verify the policy delegate is executed on some navigations to invalid URLs:

• fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate-expected.txt: Added.
• fast/loader/redirect-to-invalid-url-using-javascript-calls-policy-delegate.html: Added.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt: Added.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html: Added.
• fast/loader/window-open-to-invalid-url-calls-policy-delegate-expected.txt: Added.
• fast/loader/window-open-to-invalid-url-calls-policy-delegate.html: Added.

Renamed some existing tests added in r170120, modified them to log willPerformClientRedirectToURL and
didCancelClientRedirectForFrame, and added a test to verify navigations in existing frames via window.open:

• fast/loader/redirect-to-invalid-url-using-javascript-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt.
• fast/loader/redirect-to-invalid-url-using-javascript-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-javascript.html.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-expected.txt: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt.
• fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed.html: Renamed from fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html.
• fast/loader/window-open-to-invalid-url-disallowed-expected.txt: Added.
• fast/loader/window-open-to-invalid-url-disallowed.html: Added.

12:54 PM Changeset in webkit [172696] by Brent Fulgham

• 2 edits in trunk/Tools

[Win] Unreviewed change to force rebuild
(plus drive-by add an accessor I wanted for
some future tooling).

• WinLauncher/WinLauncher.h:

(WinLauncher::webView): Added.

8:35 AM Changeset in webkit [172695] by Brent Fulgham

• 2 edits in trunk/WebKitLibraries

[Win] Unreviewed build fix.

Upload static VS2013 version of WebKitSystemInterface.

• win/lib32/WebKitSystemInterface.lib:

Aug 16, 2014:

3:52 PM Changeset in webkit [172694] by mjs@apple.com

• 3 edits in trunk/Source/WebKit/mac

Remove the obsolete WebKitEnableCoalescedUpdatesPreferenceKey
​https://bugs.webkit.org/show_bug.cgi?id=136024

Reviewed by Filip Pizlo.

• WebView/WebFrameView.mm:

(-[WebFrameView initWithFrame:]): Remove code that respects
this key. It was SPI and is no longer used; also it was
only relevant for versions of OS X that WebKit no longer supports.

• WebView/WebPreferenceKeysPrivate.h: Remove declaration.

1:32 PM Changeset in webkit [172693] by dino@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance
​https://bugs.webkit.org/show_bug.cgi?id=136011

Reviewed by Sam Weinig.

When we render some controls, we need to make sure the NSWindow subclass we
use as the host of the AppKit views identifies itself as the key window (if
the control state is correct). We already have a flag tracking this for
key appearance - just make sure we do the same for isKeyWindow.

• platform/mac/ThemeMac.mm:

(-[WebCoreThemeWindow isKeyWindow]): New override to mirror the static
variable for key appearance.

12:26 PM Changeset in webkit [172692] by fpizlo@apple.com

• 2 edits in trunk/Tools

Update contributors.json for my new email
​https://bugs.webkit.org/show_bug.cgi?id=136021

Patch by Mark Hahnenberg <​mhahnenb@gmail.com> on 2014-08-16
Reviewed by Filip Pizlo.

• Scripts/webkitpy/common/config/contributors.json:

12:01 PM Changeset in webkit [172691] by psolanki@apple.com

• 3 edits
  2 moves in trunk/Source/WebKit2

Rename DiskCacheMonitor to NetworkDiskCacheMonitor
​https://bugs.webkit.org/show_bug.cgi?id=135897

Reviewed by Andreas Kling.

In preparation for moving DiskCacheMonitor code to WebCore in bug 135896, rename the WebKit2
class to NetworkDiskCacheMonitor.

• NetworkProcess/mac/NetworkDiskCacheMonitor.h: Renamed from Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.h.

(WebKit::NetworkDiskCacheMonitor::resourceRequest):

• NetworkProcess/mac/NetworkDiskCacheMonitor.mm: Renamed from Source/WebKit2/NetworkProcess/mac/DiskCacheMonitor.mm.

(WebKit::NetworkDiskCacheMonitor::monitorFileBackingStoreCreation):
(WebKit::NetworkDiskCacheMonitor::NetworkDiskCacheMonitor):
(WebKit::NetworkDiskCacheMonitor::messageSenderConnection):
(WebKit::NetworkDiskCacheMonitor::messageSenderDestinationID):

• NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::willCacheResponseAsync):

• WebKit2.xcodeproj/project.pbxproj:

7:26 AM Changeset in webkit [172690] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

[GTK] build fails with error: cannot allocate an object of abstract type 'WebKit::PageClientImpl'
​https://bugs.webkit.org/show_bug.cgi?id=136017

Patch by Byungseon Shin <​sun.shin@lge.com> on 2014-08-16
Reviewed by Gyuyoung Kim.

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):

• UIProcess/API/gtk/PageClientImpl.h:

2:25 AM Changeset in webkit [172689] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve performance of selection range changes viewing Scripts timeline
​https://bugs.webkit.org/show_bug.cgi?id=136015

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-16
Reviewed by Timothy Hatcher.

• UserInterface/Base/Utilities.js:

(clamp):
Helper function to clamp a value between a min and max.

• UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode.prototype.get startTime):
(WebInspector.ProfileNode.prototype.get endTime):
These can be quickly calculated, so avoid full calculation to grab the values.

• UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.updateLayout):
Update ranges with a smart helper, instead of blindly doing it and needing refresh.

• UserInterface/Views/ProfileNodeDataGridNode.js:

(WebInspector.ProfileNodeDataGridNode.prototype.get rangeEndTime):
(WebInspector.ProfileNodeDataGridNode.prototype.get data):
(WebInspector.ProfileNodeDataGridNode.prototype.updateRangeTimes):
(WebInspector.ProfileNodeDataGridNode.prototype.set rangeStartTime): Deleted.
(WebInspector.ProfileNodeDataGridNode.prototype.set rangeEndTime): Deleted.

• UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
(WebInspector.ScriptTimelineDataGridNode.prototype.set rangeStartTime): Deleted.
(WebInspector.ScriptTimelineDataGridNode.prototype.set rangeEndTime): Deleted.
When updating the range selection, compare to the last range selection
on this DataGridNode. If the visible portion of this node's time range
changes, we need a refresh. Otherwise, we don't need a refresh.

Aug 15, 2014:

10:49 PM Changeset in webkit [172688] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Update Scripts/update-LegacyInspectorBackendCommands.rb for the new generator
​https://bugs.webkit.org/show_bug.cgi?id=136006

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-15
Reviewed by Timothy Hatcher.

• Scripts/update-LegacyInspectorBackendCommands.rb:

Use the new generator and pass the appropriate flags.

• UserInterface/Protocol/Legacy/6.0/InspectorWebBackendCommands.js:
• UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:

Newly generated files using the new generator.

• Versions/Inspector-iOS-6.0.json:

Remove unsupported features.

9:38 PM Changeset in webkit [172687] by Brian Burg

• 12 edits in trunk/Source/JavaScriptCore

Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
​https://bugs.webkit.org/show_bug.cgi?id=131596

Unreviewed gardening to rebaseline inspector generator tests after addressing review comments.

• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
• inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
• inspector/scripts/tests/expected/type-declaration-array-type.json-result:
• inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
• inspector/scripts/tests/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

9:36 PM Changeset in webkit [172686] by Brian Burg

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for some GTK bots after r172655.

Some bots use Python 2.6, which lacks the 'flags' named parameter for re.sub.

• inspector/scripts/codegen/generator.py:

(Generator.stylized_name_for_enum_value): Do things the old-school way.

9:35 PM Changeset in webkit [172685] by ryuan.choi@samsung.com

• 3 edits
  1 add in trunk/Source/WebKit2

[EFL] Add ewk_intro.h to describe main page of doxygen
​https://bugs.webkit.org/show_bug.cgi?id=136013

Reviewed by Gyuyoung Kim.

• PlatformEfl.cmake:
• UIProcess/API/efl/EWebKit2.h.in:
• UIProcess/API/efl/ewk_intro.h: Added.

9:21 PM Changeset in webkit [172684] by matthew_hanson@apple.com

• 3 edits in branches/safari-600.1-branch/WebKitLibraries

Merge r172661. <rdar://problem/18037766>

9:19 PM Changeset in webkit [172683] by matthew_hanson@apple.com

• 6 edits in branches/safari-600.1-branch

Merge r172019. <rdar://problem/18029617>

9:05 PM Changeset in webkit [172682] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove forced layouts during recording caused by striped background element resizing
​https://bugs.webkit.org/show_bug.cgi?id=136009

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-15
Reviewed by Timothy Hatcher.

We used to manually resize and a custom striped background behind
the timeline tree outline content area. This can happen frequently
during timeline recordings causing forced layouts. We can eliminate
the hack and instead put the stripe background on the tree outline.

• UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.updateCustomContentOverflow): Deleted.

• UserInterface/Views/TimelineSidebarPanel.css:

(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .content .item > .status > .status-button):
(.sidebar > .panel.navigation.timeline > .content > .stripe-background): Deleted.
(.sidebar > .panel.navigation.timeline.timeline-content-view-showing > .content > .stripe-background): Deleted.
Eliminate the striped background element.

• UserInterface/Views/TimelineView.css:

(.panel.navigation.timeline > .content > .navigation-sidebar-panel-content-tree-outline):
(.panel.navigation.timeline.timeline-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
Give the timeline content tree outlines the striped background.

• UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype._updateContentOverflowShadowVisibility):
(WebInspector.NavigationSidebarPanel.prototype.updateCustomContentOverflow): Deleted.
Remove the now unused updateCustomContentOverflow method.

9:03 PM Changeset in webkit [172681] by Alan Bujtas

• 19 edits in trunk/Source

Do not use FloatRect::infiniteRect() to flag full repaints.
​https://bugs.webkit.org/show_bug.cgi?id=135900

Reviewed by Simon Fraser.

Converting FloatRect::infiniteRect() to IntRect leads to value overflow
and we end up with invalid repaint rectangle. Use a boolean flag to indicate
full repaint request.

Covered by existing tests.

Source/WebCore:

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):
(WebCore::GraphicsLayerCA::repaintLayerDirtyRects):

• platform/graphics/ca/GraphicsLayerCA.h:
• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::setTileNeedsDisplayInRect):

• platform/graphics/ca/mac/PlatformCALayerMac.h:
• platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::setNeedsDisplay):
(PlatformCALayerMac::setNeedsDisplayInRect):

Source/WebKit2:

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemote::setNeedsDisplay):

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
• WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:

(WebKit::PlatformCALayerRemoteCustom::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemoteCustom::setNeedsDisplay):

• WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:

(WebKit::PlatformCALayerRemoteTiledBacking::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemoteTiledBacking::setNeedsDisplay):

• WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:

7:57 PM Changeset in webkit [172680] by ap@apple.com

• 4 edits in trunk

REGRESSION (r172660): WebKit2.TerminateTwice asserts
​https://bugs.webkit.org/show_bug.cgi?id=136012

Source/WebKit2:

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::terminateProcess):

Added bug number to a fixme.

Tools:

• TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Skipped the test in debug mode.

7:49 PM Changeset in webkit [172679] by benjamin@webkit.org

• 6 edits in trunk/Source/WebCore

Unify the modes style resolution modes SharingRules and StyleInvalidation
​https://bugs.webkit.org/show_bug.cgi?id=135969

Reviewed by Andreas Kling.

Unifying the Collector and SelectorCheckers was done in previous patches,
this is just removing the enums.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):

• css/SelectorChecker.h:
• css/StyleInvalidationAnalysis.cpp:

(WebCore::invalidateStyleRecursively):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):

7:32 PM Changeset in webkit [172678] by ryuan.choi@samsung.com

• 4 edits in trunk/Source/WebKit2

Unreviewed build fix on the EFL port since r172635

• UIProcess/WebPageProxy.cpp: Guard removeNavigationGestureSnapshot with PLATFORM(MAC) macro.
• UIProcess/WebPageProxy.h: Ditto.
• UIProcess/efl/WebViewEfl.h: Added didFirstVisuallyNonEmptyLayoutForMainFrame and didFinishLoadForMainFrame as dummy.

7:25 PM Changeset in webkit [172677] by matthew_hanson@apple.com

• 3 edits in tags/Safari-600.1.10.1/WebKitLibraries

Merge r172661. <rdar://problem/18037766>

7:23 PM Changeset in webkit [172676] by matthew_hanson@apple.com

• 6 edits in tags/Safari-600.1.10.1

Merge r172019. <rdar://problem/18029617>

7:14 PM Changeset in webkit [172675] by matthew_hanson@apple.com

• 5 edits in tags/Safari-600.1.10.1/Source

Versioning.

7:11 PM Changeset in webkit [172674] by matthew_hanson@apple.com

• 1 delete in tags/Safari-600.1.2.10.1

Delete Tag.

7:10 PM Changeset in webkit [172673] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.10.1

New Tag.

7:09 PM Changeset in webkit [172672] by ryuan.choi@samsung.com

• 2 edits in trunk/Tools

Unreviewed build fix attempt on the CMake based pots since r172665

• TestWebKitAPI/CMakeLists.txt: Added JavaScriptCore/interpreter to the include list.

7:05 PM Changeset in webkit [172671] by matthew_hanson@apple.com

• 3 edits in tags/Safari-600.1.2.10.1/WebKitLibraries

Merge r172661. <rdar://problem/18037766>

7:03 PM Changeset in webkit [172670] by matthew_hanson@apple.com

• 1 edit in tags/Safari-600.1.2.10.1/WebKitLibraries/ChangeLog

Merge r172019. <rdar://problem/18029617>

6:59 PM Changeset in webkit [172669] by matthew_hanson@apple.com

• 5 edits in tags/Safari-600.1.2.10.1/Source

Versioning.

6:54 PM Changeset in webkit [172668] by matthew_hanson@apple.com

• 1 delete in tags/Safari-600.1.10.1

Delete tag.

6:52 PM Changeset in webkit [172667] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.2.10.1

New Tag.

6:47 PM Changeset in webkit [172666] by matthew_hanson@apple.com

• 5 edits in tags/Safari-600.1.10.1/Source

Versioning.

6:45 PM Changeset in webkit [172665] by msaboff@apple.com

• 28 edits
  1 add in trunk/Source/JavaScriptCore

Change callToJavaScript and callToNativeFunction so their callFrames match the native calling conventions
​https://bugs.webkit.org/show_bug.cgi?id=131578

Reviewed by Geoffrey Garen.

Renamed callToJavaScript and callToNativeFunction to vmEntryToJavaScript and vmEntryToNative,
respectively. Eliminated the sentinel frame and replaced it with the structure VMEntryRecord
that appears in the "locals" area of a VM entry stack frame. Changed the order that
vmEntryToJavaScript and vmEntryToNative creates their stack frames to be native calling
convention compliant. That is to save prior frame pointer, save callee save registers, then
allocate and populate the VMEntryRecord, and finally allocate a CallFrame for the JS function
that vmEntryToJavaScript will invoke. The top most vm entry frame pointer is saved in
VM::topVMEntryFrame. The vmEntry functions save prior contents of VM::topVMEntryFrame
along with the VM and VM::topCallFrame in the VMEntryRecord it places on the stack. Starting
at VM::topCallFrame, the stack can be walked using these VMEntryRecords.

Arbitrary stack unwinding is now handled either iteratively by loading VM::topVMEntryFrame
into a local variable and using CallFrame::callerFrame(VMEntryFrame*&) or by using StackVisitor.
Given that the stack is effectively a singly linked list, general stack unwinding needs to use
one of these two methods.

• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:

Addition of VMEntryRecord.h

• bytecode/BytecodeList.json:

Renaming of llint helper opcodes due to renaming callToJavaScript and callToNativeFunction.

• debugger/Debugger.cpp:

(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::returnEvent):
(JSC::Debugger::didExecuteProgram):

• jsc.cpp:

(functionDumpCallFrame):

• jit/JITOperations.cpp:

Changed unwinding to use CallFrame::callerFrame(VMEntryFrame*&).

• bytecode/CodeBlock.cpp:

(JSC::RecursionCheckFunctor::RecursionCheckFunctor):
(JSC::RecursionCheckFunctor::operator()):
(JSC::RecursionCheckFunctor::didRecurse):
(JSC::CodeBlock::noticeIncomingCall):

• debugger/DebuggerCallFrame.cpp:

(JSC::FindCallerMidStackFunctor::FindCallerMidStackFunctor):
(JSC::FindCallerMidStackFunctor::operator()):
(JSC::FindCallerMidStackFunctor::getCallerFrame):
(JSC::DebuggerCallFrame::callerFrame):

• interpreter/VMInspector.cpp:

(JSC::CountFramesFunctor::CountFramesFunctor):
(JSC::CountFramesFunctor::operator()):
(JSC::CountFramesFunctor::count):
(JSC::VMInspector::countFrames):

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::FindFirstCallerFrameWithCodeblockFunctor):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::operator()):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::foundCallFrame):
(JSC::FindFirstCallerFrameWithCodeblockFunctor::index):
(JSC::VM::throwException):
Changed unwinding to use StackVisitor including added functor classes.

• interpreter/CallFrame.cpp:

(JSC::CallFrame::callerFrame):
Added new flavor of callerFrame() that can iteratively unwind the stack.

• interpreter/CallFrame.h:

(JSC::ExecState::callerFrame): Changed callerFrame() to use private common helper.
(JSC::ExecState::callerFrameOrVMEntryFrame): Deleted.
(JSC::ExecState::isVMEntrySentinel): Deleted.
(JSC::ExecState::vmEntrySentinelCallerFrame): Deleted.
(JSC::ExecState::initializeVMEntrySentinelFrame): Deleted.
(JSC::ExecState::callerFrameSkippingVMEntrySentinel): Deleted.
(JSC::ExecState::vmEntrySentinelCodeBlock): Deleted.

• interpreter/CallFrame.h:

(JSC::ExecState::init):
(JSC::ExecState::topOfFrame):
(JSC::ExecState::currentVPC):
(JSC::ExecState::setCurrentVPC):
Eliminated unneded checking of sentinel frame.

• interpreter/Interpreter.cpp:

(JSC::unwindCallFrame):
(JSC::Interpreter::getStackTrace): Updated for unwidning changes.
(JSC::Interpreter::unwind): Eliminated unneeded sentinel frame check.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

• jit/JITStubs.h:
• llint/LLIntThunks.cpp:

(JSC::callToJavaScript): Deleted.
(JSC::callToNativetion): Deleted.
(JSC::vmEntryToJavaScript):
(JSC::vmEntryToNative):

• llint/LLIntThunks.h:

Updated for vmEntryToJavaScript and vmEntryToNative name changes.

• interpreter/Interpreter.h:

(JSC::TopCallFrameSetter::TopCallFrameSetter):
(JSC::TopCallFrameSetter::~TopCallFrameSetter):
Eliminated unneeded sentinel frame check.

• interpreter/Interpreter.h:

(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
Removed sentinel specific constructor.

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::StackVisitor):
(JSC::StackVisitor::readFrame):
(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::readInlinedFrame):
(JSC::StackVisitor::Frame::print):

• interpreter/StackVisitor.h:

(JSC::StackVisitor::Frame::callerIsVMEntry):
Changes for unwinding using CallFrame::callerFrame(VMEntryFrame*&). Also added field that
indicates when about to step over a VM entry frame.

• interpreter/VMEntryRecord.h: Added.

(JSC::VMEntryRecord::prevTopCallFrame):
(JSC::VMEntryRecord::prevTopVMEntryFrame):
New struct to record prior state of VM's notion of VM entry and top call frames.

• jit/JITCode.cpp:

(JSC::JITCode::execute):
Use new vmEntryToJavaScript and vmEntryToNative name.

• llint/LLIntOffsetsExtractor.cpp: Added include for VMEntryRecord.h.

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

Offline assembly implementation of creating stack frame with VMEntryRecord and well as restoring
relevent VM fields when exiting the VM. Added a helper that returns a VMEntryRecord given
a pointer to the VM entry frame.

• llint/LLIntThunks.cpp:

(JSC::vmEntryRecord):

• llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):
C Loop changes to mirror the assembly changes.

• runtime/VM.h:

Added topVMEntryFrame field.

6:39 PM Changeset in webkit [172664] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.10.1

New Tag.

6:37 PM Changeset in webkit [172663] by benjamin@webkit.org

• 4 edits in trunk/Source/WebCore

CSS JIT: compile :-webkit-full-page-media
​https://bugs.webkit.org/show_bug.cgi?id=135968

Reviewed by Alexey Proskuryakov.

Add the pseudo class :-webkit-full-page-media with an unoptimized function call.

It would be possible to inline it, but this selector is so uncommon I don't think
it is worth having any additional complexity for it.

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

• css/SelectorCheckerTestFunctions.h:

(WebCore::isMediaDocument):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

5:56 PM Changeset in webkit [172662] by jonowells@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Inspect Element doesn't always highlight the correct element when inspector is closed before inspecting
​https://bugs.webkit.org/show_bug.cgi?id=135995

Reviewed by Joseph Pecoraro.

Change so if an element is inspected via the Inspect Element context menu, selected
node restoration is disallowed until the main resource in the main frame changes.
This way an attempt by a sub-frame will not change the highlighted element in the
Main Frame's DOM tree unexpectedly.

• UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._mainResourceDidChange):
(WebInspector.DOMTreeManager.prototype.inspectElement):

5:42 PM Changeset in webkit [172661] by Brent Fulgham

• 3 edits in trunk/WebKitLibraries

[Win] Link to static VS2013 runtime library.
​https://bugs.webkit.org/show_bug.cgi?id=136007
<rdar://problem/18037766>

Reviewed by Dean Jackson.

• win/tools/vsprops/common.props: Update link command.
• win/tools/vsprops/debugsuffix.props: Ditto.

4:56 PM Changeset in webkit [172660] by ap@apple.com

• 5 edits in trunk/Source/WebKit2

Improve page to process relationship tracking
​https://bugs.webkit.org/show_bug.cgi?id=135996
<rdar://problem/16991213>

Reviewed by Sam Weinig.

• UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::removeAll):
(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkProvider::sendTable):
Added assertions for m_processes only having valid entries.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess): When attaching to a new process,
tell the old process that the page is not longer associated with it, avoiding
a potential stale pointer.
If re-attached to an existing process, make sure that we perform all the same
registrations as after having launched a new process. This substantially improves
the behavior when the number of open tabs is over process limit.
(WebKit::WebPageProxy::reattachToWebProcessWithItem): Added ASSERT(!isValid())
to avoid confusion. All other calls to reattachToWebProcess() have this as a
runtime check, but reattachToWebProcessWithItem() is only called for valid pages.
(WebKit::WebPageProxy::terminateProcess): Added an assertion with a FIXME for
something that will need to be fixed another day.

• UIProcess/WebPageProxy.h: Removed an unimplemented function.

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addExistingWebPage): Added assertions for page map sanity.
(WebKit::WebProcessProxy::removeWebPage): Added a check for page state being Terminated
already. This avoids an assertion failure that happened under the new call to
removeWebPage() in reattachToWebProcess(), as we are now calling it for terminated
processes that are not in WebContext::m_processes any more.
(WebKit::WebProcessProxy::didFinishLaunching): Added an assertion that page agrees
about using this process.

4:35 PM Changeset in webkit [172659] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Fix gliding in AxisScrollSnapAnimator for Mac
​https://bugs.webkit.org/show_bug.cgi?id=135971

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-15
Reviewed by Dean Jackson.

Previously, momentum events that are handled immediately after finishing a glide animation cause a second, extremely
slow glide animation to trigger. To fix this, I added a new state DestinationReached. During this state, additional
momentum events that are handled after the glide animation completes will not fill up the momentum window and trigger
a second glide event.

• platform/mac/AxisScrollSnapAnimator.h:
• platform/mac/AxisScrollSnapAnimator.mm:

(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
(WebCore::AxisScrollSnapAnimator::handleWheelEvent):
(WebCore::AxisScrollSnapAnimator::scrollSnapAnimationUpdate):
(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::computeGlideDelta):

4:19 PM Changeset in webkit [172658] by dbates@webkit.org

• 2 edits in trunk/Source/WebKit/mac

[iOS] Teach postprocess-headers.sh to remove code guarded by ENABLE_IOS_GESTURE_EVENTS
and ENABLE_TOUCH_EVENTS if applicable
​https://bugs.webkit.org/show_bug.cgi?id=135993

Reviewed by Andy Estes.

Add support infrastructure to remove code from public and private API headers that is
guarded by macro define ENABLE_{IOS_GESTURE, TOUCH}_EVENTS when these features are disabled.

We aren't using this functionality yet, but we will soon.

• postprocess-headers.sh:

4:09 PM Changeset in webkit [172657] by eric.carlson@apple.com

• 16 edits in trunk/Source/WebCore

[MSE] Implement a maximum buffer size for SourceBuffer
​https://bugs.webkit.org/show_bug.cgi?id=135614

Reviewed by Jer Noble.

Implement the MSE coded frame eviction algorithm: when new buffers are appended attempt
to keep the amount of data buffered below a maximum size (which is determined by the media
session manager) by freeing coded frames as follows:

1 - Free frames in 30 second chunks from 0 to 30 seconds before the current time.
2 - If there are time ranges after the range with the current time, free frames in

30 second chunks from duration back to the beginning of the time range after
current time.

For now we DO NOT throw a QUOTA_EXCEEDED_ERR when we are not able to free up enough
space to remain below the prescribed quota, because some big name, widely deployed,
code bases ignore the error and continue appending data as though the failed append
succeeded, leading to a corrupted bitstream and failure to play.

• Modules/mediasource/SampleMap.cpp:

(WebCore::SampleMap::addSample): Drive-by performance optimization: sample->presentationTime()

is used more than once, stash it in a local variable.

(WebCore::SampleMap::removeSample): Ditto.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::logRanges): Debug-only function to log TimeRanges.
(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::remove): Optimize logging. Buffer full and coded frame eviction logic

is in SourceBuffer instead of SourceBufferPrivate.

(WebCore::SourceBuffer::appendBufferInternal): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete): Set m_bufferFull when more data

has been buffered than allowed.

(WebCore::removeSamplesFromTrackBuffer): Add logging.
(WebCore::SourceBuffer::removeCodedFrames): Improve logging. Avoid debug build assert when

current time is after last enqueued presentation time.

(WebCore::SourceBuffer::evictCodedFrames): The coded frame eviction algorithm.
(WebCore::SourceBuffer::maximumBufferSize): Return the maximum amount of data that can

be buffered.

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Improve logging. Don't attempt

to create a PlatformTimeRanges with inverted start and end to avoid an assert in debug.

(WebCore::SourceBuffer::hasAudio): New, return true if there are any audio tracks.
(WebCore::SourceBuffer::hasVideo): New, return true if there are any video tracks.
(WebCore::SourceBuffer::sourceBufferPrivateHasAudio): Call hasAudio.
(WebCore::SourceBuffer::sourceBufferPrivateHasVideo): Call hasVideo.
(WebCore::SourceBuffer::hasCurrentTime): Return true if currentTime is greater than duration.
(WebCore::SourceBuffer::hasFutureTime): Ditto.
(WebCore::SourceBuffer::extraMemoryCost): Return the amount of data buffered: the size of

the input buffer plus the size of all track samples.

(WebCore::SourceBuffer::reportExtraMemoryCost): Move buffered size calculation to extraMemoryCost.
(WebCore::SourceBuffer::document): Document accessor.

• Modules/mediasource/SourceBuffer.h: Drive-by size optimization by moving all bool member

variables to the end of class.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::refreshCachedTime): Drive-by removal of overly chatty logging.
(WebCore::HTMLMediaElement::maximumSourceBufferSize): New, maximum source buffer size.

• html/HTMLMediaElement.h:

• html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::maximumMediaSourceBufferSize): New, get maximum source buffer

size from settings, return full amount for an SourceBuffer with video and audio, return 5%
of the maximum for an audio-only SourceBuffer.

• html/HTMLMediaSession.h:

• page/Settings.in: Add maximumSourceBufferSize. Default value is enough for approximately

five minutes of 1080p video and stereo audio.

• platform/graphics/PlatformTimeRanges.cpp:

(WebCore::PlatformTimeRanges::totalDuration): Drive-by optimization.
(WebCore::PlatformTimeRanges::dump): New, allow a PlatformTimeRanges to be printed.

• platform/graphics/PlatformTimeRanges.h:

• platform/graphics/SourceBufferPrivate.h: Delete evictCodedFrames and isFull, that logic

is not in SourceBuffer.

• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
• platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame): Drive-by logging fix.
(WebCore::SourceBufferPrivateAVFObjC::evictCodedFrames): Deleted.
(WebCore::SourceBufferPrivateAVFObjC::isFull): Deleted.

• platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::evictCodedFrames): Deleted.
(WebCore::MockSourceBufferPrivate::isFull): Deleted.

• platform/mock/mediasource/MockSourceBufferPrivate.h:

3:43 PM Changeset in webkit [172656] by Alan Bujtas

• 6 edits
  2 adds in trunk

REGRESSION: Parts of the route/route options windows are invisible at maps.google.com
​https://bugs.webkit.org/show_bug.cgi?id=135977
<rdar://problem/17961698>

Reviewed by Andreas Kling.

When the style change requires both layout and repaint, the style diff is set to
'layout is needed' (and masks the repaint change) as normally layout is followed by a repaint.
However, in compositing context, layout may not be followed by repaint, so when the style diff
indicates layout, we need to figure out whether it implies repaint too.
This logic should eventually be moved from RenderElement to RenderLayerModelObject/RenderLayer.
-tracked here: webkit.org/b/135990

Source/WebCore:

Test: compositing/cliprect-and-position-change-on-compositing-layer.html

• rendering/RenderElement.cpp:

(WebCore::RenderElement::setNeedsPositionedMovementLayout):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayerRepaint):
(WebCore::RenderStyle::diffRequiresLayerRepaint):
(WebCore::RenderStyle::diffRequiresRepaint): Deleted.

• rendering/style/RenderStyle.h:
• rendering/style/RenderStyleConstants.h:

LayoutTests:

• compositing/cliprect-and-position-change-on-compositing-layer-expected.html: Added.
• compositing/cliprect-and-position-change-on-compositing-layer.html: Added.

3:40 PM Changeset in webkit [172655] by Brian Burg

• 39 edits
  57 adds
  2 deletes in trunk

Web Inspector: rewrite CodeGeneratorInspector to be modular and testable
​https://bugs.webkit.org/show_bug.cgi?id=131596

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Replace CodeGeneratorInspector.py with generate-inspector-protocol-bindings.py.
The new generator decouples parsing and typechecking a model of the protocol from
code generation. Each generated file is created by a different subclass of Generator.
Helper methods to compute various type signatures are shared among generators.

This patch introduces a test harness and a test suite that covers all functionality.

Aside from hooking up the new inspector bindings generator to the build system,
there are a few comingled changes that would be painful to split from the main
patch:

Convert protocol enumeration types from struct-namespaced enums to C++ scoped enums.

Move all runtimeCast(), assertValueHasExpectedType(), and RuntimeCastHelper methods to static
methods of BindingTraits specializations.

Together, these changes reduce duplication and make it possible to forward-declare
all protocol enum and object types, reducing weird ordering dependencies between domains.

• CMakeLists.txt:
• DerivedSources.make:
• JavaScriptCore.vcxproj/copy-files.cmd:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Add inspector scripts to solution filters.
• JavaScriptCore.xcodeproj/project.pbxproj:
• inspector/ConsoleMessage.cpp: Convert to scoped enums.

(Inspector::messageSourceValue):
(Inspector::messageTypeValue):
(Inspector::messageLevelValue):

• inspector/InjectedScript.cpp: Convert to scoped enums and BindingTraits.

(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::wrapCallFrames):
(Inspector::InjectedScript::wrapObject):
(Inspector::InjectedScript::wrapTable):

• inspector/InjectedScriptBase.cpp: Convert InspectorValue::Type to a scoped enum.

(Inspector::InjectedScriptBase::makeEvalCall):

• inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptForObjectId):

• inspector/InspectorTypeBuilder.h:

(Inspector::TypeBuilder::Array::create):
(Inspector::TypeBuilder::StructItemTraits::pushRefPtr):
(Inspector::TypeBuilder::ArrayItemHelper<String>::Traits::pushRaw):
(Inspector::TypeBuilder::ArrayItemHelper<int>::Traits::pushRaw):
(Inspector::TypeBuilder::ArrayItemHelper<double>::Traits::pushRaw):
(Inspector::TypeBuilder::ArrayItemHelper<bool>::Traits::pushRaw):
(Inspector::TypeBuilder::ArrayItemHelper<InspectorValue>::Traits::pushRefPtr):
(Inspector::TypeBuilder::ArrayItemHelper<InspectorObject>::Traits::pushRefPtr):
(Inspector::TypeBuilder::ArrayItemHelper<InspectorArray>::Traits::pushRefPtr):
(Inspector::TypeBuilder::PrimitiveBindingTraits::assertValueHasExpectedType):
(Inspector::TypeBuilder::BindingTraits<TypeBuilder::Array<T>>::runtimeCast):
(Inspector::TypeBuilder::BindingTraits<TypeBuilder::Array<T>>::assertValueHasExpectedType):
(Inspector::TypeBuilder::BindingTraits<InspectorValue>::assertValueHasExpectedType):
(Inspector::TypeBuilder::BindingTraits<int>::assertValueHasExpectedType):
(Inspector::TypeBuilder::ExactlyInt::ExactlyInt): Deleted. It was not used.
(Inspector::TypeBuilder::ExactlyInt::operator int): Deleted.
(Inspector::TypeBuilder::ExactlyInt::cast_to_int): Deleted.
(Inspector::TypeBuilder::ExactlyInt::cast_to_int<int>): Deleted.
(Inspector::TypeBuilder::int>): Deleted.
(Inspector::TypeBuilder::RuntimeCastHelper::assertType): Deleted.
(Inspector::TypeBuilder::RuntimeCastHelper::assertAny): Deleted.
(Inspector::TypeBuilder::RuntimeCastHelper::assertInt): Deleted.
(Inspector::TypeBuilder::Array::runtimeCast): Deleted.
(Inspector::TypeBuilder::Array::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::StructItemTraits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<String>::Traits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<int>::Traits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<double>::Traits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<bool>::Traits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<InspectorValue>::Traits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<InspectorObject>::Traits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<InspectorArray>::Traits::assertCorrectValue): Deleted.
(Inspector::TypeBuilder::ArrayItemHelper<TypeBuilder::Array<T>>::Traits::assertCorrectValue): Deleted.

• inspector/InspectorValues.cpp: Convert InspectorValue::Type to a scoped enum.

(Inspector::InspectorValue::writeJSON):
(Inspector::InspectorBasicValue::asBoolean):
(Inspector::InspectorBasicValue::asNumber):
(Inspector::InspectorBasicValue::writeJSON):
(Inspector::InspectorString::writeJSON):
(Inspector::InspectorObjectBase::InspectorObjectBase):
(Inspector::InspectorObjectBase::setArray): Take InspectorArrayBase.
(Inspector::InspectorObjectBase::setObject): Take InspectorObjectBase.
(Inspector::InspectorArrayBase::InspectorArrayBase):

• inspector/InspectorValues.h:

• inspector/agents/InspectorDebuggerAgent.cpp: Convert to scoped enums.

(Inspector::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(Inspector::InspectorDebuggerAgent::breakProgram):

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::parse):

• inspector/agents/InspectorRuntimeAgent.h:

• inspector/scripts/CodeGeneratorInspector.py: Removed.
• inspector/scripts/codegen/init.py: Added.
• inspector/scripts/codegen/generate_backend_commands.py: Added.

(BackendCommandsGenerator):
(BackendCommandsGenerator.init):
(BackendCommandsGenerator.model):
(BackendCommandsGenerator.output_filename):
(BackendCommandsGenerator.generate_license):
(BackendCommandsGenerator.generate_output):
(BackendCommandsGenerator.generate_domain):
(BackendCommandsGenerator.generate_domain.is_anonymous_enum_member):
(BackendCommandsGenerator.generate_domain.generate_parameter_object):

• inspector/scripts/codegen/generate_backend_dispatcher_header.py: Added.

(BackendDispatcherHeaderGenerator):
(BackendDispatcherHeaderGenerator.init):
(BackendDispatcherHeaderGenerator.model):
(BackendDispatcherHeaderGenerator.output_filename):
(BackendDispatcherHeaderGenerator.generate_license):
(BackendDispatcherHeaderGenerator.generate_output):
(BackendDispatcherHeaderGenerator.generate_output.for):
(BackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain):
(BackendDispatcherHeaderGenerator._generate_anonymous_enum_for_parameter):
(BackendDispatcherHeaderGenerator._generate_handler_declaration_for_command):
(BackendDispatcherHeaderGenerator._generate_async_handler_declaration_for_command):
(BackendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain):
(BackendDispatcherHeaderGenerator._generate_dispatcher_declaration_for_command):

• inspector/scripts/codegen/generate_backend_dispatcher_implementation.py: Added.

(BackendDispatcherImplementationGenerator):
(BackendDispatcherImplementationGenerator.init):
(BackendDispatcherImplementationGenerator.model):
(BackendDispatcherImplementationGenerator.output_filename):
(BackendDispatcherImplementationGenerator.generate_license):
(BackendDispatcherImplementationGenerator.generate_output):
(BackendDispatcherImplementationGenerator._generate_handler_class_destructor_for_domain):
(BackendDispatcherImplementationGenerator._generate_dispatcher_implementations_for_domain):
(BackendDispatcherImplementationGenerator._generate_small_dispatcher_switch_implementation_for_domain):
(BackendDispatcherImplementationGenerator._generate_large_dispatcher_switch_implementation_for_domain):
(BackendDispatcherImplementationGenerator._generate_async_dispatcher_class_for_domain):
(BackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

• inspector/scripts/codegen/generate_frontend_dispatcher_header.py: Added.

(FrontendDispatcherHeaderGenerator):
(FrontendDispatcherHeaderGenerator.init):
(FrontendDispatcherHeaderGenerator.model):
(FrontendDispatcherHeaderGenerator.output_filename):
(FrontendDispatcherHeaderGenerator.generate_license):
(FrontendDispatcherHeaderGenerator.generate_output):
(FrontendDispatcherHeaderGenerator._generate_anonymous_enum_for_parameter):
(FrontendDispatcherHeaderGenerator._generate_dispatcher_declarations_for_domain):
(FrontendDispatcherHeaderGenerator._generate_dispatcher_declaration_for_event):

• inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py: Added.

(FrontendDispatcherImplementationGenerator):
(FrontendDispatcherImplementationGenerator.init):
(FrontendDispatcherImplementationGenerator.model):
(FrontendDispatcherImplementationGenerator.output_filename):
(FrontendDispatcherImplementationGenerator.generate_license):
(FrontendDispatcherImplementationGenerator.generate_output):
(FrontendDispatcherImplementationGenerator._generate_dispatcher_implementations_for_domain):
(FrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):

• inspector/scripts/codegen/generate_type_builder_header.py: Added.

(TypeBuilderHeaderGenerator):
(TypeBuilderHeaderGenerator.init):
(TypeBuilderHeaderGenerator.model):
(TypeBuilderHeaderGenerator.output_filename):
(TypeBuilderHeaderGenerator.generate_license):
(TypeBuilderHeaderGenerator.generate_output):
(TypeBuilderHeaderGenerator._generate_forward_declarations):
(_generate_typedefs):
(_generate_typedefs_for_domain):
(_generate_builders_for_domain):
(_generate_class_for_object_declaration):
(_generate_struct_for_enum_declaration):
(_generate_struct_for_anonymous_enum_member):
(_generate_struct_for_anonymous_enum_member.apply_indentation):
(_generate_struct_for_enum_type):
(_generate_builder_state_enum):
(_generate_builder_setter_for_member):
(_generate_unchecked_setter_for_member):
(_generate_forward_declarations_for_binding_traits):

• inspector/scripts/codegen/generate_type_builder_implementation.py: Added.

(TypeBuilderImplementationGenerator):
(TypeBuilderImplementationGenerator.init):
(TypeBuilderImplementationGenerator.model):
(TypeBuilderImplementationGenerator.output_filename):
(TypeBuilderImplementationGenerator.generate_license):
(TypeBuilderImplementationGenerator.generate_output):
(TypeBuilderImplementationGenerator._generate_enum_mapping):
(TypeBuilderImplementationGenerator._generate_open_field_names):
(TypeBuilderImplementationGenerator._generate_builders_for_domain):
(TypeBuilderImplementationGenerator._generate_runtime_cast_for_object_declaration):
(TypeBuilderImplementationGenerator._generate_assertion_for_object_declaration):
(TypeBuilderImplementationGenerator._generate_assertion_for_enum):

• inspector/scripts/codegen/generator.py: Added.

(ucfirst):
(Generator):
(Generator.init):
(Generator.model):
(Generator.generate_license):
(Generator.domains_to_generate):
(Generator.generate_output):
(Generator.output_filename):
(Generator.encoding_for_enum_value):
(Generator.assigned_enum_values):
(Generator.type_needs_runtime_casts):
(Generator.type_has_open_fields):
(Generator.type_needs_shape_assertions):
(Generator.calculate_types_requiring_shape_assertions):
(Generator.calculate_types_requiring_shape_assertions.gather_transitively_referenced_types):
(Generator._traverse_and_assign_enum_values):
(Generator._assign_encoding_for_enum_value):
(Generator.wrap_with_guard_for_domain):
(Generator.stylized_name_for_enum_value):
(Generator.stylized_name_for_enum_value.replaceCallback):
(Generator.keyed_get_method_for_type):
(Generator.keyed_set_method_for_type):
(Generator.type_builder_string_for_type):
(Generator.type_builder_string_for_type_member):
(Generator.type_string_for_unchecked_formal_in_parameter):
(Generator.type_string_for_checked_formal_event_parameter):
(Generator.type_string_for_type_member):
(Generator.type_string_for_type_with_name):
(Generator.type_string_for_formal_out_parameter):
(Generator.type_string_for_formal_async_parameter):
(Generator.type_string_for_stack_in_parameter):
(Generator.type_string_for_stack_out_parameter):
(Generator.assertion_method_for_type_member):
(Generator.assertion_method_for_type_member.assertion_method_for_type):
(Generator.cpp_name_for_primitive_type):
(Generator.js_name_for_parameter_type):
(Generator.should_use_wrapper_for_return_type):
(Generator.should_pass_by_copy_for_return_type):

• inspector/scripts/codegen/generator_templates.py: Added.

(GeneratorTemplates):
(void):
(HashMap):
(Builder):
(Inspector):

• inspector/scripts/codegen/models.py: Added.

(ucfirst):
(ParseException):
(TypecheckException):
(Framework):
(Framework.init):
(Framework.setting):
(Framework.fromString):
(Frameworks):
(TypeReference):
(TypeReference.init):
(TypeReference.referenced_name):
(Type):
(Type.init):
(Type.eq):
(Type.hash):
(Type.raw_name):
(Type.is_enum):
(Type.type_domain):
(Type.qualified_name):
(Type.resolve_type_references):
(PrimitiveType):
(PrimitiveType.init):
(PrimitiveType.repr):
(PrimitiveType.type_domain):
(PrimitiveType.qualified_name):
(AliasedType):
(AliasedType.init):
(AliasedType.repr):
(AliasedType.is_enum):
(AliasedType.type_domain):
(AliasedType.qualified_name):
(AliasedType.resolve_type_references):
(EnumType):
(EnumType.init):
(EnumType.repr):
(EnumType.is_enum):
(EnumType.type_domain):
(EnumType.enum_values):
(EnumType.qualified_name):
(EnumType.resolve_type_references):
(ArrayType):
(ArrayType.init):
(ArrayType.repr):
(ArrayType.type_domain):
(ArrayType.qualified_name):
(ArrayType.resolve_type_references):
(ObjectType):
(ObjectType.init):
(ObjectType.repr):
(ObjectType.type_domain):
(ObjectType.qualified_name):
(check_for_required_properties):
(Protocol):
(Protocol.init):
(Protocol.parse_specification):
(Protocol.parse_domain):
(Protocol.parse_type_declaration):
(Protocol.parse_type_member):
(Protocol.parse_command):
(Protocol.parse_event):
(Protocol.parse_call_or_return_parameter):
(Protocol.resolve_types):
(Protocol.lookup_type_for_declaration):
(Protocol.lookup_type_reference):
(Domain):
(Domain.init):
(Domain.resolve_type_references):
(Domains):
(TypeDeclaration):
(TypeDeclaration.init):
(TypeDeclaration.resolve_type_references):
(TypeMember):
(TypeMember.init):
(TypeMember.resolve_type_references):
(Parameter):
(Parameter.init):
(Parameter.resolve_type_references):
(Command):
(Command.init):
(Command.resolve_type_references):
(Event):
(Event.init):
(Event.resolve_type_references):

• inspector/scripts/generate-inspector-protocol-bindings.py: Added.

(IncrementalFileWriter):
(IncrementalFileWriter.init):
(IncrementalFileWriter.write):
(IncrementalFileWriter.close):
(generate_from_specification):
(generate_from_specification.load_specification):

• inspector/scripts/tests/commands-with-async-attribute.json: Added.
• inspector/scripts/tests/commands-with-optional-call-return-parameters.json: Added.
• inspector/scripts/tests/domains-with-varying-command-sizes.json: Added.
• inspector/scripts/tests/events-with-optional-parameters.json: Added.
• inspector/scripts/tests/expected/commands-with-async-attribute.json-result: Added.
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result: Added.
• inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result: Added.
• inspector/scripts/tests/expected/events-with-optional-parameters.json-result: Added.
• inspector/scripts/tests/fail-on-duplicate-type-declarations.json-error: Added.
• inspector/scripts/tests/fail-on-enum-with-no-values.json-error: Added.
• inspector/scripts/tests/fail-on-type-declaration-using-type-reference.json-error: Added.
• inspector/scripts/tests/fail-on-type-with-lowercase-name.json-error: Added.
• inspector/scripts/tests/fail-on-unknown-type-reference-in-type-declaration.json-error: Added.
• inspector/scripts/tests/fail-on-unknown-type-reference-in-type-member.json-error: Added.
• inspector/scripts/tests/expected/same-type-id-different-domain.json-result: Added.
• inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result: Added.
• inspector/scripts/tests/expected/type-declaration-array-type.json-result: Added.
• inspector/scripts/tests/expected/type-declaration-enum-type.json-result: Added.
• inspector/scripts/tests/expected/type-declaration-object-type.json-result: Added.
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result: Added.
• inspector/scripts/tests/fail-on-duplicate-type-declarations.json: Added.
• inspector/scripts/tests/fail-on-enum-with-no-values.json: Added.
• inspector/scripts/tests/fail-on-type-declaration-using-type-reference.json: Added.
• inspector/scripts/tests/fail-on-type-with-lowercase-name.json: Added.
• inspector/scripts/tests/fail-on-unknown-type-reference-in-type-declaration.json: Added.
• inspector/scripts/tests/fail-on-unknown-type-reference-in-type-member.json: Added.
• inspector/scripts/tests/same-type-id-different-domain.json: Added.
• inspector/scripts/tests/type-declaration-aliased-primitive-type.json: Added.
• inspector/scripts/tests/type-declaration-array-type.json: Added.
• inspector/scripts/tests/type-declaration-enum-type.json: Added.
• inspector/scripts/tests/type-declaration-object-type.json: Added.
• inspector/scripts/tests/type-requiring-runtime-casts.json: Added.

Source/WebCore:

Aside from hooking up the new inspector bindings generator to the build system,
there are a few comingled changes that would be painful to split from the main
patch. Together, these changes make it possible to forward-declare all protocol
enumerations as scoped enums, reducing weird ordering dependencies between domains.

All runtimeCast() methods are now static methods of BindingTraits specializations,
rather than as static methods of the type builder classes.

All protocol enumeration types are scoped enums rather than struct-namespaced enums.

Remove some implicit protocol type and enumeration definitions because they trigger
compiler bugs or introduce unnecessary complexity in the bindings generator.

No new tests, no behavior changed.

• CMakeLists.txt:
• DerivedSources.make: Update script dependencies and the bindings generator script name.

• inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::inspectImpl): Convert to BindingTraits.

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::detectOrigin):
(WebCore::InspectorCSSAgent::buildArrayForRegions):

• inspector/InspectorCSSAgent.h:
• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceTypeJson):
(WebCore::InspectorPageAgent::getScriptExecutionStatus): Convert to scoped enums.

(WebCore::InspectorPageAgent::buildObjectForFrameTree): Extract FrameResourceTree::Resources
into its own explicitly-defined object type. The new generator does not support implicitly
defining object types as elements of arrays.

• inspector/InspectorPageAgent.h:
• inspector/InspectorReplayAgent.cpp: Disambiguate between internal and protocol types.

(WebCore::buildInspectorObjectForSessionState):
(WebCore::buildInspectorObjectForSegmentState):
(WebCore::InspectorReplayAgent::sessionState):
(WebCore::InspectorReplayAgent::didCreateFrontendAndBackend):
(WebCore::InspectorReplayAgent::frameNavigated):
(WebCore::InspectorReplayAgent::frameDetached):
(WebCore::InspectorReplayAgent::willDispatchEvent):
(WebCore::InspectorReplayAgent::startCapturing):
(WebCore::InspectorReplayAgent::stopCapturing):
(WebCore::InspectorReplayAgent::replayToPosition):
(WebCore::InspectorReplayAgent::replayToCompletion):
(WebCore::InspectorReplayAgent::pausePlayback):
(WebCore::InspectorReplayAgent::cancelPlayback):
(WebCore::InspectorReplayAgent::switchSession):
(WebCore::InspectorReplayAgent::insertSessionSegment):
(WebCore::InspectorReplayAgent::removeSessionSegment):
(WebCore::InspectorReplayAgent::currentReplayState):
(WebCore::InspectorReplayAgent::getAvailableSessions):
(WebCore::InspectorReplayAgent::getSessionData):
(WebCore::InspectorReplayAgent::getSegmentData):

• inspector/InspectorReplayAgent.h:
• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willSendRequest):

• inspector/InspectorStyleSheet.cpp: Convert to scoped enums. Extract CSSProperty::Status

because scoped enums defined in a class scope trigger compiler bugs in GCC 4.8.
(WebCore::buildMediaObject):
(WebCore::InspectorStyle::styleWithProperties): Work around compiler disagreements.
(WebCore::InspectorStyleSheet::create):
(WebCore::InspectorStyleSheet::InspectorStyleSheet):
(WebCore::InspectorStyleSheetForInlineStyle::create):
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

• inspector/InspectorStyleSheet.h:

• inspector/InspectorTimelineAgent.cpp: Convert to scoped enums and BindingTraits.

(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::sendEvent):

• inspector/protocol/CSS.json: Extract CSSProperty::Status.
• inspector/protocol/Page.json: Extract FrameResourceTree::Resources.

Source/WebInspectorUI:

Also apply type extraction refactorings to old protocol versions for consistency.

• Versions/Inspector-iOS-6.0.json:
• Versions/Inspector-iOS-7.0.json:

Tools:

• Scripts/run-inspector-generator-tests: Added.

(main):

• Scripts/webkitpy/inspector/init.py: Added.
• Scripts/webkitpy/inspector/main.py: Added.

(InspectorGeneratorTests):
(InspectorGeneratorTests.init):
(InspectorGeneratorTests.generate_from_json):
(InspectorGeneratorTests.write_error_file):
(InspectorGeneratorTests.detect_changes):
(InspectorGeneratorTests.run_tests):
(InspectorGeneratorTests.main):

2:48 PM Changeset in webkit [172654] by matthew_hanson@apple.com

• 1 copy in tags/Safari-600.1.4.11.1

New Tag.

2:22 PM Changeset in webkit [172653] by barraclough@apple.com

• 3 edits in trunk/Source/WebKit2

Fix plugin visibility check.
​https://bugs.webkit.org/show_bug.cgi?id=135991

D'oh, more unreviewed typo fix. :-(

• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
(WebKit::PluginControllerProxy::updateVisibilityActivity):
(WebKit::PluginControllerProxy::updateVisiblityActivity): Deleted.

• PluginProcess/PluginControllerProxy.h:

2:16 PM Changeset in webkit [172652] by matthew_hanson@apple.com

• 3 edits
  3 copies in branches/safari-600.1.4.11-branch

Merge r172603. <rdar://problem/18008488>

2:14 PM Changeset in webkit [172651] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[EME][Mac] Adopt AVStreamSession.
​https://bugs.webkit.org/show_bug.cgi?id=135983

Reviewed by Eric Carlson.

Add AVStreamDataParsers to a new AVStreamSession instance, and expire that session when asked to release
the session's keys.

• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::~CDMSessionMediaSourceAVFObjC):
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys):
(WebCore::CDMSessionMediaSourceAVFObjC::update):

2:12 PM Changeset in webkit [172650] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Probe details sidebar data grids do not show data
​https://bugs.webkit.org/show_bug.cgi?id=135992

Reviewed by Joseph Pecoraro.

• UserInterface/Views/ProbeSetDataGrid.js:

(WebInspector.ProbeSetDataGrid): Make the DataGrid be inline to show the data correctly.

2:09 PM Changeset in webkit [172649] by commit-queue@webkit.org

• 19 edits in trunk/Source

Implement snapping behavior for iOS
​https://bugs.webkit.org/show_bug.cgi?id=135769

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-15
Reviewed by Brent Fulgham.

Source/WebCore:

Added support for snap points on iOS. This entails sending snap points from the web process to the UI process
by encoding and decoding snap points and updating ScrollingTreeOverflowScrollingNodeIOS and WKWebView to support
animation to snap points in the cases of mainframe and overflow scrolling, respectively.

There are no new tests yet -- we'll need to find a way to test this!

• WebCore.exp.in:
• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::setStateScrollingNodeSnapOffsetsAsFloat): Helper functions used to convert LayoutUnits to floats for snap offsets.
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated): Update snap offsets for mainframe scrolling, as well as the state node.
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode): Added snap offsets.

• page/scrolling/AxisScrollSnapOffsets.h:

(WebCore::closestSnapOffset): Computes the closest snap offset given a sorted vector of comparable types (e.g. float, LayoutUnit).

• page/scrolling/ScrollingCoordinator.h:
• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setHorizontalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::setVerticalSnapOffsets):

• page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::horizontalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::verticalSnapOffsets):

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

• page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::horizontalSnapOffsets):
(WebCore::ScrollingTreeScrollingNode::verticalSnapOffsets):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout): Update snap offsets for overflow scrolling.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer): Updates the state node's snap offsets for overflow scrolling.

Source/WebKit2:

Added support for snap points on iOS.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::encode): Added snap offset encoding.
(ArgumentCoder<ScrollingStateScrollingNode>::decode): Added snap offset decoding.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): For mainframe scrolling, retargets the scroll destination to the appropriate snap point.

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h: Added methods to extract relevant information for WKWebView from snap offsets in mainframe scrolling.
• UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): For overflow scrolling, retargets the scroll destination to the appropriate snap point.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren): Sets the deceleration factor to FAST if snap points are active.

• UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::adjustTargetContentOffsetForSnapping): Used by WKWebView for mainframe scrolling to retarget the scroll destination, if necessary.
(WebKit::RemoteScrollingCoordinatorProxy::shouldSetScrollViewDecelerationRateFast): Used by WKWebView for mainframe scrolling to determine whether to set deceleration rate to the fast value.
(WebKit::RemoteScrollingCoordinatorProxy::shouldSnapForMainFrameScrolling): Helper method.
(WebKit::RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling): Helper method.

2:04 PM Changeset in webkit [172648] by mmirman@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Made native inlining errors not segfault.
​https://bugs.webkit.org/show_bug.cgi?id=135988

Reviewed by Geoffrey Garen.

• ftl/FTLAbbreviations.h:

(JSC::FTL::disposeMessage): Added.

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compilePutById):
abstracted out Options::verboseCompilation as was the case in the rest of the file.
(JSC::FTL::LowerDFGToLLVM::compileNativeCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol):
added output error messages for llvm module loading.

1:48 PM Changeset in webkit [172647] by krit@webkit.org

• 4 edits in trunk

Turn r/rx/ry to presentation attributes
​https://bugs.webkit.org/show_bug.cgi?id=135978

Source/WebCore:

Unreviewed typo.

Patch by Dirk Schulze <​krit@webkit.org> on 2014-08-15

• rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

LayoutTests:

Patch by Dirk Schulze <​krit@webkit.org> on 2014-08-15
Reviewed by Dean Jackson.

Rebaseline test.

• svg/css/parse-length-expected.txt:

1:37 PM Changeset in webkit [172646] by barraclough@apple.com

• 3 edits in trunk/Source/WebKit2

Fix plugin visibility check.
​https://bugs.webkit.org/show_bug.cgi?id=135991

Unreviewed typo fix.

• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):
(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):
(WebKit::PluginControllerProxy::updateVisiblityActivity):

• PluginProcess/PluginControllerProxy.h:

1:32 PM Changeset in webkit [172645] by barraclough@apple.com

• 3 edits in trunk/Source/WebKit2

Fix plugin visibility check.
​https://bugs.webkit.org/show_bug.cgi?id=135991

Reviewed by Andreas Kling.

We should only take a UserActivity if the plugin is in a visible window,
and also is itself visible.

• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):

• initialize member state.

(WebKit::PluginControllerProxy::visibilityDidChange):
(WebKit::PluginControllerProxy::windowVisibilityChanged):

• update member state & call updateVisiblityActivity.

(WebKit::PluginControllerProxy::updateVisiblityActivity):

• enable the UserActivity only if both visibilities are true.

• PluginProcess/PluginControllerProxy.h:
  • added m_isVisible, m_isWindowVisible, updateVisibilityActivity.

1:12 PM Changeset in webkit [172644] by dburkart@apple.com

• 5 edits in branches/safari-600.1-branch/Source

Bump versioning.

12:53 PM Changeset in webkit [172643] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

[Services with UI] Selections are incorrect when selecting three lines.
​https://bugs.webkit.org/show_bug.cgi?id=135989
<rdar://problem/18032571>

Reviewed by Tim Horton.

The stitching algorithm did not handle correctly the case of selections
over three lines if the middle line is composed of only one rectangle.

• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::stitchRects):

12:42 PM Changeset in webkit [172642] by krit@webkit.org

• 21 edits in trunk

Turn r/rx/ry to presentation attributes
​https://bugs.webkit.org/show_bug.cgi?id=135978

Patch by Dirk Schulze <​krit@webkit.org> on 2014-08-15
Reviewed by Dean Jackson.

This follows the patch for width and height presentation attributes and
Source/WebCore:

turns rx, ry and r to presentation attributes as well:

​​http://trac.webkit.org/changeset/171341

Extended existing tests.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):

• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

• css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

• css/SVGCSSPropertyNames.in:
• page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• rendering/style/RenderStyle.h:
• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setR):
(WebCore::SVGRenderStyle::setRx):
(WebCore::SVGRenderStyle::setRy):
(WebCore::SVGRenderStyle::r):
(WebCore::SVGRenderStyle::rx):
(WebCore::SVGRenderStyle::ry):

• rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleLayoutData::StyleLayoutData):
(WebCore::StyleLayoutData::operator==):

• rendering/style/SVGRenderStyleDefs.h:
• rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

• rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromCircleElement):
(WebCore::updatePathFromEllipseElement):
(WebCore::updatePathFromRectElement):
(WebCore::updatePathFromLineElement): Deleted.

• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):

• svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):

• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):

• svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::svgAttributeChanged):

LayoutTests:

turns r, rx and ry to presentation attributes as well:

​​http://trac.webkit.org/changeset/171341

• svg/css/parse-length.html:
• transitions/svg-layout-transition-expected.txt:
• transitions/svg-layout-transition.html:

12:38 PM Changeset in webkit [172641] by krit@webkit.org

• 23 edits in trunk

Turn cx/cy to presentation attributes
​https://bugs.webkit.org/show_bug.cgi?id=135975

Reviewed by Dean Jackson.

This follows the patch for width and height presentation attributes and
Source/WebCore:

turns x and y to presentation attributes as well:

​​http://trac.webkit.org/changeset/171341

Extended existing tests.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):

• css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

• css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

• css/SVGCSSPropertyNames.in:
• page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• rendering/style/RenderStyle.h:
• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setCx):
(WebCore::SVGRenderStyle::setCy):
(WebCore::SVGRenderStyle::cx):
(WebCore::SVGRenderStyle::cy):

• rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleLayoutData::StyleLayoutData):
(WebCore::StyleLayoutData::operator==):

• rendering/style/SVGRenderStyleDefs.h:
• rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

• rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromCircleElement):
(WebCore::updatePathFromEllipseElement):

• svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):
(WebCore::SVGCircleElement::selfHasRelativeLengths): Deleted.

• svg/SVGCircleElement.h:
• svg/SVGElement.cpp:

(WebCore::populateAttributeNameToCSSPropertyIDMap):
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap):

• svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):
(WebCore::SVGEllipseElement::selfHasRelativeLengths): Deleted.

• svg/SVGEllipseElement.h:

LayoutTests:

turns cx and cy to presentation attributes as well:

​​http://trac.webkit.org/changeset/171341

• svg/css/parse-length-expected.txt:
• svg/css/parse-length.html:
• transitions/svg-layout-transition-expected.txt:
• transitions/svg-layout-transition.html:

12:11 PM Changeset in webkit [172640] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Legacy Mac toolbar appearance looks wrong
​https://bugs.webkit.org/show_bug.cgi?id=135962

Reviewed by Joseph Pecoraro.

• UserInterface/Views/Toolbar.css:

(body.mac-platform.legacy .toolbar): Don't draw a gradient background when not docked.
Move border-bottom-color from body.mac-platform.legacy.docked .toolbar to here so it
applies all the time as it should have.

12:10 PM Changeset in webkit [172639] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Service overlays stay fixed when <iframe> scrolls
​https://bugs.webkit.org/show_bug.cgi?id=135959
<rdar://problem/17957716>

Reviewed by Enrica Casucci.

• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::highlightsAreEquivalent):
Tiny correctness fix; highlights can only be equivalent if their
types are equivalent as well.

12:03 PM Changeset in webkit [172638] by commit-queue@webkit.org

• 2 edits in trunk/Tools

run-webkit-tests should skip 'support' directories
​https://bugs.webkit.org/show_bug.cgi?id=135910

Patch by Rebecca Hauck <​rhauck@adobe.com> on 2014-08-15
Reviewed by Bem Jones-Bey.

This patch adds the 'support' directory to the list
of dirs to skip when looking for runnable tests.
the W3C uses this name for support files, so tests
imported from the W3C will not work without this change
or without many edits.

• Scripts/webkitpy/port/base.py:

(Port._real_tests):

11:56 AM Changeset in webkit [172637] by barraclough@apple.com

• 12 edits in trunk/Source/WebKit2

de-PLATFORM(COCOA) a couple of methods in plugin code
​https://bugs.webkit.org/show_bug.cgi?id=135987

Reviewed by Sam Weinig.

Pass through the visibility & focus on all platforms, to simplify & avoid
any weird inconsistencies between platforms.

• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::windowFocusChanged):
(WebKit::PluginControllerProxy::windowVisibilityChanged):

• PluginProcess/PluginControllerProxy.h:
• PluginProcess/PluginControllerProxy.messages.in:
• PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::windowFocusChanged): Deleted.
(WebKit::PluginControllerProxy::windowVisibilityChanged): Deleted.

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::windowVisibilityChanged):

• WebProcess/Plugins/Netscape/NetscapePlugin.h:
• WebProcess/Plugins/Plugin.h:
• WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::windowAndViewFramesChanged):

• WebProcess/Plugins/PluginProxy.h:
• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::viewStateDidChange):
(WebKit::PluginView::platformViewStateDidChange): Deleted.

• WebProcess/Plugins/PluginView.h:

11:47 AM Changeset in webkit [172636] by timothy_horton@apple.com

• 6 edits in trunk/Source/WebKit2

Service overlays stay fixed when <iframe> scrolls
​https://bugs.webkit.org/show_bug.cgi?id=135959
<rdar://problem/17957716>

Reviewed by Enrica Casucci.

• WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::didScrollFrame):

• WebProcess/WebPage/PageOverlay.h:

(WebKit::PageOverlay::Client::didScrollFrame):

• WebProcess/WebPage/PageOverlayController.cpp:

(WebKit::PageOverlayController::didScrollFrame):
Push didScrollFrame down to the overlays.

• WebProcess/WebPage/ServicesOverlayController.h:
• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::Highlight::createForSelection):
Hold on to the selection's Range so we can use it to compare Highlights later.

(WebKit::ServicesOverlayController::Highlight::Highlight):
(WebKit::ServicesOverlayController::Highlight::setDDHighlight):
Factor the code to set up and paint the highlight out, so that we can
set a new DDHighlightRef on a Highlight and the layer moves/reshapes/repaints.

(WebKit::ServicesOverlayController::buildPhoneNumberHighlights):
(WebKit::ServicesOverlayController::buildSelectionHighlight):
(WebKit::ServicesOverlayController::replaceHighlightsOfTypePreservingEquivalentHighlights):
Factor replaceHighlightsOfTypePreservingEquivalentHighlights out
so that we can use it for buildSelectionHighlight as well.

Steal the DDHighlightRef from the new Highlight when re-using an old one
so that the newly computed rects are used instead of the old ones.

(WebKit::ServicesOverlayController::highlightsAreEquivalent):
We will always have a Range now, so we can always check equivalence using it.

(WebKit::ServicesOverlayController::didScrollFrame):
Rebuild all highlights upon subframe scroll, as they might have moved.
We could optimize this in the future, but for now it's cheap enough
and rare enough that it doesn't matter.

11:42 AM Changeset in webkit [172635] by timothy_horton@apple.com

• 12 edits in trunk/Source/WebKit2

REGRESSION (WebKit2 Gestures): White flash when swiping back to cnn.com's homepage from an article
​https://bugs.webkit.org/show_bug.cgi?id=135951
<rdar://problem/18006149>

Reviewed by Simon Fraser.

Wait for (the first visually non-empty layout AND the render tree size threshold to be hit),
OR didFinishLoadForFrame, whichever comes first. Once we've done the first visually non-empty layout,
we'll start the watchdog and tear down the snapshot in three seconds no matter what.
Also, force a repaint so we can asynchronously wait for the Web Process to paint and return to us
before removing the snapshot, which improves our chances that something is actually on the screen.

• UIProcess/API/mac/WKView.mm:

(-[WKView _didFirstVisuallyNonEmptyLayoutForMainFrame]):
(-[WKView _didFinishLoadForMainFrame]):
(-[WKView _removeNavigationGestureSnapshot]):

• UIProcess/API/mac/WKViewInternal.h:
• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::removeNavigationGestureSnapshot):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):

• UIProcess/mac/PageClientImpl.h:
• UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
(WebKit::PageClientImpl::didFinishLoadForMainFrame):
(WebKit::PageClientImpl::removeNavigationGestureSnapshot):
Plumb didFirstVisuallyNonEmptyLayoutForMainFrame and didFinishLoadForMainFrame
through to ViewGestureController from WebPageProxy via the PageClient, etc.

Ditto for removeNavigationGestureSnapshot, though it is called from a
VoidCallback in ViewGestureController instead of from WebFrameLoaderClient and friends.

• UIProcess/mac/ViewGestureController.h:
• UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
When finishing a swipe, we want to wait for both the first visually non-empty layout
and the render tree size threshold being hit.

(WebKit::ViewGestureController::didHitRenderTreeSizeThreshold):
(WebKit::ViewGestureController::didFirstVisuallyNonEmptyLayoutForMainFrame):
When both of these things have happened, remove the swipe snapshot (after forcing a repaint).
For didFirstVisuallyNonEmptyLayoutForMainFrame, we will also start a watchdog
ensuring that we remove the snapshot in three seconds.

(WebKit::ViewGestureController::didFinishLoadForMainFrame):
When didFinishLoadForMainFrame happens, remove the swipe snapshot (after forcing a repaint).

(WebKit::ViewGestureController::swipeSnapshotWatchdogTimerFired):
If the watchdog timer fires, remove the swipe snapshot (after forcing a repaint).

(WebKit::ViewGestureController::removeSwipeSnapshotAfterRepaint):
Force a repaint and wait for the async callback before removing the snapshot.
It is safe to hold on to the WebPageProxy here because it will always
call all of its callbacks before it is destroyed.
Avoid enqueuing multiple force-repaints.

(WebKit::ViewGestureController::removeSwipeSnapshot):

11:26 AM Changeset in webkit [172634] by barraclough@apple.com

• 2 edits in trunk/Source/WebKit2

Fix plugin visibility initialization
​https://bugs.webkit.org/show_bug.cgi?id=135985

Reviewed by Geoffrey Garen.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin):

• We're not currently initializing the plugin visibility state, and we're passing the wrong value for window visibility.

11:26 AM Changeset in webkit [172633] by Lucas Forschler

• 6 edits in branches/safari-600.1.4.11-branch/Source

Merged r172502. <rdar://problem/18022784>

11:24 AM Changeset in webkit [172632] by Lucas Forschler

• 3 edits
  4 copies in branches/safari-600.1.4.11-branch

Merged r171675. <rdar://problem/18022779>

10:38 AM Changeset in webkit [172631] by aestes@apple.com

• 2 edits in trunk/Source/WebKit

[Cocoa] Add migrate-headers.sh and postprocess-headers.sh to WebKit.xcodeproj
​https://bugs.webkit.org/show_bug.cgi?id=135984

Reviewed by Daniel Bates.

It's nice to be able to look at these files in Xcode.

• WebKit.xcodeproj/project.pbxproj:

10:36 AM Changeset in webkit [172630] by Lucas Forschler

• 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

10:33 AM Changeset in webkit [172629] by barraclough@apple.com

• 8 edits in trunk/Source/WebKit2

Simplify visibility activity accounting for plugins
​https://bugs.webkit.org/show_bug.cgi?id=135981

Reviewed by Dan Bernstein.

Just take one per connection, rather than implementing a counting mechanism.

• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::PluginControllerProxy):

• PluginProcess/PluginControllerProxy.h:
  • added m_visiblityActivity.
• PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::PluginProcess):
(WebKit::PluginProcess::pluginsForWebProcessDidBecomeVisible): Deleted.
(WebKit::PluginProcess::pluginsForWebProcessDidBecomeHidden): Deleted.

• PluginProcess/PluginProcess.h:
  • removed pluginsForWebProcessDidBecomeVisible/Hidden.
• PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::pluginDidBecomeVisible): Deleted.
(WebKit::WebProcessConnection::pluginDidBecomeHidden): Deleted.

• PluginProcess/WebProcessConnection.h:
  • removed pluginDidBecomeVisible/Hidden.
• PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::windowVisibilityChanged):

• windowVisibilityChanged uses m_visiblityActivity, rather than calling to PluginControllerProxy.

10:31 AM Changeset in webkit [172628] by Lucas Forschler

• 1 copy in branches/safari-600.1.4.11-branch

New Branch.

9:49 AM Changeset in webkit [172627] by mrowe@apple.com

• 2 edits in trunk/Source/WebKit

<​https://webkit.org/b/135979> WebKit1 Plug-in test failures in clean builds after r172595

Reviewed by Dan Bernstein.

• WebKit.xcodeproj/project.pbxproj: Add a WebKitPluginHost.app symlink at the top level of

WebKitLegacy.framework that points into Versions/Current. This enables -[NSBundle pathForAuxiliaryExecutable:]
to work correctly. Adding this symlink requires deleting any content that may already exist
at that path, since prior to r172595 it may have contained either a symlink or an
application bundle.

9:38 AM Changeset in webkit [172626] by cavalcantii@gmail.com

• 2 edits in trunk/Source/WebCore

Fix typo in Path comment
​https://bugs.webkit.org/show_bug.cgi?id=135960

Reviewed by Alexey Proskuryakov.

No new tests, no change on behavior.

• platform/graphics/Path.h:

5:35 AM Changeset in webkit [172625] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.5.3

WebKitGTK+ 2.5.3

5:23 AM Changeset in webkit [172624] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.5.3 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

• gtk/NEWS: Add release notes for 2.5.3.

4:30 AM Changeset in webkit [172623] by Carlos Garcia Campos

• 2 edits in trunk

[GTK] Disable memory sampler on non-Linux system
​https://bugs.webkit.org/show_bug.cgi?id=134483

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-08-15
Reviewed by Philippe Normand.

Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp only works on
Linux because it uses many Linux-specific features, so we should disable
memory sampler on other systems by default.

• Source/cmake/OptionsGTK.cmake:

2:16 AM Changeset in webkit [172622] by Carlos Garcia Campos

• 2 edits in trunk

[GTK] HTML API documentation should also be installed versioned
​https://bugs.webkit.org/show_bug.cgi?id=135970

Reviewed by Philippe Normand.

• Source/PlatformGTK.cmake: Append -${WEBKITGTK_API_VERSION} to

the directory name.

Aug 14, 2014:

9:24 PM Changeset in webkit [172621] by akling@apple.com

• 3 edits in trunk/Source/WebCore

Remove two unused Range functions.
<​https://webkit.org/b/135944>

Reviewed by Geoffrey Garen.

• dom/Range.cpp:

(WebCore::Range::maxStartOffset): Deleted.
(WebCore::Range::maxEndOffset): Deleted.

• dom/Range.h:

9:10 PM Changeset in webkit [172620] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

Preserve editing style for -webkit-tap-highlight-color on all ports that enable ENABLE_TOUCH_EVENTS
​https://bugs.webkit.org/show_bug.cgi?id=135963

Reviewed by Andy Estes.

Currently we only preserve the CSS property -webkit-tap-highlight-color during editing operations
for iOS. Instead we should preserve it for all ports that enable ENABLE_TOUCH_EVENTS as this CSS
property isn't specific to iOS.

Also added FIXME comment with regards to the CSS property -webkit-composition-fill-color.

• editing/EditingStyle.cpp:

9:06 PM Changeset in webkit [172619] by benjamin@webkit.org

• 8 edits
  8 adds in trunk

CSS JIT: compile the :empty pseudo class
​https://bugs.webkit.org/show_bug.cgi?id=135958

Reviewed by Andreas Kling.

Source/WebCore:

Compile :empty, nothing fancy.

Tests: fast/selectors/empty-basics.html

fast/selectors/empty-long-adjacent-backtracking.html
fast/selectors/empty-adjacent-style-update.html
fast/selectors/empty-style-update.html

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::jumpIfElementIsNotEmpty):
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmpty):
(WebCore::SelectorCompiler::setElementStyleFromContextIsAffectedByEmptyAndUpdateRenderStyleIfNecessary):
(WebCore::SelectorCompiler::setElementStyleIsAffectedByEmptyAndUpdateRenderStyleIfNecessary):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsEmpty):

• dom/CharacterData.h:

(WebCore::CharacterData::dataMemoryOffset):

• dom/ContainerNode.h:

(WebCore::ContainerNode::firstChildMemoryOffset):

• dom/Node.h:

(WebCore::Node::flagIsText):

Source/WTF:

• wtf/text/StringImpl.h:

(WTF::StringImpl::lengthMemoryOffset):

LayoutTests:

Add some test coverage, :empty had very little testing.

The test empty-adjacent-style-update expose some problems with style update,
I will look into them separately.

• fast/selectors/empty-adjacent-style-update-expected.txt: Added.
• fast/selectors/empty-adjacent-style-update.html: Added.
• fast/selectors/empty-basics-expected.txt: Added.
• fast/selectors/empty-basics.html: Added.
• fast/selectors/empty-long-adjacent-backtracking-expected.txt: Added.
• fast/selectors/empty-long-adjacent-backtracking.html: Added.
• fast/selectors/empty-style-update-expected.txt: Added.
• fast/selectors/empty-style-update.html: Added.

8:22 PM Changeset in webkit [172618] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Allocate the whole RegExpMatchesArray backing store up front.
<​https://webkit.org/b/135217>

We were using the generic array backing store allocation path for
RegExpMatchesArray which meant starting with 4 slots and then growing
it dynamically as we append. Since we always know the final number of
entries up front, allocate a perfectly-sized backing store right away.

~2% progression on Octane/regexp.

Reviewed by Geoffrey Garen.

• runtime/JSArray.h:

(JSC::createArrayButterflyWithExactLength):

• runtime/RegExpMatchesArray.cpp:

(JSC::RegExpMatchesArray::create):

5:30 PM Changeset in webkit [172617] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Dragging Undocked inspector by window title has broken behavior
​https://bugs.webkit.org/show_bug.cgi?id=135950

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

On Mac ports where we the inspector content goes everywhere, window dragging behavior
still exists for the top 22px of the window. So don't do our JavaScript based window
dragging for this special region.

• UserInterface/Models/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.Modifier.get CommandOrControl):
(WebInspector.KeyboardShortcut.prototype.get displayName):
Instead of calling a host function, use the value already in the frontend.

5:21 PM Changeset in webkit [172616] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk/Source/WebCore

Implement scroll snapping animations on Mac
​https://bugs.webkit.org/show_bug.cgi?id=135768

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-08-14
Reviewed by Beth Dakin.

Implementing the scroll snap animations required for snapping in both overflow and mainframe areas on Mac.
Since we receive a series of discrete wheel events, we need to predict the distance we need to traverse,
compute the appropriate snap point, and then compute an animation curve to that location. The snap animations
are split into two types: snapping, which handles letting go of the trackpad with zero velocity, and gliding,
which handles flick gestures. In both cases, sinusoidal curves are used to ease animation to the target
location. In the former case, the initial velocity is low, and increases to a maximum value during the middle
of the animation before decreasing to 0. In the latter case, the curve is computed such that the initial
velocity matches the user's scroll velocity, and the final velocity matches a lower final velocity that is
somewhat arbitrarily computed. (See the FIXME in AxisScrollSnapOffsets::initializeGlideParameters). How the
equations and constants were chosen is described in greater detail in the comments above
AxisScrollSnapOffsets::computeGlideDelta and AxisScrollSnapOffsets::computeSnapDelta. Note that the final
velocity should ideally be equal to 0. However, with this particular curve, this caused the animation to feel
too slow near the snap point.

No tests, since there is no observable change in behavior. Tests will be included when iOS and Mac scrolling
areas hook into this code.

• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::closestSnapOffset): Computes the closest snap offset given velocity and prdicted destination.

• page/scrolling/AxisScrollSnapOffsets.h:
• platform/mac/AxisScrollSnapAnimator.h: Added.

(WebCore::AxisScrollSnapAnimatorClient::~AxisScrollSnapAnimatorClient):

• platform/mac/AxisScrollSnapAnimator.mm: Added.

(WebCore::toWheelEventStatus): Converts a pair of PlatformWheelEventPhases to a WheelEventStatus.
(WebCore::projectedInertialScrollDistance): Attempts to predict the distance covered by the inertial scrolling phase.
(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
(WebCore::AxisScrollSnapAnimator::handleWheelEvent): Updates the internal state of the AxisScrollSnapAnimator, given a PlatformWheelEvent
(WebCore::AxisScrollSnapAnimator::shouldOverrideWheelEvent): Determines whether or not we should override a wheel event given the animator's internal state.
(WebCore::AxisScrollSnapAnimator::scrollSnapAnimationUpdate): Updates a single loop of the scroll snapping animation.
(WebCore::AxisScrollSnapAnimator::beginScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::computeSnapDelta): See comments for more information.
(WebCore::AxisScrollSnapAnimator::computeGlideDelta): See comments for more information.
(WebCore::AxisScrollSnapAnimator::initializeGlideParameters):
(WebCore::AxisScrollSnapAnimator::pushInitialWheelDelta):
(WebCore::AxisScrollSnapAnimator::averageInitialWheelDelta):
(WebCore::AxisScrollSnapAnimator::clearInitialWheelDeltaWindow):

5:18 PM Changeset in webkit [172615] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Split console toggle button wrong - Images/Images/SplitToggleUp.svg does not exist
​https://bugs.webkit.org/show_bug.cgi?id=135957

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
Wrong image path passed to platformImagePath.

4:59 PM Changeset in webkit [172614] by commit-queue@webkit.org

• 39 edits in trunk/Source

Allow high fidelity type profiling to be enabled and disabled.
​https://bugs.webkit.org/show_bug.cgi?id=135423

Patch by Saam Barati <​sbarati@apple.com> on 2014-08-14
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• Merged op_put_to_scope_with_profile and op_get_from_scope_with_profile into op_profile_types_with_high_fidelity by adding extra arguments to the opcode.
• Altered SymbolTable to use less memory by adding a rare data structure for type profiling.
• Created an interface to turn on and off type profiling from the Web Inspector.
• Refactored how entries are written to HighFidelityLog to make it easier to inline when generating machine code.
• Implemented op_profile_types_with_high_fidelity in the baseline JIT by inlining the process of writing to the log and doing a small amount of type inference optimizations.

• bytecode/BytecodeList.json:
• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::scopeDependentProfile): Deleted.

• bytecode/CodeBlock.h:
• bytecode/TypeLocation.h:

(JSC::TypeLocation::TypeLocation):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity):
(JSC::BytecodeGenerator::emitGetFromScopeWithProfile): Deleted.
(JSC::BytecodeGenerator::emitPutToScopeWithProfile): Deleted.

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::ThisNode::emitBytecode):
(JSC::ResolveNode::emitBytecode):
(JSC::BracketAccessorNode::emitBytecode):
(JSC::DotAccessorNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
(JSC::PrefixNode::emitResolve):
(JSC::PrefixNode::emitBracket):
(JSC::PrefixNode::emitDot):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::AssignDotNode::emitBytecode):
(JSC::ReadModifyDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):
(JSC::ReadModifyBracketNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):

• inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::TypeRecompiler::operator()):
(Inspector::recompileAllJSFunctionsForTypeProfiling):
(Inspector::InspectorRuntimeAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorRuntimeAgent::enableHighFidelityTypeProfiling):
(Inspector::InspectorRuntimeAgent::disableHighFidelityTypeProfiling):
(Inspector::InspectorRuntimeAgent::setHighFidelityTypeProfilingEnabledState):

• inspector/agents/InspectorRuntimeAgent.h:
• inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend):

• inspector/protocol/Runtime.json:
• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

• jit/JIT.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_types_with_high_fidelity):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_types_with_high_fidelity):

• jit/JITOperations.cpp:
• jit/JITOperations.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::getFromScopeCommon): Deleted.
(JSC::LLInt::putToScopeCommon): Deleted.

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:
• runtime/HighFidelityLog.cpp:

(JSC::HighFidelityLog::initializeHighFidelityLog):
(JSC::HighFidelityLog::~HighFidelityLog):
(JSC::HighFidelityLog::processHighFidelityLog):

• runtime/HighFidelityLog.h:

(JSC::HighFidelityLog::LogEntry::structureIDOffset):
(JSC::HighFidelityLog::LogEntry::valueOffset):
(JSC::HighFidelityLog::LogEntry::locationOffset):
(JSC::HighFidelityLog::recordTypeInformationForLocation):
(JSC::HighFidelityLog::logEndPtr):
(JSC::HighFidelityLog::logStartOffset):
(JSC::HighFidelityLog::currentLogEntryOffset):

• runtime/HighFidelityTypeProfiler.cpp:

(JSC::HighFidelityTypeProfiler::logTypesForTypeLocation):
(JSC::descriptorMatchesTypeLocation):

• runtime/HighFidelityTypeProfiler.h:
• runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):
(JSC::SymbolTable::cloneCapturedNames):
(JSC::SymbolTable::prepareForHighFidelityTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForRegister):
(JSC::SymbolTable::globalTypeSetForRegister):
(JSC::SymbolTable::globalTypeSetForVariable):

• runtime/SymbolTable.h:

(JSC::SymbolTable::add):
(JSC::SymbolTable::set):

• runtime/TypeLocationCache.cpp:

(JSC::TypeLocationCache::getTypeLocation):

• runtime/TypeSet.cpp:

(JSC::TypeSet::getRuntimeTypeForValue):
(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::allPrimitiveTypeNames):
(JSC::TypeSet::addTypeForValue): Deleted.

• runtime/TypeSet.h:
• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::nextTypeLocation):
(JSC::VM::enableHighFidelityTypeProfiling):
(JSC::VM::disableHighFidelityTypeProfiling):
(JSC::VM::dumpHighFidelityProfilingTypes):

• runtime/VM.h:

(JSC::VM::nextLocation): Deleted.

Source/WebCore:

PageRuntimeAgent and WorkerRuntimeAgent now call their super
class's (InspectorRuntimeAgent) implementation of willDestroyFrontendAndBackend
to give InspectorRuntimeAgent a chance to recompile all JavaScript
functions, if necessary, for type profiling.

• inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::willDestroyFrontendAndBackend):

• inspector/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::willDestroyFrontendAndBackend):

4:50 PM Changeset in webkit [172613] by Lucas Forschler

• 5 edits in branches/safari-600.1-branch/Source

Versioning.

4:43 PM Changeset in webkit [172612] by Lucas Forschler

• 1 copy in tags/Safari-600.1.10

New Tag.

3:59 PM Changeset in webkit [172611] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172609. <rdar://problem/18023620>

3:56 PM Changeset in webkit [172610] by Lucas Forschler

• 5 edits in branches/safari-600.1-branch

Merged r172604. <rdar://problem/18022221>

3:22 PM Changeset in webkit [172609] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Win] Correct build when DerivedSources location not supplied by build environment
​https://bugs.webkit.org/show_bug.cgi?id=135954
<rdar://problem/18023620>

Reviewed by Joseph Pecoraro.

The DerivedSourcesDirectory is not always defined, depending on what
solution is being used to build this project. Instead, just define
it directly, since we already know where it needs to go.

Also:

1. Stop redirecting the copy output to NUL so I can see if this fails in the future.
2. Make sure the target directory exists before copying to it.

• WebCore.vcxproj/copyForwardingHeaders.cmd: Properly specify

the directories for copying the JS file.

2:39 PM Changeset in webkit [172608] by ggaren@apple.com

• 2 edits in trunk/Source/bmalloc

Fixed a bmalloc crash seen on the EWS bot
​https://bugs.webkit.org/show_bug.cgi?id=135955

Reviewed by Andreas Kling.

• bmalloc/Syscall.h: Some CG APIs vm_copy their input buffers. If the

input buffer is a malloc region, that region will get marked Copy-On-Write
by the kernel. Calls to madvise() for COW regions fail and return EINVAL
on older OS X's. In 10.10, they still fail, but they do not return
EINVAL.

So, we can only ASSERT that our syscalls succeed starting with 10.10.

2:36 PM Changeset in webkit [172607] by zoltan@webkit.org

• 2 edits in trunk/Source/WebCore

[CSS3-Text] Cosmetics on RenderBlockFlow::textAlignmentForLine
​https://bugs.webkit.org/show_bug.cgi?id=135940

Reviewed by Darin Adler.

Processing the not CSS3_TEXT case first, and removing an extra whitespace after r172524.

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::textAlignmentForLine):

2:34 PM Changeset in webkit [172606] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Avoid re-binding the same function over and over
​https://bugs.webkit.org/show_bug.cgi?id=135949

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

• UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype._startAutoCapturing):
(WebInspector.TimelineManager.prototype._stopAutoRecordingSoon):
(WebInspector.TimelineManager.prototype._resetAutoRecordingDeadTimeTimeout):
Stash a bound copy of the function once, and reuse it.

2:17 PM Changeset in webkit [172605] by ggaren@apple.com

• 2 edits in trunk/Source/bmalloc

Fixed the bmalloc build
​https://bugs.webkit.org/show_bug.cgi?id=135953

Reviewed by Andreas Kling.

• bmalloc.xcodeproj/project.pbxproj: Marked a few headers as private.

These headers are used, so they must be available outside the project.

2:09 PM Changeset in webkit [172604] by Brent Fulgham

• 5 edits in trunk

[Win] Extend auto-version and version-stamp for RC_ProjectBuildVersion
​https://bugs.webkit.org/show_bug.cgi?id=135948
<rdar://problem/18022221>

Reviewed by David Kilzer.

Tools:

• Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl: Add tests

for RC_ProjectBuildVersion.

WebKitLibraries:

• win/tools/scripts/auto-version.pl:

(splitVersion): Use RC_ProjectBuildVersion (or RC_PROJECTBUILDVERSION) if set
in the environment as the 'Build Version', unless the multi-tuple version
supplied by RC_ProjectSourceVersion already has a fourth component.

• win/tools/scripts/version-stamp.pl: Check for RC_ProjectBuildVersion and

use it in preference to RC_PROJECTBUILDVERSION.

2:04 PM Changeset in webkit [172603] by mhock@apple.com

• 3 edits
  3 adds in trunk

IndexedDB should respect SchemeRegistry's database access setting.
​https://bugs.webkit.org/show_bug.cgi?id=135890
<rdar://problem/17989469>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: storage/indexeddb/open-db-private-browsing.html

• Modules/indexeddb/IDBFactory.cpp:

LayoutTests:

• storage/indexeddb/open-db-private-browsing-expected.txt: Added.
• storage/indexeddb/open-db-private-browsing.html: Added. Simple test to open database in private browsing mode.
• storage/indexeddb/resources/open-db-private-browsing.js: Added.

1:58 PM Changeset in webkit [172602] by dfarler@apple.com

• 2 edits in trunk/Tools

[iOS] run-webkit-tests runs webkit-build-directory on every test
​https://bugs.webkit.org/show_bug.cgi?id=135409

Reviewed by Daniel Bates.

• Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init): Cache Mac build directory.
(IOSSimulatorPort.relay_path): Use cached build directory.
(IOSSimulatorPort._path_to_image_diff): Use cached build directory.

1:40 PM Changeset in webkit [172601] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines can get caught in requestAnimationFrame loop when not recording
​https://bugs.webkit.org/show_bug.cgi?id=135946

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-08-14
Reviewed by Timothy Hatcher.

Each TimelineContentView was listening for the TimelineManager's start/stop
capturing events. However, only the active recording could possibly update.
Likewise, if a pre-existing recording started and stopped we did not properly
stop in the case where we were waiting for an event to update the current time,
which would result in an infinite rAF loop of no updates.

• UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.unloaded):
When a timeline recording is unloaded trigger an event.

• UserInterface/Views/TimelineContentView.js:

(WebInspector.TimelineContentView.prototype._startUpdatingCurrentTime):
Assert we were not already waiting.

(WebInspector.TimelineContentView.prototype._stopUpdatingCurrentTime):
Properly handle the case of starting/stoping an already existing recording
without a new event coming in.

(WebInspector.TimelineContentView.prototype._recordingTimesUpdated):
(WebInspector.TimelineContentView.prototype._recordingReset):
Convert to a boolean instead of deleting state.

(WebInspector.TimelineContentView.prototype._recordingUnloaded):
Stop listening to timeline manager events that no longer affect unloaded recordings.

12:46 PM Changeset in webkit [172600] by yoav@yoav.ws

• 2 edits in trunk/Source/WebCore

srcset with w descriptor doesn't behave as expected when sizes is not supported.
​https://bugs.webkit.org/show_bug.cgi?id=135935

Reviewed by Dean Jackson.

In current implementation, if sizes is not supported, when authors would write
markup such as <img src=fallback.jpg srcset="100px.jpg 100w, 400px.jpg 400w">
the first candidate in srcset would be picked, regardless of its dimensions
That is likely to be confusing for authors.
Dropping these "not yet supported" candidates is likely to be less confusing,
and will result in the "fallback.jpg" candidate being picked.

No new tests since this change only concerns builds that are built
with the PICTURE_SIZES compile flag turned off.

• html/parser/HTMLSrcsetParser.cpp:

(WebCore::parseDescriptors):
Drop candidates that include either 'w' or 'h' descriptors when the
sizes feature is not supported.

12:38 PM Changeset in webkit [172599] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Make inherited style and parent renderer references
​https://bugs.webkit.org/show_bug.cgi?id=135857

Reviewed by Andreas Kling.

We don't recurse into non-rendered subtrees anymore so they can't be null.
Also stop using Element::renderStyle() as it differs from e->renderer().style() in
some rare cases (that should be fixed).

• style/StyleResolveTree.cpp:

(WebCore::Style::RenderTreePosition::parent):
(WebCore::Style::RenderTreePosition::RenderTreePosition):
(WebCore::Style::RenderTreePosition::canInsert):
(WebCore::Style::RenderTreePosition::insert):
(WebCore::Style::RenderTreePosition::computeNextSibling):
(WebCore::Style::shouldCreateRenderer):
(WebCore::Style::styleForElement):
(WebCore::Style::createRendererIfNeeded):
(WebCore::Style::textRendererIsNeeded):
(WebCore::Style::createTextRendererIfNeeded):
(WebCore::Style::updateTextRendererAfterContentChange):
(WebCore::Style::attachChildren):
(WebCore::Style::attachDistributedChildren):
(WebCore::Style::attachShadowRoot):
(WebCore::Style::resetStyleForNonRenderedDescendants):
(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachRenderTree):
(WebCore::Style::resolveLocal):
(WebCore::Style::resolveShadowTree):
(WebCore::Style::updateBeforeOrAfterPseudoElement):
(WebCore::Style::resolveTree):

12:28 PM Changeset in webkit [172598] by oliver@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Update scope resolution to assume that the parent activation is always there
​https://bugs.webkit.org/show_bug.cgi?id=135947

Reviewed by Andreas Kling.

Another incremental step in removing the idea of lazily created
activations.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitResolveClosure):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitResolveClosure):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

11:54 AM Changeset in webkit [172597] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

[Forms] We should share RenderStyle object for optgroup and option element
​https://bugs.webkit.org/show_bug.cgi?id=88405

Reviewed by Andreas Kling.

We can remove this special case now.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):

11:36 AM Changeset in webkit [172596] by enrica@apple.com

• 2 edits in trunk/Source/WebKit2

[Services with UI] Selection services don't work inside <iframes>.
​https://bugs.webkit.org/show_bug.cgi?id=135941
<rdar://problem/17957690>

Reviewed by Tim Horton.

Need to map the selection rectangles using the correct FrameView.
When handling the click, we must use the selection from the focused frame.

• WebProcess/WebPage/mac/ServicesOverlayController.mm:

(WebKit::ServicesOverlayController::buildSelectionHighlight):
(WebKit::ServicesOverlayController::handleClick):

11:17 AM Changeset in webkit [172595] by mrowe@apple.com

• 6 edits in trunk/Source

<​https://webkit.org/b/135909> Move helper applications out of the root of the framework.

As described in <​https://developer.apple.com/library/mac/technotes/tn2206/>, for bundles containing
a Versions directory there may be no other content at the top level of the bundle other than symlinks.
Upcoming changes to code signing will prevent bundles that violate this rule from being signed.

Reviewed by Sam Weinig.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj: Add the symlink to WebKitPluginHost.app in the Versions/A

directory of the framework rather than at the top level.

Source/WebKit2:

• Configurations/Base.xcconfig: Define a configuration setting that points to the content directory

of the framework. On OS X this is Versions/A. On iOS, where frameworks are shallow, this is the top level.

• Configurations/BaseLegacyProcess.xcconfig: Install the legacy processes in the content directory

of the framework.

• WebKit2.xcodeproj/project.pbxproj: Copy the legacy processes into the content directory of the

framework during engineering builds. Generate symlinks for the legacy processes to their locations
in Versions/Current. This is necessary because -[NSBundle pathForAuxiliaryExecutable:] only looks
at the top level of the framework wrapper.

11:07 AM Changeset in webkit [172594] by oliver@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Create activations eagerly
​https://bugs.webkit.org/show_bug.cgi?id=135942

Reviewed by Geoffrey Garen.

Prepare to rewrite activation objects into a more
sane implementation. Step 1 is reverting to eager
creation of the activation object. This results in
a 1.35x regression in earley, but otherwise has a
minimal performance impact.

The earley regression is being tracked by bug #135943

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunctionInternal):
(JSC::BytecodeGenerator::emitNewFunctionExpression):
(JSC::BytecodeGenerator::emitCallEval):
(JSC::BytecodeGenerator::emitPushWithScope):
(JSC::BytecodeGenerator::emitPushCatchScope):
(JSC::BytecodeGenerator::createActivationIfNecessary): Deleted.

• bytecompiler/BytecodeGenerator.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_create_activation):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_create_activation):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

10:59 AM Changeset in webkit [172593] by achristensen@apple.com

• 1 edit
  1 delete in trunk/Source/WebKit

Unreviewed. Removing empty directories.

• qt: Removed.
• qt/declarative: Removed.
• qt/docs: Removed.
• qt/docs/webkitsnippets: Removed.
• qt/examples: Removed.
• qt/tests: Removed.
• qt/tests/MIMESniffing: Removed.
• qt/tests/benchmarks: Removed.
• qt/tests/qgraphicswebview: Removed.
• qt/tests/qwebelement: Removed.
• qt/tests/qwebframe: Removed.
• qt/tests/qwebhistory: Removed.
• qt/tests/qwebpage: Removed.
• qt/tests/qwebsecurityorigin: Removed.
• qt/tests/qwebview: Removed.

10:52 AM Changeset in webkit [172592] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

WebKit2GTK - WebKitWebProcess assertion fails when dragging and dropping a file into the view
​https://bugs.webkit.org/show_bug.cgi?id=127576

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-14
Reviewed by Carlos Garcia Campos.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragControllerAction): Assume read access
to any file that has been dragged into the web view when compiling for
GTK, since we don't support sandbox extensions.

10:49 AM Changeset in webkit [172591] by Antti Koivisto

• 10 edits in trunk/Source/WebCore

Remove nonRendererStyle
​https://bugs.webkit.org/show_bug.cgi?id=135938

Reviewed by Andreas Kling.

It is used to support styling of non-renderer option elements. We have a better
mechanism for this, Element::computedStyle().

• dom/Element.cpp:

(WebCore::Element::resetComputedStyle):
(WebCore::Element::willResetComputedStyle):

Add a virtual callback for computed style reset.

• dom/Element.h:
• dom/Node.h:

(WebCore::Node::nonRendererStyle): Deleted.

• dom/NodeRenderStyle.h:

(WebCore::Node::renderStyle):

renderStyle() now always matches renderer()->style()

• html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::HTMLOptGroupElement):
(WebCore::HTMLOptGroupElement::isFocusable):
(WebCore::HTMLOptGroupElement::didAttachRenderers): Deleted.
(WebCore::HTMLOptGroupElement::willDetachRenderers): Deleted.
(WebCore::HTMLOptGroupElement::updateNonRenderStyle): Deleted.
(WebCore::HTMLOptGroupElement::nonRendererStyle): Deleted.
(WebCore::HTMLOptGroupElement::customStyleForRenderer): Deleted.

• html/HTMLOptGroupElement.h:
• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isFocusable):

Use computedStyle.

(WebCore::HTMLOptionElement::willResetComputedStyle):
(WebCore::HTMLOptionElement::didAttachRenderers): Deleted.
(WebCore::HTMLOptionElement::willDetachRenderers): Deleted.
(WebCore::HTMLOptionElement::updateNonRenderStyle): Deleted.
(WebCore::HTMLOptionElement::nonRendererStyle): Deleted.
(WebCore::HTMLOptionElement::customStyleForRenderer): Deleted.
(WebCore::HTMLOptionElement::didRecalcStyle): Deleted.

• html/HTMLOptionElement.h:
• rendering/RenderMenuList.cpp:

(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):

Use computedStyle.

9:39 AM Changeset in webkit [172590] by Lucas Forschler

• 3 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172584. <rdar://problem/18015428>

9:37 AM Changeset in webkit [172589] by Lucas Forschler

• 1 edit in branches/safari-600.1-branch/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.css

Merge patch from <rdar://problem/18016176>.

9:27 AM Changeset in webkit [172588] by Lucas Forschler

• 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r172506. <rdar://problem/17810998>

9:21 AM Changeset in webkit [172587] by commit-queue@webkit.org

• 4 edits in trunk

Add support for ppc, ppc64, ppc64le, s390, s390x into the CMake build
​https://bugs.webkit.org/show_bug.cgi?id=135937

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-08-14
Reviewed by Carlos Garcia Campos.

• CMakeLists.txt:

9:08 AM Changeset in webkit [172586] by zandobersek@gmail.com

• 3 edits in trunk/Tools

Initialize a separate variable (TestWTF_SOURCES) with the list of files
that are built into the TestWTF executable and move it above the platform-specific
config file inclusion. This makes it possible to add platform-specific files to that
list (e.g. GUniquePtr.cpp for the GTK port).

Rubber-stamped by Carlos Garcia Campos.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/PlatformGTK.cmake:

9:06 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

8:58 AM Changeset in webkit [172585] by clopez@igalia.com

• 4 edits
  1 add
  1 delete in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Update expectations with new identified failures and flakiness.
• platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt: Rebaseline after r172517.
• platform/gtk/fast/ruby/ruby/ruby-base-merge-block-children-crash-2-expected.png: Removed. File was in wrong path.
• platform/gtk/fast/ruby/ruby/ruby-base-merge-block-children-crash-2-expected.txt: Removed. File was in wrong path.
• platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Rebaseline after r172136.
• platform/gtk/scrollbars/scrollbar-selectors-expected.txt: Added. Rebaseline after r172220.

8:13 AM Changeset in webkit [172584] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

[MSE] Altering the quality of a YouTube video will cause the video to distort and display an error message
​https://bugs.webkit.org/show_bug.cgi?id=135931

Reviewed by Eric Carlson.

When removing samples from the TrackBuffer's sample map, also remove those samples from the
TrackBuffer's decode queue. Otherwise, removed samples may persist in the decode queue and
either break sync-sample dependencies or cause decoding artifacts.

Pull the code which removes samples from a track buffer into its own utility function, and
use this function both from removeCodedFrames(), and also when samples are removed due to
overlapping appends in sourceBufferPrivateDidReceiveSample(). In order to reference
TrackBuffers outside of SourceBuffer (and in the static removeSamplesFromTrackBuffer()
function), make TrackBuffer a public forward declaration.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBuffer::removeCodedFrames):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

• Modules/mediasource/SourceBuffer.h:

7:44 AM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com

(diff)

6:10 AM Changeset in webkit [172583] by Carlos Garcia Campos

• 3 edits in trunk

[GTK] REGRESSION(r171598, CMake): Introspection files are installed at the wrong path
​https://bugs.webkit.org/show_bug.cgi?id=135934

Reviewed by Gustavo Noronha Silva.

Since r171598 gir files are installed under $datadir/webkitgtk-4.0/gir-1.0/.
The gir files should installed in $datadir/gir-1.0/ together with all other
gir files. We don't need to install introspection files in a versioned
directory because their filenames already contain the binary version. But before
r171598, the files were only installed to the right directory if the
gobject-instrospection pkg-config file was in the same prefix than the one we
wanted to install, because the gir and typelibs directories were extracted from
the pkg-config file. We should define INTROSPECTION_INSTALL_GIRDIR and
INTROSPECTION_INSTALL_TYPELIBDIR in OptionsGTK.cmake based on $datadir and $libdir
like we do in the autotools build.

• Source/cmake/FindGObjectIntrospection.cmake: Do not define

INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.

• Source/cmake/OptionsGTK.cmake: Define

INTROSPECTION_INSTALL_GIRDIR and INTROSPECTION_INSTALL_TYPELIBDIR.

4:13 AM Changeset in webkit [172582] by mihnea@adobe.com

• 1 edit
  8 moves
  1 add in trunk/LayoutTests

[CSSRegions] Move svg tests into fast/regions/svg
​https://bugs.webkit.org/show_bug.cgi?id=135883

Reviewed by Andrei Bucur.

Move tests and adjust paths accordingly.

• fast/regions/svg/svg-doc-fragment-not-collected-expected.html: Renamed from LayoutTests/fast/regions/svg-doc-fragment-not-collected-expected.html.
• fast/regions/svg/svg-doc-fragment-not-collected.html: Renamed from LayoutTests/fast/regions/svg-doc-fragment-not-collected.html.
• fast/regions/svg/svg-element-not-collected-expected.html: Renamed from LayoutTests/fast/regions/svg-element-not-collected-expected.html.
• fast/regions/svg/svg-element-not-collected.html: Renamed from LayoutTests/fast/regions/svg-element-not-collected.html.
• fast/regions/svg/svg-root-element-collected-expected.txt: Renamed from LayoutTests/fast/regions/svg-root-element-collected-expected.txt.
• fast/regions/svg/svg-root-element-collected.html: Renamed from LayoutTests/fast/regions/svg-root-element-collected.html.
• fast/regions/svg/symbol-in-named-flow-crash-expected.txt: Renamed from LayoutTests/fast/regions/symbol-in-named-flow-crash-expected.txt.
• fast/regions/svg/symbol-in-named-flow-crash.svg: Renamed from LayoutTests/fast/regions/symbol-in-named-flow-crash.svg.

3:31 AM Changeset in webkit [172581] by Carlos Garcia Campos

• 2 edits in trunk

[GTK] WebKit DOM documentation (webkitdomgtk) not installed after make install
​https://bugs.webkit.org/show_bug.cgi?id=135836

Reviewed by Philippe Normand.

• Source/PlatformGTK.cmake: Add install command to also install

the GObject DOM bindings API docs.

2:35 AM Changeset in webkit [172580] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

ImageBufferDataCairo.h is missing header guards
​https://bugs.webkit.org/show_bug.cgi?id=135933

Reviewed by Philippe Normand.

• platform/graphics/cairo/ImageBufferDataCairo.h:

Add the missing head guards to avoid problems when re-inclusion occurs.

2:33 AM Changeset in webkit [172579] by zandobersek@gmail.com

• 2 edits in trunk

Unreviewed. In r165709 I mistakenly appended the -fno-exceptions
and -fno-strict-aliasing compiler flags to CMAKE_CXX_FLAGS and then
re-set CMAKE_C_FLAGS with the new string. The two flags should really
be appended to CMAKE_C_FLAGS and the same variable re-set with the
new string.

• Source/cmake/OptionsCommon.cmake:

1:49 AM Changeset in webkit [172578] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix JSC::ARM64Assembler::LinkRecord::RealTypes
​https://bugs.webkit.org/show_bug.cgi?id=135906

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-08-14
Reviewed by Michael Saboff.

JSC::ARM64Assembler::LinkRecord::RealTypes::m_compareRegister is defined
to occupy 5 bits but JSC::ARM64Assembler::RegisterID needs 6 bits. So,
increase the size of the bit field and also reorganize the struct to
better align with word boundaries.

• assembler/ARM64Assembler.h: