Timeline
Sep 10, 2014:
- 11:41 PM Changeset in webkit [173508] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
https://bugs.webkit.org/show_bug.cgi?id=136698
Patch by Tanay C <tanay.c@samsung.com> on 2014-09-10
Reviewed by Gyuyoung Kim.
- MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
(on_mouse_wheel): Added.
(window_free):
(window_create):
- 9:42 PM Changeset in webkit [173507] by
-
- 4 edits in trunk/Source/WebCore
Use ASSERT instead of ASSERT_WITH_SECURITY_IMPLICATION
https://bugs.webkit.org/show_bug.cgi?id=136732
Reviewed by Andy Estes.
Since r173458 changed to use static_cast<> with toFoo, ASSERT_WITH_SECURITY_IMPLICATION doesn't
need to be used anymore. ASSERT is enough for it.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
- 9:01 PM Changeset in webkit [173506] by
-
- 2 edits in trunk/Source/WebCore
[SVG] Cleanup iterator code in SMILTimeContainer using range-based loop
https://bugs.webkit.org/show_bug.cgi?id=136720
Reviewed by Filip Pizlo.
No new tests, no change on behavior.
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):
(WebCore::SMILTimeContainer::updateAnimations):
- 7:37 PM Changeset in webkit [173505] by
-
- 13 edits1 add in trunk/Source
Web Inspector: Modify the type profiler runtime protocol to transfer some computation into the WebInspector
https://bugs.webkit.org/show_bug.cgi?id=136500
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
This patch changes the type profiler protocol to the Web Inspector
by moving the work of calculating computed properties that effect the UI
into the Web Inspector. This makes the Web Inspector have control over the
strings it displays as UI elements representing type information to the user
instead of JavaScriptCore deciding on a convention for these strings.
JavaScriptCore now sends enough information to the Web Inspector so that
it can compute the properties JavaScriptCore used to compute.
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
- inspector/protocol/Runtime.json:
- runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::getTypesForVariableAtOffsetForInspector): Deleted.
- runtime/TypeProfiler.h:
- runtime/TypeSet.cpp:
(JSC::TypeSet::inspectorTypeSet):
(JSC::StructureShape::leastCommonAncestor):
(JSC::StructureShape::inspectorRepresentation):
- runtime/TypeSet.h:
Source/WebInspectorUI:
This patch maintains the same UI in the Web Inspector for displaying
type information, but now accounts for the new protocol for type profiling.
The Inspector now has a TypeSet class that wraps the TypeDescription
protocol object and creates a simple interface for asking protocol objects
about their type.
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):
- UserInterface/Main.html:
- UserInterface/Models/TypeSet.js: Added.
(WebInspector.TypeSet):
(WebInspector.TypeSet.fromPayload):
(WebInspector.TypeSet.prototype.isContainedIn):
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation.handler):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptTypeInformation):
- UserInterface/Views/TypePropertiesSection.js:
(WebInspector.TypePropertiesSection.prototype.onpopulate):
(WebInspector.TypePropertyTreeElement.prototype.onpopulate):
- UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView.prototype.update):
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
(WebInspector.TypeTokenView.prototype._displayTypeName):
- 6:47 PM Changeset in webkit [173504] by
-
- 3 edits in trunk/Source/WebCore
Fix the build.
- platform/network/ResourceHandle.h:
- platform/network/mac/ResourceHandleMac.mm:
- 6:25 PM Changeset in webkit [173503] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
https://bugs.webkit.org/show_bug.cgi?id=136284
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-09-10
Reviewed by Gyuyoung Kim.
- MiniBrowser/efl/main.c:
(window_create):
- 5:50 PM Changeset in webkit [173502] by
-
- 6 edits in trunk/Source/WebCore
Delete class SavedDrawingStateForMask
https://bugs.webkit.org/show_bug.cgi?id=136498
Patch by Myles C. Maxfield <mmaxfield@apple.com> <litherum@gmail.com> on 2014-09-09
Reviewed by Darin Adler.
This class is left over from when text-decoration-skip: ink used
GraphicsContext masking.
No new tests because there is no behavior change.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
- rendering/InlineTextBox.h:
- rendering/TextPainter.cpp:
(WebCore::TextPainter::TextPainter):
(WebCore::paintTextWithShadows):
(WebCore::TextPainter::paintText):
- rendering/TextPainter.h:
(WebCore::SavedDrawingStateForMask::SavedDrawingStateForMask): Deleted.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintTextWithShadows):
- 5:47 PM Changeset in webkit [173501] by
-
- 3 edits in trunk/Source/WebCore
Call setCollectsTimingData only once, and before making any {CF,NS}URLConnections
https://bugs.webkit.org/show_bug.cgi?id=136731
<rdar://problem/18252844>
Reviewed by Simon Fraser.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
Move setCollectsTimingData to before createCFURLConnection, so the first connection
has timing data associated with it.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
Move setCollectsTimingData to before we create our NSURLConnection, so the first connection
has timing data associated with it.
Use setCollectsTimingData instead of the NSURLConnection SPI directly.
(WebCore::ResourceHandle::setCollectsTimingData):
Only call _setCollectsTimingData once.
- 5:38 PM Changeset in webkit [173500] by
-
- 12 edits3 adds in trunk/LayoutTests
Unreviewed gardening. Rebaseline failing media/video- tests broken by r156546.
- platform/mac/TestExpectations:
- platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
- platform/mac/media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles-expected.txt: Added.
- platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
- platform/mac/media/video-controls-no-scripting-expected.txt: Added.
- platform/mac/media/video-controls-rendering-expected.png:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/media/video-display-toggle-expected.png:
- platform/mac/media/video-display-toggle-expected.txt:
- platform/mac/media/video-empty-source-expected.png:
- platform/mac/media/video-empty-source-expected.txt:
- platform/mac/media/video-volume-slider-expected.png:
- platform/mac/media/video-volume-slider-expected.txt:
- platform/mac/media/volume-bar-empty-when-muted-expected.txt: Added.
- 5:25 PM Changeset in webkit [173499] by
-
- 11 edits in trunk/Source/WebCore
Remove iOS-only -webkit-composition-fill-color CSS property.
https://bugs.webkit.org/show_bug.cgi?id=136728
rdar://problem/10439154
Reviewed by Tim Horton.
This property is no longer used on iOS.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- editing/EditingStyle.cpp:
- platform/graphics/Color.h:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintCompositionBackground):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- 5:01 PM Changeset in webkit [173498] by
-
- 4 edits in trunk/Tools
import-w3c-tests doesn't handle relative paths to support files in ref files correctly
https://bugs.webkit.org/show_bug.cgi?id=135929
Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-09-10
Reviewed by Bem Jones-Bey.
The recent refactor of the W3C test repo falsified a bunch of assmumptions that
were made when this script was originally written with respect to relative paths
in ref files. This patch updates import-w3c-tests to update paths in ref files if
they move relative to the test file.
- Scripts/webkitpy/w3c/test_converter.py:
(convert_for_webkit):
(_W3CTestConverter.init):
(_W3CTestConverter.convert_reference_relpaths):
(_W3CTestConverter.convert_style_data):
(_W3CTestConverter.convert_attributes_if_needed):
- Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
- Scripts/webkitpy/w3c/test_parser.py:
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.support_files):
- 4:57 PM Changeset in webkit [173497] by
-
- 2 edits in trunk/Source/JavaScriptCore
Apply ARM64-specific lowering to load/store instructions in offlineasm
https://bugs.webkit.org/show_bug.cgi?id=136569
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-09-10
Reviewed by Michael Saboff.
The standard risc lowering of load/store instructions with base +
immediate offset addresses is to move the offset to a temporary, add the
base to the temporary, and then change the load/store to use the
temporary + 0 immediate offset address. However, on ARM64, base +
register offset addressing mode is available, so it is unnecessary to
perform explicit register additions but it is enough to change load/store
to use base + temporary as the address.
- offlineasm/arm64.rb: Added arm64LowerMalformedLoadStoreAddresses
- 4:48 PM Changeset in webkit [173496] by
-
- 2 edits in trunk/LayoutTests
More unreviewed gardening.
- Mark tests as WontFix which depend on platform support which will never be added.
- Fix http/tests/media/video-auth.html by marking it as failing on MountainLion.
- platform/mac/TestExpectations:
- 3:44 PM Changeset in webkit [173495] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Re-skip some obsolete EME tests.
- platform/mac/TestExpectations:
- 3:41 PM Changeset in webkit [173494] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Eliminate typeof "undefined" checks
https://bugs.webkit.org/show_bug.cgi?id=136691
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Alexey Proskuryakov.
- UserInterface/Base/Main.js:
(WebInspector.linkifyURLAsNode):
(WebInspector.linkifyStringAsFragment):
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.prototype._invokeWithArguments):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype.get resizeMethod):
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype.get minimumWidth):
- 3:22 PM Changeset in webkit [173493] by
-
- 3 edits in trunk/Source/WebCore
Remove ImageSource::ShouldSkipMetadata
https://bugs.webkit.org/show_bug.cgi?id=136713
Reviewed by Pratik Solanki.
- platform/graphics/ImageSource.h:
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::createImageSourceOptions):
(WebCore::imageSourceOptions):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
Remove ShouldSkipMetadata and users. Nobody ever uses DoNotSkipMetadata.
- 3:13 PM Changeset in webkit [173492] by
-
- 11 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Fix obscure ESLint warnings and skip directories
https://bugs.webkit.org/show_bug.cgi?id=136686
Reviewed by Timothy Hatcher.
- .eslintignore: Added.
Skip directories we do not want ESLint to process.
- .eslintrc:
Add rules we've seen and sort sections.
- UserInterface/Controllers/FormatterContentBuilder.js:
(FormatterContentBuilder.prototype._appendIndent):
- UserInterface/Models/Color.js:
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
- UserInterface/Views/DOMTreeDataGridNode.js:
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.ondelete):
(WebInspector.DOMTreeElement.prototype._insertInLastAttributePosition):
(WebInspector.DOMTreeElement.prototype._distinctClosingTagElement):
- UserInterface/Views/EditingSupport.js:
(WebInspector.EditingConfig):
- UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype._makeOutlet):
- UserInterface/Views/TreeOutline.js:
(TreeOutline.prototype.appendChild):
(TreeOutline.prototype.insertChild):
(TreeOutline.prototype.removeChildAtIndex):
(TreeOutline.prototype.removeChild):
(TreeElement.prototype.expandRecursively):
Fix linter issues.
- 2:55 PM Changeset in webkit [173491] by
-
- 2 edits in trunk/LayoutTests
Skip some flaky tests that may be affecting subsequent tests.
- platform/mac/TestExpectations:
- 2:52 PM Changeset in webkit [173490] by
-
- 22 edits2 moves in trunk/Source/JavaScriptCore
Rename JSVariableObject to JSEnvironmentRecord to align naming with ES spec
https://bugs.webkit.org/show_bug.cgi?id=136710
Reviewed by Anders Carlsson.
This is a trivial rename.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractHeap.h:
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLAbstractHeapRepository.cpp:
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetClosureRegisters):
- jit/JITOpcodes32_64.cpp:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emitPutClosureVar):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emitPutClosureVar):
- llint/LLIntOffsetsExtractor.cpp:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnNonIndexPropertyNames):
- runtime/JSActivation.h:
- runtime/JSEnvironmentRecord.cpp: Renamed from Source/JavaScriptCore/runtime/JSVariableObject.cpp.
- runtime/JSEnvironmentRecord.h: Renamed from Source/JavaScriptCore/runtime/JSVariableObject.h.
(JSC::JSEnvironmentRecord::registers):
(JSC::JSEnvironmentRecord::registerAt):
(JSC::JSEnvironmentRecord::addressOfRegisters):
(JSC::JSEnvironmentRecord::offsetOfRegisters):
(JSC::JSEnvironmentRecord::JSEnvironmentRecord):
- runtime/JSNameScope.h:
- runtime/JSSegmentedVariableObject.h:
- 2:45 PM Changeset in webkit [173489] by
-
- 5 edits in branches/safari-600.1.4.11-branch/Source/WebKit2
Merged r173450. <rdar://problem/17629840>
- 2:42 PM Changeset in webkit [173488] by
-
- 2 edits in trunk/LayoutTests
"AVF info: hasOfflineRenderer, board-id check : true" in media/track/track-forced-subtitles-in-band.html
https://bugs.webkit.org/show_bug.cgi?id=124219
Unreviewed gardening. This skip was made unnecessary after selective filtering was added in r160247.
- platform/mac/TestExpectations:
- 2:40 PM Changeset in webkit [173487] by
-
- 2 edits in branches/safari-600.1.4.11-branch/Source/WebCore
Merged r173345. <rdar://problem/17457013>
- 2:38 PM Changeset in webkit [173486] by
-
- 2 edits in trunk/LayoutTests
More unreviewed gardening of media/ tests; Move tests into the correct sub-groups and add comments
to test expectations without attached bugzilla bugs (due to WontFix, etc.).
- platform/mac/TestExpectations:
- 2:38 PM Changeset in webkit [173485] by
-
- 1 move in tags/Safari-600.1.17.1
Rename Tag.
- 1:40 PM Changeset in webkit [173484] by
-
- 3 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=136650
Rubber-banding in the DOM view of the WebInspector is really jumpy
-and corresponding-
rdar://problem/18166043
Reviewed by Darin Adler.
This patch implements the ScrollableArea virtual function isRubberBandInProgress()
for RenderLayer, and then uses that to determine whether to clamp the scroll
position in updateScrollInfoAfterLayout().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isRubberBandInProgress):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
- rendering/RenderLayer.h:
- 1:34 PM Changeset in webkit [173483] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 1:32 PM Changeset in webkit [173482] by
-
- 1 copy in tags/safari-600.1.17.1
New Tag.
- 1:30 PM Changeset in webkit [173481] by
-
- 2 edits in branches/safari-600.1.17-branch/Source/WebCore
Merge r173218. rdar://problem/18112559
- 1:14 PM Changeset in webkit [173480] by
-
- 3 edits in trunk/Source/JavaScriptCore
[mips] Add missing parts and fix LLINT mips backend
https://bugs.webkit.org/show_bug.cgi?id=136706
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm: Fix invalid CalleeSave register number.
Implement initPCRelative and setEntryAddress macros.
- llint/LowLevelInterpreter32_64.asm: Fix register distribution in
doVMEntry macro.
- 12:59 PM Changeset in webkit [173479] by
-
- 2 edits in trunk/LayoutTests
More unreviewed gardening; despite the comment, media/audio-repaint.html is failing on all mac ports, not just on Lion.
- platform/mac/TestExpectations:
- 12:26 PM Changeset in webkit [173478] by
-
- 2 edits in trunk/Source/WebCore
Remove a workaround in frameIsCompleteAtIndex for a problem that was fixed in Lion
https://bugs.webkit.org/show_bug.cgi?id=136652
Reviewed by Dan Bernstein.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameIsCompleteAtIndex):
ImageIO returns the right thing now.
- 12:15 PM Changeset in webkit [173477] by
-
- 14 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint consistent-return warnings
https://bugs.webkit.org/show_bug.cgi?id=136682
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
- .eslintrc:
- UserInterface/Controllers/BranchManager.js:
(WebInspector.BranchManager.prototype.createBranch):
- UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload):
- UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.showChild):
(WebInspector.DOMTreeElement.prototype._startEditingTarget):
(WebInspector.DOMTreeElement.prototype._startEditing):
- UserInterface/Views/EditingSupport.js:
- UserInterface/Views/EventListenerSectionGroup.js:
(WebInspector.EventListenerSectionGroup.prototype._nodeTextOrLink):
- UserInterface/Views/FrameContentView.js:
(WebInspector.FrameContentView.prototype._showContentViewForIdentifier):
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar.prototype.insertNavigationItem):
(WebInspector.NavigationBar.prototype.removeNavigationItem):
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole.prototype._insertExecutionContextPathComponentForFrame):
- UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.addSidebarPanel):
(WebInspector.Sidebar.prototype.removeSidebarPanel):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.addStyleClassToLine):
(WebInspector.TextEditor.prototype.removeStyleClassFromLine):
(WebInspector.TextEditor.prototype.toggleStyleClassForLine):
- 11:58 AM Changeset in webkit [173476] by
-
- 3 edits in trunk/Source/WebCore
Laying out a TextRun using an SVG font is O(n2)
https://bugs.webkit.org/show_bug.cgi?id=136584
Reviewed by Darin Adler.
Addressing post-commit review from Darin.
No new tests.
- platform/graphics/Font.h:
(WebCore::Font::treatAsSpace): Un-inline.
(WebCore::Font::treatAsZeroWidthSpace): Ditto.
(WebCore::Font::treatAsZeroWidthSpaceInComplexScript): Ditto.
- svg/SVGFontData.cpp:
(WebCore::computeNormalizedSpaces): Avoid unnecessary copy.
- 11:15 AM Changeset in webkit [173475] by
-
- 4 edits in trunk/LayoutTests
Unreviewed. Fix a snapshotting test. Test was incorrect as it assumed the wrong window size.
- platform/mac-wk2/TestExpectations: Remove some duplicate test expectations.
- platform/mac-wk2/plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image-expected.txt:
- plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html:
- 11:10 AM Changeset in webkit [173474] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Optimization; avoid reallocating string many times.
https://bugs.webkit.org/show_bug.cgi?id=136704
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-10
Reviewed by Alex Christensen.
Adding individual characters to a string is inefficient, the string will be reallocated each time.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::readCurlCookieToken):
- 11:01 AM Changeset in webkit [173473] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 10:45 AM Changeset in webkit [173472] by
-
- 2 edits in trunk/LayoutTests
Rollout r173446, the skipped tests still fail only on the bots.
- platform/mac-wk2/TestExpectations:
- 10:43 AM Changeset in webkit [173471] by
-
- 1 copy in branches/safari-600.1.17-branch
New Branch.
- 10:18 AM Changeset in webkit [173470] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Group all the media expectations together logically.
- platform/mac/TestExpectations:
- 9:43 AM Changeset in webkit [173469] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
TypeSet needs a mode where it no longer profiles structure shapes
https://bugs.webkit.org/show_bug.cgi?id=136263
Reviewed by Filip Pizlo.
The TypeSet data structure used to gather as many StructureShape
objects as it encountered during type profiling. But, this meant
that there was no upper limit on how many objects it could allocate.
This patch places a fixed upper bound on the number of StructureShapes
allocated per TypeSet to prevent using too much memory for little gain
in type profiling usefulness.
StructureShape objects are now also aware of when they are created
from Structures which are dictionaries.
In total, this patch lays the final groundwork needed in refactoring
the inspector protocol for the type profiler.
- runtime/Structure.cpp:
(JSC::Structure::toStructureShape):
- runtime/TypeProfiler.cpp:
(JSC::TypeProfiler::typeInformationForExpressionAtOffset):
- runtime/TypeSet.cpp:
(JSC::TypeSet::TypeSet):
(JSC::TypeSet::addTypeInformation):
(JSC::StructureShape::StructureShape):
(JSC::StructureShape::toJSONString):
(JSC::StructureShape::enterDictionaryMode):
- runtime/TypeSet.h:
(JSC::TypeSet::isOverflown):
- tests/typeProfiler/dictionary-mode.js: Added.
(wrapper):
- tests/typeProfiler/driver/driver.js:
- tests/typeProfiler/overflow.js: Added.
(wrapper.Proto):
(wrapper):
- 9:35 AM Changeset in webkit [173468] by
-
- 7 edits in trunk/Source/WebKit2
NetworkResourceLoader cleanups
https://bugs.webkit.org/show_bug.cgi?id=136701
Reviewed by Darin Adler.
After smashing NetworkResourceLoader together with the clients it can be made nicer.
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleLoader):
(WebKit::NetworkResourceLoadScheduler::removeLoader):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::SynchronousLoadData::SynchronousLoadData):
The original request is now part of the loader.
(WebKit::sendReplyToSynchronousRequest):
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
Instead of copying everything out from NetworkResourceLoadParameters just include the whole thing as a const field.
SanboxExtension construction moves to NetworkResourceLoadParameters::decode()
Stuff that is related to starting the load moves to start().
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::setDefersLoading):
Eliminate m_deferredRequest since we now always remember the original request.
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
(WebKit::NetworkResourceLoader::didFail):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
Eliminate unnecessary m_suggestedRequestForWillSendRequest.
(WebKit::NetworkResourceLoader::wasBlocked):
(WebKit::NetworkResourceLoader::cannotShowURL):
(WebKit::NetworkResourceLoader::shouldUseCredentialStorage):
(WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge):
(WebKit::NetworkResourceLoader::receivedCancellation):
(WebKit::NetworkResourceLoader::startBufferingTimerIfNeeded):
(WebKit::NetworkResourceLoader::consumeSandboxExtensions):
(WebKit::NetworkResourceLoader::invalidateSandboxExtensions):
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::originalRequest):
(WebKit::NetworkResourceLoader::currentRequest):
(WebKit::NetworkResourceLoader::sessionID):
(WebKit::NetworkResourceLoader::defersLoading):
(WebKit::NetworkResourceLoader::isLoadingMainResource):
(WebKit::NetworkResourceLoader::request): Deleted.
(WebKit::NetworkResourceLoader::sendAbortingOnFailure): Deleted.
Made private and moved to cpp.
- NetworkProcess/mac/NetworkDiskCacheMonitor.mm:
(WebKit::NetworkDiskCacheMonitor::NetworkDiskCacheMonitor):
Use original request instead of the current one. This might fix a bug where we didn't use file backing over redirects.
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
Decode to SanboxExtensions to the actual type rather than a handle.
- Shared/Network/NetworkResourceLoadParameters.h:
- 9:22 AM Changeset in webkit [173467] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r173446.
https://bugs.webkit.org/show_bug.cgi?id=136707
These two tests fail consistently on Mavericks and ML WK2
bots. (Requested by jernoble|laptop on #webkit).
Reverted changeset:
"Unskip two snapshotting tests that work for me consistently
locally."
http://trac.webkit.org/changeset/173446
- 9:00 AM Changeset in webkit [173466] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint no-undef warnings
https://bugs.webkit.org/show_bug.cgi?id=136660
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
- UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.prototype._generateClassName):
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
- UserInterface/Models/Gradient.js:
(WebInspector.Gradient.fromString):
- UserInterface/Views/CodeMirrorAdditions.js:
- UserInterface/Views/ReplayDashboardView.js:
(WebInspector.ReplayDashboardView):
- 8:58 AM Changeset in webkit [173465] by
-
- 1 edit1 add in trunk/Source/WebCore
[Curl] Compile error, CertificateInfo.h is not found.
https://bugs.webkit.org/show_bug.cgi?id=136703
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-10
Reviewed by Alex Christensen.
Curl also needs to implement the CertificateInfo class.
- platform/network/curl/CertificateInfo.h: Added.
(WebCore::CertificateInfo::CertificateInfo):
- 8:54 AM Changeset in webkit [173464] by
-
- 7 edits in trunk/Source/WebCore
Clean up some ENABLE(PICTURE_SIZES) stuff, don't change function signatures inside #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=136654
Reviewed by Darin Adler.
Adding parameters inside an #ifdef makes for unreadable code, so remove some
#if ENABLE(PICTURE_SIZES) related to the preload scanner and always pass the arguments.
Reduced the argument count on some functions by just passing a Document&.
Also fix a couple of uses of #if ENABLE_PICTURE_SIZES.
- html/HTMLImageElement.h:
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLSrcsetParser.cpp:
(WebCore::pickBestImageCandidate):
(WebCore::bestFitSourceForImageAttributes):
- html/parser/HTMLSrcsetParser.h:
- 8:51 AM Changeset in webkit [173463] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unused Console search highlight methods
https://bugs.webkit.org/show_bug.cgi?id=136661
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
ESLint's no-undef warning complained about some undefined references
in these functions that would have thrown exceptions. Turns out this
code is unused, and we do highlighting in the console separately.
- UserInterface/Views/ConsoleCommand.js:
(WebInspector.ConsoleCommand.prototype.clearHighlight): Deleted.
(WebInspector.ConsoleCommand.prototype.highlightSearchResults): Deleted.
(WebInspector.ConsoleCommand.prototype.matchesRegex): Deleted.
- UserInterface/Views/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype.clearHighlight): Deleted.
(WebInspector.ConsoleMessageImpl.prototype.highlightSearchResults): Deleted.
(WebInspector.ConsoleMessageImpl.prototype.matchesRegex): Deleted.
- 8:49 AM Changeset in webkit [173462] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint* no-avoidable-bind warnings
https://bugs.webkit.org/show_bug.cgi?id=136690
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-10
Reviewed by Timothy Hatcher.
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.LocalJSONObject.prototype._children):
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
- UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._updateDataGrid):
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._filterMessages):
- UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype.get supplementalRepresentedObjects):
- 7:59 AM Changeset in webkit [173461] by
-
- 2 edits in trunk/Source/JavaScriptCore
[MIPS] branch32WithPatch missing
https://bugs.webkit.org/show_bug.cgi?id=136696
Reviewed by Michael Saboff.
Added the missing branch32WithPatch. The implementation
is currently the same as the branchPtrithPatch because
the macro assembler supports only 32 bit MIPS.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branch32WithPatch):
- 7:57 AM Changeset in webkit [173460] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix !ENABLE(DFG_JIT) build
https://bugs.webkit.org/show_bug.cgi?id=136702
Reviewed by Michael Saboff.
- bytecode/CallEdgeProfile.h:
- 7:47 AM Changeset in webkit [173459] by
-
- 3 edits2 adds in trunk
AX: aria-labelledby is not honoring sub-node text
https://bugs.webkit.org/show_bug.cgi?id=136689
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Test: accessibility/aria-labelledby-with-descendants.html
When aria-labelledby retrieves the textUnderElements it needs to consider
all sub-children, including focusable content.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::accessibleNameForNode):
LayoutTests:
- accessibility/aria-labelledby-with-descendants-expected.txt: Added.
- accessibility/aria-labelledby-with-descendants.html: Added.
- 6:23 AM Changeset in webkit [173458] by
-
- 9 edits in trunk/Source/WebCore
Use toDocument instead of static_cast<Document*>
https://bugs.webkit.org/show_bug.cgi?id=136694
Reviewed by Andy Estes.
Clean up static_cast<Document*>.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::document):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::document):
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::dispatchErrorEvent): Add a line to remove .get().
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::addToWorkerDocuments):
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::document):
(WebCore::XMLHttpRequest::open):
- 3:12 AM Changeset in webkit [173457] by
-
- 13 edits2 deletes in trunk/Source/WebCore
Merge CheckingContexts from SelectorCompiler and SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=135255
Reviewed by Benjamin Poulain.
In this patch, we merge SelectorChecker::SelectorCheckingContext and SelectorCompiler::CheckingContext.
We expose only SelectorChecker::CheckingContext. That is the same to the old SelectorCompiler::CheckingContext.
In SelectorChecker.cpp, we define SelectorChecker::CheckingContextWithStatus and use it internally.
And we move VisitedMatchType from SelectorChecker.h to SelectorChecker.cpp.
VisitedMatchType is also explicitly used by SelectorCheckerFastPath. However, SelectorCheckerFastPath is now
used only from SelectorQuery (Style resolution algorithm no longer uses it: r171059).
In this patch, we remove SelectorCheckerFastPath since the major cases are covered by CSS JIT.
InRightMostWithIdMatch,Element#matchesand multiple selectorsquerySelector('a, b')cases,
CSS JIT is not used. So dropping fast path affects them. But 1) these cases are rare or 2) the target node
is typically only one since nodes are filtered before matching. So it doesn't have performance regression.
And now since CheckingContextWithStatus is the derived class of CheckingContext, we can use
the same test functions; template parameter is not necessary. It reduces code size.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSAllInOne.cpp:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::CheckingContextWithStatus::CheckingContextWithStatus):
(WebCore::SelectorChecker::match):
(WebCore::checkingContextForParent):
(WebCore::SelectorChecker::matchRecursively):
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::SelectorChecker::checkOne):
(WebCore::SelectorChecker::checkScrollbarPseudoClass):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::CheckingContext::CheckingContext):
(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext): Deleted.
- css/SelectorCheckerFastPath.cpp: Removed.
- css/SelectorCheckerFastPath.h: Removed.
- css/SelectorCheckerTestFunctions.h:
(WebCore::scrollbarMatchesEnabledPseudoClass):
(WebCore::scrollbarMatchesDisabledPseudoClass):
(WebCore::scrollbarMatchesHoverPseudoClass):
(WebCore::scrollbarMatchesActivePseudoClass):
(WebCore::scrollbarMatchesHorizontalPseudoClass):
(WebCore::scrollbarMatchesVerticalPseudoClass):
(WebCore::scrollbarMatchesDecrementPseudoClass):
(WebCore::scrollbarMatchesIncrementPseudoClass):
(WebCore::scrollbarMatchesStartPseudoClass):
(WebCore::scrollbarMatchesEndPseudoClass):
(WebCore::scrollbarMatchesDoubleButtonPseudoClass):
(WebCore::scrollbarMatchesSingleButtonPseudoClass):
(WebCore::scrollbarMatchesNoButtonPseudoClass):
(WebCore::scrollbarMatchesCornerPresentPseudoClass):
- css/StyleResolver.h:
(WebCore::checkRegionSelector):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::appendUnoptimizedPseudoClassWithContext):
(WebCore::SelectorCompiler::addScrollbarPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
(WebCore::SelectorCompiler::SelectorCodeGenerator::branchOnResolvingModeWithCheckingContext):
(WebCore::SelectorCompiler::elementIsActiveForStyleResolution):
(WebCore::SelectorCompiler::setElementStyleFromContextIsAffectedByEmptyAndUpdateRenderStyleIfNecessary):
(WebCore::SelectorCompiler::elementIsHoveredForStyleResolution):
(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateRequestedPseudoElementEqualsToSelectorPseudoElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateMarkPseudoStyleForPseudoElement):
- cssjit/SelectorCompiler.h:
(WebCore::SelectorCompiler::CheckingContext::CheckingContext): Deleted.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::SelectorDataList::selectorMatches):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithCheckingContext):
(WebCore::isCompiledSelector):
(WebCore::SelectorDataList::compileSelector):
(WebCore::SelectorDataList::execute):
- dom/SelectorQuery.h:
(WebCore::SelectorDataList::SelectorData::SelectorData):
- 1:37 AM Changeset in webkit [173456] by
-
- 8 edits in trunk
[GTK] allow overwriting destination of download
https://bugs.webkit.org/show_bug.cgi?id=136372
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-10
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadGetProperty): Added
(webkit_download_class_init): Install webkitDownloadGetProperty
(webkitDownloadDecideDestinationWithSuggestedFilename): Add
allowOverwrite parameter and set it appropriately
(webkit_download_get_allow_overwrite): Added
(webkit_download_set_allow_overwrite): Added
- UIProcess/API/gtk/WebKitDownload.h: New API
- UIProcess/API/gtk/WebKitDownloadClient.cpp:
(decideDestinationWithSuggestedFilename): Pass allowOverwrite to
webkitDownloadDecideDestinationWithSuggestedFilename
- UIProcess/API/gtk/WebKitDownloadPrivate.h: Add allowOverwrite
parameter to webkitDownloadDecideDestinationWithSuggestedFilename
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: New API
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(downloadLocalFileSuccessfully): Split from testDownloadLocalFile
(testDownloadLocalFile): Split off downloadLocalFileSuccessfully
(createFileAtDestination): Added
(testDownloadOverwriteDestinationAllowed): Added
(testDownloadOverwriteDestinationDisallowed): Added
(testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
(testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
(beforeAll): New tests
- 12:21 AM Changeset in webkit [173455] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Clean up the WebKit build from unused parameter warning in Webkit2/UIProcess module
https://bugs.webkit.org/show_bug.cgi?id=136670
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-09-10
Reviewed by Martin Robinson.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::didSameDocumentNavigationForMainFrame):
Sep 9, 2014:
- 8:59 PM Changeset in webkit [173454] by
-
- 4 edits in trunk
[MSE] http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html failing after r173318
https://bugs.webkit.org/show_bug.cgi?id=136676
Reviewed by Eric Carlson.
Source/WebCore:
Revert the inadvertant conditional change introduced in r173318.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDurationInternal):
LayoutTests:
- platform/mac/TestExpectations:
- 5:05 PM Changeset in webkit [173453] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix for Windows.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- 4:31 PM Changeset in webkit [173452] by
-
- 7 edits in trunk
iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
https://bugs.webkit.org/show_bug.cgi?id=135551
Reviewed by Daniel Bates.
Prevent printing invalid Unicode strings going to stderr.
Also, make filesystem.py more tolerant about receiving
Unicode (encoded as UTF-8) when writing to files, in the
rare case that an NSError description will make it to
stderr, such as -[LTRelayController createUniqueApp].
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController launchSimulator]): Removed.
(-[LTRelayController createUniqueApp]):
Don't explicitly try to uninstall the app. It is automatically handled
when installing an app with the same bundle identifier.
(-[LTRelayController start]):
(-[LTRelayController bootDevice]): Removed.
The device already boots as a part of starting the simulator. Attempting
to boot a second time may cause spurious stderr output.
- Scripts/webkitpy/port/driver.py:
(IOSSimulatorDriver._setup_environ_for_driver):
Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
Open the iOS Simulator once instead of the LayoutTestRelay trying
to do it.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._get_crash_log):
Make sure stderr is at least an empty string.
(IOSSimulatorPort):
(IOSSimulatorPort.developer_dir):
New property for setting up DEVELOPER_DIR in the driver environment.
- 4:21 PM Changeset in webkit [173451] by
-
- 5 edits in tags/Safari-600.1.22/Source
Versioning.
- 4:16 PM Changeset in webkit [173450] by
-
- 5 edits in trunk/Source/WebKit2
REGRESSION (WebKit2): -webkit-touch-callout: none has no effect.
https://bugs.webkit.org/show_bug.cgi?id=136685
rdar://problem/17629840
Reviewed by Benjamin Poulain.
We need to check if the touch callout is enabled for the element before starting
the long press gesture.
The information about the touch callout is returned together with the rest of data
returned by the InteractionInformationAtPosition.
- Shared/InteractionInformationAtPosition.cpp:
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- Shared/InteractionInformationAtPosition.h:
(WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _actionForLongPress]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 4:12 PM Changeset in webkit [173449] by
-
- 1 copy in tags/Safari-600.1.22
New Tag.
- 4:04 PM Changeset in webkit [173448] by
-
- 3 edits in trunk/Tools
Clean up the MiniBrowser Xcode project
https://bugs.webkit.org/show_bug.cgi?id=136684
Reviewed by Tim Horton.
- MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
- MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
WebKit2.framework. Upgraded project file version.
- 4:03 PM Changeset in webkit [173447] by
-
- 5 edits in branches/safari-600.1-branch/Source
Versioning.
- 3:52 PM Changeset in webkit [173446] by
-
- 2 edits in trunk/LayoutTests
Unskip two snapshotting tests that work for me consistently locally.
- platform/mac-wk2/TestExpectations:
- 3:47 PM Changeset in webkit [173445] by
-
- 3 edits in trunk/Source/WebCore
FrameLoader::prepareForHistoryNavigation is unused
https://bugs.webkit.org/show_bug.cgi?id=136683
Reviewed by Tim Horton.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForHistoryNavigation): Deleted.
- loader/FrameLoader.h: Removed the declaration.
- 2:58 PM Changeset in webkit [173444] by
-
- 4 edits4 adds in trunk
[CSS Grid Layout] Ignore ::first-letter pseudo-element
https://bugs.webkit.org/show_bug.cgi?id=136625
Reviewed by Darin Adler.
Source/WebCore:
According to the spec the ::first-letter pseudo-element do not apply to
grid containers (neither to flexboxes).
Fixed issue in RenderBlock::getFirstLetter() that applies to both grids
and flexboxes. Basically if the grid's or flexbox's container was
defining the ::first-line pseudo-element and the grid or flexbox itself
too, the value from the grid or flexbox was being applied to the items.
Added the proper check to avoid this.
Added two new tests for grid and modified one flexbox test to cover the
issue explained above.
Tests: css3/flexbox/flexbox-ignore-container-firstLetter.html
fast/css-grid-layout/grid-container-ignore-first-letter.html
fast/css-grid-layout/grid-item-first-letter-valid.html
- rendering/RenderBlock.cpp:
(WebCore::isRenderBlockFlowOrRenderButton): New method refactoring
similar calls through the source code.
(WebCore::RenderBlock::firstLineBlock): Use
isRenderBlockFlowOrRenderButton().
(WebCore::findFirstLetterBlock): Modify it to use
isRenderBlockFlowOrRenderButton() in order to include grids and not only
check flexboxes.
(WebCore::RenderBlock::getFirstLetter): Use
isRenderBlockFlowOrRenderButton().
(WebCore::RenderBlock::updateFirstLetter): Early return if
firstLetterContainer is null (in the case of flexboxes or grids).
LayoutTests:
- css3/flexbox/flexbox-ignore-container-firstLetter.html: Modify test,
in order to actually check that the ::first-letter in a regular
container is ignored in the flexbox.
- fast/css-grid-layout/grid-container-ignore-first-letter-expected.txt: Added.
- fast/css-grid-layout/grid-container-ignore-first-letter.html: Added.
- fast/css-grid-layout/grid-item-first-letter-valid-expected.txt: Added.
- fast/css-grid-layout/grid-item-first-letter-valid.html: Added.
- 2:49 PM Changeset in webkit [173443] by
-
- 12 edits in trunk/Source
Disable the "unreachable-code" warning
https://bugs.webkit.org/show_bug.cgi?id=136677
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-09-09
Reviewed by Darin Adler.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Source/WTF:
The warning causes various build errors depending on which Clang you are using.
For example, with recent clangs, it breaks all the ARCHS dependent code like this:
if (sizeof(uintptr_t) == 4)
Something for 32 bits.
else
Somethign for 64 bits.
- Configurations/Base.xcconfig:
- 2:43 PM Changeset in webkit [173442] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] -[WKBackForwardList backList] contains an unnecessary nil check
https://bugs.webkit.org/show_bug.cgi?id=136680
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
(-[WKBackForwardList backList]): Removed nil check.
(-[WKBackForwardList forwardList]): Ditto.
- 2:03 PM Changeset in webkit [173441] by
-
- 8 edits14 adds in trunk
Add support for :read-write/:read-only matching editable content
https://bugs.webkit.org/show_bug.cgi?id=136668
Reviewed by Antti Koivisto.
Source/WebCore:
This is the second part of the update of :read-write/:read-only to the latest spec
(http://www.whatwg.org/specs/web-apps/current-work/multipage/scripting.html#selectors).
The selectors :read-write/:read-only should match elements that are editable. The exact definition is:
"elements that are editing hosts or editable and are neither input elements nor textarea elements".
Matching that definition is really easy. It was done by updating HTMLElement's matchesReadWritePseudoClass()
to consider both contentEditable and designMode.
The tricky part is making that efficient in all cases. Matching contentEditable is horribly inefficient
compared to the other primitives. We don't want to execute that for every element.
Since matchesReadWritePseudoClass() was used by the theming code, that code was adjusted to
-Avoid calling that on regular HTMLElement, limiting the query to <input> and <textarea> where it is fast.
-Avoid the call entirely when possible.
Tests: fast/css/read-only-read-write-contenteditable-basics.html
fast/css/read-only-read-write-designmode-basics.html
fast/css/read-only-read-write-webkit-user-modify.html
fast/selectors/read-only-read-write-contenteditable-basics.html
fast/selectors/read-only-read-write-contenteditable-svg-foreignObject.html
fast/selectors/read-only-read-write-designmode-basics.html
fast/selectors/read-only-read-write-style-update.html
- html/HTMLElement.cpp:
(WebCore::contentEditableType):
This code is a generalization of the code that was in HTMLElement::contentEditable().
It is used by both matchesReadWritePseudoClass() and contentEditable() to determine
a valid state from the value of contentEditable.
(WebCore::HTMLElement::matchesReadWritePseudoClass):
Per the definition of editable content, we first check if the current element is an editing host,
if not we look for an editing host. If there are none, test for designMode.
(WebCore::HTMLElement::contentEditable):
(WebCore::RenderTheme::isReadOnlyControl):
The old definition would only match <input> and <textarea>. The code was updated to keep the same
behavior after matchesReadWritePseudoClass() is udpated. This avoids the performance problem of calling
matchesReadWritePseudoClass() on regular HTMLElement.
- platform/ControlStates.h:
ReadOnlyState was only used by ThemeMac for convertControlStatesToThemeDrawState().
In turn, convertControlStatesToThemeDrawState() was only used for painting
"-webkit-inner-spin-button". Buttons are not read-write to begin with.
The whole code looks like legacy from styling of input elements and was removed.
Removing ReadOnlyState removes the expensive part of extractControlStatesForRenderer().
- html/HTMLElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::readOnlyAttributeChanged):
- platform/mac/ThemeMac.mm:
(WebCore::convertControlStatesToThemeDrawState):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::extractControlStatesForRenderer):
LayoutTests:
- fast/css/read-only-read-write-contenteditable-basics-expected.html: Added.
- fast/css/read-only-read-write-contenteditable-basics.html: Added.
- fast/css/read-only-read-write-designmode-basics-expected.html: Added.
- fast/css/read-only-read-write-designmode-basics.html: Added.
- fast/css/read-only-read-write-webkit-user-modify-expected.txt: Added.
- fast/css/read-only-read-write-webkit-user-modify.html: Added.
- fast/selectors/read-only-read-write-contenteditable-basics-expected.txt: Added.
- fast/selectors/read-only-read-write-contenteditable-basics.html: Added.
- fast/selectors/read-only-read-write-contenteditable-svg-foreignObject-expected.txt: Added.
- fast/selectors/read-only-read-write-contenteditable-svg-foreignObject.html: Added.
- fast/selectors/read-only-read-write-designmode-basics-expected.txt: Added.
- fast/selectors/read-only-read-write-designmode-basics.html: Added.
- fast/selectors/read-only-read-write-style-update-expected.txt: Added.
- fast/selectors/read-only-read-write-style-update.html: Added.
- 1:56 PM Changeset in webkit [173440] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed gardening. Mark two media-source tests as failing.
- platform/mac/TestExpectations:
- 1:30 PM Changeset in webkit [173439] by
-
- 2 edits in trunk/Source/WebCore
[MSE] media/media-source tests broken after r173318
https://bugs.webkit.org/show_bug.cgi?id=136675
Reviewed by Eric Carlson.
Fixes the following tests:
http/tests/media/media-source/mediasource-play.html
http/tests/media/media-source/mediasource-remove.html
media/media-source/media-source-monitor-source-buffers.html
media/media-source/media-source-overlapping-append-buffered.html
In r173318, a for loop was converted to a C++11 loop, but in so doing, left
pre-initialized, empty values in the beginning of returned Vector, which caused
the calling algorithm to miscalculate the amount of data buffered by the media
source.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::activeRanges):
- 1:12 PM Changeset in webkit [173438] by
-
- 3 edits in trunk/Tools
svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
https://bugs.webkit.org/show_bug.cgi?id=136379
Patch by Daniel Bates <dbates@webkit.org> on 2014-09-09
Reviewed by David Kilzer.
Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
and sets a property on F (say, the executable bit).
- Scripts/svn-apply:
(patch): Only add file if the diff has text chunks.
- Scripts/svn-unapply:
(patch): Only delete added file if the diff has text chunks.
- 12:51 PM Changeset in webkit [173437] by
-
- 2 edits in trunk/LayoutTests
Fix syntax on some expected failures.
- platform/mac/TestExpectations:
- 12:46 PM Changeset in webkit [173436] by
-
- 53 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint no-trailing-spaces warnings
https://bugs.webkit.org/show_bug.cgi?id=136657
Reviewed by NOBODY (OOPS!).
- .eslintrc:
- UserInterface/Base/DOMUtilities.js:
- UserInterface/Base/URLUtilities.js:
(relativePath):
- UserInterface/Base/Utilities.js:
- UserInterface/Controllers/CodeMirrorColorEditingController.js:
(WebInspector.CodeMirrorColorEditingController.prototype._colorPickerColorChanged):
- UserInterface/Controllers/CodeMirrorDragToAdjustNumberController.js:
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.set enabled):
(WebInspector.CodeMirrorDragToAdjustNumberController.prototype.dragToAdjustControllerCanAdjustObjectAtPoint):
- UserInterface/Controllers/CodeMirrorEditingController.js:
(WebInspector.CodeMirrorEditingController.prototype.handleKeydownEvent):
- UserInterface/Controllers/CodeMirrorGradientEditingController.js:
(WebInspector.CodeMirrorGradientEditingController.prototype.gradientSliderStopWasSelected):
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):
- UserInterface/Controllers/DragToAdjustController.js:
(WebInspector.DragToAdjustController.prototype.set active):
(WebInspector.DragToAdjustController.prototype._setDragging):
(WebInspector.DragToAdjustController.prototype._setTracksMouseClickAndDrag):
- UserInterface/External/Esprima/esprima.js:
- UserInterface/Models/ApplicationCacheFrame.js:
(WebInspector.ApplicationCacheFrame):
- UserInterface/Models/ApplicationCacheManifest.js:
(WebInspector.ApplicationCacheManifest):
(WebInspector.ApplicationCacheManifest.prototype.get manifestURL):
- UserInterface/Models/CookieStorageObject.js:
- UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.prototype.get title):
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
- UserInterface/Models/DatabaseObject.js:
(WebInspector.DatabaseObject.prototype.getTableNames):
- UserInterface/Models/DatabaseTableObject.js:
(WebInspector.DatabaseTableObject):
- UserInterface/Models/Gradient.js:
(WebInspector.Gradient.fromString):
(WebInspector.RadialGradient.prototype.toString):
- UserInterface/Models/IssueMessage.js:
(WebInspector.IssueMessage.prototype._formatTextIfNecessary):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
- UserInterface/Models/Script.js:
(WebInspector.Script.prototype._makeSyntaxTree):
- UserInterface/Models/SourceCodeLocation.js:
(WebInspector.SourceCodeLocation.prototype.hasDifferentDisplayLocation):
- UserInterface/Models/TextMarker.js:
- UserInterface/Protocol/PageObserver.js:
- UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.refresh):
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype._networkStateUpdated):
- UserInterface/Views/ApplicationCacheFrameTreeElement.js:
(WebInspector.ApplicationCacheFrameTreeElement):
- UserInterface/Views/ApplicationCacheManifestTreeElement.js:
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get name):
(WebInspector.ApplicationCacheManifestTreeElement.prototype.get secondaryName):
- UserInterface/Views/ButtonNavigationItem.js:
(WebInspector.ButtonNavigationItem):
- UserInterface/Views/ColorPicker.js:
- UserInterface/Views/ColorWheel.js:
(WebInspector.ColorWheel.prototype._draw):
- UserInterface/Views/CompletionSuggestionsView.js:
(WebInspector.CompletionSuggestionsView.prototype.show):
- UserInterface/Views/ConsoleCommand.js:
- UserInterface/Views/ConsolePrompt.js:
- UserInterface/Views/ContentFlowTreeElement.js:
- UserInterface/Views/CookieStorageTreeElement.js:
(WebInspector.CookieStorageTreeElement):
- UserInterface/Views/EventListenerSectionGroup.js:
(WebInspector.EventListenerSectionGroup.prototype._functionTextOrLink):
- UserInterface/Views/GeneralTreeElementPathComponent.js:
- UserInterface/Views/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._handleKeydownEvent):
- UserInterface/Views/LayerTreeDataGridNode.js:
(WebInspector.LayerTreeDataGridNode.prototype._makeNameCell):
- UserInterface/Views/LayerTreeSidebarPanel.js:
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._highlightRanges):
- UserInterface/Views/NavigationBar.js:
(WebInspector.NavigationBar):
- UserInterface/Views/NavigationItem.js:
(WebInspector.NavigationItem):
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
- UserInterface/Views/ScopeBar.js:
- UserInterface/Views/ScopeBarItem.js:
(WebInspector.ScopeBarItem):
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel):
- UserInterface/Views/ScriptTimelineDataGridNode.js:
(WebInspector.ScriptTimelineDataGridNode.prototype.updateRangeTimes):
- UserInterface/Views/ScriptTreeElement.js:
(WebInspector.ScriptTreeElement):
- UserInterface/Views/SearchBar.js:
- UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
- UserInterface/Views/Slider.js:
Conflicts:
Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorColorEditingController.js
- 12:28 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 12:27 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 12:25 PM Changeset in webkit [173435] by
-
- 4 edits in trunk
[GTK] Unreviewed GTK gardening.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
LayoutTests:
Update some expectations for new cases.
- 12:07 PM Changeset in webkit [173434] by
-
- 2 edits in trunk/LayoutTests
Skip some WebGL tests failing on Mavericks and MountainLion bots.
- platform/mac/TestExpectations:
- 11:38 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 11:27 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 10:34 AM Changeset in webkit [173433] by
-
- 15 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint eqeqeq warnings
https://bugs.webkit.org/show_bug.cgi?id=136658
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-09
Reviewed by Andy Estes.
- UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.mycallback):
(WebInspector.DOMTreeManager.prototype.searchResult):
- UserInterface/Models/Breakpoint.js:
(WebInspector.Breakpoint.prototype.clearActions):
- UserInterface/Models/DOMTree.js:
(WebInspector.DOMTree.prototype._requestRootDOMNode.rootObjectAvailable):
(WebInspector.DOMTree.prototype._requestRootDOMNode.rootDOMNodeAvailable):
(WebInspector.DOMTree.prototype._requestRootDOMNode.dispatchCallbacks):
(WebInspector.DOMTree.prototype._requestRootDOMNode):
- UserInterface/Models/ProbeSet.js:
(WebInspector.ProbeSet.prototype.removeProbe):
- UserInterface/Models/ProbeSetDataTable.js:
(WebInspector.ProbeSetDataTable.prototype.addSampleForProbe):
- UserInterface/Views/CodeMirrorAdditions.js:
- UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype._filterCookies):
(WebInspector.cookieMatchesResourceURL):
- UserInterface/Views/DOMStorageContentView.js:
(WebInspector.DOMStorageContentView.prototype._editingCallback):
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement):
(WebInspector.DOMTreeElement.prototype._updateChildren):
(WebInspector.DOMTreeElement.prototype._startEditingTarget):
(WebInspector.DOMTreeElement.prototype._textNodeEditingCommitted):
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._resizerDragging):
- UserInterface/Views/DatabaseContentView.js:
(WebInspector.DatabaseContentView.prototype._queryError):
- UserInterface/Views/DetailsSectionSimpleRow.js:
(.valueElementClicked):
(WebInspector.DetailsSectionSimpleRow):
- UserInterface/Views/Slider.js:
(WebInspector.Slider.prototype.get _maxX):
- UserInterface/Views/TreeOutline.js:
(TreeElement.prototype.expand):
- 10:31 AM Changeset in webkit [173432] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint no-extra-semi
https://bugs.webkit.org/show_bug.cgi?id=136666
Reviewed by Andy Estes.
Add explicit no-extra-semi rule to .eslintrc. Remove all unnecessary
semicolons as identified by ESLint.
- .eslintrc:
- Tools/PrettyPrinting/Formatter.js:
(Formatter):
- UserInterface/Controllers/Formatter.js:
(Formatter):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize):
- UserInterface/Views/LayerTreeSidebarPanel.js:
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid.comparator):
(WebInspector.LayerTreeSidebarPanel.prototype._sortDataGrid):
- UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertyTreeElement.prototype.callback):
(WebInspector.ObjectPropertyTreeElement.prototype.applyExpression):
- 10:29 AM Changeset in webkit [173431] by
-
- 73 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix ESLint semi (missing semicolon)
https://bugs.webkit.org/show_bug.cgi?id=136665
Reviewed by Andy Estes.
Add missing semicolons as identified by ESLint. Add explicit semi rule to .eslintrc.
- .eslintrc:
- Tools/PrettyPrinting/FormatterContentBuilder.js:
- Tools/PrettyPrinting/FormatterDebug.js:
(Formatter.prototype.debug):
- UserInterface/Base/DOMUtilities.js:
- UserInterface/Base/EventListener.js:
(WebInspector.EventListener):
(WebInspector.EventListener.prototype.this._callback):
(WebInspector.EventListener.prototype.connect):
- UserInterface/Base/Object.js:
(WebInspector.Object):
(WebInspector.Object.addConstructorFunctions):
(WebInspector.Event):
- UserInterface/Base/URLUtilities.js:
(WebInspector.displayNameForURL):
(WebInspector.displayNameForHost):
- UserInterface/Base/Utilities.js:
(.):
- UserInterface/Controllers/BranchManager.js:
(WebInspector.BranchManager):
- UserInterface/Controllers/CSSStyleManager.js:
(WebInspector.CSSStyleManager):
- UserInterface/Controllers/CodeMirrorColorEditingController.js:
(WebInspector.CodeMirrorColorEditingController):
- UserInterface/Controllers/CodeMirrorEditingController.js:
(WebInspector.CodeMirrorEditingController):
- UserInterface/Controllers/CodeMirrorGradientEditingController.js:
(WebInspector.CodeMirrorGradientEditingController):
(WebInspector.CodeMirrorGradientEditingController.prototype.popoverDidPresent):
- UserInterface/Controllers/CodeMirrorTokenTrackingController.js:
- UserInterface/Controllers/FormatterContentBuilder.js:
- UserInterface/Controllers/FormatterSourceMap.js:
(WebInspector.FormatterSourceMap.fromBuilder):
- UserInterface/Controllers/IssueManager.js:
(WebInspector.IssueManager):
- UserInterface/Controllers/LogManager.js:
(WebInspector.LogManager):
- UserInterface/Models/BreakpointAction.js:
- UserInterface/Models/CSSCompletions.js:
(WebInspector.CSSCompletions):
(WebInspector.CSSCompletions.requestCSSNameCompletions):
- UserInterface/Models/CSSKeywordCompletions.js:
(WebInspector.CSSKeywordCompletions.forProperty):
(WebInspector.CSSKeywordCompletions.isColorAwareProperty):
- UserInterface/Models/CSSStyleSheet.js:
(WebInspector.CSSStyleSheet.resetUniqueDisplayNameNumbers):
- UserInterface/Models/Color.js:
(WebInspector.Color):
(WebInspector.Color.fromString):
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode):
- UserInterface/Models/DOMSearchMatchObject.js:
(WebInspector.DOMSearchMatchObject.titleForDOMNode):
- UserInterface/Models/ExecutionContext.js:
(WebInspector.ExecutionContext.supported):
- UserInterface/Models/Gradient.js:
(WebInspector.LinearGradient):
(WebInspector.LinearGradient.linearGradientWithComponents):
(WebInspector.RadialGradient):
(WebInspector.RadialGradient.radialGradientWithComponents):
- UserInterface/Models/IssueMessage.js:
(WebInspector.IssueMessage):
- UserInterface/Models/ReplaySessionSegment.js:
(WebInspector.IncompleteSessionSegment):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.associateWithScript):
- UserInterface/Models/Script.js:
(WebInspector.Script.resetUniqueDisplayNameNumbers):
- UserInterface/Models/Setting.js:
(WebInspector.Setting):
- UserInterface/Models/SourceCodePosition.js:
(WebInspector.SourceCodePosition):
- UserInterface/Models/SourceMap.js:
(WebInspector.SourceMap):
(WebInspector.SourceMap.StringCharIterator):
- UserInterface/Models/TextMarker.js:
(WebInspector.TextMarker):
- UserInterface/Models/TextRange.js:
(WebInspector.TextRange):
- UserInterface/Protocol/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
- UserInterface/Protocol/MessageDispatcher.js:
(WebInspector.dispatchNextQueuedMessageFromBackend):
(WebInspector.dispatchMessageFromBackend):
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPrimitiveValue):
(WebInspector.RemoteObject.fromLocalObject):
(WebInspector.RemoteObject.resolveNode):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.type):
(WebInspector.RemoteObjectProperty):
(WebInspector.RemoteObjectProperty.fromPrimitiveValue):
(WebInspector.LocalJSONObject):
- UserInterface/Protocol/ReplayObserver.js:
(WebInspector.ReplayPosition.fromProtocol):
- UserInterface/Views/BreakpointActionView.js:
(WebInspector.BreakpointActionView.displayStringForType):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype.if):
- UserInterface/Views/ClusterContentView.js:
(WebInspector.ClusterContentView.prototype.goBack):
(WebInspector.ClusterContentView.prototype.goForward):
- UserInterface/Views/CodeMirrorAdditions.js:
- UserInterface/Views/ColorWheel.js:
(WebInspector.ColorWheel):
- UserInterface/Views/ConsoleMessage.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.create):
- UserInterface/Views/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl):
- UserInterface/Views/ContextMenu.js:
(WebInspector.ContextMenuItem):
(WebInspector.ContextSubMenuItem):
(WebInspector.ContextMenu):
(WebInspector.ContextMenu.Provider):
(WebInspector.ContextMenu.registerProvider):
(WebInspector.contextMenuItemSelected):
(WebInspector.contextMenuCleared):
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement):
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline):
- UserInterface/Views/DOMTreeUpdater.js:
(WebInspector.DOMTreeUpdater):
- UserInterface/Views/DatabaseContentView.js:
(WebInspector.DatabaseContentView):
- UserInterface/Views/EditingSupport.js:
(WebInspector.isBeingEdited):
(WebInspector.markBeingEdited):
(WebInspector.isEditingAnyField):
(WebInspector.isEventTargetAnEditableField):
(WebInspector.EditingConfig):
(WebInspector.startEditing):
- UserInterface/Views/EventListenerSection.js:
(WebInspector.EventListenerSection):
- UserInterface/Views/EventListenerSectionGroup.js:
(WebInspector.EventListenerSectionGroup):
- UserInterface/Views/FindBanner.js:
- UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement):
- UserInterface/Views/GoToLineDialog.js:
(WebInspector.GoToLineDialog):
- UserInterface/Views/IndeterminateProgressSpinner.js:
(WebInspector.IndeterminateProgressSpinner):
- UserInterface/Views/LayoutTimelineDataGrid.js:
(WebInspector.LayoutTimelineDataGrid):
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
- UserInterface/Views/NavigationItem.js:
- UserInterface/Views/ObjectPropertiesSection.js:
(WebInspector.ObjectPropertiesSection):
(WebInspector.ObjectPropertiesSection.CompareProperties):
(WebInspector.ObjectPropertyTreeElement):
- UserInterface/Views/ProbeSetDetailsSection.js:
- UserInterface/Views/PropertiesSection.js:
(WebInspector.PropertiesSection):
- UserInterface/Views/ResourceTreeElement.js:
(WebInspector.ResourceTreeElement.compareResourceTreeElements):
(WebInspector.ResourceTreeElement.compareFolderAndResourceTreeElements):
- UserInterface/Views/ScriptTimelineDataGrid.js:
(WebInspector.ScriptTimelineDataGrid):
- UserInterface/Views/SearchResultTreeElement.js:
(WebInspector.SearchResultTreeElement.truncateAndHighlightTitle):
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler):
(WebInspector.TimelineRuler.prototype.get allowsClippedLabels):
(WebInspector.TimelineRuler.prototype._handleMouseUp):
- UserInterface/Views/Toolbar.js:
- UserInterface/Views/TreeOutline.js:
(TreeOutline.prototype.appendChild):
(TreeOutline.prototype.insertChild):
(TreeOutline.prototype.removeChildAtIndex):
(TreeOutline.prototype.removeChild):
(TreeOutline.prototype.removeChildren):
(TreeOutline.prototype.removeChildrenRecursive):
(TreeOutline.prototype._rememberTreeElement):
(TreeOutline.prototype._forgetTreeElement):
(TreeOutline.prototype._forgetChildrenRecursive):
(TreeOutline.prototype.getCachedTreeElement):
(TreeOutline.prototype.findTreeElement):
(TreeOutline.prototype._treeElementDidChange):
(TreeOutline.prototype.treeElementFromPoint):
(TreeOutline.prototype._treeKeyDown):
(TreeOutline.prototype.expand):
(TreeOutline.prototype.collapse):
(TreeOutline.prototype.revealed):
(TreeOutline.prototype.reveal):
(TreeOutline.prototype.select):
(TreeOutline.prototype.revealAndSelect):
(TreeElement.prototype._attach):
(TreeElement.prototype._detach):
(TreeElement.treeElementMouseDown):
(TreeElement.treeElementToggled):
(TreeElement.treeElementDoubleClicked):
(TreeElement.prototype.collapse):
(TreeElement.prototype.collapseRecursively):
(TreeElement.prototype.expand):
(TreeElement.prototype.expandRecursively):
(TreeElement.prototype.hasAncestor):
(TreeElement.prototype.reveal):
(TreeElement.prototype.revealed):
(TreeElement.prototype.selectOnMouseDown):
(TreeElement.prototype.select):
(TreeElement.prototype.revealAndSelect):
(TreeElement.prototype.deselect):
(TreeElement.prototype.onpopulate):
(TreeElement.prototype.traverseNextTreeElement):
(TreeElement.prototype.traversePreviousTreeElement):
(TreeElement.prototype.isEventWithinDisclosureTriangle):
- UserInterface/Views/TreeOutlineDataGridSynchronizer.js:
(WebInspector.TreeOutlineDataGridSynchronizer):
- 10:26 AM Changeset in webkit [173430] by
-
- 2 edits in trunk/Tools
Update my email in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=136671
Patch by Christophe Dumez <Chris Dumez> on 2014-09-09
Reviewed by Andreas Kling.
- Scripts/webkitpy/common/config/contributors.json:
- 8:58 AM Changeset in webkit [173429] by
-
- 5 edits in trunk/Source/WebKit2
Make DrawingArea a real MessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=136438
Reviewed by Darin Adler.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::DrawingArea):
(WebKit::DrawingArea::~DrawingArea):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::didReceiveMessage):
Make DrawingArea a real MessageReceiver instead of a LegacyReceiver that
jumps through WebPage to receive its messages.
- 8:09 AM Changeset in webkit [173428] by
-
- 3 edits4 adds in trunk
AX: HTML5 landmark (and related) elements should not be ignored.
https://bugs.webkit.org/show_bug.cgi?id=135116
Patch by Takeshi Kurosawa <taken.spc@gmail.com> on 2014-09-09
Reviewed by Chris Fleizach.
Make sure following element should not be ignored in computeAccessibilityIsIgnored
- header, aside, address, main, nav, article, section
- dt, dd
Source/WebCore:
Tests: platform/mac/accessibility/descriptionlist-not-ignored.html
platform/mac/accessibility/landmark-not-ignored.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
LayoutTests:
- platform/mac/accessibility/descriptionlist-not-ignored-expected.txt: Added.
- platform/mac/accessibility/descriptionlist-not-ignored.html: Added.
- platform/mac/accessibility/landmark-not-ignored-expected.txt: Added.
- platform/mac/accessibility/landmark-not-ignored.html: Added.
- 4:39 AM Changeset in webkit [173427] by
-
- 3 edits in trunk/Source/WebCore
[CSS Grid Layout] RenderGrid methods should take RenderBox references
https://bugs.webkit.org/show_bug.cgi?id=136630
Reviewed by Darin Adler.
RenderGrid has several methods that take pointers to RenderBox
instances but the body of those methods assumes that the objects
will never be NULL. We should replace them by references.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::logicalContentHeightForChild):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::insertItemIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::cachedGridCoordinate):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
- rendering/RenderGrid.h:
- 3:34 AM Changeset in webkit [173426] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary assert that is getting hit in some scenarios.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::certificateInfo):
- 2:22 AM Changeset in webkit [173425] by
-
- 2 edits in trunk/Source/WebCore
Try to fix windows build.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformCertificateInfo):
- 1:56 AM Changeset in webkit [173424] by
-
- 3 edits2 adds in trunk
[CSSRegions]Incorrect layout for multicol element transformed into region
https://bugs.webkit.org/show_bug.cgi?id=136459
Reviewed by David Hyatt.
Source/WebCore:
Until we will support the multicolumn region functionality, a multicolumn element
that also has flow-from style is not transformed into a region (https://bugs.webkit.org/show_bug.cgi?id=135153).
However, when a multicolumn element with flow-from style dynamically loses
its multicolumn style while keeping the flow-from style, we have to transform
the element into a region by detaching and attaching the associated DOM node,
in the same way we are proceeding when an element receives a different flow-from style.
Test: fast/regions/multicol/nested-multicol-into-region-dynamic.html
- style/StyleResolveTree.cpp:
(WebCore::Style::determineChange):
LayoutTests:
- fast/regions/multicol/nested-multicol-into-region-dynamic-expected.txt: Added.
- fast/regions/multicol/nested-multicol-into-region-dynamic.html: Added.
- 1:19 AM Changeset in webkit [173423] by
-
- 22 edits1 move in trunk/Source
Pass certificate info as part of ResourceResponse
https://bugs.webkit.org/show_bug.cgi?id=136611
Reviewed by Darin Adler.
Source/WebCore:
The current way of passing certificate info separately from ResourceResponse and then jamming it back
is complex and confusing. This patch makes it a true part of the ResourceResponse.
With this patch we also only create and pass the certificate info object for the main resource. It is
a big and complex object and we never look into it for any other resource type.
- WebCore.exp.in:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
Mark initialized for synthetic responses, unitialized for those backed by a platform request.
(WebCore::ResourceResponseBase::initializeCertificateInfo):
Calling this pulls the certificate info out from the platform type.
It shoud only be used for resources that need it.
(WebCore::ResourceResponseBase::certificateInfo):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformCertificateInfo):
(WebCore::ResourceResponseBase::platformSuggestedFileName):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
Encode and decode certificate info if it is present.
- platform/network/cf/ResourceResponse.h:
- platform/network/mac/CertificateInfo.h:
- platform/network/mac/CertificateInfoMac.mm:
(WebCore::CertificateInfo::CertificateInfo):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformCertificateInfo):
(WebCore::ResourceResponse::setCertificateChain): Deleted.
(WebCore::ResourceResponse::certificateChain): Deleted.
- platform/network/soup/ResourceResponse.h:
- platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::platformCertificateInfo):
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
Initialize the certificate info only if requested.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo): Deleted.
Rename didReceiveResponseWithCertificateInfo -> didReceiveResponse as it is now part of the response.
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
Request certificate info for the main resource only.
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::certificateInfo):
- 12:57 AM Changeset in webkit [173422] by
-
- 2 edits in trunk/Source/WebCore
[CSSRegions] Use C++11 range-based loops in FlowThreadController
https://bugs.webkit.org/show_bug.cgi?id=136634
Reviewed by Andrei Bucur.
No new tests as no new functionality was introduced.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::ensureRenderFlowThreadWithName):
(WebCore::FlowThreadController::styleDidChange):
(WebCore::FlowThreadController::layoutRenderNamedFlowThreads):
(WebCore::FlowThreadController::updateFlowThreadsChainIfNecessary):
(WebCore::FlowThreadController::updateFlowThreadsNeedingLayout):
(WebCore::FlowThreadController::updateFlowThreadsNeedingTwoStepLayout):
(WebCore::FlowThreadController::resetFlowThreadsWithAutoHeightRegions):
(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):
(WebCore::FlowThreadController::updateFlowThreadsLayerToRegionMappingsIfNeeded):
(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::FlowThreadController::isAutoLogicalHeightRegionsCountConsistent):
Sep 8, 2014:
- 11:36 PM Changeset in webkit [173421] by
-
- 2 edits in trunk/Source/WebCore
Minor refactor in CSSComputedStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=136664
Reviewed by Darin Adler.
The "if (length.isPercentNotCalculated()) createValue() else zoomAdjustedPixelValue()"
pattern occurred a number of times here, so factor into percentageOrZoomAdjustedValue().
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::positionOffsetValue): l -> length
(WebCore::percentageOrZoomAdjustedValue):
(WebCore::getBorderRadiusCornerValues):
(WebCore::getBorderRadiusCornerValue):
(WebCore::scrollSnapDestination):
(WebCore::scrollSnapPoints):
(WebCore::scrollSnapCoordinates):
- 11:34 PM Changeset in webkit [173420] by
-
- 2 edits in trunk/Source/WebKit2
[WebKit2] Fix build error in WebKit2/WebProcess module
https://bugs.webkit.org/show_bug.cgi?id=136667
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-09-08
Reviewed by Darin Adler.
Fix the build error by handling default case.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::maximumBufferingTime):
- 11:07 PM Changeset in webkit [173419] by
-
- 2 edits in trunk/Source/WebCore
Application Cache Storage: failed to execute statement "DELETE FROM CacheGroups" error "no such table: CacheGroups"
https://bugs.webkit.org/show_bug.cgi?id=136647
Reviewed by Darin Adler.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::verifySchemaVersion):
Don't try to delete the tables if we can't expect to have them yet.
- 7:56 PM Changeset in webkit [173418] by
-
- 6 edits2 adds in trunk
REGRESSION (r172153): Text drawn with wrong color when second text shadow has zero offset and blur (breaks buttons at aws.amazon.com)
https://bugs.webkit.org/show_bug.cgi?id=136612
Reviewed by Darin Adler.
Source/WebCore:
r172153 was fundamentally broken, and would restore graphics contexts that had never been saved. This patch
reimplements r172153 by using "continue" to skip loop iterations instead of changing the internal logic of
the loop.
In addition, I have refactored InlineTextBox::applyShadowToGraphicsContext() to take an extra boolean
reference as an out parameter in order to make it obvious it if saved a graphics context that needs
to be restored. This should make it less likely to make these kinds of mistakes in the future.
Test: fast/text/empty-shadow-with-color.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext): Add bool reference out param.
- rendering/InlineTextBox.h: Ditto.
- rendering/TextPainter.cpp:
(WebCore::isEmptyShadow): Change logic to not skip loop iterations on a null shadow.
(WebCore::paintTextWithShadows): Use continue to skip loop iterations for empty shadows. In addition,
use the out param in InlineTextBox::applyShadowToGraphicsContext().
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintTextWithShadows): Update for new sigurature of
InlineTextBox::applyShadowToGraphicsContext().
LayoutTests:
Make sure that text is drawn with correct color when second text shadow has zero offset and blur
- fast/text/empty-shadow-with-color-expected.html: Added.
- fast/text/empty-shadow-with-color.html: Added.
- 7:31 PM Changeset in webkit [173417] by
-
- 2 edits in trunk/PerformanceTests
PerformanceTests/SVG/SVG-Text.html has unparsable output
https://bugs.webkit.org/show_bug.cgi?id=136648
Reviewed by Gavin Barraclough.
I need to clean up the arbitrary text on the page before telling
the test runner infrastructure that the test is complete.
- SVG/SVG-Text.html:
- 7:03 PM Changeset in webkit [173416] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. More webgl conformance test gardening.
- platform/mac/TestExpectations:
- 6:46 PM Changeset in webkit [173415] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix 32-bit Mac build for new warnings
https://bugs.webkit.org/show_bug.cgi?id=136624
Reviewed by Darin Adler.
(Jessie already fixed this but my version with typedefs seems a tiny bit cleaner.)
- Carbon/HIViewAdapter.m:
(+[HIViewAdapter bindHIViewToNSView:nsView:]): Need to use explicit casting now.
- 6:39 PM Changeset in webkit [173414] by
-
- 2 edits in trunk/Tools
[EFL] Enable fixed layout by default
https://bugs.webkit.org/show_bug.cgi?id=136607
Reviewed by Csaba Osztrogonác.
Fixed layout is being used by Tizen platform by default. However, the feature
has still many defects now. So, we need to enable it by default, then should fix
those bugs.
- MiniBrowser/efl/main.c:
- 5:34 PM Changeset in webkit [173413] by
-
- 22 edits2 adds in trunk/Source
DFG should have a reusable SSA builder
https://bugs.webkit.org/show_bug.cgi?id=136331
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
We want to implement sophisticated SSA transformations like object allocation sinking
(https://bugs.webkit.org/show_bug.cgi?id=136330), but to do that, we need to be able to do
updates to SSA that require inserting new Phi's. This requires calculating where Phis go.
Previously, our Phi calculation was based on Aycock and Horspool's algorithm, and our
implementation of this algorithm only worked when doing CPS->SSA conversion. The code
could not be reused for cases where some phase happens to know that it introduced a few
defs in some blocks and it wants to figure out where the Phis should go. Moreover, even
the general algorithm of Aycock and Horspool is not well suited to such targetted SSA
updates, since it requires first inserting maximal Phis. That scales well when the Phis
were already there (like in our CPS form) but otherwise it's quite unnatural and may be
difficult to make efficient.
The usual way of handling both SSA conversion and SSA update is to use Cytron et al's
algorithm based on dominance frontiers. For a while now, I've been working on creating a
Cytron-based SSA calculator that can be used both as a replacement for our current SSA
converter and as a reusable tool for any phase that needs to do SSA update. I previously
optimized our dominator calculation and representation to use dominator trees computed
using Lengauer and Tarjan's algorithm - mainly to make it more scalable to enumerate over
the set of blocks that dominate you or vice-versa, and then I implemented a dominance
frontier calculator. This patch implements the final step towards making SSA update
available to all SSA phases: it implements an SSACalculator that can tell you where Phis
go when given an arbitrary set of Defs. To keep things simple, and to ensure that we have
good test coverage for this SSACalculator, this patch replaces the old Aycock-Horspool
SSA converter with one based on the SSACalculator.
This has no observable impact. It does reduce the amount of code in SSAConversionPhase.
But even better, it makes SSAConversionPhase have significantly less tricky logic. It
mostly just relies on SSACalculator to do the tricky stuff, and SSAConversionPhase mostly
just reasons about the weirdnesses unique to the ThreadedCPS form that it sees as input.
In fact, using the Cytron et al approach means that there isn't really any "smoke and
mirrors" trickyness related to SSA. SSACalculator's only "tricks" are using the pruned
iterated dominance frontier to place Phi's and using the dom tree to find reaching defs.
The complexity is mostly confined to Dominators, which computes various dominator-related
properties over the control flow graph. That class can be difficult to understand, but at
least it follows well-known graph theory wisdom.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAnalysis.h:
- dfg/DFGCSEPhase.cpp:
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
- dfg/DFGDominators.h:
(JSC::DFG::Dominators::immediateDominatorOf):
(JSC::DFG::Dominators::forAllBlocksInIteratedDominanceFrontierOf):
(JSC::DFG::Dominators::forAllBlocksInPrunedIteratedDominanceFrontierOf):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::getBlocksInPreOrder): Deleted.
(JSC::DFG::Graph::getBlocksInPostOrder): Deleted.
- dfg/DFGGraph.h:
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::run):
- dfg/DFGNodeFlags.h:
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
(JSC::DFG::Phase::endPhase):
- dfg/DFGPhase.h:
- dfg/DFGSSACalculator.cpp: Added.
(JSC::DFG::SSACalculator::Variable::dump):
(JSC::DFG::SSACalculator::Variable::dumpVerbose):
(JSC::DFG::SSACalculator::Def::dump):
(JSC::DFG::SSACalculator::SSACalculator):
(JSC::DFG::SSACalculator::~SSACalculator):
(JSC::DFG::SSACalculator::newVariable):
(JSC::DFG::SSACalculator::newDef):
(JSC::DFG::SSACalculator::nonLocalReachingDef):
(JSC::DFG::SSACalculator::reachingDefAtTail):
(JSC::DFG::SSACalculator::dump):
- dfg/DFGSSACalculator.h: Added.
(JSC::DFG::SSACalculator::Variable::index):
(JSC::DFG::SSACalculator::Variable::Variable):
(JSC::DFG::SSACalculator::Def::variable):
(JSC::DFG::SSACalculator::Def::block):
(JSC::DFG::SSACalculator::Def::value):
(JSC::DFG::SSACalculator::Def::Def):
(JSC::DFG::SSACalculator::variable):
(JSC::DFG::SSACalculator::computePhis):
(JSC::DFG::SSACalculator::phisForBlock):
(JSC::DFG::SSACalculator::reachingDefAtHead):
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::SSAConversionPhase):
(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::SSAConversionPhase::forwardPhiChildren): Deleted.
(JSC::DFG::SSAConversionPhase::forwardPhi): Deleted.
(JSC::DFG::SSAConversionPhase::forwardPhiEdge): Deleted.
(JSC::DFG::SSAConversionPhase::deduplicateChildren): Deleted.
- dfg/DFGSSAConversionPhase.h:
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::Validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
(JSC::DFG::validate):
- dfg/DFGValidate.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
- runtime/Options.h:
Source/WTF:
Update the alloc() method to use variadic templates. This makes it more natural to use.
- wtf/SegmentedVector.h:
(WTF::SegmentedVector::alloc):
- 5:33 PM Changeset in webkit [173412] by
-
- 5 edits in branches/safari-600.1-branch/Source
Versioning.
- 5:24 PM Changeset in webkit [173411] by
-
- 1 copy in tags/Safari-600.1.21
New Tag.
- 5:21 PM Changeset in webkit [173410] by
-
- 54 edits2 deletes in trunk/Source
Unreviewed, rolling out r173402.
https://bugs.webkit.org/show_bug.cgi?id=136649
Breaking buildw with error "unable to restore file position to
0x00000c60 for section DWARF.debug_info (errno = 9)"
(Requested by mlam_ on #webkit).
Reverted changeset:
"Move CallFrame and Register inlines functions out of
JSScope.h."
https://bugs.webkit.org/show_bug.cgi?id=136579
http://trac.webkit.org/changeset/173402
- 5:18 PM Changeset in webkit [173409] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip some WebGL conformance tests that may be passing on the bots now.
- platform/mac/TestExpectations:
- 5:08 PM Changeset in webkit [173408] by
-
- 2 edits in branches/safari-600.1-branch/Source/ThirdParty
Unreviewed build fix for FHPrime 64bit builds.
- gtest/msvc/gtest-md.vcxproj:
- 5:02 PM Changeset in webkit [173407] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Inspector frequently restores wrong view when opened (often Timelines instead of Resource)
https://bugs.webkit.org/show_bug.cgi?id=135965
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-08
Reviewed by Timothy Hatcher.
There were numerous subtle race conditions in state restoration.
This patch intends to fix a number of them to get what feels
like sane behavior for selected sidebar state restoration.
- Starting a Timeline recording no longer automatically switches to the TimelineContentView.
This was making every reload switch to Timelines. If you had
a resource selected (e.g. the DOM Tree) we should go back
to showing the DOM tree.
- Background sidebars should not reveal and select tree elements.
This was making resources get selected in Timelines when reloading the page
because the background Resources sidebar was restoring selection of the resource.
That is an unexpected selection and breaks the experience of Timelines.
- ContentView changes during page navigation / reload should not be saved, and improve Resource restoration.
If a TimelineContentView was in the ContentBrowser back/forward history,
a reload with a resource selected in the Resources sidebar would end up
showing the Timelines sidebar. This was because when ContentViews are
closed during the navigation, the ContentBrowser would fall back to the
remaining TimelineContentView and switch to its only allowed sidebar
(Timelines). ResourceSidebarPanel, knowing a resource was selected,
would select the MainFrame intending to stay in the Resource sidebar,
but the resource is okay with showing in any sidebar, so we stay on Timelines.
- Resource sidebar state restoration should propertly restore selection.
On reload, state restoration would know the resource to re-select in the
Resources sidebar. As ResourceTreeElements are added to the sidebar
they are checked against the state restoration cookie. If they match,
they would select the element and delete the cookie. Unfortunately,
if this was the first TreeElement child being added to a FrameTreeElement,
the FrameTreeElement onpopulate would remove all children and re-add
them in a unique way. Unfortunately this means the TreeElement we
selected based on the cookie, immediately got thrown away and recreated,
and we no longer reveal and select it. This is a special case for
FrameTreeElements which use the onpopulate SPI. So, instead of starting
processing the new element queue, if this is the first time just trigger
the onpopulate and elements are made just once.
- Show Error Console triggering early, could have unexpected sidebar behavior.
Opening Web Inspector directly to the console can run before
WebInspector.contentLoaded (DOMContentLoaded). So in that case
WebInspector.showFullHeightConsole was not handling if the contentBrowser
had no content view yet, and the sidebar might be-reopened later on
in contentLoaded based on the setting value.
- Improve automatic resource selection for sidebars with multiple tree outlines.
Selecting a call frame tree element was unexpectedly changing the
selection to a Resource where the breakpoint was set. This was
because we were only looking at one of potentially many content
tree outlines in the sidebar to see if there was a user action.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
(WebInspector.showFullHeightConsole):
(WebInspector.toggleConsoleView):
(WebInspector._mainResourceDidChange):
(WebInspector._provisionalLoadStarted):
(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):
(WebInspector._updateCookieForInspectorViewState):
(WebInspector._contentBrowserCurrentContentViewDidChange):
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange.delayedWork):
(WebInspector.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype._recordingLoaded):
- 5:00 PM Changeset in webkit [173406] by
-
- 5 edits3 adds in trunk
Web Inspector: Add layout test for lowercase CSSProperty names
https://bugs.webkit.org/show_bug.cgi?id=135961
Patch by Matt Baker <Matt Baker> on 2014-09-08
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
Modified test components to support testing CSSStyleManager and related classes:
- Added required models to Test.html
- Added CSSCompletions initialization to Test.js
- CSSCompletions doesn't assume presence of CodeMirror.
- UserInterface/Base/Test.js:
(WebInspector.loaded):
- UserInterface/Models/CSSCompletions.js:
- UserInterface/Test.html:
LayoutTests:
Added test to check that property names in matched CSS rules are returned in lowercase
when specified with upper or mixed case in the original CSS source.
- inspector/css/matched-style-properties-expected.txt: Added.
- inspector/css/matched-style-properties.html: Added.
- 4:59 PM Changeset in webkit [173405] by
-
- 5 edits in trunk
Web Inspector: Fixes to layout test infrastructure
https://bugs.webkit.org/show_bug.cgi?id=136360
Patch by Matt Baker <Matt Baker> on 2014-09-08
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
Added missing includes to Test.html, which was breaking tests that
depended on SourceCodeLocation and LazySourceCodeLocation. Also fixed
bug which prevented test results from being resent after reloading the
page under test.
- UserInterface/Base/Test.js:
(InspectorTest.reloadPage):
- UserInterface/Test.html:
LayoutTests:
Updated expected results to reflect breakpoint resolution changes in r171784.
- inspector/debugger/probe-manager-add-remove-actions-expected.txt:
- 4:54 PM Changeset in webkit [173404] by
-
- 5 edits in branches/safari-600.1.4.11-branch/Source
Versioning.
- 4:41 PM Changeset in webkit [173403] by
-
- 1 copy in tags/Safari-600.1.4.11.5
New tag.
- 3:58 PM Changeset in webkit [173402] by
-
- 54 edits2 adds in trunk/Source
Move CallFrame and Register inlines functions out of JSScope.h.
<https://webkit.org/b/136579>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This include fixing up some files to #include JSCInlines.h to pick up
these inline functions. I also added JSCellInlines.h to JSCInlines.h
since it is included from many of the affected .cpp files.
- API/ObjCCallbackFunction.mm:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bindings/ScriptValue.cpp:
- inspector/InjectedScriptHost.cpp:
- inspector/InjectedScriptManager.cpp:
- inspector/JSGlobalObjectInspectorController.cpp:
- inspector/JSJavaScriptCallFrame.cpp:
- inspector/ScriptDebugServer.cpp:
- interpreter/CallFrameInlines.h:
(JSC::CallFrame::vm):
(JSC::CallFrame::lexicalGlobalObject):
(JSC::CallFrame::globalThisValue):
- interpreter/RegisterInlines.h: Added.
(JSC::Register::operator=):
(JSC::Register::scope):
- runtime/ArgumentsIteratorConstructor.cpp:
- runtime/JSArrayIterator.cpp:
- runtime/JSCInlines.h:
- runtime/JSCJSValue.cpp:
- runtime/JSMapIterator.cpp:
- runtime/JSPromiseConstructor.cpp:
- runtime/JSPromiseDeferred.cpp:
- runtime/JSPromiseFunctions.cpp:
- runtime/JSPromisePrototype.cpp:
- runtime/JSPromiseReaction.cpp:
- runtime/JSScope.h:
(JSC::Register::operator=): Deleted.
(JSC::Register::scope): Deleted.
(JSC::ExecState::vm): Deleted.
(JSC::ExecState::lexicalGlobalObject): Deleted.
(JSC::ExecState::globalThisValue): Deleted.
- runtime/JSSetIterator.cpp:
- runtime/MapConstructor.cpp:
- runtime/MapData.cpp:
- runtime/MapIteratorPrototype.cpp:
- runtime/MapPrototype.cpp:
- runtime/SetConstructor.cpp:
- runtime/SetIteratorPrototype.cpp:
- runtime/SetPrototype.cpp:
- runtime/WeakMapConstructor.cpp:
- runtime/WeakMapPrototype.cpp:
Source/WebCore:
No new tests.
Added #include of the appropriate *Inlines.h files. Unlike in
JavaScriptCore, I #include'd the specific needed *Inlines.h instead of
JSCInlines.h. This is done to minimize the need for WebCore to be
rebuilt when JSC changes are introduced.
- ForwardingHeaders/interpreter/RegisterInlines.h: Added.
- bindings/js/JSAudioBufferSourceNodeCustom.cpp:
- bindings/js/JSAudioTrackCustom.cpp:
- bindings/js/JSBiquadFilterNodeCustom.cpp:
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
- bindings/js/JSCommandLineAPIHostCustom.cpp:
- bindings/js/JSCustomSQLStatementErrorCallback.cpp:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMStringListCustom.cpp:
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSHTMLDocumentCustom.cpp:
- bindings/js/JSOscillatorNodeCustom.cpp:
- bindings/js/JSPannerNodeCustom.cpp:
- bindings/js/JSPopStateEventCustom.cpp:
- dom/TreeWalker.cpp:
- html/HTMLPlugInImageElement.cpp:
- inspector/CommandLineAPIModule.cpp:
- inspector/InspectorController.cpp:
- 3:33 PM Changeset in webkit [173401] by
-
- 5 edits2 adds in trunk/Source/WebCore
Separate the Apple media controls module from other ports
https://bugs.webkit.org/show_bug.cgi?id=136644
rdar://problem/18270969
Reviewed by Eric Carlson.
Make a mediaControlsBase.{js|css} that acts as the base
class for the EFL and GTK ports (they were using mediaControlsApple).
Over time, the Apple-specific controls may use more of the
Base class.
- Modules/mediacontrols/mediaControlsBase.css: Added.
- Modules/mediacontrols/mediaControlsBase.js: Added.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::mediaControlsStyleSheet): Load Base rather than Apple.
(WebCore::RenderThemeEfl::mediaControlsScript): Ditto.
- rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::mediaControlsScript): Ditto.
- 2:40 PM Changeset in webkit [173400] by
-
- 2 edits in trunk/LayoutTests
Investigate test failures on ML caused by MediaTime refactoring
https://bugs.webkit.org/show_bug.cgi?id=136532
Added another test that appears to have been affected by this refactoring.
- platform/mac/TestExpectations:
- 2:38 PM Changeset in webkit [173399] by
-
- 3 edits in trunk/Source/WebKit2
Fix the iOS build.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
- 2:22 PM Changeset in webkit [173398] by
-
- 2 edits in trunk/Source/WebCore
Always update the referrer header in CachedResource
https://bugs.webkit.org/show_bug.cgi?id=136642
Reviewed by Alexey Proskuryakov.
If a request already includes a referrer header, and the document has
a non-default referrer policy, it is possible that we have to modify
the referrer header.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addAdditionalRequestHeaders):
- 1:51 PM Changeset in webkit [173397] by
-
- 182 edits in trunk
Remove FILTERS flag
https://bugs.webkit.org/show_bug.cgi?id=136571
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-09-08
Reviewed by Darin Adler.
.:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests required, no new functionality.
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- dom/DOMImplementation.cpp:
(WebCore::isSupportedSVG10Feature):
(WebCore::isSupportedSVG11Feature):
- platform/graphics/cpu/arm/filters/FEBlendNEON.h:
- platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:
- platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h:
- platform/graphics/cpu/arm/filters/NEONHelpers.h:
- platform/graphics/filters/DistantLightSource.cpp:
- platform/graphics/filters/DistantLightSource.h:
- platform/graphics/filters/FEBlend.cpp:
- platform/graphics/filters/FEBlend.h:
- platform/graphics/filters/FEColorMatrix.cpp:
- platform/graphics/filters/FEColorMatrix.h:
- platform/graphics/filters/FEComponentTransfer.cpp:
- platform/graphics/filters/FEComponentTransfer.h:
- platform/graphics/filters/FEComposite.cpp:
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FEConvolveMatrix.cpp:
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FEDiffuseLighting.cpp:
- platform/graphics/filters/FEDiffuseLighting.h:
- platform/graphics/filters/FEDisplacementMap.cpp:
- platform/graphics/filters/FEDisplacementMap.h:
- platform/graphics/filters/FEDropShadow.cpp:
- platform/graphics/filters/FEDropShadow.h:
- platform/graphics/filters/FEFlood.cpp:
- platform/graphics/filters/FEFlood.h:
- platform/graphics/filters/FEGaussianBlur.cpp:
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FELighting.cpp:
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/FEMerge.cpp:
- platform/graphics/filters/FEMerge.h:
- platform/graphics/filters/FEMorphology.cpp:
- platform/graphics/filters/FEMorphology.h:
- platform/graphics/filters/FEOffset.cpp:
- platform/graphics/filters/FEOffset.h:
- platform/graphics/filters/FESpecularLighting.cpp:
- platform/graphics/filters/FESpecularLighting.h:
- platform/graphics/filters/FETile.cpp:
- platform/graphics/filters/FETile.h:
- platform/graphics/filters/FETurbulence.cpp:
- platform/graphics/filters/FETurbulence.h:
- platform/graphics/filters/Filter.h:
- platform/graphics/filters/FilterEffect.cpp:
- platform/graphics/filters/FilterEffect.h:
- platform/graphics/filters/LightSource.h:
- platform/graphics/filters/PointLightSource.cpp:
- platform/graphics/filters/PointLightSource.h:
- platform/graphics/filters/SourceAlpha.cpp:
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/filters/SourceGraphic.cpp:
- platform/graphics/filters/SourceGraphic.h:
- platform/graphics/filters/SpotLightSource.cpp:
- platform/graphics/filters/SpotLightSource.h:
- rendering/svg/RenderSVGResource.cpp:
(WebCore::removeFromCacheAndInvalidateDependencies):
- rendering/svg/RenderSVGResourceFilter.cpp:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceFilterPrimitive.cpp:
- rendering/svg/RenderSVGResourceFilterPrimitive.h:
- rendering/svg/RenderSVGRoot.cpp:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::intersectRepaintRectWithResources):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGResourceContainer):
(WebCore::writeResources):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- rendering/svg/SVGRenderingContext.h:
(WebCore::SVGRenderingContext::SVGRenderingContext):
- rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
(WebCore::SVGResources::buildCachedResources):
(WebCore::SVGResources::removeClientFromCache):
(WebCore::SVGResources::resourceDestroyed):
(WebCore::SVGResources::buildSetOfResources):
(WebCore::SVGResources::resetFilter):
(WebCore::SVGResources::dump):
- rendering/svg/SVGResources.h:
(WebCore::SVGResources::filter):
(WebCore::SVGResources::ClipperFilterMaskerData::ClipperFilterMaskerData):
- rendering/svg/SVGResourcesCycleSolver.cpp:
(WebCore::SVGResourcesCycleSolver::breakCycle):
- svg/SVGAnimatedEnumeration.cpp:
(WebCore::enumerationValueForTargetAttribute):
- svg/SVGComponentTransferFunctionElement.cpp:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGComponentTransferFunctionElement.idl:
- svg/SVGFEBlendElement.cpp:
- svg/SVGFEBlendElement.h:
- svg/SVGFEBlendElement.idl:
- svg/SVGFEColorMatrixElement.cpp:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEColorMatrixElement.idl:
- svg/SVGFEComponentTransferElement.cpp:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFEComponentTransferElement.idl:
- svg/SVGFECompositeElement.cpp:
- svg/SVGFECompositeElement.h:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEConvolveMatrixElement.cpp:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEConvolveMatrixElement.idl:
- svg/SVGFEDiffuseLightingElement.cpp:
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDiffuseLightingElement.idl:
- svg/SVGFEDisplacementMapElement.cpp:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDisplacementMapElement.idl:
- svg/SVGFEDistantLightElement.cpp:
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEDistantLightElement.idl:
- svg/SVGFEDropShadowElement.cpp:
- svg/SVGFEDropShadowElement.h:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEFloodElement.cpp:
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/SVGFEFuncAElement.cpp:
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncAElement.idl:
- svg/SVGFEFuncBElement.cpp:
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncBElement.idl:
- svg/SVGFEFuncGElement.cpp:
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncGElement.idl:
- svg/SVGFEFuncRElement.cpp:
- svg/SVGFEFuncRElement.h:
- svg/SVGFEFuncRElement.idl:
- svg/SVGFEGaussianBlurElement.cpp:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEImageElement.cpp:
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGFELightElement.cpp:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeElement.idl:
- svg/SVGFEMergeNodeElement.cpp:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMergeNodeElement.idl:
- svg/SVGFEMorphologyElement.cpp:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFEOffsetElement.cpp:
- svg/SVGFEOffsetElement.h:
- svg/SVGFEOffsetElement.idl:
- svg/SVGFEPointLightElement.cpp:
- svg/SVGFEPointLightElement.h:
- svg/SVGFEPointLightElement.idl:
- svg/SVGFESpecularLightingElement.cpp:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpecularLightingElement.idl:
- svg/SVGFESpotLightElement.cpp:
- svg/SVGFESpotLightElement.h:
- svg/SVGFESpotLightElement.idl:
- svg/SVGFETileElement.cpp:
- svg/SVGFETileElement.h:
- svg/SVGFETileElement.idl:
- svg/SVGFETurbulenceElement.cpp:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFETurbulenceElement.idl:
- svg/SVGFilterElement.cpp:
- svg/SVGFilterElement.h:
- svg/SVGFilterElement.idl:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFilter.cpp:
- svg/graphics/filters/SVGFilter.h:
- svg/graphics/filters/SVGFilterBuilder.cpp:
- svg/graphics/filters/SVGFilterBuilder.h:
- svg/svgtags.in:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 1:36 PM Changeset in webkit [173396] by
-
- 2 edits in branches/safari-600.1-branch/Source/WebCore
Merged r173365. rdar://problem/18257576
- 1:10 PM Changeset in webkit [173395] by
-
- 2 edits in branches/safari-600.1-branch/Source/ThirdParty/ANGLE
Unreviewed tentative build fix for FHPrime bots.
- ANGLE.vcxproj/libGLESv2Common.props:
- 1:01 PM Changeset in webkit [173394] by
-
- 7 edits in trunk/Source/WebKit2
Buffer images on web process side
https://bugs.webkit.org/show_bug.cgi?id=136631
Reviewed by Darin Adler.
We can substantially reduce IPC and decoding time for large images by allowing some buffering.
This patch makes us buffer image data up to 0.5s before sending it over to the web process.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::didReceiveBuffer):
Start the timer.
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::startBufferingTimerIfNeeded):
(WebKit::NetworkResourceLoader::bufferingTimerFired):
(WebKit::NetworkResourceLoader::sendBuffer):
Send the data when the timer fires or the load finishes, whichever happens first.
- NetworkProcess/NetworkResourceLoader.h:
- Platform/IPC/ArgumentCoders.h:
Support encoding std::chrono::duration
- Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):
- Shared/Network/NetworkResourceLoadParameters.h:
Pass maximimum buffering duration.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::maximumBufferingTime):
Deterimine duration from the resource type.
Enabled full buffering for font resources. They are not decoded incrementally.
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- 11:59 AM Changeset in webkit [173393] by
-
- 4 edits in trunk/Source
HAVE(VOUCHERS) is not available outside of WebKit2
https://bugs.webkit.org/show_bug.cgi?id=136637
Reviewed by Tim Horton.
Source/WebKit2:
- config.h: Moved the definition of HAVE_VOUCHERS from here to wtf’s Platform.h.
Source/WTF:
- wtf/Platform.h: Moved the definition of HAVE_VOUCHERS from WebKit2’s config.h here.
- 11:57 AM Changeset in webkit [173392] by
-
- 7 edits in trunk/Source/WebCore
Use enum class for the RunPostLayoutTasks enum
https://bugs.webkit.org/show_bug.cgi?id=136640
Reviewed by Dean Jackson.
Use enum class for RunPostLayoutTasks fixing callers. Add an explanatory comment,
and add some spacing.
- dom/Document.cpp:
(WebCore::Document::updateLayoutIgnorePendingStylesheets):
- dom/Document.h:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetForJSBindings):
- testing/Internals.cpp:
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
- 11:54 AM Changeset in webkit [173391] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=136633
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-08
Reviewed by Darin Adler.
Enum name has already been defined.
- platform/audio/AudioHardwareListener.h:
- 11:44 AM Changeset in webkit [173390] by
-
- 2 edits in branches/safari-600.1.4.11-branch/Source/WebCore
Merged r173344. <rdar://problem/18267402>
- 11:32 AM Changeset in webkit [173389] by
-
- 2 edits in trunk/Source/WebCore
Remove some unused code in ImageSourceCG
https://bugs.webkit.org/show_bug.cgi?id=136638
Reviewed by Dan Bernstein.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::setData):
Remove this code. Firstly, it's in a USE(CG) && !PLATFORM(COCOA) && !PLATFORM(WIN)
block, and that's simply not a thing. Secondly, the referenced bug was fixed in Lion.
- 11:14 AM Changeset in webkit [173388] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
Merge StructureShapes that share the same prototype chain
https://bugs.webkit.org/show_bug.cgi?id=136549
Reviewed by Filip Pizlo.
Instead of keeping track of many discrete StructureShapes that share
the same prototype chain, TypeSet should merge StructureShapes that
have the same prototype chain and provide a new member variable for
optional structure fields. This provides a cleaner and more concise
interface for dealing with StructureShapes within TypeSet. Instead
of having many discrete shapes that are almost identical, almost
identical shapes will be merged together with an interface for
understanding what fields the shapes being merged together differ in.
- runtime/TypeSet.cpp:
(JSC::TypeSet::addTypeInformation):
(JSC::StructureShape::addProperty):
(JSC::StructureShape::toJSONString):
(JSC::StructureShape::inspectorRepresentation):
(JSC::StructureShape::hasSamePrototypeChain):
(JSC::StructureShape::merge):
- runtime/TypeSet.h:
- tests/typeProfiler/optional-fields.js: Added.
(wrapper.func):
(wrapper):
- 11:04 AM Changeset in webkit [173387] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the build after r173383, part 4.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
Machine finally caught up so I could actually test the fixes!
- 10:53 AM Changeset in webkit [173386] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the build after r173383, part 3.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
- 10:45 AM Changeset in webkit [173385] by
-
- 2 edits in trunk/Source/WTF
Try to fix the build after r173383, part 2.
- wtf/OSObjectPtr.h:
- 10:37 AM Changeset in webkit [173384] by
-
- 2 edits in trunk/Source/WTF
Try to fix the build after r173383.
- wtf/OSObjectPtr.h:
- 10:26 AM Changeset in webkit [173383] by
-
- 2 edits in trunk/Source/WTF
Make OSObjectPtr a bit more like RefPtr
https://bugs.webkit.org/show_bug.cgi?id=136613
Reviewed by Darin Adler.
Address some of Darin's feedback by:
- Making the adopting constructor private and friending adoptOSObject().
- Implementing the assignment operator using swap.
- Adding a move assignment operator.
- wtf/OSObjectPtr.h:
(WTF::OSObjectPtr::operator=):
(WTF::OSObjectPtr::swap):
(WTF::OSObjectPtr::OSObjectPtr):
- 10:10 AM Changeset in webkit [173382] by
-
- 13 edits in trunk/Source/WebCore
Introduce CSS_RULE_TYPE_CASTS, and use it
https://bugs.webkit.org/show_bug.cgi?id=136628
Reviewed by Darin Adler.
As a step to use toFoo, this patch introduces toCSSFooRule(). This will help to detect
wrong type cast. Additionally some missing type casts are clean up as well.
No new tests, no behavior changes.
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSImportRule.h:
- css/CSSMediaRule.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateRowsAndAreas):
- css/CSSRule.h:
- css/CSSStyleRule.h:
- css/CSSSupportsRule.h:
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collect):
- css/WebKitCSSRegionRule.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::asCSSStyleRule):
(WebCore::InspectorCSSAgent::collectStyleSheets):
- inspector/InspectorStyleSheet.cpp:
(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
- 10:05 AM Changeset in webkit [173381] by
-
- 4 edits in trunk/Tools
Dashboard metrics should ignore commits that didn't trigger builds
https://bugs.webkit.org/show_bug.cgi?id=136618
Reviewed by Darin Adler.
Commits that didn't trigger builds are ones like ChangeLog updates, patches for
other platforms etc. It does not make sense to count wait time for these, as it
can be arbitrarily long.
The new algorithm is much slower asymptotically, but it's OK, computers are fast.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
(BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
We used to walk the timeline to see which revisions are fully tested, but that's not
correct. A revision that's only tested by a subset of queues finishes independently
of another that's tested by another subset. Now, we just search for the answer for
each revision individually.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
(MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
the analyzer now reports. Removed best time, which is more confusing than meaningful.
- 9:11 AM Changeset in webkit [173380] by
-
- 2 edits in trunk/Source/WebKit/mac
32-bit build fix after r173364.
- Carbon/HIViewAdapter.m:
(+[HIViewAdapter bindHIViewToNSView:nsView:]):
- 8:28 AM Changeset in webkit [173379] by
-
- 3 edits in trunk/Source/WebKit/mac
Build fix.
Added back SPI that is still in use.
- Misc/WebNSURLExtras.h:
- Misc/WebNSURLExtras.mm:
(-[NSURL _webkit_URLByRemovingFragment]):
- 8:21 AM Changeset in webkit [173378] by
-
- 4 edits in trunk/Source
Source/WebKit/mac:
iOS Simulator build fix.
- Misc/WebKitSystemBits.m:
(WebMemorySize):
Source/WebKit2:
Build fix.
- Platform/IPC/Connection.h:
- 8:21 AM Changeset in webkit [173377] by
-
- 2 edits in trunk/Source/JavaScriptCore
More 32-bit Release build fixes after r173364.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 7:45 AM Changeset in webkit [173376] by
-
- 2 edits in trunk/Source/WTF
More build fixes after r173374.
- wtf/dtoa/strtod.cc:
- 7:33 AM Changeset in webkit [173375] by
-
- 2 edits in trunk/Source/WTF
Build fix after r173374.
- wtf/dtoa/strtod.cc:
- 7:26 AM Changeset in webkit [173374] by
-
- 2 edits in trunk/Source/WTF
Speculative build fix after r173364.
- wtf/dtoa/strtod.cc:
- 3:01 AM Changeset in webkit [173373] by
-
- 2 edits in trunk/Source/WebCore
[EFL[WK2] MiniBrowser comes to crash on debug mode
https://bugs.webkit.org/show_bug.cgi?id=136617
Reviewed by Csaba Osztrogonác.
Fix wrong ASSERTION use in applyCursorFromEcoreX().
- platform/efl/EflScreenUtilities.cpp: Change ASSERT(!window) with *ASSERT(window)*
(WebCore::applyCursorFromEcoreX):
- 2:32 AM Changeset in webkit [173372] by
-
- 2 edits in trunk/Tools
Remove EWebLauncher from webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=136622
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-09-08
Reviewed by Gyuyoung Kim.
- Scripts/webkitdirs.pm:
(launcherName):
Sep 7, 2014:
- 7:39 PM Changeset in webkit [173371] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix typos in last patch to fix build.
Unreviewed build fix.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):
- 7:16 PM Changeset in webkit [173370] by
-
- 10 edits in trunk/Source
Introduce COMPILER_QUIRK(CONSIDERS_UNREACHABLE_CODE) and use it
https://bugs.webkit.org/show_bug.cgi?id=136616
Reviewed by Darin Adler.
Source/JavaScriptCore:
Many compilers will analyze unrechable code paths (e.g. after an
unreachable code path), so sometimes they need dead code initializations.
But clang with suitable warnings will complain about unreachable code. So
use the quirk to include it conditionally.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdOp):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
- jsc.cpp:
- runtime/JSArray.cpp:
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
- runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
Source/WTF:
- wtf/Compiler.h: Define the quirk for all compilers but clang.
- 6:36 PM Changeset in webkit [173369] by
-
- 5 edits in trunk/Source/WebCore
Introduce toBasicShapeFoo() instead of static_cast<BasicShapeFoo*>
https://bugs.webkit.org/show_bug.cgi?id=136609
Reviewed by Darin Adler.
To use BasicShapeFoo() helps to detect wrong type casting and improve code readability.
No new tests, no behavior changes.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeCircle::blend):
(WebCore::BasicShapeEllipse::blend):
(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInset::blend):
- rendering/style/BasicShapes.h:
- 12:14 PM Changeset in webkit [173368] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix build failure seen on Mountain Lion buildbot.
- Misc/WebNSDataExtras.h: Make WEB_GUESS_MIME_TYPE_PEEK_LENGTH an unsigned instead
of an int, to avoid warning about mixing signs.
- 10:56 AM Changeset in webkit [173367] by
-
- 16 edits1 move2 adds in trunk
XPCPtr should be converted into an all purpose smart pointer for os_objects
https://bugs.webkit.org/show_bug.cgi?id=136602
Reviewed by Darin Adler.
Source/WebKit2:
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:
(DatabaseServiceInitializer):
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(WebKit::NetworkServiceInitializerDelegate::NetworkServiceInitializerDelegate):
(NetworkServiceInitializer):
- Platform/IPC/Connection.h:
(IPC::Connection::Identifier::Identifier):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::ConnectionTerminationWatchdog::createConnectionTerminationWatchdog):
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
- Platform/IPC/mac/XPCPtr.h: Removed.
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit::PluginServiceInitializerDelegate::PluginServiceInitializerDelegate):
(PluginServiceInitializer):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializerDelegate::XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializer):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
(WebKit::XPCServiceInitializerDelegate::hasEntitlement):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
(WebKit::connectToReExecService):
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
Update after the rename of XPCPtr to OSObjectPtr.
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/OSObjectPtr.h: Copied from Source/WebKit2/Platform/IPC/mac/XPCPtr.h.
(WTF::retainOSObject):
(WTF::releaseOSObject):
(WTF::OSObjectPtr::OSObjectPtr):
(WTF::OSObjectPtr::~OSObjectPtr):
(WTF::OSObjectPtr::operator=):
(WTF::adoptOSObject):
(IPC::XPCPtr::XPCPtr): Deleted.
(IPC::XPCPtr::~XPCPtr): Deleted.
(IPC::XPCPtr::operator=): Deleted.
(IPC::adoptXPC): Deleted.
Rename/move XPCPtr to OSObjectPtr and make it work with any os_object.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/darwin: Added.
- TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
Add basic unit tests for OSObjectPtr.
- 2:30 AM Changeset in webkit [173366] by
-
- 3 edits in trunk/Source/WebInspectorUI
Use a <circle> instead of a <path> in DownloadArrow.svg.
https://bugs.webkit.org/show_bug.cgi?id=136608
Reviewed by Antoine Quint.
- UserInterface/Images/DownloadArrow.svg:
- UserInterface/Views/TreeElementStatusButton.css:
(.item > .status > .status-button > svg .filled):
(body.mac-platform.legacy .item > .status > .status-button > svg .filled):
(:focus .item.selected > .status > .status-button > svg .filled):
(.item > .status > .status-button > svg .stroked):
(body.mac-platform.legacy .item > .status > .status-button > svg .stroked):
(:focus .item.selected > .status > .status-button > svg .stroked):
Tweak CSS selectors to apply to other shapes, not just path.
Sep 6, 2014:
- 5:19 PM Changeset in webkit [173365] by
-
- 2 edits in trunk/Source/WebCore
[Fullscreen] Add a site-specific hack to work around "flash on exit" behavior of YouTube.com.
https://bugs.webkit.org/show_bug.cgi?id=136604
Reviewed by Eric Carlson.
YouTube.com will cause a "flash" of the full screen sized <video> element upon exiting full
screen because the "fullscreenchange" event is fired asynchronously after the exit animation
completes. Only YouTube sites and embeds, add a site-specific-quirk which runs the "fullscreenchange"
event synchronously at the end of the exit animation. This causes YouTube's video resizing logic
to run during the period of time where we've disabled screen updates, instead of immediately
after.
- dom/Document.cpp:
(WebCore::Document::webkitDidExitFullScreenForElement):
- 3:53 PM Changeset in webkit [173364] by
-
- 40 edits in trunk/Source
Make updates suggested by new version of Xcode
https://bugs.webkit.org/show_bug.cgi?id=136603
Reviewed by Mark Rowe.
Source/JavaScriptCore:
- Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
- JavaScriptCore.xcodeproj/project.pbxproj: Update LastUpgradeCheck.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode): Compile out unreachable code
for clang, since it understands the code is unreachable.
- runtime/JSArray.cpp:
(JSC::JSArray::fillArgList): Ditto.
(JSC::JSArray::copyToArguments): Ditto.
Source/ThirdParty:
- gtest/xcode/Config/General.xcconfig: Moved CLANG_WARN_BOOL_CONVERSION,
CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION, and COMBINE_HIDPI_IMAGES
here from project file. Added CLANG_WARN_UNREACHABLE_CODE, ENABLE_STRICT_OBJC_MSGSEND,
and GCC_WARN_64_TO_32_BIT_CONVERSION as suggested by Xcode upgrade check.
- gtest/xcode/gtest.xcodeproj/project.pbxproj: Updated LastUpgradeCheck and removed
things that are redundant with the xcconfig file above.
Source/ThirdParty/ANGLE:
- ANGLE.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
- Configurations/ANGLE.xcconfig: Added CLANG_WARN_BOOL_CONVERSION,
CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION, COMBINE_HIDPI_IMAGES,
and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
Source/WebCore:
- Configurations/Base.xcconfig: Added COMBINE_HIDPI_IMAGES and
ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
- WebCore.xcodeproj/project.pbxproj: Let Xcode remove an orphaned item from the file,
and also updated LastUpgradeCheck.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateTextTrackDisplay): Use #if/#else/#endif instead of
using #if/return/#endif and leaving code unreachable.
(WebCore::HTMLMediaElement::configureMediaControls): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
- html/canvas/WebGLDrawBuffers.cpp:
(WebCore::WebGLDrawBuffers::supported): Ditto.
Source/WebInspectorUI:
- Configurations/Base.xcconfig: Added CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
CLANG_WARN_UNREACHABLE_CODE, CLANG_WARNDUPLICATE_METHOD_MATCH, ENABLE_STRICT_OBJC_MSGSEND,
GCC_WARN_UNDECLARED_SELECTOR, and GCC_WARN_UNUSED_FUNCTION as suggested by Xcode update check.
Also removed duplicate GCC_WARN_UNUSED_VARIABLE line.
- WebInspectorUI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
Source/WebKit/mac:
- Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
and ENABLE_STRICT_OBJC_MSGSEND as suggested by Xcode upgrade check.
- History/WebURLsWithTitles.m:
(+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use NSUInteger instead of
unsigned for correctness, and to quiet the 32-to-64-bit compiler warning (which is
not turned on because it gives us too many false positives).
- Misc/WebElementDictionary.mm:
(-[WebElementDictionary objectForKey:]): Ditto.
- Misc/WebNSDataExtras.m:
(-[NSData _webkit_guessedMIMETypeForXML]): Ditto.
(-[NSData _webkit_guessedMIMEType]): Ditto.
(-[NSData _webkit_parseRFC822HeaderFields]): Ditto.
(-[NSData _web_locationAfterFirstBlankLine]): Ditto.
- Misc/WebNSURLExtras.h: Removed unused _web_URLWithLowercasedScheme, _web_hostData,
_webkit_URLByRemovingFragment, _webkit_URLByRemovingResourceSpecifier, _webkit_isFTPDirectoryURL,
_webkit_shouldLoadAsEmptyDocument, _web_hostNameNeedsDecodingWithRange:,
_web_hostNameNeedsEncodingWithRange:, _web_decodeHostNameWithRange:, _web_encodeHostNameWithRange:,
and _webkit_URLFragment methods.
- Misc/WebNSURLExtras.mm:
(-[NSURL _web_URLByTruncatingOneCharacterBeforeComponent:]): Deleted.
(-[NSURL _webkit_URLByRemovingFragment]): Deleted.
(-[NSURL _webkit_URLByRemovingResourceSpecifier]): Deleted.
(-[NSURL _webkit_isFTPDirectoryURL]): Deleted.
(-[NSURL _webkit_shouldLoadAsEmptyDocument]): Deleted.
(-[NSURL _web_URLWithLowercasedScheme]): Deleted.
(-[NSString _webkit_isFTPDirectoryURL]): Deleted.
(-[NSString _web_hostNameNeedsDecodingWithRange:]): Deleted.
(-[NSString _web_hostNameNeedsEncodingWithRange:]): Deleted.
(-[NSString _web_decodeHostNameWithRange:]): Deleted.
(-[NSString _web_encodeHostNameWithRange:]): Deleted.
(-[NSString _webkit_URLFragment]): Deleted.
- Plugins/WebPluginDatabase.mm:
(-[WebPluginDatabase removePluginInstanceViewsFor:]): Use a modern for loop
to iterate an array instead of a loop using the type "unsigned int".
- WebCoreSupport/WebOpenPanelResultListener.mm:
(-[WebOpenPanelResultListener chooseFilenames:]): Use NSUInteger instead of int.
- WebView/WebDelegateImplementationCaching.mm:
(CallDelegate): Use wtfCallIMP in one overload that was instead just calling the
directly without a proper type for the function pointer. This might have been causing
an actual problem on 64-bit systems, and it was different from all the other CallDelegate
functions that were already doing this correctly.
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _placePopupWindow:]): Use NSUInteger instead of int.
Source/WebKit2:
- Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE, COMBINE_HIDPI_IMAGES,
and ENABLE_STRICT_OBJC_MSGSEND as suggested by the Xcode upgrade check.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeCocoaOverrides): Changed NSConcreteTask_launch to use the same technique
as the other functions in this file, doing the type casting right at the call to
method_setImplementation so the global has a suitable type for making a function call,
rather than relying on the abilty to call through a type without a specific argument list.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::pathExtension): Use size_t for the result of String::reverseFind rather than
converting it to an int. Also don't rely on the fact that WTF's notFound becomes -1 when
cast from size_t to int.
- WebKit2.xcodeproj/project.pbxproj: Let Xcode delete some orphaned items, and updated
LastUpgradeCheck.
Source/WTF:
- Configurations/Base.xcconfig: Added CLANG_WARN_UNREACHABLE_CODE,
COMBINE_HIDPI_IMAGES, and ENABLE_STRICT_OBJC_MSGSEND as suggested by
Xcode upgrade check.
- WTF.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
- 1:52 PM Changeset in webkit [173363] by
-
- 12 edits in trunk/Source
Web Inspector: convert DockSide to an enum class
https://bugs.webkit.org/show_bug.cgi?id=136601
Reviewed by Timothy Hatcher.
Source/WebCore:
- inspector/InspectorFrontendClient.h:
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::requestSetDockSide):
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::frontendLoaded):
(-[WebInspectorWindowController attachWindow:]):
(-[WebInspectorWindowController attach]):
(-[WebInspectorWindowController detach]):
- WebInspector/WebInspectorFrontend.mm:
(-[WebInspectorFrontend attach]):
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::frontendLoaded):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::attachWindow):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::attachedBottom):
(WebKit::WebInspector::attachedRight):
(WebKit::WebInspector::detached):
- 12:27 PM Changeset in webkit [173362] by
-
- 5 edits in branches/safari-600.1-branch/Source
Versioning.
- 11:49 AM Changeset in webkit [173361] by
-
- 1 copy in tags/Safari-600.1.20
New tag.
- 10:58 AM Changeset in webkit [173360] by
-
- 2 edits in trunk/Source/WebCore
Serialize ResourceResponses using WebKit types
https://bugs.webkit.org/show_bug.cgi?id=136545
Fix the failing webarchive tests.
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::initNSURLResponse): Map empty text encoding name to nil NSString.
- 10:27 AM Changeset in webkit [173359] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 10:02 AM Changeset in webkit [173358] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo][Curl] fileExists() incorrectly claims folder does not exist.
https://bugs.webkit.org/show_bug.cgi?id=136598
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-06
Reviewed by Alex Christensen.
The fileExists() function will always return false on Windows,
if the filename parameter ends with a slash or backslash.
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::setCacheDirectory): Add slash after call to fileExists().
- 9:04 AM Changeset in webkit [173357] by
-
- 2 edits in trunk/Source/WebCore
New clang warns about boolean checks for |this| pointer in RenderObject debug methods
<http://webkit.org/b/136599>
Reviewed by Zalan Bujtas.
Ignores the following static analyzer warnings:
Source/WebCore/rendering/RenderObject.cpp:1465:10: error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
if (!this) {
~
~
Source/WebCore/rendering/RenderObject.cpp:1584:10: error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
if (!this)
~
~
- rendering/RenderObject.cpp:
(WebCore::RenderObject::showRenderObject):
(WebCore::RenderObject::showRenderSubTreeAndMark):
Add "#pragma clang" preprocessor macros to ignore this warning
since the code is only compiled for Debug builds. Also add a
pragma for the pragma so older clangs don't complain about an
unkonwn pragma.
- 8:33 AM Changeset in webkit [173356] by
-
- 14 edits in trunk
Serialize ResourceResponses using WebKit types
https://bugs.webkit.org/show_bug.cgi?id=136545
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Serialization is faster and we can mostly avoid having NSURLResponses in web process.
- WebCore.exp.in:
- platform/network/ResourceLoadTiming.h:
(WebCore::ResourceLoadTiming::encode):
(WebCore::ResourceLoadTiming::decode):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
Serialize from the WebCore data instead of serializing NSURLResponse.
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
Synthesize CFURLResponse by creating NSURLResponse on Cocoa platforms so we don't need copy code.
This has negligible performance impact, NSURLResponse is just a wrapper around CFURLResponse.
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::nsURLResponse):
(WebCore::ResourceResponse::setCertificateChain):
Avoid unnecessary NSURLRequest instantiation in debug builds.
Source/WebKit2:
Remove the WK2 serialization code for responses. It moves to the types itself in WebCore where it is
close to the data being serialized and less likely to get out of sync.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceResponse>::encode): Deleted.
(IPC::ArgumentCoder<ResourceResponse>::decode): Deleted.
- Shared/WebCoreArgumentCoders.h:
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ResourceResponse>::encodePlatformData): Deleted.
(IPC::ArgumentCoder<ResourceResponse>::decodePlatformData): Deleted.
LayoutTests:
Remove failure expectations for tests fixed by this patch.
http/tests/xmlhttprequest/web-apps/012.html
http/tests/xmlhttprequest/web-apps/013.html
- platform/mac-wk2/TestExpectations:
- 8:02 AM Changeset in webkit [173355] by
-
- 2 edits in trunk/Source/WebCore
HTMLElement.cpp does not compile with new clang
<http://webkit.org/b/136600>
Reviewed by Chris Fleizach.
Fixes the following static analyzer warning:
Source/WebCore/html/HTMLElement.cpp:545:10: error: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Werror,-Wundefined-bool-conversion]
if (!this !parentNode()) ~
~
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setOuterText): Remove "!this" check added
in r75738. It would only cover up real bugs, and isn't even hit
in layout tests.
- 4:17 AM Changeset in webkit [173354] by
-
- 8 edits1 delete in trunk/Source
[EFL] Drop evas object cursor support
https://bugs.webkit.org/show_bug.cgi?id=136324
Reviewed by Gyuyoung Kim.
Removed evas object cursor because there are some bugs.
ewebkit will only support ecore_x_cursor because ewebkit is available with X, now.
Source/WebCore:
- platform/efl/DefaultTheme/CMakeLists.txt: Removed cursor related code.
- platform/efl/DefaultTheme/default.edc: Ditto.
- platform/efl/DefaultTheme/widget/cursor/cursor.edc: Removed.
- platform/efl/EflScreenUtilities.cpp:
(WebCore::getEcoreCursor):
(WebCore::applyCursorFromEcoreX): Renamed applyFallbackCursor.
(WebCore::createCustomCursor): Added to make custom cursor.
(WebCore::applyFallbackCursor): Deleted.
- platform/efl/EflScreenUtilities.h:
Source/WebKit2:
- UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):
(EwkView::EwkView):
(EwkView::updateCursor): Simplifies not to use evas object cursor.
(EwkView::setCursor): Ditto.
- UIProcess/API/efl/EwkView.h:
- 3:36 AM Changeset in webkit [173353] by
-
- 2 edits in trunk/Tools
Unreviewed, EFL build fix when SHARED_CORE is on.
- TestWebKitAPI/PlatformEfl.cmake:
- 12:07 AM Changeset in webkit [173352] by
-
- 4 edits in trunk
Unreviewed, rolling out r173335.
https://bugs.webkit.org/show_bug.cgi?id=136597
Broke webgl/1.0.2/conformance/glsl/misc/shader-varying-
packing-restrictions.html (Requested by ap on #webkit).
Reverted changeset:
"Remove statically used varyings from packing restrictions
check."
https://bugs.webkit.org/show_bug.cgi?id=136585
http://trac.webkit.org/changeset/173335
- 12:02 AM Changeset in webkit [173351] by
-
- 13 edits in trunk/Source
Unreviewed, rolling out r173340 and r173342.
https://bugs.webkit.org/show_bug.cgi?id=136596
Broke many tests (Requested by ap on #webkit).
Reverted changesets:
"Remove PLATFORM(IOS) from WebCore/editing (Part 3)."
https://bugs.webkit.org/show_bug.cgi?id=136474
http://trac.webkit.org/changeset/173340
"Build fix after r173340."
http://trac.webkit.org/changeset/173342
