Timeline
Oct 27, 2014:
- 10:46 PM Changeset in webkit [175243] by
-
- 3 edits6 adds in trunk
Crash when attempting to perform array iteration on a non-array with numeric keys not initialized.
<https://webkit.org/b/137814>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
The arrayIteratorNextThunkGenerator() thunk was not checking for the case where
the butterfly may be NULL. This was the source of the crash, and is now fixed.
In addition, it is also not checking for the case where a property named "length"
may have been set on the iterated object. The thunk only checks the butterfly's
publicLength for its iteration operation. Array objects will work fine with this
because it always updates its butterfly's publicLength when its length changes.
In the case of iterable non-Array objects, the "length" property will require a
look up outside of the scope of this thunk. The fix is simply to limit the fast
case checks in this thunk to Array objects.
- jit/ThunkGenerators.cpp:
(JSC::arrayIteratorNextThunkGenerator):
LayoutTests:
- js/array-length-shortening-expected.txt: Added.
- js/array-length-shortening.html: Added.
- js/for-of-crash-expected.txt: Added.
- js/for-of-crash.html: Added.
- js/script-tests/array-length-shortening.js: Added.
(testLengthShortening):
(denseInt32Elements):
(denseDoubleElements):
(denseObjectElements):
(holeyInt32Elements):
(holeyDoubleElements):
(holeyObjectElements):
(arrayStorageInt32Elements):
(arrayStorageDoubleElements):
(arrayStorageObjectElements):
(sparseInt32Elements):
(sparseDoubleElements):
(sparseObjectElements):
- js/script-tests/for-of-crash.js: Added.
(foo):
- 10:39 PM Changeset in webkit [175242] by
-
- 6 edits in trunk/Source/WebCore
Move RenderBlock::beingDestroyed() to RenderObject.
<https://webkit.org/b/138116>
Reviewed by Antti Koivisto.
Make "is being destroyed" a RenderObject concept instead of restricting
it to RenderBlocks. I'm guessing that this was specific to blocks due to
lack of bitfield space in RenderObject, and that's no longer an issue.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::beingDestroyed): Deleted.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroy):
- rendering/RenderObject.h:
(WebCore::RenderObject::beingDestroyed):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
- 10:38 PM Changeset in webkit [175241] by
-
- 3 edits2 adds in trunk
AX: input type=hidden is being exposed when aria-hidden=false
https://bugs.webkit.org/show_bug.cgi?id=138106
Reviewed by Benjamin Poulain.
Source/WebCore:
If an input type=hidden was inside an aria-hidden=false, it would appear because
the lack of a RenderObject behind that object was not blocking its adoption into the AX tree.
We should explicity check for whether the type is hidden and then return an appropriate role.
Test: accessibility/input-type-hidden-in-aria-hidden-false.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
LayoutTests:
- accessibility/input-type-hidden-in-aria-hidden-false-expected.txt: Added.
- accessibility/input-type-hidden-in-aria-hidden-false.html: Added.
- 10:05 PM Changeset in webkit [175240] by
-
- 3 edits in trunk/Source/JavaScriptCore
Simplified some JSObject methods for converting arrays to ArrayStorage shape.
<https://webkit.org/b/138119>
Reviewed by Filip Pizlo.
Currently, for each Undecided, Int32, Double, and Contiguous array shapes,
there are 3 JSObject methods to convert them to ArrayStorage shape:
ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition, unsigned neededLength);
ArrayStorage* convert<shape>ToArrayStorage(VM&, NonPropertyTransition);
ArrayStorage* convert<shape>ToArrayStorage(VM&);
However, the neededLength that is passed is always m_butterfly->vectorLength().
Hence, the method that takes a neededLength is really not needed. This patch
removes this unneeded verbosity.
- runtime/JSObject.cpp:
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToArrayStorage):
- Also reordered the placement of the DeferGC statement so this Int32 function will look more similar to the others.
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
- runtime/JSObject.h:
- 8:46 PM Changeset in webkit [175239] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r175235. rdar://problem/18787412
- 8:05 PM Changeset in webkit [175238] by
-
- 3 edits in trunk/Source/WebKit2
NSSharingService protocol conformance should be internal to WKActionMenuController
https://bugs.webkit.org/show_bug.cgi?id=138112
Patch by Conrad Shultz <Conrad Shultz> on 2014-10-27
Reviewed by Tim Horton.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
Move protocol conformance from the interface to a class extension.
- 7:49 PM Changeset in webkit [175237] by
-
- 2 edits in trunk/Source/WebCore
https://trac.webkit.org/changeset/175233 broke many tests, fixing an incorrect '!'.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- 6:00 PM Changeset in webkit [175236] by
-
- 4 edits3 adds in trunk
text-combine needs to center text within the vertical space using glyph bounds
https://bugs.webkit.org/show_bug.cgi?id=138056
<rdar://problem/15403667>
Reviewed by Dean Jackson.
Source/WebCore:
Added fast/text/tatechuyoko.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::RenderCombineText):
(WebCore::RenderCombineText::adjustTextOrigin):
(WebCore::RenderCombineText::combineText):
- rendering/RenderCombineText.h:
LayoutTests:
- fast/text/tatechuyoko.html: Added.
- platform/mac/fast/text/tatechuyoko-expected.png: Added.
- platform/mac/fast/text/tatechuyoko-expected.txt: Added.
- 5:36 PM Changeset in webkit [175235] by
-
- 2 edits in trunk/Source/WebKit2
WebContent crash in WebKit::WebPage::expandedRangeFromHandle.
https://bugs.webkit.org/show_bug.cgi?id=138023
rdar://problem/18787412
Reviewed by Ryosuke Niwa.
We must change that we have a valid currentRange before trying
to expand or contract.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::changeBlockSelection):
- 4:13 PM Changeset in webkit [175234] by
-
- 2 edits in trunk/Websites/perf.webkit.org
REGRESSION: commit logs are not shown sometimes on the new dashboard UI
https://bugs.webkit.org/show_bug.cgi?id=138099
Reviewed by Benjamin Poulain.
The bug was caused by _currentItemChanged not passing the previous point in the list of points and also
_showDetails inverting the order of the current and old measurements.
- public/v2/app.js:
(App.PaneController._currentItemChanged): Pass in the previous point to _showDetails when there is one.
(App.PaneController._showDetails): Since points are ordered chronologically, the last point is the
current (latest) measurement and the first point is the oldest measurement.
(App.CommitsViewerComponent.commitsChanged): Don't show a single measurement as a range for clarity.
- 3:55 PM Changeset in webkit [175233] by
-
- 2 edits in trunk/Source/WebCore
Cleanup after r175213: fastGetAttribute().isNull() should be fastHasAttribute()
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Darin spotted this mistake.
- 2:59 PM Changeset in webkit [175232] by
-
- 7 edits in trunk
http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots
https://bugs.webkit.org/show_bug.cgi?id=138098
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::switchToNewTestingSession):
Create a separate session for each WKTR/DRT process when testing.
Source/WebKit2:
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- WebProcess/com.apple.WebProcess.sb.in:
Update for the new name of testing session. Memory regions are now of the form
"WebKit Test-<pid>-0".
LayoutTests:
- platform/mac-wk1/TestExpectations: Removed the test from expectations. It's still
skipped on WK2, because we don't yet implement the necessary WKTR functionality.
- 2:08 PM Changeset in webkit [175231] by
-
- 13 edits in trunk/Source
Use separate HashMaps for common and uncommon headers in HTTPHeaderMap
https://bugs.webkit.org/show_bug.cgi?id=138079
Reviewed by Anders Carlsson.
Source/WebCore:
Use separate HashMaps for common and uncommon headers in HTTPHeaderMap:
- a (faster) HashMap<HTTPHeaderMap, String> for common HTTP headers
- a HashMap<String, String, CaseFoldingHash> for uncommon ones
This avoids having to construct Strings from HTTPHeaderMap values for
storing. This also means we have less isolated String copies to do when
creating cross-thread data. The common headers HashMap should also be
a bit more efficient due to faster hashing and faster key comparison in
case of collision.
Some calls sites can also benefit from having direct access to common
headers of the request in HTTPHeaderName type.
This patch adds a new HTTPHeaderMapConstIterator iterator type for
HTTPHeaderMap so that call sites that do not need / want to distinguish
common / uncommon headers still do not need to. They can keep using
modern C++ loops over HTTPHeaderMap objects and get <String, String>
key/value pairs.
No new tests, no behavior change.
- loader/CrossOriginAccessControl.cpp:
(WebCore::isOnAccessControlSimpleRequestHeaderWhitelist):
Have isOnAccessControlSimpleRequestHeaderWhitelist() take a
HTTPHeaderName in argument instead of a String as only common headers
are in the whitelist.
(WebCore::isSimpleCrossOriginAccessRequest):
Call isOnAccessControlSimpleRequestHeaderWhitelist() only for common
HTTP headers.
- loader/CrossOriginAccessControl.h:
Have isOnAccessControlSimpleRequestHeaderWhitelist() take a
HTTPHeaderName in argument instead of a String as only common headers
are in the whitelist.
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginHeaders):
Call isOnAccessControlSimpleRequestHeaderWhitelist() only for common
HTTP headers.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
Call httpHeaderFields().commonHeaders().find() instead of
httpHeaderFields().find() as we are looking for a common header.
HTTPHeaderMap::find(HTTPHeaderName) was removed now that we have a
HashMap dedicated to common headers.
- loader/cache/CachedRawResource.cpp:
(WebCore::shouldIgnoreHeaderForCacheReuse):
Update argument type to be a HTTPHeaderName instead of a String as
only common HTTP headers can be ignored for cache reuse. The
implementation already dealt with HTTPHeaderName type and had to
call findHTTPHeaderName(). This is no longer needed now that the
call site now has direct access to common headers in HTTPHeaderName
type.
(WebCore::CachedRawResource::canReuse):
- Only call shouldIgnoreHeaderForCacheReuse() for common HTTP headers.
- Slightly optimize the second loop (the one over oldHeaderMap) to only check that the key is present in newHeaderMap, without actually comparing the String values. If the String values were different, the first loop would have seen it already and we would have returned early.
Source/WebKit2:
Update the WK2 IPC HTTPHeaderMap serialization / deserialization code
to leverage the fact that HTTPHeaderMap now stores common HTTP headers
and uncommon one in separate HashMaps. This speeds up deserialization
as we no longer need to call findHTTPHeaderName() for every decoded
header. We already know if the header is a common one or not, and if
it is then we already have a HTTPHeaderName type instead of a String.
I see that we spend ~40% less time in HTTPHeaderMap decoding when
loading http://flickr.com/explore, while the encoding takes about
the same amount of time as before.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<HTTPHeaderMap>::encode):
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):
Source/WTF:
Add HashTraits for C++11 strong enum types. Using integer HashTraits for
strong enums would be inconvenient as it would require casting between
integer and strong enum types.
- wtf/HashTraits.h:
(WTF::StrongEnumHashTraits::emptyValue):
(WTF::StrongEnumHashTraits::constructDeletedValue):
(WTF::StrongEnumHashTraits::isDeletedValue):
- 1:42 PM Changeset in webkit [175230] by
-
- 4 edits in trunk/Source/WebCore
Devirtualize RenderDeprecatedFlexibleBox::isStretchingChildren().
<https://webkit.org/b/138096>
Reviewed by Chris Dumez.
This function is only ever called on a renderer after we've checked
that it's a RenderDeprecatedFlexibleBox, so make it non-virtual.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalHeight):
- rendering/RenderDeprecatedFlexibleBox.h:
- rendering/RenderObject.h:
- 1:08 PM Changeset in webkit [175229] by
-
- 4 edits in trunk/Source/WebKit/mac
Provide a way for WebKit1 clients to override default action menu items
https://bugs.webkit.org/show_bug.cgi?id=138066
-and corresponding-
rdar://problem/18451638
Reviewed by Anders Carlsson.
WebActionMenuController now has an ivar for the WebActionMenuType so that it can
send that along to clients customizing the menu.
- WebView/WebActionMenuController.h:
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController prepareForMenu:withEvent:]):
(-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
New enum and new SPI to customize menus.
- WebView/WebUIDelegatePrivate.h:
- 1:06 PM Changeset in webkit [175228] by
-
- 2 edits in trunk/Source/WebCore
Reintroduce null check removed in r175222
https://bugs.webkit.org/show_bug.cgi?id=138087
Reviewed by Andreas Kling.
Reintroduce null check removed in r175222 as several layout tests are
crashing on the bots without them. At least the Pair pointer can be
null according to the assertion hits on the bots.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertRadius):
- 12:43 PM Changeset in webkit [175227] by
-
- 2 edits in trunk/LayoutTests
Add [ Yosemite ] modifier to a couple of tests in section 7.
These two tests fail with PPT, so they are expected to pass on 10.8. Our current
approach is a have separate sections for Mavericks and Yosemite, even for PPT
specific failures that affect both.
- platform/mac-wk2/TestExpectations:
- 12:31 PM Changeset in webkit [175226] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebCore
Merged r175158. rdar://problem/18571212
- 12:03 PM Changeset in webkit [175225] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r175157. rdar://problem/18739335
- 12:01 PM Changeset in webkit [175224] by
-
- 4 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r175153. rdar://problem/18739335
- 11:31 AM Changeset in webkit [175223] by
-
- 2 edits in trunk/LayoutTests
http/tests/cookies/third-party-cookie-relaxing.html is flaky on bots.
https://bugs.webkit.org/show_bug.cgi?id=138098.
Updated Expectations.
- platform/mac-wk1/TestExpectations:
- 11:26 AM Changeset in webkit [175222] by
-
- 4 edits in trunk/Source/WebCore
Move radius CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138087
Reviewed by Andreas Kling.
Move radius CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder so that they are now generated from CSSPropertyNames.in.
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyBorderRadius::setValue): Deleted.
(WebCore::ApplyPropertyBorderRadius::applyValue): Deleted.
(WebCore::ApplyPropertyBorderRadius::createHandler): Deleted.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertRadius):
- 11:06 AM Changeset in webkit [175221] by
-
- 3 edits in trunk/Source/WebCore
Shrink MathMLOperatorDictionary::dictionary table
https://bugs.webkit.org/show_bug.cgi?id=137914
Reviewed by Darin Adler.
Improve packing of the Entry structure that's used for elements
of the MathMLOperatorDictionary::dictionary table. This drops the
size of the struct from 16 bytes to just 4 bytes, and shrinks the
size of the dictionary table from rougly 16 kB down to 4 kB.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::MathMLOperatorDictionary::ExtractKey):
(WebCore::RenderMathMLOperator::setOperatorProperties):
- rendering/mathml/RenderMathMLOperator.h:
- 10:33 AM Changeset in webkit [175220] by
-
- 1 edit54 deletes in trunk/LayoutTests
Some test for multicol were redundant.
https://bugs.webkit.org/show_bug.cgi?id=133084
Patch by Piotr Grad <p.grad@samsung.com> on 2014-10-27
Reviewed by Andreas Kling.
- fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/anonymous-block-split-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/clone-before-after-content-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/clone-block-children-inline-mismatch-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/clone-flexbox.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/continuation-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/continuation-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/double-merge-anonymous-block-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/empty-anonymous-block-split-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/float-not-removed-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-above-or-below.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-block-axis-flipped.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-end-of-column.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-float-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-float.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages-flipped.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-between-pages.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/hit-test-gap-block-axis.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/list-multi-column-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input-expected.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/multicol-with-child-renderLayer-for-input.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/positioned-child-not-removed-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/positioned-objects-not-removed-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/recursive-split-flow-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/removal-of-multicol-span-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/remove-child-split-flow-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/split-flow-anonymous-wrapper-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/split-inline-wrong-post-block-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/table-multi-column-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/textbox-not-removed-crash.html: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash-expected.txt: Removed.
- fast/multicol/newmulticol/compare-with-old-impl/update-after-content-before-child-crash.html: Removed.
- 10:20 AM Changeset in webkit [175219] by
-
- 3 edits in trunk/Source/WebCore
Move canContainFixedPositionObjects() to RenderElement.
<https://webkit.org/b/138088>
Reviewed by Mihnea Ovidenie.
Only RenderElement can contain other renderers, so it's not really
natural to answer this question on RenderObject anyway.
Moving it to RenderElement lets it access more efficient getters
that don't have to handle the RenderText case.
- rendering/RenderElement.h:
(WebCore::RenderElement::canContainFixedPositionObjects):
- rendering/RenderObject.h:
(WebCore::RenderObject::canContainFixedPositionObjects): Deleted.
- 10:08 AM Changeset in webkit [175218] by
-
- 2 edits in trunk/LayoutTests
media/track/audio-track.html is flaky on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=137882
- platform/mac/TestExpectations: Marking it as such.
- 9:31 AM Changeset in webkit [175217] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r175145. rdar://problem/18376333
- 1:09 AM Changeset in webkit [175216] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r175143. rdar://problem/18692335
Oct 26, 2014:
- 11:51 PM Changeset in webkit [175215] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6
Merge r173999 - [GTK] Enable CSS_IMAGE_SET in production builds
https://bugs.webkit.org/show_bug.cgi?id=137142
Reviewed by Alejandro G. Castro.
This is required by the inspector to show some of the icons that
has a HiDPI variant.
- Source/cmake/OptionsGTK.cmake:
- 11:29 PM Changeset in webkit [175214] by
-
- 5 edits in branches/safari-600.1.4.12-branch/Source
Versioning.
- 9:28 PM Changeset in webkit [175213] by
-
- 9 edits2 adds in trunk
Images with usemap should not have a link state
https://bugs.webkit.org/show_bug.cgi?id=138071
Reviewed by Andreas Kling.
Source/WebCore:
Image tags were incorrectly getting a link state if a usemap is defined.
The <area> of the usemap is supposed to get the link state, but never the image.
Unfortunately, the Accessibility code was relying on the wrong behavior
to set the ImageMapRole, most of the patch is updating that code to get
the correct role without the link state.
Test: fast/selectors/images-with-usemap-should-not-match-link.html
The accessibility code is covered by a few tests in accessibility/.
The test accessibility/aria-used-on-image-maps.html ensure the <area>
elements also get the correct role.
- dom/Node.h:
(WebCore::Node::setIsLink):
(WebCore::Node::clearIsLink): Deleted.
Unused code.
(WebCore::Node::isLink):
Move with its setter for clarity.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
This is the bug.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
Here the branches for the role ImageMap where behind isLink() which would
never be valid after the fix.
My fix here was to use the same definition previously set by HTMLImageElement::parseAttribute(),
any usemap attribute qualifies the node for ImageMapRole.
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::linkedUIElements):
(WebCore::AccessibilityRenderObject::url):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAnchor): Deleted.
Something funny I discovered is the Accessibility code worked around the bug
by defining isAnchor() that exclude images from isLink().
Since isLink() will no longer be true for images, the hack can be removed.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::AccessibilityNodeObject::isAnchor): Deleted.
- accessibility/AccessibilityNodeObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
- fast/selectors/images-with-usemap-should-not-match-link-expected.txt: Added.
- fast/selectors/images-with-usemap-should-not-match-link.html: Added.
- 9:20 PM Changeset in webkit [175212] by
-
- 11 edits in trunk/Source/WebCore
Replace Element::didAffectSelector() by setNeedsStyleRecalc()
https://bugs.webkit.org/show_bug.cgi?id=138080
Reviewed by Andreas Kling.
Element::didAffectSelector() was probably an optimization at some point,
with the current code is does nothing more than setNeedsStyleRecalc().
- dom/Document.cpp:
(WebCore::Document::setCSSTarget):
- dom/Element.cpp:
(WebCore::Element::didAffectSelector): Deleted.
- dom/Element.h:
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::disabledStateChanged):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setIndeterminate):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::parseAttribute):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::parseAttribute):
(WebCore::HTMLOptionElement::setSelectedState):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::didElementStateChange):
- 3:25 PM Changeset in webkit [175211] by
-
- 10 edits in trunk/Source/WebCore
Move some RenderObject member functions to RenderElement.
<https://webkit.org/b/138085>
Reviewed by Chris Dumez.
Move these two functions to RenderElement:
- handleDynamicFloatPositionChange()
- removeAnonymousWrappersForInlinesIfNecessary()
Also make childBecameNonInline() take a RenderElement& since
that's all we ever pass to it.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::childBecameNonInline):
- rendering/RenderBlock.h:
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::childBecameNonInline):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::handleDynamicFloatPositionChange):
(WebCore::RenderElement::removeAnonymousWrappersForInlinesIfNecessary):
- rendering/RenderElement.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::childBecameNonInline):
- rendering/RenderInline.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::handleDynamicFloatPositionChange): Deleted.
(WebCore::RenderObject::removeAnonymousWrappersForInlinesIfNecessary): Deleted.
- rendering/RenderObject.h:
- 1:20 PM Changeset in webkit [175210] by
-
- 7 edits in trunk/Source/WebCore
Move continuation teardown from subclasses to RenderBoxModelObject.
<https://webkit.org/b/138081>
Reviewed by Antti Koivisto.
Let RenderBoxModelObject::willBeDestroyed() tear down any continuation
instead of having every subclass do this themselves.
Also added a RenderElement bit tracking whether the renderer has a
continuation. This avoids a hash lookup every time we destroy a
RenderBoxModelObject that didn't have a continuation.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willBeDestroyed):
- rendering/RenderBoxModelObject.cpp:
(WebCore::continuationMap):
(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::continuation):
(WebCore::RenderBoxModelObject::setContinuation):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
- rendering/RenderElement.h:
(WebCore::RenderElement::setHasContinuation):
(WebCore::RenderElement::hasContinuation):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
Oct 25, 2014:
- 10:47 PM Changeset in webkit [175209] by
-
- 2 edits in trunk/Source/WebCore
Remove a useless variable from SelectorCodeGenerator::generateElementMatchesSelectorList()
https://bugs.webkit.org/show_bug.cgi?id=138076
Reviewed by Alexey Proskuryakov.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesSelectorList):
The variable elementAddressRegisterIndex was just needed for debugging, it is useless now.
- 9:47 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:44 PM Changeset in webkit [175208] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening after r174685.
- platform/gtk/TestExpectations: Report new failures and update expectations.
- 9:12 PM Changeset in webkit [175207] by
-
- 2 edits in trunk/Tools
Fix link to Arch Linux Wiki
https://bugs.webkit.org/show_bug.cgi?id=138010
Patch by Raniere Silva <raniere@ime.unicamp.br> on 2014-10-25
Reviewed by Benjamin Poulain.
- gtk/install-dependencies:
- 8:52 PM Changeset in webkit [175206] by
-
- 4 edits in trunk/Source
Web Inspector: timelines should not count time elapsed while paused in the debugger
https://bugs.webkit.org/show_bug.cgi?id=136351
Unreviewed, follow-up fix after r175203. The debugger agent should not assume
that the inspector environment's stopwatch has already been started.
Source/JavaScriptCore:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::didPause): Check if the stopwatch isActive() before stopping.
Source/WTF:
- wtf/Stopwatch.h:
(WTF::Stopwatch::isActive): Added. Allow peeking at the stopwatch state.
- 8:25 PM Changeset in webkit [175205] by
-
- 7 edits6 copies6 adds in trunk/LayoutTests
Land Yosemite results for six editing/selection/vertical* tests.
These failures used to be mostly hidden because of bug 138070, now they are visible.
The change is due to different fonts.
- platform/mac-mavericks/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt.
- platform/mac-mavericks/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt.
- platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt.
- platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt.
- platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt.
- platform/mac-mavericks/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Copied from LayoutTests/platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt.
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Added.
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Added.
- platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Added.
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Added.
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Added.
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Added.
- platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
- 4:29 PM Changeset in webkit [175204] by
-
- 5 edits in trunk/Tools
Test regressions are not detected when image result is missing
https://bugs.webkit.org/show_bug.cgi?id=138070
Reviewed by Simon Fraser.
- Scripts/webkitpy/layout_tests/models/test_run_results.py:
- Scripts/webkitpy/layout_tests/views/buildbot_results.py:
Count these as regressions, not as flaky tests.
- Scripts/webkitpy/port/test.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
Test it.
- 3:05 PM Changeset in webkit [175203] by
-
- 39 edits1 add in trunk/Source
Web Inspector: timelines should not count time elapsed while paused in the debugger
https://bugs.webkit.org/show_bug.cgi?id=136351
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Now that we have a stopwatch to provide pause-aware timing data, we can remove the
profiler's handling of debugger pause/continue callbacks. The debugger agent accounts
for suspended execution by pausing and resuming the stopwatch.
- API/JSProfilerPrivate.cpp:
(JSStartProfiling): Use a fresh stopwatch when profiling from the JSC API.
- inspector/InspectorEnvironment.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::executionStopwatch):
- inspector/JSGlobalObjectInspectorController.h:
- inspector/ScriptDebugServer.cpp:
(Inspector::ScriptDebugServer::handlePause):
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
(Inspector::InspectorDebuggerAgent::didContinue):
- inspector/agents/InspectorDebuggerAgent.h:
- profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::profiler): Use nullptr.
(JSC::LegacyProfiler::startProfiling): Hand off a stopwatch to the profile generator.
(JSC::LegacyProfiler::stopProfiling): Use nullptr.
(JSC::LegacyProfiler::didPause): Deleted.
(JSC::LegacyProfiler::didContinue): Deleted.
- profiler/LegacyProfiler.h:
- profiler/Profile.cpp: The root node should always have a start time of 0.0.
(JSC::Profile::Profile):
- profiler/ProfileGenerator.cpp: Remove debugger pause/continue callbacks and the
timestamp member that was used to track time elapsed by the debugger. Just use the
stopwatch's elapsed times to generate start/elapsed times for function calls.
(JSC::ProfileGenerator::create):
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::AddParentForConsoleStartFunctor::operator()): The parent node of |console.profile|
should have a start time of 0.0, since it represents the starting node of profiling.
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.
- profiler/ProfileGenerator.h:
Source/WebCore:
To avoid counting time elapsed while the debugger is paused, timeline records should
keep track of time elapsed since the start of timeline capturing, rather than wall clock
timestamps. We can easily compute elapsed time by sharing a Stopwatch instance through the
inspector environment. The stopwatch runs with timelines and is paused with the debugger,
so subsequent time measurements will not include time elapsed while the debugger is paused.
This refactoring is safe because start and end times are only used to graph records; the
timestamp's actual value is irrelevant and is not displayed in the user interface. Date
timestamps are still included with network-related records as part of their header data.
No new tests, because we cannot reliably test timing changes induced by debugger pauses.
It is possible for records to accrue time before the debugger pauses or after it resumes.
- inspector/InspectorCSSAgent.cpp: Remove unnecessary include.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::executionStopwatch): Add a shared stopwatch.
- inspector/InspectorController.h:
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::timestamp): Redirect to the shared stopwatch.
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
- inspector/InspectorPageAgent.h:
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::timestamp): Redirect to the shared stopwatch.
(WebCore::InspectorResourceAgent::willSendRequest):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::didFinishLoading):
(WebCore::InspectorResourceAgent::didFailLoading):
(WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorResourceAgent::didCloseWebSocket):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrame):
(WebCore::InspectorResourceAgent::didSendWebSocketFrame):
(WebCore::InspectorResourceAgent::didReceiveWebSocketFrameError):
- inspector/InspectorResourceAgent.h:
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart): Start and stop the stopwatch with timelines.
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::timestamp): Redirect to the shared stopwatch.
(WebCore::startProfiling):
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::willCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::TimelineTimeConverter::reset): Deleted.
- inspector/InspectorTimelineAgent.h:
(WebCore::TimelineTimeConverter::TimelineTimeConverter): Deleted.
(WebCore::TimelineTimeConverter::fromMonotonicallyIncreasingTime): Deleted.
(WebCore::InspectorTimelineAgent::timeConverter): Deleted.
- inspector/TimelineRecordFactory.cpp:
- inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::executionStopwatch): Add a shared stopwatch.
- inspector/WorkerInspectorController.h:
Source/WebInspectorUI:
Don't update the timeline's current time when the debugger is paused.
Start and end times for timeline records are now in seconds elapsed since timeline
recording started, rather than milliseconds since the epoch. Also convert code that
tracks page/resource load timings to use elapsed times rather than timestamps.
Add a workaround to preserve compatibility with old backends. Convert legacy timestamps
in multiple agents to elapsed times.
- UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveData):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidFinishLoading):
(WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
- UserInterface/Controllers/ProbeManager.js:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.computeElapsedTime): Forward to the active TimelineRecording.
(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):
(WebInspector.TimelineManager.prototype.pageDidLoad):
(WebInspector.TimelineManager.prototype._loadNewRecording):
- UserInterface/Models/Probe.js:
(WebInspector.ProbeSample):
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.updateForRedirectResponse):
(WebInspector.Resource.prototype.updateForResponse):
(WebInspector.Resource.prototype.increaseSize):
(WebInspector.Resource.prototype.markAsFinished):
(WebInspector.Resource.prototype.markAsFailed):
(WebInspector.Resource.prototype.revertMarkAsFinished):
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.computeElapsedTime):
- UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype._debuggerPaused):
(WebInspector.TimelineContentView.prototype._debuggerResumed):
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Stopwatch.h: Added. This implements a refcounted monotonic stopwatch.
(WTF::Stopwatch::create):
(WTF::Stopwatch::Stopwatch):
(WTF::Stopwatch::reset):
(WTF::Stopwatch::start):
(WTF::Stopwatch::stop):
(WTF::Stopwatch::elapsedTime):
- 12:58 PM Changeset in webkit [175202] by
-
- 1 edit1 add in trunk/LayoutTests
Add Mavericks results for platform/mac/editing/spelling/delete-autocorrected-word-2.html, too.
Yosemite, Mavericks and Mountain Lion all have different results.
- platform/mac-mavericks/platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt: Added.
- 12:25 PM Changeset in webkit [175201] by
-
- 3 edits in trunk/LayoutTests
Update Yosemite results for platform/mac/editing/spelling/delete-autocorrected-word-2.html.
Looks like this got confused during Yosemite tests landing.
This test is currently marked as failing on WK2, but it passed for me, so maybe we
can mark it as passing there too. Tracked as bug 105616.
- platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png:
- platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt:
- 12:21 PM Changeset in webkit [175200] by
-
- 2 edits in trunk/Source/WebCore
Fix builds using the public SDK.
- platform/spi/cocoa/NSExtensionSPI.h:
- 12:10 PM Changeset in webkit [175199] by
-
- 2 edits1 copy2 deletes in trunk/LayoutTests
Update results for compositing/rtl/rtl-fixed-overflow-scrolled.html.
Prior to Yosemite results landing, this test was marked as failing on WK2, and its
results matched WK1. It got changed several times during the merge, so it ended
up being marked as failing on WK1, but with WK1 results landed.
Let's land WK2 results and keep testing on WK2. Also, Mavericks results were no different
from Yosemite.
- platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Removed.
- platform/mac-mavericks/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt: Removed.
- platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png: Copied from LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.png.
- platform/mac/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
- 2:42 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
Oct 24, 2014:
- 8:18 PM Changeset in webkit [175198] by
-
- 5 edits in branches/safari-600.3-branch/Source
Versioning.
- 7:37 PM Changeset in webkit [175197] by
-
- 5 edits2 adds in trunk
Clamp wordSpacing percentage value.
https://bugs.webkit.org/show_bug.cgi?id=129350.
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-10-24
Reviewed by Zalan Bujtas.
Source/WebCore:
When the CSS wordSpacing property is percentage, its value has to be within the
pre-defined min/max values for the CSS length type. This is done the same way
the wordSpacing of type <length> is handled.
Tests: css3/infinite-word-spacing.html.
Move the definitions of minValueForCssLength and maxValueForCssLength from the
.cpp file to the .h file.
- css/CSSPrimitiveValue.cpp:
- css/CSSPrimitiveValue.h:
Clamp the wordSpacing value to minValueForCssLength and maxValueForCssLength when
its type is percentage.
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyWordSpacing::applyValue):
LayoutTests:
Make sure that setting the CSS style wordSpacing property to very huge percentage
value and blending this value with other values for animating key frames does
not assert or crash. The expectation is to have this huge value to be clamped to
the pre-defined min/max values for the CSS length type. So when blending the clamped
value with other wordSpacing values, the result can't be NaN. This should be very
similar to the case when it is set to a huge <length> value.
- css3/infinite-word-spacing-expected.txt: Added.
- css3/infinite-word-spacing.html: Added.
- 7:15 PM Changeset in webkit [175196] by
-
- 5 edits in trunk/Source
Fix the iOS build
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-10-24
Source/WebKit/mac:
- Configurations/WebKitLegacy.xcconfig:
- WebView/WebView.mm:
Source/WebKit2:
- Configurations/WebKit.xcconfig:
- 5:50 PM Changeset in webkit [175195] by
-
- 1 copy in tags/Safari-600.3.1
New Tag.
- 5:12 PM Changeset in webkit [175194] by
-
- 2 edits2 copies1 add in trunk/LayoutTests
Update Yosemite results for fast/block/float/overhanging-tall-block.html for
font size differences.
The test fails pixel results, filed bug 138065 to track that.
- platform/mac-mavericks/fast/block/float: Added.
- platform/mac-mavericks/fast/block/float/overhanging-tall-block-expected.png: Copied from LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.png.
- platform/mac-mavericks/fast/block/float/overhanging-tall-block-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/overhanging-tall-block-expected.txt.
- platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
- 4:51 PM Changeset in webkit [175193] by
-
- 6 edits1 add in trunk/Source/WebKit2
_actionMenuItemsForHitTestResult should also take a type indicating what the menu
was built for
https://bugs.webkit.org/show_bug.cgi?id=138063
Reviewed by Dan Bernstein.
New type enum that can be used by clients.
- Shared/API/c/WKActionMenuTypes.h: Added.
Remove the old SPI and add the new.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:]):
(-[WKView _actionMenuItemsForHitTestResult:defaultActionMenuItems:]): Deleted.
Now keep an ivar for the type.
- UIProcess/mac/WKActionMenuController.h:
Create a category for the old SPI so that we can still call it if clients have
implemented it.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController initWithPage:view:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(imageForResource:name::if):
(-[WKActionMenuController _updateActionMenuItems]):
- WebKit2.xcodeproj/project.pbxproj:
- 4:51 PM Changeset in webkit [175192] by
-
- 5 edits4 copies in trunk/LayoutTests
Update media test results for Yosemite.
media/controls-styling.html appears to actually fail, filed bug 138064 about that.
media/video-zoom-controls.html results are not great; Dean reportedly has a fix for that.
- platform/mac-mavericks/media/controls-styling-expected.png: Copied from LayoutTests/platform/mac/media/controls-styling-expected.png.
- platform/mac-mavericks/media/controls-styling-expected.txt: Copied from LayoutTests/platform/mac/media/controls-styling-expected.txt.
- platform/mac-mavericks/media/video-zoom-controls-expected.png: Copied from LayoutTests/platform/mac/media/video-zoom-controls-expected.png.
- platform/mac-mavericks/media/video-zoom-controls-expected.txt: Copied from LayoutTests/platform/mac/media/video-zoom-controls-expected.txt.
- platform/mac/media/controls-styling-expected.png:
- platform/mac/media/controls-styling-expected.txt:
- platform/mac/media/video-zoom-controls-expected.png:
- platform/mac/media/video-zoom-controls-expected.txt:
- 4:13 PM Changeset in webkit [175191] by
-
- 1 edit2 deletes in trunk/LayoutTests
Remove MountainLion results that I incorrectly copied. These are the same as Mavericks.
- platform/mac-mountainlion/fast/writing-mode: Removed.
- platform/mac-mountainlion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
- platform/mac-mountainlion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
- platform/mac-mountainlion/mathml: Removed.
- platform/mac-mountainlion/mathml/opentype: Removed.
- platform/mac-mountainlion/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Removed.
- 4:10 PM Changeset in webkit [175190] by
-
- 3 edits in trunk/Source/WebKit2
Share sheet doesn't attach to the window
https://bugs.webkit.org/show_bug.cgi?id=138062
<rdar://problem/18767397>
Reviewed by Beth Dakin.
- UIProcess/mac/WKActionMenuController.h:
WKActionMenuController is now a NSSharingService{Picker}Delegate.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForImage]):
Set us up as the NSSharingServicePicker delegate.
(-[WKActionMenuController sharingServicePicker:delegateForSharingService:]):
Set us up as the NSSharingService delegate.
(-[WKActionMenuController sharingService:sourceWindowForShareItems:sharingContentScope:]):
Return the appropriate window to attach to.
- 4:03 PM Changeset in webkit [175189] by
-
- 2 edits in trunk/Tools
Add Conrad Shultz to the contributors list.
- Scripts/webkitpy/common/config/contributors.json:
- 4:01 PM Changeset in webkit [175188] by
-
- 7 edits1 add in trunk/Source/WebKit2
Abstractify WebOriginDataManager to support arbitrary ChildProcess supplements.
https://bugs.webkit.org/show_bug.cgi?id=137993
Reviewed by Brady Eidson.
To allow different ChildProcess subclasses to handle listing and deletion of origin
data, make WebOriginDataManager more generic by having a supplement implement the
details, leaving WebOriginDataManager to deal with cross-process messaging.
De-virtualize AsyncTask, allowing a task to be created by passing in a
function<void()>, rather than an object, method, and arguments.
- Shared/AsyncTask.h:
(WebKit::AsyncTask::AsyncTask):
(WebKit::AsyncTask::performTask):
(WebKit::AsyncTask::~AsyncTask): Deleted.
Add a new virtual base class, to be implemented by various ChildProcesses, which
WebOriginDataManager will use to implement listing and deletion requests.
- WebProcess/OriginData/WebOriginDataManager.h:
- WebProcess/OriginData/WebOriginDataManagerSupplement.h: Added.
(WebKit::WebOriginDataManagerSupplement::WebOriginDataManagerSupplement):
(WebKit::WebOriginDataManagerSupplement::~WebOriginDataManagerSupplement):
(WebKit::WebOriginDataManagerSupplement::getOrigins):
(WebKit::WebOriginDataManagerSupplement::deleteEntriesForOrigin):
(WebKit::WebOriginDataManagerSupplement::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManagerSupplement::deleteAllEntries):
- WebKit2.xcodeproj/project.pbxproj:
WebOriginDataManager doesn't need to be a ChildSupplement. Remove the DatabaseProcess-
specific implementations for its message handlers and replace with clean, generic calls
to its supplement. Because these supplements may want to respond to the request
asynchronously, pass a completion function in to be called by the supplement once its
work is complete.
- WebProcess/OriginData/WebOriginDataManager.cpp:
(WebKit::WebOriginDataManager::WebOriginDataManager):
(WebKit::WebOriginDataManager::getOrigins):
(WebKit::WebOriginDataManager::deleteEntriesForOrigin):
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates):
(WebKit::WebOriginDataManager::deleteAllEntries):
(WebKit::WebOriginDataManager::supplementName): Deleted.
DatabaseProcess already uses WebOriginDataManager, so it will be the first process
to fall under the heel of the new regime. DatabaseProcess will subclass
WebOriginDataManagerSupplement, and pass itself in twice to the WebOriginDataManager
constructor. Create a lambda-based AsyncTask for each request, and call the completion
function when each request is complete.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::DatabaseProcess):
(WebKit::DatabaseProcess::getIndexedDatabaseOrigins):
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigin):
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::deleteAllIndexedDatabaseEntries):
(WebKit::DatabaseProcess::getOrigins):
(WebKit::DatabaseProcess::deleteEntriesForOrigin):
(WebKit::DatabaseProcess::deleteEntriesModifiedBetweenDates):
(WebKit::DatabaseProcess::deleteAllEntries):
(WebKit::DatabaseProcess::doGetIndexedDatabaseOrigins): Deleted.
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesForOrigin): Deleted.
(WebKit::DatabaseProcess::doDeleteIndexedDatabaseEntriesModifiedBetweenDates): Deleted.
(WebKit::DatabaseProcess::doDeleteAllIndexedDatabaseEntries): Deleted.
- DatabaseProcess/DatabaseProcess.h:
- 3:27 PM Changeset in webkit [175187] by
-
- 3 edits in trunk/Source/WebKit2
Very large images crash in action menu code
https://bugs.webkit.org/show_bug.cgi?id=138059
-and corresponding-
rdar://problem/18767859
Reviewed by Tim Horton.
If the HitTestResult failed to create and image, then don’t go for the image
action menu.
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItems]):
ShareableBitmap::createShareable() can fail. The result needs to be null-checked.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performActionMenuHitTestAtLocation):
- 3:24 PM Changeset in webkit [175186] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Use modern loops in ResourceRequestCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=138052
Reviewed by Darin Adler.
Use modern loops in ResourceRequestCocoa.mm and leverage Objective-C's
fast enumeration.
No new tests, no behavior change.
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
- Use NSDictionary's block-based enumeration as we enumerate both keys and values and this is faster than using fast enumeration of the keys then calling [NSDictionary objectForKey:]
- Use Objective C's fast enumeration for contentDispositionEncodingFallbackArray as this is faster and shorter than index based access. Also use reserveCapacity() / uncheckedAppend() for m_responseContentDispositionEncodingFallbackArray as we know how many elements were are going to append in the common case.
(WebCore::ResourceRequest::doUpdatePlatformRequest):
- Use fast enumeration for [nsRequest allHTTPHeaderFields] dictionary keys instead of calling [NSDictionary allKeys] and then doing index-based iteration, to avoid copying the keys to a new array. Also do a forward enumeration instead of a reverse one. I don't see why a backward enumeration would be necessary here. We are not modifying the NSDictionary we are iterating over as [nsRequest allHTTPHeaderFields] makes a copy.
- Use a modern C++ loop for m_responseContentDispositionEncodingFallbackArray.
- 3:01 PM Changeset in webkit [175185] by
-
- 3 edits in trunk/Source/WebKit2
Build fix.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
- 2:51 PM Changeset in webkit [175184] by
-
- 3 edits in trunk/Source/WebKit2
Blindly try to fix all the builds.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
- 2:49 PM Changeset in webkit [175183] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix.
- WebView/WebActionMenuController.mm:
(-[WebActionMenuController _openURLFromActionMenu:]):
(-[WebActionMenuController _addToReadingListFromActionMenu:]):
(-[WebActionMenuController _quickLookURLFromActionMenu:]):
- 2:45 PM Changeset in webkit [175182] by
-
- 6 edits6 adds in trunk/Source/WebKit
WebKit1 should support action menus
https://bugs.webkit.org/show_bug.cgi?id=138032
Reviewed by Tim Horton.
This patch adds basic support for action menus and adds actions for links.
Helper class takes care of all of the action menu work. WebView will forward the
prepareForMenu: message, and then the helper class takes it from there.
- WebView/WebActionMenuController.h: Added.
- WebView/WebActionMenuController.mm: Added.
(-[WebActionMenuController webViewClosed]):
(-[WebActionMenuController prepareForMenu:withEvent:]):
Selectors for link actions.
(-[WebActionMenuController _openURLFromActionMenu:]):
(-[WebActionMenuController _addToReadingListFromActionMenu:]):
(-[WebActionMenuController _elementBoundingBoxFromDOMElement:]):
(-[WebActionMenuController _quickLookURLFromActionMenu:]):
(-[WebActionMenuController _createActionMenuItemForTag:withHitTestResult:]):
(webKitBundleImageNamed):
(-[WebActionMenuController _defaultMenuItemsForLink:]):
(-[WebActionMenuController _defaultMenuItemsForHitTestResult:]):
Tags for the action menu items.
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.mm:
Set the action menu if possible and create the controller.
(-[WebView _initWithFrame:frameName:groupName:]):
(-[WebView _close]):
(-[WebView prepareForMenu:withEvent:]):
WebViewData stores the WebActionMenuHelper
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
- 2:45 PM Changeset in webkit [175181] by
-
- 2 edits in trunk/Source/WebKit2
Blindly try to fix all the builds.
- UIProcess/mac/WKActionMenuController.h:
- 2:39 PM Changeset in webkit [175180] by
-
- 3 edits in trunk/Source/WebKit2
Blindly try to fix the 32-bit build.
- UIProcess/mac/WKActionMenuController.h:
- UIProcess/mac/WKActionMenuController.mm:
- 2:13 PM Changeset in webkit [175179] by
-
- 2 edits in trunk/Source/WebKit2
[Mac][WebKit2] Move action menu code into its own file
https://bugs.webkit.org/show_bug.cgi?id=138034
<rdar://problem/18758758>
- UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController _addImageToPhotos:]):
Review comments that were not previously addressed.
- 2:08 PM Changeset in webkit [175178] by
-
- 3 edits2 adds in trunk/Source/WebKit2
[Mac][WebKit2] Move action menu code into its own file
https://bugs.webkit.org/show_bug.cgi?id=138034
<rdar://problem/18758758>
Reviewed by Dan Bernstein.
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):
Make a WKActionMenuController if needed.
(-[WKView prepareForMenu:withEvent:]):
(-[WKView willOpenMenu:withEvent:]):
(-[WKView didCloseMenu:withEvent:]):
(-[WKView _didPerformActionMenuHitTest:]):
Forward these to WKActionMenuController.
(-[WKView _openURLFromActionMenu:]): Deleted.
(-[WKView _addToReadingListFromActionMenu:]): Deleted.
(-[WKView _quickLookURLFromActionMenu:]): Deleted.
(-[WKView _createActionMenuItemForTag:]): Deleted.
(webKitBundleImageNamed): Deleted.
(-[WKView _copyImage:]): Deleted.
(-[WKView _saveImageToDownloads:]): Deleted.
(temporaryPhotosDirectoryPath): Deleted.
(pathToPhotoOnDisk): Deleted.
(-[WKView _addImageToPhotos:]): Deleted.
(-[WKView _defaultMenuItemsForImage]): Deleted.
(-[WKView _defaultMenuItems]): Deleted.
(-[WKView _updateActionMenu]): Deleted.
Moved to WKActionMenuController.
- UIProcess/mac/WKActionMenuController.h: Added.
- UIProcess/mac/WKActionMenuController.mm: Added.
(-[WKActionMenuController initWithPage:view:]):
(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController willOpenMenu:withEvent:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController didPerformActionMenuHitTest:]):
(-[WKActionMenuController _defaultMenuItemsForLink]):
(-[WKActionMenuController _openURLFromActionMenu:]):
(-[WKActionMenuController _addToReadingListFromActionMenu:]):
(-[WKActionMenuController _quickLookURLFromActionMenu:]):
(-[WKActionMenuController _defaultMenuItemsForImage]):
(-[WKActionMenuController _copyImage:]):
(-[WKActionMenuController _saveImageToDownloads:]):
(temporaryPhotosDirectoryPath):
(pathToPhotoOnDisk):
(-[WKActionMenuController _addImageToPhotos:]):
(-[WKActionMenuController _createActionMenuItemForTag:]):
(webKitBundleImageNamed):
(imageForResource:name::if):
(-[WKActionMenuController _updateActionMenuItems]):
Moved from WKView.
- WebKit2.xcodeproj/project.pbxproj:
- 1:59 PM Changeset in webkit [175177] by
-
- 2 edits in trunk/Source/WebCore
Replace INT_MIN/MAX / kFixedPointDenominator with intMin/MaxForLayoutUnit.
https://bugs.webkit.org/show_bug.cgi?id=138047
Reviewed by Andreas Kling.
No change in functionality.
- css/CSSPrimitiveValue.cpp:
- 1:26 PM Changeset in webkit [175176] by
-
- 4 edits8 adds in trunk/LayoutTests
[Win] More unreviewed gardening/rebaselining of Windows tests.
- platform/win/TestExpectations:
- platform/win/fast/repaint/select-option-background-color-expected.txt:
- platform/win/fast/repaint/slider-thumb-drag-release-expected.txt: Added.
- platform/win/fast/repaint/slider-thumb-float-expected.txt: Added.
- platform/win/fast/replaced/table-percent-height-expected.txt: Added.
- platform/win/fast/replaced/three-selects-break-expected.txt: Added.
- platform/win/fast/table/remove-td-display-none-expected.txt:
- platform/win/fast/transforms: Added.
- platform/win/fast/transforms/transformed-focused-text-input-expected.txt: Added.
- platform/win/platform/win/accessibility: Added.
- platform/win/platform/win/accessibility/option-element-position-and-size-expected.txt: Added.
- 1:23 PM Changeset in webkit [175175] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r174877): WebProcess sends an empty Cookies HTTP header
https://bugs.webkit.org/show_bug.cgi?id=138053
Reviewed by Chris Dumez.
Fixes existing tests.
- platform/network/mac/CookieJarMac.mm: (WebCore::cookiesForSession): Restore the
behavior of returning a null string when there are no cookies.
- 1:12 PM Changeset in webkit [175174] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
https://bugs.webkit.org/show_bug.cgi?id=138039
Reviewed by Darin Adler.
Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
for case-insensitive string comparison instead of converting to UTF-8 and then
using strcasecmp().
No new tests, no behavior change.
- platform/mac/QuickLookMac.mm:
(WebCore::QuickLookMac::computeNeedsQuickLookResourceCachingQuirks):
- 12:28 PM Changeset in webkit [175173] by
-
- 6 edits7 copies4 adds1 delete in trunk/LayoutTests
Update some results that were incorrect for Yosemite.
- platform/mac-mavericks/fast/text/international/hindi-spacing-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.png.
- platform/mac-mavericks/fast/text/international/hindi-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt.
- platform/mac-mavericks/fast/writing-mode: Added.
- platform/mac-mavericks/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png.
- platform/mac-mavericks/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
- platform/mac-mountainlion/fast/writing-mode: Added.
- platform/mac-mountainlion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Copied from LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png.
- platform/mac-mountainlion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Copied from LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt.
- platform/mac-mountainlion/mathml: Added.
- platform/mac-mountainlion/mathml/opentype: Added.
- platform/mac-mountainlion/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Copied from LayoutTests/platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt.
- platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
- platform/mac/fast/text/international/hindi-spacing-expected.png:
- platform/mac/fast/text/international/hindi-spacing-expected.txt:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
- platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- 12:16 PM Changeset in webkit [175172] by
-
- 2 edits in trunk/Source/JavaScriptCore
Simplified IndexingType's hasAnyArrayStorage().
<https://webkit.org/b/138051>
Reviewed by Michael Saboff.
IndexingType's hasAnyArrayStorage() currently does subtraction of ArrayStorageShape
with the purpose of making non-ArrayStorage types underflow (with that subtraction)
and have a result that exceeds SlowPutArrayStorageShape. What it is doing is
basically checking for a shape value that is greater equal to ArrayStorageShape.
We can just simplify the code as such.
Also added a comment to describe the structure of the bits in IndexingType.
- runtime/IndexingType.h:
(JSC::hasAnyArrayStorage):
- 12:13 PM Changeset in webkit [175171] by
-
- 3 edits in trunk/Source/WebCore
Avoid unnecessary NSURLRequest copies in ResourceRequest::doUpdatePlatformRequest() / doUpdatePlatformHTTPBody()
https://bugs.webkit.org/show_bug.cgi?id=138049
Reviewed by Alexey Proskuryakov.
Avoid unnecessary NSURLRequest copies in ResourceRequest::doUpdatePlatformRequest()
/ doUpdatePlatformHTTPBody(). It turns out that about half the time, the
m_nsRequest member is already mutable so it is unnecessary to call
[NSURLRequest mutableCopy], we can just cast it to an NSMutableURLRequest* and
avoid copying.
This patch also moves the code to a new ensureMutableNSURLRequest() method to
avoid duplicating the logic.
I see that we spend ~21% less time in these 2 functions when loading
http://flickr.com/explore/ (39.6ms -> 31.2ms).
No new tests, no behavior change.
- platform/network/cf/ResourceRequest.h:
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::ensureMutableNSURLRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
- 12:11 PM Changeset in webkit [175170] by
-
- 3 edits in trunk/LayoutTests
fast/multicol/fixed-stack.html failing since introduction.
https://bugs.webkit.org/show_bug.cgi?id=132421
- platform/mac-wk1/TestExpectations: As of Yosemite, it's failing on mac-wk1 too.
- platform/gtk/TestExpectations: [ Pass ] is no longer needed, because we don't have
an entry in global TestExpectations now.
- 11:32 AM Changeset in webkit [175169] by
-
- 4 edits in trunk/Source/WebCore
Move ComputeLength CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138036
Reviewed by Andreas Kling.
Move ComputeLength CSS properties from DeprecatedStyleBuilder to the
new StyleBuilder so that they are now generated. 3 Converters are
provided for these properties: ComputedLength / LineWidth / Spacing.
This is inspired by the following Blink revision by
<timloh@chromium.org>:
https://src.chromium.org/viewvc/blink?view=rev&revision=154012
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyComputeLength::setValue): Deleted.
(WebCore::ApplyPropertyComputeLength::applyValue): Deleted.
(WebCore::ApplyPropertyComputeLength::createHandler): Deleted.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertComputedLength):
(WebCore::StyleBuilderConverter::convertLineWidth):
(WebCore::StyleBuilderConverter::convertSpacing):
- 11:13 AM Changeset in webkit [175168] by
-
- 2 edits in trunk/Source/WebCore
Make ScriptWrappable's destructor protected instead of public
https://bugs.webkit.org/show_bug.cgi?id=138037
Reviewed by Andreas Kling.
Make ScriptWrappable's destructor protected instead of public as it is
not virtual and this class is subclassed a lot.
No new tests, no behavior change.
- bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::~ScriptWrappable):
- 10:25 AM Changeset in webkit [175167] by
-
- 2 edits in trunk/Source/WebKit
All plug-in tests fail on Yosemite WK1
https://bugs.webkit.org/show_bug.cgi?id=138040
Reviewed by Dan Bernstein.
Fix a symlink for WebKitPluginHost.app. There is also a broken symlink for WebKitPluginAgent,
which I don't know what to do about, but that seems harmless.
- WebKit.xcodeproj/project.pbxproj:
- 10:03 AM Changeset in webkit [175166] by
-
- 2 edits in trunk/Tools
build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
https://bugs.webkit.org/show_bug.cgi?id=138046
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
- Otherwise, we’ll retry normally in 45 seconds.
- 2:12 AM Changeset in webkit [175165] by
-
- 2 edits in trunk/LayoutTests
[Windows] Skip tests after removing SafariTheme that fail because background renders too dark.
https://bugs.webkit.org/show_bug.cgi?id=138042.
- platform/win/TestExpectations:
24 Roger Fong <roger_fong@apple.com>
- 2:04 AM Changeset in webkit [175164] by
-
- 2 edits in trunk/LayoutTests
[Windows] Skip tests after removing SafariTheme that fail because borders now render too dark.
https://bugs.webkit.org/show_bug.cgi?id=138041.
- platform/win/TestExpectations:
- 1:59 AM Changeset in webkit [175163] by
-
- 2 edits in trunk/LayoutTests
[Windows] More unreviewed gardening after getting rid of SafariTheme.
- platform/win/TestExpectations: Skip a handful of tests that were failing
on the Windows bots after removing SafariTheme for miscellaneous reasons.
- 1:51 AM Changeset in webkit [175162] by
-
- 2 edits in trunk/LayoutTests
[Windows] More unreviewed gardening after getting rid of SafariTheme.
https://bugs.webkit.org/show_bug.cgi?id=138025
- platform/win/TestExpectations: These tests fail seemingly due to text size difference,
which consequently cause the text containers to be too larger as well.
- 1:43 AM Changeset in webkit [175161] by
-
- 9 edits9 adds in trunk/LayoutTests
[Windows] More rebaselining of Windows tests after removing SafariTheme.
- platform/win/editing/selection/select-across-readonly-input-1-expected.txt:
- platform/win/editing/selection/select-across-readonly-input-2-expected.txt:
- platform/win/editing/selection/select-across-readonly-input-3-expected.txt:
- platform/win/fast/block/positioning/inline-block-relposition-expected.txt:
- platform/win/fast/canvas/fallback-content-expected.txt: Added.
- platform/win/fast/css/button-height-expected.txt:
- platform/win/fast/dom/HTMLInputElement: Added.
- platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Added.
- platform/win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Added.
- platform/win/fast/dom/tabindex-clamp-expected.txt: Added.
- platform/win/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
- platform/win/fast/html/details-no-summary4-expected.txt: Added.
- platform/win/fast/html/details-open-javascript-expected.txt: Added.
- platform/win/fast/html/details-open2-expected.txt: Added.
- platform/win/fast/html/details-open4-expected.txt: Added.
- platform/win/fast/html/details-replace-summary-child-expected.txt:
- platform/win/fast/html/details-replace-text-expected.txt:
- 12:09 AM Changeset in webkit [175160] by
-
- 10 edits in trunk
[GTK] Implement is_selected method on WebKitHitTestResult
https://bugs.webkit.org/show_bug.cgi?id=137110
Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2014-10-24
Reviewed by Tim Horton.
Source/WebKit2:
Expose CONTEXT_SELECTION for WebKitHitTestResult.
- Shared/WebHitTestResult.cpp: Add is_selected field and getter for this field.
(WebKit::WebHitTestResult::Data::Data):
(WebKit::WebHitTestResult::Data::encode):
(WebKit::WebHitTestResult::Data::decode):
- Shared/WebHitTestResult.h:
(WebKit::WebHitTestResult::isSelected):
- UIProcess/API/gtk/WebKitHitTestResult.cpp: Add WEBKIT_HIT_TEST_RESULT_CONTEXT_SELECTION context and method to check it.
(webkitHitTestResultCreate):
(webkitHitTestResultCompare):
(webkit_hit_test_result_context_is_selection):
- UIProcess/API/gtk/WebKitHitTestResult.h:
- UIProcess/API/gtk/WebKitWebView.cpp: Modify context-menu callback to set the new context option.
(webkitWebViewPopulateContextMenu):
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add documentation about new function.
Tools:
Add tests for new context SELECTION on WebKitHitTestResult.
- TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
(testContextMenuDefaultMenu):
- TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
(testWebViewMouseTarget):
Oct 23, 2014:
- 11:58 PM Changeset in webkit [175159] by
-
- 8 edits2 copies2 moves1 add1 delete in trunk/Source
[GTK][Cairo] Remove GTK dependency of WidgetBackingStoreGtkX11
https://bugs.webkit.org/show_bug.cgi?id=138004
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Rename all WidgetBackingStore* classes as
BackingStoreBackendCairo* since all of them are actually
BackingStore backends based on cairo, and move them from
platform/cairo and platform/gtk to platform/graphics/cairo.
BackingStoreBackendCairo is the base class that contains common
members like the surface and size. BackingStoreBackendCairoImpl is
the implementation using only cairo, and BackingStoreBackendCairoX11
using xlib. BackingStoreBackendCairoX11 receives all the X11
information it needs as constructor parameters, instead of using a
GtkWidget and GTK+ X11 API. BackingStoreBackendCairoImpl receives
the surface already created as constructor parameter, so that it
doesn't have any platform specific code now.
- PlatformEfl.cmake: Update compilation files.
- PlatformGTK.cmake: Ditto.
- platform/cairo/WidgetBackingStoreCairo.cpp: Removed.
- platform/graphics/cairo/BackingStoreBackendCairo.h: Renamed from Source/WebCore/platform/cairo/WidgetBackingStore.h.
(WebCore::BackingStoreBackendCairo::~BackingStoreBackendCairo):
(WebCore::BackingStoreBackendCairo::surface):
(WebCore::BackingStoreBackendCairo::size):
(WebCore::BackingStoreBackendCairo::BackingStoreBackendCairo):
- platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp: Added.
(WebCore::BackingStoreBackendCairoImpl::BackingStoreBackendCairoImpl):
(WebCore::BackingStoreBackendCairoImpl::~BackingStoreBackendCairoImpl):
(WebCore::BackingStoreBackendCairoImpl::scroll):
- platform/graphics/cairo/BackingStoreBackendCairoImpl.h: Renamed from Source/WebCore/platform/cairo/WidgetBackingStoreCairo.h.
- platform/graphics/cairo/BackingStoreBackendCairoX11.cpp: Renamed from Source/WebCore/platform/gtk/WidgetBackingStoreGtkX11.cpp.
(WebCore::BackingStoreBackendCairoX11::BackingStoreBackendCairoX11):
(WebCore::BackingStoreBackendCairoX11::~BackingStoreBackendCairoX11):
(WebCore::BackingStoreBackendCairoX11::scroll):
- platform/graphics/cairo/BackingStoreBackendCairoX11.h: Renamed from Source/WebCore/platform/gtk/WidgetBackingStoreGtkX11.h.
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::cairoSurfaceGetDeviceScale):
- platform/graphics/cairo/CairoUtilities.h:
Source/WebKit2:
- UIProcess/BackingStore.h: Rename m_backingStore as m_backend,
since it's a bit confusing that a BackingStore class has a
m_backingStore member and WidgetBackingStore has been renamed as
BackingStoreBackendCairo.
- UIProcess/cairo/BackingStoreCairo.cpp:
(WebKit::BackingStore::createBackend): Helper function to create
the BackingStore backend depending on the platform.
(WebKit::BackingStore::paint): Use m_backend instead of m_backingStore.
(WebKit::BackingStore::incorporateUpdate): Ditto.
(WebKit::BackingStore::scroll): Ditto.
(WebKit::createBackingStoreForGTK): Deleted.
- 8:35 PM Changeset in webkit [175158] by
-
- 2 edits in trunk/Source/WebCore
WebContent crash at WebCore::RenderTextControl::textFormControlElement const.
https://bugs.webkit.org/show_bug.cgi?id=138035
Reviewed by Antti Koivisto.
NULL-check element().renderer() before using it.
- html/SearchInputType.cpp:
(WebCore::SearchInputType::didSetValueByUserEdit):
- 8:00 PM Changeset in webkit [175157] by
-
- 2 edits in trunk/Source/WebKit2
Fix a bad find-and-replace in r175153
Looks like I messed up the commit on landing.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-10-23
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::didCommitLoadForFrame):
- 7:12 PM Changeset in webkit [175156] by
-
- 3 edits in trunk/Source/WebCore
Remove HarfBuzzRun::create() factory function
https://bugs.webkit.org/show_bug.cgi?id=137945
Reviewed by Ryosuke Niwa.
As a step to use std::unique_ptr<>, this patch applies std::unique_ptr<> and std::make_unique<>.
Thus HarfBuzzRun::create() is needed no longer.
No new tests, no behavior changes.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::collectHarfBuzzRuns):
- platform/graphics/harfbuzz/HarfBuzzShaper.h:
(WebCore::HarfBuzzShaper::HarfBuzzRun::create): Deleted.
- 6:32 PM Changeset in webkit [175155] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed iOS build fix
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2014-10-23
- editing/FrameSelection.cpp:
- 6:29 PM Changeset in webkit [175154] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Optimize URL::createCFURL() for the common case
https://bugs.webkit.org/show_bug.cgi?id=138030
Reviewed by Alexey Proskuryakov.
Optimize URL::createCFURL() for the common case by adding a fast path
for when the URL String is already 8-bit (common case).
When the string is 8-bit, we don't need to copy the bytes into a
temporary buffer and we can construct the CFURLRef directly from it.
This makes URL::createCFURL() ~34% faster on my machine.
No new tests, no behavior change.
- platform/mac/URLMac.mm:
(WebCore::URL::createCFURL):
- 5:44 PM Changeset in webkit [175153] by
-
- 4 edits in trunk/Source/WebKit2
[iOS WK2] If a page has the exact same VisibleContentRect as the page before, its VisibleContentRectUpdate can be ignored
https://bugs.webkit.org/show_bug.cgi?id=138031
rdar://problem/18739335
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-10-23
Reviewed by Simon Fraser.
Since any VisibleContentRectUpdate is costly for the WebProcess, we avoid sending updates
if none of the important parameters have changed (scale and geometry).
One unintended side effect is that the update of a page can be blocked if the parameters
of the previous page were identical.
What happen is this:
1) Page [A] sends its content rect update as needed. WebPageProxy saves the last update
in m_lastVisibleContentRectUpdate and use that value to avoid useless updates.
2) Page [B] load after page [A] and have the exact VisibleContentRect. When receiving the first
layer tree commit after didCommitLoadForFrame, WKWebView sends its VisibleContentRect
to WebPageProxy to synchronize the state of the WebProcess with what is on screen.
3) Since the two VisibleContentRect update has the same value as the ones of page [A], WebPageProxy
discards the update. The WebProcess has its initialization viewport and is not udpated until
a major parameter changes (scale or position).
In rdar://problem/18739335, the problem is the similar but with a different failure point:
1) Everything above happened already.
2) The layer tree transaction has a scrolling request. This is processed by WKWebView.
3) Since the scrolling position is invalid, the request is ignored and we send the last
VisibleContentRect to the WebProcess with WebPageProxy::resendLastVisibleContentRects().
4) Since the VisibleContentRect was never updated after didCommitLoadForFrame, the one we send
is for the previous page, which the web process correctly ignores.
This patch solves the problem by nuking the cached m_lastVisibleContentRectUpdate before
any valid VisibleContentRectUpdate for a new page.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didCommitLayerTree):
- 4:49 PM Changeset in webkit [175152] by
-
- 3 edits2 adds in trunk
Carets in GMail and iCloud compositions are the foreground text color
https://bugs.webkit.org/show_bug.cgi?id=138029
Reviewed by Simon Fraser.
Source/WebCore:
Previously, we were only checking whether the background colors of the foreground and background
elements were the same, rather than taking validity and opacity into consideration.
Test: editing/caret/color-span-inside-editable-background.html
- editing/FrameSelection.cpp:
(WebCore::disappearsIntoBackground):
(WebCore::CaretBase::paintCaret):
LayoutTests:
Test the case where the content editable root has a background color specified.
- editing/caret/color-span-inside-editable-background-expected.html: Added.
- editing/caret/color-span-inside-editable-background.html: Added.
- 4:43 PM Changeset in webkit [175151] by
-
- 31 edits6 adds in trunk/Source
Web Inspector: Provide a way to have alternate inspector agents
https://bugs.webkit.org/show_bug.cgi?id=137901
Reviewed by Brian Burg.
Source/JavaScriptCore:
Provide a way to use alternate inspector agents debugging a JSContext.
Expose a very slim private API that a client could use to know when
an inspector has connected/disconnected, and a way to register its
augmentative agents.
- Configurations/FeatureDefines.xcconfig:
- JavaScriptCore.xcodeproj/project.pbxproj:
New feature guard. New files.
- API/JSContextRef.cpp:
(JSGlobalContextGetAugmentableInspectorController):
- API/JSContextRefInspectorSupport.h: Added.
Access to the private interface from a JSContext.
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
- inspector/JSGlobalObjectInspectorController.h:
- inspector/augmentable/AugmentableInspectorController.h: Added.
(Inspector::AugmentableInspectorController::~AugmentableInspectorController):
(Inspector::AugmentableInspectorController::connected):
- inspector/augmentable/AugmentableInspectorControllerClient.h: Added.
(Inspector::AugmentableInspectorControllerClient::~AugmentableInspectorControllerClient):
- inspector/augmentable/AlternateDispatchableAgent.h: Added.
(Inspector::AlternateDispatchableAgent::AlternateDispatchableAgent):
Provide the private APIs a client could use to add alternate agents using alternate backend dispatchers.
- inspector/scripts/codegen/init.py:
- inspector/scripts/generate-inspector-protocol-bindings.py:
(generate_from_specification):
New includes, and use the new generator.
- inspector/scripts/codegen/generate_alternate_backend_dispatcher_header.py: Added.
(AlternateBackendDispatcherHeaderGenerator):
(AlternateBackendDispatcherHeaderGenerator.init):
(AlternateBackendDispatcherHeaderGenerator.output_filename):
(AlternateBackendDispatcherHeaderGenerator.generate_output):
(AlternateBackendDispatcherHeaderGenerator._generate_handler_declarations_for_domain):
(AlternateBackendDispatcherHeaderGenerator._generate_handler_declaration_for_command):
Generate the abstract AlternateInspectorBackendDispatcher interfaces.
- inspector/scripts/codegen/generate_backend_dispatcher_header.py:
(BackendDispatcherHeaderGenerator.generate_output):
(BackendDispatcherHeaderGenerator._generate_alternate_handler_forward_declarations_for_domains):
(BackendDispatcherHeaderGenerator._generate_alternate_handler_forward_declarations_for_domains.AlternateInspector):
Forward declare alternate dispatchers, and allow setting an alternate dispatcher on a domain dispatcher.
- inspector/scripts/codegen/generate_backend_dispatcher_implementation.py:
(BackendDispatcherImplementationGenerator.generate_output):
(BackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):
Check for and dispatch on an AlternateInspectorBackendDispatcher if there is one for this domain.
- inspector/scripts/codegen/generator_templates.py:
(AlternateInspectorBackendDispatcher):
(AlternateInspector):
Template boilerplate for prelude and postlude.
- inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
Rebaseline tests.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
- 4:36 PM Changeset in webkit [175150] by
-
- 2 edits in trunk/Source/WebCore
Don't assume that style.overflowX() == style.overflowY()
https://bugs.webkit.org/show_bug.cgi?id=138028
Reviewed by Zalan Bujtas.
WebKit doesn't support independent overflow scroll/hidden on different axes,
but the RenderStyle does report the correct values. So check both overflowX()
and overflowY() in a couple of places where we need to.
- rendering/RenderLayerCompositor.cpp:
(WebCore::styleHasTouchScrolling):
(WebCore::styleChangeRequiresLayerRebuild):
- 4:30 PM Changeset in webkit [175149] by
-
- 15 edits in trunk/Source/WebCore
Get rid of unnecessary vtables in WebKit
https://bugs.webkit.org/show_bug.cgi?id=138024
Reviewed by Benjamin Poulain.
Get rid of unnecessary vtables in WebKit by de-virtualizing destructors
when possible and marking the class as final to make sure people don't
subclass it.
No new tests, no behavior change.
- WebCore.exp.in:
- css/WebKitCSSMatrix.h:
- css/WebKitCSSMatrix.idl:
- html/canvas/WebGLContextGroup.h:
- html/canvas/WebGLGetInfo.h:
- html/canvas/WebGLUniformLocation.h:
(WebCore::WebGLUniformLocation::~WebGLUniformLocation): Deleted.
- html/canvas/WebGLUniformLocation.idl:
- inspector/DOMPatchSupport.h:
- inspector/InspectorHistory.h:
- inspector/InspectorStyleSheet.h:
- page/WheelEventDeltaTracker.h:
- page/scrolling/ScrollLatchingState.h:
- platform/audio/Biquad.h:
- platform/graphics/Pattern.h:
- 4:26 PM Changeset in webkit [175148] by
-
- 41 edits in trunk/Source
Clean up virtual functions in dom/
https://bugs.webkit.org/show_bug.cgi?id=138019
Reviewed by Benjamin Poulain.
Clean up virtual functions in dom/ by:
- Making virtual functions final when possible
- Making classes final when possible
- Using 'override' when appropriate
- Explicitly marking functions / destructors as virtual when they are inherently virtual
- Making isXXX() virtual functions private on XXX classes to avoid unnecessary type checks
- Dropping final for virtual functions in classes already marked as final
No new tests, no behavior change.
- WebCore.exp.in:
- dom/AutocompleteErrorEvent.h:
- dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEventInit::BeforeLoadEventInit):
- dom/BeforeTextInsertedEvent.h:
- dom/ClipboardEvent.h:
- dom/CompositionEvent.h:
- dom/CustomEvent.h:
- dom/DeviceMotionController.h:
(WebCore::DeviceMotionController::~DeviceMotionController): Deleted.
- dom/DeviceMotionEvent.h:
- dom/DeviceOrientationController.h:
(WebCore::DeviceOrientationController::~DeviceOrientationController): Deleted.
- dom/DeviceOrientationEvent.h:
- dom/Document.h:
- dom/DocumentFragment.h:
- dom/ErrorEvent.h:
- dom/FocusEvent.h:
- dom/HashChangeEvent.h:
- dom/KeyboardEvent.h:
- dom/LiveNodeList.h:
- dom/MessageEvent.h:
- dom/MessagePort.h:
- dom/MouseEvent.h:
- dom/MouseRelatedEvent.h:
- dom/MutationEvent.h:
- dom/NamedFlowCollection.h:
- dom/OverflowEvent.h:
- dom/PageTransitionEvent.h:
- dom/PendingScript.h:
- dom/PopStateEvent.h:
- dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::finish): Deleted.
(WebCore::RawDataDocumentParser::flush): Deleted.
(WebCore::RawDataDocumentParser::insert): Deleted.
(WebCore::RawDataDocumentParser::append): Deleted.
- dom/ScriptableDocumentParser.h:
- dom/SecurityPolicyViolationEvent.h:
- dom/TextEvent.h:
- dom/TouchEvent.h:
- dom/TransitionEvent.h:
- dom/UIEvent.h:
- dom/WebKitAnimationEvent.h:
- dom/WebKitTransitionEvent.h:
- dom/WheelEvent.h:
- page/DeviceController.h:
(WebCore::DeviceController::~DeviceController):
- 4:00 PM Changeset in webkit [175147] by
-
- 12 edits3 adds in trunk/Source
Add some SPI headers for NSExtension and NSSharingService{Picker}
https://bugs.webkit.org/show_bug.cgi?id=138027
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/cocoa/NSExtensionSPI.h: Added.
- platform/spi/mac/NSSharingServicePickerSPI.h: Added.
- platform/spi/mac/NSSharingServiceSPI.h: Added.
Add modern SPI headers for NSExtension, and NSSharingService{Picker}.
- rendering/RenderThemeMac.mm:
Replace redefinitions with an SPI header #import.
- UIProcess/API/mac/WKView.mm:
- UIProcess/mac/ServicesController.mm:
- UIProcess/mac/WebContextMenuProxyMac.mm:
Replace redefinitions with SPI header #imports.
- Misc/WebSharingServicePickerController.h:
- Misc/WebSharingServicePickerController.mm:
- WebCoreSupport/WebSelectionServiceController.mm:
- WebCoreSupport/WebContextMenuClient.mm:
Fix a sorting issue.
Replace redefinitions with SPI header #imports.
- 3:58 PM Changeset in webkit [175146] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed gardening after removing SafariTheme.
https://bugs.webkit.org/show_bug.cgi?id=138025.
- platform/win/TestExpectations:
- 3:22 PM Changeset in webkit [175145] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Make sure any dynamic viewport update schedules a layer tree commit
https://bugs.webkit.org/show_bug.cgi?id=138021
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-10-23
Reviewed by Simon Fraser.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
Sometimes, the clients can do a dynamic viewport update but only change the minimum
layout size (see rdar://problem/18755250).
When that happens, it is possible to do the full state update without ever scheduling
a layer tree commit. For example, if the new minimum layout height is only a few pixels
smaller than the old value and the layout of the page is equal or larger than the old value,
the layout is done without any side effect to the content (assuming a viewport configuration
based on width).
The contract with the client is that the next layer tree commit after a dynamic viewport update
carries all the valid parameters for the new viewport size. Since the new layout never scheduled
a layer tree commit, the UIProcess is just waiting for one, discarding all input.
This patch solves the issue by explicitely scheduling a layer flush after updating all the layout
and view parameters to their final values. In most cases, this makes no difference since a layer
tree commit was already scheduled. In the rare cases where nothing was scheduled, scheduling
the layer tree commit ensure we unlock the UIProcess.
- 3:01 PM Changeset in webkit [175144] by
-
- 14 edits51 adds in trunk/LayoutTests
[Win] Rebaseline a bunch of forms tests that no longer match after removing SafariTheme.
https://bugs.webkit.org/show_bug.cgi?id=138022.
- platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Added.
- platform/win/fast/forms/basic-inputs-expected.txt:
- platform/win/fast/forms/basic-textareas-expected.txt: Added.
- platform/win/fast/forms/basic-textareas-quirks-expected.txt: Added.
- platform/win/fast/forms/blankbuttons-expected.txt:
- platform/win/fast/forms/button-generated-content-expected.txt:
- platform/win/fast/forms/button-inner-block-reuse-expected.txt: Added.
- platform/win/fast/forms/control-clip-expected.txt: Added.
- platform/win/fast/forms/fieldset-align-expected.txt: Added.
- platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
- platform/win/fast/forms/fieldset-with-float-expected.txt: Added.
- platform/win/fast/forms/float-before-fieldset-expected.txt: Added.
- platform/win/fast/forms/focus-selection-textarea-expected.txt: Added.
- platform/win/fast/forms/indeterminate-expected.txt: Added.
- platform/win/fast/forms/input-appearance-readonly-expected.txt: Added.
- platform/win/fast/forms/input-appearance-visibility-expected.txt: Added.
- platform/win/fast/forms/input-first-letter-expected.txt: Added.
- platform/win/fast/forms/input-readonly-dimmed-expected.txt: Added.
- platform/win/fast/forms/input-spaces-expected.txt: Added.
- platform/win/fast/forms/input-text-click-outside-expected.txt: Added.
- platform/win/fast/forms/input-type-text-min-width-expected.txt: Added.
- platform/win/fast/forms/input-width-expected.txt: Added.
- platform/win/fast/forms/listbox-onchange-expected.txt: Added.
- platform/win/fast/forms/menulist-clip-expected.txt:
- platform/win/fast/forms/menulist-option-wrap-expected.txt: Added.
- platform/win/fast/forms/menulist-separator-painting-expected.txt: Added.
- platform/win/fast/forms/menulist-width-change-expected.txt:
- platform/win/fast/forms/negativeLineHeight-expected.txt: Added.
- platform/win/fast/forms/onselect-textarea-expected.txt: Added.
- platform/win/fast/forms/option-script-expected.txt:
- platform/win/fast/forms/option-text-clip-expected.txt:
- platform/win/fast/forms/placeholder-pseudo-style-expected.txt: Added.
- platform/win/fast/forms/range/input-appearance-range-expected.txt: Added.
- platform/win/fast/forms/range/range-thumb-height-percentage-expected.txt: Added.
- platform/win/fast/forms/range/slider-padding-expected.txt: Added.
- platform/win/fast/forms/range/slider-thumb-shared-style-expected.txt: Added.
- platform/win/fast/forms/range/slider-thumb-stylability-expected.txt: Added.
- platform/win/fast/forms/range/thumbslider-no-parent-slider-expected.txt: Added.
- platform/win/fast/forms/search-cancel-button-style-sharing-expected.txt: Added.
- platform/win/fast/forms/search-display-none-cancel-button-expected.txt: Added.
- platform/win/fast/forms/search-rtl-expected.txt: Added.
- platform/win/fast/forms/search-styled-expected.txt:
- platform/win/fast/forms/search-vertical-alignment-expected.txt: Added.
- platform/win/fast/forms/select-background-none-expected.txt: Added.
- platform/win/fast/forms/select-empty-option-height-expected.txt: Added.
- platform/win/fast/forms/select-size-expected.txt: Added.
- platform/win/fast/forms/select-style-expected.txt: Added.
- platform/win/fast/forms/select-visual-hebrew-expected.txt: Added.
- platform/win/fast/forms/select-writing-direction-natural-expected.txt:
- platform/win/fast/forms/selectlist-minsize-expected.txt: Added.
- platform/win/fast/forms/stuff-on-my-optgroup-expected.txt: Added.
- platform/win/fast/forms/textAreaLineHeight-expected.txt: Added.
- platform/win/fast/forms/textarea-align-expected.txt: Added.
- platform/win/fast/forms/textarea-metrics-expected.txt: Added.
- platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Added.
- platform/win/fast/forms/textarea-placeholder-visibility-1-expected.txt:
- platform/win/fast/forms/textarea-placeholder-visibility-2-expected.txt:
- platform/win/fast/forms/textarea-scroll-height-expected.txt: Added.
- platform/win/fast/forms/textarea-scrollbar-expected.txt:
- platform/win/fast/forms/textarea-scrolled-type-expected.txt: Added.
- platform/win/fast/forms/textarea-setinnerhtml-expected.txt: Added.
- platform/win/fast/forms/textarea-width-expected.txt:
- platform/win/fast/forms/textfield-overflow-by-value-update-expected.txt: Added.
- platform/win/fast/forms/textfield-overflow-expected.txt: Added.
- 2:51 PM Changeset in webkit [175143] by
-
- 2 edits in trunk/Source/WebKit2
WebContent crash in WebKit::WebPage::expandedRangeFromHandle
https://bugs.webkit.org/show_bug.cgi?id=138023
Reviewed by Enrica Casucci.
The crashes are caused by rangeForBlockAtPoint returning a null Range.
Exit early or continue if a range is null in various places.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::expandedRangeFromHandle): Continue looking for another point if the range returned by
rangeForBlockAtPoint is null.
(WebKit::WebPage::contractedRangeFromHandle): Ditto.
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle): Removed the FIXME now that Enrica has
verified that this early exit added in r173788 is correct.
- 2:04 PM Changeset in webkit [175142] by
-
- 2 edits in trunk/Tools
[Win] Skip failing JSC tests following r175078
https://bugs.webkit.org/show_bug.cgi?id=130967.
- Scripts/run-javascriptcore-tests:
- 1:54 PM Changeset in webkit [175141] by
-
- 2 edits in trunk/Source/JavaScriptCore
offsets.rb:183:in `buildOffsetsMap': unhandled exception - is offlineasm dependency tracking broken? (132668)
https://bugs.webkit.org/show_bug.cgi?id=138017
Reviewed by Mark Lam.
Removed from the nput file $(SRCROOT)/llint/LowLevelAssembler.asm and output file
$(BUILT_PRODUCTS_DIR)/LLIntOffsets/LLIntDesiredOffsets.h from the Generate Derived Sources
build phase in the LLInt Offset target. There is no need for Xcode to do any dependency
checking with these files as the ruby script offlineasm/generate_offset_extractor.rb will
do that for us.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 1:29 PM Changeset in webkit [175140] by
-
- 1 copy in tags/Safari-600.1.4.12.2
New tag.
- 1:27 PM Changeset in webkit [175139] by
-
- 3 edits in trunk/Source/WebCore
[Mac] don't update caption user style sheet during parsing
https://bugs.webkit.org/show_bug.cgi?id=137983
rdar://problem/18735366
Reviewed by Jer Noble.
No new tests, existing tests cover the changes.
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::CaptionUserPreferencesMediaAF): Initialize m_updateStyleSheetTimer.
(WebCore::CaptionUserPreferencesMediaAF::updateTimerFired): Call updateCaptionStyleSheetOveride.
(WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges): Prime a timer to update
the captions style sheet after a slight delay.
- 12:56 PM Changeset in webkit [175138] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Double border appearing in node sidebar in expanded items in OS X Mavericks.
https://bugs.webkit.org/show_bug.cgi?id=138011
Reviewed by Timothy Hatcher.
Selector added for OS X Mavericks and earlier versions using .mac-platform.legacy.
- UserInterface/Views/DetailsSection.css:
(body.mac-platform.legacy .details-section .details-section:first-child):
- 12:51 PM Changeset in webkit [175137] by
-
- 4 edits in trunk/Source/WebCore
Move remaining Length-type properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138012
Reviewed by Antti Koivisto.
Move remaining Length-type properties from DeprecatedStyleBuilder to
the new StyleBuilder so that they are now generated from
CSSPropertyNames.in as well. The patch introduces a couple of type
converters for those: "LengthSizing / LengthMaxSizing".
No new tests, no behavior change.
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertLengthSizing):
(WebCore::StyleBuilderConverter::convertLengthMaxSizing):
- 12:42 PM Changeset in webkit [175136] by
-
- 1 edit in trunk/Websites/bugs.webkit.org/Bugzilla/Install/Filesystem.pm
Teach Bugzilla how to set permissions for *.js files correctly
- Bugzilla/Install/Filesystem.pm:
(Bugzilla::Install::Filesystem::FILESYSTEM): Set permissions for
*.js files correctly when checksetup.pl is run.
- 12:38 PM Changeset in webkit [175135] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] iPhone unselecting items in <select multiple> shows incorrect values selected
https://bugs.webkit.org/show_bug.cgi?id=137989
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-10-23
Reviewed by Alexey Proskuryakov.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKMultipleSelectPicker pickerView:row:column:checked:]):
The second argument is "allowsMultipleSelection" and should only be set
when we are making a selection in a <select multiple>.
- 12:26 PM Changeset in webkit [175134] by
-
- 2 edits in tags/Safari-601.1.5/Source/JavaScriptCore
Merged r175058. <rdar://problem/18739720>
- 12:17 PM Changeset in webkit [175133] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Correcting the merge for r175075. <rdar://problem/18717767>
- 12:03 PM Changeset in webkit [175132] by
-
- 2 edits in trunk/Source/WebKit/mac
Crashes under WebSelectionServiceController::hasRelevantSelectionServices
https://bugs.webkit.org/show_bug.cgi?id=138013
Reviewed by Dan Bernstein.
- WebCoreSupport/WebSelectionServiceController.mm:
(WebSelectionServiceController::hasRelevantSelectionServices):
Don't adopt this autoreleased object.
- 11:28 AM Changeset in webkit [175131] by
-
- 4 edits2 adds in trunk
[Mac] Safari cannot play 'audio/amr' content.
https://bugs.webkit.org/show_bug.cgi?id=137894
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-can-play-case-insensitive.html
Sites are returning 'video/amr' for AMR audio content, but the IANA spec says 'audio/AMR', which is also what
AVFoundation claims to support. However, MIME types are supposed to be case-insensitive. When creating our
mime type cache, case-fold to lower all MIME types given to us by our media frameworks.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::mimeTypeCache):
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::addFileTypesToCache):
LayoutTests:
- media/media-can-play-case-insensitive-expected.txt: Added.
- media/media-can-play-case-insensitive.html: Added.
- 11:01 AM Changeset in webkit [175130] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebCore
Merged r174827. rdar://problem/18742369
- 10:55 AM Changeset in webkit [175129] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r175127. <rdar://problem/18717767>
- 10:52 AM Changeset in webkit [175128] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Correcting the merge for r175075. <rdar://problem/18717767>
- 10:46 AM Changeset in webkit [175127] by
-
- 2 edits in trunk/Source/WebKit2
Assertion failures in ImageKit soft linking
https://bugs.webkit.org/show_bug.cgi?id=138009
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
Soft-link ImageKit correctly.
ImageKit is inside the Quartz umbrella framework.
- 10:19 AM Changeset in webkit [175126] by
-
- 3 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merge patch for r174799. <rdar://problem/18742380>
- 9:34 AM Changeset in webkit [175125] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Fix the build after <http://trac.webkit.org/changeset/175079>
(https://bugs.webkit.org/show_bug.cgi?id=137995)
Rubber-stamped by Anders Carlsson.
Remove PageClientImpl::didPerformActionMenuHitTest() for iOS.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didPerformActionMenuHitTest): Deleted.
- 9:19 AM Changeset in webkit [175124] by
-
- 16 edits6 copies in branches/safari-600.3-branch/Source/WebKit2
Merge r175075. <rdar://problem/18717767>
- 9:14 AM Changeset in webkit [175123] by
-
- 8 edits1 add in trunk/Source/WebCore
Move Length-type CSS properties from DeprecatedStyleBuilder to the new Style Builder
https://bugs.webkit.org/show_bug.cgi?id=138000
Reviewed by Andreas Kling.
Move most Length-type CSS properties from DeprecatedStyleBuilder to the
new Style Builder so that they are now generated. This patch adds
support for a "Converter" option in CSSPropertyNames.in that can be
used to specify a type converter function in
css/StyleBuilderConverter.h. This patch adds support for Length and
LengthOrAuto converters so that most Length-type properties can now be
generated.
Another converter (likely called "LengthSizing") will be needed to
generate the remaining Length-type properties. This will be taken care
of in a follow-up patch.
This patch is inspired by the following Blink revision by
<timloh@chromium.org>:
https://src.chromium.org/viewvc/blink?view=rev&revision=150500
No new tests, no behavior change.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSPropertyNames.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
- css/SVGCSSPropertyNames.in:
- css/StyleBuilder.h:
- css/StyleBuilderConverter.h: Added.
(WebCore::StyleBuilderConverter::convertLength):
(WebCore::StyleBuilderConverter::convertLengthOrAuto):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- css/makeprop.pl:
- 9:09 AM Changeset in webkit [175122] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r175016. <rdar://problem/18731860>
- 8:56 AM Changeset in webkit [175121] by
-
- 3 edits1 copy in branches/safari-600.3-branch/Source/WebKit2
Merge r174913. <rdar://problem/18712808>
- 8:52 AM Changeset in webkit [175120] by
-
- 5 edits in branches/safari-600.3-branch/Source/WebKit2
Merge r175061. <rdar://problem/18694470>
- 8:50 AM Changeset in webkit [175119] by
-
- 12 edits1 copy3 adds in branches/safari-600.3-branch/Source
Merge r174908. <rdar://problem/18694470>
- 6:19 AM WebKitGTK/2.4.x edited by
- (diff)
- 6:15 AM Changeset in webkit [175118] by
-
- 2 edits in trunk/Source/JavaScriptCore
Change CallFrame::lexicalGlobalObject() to use Callee instead of JSScope
https://bugs.webkit.org/show_bug.cgi?id=136901
Reviewed by Mark Lam.
Implement ExecState::lexicalGlobalObject() using Callee.
- runtime/JSScope.h:
(JSC::ExecState::lexicalGlobalObject):
- 5:20 AM Changeset in webkit [175117] by
-
- 17 edits in trunk/Source/WebCore
Const-ify static s_resourceType members in RenderSVGResource* classes
https://bugs.webkit.org/show_bug.cgi?id=137911
Reviewed by Andreas Kling.
Make s_resourceType static members in RenderSVGResource* classes const.
Also update the resourceType() methods, where necessary, so that they
return the s_resourceType constant.
- rendering/svg/RenderSVGResourceClipper.cpp:
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceFilter.cpp:
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceLinearGradient.cpp:
- rendering/svg/RenderSVGResourceLinearGradient.h:
- rendering/svg/RenderSVGResourceMarker.cpp:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.cpp:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.cpp:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceRadialGradient.cpp:
- rendering/svg/RenderSVGResourceRadialGradient.h:
- rendering/svg/RenderSVGResourceSolidColor.cpp:
- rendering/svg/RenderSVGResourceSolidColor.h:
- 4:17 AM Changeset in webkit [175116] by
-
- 3 edits in trunk/Source/WebCore
[TexMap] Clean up virtual method declarations in GraphicsLayerTextureMapper
https://bugs.webkit.org/show_bug.cgi?id=137957
Reviewed by Martin Robinson.
Added override notation to the GraphicsLayerTextureMapper methods that are
overriding the base methods from the GraphicsLayer class and don't have it yet.
Also reordered these methods to follow the order of declaration in the
GraphicsLayer class.
Removed ::setName() and ::willBeDestroyed() methods since they just called
the base class' methods.
Also removed the ::solidColor() and ::changeMask() methods. The first one was
only called in one place which can reference the m_solidColor member directly,
and the second one wasn't used at all.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
(WebCore::GraphicsLayerTextureMapper::setName): Deleted.
(WebCore::GraphicsLayerTextureMapper::willBeDestroyed): Deleted.
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(WebCore::GraphicsLayerTextureMapper::solidColor): Deleted.
(WebCore::GraphicsLayerTextureMapper::usesContentsLayer): Deleted.
(WebCore::GraphicsLayerTextureMapper::platformLayer): Deleted.
(WebCore::GraphicsLayerTextureMapper::changeMask): Deleted.
- 2:55 AM Changeset in webkit [175115] by
-
- 3 edits in trunk/Source/WTF
[GTK] Fix build on Hurd
https://bugs.webkit.org/show_bug.cgi?id=138003
Reviewed by Carlos Garcia Campos.
- wtf/InlineASM.h:
- wtf/Platform.h:
- 2:53 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:50 AM WebKitGTK/2.6.x edited by
- (diff)
- 2:35 AM Changeset in webkit [175114] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix build problem after r175098
https://bugs.webkit.org/show_bug.cgi?id=138002
Reviewed by Gyuyoung Kim.
Add ECORE_X dependency to avoid linking problems while building unit tests.
- PlatformEfl.cmake:
Change-Id: I9228d141456c3b34b61424aa4715cef85534104f
- 2:33 AM Changeset in webkit [175113] by
-
- 11 edits in branches/safari-600.3-branch/Source/WebCore
Merged r174040. rdar://problem/18428706
- 2:30 AM Changeset in webkit [175112] by
-
- 12 edits in branches/safari-600.3-branch/Source
Merged r173694. rdar://problem/18428706
- 2:29 AM Changeset in webkit [175111] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebCore
Merged r173208. rdar://problem/18428706
- 2:28 AM Changeset in webkit [175110] by
-
- 4 edits in branches/safari-600.3-branch/Source/WebCore
Merged r173133. rdar://problem/18428706
- 2:26 AM Changeset in webkit [175109] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r173132. rdar://problem/18428706
- 2:25 AM Changeset in webkit [175108] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebCore
Merged r172964. rdar://problem/18428706
- 2:24 AM Changeset in webkit [175107] by
-
- 6 edits in branches/safari-600.3-branch/Source/WebCore
Merged r172963. rdar://problem/18428706
- 2:23 AM Changeset in webkit [175106] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r172653. rdar://problem/18428706
- 2:22 AM Changeset in webkit [175105] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r172646. rdar://problem/18428706
- 2:21 AM Changeset in webkit [175104] by
-
- 3 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r172645. rdar://problem/18428706
- 2:20 AM Changeset in webkit [175103] by
-
- 12 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r172637. rdar://problem/18428706
- 2:18 AM Changeset in webkit [175102] by
-
- 2 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r172634. rdar://problem/18428706
- 2:17 AM Changeset in webkit [175101] by
-
- 8 edits in branches/safari-600.3-branch/Source/WebKit2
Merged r172629. rdar://problem/18428706
- 2:02 AM Changeset in webkit [175100] by
-
- 4 edits in trunk/Source/WebCore
AX: Do the early return when role is different than UnknownRole
https://bugs.webkit.org/show_bug.cgi?id=137880
Reviewed by Chris Fleizach.
We do not need to call ariaRoleAttribute() to check whether m_ariaRole is different than UnknownRole.
Just check m_ariaRole instead.
No new tests, no behavior change, just some cleanup
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::determineAccessibilityRole):
- 1:21 AM Changeset in webkit [175099] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Set proper default value for WebPageAccessibilityObject
https://bugs.webkit.org/show_bug.cgi?id=137951
Reviewed by Csaba Osztrogonác.
Initial value for WebPageAccessibilityObject should be nullptr.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 1:02 AM Changeset in webkit [175098] by
-
- 8 edits3 adds in trunk/Source/WebKit2
[EFL] Introduce EFL Accessibility in WebKit
https://bugs.webkit.org/show_bug.cgi?id=137819
Reviewed by Gyuyoung Kim.
EFL Accessibility provides an API that is used to notify clients that certain
Accessibility events occur. Utilizing it makes WebKit-EFL coherent with EFL native
accessibility approach.
- PlatformEfl.cmake:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/EwkView.h:
(EwkView::webAccessibility):
- UIProcess/API/efl/WebAccessibility.cpp: Added.
(WebKit::WebAccessibility::WebAccessibility):
(WebKit::WebAccessibility::~WebAccessibility):
(WebKit::WebAccessibility::eventHandler):
(WebKit::WebAccessibility::executeGestureAction):
(WebKit::WebAccessibility::activate):
(WebKit::WebAccessibility::read):
(WebKit::WebAccessibility::readNext):
(WebKit::WebAccessibility::readPrev):
(WebKit::WebAccessibility::up):
(WebKit::WebAccessibility::down):
(WebKit::WebAccessibility::scroll):
(WebKit::WebAccessibility::mouse):
(WebKit::WebAccessibility::enable):
(WebKit::WebAccessibility::disable):
- UIProcess/API/efl/WebAccessibility.h: Added.
(WebKit::WebAccessibility::activateAction):
(WebKit::WebAccessibility::nextAction):
(WebKit::WebAccessibility::prevAction):
(WebKit::WebAccessibility::readAction):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_accessibility_action_activate_get):
(ewk_view_accessibility_action_next_get):
(ewk_view_accessibility_action_prev_get):
(ewk_view_accessibility_action_read_by_point_get):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_accessibility.cpp: Added.
(EWK2Accessibility::xwindow):
(TEST_F):
- UIProcess/WebPageProxy.h:
- UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::accessibilityObjectReadByPoint):
(WebKit::WebPageProxy::accessibilityObjectReadPrevious):
(WebKit::WebPageProxy::accessibilityObjectReadNext):
- 12:27 AM Changeset in webkit [175097] by
-
- 3 edits4 adds in trunk
CSS JIT: Implement :matches
https://bugs.webkit.org/show_bug.cgi?id=137947
Reviewed by Benjamin Poulain.
Source/WebCore:
Initial patch for supporting :matches in CSS JIT.
In this patch, we implement :matches
by leveraging the generalized nested backtracking implementation.
Tests: fast/selectors/matches-backtracking.html
fast/selectors/matches-complex.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::hasAnyCombinators):
(WebCore::SelectorCompiler::computeBacktrackingMemoryRequirements):
(WebCore::SelectorCompiler::computeBacktrackingInformation):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesMatchesPseudoClass):
LayoutTests:
- fast/selectors/matches-backtracking-expected.txt: Added.
- fast/selectors/matches-backtracking.html: Added.
- fast/selectors/matches-complex-expected.txt: Added.
- fast/selectors/matches-complex.html: Added.
- nested :matches
- multiple :matches
- :matches with CannotMatchAnything
- :matches with :not
- :matches(with a lot of selectors) are tested.
- 12:17 AM Changeset in webkit [175096] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r175081. rdar://problem/17785162
- 12:17 AM Changeset in webkit [175095] by
-
- 2 edits in trunk/Source/WebCore
RenderThemeGtk::mediaControlsScript() is not defined when VIDEO is disabled.
<https://webkit.org/b/137970>.
Patch by Milan Crha <mcrha@redhat.com> on 2014-10-23
Reviewed by Carlos Garcia Campos.
- rendering/RenderThemeGtk.cpp:
- 12:15 AM Changeset in webkit [175094] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebCore
Merged r174846. rdar://problem/18742390
- 12:08 AM Changeset in webkit [175093] by
-
- 3 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r174788. rdar://problem/17916459
- 12:06 AM Changeset in webkit [175092] by
-
- 4 edits in branches/safari-600.1.4.12-branch/Source/WebCore
Merged r174787. rdar://problem/18742395
- 12:03 AM Changeset in webkit [175091] by
-
- 2 edits in branches/safari-600.1.4.12-branch/Source/WebKit2
Merged r174512. rdar://problem/18742317
- 12:01 AM Changeset in webkit [175090] by
-
- 3 edits in branches/safari-600.1.4.12-branch/Source/WebCore
Merged r173974. rdar://problem/18742384
