Timeline



Nov 27, 2014:

11:04 PM Changeset in webkit [176555] by ryuan.choi@navercorp.com
  • 10 edits
    1 delete in trunk

[EFL] Remove E_Dbus dependency
​https://bugs.webkit.org/show_bug.cgi?id=136355

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/FindE_DBus.cmake: Removed.
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
This patch replaces E_Dbus implementation to Eldbus.

  • PlatformEfl.cmake:
  • platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::batteryProperties):
(WebCore::batteryPropertiesChanged):
(WebCore::BatteryProviderEfl::deviceTypeCallback):
(WebCore::BatteryProviderEfl::enumerateDevices):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired): Deleted.
(WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
(WebCore::BatteryProviderEfl::setBatteryClient): Deleted.

  • platform/efl/BatteryProviderEfl.h:

(WebCore::BatteryProviderEfl::connection):
(WebCore::BatteryProviderEfl::setSignalHandler):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.

Source/WebKit2:

  • UIProcess/API/efl/ewk_main.cpp: Added init/shutdown for eldbus.

(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):

Tools:

  • MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
5:40 PM Changeset in webkit [176554] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
​https://bugs.webkit.org/show_bug.cgi?id=139057

Reviewed by Anders Carlsson.

No test, don't know how to repro.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.

4:51 PM Changeset in webkit [176553] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr instead of OwnPtr in JSC classes
​https://bugs.webkit.org/show_bug.cgi?id=139009

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

  • bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):

  • bytecode/DFGExitProfile.h:
  • bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::add):

  • bytecode/LazyOperandValueProfile.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::clearNewlyAllocated):

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

  • runtime/RegExp.cpp:

(JSC::RegExp::invalidateCode):

  • runtime/RegExp.h:
  • yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

4:24 PM Changeset in webkit [176552] by jdiggs@igalia.com
  • 9 edits in trunk

AX: [ATK] Meter and Option elements do not expose their id attribute
​https://bugs.webkit.org/show_bug.cgi?id=139017

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The options in a collapsed select element lack a node, so get the id
attribute from the associated action element. In the case of a meter,
the meter element itself is not exposed; its RenderMeter is instead.
So associate the meter element's id with the exposed RenderMeter.

No new tests. Instead, updated existing expectations to reflect the fix.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::element):

  • accessibility/AccessibilityProgressIndicator.h:
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

LayoutTests:

  • accessibility/roles-exposed.html: Unskipped the meter element test.
  • platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
10:00 AM Changeset in webkit [176551] by andersca@apple.com
  • 5 edits
    2 copies in trunk/Source/WebKit

Add a stubbed out WebVisitedLinkStore to WebViewGroup
​https://bugs.webkit.org/show_bug.cgi?id=139066

Reviewed by Antti Koivisto.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::visitedLinkStore):

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::WebViewGroup):

  • WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
  • WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.

(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

9:58 AM Changeset in webkit [176550] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add a Page::setVisitedLinkStore member function
​https://bugs.webkit.org/show_bug.cgi?id=139065

Reviewed by Antti Koivisto.

This will be used in a subsequent commit.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::setVisitedLinkStore):

  • page/Page.h:
4:47 AM WebKitGTK/2.4.x edited by Andres Gomez
(diff)
4:04 AM Changeset in webkit [176549] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.
​https://bugs.webkit.org/show_bug.cgi?id=139061

rebaseline after r176354.

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-27

  • platform/gtk/fast/multicol/tall-image-behavior-expected.png: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-expected.txt: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-lr-expected.png: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-rl-expected.png: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
3:39 AM Changeset in webkit [176548] by Andres Gomez
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update NavigationItemProbes icon for the GTK+ port
​https://bugs.webkit.org/show_bug.cgi?id=139074

Reviewed by Carlos Garcia Campos.

NavigationItemProbes was updated for the Mac port and we are now
having a similar ideogram in GTK+.

  • UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.

Nov 26, 2014:

5:39 AM Changeset in webkit [176547] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening after r176354.
​https://bugs.webkit.org/show_bug.cgi?id=139060

rebaseline after r176354.

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-26

  • platform/efl/fast/multicol/tall-image-behavior-expected.png: Added.
  • platform/efl/fast/multicol/tall-image-behavior-expected.txt: Added.
  • platform/efl/fast/multicol/tall-image-behavior-lr-expected.png: Added.
  • platform/efl/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
  • platform/efl/fast/multicol/tall-image-behavior-rl-expected.png: Added.
  • platform/efl/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
12:08 AM Changeset in webkit [176546] by commit-queue@webkit.org
  • 3 edits
    2 adds
    2 deletes in trunk/Tools

[EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
​https://bugs.webkit.org/show_bug.cgi?id=139047

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-11-26
Reviewed by Carlos Garcia Campos.

  • efl/jhbuild.modules:
  • efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
  • efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
  • gtk/jhbuild-optional.modules:
  • gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
  • gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.

Nov 25, 2014:

4:27 PM Changeset in webkit [176545] by commit-queue@webkit.org
  • 15 edits in trunk

Add parsing for :dir()
​https://bugs.webkit.org/show_bug.cgi?id=138932

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2014-11-25
Reviewed by Benjamin Poulain.

Source/WebCore:

Add support for parsing :dir() pseudo class. The implementation of selector
matching will be in a follow-up patch.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):

  • css/CSSSelector.cpp:

(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/selectors/invalid-functional-pseudo-class-expected.txt:
  • fast/selectors/invalid-functional-pseudo-class.html:
11:50 AM Changeset in webkit [176544] by andersca@apple.com
  • 11 edits in trunk/Source

Remove user content handling from PageGroup
​https://bugs.webkit.org/show_bug.cgi?id=139051

Reviewed by Antti Koivisto.

Source/WebCore:

Remove m_userContentController from PageGroup and the related functions and symbol exports.

  • WebCore.exp.in:
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addPage):
(WebCore::PageGroup::removePage):
(WebCore::PageGroup::addUserScriptToWorld): Deleted.
(WebCore::PageGroup::addUserStyleSheetToWorld): Deleted.
(WebCore::PageGroup::removeUserScriptFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetFromWorld): Deleted.
(WebCore::PageGroup::removeUserScriptsFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetsFromWorld): Deleted.
(WebCore::PageGroup::removeAllUserContent): Deleted.

  • page/PageGroup.h:

Source/WebKit/mac:

Use the user content controller in the web view group.

  • WebView/WebView.mm:

(-[WebView _injectOutlookQuirksScript]):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
Talk to the user content controller from the passed in WebPageGroupProxy.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Create the WebPageGroupProxy before creating the page so we can get its user content controller and
pass it to the page configuration if necessary.

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::userContentController):
New function that lazily creates a user content controller. We don't want to create this eagerly since
it's not used with the modern API.

(WebKit::WebPageGroupProxy::addUserStyleSheet):
(WebKit::WebPageGroupProxy::addUserScript):
(WebKit::WebPageGroupProxy::removeAllUserStyleSheets):
(WebKit::WebPageGroupProxy::removeAllUserScripts):
(WebKit::WebPageGroupProxy::removeAllUserContent):
Call through to the user content controller.

  • WebProcess/WebPage/WebPageGroupProxy.h:

Add an m_userContentController member.

10:05 AM Changeset in webkit [176543] by alex
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, upload two missing test files in the commit r174677.

  • mathml/presentation/mo-stretch-update-expected.html: Added.
  • mathml/presentation/mo-stretch-update.html: Added.
8:16 AM Changeset in webkit [176542] by andersca@apple.com
  • 7 edits in trunk/Source

Add a user content controller to WebViewGroup and use it for user content
​https://bugs.webkit.org/show_bug.cgi?id=139043

Reviewed by Antti Koivisto.

Source/WebCore:

  • WebCore.exp.in:

Export symbols.

  • page/Page.cpp:

(WebCore::Page::setUserContentController):
Invalidate the injected style cache when setting a new user content controller.

Source/WebKit/mac:

This is another tiny step towards getting rid of user content handling inside PageGroup.

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::userContentController):
Add a UserContentController member and getter.

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::get):
Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).

(WebViewGroup::WebViewGroup):
Create a user content controller.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
set its user content controller in the PageConfiguration.

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Ditto.

(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
(+[WebView _removeAllUserContentFromGroup:]):
Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.

(-[WebView setGroupName:]):
Set the user content controller to the new WebViewGroup's user content controller.

6:49 AM Changeset in webkit [176541] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] gstmpegts is not initialized
​https://bugs.webkit.org/show_bug.cgi?id=139039

Reviewed by Carlos Garcia Campos.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer): Initialize the gstmpegts library.

6:29 AM Changeset in webkit [176540] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
version of libraries when running the temporary executable
​https://bugs.webkit.org/show_bug.cgi?id=138833

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-25
Reviewed by Carlos Garcia Campos.

This patch modifies LD_LIBRARY_PATH to make sure the dynamic linker
find the correct version of libraries when running the temporary
executable to generate the .gir file.

  • PlatformGTK.cmake:
5:48 AM Changeset in webkit [176539] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
​https://bugs.webkit.org/show_bug.cgi?id=138090

Patch by Tanay C <​tanay.c@samsung.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.

  • MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll

(browserWindowZoomIn): Added.
(browserWindowZoomOut): Added.
(scrollEventCallback): Added.
(zoomInCallback): Modified.
(zoomOutCallback): Modified.
(browserWindowConstructed): Modified.

1:59 AM Changeset in webkit [176538] by Csaba Osztrogonác
  • 5 edits in trunk

[EFL] REGRESSION(r176514): It made performance tests fail
​https://bugs.webkit.org/show_bug.cgi?id=139037

Reviewed by Gyuyoung Kim.

Source/WebKit2:

  • WebProcess/efl/WebProcessMainEfl.cpp: Don't try to load/shutdown eail if eailLibraryPath() is empty.

Tools:

  • Scripts/webkitpy/port/efl.py:

(EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.

  • efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so

only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.

Nov 24, 2014:

11:41 PM Changeset in webkit [176537] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/WebCore

Fix unused variable warning in Biquad.cpp
​https://bugs.webkit.org/show_bug.cgi?id=139031

Reviewed by Andreas Kling.

No new tests needed.

  • platform/audio/Biquad.cpp:
11:39 PM Changeset in webkit [176536] by evab.u-szeged@partner.samsung.com
  • 4 edits
    4 deletes in trunk/Source

Remove Qt cruft related to tap higlighting
​https://bugs.webkit.org/show_bug.cgi?id=139030

Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

  • CMakeLists.txt:
  • page/GestureTapHighlighter.cpp: Removed.
  • page/GestureTapHighlighter.h: Removed.

Source/WebKit2:

  • CMakeLists.txt:
  • WebProcess/WebPage/TapHighlightController.cpp: Removed.
  • WebProcess/WebPage/TapHighlightController.h: Removed.
9:26 PM Changeset in webkit [176535] by commit-queue@webkit.org
  • 5 edits in trunk

Fix the parsing and re-serialization of :lang pseudo class selector when it has multiple arguments with same value
​https://bugs.webkit.org/show_bug.cgi?id=139013

Patch by Dhi Aurrahman <​diorahman@rockybars.com> on 2014-11-24
Reviewed by Benjamin Poulain.

Source/WebCore:

Fix the parsing and re-serialization of :lang pseudo class selector when
it has multiple arguments with same value e.g. :lang(en, en, en). Previously,
given :lang(en, en, en) selector, it was parsed and reserialized
as :lang(enenen) instead of :lang(en, en, en)

Related test on parsing and re-serialization of css selectors is updated.

  • css/CSSSelector.cpp:

(WebCore::appendArgumentList):

LayoutTests:

Updated tests to verify the parsing and serialization of :lang pseudo class
selector when it has multiple arguments with same value.

  • fast/css/css-selector-text-expected.txt: Updated to cover fix.
  • fast/css/css-selector-text.html: Updated to cover fix.
7:47 PM Changeset in webkit [176534] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Fix r176527. Iterate through the text renderers.
​https://bugs.webkit.org/show_bug.cgi?id=139007

Reviewed by Antti Koivisto.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

6:40 PM Changeset in webkit [176533] by gyuyoung.kim@samsung.com
  • 14 edits in trunk/Source/JavaScriptCore

Clean up OwnPtr and PassOwnPtr in JSC - bytecode, jit, inspector, and interpreter
​https://bugs.webkit.org/show_bug.cgi?id=139022

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

  • bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):

  • bytecode/DFGExitProfile.h:
  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::JITFinalizer):

  • dfg/DFGJITFinalizer.h:
  • heap/IncrementalSweeper.h:
  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

  • inspector/agents/InspectorDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.h:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::enableSampler):

  • interpreter/Interpreter.h:
  • jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::ExecutableAllocator):

  • jit/ExecutableAllocator.h:
5:37 PM Changeset in webkit [176532] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix since r176530.

  • UIProcess/CoordinatedGraphics/WebView.cpp: Replace pointer with reference.

(WebKit::WebView::processDidExit):

5:00 PM Changeset in webkit [176531] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Rename TextFragment::mustBreak to TextFragment::isLineBreak
​https://bugs.webkit.org/show_bug.cgi?id=139035

Reviewed by Antti Koivisto.

Move new line logic to FlowContents class.
This is in preparation to support <br>.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::TextFragment::TextFragment):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::isNewline):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter): Deleted.

4:26 PM Changeset in webkit [176530] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit2

[WK2] Remove some bad stuff from WebPageProxy
​https://bugs.webkit.org/show_bug.cgi?id=138896

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-11-24
Reviewed by Sam Weinig.

The state loadStateAtProcessExit does not seem to be used anywhere.

The state urlAtProcessExit only exists to forward the url from
WebPageProxy::resetStateAfterProcessExited() to the coordinated graphics code
WebView::processDidExit().

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::processDidExit):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::urlAtProcessExit): Deleted.
(WebKit::WebPageProxy::loadStateAtProcessExit): Deleted.

4:20 PM Changeset in webkit [176529] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Move :placeholder-shown out of experimental
​https://bugs.webkit.org/show_bug.cgi?id=138998

Reviewed by Andreas Kling.

The pseudo class :placeholder-shown is used by the inspector, disabling it breaks
the sidebar.

The implementation has been stable for a while, we can move it to stable.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasPlaceholderShown):

4:15 PM Changeset in webkit [176528] by Antti Koivisto
  • 4 edits
    2 adds in trunk

Avoid String concatenation with line break iterator
​https://bugs.webkit.org/show_bug.cgi?id=139034

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/text/simple-lines-multiple-renderers-break.html

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::initializeSegments):

Include String too so it doesn't need to be fetched from the renderer.

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):

Make this iterative instead of recursive.
Uset setPriorContext to provide previous characters instead of concatenating
the string from all the previous segments.

(WebCore::SimpleLineLayout::findNextNonWhitespace):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):

Search using segments instead of the concatenated string.

(WebCore::SimpleLineLayout::FlowContents::textWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPositionSlow):
(WebCore::SimpleLineLayout::FlowContents::runWidth):
(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow): Deleted.
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Deleted.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition): Deleted.

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::characterAt):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::segmentIndexForPosition):
(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):

LayoutTests:

Test that there is no implicit break point between Text nodes.

  • fast/text/simple-lines-multiple-renderers-break-expected.html: Added.
  • fast/text/simple-lines-multiple-renderers-break.html: Added.
4:10 PM Changeset in webkit [176527] by Alan Bujtas
  • 3 edits
    4 adds in trunk

SimpleLineLayout::canUseFor() should iterate through RenderTexts to check if their content is eligible for simple line layout.
​https://bugs.webkit.org/show_bug.cgi?id=139007

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html

fast/text/simple-line-layout-multiple-renderers-with-float.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

LayoutTests:

  • fast/text/simple-line-layout-multiple-renderers-non-breaking-space-expected.html: Added.
  • fast/text/simple-line-layout-multiple-renderers-non-breaking-space.html: Added.
  • fast/text/simple-line-layout-multiple-renderers-with-float-expected.html: Added.
  • fast/text/simple-line-layout-multiple-renderers-with-float.html: Added.
4:05 PM Changeset in webkit [176526] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] update-webkitgtk-libs fails to build fontconfig
​https://bugs.webkit.org/show_bug.cgi?id=139032

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-24
Reviewed by Martin Robinson.

On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
fontconfig will try to generate documentation and fail.

  • gtk/install-dependencies:
3:56 PM Changeset in webkit [176525] by Alan Bujtas
  • 3 edits in trunk/LayoutTests

Simple line layout: fast/text/simple-lines-multiple-renderers test has the wrong content.
​https://bugs.webkit.org/show_bug.cgi?id=139036

Swap simple-lines-multiple-renderers.html and simple-lines-multiple-renderers-expected.html

  • fast/text/simple-lines-multiple-renderers-expected.html:
  • fast/text/simple-lines-multiple-renderers.html:
2:12 PM Changeset in webkit [176524] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Move the '-webkit-box-reflext' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139008

Reviewed by Anders Carlsson.

  • css/CSSPropertyNames.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertReflection):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

2:09 PM Changeset in webkit [176523] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Stub out user content WebView member functions on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139033

Reviewed by Sam Weinig.

These functions aren't used by any clients and hinder getting rid of PageGroup.
If it turns out they're still needed we can copy the user content controller code from Mac Legacy WebKit.

  • WebView.cpp:

(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
(toStringVector): Deleted.

12:48 PM Changeset in webkit [176522] by ryuan.choi@navercorp.com
  • 2 edits in trunk/Source/WebKit2

[EFL] REGRESSION(176066): It made all performance tests fail
​https://bugs.webkit.org/show_bug.cgi?id=138865

Reviewed by Csaba Osztrogonác.

Since r176066, there are crash because evas_gl_surface is destroyed with
invalid evas_gl instance after evas_gl is destroyed.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::~EwkView):

10:07 AM Changeset in webkit [176521] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Remove unused Style struct from SimpleLineLayout.cpp
​https://bugs.webkit.org/show_bug.cgi?id=139027

Reviewed by Sam Weinig.

It was moved to FlowContents.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::Style::Style): Deleted.

9:02 AM Changeset in webkit [176520] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Compile error in ResourceHandleManager.cpp.
​https://bugs.webkit.org/show_bug.cgi?id=139026

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-11-24
Reviewed by Brent Fulgham.

The parameter types of the constructor of the Timer class has changed.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::ResourceHandleManager):
(WebCore::ResourceHandleManager::downloadTimerCallback):

  • platform/network/curl/ResourceHandleManager.h:
6:49 AM Changeset in webkit [176519] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

Webkit2 doesnt build on powerpc 32 bits
​https://bugs.webkit.org/show_bug.cgi?id=130837

Reviewed by Carlos Garcia Campos.

Check if libatomic is needed in order to use std::atomic, and add
it to the list of WebKit2 libraries.

  • PlatformGTK.cmake:
6:13 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
4:50 AM Changeset in webkit [176518] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.7.2

WebKitGTK+ 2.7.2

4:45 AM Changeset in webkit [176517] by Carlos Garcia Campos
  • 4 edits in trunk

.:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.1 release.

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.7.2 release.

  • gtk/NEWS: Add release notes for 2.7.2.
4:12 AM Changeset in webkit [176516] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ make distcheck.

  • gtk/manifest.txt: Remove deleted files.
4:05 AM Changeset in webkit [176515] by jdiggs@igalia.com
  • 6 edits in trunk

AX: [ATK] Unskip the skipped ATK tests in roles-exposed.html
​https://bugs.webkit.org/show_bug.cgi?id=139016

Reviewed by Chris Fleizach.

Source/WebCore:

There was one test that could not be unskipped without making a change
for that one to pass: mapping DocumentRegionRole to ATK_ROLE_PANEL. The
rest of the "fix" is just unskipping tests for ATK and updating the test
expectations.

No new tests needed.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

LayoutTests:

  • accessibility/roles-exposed.html: Unskipped a bunch of tests.
  • platform/efl/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Updated for unskipped tests.
3:30 AM Changeset in webkit [176514] by k.czech@samsung.com
  • 4 edits
    1 add in trunk

[EFL] Utilize Eail library to support accessibility in EFL
​https://bugs.webkit.org/show_bug.cgi?id=137742

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Initialize EAIL module so that all the listeners and atk-bridge started properly.
Dynamic loading of EAIL help us to avoid elementary dependencies in WebKit.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(eailLibraryPath): reads path provided by ACCESSIBILITY_EAIL_LIBRARY_PATH variable.
(eail):

Tools:

Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.

  • efl/jhbuild-optional.modules: Added.
  • efl/jhbuild.modules:
3:18 AM Changeset in webkit [176513] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
​https://bugs.webkit.org/show_bug.cgi?id=139023

Reviewed by Sergio Villar Senin.

Source/WebKit2:

The WebKitWebContext is a construct only property, so it's always
set to the default value when not provided, during the
construction. When a related-view is used to create a new web view
we should ensure that the same web context is used for the new web
view, instead of the default. We should also ignore any web
context given as construct parameter if a related view is alos provided.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Do not set the context to the default
one when not given during construction.
(webkitWebViewSetProperty): Only use the default web context when
not provided as construct parameter and there isn't a related view.

Tools:

Rename WebKitWebView/default-context as WebKitWebView/web-context
and check we are always using the right context for new web views.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewWebContext):
(beforeAll):
(testWebViewDefaultContext): Deleted.

Nov 23, 2014:

11:24 PM Changeset in webkit [176512] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK] Add API to override the default local storage directory
​https://bugs.webkit.org/show_bug.cgi?id=138828

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add WebKitWebContext:local-storage-directory construct-only
property. If not provided the default will be used.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextGetProperty):
(webkitWebContextSetProperty):
(webkitWebContextConstructed):
(webkit_web_context_class_init):

Tools:

Add test to check that the local storage directory is created at
the path given on construction.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextConfiguration):
(beforeAll):

  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(Test::Test):
(Test::~Test): Deleted.

9:21 PM Changeset in webkit [176511] by Conrad Shultz
  • 4 edits in trunk/Source/WebKit2

Page previews should have titles
​https://bugs.webkit.org/show_bug.cgi?id=139020

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKViewPrivate.h:

Declare -_titleForPreviewOfURL:.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _titleForPreviewOfURL:]):
Stub implementation.

  • UIProcess/mac/WKActionMenuController.mm:

(+[WKPagePreviewViewController previewPadding]):
Account for the title height.
(-[WKPagePreviewViewController loadView]):
Set correct autoresize masks on some views; create and configure a title view that is
horizontally and vertically centered.
(-[WKActionMenuController pagePreviewViewController:titleForPreviewOfURL:]):
WKPagePreviewViewControllerDelegate method; wrap -[WKView _titleForPreviewOfURL:].

10:46 AM Changeset in webkit [176510] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Use segment vector for FlowContents
​https://bugs.webkit.org/show_bug.cgi?id=139015

Reviewed by Zalan Bujtas.

And FlowContents::Segment struct and use it.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary):

Use segments.
If there is only one segment there is nothing to do. Bail out.

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::initializeSegments):

Move initialization to a function so m_segments can be const.
Don't add empty end segment, handle the end case in code.

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::textWidth):

Simplify and use segments.

(WebCore::SimpleLineLayout::FlowContents::segmentForPositionSlow):

Replace hand-rolled binary search with std::lower_bounds.

(WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded):
(WebCore::SimpleLineLayout::FlowContents::renderer): Deleted.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): Deleted.

  • rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::hasOneSegment):
(WebCore::SimpleLineLayout::FlowContents::length):
(WebCore::SimpleLineLayout::FlowContents::isEnd):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent): Deleted.

Renamed.

(WebCore::SimpleLineLayout::FlowContents::segmentForPosition):

Inline the fast path.

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):

10:00 AM Changeset in webkit [176509] by Simon Fraser
  • 12 edits in trunk/Source

Extend WKRenderObject and WKRenderLayer with some more useful data
​https://bugs.webkit.org/show_bug.cgi?id=139006

Reviewed by Sam Weinig.
Source/WebCore:

Export WebCore::RenderLayerBacking::backingStoreMemoryEstimate() const.

  • WebCore.exp.in:

Source/WebKit2:

Implement WKRenderLayerGetBackingStoreMemoryEstimate,
WKRenderObjectCopyTextSnippet and WKRenderObjectGetTextLength for improved
RenderLayer and RenderTree display in clients of the C SPI.

  • Shared/API/c/WKRenderLayer.cpp:

(WKRenderLayerGetBackingStoreMemoryEstimate):

  • Shared/API/c/WKRenderLayer.h:
  • Shared/API/c/WKRenderObject.cpp:

(WKRenderObjectCopyTextSnippet):
(WKRenderObjectGetTextLength):

  • Shared/API/c/WKRenderObject.h:
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Shared/WebRenderLayer.h:

(WebKit::WebRenderLayer::backingStoreMemoryEstimate):

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):

  • Shared/WebRenderObject.h:

(WebKit::WebRenderObject::textSnippet):
(WebKit::WebRenderObject::textLength):

Note: See TracTimeline for information about the timeline view.