Context Navigation

← Previous Period
Next Period →

Timeline

Nov 28, 2014:

11:11 PM Changeset in webkit [176572] by gyuyoung.kim@samsung.com

7 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr<>|make_unique<> in ftl, bytecode of JSC
https://bugs.webkit.org/show_bug.cgi?id=139063

Reviewed by Andreas Kling.

Clean up OwnPtr and PassOwnPtr in JSC.

bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::push):

bytecode/StructureStubClearingWatchpoint.h:

(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):

ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

ftl/FTLJITFinalizer.h:
ftl/FTLLink.cpp:

(JSC::FTL::link):

parser/SourceProviderCacheItem.h:

10:20 PM Changeset in webkit [176571] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Move the '-webkit-initial-letter', '-webkit-line-box-contain' and '-webkit-text-stroke-width' CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=139053

Patch by Sam Weinig <sam@webkit.org> on 2014-11-28
Reviewed by Andreas Kling.

css/CSSPropertyNames.in:
css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertInitialLetter):
(WebCore::StyleBuilderConverter::convertTextStrokeWidth):
(WebCore::StyleBuilderConverter::convertLineBoxContain):

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

2:10 PM Changeset in webkit [176570] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Stale userData is handed to WKView _actionMenuItemsForHitTestResult under prepareForMenu
https://bugs.webkit.org/show_bug.cgi?id=139069
<rdar://problem/19075587>

Reviewed by Sam Weinig.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController wkView:willHandleMouseDown:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _clearActionMenuState]):
Previously, _userData was not being cleared in didCloseMenu, so a subsequent
action menu invocation would end up sending stale userData to _actionMenuItemsForHitTestResult.

Additionally, factor all of the cleanup code out into _clearActionMenuState,
and call it from both wkView:willHandleMouseDown: and didCloseMenu:withEvent:.

2:09 PM Changeset in webkit [176569] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

DataDetectors PageOverlay callbacks are never called
https://bugs.webkit.org/show_bug.cgi?id=139067
<rdar://problem/19086676>

Reviewed by Anders Carlsson.

Shared/mac/ActionMenuHitTestResult.mm:

(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Encode/decode the PageOverlay ID.

10:39 AM Changeset in webkit [176568] by Simon Fraser

6 edits in trunk/Source/WebKit2

Allow clients of the WKRenderLayerRef C SPI to connect layer trees across frame boundaries
https://bugs.webkit.org/show_bug.cgi?id=139021

Reviewed by Dan Bernstein.

Add WKRenderLayerGetFrameContentsLayer which returns a WKRenderLayerRef for
the content document of a RenderWidget, if its has one (e.g. frames, iframes
and <object> with document contents).

Shared/API/c/WKRenderLayer.cpp:

(WKRenderLayerGetFrameContentsLayer):

Shared/API/c/WKRenderLayer.h:
Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):

Shared/WebRenderLayer.h:

(WebKit::WebRenderLayer::frameContentsLayer):

9:05 AM Changeset in webkit [176567] by commit-queue@webkit.org

2 edits
3 adds in trunk/Tools

Unreviewed, rolling out r176564.
https://bugs.webkit.org/show_bug.cgi?id=139093

massive failures on release test bot (Requested by philn on
#webkit).

Reverted changeset:

"[GStreamer] Bump internal jhbuild versions to 1.4.4"
https://bugs.webkit.org/show_bug.cgi?id=138866
http://trac.webkit.org/changeset/176564

8:39 AM Changeset in webkit [176566] by Carlos Garcia Campos

4 edits in trunk/Tools

[GTK] Use GMainLoopSource in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=138831

Reviewed by Sergio Villar Senin.

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.

WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.

7:27 AM Changeset in webkit [176565] by Philippe Normand

2 edits in trunk

[CMake] Build failure against GStreamer git master
https://bugs.webkit.org/show_bug.cgi?id=138872

Reviewed by Csaba Osztrogon.

Source/cmake/FindGStreamer.cmake: Simplified the

FIND_GSTREAMER_COMPONENT macro. Trust pkg-config for include
headers lookup, there's no need to do this manually. Also
explicitely check the version specified in GStreamer_FIND_VERSION.

6:42 AM Changeset in webkit [176564] by Philippe Normand

2 edits
3 deletes in trunk/Tools

[GStreamer] Bump internal jhbuild versions to 1.4.4
https://bugs.webkit.org/show_bug.cgi?id=138866

Reviewed by Carlos Garcia Campos.

gtk/jhbuild.modules:
gtk/patches/gst-events-arent-gstobjects.patch: Removed.
gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.

6:29 AM Changeset in webkit [176563] by Carlos Garcia Campos

14 edits
2 deletes in trunk/Tools

[GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
https://bugs.webkit.org/show_bug.cgi?id=138834

Reviewed by Sergio Villar Senin.

It makes everyting simpler and the tests run faster too, since we
don't need to spawn the private bus and wait until the DBus name
is registered. The web extension registers a new JavaSCript class
with a status method to run the tests, similar to the DBus
method. In the UI process side, tests use webkit_web_view_run_java_script()
instead of sending a DBus message.

TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:

(WebKitDOMNodeFilterTest::create):
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
(WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
(WebKitDOMNodeFilterTest::runTest): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::create):
(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::webPageFromArgs): Deleted.
(WebKitDOMNodeTest::runTest): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:

(WebKitDOMXPathNSResolverTest::create):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
(WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
(WebKitDOMXPathNSResolverTest::runTest): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:

(WebKitFrameTest::create):
(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):
(WebKitFrameTest::webPageFromArgs): Deleted.
(WebKitFrameTest::runTest): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(testWebKitDOMNodeTagNames):
(beforeAll):
(afterAll):

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:

(runTest):
(beforeAll):
(afterAll):

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:

(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(runTest): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:

(webkitFrameTestRun):
(beforeAll):
(afterAll):

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(testsMap):
(WebProcessTest::add):
(WebProcessTest::create):
(runTest):
(windowObjectClearedCallback):
(webkit_web_extension_initialize):
(methodCallCallback): Deleted.
(webkit_web_extension_initialize_with_user_data): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::runWebProcessTest):

TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:

5:41 AM Changeset in webkit [176562] by Csaba Osztrogonác

2 edits
1 add in trunk/Tools

[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=139086

Reviewed by Gyuyoung Kim.

efl/jhbuild.modules:
efl/patches/libseccomp-pick-up-CC.patch: Added.

3:05 AM Changeset in webkit [176561] by Philippe Normand

2 edits in trunk/Source/WebCore

[GStreamer] HTTP source element lacks SCHEDULING query support
https://bugs.webkit.org/show_bug.cgi?id=139064

Reviewed by Carlos Garcia Campos.

No new tests, covered by http/tests/media/hls.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcQueryWithParent): Make the element handle SCHEDULING
queries with the BANDWIDTH_LIMITED flag. This helps uridecodebin
to configure itself for adaptive streaming playback scenarios.

1:50 AM Changeset in webkit [176560] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Add warning if CMake version is too old for building with ninja.
https://bugs.webkit.org/show_bug.cgi?id=139055

Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-11-28
Reviewed by Gyuyoung Kim.

CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
that version in their repositories.

efl/install-dependencies:

1:10 AM Changeset in webkit [176559] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

[WK2] SecComp buildfix after r176452
https://bugs.webkit.org/show_bug.cgi?id=139081

Reviewed by Antti Koivisto.

Shared/linux/SeccompFilters/SeccompBroker.cpp:

(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):

1:09 AM Changeset in webkit [176558] by Csaba Osztrogonác

3 edits in trunk/Source/WebKit2

Fix -Wc++11-narrowing error in SeccompFilters.cpp
https://bugs.webkit.org/show_bug.cgi?id=139079

Reviewed by Carlos Garcia Campos.

Shared/linux/SeccompFilters/SeccompFilters.cpp:

(WebKit::SeccompFilters::addRule):

Shared/linux/SeccompFilters/SeccompFilters.h:

1:04 AM Changeset in webkit [176557] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

[WK2] SecComp buildfix after r168605 and r168999
https://bugs.webkit.org/show_bug.cgi?id=139080

Reviewed by Carlos Garcia Campos.

Shared/linux/SeccompFilters/SyscallPolicy.cpp:

(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

1:00 AM Changeset in webkit [176556] by commit-queue@webkit.org

5 edits
2 adds in trunk

[ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
https://bugs.webkit.org/show_bug.cgi?id=139044

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-11-28
Reviewed by Chris Fleizach.

ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
The proposed solution will enable the use of this method for the object table.
Existing test shows the result.

Tools:

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::columnHeaders):

LayoutTests:

accessibility/table-column-headers-with-captions.html: Updated for ATK platform.
platform/efl/accessibility/table-column-headers-with-captions-expected.txt: Added.
platform/gtk/TestExpectations: Updated for GTK.
platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Added.

Nov 27, 2014:

11:04 PM Changeset in webkit [176555] by ryuan.choi@navercorp.com

10 edits
1 delete in trunk

[EFL] Remove E_Dbus dependency
https://bugs.webkit.org/show_bug.cgi?id=136355

Reviewed by Gyuyoung Kim.

Source/cmake/FindE_DBus.cmake: Removed.
Source/cmake/OptionsEfl.cmake:

Source/WebCore:

E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
This patch replaces E_Dbus implementation to Eldbus.

PlatformEfl.cmake:
platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::batteryProperties):
(WebCore::batteryPropertiesChanged):
(WebCore::BatteryProviderEfl::deviceTypeCallback):
(WebCore::BatteryProviderEfl::enumerateDevices):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired): Deleted.
(WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
(WebCore::BatteryProviderEfl::setBatteryClient): Deleted.

platform/efl/BatteryProviderEfl.h:

(WebCore::BatteryProviderEfl::connection):
(WebCore::BatteryProviderEfl::setSignalHandler):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.

Source/WebKit2:

UIProcess/API/efl/ewk_main.cpp: Added init/shutdown for eldbus.

(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):

Tools:

MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.

5:40 PM Changeset in webkit [176554] by Antti Koivisto

2 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
https://bugs.webkit.org/show_bug.cgi?id=139057

Reviewed by Anders Carlsson.

No test, don't know how to repro.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.

4:51 PM Changeset in webkit [176553] by gyuyoung.kim@samsung.com

11 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr instead of OwnPtr in JSC classes
https://bugs.webkit.org/show_bug.cgi?id=139009

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):

bytecode/DFGExitProfile.h:
bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::add):

bytecode/LazyOperandValueProfile.h:
heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):

heap/MarkedBlock.h:

(JSC::MarkedBlock::clearNewlyAllocated):

inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

runtime/RegExp.cpp:

(JSC::RegExp::invalidateCode):

runtime/RegExp.h:
yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):

yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):

yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

4:24 PM Changeset in webkit [176552] by jdiggs@igalia.com

9 edits in trunk

AX: [ATK] Meter and Option elements do not expose their id attribute
https://bugs.webkit.org/show_bug.cgi?id=139017

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The options in a collapsed select element lack a node, so get the id
attribute from the associated action element. In the case of a meter,
the meter element itself is not exposed; its RenderMeter is instead.
So associate the meter element's id with the exposed RenderMeter.

No new tests. Instead, updated existing expectations to reflect the fix.

accessibility/AccessibilityObject.h:
accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::element):

accessibility/AccessibilityProgressIndicator.h:
accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

LayoutTests:

accessibility/roles-exposed.html: Unskipped the meter element test.
platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.

10:00 AM Changeset in webkit [176551] by andersca@apple.com

5 edits
2 copies in trunk/Source/WebKit

Add a stubbed out WebVisitedLinkStore to WebViewGroup
https://bugs.webkit.org/show_bug.cgi?id=139066

Reviewed by Antti Koivisto.

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

WebCoreSupport/WebViewGroup.h:

(WebViewGroup::visitedLinkStore):

WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::WebViewGroup):

WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.

(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

9:58 AM Changeset in webkit [176550] by andersca@apple.com