Timeline



Jan 1, 2015:

9:26 PM Changeset in webkit [177857] by commit-queue@webkit.org
  • 41 edits
    2 deletes in trunk/Source

Remove GroupSettings
​https://bugs.webkit.org/show_bug.cgi?id=140037

Patch by Sam Weinig <​sam@webkit.org> on 2015-01-01
Reviewed by Dan Bernstein.

Source/WebCore:

Nothing sets the values in GroupSettings and nothing uses them.

  • The indexedDBDatabasePath is accessed and sent to the IndexedDB backend, but the backend then proceeds to not use it.
  • CMakeLists.txt:
  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBFactoryBackendInterface.cpp:

(WebCore::IDBFactoryBackendInterface::create):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/PageGroupIndexedDatabase.cpp:

(WebCore::PageGroupIndexedDatabase::PageGroupIndexedDatabase):
(WebCore::PageGroupIndexedDatabase::from):
(WebCore::PageGroupIndexedDatabase::factoryBackend):

  • Modules/indexeddb/PageGroupIndexedDatabase.h:
  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:

(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):

  • Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentStyleSheetCollection.cpp:
  • page/CaptionUserPreferences.cpp:
  • page/Frame.cpp:
  • page/GroupSettings.cpp: Removed.
  • page/GroupSettings.h: Removed.
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):

  • page/PageGroup.h:

(WebCore::PageGroup::groupSettings): Deleted.

  • platform/DatabaseStrategy.cpp:

(WebCore::DatabaseStrategy::createIDBFactoryBackend):

  • platform/DatabaseStrategy.h:
  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

  • workers/DedicatedWorkerThread.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::SharedWorkerProxy::groupSettings): Deleted.

  • workers/SharedWorkerGlobalScope.cpp:

(WebCore::SharedWorkerGlobalScope::create):
(WebCore::SharedWorkerGlobalScope::SharedWorkerGlobalScope):

  • workers/SharedWorkerGlobalScope.h:
  • workers/SharedWorkerThread.cpp:

(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerGlobalScope):

  • workers/SharedWorkerThread.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::groupSettings): Deleted.

  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:

Source/WebKit2:

Remove unused databaseDirectoryIdentifier parameters.

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::getDatabaseNames):
(WebKit::WebIDBFactoryBackend::deleteDatabase):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Storage/StorageNamespaceImpl.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createIDBFactoryBackend):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
8:41 PM Changeset in webkit [177856] by Yusuke Suzuki
  • 5 edits in trunk

Source/JavaScriptCore:
String includes methods perform toString on searchString before toInt32 on a offset
​https://bugs.webkit.org/show_bug.cgi?id=140031

Reviewed by Darin Adler.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncStartsWith):
(JSC::stringProtoFuncEndsWith):
(JSC::stringProtoFuncIncludes):

LayoutTests:
String includes methods perform toString on searchString before toInteger on a offset
​https://bugs.webkit.org/show_bug.cgi?id=140031

Reviewed by Darin Adler.

As per the latest ES6 draft, String.prototype.{startsWith, endsWith, includes}
perform toString on searchString (argument 0) before performing toInteger on offset (argument 1).

  • js/script-tests/string-includes.js:

(searchString.toString):
(startOffset.valueOf):
(endOffset.valueOf):
(matchString.toString): Deleted.

  • js/string-includes-expected.txt:
6:05 PM Changeset in webkit [177855] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the iOS build.

  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):

5:13 PM Changeset in webkit [177854] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/JavaScriptCore

Change to return std::unique_ptr<> in fooCreate()
​https://bugs.webkit.org/show_bug.cgi?id=139983

Reviewed by Darin Adler.

To avoid unnecessary std::unique_ptr<> casting, fooCreate() returns std::unique_ptr<> directly.

  • create_regex_tables:
  • yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):

4:57 PM Changeset in webkit [177853] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix itearator typo
​https://bugs.webkit.org/show_bug.cgi?id=140027

Reviewed by Csaba Osztrogonác.

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::nextBreakablePosition): Spelling mistake.

4:29 PM Changeset in webkit [177852] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Don't dereference end() in SimpleLineLayout::RunResolver::rangeForRenderer
​https://bugs.webkit.org/show_bug.cgi?id=139951
rdar://problem/19339881

Reviewed by Darin Adler.

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):

3:53 PM Changeset in webkit [177851] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

ASSERT that a null key is never used with FeatureCounter
​https://bugs.webkit.org/show_bug.cgi?id=140030

Reviewed by Darin Adler.

  • platform/FeatureCounter.cpp:

(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

  • platform/ios/FeatureCounter.mm:

(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

2:35 PM Changeset in webkit [177850] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[iOS] Fix memory leak in FeatureCounter
​https://bugs.webkit.org/show_bug.cgi?id=140029
<rdar://problem/19255690>

Reviewed by Darin Adler.

Fix memory leak in FeatureCounter. The NSString for the counter key
was allocated but never released. The patch switches to using a
RetainPtr instead of a raw pointer to avoid the issue.

  • platform/ios/FeatureCounter.mm:

(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):

2:21 PM Changeset in webkit [177849] by jeffm@apple.com
  • 27 edits in trunk

Update user-visible copyright strings to include 2015
​https://bugs.webkit.org/show_bug.cgi?id=139880

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:
  • Info.plist:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
  • mac/Info-WebKit2.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
1:20 PM Changeset in webkit [177848] by weinig@apple.com
  • 9 edits in trunk/Source

Move scrolling code off of WTF::bind
​https://bugs.webkit.org/show_bug.cgi?id=140019

Reviewed by Darin Adler.

Source/WebCore:

  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::tryToHandleWheelEvent):
(WebCore::ThreadedScrollingTree::invalidate):
(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):
(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
(WebCore::derefScrollingCoordinator): Deleted.

  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::invalidate):
(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):
(WebCore::derefScrollingCoordinator): Deleted.

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::pageDestroyed):
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseMemory):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

Source/WebKit2:

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::touchEvent):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

12:49 PM Changeset in webkit [177847] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Remove FontData::containsCharacters
​https://bugs.webkit.org/show_bug.cgi?id=140026

Reviewed by Dan Bernstein.

This virtual function has no clients.

  • platform/graphics/FontData.h:
  • platform/graphics/SegmentedFontData.cpp:

(WebCore::SegmentedFontData::containsCharacter): Deleted.
(WebCore::SegmentedFontData::containsCharacters): Deleted.

  • platform/graphics/SegmentedFontData.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::containsCharacters): Deleted.

  • platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::containsCharacters): Deleted.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::containsCharacters): Deleted.

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::containsCharacters): Deleted.

11:56 AM Changeset in webkit [177846] by Darin Adler
  • 22 edits in trunk

We often misspell identifier as "identifer"
​https://bugs.webkit.org/show_bug.cgi?id=140025

Reviewed by Michael Saboff.

Source/JavaScriptCore:

  • runtime/ArrayConventions.h: Fix it.

Source/WebCore:

  • html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseNPTFragment):

  • html/parser/AtomicHTMLToken.h:
  • html/parser/HTMLToken.h:
  • html/shadow/SliderThumbElement.h:
  • platform/graphics/ISOVTTCue.cpp:

(WebCore::ISOWebVTTCue::ISOWebVTTCue):

  • platform/graphics/ISOVTTCue.h:

(WebCore::ISOWebVTTCue::id):
Fix mispellings.

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector._updateNavigationSidebarForCurrentContentView):
(WebInspector._contentBrowserCurrentContentViewDidChange):
Fix misspellings.

Source/WebKit2:

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h:
  • UIProcess/WebPageGroup.cpp:

(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):

  • UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::identifier):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::createInspectorPage):

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::WebPageGroupProxy):

  • WebProcess/WebPage/WebPageGroupProxy.h:

(WebKit::WebPageGroupProxy::identifier):
Fix misspellings.

Tools:

  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
  • Scripts/webkitdirs.pm:

(appIdentifierFromBundle):
(installAndLaunchIOSWebKitAppInSimulator):
Fix misspellings

5:59 AM WebKitGTK/StartHacking edited by Michael Catanzaro
fixup (diff)
5:58 AM WebKitGTK/StartHacking edited by Michael Catanzaro
Don't recommend old unsupported distro releases (diff)
5:54 AM WebKitGTK/StartHacking edited by Michael Catanzaro
fix path to MiniBrowser (diff)
5:48 AM WebKitGTK/TrackingMemoryErrors edited by Michael Catanzaro
fix path to MiniBrowser (diff)
12:32 AM Changeset in webkit [177845] by Alan Bujtas
  • 4 edits in trunk

Saturated arithmetics: Incorrect float/double clamping.
​https://bugs.webkit.org/show_bug.cgi?id=139888
rdar://problem/19330885

Reviewed by Simon Fraser.

Clamp float and double values correctly when applying saturated arithmetics.

Source/WebCore:

Test: LayoutUnit test for float overflow.

  • platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):

Tools:

  • TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:

(TestWebKitAPI::TEST):

12:06 AM Changeset in webkit [177844] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/send-on-abort.html is flaky in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=140020

Reviewed by Darin Adler.

  1. XHR loads are aborted when a page load starts, not when it's committed (which

is a known bug in WebKit). This gave the failure timer an opportunity to fire between
these events. Fixed by extending the delay.

  1. Starting the test while parsing had a potential for a race with loading - we

could run it before all data was loaded. While this probably didn't happen in
practice here, it's better to run navigation tests under 100% reproducible conditions,
like during onload.

  • http/tests/xmlhttprequest/send-on-abort.html:
12:05 AM Changeset in webkit [177843] by ap@apple.com
  • 12 edits in trunk/LayoutTests

http/tests/notifications/legacy/show.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=140023

http/tests/notifications/window-show-on-click.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112499

Reviewed by Darin Adler.

Remove 100 ms timeouts from notification tests. If they become broken, it will
be detected as timeout.

  • http/tests/notifications/events-in-dictionary.html:
  • http/tests/notifications/events.html:
  • http/tests/notifications/legacy/double-show.html:
  • http/tests/notifications/legacy/events.html:
  • http/tests/notifications/legacy/request-no-callback.html:
  • http/tests/notifications/legacy/request.html:
  • http/tests/notifications/legacy/show.html:
  • http/tests/notifications/legacy/window-show-on-click.html:
  • http/tests/notifications/request.html:
  • http/tests/notifications/window-show-on-click.html:
  • platform/mac/TestExpectations: window-show-on-click.html should pass now.
12:04 AM Changeset in webkit [177842] by ap@apple.com
  • 3 edits in trunk/LayoutTests

fast/ruby/ruby-svg-crash.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=135610

Reviewed by Darin Adler.

  • fast/ruby/ruby-svg-crash.html: Streamline the test to avoid timer races. I

verified that it still crashes without the original fix (it gets an
ASSERT_WITH_SECURITY_IMPILICATIONS).

  • platform/mac/TestExpectations: Removed the expectation.

Dec 31, 2014:

5:25 PM Changeset in webkit [177841] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the iOS build.

  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::commitTreeState):

5:03 PM Changeset in webkit [177840] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

URTBF after r177835.

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
3:30 PM Changeset in webkit [177839] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r176476.
​https://bugs.webkit.org/show_bug.cgi?id=140021

Sadly, this didn't reduce media test crashiness (Requested by
ap on #webkit).

Reverted changeset:

"[Mac] Random crashes inside media libraries when creating
then destroying media quickly."
​https://bugs.webkit.org/show_bug.cgi?id=138980
​http://trac.webkit.org/changeset/176476

1:34 PM Changeset in webkit [177838] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebKit2

[GTK] Suppress unused parameter warnings in ui clients
​https://bugs.webkit.org/show_bug.cgi?id=140012

Drop the parameter name of WebKitUIClient::isPlayingAudioDidChange
to suppress warnings.

Reviewed by Benjamin Poulain.

  • UIProcess/API/gtk/WebKitUIClient.cpp:
1:21 PM Changeset in webkit [177837] by ap@apple.com
  • 3 edits in trunk/LayoutTests

execDeleteCommand() does not update spellchecker sometimes
​https://bugs.webkit.org/show_bug.cgi?id=139862

Updated test expectation for a test that always crashes on WK1 (it was already
skipped on mac-wk2, efl and gtk).

1:16 PM Changeset in webkit [177836] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Test expectation gardening.

Add expectations for test that became flaky after enabling kerning and ligatures,
plus a few more that were mis-characterized.

  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
12:01 PM Changeset in webkit [177835] by weinig@apple.com
  • 23 edits in trunk/Source

Remove the remaining uses of OwnPtr from WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=140017

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit):
(WebCore::ScrollingStateTree::create): Deleted.

  • page/scrolling/ScrollingStateTree.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::commitNewTreeState):

  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::commitNewTreeState):

  • page/scrolling/ios/ScrollingTreeIOS.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::commitTreeState):

Source/WebKit2:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingCoordinatorTransaction::decode):

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:

(WebKit::RemoteScrollingCoordinatorTransaction::setStateTreeToEncode):
(WebKit::RemoteScrollingCoordinatorTransaction::scrollingStateTree):

  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::updateScrollingTree):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(-[WKPrintingView _askPageToComputePageRects]):
(-[WKPrintingView _drawPreview:]):

  • WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
11:03 AM Changeset in webkit [177834] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Don’t use AccessibilityAllInOne when building with Xcode
​https://bugs.webkit.org/show_bug.cgi?id=139974

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added all files included by AccessibilityAllInOne.cpp

to the WebCore target, and removed AccessibilityAllInOne.cpp from the project.

9:16 AM Changeset in webkit [177833] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix build warnings after r177792.
​https://bugs.webkit.org/show_bug.cgi?id=140005.

Patch by Bartlomiej Gajda <​b.gajda@samsung.com> on 2014-12-31
Reviewed by Anders Carlsson.

Add UNUSED_PARAM(connection) for async messages.

  • Scripts/webkit/messages.py:

(generate_message_handler):

3:33 AM Changeset in webkit [177832] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK port.

Move the ArgumentCodersGtk.h inclusion from WebPageProxy.cpp to
WebPageProxy.h. This makes GTK-specific IPC coders available to
WebPageProxyMessageReceiver, fixing a build error due to missing
ArgumentCoder template specializations for WebCore::DragData type
that is used in the GTK-specific StartDrag message.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
12:44 AM Changeset in webkit [177831] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r177824 and r177826.
​https://bugs.webkit.org/show_bug.cgi?id=140011

The new test crashes (Requested by ap on #webkit).

Reverted changesets:

"Too large plugins are crashing."
​https://bugs.webkit.org/show_bug.cgi?id=139856
​http://trac.webkit.org/changeset/177824

"Fix bug number typo in the previous commit."
​http://trac.webkit.org/changeset/177826

12:36 AM Changeset in webkit [177830] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update storage tracker test expectations after r177814.

  • platform/mac/TestExpectations:
12:26 AM Changeset in webkit [177829] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening, mark more timeouting tests.

  • platform/win/TestExpectations:

Dec 30, 2014:

4:53 PM Changeset in webkit [177828] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Move font-related CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=140008

Reviewed by Darin Adler.

Move font-related CSS properties to the new StyleBuilder
by teaching makeprop.pl how to generate them.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFont::applyInheritValue): Deleted.
(WebCore::ApplyPropertyFont::applyInitialValue): Deleted.
(WebCore::ApplyPropertyFont::applyValue): Deleted.
(WebCore::ApplyPropertyFont::createHandler): Deleted.

  • css/makeprop.pl:

(generateInitialValueSetter):
(generateInheritValueSetter):
(generateValueSetter):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::initialItalic):
(WebCore::FontDescription::initialSmallCaps):
(WebCore::FontDescription::initialKerning):
(WebCore::FontDescription::initialFontSmoothing):
(WebCore::FontDescription::initialTextRenderingMode):

2:25 PM Changeset in webkit [177827] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=140007

Reviewed by Darin Adler.

Move '-webkit-font-variant-ligature' CSS property to the new StyleBuilder
by using custom code.

  • css/CSSPropertyNames.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::applyValue): Deleted.
(WebCore::ApplyPropertyFontVariantLigatures::createHandler): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialWebkitFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyInheritWebkitFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyValueWebkitFontVariantLigatures):

2:09 PM Changeset in webkit [177826] by rgabor@webkit.org
  • 4 edits in trunk

Source/WebKit2:
Too large plugins are crashing.
​https://bugs.webkit.org/show_bug.cgi?id=139868

Reviewed by Darin Adler.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated.

LayoutTests:
Fix bug number typo in the previous commit.

  • plugins/large-plugin-crash-expected.txt:
  • plugins/large-plugin-crash.html:
12:43 PM Changeset in webkit [177825] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

[Cocoa] Enable the compiler to check format strings specified with UI_STRING and UI_STRING_KEY
​https://bugs.webkit.org/show_bug.cgi?id=140003

Reviewed by Darin Adler.

  • Misc/WebLocalizableStrings.h: Made UI_STRING and UI_STRING_KEY call a new helper function

that takes their "string" parameter as a "value" "parameter and has an attribute telling
the compiler that if the "value" parameter is a format string then the function returns a
modified version of it. The result is that if UI_STRING is used as a format string parameter
to some function or method, the compiler will check the format specifiers in the string
against the other parameters.

10:40 AM Changeset in webkit [177824] by rgabor@webkit.org
  • 3 edits
    2 adds in trunk

Too large plugins are crashing.
​https://bugs.webkit.org/show_bug.cgi?id=139856

Reviewed by Darin Adler.

Source/WebKit2:

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::updateBackingStore): Return false if backingStore cannot be allocated.

LayoutTests:

Add layout test to cover this crash.

  • plugins/large-plugin-crash-expected.txt: Added.
  • plugins/large-plugin-crash.html: Added.
9:41 AM Changeset in webkit [177823] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Transient local storage namespaces need to ref their storage areas
​https://bugs.webkit.org/show_bug.cgi?id=140006
<rdar://problem/19225389>

Reviewed by Sam Weinig.

We need to keep transient storage areas around even if they have no active connections,
so use a RefPtr instead of a raw pointer. This matches what we do for session storage namespaces.

  • UIProcess/Storage/StorageManager.cpp:
4:29 AM Changeset in webkit [177822] by k.czech@samsung.com
  • 2 edits in trunk/Tools

[EFL] Bump version of ATK used by jhbuild to 2.15.2
​https://bugs.webkit.org/show_bug.cgi?id=139816

Reviewed by Gyuyoung Kim.

Bump version of ATK used by jhbuild to 2.15.2

  • efl/jhbuild.modules:

Dec 29, 2014:

8:39 PM Changeset in webkit [177821] by Chris Dumez
  • 11 edits in trunk/Source/WebCore

Move animation / transition CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139999

Reviewed by Darin Adler.

Move animation / transition CSS properties to the new StyleBuilder by
teaching makeprop.pl how to generate them.

6:59 PM Changeset in webkit [177820] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/JavaScriptCore

Move JavaScriptCore/yarr to std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=139621

Reviewed by Anders Carlsson.

Final clean up OwnPtr|PassOwnPtr in JavaScriptCore/yarr.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileBody):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::reset):
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
(JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::YarrPatternConstructor::atomParentheticalAssertionBegin):
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):

  • yarr/YarrPattern.h:

(JSC::Yarr::PatternDisjunction::addNewAlternative):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):

1:54 PM Changeset in webkit [177819] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another attempt at fixing the build.

  • WebKitDLL.cpp:

(shutDownWebKit):

1:50 PM Changeset in webkit [177818] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Try to fix the Windows build.

  • WebKitDLL.cpp:

(shutDownWebKit):

1:48 PM Changeset in webkit [177817] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fixed the iOS build.

  • Configurations/WebKitLegacy.xcconfig:
1:43 PM Changeset in webkit [177816] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove more dead code
​https://bugs.webkit.org/show_bug.cgi?id=139998

Reviewed by Oliver Hunt.

  • page/PageGroup.cpp:

(WebCore::PageGroup::localStorage): Deleted.
(WebCore::PageGroup::transientLocalStorage): Deleted.

  • page/PageGroup.h:

(WebCore::PageGroup::hasLocalStorage): Deleted.

1:32 PM Changeset in webkit [177815] by andersca@apple.com
  • 9 edits in trunk/Source

Remove unneeded StorageNamespace functions
​https://bugs.webkit.org/show_bug.cgi?id=139997

Reviewed by Sam Weinig.

Source/WebCore:

  • loader/EmptyClients.cpp:
  • storage/StorageNamespace.h:

(WebCore::StorageNamespace::closeIdleLocalStorageDatabases): Deleted.

Source/WebKit:

We can just cast to StorageNamespaceImpl directly, no need for virtual dispatch.

  • Storage/StorageNamespaceImpl.h:
  • Storage/WebStorageNamespaceProvider.cpp:

(WebStorageNamespaceProvider::closeLocalStorage):
(WebStorageNamespaceProvider::clearLocalStorageForAllOrigins):
(WebStorageNamespaceProvider::clearLocalStorageForOrigin):
(WebStorageNamespaceProvider::closeIdleLocalStorageDatabases):
(WebStorageNamespaceProvider::syncLocalStorage):

Source/WebKit2:

  • WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::close): Deleted.
(WebKit::StorageNamespaceImpl::clearOriginForDeletion): Deleted.
(WebKit::StorageNamespaceImpl::clearAllOriginsForDeletion): Deleted.
(WebKit::StorageNamespaceImpl::sync): Deleted.
(WebKit::StorageNamespaceImpl::closeIdleLocalStorageDatabases): Deleted.

  • WebProcess/Storage/StorageNamespaceImpl.h:
1:26 PM Changeset in webkit [177814] by andersca@apple.com
  • 9 edits in trunk/Source

Get rid of some PageGroup storage functions
​https://bugs.webkit.org/show_bug.cgi?id=139996

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • page/PageGroup.cpp:

(WebCore::PageGroup::closeLocalStorage): Deleted.
(WebCore::PageGroup::clearLocalStorageForAllOrigins): Deleted.
(WebCore::PageGroup::clearLocalStorageForOrigin): Deleted.
(WebCore::PageGroup::closeIdleLocalStorageDatabases): Deleted.
(WebCore::PageGroup::syncLocalStorage): Deleted.

  • page/PageGroup.h:

Source/WebKit:

Call WebStorageNamespaceProvider directly instead.

  • Storage/StorageTracker.cpp:

(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):

Source/WebKit/mac:

Call WebStorageNamespaceProvider directly instead.

  • Storage/WebStorageManager.mm:

(-[WebStorageManager syncLocalStorage]):
(+[WebStorageManager closeIdleLocalStorageDatabases]):

  • WebView/WebView.mm:

(+[WebView _applicationWillTerminate]):

1:12 PM Changeset in webkit [177813] by andersca@apple.com
  • 19 edits
    13 moves in trunk/Source

Move storage code from WebCore to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=139558

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/MemoryPressureHandler.cpp:

Source/WebKit:

  • Storage/StorageAreaImpl.cpp: Renamed from Source/WebCore/storage/StorageAreaImpl.cpp.

(WebCore::StorageAreaImpl::~StorageAreaImpl):
(WebCore::StorageAreaImpl::StorageAreaImpl):
(WebCore::StorageAreaImpl::create):
(WebCore::StorageAreaImpl::copy):
(WebCore::StorageAreaImpl::canAccessStorage):
(WebCore::StorageAreaImpl::storageType):
(WebCore::StorageAreaImpl::length):
(WebCore::StorageAreaImpl::key):
(WebCore::StorageAreaImpl::item):
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
(WebCore::StorageAreaImpl::contains):
(WebCore::StorageAreaImpl::importItems):
(WebCore::StorageAreaImpl::close):
(WebCore::StorageAreaImpl::clearForOriginDeletion):
(WebCore::StorageAreaImpl::sync):
(WebCore::StorageAreaImpl::blockUntilImportComplete):
(WebCore::StorageAreaImpl::memoryBytesUsedByCache):
(WebCore::StorageAreaImpl::incrementAccessCount):
(WebCore::StorageAreaImpl::decrementAccessCount):
(WebCore::StorageAreaImpl::closeDatabaseTimerFired):
(WebCore::StorageAreaImpl::closeDatabaseIfIdle):
(WebCore::StorageAreaImpl::dispatchStorageEvent):

  • Storage/StorageAreaImpl.h: Renamed from Source/WebCore/storage/StorageAreaImpl.h.
  • Storage/StorageAreaSync.cpp: Renamed from Source/WebCore/storage/StorageAreaSync.cpp.

(WebCore::StorageAreaSync::StorageAreaSync):
(WebCore::StorageAreaSync::create):
(WebCore::StorageAreaSync::~StorageAreaSync):
(WebCore::StorageAreaSync::scheduleFinalSync):
(WebCore::StorageAreaSync::scheduleItemForSync):
(WebCore::StorageAreaSync::scheduleClear):
(WebCore::StorageAreaSync::scheduleCloseDatabase):
(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::openDatabase):
(WebCore::StorageAreaSync::migrateItemTableIfNeeded):
(WebCore::StorageAreaSync::performImport):
(WebCore::StorageAreaSync::markImported):
(WebCore::StorageAreaSync::blockUntilImportComplete):
(WebCore::StorageAreaSync::sync):
(WebCore::StorageAreaSync::performSync):
(WebCore::StorageAreaSync::deleteEmptyDatabase):
(WebCore::StorageAreaSync::scheduleSync):

  • Storage/StorageAreaSync.h: Renamed from Source/WebCore/storage/StorageAreaSync.h.
  • Storage/StorageNamespaceImpl.cpp: Renamed from Source/WebCore/storage/StorageNamespaceImpl.cpp.

(WebCore::localStorageNamespaceMap):
(WebCore::StorageNamespaceImpl::createSessionStorageNamespace):
(WebCore::StorageNamespaceImpl::getOrCreateLocalStorageNamespace):
(WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
(WebCore::StorageNamespaceImpl::~StorageNamespaceImpl):
(WebCore::StorageNamespaceImpl::copy):
(WebCore::StorageNamespaceImpl::storageArea):
(WebCore::StorageNamespaceImpl::close):
(WebCore::StorageNamespaceImpl::clearOriginForDeletion):
(WebCore::StorageNamespaceImpl::clearAllOriginsForDeletion):
(WebCore::StorageNamespaceImpl::sync):
(WebCore::StorageNamespaceImpl::closeIdleLocalStorageDatabases):

  • Storage/StorageNamespaceImpl.h: Renamed from Source/WebCore/storage/StorageNamespaceImpl.h.
  • Storage/StorageSyncManager.cpp: Renamed from Source/WebCore/storage/StorageSyncManager.cpp.

(WebCore::StorageSyncManager::create):
(WebCore::StorageSyncManager::StorageSyncManager):
(WebCore::StorageSyncManager::~StorageSyncManager):
(WebCore::StorageSyncManager::fullDatabaseFilename):
(WebCore::StorageSyncManager::dispatch):
(WebCore::StorageSyncManager::close):

  • Storage/StorageSyncManager.h: Renamed from Source/WebCore/storage/StorageSyncManager.h.
  • Storage/StorageThread.cpp: Renamed from Source/WebCore/storage/StorageThread.cpp.

(WebCore::activeStorageThreads):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::threadEntryPointCallback):
(WebCore::StorageThread::threadEntryPoint):
(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::performTerminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):

  • Storage/StorageThread.h: Renamed from Source/WebCore/storage/StorageThread.h.
  • Storage/StorageTracker.cpp: Renamed from Source/WebCore/storage/StorageTracker.cpp.

(WebCore::StorageTracker::initializeTracker):
(WebCore::StorageTracker::internalInitialize):
(WebCore::StorageTracker::tracker):
(WebCore::StorageTracker::StorageTracker):
(WebCore::StorageTracker::setDatabaseDirectoryPath):
(WebCore::StorageTracker::databaseDirectoryPath):
(WebCore::StorageTracker::trackerDatabasePath):
(WebCore::ensureDatabaseFileExists):
(WebCore::StorageTracker::openTrackerDatabase):
(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::truncateDatabaseFile):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOriginWithIdentifier):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::willDeleteAllOrigins):
(WebCore::StorageTracker::willDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::isActive):
(WebCore::StorageTracker::setIsActive):
(WebCore::StorageTracker::databasePathForOrigin):
(WebCore::StorageTracker::diskUsageForOrigin):

  • Storage/StorageTracker.h: Renamed from Source/WebCore/storage/StorageTracker.h.

(WebCore::StorageTracker::storageDatabaseIdleInterval):
(WebCore::StorageTracker::setStorageDatabaseIdleInterval):

  • Storage/StorageTrackerClient.h: Renamed from Source/WebCore/storage/StorageTrackerClient.h.

(WebCore::StorageTrackerClient::~StorageTrackerClient):

  • Storage/WebStorageNamespaceProvider.cpp:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Storage/WebStorageManager.mm:
  • Storage/WebStorageTrackerClient.h:
  • WebView/WebView.mm:

Source/WebKit2:

  • WebProcess/WebProcess.cpp:
12:16 PM Changeset in webkit [177812] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed the iOS build.

  • WebProcess/WebPage/ios/WebPageIOS.mm:
12:07 PM Changeset in webkit [177811] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Another iOS build fix.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::elementDidFocus):

11:54 AM Changeset in webkit [177810] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Turn on transient local storage support again
​https://bugs.webkit.org/show_bug.cgi?id=139995

Reviewed by Sam Weinig.

Using transient local storage caused weird crashes in the UI process so that change had to
be backed out - let's turn it on and see if it still happens.

  • WebProcess/Storage/WebStorageNamespaceProvider.cpp:

(WebKit::WebStorageNamespaceProvider::createTransientLocalStorageNamespace):

11:46 AM Changeset in webkit [177809] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove more old coder code gunk.

Rubber-stamped by Sam Weinig.

  • Scripts/webkit/messages.py:

(argument_coder_headers_for_type):
(handler_function): Deleted.

11:44 AM Changeset in webkit [177808] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix the iOS build.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::startAssistingNode):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::elementDidFocus):

11:42 AM Changeset in webkit [177807] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r177805.

  • CMakeLists.txt:
11:38 AM Changeset in webkit [177806] by andersca@apple.com
  • 15 edits
    5 deletes in trunk/Source/WebKit2

Remove the old user message coder code
​https://bugs.webkit.org/show_bug.cgi?id=139994

Reviewed by Sam Weinig.

  • Platform/IPC/HandleMessage.h:

(IPC::callMemberFunctionImpl): Deleted.
(IPC::callMemberFunction): Deleted.
(IPC::handleMessageVariadic): Deleted.

  • Scripts/webkit/messages.py:

(decode_type):
(async_message_statement):
(sync_message_statement):

  • Shared/UserMessageCoders.h: Removed.
  • Shared/mac/ObjCObjectGraphCoders.h: Removed.
  • Shared/mac/ObjCObjectGraphCoders.mm: Removed.
  • UIProcess/WebConnectionToWebProcess.cpp:
  • UIProcess/WebContextUserMessageCoders.h: Removed.
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebProcessPool.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h: Removed.
  • WebProcess/WebConnectionToUIProcess.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/WebContextMenu.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/WebProcess.cpp:
11:35 AM Changeset in webkit [177805] by weinig@apple.com
  • 2 edits
    3 moves in trunk/Source/WebKit2

Move WebPasteboardProxy from Shared to UIProcess, where it should have been all along
Rubber-stamped by Anders Carlsson.

  • Shared/WebPasteboardProxy.cpp: Removed.
  • Shared/WebPasteboardProxy.h: Removed.
  • Shared/WebPasteboardProxy.messages.in: Removed.
  • UIProcess/WebPasteboardProxy.cpp: Copied from Shared/WebPasteboardProxy.cpp.
  • UIProcess/WebPasteboardProxy.h: Copied from Shared/WebPasteboardProxy.h.
  • UIProcess/WebPasteboardProxy.messages.in: Copied from Shared/WebPasteboardProxy.messages.in.
  • WebKit2.xcodeproj/project.pbxproj:
11:29 AM Changeset in webkit [177804] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the iOS build.

  • Shared/WebPasteboardProxy.h:
11:27 AM Changeset in webkit [177803] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Convert injected bundle message posting to UserData
​https://bugs.webkit.org/show_bug.cgi?id=139993

Reviewed by Sam Weinig.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::postMessageToInjectedBundle):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::handleInjectedBundleMessage):
(WebKit::WebProcess::postInjectedBundleMessage): Deleted.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
11:25 AM Changeset in webkit [177802] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the iOS build.

  • Shared/WebPasteboardProxy.h:
11:21 AM Changeset in webkit [177801] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more speculative buildfix after r177794.

  • CMakeLists.txt:
11:20 AM Changeset in webkit [177800] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the iOS build.

  • Shared/WebPasteboardProxy.h:
11:15 AM Changeset in webkit [177799] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Speculative buildfix after r177793.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

11:14 AM Changeset in webkit [177798] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Speculative buildfix after r177794.

  • CMakeLists.txt:
11:08 AM Changeset in webkit [177797] by weinig@apple.com
  • 8 edits in trunk/Source/WebKit2

Removes some unnecessary use of LegacyReceiver
​https://bugs.webkit.org/show_bug.cgi?id=139992

Reviewed by Anders Carlsson.

  • Shared/WebConnection.cpp:

(WebKit::WebConnection::didReceiveMessage): Deleted.

  • Shared/WebConnection.h:
  • Shared/WebConnection.messages.in:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::didReceiveMessage): Deleted.
(WebKit::WebProcessPool::didReceiveSyncMessage): Deleted.

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessPool.messages.in:

Remove unnecessary use of LegacyReceiver.

  • UIProcess/WebPageProxy.h:

Remove declarations for functions that don't exist.

11:02 AM Changeset in webkit [177796] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Convert all variadic web process messages to UserData
​https://bugs.webkit.org/show_bug.cgi?id=139991

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::loadString):
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadAlternateHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::loadWebArchiveData):
(WebKit::WebPage::postInjectedBundleMessage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
10:38 AM Changeset in webkit [177795] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Convert all variadic WebProcessProxy message over to UserData
​https://bugs.webkit.org/show_bug.cgi?id=139990

Reviewed by Sam Weinig.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didLayout):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::didDetectXSSForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::decidePolicyForResponseSync):
(WebKit::WebPageProxy::unableToImplementPolicy):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::mouseDidMoveOverElement):
(WebKit::WebPageProxy::didBeginTrackingPotentialLongMousePress):
(WebKit::WebPageProxy::didRecognizeLongMousePress):
(WebKit::WebPageProxy::didCancelTrackingPotentialLongMousePress):
(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu):
(WebKit::WebPageProxy::didPerformActionMenuHitTest):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showSelectionServiceMenu):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mouseDidMoveOverElement):
(WebKit::WebChromeClient::didBeginTrackingPotentialLongMousePress):
(WebKit::WebChromeClient::didRecognizeLongMousePress):
(WebKit::WebChromeClient::didCancelTrackingPotentialLongMousePress):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::didDetectXSS):

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):

10:23 AM Changeset in webkit [177794] by weinig@apple.com
  • 9 edits
    4 adds in trunk/Source/WebKit2

Move Pasteboard code out of WebProcessPool and into its own singleton class
​https://bugs.webkit.org/show_bug.cgi?id=139987

Reviewed by Anders Carlsson.

  • DerivedSources.make:
  • Shared/WebPasteboardProxy.cpp: Added.

(WebKit::WebPasteboardProxy::shared):
(WebKit::WebPasteboardProxy::WebPasteboardProxy):
(WebKit::WebPasteboardProxy::addWebProcessProxy):

  • Shared/WebPasteboardProxy.h: Added.
  • Shared/WebPasteboardProxy.messages.in: Added.
  • UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: Added.
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::didReceiveSyncMessage):
(WebKit::WebProcessPool::dummy): Deleted.

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessPool.messages.in:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::writeItemsToPasteboard):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
10:11 AM Changeset in webkit [177793] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Use UserData for bundle initialization data
​https://bugs.webkit.org/show_bug.cgi?id=139989

Reviewed by Sam Weinig.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::~WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

9:46 AM Changeset in webkit [177792] by andersca@apple.com
  • 7 edits
    1 delete in trunk/Source/WebKit2

Use UserData when sending messages to the process pool
​https://bugs.webkit.org/show_bug.cgi?id=139978

Reviewed by Sam Weinig.

  • Scripts/webkit/messages.py:

(generate_message_handler):
Include the connection parameter for legacy receivers as well.

  • Shared/CoreIPCSupport/WebContextMessageKinds.h:

Remove this, it's no longer needed.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::didReceiveMessage):
No need to special case the postMessage message.

(WebKit::WebProcessPool::didReceiveSyncMessage):
No need to special case the postSynchronousMessageMessage message.

(WebKit::WebProcessPool::handleMessage):
Convert handles to objects and call didReceiveMessageFromInjectedBundle.

(WebKit::WebProcessPool::handleSynchronousMessage):
Convert handles to objects, call didReceiveSynchronousMessageFromInjectedBundle, and then
convert objects back to handles in the reply.

(WebKit::WebProcessPool::didReceiveMessageFromInjectedBundle): Deleted.
(WebKit::WebProcessPool::didReceiveSynchronousMessageFromInjectedBundle): Deleted.
(WebKit::WebProcessPool::dummy): Deleted.

  • UIProcess/WebProcessPool.h:

Add handleMessage and handleSynchronousMessage message handlers.

  • UIProcess/WebProcessPool.messages.in:

Add new messages.

  • WebKit2.xcodeproj/project.pbxproj:

Remove a now unused file.

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
Convert objects to handles in the message body and then send the HandleMessage to the UI process.

(WebKit::InjectedBundle::postSynchronousMessage):
Convert objects to handles in the message body, send the HandleSynchronousMessage message to the UI process,
and then convert handles back to objects in the reply.

7:31 AM Changeset in webkit [177791] by jonowells@apple.com
  • 11 edits in trunk/Source/WebInspectorUI

Web Inspector: SourceCode.requestContent should return a promise
​https://bugs.webkit.org/show_bug.cgi?id=135777

Reviewed by Brian Burg.

Change SourceCode.js to request content from the backend using Promises. Change Resource.js to use this new
approach when determining whether a resource load has finished. Change all calls to the older
SourceCode#requestContentFromBackendIfNeeded to simply use requestContent and use a catch function
if a content request error needs to be handled. Fix a bug where the appropriate error message for an
invalid resource wasn't showing in the resource content view.

  • UserInterface/Controllers/AnalyzerManager.js:

(set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode.):
(set WebInspector.AnalyzerManager.prototype.getAnalyzerMessagesForSourceCode):

  • UserInterface/Controllers/CSSStyleManager.js:

(WebInspector.CSSStyleManager.prototype._updateResourceContent.fetchedStyleSheetContent):
(WebInspector.CSSStyleManager.prototype._updateResourceContent.styleSheetReady):

  • UserInterface/Models/CSSStyleSheet.js:

(WebInspector.CSSStyleSheet.prototype.requestContentFromBackend):
(WebInspector.CSSStyleSheet.prototype.canRequestContentFromBackend): Deleted.

  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.changeStyleText):

  • UserInterface/Models/Resource.js:

(WebInspector.Resource.prototype.canRequestContent):
(WebInspector.Resource.prototype.requestContentFromBackend):
(WebInspector.Resource.prototype.markAsFinished):
(WebInspector.Resource.prototype.markAsFailed):
(WebInspector.Resource.prototype.getImageSize):
(WebInspector.Resource.prototype.canRequestContentFromBackend): Deleted.

  • UserInterface/Models/Script.js:

(WebInspector.Script.prototype.requestContentFromBackend):
(WebInspector.Script.prototype.requestScriptSyntaxTree.catch):
(WebInspector.Script.prototype.canRequestContentFromBackend): Deleted.

  • UserInterface/Models/SourceCode.js:

(WebInspector.SourceCode):
(WebInspector.SourceCode.prototype.requestContent):
(WebInspector.SourceCode.prototype.requestContentFromBackend):
(WebInspector.SourceCode.prototype._processContent):
(WebInspector.SourceCode.prototype.canRequestContentFromBackend): Deleted.
(WebInspector.SourceCode.prototype.requestContentFromBackendIfNeeded): Deleted.
(WebInspector.SourceCode.prototype.servicePendingContentRequests): Deleted.

  • UserInterface/Models/SourceMapResource.js:

(WebInspector.SourceMapResource):
(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
(WebInspector.SourceMapResource.prototype.requestContentFromBackend):
(WebInspector.SourceMapResource.prototype.canRequestContentFromBackend): Deleted.
(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded): Deleted.

  • UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView):
(WebInspector.ResourceContentView.prototype._contentAvailable):
(WebInspector.ResourceContentView.prototype._contentError):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype._contentAvailable):
(WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent.scriptContentAvailable):
(WebInspector.SourceCodeTextEditor.prototype._populateWithInlineScriptContent):
(WebInspector.SourceCodeTextEditor.prototype._populateWithScriptContent):

6:46 AM Changeset in webkit [177790] by commit-queue@webkit.org
  • 11 edits in trunk

Source/WebCore:
[GStreamer] Rewrite MediaSource implementation
​https://bugs.webkit.org/show_bug.cgi?id=139441

Patch by Sebastian Dröge <​sebastian@centricular.com> on 2014-12-29
Reviewed by Philippe Normand.

This now is a clean reimplementation around appsrc that works good
enough for YouTube (except for seeking), but it still does not
implement the complete API correctly. Further work is required on
top of this and the Bugzilla ticket linked above contains some
further work in the right direction.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
(WebCore::MediaPlayerPrivateGStreamer::canSaveMediaData):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(WebCore::MediaPlayerPrivateGStreamer::totalVideoFrames):
(WebCore::MediaPlayerPrivateGStreamer::droppedVideoFrames):
(WebCore::MediaPlayerPrivateGStreamer::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateGStreamer::totalFrameDelay):
(WebCore::MediaPlayerPrivateGStreamer::isMediaSource):

  • platform/graphics/gstreamer/MediaSourceGStreamer.cpp:

(WebCore::MediaSourceGStreamer::MediaSourceGStreamer):
(WebCore::MediaSourceGStreamer::addSourceBuffer):
(WebCore::MediaSourceGStreamer::durationChanged):
(WebCore::MediaSourceGStreamer::markEndOfStream):
(WebCore::MediaSourceGStreamer::unmarkEndOfStream):
(WebCore::MediaSourceGStreamer::readyState):
(WebCore::MediaSourceGStreamer::setReadyState):
(WebCore::MediaSourceGStreamer::waitForSeekCompleted):
(WebCore::MediaSourceGStreamer::seekCompleted):

  • platform/graphics/gstreamer/MediaSourceGStreamer.h:
  • platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
(WebCore::SourceBufferPrivateGStreamer::~SourceBufferPrivateGStreamer):
(WebCore::SourceBufferPrivateGStreamer::setClient):
(WebCore::SourceBufferPrivateGStreamer::append):
(WebCore::SourceBufferPrivateGStreamer::removedFromMediaSource):
(WebCore::SourceBufferPrivateGStreamer::readyState):
(WebCore::SourceBufferPrivateGStreamer::setReadyState):
(WebCore::SourceBufferPrivateGStreamer::flushAndEnqueueNonDisplayingSamples):
(WebCore::SourceBufferPrivateGStreamer::enqueueSample):
(WebCore::SourceBufferPrivateGStreamer::isReadyForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::setActive):
(WebCore::SourceBufferPrivateGStreamer::stopAskingForMoreSamples):
(WebCore::SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples):

  • platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h:
  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webkit_media_src_class_init):
(webkit_media_src_init):
(webKitMediaSrcFinalize):
(webKitMediaSrcSetProperty):
(webKitMediaSrcGetProperty):
(webKitMediaSrcDoAsyncStart):
(webKitMediaSrcDoAsyncDone):
(webKitMediaSrcChangeState):
(webKitMediaSrcQueryWithParent):
(webKitMediaSrcGetUri):
(webKitMediaSrcSetUri):
(WebCore::MediaSourceClientGStreamer::MediaSourceClientGStreamer):
(WebCore::MediaSourceClientGStreamer::~MediaSourceClientGStreamer):
(WebCore::MediaSourceClientGStreamer::addSourceBuffer):
(WebCore::MediaSourceClientGStreamer::durationChanged):
(WebCore::MediaSourceClientGStreamer::append):
(WebCore::MediaSourceClientGStreamer::markEndOfStream):
(WebCore::MediaSourceClientGStreamer::removedFromMediaSource):
(WTF::adoptGRef):
(WTF::refGPtr<WebKitMediaSrc>):
(WTF::derefGPtr<WebKitMediaSrc>):
(webKitMediaSrcAddSrc): Deleted.
(webKitMediaVideoSrcStop): Deleted.
(webKitMediaAudioSrcStop): Deleted.
(webKitMediaVideoSrcStart): Deleted.
(webKitMediaAudioSrcStart): Deleted.
(webKitMediaVideoSrcNeedDataMainCb): Deleted.
(webKitMediaAudioSrcNeedDataMainCb): Deleted.
(webKitMediaVideoSrcNeedDataCb): Deleted.
(webKitMediaAudioSrcNeedDataCb): Deleted.
(webKitMediaVideoSrcEnoughDataMainCb): Deleted.
(webKitMediaAudioSrcEnoughDataMainCb): Deleted.
(webKitMediaVideoSrcEnoughDataCb): Deleted.
(webKitMediaAudioSrcEnoughDataCb): Deleted.
(webKitMediaVideoSrcSeekMainCb): Deleted.
(webKitMediaAudioSrcSeekMainCb): Deleted.
(webKitMediaVideoSrcSeekDataCb): Deleted.
(webKitMediaAudioSrcSeekDataCb): Deleted.
(webKitMediaSrcSetMediaPlayer): Deleted.
(webKitMediaSrcSetPlayBin): Deleted.
(MediaSourceClientGstreamer::MediaSourceClientGstreamer): Deleted.
(MediaSourceClientGstreamer::~MediaSourceClientGstreamer): Deleted.
(MediaSourceClientGstreamer::didReceiveDuration): Deleted.
(MediaSourceClientGstreamer::didReceiveData): Deleted.
(MediaSourceClientGstreamer::didFinishLoading): Deleted.
(MediaSourceClientGstreamer::didFail): Deleted.

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.h:

Rewrite MediaSource implementation for GStreamer. The old code was
overly complicated and did not work at all for anything I've tested
it with.

LayoutTests:
Enable MediaSource tests for the GTK port
​https://bugs.webkit.org/show_bug.cgi?id=139441

Patch by Sebastian Dröge <​sebastian@centricular.com> on 2014-12-29
Reviewed by Philippe Normand.

  • platform/gtk/TestExpectations:

Enable MediaSource tests that are actually succeeding for
the GTK port.

4:53 AM Changeset in webkit [177789] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[jhBuild] cairo build error (-flto)
​https://bugs.webkit.org/show_bug.cgi?id=139056

Patch by Fabien Vallée <​fvallee@connected-labs.com> on 2014-12-29
Reviewed by Philippe Normand.

cairo fails to link with gcc 4.9 due to lto
related issue. This problem has been partially
addressed by cairo:
​http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
use the cairo --disable-lto option and remove jhbuild
makeargs fixes the issue.

  • gtk/jhbuild.modules:
  • gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.

Dec 28, 2014:

11:00 PM Changeset in webkit [177788] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, additional build fix on win port since r177786.

  • platform/graphics/opengl/Extensions3DOpenGLES.h: Change a constructor from *protected* to *public*.
10:51 PM Changeset in webkit [177787] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Unreviewed, speculative build fix on win port since r177786.

Apply std::unique_ptr<> and std::make_unique<> to win files as well.

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::createWindowsBitmap):

10:24 PM Changeset in webkit [177786] by gyuyoung.kim@samsung.com
  • 23 edits in trunk/Source/WebCore

Convert OwnPtr to std::unique_ptr in WebCore/graphics/
​https://bugs.webkit.org/show_bug.cgi?id=139971

Reviewed by Darin Adler.

Use std::unique_ptr<> and std::make_unique<> instead of OwnPtr.

  • platform/graphics/GlyphMetricsMap.h:

(WebCore::GlyphMetricsMap<T>::locatePageSlowCase):

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::getChild):
(WebCore::GlyphPageTreeNode::pruneCustomFontData):
(WebCore::GlyphPageTreeNode::pruneFontData):

  • platform/graphics/GlyphPageTreeNode.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsContext3DPrivate.h:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/MaskImageOperation.h:
  • platform/graphics/ca/LayerPool.h:
  • platform/graphics/ca/TileController.h:
  • platform/graphics/ca/TileCoverageMap.h:
  • platform/graphics/ca/mac/WebTiledBackingLayer.h:
  • platform/graphics/gpu/DrawingBuffer.h:
  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::Texture):
(WebCore::Texture::create):

  • platform/graphics/gpu/Texture.h:
  • platform/graphics/opengl/Extensions3DOpenGL.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::getExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::mappedSymbolName):

  • platform/graphics/wayland/WaylandDisplay.cpp:

(WebCore::WaylandDisplay::createSharingGLContext):

  • platform/graphics/wayland/WaylandDisplay.h:
  • platform/graphics/wayland/WaylandSurface.cpp:

(WebCore::WaylandSurface::createGLContext):

  • platform/graphics/wayland/WaylandSurface.h:
2:36 PM Changeset in webkit [177785] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/regions/layers/region-removed-during-animation.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=139979

  • platform/mac-wk2/TestExpectations: Marking as such.
12:59 PM Changeset in webkit [177784] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

iOS build fix.

Reverted r177781, because it appears to trigger <​http://webkit.org/b/139609> on iOS.

  • WebCore.xcodeproj/project.pbxproj:
12:42 PM WebKitGtkLayoutTests edited by Michael Catanzaro
Update "If you wish to run a single test you can do" for CMake (diff)
12:10 PM Changeset in webkit [177783] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Transform nested objects inside arrays
​https://bugs.webkit.org/show_bug.cgi?id=139976

Reviewed by Oliver Hunt.

Call transformGraph on each element so that we'll transform other nested objects correctly.

  • Shared/UserData.cpp:

(WebKit::transformGraph):

11:32 AM Changeset in webkit [177782] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Set relayoutChildren to 'true' only if size change happens in Table
​https://bugs.webkit.org/show_bug.cgi?id=139676

Patch by Roland Takacs <​rtakacs.u-szeged@partner.samsung.com> on 2014-12-28
Reviewed by Darin Adler.

Pass 'true' value for layoutPositionedObjects() in case of size change.
It helps to avoid unneccessary setChildNeedsLayout() and
setPreferredLogicalWidthsDirty() calls.

This is a backport of my fix in Blink: ​https://codereview.chromium.org/714933002/

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::layout):

11:29 AM Changeset in webkit [177781] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Don’t use AccessibilityAllInOne when building with Xcode
​https://bugs.webkit.org/show_bug.cgi?id=139974

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Added all files included by AccessibilityAllInOne.cpp

to the WebCore target, and removed AccessibilityAllInOne.cpp from the project.

10:51 AM Changeset in webkit [177780] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Update Mac test results after r177770.

Line numbers in error messages changed.

  • platform/mac/http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:
  • platform/mac/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt:
3:03 AM Changeset in webkit [177779] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening, mark more failing tests.

  • platform/win/TestExpectations:
2:55 AM Changeset in webkit [177778] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening, mark more timeouting and crashing tests.

  • platform/win/TestExpectations:
2:39 AM Changeset in webkit [177777] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening, mark failing tests.

  • platform/win/TestExpectations:
12:56 AM Changeset in webkit [177776] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening, typo fix.

  • platform/win/TestExpectations:
Note: See TracTimeline for information about the timeline view.