Timeline
Jan 26, 2015:
- 11:40 PM Changeset in webkit [179174] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, rebaseline several CSS tests after r179168.
Computed line-height is no longer 'normal' but the font's line
spacing.
- fast/css/font-shorthand-line-height-expected.txt:
- fast/css/font-shorthand-line-height.html:
- platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- 11:30 PM Changeset in webkit [179173] by
-
- 7 edits26 adds in trunk/LayoutTests
[Win] Unskipping more tests after correcting baselines for Windows widgets.
- platform/win/TestExpectations:
- platform/win/fast/events/context-no-deselect-expected.png: Added.
- platform/win/fast/events/context-no-deselect-expected.txt: Added.
- platform/win/fast/events/dropzone-005-expected.txt: Added.
- platform/win/fast/events/ime-composition-events-001-expected.txt:
- platform/win/fast/events/key-events-in-input-button-expected.txt: Added.
- platform/win/fast/events/mouseup-from-button2-expected.txt: Added.
- platform/win/fast/flexbox: Added.
- platform/win/fast/flexbox/clear-overflow-before-scroll-update-expected.txt: Added.
- platform/win/fast/frames/flattening: Added.
- platform/win/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/win/fast/multicol/client-rects-expected.png: Added.
- platform/win/fast/multicol/client-rects-expected.txt: Added.
- platform/win/fast/multicol/client-rects-spanners-complex-expected.png: Added.
- platform/win/fast/multicol/client-rects-spanners-complex-expected.txt: Added.
- platform/win/fast/multicol/client-rects-spanners-expected.png: Added.
- platform/win/fast/multicol/client-rects-spanners-expected.txt: Added.
- platform/win/fast/multicol/newmulticol: Added.
- platform/win/fast/multicol/newmulticol/client-rects-expected.png: Added.
- platform/win/fast/multicol/newmulticol/client-rects-expected.txt: Added.
- platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/win/fast/overflow/scrollRevealButton-expected.txt:
- platform/win/fast/parser/bad-xml-slash-expected.txt: Added.
- platform/win/fast/parser/document-write-option-expected.txt: Added.
- platform/win/fast/repaint/control-clip-expected.txt:
- platform/win/fast/replaced/object-with-embed-url-param-expected.txt: Added.
- platform/win/fast/replaced/replaced-breaking-expected.txt: Added.
- platform/win/fast/replaced/replaced-breaking-mixture-expected.txt: Added.
- platform/win/fast/replaced/width100percent-button-expected.txt:
- platform/win/fast/replaced/width100percent-checkbox-expected.txt: Added.
- platform/win/fast/replaced/width100percent-menulist-expected.txt: Added.
- platform/win/fast/replaced/width100percent-radio-expected.txt: Added.
- 11:05 PM Changeset in webkit [179172] by
-
- 16 edits in trunk/Source/WebCore
Introduce Document::body() for call sites interested in the <body> element
https://bugs.webkit.org/show_bug.cgi?id=140920
Reviewed by Darin Adler.
Introduce Document::body() method for call sites interested only in the
document's <body> element (not the <frameset>). Also clean up the call
sites of Document::bodyOrFrameset() to cache the return value when
suitable as this method does a tree traversal.
This patch does not change behavior, it merely ports calls sites that
were calling Document::bodyOrFrameset() then checking if the tag was
<body>, to call Document::body() instead. Doing so is more efficient
and clearer.
- 10:32 PM Changeset in webkit [179171] by
-
- 3 edits2 adds in trunk
Apply feTurbulence spec change to fix zero length vector generation
https://bugs.webkit.org/show_bug.cgi?id=140812
.:
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-01-26
Reviewed by Darin Adler.
Recently a bug with the turbulence algorithm was corrected in the
Filter Effects specification.
For some seed values this bug allowed zero length vectors to be generated.
This resulted in large solid color squares being present in the generated image.
The feTurbulence algorithm was updated to reject zero length vectors. This patch
applies that change in WebCore.
Test: svg/filters/feTurbulence_bad_seeds.html
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::initPaint):
Added rejection sampling during vector generation to avoid zero length vectors.
LayoutTests:
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-01-26
Reviewed by Darin Adler.
Ref test that generates a turbulence image which is then coloured black
and alpha min/maxxed (>0 becomes 1, 0 stays zero). This allows holes
caused by zero length vectors to be easily identified.
- svg/filters/feTurbulence_bad_seeds-expected.html: Added.
- svg/filters/feTurbulence_bad_seeds.html: Added.
- 10:24 PM Changeset in webkit [179170] by
-
- 16 edits in trunk
[Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
https://bugs.webkit.org/show_bug.cgi?id=87426
<rdar://problem/11527899>
Reviewed by Darin Adler.
Source/WebCore:
Revise COMPtr to work better with our HashMap implementation:
(1) Add a specialization for IsSmartPtr.
(2) Remove PtrHash specialization.
(3) Refresh HashTrails specialization for COMPtr to match what we
do for RefPtr.
- platform/win/COMPtr.h:
Source/WebKit/win:
Revise COMPtr to work better with our HashMap implementation. Use
modern loop syntax.
- WebHistory.cpp:
(WebHistory::visitedURL): Adjust for new COMPtr changes.
- WebPreferences.cpp:
(WebPreferences::getInstanceForIdentifier): Ditto.
(WebPreferences::removeReferenceForIdentifier): Ditto.
- WebView.cpp:
(WebView::setEditable): Ditto.
Source/WTF:
Revise internal containers to use std::addressof in preference to
to using the '&' operator.
- wtf/Deque.h:
(WTF::inlineCapacity>::append):
(WTF::inlineCapacity>::prepend):
(WTF::inlineCapacity>::removeFirst):
(WTF::inlineCapacity>::removeLast):
(WTF::inlineCapacity>::remove):
(WTF::inlineCapacity>::after):
(WTF::inlineCapacity>::before):
- wtf/GetPtr.h:
- wtf/HashTable.h:
(WTF::HashTableBucketInitializer<false>::initialize):
- wtf/HashTraits.h:
(WTF::SimpleClassHashTraits::constructDeletedValue):
(WTF::CustomHashTraits::constructDeletedValue):
- wtf/ListHashSet.h:
(WTF::ListHashSetConstIterator::get):
- wtf/Vector.h:
(WTF::Vector::swap):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):
Tools:
Revise COMPtr to work better with our HashMap implementation. Use
modern loop syntax.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):
- DumpRenderTree/win/DumpRenderTree.cpp:
(dumpBackForwardListForAllWindows):
- 10:14 PM Changeset in webkit [179169] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Enable JSC stress tests by default
https://bugs.webkit.org/show_bug.cgi?id=128307
Unreviewed typo fix after r179165.
- tests/mozilla/mozilla-tests.yaml:
- 10:12 PM Changeset in webkit [179168] by
-
- 36 edits in trunk
The computed value of line-height:normal is incorrect
https://bugs.webkit.org/show_bug.cgi?id=133744
Patch by Sylvain Galineau <galineau@adobe.com> on 2015-01-26
Reviewed by Dean Jackson.
Source/WebCore:
Use font's line spacing as computed line-height value when specified value is 'normal'.
This behavior is compatible with all other engines.
No new tests; all existing tests are updated to reflect the new computed value.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::lineHeightFromStyle): If line-height wasn't set, use the font's line spacing (same as Blink).
LayoutTests:
line-height:normal now computes to a length value.
This patch updates the tests to reflect the new computed value, as needed.
- css3/calc/line-height-expected.txt:
- editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt:
- fast/css/font-calculated-value-expected.txt:
- fast/css/font-calculated-value.html:
- fast/css/font-shorthand-from-longhands-expected.txt:
- fast/css/font-shorthand-from-longhands.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-font-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/script-tests/computed-style-font.js:
- fast/css/line-height-text-autosizing-expected.txt:
- fast/css/line-height-text-autosizing.html:
- fast/ruby/ruby-line-height-expected.txt:
- fast/ruby/script-tests/ruby-line-height.js:
- media/track/track-cue-rendering-on-resize-expected.txt:
- media/track/track-cue-rendering-on-resize.html:
- platform/mac-mavericks/platform/mac/editing/attributed-string/anchor-element-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/basic-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/font-size-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/font-weight-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/letter-spacing-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/text-decorations-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/vertical-align-expected.txt:
- platform/mac/editing/attributed-string/anchor-element-expected.txt:
- platform/mac/editing/attributed-string/basic-expected.txt:
- platform/mac/editing/attributed-string/font-size-expected.txt:
- platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
- platform/mac/editing/attributed-string/font-weight-expected.txt:
- platform/mac/editing/attributed-string/letter-spacing-expected.txt:
- platform/mac/editing/attributed-string/text-decorations-expected.txt:
- platform/mac/editing/attributed-string/vertical-align-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 10:04 PM Changeset in webkit [179167] by
-
- 4 edits14 adds1 delete in trunk/LayoutTests
[Win] Windows gardening (removing more skips).
- platform/win/TestExpectations:
- platform/win/fast/block/basic/011-expected.png: Added.
- platform/win/fast/block/basic/011-expected.txt: Added.
- platform/win/fast/block/float/overhanging-tall-block-expected.png: Added.
- platform/win/fast/block/float/overhanging-tall-block-expected.txt: Added.
- platform/win/fast/borders/bidi-002-expected.png: Added.
- platform/win/fast/borders/bidi-002-expected.txt: Added.
- platform/win/fast/borders/bidi-009a-expected.png: Added.
- platform/win/fast/borders/bidi-009a-expected.txt: Added.
- platform/win/fast/borders/border-fit-expected.txt: Added.
- platform/win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
- platform/win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
- platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Removed property svn:executable.
- platform/win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Removed property svn:executable.
- platform/win/fast/dom/HTMLTableColElement: Added.
- platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
- platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
- platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
- 9:54 PM Changeset in webkit [179166] by
-
- 6 edits in trunk
Document.dir should reflect the 'dir' attribute of the root html element
https://bugs.webkit.org/show_bug.cgi?id=140922
Reviewed by Darin Adler.
Source/WebCore:
Document.dir should reflect the 'dir' content attribute of the root
<html> element as per the specification:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-dir
Previously, WebKit was reflecting the 'dir' content attribute of the
body element. This patch aligns WebKit with the specification and the
behavior of other browsers (tested Firefox 28, IE11 and Chrome).
This patch is based on the following Blink revision by me:
https://src.chromium.org/viewvc/blink?revision=171734&view=revision
Test: fast/dom/document-dir-property.html
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir):
(WebCore::HTMLDocument::setDir):
- html/HTMLDocument.h:
LayoutTests:
Update fast/dom/document-dir-property.html to reflect the behavior
change.
- fast/dom/document-dir-property-expected.txt:
- fast/dom/document-dir-property.html:
- 9:01 PM Changeset in webkit [179165] by
-
- 8 edits in trunk
[Win] Enable JSC stress tests by default
https://bugs.webkit.org/show_bug.cgi?id=128307
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- tests/mozilla/mozilla-tests.yaml: Skipped on Windows.
- tests/stress/ftl-arithcos.js: Skipped on Windows.
Tools:
- Scripts/run-javascriptcore-tests:
LayoutTests:
- js/script-tests/date-constructor.js: Skipped on Windows.
- js/script-tests/sort-stability.js: Skipped on Windows.
- 8:50 PM Changeset in webkit [179164] by
-
- 8 edits4 copies in branches/safari-600.1.4.15-branch/Source
Merged r177328. rdar://problem/19445865
- 8:39 PM Changeset in webkit [179163] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r179101): SVGUseElement::expandUseElementsInShadowTree has an object lifetime mistake
https://bugs.webkit.org/show_bug.cgi?id=140921
Reviewed by Alexey Proskuryakov.
Bug found by running regression tests with Address Sanitizer.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Use a Ref to protect
the original use element after it's been replaced in the tree; we use it for
one more thing after that.
- 8:06 PM Changeset in webkit [179162] by
-
- 4 edits in trunk/Tools
[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
arguments for build and test scripts
https://bugs.webkit.org/show_bug.cgi?id=139748
Patch by Simon Fraser <Simon Fraser> on 2015-01-26
Reviewed by Daniel Bates.
There was much confusion resulting from the multitude of aliases used to build/test for
the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
tests directory.
This fixes an issue where run-api-tests and some other scripts failed when run with
--simulator.
- Scripts/build-webkit:
- Scripts/package-root:
(usage):
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(determineXcodeSDK):
- Scripts/webkitpy/port/factory.py:
(platform_options):
- 6:39 PM Changeset in webkit [179161] by
-
- 2 edits in trunk
[iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
https://bugs.webkit.org/show_bug.cgi?id=140203
rdar://problem/19198492
Reviewed by Sam Weinig.
Source/WebKit2:
When handling the OwnerWasInvalidated case in -[WKWebView evaluateJavaScript:completionHandler:],
the block passed to dispatch_async() needs to be retained. Fix by passing the RefPtr
to the lambda.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
(TEST):
- 6:39 PM Changeset in webkit [179160] by
-
- 2 edits1 add in trunk
Need a short description (OOPS!).
Need the bug URL (OOPS!).
Reviewed by NOBODY (OOPS!).
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
(TEST):
- 5:14 PM Changeset in webkit [179159] by
-
- 2 edits in trunk/Source/JavaScriptCore
Parse a function expression as a primary expression
https://bugs.webkit.org/show_bug.cgi?id=140908
Reviewed by Mark Lam.
Moved the code to generate an AST node for a function expression from parseMemberExpression
to parsePrimaryExpression to match the ES6 specification terminology:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-primary-expression
There should be no behavior change from this change since parsePrimaryExpression is only
called in parseMemberExpression other than the fact failIfStackOverflow() is called.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
- 4:55 PM Changeset in webkit [179158] by
-
- 2 edits in trunk/Source/WebCore
WebGL 2.0: Actually allow for experimental-webgl2 context creation.
https://bugs.webkit.org/show_bug.cgi?id=140906
<rdar://problem/19606875>.
Reviewed by Brent Fulgham.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::is3dType): Include experimental-webgl2 in the list of acceptable 3d context types.
- 4:26 PM Changeset in webkit [179157] by
-
- 34 edits in trunk/Source
Rename Document::body() to Document::bodyOrFrameset() for clarity
https://bugs.webkit.org/show_bug.cgi?id=140902
Reviewed by Andreas Kling.
Rename Document::body() to Document::bodyOrFrameset() for clarity. This
method does not necessarily return an HTMLBodyElement, it can also
return a frameset as per the specification:
http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
This method is often misused internally (the caller is only interested
in the <body> element). I will fix these instances in a follow-up patch,
this patch is only renaming mechanically.
- 4:19 PM Changeset in webkit [179156] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit2
Merge r179087. rdar://problem/19571057
- 4:19 PM Changeset in webkit [179155] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebCore
Merge r179086. rdar://problem/19566089
- 4:19 PM Changeset in webkit [179154] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit2
Merge r179023. rdar://problem/19573674
- 4:19 PM Changeset in webkit [179153] by
-
- 10 edits in branches/safari-600.4-branch/Source
Merge r179014. rdar://problem/19573674
- 4:19 PM Changeset in webkit [179152] by
-
- 4 edits in branches/safari-600.4-branch/Source
Merge r179013. rdar://problem/19571601
- 4:19 PM Changeset in webkit [179151] by
-
- 6 edits in branches/safari-600.4-branch/Source
Merge r178938. rdar://problem/19558472
- 4:19 PM Changeset in webkit [179150] by
-
- 4 edits in branches/safari-600.4-branch/Source
Merge r178858. rdar://problem/19540806
- 3:23 PM Changeset in webkit [179149] by
-
- 2 edits in trunk/LayoutTests
[Win] More test gardening.
- platform/win/TestExpectations:
- 3:20 PM Changeset in webkit [179148] by
-
- 5 edits in trunk/Source/WebKit2
Add a user default for disabling network cache
https://bugs.webkit.org/show_bug.cgi?id=140904
Reviewed by Andreas Kling
defaults write com.apple.Safari WebKitNetworkCacheEnabled -bool YES/NO
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- 2:59 PM Changeset in webkit [179147] by
-
- 3 edits3 adds in trunk
Fix Border-radius clipping issue on a composited descendants
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=138551
Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-26
Reviewed by Simon Fraser.
Fix assertion in RenderLayerBacking::paintIntoLayer
by not checking out of sync with the GraphicsLayer heirarchy
in GraphicsLayerPaintChildClippingMask phase.
Test: compositing/clipping/border-radius-overflow-hidden-stacking-context.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=138551
Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-26
Reviewed by Simon Fraser.
Ref test that clips composited descendant by stacking context with border-radius and overflow hidden element.
- compositing/clipping/border-radius-overflow-hidden-stacking-context-expected.txt: Added.
- compositing/clipping/border-radius-overflow-hidden-stacking-context.html: Added.
- 2:50 PM Changeset in webkit [179146] by
-
- 4 edits5 adds in branches/safari-600.1.4.15-branch
Merged r177927. rdar://problem/19565854
- 2:44 PM Changeset in webkit [179145] by
-
- 2 edits in trunk/Source/WebCore
Simplify RenderElement's shouldRepaintForImageAnimation()
https://bugs.webkit.org/show_bug.cgi?id=140890
Reviewed by Darin Adler.
Simplify RenderElement's shouldRepaintForImageAnimation() by
not calling rendererForRootBackground(). The previous code was
doing a null-check on Document::documentElement() but failing
to do a null-check on the renderer just after, which lead me
to refactor this code.
Instead of calling document().documentElement.renderer(), we
now call renderer.parent(). This is equivalent because we already
know that renderer.isBody() returns true. The parent of the <body>
has to be the <html> element, which has to be the documentElement.
There is also no need to do a null-check on renderer.parent(). We
already know that the <body> has a renderer (because |renderer| is
its renderer), thus its parent <html> element has to have a renderer
as well.
Finally, simply call !rootElement.hasBackground() instead of
rootElement.rendererForRootBackground() == &bodyRenderer to determine
if the background painted by the root. This is equivalent but more
efficient because:
- We already know that the root renderer's is an <html> element. We can thus avoid the check in rendererForRootBackground().
- We already have the <body>'s renderer so we don't need to do the DOM tree traversal in rendererForRootBackground() to get it.
No new tests, already covered by:
fast/images/animated-gif-body-delegated-background-image.html
fast/images/animated-gif-html-background-image.html
- rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):
- 2:40 PM Changeset in webkit [179144] by
-
- 4 edits2 adds in trunk/Tools
Add iOS EWS to build.webkit.org/dashboard
<http://webkit.org/b/140627>
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer): Add ios-ews queue info.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
Add iOS8Device platform.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
iOS device logo.
- 2:36 PM Changeset in webkit [179143] by
-
- 80 edits in trunk/Source
First argument to DOM traversal functions should be a reference
https://bugs.webkit.org/show_bug.cgi?id=140895
Reviewed by Antti Koivisto.
First argument to DOM traversal functions should be a reference instead
of a pointer as it is dereferenced without null-check.
- 2:03 PM Changeset in webkit [179142] by
-
- 6 edits in trunk/Source/WebCore
[WebGL2] Update IDL for WebGL2.
https://bugs.webkit.org/show_bug.cgi?id=126406
<rdar://problem/15002268>.
Reviewed by Brent Fulgham.
Update WebGL2RenderingContext idl to match spec. Create method stubs as necessary.
- bindings/js/JSWebGL2RenderingContextCustom.cpp:
(WebCore::JSWebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGL2RenderingContext::getInternalformatParameter):
(WebCore::JSWebGL2RenderingContext::getQueryParameter):
(WebCore::JSWebGL2RenderingContext::getSamplerParameter):
(WebCore::JSWebGL2RenderingContext::getSyncParameter):
(WebCore::JSWebGL2RenderingContext::getIndexedParameter):
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockName):
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::copyBufferSubData):
(WebCore::WebGL2RenderingContext::getBufferSubData):
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGL2RenderingContext::blitFramebuffer):
(WebCore::WebGL2RenderingContext::framebufferTextureLayer):
(WebCore::WebGL2RenderingContext::getInternalformatParameter):
(WebCore::WebGL2RenderingContext::invalidateFramebuffer):
(WebCore::WebGL2RenderingContext::invalidateSubFramebuffer):
(WebCore::WebGL2RenderingContext::readBuffer):
(WebCore::WebGL2RenderingContext::renderbufferStorageMultisample):
(WebCore::WebGL2RenderingContext::texStorage2D):
(WebCore::WebGL2RenderingContext::texStorage3D):
(WebCore::WebGL2RenderingContext::texImage3D):
(WebCore::WebGL2RenderingContext::texSubImage3D):
(WebCore::WebGL2RenderingContext::copyTexSubImage3D):
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
(WebCore::WebGL2RenderingContext::getFragDataLocation):
(WebCore::WebGL2RenderingContext::uniform1ui):
(WebCore::WebGL2RenderingContext::uniform2ui):
(WebCore::WebGL2RenderingContext::uniform3ui):
(WebCore::WebGL2RenderingContext::uniform4ui):
(WebCore::WebGL2RenderingContext::uniform1uiv):
(WebCore::WebGL2RenderingContext::uniform2uiv):
(WebCore::WebGL2RenderingContext::uniform3uiv):
(WebCore::WebGL2RenderingContext::uniform4uiv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x3fv):
(WebCore::WebGL2RenderingContext::vertexAttribI4i):
(WebCore::WebGL2RenderingContext::vertexAttribI4iv):
(WebCore::WebGL2RenderingContext::vertexAttribI4ui):
(WebCore::WebGL2RenderingContext::vertexAttribI4uiv):
(WebCore::WebGL2RenderingContext::vertexAttribIPointer):
(WebCore::WebGL2RenderingContext::vertexAttribDivisor):
(WebCore::WebGL2RenderingContext::drawArraysInstanced):
(WebCore::WebGL2RenderingContext::drawElementsInstanced):
(WebCore::WebGL2RenderingContext::drawRangeElements):
(WebCore::WebGL2RenderingContext::drawBuffers):
(WebCore::WebGL2RenderingContext::clearBufferiv):
(WebCore::WebGL2RenderingContext::clearBufferuiv):
(WebCore::WebGL2RenderingContext::clearBufferfv):
(WebCore::WebGL2RenderingContext::clearBufferfi):
(WebCore::WebGL2RenderingContext::createQuery):
(WebCore::WebGL2RenderingContext::deleteQuery):
(WebCore::WebGL2RenderingContext::isQuery):
(WebCore::WebGL2RenderingContext::beginQuery):
(WebCore::WebGL2RenderingContext::endQuery):
(WebCore::WebGL2RenderingContext::getQuery):
(WebCore::WebGL2RenderingContext::getQueryParameter):
(WebCore::WebGL2RenderingContext::createSampler):
(WebCore::WebGL2RenderingContext::deleteSampler):
(WebCore::WebGL2RenderingContext::isSampler):
(WebCore::WebGL2RenderingContext::bindSampler):
(WebCore::WebGL2RenderingContext::samplerParameteri):
(WebCore::WebGL2RenderingContext::samplerParameterf):
(WebCore::WebGL2RenderingContext::getSamplerParameter):
(WebCore::WebGL2RenderingContext::fenceSync):
(WebCore::WebGL2RenderingContext::isSync):
(WebCore::WebGL2RenderingContext::deleteSync):
(WebCore::WebGL2RenderingContext::clientWaitSync):
(WebCore::WebGL2RenderingContext::waitSync):
(WebCore::WebGL2RenderingContext::getSyncParameter):
(WebCore::WebGL2RenderingContext::createTransformFeedback):
(WebCore::WebGL2RenderingContext::deleteTransformFeedback):
(WebCore::WebGL2RenderingContext::isTransformFeedback):
(WebCore::WebGL2RenderingContext::bindTransformFeedback):
(WebCore::WebGL2RenderingContext::beginTransformFeedback):
(WebCore::WebGL2RenderingContext::endTransformFeedback):
(WebCore::WebGL2RenderingContext::transformFeedbackVaryings):
(WebCore::WebGL2RenderingContext::getTransformFeedbackVarying):
(WebCore::WebGL2RenderingContext::pauseTransformFeedback):
(WebCore::WebGL2RenderingContext::resumeTransformFeedback):
(WebCore::WebGL2RenderingContext::bindBufferBase):
(WebCore::WebGL2RenderingContext::bindBufferRange):
(WebCore::WebGL2RenderingContext::getIndexedParameter):
(WebCore::WebGL2RenderingContext::getUniformIndices):
(WebCore::WebGL2RenderingContext::getActiveUniforms):
(WebCore::WebGL2RenderingContext::getUniformBlockIndex):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockName):
(WebCore::WebGL2RenderingContext::uniformBlockBinding):
(WebCore::WebGL2RenderingContext::createVertexArray):
(WebCore::WebGL2RenderingContext::deleteVertexArray):
(WebCore::WebGL2RenderingContext::isVertexArray):
(WebCore::WebGL2RenderingContext::bindVertexArray):
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGL2RenderingContext.idl:
- platform/graphics/GraphicsTypes3D.h:
- 1:42 PM Changeset in webkit [179141] by
-
- 2 edits in trunk/Source/WebCore
Don't let the CSSValuePool's font family cache grow unbounded.
<https://webkit.org/b/140894>
Reviewed by Chris Dumez.
Darin pointed out to Chris who pointed out to me that the font family cache
in CSSValuePool can grow unbounded until we get a system memory pressure
notification. Put a limit on it like we did with the font face cache.
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
- 1:29 PM Changeset in webkit [179140] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r177404. rdar://problem/19419787
- 1:26 PM Changeset in webkit [179139] by
-
- 1 edit5 adds in branches/safari-600.1.4.15-branch/LayoutTests
Merged r177408. rdar://problem/19432686
- 1:26 PM Changeset in webkit [179138] by
-
- 38 edits in branches/safari-600.1.4.15-branch
Merged r177398. rdar://problem/19432686
- 12:57 PM Changeset in webkit [179137] by
-
- 2 edits in trunk/Source/WebCore
Plug leak in jsValueWithDictionaryInContext().
<https://webkit.org/b/140889>
Reviewed by Alexey Proskuryakov.
Add a missing JSStringRelease to plug leak that was showing up on leaks bot.
- platform/mac/SerializedPlatformRepresentationMac.mm:
(WebCore::jsValueWithDictionaryInContext):
- 12:56 PM Changeset in webkit [179136] by
-
- 2 edits in trunk/Tools
copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
https://bugs.webkit.org/show_bug.cgi?id=140896
Reviewed by Michael Saboff.
I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
makes our script do this.
Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
this would be harder given llvm's autoconf setup.
- Scripts/copy-webkitlibraries-to-product-directory:
- 12:51 PM Changeset in webkit [179135] by
-
- 2 edits in trunk/Tools
Update bot assignments.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 12:41 PM Changeset in webkit [179134] by
-
- 11 edits4 adds in trunk
Integrate WP python server into WebKit test framework
https://bugs.webkit.org/show_bug.cgi?id=127094
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Contains parameters of web platform test server.
- resources/config.json: Added.
Tools:
This patch adds W3C web server (wptserver) as a new HTTP server.
wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
- Scripts/webkitpy/common/system/executive_mock.py:
(MockProcess.communicate):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.start_servers):
(LayoutTestRunner.stop_servers):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
(LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
(LayoutTestRunnerTests):
(LayoutTestRunnerTests.test_servers_started):
- Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed.
(Manager.init):
(Manager._is_http_test):
(Manager._is_web_platform_test):
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_needs_servers.get_wpt_doc_root):
(ManagerTest.test_needs_servers.get_manager):
(ManagerTest.test_needs_servers):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
(parse_args):
- Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
(main):
- Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
(doc_root):
(base_url):
(WebPlatformTestServer):
(WebPlatformTestServer.init):
(WebPlatformTestServer._set_start_cmd):
(WebPlatformTestServer._copy_webkit_test_files):
(WebPlatformTestServer._clean_webkit_test_files):
(WebPlatformTestServer._prepare_config):
(WebPlatformTestServer._spawn_process):
(WebPlatformTestServer._stop_running_server):
- Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
(TestWebPlatformTestServer):
(TestWebPlatformTestServer.test_start_cmd):
- Scripts/webkitpy/port/base.py:
(Port.init):
(Port.to.start_web_platform_test_server):
(Port.to):
(Port.to.web_platform_test_server_doc_root):
(Port.to.web_platform_test_server_base_url):
(Port.to.stop_web_platform_test_server):
- Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
(Driver.init):
(Driver.is_web_platform_test):
(Driver.test_to_uri):
(Driver.uri_to_test):
(Driver._command_from_driver_input):
- Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules.
(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):
- 12:40 PM Changeset in webkit [179133] by
-
- 14 edits in branches/safari-600.1.4.15-branch
Merged r177377. rdar://problem/19419793
- 12:40 PM Changeset in webkit [179132] by
-
- 15 edits32 adds in trunk
Fix CSS Selector's tag name matching when mixing HTML and XML
https://bugs.webkit.org/show_bug.cgi?id=140878
Reviewed by Darin Adler.
Source/WebCore:
Previsouly, WebKit was unable to match any XML element that had
any uppercase character if the stylesheet was in a HTML document.
This problem was most often reported due to the inability to style
SVG-in-HTML.
The reason was that the tag local name was incorrectly transformed
to lowercase at parsing time. Instead, we are supposed to only
do case-insensitive match for HTML elements in a HTML document.
This fix is very similar with how we handle attributes:
-Keep both the original and the lowercase versions of the name.
-When matching, chose which version to use depending on the element being matched.
There is one major difference in the way the names are stored.
Unlike attribute selectors, tag name selectors are common, and the uppercase
version is not that uncommon. I wanted to preserve the dense representation
so I specialized CSSSelector specifically for tag names.
To store the data, if the name is already lowercase, just use the m_data pointer
as usual.
If the name is not lowercase, allocate a new small structure in the union to store
both names.
Tests: fast/css/tagname-and-namespace-case-sensitivity-xml-in-html.html
fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml-expected.xhtml
fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml.xhtml
fast/css/tagname-case-sensitivity-svg-in-html.html
fast/css/tagname-case-sensitivity-svg-in-xhtml-expected.xhtml
fast/css/tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/css/tagname-case-sensitivity-xml-in-html.html
fast/css/tagname-case-sensitivity-xml-in-xhtml-expected.xhtml
fast/css/tagname-case-sensitivity-xml-in-xhtml.xhtml
fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html.html
fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html.html
fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html.html
fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html.html
fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml.xhtml
fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html.html
fast/selectors/tagname-descendant-backtracking-case-sensitivity-html.html
- css/CSSGrammar.y.in:
The parser is unaware of anything case related. CSSSelector takes care of that.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::createRareData):
- css/CSSSelector.h:
(WebCore::CSSSelector::NameWithCase::NameWithCase):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagQName):
(WebCore::CSSSelector::tagLowercaseLocalName):
The new representation stores both the original form and the lower case
form.
- css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::shrinkToFit):
- css/RuleSet.h:
(WebCore::RuleSet::tagRules):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
The tag name partition is now split in two: lowercase and original case.
If the matched element is HTML, the lowercase partition is used.
- css/SelectorFilter.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::collectDescendantSelectorIdentifierHashes):
This is the most annoying part of the patch performance wise:
the bloom filter knows the case of the real elements but it cannot know
how selectors will match them.
To make it work, all names are now converted to lowercase.
That implies that we can filter less on XML and we may have to pay for
converting the tag name to lowercase.
I expect the performance hit to be small because:
-Having two XML elements with the same name but different case is uncommon.
-Most elements use lowercase names.
Still sad...that's the price to pay for correctness.
- css/SelectorChecker.cpp:
(WebCore::tagMatches):
(WebCore::SelectorChecker::checkOne):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::tagMatches): Deleted.
Update the legacy matcher, nothing special.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::TagNamePattern::TagNamePattern):
(WebCore::SelectorCompiler::constructFragmentsInternal):
(WebCore::SelectorCompiler::equalTagNames):
(WebCore::SelectorCompiler::equalTagNamePatterns):
(WebCore::SelectorCompiler::computeBacktrackingStartOffsetInChain):
(WebCore::SelectorCompiler::computeBacktrackingHeightFromDescendant):
(WebCore::SelectorCompiler::computeBacktrackingWidthFromIndirectAdjacent):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):
Tag names are used to optimize backtracking; this is quite common for descendant
(e.g. div > ul > li).
We have to differenciate one new case there: if two tag names are equal
when compared case-insensitively but strictly different, they may still
be equal if they don't match the same kind of elements or both matches
and HTML element.
- dom/SelectorQuery.cpp:
(WebCore::localNameMatches):
(WebCore::elementsForLocalName):
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
Update the inline versions of SelectorQuery.
LayoutTests:
We had very little coverage for XHTML and XML in HTML.
I added lots of new tests to cover the basics.
- fast/dom/css-dom-read-2-expected.txt:
- fast/dom/css-dom-read-expected.txt:
CSSOM now provide the tagname in the original case instead of lowercase,
which is actually what the spec defines:
"If the character is not handled by one of the above rules and is greater
than or equal to U+0080, is "-" (U+002D) or "_" (U+005F), or is in one
of the ranges [0-9] (U+0030 to U+0039), [A-Z] (U+0041 to U+005A),
or [a-z] (U+0061 to U+007A), then the character itself."
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-html-expected.html: Added.
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-html.html: Added.
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml-expected.xhtml: Added.
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml.xhtml: Added.
- fast/css/tagname-case-sensitivity-svg-in-html-expected.html: Added.
- fast/css/tagname-case-sensitivity-svg-in-html.html: Added.
- fast/css/tagname-case-sensitivity-svg-in-xhtml-expected.xhtml: Added.
- fast/css/tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/css/tagname-case-sensitivity-xml-in-html-expected.html: Added.
- fast/css/tagname-case-sensitivity-xml-in-html.html: Added.
- fast/css/tagname-case-sensitivity-xml-in-xhtml-expected.xhtml: Added.
- fast/css/tagname-case-sensitivity-xml-in-xhtml.xhtml: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html.html: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html.html: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html.html: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html.html: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml.xhtml: Added.
- fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html-expected.txt: Added.
- fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html.html: Added.
- fast/selectors/tagname-descendant-backtracking-case-sensitivity-html-expected.txt: Added.
- fast/selectors/tagname-descendant-backtracking-case-sensitivity-html.html: Added.
- 12:04 PM Changeset in webkit [179131] by
-
- 3 edits in trunk/Source/WebCore
Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)
https://bugs.webkit.org/show_bug.cgi?id=140891
Reviewed by Anders Carlsson.
Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)
to make sure the argument is not unexpectedly moved when it shouldn't (like I
experienced yesterday in Bug 140577):
<http://trac.webkit.org/changeset/179105>
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create):
- css/CSSValuePool.h:
(WebCore::CSSValuePool::createValue):
- 11:45 AM Changeset in webkit [179130] by
-
- 2 edits in trunk/Tools
Teach run-webkit-app --simulator how to install custom built app
https://bugs.webkit.org/show_bug.cgi?id=140691
Reviewed by David Kilzer.
We should teach run-webkit-app --simulator how to install a custom built app.
Currently run-webkit-app --simulator can only run a system app or an app that
was installed using the simctl command line tool. For convenience we should
teach run-webkit-app --simulator how to install a custom built app.
As a side effect of this change run-safari --simulator will install and run
a custom built of MobileSafari (if it exists).
- Scripts/webkitdirs.pm:
(iOSSimulatorDevices): Added FIXME comment to decouple device representation in
Perl from the structure of the device.plist file.
(plistPathFromBundle): Fix if-statement condition so that we actually perform a
file system check to determine the plist path for a Mac app bundle.
(appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
it will complain that it cannot find the file: "Domain ... does not exist".
(appDisplayNameFromBundle): Ditto.
(waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
until a simulator device is the specified state.
(relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
(if it's open) before opening it again so as to ensure that the iOS Simulator boots
the specified device.
(quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
As implied by its name, this function will not return until the specified simulator
device UDID is in the shutdown state.
(iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
device with the specified UDID.
(isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
expression echoxcrun --sdk iphonesimulator --show-sdk-path/Applications/, contains a
symbolic link. Specifically, echoxcrun --sdk iphonesimulator --show-sdk-pathreturns
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
(hasUserInstalledAppInSimulatorDevice): Added.
(isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
"Booted" state.
(runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
switching between a system installed app and a custom built version of the same app (e.g.
custom build of MobileSafari) will erase all contents and settings in the simulator device.
(eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
as that was the only caller of this function.
(bootedIOSSimulatorDevice): Deleted.
(openIOSSimulator): Deleted.
- 11:44 AM Changeset in webkit [179129] by
-
- 6 edits in trunk/Source
Blacklist iBooks for WebKit's default immediate actions
https://bugs.webkit.org/show_bug.cgi?id=140854
-and corresponding-
rdar://problem/19489518
Reviewed by Tim Horton.
Source/WebCore:
Add a runtime check for iBooks.
- WebCore.exp.in:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsIBooks):
- platform/RuntimeApplicationChecks.h:
Source/WebKit2:
Blacklist iBooks.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _updateImmediateActionItem]):
- 11:38 AM Changeset in webkit [179128] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r177360. rdar://problem/19432691
- 11:38 AM Changeset in webkit [179127] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176384. rdar://problem/19432691
- 11:38 AM Changeset in webkit [179126] by
-
- 11 edits2 adds in branches/safari-600.1.4.15-branch
Merged r172854. rdar://problem/19432691
- 10:33 AM Changeset in webkit [179125] by
-
- 6 edits6 adds in branches/safari-600.1.4.15-branch
Merged r177135. rdar://problem/19450110
- 10:33 AM Changeset in webkit [179124] by
-
- 8 edits in trunk/Source
[iOS] [SVG -> OTF Converter] Flip the switch off on iOS
https://bugs.webkit.org/show_bug.cgi?id=140860
Reviewed by Darin Adler.
Source/JavaScriptCore:
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests because this simply reverts broken code.
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
- 10:31 AM Changeset in webkit [179123] by
-
- 2 edits in trunk/Tools
Update bot assignments.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:18 AM Changeset in webkit [179122] by
-
- 5 edits in trunk/Tools
Leaks bot shouldn't run JSC tests
https://bugs.webkit.org/show_bug.cgi?id=140877
Reviewed by Darin Adler.
Shaves off 48 minutes of time.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestLeaksFactory): Slim down the leaks queue.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.print_leaks_summary):
- Scripts/webkitpy/port/mac.py:
(MacPort.print_leaks_summary):
Don't yell when leaks are detected.
- 10:03 AM Changeset in webkit [179121] by
-
- 2 edits in trunk
[cmake] Remove compiler version calculate cruft
https://bugs.webkit.org/show_bug.cgi?id=140885
Reviewed by Darin Adler.
- Source/cmake/WebKitHelpers.cmake:
- 10:02 AM Changeset in webkit [179120] by
-
- 2 edits in trunk/Tools
Refactor run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=140824
Reviewed by Darin Adler.
Separated mozilla, stress test code paths and
determining skipped mozilla tests into subroutines.
- Scripts/run-javascriptcore-tests:
(runMozillaTests):
(runJSCStressTests):
(defaultJsDriverArgsForMozillaTests):
- 9:52 AM Changeset in webkit [179119] by
-
- 4 edits in trunk/Source/WebCore
Demote 'line-height' to a low priority property.
https://bugs.webkit.org/show_bug.cgi?id=140817
Reviewed by Andreas Kling.
Our special handling of the 'line-height' property is no longer
required, since the 'font' shorthand is now expanded in the parser
in all cases (also for system fonts).
This patch is based on the following Blink revision:
https://src.chromium.org/viewvc/blink?revision=184629&view=revision
No new tests, already covered by:
fast/css/font-shorthand-line-height.html
fast/css/line-height-font-order.html
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
- css/StyleResolver.h:
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::setLineHeightValue): Deleted.
(WebCore::StyleResolver::State::lineHeightValue): Deleted.
- 9:51 AM Changeset in webkit [179118] by
-
- 3 edits4 adds in branches/safari-600.1.4.15-branch
Merged r177292. rdar://problem/19419760
- 9:51 AM Changeset in webkit [179117] by
-
- 1 edit2 adds in branches/safari-600.1.4.15-branch/PerformanceTests
Merged r177051. rdar://problem/19419760
- 9:20 AM Changeset in webkit [179116] by
-
- 3 edits in trunk/Tools
[buildbot] Fix grammar of TestWithFailureCount
https://bugs.webkit.org/show_bug.cgi?id=140884
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestWithFailureCount):
(TestWithFailureCount.commandComplete):
(TestWithFailureCount.getText2):
(RunUnitTests):
(RunPythonTests):
(RunPerlTests):
(RunLLINTCLoopTests):
(Run32bitJSCTests):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(RunLLINTCLoopTestsTest.test_failure):
(Run32bitJSCTestsTest.test_failure):
(RunUnitTestsTest.assertFailures):
- 8:25 AM Changeset in webkit [179115] by
-
- 2 edits in trunk/Source/WebKit2
AX: crash in accessibilityRootObjectWrapper method (WebPageAccessibilityObjectAtk.cpp)
<https://bugs.webkit.org/show_bug.cgi?id=140618>
Patch by Fabien Vallée <fvallee@connected-labs.com> on 2015-01-26
Reviewed by Chris Fleizach.
Check if document()->axObjectCache() is nullptr to fix the crash.
Similar patch has been applied on mac port:
<http://trac.webkit.org/changeset/167136>
Crash occured on <http://itv.mit-xperts.com/hbbtvtest/appmanager/>
(this page needs CEHTML / HbbTV extensions, conditions cannot
be reproduced using regression tests)
- WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
(accessibilityRootObjectWrapper):
- 7:51 AM Changeset in webkit [179114] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself to the committer section.
- 7:15 AM Changeset in webkit [179113] by
-
- 2 edits in trunk
[cmake] Stop compiling with -Wno-error=uninitialized and -Wno-error=literal-suffix
https://bugs.webkit.org/show_bug.cgi?id=140886
Reviewed by Žan Doberšek.
- Source/cmake/WebKitHelpers.cmake:
- 5:49 AM Changeset in webkit [179112] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Remove references to removed tests from GTK+ TestExpectations.
Shared workers are no longer supported and the layout tests were
removed.
- platform/gtk/TestExpectations:
- 3:12 AM Changeset in webkit [179111] by
-
- 10 edits2 moves in trunk
[GTK] gtkdoc does not appear in DevHelp
https://bugs.webkit.org/show_bug.cgi?id=139369
.:
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-26
Reviewed by Philippe Normand.
Expect the gtkdoc to be generated in folders named with the API version.
- Source/PlatformGTK.cmake:
Source/WebCore:
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-26
Reviewed by Philippe Normand.
- PlatformGTK.cmake: Include the API version in the gtkdoc filenames.
Source/WebKit2:
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-26
Reviewed by Philippe Normand.
- PlatformGTK.cmake: Include the API version in the gtkdoc filenames.
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt.
- UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk.types.
Tools:
Patch by Michael Catanzaro <Michael Catanzaro> and Carlos Garcia Campos <cgarcia@igalia.com> on 2015-01-26
Reviewed by Philippe Normand.
- gtk/generate-gtkdoc: Create the generators in the main function
and use them to get the local cross renference dependencies. Also
pass the generator module name to webkitdom.write_doc_files().
(get_gtkdoc_module_paths): Receive a list of local cross reference
dependencies.
(get_generator_for_config): Set the main_sgml_file property of the
GtkDoc object from the configuration file.
(generate_documentation): Generate the documentation for the given
generator.
(generate_documentation_for_config): Deleted.
- gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
- gtk/webkitdom.py:
(write_doc_files): Receive the module name used to build the
-sections.txt filename.
- 1:42 AM Changeset in webkit [179110] by
-
- 3 edits in trunk
[EFL][GTK] Stop compiling with fno-omit-frame-pointer, -fno-tree-dce
https://bugs.webkit.org/show_bug.cgi?id=140609
Reviewed by Csaba Osztrogonác.
The latest releases of GCC versions 4.7, 4.8 and 4.9 all compile and
run JSC tests fine without the -fno-tree-dce and -fno-omit-frame-pointer
compilation flags. Those were added after the jsCStack branch merge, but
can now be removed since the -ftree-dce issues were fixed in GCC, and
changes in r173282 and r173298 again enable compiling with -fomit-frame-pointer.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- 1:09 AM Changeset in webkit [179109] by
-
- 7 edits in trunk
Unreviewed, rolling out r179107.
https://bugs.webkit.org/show_bug.cgi?id=140880
The GCC in the bots doesn't support the AsyncTask
implementation (Requested by KaL on #webkit).
Reverted changeset:
"[GTK] Enable IndexedDB"
https://bugs.webkit.org/show_bug.cgi?id=98932
http://trac.webkit.org/changeset/179107
- 1:08 AM Changeset in webkit [179108] by
-
- 2 edits in trunk/Tools
[EFL] Bump libseccomp version to 2.1.1
https://bugs.webkit.org/show_bug.cgi?id=140357
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- 12:25 AM Changeset in webkit [179107] by
-
- 7 edits in trunk
[GTK] Enable IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=98932
Reviewed by Žan Doberšek.
.:
- Source/cmake/OptionsGTK.cmake: Enable DATABASE_PROCESS and INDEXED_DATABASE.
- Source/cmake/WebKitFeatures.cmake: Add ENABLE_DATABASE_PROCESS.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
LayoutTests:
- platform/gtk/TestExpectations: Update IndexedDB test expectations.
Jan 25, 2015:
- 11:59 PM Changeset in webkit [179106] by
-
- 8 edits1 add in trunk/Tools
Would like leaks bot results at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122657
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
than necessary, could use the ones from buildbot in more places.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue): Reflect configuration option for leaks queues.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
Add leaks queues to performance column. First, leaks are about performance indeed,
and second, this is where we have some space to spare.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
least a year.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid td): Moved height from queue-view - we can now have more than one
queue view per cell. The heigt is needed to avoid ugly overlapping while loading
results - once the results are loaded, all rows are currently higher than that.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
(.leaks-popover): Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
Load BuildbotLeaksQueueView.js.
- 11:10 PM Changeset in webkit [179105] by
-
- 2 edits in trunk/Source/WebCore
Remove 'font' shorthand property special casing
https://bugs.webkit.org/show_bug.cgi?id=140577
Reviewed by Darin Adler.
Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
supposed to change. This also makes sure that m_value.fontFamily
gets copied instead of moved when constructing a clone in
CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
to fail on the bots.
- css/CSSPrimitiveValue.h:
- 10:29 PM Changeset in webkit [179104] by
-
- 4 edits115 moves2518 adds in trunk/LayoutTests
[iOS] Update expected results and test expectations
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
[...]
- 9:01 PM Changeset in webkit [179103] by
-
- 6 edits in trunk/LayoutTests
fast/html/marquee-scrollamount.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140851
Reviewed by Darin Adler.
Updated the test to not have a zero delay timer race. Added many comments, because
what is being tested here is quite subtle.
- fast/html/marquee-scrollamount.html:
- platform/efl/fast/html/marquee-scrollamount-expected.txt:
- platform/gtk/fast/html/marquee-scrollamount-expected.txt:
- platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt:
- platform/mac/fast/html/marquee-scrollamount-expected.txt:
The DOM changed slightly, because we now insert the marquee after load event.
- 8:04 PM Changeset in webkit [179102] by
-
- 3 edits2 adds in trunk
Setting HTMLMarqueeElement.trueSpeed doesn't work
https://bugs.webkit.org/show_bug.cgi?id=140863
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/html/marquee-set-truespeed.html
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::minimumDelay):
Check the boolean attribute properly - an empty value is true.
LayoutTests:
Verify that setting scrollDelay to a value under 60 actually works when trueSpeed is set.
- fast/html/marquee-set-truespeed-expected.html: Added.
- fast/html/marquee-set-truespeed.html: Added.
- 7:22 PM Changeset in webkit [179101] by
-
- 7 edits in trunk/Source/WebCore
Streamline SVGUseElement shadow tree handling and make it use SVGElementInstance less
https://bugs.webkit.org/show_bug.cgi?id=140875
Reviewed by Anders Carlsson.
Refactoring of code that is pretty well covered by existing tests, so
not adding new tests.
Inspired by work Rob Buis did in Blink:
http://src.chromium.org/viewvc/blink?view=revision&revision=173273
Althgouh that is less than half of what ended up in this patch.
- dom/ContainerNode.h: Fixed NoEventDispatchAssertion so it can be
copied without causing an underflow of NoEventDispatchAssertion::s_count.
Made the copy constructor call the default constructor. Also changed it
to be based on ASSERT_DISABLED rather than NDEBUG and tweaked it a bit.
- dom/ElementIteratorAssertions.h: Removed an unnecessary include and
an unnecessary default constructor. Changed to use WTF::Optional instead
of WTF::OwnPtr to handle NoEventDispatchAssertion, which makes this class
copyable and assignable, which in turn makes the iterators based on this
copyable and assignable, which is what I needed in SVGUseElement code.
Also simplified code in a couple places.
- dom/TypedElementDescendantIterator.h:
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
Fixed an error where the arguments to Traversal::next were passed backwards.
This led to incomplete iteration in SVGUseElement code, and an immediate
assertion failure. Probably could use some unit test coverage, too.
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):
Ditto.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::animatedInstanceRoot): Deleted.
(WebCore::SVGUseElement::transferSizeAttributesToShadowTreeTargetClone):
Removed the originalElement argument, since we can use the correspondingElement
to get back to it. Removed the useElement argument and changed this into a
member function.
(WebCore::SVGUseElement::svgAttributeChanged): Updated for above changes.
(WebCore::subtreeContainsDisallowedElement): Deleted this function, because
it was only used to optimize by not calling removeDisallowedElementsFromSubtree,
but that function is already similarly efficient when called to do nothing, so
the preflight was not useful.
(WebCore::SVGUseElement::clearResourceReferences): Call userAgentShadowRoot
instead of shadowRoot for clarity.
(WebCore::SVGUseElement::buildPendingResource): Pass a reference instead of
a pointer to buildShadowAndInstanceTree, since it's guaranteed to not be null.
(WebCore::SVGUseElement::shadowTreeTargetClone): Added. Returns the SVG element
inside the shadow tree that corresponds to the use element's target.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Changed argument type
to a reference instead of a pointer. Removed comments explaining why we have
an instance tree, since soon we will not have one. Removed many comments that
simply state the names of the functions they are commenting on and perhaps a tiny
bit more. Changed to not use m_targetElementInstance as much, dealing with the
shadow tree directly instead of through the instance tree.
(WebCore::SVGUseElement::toClipPath): Use shadowTreeTargetClone instead of
getting at the element through m_targetElementInstance.
(WebCore::SVGUseElement::rendererClipChild): Ditto.
(WebCore::removeDisallowedElementsFromSubtree): Removed the inline keyword,
since there's no good reason to inline thif function's body. Improved local
variable names and used a modern for loop. Also moved the comment about why
this function is used here inside the function instead of repeating it at
each call site.
(WebCore::SVGUseElement::buildShadowTree): Changed to take a reference
instead of a pointer. Moved the check to see if the target is disallowed
out of this function and into buildShadowAndInstanceTree, which needs to
handle that failure explicitly. Tightened up the code a bit, using Ref instead
of RefPtr, putting the comment about removeDisallowedElementsFromSubtree into
that function itself, and removing the unneeded subtreeContainsDisallowedElement
check entirely.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Removed the argument,
getting the shadow tree from the shadowTree function instead. Walk the tree
iteratively instead of recursively, using the descendantsOfType function.
Rearranged and streamlined the logic.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
(WebCore::SVGUseElement::transferAttributesToShadowTreeReplacement): Renamed
this to avoid the term "replaced element", which is not a reasonable way to
refer to the <g> element in the shadow tree that replaces the <use> element.
Changed the argument type to SVGGElement to make it harder to misuse this
function by accident, and made the use element be "this" instead of passing
it as an argument.
(WebCore::SVGUseElement::selfHasRelativeLengths): Call hasRelativeLengths
on the target inside the shadow tree rather than the original target, which
makes more sense anyway, and is straightforward now that we have the
shadowTreeTargetClone function. Removes use of m_targetElementInstance here.
- svg/SVGUseElement.h: Updated for above changes.
- svg/SVGUseElement.idl: Removed animatedInstanceRoot and tweaked formatting.
- 6:11 PM Changeset in webkit [179100] by
-
- 22 edits5 adds in trunk
Remove 'font' shorthand property special casing
https://bugs.webkit.org/show_bug.cgi?id=140577
Reviewed by Darin Adler.
Source/WebCore:
Expand system font values during 'font' property parsing. The 'font'
CSS property was the only shorthand that wasn't always expanded in
the CSS parser, so it needed a lot of special handling that we can
now get rid of.
This patch is inspired from the following Blink revision:
https://src.chromium.org/viewvc/blink?view=rev&revision=184449
Tests:
- fast/css/css2-system-fonts.html (existing)
- fast/css/CSSPrimitiveValue-font-family-primitiveType.html (new)
- fast/css/font-systemFontID-parsing.html (new)
- fast/css/font-shorthand-line-height.html (rebased)
- WebCore.xcodeproj/project.pbxproj:
- css/CSSCalculationValue.cpp:
(WebCore::hasDoubleValue):
Handle CSS_FONT_FAMILY similarly to CSS_STRING in the switch.
- css/CSSFontFamily.h: Added.
Introduce new CSSFontFamily class to store font families inside
CSSPrimitive, instead of using a simple String as previously. We need
an additional 'fromSystemFontID' flag in addition to the font family
name now that system font ID are expanded during parsing. This
information is needed later on by the StyleBuilder (see comment below).
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
Update code dealing with font family CSSPrimitiveValues now that they
hold a CSSFontFamily internally instead of a String.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSystemFont):
Expand system font values for the 'font' property by asking the
RenderTheme for the system font and using it to set the 'font'
longhand properties.
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
Handle CSS_FONT_FAMILY value in the switch.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::primitiveType):
Make sure we still expose font family CSSPrimitiveValues to the Web as
CSS_STRING, even though we are using a slightly different representation
internally. This is so that we don't change web-exposed behavior and I
added a new layout test to cover this.
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
Handle CSS_FONT_FAMILY type in switches.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontFamily):
Add method to test if a CSSPrimitiveValue holds a CSSFontFamily
internally.
(WebCore::CSSPrimitiveValue::fontFamily):
Add a getter to retrieve the internal CSSFontFamily object if the
primitive type is CSS_FONT_FAMILY.
- css/CSSPropertyNames.in:
Treat 'font' as a regular shorthand property. Specify its longhand
properties so that makeprop.pl can generate the shorthand code for
us. Also demote 'font' to being a low-priority property as it is
now always expanded during parsing.
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
- css/CSSValuePool.h:
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueFontFamily):
- Update the 'font-family' value setter in the StyleBuilder to reflect
the changes in the CSS parser. The CSSPrimitiveValues in the list now
have CSS_FONT_FAMILY type instead of CSS_STRING.
- We also set the 'isGenericFamily' flag if the font-family was expanded
from a system font ID (e.g. caption). The 'isGenericFamily' flag is
used later on to property set the 'isSpecifiedFont' flag on the
FontDescription object. If we don't do this, system font values will
be treated as specified fonts, which means that we will no longer use
the 'use backslash as Yen sign' hack for those. This is covered by the
following layout tests:
- fast/text/backslash-to-yen-sign-euc.html
- editing/selection/find-yensign-and-backslash.html
(WebCore::StyleBuilderCustom::applyInitialFont): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFont): Deleted.
(WebCore::StyleBuilderCustom::applyValueFont): Deleted.
Remove StyleBuilder code dealing with the 'font' property. Now that
the 'font' property is always expanded during parsing, this code can
never be reached.
- css/StylePropertyShorthand.cpp:
(WebCore::isExpandedShorthand):
Stop returning false for 'font' as it is now expanded during parsing
as well. We should probably consider renaming this method to something
else now that all shorthands are expanded, maybe isCSSShorthand() or
isShorthandProperty().
(WebCore::fontShorthand): Deleted.
- css/StylePropertyShorthand.h:
(WebCore::matchingCustomShorthandsForLonghand): Deleted.
Remove custom shorthand code for the 'font' property as it is now
generated by makeprop.pl, like other shorthands.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyFont): Deleted.
This is unused now that the StyleBuilder code for 'font' has been
removed.
- css/makeprop.pl:
Remove custom shorthand code for 'font' as it no longer requires any
special handling.
LayoutTests:
- fast/css/CSSPrimitiveValue-font-family-primitiveType-expected.txt: Added.
- fast/css/CSSPrimitiveValue-font-family-primitiveType.html: Added.
Add layout test to make sure that the font-family is still exposed to the
Web as a CSSValueList of CSSPrimitiveValues whose primitiveType is
CSS_STRING. This is useful because we now use a slightly different
representation internally.
- fast/css/font-shorthand-line-height-expected.txt:
- fast/css/font-shorthand-line-height.html:
Rebaseline the test. This is a progression. Setting the 'font' property
to a system font ID is supposed to reset the line-height property to
'normal'. It previously did not because system font IDs were not
expanded at parsing time. The new behavior is consistent with Chrome and
Firefox as well.
- fast/css/font-systemFontID-parsing-expected.txt: Added.
- fast/css/font-systemFontID-parsing.html: Added.
Add a layout test to make sure that the CSS parser is rejecting a 'font'
property with more than one system font id.
- 4:14 PM Changeset in webkit [179099] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177449. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179098] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177444. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179097] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177332. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179096] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177306. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179095] by
-
- 18 edits in branches/safari-600.1.4.15-branch/Source
Merged r177301. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179094] by
-
- 5 edits8 adds in branches/safari-600.1.4.15-branch
Merged r177050. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179093] by
-
- 1 edit in branches/safari-600.1.4.15-branch/Source/WebCore/ChangeLog
Merged r177041. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179092] by
-
- 29 edits in branches/safari-600.1.4.15-branch
Merged r177035. rdar://problem/19419933
- 11:40 AM Changeset in webkit [179091] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
Document a few more failures in the expectations file.
- platform/win/TestExpectations:
- 11:28 AM Changeset in webkit [179090] by
-
- 2 edits in trunk/LayoutTests
[Win] Document some Debug crashes in Accessibility code.
- platform/win/TestExpectations:
- 10:37 AM Changeset in webkit [179089] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
Skip crashes and timeouts to speed up test runs.
- platform/win/TestExpectations:
- 10:01 AM Changeset in webkit [179088] by
-
- 9 edits3 adds in trunk
[Win] Add WebKit message loop interface.
https://bugs.webkit.org/show_bug.cgi?id=140857
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-25
Reviewed by Brent Fulgham.
Added message loop interface which will run the message loop,
and perform required tasks (like calling CFRunLoopRunInMode)
on each iteration of the loop.
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Added new files to project.
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.
Source/WebKit/win:
- ForEachCoClass.h:
- Interfaces/WebKit.idl:
- Interfaces/WebKitMessageLoop.idl: Added.
- WebKitClassFactory.cpp:
- WebKitMessageLoop.cpp: Added.
(WebKitMessageLoop::WebKitMessageLoop):
(WebKitMessageLoop::~WebKitMessageLoop):
(WebKitMessageLoop::createInstance):
(WebKitMessageLoop::QueryInterface):
(WebKitMessageLoop::AddRef):
(WebKitMessageLoop::Release):
(WebKitMessageLoop::run):
(WebKitMessageLoop::performMessageLoopTasks):
- WebKitMessageLoop.h: Added.
Tools:
- WinLauncher/WinMain.cpp:
(wWinMain): Use new message loop interface.
- 12:20 AM Changeset in webkit [179087] by
-
- 2 edits in trunk/Source/WebKit2
Unresponsive Web processes sometimes throw ObjC exceptions under didPerformActionMenuHitTest:
https://bugs.webkit.org/show_bug.cgi?id=140859
<rdar://problem/19571057>
Reviewed by Darin Adler.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):
If we've already given up on this gesture (either because it was canceled or the
willBeginAnimation timeout expired), we shouldn't build a new animationController for it.
This is true both because it wouldn't look good to swap animationControllers out
from under the gesture, but also because AppKit throws an exception when you do this
and that breaks a lot of things.
- 12:17 AM Changeset in webkit [179086] by
-
- 2 edits in trunk/Source/WebCore
Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
https://bugs.webkit.org/show_bug.cgi?id=140862
<rdar://problem/19566089>
Reviewed by Dan Bernstein.
- page/Frame.cpp:
(WebCore::Frame::rangeForPoint):
If there isn't a selectable text node at the given point, rangeForPoint
will eventually return null. However, we can make it fail much faster
by checking the initial position's text-ness and selectability.
- 12:02 AM Changeset in webkit [179085] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening for EFL port.
- platform/efl/TestExpectations: media/media-fullscreen-inline.html has been passed since r19100.
Jan 24, 2015:
- 11:35 PM Changeset in webkit [179084] by
-
- 16 edits13 adds in trunk/LayoutTests
[Win] More rebaselines. (Tables)
- platform/win/tables/mozilla/bugs/bug1188-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug1188-expected.txt:
- platform/win/tables/mozilla/bugs/bug18359-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug18359-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-3-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-4-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/win/tables/mozilla/bugs/bug29326-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug29326-expected.txt:
- platform/win/tables/mozilla/bugs/bug33855-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug33855-expected.txt:
- platform/win/tables/mozilla/bugs/bug4382-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug4382-expected.txt:
- platform/win/tables/mozilla/bugs/bug4527-expected.txt:
- platform/win/tables/mozilla/bugs/bug96334-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug96334-expected.txt:
- platform/win/tables/mozilla/core/margins-expected.png: Added.
- platform/win/tables/mozilla/core/margins-expected.txt:
- platform/win/tables/mozilla/dom/tableDom-expected.png: Added.
- platform/win/tables/mozilla/dom/tableDom-expected.txt:
- platform/win/tables/mozilla/other/move_row-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 11:14 PM Changeset in webkit [179083] by
-
- 67 edits43 adds in trunk/LayoutTests
[Win] Unreviewed rebaselining.
Second batch: Fast
- platform/win/fast/block/float/float-avoidance-expected.png: Added.
- platform/win/fast/block/margin-collapse/103-expected.png: Added.
- platform/win/fast/canvas/fallback-content-expected.txt:
- platform/win/fast/css/non-standard-checkbox-size-expected.png: Added.
- platform/win/fast/css/non-standard-checkbox-size-expected.txt:
- platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/win/fast/forms/001-expected.png:
- platform/win/fast/forms/001-expected.txt:
- platform/win/fast/forms/003-expected.png: Added.
- platform/win/fast/forms/003-expected.txt:
- platform/win/fast/forms/004-expected.png: Added.
- platform/win/fast/forms/004-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label01-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label02-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label03-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label04-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/win/fast/forms/basic-inputs-expected.png:
- platform/win/fast/forms/basic-inputs-expected.txt:
- platform/win/fast/forms/basic-selects-expected.png:
- platform/win/fast/forms/basic-selects-expected.txt:
- platform/win/fast/forms/basic-textareas-quirks-expected.png: Added.
- platform/win/fast/forms/box-shadow-override-expected.png:
- platform/win/fast/forms/box-shadow-override-expected.txt:
- platform/win/fast/forms/control-clip-overflow-expected.png: Added.
- platform/win/fast/forms/control-clip-overflow-expected.txt:
- platform/win/fast/forms/control-restrict-line-height-expected.png: Added.
- platform/win/fast/forms/control-restrict-line-height-expected.txt:
- platform/win/fast/forms/disabled-select-change-index-expected.png: Added.
- platform/win/fast/forms/disabled-select-change-index-expected.txt:
- platform/win/fast/forms/file/file-input-disabled-expected.png:
- platform/win/fast/forms/file/file-input-disabled-expected.txt:
- platform/win/fast/forms/form-element-geometry-expected.png: Added.
- platform/win/fast/forms/form-element-geometry-expected.txt:
- platform/win/fast/forms/formmove-expected.png: Added.
- platform/win/fast/forms/formmove-expected.txt:
- platform/win/fast/forms/indeterminate-expected.png: Added.
- platform/win/fast/forms/indeterminate-expected.txt:
- platform/win/fast/forms/input-appearance-height-expected.png: Added.
- platform/win/fast/forms/input-appearance-height-expected.txt:
- platform/win/fast/forms/input-appearance-selection-expected.png: Added.
- platform/win/fast/forms/input-appearance-selection-expected.txt: Added.
- platform/win/fast/forms/menulist-deselect-update-expected.txt:
- platform/win/fast/forms/menulist-no-overflow-expected.png: Added.
- platform/win/fast/forms/menulist-no-overflow-expected.txt:
- platform/win/fast/forms/menulist-restrict-line-height-expected.png: Added.
- platform/win/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/win/fast/forms/menulist-separator-painting-expected.txt:
- platform/win/fast/forms/menulist-style-color-expected.png:
- platform/win/fast/forms/menulist-style-color-expected.txt:
- platform/win/fast/forms/menulist-width-change-expected.txt:
- platform/win/fast/forms/option-script-expected.txt:
- platform/win/fast/forms/option-strip-whitespace-expected.png: Added.
- platform/win/fast/forms/option-strip-whitespace-expected.txt:
- platform/win/fast/forms/option-text-clip-expected.png:
- platform/win/fast/forms/option-text-clip-expected.txt:
- platform/win/fast/forms/range/input-appearance-range-expected.png: Added.
- platform/win/fast/forms/range/input-appearance-range-expected.txt:
- platform/win/fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Added.
- platform/win/fast/forms/range/slider-mouse-events-expected.txt:
- platform/win/fast/forms/range/slider-onchange-event-expected.txt: Added.
- platform/win/fast/forms/range/slider-padding-expected.txt:
- platform/win/fast/forms/range/slider-thumb-shared-style-expected.png: Added.
- platform/win/fast/forms/range/slider-thumb-shared-style-expected.txt:
- platform/win/fast/forms/range/slider-zoomed-expected.txt: Added.
- platform/win/fast/forms/select-align-expected.png: Added.
- platform/win/fast/forms/select-align-expected.txt:
- platform/win/fast/forms/select-background-none-expected.txt:
- platform/win/fast/forms/select-baseline-expected.png: Added.
- platform/win/fast/forms/select-baseline-expected.txt:
- platform/win/fast/forms/select-change-listbox-to-popup-expected.png: Added.
- platform/win/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/win/fast/forms/select-change-popup-to-listbox-expected.png: Added.
- platform/win/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
- platform/win/fast/forms/select-disabled-appearance-expected.png: Added.
- platform/win/fast/forms/select-disabled-appearance-expected.txt:
- platform/win/fast/forms/select-initial-position-expected.png: Added.
- platform/win/fast/forms/select-initial-position-expected.txt:
- platform/win/fast/forms/select-selected-expected.png: Added.
- platform/win/fast/forms/select-selected-expected.txt:
- platform/win/fast/forms/select-size-expected.txt:
- platform/win/fast/forms/select-style-expected.png: Added.
- platform/win/fast/forms/select-style-expected.txt:
- platform/win/fast/forms/select-visual-hebrew-expected.txt:
- platform/win/fast/forms/select-writing-direction-natural-expected.png:
- platform/win/fast/forms/select-writing-direction-natural-expected.txt:
- platform/win/fast/forms/select/optgroup-rendering-expected.png:
- platform/win/fast/forms/select/optgroup-rendering-expected.txt:
- platform/win/fast/forms/selectlist-minsize-expected.txt:
- platform/win/fast/forms/stuff-on-my-optgroup-expected.png: Added.
- platform/win/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/win/fast/invalid: Added.
- platform/win/fast/invalid/014-expected.txt: Added.
- platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
- platform/win/fast/parser: Added.
- platform/win/fast/parser/entity-comment-in-textarea-expected.txt: Added.
- platform/win/fast/parser/open-comment-in-textarea-expected.txt: Added.
- platform/win/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/win/fast/replaced/three-selects-break-expected.txt:
- platform/win/fast/text/international/bidi-menulist-expected.txt:
- platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/win/fast/text/textIteratorNilRenderer-expected.txt:
- 9:46 PM Changeset in webkit [179082] by
-
- 22 edits in trunk/LayoutTests
[Win] Unreviewed baseline update.
First batch: CSS updates.
- platform/win/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/win/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/win/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/win/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/win/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/win/fast/block/float/float-avoidance-expected.txt:
- platform/win/fast/block/margin-collapse/103-expected.txt:
- 8:36 PM Changeset in webkit [179081] by
-
- 2 edits in trunk/Tools
update-webkit’s --internal option is unused
https://bugs.webkit.org/show_bug.cgi?id=140861
Reviewed by Anders Carlsson.
- Scripts/update-webkit: Removed the option.
- 7:02 PM Changeset in webkit [179080] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Cocoa] Drop WKDiagnosticLoggingResultType defines
https://bugs.webkit.org/show_bug.cgi?id=140838
Reviewed by Sam Weinig.
Drop WKDiagnosticLoggingResultType defines in _WKDiagnosticLoggingDelegate.h
header now that the client-side is correctly using
_WKDiagnosticLoggingResultType instead.
- UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
- 6:55 PM Changeset in webkit [179079] by
-
- 26 edits81 adds in trunk/LayoutTests
[Win] Unreviewed gardening. Reactivating tests.
Re-enable a series of tests that work properly on Windows. New baselines will be needed.
- platform/win/TestExpectations:
- platform/win/css1/box_properties/acid_test-expected.png: Added.
- platform/win/css1/box_properties/acid_test-expected.txt:
- platform/win/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/win/fast/block/float/float-avoidance-expected.txt:
- platform/win/fast/block/margin-collapse/103-expected.txt:
- platform/win/fast/css/box-shadow-and-border-radius-expected.png:
- platform/win/fast/dynamic/008-expected.txt: Added.
- platform/win/fast/forms/001-expected.png: Added.
- platform/win/fast/forms/001-expected.txt:
- platform/win/fast/forms/003-expected.txt:
- platform/win/fast/forms/004-expected.txt:
- platform/win/fast/forms/006-expected.png: Added.
- platform/win/fast/forms/007-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label01-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label02-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label03-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label04-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label05-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Removed property svn:executable.
- platform/win/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
- platform/win/fast/forms/basic-buttons-expected.png: Added.
- platform/win/fast/forms/basic-buttons-expected.txt: Added.
- platform/win/fast/forms/basic-inputs-expected.png: Added.
- platform/win/fast/forms/basic-selects-expected.txt:
- platform/win/fast/forms/basic-textareas-expected.png: Added.
- platform/win/fast/forms/box-shadow-override-expected.png: Added.
- platform/win/fast/forms/box-shadow-override-expected.txt: Added.
- platform/win/fast/forms/button-positioned-expected.txt: Added.
- platform/win/fast/forms/button-sizes-expected.txt: Added.
- platform/win/fast/forms/button-style-color-expected.txt: Added.
- platform/win/fast/forms/button-text-transform-expected.txt: Added.
- platform/win/fast/forms/control-clip-overflow-expected.txt: Added.
- platform/win/fast/forms/control-restrict-line-height-expected.txt:
- platform/win/fast/forms/disabled-select-change-index-expected.txt: Added.
- platform/win/fast/forms/form-element-geometry-expected.txt: Added.
- platform/win/fast/forms/hidden-listbox-expected.txt: Added.
- platform/win/fast/forms/input-appearance-focus-expected.txt: Added.
- platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
- platform/win/fast/forms/input-readonly-autoscroll-expected.txt: Added.
- platform/win/fast/forms/input-text-double-click-expected.txt: Added.
- platform/win/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
- platform/win/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
- platform/win/fast/forms/listbox-width-change-expected.txt: Added.
- platform/win/fast/forms/menulist-deselect-update-expected.txt:
- platform/win/fast/forms/menulist-no-overflow-expected.txt: Added.
- platform/win/fast/forms/number/number-appearance-rtl-expected.txt: Added.
- platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Added.
- platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Added.
- platform/win/fast/forms/option-strip-whitespace-expected.txt: Added.
- platform/win/fast/forms/plaintext-mode-2-expected.txt: Added.
- platform/win/fast/forms/search: Added.
- platform/win/fast/forms/search/search-size-with-decorations-expected.txt: Added.
- platform/win/fast/forms/select-align-expected.txt: Added.
- platform/win/fast/forms/select-baseline-expected.txt: Added.
- platform/win/fast/forms/select-block-background-expected.txt: Added.
- platform/win/fast/forms/select-change-listbox-size-expected.txt: Added.
- platform/win/fast/forms/select-change-listbox-to-popup-expected.txt: Added.
- platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
- platform/win/fast/forms/select-disabled-appearance-expected.txt: Added.
- platform/win/fast/forms/select-initial-position-expected.txt: Added.
- platform/win/fast/forms/select-item-background-clip-expected.txt: Added.
- platform/win/fast/forms/select-list-box-with-height-expected.txt: Added.
- platform/win/fast/forms/select-selected-expected.txt: Added.
- platform/win/fast/forms/select/optgroup-rendering-expected.txt:
- platform/win/fast/forms/tabbing-input-iframe-expected.txt: Added.
- platform/win/fast/frames: Added.
- platform/win/fast/frames/take-focus-from-iframe-expected.txt: Added.
- platform/win/fast/multicol/pagination: Added.
- platform/win/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
- platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
- platform/win/fast/overflow/entity-comment-in-textarea-expected.txt: Added.
- platform/win/fast/overflow/open-comment-in-textarea-expected.txt: Added.
- platform/win/fast/overflow/overflow-x-y-expected.txt: Added.
- platform/win/fast/table/003-expected.txt: Added.
- platform/win/fast/table/colspanMinWidth-expected.txt: Added.
- platform/win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug103533-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug1188-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug12384-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug1318-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug18359-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug26178-expected.txt:
- platform/win/tables/mozilla/bugs/bug28928-expected.txt:
- platform/win/tables/mozilla/bugs/bug29326-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug30559-expected.txt:
- platform/win/tables/mozilla/bugs/bug30692-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug33855-expected.txt:
- platform/win/tables/mozilla/bugs/bug4382-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug4429-expected.txt:
- platform/win/tables/mozilla/bugs/bug44505-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug51037-expected.txt:
- platform/win/tables/mozilla/bugs/bug55545-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug96334-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug99948-expected.txt: Added.
- platform/win/tables/mozilla/core: Added.
- platform/win/tables/mozilla/core/bloomberg-expected.txt: Added.
- platform/win/tables/mozilla/core/margins-expected.txt: Added.
- platform/win/tables/mozilla/dom/tableDom-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_align_justify-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- 5:28 PM Changeset in webkit [179078] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176725. rdar://problem/19432746
- 5:28 PM Changeset in webkit [179077] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged 'resolvedURL' changes from r176108. rdar://problem/19432746
- 4:54 PM Changeset in webkit [179076] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176475. rdar://problem/19450119
- 4:54 PM Changeset in webkit [179075] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175251. rdar://problem/19450119
- 4:08 PM Changeset in webkit [179074] by
-
- 2 edits in trunk/Tools
DumpRenderTree needs to run with Windows native controls on Windows
https://bugs.webkit.org/show_bug.cgi?id=25592
Reviewed by Anders Carlsson.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
(prepareConsistentTestingEnvironment): Ditto.
- 12:36 PM Changeset in webkit [179073] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176382. rdar://problem/19419810
- 12:30 PM Changeset in webkit [179072] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r176321. rdar://problem/19369495
- 12:16 PM Changeset in webkit [179071] by
-
- 8 edits2 adds in branches/safari-600.1.4.15-branch
Merged r176262. rdar://problem/19432679
- 12:16 PM Changeset in webkit [179070] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175260. rdar://problem/19432679
- 11:55 AM Changeset in webkit [179069] by
-
- 7 edits6 adds in trunk
Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=140826
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: svg/animations/use-animate-width-and-height.html
svg/custom/use-attribute-invalidations.html
svg/custom/use-dynamic-attribute-setting.html
This is an adaptation of work Rob Buis did in Blink:
http://src.chromium.org/viewvc/blink?view=revision&revision=173258
The goal here is to reduce use of SVGElementInstance since we are going to
remove it. The tests Rob added to Blink (which I believe I improved a bit here)
meant we had to fix quite a few bugs in the implementation of the width/height
logic rather than just moving it. Even so, this could use even more test coverage
since there is separate logic for <symbol> and <svg>, three different code paths
(animation/attribute setting, initial creation, and one other), and also
distinct issues for attributes not set at all, attributes set to values that
can't be parsed, and attributes set with different units.
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calcViewport): Removed the old logic.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement): Use ASCIILiteral to more efficiently
create strings from ASCII literals here.
(WebCore::SVGSVGElement::parseAttribute): Default to 100%, not 0, when the
width or height property are either not set or not successfully parsed. Without
this change, one of the SVG tests starts failing.
- svg/SVGUseElement.cpp:
(WebCore::updateWidthAndHeight): Added. The tricky part here is that we have
to copy width and height attributes only if they were successfully parsed, and
also we need to copy the current animating values, not the original attribute
strings. Kind of messy, but I wanted to adapt Rob's solution for the time being,
rather than inventing something new.
(WebCore::SVGUseElement::svgAttributeChanged): Call updateWidthAndHeight.
This is used both when actual attribute changes occur and also when animation
changes the current value.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateWidthAndHeight.
This is used when the shadow elements are first created.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Call updateWidthAndHeight.
This was in Rob's patch, but I am not sure we have sufficient test coverage.
LayoutTests:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Old test
result was expecting failure. New one expects success.
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Ditto.
- svg/animations/use-animate-width-and-height-expected.txt: Added.
- svg/animations/use-animate-width-and-height.html: Added.
- svg/custom/use-attribute-invalidations-expected.html: Added.
- svg/custom/use-attribute-invalidations.html: Added.
- svg/custom/use-dynamic-attribute-setting-expected.html: Added.
- svg/custom/use-dynamic-attribute-setting.html: Added.
- 11:14 AM Changeset in webkit [179068] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175976. rdar://problem/19420064
- 10:57 AM Changeset in webkit [179067] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175585. rdar://problem/19419818
- 10:30 AM Changeset in webkit [179066] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged small change from r175549. rdar://problem/19433134
- 9:27 AM Changeset in webkit [179065] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r174860. rdar://problem/19419859
- 9:00 AM Changeset in webkit [179064] by
-
- 3 edits7 adds in branches/safari-600.1.4.15-branch
Merged r175085. rdar://problem/19419853
- 9:00 AM Changeset in webkit [179063] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174356. rdar://problem/19419853
- 9:00 AM Changeset in webkit [179062] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged branch-only patch (r0). rdar://problem/19564738
- 8:28 AM Changeset in webkit [179061] by
-
- 4 edits in trunk/Source
Provide implementation for WTF::DefaultHash<bool>
https://bugs.webkit.org/show_bug.cgi?id=140848
Reviewed by Anders Carlsson.
Source/WebCore:
Use HashMap<std::pair<UChar32, bool>> type in Font.cpp for
CharacterFallbackMap instead of HashMap<std::pair<UChar32, unsigned>>.
It builds now that WTF::DefaultHash<bool> is defined in WTF.
- platform/graphics/Font.cpp:
(WebCore::Font::removeFromSystemFallbackCache):
Source/WTF:
Provide implementation for WTF::DefaultHash<bool> so that we can use
HashMap<std::pair<XXX, bool>> in the code base. Right now, we need to
use some integer type to work around the issue.
- wtf/HashFunctions.h:
Jan 23, 2015:
- 11:05 PM Changeset in webkit [179060] by
-
- 1 edit1 add in trunk/LayoutTests
[Win] Unreviewed gardening. Add Windows baseline for
mouse-cursor-image-set.
- platform/win/fast/events/mouse-cursor-image-set-expected.txt: Added.
- 11:04 PM Changeset in webkit [179059] by
-
- 2 edits in trunk/Source/WebCore
[Win] Cursor assignment operator is skipping scale factor
https://bugs.webkit.org/show_bug.cgi?id=140852
Reviewed by Chris Dumez.
Found by fast/events/mouse-cursor-image-set.html
- platform/win/CursorWin.cpp:
(WebCore::Cursor::operator=): Make sure to also assign the
scale factor.
- 9:36 PM Changeset in webkit [179058] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Attempt to fix the build after AVValueTiming.h moved
- platform/spi/ios/AVKitSPI.h: The AVValueTiming.h header moved
to an unexpected location, so work around it by using local SPI
declarations.
- 9:33 PM Changeset in webkit [179057] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the build after r179056.
- platform/Cursor.h: (WebCore::Cursor::Cursor): Initialize dadat members in correct order.
- 9:26 PM Changeset in webkit [179056] by
-
- 3 edits in trunk/Source/WebCore
[Win] Cursor copy constructor does not initialize scale factor
https://bugs.webkit.org/show_bug.cgi?id=140849
Reviewed by Antti Koivisto.
Found by fast/events/mouse-cursor-image-set.html
Make sure the scale factor is captured during copy construction. Also make sure
it is properly initialized in the default constructor, since it it used in the
Windows port for some default cursors.
- platform/CursorWin.h:
- platform/win/CursorWin.cpp:
(WebCore::Cursor::Cursor): Make sure copy constructor captures
the scale factor.
- 8:15 PM Changeset in webkit [179055] by
-
- 10 edits42 adds in trunk
Add pointer/hover media queries
https://bugs.webkit.org/show_bug.cgi?id=134822
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-23
Reviewed by Antti Koivisto.
Source/WebCore:
Media Queries Level 4 introduces two types of Interaction Media Features:
"pointer" and "hover". Those media features are useful for adapting the design
to the type of input:
This implementation is trivial: just #ifdef the return value depending on
the support for touch events.
In the future we should move that to a client interface but let's start easy
for now.
Tests: fast/media/mq-any-hover-cssom.html
fast/media/mq-any-hover-invalid.html
fast/media/mq-any-hover-matchMedia.html
fast/media/mq-any-hover-styling.html
fast/media/mq-any-pointer-cssom.html
fast/media/mq-any-pointer-invalid.html
fast/media/mq-any-pointer-matchMedia.html
fast/media/mq-any-pointer-styling.html
fast/media/mq-hover-cssom.html
fast/media/mq-hover-invalid.html
fast/media/mq-hover-matchMedia.html
fast/media/mq-hover-styling.html
fast/media/mq-pointer-cssom.html
fast/media/mq-pointer-invalid.html
fast/media/mq-pointer-matchMedia.html
fast/media/mq-pointer-styling.html
- css/CSSValueKeywords.in:
- css/MediaFeatureNames.h:
- css/MediaQueryEvaluator.cpp:
(WebCore::hoverMediaFeatureEval):
(WebCore::any_hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
(WebCore::any_pointerMediaFeatureEval):
(WebCore::leastCapablePrimaryPointerDeviceType): Deleted.
- css/MediaQueryExp.cpp:
(WebCore::featureWithCSSValueID):
(WebCore::featureWithZeroOrOne):
(WebCore::featureWithoutValue):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
- page/Settings.in:
LayoutTests:
- fast/media/mq-any-hover-cssom-expected.txt: Added.
- fast/media/mq-any-hover-cssom.html: Added.
- fast/media/mq-any-hover-invalid-expected.txt: Added.
- fast/media/mq-any-hover-invalid.html: Added.
- fast/media/mq-any-hover-matchMedia-expected.txt: Added.
- fast/media/mq-any-hover-matchMedia.html: Added.
- fast/media/mq-any-hover-styling-expected.txt: Added.
- fast/media/mq-any-hover-styling.html: Added.
- fast/media/mq-any-pointer-cssom-expected.txt: Added.
- fast/media/mq-any-pointer-cssom.html: Added.
- fast/media/mq-any-pointer-invalid-expected.txt: Added.
- fast/media/mq-any-pointer-invalid.html: Added.
- fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
- fast/media/mq-any-pointer-matchMedia.html: Added.
- fast/media/mq-any-pointer-styling-expected.txt: Added.
- fast/media/mq-any-pointer-styling.html: Added.
- fast/media/mq-hover-cssom-expected.txt: Added.
- fast/media/mq-hover-cssom.html: Added.
- fast/media/mq-hover-invalid-expected.txt: Added.
- fast/media/mq-hover-invalid.html: Added.
- fast/media/mq-hover-matchMedia-expected.txt: Added.
- fast/media/mq-hover-matchMedia.html: Added.
- fast/media/mq-hover-styling-expected.txt: Added.
- fast/media/mq-hover-styling.html: Added.
- fast/media/mq-pointer-cssom-expected.txt: Added.
- fast/media/mq-pointer-cssom.html: Added.
- fast/media/mq-pointer-expected.txt:
- fast/media/mq-pointer-invalid-expected.txt: Added.
- fast/media/mq-pointer-invalid.html: Added.
- fast/media/mq-pointer-matchMedia-expected.txt: Added.
- fast/media/mq-pointer-matchMedia.html: Added.
- fast/media/mq-pointer-styling-expected.txt: Added.
- fast/media/mq-pointer-styling.html: Added.
- fast/media/mq-pointer.html:
- platform/ios-simulator/fast/media/mq-any-hover-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-any-hover-styling-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-any-pointer-styling-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-hover-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-hover-styling-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-pointer-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-pointer-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-pointer-styling-expected.txt: Added.
- 7:05 PM Changeset in webkit [179054] by
-
- 20 edits6 deletes in trunk
Unreviewed, rolling out r179051.
https://bugs.webkit.org/show_bug.cgi?id=140850
broke the 32-bit build (Requested by thorton on #webkit).
Reverted changeset:
"[Mac][EME] Support ClearKey encryption with AES128-encrypted
HLS"
https://bugs.webkit.org/show_bug.cgi?id=140825
http://trac.webkit.org/changeset/179051
- 6:34 PM Changeset in webkit [179053] by
-
- 9 edits in trunk/Source
Web Inspector: Rename InjectedScriptHost::type to subtype
https://bugs.webkit.org/show_bug.cgi?id=140841
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-23
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
We were using this to set the subtype of an "object" type RemoteObject
so we should clean up the name and call it subtype.
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptSource.js:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::type): Deleted.
- inspector/JSInjectedScriptHost.h:
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionSubtype):
(Inspector::jsInjectedScriptHostPrototypeFunctionType): Deleted.
Source/WebCore:
- inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::subtype):
(WebCore::WebInjectedScriptHost::type): Deleted.
- inspector/WebInjectedScriptHost.h:
- 6:27 PM Changeset in webkit [179052] by
-
- 3 edits in trunk/Source/WebKit2
Implement cache size limit
https://bugs.webkit.org/show_bug.cgi?id=140844
Reviewed by Andreas Kling.
Prevent the cache from growing without bounds. The simple scheme implemented here
estimates the cache size from number of entries. When the estimated size exceeds
the maximum size we randomly clear 1/4 of the entries.
- NetworkProcess/cache/NetworkCacheStorage.h:
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initialize):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::setMaximumSize):
(WebKit::NetworkCacheStorage::clear):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
(WebKit::NetworkCacheStorage::initializeKeyFilter): Deleted.
- 6:20 PM Changeset in webkit [179051] by
-
- 20 edits3 copies10 adds in trunk
[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS
https://bugs.webkit.org/show_bug.cgi?id=140825
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/clearkey/clear-key-hls-aes128.html
Add support for ClearKey encryption when used with an AES-128 encrypted HLS stream.
- Modules/encryptedmedia/CDM.cpp:
(WebCore::installedCDMFactories): Add the CDMPrivateClearKey factory.
- Modules/encryptedmedia/CDMPrivateClearKey.cpp:
(WebCore::CDMPrivateClearKey::supportsKeySystem): Support the "org.w3c.clearkey" key system.
(WebCore::CDMPrivateClearKey::supportsKeySystemAndMimeType): Ditto.
(WebCore::CDMPrivateClearKey::supportsMIMEType): Ditto.
(WebCore::CDMPrivateClearKey::createSession): Create a CDMSessionClearKey.
- Modules/encryptedmedia/CDMPrivateClearKey.h:
(WebCore::CDMPrivateClearKey::create): Simple factory.
(WebCore::CDMPrivateClearKey::~CDMPrivateClearKey): Virtual destructor.
(WebCore::CDMPrivateClearKey::CDMPrivateClearKey): Simple destructor.
- Modules/encryptedmedia/CDMSessionClearKey.cpp: Added.
(WebCore::clearKeyVM): Static method returning the VM to be used by JSON parsing.
(WebCore::CDMSessionClearKey::CDMSessionClearKey): Simple constructor.
(WebCore::CDMSessionClearKey::~CDMSessionClearKey): Simple destructor.
(WebCore::CDMSessionClearKey::generateKeyRequest): Store the initData, ensure that it consists of a UTF8-encoded key
URI, and return same.
(WebCore::CDMSessionClearKey::releaseKeys): Purged all cached keys.
(WebCore::CDMSessionClearKey::update): Parse raw JSON-encoded JWK keys, rejecting non-AES, non-oct keys.
(WebCore::CDMSessionClearKey::cachedKeyForKeyID): Return cached keys.
- Modules/encryptedmedia/CDMSessionClearKey.h:
Add support for the "org.w3c.clearkey" CDM to MediaPlayerPrivateAVFoundationObjC, and do so in a platform-agnostic
way by simply asking for raw key data from MediaPlayerClient when notified that a key has been added.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::fulfillRequestWithKeyData): Added utility method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::keyAdded):
Pipe a keyAdded() notification down to MediaPlayer and a cachedKeyForKeyId() request up to CDMSessionClearKey:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::cachedKeyForKeyId):
(WebCore::MediaKeySession::addKeyTimerFired):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::keyAdded):
(WebCore::MediaKeys::cachedKeyForKeyId):
- Modules/encryptedmedia/MediaKeys.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::keyAdded):
- html/HTMLMediaElement.h:
- platform/graphics/CDMSession.h:
(WebCore::CDMSession::cachedKeyForKeyID):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::cachedKeyForKeyId):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCachedKeyForKeyId):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::keyAdded):
Add new files to project:
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
LayoutTests:
- http/tests/media/clearkey/clear-key-hls-aes128-expected.txt: Added.
- http/tests/media/clearkey/clear-key-hls-aes128.html: Added.
- http/tests/media/clearkey/support.js: Added.
(stringToUInt8Array):
(uInt8ArrayToString):
(base64EncodeUint8Array):
- http/tests/media/resources/hls/clearkey/crypt0.key: Added.
- http/tests/media/resources/hls/clearkey/iframe_index.m3u8: Added.
- http/tests/media/resources/hls/clearkey/main0.ts: Added.
- http/tests/media/resources/hls/clearkey/prog_index.m3u8: Added.
- media/video-test.js:
(waitForEventOnceOn):
- 5:41 PM Changeset in webkit [179050] by
-
- 15 edits in trunk/Source/WebCore
Implement system fonts FontDescription caching at RenderTheme level
https://bugs.webkit.org/show_bug.cgi?id=140840
Reviewed by Andreas Kling.
Implement system fonts FontDescription caching at RenderTheme level
instead of duplicating the logic in its subclasses for each platform.
This reduces code / logic duplication and reduces the amount of
platform-specific code. This will also make the refactoring at
Bug 140577 a lot easier.
The caching logic remains in RenderThemeIOS class for iOS because:
- It supports different system font values than all other platforms
- It requires cache invalidation in some cases while other platforms do not.
This patch is inspired by the following Blink revision:
https://src.chromium.org/viewvc/blink?view=rev&revision=184449
Test: fast/css/css2-system-fonts.html
- 5:38 PM Changeset in webkit [179049] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening: Correct some typos in Failure entries.
- platform/win/TestExpectations:
- 5:13 PM Changeset in webkit [179048] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Refactor line wrapping logic.
https://bugs.webkit.org/show_bug.cgi?id=140834
Reviewed by Antti Koivisto.
Use a more readable structure to deal with wrapping logic.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::createLineRuns):
- 5:12 PM Changeset in webkit [179047] by
-
- 3 edits in trunk/Source/WebCore
Simple line layout: Use only FlowContents::nextTextFragment() to read fragments from the text flow.
https://bugs.webkit.org/show_bug.cgi?id=140842
Reviewed by Antti Koivisto.
This is in preparation to make FlowContents a content iterator class.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::initializeNewLine):
- rendering/SimpleLineLayoutFlowContents.h:
- 5:05 PM Changeset in webkit [179046] by
-
- 2 edits in trunk/Tools
test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
<http://webkit.org/b/140787>
Reviewed by Daniel Bates.
- Scripts/webkitpy/port/ios.py:
(IOSPort.determine_full_port_name): Instead of checking the type
of the current host, test if /usr/bin/xcrun exists before trying
to use it.
- 5:03 PM Changeset in webkit [179045] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Build fix after r179028, r179030, r179031, r179032.
Reviewed by Dana Burkart.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
- 4:52 PM Changeset in webkit [179044] by
-
- 5 edits2 adds in trunk
[MSE] Implement Range Removal algorithm.
https://bugs.webkit.org/show_bug.cgi?id=140622.
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2015-01-23
Reviewed by Jer Noble.
Source/WebCore:
This extract Range Removal algorithm (Editor's Draft version, bug:26316) from remove(),
to separate function to deal with old FIXME since bug in spec was resolved.
This should both guarantee good order of events, and prevent from switching to 'open' state
during end of stream.
Test: media/media-source/media-source-end-of-stream-readyState.html
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDurationInternal): update to use rangeRemoval(), not remove()
(WebCore::MediaSource::streamEndedWithError): remove FIXME, brigning back correct order of events.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::remove): comments up to spec, extract rangeRemoval algorithm.
(WebCore::SourceBuffer::rangeRemoval):
(WebCore::SourceBuffer::removeTimerFired): comments up to spec.
- Modules/mediasource/SourceBuffer.h:
LayoutTests:
Added short test to check whether endOfStream incorrectly switches back
to 'open' state.
- media/media-source/media-source-end-of-stream-readyState.html: Added.
- media/media-source/media-source-end-of-stream-readyState-expected.txt: Added.
- 4:49 PM Changeset in webkit [179043] by
-
- 2 edits in trunk/Tools
Fix the false positive build failures on the Windows buildbots
https://bugs.webkit.org/show_bug.cgi?id=140819
Reviewed by Brent Fulgham.
Increase the build timeout (without producing output) to 2 hours for Windows bots,
the default 20 minutes is enough for others since they produce output during the build.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildFactory.init):
- 4:48 PM Changeset in webkit [179042] by
-
- 20 edits5 deletes in tags/Safari-600.5.3
Rollout r178466
- 4:45 PM Changeset in webkit [179041] by
-
- 12 edits8 deletes in tags/Safari-600.5.3
Rollout r178467
- 4:43 PM Changeset in webkit [179040] by
-
- 20 edits5 deletes in branches/safari-600.5-branch
Rollout r178466
- 4:38 PM Changeset in webkit [179039] by
-
- 4 edits2 adds in trunk/LayoutTests
[Win] Test gardening. Mark a few failures after filing bugs.
Also rebaseline a few tests.
- platform/win/TestExpectations:
- platform/win/accessibility/parent-element-expected.txt:
- platform/win/editing/input/caret-at-the-edge-of-input-expected.png: Added.
- platform/win/editing/input/caret-at-the-edge-of-input-expected.txt: Added.
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 4:32 PM Changeset in webkit [179038] by
-
- 12 edits8 deletes in branches/safari-600.5-branch
Rollout r178467
- 4:24 PM Changeset in webkit [179037] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard always assigns the result of A/B testing with build request 1
https://bugs.webkit.org/show_bug.cgi?id=140382
Reviewed by Darin Adler.
The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
Also fixed a typo as well as a bug that reports were never associated with builds.
- public/include/report-processor.php:
(ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
instead of the first non-null value.
(ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
(ReportProcessor::commit): Associate the report with the corresponding build as intended.
- 4:21 PM Changeset in webkit [179036] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
- public/admin/tests.php:
- 3:48 PM Changeset in webkit [179035] by
-
- 2 edits in trunk/Source/JavaScriptCore
LayoutTests/js/script-tests/reentrant-caching.js crashing on 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=140843
Reviewed by Oliver Hunt.
When we are in vmEntryToJavaScript, we keep the stack pointer at an
alignment sutiable for pointing to a call frame header, which is the
alignment post making a call. We adjust the sp when calling to JS code,
but don't adjust it before calling the out of stack handler.
- llint/LowLevelInterpreter32_64.asm:
Moved stack point down 8 bytes to get it aligned.
- 3:37 PM Changeset in webkit [179034] by
-
- 5 edits9 copies in branches/safari-600.5-branch
Merged r176354. <rdar://19451336>
- 3:34 PM Changeset in webkit [179033] by
-
- 4 edits in trunk
Source/WebKit/win:
[Win] Teach WebKit to provide IAccessible2 'get_language'
https://bugs.webkit.org/show_bug.cgi?id=140839
Reviewed by Dean Jackson.
- AccessibleBase.cpp:
(AccessibleBase::get_locale): Wrap the Webore::AccessibleObject::language
result in an IA2Locale structure to statisfy the IAccessible2 specification.
Tools:
[Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
https://bugs.webkit.org/show_bug.cgi?id=140839
Reviewed by Dean Jackson.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::language): Retrieve the 'language' BSTR
from the IA2Locale structure and pass it to DRT.
- 3:09 PM Changeset in webkit [179032] by
-
- 11 edits4 copies in branches/safari-600.1.4.15-branch
Merged r174489. rdar://problem/19434944
- 3:06 PM Changeset in webkit [179031] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174373. rdar://problem/19434944
- 3:05 PM Changeset in webkit [179030] by
-
- 8 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174297. rdar://problem/19434944
- 3:04 PM Changeset in webkit [179029] by
-
- 9 edits4 copies in branches/safari-600.5-branch
Merged r174489. <rdar://problem/19452129>
- 3:03 PM Changeset in webkit [179028] by
-
- 42 edits1 copy in branches/safari-600.1.4.15-branch
Merged r174233. rdar://problem/19434944
- 2:16 PM Changeset in webkit [179027] by
-
- 3 edits4 adds in trunk
Hit test returns incorrect results when performed in paginated content over the page gaps.
https://bugs.webkit.org/show_bug.cgi?id=140837
rdar://problem/17494390
Reviewed by Dave Hyatt.
Source/WebCore:
Tests: fast/multicol/pagination/LeftToRight-tb-hittest.html
fast/multicol/pagination/RightToLeft-rl-hittest.html
When hittesting reaches the RenderView we need to check if we are
in paginated content and use the correct class to compute hittest results.
- rendering/RenderView.cpp:
(WebCore::RenderView::updateHitTestResult):
LayoutTests:
- fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
- fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
- fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
- fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.
- 1:57 PM Changeset in webkit [179026] by
-
- 40 edits5 adds12 deletes in trunk/LayoutTests
[Win] Unreviewed gardening after landing r179024.
Update Windows-specific accessibility tests and test expectations after making Windows AX output match Mac.
This allows us to share more Mac results.
- platform/win/TestExpectations:
- platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
- platform/win/accessibility/aria-checkbox-text-expected.txt: Removed.
- platform/win/accessibility/aria-combobox-expected.txt:
- platform/win/accessibility/aria-fallback-roles-expected.txt: Removed.
- platform/win/accessibility/aria-hidden-expected.txt: Removed.
- platform/win/accessibility/aria-labelledby-on-input-expected.txt: Removed.
- platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
- platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
- platform/win/accessibility/aria-list-and-listitem-expected.txt:
- platform/win/accessibility/aria-mappings-expected.txt: Added.
- platform/win/accessibility/aria-menubar-menuitems-expected.txt:
- platform/win/accessibility/aria-option-role-expected.txt:
- platform/win/accessibility/aria-presentational-role-expected.txt: Removed.
- platform/win/accessibility/aria-roles-expected.txt:
- platform/win/accessibility/aria-tab-role-on-buttons-expected.txt:
- platform/win/accessibility/aria-tab-roles-expected.txt:
- platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
- platform/win/accessibility/canvas-description-and-role-expected.txt:
- platform/win/accessibility/canvas-fallback-content-expected.txt:
- platform/win/accessibility/css-content-attribute-expected.txt: Added.
- platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt:
- platform/win/accessibility/div-within-anchors-causes-crash-expected.txt:
- platform/win/accessibility/document-enabled-state-expected.txt:
- platform/win/accessibility/document-enabled-state.html:
- platform/win/accessibility/document-role-expected.txt:
- platform/win/accessibility/heading-elements-expected.txt:
- platform/win/accessibility/heading-elements.html:
- platform/win/accessibility/image-map1-expected.txt: Added.
- platform/win/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/win/accessibility/img-alt-attribute-expected.txt:
- platform/win/accessibility/img-alt-attribute.html:
- platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
- platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
- platform/win/accessibility/img-fallsback-to-title-expected.txt: Removed.
- platform/win/accessibility/input-image-alt-expected.txt: Removed.
- platform/win/accessibility/linked-elements-expected.txt:
- platform/win/accessibility/linked-elements.html:
- platform/win/accessibility/list-item-role-expected.txt:
- platform/win/accessibility/list-item-role.html:
- platform/win/accessibility/list-marker-role-expected.txt:
- platform/win/accessibility/list-marker-role.html:
- platform/win/accessibility/list-role-expected.txt:
- platform/win/accessibility/list-role.html:
- platform/win/accessibility/multiple-select-element-role-expected.txt:
- platform/win/accessibility/multiple-select-element-role.html:
- platform/win/accessibility/parent-element-expected.txt:
- platform/win/accessibility/parent-element.html:
- platform/win/accessibility/select-element-role-expected.txt:
- platform/win/accessibility/select-element-role.html:
- platform/win/accessibility/selection-and-focus-expected.txt:
- platform/win/accessibility/selection-and-focus.html:
- platform/win/accessibility/single-select-children.html:
- platform/win/accessibility/svg-image-expected.txt: Removed.
- platform/win/accessibility/text-role-expected.txt:
- platform/win/aria-labelledby-overrides-aria-label-actual.txt: Added.
- 1:39 PM Changeset in webkit [179025] by
-
- 4 edits in trunk/Source/WebCore
Document should be a FontSelectorClient.
<https://webkit.org/b/140833>
Reviewed by Antti Koivisto.
Make Document a FontSelectorClient so it can listen to the invalidation
callbacks from FontSelector instead of having code in FontSelector that
calls out to Document on invalidation.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
- dom/Document.cpp:
(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::fontSelector):
(WebCore::Document::clearStyleResolver):
- dom/Document.h:
- 1:31 PM Changeset in webkit [179024] by
-
- 2 edits in trunk/Tools
[Win] Update DRT Accessibility implementation to better match Mac.
https://bugs.webkit.org/show_bug.cgi?id=140830
Reviewed by Dean Jackson.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(convertToDRTLabel):
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::isFocused):
- 12:53 PM Changeset in webkit [179023] by
-
- 2 edits in trunk/Source/WebKit2
Fix the pre-Yosemite build.
- UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
- 12:12 PM Changeset in webkit [179022] by
-
- 1 copy in tags/Safari-600.1.4.15.2
New tag.
- 12:10 PM Changeset in webkit [179021] by
-
- 1 copy in tags/Safari-600.5.3
New tag.
- 12:05 PM Changeset in webkit [179020] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source
Versioning.
- 12:05 PM Changeset in webkit [179019] by
-
- 15 edits2 adds in trunk
Web Inspector: Object Previews in the Console
https://bugs.webkit.org/show_bug.cgi?id=129204
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Update the very old, unused object preview code. Part of this comes from
the earlier WebKit legacy implementation, and the Blink implementation.
A RemoteObject may include a preview, if it is asked for, and if the
RemoteObject is an object. Previews are a shallow (single level) list
of a limited number of properties on the object. The previewed
properties are always stringified (even if primatives). Previews are
limited to just 5 properties or 100 indices. Previews are marked
as lossless if they are a complete snapshot of the object.
There is a path to make previews two levels deep, that is currently
unused but should soon be used for tables (e.g. IndexedDB).
- inspector/InjectedScriptSource.js:
- Move some code off of InjectedScript to be generic functions
usable by RemoteObject as well.
- Update preview generation to use
- inspector/protocol/Runtime.json:
- Add a new type, "accessor" for preview objects. This represents
a getter / setter. We currently don't get the value.
Source/WebInspectorUI:
- UserInterface/Controllers/JavaScriptLogViewController.js:
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
- UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.):
Update RuntimeManager callsites that do not need object previews.
- UserInterface/Controllers/RuntimeManager.js:
(WebInspector.RuntimeManager.prototype.evalCallback):
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
Update the main evaluate method to include a boolean parameter for
object previews. Most callers do not need them. Also, since previews
were not available on iOS 6, switch to invoke, to conditionally
include the command parameter.
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get preview):
Store the preview from the payload.
- UserInterface/Views/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
Pass an explicit false for most formatters to not use a preview if available.
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
Currently only object types are previewed. Though we request previews
for arrays, we don't use the preview because we show a better preview
by just immediately requesting for a full non-preview property list.
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
Quickly output an object preview into the title element. The format
is "ClassName {prop: value...}". Elide the class name if it is "Object".
Also skip over certain preview properties that may not be useful
at a glance (like constructor, or accessors without values).
- UserInterface/Views/LogContentView.css:
(.console-object-preview):
(.console-formatted-array .console-object-preview):
(.console-object-preview-lossless):
(.expanded .console-object-preview):
Show lossy previews in italics.
Show lossless previews and array previews without italics.
Do not show the class name in the preview in italics when expanded.
(.console-object-preview .name):
Give preview property names the same color as ObjectPropertiesSection property names.
(.expanded .console-object-preview > .console-object-preview-body):
When expanding an object, hide the preview.
(.console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
(.expanded .console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
For "Object" previews, hide the name "Object" when not expanded, and show it when expanded.
LayoutTests:
- inspector/debugger/command-line-api-exception-nested-catch.html:
- inspector/debugger/command-line-api-exception.html:
- inspector/model/remote-object-get-properties.html:
Update RuntimeManager callsites to not ask for previews when evaluating.
- inspector/model/remote-object-expected.txt: Added.
- inspector/model/remote-object.html: Added.
Add a test specifically for Remote Object. This test can also be
opened in a browser. It attempts to run the gamut of all different
types of objects and shows the RemoteObject constructed for it.
- 12:03 PM Changeset in webkit [179018] by
-
- 5 edits in branches/safari-600.5-branch/Source
Versioning.
- 12:01 PM Changeset in webkit [179017] by
-
- 2 edits in trunk/Source/WebCore
Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=140829
Reviewed by Andreas Kling.
Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
by calling CSSValuePool::createFontFamilyValue() to create the font
family CSSPrimitiveValue instead of cssValuePool().createValue().
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily):
- 11:57 AM Changeset in webkit [179016] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Disable *Annotators on minified files that aren't pretty printed
https://bugs.webkit.org/show_bug.cgi?id=140550
Reviewed by Timothy Hatcher.
When SourceCodeTextEditor speculates that a file is minified it
sets a flag on itself that the Annotators will notice when pretty
printing and turning on type profiling.
SourceCodeTextEditor enforces the following two behaviors:
- Always pretty print a file if we think it's minified while
viewing type annotations. So, while viewing a minified file,
if you press the type profiling button, the pretty printer will
first reformat the file, then the type profiler will insert type annotations.
- If the type profiler is enabled and we're viewing a pretty
printed file that we think originally was minified, and the
pretty printer is disabled via pressing the button, then the
type profiler will also be disabled.
These two behaviors maintain a good user experience because
it prevents a bad visual representation of profiler data and
also prevents bad performance.
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations): Deleted.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.shown):
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._contentWillPopulate):
(WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
- 11:52 AM Changeset in webkit [179015] by
-
- 4 edits in trunk/Source/JavaScriptCore
Immediate crash when setting JS breakpoint
https://bugs.webkit.org/show_bug.cgi?id=140811
Reviewed by Mark Lam.
When the DFG stack layout phase doesn't allocate a register for the scope register,
it incorrectly sets the scope register in the code block to a bad value, one with
an offset of 0. Changed it so that we set the code block's scope register to the
invalid VirtualRegister instead.
No tests needed as adding the ASSERT in setScopeRegister() was used to find the bug.
We crash with that ASSERT in testapi and likely many other tests as well.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setScopeRegister):
(JSC::CodeBlock::scopeRegister):
Added ASSERTs to catch any future improper setting of the code block's scope register.
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- 11:43 AM Changeset in webkit [179014] by
-
- 10 edits in trunk/Source
QLPreviewMenuItem popovers don't close when the page scrolls
https://bugs.webkit.org/show_bug.cgi?id=140806
<rdar://problem/19555618>
Reviewed by Beth Dakin.
Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
- WebView/WebHTMLView.mm:
(-[WebHTMLView scrollWheel:scrollWheel:]):
Send scrollWheel along to WebImmediateActionController.
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webView:didHandleScrollWheel:]):
(-[WebImmediateActionController _clearImmediateActionState]):
(-[WebImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.
- UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
Send _dismissContentRelativeChildWindows on to WKImmediateActionController.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController dismissContentRelativeChildWindows]):
(-[WKImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.
- platform/spi/mac/QuickLookMacSPI.h:
Add some SPI.
- 11:42 AM Changeset in webkit [179013] by
-
- 4 edits in trunk/Source
Infinite recursion in _clearImmediateActionState
https://bugs.webkit.org/show_bug.cgi?id=140807
<rdar://problem/19571601>
Reviewed by Anders Carlsson.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
Clear _hasActivatedActionContext before calling didUseActions, because
didUseActions can call _clearImmediateActionState.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _clearImmediateActionState]):
Use this opportunity to bring identical code to WebKit1, to avoid
getting DataDetectors stuck when an immediate action is canceled.
- 10:44 AM Changeset in webkit [179012] by
-
- 18 edits in trunk/Source/WebCore
Hang CSSFontSelector off Document instead of StyleResolver.
<https://webkit.org/b/140820>
Reviewed by Antti Koivisto.
Move the CSSFontSelector from StyleResolver to Document. This is the first
step towards making the CSSFontSelector be able to survive full style recalc.
Clearing a Document's StyleResolver will still nuke the CSSFontSelector,
though that is done in Document::clearStyleResolver() now.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
- css/CSSFontSelector.h:
Modernize CSSFontSelector construction a bit by having create() return
a Ref and the constructor take a Document& instead of a Document*.
Also made the constructor explicit.
(WebCore::StyleResolver::~StyleResolver):
- dom/Document.cpp:
(WebCore::Document::clearStyleResolver):
Nuke the current CSSFontSelector in clearStyleResolver() instead of
in ~StyleResolver. It's a minor change, but shows the way forward.
Added a FIXME about how CSSFontSelector should eventually survive
this operation.
(WebCore::Document::fontSelector):
- css/FontLoader.cpp:
(WebCore::FontLoader::loadFont):
(WebCore::FontLoader::checkFont):
(WebCore::FontLoader::resolveFontStyle):
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
- css/StyleResolver.h:
(WebCore::StyleResolver::fontSelector): Deleted.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::updateFont):
- dom/Document.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(RenderMenuList::fontSelector):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::fontSelector):
- rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveTree):
Move CSSFontSelector ownership from StyleResolver to Document.
- 10:28 AM Changeset in webkit [179011] by
-
- 2 edits in trunk/LayoutTests
Create a "load and stall" cgi that support byte ranges.
https://bugs.webkit.org/show_bug.cgi?id=140628
Reviewed by Jer Noble.
- http/tests/media/resources/serve-video.php: Add support for "stallOffset", "stallDuration",
and "chunkSize" parameters.
- 10:27 AM Changeset in webkit [179010] by
-
- 2 edits in trunk/Source/WebCore
Layout Test http/tests/media/track-in-band-hls-metadata.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140827
Reviewed by Eric Carlson.
Create the m_metadataTrack by calling prepareMetadataTrack() before deref-ing it.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
- 8:33 AM Changeset in webkit [179009] by
-
- 2 edits in trunk/Source/WTF
[GTK] Add missing null check in some derefGPtr implementations
https://bugs.webkit.org/show_bug.cgi?id=140822
Reviewed by Sergio Villar Senin.
It's missing in GHashTable and GVariant implementations.
- wtf/gobject/GRefPtr.cpp:
(WTF::derefGPtr):
- 6:56 AM Changeset in webkit [179008] by
-
- 3 edits in trunk/Tools
REGRESSION: run-perf-tests --profiler= seems to have broken
https://bugs.webkit.org/show_bug.cgi?id=113528
Reviewed by Daniel Bates.
The problem is that "perf --record" (or the equivalent call for
other profilers) is never called whenever there is a wrapper
option in the port. We should inject the profiler call first
(should it exists) and then use the port wrapper.
- Scripts/webkitpy/port/driver.py:
(Driver._command_wrapper):
- Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.test_profiler_and_wrapper): New unit test.
- 6:30 AM Changeset in webkit [179007] by
-
- 19 edits12 adds in trunk
[GTK] Add initial database process support
https://bugs.webkit.org/show_bug.cgi?id=139491
Reviewed by Sergio Villar Senin.
.:
- Source/cmake/OptionsGTK.cmake: Set WebKit2_DatabaseProcess_OUTPUT_NAME.
Source/WebCore:
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase): Use
WebCore::fileSystemRepresentation() for the database filename,
otherwise sqlite3_open() fails when the filename contains "%2E".
Source/WebKit2:
Add initial support for DatabaseProcess, disabled by default for
now.
- CMakeLists.txt: Add required files to compilation.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.
- DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp: Added.
(main):
- DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp: Added.
(WebKit::DatabaseProcessMainUnix):
- DatabaseProcess/unix/DatabaseProcessMainUnix.h: Added.
- PlatformGTK.cmake: Add required files to compilation.
- Shared/ProcessExecutablePath.h:
- Shared/gtk/KeyedDecoder.cpp: Added.
(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::buildDictionaryFromGVariant):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):
- Shared/gtk/KeyedDecoder.h: Added.
- Shared/gtk/KeyedEncoder.cpp: Added.
(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::encodeDouble):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
(WebKit::KeyedEncoder::finishEncoding):
- Shared/gtk/KeyedEncoder.h: Added.
- Shared/gtk/ProcessExecutablePathGtk.cpp:
(WebKit::executablePathOfDatabaseProcess):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Handle the
DatabaseProcess too.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Add
the unix domain sockets implementation.
Source/WTF:
Add support for using GRefPtr with GVariantBuilder.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
- wtf/gobject/GTypedefs.h:
- 2:33 AM Changeset in webkit [179006] by
-
- 2 edits in trunk/Source/WebCore
Initialization for some member variable of FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=136327
Patch by Byeongha Cho <byeongha.cho@samsung.com> on 2015-01-23
Reviewed by Myles C. Maxfield.
No new tests. There's no functional change.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):
- 2:05 AM Changeset in webkit [179005] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175608. rdar://problem/19395075
- 2:05 AM Changeset in webkit [179004] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175607. rdar://problem/19395075
- 2:05 AM Changeset in webkit [179003] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175595. rdar://problem/19395075
- 2:04 AM Changeset in webkit [179002] by
-
- 6 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175577. rdar://problem/19395075
- 2:04 AM Changeset in webkit [179001] by
-
- 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174885. rdar://problem/19395075
- 2:04 AM Changeset in webkit [179000] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174286. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178999] by
-
- 4 edits3 adds in branches/safari-600.1.4.15-branch/Source
Merged r174250. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178998] by
-
- 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174232. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178997] by
-
- 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174072. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178996] by
-
- 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r172966. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178995] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r173762. rdar://problem/19420088
- 2:04 AM Changeset in webkit [178994] by
-
- 10 edits in branches/safari-600.1.4.15-branch/Source
Merged r173741. rdar://problem/19420088
- 1:18 AM Changeset in webkit [178993] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merged r178680. rdar://problem/19489593
- 1:17 AM Changeset in webkit [178992] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merged r178676. rdar://problem/19489593
- 1:16 AM Changeset in webkit [178991] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merged r178605. rdar://problem/19490114
- 1:14 AM Changeset in webkit [178990] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit2
Merged r178595. rdar://problem/19490114
- 12:52 AM Changeset in webkit [178989] by
-
- 2 edits in trunk/LayoutTests
svg-resource-fragment-identifier-img-src.html is a hidpi reftest, but its -expected.html
counterpart isn't hidpi
https://bugs.webkit.org/show_bug.cgi?id=140815
Reviewed by Simon Fraser.
- svg/css/svg-resource-fragment-identifier-img-src-expected.html: Make the expectation
match its test.
- 12:49 AM Changeset in webkit [178988] by
-
- 2 edits in trunk/Source/WebCore
Rename ChildNodeRemovalNotifier::m_insertionPoint to m_removalPoint
https://bugs.webkit.org/show_bug.cgi?id=140766
Reviewed by Andreas Kling.
ChildNodeRemovalNotifier::ChildNodeRemovalNotifier(...) should take
a node as removal point.
It's probably Copy/Paste from ChildNodeInsertionNotifier::m_insertionPoint.
No new tests. No behavior change.
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
- 12:25 AM Changeset in webkit [178987] by
-
- 5 edits7 deletes in trunk/LayoutTests
Rewrite the fast/css/css2-system-fonts.html test to be more useful on all platforms
https://bugs.webkit.org/show_bug.cgi?id=140810
Reviewed by Andreas Kling.
Make the fast/css/css2-system-fonts.html explicit about the font styles
expected on each platform instead of just Mac.
It also converts the test to be text only as the style information is
now displayed in text format.
This change is in preparation for a refactor of system font handling.
This change is based on the following Blink revision by
<alancutter@chromium.org>:
http://src.chromium.org/viewvc/blink?view=revision&revision=169612
- fast/css/css2-system-fonts.html:
- platform/efl/fast/css/css2-system-fonts-expected.png: Removed.
- platform/efl/fast/css/css2-system-fonts-expected.txt: Removed.
- platform/gtk/fast/css/css2-system-fonts-expected.png: Removed.
- platform/gtk/fast/css/css2-system-fonts-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt:
- platform/mac-mavericks/fast/css/css2-system-fonts-expected.png: Removed.
- platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
- platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Removed.
- platform/mac/fast/css/css2-system-fonts-expected.png: Removed.
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- 12:19 AM Changeset in webkit [178986] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix debug build after r178940
https://bugs.webkit.org/show_bug.cgi?id=140814
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-23
Reviewed by Carlos Garcia Campos.
- platform/graphics/opentype/OpenTypeVerticalData.cpp:
(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs):
Jan 22, 2015:
- 11:31 PM Changeset in webkit [178985] by
-
- 5 edits in branches/safari-600.4-branch/Source
Versioning.
- 11:04 PM Changeset in webkit [178984] by
-
- 4 edits in trunk/Source/JavaScriptCore
EdenCollections unnecessarily visit SmallStrings
https://bugs.webkit.org/show_bug.cgi?id=140762
Reviewed by Geoffrey Garen.
- heap/Heap.cpp:
(JSC::Heap::copyBackingStores): Also added a GCPhase for copying
backing stores, which is a significant portion of garbage collection.
(JSC::Heap::visitSmallStrings): Check to see if we need to visit
SmallStrings based on the collection type.
- runtime/SmallStrings.cpp:
(JSC::SmallStrings::SmallStrings):
(JSC::SmallStrings::visitStrongReferences): Set the fact that we have
visited the SmallStrings since the last modification.
- runtime/SmallStrings.h:
(JSC::SmallStrings::needsToBeVisited): If we're doing a
FullCollection, we need to visit. Otherwise, it depends on whether
we've been visited since the last modification/allocation.
- 10:26 PM Changeset in webkit [178983] by
-
- 3 edits in trunk/Source/WebCore
Simple line layout: Move leading whitespace handling from removeTrailingWhitespace() to initializeNewLine().
https://bugs.webkit.org/show_bug.cgi?id=140757
Reviewed by Antti Koivisto.
Checking if overflowed pre-wrap whitespace needs to be ignored should not be part of the trailing whitespace handling.
Move it to initializeNewLine().
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::preWrap):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
- rendering/SimpleLineLayoutFlowContents.h:
(WebCore::SimpleLineLayout::FlowContents::isLineBreak):
- 9:38 PM Changeset in webkit [178982] by
-
- 6 edits in branches/safari-600.5-branch/Source
Merge r174708. rdar://problem/19451256
- 9:38 PM Changeset in webkit [178981] by
-
- 1 edit3 adds in branches/safari-600.5-branch/LayoutTests
Merge r175264. rdar://problem/19451378
- 8:17 PM Changeset in webkit [178980] by
-
- 10 edits in trunk/Source/WebKit2
[iOS][WK2] Ignore synthetic click initiated on a previous page
https://bugs.webkit.org/show_bug.cgi?id=139556
rdar://problem/18586008
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-22
Reviewed by David Kilzer.
Under the right accumulation of bad luck, a synthetic click could be generated
on a page that never asked for it.
What happened was:
1) Page Foo listen to touch event.
2) In response to touch events, Foo decides to navigate to page Bar
*but* it does not cancel the native gesture recognizers with preventDefault().
3) Page Bar loads.
4) The native gesture recognizer ask us to click, we forward that to the WebProcess
and generate a synthetic mouse event.
-> Bar receives a click.
If you are unlucky enough, it looks like a single tap does a double click.
There are two ways this patch avoids the problem:
First, in the UIProcess, we just cancel the HighlightLongPressGestureRecognizer
on didCommitLoadForMainFrame. This prevents "fast clicks" from accidentally going through.
This is not bullet proof because we get didCommitLoadForMainFrame asynchronously but
killing the timer and gesture seems like a good idea.
Second, we skip any tap command at the WebProcess level when it was issued for
the previous page. This is using the same principle we used for VisibleContentRect:
any input generated before the current layer tree commit is useless for the current page.
We track the commit ID in the UIProcess when we decide to do the tracking or not.
Note that we keep the ID regardless of the tracking state, it does not matter if we have sent
touch events, what matters is what content was on screen when the touch events were handled.
If the user interaction result in a tap, we send the commit ID along the tap commands.
In the WebProcess, we know the actual layer tree commit associated with the current page.
If the tap was generated with a layer ID preceding the current page, we fail the command.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::resetState):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _didCommitLoadForMainFrame]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _attemptClickAtLocation:]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::commitPotentialTap):
(WebKit::WebPageProxy::handleTap):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCommitLoad):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleTap):
(WebKit::WebPage::commitPotentialTap):
- 8:06 PM Changeset in webkit [178979] by
-
- 2 edits in trunk/Tools
configure-xcode-for-ios-development needs to import webkitdirs.pm
<http://webkit.org/b/140704>
Fixes the following runtime error:
Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
- Scripts/configure-xcode-for-ios-development: Add back code to
import webkitdirs.pm for the exitStatus() method. Not sure why
I removed it before patch review.
- 7:32 PM Changeset in webkit [178978] by
-
- 3 edits2 deletes in trunk/Source/WebKit
Remove unused class EmojiFallbackFontSelector.
<https://webkit.org/b/140809>
Reviewed by Antti Koivisto.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/ios:
This class no longer has any clients.
- Misc/EmojiFallbackFontSelector.cpp: Removed.
- Misc/EmojiFallbackFontSelector.h: Removed.
- 6:21 PM Changeset in webkit [178977] by
-
- 6 edits in branches/safari-600.5-branch/Source/WebCore
Merged r178967. <rdar://19572776>
- 6:17 PM Changeset in webkit [178976] by
-
- 1 edit2 adds in trunk/LayoutTests
Import fast/css/font-shorthand-line-height.html layout test from Blink
https://bugs.webkit.org/show_bug.cgi?id=140801
Reviewed by Andreas Kling.
Import fast/css/font-shorthand-line-height.html layout test from Blink
to get better test coverage for 'line-height' font shorthands cascades:
https://src.chromium.org/viewvc/blink?view=rev&revision=184346
I am working on expanding the font shorthand at parsing time (like
other shorthands) via Bug 140577 and I want to make sure I don't break
line-height in the process.
- fast/css/font-shorthand-line-height-expected.txt: Added.
- fast/css/font-shorthand-line-height.html: Added.
- 5:57 PM Changeset in webkit [178975] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][Cocoa] Drop WKWebViewConfiguration._featureCounterEnabled SPI.
https://bugs.webkit.org/show_bug.cgi?id=140799
Reviewed by Dan Bernstein.
Drop WKWebViewConfiguration._featureCounterEnabled SPI now that the
client-side has been updated.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]):
(-[WKWebViewConfiguration _featureCounterEnabled]): Deleted.
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 5:28 PM Changeset in webkit [178974] by
-
- 1 copy in tags/Safari-600.4.3
New tag.
- 5:19 PM Changeset in webkit [178973] by
-
- 2 edits in trunk/Source/WebKit2
Fix ENABLE(NETWORK_CACHE) build
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishLoading):
- 5:16 PM Changeset in webkit [178972] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Unreviewed test fix after r178965.
- WebView.cpp: Supply missing implementation of 'setEditable'. It
currently asserts, causing all debug tests to fail.
- 4:47 PM Changeset in webkit [178971] by
-
- 2 edits in trunk/Tools
REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
https://bugs.webkit.org/show_bug.cgi?id=140795
Reviewed by Jon Honeycutt.
- BuildSlaveSupport/build.webkit.org-config/config.json:
r178847 accidentally remove the scheduler for this bot. Re-add it to the
Yosemite scheduler.
- 4:44 PM Changeset in webkit [178970] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: ResourceContentView.js incorrectly contains call to WebInspector.UIString with a variable parameter
https://bugs.webkit.org/show_bug.cgi?id=140268
Reviewed by Timothy Hatcher.
UIString no longer incorrectly used around variables. Drive-by fixes to prototype inheritance style.
Use of Promises corrected such that requesting content for a resource resolves rather than rejects if
a resource can't be found or has another error that isn't a web inspector error.
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/Models/Resource.js: Change reject to resolve.
- UserInterface/Models/Script.js:
(WebInspector.Script.prototype.requestContentFromBackend): Proper use of Error object.
- UserInterface/Models/SourceCode.js: Use correct inheritance style.
- UserInterface/Views/ResourceContentView.js:
(WebInspector.ResourceContentView.prototype._contentAvailable): Handle error now that promise resolves.
(WebInspector.ResourceContentView.prototype._contentError): Remove incorrect use of UIString.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype._contentAvailable): Handle error now that promise resolves.
- 4:31 PM Changeset in webkit [178969] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Media controls disappear when loading a HLS live stream
https://bugs.webkit.org/show_bug.cgi?id=140792
rdar://problem/19491658
Reviewed by Dean Jackson.
Overload reconnectControls to reconnect the "start playback" button
if the control type has been set to "StartPlaybackButton".
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.reconnectControls):
- 4:18 PM Changeset in webkit [178968] by
-
- 5 edits in trunk/Source
[Win] No plugin content on some sites.
https://bugs.webkit.org/show_bug.cgi?id=140780
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-22
Reviewed by Anders Carlsson.
Source/WebCore:
Return script instance from ScriptController::createScriptInstanceForWidget(),
instead of always returning null.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::createScriptInstanceForWidget):
- plugins/PluginViewBase.h:
(WebCore::PluginViewBase::bindingInstance):
Source/WebKit/win:
Add override modifier to bindingInstance method.
- Plugins/PluginView.h:
- 4:17 PM Changeset in webkit [178967] by
-
- 6 edits in trunk/Source/WebCore
[Mac][EME] Adopt changes to AVStreamSession class methods
https://bugs.webkit.org/show_bug.cgi?id=140778
rdar://problem/19458200
Reviewed by Eric Carlson.
AVStreamSession class methods have added a "storageDirectoryAtURL:" parameter so as to be able to
read and modify records stored at non-default storage locations.
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::mediaKeysStorageDirectory): Implement client method by querying document and settings.
- Modules/encryptedmedia/MediaKeySession.h:
- platform/graphics/CDMSession.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::releaseKeys): Check whether the AVStreamSession class responds to new selector before calling.
(WebCore::CDMSessionMediaSourceAVFObjC::update): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyReleaseMessage): Ditto.
(WebCore::CDMSessionMediaSourceAVFObjC::storagePath): Fetch the storage path from the client.
- 4:15 PM Changeset in webkit [178966] by
-
- 3 edits2 adds in trunk
REGRESSION (174847): can't view NHK(Japan's national public broadcasting organization)’s news pages
https://bugs.webkit.org/show_bug.cgi?id=140794
Reviewed by Anders Carlsson.
Source/WebCore:
If a document.open has been set, return it instead of always returning a new,
non-cached instance of jsHTMLDocumentPrototypeFunctionOpen.
Test: js/dom/document-overwrite-open.html
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):
LayoutTests:
- js/dom/document-overwrite-open-expected.txt: Added.
- js/dom/document-overwrite-open.html: Added.
- 3:46 PM Changeset in webkit [178965] by
-
- 11 edits in trunk
[Win] Expose missing editing features through WebView interface
https://bugs.webkit.org/show_bug.cgi?id=140773
<rdar://problem/19565421>
Reviewed by Dean Jackson.
Connect the various WebView editing delegate methods to our
test infrastructure. Also prefer _bstr_t to raw BSTR types
to simplify life cycle management.
Source/WebKit/win:
- DOMCoreClasses.cpp: Flesh out the DOMRange object.
(DOMElement::createInstance):
(DOMRange::QueryInterface):
(DOMRange::DOMRange):
(DOMRange::~DOMRange):
(DOMRange::createInstance):
(DOMRange::startContainer):
(DOMRange::startOffset):
(DOMRange::endContainer):
(DOMRange::endOffset):
(DOMRange::collapsed):
(DOMRange::commonAncestorContainer):
(DOMRange::setStart):
(DOMRange::setEnd):
(DOMRange::setStartBefore):
(DOMRange::setStartAfter):
(DOMRange::setEndBefore):
(DOMRange::setEndAfter):
(DOMRange::collapse):
(DOMRange::selectNode):
(DOMRange::selectNodeContents):
(DOMRange::compareBoundaryPoints):
(DOMRange::deleteContents):
(DOMRange::extractContents):
(DOMRange::cloneContents):
(DOMRange::insertNode):
(DOMRange::surroundContents):
(DOMRange::cloneRange):
(DOMRange::toString):
(DOMRange::detach):
- DOMCoreClasses.h:
(DOMRange::AddRef):
(DOMRange::Release):
(DOMRange::throwException):
(DOMRange::callWebScriptMethod):
(DOMRange::evaluateWebScript):
(DOMRange::removeWebScriptKey):
(DOMRange::stringRepresentation):
(DOMRange::webScriptValueAtIndex):
(DOMRange::setWebScriptValueAtIndex):
(DOMRange::setException):
- Interfaces/IWebEditingDelegate.idl:
- Interfaces/IWebView.idl:
- WebCoreSupport/WebEditorClient.cpp: Connect more methods
to actual editing features in WebCore.
(WebEditorClient::shouldBeginEditing):
(WebEditorClient::shouldEndEditing):
(WebEditorClient::didBeginEditing):
(WebEditorClient::respondToChangedContents):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::didEndEditing):
(WebEditorClient::shouldDeleteRange):
(WebEditorClient::shouldInsertNode):
(WebEditorClient::shouldInsertText):
(WebEditorClient::shouldChangeSelectedRange):
(WebEditorClient::webViewDidChangeTypingStyle):
(WebEditorClient::webViewDidChangeSelection):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):
- WebView.cpp:
(WebView::setEditingDelegate): Added.
Tools:
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
- DumpRenderTree/win/EditingDelegate.cpp:
(EditingDelegate::QueryInterface):
(dumpPath):
(dump):
(EditingDelegate::shouldBeginEditingInDOMRange):
(EditingDelegate::shouldEndEditingInDOMRange):
(EditingDelegate::shouldInsertNode):
(EditingDelegate::shouldInsertText):
(EditingDelegate::shouldDeleteDOMRange):
(EditingDelegate::shouldChangeSelectedDOMRange):
(EditingDelegate::shouldApplyStyle):
(EditingDelegate::shouldChangeTypingStyle):
(EditingDelegate::doPlatformCommand):
(EditingDelegate::webViewDidBeginEditing):
(EditingDelegate::webViewDidChange):
(EditingDelegate::webViewDidEndEditing):
(EditingDelegate::webViewDidChangeTypingStyle):
(EditingDelegate::webViewDidChangeSelection):
(EditingDelegate::checkSpellingOfString):
(EditingDelegate::onNotify):
- DumpRenderTree/win/EditingDelegate.h:
- 3:42 PM Changeset in webkit [178964] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Reset LineState when starting a new line.
https://bugs.webkit.org/show_bug.cgi?id=140789
Reviewed by Antti Koivisto.
Reset LineState when starting a new line to ensure we always
start with a clean state.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::updateLineConstrains):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::createTextRuns):
- 3:35 PM Changeset in webkit [178963] by
-
- 12 edits15 adds in trunk
[WebGL2] Create empty interface files for new WebGL2 objects.
https://bugs.webkit.org/show_bug.cgi?id=140779.
<rdar://problem/15002288>
Reviewed by Dean Jackson.
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/WebGLQuery.cpp: Added.
(WebCore::WebGLQuery::create):
(WebCore::WebGLQuery::~WebGLQuery):
(WebCore::WebGLQuery::WebGLQuery):
(WebCore::WebGLQuery::deleteObjectImpl):
- html/canvas/WebGLQuery.h: Added.
- html/canvas/WebGLQuery.idl: Added.
- html/canvas/WebGLSampler.cpp: Added.
(WebCore::WebGLSampler::create):
(WebCore::WebGLSampler::~WebGLSampler):
(WebCore::WebGLSampler::WebGLSampler):
(WebCore::WebGLSampler::deleteObjectImpl):
- html/canvas/WebGLSampler.h: Added.
- html/canvas/WebGLSampler.idl: Added.
- html/canvas/WebGLSharedObject.h:
(WebCore::WebGLSharedObject::isQuery):
(WebCore::WebGLSharedObject::isSampler):
(WebCore::WebGLSharedObject::isSync):
(WebCore::WebGLSharedObject::isTransformFeedback):
(WebCore::WebGLSharedObject::isVertexArrayObject):
- html/canvas/WebGLSync.cpp: Added.
(WebCore::WebGLSync::create):
(WebCore::WebGLSync::~WebGLSync):
(WebCore::WebGLSync::WebGLSync):
(WebCore::WebGLSync::deleteObjectImpl):
- html/canvas/WebGLSync.h: Added.
- html/canvas/WebGLSync.idl: Added.
- html/canvas/WebGLTransformFeedback.cpp: Added.
(WebCore::WebGLTransformFeedback::create):
(WebCore::WebGLTransformFeedback::~WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::WebGLTransformFeedback):
(WebCore::WebGLTransformFeedback::deleteObjectImpl):
- html/canvas/WebGLTransformFeedback.h: Added.
- html/canvas/WebGLTransformFeedback.idl: Added.
- html/canvas/WebGLVertexArrayObject.cpp: Added.
(WebCore::WebGLVertexArrayObject::create):
(WebCore::WebGLVertexArrayObject::~WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject):
(WebCore::WebGLVertexArrayObject::deleteObjectImpl):
- html/canvas/WebGLVertexArrayObject.h: Added.
- html/canvas/WebGLVertexArrayObject.idl: Added.
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 3:35 PM Changeset in webkit [178962] by
-
- 2 edits in tags/Safari-601.1.15.1/Source/WebKit2
Merged r178958. rdar://problem/19438402
- 3:34 PM Changeset in webkit [178961] by
-
- 2 edits in trunk/WebKitLibraries
[iOS] Fix build for external iphoneos SDK
Reviewed by Daniel Bates.
- WebKitSystemInterface.h: Remove import of the
<IOSurface/IOSurface.h> header, and add a typedef for
IOSurfaceRef in its place.
- 3:32 PM Changeset in webkit [178960] by
-
- 5 edits in tags/Safari-601.1.15.1/Source
Versioning.
- 3:30 PM Changeset in webkit [178959] by
-
- 1 copy in tags/Safari-601.1.15.1
New tag.
- 3:21 PM Changeset in webkit [178958] by
-
- 2 edits in trunk/Source/WebKit2
UserData decoding of WKTypeRefWrapper always fails
https://bugs.webkit.org/show_bug.cgi?id=140791
<rdar://problem/19438402>
Reviewed by Anders Carlsson.
- Shared/mac/ObjCObjectGraph.mm:
(WebKit::ObjCObjectGraph::decode):
Add a missing break.
- 3:20 PM Changeset in webkit [178957] by
-
- 2 edits in trunk/LayoutTests
Skip another copy of oes-vertex-array-object test, because it has the same problems
as the old one.
- platform/mac/TestExpectations:
- 3:16 PM Changeset in webkit [178956] by
-
- 18 edits12 adds1 delete in trunk/LayoutTests
[Win] Unreviewed test gardening.
Clean up editing-related tests and rebaseline some output.
- platform/win/TestExpectations:
- platform/win/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/win/editing/input/reveal-caret-of-multiline-input-expected.txt:
- platform/win/editing/inserting/4960120-1-expected.txt:
- platform/win/editing/inserting/break-blockquote-after-delete-expected.txt:
- platform/win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
- platform/win/editing/pasteboard/4641033-expected.txt: Added.
- platform/win/editing/pasteboard/4944770-1-expected.txt: Added.
- platform/win/editing/pasteboard/4944770-2-expected.txt: Added.
- platform/win/editing/pasteboard/drop-text-without-selection-expected.txt: Added.
- platform/win/editing/selection/3690703-2-expected.txt:
- platform/win/editing/selection/3690703-expected.txt:
- platform/win/editing/selection/3690719-expected.txt:
- platform/win/editing/selection/4975120-expected.txt: Added.
- platform/win/editing/selection/5240265-expected.txt:
- platform/win/editing/selection/caret-before-select-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-2-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-2-left-expected.txt:
- platform/win/editing/selection/caret-rtl-expected.txt: Added.
- platform/win/editing/selection/caret-rtl-right-expected.txt:
- platform/win/editing/selection/drag-select-1-expected.txt: Added.
- platform/win/editing/selection/mixed-editability-10-expected.txt:
- platform/win/editing/selection/replaced-boundaries-3-expected.txt: Added.
- platform/win/editing/selection/select-box-expected.txt: Added.
- platform/win/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
- platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
- platform/win/editing/selection/selection-button-text-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
- platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
- platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- 3:13 PM Changeset in webkit [178955] by
-
- 2 edits in trunk/Source/WebCore
Fix remaining multiple targets per rule issues in DerivedSources.make
https://bugs.webkit.org/show_bug.cgi?id=140790
Reviewed by David Kilzer.
Fix remaining multiple target per rule issues in DerivedSources.make,
similarly to Bug 140784 and Bug 140756.
This was causing us to run scripts several times to generate the same
files and may lead to malformed files in case of concurrency.
- DerivedSources.make:
- 3:12 PM Changeset in webkit [178954] by
-
- 17 edits in trunk
Add a build flag for ES6 class syntax
https://bugs.webkit.org/show_bug.cgi?id=140760
Reviewed by Michael Saboff.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Added ES6_CLASS_SYNTAX build flag and used it in tokenizer to recognize
"class", "extends", "static" and "super" keywords.
- Configurations/FeatureDefines.xcconfig:
- parser/Keywords.table:
- parser/ParserTokens.h:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 3:09 PM Changeset in webkit [178953] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip flakey inspector test.
- 2:23 PM Changeset in webkit [178952] by
-
- 2 edits in trunk/Source/WebCore
SVGNames.cpp and HTMLNames.cpp are sometimes malformed
https://bugs.webkit.org/show_bug.cgi?id=140784
<rdar://problem/17701233>
Reviewed by David Kilzer.
Due to bad rules in DerivedSources.make, make_names.pl was called
several times with the same arguments during build. This is because
SVG/HTML/MathML each had several targets associated to the same
command. This would cause the command (make_names.pl) to be called
once per target. However, make_names.pl only needs to be executed
once to generate all of the files currently marked as target.
Calling make_names.pl several times for the same files is not only
wasteful, but it can also lead to malformed generated files if the
scripts instances are executed in parallel as they will read / write
from / to the same files.
This patch uses INTERMEDIATE targets instead so that we can still
indicate which files are generated by make_names.pl but only run
the script once.
This is a similar fix as for Bug 140756. There may several other
similar issues in DerivedSources.make but this patch focuses on
make_names.pl. I will take care of other in follow-ups if needed.
- DerivedSources.make:
- 2:21 PM Changeset in webkit [178951] by
-
- 4 edits in trunk/Source/WebCore
Have Counter::create() return a Ref<Counter>
https://bugs.webkit.org/show_bug.cgi?id=140777
Reviewed by Andreas Kling.
Have Counter::create() return a Ref<Counter> instead of a PassRefPtr.
The CSSPrimitiveValue class needed some updates as well to support
constructing a CSSPrimitiveValue object from a Ref<>.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/Counter.h:
(WebCore::Counter::create):
(WebCore::Counter::cloneForCSSOM):
- 2:20 PM Changeset in webkit [178950] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r178426. rdar://problem/19526069
- 2:19 PM Changeset in webkit [178949] by
-
- 21 edits4 deletes in trunk/Source
Drop the legacy FeatureCounter class
https://bugs.webkit.org/show_bug.cgi?id=140749
Reviewed by Andreas Kling.
Drop the legacy FeatureCounter class and use DiagnosticLoggingClient
instead.
Source/WebCore:
- CMakeLists.txt:
- Configurations/WebCore.xcconfig:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::mustRevalidateDueToCacheHeaders):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::logMemoryCacheResourceRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::determineRevalidationPolicy):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mustRevalidateIsExpiredKey):
(WebCore::DiagnosticLoggingKeys::playedKey):
(WebCore::DiagnosticLoggingKeys::noCacheKey):
(WebCore::DiagnosticLoggingKeys::noStoreKey):
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::mediaKey):
(WebCore::DiagnosticLoggingKeys::isExpiredKey):
(WebCore::DiagnosticLoggingKeys::loadingKey):
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::reasonKey):
(WebCore::DiagnosticLoggingKeys::audioKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
(WebCore::DiagnosticLoggingKeys::resourceRequestKey):
(WebCore::DiagnosticLoggingKeys::revalidatingKey):
(WebCore::DiagnosticLoggingKeys::unusedKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
(WebCore::DiagnosticLoggingKeys::usedKey):
(WebCore::DiagnosticLoggingKeys::userKey):
(WebCore::DiagnosticLoggingKeys::videoKey):
(WebCore::DiagnosticLoggingKeys::webViewKey):
(WebCore::DiagnosticLoggingKeys::zoomedKey):
- page/DiagnosticLoggingKeys.h:
- page/Settings.in:
- platform/FeatureCounter.cpp: Removed.
- platform/FeatureCounter.h: Removed.
- platform/FeatureCounterKeys.h: Removed.
- platform/ios/FeatureCounter.mm: Removed.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _featureCounterEnabled]):
(-[WKWebViewConfiguration _setFeatureCounterEnabled:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::willStartUserTriggeredZooming):
- 2:17 PM Changeset in webkit [178948] by
-
- 2 edits in trunk/Source/WebCore
When extending the fallback transitions with their closure, we are modifying the Set while iterating it
https://bugs.webkit.org/show_bug.cgi?id=140785
Reviewed by Andreas Kling.
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::populateTransitions):
Make that in two steps: accumulate the fallback transitions then add the closure
of every element.
- 2:16 PM Changeset in webkit [178947] by
-
- 5 edits5 adds in branches/safari-600.5-branch
Merge r178038. rdar://problem/19451263
- 2:16 PM Changeset in webkit [178946] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merge r177611. rdar://problem/19451361
- 2:16 PM Changeset in webkit [178945] by
-
- 1 edit5 adds in branches/safari-600.5-branch/LayoutTests
Merge r177408. rdar://problem/19451330
- 2:16 PM Changeset in webkit [178944] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r177360. rdar://problem/19451319
- 2:13 PM Changeset in webkit [178943] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290
- http/tests/appcache/404-resource-with-slow-main-resource.php: Try updating the
tiemout, as it's not sufficient for appcache load to fail on some bots.
- http/tests/appcache/404-resource-with-slow-main-resource.php:
- 2:02 PM Changeset in webkit [178942] by
-
- 3 edits5 adds in branches/safari-600.5-branch
Merge r177292. rdar://problem/19452139
- 2:02 PM Changeset in webkit [178941] by
-
- 18 edits in branches/safari-600.5-branch/Source
Merge r177152. rdar://problem/19451288
- 1:57 PM Changeset in webkit [178940] by
-
- 118 edits2 moves in trunk/Source
Rename SimpleFontData to Font
https://bugs.webkit.org/show_bug.cgi?id=140496
Reviewed by Zalan Bujtas.
The fallback supporting Font type was renamed FontCascade.
We can now rename SimpleFontData to Font matching the usual definition.
- 1:54 PM Changeset in webkit [178939] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Make trailing whitespace handling more explicit.
https://bugs.webkit.org/show_bug.cgi?id=140776
Reviewed by Antti Koivisto.
Differentiate between committed and uncommitted trailing whitespace.
This enables further cleanup in removeTrailingWhitespace().
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun):
(WebCore::SimpleLineLayout::LineState::addUncommitted):
(WebCore::SimpleLineLayout::LineState::hasWhitespaceOnly):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::LineState::LineState): Deleted.
(WebCore::SimpleLineLayout::LineState::removeCommittedTrailingWhitespace): Deleted.
(WebCore::SimpleLineLayout::LineState::resetTrailingWhitespace): Deleted.
- 1:40 PM Changeset in webkit [178938] by
-
- 6 edits in trunk/Source
ibtoold crash below -[WebView close]
https://bugs.webkit.org/show_bug.cgi?id=140782
-and corresponding-
rdar://problem/19558472
Reviewed by Tim Horton.
Retain the NSImmediateActionGestureRecognizer. This should not be necessary, but
Source/WebKit/mac:
it is because interface builder is messing with our views.
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController _cancelImmediateAction]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController _updateImmediateActionItem]):
Source/WebKit2:
it is because interface builder can mess with our views.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _cancelImmediateAction]):
(-[WKImmediateActionController _cancelImmediateActionIfNeeded]):
(-[WKImmediateActionController _updateImmediateActionItem]):
- 1:04 PM Changeset in webkit [178937] by
-
- 6 edits2 adds in trunk
Crash in URL::protocol() after appcache load fails
https://bugs.webkit.org/show_bug.cgi?id=140755
rdar://problem/7881290
Reviewed by Dan Bates.
Source/WebCore:
Test: http/tests/appcache/404-resource-with-slow-main-resource.php
Not every cache that isn't being updated is complete. It could also be in a zombie
state after failing to load. We get rid of the cache once the main resource finishes
loading, but while it's being loaded, the zombie still looks like a regular
candidate application cache.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::isComplete):
- loader/appcache/ApplicationCache.h:
Removed const from isComplete(), because otherwise we couldn't use ApplicationCacheGroup::m_caches.contains().
Constness doesn't make a lot of sense for these objects anyway.
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::failedLoadingMainResource): Toned down an assertion.
We can fail a main resource load when the document has a zombie appcache, too.
- loader/appcache/ApplicationCacheGroup.h:
(WebCore::ApplicationCacheGroup::cacheIsComplete):
(WebCore::ApplicationCacheGroup::cacheIsBeingUpdated): Deleted.
These functions are only used in ApplicationCache::isComplete().
LayoutTests:
- http/tests/appcache/404-resource-with-slow-main-resource-expected.txt: Added.
- http/tests/appcache/404-resource-with-slow-main-resource.php: Added.
- 12:35 PM Changeset in webkit [178936] by
-
- 3 edits5 adds in branches/safari-600.5-branch
Merge r177033. rdar://problem/19451244
- 12:34 PM Changeset in webkit [178935] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merge r177011. rdar://problem/19451253
- 12:34 PM Changeset in webkit [178934] by
-
- 2 edits in branches/safari-600.5-branch/Source/WTF
Merge r176982. rdar://problem/19452174
- 12:34 PM Changeset in webkit [178933] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176971. rdar://problem/19452174
- 12:34 PM Changeset in webkit [178932] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176768. rdar://problem/19451369
- 12:03 PM Changeset in webkit [178931] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r176285. rdar://problem/19452164
- 12:01 PM Changeset in webkit [178930] by
-
- 2 edits in trunk/Source/WebCore
Avoid defining always empty Vector<TextCheckingResult>
https://bugs.webkit.org/show_bug.cgi?id=140765
Reviewed by Alexey Proskuryakov.
Pass an empty vector direclty instead.
No new tests. No behavior change.
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheckCancel):
- 11:38 AM Changeset in webkit [178929] by
-
- 2 edits in trunk/Source/WebCore
makeprop.pl script is called too many times during build
https://bugs.webkit.org/show_bug.cgi?id=140756
<rdar://problem/19467942>
Reviewed by David Kilzer.
The makeprop.pl script was called 4 times (instead of once) during
build due to a bad Makefile rule in DerivedSources.make. makeprop.pl
had 4 associated targets and thus was called 4 times (with the same
parameter). Calling it once is sufficient to generate all 4 files
that were marked as target. This patch uses an INTERMEDIATE target
instead so that we can indicate that several files are generated
by the same command.
I believe this may be the reason for the sporatic build failures
that look like:
"""
CSSPropertyNames.gperf: No keywords in input file!
calling gperf failed: 256 at WebCore/css/makeprop.pl line 1036.
"""
The makeprop.pl script is generating gperf's input file and calling the
gperf executable on this file. If the script is executed several times
in parallel, it would explain the build failures as several instances
of makeprop.pl may be writing / reading from the same
CSSPropertyNames.gperf file.
- DerivedSources.make:
- 11:34 AM Changeset in webkit [178928] by
-
- 31 edits3 deletes in trunk
Unreviewed, rolling out r178894.
https://bugs.webkit.org/show_bug.cgi?id=140775
Broke JSC and bindings tests (Requested by ap_ on #webkit).
Reverted changeset:
"put_by_val_direct need to check the property is index or not
for using putDirect / putDirectIndex"
https://bugs.webkit.org/show_bug.cgi?id=140426
http://trac.webkit.org/changeset/178894
- 11:27 AM Changeset in webkit [178927] by
-
- 9 edits2 copies1 add in trunk/Source
[iOS] Fix iphoneos SDK builds for ios-ews queue
<http://webkit.org/b/140748>
Reviewed by Daniel Bates.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Add new SPI headers.
- platform/graphics/cg/ImageBufferCG.cpp: Switch to using
"IOSurfaceSPI.h" from <IOSurface/IOSurface.h>.
- platform/graphics/cg/ImageBufferDataCG.cpp: Ditto.
- platform/graphics/cocoa/IOSurface.mm: Ditto. Move definitions
in <IOSurface/IOSurfacePrivate.h> into "IOSurfaceSPI.h".
- platform/spi/cg/CoreGraphicsSPI.h: Switch to
WTF_EXTERN_C_{BEGIN,END}. Add
CGContextGetFontAntialiasingStyle() and
CGContextSetFontAntialiasingStyle().
- platform/spi/cocoa/IOPMLibSPI.h: Switch to use IOReturnSPI.h.
- platform/spi/cocoa/IOReturnSPI.h: Add.
- platform/spi/cocoa/IOSurfaceSPI.h: Add.
- platform/spi/cocoa/IOTypesSPI.h: Add.
Source/WebKit2:
- Platform/spi/ios/BKSProcessAssertionSPI.h: Add -invalidate
definition. Sort @property to the top of BKSProcessAssertion.
- 11:05 AM Changeset in webkit [178926] by
-
- 5 edits3 adds in trunk
BytecodeGenerator::initializeCapturedVariable() sets a misleading value for the 5th operand of op_put_to_scope.
<https://webkit.org/b/140743>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
BytecodeGenerator::initializeCapturedVariable() was setting the 5th operand to
op_put_to_scope to an inappropriate value (i.e. 0). As a result, the execution
of put_to_scope could store a wrong inferred value into the VariableWatchpointSet
for which ever captured variable is at local index 0. In practice, this turns
out to be the local for the Arguments object. In this reproduction case in the
bug, the wrong inferred value written there is the boolean true.
Subsequently, DFG compilation occurs and CreateArguments is emitted to first do
a check of the local for the Arguments object. But because that local has a
wrong inferred value, the check always discovers a non-null value and we never
actually create the Arguments object. Immediately after this, an OSR exit
occurs leaving the Arguments object local uninitialized. Later on at arguments
tear off, we run into a boolean true where we had expected to find an Arguments
object, which in turn, leads to the crash.
The fix is to:
- In the case where the resolveModeType is LocalClosureVar, change the 5th operand of op_put_to_scope to be a boolean. True means that the local var is watchable. False means it is not watchable. We no longer pass the local index (instead of true) and UINT_MAX (instead of false).
This allows us to express more clearer in the code what that value means,
as well as remove the redundant way of getting the local's identifier.
The identifier is always the one passed in the 2nd operand.
- Previously, though intuitively, we know that the watchable variable identifier should be the same as the one that is passed in operand 2, this relationship was not clear in the code. By code analysis, I confirmed that the callers of BytecodeGenerator::emitPutToScope() always use the same identifier for operand 2 and for filling out the ResolveScopeInfo from which we get the watchable variable identifier later. I've changed the code to make this clear now by always using the identifier passed in operand 2.
- In the case where the resolveModeType is LocalClosureVar, initializeCapturedVariable() and emitPutToScope() will now query hasWatchableVariable() to determine if the local is watchable or not. Accordingly, we pass the boolean result of hasWatchableVariable() as operand 5 of op_put_to_scope.
Also added some assertions.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::initializeCapturedVariable):
(JSC::BytecodeGenerator::hasConstant):
(JSC::BytecodeGenerator::emitPutToScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::hasWatchableVariable):
(JSC::BytecodeGenerator::watchableVariableIdentifier):
(JSC::BytecodeGenerator::watchableVariable): Deleted.
LayoutTests:
- js/dfg-osr-exit-between-create-and-tearoff-arguments-expected.txt: Added.
- js/dfg-osr-exit-between-create-and-tearoff-arguments.html: Added.
- js/script-tests/dfg-osr-exit-between-create-and-tearoff-arguments.js: Added.
(foo):
- 10:51 AM Changeset in webkit [178925] by
-
- 2 edits in trunk/Tools
[iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
runtime in simctl output
https://bugs.webkit.org/show_bug.cgi?id=140751
Reviewed by David Kilzer.
Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
with an error because it does not know how to parse the output of the simctl tool
to identify an Apple Internal runtime.
- Scripts/webkitpy/xcode/simulator.py:
(Runtime.init): Add parameter is_internal_runtime (defaults to False).
(Runtime.eq): Take is_internal_runtime when comparing two Runtime objects for equality.
(Runtime.repr): Update printable representation of Runtime object to indicate whether
the runtime is an internal runtime.
(Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
(Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
appropriate value.
(Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
it updates the appropriate Runtime object.
(Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
looking up a Runtime object for an internal runtime.
- 10:47 AM Changeset in webkit [178924] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r175771. rdar://problem/19451238
- 10:47 AM Changeset in webkit [178923] by
-
- 7 edits in branches/safari-600.5-branch/Source/WebKit2
Merge r175759. rdar://problem/19450899
- 10:47 AM Changeset in webkit [178922] by
-
- 4 edits2 adds in branches/safari-600.5-branch
Merge r175131. rdar://problem/19452187
- 10:46 AM Changeset in webkit [178921] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r174716. rdar://problem/19451273
- 10:46 AM Changeset in webkit [178920] by
-
- 3 edits in branches/safari-600.5-branch
Merge r174698. rdar://problem/19451342
- 10:25 AM Changeset in webkit [178919] by
-
- 8 edits5 adds in trunk/LayoutTests
[Win] More unskips and rebaselines.
- platform/win/TestExpectations:
- platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
- platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
- platform/win/inspector-protocol: Added.
- platform/win/inspector-protocol/debugger: Added.
- platform/win/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
- platform/win/inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added.
- platform/win/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Added.
- platform/win/svg/text/kerning-expected.txt:
- platform/win/svg/text/multichar-glyph-expected.txt:
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.png:
- platform/win/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
- 10:07 AM Changeset in webkit [178918] by
-
- 3 edits in trunk/Source/JavaScriptCore
PropertyListNode::emitNode duplicates the code to put a constant property
https://bugs.webkit.org/show_bug.cgi?id=140761
Reviewed by Geoffrey Garen.
Extracted PropertyListNode::emitPutConstantProperty to share the code.
Also made PropertyListNode::emitBytecode private since nobody is calling this function directly.
- bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
(JSC::PropertyListNode::emitPutConstantProperty): Added.
- parser/Nodes.h:
- 9:59 AM Changeset in webkit [178917] by
-
- 2 edits in trunk/Tools
LeaksViewer doesn't show recent builds if there are less than 10
https://bugs.webkit.org/show_bug.cgi?id=140716
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
- 9:21 AM Changeset in webkit [178916] by
-
- 3 edits in trunk/WebKitLibraries
[Win] Unreviewed gardening.
Activate ENABLE(MOUSE_CURSOR_SCALE). This works on Windows and causes more tests to pass.
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 5:46 AM Changeset in webkit [178915] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Fix up slave distribution for Apple bots.
- 5:14 AM Changeset in webkit [178914] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Fix json.
- 5:12 AM Changeset in webkit [178913] by
-
- 2 edits in trunk/Tools
Add Apple build slaves.
Fixed text alignment for slave list.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:22 AM Changeset in webkit [178912] by
-
- 4 edits2 adds in trunk/LayoutTests
AX: [ATK] Mark accessibility/list-detection.html as a suitable test for EFL and GTK.
https://bugs.webkit.org/show_bug.cgi?id=140721
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2015-01-22
Reviewed by Chris Fleizach.
The test checks the heuristic to determine if a 'list' is really a list.
In the area of ATK a role for description list has been separated from the role AXList.
This made the test stopped giving positive results for ports EFL and GTK.
The proposed amendment restores test for these ports.
- accessibility/list-detection.html:
- platform/efl/TestExpectations:
- platform/efl/accessibility/list-detection-expected.txt: Added.
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/list-detection-expected.txt: Added.
- 2:35 AM WebKitGTK/Roadmap edited by
- (diff)
- 2:23 AM Changeset in webkit [178911] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Expected gutter highlight when selecting console input line, just like output line
https://bugs.webkit.org/show_bug.cgi?id=140696
Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-01-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
- 2:21 AM Changeset in webkit [178910] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warning in WebKit2/UIProcess module
https://bugs.webkit.org/show_bug.cgi?id=140758
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2015-01-22
Reviewed by Csaba Osztrogonác.
Fix build warnings by using UNUSED_PARAM macro
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveAllUserContentFilters):
- 2:18 AM WebKitGTK/Roadmap edited by
- (diff)
- 2:09 AM Changeset in webkit [178909] by
-
- 2 edits in branches/safari-600.5-branch/Source/JavaScriptCore
Merge r174381. rdar://problem/19450841
- 2:08 AM Changeset in webkit [178908] by
-
- 2 edits in branches/safari-600.5-branch/Source/WTF
Merge r174377. rdar://problem/19451247
- 2:08 AM Changeset in webkit [178907] by
-
- 8 edits in branches/safari-600.5-branch/Source/JavaScriptCore
Merge r174371. rdar://problem/19450845
- 2:08 AM Changeset in webkit [178906] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r174345. rdar://problem/19451258
- 2:08 AM Changeset in webkit [178905] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r173790. rdar://problem/19451354
- 2:04 AM WebKitGTK/Roadmap edited by
- (diff)
- 1:32 AM Changeset in webkit [178904] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r173688. rdar://problem/19451277
- 1:31 AM Changeset in webkit [178903] by
-
- 4 edits32 adds in branches/safari-600.5-branch
Merge r172797. rdar://problem/19451324
- 1:31 AM Changeset in webkit [178902] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit
Merge r172509. rdar://problem/19451367
- 1:31 AM Changeset in webkit [178901] by
-
- 6 edits2 adds in branches/safari-600.5-branch
Merge r172504. rdar://problem/19451367
- 1:31 AM Changeset in webkit [178900] by
-
- 3 edits2 adds in branches/safari-600.5-branch
Merge r172326. rdar://problem/19452126
- 1:11 AM Changeset in webkit [178899] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171404. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178898] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171392. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178897] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171388. rdar://problem/19451349
- 1:11 AM Changeset in webkit [178896] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171385. rdar://problem/19451349
- 12:56 AM Changeset in webkit [178895] by
-
- 4 edits2 adds in trunk
[CSS Grid Layout] Skip items spanning flex tracks when sizing content based tracks
https://bugs.webkit.org/show_bug.cgi?id=140720
Reviewed by David Hyatt.
Source/WebCore:
Section "11.5. Resolve Intrinsic Track Sizes" of the specs forces
us to ignore items spanning tracks with flex sizing functions when
resolving the content-based track sizing functions. Items with
span < 2 are not affected by this rule (as they will belong to a
single track). This way the algorithm ensures that min-content and
max-content restrictions are fulfilled before distributing the
extra space.
Test: fast/css-grid-layout/flex-and-content-sized-resolution-columns.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::spanningItemCrossesFlexibleSizedTracks):
(WebCore::integerSpanForDirection):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
- rendering/RenderGrid.h:
LayoutTests:
- fast/css-grid-layout/flex-and-content-sized-resolution-columns-expected.txt: Added.
- fast/css-grid-layout/flex-and-content-sized-resolution-columns.html: Added.
- 12:54 AM Changeset in webkit [178894] by
-
- 31 edits3 adds in trunk
put_by_val_direct need to check the property is index or not for using putDirect / putDirectIndex
https://bugs.webkit.org/show_bug.cgi?id=140426
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
In the put_by_val_direct operation, we use JSObject::putDirect.
However, it only accepts non-index property. For index property, we need to use JSObject::putDirectIndex.
This patch changes Identifier::asIndex() to return Optional<uint32_t>.
It forces callers to check the value is index or not explicitly.
Additionally, it checks toString-ed Identifier is index or not to choose putDirect / putDirectIndex.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDirectPutById):
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
(JSC::emitPutTransitionStubAndGetOldStructure):
- jsc.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
(JSC::Arguments::put):
(JSC::Arguments::deleteProperty):
(JSC::Arguments::defineOwnProperty):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSort):
- runtime/JSArray.cpp:
(JSC::JSArray::defineOwnProperty):
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::put):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):
- runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putDirectAccessor):
(JSC::JSObject::putDirectCustomAccessor):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::putDirectMayBeIndex):
(JSC::JSObject::defineOwnProperty):
- runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::putDirectInternal):
- runtime/JSString.cpp:
(JSC::JSString::getStringPropertyDescriptor):
- runtime/JSString.h:
(JSC::JSString::getStringPropertySlot):
- runtime/LiteralParser.cpp:
(JSC::LiteralParser<CharType>::parse):
- runtime/PropertyName.h:
(JSC::toUInt32FromCharacters):
(JSC::toUInt32FromStringImpl):
(JSC::PropertyName::asIndex):
- runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
- runtime/StringObject.cpp:
(JSC::StringObject::deleteProperty):
- runtime/Structure.cpp:
(JSC::Structure::prototypeChainMayInterceptStoreTo):
Source/WebCore:
Test: js/dfg-put-by-val-direct-with-edge-numbers.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64Array::getOwnPropertySlot):
(WebCore::JSFloat64Array::getOwnPropertyDescriptor):
(WebCore::JSFloat64Array::put):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::getOwnPropertySlot):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):
LayoutTests:
- js/dfg-put-by-val-direct-with-edge-numbers-expected.txt: Added.
- js/dfg-put-by-val-direct-with-edge-numbers.html: Added.
- js/script-tests/dfg-put-by-val-direct-with-edge-numbers.js: Added.
(lookupWithKey):
(dfgShouldThrow):
(lookupWithKey2):
(toStringThrowsError.toString):
- 12:36 AM Changeset in webkit [178893] by
-
- 6 edits in trunk
[CSS Grid Layout] Size tracks using a list of all items sorted by span
https://bugs.webkit.org/show_bug.cgi?id=140615
Reviewed by Andreas Kling.
Source/WebCore:
In r173620 we fixed
RenderGrid::resolveContentBasedTrackSizingFunctions() so that it
now collects all items spanning content-sized tracks and process
them one by one after sorting them by ascending span.
The problem is that it was incorrectly implemented, it has two
important bugs. First one is that the hash table that collects
items is regenerated after processing each track, so it's actually
doing nothing. Secondly we're only sorting the items on each
track, instead of all the items in the grid.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
LayoutTests:
- fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
Added tons of new test cases.
- fast/css-grid-layout/grid-content-sized-columns-resolution.html: Ditto.
- fast/css-grid-layout/grid-preferred-logical-widths.html:
Adjusted results.
- 12:30 AM Changeset in webkit [178892] by
-
- 11 edits in trunk/Source/WebKit2
[GTK] Use API::ContextMenuClient and API::InjectedBundle::PageContextMenuClient classes
https://bugs.webkit.org/show_bug.cgi?id=138467
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitContextMenu.cpp:
(webkitContextMenuPopulate): Add a version that receives a Vector<WebContextMenuItemData>&.
(webkitContextMenuCreate): Change it to receive a const
Vector<WebContextMenuItemData>& instead of a API::Array* and also
add a another version that receives const Vector<ContextMenuItem>&.
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(attachContextMenuClientToView): Use a class derived from
API::ContextMenuClient to implement the context menu client.
(getContextMenuFromProposedMenu): Deleted.
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(webkitContextMenuItemCreate): Change it to receive a const
WebContextMenuItemData& and added another version that receives a
const ContextMenuItem&.
- UIProcess/API/gtk/WebKitContextMenuItemPrivate.h:
- UIProcess/API/gtk/WebKitContextMenuPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu): Remove the creation of a
WebHitTestResult::Data, since it receives it now as parameter.
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp:
(webkitWebHitTestResultCreate): Change it to receive a const
HitTestResult& instead of const InjectedBundleHitTestResult&.
- WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResultPrivate.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Use a class derived from
API::InjectedBundle::PageContextMenuClient to implement the
context menu client.
(getContextMenuFromDefaultMenu): Deleted.
- 12:05 AM Changeset in webkit [178891] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Try to fix Debug build after r178889.
- UIProcess/API/C/WKPage.cpp: Include Logging.h.
- 12:02 AM Changeset in webkit [178890] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merge r171357. rdar://problem/19451349
