Timeline
Jan 27, 2015:
- 11:41 PM Changeset in webkit [179243] by
-
- 6 edits in branches/safari-600.4-branch/Source
Merged r179230. rdar://problem/19621509
- 9:53 PM Changeset in webkit [179242] by
-
- 61 edits in trunk/Source
Use a Ref<CachedResourceLoader> in Document instead of a RefPtr
https://bugs.webkit.org/show_bug.cgi?id=140971
Reviewed by Andreas Kling.
Source/WebCore:
Use a Ref<CachedResourceLoader> in Document instead of a RefPtr as it
can never be null. Also have Document::cachedResourceLoader() return a
reference instead of a pointer. This gets rid of a lot of unnecessary
null-checks.
Source/WebKit/win:
Use more references instead of pointers.
- WebDataSource.cpp:
(WebDataSource::subresourceForURL):
- 9:48 PM Changeset in webkit [179241] by
-
- 2 edits in trunk/Source/JavaScriptCore
ExitSiteData saying m_takesSlowPath shouldn't mean early returning takesSlowPath() since for the non-LLInt case we later set m_couldTakeSlowPath, which is more precise
https://bugs.webkit.org/show_bug.cgi?id=140980
Reviewed by Oliver Hunt.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- 9:29 PM Changeset in webkit [179240] by
-
- 1 edit2 copies in trunk/Tools
Partially revert r178802.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
- 9:11 PM Changeset in webkit [179239] by
-
- 5 edits in trunk/Source
Versioning.
- 9:09 PM Changeset in webkit [179238] by
-
- 1 copy in tags/Safari-601.1.16
New tag.
- 6:37 PM Changeset in webkit [179237] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (OS X 10.10.2): media/track/track-in-band-style.html frequently times out
https://bugs.webkit.org/show_bug.cgi?id=140974
- platform/mac/TestExpectations: Added an expectation.
- 6:29 PM Changeset in webkit [179236] by
-
- 17 edits in trunk/Source
More build fixes for newer clang.
Rubber-stamped by Anders Carlsson.
Source/WebCore:
- loader/icon/IconDatabase.h: Added missing override keywords.
Source/WebKit/mac:
Marked a deprecated accessibility method as such.
- WebView/WebFrame.mm:
(-[WebFrame accessibilityRoot]):
Source/WebKit2:
Added missing override keywords, marked some deprecated accessibility methods as such.
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::doPreInitializationWork): Deleted.
(WebKit::PluginProcessMainDelegate::getExtraInitializationData): Deleted.
(WebKit::PluginProcessMainDelegate::doPostRunWork): Deleted.
- PluginProcess/WebProcessConnection.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/mac/PageClientImpl.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(PageOverlayClientImpl::actionContextForResultAtPoint): Deleted.
(PageOverlayClientImpl::dataDetectorsDidPresentUI): Deleted.
(PageOverlayClientImpl::dataDetectorsDidChangeUI): Deleted.
(PageOverlayClientImpl::dataDetectorsDidHideUI): Deleted.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(WebKit::NetscapePlugin::isBeingAsynchronouslyInitialized): Deleted.
- WebProcess/Plugins/PDF/PDFPlugin.h:
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/Plugins/PluginProxy.h:
(WebKit::PluginProxy::isBeingAsynchronouslyInitialized): Deleted.
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- 5:54 PM Changeset in webkit [179235] by
-
- 2 edits in trunk/Tools
build.webkit.org/dashboard asserts on some commits
https://bugs.webkit.org/show_bug.cgi?id=140926
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
(Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
- 5:26 PM Changeset in webkit [179234] by
-
- 2 edits in trunk/LayoutTests
[Win] Re-enable Sputnik.
- platform/win/TestExpectations:
- platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
- 5:16 PM Changeset in webkit [179233] by
-
- 10 edits in trunk
WebGL2: Disable various extensions on WebGL2 context that have been promoted to core.
https://bugs.webkit.org/show_bug.cgi?id=140907.
<rdar://problem/19545857>
Reviewed by Brent Fulgham.
Source/WebCore:
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getSupportedExtensions): Deleted.
- html/canvas/WebGLRenderingContextBase.h:
- html/canvas/WebGLRenderingContextBase.idl:
Remove some extra extension enums that shouldn't have been declared on the context idl.
LayoutTests:
- fast/canvas/webgl/constants.html:
- 5:11 PM Changeset in webkit [179232] by
-
- 3 edits in trunk/Tools
Make flakiness dashboard OS list actually match test_expectations.py
https://bugs.webkit.org/show_bug.cgi?id=140969
Reviewed by Ryosuke Niwa.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 5:08 PM Changeset in webkit [179231] by
-
- 3 edits1 add in trunk/LayoutTests
[Win] More Windows rebaselines.
- platform/win/fast/events/ondrop-text-htmlt-expected.txt: Added.
- platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
- platform/win/fast/text/fallback-traits-fixup-expected.txt:
- platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
- 5:06 PM Changeset in webkit [179230] by
-
- 6 edits in trunk/Source
Immediate action gesture recognizer still doesn't work well with IB
https://bugs.webkit.org/show_bug.cgi?id=140967
-and corresponding-
rdar://problem/19621509
Reviewed by Tim Horton.
We should add (or remove) the gesture recognizer in viewDidMoveToWindow because
initWithFrame it too early and IB might mess with it.
Source/WebKit/mac:
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController immediateActionRecognizer]):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView viewDidMoveToWindow]):
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView viewDidMoveToWindow]):
(-[WKView initWithFrame:processPool:configuration:webView:]):
- 4:48 PM Changeset in webkit [179229] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary m_cachedPage null-checks in PageCache
https://bugs.webkit.org/show_bug.cgi?id=140965
Reviewed by Andreas Kling.
Remove unnecessary m_cachedPage null-checks in PageCache. We initialize
m_cachedPage when inserting the HistoryItem in the page cache and clear
it when removing it from the page cache. Therefore, it is guaranteed
that HistoryItems currently in the page cache have m_cachedPage
initialized and there is no need to null-check it.
- history/PageCache.cpp:
(WebCore::PageCache::frameCount):
(WebCore::PageCache::markPagesForVistedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore::PageCache::markPagesForDeviceScaleChanged):
(WebCore::PageCache::markPagesForCaptionPreferencesChanged):
- 4:13 PM Changeset in webkit [179228] by
-
- 3 edits in trunk/Source/WebCore
Some NSAccessibility methods we use are deprecated on 10.10
https://bugs.webkit.org/show_bug.cgi?id=140966
Reviewed by Anders Carlsson.
- accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::overrideAttachmentParent):
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper role]):
(-[WebAccessibilityObjectWrapper roleDescription]):
Silence the warnings for now.
- 4:02 PM Changeset in webkit [179227] by
-
- 5 edits in trunk/Source/WebCore
Rename isExpandedShorthand() to isShorthandCSSProperty() for clarity
https://bugs.webkit.org/show_bug.cgi?id=140954
Reviewed by Andreas Kling.
Rename isExpandedShorthand() to isShorthandCSSProperty() for clarity as
all CSS shorthand properties are now expanded during parsing (even
'font').
- css/StylePropertyShorthand.cpp:
(WebCore::isShorthandCSSProperty):
(WebCore::isExpandedShorthand): Deleted.
- css/StylePropertyShorthand.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- css/makeprop.pl:
- 3:43 PM Changeset in webkit [179226] by
-
- 6 edits in branches/safari-600.4-branch/Source
Merge r179129. rdar://problem/19489518
- 3:38 PM Changeset in webkit [179225] by
-
- 2 edits in trunk/Tools
[Win] WinLauncher crashes on eleventh site visited
https://bugs.webkit.org/show_bug.cgi?id=140960
Reviewed by Anders Carlsson.
- WinLauncher/WinLauncher.cpp:
(WinLauncher::showLastVisitedSites): Don't access off the end of
the history array.
- 3:34 PM Changeset in webkit [179224] by
-
- 6 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177647. rdar://problem/19445865
- 2:56 PM Changeset in webkit [179223] by
-
- 5 edits2 moves in trunk/Source/JavaScriptCore
Move DFGBinarySwitch out of the DFG so that all of the JITs can use it
https://bugs.webkit.org/show_bug.cgi?id=140959
Rubber stamped by Geoffrey Garen.
I want to use this for polymorphic stubs for https://bugs.webkit.org/show_bug.cgi?id=140660.
This code no longer has DFG dependencies so this is a very clean move.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGBinarySwitch.cpp: Removed.
- dfg/DFGBinarySwitch.h: Removed.
- dfg/DFGSpeculativeJIT.cpp:
- jit/BinarySwitch.cpp: Copied from Source/JavaScriptCore/dfg/DFGBinarySwitch.cpp.
- jit/BinarySwitch.h: Copied from Source/JavaScriptCore/dfg/DFGBinarySwitch.h.
- 2:49 PM Changeset in webkit [179222] by
-
- 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177612. rdar://problem/19445900
- 2:41 PM Changeset in webkit [179221] by
-
- 3 edits in trunk/Source/WTF
Removed WTF_MALLOC_VALIDATION
https://bugs.webkit.org/show_bug.cgi?id=140958
Reviewed by Anders Carlsson.
I don't think anyone has been using this, and the #ifdefs were driving
me crazy.
We have other options for validation -- like MallocGuardEdges,
MallocCheckHeapEach, MallocScribble, and GuardMalloc.
- wtf/FastMalloc.cpp:
(WTF::tryFastMalloc):
(WTF::fastMalloc):
(WTF::tryFastCalloc):
(WTF::fastCalloc):
(WTF::fastFree):
(WTF::tryFastRealloc):
(WTF::fastRealloc):
(WTF::fastMallocSize):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
(WTF::Internal::fastMallocMatchFailed): Deleted.
- wtf/FastMalloc.h:
(WTF::Internal::fastMallocValidationHeader): Deleted.
(WTF::Internal::fastMallocValidationSuffix): Deleted.
(WTF::Internal::fastMallocMatchValidationType): Deleted.
(WTF::Internal::setFastMallocMatchValidationType): Deleted.
(WTF::fastMallocMatchValidateMalloc): Deleted.
(WTF::fastMallocMatchValidateFree): Deleted.
(WTF::fastMallocValidate): Deleted.
- 2:37 PM Changeset in webkit [179220] by
-
- 7 edits1 copy3 adds in trunk
Simplify http/tests/media/video-play-stall.html
https://bugs.webkit.org/show_bug.cgi?id=140630
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/media/video-play-waiting.html
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::play): Add more logging.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): MediaPlayerAVPlayerItemStatusPlaybackBufferEmpty
always maps to HaveCurrentData.
(WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Don't log FunctionType,
doing so it needlessly verbose.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Log KVO property
values and notification state.
LayoutTests:
- http/tests/media/video-play-stall-expected.txt:
- http/tests/media/video-play-stall.html:
- http/tests/media/video-play-waiting-expected.txt: Added.
- http/tests/media/video-play-waiting.html: Added.
- media/content/long-test.mp4: Added. New media file with 30 second duration.
- media/content/long-test.ogv: Ditto.
- platform/mac/TestExpectations: Remove video-play-stall.html from the skip list. Mark
video-play-waiting.html as flakey as it sometimes times out.
- 2:31 PM Changeset in webkit [179219] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177591. rdar://problem/19445895
- 2:29 PM Changeset in webkit [179218] by
-
- 3 edits in trunk/Tools
[Mac] Disable building Java applets by default
https://bugs.webkit.org/show_bug.cgi?id=140957
rdar://problem/19619529
Reviewed by Anders Carlsson.
It was actually already disabled unconditionally, by accident.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
- Scripts/webkitpy/port/mac.py:
(MacPort._check_port_build):
(MacPort._build_java_test_support):
- 2:22 PM Changeset in webkit [179217] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177581. rdar://problem/19445888
- 2:07 PM Changeset in webkit [179216] by
-
- 3 edits in trunk/Tools
[iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
https://bugs.webkit.org/show_bug.cgi?id=140949
Reviewed by Alexey Proskuryakov.
Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
builders so that run-webkit-tests can lint the appropriate TestExpectation
files.
- Scripts/webkitpy/port/builders.py:
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.init): Move logic to query for the Mac build directory from here...
(IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
will fail because IOSSimulatorPort.init() ultimately calls Tools/Scripts/webkit-build-directory
to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
- 2:05 PM Changeset in webkit [179215] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177531. rdar://problem/19445868
- 2:02 PM Changeset in webkit [179214] by
-
- 4 edits in trunk/Tools
Update bots on the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=140956
Reviewed by Ryosuke Niwa.
- TestResultServer/static-dashboards/builders.jsonp:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
- 1:59 PM Changeset in webkit [179213] by
-
- 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177526. <rdar://problem/19445868>
- 1:37 PM Changeset in webkit [179212] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177504. rdar://problem/19445872
- 1:34 PM Changeset in webkit [179211] by
-
- 41 edits1 copy4 adds in trunk/Source
Unreviewed, rolling out r179192.
https://bugs.webkit.org/show_bug.cgi?id=140953
Caused numerous layout test failures (Requested by mattbaker_
on #webkit).
Reverted changeset:
"Use FastMalloc (bmalloc) instead of BlockAllocator for GC
pages"
https://bugs.webkit.org/show_bug.cgi?id=140900
http://trac.webkit.org/changeset/179192
- 1:27 PM Changeset in webkit [179210] by
-
- 8 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177499. rdar://problem/19445880
- 1:19 PM Changeset in webkit [179209] by
-
- 22 edits3 copies3 deletes in branches/safari-600.1.4.15-branch/Source
Merged r177455. rdar://problem/19445868
- 1:10 PM Changeset in webkit [179208] by
-
- 8 edits11 adds1 delete in trunk/LayoutTests
[Win] Another round of bug filing and expectation updates.
- platform/win/TestExpectations:
- platform/win/fast/selectors: Added.
- platform/win/fast/selectors/064-expected.txt: Added.
- platform/win/fast/text/backslash-to-yen-sign-euc-expected.txt:
- platform/win/fast/text/backslash-to-yen-sign-expected.png: Added.
- platform/win/fast/text/drawBidiText-expected.txt: Added.
- platform/win/fast/text/fallback-traits-fixup-expected.txt:
- platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
- platform/win/fast/text/international/hindi-spacing-expected.txt: Added.
- platform/win/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Removed property svn:executable.
- platform/win/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt: Added.
- platform/win/fast/text/unicode-variation-selector-expected.txt:
- platform/win/fast/text/whitespace: Added.
- platform/win/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt: Added.
- platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
- platform/win/fast/writing-mode/fieldsets-expected.txt: Added.
- platform/win/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Removed.
- platform/win/printing/iframe-print-expected.txt: Added.
- platform/win/transforms/2d/zoom-menulist-expected.txt: Added.
- 1:00 PM Changeset in webkit [179207] by
-
- 5 edits in tags/Safari-600.5.3.1/Source
Versioning.
- 12:55 PM Changeset in webkit [179206] by
-
- 1 copy in tags/Safari-600.5.3.1
New tag.
- 12:50 PM Changeset in webkit [179205] by
-
- 1 edit2 adds in trunk/LayoutTests
Import the layout test style-sharing-type-and-readonly.html from blink
https://bugs.webkit.org/show_bug.cgi?id=125280
Reviewed by Sergio Villar Senin.
I fixed the bug a while ago but having one more test seems valuable.
This test is from blink: https://codereview.chromium.org/27033011
by Elliott Sprehn.
- fast/css/style-sharing-type-and-readonly-expected.txt: Added.
- fast/css/style-sharing-type-and-readonly.html: Added.
- 12:46 PM Changeset in webkit [179204] by
-
- 2 edits in trunk/Source/WebCore
Modernize some constructors of the CSS JIT
https://bugs.webkit.org/show_bug.cgi?id=140903
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-27
Reviewed by Darin Adler.
Two constructors were still using the old style.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment): Deleted.
(WebCore::SelectorCompiler::TagNamePattern::TagNamePattern): Deleted.
- 12:45 PM Changeset in webkit [179203] by
-
- 1 edit10 adds in trunk/LayoutTests
Import some extra tests for r179132
https://bugs.webkit.org/show_bug.cgi?id=140930
Reviewed by Sam Weinig.
Add some tests that were done from previous attempts at fixing
the bug.
- fast/dom/SelectorAPI/tag-case-insensitive-expected.txt: Added.
- fast/dom/SelectorAPI/tag-case-insensitive.html: Added.
- fast/dom/SelectorAPI/tag-case-sensitive-expected.txt: Added.
- fast/dom/SelectorAPI/tag-case-sensitive.xhtml: Added.
- svg/css/case-sensitive-tags-expected.txt: Added.
- svg/css/case-sensitive-tags.html: Added.
- svg/dom/tag-case-sensitive-svg-in-html-expected.txt: Added.
- svg/dom/tag-case-sensitive-svg-in-html.html: Added.
Those tests were created by Alexandru Chiculita for
https://bugs.webkit.org/show_bug.cgi?id=83438
The patch was rejected at the time due to the perf impact.
That has been solved since then by the CSS JIT.
- svg/css/foreignObject-case-styling-expected.html: Added.
- svg/css/foreignObject-case-styling.html: Added.
This test is from Boris Zbarsky when he reported
https://bugs.webkit.org/show_bug.cgi?id=79444.
- 12:25 PM Changeset in webkit [179202] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r178591): 20% regression in Octane box2d
https://bugs.webkit.org/show_bug.cgi?id=140948
Reviewed by Geoffrey Garen.
Added check that we have a lexical environment to the arguments is captured check.
It doesn't make sense to resolve "arguments" when it really isn't captured.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::willResolveToArgumentsRegister):
- 12:16 PM Changeset in webkit [179201] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix.
Lack of include guards in WebVTTElement.h caused a build failure once we started including
this header file from more than one implementation file.
- html/track/WebVTTElement.h:
- 11:52 AM Changeset in webkit [179200] by
-
- 6 edits in trunk/LayoutTests
[iOS] Update test results and test expectations
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/ios-simulator/css3/blending/blend-mode-simple-composited-expected.txt:
- platform/ios-simulator/css3/blending/blend-mode-simple-expected.txt:
- 11:44 AM Changeset in webkit [179199] by
-
- 2 edits in trunk/Tools
[iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
https://bugs.webkit.org/show_bug.cgi?id=140942
Reviewed by Alexey Proskuryakov.
The directory LayoutTests/platform/wk2 contains test expectations and test results that
are applicable to all WebKit2 ports. We should make use of this information when
running layout tests using iOS WebKit2.
Additionally, make use of the convenience function Port._wk2_port_name() for the name
of the WebKit2 port instead of directly using string concatenation.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_baseline_search_path):
- 11:41 AM Changeset in webkit [179198] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit2
Merge r179195. rdar://problem/19572685
- 11:39 AM Changeset in webkit [179197] by
-
- 12 edits in trunk
CSSKeyframesRule::findRule() and deleteRule() should delete the last matching rule, not the first
https://bugs.webkit.org/show_bug.cgi?id=139732
Patch by Sylvain Galineau <galineau@adobe.com> on 2015-01-26
Reviewed by Dean Jackson and Darin Adler.
Source/WebCore:
No new tests because existing tests have been updated to verify this behavior.
- css/CSSKeyframeRule.h:
(WebCore::StyleKeyframe::getKeys): Deleted.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::keyframeStylesForAnimation): use StyleKeyframe::keys().
- css/CSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::parseKeyString): Deleted. Moved to CSSParser.
(WebCore::StyleKeyframe::keyText): Build keyframe selector from Vector<double> representation.
- css/CSSKeyframeRule.h:
(WebCore::StyleKeyframe::setKeyText): parse keyframe selector into Vector<double>.
(WebCore::StyleKeyframe::keys): Added. Returns vector representation of selector keys.
(WebCore::StyleKeyframe::getKeys): Deleted. Now keys().
- css/CSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::findKeyframeIndex): Return last matching rule.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseKeyframeSelector): Added. Moved from StyleKeyframe.
- css/CSSParser.h:
(WebCore::CSSParser::parseKeyframeSelector): Added. Moved from StyleKeyframe.
LayoutTests:
Update existing keyframes OM tests to check for findRule/deleteRule matching order i.e. find/delete last specified rule.
- animations/keyframes-rule-expected.txt:
- animations/keyframes-rule.html:
- animations/unprefixed-keyframes-rule-expected.txt:
- animations/unprefixed-keyframes-rule.html:
- 11:16 AM Changeset in webkit [179196] by
-
- 2 edits2 deletes in trunk/LayoutTests
Unreviewed, rebaseline fast/css/css2-system-fonts.html on iOS.
Rebaseline fast/css/css2-system-fonts.html on iOS after r179168.
- platform/ios-sim-deprecated/fast/css/css2-system-fonts-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt:
- platform/ios-simulator/fast/css/css2-system-fonts-expected.txt: Removed.
- 11:12 AM Changeset in webkit [179195] by
-
- 2 edits in trunk/Source/WebKit2
Invoking an immediate action on link often dismisses selection
https://bugs.webkit.org/show_bug.cgi?id=140911
-and corresponding-
rdar://problem/19572685
Reviewed by Tim Horton.
Calling _page->setMaintainsInactiveSelection(false) in complete is often
too soon. Instead, call it in dismissContentRelativeChildWindows. This is more
similar to the timing for the TextIndicator.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController dismissContentRelativeChildWindows]):
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WKImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
- 11:08 AM Changeset in webkit [179194] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed build fix. "eta" isn't set on a in-progress build on a newly added builder.
- tools/sync-with-buildbot.py:
(find_request_updates):
- 10:44 AM Changeset in webkit [179193] by
-
- 2 edits in trunk/Source/WebKit/mac
Fixed building projects that import WebView.h with WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS.
Rubber-stamped by Anders Carlsson.
- WebView/WebView.h: Added forward declarations of the protocols.
- 10:29 AM Changeset in webkit [179192] by
-
- 41 edits5 deletes in trunk/Source
Use FastMalloc (bmalloc) instead of BlockAllocator for GC pages
https://bugs.webkit.org/show_bug.cgi?id=140900
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
Removes some more custom allocation code.
Looks like a speedup. (See results attached to bugzilla.)
Will hopefully reduce memory use by improving sharing between the GC and
malloc heaps.
- API/JSBase.cpp:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj: Feed the compiler.
- heap/BlockAllocator.cpp: Removed.
- heap/BlockAllocator.h: Removed. No need for a custom allocator anymore.
- heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::CodeBlockSet):
- heap/CodeBlockSet.h: Feed the compiler.
- heap/CopiedBlock.h:
(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::isOversize):
(JSC::CopiedBlock::payloadEnd):
(JSC::CopiedBlock::capacity):
- heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes): Each copied block now tracks its
own size, since we can't rely on Region to tell us our size anymore.
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocateOversize):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::recycleEvacuatedBlock):
(JSC::CopiedSpace::recycleBorrowedBlock):
(JSC::CopiedSpace::allocateBlockForCopyingPhase):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::startedCopying): Deallocate blocks directly, rather
than pushing them onto the block allocator's free list; the block
allocator doesn't exist anymore.
- heap/CopyWorkList.h:
(JSC::CopyWorkListSegment::create):
(JSC::CopyWorkListSegment::CopyWorkListSegment):
(JSC::CopyWorkList::~CopyWorkList):
(JSC::CopyWorkList::append):
(JSC::CopyWorkList::CopyWorkList): Deleted.
- heap/GCSegmentedArray.h:
(JSC::GCArraySegment::GCArraySegment):
- heap/GCSegmentedArrayInlines.h:
(JSC::GCSegmentedArray<T>::GCSegmentedArray):
(JSC::GCSegmentedArray<T>::~GCSegmentedArray):
(JSC::GCSegmentedArray<T>::clear):
(JSC::GCSegmentedArray<T>::expand):
(JSC::GCSegmentedArray<T>::refill):
(JSC::GCArraySegment<T>::create):
- heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::GCThreadSharedData):
- heap/GCThreadSharedData.h: Feed the compiler.
- heap/HandleBlock.h:
- heap/HandleBlockInlines.h:
(JSC::HandleBlock::create):
(JSC::HandleBlock::HandleBlock):
(JSC::HandleBlock::payloadEnd):
- heap/HandleSet.cpp:
(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow): Same as above.
- heap/Heap.cpp:
(JSC::Heap::Heap):
- heap/Heap.h: Removed the block allocator since it is unused now.
- heap/HeapBlock.h:
(JSC::HeapBlock::destroy):
(JSC::HeapBlock::HeapBlock):
(JSC::HeapBlock::region): Deleted. Removed the Region pointer from each
HeapBlock since a HeapBlock is just a normal allocation now.
- heap/HeapInlines.h:
(JSC::Heap::blockAllocator): Deleted.
- heap/HeapTimer.cpp:
- heap/MarkStack.cpp:
(JSC::MarkStackArray::MarkStackArray):
- heap/MarkStack.h: Feed the compiler.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateBlock): No need to use a custom code path
based on size, since we use a general purpose allocator now.
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::capacity): Track block size explicitly, like CopiedBlock.
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::freeBlock):
- heap/MarkedSpace.h:
- heap/Region.h: Removed.
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::SlotVisitor): Removed reference to block allocator.
- heap/SuperRegion.cpp: Removed.
- heap/SuperRegion.h: Removed.
- heap/WeakBlock.cpp:
(JSC::WeakBlock::create):
(JSC::WeakBlock::WeakBlock):
- heap/WeakBlock.h:
- heap/WeakSet.cpp:
(JSC::WeakSet::~WeakSet):
(JSC::WeakSet::addAllocator):
(JSC::WeakSet::removeAllocator): Removed reference to block allocator.
Source/WebCore:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install): Be sure to release other
memory after GC and not before, since GC might contribute to free
malloc pages now.
Source/WTF:
New interface for aligned allocation: fastAlignedMalloc / fastAlignedFree.
We require a special function call on free because Windows.
- wtf/FastMalloc.cpp:
(WTF::fastAlignedMalloc):
(WTF::fastAlignedFree): Do it.
(WTF::do_memalign): Un-ifdef this, since we use it now.
- wtf/FastMalloc.h: Make our new function names visible like the rest
of fastMalloc.
- 10:24 AM Changeset in webkit [179191] by
-
- 3 edits in trunk/LayoutTests
<rdar://problem/16801814> Media controls do not appear in 2 DRT tests
This doesn't appear to happen any more, although the tests are still flaky due to
flaky font metrics.
- platform/mac/TestExpectations:
- platform/mac/media/controls-without-preload-expected.txt:
- 10:22 AM Changeset in webkit [179190] by
-
- 2 edits in trunk/Tools
[Win] Disable FTL stress tests
https://bugs.webkit.org/show_bug.cgi?id=140932
Reviewed by Brent Fulgham.
- Scripts/run-javascriptcore-tests:
- 10:15 AM Changeset in webkit [179189] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Rebaseline several editing tests on Mac after r179168.
- platform/mac/editing/attributed-string/font-size-expected.txt:
- platform/mac/editing/attributed-string/vertical-align-expected.txt:
- 9:28 AM Changeset in webkit [179188] by
-
- 2 edits in trunk/LayoutTests
[Win] Unskip tests now that r179170 is in place.
- platform/win/TestExpectations:
- 9:13 AM Changeset in webkit [179187] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARM] Typo fix after r176083
https://bugs.webkit.org/show_bug.cgi?id=140937
Reviewed by Anders Carlsson.
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::ldrh):
- 9:05 AM Changeset in webkit [179186] by
-
- 3 edits1 add in trunk/LayoutTests
[Win] Adjust some expectations based on test bot display metrics.
- platform/win/TestExpectations:
- platform/win/fast/dom/adopt-node-crash-2-expected.txt:
- platform/win/fast/ondrop-text-html-expected.txt: Added.
- 9:01 AM Changeset in webkit [179185] by
-
- 4 edits in trunk/Source/WebCore
Simple line layout: Make FlowContents an iterator class.
https://bugs.webkit.org/show_bug.cgi?id=140909
Reviewed by Antti Koivisto.
This patch transfers content position handling from createLineRuns()/LineState to
FlowContents. FlowContents becomes a real iterator class.
It tightens content and position information so that we can start supporting
no textual content such as <br>.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::LineState::commitAndCreateRun): Remove redundant committedLogicalRight.
(WebCore::SimpleLineLayout::LineState::addUncommitted): Now that we don't have current
positon in LineState, we need to be able to figure out where we start the uncommitted content.
This is mainly relevant after collapsed whitespace, when we start a new uncommitted segment.
It was previously achieved through LineState::jumpTo().
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::firstFragment): Return the first fragment for this line.
(WebCore::SimpleLineLayout::createLineRuns): Renaming and removing position handling.
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns): Renaming.
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::LineState::jumpTo): Deleted.
(WebCore::SimpleLineLayout::initializeNewLine): Deleted. : Move overflow fragment functionality
to firstFragment().
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::FlowContents::nextTextFragment):
- rendering/SimpleLineLayoutFlowContents.h:
- 9:00 AM Changeset in webkit [179184] by
-
- 6 edits in trunk/Websites/webkit.org
Update Xcode requirement and add instructions to build, run, and debug WebKit for iOS Simulator
Reviewed by David Kilzer.
- building/build.html: Added instructions to build WebKit for iOS Simulator.
- building/debug.html: Added some instructions to debug the UIProcess and WebProcess
in the iOS Simulator using command line tools. We should look to add Xcode instructions
and simplify these steps once we teach debug-safari about the iOS Simulator.
- building/run.html: Added remark to run Safari in the iOS Simulator.
- building/tools.html: Require Xcode 6.1.1 (for the iOS 8.1 SDK) to build for iOS Simulator.
- css/main.css: Define the .ios-instructions class with the same style as other .*-instructions classes.
- 8:17 AM Changeset in webkit [179183] by
-
- 7 edits in trunk/Source/WebKit/mac
Make it easy to test enabling formal delegate protocols
https://bugs.webkit.org/show_bug.cgi?id=140892
Reviewed by Dan Bernstein.
Add an WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS define that controls whether delegates should be formal protocols.
- Misc/WebDownload.h:
- WebView/WebFrameLoadDelegate.h:
- WebView/WebPolicyDelegate.h:
- WebView/WebResourceLoadDelegate.h:
- WebView/WebUIDelegate.h:
- WebView/WebView.h:
- 8:10 AM Changeset in webkit [179182] by
-
- 6 edits in trunk/Source/WebKit2
REGRESSION(r166975): [GTK] Page overlays are not drawn anymore after r166975
https://bugs.webkit.org/show_bug.cgi?id=131433
Reviewed by Žan Doberšek.
Implement page overlays for the GTK+ port.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
Override pure virtual setViewOverlayRootLayer().
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display): Remove FIXME and use modern
for loop.
(WebKit::DrawingAreaImpl::attachViewOverlayGraphicsLayer): Remove
ifdefs and use LayerTreeHost::setViewOverlayRootLayer().
- WebProcess/WebPage/LayerTreeHost.h: Add pure virtual setViewOverlayRootLayer().
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk): Initialize m_viewOverlayRootLayer.
(WebKit::LayerTreeHostGtk::initialize): Remove FIXME.
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
Remove unused old page overlays code.
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect): Ditto.
(WebKit::LayerTreeHostGtk::sizeDidChange): Ditto.
(WebKit::LayerTreeHostGtk::paintContents): Remove FIXME.
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges): Flush
compositing state on m_pageOverlayLayers if present.
(WebKit::LayerTreeHostGtk::setViewOverlayRootLayer): Set m_pageOverlayLayers.
(WebKit::LayerTreeHostGtk::createPageOverlayLayer): Deleted.
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer): Deleted.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h: Remove unused old
page overlays code.
- 7:59 AM Changeset in webkit [179181] by
-
- 9 edits in trunk
HTMLElement.dir should only return known values
https://bugs.webkit.org/show_bug.cgi?id=140925
Reviewed by Darin Adler.
Source/WebCore:
HTMLElement.dir should only return known values according to the HTML
specification:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-dir
Chrome and Firefox 28 match the specification. IE11's behavior is
slightly different:
- When setting an unknown 'dir' value, an exception will be thrown.
- Setting a known 'dir' value in a non-canonical case (e.g. "RTL"), the value will be directly converted to its canonical form (e.g. "rtl") before updating the DOM tree. (close to the spec but changing the case upon setting).
This patch is based on the following Blink revision by me:
https://src.chromium.org/viewvc/blink?view=rev&revision=171861
Test: fast/dom/document-dir-property.html
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir):
(WebCore::HTMLDocument::setDir):
- html/HTMLDocument.h:
- html/HTMLElement.cpp:
(WebCore::toValidDirValue):
(WebCore::HTMLElement::dir):
(WebCore::HTMLElement::setDir):
- html/HTMLElement.h:
- html/HTMLElement.idl:
LayoutTests:
Update fast/dom/document-dir-property.html to make sure HTMLDocument.dir
and HTMLElement.dir only return known values, as per the HTML
specification.
- fast/dom/document-dir-property-expected.txt:
- fast/dom/document-dir-property.html:
- 7:32 AM Changeset in webkit [179180] by
-
- 2 edits in trunk/Tools
REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
https://bugs.webkit.org/show_bug.cgi?id=140939
Reviewed by Eric Carlson.
Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
- Scripts/webkitdirs.pm:
(hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
and define a function called wanted.
- 7:16 AM Changeset in webkit [179179] by
-
- 2 edits in trunk/Tools
Teach run-webkit-app --simulator how to install custom built app
https://bugs.webkit.org/show_bug.cgi?id=140691
Fix inadvertent omission of directory test flag in expression to check for the
existence of the iOS simulator device-specific directory for user installed apps.
- Scripts/webkitdirs.pm:
(hasUserInstalledAppInSimulatorDevice):
- 6:12 AM Changeset in webkit [179178] by
-
- 2 edits in trunk/LayoutTests
[EFL] AX: Update test expectations for test related with AXRole.
https://bugs.webkit.org/show_bug.cgi?id=140933
Unreviewed EFL gardening.
roles-exposed.html's test expectation changed: for specified elements
AXRole value should NOT be equal AXUnknown but AXStatic because for ATK
version 2.15.2 there is new ATK_ROLE_STATIC role which should be used
instead of ATK_ROLE_UNKNOWN.
Patch by Michal Poteralski <m.poteralski@samsung.com> on 2015-01-27
- platform/efl/accessibility/roles-exposed-expected.txt:
- 1:40 AM Changeset in webkit [179177] by
-
- 2 edits in trunk/PerformanceTests/SunSpider
[Win] JSC profiler tests asserts in debug mode
https://bugs.webkit.org/show_bug.cgi?id=140931
Unreviewed gardening, skip failing tests.
- profiler-test.yaml:
- 1:26 AM Changeset in webkit [179176] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Win] Unreviewed gardening, skip failing tests.
- tests/exceptionFuzz.yaml: Skip exception fuzz tests due to bug140928.
- tests/mozilla/mozilla-tests.yaml: Skip ecma/Date/15.9.5.28-1.js due to bug140927.
- 12:19 AM Changeset in webkit [179175] by
-
- 5 edits in trunk/Source/WebKit2
Remove remaining PLUGIN_ARCHITECTURE(WIN) code blocks from WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=140912
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-01-27
Reviewed by Anders Carlsson.
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
- Shared/Plugins/PluginQuirks.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::userAgent):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Jan 26, 2015:
- 11:40 PM Changeset in webkit [179174] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, rebaseline several CSS tests after r179168.
Computed line-height is no longer 'normal' but the font's line
spacing.
- fast/css/font-shorthand-line-height-expected.txt:
- fast/css/font-shorthand-line-height.html:
- platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- 11:30 PM Changeset in webkit [179173] by
-
- 7 edits26 adds in trunk/LayoutTests
[Win] Unskipping more tests after correcting baselines for Windows widgets.
- platform/win/TestExpectations:
- platform/win/fast/events/context-no-deselect-expected.png: Added.
- platform/win/fast/events/context-no-deselect-expected.txt: Added.
- platform/win/fast/events/dropzone-005-expected.txt: Added.
- platform/win/fast/events/ime-composition-events-001-expected.txt:
- platform/win/fast/events/key-events-in-input-button-expected.txt: Added.
- platform/win/fast/events/mouseup-from-button2-expected.txt: Added.
- platform/win/fast/flexbox: Added.
- platform/win/fast/flexbox/clear-overflow-before-scroll-update-expected.txt: Added.
- platform/win/fast/frames/flattening: Added.
- platform/win/fast/frames/flattening/frameset-flattening-simple-expected.txt: Added.
- platform/win/fast/multicol/client-rects-expected.png: Added.
- platform/win/fast/multicol/client-rects-expected.txt: Added.
- platform/win/fast/multicol/client-rects-spanners-complex-expected.png: Added.
- platform/win/fast/multicol/client-rects-spanners-complex-expected.txt: Added.
- platform/win/fast/multicol/client-rects-spanners-expected.png: Added.
- platform/win/fast/multicol/client-rects-spanners-expected.txt: Added.
- platform/win/fast/multicol/newmulticol: Added.
- platform/win/fast/multicol/newmulticol/client-rects-expected.png: Added.
- platform/win/fast/multicol/newmulticol/client-rects-expected.txt: Added.
- platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
- platform/win/fast/overflow/scrollRevealButton-expected.txt:
- platform/win/fast/parser/bad-xml-slash-expected.txt: Added.
- platform/win/fast/parser/document-write-option-expected.txt: Added.
- platform/win/fast/repaint/control-clip-expected.txt:
- platform/win/fast/replaced/object-with-embed-url-param-expected.txt: Added.
- platform/win/fast/replaced/replaced-breaking-expected.txt: Added.
- platform/win/fast/replaced/replaced-breaking-mixture-expected.txt: Added.
- platform/win/fast/replaced/width100percent-button-expected.txt:
- platform/win/fast/replaced/width100percent-checkbox-expected.txt: Added.
- platform/win/fast/replaced/width100percent-menulist-expected.txt: Added.
- platform/win/fast/replaced/width100percent-radio-expected.txt: Added.
- 11:05 PM Changeset in webkit [179172] by
-
- 16 edits in trunk/Source/WebCore
Introduce Document::body() for call sites interested in the <body> element
https://bugs.webkit.org/show_bug.cgi?id=140920
Reviewed by Darin Adler.
Introduce Document::body() method for call sites interested only in the
document's <body> element (not the <frameset>). Also clean up the call
sites of Document::bodyOrFrameset() to cache the return value when
suitable as this method does a tree traversal.
This patch does not change behavior, it merely ports calls sites that
were calling Document::bodyOrFrameset() then checking if the tag was
<body>, to call Document::body() instead. Doing so is more efficient
and clearer.
- 10:32 PM Changeset in webkit [179171] by
-
- 3 edits2 adds in trunk
Apply feTurbulence spec change to fix zero length vector generation
https://bugs.webkit.org/show_bug.cgi?id=140812
.:
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-01-26
Reviewed by Darin Adler.
Recently a bug with the turbulence algorithm was corrected in the
Filter Effects specification.
For some seed values this bug allowed zero length vectors to be generated.
This resulted in large solid color squares being present in the generated image.
The feTurbulence algorithm was updated to reject zero length vectors. This patch
applies that change in WebCore.
Test: svg/filters/feTurbulence_bad_seeds.html
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::initPaint):
Added rejection sampling during vector generation to avoid zero length vectors.
LayoutTests:
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-01-26
Reviewed by Darin Adler.
Ref test that generates a turbulence image which is then coloured black
and alpha min/maxxed (>0 becomes 1, 0 stays zero). This allows holes
caused by zero length vectors to be easily identified.
- svg/filters/feTurbulence_bad_seeds-expected.html: Added.
- svg/filters/feTurbulence_bad_seeds.html: Added.
- 10:24 PM Changeset in webkit [179170] by
-
- 16 edits in trunk
[Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
https://bugs.webkit.org/show_bug.cgi?id=87426
<rdar://problem/11527899>
Reviewed by Darin Adler.
Source/WebCore:
Revise COMPtr to work better with our HashMap implementation:
(1) Add a specialization for IsSmartPtr.
(2) Remove PtrHash specialization.
(3) Refresh HashTrails specialization for COMPtr to match what we
do for RefPtr.
- platform/win/COMPtr.h:
Source/WebKit/win:
Revise COMPtr to work better with our HashMap implementation. Use
modern loop syntax.
- WebHistory.cpp:
(WebHistory::visitedURL): Adjust for new COMPtr changes.
- WebPreferences.cpp:
(WebPreferences::getInstanceForIdentifier): Ditto.
(WebPreferences::removeReferenceForIdentifier): Ditto.
- WebView.cpp:
(WebView::setEditable): Ditto.
Source/WTF:
Revise internal containers to use std::addressof in preference to
to using the '&' operator.
- wtf/Deque.h:
(WTF::inlineCapacity>::append):
(WTF::inlineCapacity>::prepend):
(WTF::inlineCapacity>::removeFirst):
(WTF::inlineCapacity>::removeLast):
(WTF::inlineCapacity>::remove):
(WTF::inlineCapacity>::after):
(WTF::inlineCapacity>::before):
- wtf/GetPtr.h:
- wtf/HashTable.h:
(WTF::HashTableBucketInitializer<false>::initialize):
- wtf/HashTraits.h:
(WTF::SimpleClassHashTraits::constructDeletedValue):
(WTF::CustomHashTraits::constructDeletedValue):
- wtf/ListHashSet.h:
(WTF::ListHashSetConstIterator::get):
- wtf/Vector.h:
(WTF::Vector::swap):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):
Tools:
Revise COMPtr to work better with our HashMap implementation. Use
modern loop syntax.
- DumpRenderTree/win/AccessibilityControllerWin.cpp:
(AccessibilityController::~AccessibilityController):
(AccessibilityController::winNotificationReceived):
- DumpRenderTree/win/DumpRenderTree.cpp:
(dumpBackForwardListForAllWindows):
- 10:14 PM Changeset in webkit [179169] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Win] Enable JSC stress tests by default
https://bugs.webkit.org/show_bug.cgi?id=128307
Unreviewed typo fix after r179165.
- tests/mozilla/mozilla-tests.yaml:
- 10:12 PM Changeset in webkit [179168] by
-
- 36 edits in trunk
The computed value of line-height:normal is incorrect
https://bugs.webkit.org/show_bug.cgi?id=133744
Patch by Sylvain Galineau <galineau@adobe.com> on 2015-01-26
Reviewed by Dean Jackson.
Source/WebCore:
Use font's line spacing as computed line-height value when specified value is 'normal'.
This behavior is compatible with all other engines.
No new tests; all existing tests are updated to reflect the new computed value.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::lineHeightFromStyle): If line-height wasn't set, use the font's line spacing (same as Blink).
LayoutTests:
line-height:normal now computes to a length value.
This patch updates the tests to reflect the new computed value, as needed.
- css3/calc/line-height-expected.txt:
- editing/pasteboard/simplfiying-markup-should-not-strip-content-expected.txt:
- fast/css/font-calculated-value-expected.txt:
- fast/css/font-calculated-value.html:
- fast/css/font-shorthand-from-longhands-expected.txt:
- fast/css/font-shorthand-from-longhands.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-font-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/script-tests/computed-style-font.js:
- fast/css/line-height-text-autosizing-expected.txt:
- fast/css/line-height-text-autosizing.html:
- fast/ruby/ruby-line-height-expected.txt:
- fast/ruby/script-tests/ruby-line-height.js:
- media/track/track-cue-rendering-on-resize-expected.txt:
- media/track/track-cue-rendering-on-resize.html:
- platform/mac-mavericks/platform/mac/editing/attributed-string/anchor-element-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/basic-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/font-size-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/font-weight-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/letter-spacing-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/text-decorations-expected.txt:
- platform/mac-mavericks/platform/mac/editing/attributed-string/vertical-align-expected.txt:
- platform/mac/editing/attributed-string/anchor-element-expected.txt:
- platform/mac/editing/attributed-string/basic-expected.txt:
- platform/mac/editing/attributed-string/font-size-expected.txt:
- platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
- platform/mac/editing/attributed-string/font-weight-expected.txt:
- platform/mac/editing/attributed-string/letter-spacing-expected.txt:
- platform/mac/editing/attributed-string/text-decorations-expected.txt:
- platform/mac/editing/attributed-string/vertical-align-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 10:04 PM Changeset in webkit [179167] by
-
- 4 edits14 adds1 delete in trunk/LayoutTests
[Win] Windows gardening (removing more skips).
- platform/win/TestExpectations:
- platform/win/fast/block/basic/011-expected.png: Added.
- platform/win/fast/block/basic/011-expected.txt: Added.
- platform/win/fast/block/float/overhanging-tall-block-expected.png: Added.
- platform/win/fast/block/float/overhanging-tall-block-expected.txt: Added.
- platform/win/fast/borders/bidi-002-expected.png: Added.
- platform/win/fast/borders/bidi-002-expected.txt: Added.
- platform/win/fast/borders/bidi-009a-expected.png: Added.
- platform/win/fast/borders/bidi-009a-expected.txt: Added.
- platform/win/fast/borders/border-fit-expected.txt: Added.
- platform/win/fast/dom/HTMLInputElement/input-image-alt-text-expected.png: Added.
- platform/win/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt: Added.
- platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt: Removed property svn:executable.
- platform/win/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Removed property svn:executable.
- platform/win/fast/dom/HTMLTableColElement: Added.
- platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png: Added.
- platform/win/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Added.
- platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
- 9:54 PM Changeset in webkit [179166] by
-
- 6 edits in trunk
Document.dir should reflect the 'dir' attribute of the root html element
https://bugs.webkit.org/show_bug.cgi?id=140922
Reviewed by Darin Adler.
Source/WebCore:
Document.dir should reflect the 'dir' content attribute of the root
<html> element as per the specification:
https://html.spec.whatwg.org/multipage/dom.html#dom-document-dir
Previously, WebKit was reflecting the 'dir' content attribute of the
body element. This patch aligns WebKit with the specification and the
behavior of other browsers (tested Firefox 28, IE11 and Chrome).
This patch is based on the following Blink revision by me:
https://src.chromium.org/viewvc/blink?revision=171734&view=revision
Test: fast/dom/document-dir-property.html
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::dir):
(WebCore::HTMLDocument::setDir):
- html/HTMLDocument.h:
LayoutTests:
Update fast/dom/document-dir-property.html to reflect the behavior
change.
- fast/dom/document-dir-property-expected.txt:
- fast/dom/document-dir-property.html:
- 9:01 PM Changeset in webkit [179165] by
-
- 8 edits in trunk
[Win] Enable JSC stress tests by default
https://bugs.webkit.org/show_bug.cgi?id=128307
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- tests/mozilla/mozilla-tests.yaml: Skipped on Windows.
- tests/stress/ftl-arithcos.js: Skipped on Windows.
Tools:
- Scripts/run-javascriptcore-tests:
LayoutTests:
- js/script-tests/date-constructor.js: Skipped on Windows.
- js/script-tests/sort-stability.js: Skipped on Windows.
- 8:50 PM Changeset in webkit [179164] by
-
- 8 edits4 copies in branches/safari-600.1.4.15-branch/Source
Merged r177328. rdar://problem/19445865
- 8:39 PM Changeset in webkit [179163] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r179101): SVGUseElement::expandUseElementsInShadowTree has an object lifetime mistake
https://bugs.webkit.org/show_bug.cgi?id=140921
Reviewed by Alexey Proskuryakov.
Bug found by running regression tests with Address Sanitizer.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Use a Ref to protect
the original use element after it's been replaced in the tree; we use it for
one more thing after that.
- 8:06 PM Changeset in webkit [179162] by
-
- 4 edits in trunk/Tools
[iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
arguments for build and test scripts
https://bugs.webkit.org/show_bug.cgi?id=139748
Patch by Simon Fraser <Simon Fraser> on 2015-01-26
Reviewed by Daniel Bates.
There was much confusion resulting from the multitude of aliases used to build/test for
the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
tests directory.
This fixes an issue where run-api-tests and some other scripts failed when run with
--simulator.
- Scripts/build-webkit:
- Scripts/package-root:
(usage):
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(determineXcodeSDK):
- Scripts/webkitpy/port/factory.py:
(platform_options):
- 6:39 PM Changeset in webkit [179161] by
-
- 2 edits in trunk
[iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
https://bugs.webkit.org/show_bug.cgi?id=140203
rdar://problem/19198492
Reviewed by Sam Weinig.
Source/WebKit2:
When handling the OwnerWasInvalidated case in -[WKWebView evaluateJavaScript:completionHandler:],
the block passed to dispatch_async() needs to be retained. Fix by passing the RefPtr
to the lambda.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
(TEST):
- 6:39 PM Changeset in webkit [179160] by
-
- 2 edits1 add in trunk
Need a short description (OOPS!).
Need the bug URL (OOPS!).
Reviewed by NOBODY (OOPS!).
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
(TEST):
- 5:14 PM Changeset in webkit [179159] by
-
- 2 edits in trunk/Source/JavaScriptCore
Parse a function expression as a primary expression
https://bugs.webkit.org/show_bug.cgi?id=140908
Reviewed by Mark Lam.
Moved the code to generate an AST node for a function expression from parseMemberExpression
to parsePrimaryExpression to match the ES6 specification terminology:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-primary-expression
There should be no behavior change from this change since parsePrimaryExpression is only
called in parseMemberExpression other than the fact failIfStackOverflow() is called.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
- 4:55 PM Changeset in webkit [179158] by
-
- 2 edits in trunk/Source/WebCore
WebGL 2.0: Actually allow for experimental-webgl2 context creation.
https://bugs.webkit.org/show_bug.cgi?id=140906
<rdar://problem/19606875>.
Reviewed by Brent Fulgham.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::is3dType): Include experimental-webgl2 in the list of acceptable 3d context types.
- 4:26 PM Changeset in webkit [179157] by
-
- 34 edits in trunk/Source
Rename Document::body() to Document::bodyOrFrameset() for clarity
https://bugs.webkit.org/show_bug.cgi?id=140902
Reviewed by Andreas Kling.
Rename Document::body() to Document::bodyOrFrameset() for clarity. This
method does not necessarily return an HTMLBodyElement, it can also
return a frameset as per the specification:
http://www.w3.org/TR/html5/dom.html#dom-tree-accessors
This method is often misused internally (the caller is only interested
in the <body> element). I will fix these instances in a follow-up patch,
this patch is only renaming mechanically.
- 4:19 PM Changeset in webkit [179156] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit2
Merge r179087. rdar://problem/19571057
- 4:19 PM Changeset in webkit [179155] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebCore
Merge r179086. rdar://problem/19566089
- 4:19 PM Changeset in webkit [179154] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit2
Merge r179023. rdar://problem/19573674
- 4:19 PM Changeset in webkit [179153] by
-
- 10 edits in branches/safari-600.4-branch/Source
Merge r179014. rdar://problem/19573674
- 4:19 PM Changeset in webkit [179152] by
-
- 4 edits in branches/safari-600.4-branch/Source
Merge r179013. rdar://problem/19571601
- 4:19 PM Changeset in webkit [179151] by
-
- 6 edits in branches/safari-600.4-branch/Source
Merge r178938. rdar://problem/19558472
- 4:19 PM Changeset in webkit [179150] by
-
- 4 edits in branches/safari-600.4-branch/Source
Merge r178858. rdar://problem/19540806
- 3:23 PM Changeset in webkit [179149] by
-
- 2 edits in trunk/LayoutTests
[Win] More test gardening.
- platform/win/TestExpectations:
- 3:20 PM Changeset in webkit [179148] by
-
- 5 edits in trunk/Source/WebKit2
Add a user default for disabling network cache
https://bugs.webkit.org/show_bug.cgi?id=140904
Reviewed by Andreas Kling
defaults write com.apple.Safari WebKitNetworkCacheEnabled -bool YES/NO
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):
- 2:59 PM Changeset in webkit [179147] by
-
- 3 edits3 adds in trunk
Fix Border-radius clipping issue on a composited descendants
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=138551
Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-26
Reviewed by Simon Fraser.
Fix assertion in RenderLayerBacking::paintIntoLayer
by not checking out of sync with the GraphicsLayer heirarchy
in GraphicsLayerPaintChildClippingMask phase.
Test: compositing/clipping/border-radius-overflow-hidden-stacking-context.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=138551
Patch by Byungseon Shin <sun.shin@lge.com> on 2015-01-26
Reviewed by Simon Fraser.
Ref test that clips composited descendant by stacking context with border-radius and overflow hidden element.
- compositing/clipping/border-radius-overflow-hidden-stacking-context-expected.txt: Added.
- compositing/clipping/border-radius-overflow-hidden-stacking-context.html: Added.
- 2:50 PM Changeset in webkit [179146] by
-
- 4 edits5 adds in branches/safari-600.1.4.15-branch
Merged r177927. rdar://problem/19565854
- 2:44 PM Changeset in webkit [179145] by
-
- 2 edits in trunk/Source/WebCore
Simplify RenderElement's shouldRepaintForImageAnimation()
https://bugs.webkit.org/show_bug.cgi?id=140890
Reviewed by Darin Adler.
Simplify RenderElement's shouldRepaintForImageAnimation() by
not calling rendererForRootBackground(). The previous code was
doing a null-check on Document::documentElement() but failing
to do a null-check on the renderer just after, which lead me
to refactor this code.
Instead of calling document().documentElement.renderer(), we
now call renderer.parent(). This is equivalent because we already
know that renderer.isBody() returns true. The parent of the <body>
has to be the <html> element, which has to be the documentElement.
There is also no need to do a null-check on renderer.parent(). We
already know that the <body> has a renderer (because |renderer| is
its renderer), thus its parent <html> element has to have a renderer
as well.
Finally, simply call !rootElement.hasBackground() instead of
rootElement.rendererForRootBackground() == &bodyRenderer to determine
if the background painted by the root. This is equivalent but more
efficient because:
- We already know that the root renderer's is an <html> element. We can thus avoid the check in rendererForRootBackground().
- We already have the <body>'s renderer so we don't need to do the DOM tree traversal in rendererForRootBackground() to get it.
No new tests, already covered by:
fast/images/animated-gif-body-delegated-background-image.html
fast/images/animated-gif-html-background-image.html
- rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):
- 2:40 PM Changeset in webkit [179144] by
-
- 4 edits2 adds in trunk/Tools
Add iOS EWS to build.webkit.org/dashboard
<http://webkit.org/b/140627>
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer): Add ios-ews queue info.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
Add iOS8Device platform.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
iOS device logo.
- 2:36 PM Changeset in webkit [179143] by
-
- 80 edits in trunk/Source
First argument to DOM traversal functions should be a reference
https://bugs.webkit.org/show_bug.cgi?id=140895
Reviewed by Antti Koivisto.
First argument to DOM traversal functions should be a reference instead
of a pointer as it is dereferenced without null-check.
- 2:03 PM Changeset in webkit [179142] by
-
- 6 edits in trunk/Source/WebCore
[WebGL2] Update IDL for WebGL2.
https://bugs.webkit.org/show_bug.cgi?id=126406
<rdar://problem/15002268>.
Reviewed by Brent Fulgham.
Update WebGL2RenderingContext idl to match spec. Create method stubs as necessary.
- bindings/js/JSWebGL2RenderingContextCustom.cpp:
(WebCore::JSWebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::JSWebGL2RenderingContext::getInternalformatParameter):
(WebCore::JSWebGL2RenderingContext::getQueryParameter):
(WebCore::JSWebGL2RenderingContext::getSamplerParameter):
(WebCore::JSWebGL2RenderingContext::getSyncParameter):
(WebCore::JSWebGL2RenderingContext::getIndexedParameter):
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockName):
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::copyBufferSubData):
(WebCore::WebGL2RenderingContext::getBufferSubData):
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGL2RenderingContext::blitFramebuffer):
(WebCore::WebGL2RenderingContext::framebufferTextureLayer):
(WebCore::WebGL2RenderingContext::getInternalformatParameter):
(WebCore::WebGL2RenderingContext::invalidateFramebuffer):
(WebCore::WebGL2RenderingContext::invalidateSubFramebuffer):
(WebCore::WebGL2RenderingContext::readBuffer):
(WebCore::WebGL2RenderingContext::renderbufferStorageMultisample):
(WebCore::WebGL2RenderingContext::texStorage2D):
(WebCore::WebGL2RenderingContext::texStorage3D):
(WebCore::WebGL2RenderingContext::texImage3D):
(WebCore::WebGL2RenderingContext::texSubImage3D):
(WebCore::WebGL2RenderingContext::copyTexSubImage3D):
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
(WebCore::WebGL2RenderingContext::getFragDataLocation):
(WebCore::WebGL2RenderingContext::uniform1ui):
(WebCore::WebGL2RenderingContext::uniform2ui):
(WebCore::WebGL2RenderingContext::uniform3ui):
(WebCore::WebGL2RenderingContext::uniform4ui):
(WebCore::WebGL2RenderingContext::uniform1uiv):
(WebCore::WebGL2RenderingContext::uniform2uiv):
(WebCore::WebGL2RenderingContext::uniform3uiv):
(WebCore::WebGL2RenderingContext::uniform4uiv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x3fv):
(WebCore::WebGL2RenderingContext::vertexAttribI4i):
(WebCore::WebGL2RenderingContext::vertexAttribI4iv):
(WebCore::WebGL2RenderingContext::vertexAttribI4ui):
(WebCore::WebGL2RenderingContext::vertexAttribI4uiv):
(WebCore::WebGL2RenderingContext::vertexAttribIPointer):
(WebCore::WebGL2RenderingContext::vertexAttribDivisor):
(WebCore::WebGL2RenderingContext::drawArraysInstanced):
(WebCore::WebGL2RenderingContext::drawElementsInstanced):
(WebCore::WebGL2RenderingContext::drawRangeElements):
(WebCore::WebGL2RenderingContext::drawBuffers):
(WebCore::WebGL2RenderingContext::clearBufferiv):
(WebCore::WebGL2RenderingContext::clearBufferuiv):
(WebCore::WebGL2RenderingContext::clearBufferfv):
(WebCore::WebGL2RenderingContext::clearBufferfi):
(WebCore::WebGL2RenderingContext::createQuery):
(WebCore::WebGL2RenderingContext::deleteQuery):
(WebCore::WebGL2RenderingContext::isQuery):
(WebCore::WebGL2RenderingContext::beginQuery):
(WebCore::WebGL2RenderingContext::endQuery):
(WebCore::WebGL2RenderingContext::getQuery):
(WebCore::WebGL2RenderingContext::getQueryParameter):
(WebCore::WebGL2RenderingContext::createSampler):
(WebCore::WebGL2RenderingContext::deleteSampler):
(WebCore::WebGL2RenderingContext::isSampler):
(WebCore::WebGL2RenderingContext::bindSampler):
(WebCore::WebGL2RenderingContext::samplerParameteri):
(WebCore::WebGL2RenderingContext::samplerParameterf):
(WebCore::WebGL2RenderingContext::getSamplerParameter):
(WebCore::WebGL2RenderingContext::fenceSync):
(WebCore::WebGL2RenderingContext::isSync):
(WebCore::WebGL2RenderingContext::deleteSync):
(WebCore::WebGL2RenderingContext::clientWaitSync):
(WebCore::WebGL2RenderingContext::waitSync):
(WebCore::WebGL2RenderingContext::getSyncParameter):
(WebCore::WebGL2RenderingContext::createTransformFeedback):
(WebCore::WebGL2RenderingContext::deleteTransformFeedback):
(WebCore::WebGL2RenderingContext::isTransformFeedback):
(WebCore::WebGL2RenderingContext::bindTransformFeedback):
(WebCore::WebGL2RenderingContext::beginTransformFeedback):
(WebCore::WebGL2RenderingContext::endTransformFeedback):
(WebCore::WebGL2RenderingContext::transformFeedbackVaryings):
(WebCore::WebGL2RenderingContext::getTransformFeedbackVarying):
(WebCore::WebGL2RenderingContext::pauseTransformFeedback):
(WebCore::WebGL2RenderingContext::resumeTransformFeedback):
(WebCore::WebGL2RenderingContext::bindBufferBase):
(WebCore::WebGL2RenderingContext::bindBufferRange):
(WebCore::WebGL2RenderingContext::getIndexedParameter):
(WebCore::WebGL2RenderingContext::getUniformIndices):
(WebCore::WebGL2RenderingContext::getActiveUniforms):
(WebCore::WebGL2RenderingContext::getUniformBlockIndex):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockName):
(WebCore::WebGL2RenderingContext::uniformBlockBinding):
(WebCore::WebGL2RenderingContext::createVertexArray):
(WebCore::WebGL2RenderingContext::deleteVertexArray):
(WebCore::WebGL2RenderingContext::isVertexArray):
(WebCore::WebGL2RenderingContext::bindVertexArray):
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGL2RenderingContext.idl:
- platform/graphics/GraphicsTypes3D.h:
- 1:42 PM Changeset in webkit [179141] by
-
- 2 edits in trunk/Source/WebCore
Don't let the CSSValuePool's font family cache grow unbounded.
<https://webkit.org/b/140894>
Reviewed by Chris Dumez.
Darin pointed out to Chris who pointed out to me that the font family cache
in CSSValuePool can grow unbounded until we get a system memory pressure
notification. Put a limit on it like we did with the font face cache.
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
- 1:29 PM Changeset in webkit [179140] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r177404. rdar://problem/19419787
- 1:26 PM Changeset in webkit [179139] by
-
- 1 edit5 adds in branches/safari-600.1.4.15-branch/LayoutTests
Merged r177408. rdar://problem/19432686
- 1:26 PM Changeset in webkit [179138] by
-
- 38 edits in branches/safari-600.1.4.15-branch
Merged r177398. rdar://problem/19432686
- 12:57 PM Changeset in webkit [179137] by
-
- 2 edits in trunk/Source/WebCore
Plug leak in jsValueWithDictionaryInContext().
<https://webkit.org/b/140889>
Reviewed by Alexey Proskuryakov.
Add a missing JSStringRelease to plug leak that was showing up on leaks bot.
- platform/mac/SerializedPlatformRepresentationMac.mm:
(WebCore::jsValueWithDictionaryInContext):
- 12:56 PM Changeset in webkit [179136] by
-
- 2 edits in trunk/Tools
copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
https://bugs.webkit.org/show_bug.cgi?id=140896
Reviewed by Michael Saboff.
I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
makes our script do this.
Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
this would be harder given llvm's autoconf setup.
- Scripts/copy-webkitlibraries-to-product-directory:
- 12:51 PM Changeset in webkit [179135] by
-
- 2 edits in trunk/Tools
Update bot assignments.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 12:41 PM Changeset in webkit [179134] by
-
- 11 edits4 adds in trunk
Integrate WP python server into WebKit test framework
https://bugs.webkit.org/show_bug.cgi?id=127094
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Contains parameters of web platform test server.
- resources/config.json: Added.
Tools:
This patch adds W3C web server (wptserver) as a new HTTP server.
wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
- Scripts/webkitpy/common/system/executive_mock.py:
(MockProcess.communicate):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner.start_servers):
(LayoutTestRunner.stop_servers):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
(LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
(LayoutTestRunnerTests):
(LayoutTestRunnerTests.test_servers_started):
- Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed.
(Manager.init):
(Manager._is_http_test):
(Manager._is_web_platform_test):
(Manager._run_tests):
- Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_needs_servers.get_wpt_doc_root):
(ManagerTest.test_needs_servers.get_manager):
(ManagerTest.test_needs_servers):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
(parse_args):
- Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
(main):
- Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
(doc_root):
(base_url):
(WebPlatformTestServer):
(WebPlatformTestServer.init):
(WebPlatformTestServer._set_start_cmd):
(WebPlatformTestServer._copy_webkit_test_files):
(WebPlatformTestServer._clean_webkit_test_files):
(WebPlatformTestServer._prepare_config):
(WebPlatformTestServer._spawn_process):
(WebPlatformTestServer._stop_running_server):
- Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
(TestWebPlatformTestServer):
(TestWebPlatformTestServer.test_start_cmd):
- Scripts/webkitpy/port/base.py:
(Port.init):
(Port.to.start_web_platform_test_server):
(Port.to):
(Port.to.web_platform_test_server_doc_root):
(Port.to.web_platform_test_server_base_url):
(Port.to.stop_web_platform_test_server):
- Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
(Driver.init):
(Driver.is_web_platform_test):
(Driver.test_to_uri):
(Driver.uri_to_test):
(Driver._command_from_driver_input):
- Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules.
(DriverTest.test_test_to_uri):
(DriverTest.test_uri_to_test):
- 12:40 PM Changeset in webkit [179133] by
-
- 14 edits in branches/safari-600.1.4.15-branch
Merged r177377. rdar://problem/19419793
- 12:40 PM Changeset in webkit [179132] by
-
- 15 edits32 adds in trunk
Fix CSS Selector's tag name matching when mixing HTML and XML
https://bugs.webkit.org/show_bug.cgi?id=140878
Reviewed by Darin Adler.
Source/WebCore:
Previsouly, WebKit was unable to match any XML element that had
any uppercase character if the stylesheet was in a HTML document.
This problem was most often reported due to the inability to style
SVG-in-HTML.
The reason was that the tag local name was incorrectly transformed
to lowercase at parsing time. Instead, we are supposed to only
do case-insensitive match for HTML elements in a HTML document.
This fix is very similar with how we handle attributes:
-Keep both the original and the lowercase versions of the name.
-When matching, chose which version to use depending on the element being matched.
There is one major difference in the way the names are stored.
Unlike attribute selectors, tag name selectors are common, and the uppercase
version is not that uncommon. I wanted to preserve the dense representation
so I specialized CSSSelector specifically for tag names.
To store the data, if the name is already lowercase, just use the m_data pointer
as usual.
If the name is not lowercase, allocate a new small structure in the union to store
both names.
Tests: fast/css/tagname-and-namespace-case-sensitivity-xml-in-html.html
fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml-expected.xhtml
fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml.xhtml
fast/css/tagname-case-sensitivity-svg-in-html.html
fast/css/tagname-case-sensitivity-svg-in-xhtml-expected.xhtml
fast/css/tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/css/tagname-case-sensitivity-xml-in-html.html
fast/css/tagname-case-sensitivity-xml-in-xhtml-expected.xhtml
fast/css/tagname-case-sensitivity-xml-in-xhtml.xhtml
fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html.html
fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html.html
fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html.html
fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml.xhtml
fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html.html
fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml.xhtml
fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html.html
fast/selectors/tagname-descendant-backtracking-case-sensitivity-html.html
- css/CSSGrammar.y.in:
The parser is unaware of anything case related. CSSSelector takes care of that.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::createRareData):
- css/CSSSelector.h:
(WebCore::CSSSelector::NameWithCase::NameWithCase):
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::~CSSSelector):
(WebCore::CSSSelector::tagQName):
(WebCore::CSSSelector::tagLowercaseLocalName):
The new representation stores both the original form and the lower case
form.
- css/RuleSet.cpp:
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::shrinkToFit):
- css/RuleSet.h:
(WebCore::RuleSet::tagRules):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
The tag name partition is now split in two: lowercase and original case.
If the matched element is HTML, the lowercase partition is used.
- css/SelectorFilter.cpp:
(WebCore::collectElementIdentifierHashes):
(WebCore::collectDescendantSelectorIdentifierHashes):
This is the most annoying part of the patch performance wise:
the bloom filter knows the case of the real elements but it cannot know
how selectors will match them.
To make it work, all names are now converted to lowercase.
That implies that we can filter less on XML and we may have to pay for
converting the tag name to lowercase.
I expect the performance hit to be small because:
-Having two XML elements with the same name but different case is uncommon.
-Most elements use lowercase names.
Still sad...that's the price to pay for correctness.
- css/SelectorChecker.cpp:
(WebCore::tagMatches):
(WebCore::SelectorChecker::checkOne):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::tagMatches): Deleted.
Update the legacy matcher, nothing special.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::TagNamePattern::TagNamePattern):
(WebCore::SelectorCompiler::constructFragmentsInternal):
(WebCore::SelectorCompiler::equalTagNames):
(WebCore::SelectorCompiler::equalTagNamePatterns):
(WebCore::SelectorCompiler::computeBacktrackingStartOffsetInChain):
(WebCore::SelectorCompiler::computeBacktrackingHeightFromDescendant):
(WebCore::SelectorCompiler::computeBacktrackingWidthFromIndirectAdjacent):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):
Tag names are used to optimize backtracking; this is quite common for descendant
(e.g. div > ul > li).
We have to differenciate one new case there: if two tag names are equal
when compared case-insensitively but strictly different, they may still
be equal if they don't match the same kind of elements or both matches
and HTML element.
- dom/SelectorQuery.cpp:
(WebCore::localNameMatches):
(WebCore::elementsForLocalName):
(WebCore::SelectorDataList::executeSingleTagNameSelectorData):
Update the inline versions of SelectorQuery.
LayoutTests:
We had very little coverage for XHTML and XML in HTML.
I added lots of new tests to cover the basics.
- fast/dom/css-dom-read-2-expected.txt:
- fast/dom/css-dom-read-expected.txt:
CSSOM now provide the tagname in the original case instead of lowercase,
which is actually what the spec defines:
"If the character is not handled by one of the above rules and is greater
than or equal to U+0080, is "-" (U+002D) or "_" (U+005F), or is in one
of the ranges [0-9] (U+0030 to U+0039), [A-Z] (U+0041 to U+005A),
or [a-z] (U+0061 to U+007A), then the character itself."
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-html-expected.html: Added.
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-html.html: Added.
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml-expected.xhtml: Added.
- fast/css/tagname-and-namespace-case-sensitivity-xml-in-xhtml.xhtml: Added.
- fast/css/tagname-case-sensitivity-svg-in-html-expected.html: Added.
- fast/css/tagname-case-sensitivity-svg-in-html.html: Added.
- fast/css/tagname-case-sensitivity-svg-in-xhtml-expected.xhtml: Added.
- fast/css/tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/css/tagname-case-sensitivity-xml-in-html-expected.html: Added.
- fast/css/tagname-case-sensitivity-xml-in-html.html: Added.
- fast/css/tagname-case-sensitivity-xml-in-xhtml-expected.xhtml: Added.
- fast/css/tagname-case-sensitivity-xml-in-xhtml.xhtml: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-html.html: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
- fast/selectors/element-closest-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-html.html: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
- fast/selectors/element-matches-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-html.html: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-svg-in-xhtml.xhtml: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-html.html: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml-expected.txt: Added.
- fast/selectors/querySelector-tagname-case-sensitivity-xml-in-xhtml.xhtml: Added.
- fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html-expected.txt: Added.
- fast/selectors/tagname-adjacent-backtracking-case-sensitivity-html.html: Added.
- fast/selectors/tagname-descendant-backtracking-case-sensitivity-html-expected.txt: Added.
- fast/selectors/tagname-descendant-backtracking-case-sensitivity-html.html: Added.
- 12:04 PM Changeset in webkit [179131] by
-
- 3 edits in trunk/Source/WebCore
Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)
https://bugs.webkit.org/show_bug.cgi?id=140891
Reviewed by Anders Carlsson.
Use std::forward() instead of WTF::move() in CSSPrimitiveValue::create(T&& value)
to make sure the argument is not unexpectedly moved when it shouldn't (like I
experienced yesterday in Bug 140577):
<http://trac.webkit.org/changeset/179105>
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::create):
- css/CSSValuePool.h:
(WebCore::CSSValuePool::createValue):
- 11:45 AM Changeset in webkit [179130] by
-
- 2 edits in trunk/Tools
Teach run-webkit-app --simulator how to install custom built app
https://bugs.webkit.org/show_bug.cgi?id=140691
Reviewed by David Kilzer.
We should teach run-webkit-app --simulator how to install a custom built app.
Currently run-webkit-app --simulator can only run a system app or an app that
was installed using the simctl command line tool. For convenience we should
teach run-webkit-app --simulator how to install a custom built app.
As a side effect of this change run-safari --simulator will install and run
a custom built of MobileSafari (if it exists).
- Scripts/webkitdirs.pm:
(iOSSimulatorDevices): Added FIXME comment to decouple device representation in
Perl from the structure of the device.plist file.
(plistPathFromBundle): Fix if-statement condition so that we actually perform a
file system check to determine the plist path for a Mac app bundle.
(appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
it will complain that it cannot find the file: "Domain ... does not exist".
(appDisplayNameFromBundle): Ditto.
(waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
until a simulator device is the specified state.
(relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
(if it's open) before opening it again so as to ensure that the iOS Simulator boots
the specified device.
(quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
As implied by its name, this function will not return until the specified simulator
device UDID is in the shutdown state.
(iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
device with the specified UDID.
(isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
expression echoxcrun --sdk iphonesimulator --show-sdk-path/Applications/, contains a
symbolic link. Specifically, echoxcrun --sdk iphonesimulator --show-sdk-pathreturns
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
(hasUserInstalledAppInSimulatorDevice): Added.
(isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
"Booted" state.
(runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
switching between a system installed app and a custom built version of the same app (e.g.
custom build of MobileSafari) will erase all contents and settings in the simulator device.
(eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
as that was the only caller of this function.
(bootedIOSSimulatorDevice): Deleted.
(openIOSSimulator): Deleted.
- 11:44 AM Changeset in webkit [179129] by
-
- 6 edits in trunk/Source
Blacklist iBooks for WebKit's default immediate actions
https://bugs.webkit.org/show_bug.cgi?id=140854
-and corresponding-
rdar://problem/19489518
Reviewed by Tim Horton.
Source/WebCore:
Add a runtime check for iBooks.
- WebCore.exp.in:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsIBooks):
- platform/RuntimeApplicationChecks.h:
Source/WebKit2:
Blacklist iBooks.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _updateImmediateActionItem]):
- 11:38 AM Changeset in webkit [179128] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r177360. rdar://problem/19432691
- 11:38 AM Changeset in webkit [179127] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176384. rdar://problem/19432691
- 11:38 AM Changeset in webkit [179126] by
-
- 11 edits2 adds in branches/safari-600.1.4.15-branch
Merged r172854. rdar://problem/19432691
- 10:33 AM Changeset in webkit [179125] by
-
- 6 edits6 adds in branches/safari-600.1.4.15-branch
Merged r177135. rdar://problem/19450110
- 10:33 AM Changeset in webkit [179124] by
-
- 8 edits in trunk/Source
[iOS] [SVG -> OTF Converter] Flip the switch off on iOS
https://bugs.webkit.org/show_bug.cgi?id=140860
Reviewed by Darin Adler.
Source/JavaScriptCore:
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests because this simply reverts broken code.
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
The fonts it makes are grotesque. (See what I did there? Typographic
humor is the best humor.)
- Configurations/FeatureDefines.xcconfig:
- 10:31 AM Changeset in webkit [179123] by
-
- 2 edits in trunk/Tools
Update bot assignments.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:18 AM Changeset in webkit [179122] by
-
- 5 edits in trunk/Tools
Leaks bot shouldn't run JSC tests
https://bugs.webkit.org/show_bug.cgi?id=140877
Reviewed by Darin Adler.
Shaves off 48 minutes of time.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestLeaksFactory): Slim down the leaks queue.
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.print_leaks_summary):
- Scripts/webkitpy/port/mac.py:
(MacPort.print_leaks_summary):
Don't yell when leaks are detected.
- 10:03 AM Changeset in webkit [179121] by
-
- 2 edits in trunk
[cmake] Remove compiler version calculate cruft
https://bugs.webkit.org/show_bug.cgi?id=140885
Reviewed by Darin Adler.
- Source/cmake/WebKitHelpers.cmake:
- 10:02 AM Changeset in webkit [179120] by
-
- 2 edits in trunk/Tools
Refactor run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=140824
Reviewed by Darin Adler.
Separated mozilla, stress test code paths and
determining skipped mozilla tests into subroutines.
- Scripts/run-javascriptcore-tests:
(runMozillaTests):
(runJSCStressTests):
(defaultJsDriverArgsForMozillaTests):
- 9:52 AM Changeset in webkit [179119] by
-
- 4 edits in trunk/Source/WebCore
Demote 'line-height' to a low priority property.
https://bugs.webkit.org/show_bug.cgi?id=140817
Reviewed by Andreas Kling.
Our special handling of the 'line-height' property is no longer
required, since the 'font' shorthand is now expanded in the parser
in all cases (also for system fonts).
This patch is based on the following Blink revision:
https://src.chromium.org/viewvc/blink?revision=184629&view=revision
No new tests, already covered by:
fast/css/font-shorthand-line-height.html
fast/css/line-height-font-order.html
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
- css/StyleResolver.h:
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::setLineHeightValue): Deleted.
(WebCore::StyleResolver::State::lineHeightValue): Deleted.
- 9:51 AM Changeset in webkit [179118] by
-
- 3 edits4 adds in branches/safari-600.1.4.15-branch
Merged r177292. rdar://problem/19419760
- 9:51 AM Changeset in webkit [179117] by
-
- 1 edit2 adds in branches/safari-600.1.4.15-branch/PerformanceTests
Merged r177051. rdar://problem/19419760
- 9:20 AM Changeset in webkit [179116] by
-
- 3 edits in trunk/Tools
[buildbot] Fix grammar of TestWithFailureCount
https://bugs.webkit.org/show_bug.cgi?id=140884
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(TestWithFailureCount):
(TestWithFailureCount.commandComplete):
(TestWithFailureCount.getText2):
(RunUnitTests):
(RunPythonTests):
(RunPerlTests):
(RunLLINTCLoopTests):
(Run32bitJSCTests):
- BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(RunLLINTCLoopTestsTest.test_failure):
(Run32bitJSCTestsTest.test_failure):
(RunUnitTestsTest.assertFailures):
- 8:25 AM Changeset in webkit [179115] by
-
- 2 edits in trunk/Source/WebKit2
AX: crash in accessibilityRootObjectWrapper method (WebPageAccessibilityObjectAtk.cpp)
<https://bugs.webkit.org/show_bug.cgi?id=140618>
Patch by Fabien Vallée <fvallee@connected-labs.com> on 2015-01-26
Reviewed by Chris Fleizach.
Check if document()->axObjectCache() is nullptr to fix the crash.
Similar patch has been applied on mac port:
<http://trac.webkit.org/changeset/167136>
Crash occured on <http://itv.mit-xperts.com/hbbtvtest/appmanager/>
(this page needs CEHTML / HbbTV extensions, conditions cannot
be reproduced using regression tests)
- WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
(accessibilityRootObjectWrapper):
- 7:51 AM Changeset in webkit [179114] by
-
- 2 edits in trunk/Tools
Unreviewed. Moving myself to the committer section.
- 7:15 AM Changeset in webkit [179113] by
-
- 2 edits in trunk
[cmake] Stop compiling with -Wno-error=uninitialized and -Wno-error=literal-suffix
https://bugs.webkit.org/show_bug.cgi?id=140886
Reviewed by Žan Doberšek.
- Source/cmake/WebKitHelpers.cmake:
- 5:49 AM Changeset in webkit [179112] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Remove references to removed tests from GTK+ TestExpectations.
Shared workers are no longer supported and the layout tests were
removed.
- platform/gtk/TestExpectations:
- 3:12 AM Changeset in webkit [179111] by
-
- 10 edits2 moves in trunk
[GTK] gtkdoc does not appear in DevHelp
https://bugs.webkit.org/show_bug.cgi?id=139369
.:
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-26
Reviewed by Philippe Normand.
Expect the gtkdoc to be generated in folders named with the API version.
- Source/PlatformGTK.cmake:
Source/WebCore:
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-26
Reviewed by Philippe Normand.
- PlatformGTK.cmake: Include the API version in the gtkdoc filenames.
Source/WebKit2:
Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-26
Reviewed by Philippe Normand.
- PlatformGTK.cmake: Include the API version in the gtkdoc filenames.
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt.
- UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk.types.
Tools:
Patch by Michael Catanzaro <Michael Catanzaro> and Carlos Garcia Campos <cgarcia@igalia.com> on 2015-01-26
Reviewed by Philippe Normand.
- gtk/generate-gtkdoc: Create the generators in the main function
and use them to get the local cross renference dependencies. Also
pass the generator module name to webkitdom.write_doc_files().
(get_gtkdoc_module_paths): Receive a list of local cross reference
dependencies.
(get_generator_for_config): Set the main_sgml_file property of the
GtkDoc object from the configuration file.
(generate_documentation): Generate the documentation for the given
generator.
(generate_documentation_for_config): Deleted.
- gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
- gtk/webkitdom.py:
(write_doc_files): Receive the module name used to build the
-sections.txt filename.
- 1:42 AM Changeset in webkit [179110] by
-
- 3 edits in trunk
[EFL][GTK] Stop compiling with fno-omit-frame-pointer, -fno-tree-dce
https://bugs.webkit.org/show_bug.cgi?id=140609
Reviewed by Csaba Osztrogonác.
The latest releases of GCC versions 4.7, 4.8 and 4.9 all compile and
run JSC tests fine without the -fno-tree-dce and -fno-omit-frame-pointer
compilation flags. Those were added after the jsCStack branch merge, but
can now be removed since the -ftree-dce issues were fixed in GCC, and
changes in r173282 and r173298 again enable compiling with -fomit-frame-pointer.
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- 1:09 AM Changeset in webkit [179109] by
-
- 7 edits in trunk
Unreviewed, rolling out r179107.
https://bugs.webkit.org/show_bug.cgi?id=140880
The GCC in the bots doesn't support the AsyncTask
implementation (Requested by KaL on #webkit).
Reverted changeset:
"[GTK] Enable IndexedDB"
https://bugs.webkit.org/show_bug.cgi?id=98932
http://trac.webkit.org/changeset/179107
- 1:08 AM Changeset in webkit [179108] by
-
- 2 edits in trunk/Tools
[EFL] Bump libseccomp version to 2.1.1
https://bugs.webkit.org/show_bug.cgi?id=140357
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- 12:25 AM Changeset in webkit [179107] by
-
- 7 edits in trunk
[GTK] Enable IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=98932
Reviewed by Žan Doberšek.
.:
- Source/cmake/OptionsGTK.cmake: Enable DATABASE_PROCESS and INDEXED_DATABASE.
- Source/cmake/WebKitFeatures.cmake: Add ENABLE_DATABASE_PROCESS.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
LayoutTests:
- platform/gtk/TestExpectations: Update IndexedDB test expectations.
Jan 25, 2015:
- 11:59 PM Changeset in webkit [179106] by
-
- 8 edits1 add in trunk/Tools
Would like leaks bot results at build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=122657
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
than necessary, could use the ones from buildbot in more places.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue): Reflect configuration option for leaks queues.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
Add leaks queues to performance column. First, leaks are about performance indeed,
and second, this is where we have some space to spare.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
least a year.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid td): Moved height from queue-view - we can now have more than one
queue view per cell. The heigt is needed to avoid ugly overlapping while loading
results - once the results are loaded, all rows are currently higher than that.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
(.leaks-popover): Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
Load BuildbotLeaksQueueView.js.
- 11:10 PM Changeset in webkit [179105] by
-
- 2 edits in trunk/Source/WebCore
Remove 'font' shorthand property special casing
https://bugs.webkit.org/show_bug.cgi?id=140577
Reviewed by Darin Adler.
Mark CSSPrimitiveValue::m_value.fontFamily as const as it is not
supposed to change. This also makes sure that m_value.fontFamily
gets copied instead of moved when constructing a clone in
CSSPrimitiveValue::cloneForCSSOM(). This was causing several tests
to fail on the bots.
- css/CSSPrimitiveValue.h:
- 10:29 PM Changeset in webkit [179104] by
-
- 4 edits115 moves2518 adds in trunk/LayoutTests
[iOS] Update expected results and test expectations
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
[...]
- 9:01 PM Changeset in webkit [179103] by
-
- 6 edits in trunk/LayoutTests
fast/html/marquee-scrollamount.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140851
Reviewed by Darin Adler.
Updated the test to not have a zero delay timer race. Added many comments, because
what is being tested here is quite subtle.
- fast/html/marquee-scrollamount.html:
- platform/efl/fast/html/marquee-scrollamount-expected.txt:
- platform/gtk/fast/html/marquee-scrollamount-expected.txt:
- platform/ios-simulator-wk2/fast/html/marquee-scrollamount-expected.txt:
- platform/mac/fast/html/marquee-scrollamount-expected.txt:
The DOM changed slightly, because we now insert the marquee after load event.
- 8:04 PM Changeset in webkit [179102] by
-
- 3 edits2 adds in trunk
Setting HTMLMarqueeElement.trueSpeed doesn't work
https://bugs.webkit.org/show_bug.cgi?id=140863
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/html/marquee-set-truespeed.html
- html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::minimumDelay):
Check the boolean attribute properly - an empty value is true.
LayoutTests:
Verify that setting scrollDelay to a value under 60 actually works when trueSpeed is set.
- fast/html/marquee-set-truespeed-expected.html: Added.
- fast/html/marquee-set-truespeed.html: Added.
- 7:22 PM Changeset in webkit [179101] by
-
- 7 edits in trunk/Source/WebCore
Streamline SVGUseElement shadow tree handling and make it use SVGElementInstance less
https://bugs.webkit.org/show_bug.cgi?id=140875
Reviewed by Anders Carlsson.
Refactoring of code that is pretty well covered by existing tests, so
not adding new tests.
Inspired by work Rob Buis did in Blink:
http://src.chromium.org/viewvc/blink?view=revision&revision=173273
Althgouh that is less than half of what ended up in this patch.
- dom/ContainerNode.h: Fixed NoEventDispatchAssertion so it can be
copied without causing an underflow of NoEventDispatchAssertion::s_count.
Made the copy constructor call the default constructor. Also changed it
to be based on ASSERT_DISABLED rather than NDEBUG and tweaked it a bit.
- dom/ElementIteratorAssertions.h: Removed an unnecessary include and
an unnecessary default constructor. Changed to use WTF::Optional instead
of WTF::OwnPtr to handle NoEventDispatchAssertion, which makes this class
copyable and assignable, which in turn makes the iterators based on this
copyable and assignable, which is what I needed in SVGUseElement code.
Also simplified code in a couple places.
- dom/TypedElementDescendantIterator.h:
(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
Fixed an error where the arguments to Traversal::next were passed backwards.
This led to incomplete iteration in SVGUseElement code, and an immediate
assertion failure. Probably could use some unit test coverage, too.
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):
Ditto.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::animatedInstanceRoot): Deleted.
(WebCore::SVGUseElement::transferSizeAttributesToShadowTreeTargetClone):
Removed the originalElement argument, since we can use the correspondingElement
to get back to it. Removed the useElement argument and changed this into a
member function.
(WebCore::SVGUseElement::svgAttributeChanged): Updated for above changes.
(WebCore::subtreeContainsDisallowedElement): Deleted this function, because
it was only used to optimize by not calling removeDisallowedElementsFromSubtree,
but that function is already similarly efficient when called to do nothing, so
the preflight was not useful.
(WebCore::SVGUseElement::clearResourceReferences): Call userAgentShadowRoot
instead of shadowRoot for clarity.
(WebCore::SVGUseElement::buildPendingResource): Pass a reference instead of
a pointer to buildShadowAndInstanceTree, since it's guaranteed to not be null.
(WebCore::SVGUseElement::shadowTreeTargetClone): Added. Returns the SVG element
inside the shadow tree that corresponds to the use element's target.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Changed argument type
to a reference instead of a pointer. Removed comments explaining why we have
an instance tree, since soon we will not have one. Removed many comments that
simply state the names of the functions they are commenting on and perhaps a tiny
bit more. Changed to not use m_targetElementInstance as much, dealing with the
shadow tree directly instead of through the instance tree.
(WebCore::SVGUseElement::toClipPath): Use shadowTreeTargetClone instead of
getting at the element through m_targetElementInstance.
(WebCore::SVGUseElement::rendererClipChild): Ditto.
(WebCore::removeDisallowedElementsFromSubtree): Removed the inline keyword,
since there's no good reason to inline thif function's body. Improved local
variable names and used a modern for loop. Also moved the comment about why
this function is used here inside the function instead of repeating it at
each call site.
(WebCore::SVGUseElement::buildShadowTree): Changed to take a reference
instead of a pointer. Moved the check to see if the target is disallowed
out of this function and into buildShadowAndInstanceTree, which needs to
handle that failure explicitly. Tightened up the code a bit, using Ref instead
of RefPtr, putting the comment about removeDisallowedElementsFromSubtree into
that function itself, and removing the unneeded subtreeContainsDisallowedElement
check entirely.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Removed the argument,
getting the shadow tree from the shadowTree function instead. Walk the tree
iteratively instead of recursively, using the descendantsOfType function.
Rearranged and streamlined the logic.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Ditto.
(WebCore::SVGUseElement::transferEventListenersToShadowTree): Ditto.
(WebCore::SVGUseElement::transferAttributesToShadowTreeReplacement): Renamed
this to avoid the term "replaced element", which is not a reasonable way to
refer to the <g> element in the shadow tree that replaces the <use> element.
Changed the argument type to SVGGElement to make it harder to misuse this
function by accident, and made the use element be "this" instead of passing
it as an argument.
(WebCore::SVGUseElement::selfHasRelativeLengths): Call hasRelativeLengths
on the target inside the shadow tree rather than the original target, which
makes more sense anyway, and is straightforward now that we have the
shadowTreeTargetClone function. Removes use of m_targetElementInstance here.
- svg/SVGUseElement.h: Updated for above changes.
- svg/SVGUseElement.idl: Removed animatedInstanceRoot and tweaked formatting.
- 6:11 PM Changeset in webkit [179100] by
-
- 22 edits5 adds in trunk
Remove 'font' shorthand property special casing
https://bugs.webkit.org/show_bug.cgi?id=140577
Reviewed by Darin Adler.
Source/WebCore:
Expand system font values during 'font' property parsing. The 'font'
CSS property was the only shorthand that wasn't always expanded in
the CSS parser, so it needed a lot of special handling that we can
now get rid of.
This patch is inspired from the following Blink revision:
https://src.chromium.org/viewvc/blink?view=rev&revision=184449
Tests:
- fast/css/css2-system-fonts.html (existing)
- fast/css/CSSPrimitiveValue-font-family-primitiveType.html (new)
- fast/css/font-systemFontID-parsing.html (new)
- fast/css/font-shorthand-line-height.html (rebased)
- WebCore.xcodeproj/project.pbxproj:
- css/CSSCalculationValue.cpp:
(WebCore::hasDoubleValue):
Handle CSS_FONT_FAMILY similarly to CSS_STRING in the switch.
- css/CSSFontFamily.h: Added.
Introduce new CSSFontFamily class to store font families inside
CSSPrimitive, instead of using a simple String as previously. We need
an additional 'fromSystemFontID' flag in addition to the font family
name now that system font ID are expanded during parsing. This
information is needed later on by the StyleBuilder (see comment below).
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
Update code dealing with font family CSSPrimitiveValues now that they
hold a CSSFontFamily internally instead of a String.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSystemFont):
Expand system font values for the 'font' property by asking the
RenderTheme for the system font and using it to set the 'font'
longhand properties.
- css/CSSParserValues.cpp:
(WebCore::CSSParserValue::createCSSValue):
Handle CSS_FONT_FAMILY value in the switch.
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::primitiveType):
Make sure we still expose font family CSSPrimitiveValues to the Web as
CSS_STRING, even though we are using a slightly different representation
internally. This is so that we don't change web-exposed behavior and I
added a new layout test to cover this.
(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
Handle CSS_FONT_FAMILY type in switches.
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isFontFamily):
Add method to test if a CSSPrimitiveValue holds a CSSFontFamily
internally.
(WebCore::CSSPrimitiveValue::fontFamily):
Add a getter to retrieve the internal CSSFontFamily object if the
primitive type is CSS_FONT_FAMILY.
- css/CSSPropertyNames.in:
Treat 'font' as a regular shorthand property. Specify its longhand
properties so that makeprop.pl can generate the shorthand code for
us. Also demote 'font' to being a low-priority property as it is
now always expanded during parsing.
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
- css/CSSValuePool.h:
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueFontFamily):
- Update the 'font-family' value setter in the StyleBuilder to reflect
the changes in the CSS parser. The CSSPrimitiveValues in the list now
have CSS_FONT_FAMILY type instead of CSS_STRING.
- We also set the 'isGenericFamily' flag if the font-family was expanded
from a system font ID (e.g. caption). The 'isGenericFamily' flag is
used later on to property set the 'isSpecifiedFont' flag on the
FontDescription object. If we don't do this, system font values will
be treated as specified fonts, which means that we will no longer use
the 'use backslash as Yen sign' hack for those. This is covered by the
following layout tests:
- fast/text/backslash-to-yen-sign-euc.html
- editing/selection/find-yensign-and-backslash.html
(WebCore::StyleBuilderCustom::applyInitialFont): Deleted.
(WebCore::StyleBuilderCustom::applyInheritFont): Deleted.
(WebCore::StyleBuilderCustom::applyValueFont): Deleted.
Remove StyleBuilder code dealing with the 'font' property. Now that
the 'font' property is always expanded during parsing, this code can
never be reached.
- css/StylePropertyShorthand.cpp:
(WebCore::isExpandedShorthand):
Stop returning false for 'font' as it is now expanded during parsing
as well. We should probably consider renaming this method to something
else now that all shorthands are expanded, maybe isCSSShorthand() or
isShorthandProperty().
(WebCore::fontShorthand): Deleted.
- css/StylePropertyShorthand.h:
(WebCore::matchingCustomShorthandsForLonghand): Deleted.
Remove custom shorthand code for the 'font' property as it is now
generated by makeprop.pl, like other shorthands.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyFont): Deleted.
This is unused now that the StyleBuilder code for 'font' has been
removed.
- css/makeprop.pl:
Remove custom shorthand code for 'font' as it no longer requires any
special handling.
LayoutTests:
- fast/css/CSSPrimitiveValue-font-family-primitiveType-expected.txt: Added.
- fast/css/CSSPrimitiveValue-font-family-primitiveType.html: Added.
Add layout test to make sure that the font-family is still exposed to the
Web as a CSSValueList of CSSPrimitiveValues whose primitiveType is
CSS_STRING. This is useful because we now use a slightly different
representation internally.
- fast/css/font-shorthand-line-height-expected.txt:
- fast/css/font-shorthand-line-height.html:
Rebaseline the test. This is a progression. Setting the 'font' property
to a system font ID is supposed to reset the line-height property to
'normal'. It previously did not because system font IDs were not
expanded at parsing time. The new behavior is consistent with Chrome and
Firefox as well.
- fast/css/font-systemFontID-parsing-expected.txt: Added.
- fast/css/font-systemFontID-parsing.html: Added.
Add a layout test to make sure that the CSS parser is rejecting a 'font'
property with more than one system font id.
- 4:14 PM Changeset in webkit [179099] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177449. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179098] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177444. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179097] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r177332. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179096] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r177306. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179095] by
-
- 18 edits in branches/safari-600.1.4.15-branch/Source
Merged r177301. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179094] by
-
- 5 edits8 adds in branches/safari-600.1.4.15-branch
Merged r177050. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179093] by
-
- 1 edit in branches/safari-600.1.4.15-branch/Source/WebCore/ChangeLog
Merged r177041. rdar://problem/19419933
- 4:14 PM Changeset in webkit [179092] by
-
- 29 edits in branches/safari-600.1.4.15-branch
Merged r177035. rdar://problem/19419933
- 11:40 AM Changeset in webkit [179091] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
Document a few more failures in the expectations file.
- platform/win/TestExpectations:
- 11:28 AM Changeset in webkit [179090] by
-
- 2 edits in trunk/LayoutTests
[Win] Document some Debug crashes in Accessibility code.
- platform/win/TestExpectations:
- 10:37 AM Changeset in webkit [179089] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
Skip crashes and timeouts to speed up test runs.
- platform/win/TestExpectations:
- 10:01 AM Changeset in webkit [179088] by
-
- 9 edits3 adds in trunk
[Win] Add WebKit message loop interface.
https://bugs.webkit.org/show_bug.cgi?id=140857
Patch by peavo@outlook.com <peavo@outlook.com> on 2015-01-25
Reviewed by Brent Fulgham.
Added message loop interface which will run the message loop,
and perform required tasks (like calling CFRunLoopRunInMode)
on each iteration of the loop.
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Added new files to project.
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto.
Source/WebKit/win:
- ForEachCoClass.h:
- Interfaces/WebKit.idl:
- Interfaces/WebKitMessageLoop.idl: Added.
- WebKitClassFactory.cpp:
- WebKitMessageLoop.cpp: Added.
(WebKitMessageLoop::WebKitMessageLoop):
(WebKitMessageLoop::~WebKitMessageLoop):
(WebKitMessageLoop::createInstance):
(WebKitMessageLoop::QueryInterface):
(WebKitMessageLoop::AddRef):
(WebKitMessageLoop::Release):
(WebKitMessageLoop::run):
(WebKitMessageLoop::performMessageLoopTasks):
- WebKitMessageLoop.h: Added.
Tools:
- WinLauncher/WinMain.cpp:
(wWinMain): Use new message loop interface.
- 12:20 AM Changeset in webkit [179087] by
-
- 2 edits in trunk/Source/WebKit2
Unresponsive Web processes sometimes throw ObjC exceptions under didPerformActionMenuHitTest:
https://bugs.webkit.org/show_bug.cgi?id=140859
<rdar://problem/19571057>
Reviewed by Darin Adler.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):
If we've already given up on this gesture (either because it was canceled or the
willBeginAnimation timeout expired), we shouldn't build a new animationController for it.
This is true both because it wouldn't look good to swap animationControllers out
from under the gesture, but also because AppKit throws an exception when you do this
and that breaks a lot of things.
- 12:17 AM Changeset in webkit [179086] by
-
- 2 edits in trunk/Source/WebCore
Long spins under Frame::rangeForPoint when doing Lookup on feedly.com
https://bugs.webkit.org/show_bug.cgi?id=140862
<rdar://problem/19566089>
Reviewed by Dan Bernstein.
- page/Frame.cpp:
(WebCore::Frame::rangeForPoint):
If there isn't a selectable text node at the given point, rangeForPoint
will eventually return null. However, we can make it fail much faster
by checking the initial position's text-ness and selectability.
- 12:02 AM Changeset in webkit [179085] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening for EFL port.
- platform/efl/TestExpectations: media/media-fullscreen-inline.html has been passed since r19100.
Jan 24, 2015:
- 11:35 PM Changeset in webkit [179084] by
-
- 16 edits13 adds in trunk/LayoutTests
[Win] More rebaselines. (Tables)
- platform/win/tables/mozilla/bugs/bug1188-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug1188-expected.txt:
- platform/win/tables/mozilla/bugs/bug18359-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug18359-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-3-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug2479-3-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-4-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug2479-4-expected.txt:
- platform/win/tables/mozilla/bugs/bug29326-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug29326-expected.txt:
- platform/win/tables/mozilla/bugs/bug33855-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug33855-expected.txt:
- platform/win/tables/mozilla/bugs/bug4382-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug4382-expected.txt:
- platform/win/tables/mozilla/bugs/bug4527-expected.txt:
- platform/win/tables/mozilla/bugs/bug96334-expected.png: Added.
- platform/win/tables/mozilla/bugs/bug96334-expected.txt:
- platform/win/tables/mozilla/core/margins-expected.png: Added.
- platform/win/tables/mozilla/core/margins-expected.txt:
- platform/win/tables/mozilla/dom/tableDom-expected.png: Added.
- platform/win/tables/mozilla/dom/tableDom-expected.txt:
- platform/win/tables/mozilla/other/move_row-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
- platform/win/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
- 11:14 PM Changeset in webkit [179083] by
-
- 67 edits43 adds in trunk/LayoutTests
[Win] Unreviewed rebaselining.
Second batch: Fast
- platform/win/fast/block/float/float-avoidance-expected.png: Added.
- platform/win/fast/block/margin-collapse/103-expected.png: Added.
- platform/win/fast/canvas/fallback-content-expected.txt:
- platform/win/fast/css/non-standard-checkbox-size-expected.png: Added.
- platform/win/fast/css/non-standard-checkbox-size-expected.txt:
- platform/win/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
- platform/win/fast/forms/001-expected.png:
- platform/win/fast/forms/001-expected.txt:
- platform/win/fast/forms/003-expected.png: Added.
- platform/win/fast/forms/003-expected.txt:
- platform/win/fast/forms/004-expected.png: Added.
- platform/win/fast/forms/004-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label01-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label01-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label02-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label02-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label03-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label03-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label04-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label04-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/win/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/win/fast/forms/basic-inputs-expected.png:
- platform/win/fast/forms/basic-inputs-expected.txt:
- platform/win/fast/forms/basic-selects-expected.png:
- platform/win/fast/forms/basic-selects-expected.txt:
- platform/win/fast/forms/basic-textareas-quirks-expected.png: Added.
- platform/win/fast/forms/box-shadow-override-expected.png:
- platform/win/fast/forms/box-shadow-override-expected.txt:
- platform/win/fast/forms/control-clip-overflow-expected.png: Added.
- platform/win/fast/forms/control-clip-overflow-expected.txt:
- platform/win/fast/forms/control-restrict-line-height-expected.png: Added.
- platform/win/fast/forms/control-restrict-line-height-expected.txt:
- platform/win/fast/forms/disabled-select-change-index-expected.png: Added.
- platform/win/fast/forms/disabled-select-change-index-expected.txt:
- platform/win/fast/forms/file/file-input-disabled-expected.png:
- platform/win/fast/forms/file/file-input-disabled-expected.txt:
- platform/win/fast/forms/form-element-geometry-expected.png: Added.
- platform/win/fast/forms/form-element-geometry-expected.txt:
- platform/win/fast/forms/formmove-expected.png: Added.
- platform/win/fast/forms/formmove-expected.txt:
- platform/win/fast/forms/indeterminate-expected.png: Added.
- platform/win/fast/forms/indeterminate-expected.txt:
- platform/win/fast/forms/input-appearance-height-expected.png: Added.
- platform/win/fast/forms/input-appearance-height-expected.txt:
- platform/win/fast/forms/input-appearance-selection-expected.png: Added.
- platform/win/fast/forms/input-appearance-selection-expected.txt: Added.
- platform/win/fast/forms/menulist-deselect-update-expected.txt:
- platform/win/fast/forms/menulist-no-overflow-expected.png: Added.
- platform/win/fast/forms/menulist-no-overflow-expected.txt:
- platform/win/fast/forms/menulist-restrict-line-height-expected.png: Added.
- platform/win/fast/forms/menulist-restrict-line-height-expected.txt:
- platform/win/fast/forms/menulist-separator-painting-expected.txt:
- platform/win/fast/forms/menulist-style-color-expected.png:
- platform/win/fast/forms/menulist-style-color-expected.txt:
- platform/win/fast/forms/menulist-width-change-expected.txt:
- platform/win/fast/forms/option-script-expected.txt:
- platform/win/fast/forms/option-strip-whitespace-expected.png: Added.
- platform/win/fast/forms/option-strip-whitespace-expected.txt:
- platform/win/fast/forms/option-text-clip-expected.png:
- platform/win/fast/forms/option-text-clip-expected.txt:
- platform/win/fast/forms/range/input-appearance-range-expected.png: Added.
- platform/win/fast/forms/range/input-appearance-range-expected.txt:
- platform/win/fast/forms/range/slider-delete-while-dragging-thumb-expected.txt: Added.
- platform/win/fast/forms/range/slider-mouse-events-expected.txt:
- platform/win/fast/forms/range/slider-onchange-event-expected.txt: Added.
- platform/win/fast/forms/range/slider-padding-expected.txt:
- platform/win/fast/forms/range/slider-thumb-shared-style-expected.png: Added.
- platform/win/fast/forms/range/slider-thumb-shared-style-expected.txt:
- platform/win/fast/forms/range/slider-zoomed-expected.txt: Added.
- platform/win/fast/forms/select-align-expected.png: Added.
- platform/win/fast/forms/select-align-expected.txt:
- platform/win/fast/forms/select-background-none-expected.txt:
- platform/win/fast/forms/select-baseline-expected.png: Added.
- platform/win/fast/forms/select-baseline-expected.txt:
- platform/win/fast/forms/select-change-listbox-to-popup-expected.png: Added.
- platform/win/fast/forms/select-change-listbox-to-popup-expected.txt:
- platform/win/fast/forms/select-change-popup-to-listbox-expected.png: Added.
- platform/win/fast/forms/select-change-popup-to-listbox-expected.txt: Added.
- platform/win/fast/forms/select-disabled-appearance-expected.png: Added.
- platform/win/fast/forms/select-disabled-appearance-expected.txt:
- platform/win/fast/forms/select-initial-position-expected.png: Added.
- platform/win/fast/forms/select-initial-position-expected.txt:
- platform/win/fast/forms/select-selected-expected.png: Added.
- platform/win/fast/forms/select-selected-expected.txt:
- platform/win/fast/forms/select-size-expected.txt:
- platform/win/fast/forms/select-style-expected.png: Added.
- platform/win/fast/forms/select-style-expected.txt:
- platform/win/fast/forms/select-visual-hebrew-expected.txt:
- platform/win/fast/forms/select-writing-direction-natural-expected.png:
- platform/win/fast/forms/select-writing-direction-natural-expected.txt:
- platform/win/fast/forms/select/optgroup-rendering-expected.png:
- platform/win/fast/forms/select/optgroup-rendering-expected.txt:
- platform/win/fast/forms/selectlist-minsize-expected.txt:
- platform/win/fast/forms/stuff-on-my-optgroup-expected.png: Added.
- platform/win/fast/forms/stuff-on-my-optgroup-expected.txt:
- platform/win/fast/invalid: Added.
- platform/win/fast/invalid/014-expected.txt: Added.
- platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
- platform/win/fast/parser: Added.
- platform/win/fast/parser/entity-comment-in-textarea-expected.txt: Added.
- platform/win/fast/parser/open-comment-in-textarea-expected.txt: Added.
- platform/win/fast/repaint/slider-thumb-drag-release-expected.txt:
- platform/win/fast/replaced/three-selects-break-expected.txt:
- platform/win/fast/text/international/bidi-menulist-expected.txt:
- platform/win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/win/fast/text/textIteratorNilRenderer-expected.txt:
- 9:46 PM Changeset in webkit [179082] by
-
- 22 edits in trunk/LayoutTests
[Win] Unreviewed baseline update.
First batch: CSS updates.
- platform/win/css2.1/t09-c5526c-display-00-e-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-161-expected.png:
- platform/win/css3/selectors3/html/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-25-expected.png:
- platform/win/css3/selectors3/html/css3-modsel-25-expected.txt:
- platform/win/css3/selectors3/html/css3-modsel-70-expected.png:
- platform/win/css3/selectors3/html/css3-modsel-70-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
- platform/win/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.png:
- platform/win/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
- platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.png:
- platform/win/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.png:
- platform/win/css3/selectors3/xml/css3-modsel-161-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-25-expected.png:
- platform/win/css3/selectors3/xml/css3-modsel-25-expected.txt:
- platform/win/css3/selectors3/xml/css3-modsel-70-expected.png:
- platform/win/css3/selectors3/xml/css3-modsel-70-expected.txt:
- platform/win/fast/block/float/float-avoidance-expected.txt:
- platform/win/fast/block/margin-collapse/103-expected.txt:
- 8:36 PM Changeset in webkit [179081] by
-
- 2 edits in trunk/Tools
update-webkit’s --internal option is unused
https://bugs.webkit.org/show_bug.cgi?id=140861
Reviewed by Anders Carlsson.
- Scripts/update-webkit: Removed the option.
- 7:02 PM Changeset in webkit [179080] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Cocoa] Drop WKDiagnosticLoggingResultType defines
https://bugs.webkit.org/show_bug.cgi?id=140838
Reviewed by Sam Weinig.
Drop WKDiagnosticLoggingResultType defines in _WKDiagnosticLoggingDelegate.h
header now that the client-side is correctly using
_WKDiagnosticLoggingResultType instead.
- UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
- 6:55 PM Changeset in webkit [179079] by
-
- 26 edits81 adds in trunk/LayoutTests
[Win] Unreviewed gardening. Reactivating tests.
Re-enable a series of tests that work properly on Windows. New baselines will be needed.
- platform/win/TestExpectations:
- platform/win/css1/box_properties/acid_test-expected.png: Added.
- platform/win/css1/box_properties/acid_test-expected.txt:
- platform/win/editing/input/caret-at-the-edge-of-input-expected.txt:
- platform/win/fast/block/float/float-avoidance-expected.txt:
- platform/win/fast/block/margin-collapse/103-expected.txt:
- platform/win/fast/css/box-shadow-and-border-radius-expected.png:
- platform/win/fast/dynamic/008-expected.txt: Added.
- platform/win/fast/forms/001-expected.png: Added.
- platform/win/fast/forms/001-expected.txt:
- platform/win/fast/forms/003-expected.txt:
- platform/win/fast/forms/004-expected.txt:
- platform/win/fast/forms/006-expected.png: Added.
- platform/win/fast/forms/007-expected.png: Added.
- platform/win/fast/forms/HTMLOptionElement_label01-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label02-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label03-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label04-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label05-expected.txt: Added.
- platform/win/fast/forms/HTMLOptionElement_label06-expected.txt: Removed property svn:executable.
- platform/win/fast/forms/HTMLOptionElement_label07-expected.txt: Added.
- platform/win/fast/forms/basic-buttons-expected.png: Added.
- platform/win/fast/forms/basic-buttons-expected.txt: Added.
- platform/win/fast/forms/basic-inputs-expected.png: Added.
- platform/win/fast/forms/basic-selects-expected.txt:
- platform/win/fast/forms/basic-textareas-expected.png: Added.
- platform/win/fast/forms/box-shadow-override-expected.png: Added.
- platform/win/fast/forms/box-shadow-override-expected.txt: Added.
- platform/win/fast/forms/button-positioned-expected.txt: Added.
- platform/win/fast/forms/button-sizes-expected.txt: Added.
- platform/win/fast/forms/button-style-color-expected.txt: Added.
- platform/win/fast/forms/button-text-transform-expected.txt: Added.
- platform/win/fast/forms/control-clip-overflow-expected.txt: Added.
- platform/win/fast/forms/control-restrict-line-height-expected.txt:
- platform/win/fast/forms/disabled-select-change-index-expected.txt: Added.
- platform/win/fast/forms/form-element-geometry-expected.txt: Added.
- platform/win/fast/forms/hidden-listbox-expected.txt: Added.
- platform/win/fast/forms/input-appearance-focus-expected.txt: Added.
- platform/win/fast/forms/input-double-click-selection-gap-bug-expected.txt: Added.
- platform/win/fast/forms/input-readonly-autoscroll-expected.txt: Added.
- platform/win/fast/forms/input-text-double-click-expected.txt: Added.
- platform/win/fast/forms/listbox-hit-test-zoomed-expected.txt: Added.
- platform/win/fast/forms/listbox-scrollbar-incremental-load-expected.txt: Added.
- platform/win/fast/forms/listbox-width-change-expected.txt: Added.
- platform/win/fast/forms/menulist-deselect-update-expected.txt:
- platform/win/fast/forms/menulist-no-overflow-expected.txt: Added.
- platform/win/fast/forms/number/number-appearance-rtl-expected.txt: Added.
- platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: Added.
- platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt: Added.
- platform/win/fast/forms/option-strip-whitespace-expected.txt: Added.
- platform/win/fast/forms/plaintext-mode-2-expected.txt: Added.
- platform/win/fast/forms/search: Added.
- platform/win/fast/forms/search/search-size-with-decorations-expected.txt: Added.
- platform/win/fast/forms/select-align-expected.txt: Added.
- platform/win/fast/forms/select-baseline-expected.txt: Added.
- platform/win/fast/forms/select-block-background-expected.txt: Added.
- platform/win/fast/forms/select-change-listbox-size-expected.txt: Added.
- platform/win/fast/forms/select-change-listbox-to-popup-expected.txt: Added.
- platform/win/fast/forms/select-dirty-parent-pref-widths-expected.txt: Added.
- platform/win/fast/forms/select-disabled-appearance-expected.txt: Added.
- platform/win/fast/forms/select-initial-position-expected.txt: Added.
- platform/win/fast/forms/select-item-background-clip-expected.txt: Added.
- platform/win/fast/forms/select-list-box-with-height-expected.txt: Added.
- platform/win/fast/forms/select-selected-expected.txt: Added.
- platform/win/fast/forms/select/optgroup-rendering-expected.txt:
- platform/win/fast/forms/tabbing-input-iframe-expected.txt: Added.
- platform/win/fast/frames: Added.
- platform/win/fast/frames/take-focus-from-iframe-expected.txt: Added.
- platform/win/fast/multicol/pagination: Added.
- platform/win/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
- platform/win/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
- platform/win/fast/overflow/entity-comment-in-textarea-expected.txt: Added.
- platform/win/fast/overflow/open-comment-in-textarea-expected.txt: Added.
- platform/win/fast/overflow/overflow-x-y-expected.txt: Added.
- platform/win/fast/table/003-expected.txt: Added.
- platform/win/fast/table/colspanMinWidth-expected.txt: Added.
- platform/win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug103533-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug1188-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug12384-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug1318-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug18359-expected.txt:
- platform/win/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug26178-expected.txt:
- platform/win/tables/mozilla/bugs/bug28928-expected.txt:
- platform/win/tables/mozilla/bugs/bug29326-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug30559-expected.txt:
- platform/win/tables/mozilla/bugs/bug30692-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug33855-expected.txt:
- platform/win/tables/mozilla/bugs/bug4382-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug4429-expected.txt:
- platform/win/tables/mozilla/bugs/bug44505-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug51037-expected.txt:
- platform/win/tables/mozilla/bugs/bug55545-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug92647-2-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug96334-expected.txt: Added.
- platform/win/tables/mozilla/bugs/bug99948-expected.txt: Added.
- platform/win/tables/mozilla/core: Added.
- platform/win/tables/mozilla/core/bloomberg-expected.txt: Added.
- platform/win/tables/mozilla/core/margins-expected.txt: Added.
- platform/win/tables/mozilla/dom/tableDom-expected.txt:
- platform/win/tables/mozilla/marvin/x_col_align_justify-expected.png: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
- platform/win/tables/mozilla_expected_failures/bugs/bug45621-expected.txt: Added.
- platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- 5:28 PM Changeset in webkit [179078] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176725. rdar://problem/19432746
- 5:28 PM Changeset in webkit [179077] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged 'resolvedURL' changes from r176108. rdar://problem/19432746
- 4:54 PM Changeset in webkit [179076] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r176475. rdar://problem/19450119
- 4:54 PM Changeset in webkit [179075] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175251. rdar://problem/19450119
- 4:08 PM Changeset in webkit [179074] by
-
- 2 edits in trunk/Tools
DumpRenderTree needs to run with Windows native controls on Windows
https://bugs.webkit.org/show_bug.cgi?id=25592
Reviewed by Anders Carlsson.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
(prepareConsistentTestingEnvironment): Ditto.
- 12:36 PM Changeset in webkit [179073] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r176382. rdar://problem/19419810
- 12:30 PM Changeset in webkit [179072] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r176321. rdar://problem/19369495
- 12:16 PM Changeset in webkit [179071] by
-
- 8 edits2 adds in branches/safari-600.1.4.15-branch
Merged r176262. rdar://problem/19432679
- 12:16 PM Changeset in webkit [179070] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175260. rdar://problem/19432679
- 11:55 AM Changeset in webkit [179069] by
-
- 7 edits6 adds in trunk
Move height/width implementation for use element from RenderSVGViewportContainer to SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=140826
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: svg/animations/use-animate-width-and-height.html
svg/custom/use-attribute-invalidations.html
svg/custom/use-dynamic-attribute-setting.html
This is an adaptation of work Rob Buis did in Blink:
http://src.chromium.org/viewvc/blink?view=revision&revision=173258
The goal here is to reduce use of SVGElementInstance since we are going to
remove it. The tests Rob added to Blink (which I believe I improved a bit here)
meant we had to fix quite a few bugs in the implementation of the width/height
logic rather than just moving it. Even so, this could use even more test coverage
since there is separate logic for <symbol> and <svg>, three different code paths
(animation/attribute setting, initial creation, and one other), and also
distinct issues for attributes not set at all, attributes set to values that
can't be parsed, and attributes set with different units.
- rendering/svg/RenderSVGViewportContainer.cpp:
(WebCore::RenderSVGViewportContainer::calcViewport): Removed the old logic.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::SVGSVGElement): Use ASCIILiteral to more efficiently
create strings from ASCII literals here.
(WebCore::SVGSVGElement::parseAttribute): Default to 100%, not 0, when the
width or height property are either not set or not successfully parsed. Without
this change, one of the SVG tests starts failing.
- svg/SVGUseElement.cpp:
(WebCore::updateWidthAndHeight): Added. The tricky part here is that we have
to copy width and height attributes only if they were successfully parsed, and
also we need to copy the current animating values, not the original attribute
strings. Kind of messy, but I wanted to adapt Rob's solution for the time being,
rather than inventing something new.
(WebCore::SVGUseElement::svgAttributeChanged): Call updateWidthAndHeight.
This is used both when actual attribute changes occur and also when animation
changes the current value.
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Call updateWidthAndHeight.
This is used when the shadow elements are first created.
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Call updateWidthAndHeight.
This was in Rob's patch, but I am not sure we have sufficient test coverage.
LayoutTests:
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.png: Old test
result was expecting failure. New one expects success.
- platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt: Ditto.
- svg/animations/use-animate-width-and-height-expected.txt: Added.
- svg/animations/use-animate-width-and-height.html: Added.
- svg/custom/use-attribute-invalidations-expected.html: Added.
- svg/custom/use-attribute-invalidations.html: Added.
- svg/custom/use-dynamic-attribute-setting-expected.html: Added.
- svg/custom/use-dynamic-attribute-setting.html: Added.
- 11:14 AM Changeset in webkit [179068] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175976. rdar://problem/19420064
- 10:57 AM Changeset in webkit [179067] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r175585. rdar://problem/19419818
- 10:30 AM Changeset in webkit [179066] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged small change from r175549. rdar://problem/19433134
- 9:27 AM Changeset in webkit [179065] by
-
- 3 edits2 adds in branches/safari-600.1.4.15-branch
Merged r174860. rdar://problem/19419859
- 9:00 AM Changeset in webkit [179064] by
-
- 3 edits7 adds in branches/safari-600.1.4.15-branch
Merged r175085. rdar://problem/19419853
- 9:00 AM Changeset in webkit [179063] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174356. rdar://problem/19419853
- 9:00 AM Changeset in webkit [179062] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged branch-only patch (r0). rdar://problem/19564738
- 8:28 AM Changeset in webkit [179061] by
-
- 4 edits in trunk/Source
Provide implementation for WTF::DefaultHash<bool>
https://bugs.webkit.org/show_bug.cgi?id=140848
Reviewed by Anders Carlsson.
Source/WebCore:
Use HashMap<std::pair<UChar32, bool>> type in Font.cpp for
CharacterFallbackMap instead of HashMap<std::pair<UChar32, unsigned>>.
It builds now that WTF::DefaultHash<bool> is defined in WTF.
- platform/graphics/Font.cpp:
(WebCore::Font::removeFromSystemFallbackCache):
Source/WTF:
Provide implementation for WTF::DefaultHash<bool> so that we can use
HashMap<std::pair<XXX, bool>> in the code base. Right now, we need to
use some integer type to work around the issue.
- wtf/HashFunctions.h:
Jan 23, 2015:
- 11:05 PM Changeset in webkit [179060] by
-
- 1 edit1 add in trunk/LayoutTests
[Win] Unreviewed gardening. Add Windows baseline for
mouse-cursor-image-set.
- platform/win/fast/events/mouse-cursor-image-set-expected.txt: Added.
- 11:04 PM Changeset in webkit [179059] by
-
- 2 edits in trunk/Source/WebCore
[Win] Cursor assignment operator is skipping scale factor
https://bugs.webkit.org/show_bug.cgi?id=140852
Reviewed by Chris Dumez.
Found by fast/events/mouse-cursor-image-set.html
- platform/win/CursorWin.cpp:
(WebCore::Cursor::operator=): Make sure to also assign the
scale factor.
- 9:36 PM Changeset in webkit [179058] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Attempt to fix the build after AVValueTiming.h moved
- platform/spi/ios/AVKitSPI.h: The AVValueTiming.h header moved
to an unexpected location, so work around it by using local SPI
declarations.
- 9:33 PM Changeset in webkit [179057] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the build after r179056.
- platform/Cursor.h: (WebCore::Cursor::Cursor): Initialize dadat members in correct order.
- 9:26 PM Changeset in webkit [179056] by
-
- 3 edits in trunk/Source/WebCore
[Win] Cursor copy constructor does not initialize scale factor
https://bugs.webkit.org/show_bug.cgi?id=140849
Reviewed by Antti Koivisto.
Found by fast/events/mouse-cursor-image-set.html
Make sure the scale factor is captured during copy construction. Also make sure
it is properly initialized in the default constructor, since it it used in the
Windows port for some default cursors.
- platform/CursorWin.h:
- platform/win/CursorWin.cpp:
(WebCore::Cursor::Cursor): Make sure copy constructor captures
the scale factor.
- 8:15 PM Changeset in webkit [179055] by
-
- 10 edits42 adds in trunk
Add pointer/hover media queries
https://bugs.webkit.org/show_bug.cgi?id=134822
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-01-23
Reviewed by Antti Koivisto.
Source/WebCore:
Media Queries Level 4 introduces two types of Interaction Media Features:
"pointer" and "hover". Those media features are useful for adapting the design
to the type of input:
This implementation is trivial: just #ifdef the return value depending on
the support for touch events.
In the future we should move that to a client interface but let's start easy
for now.
Tests: fast/media/mq-any-hover-cssom.html
fast/media/mq-any-hover-invalid.html
fast/media/mq-any-hover-matchMedia.html
fast/media/mq-any-hover-styling.html
fast/media/mq-any-pointer-cssom.html
fast/media/mq-any-pointer-invalid.html
fast/media/mq-any-pointer-matchMedia.html
fast/media/mq-any-pointer-styling.html
fast/media/mq-hover-cssom.html
fast/media/mq-hover-invalid.html
fast/media/mq-hover-matchMedia.html
fast/media/mq-hover-styling.html
fast/media/mq-pointer-cssom.html
fast/media/mq-pointer-invalid.html
fast/media/mq-pointer-matchMedia.html
fast/media/mq-pointer-styling.html
- css/CSSValueKeywords.in:
- css/MediaFeatureNames.h:
- css/MediaQueryEvaluator.cpp:
(WebCore::hoverMediaFeatureEval):
(WebCore::any_hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
(WebCore::any_pointerMediaFeatureEval):
(WebCore::leastCapablePrimaryPointerDeviceType): Deleted.
- css/MediaQueryExp.cpp:
(WebCore::featureWithCSSValueID):
(WebCore::featureWithZeroOrOne):
(WebCore::featureWithoutValue):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
- page/Settings.in:
LayoutTests:
- fast/media/mq-any-hover-cssom-expected.txt: Added.
- fast/media/mq-any-hover-cssom.html: Added.
- fast/media/mq-any-hover-invalid-expected.txt: Added.
- fast/media/mq-any-hover-invalid.html: Added.
- fast/media/mq-any-hover-matchMedia-expected.txt: Added.
- fast/media/mq-any-hover-matchMedia.html: Added.
- fast/media/mq-any-hover-styling-expected.txt: Added.
- fast/media/mq-any-hover-styling.html: Added.
- fast/media/mq-any-pointer-cssom-expected.txt: Added.
- fast/media/mq-any-pointer-cssom.html: Added.
- fast/media/mq-any-pointer-invalid-expected.txt: Added.
- fast/media/mq-any-pointer-invalid.html: Added.
- fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
- fast/media/mq-any-pointer-matchMedia.html: Added.
- fast/media/mq-any-pointer-styling-expected.txt: Added.
- fast/media/mq-any-pointer-styling.html: Added.
- fast/media/mq-hover-cssom-expected.txt: Added.
- fast/media/mq-hover-cssom.html: Added.
- fast/media/mq-hover-invalid-expected.txt: Added.
- fast/media/mq-hover-invalid.html: Added.
- fast/media/mq-hover-matchMedia-expected.txt: Added.
- fast/media/mq-hover-matchMedia.html: Added.
- fast/media/mq-hover-styling-expected.txt: Added.
- fast/media/mq-hover-styling.html: Added.
- fast/media/mq-pointer-cssom-expected.txt: Added.
- fast/media/mq-pointer-cssom.html: Added.
- fast/media/mq-pointer-expected.txt:
- fast/media/mq-pointer-invalid-expected.txt: Added.
- fast/media/mq-pointer-invalid.html: Added.
- fast/media/mq-pointer-matchMedia-expected.txt: Added.
- fast/media/mq-pointer-matchMedia.html: Added.
- fast/media/mq-pointer-styling-expected.txt: Added.
- fast/media/mq-pointer-styling.html: Added.
- fast/media/mq-pointer.html:
- platform/ios-simulator/fast/media/mq-any-hover-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-any-hover-styling-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-any-pointer-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-any-pointer-styling-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-hover-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-hover-styling-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-pointer-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-pointer-matchMedia-expected.txt: Added.
- platform/ios-simulator/fast/media/mq-pointer-styling-expected.txt: Added.
- 7:05 PM Changeset in webkit [179054] by
-
- 20 edits6 deletes in trunk
Unreviewed, rolling out r179051.
https://bugs.webkit.org/show_bug.cgi?id=140850
broke the 32-bit build (Requested by thorton on #webkit).
Reverted changeset:
"[Mac][EME] Support ClearKey encryption with AES128-encrypted
HLS"
https://bugs.webkit.org/show_bug.cgi?id=140825
http://trac.webkit.org/changeset/179051
- 6:34 PM Changeset in webkit [179053] by
-
- 9 edits in trunk/Source
Web Inspector: Rename InjectedScriptHost::type to subtype
https://bugs.webkit.org/show_bug.cgi?id=140841
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-23
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
We were using this to set the subtype of an "object" type RemoteObject
so we should clean up the name and call it subtype.
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptSource.js:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::type): Deleted.
- inspector/JSInjectedScriptHost.h:
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionSubtype):
(Inspector::jsInjectedScriptHostPrototypeFunctionType): Deleted.
Source/WebCore:
- inspector/WebInjectedScriptHost.cpp:
(WebCore::WebInjectedScriptHost::subtype):
(WebCore::WebInjectedScriptHost::type): Deleted.
- inspector/WebInjectedScriptHost.h:
- 6:27 PM Changeset in webkit [179052] by
-
- 3 edits in trunk/Source/WebKit2
Implement cache size limit
https://bugs.webkit.org/show_bug.cgi?id=140844
Reviewed by Andreas Kling.
Prevent the cache from growing without bounds. The simple scheme implemented here
estimates the cache size from number of entries. When the estimated size exceeds
the maximum size we randomly clear 1/4 of the entries.
- NetworkProcess/cache/NetworkCacheStorage.h:
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initialize):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::setMaximumSize):
(WebKit::NetworkCacheStorage::clear):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
(WebKit::NetworkCacheStorage::initializeKeyFilter): Deleted.
- 6:20 PM Changeset in webkit [179051] by
-
- 20 edits3 copies10 adds in trunk
[Mac][EME] Support ClearKey encryption with AES128-encrypted HLS
https://bugs.webkit.org/show_bug.cgi?id=140825
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/clearkey/clear-key-hls-aes128.html
Add support for ClearKey encryption when used with an AES-128 encrypted HLS stream.
- Modules/encryptedmedia/CDM.cpp:
(WebCore::installedCDMFactories): Add the CDMPrivateClearKey factory.
- Modules/encryptedmedia/CDMPrivateClearKey.cpp:
(WebCore::CDMPrivateClearKey::supportsKeySystem): Support the "org.w3c.clearkey" key system.
(WebCore::CDMPrivateClearKey::supportsKeySystemAndMimeType): Ditto.
(WebCore::CDMPrivateClearKey::supportsMIMEType): Ditto.
(WebCore::CDMPrivateClearKey::createSession): Create a CDMSessionClearKey.
- Modules/encryptedmedia/CDMPrivateClearKey.h:
(WebCore::CDMPrivateClearKey::create): Simple factory.
(WebCore::CDMPrivateClearKey::~CDMPrivateClearKey): Virtual destructor.
(WebCore::CDMPrivateClearKey::CDMPrivateClearKey): Simple destructor.
- Modules/encryptedmedia/CDMSessionClearKey.cpp: Added.
(WebCore::clearKeyVM): Static method returning the VM to be used by JSON parsing.
(WebCore::CDMSessionClearKey::CDMSessionClearKey): Simple constructor.
(WebCore::CDMSessionClearKey::~CDMSessionClearKey): Simple destructor.
(WebCore::CDMSessionClearKey::generateKeyRequest): Store the initData, ensure that it consists of a UTF8-encoded key
URI, and return same.
(WebCore::CDMSessionClearKey::releaseKeys): Purged all cached keys.
(WebCore::CDMSessionClearKey::update): Parse raw JSON-encoded JWK keys, rejecting non-AES, non-oct keys.
(WebCore::CDMSessionClearKey::cachedKeyForKeyID): Return cached keys.
- Modules/encryptedmedia/CDMSessionClearKey.h:
Add support for the "org.w3c.clearkey" CDM to MediaPlayerPrivateAVFoundationObjC, and do so in a platform-agnostic
way by simply asking for raw key data from MediaPlayerClient when notified that a key has been added.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::keySystemIsSupported):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsKeySystem):
(WebCore::fulfillRequestWithKeyData): Added utility method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::keyAdded):
Pipe a keyAdded() notification down to MediaPlayer and a cachedKeyForKeyId() request up to CDMSessionClearKey:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::cachedKeyForKeyId):
(WebCore::MediaKeySession::addKeyTimerFired):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::keyAdded):
(WebCore::MediaKeys::cachedKeyForKeyId):
- Modules/encryptedmedia/MediaKeys.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::keyAdded):
- html/HTMLMediaElement.h:
- platform/graphics/CDMSession.h:
(WebCore::CDMSession::cachedKeyForKeyID):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::keyAdded):
(WebCore::MediaPlayer::cachedKeyForKeyId):
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCachedKeyForKeyId):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::keyAdded):
Add new files to project:
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
LayoutTests:
- http/tests/media/clearkey/clear-key-hls-aes128-expected.txt: Added.
- http/tests/media/clearkey/clear-key-hls-aes128.html: Added.
- http/tests/media/clearkey/support.js: Added.
(stringToUInt8Array):
(uInt8ArrayToString):
(base64EncodeUint8Array):
- http/tests/media/resources/hls/clearkey/crypt0.key: Added.
- http/tests/media/resources/hls/clearkey/iframe_index.m3u8: Added.
- http/tests/media/resources/hls/clearkey/main0.ts: Added.
- http/tests/media/resources/hls/clearkey/prog_index.m3u8: Added.
- media/video-test.js:
(waitForEventOnceOn):
- 5:41 PM Changeset in webkit [179050] by
-
- 15 edits in trunk/Source/WebCore
Implement system fonts FontDescription caching at RenderTheme level
https://bugs.webkit.org/show_bug.cgi?id=140840
Reviewed by Andreas Kling.
Implement system fonts FontDescription caching at RenderTheme level
instead of duplicating the logic in its subclasses for each platform.
This reduces code / logic duplication and reduces the amount of
platform-specific code. This will also make the refactoring at
Bug 140577 a lot easier.
The caching logic remains in RenderThemeIOS class for iOS because:
- It supports different system font values than all other platforms
- It requires cache invalidation in some cases while other platforms do not.
This patch is inspired by the following Blink revision:
https://src.chromium.org/viewvc/blink?view=rev&revision=184449
Test: fast/css/css2-system-fonts.html
- 5:38 PM Changeset in webkit [179049] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening: Correct some typos in Failure entries.
- platform/win/TestExpectations:
- 5:13 PM Changeset in webkit [179048] by
-
- 2 edits in trunk/Source/WebCore
Simple line layout: Refactor line wrapping logic.
https://bugs.webkit.org/show_bug.cgi?id=140834
Reviewed by Antti Koivisto.
Use a more readable structure to deal with wrapping logic.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::createLineRuns):
- 5:12 PM Changeset in webkit [179047] by
-
- 3 edits in trunk/Source/WebCore
Simple line layout: Use only FlowContents::nextTextFragment() to read fragments from the text flow.
https://bugs.webkit.org/show_bug.cgi?id=140842
Reviewed by Antti Koivisto.
This is in preparation to make FlowContents a content iterator class.
No change in functionality.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::initializeNewLine):
- rendering/SimpleLineLayoutFlowContents.h:
- 5:05 PM Changeset in webkit [179046] by
-
- 2 edits in trunk/Tools
test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
<http://webkit.org/b/140787>
Reviewed by Daniel Bates.
- Scripts/webkitpy/port/ios.py:
(IOSPort.determine_full_port_name): Instead of checking the type
of the current host, test if /usr/bin/xcrun exists before trying
to use it.
- 5:03 PM Changeset in webkit [179045] by
-
- 4 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Build fix after r179028, r179030, r179031, r179032.
Reviewed by Dana Burkart.
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::WidthIterator):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
- 4:52 PM Changeset in webkit [179044] by
-
- 5 edits2 adds in trunk
[MSE] Implement Range Removal algorithm.
https://bugs.webkit.org/show_bug.cgi?id=140622.
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2015-01-23
Reviewed by Jer Noble.
Source/WebCore:
This extract Range Removal algorithm (Editor's Draft version, bug:26316) from remove(),
to separate function to deal with old FIXME since bug in spec was resolved.
This should both guarantee good order of events, and prevent from switching to 'open' state
during end of stream.
Test: media/media-source/media-source-end-of-stream-readyState.html
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDurationInternal): update to use rangeRemoval(), not remove()
(WebCore::MediaSource::streamEndedWithError): remove FIXME, brigning back correct order of events.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::remove): comments up to spec, extract rangeRemoval algorithm.
(WebCore::SourceBuffer::rangeRemoval):
(WebCore::SourceBuffer::removeTimerFired): comments up to spec.
- Modules/mediasource/SourceBuffer.h:
LayoutTests:
Added short test to check whether endOfStream incorrectly switches back
to 'open' state.
- media/media-source/media-source-end-of-stream-readyState.html: Added.
- media/media-source/media-source-end-of-stream-readyState-expected.txt: Added.
- 4:49 PM Changeset in webkit [179043] by
-
- 2 edits in trunk/Tools
Fix the false positive build failures on the Windows buildbots
https://bugs.webkit.org/show_bug.cgi?id=140819
Reviewed by Brent Fulgham.
Increase the build timeout (without producing output) to 2 hours for Windows bots,
the default 20 minutes is enough for others since they produce output during the build.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildFactory.init):
- 4:48 PM Changeset in webkit [179042] by
-
- 20 edits5 deletes in tags/Safari-600.5.3
Rollout r178466
- 4:45 PM Changeset in webkit [179041] by
-
- 12 edits8 deletes in tags/Safari-600.5.3
Rollout r178467
- 4:43 PM Changeset in webkit [179040] by
-
- 20 edits5 deletes in branches/safari-600.5-branch
Rollout r178466
- 4:38 PM Changeset in webkit [179039] by
-
- 4 edits2 adds in trunk/LayoutTests
[Win] Test gardening. Mark a few failures after filing bugs.
Also rebaseline a few tests.
- platform/win/TestExpectations:
- platform/win/accessibility/parent-element-expected.txt:
- platform/win/editing/input/caret-at-the-edge-of-input-expected.png: Added.
- platform/win/editing/input/caret-at-the-edge-of-input-expected.txt: Added.
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 4:32 PM Changeset in webkit [179038] by
-
- 12 edits8 deletes in branches/safari-600.5-branch
Rollout r178467
- 4:24 PM Changeset in webkit [179037] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard always assigns the result of A/B testing with build request 1
https://bugs.webkit.org/show_bug.cgi?id=140382
Reviewed by Darin Adler.
The bug was caused by the expression array_get($report, 'jobId') or array_get($report, 'buildRequest')
which always evaluated to 1 when the report contained jobId. Fixed the bug by cascading array_get instead.
Also fixed a typo as well as a bug that reports were never associated with builds.
- public/include/report-processor.php:
(ReportProcessor::process): Don't use "or" to find the non-null value since that always evaluates to 1
instead of the first non-null value.
(ReportProcessor::resolve_build_id): Fixed the typo by adding the missing "$this->".
(ReportProcessor::commit): Associate the report with the corresponding build as intended.
- 4:21 PM Changeset in webkit [179036] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed typo fix. The prefix in triggerable_configurations is "trigconfig", not "trigrepo".
- public/admin/tests.php:
- 3:48 PM Changeset in webkit [179035] by
-
- 2 edits in trunk/Source/JavaScriptCore
LayoutTests/js/script-tests/reentrant-caching.js crashing on 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=140843
Reviewed by Oliver Hunt.
When we are in vmEntryToJavaScript, we keep the stack pointer at an
alignment sutiable for pointing to a call frame header, which is the
alignment post making a call. We adjust the sp when calling to JS code,
but don't adjust it before calling the out of stack handler.
- llint/LowLevelInterpreter32_64.asm:
Moved stack point down 8 bytes to get it aligned.
- 3:37 PM Changeset in webkit [179034] by
-
- 5 edits9 copies in branches/safari-600.5-branch
Merged r176354. <rdar://19451336>
- 3:34 PM Changeset in webkit [179033] by
-
- 4 edits in trunk
Source/WebKit/win:
[Win] Teach WebKit to provide IAccessible2 'get_language'
https://bugs.webkit.org/show_bug.cgi?id=140839
Reviewed by Dean Jackson.
- AccessibleBase.cpp:
(AccessibleBase::get_locale): Wrap the Webore::AccessibleObject::language
result in an IA2Locale structure to statisfy the IAccessible2 specification.
Tools:
[Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage
https://bugs.webkit.org/show_bug.cgi?id=140839
Reviewed by Dean Jackson.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::language): Retrieve the 'language' BSTR
from the IA2Locale structure and pass it to DRT.
- 3:09 PM Changeset in webkit [179032] by
-
- 11 edits4 copies in branches/safari-600.1.4.15-branch
Merged r174489. rdar://problem/19434944
- 3:06 PM Changeset in webkit [179031] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174373. rdar://problem/19434944
- 3:05 PM Changeset in webkit [179030] by
-
- 8 edits in branches/safari-600.1.4.15-branch/Source/WebCore
Merged r174297. rdar://problem/19434944
- 3:04 PM Changeset in webkit [179029] by
-
- 9 edits4 copies in branches/safari-600.5-branch
Merged r174489. <rdar://problem/19452129>
- 3:03 PM Changeset in webkit [179028] by
-
- 42 edits1 copy in branches/safari-600.1.4.15-branch
Merged r174233. rdar://problem/19434944
- 2:16 PM Changeset in webkit [179027] by
-
- 3 edits4 adds in trunk
Hit test returns incorrect results when performed in paginated content over the page gaps.
https://bugs.webkit.org/show_bug.cgi?id=140837
rdar://problem/17494390
Reviewed by Dave Hyatt.
Source/WebCore:
Tests: fast/multicol/pagination/LeftToRight-tb-hittest.html
fast/multicol/pagination/RightToLeft-rl-hittest.html
When hittesting reaches the RenderView we need to check if we are
in paginated content and use the correct class to compute hittest results.
- rendering/RenderView.cpp:
(WebCore::RenderView::updateHitTestResult):
LayoutTests:
- fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt: Added.
- fast/multicol/pagination/LeftToRight-tb-hittest.html: Added.
- fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt: Added.
- fast/multicol/pagination/RightToLeft-rl-hittest.html: Added.
- 1:57 PM Changeset in webkit [179026] by
-
- 40 edits5 adds12 deletes in trunk/LayoutTests
[Win] Unreviewed gardening after landing r179024.
Update Windows-specific accessibility tests and test expectations after making Windows AX output match Mac.
This allows us to share more Mac results.
- platform/win/TestExpectations:
- platform/win/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt:
- platform/win/accessibility/aria-checkbox-text-expected.txt: Removed.
- platform/win/accessibility/aria-combobox-expected.txt:
- platform/win/accessibility/aria-fallback-roles-expected.txt: Removed.
- platform/win/accessibility/aria-hidden-expected.txt: Removed.
- platform/win/accessibility/aria-labelledby-on-input-expected.txt: Removed.
- platform/win/accessibility/aria-labelledby-overrides-aria-label-expected.txt:
- platform/win/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
- platform/win/accessibility/aria-list-and-listitem-expected.txt:
- platform/win/accessibility/aria-mappings-expected.txt: Added.
- platform/win/accessibility/aria-menubar-menuitems-expected.txt:
- platform/win/accessibility/aria-option-role-expected.txt:
- platform/win/accessibility/aria-presentational-role-expected.txt: Removed.
- platform/win/accessibility/aria-roles-expected.txt:
- platform/win/accessibility/aria-tab-role-on-buttons-expected.txt:
- platform/win/accessibility/aria-tab-roles-expected.txt:
- platform/win/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
- platform/win/accessibility/canvas-description-and-role-expected.txt:
- platform/win/accessibility/canvas-fallback-content-expected.txt:
- platform/win/accessibility/css-content-attribute-expected.txt: Added.
- platform/win/accessibility/deleting-iframe-destroys-axcache-expected.txt:
- platform/win/accessibility/div-within-anchors-causes-crash-expected.txt:
- platform/win/accessibility/document-enabled-state-expected.txt:
- platform/win/accessibility/document-enabled-state.html:
- platform/win/accessibility/document-role-expected.txt:
- platform/win/accessibility/heading-elements-expected.txt:
- platform/win/accessibility/heading-elements.html:
- platform/win/accessibility/image-map1-expected.txt: Added.
- platform/win/accessibility/image-with-alt-and-map-expected.txt: Added.
- platform/win/accessibility/img-alt-attribute-expected.txt:
- platform/win/accessibility/img-alt-attribute.html:
- platform/win/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
- platform/win/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
- platform/win/accessibility/img-fallsback-to-title-expected.txt: Removed.
- platform/win/accessibility/input-image-alt-expected.txt: Removed.
- platform/win/accessibility/linked-elements-expected.txt:
- platform/win/accessibility/linked-elements.html:
- platform/win/accessibility/list-item-role-expected.txt:
- platform/win/accessibility/list-item-role.html:
- platform/win/accessibility/list-marker-role-expected.txt:
- platform/win/accessibility/list-marker-role.html:
- platform/win/accessibility/list-role-expected.txt:
- platform/win/accessibility/list-role.html:
- platform/win/accessibility/multiple-select-element-role-expected.txt:
- platform/win/accessibility/multiple-select-element-role.html:
- platform/win/accessibility/parent-element-expected.txt:
- platform/win/accessibility/parent-element.html:
- platform/win/accessibility/select-element-role-expected.txt:
- platform/win/accessibility/select-element-role.html:
- platform/win/accessibility/selection-and-focus-expected.txt:
- platform/win/accessibility/selection-and-focus.html:
- platform/win/accessibility/single-select-children.html:
- platform/win/accessibility/svg-image-expected.txt: Removed.
- platform/win/accessibility/text-role-expected.txt:
- platform/win/aria-labelledby-overrides-aria-label-actual.txt: Added.
- 1:39 PM Changeset in webkit [179025] by
-
- 4 edits in trunk/Source/WebCore
Document should be a FontSelectorClient.
<https://webkit.org/b/140833>
Reviewed by Antti Koivisto.
Make Document a FontSelectorClient so it can listen to the invalidation
callbacks from FontSelector instead of having code in FontSelector that
calls out to Document on invalidation.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
- dom/Document.cpp:
(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::fontSelector):
(WebCore::Document::clearStyleResolver):
- dom/Document.h:
- 1:31 PM Changeset in webkit [179024] by
-
- 2 edits in trunk/Tools
[Win] Update DRT Accessibility implementation to better match Mac.
https://bugs.webkit.org/show_bug.cgi?id=140830
Reviewed by Dean Jackson.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(convertToDRTLabel):
(AccessibilityUIElement::role):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::isFocused):
- 12:53 PM Changeset in webkit [179023] by
-
- 2 edits in trunk/Source/WebKit2
Fix the pre-Yosemite build.
- UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
- 12:12 PM Changeset in webkit [179022] by
-
- 1 copy in tags/Safari-600.1.4.15.2
New tag.
- 12:10 PM Changeset in webkit [179021] by
-
- 1 copy in tags/Safari-600.5.3
New tag.
- 12:05 PM Changeset in webkit [179020] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source
Versioning.
- 12:05 PM Changeset in webkit [179019] by
-
- 15 edits2 adds in trunk
Web Inspector: Object Previews in the Console
https://bugs.webkit.org/show_bug.cgi?id=129204
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Update the very old, unused object preview code. Part of this comes from
the earlier WebKit legacy implementation, and the Blink implementation.
A RemoteObject may include a preview, if it is asked for, and if the
RemoteObject is an object. Previews are a shallow (single level) list
of a limited number of properties on the object. The previewed
properties are always stringified (even if primatives). Previews are
limited to just 5 properties or 100 indices. Previews are marked
as lossless if they are a complete snapshot of the object.
There is a path to make previews two levels deep, that is currently
unused but should soon be used for tables (e.g. IndexedDB).
- inspector/InjectedScriptSource.js:
- Move some code off of InjectedScript to be generic functions
usable by RemoteObject as well.
- Update preview generation to use
- inspector/protocol/Runtime.json:
- Add a new type, "accessor" for preview objects. This represents
a getter / setter. We currently don't get the value.
Source/WebInspectorUI:
- UserInterface/Controllers/JavaScriptLogViewController.js:
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
- UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.):
Update RuntimeManager callsites that do not need object previews.
- UserInterface/Controllers/RuntimeManager.js:
(WebInspector.RuntimeManager.prototype.evalCallback):
(WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow):
Update the main evaluate method to include a boolean parameter for
object previews. Most callers do not need them. Also, since previews
were not available on iOS 6, switch to invoke, to conditionally
include the command parameter.
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.prototype.get preview):
Store the preview from the payload.
- UserInterface/Views/ConsoleMessageImpl.js:
(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsString):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
Pass an explicit false for most formatters to not use a preview if available.
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
Currently only object types are previewed. Though we request previews
for arrays, we don't use the preview because we show a better preview
by just immediately requesting for a full non-preview property list.
(WebInspector.ConsoleMessageImpl.prototype._appendObjectPreview):
Quickly output an object preview into the title element. The format
is "ClassName {prop: value...}". Elide the class name if it is "Object".
Also skip over certain preview properties that may not be useful
at a glance (like constructor, or accessors without values).
- UserInterface/Views/LogContentView.css:
(.console-object-preview):
(.console-formatted-array .console-object-preview):
(.console-object-preview-lossless):
(.expanded .console-object-preview):
Show lossy previews in italics.
Show lossless previews and array previews without italics.
Do not show the class name in the preview in italics when expanded.
(.console-object-preview .name):
Give preview property names the same color as ObjectPropertiesSection property names.
(.expanded .console-object-preview > .console-object-preview-body):
When expanding an object, hide the preview.
(.console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
(.expanded .console-object-preview > .console-object-preview-name.console-object-preview-name-Object):
For "Object" previews, hide the name "Object" when not expanded, and show it when expanded.
LayoutTests:
- inspector/debugger/command-line-api-exception-nested-catch.html:
- inspector/debugger/command-line-api-exception.html:
- inspector/model/remote-object-get-properties.html:
Update RuntimeManager callsites to not ask for previews when evaluating.
- inspector/model/remote-object-expected.txt: Added.
- inspector/model/remote-object.html: Added.
Add a test specifically for Remote Object. This test can also be
opened in a browser. It attempts to run the gamut of all different
types of objects and shows the RemoteObject constructed for it.
- 12:03 PM Changeset in webkit [179018] by
-
- 5 edits in branches/safari-600.5-branch/Source
Versioning.
- 12:01 PM Changeset in webkit [179017] by
-
- 2 edits in trunk/Source/WebCore
Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=140829
Reviewed by Andreas Kling.
Leverage CSSValuePool's font family cache in CSSComputedStyleDeclaration
by calling CSSValuePool::createFontFamilyValue() to create the font
family CSSPrimitiveValue instead of cssValuePool().createValue().
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily):
- 11:57 AM Changeset in webkit [179016] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Disable *Annotators on minified files that aren't pretty printed
https://bugs.webkit.org/show_bug.cgi?id=140550
Reviewed by Timothy Hatcher.
When SourceCodeTextEditor speculates that a file is minified it
sets a flag on itself that the Annotators will notice when pretty
printing and turning on type profiling.
SourceCodeTextEditor enforces the following two behaviors:
- Always pretty print a file if we think it's minified while
viewing type annotations. So, while viewing a minified file,
if you press the type profiling button, the pretty printer will
first reformat the file, then the type profiler will insert type annotations.
- If the type profiler is enabled and we're viewing a pretty
printed file that we think originally was minified, and the
pretty printer is disabled via pressing the button, then the
type profiler will also be disabled.
These two behaviors maintain a good user experience because
it prevents a bad visual representation of profiler data and
also prevents bad performance.
- UserInterface/Controllers/TypeTokenAnnotator.js:
(WebInspector.TypeTokenAnnotator.prototype.toggleTypeAnnotations): Deleted.
- UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.shown):
(WebInspector.SourceCodeTextEditor.prototype.contentDidChange):
(WebInspector.SourceCodeTextEditor.prototype.toggleTypeAnnotations):
(WebInspector.SourceCodeTextEditor.prototype.prettyPrint):
(WebInspector.SourceCodeTextEditor.prototype._contentWillPopulate):
(WebInspector.SourceCodeTextEditor.prototype._populateWithContent):
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
- 11:52 AM Changeset in webkit [179015] by
-
- 4 edits in trunk/Source/JavaScriptCore
Immediate crash when setting JS breakpoint
https://bugs.webkit.org/show_bug.cgi?id=140811
Reviewed by Mark Lam.
When the DFG stack layout phase doesn't allocate a register for the scope register,
it incorrectly sets the scope register in the code block to a bad value, one with
an offset of 0. Changed it so that we set the code block's scope register to the
invalid VirtualRegister instead.
No tests needed as adding the ASSERT in setScopeRegister() was used to find the bug.
We crash with that ASSERT in testapi and likely many other tests as well.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setScopeRegister):
(JSC::CodeBlock::scopeRegister):
Added ASSERTs to catch any future improper setting of the code block's scope register.
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- 11:43 AM Changeset in webkit [179014] by
-
- 10 edits in trunk/Source
QLPreviewMenuItem popovers don't close when the page scrolls
https://bugs.webkit.org/show_bug.cgi?id=140806
<rdar://problem/19555618>
Reviewed by Beth Dakin.
Now that QLPreviewMenuItem's popover doesn't eat scrolls, we need to dismiss it if the page scrolls.
- WebView/WebHTMLView.mm:
(-[WebHTMLView scrollWheel:scrollWheel:]):
Send scrollWheel along to WebImmediateActionController.
- WebView/WebImmediateActionController.h:
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController webView:didHandleScrollWheel:]):
(-[WebImmediateActionController _clearImmediateActionState]):
(-[WebImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.
- UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
Send _dismissContentRelativeChildWindows on to WKImmediateActionController.
- UIProcess/mac/WKImmediateActionController.h:
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController dismissContentRelativeChildWindows]):
(-[WKImmediateActionController _defaultAnimationController]):
Keep track of the active QLPreviewMenuItem, and close it upon scroll.
- platform/spi/mac/QuickLookMacSPI.h:
Add some SPI.
- 11:42 AM Changeset in webkit [179013] by
-
- 4 edits in trunk/Source
Infinite recursion in _clearImmediateActionState
https://bugs.webkit.org/show_bug.cgi?id=140807
<rdar://problem/19571601>
Reviewed by Anders Carlsson.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
Clear _hasActivatedActionContext before calling didUseActions, because
didUseActions can call _clearImmediateActionState.
- WebView/WebImmediateActionController.mm:
(-[WebImmediateActionController _clearImmediateActionState]):
Use this opportunity to bring identical code to WebKit1, to avoid
getting DataDetectors stuck when an immediate action is canceled.
- 10:44 AM Changeset in webkit [179012] by
-
- 18 edits in trunk/Source/WebCore
Hang CSSFontSelector off Document instead of StyleResolver.
<https://webkit.org/b/140820>
Reviewed by Antti Koivisto.
Move the CSSFontSelector from StyleResolver to Document. This is the first
step towards making the CSSFontSelector be able to survive full style recalc.
Clearing a Document's StyleResolver will still nuke the CSSFontSelector,
though that is done in Document::clearStyleResolver() now.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
- css/CSSFontSelector.h:
Modernize CSSFontSelector construction a bit by having create() return
a Ref and the constructor take a Document& instead of a Document*.
Also made the constructor explicit.
(WebCore::StyleResolver::~StyleResolver):
- dom/Document.cpp:
(WebCore::Document::clearStyleResolver):
Nuke the current CSSFontSelector in clearStyleResolver() instead of
in ~StyleResolver. It's a minor change, but shows the way forward.
Added a FIXME about how CSSFontSelector should eventually survive
this operation.
(WebCore::Document::fontSelector):
- css/FontLoader.cpp:
(WebCore::FontLoader::loadFont):
(WebCore::FontLoader::checkFont):
(WebCore::FontLoader::resolveFontStyle):
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
- css/StyleResolver.h:
(WebCore::StyleResolver::fontSelector): Deleted.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::updateFont):
- dom/Document.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMenuList.cpp:
(RenderMenuList::fontSelector):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::fontSelector):
- rendering/TextAutoSizing.cpp:
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveTree):
Move CSSFontSelector ownership from StyleResolver to Document.
- 10:28 AM Changeset in webkit [179011] by
-
- 2 edits in trunk/LayoutTests
Create a "load and stall" cgi that support byte ranges.
https://bugs.webkit.org/show_bug.cgi?id=140628
Reviewed by Jer Noble.
- http/tests/media/resources/serve-video.php: Add support for "stallOffset", "stallDuration",
and "chunkSize" parameters.
- 10:27 AM Changeset in webkit [179010] by
-
- 2 edits in trunk/Source/WebCore
Layout Test http/tests/media/track-in-band-hls-metadata.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140827
Reviewed by Eric Carlson.
Create the m_metadataTrack by calling prepareMetadataTrack() before deref-ing it.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
- 8:33 AM Changeset in webkit [179009] by
-
- 2 edits in trunk/Source/WTF
[GTK] Add missing null check in some derefGPtr implementations
https://bugs.webkit.org/show_bug.cgi?id=140822
Reviewed by Sergio Villar Senin.
It's missing in GHashTable and GVariant implementations.
- wtf/gobject/GRefPtr.cpp:
(WTF::derefGPtr):
- 6:56 AM Changeset in webkit [179008] by
-
- 3 edits in trunk/Tools
REGRESSION: run-perf-tests --profiler= seems to have broken
https://bugs.webkit.org/show_bug.cgi?id=113528
Reviewed by Daniel Bates.
The problem is that "perf --record" (or the equivalent call for
other profilers) is never called whenever there is a wrapper
option in the port. We should inject the profiler call first
(should it exists) and then use the port wrapper.
- Scripts/webkitpy/port/driver.py:
(Driver._command_wrapper):
- Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.test_profiler_and_wrapper): New unit test.
- 6:30 AM Changeset in webkit [179007] by
-
- 19 edits12 adds in trunk
[GTK] Add initial database process support
https://bugs.webkit.org/show_bug.cgi?id=139491
Reviewed by Sergio Villar Senin.
.:
- Source/cmake/OptionsGTK.cmake: Set WebKit2_DatabaseProcess_OUTPUT_NAME.
Source/WebCore:
- platform/sql/SQLiteFileSystem.cpp:
(WebCore::SQLiteFileSystem::openDatabase): Use
WebCore::fileSystemRepresentation() for the database filename,
otherwise sqlite3_open() fails when the filename contains "%2E".
Source/WebKit2:
Add initial support for DatabaseProcess, disabled by default for
now.
- CMakeLists.txt: Add required files to compilation.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.
- DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp: Added.
(main):
- DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp: Added.
(WebKit::DatabaseProcessMainUnix):
- DatabaseProcess/unix/DatabaseProcessMainUnix.h: Added.
- PlatformGTK.cmake: Add required files to compilation.
- Shared/ProcessExecutablePath.h:
- Shared/gtk/KeyedDecoder.cpp: Added.
(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::buildDictionaryFromGVariant):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):
- Shared/gtk/KeyedDecoder.h: Added.
- Shared/gtk/KeyedEncoder.cpp: Added.
(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::encodeDouble):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):
(WebKit::KeyedEncoder::finishEncoding):
- Shared/gtk/KeyedEncoder.h: Added.
- Shared/gtk/ProcessExecutablePathGtk.cpp:
(WebKit::executablePathOfDatabaseProcess):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::didCreateDatabaseToWebProcessConnection):
Add the unix domain sockets implementation.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Handle the
DatabaseProcess too.
- UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::platformDefaultIndexedDBDatabaseDirectory):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Add
the unix domain sockets implementation.
Source/WTF:
Add support for using GRefPtr with GVariantBuilder.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
- wtf/gobject/GRefPtr.h:
- wtf/gobject/GTypedefs.h:
- 2:33 AM Changeset in webkit [179006] by
-
- 2 edits in trunk/Source/WebCore
Initialization for some member variable of FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=136327
Patch by Byeongha Cho <byeongha.cho@samsung.com> on 2015-01-23
Reviewed by Myles C. Maxfield.
No new tests. There's no functional change.
- platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::operator=):
(WebCore::FontPlatformData::~FontPlatformData):
- 2:05 AM Changeset in webkit [179005] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175608. rdar://problem/19395075
- 2:05 AM Changeset in webkit [179004] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175607. rdar://problem/19395075
- 2:05 AM Changeset in webkit [179003] by
-
- 5 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175595. rdar://problem/19395075
- 2:04 AM Changeset in webkit [179002] by
-
- 6 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r175577. rdar://problem/19395075
- 2:04 AM Changeset in webkit [179001] by
-
- 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174885. rdar://problem/19395075
- 2:04 AM Changeset in webkit [179000] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174286. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178999] by
-
- 4 edits3 adds in branches/safari-600.1.4.15-branch/Source
Merged r174250. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178998] by
-
- 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174232. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178997] by
-
- 8 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r174072. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178996] by
-
- 9 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r172966. rdar://problem/19395075
- 2:04 AM Changeset in webkit [178995] by
-
- 3 edits in branches/safari-600.1.4.15-branch/Source/WebKit2
Merged r173762. rdar://problem/19420088
- 2:04 AM Changeset in webkit [178994] by
-
- 10 edits in branches/safari-600.1.4.15-branch/Source
Merged r173741. rdar://problem/19420088
- 1:18 AM Changeset in webkit [178993] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merged r178680. rdar://problem/19489593
- 1:17 AM Changeset in webkit [178992] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merged r178676. rdar://problem/19489593
- 1:16 AM Changeset in webkit [178991] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit/mac
Merged r178605. rdar://problem/19490114
- 1:14 AM Changeset in webkit [178990] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit2
Merged r178595. rdar://problem/19490114
- 12:52 AM Changeset in webkit [178989] by
-
- 2 edits in trunk/LayoutTests
svg-resource-fragment-identifier-img-src.html is a hidpi reftest, but its -expected.html
counterpart isn't hidpi
https://bugs.webkit.org/show_bug.cgi?id=140815
Reviewed by Simon Fraser.
- svg/css/svg-resource-fragment-identifier-img-src-expected.html: Make the expectation
match its test.
- 12:49 AM Changeset in webkit [178988] by
-
- 2 edits in trunk/Source/WebCore
Rename ChildNodeRemovalNotifier::m_insertionPoint to m_removalPoint
https://bugs.webkit.org/show_bug.cgi?id=140766
Reviewed by Andreas Kling.
ChildNodeRemovalNotifier::ChildNodeRemovalNotifier(...) should take
a node as removal point.
It's probably Copy/Paste from ChildNodeInsertionNotifier::m_insertionPoint.
No new tests. No behavior change.
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeRemovalNotifier::ChildNodeRemovalNotifier):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromDocument):
(WebCore::ChildNodeRemovalNotifier::notifyNodeRemovedFromTree):
- 12:25 AM Changeset in webkit [178987] by
-
- 5 edits7 deletes in trunk/LayoutTests
Rewrite the fast/css/css2-system-fonts.html test to be more useful on all platforms
https://bugs.webkit.org/show_bug.cgi?id=140810
Reviewed by Andreas Kling.
Make the fast/css/css2-system-fonts.html explicit about the font styles
expected on each platform instead of just Mac.
It also converts the test to be text only as the style information is
now displayed in text format.
This change is in preparation for a refactor of system font handling.
This change is based on the following Blink revision by
<alancutter@chromium.org>:
http://src.chromium.org/viewvc/blink?view=revision&revision=169612
- fast/css/css2-system-fonts.html:
- platform/efl/fast/css/css2-system-fonts-expected.png: Removed.
- platform/efl/fast/css/css2-system-fonts-expected.txt: Removed.
- platform/gtk/fast/css/css2-system-fonts-expected.png: Removed.
- platform/gtk/fast/css/css2-system-fonts-expected.txt: Removed.
- platform/ios-simulator-wk2/fast/css/css2-system-fonts-expected.txt:
- platform/mac-mavericks/fast/css/css2-system-fonts-expected.png: Removed.
- platform/mac-mavericks/fast/css/css2-system-fonts-expected.txt:
- platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt: Removed.
- platform/mac/fast/css/css2-system-fonts-expected.png: Removed.
- platform/mac/fast/css/css2-system-fonts-expected.txt:
- 12:19 AM Changeset in webkit [178986] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix debug build after r178940
https://bugs.webkit.org/show_bug.cgi?id=140814
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-01-23
Reviewed by Carlos Garcia Campos.
- platform/graphics/opentype/OpenTypeVerticalData.cpp:
(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs):
