Timeline
Feb 9, 2015:
- 11:40 PM Changeset in webkit [179865] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
JSC's Type Profiler doesn't profile the type of the looping variable in ForOf/ForIn loops
https://bugs.webkit.org/show_bug.cgi?id=141241
Reviewed by Filip Pizlo.
Type information is now recorded for ForIn and ForOf statements.
It was an oversight to not have these statements profiled before.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):
- tests/typeProfiler/loop.js: Added.
(testForIn):
(testForOf):
- 11:09 PM Changeset in webkit [179864] by
-
- 2 edits in trunk/LayoutTests
[Win] Activate media tests. (Unreviewed)
- platform/win/TestExpectations: Activate tests.
- 8:46 PM Changeset in webkit [179863] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::StackLayoutPhase should always set the scopeRegister to VirtualRegister() because the DFG doesn't do anything to make its value valid
https://bugs.webkit.org/show_bug.cgi?id=141412
Reviewed by Michael Saboff.
StackLayoutPhase was attempting to ensure that the register that
CodeBlock::scopeRegister() points to is the right one for the DFG. But the DFG did nothing
else to maintain the validity of the scopeRegister(). It wasn't captured as far as I can
tell. StackLayoutPhase didn't explicitly mark it live. PreciseLocalClobberize didn't mark
it as being live. So, by the time we got here the register referred to by
CodeBlock::scopeRegister() would have been junk. Moreover, CodeBlock::scopeRegister() was
not used for DFG code blocks, and was hardly ever used outside of bytecode generation.
So, this patch just removes the code to manipulate this field and replaces it with an
unconditional setScopeRegister(VirtualRegister()). Setting it to the invalid register
ensures that any attempst to read the scopeRegister in a DFG or FTL frame immediately
punts.
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- 7:27 PM Changeset in webkit [179862] by
-
- 21 edits2 adds in trunk/Source/JavaScriptCore
Varargs frame set-up should be factored out for use by other JITs
https://bugs.webkit.org/show_bug.cgi?id=141388
Reviewed by Michael Saboff.
Previously the code that dealt with varargs always assumed that we were setting up a varargs call
frame by literally following the execution semantics of op_call_varargs. This isn't how it'll
happen once the DFG and FTL do varargs calls, or when varargs calls get inlined. The DFG and FTL
don't literally execute bytecode; for example their stack frame layout has absolutely nothing in
common with what the bytecode says, and that will never change.
This patch makes two changes:
Setting up the varargs callee frame can be done in smaller steps: particularly in the case of a
varargs call that gets inlined, we aren't going to actually want to set up a callee frame in
full - we just want to put the arguments somewhere, and that place will not have much (if
anything) in common with the call frame format. This patch factors that out into something called
a loadVarargs. The thing we used to call loadVarargs is now called setupVarargsFrame. This patch
also separates loading varargs from setting this, since the fact that those two things are done
together is a detail made explicit in bytecode but it's not at all required in the higher-tier
engines. In the process of factoring this code out, I found a bunch of off-by-one errors in the
various calculations. I fixed them. The distance from the caller's frame pointer to the callee
frame pointer is always:
numUsedCallerSlots + argCount + 1 + CallFrameSize
where numUsedCallerSlots is toLocal(firstFreeRegister) - 1, which simplifies down to just
-firstFreeRegister. The code now speaks of numUsedCallerSlots rather than firstFreeRegister,
since the latter is a bytecode peculiarity that doesn't apply in the DFG or FTL. In the DFG, the
internally-computed frame size, minus the parameter slots, will be used for numUsedCallerSlots.
In the FTL, we will essentially compute numUsedCallerSlots dynamically by subtracting SP from FP.
Eventually, LLVM might give us some cleaner way of doing this, but it probably doesn't matter
very much.
The arguments forwarding optimization is factored out of the Baseline JIT: the DFG and FTL will
want to do this optimization as well, but it involves quite a bit of code. So, this code is now
factored out into SetupVarargsFrame.h|cpp, so that other JITs can use it. In the process of factoring
this code out I noticed that the 32-bit and 64-bit code is nearly identical, so I combined them.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.h:
(JSC::ExecState::r):
(JSC::ExecState::uncheckedR):
- bytecode/VirtualRegister.h:
(JSC::VirtualRegister::operator+):
(JSC::VirtualRegister::operator-):
(JSC::VirtualRegister::operator+=):
(JSC::VirtualRegister::operator-=):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
(JSC::sizeFrameForVarargs):
(JSC::loadVarargs):
(JSC::setupVarargsFrame):
(JSC::setupVarargsFrameAndSetThis):
- interpreter/Interpreter.h:
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::AssemblyHelpers::emitGetFromCallFrameHeader32):
(JSC::AssemblyHelpers::emitGetFromCallFrameHeader64):
- jit/JIT.h:
- jit/JITCall.cpp:
(JSC::JIT::compileSetupVarargsFrame):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileSetupVarargsFrame):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
(JSC::JIT::emitGetFromCallFrameHeaderPtr): Deleted.
(JSC::JIT::emitGetFromCallFrameHeader32): Deleted.
(JSC::JIT::emitGetFromCallFrameHeader64): Deleted.
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/SetupVarargsFrame.cpp: Added.
(JSC::emitSetupVarargsFrameFastCase):
- jit/SetupVarargsFrame.h: Added.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Arguments.cpp:
(JSC::Arguments::copyToArguments):
- runtime/Arguments.h:
- runtime/JSArray.cpp:
(JSC::JSArray::copyToArguments):
- runtime/JSArray.h:
- 5:21 PM Changeset in webkit [179861] by
-
- 68 edits in trunk/Source/WebCore
Update WEBCORE_EXPORT to prepare to start using it.
https://bugs.webkit.org/show_bug.cgi?id=141409
Patch by Alex Christensen <achristensen@webkit.org> on 2015-02-09
Reviewed by Tim Horton.
- bindings/js/JSDOMGlobalObject.h:
- bindings/objc/DOMInternal.h:
- bindings/objc/ExceptionHandlers.mm:
- bindings/objc/WebScriptObjectPrivate.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
- bindings/scripts/test/JS/JSTestEventConstructor.h:
- bindings/scripts/test/JS/JSTestEventTarget.h:
- bindings/scripts/test/JS/JSTestException.h:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestTypedefs.h:
- bindings/scripts/test/JS/JSattribute.h:
- bindings/scripts/test/JS/JSreadonly.h:
- css/StyleProperties.h:
- dom/DeviceMotionData.h:
- dom/Node.h:
- dom/Position.h:
- dom/ScriptExecutionContext.h:
- editing/Editor.h:
- editing/htmlediting.h:
- html/HTMLInputElement.h:
- html/TimeRanges.h:
- loader/FrameLoader.h:
- loader/cache/CacheValidation.h:
- loader/cache/MemoryCache.h:
- loader/icon/IconDatabase.h:
- page/DatabaseProvider.h:
- page/DiagnosticLoggingKeys.h:
- page/EventHandler.h:
- page/FrameSnapshotting.h:
- page/MainFrame.h:
- page/PageConsoleClient.h:
- page/PageOverlay.h:
- platform/CrossThreadCopier.h:
- platform/FileSystem.h:
- platform/PlatformSpeechSynthesizer.h:
- platform/RemoteCommandListener.h:
- platform/RuntimeApplicationChecks.h:
- platform/graphics/Font.h:
- platform/graphics/FontCache.h:
- platform/graphics/FontGlyphs.h:
- platform/graphics/FontRanges.h:
- platform/graphics/GeometryUtilities.h:
- platform/graphics/GlyphPage.h:
- platform/graphics/Region.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/TileController.h:
- platform/graphics/transforms/TransformationMatrix.h:
- platform/mac/WebCoreFullScreenWarningView.h:
- platform/network/BlobDataFileReference.h:
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.h:
- platform/network/create-http-header-name-table:
- platform/network/mac/WebCoreURLResponse.h:
- platform/sql/SQLiteDatabaseTracker.h:
- platform/sql/SQLiteStatement.h:
- rendering/HitTestLocation.h:
- rendering/HitTestResult.h:
- storage/StorageEventDispatcher.h:
Added WEBCORE_EXPORT macros.
- 5:17 PM Changeset in webkit [179860] by
-
- 2 edits in trunk/Source/WebCore
Check for self-assignment in Length::operator=(const Length&)
https://bugs.webkit.org/show_bug.cgi?id=141402
Reviewed by Andreas Kling.
Check for self-assignment in Length::operator=(const Length&) as
calling memcpy() with the same source and destination addresses has
undefined behavior.
- platform/Length.h:
(WebCore::Length::operator=):
- 5:02 PM Changeset in webkit [179859] by
-
- 22 edits2 deletes in trunk
WebGL: Update 1.0.2 conformance layout tests and address new failure.
https://bugs.webkit.org/show_bug.cgi?id=141408.
<rdar://problem/19773236>
Reviewed by Dean Jackson.
Tests covered by updated 1.0.2 conformance tests.
- html/canvas/WebGLRenderingContextBase.cpp:
Return null string instead of empty string if parameter validation fails.
(WebCore::WebGLRenderingContextBase::getProgramInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderInfoLog):
(WebCore::WebGLRenderingContextBase::getShaderSource):
- fast/canvas/webgl/bad-arguments-test-expected.txt: Removed.
- fast/canvas/webgl/bad-arguments-test.html: Removed. Redundant test case.
- webgl/1.0.2/resources/webgl_test_files/README.md:
- webgl/1.0.2/resources/webgl_test_files/conformance/attribs/gl-disabled-vertex-attrib.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-s3tc.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/extensions/webgl-debug-shaders.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/misc/bad-arguments-test.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/misc/webgl-specific.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/more/functions/uniformMatrixBadArgs.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/more/unit.js:
- webgl/1.0.2/resources/webgl_test_files/conformance/more/util.js:
(VBO.prototype.use):
- webgl/1.0.2/resources/webgl_test_files/conformance/rendering/multisample-corruption.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/resources/fragmentShader.frag:
- webgl/1.0.2/resources/webgl_test_files/conformance/resources/glsl-generator.js:
- webgl/1.0.2/resources/webgl_test_files/conformance/resources/vertexShader.vert:
- webgl/1.0.2/resources/webgl_test_files/conformance/resources/webgl-test-utils.js:
(WebGLTestUtils):
- webgl/1.0.2/resources/webgl_test_files/test-guidelines.md:
- webgl/1.0.2/resources/webgl_test_files/webgl-conformance-tests.html:
- 4:43 PM Changeset in webkit [179858] by
-
- 2 edits in tags/Safari-601.1.17.1/Source/WebCore
Merged r179839. rdar://problem/19520735
- 4:32 PM Changeset in webkit [179857] by
-
- 5 edits in tags/Safari-601.1.17.1/Source
Versioning.
- 4:30 PM Changeset in webkit [179856] by
-
- 1 copy in tags/Safari-601.1.17.1
New tag.
- 4:12 PM Changeset in webkit [179855] by
-
- 2 edits in trunk/Source/WTF
REGRESSION: tryFastCalloc is no longer "try"
https://bugs.webkit.org/show_bug.cgi?id=141406
Reviewed by Darin Adler.
This causes crashes on some WebKit regression test bots.
- wtf/FastMalloc.cpp: (WTF::tryFastCalloc): Fix what looks like a copy/paste mistake.
- 3:58 PM Changeset in webkit [179854] by
-
- 1 copy in tags/Safari-600.5.5
New tag.
- 3:48 PM Changeset in webkit [179853] by
-
- 5 edits in branches/safari-600.4-branch/Source
Versioning.
- 3:43 PM Changeset in webkit [179852] by
-
- 5 edits in branches/safari-600.1.17-branch/Source
Versioning.
- 3:39 PM Changeset in webkit [179851] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG call codegen should resolve the callee operand as late as possible
https://bugs.webkit.org/show_bug.cgi?id=141398
Reviewed by Mark Lam.
This is mostly a benign restructuring to help with the implementation of
https://bugs.webkit.org/show_bug.cgi?id=141332.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- 3:39 PM Changeset in webkit [179850] by
-
- 3 edits in trunk/Source/WebCore
Avoid using a HashMap for DisplayRefreshMonitorManager, which rarely has more than one item
https://bugs.webkit.org/show_bug.cgi?id=141353
Reviewed by Anders Carlsson.
No new tests, because there's no behavior change.
- platform/graphics/DisplayRefreshMonitorManager.cpp:
(WebCore::DisplayRefreshMonitorManager::ensureMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh):
- platform/graphics/DisplayRefreshMonitorManager.h:
Use a Vector of RefPtr<DisplayRefreshMonitor> instead of a HashMap
from uint64_t to RefPtr<DisplayRefreshMonitor>. There's usually only one
display, so there's usually only one DisplayRefreshMonitor. Linear search
on the Vector will be faster than the hash lookup in all conceivable cases.
This also avoids the situation mentioned in the comments in DisplayRefreshMonitorManager.h
where we don't know enough about PlatformDisplayID to safely hash it.
- 3:26 PM Changeset in webkit [179849] by
-
- 1 copy in tags/Safari-600.1.17.7
New tag.
- 3:25 PM Changeset in webkit [179848] by
-
- 2 edits in branches/safari-600.1.17-branch/Source/WebKit/win
Merged r179841. <rdar://problem/19772847>
- 3:19 PM Changeset in webkit [179847] by
-
- 2 edits in trunk/Source/WebKit2
Selection flickers when trying to change size of selection.
https://bugs.webkit.org/show_bug.cgi?id=141404
rdar://problem/18824863
Reviewed by Benjamin Poulain.
When looking for the contracted range from the current range,
we were incorrectly choosing a selection whose rectangle is empty
as a best match candidate. This was throwing off all the logic
and producing a contracted range whose rectangle was bigger than the
expanded range, therefore producing a shrink threshold larger than the
growth one.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::contractedRangeFromHandle):
- 3:19 PM Changeset in webkit [179846] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception when reporting wrong backend command call signature
https://bugs.webkit.org/show_bug.cgi?id=141401
Reviewed by Joseph Pecoraro.
- UserInterface/Protocol/InspectorBackend.js:
(InspectorBackend.Command.prototype._invokeWithArguments): Fix wrong variable name.
- 3:09 PM Changeset in webkit [179845] by
-
- 1 copy in tags/Safari-600.1.4.15.4
New tag.
- 3:04 PM Changeset in webkit [179844] by
-
- 1 copy in tags/Safari-600.4.8
New tag.
- 2:57 PM Changeset in webkit [179843] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Disable the currentTime estimation code in HTMLMediaElement for Yosemite+
https://bugs.webkit.org/show_bug.cgi?id=141399
Reviewed by Eric Carlson.
Apparenty -[AVPlayer rate] means different things for HLS and progressive content; for progressive,
the -rate is the actual rate of playback. For HLS, the -rate is the requested rate, and will return
the requested value even if time is not progressing.
We added the currentTime estimation engine because asking AVFoundation for its -currentTime used to
be expensive, but we've been assured that in recent iOS and OS X releases, -currentTime should be
very fast. That, in combination with the HLS behavior of -rate and how it breaks the currentTime
estimation, means we should probably turn it off for iOS and Yosemite.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
(WebCore::MediaPlayerPrivateAVFoundationObjC::maximumDurationToCacheMediaTime): Move implementation to .mm.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::maximumDurationToCacheMediaTime): Disable on iOS and >=10.10.
- 12:50 PM Changeset in webkit [179842] by
-
- 8 edits in trunk/Source/WebCore
WebGL 2: Texture call format, internal format, and type validation.
https://bugs.webkit.org/show_bug.cgi?id=141318.
<rdar://problem/19733828>
Reviewed by Brent Fulgham.
Tests will be covered by WebGL2 conformance tests.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter): Add missing ExceptionCode argument.
(WebCore::WebGL2RenderingContext::copyTexImage2D): Validate texture formats based on GLES3 spec.
(WebCore::WebGL2RenderingContext::texSubImage2DBase): Validate using internal format from texture target.
(WebCore::WebGL2RenderingContext::texSubImage2DImpl): Validate using internal format from texture target.
(WebCore::WebGL2RenderingContext::texSubImage2D): Validate using internal format from texture target.
(WebCore::WebGL2RenderingContext::validateTexFuncParameters): Do extra validation for copyTexImage2D.
(WebCore::WebGL2RenderingContext::validateTexFuncFormatAndType): Validate internal format, format and type combination.
(WebCore::WebGL2RenderingContext::validateTexFuncData): Validate new data types.
This method now accepts an internal format argument.
(WebCore::WebGL2RenderingContext::baseInternalFormatFromInternalFormat):
Helper method to convert internal format to base internal format.
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::copyTexImage2D): Moved from WebGLRenderingContextBase.
(WebCore::WebGLRenderingContext::texSubImage2DBase): Ditto.
(WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
(WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::validateTexFuncParameters): Ditto.
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType): Ditto.
(WebCore::WebGLRenderingContext::validateTexFuncData): Ditto.
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texImage2DBase):
(WebCore::WebGLRenderingContextBase::validateTexFunc):
(WebCore::WebGLRenderingContextBase::texImage2D):
(WebCore::WebGLRenderingContextBase::copyTexImage2D): Deleted.
(WebCore::WebGLRenderingContextBase::texSubImage2DBase): Deleted.
(WebCore::WebGLRenderingContextBase::texSubImage2DImpl): Deleted.
(WebCore::WebGLRenderingContextBase::texSubImage2D): Deleted.
(WebCore::WebGLRenderingContextBase::validateTexFuncFormatAndType): Deleted.
(WebCore::WebGLRenderingContextBase::validateTexFuncParameters): Deleted.
(WebCore::WebGLRenderingContextBase::validateTexFuncData): Deleted.
- html/canvas/WebGLRenderingContextBase.h: Modify validation type enums to differentiate between CopyImage, TexImage and TexSubImage calls.
(WebCore::ScopedDrawingBufferBinder::ScopedDrawingBufferBinder): Moved from WebGLRenderingContextBase.
(WebCore::ScopedDrawingBufferBinder::~ScopedDrawingBufferBinder): Ditto.
(WebCore::clip1D): Ditto.
(WebCore::clip2D): Ditto.
- platform/graphics/GraphicsContext3D.h: Rename a typo'ed enum.
- 12:27 PM Changeset in webkit [179841] by
-
- 2 edits in trunk/Source/WebKit/win
AX: [Win] OBJID_CLIENT comparisons broken in 64-bit builds
https://bugs.webkit.org/show_bug.cgi?id=141391
<rdar://problem/19767342>
Reviewed by Anders Carlsson.
- WebView.cpp:
(WebView::onGetObject): Cast lParam as LONG to ensure proper word size for
comparison against OBJID_CLIENT.
- 11:57 AM Changeset in webkit [179840] by
-
- 10 edits in trunk/Source/JavaScriptCore
DFG should only have two mechanisms for describing effectfulness of nodes; previously there were three
https://bugs.webkit.org/show_bug.cgi?id=141369
Reviewed by Michael Saboff.
We previously used the NodeMightClobber and NodeClobbersWorld NodeFlags to describe
effectfulness. Starting over a year ago, we introduced a more powerful mechanism - the
DFG::clobberize() function. Now we only have one remaining client of the old NodeFlags,
and everyone else uses DFG::clobberize(). We should get rid of those NodeFlags and
finally switch everyone over to DFG::clobberize().
Unfortunately there is still another place where effectfulness of nodes is described: the
AbstractInterpreter. This is because the AbstractInterpreter has special tuning both for
compile time performance and there are places where the AI is more precise than
clobberize() because of its flow-sensitivity.
This means that after this change there will be only two places, rather than three, where
the effectfulness of a node has to be described:
- DFG::clobberize()
- DFG::AbstractInterpreter
- dfg/DFGClobberize.cpp:
(JSC::DFG::clobbersWorld):
- dfg/DFGClobberize.h:
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeGetTypedArrayByteLength):
(JSC::DFG::FixupPhase::convertToGetArrayLength):
(JSC::DFG::FixupPhase::attemptToMakeGetTypedArrayByteOffset):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::isPredictedNumerical): Deleted.
(JSC::DFG::Graph::byValIsPure): Deleted.
(JSC::DFG::Graph::clobbersWorld): Deleted.
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToGetLocalUnlinked):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToMultiGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::convertToMultiPutByOffset):
- dfg/DFGNodeFlags.cpp:
(JSC::DFG::dumpNodeFlags):
- dfg/DFGNodeFlags.h:
- dfg/DFGNodeType.h:
- 11:53 AM Changeset in webkit [179839] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r179494.
https://bugs.webkit.org/show_bug.cgi?id=141395
Caused slowdown in a WebKit client test scenario (Requested by
kling on #webkit).
Reverted changeset:
"[Cocoa] Make decoded image data purgeable ASAP."
https://bugs.webkit.org/show_bug.cgi?id=140298
http://trac.webkit.org/changeset/179494
- 11:45 AM Changeset in webkit [179838] by
-
- 5 edits8 adds in trunk
[WebAudio] AudioBufferSourceNodes should accurately play backwards if given a negative playbackRate.
https://bugs.webkit.org/show_bug.cgi?id=140955
Reviewed by Eric Carlson.
Source/WebCore:
Tests: webaudio/audiobuffersource-negative-playbackrate-interpolated.html
webaudio/audiobuffersource-negative-playbackrate.html
Add support for playing an AudioBufferSourceNode at a negative playbackRate. Change the meaning of
start() to set the initial playback position at the end of the play range if the rate of playback
is negtive.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode): Allow the playbackRate AudioParam to range from [-32, 32].
(WebCore::AudioBufferSourceNode::renderFromBuffer): Change variable names from "start" and "end" to "min" and "max"
for clarity. Add a non-interpolated and interpolated render step for negative playback.
(WebCore::AudioBufferSourceNode::start): Drive-by fix: default value of grainDuration is not 0.02.
(WebCore::AudioBufferSourceNode::startPlaying): Start playing at the end of the buffer for negative playback.
(WebCore::AudioBufferSourceNode::totalPitchRate): Allow the pitch to be negative.
LayoutTests:
- webaudio/audiobuffersource-negative-playbackrate-expected.txt: Added.
- webaudio/audiobuffersource-negative-playbackrate-interpolated-expected.txt: Added.
- webaudio/audiobuffersource-negative-playbackrate-interpolated-loop-expected.txt: Added.
- webaudio/audiobuffersource-negative-playbackrate-interpolated-loop.html: Added.
- webaudio/audiobuffersource-negative-playbackrate-interpolated.html:
- webaudio/audiobuffersource-negative-playbackrate-loop-expected.txt: Added.
- webaudio/audiobuffersource-negative-playbackrate-loop.html: Added.
- webaudio/audiobuffersource-negative-playbackrate.html:
- webaudio/resources/audiobuffersource-testing.js:
(createRamp):
Get rid of extra HRTF padding as it's now unnecessary.
- webaudio/resources/note-grain-on-testing.js:
(createSignalBuffer):
(verifyStartAndEndFrames):
- 11:33 AM WebKitGTK/Gardening/Howto edited by
- (diff)
- 11:29 AM WebKitGTK/Gardening/Howto edited by
- (diff)
- 11:29 AM WebKitGTK/Gardening/Howto edited by
- (diff)
- 11:28 AM WebKitGTK/Gardening/Howto edited by
- (diff)
- 11:27 AM WebKitGTK/Gardening edited by
- (diff)
- 11:27 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 11:23 AM WebKitGTK/Gardening/Howto edited by
- (diff)
- 11:19 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 10:59 AM Changeset in webkit [179837] by
-
- 2 edits in trunk/LayoutTests
[iOS] Gardening: css3/masking/mask-repeat-space-padding.html
- platform/ios-simulator-wk2/TestExpectations: Remove
expectation since this is covered in
platform/ios-simulator/TestExpectations as an ImageOnlyFailure.
- 10:53 AM Changeset in webkit [179836] by
-
- 3 edits in trunk/LayoutTests
[iOS] Gardening for editing/execCommand/remove-list-item-1.html
- platform/ios-simulator-wk1/TestExpectations:
(editing/execCommand/remove-list-item-1.html): Mark as flakey.
When run (with or without --run-singly), this test always passes
the first time, but fails all subsequent times due to
EDITING DELEGATE: shouldChangeSelectedDOMRange:range
running in a different order.
- platform/ios-simulator-wk2/editing/execCommand/remove-list-item-1-expected.txt: Update.
- 10:26 AM Changeset in webkit [179835] by
-
- 2 edits in branches/safari-600.5-branch/Source/WebKit2
Merged r179809. rdar://problem/19711203
- 10:24 AM Changeset in webkit [179834] by
-
- 2 edits in branches/safari-600.4-branch/Source/WebKit2
Merged r179809. rdar://problem/19711203
- 10:23 AM Changeset in webkit [179833] by
-
- 5 edits in branches/safari-600.4-branch/Source
Versioning.
- 10:22 AM Changeset in webkit [179832] by
-
- 1 edit1 add in trunk/LayoutTests
REGRESSION (r179771): [iOS] Gardening for compositing/layer-creation/subpixel-adjacent-layers-overlap.html
Test recently added for:
Convert the compositing overlap map to use LayoutRects
<http://webkit.org/b/141346>
- platform/ios-simulator/compositing/layer-creation/subpixel-adjacent-layers-overlap-expected.txt:
Add platform-specific results for ios-simulator.
- 10:07 AM Changeset in webkit [179831] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the !ENABLE(DFG_JIT) build
https://bugs.webkit.org/show_bug.cgi?id=141387
Reviewed by Darin Adler.
- jit/Repatch.cpp:
- 9:52 AM Changeset in webkit [179830] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests shell test runner should run tests in fixed order
https://bugs.webkit.org/show_bug.cgi?id=141383
Reviewed by Darin Adler.
- Scripts/jsc-stress-test-helpers/shell-runner.sh:
- 9:15 AM Changeset in webkit [179829] by
-
- 3 edits in trunk/Source/WebCore
Try to fix build on platforms that use SVG "all in one" file (Windows).
- svg/SVGAElement.cpp: Don't do "using namespace HTMLNames;" outside of
function boundaries, because that will be inherited by other files.
(WebCore::SVGAElement::isURLAttribute): Use XLinkNames directly here
instead of using HTMLNames implicitly.
- svg/SVGElement.cpp: Don't do "using namespace HTMLNames;" outside of
function boundaries, because that will be inherited by other files.
(WebCore::populateAttributeNameToCSSPropertyIDMap): Instead do it in here.
(WebCore::populateAttributeNameToAnimatedPropertyTypeMap): And here.
(WebCore::populateCSSPropertyWithSVGDOMNameToAnimatedPropertyTypeMap): And here.
(WebCore::SVGElement::parseAttribute): And use HTMLNames directly here
instead of implicitly.
- 8:37 AM Changeset in webkit [179828] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r179705): 2nd-level inspector availability no longer controlled by DeveloperExtrasEnabled user default
https://bugs.webkit.org/show_bug.cgi?id=141343
Reviewed by Timothy Hatcher.
The regression was caused by the switch to using WKWebViewConfiguration and
its default WebPreferences object, which is used to populate the inspector page's
Settings object. This WebPreferences is initialized with no identifier, so
only preferences in the FOR_EACH_WEBKIT_DEBUG_*_PREFERENCE macros are populated
from NSUserDefaults.
The simplest fix is to move DeveloperExtrasEnabled into the DEBUG group.
Previously, each inspector level had a unique identifier such as
WebInspectorPageGroupLevelN, and the n+1 level inspector was enabled
by toggling WebInspectorPageGroupLevelN.WebKit2DeveloperExrasEnabled.
With the move to the DEBUG group, the preference becomes simply
WebKitDeveloperExtrasEnabled, which enables any level of inspector.
(This does not clash with Safari's "Show Develop Menu" preference, which uses
the key "WebKitDeveloperExtrasEnabledPreferenceKey")
- Shared/WebPreferencesDefinitions.h:
- 8:22 AM Changeset in webkit [179827] by
-
- 2 edits in trunk/Source/WebCore
[iOS] exit from fullscreen when player view controller calls delegate
https://bugs.webkit.org/show_bug.cgi?id=141350
Reviewed by Jer Noble.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController playerViewControllerWillCancelOptimizedFullscree:]): New, ask delegate
to exit from fullscreen.
- 7:56 AM HackingWebInspector edited by
- update NSUserDefaults keys after … (diff)
- 6:05 AM Changeset in webkit [179826] by
-
- 3 edits1 add in trunk
ASSERTION FAILED: resolvedInitialPosition <= resolvedFinalPosition in WebCore::GridSpan::GridSpan
https://bugs.webkit.org/show_bug.cgi?id=141328
Reviewed by Darin Adler.
.:
Added as manual test because it involves a huge grid allocation
which is very slow on Debug bots, the only ones capable to trigger
the assertion.
- ManualTests/css-grid-layout-item-with-huge-span-crash.html: Added.
Source/WebCore:
Whenever
GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition()
was trying to place an item with span, it was completely ignoring
the resolvedInitialPosition returned by
GridResolvedPosition::resolveGridPositionAgainstOppositePosition()
and only using the finalResolvedPosition. This works with an
unlimited grid which can indefinitely grow. But if the item spans
over the grid track limits, then it might happen that the final
resolved position is placed before the initial resolved position,
something that is forbidden.
The solution is to directly use the GridSpan returned by
GridResolvedPosition::resolveGridPositionAgainstOppositePosition(), if the item
does not surpass the track limits then the returned initialResolvedPosition
is identical to the provided one, otherwise it's properly corrected to respect
track boundaries.
- rendering/style/GridResolvedPosition.cpp:
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
- 5:18 AM Changeset in webkit [179825] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK Gardening.
- platform/gtk/TestExpectations: Mark new test failing
- platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt: Added. Rebaseline after r177774.
- 4:32 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 4:04 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 3:55 AM WebKitGTK/Gardening/Calendar created by
- 3:55 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 3:54 AM WebKitGTK/Gardening edited by
- (diff)
- 3:52 AM WebKitGTK/Gardening/Howto created by
- 3:34 AM Changeset in webkit [179824] by
-
- 6 edits in trunk
[CSS Grid Layout] Tracks' growth limits must be >= base sizes
https://bugs.webkit.org/show_bug.cgi?id=140540
Reviewed by Antti Koivisto.
Source/WebCore:
The track sizing algorithm is supposed to avoid those situations
but they easily (specially when we mix absolute lengths and
intrinsic lengths in min and max track sizing functions) and
frequently appear. In those cases the outcome from the algorithm
is wrong, tracks are not correctly sized.
In order to fulfill the restriction, m_usedBreadth and
m_maxBreadth are now private members of GridTrack and the class
now provides a couple of methods to modify them respecting the
growthLimit >= baseSize precondition.
Apart from that, the members and methods of GridTrack were also
renamed to match the ones used in the recent algorithm rewrite:
usedBreadth became baseSize and maxBreadth is now growthLimit.
Although the algorithm was not modified at all, this change
detected and fixed several invalid results (tracks and/or grids
bigger than expected).
- rendering/RenderGrid.cpp:
(WebCore::GridTrack::GridTrack): Renamed fields and methods. Added
assertions.
(WebCore::GridTrack::baseSize): Renamed from usedBreadth.
(WebCore::GridTrack::growthLimit): Renamed from maxBreadth.
(WebCore::GridTrack::setBaseSize):
(WebCore::GridTrack::setGrowthLimit):
(WebCore::GridTrack::growBaseSize): Renamed from growUsedBreadth.
(WebCore::GridTrack::growGrowthLimit): Renamed from growMaxBreadth.
(WebCore::GridTrack::growthLimitIsInfinite): New helper method.
(WebCore::GridTrack::growthLimitIfNotInfinite): Renamed from
maxBreadthIfNotInfinite.
(WebCore::GridTrack::isGrowthLimitBiggerThanBaseSize): New helper
method to verify ASSERTs are true.
(WebCore::GridTrack::ensureGrowthLimitIsBiggerThanBaseSize): Ditto.
(WebCore::GridTrackForNormalization::GridTrackForNormalization):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeNormalizedFractionBreadth):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::sortByGridTrackGrowthPotential):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::GridTrack::growUsedBreadth): Renamed to growBaseSize.
(WebCore::GridTrack::usedBreadth): Renamed to baseSize.
(WebCore::GridTrack::growMaxBreadth): Renamed to growGrowthLimit.
(WebCore::GridTrack::maxBreadthIfNotInfinite): Renamed to
growthLimitIfNotInfinite.
- rendering/RenderGrid.h:
LayoutTests:
- fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
- fast/css-grid-layout/grid-content-sized-columns-resolution.html:
- 3:03 AM Changeset in webkit [179823] by
-
- 3 edits in trunk/Source/WebKit2
Measure cache size more accurately
https://bugs.webkit.org/show_bug.cgi?id=141378
<rdar://problem/19760224>
Reviewed by Chris Dumez.
Estimate the cache disk space usage from the actual entry sizes instead of the item count.
This prevents large cache items from making the cache grow beyond its bounds.
- NetworkProcess/cache/NetworkCacheStorage.h:
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::initialize):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::clear):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
- 2:01 AM WebKitGTK/Gardening created by
- 12:18 AM Changeset in webkit [179822] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, add new baseline since r179796.
New baseline was added by r179796. EFL port supports the test as well.
This patch adds new baseline based on EFL port.
- platform/efl/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
- platform/efl/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.
- 12:02 AM Changeset in webkit [179821] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r179705): [GTK] The Web Inspector doesn't work after r179705
https://bugs.webkit.org/show_bug.cgi?id=141333
Reviewed by Žan Doberšek.
Create an initialize WebPreferences for the inspector page. This
was moved from cross-platform code to platform specific code.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Feb 8, 2015:
- 11:09 PM Changeset in webkit [179820] by
-
- 10 edits2 adds in trunk
AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
https://bugs.webkit.org/show_bug.cgi?id=140485
Reviewed by Anders Carlsson.
Source/WebCore:
If setting an accessibility attribute results in a modal alert being displayed, it can cause VoiceOver
to hang. A simple solution is perform the actual work after a short delay, which will ensure the call
returns without hanging.
Test: platform/mac/accessibility/setting-attributes-is-asynchronous.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
Tools:
Implement takeFocus() as a way to set focus through accessibility wrappers.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::takeFocus):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::takeFocus):
LayoutTests:
Modify tests that relied on setting behavior and immediately checking results. Those
tests now need to retrieve results after a short timeout.
- accessibility/textarea-selected-text-range-expected.txt:
- accessibility/textarea-selected-text-range.html:
- platform/mac/accessibility/select-element-selection-with-optgroups.html:
- platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt: Added.
- platform/mac/accessibility/setting-attributes-is-asynchronous.html: Added.
- 7:44 PM Changeset in webkit [179819] by
-
- 10 edits8 adds in trunk
Add parsing support for CSS Selector L4's case-insensitive attribute
https://bugs.webkit.org/show_bug.cgi?id=141373
Reviewed by Darin Adler.
Source/WebCore:
This patch adds parsing for the case-insensitive attribute value
matching of CSS Selectors Level 4: http://dev.w3.org/csswg/selectors-4/#attribute-case
Excuse of a grammar: http://dev.w3.org/csswg/selectors-4/#grammar
This patch also covers serialization for CSSOM. The serialization
is defined here: http://dev.w3.org/csswg/cssom/#serializing-selectors
Matching is completely ignored in this patch. All the simple selectors
are treated as regular attribute selectors.
Tests: fast/css/parsing-css-attribute-case-insensitive-value-1.html
fast/css/parsing-css-attribute-case-insensitive-value-2.html
fast/css/parsing-css-attribute-case-insensitive-value-3.html
fast/css/parsing-css-attribute-case-insensitive-value-4.html
- css/CSSGrammar.y.in:
- css/CSSParserValues.h:
(WebCore::CSSParserSelector::setAttributeValueMatchingIsCaseInsensitive):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::setAttributeValueMatchingIsCaseInsensitive):
(WebCore::CSSSelector::attributeValueMatchingIsCaseInsensitive):
LayoutTests:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/css-set-selector-text-expected.txt:
- fast/css/css-set-selector-text.html:
Basic round-trip serialization through CSSOM.
- fast/css/parsing-css-attribute-case-insensitive-value-1-expected.txt: Added.
- fast/css/parsing-css-attribute-case-insensitive-value-1.html: Added.
Simple cases by themself and used in complex selectors.
- fast/css/parsing-css-attribute-case-insensitive-value-2-expected.txt: Added.
- fast/css/parsing-css-attribute-case-insensitive-value-2.html: Added.
Less simple cases, all kinds of valid syntax for case-insensitive attributes.
- fast/css/parsing-css-attribute-case-insensitive-value-3-expected.txt: Added.
- fast/css/parsing-css-attribute-case-insensitive-value-3.html: Added.
Cases that must be treated as invalid selectors.
- fast/css/parsing-css-attribute-case-insensitive-value-4-expected.txt: Added.
- fast/css/parsing-css-attribute-case-insensitive-value-4.html: Added.
Verify that invalid rules do not affect surrounding valid rules.
- 6:56 PM Changeset in webkit [179818] by
-
- 3 edits in trunk/LayoutTests
[iOS] Skip js/dom/create-lots-of-workers.html on ios-simulator
Already skipped on mac; marked as flakey on efl and gtk.
Fix tracked by:
REGRESSION: js/dom/create-lots-of-workers.html frequently crashes (sometimes in js/dom/cross-frame-bad-time.html)
<http://webkit.org/b/129758>
<rdar://problem/19760988>
- platform/ios-simulator/TestExpectations: Skip test.
- platform/mac/TestExpectations: Add comment about skipping on
ios-simulator.
- 6:42 PM Changeset in webkit [179817] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove a few duplicate propagation steps from the DFG's PredictionPropagation phase
https://bugs.webkit.org/show_bug.cgi?id=141363
Reviewed by Darin Adler.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
Some blocks were duplicated, they probably evolved separately
to the same state.
- 6:40 PM Changeset in webkit [179816] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove useless declarations and a stale comment from DFGByteCodeParser.h
https://bugs.webkit.org/show_bug.cgi?id=141361
Reviewed by Darin Adler.
The comment refers to the original form of the ByteCodeParser:
parse(Graph&, JSGlobalData*, CodeBlock*, unsigned startIndex);
That form is long dead, the comment is more misleading than anything.
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGByteCodeParser.h:
- 6:38 PM Changeset in webkit [179815] by
-
- 3 edits in trunk/Source/JavaScriptCore
Encapsulate DFG::Plan's beforeFTL timestamp
https://bugs.webkit.org/show_bug.cgi?id=141360
Reviewed by Darin Adler.
Make the attribute private, it is an internal state.
Rename beforeFTL->timeBeforeFTL for readability.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
- 6:37 PM Changeset in webkit [179814] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove DFGNode::hasArithNodeFlags()
https://bugs.webkit.org/show_bug.cgi?id=141319
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-02-08
Reviewed by Michael Saboff.
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags): Deleted.
Unused code is unused.
- 5:50 PM Changeset in webkit [179813] by
-
- 2 edits in trunk/Source/WebCore
Fix CMake-based build.
- CMakeLists.txt: Added a dependency on the CMakeLists.txt itself, analogous
to the one I added in DerivedSources.make.
- 5:40 PM Changeset in webkit [179812] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- bindings/js/JSEventListener.h: Removed a call to forwardEventListeners.
- 5:25 PM Changeset in webkit [179811] by
-
- 2 edits in trunk/LayoutTests
fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=141364
Reviewed by Sam Weinig.
Make the test wait for the plug-in to become available.
- fullscreen/full-screen-plugin.html:
- 5:13 PM Changeset in webkit [179810] by
-
- 88 edits4 deletes in trunk
Remove the SVG instance tree
https://bugs.webkit.org/show_bug.cgi?id=140602
Reviewed by Dean Jackson.
Source/WebCore:
- CMakeLists.txt: Removed SVGElementInstance source files.
- DerivedSources.cpp: Ditto.
- DerivedSources.make: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSEventListener.cpp:
(WebCore::forwardsEventListeners): Deleted. Only returned true for JSSVGElementInstance.
(WebCore::correspondingElementWrapper): Deleted. Only used for JSSVGElementInstance.
(WebCore::createJSEventListenerForAttribute): Deleted. Argument type was JSSVGElementInstance.
(WebCore::createJSEventListenerForAdd): Removed most of the code; later we can delete this entirely.
- bindings/js/JSEventListener.h: Removed the overload of createJSEventListenerForAttribute
that takes a JSSVGElementInstance.
- bindings/js/JSSVGElementInstanceCustom.cpp: Removed.
- dom/ContainerNodeAlgorithms.h: Updated comment to reflect the fact that
this code is really now only used for ContainerNode and no longer needs to
exist in a generic form.
- dom/EventTarget.h: Removed forward declaration of SVGElementInstance.
- svg/SVGElement.h: Ditto.
- dom/EventTargetFactory.in: Removed SVGElementInstance.
- svg/SVGElementInstance.cpp: Removed.
- svg/SVGElementInstance.h: Removed.
- svg/SVGElementInstance.idl: Removed.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto): Removed obsolete comment.
(WebCore::SVGUseElement::instanceTreeIsLoading): Deleted. Unused
function that I forgot to delete in my last patch. It also had a
glaring mistake, a missing "return" before the recursive call to
itself that would cause it to return false when it should return true.
- svg/SVGUseElement.h: Removed instanceTreeIsLoading.
- dom/EventDispatcher.cpp: Removed include of SVGElementInstance.h.
- page/EventHandler.cpp: Ditto.
- rendering/svg/RenderSVGViewportContainer.cpp: Ditto.
- svg/SVGAElement.cpp: Ditto.
- svg/SVGAllInOne.cpp: Ditto.
- svg/SVGAnimateMotionElement.cpp: Ditto.
- svg/SVGAnimatedTypeAnimator.h: Ditto.
- svg/SVGAnimationElement.cpp: Ditto.
- svg/SVGCircleElement.cpp: Ditto.
- svg/SVGClipPathElement.cpp: Ditto.
- svg/SVGComponentTransferFunctionElement.cpp: Ditto.
- svg/SVGCursorElement.cpp: Ditto.
- svg/SVGElement.cpp: Ditto.
- svg/SVGEllipseElement.cpp: Ditto.
- svg/SVGFEBlendElement.cpp: Ditto.
- svg/SVGFEColorMatrixElement.cpp: Ditto.
- svg/SVGFECompositeElement.cpp: Ditto.
- svg/SVGFEConvolveMatrixElement.cpp: Ditto.
- svg/SVGFEDiffuseLightingElement.cpp: Ditto.
- svg/SVGFEDisplacementMapElement.cpp: Ditto.
- svg/SVGFEDropShadowElement.cpp: Ditto.
- svg/SVGFEGaussianBlurElement.cpp: Ditto.
- svg/SVGFEImageElement.cpp: Ditto.
- svg/SVGFELightElement.cpp: Ditto.
- svg/SVGFEMergeNodeElement.cpp: Ditto.
- svg/SVGFEMorphologyElement.cpp: Ditto.
- svg/SVGFEOffsetElement.cpp: Ditto.
- svg/SVGFESpecularLightingElement.cpp: Ditto.
- svg/SVGFETileElement.cpp: Ditto.
- svg/SVGFETurbulenceElement.cpp: Ditto.
- svg/SVGFilterElement.cpp: Ditto.
- svg/SVGFilterPrimitiveStandardAttributes.cpp: Ditto.
- svg/SVGForeignObjectElement.cpp: Ditto.
- svg/SVGGElement.cpp: Ditto.
- svg/SVGGradientElement.cpp: Ditto.
- svg/SVGGraphicsElement.cpp: Ditto.
- svg/SVGImageElement.cpp: Ditto.
- svg/SVGLineElement.cpp: Ditto.
- svg/SVGLinearGradientElement.cpp: Ditto.
- svg/SVGMarkerElement.cpp: Ditto.
- svg/SVGMaskElement.cpp: Ditto.
- svg/SVGPathElement.cpp: Ditto.
- svg/SVGPatternElement.cpp: Ditto.
- svg/SVGPolyElement.cpp: Ditto.
- svg/SVGRadialGradientElement.cpp: Ditto.
- svg/SVGRectElement.cpp: Ditto.
- svg/SVGSVGElement.cpp: Ditto.
- svg/SVGScriptElement.cpp: Ditto.
- svg/SVGStopElement.cpp: Ditto.
- svg/SVGSymbolElement.cpp: Ditto.
- svg/SVGTRefElement.cpp: Ditto.
- svg/SVGTextContentElement.cpp: Ditto.
- svg/SVGTextElement.cpp: Ditto.
- svg/SVGTextPathElement.cpp: Ditto.
- svg/SVGTextPositioningElement.cpp: Ditto.
Tools:
- Scripts/check-for-global-initializers: Removed special case for
SVGElementInstance.o.
LayoutTests:
Last step: Remove SVGElementInstance class itself.
- js/dom/global-constructors-attributes-expected.txt: Removed SVGElementInstance.
- platform/efl/js/dom/global-constructors-attributes-expected.txt: Ditto.
- platform/gtk/js/dom/global-constructors-attributes-expected.txt: Ditto.
- platform/ios-sim-deprecated/fast/dom/Window/window-property-descriptors-expected.txt: Ditto.
- platform/ios-sim-deprecated/fast/js/global-constructors-expected.txt: Ditto.
- platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt: Ditto.
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt: Ditto.
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt: Ditto.
- platform/mac/js/dom/global-constructors-attributes-expected.txt: Ditto.
- platform/win/js/dom/global-constructors-attributes-expected.txt: Ditto.
- svg/custom/global-constructors-expected.txt: Ditto.
- svg/custom/script-tests/global-constructors.js: Ditto.
- svg/dom/svg2-inheritance-expected.txt: Ditto.
- svg/dom/svg2-inheritance.html: Ditto.
- 4:30 PM Changeset in webkit [179809] by
-
- 2 edits in trunk/Source/WebKit2
Null deref in _clearImmediateActionState when closing a view with a DataDetectors popover open
https://bugs.webkit.org/show_bug.cgi?id=141377
<rdar://problem/19711203>
Reviewed by Darin Adler.
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _clearImmediateActionState]):
We can have already detached the page when DataDetectors calls us back
in interactionStoppedHandler. While we have kept a strong reference to the
page in the interactionStoppedHandler block, _page is nulled out.
It's OK to avoid doing this work, in any case, because closing a page
tears down the TextIndicator anyway.
- 3:40 PM Changeset in webkit [179808] by
-
- 3 edits in trunk/Source/WebCore
Tweak inline playback controls to match system spec
https://bugs.webkit.org/show_bug.cgi?id=141375
<rdar://problem/19760754>
Reviewed by Sam Weinig.
Rework the UI of the inline media controls on iOS, to
better match the system specification. I've batched a
few changes into one patch because many of them are
inter-dependent, and not very aggressive. Changes are:
- updated artwork for the buttons.
- separate artwork for normal and active states.
- background images are now explicitly sized and positioned in the middle of the element, allowing audio and video to use the same glyphs even though the elements are different sizes.
- use plus-darker blend mode on the button glyphs.
- rearranged some of the rules to group things in a logical order.
- time should front-pad a "0" character, if less than 10.
- no need for an "active" class on the Airplay button (although I won't be surprised if this changes back).
- Modules/mediacontrols/mediaControlsiOS.css:
(::-webkit-media-controls):
(video::-webkit-media-controls-wireless-playback-picker-button.active): Deleted.
(audio::-webkit-media-controls-wireless-playback-picker-button.active): Deleted.
(audio::-webkit-media-controls-play-button:active): Deleted.
(audio::-webkit-media-controls-play-button.paused): Deleted.
(video::-webkit-media-controls-timeline): Deleted.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.updateWirelessPlaybackStatus): No need
for the "active" class.
(ControllerIOS.prototype.formatTime): Pad with a leading zero.
- 3:22 PM Changeset in webkit [179807] by
-
- 9 edits9 adds50 deletes in trunk
Make SVGUseElement work without creating any SVGElementInstance objects
https://bugs.webkit.org/show_bug.cgi?id=141374
Reviewed by Sam Weinig.
Source/WebCore:
- dom/ElementIterator.h: Changed the * and -> operators to be const.
There is no need for the iterator itself to be modified just to dereference it.
- dom/TypedElementDescendantIterator.h: Added DoubleTypedElementDescendantIterator.
This allows callers to call descendantsOfType on two elements, as long as the caller
can guarantee that both have the same number of descendants of that type. It's handy
for walking a tree of cloned elements to set up something between each original and
its clone. In the future we might instead change the cloning machinery so it can do
this work as we clone, and if so, we could consider deleting this.
- svg/SVGElement.cpp:
(WebCore::SVGElement::correspondingElement): Made this const.
(WebCore::SVGElement::invalidateInstances): Got rid of the rule that said "this can
only be done for an element in a document", since it's useful to do this on an element
that has just been removed from a document. Removed the "updateStyleIfNeeded" call
here now that the other changes make it no longer needed. Removed an unimportant
assertion that we only invalidate use elements that are in a document; that's not
a necessary restriction. Streamlined the logic a bit.
- svg/SVGElement.h: Made correspondingElement const.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedInto): Removed an assertion about
m_targetElementInstance since that's gone now.
(WebCore::SVGUseElement::svgAttributeChanged): Changed code that transfers
size attributes to the shadow tree to use shadowTreeTargetClone instead of
m_targetElementInstance.
(WebCore::SVGUseElement::clearResourceReferences): Removed code to detach
m_targetElementInstance, and also the call to removeAllTargetReferencesForElement,
because we no longer use those.
(WebCore::SVGUseElement::buildPendingResource): Moved the code to build the
shadow tree in here and deleted the buildShadowAndInstanceTree function.
Also changed logic so that we use a pending resource any time the target is not
a valid one. That helps us correctly handle cases where we initially have an
invalid target, but later get a value one
(WebCore::SVGUseElement::buildShadowAndInstanceTree): Deleted. The code here
was greatly simplified and moved into buildPendingResource.
(WebCore::SVGUseElement::buildInstanceTree): Deleted.
(WebCore::SVGUseElement::hasCycleUseReferencing): Deleted. Cycles are now
detected by the new isValidTarget function and so there's no need for a
separate explicit check for a cycle.
(WebCore::associateClonesWithOriginals): Added. Helper that makes
functions that build the shadow tree simpler and easier to read.
(WebCore::associateReplacementCloneWithOriginal): Added. Helper to
make associateReplacementClonesWithOriginals simple.
(WebCore::associateReplacementClonesWithOriginals): Added. Helper that
makes functions that build the shadow tree simpler and easier to read.
(WebCore::SVGUseElement::buildShadowTree): Call associateClonesWithOriginals
since associateInstancesWithShadowTreeElements no longer does this.
(WebCore::SVGUseElement::isValidTarget): Added. Covers all the different
reasons a target might not be valid: type of element, reference cycles, and
also "not in document" (refactored in here; not sure when that can happen
in practice, might be possible to remove it later).
(WebCore::SVGUseElement::expandUseElementsInShadowTree): Add checks for
documents that are still loading; this used to be checked when building the
instance tree. Added calls to associateReplacementClonesWithOriginals and
associateClonesWithOriginals; that used to be done by later in the
associateInstancesWithShadowTreeElements function. Use isValidTarget so
we handle cycles as well as invalid target types.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree): Added a call to
associateReplacementClonesWithOriginals, since we can no longer do that in
associateInstancesWithShadowTreeElements.
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements): Deleted.
(WebCore::SVGUseElement::instanceForShadowTreeElement): Deleted.
(WebCore::SVGUseElement::invalidateDependentShadowTrees): Removed a comment
that simply restated the name of the function.
- svg/SVGUseElement.h: Removed instanceForShadowTreeElement,
buildShadowAndInstanceTree, detachInstance, buildInstanceTree,
hasCycleUseReferencing, associateInstancesWithShadowTreeElements,
instanceForShadowTreeElement, and m_targetElementInstance. Added isValidTarget.
LayoutTests:
Results changed on some tests that expected the old "remove all content if a cycle is detected"
behavior from the <use> element. The new behavior is to inhibit cycles, but render everything
else, which is much easier to implement correctly and also makes logical sense. Changed all
those tests to be reference tests, which makes sense since they are focusing on what gets
rendered in these complex cases, and the expected results are a lot easier to understand in
SVG form than they were in txt/png form. This also means we can remove a lot of platform-specific
results since reference tests aren't sensitive to small platform differences in rendering.
- platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Removed.
- platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Removed.
- platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Removed.
- platform/efl/svg/hixie/error/017-expected.png: Removed.
- platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Removed.
- platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Removed.
- platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Removed.
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.png: Removed.
- platform/gtk/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Removed.
- platform/gtk/svg/custom/use-recursion-1-expected.png: Removed.
- platform/gtk/svg/custom/use-recursion-1-expected.txt: Removed.
- platform/gtk/svg/custom/use-recursion-2-expected.png: Removed.
- platform/gtk/svg/custom/use-recursion-2-expected.txt: Removed.
- platform/gtk/svg/custom/use-recursion-3-expected.png: Removed.
- platform/gtk/svg/custom/use-recursion-3-expected.txt: Removed.
- platform/gtk/svg/custom/use-recursion-4-expected.png: Removed.
- platform/gtk/svg/custom/use-recursion-4-expected.txt: Removed.
- platform/gtk/svg/hixie/error/017-expected.png: Removed.
- platform/ios-sim-deprecated/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/custom/use-recursion-1-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/custom/use-recursion-2-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/custom/use-recursion-3-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/custom/use-recursion-4-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/hixie/error/017-expected.txt: Removed.
- platform/ios-simulator/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Removed.
- platform/ios-simulator/svg/custom/use-recursion-1-expected.txt: Removed.
- platform/ios-simulator/svg/custom/use-recursion-2-expected.txt: Removed.
- platform/ios-simulator/svg/custom/use-recursion-3-expected.txt: Removed.
- platform/ios-simulator/svg/custom/use-recursion-4-expected.txt: Removed.
- platform/mac-mountainlion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
- platform/mac-mountainlion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
- platform/mac-mountainlion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
- platform/mac-mountainlion/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Removed.
- platform/mac-mountainlion/svg/custom/use-recursion-1-expected.txt: Removed.
- platform/mac-mountainlion/svg/custom/use-recursion-2-expected.txt: Removed.
- platform/mac-mountainlion/svg/custom/use-recursion-3-expected.txt: Removed.
- platform/mac-mountainlion/svg/custom/use-recursion-4-expected.txt: Removed.
- platform/mac-mountainlion/svg/hixie/error/017-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Removed.
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png: Removed.
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png: Removed.
- platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png: Removed.
- platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt: Removed.
- platform/mac/svg/custom/use-recursion-1-expected.png: Removed.
- platform/mac/svg/custom/use-recursion-1-expected.txt: Removed.
- platform/mac/svg/custom/use-recursion-2-expected.png: Removed.
- platform/mac/svg/custom/use-recursion-2-expected.txt: Removed.
- platform/mac/svg/custom/use-recursion-3-expected.png: Removed.
- platform/mac/svg/custom/use-recursion-3-expected.txt: Removed.
- platform/mac/svg/custom/use-recursion-4-expected.png: Removed.
- platform/mac/svg/custom/use-recursion-4-expected.txt: Removed.
- platform/mac/svg/hixie/error/017-expected.png: Removed.
- platform/mac/svg/hixie/error/017-expected.txt: Removed.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.svg: Added. Made this be a reference test,
and made it expect more of the recursion to work.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.svg: Added. More of the same.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.svg: Added. More of the same.
- svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
- svg/custom/use-on-disallowed-foreign-object-3-expected.svg: Added. More of the same.
- svg/custom/use-recursion-1-expected.svg: Added. More of the same.
- svg/custom/use-recursion-2-expected.svg: Added. More of the same.
- svg/custom/use-recursion-3-expected.svg: Added. More of the same.
- svg/custom/use-recursion-4-expected.svg: Added. More of the same.
- svg/hixie/error/017-expected.txt: Removed.
- svg/hixie/error/017-expected.xml: Added. More of the same.
- svg/in-html/defs-after-use.html: Updated incorrect bug number in this test.
- 3:21 PM Changeset in webkit [179806] by
-
- 3 edits in trunk/LayoutTests
Skip fast/parser/document-open-in-unload.html on all WK2 platforms
Tracked by:
[WK2] fast/parser/document-open-in-unload.html makes the following test crash
<http://webkit.org/b/98345>
- platform/mac-wk2/TestExpectations: Move Skip expectation from here...
- platform/wk2/TestExpectations: ...to here with updated bug number.
- 3:20 PM Changeset in webkit [179805] by
-
- 2 edits in trunk/LayoutTests
Update section headers for mac-wk2/TestExpectations
- platform/mac-wk2/TestExpectations:
- 2:06 PM Changeset in webkit [179804] by
-
- 12 edits3 adds in trunk/Source
[WK2] Add logging to validate the network cache efficacy (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=141269
<rdar://problem/19632080>
Reviewed by Antti Koivisto.
Source/WebCore:
Export an extra symbol.
- WebCore.exp.in:
Source/WebKit2:
Add console logging to validate the network cache efficacy. This will
tell us if how the network cache satisties requests, in particular:
- Request cannot be handled by the cache
- Entry was not in the cache but is no longer there (pruned)
- Entry is in the cache but is not usable
- Entry is in the cache and is used.
This patch introduces a SQLite-based network cache statistics storage
that is used to store requests we have seen before, and query if we
have seen a request before. The storage is lightweight as it only
stores hashes in the database, in a background thread.
The statistics cache is initially bootstapped from the network disk
cache so that we have data initially and get as accurate statistics
as possible from the start.
To maintain an acceptable level of performance, we have a hard limit
on the number of unique requests that are retained set to 100000.
Diagnostic logging for this will be added in a follow-up patch.
- 12:22 PM Changeset in webkit [179803] by
-
- 2 edits in trunk/LayoutTests
[iOS] Gardening: Some MathML tests crash in RenderMathMLOperator::advanceForGlyph() or boundsForGlyph()
Tracked by: <http://webkit.org/b/141371>
- platform/ios-simulator-wk2/TestExpectations: Mark tests as
crashing.
- 12:22 PM Changeset in webkit [179802] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r179391): Remove references to deleted SVG tests
Fixes the following lint warnings:
--lint-test-files warnings:
LayoutTests/platform/ios-simulator-wk2/TestExpectations:412 Path does not exist. svg/custom/use-elementInstance-event-target.svg
LayoutTests/platform/ios-simulator-wk2/TestExpectations:413 Path does not exist. svg/custom/use-elementInstance-methods.svg
LayoutTests/platform/ios-simulator-wk2/TestExpectations:417 Path does not exist. svg/custom/use-instanceRoot-event-listeners.xhtml
- platform/ios-simulator-wk2/TestExpectations: Remove deleted
tests.
- 12:00 PM Changeset in webkit [179801] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Removing an accidentally committed ChangeLog.
- 11:46 AM TestExpectations edited by
- Fix new-run-webkit-tests to just run-webkit-tests. (diff)
- 11:33 AM Changeset in webkit [179800] by
-
- 1 edit1 add in trunk/LayoutTests
AX: The input element with type="search" has no default focus outline
https://bugs.webkit.org/show_bug.cgi?id=140326
Adding results for Mavericks.
- platform/mac-mavericks/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.
- 11:17 AM Changeset in webkit [179799] by
-
- 2 edits in trunk/LayoutTests
http/tests/security/appcache-in-private-browsing.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=141370
- TestExpectations: Marking as such.
- 11:11 AM Changeset in webkit [179798] by
-
- 3 edits in trunk/LayoutTests
Application cache abort() tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=87633
Moved expectations form Efl to root TestExpectations file. Also, removed Crash
expectation, as no bot hits that now.
Removed an erroneously added expectation for abort-cache-onchecking-resource-404.html -
this test doesn't happen to fail on the bots, although it also doesn't appear to
be very robust.
- TestExpectations:
- platform/efl/TestExpectations:
- 10:47 AM Changeset in webkit [179797] by
-
- 2 edits in trunk/LayoutTests
http/tests/appcache/abort-cache-onchecking-resource-404.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=141368
- TestExpectations: This test is intrinsically unreliable, but at least it checks
that there is no crash is any of the code paths that it takes.
- 12:02 AM Changeset in webkit [179796] by
-
- 3 edits3 adds in trunk
AX: The input element with type="search" has no default focus outline
https://bugs.webkit.org/show_bug.cgi?id=140326
Reviewed by Darin Adler.
Source/WebCore:
The platform RenderTheme takes care of the search field, and that code
was missing a check for whether the element was focused.
Test: fast/css/focus-ring-exists-for-search-field.html
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchField):
LayoutTests:
- fast/css/focus-ring-exists-for-search-field.html: Added.
- platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
- platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.
Feb 7, 2015:
- 11:54 PM Changeset in webkit [179795] by
-
- 2 edits in trunk/Source/WTF
[ARM] GC sometimes stuck in an infinite loop if parallel GC is enabled
https://bugs.webkit.org/show_bug.cgi?id=141290
Reviewed by Anders Carlsson.
- wtf/Platform.h:
- 9:24 PM Changeset in webkit [179794] by
-
- 2 edits in trunk/LayoutTests
fullscreen/full-screen-plugin.html is very flaky on Yosemite WK2
https://bugs.webkit.org/show_bug.cgi?id=141364
Reviewed by Zalan Bujtas.
Speculative fix. Make sure that the plug-in has loaded before using it.
- fullscreen/full-screen-plugin.html:
- 7:26 PM Changeset in webkit [179793] by
-
- 3 edits in trunk/Tools
[iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
<http://webkit.org/b/141365>
Reviewed by Daniel Bates.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator): Add unavailable_version_re precompiled regex.
(Simulator._parse_devices): Check for unavailable versions and
ignore them if found when parsing the output of
xcrun simctl list.
- Scripts/webkitpy/xcode/simulator_unittest.py:
(test_unavailable_devices): Add test with output from
xcrun simctl listwith unavailable runtimes that fails before
the fix.
- 6:43 PM Changeset in webkit [179792] by
-
- 7 edits12 adds in trunk
Add some dictionary lookup tests
https://bugs.webkit.org/show_bug.cgi?id=141355
Reviewed by Darin Adler.
Tests: platform/mac/editing/dictionary-lookup/dictionary-lookup-input.html
platform/mac/editing/dictionary-lookup/dictionary-lookup-inside-selection.html
platform/mac/editing/dictionary-lookup/dictionary-lookup-outside-selection.html
platform/mac/editing/dictionary-lookup/dictionary-lookup-rtl.html
platform/mac/editing/dictionary-lookup/dictionary-lookup.html
- WebCore.exp.in:
Remove an unneeded export.
- editing/mac/DictionaryLookup.h:
Use OBJC_CLASS instead of @class so that this can be included in pure-C++ files.
- testing/Internals.cpp:
(WebCore::Internals::rangeForDictionaryLookupAtLocation):
- testing/Internals.h:
- testing/Internals.idl:
Expose rangeForDictionaryLookupAtHitTestResult fairly directly to JavaScript.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-expected.txt: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-input-expected.txt: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-input.html: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-inside-selection-expected.txt: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-inside-selection.html: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-outside-selection-expected.txt: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-outside-selection.html: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-rtl-expected.txt: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup-rtl.html: Added.
- platform/mac/editing/dictionary-lookup/dictionary-lookup.html: Added.
- platform/mac/editing/dictionary-lookup/lookup-test.js: Added.
(runTest):
Add tests for various cases that we've had trouble with in the past.
- 6:28 PM Changeset in webkit [179791] by
-
- 23 edits in trunk
Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
https://bugs.webkit.org/show_bug.cgi?id=141321
Reviewed by Darin Adler.
Source/JavaScriptCore:
Use new Vector::removeFirstMatching() / removeAllMatching() methods.
Source/WebCore:
Use new Vector::removeFirstMatching() / removeAllMatching() methods.
Source/WebKit/win:
Use new Vector::removeFirstMatching() / removeAllMatching() methods.
Source/WebKit2:
Use new Vector::removeFirstMatching() / removeAllMatching() methods.
Source/WTF:
Add Vector::removeFirstMatching() / removeAllMatching() methods taking
lambda functions to match the element(s) to remove. This simplifies the
code a bit. Vector::removeAllMatching() is also more efficient than the
manual removal alternative.
- wtf/Vector.h:
Tools:
Use new Vector::removeFirstMatching() / removeAllMatching() methods.
- 5:31 PM Changeset in webkit [179790] by
-
- 1 edit8 deletes in trunk/LayoutTests
Unreviewed gardening.
Remove svg/custom/use-events-crash.svg. It has no value anymore.
See webkit.org/b/141108
- platform/gtk/svg/custom/use-events-crash-expected.png: Removed.
- platform/gtk/svg/custom/use-events-crash-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/custom/use-events-crash-expected.txt: Removed.
- platform/ios-simulator/svg/custom/use-events-crash-expected.txt: Removed.
- platform/mac-mountainlion/svg/custom/use-events-crash-expected.txt: Removed.
- platform/mac/svg/custom/use-events-crash-expected.png: Removed.
- platform/mac/svg/custom/use-events-crash-expected.txt: Removed.
- svg/custom/use-events-crash.svg: Removed.
- 4:53 PM Changeset in webkit [179789] by
-
- 2 edits in trunk/LayoutTests
http/tests/xmlhttprequest/event-listener-gc.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33342
Reviewed by Darin Adler.
This test relies on a zero-delay timer being a lot faster than fetching from network.
Force a layout before starting the test, because otherwise, the layout can significantly
delay the timer (I've seen 50-60 milliseconds being a common delay in debug builds).
Also, changed the resource URL to avoid Apache error log spew.
- http/tests/xmlhttprequest/event-listener-gc.html:
- 4:44 PM Changeset in webkit [179788] by
-
- 4 edits1 add in trunk/Tools
[iOS] Make Simulator class testable
<http://webkit.org/b/141358>
Rubber-stamped by Darin Adler.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.xcode_simctl_list): Move
xcrun simctl list
command to here from Simulator.refresh() in xcode/simulator.py
so that the output of the command can be mocked.
- Scripts/webkitpy/common/system/platforminfo_mock.py:
(MockPlatformInfo.init): Set self.expected_xcode_simctl_list
to None.
(MockPlatformInfo.xcode_simctl_list): Add method that returns
self.expected_xcode_simctl_list expectation.
- Scripts/webkitpy/xcode/simulator.py: Add missing copyright
and license header.
(Simulator.init): Add optional 'host' parameter to make it
possible to pass in a mock object for testing. Set self._host
to 'host' parameter or create Host() object.
(Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
method.
- Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
for current code.
(SimulatorTest):
(SimulatorTest.setUp):
(SimulatorTest._set_expected_xcrun_simctl_list):
(SimulatorTest.test_simulator_device_types):
(test_invalid_device_types_header):
(test_invalid_runtimes_header):
(test_invalid_devices_header):
- 4:32 PM Changeset in webkit [179787] by
-
- 4 edits in trunk/LayoutTests
fast/images/animated-gif-iframe-webkit-transform.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=141323
Reviewed by Alexey Proskuryakov.
Use shouldBecomeEqual() instead of shouldBe() to check for initial test
conditions. This should address the flakiness.
- fast/images/animated-gif-iframe-webkit-transform-expected.txt:
- fast/images/animated-gif-iframe-webkit-transform.html:
- platform/mac/TestExpectations:
- 3:46 PM Changeset in webkit [179786] by
-
- 8 edits1 add in trunk/Source/WebKit2
Add API::HistoryClient and split some things out of API::NavigationClient
https://bugs.webkit.org/show_bug.cgi?id=141264
Reviewed by Darin Adler.
- UIProcess/API/APIHistoryClient.h: Added.
(API::HistoryClient::~HistoryClient):
(API::HistoryClient::didNavigateWithNavigationData):
(API::HistoryClient::didPerformClientRedirect):
(API::HistoryClient::didPerformServerRedirect):
(API::HistoryClient::didUpdateHistoryTitle):
- UIProcess/API/APINavigationClient.h:
(API::NavigationClient::didNavigateWithNavigationData): Deleted.
(API::NavigationClient::didPerformClientRedirect): Deleted.
(API::NavigationClient::didPerformServerRedirect): Deleted.
(API::NavigationClient::didUpdateHistoryTitle): Deleted.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::createHistoryClient):
(WebKit::NavigationState::HistoryClient::HistoryClient):
(WebKit::NavigationState::HistoryClient::~HistoryClient):
(WebKit::NavigationState::HistoryClient::didNavigateWithNavigationData):
(WebKit::NavigationState::HistoryClient::didPerformClientRedirect):
(WebKit::NavigationState::HistoryClient::didPerformServerRedirect):
(WebKit::NavigationState::HistoryClient::didUpdateHistoryTitle):
(WebKit::NavigationState::NavigationClient::didNavigateWithNavigationData): Deleted.
(WebKit::NavigationState::NavigationClient::didPerformClientRedirect): Deleted.
(WebKit::NavigationState::NavigationClient::didPerformServerRedirect): Deleted.
(WebKit::NavigationState::NavigationClient::didUpdateHistoryTitle): Deleted.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setHistoryClient):
(WebKit::WebPageProxy::didNavigateWithNavigationData):
(WebKit::WebPageProxy::didPerformClientRedirect):
(WebKit::WebPageProxy::didPerformServerRedirect):
(WebKit::WebPageProxy::didUpdateHistoryTitle):
- UIProcess/WebPageProxy.h:
Add a API::HistoryClient and move the few things that belong on it out of API::NavigationClient.
Adjust accordingly in WebPageProxy and NavigationState.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView setNavigationDelegate:]):
(-[WKWebView setUIDelegate:]):
(-[WKWebView _setHistoryDelegate:]):
Lazily push the NavigationState/UIDelegate clients down to WebPageProxy upon
installation of a delegate, so that alternative (C SPI) delegate setters can
be separately created.
- WebKit2.xcodeproj/project.pbxproj:
- 3:17 PM Changeset in webkit [179785] by
-
- 7 edits2 adds12 deletes in trunk
Source/WebCore:
Stop dispatching events to with SVGElementInstance objects as their targets
https://bugs.webkit.org/show_bug.cgi?id=141108
Reviewed by Anders Carlsson.
Test: svg/custom/use-event-retargeting.html
- dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingTargetRules): Replaced the code that retargeted
events at SVGElementInstance objects with code that retargets them at the use
element instead. Also wrote the code in a simpler way.
LayoutTests:
Stop dispatching events with SVGElementInstance objects as their targets
https://bugs.webkit.org/show_bug.cgi?id=141108
Reviewed by Anders Carlsson.
Many tests are no longer relevant once we aren't doing this any more.
- platform/gtk/svg/custom/use-instanceRoot-event-bubbling-expected.png: Removed.
- platform/gtk/svg/custom/use-instanceRoot-modifications-expected.png: Removed.
- platform/gtk/svg/custom/use-instanceRoot-modifications-expected.txt: Removed.
- platform/ios-sim-deprecated/svg/custom/use-instanceRoot-modifications-expected.txt: Removed.
- platform/ios-simulator/svg/custom/use-instanceRoot-modifications-expected.txt: Removed.
- platform/mac-mountainlion/svg/custom/use-instanceRoot-modifications-expected.txt: Removed.
- platform/mac/svg/custom/use-instanceRoot-event-bubbling-expected.png: Removed.
- platform/mac/svg/custom/use-instanceRoot-modifications-expected.png: Removed.
- platform/mac/svg/custom/use-instanceRoot-modifications-expected.txt: Removed.
- svg/custom/use-instanceRoot-modifications.svg: Removed.
- svg/custom/use-instanceRoot-with-use-removed-expected.txt: Removed.
- svg/custom/use-instanceRoot-with-use-removed.svg: Removed.
- svg/custom/resources/use-instanceRoot-event-bubbling.js: Updated this test to expect
the events to be dispatched with the SVGUseElement as the target. I talked this over with
Sam Weinig and we decided this is good behavior for now, and it almost matches what the
spec says. Might be worth refining later.
- svg/custom/use-instanceRoot-event-bubbling-expected.txt: Updated expected results.
- svg/custom/use-instanceRoot-event-bubbling.xhtml: Tweaked the test a little. It still
could use improvement; it's like half a "repaint test", which is strange.
- svg/custom/use-event-retargeting-expected.txt: Added. Got this test from Blink.
- svg/custom/use-event-retargeting.html: Added. Ditto.
- svg/custom/use-events-crash.svg: Added some more events, a second click, so that we
don't hang with the context menu up when running this. Also converted line endings to
use LF instead of CRLF.
- 2:48 PM Changeset in webkit [179784] by
-
- 6 edits in trunk/Source/WebCore
[Mac] Set -contentsScale on AVPlayerLayer to allow AVPlayer to select the appropriate HLS variant.
https://bugs.webkit.org/show_bug.cgi?id=141354
rdar://problem/19717591
Reviewed by Darin Adler.
AVPlayer will try to determine the correct HLS variant based on the bounds of an AVPlayerLayer.
When not in a layer tree, AVFoundation is not able to determine the correct mapping from logical
units to pixel values. To provide AVPlayer with that scaling value, set -contentsScale based on
both the current device scale and the current page scale.
Since this needs to be set at initialization time, before the AVPlayer is has any AVPlayerItems,
add some plumbing up from MediaPlayer to as the HTMLMediaElement for the appropriate contents
scale.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerContentsScale):
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerContentsScale):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateContentsScale):
- 12:21 PM Changeset in webkit [179783] by
-
- 2 edits in trunk/Source/WebCore
ASan complains about plugins/snapshotting/snapshot-plugin-not-quite-blocked-by-image.html
https://bugs.webkit.org/show_bug.cgi?id=141352
rdar://problem/19717490
Reviewed by Anders Carlsson.
- dom/Document.cpp: (WebCore::Document::ensurePlugInsInjectedScript): This string
is not null terminated.
- 11:50 AM Changeset in webkit [179782] by
-
- 2 edits in trunk/Source/WebKit2
And as a further followup restore the 8bit test too.
- NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::hashString):
- 11:45 AM Changeset in webkit [179781] by
-
- 4 edits in trunk/Source/WebKit2
Use longer hashes for cache keys
https://bugs.webkit.org/show_bug.cgi?id=141356
Rubber-stamped by Darin Adler.
Folloup and build fix.
- NetworkProcess/cache/NetworkCacheCoders.h:
- NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::hashString):
Use containsOnlyASCII instead of is8Bit so both paths always compute the same hash.
- NetworkProcess/cache/NetworkCacheKey.h:
- 11:19 AM Changeset in webkit [179780] by
-
- 2 edits in trunk/Source/WebKit2
Remove a printf.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::retrieve):
- 11:18 AM Changeset in webkit [179779] by
-
- 8 edits in trunk/Source/WebKit2
Use longer hashes for cache keys
https://bugs.webkit.org/show_bug.cgi?id=141356
Reviewed by Darin Adler.
The current key hashes are 32bit. We should use longer hashes to eliminate collisions.
This patch switches us to using MD5 digests for the cache key hashes. As a result the file names for the cache
entries grow from 8 to 32 character.
Note that we don't need a cryptographic hash (full cache keys are verified against the entries).
MD5 just happens to be fast, convenient and available.
The patch also moves the whole cache hierarchy down to a versioned subdirectory ("WebKitCache/Version 2")
and deletes any old style cache files if they exist.
- NetworkProcess/cache/NetworkCacheCoders.cpp:
(WebKit::NetworkCacheCoder<MD5::Digest>::encode):
(WebKit::NetworkCacheCoder<MD5::Digest>::decode):
- NetworkProcess/cache/NetworkCacheCoders.h:
- NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCacheKey::NetworkCacheKey):
(WebKit::hashString):
(WebKit::NetworkCacheKey::computeHash):
(WebKit::NetworkCacheKey::hashAsString):
(WebKit::NetworkCacheKey::stringToHash):
- NetworkProcess/cache/NetworkCacheKey.h:
(WebKit::NetworkCacheKey::shortHash):
(WebKit::NetworkCacheKey::toShortHash):
32bit hash to use in the bloom filter.
(WebKit::NetworkCacheKey::hashStringLength):
- NetworkProcess/cache/NetworkCacheStorage.h:
Bump the version.
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::traverseCacheFiles):
(WebKit::makeVersionedDirectoryPath):
(WebKit::NetworkCacheStorage::NetworkCacheStorage):
(WebKit::NetworkCacheStorage::initialize):
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::retrieve):
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::update):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
(WebKit::NetworkCacheStorage::deleteOldVersions):
Wipe out the version 1 cache.
- 9:01 AM Changeset in webkit [179778] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests --remote should use the default ssh port
https://bugs.webkit.org/show_bug.cgi?id=141287
Reviewed by Darin Adler.
- Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
- 12:32 AM Changeset in webkit [179777] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (OS X 10.10.2): http/tests/media/video-query-url.html frequently times out
https://bugs.webkit.org/show_bug.cgi?id=141085
- platform/mac-wk2/TestExpectations: Added an expectation.
Feb 6, 2015:
- 8:35 PM Changeset in webkit [179776] by
-
- 3 edits2 adds in trunk
ASSERT repaintContainer->hasLayer() in WebCore::RenderObject::repaintUsingContainer
https://bugs.webkit.org/show_bug.cgi?id=140750
Reviewed by Simon Fraser.
There's a short period of time when RenderObject::layer() still returns a valid pointer
even though we already cleared the hasLayer() flag.
Do not use the layer as repaint container in such cases.
Source/WebCore:
Test: compositing/repaint-container-assertion-when-toggling-compositing.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::enclosingLayer):
LayoutTests:
- compositing/repaint-container-assertion-when-toggling-compositing-expected.txt: Added.
- compositing/repaint-container-assertion-when-toggling-compositing.html: Added.
- 8:35 PM Changeset in webkit [179775] by
-
- 2 edits in trunk/Tools
dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
https://bugs.webkit.org/show_bug.cgi?id=141349
Reviewed by Alexey Proskuryakov.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update):
- 7:06 PM Changeset in webkit [179774] by
-
- 5 edits in trunk/Source
Have SQLiteStatement::database() return a reference
https://bugs.webkit.org/show_bug.cgi?id=141348
Reviewed by Andreas Kling.
Have SQLiteStatement::database() return a reference as it can never
return null.
Source/WebCore:
- loader/icon/IconDatabase.cpp:
(WebCore::readySQLiteStatement):
- platform/sql/SQLiteStatement.h:
(WebCore::SQLiteStatement::database):
Source/WebKit2:
- DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:
(WebKit::SQLiteIDBCursor::internalAdvanceOnce):
- 5:38 PM Changeset in webkit [179773] by
-
- 2 edits in trunk/Source/WebCore
Add youtube-nocookie URL to isYouTubeURL predicate
https://bugs.webkit.org/show_bug.cgi?id=141347
<rdar://problem/19430657>
Reviewed by Eric Carlson.
- Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::isYouTubeURL): Update for additional youtube-nocookie site.
- 5:24 PM Changeset in webkit [179772] by
-
- 5 edits2 adds in trunk
- 5:11 PM Changeset in webkit [179771] by
-
- 4 edits2 adds in trunk
Convert the compositing overlap map to use LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=141346
Source/WebCore:
rdar://problem/18206365
Reviewed by Zalan Bujtas.
If two compositing layers were adjoining but not overlapping, but happened to
have non-integral offsets, then using enclosing IntRects in the overlap map
would cause us to think they are overlapping, and create unnecessary backing store.
Fix by converting the overlap map to use LayoutRects.
Test: compositing/layer-creation/subpixel-adjacent-layers-overlap.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::OverlapMapContainer::add):
(WebCore::OverlapMapContainer::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::add):
(WebCore::RenderLayerCompositor::OverlapMap::overlapsLayers):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::append):
(WebCore::RenderLayerCompositor::OverlapMap::RectList::intersects):
(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Reviewed by Zalan Bujtas.
Test with adjacent layers on non-pixel boundaries.
- compositing/layer-creation/subpixel-adjacent-layers-overlap-expected.txt: Added.
- compositing/layer-creation/subpixel-adjacent-layers-overlap.html: Added.
- 5:08 PM Changeset in webkit [179770] by
-
- 31 edits in trunk/Source
Ref-ify various getters that return HTMLCollection.
<https://webkit.org/b/141336>
Reviewed by Anders Carlsson.
Make all the getters that return HTMLCollection objects (and never return nullptr)
return Ref instead of RefPtr.
Removed a couple of useless null checks that were exposed by this change.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
- dom/Document.cpp:
(WebCore::Document::ensureCachedCollection):
(WebCore::Document::images):
(WebCore::Document::applets):
(WebCore::Document::embeds):
(WebCore::Document::plugins):
(WebCore::Document::scripts):
(WebCore::Document::links):
(WebCore::Document::forms):
(WebCore::Document::anchors):
(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):
(WebCore::Document::iconURLs):
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::ensureCachedHTMLCollection):
- dom/Element.h:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::suggestions):
- html/HTMLDataListElement.cpp:
(WebCore::HTMLDataListElement::options):
- html/HTMLDataListElement.h:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::children):
- html/HTMLElement.h:
- html/HTMLFieldSetElement.cpp:
(WebCore::HTMLFieldSetElement::elements):
- html/HTMLFieldSetElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elements):
- html/HTMLFormElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):
- html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::areas):
- html/HTMLMapElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectedOptions):
(WebCore::HTMLSelectElement::options):
- html/HTMLSelectElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::rows):
(WebCore::HTMLTableElement::tBodies):
- html/HTMLTableElement.h:
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::insertCell):
(WebCore::HTMLTableRowElement::deleteCell):
(WebCore::HTMLTableRowElement::cells):
- html/HTMLTableRowElement.h:
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::insertRow):
(WebCore::HTMLTableSectionElement::deleteRow):
(WebCore::HTMLTableSectionElement::rows):
- html/HTMLTableSectionElement.h:
- html/RangeInputType.cpp:
(WebCore::RangeInputType::updateTickMarkValues):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
- 4:45 PM Changeset in webkit [179769] by
-
- 1 copy in tags/Safari-600.4.7
New tag.
- 4:39 PM Changeset in webkit [179768] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Implement audio track selection in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=131236
<rdar://problem/16552632>
Reviewed by Eric Carlson.
- platform/ios/WebVideoFullscreenModelVideoElement.h:
- platform/ios/WebVideoFullscreenModelVideoElement.mm:
(WebVideoFullscreenModelVideoElement::selectAudioMediaOption): Provide implementation.
(WebVideoFullscreenModelVideoElement::updateLegibleOptions): Add audio track information
to menu displayed to user.
- 3:37 PM Changeset in webkit [179767] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG SSA shouldn't have SetArgument nodes
https://bugs.webkit.org/show_bug.cgi?id=141342
Reviewed by Mark Lam.
I was wondering why we kept the SetArgument around for captured
variables. It turns out we did so because we thought we had to, even
though we didn't have to. The node is meaningless in SSA.
- dfg/DFGSSAConversionPhase.cpp:
(JSC::DFG::SSAConversionPhase::run):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
- 3:31 PM Changeset in webkit [179766] by
-
- 2 edits in trunk/Websites/perf.webkit.org
The delta value in the chart pane sometimes doens't show '+' for a positive delta
https://bugs.webkit.org/show_bug.cgi?id=141340
Reviewed by Andreas Kling.
The bug was caused by computeStatus prefixing the value delta with '+' if it's greater than 0 after
it had already been formatted. Fixed the bug by using a formatter that always emits a sign symbol.
- public/v2/app.js:
(App.Pane.computeStatus):
(App.createChartData):
- 2:55 PM Changeset in webkit [179765] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed build fix. currentPoint wasn't defined when selectedPoints was used to find points.
- public/v2/app.js:
(App.PaneController._updateDetails):
- 2:47 PM Changeset in webkit [179764] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed. Commit the forgotten change.
- public/include/manifest.php:
- 2:43 PM Changeset in webkit [179763] by
-
- 8 edits in trunk/Websites/perf.webkit.org
New perf dashboard should have multiple dashboard pages
https://bugs.webkit.org/show_bug.cgi?id=141339
Reviewed by Chris Dumez.
Added the support for multiple dashboard pages. Also added the status of the latest data point.
e.g. "5% better than target"
- public/v2/app.css: Tweaked the styles to work around the fact Ember.js creates empty script elements.
Also hid the border lines around charts on the dashboard page for a cleaner look.
- public/v2/app.js:
(App.IndexRoute): Added. Navigate to /dashboard/<defaultDashboardName> once the manifest.json is loaded.
(App.IndexRoute.beforeModel): Added.
(App.DashboardRoute): Added.
(App.DashboardRoute.model): Added. Return the dashboard specified by the name.
(App.CustomDashboardRoute): Added. This route is used for a customized dashboard specified by "grid".
(App.CustomDashboardRoute.model): Create a dashboard model from "grid" query parameter.
(App.CustomDashboardRoute.renderTemplate): Use the dashboard template.
(App.DashboardController): Renamed from App.IndexController.
(App.DashboardController.modelChanged): Renamed from gridChanged. Removed the code to deal with "grid"
and "defaultDashboard" as these are taken care of by newly added routers.
(App.DashboardController.computeGrid): Renamed from updateGrid. No longer updates "grid" since this is
now done in actions.toggleEditMode.
(App.DashboardController.actions.toggleEditMode): Navigate to CustomDashboardRoute when start editing
an existing dashboard.
(App.Pane.computeStatus): Moved from App.PaneController so that to be called in App.Pane.latestStatus.
Also moved the code to compute the delta with respect to the previous data point from _updateDetails.
(App.Pane._relativeDifferentToLaterPointInTimeSeries): Ditto.
(App.Pane.latestStatus): Added. Used by the dashboard template to show the status of the latest result.
(App.createChartData): Added deltaFormatter to show less significant digits for differences.
(App.PaneController._updateDetails): Updated per changes to computeStatus.
- public/v2/chart-pane.css: Added style rules for the status labels on the dashboard.
- public/v2/data.js:
(TimeSeries.prototype.lastPoint): Added.
- public/v2/index.html: Prefetch manifest.json as soon as possible, show the latest data points' status
on the dashboard, and enumerate all predefined dashboards.
- public/v2/interactive-chart.js:
(App.InteractiveChartComponent._relayoutDataAndAxes): Slightly adjust the offset at which we show unit
for the dashboard page.
- public/v2/manifest.js:
(App.Dashboard): Inherit from App.NameLabelModel now that each predefined dashboard has a name.
(App.MetricSerializer.normalizePayload): Parse all predefined dashboards instead of a single dashboard.
IDs are generated for each dashboard for forward compatibility.
(App.Manifest):
(App.Manifest.dashboardByName): Added.
(App.Manifest.defaultDashboardName): Added.
(App.Manifest._fetchedManifest): Create dashboard model objects for all predefined ones.
- 2:14 PM Changeset in webkit [179762] by
-
- 8 edits1 copy1 add in trunk
[MSE] Implement Append Error algorithm.
https://bugs.webkit.org/show_bug.cgi?id=139439
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2015-02-06
Reviewed by Jer Noble.
If Source Buffer has not received first init segment, then it shall call endOfStream after receiving
Media Segment, as per Media Source spec. (from 17 July 2014) in paragraph 3.5.1 point 6.1.
Source/WebCore:
Based this change on Editor's Draft 12 December 2014, as it clarifies order of events.
Test: media/media-source/media-source-append-media-segment-without-init.html
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::streamEndedWithError):
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::validateInitializationSegment):
(WebCore::SourceBuffer::appendError):
- Modules/mediasource/SourceBuffer.h:
LayoutTests:
Added test which after creating SourceBuffer sends media sample, without any init segments.
Updated existing tests, so they correctly expect updateend and error as per Append Error algorithm.
- media/media-source/media-source-append-failed-expected.txt:
- media/media-source/media-source-append-failed.html:
- media/media-source/media-source-append-media-segment-without-init-expected.txt: Added.
- media/media-source/media-source-append-media-segment-without-init.html: Added.
- media/media-source/media-source-multiple-initialization-segments-expected.txt:
- media/media-source/media-source-multiple-initialization-segments.html:
- 2:08 PM Changeset in webkit [179761] by
-
- 3 edits in branches/safari-600.5-branch/Source/WebCore
Merged r179758. rdar://problem/19738407
- 2:05 PM Changeset in webkit [179760] by
-
- 3 edits in branches/safari-600.4-branch/Source/WebCore
Merged r179758. rdar://problem/19738407
- 2:01 PM Changeset in webkit [179759] by
-
- 5 edits in branches/safari-600.4-branch/Source
Versioning.
- 1:54 PM Changeset in webkit [179758] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION: Lookup doesn't work in RTL
https://bugs.webkit.org/show_bug.cgi?id=141338
<rdar://problem/19738407>
Reviewed by Dan Bernstein.
- editing/Editor.cpp:
(WebCore::Editor::scanSelectionForTelephoneNumbers):
- editing/mac/DictionaryLookup.mm:
(WebCore::rangeExpandedAroundPositionByCharacters):
Positions are independent of writing direction, so we don't
need to (and shouldn't) do anything special for RTL here.
- 1:48 PM Changeset in webkit [179757] by
-
- 2 edits in trunk/LayoutTests
Correct expectations for inspector/css/selector-dynamic-specificity.html.
"Slow Pass Timeout" is not currently valid - if we expect a flaky timeout, we need
to expect it within the regular period of time with "Pass Timeout".
- platform/mac-wk2/TestExpectations:
- 1:39 PM Changeset in webkit [179756] by
-
- 2 edits in trunk/Source/JavaScriptCore
It should be possible to use the DFG SetArgument node to indicate that someone set the value of a local out-of-band
https://bugs.webkit.org/show_bug.cgi?id=141337
Reviewed by Mark Lam.
This mainly involved ensuring that SetArgument behaves just like SetLocal from a CPS standpoint, but with a special case for those SetArguments that
are associated with the prologue.
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSet):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::specialCaseArguments):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetLocal): Deleted.
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument): Deleted.
- 1:33 PM Changeset in webkit [179755] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: CSS Resource appears as empty after editing it via Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=140586
Reviewed by Timothy Hatcher.
Update SourceCode#_processContent to properly handle the promise returned from CSSAgent so that the content
will properly update when a style has changed. Properly clear the existing _requestContentPromise on the
stylesheet so that the content will update correctly.
- UserInterface/Controllers/CSSStyleManager.js: Drive-by style updates.
(WebInspector.CSSStyleManager.prototype._fetchInfoForAllStyleSheets):
- UserInterface/Models/CSSStyleSheet.js: Drive-by inheritance style update.
(WebInspector.CSSStyleSheet.prototype.requestContentFromBackend): Remove unnecessary backend promise function call.
- UserInterface/Models/Resource.js: Drive-by removal of unused variable.
- UserInterface/Models/SourceCode.js:
(WebInspector.SourceCode.prototype.markContentAsStale): Clear _requestContentPromise.
(WebInspector.SourceCode.prototype._processContent): Handleparameters.textcorrectly.
- 1:21 PM Changeset in webkit [179754] by
-
- 8 edits in trunk
Report network process crashes during layout tests
https://bugs.webkit.org/show_bug.cgi?id=139646
Reviewed by Anders Carlsson.
Source/WebKit2:
Added a way to get network process pid, modeled after how we do this for web process.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextGetNetworkProcessIdentifier):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::networkProcessCrashed): Don't reset m_networkProcess until
after calling the client, so that the client could retrieve its pid.
(WebKit::WebProcessPool::networkProcessIdentifier):
- UIProcess/WebProcessPool.h:
Tools:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::networkProcessName):
(WTR::TestController::networkProcessDidCrash):
- WebKitTestRunner/TestController.h:
- 12:57 PM Changeset in webkit [179753] by
-
- 6 edits in trunk/Source/JavaScriptCore
MachineThreads should be ref counted.
<https://webkit.org/b/141317>
Reviewed by Filip Pizlo.
The VM's MachineThreads registry object is being referenced from other
threads as a raw pointer. In a scenario where the VM is destructed on
the main thread, there is no guarantee that another thread isn't still
holding a reference to the registry and will eventually invoke
removeThread() on it on thread exit. Hence, there's a possible use
after free scenario here.
The fix is to make MachineThreads ThreadSafeRefCounted, and have all
threads that references keep a RefPtr to it to ensure that it stays
alive until the very last thread is done with it.
- API/tests/testapi.mm:
(useVMFromOtherThread): - Renamed to be more descriptive.
(useVMFromOtherThreadAndOutliveVM):
- Added a test that has another thread which uses the VM outlive the VM to confirm that there is no crash.
However, I was not actually able to get the VM to crash without this
patch because I wasn't always able to the thread destructor to be
called. With this patch applied, I did verify with some logging that
the MachineThreads registry is only destructed after all threads
have removed themselves from it.
(threadMain): Deleted.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::gatherStackRoots):
- heap/Heap.h:
(JSC::Heap::machineThreads):
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeCurrentThread):
- heap/MachineStackMarker.h:
- 12:46 PM Changeset in webkit [179752] by
-
- 5 edits in trunk/Source/WebKit2
Support overriding the deviceScaleFactor per WKWebView/WKView
https://bugs.webkit.org/show_bug.cgi?id=141311
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKViewPrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setOverrideDeviceScaleFactor:]):
(-[WKWebView _overrideDeviceScaleFactor]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/API/mac/WKView.mm:
(-[WKView _intrinsicDeviceScaleFactor]):
(-[WKView _setOverrideDeviceScaleFactor:]):
(-[WKView _overrideDeviceScaleFactor]):
- 12:25 PM Changeset in webkit [179751] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r179743.
https://bugs.webkit.org/show_bug.cgi?id=141335
caused missing symbols in non-WebKit clients of WTF::Vector
(Requested by kling on #webkit).
Reverted changeset:
"Remove WTF::fastMallocGoodSize()."
https://bugs.webkit.org/show_bug.cgi?id=141020
http://trac.webkit.org/changeset/179743
- 10:56 AM Changeset in webkit [179750] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r179706): Caused memory corruption on some tests (Requested by _ap_ on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=141324
Reviewed by Alexey Proskuryakov.
No new tests. This is caught by existing tests under ASAN, and I don't know how to reproduce
it without ASAN.
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): Give up
and just always invalidate the next line. It's too hard to come up
with the condition that catches all needed cases, doesn't itself
cause a crash, and isn't overzealous. And we do this for the
previous line anyway. Also clean up the code a bit since it
confusingly reuses a variable, and declares it uninitialized, for
no good reason.
- 10:50 AM Changeset in webkit [179749] by
-
- 3 edits in trunk/LayoutTests
http/tests/xmlhttprequest/event-listener-gc.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33342
Tweaked test output a little, hopefully this will shed some light on what happens in failure case.
- http/tests/xmlhttprequest/event-listener-gc-expected.txt:
- http/tests/xmlhttprequest/event-listener-gc.html:
- 9:58 AM Changeset in webkit [179748] by
-
- 14 edits in branches/safari-600.5-branch
Rollout r179133. rdar://problem/19526158
- 8:27 AM Changeset in webkit [179747] by
-
- 2 edits in trunk/Tools
run-jsc-stress-tests --remote should create remote directory before copying the bundle
https://bugs.webkit.org/show_bug.cgi?id=141329
Reviewed by Michael Saboff.
- Scripts/run-jsc-stress-tests:
- 8:04 AM Changeset in webkit [179746] by
-
- 4 edits in trunk/Source/JavaScriptCore
Remove BytecodeGenerator::preserveLastVar() and replace it with a more robust mechanism for preserving non-temporary registers
https://bugs.webkit.org/show_bug.cgi?id=141211
Reviewed by Mark Lam.
Previously, the way non-temporary registers were preserved (i.e. not reclaimed anytime
we did newTemporary()) by calling preserveLastVar() after all non-temps are created. It
would raise the refcount on the last (highest-numbered) variable created, and rely on
the fact that register reclamation started at higher-numbered registers and worked its
way down. So any retained register would block any lower-numbered registers from being
reclaimed.
Also, preserveLastVar() sets a thing called m_firstConstantIndex. It's unused.
This removes preserveLastVar() and makes addVar() retain each register it creates. This
is more explicit, since addVar() is the mechanism for creating non-temporary registers.
To make this work I had to remove an assertion that Register::setIndex() can only be
called when the refcount is zero. This method might be called after a var is created to
change its index. This previously worked because preserveLastVar() would be called after
we had already made all index changes, so the vars would still have refcount zero. Now
they have refcount 1. I think it's OK to lose this assertion; I can't remember this
assertion ever firing in a way that alerted me to a serious issue.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::preserveLastVar): Deleted.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::addVar):
- bytecompiler/RegisterID.h:
(JSC::RegisterID::setIndex):
- 6:50 AM Changeset in webkit [179745] by
-
- 11 edits in trunk
[GTK] Remove WebKitWebView::close-notification signal
https://bugs.webkit.org/show_bug.cgi?id=141330
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
In favor of a WebKitNotification::closed signal and
webkit_notification_close() method that both applications and
WebKit can use to close a notification. This also fixes the
onclose event that was not fired when the notification was
closed. It also brings back padding space in WebKitWebViewClass.
- UIProcess/API/gtk/WebKitNotification.cpp:
(webkit_notification_class_init): Add WebKitNotification::closed signal.
(webkit_notification_close): Emit WebKitNotification::closed.
- UIProcess/API/gtk/WebKitNotification.h:
- UIProcess/API/gtk/WebKitNotificationProvider.cpp:
(WebKitNotificationProvider::notificationCloseCallback): Callback
for WebKitNotification::closed signal that notifies the WebProcess
and removes the notification from the map.
(WebKitNotificationProvider::show): Connect to WebKitNotification::closed.
(WebKitNotificationProvider::cancelNotificationByID): Call webkit_notification_close().
- UIProcess/API/gtk/WebKitNotificationProvider.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(notifyNotificationClosed): The user closed the annotation, call
webkit_notification_close().
(webNotificationClosed): The WebKitNotification has been closed,
close the libnotify notification if it hasn't been closed yet.
(webkitWebViewShowNotification): Create the libnotifiy
notification if needed and associate it to the WebKitNotification
as user data. Connect to the closed signal of both, the libnotifiy
notification and the WebKit notification.
(webkitWebViewCloseNotification): Deleted.
(webkit_web_view_class_init): Remove close-notification signal and
the default hanlder.
(webkitWebViewEmitCloseNotification): Deleted.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add webkit_notification_close.
Tools:
Update notifications unit tests according to the API changes, and
add a test case to check that onclose event is fired when a
notification is closed by the user.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewNotification):
- 6:46 AM Changeset in webkit [179744] by
-
- 5 edits in trunk/Source/WebKit2
ASSERTION FAILED: !m_adoptionIsRequired in WTF::RefCountedBase::ref
https://bugs.webkit.org/show_bug.cgi?id=141035
Reviewed by Sergio Villar Senin.
Rename PrinterListGtk::singleton() as PrinterListGtk::getOrCreate(), and
make it return nullptr when the shared PrinterListGtk object is
still being created. This can happen if the nested loop used by
gtk_enumerate_printers dispatches a GSource that starts a new
synchronous print operation. In that case we just ignore the
second print operation, since there's already one ongoing.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::print): Return early if
PrinterListGtk::getOrCreate() return nullptr.
- WebProcess/WebPage/gtk/PrinterListGtk.cpp:
(WebKit::PrinterListGtk::getOrCreate): Return nullptr if the
PrinterListGtk is still enumerating the printers.
(WebKit::PrinterListGtk::PrinterListGtk): Initialize
m_enumeratingPrinters to true before calling
gtk_enumerate_printers, and to false once it finishes.
(WebKit::PrinterListGtk::singleton): Deleted.
(WebKit::PrinterListGtk::enumeratePrintersFunction): Deleted.
- WebProcess/WebPage/gtk/PrinterListGtk.h:
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Add an
assertion here since PrinterListGtk::getOrCreate() should never
return nullptr at this point.
- 2:03 AM Changeset in webkit [179743] by
-
- 7 edits in trunk/Source
Remove WTF::fastMallocGoodSize().
<https://webkit.org/b/141020>
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
- assembler/AssemblerBuffer.h:
(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerData::grow):
Source/WTF:
bmalloc's good-size API just returns exactly whatever you pass it,
so it's of no utility to us anymore.
This gets rid of a bunch of pointless out-of-line calls in Vector
construction and growth.
- wtf/Compression.cpp:
(WTF::GenericCompressedData::create):
- wtf/FastMalloc.cpp:
(WTF::fastMallocGoodSize): Deleted.
- wtf/FastMalloc.h:
- wtf/Vector.h:
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
- 12:31 AM Changeset in webkit [179742] by
-
- 2 edits in trunk/LayoutTests
http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=141325
- platform/mac-wk2/TestExpectations: Mark it as such.
- 12:14 AM Changeset in webkit [179741] by
-
- 2 edits in trunk/LayoutTests
inspector/css/selector-dynamic-specificity.html is very slow on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=141252
- platform/mac-wk2/TestExpectations: Add weaker expectations for debug builds.
Feb 5, 2015:
- 8:32 PM Changeset in webkit [179740] by
-
- 4 edits in trunk/LayoutTests
Test gardening for issues uncovered by disabling retries on debug bots.
- TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 8:07 PM Changeset in webkit [179739] by
-
- 2 edits in trunk/Source/WebCore
Remove duplicate loop after r179532
https://bugs.webkit.org/show_bug.cgi?id=141300
Reviewed by Benjamin Poulain.
No new tests, no behavior changed.
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesLangPseudoClass):
- 7:55 PM Changeset in webkit [179738] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r179725.
https://bugs.webkit.org/show_bug.cgi?id=141320
caused 2 layout tests to fail (Requested by zalan on #webkit).
Reverted changeset:
"[MSE] Implement Append Error algorithm."
https://bugs.webkit.org/show_bug.cgi?id=139439
http://trac.webkit.org/changeset/179725
- 7:14 PM Changeset in webkit [179737] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Run a full garbage collection on memory warning.
<https://webkit.org/b/141313>
<rdar://problem/19738024>
Reviewed by Chris Dumez.
Make sure that we run a full GC when trying to free up memory, as this might
be our last chance to execute before the kernel suspends this process.
This aligns WebKit2 with the old WebKit1 behavior.
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformReleaseMemory):
- 6:21 PM Changeset in webkit [179736] by
-
- 2 edits in trunk/Source/WebKit2
Null deref in ViewGestureController::beginSwipeGesture when swiping while script is navigating
https://bugs.webkit.org/show_bug.cgi?id=141308
<rdar://problem/18460046>
Reviewed by Simon Fraser.
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::trackSwipeGesture):
If script navigates (history.back, probably other cases too) while in the middle of
building up enough scroll events to start a swipe, it can destroy the history item
that we were planning to swipe to. If this happens, bail from the swipe.
- 6:04 PM Changeset in webkit [179735] by
-
- 5 edits2 copies in branches/safari-600.1.4.15-branch
Merged r179567. rdar://problem/19432892
- 5:40 PM Changeset in webkit [179734] by
-
- 12 edits in branches/safari-600.1.4.15-branch
Merge patch from rdar://problem/19432653.
- 5:34 PM Changeset in webkit [179733] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Unskip 4 passing tests regarding webgl.
Those tests were marked with *CRASH* on r179465 though, it looks
wrong.
- platform/efl/TestExpectations:
- 5:24 PM Changeset in webkit [179732] by
-
- 3 edits in trunk/Source/WebKit2
Don't pass architecture to development plug-in XPC services
https://bugs.webkit.org/show_bug.cgi?id=141309
Reviewed by Anders Carlsson.
We now have separate services for 32-bit and 64-bit.
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::reexec):
(WebKit::XPCServiceEventHandler):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToReExecService):
- 5:23 PM Changeset in webkit [179731] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Move commits viewer to the end of details view
https://bugs.webkit.org/show_bug.cgi?id=141315
Rubber-stamped by Andreas Kling.
Show the difference instead of the old value per kling's request.
- public/v2/app.js:
(App.PaneController._updateDetails):
- public/v2/index.html:
- 5:15 PM Changeset in webkit [179730] by
-
- 5 edits2 deletes in branches/safari-600.1.4.15-branch
Rollout r179711 (179657 on trunk).
- 5:14 PM Changeset in webkit [179729] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Move commits viewer to the end of details view
https://bugs.webkit.org/show_bug.cgi?id=141315
Reviewed by Andreas Kling.
Improved the way list of commits are shown per kling's request.
- public/v2/app.js:
(App.PaneController._updateDetails): Always show the old value even when a single point is selected.
- public/v2/chart-pane.css: Updated the style for the commits viewer.
- public/v2/commits-viewer.js:
(App.CommitsViewerComponent): Added "visible" property to hide the list of commits.
(App.CommitsViewerComponent.actions.toggleVisibility): Added. Toggles "visible" property.
- public/v2/index.html: Updated the template for commits viewer to support "visible" property. Also
moved the commits viewers out of the details tables so that they don't interleave revision data.
- 5:12 PM Changeset in webkit [179728] by
-
- 15 edits1 delete in trunk/Source/JavaScriptCore
CodeCache is not thread safe when adding the same source from two different threads
https://bugs.webkit.org/show_bug.cgi?id=141275
Reviewed by Mark Lam.
The issue for this bug is that one thread, takes a cache miss in CodeCache::getGlobalCodeBlock,
but in the process creates a cache entry with a nullptr UnlinkedCodeBlockType* which it
will fill in later in the function. During the body of that function, it allocates
objects that may garbage collect. During that garbage collection, we drop the all locks.
While the locks are released by the first thread, another thread can enter the VM and might
have exactly the same source and enter CodeCache::getGlobalCodeBlock() itself. When it
looks up the code block, it sees it as a cache it and uses the nullptr UnlinkedCodeBlockType*
and crashes. This fixes the problem by not dropping the locks during garbage collection.
There are other likely scenarios where we have a data structure like this code cache in an
unsafe state for arbitrary reentrance.
Moved the functionality of DelayedReleaseScope directly into Heap. Changed it into
a simple list that is cleared with the new function Heap::releaseDelayedReleasedObjects.
Now we accumulate objects to be released and release them when all locks are dropped or
when destroying the Heap. This eliminated the dropping and reaquiring of locks associated
with the old scope form of this list.
Given that all functionality of DelayedReleaseScope is now used and referenced by Heap
and the lock management no longer needs to be done, just made the list a member of Heap.
We do need to guard against the case that releasing an object can create more objects
by calling into JS. That is why releaseDelayedReleasedObjects() is written to remove
an object to release so that we aren't recursively in Vector code. The other thing we
do in releaseDelayedReleasedObjects() is to guard against recursive calls to itself using
the m_delayedReleaseRecursionCount. We only release at the first entry into the function.
This case is already tested by testapi.mm.
- heap/DelayedReleaseScope.h: Removed file
- API/JSAPIWrapperObject.mm:
- API/ObjCCallbackFunction.mm:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryAllocate):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
- heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::lastChanceToFinalize):
(JSC::MarkedSpace::didFinishIterating):
- heap/MarkedSpace.h:
- heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
(JSC::Heap::zombifyDeadObjects):
Removed references to DelayedReleaseScope and DelayedReleaseScope.h.
- heap/Heap.cpp:
(JSC::Heap::Heap): Initialized m_delayedReleaseRecursionCount.
(JSC::Heap::lastChanceToFinalize): Call releaseDelayedObjectsNow() as the VM is going away.
(JSC::Heap::releaseDelayedReleasedObjects): New function that released the accumulated
delayed release objects.
- heap/Heap.h:
(JSC::Heap::m_delayedReleaseObjects): List of objects to be released later.
(JSC::Heap::m_delayedReleaseRecursionCount): Counter to indicate that
releaseDelayedReleasedObjects is being called recursively.
- heap/HeapInlines.h:
(JSC::Heap::releaseSoon): Changed location of list to add delayed release objects.
- runtime/JSLock.cpp:
(JSC::JSLock::willReleaseLock):
Call Heap::releaseDelayedObjectsNow() when releasing the lock.
- 5:07 PM Changeset in webkit [179727] by
-
- 2 edits in trunk/Source/WebKit2
Use deleteEmptyDirectory() in NetworkCacheStorage::clear()
https://bugs.webkit.org/show_bug.cgi?id=141314
Reviewed by Antti Koivisto.
Use deleteEmptyDirectory() in NetworkCacheStorage::clear() to simplify
the code a little bit.
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::clear):
- 5:05 PM Changeset in webkit [179726] by
-
- 2 edits in trunk/Source/WebCore
Fix ASSERTION FAILED: !root->needsLayout() in FrameView::layout()
https://bugs.webkit.org/show_bug.cgi?id=141032
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-02-05
Reviewed by Darin Adler.
This patch moves the !root->needsLayout() assert statement above
updateLayerPositionsAfterLayout() that can modify dirty bit system
when we have RenderMarquee.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 4:57 PM Changeset in webkit [179725] by
-
- 4 edits2 adds in trunk
[MSE] Implement Append Error algorithm.
https://bugs.webkit.org/show_bug.cgi?id=139439
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2015-02-05
Reviewed by Jer Noble.
If Source Buffer has not received first init segment, then it shall call endOfStream after receiving
Media Segment, as per Media Source spec. (from 17 July 2014) in paragraph 3.5.1 point 6.1.
Source/WebCore:
Based this change on Editor's Draft 12 December 2014, as it clarifies order of events.
Test: media/media-source/media-source-append-media-segment-without-init.html
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::streamEndedWithError):
- Modules/mediasource/MediaSource.h:
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::validateInitializationSegment):
(WebCore::SourceBuffer::appendError):
- Modules/mediasource/SourceBuffer.h:
LayoutTests:
Added test which after creating SourceBuffer sends media sample, without any init segments.
- media/media-source/media-source-append-media-segment-without-init-expected.txt: Added.
- media/media-source/media-source-append-media-segment-without-init.html: Added.
- 4:53 PM Changeset in webkit [179724] by
-
- 10 edits2 copies in branches/safari-600.1.4.15-branch
Merged r179627. rdar://problem/19432897
- 4:33 PM Changeset in webkit [179723] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed gardening.
Mark inspector/css/selector-specificity.html flaky with Crash too (already marked with Timeout).
- platform/mac/TestExpectations:
- 4:32 PM Changeset in webkit [179722] by
-
- 16 edits2 copies in branches/safari-600.1.4.15-branch
Merged r179366. rdar://problem/19432900
- 4:30 PM Changeset in webkit [179721] by
-
- 2 edits in trunk/Tools
Dashboard doesn't consider building ASan a productive step
https://bugs.webkit.org/show_bug.cgi?id=141312
Reviewed by Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
- 3:47 PM Changeset in webkit [179720] by
-
- 3 edits in trunk/Source/WebKit2
[iOS] Remove False Positive dispatch_source Leak in WebMemoryPressureHandler singleton
https://bugs.webkit.org/show_bug.cgi?id=141307
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-05
Reviewed by Anders Carlsson.
- UIProcess/ios/WebMemoryPressureHandlerIOS.h:
- UIProcess/ios/WebMemoryPressureHandlerIOS.mm:
(WebKit::WebMemoryPressureHandler::WebMemoryPressureHandler):
We want to keep the dispatch_source around, so just tie it to the
singleton so that it is not reported as a leak.
- 3:36 PM Changeset in webkit [179719] by
-
- 2 edits in trunk/LayoutTests
TestExpectations gardening.
- platform/win/TestExpectations: These two canvas tests fail on Windows only.
- 3:35 PM Changeset in webkit [179718] by
-
- 2 edits in trunk/LayoutTests
TestExpectations gardening.
- TestExpectations: Updated expectations for tests that pass.
- 3:27 PM Changeset in webkit [179717] by
-
- 2 edits in trunk/LayoutTests
TestExpectations gardening.
- platform/mac/TestExpectations: Updated expectatiosn for tests that sometimes pass.
- 3:15 PM Changeset in webkit [179716] by
-
- 2 edits in trunk/Tools
[iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
https://bugs.webkit.org/show_bug.cgi?id=141306
Reviewed by Alexey Proskuryakov.
The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
corresponding to the last-most runtime parsed from the output ofsimctl listfor any non-
existent runtime.
- Scripts/webkitpy/xcode/simulator.py:
(Runtime.from_identifier):
- 3:01 PM Changeset in webkit [179715] by
-
- 2 edits in trunk/LayoutTests
<rdar://problem/18216390> ASSERTION FAILED: !m_visibleDescendantStatusDirty in WebCore::RenderLayer::isVisuallyNonEmpty()
fullscreen/full-screen-iframe-legacy.html is another affected test.
- TestExpectations: Marked it as flakily crashing.
- 2:58 PM Changeset in webkit [179714] by
-
- 2 edits in trunk/Source/WebKit
[Win] 64-bit build fix after r179702 and r179709
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 2:47 PM Changeset in webkit [179713] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION: Inline SourceMap resources show empty content when opened.
https://bugs.webkit.org/show_bug.cgi?id=141225
Reviewed by Timothy Hatcher.
Change WebInspector.SourceMapResource.prototype.requestContentFromBackend to correctly and consistently handle
calls to NetworkAgent. The helper function sourceMapResourceLoaded will now properly handle parameters as a single
payload, including manual calls in the case where the source map content is in a data URI. Also
WebInspector.SourceCode.prototype._processContent now properly handles an error string used for displaying
resource loading error messages in the resource content view.
- UserInterface/Models/Resource.js: drive-by style fix.
- UserInterface/Models/SourceCode.js:
(WebInspector.SourceCode.prototype._processContent):
Properly handle error string.
- UserInterface/Models/SourceMapResource.js:
(WebInspector.SourceMapResource.prototype.requestContentFromBackend):
(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoaded):
Formerly sourceMapResourceLoadError, now handles parameters from the NetworkAgent correctly.
(WebInspector.SourceMapResource.prototype.requestContentFromBackend.sourceMapResourceLoadError):
This function now handles NetworkAgent errors only.
- 2:46 PM Changeset in webkit [179712] by
-
- 3 edits in trunk/Tools
LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
https://bugs.webkit.org/show_bug.cgi?id=139746
<rdar://problem/19283658>
Reviewed by Alexey Proskuryakov.
Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
if the simulator device is not in state Booted.
Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
launching/relaunching the iOS Simulator app and a simulator app can only be installed
on a device that is in the Booted state. LayoutTestRelay may run before the
device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
We should defer executing LayoutTestRelay until the simulator device booted by
iOS Simulator is in the Booted state.
- Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
Simulator methods with the module name, simulator.
(IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
before launching iOS Simulator to boot it.
(IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
(IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
- Scripts/webkitpy/xcode/simulator.py:
(Device.init): Remove parameter state and an instance variable of the same name, which represented
the state of the device when we created this object as part of parsing the output ofsimctl list. Callers
interested in the state of the device are more likely interested in the current state of the device as
opposed to the state of the device when the Device object was created.
(Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
(Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
from both this function and Simulator.device_state().
(Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
(Simulator.DeviceState): Added; class of constants.
(Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
device is in the specified state.
(Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
(Simulator.device_directory): Added.
(Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
- 2:35 PM Changeset in webkit [179711] by
-
- 5 edits2 copies in branches/safari-600.1.4.15-branch
Merged r179567. rdar://problem/19432892
- 2:34 PM Changeset in webkit [179710] by
-
- 7 edits in trunk/Websites/perf.webkit.org
New perf dashboard should compare results to baseline and target
https://bugs.webkit.org/show_bug.cgi?id=141286
Reviewed by Chris Dumez.
Compare the selected value against baseline and target values as done in v1. e.g. "5% below target"
Also use d3.format to format the selected value to show four significant figures.
- public/v2/app.js:
(App.Pane.searchCommit):
(App.Pane._fetch): Create time series here via createChartData so that _computeStatus can use them
to compute the status text without having to recreate them.
(App.createChartData): Added.
(App.PaneController._updateDetails): Use 3d.format on current and old values.
(App.PaneController._computeStatus): Added. Computes the status text.
(App.PaneController._relativeDifferentToLaterPointInTimeSeries): Added.
(App.AnalysisTaskController._fetchedManifest): Use createChartData as done in App.Pane._fetch. Also
format the values using chartData.formatter.
- public/v2/chart-pane.css: Enlarge the status text. Show the status text in red if it's worse than
the baseline and in blue if it's better than the target.
- public/v2/data.js:
(TimeSeries.prototype.findPointAfterTime): Added.
- public/v2/index.html: Added a new tbody for the status text and the selected value. Also fixed
the bug that we were not showing the old value's unit.
- public/v2/interactive-chart.js:
(App.InteractiveChartComponent._constructGraphIfPossible): Use chartData.formatter. Also cleaned up
the code to show the baseline and the target lines.
- public/v2/manifest.js:
(App.Manifest.fetchRunsWithPlatformAndMetric): Added smallerIsBetter.
- 2:17 PM Changeset in webkit [179709] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed attempt to fix Windows build after r179702.
Export a couple of extra symbols.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 2:17 PM Changeset in webkit [179708] by
-
- 6 edits in trunk/Source/WebKit2
Switch to file backed buffer when resource is cached to disk
https://bugs.webkit.org/show_bug.cgi?id=141295
Reviewed by Chris Dumez.
Wire the DidCacheResource mechanism to the new disk cache.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishLoading):
Send DidCacheResource message to the web process so it can switch the resource to file backing.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::store):
(WebKit::NetworkCache::update):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::DispatchPtr::DispatchPtr):
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::Data::Data):
(WebKit::mapFile):
(WebKit::decodeEntry):
(WebKit::retrieveActive):
(WebKit::NetworkCacheStorage::retrieve):
(WebKit::NetworkCacheStorage::store):
Map files larger than a memory page after a successful store.
(WebKit::NetworkCacheStorage::update):
(WebKit::encodeEntry): Deleted.
- 2:13 PM Changeset in webkit [179707] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Properly check for mmap() error case
https://bugs.webkit.org/show_bug.cgi?id=141304
Reviewed by Anders Carlsson.
mmap() returns MAP_FAILED, which is (void*)-1, not a null pointer in
case of failure. This patch updates several wrong error checks in
WebKit2.
- Platform/IPC/ArgumentEncoder.cpp:
(IPC::allocBuffer):
(IPC::ArgumentEncoder::reserve):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::sendOutgoingMessage):
- 1:55 PM Changeset in webkit [179706] by
-
- 3 edits2 adds in trunk
Crash due to failing to dirty a removed text node's line box
https://bugs.webkit.org/show_bug.cgi?id=136544
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/text/remove-text-node-linebox-not-dirty-crash.html
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): Make the check for dirtying the next
line box a bit more inclusive to avoid a case of a line box for a destroyed render object not
being dirtied. In particular, when the text node's parent has no line boxes but contains BRs.
LayoutTests:
- fast/text/remove-text-node-linebox-not-dirty-crash-expected.txt: Added.
- fast/text/remove-text-node-linebox-not-dirty-crash.html: Added.
- 1:52 PM Changeset in webkit [179705] by
-
- 10 edits in trunk/Source/WebKit2
Clean up WebInspectorProxy and use simpler inspector levels design
https://bugs.webkit.org/show_bug.cgi?id=141135
Reviewed by Timothy Hatcher.
Inspector levels used to be managed by keeping a set of WebPageGroup
instances and doing pointer comparisons to check whether the inspected
view is itself a web inspector instance. This is unnecessary, as we
can maintain a mapping from WebPageProxy* to its corresponding level.
When an inspector instance is created, it is inserted into the mapping
along with its level. An inspector's level is 1 unless its inspected page
is in the mapping, then it is one greater that the inspected page's level.
The level is provided by inspectorLevel(), rather than a member variable.
WebInspectorProxy is created in the constructor of WebPageProxy. Thus, there
would be no chance to add the inspector page's level to the mapping before the
next level inspector tries to look it up when initializing its members.
This patch introduces other miscellaneous cleanups, such as naming m_page
to m_inspectedPage, using Ref and using an enum class for the attachment side.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorGetPage):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(resizeWebKitWebViewBaseFromAllocation):
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::pageLevelMap):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::inspectorLevel):
(WebKit::WebInspectorProxy::inspectorPageGroupIdentifier):
(WebKit::WebInspectorProxy::inspectorPagePreferences):
(WebKit::WebInspectorProxy::invalidate):
(WebKit::WebInspectorProxy::isFront):
(WebKit::WebInspectorProxy::connect):
(WebKit::WebInspectorProxy::show):
(WebKit::WebInspectorProxy::hide):
(WebKit::WebInspectorProxy::close):
(WebKit::WebInspectorProxy::didRelaunchInspectorPageProcess):
(WebKit::WebInspectorProxy::showConsole):
(WebKit::WebInspectorProxy::showResources):
(WebKit::WebInspectorProxy::showMainResourceForFrame):
(WebKit::WebInspectorProxy::attachBottom):
(WebKit::WebInspectorProxy::attachRight):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::togglePageProfiling):
(WebKit::WebInspectorProxy::isInspectorPage):
(WebKit::decidePolicyForNavigationAction):
(WebKit::WebInspectorProxy::remoteFrontendConnected):
(WebKit::WebInspectorProxy::remoteFrontendDisconnected):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didClose):
(WebKit::WebInspectorPageGroups::singleton): Deleted.
(WebKit::WebInspectorPageGroups::inspectorLevel): Deleted.
(WebKit::WebInspectorPageGroups::isInspectorPageGroup): Deleted.
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel): Deleted.
(WebKit::WebInspectorPageGroups::inspectorPageGroupForLevel): Deleted.
(WebKit::WebInspectorPageGroups::createInspectorPageGroup): Deleted.
(WebKit::WebInspectorProxy::~WebInspectorProxy): Deleted.
(WebKit::WebInspectorProxy::inspectorPageGroup): Deleted.
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Deleted.
(WebKit::WebInspectorProxy::enableRemoteInspection): Deleted.
(WebKit::WebInspectorProxy::open): Deleted.
- UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::create):
(WebKit::WebInspectorProxy::inspectedPage):
(WebKit::WebInspectorProxy::page): Deleted.
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::dockButtonClicked):
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformInspectedWindowWidth):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
(WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter attachRight:]):
(-[WKWebInspectorProxyObjCAdapter attachBottom:]):
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::windowFrameDidChange):
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
(WebKit::WebInspectorProxy::platformInspectedWindowHeight):
(WebKit::WebInspectorProxy::platformInspectedWindowWidth):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(-[WKWebInspectorProxyObjCAdapter close]): Deleted.
- 1:48 PM Changeset in webkit [179704] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Cocoa] Populate m_contentsFilter bloom filter from the main dispatch queue NetworkCacheStorage::initialize()
https://bugs.webkit.org/show_bug.cgi?id=141297
Reviewed by Antti Koivisto.
Populate m_contentsFilter bloom filter from the main dispatch queue
NetworkCacheStorage::initialize() to avoid thread-safety issues.
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::initialize):
- 1:46 PM Changeset in webkit [179703] by
-
- 2 edits in trunk/Source/WebKit2
Use deleteFile() in NetworkCacheStorageCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=141299
Reviewed by Antti Koivisto.
Use deleteFile() in NetworkCacheStorageCocoa.mm to simplify the code
a bit.
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::removeEntry):
(WebKit::NetworkCacheStorage::clear):
(WebKit::NetworkCacheStorage::shrinkIfNeeded):
- 1:29 PM Changeset in webkit [179702] by
-
- 7 edits2 adds in trunk
Free memory read under MemoryCache::pruneLiveResourcesToSize()
https://bugs.webkit.org/show_bug.cgi?id=141292
<rdar://problem/19725522>
Reviewed by Antti Koivisto.
In MemoryCache::pruneLiveResourcesToSize(), we were iterating over the
m_liveDecodedResources ListHashSet and possibly calling
CachedResource::destroyDecodedData() on the current value. Doing so
would cause a call to ListHashSet::remove() to remove the value pointed
by the current iterator, thus invalidating our iterator.
In this patch, we increment the ListHashSet iterator *before* calling
CachedResource::destroyDecodedData(), while the current iterator is
still valid. Note that this is safe because unlike iteration of most
WTF Hash data structures, iteration is guaranteed safe against mutation
of the ListHashSet, except for removal of the item currently pointed to
by a given iterator.
Test: http/tests/cache/memory-cache-pruning.html
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneLiveResourcesToSize):
- 12:12 PM Changeset in webkit [179701] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: eliminate some unnecessary layout/painting in timeline overview and ruler
https://bugs.webkit.org/show_bug.cgi?id=141293
Reviewed by Timothy Hatcher.
The timeline overview's ruler was forcing repaints of divider labels even if the labels
had not changed since the last requestAnimationFrame. Bail out early if nothing changed.
The timeline overview and its graphs were updating layout using requestAnimationFrame
even when the TimelineContentView is not visible. Fix this by propagating visibility
changes to subviews, and not updating layout when hidden.
The above change also fixes an assertion sometimes encountered when the timeline view
tries to cache an element's offset width, but cannot because it isn't visible.
- UserInterface/Views/TimelineContentView.js:
(WebInspector.TimelineContentView.prototype.shown):
(WebInspector.TimelineContentView.prototype.hidden):
- UserInterface/Views/TimelineOverview.js:
(WebInspector.TimelineOverview.prototype.get visible):
(WebInspector.TimelineOverview.prototype.shown):
(WebInspector.TimelineOverview.prototype.hidden):
(WebInspector.TimelineOverview.prototype._needsLayout):
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype.get visible):
(WebInspector.TimelineOverviewGraph.prototype.shown):
(WebInspector.TimelineOverviewGraph.prototype.hidden):
(WebInspector.TimelineOverviewGraph.prototype.needsLayout):
- UserInterface/Views/TimelineRuler.js:
(WebInspector.TimelineRuler.prototype.updateLayout):
- 11:49 AM Changeset in webkit [179700] by
-
- 2 edits in trunk/LayoutTests
[Win] Mark another group of assertion failures.
- platform/win/TestExpectations:
- 11:37 AM Changeset in webkit [179699] by
-
- 3 edits2 adds in trunk
[Mac] HLS <video> will not fire 'progress' events, only 'stalled'.
https://bugs.webkit.org/show_bug.cgi?id=141284
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/media/hls/hls-progress.html
totalBytes() will always return 0 for HLS streams, which will cause didLoadingProgress() to always
return false. Skip this optimization.
Drive-by fix: duration() will always return 0 for this class as well. Use durationMediaTime() instead.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress):
LayoutTests:
- http/tests/media/hls/hls-progress-expected.txt: Added.
- http/tests/media/hls/hls-progress.html: Added.
- 11:29 AM Changeset in webkit [179698] by
-
- 2 edits in trunk/Tools
Disable retries on Mac debug testers
https://bugs.webkit.org/show_bug.cgi?id=141296
Reviewed by Simon Fraser.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 10:40 AM Changeset in webkit [179697] by
-
- 2 edits in trunk/LayoutTests
[Mac] Unreviewed gardening.
Mark compositing/reflections/masked-reflection-on-composited.html flaky.
- platform/mac/TestExpectations:
- 10:36 AM Changeset in webkit [179696] by
-
- 2 edits in trunk/LayoutTests
http/tests/xmlhttprequest/event-listener-gc.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=33342
Reviewed by Anders Carlsson.
Speculative fix.
- http/tests/xmlhttprequest/print-content-type.cgi: Make the resource uncacheable,
so that it doesn't load too quickly.
- 10:07 AM Changeset in webkit [179695] by
-
- 58 edits in trunk/Source/WebCore
Move InstanceInvalidationGuard/UpdateBlocker to SVGElement from SVGElementInstance
https://bugs.webkit.org/show_bug.cgi?id=141148
Patch by Darin Adler <Darin Adler> on 2015-02-05
Reviewed by Brent Fulgham and Anders Carlsson.
Inspired by this change Rob Buis made in Blink:
http://src.chromium.org/viewvc/blink?view=revision&revision=173343
I actually wrote the whole thing and then discovered we did it almost identically.
- svg/SVGAnimatedTypeAnimator.cpp:
(WebCore::SVGElementAnimatedPropertyList::setInstanceUpdatesBlocked): Added this
helper function to get around a circular header dependency.
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::executeAction): Use setInstanceUpdatesBlocked.
- svg/SVGElement.cpp:
(WebCore::SVGElement::removedFrom): Use invalidateInstances.
(WebCore::SVGElement::finishParsingChildren): Ditto.
(WebCore::SVGElement::svgAttributeChanged): Ditto.
(WebCore::SVGElement::childrenChanged): Ditto.
(WebCore::SVGElement::setInstanceUpdatesBlocked): Added an assertion that will
catch anyone who nests InstanceUpdateBlocker by accident.
(WebCore::SVGElement::invalidateInstances): Moved this here from
SVGElementInstance::invalidateAllInstancesOfElement. I had already modified this
so it had nothing to do with SVGElementInstance, so it was a simple matter of
converting this into a member function. Added a FIXME about the mysterious
updateStyleIfNeeded that makes multiple tests fail if it's removed.
- svg/SVGElement.h: Added public InstanceUpdateBlocker class, protected
InstanceInvalidationGuard class, and private invalidateInstances function.
Unlike the ones in SVGElementInstance these use references so they are then
not copyable without using the WTF_MAKE_NONCOPYABLE macro.
- svg/SVGElementInstance.cpp:
(WebCore::SVGElementInstance::invalidateAllInstancesOfElement): Deleted.
(WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker): Deleted.
(WebCore::SVGElementInstance::InstanceUpdateBlocker::~InstanceUpdateBlocker): Deleted.
- svg/SVGElementInstance.h: Removed InvalidationGuard, InstanceUpdateBlocker, and
invalidateAllInstancesOfElement. Didn't do any further cleanup since we soon will
delete this entire file.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::svgAttributeChanged): Updated to use new name and reference
instead of pointer.
- svg/SVGAnimateElementBase.cpp:
(WebCore::applyCSSPropertyToTargetAndInstances): Ditto.
(WebCore::removeCSSPropertyFromTargetAndInstances): Ditto.
(WebCore::notifyTargetAndInstancesAboutAnimValChange): Ditto.
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation): Ditto.
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::svgAttributeChanged): Ditto.
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::svgAttributeChanged): Ditto.
- svg/SVGComponentTransferFunctionElement.cpp:
(WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged): Ditto.
- svg/SVGCursorElement.cpp:
(WebCore::SVGCursorElement::svgAttributeChanged): Ditto.
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::svgAttributeChanged): Ditto.
- svg/SVGFEBlendElement.cpp:
(WebCore::SVGFEBlendElement::svgAttributeChanged): Ditto.
- svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::svgAttributeChanged): Ditto.
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::svgAttributeChanged): Ditto.
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged): Ditto.
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged): Ditto.
- svg/SVGFEDisplacementMapElement.cpp:
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Ditto.
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::svgAttributeChanged): Ditto.
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): Ditto.
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::svgAttributeChanged): Ditto.
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged): Ditto.
- svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Ditto.
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::svgAttributeChanged): Ditto.
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::svgAttributeChanged): Ditto.
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged): Ditto.
- svg/SVGFETileElement.cpp:
(WebCore::SVGFETileElement::svgAttributeChanged): Ditto.
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::svgAttributeChanged): Ditto.
- svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::svgAttributeChanged): Ditto.
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged): Ditto.
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::svgAttributeChanged): Ditto.
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::svgAttributeChanged): Ditto.
- svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::svgAttributeChanged): Ditto.
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::svgAttributeChanged): Ditto.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::svgAttributeChanged): Ditto.
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::svgAttributeChanged): Ditto.
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::svgAttributeChanged): Ditto.
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::svgAttributeChanged): Ditto.
- svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::svgAttributeChanged): Ditto.
- svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::svgAttributeChanged): Ditto.
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::svgAttributeChanged): Ditto.
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::svgAttributeChanged): Ditto.
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::svgAttributeChanged): Ditto.
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::svgAttributeChanged): Ditto.
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::svgAttributeChanged): Ditto.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::svgAttributeChanged): Ditto.
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::svgAttributeChanged): Ditto.
- svg/SVGStopElement.cpp:
(WebCore::SVGStopElement::svgAttributeChanged): Ditto.
- svg/SVGSymbolElement.cpp:
(WebCore::SVGSymbolElement::svgAttributeChanged): Ditto.
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::svgAttributeChanged): Ditto.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::svgAttributeChanged): Ditto.
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::svgAttributeChanged): Ditto.
- svg/SVGTextPositioningElement.cpp:
(WebCore::SVGTextPositioningElement::svgAttributeChanged): Ditto.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::svgAttributeChanged): Ditto.
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::svgAttributeChanged): Ditto.
- 9:56 AM Changeset in webkit [179694] by
-
- 2 edits in trunk/Tools
Need a way to force $xcodeSDK in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=141291
Reviewed by Anders Carlsson.
- Scripts/webkitdirs.pm:
(setXcodeSDK): Added.
- 9:25 AM Changeset in webkit [179693] by
-
- 2 edits in trunk/Source/WebCore
Remind ourselves to remove work-around code
https://bugs.webkit.org/show_bug.cgi?id=141289
Unreviewed gardening: Add a reminder FIXME to CSSParser
so we can remove the MSVC-specific hack in the future.
- css/CSSParser.cpp:
- 9:04 AM Changeset in webkit [179692] by
-
- 2 edits in trunk/LayoutTests
[Win] More Unreviewed gardening.
- platform/win/TestExpectations:
- 8:50 AM Changeset in webkit [179691] by
-
- 6 edits2 adds in trunk
Do not destroy RenderQuote's text fragment child when quotation mark string is changing.
https://bugs.webkit.org/show_bug.cgi?id=141271
rdar://problem/18169375
Reviewed by Antti Koivisto.
Similar approach as https://codereview.chromium.org/679593004/
This patch ensures that laying out a RenderQuote does not force a sibling RenderQuote's
child renderer(RenderText) to be destroyed.
BreakingContext holds a pointer to the next renderer on the line (BreakingContext::m_nextObject).
While laying out the line, initiated by BreakingContext, placing the current renderer could end up destroying the "next" renderer.
This happens when the pseudo after quotation mark(RenderQuote) becomes floated, the sibling <q>'s pseudo
before text needs to be changed (from " to ') so that we don't end up with 2 sets of the same opening
strings.
The fix is to reuse the RenderTextFragment object instead of destroy/recreate it.
Source/WebCore:
Test: fast/css/content/quote-crash-when-floating.html
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote):
(WebCore::fragmentChild):
(WebCore::RenderQuote::updateText):
- rendering/RenderQuote.h:
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::setText):
(WebCore::RenderTextFragment::setContentString):
- rendering/RenderTextFragment.h:
LayoutTests:
- fast/css/content/quote-crash-when-floating-expected.txt: Added.
- fast/css/content/quote-crash-when-floating.html: Added.
- 6:31 AM Changeset in webkit [179690] by
-
- 4 edits in trunk/Source/WebKit2
Avoid copying std::functions across threads in NetworkCacheStorage
https://bugs.webkit.org/show_bug.cgi?id=141273
Reviewed by Andreas Kling.
The current approach is risky. There is possiblity that captured variables are
deleted in an unexpected thread.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::retrieve):
The capture trick here is no longer needed.
- NetworkProcess/cache/NetworkCacheStorage.h:
For each cache operation we create Retrive/Store/UpdateOperation object kept alive by the active operation map.
This object captures all parameters of the operation including the lambda. When the operation completes
the object is removed from the map in the main thread, ensuring safe destruction.
- NetworkProcess/cache/NetworkCacheStorageCocoa.mm:
(WebKit::NetworkCacheStorage::dispatchRetrieveOperation):
(WebKit::NetworkCacheStorage::dispatchPendingRetrieveOperations):
(WebKit::retrieveActive):
Instead of maintaining a separate write cache we just look through the active write and update maps.
(WebKit::NetworkCacheStorage::retrieve):
Use fixed sized priority array rather than a dynamic one. Vector<Deque<std::unique_ptr>> doesn't quite work.
(WebKit::NetworkCacheStorage::store):
(WebKit::NetworkCacheStorage::update):
(WebKit::NetworkCacheStorage::clear):
- 5:34 AM Changeset in webkit [179689] by
-
- 2 edits in trunk/Source/WebCore
[Media iOS] Add a debug setting to always show the optimized fullscreen button
https://bugs.webkit.org/show_bug.cgi?id=141277
<rdar://problem/19724471>
Reviewed by Eric Carlson.
Add a debug option so that we can test the optimized fullscreen
control on media that doesn't support it.
- Modules/mediacontrols/mediaControlsiOS.js: Add gSimulateOptimizedFullscreenAvailable.
(ControllerIOS.prototype.createControls): Check the setting.
(ControllerIOS.prototype.configureInlineControls): Ditto.
(ControllerIOS.prototype.formatTime): Drive-by whitespace cleanup.
(ControllerIOS.prototype.handleBaseGestureChange):
(ControllerIOS.prototype.handleWrapperTouchStart):
(ControllerIOS.prototype.handleOptimizedFullscreenTouchEnd):
(ControllerIOS.prototype.handlePresentationModeChange): Drive-by variable renaming.
- 5:02 AM Changeset in webkit [179688] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Set all tests of svg/W3C-SVG-1.1 and svg/W3C-SVG-1.1-SE to flaky.
Because all tests looks like flaky now. This will be handled on Bug 137138. Additionally
duplicated tests are removed.
- platform/efl/TestExpectations:
- 2:19 AM Changeset in webkit [179687] by
-
- 33 edits11 adds in trunk
[Streams API] Implement a barebone ReadableStream interface
https://bugs.webkit.org/show_bug.cgi?id=141045
Reviewed by Benjamin Poulain.
.:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake: Made streams API compilation on by default.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
This patch implements the ReadableStream IDL (https://streams.spec.whatwg.org/#rs-model).
No functionality is yet added.
ReadableStreamSource is expected to be implemented for native sources (such as HTTP sources)
as well as JavaScript source through ReadableStreamJSSource.
Test: streams/readablestream-constructor.html
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.cpp:
- DerivedSources.make:
- Modules/streams/ReadableStream.cpp: Added.
(WebCore::ReadableStream::create):
(WebCore::ReadableStream::ReadableStream):
(WebCore::ReadableStream::~ReadableStream):
(WebCore::ReadableStream::state):
(WebCore::ReadableStream::closed):
(WebCore::ReadableStream::ready):
- Modules/streams/ReadableStream.h: Added.
- Modules/streams/ReadableStream.idl: Added.
- Modules/streams/ReadableStreamSource.h: Added.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.vcxproj/WebCoreCommon.props:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSReadableStreamCustom.cpp: Added.
(WebCore::JSReadableStream::read):
(WebCore::JSReadableStream::ready):
(WebCore::JSReadableStream::closed):
(WebCore::JSReadableStream::cancel):
(WebCore::JSReadableStream::pipeTo):
(WebCore::JSReadableStream::pipeThrough):
(WebCore::constructJSReadableStream):
- bindings/js/ReadableStreamJSSource.cpp: Added.
(WebCore::ReadableStreamJSSource::create):
(WebCore::ReadableStreamJSSource::ReadableStreamJSSource):
(WebCore::ReadableStreamJSSource::setInternalError):
- bindings/JSReadableStreamJSSource.h: Added.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
LayoutTests:
Added readablestream-constructor test that checks ReadableStream properties and state.
Rebased global-constructor-attributes.html expectations to add ReadableStream description.
- js/dom/global-constructors-attributes-expected.txt:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- streams/readablestream-constructor-expected.txt: Added.
- streams/readablestream-constructor.html: Added.
- 1:54 AM Changeset in webkit [179686] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed build fix.
- public/v2/app.js:
(App.IndexController.gridChanged): Use store.createRecord to create a custom dashboard as required by Ember.js
- 1:25 AM Changeset in webkit [179685] by
-
- 3 edits in branches/safari-600.1.4.15-branch
Merged r178953. rdar://problem/19651478
- 1:25 AM Changeset in webkit [179684] by
-
- 4 edits in trunk/LayoutTests
Remove Mountain Lion specific test expectations
https://bugs.webkit.org/show_bug.cgi?id=141243
Reviewed by Alexey Proskuryakov.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:59 AM Changeset in webkit [179683] by
-
- 2 edits in branches/safari-600.1.4.15-branch/LayoutTests
Merged r178953. rdar://problem/19651478
- 12:58 AM Changeset in webkit [179682] by
-
- 6 edits in trunk
Crash in uninitialized deconstructing variable.
https://bugs.webkit.org/show_bug.cgi?id=141070
Reviewed by Michael Saboff.
Source/JavaScriptCore:
According to the ES6 spec, when a destructuring pattern occurs
as the left hand side of an assignment inside a var declaration
statement, the assignment must also have a right hand side value.
"var {x} = {};" is a legal syntactic statement, but,
"var {x};" is a syntactic error.
Section 13.2.2 of the latest draft ES6 spec specifies this requirement:
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-variable-statement
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseVarDeclaration):
(JSC::Parser<LexerType>::parseVarDeclarationList):
(JSC::Parser<LexerType>::parseForStatement):
- parser/Parser.h:
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 12:58 AM Changeset in webkit [179681] by
-
- 3 edits in branches/safari-600.1.4.15-branch/LayoutTests
Merged r178795. rdar://problem/19651478
- 12:55 AM Changeset in webkit [179680] by
-
- 11 edits1 copy in branches/safari-600.1.4.15-branch
Merged r178768. rdar://problem/19651478
- 12:19 AM Changeset in webkit [179679] by
-
- 2 edits in branches/safari-600.1.4.15-branch/Source/JavaScriptCore
Merged r179329.
