Timeline
Jun 30, 2015:
- 11:26 PM Changeset in webkit [186172] by
-
- 4 edits in trunk/Source
[Win] Unreviewed build fix after r186169.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Temporarily don't build ANGLE projects on Windows.
Source/WTF:
- wtf/FeatureDefines.h:
Temporarily disable WebGL on WinCairo. It was already temporarily disabled on AppleWin.
- 11:23 PM Changeset in webkit [186171] by
-
- 5 edits in trunk/Source
Versioning.
- 11:18 PM Changeset in webkit [186170] by
-
- 6 edits in tags/Safari-601.1.38/Source/WebKit2
Roll out r186148. rdar://problem/20655729
- 11:17 PM Changeset in webkit [186169] by
-
- 160 edits541 adds85 deletes in trunk/Source
Update ANGLE to b11e2483742db884bd0af41f78f528240577356b.
https://bugs.webkit.org/show_bug.cgi?id=145010
Reviewed by Dean Jackson.
Source/ThirdParty/ANGLE:
Huge list of source changes omitted.
ROLL DEPS!
Source/WebCore:
- CMakeLists.txt:
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::appendSymbol):
(WebCore::getStructInfo):
(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::getValidationResultValue): Deleted.
- platform/graphics/ANGLEWebKitBridge.h:
(WebCore::ANGLEShaderSymbol::isSampler):
- platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::SymbolInfo::SymbolInfo):
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::checkVaryingsPacking):
(WebCore::GraphicsContext3D::precisionsMatch):
Update WebCore to reflect changes in ANGLE.
- 11:15 PM Changeset in webkit [186168] by
-
- 1 copy in tags/Safari-601.1.38
New tag.
- 11:08 PM Changeset in webkit [186167] by
-
- 2 edits1 add in trunk/LayoutTests
[EFL] Unreviewed gardening.
Some tests are flaky or timeout after bumping Ubuntu version from 14.04 to 15.04.
Mark the tests to flaky or timeout.
- platform/efl/TestExpectations:
- platform/efl/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
- 10:59 PM Changeset in webkit [186166] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, skip this test for now. We can unskip it when this feature is enabled.
- js/script-tests/intl.js:
- 9:30 PM Changeset in webkit [186165] by
-
- 5 edits2 adds in trunk
Frame flattening: Hit-testing an iframe could end up destroying the associated inline tree context.
https://bugs.webkit.org/show_bug.cgi?id=146447
rdar://problem/20613501
Reviewed by Simon Fraser.
This patch ensures that the render tree associated with the document on which
the hit-test is initiated does not get laid out, unless it was directly mutated prior to the hittest.
Hit-test requirements:
- A clean the render tree before hit-testing gets propagated to the renderers.
Document::updateLayout() ensures it by calling both updateStyleIfNeeded() and layout() not only on the current tree, but also
on the ancestors if needed.
- No render tree mutation while hit-testing the renderers.
When an iframe is being hit-tested, this hit-test could bubble down to the child frame's render view.
In order to ensure #1, we call Document::updateLayout() on the current (subframe) document.
If updateStyleIfNeeded() mutates the render tree, we mark it dirty for layout(). However frame flattening also
marks the parent renderer (RenderIFrame) dirty.
While calling layout() to clean the current render tree, we end up laying out the parent tree too.
Laying out the parent tree could end up destroying the inline tree context from where the
hittest just bubbled down. (InlineFlowBox -> RenderWidget -> RenderView).
This patch protects the render tree from such unintentional inline tree mutation during hittesting.
After the initial layout we set a layout disallow flag on the frame view to defer subsequent layouts.
This patch only changes behavior when frame flattening is enabled, but in future we may always want to enable this.
Source/WebCore:
Test: fast/frames/flattening/hittest-iframe-while-style-changes-crash.html
- page/FrameView.cpp:
(WebCore::FrameView::layout):
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded): Deleted. -> Assertion in no longer valid.
- page/FrameView.h:
- rendering/RenderView.cpp:
(WebCore::FrameFlatteningLayoutDisallower::FrameFlatteningLayoutDisallower):
(WebCore::FrameFlatteningLayoutDisallower::~FrameFlatteningLayoutDisallower):
(WebCore::RenderView::hitTest): Protect the render tree from subsequent layouts.
LayoutTests:
- fast/frames/flattening/hittest-iframe-while-style-changes-crash-expected.txt: Added.
- fast/frames/flattening/hittest-iframe-while-style-changes-crash.html: Added.
- 7:39 PM Changeset in webkit [186164] by
-
- 2 edits in trunk/Source/WebKit2
Fix CoordinatedGraphics.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
- 7:07 PM Changeset in webkit [186163] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: add " = $0" hint after selected element in main DOMTreeOutline
https://bugs.webkit.org/show_bug.cgi?id=145739
Patch by Devin Rousso <Devin Rousso> on 2015-06-30
Reviewed by Timothy Hatcher.
- UserInterface/Views/DOMTreeOutline.css: Adds a semi-opaque " = $0" to the selected element in the DOM tree.
(.dom-tree-outline li.selected > span::after):
(.dom-tree-outline:focus li.selected > span::after):
- 7:03 PM Changeset in webkit [186162] by
-
- 3 edits in trunk/Source/WebKit2
More Gtk/EFL fixing.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer):
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):
- 7:01 PM Changeset in webkit [186161] by
-
- 25 edits5 adds in trunk
Implement ECMAScript Internationalization API
https://bugs.webkit.org/show_bug.cgi?id=90906
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2015-06-30
Reviewed by Benjamin Poulain.
.:
Begin implementing the Intl apis behind ENABLE_INTL flag.
Create the base Intl namespace object.
- Source/cmake/WebKitFeatures.cmake: add ENABLE_INTL flag
Source/JavaScriptCore:
- CMakeLists.txt: add IntlObject.cpp
- Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: add IntlObject
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: add IntlObject
- JavaScriptCore.xcodeproj/project.pbxproj: add IntlObject
- runtime/CommonIdentifiers.h: add "Intl" name
- runtime/IntlObject.cpp: Added.
(JSC::IntlObject::IntlObject):
(JSC::IntlObject::create):
(JSC::IntlObject::finishCreation):
(JSC::IntlObject::createStructure):
- runtime/IntlObject.h: Added.
- runtime/JSGlobalObject.cpp: Add global Intl
(JSC::JSGlobalObject::init):
Source/WebCore:
Test: js/intl.html
- Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig: add ENABLE_INTL flag
Source/WTF:
- wtf/FeatureDefines.h: add ENABLE_INTL flag
Tools:
- Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.props: add ENABLE_INTL flag
- win/tools/vsprops/FeatureDefinesCairo.props: add ENABLE_INTL flag
LayoutTests:
- TestExpectations: Skip intl until enabled
- js/intl-expected.txt: Added.
- js/intl.html: Added.
- js/script-tests/intl.js: Added.
(global):
- 6:51 PM Changeset in webkit [186160] by
-
- 4 edits2 adds in trunk
scroll-snap-points do not work very well with mechanical scroll wheel events
https://bugs.webkit.org/show_bug.cgi?id=142501
<rdar://problem/20093511>
Patch by Wenson Hsieh <whsieh@berkeley.edu> on 2015-06-30
Reviewed by Brent Fulgham.
Source/WebCore:
Stateless scroll events generated by scrolling with a mechanical mouse wheel now trigger scroll
snapping after a fixed delay.
Test: platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html
- platform/cocoa/ScrollController.h: Added member to track stateless scrolling.
- platform/cocoa/ScrollController.mm: Added constant for delay for stateless scroll snapping.
(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Triggers timer upon stateless scroll events.
(WebCore::ScrollController::horizontalScrollSnapTimerFired): Timer now handles stateless scrolling updates.
(WebCore::ScrollController::verticalScrollSnapTimerFired): See above.
(WebCore::ScrollController::beginScrollSnapAnimation): Handles stateless scroll snapping.
LayoutTests:
- platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html: Added.
- 6:46 PM Changeset in webkit [186159] by
-
- 5 edits in trunk/Source
Fix Mac and Windows builds.
Source/WebKit/win:
- WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::flushPendingLayerChanges):
- WebView.cpp:
(WebView::flushPendingGraphicsLayerChanges):
Source/WebKit2:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
- 6:33 PM Changeset in webkit [186158] by
-
- 5 edits in tags/Safari-601.1.37.1.2/Source
Versioning.
- 6:30 PM Changeset in webkit [186157] by
-
- 1 copy in tags/Safari-601.1.37.1.2
New tag.
- 6:15 PM Changeset in webkit [186156] by
-
- 6 edits in trunk/Source/WebCore
Try to fix Gtk and EFL builds.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:
(WebCore::CompositingCoordinator::flushPendingLayerChanges):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
- 6:08 PM Changeset in webkit [186155] by
-
- 10 edits in trunk/Source
[iOS] Missing tiles inside position:fixed on scrolling
https://bugs.webkit.org/show_bug.cgi?id=146485
rdar://problem/21226861
Reviewed by Tim Horton.
Layer flushing adjusts the coverage rect for tiled layers, but does so at times
when position:fixed layers are moved around by the scrolling tree. The computed
coverage rect then doesn't reflect the layer's on-screen position, causing missing
tiles.
Fix by pushing the notion of being in a "stable state" onto FrameView, and passing
that state into the layer flush. When not in a stable state, flushing doesn't change
the visible and coverage rects for layers that are viewport-constrained.
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::reset):
- page/FrameView.h: Remove some velocity-related data members that were unused.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::flushCompositingState):
(WebCore::GraphicsLayer::flushCompositingStateForThisLayerOnly):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::flushCompositingState):
(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects): If this is a viewport-constrained
layer, and the viewport is not stable, don't touch the rects.
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
- platform/graphics/ca/GraphicsLayerCA.h:
(WebCore::GraphicsLayerCA::CommitState::CommitState):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
Source/WebKit2:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- 6:01 PM Changeset in webkit [186154] by
-
- 5 edits in trunk/Source/WebCore
Rename GraphicsLayer's allowsBackingStoreDetachment to isViewportConstrained
https://bugs.webkit.org/show_bug.cgi?id=146483
Reviewed by Tim Horton.
What GraphicsLayer really needs to know is whether some other thread/process
is moving its platform layers around behind its back, and this is is better
expressed as "isViewportConstrained" rather than "allowsBackingStoreDetachment".
The sense of the flag is flipped, and boolean logic adjusted accordingly.
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::setIsViewportConstrained):
(WebCore::GraphicsLayer::isViewportConstrained):
(WebCore::GraphicsLayer::setAllowsBackingStoreDetachment): Deleted.
(WebCore::GraphicsLayer::allowsBackingStoreDetachment): Deleted.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):
(WebCore::GraphicsLayerCA::recursiveCommitChanges):
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setIsScrollCoordinatedWithViewportConstrainedRole):
- 5:46 PM Changeset in webkit [186153] by
-
- 5 edits in trunk/Source/WebKit2
[EFL] Implement ewk_favicon_database_clear() API.
https://bugs.webkit.org/show_bug.cgi?id=146337
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-30
Reviewed by Gyuyoung Kim.
We need to provide way to clear favicon data.
- UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::getIconSurfaceSynchronously):
(EwkFaviconDatabase::clearFaviconDatabase):
(EwkFaviconDatabase::iconDataReadyForPageURL):
(ewk_favicon_database_icon_change_callback_del):
(ewk_favicon_database_clear):
- UIProcess/API/efl/ewk_favicon_database.h:
- UIProcess/API/efl/ewk_favicon_database_private.h:
- UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
(TEST_F):
- 5:39 PM Changeset in webkit [186152] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Ignore viewport rect changes during zoom bouncing.
<https://webkit.org/b/146480>
Reviewed by Benjamin Poulain.
When the user has pinch-zoomed past the maximum zoom scale and lets go of the screen,
we animate a bounce back to the maximum scale.
Suppress viewport rect updates during this bounce animation since we don't need them
anyway. This fixes an issue where we'd sometimes get a weird rect during the animation
and if could send that to the web process, causing it to generate tiles for a part of
the page that's not actually exposed.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _updateVisibleContentRects]):
- 5:36 PM Changeset in webkit [186151] by
-
- 2 edits in trunk/Source/WTF
Errors in read() are not handled in WTF::cryptographicallyRandomValuesFromOS.
https://bugs.webkit.org/show_bug.cgi?id=146473
Patch by Keith Miller <keith_miller@apple.com> on 2015-06-30
Reviewed by Filip Pizlo.
We were not checking if errors occurred in WTF::cryptographicallyRandomValuesFromOS.
We now buffer the data until enough bits of entropy exist to fill the buffer
rather than crash. Additionally, added two crash functions so we can distinguish
between the two reasons why we crashed in traces.
- wtf/OSRandomSource.cpp:
(WTF::crashUnableToOpenFD):
(WTF::crashUnableToReadFromFD):
(WTF::cryptographicallyRandomValuesFromOS):
- 5:17 PM Changeset in webkit [186150] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, rebaseline editing/style/unbold-in-bold.html on WK2.
- platform/mac-wk2/editing/style/unbold-in-bold-expected.txt: Added.
- 5:16 PM Changeset in webkit [186149] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed, revert bad wk2 baseline done in r186106.
- platform/mac-wk2/editing/style: Removed.
- 5:08 PM Changeset in webkit [186148] by
-
- 6 edits in trunk/Source/WebKit2
<rdar://problem/20655729> WebKit should heuristically exclude scrolling touch events from the user gesture category
Reviewed by Benjamin Poulain.
- Platform/spi/ios/UIKitSPI.h:
- Shared/WebEvent.h:
(WebKit::WebTouchEvent::WebTouchEvent):
(WebKit::WebTouchEvent::position):
(WebKit::WebTouchEvent::isPotentialTap):
(WebKit::WebTouchEvent::isGesture):
(WebKit::WebTouchEvent::gestureScale):
(WebKit::WebTouchEvent::gestureRotation):
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformTouchEvent::WebKit2PlatformTouchEvent):
- Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):
- Shared/ios/WebTouchEventIOS.cpp:
(WebKit::WebTouchEvent::encode):
(WebKit::WebTouchEvent::decode):
Pipe isPotentialTap through.
- 4:33 PM Changeset in webkit [186147] by
-
- 5 edits1 copy1 delete in tags/Safari-601.1.37.0.1/Source/WebKit2
Roll out r185936. rdar://problem/21597179
- 4:30 PM Changeset in webkit [186146] by
-
- 5 edits in tags/Safari-601.1.37.0.1/Source
Roll out r185939. rdar://problem/21597179
- 4:27 PM Changeset in webkit [186145] by
-
- 2 edits in tags/Safari-601.1.37.0.1/Source/WebCore
Roll out r185951. rdar://problem/21597179
- 4:15 PM Changeset in webkit [186144] by
-
- 5 edits in tags/Safari-601.1.37.0.1/Source
Versioning.
- 4:10 PM Changeset in webkit [186143] by
-
- 1 copy in tags/Safari-601.1.37.0.1
New tag.
- 3:58 PM Changeset in webkit [186142] by
-
- 3 edits in trunk/PerformanceTests
Update the JetStream documentation to reflect the recent changes
https://bugs.webkit.org/show_bug.cgi?id=146474
Reviewed by Geoffrey Garen.
- JetStream/create.rb: Bump the version.
- JetStream/in-depth-TEMPLATE.html: Add cdjs documentation. Remove cordic documentation. Change documentation for splay and mandreel.
- 3:58 PM Changeset in webkit [186141] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: ProfileNode cleanup
https://bugs.webkit.org/show_bug.cgi?id=146472
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Timothy Hatcher.
- UserInterface/Models/ProfileNode.js:
(WebInspector.ProfileNode):
Use Array.prototype.every instead of reduce.
Correct the name of a function to be what callers expect!
- 3:51 PM Changeset in webkit [186140] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] [EFL] Unreviewed build fix after r186118.
Add if PLATFORM(COCOA) back.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):
- WebProcess/WebProcess.h:
- 3:21 PM Changeset in webkit [186139] by
-
- 2 edits in trunk/Source/WebCore
CABackdropFilter should set windowServerAware to false
https://bugs.webkit.org/show_bug.cgi?id=146469
<rdar://problem/21618614>
Reviewed by Simon Fraser.
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::PlatformCALayerCocoa): Set windowServerAware
to false on Mac (it's not available on iOS).
- 3:20 PM Changeset in webkit [186138] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: iOS 8: Profile Nodes not showing in JavaScript Timeline
https://bugs.webkit.org/show_bug.cgi?id=146471
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Brian Burg.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload.profileNodeCallFromPayload):
For legacy backends, convert the startTime to the proper timestamp type.
- 3:19 PM Changeset in webkit [186137] by
-
- 3 edits in trunk/Source/WebCore
Rolling out r175171
https://bugs.webkit.org/show_bug.cgi?id=146470
<rdar://problem/21349934>
Unreviewed, rolling out <http://trac.webkit.org/changeset/175171>. It
wasn't a huge win and Brady says it caused crash at
<rdar://problem/21349934>.
- platform/network/cf/ResourceRequest.h:
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
- 3:19 PM Changeset in webkit [186136] by
-
- 4 edits in trunk/Source/JavaScriptCore
Allow object allocation sinking through GetScope, GetExecutable and SkipScope nodes
https://bugs.webkit.org/show_bug.cgi?id=146431
Reviewed by Filip Pizlo.
- dfg/DFGNode.h:
(JSC::DFG::Node::isFunctionAllocation):
(JSC::DFG::Node::isPhantomFunctionAllocation):
- dfg/DFGObjectAllocationSinkingPhase.cpp:
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
- dfg/DFGPromoteHeapAccess.h:
(JSC::DFG::promoteHeapAccess):
- 3:16 PM Changeset in webkit [186135] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, revert bad WK1 rebaseline done in r186106.
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- 3:00 PM Changeset in webkit [186134] by
-
- 4 edits in trunk/Source
Crash under _layoutForNodeHighlight: when inspecting espn.com
https://bugs.webkit.org/show_bug.cgi?id=146422
Reviewed by Joseph Pecoraro.
Source/WebKit/mac:
When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.
Fix by bailing in this case.
- WebInspector/WebNodeHighlightView.mm:
(-[WebNodeHighlightView _layoutForNodeHighlight:parent:]):
Source/WebKit2:
When inspecting espn.com, MobileSafari sometimes crashes, because
highlight.quads is empty. I was not able to quickly determine why.
Fix by bailing in this case.
- UIProcess/WKInspectorHighlightView.mm:
(-[WKInspectorHighlightView _layoutForNodeHighlight:]):
- 2:45 PM Changeset in webkit [186133] by
-
- 24 edits1 add in trunk/Source
Web Inspector: Reduce rendering frames "Other" time by instrumenting compositing
https://bugs.webkit.org/show_bug.cgi?id=146168
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/protocol/Timeline.json:
New timeline record type for compositing events.
Source/WebCore:
Added Inspector instrumentation for measuring CoreAnimation compositing time. We mark the start of a composite
event when the LayerFlushScheduler triggers a scheduled layer flush. InspectorController now exports a function
for marking the end of the composite event, which should be called during the CA transaction post-commit phase
(based on platform support). Lacking platform support, the event is considered complete after CoreAnimation
runloop observers have run.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::didComposite):
- inspector/InspectorController.h:
New export for instrumentation in WebKit2.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willCompositeImpl):
(WebCore::InspectorInstrumentation::didCompositeImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willComposite):
(WebCore::InspectorInstrumentation::didComposite):
Plumbing for new instrumentation.
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::didComposite):
(WebCore::toProtocol):
- inspector/InspectorTimelineAgent.h:
New Composite event type and instrumentation.
- page/FrameView.cpp:
(WebCore::FrameView::flushCompositingStateIncludingSubframes):
Hook for start of compositing.
- platform/spi/cocoa/QuartzCoreSPI.h:
New header include and interface declaration.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._processRecord):
Added handling for new Composite record type. Paint records with a parent Composite record
are flagged to simplify processing after the event hierarchy is unpacked.
- UserInterface/Images/TimelineRecordComposite.svg: Added.
New composite record icon.
- UserInterface/Models/LayoutTimelineRecord.js:
(WebInspector.LayoutTimelineRecord):
(WebInspector.LayoutTimelineRecord.displayNameForEventType):
(WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Added
Composite record support.
- UserInterface/Models/RenderingFrameTimelineRecord.js:
(WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
Add compositing time when bucketing runloop tasks, ignoring Paint events that are
contained within a Composite event.
- UserInterface/Views/LayoutTimelineOverviewGraph.js:
(WebInspector.LayoutTimelineOverviewGraph.prototype._layoutTimelineRecordAdded):
Add Composite records to paint timeline row.
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
Small unrelated fix.
- UserInterface/Views/TimelineIcons.css:
(.composite-record .icon):
- UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar.timeline-record-type-layout.layout-timeline-record-composite > .segment):
- UserInterface/Views/TimelineRecordTreeElement.js:
(WebInspector.TimelineRecordTreeElement):
New styles and tree element icon.
Source/WebKit2:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Added CA transaction post-commit handlers to instrument end of composite.
- 2:40 PM Changeset in webkit [186132] by
-
- 4 edits in trunk/Source
The bounds on InteractionInformationAtPosition should be more precise
https://bugs.webkit.org/show_bug.cgi?id=146468
-and corresponding-
rdar://problem/20739834
Reviewed by Enrica Casucci and Simon Fraser.
Source/WebCore:
Export absoluteContentQuad().
- rendering/RenderBox.h:
Source/WebKit2:
For links, get the TextQuads from the Range, and for images, look at the
absoluteContentQuad(). All other items can continue to use absoluteBoundingBox.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 2:37 PM Changeset in webkit [186131] by
-
- 2 edits in trunk/Tools
Added myself, Jonathan Davis, as a committer.
- 2:01 PM Changeset in webkit [186130] by
-
- 2 edits in trunk/Websites/webkit.org
Added WebKit feature status page to navigation.
- 1:31 PM Changeset in webkit [186129] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments in r185756.
- html/RubyTextElement.cpp:
(WebCore::RubyTextElement::createElementRenderer):
- 1:03 PM Changeset in webkit [186128] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments in r185916
- platform/LayoutUnit.h:
(WebCore::roundToDevicePixel):
- 12:53 PM Changeset in webkit [186127] by
-
- 2 edits in trunk/Source/WebCore
MediaSession: Use setSessionInternal to set the default media session in HTMLMediaElement's constructor
https://bugs.webkit.org/show_bug.cgi?id=146465
Reviewed by Eric Carlson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- 12:48 PM Changeset in webkit [186126] by
-
- 2 edits in trunk/Source/WebKit2
Disable Spintracer when getting the list of plug-ins
https://bugs.webkit.org/show_bug.cgi?id=146467
rdar://problem/21616640
Reviewed by Tim Horton.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):
- 12:12 PM Changeset in webkit [186125] by
-
- 2 edits in trunk/Source/WebKit2
Java Plugin cannot launch JavaUpdater.app after renaming
https://bugs.webkit.org/show_bug.cgi?id=146464
rdar://problem/19747153
Reviewed by Tim Horton.
Check for both "JavaUpdater.app" and "Java Updater.app".
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isJavaUpdaterURL):
- 11:26 AM Changeset in webkit [186124] by
-
- 8 edits in trunk/Source/WebKit/mac
Remove the WK_ENABLE_FORMAL_DELEGATE_PROTOCOLS ifdefs now that this is always true
https://bugs.webkit.org/show_bug.cgi?id=146462
Reviewed by Dan Bernstein.
- Misc/WebDownload.h:
- WebView/WebFrameLoadDelegate.h:
- WebView/WebPolicyDelegate.h:
- WebView/WebResourceLoadDelegate.h:
- WebView/WebUIDelegate.h:
- WebView/WebView.h:
- postprocess-headers.sh:
- 11:10 AM Changeset in webkit [186123] by
-
- 5 edits in trunk/Source/WebCore
Media Session: implement algorithm for updating a media element's session (6.1)
https://bugs.webkit.org/show_bug.cgi?id=146460
Reviewed by Darin Adler.
In addition to storing a pointer to the new media session, we now:
- pause the media element if it is 'active' in the current media session
- remove the media element from the current media session
- release the current media session if there are no more active media elements
- set the default media session if the new media session is null
- update the 'kind' attribute to match the kind of the new media session
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::isMediaElementActive):
(WebCore::MediaSession::hasActiveMediaElements):
- Modules/mediasession/MediaSession.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSession):
(WebCore::HTMLMediaElement::setSessionInternal):
- html/HTMLMediaElement.h:
- 11:08 AM Changeset in webkit [186122] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Avoid taking a useless / blank navigation snapshot when navigating after restoring sessionState
https://bugs.webkit.org/show_bug.cgi?id=146446
<rdar://problem/21584231>
Reviewed by Darin Adler.
We currently take a useless / blank navigation snapshot when navigating
after restoring the back / forward list from a sessionState object.
This is because we get a current HistoryItem from the sessionState
which we have never really navigated to. We then take a navigation
snapshot for the current HistoryItem when navigating away as we usually
do. However, in this case, the HistoryItem was imported and there is
nothing to snapshot.
Taking this snapshot is not only wasteful, it can also potentially
overwrite the snapshot that was set by the client using
WKWebView._saveBackForwardSnapshotForItem() SPI.
To address the problem, this patch suppresses navigation snapshotting
after restoring the back / forward list from a session state and until
the next load is committed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::recordNavigationSnapshot):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- 10:32 AM Changeset in webkit [186121] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] webViewAddMessageToConsole always gets 1 for isError
https://bugs.webkit.org/show_bug.cgi?id=146457
<rdar://problem/21606395>
Reviewed by Zalan Bujtas.
- WebCoreSupport/WebChromeClient.cpp:
(messageIsError): Added.
(WebChromeClient::addMessageToConsole): Only pass true for
isError if the message is an error message.
- 10:20 AM Changeset in webkit [186120] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: iOS 8: Uncaught Exception expanding Object Prototype
https://bugs.webkit.org/show_bug.cgi?id=146427
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Timothy Hatcher.
- UserInterface/Views/ObjectTreePropertyTreeElement.js:
(WebInspector.ObjectTreePropertyTreeElement.prototype._updateProperties):
- UserInterface/Views/ObjectTreeView.js:
(WebInspector.ObjectTreeView.prototype._updateProperties):
We are supposed to receive value properties for proto properties
so that we can immediately start showing information about the property.
When that is not the case, which appeared to only be on legacy
backends for the top level prototype, just ignore it.
- 10:16 AM Changeset in webkit [186119] by
-
- 6 edits in trunk/Source/WebInspectorUI
Web Inspector: Misc. Timeline cleanup
https://bugs.webkit.org/show_bug.cgi?id=146430
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-30
Reviewed by Timothy Hatcher.
- UserInterface/Models/Timeline.js:
(WebInspector.Timeline.prototype.reset):
Nobody listens for this event. Just remove it.
- UserInterface/Models/TimelineRecording.js:
Avoiding doing multiple lookups.
- UserInterface/Views/TimelineDataGridNode.js:
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
- UserInterface/Views/TimelineView.js:
(WebInspector.TimelineView.prototype.updateLayout):
Eliminate some unnecessary deletes.
- 10:12 AM Changeset in webkit [186118] by
-
- 13 edits in trunk/Source
Get rid of unused WKSI functions
https://bugs.webkit.org/show_bug.cgi?id=146443
Reviewed by Tim Horton.
Source/WebCore:
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::platformAddPathForRoundedRect):
Just call CGPathAddRoundedRect directly.
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired):
- WebProcess/WebProcess.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::destroyRenderingResources):
- 9:39 AM Changeset in webkit [186117] by
-
- 2 edits in trunk/Tools
Unreviewed build fix.
- Scripts/update-webkit-dependency: Try to build even if we cannot connect
to developer.apple.com to get update libraries.
- 9:31 AM Changeset in webkit [186116] by
-
- 5 edits in tags/Safari-601.1.37.1.1/Source
Versioning.
- 9:27 AM Changeset in webkit [186115] by
-
- 1 copy in tags/Safari-601.1.37.1.1
New tag.
- 4:26 AM Changeset in webkit [186114] by
-
- 3 edits in trunk/Source/WebKit/win
[WinCairo] Compile error, WebEditorClient::didApplyStyle() should not have any parameters.
https://bugs.webkit.org/show_bug.cgi?id=146450
Reviewed by Csaba Osztrogonác.
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::shouldApplyStyle):
(WebEditorClient::didApplyStyle):
- WebCoreSupport/WebEditorClient.h:
- 2:53 AM Changeset in webkit [186113] by
-
- 4 edits in trunk
[Streams API] Finish pulling must always be done asynchronously as it is the expected promise behavior (according to the spec)
https://bugs.webkit.org/show_bug.cgi?id=146408
Reviewed by Darin Adler.
Source/WebCore:
Current tests cover the case already.
- Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::pull): Call finishPull() in a postTask to delay it and simulate the promise
resolution.
LayoutTests:
- streams/reference-implementation/readable-stream-expected.txt: Updated expectation to PASS
- 2:27 AM Changeset in webkit [186112] by
-
- 5 edits in trunk
[Streams API] Synced bad strategy test with reference implementation
https://bugs.webkit.org/show_bug.cgi?id=146411
Reviewed by Darin Adler.
Source/WebCore:
Current tests cover the case.
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::retrieveChunkSize): Check for negative size then running the JavaScript function.
LayoutTests:
- streams/reference-implementation/bad-strategies-expected.txt:
- streams/reference-implementation/bad-strategies.html: There are three tests that are merged into one and a
fourth check is added. Updated expectations accordingly.
- 12:50 AM Changeset in webkit [186111] by
-
- 6 edits in trunk/Source/WebCore
[Streams API] Remove ReadableStream.getReader() custom binding
https://bugs.webkit.org/show_bug.cgi?id=146404
Reviewed by Darin Adler.
Covered by existing tests.
- Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::getReader): Updated to take an exception.
- Modules/streams/ReadableStream.h:
- Modules/streams/ReadableStream.idl: Updated to remove custom binding.
- bindings/js/JSReadableStreamCustom.cpp:
(WebCore::JSReadableStream::getReader): Deleted.
- bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::constructJSReadableStreamReader): Updated to pass an exception to getReader.
- 12:17 AM Changeset in webkit [186110] by
-
- 2 edits in trunk
[CMake] Error when gst-plugins-base is missing is too confusing
https://bugs.webkit.org/show_bug.cgi?id=145682
Reviewed by Carlos Garcia Campos.
- Source/cmake/OptionsGTK.cmake: Error out if the required
GStreamer libraries are not found on the host.
Jun 29, 2015:
- 11:47 PM Changeset in webkit [186109] by
-
- 6 edits in trunk/Source/WebCore
[Streams API] ReadableStreamReader.closed should use DOMPromise
https://bugs.webkit.org/show_bug.cgi?id=146406
Reviewed by Darin Adler.
Added storage of ClosedPromise as Optional of ReadableStream.
Updated code accordingly.
Covered by existing tests.
- Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::clearCallbacks):
(WebCore::ReadableStream::releaseReader):
(WebCore::ReadableStream::changeStateToErrored):
(WebCore::ReadableStream::closed):
- Modules/streams/ReadableStream.h:
- Modules/streams/ReadableStreamReader.cpp:
(WebCore::ReadableStreamReader::closed):
- Modules/streams/ReadableStreamReader.h:
- bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::JSReadableStreamReader::closed):
- 11:02 PM Changeset in webkit [186108] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Unreviewed GTK build fix since r186088 and r186095.
https://bugs.webkit.org/show_bug.cgi?id=146449
- PlatformGTK.cmake:
- UIProcess/API/gtk/PageClientImpl.h:
- 10:33 PM Changeset in webkit [186107] by
-
- 3 edits in trunk/Source/WebCore
[iOS WK2] WKWebViews in Facebook app start off black
https://bugs.webkit.org/show_bug.cgi?id=146445
rdar://problem/21600433
Reviewed by Tim Horton.
If -isOpaque is toggled on a WKWebView, we failed to make the page tiles non-opaque
for a while. After r183775, RenderLayerCompositor::rootBackgroundTransparencyChanged() was called,
but only considered the computed document background color, and not the view transparency.
Fix by having rootBackgroundTransparencyChanged() simply use viewHasTransparentBackground(),
which checks the FrameView transparency. Now we just need to store a transparency bool rather
than the old color (we only checked its alpha anyway).
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundTransparencyChanged):
- 7:38 PM Changeset in webkit [186106] by
-
- 2 edits1 copy in trunk/LayoutTests
Another rebaseline after r186086.
WebKit2 needs the original expected result.
- platform/mac-wk2/editing/style: Copied from LayoutTests/platform/mac/editing/style/unbold-in-bold-expected.txt.
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- 7:05 PM Changeset in webkit [186105] by
-
- 2 edits in trunk/LayoutTests
Rebaseline after r186086.
- platform/mac/editing/style/unbold-in-bold-expected.txt:
- 6:26 PM Changeset in webkit [186104] by
-
- 2 edits in trunk/Source/WebCore
WebKit should use 80% black background for PiP indicator
https://bugs.webkit.org/show_bug.cgi?id=146444
<rdar://problem/21555726>
Reviewed by Sam Weinig.
Change the black background to a slightly less black background.
This also involved making the placard artwork white, in order
to keep it visible against the new grey.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-wireless-playback-status):
(audio::-webkit-media-controls-wireless-playback-status.small):
(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):
- 6:09 PM Changeset in webkit [186103] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed EFL build fix since r186088 and r186095.
- CMakeLists.txt: Remove ConnectionStack.cpp.
- UIProcess/CoordinatedGraphics/WebView.h: Override virtual didFailLoadForMainFrame().
- 5:47 PM Changeset in webkit [186102] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Unable to select the text of an inline error message
https://bugs.webkit.org/show_bug.cgi?id=145813
Reviewed by Timothy Hatcher.
- UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror-linewidget):
- UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.createWidgetForLine):
- 5:40 PM Changeset in webkit [186101] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove harmless error for not getting named flows
https://bugs.webkit.org/show_bug.cgi?id=146417
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Darin Adler.
- UserInterface/Controllers/DOMTreeManager.js:
- 5:37 PM Changeset in webkit [186100] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network errors (404) are missing location link in console messages
https://bugs.webkit.org/show_bug.cgi?id=146442
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Darin Adler.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
Restore behavior of adding a location link for network messages with urls.
- 5:32 PM Changeset in webkit [186099] by
-
- 6 edits in trunk/Source
Flag sync XHRs from the network process so they can be handled appropriately.
<rdar://problem/21579162> and https://bugs.webkit.org/show_bug.cgi?id=146441
Reviewed by Darin Adler.
Source/WebCore:
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::loadingSynchronousXHR): Added so clients of asynchronous
loads can signal they should be treated like synchronous loads at the platform level.
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start): Adjust SchedulingBehavior based on the client.
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::start): Adjust SchedulingBehavior based on the client.
Source/WebKit2:
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::loadingSynchronousXHR): Return isSynchronous().
- 5:27 PM Changeset in webkit [186098] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: iOS 8: Resources Timeline Data does not show up
https://bugs.webkit.org/show_bug.cgi?id=146433
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Timothy Hatcher.
There were a couple issues with initializing the legacy base timestamp
for attempting to dynamically compute monotonically increasing timestamps
for timeline events for legacy backends.
- Sometimes legacy timestamps were in seconds since epochs, sometimes milliseconds. The frontend did not handle both.
- On navigations, even while resetting the base timestamp for the first new record received, the main resource still had a will send request time computed from the previous page's time system. This patch re-uses the original timestamp for this main resource as the new base and all future records are computed relative to this.
- UserInterface/Controllers/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
- UserInterface/Models/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.get originalRequestWillBeSentTimestamp):
For legacy timestamp calculations, save the original request will be sent
timestamp on the Resource in case it is needed.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._loadNewRecording):
When auto-starting a new recording for a navigation / reload, use the
main resource's request will be sent timestamp as the new base.
- UserInterface/Models/TimelineRecording.js:
Address legacy timeline timestamps by handling both legacy timestamps
that may be seconds / milliseconds.
- 5:24 PM Changeset in webkit [186097] by
-
- 2 edits in trunk/Source/WebCore
AX: PlatformSpeechSynthesizer code doesn't catch Objective-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=146419
Reviewed by Simon Fraser.
Make sure ObjC exception resulting from calling into the platform cause problems in WebKit.
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
(-[WebSpeechSynthesisWrapper speakUtterance:]):
(-[WebSpeechSynthesisWrapper pause]):
(-[WebSpeechSynthesisWrapper resume]):
(-[WebSpeechSynthesisWrapper cancel]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didStartSpeechUtterance:]):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::pause):
- 5:15 PM Changeset in webkit [186096] by
-
- 2 edits in trunk/Source/WebKit2
Remove an empty group from the Xcode project.
- WebKit2.xcodeproj/project.pbxproj:
- 4:46 PM Changeset in webkit [186095] by
-
- 4 edits2 deletes in trunk/Source/WebKit2
Get rid of ConnectionStack
https://bugs.webkit.org/show_bug.cgi?id=146437
Reviewed by Andreas Kling.
Just use a TemporaryChange and a static variable instead.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::setGlobalException):
(WebKit::WebProcessConnection::didReceiveMessage):
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- Shared/ConnectionStack.cpp: Removed.
(WebKit::ConnectionStack::singleton): Deleted.
- Shared/ConnectionStack.h: Removed.
(WebKit::ConnectionStack::current): Deleted.
(WebKit::ConnectionStack::CurrentConnectionPusher::CurrentConnectionPusher): Deleted.
(WebKit::ConnectionStack::CurrentConnectionPusher::~CurrentConnectionPusher): Deleted.
- WebKit2.xcodeproj/project.pbxproj:
- 4:14 PM Changeset in webkit [186094] by
-
- 2 edits in trunk/Source/WebCore
Removing an element from a media session should also remove it from the sets of active participating elements
https://bugs.webkit.org/show_bug.cgi?id=146420
Reviewed by Eric Carlson.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::removeMediaElement):
- 4:08 PM Changeset in webkit [186093] by
-
- 2 edits in trunk/WebKitLibraries
[Win] Activate SSE support for 32-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=144923
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-29
Reviewed by Brent Fulgham.
- win/tools/vsprops/common.props:
- 4:01 PM Changeset in webkit [186092] by
-
- 5 edits in trunk/Source/WebKit2
Fix the build.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didFailLoadForMainFrame]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didFailLoadForMainFrame):
- 3:59 PM Changeset in webkit [186091] by
-
- 12 edits in trunk
Temporarily disable PICTURE_SIZES
https://bugs.webkit.org/show_bug.cgi?id=146435
<rdar://problem/21087013>
Source/JavaScriptCore:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
Temporarily disable PICTURE_SIZES until Safari branches.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Reviewed by Tim Horton.
Temporarily disable PICTURE_SIZES because it causes problems with out
of date <picture> polyfills.
- wtf/FeatureDefines.h:
LayoutTests:
Reviewed by Tim Horton.
Skip HTMLImageElement.sizes tests.
- 3:42 PM Changeset in webkit [186090] by
-
- 3 edits in trunk/Source/WebCore
Fix the build.
- editing/cocoa/HTMLConverter.mm:
- platform/spi/cocoa/NSAttributedStringSPI.h:
- 3:35 PM Changeset in webkit [186089] by
-
- 2 edits in trunk/Source/WebCore
Fix the build.
- platform/spi/cocoa/NSAttributedStringSPI.h:
- 3:07 PM Changeset in webkit [186088] by
-
- 10 edits in trunk/Source/WebKit2
Don't try to access a possibly deallocated WebFrameProxy object
https://bugs.webkit.org/show_bug.cgi?id=146428
rdar://problem/21446364
Reviewed by Tim Horton.
Make sure to call isMainFrame before calling out to the client inside
WebPageProxy::didFailLoadForFrame, matching what we do for WebPageProxy::didFinishLoadForFrame.
Also, add a ViewGestureController::didFailLoadForMainFrame function and call that instead of
calling didFinishLoadForMainFrame in the failure case.
- UIProcess/API/mac/WKView.mm:
(-[WKView _didFailLoadForMainFrame]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFailLoadForFrame):
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::mainFrameLoadDidReachTerminalState):
(WebKit::ViewGestureController::didFinishLoadForMainFrame): Deleted.
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didFailLoadForMainFrame):
- UIProcess/mac/ViewGestureController.h:
(WebKit::ViewGestureController::didFinishLoadForMainFrame):
(WebKit::ViewGestureController::didFailLoadForMainFrame):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::mainFrameLoadDidReachTerminalState):
(WebKit::ViewGestureController::didFinishLoadForMainFrame): Deleted.
- 2:56 PM Changeset in webkit [186087] by
-
- 2 edits in trunk/Source/WebKit2
Disable default gesture recognizers on preview.
https://bugs.webkit.org/show_bug.cgi?id=146424
rdar://problem/21572828
We should disable default gesture recognizers on preview, to avoid activating links or
triggering touch events accidentally. We can enable them after preview finishes.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-06-29
Reviewed by Beth Dakin.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]):
(-[WKContentView didDismissPreviewViewController:committing:]):
- 2:38 PM Changeset in webkit [186086] by
-
- 20 edits3 adds in trunk/Source
Font panel doesn't get updated when bolding text via cmd+b in Mail on OS X
https://bugs.webkit.org/show_bug.cgi?id=146379
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by WebKit not updating the font panel when the typing style changes.
There was also a bug that WebKit never updated font attributes on OS X.
Fixed the bugs by always updating the font panel after applying style instead of only
when the selection changes and setting the font attributes.
I tried really had to write a WebKit API test but I couldn't get it to work so there are
no new tests :(
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp:
(WebCore::Editor::applyStyle):
(WebCore::Editor::shouldApplyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::Editor::applyStyleToSelection):
(WebCore::Editor::applyParagraphStyleToSelection):
(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::document):
(WebCore::Editor::styleForSelectionStart): Deleted.
- editing/Editor.h:
- editing/cocoa/EditorCocoa.h: Added. Shares the declaration for NSUnderlineStyle in iOS.
- editing/cocoa/EditorCocoa.mm: Added.
(WebCore::Editor::styleForSelectionStart): Moved from Editor.cpp
(WebCore::Editor::getTextDecorationAttributesRespectingTypingStyle): Extracted from iOS's
fontAttributesForSelectionStart implementation.
- editing/cocoa/HTMLConverter.mm:
- editing/ios/EditorIOS.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- loader/EmptyClients.h:
- page/EditorClient.h:
Source/WebKit/mac:
Update the font panel when newly added EditorClient::didApplyStyle is called. Also set the font attributes
in _updateFontPanel so that underline and strike through states will be reflected.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldApplyStyle):
(updateFontPanelIfNeeded): Extracted from respondToChangedContents.
(WebEditorClient::didApplyStyle): Added.
(WebEditorClient::respondToChangedContents):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _updateFontPanel]): Sets font attributes as well as font.
Source/WebKit/win:
- WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::didApplyStyle): Added.
- WebCoreSupport/WebEditorClient.h:
Source/WebKit2:
Since font panel doesn't open in WebKit2 at the moment, just add an empty implementation of didApplyStyle
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didApplyStyle):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebPage/WebPage.h:
- 2:11 PM Changeset in webkit [186085] by
-
- 2 edits in trunk/Tools
Add timeout in run-webkit-tests for launching the simulator
https://bugs.webkit.org/show_bug.cgi?id=146371
Reviewed by Darin Adler.
Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
for the otherwise infinitely patient wait_until_device_is_in_state method.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator.DeviceState):
(Simulator):
(Simulator.wait_until_device_is_in_state):
(Simulator.device_state):
- 2:01 PM Changeset in webkit [186084] by
-
- 3 edits in trunk/Source/WebCore
MediaSession: use a HashSet for the collection of participating elements
https://bugs.webkit.org/show_bug.cgi?id=146421
Reviewed by Eric Carlson.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::addMediaElement):
(WebCore::MediaSession::removeMediaElement):
- Modules/mediasession/MediaSession.h:
- 1:53 PM Changeset in webkit [186083] by
-
- 14 edits in trunk/Source
Setting to enable/disable media controls sizing on page zoom
https://bugs.webkit.org/show_bug.cgi?id=146423
<rdar://problem/18379634>
Reviewed by Eric Carlson.
Add a new setting "MediaControlsScaleWithPageZoom" that can disable
the behaviour we currently implement on iOS, where the media controls
attempt to remain at a fixed size independent of page zoom.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Do not
set this value to true if the new setting is disabled.
- page/Settings.cpp:
- page/Settings.in: Add the new setting.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Initialize to false on iOS, true otherwise.
(-[WebPreferences mediaControlsScaleWithPageZoom]):
(-[WebPreferences setMediaControlsScaleWithPageZoom:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h: Initialize to false on iOS, true otherwise.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMediaControlsScaleWithPageZoom):
(WKPreferencesGetMediaControlsScaleWithPageZoom):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 12:56 PM Changeset in webkit [186082] by
-
- 10 edits in trunk/Source/WebKit2
[WK2][iOS] Swipe gesture snapshot stays up for 3 seconds when swiping back after top-hit navigation
https://bugs.webkit.org/show_bug.cgi?id=146415
<rdar://problem/21595801>
Reviewed by Tim Horton.
Swipe gesture snapshot previously stayed up for 3 seconds when swiping
back after a top-hit navigation. This is because we do not restore the
scroll position in this case and the ViewGestureController was waiting
for the scroll position to be restored before taking down the snapshot.
This patch adds a fail-safe mechanism so that the WebProcess can let
the UIProcess know (via a CouldNotRestorePageState IPC) that the page
state (including scroll position) could not be restored so that it can
let the ViewGestureController it should not wait for the scroll
position to be restored.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _couldNotRestorePageState]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::couldNotRestorePageState):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::couldNotRestorePageState):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::restorePageState):
- 12:52 PM Changeset in webkit [186081] by
-
- 32 edits10 adds2 deletes in trunk
WebRTC: Update the MediaStream API
https://bugs.webkit.org/show_bug.cgi?id=146313
Reviewed by Eric Carlson.
Source/WebCore:
Update the MediaStream API (MediaStream, MediaStreamTrack and
RealtimeMediaSource) to match the Media Capture and Stream
specification [1]. Notable changes:
Updated event handling to synchronously update corresponding
state/attributes as events are dispatched.
Removed 'new' state from MediaStreamTrack. A track is either 'live' or
'ended'. As a consequence 'started' event is also removed.
MediaStreamTrack always has a source (disconnected source concept was
removed from the spec). Therefore, more state can be kept at the source
without going away.
Calculate MediaStream.active internally, from the track set, instead of
setting it externally.
Updated RealtimeMediaSource Observer interface.
Replaced MediaStream's separate audio and video track lists with a
single track set (more aligned with spec).
Updated MediaStream constructor to adopt instead of clone track
arguments (or tracks from MediaStream argument).
Removed MediaStreamTrack.getSources() and corresponding test (removed
from spec).
Test status: 3 added, 8 existing enabled (some updated) and 1 removed.
[1] http://w3c.github.io/mediacapture-main/archives/20150523/getusermedia.html
Tests: fast/mediastream/MediaStreamTrack-clone.html
fast/mediastream/MediaStreamTrack-kind.html
fast/mediastream/MediaStreamTrack-stop.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::getAudioTracks):
(WebCore::MediaStream::getVideoTracks):
(WebCore::MediaStream::getTracks):
(WebCore::MediaStream::contextDestroyed):
(WebCore::MediaStream::trackDidEnd):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::didAddTrackToPrivate):
(WebCore::MediaStream::didRemoveTrackFromPrivate):
(WebCore::MediaStream::internalAddTrack):
(WebCore::MediaStream::internalRemoveTrack):
(WebCore::MediaStream::scheduleActiveStateChange):
(WebCore::MediaStream::activityEventTimerFired):
(WebCore::MediaStream::trackVectorForType):
(WebCore::MediaStream::~MediaStream): Deleted.
(WebCore::MediaStream::registry): Deleted.
(WebCore::MediaStream::addObserver): Deleted.
(WebCore::MediaStream::removeObserver): Deleted.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::id):
(WebCore::MediaStreamTrack::label):
(WebCore::MediaStreamTrack::enabled):
(WebCore::MediaStreamTrack::setEnabled):
(WebCore::MediaStreamTrack::muted):
(WebCore::MediaStreamTrack::readonly):
(WebCore::MediaStreamTrack::remote):
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore::MediaStreamTrack::clone):
(WebCore::MediaStreamTrack::stopProducingData):
(WebCore::MediaStreamTrack::states):
(WebCore::MediaStreamTrack::getCapabilities):
(WebCore::MediaStreamTrack::applyConstraints):
(WebCore::MediaStreamTrack::trackEnded):
(WebCore::MediaStreamTrack::trackMutedChanged):
(WebCore::MediaStreamTrack::stop):
(WebCore::MediaStreamTrack::getConstraints): Deleted.
(WebCore::MediaStreamTrack::addObserver): Deleted.
(WebCore::MediaStreamTrack::removeObserver): Deleted.
(WebCore::MediaStreamTrack::configureTrackRendering): Deleted.
(WebCore::MediaStreamTrack::activeDOMObjectName): Deleted.
(WebCore::MediaStreamTrack::canSuspendForPageCache): Deleted.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Deleted.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::didCreateStream):
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::tracks):
(WebCore::MediaStreamPrivate::updateActiveState):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):
- platform/mediastream/MediaStreamPrivate.h:
(WebCore::MediaStreamPrivate::active): Deleted.
- platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::create):
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::~MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::label):
(WebCore::MediaStreamTrackPrivate::setEnabled):
(WebCore::MediaStreamTrackPrivate::endTrack):
(WebCore::MediaStreamTrackPrivate::clone):
(WebCore::MediaStreamTrackPrivate::type):
(WebCore::MediaStreamTrackPrivate::applyConstraints):
(WebCore::MediaStreamTrackPrivate::sourceStopped):
(WebCore::MediaStreamTrackPrivate::sourceMutedChanged):
(WebCore::MediaStreamTrackPrivate::preventSourceFromStopping):
(WebCore::MediaStreamTrackPrivate::muted): Deleted.
(WebCore::MediaStreamTrackPrivate::readonly): Deleted.
(WebCore::MediaStreamTrackPrivate::remote): Deleted.
(WebCore::MediaStreamTrackPrivate::constraints): Deleted.
(WebCore::MediaStreamTrackPrivate::states): Deleted.
(WebCore::MediaStreamTrackPrivate::capabilities): Deleted.
- platform/mediastream/MediaStreamTrackPrivate.h:
(WebCore::MediaStreamTrackPrivate::id):
(WebCore::MediaStreamTrackPrivate::ended):
(WebCore::MediaStreamTrackPrivate::enabled):
(WebCore::MediaStreamTrackPrivate::setClient):
(WebCore::MediaStreamTrackPrivate::source): Deleted.
(WebCore::MediaStreamTrackPrivate::client): Deleted.
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::RealtimeMediaSource):
(WebCore::RealtimeMediaSource::reset):
(WebCore::RealtimeMediaSource::setMuted):
(WebCore::RealtimeMediaSource::readonly):
(WebCore::RealtimeMediaSource::stop):
(WebCore::RealtimeMediaSource::requestStop):
(WebCore::RealtimeMediaSource::addObserver): Deleted.
(WebCore::RealtimeMediaSource::removeObserver): Deleted.
- platform/mediastream/RealtimeMediaSource.h:
(WebCore::RealtimeMediaSource::stopped):
(WebCore::RealtimeMediaSource::id): Deleted.
(WebCore::RealtimeMediaSource::muted): Deleted.
(WebCore::RealtimeMediaSource::setReadonly): Deleted.
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::createMediaStream): Deleted.
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream): Deleted.
LayoutTests:
Test status: 3 added, 8 existing enabled (some updated) and 1 removed.
- TestExpectations:
- fast/mediastream/MediaStream-add-ended-tracks-expected.txt:
- fast/mediastream/MediaStream-add-ended-tracks.html:
- fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
- fast/mediastream/MediaStream-add-remove-tracks.html:
- fast/mediastream/MediaStream-add-tracks-to-inactive-stream.html:
- fast/mediastream/MediaStream-clone-expected.txt: Added.
- fast/mediastream/MediaStream-clone.html:
- fast/mediastream/MediaStream-construct-with-ended-tracks-expected.txt: Added.
- fast/mediastream/MediaStream-construct-with-ended-tracks.html:
- fast/mediastream/MediaStream-getTracks-expected.txt:
- fast/mediastream/MediaStream-getTracks.html:
- fast/mediastream/MediaStreamConstructor.html:
- fast/mediastream/MediaStreamTrack-clone-expected.txt: Added.
- fast/mediastream/MediaStreamTrack-clone.html: Added.
- fast/mediastream/MediaStreamTrack-getSources-expected.txt: Removed.
- fast/mediastream/MediaStreamTrack-getSources.html: Removed. Tested method removed from spec.
- fast/mediastream/MediaStreamTrack-kind-expected.txt: Added.
- fast/mediastream/MediaStreamTrack-kind.html: Added.
- fast/mediastream/MediaStreamTrack-stop-expected.txt: Added.
- fast/mediastream/MediaStreamTrack-stop.html: Added.
- fast/mediastream/MediaStreamTrackEvent-constructor-expected.txt:
- fast/mediastream/MediaStreamTrackEvent-constructor.html:
- fast/mediastream/resources/getUserMedia-helper.js: Added.
(.reject):
(getUserMedia):
(defaultRejectOrCatch):
- platform/gtk/TestExpectations:
- 12:43 PM Changeset in webkit [186080] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION: Web Inspector: Jump to Definition is broken
https://bugs.webkit.org/show_bug.cgi?id=146376
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-29
Reviewed by Timothy Hatcher.
- UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject):
Allow changing tabs when jumping to function definition.
- 12:40 PM Changeset in webkit [186079] by
-
- 14 edits4 adds in trunk
Make the NFA transitions range-based
https://bugs.webkit.org/show_bug.cgi?id=146338
Reviewed by Alex Christensen.
Source/WebCore:
Change the NFA to use range based transition for any kind of transition.
The fallback transition is also absorbed as ranges.
Previously, the NFA would only have single transitions and a fallback
transition for all cases not covered by single transitions.
The problem with that design was that character ranges (e.g. [a-z]) were
extended as individual transitions. Something like [a] would cover
most of the alphabet with transitions.
When converting the NFA to DFA, the time is proportional to the number of states
multiplied by the number of transitions. With many individual transitions,
the run time was an order of magnitude higher than what we want.
This patch changes the NFA to only handle ranges of characters. A single transition
becomes a range with the character as first and last character in the range
('a' becomes 'a' to 'a').
Ranges of characters are handled direclty (e.g. [a-z] becomes a single 'a' to 'z' transition).
In the context of the state machines, ranges have identifies (the target of the transitions).
When two ranges collide, they have to be split such that each part retain its target
except the intersection that gets the union of the targets.
Handling the union of ranges efficiently is critical because we have to do
it for every NFA node in any subset when building the DFA. The helper
class that does that is MutableRange.
The union of ranges is done efficiently because of preconditions on our list of ranges:
-The ranges must be sorted.
-No range in a list can intersect any other range in the same list.
To merge two ranges, we can go over them in order and split them part by part.
It is easy to find what goes where because they are both sorted and we can
compare the characters of each to know how to move forward.
The time to merge 2 range list is proportional to O(n+m) where 'n' and 'm' are
the number of ranges in each list.
Since taking the union of two lists usually create new ranges, we have to allocate
those somewhere efficiently. To do that, MutableRange support an inline capacity,
which is used for the NFAToDFA Convertion.
---
With ranges, the NFA-to-DFA conversion changes very little:
-Each NFA nodes contains a list of ranges and each range has a list of targets.
-The subset construction select any number of NFA nodes corresponding to
a single deterministic state.
-For the subset, we can use MutableRange to merge the ranges of every
NFA node in the set. The resulting list has rangeis with targets corresponding
to the union of all the transitions.
-We go over all the ranges the same way we used to go over the transitions.
Since the DFA does not support ranges, the ranges are spread as individual
transitions + fallback transition.
---
With the efficient merging solved, we still need the actual NFA to use ranges
instead of individual transitions.
I could have used MutableRange for that but it is not the most compact
way to represent ranges that do not need merging.
Instead, the NFA uses a custom structure: ImmutableNFA. It is basically
the same thing, but in that one you cannot change a list of range
after creating it.
Consequently, the sorted ranges in ImmutableNFA are also subsequent
in memory, which is really nice to go over them efficiently
when merging ranges in the NFA-to-DFA conversion. :)
When building the NFA, we don't know all the transitions when creating
each node, BUT we know that we have very few node "unfinished" at any
time. Since we build by going depth-first in the prefix-tree, we only
have the max-depth of live nodes in the worst case.
To help building the NFA out of the prefix tree, we have
ImmutableNFANodeBuilder. It keeps all the informations about a NFA node,
but in a non-compact, mutable form. When a ImmutableNFANodeBuilder
is destroyed, it serialize the information into the immutable NFA.
- WebCore.xcodeproj/project.pbxproj:
- contentextensions/CombinedURLFilters.cpp:
(WebCore::ContentExtensions::generateNFAForSubtree):
(WebCore::ContentExtensions::CombinedURLFilters::processNFAs):
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
- contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::empty):
- contentextensions/DFA.h:
- contentextensions/ImmutableNFA.h: Added.
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator*):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator->):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator==):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator!=):
(WebCore::ContentExtensions::ImmutableNFA::ConstTargetIterator::operator++):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstTargets::begin):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstTargets::end):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator*):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator->):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator==):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator!=):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::operator++):
(WebCore::ContentExtensions::ImmutableNFA::ConstRangeIterator::data):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstRange::begin):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstRange::end):
(WebCore::ContentExtensions::ImmutableNFA::IterableConstRange::debugPrint):
(WebCore::ContentExtensions::ImmutableNFA::transitionsForNode):
(WebCore::ContentExtensions::ImmutableNFA::root):
(WebCore::ContentExtensions::ImmutableNFA::finalize):
(WebCore::ContentExtensions::ImmutableNFA::memoryUsed):
- contentextensions/ImmutableNFANodeBuilder.h: Added.
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::ImmutableNFANodeBuilder):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::~ImmutableNFANodeBuilder):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::addTransition):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::addEpsilonTransition):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::setActions):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::operator=):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::finalize):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::sinkActions):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::sinkTransitions):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::sinkEpsilonTransitions):
- contentextensions/MutableRange.h: Added.
(WebCore::ContentExtensions::MutableRange::MutableRange):
(WebCore::ContentExtensions::MutableRange::operator=):
(WebCore::ContentExtensions::MutableRange::size):
- contentextensions/MutableRangeList.h: Added.
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator*):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator->):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator==):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator!=):
(WebCore::ContentExtensions::MutableRangeList::ConstIterator::operator++):
(WebCore::ContentExtensions::MutableRangeList::begin):
(WebCore::ContentExtensions::MutableRangeList::end):
(WebCore::ContentExtensions::MutableRangeList::appendRange):
(WebCore::ContentExtensions::MutableRangeList::extend):
(WebCore::ContentExtensions::MutableRangeList::isEmpty):
(WebCore::ContentExtensions::MutableRangeList::clear):
(WebCore::ContentExtensions::MutableRangeList::debugPrint):
(WebCore::ContentExtensions::MutableRangeList::insertBetween):
(WebCore::ContentExtensions::MutableRangeList::initializeFrom):
- contentextensions/NFA.cpp:
(WebCore::ContentExtensions::NFA::debugPrintDot):
(WebCore::ContentExtensions::NFA::NFA): Deleted.
(WebCore::ContentExtensions::NFA::createNode): Deleted.
(WebCore::ContentExtensions::NFA::memoryUsed): Deleted.
(WebCore::ContentExtensions::NFA::addTransition): Deleted.
(WebCore::ContentExtensions::NFA::addEpsilonTransition): Deleted.
(WebCore::ContentExtensions::NFA::addTransitionsOnAnyCharacter): Deleted.
(WebCore::ContentExtensions::NFA::setActions): Deleted.
(WebCore::ContentExtensions::NFA::graphSize): Deleted.
(WebCore::ContentExtensions::NFA::restoreToGraphSize): Deleted.
(WebCore::ContentExtensions::printRange): Deleted.
(WebCore::ContentExtensions::printTransitions): Deleted.
- contentextensions/NFA.h:
(WebCore::ContentExtensions::NFA::root): Deleted.
(WebCore::ContentExtensions::NFA::addRuleId): Deleted.
- contentextensions/NFANode.h:
- contentextensions/NFAToDFA.cpp:
(WebCore::ContentExtensions::epsilonClosureExcludingSelf):
(WebCore::ContentExtensions::resolveEpsilonClosures):
(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetSource::NodeIdSetToUniqueNodeIdSetSource):
(WebCore::ContentExtensions::NodeIdSetToUniqueNodeIdSetTranslator::translate):
(WebCore::ContentExtensions::DataConverterWithEpsilonClosure::convert):
(WebCore::ContentExtensions::DataConverterWithEpsilonClosure::extend):
(WebCore::ContentExtensions::createCombinedTransition):
(WebCore::ContentExtensions::canUseFallbackTransition):
(WebCore::ContentExtensions::findBestFallbackTarget):
(WebCore::ContentExtensions::getOrCreateDFANode):
(WebCore::ContentExtensions::NFAToDFA::convert):
(WebCore::ContentExtensions::populateTransitions): Deleted.
- contentextensions/NFAToDFA.h:
- contentextensions/Term.h:
(WebCore::ContentExtensions::Term::Term):
(WebCore::ContentExtensions::Term::generateGraph):
(WebCore::ContentExtensions::Term::generateSubgraphForAtom):
(WebCore::ContentExtensions::Term::Term::generateGraph): Deleted.
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
Test some new interesting cases.
- 12:12 PM Changeset in webkit [186078] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: test session attribute of newly-created media elements
https://bugs.webkit.org/show_bug.cgi?id=146412
Reviewed by Eric Carlson.
- media/session/default-session-expected.txt: Added.
- media/session/default-session.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 12:08 PM Changeset in webkit [186077] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][iOS] Add WKWebView private API to save a back/forward snapshot
https://bugs.webkit.org/show_bug.cgi?id=146398
<rdar://problem/21584231>
Reviewed by Dan Bernstein.
Add WKWebView private API to save a back/forward snapshot so that the
client can make sure a back/forward snapshot is available even when
swapping WKWebView upon navigation.
This matches the WKView.saveBackForwardSnapshotForItem API we have on
Mac.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView saveBackForwardSnapshotForItem:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 12:04 PM Changeset in webkit [186076] by
-
- 10 edits in trunk/Source
Binding generator should allow using JSC::Value for "any" parameter in lieu of ScriptValue
https://bugs.webkit.org/show_bug.cgi?id=146403
Reviewed by Darin Adler.
Source/JavaScriptCore:
- bindings/ScriptValue.h: Added implicit conversion to JSC::JSValue.
Source/WebCore:
Covered by existing tests.
Enabling new APIs to use JSC::JSValue by using implicit case from ScriptValue to JSC::JSValue.
Updated binding generator to include ScruptValue header in the needed JSXX.cpp files.
Applied approach to ReadableStreamController.error.
- Modules/streams/ReadableStreamController.h:
(WebCore::ReadableStreamController::error):
- Modules/streams/ReadableStreamController.idl:
- bindings/js/JSReadableStreamControllerCustom.cpp:
(WebCore::constructJSReadableStreamController): Deleted.
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::error):
- bindings/js/ReadableJSStream.h:
- bindings/scripts/CodeGeneratorJS.pm:
(JSValueToNative):
- bindings/scripts/test/JS/JSTestObj.cpp:
- 11:56 AM Changeset in webkit [186075] by
-
- 10 edits1 delete in trunk/Source
Use DISPATCH_SOURCE_TYPE_MEMORYPRESSURE instead of DISPATCH_SOURCE_TYPE_MEMORYSTATUS
https://bugs.webkit.org/show_bug.cgi?id=146413
Source/WebCore:
rdar://problem/21295036
Reviewed by Andreas Kling.
Replace SPI with API.
- WebCore.xcodeproj/project.pbxproj:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::install):
- platform/mac/WebCoreSystemInterface.h:
- platform/spi/cocoa/DispatchSPI.h: Removed.
Source/WebKit/mac:
Reviewed by Andreas Kling.
Replace SPI with API.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- WebView/WebView.mm:
(+[WebView registerForMemoryNotifications]):
Source/WebKit2:
Reviewed by Andreas Kling.
Replace SPI with API.
- UIProcess/ios/WebMemoryPressureHandlerIOS.mm:
(WebKit::WebMemoryPressureHandler::WebMemoryPressureHandler):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- 11:46 AM Changeset in webkit [186074] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Pausing a media element should discard buffered data immediately if under memory pressure.
<https://webkit.org/b/146410>
<rdar://problem/20366883>
Reviewed by Darin Adler.
When moving a media element into paused state, call purgeBufferedDataIfPossible()
right away if the system is under memory pressure.
This ensures that mediaserverd drops its forward-looking frame queue right
away instead of waiting for a new pressure notification.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pauseInternal):
- 10:43 AM Changeset in webkit [186073] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] Hardware Keyboard: All combinations of arrow keys and space key do not scroll the view.
https://bugs.webkit.org/show_bug.cgi?id=146290
rdar://problem/18466015
We don't normally get called by the keyboard to handle the event if we are not
interacting with editable content. In order to receive all the hardware keyboard events
we need to implement _handleKeyUIEvent which is called for every key event
when the view is first responder. This gives us the opportunity to send each keystroke
to the WebProcess to let any Javascript handler intercept it and then perform the default
action for the key combination.
Unfortunately this mechanism does not provide key repeat, which is implemented in the
keyboard layer. In order to have it at least for the arrow keys, we use the keyCommands
mechanism only for those.
Reviewed by Darin Adler.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollByOffset:]):
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView keyCommands]):
(-[WKContentView _arrowKey:]):
(-[WKContentView _handleKeyUIEvent:]):
(-[WKContentView handleKeyEvent:]):
(-[WKContentView handleKeyWebEvent:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
- 10:33 AM Changeset in webkit [186072] by
-
- 3 edits in trunk/Source/WebCore
Media Session: Media elements should report a null session for Default sessions
https://bugs.webkit.org/show_bug.cgi?id=146373
Reviewed by Eric Carlson.
If a media element's current session is a 'Default' media session, its session property should report null in
the JavaScript API.
- Modules/mediasession/MediaSession.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::session):
- 10:18 AM Changeset in webkit [186071] by
-
- 4 edits in trunk
[Mac] Disable QTKit by default.
https://bugs.webkit.org/show_bug.cgi?id=146352
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-06-29
Reviewed by Darin Adler.
Source/WebCore:
Fix the the requirement for enabling QTKit and AVFoundation.
- page/Settings.cpp:
(WebCore::invalidateAfterGenericFamilyChange): Remove the requirement
for enabling QTKit and AVFoundation. The initial state of QTKit should
be disabled on all OS X ports. And the initial state of AVFoundation
should be enabled on all OS X ports.
LayoutTests:
- platform/mac/TestExpectations: Skip media tests which require QTKit on
all OS X ports.
- 9:50 AM Changeset in webkit [186070] by
-
- 2 edits3 adds in trunk/LayoutTests
Test existence of controls on MediaSession
https://bugs.webkit.org/show_bug.cgi?id=146356
Reviewed by Eric Carlson.
- media/session/controls-existence-expected.txt: Added.
- media/session/controls-existence.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 8:22 AM Changeset in webkit [186069] by
-
- 2 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening on 29th Jun.
https://bugs.webkit.org/show_bug.cgi?id=146409
Remove the duplicated results and rebaseline the missing tests.
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-06-29
- platform/efl/TestExpectations:
- platform/efl/editing/execCommand/paste-1-expected.txt: Added.
- platform/efl/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added.
- 3:09 AM Changeset in webkit [186068] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Purge unused favicons from IconDatabase after 30 days.
https://bugs.webkit.org/show_bug.cgi?id=146334
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-29
Reviewed by Gyuyoung Kim.
We need purge unused favicons from IconDatabase for database size control.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performURLImport):
Jun 28, 2015:
- 11:51 PM Changeset in webkit [186067] by
-
- 3 edits in trunk/Source/WebKit2
Fixed the iOS 8.x build after r186066.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::create):
- 11:43 PM Changeset in webkit [186066] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the iOS build after r186059.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- 11:26 PM Changeset in webkit [186065] by
-
- 2 edits27 adds in trunk/LayoutTests
[EFL] Unreviewed add new baseline for missing tests
Some tests need to have own test expectations for EFL port.
- platform/efl/TestExpectations:
- platform/efl/accessibility/auto-filled-value-expected.txt: Added.
- platform/efl/accessibility/img-fallsback-to-title-expected.txt: Added.
- platform/efl/accessibility/internal-link-anchors2-expected.txt: Added.
- platform/efl/accessibility/math-multiscript-attributes-expected.txt: Added.
- platform/efl/accessibility/meter-element-expected.txt: Added.
- platform/efl/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
- platform/efl/compositing/iframes/resizer-expected.txt: Added.
- platform/efl/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.
- platform/efl/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added.
- platform/efl/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
- platform/efl/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
- platform/efl/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt: Added.
- platform/efl/css3/flexbox/flexbox-baseline-margins-expected.txt: Added.
- platform/efl/editing/selection/contains-boundaries-expected.txt: Added.
- platform/efl/editing/selection/mixed-editability-10-expected.txt: Added.
- platform/efl/editing/selection/replaced-boundaries-3-expected.txt: Added.
- platform/efl/editing/style/5065910-expected.txt: Added.
- platform/efl/editing/style/font-family-with-space-expected.txt: Added.
- platform/efl/fast/css/named-images-expected.txt: Added.
- platform/efl/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt: Added.
- platform/efl/ietestcenter/css3/text/textshadow-005-expected.txt: Added.
- platform/efl/printing/media-queries-print-expected.txt: Added.
- platform/efl/printing/setPrinting-expected.txt: Added.
- platform/efl/printing/simultaneous-position-float-change-expected.txt: Added.
- platform/efl/printing/width-overflow-expected.txt: Added.
- platform/efl/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
- 10:29 PM Changeset in webkit [186064] by
-
- 6 edits in trunk/Source/WebCore
Add support for 'Default' media session types
https://bugs.webkit.org/show_bug.cgi?id=146355
Reviewed by Darin Adler.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::MediaSession): Added a new constructor for creating 'Default' media sessions.
(WebCore::MediaSession::kind): 'Default' media sessions are represented by an empty string.
- Modules/mediasession/MediaSession.h:
- dom/Document.cpp:
(WebCore::Document::defaultMediaSession): Lazily construct the default media session.
- dom/Document.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): New media elements are assigned to the 'Default' media session.
- 10:05 PM Changeset in webkit [186063] by
-
- 2 edits in trunk/Source/WebKit2
AX: iOS: Crash at accessibilityObjectForMainFramePlugin()
https://bugs.webkit.org/show_bug.cgi?id=146399
Reviewed by Darin Adler.
Could not reproduce issue, but the invalid address seems to indicate this is a nullptr access is happening when we try to get the plugin of the m_page variable when
it has not been initialized.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::accessibilityObjectForMainFramePlugin):
- 9:47 PM Changeset in webkit [186062] by
-
- 1 edit16 adds in trunk/LayoutTests
[EFL] Unreviewed, gardening.
Add missing expectation results in fast/ directory.
- platform/efl/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
- platform/efl/fast/forms/select-element-focus-ring-expected.txt: Added.
- platform/efl/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
- platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/efl/fast/regions/region-dynamic-after-before-expected.txt: Added.
- platform/efl/fast/regions/region-generated-content-before-after-expected.txt: Added.
- platform/efl/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
- platform/efl/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
- platform/efl/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
- platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
- platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Added.
- platform/efl/fast/ruby/select-ruby-expected.txt: Added.
- 8:18 PM Changeset in webkit [186061] by
-
- 2 edits in trunk/LayoutTests
ASAN crashes in js/regress-141098.html
<http://webkit.org/b/145007>
- TestExpectations: Remove test from skip list as it no longer
crashes with ASan enabled:
- js/regress-141098.html
- 8:18 PM Changeset in webkit [186060] by
-
- 2 edits in trunk/Source/WebKit/mac
[Mac] Remove redundant call to colorUsingColorSpaceName:
https://bugs.webkit.org/show_bug.cgi?id=146397
Reviewed by Alexey Proskuryakov.
- WebView/WebHTMLView.mm:
(extractUnderlines): Remove call to the colorUsingColorSpaceName: method,
since colorFromNSColor already calls it. No need to do it twice.
- 6:19 PM Changeset in webkit [186059] by
-
- 62 edits in trunk/Source/WebKit2
Use Ref/RefPtr instead of PassRefPtr in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=146190
Reviewed by Darin Adler.
As a step to remove PassRefPtr, this patch reduces use of PassRefPtr in WebKit2.
- Shared/API/c/WKContextMenuItem.cpp:
(WKContextMenuItemCreateAsAction):
(WKContextMenuItemCreateAsCheckableAction):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::create):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:
(WebKit::ThreadSafeCoordinatedSurface::create):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::create):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::create):
- Shared/Plugins/NPRemoteObjectMap.h:
- Shared/WebBatteryStatus.h:
(WebKit::WebBatteryStatus::create):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
- Shared/WebContextMenuItem.h:
(WebKit::WebContextMenuItem::create):
- Shared/WebRenderObject.cpp:
(WebKit::WebRenderObject::create):
- Shared/WebRenderObject.h:
(WebKit::WebRenderObject::create):
- UIProcess/API/APINavigationData.h:
(API::NavigationData::create):
- UIProcess/API/APISession.cpp:
(API::Session::createEphemeral):
- UIProcess/API/APISession.h:
- UIProcess/API/APISessionState.cpp:
(API::SessionState::create):
- UIProcess/API/APISessionState.h:
- UIProcess/API/APIUserScript.h:
- UIProcess/API/APIWebsiteDataStore.cpp:
(API::WebsiteDataStore::createNonPersistentDataStore):
(API::WebsiteDataStore::create):
- UIProcess/API/APIWebsiteDataStore.h:
- UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
(WKPageSetPageContextMenuClient):
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCreateFromData):
- UIProcess/API/C/WKUserScriptRef.cpp:
(WKUserScriptCreateWithSource):
- UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:
(-[WKNSURLAuthenticationChallengeSender useCredential:forAuthenticationChallenge:]):
- UIProcess/API/Cocoa/WKProcessGroup.mm:
(-[WKProcessGroup _setAllowsSpecificHTTPSCertificate:forHost:]):
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setAllowsSpecificHTTPSCertificate:forHost:]):
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore nonPersistentDataStore]):
- UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest::create):
- UIProcess/API/efl/ewk_back_forward_list_item_private.h:
(EwkBackForwardListItem::create):
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::create):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu::create):
- UIProcess/API/efl/ewk_download_job_private.h:
(EwkDownloadJob::create):
- UIProcess/API/efl/ewk_file_chooser_request_private.h:
(EwkFileChooserRequest::create):
- UIProcess/API/efl/ewk_form_submission_request_private.h:
(EwkFormSubmissionRequest::create):
- UIProcess/API/efl/ewk_navigation_data_private.h:
(EwkNavigationData::create):
- UIProcess/API/efl/ewk_security_origin_private.h:
(EwkSecurityOrigin::create):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::create):
- UIProcess/Authentication/AuthenticationDecisionListener.h:
(WebKit::AuthenticationDecisionListener::create):
- UIProcess/Authentication/WebCredential.h:
(WebKit::WebCredential::create):
- UIProcess/Authentication/WebProtectionSpace.h:
(WebKit::WebProtectionSpace::create):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::HistoryClient::didNavigateWithNavigationData):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::create):
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Launcher/ProcessLauncher.h:
(WebKit::ProcessLauncher::create):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
- UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::create):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Scrolling/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::create):
- UIProcess/Scrolling/RemoteScrollingTree.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::create):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool):
- UIProcess/efl/WebPopupMenuListenerEfl.h:
(WebKit::WebPopupMenuListenerEfl::create):
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebView::create):
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(WebKit::WebVideoFullscreenManagerProxy::create):
- 5:33 PM Changeset in webkit [186058] by
-
- 3 edits2 deletes in trunk/Source/WebKit2
[Cocoa] Remove _WKSecurityOrigin.{h,mm}
https://bugs.webkit.org/show_bug.cgi?id=146402
Reviewed by Sam Weinig.
- UIProcess/API/Cocoa/WKSecurityOrigin.mm: Declare and define _WKSecurityOrigin here.
(-[WKSecurityOrigin methodSignatureForSelector:]): Moved into a WKBinaryCompatibility
category.
(-[WKSecurityOrigin forwardInvocation:]): Ditto.
- UIProcess/API/Cocoa/_WKSecurityOrigin.h: Removed.
- UIProcess/API/Cocoa/_WKSecurityOrigin.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj: Removed references to _WKSecurityOrigin.{h,mm}.
- 4:30 PM Changeset in webkit [186057] by
-
- 2 edits in trunk/Tools
[Xcode] Use the same environment for command-line and IDE builds
https://bugs.webkit.org/show_bug.cgi?id=146401
Reviewed by Anders Carlsson.
- Scripts/webkitdirs.pm:
(XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
xcodebuild use the same environment Xcode uses.
- 4:07 PM Changeset in webkit [186056] by
-
- 2 edits in trunk/LayoutTests
Fix warning about duplicate test expectation: js/regress-141098.html
Fixes the following warning when running layout tests:
LayoutTests/TestExpectations:523 More specific entry for js/regress-141098.html on line LayoutTests/TestExpectations:523 overrides line LayoutTests/TestExpectations:519. js/regress-141098.html
- TestExpectations: Comment out duplicate:
- js/regress-141098.html
- 3:51 PM Changeset in webkit [186055] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/contentextensions/character-set-basic-support.html as flaky on mac-wk2
- platform/mac-wk2/TestExpectations: Mark ask flaky:
- http/tests/contentextensions/character-set-basic-support.html
- 3:16 PM Changeset in webkit [186054] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Drop buffered data in paused media elements on memory pressure.
<https://webkit.org/b/146369>
<rdar://problem/20366883>
Reviewed by Eric Carlson.
To avoid getting crushed under mediaserverd memory growth when viewing
a page with multiple media elements, add a step to the memory pressure
handler that drops buffered data from all media elements that are
not currently playing.
On a test page with a bunch of embedded YouTube videos, this pass frees
up ~4MB per paused video when the system memory pressure hits.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::allMediaElements):
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::purgeBufferedDataIfPossible):
- html/HTMLMediaElement.h:
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
- 1:36 PM Changeset in webkit [186053] by
-
- 6 edits in tags/Safari-601.1.37.1
Merge r186046. rdar://problem/21581792
- 1:33 PM Changeset in webkit [186052] by
-
- 5 edits in tags/Safari-601.1.37.1/Source
Versioning.
- 1:22 PM Changeset in webkit [186051] by
-
- 1 copy in tags/Safari-601.1.37.1
New Tag.
- 12:09 PM Changeset in webkit [186050] by
-
- 2 edits in trunk
CairoGL should be checked unconditionally
https://bugs.webkit.org/show_bug.cgi?id=146390
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-06-28
Reviewed by Darin Adler.
- Source/cmake/OptionsGTK.cmake: Move check for CairoGL so that
it is run unconditionally; this is necessary because its result
is used later on, outside of any conditions.
- 11:53 AM Changeset in webkit [186049] by
-
- 5 edits3 adds in trunk
Crash: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CachedFrameBase::restore + 333
https://bugs.webkit.org/show_bug.cgi?id=146388
<rdar://problem/21567343>
Reviewed by Darin Adler.
Source/WebCore:
Pages that are currently loading are not supposed to go into the
PageCache. However, PageCache::canCache() only checks if the
FrameLoader's documentLoader is loading. If the subframe is in
provisional load stage, we would fail to detect that the frame is
actually loading because the FrameLoader active documentLoader would
be the provisional documentLoader, not the regular documentLoader.
Therefore, the page would get added to the PageCache and the frame
would keep loading while in the PageCache.
On http://www.audiusa.com/models, this is what was happening. It was
crashing because the subframe would finish loading while in the
PageCache, in which case we would fire the 'load' event and the
content 'load' event handler would then proceed to remove the iframe.
Upon restoring the PageCache entry, we would run into trouble as we
would have a CachedFrame whose Frame has been removed.
The solution proposed is to prevent page-caching if a subframe is in
provisional load stage.
Test: http/tests/navigation/page-cache-iframe-provisional-load.html
- history/PageCache.cpp:
(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::provisionalLoadKey):
- page/DiagnosticLoggingKeys.h:
LayoutTests:
Add layout test to cover the case where a subframe is currently in
provisional load stage when checking if the page if page-cacheable.
The test also removes the iframe once loaded in order to cause a crash
if the frame were to finish loading while in the page cache.
- http/tests/navigation/page-cache-iframe-provisional-load-expected.txt: Added.
- http/tests/navigation/page-cache-iframe-provisional-load.html: Added.
- http/tests/navigation/resources/page-cache-helper-slow.html: Added.
- 10:57 AM Changeset in webkit [186048] by
-
- 2 edits in trunk/Source/WebKit2
Tried to fix the EFL buid after r186046.
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl):
- 9:18 AM Changeset in webkit [186047] by
-
- 5 edits in trunk
[ES6] Implement ES6 arrow function syntax. No Line terminator between function parameters and =>
https://bugs.webkit.org/show_bug.cgi?id=146394
Source/JavaScriptCore:
Patch by Aleksandr Skachkov <gskachkov@gmail.com> on 2015-06-28
Reviewed by Yusuke Suzuki.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
LayoutTests:
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2015-06-28
Reviewed by Yusuke Suzuki.
- js/arrowfunction-syntax-errors-expected.txt:
- js/script-tests/arrowfunction-syntax-errors.js:
- 9:05 AM Changeset in webkit [186046] by
-
- 6 edits in trunk
REGRESSION (r185915): Source-incompatible change in WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=146396
Reviewed by Anders Carlsson.
Source/WebKit2:
- UIProcess/API/C/WKPageUIClient.h: Renamed
runJavaScript{Alert,Confirm,Prompt}_deprecatedForUseWithV0 back to runJavaScript{Alert,Confirm,Prompt}
in client versions prior to V5.
Tools:
- TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
(TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
(TestWebKitAPI::TEST): Updated for renames.
- TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
(runJavaScriptAlert): Removed suffix.
(TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(runJavaScriptAlert): Removed suffix.
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
- 8:33 AM Changeset in webkit [186045] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: Page footers are displayed above the bottom of the WebView due to tiled scaling
https://bugs.webkit.org/show_bug.cgi?id=146393
<rdar://problem/21113217>
Reviewed by Sam Weinig.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
Don't include the top content inset in the layout size.
- 5:39 AM Changeset in webkit [186044] by
-
- 5 edits in trunk
[Streams API] Add support for chunks with customized sizes
https://bugs.webkit.org/show_bug.cgi?id=146312
Reviewed by Darin Adler.
Source/WebCore:
Covered by rebased tests.
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::read): Decrement totalQueueSize with the chunk specific size.
(WebCore::ReadableJSStream::enqueue): Calls retrieveSize, enqueue chunk with its size and increment totalQueueSize.
(WebCore::ReadableJSStream::retrieveChunkSize): Calls size JS callback and convert it to double.
- bindings/js/ReadableJSStream.h:
LayoutTests:
- streams/reference-implementation/bad-strategies-expected.txt:
- 5:16 AM Changeset in webkit [186043] by
-
- 6 edits in trunk/Source/WebCore
[Streams API]Remove ReadableStreamController.close custom binding
https://bugs.webkit.org/show_bug.cgi?id=146380
Reviewed by Darin Adler.
No change in behavior.
- Modules/streams/ReadableStreamController.h:
(WebCore::ReadableStreamController::close): Calling ReadableJSStream close method.
- Modules/streams/ReadableStreamController.idl: Removed Custom.
- bindings/js/JSReadableStreamControllerCustom.cpp:
(WebCore::JSReadableStreamController::close): Deleted.
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::close): Moved custom binding code here.
- bindings/js/ReadableJSStream.h:
- 12:43 AM Changeset in webkit [186042] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Wrong border color of console messages when filters are enabled
https://bugs.webkit.org/show_bug.cgi?id=146392
Reviewed by Timothy Hatcher.
- UserInterface/Views/LogContentView.css:
(.console-error-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
(.console-warning-level:not(.filtered-out, .filtered-out-by-search) + .console-item):
Jun 27, 2015:
- 8:47 PM Changeset in webkit [186041] by
-
- 4 edits in trunk/PerformanceTests
[JetStream] Raise the percentile of mandreel-latency and splay-latency
https://bugs.webkit.org/show_bug.cgi?id=146378
Reviewed by Mark Lam.
The current percentile is 95%. When I looked at the sample lists in our GC, it was
clear that the worst 5% samples completely amortize our GC pauses. Our GC pauses can
be quite bad. Clearly, splay-latency is meant to test whether we have an incremental
GC that ensures that you don't have bad worst-case pauses. But 95% is too small,
because it doesn't really capture those pauses. Raising the percentile to above 99%
appears to do the trick. 99.5% or more seems like a good bet. The trade-off there is
just that if we set it too high, then we won't have enough statistics. Doing this very
clearly rewards GCs that are incremental, and punishes GCs that aren't (like ours).
That's what we want, since in the future we want to use this test to guide any
improvements to the worst-case performance of our GC.
The way that the percentile is selected will also affect mandreel-latency. That's a
good thing, because 95% is probably too low for that test as well. That test ends up
with >10k samples. The goal of using 95% in the first place was to get enough samples
to have a stable average. But if we have >10k samples, we can push that percentile up
much higher and still get good statistics while achieving the effect we want - i.e.
getting the worst case.
I don't think that we need to do the same thing for cdjs. That test only takes 200
samples, so 95% means we report the average of the worst 10 samples. That's probably
good enough.
- JetStream/Octane2/base.js: Raise the percentile as described above.
(BenchmarkSuite.prototype.RunSingleBenchmark):
- JetStream/Reference.js: Tweak the reference times to bring the latency tests closer to 100ish on my machine.
- JetStream/create.rb: Bump the version.
- 8:29 PM Changeset in webkit [186040] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/webgl/tex-*.html flakily timeout on Mavericks Debug WK1
- platform/mac-wk1/TestExpectations: Change "Slow" to
"Pass Timeout" since the tests flakily time out and fail:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
- fast/canvas/webgl/tex-image-and-uniform-binding-bugs.html
- 8:29 PM Changeset in webkit [186039] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r186038): accessibility/aria-roledescription.html fails on Windows
- platform/win/TestExpectations: Mark as failing on Windows:
- accessibility/aria-roledescription.html
- 4:02 PM Changeset in webkit [186038] by
-
- 7 edits2 adds in trunk
AX: implement @aria-roledescription
https://bugs.webkit.org/show_bug.cgi?id=146274
Reviewed by Darin Adler.
Source/WebCore:
Add support for aria-roledescription.
Test: accessibility/aria-roledescription.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasHighlighting):
(WebCore::AccessibilityObject::roleDescription):
(WebCore::nodeHasPresentationRole):
- accessibility/AccessibilityObject.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityMaxValue]):
(-[WebAccessibilityObjectWrapper accessibilityRoleDescription]):
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
LayoutTests:
- accessibility/aria-roledescription-expected.txt: Added.
- accessibility/aria-roledescription.html: Added.
- 3:53 PM Changeset in webkit [186037] by
-
- 6 edits in trunk/Source/JavaScriptCore
Make converting JSString to StringView idiomatically safe
https://bugs.webkit.org/show_bug.cgi?id=146387
Reviewed by Anders Carlsson.
- jsc.cpp:
(functionPrint): Add explicit call to SafeView::get, needed since there
is no StringView temporary.
(functionDebug): Ditto.
- runtime/ArrayPrototype.cpp:
(JSC::holesMustForwardToPrototype): Refactored into helper function.
(JSC::join): Refactored so that StringView is a function argument, making
the lifetime simpler.
(JSC::arrayProtoFuncJoin): Ditto.
(JSC::arrayProtoFuncReverse): Use new holesMustForwardToPrototype helper.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode): Add explicit call to SafeView::get.
- runtime/JSString.h: Moved declarations of functions to the top of the
file instead of mixing them in with the function definitions. Changed
return type of the view function to return a JSString::SafeView so that
the JSString's lifetime will last as long as the StringView does in
typical coding idioms.
(JSC::JSString::getIndex): Use unsafeView so we can index into the
view; could also have used view.get but here in this class this seems fine.
(JSC::JSRopeString::unsafeView): Renamed existing view function to this.
(JSC::JSString::unsafeView): Ditto.
(JSC::JSString::SafeView::SafeView): Contains reference to an ExecState
and a JSString. The ExecState is needed to create the StringView, and the
JSString needs to be kept alive as long as the StringView is.
(JSC::JSString::SafeView::operator StringView): Call unsafeView.
(JSC::JSString::SafeView::get): Convenience for when we want to call
StringView member functions.
(JSC::JSString::view): Added. Returns a SafeView.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncIndexOf): Add explicit call to SafeView::get.
- 3:52 PM Changeset in webkit [186036] by
-
- 3 edits in trunk/Source/WebCore
Fix the build.
- platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::cfError): Take out log statement. Add FIXME comment that explains part of the reason we may get null here.
- platform/network/mac/ResourceErrorMac.mm: (WebCore::createNSErrorFromResourceErrorBase): Ditto.
- 2:38 PM Changeset in webkit [186035] by
-
- 3 edits in trunk/Source/WebCore
Crash in WebCore::ResourceError::cfError() after provisional load failed
<http://webkit.org/b/146384>
Reviewed by Darin Adler.
This is a speculative fix based on the crashing stack.
- platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::cfError): Add NULL check.
- platform/network/mac/ResourceErrorMac.mm:
(WebCore::createNSErrorFromResourceErrorBase): Add nil check in
case we ever turn off USE(CFNETWORK) for iOS.
- 2:37 PM Changeset in webkit [186034] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r186001): fast/text/han-generic-font-families.html always fails on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=146385
Unreviewed.
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-06-27
- platform/mac-yosemite/fast/text/han-generic-font-families-expected.html:
- platform/mac/TestExpectations:
- 2:31 PM Changeset in webkit [186033] by
-
- 7 edits in trunk/Websites/perf.webkit.org
build-requests should use conform to JSON API format
https://bugs.webkit.org/show_bug.cgi?id=146375
Reviewed by Stephanie Lewis.
Instead of returning single dictionary that maps root set id to a dictionary of repository names
to revisions, timestamps, simply return root sets and roots "rows" or "objects" as defined in
JSON API (http://jsonapi.org/). This API change makes it easier to resolve the bug 146374 and
matches what we do in /api/test-groups.
Also add the support for /api/build-requests/?id=<id> to fetch the build request with <id>.
This is useful for debugging purposes.
- public/api/build-requests.php:
(main): Added the support for $_GETid?. Also return "rootSets" and "roots".
(update_builds): Extracted from main.
- public/include/build-requests-fetcher.php:
(BuildRequestFetcher::fetch_request): Added. Used for /api/build-requests/?id=<id>.
(BuildRequestFetcher::results_internal): Always call fetch_roots_for_set_if_needed.
(BuildRequestFetcher::fetch_roots_for_set_if_needed): Renamed from fetch_roots_for_set.
Moved the logic to exit early when the root set had already been fetched here.
- public/v2/analysis.js:
(App.TestGroup._fetchTestResults): Fixed the bug that test groups without any successful results
won't be shown.
- tools/pull-os-versions.py:
(main):
(setup_auth): Moved to util.py
- tools/sync-with-buildbot.py:
(main): Replaced a bunch of perf dashboard related options by --server-config-json.
(update_and_fetch_build_requests): No longer takes build_request_auth since that's now taken care
of by setup_auth.
(organize_root_sets_by_id_and_repository_names): Added. Builds the old rootsSets directory based
on "roots" and "rootSets" dictionaries returned by /api/build-requests.
(config_for_request): Fixed a bug that the script blows up when the build request is missing
the repository specified in the configuration. This tolerance is necessary when a new repository
dependency is added but we want to run A/B tests for old builds without the dependency.
(fetch_json): No longer takes auth.
- tools/util.py:
(setup_auth): Moved from pull-os-versions.py to be shared with sync-with-buildbot.py.
- 2:11 PM Changeset in webkit [186032] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Only flag a video element as eligible for auto-play to AppleTV one time
https://bugs.webkit.org/show_bug.cgi?id=146386
Reviewed by Brent Fulgham.
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::removeAllPlaybackTargetPickerClients): Drive-by fix - early
return when there are no clients.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pendingActionTimerFired): Set m_failedToPlayToWirelessTarget if the
media engine is still unable to play to the wireless target.
(WebCore::HTMLMediaElement::prepareForLoad): Clear m_failedToPlayToWirelessTarget.
(WebCore::HTMLMediaElement::mediaState): Don't set the ExternalDeviceAutoPlayCandidate flag
if m_failedToPlayToWirelessTarget is true.
- html/HTMLMediaElement.h:
- 10:59 AM Changeset in webkit [186031] by
-
- 1 edit3 adds in trunk/LayoutTests
REGRESSION (r186029): fast/text/justify-ideograph-{complex,simple,vertical}.html fail on Yosemite
The results replaced in r186029 were the Yosemite results, so
Yosemite started failing when they were rebaselined for
El Capitan.
- platform/mac-yosemite/fast/text/justify-ideograph-complex-expected.txt: Copied from platform/mac/fast/text/justify-ideograph-complex-expected.txt in r186028.
- platform/mac-yosemite/fast/text/justify-ideograph-simple-expected.txt: Copied from platform/mac/fast/text/justify-ideograph-simple-expected.txt in r186028.
- platform/mac-yosemite/fast/text/justify-ideograph-vertical-expected.txt: Copied from platform/mac/fast/text/justify-ideograph-vertical-expected.txt in r186028.
- 10:04 AM Changeset in webkit [186030] by
-
- 1 edit1 add in trunk/LayoutTests
Add missing image results for platform/mac/platform/mac/fast/text/vertical-surrogate-pair.html
- platform/mac/platform/mac/fast/text/vertical-surrogate-pair-expected.png: Added.
- 10:04 AM Changeset in webkit [186029] by
-
- 7 edits1 add in trunk/LayoutTests
Rebaseline El Capitan results for fast/text/justify-ideograph-{complex,simple,vertical}.html
- platform/mac/TestExpectations: Removed expectations.
- platform/mac/fast/text/justify-ideograph-complex-expected.png: Updated.
- platform/mac/fast/text/justify-ideograph-complex-expected.txt: Updated.
- platform/mac/fast/text/justify-ideograph-simple-expected.png: Updated.
- platform/mac/fast/text/justify-ideograph-simple-expected.txt: Updated.
- platform/mac/fast/text/justify-ideograph-vertical-expected.png: Added.
- platform/mac/fast/text/justify-ideograph-vertical-expected.txt: Updated.
- 10:00 AM Changeset in webkit [186028] by
-
- 2 edits in trunk/LayoutTests
Document more slow fast/canvas/webgl tests on Mavericks Debug WK1
See Flakiness Dashboard:
<http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcanvas%2Fwebgl%2Ftex-image-and-sub-image-2d-with-video-rgba4444.html>
<http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fcanvas%2Fwebgl%2Ftex-image-and-sub-image-2d-with-video-rgba5551.html>
- platform/mac-wk1/TestExpectations: Add slow expectations for:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html
- 8:54 AM Changeset in webkit [186027] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r186001): fast/text/han-generic-font-families.html always fails on Yosemite
Fix tracked by: <http://webkit.org/b/146385>
- platform/mac/TestExpectations: Mark as failing on Yosemite:
- fast/text/han-generic-font-families.html
- 8:54 AM Changeset in webkit [186026] by
-
- 2 edits in trunk/LayoutTests
editing/undo/remove-css-property-and-remove-style.html is flaky on Debug WK2
As seen on Flakiness Dashboard:
<http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fundo%2Fremove-css-property-and-remove-style.html>
- platform/mac-wk2/TestExpectations: Add:
- editing/undo/remove-css-property-and-remove-style.html
- 1:52 AM Changeset in webkit [186025] by
-
- 6 edits in trunk/Source/WebKit2
Make NetworkCache::traverse faster
https://bugs.webkit.org/show_bug.cgi?id=146354
Reviewed by Anders Carlsson.
- NetworkProcess/cache/NetworkCacheIOChannel.h:
(WebKit::NetworkCache::IOChannel::path):
(WebKit::NetworkCache::IOChannel::type):
- NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
(WebKit::NetworkCache::IOChannel::open):
(WebKit::NetworkCache::IOChannel::read):
(WebKit::NetworkCache::IOChannel::write):
(WebKit::NetworkCache::IOChannel::readSync): Deleted.
Not needed anymore.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::WriteOperation::WriteOperation):
(WebKit::NetworkCache::Storage::TraverseOperation::TraverseOperation):
Add TraverseOperation, similar to Read/Write.
(WebKit::NetworkCache::Storage::open):
(WebKit::NetworkCache::Storage::traverse):
Use async I/O.
Use condition variable to allow maximum 5 parallel file reads.
- NetworkProcess/cache/NetworkCacheStorage.h:
- 1:04 AM Changeset in webkit [186024] by
-
- 6 edits in trunk
[Streams API] Implement ReadableStreamController.desiredSize property
https://bugs.webkit.org/show_bug.cgi?id=146311
Reviewed by Darin Adler.
Source/WebCore:
Covered by rebased tests.
- Modules/streams/ReadableStreamController.h: Adding desiredSize getter.
(WebCore::ReadableStreamController::desiredSize): Ditto.
- Modules/streams/ReadableStreamController.idl: Added desiredSize attribute.
LayoutTests:
- streams/reference-implementation/count-queuing-strategy-expected.txt:
- streams/reference-implementation/readable-stream-expected.txt:
- 12:45 AM Changeset in webkit [186023] by
-
- 6 edits2 adds in trunk
[GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
https://bugs.webkit.org/show_bug.cgi?id=146318
Reviewed by Sergio Villar Senin.
.:
Enable PUBLIC_SUFFIX_LIST for GTK+.
- Source/cmake/OptionsGTK.cmake:
Source/WebCore:
This is covered by unit tests.
- PlatformGTK.cmake:
- platform/soup/PublicSuffixSoup.cpp: Added.
(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):
Tools:
Copy mac PublicSuffix test to the common directory and add it to
the GTK+ build.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
(TestWebKitAPI::TEST_F):
- 12:42 AM Changeset in webkit [186022] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] NetworkCache: Make NetworkProcess::clearDiskCache actually clear the the resources depending on the date
https://bugs.webkit.org/show_bug.cgi?id=146316
Reviewed by Sergio Villar Senin.
And make sure the completion handler is called, as well. This
functionality is already implemented in Storage::clear(), so we
just need to pass the time point and completion handler to Cache::clear().
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::clearDiskCache):
Jun 26, 2015:
- 7:04 PM Changeset in webkit [186021] by
-
- 6 edits3 adds in trunk
[iOS] AppleGothic has been superseded by Apple SD Gothic Neo
https://bugs.webkit.org/show_bug.cgi?id=146372
<rdar://problem/21574004>
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/text/hangul-generic-font-families.html
- page/mac/SettingsMac.mm:
(WebCore::Settings::initializeDefaultFontFamilies):
LayoutTests:
- fast/text/hangul-generic-font-families.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/fast/text/hangul-generic-font-families-expected.html: Added.
- platform/mac/fast/text/hangul-generic-font-families-expected.html: Added.
- platform/win/TestExpectations:
- 6:43 PM Changeset in webkit [186020] by
-
- 15 edits3 adds in trunk
Supporting getStartDate and added tests
https://bugs.webkit.org/show_bug.cgi?id=145676
<rdar://problem/20876076>
Patch by Matt Daiter <mdaiter@apple.com> on 2015-06-26
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/media/hls/video-controller-getStartDate.html
- bindings/js/JSDOMBinding.cpp:
(WebCore::jsDateOrNaN):
- bindings/js/JSDOMBinding.h:
- bindings/scripts/CodeGeneratorJS.pm: Added features to return
NaN for Date
- bindings/scripts/CodeGeneratorGObject.pm: Needed to add
type checking code for GObject (no date)
(NativeToJSValue):
- bindings/scripts/IDLAttributes.txt:
- html/HTMLMediaElement.cpp: Added getStartDate function
(WebCore::HTMLMediaElement::getStartDate):
- html/HTMLMediaElement.h: Needed to add declarations
- html/HTMLMediaElement.idl: Needed to modify for returning NaN
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::getStartDate):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: Added in Mac-specific platform
(WebCore::MediaPlayerPrivateInterface::getStartDate):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::getStartDate):
LayoutTests:
- http/tests/media/hls/video-controller-getStartDate-expected.txt: Added.
- http/tests/media/hls/video-controller-getStartDate.html: Added.
- http/tests/media/resources/hls/test-vod-date-time.m3u8: Added.
- 4:50 PM Changeset in webkit [186019] by
-
- 2 edits in trunk/Source/WebKit2
Rubber-stamped by Tim Horton.
As Dan pointed out in https://bugs.webkit.org/show_bug.cgi?id=146350 , this way of
getting the screen size was problematic on multiple counts. Fixed here by using
UIScreen.
- UIProcess/WKImagePreviewViewController.mm:
(-[WKImagePreviewViewController initWithCGImage:]):
- 4:48 PM Changeset in webkit [186018] by
-
- 4 edits in trunk/Source
WebPage::getPositionInformation() should not copy an image that is larger than the
screen
https://bugs.webkit.org/show_bug.cgi?id=146367
Reviewed by Tim Horton.
Source/WebCore:
Export the rect version of this function too.
- platform/graphics/GraphicsContext.h:
Source/WebKit2:
Maintain aspectRatio, but scale down the buffer size if the image is larger than
the screen.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 4:46 PM Changeset in webkit [186017] by
-
- 2 edits in trunk/Source/WebKit2
Re-instating the #import and assertion removed in r186014.
https://bugs.webkit.org/show_bug.cgi?id=146358
Not reviewed.
- UIProcess/API/Cocoa/WKUserContentController.mm:
- Speculative fix: should have used <wtf/MainThread.h> instead of <WTF/MainThread.h>.
- 4:33 PM Changeset in webkit [186016] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Muted videos should not automatically play to AppleTV
https://bugs.webkit.org/show_bug.cgi?id=146366
Reviewed by Dean Jackson.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_initiallyMuted.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Support CheckMediaState.
(WebCore::HTMLMediaElement::setReadyState): Set m_initiallyMuted to true if the element is
muted or the volume is less than 5%.
(WebCore::HTMLMediaElement::setMuted): Update media state asynchronously so multiple state
changes can be coalesced.
(WebCore::HTMLMediaElement::mediaPlayerEngineUpdated): Ditto.
(WebCore::HTMLMediaElement::setPlaying): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged): Ditto.
(WebCore::HTMLMediaElement::removeEventListener): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
(WebCore::HTMLMediaElement::updateMediaState): Update after a timer when passed UpdateMediaState::Asynchronously.
(WebCore::HTMLMediaElement::mediaState): Don't set the ExternalDeviceAutoPlayCandidate flag if
m_initiallyMuted is true.
- html/HTMLMediaElement.h:
- html/HTMLMediaElementEnums.h:
- 3:55 PM Changeset in webkit [186015] by
-
- 2 edits in trunk/LayoutTests
No audio on animated page with the attached fixed layout epub
https://bugs.webkit.org/show_bug.cgi?id=146365
<rdar://problem/21360354>
Updated results.
- media/audio-playback-restriction-play-expected.txt:
- 3:47 PM Changeset in webkit [186014] by
-
- 2 edits in trunk/Source/WebKit2
Gardeining: remove an assertion and a #import to green the bot.
https://bugs.webkit.org/show_bug.cgi?id=146358
Not reviewed.
- UIProcess/API/Cocoa/WKUserContentController.mm:
- Not sure why the <WTF/MainThread.h> cannot be found on some bots, but I'm removing it (and the assertion that needed it) for now while I investigate further.
- 3:28 PM Changeset in webkit [186013] by
-
- 2 edits in trunk/WebKitLibraries
[WinCairo] Enable WEB_TIMING.
https://bugs.webkit.org/show_bug.cgi?id=146357
Reviewed by Brent Fulgham.
- win/tools/vsprops/FeatureDefinesCairo.props:
- 3:18 PM Changeset in webkit [186012] by
-
- 9 edits2 deletes in trunk
Rolling out r184660
https://bugs.webkit.org/show_bug.cgi?id=145200
Reverting r184660 because it caused a regression.
Source/WebCore:
- English.lproj/Localizable.strings:
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createAutoFillButton): Deleted.
- platform/LocalizedStrings.cpp:
(WebCore::AXAutoFillButtonText): Deleted.
- platform/LocalizedStrings.h:
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::AXAutoFillButtonText): Deleted.
- platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::AXAutoFillButtonText): Deleted.
LayoutTests:
- accessibility/input-auto-fill-button-expected.txt: Removed.
- accessibility/input-auto-fill-button.html: Removed.
- platform/win/TestExpectations:
- 3:18 PM Changeset in webkit [186011] by
-
- 6 edits7 deletes in trunk
Rolling out r185881
https://bugs.webkit.org/show_bug.cgi?id=146243
And
r185828
https://bugs.webkit.org/show_bug.cgi?id=145241
Reverting r185881 and r185828 because the latter caused a regression.
Source/WebCore:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityTextFieldDecorationHitTest): Deleted.
(WebCore::AccessibilityRenderObject::accessibilityHitTest): Deleted.
- accessibility/AccessibilityRenderObject.h:
LayoutTests:
- accessibility/hit-test-input-auto-fill-button-expected.txt: Removed.
- accessibility/hit-test-input-auto-fill-button.html: Removed.
- accessibility/hit-test-input-search-cancel-button-expected.txt: Removed.
- accessibility/hit-test-input-search-cancel-button.html: Removed.
- accessibility/input-search-cancel-button-expected.txt: Removed.
- accessibility/input-search-cancel-button.html: Removed.
- accessibility/resources/shouldBeAccessibleByCursor.js: Removed.
- platform/win/TestExpectations:
- platform/wk2/TestExpectations:
- 3:14 PM Changeset in webkit [186010] by
-
- 2 edits in trunk/Source/WebKit2
ScriptMessageHandlerDelegate::didPostMessage() should reuse its JSContext instance.
https://bugs.webkit.org/show_bug.cgi?id=146358
Reviewed by Anders Carlsson.
Currently, ScriptMessageHandlerDelegate::didPostMessage() creates a new JSContext each
time it is called. This JSContext is used only once to deserialized a JSON object
and then destroyed. We will change ScriptMessageHandlerDelegate to cache the JSContext
and reuse it in all subsequent calls to didPostMessage().
Also added a @autoreleasepool scope in didPostMessage() so that transient ObjC objects
will be release sooner.
- UIProcess/API/Cocoa/WKUserContentController.mm:
- 2:33 PM Changeset in webkit [186009] by
-
- 4 edits in trunk
No audio on animated page with the attached fixed layout epub
https://bugs.webkit.org/show_bug.cgi?id=146365
Source/WebCore:
Reviewed by Eric Carlson.
The new restriction RequireUserGestureForAudioRateChange conflicted
with existing clients who expected RequireUserGestureForRateChange
to allow autoplaying audio. Update the logic to ensure that
RequireUserGestureForRateChange covers all media when set to
false.
This may require a revisit once we're using RequireUserGestureForAudioRateChange
in production, because the global setting will trump that, and
most clients have the global setting to false. We'll need to come
up with a way to allow legacy clients to preserve their behaviour.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Only restrict audio
if RequireUserGestureForRateChange is also false.
LayoutTests:
<rdar://problem/21360354>
Reviewed by Eric Carlson.
The test to ensure audio needs a user gesture now needs to also
restrict the general case.
- media/audio-playback-restriction-play.html:
- 2:24 PM Changeset in webkit [186008] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Add support for image previews
https://bugs.webkit.org/show_bug.cgi?id=146350
-and corresponding-
rdar://problem/20640234
Reviewed by Tim Horton.
For images, use the actual image instead of a snapshot.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
ViewController for image preview.
- UIProcess/WKImagePreviewViewController.h: Added.
- UIProcess/WKImagePreviewViewController.mm: Added.
(-[WKImagePreviewViewController loadView]):
(-[WKImagePreviewViewController initWithCGImage:]):
(-[WKImagePreviewViewController viewDidLayoutSubviews]):
(_scaleSizeWithinSize):
New enum and member variable to keep track of preview type.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
Only apply the http restriction to non-image links since we can still preview the
image of a non-http image link.
(-[WKContentView gestureRecognizerShouldBegin:]):
Handle links and images.
(-[WKContentView previewViewControllerForPosition:inSourceView:]):
Return early for non-link previews.
(-[WKContentView commitPreviewViewController:]):
New files.
- WebKit2.xcodeproj/project.pbxproj:
Just use the actual image in the PositionInformation for image elements rather
than taking a screen shot.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 1:42 PM Changeset in webkit [186007] by
-
- 9 edits1 delete in trunk/Source/WebCore
Get rid of ScrollbarThemeClient now that it's unused
https://bugs.webkit.org/show_bug.cgi?id=146327
Reviewed by Beth Dakin.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::scrollbarOverlayStyle): Deleted.
(WebCore::Scrollbar::isScrollableAreaActive): Deleted.
(WebCore::Scrollbar::isScrollViewScrollbar): Deleted.
(WebCore::Scrollbar::root): Deleted.
- platform/Scrollbar.h:
(WebCore::Scrollbar::isCustomScrollbar):
(WebCore::Scrollbar::orientation):
(WebCore::Scrollbar::value):
(WebCore::Scrollbar::currentPos):
(WebCore::Scrollbar::visibleSize):
(WebCore::Scrollbar::totalSize):
(WebCore::Scrollbar::maximum):
(WebCore::Scrollbar::controlSize):
(WebCore::Scrollbar::lineStep):
(WebCore::Scrollbar::pageStep):
(WebCore::Scrollbar::pressedPart):
(WebCore::Scrollbar::hoveredPart):
(WebCore::Scrollbar::enabled):
(WebCore::Scrollbar::styleChanged):
(WebCore::Scrollbar::isAlphaLocked):
(WebCore::Scrollbar::setIsAlphaLocked):
- platform/ScrollbarTheme.h:
- platform/ScrollbarThemeClient.h: Removed.
(WebCore::ScrollbarThemeClient::~ScrollbarThemeClient): Deleted.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::updateScrollbarOverlayStyle):
- rendering/RenderScrollbarTheme.cpp:
- 12:21 PM Changeset in webkit [186006] by
-
- 3 edits1 add in trunk
Network process hangs fetching disk cache entries
https://bugs.webkit.org/show_bug.cgi?id=146348
<rdar://problem/21528072>
Reviewed by Anders Carlsson.
RunLoop::dispatch may deadlock if invoked with std::function that captures an object that calls RunLoop::dispatch in destructor.
- wtf/RunLoop.cpp:
(WTF::RunLoop::performWork):
Don't reuse std::function variable in loop. We may end up destroying previously held std::function in assignment
while holding the runloop mutex. With this change std::function is always destroyed with mutex unlocked.
- 11:26 AM Changeset in webkit [186005] by
-
- 8 edits in trunk/Source/WebCore
Prevent new loads while in PageCache (or being added to PageCache)
https://bugs.webkit.org/show_bug.cgi?id=146299
<rdar://problem/21523788>
Reviewed by Darin Adler.
Generalize the change in r185337 to prevent new loads while in the
PageCache (or being added to the PageCache), instead of merely
preventing new loads in pagehide event handlers. We should never
have any pages that are still loading inside the PageCache.
The fix in r185337 was apparently insufficient to address the
problem so generalizing the check / policy will hopefully catch
more cases where content is able to start loads while being added
to the PageCache. This patch also removes some of the complexity
added in r185337 as it is no longer needed.
No new tests, already covered by:
http/tests/navigation/image-load-in-pagehide-handler.html
http/tests/navigation/subframe-pagehide-handler-starts-load.html
http/tests/navigation/subframe-pagehide-handler-starts-load2.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::handleBeforeUnloadEvent):
(WebCore::FrameLoader::FrameLoader): Deleted.
- loader/FrameLoader.h:
(WebCore::FrameLoader::pageDismissalEventBeingDispatched):
- loader/ImageLoader.cpp:
(WebCore::pageIsBeingDismissed):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):
- page/Page.cpp:
(WebCore::Page::inPageCache):
- page/Page.h:
(WebCore::Page::group): Deleted.
- 11:23 AM Changeset in webkit [186004] by
-
- 9 edits2 adds in trunk
WinLauncher fails to download files.
https://bugs.webkit.org/show_bug.cgi?id=146242
Reviewed by Alex Christensen.
Source/WebKit/win:
Don't start download when there is no download delegate.
- WebView.cpp:
(WebView::downloadURL):
Tools:
Added WinLauncher download delegate.
- WinLauncher/Common.cpp:
- WinLauncher/WebDownloadDelegate.cpp: Added.
(WebDownloadDelegate::WebDownloadDelegate):
(WebDownloadDelegate::~WebDownloadDelegate):
(WebDownloadDelegate::QueryInterface):
(WebDownloadDelegate::AddRef):
(WebDownloadDelegate::Release):
(WebDownloadDelegate::decideDestinationWithSuggestedFilename):
(WebDownloadDelegate::didCancelAuthenticationChallenge):
(WebDownloadDelegate::didCreateDestination):
(WebDownloadDelegate::didFailWithError):
(WebDownloadDelegate::didReceiveAuthenticationChallenge):
(WebDownloadDelegate::didReceiveDataOfLength):
(WebDownloadDelegate::didReceiveResponse):
(WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
(WebDownloadDelegate::willResumeWithResponse):
(WebDownloadDelegate::willSendRequest):
(WebDownloadDelegate::didBegin):
(WebDownloadDelegate::didFinish):
- WinLauncher/WebDownloadDelegate.h: Added.
- WinLauncher/WinLauncher.cpp:
(WinLauncher::setAccessibilityDelegate):
(WinLauncher::setResourceLoadDelegate):
(WinLauncher::setDownloadDelegate):
(WinLauncher::mainFrame):
- WinLauncher/WinLauncher.h:
(WinLauncher::standardPreferences):
(WinLauncher::privatePreferences):
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
- WinLauncher/WinMain.cpp:
(wWinMain):
- 11:17 AM Changeset in webkit [186003] by
-
- 2 edits in trunk/Source/WebCore
[OS X] Change the layer tiling threshold from 2000 to 2048 pixels
https://bugs.webkit.org/show_bug.cgi?id=146353
Reviewed by Tim Horton.
Programmers love powers of two.
- platform/graphics/ca/GraphicsLayerCA.cpp:
- 10:42 AM Changeset in webkit [186002] by
-
- 2 edits in trunk/Source/WebKit2
Wireless Playback Target-related #import should be a #include
https://bugs.webkit.org/show_bug.cgi?id=146283
Reviewed by Eric Carlson.
- Shared/WebCoreArgumentCoders.cpp:
- 10:27 AM Changeset in webkit [186001] by
-
- 6 edits5 adds in trunk
[Cocoa] Sans-serif generic font family should map to PingFang
https://bugs.webkit.org/show_bug.cgi?id=146333
<rdar://problem/21521217>
Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2015-06-26
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Also performs a little bit of cleanup.
Test: fast/text/han-generic-font-families.html
- page/mac/SettingsMac.mm:
(WebCore::sansSerifTraditionalHanFontFamily):
(WebCore::sansSerifSimplifiedHanFontFamily):
(WebCore::Settings::initializeDefaultFontFamilies):
LayoutTests:
- fast/text/han-generic-font-families.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/fast/text/han-generic-font-families-expected.html: Added.
- platform/mac-mavericks/fast/text/han-generic-font-families-expected.html: Added.
- platform/mac-yosemite/fast/text/han-generic-font-families-expected.html: Added.
- platform/mac/fast/text/han-generic-font-families-expected.html: Added.
- platform/win/TestExpectations:
- 10:09 AM Changeset in webkit [186000] by
-
- 2 edits in trunk/Source/WebCore
[Curl] Compile errors; ResourceResponseBase::resourceLoadTiming() has changed return type.
https://bugs.webkit.org/show_bug.cgi?id=146343
Reviewed by Brent Fulgham.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::calculateWebTimingInformations):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::initializeHandle):
(WebCore::ResourceHandleManager::initCookieSession):
(WebCore::sockoptfunction): Deleted.
- 9:45 AM Changeset in webkit [185999] by
-
- 11 edits2 moves1 add in trunk/Source/WebKit
[Win] Implement WebViewGroup to support WebView::addxxxToGroup().
https://bugs.webkit.org/show_bug.cgi?id=145908
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-26
Reviewed by Brent Fulgham.
Make WebViewGroup class sharing on Mac and Win port.
Source/WebKit:
- WebCoreSupport: Added.
- WebCoreSupport/WebViewGroup.cpp: Added.
(webViewGroups):
(WebViewGroup::getOrCreate):
(WebViewGroup::get):
(WebViewGroup::WebViewGroup):
(WebViewGroup::~WebViewGroup):
(WebViewGroup::addWebView):
(WebViewGroup::removeWebView):
(WebViewGroup::storageNamespaceProvider):
- WebCoreSupport/WebViewGroup.h: Added.
(WebViewGroup::userContentController):
(WebViewGroup::visitedLinkStore):
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
- WebKit.vcxproj/WebKit/WebKitCommon.props:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- WebCoreSupport/WebViewGroup.h: Removed.
- WebCoreSupport/WebViewGroup.mm: Removed.
Source/WebKit/win:
- WebCoreSupport/WebVisitedLinkStore.cpp:
(visitedLinkStores):
(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::setShouldTrackVisitedLinks):
(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::singleton): Deleted.
- WebCoreSupport/WebVisitedLinkStore.h:
- WebView.cpp:
(toURL):
(localStorageDatabasePath):
(WebView::WebView):
(WebView::~WebView):
(WebView::shouldInitializeTrackPointHack):
(WebView::initWithFrame):
(WebView::setGroupName):
(WebView::addVisitedLinks):
- WebView.h:
- 9:42 AM Changeset in webkit [185998] by
-
- 3 edits1 delete in trunk/Source/JavaScriptCore
Remove ARMv7Assembler.cpp
https://bugs.webkit.org/show_bug.cgi?id=146340
Reviewed by Filip Pizlo.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARMv7Assembler.cpp: Removed.
- 8:17 AM Changeset in webkit [185997] by
-
- 2 edits in trunk/Source/WebCore
iOS speech synthesizer should expose names
https://bugs.webkit.org/show_bug.cgi?id=146319
Reviewed by Mario Sanchez Prada.
Use newer API to get the name and identifier of each voice asset.
- platform/ios/PlatformSpeechSynthesizerIOS.mm:
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
- 6:24 AM Changeset in webkit [185996] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the !ENABLE(ES6_ARROWFUNCTION_SYNTAX) build after r185989
https://bugs.webkit.org/show_bug.cgi?id=146344
Reviewed by Yusuke Suzuki.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseSourceElements):
- 6:05 AM Changeset in webkit [185995] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Remove unnecessary overriden methods from ScrollBarEfl
https://bugs.webkit.org/show_bug.cgi?id=146342
Reviewed by Gyuyoung Kim.
- platform/efl/ScrollbarEfl.cpp:
(WebCore::ScrollbarEfl::setParent): Deleted.
(WebCore::ScrollbarEfl::setFrameRect): Deleted.
(WebCore::ScrollbarEfl::frameRectsChanged): Deleted.
(WebCore::ScrollbarEfl::invalidate): Deleted.
- platform/efl/ScrollbarEfl.h:
- 6:01 AM Changeset in webkit [185994] by
-
- 6 edits in trunk/Source/WebCore
Convert some of WebCore/dom over to range-for loops
https://bugs.webkit.org/show_bug.cgi?id=126250
Reviewed by Darin Adler.
Based on the original patch of Sam Weinig <sam@webkit.org>.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild):
(WebCore::willRemoveChildren):
(WebCore::ContainerNode::appendChild):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::disconnect):
(WebCore::MutationObserver::getObservedNodes):
(WebCore::MutationObserver::deliver):
- dom/MutationObserverInterestGroup.cpp:
(WebCore::MutationObserverInterestGroup::isOldValueRequested):
(WebCore::MutationObserverInterestGroup::enqueueMutationRecord):
- dom/MutationObserverRegistration.cpp:
(WebCore::MutationObserverRegistration::clearTransientRegistrations):
(WebCore::MutationObserverRegistration::addRegistrationNodesToSet):
- dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::collectMatchingObserversForMutation):
(WebCore::Node::notifyMutationObserversNodeWillDetach):
- 4:37 AM Changeset in webkit [185993] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed buildfix after r185971, disable WEB_TIMING.
- win/tools/vsprops/FeatureDefinesCairo.props:
- 4:05 AM Changeset in webkit [185992] by
-
- 3 edits1 delete in trunk/Tools
[EFL] Bump libseccomp version to 2.2.1
https://bugs.webkit.org/show_bug.cgi?id=146341
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- efl/jhbuildrc: Enabled libseccomp build on AArch64.
- efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
- 1:49 AM Changeset in webkit [185991] by
-
- 2 edits in tags/Safari-601.1.37/Source/WebCore
Merged r185988.
- 12:10 AM Changeset in webkit [185990] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r185971): js/dom/global-constructors-attributes.html fails on Windows
- platform/win/js/dom/global-constructors-attributes-expected.txt:
Update results after enabling WEB_TIMING API for Windows.
