Timeline



Aug 7, 2015:

11:33 PM Changeset in webkit [188189] by ap@apple.com
  • 3 edits in branches/safari-601.1-branch/LayoutTests

Correct expectations for platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html.

Use a correct path, and only skip the test on WK1.

  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
10:39 PM Changeset in webkit [188188] by Devin Rousso
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Decrease the padding of each rule in the Rules sidebar to allow more content to show
​https://bugs.webkit.org/show_bug.cgi?id=147360

Reviewed by Timothy Hatcher.

Generally tightened the padding around each section in the rules panel, as well as the
content inside each section. Also moved the new rule button to be next to the filter bar.

  • UserInterface/Views/CSSStyleDeclarationSection.css:

(.style-declaration-section):
(.style-declaration-section.last-in-group):
(.style-declaration-section.last-in-group + .style-declaration-section): Deleted.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content > .pseudo-classes):
(.sidebar > .panel.details.css-style > .content + .options-container):
(.sidebar > .panel.details.css-style > .content:not(.supports-new-rule, .has-filter-bar) + .options-container):
(.sidebar > .panel.details.css-style > .content + .options-container > .new-rule):
(.sidebar > .panel.details.css-style > .content + .options-container > .filter-bar):
(.sidebar > .panel.details.css-style > .content:not(.has-filter-bar) + .options-container > .filter-bar):
(.sidebar > .panel.details.css-style > .content.has-filter-bar + .filter-bar): Deleted.
(.sidebar > .panel.details.css-style > .content:not(.has-filter-bar) + .filter-bar): Deleted.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._switchPanels):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._newRuleButtonClicked):

  • UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style .rules .label):

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
(WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonClicked):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.addNewRuleButton): Deleted.
(WebInspector.RulesStyleDetailsPanel.prototype.refresh): Deleted.
(WebInspector.RulesStyleDetailsPanel.prototype._newRuleClicked): Deleted.

10:39 PM Changeset in webkit [188187] by Gyuyoung Kim
  • 28 edits in trunk/Source

Reduce uses of PassRefPtr in bindings
​https://bugs.webkit.org/show_bug.cgi?id=147781

Reviewed by Chris Dumez.

Use RefPtr when function can return null or an instance. If not, Ref is used.

Source/JavaScriptCore:

  • runtime/JSGenericTypedArrayView.h:

(JSC::toNativeTypedView):

Source/WebCore:

  • bindings/gobject/GObjectNodeFilterCondition.h:
  • bindings/gobject/GObjectXPathNSResolver.h:
  • bindings/gobject/WebKitDOMNodeFilter.cpp:

(WebKit::core):

  • bindings/gobject/WebKitDOMNodeFilterPrivate.h:
  • bindings/gobject/WebKitDOMXPathNSResolver.cpp:

(WebKit::core):

  • bindings/gobject/WebKitDOMXPathNSResolverPrivate.h:
  • bindings/js/CallbackFunction.h:

(WebCore::createFunctionOnlyCallback):

  • bindings/js/Dictionary.h:

(WebCore::Dictionary::getEventListener):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):
(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::scriptValueToIDBKey):

  • bindings/js/IDBBindingUtilities.h:
  • bindings/js/JSDOMBinding.h:

(WebCore::toInt8Array):
(WebCore::toInt16Array):
(WebCore::toInt32Array):
(WebCore::toUint8Array):
(WebCore::toUint8ClampedArray):
(WebCore::toUint16Array):
(WebCore::toUint32Array):
(WebCore::toFloat32Array):
(WebCore::toFloat64Array):

  • bindings/js/JSDOMStringListCustom.cpp:

(WebCore::JSDOMStringList::toWrapped):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::readAccelerationArgument):
(WebCore::readRotationRateArgument):

  • bindings/js/JSErrorHandler.h:

(WebCore::createJSErrorHandler):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::createPositionOptions):

  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::toWrapped):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createWorld):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):

  • bindings/js/SerializedScriptValue.h:
  • bindings/objc/DOMUIKitExtensions.mm:

(-[DOMNode rangeOfContainingParagraph]):

  • bindings/objc/ObjCNodeFilterCondition.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

9:08 PM Changeset in webkit [188186] by mmaxfield@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

[El Capitan] Test Gardening

Unreviewed.

  • platform/mac/css3/font-feature-settings-preinstalled-fonts-expected.txt: Added.
8:54 PM Changeset in webkit [188185] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[OS X] Remove dead code from FontCache::createFontPlatformData()
​https://bugs.webkit.org/show_bug.cgi?id=147804

Reviewed by Zalan Bujtas.

CTFontCreateForCSS() always returns the best font.

No new tests because there is no behavior change.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fontWithFamily):

8:45 PM Changeset in webkit [188184] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't include zero-width space into a copied text from the console
​https://bugs.webkit.org/show_bug.cgi?id=147767

Reviewed by Timothy Hatcher.

Now removes work break characters in generated javascript text when copying
to the clipboard. Also replaced var with let in the modified functions.

  • UserInterface/Views/ConsoleCommandView.js:

(WebInspector.ConsoleCommandView.prototype.toClipboardString):
(WebInspector.ConsoleCommandView):

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype.toClipboardString):

8:06 PM Changeset in webkit [188183] by Alan Bujtas
  • 22 edits in trunk/Source/WebCore

Move painting functions from RenderObject to RenderElement.
​https://bugs.webkit.org/show_bug.cgi?id=147764

Reviewed by Simon Fraser.

Ideally they should live in RenderBoxModelObject, but the current SVG architecture makes is difficult
to move them there.

No change in functionality.

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::FloatRect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintOneBorderSide):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::drawLineForBoxSide):
(WebCore::RenderElement::paintFocusRing):
(WebCore::RenderElement::paintOutline):

  • rendering/RenderElement.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::paintColumnRules):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide): Deleted.
(WebCore::RenderObject::paintFocusRing): Deleted.
(WebCore::RenderObject::paintOutline): Deleted.

  • rendering/RenderObject.h:
  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorders):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintRowGroupBorder):

  • rendering/RenderTheme.h:

(WebCore::RenderTheme::paintMenuListButtonDecorations):

  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonDecorations):

7:14 PM Changeset in webkit [188182] by jcraig@apple.com
  • 8 edits
    2 adds in trunk

REGRESSION(r184722) AX: WebKit video playback toolbar removed from DOM; no longer accessible to VoiceOver
​https://bugs.webkit.org/show_bug.cgi?id=145684

Reviewed by Dean Jackson.

Source/WebCore:

Updated Apple Video controls to add an invisible but focusable button that allows VoiceOver
users (and when unblocked, keyboard users) to re-display the video controls.

Test: media/video-controls-show-on-kb-or-ax-event.html

  • English.lproj/mediaControlsLocalizedStrings.js:
  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-show-controls):
(video::-webkit-media-show-controls):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleShowControlsClick):
(Controller.prototype.handleWrapperMouseMove):
(Controller.prototype.updateForShowingControls):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.setNeedsUpdateForDisplayedWidth):

  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-show-controls):
(video::-webkit-media-show-controls):

LayoutTests:

  • http/tests/contentextensions/text-track-blocked-expected.txt: Minor update to test case expectation.
  • media/video-controls-show-on-kb-or-ax-event-expected.txt: Added.
  • media/video-controls-show-on-kb-or-ax-event.html: New test validates video controls can be displayed without the need for a mouse.
  • platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Minor update to test case expectation.
6:13 PM Changeset in webkit [188181] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

5:48 PM Changeset in webkit [188180] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.5

New tag.

5:21 PM Changeset in webkit [188179] by achristensen@apple.com
  • 2 edits in trunk/Tools

[GTK] Another build fix after r188157.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::viewSupportsOptions):
Name all the things correctly!

5:14 PM Changeset in webkit [188178] by achristensen@apple.com
  • 2 edits in trunk/Tools

[EFL, GTK] Build fix after r188176.

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.

5:09 PM Changeset in webkit [188177] by achristensen@apple.com
  • 2 edits in trunk/Tools

[GTK] Speculative build fix after r188157.

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView):
Update parameter list.

4:42 PM Changeset in webkit [188176] by achristensen@apple.com
  • 9 edits
    3 moves
    3 adds in trunk

Build more testing binaries with CMake on Windows
​https://bugs.webkit.org/show_bug.cgi?id=147799

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

  • shell/PlatformWin.cmake: Added.

Build jsc.dll and jsc.exe to find Apple Application Support or WinCairo dlls before using them.

Source/WebCore:

  • CMakeLists.txt:

MockCDM.cpp needs to be part of WebCoreTestSupport, not WebCore.

  • PlatformWin.cmake:

Added files needed for AppleWin port.

Source/WebKit/win:

  • WebKitDLL.cpp:

(loadResourceIntoBuffer):
AppleWin doesn't like exporting a function without a separate declaration.

Tools:

  • DumpRenderTree/CMakeLists.txt:

Build TestNetscapePlugin.

  • DumpRenderTree/PlatformWin.cmake:

Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.

  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
  • DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
  • DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
4:39 PM Changeset in webkit [188175] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Being moving away from using SQLTransactionStateMachine in SQLTransactionBackend
​https://bugs.webkit.org/show_bug.cgi?id=147798

Reviewed by Geoffrey Garen.

This is the first step towards getting rid of the state machine so we can ultimately merge SQLTransactionBackend
into SQLTransaction.

Instead of having the state machine run our functions, just run them ourselves where we can. For states that need
to be handled in the frontend, call SQLTransaction::requestTransitToState explicitly.

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::stateFunctionFor):
(WebCore::SQLTransactionBackend::lockAcquired):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runStatements):
(WebCore::SQLTransactionBackend::runCurrentStatement):
(WebCore::SQLTransactionBackend::handleCurrentStatementError):
(WebCore::SQLTransactionBackend::handleTransactionError):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState): Deleted.
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError): Deleted.
(WebCore::SQLTransactionBackend::nextStateForTransactionError): Deleted.
(WebCore::SQLTransactionBackend::sendToFrontendState): Deleted.

  • Modules/webdatabase/SQLTransactionBackend.h:
4:31 PM Changeset in webkit [188174] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] Test gardening

Unreviewed.

  • platform/mac/TestExpectations:
4:25 PM Changeset in webkit [188173] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Simplify OS-specific CSS class names
​https://bugs.webkit.org/show_bug.cgi?id=147794

Replace "body:not(.el-capitan)" with ".legacy-mac".
Replace "body.el-capitan" with ".latest-mac".

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

  • UserInterface/Views/Toolbar.css:

(body.legacy-mac .toolbar .dashboard-container):
(body.legacy-mac .toolbar .search-bar > input[type="search"]):
(body.legacy-mac .toolbar .search-bar > input[type="search"]:focus):
(body.legacy-mac .toolbar .item.button:active):
(body.window-inactive.legacy-mac .toolbar .dashboard-container):
(body.latest-mac .toolbar .dashboard-container):
(body.latest-mac .toolbar .search-bar > input[type="search"]):
(body.latest-mac .toolbar .search-bar > input[type="search"]:focus):
(@media (-webkit-min-device-pixel-ratio: 2)):
(body.latest-mac .toolbar .item.button:active):
(body.latest-mac.window-inactive .toolbar .dashboard-container):
(body:not(.el-capitan) .toolbar .dashboard-container): Deleted.
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]): Deleted.
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body:not(.el-capitan) .toolbar .item.button:active): Deleted.
(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container): Deleted.
(body.el-capitan .toolbar .dashboard-container): Deleted.
(body.el-capitan .toolbar .search-bar > input[type="search"]): Deleted.
(body.el-capitan .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body.el-capitan .toolbar .item.button:active): Deleted.
(body.el-capitan.window-inactive .toolbar .dashboard-container): Deleted.

4:10 PM Changeset in webkit [188172] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
​https://bugs.webkit.org/show_bug.cgi?id=147667

Patch by Jason Marcell <​jmarcell@apple.com> on 2015-08-07
Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
other than "openSource" and "internal".
(BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:

(Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
(Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
(sortedPlatforms): Deleted.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:

(buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
(sortedPlatforms): Deleted.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:

(sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
and sorts them by this property returning the new sorted array.

4:07 PM Changeset in webkit [188171] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

4:04 PM Changeset in webkit [188170] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.48

New tag.

3:38 PM Changeset in webkit [188169] by fpizlo@apple.com
  • 41 edits
    5 adds in trunk

Lightweight locks should be adaptive
​https://bugs.webkit.org/show_bug.cgi?id=147545

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • dfg/DFGCommon.cpp:

(JSC::DFG::startCrashing):

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::workListLock):

  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::shouldReportLiveBytes):
(JSC::CopiedBlock::reportLiveBytes):

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneFillingBlock):

  • heap/CopiedSpace.h:

(JSC::CopiedSpace::CopiedGeneration::CopiedGeneration):

  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::recycleEvacuatedBlock):

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::didStartCopying):

  • heap/GCThreadSharedData.h:

(JSC::GCThreadSharedData::getNextBlocksToCopy):

  • heap/ListableHandler.h:

(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::addNotThreadSafe):

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStacks):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::copyLater):

  • parser/SourceProvider.cpp:

(JSC::SourceProvider::~SourceProvider):
(JSC::SourceProvider::getID):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::removeFirstAtExitDatabase):

  • runtime/TypeProfilerLog.h:

Source/WebCore:

  • bindings/objc/WebScriptObject.mm:

(WebCore::getJSWrapper):
(WebCore::addJSWrapper):
(WebCore::removeJSWrapper):
(WebCore::removeJSWrapperIfRetainCountOne):

  • platform/audio/mac/CARingBuffer.cpp:

(WebCore::CARingBuffer::setCurrentFrameBounds):
(WebCore::CARingBuffer::getCurrentFrameBounds):

  • platform/audio/mac/CARingBuffer.h:
  • platform/ios/wak/WAKWindow.mm:

(-[WAKWindow setExposedScrollViewRect:]):
(-[WAKWindow exposedScrollViewRect]):

Source/WebKit2:

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::clearQueuedTouchEventsForPage):
(WebKit::EventDispatcher::getQueuedTouchEventsForPage):
(WebKit::EventDispatcher::touchEvent):
(WebKit::EventDispatcher::dispatchTouchEvents):

  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):

  • WebProcess/WebPage/ViewUpdateDispatcher.h:

Source/WTF:

A common idiom in WebKit is to use spinlocks. We use them because the lock acquisition
overhead is lower than system locks and because they take dramatically less space than system
locks. The speed and space advantages of spinlocks can be astonishing: an uncontended spinlock
acquire is up to 10x faster and under microcontention - short critical section with two or
more threads taking turns - spinlocks are up to 100x faster. Spinlocks take only 1 byte or 4
bytes depending on the flavor, while system locks take 64 bytes or more. Clearly, WebKit
should continue to avoid system locks - they are just far too slow and far too big.

But there is a problem with this idiom. System lock implementations will sleep a thread when
it attempts to acquire a lock that is held, while spinlocks will cause the thread to burn CPU.
In WebKit spinlocks, the thread will repeatedly call sched_yield(). This is awesome for
microcontention, but awful when the lock will not be released for a while. In fact, when
critical sections take tens of microseconds or more, the CPU time cost of our spinlocks is
almost 100x more than the CPU time cost of a system lock. This case doesn't arise too
frequently in our current uses of spinlocks, but that's probably because right now there are
places where we make a conscious decision to use system locks - even though they use more
memory and are slower - because we don't want to waste CPU cycles when a thread has to wait a
while to acquire the lock.

The solution is to just implement a modern adaptive mutex in WTF. Luckily, this isn't a new
concept. This patch implements a mutex that is reminiscent of the kinds of low-overhead locks
that JVMs use. The actual implementation here is inspired by some of the ideas from [1]. The
idea is simple: the fast path is an inlined CAS to immediately acquire a lock that isn't held,
the slow path tries some number of spins to acquire the lock, and if that fails, the thread is
put on a queue and put to sleep. The queue is made up of statically allocated thread nodes and
the lock itself is a tagged pointer: either it is just bits telling us the complete lock state
(not held or held) or it is a pointer to the head of a queue of threads waiting to acquire the
lock. This approach gives WTF::Lock three different levels of adaptation: an inlined fast path
if the lock is not contended, a short burst of spinning for microcontention, and a full-blown
queue for critical sections that are held for a long time.

On a locking microbenchmark, this new Lock exhibits the following performance
characteristics:

  • Lock+unlock on an uncontended no-op critical section: 2x slower than SpinLock and 3x faster than a system mutex.
  • Lock+unlock on a contended no-op critical section: 2x slower than SpinLock and 100x faster than a system mutex.
  • CPU time spent in lock() on a lock held for a while: same as system mutex, 90x less than a SpinLock.
  • Memory usage: sizeof(void*), so on 64-bit it's 8x less than a system mutex but 2x worse than a SpinLock.

This patch replaces all uses of SpinLock with Lock, since our critical sections are not
no-ops so if you do basically anything in your critical section, the Lock overhead will be
invisible. Also, in all places where we used SpinLock, we could tolerate 8 bytes of overhead
instead of 4. Performance benchmarking using JSC macrobenchmarks shows no difference, which is
as it should be: the purpose of this change is to reduce CPU time wasted, not wallclock time.
This patch doesn't replace any uses of ByteSpinLock, since we expect that the space benefits
of having a lock that just uses a byte are still better than the CPU wastage benefits of
Lock. But, this work will enable some future work to create locks that will fit in just 1.6
bits: ​https://bugs.webkit.org/show_bug.cgi?id=147665.

Rolling this back in after fixing Lock::unlockSlow() for architectures that have a truly weak
CAS. Since the Lock::unlock() fast path can go to slow path spuriously, it may go there even if
there aren't any threads on the Lock's queue. So, unlockSlow() must be able to deal with the
possibility of a null queue head.

[1] ​http://www.filpizlo.com/papers/pizlo-pppj2011-fable.pdf

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • benchmarks: Added.
  • benchmarks/LockSpeedTest.cpp: Added.

(main):

  • wtf/Atomics.h:

(WTF::Atomic::compareExchangeWeak):
(WTF::Atomic::compareExchangeStrong):

  • wtf/CMakeLists.txt:
  • wtf/Lock.cpp: Added.

(WTF::LockBase::lockSlow):
(WTF::LockBase::unlockSlow):

  • wtf/Lock.h: Added.

(WTF::LockBase::lock):
(WTF::LockBase::unlock):
(WTF::LockBase::isHeld):
(WTF::LockBase::isLocked):
(WTF::Lock::Lock):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::release):
(WTF::MetaAllocatorHandle::shrink):
(WTF::MetaAllocator::allocate):
(WTF::MetaAllocator::currentStatistics):
(WTF::MetaAllocator::addFreshFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):

  • wtf/MetaAllocator.h:
  • wtf/SpinLock.h:
  • wtf/ThreadingPthreads.cpp:
  • wtf/ThreadingWin.cpp:
  • wtf/text/AtomicString.cpp:
  • wtf/text/AtomicStringImpl.cpp:

(WTF::AtomicStringTableLocker::AtomicStringTableLocker):

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/Lock.cpp: Added.

(TestWebKitAPI::runLockTest):
(TestWebKitAPI::TEST):

2:55 PM Changeset in webkit [188168] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

Post-review comments on r188146
​https://bugs.webkit.org/show_bug.cgi?id=147793

Reviewed by Daniel Bates.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::appendTrueTypeFeature):
(WebCore::appendOpenTypeFeature):
(WebCore::applyFontFeatureSettings):

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::getSystemFontFallbackForCharacters):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fontWithFamily):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):

2:49 PM Changeset in webkit [188167] by mmaxfield@apple.com
  • 9 edits
    2 adds in trunk

Source/WebCore:
[Cocoa] Font fallback is not language-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=147390

Reviewed by Dean Jackson.

We need to make our font fallback code sensitive to locale.

This patch rolls r187729 back in. However, only particular versions of iOS and OS X are
performant enough to enable this language-sensitivity.

This patch also applies to iOS.

Test: fast/text/fallback-language-han.html

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCacheIOS.mm:

(WebCore::FontCache::systemFallbackForCharacters):

LayoutTests:
[OS X] Font fallback is not language-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=147390

Reviewed by Dean Jackson.

This test is expected to fail most places.

  • fast/text/fallback-language-han-expected.html: Added.
  • fast/text/fallback-language-han.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/iOS/TestExpectations:
2:44 PM Changeset in webkit [188166] by Alan Bujtas
  • 6 edits in trunk/Source/WebCore

RenderTheme::volumeSliderOffsetFromMuteButton should take const& RenderBox.
​https://bugs.webkit.org/show_bug.cgi?id=147731

Reviewed by Simon Fraser.

No change in functionality.

  • rendering/RenderMediaControlElements.cpp:

(WebCore::RenderMediaVolumeSliderContainer::layout):

  • rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Deleted.

  • rendering/RenderMediaControls.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):

  • rendering/RenderTheme.h:
2:37 PM Changeset in webkit [188165] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188150. rdar://problem/22123707

2:30 PM Changeset in webkit [188164] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

Replace RenderObject::isRooted() logic with isDescendantOf().
​https://bugs.webkit.org/show_bug.cgi?id=147788

Reviewed by Simon Fraser.

And some related cleanups.

No change in functionality.

  • page/FrameView.cpp:

(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::extendedBackgroundRectForPainting):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers):

  • rendering/RenderElement.cpp:

(WebCore::shouldRepaintForImageAnimation):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::isDescendantOf):
(WebCore::scheduleRelayoutForSubtree):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintSlowRepaintObject):
(WebCore::RenderObject::isRooted):

  • rendering/RenderObject.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::unextendedBackgroundRect):
(WebCore::RenderView::backgroundRect):

  • rendering/RenderView.h:
2:25 PM Changeset in webkit [188163] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

Subtree layout code should use RenderElement.
​https://bugs.webkit.org/show_bug.cgi?id=147694

Reviewed by Simon Fraser.

Subtree layout will never begin at a RenderText, so tighten up
the code to operate on RenderElements instead of RenderObjects.
(This patch is based on webkit.org/b/126878)

No change in functionality.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willLayout):

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView): Deleted.
(WebCore::FrameView::layoutRoot): Deleted.

  • page/FrameView.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::clearLayoutRootIfNeeded):
(WebCore::RenderElement::willBeDestroyed):

  • rendering/RenderElement.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::clearLayoutRootIfNeeded): Deleted.
(WebCore::RenderObject::willBeDestroyed): Deleted.

  • rendering/RenderObject.h:
2:12 PM Changeset in webkit [188162] by Wenson Hsieh
  • 5 edits in trunk/Source

Temporarily allow programmatic input assistance for adding Gmail account
​https://bugs.webkit.org/show_bug.cgi?id=147792

Reviewed by Enrica Casucci.
<rdar://problem/22126518>

Temporary fix for keyboard input sliding out and immediately back in upon user interaction
in the Gmail 2-factor authentication page.

Source/WebCore:

  • platform/RuntimeApplicationChecksIOS.h:
  • platform/RuntimeApplicationChecksIOS.mm:

(WebCore::applicationIsGmailAddAccountOnIOS): Added bundle ID for Gmail settings.

Source/WebKit2:

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]): Early

return no longer triggers due to lack of user interaction when adding a new Gmail account
through Settings.

2:12 PM Changeset in webkit [188161] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix a tyop.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::viewSupportsOptions):

2:07 PM Changeset in webkit [188160] by Simon Fraser
  • 4 edits
    34 moves
    2 adds in trunk/LayoutTests

Move platform/mac/fast/scrolling/ tests into fast/scrolling/latching/

  • TestExpectations:
  • fast/scrolling/latching/iframe_in_iframe-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/iframe_in_iframe-expected.txt.
  • fast/scrolling/latching/iframe_in_iframe.html: Renamed from LayoutTests/platform/mac/fast/scrolling/iframe_in_iframe.html.
  • fast/scrolling/latching/resources/background.html: Renamed from LayoutTests/platform/mac/fast/scrolling/resources/background.html.
  • fast/scrolling/latching/resources/inner_content.html: Renamed from LayoutTests/platform/mac/fast/scrolling/resources/inner_content.html.
  • fast/scrolling/latching/resources/scroll_nested_iframe_test_inner.html: Renamed from LayoutTests/platform/mac/fast/scrolling/resources/scroll_nested_iframe_test_inner.html.
  • fast/scrolling/latching/resources/scroll_nested_iframe_test_outer.html: Renamed from LayoutTests/platform/mac/fast/scrolling/resources/scroll_nested_iframe_test_outer.html.
  • fast/scrolling/latching/resources/testContent.html: Renamed from LayoutTests/platform/mac/fast/scrolling/resources/testContent.html.
  • fast/scrolling/latching/resources/testImage.png: Renamed from LayoutTests/platform/mac/fast/scrolling/resources/testImage.png.
  • fast/scrolling/latching/scroll-div-latched-div-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt.
  • fast/scrolling/latching/scroll-div-latched-div.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-div.html.
  • fast/scrolling/latching/scroll-div-latched-mainframe-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt.
  • fast/scrolling/latching/scroll-div-latched-mainframe.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-latched-mainframe.html.
  • fast/scrolling/latching/scroll-div-no-latching-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-no-latching-expected.txt.
  • fast/scrolling/latching/scroll-div-no-latching.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-no-latching.html.
  • fast/scrolling/latching/scroll-div-with-nested-nonscrollable-iframe-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe-expected.txt.
  • fast/scrolling/latching/scroll-div-with-nested-nonscrollable-iframe.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html.
  • fast/scrolling/latching/scroll-iframe-fragment-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-fragment-expected.txt.
  • fast/scrolling/latching/scroll-iframe-fragment.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-fragment.html.
  • fast/scrolling/latching/scroll-iframe-latched-iframe-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt.
  • fast/scrolling/latching/scroll-iframe-latched-iframe.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html.
  • fast/scrolling/latching/scroll-iframe-latched-mainframe-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt.
  • fast/scrolling/latching/scroll-iframe-latched-mainframe.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html.
  • fast/scrolling/latching/scroll-iframe-webkit1-latching-bug-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug-expected.txt.
  • fast/scrolling/latching/scroll-iframe-webkit1-latching-bug.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-iframe-webkit1-latching-bug.html.
  • fast/scrolling/latching/scroll-latched-nested-div-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-latched-nested-div-expected.txt.
  • fast/scrolling/latching/scroll-latched-nested-div.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-latched-nested-div.html.
  • fast/scrolling/latching/scroll-nested-iframe-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-nested-iframe-expected.txt.
  • fast/scrolling/latching/scroll-nested-iframe.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-nested-iframe.html.
  • fast/scrolling/latching/scroll-select-bottom-test-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-select-bottom-test-expected.txt.
  • fast/scrolling/latching/scroll-select-bottom-test.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-select-bottom-test.html.
  • fast/scrolling/latching/scroll-select-latched-mainframe-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt.
  • fast/scrolling/latching/scroll-select-latched-mainframe.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-mainframe.html.
  • fast/scrolling/latching/scroll-select-latched-select-expected.txt: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt.
  • fast/scrolling/latching/scroll-select-latched-select.html: Renamed from LayoutTests/platform/mac/fast/scrolling/scroll-select-latched-select.html.
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
2:07 PM Changeset in webkit [188159] by Simon Fraser
  • 6 edits
    18 moves
    1 add
    1 delete in trunk/LayoutTests

Move platform/mac/fast/forms/ tests to fast/forms/

  • TestExpectations:
  • fast/forms/attributed-strings-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/attributed-strings-expected.txt.
  • fast/forms/attributed-strings.html: Renamed from LayoutTests/platform/mac/fast/forms/attributed-strings.html.
  • fast/forms/focus-option-control-on-page-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/focus-option-control-on-page-expected.txt.
  • fast/forms/focus-option-control-on-page.html: Renamed from LayoutTests/platform/mac/fast/forms/focus-option-control-on-page.html.
  • fast/forms/indeterminate-progress-inline-height-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height-expected.txt.
  • fast/forms/indeterminate-progress-inline-height.html: Renamed from LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height.html.
  • fast/forms/input-appearance-spinbutton-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-expected.png.
  • fast/forms/input-appearance-spinbutton-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt.
  • fast/forms/input-appearance-spinbutton-size-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt.
  • fast/forms/input-appearance-spinbutton-size.html: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-size.html.
  • fast/forms/input-appearance-spinbutton-up-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt.
  • fast/forms/input-appearance-spinbutton-up.html: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-up.html.
  • fast/forms/input-appearance-spinbutton.html: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton.html.
  • fast/forms/input-number-click-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-number-click-expected.txt.
  • fast/forms/input-number-click.html: Renamed from LayoutTests/platform/mac/fast/forms/input-number-click.html.
  • fast/forms/listbox-scrollbar-hit-test-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt.
  • fast/forms/listbox-scrollbar-hit-test.html: Renamed from LayoutTests/platform/mac/fast/forms/listbox-scrollbar-hit-test.html.
  • fast/forms/script-tests/focus-option-control-on-page.js: Renamed from LayoutTests/platform/mac/fast/forms/script-tests/focus-option-control-on-page.js.
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Removed.
  • platform/wk2/TestExpectations:
1:45 PM Changeset in webkit [188158] by ap@apple.com
  • 3 edits in trunk/Tools

Update AppEngine app version numbers to the latest commit.

  • QueueStatusServer/app.yaml:
  • TestResultServer/app.yaml:
1:35 PM Changeset in webkit [188157] by andersca@apple.com
  • 10 edits
    1 add in trunk/Tools

Simplify WKTR's view options
​https://bugs.webkit.org/show_bug.cgi?id=147791

Reviewed by Sam Weinig.

Instead of using a WKDictionaryRef, just use a struct for the options.

  • WebKitTestRunner/PlatformWebView.h:

(WTR::PlatformWebView::options):
(WTR::PlatformWebView::viewSupportsOptions): Deleted.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::ensureViewSupportsOptions):
(WTR::TestController::updateLayoutTypeForTest):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/ViewOptions.h: Added.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformConfigureViewForTest):

1:19 PM Changeset in webkit [188156] by Lucas Forschler
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188115. rdar://problem/22181735

1:17 PM Changeset in webkit [188155] by Lucas Forschler
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188112. <rdar://problem/22128839>

1:16 PM Changeset in webkit [188154] by Lucas Forschler
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188111. <rdar://problem/22128839>

1:15 PM Changeset in webkit [188153] by Lucas Forschler
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188109. <rdar://problem/22128839>

1:14 PM Changeset in webkit [188152] by Lucas Forschler
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188058. <rdar://problem/22128839>

1:13 PM Changeset in webkit [188151] by Lucas Forschler
  • 3 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188053. <rdar://problem/22128839>

1:10 PM Changeset in webkit [188150] by aestes@apple.com
  • 5 edits in trunk/Source/WebCore

Crash when following a Google search link to Twitter with Limit Adult Content enabled
​https://bugs.webkit.org/show_bug.cgi?id=147651

Reviewed by Brady Eidson.

When a loaded CachedRawResource gets a new client, it synthesizes the callbacks that the new client would have
received while the resource was loading. Unlike a real network load, it synthesizes these callbacks in a single
run loop iteration. When DocumentLoader receives a redirect, and finds substitute data in the app cache for the
redirect URL, it schedules a timer that removes DocumentLoader as a client of the CachedRawResource then
synthesizes its own set of CachedRawResourceClient callbacks. But since CachedRawResource has already delivered
client callbacks before the app cache timer fires, DocumentLoader unexpectedly ends up getting two sets of
client callbacks and badness ensues.

The fix is to let CachedRawResource detect if a redirect will trigger the client to load substitute data. If so,
stop delivering client callbacks.

Layout test to follow.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::syntheticRedirectReceived): If there is valid substitute data, do not continue.

  • loader/DocumentLoader.h:
  • loader/cache/CachedRawResource.cpp: Returned early if syntheticRedirectReceived() said not to continue.

(WebCore::CachedRawResource::didAddClient):

  • loader/cache/CachedRawResourceClient.h:

(WebCore::CachedRawResourceClient::syntheticRedirectReceived):

1:06 PM Changeset in webkit [188149] by msaboff@apple.com
  • 3 edits in branches/jsc-tailcall/Source/JavaScriptCore

Unreviewed. Rollout r188072 as there are crashes with release builds.

The combination of r188071 and r188072 does not properly restore all registers for
all exceptions. Rolling out to make the branch functional again.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter64.asm:
12:40 PM Changeset in webkit [188148] by dino@apple.com
  • 3 edits
    2 adds in trunk

Shadows don't draw on fillText when using a gradient fill
​https://bugs.webkit.org/show_bug.cgi?id=147758
<rdar://problem/20860912>

Reviewed by Myles Maxfield.

Source/WebCore:

Since we use a mask to render a pattern or gradient
into text, any shadow was being clipped out. Change
this to draw the shadow before the mask + fill operation,
using a technique similar to text-shadow.

Test: fast/canvas/gradient-text-with-shadow.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Get the current shadow
style, paint the text with a transformed shadow offset so that we only
see the shadow and not the text, then combine with the existing pattern/gradient
fill.

LayoutTests:

New test that exercises shadows on gradient fills. This really
should be a ref test, but there is a very small rendering difference
caused by masking, so instead it uses JS to look for pixels of
the correct color.

  • fast/canvas/gradient-text-with-shadow-expected.txt: Added.
  • fast/canvas/gradient-text-with-shadow.html: Added.
12:34 PM Changeset in webkit [188147] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Rename some variables in the JSC watchdog implementation.
​https://bugs.webkit.org/show_bug.cgi?id=147790

Rubber stamped by Benjamin Poulain.

This is just a refactoring patch to give the variable better names that describe their
intended use. There is no behavior change.

  • runtime/Watchdog.cpp:

(JSC::Watchdog::Watchdog):
(JSC::Watchdog::setTimeLimit):
(JSC::Watchdog::didFire):
(JSC::Watchdog::isEnabled):
(JSC::Watchdog::fire):
(JSC::Watchdog::startCountdownIfNeeded):

  • runtime/Watchdog.h:
12:09 PM Changeset in webkit [188146] by mmaxfield@apple.com
  • 8 edits
    4 adds in trunk

Implement font-feature-settings
​https://bugs.webkit.org/show_bug.cgi?id=147722

Reviewed by Simon Fraser.

Source/WebCore:

Fonts with features are simply modeled as new font objects. Font
feature information is contained within FontDescription, and our
caches are correctly sensitive to this information. Therefore,
we just need to make our font lookup code honor the request to
use certain features.

This patch creates a file, FontCacheCoreText.cpp, which will be the
new home of all shared OS X / iOS FontCache code. Over time, I will
be moving more and more source into this file, until there is
nothing left of FontCacheMac.mm and FontCacheIOS.mm. For now, the
only function in this file is the code which applies font features.

Test: css3/font-feature-settings-preinstalled-fonts.html

  • WebCore.xcodeproj/project.pbxproj: Add FontCacheCoreText.cpp.
  • platform/graphics/FontCache.h:
  • platform/graphics/cocoa/FontCacheCoreText.cpp: Added.

(WebCore::appendTrueTypeFeature): What the name says.
(WebCore::appendOpenTypeFeature): Ditto.
(WebCore::applyFontFeatureSettings): Ditto.

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::getSystemFontFallbackForCharacters): Call
applyFontFeatureSettings().
(WebCore::FontCache::createFontPlatformData): Ditto.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fontWithFamily): Ditto.
(WebCore::FontCache::systemFallbackForCharacters): Ditto.
(WebCore::FontCache::createFontPlatformData): Ditto.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Ditto.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):
Ditto.

LayoutTests:

Until I can make a custom font for reference tests, use a simple dump-render-tree test.

  • css3/font-feature-settings-preinstalled-fonts.html: Added.
  • platform/mac-yosemite/css3/font-feature-settings-preinstalled-fonts-expected.txt: Added.
12:08 PM Changeset in webkit [188145] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r187907.
​https://bugs.webkit.org/show_bug.cgi?id=147789

taking a different approach to the fix (Requested by estes on
#webkit).

Reverted changeset:

"Crash when following a Google search link to Twitter with
Limit Adult Content enabled."
​https://bugs.webkit.org/show_bug.cgi?id=147651
​http://trac.webkit.org/changeset/187907

11:51 AM Changeset in webkit [188144] by Chris Dumez
  • 41 edits
    4 deletes in trunk

Source/JavaScriptCore:
Interpreter::unwind shouldn't be responsible for assigning the correct scope.
​https://bugs.webkit.org/show_bug.cgi?id=147666

Patch by Saam barati <​saambarati1@gmail.com> on 2015-08-07
Reviewed by Geoffrey Garen.

If we make the bytecode generator know about every local scope it
creates, and if we give each local scope a unique register, the
bytecode generator has all the information it needs to assign
the correct scope to a catch handler. Because the bytecode generator
knows this information, it's a better separation of responsibilties
for it to set up the proper scope instead of relying on the exception
handling runtime to find the scope.

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/HandlerInfo.h:

(JSC::UnlinkedHandlerInfo::UnlinkedHandlerInfo):
(JSC::HandlerInfo::initialize):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::emitGetScope):
(JSC::BytecodeGenerator::emitPushWithScope):
(JSC::BytecodeGenerator::emitGetParentScope):
(JSC::BytecodeGenerator::emitPopScope):
(JSC::BytecodeGenerator::emitPopWithScope):
(JSC::BytecodeGenerator::allocateAndEmitScope):
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::pushTry):
(JSC::BytecodeGenerator::popTryAndEmitCatch):
(JSC::BytecodeGenerator::localScopeDepth):
(JSC::BytecodeGenerator::calculateTargetScopeDepthForExceptionHandler): Deleted.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::WithNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::compileOpStrictEq):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_to_number):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/JSScope.cpp:

(JSC::JSScope::objectAtScope):
(JSC::isUnscopable):
(JSC::JSScope::depth): Deleted.

  • runtime/JSScope.h:

Source/WebCore:
Fix WinCairo build after r188130.

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-08-07

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
I forgot the parameter name.

Source/WebKit2:
Move concrete KeyedDecoder/Encoder implementations to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=147757.

Patch by Brady Eidson <​beidson@apple.com> on 2015-08-07
Rubberstamped by Andy Estes.

  • DatabaseProcess/IndexedDB/IDBSerialization.cpp:

(WebKit::serializeIDBKeyPath):
(WebKit::deserializeIDBKeyPath):
(WebKit::serializeIDBKeyData):
(WebKit::deserializeIDBKeyData):

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF:
Unreviewed, roll out ​http://trac.webkit.org/changeset/187972.

Patch by Filip Pizlo <​fpizlo@apple.com> on 2015-08-05

  • wtf/Atomics.cpp:

(WTF::getSwapLock):
(WTF::atomicStep):

  • wtf/MessageQueue.h:

(WTF::MessageQueue::infiniteTime):
(WTF::MessageQueue<DataType>::append):
(WTF::MessageQueue<DataType>::appendAndKill):
(WTF::MessageQueue<DataType>::appendAndCheckEmpty):
(WTF::MessageQueue<DataType>::prepend):
(WTF::MessageQueue<DataType>::removeIf):
(WTF::MessageQueue<DataType>::isEmpty):
(WTF::MessageQueue<DataType>::kill):
(WTF::MessageQueue<DataType>::killed):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ThreadPrivate::execute):
(WTF::ParallelEnvironment::ThreadPrivate::waitForFinish):
(WTF::ParallelEnvironment::ThreadPrivate::workerThread):

  • wtf/ParallelJobsGeneric.h:
  • wtf/RunLoop.cpp:

(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h:
  • wtf/ThreadSpecificWin.cpp:

(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
(WTF::ThreadSpecificThreadExit):

  • wtf/Threading.cpp:

(WTF::threadEntryPoint):
(WTF::createThread):

  • wtf/ThreadingPrimitives.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::threadMapMutex):
(WTF::initializeThreading):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::changeThreadPriority):
(WTF::waitForThreadCompletion):
(WTF::detachThread):
(WTF::threadDidExit):
(WTF::currentThread):
(WTF::Mutex::Mutex):
(WTF::Mutex::~Mutex):
(WTF::Mutex::lock):
(WTF::Mutex::tryLock):
(WTF::Mutex::unlock):
(WTF::ThreadCondition::~ThreadCondition):
(WTF::ThreadCondition::wait):
(WTF::ThreadCondition::timedWait):
(WTF::DeprecatedMutex::DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::~DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::lock): Deleted.
(WTF::DeprecatedMutex::tryLock): Deleted.
(WTF::DeprecatedMutex::unlock): Deleted.

  • wtf/ThreadingWin.cpp:

(WTF::initializeCurrentThreadInternal):
(WTF::threadMapMutex):
(WTF::initializeThreading):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::clearThreadHandleForIdentifier):
(WTF::currentThread):
(WTF::Mutex::Mutex):
(WTF::Mutex::~Mutex):
(WTF::Mutex::lock):
(WTF::Mutex::tryLock):
(WTF::Mutex::unlock):
(WTF::ThreadCondition::~ThreadCondition):
(WTF::ThreadCondition::wait):
(WTF::ThreadCondition::timedWait):
(WTF::DeprecatedMutex::DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::~DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::lock): Deleted.
(WTF::DeprecatedMutex::tryLock): Deleted.
(WTF::DeprecatedMutex::unlock): Deleted.

  • wtf/WorkQueue.h:
  • wtf/dtoa.cpp:
  • wtf/dtoa.h:
  • wtf/efl/DispatchQueueEfl.cpp:

(DispatchQueue::dispatch):
(DispatchQueue::performWork):
(DispatchQueue::performTimerWork):
(DispatchQueue::insertTimerWorkItem):
(DispatchQueue::wakeUpThread):
(DispatchQueue::getNextTimeOut):

  • wtf/efl/DispatchQueueEfl.h:
  • wtf/efl/RunLoopEfl.cpp:

(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):

  • wtf/threads/BinarySemaphore.cpp:

(WTF::BinarySemaphore::signal):
(WTF::BinarySemaphore::wait):

  • wtf/threads/BinarySemaphore.h:
  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::handleCallback):
(WTF::WorkQueue::platformInvalidate):
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::timerCallback):
(WTF::WorkQueue::dispatchAfter):

Tools:
Running tests for a long time results in some tests running very slowly (throttling)
​https://bugs.webkit.org/show_bug.cgi?id=147718

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-08-07
Reviewed by Chris Dumez.

Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
Although COCOA ports default this setting to be disabled in WebKit1,
we should make both test harnesses disable the setting for consistency.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

11:40 AM Changeset in webkit [188143] by Simon Fraser
  • 1 edit
    8213 deletes in trunk/LayoutTests

Remove platform/ios-sim-deprecated. All of the tests here exist elsewhere already.

  • platform/ios-sim-deprecated/: Removed.
11:33 AM Changeset in webkit [188142] by Brian Burg
  • 12 edits
    149 copies
    8 moves
    7 adds
    1 delete in trunk/LayoutTests

Web Inspector: move LayoutTests/inspector-protocol/ tests to LayoutTests/inspector/
​https://bugs.webkit.org/show_bug.cgi?id=147729

Reviewed by Timothy Hatcher.

Merge inspector-protocol tests into the inspector directory. Rename a few helper
resources whose names clashed. Put top-level tests into unit-tests/ and protocol/.

Update TestExpectations to not reference inspector-protocol paths.

  • TestExpectations:
  • http/tests/inspector/resources/console-test.js: Renamed from LayoutTests/inspector-protocol/resources/console-test.js.
  • http/tests/inspector/resources/probe-test.js: Renamed from LayoutTests/inspector-protocol/resources/probe-helper.js.
  • inspector-protocol/debugger/resources/breakpoint.js: Removed.
  • inspector/console/console-message-expected.txt: Renamed from LayoutTests/inspector-protocol/console/console-message-expected.txt.
  • inspector/console/console-message.html: Renamed from LayoutTests/inspector-protocol/console/console-message.html.
  • inspector/console/css-source-locations-expected.txt: Renamed from LayoutTests/inspector-protocol/console/css-source-locations-expected.txt.
  • inspector/console/css-source-locations.html: Renamed from LayoutTests/inspector-protocol/console/css-source-locations.html.
  • inspector/console/js-source-locations-expected.txt: Renamed from LayoutTests/inspector-protocol/console/js-source-locations-expected.txt.
  • inspector/console/js-source-locations.html: Renamed from LayoutTests/inspector-protocol/console/js-source-locations.html.
  • inspector/console/resources/errors.css: Renamed from LayoutTests/inspector-protocol/resources/errors.css.

(div):

  • inspector/console/resources/errors.js: Renamed from LayoutTests/inspector-protocol/resources/errors.js.

(foo):

  • inspector/console/x-frame-options-message-expected.txt: Renamed from LayoutTests/inspector-protocol/console/x-frame-options-message-expected.txt.
  • inspector/console/x-frame-options-message.html: Renamed from LayoutTests/inspector-protocol/console/x-frame-options-message.html.
  • inspector/css/getSupportedCSSProperties-expected.txt: Renamed from LayoutTests/inspector-protocol/css/getSupportedCSSProperties-expected.txt.
  • inspector/css/getSupportedCSSProperties.html: Renamed from LayoutTests/inspector-protocol/css/getSupportedCSSProperties.html.
  • inspector/debugger/breakpoint-action-detach-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-action-detach-expected.txt.
  • inspector/debugger/breakpoint-action-detach.html: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-action-detach.html.
  • inspector/debugger/breakpoint-action-eval.html:
  • inspector/debugger/breakpoint-action-with-exception-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-action-with-exception-expected.txt.
  • inspector/debugger/breakpoint-action-with-exception.html: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-action-with-exception.html.
  • inspector/debugger/breakpoint-condition-detach-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-condition-detach-expected.txt.
  • inspector/debugger/breakpoint-condition-detach.html: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-condition-detach.html.
  • inspector/debugger/breakpoint-condition-with-bad-script-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt.
  • inspector/debugger/breakpoint-condition-with-bad-script.html: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-bad-script.html.
  • inspector/debugger/breakpoint-condition-with-exception-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-exception-expected.txt.
  • inspector/debugger/breakpoint-condition-with-exception.html: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-condition-with-exception.html.
  • inspector/debugger/breakpoint-eval-with-exception-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt.
  • inspector/debugger/breakpoint-eval-with-exception.html: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-eval-with-exception.html.
  • inspector/debugger/breakpoint-inside-conditons-and-actions-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-inside-conditons-and-actions-expected.txt.
  • inspector/debugger/breakpoint-inside-conditons-and-actions.html: Renamed from LayoutTests/inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html.
  • inspector/debugger/call-frame-function-name-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-function-name-expected.txt.
  • inspector/debugger/call-frame-function-name.html: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-function-name.html.
  • inspector/debugger/call-frame-this-host-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-this-host-expected.txt.
  • inspector/debugger/call-frame-this-host.html: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-this-host.html.
  • inspector/debugger/call-frame-this-nonstrict-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-this-nonstrict-expected.txt.
  • inspector/debugger/call-frame-this-nonstrict.html: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-this-nonstrict.html.
  • inspector/debugger/call-frame-this-strict-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-this-strict-expected.txt.
  • inspector/debugger/call-frame-this-strict.html: Renamed from LayoutTests/inspector-protocol/debugger/call-frame-this-strict.html.
  • inspector/debugger/debugger-statement-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/debugger-statement-expected.txt.
  • inspector/debugger/debugger-statement.html: Renamed from LayoutTests/inspector-protocol/debugger/debugger-statement.html.
  • inspector/debugger/didSampleProbe-multiple-probes-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/didSampleProbe-multiple-probes-expected.txt.
  • inspector/debugger/didSampleProbe-multiple-probes.html: Renamed from LayoutTests/inspector-protocol/debugger/didSampleProbe-multiple-probes.html.
  • inspector/debugger/hit-breakpoint-from-console-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console-expected.txt.
  • inspector/debugger/hit-breakpoint-from-console.html: Renamed from LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console.html.
  • inspector/debugger/nested-inspectors-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/nested-inspectors-expected.txt.
  • inspector/debugger/nested-inspectors.html: Renamed from LayoutTests/inspector-protocol/debugger/nested-inspectors.html.
  • inspector/debugger/pause-dedicated-worker-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/pause-dedicated-worker-expected.txt.
  • inspector/debugger/pause-dedicated-worker.html: Renamed from LayoutTests/inspector-protocol/debugger/pause-dedicated-worker.html.
  • inspector/debugger/pause-on-assert-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/pause-on-assert-expected.txt.
  • inspector/debugger/pause-on-assert.html: Renamed from LayoutTests/inspector-protocol/debugger/pause-on-assert.html.
  • inspector/debugger/probe-manager-add-remove-actions.html:
  • inspector/debugger/regress-133182-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/regress-133182-expected.txt.
  • inspector/debugger/regress-133182.html: Renamed from LayoutTests/inspector-protocol/debugger/regress-133182.html.
  • inspector/debugger/removeBreakpoint-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/removeBreakpoint-expected.txt.
  • inspector/debugger/removeBreakpoint.html: Renamed from LayoutTests/inspector-protocol/debugger/removeBreakpoint.html.
  • inspector/debugger/resources/assert.js: Renamed from LayoutTests/inspector-protocol/debugger/resources/assert.js.
  • inspector/debugger/resources/dedicated-worker.js: Renamed from LayoutTests/inspector-protocol/debugger/resources/dedicated-worker.js.
  • inspector/debugger/resources/exception.js: Renamed from LayoutTests/inspector-protocol/debugger/resources/exception.js.
  • inspector/debugger/resources/mac-linebreaks.js: Renamed from LayoutTests/inspector-protocol/debugger/resources/mac-linebreaks.js.
  • inspector/debugger/resources/mixed-linebreaks.js: Renamed from LayoutTests/inspector-protocol/debugger/resources/mixed-linebreaks.js.
  • inspector/debugger/resources/script-for-breakpoint-actions.js: Copied from LayoutTests/inspector/debugger/resources/breakpoint.js.
  • inspector/debugger/resources/unix-linebreaks.js: Renamed from LayoutTests/inspector-protocol/debugger/resources/unix-linebreaks.js.
  • inspector/debugger/resources/windows-linebreaks.js: Renamed from LayoutTests/inspector-protocol/debugger/resources/windows-linebreaks.js.
  • inspector/debugger/searchInContent-linebreaks-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/searchInContent-linebreaks-expected.txt.
  • inspector/debugger/searchInContent-linebreaks.html: Renamed from LayoutTests/inspector-protocol/debugger/searchInContent-linebreaks.html.
  • inspector/debugger/setBreakpoint-actions-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-actions-expected.txt.
  • inspector/debugger/setBreakpoint-actions.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-actions.html.
  • inspector/debugger/setBreakpoint-autoContinue-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-autoContinue-expected.txt.
  • inspector/debugger/setBreakpoint-autoContinue.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-autoContinue.html.
  • inspector/debugger/setBreakpoint-column-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-column-expected.txt.
  • inspector/debugger/setBreakpoint-column.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-column.html.
  • inspector/debugger/setBreakpoint-column.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-column.txt.
  • inspector/debugger/setBreakpoint-condition-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-condition-expected.txt.
  • inspector/debugger/setBreakpoint-condition.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-condition.html.
  • inspector/debugger/setBreakpoint-dfg-and-modify-local-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt.
  • inspector/debugger/setBreakpoint-dfg-and-modify-local.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html.
  • inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local-expected.txt.
  • inspector/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html.
  • inspector/debugger/setBreakpoint-dfg-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg-expected.txt.
  • inspector/debugger/setBreakpoint-dfg.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-dfg.html.
  • inspector/debugger/setBreakpoint-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-expected.txt.
  • inspector/debugger/setBreakpoint-options-exception-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-options-exception-expected.txt.
  • inspector/debugger/setBreakpoint-options-exception.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint-options-exception.html.
  • inspector/debugger/setBreakpoint.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpoint.html.
  • inspector/debugger/setBreakpointByUrl-sourceURL-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpointByUrl-sourceURL-expected.txt.
  • inspector/debugger/setBreakpointByUrl-sourceURL.html: Renamed from LayoutTests/inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html.
  • inspector/debugger/setPauseOnExceptions-all-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-all-expected.txt.
  • inspector/debugger/setPauseOnExceptions-all.html: Renamed from LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-all.html.
  • inspector/debugger/setPauseOnExceptions-none-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-none-expected.txt.
  • inspector/debugger/setPauseOnExceptions-none.html: Renamed from LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-none.html.
  • inspector/debugger/setPauseOnExceptions-uncaught-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-uncaught-expected.txt.
  • inspector/debugger/setPauseOnExceptions-uncaught.html: Renamed from LayoutTests/inspector-protocol/debugger/setPauseOnExceptions-uncaught.html.
  • inspector/debugger/setVariableValue-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/setVariableValue-expected.txt.
  • inspector/debugger/setVariableValue.html: Renamed from LayoutTests/inspector-protocol/debugger/setVariableValue.html.
  • inspector/debugger/terminate-dedicated-worker-while-paused-expected.txt: Renamed from LayoutTests/inspector-protocol/debugger/terminate-dedicated-worker-while-paused-expected.txt.
  • inspector/debugger/terminate-dedicated-worker-while-paused.html: Renamed from LayoutTests/inspector-protocol/debugger/terminate-dedicated-worker-while-paused.html.
  • inspector/dom-debugger/node-removed-expected.txt: Renamed from LayoutTests/inspector-protocol/dom-debugger/node-removed-expected.txt.
  • inspector/dom-debugger/node-removed.html: Renamed from LayoutTests/inspector-protocol/dom-debugger/node-removed.html.
  • inspector/dom/dom-remove-events-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/dom-remove-events-expected.txt.
  • inspector/dom/dom-remove-events.html: Renamed from LayoutTests/inspector-protocol/dom/dom-remove-events.html.
  • inspector/dom/dom-search-crash-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/dom-search-crash-expected.txt.
  • inspector/dom/dom-search-crash.html: Renamed from LayoutTests/inspector-protocol/dom/dom-search-crash.html.
  • inspector/dom/dom-search-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/dom-search-expected.txt.
  • inspector/dom/dom-search-with-context-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/dom-search-with-context-expected.txt.
  • inspector/dom/dom-search-with-context.html: Renamed from LayoutTests/inspector-protocol/dom/dom-search-with-context.html.
  • inspector/dom/dom-search.html: Renamed from LayoutTests/inspector-protocol/dom/dom-search.html.
  • inspector/dom/focus-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/focus-expected.txt.
  • inspector/dom/focus.html: Renamed from LayoutTests/inspector-protocol/dom/focus.html.
  • inspector/dom/getAccessibilityPropertiesForNode-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt.
  • inspector/dom/getAccessibilityPropertiesForNode.html: Renamed from LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode.html.
  • inspector/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt.
  • inspector/dom/getAccessibilityPropertiesForNode_liveRegion.html: Renamed from LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html.
  • inspector/dom/getAccessibilityPropertiesForNode_mouseEventNodeId-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_mouseEventNodeId-expected.txt.
  • inspector/dom/getAccessibilityPropertiesForNode_mouseEventNodeId.html: Renamed from LayoutTests/inspector-protocol/dom/getAccessibilityPropertiesForNode_mouseEventNodeId.html.
  • inspector/dom/highlight-flow-with-no-region-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/highlight-flow-with-no-region-expected.txt.
  • inspector/dom/highlight-flow-with-no-region.html: Renamed from LayoutTests/inspector-protocol/dom/highlight-flow-with-no-region.html.
  • inspector/dom/remove-multiple-nodes-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/remove-multiple-nodes-expected.txt.
  • inspector/dom/remove-multiple-nodes.html: Renamed from LayoutTests/inspector-protocol/dom/remove-multiple-nodes.html.
  • inspector/dom/request-child-nodes-depth-expected.txt: Renamed from LayoutTests/inspector-protocol/dom/request-child-nodes-depth-expected.txt.
  • inspector/dom/request-child-nodes-depth.html: Renamed from LayoutTests/inspector-protocol/dom/request-child-nodes-depth.html.
  • inspector/dom/resources/dom-search-crash-iframe.html: Renamed from LayoutTests/inspector-protocol/dom/resources/dom-search-crash-iframe.html.
  • inspector/dom/resources/dom-search-iframe.html: Renamed from LayoutTests/inspector-protocol/dom/resources/dom-search-iframe.html.
  • inspector/dom/resources/dom-search-queries.js: Renamed from LayoutTests/inspector-protocol/dom/resources/dom-search-queries.js.
  • inspector/layers/layers-anonymous-expected.txt: Renamed from LayoutTests/inspector-protocol/layers/layers-anonymous-expected.txt.
  • inspector/layers/layers-anonymous.html: Renamed from LayoutTests/inspector-protocol/layers/layers-anonymous.html.
  • inspector/layers/layers-blending-compositing-reasons-expected.txt: Renamed from LayoutTests/inspector-protocol/layers/layers-blending-compositing-reasons-expected.txt.
  • inspector/layers/layers-blending-compositing-reasons.html: Renamed from LayoutTests/inspector-protocol/layers/layers-blending-compositing-reasons.html.
  • inspector/layers/layers-compositing-reasons-expected.txt: Renamed from LayoutTests/inspector-protocol/layers/layers-compositing-reasons-expected.txt.
  • inspector/layers/layers-compositing-reasons.html: Renamed from LayoutTests/inspector-protocol/layers/layers-compositing-reasons.html.
  • inspector/layers/layers-for-node-expected.txt: Renamed from LayoutTests/inspector-protocol/layers/layers-for-node-expected.txt.
  • inspector/layers/layers-for-node.html: Renamed from LayoutTests/inspector-protocol/layers/layers-for-node.html.
  • inspector/layers/layers-generated-content-expected.txt: Renamed from LayoutTests/inspector-protocol/layers/layers-generated-content-expected.txt.
  • inspector/layers/layers-generated-content.html: Renamed from LayoutTests/inspector-protocol/layers/layers-generated-content.html.
  • inspector/layers/layers-reflected-content-expected.txt: Renamed from LayoutTests/inspector-protocol/layers/layers-reflected-content-expected.txt.
  • inspector/layers/layers-reflected-content.html: Renamed from LayoutTests/inspector-protocol/layers/layers-reflected-content.html.
  • inspector/page/archive-expected.txt: Renamed from LayoutTests/inspector-protocol/page/archive-expected.txt.
  • inspector/page/archive.html: Renamed from LayoutTests/inspector-protocol/page/archive.html.
  • inspector/page/frameScheduledNavigation-expected.txt: Renamed from LayoutTests/inspector-protocol/page/frameScheduledNavigation-expected.txt.
  • inspector/page/frameScheduledNavigation.html: Renamed from LayoutTests/inspector-protocol/page/frameScheduledNavigation.html.
  • inspector/page/frameStartedLoading-expected.txt: Renamed from LayoutTests/inspector-protocol/page/frameStartedLoading-expected.txt.
  • inspector/page/frameStartedLoading.html: Renamed from LayoutTests/inspector-protocol/page/frameStartedLoading.html.
  • inspector/page/javascriptDialogEvents-expected.txt: Renamed from LayoutTests/inspector-protocol/page/javascriptDialogEvents-expected.txt.
  • inspector/page/javascriptDialogEvents.html: Renamed from LayoutTests/inspector-protocol/page/javascriptDialogEvents.html.
  • inspector/page/resources/blank.html: Renamed from LayoutTests/inspector-protocol/page/resources/blank.html.
  • inspector/page/setEmulatedMedia-expected.txt: Renamed from LayoutTests/inspector-protocol/page/setEmulatedMedia-expected.txt.
  • inspector/page/setEmulatedMedia.html: Renamed from LayoutTests/inspector-protocol/page/setEmulatedMedia.html.
  • inspector/protocol/protocol-promise-result-expected.txt: Renamed from LayoutTests/inspector/protocol-promise-result-expected.txt.
  • inspector/protocol/protocol-promise-result.html: Renamed from LayoutTests/inspector/protocol-promise-result.html.
  • inspector/runtime/getProperties-expected.txt: Renamed from LayoutTests/inspector-protocol/runtime/getProperties-expected.txt.
  • inspector/runtime/getProperties.html: Renamed from LayoutTests/inspector-protocol/runtime/getProperties.html.
  • inspector/unit-tests/async-test-suite-expected.txt: Renamed from LayoutTests/inspector-protocol/async-test-suite-expected.txt.
  • inspector/unit-tests/async-test-suite.html: Renamed from LayoutTests/inspector-protocol/async-test-suite.html.
  • inspector/unit-tests/event-listener-expected.txt: Renamed from LayoutTests/inspector/event-listener-expected.txt.
  • inspector/unit-tests/event-listener-set-expected.txt: Renamed from LayoutTests/inspector/event-listener-set-expected.txt.
  • inspector/unit-tests/event-listener-set.html: Renamed from LayoutTests/inspector/event-listener-set.html.
  • inspector/unit-tests/event-listener.html: Renamed from LayoutTests/inspector/event-listener.html.
  • inspector/unit-tests/sync-test-suite-expected.txt: Renamed from LayoutTests/inspector-protocol/sync-test-suite-expected.txt.
  • inspector/unit-tests/sync-test-suite.html: Renamed from LayoutTests/inspector-protocol/sync-test-suite.html.
  • inspector/unit-tests/test-harness-trivially-works-expected.txt: Renamed from LayoutTests/inspector/test-harness-trivially-works-expected.txt.
  • inspector/unit-tests/test-harness-trivially-works.html: Renamed from LayoutTests/inspector/test-harness-trivially-works.html.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
11:27 AM Changeset in webkit [188141] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WinCairo build after r188130.

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
I forgot the parameter name.

11:22 AM Changeset in webkit [188140] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WinCairo build after r188130.

  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
Update fontPlatformData parameters.

11:11 AM Changeset in webkit [188139] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Running tests for a long time results in some tests running very slowly (throttling)
​https://bugs.webkit.org/show_bug.cgi?id=147718

Reviewed by Chris Dumez.

Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
Although COCOA ports default this setting to be disabled in WebKit1,
we should make both test harnesses disable the setting for consistency.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

10:58 AM Changeset in webkit [188138] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Option+Up/Down arrow keys should increment/decrement numbers in HTML and SVG attributes
​https://bugs.webkit.org/show_bug.cgi?id=147317

Reviewed by Timothy Hatcher.

If the value under the cursor in an HTML element attribute is a number, pressing alt and
up/down will increment/decrement the number value and apply that change to the element.

  • UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow.prototype._alteredFloatNumber):
(WebInspector.BoxModelDetailsSectionRow.prototype._handleKeyDown):

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._startEditingAttribute):
(WebInspector.DOMTreeElement.prototype._attributeEditingCommitted):
(WebInspector.DOMTreeElement.prototype._attributeNumberEditingCommitted):

  • UserInterface/Views/EditingSupport.js:

(WebInspector.EditingConfig.prototype.setNumberCommitHandler):
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing.handleEditingResult):

10:47 AM Changeset in webkit [188137] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Attempt to fix the Windows build after <​http://trac.webkit.org/changeset/188130>
(​https://bugs.webkit.org/show_bug.cgi?id=147775)

Include header FontDescription.h.

  • platform/graphics/win/FontCustomPlatformData.cpp:
  • platform/graphics/win/FontCustomPlatformDataCairo.cpp:
10:41 AM Changeset in webkit [188136] by saambarati1@gmail.com
  • 20 edits in trunk/Source/JavaScriptCore

Interpreter::unwind shouldn't be responsible for assigning the correct scope.
​https://bugs.webkit.org/show_bug.cgi?id=147666

Reviewed by Geoffrey Garen.

If we make the bytecode generator know about every local scope it
creates, and if we give each local scope a unique register, the
bytecode generator has all the information it needs to assign
the correct scope to a catch handler. Because the bytecode generator
knows this information, it's a better separation of responsibilties
for it to set up the proper scope instead of relying on the exception
handling runtime to find the scope.

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/HandlerInfo.h:

(JSC::UnlinkedHandlerInfo::UnlinkedHandlerInfo):
(JSC::HandlerInfo::initialize):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::emitGetScope):
(JSC::BytecodeGenerator::emitPushWithScope):
(JSC::BytecodeGenerator::emitGetParentScope):
(JSC::BytecodeGenerator::emitPopScope):
(JSC::BytecodeGenerator::emitPopWithScope):
(JSC::BytecodeGenerator::allocateAndEmitScope):
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::pushTry):
(JSC::BytecodeGenerator::popTryAndEmitCatch):
(JSC::BytecodeGenerator::localScopeDepth):
(JSC::BytecodeGenerator::calculateTargetScopeDepthForExceptionHandler): Deleted.

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::WithNode::emitBytecode):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::compileOpStrictEq):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_push_with_scope):
(JSC::JIT::emit_op_to_number):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:
  • runtime/JSScope.cpp:

(JSC::JSScope::objectAtScope):
(JSC::isUnscopable):
(JSC::JSScope::depth): Deleted.

  • runtime/JSScope.h:
10:31 AM Changeset in webkit [188135] by Yusuke Suzuki
  • 6 edits in trunk/Source/JavaScriptCore

Add MacroAssembler::patchableBranch64 and fix ARM64's patchableBranchPtr
​https://bugs.webkit.org/show_bug.cgi?id=147761

Reviewed by Mark Lam.

This patch implements MacroAssembler::patchableBranch64 in 64bit environments.
And fix the existing MacroAssemblerARM64::patchableBranchPtr, before this patch,
it truncates the immediate pointer into the 32bit immediate.
And use patchableBranch64 in the baseline JIT under the JSVALUE64 configuration.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::patchableBranchPtr):
(JSC::MacroAssemblerARM64::patchableBranch64):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::patchableBranch64):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::emitPatchableJumpIfNotImmediateInteger):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):

10:30 AM Changeset in webkit [188134] by Simon Fraser
  • 1 edit
    37 deletes in trunk/LayoutTests

ios-sim-deprecated/iphone/fast/events/touch/ already existed in fast/events/touch, so remove them.

  • platform/ios-sim-deprecated/iphone/fast/events/touch/document-create-touch-list-ios-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/document-create-touch-list-ios.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/gesture-event-basic-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/gesture-event-basic.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/input-touch-target-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/input-touch-target.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/inserted-fragment-touch-target-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/inserted-fragment-touch-target.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/moved-touch-target-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/moved-touch-target.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/multi-touch-some-without-handlers-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/multi-touch-some-without-handlers.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/ontouchstart-active-selector-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/ontouchstart-active-selector.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/removed-fragment-touch-target-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/removed-fragment-touch-target.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/removed-touch-target-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/removed-touch-target.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/TEMPLATE.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/document-create-touch-list-ios.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/input-touch-target.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/multi-touch-some-without-handlers.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/text-node-touch-target.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/textarea-touch-target.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/touch-event-frames.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/touch-event-pageXY.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/zoomed-touch-event-pageXY.js: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/text-node-touch-target-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/text-node-touch-target.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/textarea-touch-target-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/textarea-touch-target.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-frames-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-frames.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-pageXY-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-pageXY.html: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/zoomed-touch-event-pageXY-expected.txt: Removed.
  • platform/ios-sim-deprecated/iphone/fast/events/touch/zoomed-touch-event-pageXY.html: Removed.
10:30 AM Changeset in webkit [188133] by Simon Fraser
  • 1 edit
    2 moves in trunk/LayoutTests

Move platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html into http/tests/loading/

  • http/tests/loading/multiple-prioritization-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt.
  • http/tests/loading/multiple-prioritization.html: Renamed from LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html.
10:30 AM Changeset in webkit [188132] by Simon Fraser
  • 5 edits
    6 moves
    3 adds
    2 deletes in trunk/LayoutTests

Move ios-sim-deprecated/fast/dom/ tests into fast/dom

  • TestExpectations:
  • fast/dom/Range/expand-word-with-apostrophe-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe-expected.txt.
  • fast/dom/Range/expand-word-with-apostrophe.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe.html.
  • fast/dom/Window/no-window-resize-on-document-size-change-expected.txt: Added.
  • fast/dom/Window/no-window-resize-on-document-size-change.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Window/no-window-resize-on-document-size-change.html.
  • fast/dom/adopt-attribute-crash-expected.txt:
  • fast/dom/navigator-iOS-userAgent-expected.txt: Added.
  • fast/dom/navigator-iOS-userAgent.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/navigator-iOS-userAgent.html.
  • fast/dom/timer-fire-after-page-pause-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause-expected.txt.
  • fast/dom/timer-fire-after-page-pause.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause.html.
  • platform/ios-sim-deprecated/fast/dom/Window/no-window-resize-on-document-size-change-expected.txt: Removed.
  • platform/ios-sim-deprecated/fast/dom/navigator-iOS-userAgent-expected.txt: Removed.
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/fast/dom/navigator-iOS-userAgent-expected.txt: Added.
10:30 AM Changeset in webkit [188131] by Simon Fraser
  • 4 edits
    1 copy
    4 moves
    1 delete in trunk/LayoutTests

Move two ios-sim-deprecated/animations/ tests into animations.

  • animations/resources/anim.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/resources/anim.html.
  • animations/restart-after-scroll-expected.txt: Copied from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt.
  • animations/restart-after-scroll-nested-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt.
  • animations/restart-after-scroll-nested.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested.html.
  • animations/restart-after-scroll.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll.html.
  • platform/ios-sim-deprecated/animations/restart-after-scroll-expected.txt: Removed.
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
10:06 AM Changeset in webkit [188130] by mmaxfield@apple.com
  • 15 edits in trunk/Source/WebCore

Allow FontCustomPlatformData to consult with FontDescription
​https://bugs.webkit.org/show_bug.cgi?id=147775

Reviewed by Zalan Bujtas.

In order to implement font-feature-settings, web fonts need to be
able to consult with the set of active font features. Rather than
add yet another argument to all the functions in this flow, this
patch passes around a reference to the FontDescription itself instead
of copies of constituent members of it.

No new tests because there is no behavior change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::createFont):
(WebCore::CachedFont::platformDataFromCustomData):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::platformDataFromCustomData):

  • loader/cache/CachedSVGFont.h:
  • platform/graphics/cairo/FontCustomPlatformData.h:
  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/freetype/FontPlatformData.h:
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformCreateScaledFont):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/mac/FontCustomPlatformData.h:
  • platform/graphics/win/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

  • platform/graphics/win/FontCustomPlatformData.h:
10:04 AM Changeset in webkit [188129] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Use a specific version of Speedometer in run-benchmark
​https://bugs.webkit.org/show_bug.cgi?id=147769

Reviewed by Chris Dumez.

Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).

  • Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
9:36 AM Changeset in webkit [188128] by rniwa@webkit.org
  • 2 edits in trunk/Tools

twisted_http_server.py should support --port
​https://bugs.webkit.org/show_bug.cgi?id=147771

Reviewed by Chris Dumez.

Added the option. This makes the script more useful on its own.

  • Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
9:35 AM Changeset in webkit [188127] by calvaris@igalia.com
  • 22 edits
    3 adds
    1 delete in trunk

[Streams API] Create CountQueuingStrategy object as per spec
​https://bugs.webkit.org/show_bug.cgi?id=146594

Reviewed by Geoffrey Garen.

Source/WebCore:

CountQueuingStrategy is a class part of the Streams API that can be found at
​https://streams.spec.whatwg.org/#cqs-class. We had it as js at the tests but the spec says we have to provide it
natively. The class is implemented in this patch by creating its corresponding IDL with the size method using
the [CustomBinding] attribute, that does not create any bindings against the object allowing us full control to
do what the spec requires (just returning 1 without any cast check). The constructor sets the highWaterMark
property taking it from the argument.

Covered by current tests
(LayoutTests/streams/reference-implementation/count-queuing-strategy.html and
LayoutTests/streams/reference-implementation/brand-checks.html).

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • PlatformMac.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Build infrastructure.
  • Modules/streams/CountQueuingStrategy.h: Added.

(WebCore::CountQueuingStrategy::~CountQueuingStrategy): Created empty.
(WebCore::CountQueuingStrategy::size): Returns 1.

  • Modules/streams/CountQueuingStrategy.idl: Added.
  • bindings/js/JSCountQueuingStrategyCustom.cpp: Added.

(WebCore::jsCountQueuingStrategyPrototypeFunctionSize): Calls WebCore::CountQueuingStrategy::size.
(WebCore::constructJSCountQueuingStrategy): Constructs the strategy, copies the highWaterMark from the argument
and returns it.

  • bindings/js/JSDOMBinding.h:

(WebCore::getPropertyFromObject): Moved from ReadableJSStream.cpp.
(WebCore::setPropertyToObject): Added to create a property into an object.

  • bindings/js/ReadableJSStream.cpp:

(WebCore::getPropertyFromObject): Deleted.

LayoutTests:

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt: Updated expectations with

CountQueuingStrategy constructor.

  • streams/reference-implementation/brand-checks.html:
  • streams/reference-implementation/count-queuing-strategy.html: Removed reference to count-queuing-strategy.js.
  • streams/reference-implementation/resources/count-queuing-strategy.js: Removed.

(CountQueuingStrategy): Deleted.
(CountQueuingStrategy.prototype.size): Deleted.

9:04 AM Changeset in webkit [188126] by beidson@apple.com
  • 10 edits
    8 moves in trunk/Source

Move concrete KeyedDecoder/Encoder implementations to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=147757.

Rubberstamped by Andy Estes.

Source/WebCore:

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/KeyedCoding.h:

(WebCore::KeyedDecoder::KeyedDecoder): Static constructor to be implemented per-platform.
(WebCore::KeyedEncoder::KeyedEncoder): Ditto.

  • platform/cf/KeyedDecoderCF.cpp: Renamed from Source/WebKit2/Shared/cf/KeyedDecoder.cpp.

(WebCore::KeyedDecoder::decoder):
(WebCore::KeyedDecoderCF::KeyedDecoderCF):
(WebCore::KeyedDecoderCF::~KeyedDecoderCF):
(WebCore::KeyedDecoderCF::decodeBytes):
(WebCore::KeyedDecoderCF::decodeBool):
(WebCore::KeyedDecoderCF::decodeUInt32):
(WebCore::KeyedDecoderCF::decodeInt32):
(WebCore::KeyedDecoderCF::decodeInt64):
(WebCore::KeyedDecoderCF::decodeFloat):
(WebCore::KeyedDecoderCF::decodeDouble):
(WebCore::KeyedDecoderCF::decodeString):
(WebCore::KeyedDecoderCF::beginObject):
(WebCore::KeyedDecoderCF::endObject):
(WebCore::KeyedDecoderCF::beginArray):
(WebCore::KeyedDecoderCF::beginArrayElement):
(WebCore::KeyedDecoderCF::endArrayElement):
(WebCore::KeyedDecoderCF::endArray):

  • platform/cf/KeyedDecoderCF.h: Renamed from Source/WebKit2/Shared/cf/KeyedDecoder.h.
  • platform/cf/KeyedEncoderCF.cpp: Renamed from Source/WebKit2/Shared/cf/KeyedEncoder.cpp.

(WebCore::KeyedEncoder::encoder):
(WebCore::createDictionary):
(WebCore::KeyedEncoderCF::KeyedEncoderCF):
(WebCore::KeyedEncoderCF::~KeyedEncoderCF):
(WebCore::KeyedEncoderCF::encodeBytes):
(WebCore::KeyedEncoderCF::encodeBool):
(WebCore::KeyedEncoderCF::encodeUInt32):
(WebCore::KeyedEncoderCF::encodeInt32):
(WebCore::KeyedEncoderCF::encodeInt64):
(WebCore::KeyedEncoderCF::encodeFloat):
(WebCore::KeyedEncoderCF::encodeDouble):
(WebCore::KeyedEncoderCF::encodeString):
(WebCore::KeyedEncoderCF::beginObject):
(WebCore::KeyedEncoderCF::endObject):
(WebCore::KeyedEncoderCF::beginArray):
(WebCore::KeyedEncoderCF::beginArrayElement):
(WebCore::KeyedEncoderCF::endArrayElement):
(WebCore::KeyedEncoderCF::endArray):
(WebCore::KeyedEncoderCF::finishEncoding):

  • platform/cf/KeyedEncoderCF.h: Renamed from Source/WebKit2/Shared/cf/KeyedEncoder.h.
  • platform/glib/KeyedDecoderGlib.cpp: Renamed from Source/WebKit2/Shared/glib/KeyedDecoder.cpp.

(WebCore::KeyedDecoder::decoder):
(WebCore::KeyedDecoderGlib::KeyedDecoderGlib):
(WebCore::KeyedDecoderGlib::~KeyedDecoderGlib):
(WebCore::KeyedDecoderGlib::dictionaryFromGVariant):
(WebCore::KeyedDecoderGlib::decodeBytes):
(WebCore::KeyedDecoderGlib::decodeSimpleValue):
(WebCore::KeyedDecoderGlib::decodeBool):
(WebCore::KeyedDecoderGlib::decodeUInt32):
(WebCore::KeyedDecoderGlib::decodeInt32):
(WebCore::KeyedDecoderGlib::decodeInt64):
(WebCore::KeyedDecoderGlib::decodeFloat):
(WebCore::KeyedDecoderGlib::decodeDouble):
(WebCore::KeyedDecoderGlib::decodeString):
(WebCore::KeyedDecoderGlib::beginObject):
(WebCore::KeyedDecoderGlib::endObject):
(WebCore::KeyedDecoderGlib::beginArray):
(WebCore::KeyedDecoderGlib::beginArrayElement):
(WebCore::KeyedDecoderGlib::endArrayElement):
(WebCore::KeyedDecoderGlib::endArray):

  • platform/glib/KeyedDecoderGlib.h: Renamed from Source/WebKit2/Shared/glib/KeyedDecoder.h.
  • platform/glib/KeyedEncoderGlib.cpp: Renamed from Source/WebKit2/Shared/glib/KeyedEncoder.cpp.

(WebCore::KeyedEncoder::encoder):
(WebCore::KeyedEncoderGlib::KeyedEncoderGlib):
(WebCore::KeyedEncoderGlib::~KeyedEncoderGlib):
(WebCore::KeyedEncoderGlib::encodeBytes):
(WebCore::KeyedEncoderGlib::encodeBool):
(WebCore::KeyedEncoderGlib::encodeUInt32):
(WebCore::KeyedEncoderGlib::encodeInt32):
(WebCore::KeyedEncoderGlib::encodeInt64):
(WebCore::KeyedEncoderGlib::encodeFloat):
(WebCore::KeyedEncoderGlib::encodeDouble):
(WebCore::KeyedEncoderGlib::encodeString):
(WebCore::KeyedEncoderGlib::beginObject):
(WebCore::KeyedEncoderGlib::endObject):
(WebCore::KeyedEncoderGlib::beginArray):
(WebCore::KeyedEncoderGlib::beginArrayElement):
(WebCore::KeyedEncoderGlib::endArrayElement):
(WebCore::KeyedEncoderGlib::endArray):
(WebCore::KeyedEncoderGlib::finishEncoding):

  • platform/glib/KeyedEncoderGlib.h: Renamed from Source/WebKit2/Shared/glib/KeyedEncoder.h.

Source/WebKit2:

  • DatabaseProcess/IndexedDB/IDBSerialization.cpp:

(WebKit::serializeIDBKeyPath):
(WebKit::deserializeIDBKeyPath):
(WebKit::serializeIDBKeyData):
(WebKit::deserializeIDBKeyData):

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebKit2.xcodeproj/project.pbxproj:
8:28 AM Changeset in webkit [188125] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] WTF unit tests are timing out in the bots
​https://bugs.webkit.org/show_bug.cgi?id=147777

Reviewed by Filip Pizlo.

Add a way to mark google unit tests as slow and add
WTF_Lock.ContentedShortSection to the list. In case of slow test
we use the double of the given timeout for that particular test.

  • Scripts/run-gtk-tests:

(TestRunner):
(TestRunner._run_google_test):

5:01 AM WebKitIDL edited by calvaris@igalia.com
(diff)
4:17 AM Changeset in webkit [188124] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ compile warning also introduced in r188121.

  • UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp:

(webkit_install_missing_media_plugins_permission_request_get_description):

3:51 AM Changeset in webkit [188123] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ debug build after r188121.

  • UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp:

(webkit_install_missing_media_plugins_permission_request_get_description):

3:27 AM Changeset in webkit [188122] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests should not stop when a google test case fails
​https://bugs.webkit.org/show_bug.cgi?id=147778

Reviewed by Philippe Normand.

For glib based tests we run the test runner with the -k option,
but for google tests we are aborting as soon as we find a failure.

  • Scripts/run-gtk-tests:

(TestRunner._run_google_test_suite): Use a global return code that
is set to 1 when any test has failed.

2:51 AM Changeset in webkit [188121] by Carlos Garcia Campos
  • 34 edits
    2 copies
    3 adds in trunk

[GStreamer] Do not automatically show PackageKit codec installation notifications
​https://bugs.webkit.org/show_bug.cgi?id=135973

Reviewed by Philippe Normand.

Source/WebCore:

Add description parameter to requestInstallMissingPlugins() that
will be used by the API layer.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::requestInstallMissingPlugins):

  • html/HTMLMediaElement.h:
  • page/ChromeClient.h:
  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::requestInstallMissingPlugins):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

Source/WebKit2:

Add InstallMissingMediaPluginsPermissionRequest to ask the API
layer whether to allow or deny the installation of missing media
plugins. And add a GTK+ implementation based on current permission
request API. Replace the
PageClientImpl::createGstInstallPluginsContext() with
decicePolicyForInstallMissingMediaPluginsPermissionRequest() that
passes the InstallMissingMediaPluginsPermissionRequest object to
the API layer. The allow method receives the
GstInstallPluginsContext now, so that it can be created by the API implementation.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::decicePolicyForInstallMissingMediaPluginsPermissionRequest):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: Added.

(createGstInstallPluginsContext):
(webkitInstallMissingMediaPluginsPermissionRequestAllow):
(webkitInstallMissingMediaPluginsPermissionRequestDeny):
(webkit_permission_request_interface_init):
(webkitInstallMissingMediaPluginsPermissionRequestDispose):
(webkit_install_missing_media_plugins_permission_request_class_init):
(webkitInstallMissingMediaPluginsPermissionRequestCreate):
(webkit_install_missing_media_plugins_permission_request_get_description):

  • UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.h: Added.
  • UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequestPrivate.h: Added.
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRequestInstallMissingMediaPlugins):

  • UIProcess/API/gtk/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0.types:
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
  • UIProcess/API/gtk/webkit2.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/efl/WebViewEfl.h:
  • UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp: Copied from Source/WebKit2/UIProcess/gstreamer/WebPageProxyGStreamer.cpp.

(WebKit::InstallMissingMediaPluginsPermissionRequest::InstallMissingMediaPluginsPermissionRequest):
(WebKit::InstallMissingMediaPluginsPermissionRequest::~InstallMissingMediaPluginsPermissionRequest):
(WebKit::InstallMissingMediaPluginsPermissionRequest::allow):
(WebKit::InstallMissingMediaPluginsPermissionRequest::deny):
(WebKit::InstallMissingMediaPluginsPermissionRequest::didEndRequestInstallMissingMediaPlugins):

  • UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h: Copied from Source/WebKit2/WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp.

(WebKit::InstallMissingMediaPluginsPermissionRequest::create):
(WebKit::InstallMissingMediaPluginsPermissionRequest::page):
(WebKit::InstallMissingMediaPluginsPermissionRequest::details):
(WebKit::InstallMissingMediaPluginsPermissionRequest::description):

  • UIProcess/gstreamer/WebPageProxyGStreamer.cpp:

(WebKit::WebPageProxy::requestInstallMissingMediaPlugins):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::requestInstallMissingMediaPlugins):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp:

(WebKit::WebPage::requestInstallMissingMediaPlugins):

Tools:

Handle the missing media plugins installation permission request
in MiniBrowser and add a test case for the new API.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewDecidePermissionRequest):

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(permissionRequestCallback):
(testInstallMissingPluginsPermissionRequest):
(beforeAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(methodCallCallback):

1:32 AM Changeset in webkit [188120] by commit-queue@webkit.org
  • 4 edits in trunk

AX: Bug 147737 is causing test failures in Mavericks WK1
​https://bugs.webkit.org/show_bug.cgi?id=147763

Source/WebCore:

Restrict change made in 147737 to ElCapitan+ because it is causing tests
to fail in Mavericks.

Patch by Doug Russell <​d_russell@apple.com> on 2015-08-07
Reviewed by Chris Fleizach.

Fixes failing tests.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):

LayoutTests:

Patch by Doug Russell <​d_russell@apple.com> on 2015-08-07
Reviewed by Chris Fleizach.

  • platform/mac/TestExpectations:
1:15 AM Changeset in webkit [188119] by calvaris@igalia.com
  • 8 edits in trunk/Source/WebCore

Create [CustomBinding] extended IDL attribute
​https://bugs.webkit.org/show_bug.cgi?id=146593

Reviewed by Geoffrey Garen.

Added the [CustomBinding] IDL extended attribute. The idea is that when using this attribute, bindings generate
only the signature of the JS functions and we have to implement all the access in the Custom.cpp files, meaning
accessing the implementations at our wish.

Added customBindingMethod, customBindingMethodWithArgs to the generator tests.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Skipped [CustomBinding] methods.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Consider CustomBinding as ForwardDeclareInHeader.
(GenerateImplementation): Avoid printing both header and implementation of the function.

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipFunction): Skipped [CustomBinding] methods.

  • bindings/scripts/IDLAttributes.txt: Added [CustomBinding] IDL extended attribute.
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/TestObj.idl: Added customBindingMethod, customBindingMethodWithArgs and their

expectations.

Aug 6, 2015:

11:48 PM Changeset in webkit [188118] by zandobersek@gmail.com
  • 37 edits in trunk/Source/WebCore

Source/WebCore/crypto code should pass std::function<> objects through rvalue references
​https://bugs.webkit.org/show_bug.cgi?id=147332

Reviewed by Anders Carlsson.

Pass the std::function<> callbacks through CryptoAlgorithm methods via
rvlaue references. This avoids generation of unnecessary move and copy
constructors for std::function<> objects that are being handled.

  • crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::encrypt):
(WebCore::CryptoAlgorithm::decrypt):
(WebCore::CryptoAlgorithm::sign):
(WebCore::CryptoAlgorithm::verify):
(WebCore::CryptoAlgorithm::digest):
(WebCore::CryptoAlgorithm::generateKey):
(WebCore::CryptoAlgorithm::deriveKey):
(WebCore::CryptoAlgorithm::deriveBits):
(WebCore::CryptoAlgorithm::importKey):
(WebCore::CryptoAlgorithm::encryptForWrapKey):
(WebCore::CryptoAlgorithm::decryptForUnwrapKey):

  • crypto/CryptoAlgorithm.h:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
(WebCore::CryptoAlgorithmAES_CBC::importKey):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey):
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey):
(WebCore::CryptoAlgorithmAES_KW::generateKey):
(WebCore::CryptoAlgorithmAES_KW::importKey):

  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
(WebCore::CryptoAlgorithmHMAC::generateKey):
(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::encrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::decrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::generateKey):
(WebCore::CryptoAlgorithmRSA_OAEP::importKey):

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmSHA1.cpp:

(WebCore::CryptoAlgorithmSHA1::digest):

  • crypto/algorithms/CryptoAlgorithmSHA1.h:
  • crypto/algorithms/CryptoAlgorithmSHA224.cpp:

(WebCore::CryptoAlgorithmSHA224::digest):

  • crypto/algorithms/CryptoAlgorithmSHA224.h:
  • crypto/algorithms/CryptoAlgorithmSHA256.cpp:

(WebCore::CryptoAlgorithmSHA256::digest):

  • crypto/algorithms/CryptoAlgorithmSHA256.h:
  • crypto/algorithms/CryptoAlgorithmSHA384.cpp:

(WebCore::CryptoAlgorithmSHA384::digest):

  • crypto/algorithms/CryptoAlgorithmSHA384.h:
  • crypto/algorithms/CryptoAlgorithmSHA512.cpp:

(WebCore::CryptoAlgorithmSHA512::digest):

  • crypto/algorithms/CryptoAlgorithmSHA512.h:
  • crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):

  • crypto/gnutls/CryptoAlgorithmHMACGnuTLS.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/gnutls/CryptoAlgorithmRSAES_PKCS1_v1_5GnuTLS.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

11:17 PM Changeset in webkit [188117] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed, work around assertions in Windows's std::atomic.

  • wtf/Atomics.h:

(WTF::Atomic::compareExchangeWeak):
(WTF::Atomic::compareExchangeStrong):

10:15 PM Changeset in webkit [188116] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix GTK clean build after r187997
​https://bugs.webkit.org/show_bug.cgi?id=147723

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-08-06
Reviewed by Gyuyoung Kim.

  • CMakeLists.txt:

r187997 made it so WebCoreTestSupport does not link with WebCore, which is necessary to get DumpRenderTree to link.
It also made it so WebCoreTestSupport is no longer dependent on WebCore, which causes it to build at the same time.
This caused problems because WebCoreTestSupport uses headers that are generated for WebCore, such as WebKitFontFamilyNames.h.
Adding a dependency makes it so that WebCoreTestSupport waits until WebCore is done compiling before compiling,
which is what it used to do, but it does not cause linking problems with DumpRenderTree.

10:09 PM Changeset in webkit [188115] by Beth Dakin
  • 2 edits in trunk/Source/WebKit2

TextIndicator can have stale contentImage data and crash
​https://bugs.webkit.org/show_bug.cgi?id=147770
-and corresponding-
rdar://problem/22181735

Reviewed by Tim Horton.

If there is no contentImage or contentImageWithHighlight, set them to
nullptr.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextIndicatorData>::decode):

9:21 PM Changeset in webkit [188114] by mmaxfield@apple.com
  • 4 edits in trunk/Source/WebCore

CSSSegmentedFontFace::fontRanges() does not handle duplicate fonts correctly
​https://bugs.webkit.org/show_bug.cgi?id=147765

Reviewed by Filip Pizlo.

CSSSegmentedFontFace::fontRanges() was trying to hash on FontDescriptors by
picking a few specific pieces of data out of the FontDescriptor, computing
a hash on it, and using that unsigned as a key in a HashMap. This has two
problems: it doesn't handle equality correctly, as hash collisions cannot
depend on an equality operator to dedup, and it doesn't hash on all the
members of a FontDescription.

Instead, this HashMap should use FontDescriptionKey, which represents a
FontDescription, and is designed exactly for the purpose of being used as a
key in a HashMap.

No new tests because there is no behavior change (because a problem occurs
when two different FontDescriptions hash to the same value, which is rare).

  • css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::fontRanges):

  • css/CSSSegmentedFontFace.h:
  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKeyHash::hash):
(WebCore::FontDescriptionKeyHash::equal):

9:17 PM Changeset in webkit [188113] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Unreviewed, reduce the duration of a Lock unit test. It was timing out.

  • TestWebKitAPI/Tests/WTF/Lock.cpp:

(TestWebKitAPI::TEST):

8:44 PM Changeset in webkit [188112] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed all the builds after trying to fix the non-HAVE(LINK_PREVIEW) build.

  • UIProcess/ios/WKContentViewInteraction.mm:
8:41 PM Changeset in webkit [188111] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed the non-HAVE(LINK_PREVIEW) build.

  • UIProcess/ios/WKContentViewInteraction.mm:
8:34 PM Changeset in webkit [188110] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

8:27 PM Changeset in webkit [188109] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Cleanup action sheet only when long press is canceled (non ended).
​https://bugs.webkit.org/show_bug.cgi?id=147766
rdar://problem/22181842

Reviewed by Tim Horton.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _longPressRecognized:]):

7:54 PM Changeset in webkit [188108] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.4

New tag.

7:51 PM Changeset in webkit [188107] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebKit2

Roll out r188053. rdar://problem/22128839

7:49 PM Changeset in webkit [188106] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Roll out r188058. rdar://problem/22128839

7:08 PM Changeset in webkit [188105] by Yusuke Suzuki
  • 38 edits
    51 adds in trunk

Introduce get_by_id like IC into get_by_val when the given name is String or Symbol
​https://bugs.webkit.org/show_bug.cgi?id=147480

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch adds get_by_id IC to get_by_val operation by caching the string / symbol id.
The IC site only caches one id. After checking that the given id is the same to the
cached one, we perform the get_by_id IC onto it.
And by collecting IC StructureStubInfo information, we pass it to the DFG and DFG
compiles get_by_val op code into CheckIdent (with edge type check) and GetById related
operations when the given get_by_val leverages the property load with the cached id.

To ensure the incoming value is the expected id, in DFG layer, we use SymbolUse and
StringIdentUse to enforce the type. To use it, this patch implements SymbolUse.
This can be leveraged to optimize symbol operations in DFG.

And since byValInfo is frequently used, we align the byValInfo design to the stubInfo like one.
Allocated by the Bag and operations take the raw byValInfo pointer directly instead of performing
binary search onto m_byValInfos. And by storing ArrayProfile* under the ByValInfo, we replaced the
argument ArrayProfile* in the operations with ByValInfo*.

  • bytecode/ByValInfo.h:

(JSC::ByValInfo::ByValInfo):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::getByValInfoMap):
(JSC::CodeBlock::addByValInfo):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getByValInfo): Deleted.
(JSC::CodeBlock::setNumberOfByValInfos): Deleted.
(JSC::CodeBlock::numberOfByValInfos): Deleted.
(JSC::CodeBlock::byValInfo): Deleted.

  • bytecode/ExitKind.cpp:

(JSC::exitKindToString):

  • bytecode/ExitKind.h:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):

  • bytecode/GetByIdStatus.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::observeUseKindOnNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasUidOperand):
(JSC::DFG::Node::uidOperand):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCheckIdent):
(JSC::DFG::SpeculativeJIT::speculateSymbol):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckIdent):
(JSC::FTL::DFG::LowerDFGToLLVM::lowSymbol):
(JSC::FTL::DFG::LowerDFGToLLVM::speculate):
(JSC::FTL::DFG::LowerDFGToLLVM::isNotSymbol):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateSymbol):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::ByValCompilationInfo::ByValCompilationInfo):
(JSC::JIT::compileGetByValWithCachedId):

  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):

  • jit/JITOperations.cpp:

(JSC::getByVal):

  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompileGetByValWithCachedId):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):

  • runtime/Symbol.h:
  • tests/stress/get-by-val-with-string-constructor.js: Added.

(Hello):
(get Hello.prototype.generate):
(ok):

  • tests/stress/get-by-val-with-string-exit.js: Added.

(shouldBe):
(getByVal):
(getStr1):
(getStr2):

  • tests/stress/get-by-val-with-string-generated.js: Added.

(shouldBe):
(getByVal):
(getStr1):
(getStr2):

  • tests/stress/get-by-val-with-string-getter.js: Added.

(object.get hello):
(ok):

  • tests/stress/get-by-val-with-string.js: Added.

(shouldBe):
(getByVal):
(getStr1):
(getStr2):

  • tests/stress/get-by-val-with-symbol-constructor.js: Added.

(Hello):
(get Hello.prototype.generate):
(ok):

  • tests/stress/get-by-val-with-symbol-exit.js: Added.

(shouldBe):
(getByVal):
(getSym1):
(getSym2):

  • tests/stress/get-by-val-with-symbol-getter.js: Added.

(object.get hello):
(.get ok):

  • tests/stress/get-by-val-with-symbol.js: Added.

(shouldBe):
(getByVal):
(getSym1):
(getSym2):

LayoutTests:

Add synthetic benchmarks that replaces normal property load with symbol/string keyed load.

  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-expected.txt: Added.
  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple-expected.txt: Added.
  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination-simple.html: Added.
  • js/regress/get-by-val-with-string-bimorphic-check-structure-elimination.html: Added.
  • js/regress/get-by-val-with-string-chain-from-try-block-expected.txt: Added.
  • js/regress/get-by-val-with-string-chain-from-try-block.html: Added.
  • js/regress/get-by-val-with-string-check-structure-elimination-expected.txt: Added.
  • js/regress/get-by-val-with-string-check-structure-elimination.html: Added.
  • js/regress/get-by-val-with-string-proto-or-self-expected.txt: Added.
  • js/regress/get-by-val-with-string-proto-or-self.html: Added.
  • js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple-expected.txt: Added.
  • js/regress/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.html: Added.
  • js/regress/get-by-val-with-string-self-or-proto-expected.txt: Added.
  • js/regress/get-by-val-with-string-self-or-proto.html: Added.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-expected.txt: Added.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple-expected.txt: Added.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.html: Added.
  • js/regress/get-by-val-with-symbol-bimorphic-check-structure-elimination.html: Added.
  • js/regress/get-by-val-with-symbol-chain-from-try-block-expected.txt: Added.
  • js/regress/get-by-val-with-symbol-chain-from-try-block.html: Added.
  • js/regress/get-by-val-with-symbol-check-structure-elimination-expected.txt: Added.
  • js/regress/get-by-val-with-symbol-check-structure-elimination.html: Added.
  • js/regress/get-by-val-with-symbol-proto-or-self-expected.txt: Added.
  • js/regress/get-by-val-with-symbol-proto-or-self.html: Added.
  • js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple-expected.txt: Added.
  • js/regress/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.html: Added.
  • js/regress/get-by-val-with-symbol-self-or-proto-expected.txt: Added.
  • js/regress/get-by-val-with-symbol-self-or-proto.html: Added.
  • js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination-simple.js: Added.
  • js/regress/script-tests/get-by-val-with-string-bimorphic-check-structure-elimination.js: Added.
  • js/regress/script-tests/get-by-val-with-string-chain-from-try-block.js: Added.

(A):
(B):
(C):
(D):
(E):
(F):
(G):
(foo):

  • js/regress/script-tests/get-by-val-with-string-check-structure-elimination.js: Added.
  • js/regress/script-tests/get-by-val-with-string-proto-or-self.js: Added.

(foo):
(bar):
(Foo):

  • js/regress/script-tests/get-by-val-with-string-quadmorphic-check-structure-elimination-simple.js: Added.
  • js/regress/script-tests/get-by-val-with-string-self-or-proto.js: Added.

(foo):
(bar):
(Foo):

  • js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination-simple.js: Added.
  • js/regress/script-tests/get-by-val-with-symbol-bimorphic-check-structure-elimination.js: Added.
  • js/regress/script-tests/get-by-val-with-symbol-chain-from-try-block.js: Added.

(A):
(B):
(C):
(D):
(E):
(F):
(G):
(foo):

  • js/regress/script-tests/get-by-val-with-symbol-check-structure-elimination.js: Added.
  • js/regress/script-tests/get-by-val-with-symbol-proto-or-self.js: Added.

(foo):
(bar):
(Foo):

  • js/regress/script-tests/get-by-val-with-symbol-quadmorphic-check-structure-elimination-simple.js: Added.
  • js/regress/script-tests/get-by-val-with-symbol-self-or-proto.js: Added.

(foo):
(bar):
(Foo):

6:36 PM Changeset in webkit [188104] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Remove dead code from FontCache::createFontPlatformData()
​https://bugs.webkit.org/show_bug.cgi?id=147762

Reviewed by Andy Estes.

No new tests because there is no behavior change.

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::createFontPlatformData): Deleted.

6:29 PM Changeset in webkit [188103] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Revert part of my "build fix" in r188101.

  • CMakeLists.txt:

MockCDM was already conditionally added to WebCore_SOURCES, and that change causes dependency cycles when bug 147723 is fixed.

6:22 PM Changeset in webkit [188102] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Running tests for a long time results in some tests running very slowly (throttling)
​https://bugs.webkit.org/show_bug.cgi?id=147718

Reviewed by Alexey Proskuryakov.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
Ensure throttling settings are disabled for tests for all ports, as
COCOA ports default to having these setting enabled. Note, there is
still other timer throttling not covered by these setting.

6:03 PM Changeset in webkit [188101] by achristensen@apple.com
  • 4 edits in trunk

[Win] CMake build fix after r188098.

.:

  • Source/cmake/OptionsWinCairo.cmake:

OptionsWindows.cmake uses WTF_PLATFORM_WIN_CAIRO now, so we need to set it before including OptionsWindows.

Source/WebCore:

  • CMakeLists.txt:

MockCDM is necessary for testing if ENCRYPTED_MEDIA_V2 is enabled.

5:49 PM Changeset in webkit [188100] by fpizlo@apple.com
  • 40 edits
    5 adds in trunk

Lightweight locks should be adaptive
​https://bugs.webkit.org/show_bug.cgi?id=147545

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::workListLock):

  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::shouldReportLiveBytes):
(JSC::CopiedBlock::reportLiveBytes):

  • heap/CopiedSpace.h:

(JSC::CopiedSpace::CopiedGeneration::CopiedGeneration):

  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::recycleEvacuatedBlock):

  • heap/GCThreadSharedData.h:

(JSC::GCThreadSharedData::getNextBlocksToCopy):

  • heap/ListableHandler.h:

(JSC::ListableHandler::List::addThreadSafe):
(JSC::ListableHandler::List::addNotThreadSafe):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::copyLater):

  • runtime/TypeProfilerLog.h:

Source/WebCore:

No new tests because no new behavior.

  • bindings/objc/WebScriptObject.mm:

(WebCore::getJSWrapper):
(WebCore::addJSWrapper):
(WebCore::removeJSWrapper):
(WebCore::removeJSWrapperIfRetainCountOne):

  • platform/ios/wak/WAKWindow.mm:

(-[WAKWindow setExposedScrollViewRect:]):
(-[WAKWindow exposedScrollViewRect]):

Source/WebKit2:

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::clearQueuedTouchEventsForPage):
(WebKit::EventDispatcher::getQueuedTouchEventsForPage):
(WebKit::EventDispatcher::touchEvent):
(WebKit::EventDispatcher::dispatchTouchEvents):

  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
(WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate):

  • WebProcess/WebPage/ViewUpdateDispatcher.h:

Source/WTF:

A common idiom in WebKit is to use spinlocks. We use them because the lock acquisition
overhead is lower than system locks and because they take dramatically less space than system
locks. The speed and space advantages of spinlocks can be astonishing: an uncontended spinlock
acquire is up to 10x faster and under microcontention - short critical section with two or
more threads taking turns - spinlocks are up to 100x faster. Spinlocks take only 1 byte or 4
bytes depending on the flavor, while system locks take 64 bytes or more. Clearly, WebKit
should continue to avoid system locks - they are just far too slow and far too big.

But there is a problem with this idiom. System lock implementations will sleep a thread when
it attempts to acquire a lock that is held, while spinlocks will cause the thread to burn CPU.
In WebKit spinlocks, the thread will repeatedly call sched_yield(). This is awesome for
microcontention, but awful when the lock will not be released for a while. In fact, when
critical sections take tens of microseconds or more, the CPU time cost of our spinlocks is
almost 100x more than the CPU time cost of a system lock. This case doesn't arise too
frequently in our current uses of spinlocks, but that's probably because right now there are
places where we make a conscious decision to use system locks - even though they use more
memory and are slower - because we don't want to waste CPU cycles when a thread has to wait a
while to acquire the lock.

The solution is to just implement a modern adaptive mutex in WTF. Luckily, this isn't a new
concept. This patch implements a mutex that is reminiscent of the kinds of low-overhead locks
that JVMs use. The actual implementation here is inspired by some of the ideas from [1]. The
idea is simple: the fast path is an inlined CAS to immediately acquire a lock that isn't held,
the slow path tries some number of spins to acquire the lock, and if that fails, the thread is
put on a queue and put to sleep. The queue is made up of statically allocated thread nodes and
the lock itself is a tagged pointer: either it is just bits telling us the complete lock state
(not held or held) or it is a pointer to the head of a queue of threads waiting to acquire the
lock. This approach gives WTF::Lock three different levels of adaptation: an inlined fast path
if the lock is not contended, a short burst of spinning for microcontention, and a full-blown
queue for critical sections that are held for a long time.

On a locking microbenchmark, this new Lock exhibits the following performance
characteristics:

  • Lock+unlock on an uncontended no-op critical section: 2x slower than SpinLock and 3x faster than a system mutex.
  • Lock+unlock on a contended no-op critical section: 2x slower than SpinLock and 100x faster than a system mutex.
  • CPU time spent in lock() on a lock held for a while: same as system mutex, 90x less than a SpinLock.
  • Memory usage: sizeof(void*), so on 64-bit it's 8x less than a system mutex but 2x worse than a SpinLock.

This patch replaces all uses of SpinLock with Lock, since our critical sections are not
no-ops so if you do basically anything in your critical section, the Lock overhead will be
invisible. Also, in all places where we used SpinLock, we could tolerate 8 bytes of overhead
instead of 4. Performance benchmarking using JSC macrobenchmarks shows no difference, which is
as it should be: the purpose of this change is to reduce CPU time wasted, not wallclock time.
This patch doesn't replace any uses of ByteSpinLock, since we expect that the space benefits
of having a lock that just uses a byte are still better than the CPU wastage benefits of
Lock. But, this work will enable some future work to create locks that will fit in just 1.6
bits: ​https://bugs.webkit.org/show_bug.cgi?id=147665.

[1] ​http://www.filpizlo.com/papers/pizlo-pppj2011-fable.pdf

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • benchmarks: Added.
  • benchmarks/LockSpeedTest.cpp: Added.

(main):

  • wtf/CMakeLists.txt:
  • wtf/Lock.cpp: Added.

(WTF::LockBase::lockSlow):
(WTF::LockBase::unlockSlow):

  • wtf/Lock.h: Added.

(WTF::LockBase::lock):
(WTF::LockBase::unlock):
(WTF::LockBase::isHeld):
(WTF::Lock::Lock):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::release):
(WTF::MetaAllocatorHandle::shrink):
(WTF::MetaAllocator::allocate):
(WTF::MetaAllocator::currentStatistics):
(WTF::MetaAllocator::addFreshFreeSpace):
(WTF::MetaAllocator::debugFreeSpaceSize):

  • wtf/MetaAllocator.h:
  • wtf/SpinLock.h:
  • wtf/ThreadingPthreads.cpp:
  • wtf/ThreadingWin.cpp:
  • wtf/text/AtomicString.cpp:
  • wtf/text/AtomicStringImpl.cpp:

(WTF::AtomicStringTableLocker::AtomicStringTableLocker):

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/Lock.cpp: Added.

(TestWebKitAPI::runLockTest):
(TestWebKitAPI::TEST):

5:21 PM Changeset in webkit [188099] by commit-queue@webkit.org
  • 10 edits
    1 add in trunk/Source/JavaScriptCore

Parse the entire WebAssembly modules
​https://bugs.webkit.org/show_bug.cgi?id=147393

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-08-06
Reviewed by Geoffrey Garen.

Parse the entire WebAssembly modules from files produced by pack-asmjs
<​https://github.com/WebAssembly/polyfill-prototype-1>. This patch can only
parse modules whose function definition section contains only functions that
have "return 0;" as their only statement. Parsing of any functions will be
implemented in a subsequent patch.

(JSC::JSWASMModule::destroy):

  • wasm/JSWASMModule.h:

(JSC::JSWASMModule::i32Constants):
(JSC::JSWASMModule::f32Constants):
(JSC::JSWASMModule::f64Constants):
(JSC::JSWASMModule::signatures):
(JSC::JSWASMModule::functionImports):
(JSC::JSWASMModule::functionImportSignatures):
(JSC::JSWASMModule::globalVariableTypes):
(JSC::JSWASMModule::functionDeclarations):
(JSC::JSWASMModule::functionPointerTables):

  • wasm/WASMFormat.h: Added.
  • wasm/WASMModuleParser.cpp:

(JSC::WASMModuleParser::parse):
(JSC::WASMModuleParser::parseModule):
(JSC::WASMModuleParser::parseConstantPoolSection):
(JSC::WASMModuleParser::parseSignatureSection):
(JSC::WASMModuleParser::parseFunctionImportSection):
(JSC::WASMModuleParser::parseGlobalSection):
(JSC::WASMModuleParser::parseFunctionDeclarationSection):
(JSC::WASMModuleParser::parseFunctionPointerTableSection):
(JSC::WASMModuleParser::parseFunctionDefinitionSection):
(JSC::WASMModuleParser::parseFunctionDefinition):
(JSC::WASMModuleParser::parseExportSection):

  • wasm/WASMModuleParser.h:
  • wasm/WASMReader.cpp:

(JSC::WASMReader::readUInt32):
(JSC::WASMReader::readCompactUInt32):
(JSC::WASMReader::readString):
(JSC::WASMReader::readType):
(JSC::WASMReader::readExpressionType):
(JSC::WASMReader::readExportFormat):
(JSC::WASMReader::readByte):
(JSC::WASMReader::readUnsignedInt32): Deleted.

  • wasm/WASMReader.h:
5:03 PM Changeset in webkit [188098] by achristensen@apple.com
  • 5 edits in trunk/Source

[Win] Enable all Windows features in CMake
​https://bugs.webkit.org/show_bug.cgi?id=147744

Reviewed by Tim Horton.

  • PlatformWin.cmake:

Source/WebCore:

Add a file needed for enabling video.

Source/WebKit:

Add some include directories needed for the newly enabled features.

5:00 PM Changeset in webkit [188097] by mrajca@apple.com
  • 6 edits
    2 copies in trunk/Source/WebKit2

Media Session: notify focus manager clients when the playing state of the focused media element changes
​https://bugs.webkit.org/show_bug.cgi?id=147745

Reviewed by Tim Horton.

Added plumbing to allow focus manager's clients to be notified when the focused Content media element begins
playing or is paused.

  • UIProcess/API/C/WKMediaSessionFocusManager.cpp:

(WKMediaSessionFocusManagerSetClient):

  • UIProcess/API/C/WKMediaSessionFocusManager.h:
  • UIProcess/WebMediaSessionFocusManager.cpp:

(WebKit::WebMediaSessionFocusManager::initializeClient):
(WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange):

  • UIProcess/WebMediaSessionFocusManager.h:
  • UIProcess/WebMediaSessionFocusManagerClient.cpp:

(WebKit::WebMediaSessionFocusManagerClient::didChangePlaybackAttribute):

  • UIProcess/WebMediaSessionFocusManagerClient.h:
  • WebKit2.xcodeproj/project.pbxproj:
4:48 PM Changeset in webkit [188096] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Make CMake usable on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=147756

Reviewed by Tim Horton.

  • PlatformMac.cmake:

DatabaseProcess_SOURCES needs something in order to not have errors when generating build systems from CMake.
This doesn't fix everything, but it can now be used to build jsc again.

4:48 PM Changeset in webkit [188095] by dburkart@apple.com
  • 11 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r188011. rdar://problem/22055130

4:48 PM Changeset in webkit [188094] by dburkart@apple.com
  • 6 edits in branches/safari-601.1-branch/Source/WebKit/win

Merge r188005. rdar://problem/22059707

4:41 PM Changeset in webkit [188093] by Brent Fulgham
  • 2 edits in trunk/Websites/webkit.org

Correct a typo in the explanatory text.

  • demos/backdrop-filter/index.html:
4:40 PM Changeset in webkit [188092] by rniwa@webkit.org
  • 15 edits
    1 copy
    1 delete in trunk/Tools

http_server_driver and benchmark_builder should not be in run-benchmark's plan files
​https://bugs.webkit.org/show_bug.cgi?id=147752

Reviewed by Chris Dumez.

Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.

Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.

  • Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
  • Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
  • Scripts/webkitpy/benchmark_runner/benchmark_builder/init.py: Removed.
  • Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
  • Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init): No longer takes http_server_driver_override as an argument since this is not handled by
HTTPServerDriverFactory taking the platform name as an argument.
(BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.

  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/http_server_driver/init.py:

(http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.

  • Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:

(HTTPServerDriver): Replaced name by platforms.

  • Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver): Ditto.

  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(parse_args): Removed --http-server-driver option.
(start): Ditto.

4:35 PM Changeset in webkit [188091] by dburkart@apple.com
  • 15 edits
    1 add in branches/safari-601.1-branch

Merge r187962. rdar://problem/21827815

4:35 PM Changeset in webkit [188090] by dburkart@apple.com
  • 7 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187764. rdar://problem/22077836

4:35 PM Changeset in webkit [188089] by andersca@apple.com
  • 8 edits
    2 moves in trunk/Source/WebCore

Rename SQLStatementBackend to SQLStatement
​https://bugs.webkit.org/show_bug.cgi?id=147755

Reviewed by Geoffrey Garen.

  • CMakeLists.txt:
  • Modules/webdatabase/SQLStatement.h: Renamed from Source/WebCore/Modules/webdatabase/SQLStatementBackend.h.

(WebCore::SQLStatement::hasStatementCallback):
(WebCore::SQLStatement::hasStatementErrorCallback):

  • Modules/webdatabase/SQLStatementBackend.cpp: Removed.

(WebCore::SQLStatementBackend::SQLStatementBackend): Deleted.
(WebCore::SQLStatementBackend::~SQLStatementBackend): Deleted.
(WebCore::SQLStatementBackend::sqlError): Deleted.
(WebCore::SQLStatementBackend::sqlResultSet): Deleted.
(WebCore::SQLStatementBackend::execute): Deleted.
(WebCore::SQLStatementBackend::performCallback): Deleted.
(WebCore::SQLStatementBackend::setDatabaseDeletedError): Deleted.
(WebCore::SQLStatementBackend::setVersionMismatchedError): Deleted.
(WebCore::SQLStatementBackend::setFailureDueToQuota): Deleted.
(WebCore::SQLStatementBackend::clearFailureDueToQuota): Deleted.
(WebCore::SQLStatementBackend::lastExecutionFailedDueToQuota): Deleted.

  • Modules/webdatabase/SQLStatementBackend.h:

(WebCore::SQLStatementBackend::hasStatementCallback): Deleted.
(WebCore::SQLStatementBackend::hasStatementErrorCallback): Deleted.

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::executeSQL):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::executeSQL):

  • Modules/webdatabase/SQLTransactionBackend.h:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
4:31 PM Changeset in webkit [188088] by mmaxfield@apple.com
  • 5 edits in trunk/Source/WebCore

Make FontDescriptionKey sensitive to FontFeatureSettings
​https://bugs.webkit.org/show_bug.cgi?id=147751

Reviewed by Anders Carlsson.

Just like how FontDescription hashes should be sensitive to locale, they should
also be sensitive to font features.

This patch also fixes operator== for FontDescriptionKey, which was previously
comparing hashes for equality instead of the underlying data. Comparing hashes
for equality is useless inside hashmaps.

This is in preparation for implementing font-feature-settings.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.cpp:

(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::hashTableDeletedSize): Deleted.

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::operator!=):
(WebCore::FontDescriptionKey::isHashTableDeletedValue):
(WebCore::FontDescriptionKey::computeHash):

  • platform/graphics/FontFeatureSettings.cpp:

(WebCore::FontFeature::hash):
(WebCore::FontFeatureSettings::hash):

  • platform/graphics/FontFeatureSettings.h:
4:31 PM Changeset in webkit [188087] by Brent Fulgham
  • 1 edit
    7 adds in trunk/Websites/webkit.org

Add an example of backdrop-filter.

  • demos/backdrop-filter: Added.
  • demos/backdrop-filter/dynamic_poster.jpg: Added.
  • demos/backdrop-filter/dynamic_source.m4v: Added.
  • demos/backdrop-filter/index.html: Added.
  • demos/backdrop-filter/inverted_color.jpg: Added.
  • demos/backdrop-filter/multiple.jpg: Added.
  • demos/backdrop-filter/simple_blur.jpg: Added.
4:25 PM Changeset in webkit [188086] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

The typedArrayLength function in FTLLowerDFGToLLVM is dead code.
​https://bugs.webkit.org/show_bug.cgi?id=147749

Patch by Keith Miller <​keith_miller@apple.com> on 2015-08-06
Reviewed by Filip Pizlo.

Removed dead code elimination. the TypedArray length is compiled in compileGetArrayLength()
thus no one calls this code.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::typedArrayLength): Deleted.

4:23 PM Changeset in webkit [188085] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Source/JavaScriptCore:
The JSONP parser incorrectly parsers -0 as +0.
​https://bugs.webkit.org/show_bug.cgi?id=147590

Patch by Keith Miller <​keith_miller@apple.com> on 2015-08-06
Reviewed by Michael Saboff.

In the LiteralParser we should use a double to store the accumulator for numerical tokens
rather than an int. Using an int means that -0 is, incorrectly, parsed as +0.

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lexNumber):

LayoutTests:
The JSONP parser incorrectly parses -0 as +0.
​https://bugs.webkit.org/show_bug.cgi?id=147590

Patch by Keith Miller <​keith_miller@apple.com> on 2015-08-06
Reviewed by Michael Saboff.

A simple test that attempts loads a JSONP that sets a variable to 0.

  • js/regress/JSONP-negative-0-expected.txt: Added.
  • js/regress/JSONP-negative-0.html: Added.
  • js/regress/script-tests/JSONP-negative-0.js: Added.
4:22 PM Changeset in webkit [188084] by dburkart@apple.com
  • 3 edits in branches/safari-601.1-branch/LayoutTests

Merge r187964. rdar://problem/21870332

4:22 PM Changeset in webkit [188083] by dburkart@apple.com
  • 3 edits
    3 adds in branches/safari-601.1-branch

Merge r187935. rdar://problem/22097682

4:22 PM Changeset in webkit [188082] by dburkart@apple.com
  • 3 edits
    3 adds in branches/safari-601.1-branch

Merge r187930. rdar://problem/21870332

4:21 PM Changeset in webkit [188081] by andersca@apple.com
  • 13 edits
    2 deletes in trunk/Source/WebCore

Merge SQLStatement into SQLStatementBackend
​https://bugs.webkit.org/show_bug.cgi?id=147754

Reviewed by Geoffrey Garen.

  • CMakeLists.txt:
  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/SQLStatement.cpp: Removed.

(WebCore::SQLStatement::SQLStatement): Deleted.
(WebCore::SQLStatement::setBackend): Deleted.
(WebCore::SQLStatement::hasCallback): Deleted.
(WebCore::SQLStatement::hasErrorCallback): Deleted.
(WebCore::SQLStatement::performCallback): Deleted.

  • Modules/webdatabase/SQLStatement.h: Removed.
  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::SQLStatementBackend):
(WebCore::SQLStatementBackend::performCallback):
(WebCore::SQLStatementBackend::frontend): Deleted.

  • Modules/webdatabase/SQLStatementBackend.h:

(WebCore::SQLStatementBackend::hasStatementCallback):
(WebCore::SQLStatementBackend::hasStatementErrorCallback):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::deliverStatementCallback):
(WebCore::SQLTransaction::executeSQL):

  • Modules/webdatabase/SQLTransaction.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::currentStatement):
(WebCore::SQLTransactionBackend::executeSQL):

  • Modules/webdatabase/SQLTransactionBackend.h:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSQLTransactionCustom.cpp:
4:15 PM Changeset in webkit [188080] by Brent Fulgham
  • 1 edit
    1 add in trunk/Websites/webkit.org

Add a poster image for the video.

  • blog-files/backdrop-filters/dynamic_poster.jpg: Added.
4:09 PM Changeset in webkit [188079] by dburkart@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit/mac

Merge r187910. rdar://problem/15779101

4:09 PM Changeset in webkit [188078] by dburkart@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit/win

Merge r187894. rdar://problem/15779101

4:09 PM Changeset in webkit [188077] by dburkart@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187892. rdar://problem/21932187

4:09 PM Changeset in webkit [188076] by dburkart@apple.com
  • 44 edits
    5 adds in branches/safari-601.1-branch

Merge r187886. rdar://problem/15779101

4:08 PM Changeset in webkit [188075] by dburkart@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187693. rdar://problem/22047626

4:08 PM Changeset in webkit [188074] by dburkart@apple.com
  • 3 edits in branches/safari-601.1-branch

Merge r187622. rdar://problem/15779101

4:08 PM Changeset in webkit [188073] by dburkart@apple.com
  • 9 edits
    3 adds in branches/safari-601.1-branch

Merge r187620. rdar://problem/15779101

3:45 PM Changeset in webkit [188072] by msaboff@apple.com
  • 3 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Stop saving and restoring all callee saves on vmEntry / exit for platforms with per function callee saves handling
​https://bugs.webkit.org/show_bug.cgi?id=147747

Reviewed by Basile Clement.

Removed saving of callee save registers and materialization of special tag registers for
64 bit platforms.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter64.asm:
3:41 PM Changeset in webkit [188071] by msaboff@apple.com
  • 22 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Exceptions should properly restore callee save register contents during unwinding
​https://bugs.webkit.org/show_bug.cgi?id=147639

Reviewed by Basile Clement.

Added handling of callee save register restoration to exception handling.
The basic flow is when an exception is thrown or one is recognized to have been
generated in C++ code, we save the current state of all callee save registers to
VM::calleeSaveRegistersBuffer. As we unwind looking for the corresponding catch,
we copy the callee saves from call frames to the same VM::calleeSaveRegistersBuffer.
This is done for all call frames on the stack up to but not including the call
frame that has the corresponding catch block. When we process the catch, we
restore the callee save registers with the contents of VM::calleeSaveRegistersBuffer.
If there isn't a catch, then handleUncaughtException will restore callee saves
before it returns back to the calling C++.

As part of this change, restructured callee save handling in OSR exit handlers so
that we always use the current values of the tag registers for boxing. Also
eliminated the writing out of undefined for the baseline's callee saves slots.

Eliminated callee saves registers as possible locals for various thunk generation
as the callee saves may not have been saved by the function calling the thunk.

Cleaned up the static RegisterSet's including added one for LLInt callee saves and
one to be used to allocate local registers not including the callee saves or other
special registers.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock): Set the initial callee saves to what the LLInt needs.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

  • interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::operator()):
(JSC::UnwindFunctor::copyCalleeSavesToVMCalleeSavesBuffer):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitRestoreCalleeSaves):

  • jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_throw):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_throw):

  • jit/Repatch.cpp:

(JSC::generateByIdStub):

  • jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):

  • llint/LowLevelInterpreter32.asm:

(_llint_throw_from_slow_path_trampoline):

  • llint/LowLevelInterpreter64.asm:

(_llint_throw_from_slow_path_trampoline):

  • llint/LowLevelInterpreter.asm:

(copyCalleeSavesToVMCalleeSavesBuffer):
Copy callee saves register contents to VM::calleeSaveRegistersBuffer.

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::restoreCalleeSavesFromVMCalleeSavesBuffer):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

  • llint/LowLevelInterpreter32.asm:

(_handleUncaughtException):
(_llint_op_catch):

  • llint/LowLevelInterpreter64.asm:

(_handleUncaughtException):
(_llint_op_catch):

  • llint/LowLevelInterpreter.asm:

(restoreCalleeSavesFromVMCalleeSavesBuffer):
Restore callee saves register contents from VM::calleeSaveRegistersBuffer.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

Restore callee saves from the DFG and save the appropriate ones for the baseline JIT.
Materialize the tag registers on 64 bit platforms.

(JSC::DFG::adjustAndJumpToTarget):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::copyCalleeSavesToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::jumpToExceptionHandler):
(JSC::CCallHelpers::prepareForTailCallSlow):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::specialRegisters):
(JSC::RegisterSet::nonTempRegisters):
(JSC::RegisterSet::calleeSaveRegisters):
(JSC::RegisterSet::llintCalleeSaveRegisters):
(JSC::RegisterSet::baselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):
(JSC::RegisterSet::allVMCalleeSaveRegisters):
(JSC::RegisterSet::allGPRs):

  • jit/RegisterSet.h:

Added LLInt callee saves register set.
Updated the register set of used registers to include callee saves.

  • jit/GPRInfo.h:
  • llint/LowLevelInterpreter.asm:

(preserveCalleeSavesUsedByLLInt):
(restoreCalleeSavesUsedByLLInt):
Fixed numberOfLLIntBaselineCalleeSaveRegisters for X86-64 Windows.

  • llint/LowLevelInterpreter.asm:

(prologue): Moved callee save preservation to before we overwrite the PC callee save.

3:40 PM Changeset in webkit [188070] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188062. rdar://problem/22028179

3:38 PM Changeset in webkit [188069] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188051. rdar://problem/22028179

3:37 PM Changeset in webkit [188068] by Chris Dumez
  • 19 edits
    4 adds in trunk

Toggle GPS state based on page visibility to save battery
​https://bugs.webkit.org/show_bug.cgi?id=147685

Reviewed by Benjamin Poulain.

Source/WebCore:

Toggle GPS state based on page visibility to save battery. Previously,
if the site you were viewing was watching your position and you
switched tab, the GPS would stay on. This was bad for battery life.

Tests: fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible.html

fast/dom/Geolocation/stopUpdatingForHiddenPage.html

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::viewStateDidChange):

Tools:

Add testRunner.isGeolocationProviderActive() test support function.

  • DumpRenderTree/TestRunner.cpp:

(isGeolocationProviderActiveCallback):
(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/MockGeolocationProvider.h:
  • DumpRenderTree/mac/MockGeolocationProvider.mm:

(-[MockGeolocationProvider isActive]):

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::isGeolocationProviderActive):

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::isGeolocationProviderActive):

  • WebKitTestRunner/GeolocationProviderMock.h:

(WTR::GeolocationProviderMock::isActive):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::isGeolocationProviderActive):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::isGeolocationProviderActive):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::isGeolocationProviderActive):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Add layout tests to check that the GeolocationClient starts and stops
updating when page visibility changes.

  • fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible-expected.txt: Added.
  • fast/dom/Geolocation/startUpdatingOnlyWhenPageVisible.html: Added.
  • fast/dom/Geolocation/stopUpdatingForHiddenPage-expected.txt: Added.
  • fast/dom/Geolocation/stopUpdatingForHiddenPage.html: Added.
3:36 PM Changeset in webkit [188067] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Structures used for tryGetConstantProperty() should be registered first
​https://bugs.webkit.org/show_bug.cgi?id=147750

Reviewed by Saam Barati and Michael Saboff.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetConstantProperty): Add an assertion to that effect. This should catch the bug sooner.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addStructureSet): Register structures when we make a structure set. That ensures that we won't call tryGetConstantProperty() on a structure that hasn't been registered yet.

  • dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run): Don't register structure sets here anymore. Registering them before we get here means there is no chance of the code being DCE'd before the structures get registered. It also enables the tryGetConstantProperty() assertion, since that code runs before StructureRegisterationPhase.
(JSC::DFG::StructureRegistrationPhase::registerStructures):
(JSC::DFG::StructureRegistrationPhase::registerStructure):
(JSC::DFG::StructureRegistrationPhase::assertAreRegistered):
(JSC::DFG::StructureRegistrationPhase::assertIsRegistered):
(JSC::DFG::performStructureRegistration):

3:32 PM Changeset in webkit [188066] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

SQLStatementBackend doesn't need to be refcounted
​https://bugs.webkit.org/show_bug.cgi?id=147748

Reviewed by Geoffrey Garen.

There's no shared ownership of SQLStatementBackend so we can just use std::unique_ptr.

  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::create): Deleted.

  • Modules/webdatabase/SQLStatementBackend.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::executeSQL):

  • Modules/webdatabase/SQLTransactionBackend.h:
3:23 PM Changeset in webkit [188065] by rniwa@webkit.org
  • 8 edits
    2 adds in trunk/Tools

Automate JSBench with run-benchmark
​https://bugs.webkit.org/show_bug.cgi?id=147716

Reviewed by Chris Dumez.

Added JSBench plan to run-benchmark.

  • Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:

(GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
(GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.

  • Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
  • Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
  • Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
  • Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
  • Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
  • Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
  • Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
  • Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
  • Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
3:16 PM Changeset in webkit [188064] by Brent Fulgham
  • 1 edit
    3 adds in trunk/Websites/webkit.org

Add more media control examples.

  • blog-files/backdrop-filters/dynamic_backdrop.m4v: Added.
  • blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg: Added.
  • blog-files/backdrop-filters/Media_Controls_Complete_2x.jpg: Added.
2:38 PM Changeset in webkit [188063] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Crashes when calling swizzled setNeedsDisplayInRect: on heartbeat thread
​https://bugs.webkit.org/show_bug.cgi?id=147746
rdar://problem/18698271

Reviewed by Dan Bernstein.

Back off if someone is calling our swizzled setNeedsDisplayInRect on a non-main thread.

  • WebView/WebHTMLView.mm:

(setNeedsDisplayInRect):

2:36 PM Changeset in webkit [188062] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument
​https://bugs.webkit.org/show_bug.cgi?id=147734
rdar://problem/22028179

Reviewed by Andy Estes.

Test to follow, see ​https://bugs.webkit.org/show_bug.cgi?id=147735

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext): Use applyContentDispositionAttachmentSandbox

instead of setting sandbox flags directly.

(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Don't special

case MediaDocument.

(WebCore::Document::applyContentDispositionAttachmentSandbox): Apply sandbox flags

according to document type.

  • dom/Document.h:
2:23 PM Changeset in webkit [188061] by andersca@apple.com
  • 10 edits
    2 deletes in trunk/Source/WebCore

Get rid of DatabaseBackendBase
​https://bugs.webkit.org/show_bug.cgi?id=147733

Reviewed by Geoffrey Garen.

  • CMakeLists.txt:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp: Removed.

(WebCore::DatabaseBackendBase::DatabaseBackendBase): Deleted.
(WebCore::DatabaseBackendBase::~DatabaseBackendBase): Deleted.

  • Modules/webdatabase/DatabaseBackendBase.h: Removed.
  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseTracker.cpp:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
2:23 PM Changeset in webkit [188060] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188058. rdar://problem/22128839

2:17 PM Changeset in webkit [188059] by commit-queue@webkit.org
  • 139 edits
    10 copies
    1 move
    5 adds
    1 delete in trunk/LayoutTests

Web Inspector: move http/tests/inspector-protocol/ contents to http/tests/inspector/
​https://bugs.webkit.org/show_bug.cgi?id=147739

Patch by Brian Burg <BJ Burg> on 2015-08-06
Reviewed by Timothy Hatcher.

Start merging inspector-protocol/ directory into inspector/, starting with http tests.

This patch puts the few http tests into their own domain directories. Files related
to the test harness have been moved to the appropriate resources/ directory.
Update all inspector tests to the new paths.

Lastly, rename InspectorTest.js and protocol-test.html to ProtocolTestStub, to make
it obvious that these files are only used by the protocol test harness.

  • http/tests/inspector/console/access-inspected-object-expected.txt: Renamed from LayoutTests/http/tests/inspector-protocol/access-inspected-object-expected.txt.
  • http/tests/inspector/console/access-inspected-object.html: Renamed from LayoutTests/http/tests/inspector-protocol/access-inspected-object.html.
  • http/tests/inspector/css/bad-mime-type.html:
  • http/tests/inspector/dom/resources/InspectorDOMListener.js: Renamed from LayoutTests/http/tests/inspector-protocol/resources/InspectorDOMListener.js.
  • http/tests/inspector/page/loading-iframe-document-node-expected.txt: Renamed from LayoutTests/http/tests/inspector-protocol/loading-iframe-document-node-expected.txt.
  • http/tests/inspector/page/loading-iframe-document-node.html: Renamed from LayoutTests/http/tests/inspector-protocol/loading-iframe-document-node.html.
  • http/tests/inspector/page/resources/slow-test-page.html: Renamed from LayoutTests/http/tests/inspector-protocol/resources/slow-test-page.html.
  • http/tests/inspector/page/resources/test-page.html: Renamed from LayoutTests/http/tests/inspector-protocol/resources/test-page.html.
  • http/tests/inspector/replay/document-last-modified-fallback-value.html:
  • http/tests/inspector/resources/ProtocolTestStub.html: Renamed from LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html.
  • http/tests/inspector/resources/ProtocolTestStub.js: Renamed from LayoutTests/http/tests/inspector-protocol/resources/InspectorTest.js.
  • http/tests/inspector/resources/inspector-test.js: Renamed from LayoutTests/http/tests/inspector/inspector-test.js.
  • http/tests/inspector/resources/protocol-test.js: Renamed from LayoutTests/http/tests/inspector-protocol/resources/protocol-test.js.
  • inspector-protocol/async-test-suite.html:
  • inspector-protocol/console/console-message.html:
  • inspector-protocol/console/css-source-locations.html: Fix references to console helpers.
  • inspector-protocol/console/js-source-locations.html:
  • inspector-protocol/console/x-frame-options-message.html:
  • inspector-protocol/css/getSupportedCSSProperties.html:
  • inspector-protocol/debugger/breakpoint-action-detach.html:
  • inspector-protocol/debugger/breakpoint-action-with-exception.html:
  • inspector-protocol/debugger/breakpoint-condition-detach.html:
  • inspector-protocol/debugger/breakpoint-condition-with-bad-script.html:
  • inspector-protocol/debugger/breakpoint-condition-with-exception.html:
  • inspector-protocol/debugger/breakpoint-eval-with-exception.html:
  • inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html:
  • inspector-protocol/debugger/call-frame-function-name.html:
  • inspector-protocol/debugger/call-frame-this-host.html:
  • inspector-protocol/debugger/call-frame-this-nonstrict.html:
  • inspector-protocol/debugger/call-frame-this-strict.html:
  • inspector-protocol/debugger/debugger-statement.html:
  • inspector-protocol/debugger/didSampleProbe-multiple-probes.html:
  • inspector-protocol/debugger/hit-breakpoint-from-console.html:
  • inspector-protocol/debugger/nested-inspectors.html:
  • inspector-protocol/debugger/pause-dedicated-worker.html:
  • inspector-protocol/debugger/pause-on-assert.html:
  • inspector-protocol/debugger/regress-133182.html:
  • inspector-protocol/debugger/removeBreakpoint.html:
  • inspector-protocol/debugger/searchInContent-linebreaks.html:
  • inspector-protocol/debugger/setBreakpoint-actions.html:
  • inspector-protocol/debugger/setBreakpoint-autoContinue.html:
  • inspector-protocol/debugger/setBreakpoint-column.html:
  • inspector-protocol/debugger/setBreakpoint-condition.html:
  • inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html:
  • inspector-protocol/debugger/setBreakpoint-dfg-callee-and-examine-dfg-local.html:
  • inspector-protocol/debugger/setBreakpoint-dfg.html:
  • inspector-protocol/debugger/setBreakpoint-options-exception.html:
  • inspector-protocol/debugger/setBreakpoint.html:
  • inspector-protocol/debugger/setBreakpointByUrl-sourceURL.html:
  • inspector-protocol/debugger/setPauseOnExceptions-all.html:
  • inspector-protocol/debugger/setPauseOnExceptions-none.html:
  • inspector-protocol/debugger/setPauseOnExceptions-uncaught.html:
  • inspector-protocol/debugger/setVariableValue.html:
  • inspector-protocol/debugger/terminate-dedicated-worker-while-paused.html:
  • inspector-protocol/dom-debugger/node-removed.html:
  • inspector-protocol/dom/dom-remove-events.html:
  • inspector-protocol/dom/dom-search-crash.html:
  • inspector-protocol/dom/dom-search-with-context.html:
  • inspector-protocol/dom/dom-search.html:
  • inspector-protocol/dom/focus.html:
  • inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
  • inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html:
  • inspector-protocol/dom/getAccessibilityPropertiesForNode_mouseEventNodeId.html:
  • inspector-protocol/dom/highlight-flow-with-no-region.html:
  • inspector-protocol/dom/remove-multiple-nodes.html:
  • inspector-protocol/dom/request-child-nodes-depth.html:
  • inspector-protocol/layers/layers-anonymous.html:
  • inspector-protocol/layers/layers-blending-compositing-reasons.html:
  • inspector-protocol/layers/layers-compositing-reasons.html:
  • inspector-protocol/layers/layers-for-node.html:
  • inspector-protocol/layers/layers-generated-content.html:
  • inspector-protocol/layers/layers-reflected-content.html:
  • inspector-protocol/page/archive.html:
  • inspector-protocol/page/frameScheduledNavigation.html:
  • inspector-protocol/page/frameStartedLoading.html:
  • inspector-protocol/page/javascriptDialogEvents.html:
  • inspector-protocol/page/setEmulatedMedia.html:
  • inspector-protocol/runtime/getProperties.html:
  • inspector-protocol/sync-test-suite.html:
  • inspector/console/command-line-api.html:
  • inspector/console/console-api.html:
  • inspector/console/console-table.html:
  • inspector/css/get-system-fonts.html:
  • inspector/css/matched-style-properties.html:
  • inspector/css/modify-rule-selector.html:
  • inspector/css/pseudo-element-matches-for-pseudo-element-node.html:
  • inspector/css/pseudo-element-matches.html:
  • inspector/css/selector-dynamic-specificity.html:
  • inspector/css/selector-specificity.html:
  • inspector/css/stylesheet-with-mutations.html:
  • inspector/debugger/break-on-exception-catch.html:
  • inspector/debugger/break-on-exception-finally.html:
  • inspector/debugger/break-on-exception-native.html:
  • inspector/debugger/break-on-exception-throw-in-promise-rethrow-in-catch.html:
  • inspector/debugger/break-on-exception-throw-in-promise-then-with-catch.html:
  • inspector/debugger/break-on-exception-throw-in-promise-then.html:
  • inspector/debugger/break-on-exception-throw-in-promise-with-catch.html:
  • inspector/debugger/break-on-exception-throw-in-promise.html:
  • inspector/debugger/break-on-exception-window-onerror.html:
  • inspector/debugger/break-on-exception.html:
  • inspector/debugger/break-on-uncaught-exception-catch.html:
  • inspector/debugger/break-on-uncaught-exception-finally.html:
  • inspector/debugger/break-on-uncaught-exception-native.html:
  • inspector/debugger/break-on-uncaught-exception-throw-in-promise-rethrow-in-catch.html:
  • inspector/debugger/break-on-uncaught-exception-throw-in-promise-then-with-catch.html:
  • inspector/debugger/break-on-uncaught-exception-throw-in-promise-then.html:
  • inspector/debugger/break-on-uncaught-exception-throw-in-promise-with-catch.html:
  • inspector/debugger/break-on-uncaught-exception-throw-in-promise.html:
  • inspector/debugger/break-on-uncaught-exception-window-onerror.html:
  • inspector/debugger/break-on-uncaught-exception.html:
  • inspector/debugger/breakpoint-action-eval.html:
  • inspector/debugger/breakpoint-columns.html:
  • inspector/debugger/breakpoint-scope.html:
  • inspector/debugger/command-line-api-exception-nested-catch.html:
  • inspector/debugger/command-line-api-exception.html:
  • inspector/debugger/js-stacktrace.html:
  • inspector/debugger/pause-reason.html:
  • inspector/debugger/probe-manager-add-remove-actions.html:
  • inspector/debugger/search-scripts-expected.txt:
  • inspector/debugger/search-scripts.html:
  • inspector/dom/content-flow-content-nodes.html:
  • inspector/dom/content-flow-content-removal.html:
  • inspector/dom/content-flow-list.html:
  • inspector/dom/content-node-region-info.html:
  • inspector/dom/highlight-shape-outside-margin.html:
  • inspector/dom/highlight-shape-outside.html:
  • inspector/dom/highlightSelector.html:
  • inspector/dom/pseudo-element-dynamic.html:
  • inspector/dom/pseudo-element-static.html:
  • inspector/dom/template-content.html:
  • inspector/event-listener-set.html:
  • inspector/event-listener.html:
  • inspector/model/parse-script-syntax-tree.html:
  • inspector/model/remote-object-get-properties.html:
  • inspector/model/remote-object-weak-collection.html:
  • inspector/model/remote-object.html:
  • inspector/page/main-frame-resource.html:
  • inspector/protocol-promise-result.html:
  • inspector/replay/javascript-date-now.html:
  • inspector/replay/javascript-random-seed.html:
  • inspector/replay/window-navigator-plugins-memoized.html:
  • inspector/test-harness-trivially-works.html:
  • inspector/timeline/debugger-paused-while-recording.html:
  • inspector/timeline/exception-in-injected-script-while-recording.html:
  • inspector/timeline/recording-start-stop-timestamps.html:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
2:03 PM Changeset in webkit [188058] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix for iOS after ​http://trac.webkit.org/changeset/188053.

Unreviewed.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _registerPreview]):

1:53 PM Changeset in webkit [188057] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Add comment to CSSParserString
​https://bugs.webkit.org/show_bug.cgi?id=147724

Reviewed by Dean Jackson.

No new tests because there is no behavior change.

  • css/CSSParserValues.h:
1:45 PM Changeset in webkit [188056] by mmaxfield@apple.com
  • 8 edits in trunk

Font feature settings comparisons are order-dependent and case-dependent
​https://bugs.webkit.org/show_bug.cgi?id=147719

Reviewed by Benjamin Poulain.

Source/WebCore:

We should make our settings vector order-independent and case-independent.

Test: css3/font-feature-settings-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFontFeatureTag):

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontFeatureSettings):

  • platform/graphics/FontFeatureSettings.cpp:

(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator==):
(WebCore::FontFeatureSettings::FontFeatureSettings):

  • platform/graphics/FontFeatureSettings.h:

(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator==):
(WebCore::FontFeature::operator<):
(WebCore::FontFeatureSettings::insert):
(WebCore::FontFeatureSettings::FontFeatureSettings):
(WebCore::FontFeatureSettings::append): Deleted.

LayoutTests:

Make the test insensitive to order and case.

  • css3/font-feature-settings-parsing-expected.txt:
  • css3/font-feature-settings-parsing.html:
1:40 PM Changeset in webkit [188055] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AX: AXLoadComplete that comes before AX API access won't fire
​https://bugs.webkit.org/show_bug.cgi?id=147737

Patch by Doug Russell <​d_russell@apple.com> on 2015-08-06
Reviewed by Chris Fleizach.

Treat setEnhancedUserInterfaceAccessibility() as AX API access and if true,
enableAccessibility().

Source/WebCore:

Test: accessibility/mac/loaded-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):

LayoutTests:

  • accessibility/mac/loaded-notification-expected.txt: Added.
  • accessibility/mac/loaded-notification.html: Added.
1:33 PM Changeset in webkit [188054] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r188053. rdar://problem/22128839

1:14 PM Changeset in webkit [188053] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

Allow long press to cancel link preview.
​https://bugs.webkit.org/show_bug.cgi?id=147743
rdar://problem/22128839

Reviewed by Tim Horton.

We should be able to show the context menu at the beginnig of link preview.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView _longPressRecognized:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _registerPreview]):
(-[WKContentView _unregisterPreview]):

12:48 PM Changeset in webkit [188052] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r187693. rdar://problem/22047626

11:45 AM Changeset in webkit [188051] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Do not enforce "content-disposition: attachment" sandbox restrictions on a MediaDocument
​https://bugs.webkit.org/show_bug.cgi?id=147734
rdar://problem/22028179

Reviewed by Dean Jackson.

Test to follow, see ​https://bugs.webkit.org/show_bug.cgi?id=147735

  • dom/Document.cpp:

(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Return

early if the Document is a MediaDocument.

11:35 AM Changeset in webkit [188050] by Yusuke Suzuki
  • 2 edits in trunk/Tools

Pass-through the undefined options in run-jsc
​https://bugs.webkit.org/show_bug.cgi?id=147717

Undefined options in run-jsc is just passed to the actual jsc shell.
We can execute Tools/Scripts/run-jsc -d.

Reviewed by Csaba Osztrogonác.

  • Scripts/run-jsc:
11:30 AM Changeset in webkit [188049] by mrajca@apple.com
  • 2 edits in trunk/Source/WebCore

Media Session: remove media elements from the ID <-> element map on destruction
​https://bugs.webkit.org/show_bug.cgi?id=147707

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

11:21 AM Changeset in webkit [188048] by mrajca@apple.com
  • 5 edits in trunk/Source/WebKit2

Media Session: rename isFocusedContentMediaElementPaused and get rid of callback
​https://bugs.webkit.org/show_bug.cgi?id=147726

Reviewed by Simon Fraser.

  • isFocusedContentMediaElementPaused should be renamed to isFocusedContentMediaElementPlaying to match recent refactoring work.
  • isFocusedContentMediaElementPlaying itself does not need a callback anymore because the value can be returned directly.
  • UIProcess/API/C/WKMediaSessionFocusManager.cpp:

(WKMediaSessionFocusManagerIsFocusedContentMediaElementPlaying): Removed callback and renamed from...
(WKMediaSessionFocusManagerIsFocusedContentMediaElementPaused): Deleted.

  • UIProcess/API/C/WKMediaSessionFocusManager.h:
  • UIProcess/WebMediaSessionFocusManager.cpp:

(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPlaying): Removed callback and renamed from...
(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPaused): Deleted.

  • UIProcess/WebMediaSessionFocusManager.h:
11:16 AM Changeset in webkit [188047] by Brent Fulgham
  • 1 edit
    2 adds in trunk/Websites/webkit.org

Add two more files for a future blog post.

  • blog-files/backdrop-filters/Media_Controls_1x.jpg: Added.
  • blog-files/backdrop-filters/Media_Controls_2x.jpg: Added.
10:58 AM Changeset in webkit [188046] by Gyuyoung Kim
  • 3 edits in trunk/Source/WebCore

[CoordinatedGraphics] Remove unused functions in Coordinated TiledBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=147621

Reviewed by Csaba Osztrogonác.

  • platform/graphics/texmap/coordinated/TiledBackingStore.cpp: Remove setTileSize() and tileSize().

(WebCore::TiledBackingStore::setTileSize):

10:55 AM Changeset in webkit [188045] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move the last remnants of DatabaseBackendBase to Database
​https://bugs.webkit.org/show_bug.cgi?id=147730

Reviewed by Tim Horton.

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::DatabaseBackendBase):

  • Modules/webdatabase/DatabaseBackendBase.h:

(WebCore::DatabaseBackendBase::databaseContext): Deleted.
(WebCore::DatabaseBackendBase::setFrontend): Deleted.

10:44 AM Changeset in webkit [188044] by beidson@apple.com
  • 1 edit
    5 adds in branches/safari-600.8-branch/LayoutTests

Re-baseline test for WK1 on this branch

Collaboration of Brady and Alexey.

  • platform/mac-wk1/http: Added.
  • platform/mac-wk1/http/tests: Added.
  • platform/mac-wk1/http/tests/misc: Added.
  • platform/mac-wk1/http/tests/misc/authentication-redirect-3: Added.
  • platform/mac-wk1/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt: Added.
10:30 AM Changeset in webkit [188043] by bshafiei@apple.com
  • 7 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r186849. rdar://problem/22045047

9:52 AM Changeset in webkit [188042] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

9:36 AM Changeset in webkit [188041] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

Fix build without ENABLE(VIDEO) after r188030.

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:

Move definition of HTMLMediaElementInvalidID to Document.h so it can be used outside of ENABLE(VIDEO) macros.

9:24 AM Changeset in webkit [188040] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Remove UnspecifiedBoolType from JSC
​https://bugs.webkit.org/show_bug.cgi?id=147597

Patch by Keith Miller <​keith_miller@apple.com> on 2015-08-06
Reviewed by Mark Lam.

We were using the safe bool pattern in the code base for implicit casting to booleans.
With C++11 this is no longer necessary and we can instead create an operator bool.

  • API/JSRetainPtr.h:

(JSRetainPtr::operator bool):
(JSRetainPtr::operator UnspecifiedBoolType): Deleted.

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::operator bool):
(JSC::DFG::Edge::operator UnspecifiedBoolType*): Deleted.

  • dfg/DFGIntegerRangeOptimizationPhase.cpp:
  • heap/Weak.h:
  • heap/WeakInlines.h:

(JSC::bool):
(JSC::UnspecifiedBoolType): Deleted.

5:31 AM Changeset in webkit [188039] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.

It's flaky.

  • Scripts/run-gtk-tests:

(TestRunner):

4:10 AM Changeset in webkit [188038] by Csaba Osztrogonác
  • 4 edits in trunk

[EFL] Bump EFL version to 1.15.0
​https://bugs.webkit.org/show_bug.cgi?id=147450

Reviewed by Gyuyoung Kim.

Source/WebKit2:

  • PlatformEfl.cmake:

Tools:

  • efl/jhbuild.modules:
3:12 AM Changeset in webkit [188037] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.8.5

WebKitGTK+ 2.8.5

3:11 AM Changeset in webkit [188036] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.5 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.8.5.
3:10 AM Changeset in webkit [188035] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Unreviewed. Fix the build with RESOURCE_TIMING disabled.

  • loader/ThreadableLoader.h:
1:50 AM Changeset in webkit [188034] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r188031 - [GTK] Crash closing a page when a context menu is open
​https://bugs.webkit.org/show_bug.cgi?id=147682

Reviewed by Sergio Villar Senin.

Implement WebContextMenuProxy::cancelTracking() to clear the
internal menu when the web page is closed.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::cancelTracking):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Deleted.

  • UIProcess/gtk/WebContextMenuProxyGtk.h:
1:47 AM Changeset in webkit [188033] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r188014 - Crash when removing children of a MathMLSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=147704
<rdar://problem/21940321>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When MathMLSelectElement::childrenChanged() is called after its
children have been removed, MathMLSelectElement calls
updateSelectedChild() which accesses m_selectedChild. However,
in this case, m_selectedChild is the previously selected child
and it may be destroyed as this point if it was removed. To avoid
this problem, MathMLSelectElement now keep a strong ref to the
currently selected element.

Test: mathml/maction-removeChild.html

  • mathml/MathMLSelectElement.h:

LayoutTests:

Add layout test that reproduces the crash under guardmalloc.

  • mathml/maction-removeChild-expected.txt: Added.
  • mathml/maction-removeChild.html: Added.
1:19 AM Changeset in webkit [188032] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Unksip TestContextMenu GTK+ API test.

This has been skipped for a long time, and it's very
unconvenient. It has never failed for me locally, so let's try
again to see if it works in the bots. I'll skip it again if it
keeps failing.

  • Scripts/run-gtk-tests:

(TestRunner):

1:14 AM Changeset in webkit [188031] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Crash closing a page when a context menu is open
​https://bugs.webkit.org/show_bug.cgi?id=147682

Reviewed by Sergio Villar Senin.

Implement WebContextMenuProxy::cancelTracking() to clear the
internal menu when the web page is closed.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::cancelTracking):
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Deleted.

  • UIProcess/gtk/WebContextMenuProxyGtk.h:
12:13 AM Changeset in webkit [188030] by mrajca@apple.com
  • 20 edits in trunk/Source

Media Session: push paused state to the media session focus manager instead of polling
​https://bugs.webkit.org/show_bug.cgi?id=147633

Reviewed by Simon Fraser.

WebCore:

  • dom/Document.cpp:

(WebCore::Document::updateIsPlayingMedia): If a valid source element ID is passed in, set the 'IsSourcePlaying'

flag accordingly.

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::elementWithID):
(WebCore::HTMLMediaElement::setMuted): Pass along the element ID.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Ditto.
(WebCore::HTMLMediaElement::setPlaying): Ditto.

  • html/HTMLMediaElement.h:
  • page/ChromeClient.h:
  • page/MediaProducer.h:
  • page/Page.cpp:

(WebCore::Page::updateIsPlayingMedia): Pass along the source element ID.
(WebCore::Page::isMediaElementPaused): Deleted. We now push media playback state changes instead of polling.

  • page/Page.h:

WebKit2:

  • UIProcess/WebMediaSessionFocusManager.cpp:

(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPaused): Report whether the focused media

element is currently playing. The callback is no longer necessary and will be removed in a future patch in
favor of returning a value directly.

(WebKit::WebMediaSessionFocusManager::mediaElementIsPlayingDidChange): Keep track of whether the focused media

element is currently playing.

  • UIProcess/WebMediaSessionFocusManager.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange): If the focused media element begins/ends playing, keep track

of its playing state.

(WebKit::WebPageProxy::isMediaElementPaused): Deleted. We now push media playback state changes instead of

polling.

  • UIProcess/WebPageProxy.h: isPlayingMediaDidChange is now passed the ID of the media element that triggered the 'playing' state change. This can be used in conjunction with the IsSourcePlaying media flag to identify whether the source element begin/ended playing.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::setPluginIsPlayingAudio): Since a media element did not trigger this, pass in 0 for the

source media element.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::isPlayingMediaDidChange): isPlayingMediaDidChange is now passed the ID of the media

element that triggered the 'playing' state change.

  • WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::isMediaElementPaused): Deleted. We now push media playback state changes instead of polling.

  • WebProcess/WebPage/WebPage.h: Ditto.
  • WebProcess/WebPage/WebPage.messages.in: Ditto.

Aug 5, 2015:

11:24 PM Changeset in webkit [188029] by Devin Rousso
  • 7 edits
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: Move the Metrics style sidebar panel into Computed
​https://bugs.webkit.org/show_bug.cgi?id=147715

Reviewed by Timothy Hatcher.

Deleted the Metrics sidebar panel and moved its contents into the Computed sidebar panel.
In addition, not hovering over the Metrics section will display the colors of each box.

  • UserInterface/Main.html:
  • UserInterface/Views/BoxModelDetailsSectionRow.css:

(.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
(.details-section .row.box-model .position):
(.details-section .row.box-model .margin):
(.details-section .row.box-model .border):
(.details-section .row.box-model .padding):
(.details-section .row.box-model :matches(.content span, .top, .right, .bottom, .left)):
(.details-section .row.box-model :matches(.right, .left)):
(.details-section .row.box-model .content): Deleted.
(.details-section .row.box-model .content span): Deleted.
(.details-section .row.box-model .left): Deleted.
(.details-section .row.box-model .right): Deleted.
(.details-section .row.box-model .top): Deleted.
(.details-section .row.box-model .bottom): Deleted.

  • UserInterface/Views/BoxModelDetailsSectionRow.js:

(WebInspector.BoxModelDetailsSectionRow.prototype._highlightDOMNode):
If no metric box is hovered, apply a class to the entire section.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):
Removed the usage of MetricsStyleDetailsPanel.

  • UserInterface/Views/ComputedStyleDetailsPanel.css:

(.details-section.style-box-model:not(.collapsed) > :matches(.header, .content)):
Give the metrics section in the Computed panel a white background.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel):
(WebInspector.ComputedStyleDetailsPanel.prototype.refresh):
Don't refresh the content unless the change is significant (without this, you cannot edit
metrics values using the arrow keys).

  • UserInterface/Views/MetricsStyleDetailsPanel.js: Removed.
11:17 PM Changeset in webkit [188028] by Devin Rousso
  • 12 edits
    1 copy
    4 adds
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: Bezier curve visual editor
​https://bugs.webkit.org/show_bug.cgi?id=134501

Reviewed by Timothy Hatcher.

Added a visual Cubic Bezier curve editor that is usable in both
the CSS sidebar and the resources panel.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/DOMUtilities.js:

(createSVGElement):

  • UserInterface/Controllers/CodeMirrorBezierEditingController.js:

(WebInspector.CodeMirrorBezierEditingController):
(WebInspector.CodeMirrorBezierEditingController.prototype.get initialValue):
(WebInspector.CodeMirrorBezierEditingController.prototype.get cssClassName):
(WebInspector.CodeMirrorBezierEditingController.prototype.popoverWillPresent):
(WebInspector.CodeMirrorBezierEditingController.prototype.popoverDidPresent):
(WebInspector.CodeMirrorBezierEditingController.prototype._bezierEditorBezierChanged):

  • UserInterface/Images/CubicBezier.svg: Added.
  • UserInterface/Main.html:
  • UserInterface/Models/Geometry.js:

(WebInspector.Point.prototype.distance):
(WebInspector.Point):
(WebInspector.CubicBezier):
(WebInspector.CubicBezier.fromPoints):
(WebInspector.CubicBezier.fromString):
(WebInspector.CubicBezier.prototype.get inPoint):
(WebInspector.CubicBezier.prototype.get outPoint):
(WebInspector.CubicBezier.prototype.copy):
(WebInspector.CubicBezier.prototype.toString):
(WebInspector.CubicBezier.prototype.solve):
(WebInspector.CubicBezier.prototype._sampleCurveX):
(WebInspector.CubicBezier.prototype._sampleCurveY):
(WebInspector.CubicBezier.prototype._sampleCurveDerivativeX):
(WebInspector.CubicBezier.prototype._solveCurveX):

  • UserInterface/Models/TextMarker.js:
  • UserInterface/Models/UnitBezier.js: Removed.
  • UserInterface/Views/BezierEditor.css: Added.

(.bezier-editor):
(.bezier-editor > .bezier-preview):
(.bezier-editor > .bezier-preview > div):
(.bezier-editor > .bezier-preview-timing):
(.bezier-editor > .bezier-preview-timing.animate):
(.bezier-editor > .bezier-container):
(@keyframes bezierPreview):
(.bezier-editor > .bezier-container):
(.bezier-editor > .bezier-container .linear-curve):
(.bezier-editor > .bezier-container .bezier-curve):
(.bezier-editor > .bezier-container .control-line):
(.bezier-editor > .bezier-container .control-handle):

  • UserInterface/Views/BezierEditor.js: Added.

(WebInspector.BezierEditor.createControl):
(WebInspector.BezierEditor):
(WebInspector.BezierEditor.prototype.get element):
(WebInspector.BezierEditor.prototype.set bezier):
(WebInspector.BezierEditor.prototype.get bezier):
(WebInspector.BezierEditor.prototype.handleEvent):
(WebInspector.BezierEditor.prototype._handleMousedown):
(WebInspector.BezierEditor.prototype._handleMousemove):
(WebInspector.BezierEditor.prototype._handleMouseup):
(WebInspector.BezierEditor.prototype._updateControlPointsForMouseEvent):
(WebInspector.BezierEditor.prototype._updateValue.round):
(WebInspector.BezierEditor.prototype._updateValue):
(WebInspector.BezierEditor.prototype._updateBezier):
(WebInspector.BezierEditor.prototype._updateControl):
(WebInspector.BezierEditor.prototype._triggerPreviewAnimation):
(WebInspector.BezierEditor.prototype._resetPreviewAnimation):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker:hover):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .cubic-bezier-marker:active):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype.didDismissPopover):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._contentChanged):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createColorSwatches):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createBezierEditors.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._createBezierEditors):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._commentProperty.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._commentProperty):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._uncommentRange.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._uncommentRange):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked.updateCodeMirror.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked.updateCodeMirror):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._cubicBezierMarkerClicked):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent):

  • UserInterface/Views/CodeMirrorAdditions.js:
  • UserInterface/Views/CodeMirrorTextMarkers.js: Added.

(createCodeMirrorTextMarkers):
(createCodeMirrorColorTextMarkers):
(createCodeMirrorGradientTextMarkers):
(createCodeMirrorCubicBezierTextMarkers):

  • UserInterface/Views/Popover.js:

(WebInspector.Popover.prototype._animateFrame):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._updateEditableMarkers):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression):

  • UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor.prototype.createColorMarkers):
(WebInspector.TextEditor.prototype.createGradientMarkers):
(WebInspector.TextEditor.prototype.createCubicBezierMarkers):
(WebInspector.TextEditor.prototype.editingControllerForMarker):

11:07 PM Changeset in webkit [188027] by ap@apple.com
  • 3 edits in trunk/LayoutTests

Fix TestExpectations lint warnings.

  • platform/mac-wk2/TestExpectations: Remove duplicate entries.
  • platform/win/TestExpectations: Update for the big platform move of 2015. One of

these tests no longer asserts, so it doesn't need to be skipped.

10:38 PM Changeset in webkit [188026] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Fix paths to ruby-expansion tests, and make them ImageOnlyFailure rather than Skip.

  • platform/mac-mavericks/TestExpectations:
10:16 PM Changeset in webkit [188025] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

CharacterFallbackMapKey should be locale-specific
​https://bugs.webkit.org/show_bug.cgi?id=147532

Reviewed by Dean Jackson.

This is in preparation for locale-specific font fallback.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):

10:13 PM Changeset in webkit [188024] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Expand CharacterFallbackMapKey to a struct
​https://bugs.webkit.org/show_bug.cgi?id=147530

Reviewed by Dean Jackson.

This is in prepraration for making this struct locale-specific.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::isHashTableDeletedValue):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::CharacterFallbackMapKeyHash::equal):
(WebCore::Font::systemFallbackFontForCharacter):

9:50 PM Changeset in webkit [188023] by Simon Fraser
  • 2 edits
    16 moves in trunk/LayoutTests

Move /mac/fast/text reference tests into fast/text. Some may need to be skipped on other platforms.

  • fast/text/arabic-zwj-and-zwnj-expected.html: Renamed from LayoutTests/platform/mac/fast/text/arabic-zwj-and-zwnj-expected.html.
  • fast/text/arabic-zwj-and-zwnj.html: Renamed from LayoutTests/platform/mac/fast/text/arabic-zwj-and-zwnj.html.
  • fast/text/combining-character-sequence-vertical-expected.html: Renamed from LayoutTests/platform/mac/fast/text/combining-character-sequence-vertical-expected.html.
  • fast/text/combining-character-sequence-vertical.html: Renamed from LayoutTests/platform/mac/fast/text/combining-character-sequence-vertical.html.
  • fast/text/combining-mark-paint-expected.html: Renamed from LayoutTests/platform/mac/fast/text/combining-mark-paint-expected.html.
  • fast/text/combining-mark-paint.html: Renamed from LayoutTests/platform/mac/fast/text/combining-mark-paint.html.
  • fast/text/font-cursive-italic-cjk-expected.html: Renamed from LayoutTests/platform/mac/fast/text/font-cursive-italic-cjk-expected.html.
  • fast/text/font-cursive-italic-cjk.html: Renamed from LayoutTests/platform/mac/fast/text/font-cursive-italic-cjk.html.
  • fast/text/kerning-with-TextLayout-expected.html: Renamed from LayoutTests/platform/mac/fast/text/kerning-with-TextLayout-expected.html.
  • fast/text/kerning-with-TextLayout.html: Renamed from LayoutTests/platform/mac/fast/text/kerning-with-TextLayout.html.
  • fast/text/multiple-codeunit-vertical-upright-expected.html: Renamed from LayoutTests/platform/mac/fast/text/multiple-codeunit-vertical-upright-expected.html.
  • fast/text/multiple-codeunit-vertical-upright.html: Renamed from LayoutTests/platform/mac/fast/text/multiple-codeunit-vertical-upright.html.
  • fast/text/synthetic-bold-transformed-expected.html: Renamed from LayoutTests/platform/mac/fast/text/synthetic-bold-transformed-expected.html.
  • fast/text/synthetic-bold-transformed.html: Renamed from LayoutTests/platform/mac/fast/text/synthetic-bold-transformed.html.
  • fast/text/trailing-word-expected.html: Renamed from LayoutTests/platform/mac/fast/text/trailing-word-expected.html.
  • fast/text/trailing-word.html: Renamed from LayoutTests/platform/mac/fast/text/trailing-word.html.
  • platform/mac/TestExpectations:
9:49 PM Changeset in webkit [188022] by Simon Fraser
  • 2 edits
    12 moves
    1 add in trunk/LayoutTests

Make ruby-expansion tests cross-platform. They may have to be skipped on other platforms.

  • fast/ruby/resources/green.png: Renamed from LayoutTests/platform/mac/fast/ruby/resources/green.png.
  • fast/ruby/resources/ruby-expansion.svg: Renamed from LayoutTests/platform/mac/fast/ruby/resources/ruby-expansion.svg.
  • fast/ruby/ruby-expansion-cjk-2-expected.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-2-expected.html.
  • fast/ruby/ruby-expansion-cjk-2.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-2.html.
  • fast/ruby/ruby-expansion-cjk-3-expected.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-3-expected.html.
  • fast/ruby/ruby-expansion-cjk-3.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-3.html.
  • fast/ruby/ruby-expansion-cjk-4-expected.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-4-expected.html.
  • fast/ruby/ruby-expansion-cjk-4.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-4.html.
  • fast/ruby/ruby-expansion-cjk-5-expected.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-5-expected.html.
  • fast/ruby/ruby-expansion-cjk-5.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-5.html.
  • fast/ruby/ruby-expansion-cjk-expected.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk-expected.html.
  • fast/ruby/ruby-expansion-cjk.html: Renamed from LayoutTests/platform/mac/fast/ruby/ruby-expansion-cjk.html.
  • platform/mac-wk1/TestExpectations:
9:49 PM Changeset in webkit [188021] by Simon Fraser
  • 1 edit
    4 deletes in trunk/LayoutTests

Remove the XBM image test. Mac doesn't suport XBM images any more.

  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.png: Removed.
  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.txt: Removed.
  • platform/mac/fast/canvas/canvas-draw-xbm-image.html: Removed.
  • platform/mac/fast/canvas/resources/smile.xbm: Removed.
9:49 PM Changeset in webkit [188020] by Simon Fraser
  • 1 edit
    1 move
    2 adds in trunk/LayoutTests

Make platform/mac/compositing/canvas/accelerated-canvas-compositing.html a cross-platform test.

  • compositing/canvas/accelerated-canvas-compositing-expected.txt: Added.
  • compositing/canvas/accelerated-canvas-compositing.html: Renamed from LayoutTests/platform/mac/compositing/canvas/accelerated-canvas-compositing.html.
9:36 PM Changeset in webkit [188019] by commit-queue@webkit.org
  • 7 edits
    3 adds
    3 deletes in trunk/LayoutTests

Web Inspector: rewrite protocol test for console messages from X-Frame-Options
​https://bugs.webkit.org/show_bug.cgi?id=147714

Patch by Brian Burg <BJ Burg> on 2015-08-05
Reviewed by Joseph Pecoraro.

Rewrite deny-X-FrameOption.html to use AsyncTestSuite, and hopefully address
the flakiness of the test. It is now in the inspector-protocol/console/ directory.

Extract the addConsoleTestCase helper to a shared file. Clean up console test
helpers and use a less awkward namespace for these helpers.

  • TestExpectations: Unskip the deleted test, the new test should be less flaky.
  • inspector-protocol/console/console-message.html:
  • inspector-protocol/console/css-source-locations.html:
  • inspector-protocol/console/js-source-locations.html:
  • inspector-protocol/console/x-frame-options-message-expected.txt: Added.
  • inspector-protocol/console/x-frame-options-message.html: Added.
  • inspector-protocol/debugger/setBreakpoint-actions.html:
  • inspector-protocol/debugger/setBreakpoint-options-exception.html:
  • inspector-protocol/page/deny-X-FrameOption-expected.txt: Removed.
  • inspector-protocol/page/deny-X-FrameOption.html: Removed.
  • inspector-protocol/resources/console-helper.js: Removed.
  • inspector-protocol/resources/console-test.js: Added.

(InspectorTest.Console.sanitizeConsoleMessage):
(InspectorTest.Console.addTestCase):

9:01 PM Changeset in webkit [188018] by rniwa@webkit.org
  • 5 edits
    3 adds in trunk

[ES6] Class parser does not allow methods named set and get.
​https://bugs.webkit.org/show_bug.cgi?id=147150

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

The bug was caused by parseClass assuming identifiers "get" and "set" could only appear
as the leading token for getter and setter methods. Fixed the bug by generalizing the code
so that we only treat them as such when it's followed by another token that could be a method name.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

LayoutTests:

Added a regression test and rebaselined a test.

  • js/class-syntax-method-names-expected.txt: Added.
  • js/class-syntax-method-names.html: Added.
  • js/class-syntax-semicolon-expected.txt: Rebaselined as the error message got improved.
  • js/script-tests/class-syntax-method-names.js: Added.
  • js/script-tests/class-syntax-semicolon.js:
8:58 PM Changeset in webkit [188017] by Nikita Vasilyev
  • 11 edits
    3 copies
    3 adds in trunk

Web Inspector: Logging error objects should have a better UI
​https://bugs.webkit.org/show_bug.cgi?id=143853

Source/WebInspectorUI:

Previously, an error object looked like any other object, which wasn't very useful.
Source links couldn't be clicked and stacktraces were unreadable.

Unify console.trace, caught and uncaught exceptions. The following examples use
the same StaceTraceView:

  • ({}).x.y
  • try { ({}).x.y } catch (e) { console.log(e); }
  • console.trace()

Reviewed by Brian Burg.

  • UserInterface/Main.html:
  • UserInterface/Models/CallFrame.js:

(WebInspector.CallFrame.fromPayload):
(WebInspector.CallFrame):

  • UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject.prototype.getOwnPropertyDescriptorsAsObject):

  • UserInterface/Test.html:
  • UserInterface/Views/CallFrameView.css:

(.call-frame .separator):
(.call-frame .subtitle .source-link): Deleted.
(.call-frame:focus .subtitle .source-link): Deleted.
(.call-frame .subtitle:empty): Deleted.
(.call-frame .subtitle): Deleted.

  • UserInterface/Views/CallFrameView.js:

(WebInspector.CallFrameView):

  • Start usind CallFrameView in stacktraces.
  • Introduce showFunctionName optional argument. In stacktraces anonymous functions

are shown as "(anonymous function)" but in console message location
links (the ones on the right side of a console message) we omit them.

  • Dash was a pseudo-element and it couldn't be copied to the clipboard.

Make it an actual HTML element.

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message-location.call-frame):
(.console-message-location.call-frame > .title):
(.console-message-location.call-frame > .subtitle > .source-link):
Since .call-frame rules are now used in stacktraces, move console message
specific rules from CallFrameView.css to ConsoleMessageView.css.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
(WebInspector.ConsoleMessageView.prototype._appendStackTrace):
(WebInspector.ConsoleMessageView.prototype._formatParameter):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsError): Added.
Format errors differently from other objects.

  • UserInterface/Views/ErrorObjectView.css: Added.

(.error-object::before):
(.error-object.expanded::before):
(.error-object-link-container):
(.error-object.expanded > .formatted-error > .error-object-link-container):
(.error-object:not(.expanded) .error-object-outline):
(.error-object-outline):

  • UserInterface/Views/ErrorObjectView.js: Added.

(WebInspector.ErrorObjectView):
(WebInspector.ErrorObjectView.parseStackTrace):
(WebInspector.ErrorObjectView.makeSourceLinkWithPrefix):
(WebInspector.ErrorObjectView.prototype.get object):
(WebInspector.ErrorObjectView.prototype.get element):
(WebInspector.ErrorObjectView.prototype.get treeOutline):
(WebInspector.ErrorObjectView.prototype.get expanded):
(WebInspector.ErrorObjectView.prototype.update):
(WebInspector.ErrorObjectView.prototype.expand):
(WebInspector.ErrorObjectView.prototype.collapse):
(WebInspector.ErrorObjectView.prototype._handlePreviewOrTitleElementClick):
(WebInspector.ErrorObjectView.prototype._buildStackTrace):
ErrorObjectView is used to log caught exceptions, e.g.:
try { i.dont.exist++ } catch (e) { console.log(e) }

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForError): Added.
Create error preview.

(WebInspector.FormattedValue.createElementForTypesAndValue):
Fix typo.

(WebInspector.FormattedValue.createObjectPreviewOrFormattedValueForRemoteObject):
Format errors differently from other objects.

LayoutTests:

Add tests for stack trace format in case it changes.

Reviewed by Brian Burg.

  • inspector/debugger/js-stacktrace-expected.txt: Added.
  • inspector/debugger/js-stacktrace.html: Added.
8:38 PM Changeset in webkit [188016] by Alan Bujtas
  • 1 edit
    4 adds in trunk/LayoutTests

Add missing test case (r187994).

Unreviewed.

  • fast/frames/flattening/crash-when-sibling-iframe-is-destroyed-with-subtree-layoutroot-expected.txt: Added.
  • fast/frames/flattening/crash-when-sibling-iframe-is-destroyed-with-subtree-layoutroot.html: Added.
  • fast/frames/flattening/resources/childframe1.html: Added.
  • fast/frames/flattening/resources/childframe2.html: Added.
6:25 PM Changeset in webkit [188015] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r187634): Script time is missing from the frames timeline
​https://bugs.webkit.org/show_bug.cgi?id=147654

Reviewed by Brian Burg.

Use the current stack entry's parent record when pushing a new stack entry, if no
TimelineRecord was generated from the parent record payload.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded):
Don't create a stack entry when record payload children array is empty.

6:25 PM Changeset in webkit [188014] by Chris Dumez
  • 3 edits
    2 adds in trunk

Crash when removing children of a MathMLSelectElement
​https://bugs.webkit.org/show_bug.cgi?id=147704
<rdar://problem/21940321>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When MathMLSelectElement::childrenChanged() is called after its
children have been removed, MathMLSelectElement calls
updateSelectedChild() which accesses m_selectedChild. However,
in this case, m_selectedChild is the previously selected child
and it may be destroyed as this point if it was removed. To avoid
this problem, MathMLSelectElement now keep a strong ref to the
currently selected element.

Test: mathml/maction-removeChild.html

  • mathml/MathMLSelectElement.h:

LayoutTests:

Add layout test that reproduces the crash under guardmalloc.

  • mathml/maction-removeChild-expected.txt: Added.
  • mathml/maction-removeChild.html: Added.
6:14 PM Changeset in webkit [188013] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Migrate FontCascade.cpp to NeverDestroyed
​https://bugs.webkit.org/show_bug.cgi?id=147533

Reviewed by Simon Fraser.

No new tests because there is no behavior change.

  • platform/graphics/FontCascade.cpp:

(WebCore::fontCascadeCache):

6:10 PM Changeset in webkit [188012] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.3

New tag.

6:06 PM Changeset in webkit [188011] by timothy_horton@apple.com
  • 11 edits in trunk/Source/WebKit2

PDFPlugins are clipped in link previews (and remain so when opened)
​https://bugs.webkit.org/show_bug.cgi?id=147708
<rdar://problem/22055130>

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processPool:configuration:webView:]):
(-[WKView _supportsArbitraryLayoutModes]):
(-[WKView _didCommitLoadForMainFrame]):
(-[WKView _setLayoutMode:]):
(-[WKView _setViewScale:]):
Avoid using any layout mode other than "ViewSize" for main frame PluginDocuments,
because they will often end up behaving incorrectly (especially with PDFPlugin,
which is even more special in that it takes over application of page scale).

Save any incoming changes to the viewScale and layoutMode, and re-apply
them once we load something in the main frame that is *not* a PluginDocument.

  • UIProcess/API/mac/WKViewInternal.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scalePage):
Make sure to reset WebCore's page scale if the main frame contains a
PluginDocument that takes care of page scale itself.

(WebKit::WebPage::didCommitLoad):
Do the same thing as what we do in WKView _didCommitLoadForMainFrame,
but without the UI process round-trip, to avoid an ugly flash.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didCommitLoad):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::containsPluginDocument):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Plumb and keep track of whether the main frame contains a PluginDocument or not.

5:26 PM Changeset in webkit [188010] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Try to fix the build

  • WebIconDatabase.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::performOpenAndVerify):

  • Modules/webdatabase/Database.h:
5:02 PM Changeset in webkit [188009] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Delete duplicate forward-declaration
​https://bugs.webkit.org/show_bug.cgi?id=147701

Reviewed by Simon Fraser.

No new tests because there is no behavior change.

  • platform/spi/cocoa/CoreTextSPI.h:
4:58 PM Changeset in webkit [188008] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.17.9

New tag.

4:56 PM Changeset in webkit [188007] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r187900): Breakpoint context menu is broken in Debugger tab
​https://bugs.webkit.org/show_bug.cgi?id=147699

Reviewed by Timothy Hatcher.

  • UserInterface/Views/SourceCodeTextEditor.js:

Skip only the separator and "Reveal in Debugger tab" menu items.

4:55 PM Changeset in webkit [188006] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebInspectorUI

Web Inspector: use super calls in more places
​https://bugs.webkit.org/show_bug.cgi?id=147696

Patch by Brian Burg <BJ Burg> on 2015-08-05
Reviewed by Timothy Hatcher.

A few opportunities for super calls were overlooked when converting to classes.

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype.onattach):
(WebInspector.BreakpointTreeElement.prototype.ondetach):

  • UserInterface/Views/CallFrameTreeElement.js:

(WebInspector.CallFrameTreeElement.prototype.onattach):
(WebInspector.CallFrameTreeElement):

  • UserInterface/Views/DebuggerTabContentView.js:

(WebInspector.DebuggerTabContentView.prototype.showDetailsSidebarPanels):

  • UserInterface/Views/ProfileNodeTreeElement.js:

(WebInspector.ProfileNodeTreeElement.prototype.onattach):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.shown):
(WebInspector.SourceCodeTextEditor.prototype.hidden):
(WebInspector.SourceCodeTextEditor.prototype.canBeFormatted):

  • UserInterface/Views/SourceCodeTreeElement.js:

(WebInspector.SourceCodeTreeElement.prototype.onattach):

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement):

4:50 PM Changeset in webkit [188005] by Brent Fulgham
  • 6 edits in trunk/Source/WebKit/win

[Win] Allow display of mixed content on Windows by default
​https://bugs.webkit.org/show_bug.cgi?id=147693
<rdar://problem/22059707>

Reviewed by Alex Christensen.

  • Interfaces/IWebPreferencesPrivate.idl: Add preference accessor

to allow getting/setting use of insecure content.

  • WebPreferenceKeysPrivate.h: Add new key for preference.
  • WebPreferences.cpp: Implement preference accessor.
  • WebPreferences.h:
  • WebView.cpp: Set WebCore settings to match prefernces for

loading mixed content.

4:50 PM Changeset in webkit [188004] by andersca@apple.com
  • 7 edits in trunk/Source/WebCore

Move the last DatabaseBackendBase functions over to Database
​https://bugs.webkit.org/show_bug.cgi?id=147706

Reviewed by Tim Horton.

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::~Database):
(WebCore::Database::setExpectedVersion):
(WebCore::Database::getActualVersionForTransaction):
(WebCore::Database::version):
(WebCore::Database::stringIdentifier):
(WebCore::Database::displayName):
(WebCore::Database::estimatedSize):
(WebCore::Database::fileName):
(WebCore::Database::details):
(WebCore::Database::maximumSize):
(WebCore::Database::databaseDebugName):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::databaseDebugName): Deleted.
(WebCore::DatabaseBackendBase::~DatabaseBackendBase): Deleted.
(WebCore::DatabaseBackendBase::version): Deleted.
(WebCore::DatabaseBackendBase::securityOrigin): Deleted.
(WebCore::DatabaseBackendBase::stringIdentifier): Deleted.
(WebCore::DatabaseBackendBase::displayName): Deleted.
(WebCore::DatabaseBackendBase::estimatedSize): Deleted.
(WebCore::DatabaseBackendBase::fileName): Deleted.
(WebCore::DatabaseBackendBase::details): Deleted.
(WebCore::DatabaseBackendBase::setExpectedVersion): Deleted.
(WebCore::DatabaseBackendBase::getActualVersionForTransaction): Deleted.
(WebCore::DatabaseBackendBase::maximumSize): Deleted.

  • Modules/webdatabase/DatabaseBackendBase.h:

(WebCore::DatabaseBackendBase::opened): Deleted.
(WebCore::DatabaseBackendBase::isNew): Deleted.
(WebCore::DatabaseBackendBase::sqliteDatabase): Deleted.
(WebCore::DatabaseBackendBase::expectedVersion): Deleted.

  • Modules/webdatabase/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExceedQuota):

  • Modules/webdatabase/SQLTransactionClient.h:
4:49 PM Changeset in webkit [188003] by bshafiei@apple.com
  • 12 edits
    1 delete in branches/safari-600.1.4.17-branch

Roll out r186982. rdar://problem/21709404

4:42 PM Changeset in webkit [188002] by fpizlo@apple.com
  • 129 edits in trunk

Unreviewed, roll out ​http://trac.webkit.org/changeset/187972.

Source/JavaScriptCore:

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::doRun):
(JSC::SamplingTool::notifyOfScope):

  • bytecode/SamplingTool.h:
  • dfg/DFGThreadData.h:
  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::isActiveForVM):
(JSC::DFG::Worklist::enqueue):
(JSC::DFG::Worklist::compilationState):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::removeAllReadyPlansForVM):
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::visitWeakReferences):
(JSC::DFG::Worklist::removeDeadPlans):
(JSC::DFG::Worklist::queueLength):
(JSC::DFG::Worklist::dump):
(JSC::DFG::Worklist::runThread):

  • dfg/DFGWorklist.h:
  • disassembler/Disassembler.cpp:
  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):

  • heap/CopiedSpace.h:
  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::recycleBorrowedBlock):
(JSC::CopiedSpace::allocateBlockForCopyingPhase):

  • heap/HeapTimer.h:
  • heap/MachineStackMarker.cpp:

(JSC::ActiveMachineThreadsManager::Locker::Locker):
(JSC::ActiveMachineThreadsManager::add):
(JSC::ActiveMachineThreadsManager::remove):
(JSC::ActiveMachineThreadsManager::ActiveMachineThreadsManager):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThreadIfFound):
(JSC::MachineThreads::tryCopyOtherThreadStack):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::MachineThreads::gatherConservativeRoots):

  • heap/MachineStackMarker.h:
  • interpreter/JSStack.cpp:

(JSC::stackStatisticsMutex):
(JSC::JSStack::addToCommittedByteCount):
(JSC::JSStack::committedByteCount):

  • jit/JITThunks.h:
  • profiler/ProfilerDatabase.h:

Source/WebCore:

  • Modules/webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::runLoop):

  • Modules/webaudio/AsyncAudioDecoder.h:
  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::addAudioConsumer):
(WebCore::MediaStreamAudioSource::removeAudioConsumer):
(WebCore::MediaStreamAudioSource::setAudioFormat):
(WebCore::MediaStreamAudioSource::consumeAudio):

  • Modules/webaudio/MediaStreamAudioSource.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::close):
(WebCore::Database::runTransaction):
(WebCore::Database::inProgressTransactionCompleted):
(WebCore::Database::hasPendingTransaction):

  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::start):
(WebCore::DatabaseThread::databaseThread):

  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setDatabaseDirectoryPath):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::closeAllDatabases):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::originLockFor):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
(WebCore::DatabaseTracker::openDatabaseMutex):
(WebCore::DatabaseTracker::setClient):
(WebCore::notificationMutex):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
(WebCore::DatabaseTracker::notifyDatabasesChanged):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginLock.h:
  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::unwrap):
(WebCore::SQLCallbackWrapper::hasCallback):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::getNextStatement):

  • Modules/webdatabase/SQLTransactionBackend.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::isExecutionTerminating):

  • bindings/js/WorkerScriptController.h:
  • dom/default/PlatformMessagePortChannel.cpp:

(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
(WebCore::MessagePortChannel::isConnectedTo):
(WebCore::MessagePortChannel::hasPendingActivity):
(WebCore::MessagePortChannel::locallyEntangledPort):
(WebCore::PlatformMessagePortChannel::setRemotePort):
(WebCore::PlatformMessagePortChannel::entangledChannel):
(WebCore::PlatformMessagePortChannel::closeInternal):

  • dom/default/PlatformMessagePortChannel.h:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::performRetainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performReleaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabase::synchronousIconDataKnownForIconURL):
(WebCore::IconDatabase::pageURLMappingCount):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::iconRecordCount):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::wakeSyncThread):
(WebCore::IconDatabase::isOpenBesidesMainThreadCallbacks):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::getOrCreatePageURLRecord):
(WebCore::IconDatabase::iconDatabaseSyncThread):
(WebCore::IconDatabase::performOpenInitialization):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::writeToDatabase):
(WebCore::IconDatabase::pruneUnretainedIcons):
(WebCore::IconDatabase::cleanupSyncThread):

  • loader/icon/IconDatabase.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::setMainFramePinState):
(WebCore::ScrollingTree::mainFrameScrollPosition):
(WebCore::ScrollingTree::setMainFrameScrollPosition):
(WebCore::ScrollingTree::isPointInNonFastScrollableRegion):
(WebCore::ScrollingTree::isRubberBandInProgress):
(WebCore::ScrollingTree::setMainFrameIsRubberBanding):
(WebCore::ScrollingTree::isScrollSnapInProgress):
(WebCore::ScrollingTree::setMainFrameIsScrollSnapping):
(WebCore::ScrollingTree::setCanRubberBandState):
(WebCore::ScrollingTree::rubberBandsAtLeft):
(WebCore::ScrollingTree::rubberBandsAtRight):
(WebCore::ScrollingTree::rubberBandsAtBottom):
(WebCore::ScrollingTree::rubberBandsAtTop):
(WebCore::ScrollingTree::setScrollPinningBehavior):
(WebCore::ScrollingTree::scrollPinningBehavior):
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
(WebCore::ScrollingTree::latchedNode):
(WebCore::ScrollingTree::setLatchedNode):
(WebCore::ScrollingTree::clearLatchedNode):

  • page/scrolling/ScrollingTree.h:
  • platform/MemoryPressureHandler.h:
  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::loadAsynchronously):
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):

  • platform/audio/HRTFDatabaseLoader.h:
  • platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::setReceivedMemoryPressure):
(WebCore::MemoryPressureHandler::clearMemoryPressure):
(WebCore::MemoryPressureHandler::shouldWaitForMemoryClearMessage):
(WebCore::MemoryPressureHandler::respondToMemoryPressureIfNeeded):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

  • platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::setMonotonicAnimationStartTime):
(WebCore::DisplayRefreshMonitor::mutex):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks):
(WebCore::MediaPlayerPrivateAVFoundation::clearMainThreadPendingFlag):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::callbackContext):
(WebCore::AVFWrapper::~AVFWrapper):
(WebCore::AVFWrapper::mapLock):
(WebCore::AVFWrapper::addToMap):
(WebCore::AVFWrapper::removeFromMap):
(WebCore::AVFWrapper::periodicTimeObserverCallback):
(WebCore::AVFWrapper::processNotification):
(WebCore::AVFWrapper::loadPlayableCompletionCallback):
(WebCore::AVFWrapper::loadMetadataCompletionCallback):
(WebCore::AVFWrapper::seekCompletedCallback):
(WebCore::AVFWrapper::processCue):
(WebCore::AVFWrapper::legibleOutputCallback):
(WebCore::AVFWrapper::processShouldWaitForLoadingOfResource):
(WebCore::AVFWrapper::resourceLoaderShouldWaitForLoadingOfRequestedResource):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitorMac::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::addListener):
(WebCore::MediaPlayerPrivateMediaFoundation::removeListener):
(WebCore::MediaPlayerPrivateMediaFoundation::notifyDeleted):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::Invoke):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::onMediaPlayerDeleted):

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
  • platform/ios/LegacyTileCache.h:
  • platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::setTilesOpaque):
(WebCore::LegacyTileCache::doLayoutTiles):
(WebCore::LegacyTileCache::setCurrentScale):
(WebCore::LegacyTileCache::commitScaleChange):
(WebCore::LegacyTileCache::layoutTilesNow):
(WebCore::LegacyTileCache::layoutTilesNowForRect):
(WebCore::LegacyTileCache::removeAllNonVisibleTiles):
(WebCore::LegacyTileCache::removeAllTiles):
(WebCore::LegacyTileCache::removeForegroundTiles):
(WebCore::LegacyTileCache::setContentReplacementImage):
(WebCore::LegacyTileCache::contentReplacementImage):
(WebCore::LegacyTileCache::tileCreationTimerFired):
(WebCore::LegacyTileCache::setNeedsDisplayInRect):
(WebCore::LegacyTileCache::updateTilingMode):
(WebCore::LegacyTileCache::setTilingMode):
(WebCore::LegacyTileCache::doPendingRepaints):
(WebCore::LegacyTileCache::flushSavedDisplayRects):
(WebCore::LegacyTileCache::prepareToDraw):

  • platform/ios/LegacyTileLayerPool.h:
  • platform/ios/LegacyTileLayerPool.mm:

(WebCore::LegacyTileLayerPool::addLayer):
(WebCore::LegacyTileLayerPool::takeLayerWithSize):
(WebCore::LegacyTileLayerPool::setCapacity):
(WebCore::LegacyTileLayerPool::prune):
(WebCore::LegacyTileLayerPool::drain):

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::add):
(WebCore::CurlDownloadManager::remove):
(WebCore::CurlDownloadManager::getActiveDownloadCount):
(WebCore::CurlDownloadManager::getPendingDownloadCount):
(WebCore::CurlDownloadManager::stopThreadIfIdle):
(WebCore::CurlDownloadManager::updateHandleList):
(WebCore::CurlDownload::~CurlDownload):
(WebCore::CurlDownload::init):
(WebCore::CurlDownload::getTempPath):
(WebCore::CurlDownload::getUrl):
(WebCore::CurlDownload::getResponse):
(WebCore::CurlDownload::closeFile):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData):
(WebCore::CurlDownload::didFail):

  • platform/network/curl/CurlDownload.h:
  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::cookieJarPath):
(WebCore::sharedResourceMutex):
(WebCore::curl_lock_callback):
(WebCore::curl_unlock_callback):

  • platform/network/ios/QuickLook.mm:

(WebCore::QLDirectoryAttributes):
(qlPreviewConverterDictionaryMutex):
(WebCore::addQLPreviewConverterWithFileForURL):
(WebCore::qlPreviewConverterUTIForURL):
(WebCore::removeQLPreviewConverterForURL):
(WebCore::safeQLURLForDocumentURLAndResourceURL):

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::setMaximumSize):
(WebCore::SQLiteDatabase::pageSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::setAuthorizer):

  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::databaseMutex):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

  • workers/WorkerThread.h:

Source/WebKit:

  • Storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::markImported):
(WebCore::StorageAreaSync::blockUntilImportComplete):
(WebCore::StorageAreaSync::performSync):

  • Storage/StorageAreaSync.h:
  • Storage/StorageTracker.cpp:

(WebCore::StorageTracker::setDatabaseDirectoryPath):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::diskUsageForOrigin):

  • Storage/StorageTracker.h:

Source/WebKit/ios:

  • WebCoreSupport/WebFixedPositionContent.mm:

(WebFixedPositionContentDataLock):
(-[WebFixedPositionContent scrollOrZoomChanged:]):
(-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
(-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
(-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
(-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]):

Source/WebKit/mac:

  • Storage/WebDatabaseManager.mm:

(transactionBackgroundTaskIdentifierLock):
(+[WebDatabaseManager startBackgroundTask]):
(+[WebDatabaseManager endBackgroundTask]):

  • WebView/WebView.mm:

(-[WebView _synchronizeCustomFixedPositionLayoutRect]):
(-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
(-[WebView _setCustomFixedPositionLayoutRect:]):
(-[WebView _fetchCustomFixedPositionLayoutRect:]):

  • WebView/WebViewData.h:

Source/WebKit/win:

  • Plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::registerPlugin):
(WebCore::PluginMainThreadScheduler::unregisterPlugin):
(WebCore::PluginMainThreadScheduler::dispatchCallsForPlugin):

  • Plugins/PluginMainThreadScheduler.h:
  • WebIconDatabase.cpp:

(WebIconDatabase::didRemoveAllIcons):
(WebIconDatabase::didImportIconURLForPageURL):
(WebIconDatabase::deliverNotifications):

  • WebLocalizableStrings.cpp:

(mainBundleLocStrings):
(frameworkLocStringsMutex):
(findCachedString):
(cacheString):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::shutdown):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • Platform/IPC/Connection.cpp:

(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingSyncReply):
(IPC::Connection::connectionDidClose):

  • Platform/IPC/Connection.h:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::appendUpdate):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::createCompositingThread):
(WebKit::ThreadedCompositor::runCompositingThread):
(WebKit::ThreadedCompositor::terminateCompositingThread):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:

(WebKit::CustomProtocolManager::addCustomProtocol):
(WebKit::CustomProtocolManager::removeCustomProtocol):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::protocolForID):

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/linux/SeccompFilters/SeccompBroker.cpp:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
(WebKit::PluginProcessConnectionManager::removePluginProcessConnection):
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::removeScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):

  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(webkitSoupRequestInputStreamReadAsync):
(webkitSoupRequestInputStreamAddData):

Source/WTF:

  • wtf/Atomics.cpp:

(WTF::getSwapLock):
(WTF::atomicStep):

  • wtf/MessageQueue.h:

(WTF::MessageQueue::infiniteTime):
(WTF::MessageQueue<DataType>::append):
(WTF::MessageQueue<DataType>::appendAndKill):
(WTF::MessageQueue<DataType>::appendAndCheckEmpty):
(WTF::MessageQueue<DataType>::prepend):
(WTF::MessageQueue<DataType>::removeIf):
(WTF::MessageQueue<DataType>::isEmpty):
(WTF::MessageQueue<DataType>::kill):
(WTF::MessageQueue<DataType>::killed):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ThreadPrivate::execute):
(WTF::ParallelEnvironment::ThreadPrivate::waitForFinish):
(WTF::ParallelEnvironment::ThreadPrivate::workerThread):

  • wtf/ParallelJobsGeneric.h:
  • wtf/RunLoop.cpp:

(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h:
  • wtf/ThreadSpecificWin.cpp:

(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
(WTF::ThreadSpecificThreadExit):

  • wtf/Threading.cpp:

(WTF::threadEntryPoint):
(WTF::createThread):

  • wtf/ThreadingPrimitives.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::threadMapMutex):
(WTF::initializeThreading):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::changeThreadPriority):
(WTF::waitForThreadCompletion):
(WTF::detachThread):
(WTF::threadDidExit):
(WTF::currentThread):
(WTF::Mutex::Mutex):
(WTF::Mutex::~Mutex):
(WTF::Mutex::lock):
(WTF::Mutex::tryLock):
(WTF::Mutex::unlock):
(WTF::ThreadCondition::~ThreadCondition):
(WTF::ThreadCondition::wait):
(WTF::ThreadCondition::timedWait):
(WTF::DeprecatedMutex::DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::~DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::lock): Deleted.
(WTF::DeprecatedMutex::tryLock): Deleted.
(WTF::DeprecatedMutex::unlock): Deleted.

  • wtf/ThreadingWin.cpp:

(WTF::initializeCurrentThreadInternal):
(WTF::threadMapMutex):
(WTF::initializeThreading):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::clearThreadHandleForIdentifier):
(WTF::currentThread):
(WTF::Mutex::Mutex):
(WTF::Mutex::~Mutex):
(WTF::Mutex::lock):
(WTF::Mutex::tryLock):
(WTF::Mutex::unlock):
(WTF::ThreadCondition::~ThreadCondition):
(WTF::ThreadCondition::wait):
(WTF::ThreadCondition::timedWait):
(WTF::DeprecatedMutex::DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::~DeprecatedMutex): Deleted.
(WTF::DeprecatedMutex::lock): Deleted.
(WTF::DeprecatedMutex::tryLock): Deleted.
(WTF::DeprecatedMutex::unlock): Deleted.

  • wtf/WorkQueue.h:
  • wtf/dtoa.cpp:
  • wtf/dtoa.h:
  • wtf/efl/DispatchQueueEfl.cpp:

(DispatchQueue::dispatch):
(DispatchQueue::performWork):
(DispatchQueue::performTimerWork):
(DispatchQueue::insertTimerWorkItem):
(DispatchQueue::wakeUpThread):
(DispatchQueue::getNextTimeOut):

  • wtf/efl/DispatchQueueEfl.h:
  • wtf/efl/RunLoopEfl.cpp:

(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):

  • wtf/threads/BinarySemaphore.cpp:

(WTF::BinarySemaphore::signal):
(WTF::BinarySemaphore::wait):

  • wtf/threads/BinarySemaphore.h:
  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::handleCallback):
(WTF::WorkQueue::platformInvalidate):
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::timerCallback):
(WTF::WorkQueue::dispatchAfter):

Tools:

  • DumpRenderTree/JavaScriptThreading.cpp:

(javaScriptThreadsMutex):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):

  • TestWebKitAPI/Tests/WTF/WorkQueue.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:

(TestWebKitAPI::TEST):

4:41 PM Changeset in webkit [188001] by bshafiei@apple.com
  • 3 edits in branches/safari-600.1.4.17-branch/LayoutTests

Roll out r186988. rdar://problem/21709404

4:40 PM Changeset in webkit [188000] by bshafiei@apple.com
  • 1 edit in branches/safari-600.1.4.17-branch/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp

Roll out r187040. rdar://problem/21709404

4:23 PM Changeset in webkit [187999] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move more functions from DatabaseBackendBase to Database
​https://bugs.webkit.org/show_bug.cgi?id=147705

Reviewed by Tim Horton.

  • Modules/webdatabase/Database.cpp:

(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::Database::Database):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::setOpenSucceeded):
(WebCore::Database::performOpenAndVerify):
(WebCore::Database::closeDatabase):
(WebCore::Database::getCachedVersion):
(WebCore::Database::setCachedVersion):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::version):
(WebCore::formatErrorMessage): Deleted.
(WebCore::guidMutex): Deleted.
(WebCore::guidToVersionMap): Deleted.
(WebCore::updateGuidVersionMap): Deleted.
(WebCore::guidToDatabaseMap): Deleted.
(WebCore::guidForOriginAndName): Deleted.
(WebCore::DatabaseBackendBase::DatabaseBackendBase): Deleted.
(WebCore::DatabaseBackendBase::closeDatabase): Deleted.
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller): Deleted.
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller): Deleted.
(WebCore::DoneCreatingDatabaseOnExitCaller::setOpenSucceeded): Deleted.
(WebCore::DatabaseBackendBase::performOpenAndVerify): Deleted.
(WebCore::DatabaseBackendBase::getCachedVersion): Deleted.
(WebCore::DatabaseBackendBase::setCachedVersion): Deleted.

  • Modules/webdatabase/DatabaseBackendBase.h:
4:17 PM Changeset in webkit [187998] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move more functions from DatabaseBackendBase to Database
​https://bugs.webkit.org/show_bug.cgi?id=147703

Reviewed by Tim Horton.

  • Modules/webdatabase/Database.cpp:

(WebCore::fullyQualifiedInfoTableName):
(WebCore::setTextValueInDatabase):
(WebCore::retrieveTextResultFromDatabase):
(WebCore::Database::getVersionFromDatabase):
(WebCore::Database::setVersionInDatabase):
(WebCore::Database::performGetTableNames):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::databaseInfoTableName): Deleted.
(WebCore::fullyQualifiedInfoTableName): Deleted.
(WebCore::retrieveTextResultFromDatabase): Deleted.
(WebCore::setTextValueInDatabase): Deleted.
(WebCore::DatabaseBackendBase::getVersionFromDatabase): Deleted.
(WebCore::DatabaseBackendBase::setVersionInDatabase): Deleted.

  • Modules/webdatabase/DatabaseBackendBase.h:
4:02 PM Changeset in webkit [187997] by achristensen@apple.com
  • 13 edits in trunk

Build DumpRenderTree with CMake.
​https://bugs.webkit.org/show_bug.cgi?id=147519

Reviewed by Brent Fulgham.

Source/WebCore:

  • CMakeLists.txt:

WebCoreTestSupport is a static library and should not be linked with WebCore.

Source/WebKit:

  • CMakeLists.txt:
  • PlatformMac.cmake:
  • PlatformWin.cmake:

Make the libraries WebKit links with private, which means that CMake will not make everything
that links with WebKit link with everything WebKit links with.

Source/WebKit/win:

  • WebView.cpp:

Include JSScriptProfile.h to export toJS(ExecState*, JSDomGlobalObject*, JSC::Profile*) from WebKit.dll.

Tools:

  • CMakeLists.txt:

Build the DumpRenderTree directory now that it builds successfully.

  • DumpRenderTree/CMakeLists.txt:

Added missing source file and don't link with WebCore.lib.

  • DumpRenderTree/PlatformWin.cmake:

Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp.

  • WinLauncher/CMakeLists.txt:

We need libcmt now that we are not linking with WebCore.lib.

3:58 PM Changeset in webkit [187996] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Move some more DatabaseBackendBase functions to Database
​https://bugs.webkit.org/show_bug.cgi?id=147702

Reviewed by Tim Horton.

  • Modules/webdatabase/Database.cpp:

(WebCore::formatErrorMessage):
(WebCore::Database::disableAuthorizer):
(WebCore::Database::enableAuthorizer):
(WebCore::Database::setAuthorizerPermissions):
(WebCore::Database::lastActionChangedDatabase):
(WebCore::Database::lastActionWasInsert):
(WebCore::Database::resetDeletes):
(WebCore::Database::hadDeletes):
(WebCore::Database::resetAuthorizer):
(WebCore::Database::incrementalVacuumIfNeeded):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::disableAuthorizer): Deleted.
(WebCore::DatabaseBackendBase::enableAuthorizer): Deleted.
(WebCore::DatabaseBackendBase::setAuthorizerPermissions): Deleted.
(WebCore::DatabaseBackendBase::lastActionChangedDatabase): Deleted.
(WebCore::DatabaseBackendBase::lastActionWasInsert): Deleted.
(WebCore::DatabaseBackendBase::resetDeletes): Deleted.
(WebCore::DatabaseBackendBase::hadDeletes): Deleted.
(WebCore::DatabaseBackendBase::resetAuthorizer): Deleted.
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded): Deleted.

  • Modules/webdatabase/DatabaseBackendBase.h:
3:57 PM Changeset in webkit [187995] by mmaxfield@apple.com
  • 1 edit
    2 adds in trunk/PerformanceTests

Add a second font-fallback performance test
​https://bugs.webkit.org/show_bug.cgi?id=147692

Reviewed by Ryosuke Niwa.

This test is smaller, but has more realistic content. Also, it uses the "lang" attribute.

  • Layout/font-fallback-2.html: Added.
  • Layout/resources/font-fallback-2.html: Added.
3:39 PM Changeset in webkit [187994] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[Frame flattening] Return early when child RenderView is not available.
​https://bugs.webkit.org/show_bug.cgi?id=147697

Reviewed by Simon Fraser.

No change in functionality.

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::peformLayoutWithFlattening):

3:33 PM Changeset in webkit [187993] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Remove more dead database code
​https://bugs.webkit.org/show_bug.cgi?id=147698

Reviewed by Tim Horton.

  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::interrupt): Deleted.
(WebCore::DatabaseBackendBase::isInterrupted): Deleted.

  • Modules/webdatabase/DatabaseBackendBase.h:
  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::execute):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::computeNextStateAndCleanupIfNeeded):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::setFullsync):
(WebCore::SQLiteDatabase::SQLiteDatabase): Deleted.
(WebCore::SQLiteDatabase::interrupt): Deleted.
(WebCore::SQLiteDatabase::isInterrupted): Deleted.

  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare): Deleted.
(WebCore::SQLiteStatement::step): Deleted.

3:20 PM Changeset in webkit [187992] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/win

Fix Windows build.

  • WebIconDatabase.h:
2:45 PM Changeset in webkit [187991] by saambarati1@gmail.com
  • 3 edits in trunk/Source/JavaScriptCore

Bytecodegenerator emits crappy code for returns in a lexical scope.
​https://bugs.webkit.org/show_bug.cgi?id=147688

Reviewed by Mark Lam.

When returning, we only need to emit complex pop scopes if we're in
a finally block. Otherwise, we can just return like normal. This saves
us from inefficiently emitting unnecessary pop scopes.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::isInFinallyBlock):
(JSC::BytecodeGenerator::hasFinaliser): Deleted.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ReturnNode::emitBytecode):

2:45 PM Changeset in webkit [187990] by Simon Fraser
  • 6 edits
    32 moves
    5 adds
    1 delete in trunk/LayoutTests

Move platform/ios-simulator/ios/fast/events/touch tests to fast/events/touch

  • fast/events/touch/document-create-touch-list-ios-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/document-create-touch-list-ios-expected.txt.
  • fast/events/touch/document-create-touch-list-ios.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/document-create-touch-list-ios.html.
  • fast/events/touch/gesture-event-basic-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/gesture-event-basic-expected.txt.
  • fast/events/touch/gesture-event-basic.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/gesture-event-basic.html.
  • fast/events/touch/input-touch-target.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/input-touch-target.html.
  • fast/events/touch/inserted-fragment-touch-target-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/inserted-fragment-touch-target-expected.txt.
  • fast/events/touch/inserted-fragment-touch-target.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/inserted-fragment-touch-target.html.
  • fast/events/touch/moved-touch-target-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/moved-touch-target-expected.txt.
  • fast/events/touch/moved-touch-target.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/moved-touch-target.html.
  • fast/events/touch/multi-touch-some-without-handlers.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/multi-touch-some-without-handlers.html.
  • fast/events/touch/ontouchstart-active-selector.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/ontouchstart-active-selector.html.
  • fast/events/touch/removed-fragment-touch-target-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/removed-fragment-touch-target-expected.txt.
  • fast/events/touch/removed-fragment-touch-target.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/removed-fragment-touch-target.html.
  • fast/events/touch/removed-touch-target-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/removed-touch-target-expected.txt.
  • fast/events/touch/removed-touch-target.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/removed-touch-target.html.
  • fast/events/touch/resources/misc-touch-helpers.js: Renamed from LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/misc-touch-helpers.js.
  • fast/events/touch/script-tests/document-create-touch-list-ios.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/document-create-touch-list-ios.js.
  • fast/events/touch/script-tests/input-touch-target.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/input-touch-target.js.
  • fast/events/touch/script-tests/multi-touch-some-without-handlers.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/multi-touch-some-without-handlers.js.
  • fast/events/touch/script-tests/text-node-touch-target.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/text-node-touch-target.js.
  • fast/events/touch/script-tests/textarea-touch-target.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/textarea-touch-target.js.
  • fast/events/touch/script-tests/touch-event-frames.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/touch-event-frames.js.
  • fast/events/touch/script-tests/touch-event-pageXY.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/touch-event-pageXY.js.
  • fast/events/touch/script-tests/zoomed-touch-event-pageXY.js: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/script-tests/zoomed-touch-event-pageXY.js.
  • fast/events/touch/text-node-touch-target.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/text-node-touch-target.html.
  • fast/events/touch/textarea-touch-target.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/textarea-touch-target.html.
  • fast/events/touch/touch-event-frames-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/touch-event-frames-expected.txt.
  • fast/events/touch/touch-event-frames.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/touch-event-frames.html.
  • fast/events/touch/touch-event-pageXY-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/touch-event-pageXY-expected.txt.
  • fast/events/touch/touch-event-pageXY.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/touch-event-pageXY.html.
  • fast/events/touch/touch-scaled-scrolled.html:
  • fast/events/touch/zoomed-touch-event-pageXY-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/zoomed-touch-event-pageXY-expected.txt.
  • fast/events/touch/zoomed-touch-event-pageXY.html: Renamed from LayoutTests/platform/ios-simulator/ios/fast/events/touch/zoomed-touch-event-pageXY.html.
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/ios/fast/events/touch/script-tests/TEMPLATE.html: Removed.
  • platform/mac/TestExpectations:
2:44 PM Changeset in webkit [187989] by Simon Fraser
  • 3 edits in trunk/LayoutTests

Remove non-existant tests from iOS TestExpectations files.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
2:42 PM Changeset in webkit [187988] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed, fix Windows.

  • wtf/ThreadSpecificWin.cpp:

(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):
(WTF::ThreadSpecificThreadExit):

2:38 PM Changeset in webkit [187987] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Fix build.

  • platform/cf/CoreMediaSoftLink.cpp:
  • platform/cf/CoreMediaSoftLink.h:
2:17 PM Changeset in webkit [187986] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove unused Object.deprecatedAddConstructorFunctions
​https://bugs.webkit.org/show_bug.cgi?id=147690

Patch by Brian Burg <BJ Burg> on 2015-08-05
Reviewed by Timothy Hatcher.

This is no longer used following the conversion to ES6 classes.

  • UserInterface/Base/Object.js:

(WebInspector.Object.deprecatedAddConstructorFunctions): Deleted.

1:44 PM Changeset in webkit [187985] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::lookupCTFont):

1:34 PM Changeset in webkit [187984] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

Change openDatabase to return a Database instead of a DatabaseBackendBase
​https://bugs.webkit.org/show_bug.cgi?id=147691

Reviewed by Tim Horton.

  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::create): Deleted.

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):

  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):

  • Modules/webdatabase/DatabaseServer.h:
1:23 PM Changeset in webkit [187983] by matthew_hanson@apple.com
  • 1 edit in branches/safari-601.1.46-branch/Source/WebKit2/WebProcess/WebCoreSupport/SessionStateConversion.cpp

Follow-up fix to the merge of r187962. rdar://problem/21827815

1:07 PM Changeset in webkit [187982] by mmaxfield@apple.com
  • 6 edits in trunk/Source/WebCore

[OS X] Migrate to CTFontCreateForCharactersWithLanguage from [NSFont findFontLike:forString:withRange:inLanguage]
​https://bugs.webkit.org/show_bug.cgi?id=147483

Reviewed by Dean Jackson.

[NSFont findFontLike:forString:withRange:inLanguage] doesn't properly handle its last argument. In
addition, we want to be moving away from NSFont in the first place and on to Core Text. This new
CoreText function correctly handles its language argument, which is required for language-specific
font fallback.

This patch rolls r187707 back in which was rolled out in r187802 due to test flakiness. This patch
fixes the flakiness.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/FontCache.h:

(WebCore::FontCache::platformPurgeInactiveFontData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fallbackDedupSet):
(WebCore::FontCache::platformPurgeInactiveFontData):
(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/spi/cocoa/CoreTextSPI.h:
  • platform/spi/mac/NSFontSPI.h:
1:04 PM Changeset in webkit [187981] by benjamin@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Fix the twitter links on the status page

  • status.html:
12:57 PM Changeset in webkit [187980] by matthew_hanson@apple.com
  • 15 edits
    1 add in branches/safari-601.1.46-branch

Merge r187962. rdar://problem/21827815

12:57 PM Changeset in webkit [187979] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r187764. rdar://problem/22077836

12:57 PM Changeset in webkit [187978] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187864. rdar://problem/22081036

12:57 PM Changeset in webkit [187977] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add the Intl API to the status page

  • features.json:

Andy VanWagoner landed the skeleton of the API and it is
enabled by default.

12:57 PM Changeset in webkit [187976] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r187756. rdar://problem/22119648

12:54 PM Changeset in webkit [187975] by ap@apple.com
  • 7 edits in trunk/Tools

AppScale: Use https URLs for subresources and links
​https://bugs.webkit.org/show_bug.cgi?id=147686

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/filters/webkit_extras.py:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:
  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  • TestResultServer/static-dashboards/treemap.js:
  • TestResultServer/static-dashboards/ui.js:
12:31 PM Changeset in webkit [187974] by andersca@apple.com
  • 15 edits
    2 deletes in trunk/Source/WebCore

Get rid of DatabaseBackend as another step towards merging Database and DatabaseBackendBase
​https://bugs.webkit.org/show_bug.cgi?id=147687

Reviewed by Tim Horton.

  • CMakeLists.txt:
  • Modules/webdatabase/ChangeVersionWrapper.cpp:

(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::close):
(WebCore::Database::from): Deleted.
(WebCore::Database::backend): Deleted.

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseBackend.cpp: Removed.

(WebCore::DatabaseBackend::DatabaseBackend): Deleted.

  • Modules/webdatabase/DatabaseBackend.h: Removed.
  • Modules/webdatabase/DatabaseManager.cpp:
  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseTableNamesTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseOpenTask::DatabaseOpenTask): Deleted.
(WebCore::DatabaseBackend::DatabaseOpenTask::doPerformTask): Deleted.
(WebCore::DatabaseBackend::DatabaseOpenTask::debugTaskName): Deleted.
(WebCore::DatabaseBackend::DatabaseCloseTask::DatabaseCloseTask): Deleted.
(WebCore::DatabaseBackend::DatabaseCloseTask::doPerformTask): Deleted.
(WebCore::DatabaseBackend::DatabaseCloseTask::debugTaskName): Deleted.
(WebCore::DatabaseBackend::DatabaseTransactionTask::DatabaseTransactionTask): Deleted.
(WebCore::DatabaseBackend::DatabaseTransactionTask::~DatabaseTransactionTask): Deleted.
(WebCore::DatabaseBackend::DatabaseTransactionTask::doPerformTask): Deleted.
(WebCore::DatabaseBackend::DatabaseTransactionTask::debugTaskName): Deleted.
(WebCore::DatabaseBackend::DatabaseTableNamesTask::DatabaseTableNamesTask): Deleted.
(WebCore::DatabaseBackend::DatabaseTableNamesTask::doPerformTask): Deleted.
(WebCore::DatabaseBackend::DatabaseTableNamesTask::debugTaskName): Deleted.

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseTask::database):

  • Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::execute):

  • Modules/webdatabase/SQLStatementBackend.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
12:21 PM Changeset in webkit [187973] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebInspectorProxy should make WKWebView first responder
​https://bugs.webkit.org/show_bug.cgi?id=147676

Reviewed by Timothy Hatcher.

Revert r181927 now that WKWebView forwards the first responder role to WKView as needed.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformAttach):

12:20 PM Changeset in webkit [187972] by fpizlo@apple.com
  • 130 edits in trunk

Rename Mutex to DeprecatedMutex
​https://bugs.webkit.org/show_bug.cgi?id=147675

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • bytecode/SamplingTool.cpp:

(JSC::SamplingTool::doRun):
(JSC::SamplingTool::notifyOfScope):

  • bytecode/SamplingTool.h:
  • dfg/DFGThreadData.h:
  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::isActiveForVM):
(JSC::DFG::Worklist::enqueue):
(JSC::DFG::Worklist::compilationState):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::removeAllReadyPlansForVM):
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::visitWeakReferences):
(JSC::DFG::Worklist::removeDeadPlans):
(JSC::DFG::Worklist::queueLength):
(JSC::DFG::Worklist::dump):
(JSC::DFG::Worklist::runThread):

  • dfg/DFGWorklist.h:
  • disassembler/Disassembler.cpp:
  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::doneCopying):

  • heap/CopiedSpace.h:
  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::recycleBorrowedBlock):
(JSC::CopiedSpace::allocateBlockForCopyingPhase):

  • heap/HeapTimer.h:
  • heap/MachineStackMarker.cpp:

(JSC::ActiveMachineThreadsManager::Locker::Locker):
(JSC::ActiveMachineThreadsManager::add):
(JSC::ActiveMachineThreadsManager::remove):
(JSC::ActiveMachineThreadsManager::ActiveMachineThreadsManager):
(JSC::MachineThreads::~MachineThreads):
(JSC::MachineThreads::addCurrentThread):
(JSC::MachineThreads::removeThreadIfFound):
(JSC::MachineThreads::tryCopyOtherThreadStack):
(JSC::MachineThreads::tryCopyOtherThreadStacks):
(JSC::MachineThreads::gatherConservativeRoots):

  • heap/MachineStackMarker.h:
  • interpreter/JSStack.cpp:

(JSC::stackStatisticsMutex):
(JSC::JSStack::addToCommittedByteCount):
(JSC::JSStack::committedByteCount):

  • jit/JITThunks.h:
  • profiler/ProfilerDatabase.h:

Source/WebCore:

No new tests because this is just a renaming.

  • Modules/webaudio/AsyncAudioDecoder.cpp:

(WebCore::AsyncAudioDecoder::AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::runLoop):

  • Modules/webaudio/AsyncAudioDecoder.h:
  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::addAudioConsumer):
(WebCore::MediaStreamAudioSource::removeAudioConsumer):
(WebCore::MediaStreamAudioSource::setAudioFormat):
(WebCore::MediaStreamAudioSource::consumeAudio):

  • Modules/webaudio/MediaStreamAudioSource.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::close):
(WebCore::Database::runTransaction):
(WebCore::Database::inProgressTransactionCompleted):
(WebCore::Database::hasPendingTransaction):

  • Modules/webdatabase/DatabaseBackend.h:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::isInterrupted):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::setPaused):

  • Modules/webdatabase/DatabaseContext.h:
  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::start):
(WebCore::DatabaseThread::setPaused):
(WebCore::DatabaseThread::handlePausedQueue):
(WebCore::DatabaseThread::databaseThread):

  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setDatabaseDirectoryPath):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForOrigin):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::closeAllDatabases):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):
(WebCore::DatabaseTracker::originLockFor):
(WebCore::DatabaseTracker::quotaForOrigin):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
(WebCore::DatabaseTracker::openDatabaseMutex):
(WebCore::DatabaseTracker::setDatabasesPaused):
(WebCore::DatabaseTracker::setClient):
(WebCore::notificationMutex):
(WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged):
(WebCore::DatabaseTracker::notifyDatabasesChanged):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/OriginLock.h:
  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::clear):
(WebCore::SQLCallbackWrapper::unwrap):
(WebCore::SQLCallbackWrapper::hasCallback):

  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::enqueueStatementBackend):
(WebCore::SQLTransactionBackend::getNextStatement):

  • Modules/webdatabase/SQLTransactionBackend.h:
  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::isExecutionTerminating):

  • bindings/js/WorkerScriptController.h:
  • dom/default/PlatformMessagePortChannel.cpp:

(WebCore::MessagePortChannel::postMessageToRemote):
(WebCore::MessagePortChannel::tryGetMessageFromRemote):
(WebCore::MessagePortChannel::isConnectedTo):
(WebCore::MessagePortChannel::hasPendingActivity):
(WebCore::MessagePortChannel::locallyEntangledPort):
(WebCore::PlatformMessagePortChannel::setRemotePort):
(WebCore::PlatformMessagePortChannel::entangledChannel):
(WebCore::PlatformMessagePortChannel::closeInternal):

  • dom/default/PlatformMessagePortChannel.h:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore::IconDatabase::synchronousIconURLForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::performRetainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performReleaseIconForPageURL):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::setIconURLForPageURL):
(WebCore::IconDatabase::synchronousLoadDecisionForIconURL):
(WebCore::IconDatabase::synchronousIconDataKnownForIconURL):
(WebCore::IconDatabase::pageURLMappingCount):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::iconRecordCount):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::wakeSyncThread):
(WebCore::IconDatabase::isOpenBesidesMainThreadCallbacks):
(WebCore::IconDatabase::databasePath):
(WebCore::IconDatabase::getOrCreatePageURLRecord):
(WebCore::IconDatabase::iconDatabaseSyncThread):
(WebCore::IconDatabase::performOpenInitialization):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::writeToDatabase):
(WebCore::IconDatabase::pruneUnretainedIcons):
(WebCore::IconDatabase::cleanupSyncThread):

  • loader/icon/IconDatabase.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::setMainFramePinState):
(WebCore::ScrollingTree::mainFrameScrollPosition):
(WebCore::ScrollingTree::setMainFrameScrollPosition):
(WebCore::ScrollingTree::isPointInNonFastScrollableRegion):
(WebCore::ScrollingTree::isRubberBandInProgress):
(WebCore::ScrollingTree::setMainFrameIsRubberBanding):
(WebCore::ScrollingTree::isScrollSnapInProgress):
(WebCore::ScrollingTree::setMainFrameIsScrollSnapping):
(WebCore::ScrollingTree::setCanRubberBandState):
(WebCore::ScrollingTree::rubberBandsAtLeft):
(WebCore::ScrollingTree::rubberBandsAtRight):
(WebCore::ScrollingTree::rubberBandsAtBottom):
(WebCore::ScrollingTree::rubberBandsAtTop):
(WebCore::ScrollingTree::setScrollPinningBehavior):
(WebCore::ScrollingTree::scrollPinningBehavior):
(WebCore::ScrollingTree::willWheelEventStartSwipeGesture):
(WebCore::ScrollingTree::latchedNode):
(WebCore::ScrollingTree::setLatchedNode):
(WebCore::ScrollingTree::clearLatchedNode):

  • page/scrolling/ScrollingTree.h:
  • platform/MemoryPressureHandler.h:
  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::loadAsynchronously):
(WebCore::HRTFDatabaseLoader::waitForLoaderThreadCompletion):

  • platform/audio/HRTFDatabaseLoader.h:
  • platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::setReceivedMemoryPressure):
(WebCore::MemoryPressureHandler::clearMemoryPressure):
(WebCore::MemoryPressureHandler::shouldWaitForMemoryClearMessage):
(WebCore::MemoryPressureHandler::respondToMemoryPressureIfNeeded):

  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

  • platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::setMonotonicAnimationStartTime):
(WebCore::DisplayRefreshMonitor::mutex):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::setDelayCallbacks):
(WebCore::MediaPlayerPrivateAVFoundation::clearMainThreadPendingFlag):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::callbackContext):
(WebCore::AVFWrapper::~AVFWrapper):
(WebCore::AVFWrapper::mapLock):
(WebCore::AVFWrapper::addToMap):
(WebCore::AVFWrapper::removeFromMap):
(WebCore::AVFWrapper::periodicTimeObserverCallback):
(WebCore::AVFWrapper::processNotification):
(WebCore::AVFWrapper::loadPlayableCompletionCallback):
(WebCore::AVFWrapper::loadMetadataCompletionCallback):
(WebCore::AVFWrapper::seekCompletedCallback):
(WebCore::AVFWrapper::processCue):
(WebCore::AVFWrapper::legibleOutputCallback):
(WebCore::AVFWrapper::processShouldWaitForLoadingOfResource):
(WebCore::AVFWrapper::resourceLoaderShouldWaitForLoadingOfRequestedResource):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::notifyTrackOfSample):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::tagsChanged):
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitorMac::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::addListener):
(WebCore::MediaPlayerPrivateMediaFoundation::removeListener):
(WebCore::MediaPlayerPrivateMediaFoundation::notifyDeleted):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::Invoke):
(WebCore::MediaPlayerPrivateMediaFoundation::AsyncCallback::onMediaPlayerDeleted):

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
  • platform/ios/LegacyTileCache.h:
  • platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::setTilesOpaque):
(WebCore::LegacyTileCache::doLayoutTiles):
(WebCore::LegacyTileCache::setCurrentScale):
(WebCore::LegacyTileCache::commitScaleChange):
(WebCore::LegacyTileCache::layoutTilesNow):
(WebCore::LegacyTileCache::layoutTilesNowForRect):
(WebCore::LegacyTileCache::removeAllNonVisibleTiles):
(WebCore::LegacyTileCache::removeAllTiles):
(WebCore::LegacyTileCache::removeForegroundTiles):
(WebCore::LegacyTileCache::setContentReplacementImage):
(WebCore::LegacyTileCache::contentReplacementImage):
(WebCore::LegacyTileCache::tileCreationTimerFired):
(WebCore::LegacyTileCache::setNeedsDisplayInRect):
(WebCore::LegacyTileCache::updateTilingMode):
(WebCore::LegacyTileCache::setTilingMode):
(WebCore::LegacyTileCache::doPendingRepaints):
(WebCore::LegacyTileCache::flushSavedDisplayRects):
(WebCore::LegacyTileCache::prepareToDraw):

  • platform/ios/LegacyTileLayerPool.h:
  • platform/ios/LegacyTileLayerPool.mm:

(WebCore::LegacyTileLayerPool::addLayer):
(WebCore::LegacyTileLayerPool::takeLayerWithSize):
(WebCore::LegacyTileLayerPool::setCapacity):
(WebCore::LegacyTileLayerPool::prune):
(WebCore::LegacyTileLayerPool::drain):

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownloadManager::add):
(WebCore::CurlDownloadManager::remove):
(WebCore::CurlDownloadManager::getActiveDownloadCount):
(WebCore::CurlDownloadManager::getPendingDownloadCount):
(WebCore::CurlDownloadManager::stopThreadIfIdle):
(WebCore::CurlDownloadManager::updateHandleList):
(WebCore::CurlDownload::~CurlDownload):
(WebCore::CurlDownload::init):
(WebCore::CurlDownload::getTempPath):
(WebCore::CurlDownload::getUrl):
(WebCore::CurlDownload::getResponse):
(WebCore::CurlDownload::closeFile):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData):
(WebCore::CurlDownload::didFail):

  • platform/network/curl/CurlDownload.h:
  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::cookieJarPath):
(WebCore::sharedResourceMutex):
(WebCore::curl_lock_callback):
(WebCore::curl_unlock_callback):

  • platform/network/ios/QuickLook.mm:

(WebCore::QLDirectoryAttributes):
(qlPreviewConverterDictionaryMutex):
(WebCore::addQLPreviewConverterWithFileForURL):
(WebCore::qlPreviewConverterUTIForURL):
(WebCore::removeQLPreviewConverterForURL):
(WebCore::safeQLURLForDocumentURLAndResourceURL):

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::interrupt):
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::setMaximumSize):
(WebCore::SQLiteDatabase::pageSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::setAuthorizer):

  • platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::databaseMutex):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::step):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

  • workers/WorkerThread.h:

Source/WebKit:

  • Storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::syncTimerFired):
(WebCore::StorageAreaSync::markImported):
(WebCore::StorageAreaSync::blockUntilImportComplete):
(WebCore::StorageAreaSync::performSync):

  • Storage/StorageAreaSync.h:
  • Storage/StorageTracker.cpp:

(WebCore::StorageTracker::setDatabaseDirectoryPath):
(WebCore::StorageTracker::finishedImportingOriginIdentifiers):
(WebCore::StorageTracker::syncImportOriginIdentifiers):
(WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::syncSetOriginDetails):
(WebCore::StorageTracker::origins):
(WebCore::StorageTracker::deleteAllOrigins):
(WebCore::StorageTracker::syncDeleteAllOrigins):
(WebCore::StorageTracker::deleteOrigin):
(WebCore::StorageTracker::syncDeleteOrigin):
(WebCore::StorageTracker::canDeleteOrigin):
(WebCore::StorageTracker::cancelDeletingOrigin):
(WebCore::StorageTracker::diskUsageForOrigin):

  • Storage/StorageTracker.h:

Source/WebKit/ios:

  • WebCoreSupport/WebFixedPositionContent.mm:

(WebFixedPositionContentDataLock):
(-[WebFixedPositionContent scrollOrZoomChanged:]):
(-[WebFixedPositionContent overflowScrollPositionForLayer:changedTo:]):
(-[WebFixedPositionContent setViewportConstrainedLayers:stickyContainerMap:]):
(-[WebFixedPositionContent hasFixedOrStickyPositionLayers]):
(-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]):

Source/WebKit/mac:

  • Storage/WebDatabaseManager.mm:

(transactionBackgroundTaskIdentifierLock):
(+[WebDatabaseManager startBackgroundTask]):
(+[WebDatabaseManager endBackgroundTask]):

  • WebView/WebView.mm:

(-[WebView _synchronizeCustomFixedPositionLayoutRect]):
(-[WebView _setCustomFixedPositionLayoutRectInWebThread:synchronize:]):
(-[WebView _setCustomFixedPositionLayoutRect:]):
(-[WebView _fetchCustomFixedPositionLayoutRect:]):

  • WebView/WebViewData.h:

Source/WebKit/win:

  • Plugins/PluginMainThreadScheduler.cpp:

(WebCore::PluginMainThreadScheduler::scheduleCall):
(WebCore::PluginMainThreadScheduler::registerPlugin):
(WebCore::PluginMainThreadScheduler::unregisterPlugin):
(WebCore::PluginMainThreadScheduler::dispatchCallsForPlugin):

  • Plugins/PluginMainThreadScheduler.h:
  • WebIconDatabase.cpp:

(WebIconDatabase::didRemoveAllIcons):
(WebIconDatabase::didImportIconURLForPageURL):
(WebIconDatabase::deliverNotifications):

  • WebLocalizableStrings.cpp:

(mainBundleLocStrings):
(frameworkLocStringsMutex):
(findCachedString):
(cacheString):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::shutdown):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • Platform/IPC/Connection.cpp:

(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingSyncReply):
(IPC::Connection::connectionDidClose):

  • Platform/IPC/Connection.h:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::appendUpdate):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::createCompositingThread):
(WebKit::ThreadedCompositor::runCompositingThread):
(WebKit::ThreadedCompositor::terminateCompositingThread):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:

(WebKit::CustomProtocolManager::addCustomProtocol):
(WebKit::CustomProtocolManager::removeCustomProtocol):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::protocolForID):

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/linux/SeccompFilters/SeccompBroker.cpp:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
(WebKit::PluginProcessConnectionManager::removePluginProcessConnection):
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::addScrollingTreeForPage):
(WebKit::EventDispatcher::removeScrollingTreeForPage):
(WebKit::EventDispatcher::wheelEvent):

  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(webkitSoupRequestInputStreamReadAsync):
(webkitSoupRequestInputStreamAddData):

Source/WTF:

  • wtf/Atomics.cpp:

(WTF::getSwapLock):
(WTF::atomicStep):

  • wtf/MessageQueue.h:

(WTF::MessageQueue::infiniteTime):
(WTF::MessageQueue<DataType>::append):
(WTF::MessageQueue<DataType>::appendAndKill):
(WTF::MessageQueue<DataType>::appendAndCheckEmpty):
(WTF::MessageQueue<DataType>::prepend):
(WTF::MessageQueue<DataType>::removeIf):
(WTF::MessageQueue<DataType>::isEmpty):
(WTF::MessageQueue<DataType>::kill):
(WTF::MessageQueue<DataType>::killed):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ThreadPrivate::execute):
(WTF::ParallelEnvironment::ThreadPrivate::waitForFinish):
(WTF::ParallelEnvironment::ThreadPrivate::workerThread):

  • wtf/ParallelJobsGeneric.h:
  • wtf/RunLoop.cpp:

(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h:
  • wtf/Threading.cpp:

(WTF::threadEntryPoint):
(WTF::createThread):

  • wtf/ThreadingPrimitives.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::threadMapMutex):
(WTF::initializeThreading):
(WTF::identifierByPthreadHandle):
(WTF::establishIdentifierForPthreadHandle):
(WTF::changeThreadPriority):
(WTF::waitForThreadCompletion):
(WTF::detachThread):
(WTF::threadDidExit):
(WTF::currentThread):
(WTF::DeprecatedMutex::DeprecatedMutex):
(WTF::DeprecatedMutex::~DeprecatedMutex):
(WTF::DeprecatedMutex::lock):
(WTF::DeprecatedMutex::tryLock):
(WTF::DeprecatedMutex::unlock):
(WTF::ThreadCondition::~ThreadCondition):
(WTF::ThreadCondition::wait):
(WTF::ThreadCondition::timedWait):
(WTF::Mutex::Mutex): Deleted.
(WTF::Mutex::~Mutex): Deleted.
(WTF::Mutex::lock): Deleted.
(WTF::Mutex::tryLock): Deleted.
(WTF::Mutex::unlock): Deleted.

  • wtf/ThreadingWin.cpp:

(WTF::initializeCurrentThreadInternal):
(WTF::threadMapMutex):
(WTF::initializeThreading):
(WTF::storeThreadHandleByIdentifier):
(WTF::threadHandleForIdentifier):
(WTF::clearThreadHandleForIdentifier):
(WTF::currentThread):
(WTF::DeprecatedMutex::DeprecatedMutex):
(WTF::DeprecatedMutex::~DeprecatedMutex):
(WTF::DeprecatedMutex::lock):
(WTF::DeprecatedMutex::tryLock):
(WTF::DeprecatedMutex::unlock):
(WTF::ThreadCondition::~ThreadCondition):
(WTF::ThreadCondition::wait):
(WTF::ThreadCondition::timedWait):
(WTF::Mutex::Mutex): Deleted.
(WTF::Mutex::~Mutex): Deleted.
(WTF::Mutex::lock): Deleted.
(WTF::Mutex::tryLock): Deleted.
(WTF::Mutex::unlock): Deleted.

  • wtf/WorkQueue.h:
  • wtf/dtoa.cpp:
  • wtf/dtoa.h:
  • wtf/efl/DispatchQueueEfl.cpp:

(DispatchQueue::dispatch):
(DispatchQueue::performWork):
(DispatchQueue::performTimerWork):
(DispatchQueue::insertTimerWorkItem):
(DispatchQueue::wakeUpThread):
(DispatchQueue::getNextTimeOut):

  • wtf/efl/DispatchQueueEfl.h:
  • wtf/efl/RunLoopEfl.cpp:

(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):

  • wtf/threads/BinarySemaphore.cpp:

(WTF::BinarySemaphore::signal):
(WTF::BinarySemaphore::wait):

  • wtf/threads/BinarySemaphore.h:
  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::handleCallback):
(WTF::WorkQueue::platformInvalidate):
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::timerCallback):
(WTF::WorkQueue::dispatchAfter):

Tools:

  • DumpRenderTree/JavaScriptThreading.cpp:

(javaScriptThreadsMutex):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):

  • TestWebKitAPI/Tests/WTF/WorkQueue.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:

(TestWebKitAPI::TEST):

11:40 AM Changeset in webkit [187971] by mdaiter@apple.com
  • 3 edits in trunk/Source/WebCore

Adding in MediaPrivateMediaStreamEngine to default compile
​https://bugs.webkit.org/show_bug.cgi?id=146790
<rdar://problem/21747289>

Reviewed by Eric Carlson.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/MediaStreamPrivate.h:

(WebCore::MediaStreamPrivate::MediaStreamPrivate):

11:35 AM Changeset in webkit [187970] by mdaiter@apple.com
  • 3 edits in trunk/Source/WebCore

Remove m_synchronizer from MediaPlayerPrivateMediaStream
​https://bugs.webkit.org/show_bug.cgi?id=147637

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::playInternal): Deleted.

11:29 AM Changeset in webkit [187969] by saambarati1@gmail.com
  • 34 edits
    4 deletes in trunk/Source/JavaScriptCore

Replace JSFunctionNameScope with JSLexicalEnvironment for the function name scope.
​https://bugs.webkit.org/show_bug.cgi?id=147657

Reviewed by Mark Lam.

This kills the last of the name scope objects. Function name scopes are
now built on top of the scoping mechanisms introduced with ES6 block scoping.
A name scope is now just a JSLexicalEnvironment. We treat assignments to the
function name scoped variable carefully depending on if the function is in
strict mode. If we're in strict mode, then we treat the variable exactly
like a "const" variable. If we're not in strict mode, we can't treat
this variable like like ES6 "const" because that would cause the bytecode
generator to throw an exception when it shouldn't.

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::resolveType):
(JSC::BytecodeGenerator::emitThrowTypeError):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):
(JSC::BytecodeGenerator::pushScopedControlFlowContext):
(JSC::BytecodeGenerator::emitPushCatchScope):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:
  • debugger/DebuggerScope.cpp:
  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_string):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_push_name_scope): Deleted.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emitSlow_op_to_string):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_push_name_scope): Deleted.

  • jit/JITOperations.cpp:

(JSC::pushNameScope): Deleted.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • parser/Nodes.cpp:
  • runtime/CommonSlowPaths.cpp:
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

  • runtime/JSFunctionNameScope.cpp: Removed.
  • runtime/JSFunctionNameScope.h: Removed.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::withScopeStructure):
(JSC::JSGlobalObject::strictEvalActivationStructure):
(JSC::JSGlobalObject::activationStructure):
(JSC::JSGlobalObject::directArgumentsStructure):
(JSC::JSGlobalObject::scopedArgumentsStructure):
(JSC::JSGlobalObject::outOfBandArgumentsStructure):
(JSC::JSGlobalObject::functionNameScopeStructure): Deleted.

  • runtime/JSNameScope.cpp: Removed.
  • runtime/JSNameScope.h: Removed.
  • runtime/JSObject.cpp:

(JSC::JSObject::toThis):
(JSC::JSObject::seal):
(JSC::JSObject::isFunctionNameScopeObject): Deleted.

  • runtime/JSObject.h:
  • runtime/JSScope.cpp:

(JSC::JSScope::isCatchScope):
(JSC::JSScope::isFunctionNameScopeObject):
(JSC::resolveModeName):

  • runtime/JSScope.h:
  • runtime/JSSymbolTableObject.cpp:
  • runtime/SymbolTable.h:
  • runtime/VM.cpp:
11:24 AM Changeset in webkit [187968] by Brian Burg
  • 13 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert miscellaneous view widgets to use ES6 classes
​https://bugs.webkit.org/show_bug.cgi?id=147658

Reviewed by Joseph Pecoraro.

Along the way, inline a few style class names.

Elided mechanical changes from the Changelog.

  • UserInterface/Base/Test.js:
  • UserInterface/Views/CSSStyleDeclarationSection.js:
  • UserInterface/Views/ConsolePrompt.js:
  • UserInterface/Views/ContentBrowser.js:
  • UserInterface/Views/ContentViewContainer.js:
  • UserInterface/Views/DOMTreeDataGridNode.js:
  • UserInterface/Views/IndeterminateProgressSpinner.js:
  • UserInterface/Views/NavigationBar.js:
  • UserInterface/Views/ProbeSetDataGridNode.js:
  • UserInterface/Views/QuickConsoleNavigationBar.js:
  • UserInterface/Views/Toolbar.js:
11:12 AM Changeset in webkit [187967] by Brian Burg
  • 35 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert remaining ContentViews to use ES6 classes
​https://bugs.webkit.org/show_bug.cgi?id=147534

Reviewed by Joseph Pecoraro.

Along the way, inline a few style class names.

Elided mechanical changes from the Changelog.

  • UserInterface/Views/ApplicationCacheFrameContentView.js:
  • UserInterface/Views/ClusterContentView.js:
  • UserInterface/Views/ConsoleTabContentView.js:
  • UserInterface/Views/ContentBrowserTabContentView.js: Rearrange initialization

of the tab's content browser to comply with TDZ rules for using this.

  • UserInterface/Views/ContentFlowDOMTreeContentView.js:
  • UserInterface/Views/ContentView.js:
  • UserInterface/Views/ContentViewContainer.js:
  • UserInterface/Views/CookieStorageContentView.js:
  • UserInterface/Views/DOMStorageContentView.js:
  • UserInterface/Views/DOMTreeContentView.js:
  • UserInterface/Views/DatabaseContentView.js:
  • UserInterface/Views/DatabaseTableContentView.js:
  • UserInterface/Views/DebuggerTabContentView.js:
  • UserInterface/Views/ElementsTabContentView.js:
  • UserInterface/Views/FontResourceContentView.js:
  • UserInterface/Views/FrameDOMTreeContentView.js:
  • UserInterface/Views/GenericResourceContentView.js:
  • UserInterface/Views/ImageResourceContentView.js:
  • UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
  • UserInterface/Views/LogContentView.js:
  • UserInterface/Views/NetworkGridContentView.js:
  • UserInterface/Views/NetworkTabContentView.js:
  • UserInterface/Views/NewTabContentView.js:
  • UserInterface/Views/ResourceClusterContentView.js:
  • UserInterface/Views/ResourceContentView.js:
  • UserInterface/Views/ResourcesTabContentView.js:
  • UserInterface/Views/ScriptContentView.js:
  • UserInterface/Views/SearchTabContentView.js:
  • UserInterface/Views/SettingsTabContentView.js:
  • UserInterface/Views/StorageTabContentView.js:
  • UserInterface/Views/TabContentView.js:
  • UserInterface/Views/TextContentView.js:
  • UserInterface/Views/TextResourceContentView.js:
  • UserInterface/Views/TimelineRecordingContentView.js:
11:09 AM Changeset in webkit [187966] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

Mark failing scrolling test.

  • platform/mac/TestExpectations:
10:30 AM Changeset in webkit [187965] by timothy@apple.com
  • 2 edits in trunk/Tools

Update the WebKit nightly icon
​https://bugs.webkit.org/show_bug.cgi?id=147684

Reviewed by Sam Weinig.

  • WebKitLauncher/webkit.icns: Replaced.
9:16 AM Changeset in webkit [187964] by Brent Fulgham
  • 3 edits in trunk/LayoutTests

Unreviewed test gardening.

Skip new latched scrolling test on WK1 due to timeout. Check in some minor clean-ups in
the test based on feedback from Antti and others:

  • platform/mac/TestExpectations:
  • platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html:
9:15 AM Changeset in webkit [187963] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

Build fix after 187961

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext):

9:05 AM Changeset in webkit [187962] by dbates@webkit.org
  • 15 edits
    1 add in trunk

REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
​https://bugs.webkit.org/show_bug.cgi?id=147678
<rdar://problem/21827815>

Reviewed by Brady Eidson.

Source/WebCore:

Fixes an issue where a non-user-initiated navigation of the main frame to a phone link (tel URL)
may be ignored. The navigation is ignored if the page was reloaded as a result of a web content
process crash, its lifetime exceeded the back-forward cache expiration interval, or a person
quits and opens Safari again, among other scenarios.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::setShouldOpenExternalURLsPolicy): Added.
(WebCore::HistoryItem::shouldOpenExternalURLsPolicy): Added.

  • history/HistoryItem.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadDifferentDocumentItem): Apply the "should open external URLs" policy
from the history item, if applicable. Also, be more explicit when instantiating a NavigationAction
so as to help make it straightforward to reduce the number of NavigationAction constructors we have
in the future.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveDocumentState): Save the "should open external URLs" policy to
the history item.
(WebCore::HistoryController::restoreDocumentState): Apply the "should open external URLs" policy
from the history item to the document loader.
(WebCore::HistoryController::initializeItem): Update the "should open external URLs" policy of
the history item to reflect the policy of the document loader associated with the current frame.

Source/WebKit2:

Teach WebKit to save and restore the "should open external URLs" policy.

  • Shared/SessionState.cpp:

(WebKit::isValidEnum): Added.
(WebKit::PageState::encode): Modified to encode the "should open external URLs" policy.
(WebKit::PageState::decode): Modified to decode the "should open external URLs" policy.

  • Shared/SessionState.h: Added ShouldOpenExternalURLsPolicy to PageState (defaults to WebCore::ShouldOpenExternalURLsPolicy::ShouldNotAllow).
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _killWebContentProcessAndResetState]): Added; used in the unit test TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Declare -[WKWebView _killWebContentProcessAndResetState].
  • UIProcess/mac/LegacySessionStateCoding.cpp: Defined constant sessionHistoryEntryShouldOpenExternalURLsPolicyKey.

(WebKit::encodeSessionHistory): Modified to encode the "should open external URLs" policy.
(WebKit::decodeSessionHistoryEntry): Modified to decode the "should open external URLs" policy.

  • WebProcess/WebCoreSupport/SessionStateConversion.cpp:

(WebKit::toPageState): Copy "should open external URLs" policy from specified history item.
(WebKit::toHistoryItem): Apply "should open external URLs" policy from PageState to HistoryItem.

Tools:

Add a test to ensure that we restore the "should open external URLs" policy on
page reload after the web content process crashes.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:

(TEST):

9:03 AM Changeset in webkit [187961] by Wenson Hsieh
  • 3 edits in trunk/Source/WebCore

Checkboxes and radio buttons should scale when zooming or pinching to zoom
​https://bugs.webkit.org/show_bug.cgi?id=147405

Reviewed by Dean Jackson.

Refactors paintButton and paintToggleButton to use a temporary buffer when rendering
if the controls are zoomed. This affects checkboxes, radio buttons, and normal (push)
buttons.

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm:

(WebCore::paintToggleButton): Refactored to use drawCellOrFocusRingWithViewIntoContext.
(WebCore::paintButton): Refactored to use drawCellOrFocusRingWithViewIntoContext.
(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext): Draws a given button cell

and/or its focus ring into the given context, optionally using an offscreen buffer.
This is a static function in ThemeMac so it can be accessed later on by
RenderThemeMac when painting search fields that scale with zoom.

(WebCore::ThemeMac::paint):
(WebCore::buttonFocusRectOutlineWidth): Deleted. Made this value into a const float.

7:07 AM Changeset in webkit [187960] by Devin Rousso
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Allow users to duplicate rules in the Rules sidebar panel
​https://bugs.webkit.org/show_bug.cgi?id=147361

Reviewed by Timothy Hatcher.

Adds context menu option to non-inherited rules that, when clicked, creates
a new rule with the same selector and no properties, and then focuses it.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.addRuleWithSelector.addedRule):
(WebInspector.DOMNodeStyles.prototype.addRuleWithSelector):

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.get _currentSelectorText):
(WebInspector.CSSStyleDeclarationSection.prototype._handleContextMenuEvent):

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionFocusNextNewInspectorRule):

7:04 AM Changeset in webkit [187959] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: Improve Support for PropertyName Iterator (Reflect.enumerate) in Inspector
​https://bugs.webkit.org/show_bug.cgi?id=147679

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-08-05
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Improve native iterator support for the PropertyName Iterator by
allowing inspection of the internal object within the iterator
and peeking of the next upcoming values of the iterator.

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::JSInjectedScriptHost::iteratorEntries):

  • runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::iteratedValue):

LayoutTests:

  • inspector/model/remote-object-expected.txt:
  • inspector/model/remote-object.html:
3:27 AM WebKitGTK/2.8.x edited by Carlos Garcia Campos
(diff)
3:27 AM Changeset in webkit [187958] by Antti Koivisto
  • 3 edits in trunk/Source/WebKit2

Network cache fetches should have timeout
​https://bugs.webkit.org/show_bug.cgi?id=147631

Reviewed by Andreas Kling.

System might be under heavy I/O pressure. If it takes long time to get data from disk we should load from network instead.

This patch introduces 1.5s timeout for disk reads. If the last dispatched cache read takes longer than that we cancel all
active and pending reads and just load those resources from network.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
(WebKit::NetworkCache::Storage::ReadOperation::cancel):
(WebKit::NetworkCache::Storage::ReadOperation::finish):

Factor to functions.

(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::Storage::finishReadOperation):
(WebKit::NetworkCache::Storage::cancelAllReadOperations):
(WebKit::NetworkCache::Storage::dispatchPendingReadOperations):
(WebKit::NetworkCache::Storage::dispatchPendingWriteOperations):

Also make dispatch functions transfer the operation ownership.

(WebKit::NetworkCache::shouldStoreBodyAsBlob):
(WebKit::NetworkCache::Storage::dispatchWriteOperation):

  • NetworkProcess/cache/NetworkCacheStorage.h:
3:25 AM Changeset in webkit [187957] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8

Merge r187854 - [GTK] Accelerated 2D Canvas enabled when cairo-gl is not available
​https://bugs.webkit.org/show_bug.cgi?id=147625

Reviewed by Martin Robinson.

Do not set the CAIRO_<COMPONENT>_* CMake variables for cairo-gl
components unless they were actually found, not to accidentally
enable Accelerated 2D canvas, which would cause the build to fail.

  • Source/cmake/FindCairoGL.cmake: Set this variables only when

pkg_check_modules() had actually found the relevant component.

3:21 AM Changeset in webkit [187956] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8

Merge r184063 - CMake defines CAIROGL_FOUND, not CAIRO_GL_FOUND
​https://bugs.webkit.org/show_bug.cgi?id=144846

Patch by Philip Chimento <​philip.chimento@gmail.com> on 2015-05-10
Reviewed by Martin Robinson.

  • Source/cmake/FindCairoGL.cmake: Use CAIROGL_* instead of

CAIRO_GL_* throughout, because find_package will define
CAIROGL_FOUND.

  • Source/cmake/OptionsGTK.cmake: Ditto.
3:10 AM Changeset in webkit [187955] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187740 - Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).
<rdar://problem/22098457> and ​https://bugs.webkit.org/show_bug.cgi?id=147560

Reviewed by Alexey Proskuryakov.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest): Only grab identifierForLoadWithoutResourceLoader() if there's no ResourceLoader.

3:09 AM Changeset in webkit [187954] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.8

Merge r187733 - Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
​https://bugs.webkit.org/show_bug.cgi?id=118455

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-08-02
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

LivenessAnalysisPhase lights up like a christmas tree in profiles.

This patch cuts its cost by 4.
About half of the gains come from removing many rehash() when copying
the HashSet.
The last quarter is achieved by having a special add() function for initializing
a HashSet.

This makes benchmarks progress by 1-2% here and there. Nothing massive.

  • dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::LivenessAnalysisPhase::process):
The m_live HashSet is only useful per block. When we are done with it,
we can transfer it to liveAtHead to avoid a copy.

Source/WTF:

Previously, when copying a HashTable, we would start from scratch
with an empty table and insert elements one by one, growing-rehashing
the table as needed.

With this patch, we have 2 improvements to remove most of the cost.

First, we compute a good size from the start. This removes all the
reallocations and rehashs.
This is where the biggest gain comes from.

The second part is a simpler version of add() when we know that
we cannot find a bucket with the same key and there cannot
be any deleted bucket.
This removes most branches from the hot loop, cutting another 25%
of the time.

  • wtf/HashTable.h:

(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::HashTable):

Tools:

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

2:37 AM Changeset in webkit [187953] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187640 - [GTK] Have DataObjectGtk::unknownTypes() return a reference to the HashMap object
​https://bugs.webkit.org/show_bug.cgi?id=147401

Reviewed by Carlos Garcia Campos.

Don't copy the DataObjectGtk::m_unknownTypes HashMap on every retrieval through
DataObjectGtk::unknownTypes(). The range-based for-loops that iterate over the
map in PasteboardGtk.cpp and PasteboardHelper.cpp are also cleaned up.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::unknownTypes):

  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writePasteboard):
(WebCore::Pasteboard::types):

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

2:04 AM Changeset in webkit [187952] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187586 - [GTK] Crashes when SoupSession is destroyed in exit handler
​https://bugs.webkit.org/show_bug.cgi?id=145347

Reviewed by Carlos Garcia Campos.

Leak the default SoupSession with NeverDestroyed to avoid races at program exit.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::defaultSession):

  • platform/network/soup/SoupNetworkSession.h:
1:58 AM Changeset in webkit [187951] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187557 - Crash in WebCore::DocumentLoader::stopLoadingForPolicyChange.
<rdar://problem/21412186> and ​https://bugs.webkit.org/show_bug.cgi?id=147418

Reviewed by Chris Dumez.

No new tests (No known reproducibility)

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived): When setting to m_waitingForContentPolicy true, make sure we have a FrameLoader.
(WebCore::DocumentLoader::detachFromFrame): Always explicitly call cancelPolicyCheckIfNeeded().
(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded): Cancel the policy check if there is one.
(WebCore::DocumentLoader::cancelMainResourceLoad): Use cancelPolicyCheckIfNeeded().

  • loader/DocumentLoader.h:

RELEASE_ASSERT followup to: Crash in WebCore::DocumentLoader::stopLoadingForPolicyChange.
​https://bugs.webkit.org/show_bug.cgi?id=147418

Reviewed by Chris Dumez.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded): RELEASE_ASSERT we have a FrameLoader here.

We want to know if we ever get here without one.

Review feedback followup to: Crash in WebCore::DocumentLoader::stopLoadingForPolicyChange.
​https://bugs.webkit.org/show_bug.cgi?id=147418

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded):

1:51 AM Changeset in webkit [187950] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r187535 - Animations sometimes fail to start
​https://bugs.webkit.org/show_bug.cgi?id=147394
rdar://problem/21852603

Reviewed by Dean Jackson.
Source/WebCore:

When an accelerated animation or transition was started at the same time as
a non-accelerated one, and then the node for the former was removed, we could
never kick off the non-accelerated animation.

AnimationControllerPrivate has logic to synchronize the two types of animation
when they start in the same animation update, which involves setting the
m_waitingForAsyncStartNotification flag, and waiting for a notifyAnimationStarted()
to come in from the graphics system.

However, it failed to handle the case where the accelerated animation was removed
before the callback was received, which left the m_waitingForAsyncStartNotification flag
set to true, preventing the non-accelerated animation from running.

Test: animations/remove-syncing-animation.html

  • page/animation/AnimationBase.h:

(WebCore::AnimationBase::isAccelerated): Make this public.

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::clear): Add logging.
(WebCore::AnimationControllerPrivate::receivedStartTimeResponse): Add logging.
(WebCore::AnimationControllerPrivate::animationWillBeRemoved): Add logging.
After removing animations from the maps, check to see if we expect any of the
remaining animations are waiting for a notifyAnimationStarted(). If not, clear
the m_waitingForAsyncStartNotification flag.
(WebCore::AnimationController::notifyAnimationStarted): Log the renderer.
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate): Remove unneeded
initializations of HashMaps.

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions): Log renderers.
(WebCore::CompositeAnimation::updateKeyframeAnimations): Ditto.

LayoutTests:

Test that starts an accelerated and non-accelerated animation, then removes
the node for the accelerated one.

  • animations/remove-syncing-animation-expected.txt: Added.
  • animations/remove-syncing-animation.html: Added.
1:34 AM Changeset in webkit [187949] by Carlos Garcia Campos
  • 7 edits
    5 adds in releases/WebKitGTK/webkit-2.8

Merge r187527 - [Freetype] Always allow font matching for strong aliases
​https://bugs.webkit.org/show_bug.cgi?id=147057

Reviewed by Martin Robinson.

Source/WebCore:

Tests: platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html

platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html

Treat fonts that are strongly-aliased to each other as if they were identical for the
purposes of CSS font fallback. This improves the layout of many web pages by allowing
fontconfig to replace fonts with metric-compatible equivalents (e.g. Arial -> Liberation
Sans) instead of rejecting the metric-compatible font as unsuitable.

  • platform/graphics/cairo/RefPtrCairo.cpp:

(WTF::refIfNotNull):
(WTF::derefIfNotNull):

  • platform/graphics/cairo/RefPtrCairo.h:
  • platform/graphics/freetype/FcUniquePtr.h: Added.

(WebCore::FcPtrDeleter<FcFontSet>::operator()):
(WebCore::FcPtrDeleter<FcLangSet>::operator()):
(WebCore::FcPtrDeleter<FcObjectSet>::operator()):

  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::strengthOfFirstAlias):
(WebCore::strongAliasesForFamily):
(WebCore::areStronglyAliased):
(WebCore::FontCache::createFontPlatformData):

Tools:

Create family aliases needed for the new layout tests.

  • WebKitTestRunner/gtk/fonts/fonts.conf:

LayoutTests:

  • platform/gtk/fonts/font-family-fallback-ignores-weak-aliases-expected.html: Added.
  • platform/gtk/fonts/font-family-fallback-ignores-weak-aliases.html: Added.
  • platform/gtk/fonts/font-family-fallback-respects-strong-aliases-expected.html: Added.
  • platform/gtk/fonts/font-family-fallback-respects-strong-aliases.html: Added.
1:10 AM Changeset in webkit [187948] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r187504 - Crash happens when calling removeEventListener for an SVG element which has an instance inside a <defs> element of shadow tree
​https://bugs.webkit.org/show_bug.cgi?id=147290

Reviewed by Daniel Bates.

Source/WebCore:

When the shadow tree is built for a <use> element, all the SVG elements
are allowed to be cloned in the shadow tree but later some of the elements
are disallowed and removed. Make sure, when disallowing an element in the
shadow tree, to reset the correspondingElement relationship between all
the disallowed descendant SVG elements and all their original elements.

Test: svg/custom/remove-event-listener-shadow-disallowed-element.svg

*svg/SVGElement.cpp:
(WebCore::SVGElement::setCorrespondingElement)

  • svg/SVGUseElement.cpp:

(WebCore::removeDisallowedElementsFromSubtree):

LayoutTests:

Make sure we do not crash when when calling removeEventListener() for an
element which is cloned under a disallowed parent inside the shadow tree
of another <use> element.

  • svg/custom/remove-event-listener-shadow-disallowed-element-expected.txt: Added.
  • svg/custom/remove-event-listener-shadow-disallowed-element.svg: Added.
1:08 AM Changeset in webkit [187947] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r187502 - ASSERTION FAILED: !currBox->needsLayout() loading bing maps (and apple.com/music and nytimes)
​https://bugs.webkit.org/show_bug.cgi?id=93891

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/dynamic.

Change tracking of positioned objects to always insert objects that need a layout in the
end of the ListHashMap for RenderViews. This ensures that dependencies between nested
positioned objects that both need a layout by the RenderView are resolved in the correct order.

Don't cache the end object when walking the ListHashMap to do layouts of positioned objects,
since that list is getting updated dynamically as earlier objects can mark and insert new
objects into the list during their layouts.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutPositionedObject):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):

  • rendering/RenderBlock.h:

LayoutTests:

  • fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash-expected.txt: Added.
  • fast/dynamic/position-fixed-to-absolute-with-positioned-child-crash.html: Added.
12:51 AM Changeset in webkit [187946] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r187485 - [GTK] Use fastMalloc instead of g_slice
​https://bugs.webkit.org/show_bug.cgi?id=147357

Reviewed by Sergio Villar Senin.

The use of g_slice is no longer encouraged by glib developers.

Source/WebCore:

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::mapGstBuffer):
(WebCore::unmapGstBuffer):

Source/WebKit2:

  • UIProcess/API/gtk/WebKitCredential.cpp:

(webkitCredentialCreate):
(webkit_credential_free):

  • UIProcess/API/gtk/WebKitJavascriptResult.cpp:

(webkitJavascriptResultCreate):
(webkit_javascript_result_unref):

  • UIProcess/API/gtk/WebKitMimeInfo.cpp:

(webkitMimeInfoCreate):
(webkit_mime_info_unref):

  • UIProcess/API/gtk/WebKitNavigationAction.cpp:

(webkitNavigationActionCreate):
(webkit_navigation_action_copy):
(webkit_navigation_action_free):

  • UIProcess/API/gtk/WebKitPrivate.h:
  • UIProcess/API/gtk/WebKitScriptDialog.cpp:

(webkitScriptDialogCopy):
(webkitScriptDialogFree):

  • UIProcess/API/gtk/WebKitUserContent.cpp:

(webkit_user_style_sheet_unref):
(webkit_user_style_sheet_new):
(webkit_user_script_unref):
(webkit_user_script_new):

12:33 AM Changeset in webkit [187945] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r187471 - First in-window viewStateChange synchronously blocks despite not previously being in-window
​https://bugs.webkit.org/show_bug.cgi?id=147344
<rdar://problem/22021772>

Reviewed by Simon Fraser.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateViewState):
(WebKit::WebPageProxy::dispatchViewStateChange):
The whole point of m_viewWasEverInWindow was so that we would not
synchronously wait when a view was added to a window for the first time,
only all subsequent times.

However, since m_viewWasEverInWindow was being set *before* being
checked in dispatchViewStateChange, we were always blocking. This is
a huge waste of main-thread time, because there's no reason to wait
for the first paint if you've never seen the view before (and shouldn't
expect it to have content).

Instead, set the flag after dispatching a view state change, so it becomes
"have we ever sent a view state with IsInWindow set" instead.

12:28 AM Changeset in webkit [187944] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187466 - Crash in WebCore::DocumentLoader::willSendRequest() with ContentFilter and AppCache.
<rdar://problem/21960398> and ​https://bugs.webkit.org/show_bug.cgi?id=147339

Reviewed by Alexey Proskuryakov.

No new tests (Not yet proven to be possible to test this).

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest): Grab the identifier from the CachedResource directly, not from the null ResourceLoader.
(WebCore::DocumentLoader::continueAfterNavigationPolicy): Null check the ResourceLoader, as it can definitely be gone by this point.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::clearLoader): Save off the identifier for later use.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::identifierForLoadWithoutResourceLoader): Expose the identifier that the ResourceLoader had when it went away.

12:19 AM Changeset in webkit [187943] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1-branch/Source

Merge r187805. rdar://problem/21838271

12:19 AM Changeset in webkit [187942] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187807. rdar://problem/21838271

12:17 AM Changeset in webkit [187941] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r187432 - [GTK] Pass a GstInstallPluginsContext to gst_install_plugins_async
​https://bugs.webkit.org/show_bug.cgi?id=147103

Reviewed by Philippe Normand.

Source/WebCore:

  • platform/graphics/gstreamer/GUniquePtrGStreamer.h: Allow to use

GUniquePtr with GstInstallPluginsContext.

Source/WebKit2:

This allows PackageKit to properly position the window and make it
transient to the web view window.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setCursor): Disambiguate Cursor now that
we include gtkx.h.
(WebKit::PageClientImpl::createGstInstallPluginsContext): Create a
new GstInstallPluginsContext and set the web view window XID when
running on X11.

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/PageClient.h:
  • UIProcess/efl/WebViewEfl.h:
  • UIProcess/gstreamer/WebPageProxyGStreamer.cpp:

(WebKit::WebPageProxy::requestInstallMissingMediaPlugins): Use
PageClient::createGstInstallPluginsContext() to create a new
GstInstallPluginsContext and pass it to gst_install_plugins_async().

Aug 4, 2015:

11:04 PM Changeset in webkit [187940] by ap@apple.com
  • 3 edits
    1 copy in branches/safari-601.1-branch

Merge r187933.

2015-08-04 Alexey Proskuryakov <​ap@apple.com>

El Capitan test result gardening.

Update for a font change.

  • platform/mac-yosemite/fast/text/crash-complex-text-surrogate-expected.txt: Copied from LayoutTests/platform/mac/fast/text/crash-complex-text-surrogate-expected.txt.
  • platform/mac/fast/text/crash-complex-text-surrogate-expected.txt:
10:32 PM Changeset in webkit [187939] by achristensen@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Build fix after r187928.

  • CMakeLists.txt:

Typo. Set libGLESv2 compile definitions instead of libEGL, which are set separately.

10:27 PM Changeset in webkit [187938] by Simon Fraser
  • 1 edit
    8 moves
    1 add in trunk/LayoutTests

Put Yosemite mac editing results in the correct location.

  • platform/mac-yosemite/editing/mac/attributed-string/anchor-element-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/anchor-element-expected.txt.
  • platform/mac-yosemite/editing/mac/attributed-string/basic-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/basic-expected.txt.
  • platform/mac-yosemite/editing/mac/attributed-string/font-size-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/font-size-expected.txt.
  • platform/mac-yosemite/editing/mac/attributed-string/font-style-variant-effect-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/font-style-variant-effect-expected.txt.
  • platform/mac-yosemite/editing/mac/attributed-string/font-weight-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/font-weight-expected.txt.
  • platform/mac-yosemite/editing/mac/attributed-string/letter-spacing-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/letter-spacing-expected.txt.
  • platform/mac-yosemite/editing/mac/attributed-string/text-decorations-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/text-decorations-expected.txt.
  • platform/mac-yosemite/editing/mac/attributed-string/vertical-align-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/editing/mac/editing/attributed-string/vertical-align-expected.txt.
9:57 PM Changeset in webkit [187937] by Simon Fraser
  • 1 edit
    4 moves
    1 add in trunk/LayoutTests

Move some Windows results for Mac editing tests (confused? I am) to the right places.

  • platform/win/editing/mac/input/devanagari-ligature-expected.txt: Renamed from LayoutTests/platform/win/platform/mac/editing/input/devanagari-ligature-expected.txt.
  • platform/win/editing/mac/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Renamed from LayoutTests/platform/win/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt.
  • platform/win/editing/mac/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Renamed from LayoutTests/platform/win/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt.
  • platform/win/editing/mac/spelling/delete-autocorrected-word-2-expected.txt: Renamed from LayoutTests/platform/win/platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt.
9:32 PM Changeset in webkit [187936] by Simon Fraser
  • 1 edit
    20 moves
    8 adds in trunk/LayoutTests

Move Mavericks and Yosemite editing/mac results into the right place.

  • platform/mac-mavericks/editing/mac/attributed-string/anchor-element-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/anchor-element-expected.txt.
  • platform/mac-mavericks/editing/mac/attributed-string/basic-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/basic-expected.txt.
  • platform/mac-mavericks/editing/mac/attributed-string/font-size-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/font-size-expected.txt.
  • platform/mac-mavericks/editing/mac/attributed-string/font-style-variant-effect-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt.
  • platform/mac-mavericks/editing/mac/attributed-string/font-weight-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/font-weight-expected.txt.
  • platform/mac-mavericks/editing/mac/attributed-string/letter-spacing-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/letter-spacing-expected.txt.
  • platform/mac-mavericks/editing/mac/attributed-string/text-decorations-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/text-decorations-expected.txt.
  • platform/mac-mavericks/editing/mac/attributed-string/vertical-align-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/attributed-string/vertical-align-expected.txt.
  • platform/mac-mavericks/editing/mac/input/devanagari-ligature-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/input/devanagari-ligature-expected.txt.
  • platform/mac-mavericks/editing/mac/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt.
  • platform/mac-mavericks/editing/mac/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt.
  • platform/mac-mavericks/editing/mac/spelling/delete-autocorrected-word-2-expected.txt: Renamed from LayoutTests/platform/mac-mavericks/platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/anchor-element-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/anchor-element-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/basic-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/basic-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/font-size-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/font-size-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/font-style-variant-effect-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/font-weight-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/font-weight-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/letter-spacing-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/letter-spacing-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/text-decorations-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/text-decorations-expected.txt.
  • platform/mac-yosemite/editing/mac/editing/attributed-string/vertical-align-expected.txt: Renamed from LayoutTests/platform/mac-yosemite/platform/mac/editing/attributed-string/vertical-align-expected.txt.
8:38 PM Changeset in webkit [187935] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AX: tree item children returned from ranged getter are different from full array of children
​https://bugs.webkit.org/show_bug.cgi?id=147660

Source/WebCore:

Patch by Doug Russell <​d_russell@apple.com> on 2015-08-04
Reviewed by Chris Fleizach.

Add an isTreeItem() check in ranged element getter so that it matches the logic in
the getter for the full children array. This prevents returning a row as a child
when only the rows contents should be returned. This prevents navigation issues on
websites without aria outlines.

Test: accessibility/mac/aria-tree-item-children.html

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

LayoutTests:

Add an isTreeItem() check in ranged element getter so that it matches the logic in
the getter for the full children array. This prevents returning a row as a child
when only the rows contents should be returned. This prevents navigation issues on
websites without aria outlines.

Patch by Doug Russell <​d_russell@apple.com> on 2015-08-04
Reviewed by Chris Fleizach.

  • accessibility/mac/aria-tree-item-children-expected.txt: Added.
  • accessibility/mac/aria-tree-item-children.html: Added.
8:33 PM Changeset in webkit [187934] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Editing tests have been broken since r186694
​https://bugs.webkit.org/show_bug.cgi?id=146888

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-08-04
Reviewed by Brent Fulgham.

Tools:

Restored some codes for the context click on GTK+ and EFL port.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.

LayoutTests:

Unskip the failure tests related with r186694.

  • platform/efl/TestExpectations:
8:29 PM Changeset in webkit [187933] by ap@apple.com
  • 2 edits
    1 copy in trunk/LayoutTests

El Capitan test result gardening.

Update for a font change.

  • platform/mac-yosemite/fast/text/crash-complex-text-surrogate-expected.txt: Copied from LayoutTests/platform/mac/fast/text/crash-complex-text-surrogate-expected.txt.
  • platform/mac/fast/text/crash-complex-text-surrogate-expected.txt:
6:39 PM Changeset in webkit [187932] by Simon Fraser
  • 5 edits
    171 moves
    16 adds
    1 delete in trunk/LayoutTests

Move platform/mac/editing tests to editing/mac

  • TestExpectations:
  • editing/mac/attributed-string/anchor-element-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/anchor-element-expected.txt.
  • editing/mac/attributed-string/anchor-element.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/anchor-element.html.
  • editing/mac/attributed-string/basic-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/basic-expected.txt.
  • editing/mac/attributed-string/basic.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/basic.html.
  • editing/mac/attributed-string/font-size-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/font-size-expected.txt.
  • editing/mac/attributed-string/font-size.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/font-size.html.
  • editing/mac/attributed-string/font-style-variant-effect-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt.
  • editing/mac/attributed-string/font-style-variant-effect.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/font-style-variant-effect.html.
  • editing/mac/attributed-string/font-weight-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/font-weight-expected.txt.
  • editing/mac/attributed-string/font-weight.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/font-weight.html.
  • editing/mac/attributed-string/letter-spacing-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/letter-spacing-expected.txt.
  • editing/mac/attributed-string/letter-spacing.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/letter-spacing.html.
  • editing/mac/attributed-string/resources/dump-attributed-string.js: Renamed from LayoutTests/platform/mac/editing/attributed-string/resources/dump-attributed-string.js.

(.):

  • editing/mac/attributed-string/text-decorations-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/text-decorations-expected.txt.
  • editing/mac/attributed-string/text-decorations.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/text-decorations.html.
  • editing/mac/attributed-string/vertical-align-expected.txt: Renamed from LayoutTests/platform/mac/editing/attributed-string/vertical-align-expected.txt.
  • editing/mac/attributed-string/vertical-align.html: Renamed from LayoutTests/platform/mac/editing/attributed-string/vertical-align.html.
  • editing/mac/deleting/backward-delete-expected.txt: Renamed from LayoutTests/platform/mac/editing/deleting/backward-delete-expected.txt.
  • editing/mac/deleting/backward-delete.html: Renamed from LayoutTests/platform/mac/editing/deleting/backward-delete.html.
  • editing/mac/dictionary-lookup/dictionary-lookup-expected.txt: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-expected.txt.
  • editing/mac/dictionary-lookup/dictionary-lookup-input-expected.txt: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-input-expected.txt.
  • editing/mac/dictionary-lookup/dictionary-lookup-input.html: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-input.html.
  • editing/mac/dictionary-lookup/dictionary-lookup-inside-selection-expected.txt: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-inside-selection-expected.txt.
  • editing/mac/dictionary-lookup/dictionary-lookup-inside-selection.html: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-inside-selection.html.
  • editing/mac/dictionary-lookup/dictionary-lookup-outside-selection-expected.txt: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-outside-selection-expected.txt.
  • editing/mac/dictionary-lookup/dictionary-lookup-outside-selection.html: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-outside-selection.html.
  • editing/mac/dictionary-lookup/dictionary-lookup-rtl-expected.txt: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-rtl-expected.txt.
  • editing/mac/dictionary-lookup/dictionary-lookup-rtl.html: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup-rtl.html.
  • editing/mac/dictionary-lookup/dictionary-lookup.html: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/dictionary-lookup.html.
  • editing/mac/dictionary-lookup/resources/lookup-test.js: Renamed from LayoutTests/platform/mac/editing/dictionary-lookup/lookup-test.js.

(runTest):

  • editing/mac/input/5576619-expected.png: Renamed from LayoutTests/platform/mac/editing/input/5576619-expected.png.
  • editing/mac/input/5576619-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/5576619-expected.txt.
  • editing/mac/input/5576619.html: Renamed from LayoutTests/platform/mac/editing/input/5576619.html.
  • editing/mac/input/NSBackgroundColor-transparent-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/NSBackgroundColor-transparent-expected.txt.
  • editing/mac/input/NSBackgroundColor-transparent.html: Renamed from LayoutTests/platform/mac/editing/input/NSBackgroundColor-transparent.html.
  • editing/mac/input/bold-node-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/bold-node-expected.txt.
  • editing/mac/input/bold-node.html: Renamed from LayoutTests/platform/mac/editing/input/bold-node.html.
  • editing/mac/input/caret-primary-bidi-expected.txt: Renamed from LayoutTests/platform/mac/platform/mac/editing/input/caret-primary-bidi-expected.txt.
  • editing/mac/input/caret-primary-bidi.html: Renamed from LayoutTests/platform/mac/editing/input/caret-primary-bidi.html.
  • editing/mac/input/crash-for-empty-text-alternative-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/crash-for-empty-text-alternative-expected.txt.
  • editing/mac/input/crash-for-empty-text-alternative.html: Renamed from LayoutTests/platform/mac/editing/input/crash-for-empty-text-alternative.html.
  • editing/mac/input/devanagari-ligature-expected.png: Renamed from LayoutTests/platform/mac/editing/input/devanagari-ligature-expected.png.
  • editing/mac/input/devanagari-ligature-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/devanagari-ligature-expected.txt.
  • editing/mac/input/devanagari-ligature.html: Renamed from LayoutTests/platform/mac/editing/input/devanagari-ligature.html.
  • editing/mac/input/edit-dictated-text-with-alternative-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/edit-dictated-text-with-alternative-expected.txt.
  • editing/mac/input/edit-dictated-text-with-alternative.html: Renamed from LayoutTests/platform/mac/editing/input/edit-dictated-text-with-alternative.html.
  • editing/mac/input/firstrectforcharacterrange-caret-in-br-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-caret-in-br-expected.txt.
  • editing/mac/input/firstrectforcharacterrange-caret-in-br.html: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-caret-in-br.html.
  • editing/mac/input/firstrectforcharacterrange-plain-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt.
  • editing/mac/input/firstrectforcharacterrange-plain.html: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-plain.html.
  • editing/mac/input/firstrectforcharacterrange-styled-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt.
  • editing/mac/input/firstrectforcharacterrange-styled.html: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-styled.html.
  • editing/mac/input/firstrectforcharacterrange-vertical-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-vertical-expected.txt.
  • editing/mac/input/firstrectforcharacterrange-vertical.html: Renamed from LayoutTests/platform/mac/editing/input/firstrectforcharacterrange-vertical.html.
  • editing/mac/input/hangul-enter-confirms-and-sends-keypress-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/hangul-enter-confirms-and-sends-keypress-expected.txt.
  • editing/mac/input/hangul-enter-confirms-and-sends-keypress.html: Renamed from LayoutTests/platform/mac/editing/input/hangul-enter-confirms-and-sends-keypress.html.
  • editing/mac/input/insert-delete-smp-symbol-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/insert-delete-smp-symbol-expected.txt.
  • editing/mac/input/insert-delete-smp-symbol.html: Renamed from LayoutTests/platform/mac/editing/input/insert-delete-smp-symbol.html.
  • editing/mac/input/insert-dictated-text-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/insert-dictated-text-expected.txt.
  • editing/mac/input/insert-dictated-text.html: Renamed from LayoutTests/platform/mac/editing/input/insert-dictated-text.html.
  • editing/mac/input/kotoeri-enter-to-confirm-and-newline-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/kotoeri-enter-to-confirm-and-newline-expected.txt.
  • editing/mac/input/kotoeri-enter-to-confirm-and-newline.html: Renamed from LayoutTests/platform/mac/editing/input/kotoeri-enter-to-confirm-and-newline.html.
  • editing/mac/input/maxlength-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/maxlength-expected.txt.
  • editing/mac/input/maxlength.html: Renamed from LayoutTests/platform/mac/editing/input/maxlength.html.
  • editing/mac/input/range-for-empty-document-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/range-for-empty-document-expected.txt.
  • editing/mac/input/range-for-empty-document.html: Renamed from LayoutTests/platform/mac/editing/input/range-for-empty-document.html.
  • editing/mac/input/replace-invalid-range-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/replace-invalid-range-expected.txt.
  • editing/mac/input/replace-invalid-range.html: Renamed from LayoutTests/platform/mac/editing/input/replace-invalid-range.html.
  • editing/mac/input/resources/first-page.html: Renamed from LayoutTests/platform/mac/editing/input/resources/first-page.html.
  • editing/mac/input/resources/hangul.js: Renamed from LayoutTests/platform/mac/editing/input/hangul.js.

(hangul):

  • editing/mac/input/resources/kotoeri.js: Renamed from LayoutTests/platform/mac/editing/input/kotoeri.js.

(kotoeri):

  • editing/mac/input/resources/logger.js: Renamed from LayoutTests/platform/mac/editing/input/logger.js.

(log):

  • editing/mac/input/resources/other-page.html: Renamed from LayoutTests/platform/mac/editing/input/resources/other-page.html.
  • editing/mac/input/secure-input-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/secure-input-expected.txt.
  • editing/mac/input/secure-input.html: Renamed from LayoutTests/platform/mac/editing/input/secure-input.html.
  • editing/mac/input/selected-composed-text-painting-expected.html: Renamed from LayoutTests/platform/mac/editing/input/selected-composed-text-painting-expected.html.
  • editing/mac/input/selected-composed-text-painting.html: Renamed from LayoutTests/platform/mac/editing/input/selected-composed-text-painting.html.
  • editing/mac/input/selection-change-closes-typing-2-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/selection-change-closes-typing-2-expected.txt.
  • editing/mac/input/selection-change-closes-typing-2.html: Renamed from LayoutTests/platform/mac/editing/input/selection-change-closes-typing-2.html.
  • editing/mac/input/selection-change-closes-typing-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/selection-change-closes-typing-expected.txt.
  • editing/mac/input/selection-change-closes-typing.html: Renamed from LayoutTests/platform/mac/editing/input/selection-change-closes-typing.html.
  • editing/mac/input/text-control-ime-input-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/text-control-ime-input-expected.txt.
  • editing/mac/input/text-control-ime-input.html: Renamed from LayoutTests/platform/mac/editing/input/text-control-ime-input.html.
  • editing/mac/input/text-input-controller-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/text-input-controller-expected.txt.
  • editing/mac/input/text-input-controller.html: Renamed from LayoutTests/platform/mac/editing/input/text-input-controller.html.
  • editing/mac/input/unconfirmed-text-navigation-with-page-cache-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/unconfirmed-text-navigation-with-page-cache-expected.txt.
  • editing/mac/input/unconfirmed-text-navigation-with-page-cache.html: Renamed from LayoutTests/platform/mac/editing/input/unconfirmed-text-navigation-with-page-cache.html.
  • editing/mac/input/undo-grouping-on-text-insertion-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/undo-grouping-on-text-insertion-expected.txt.
  • editing/mac/input/undo-grouping-on-text-insertion.html: Renamed from LayoutTests/platform/mac/editing/input/undo-grouping-on-text-insertion.html.
  • editing/mac/input/wrapped-line-char-rect-expected.txt: Renamed from LayoutTests/platform/mac/editing/input/wrapped-line-char-rect-expected.txt.
  • editing/mac/input/wrapped-line-char-rect.html: Renamed from LayoutTests/platform/mac/editing/input/wrapped-line-char-rect.html.
  • editing/mac/pasteboard/5583362-expected.png: Renamed from LayoutTests/platform/mac/editing/pasteboard/5583362-expected.png.
  • editing/mac/pasteboard/5583362-expected.txt: Renamed from LayoutTests/platform/mac/editing/pasteboard/5583362-expected.txt.
  • editing/mac/pasteboard/5583362.html: Renamed from LayoutTests/platform/mac/editing/pasteboard/5583362.html.
  • editing/mac/pasteboard/dataTransfer-set-data-file-url-expected.png: Renamed from LayoutTests/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.png.
  • editing/mac/pasteboard/dataTransfer-set-data-file-url-expected.txt: Renamed from LayoutTests/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url-expected.txt.
  • editing/mac/pasteboard/dataTransfer-set-data-file-url.html: Renamed from LayoutTests/platform/mac/editing/pasteboard/dataTransfer-set-data-file-url.html.
  • editing/mac/pasteboard/drag-selections-to-contenteditable-expected.txt: Renamed from LayoutTests/platform/mac/editing/pasteboard/drag-selections-to-contenteditable-expected.txt.
  • editing/mac/pasteboard/drag-selections-to-contenteditable.html: Renamed from LayoutTests/platform/mac/editing/pasteboard/drag-selections-to-contenteditable.html.
  • editing/mac/pasteboard/paste-and-match-style-selector-event-expected.txt: Renamed from LayoutTests/platform/mac/editing/pasteboard/paste-and-match-style-selector-event-expected.txt.
  • editing/mac/pasteboard/paste-and-match-style-selector-event.html: Renamed from LayoutTests/platform/mac/editing/pasteboard/paste-and-match-style-selector-event.html.
  • editing/mac/pasteboard/text-precomposed-expected.txt: Renamed from LayoutTests/platform/mac/editing/pasteboard/text-precomposed-expected.txt.
  • editing/mac/pasteboard/text-precomposed.html: Renamed from LayoutTests/platform/mac/editing/pasteboard/text-precomposed.html.
  • editing/mac/selection/25228-expected.png: Renamed from LayoutTests/platform/mac/editing/selection/25228-expected.png.
  • editing/mac/selection/25228-expected.txt: Renamed from LayoutTests/platform/mac/editing/selection/25228-expected.txt.
  • editing/mac/selection/25228.html: Renamed from LayoutTests/platform/mac/editing/selection/25228.html.
  • editing/mac/selection/context-menu-select-editability-expected.txt: Renamed from LayoutTests/platform/mac/editing/selection/context-menu-select-editability-expected.txt.
  • editing/mac/selection/context-menu-select-editability.html: Renamed from LayoutTests/platform/mac/editing/selection/context-menu-select-editability.html.
  • editing/mac/selection/doubleclick-should-not-expand-across-lines-expected.txt: Renamed from LayoutTests/platform/mac/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt.
  • editing/mac/selection/doubleclick-should-not-expand-across-lines.html: Renamed from LayoutTests/platform/mac/editing/selection/doubleclick-should-not-expand-across-lines.html.
  • editing/mac/selection/script-tests/TEMPLATE.html: Renamed from LayoutTests/platform/mac/editing/selection/script-tests/TEMPLATE.html.
  • editing/mac/selection/script-tests/doubleclick-should-not-expand-across-lines.js: Renamed from LayoutTests/platform/mac/editing/selection/script-tests/doubleclick-should-not-expand-across-lines.js.

(description.doubleClickOnElement):
(doubleClickAt):
(selectionShouldBe):

  • editing/mac/selection/word-thai-expected.txt: Renamed from LayoutTests/platform/mac/editing/selection/word-thai-expected.txt.
  • editing/mac/selection/word-thai.html: Renamed from LayoutTests/platform/mac/editing/selection/word-thai.html.
  • editing/mac/spelling/autocorrection-at-beginning-of-word-1-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.png.
  • editing/mac/spelling/autocorrection-at-beginning-of-word-1-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt.
  • editing/mac/spelling/autocorrection-at-beginning-of-word-1.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1.html.
  • editing/mac/spelling/autocorrection-at-beginning-of-word-2-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.png.
  • editing/mac/spelling/autocorrection-at-beginning-of-word-2-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt.
  • editing/mac/spelling/autocorrection-at-beginning-of-word-2.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2.html.
  • editing/mac/spelling/autocorrection-blockquote-crash-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt.
  • editing/mac/spelling/autocorrection-blockquote-crash.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-blockquote-crash.html.
  • editing/mac/spelling/autocorrection-contraction-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-contraction-expected.png.
  • editing/mac/spelling/autocorrection-contraction-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-contraction-expected.txt.
  • editing/mac/spelling/autocorrection-contraction.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-contraction.html.
  • editing/mac/spelling/autocorrection-delete-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-delete-expected.png.
  • editing/mac/spelling/autocorrection-delete-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-delete-expected.txt.
  • editing/mac/spelling/autocorrection-delete.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-delete.html.
  • editing/mac/spelling/autocorrection-in-textarea-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt.
  • editing/mac/spelling/autocorrection-in-textarea.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea.html.
  • editing/mac/spelling/autocorrection-removing-underline-after-paste-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.png.
  • editing/mac/spelling/autocorrection-removing-underline-after-paste-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt.
  • editing/mac/spelling/autocorrection-removing-underline-after-paste.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-removing-underline-after-paste.html.
  • editing/mac/spelling/autocorrection-removing-underline-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-removing-underline-expected.png.
  • editing/mac/spelling/autocorrection-removing-underline-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt.
  • editing/mac/spelling/autocorrection-removing-underline.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-removing-underline.html.
  • editing/mac/spelling/autocorrection-respets-undo-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-respets-undo-expected.txt.
  • editing/mac/spelling/autocorrection-respets-undo.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-respets-undo.html.
  • editing/mac/spelling/autocorrection-simple-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-simple-expected.png.
  • editing/mac/spelling/autocorrection-simple-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-simple-expected.txt.
  • editing/mac/spelling/autocorrection-simple.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-simple.html.
  • editing/mac/spelling/autocorrection-with-multi-line-text-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt.
  • editing/mac/spelling/autocorrection-with-multi-line-text.html: Renamed from LayoutTests/platform/mac/editing/spelling/autocorrection-with-multi-line-text.html.
  • editing/mac/spelling/click-autocorrected-word-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/click-autocorrected-word-expected.png.
  • editing/mac/spelling/click-autocorrected-word-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/click-autocorrected-word-expected.txt.
  • editing/mac/spelling/click-autocorrected-word.html: Renamed from LayoutTests/platform/mac/editing/spelling/click-autocorrected-word.html.
  • editing/mac/spelling/delete-autocorrected-word-1-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.png.
  • editing/mac/spelling/delete-autocorrected-word-1-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt.
  • editing/mac/spelling/delete-autocorrected-word-1.html: Renamed from LayoutTests/platform/mac/editing/spelling/delete-autocorrected-word-1.html.
  • editing/mac/spelling/delete-autocorrected-word-2-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/delete-autocorrected-word-2-expected.png.
  • editing/mac/spelling/delete-autocorrected-word-2-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/delete-autocorrected-word-2-expected.txt.
  • editing/mac/spelling/delete-autocorrected-word-2.html: Renamed from LayoutTests/platform/mac/editing/spelling/delete-autocorrected-word-2.html.
  • editing/mac/spelling/delete-into-autocorrected-word-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png.
  • editing/mac/spelling/delete-into-autocorrected-word-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt.
  • editing/mac/spelling/delete-into-autocorrected-word.html: Renamed from LayoutTests/platform/mac/editing/spelling/delete-into-autocorrected-word.html.
  • editing/mac/spelling/editing-word-with-marker-1-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-1-expected.txt.
  • editing/mac/spelling/editing-word-with-marker-1.html: Renamed from LayoutTests/platform/mac/editing/spelling/editing-word-with-marker-1.html.
  • editing/mac/spelling/forward-delete-into-autocorrected-word-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png.
  • editing/mac/spelling/forward-delete-into-autocorrected-word-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt.
  • editing/mac/spelling/forward-delete-into-autocorrected-word.html: Renamed from LayoutTests/platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html.
  • editing/mac/spelling/move-cursor-to-autocorrected-word-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png.
  • editing/mac/spelling/move-cursor-to-autocorrected-word-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt.
  • editing/mac/spelling/move-cursor-to-autocorrected-word.html: Renamed from LayoutTests/platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html.
  • editing/mac/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png: Renamed from LayoutTests/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png.
  • editing/mac/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt.
  • editing/mac/spelling/move-cursor-to-beginning-of-autocorrected-word.html: Renamed from LayoutTests/platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html.
  • editing/mac/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt: Renamed from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation-expected.txt.
  • editing/mac/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html: Renamed from LayoutTests/platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html.
  • platform/mac-wk2/TestExpectations:
  • platform/mac-wk2/editing/mac/spelling/autocorrection-contraction-expected.png: Renamed from LayoutTests/platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.png.
  • platform/mac-wk2/editing/mac/spelling/autocorrection-contraction-expected.txt: Renamed from LayoutTests/platform/mac-wk2/platform/mac/editing/spelling/autocorrection-contraction-expected.txt.
  • platform/mac/TestExpectations:
  • platform/mac/editing/input/caret-primary-bidi-expected.txt: Removed.
  • platform/win/editing/mac/spelling/autocorrection-contraction-expected.txt: Renamed from LayoutTests/platform/win/platform/mac/editing/spelling/autocorrection-contraction-expected.txt.
  • platform/wk2/TestExpectations:
6:32 PM Changeset in webkit [187931] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE the database task code
​https://bugs.webkit.org/show_bug.cgi?id=147673

Reviewed by Andreas Kling.

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::markAsDeletedAndClose):
(WebCore::Database::tableNames):

  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseTask::performTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::doPerformTask):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseTask::database):

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::SameDatabasePredicate::operator()):

6:26 PM Changeset in webkit [187930] by Brent Fulgham
  • 3 edits
    3 adds in trunk

REGRESSION (r173784): [Mac] Correct latching error for non-scrollable iframe nested inside scrollable div.
​https://bugs.webkit.org/show_bug.cgi?id=147668
<rdar://problem/21870332>

Reviewed by Simon Fraser.

Source/WebCore:

Test: platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html

When we are wrapping up processing of the wheel event for a given frame, if the current latching context
does NOT apply to the current frame (e.g., because it's latched to an enclosing frame) we should not pass
wheel events directly to the latched elements scrollable container. Instead, we should just give the current
frame an opportunity to perform any custom wheel event handling and return, so that the enclosing (latched)
frame can do the rest of its event handling.

If we don't do this, we incorrectly ask the enclosing frame to process the event, then return claiming that
we handled the event, preventing the enclosing frame from doing its part of the processing.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompleteWheelEvent):

LayoutTests:

  • platform/mac/fast/scrolling/resources/background.html: Added.
  • platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe-expected.txt: Added.
  • platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html: Added.
6:25 PM Changeset in webkit [187929] by Matt Baker
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Layout & Rendering timeline grid should show TimelineRecord parent/child relationships
​https://bugs.webkit.org/show_bug.cgi?id=147468

Reviewed by Brian Burg.

Layout timeline data grid now shows record nesting for Layout and Composite events.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded):

  • UserInterface/Models/TimelineRecord.js:

(WebInspector.TimelineRecord.prototype.get parent):
(WebInspector.TimelineRecord.prototype.set parent):
Preserve timeline record parent/child relationship.

  • UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView):
Style change for disclosure triangle support.
(WebInspector.LayoutTimelineView.prototype._layoutTimelineRecordAdded):
Only process immediate children of the rendering frame record.

6:15 PM Changeset in webkit [187928] by achristensen@apple.com
  • 7 edits in trunk/Source

Soft link libGLESv2 and libEGL on Windows again
​https://bugs.webkit.org/show_bug.cgi?id=147671

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

  • CMakeLists.txt:

Clean up some warnings when compiling with CMake.

  • include/EGL/egl.h:
  • include/EGL/eglsoftlinking.h:
  • include/GLES2/gl2.h:

Soft link egl optionally.

Source/WebCore:

  • platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::initializeEGLDisplay):
Fail gracefully if libEGL is not found.

6:08 PM Changeset in webkit [187927] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

Remove another unused database function
​https://bugs.webkit.org/show_bug.cgi?id=147670

Reviewed by Daniel Bates.

This was used back when we had WebSQL support in workers, we can safely remove all these functions now.

  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::interruptAllDatabasesForContext): Deleted.

  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::interruptAllDatabasesForContext): Deleted.

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext): Deleted.

  • Modules/webdatabase/DatabaseTracker.h:
5:57 PM Changeset in webkit [187926] by andersca@apple.com
  • 14 edits in trunk/Source

Remove database thread pause code
​https://bugs.webkit.org/show_bug.cgi?id=147669

Reviewed by Daniel Bates.

Source/WebCore:

We now grab power assertions while running SQLite transactions,
and this code isn't used at all with modern WebKit so let's just get rid of it.

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext): Deleted.
(WebCore::DatabaseContext::databaseThread): Deleted.
(WebCore::DatabaseContext::setPaused): Deleted.

  • Modules/webdatabase/DatabaseContext.h:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::Database::DatabaseTransactionTask::shouldPerformWhilePaused): Deleted.

  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::DatabaseThread): Deleted.
(WebCore::DatabaseThread::requestTermination): Deleted.
(WebCore::DatabaseUnpauseTask::DatabaseUnpauseTask): Deleted.
(WebCore::DatabaseUnpauseTask::shouldPerformWhilePaused): Deleted.
(WebCore::DatabaseUnpauseTask::doPerformTask): Deleted.
(WebCore::DatabaseUnpauseTask::debugTaskName): Deleted.
(WebCore::DatabaseThread::setPaused): Deleted.
(WebCore::DatabaseThread::handlePausedQueue): Deleted.
(WebCore::DatabaseThread::databaseThread): Deleted.

  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setDatabasesPaused): Deleted.

  • Modules/webdatabase/DatabaseTracker.h:

Source/WebKit/ios:

  • Misc/WebUIKitSupport.mm:

(WebKitSetBackgroundAndForegroundNotificationNames):
(applicationDidEnterBackground): Deleted.
(applicationWillEnterForeground): Deleted.

Source/WebKit/mac:

  • Storage/WebDatabaseManager.mm:

(WebKitSetWebDatabasePaused): Deleted.

  • Storage/WebDatabaseManagerInternal.h:
5:46 PM Changeset in webkit [187925] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Install twisted package for http server when necessary.
​https://bugs.webkit.org/show_bug.cgi?id=147082

Patch by Dewei Zhu <Dewei Zhu> on 2015-08-04
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_twisted):

5:41 PM Changeset in webkit [187924] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

5:41 PM Changeset in webkit [187923] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "No Filter Results" overlaps other UI elements when docked Inspector is small
​https://bugs.webkit.org/show_bug.cgi?id=147659

Reviewed by Timothy Hatcher.

Hide overflow of empty content label containers in navigation sidebars.

  • UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .empty-content-placeholder):

5:39 PM Changeset in webkit [187922] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.2

New tag.

5:28 PM Changeset in webkit [187921] by Chris Dumez
  • 4 edits
    2 adds in trunk

Subframes with no current HistoryItem should not prevent page-caching
​https://bugs.webkit.org/show_bug.cgi?id=147649
<rdar://problem/21614832>

Reviewed by Andreas Kling.

Source/WebCore:

Subframes with no current HistoryItem should not prevent page-caching.
We need one for the main frame as this is the key in the PageCache.
However, there is no reason to require one for subframes.

This is a common reason for page-caching failures nowadays.

Frames do no have a current HistoryItem until something has been loaded in them.

Test: http/tests/navigation/page-cache-iframe-no-current-historyItem.html

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

LayoutTests:

Add a layout test that covers page-caching of a page that contains an
iframe with no current HistoryItem. The sub-frame has no current
HistoryItem because its URL is invalid: "​http://".

  • http/tests/navigation/page-cache-iframe-no-current-historyItem-expected.txt: Added.
  • http/tests/navigation/page-cache-iframe-no-current-historyItem.html: Added.

New test.

  • platform/mac-wk1/TestExpectations:

Skip the new test on Mac WK1. The page is still not cacheable on Mac WK1
because WebFrameLoaderClient::canCachePage() returns false if the frame
does not contain HTML at the moment.

5:27 PM Changeset in webkit [187920] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Build fix after r187908

  • platform/win/WindowsTouch.h: If WINVER is set properly, we

don't need these definitions.

5:08 PM Changeset in webkit [187919] by Simon Fraser
  • 4 edits in trunk/LayoutTests

Fix script paths in these tests.

  • tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash.html:
  • tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash.html:
  • tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash.html:
4:58 PM Changeset in webkit [187918] by achristensen@apple.com
  • 6 edits in trunk

Fix quirks with CMake and VS2015
​https://bugs.webkit.org/show_bug.cgi?id=147663

Reviewed by Brent Fulgham.

.:

  • Source/cmake/OptionsWindows.cmake:

Hide some warnings. Using the same variable names in nested scopes is ok for now.
Disable INTL for now.

Source/WTF:

  • wtf/Platform.h:

Build fix after r187908

WebKitLibraries:

  • win/tools/vsprops/common.props:

Hide some warnings. Using the same variable names in nested scopes is ok for now.

4:55 PM Changeset in webkit [187917] by mrajca@apple.com
  • 11 edits
    4 adds in trunk/Source/WebKit2

Media Session: add a focus manager that WebKit clients can use to access the focused media element
​https://bugs.webkit.org/show_bug.cgi?id=147629

Reviewed by Tim Horton.

  • Shared/API/APIObject.h: Added a new type for the focus manager.
  • Shared/API/c/WKBase.h: Added a new type for the focus manager.
  • UIProcess/API/C/WKAPICast.h: Added a new type for the focus manager.
  • UIProcess/API/C/WKContext.cpp: The "global" focus manager is accessed via WKContext.

(WKContextGetMediaSessionFocusManager):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKMediaSessionFocusManager.cpp: Added C wrapper for WebMediaSessionFocusManager.

(WKMediaSessionFocusManagerGetTypeID):
(WKMediaSessionFocusManagerIsFocusedContentMediaElementPaused):

  • UIProcess/API/C/WKMediaSessionFocusManager.h: Added C wrapper for WebMediaSessionFocusManager.
  • UIProcess/WebMediaSessionFocusManager.cpp: Added to keep track of the focused media element in the UI process and let clients query this state.

(WebKit::WebMediaSessionFocusManager::supplementName):
(WebKit::WebMediaSessionFocusManager::create):
(WebKit::WebMediaSessionFocusManager::WebMediaSessionFocusManager):
(WebKit::WebMediaSessionFocusManager::refWebContextSupplement):
(WebKit::WebMediaSessionFocusManager::derefWebContextSupplement):
(WebKit::WebMediaSessionFocusManager::isFocusedContentMediaElementPaused): Check if the media element on the focused page is paused.
(WebKit::WebMediaSessionFocusManager::setFocusedMediaElement): Keep track of the focused page / media element pair.
(WebKit::WebMediaSessionFocusManager::clearFocusedMediaElement): Reset the focused page / media element pair.

  • UIProcess/WebMediaSessionFocusManager.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isMediaElementPaused): Updated to take a UnsignedCallback.
(WebKit::WebPageProxy::focusedContentMediaElementDidChange): Store the focused media element in the focus manager.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp: Added WebMediaSessionFocusManager as a supplement.
  • UIProcess/WebProcessPool.h: WebMediaSessionFocusManager is a supplement, so include its header.
  • WebKit2.xcodeproj/project.pbxproj: Added new sources and ran sort-xcode-project.
4:45 PM Changeset in webkit [187916] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187776. rdar://problem/21925990

4:45 PM Changeset in webkit [187915] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Merge r187806. rdar://problem/21838271

4:45 PM Changeset in webkit [187914] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit/mac

Merge r187801. rdar://problem/21838271

4:45 PM Changeset in webkit [187913] by matthew_hanson@apple.com
  • 6 edits
    2 adds in branches/safari-601.1-branch

Merge r187797. rdar://problem/21838271

4:45 PM Changeset in webkit [187912] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187792. rdar://problem/22116575

4:44 PM Changeset in webkit [187911] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove an unused Database function
​https://bugs.webkit.org/show_bug.cgi?id=147661

Reviewed by Simon Fraser.

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::closeImmediately): Deleted.

  • Modules/webdatabase/Database.h:
4:37 PM Changeset in webkit [187910] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Fix the build.

  • Plugins/WebNetscapePluginStream.h:
4:30 PM Changeset in webkit [187909] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marked appcache test as flakey.

I was unable to reduce flakiness of this in an acceptable fashion,
just mark it as pass/fail.

4:10 PM Changeset in webkit [187908] by Brent Fulgham
  • 15 edits in trunk

[Win] Update Apple Windows build for VS2015
​https://bugs.webkit.org/show_bug.cgi?id=147653

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Show JSC files in proper project locations in IDE.

Source/WebKit/win:

  • WebView.cpp:

(WebView::setCacheModel): Add explicit 'get' to satisfy compiler.

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj.filters: Drive-by-fix to place files in

proper project locations in the IDE.

  • wtf/Platform.h: Don't define the _HAS_EXCEPTIONS macro when building with

Visual Studio 2015.

Tools:

  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with

something older than VS2015, define snprintf as _snprintf.

  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:

Remove unneeded macro definition for snprintf.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._determine_win_version): Recognize Windows 10.

  • Scripts/webkitpy/port/win.py:

(WinPort): Ditto.

  • Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
(WinPortTest._assert_version): Ditto.

WebKitLibraries:

  • win/tools/vsprops/common.props: Fix build flags to use Windows 7

(WINVER=0x601) as minimum build target for 64-bit builds.

4:08 PM Changeset in webkit [187907] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when following a Google search link to Twitter with Limit Adult Content enabled.
<rdar://problem/22123707> and ​https://bugs.webkit.org/show_bug.cgi?id=147651

Reviewed by Sam Weinig.

No new tests (Doesn't occur in a tested config).

For now, we'll skip the application cache for main resource loads if parental controls are enabled.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::startLoadingMainResource):

3:58 PM Changeset in webkit [187906] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.47

New tag.

3:53 PM Changeset in webkit [187905] by Simon Fraser
  • 4 edits
    273 moves
    13 adds in trunk/LayoutTests

Move platform/mac-wk2/tiled-drawing to tiled-drawing/

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • tiled-drawing/background-transparency-toggle-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/background-transparency-toggle-expected.txt.
  • tiled-drawing/background-transparency-toggle.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/background-transparency-toggle.html.
  • tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content-expected.txt.
  • tiled-drawing/crash-reloading-with-position-fixed-content.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/crash-reloading-with-position-fixed-content.html.
  • tiled-drawing/fixed-background-scroll-repaint-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/fixed-background-scroll-repaint-expected.txt.
  • tiled-drawing/fixed-background-scroll-repaint.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/fixed-background-scroll-repaint.html.
  • tiled-drawing/fixed-layout-size-fixed-attachment-cover-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-cover-expected.html.
  • tiled-drawing/fixed-layout-size-fixed-attachment-cover.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-cover.html.
  • tiled-drawing/fixed-layout-size-fixed-attachment-local-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-local-expected.html.
  • tiled-drawing/fixed-layout-size-fixed-attachment-local.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-local.html.
  • tiled-drawing/header-and-footer-hit-testing-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-expected.txt.
  • tiled-drawing/header-and-footer-hit-testing-in-frame-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame-expected.txt.
  • tiled-drawing/header-and-footer-hit-testing-in-frame.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-in-frame.html.
  • tiled-drawing/header-and-footer-hit-testing-with-page-scale-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale-expected.txt.
  • tiled-drawing/header-and-footer-hit-testing-with-page-scale.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html.
  • tiled-drawing/header-and-footer-hit-testing.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html.
  • tiled-drawing/resources/bordered-image.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/resources/bordered-image.png.
  • tiled-drawing/resources/go-back.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/resources/go-back.html.
  • tiled-drawing/resources/green-blue.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/resources/green-blue.png.
  • tiled-drawing/resources/green.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/resources/green.png.
  • tiled-drawing/resources/greenbox.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/resources/greenbox.png.
  • tiled-drawing/resources/iframe-to-hit-test.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/resources/iframe-to-hit-test.html.
  • tiled-drawing/resources/scroll-and-load-page.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html.
  • tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt.
  • tiled-drawing/scrolling/clamp-out-of-bounds-scrolls.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/clamp-out-of-bounds-scrolls.html.
  • tiled-drawing/scrolling/fast-scroll-div-latched-div-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div-with-handler.html.
  • tiled-drawing/scrolling/fast-scroll-div-latched-div.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-div.html.
  • tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe-with-handler.html.
  • tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe-with-handler.html.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-iframe.html.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe-with-handler.html.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-select-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-select-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-iframe-latched-select.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-iframe-latched-select.html.
  • tiled-drawing/scrolling/fast-scroll-mainframe-zoom-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-mainframe-zoom-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-mainframe-zoom.html.
  • tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe-with-handler.html.
  • tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html.
  • tiled-drawing/scrolling/fast-scroll-select-latched-select-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler-expected.txt.
  • tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select-with-handler.html.
  • tiled-drawing/scrolling/fast-scroll-select-latched-select.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fast-scroll-select-latched-select.html.
  • tiled-drawing/scrolling/fixed-background/fixed-background-composited-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-composited-expected.html.
  • tiled-drawing/scrolling/fixed-background/fixed-background-composited.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-composited.html.
  • tiled-drawing/scrolling/fixed-background/fixed-background-negative-z-index-fixed-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-negative-z-index-fixed-expected.html.
  • tiled-drawing/scrolling/fixed-background/fixed-background-negative-z-index-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-negative-z-index-fixed.html.
  • tiled-drawing/scrolling/fixed-background/fixed-background-no-image-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-no-image-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-background-no-image.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-no-image.html.
  • tiled-drawing/scrolling/fixed-background/fixed-background-removal-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-removal-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-background-removal.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-background-removal.html.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-body-layer-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-body-layer-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-body-layer-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-body-layer-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-body-layer.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-body-layer.html.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-opacity.html.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-positioned-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-positioned-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-positioned-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-positioned-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-positioned.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-positioned.html.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-transformed.html.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background-zoomed.html.
  • tiled-drawing/scrolling/fixed-background/fixed-body-background.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-body-background.html.
  • tiled-drawing/scrolling/fixed-background/fixed-html-background-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-html-background-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-html-background-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-html-background-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-html-background.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-html-background.html.
  • tiled-drawing/scrolling/fixed-background/fixed-non-propagated-body-background-expected.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-non-propagated-body-background-expected.png.
  • tiled-drawing/scrolling/fixed-background/fixed-non-propagated-body-background-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-non-propagated-body-background-expected.txt.
  • tiled-drawing/scrolling/fixed-background/fixed-non-propagated-body-background.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed-background/fixed-non-propagated-body-background.html.
  • tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt.
  • tiled-drawing/scrolling/fixed/absolute-inside-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/absolute-inside-fixed.html.
  • tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt.
  • tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed.html.
  • tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt.
  • tiled-drawing/scrolling/fixed/fixed-in-overflow.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-in-overflow.html.
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt.
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt.
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex.html.
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/fixed-position-out-of-view.html.
  • tiled-drawing/scrolling/fixed/four-bars-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-expected.txt.
  • tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt.
  • tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer.html.
  • tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt.
  • tiled-drawing/scrolling/fixed/four-bars-zoomed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars-zoomed.html.
  • tiled-drawing/scrolling/fixed/four-bars.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/four-bars.html.
  • tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt.
  • tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt.
  • tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view.html.
  • tiled-drawing/scrolling/fixed/negative-scroll-offset.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/negative-scroll-offset.html.
  • tiled-drawing/scrolling/fixed/nested-fixed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/nested-fixed-expected.txt.
  • tiled-drawing/scrolling/fixed/nested-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/nested-fixed.html.
  • tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt.
  • tiled-drawing/scrolling/fixed/percentage-inside-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/fixed/percentage-inside-fixed.html.
  • tiled-drawing/scrolling/frames/coordinated-frame-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-expected.txt.
  • tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt.
  • tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html.
  • tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt.
  • tiled-drawing/scrolling/frames/coordinated-frame-in-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-in-fixed.html.
  • tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt.
  • tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html.
  • tiled-drawing/scrolling/frames/coordinated-frame.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/coordinated-frame.html.
  • tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt.
  • tiled-drawing/scrolling/frames/fixed-inside-frame.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/fixed-inside-frame.html.
  • tiled-drawing/scrolling/frames/frameset-frame-scrollability-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability-expected.txt.
  • tiled-drawing/scrolling/frames/frameset-frame-scrollability.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-frame-scrollability.html.
  • tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability-expected.txt.
  • tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/frameset-nested-frame-scrollability.html.
  • tiled-drawing/scrolling/frames/orphaned-subtree-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/orphaned-subtree-expected.txt.
  • tiled-drawing/scrolling/frames/orphaned-subtree.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/orphaned-subtree.html.
  • tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt.
  • tiled-drawing/scrolling/frames/remove-coordinated-frame.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/remove-coordinated-frame.html.
  • tiled-drawing/scrolling/frames/resources/autoscrolling-frame-with-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/resources/autoscrolling-frame-with-fixed.html.
  • tiled-drawing/scrolling/frames/resources/doc-with-sticky.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/resources/doc-with-sticky.html.
  • tiled-drawing/scrolling/frames/resources/frameset-frame.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/resources/frameset-frame.html.
  • tiled-drawing/scrolling/frames/resources/layouting-frame.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/resources/layouting-frame.html.
  • tiled-drawing/scrolling/frames/resources/leaf-frame.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/resources/leaf-frame.html.
  • tiled-drawing/scrolling/frames/resources/scrollable-page.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/resources/scrollable-page.html.
  • tiled-drawing/scrolling/frames/resources/subframe-inside-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/resources/subframe-inside-fixed.html.
  • tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt.
  • tiled-drawing/scrolling/frames/scroll-region-after-frame-layout.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/frames/scroll-region-after-frame-layout.html.
  • tiled-drawing/scrolling/iframe_in_iframe-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/iframe_in_iframe-expected.txt.
  • tiled-drawing/scrolling/iframe_in_iframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/iframe_in_iframe.html.
  • tiled-drawing/scrolling/non-fast-region/compute-region-inside-delete-renderer-crash-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/compute-region-inside-delete-renderer-crash-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/compute-region-inside-delete-renderer-crash.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/compute-region-inside-delete-renderer-crash.html.
  • tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-element-with-multiple-handlers-crash.html.
  • tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-crash.html.
  • tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/destroy-wheel-element-parent-crash.html.
  • tiled-drawing/scrolling/non-fast-region/handlers-in-iframes-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html.
  • tiled-drawing/scrolling/non-fast-region/resources/gain-wheel-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/gain-wheel-handler.html.
  • tiled-drawing/scrolling/non-fast-region/resources/lose-wheel-handler.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/lose-wheel-handler.html.
  • tiled-drawing/scrolling/non-fast-region/resources/wheel-handler-region-helper.js: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/wheel-handler-region-helper.js.

(rectsAsString):
(dumpRegion):

  • tiled-drawing/scrolling/non-fast-region/top-content-inset-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/top-content-inset-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/top-content-inset-header-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/top-content-inset-header-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/top-content-inset-header.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/top-content-inset-header.html.
  • tiled-drawing/scrolling/non-fast-region/top-content-inset.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/top-content-inset.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-event-plugin-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-event-plugin-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-event-plugin.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-event-plugin.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-overflow-scroll.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed.html.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic-expected.txt.
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic.html.
  • tiled-drawing/scrolling/null-parent-back-crash-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/null-parent-back-crash-expected.txt.
  • tiled-drawing/scrolling/null-parent-back-crash.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/null-parent-back-crash.html.
  • tiled-drawing/scrolling/overflow-scroll-reduced-content-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-reduced-content-expected.txt.
  • tiled-drawing/scrolling/overflow-scroll-reduced-content.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-reduced-content.html.
  • tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events-expected.txt.
  • tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events.html.
  • tiled-drawing/scrolling/resources/inner_content.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/resources/inner_content.html.
  • tiled-drawing/scrolling/resources/select_iframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/resources/select_iframe.html.
  • tiled-drawing/scrolling/resources/testContent.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/resources/testContent.html.
  • tiled-drawing/scrolling/resources/testImage.png: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/resources/testImage.png.
  • tiled-drawing/scrolling/root-overflow-with-mousewheel-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/root-overflow-with-mousewheel-expected.txt.
  • tiled-drawing/scrolling/root-overflow-with-mousewheel.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/root-overflow-with-mousewheel.html.
  • tiled-drawing/scrolling/scroll-snap/resources/horizontal-mainframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources/horizontal-mainframe.html.
  • tiled-drawing/scrolling/scroll-snap/resources/vertical-mainframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/resources/vertical-mainframe.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-destination-lock-up.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated-expected.txt.
  • tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html.
  • tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt.
  • tiled-drawing/scrolling/scrolling-tree-after-scroll.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scrolling-tree-after-scroll.html.
  • tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt.
  • tiled-drawing/scrolling/scrolling-tree-slow-scrolling.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/scrolling-tree-slow-scrolling.html.
  • tiled-drawing/scrolling/slow-scrolling-background-toggle-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/slow-scrolling-background-toggle-expected.txt.
  • tiled-drawing/scrolling/slow-scrolling-background-toggle.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/slow-scrolling-background-toggle.html.
  • tiled-drawing/scrolling/slow-scrolling-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/slow-scrolling-expected.txt.
  • tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle-expected.txt.
  • tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/slow-scrolling-hidden-background-toggle.html.
  • tiled-drawing/scrolling/slow-scrolling.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/slow-scrolling.html.
  • tiled-drawing/scrolling/stateless-scrolling-no-rubber-band-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/stateless-scrolling-no-rubber-band-expected.txt.
  • tiled-drawing/scrolling/stateless-scrolling-no-rubber-band.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/stateless-scrolling-no-rubber-band.html.
  • tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt.
  • tiled-drawing/scrolling/sticky/negative-scroll-offset.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/negative-scroll-offset.html.
  • tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt.
  • tiled-drawing/scrolling/sticky/sticky-horizontal.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/sticky-horizontal.html.
  • tiled-drawing/scrolling/sticky/sticky-layers-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/sticky-layers-expected.txt.
  • tiled-drawing/scrolling/sticky/sticky-layers.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/sticky-layers.html.
  • tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt.
  • tiled-drawing/scrolling/sticky/sticky-vertical.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/sticky/sticky-vertical.html.
  • tiled-drawing/scrolling/wheel-events-with-no-delta-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta-expected.txt.
  • tiled-drawing/scrolling/wheel-events-with-no-delta.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/scrolling/wheel-events-with-no-delta.html.
  • tiled-drawing/simple-document-with-margin-tiles-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt.
  • tiled-drawing/simple-document-with-margin-tiles.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html.
  • tiled-drawing/tile-coverage-after-scroll-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt.
  • tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt.
  • tiled-drawing/tile-coverage-after-scroll-speculative.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html.
  • tiled-drawing/tile-coverage-after-scroll.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll.html.
  • tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt.
  • tiled-drawing/tile-coverage-scroll-to-bottom.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom.html.
  • tiled-drawing/tile-coverage-slow-scrolling-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt.
  • tiled-drawing/tile-coverage-slow-scrolling.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling.html.
  • tiled-drawing/tile-coverage-speculative-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt.
  • tiled-drawing/tile-coverage-speculative.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html.
  • tiled-drawing/tile-size-slow-zoomed-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt.
  • tiled-drawing/tile-size-slow-zoomed.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html.
  • tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration-expected.txt.
  • tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html.
  • tiled-drawing/tiled-drawing-zoom-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt.
  • tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt.
  • tiled-drawing/tiled-drawing-zoom-scrolled.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html.
  • tiled-drawing/tiled-drawing-zoom.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html.
  • tiled-drawing/toggle-to-fixed-background-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/toggle-to-fixed-background-expected.txt.
  • tiled-drawing/toggle-to-fixed-background.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/toggle-to-fixed-background.html.
  • tiled-drawing/top-content-inset-fixed-attachment-body-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-body-expected.html.
  • tiled-drawing/top-content-inset-fixed-attachment-body.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-body.html.
  • tiled-drawing/top-content-inset-fixed-attachment-cover-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover-expected.html.
  • tiled-drawing/top-content-inset-fixed-attachment-cover-local-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover-local-expected.html.
  • tiled-drawing/top-content-inset-fixed-attachment-cover-local.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover-local.html.
  • tiled-drawing/top-content-inset-fixed-attachment-cover.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-cover.html.
  • tiled-drawing/top-content-inset-fixed-attachment-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-expected.html.
  • tiled-drawing/top-content-inset-fixed-attachment-local-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-local-expected.html.
  • tiled-drawing/top-content-inset-fixed-attachment-local.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-local.html.
  • tiled-drawing/top-content-inset-fixed-attachment-positioned-expected.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-positioned-expected.html.
  • tiled-drawing/top-content-inset-fixed-attachment-positioned.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment-positioned.html.
  • tiled-drawing/top-content-inset-fixed-attachment.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/top-content-inset-fixed-attachment.html.
  • tiled-drawing/use-tiled-drawing-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt.
  • tiled-drawing/use-tiled-drawing.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/use-tiled-drawing.html.
  • tiled-drawing/visible-rect-content-inset-expected.txt: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/visible-rect-content-inset-expected.txt.
  • tiled-drawing/visible-rect-content-inset.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html.
  • tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html.
  • tiled-drawing/window-server-snapshots-work.html: Renamed from LayoutTests/platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html.
3:52 PM Changeset in webkit [187904] by Simon Fraser
  • 3 edits
    92 moves
    1 add in trunk/LayoutTests

Move /platform/ios-simulator/accessibility tests to accessibility/ios-simulator/

  • TestExpectations:
  • accessibility/ios-simulator/accessibility-aria-table-children-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/accessibility-aria-table-children-expected.txt.
  • accessibility/ios-simulator/accessibility-aria-table-children.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/accessibility-aria-table-children.html.
  • accessibility/ios-simulator/accessibility-crash-in-axcontainer-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/accessibility-crash-in-axcontainer-expected.txt.
  • accessibility/ios-simulator/accessibility-crash-in-axcontainer.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/accessibility-crash-in-axcontainer.html.
  • accessibility/ios-simulator/accessibility-hint-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/accessibility-hint-expected.txt.
  • accessibility/ios-simulator/accessibility-hint.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/accessibility-hint.html.
  • accessibility/ios-simulator/aria-label-with-internal-text-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/aria-label-with-internal-text-expected.txt.
  • accessibility/ios-simulator/aria-label-with-internal-text.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/aria-label-with-internal-text.html.
  • accessibility/ios-simulator/aria-pressed-state-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/aria-pressed-state-expected.txt.
  • accessibility/ios-simulator/aria-pressed-state.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/aria-pressed-state.html.
  • accessibility/ios-simulator/centerpoint-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/centerpoint-expected.txt.
  • accessibility/ios-simulator/centerpoint.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/centerpoint.html.
  • accessibility/ios-simulator/disabled-states-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/disabled-states-expected.txt.
  • accessibility/ios-simulator/disabled-states.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/disabled-states.html.
  • accessibility/ios-simulator/dom-focus-fires-on-correct-element-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/dom-focus-fires-on-correct-element-expected.txt.
  • accessibility/ios-simulator/dom-focus-fires-on-correct-element.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/dom-focus-fires-on-correct-element.html.
  • accessibility/ios-simulator/element-paths-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/element-paths-expected.txt.
  • accessibility/ios-simulator/element-paths.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/element-paths.html.
  • accessibility/ios-simulator/file-upload-button-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/file-upload-button-expected.txt.
  • accessibility/ios-simulator/file-upload-button.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/file-upload-button.html.
  • accessibility/ios-simulator/focus-change-notifications-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/focus-change-notifications-expected.txt.
  • accessibility/ios-simulator/focus-change-notifications.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/focus-change-notifications.html.
  • accessibility/ios-simulator/header-elements-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/header-elements-expected.txt.
  • accessibility/ios-simulator/header-elements.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/header-elements.html.
  • accessibility/ios-simulator/identifier-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/identifier-expected.txt.
  • accessibility/ios-simulator/identifier.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/identifier.html.
  • accessibility/ios-simulator/iframe-access-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/iframe-access-expected.txt.
  • accessibility/ios-simulator/iframe-access.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/iframe-access.html.
  • accessibility/ios-simulator/internal-link-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/internal-link-expected.txt.
  • accessibility/ios-simulator/internal-link.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/internal-link.html.
  • accessibility/ios-simulator/landmark-type-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/landmark-type-expected.txt.
  • accessibility/ios-simulator/landmark-type.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/landmark-type.html.
  • accessibility/ios-simulator/link-with-images-text-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/link-with-images-text-expected.txt.
  • accessibility/ios-simulator/link-with-images-text.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/link-with-images-text.html.
  • accessibility/ios-simulator/link-with-only-image-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/link-with-only-image-expected.txt.
  • accessibility/ios-simulator/link-with-only-image.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/link-with-only-image.html.
  • accessibility/ios-simulator/math-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/math-expected.txt.
  • accessibility/ios-simulator/math.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/math.html.
  • accessibility/ios-simulator/mixed-checkboxes-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/mixed-checkboxes-expected.txt.
  • accessibility/ios-simulator/mixed-checkboxes.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/mixed-checkboxes.html.
  • accessibility/ios-simulator/no-child-link-header-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/no-child-link-header-expected.txt.
  • accessibility/ios-simulator/no-child-link-header.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/no-child-link-header.html.
  • accessibility/ios-simulator/non-contiguous-link-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/non-contiguous-link-expected.txt.
  • accessibility/ios-simulator/non-contiguous-link.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/non-contiguous-link.html.
  • accessibility/ios-simulator/out-of-bounds-child-access-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/out-of-bounds-child-access-expected.txt.
  • accessibility/ios-simulator/out-of-bounds-child-access.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/out-of-bounds-child-access.html.
  • accessibility/ios-simulator/password-value-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/password-value-expected.txt.
  • accessibility/ios-simulator/password-value.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/password-value.html.
  • accessibility/ios-simulator/placeholder-value-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/placeholder-value-expected.txt.
  • accessibility/ios-simulator/placeholder-value.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/placeholder-value.html.
  • accessibility/ios-simulator/popup-button-value-label-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/popup-button-value-label-expected.txt.
  • accessibility/ios-simulator/popup-button-value-label.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/popup-button-value-label.html.
  • accessibility/ios-simulator/progressbar-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/progressbar-expected.txt.
  • accessibility/ios-simulator/progressbar.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/progressbar.html.
  • accessibility/ios-simulator/radio-button-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/radio-button-expected.txt.
  • accessibility/ios-simulator/radio-button.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/radio-button.html.
  • accessibility/ios-simulator/scroll-in-overflow-div-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/scroll-in-overflow-div-expected.txt.
  • accessibility/ios-simulator/scroll-in-overflow-div.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/scroll-in-overflow-div.html.
  • accessibility/ios-simulator/secure-text-field-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/secure-text-field-expected.txt.
  • accessibility/ios-simulator/secure-text-field.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/secure-text-field.html.
  • accessibility/ios-simulator/selected-buttons-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/selected-buttons-expected.txt.
  • accessibility/ios-simulator/selected-buttons.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/selected-buttons.html.
  • accessibility/ios-simulator/selected-text-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/selected-text-expected.txt.
  • accessibility/ios-simulator/selected-text.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/selected-text.html.
  • accessibility/ios-simulator/spinbutton-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/spinbutton-expected.txt.
  • accessibility/ios-simulator/spinbutton.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/spinbutton.html.
  • accessibility/ios-simulator/svg-group-element-with-title-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/svg-group-element-with-title-expected.txt.
  • accessibility/ios-simulator/svg-group-element-with-title.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/svg-group-element-with-title.html.
  • accessibility/ios-simulator/svg-path-crash-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/svg-path-crash-expected.txt.
  • accessibility/ios-simulator/svg-path-crash.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/svg-path-crash.html.
  • accessibility/ios-simulator/tab-role-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/tab-role-expected.txt.
  • accessibility/ios-simulator/tab-role.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/tab-role.html.
  • accessibility/ios-simulator/table-cell-for-row-col-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/table-cell-for-row-col-expected.txt.
  • accessibility/ios-simulator/table-cell-for-row-col.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/table-cell-for-row-col.html.
  • accessibility/ios-simulator/table-cell-ranges-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/table-cell-ranges-expected.txt.
  • accessibility/ios-simulator/table-cell-ranges.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/table-cell-ranges.html.
  • accessibility/ios-simulator/tables-lists-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/tables-lists-expected.txt.
  • accessibility/ios-simulator/tables-lists.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/tables-lists.html.
  • accessibility/ios-simulator/text-line-no-ignored-elements-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-line-no-ignored-elements-expected.txt.
  • accessibility/ios-simulator/text-line-no-ignored-elements.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-line-no-ignored-elements.html.
  • accessibility/ios-simulator/text-marker-list-item-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-marker-list-item-expected.txt.
  • accessibility/ios-simulator/text-marker-list-item.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-marker-list-item.html.
  • accessibility/ios-simulator/text-marker-validation-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-marker-validation-expected.txt.
  • accessibility/ios-simulator/text-marker-validation.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-marker-validation.html.
  • accessibility/ios-simulator/text-role-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-role-expected.txt.
  • accessibility/ios-simulator/text-role.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/text-role.html.
  • accessibility/ios-simulator/textfield-in-axvalue-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/textfield-in-axvalue-expected.txt.
  • accessibility/ios-simulator/textfield-in-axvalue.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/textfield-in-axvalue.html.
  • accessibility/ios-simulator/toggle-button-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/toggle-button-expected.txt.
  • accessibility/ios-simulator/toggle-button.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/toggle-button.html.
  • accessibility/ios-simulator/url-test-expected.txt: Renamed from LayoutTests/platform/ios-simulator/accessibility/url-test-expected.txt.
  • accessibility/ios-simulator/url-test.html: Renamed from LayoutTests/platform/ios-simulator/accessibility/url-test.html.
  • platform/ios-simulator/TestExpectations:
3:50 PM Changeset in webkit [187903] by commit-queue@webkit.org
  • 4 edits in trunk

Improve some LayoutTests/inspector flakey output for tests with InspectorTest.reloadPage
​https://bugs.webkit.org/show_bug.cgi?id=147655

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-08-04
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Base/Test.js:

(InspectorTest.reloadPage):
Immediately mark the page as reloading so that any logs that may happen
before the callback for PageAgent.reload wait to be sent after the page
load. What was happening in flakey results was that the logs were
happening before this callback, and therefore getting logged and then
resent after page load and getting relogged.

LayoutTests:

3:48 PM Changeset in webkit [187902] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Existing text after completions do not have their completion style removed once hint is applied
​https://bugs.webkit.org/show_bug.cgi?id=147536

Reviewed by Timothy Hatcher.

No longer applies a class to the text after the completion hint.

  • UserInterface/Controllers/CodeMirrorCompletionController.css:

(.CodeMirror .CodeMirror-lines .completion-hint):

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.clearMarker):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):

3:47 PM Changeset in webkit [187901] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

3:46 PM Changeset in webkit [187900] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't show 'Reveal In Debugger Tab' menu item if already in Debugger tab
​https://bugs.webkit.org/show_bug.cgi?id=147554

Reviewed by Timothy Hatcher.

Check current tab before appending context menu items.

  • UserInterface/Base/Main.js:

(WebInspector.isShowingDebuggerTab):

  • UserInterface/Views/SourceCodeTextEditor.js:
3:45 PM Changeset in webkit [187899] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: buttons in new tab screen lack hover styles
​https://bugs.webkit.org/show_bug.cgi?id=145355

Reviewed by Timothy Hatcher.

Added hover brightness filter to new tab buttons.

  • UserInterface/Views/NewTabContentView.css:

(.new-tab.tab.content-view > .tab-item:not(.disabled):hover > .box):
(.new-tab.tab.content-view > .tab-item:not(.disabled):active > .box):

3:45 PM Changeset in webkit [187898] by mdaiter@apple.com
  • 3 edits in trunk/Source/WebCore

Added buffer to AVMediaCaptureSource
​https://bugs.webkit.org/show_bug.cgi?id=147454
<rdar://problem/22079502>

Reviewed by Jer Noble.

  • platform/mediastream/mac/AVMediaCaptureSource.h:

(WebCore::AVMediaCaptureSource::buffer):
(WebCore::AVMediaCaptureSource::setBuffer):

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):

3:40 PM Changeset in webkit [187897] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: Object previews for SVG elements shows SVGAnimatedString instead of text
​https://bugs.webkit.org/show_bug.cgi?id=147328

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-08-04
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/InjectedScriptSource.js:

Use classList and classList.toString instead of className.

LayoutTests:

  • inspector/model/remote-object-expected.txt:
  • inspector/model/remote-object.html:
3:36 PM Changeset in webkit [187896] by mdaiter@apple.com
  • 2 edits in trunk/Source/WebCore

Needless assignment of usingDot
​https://bugs.webkit.org/show_bug.cgi?id=147514

Reviewed by Eric Carlson.

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

3:32 PM Changeset in webkit [187895] by Devin Rousso
  • 13 edits
    1 copy
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Merge the styles sidebar navigation bar into a selectable item in the elements sidebar
​https://bugs.webkit.org/show_bug.cgi?id=146878

Reviewed by Timothy Hatcher.

Replaced the default navigationItem of the CSSStyleDetailsSidebarPanel with a
ScopeRadioButtonNavigationItem that will open a select element containing the labels
of each style sidebar when reselected.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._panelMatchingIdentifier):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._handleSelectedItemChanged):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.visibilityDidChange):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._navigationItemSelected): Deleted.

  • UserInterface/Views/DOMDetailsSidebarPanel.js:

(WebInspector.DOMDetailsSidebarPanel):

  • UserInterface/Views/DetailsSidebarPanel.js:

(WebInspector.DetailsSidebarPanel):

  • UserInterface/Views/MetricsStyleDetailsPanel.js:

(WebInspector.MetricsStyleDetailsPanel):

  • UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype._mouseDown):

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel):

  • UserInterface/Views/ScopeRadioButtonNavigationItem.css: Added.
  • UserInterface/Views/ScopeRadioButtonNavigationItem.js: Added.
  • UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):

  • UserInterface/Views/StyleDetailsPanel.js:

(WebInspector.StyleDetailsPanel):

3:17 PM Changeset in webkit [187894] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix Windows build after r187886.

  • Plugins/PluginStream.h:

Befriend PluginView.

2:47 PM Changeset in webkit [187893] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

shouldParseTelephoneNumbersInNode() does not need to check for Comment nodes
​https://bugs.webkit.org/show_bug.cgi?id=147630

Reviewed by Sam Weinig.

shouldParseTelephoneNumbersInNode() does not need to check for Comment
nodes. We already know the input is a ContainerNode and a Comment is
NOT a ContainerNode. Also, we were already doing a isElementNode()
check before calling disallowTelephoneNumberParsing().

I also updated the function to use a for loop for clarity and dropped
the isElementNode() check as calling hasTagName() / isLink() on a
ContainerNode is as fast all calling it on an Element nowadays.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::disallowTelephoneNumberParsing):
(WebCore::shouldParseTelephoneNumbersInNode):

2:46 PM Changeset in webkit [187892] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

[Mac] Do not require a video track for AirPlay
​https://bugs.webkit.org/show_bug.cgi?id=147647

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleReadyStateChange): Call updateWirelessTargetAvailable().
(Controller.prototype.updateHasVideo): Don't call updateWirelessTargetAvailable().
(Controller.prototype.updateWirelessTargetAvailable): Don't require video.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState): Call updateMediaState when we reach HAVE_METADATA.
(WebCore::HTMLMediaElement::mediaState): Don't require video, only that the file can play.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::showPlaybackTargetPicker): Check readyState instead of hasVideo.

2:41 PM Changeset in webkit [187891] by andersca@apple.com
  • 17 edits in trunk/Source

Get rid of ReasonForCallingAllowPlugins since it's not used anywhere
​https://bugs.webkit.org/show_bug.cgi?id=147648

Reviewed by Andreas Kling.

Source/WebCore:

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::rendererIsNeeded):

  • html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

  • loader/FrameLoaderTypes.h:
  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestPlugin):
(WebCore::SubframeLoader::createJavaAppletWidget):
(WebCore::SubframeLoader::allowPlugins):

  • loader/SubframeLoader.h:
  • plugins/DOMMimeType.cpp:

(WebCore::DOMMimeType::enabledPlugin):

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::getPluginInfo):

  • WebView/WebFrame.mm:

(-[WebFrame _canProvideDocumentSource]):

Source/WebKit/win:

  • WebView.cpp:

(WebView::canShowMIMEType):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPluginInfo):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
(WebKit::WebPage::canPluginHandleResponse):
(WebKit::WebPage::canShowMIMEType):

2:26 PM Changeset in webkit [187890] by Yusuke Suzuki
  • 23 edits
    3 adds in trunk

[ES6] Support Module Syntax
​https://bugs.webkit.org/show_bug.cgi?id=147422

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch introduces ES6 Modules syntax parsing part.
In this patch, ASTBuilder just produces the corresponding nodes to the ES6 Modules syntax,
and this patch does not include the code generator part.

Modules require 2 phase parsing. In the first pass, we just analyze the dependent modules
and do not execute the body or construct the AST. And after analyzing all the dependent
modules, we will parse the dependent modules next.
After all analyzing part is done, we will start the second pass. In the second pass, we
will parse the module, produce the AST, and execute the body.
If we don't do so, we need to create all the ASTs in the module's dependent graph at first
because the given module can be executed after the all dependent modules are executed. It
means that we need to hold so many parser arenas. To avoid this, the first pass only extracts
the dependent modules' information.

In this patch, we don't add this analyzing part yet. This patch only implements the second pass.
This patch aims at just implementing the syntax parsing functionality correctly.
After this patch is landed, we will create the ModuleDependencyAnalyzer that inherits SyntaxChecker
to collect the dependent modules fast[1].

To test the parsing, we added the "checkModuleSyntax" function into jsc shell.
By using this, we can parse the given string as the module.

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=147353

  • bytecompiler/NodesCodegen.cpp:

(JSC::ModuleProgramNode::emitBytecode):
(JSC::ImportDeclarationNode::emitBytecode):
(JSC::ExportAllDeclarationNode::emitBytecode):
(JSC::ExportDefaultDeclarationNode::emitBytecode):
(JSC::ExportLocalDeclarationNode::emitBytecode):
(JSC::ExportNamedDeclarationNode::emitBytecode):

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionCheckModuleSyntax):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createModuleSpecifier):
(JSC::ASTBuilder::createImportSpecifier):
(JSC::ASTBuilder::createImportSpecifierList):
(JSC::ASTBuilder::appendImportSpecifier):
(JSC::ASTBuilder::createImportDeclaration):
(JSC::ASTBuilder::createExportAllDeclaration):
(JSC::ASTBuilder::createExportDefaultDeclaration):
(JSC::ASTBuilder::createExportLocalDeclaration):
(JSC::ASTBuilder::createExportNamedDeclaration):
(JSC::ASTBuilder::createExportSpecifier):
(JSC::ASTBuilder::createExportSpecifierList):
(JSC::ASTBuilder::appendExportSpecifier):

  • parser/Keywords.table:
  • parser/NodeConstructors.h:

(JSC::ModuleSpecifierNode::ModuleSpecifierNode):
(JSC::ImportSpecifierNode::ImportSpecifierNode):
(JSC::ImportDeclarationNode::ImportDeclarationNode):
(JSC::ExportAllDeclarationNode::ExportAllDeclarationNode):
(JSC::ExportDefaultDeclarationNode::ExportDefaultDeclarationNode):
(JSC::ExportLocalDeclarationNode::ExportLocalDeclarationNode):
(JSC::ExportNamedDeclarationNode::ExportNamedDeclarationNode):
(JSC::ExportSpecifierNode::ExportSpecifierNode):

  • parser/Nodes.cpp:

(JSC::ModuleProgramNode::ModuleProgramNode):

  • parser/Nodes.h:

(JSC::ModuleProgramNode::startColumn):
(JSC::ModuleProgramNode::endColumn):
(JSC::ModuleSpecifierNode::moduleName):
(JSC::ImportSpecifierNode::importedName):
(JSC::ImportSpecifierNode::localName):
(JSC::ImportSpecifierListNode::specifiers):
(JSC::ImportSpecifierListNode::append):
(JSC::ImportDeclarationNode::specifierList):
(JSC::ImportDeclarationNode::moduleSpecifier):
(JSC::ExportAllDeclarationNode::moduleSpecifier):
(JSC::ExportDefaultDeclarationNode::declaration):
(JSC::ExportLocalDeclarationNode::declaration):
(JSC::ExportSpecifierNode::exportedName):
(JSC::ExportSpecifierNode::localName):
(JSC::ExportSpecifierListNode::specifiers):
(JSC::ExportSpecifierListNode::append):
(JSC::ExportNamedDeclarationNode::specifierList):
(JSC::ExportNamedDeclarationNode::moduleSpecifier):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseModuleSourceElements):
(JSC::Parser<LexerType>::parseVariableDeclaration):
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::tryParseDestructuringPatternExpression):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClassDeclaration):
(JSC::Parser<LexerType>::parseModuleSpecifier):
(JSC::Parser<LexerType>::parseImportClauseItem):
(JSC::Parser<LexerType>::parseImportDeclaration):
(JSC::Parser<LexerType>::parseExportSpecifier):
(JSC::Parser<LexerType>::parseExportDeclaration):
(JSC::Parser<LexerType>::parseMemberExpression):

  • parser/Parser.h:

(JSC::isIdentifierOrKeyword):
(JSC::ModuleScopeData::create):
(JSC::ModuleScopeData::exportedBindings):
(JSC::ModuleScopeData::exportName):
(JSC::ModuleScopeData::exportBinding):
(JSC::Scope::Scope):
(JSC::Scope::setIsModule):
(JSC::Scope::moduleScopeData):
(JSC::Parser::matchContextualKeyword):
(JSC::Parser::matchIdentifierOrKeyword):
(JSC::Parser::isofToken): Deleted.

  • parser/ParserModes.h:
  • parser/ParserTokens.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createModuleSpecifier):
(JSC::SyntaxChecker::createImportSpecifier):
(JSC::SyntaxChecker::createImportSpecifierList):
(JSC::SyntaxChecker::appendImportSpecifier):
(JSC::SyntaxChecker::createImportDeclaration):
(JSC::SyntaxChecker::createExportAllDeclaration):
(JSC::SyntaxChecker::createExportDefaultDeclaration):
(JSC::SyntaxChecker::createExportLocalDeclaration):
(JSC::SyntaxChecker::createExportNamedDeclaration):
(JSC::SyntaxChecker::createExportSpecifier):
(JSC::SyntaxChecker::createExportSpecifierList):
(JSC::SyntaxChecker::appendExportSpecifier):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

  • runtime/CommonIdentifiers.h:
  • runtime/Completion.cpp:

(JSC::checkModuleSyntax):

  • runtime/Completion.h:
  • tests/stress/modules-syntax-error-with-names.js: Added.

(shouldThrow):

  • tests/stress/modules-syntax-error.js: Added.

(shouldThrow):
(checkModuleSyntaxError.checkModuleSyntaxError.checkModuleSyntaxError):

  • tests/stress/modules-syntax.js: Added.

(prototype.checkModuleSyntax):
(checkModuleSyntax):

  • tests/stress/tagged-templates-syntax.js:

LayoutTests:

'export' and 'import' are changed from FutureReservedWord to Keyword in ES6.
​http://www.ecma-international.org/ecma-262/6.0/#sec-keywords
And restrict 'super' use under the Script / Module contexts.

  • js/dom/reserved-words-as-property-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.10-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.16-expected.txt:
  • sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:
2:00 PM Changeset in webkit [187889] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix debug CMake build on Windows after r187818.

  • PlatformWin.cmake:

Debug *AllInOne.cpp object files in WebCore require /bigobj to compile successfully.

1:50 PM Changeset in webkit [187888] by Brian Burg
  • 3 edits in trunk/Tools

Unreviewed, update email addresses in contributors.json and watchlist.

  • Scripts/webkitpy/common/config/contributors.json:
  • Scripts/webkitpy/common/config/watchlist:
1:49 PM Changeset in webkit [187887] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: timeline overview should visually distinguish selection bounds outside the visible duration
​https://bugs.webkit.org/show_bug.cgi?id=132764

Reviewed by Brian Burg.

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .selection-handle.clamped):
Added style for selection handle outside visible range.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype._updateSelection):
Toggle style class and add tool tip showing the handle's value when outside the visible range.

1:48 PM Changeset in webkit [187886] by commit-queue@webkit.org
  • 44 edits
    5 adds in trunk

Implement NPAPI redirect handling
​https://bugs.webkit.org/show_bug.cgi?id=138675
rdar://problem/15779101

Patch by Jeffrey Pfau, updated and tweaked by me.

Patch by Alexey Proskuryakov <​ap@apple.com> on 2015-08-04
Reviewed by Anders Carlsson.

Source/WebCore:

Test: http/tests/plugins/get-url-redirect-notify.html

  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::init):
(WebCore::NetscapePlugInStreamLoader::willSendRequest):
(WebCore::NetscapePlugInStreamLoader::didReceiveResponse):

  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):
(WebCore::ResourceLoader::isSubresourceLoader):
(WebCore::ResourceLoader::willSendRequestInternal):
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):

  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::isSubresourceLoader):
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::willSendRequest): Deleted.

  • loader/SubresourceLoader.h:
  • plugins/npapi.h:
  • plugins/npfunctions.h:

Source/WebKit/mac:

  • Plugins/Hosted/HostedNetscapePluginStream.h:

(WebKit::HostedNetscapePluginStream::streamID):

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::didFinishLoading):
(WebKit::HostedNetscapePluginStream::willSendRequest):
(WebKit::HostedNetscapePluginStream::didReceiveResponse):

  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::stop):
(WebNetscapePluginStream::willSendRequest):
(WebNetscapePluginStream::didReceiveResponse):

Source/WebKit/win:

  • Plugins/PluginStream.cpp:

(WebCore::PluginStream::sendJavaScriptStream):
(WebCore::PluginStream::willSendRequest):
(WebCore::PluginStream::didReceiveResponse):

  • Plugins/PluginStream.h:

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::loadURL):
(WebKit::PluginControllerProxy::continueStreamLoad):
(WebKit::PluginControllerProxy::cancelStreamLoad):
(WebKit::PluginControllerProxy::didEvaluateJavaScript):
(WebKit::PluginControllerProxy::streamWillSendRequest):
(WebKit::PluginControllerProxy::streamDidReceiveResponse):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_ConvertPoint):
(WebKit::NPN_URLRedirectResponse):
(WebKit::initializeBrowserFuncs):
(WebKit::netscapeBrowserFuncs):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::getAuthenticationInfo):
(WebKit::NetscapePlugin::registerRedirect):
(WebKit::NetscapePlugin::urlRedirectResponse):
(WebKit::NetscapePlugin::setIsPlayingAudio):
(WebKit::NetscapePlugin::NPP_URLNotify):
(WebKit::NetscapePlugin::NPP_URLRedirectNotify):
(WebKit::NetscapePlugin::NPP_GetValue):
(WebKit::NetscapePlugin::didEvaluateJavaScript):
(WebKit::NetscapePlugin::streamWillSendRequest):
(WebKit::NetscapePlugin::streamDidReceiveResponse):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::~NetscapePluginStream):
(WebKit::NetscapePluginStream::willSendRequest):
(WebKit::NetscapePluginStream::didReceiveResponse):
(WebKit::NetscapePluginStream::stop):
(WebKit::NetscapePluginStream::setURL):
(WebKit::NetscapePluginStream::cancel):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:

(WebKit::NetscapePluginStream::streamID):
(WebKit::NetscapePluginStream::npStream):

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::didEvaluateJavaScript):
(WebKit::PluginProxy::streamWillSendRequest):
(WebKit::PluginProxy::streamDidReceiveResponse):
(WebKit::PluginProxy::setPluginIsPlayingAudio):
(WebKit::PluginProxy::continueStreamLoad):
(WebKit::PluginProxy::cancelStreamLoad):

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::streamID):
(WebKit::PluginView::Stream::Stream):
(WebKit::PluginView::Stream::cancel):
(WebKit::PluginView::Stream::continueLoad):
(WebKit::buildHTTPHeaders):
(WebKit::lastModifiedDateMS):
(WebKit::PluginView::Stream::willSendRequest):
(WebKit::PluginView::Stream::didReceiveResponse):
(WebKit::PluginView::cancelStreamLoad):
(WebKit::PluginView::continueStreamLoad):
(WebKit::PluginView::cancelManualStreamLoad):

  • WebProcess/Plugins/PluginView.h:

Tools:

  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:

(PluginTest::NPP_URLNotify):
(PluginTest::NPP_URLRedirectNotify):
(PluginTest::NPP_GetValue):
(PluginTest::NPN_GetURLNotify):
(PluginTest::NPN_PostURLNotify):
(PluginTest::NPN_GetValue):
(PluginTest::NPN_ReleaseVariantValue):
(PluginTest::NPN_URLRedirectResponse):
(PluginTest::NPN_ConvertPoint):

  • DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  • DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.

(URLRedirect::URLRedirect):
(URLRedirect::ScriptableObject::hasMethod):
(URLRedirect::ScriptableObject::get):
(URLRedirect::ScriptableObject::serviceAsync):
(URLRedirect::ScriptableObject::invoke):
(URLRedirect::NPP_GetValue):
(URLRedirect::NPP_URLNotify):
(URLRedirect::NPP_URLRedirectNotify):

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NP_GetEntryPoints):
(NPP_URLNotify):
(NPP_URLRedirectNotify):
(NPP_GetValue):

LayoutTests:

  • http/tests/plugins/get-url-redirect-notify-expected.txt: Added.
  • http/tests/plugins/get-url-redirect-notify.html: Added.
  • platform/wk2/http/tests/plugins: Added.
  • platform/wk2/http/tests/plugins/get-url-redirect-notify-expected.txt: Added.
1:46 PM Changeset in webkit [187885] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

RenderTheme::paint() should take RenderBox instead of RenderObject.
​https://bugs.webkit.org/show_bug.cgi?id=147638

Reviewed by Andreas Kling.

No change in functionality.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::updateControlStatesForRenderer): ->RenderBox too.
(WebCore::RenderTheme::isActive): Remove redundant code.

  • rendering/RenderTheme.h:
1:39 PM Changeset in webkit [187884] by mdaiter@apple.com
  • 2 edits in trunk/Source/WebCore

Render to GraphicsContext MediaPlayerPrivateMediaStreamAVFObjC
​https://bugs.webkit.org/show_bug.cgi?id=147643

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paint):

1:29 PM Changeset in webkit [187883] by mdaiter@apple.com
  • 3 edits in trunk/Source/WebCore

Added ability to create images from buffers for MediaStream paint methods
​https://bugs.webkit.org/show_bug.cgi?id=147642

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createImageFromSampleBuffer):

1:29 PM Changeset in webkit [187882] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Move Matt Daiter to committers.

  • Scripts/webkitpy/common/config/contributors.json:
1:24 PM Changeset in webkit [187881] by mdaiter@apple.com
  • 2 edits in trunk/Source/WebCore

Add image variable rendered by paint methods for MediaStream
​https://bugs.webkit.org/show_bug.cgi?id=147645

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
1:11 PM Changeset in webkit [187880] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.8.10

New tag.

1:01 PM Changeset in webkit [187879] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/security/contentSecurityPolicy/source-list-parsing-10.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=147646

  • platform/win/TestExpectations: Skip failing test.
12:47 PM Changeset in webkit [187878] by Alan Bujtas
  • 11 edits in trunk/Source/WebCore

RenderTheme::baselinePosition() should take RenderBox instead of RenderObject.
​https://bugs.webkit.org/show_bug.cgi?id=147632

Reviewed by Andreas Kling.

It eliminates some redundant type checking and casting.

No change in functionality.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::baselinePosition):

  • platform/efl/RenderThemeEfl.h:
  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::baselinePosition):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::baselinePosition):

  • rendering/RenderThemeGtk.h:
  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::baselinePosition):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::baselinePosition):

  • rendering/RenderThemeSafari.h:
12:47 PM Changeset in webkit [187877] by msaboff@apple.com
  • 6 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Align callee save registers names across LLInt and JITs
​https://bugs.webkit.org/show_bug.cgi?id=147640

Reviewed by Basile Clement.

Added callee save register aliases to both the LLInt and JITs and set the aliases to
the same register. As a result, regCS0 in the JIT is the same as csr0 in the LLInt.
Some registers are unused in either the LLInt or JITs.

This is in preparation for properly handling callee save register restoration during exception
processing as all tiers are involved in the restoration process of all callee saves.

  • jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::allVMCalleeSaveRegisters):
(JSC::RegisterSet::baselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):

  • llint/LowLevelInterpreter.asm:
  • offlineasm/registers.rb:
  • offlineasm/x86.rb:
12:22 PM Changeset in webkit [187876] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187762. rdar://problem/22026864

12:11 PM Changeset in webkit [187875] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

Unreviewed, rolling out r187815 and r187817.
​https://bugs.webkit.org/show_bug.cgi?id=147644

Caused lots of Windows crashes (Requested by smfr on #webkit).

Reverted changesets:

"[WTF] Turn tryMakeString(), makeString() into variadic
templates"
​https://bugs.webkit.org/show_bug.cgi?id=147142
​http://trac.webkit.org/changeset/187815

"Unreviewed build fix."
​http://trac.webkit.org/changeset/187817

12:10 PM Changeset in webkit [187874] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
​https://bugs.webkit.org/show_bug.cgi?id=147636

Reviewed by Alex Christensen.

We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
on EWS machines)

  • Scripts/build-webkit:
12:10 PM Changeset in webkit [187873] by Brian Burg
  • 17 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes
​https://bugs.webkit.org/show_bug.cgi?id=147439

Reviewed by Joseph Pecoraro.

Along the way, inline a few style class names.

Elided mechanical changes from the Changelog.

  • UserInterface/Views/DOMTreeDataGrid.js:
  • UserInterface/Views/DataGrid.js:
  • UserInterface/Views/DatabaseTableContentView.js:
  • UserInterface/Views/IndexedDatabaseEntryDataGridNode.js:
  • UserInterface/Views/LayerTreeDataGridNode.js:
  • UserInterface/Views/LayoutTimelineDataGrid.js:
  • UserInterface/Views/LayoutTimelineDataGridNode.js:
  • UserInterface/Views/ProbeSetDataGrid.js:
  • UserInterface/Views/ProfileNodeDataGridNode.js:
  • UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
  • UserInterface/Views/ResourceTimelineDataGridNode.js:
  • UserInterface/Views/ScriptTimelineDataGrid.js:
  • UserInterface/Views/ScriptTimelineDataGridNode.js:
  • UserInterface/Views/SourceCodeTimelineTimelineDataGridNode.js:
  • UserInterface/Views/TimelineDataGrid.js:
  • UserInterface/Views/TimelineDataGridNode.js: Move a function definition out

of an else branch, since this is not allowed in ES6 strict mode.

11:57 AM Changeset in webkit [187872] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: console error when clicking AppCache folder tree element
​https://bugs.webkit.org/show_bug.cgi?id=130042

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/StorageSidebarPanel.js:

(WebInspector.StorageSidebarPanel._treeElementSelected): Don't try to
create a content view for ApplicationCacheManifestTreeElement. We can
only create a content view for AppCache frames.

11:48 AM Changeset in webkit [187871] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
​https://bugs.webkit.org/show_bug.cgi?id=147280

Patch by Jason Marcell <​jmarcell@apple.com> on 2015-08-04
Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
Refactored _parseData to handle repositories more generically.
(parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
"opensourceRevision" and "internalRevision".
(BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
parameter to more generic "repository" string parameter. Added "trac" parameter in order to
specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
and "internalRevision".
(BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
"opensourceRevision" and "internalRevision".

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding

constants for internal and opensource repositories.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:

(Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
instead of "opensourceRevision" and "internalRevision".
(Analyzer.prototype._countPercentageOfGreen): Ditto.
(Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
(Analyzer.prototype._countTimes): Ditto.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.

11:43 AM Changeset in webkit [187870] by bshafiei@apple.com
  • 5 edits in branches/safari-600.8-branch

Merged r186046. rdar://problem/22129193

11:38 AM Changeset in webkit [187869] by mark.lam@apple.com
  • 2 edits in trunk/Tools

Removed a local debugging line I accidentally left in from a previous commit.

Not Reviewed.

  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
11:30 AM Changeset in webkit [187868] by basile_clement@apple.com
  • 6 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: We should abortWithReason() if we ever return from a tail call
​https://bugs.webkit.org/show_bug.cgi?id=147634

Reviewed by Michael Saboff.

Previously, we were using a breakpoint in that case, but it really
should be an abortWithReason(). Note that this is mostly useful for the
slow path, since the fast path is always a jump - if we ever have a
slow path that does not perform the tail call, we have no idea in what
state the stack will be when we return here, and it would be dangerous
to continue executing (especially since the next instruction is
guaranteed to be a return).

  • assembler/AbortReason.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCallSlowCase):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCallSlowCase):

11:03 AM Changeset in webkit [187867] by mark.lam@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Make Saam Barati a WebKit reviewer.

  • Scripts/webkitpy/common/config/contributors.json:
10:48 AM Changeset in webkit [187866] by achristensen@apple.com
  • 11 edits
    1 add in trunk

Enable WebGL on Windows CMake build.
​https://bugs.webkit.org/show_bug.cgi?id=143311

Reviewed by Csaba Osztrogonác.

.:

  • Source/cmake/OptionsWindows.cmake:

Enable WebGL by default in CMake builds now that it works.

Source/ThirdParty/ANGLE:

  • CMakeLists.txt: Added.

Source/WebCore:

  • CMakeLists.txt:

ANGLE is built quite differently on Windows, so I'm not going to touch the existing CMake build system for
ANGLE on Linux, although I think it should eventually be unified more by using ANGLE's OpenGL renderer.

  • PlatformWin.cmake:

Added some needed source files and include directories.

Source/WebKit:

  • PlatformWin.cmake:

Added some needed source files and include directories.

Source/WTF:

  • wtf/FeatureDefines.h:

Made the CMake feature defines the same as the non-CMake feature defines.

10:12 AM Changeset in webkit [187865] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r187812.

This is not safe

Reverted changeset:

"[WK2] Reserve Vector capacity in VectorArgumentCoder<false,
T, inlineCapacity>::decode()"
​https://bugs.webkit.org/show_bug.cgi?id=147619
​http://trac.webkit.org/changeset/187812

10:09 AM Changeset in webkit [187864] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Implement isPictureInPictureInterrupted.
​https://bugs.webkit.org/show_bug.cgi?id=147620

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-08-04
Reviewed by Eric Carlson.

Implement isPictureInPictureInterrupted so setting the property to true pauses playback.
This allows PiP to pause when the device is locked while the app is suspended.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController init]):
(-[WebAVPlayerController isPictureInPictureInterrupted]):
(-[WebAVPlayerController setPictureInPictureInterrupted:]):

6:54 AM Changeset in webkit [187863] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r187364 - Networking process crash in NetworkConnectionToWebProcess::convertMainResourceLoadToDownload while attempting to download a blob
​https://bugs.webkit.org/show_bug.cgi?id=147276
rdar://problem/21423353

Reviewed by Andreas Kling.

We currently don't support downloading blobs, so for now just bail if we encounter a null loader inside
convertMainResourceLoadToDownload (which happens when trying to download a blob URL).

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didCleanupResourceLoader):
Rewrite the assertion to be more clear - it's fine to do an extra hash lookup in debug builds.

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
Bail if loader is null.

6:51 AM Changeset in webkit [187862] by Carlos Garcia Campos
  • 17 edits
    5 adds in releases/WebKitGTK/webkit-2.8/Source

Merge r187338 - [GStreamer] Crashes during plugin installation
​https://bugs.webkit.org/show_bug.cgi?id=144099

Reviewed by Philippe Normand.

Source/WebCore:

Add new methods to MediaPlayerClient and ChromeClient to request
the API layer to start the installer when there are missing media
plugins.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::requestInstallMissingPlugins): Pass
the request to the ChromeClient.

  • html/HTMLMediaElement.h:
  • page/ChromeClient.h:
  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::requestInstallMissingPlugins):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Invalidate any pending request to install missing media plugins.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): In case of
missing plugins message, start a request to install them if
supported by GST.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::create):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::MediaPlayerRequestInstallMissingPluginsCallback):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::invalidate):
(WebCore::MediaPlayerRequestInstallMissingPluginsCallback::complete):

Source/WebKit2:

Move the missing plugins installation to the UI process, ensuring
there's a single installer running and cancelling the request when
the page is closed or the media player is deleted.

  • PlatformEfl.cmake: Add new files to compilation.
  • PlatformGTK.cmake: Ditto.
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add

RequestInstallMissingMediaPlugins message.

  • UIProcess/gstreamer/WebPageProxyGStreamer.cpp: Added.

(WebKit::WebPageProxy::requestInstallMissingMediaPlugins): Call
gst_install_plugins_async() and send
DidEndRequestInstallMissingMediaPlugins message back to the web
process when done.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::requestInstallMissingMediaPlugins): Call
WebPage::requestInstallMissingMediaPlugins().

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close): Invalidate the install missing plugins
request callback.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in: Add

DidEndRequestInstallMissingMediaPlugins message.

  • WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp: Added.

(WebKit::WebPage::requestInstallMissingMediaPlugins): Send
RequestInstallMissingMediaPlugins to the UI process or complete
the request early if there's already a request in progress.
(WebKit::WebPage::didEndRequestInstallMissingMediaPlugins):
Complete the request.

6:50 AM Changeset in webkit [187861] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/bmalloc

Merge r187270 - bmalloc: Shrink the super chunk size (again)
​https://bugs.webkit.org/show_bug.cgi?id=147240

Reviewed by Andreas Kling.

Shrinking to 8MB reduced VM exhaustion crashes but did not eliminate them.
Let's try 4MB.

(My previous comment was that the maximum fast object was 2MB. But it
was 4MB! Now it's 2MB for realsies.)

  • bmalloc/Sizes.h:
6:32 AM Changeset in webkit [187860] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Tools

Merge r187218 - Unregistering and re-registering a user message handler does not work
​https://bugs.webkit.org/show_bug.cgi?id=138142

Reviewed by Martin Robinson.

This has probably been fixed in r184846, enable the test case
blocked on it.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:

(testUserContentManagerScriptMessageReceived):

6:26 AM Changeset in webkit [187859] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r187171 - [WinCairo] SVG path not rendered with all-zero dasharray
​https://bugs.webkit.org/show_bug.cgi?id=146997

Patch by Jinyoung Hur <​hur.ims@navercorp.com> on 2015-07-22
Reviewed by Martin Robinson.

Source/WebCore:

All-zero dash array should not be passed to cairo_set_dash() as an argument, because it will cause an internal Cairo error.
Rather call cairo_set_dash() with num_dashes=0 to disable dash line.

Tests: fast/canvas/canvas-lineDash.html

svg/custom/zero-dasharray.html

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setLineDash):

LayoutTests:

Canvas 2D context and SVG stroke tests with all-zero dash array are added.

  • fast/canvas/canvas-lineDash-expected.txt:
  • fast/canvas/script-tests/canvas-lineDash.js:
  • svg/custom/zero-dasharray.html: Added
  • svg/custom/zero-dasharray-expected.html: Added
6:24 AM Changeset in webkit [187858] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Source/WebCore:
Fix toJSDOMWindow() in the case of an object that has the actual JS DOM window in its prototype chain.
​https://bugs.webkit.org/show_bug.cgi?id=146785

Patch by Mark Dittmer <​mark.s.dittmer@gmail.com> on 2015-07-22
Reviewed by Mark Lam.

  • bindings/js/JSDOMWindowBase.cpp: toJSDOMWindow(): Walk the prototype chain of the given JSValue until a JSDOMWindow or JSDOMWindowShell is found.

LayoutTests:
New test: Object.create(window).location will trigger a crash when toJSDOMWindow() returns NULL on an object that have the JS DOM Window in its prototype chain.
​https://bugs.webkit.org/show_bug.cgi?id=146785

Patch by Mark Dittmer <​mark.s.dittmer@gmail.com> on 2015-07-22
Reviewed by Mark Lam.

  • js/property-of-window-as-prototype-expected.txt:
  • js/property-of-window-as-prototype.html:
6:20 AM Changeset in webkit [187857] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r187133 - StyleSheetContents::wrapperInsertRule() can create rules that overflow RuleData's selector index
​https://bugs.webkit.org/show_bug.cgi?id=147144

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-07-21
Reviewed by Alex Christensen.

Source/WebCore:

RuleData identifies selectors by the index in a large array. The index only has 13 bits
so rules with more than 8192 selectors should be split.

One of the paths was not splitting the rule: StyleSheetContents::wrapperInsertRule().
When rules with too many selectors were added, the index would overflow and
some RuleData would point to selectors in the middle of selector chains. The resulting
behavior is random based on the selectors and the DOM.

We cannot easily fix that because the CSS OM API do not expect to create
several rules in response to calls to the API.
In this patch, I don't do anything fancy and just let the calls fail
if we cannot use the rules safely.

Content Extensions were also running into this problem. Large Selector lists are
pretty common, and ContentExtensionStyleSheet::addDisplayNoneSelector() was
overflowing the RuleData, creating broken page.

Unlike CSSOM, there is no problem with splitting rules coming from Content Extensions.
Instead of creating new APIs for that case, I rely on the parser to extend the StyleSheetContents.
That code already knows how to break rules correctly.

Tests: fast/css/insert-rule-overflow-rule-data.html

http/tests/contentextensions/css-display-none-overflows-rule-data-1.html
http/tests/contentextensions/css-display-none-overflows-rule-data-2.html

  • contentextensions/ContentExtensionStyleSheet.cpp:

(WebCore::ContentExtensions::ContentExtensionStyleSheet::addDisplayNoneSelector):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::wrapperInsertRule):

LayoutTests:

This bug was affecting two parts of WebKit:
-In CSSOM, StyleSheet.insertRule() could create bogus rules.

The new test verifies that the call fails instead of creating undefined
behaviors.

-In ContentExtensions, large selectors are now working correctly. The tests

cover the case of a default stylesheet and an dynamic stylesheet.

  • fast/css/insert-rule-overflow-rule-data-expected.txt: Added.
  • fast/css/insert-rule-overflow-rule-data.html: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-1-expected.txt: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-1.html: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-1.html.json: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-2-expected.txt: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-2.html: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-2.html.json: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-3-expected.txt: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-3.html: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-3.html.json: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-4-expected.txt: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-4.html: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-4.html.json: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-5-expected.txt: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-5.html: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-5.html.json: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-6-expected.txt: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-6.html: Added.
  • http/tests/contentextensions/css-display-none-overflows-rule-data-6.html.json: Added.
6:06 AM Changeset in webkit [187856] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187128 - Placing video in fullscreen caused WebKit crash at WebCore::Range::textQuads
​https://bugs.webkit.org/show_bug.cgi?id=147166
<rdar://problem/21928558>

Reviewed by Simon Fraser.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::getClippedVisibleTextRectangles):
Check the Range, as always.

6:01 AM Changeset in webkit [187855] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.8

Merge r187121 - Safari mis-applies "animation-fill-mode: forwards" when using fractional iteration count
​https://bugs.webkit.org/show_bug.cgi?id=146996

Reviewed by Dean Jackson.
Source/WebCore:

animation-fill-mode: forwards with fractional iteration counts always snapped to
1 or 0, depending on direction. Fix to compute the fill-forward state from the
correct keyframes.

If filling forwards, AnimationBase::progress() sets the elapsed time to the duration,
then uses fractionalTime() to handle animation direction mapping. If the fractionalTime
is integral, we can return early, avoiding the cost of mapping through timing functions.

Tested by existing tests.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::progress):
(WebCore::AnimationBase::getElapsedTime):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): It was possible
to end up with prevIndex == nextIndex with reverse animations, which resulted
in divide-by-zero when computing scale. Fix by picking a nextIndex that is different
from prevIndex.

LayoutTests:

Progressions, improved tests.

  • animations/animation-direction-reverse-fill-mode-expected.txt: New results; this is a progression.
  • animations/animation-direction-reverse-fill-mode.html: Use a shorter animation. Fixed results.
  • animations/fill-mode-iteration-count-non-integer-expected.txt:
  • animations/fill-mode-iteration-count-non-integer.html: Use iteration counts that are not multiplies

of 0.5, so the test can differentiation between forward and backwards states. Add a non-linear timing
function to check that fill-forwards consults the timing functions. Don't print exact succeeding
results because they may have floating point values.

  • animations/fill-mode-reverse-expected.txt: New results; this is a progression.
  • animations/fill-mode-reverse.html: Fixed results, use gray.
5:58 AM Changeset in webkit [187854] by mario@webkit.org
  • 2 edits in trunk

[GTK] Accelerated 2D Canvas enabled when cairo-gl is not available
​https://bugs.webkit.org/show_bug.cgi?id=147625

Reviewed by Martin Robinson.

Do not set the CAIRO_<COMPONENT>_* CMake variables for cairo-gl
components unless they were actually found, not to accidentally
enable Accelerated 2D canvas, which would cause the build to fail.

  • Source/cmake/FindCairoGL.cmake: Set this variables only when

pkg_check_modules() had actually found the relevant component.

5:54 AM Changeset in webkit [187853] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r187115 - API::Session should clean up its storage in the network process when destroyed.
<​https://webkit.org/b/147139>
<rdar://problem/21838764>

Reviewed by Anders Carlsson.

Have ~Session() send a DestroyPrivateBrowsingSession message to all networking processes
for ephemeral sessions. This plugs a NetworkStorageSession leak that could retain a large
CFNetwork object graph.

  • UIProcess/API/APISession.cpp:

(API::Session::~Session):

5:52 AM Changeset in webkit [187852] by Carlos Garcia Campos
  • 6 edits
    1 delete in releases/WebKitGTK/webkit-2.8

Merge r187114 - Make PluginProxy::handleMouseEvent() asynchronous.
​https://bugs.webkit.org/show_bug.cgi?id=146142

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-07-21
Reviewed by Anders Carlsson.

PluginProxy::handleMouseEvent() forwards the generated mouse event to PluginControllerProxy
using a synchronous message, but the recipient always reply immediately with the same value("true")
even before handling the received message. So I think PluginProxy::handleMouseEvent() is perfectly
OK to process its messages asynchronously.

Source/WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::handleMouseEvent):

  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginControllerProxy.messages.in:
  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleMouseEvent):

LayoutTests:

platform/mac-wk2/plugins/mouse-events-expected.txt was introduced by webkit.org/b/116665 to avoid
flakey tests, but from now on we can share the common expectations.

  • platform/mac-wk2/plugins/mouse-events-expected.txt: Removed.
5:49 AM Changeset in webkit [187851] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187098 - Follow-up to my earlier fix for r147085
​https://bugs.webkit.org/show_bug.cgi?id=147085

Reviewed by Eric Carlson.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::isPlayingAudioDidChange):
Null-check document() before dereferencing it in case the audio context's document is destroyed
by the time the code block is called on the main thread.

5:47 AM Changeset in webkit [187850] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r187039 - REGRESSION (r174287): Flash of black when opening a new web view or navigating to a new page
​https://bugs.webkit.org/show_bug.cgi?id=147127
<rdar://problem/21474317>

Reviewed by Simon Fraser.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paintBoxDecorations):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotAtSize):
Avoid using an invalid documentBackgroundColor, fall back to baseBackgroundColor
like we did before r174287.

5:43 AM Changeset in webkit [187849] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187025 - Fix deadlock between -[AVPlayerItem currentTime] and -[AVPlayer isExternalPlaybackActive]
​https://bugs.webkit.org/show_bug.cgi?id=147085
<rdar://problem/21878275>

Reviewed by Jer Noble.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::isPlayingAudioDidChange):
Call Document::updateIsPlayingMedia() on the main thread, since we could be on the audio I/O
thread here and the Document::updateIsPlayingMedia() call could block, causing a deadlock.

5:40 AM Changeset in webkit [187848] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.8

Merge r187016 - new Date(NaN).toJSON() must return null instead of throwing a TypeError
​https://bugs.webkit.org/show_bug.cgi?id=141115

Patch by Jordan Harband <​ljharb@gmail.com> on 2015-07-19
Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToJSON):

LayoutTests:

  • js/dom/JSON-stringify-expected.txt:
  • js/resources/JSON-stringify.js:
5:31 AM WebKitGTK/2.8.x edited by mario@webkit.org
(diff)
5:29 AM Changeset in webkit [187847] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8

Merge r186987 - Bring back the GNU ar check to create thin archives on non-Linux systems
​https://bugs.webkit.org/show_bug.cgi?id=146681

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2015-07-17
Reviewed by Martin Robinson.

We already use GNU ar thin archive feature to save time and disk space
on creating static archives, but it is only enabled on Linux. Without
this feature, the debug build of WebCore can be larger than 4 GiB,
which can cause error because GNU ar format uses 32-bit integer to
store offsets in the symbol table. This patch is similar to
​https://bugs.webkit.org/show_bug.cgi?id=128596.

  • Source/cmake/OptionsCommon.cmake:
5:25 AM Changeset in webkit [187846] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r186984 - REGRESSION (r169105): Do not assign a renderer to multiple selection subtrees.
​https://bugs.webkit.org/show_bug.cgi?id=147038
rdar://problem/21819351

Reviewed by David Kilzer.

A renderer should never be assigned to multiple selection subtrees. (Currently RenderObject maintains the last selection state.)
RenderView::applySubtreeSelection() loops from the start to the end of the selection to find renderers that are inside the selection.
However, in case of regions (when multiple selection roots are present) traversing the renderer tree by calling RenderObject::nextInPreOrder() could
end up going across selection roots.
This patch ensures that we assign renderers to a specific selection only when the current selection root and the renderer's selection root match.

Source/WebCore:

Test: fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2.html

  • rendering/RenderView.cpp:

(WebCore::SelectionIterator::SelectionIterator):
(WebCore::SelectionIterator::current):
(WebCore::SelectionIterator::checkForSpanner):
(WebCore::RenderView::applySubtreeSelection):

LayoutTests:

  • fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2-expected.txt: Added.
  • fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2.html: Added.
5:23 AM Changeset in webkit [187845] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r186981 - (display: block)input range's thumb disappears when moved.
​https://bugs.webkit.org/show_bug.cgi?id=146896
<rdar://problem/21787807>

Reviewed by Simon Fraser.

Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
issued during the layout will not cover the re-positioned thumb.
We need to issue a repaint soon after the thumb is re-positioned.

Source/WebCore:

Test: fast/repaint/block-inputrange-repaint.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout):

LayoutTests:

  • fast/repaint/block-inputrange-repaint-expected.txt: Added.
  • fast/repaint/block-inputrange-repaint.html: Added.
5:20 AM Changeset in webkit [187844] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r186971 - style.fontFamily accessor crashes on unstyled node created from DOMParser().parseFromString()
​https://bugs.webkit.org/show_bug.cgi?id=147026
<rdar://problem/21864487>

Reviewed by Andreas Kling.

Source/WebCore:

Font CSS properties are a little special because they are used as indices into caches.
Normally, StyleResolver gives all nodes a default font family, so our cache works correctly.
However, if the document doesn't have a Settings object, StyleResolver wasn't doing this.
Documents created from DOMParser().parseFromString() don't have a Settings object.

Test: fast/text/crash-font-family-parsed.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::initializeFontStyle): Set a font family even if we don't have a
Settings object.

LayoutTests:

  • fast/text/crash-font-family-parsed-expected.txt: Added.
  • fast/text/crash-font-family-parsed.html: Added.
4:42 AM Changeset in webkit [187843] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r187580 - [GTK] Paste data is removed from clipboard when closing browser tab
​https://bugs.webkit.org/show_bug.cgi?id=144549

Reviewed by Martin Robinson.

GTK+ stores all clipboards in gtk_main or gtk_application_shutdown
when the main loop finishes. We don't use gtk_main() in the web
process, so we need to do the same and store all clipboards on
process shutdown.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::Pasteboard): Register the GtkClipboard.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::singleton): Make it destructible.
(WebCore::PasteboardHelper::~PasteboardHelper): Call
gtk_clipboard_store for every registered GtkClipboard.
(WebCore::PasteboardHelper::registerClipboard): Save the given
GtkClipboard.

  • platform/gtk/PasteboardHelper.h:
4:29 AM Changeset in webkit [187842] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.8/Source

Merge r186954 - [GTK] Cleanup PasteboardHelper
​https://bugs.webkit.org/show_bug.cgi?id=147035

Reviewed by Žan Doberšek.

Source/WebCore:

It's actually a singleton, but the API suggests you can create
your own or use the default one, but the default one should be the
only one. Rename PasteboardHelper::defaultPasteboardHelper() as
PasteboardHelper::singleton() and make it non-copyable and never
destroyed.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writePlainText): Use PasteboardHelper::singleton().
(WebCore::Pasteboard::write): Ditto.
(WebCore::Pasteboard::writePasteboard): Ditto.
(WebCore::Pasteboard::clear): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::read): Ditto.
(WebCore::Pasteboard::hasData): Ditto.
(WebCore::Pasteboard::types): Ditto.
(WebCore::Pasteboard::readString): Ditto.
(WebCore::Pasteboard::readFilenames): Ditto.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::singleton): Renamed as singleton, also
use NeverDestroyed and return a reference instead of a pointer.
(WebCore::PasteboardHelper::PasteboardHelper): Do all
initializations here and remove the initialization static flag,
since this is a real singleton now. Also use
gdk_atom_intern_static_string() to initialize the atoms instead of
gdk_atom_intern().
(WebCore::PasteboardHelper::targetList):
(WebCore::PasteboardHelper::targetListForDataObject):
(WebCore::getClipboardContentsCallback):

  • platform/gtk/PasteboardHelper.h:

Source/WebKit2:

Use PasteboardHelper::singleton() instead of
PasteboardHelper::defaultPasteboardHelper().

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseConstructed):

  • UIProcess/gtk/DragAndDropHandler.cpp:

(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::dataObjectForDropData):
(WebKit::DragAndDropHandler::requestDragData):

4:27 AM Changeset in webkit [187841] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r186911 - Fix disappearing position:fixed elements in fixed layout mode
​https://bugs.webkit.org/show_bug.cgi?id=147019

Reviewed by Tim Horton.
Source/WebCore:

Test: compositing/fixed-with-fixed-layout.html

When in fixed layout mode, and being scaled down, viewportConstrainedVisibleContentRect() is
the wrong thing to use to determine if position:fixed elements are clipped out. In this case,
use the simpler document bounds (before scaling).

In the long term, there needs to be an equivalent of viewportConstrainedVisibleContentRect()
that gives an appropriate rect that can be used here.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Test with four fixed elements in fixed layout mode.

  • compositing/fixed-with-fixed-layout-expected.txt: Added.
  • compositing/fixed-with-fixed-layout.html: Added.
4:19 AM Changeset in webkit [187840] by Andres Gomez
  • 1 edit
    1 add in trunk/Source/WebInspectorUI

[GTK] Add gtk icon to remove comma separated values from CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=147623

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/Minus.svg: Added.
4:16 AM Changeset in webkit [187839] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r186828 - Don't persist history item tree for subframes across reloads.
<​https://webkit.org/b/146937>
<rdar://problem/19925709>

Reviewed by Brady Eidson.

Throw away the subframe history items when reloading a page. This ensures that we
don't accumulate outdated frame metadata when subframes change name across page loads.
Since the history item tree is encoded in the UA session state and gets serialized to
disk, it's important that we don't let it grow unbounded.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForReload):

3:35 AM Changeset in webkit [187838] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r186761 - [GTK] Contents not correctly laid out when the web view is not realized
​https://bugs.webkit.org/show_bug.cgi?id=142532

Reviewed by Darin Adler.

The problem is that we are not reporting any size until the web
view is realized, so any web view loaded in a separate tab in the
browser, will report 0x0 as the window.innerWidth,
window.innerHeight until the view is realized. Websites that use
the window.innerWidth/innerHeight during the page load to decide
how to lay out the contents will be rendered wrongly.
I haven't been able to reproduce this with unit tests, as this
requires the particular case of same window but different web
views using tabs for example.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::viewSize): Always report the drawing area
size to make usre it's in sync with the WebProcess page size.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSizeAllocate): Remove the optimization of only
report the size when it has changed, since both the redirected
window and the drawing area already do that check. Also remove the
optimization of waiting until the view is mapped to report its
size, since that's often too late for websites using the window
size during load.
(webkitWebViewBaseMap): Never report size on map, it should have
already been reported by size-allocate.

2:57 AM Changeset in webkit [187837] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r186683 - Crash in HistoryController::updateForCommit dereferencing a null HistoryItem.
<rdar://problem/21371589> and ​https://bugs.webkit.org/show_bug.cgi?id=146842

Reviewed by Chris Dumez.

No new tests (Unknown how to reproduce).

This patch basically rolls back part of ​http://trac.webkit.org/changeset/179472.

r179472 changed HistoryController::setCurrentItem() to take a reference instead of a pointer.
Unfortunately, we sometimes call setCurrentItem(nullptr).

We'd like to *not* do that, and there are assertions in place to try to catch when we do,
but in the meantime it is not valid to dereference nullptr.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadSameDocumentItem):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::recursiveUpdateForCommit):
(WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
(WebCore::HistoryController::setCurrentItem): Take a ptr instead of a ref.
(WebCore::HistoryController::createItem):

  • loader/HistoryController.h:
2:55 AM Changeset in webkit [187836] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore/platform/gtk/po

Merge r186669, r187157 - Updated Swedish translation for WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=146596

Patch by Josef Andersson <​josef.andersson@fripost.org> on 2015-07-10
Reviewed by Carlos Garcia Campos.

  • sv.po:

[l10n] Updated Swedish translation
​https://bugs.webkit.org/show_bug.cgi?id=147190

Patch by Josef Andersson <​josef.andersson@fripost.org> on 2015-07-22

  • sv.po:
2:55 AM Changeset in webkit [187835] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r186666 - Plugin create can end up destroying its renderer.
​https://bugs.webkit.org/show_bug.cgi?id=146824
rdar://problem/18921429

Reviewed by Andreas Kling.

Plugins can run arbitrary code during initialization. If the plugin
happens to destroy the associated node, its renderer becomes invalid.
This patch checks whether the renderer survived the createPlugin() call.
(This WeakPtr pattern is also used in RenderWidget to avoid dangling pointers.)

Speculative fix. Not reproducible.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

2:51 AM Changeset in webkit [187834] by Carlos Garcia Campos
  • 5 edits
    12 adds in releases/WebKitGTK/webkit-2.8

Merge r186663 - Fetching Content Security Policy report URL should respect same origin policy
​https://bugs.webkit.org/show_bug.cgi?id=146754
<rdar://problem/18860259>

Reviewed by Brady Eidson.

Inspired by Blink r149791 (by Mike West <​mkwst@chromium.org>):
<​https://src.chromium.org/viewvc/blink?revision=149791&view=revision>

Source/WebCore:

As per <​http://www.w3.org/TR/2015/CR-CSP2-20150219/#send-violation-reports>, fetching the
Content Security Policy report URL should include cookies if and only if the origin of
the protected resource is equal to the origin of the report URL.

Tests: http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.html

http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled.html
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.html
http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled.html
http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled.html
http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies.html

  • loader/PingLoader.cpp:

(WebCore::PingLoader::sendViolationReport):

LayoutTests:

Added additional tests for private browsing mode.

  • http/tests/cookies/resources/setCookies.cgi:
  • http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.html: Added.
  • http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled.html: Added.
  • http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies.html: Added.
  • http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled.html: Added.
  • http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled.html: Added.
  • http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies.html: Added.
  • http/tests/security/contentSecurityPolicy/resources/save-report.php:
  • platform/wk2/TestExpectations: Skip private browsing mode tests in WebKit2 until we fix <​https://bugs.webkit.org/show_bug.cgi?id=115274>.
2:47 AM Changeset in webkit [187833] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r186653 - [GTK] Crash when spell checker returns no guesses
​https://bugs.webkit.org/show_bug.cgi?id=146805

Reviewed by Martin Robinson.

Properly handle ContextMenuItemTagNoGuessesFound in the switch statement.

  • UIProcess/API/gtk/WebKitContextMenuActions.cpp:

(webkitContextMenuActionGetForContextMenuItem):

2:45 AM Changeset in webkit [187832] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r186642, r186677 - DocumentLoader::detachFromFrame() is being called with no current Frame set.
<rdar://problem/21293082> and ​https://bugs.webkit.org/show_bug.cgi?id=146786

Reviewed by Sam Weinig.

No new tests (Unknown how to reproduce).

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::attachToFrame):
(WebCore::DocumentLoader::detachFromFrame): Null check m_frame before dereferencing it.
(WebCore::DocumentLoader::setFrame): Deleted, renamed to attachToFrame(), and take's

a Frame& instead of a Frame*.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::initForSynthesizedDocument): setFrame is now attachToFrame.
(WebCore::FrameLoader::setPolicyDocumentLoader): Ditto.
(WebCore::FrameLoader::transitionToCommitted): Ditto.

ASSERT restoring from page cache as DocumentLoader reattaches to its Frame.
<rdar://problem/21766282> and ​https://bugs.webkit.org/show_bug.cgi?id=146786

Reviewed by NOBODY (Fixing obvious boneheaded mistake in r186642)

No new tests (Covered by existing)

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::attachToFrame): Bail if reattaching to the current Frame,

which happens when restoring from the page cache.

2:40 AM Changeset in webkit [187831] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r186606 - REGRESSION (r180248): Repro Crash: com.apple.WebKit.WebContent at com.apple.JavaScriptCore: JSC::createRangeError + 20
​https://bugs.webkit.org/show_bug.cgi?id=146767

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

If the stack check fails at the top most frame, we must use that frame to
generate the exception. Reverted the code to always use the current frame to
throw an out of stack exception.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

LayoutTests:

New test that generates a call to a function that involves creating a huge
object literal that exceeds the available stack space.

  • http/tests/misc/large-js-program-expected.txt: Added.
  • http/tests/misc/large-js-program.php: Added.
2:33 AM Changeset in webkit [187830] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r186592 - REGRESSION (r182866): repeated prompts for password on internal Apple website using workers
​https://bugs.webkit.org/show_bug.cgi?id=146769

Reviewed by Sam Weinig.

Not sure how to make a regression test for this. Sure would be nice to have one though.

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions): Added. Calls through to the
base class copy constructor to copy data members of the base class (the lack of this was
the bug). Also initializes all the data members of this class.
(WebCore::ThreadableLoaderOptions::isolatedCopy): Changed to call the constructor above.

  • loader/ThreadableLoader.h: Added new constructor.
2:23 AM Changeset in webkit [187829] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r186581 - [GTK] The "Missing Plug-in" buttons are not showing up on some flash contents.
​https://bugs.webkit.org/show_bug.cgi?id=146707

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-07-08
Reviewed by Martin Robinson.

Currently, WebKitGTK+ doesn't show the "Missing Plug-in" buttons if the plugin-related tags
don't have a "type" attribute. In such a case, WebCore tries to guess the MIME type from
the extensions by using MIMETypeRegistry::getMIMETypeForExtension(). For WebKitGTK+,
MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple
array of <extension, mime type>, looking for the mime type for the given extension.
But |extensionMap| in MIMETypeRegistryGtk.cpp doesn't have the information for ".swf",
so WebCore fails to guess the MIME type and regard the content type as ObjectContentFrame,
not ObjectContentNetscapePlugin.

  • platform/gtk/MIMETypeRegistryGtk.cpp:
2:20 AM Changeset in webkit [187828] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8

Merge r186570 - Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
​https://bugs.webkit.org/show_bug.cgi?id=146546

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-07-08
Reviewed by Darin Adler.

We did't reset pendingNavigationID value when request url is empty.
Hence we need to ignore ASSERT check in this case.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reload):

Tools:

  • TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:

(TestWebKitAPI::TEST):

2:15 AM Changeset in webkit [187827] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r186541 - Crash when appending an SVG <use> element dynamically which has animated SVG <path> element
​https://bugs.webkit.org/show_bug.cgi?id=146690
<rdar://problem/20790376>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-07-08
Reviewed by Dean Jackson.

Source/WebCore:

Test: svg/animations/insert-animate-use-path-while-animation.svg

The crashing call stack shows that
SVGAnimatedListPropertyTearOff<SVGPathSegList>::m_animVal is null when
trying to access it in synchronizeWrappersIfNeeded(). This happens because
animationStarted() was not called for this animatedType.

SVGAnimateElementBase::resetAnimatedType() calls
SVGAnimatedPathAnimator::startAnimValAnimation() at the beginning of the
animation. For the target element and all its instances, this function calls
SVGAnimatedPathSegListPropertyTearOff::animationStarted() which calls
SVGAnimatedListPropertyTearOff<SVGPathSegList>::animationStarted(). This
last function allocates the member m_animVal when calling
SVGAnimatedListPropertyTearOff<SVGPathSegList>::animVal().

When adding a new instance of the same animating target element,
SVGAnimateElementBase::resetAnimatedType() just keeps calling
SVGAnimatedPathAnimator::animValDidChange() for all the instances of the
targetElement without ensuring that all of them have started their
animations.

The fix is to make SVGAnimatedPathAnimator::resetAnimValToBaseVal() ensure
that animationStarted() is called for the targetElement and all its instances.

  • svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation): Move resetting
the animation value and starting the animatedTypes code to a new overriding
function which is named resetAnimValToBaseVal().

(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal): Call the overriding
function which calls buildSVGPathByteStreamFromSVGPathSegList() as before
and ensure that all the animatedTypes have started their animations.

  • svg/SVGAnimatedPath.h:

LayoutTests:

When adding dynamically a new <use> element which references an animated
SVG path after the animation starts, ensure that WebKit is not crashing.

  • svg/animations/insert-animate-use-path-while-animation-expected.txt: Added.
  • svg/animations/insert-animate-use-path-while-animation.svg: Added.
1:47 AM Changeset in webkit [187826] by calvaris@igalia.com
  • 2 edits in trunk/Tools

Unreviewed, updated Streams API watchlist.

  • Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
12:01 AM Changeset in webkit [187825] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Merge r187691. rdar://problem/22060183

12:01 AM Changeset in webkit [187824] by matthew_hanson@apple.com
  • 3 edits
    3 adds in branches/safari-601.1-branch

Merge r187685. rdar://problem/21775336

12:01 AM Changeset in webkit [187823] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit/mac

Merge r187669. rdar://problem/16839069

12:01 AM Changeset in webkit [187822] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187545. rdar://problem/21893047

12:01 AM Changeset in webkit [187821] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187536. rdar://problem/21893047

12:01 AM Changeset in webkit [187820] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187534. rdar://problem/21893047

Aug 3, 2015:

11:51 PM Changeset in webkit [187819] by Csaba Osztrogonác
  • 35 edits in trunk/Source

Introduce COMPILER(GCC_OR_CLANG) guard and make COMPILER(GCC) true only for GCC
​https://bugs.webkit.org/show_bug.cgi?id=146833

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • assembler/ARM64Assembler.h:
  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

  • assembler/MacroAssemblerARM.cpp:

(JSC::isVFPPresent):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::isSSE2Present):

  • heap/MachineStackMarker.h:
  • interpreter/StackVisitor.cpp: Removed redundant COMPILER(CLANG) guards.

(JSC::logF):

  • jit/HostCallReturnValue.h:
  • jit/JIT.h:
  • jit/JITOperations.cpp:
  • jit/JITStubsARM.h:
  • jit/JITStubsARMv7.h:
  • jit/JITStubsX86.h:
  • jit/JITStubsX86Common.h:
  • jit/JITStubsX86_64.h:
  • jit/ThunkGenerators.cpp:
  • runtime/JSExportMacros.h:
  • runtime/MathCommon.h: Removed redundant COMPILER(CLANG) guard.

(JSC::clz32):

Source/WebCore:

  • platform/graphics/cpu/arm/filters/FELightingNEON.cpp:
  • platform/graphics/cpu/arm/filters/FELightingNEON.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApply):

  • platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):

Source/WTF:

  • wtf/Assertions.cpp:
  • wtf/Assertions.h: Removed redundant COMPILER(CLANG) guard.
  • wtf/Atomics.cpp:
  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):
(WTF::compilerFence):

  • wtf/Compiler.h:
    • Renamed COMPILER(GCC) to COMPILER(GCC_OR_CLANG), because it is true for both compiler.
    • Added COMPILER(GCC) which is true only for GCC.
    • Moved all GCC related stuff to one block and removed redundant guards accordingly.
    • Removed the unused default false definition of GCC_VERSION_AT_LEAST for non GCC compilers.
  • wtf/ExportMacros.h:
  • wtf/FastMalloc.h:
  • wtf/Platform.h:
  • wtf/StdLibExtras.h:
  • wtf/Vector.h:
  • wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

11:49 PM Changeset in webkit [187818] by Csaba Osztrogonác
  • 10 edits in trunk

[CMake] Add an option to build AllInOne files
​https://bugs.webkit.org/show_bug.cgi?id=102647

Reviewed by Alex Christensen.

.:

  • Source/cmake/OptionsEfl.cmake: Disabled by default.
  • Source/cmake/OptionsGTK.cmake: Disabled by default.
  • Source/cmake/OptionsWindows.cmake: Enabled by default.
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/WebKitMacros.cmake:

Source/WebCore:

  • CMakeLists.txt:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
11:44 PM Changeset in webkit [187817] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Unreviewed build fix.

  • wtf/text/StringConcatenate.h: Include <tuple> to avoid missing

std::tuple<> class definitions.

11:44 PM Changeset in webkit [187816] by Csaba Osztrogonác
  • 4 edits
    1 delete in trunk/Source/WebCore

Fix the all-in-one build on Linux after r187659
​https://bugs.webkit.org/show_bug.cgi?id=147557

Reviewed by Alex Christensen.

Removed MediaFeatureNames.cpp from the all-in-one build, because it caused build failures on Linux.
Additionally removed css/MediaAllInOne.cpp since it is unused.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • css/CSSAllInOne.cpp:
  • css/MediaAllInOne.cpp: Removed.
11:27 PM Changeset in webkit [187815] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WTF

[WTF] Turn tryMakeString(), makeString() into variadic templates
​https://bugs.webkit.org/show_bug.cgi?id=147142

Reviewed by Sam Weinig.

Built upon the original work by Anders Carlsson, Mark Rowe and Sam Weinig.

Implement tryMakeString() and makeString() as variadic templates, replacing
the argument count-based overloads.

tryMakeString() now constructs a stack-based tuple of necessary StringTypeAdapter
objects and utilizes the StringAdapterTuple struct template to operate on that
tuple, recursively calling the necessary operations on each element in the tuple.
This effectively mimics the process of previous tryMakeString() implementation,
but makes it scalable to a tuple of elements that are to be concatenated.

StringAppend class template now stores two StringTypeAdapter objects for the
two passed-in string objects, packed in a tuple, calling
StringAdapterTuple<>::createString() directly when concatenating the two objects
into one String.

  • wtf/text/StringConcatenate.h:

(WTF::StringTypeAdapter<char>::length):
(WTF::StringTypeAdapter<char>::is8Bit):
(WTF::StringAdapterTuple::sumWithOverflow):
(WTF::StringAdapterTuple::is8Bit):
(WTF::StringAdapterTuple::writeTo):
(WTF::StringAdapterTuple::createString):
(WTF::tryMakeString):
(WTF::makeString):
(WTF::sumWithOverflow): Deleted.

  • wtf/text/StringOperators.h:

(WTF::StringAppend::StringAppend):
(WTF::StringAppend::operator String):
(WTF::StringAppend::is8Bit):
(WTF::StringAppend::writeTo):
(WTF::StringAppend::length):
(WTF::StringAppend::string1):
(WTF::StringAppend::string2):

11:05 PM Changeset in webkit [187814] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

Add WK1 Mac result for this test.

  • platform/mac-wk1/editing/selection/caret-mode-document-begin-end-expected.txt: Added.
10:14 PM Changeset in webkit [187813] by benjamin@webkit.org
  • 87 edits
    2 adds in trunk

Returns inconsistent types for el.style.property and el.style.getPropertyValue('color')
​https://bugs.webkit.org/show_bug.cgi?id=147549

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-08-03
Reviewed by Andreas Kling.

Source/WebCore:

Kudos to Greg Whitworth for finding this bug.

Test: fast/css/getPropertyValue-returns-empty-on-missing-property.html

  • css/CSSStyleDeclaration.idl:

Our definition was wrong.
Current spec: ​http://www.w3.org/TR/cssom/#dom-cssstyledeclaration-getpropertyvalue
Current draft: ​https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-getpropertyvalue
Gecko and EdgeHTML follow the spec.

LayoutTests:

The bug is very old, there were a lot of tests to update.

The tests in css3/shapes are incorrect W3C tests. I only updated the expected
results.

The test fast/css/getPropertyValue-returns-empty-on-missing-property.html
is the new one covering the bug fix.

  • animations/script-tests/trigger-parsing.js:

(testTriggerRule):

  • animations/trigger-parsing-expected.txt:
  • animations/unprefixed-properties-expected.txt:
  • animations/unprefixed-properties.html:
  • css3/blending/blend-mode-property-parsing-invalid-expected.txt:
  • css3/blending/script-tests/blend-mode-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/filters/backdrop/backdropfilter-property-parsing-invalid-expected.txt:
  • css3/filters/backdrop/script-tests/backdropfilter-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/filters/filter-property-parsing-invalid-expected.txt:
  • css3/filters/script-tests/filter-property-parsing-invalid.js:

(testInvalidFilterRule):

  • css3/shapes/shape-outside/values/shape-image-threshold-002-expected.txt:
  • css3/shapes/shape-outside/values/shape-image-threshold-003-expected.txt:
  • css3/shapes/shape-outside/values/shape-margin-004-expected.txt:
  • css3/shapes/shape-outside/values/shape-margin-005-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-003-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-006-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-007-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-circle-008-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-003-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-006-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-007-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-ellipse-008-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-inset-005-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-inset-006-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-inset-007-expected.txt:
  • css3/shapes/shape-outside/values/shape-outside-polygon-003-expected.txt:
  • fast/backgrounds/repeat/parsing-background-repeat-expected.txt:
  • fast/backgrounds/repeat/script-tests/parsing-background-repeat.js:
  • fast/backgrounds/size/parsing-background-size-values-expected.txt:
  • fast/backgrounds/size/resources/parsing-background-size-values.js:
  • fast/box-decoration-break/box-decoration-break-parsing-expected.txt:
  • fast/box-decoration-break/box-decoration-break-parsing.html:
  • fast/box-shadow/box-shadow-parsing-invalid-expected.txt:
  • fast/box-shadow/script-tests/box-shadow-parsing-invalid.js:

(testInvalidFilterRule):

  • fast/css/background-clip-text-expected.txt:
  • fast/css/border-spacing-without-vertical-value.html:
  • fast/css/getPropertyValue-border-expected.txt:
  • fast/css/getPropertyValue-border.html:
  • fast/css/getPropertyValue-column-rule-expected.txt:
  • fast/css/getPropertyValue-column-rule.html:
  • fast/css/getPropertyValue-columns-expected.txt:
  • fast/css/getPropertyValue-columns.html:
  • fast/css/getPropertyValue-returns-empty-on-missing-property-expected.txt: Added.
  • fast/css/getPropertyValue-returns-empty-on-missing-property.html: Added.
  • fast/css/getPropertyValue-webkit-margin-collapse-expected.txt:
  • fast/css/getPropertyValue-webkit-margin-collapse.html:
  • fast/css/getPropertyValue-webkit-marquee-expected.txt:
  • fast/css/getPropertyValue-webkit-marquee.html:
  • fast/css/getPropertyValue-webkit-text-stroke-expected.txt:
  • fast/css/getPropertyValue-webkit-text-stroke.html:
  • fast/css/line-height-text-autosizing.html:
  • fast/css/outline-offset-parsing-expected.txt:
  • fast/css/parsing-color-correction-expected.txt:
  • fast/css/parsing-object-fit-expected.txt:
  • fast/css/parsing-object-fit.html:
  • fast/css/parsing-text-rendering-expected.txt:
  • fast/css/parsing-webkit-font-smoothing-expected.txt:
  • fast/css/resources/parsing-color-correction.js:
  • fast/css/resources/parsing-text-rendering.js:
  • fast/css/resources/parsing-webkit-font-smoothing.js:
  • fast/css/script-tests/background-clip-text.js:
  • fast/css/script-tests/outline-offset-parsing.js:
  • fast/css/script-tests/transform-origin-parsing.js:
  • fast/css/sticky/parsing-position-sticky-expected.txt:
  • fast/css/sticky/resources/parsing-position-sticky.js:
  • fast/css/transform-origin-parsing-expected.txt:
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip-expected.txt:
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-roundtrip.html:
  • fast/css3-text/font-synthesis-parse-expected.txt:
  • fast/css3-text/font-synthesis-parse.html:
  • fast/filter-image/parse-filter-image-expected.txt:
  • fast/filter-image/parse-filter-image.html:
  • fast/masking/parsing-clip-path-shape-expected.txt:
  • fast/masking/parsing-clip-path-shape.html:
  • fast/masking/parsing-mask-expected.txt:
  • fast/masking/parsing-mask.html:
  • fast/shapes/css-shapes-disabled-expected.txt:
  • fast/shapes/css-shapes-disabled.html:
  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
  • platform/mac/fast/css/dashboard-region-parser-expected.txt:
  • platform/mac/fast/css/dashboard-region-parser.html:
  • platform/mac/fast/text/trailing-word-parse-expected.txt:
  • platform/mac/fast/text/trailing-word-parse.html:
  • svg/paint-order/parsing-paint-order-expected.txt:
  • svg/paint-order/parsing-paint-order.html:
10:01 PM Changeset in webkit [187812] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2] Reserve Vector capacity in VectorArgumentCoder<false, T, inlineCapacity>::decode()
​https://bugs.webkit.org/show_bug.cgi?id=147619

Reviewed by Andreas Kling.

Reserve Vector capacity in VectorArgumentCoder<false, T, inlineCapacity>::decode()
as we know the size of the Vector in advance.

  • Platform/IPC/ArgumentCoders.h:
9:45 PM Changeset in webkit [187811] by Simon Fraser
  • 1 edit
    1 add in trunk/LayoutTests

Add a result missed in earlier file moves.

  • accessibility/mac/crash-invalid-text-marker-node-expected.txt: Added.
9:44 PM Changeset in webkit [187810] by Simon Fraser
  • 1 edit
    2 moves in trunk/LayoutTests

Make LayoutTests/platform/gtk/fast/css/rect-shadow-tiled.html a cross-platform test.

  • fast/css/rect-shadow-tiled-expected.txt: Renamed from LayoutTests/platform/gtk/fast/css/rect-shadow-tiled-expected.txt.
  • fast/css/rect-shadow-tiled.html: Renamed from LayoutTests/platform/gtk/fast/css/rect-shadow-tiled.html.
9:44 PM Changeset in webkit [187809] by Simon Fraser
  • 1 edit
    2 moves in trunk/LayoutTests

Make platform/gtk/editing/selection/caret-mode-document-begin-end.html into cross-platform test.

  • editing/selection/caret-mode-document-begin-end-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-document-begin-end-expected.txt.
  • editing/selection/caret-mode-document-begin-end.html: Renamed from LayoutTests/platform/gtk/editing/selection/caret-mode-document-begin-end.html.
9:43 PM Changeset in webkit [187808] by Simon Fraser
  • 3 edits
    1 move
    1 add in trunk/LayoutTests

Make accessibility/media-emits-object-replacement.html not specific to EFL.

  • accessibility/media-emits-object-replacement-expected.txt: Added.
  • accessibility/media-emits-object-replacement.html: Renamed from LayoutTests/platform/efl/accessibility/media-emits-object-replacement.html.
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
9:40 PM Changeset in webkit [187807] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix crashing Mavericks test

Unreviewed.

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::registeredFont):

8:42 PM Changeset in webkit [187806] by mmaxfield@apple.com
  • 5 edits in trunk/Source

Unreviewed post-review feedback on r187797

The correct terminology is "registered" instead of "activated."

Source/WebCore:

No new tests because there is no behavior change.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::registeredFont):
(WebCore::FontPlatformData::activatedFont): Deleted.

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

8:32 PM Changeset in webkit [187805] by mmaxfield@apple.com
  • 4 edits in trunk/Source

Clean up casts between NSFont*s and CTFontRefs
​https://bugs.webkit.org/show_bug.cgi?id=147618

Source/WebCore:

Reviewed by Mitz Pettel.

For toll free bridged types, it makes more sense to do a C-style cast, than jump
through hoops for older compilers.

No new tests because there is no behavior change.

  • platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::nsFont):
(WebCore::FontPlatformData::hash):

Source/WebKit/mac:

Reviewed by Mitz Pettel

For toll free bridged types, it makes more sense to do a C-style cast, than jump
through hoops for older compilers.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

8:21 PM Changeset in webkit [187804] by Simon Fraser
  • 48 edits
    1 move
    1 add in trunk/LayoutTests

Fix paths to js-test-pre.js and js-test-post.js after earlier file move.
Move platform/gtk/resources/atk-helpers.js into accessibility/gtk since
these are the only callers.

  • accessibility/gtk/aria-listbox-crash.html:
  • accessibility/gtk/aria-options-and-menuitems-crash.html:
  • accessibility/gtk/aria-roles-unignored.html:
  • accessibility/gtk/aria-slider-required-attributes.html:
  • accessibility/gtk/aria-toggle-button-role.html:
  • accessibility/gtk/button-accessible-name.html:
  • accessibility/gtk/caret-browsing-select-focus.html:
  • accessibility/gtk/caret-browsing-text-focus.html:
  • accessibility/gtk/caret-offsets-and-extraneous-white-spaces.html:
  • accessibility/gtk/caret-offsets.html:
  • accessibility/gtk/combobox-descendants-orientation-crash.html:
  • accessibility/gtk/detached-object-role.html:
  • accessibility/gtk/entry-and-password.html:
  • accessibility/gtk/list-items-always-exposed.html:
  • accessibility/gtk/media-controls-panel-title.html:
  • accessibility/gtk/media-emits-object-replacement.html:
  • accessibility/gtk/menu-list-unfocused-notifications.html:
  • accessibility/gtk/name-from-label.html:
  • accessibility/gtk/no-notification-for-unrendered-iframe-children.html:
  • accessibility/gtk/object-attributes.html:
  • accessibility/gtk/object-with-title.html:
  • accessibility/gtk/remapped-aria-crash.html:
  • accessibility/gtk/replaced-objects-in-anonymous-blocks.html:
  • accessibility/gtk/resources/atk-helpers.js: Renamed from LayoutTests/platform/gtk/resources/atk-helpers.js.

(setCaretOffset):

  • accessibility/gtk/spans-paragraphs-and-divs.html:
  • accessibility/gtk/spans.html:
  • accessibility/gtk/text-at-offset-embedded-objects.html:
  • accessibility/gtk/text-at-offset-newlines.html:
  • accessibility/gtk/text-at-offset-preformatted.html:
  • accessibility/gtk/text-at-offset-simple.html:
  • accessibility/gtk/text-at-offset-special-chars.html:
  • accessibility/gtk/text-at-offset-textarea.html:
  • accessibility/gtk/text-at-offset-textinput.html:
  • accessibility/gtk/text-at-offset-wrapped-lines.html:
  • accessibility/gtk/text-for-range-combo-box.html:
  • accessibility/gtk/text-for-range-embedded-objects.html:
  • accessibility/gtk/text-for-range-entry-and-password.html:
  • accessibility/gtk/text-for-range-extraneous-whitespace.html:
  • accessibility/gtk/text-for-range-formatted.html:
  • accessibility/gtk/text-for-range-heading.html:
  • accessibility/gtk/text-for-range-list-items.html:
  • accessibility/gtk/text-for-range-simple.html:
  • accessibility/gtk/text-for-range-table-cells.html:
  • accessibility/gtk/text-for-range-with-link.html:
  • accessibility/gtk/text-for-table.html:
  • accessibility/gtk/text-in-span-block-in-a-block.html:
  • accessibility/gtk/title-and-alt.html:
  • accessibility/gtk/xml-roles-exposed.html:
8:11 PM Changeset in webkit [187803] by Simon Fraser
  • 3 edits
    6 moves
    2 adds in trunk/LayoutTests

Move platform/gtk/editing/pasteboard tests into editing/pasteboard/gtk.

  • TestExpectations:
  • editing/pasteboard/gtk/middle-button-paste-expected.txt: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste-expected.txt.
  • editing/pasteboard/gtk/middle-button-paste.html: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-button-paste.html.
  • editing/pasteboard/gtk/middle-click-onpaste-expected.txt: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-expected.txt.
  • editing/pasteboard/gtk/middle-click-onpaste.html: Renamed from LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste.html.
  • editing/pasteboard/gtk/script-tests/TEMPLATE.html: Renamed from LayoutTests/platform/gtk/editing/pasteboard/script-tests/TEMPLATE.html.
  • editing/pasteboard/gtk/script-tests/middle-click-onpaste.js: Renamed from LayoutTests/platform/gtk/editing/pasteboard/script-tests/middle-click-onpaste.js.

(handlePaste):

  • platform/gtk/TestExpectations:
8:08 PM Changeset in webkit [187802] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r187707, r187709, r187724, and
r187728.
​https://bugs.webkit.org/show_bug.cgi?id=147617

fast/text/international/arabic-justify.html is flakey
(Requested by litherum on #webkit).

Reverted changesets:

"[OS X] Migrate to CTFontCreateForCharactersWithLanguage from
[NSFont findFontLike:forString:withRange:inLanguage]"
​https://bugs.webkit.org/show_bug.cgi?id=147483
​http://trac.webkit.org/changeset/187707

"Fix the build"
​http://trac.webkit.org/changeset/187709

"Expand CharacterFallbackMapKey to a struct"
​https://bugs.webkit.org/show_bug.cgi?id=147530
​http://trac.webkit.org/changeset/187724

"CharacterFallbackMapKey should be locale-specific"
​https://bugs.webkit.org/show_bug.cgi?id=147532
​http://trac.webkit.org/changeset/187728

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-08-03

8:06 PM Changeset in webkit [187801] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix the Yosemite build after r187797

Unreviewed.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

8:00 PM Changeset in webkit [187800] by Simon Fraser
  • 3 edits
    42 moves
    1 add
    1 delete in trunk/LayoutTests

Move platform/win/accessibility tests to accessibility/win.

Fix paths to script files in the tests. Fix TestExpectations. Remove an unused result.

  • TestExpectations:
  • accessibility/win/detached-object-notification-crash-expected.txt: Renamed from LayoutTests/platform/win/accessibility/detached-object-notification-crash-expected.txt.
  • accessibility/win/detached-object-notification-crash.html: Renamed from LayoutTests/platform/win/accessibility/detached-object-notification-crash.html.
  • accessibility/win/document-enabled-state-expected.txt: Renamed from LayoutTests/platform/win/accessibility/document-enabled-state-expected.txt.
  • accessibility/win/document-enabled-state.html: Renamed from LayoutTests/platform/win/accessibility/document-enabled-state.html.
  • accessibility/win/document-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/document-role-expected.txt.
  • accessibility/win/document-role.html: Renamed from LayoutTests/platform/win/accessibility/document-role.html.
  • accessibility/win/focus-events-expected.txt: Renamed from LayoutTests/platform/win/accessibility/focus-events-expected.txt.
  • accessibility/win/focus-events.html: Renamed from LayoutTests/platform/win/accessibility/focus-events.html.
  • accessibility/win/heading-elements-expected.txt: Renamed from LayoutTests/platform/win/accessibility/heading-elements-expected.txt.
  • accessibility/win/heading-elements.html: Renamed from LayoutTests/platform/win/accessibility/heading-elements.html.
  • accessibility/win/img-alt-attribute-expected.txt: Renamed from LayoutTests/platform/win/accessibility/img-alt-attribute-expected.txt.
  • accessibility/win/img-alt-attribute.html: Renamed from LayoutTests/platform/win/accessibility/img-alt-attribute.html.
  • accessibility/win/linked-elements-expected.txt: Renamed from LayoutTests/platform/win/accessibility/linked-elements-expected.txt.
  • accessibility/win/linked-elements.html: Renamed from LayoutTests/platform/win/accessibility/linked-elements.html.
  • accessibility/win/list-item-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/list-item-role-expected.txt.
  • accessibility/win/list-item-role.html: Renamed from LayoutTests/platform/win/accessibility/list-item-role.html.
  • accessibility/win/list-marker-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/list-marker-role-expected.txt.
  • accessibility/win/list-marker-role.html: Renamed from LayoutTests/platform/win/accessibility/list-marker-role.html.
  • accessibility/win/list-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/list-role-expected.txt.
  • accessibility/win/list-role.html: Renamed from LayoutTests/platform/win/accessibility/list-role.html.
  • accessibility/win/multiple-select-element-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/multiple-select-element-role-expected.txt.
  • accessibility/win/multiple-select-element-role.html: Renamed from LayoutTests/platform/win/accessibility/multiple-select-element-role.html.
  • accessibility/win/option-element-position-and-size-expected.txt: Renamed from LayoutTests/platform/win/platform/win/accessibility/option-element-position-and-size-expected.txt.
  • accessibility/win/option-element-position-and-size.html: Renamed from LayoutTests/platform/win/accessibility/option-element-position-and-size.html.
  • accessibility/win/option-element-selection-and-focus-events-expected.txt: Renamed from LayoutTests/platform/win/accessibility/option-element-selection-and-focus-events-expected.txt.
  • accessibility/win/option-element-selection-and-focus-events.html: Renamed from LayoutTests/platform/win/accessibility/option-element-selection-and-focus-events.html.
  • accessibility/win/parent-element-expected.txt: Renamed from LayoutTests/platform/win/accessibility/parent-element-expected.txt.
  • accessibility/win/parent-element.html: Renamed from LayoutTests/platform/win/accessibility/parent-element.html.
  • accessibility/win/scroll-to-anchor-expected.txt: Renamed from LayoutTests/platform/win/accessibility/scroll-to-anchor-expected.txt.
  • accessibility/win/scroll-to-anchor.html: Renamed from LayoutTests/platform/win/accessibility/scroll-to-anchor.html.
  • accessibility/win/select-element-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/select-element-role-expected.txt.
  • accessibility/win/select-element-role.html: Renamed from LayoutTests/platform/win/accessibility/select-element-role.html.
  • accessibility/win/select-element-valuechange-event-expected.txt: Renamed from LayoutTests/platform/win/accessibility/select-element-valuechange-event-expected.txt.
  • accessibility/win/select-element-valuechange-event.html: Renamed from LayoutTests/platform/win/accessibility/select-element-valuechange-event.html.
  • accessibility/win/selection-and-focus-expected.txt: Renamed from LayoutTests/platform/win/accessibility/selection-and-focus-expected.txt.
  • accessibility/win/selection-and-focus.html: Renamed from LayoutTests/platform/win/accessibility/selection-and-focus.html.
  • accessibility/win/single-select-children-changed-expected.txt: Renamed from LayoutTests/platform/win/accessibility/single-select-children-changed-expected.txt.
  • accessibility/win/single-select-children-changed.html: Renamed from LayoutTests/platform/win/accessibility/single-select-children-changed.html.
  • accessibility/win/single-select-children-expected.txt: Renamed from LayoutTests/platform/win/accessibility/single-select-children-expected.txt.
  • accessibility/win/single-select-children.html: Renamed from LayoutTests/platform/win/accessibility/single-select-children.html.
  • accessibility/win/text-role-expected.txt: Renamed from LayoutTests/platform/win/accessibility/text-role-expected.txt.
  • accessibility/win/text-role.html: Renamed from LayoutTests/platform/win/accessibility/text-role.html.
  • platform/win/TestExpectations:
  • platform/win/accessibility/option-element-position-and-size-expected.txt: Removed.
8:00 PM Changeset in webkit [187799] by Simon Fraser
  • 5 edits
    465 moves
    3 adds
    2 deletes in trunk/LayoutTests

Move platform/mac/accessibility tests to accessibility/mac.

Fix paths to script files in the tests. Fix TestExpectations. Remove an unused result.

  • TestExpectations:
  • accessibility/mac/abbr-acronym-tags-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/abbr-acronym-tags-expected.txt.
  • accessibility/mac/abbr-acronym-tags.html: Renamed from LayoutTests/platform/mac/accessibility/abbr-acronym-tags.html.
  • accessibility/mac/accesskey-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/accesskey-expected.txt.
  • accessibility/mac/accesskey.html: Renamed from LayoutTests/platform/mac/accessibility/accesskey.html.
  • accessibility/mac/alt-for-css-content-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/alt-for-css-content-expected.txt.
  • accessibility/mac/alt-for-css-content.html: Renamed from LayoutTests/platform/mac/accessibility/alt-for-css-content.html.
  • accessibility/mac/area-with-aria-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/area-with-aria-label-expected.txt.
  • accessibility/mac/area-with-aria-label.html: Renamed from LayoutTests/platform/mac/accessibility/area-with-aria-label.html.
  • accessibility/mac/aria-alerts-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-alerts-expected.txt.
  • accessibility/mac/aria-alerts.html: Renamed from LayoutTests/platform/mac/accessibility/aria-alerts.html.
  • accessibility/mac/aria-columnrowheaders-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-columnrowheaders-expected.txt.
  • accessibility/mac/aria-columnrowheaders.html: Renamed from LayoutTests/platform/mac/accessibility/aria-columnrowheaders.html.
  • accessibility/mac/aria-directory-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-directory-expected.txt.
  • accessibility/mac/aria-directory.html: Renamed from LayoutTests/platform/mac/accessibility/aria-directory.html.
  • accessibility/mac/aria-divs-not-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-divs-not-ignored-expected.txt.
  • accessibility/mac/aria-divs-not-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/aria-divs-not-ignored.html.
  • accessibility/mac/aria-drag-drop-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-drag-drop-expected.txt.
  • accessibility/mac/aria-drag-drop.html: Renamed from LayoutTests/platform/mac/accessibility/aria-drag-drop.html.
  • accessibility/mac/aria-expanded-not-exposed-when-undefined-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-not-exposed-when-undefined-expected.txt.
  • accessibility/mac/aria-expanded-not-exposed-when-undefined.html: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-not-exposed-when-undefined.html.
  • accessibility/mac/aria-expanded-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-notifications-expected.txt.
  • accessibility/mac/aria-expanded-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-notifications.html.
  • accessibility/mac/aria-expanded-standard-items-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-standard-items-expected.txt.
  • accessibility/mac/aria-expanded-standard-items.html: Renamed from LayoutTests/platform/mac/accessibility/aria-expanded-standard-items.html.
  • accessibility/mac/aria-grid-with-strange-hierarchy-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-grid-with-strange-hierarchy-expected.txt.
  • accessibility/mac/aria-grid-with-strange-hierarchy.html: Renamed from LayoutTests/platform/mac/accessibility/aria-grid-with-strange-hierarchy.html.
  • accessibility/mac/aria-grouping-roles-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-grouping-roles-expected.txt.
  • accessibility/mac/aria-grouping-roles.html: Renamed from LayoutTests/platform/mac/accessibility/aria-grouping-roles.html.
  • accessibility/mac/aria-hidden-changes-for-non-ignored-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-hidden-changes-for-non-ignored-elements-expected.txt.
  • accessibility/mac/aria-hidden-changes-for-non-ignored-elements.html: Renamed from LayoutTests/platform/mac/accessibility/aria-hidden-changes-for-non-ignored-elements.html.
  • accessibility/mac/aria-image-emits-object-replacement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-image-emits-object-replacement-expected.txt.
  • accessibility/mac/aria-image-emits-object-replacement.html: Renamed from LayoutTests/platform/mac/accessibility/aria-image-emits-object-replacement.html.
  • accessibility/mac/aria-label-overrides-visible-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-label-overrides-visible-text-expected.txt.
  • accessibility/mac/aria-label-overrides-visible-text.html: Renamed from LayoutTests/platform/mac/accessibility/aria-label-overrides-visible-text.html.
  • accessibility/mac/aria-listbox-selectedchildren-change-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-listbox-selectedchildren-change-expected.txt.
  • accessibility/mac/aria-listbox-selectedchildren-change.html: Renamed from LayoutTests/platform/mac/accessibility/aria-listbox-selectedchildren-change.html.
  • accessibility/mac/aria-liveregion-marquee-default-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-marquee-default-expected.txt.
  • accessibility/mac/aria-liveregion-marquee-default.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-marquee-default.html.
  • accessibility/mac/aria-liveregion-on-image-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-on-image-expected.txt.
  • accessibility/mac/aria-liveregion-on-image.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregion-on-image.html.
  • accessibility/mac/aria-liveregions-addedelement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-addedelement-expected.txt.
  • accessibility/mac/aria-liveregions-addedelement.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-addedelement.html.
  • accessibility/mac/aria-liveregions-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-attributes-expected.txt.
  • accessibility/mac/aria-liveregions-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-attributes.html.
  • accessibility/mac/aria-liveregions-changedalt-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedalt-expected.txt.
  • accessibility/mac/aria-liveregions-changedalt.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedalt.html.
  • accessibility/mac/aria-liveregions-changedtext-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedtext-expected.txt.
  • accessibility/mac/aria-liveregions-changedtext.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-changedtext.html.
  • accessibility/mac/aria-liveregions-notifications-always-sent-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt.
  • accessibility/mac/aria-liveregions-notifications-always-sent.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-always-sent.html.
  • accessibility/mac/aria-liveregions-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications-expected.txt.
  • accessibility/mac/aria-liveregions-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-notifications.html.
  • accessibility/mac/aria-liveregions-removedelement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-removedelement-expected.txt.
  • accessibility/mac/aria-liveregions-removedelement.html: Renamed from LayoutTests/platform/mac/accessibility/aria-liveregions-removedelement.html.
  • accessibility/mac/aria-menu-closed-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-closed-notification-expected.txt.
  • accessibility/mac/aria-menu-closed-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-closed-notification.html.
  • accessibility/mac/aria-menu-item-selected-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt.
  • accessibility/mac/aria-menu-item-selected-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-item-selected-notification.html.
  • accessibility/mac/aria-menu-open-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-open-notification-expected.txt.
  • accessibility/mac/aria-menu-open-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-open-notification.html.
  • accessibility/mac/aria-menu-role-descriptions-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-role-descriptions-expected.txt.
  • accessibility/mac/aria-menu-role-descriptions.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menu-role-descriptions.html.
  • accessibility/mac/aria-menubar-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menubar-expected.txt.
  • accessibility/mac/aria-menubar.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menubar.html.
  • accessibility/mac/aria-menuitem-checked-value-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-checked-value-expected.txt.
  • accessibility/mac/aria-menuitem-checked-value.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-checked-value.html.
  • accessibility/mac/aria-menuitem-focus-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-focus-expected.txt.
  • accessibility/mac/aria-menuitem-focus.html: Renamed from LayoutTests/platform/mac/accessibility/aria-menuitem-focus.html.
  • accessibility/mac/aria-multiline-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-multiline-expected.txt.
  • accessibility/mac/aria-multiline.html: Renamed from LayoutTests/platform/mac/accessibility/aria-multiline.html.
  • accessibility/mac/aria-multiple-liveregions-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification-expected.txt.
  • accessibility/mac/aria-multiple-liveregions-notification.html: Renamed from LayoutTests/platform/mac/accessibility/aria-multiple-liveregions-notification.html.
  • accessibility/mac/aria-multiselectable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-multiselectable-expected.txt.
  • accessibility/mac/aria-multiselectable.html: Renamed from LayoutTests/platform/mac/accessibility/aria-multiselectable.html.
  • accessibility/mac/aria-owns-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-owns-expected.txt.
  • accessibility/mac/aria-owns.html: Renamed from LayoutTests/platform/mac/accessibility/aria-owns.html.
  • accessibility/mac/aria-popup-buttons-on-native-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-popup-buttons-on-native-elements-expected.txt.
  • accessibility/mac/aria-popup-buttons-on-native-elements.html: Renamed from LayoutTests/platform/mac/accessibility/aria-popup-buttons-on-native-elements.html.
  • accessibility/mac/aria-popup-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-popup-expected.txt.
  • accessibility/mac/aria-popup.html: Renamed from LayoutTests/platform/mac/accessibility/aria-popup.html.
  • accessibility/mac/aria-pressed-button-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-pressed-button-attributes-expected.txt.
  • accessibility/mac/aria-pressed-button-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/aria-pressed-button-attributes.html.
  • accessibility/mac/aria-radiobutton-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-radiobutton-text-expected.txt.
  • accessibility/mac/aria-radiobutton-text.html: Renamed from LayoutTests/platform/mac/accessibility/aria-radiobutton-text.html.
  • accessibility/mac/aria-radiogroup-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-radiogroup-expected.txt.
  • accessibility/mac/aria-radiogroup.html: Renamed from LayoutTests/platform/mac/accessibility/aria-radiogroup.html.
  • accessibility/mac/aria-required-popup-button-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-required-popup-button-expected.txt.
  • accessibility/mac/aria-required-popup-button.html: Renamed from LayoutTests/platform/mac/accessibility/aria-required-popup-button.html.
  • accessibility/mac/aria-slider-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-slider-expected.txt.
  • accessibility/mac/aria-slider.html: Renamed from LayoutTests/platform/mac/accessibility/aria-slider.html.
  • accessibility/mac/aria-spinbutton-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton-crash-expected.txt.
  • accessibility/mac/aria-spinbutton-crash.html: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton-crash.html.
  • accessibility/mac/aria-spinbutton-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton-expected.txt.
  • accessibility/mac/aria-spinbutton.html: Renamed from LayoutTests/platform/mac/accessibility/aria-spinbutton.html.
  • accessibility/mac/aria-table-with-colspan-cells-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-table-with-colspan-cells-expected.txt.
  • accessibility/mac/aria-table-with-colspan-cells.html: Renamed from LayoutTests/platform/mac/accessibility/aria-table-with-colspan-cells.html.
  • accessibility/mac/aria-toolbar-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-toolbar-expected.txt.
  • accessibility/mac/aria-toolbar.html: Renamed from LayoutTests/platform/mac/accessibility/aria-toolbar.html.
  • accessibility/mac/aria-tree-activedescendant-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-activedescendant-expected.txt.
  • accessibility/mac/aria-tree-activedescendant.html: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-activedescendant.html.
  • accessibility/mac/aria-tree-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-expected.txt.
  • accessibility/mac/aria-tree-index-of-items-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-index-of-items-expected.txt.
  • accessibility/mac/aria-tree-index-of-items.html: Renamed from LayoutTests/platform/mac/accessibility/aria-tree-index-of-items.html.
  • accessibility/mac/aria-tree.html: Renamed from LayoutTests/platform/mac/accessibility/aria-tree.html.
  • accessibility/mac/aria-treegrid-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-treegrid-expected.txt.
  • accessibility/mac/aria-treegrid.html: Renamed from LayoutTests/platform/mac/accessibility/aria-treegrid.html.
  • accessibility/mac/aria-valuetext-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext-expected.txt.
  • accessibility/mac/aria-valuetext-on-native-slider-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext-on-native-slider-expected.txt.
  • accessibility/mac/aria-valuetext-on-native-slider.html: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext-on-native-slider.html.
  • accessibility/mac/aria-valuetext.html: Renamed from LayoutTests/platform/mac/accessibility/aria-valuetext.html.
  • accessibility/mac/attributed-string-includes-highlighting-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-highlighting-expected.txt.
  • accessibility/mac/attributed-string-includes-highlighting.html: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-highlighting.html.
  • accessibility/mac/attributed-string-includes-misspelled-with-selection-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-misspelled-with-selection-expected.txt.
  • accessibility/mac/attributed-string-includes-misspelled-with-selection.html: Renamed from LayoutTests/platform/mac/accessibility/attributed-string-includes-misspelled-with-selection.html.
  • accessibility/mac/bounds-for-range-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/bounds-for-range-expected.txt.
  • accessibility/mac/bounds-for-range.html: Renamed from LayoutTests/platform/mac/accessibility/bounds-for-range.html.
  • accessibility/mac/button-shouldnot-have-axvalue-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/button-shouldnot-have-axvalue-expected.txt.
  • accessibility/mac/button-shouldnot-have-axvalue.html: Renamed from LayoutTests/platform/mac/accessibility/button-shouldnot-have-axvalue.html.
  • accessibility/mac/canvas-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/canvas-expected.txt.
  • accessibility/mac/canvas.html: Renamed from LayoutTests/platform/mac/accessibility/canvas.html.
  • accessibility/mac/caret-browsing-arrow-nav-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-arrow-nav-expected.txt.
  • accessibility/mac/caret-browsing-arrow-nav.html: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-arrow-nav.html.
  • accessibility/mac/caret-browsing-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-attribute-expected.txt.
  • accessibility/mac/caret-browsing-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-attribute.html.
  • accessibility/mac/caret-browsing-tab-selection-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-tab-selection-expected.txt.
  • accessibility/mac/caret-browsing-tab-selection.html: Renamed from LayoutTests/platform/mac/accessibility/caret-browsing-tab-selection.html.
  • accessibility/mac/change-notification-on-scroll-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/change-notification-on-scroll-expected.txt.
  • accessibility/mac/change-notification-on-scroll.html: Renamed from LayoutTests/platform/mac/accessibility/change-notification-on-scroll.html.
  • accessibility/mac/checkbox-posts-value-change-notification-after-activation-with-space-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/checkbox-posts-value-change-notification-after-activation-with-space-expected.txt.
  • accessibility/mac/checkbox-posts-value-change-notification-after-activation-with-space.html: Renamed from LayoutTests/platform/mac/accessibility/checkbox-posts-value-change-notification-after-activation-with-space.html.
  • accessibility/mac/clipped-text-under-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/clipped-text-under-element-expected.txt.
  • accessibility/mac/clipped-text-under-element.html: Renamed from LayoutTests/platform/mac/accessibility/clipped-text-under-element.html.
  • accessibility/mac/combobox-activedescendant-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt.
  • accessibility/mac/combobox-activedescendant-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/combobox-activedescendant-notifications.html.
  • accessibility/mac/combox-box-value-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/combox-box-value-expected.txt.
  • accessibility/mac/combox-box-value.html: Renamed from LayoutTests/platform/mac/accessibility/combox-box-value.html.
  • accessibility/mac/content-editable-range-properties-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/content-editable-range-properties-expected.txt.
  • accessibility/mac/content-editable-range-properties.html: Renamed from LayoutTests/platform/mac/accessibility/content-editable-range-properties.html.
  • accessibility/mac/crash-in-element-for-text-marker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/crash-in-element-for-text-marker-expected.txt.
  • accessibility/mac/crash-in-element-for-text-marker.html: Renamed from LayoutTests/platform/mac/accessibility/crash-in-element-for-text-marker.html.
  • accessibility/mac/crash-invalid-text-marker-node.html: Renamed from LayoutTests/platform/mac/accessibility/crash-invalid-text-marker-node.html.
  • accessibility/mac/css-speech-speak-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/css-speech-speak-expected.txt.
  • accessibility/mac/css-speech-speak.html: Renamed from LayoutTests/platform/mac/accessibility/css-speech-speak.html.
  • accessibility/mac/definition-list-term-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/definition-list-term-expected.txt.
  • accessibility/mac/definition-list-term.html: Renamed from LayoutTests/platform/mac/accessibility/definition-list-term.html.
  • accessibility/mac/descriptionlist-not-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored-expected.txt.
  • accessibility/mac/descriptionlist-not-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/descriptionlist-not-ignored.html.
  • accessibility/mac/details-summary-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/details-summary-expected.txt.
  • accessibility/mac/details-summary.html: Renamed from LayoutTests/platform/mac/accessibility/details-summary.html.
  • accessibility/mac/div-containing-div-with-aria-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/div-containing-div-with-aria-expected.txt.
  • accessibility/mac/div-containing-div-with-aria.html: Renamed from LayoutTests/platform/mac/accessibility/div-containing-div-with-aria.html.
  • accessibility/mac/document-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/document-attributes-expected.txt.
  • accessibility/mac/document-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/document-attributes.html.
  • accessibility/mac/document-links-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/document-links-expected.txt.
  • accessibility/mac/document-links.html: Renamed from LayoutTests/platform/mac/accessibility/document-links.html.
  • accessibility/mac/document-title-used-for-description-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/document-title-used-for-description-expected.txt.
  • accessibility/mac/document-title-used-for-description.html: Renamed from LayoutTests/platform/mac/accessibility/document-title-used-for-description.html.
  • accessibility/mac/double-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/double-title-expected.txt.
  • accessibility/mac/double-title.html: Renamed from LayoutTests/platform/mac/accessibility/double-title.html.
  • accessibility/mac/editable-webarea-context-menu-point-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point-expected.txt.
  • accessibility/mac/editable-webarea-context-menu-point.html: Renamed from LayoutTests/platform/mac/accessibility/editable-webarea-context-menu-point.html.
  • accessibility/mac/element-busy-changed-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-busy-changed-expected.txt.
  • accessibility/mac/element-busy-changed.html: Renamed from LayoutTests/platform/mac/accessibility/element-busy-changed.html.
  • accessibility/mac/element-focus-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-focus-expected.txt.
  • accessibility/mac/element-focus.html: Renamed from LayoutTests/platform/mac/accessibility/element-focus.html.
  • accessibility/mac/element-for-text-marker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-for-text-marker-expected.txt.
  • accessibility/mac/element-for-text-marker.html: Renamed from LayoutTests/platform/mac/accessibility/element-for-text-marker.html.
  • accessibility/mac/element-is-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-is-ignored-expected.txt.
  • accessibility/mac/element-is-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/element-is-ignored.html.
  • accessibility/mac/element-level-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-level-expected.txt.
  • accessibility/mac/element-level.html: Renamed from LayoutTests/platform/mac/accessibility/element-level.html.
  • accessibility/mac/element-paths-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/element-paths-expected.txt.
  • accessibility/mac/element-paths.html: Renamed from LayoutTests/platform/mac/accessibility/element-paths.html.
  • accessibility/mac/estimated-progress-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/estimated-progress-expected.txt.
  • accessibility/mac/estimated-progress.html: Renamed from LayoutTests/platform/mac/accessibility/estimated-progress.html.
  • accessibility/mac/expanded-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/expanded-notification-expected.txt.
  • accessibility/mac/expanded-notification.html: Renamed from LayoutTests/platform/mac/accessibility/expanded-notification.html.
  • accessibility/mac/file-upload-button-subrole-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/file-upload-button-subrole-expected.txt.
  • accessibility/mac/file-upload-button-subrole.html: Renamed from LayoutTests/platform/mac/accessibility/file-upload-button-subrole.html.
  • accessibility/mac/find-and-replace-match-capitalization-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/find-and-replace-match-capitalization-expected.txt.
  • accessibility/mac/find-and-replace-match-capitalization.html: Renamed from LayoutTests/platform/mac/accessibility/find-and-replace-match-capitalization.html.
  • accessibility/mac/focus-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/focus-crash-expected.txt.
  • accessibility/mac/focus-crash.html: Renamed from LayoutTests/platform/mac/accessibility/focus-crash.html.
  • accessibility/mac/focus-setting-selection-syncronizing-not-clearing-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/focus-setting-selection-syncronizing-not-clearing-expected.txt.
  • accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html: Renamed from LayoutTests/platform/mac/accessibility/focus-setting-selection-syncronizing-not-clearing.html.
  • accessibility/mac/footer-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/footer-expected.txt.
  • accessibility/mac/footer-roledescription-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/footer-roledescription-expected.txt.
  • accessibility/mac/footer-roledescription.html: Renamed from LayoutTests/platform/mac/accessibility/footer-roledescription.html.
  • accessibility/mac/footer.html: Renamed from LayoutTests/platform/mac/accessibility/footer.html.
  • accessibility/mac/form-control-value-settable-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/form-control-value-settable-expected.txt.
  • accessibility/mac/form-control-value-settable.html: Renamed from LayoutTests/platform/mac/accessibility/form-control-value-settable.html.
  • accessibility/mac/frame-with-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/frame-with-title-expected.txt.
  • accessibility/mac/frame-with-title.html: Renamed from LayoutTests/platform/mac/accessibility/frame-with-title.html.
  • accessibility/mac/header-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/header-expected.txt.
  • accessibility/mac/header.html: Renamed from LayoutTests/platform/mac/accessibility/header.html.
  • accessibility/mac/heading-clickpoint-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/heading-clickpoint-expected.txt.
  • accessibility/mac/heading-clickpoint.html: Renamed from LayoutTests/platform/mac/accessibility/heading-clickpoint.html.
  • accessibility/mac/hr-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/hr-element-expected.txt.
  • accessibility/mac/hr-element.html: Renamed from LayoutTests/platform/mac/accessibility/hr-element.html.
  • accessibility/mac/html-section-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html-section-elements-expected.txt.
  • accessibility/mac/html-section-elements.html: Renamed from LayoutTests/platform/mac/accessibility/html-section-elements.html.
  • accessibility/mac/html-slider-indicator-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html-slider-indicator-expected.txt.
  • accessibility/mac/html-slider-indicator.html: Renamed from LayoutTests/platform/mac/accessibility/html-slider-indicator.html.
  • accessibility/mac/html-with-aria-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html-with-aria-label-expected.txt.
  • accessibility/mac/html-with-aria-label.html: Renamed from LayoutTests/platform/mac/accessibility/html-with-aria-label.html.
  • accessibility/mac/html5-input-number-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/html5-input-number-expected.txt.
  • accessibility/mac/html5-input-number.html: Renamed from LayoutTests/platform/mac/accessibility/html5-input-number.html.
  • accessibility/mac/id-class-attributes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/id-class-attributes-expected.txt.
  • accessibility/mac/id-class-attributes.html: Renamed from LayoutTests/platform/mac/accessibility/id-class-attributes.html.
  • accessibility/mac/iframe-aria-hidden-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/iframe-aria-hidden-expected.txt.
  • accessibility/mac/iframe-aria-hidden.html: Renamed from LayoutTests/platform/mac/accessibility/iframe-aria-hidden.html.
  • accessibility/mac/iframe-with-title-correct-hierarchy-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/iframe-with-title-correct-hierarchy-expected.txt.
  • accessibility/mac/iframe-with-title-correct-hierarchy.html: Renamed from LayoutTests/platform/mac/accessibility/iframe-with-title-correct-hierarchy.html.
  • accessibility/mac/imagemap-hittest-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/imagemap-hittest-expected.txt.
  • accessibility/mac/imagemap-hittest.html: Renamed from LayoutTests/platform/mac/accessibility/imagemap-hittest.html.
  • accessibility/mac/inherited-presentational-lists-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/inherited-presentational-lists-expected.txt.
  • accessibility/mac/inherited-presentational-lists.html: Renamed from LayoutTests/platform/mac/accessibility/inherited-presentational-lists.html.
  • accessibility/mac/input-image-url-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-image-url-expected.txt.
  • accessibility/mac/input-image-url.html: Renamed from LayoutTests/platform/mac/accessibility/input-image-url.html.
  • accessibility/mac/input-replacevalue-userinfo-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-replacevalue-userinfo-expected.txt.
  • accessibility/mac/input-replacevalue-userinfo.html: Renamed from LayoutTests/platform/mac/accessibility/input-replacevalue-userinfo.html.
  • accessibility/mac/input-slider-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-slider-expected.txt.
  • accessibility/mac/input-slider.html: Renamed from LayoutTests/platform/mac/accessibility/input-slider.html.
  • accessibility/mac/input-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/input-title-expected.txt.
  • accessibility/mac/input-title.html: Renamed from LayoutTests/platform/mac/accessibility/input-title.html.
  • accessibility/mac/internal-link-anchors-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/internal-link-anchors-expected.txt.
  • accessibility/mac/internal-link-anchors.html: Renamed from LayoutTests/platform/mac/accessibility/internal-link-anchors.html.
  • accessibility/mac/internal-link-when-document-has-fragment-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/internal-link-when-document-has-fragment-expected.txt.
  • accessibility/mac/internal-link-when-document-has-fragment.html: Renamed from LayoutTests/platform/mac/accessibility/internal-link-when-document-has-fragment.html.
  • accessibility/mac/invalid-menu-role-does-not-send-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/invalid-menu-role-does-not-send-notification-expected.txt.
  • accessibility/mac/invalid-menu-role-does-not-send-notification.html: Renamed from LayoutTests/platform/mac/accessibility/invalid-menu-role-does-not-send-notification.html.
  • accessibility/mac/label-element-with-hidden-control-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/label-element-with-hidden-control-expected.txt.
  • accessibility/mac/label-element-with-hidden-control.html: Renamed from LayoutTests/platform/mac/accessibility/label-element-with-hidden-control.html.
  • accessibility/mac/label-elements-exposed-as-title-ui-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/label-elements-exposed-as-title-ui-elements-expected.txt.
  • accessibility/mac/label-elements-exposed-as-title-ui-elements.html: Renamed from LayoutTests/platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html.
  • accessibility/mac/landmark-not-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/landmark-not-ignored-expected.txt.
  • accessibility/mac/landmark-not-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/landmark-not-ignored.html.
  • accessibility/mac/line-range-for-text-marker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/line-range-for-text-marker-expected.txt.
  • accessibility/mac/line-range-for-text-marker.html: Renamed from LayoutTests/platform/mac/accessibility/line-range-for-text-marker.html.
  • accessibility/mac/link-with-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/link-with-title-expected.txt.
  • accessibility/mac/link-with-title.html: Renamed from LayoutTests/platform/mac/accessibility/link-with-title.html.
  • accessibility/mac/list-items-ignored-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/list-items-ignored-expected.txt.
  • accessibility/mac/list-items-ignored.html: Renamed from LayoutTests/platform/mac/accessibility/list-items-ignored.html.
  • accessibility/mac/listbox-hit-test-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listbox-hit-test-expected.txt.
  • accessibility/mac/listbox-hit-test.html: Renamed from LayoutTests/platform/mac/accessibility/listbox-hit-test.html.
  • accessibility/mac/listmarker-suffix-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listmarker-suffix-expected.txt.
  • accessibility/mac/listmarker-suffix.html: Renamed from LayoutTests/platform/mac/accessibility/listmarker-suffix.html.
  • accessibility/mac/live-region-creation-notification-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/live-region-creation-notification-expected.txt.
  • accessibility/mac/live-region-creation-notification.html: Renamed from LayoutTests/platform/mac/accessibility/live-region-creation-notification.html.
  • accessibility/mac/live-region-on-span-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/live-region-on-span-expected.txt.
  • accessibility/mac/live-region-on-span.html: Renamed from LayoutTests/platform/mac/accessibility/live-region-on-span.html.
  • accessibility/mac/main-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/main-element-expected.txt.
  • accessibility/mac/main-element.html: Renamed from LayoutTests/platform/mac/accessibility/main-element.html.
  • accessibility/mac/malformed-tree-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/malformed-tree-expected.txt.
  • accessibility/mac/malformed-tree.html: Renamed from LayoutTests/platform/mac/accessibility/malformed-tree.html.
  • accessibility/mac/math-alttext-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/math-alttext-expected.txt.
  • accessibility/mac/math-alttext.html: Renamed from LayoutTests/platform/mac/accessibility/math-alttext.html.
  • accessibility/mac/mathml-elements-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-elements-expected.txt.
  • accessibility/mac/mathml-elements.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-elements.html.
  • accessibility/mac/mathml-line-fraction-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-line-fraction-expected.txt.
  • accessibility/mac/mathml-line-fraction.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-line-fraction.html.
  • accessibility/mac/mathml-multiscript-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-multiscript-expected.txt.
  • accessibility/mac/mathml-multiscript.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-multiscript.html.
  • accessibility/mac/mathml-root-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mathml-root-expected.txt.
  • accessibility/mac/mathml-root.html: Renamed from LayoutTests/platform/mac/accessibility/mathml-root.html.
  • accessibility/mac/media-emits-object-replacement-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/media-emits-object-replacement-expected.txt.
  • accessibility/mac/media-emits-object-replacement.html: Renamed from LayoutTests/platform/mac/accessibility/media-emits-object-replacement.html.
  • accessibility/mac/media-role-descriptions-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/media-role-descriptions-expected.txt.
  • accessibility/mac/media-role-descriptions.html: Renamed from LayoutTests/platform/mac/accessibility/media-role-descriptions.html.
  • accessibility/mac/menu-item-values-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/menu-item-values-expected.txt.
  • accessibility/mac/menu-item-values.html: Renamed from LayoutTests/platform/mac/accessibility/menu-item-values.html.
  • accessibility/mac/misspelled-attributed-string-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/misspelled-attributed-string-expected.txt.
  • accessibility/mac/misspelled-attributed-string.html: Renamed from LayoutTests/platform/mac/accessibility/misspelled-attributed-string.html.
  • accessibility/mac/mixed-checkbox-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox-expected.txt.
  • accessibility/mac/mixed-checkbox.html: Renamed from LayoutTests/platform/mac/accessibility/mixed-checkbox.html.
  • accessibility/mac/native-list-item-should-not-expose-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label-expected.txt.
  • accessibility/mac/native-list-item-should-not-expose-label.html: Renamed from LayoutTests/platform/mac/accessibility/native-list-item-should-not-expose-label.html.
  • accessibility/mac/native-vs-nonnative-checkboxes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt.
  • accessibility/mac/native-vs-nonnative-checkboxes.html: Renamed from LayoutTests/platform/mac/accessibility/native-vs-nonnative-checkboxes.html.
  • accessibility/mac/no-unknown-objects-when-title-attribute-present-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/no-unknown-objects-when-title-attribute-present-expected.txt.
  • accessibility/mac/no-unknown-objects-when-title-attribute-present.html: Renamed from LayoutTests/platform/mac/accessibility/no-unknown-objects-when-title-attribute-present.html.
  • accessibility/mac/object-replacement-with-no-rendered-children-at-node-start-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start-expected.txt.
  • accessibility/mac/object-replacement-with-no-rendered-children-at-node-start.html: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html.
  • accessibility/mac/object-replacement-with-rendered-children-at-node-start-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start-expected.txt.
  • accessibility/mac/object-replacement-with-rendered-children-at-node-start.html: Renamed from LayoutTests/platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html.
  • accessibility/mac/option-with-arialabel-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/option-with-arialabel-expected.txt.
  • accessibility/mac/option-with-arialabel.html: Renamed from LayoutTests/platform/mac/accessibility/option-with-arialabel.html.
  • accessibility/mac/option-with-lang-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/option-with-lang-expected.txt.
  • accessibility/mac/option-with-lang.html: Renamed from LayoutTests/platform/mac/accessibility/option-with-lang.html.
  • accessibility/mac/ordered-textmarker-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/ordered-textmarker-crash-expected.txt.
  • accessibility/mac/ordered-textmarker-crash.html: Renamed from LayoutTests/platform/mac/accessibility/ordered-textmarker-crash.html.
  • accessibility/mac/parent-of-table-row-is-table-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/parent-of-table-row-is-table-expected.txt.
  • accessibility/mac/parent-of-table-row-is-table.html: Renamed from LayoutTests/platform/mac/accessibility/parent-of-table-row-is-table.html.
  • accessibility/mac/popup-button-exposes-axvalue-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/popup-button-exposes-axvalue-expected.txt.
  • accessibility/mac/popup-button-exposes-axvalue.html: Renamed from LayoutTests/platform/mac/accessibility/popup-button-exposes-axvalue.html.
  • accessibility/mac/press-action-for-presentational-descendants-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/press-action-for-presentational-descendants-expected.txt.
  • accessibility/mac/press-action-for-presentational-descendants.html: Renamed from LayoutTests/platform/mac/accessibility/press-action-for-presentational-descendants.html.
  • accessibility/mac/press-action-is-first-expected.txt: Renamed from LayoutTests/platform/mac/platform/mac/accessibility/press-action-is-first-expected.txt.
  • accessibility/mac/press-action-is-first.html: Renamed from LayoutTests/platform/mac/accessibility/press-action-is-first.html.
  • accessibility/mac/press-action-not-exposed-for-event-delegation-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/press-action-not-exposed-for-event-delegation-expected.txt.
  • accessibility/mac/press-action-not-exposed-for-event-delegation.html: Renamed from LayoutTests/platform/mac/accessibility/press-action-not-exposed-for-event-delegation.html.
  • accessibility/mac/prevent-keyboard-event-dispatch-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/prevent-keyboard-event-dispatch-expected.txt.
  • accessibility/mac/prevent-keyboard-event-dispatch.html: Renamed from LayoutTests/platform/mac/accessibility/prevent-keyboard-event-dispatch.html.
  • accessibility/mac/progressbar-indeterminate-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/progressbar-indeterminate-expected.txt.
  • accessibility/mac/progressbar-indeterminate.html: Renamed from LayoutTests/platform/mac/accessibility/progressbar-indeterminate.html.
  • accessibility/mac/radio-button-checkbox-size-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/radio-button-checkbox-size-expected.txt.
  • accessibility/mac/radio-button-checkbox-size.html: Renamed from LayoutTests/platform/mac/accessibility/radio-button-checkbox-size.html.
  • accessibility/mac/range-for-line-textarea-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/range-for-line-textarea-expected.txt.
  • accessibility/mac/range-for-line-textarea.html: Renamed from LayoutTests/platform/mac/accessibility/range-for-line-textarea.html.
  • accessibility/mac/range-for-position-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/range-for-position-expected.txt.
  • accessibility/mac/range-for-position.html: Renamed from LayoutTests/platform/mac/accessibility/range-for-position.html.
  • accessibility/mac/removing-textarea-after-edit-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/removing-textarea-after-edit-crash-expected.txt.
  • accessibility/mac/removing-textarea-after-edit-crash.html: Renamed from LayoutTests/platform/mac/accessibility/removing-textarea-after-edit-crash.html.
  • accessibility/mac/resources/accessibility-helper.js: Renamed from LayoutTests/platform/mac/accessibility/resources/accessibility-helper.js.

(clearSelectionAndFocusOnWebArea):
(elementAtStartMarkerOfSelectedTextMarkerRange):
(caretBrowsingEnabled):
(setCaretBrowsingEnabled):

  • accessibility/mac/resources/cake.png: Renamed from LayoutTests/platform/mac/accessibility/resources/cake.png.
  • accessibility/mac/rowheader-outside-table-role-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/rowheader-outside-table-role-expected.txt.
  • accessibility/mac/rowheader-outside-table-role.html: Renamed from LayoutTests/platform/mac/accessibility/rowheader-outside-table-role.html.
  • accessibility/mac/ruby-hierarchy-roles-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/ruby-hierarchy-roles-expected.txt.
  • accessibility/mac/ruby-hierarchy-roles.html: Renamed from LayoutTests/platform/mac/accessibility/ruby-hierarchy-roles.html.
  • accessibility/mac/scroll-to-visible-action-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/scroll-to-visible-action-expected.txt.
  • accessibility/mac/scroll-to-visible-action.html: Renamed from LayoutTests/platform/mac/accessibility/scroll-to-visible-action.html.
  • accessibility/mac/scrollbars-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/scrollbars-expected.txt.
  • accessibility/mac/scrollbars.html: Renamed from LayoutTests/platform/mac/accessibility/scrollbars.html.
  • accessibility/mac/search-field-cancel-button-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-field-cancel-button-expected.txt.
  • accessibility/mac/search-field-cancel-button.html: Renamed from LayoutTests/platform/mac/accessibility/search-field-cancel-button.html.
  • accessibility/mac/search-predicate-container-not-included-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-container-not-included-expected.txt.
  • accessibility/mac/search-predicate-container-not-included.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-container-not-included.html.
  • accessibility/mac/search-predicate-element-count-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-element-count-expected.txt.
  • accessibility/mac/search-predicate-element-count.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-element-count.html.
  • accessibility/mac/search-predicate-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-expected.txt.
  • accessibility/mac/search-predicate-immediate-descendants-only-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-immediate-descendants-only-expected.txt.
  • accessibility/mac/search-predicate-immediate-descendants-only.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-immediate-descendants-only.html.
  • accessibility/mac/search-predicate-start-not-specified-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-start-not-specified-expected.txt.
  • accessibility/mac/search-predicate-start-not-specified.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate-start-not-specified.html.
  • accessibility/mac/search-predicate.html: Renamed from LayoutTests/platform/mac/accessibility/search-predicate.html.
  • accessibility/mac/search-subrole-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-subrole-expected.txt.
  • accessibility/mac/search-subrole.html: Renamed from LayoutTests/platform/mac/accessibility/search-subrole.html.
  • accessibility/mac/search-when-element-starts-in-table-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table-expected.txt.
  • accessibility/mac/search-when-element-starts-in-table.html: Renamed from LayoutTests/platform/mac/accessibility/search-when-element-starts-in-table.html.
  • accessibility/mac/search-with-frames-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/search-with-frames-expected.txt.
  • accessibility/mac/search-with-frames.html: Renamed from LayoutTests/platform/mac/accessibility/search-with-frames.html.
  • accessibility/mac/secure-text-field-supports-fast-search-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search-expected.txt.
  • accessibility/mac/secure-text-field-supports-fast-search.html: Renamed from LayoutTests/platform/mac/accessibility/secure-text-field-supports-fast-search.html.
  • accessibility/mac/select-element-selection-with-optgroups-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups-expected.txt.
  • accessibility/mac/select-element-selection-with-optgroups.html: Renamed from LayoutTests/platform/mac/accessibility/select-element-selection-with-optgroups.html.
  • accessibility/mac/select-text-should-match-whole-words-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text-should-match-whole-words-expected.txt.
  • accessibility/mac/select-text-should-match-whole-words.html: Renamed from LayoutTests/platform/mac/accessibility/select-text-should-match-whole-words.html.
  • accessibility/mac/select-text-stays-inside-text-controls-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text-stays-inside-text-controls-expected.txt.
  • accessibility/mac/select-text-stays-inside-text-controls.html: Renamed from LayoutTests/platform/mac/accessibility/select-text-stays-inside-text-controls.html.
  • accessibility/mac/select-text/select-text-1-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-1-expected.txt.
  • accessibility/mac/select-text/select-text-1.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-1.html.
  • accessibility/mac/select-text/select-text-135546-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135546-expected.txt.
  • accessibility/mac/select-text/select-text-135546.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135546.html.
  • accessibility/mac/select-text/select-text-135575-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135575-expected.txt.
  • accessibility/mac/select-text/select-text-135575.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-135575.html.
  • accessibility/mac/select-text/select-text-2-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-2-expected.txt.
  • accessibility/mac/select-text/select-text-2.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-2.html.
  • accessibility/mac/select-text/select-text-3-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-3-expected.txt.
  • accessibility/mac/select-text/select-text-3.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-3.html.
  • accessibility/mac/select-text/select-text-4-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-4-expected.txt.
  • accessibility/mac/select-text/select-text-4.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-4.html.
  • accessibility/mac/select-text/select-text-5-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-5-expected.txt.
  • accessibility/mac/select-text/select-text-5.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-5.html.
  • accessibility/mac/select-text/select-text-6-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-6-expected.txt.
  • accessibility/mac/select-text/select-text-6.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-6.html.
  • accessibility/mac/select-text/select-text-7-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-7-expected.txt.
  • accessibility/mac/select-text/select-text-7.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-7.html.
  • accessibility/mac/select-text/select-text-8-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-8-expected.txt.
  • accessibility/mac/select-text/select-text-8.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-8.html.
  • accessibility/mac/select-text/select-text-9-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-9-expected.txt.
  • accessibility/mac/select-text/select-text-9.html: Renamed from LayoutTests/platform/mac/accessibility/select-text/select-text-9.html.
  • accessibility/mac/selected-rows-table-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selected-rows-table-expected.txt.
  • accessibility/mac/selected-rows-table.html: Renamed from LayoutTests/platform/mac/accessibility/selected-rows-table.html.
  • accessibility/mac/selected-tab-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selected-tab-crash-expected.txt.
  • accessibility/mac/selected-tab-crash.html: Renamed from LayoutTests/platform/mac/accessibility/selected-tab-crash.html.
  • accessibility/mac/selected-text-range-for-empty-textarea-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selected-text-range-for-empty-textarea-expected.txt.
  • accessibility/mac/selected-text-range-for-empty-textarea.html: Renamed from LayoutTests/platform/mac/accessibility/selected-text-range-for-empty-textarea.html.
  • accessibility/mac/selection-change-userinfo-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-change-userinfo-expected.txt.
  • accessibility/mac/selection-change-userinfo.html: Renamed from LayoutTests/platform/mac/accessibility/selection-change-userinfo.html.
  • accessibility/mac/selection-element-tabbing-to-link-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-element-tabbing-to-link-expected.txt.
  • accessibility/mac/selection-element-tabbing-to-link.html: Renamed from LayoutTests/platform/mac/accessibility/selection-element-tabbing-to-link.html.
  • accessibility/mac/selection-initial-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-initial-expected.txt.
  • accessibility/mac/selection-initial.html: Renamed from LayoutTests/platform/mac/accessibility/selection-initial.html.
  • accessibility/mac/selection-notification-focus-change-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-notification-focus-change-expected.txt.
  • accessibility/mac/selection-notification-focus-change.html: Renamed from LayoutTests/platform/mac/accessibility/selection-notification-focus-change.html.
  • accessibility/mac/selection-sync-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-sync-expected.txt.
  • accessibility/mac/selection-sync.html: Renamed from LayoutTests/platform/mac/accessibility/selection-sync.html.
  • accessibility/mac/selection-value-changes-for-aria-textbox-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/selection-value-changes-for-aria-textbox-expected.txt.
  • accessibility/mac/selection-value-changes-for-aria-textbox.html: Renamed from LayoutTests/platform/mac/accessibility/selection-value-changes-for-aria-textbox.html.
  • accessibility/mac/setting-attributes-is-asynchronous-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous-expected.txt.
  • accessibility/mac/setting-attributes-is-asynchronous.html: Renamed from LayoutTests/platform/mac/accessibility/setting-attributes-is-asynchronous.html.
  • accessibility/mac/slider-allows-title-ui-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element-expected.txt.
  • accessibility/mac/slider-allows-title-ui-element.html: Renamed from LayoutTests/platform/mac/accessibility/slider-allows-title-ui-element.html.
  • accessibility/mac/slider-supports-actions-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/slider-supports-actions-expected.txt.
  • accessibility/mac/slider-supports-actions.html: Renamed from LayoutTests/platform/mac/accessibility/slider-supports-actions.html.
  • accessibility/mac/spinbutton-valuedescription-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/spinbutton-valuedescription-expected.txt.
  • accessibility/mac/spinbutton-valuedescription.html: Renamed from LayoutTests/platform/mac/accessibility/spinbutton-valuedescription.html.
  • accessibility/mac/stale-table-rows-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/stale-table-rows-expected.txt.
  • accessibility/mac/stale-table-rows.html: Renamed from LayoutTests/platform/mac/accessibility/stale-table-rows.html.
  • accessibility/mac/stale-textmarker-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/stale-textmarker-crash-expected.txt.
  • accessibility/mac/stale-textmarker-crash.html: Renamed from LayoutTests/platform/mac/accessibility/stale-textmarker-crash.html.
  • accessibility/mac/static-text-role-uses-text-under-element-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt.
  • accessibility/mac/static-text-role-uses-text-under-element.html: Renamed from LayoutTests/platform/mac/accessibility/static-text-role-uses-text-under-element.html.
  • accessibility/mac/static-text-with-aria-label-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/static-text-with-aria-label-expected.txt.
  • accessibility/mac/static-text-with-aria-label.html: Renamed from LayoutTests/platform/mac/accessibility/static-text-with-aria-label.html.
  • accessibility/mac/string-range-contains-listmarker-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/string-range-contains-listmarker-expected.txt.
  • accessibility/mac/string-range-contains-listmarker.html: Renamed from LayoutTests/platform/mac/accessibility/string-range-contains-listmarker.html.
  • accessibility/mac/submit-button-default-value-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/submit-button-default-value-expected.txt.
  • accessibility/mac/submit-button-default-value.html: Renamed from LayoutTests/platform/mac/accessibility/submit-button-default-value.html.
  • accessibility/mac/supports-focus-setting-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/supports-focus-setting-expected.txt.
  • accessibility/mac/supports-focus-setting.html: Renamed from LayoutTests/platform/mac/accessibility/supports-focus-setting.html.
  • accessibility/mac/table-column-and-row-count-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-column-and-row-count-expected.txt.
  • accessibility/mac/table-column-and-row-count.html: Renamed from LayoutTests/platform/mac/accessibility/table-column-and-row-count.html.
  • accessibility/mac/table-headers-attribute-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-headers-attribute-expected.txt.
  • accessibility/mac/table-headers-attribute.html: Renamed from LayoutTests/platform/mac/accessibility/table-headers-attribute.html.
  • accessibility/mac/table-multi-bodies-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-multi-bodies-expected.txt.
  • accessibility/mac/table-multi-bodies.html: Renamed from LayoutTests/platform/mac/accessibility/table-multi-bodies.html.
  • accessibility/mac/table-updating-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-updating-expected.txt.
  • accessibility/mac/table-updating.html: Renamed from LayoutTests/platform/mac/accessibility/table-updating.html.
  • accessibility/mac/table-visible-rows-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-visible-rows-expected.txt.
  • accessibility/mac/table-visible-rows.html: Renamed from LayoutTests/platform/mac/accessibility/table-visible-rows.html.
  • accessibility/mac/table-with-row-col-of-headers-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-with-row-col-of-headers-expected.txt.
  • accessibility/mac/table-with-row-col-of-headers.html: Renamed from LayoutTests/platform/mac/accessibility/table-with-row-col-of-headers.html.
  • accessibility/mac/table-with-zebra-rows-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/table-with-zebra-rows-expected.txt.
  • accessibility/mac/table-with-zebra-rows.html: Renamed from LayoutTests/platform/mac/accessibility/table-with-zebra-rows.html.
  • accessibility/mac/test-convenience-methods-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/test-convenience-methods-expected.txt.
  • accessibility/mac/test-convenience-methods.html: Renamed from LayoutTests/platform/mac/accessibility/test-convenience-methods.html.
  • accessibility/mac/text-marker-for-bounds-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/text-marker-for-bounds-expected.txt.
  • accessibility/mac/text-marker-for-bounds.html: Renamed from LayoutTests/platform/mac/accessibility/text-marker-for-bounds.html.
  • accessibility/mac/text-marker-length-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/text-marker-length-expected.txt.
  • accessibility/mac/text-marker-length.html: Renamed from LayoutTests/platform/mac/accessibility/text-marker-length.html.
  • accessibility/mac/textbox-role-reports-line-number-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-line-number-expected.txt.
  • accessibility/mac/textbox-role-reports-line-number.html: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-line-number.html.
  • accessibility/mac/textbox-role-reports-notifications-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-notifications-expected.txt.
  • accessibility/mac/textbox-role-reports-notifications.html: Renamed from LayoutTests/platform/mac/accessibility/textbox-role-reports-notifications.html.
  • accessibility/mac/textmarker-for-index-out-of-bounds-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash-expected.txt.
  • accessibility/mac/textmarker-for-index-out-of-bounds-crash.html: Renamed from LayoutTests/platform/mac/accessibility/textmarker-for-index-out-of-bounds-crash.html.
  • accessibility/mac/textmarker-routines-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/textmarker-routines-expected.txt.
  • accessibility/mac/textmarker-routines.html: Renamed from LayoutTests/platform/mac/accessibility/textmarker-routines.html.
  • accessibility/mac/title-attribute-not-used-as-axtitle-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-not-used-as-axtitle-expected.txt.
  • accessibility/mac/title-attribute-not-used-as-axtitle.html: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-not-used-as-axtitle.html.
  • accessibility/mac/title-attribute-used-as-last-resort-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt.
  • accessibility/mac/title-attribute-used-as-last-resort.html: Renamed from LayoutTests/platform/mac/accessibility/title-attribute-used-as-last-resort.html.
  • accessibility/mac/unexpected-help-text-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/unexpected-help-text-expected.txt.
  • accessibility/mac/unexpected-help-text.html: Renamed from LayoutTests/platform/mac/accessibility/unexpected-help-text.html.
  • accessibility/mac/unsupported-attribute-does-not-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/unsupported-attribute-does-not-crash-expected.txt.
  • accessibility/mac/unsupported-attribute-does-not-crash.html: Renamed from LayoutTests/platform/mac/accessibility/unsupported-attribute-does-not-crash.html.
  • accessibility/mac/update-children-when-aria-role-changes-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/update-children-when-aria-role-changes-expected.txt.
  • accessibility/mac/update-children-when-aria-role-changes.html: Renamed from LayoutTests/platform/mac/accessibility/update-children-when-aria-role-changes.html.
  • accessibility/mac/updating-attribute-in-table-row-crash-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/updating-attribute-in-table-row-crash-expected.txt.
  • accessibility/mac/updating-attribute-in-table-row-crash.html: Renamed from LayoutTests/platform/mac/accessibility/updating-attribute-in-table-row-crash.html.
  • accessibility/mac/value-change-userinfo-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/value-change-userinfo-expected.txt.
  • accessibility/mac/value-change-userinfo.html: Renamed from LayoutTests/platform/mac/accessibility/value-change-userinfo.html.
  • accessibility/mac/visible-position-crash-for-text-node-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/visible-position-crash-for-text-node-expected.txt.
  • accessibility/mac/visible-position-crash-for-text-node.html: Renamed from LayoutTests/platform/mac/accessibility/visible-position-crash-for-text-node.html.
  • accessibility/mac/webarea-can-set-focus-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webarea-can-set-focus-expected.txt.
  • accessibility/mac/webarea-can-set-focus.html: Renamed from LayoutTests/platform/mac/accessibility/webarea-can-set-focus.html.
  • accessibility/mac/webarea-size-equals-content-size-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webarea-size-equals-content-size-expected.txt.
  • accessibility/mac/webarea-size-equals-content-size.html: Renamed from LayoutTests/platform/mac/accessibility/webarea-size-equals-content-size.html.
  • accessibility/mac/webkit-alt-for-css-content-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webkit-alt-for-css-content-expected.txt.
  • accessibility/mac/webkit-alt-for-css-content.html: Renamed from LayoutTests/platform/mac/accessibility/webkit-alt-for-css-content.html.
  • accessibility/mac/webkit-scrollarea-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea-expected.txt.
  • accessibility/mac/webkit-scrollarea-position-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea-position-expected.txt.
  • accessibility/mac/webkit-scrollarea-position.html: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea-position.html.
  • accessibility/mac/webkit-scrollarea.html: Renamed from LayoutTests/platform/mac/accessibility/webkit-scrollarea.html.
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/accessibility/press-action-is-first-expected.txt: Removed.
  • platform/mac/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Removed.
  • platform/wk2/TestExpectations:
7:12 PM Changeset in webkit [187798] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

6:39 PM Changeset in webkit [187797] by mmaxfield@apple.com
  • 6 edits
    2 adds in trunk

REGRESSION(r184899): Crash when focusing an input element styled with a web font
​https://bugs.webkit.org/show_bug.cgi?id=147616
<rdar://problem/21838271>

Reviewed by Dean Jackson.

Source/WebCore:

NSFontManager can't handle web fonts. We used to pass null to NSFontManager in this case,
but r184899 changed that.

Test: fast/text/input-webfont-focus.html

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::activatedFont):

Source/WebKit/mac:

NSFontManager can't handle web fonts. We used to pass null to NSFontManager in this case,
but r184899 changed that.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _updateFontPanel]):

LayoutTests:

  • fast/text/input-webfont-focus-expected.txt: Added.
  • fast/text/input-webfont-focus.html: Added.
6:27 PM Changeset in webkit [187796] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.1

New tag.

6:16 PM Changeset in webkit [187795] by Gyuyoung Kim
  • 21 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Rearrange uses of USE_COORDINATED_GRAPHICS_MULTIPROCESS
​https://bugs.webkit.org/show_bug.cgi?id=147256

Reviewed by Benjamin Poulain.

Reduce uses of USE_COORDINATED_GRAPHICS_MULTIPROCESS guard in order to fix build
breaks when USE_COORDINATED_GRAPHICS_MULTIPROCESS is off. This is first step to switch
between multiprocess model to thread model.

  • PlatformEfl.cmake:
  • Shared/DrawingAreaInfo.h:
  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewFindZoomableAreaForRect):

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:

(WebKit::CoordinatedLayerTreeHostProxy::commitCoordinatedGraphicsState):

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
  • UIProcess/CoordinatedGraphics/PageViewportController.cpp:

(WebKit::PageViewportController::pageTransitionViewportReady):

  • UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp:
  • UIProcess/CoordinatedGraphics/WebView.cpp:
  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::commitPageTransitionViewport):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged):
(WebKit::WebPage::pageDidRequestScroll):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
6:14 PM Changeset in webkit [187794] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix uninitialized property leading to an assert.

  • runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::PutPropertySlot):

6:11 PM Changeset in webkit [187793] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix.

It turns out that the IFEQ command (at least on Cygwin) does not
understand Wildcards for OS types. Consequently, we should not use
Windows* in makefiles. Luckily, we only need Windows_NT anymore.

  • DerivedSources.make: Change Windows* -> Windows_NT to correct build.
5:48 PM Changeset in webkit [187792] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r186916): TextIndicators for multiline link previews are unreadable/offset/blank
​https://bugs.webkit.org/show_bug.cgi?id=147615
<rdar://problem/22116575>

Reviewed by Dean Jackson.

  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
No need to offset by the difference between the text bounding rect and the selection bounding rect,
because the snapshot is now (after r186916) taken of exactly the text bounding rect.

5:39 PM Changeset in webkit [187791] by basile_clement@apple.com
  • 29 edits
    1 add in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Implement the tail call opcodes in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=146850

Reviewed by Michael Saboff.

This patch adds support for tail calls in the DFG. This requires a slightly high number of nodes:

  • TailCall and TailCallVarargs are straightforward. They are terminal nodes and have the semantics of an actual tail call.
  • TailCallInlinedCaller and TailCallVarargsInlinedCaller are here to perform a tail call inside an inlined function. They are non terminal nodes, and are performing the call as a regular call after popping an appropriate number of inlined tail call frames.
  • TailCallForwardVarargs and TailCallForwardVarargsInlinedCaller are the extension of TailCallVarargs and TailCallVarargsInlinedCaller to enable the varargs forwarding optimization so that we don't lose performance with a tail call instead of a regular call.

This also required two broad kind of changes:

  • Changes in the JIT itself (DFGSpeculativeJIT) are pretty straightforward since they are just an extension of the baseline JIT changes introduced previously.
  • Changes in the runtime are mostly related with handling inline call frames. The idea here is that we have a special TailCall type for call frames that indicates to the various pieces of code walking the inline call frame that they should (recursively) skip the caller in their analysis.
  • bytecode/CallMode.h:

(JSC::specializationKindFor):

  • bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::isApproximatelyEqualTo):
(JSC::CodeOrigin::approximateHash):
(JSC::CodeOrigin::inlineStack):
(JSC::InlineCallFrame::dumpInContext):
(WTF::printInternal):

  • bytecode/CodeOrigin.h:

(JSC::InlineCallFrame::callModeFor):
(JSC::InlineCallFrame::kindFor):
(JSC::InlineCallFrame::varargsKindFor):
(JSC::InlineCallFrame::specializationKindFor):
(JSC::InlineCallFrame::isVarargs):
(JSC::InlineCallFrame::isTail):
(JSC::InlineCallFrame::computeCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerInlineFrameSkippingDeadFrames):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::findTerminal):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::allInlineFramesAreTailCalls):
(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::forAllLocalsLiveInBytecode):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasCallVarargsData):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):

  • dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGVarargsForwardingPhase.cpp:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::bytecodeOffsetFromCodeOriginIndex):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::gotoNextFrame):

  • jit/CCallHelpers.h:
  • tests/stress/dfg-tail-calls.js: Added.
5:30 PM Changeset in webkit [187790] by mrajca@apple.com
  • 9 edits in trunk/Source

Media Session: let UI clients query whether a media element is paused
​https://bugs.webkit.org/show_bug.cgi?id=147588

Reviewed by Tim Horton.

WebCore:

  • page/Page.cpp:

(WebCore::Page::isMediaElementPaused): Determine if the media element with the given ID is paused.

  • page/Page.h:

WebKit2: Added plumbing to determine if a page's media element is paused.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isMediaElementPaused):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::isMediaElementPaused):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
5:19 PM Changeset in webkit [187789] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187751. rdar://problem/22018044

5:19 PM Changeset in webkit [187788] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/LayoutTests

Merge r187778. rdar://problem/22098457

5:19 PM Changeset in webkit [187787] by matthew_hanson@apple.com
  • 1 edit
    5 adds in branches/safari-601.1-branch/LayoutTests

Merge r187752. rdar://problem/22098457

5:19 PM Changeset in webkit [187786] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187740. rdar://problem/22098457

5:19 PM Changeset in webkit [187785] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187466. rdar://problem/21960398

5:19 PM Changeset in webkit [187784] by matthew_hanson@apple.com
  • 1 edit in branches/safari-601.1-branch/Source/WebCore/ChangeLog

Merge r187675. rdar://problem/21632211

4:45 PM Changeset in webkit [187783] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix Windows.

  • bytecode/ObjectPropertyConditionSet.h:

(JSC::ObjectPropertyConditionSet::fromRawPointer):

4:29 PM Changeset in webkit [187782] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/LayoutTests

Merge r187778. rdar://problem/22098457

4:29 PM Changeset in webkit [187781] by matthew_hanson@apple.com
  • 1 edit
    5 adds in branches/safari-601.1.46-branch/LayoutTests

Merge r187752. rdar://problem/22098457

4:13 PM Changeset in webkit [187780] by fpizlo@apple.com
  • 48 edits
    24 adds
    4 deletes in trunk

DFG should have adaptive structure watchpoints
​https://bugs.webkit.org/show_bug.cgi?id=146929

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Before this change, if you wanted to efficiently validate whether an object has (or doesn't have) a
property, you'd check that the object still has the structure that you first saw the object have. We
optimized this a bit with transition watchpoints on the structure, which sometimes allowed us to
elide the structure check.

But this approach fails when that object frequently has new properties added to it. This would
change the structure and fire the transition watchpoint, so the code we emitted would be invalid and
we'd have to recompile either the IC or an entire code block.

This change introduces a new concept: an object property condition. This value describes some
condition involving a property on some object. There are four kinds: presence, absence,
absence-of-setter, and equivalence. For example, a presence condition says that we expect that the
object has some property at some offset with some attributes. This allows us to implement a new kind
of watchpoint, which knows about the object property condition that it's being used to enforce. If
the watchpoint fires because of a structure transition, the watchpoint may simply reinstall itself
on the new structure.

Object property conditions are used on the prototype chain of PutById transitions, GetById misses,
and prototype accesses. They are also used for any DFG accesses to object constants, including
global property accesses.

Mostly because of the effect on global property access, this is a 9% speed-up on Kraken. It's
neutral on most other things. It's a 68x speed-up on a microbenchmark that illustrates the prototype
chain situation. It's also a small speed-up on getter-richards.

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):

  • bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

  • bytecode/ComplexGetStatus.h:

(JSC::ComplexGetStatus::ComplexGetStatus):
(JSC::ComplexGetStatus::takesSlowPath):
(JSC::ComplexGetStatus::kind):
(JSC::ComplexGetStatus::offset):
(JSC::ComplexGetStatus::conditionSet):
(JSC::ComplexGetStatus::attributes): Deleted.
(JSC::ComplexGetStatus::specificValue): Deleted.
(JSC::ComplexGetStatus::chain): Deleted.

  • bytecode/ConstantStructureCheck.cpp: Removed.
  • bytecode/ConstantStructureCheck.h: Removed.
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::~GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):
(JSC::GetByIdVariant::baseStructure): Deleted.

  • bytecode/GetByIdVariant.h:

(JSC::GetByIdVariant::operator!):
(JSC::GetByIdVariant::structureSet):
(JSC::GetByIdVariant::conditionSet):
(JSC::GetByIdVariant::offset):
(JSC::GetByIdVariant::callLinkStatus):
(JSC::GetByIdVariant::constantChecks): Deleted.
(JSC::GetByIdVariant::alternateBase): Deleted.

  • bytecode/ObjectPropertyCondition.cpp: Added.

(JSC::ObjectPropertyCondition::dumpInContext):
(JSC::ObjectPropertyCondition::dump):
(JSC::ObjectPropertyCondition::structureEnsuresValidityAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::validityRequiresImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::isStillValid):
(JSC::ObjectPropertyCondition::structureEnsuresValidity):
(JSC::ObjectPropertyCondition::isWatchableAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::isWatchable):
(JSC::ObjectPropertyCondition::isStillLive):
(JSC::ObjectPropertyCondition::validateReferences):
(JSC::ObjectPropertyCondition::attemptToMakeEquivalenceWithoutBarrier):

  • bytecode/ObjectPropertyCondition.h: Added.

(JSC::ObjectPropertyCondition::ObjectPropertyCondition):
(JSC::ObjectPropertyCondition::presenceWithoutBarrier):
(JSC::ObjectPropertyCondition::presence):
(JSC::ObjectPropertyCondition::absenceWithoutBarrier):
(JSC::ObjectPropertyCondition::absence):
(JSC::ObjectPropertyCondition::absenceOfSetterWithoutBarrier):
(JSC::ObjectPropertyCondition::absenceOfSetter):
(JSC::ObjectPropertyCondition::equivalenceWithoutBarrier):
(JSC::ObjectPropertyCondition::equivalence):
(JSC::ObjectPropertyCondition::operator!):
(JSC::ObjectPropertyCondition::object):
(JSC::ObjectPropertyCondition::condition):
(JSC::ObjectPropertyCondition::kind):
(JSC::ObjectPropertyCondition::uid):
(JSC::ObjectPropertyCondition::hasOffset):
(JSC::ObjectPropertyCondition::offset):
(JSC::ObjectPropertyCondition::hasAttributes):
(JSC::ObjectPropertyCondition::attributes):
(JSC::ObjectPropertyCondition::hasPrototype):
(JSC::ObjectPropertyCondition::prototype):
(JSC::ObjectPropertyCondition::hasRequiredValue):
(JSC::ObjectPropertyCondition::requiredValue):
(JSC::ObjectPropertyCondition::hash):
(JSC::ObjectPropertyCondition::operator==):
(JSC::ObjectPropertyCondition::isHashTableDeletedValue):
(JSC::ObjectPropertyCondition::isCompatibleWith):
(JSC::ObjectPropertyCondition::watchingRequiresStructureTransitionWatchpoint):
(JSC::ObjectPropertyCondition::watchingRequiresReplacementWatchpoint):
(JSC::ObjectPropertyCondition::isValidValueForPresence):
(JSC::ObjectPropertyConditionHash::hash):
(JSC::ObjectPropertyConditionHash::equal):

  • bytecode/ObjectPropertyConditionSet.cpp: Added.

(JSC::ObjectPropertyConditionSet::forObject):
(JSC::ObjectPropertyConditionSet::forConditionKind):
(JSC::ObjectPropertyConditionSet::numberOfConditionsWithKind):
(JSC::ObjectPropertyConditionSet::hasOneSlotBaseCondition):
(JSC::ObjectPropertyConditionSet::slotBaseCondition):
(JSC::ObjectPropertyConditionSet::mergedWith):
(JSC::ObjectPropertyConditionSet::structuresEnsureValidity):
(JSC::ObjectPropertyConditionSet::structuresEnsureValidityAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyConditionSet::needImpurePropertyWatchpoint):
(JSC::ObjectPropertyConditionSet::areStillLive):
(JSC::ObjectPropertyConditionSet::dumpInContext):
(JSC::ObjectPropertyConditionSet::dump):
(JSC::generateConditionsForPropertyMiss):
(JSC::generateConditionsForPropertySetterMiss):
(JSC::generateConditionsForPrototypePropertyHit):
(JSC::generateConditionsForPrototypePropertyHitCustom):
(JSC::generateConditionsForPropertySetterMissConcurrently):

  • bytecode/ObjectPropertyConditionSet.h: Added.

(JSC::ObjectPropertyConditionSet::ObjectPropertyConditionSet):
(JSC::ObjectPropertyConditionSet::invalid):
(JSC::ObjectPropertyConditionSet::nonEmpty):
(JSC::ObjectPropertyConditionSet::isValid):
(JSC::ObjectPropertyConditionSet::isEmpty):
(JSC::ObjectPropertyConditionSet::begin):
(JSC::ObjectPropertyConditionSet::end):
(JSC::ObjectPropertyConditionSet::releaseRawPointer):
(JSC::ObjectPropertyConditionSet::adoptRawPointer):
(JSC::ObjectPropertyConditionSet::fromRawPointer):
(JSC::ObjectPropertyConditionSet::Data::Data):

  • bytecode/PolymorphicGetByIdList.cpp:

(JSC::GetByIdAccess::GetByIdAccess):
(JSC::GetByIdAccess::~GetByIdAccess):
(JSC::GetByIdAccess::visitWeak):

  • bytecode/PolymorphicGetByIdList.h:

(JSC::GetByIdAccess::GetByIdAccess):
(JSC::GetByIdAccess::structure):
(JSC::GetByIdAccess::conditionSet):
(JSC::GetByIdAccess::stubRoutine):
(JSC::GetByIdAccess::chain): Deleted.
(JSC::GetByIdAccess::chainCount): Deleted.

  • bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::fromStructureStubInfo):
(JSC::PutByIdAccess::visitWeak):

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::PutByIdAccess):
(JSC::PutByIdAccess::transition):
(JSC::PutByIdAccess::setter):
(JSC::PutByIdAccess::newStructure):
(JSC::PutByIdAccess::conditionSet):
(JSC::PutByIdAccess::stubRoutine):
(JSC::PutByIdAccess::chain): Deleted.
(JSC::PutByIdAccess::chainCount): Deleted.

  • bytecode/PropertyCondition.cpp: Added.

(JSC::PropertyCondition::dumpInContext):
(JSC::PropertyCondition::dump):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):
(JSC::PropertyCondition::validityRequiresImpurePropertyWatchpoint):
(JSC::PropertyCondition::isStillValid):
(JSC::PropertyCondition::isWatchableWhenValid):
(JSC::PropertyCondition::isWatchableAssumingImpurePropertyWatchpoint):
(JSC::PropertyCondition::isWatchable):
(JSC::PropertyCondition::isStillLive):
(JSC::PropertyCondition::validateReferences):
(JSC::PropertyCondition::isValidValueForAttributes):
(JSC::PropertyCondition::isValidValueForPresence):
(JSC::PropertyCondition::attemptToMakeEquivalenceWithoutBarrier):
(WTF::printInternal):

  • bytecode/PropertyCondition.h: Added.

(JSC::PropertyCondition::PropertyCondition):
(JSC::PropertyCondition::presenceWithoutBarrier):
(JSC::PropertyCondition::presence):
(JSC::PropertyCondition::absenceWithoutBarrier):
(JSC::PropertyCondition::absence):
(JSC::PropertyCondition::absenceOfSetterWithoutBarrier):
(JSC::PropertyCondition::absenceOfSetter):
(JSC::PropertyCondition::equivalenceWithoutBarrier):
(JSC::PropertyCondition::equivalence):
(JSC::PropertyCondition::operator!):
(JSC::PropertyCondition::kind):
(JSC::PropertyCondition::uid):
(JSC::PropertyCondition::hasOffset):
(JSC::PropertyCondition::offset):
(JSC::PropertyCondition::hasAttributes):
(JSC::PropertyCondition::attributes):
(JSC::PropertyCondition::hasPrototype):
(JSC::PropertyCondition::prototype):
(JSC::PropertyCondition::hasRequiredValue):
(JSC::PropertyCondition::requiredValue):
(JSC::PropertyCondition::hash):
(JSC::PropertyCondition::operator==):
(JSC::PropertyCondition::isHashTableDeletedValue):
(JSC::PropertyCondition::isCompatibleWith):
(JSC::PropertyCondition::watchingRequiresStructureTransitionWatchpoint):
(JSC::PropertyCondition::watchingRequiresReplacementWatchpoint):
(JSC::PropertyConditionHash::hash):
(JSC::PropertyConditionHash::equal):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::operator=):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::setter):
(JSC::PutByIdVariant::makesCalls):
(JSC::PutByIdVariant::attemptToMerge):
(JSC::PutByIdVariant::attemptToMergeTransitionWithReplace):
(JSC::PutByIdVariant::dumpInContext):
(JSC::PutByIdVariant::baseStructure): Deleted.

  • bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::kind):
(JSC::PutByIdVariant::structure):
(JSC::PutByIdVariant::structureSet):
(JSC::PutByIdVariant::oldStructure):
(JSC::PutByIdVariant::conditionSet):
(JSC::PutByIdVariant::offset):
(JSC::PutByIdVariant::callLinkStatus):
(JSC::PutByIdVariant::constantChecks): Deleted.
(JSC::PutByIdVariant::alternateBase): Deleted.

  • bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::~StructureStubClearingWatchpoint):
(JSC::StructureStubClearingWatchpoint::push):
(JSC::StructureStubClearingWatchpoint::fireInternal):
(JSC::WatchpointsOnStructureStubInfo::~WatchpointsOnStructureStubInfo):
(JSC::WatchpointsOnStructureStubInfo::addWatchpoint):
(JSC::WatchpointsOnStructureStubInfo::ensureReferenceAndAddWatchpoint):

  • bytecode/StructureStubClearingWatchpoint.h:

(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):
(JSC::WatchpointsOnStructureStubInfo::codeBlock):
(JSC::WatchpointsOnStructureStubInfo::stubInfo):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::visitWeakReferences):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::setSeen):
(JSC::StructureStubInfo::addWatchpoint):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp: Added.

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::AdaptiveInferredPropertyValueWatchpoint):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::install):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::fire):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::fireInternal):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::fireInternal):

  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h: Added.

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::key):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::StructureWatchpoint):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::PropertyWatchpoint):

  • dfg/DFGAdaptiveStructureWatchpoint.cpp: Added.

(JSC::DFG::AdaptiveStructureWatchpoint::AdaptiveStructureWatchpoint):
(JSC::DFG::AdaptiveStructureWatchpoint::install):
(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

  • dfg/DFGAdaptiveStructureWatchpoint.h: Added.

(JSC::DFG::AdaptiveStructureWatchpoint::key):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::cellConstantWithStructureCheck):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::check):
(JSC::DFG::ByteCodeParser::promoteToConstant):
(JSC::DFG::ByteCodeParser::planLoad):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::presenceLike):
(JSC::DFG::ByteCodeParser::checkPresenceLike):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::emitChecks): Deleted.

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::validateReferences):

  • dfg/DFGCommonData.h:
  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::addBaseCheck):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
(JSC::DFG::ConstantFoldingPhase::addChecks): Deleted.

  • dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
(JSC::DFG::InferredValueAdaptor::add):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):
(JSC::DFG::DesiredWatchpoints::DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::consider):
(JSC::DFG::DesiredWatchpoints::reallyAdd):
(JSC::DFG::DesiredWatchpoints::areStillValid):
(JSC::DFG::DesiredWatchpoints::dumpInContext):

  • dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::SetPointerAdaptor::add):
(JSC::DFG::SetPointerAdaptor::hasBeenInvalidated):
(JSC::DFG::SetPointerAdaptor::dumpInContext):
(JSC::DFG::InferredValueAdaptor::hasBeenInvalidated):
(JSC::DFG::InferredValueAdaptor::dumpInContext):
(JSC::DFG::ArrayBufferViewWatchpointAdaptor::hasBeenInvalidated):
(JSC::DFG::ArrayBufferViewWatchpointAdaptor::dumpInContext):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::hasBeenInvalidated):
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::dumpInContext):
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::isWatched):
(JSC::DFG::GenericDesiredWatchpoints::dumpInContext):
(JSC::DFG::DesiredWatchpoints::isWatched):
(JSC::DFG::GenericSetAdaptor::add): Deleted.
(JSC::DFG::GenericSetAdaptor::hasBeenInvalidated): Deleted.

  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::addLazily):
(JSC::DFG::DesiredWeakReferences::contains):

  • dfg/DFGDesiredWeakReferences.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::clearFlagsOnAllNodes):
(JSC::DFG::Graph::watchCondition):
(JSC::DFG::Graph::isSafeToLoad):
(JSC::DFG::Graph::livenessFor):
(JSC::DFG::Graph::tryGetConstantProperty):
(JSC::DFG::Graph::visitChildren):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::identifiers):
(JSC::DFG::Graph::watchpoints):

  • dfg/DFGMultiGetByOffsetData.cpp: Added.

(JSC::DFG::GetByOffsetMethod::dumpInContext):
(JSC::DFG::GetByOffsetMethod::dump):
(JSC::DFG::MultiGetByOffsetCase::dumpInContext):
(JSC::DFG::MultiGetByOffsetCase::dump):
(WTF::printInternal):

  • dfg/DFGMultiGetByOffsetData.h: Added.

(JSC::DFG::GetByOffsetMethod::GetByOffsetMethod):
(JSC::DFG::GetByOffsetMethod::constant):
(JSC::DFG::GetByOffsetMethod::load):
(JSC::DFG::GetByOffsetMethod::loadFromPrototype):
(JSC::DFG::GetByOffsetMethod::operator!):
(JSC::DFG::GetByOffsetMethod::kind):
(JSC::DFG::GetByOffsetMethod::prototype):
(JSC::DFG::GetByOffsetMethod::offset):
(JSC::DFG::MultiGetByOffsetCase::MultiGetByOffsetCase):
(JSC::DFG::MultiGetByOffsetCase::set):
(JSC::DFG::MultiGetByOffsetCase::method):

  • dfg/DFGNode.h:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileMultiGetByOffset):

  • jit/Repatch.cpp:

(JSC::repatchByIdSelfAccess):
(JSC::checkObjectPropertyCondition):
(JSC::checkObjectPropertyConditions):
(JSC::replaceWithJump):
(JSC::generateByIdStub):
(JSC::actionForCell):
(JSC::tryBuildGetByIDList):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::tryRepatchIn):
(JSC::addStructureTransitionCheck): Deleted.
(JSC::emitPutTransitionStubAndGetOldStructure): Deleted.

  • runtime/IntendedStructureChain.cpp: Removed.
  • runtime/IntendedStructureChain.h: Removed.
  • runtime/JSCJSValue.h:
  • runtime/JSObject.cpp:

(JSC::throwTypeError):
(JSC::JSObject::convertToDictionary):
(JSC::JSObject::shiftButterflyAfterFlattening):

  • runtime/JSObject.h:

(JSC::JSObject::flattenDictionaryObject):
(JSC::JSObject::convertToDictionary): Deleted.

  • runtime/Operations.h:

(JSC::normalizePrototypeChain):
(JSC::normalizePrototypeChainForChainAccess): Deleted.
(JSC::isPrototypeChainNormalized): Deleted.

  • runtime/PropertySlot.h:

(JSC::PropertySlot::PropertySlot):
(JSC::PropertySlot::slotBase):

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::toCacheableDictionaryTransition):
(JSC::Structure::toUncacheableDictionaryTransition):
(JSC::Structure::ensurePropertyReplacementWatchpointSet):
(JSC::Structure::startWatchingPropertyForReplacements):
(JSC::Structure::didCachePropertyReplacement):
(JSC::Structure::dump):

  • runtime/Structure.h:
  • runtime/VM.h:
  • tests/stress/fold-multi-get-by-offset-to-get-by-offset-without-folding-the-structure-check-new.js: Added.

(foo):
(bar):
(baz):

  • tests/stress/multi-get-by-offset-self-or-proto.js: Added.

(foo):

  • tests/stress/replacement-watchpoint-dictionary.js: Added.

(foo):

  • tests/stress/replacement-watchpoint.js: Added.

(foo):

  • tests/stress/undefined-access-dictionary-then-proto-change.js: Added.

(foo):

  • tests/stress/undefined-access-then-proto-change.js: Added.

(foo):

LayoutTests:

  • js/regress/global-object-access-with-mutating-structure-expected.txt: Added.
  • js/regress/global-object-access-with-mutating-structure.html: Added.
  • js/regress/prototype-access-with-mutating-prototype-expected.txt: Added.
  • js/regress/prototype-access-with-mutating-prototype.html: Added.
  • js/regress/script-tests/global-object-access-with-mutating-structure.js: Added.

(foo):

  • js/regress/script-tests/prototype-access-with-mutating-prototype.js: Added.

(foo):

  • js/regress/script-tests/undefined-property-access.js:

(foo):
(bar):
(baz):

3:45 PM Changeset in webkit [187779] by benjamin@webkit.org
  • 1 edit
    3 adds in trunk/Websites/webkit.org

Prepare screenshots for a potential blog post

  • blog-files/css-selectors-level-4/dynamic-specificity-1x.png: Added.
  • blog-files/css-selectors-level-4/dynamic-specificity-2x.png: Added.
3:40 PM Changeset in webkit [187778] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Fix ASSERTy test added in r187752

  • http/tests/appcache/resources/identifier-test-real.php: Only post one message.
3:34 PM Changeset in webkit [187777] by Simon Fraser
  • 3 edits
    144 moves
    1 add in trunk/LayoutTests

Move platform/gtk/accessibility tests into accessibility/gtk
​https://bugs.webkit.org/show_bug.cgi?id=147594

Move platform/gtk/accessibility tests into accessibility/gtk. Skip them in global TestExpectations, re-enable them in platform/gtk/TestExpectations.

  • TestExpectations:
  • accessibility/gtk/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt.
  • accessibility/gtk/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-fallback-roles-expected.txt.
  • accessibility/gtk/aria-help-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-help-expected.txt.
  • accessibility/gtk/aria-hidden-false-works-in-subtrees-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt.
  • accessibility/gtk/aria-inherits-presentational-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-inherits-presentational-expected.txt.
  • accessibility/gtk/aria-listbox-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-listbox-crash-expected.txt.
  • accessibility/gtk/aria-listbox-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-listbox-crash.html.
  • accessibility/gtk/aria-menubar-menuitems-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-menubar-menuitems-expected.txt.
  • accessibility/gtk/aria-options-and-menuitems-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-options-and-menuitems-crash-expected.txt.
  • accessibility/gtk/aria-options-and-menuitems-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-options-and-menuitems-crash.html.
  • accessibility/gtk/aria-roles-unignored-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-roles-unignored-expected.txt.
  • accessibility/gtk/aria-roles-unignored.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-roles-unignored.html.
  • accessibility/gtk/aria-slider-required-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes-expected.txt.
  • accessibility/gtk/aria-slider-required-attributes.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-slider-required-attributes.html.
  • accessibility/gtk/aria-switch-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-switch-text-expected.txt.
  • accessibility/gtk/aria-table-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-table-hierarchy-expected.txt.
  • accessibility/gtk/aria-toggle-button-role-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-toggle-button-role-expected.txt.
  • accessibility/gtk/aria-toggle-button-role.html: Renamed from LayoutTests/platform/gtk/accessibility/aria-toggle-button-role.html.
  • accessibility/gtk/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt.
  • accessibility/gtk/button-accessible-name-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt.
  • accessibility/gtk/button-accessible-name.html: Renamed from LayoutTests/platform/gtk/accessibility/button-accessible-name.html.
  • accessibility/gtk/caret-browsing-select-focus-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-select-focus-expected.txt.
  • accessibility/gtk/caret-browsing-select-focus.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-select-focus.html.
  • accessibility/gtk/caret-browsing-text-focus-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-text-focus-expected.txt.
  • accessibility/gtk/caret-browsing-text-focus.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-browsing-text-focus.html.
  • accessibility/gtk/caret-offsets-and-extraneous-white-spaces-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces-expected.txt.
  • accessibility/gtk/caret-offsets-and-extraneous-white-spaces.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets-and-extraneous-white-spaces.html.
  • accessibility/gtk/caret-offsets-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets-expected.txt.
  • accessibility/gtk/caret-offsets.html: Renamed from LayoutTests/platform/gtk/accessibility/caret-offsets.html.
  • accessibility/gtk/color-well-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/color-well-expected.txt.
  • accessibility/gtk/combobox-descendants-orientation-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/combobox-descendants-orientation-crash-expected.txt.
  • accessibility/gtk/combobox-descendants-orientation-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/combobox-descendants-orientation-crash.html.
  • accessibility/gtk/css-content-attribute-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/css-content-attribute-expected.txt.
  • accessibility/gtk/detached-object-role-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/detached-object-role-expected.txt.
  • accessibility/gtk/detached-object-role.html: Renamed from LayoutTests/platform/gtk/accessibility/detached-object-role.html.
  • accessibility/gtk/dimensions-include-descendants-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/dimensions-include-descendants-expected.txt.
  • accessibility/gtk/disabled-controls-not-focusable-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/disabled-controls-not-focusable-expected.txt.
  • accessibility/gtk/entry-and-password-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/entry-and-password-expected.txt.
  • accessibility/gtk/entry-and-password.html: Renamed from LayoutTests/platform/gtk/accessibility/entry-and-password.html.
  • accessibility/gtk/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt.
  • accessibility/gtk/image-link-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-link-expected.txt.
  • accessibility/gtk/image-map1-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-map1-expected.txt.
  • accessibility/gtk/image-map2-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-map2-expected.txt.
  • accessibility/gtk/image-with-alt-and-map-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/image-with-alt-and-map-expected.txt.
  • accessibility/gtk/img-fallsback-to-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/img-fallsback-to-title-expected.txt.
  • accessibility/gtk/inline-continuations-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/inline-continuations-expected.txt.
  • accessibility/gtk/input-slider-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/input-slider-expected.txt.
  • accessibility/gtk/input-slider.html: Renamed from LayoutTests/platform/gtk/accessibility/input-slider.html.
  • accessibility/gtk/list-detection-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/list-detection-expected.txt.
  • accessibility/gtk/list-items-always-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/list-items-always-exposed-expected.txt.
  • accessibility/gtk/list-items-always-exposed.html: Renamed from LayoutTests/platform/gtk/accessibility/list-items-always-exposed.html.
  • accessibility/gtk/lists-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/lists-expected.txt.
  • accessibility/gtk/math-multiscript-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-multiscript-attributes-expected.txt.
  • accessibility/gtk/math-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/math-text-expected.txt.
  • accessibility/gtk/media-controls-panel-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/media-controls-panel-title-expected.txt.
  • accessibility/gtk/media-controls-panel-title.html: Renamed from LayoutTests/platform/gtk/accessibility/media-controls-panel-title.html.
  • accessibility/gtk/media-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/media-element-expected.txt.
  • accessibility/gtk/media-emits-object-replacement-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/media-emits-object-replacement-expected.txt.
  • accessibility/gtk/media-emits-object-replacement.html: Renamed from LayoutTests/platform/gtk/accessibility/media-emits-object-replacement.html.
  • accessibility/gtk/menu-list-crash2-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-crash2-expected.txt.
  • accessibility/gtk/menu-list-sends-change-notification-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt.
  • accessibility/gtk/menu-list-unfocused-notifications-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-unfocused-notifications-expected.txt.
  • accessibility/gtk/menu-list-unfocused-notifications.html: Renamed from LayoutTests/platform/gtk/accessibility/menu-list-unfocused-notifications.html.
  • accessibility/gtk/meter-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/meter-element-expected.txt.
  • accessibility/gtk/name-from-label-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/name-from-label-expected.txt.
  • accessibility/gtk/name-from-label.html: Renamed from LayoutTests/platform/gtk/accessibility/name-from-label.html.
  • accessibility/gtk/no-notification-for-unrendered-iframe-children-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/no-notification-for-unrendered-iframe-children-expected.txt.
  • accessibility/gtk/no-notification-for-unrendered-iframe-children.html: Renamed from LayoutTests/platform/gtk/accessibility/no-notification-for-unrendered-iframe-children.html.
  • accessibility/gtk/object-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/object-attributes-expected.txt.
  • accessibility/gtk/object-attributes.html: Renamed from LayoutTests/platform/gtk/accessibility/object-attributes.html.
  • accessibility/gtk/object-with-title-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/object-with-title-expected.txt.
  • accessibility/gtk/object-with-title.html: Renamed from LayoutTests/platform/gtk/accessibility/object-with-title.html.
  • accessibility/gtk/platform-name-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/platform-name-expected.txt.
  • accessibility/gtk/plugin-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/plugin-expected.txt.
  • accessibility/gtk/press-targets-center-point-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/press-targets-center-point-expected.txt.
  • accessibility/gtk/radio-button-title-label-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/radio-button-title-label-expected.txt.
  • accessibility/gtk/remapped-aria-crash-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/remapped-aria-crash-expected.txt.
  • accessibility/gtk/remapped-aria-crash.html: Renamed from LayoutTests/platform/gtk/accessibility/remapped-aria-crash.html.
  • accessibility/gtk/render-counter-text-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/render-counter-text-expected.txt.
  • accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks-expected.txt.
  • accessibility/gtk/replaced-objects-in-anonymous-blocks.html: Renamed from LayoutTests/platform/gtk/accessibility/replaced-objects-in-anonymous-blocks.html.
  • accessibility/gtk/roles-computedRoleString-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/roles-computedRoleString-expected.txt.
  • accessibility/gtk/roles-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt.
  • accessibility/gtk/spans-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/spans-expected.txt.
  • accessibility/gtk/spans-paragraphs-and-divs-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs-expected.txt.
  • accessibility/gtk/spans-paragraphs-and-divs.html: Renamed from LayoutTests/platform/gtk/accessibility/spans-paragraphs-and-divs.html.
  • accessibility/gtk/spans.html: Renamed from LayoutTests/platform/gtk/accessibility/spans.html.
  • accessibility/gtk/spinbutton-value-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt.
  • accessibility/gtk/tabindex-elements-are-accessible-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt.
  • accessibility/gtk/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt.
  • accessibility/gtk/table-cell-spans-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-cell-spans-expected.txt.
  • accessibility/gtk/table-cells-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-cells-expected.txt.
  • accessibility/gtk/table-column-headers-with-captions-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-column-headers-with-captions-expected.txt.
  • accessibility/gtk/table-detection-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-detection-expected.txt.
  • accessibility/gtk/table-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-hierarchy-expected.txt.
  • accessibility/gtk/table-one-cell-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-one-cell-expected.txt.
  • accessibility/gtk/table-roles-hierarchy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-roles-hierarchy-expected.txt.
  • accessibility/gtk/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-sections-expected.txt.
  • accessibility/gtk/table-with-rules-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-with-rules-expected.txt.
  • accessibility/gtk/text-at-offset-embedded-objects-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-embedded-objects-expected.txt.
  • accessibility/gtk/text-at-offset-embedded-objects.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-embedded-objects.html.
  • accessibility/gtk/text-at-offset-newlines-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-newlines-expected.txt.
  • accessibility/gtk/text-at-offset-newlines.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-newlines.html.
  • accessibility/gtk/text-at-offset-preformatted-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-preformatted-expected.txt.
  • accessibility/gtk/text-at-offset-preformatted.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-preformatted.html.
  • accessibility/gtk/text-at-offset-simple-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-simple-expected.txt.
  • accessibility/gtk/text-at-offset-simple.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-simple.html.
  • accessibility/gtk/text-at-offset-special-chars-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-special-chars-expected.txt.
  • accessibility/gtk/text-at-offset-special-chars.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-special-chars.html.
  • accessibility/gtk/text-at-offset-textarea-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textarea-expected.txt.
  • accessibility/gtk/text-at-offset-textarea.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textarea.html.
  • accessibility/gtk/text-at-offset-textinput-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textinput-expected.txt.
  • accessibility/gtk/text-at-offset-textinput.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-textinput.html.
  • accessibility/gtk/text-at-offset-wrapped-lines-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-wrapped-lines-expected.txt.
  • accessibility/gtk/text-at-offset-wrapped-lines.html: Renamed from LayoutTests/platform/gtk/accessibility/text-at-offset-wrapped-lines.html.
  • accessibility/gtk/text-for-range-combo-box-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-combo-box-expected.txt.
  • accessibility/gtk/text-for-range-combo-box.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-combo-box.html.
  • accessibility/gtk/text-for-range-embedded-objects-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-embedded-objects-expected.txt.
  • accessibility/gtk/text-for-range-embedded-objects.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-embedded-objects.html.
  • accessibility/gtk/text-for-range-entry-and-password-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-entry-and-password-expected.txt.
  • accessibility/gtk/text-for-range-entry-and-password.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-entry-and-password.html.
  • accessibility/gtk/text-for-range-extraneous-whitespace-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-extraneous-whitespace-expected.txt.
  • accessibility/gtk/text-for-range-extraneous-whitespace.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-extraneous-whitespace.html.
  • accessibility/gtk/text-for-range-formatted-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-formatted-expected.txt.
  • accessibility/gtk/text-for-range-formatted.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-formatted.html.
  • accessibility/gtk/text-for-range-heading-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-heading-expected.txt.
  • accessibility/gtk/text-for-range-heading.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-heading.html.
  • accessibility/gtk/text-for-range-list-items-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-list-items-expected.txt.
  • accessibility/gtk/text-for-range-list-items.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-list-items.html.
  • accessibility/gtk/text-for-range-simple-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-simple-expected.txt.
  • accessibility/gtk/text-for-range-simple.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-simple.html.
  • accessibility/gtk/text-for-range-table-cells-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-table-cells-expected.txt.
  • accessibility/gtk/text-for-range-table-cells.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-table-cells.html.
  • accessibility/gtk/text-for-range-with-link-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-with-link-expected.txt.
  • accessibility/gtk/text-for-range-with-link.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-range-with-link.html.
  • accessibility/gtk/text-for-table-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-for-table-expected.txt.
  • accessibility/gtk/text-for-table.html: Renamed from LayoutTests/platform/gtk/accessibility/text-for-table.html.
  • accessibility/gtk/text-in-span-block-in-a-block-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block-expected.txt.
  • accessibility/gtk/text-in-span-block-in-a-block.html: Renamed from LayoutTests/platform/gtk/accessibility/text-in-span-block-in-a-block.html.
  • accessibility/gtk/title-and-alt-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/title-and-alt-expected.txt.
  • accessibility/gtk/title-and-alt.html: Renamed from LayoutTests/platform/gtk/accessibility/title-and-alt.html.
  • accessibility/gtk/transformed-element-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/transformed-element-expected.txt.
  • accessibility/gtk/xml-roles-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/xml-roles-exposed-expected.txt.
  • accessibility/gtk/xml-roles-exposed.html: Renamed from LayoutTests/platform/gtk/accessibility/xml-roles-exposed.html.
  • platform/gtk/TestExpectations:
3:20 PM Changeset in webkit [187776] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Always require user gesture to begin playing to AppleTV automatically
​https://bugs.webkit.org/show_bug.cgi?id=147591

Reviewed by Jer Noble.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaState): Don't set the ExternalDeviceAutoPlayCandidate

flag until the user has explicitly triggered playback.

3:05 PM Changeset in webkit [187775] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r187708): Breakpoint dialog script action editing broken
​https://bugs.webkit.org/show_bug.cgi?id=147553

Reviewed by Joseph Pecoraro.

Passing a widget to CodeMirror.setBookmark generates a viewportChange event, causing the
BreakpointActionView to update the popup for the breakpoint. The spurious update dismisses
the suggestion list, removes the CodeMirror completion hint, and causes other problems.

Now we ignore viewportChange events unless the viewport size changes. We still want to update
the popup when a carriage return or text wrap modifies the viewport.

  • UserInterface/Views/BreakpointActionView.js:

(WebInspector.BreakpointActionView.prototype._updateBody):
Evaluate and Probe actions store the current viewport size.
(WebInspector.BreakpointActionView.prototype._codeMirrorViewportChanged):
Check if viewport size has changed since last event.

2:59 PM Changeset in webkit [187774] by ap@apple.com
  • 2 edits in trunk/Tools

AppScale: Add required indices
​https://bugs.webkit.org/show_bug.cgi?id=147593

Reviewed by Tim Horton.

  • QueueStatusServer/index.yaml:
2:56 PM Changeset in webkit [187773] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Application cache DataGrid has incorrect column heading styles
​https://bugs.webkit.org/show_bug.cgi?id=147531

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ApplicationCacheFrameContentView.js:

(WebInspector.ApplicationCacheFrameContentView): Remove erroneous
"storage-view" class, which is intended for databases, not AppCache.

2:53 PM Changeset in webkit [187772] by fpizlo@apple.com
  • 3 edits
    2 adds in trunk

Check in LLVM 3.6.2 binary drops for El Capitan
​https://bugs.webkit.org/show_bug.cgi?id=147582

Reviewed by Alexey Proskuryakov.

Tools:

Recognize 10.11 and use the right drops.

  • Scripts/copy-webkitlibraries-to-product-directory:

WebKitLibraries:

Check in drops built from the LLVM 3.6.2 open source release.

These drops were built by doing:

1) Check out WebKit to a directory like /some/path/OpenSource.

2) Unpack LLVM 3.6.2 into /some/path/OpenSource/llvm. I got LLVM 3.6.2 from:

​http://llvm.org/releases/3.6.2/llvm-3.6.2.src.tar.xz

3) While in /some/path/OpenSource, run Tools/Scripts/build-jsc --release. Make sure it's a
totally clean build (i.e. delete WebKitBuild before starting).

4) Run the following to create binary drops:

Tools/Scripts/export-llvm-build -i WebKitLibraries/LLVMIncludesElCapitan.tar.bz2 -l WebKitLibraries/LLVMLibrariesElCapitan.tar.bz2 -b llvm/wkLLVMBuild -B llvm/wkLLVMBuild/Release+Asserts -s llvm

  • LLVMIncludesElCapitan.tar.bz2: Added.
  • LLVMLibrariesElCapitan.tar.bz2: Added.
2:49 PM Changeset in webkit [187771] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187740. rdar://problem/22098457

2:49 PM Changeset in webkit [187770] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187466. rdar://problem/21960398

2:49 PM Changeset in webkit [187769] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r187731. rdar://problem/22052829

2:49 PM Changeset in webkit [187768] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r187751. rdar://problem/22018044

2:39 PM Changeset in webkit [187767] by basile_clement@apple.com
  • 5 edits
    1 add in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Kraken/stanford-crypto-ccm crashes
​https://bugs.webkit.org/show_bug.cgi?id=147561

Reviewed by Michael Saboff.

When performing a tail call, we assume that if the top of the tail
caller's frame is not stack-aligned, we can use the stack slot above it
in case we need to move the top of the frame. However, we don't enforce
this when actually performing a call, which leads to interesting (and
crashing) situations. We are already enforcing this in the "special
call" cases (calls from native code, inlined cache calls, etc.), so
this is just a matter of making sure the bytecode generator, DFG and
FTL ensure proper padding.

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallArguments::CallArguments):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):

  • tests/stress/mutual-tail-call-no-stack-overflow.js:

(odd):
(even):

  • tests/stress/tail-calls-dont-overwrite-live-stack.js: Added.

(tail):
(obj.method):
(obj.get fromNative):
(getThis):

2:37 PM Changeset in webkit [187766] by Simon Fraser
  • 1 edit
    64 deletes in trunk/LayoutTests

Remove Windows XP test results
​https://bugs.webkit.org/show_bug.cgi?id=147592

Reviewed by Brent Fulgham.

We no longer need to maintain Windows XP test results.

  • platform/win-xp/TestExpectations: Removed.
  • platform/win-xp/*: Removed.
2:30 PM Changeset in webkit [187765] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

Make sure error handling code APIUserContentExtensionStore closes open file descriptors
​https://bugs.webkit.org/show_bug.cgi?id=147562

Reviewed by Alex Christensen.

Make sure error handling code APIUserContentExtensionStore closes open
file descriptors to avoid leaking them.

  • NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::adoptAndMapFile):

  • UIProcess/API/APIUserContentExtensionStore.cpp:

(API::compiledToFile):

2:27 PM Changeset in webkit [187764] by Beth Dakin
  • 7 edits in trunk/Source/WebKit2

Need WKWebView API to enable/disable link preview
​https://bugs.webkit.org/show_bug.cgi?id=147573
-and corresponding-
rdar://problem/22077836

Reviewed by Dan Bernstein.

WKView implementation.

  • UIProcess/API/Cocoa/WKViewPrivate.h:

New API. Call into WKView to handle Mac.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView allowsLinkPreview]):
(-[WKWebView setAllowsLinkPreview:]):

Remove the SPI declaration from WKWebViewPrivate in order to make this API.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Handle the Mac side.

  • UIProcess/API/mac/WKView.mm:

(-[WKView viewDidMoveToWindow]):
(-[WKView initWithFrame:processPool:configuration:webView:]):
(-[WKView allowsBackForwardNavigationGestures]):
(-[WKView allowsLinkPreview]):
(-[WKView setAllowsLinkPreview:]):

Don’t register previews when link preview is prevented.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _registerPreview]):

2:26 PM Changeset in webkit [187763] by Yusuke Suzuki
  • 4 edits
    1 add in trunk

JavascriptCore Crash in JSC::ASTBuilder::Property JSC::Parser<JSC::Lexer<unsigned char> >::parseProperty<JSC::ASTBuilder>(JSC::ASTBuilder&, bool)
​https://bugs.webkit.org/show_bug.cgi?id=147538

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Due to the order of the ARROWFUNCTION token in JSTokenType enum, it is categorized as the one of the Keyword.
As a result, when lexing the property name that can take the keywords, the ARROWFUNCTION token is accidentally accepted.
This patch changes the order of the ARROWFUNCTION token in JSTokenType to make it the operator token.

  • parser/ParserTokens.h:
  • tests/stress/arrow-function-token-is-not-keyword.js: Added.

(testSyntaxError):

LayoutTests:

Update the test expectation file because '=>' is a token, not a keywowrd.

  • js/arrowfunction-syntax-errors-expected.txt:
2:05 PM Changeset in webkit [187762] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Inline video controls overlap each other while playing video in slideover mode
​https://bugs.webkit.org/show_bug.cgi?id=147535
<rdar://problem/22026864>

Reviewed by Eric Carlson.

Now that the resizing code is in the shared controller, we need to
make sure to hide the timeline scrubber in iOS when the controls
get too small. This involved adding the dropped class to the timeline,
and rules for hiding to the CSS.

Meanwhile, when the page scale factor is less than one, we use the CSS zoom property
and don't need to factor in the page scale factor when calculating
the size.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updateLayoutForDisplayedWidth): Don't use pageScaleFactor.

  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-panel .dropped): Add display none for this rule.

1:56 PM Changeset in webkit [187761] by basile_clement@apple.com
  • 2 edits
    1 add in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Get and put inline caches are not properly restoring the stack pointer
​https://bugs.webkit.org/show_bug.cgi?id=147583

Reviewed by Michael Saboff.

If there is a tail call in a getter, we can't rely on the stack pointer
being valid after returning from the call.

  • jit/Repatch.cpp:

(JSC::generateByIdStub):

  • tests/stress/tail-call-in-inline-cache.js: Added.

(tail):
(obj.get x):

1:47 PM Changeset in webkit [187760] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Clean up the naming for AST expression generation.
​https://bugs.webkit.org/show_bug.cgi?id=147581

Patch by Keith Miller <​keith_miller@apple.com> on 2015-08-03
Reviewed by Yusuke Suzuki.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createThisExpr):
(JSC::ASTBuilder::createSuperExpr):
(JSC::ASTBuilder::createNewTargetExpr):
(JSC::ASTBuilder::thisExpr): Deleted.
(JSC::ASTBuilder::superExpr): Deleted.
(JSC::ASTBuilder::newTargetExpr): Deleted.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createThisExpr):
(JSC::SyntaxChecker::createSuperExpr):
(JSC::SyntaxChecker::createNewTargetExpr):
(JSC::SyntaxChecker::thisExpr): Deleted.
(JSC::SyntaxChecker::superExpr): Deleted.
(JSC::SyntaxChecker::newTargetExpr): Deleted.

1:46 PM Changeset in webkit [187759] by msaboff@apple.com
  • 4 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Callee save registers should be saved after the stack pointer is set up
​https://bugs.webkit.org/show_bug.cgi?id=147580

Reviewed by Basile Clement.

Moved the saving of callee saves to after we check for stack overflow and have
set up the stack pointer.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • llint/LowLevelInterpreter.asm:
1:40 PM Changeset in webkit [187758] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Safari is failing to remove SQLite Databases via Remove All Website Data
​https://bugs.webkit.org/show_bug.cgi?id=147584
rdar://problem/22095006

Reviewed by Brady Eidson.

If we end up deleting every single database for an origin, make sure to also delete the origin.

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabasesModifiedSince):

1:29 PM Changeset in webkit [187757] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Move "starting from root" frame flattening logging to the correct place.
​https://bugs.webkit.org/show_bug.cgi?id=147571

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded):
(WebCore::FrameView::layout): Deleted.

1:23 PM Changeset in webkit [187756] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Link previews sometimes don't hide the link highlight
​https://bugs.webkit.org/show_bug.cgi?id=147585
<rdar://problem/22119648>

Reviewed by Beth Dakin.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interactionStartedFromPreviewItemController:]):
(-[WKContentView _interactionStoppedFromPreviewItemController:]):
(-[WKContentView _previewItemController:didDismissPreview:committing:]):
(-[WKContentView _previewItemController:willPresentPreview:forPosition:inSourceView:]): Deleted.
Use interactionStarted/Stopped, which are always called, instead of didDismiss/willPresent,
which are only called if we return a custom view controller from _presentedViewControllerForPreviewItemController.
We continue using didDismiss to inform clients of dismissal because they'll
only care if they customized the view controller.

12:54 PM Changeset in webkit [187755] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

12:52 PM Changeset in webkit [187754] by bshafiei@apple.com
  • 1 copy in branches/safari-601.1.46-branch

New Branch.

12:35 PM Changeset in webkit [187753] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Do not munmap() on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=147569

Reviewed by Geoffrey Garen.

Do not munmap() on the main thread for performance reasons and
consistency as we already make sure to mmap() on another thread.

  • NetworkProcess/cache/NetworkCacheDataCocoa.mm:

(WebKit::NetworkCache::Data::adoptMap):

12:35 PM Changeset in webkit [187752] by beidson@apple.com
  • 1 edit
    5 adds in trunk/LayoutTests

Adding a test for:
Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).
<rdar://problem/22098457> and ​https://bugs.webkit.org/show_bug.cgi?id=147560

Reviewed by Alexey Proskuryakov.

  • http/tests/appcache/identifier-test-expected.txt: Added.
  • http/tests/appcache/identifier-test.html: Added.
  • http/tests/appcache/resources/identifier-test-real.php: Added.
  • http/tests/appcache/resources/identifier-test.manifest: Added.
  • http/tests/appcache/resources/identifier-test.php: Added.
12:29 PM Changeset in webkit [187751] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit2

Inputs with the autofocus attribute cause the keyboard to not deploy
​https://bugs.webkit.org/show_bug.cgi?id=147555
<rdar://problem/22018044>

Reviewed by Andreas Kling.

Upon submitting a form by pressing "Go" on the keyboard, an <input> on the next page with the
autofocus attribute may become non-interactible. When attempting to tap on the input, nothing
seems to happen. This is because the state of WebPage upon invoking WebPage::elementDidFocus
indicates (incorrectly) that the input element is already focused, and therefore hits an early
return. To solve this, we explicitly reset m_hasFocusedDueToUserInteraction upon transitioning
to a new page.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didStartPageTransition): On iOS, resets m_hasFocusedDueToUserInteraction as

well. It was previously thought that this would be handled by blur() called on the assisted
element when submitting a form. However, pressing "Go" on the iOS keyboard is an implicit
submission and does not trigger a blur event.

12:25 PM Changeset in webkit [187750] by Yusuke Suzuki
  • 5 edits
    1 add in trunk/Source/JavaScriptCore

Don't set up the callsite to operationGetByValDefault when the optimization is already done
​https://bugs.webkit.org/show_bug.cgi?id=147577

Reviewed by Filip Pizlo.

operationGetByValDefault should be called only when the IC is not set.
operationGetByValString breaks this invariant and ASSERT(!byValInfo.stubRoutine) in
operationGetByValDefault raises the assertion failure.
In this patch, we change the callsite setting up code in operationGetByValString when
the IC is already set. And to make the operation's meaning explicitly, we changed the
name operationGetByValDefault to operationGetByValOptimize, that is aligned to the
GetById case.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitSlow_op_get_by_val):

  • tests/stress/operation-get-by-val-default-should-not-called-for-already-optimized-site.js: Added.

(hello):

12:20 PM Changeset in webkit [187749] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Fix error handling case in Cache::dumpContentsToFile()
​https://bugs.webkit.org/show_bug.cgi?id=147567

Reviewed by Andreas Kling.

Cache::dumpContentsToFile() was expecting openFile() to return 0 in case
of error. However, it returns invalidPlatformFileHandle, which is -1 on
Unix.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::dumpContentsToFile):

11:47 AM Changeset in webkit [187748] by mmaxfield@apple.com
  • 35 edits
    2 deletes in trunk

Unreviewed, rolling out r187729.
​https://bugs.webkit.org/show_bug.cgi?id=147575

10% performance hit (Requested by litherum on #webkit).

Reverted changeset:

"[OS X] Font fallback is not language-sensitive"
​https://bugs.webkit.org/show_bug.cgi?id=147390
​http://trac.webkit.org/changeset/187729

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-08-03

11:45 AM Changeset in webkit [187747] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

Make sure WebMemorySampler doesn't leak file descriptor
​https://bugs.webkit.org/show_bug.cgi?id=147564

Reviewed by Anders Carlsson.

WebMemorySampler was opening files but never closing them.

  • Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::stop):

  • Shared/WebMemorySampler.h:
11:24 AM Changeset in webkit [187746] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

ChildWidgetState::ChildWidgetIs* naming is redundant.
​https://bugs.webkit.org/show_bug.cgi?id=147565

Reviewed by Simon Fraser.

Since strongly typed enum requires to write out 'ChildWidgetState::ChildWidgetIsDestroyed',
the enumerator list names can be shortened.

No change in behaviour.

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::peformLayoutWithFlattening):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition):

  • rendering/RenderWidget.h:
10:59 AM Changeset in webkit [187745] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Make it possible to use String::utf8() in the debugger
​https://bugs.webkit.org/show_bug.cgi?id=147566

Reviewed by Tim Horton.

Add a new utf8() overload that doesn't take any parameters and just calls utf8(LenientConversion), since lldb doesn't support evaluating
function calls with default parameters at the moment.

  • wtf/text/WTFString.cpp:

(WTF::String::utf8):

  • wtf/text/WTFString.h:
10:52 AM Changeset in webkit [187744] by bshafiei@apple.com
  • 5 edits in branches/safari-600.8-branch/Source

Versioning.

10:28 AM Changeset in webkit [187743] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.17-branch/Source

Versioning.

10:28 AM Changeset in webkit [187742] by Csaba Osztrogonác
  • 1 edit
    4 deletes in trunk/Source/JavaScriptCore

[FTL] Remove unused scripts related to native call inlining
​https://bugs.webkit.org/show_bug.cgi?id=147448

Reviewed by Filip Pizlo.

  • build-symbol-table-index.py: Removed.
  • copy-llvm-ir-to-derived-sources.sh: Removed.
  • create-llvm-ir-from-source-file.py: Removed.
  • create-symbol-table-index.py: Removed.
10:14 AM Changeset in webkit [187741] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

Pass ControlStates& to RenderTheme methods instead of ControlStates*
​https://bugs.webkit.org/show_bug.cgi?id=147521

Reviewed by Andreas Kling.

No change in functionality.

  • platform/Theme.h:

(WebCore::Theme::selectionColor):
(WebCore::Theme::paint):
(WebCore::Theme::inflateControlPaintRect):

  • platform/mac/ThemeMac.h:
  • platform/mac/ThemeMac.mm:

(WebCore::updateStates):
(WebCore::convertControlStatesToThemeDrawState):
(WebCore::configureToggleButton):
(WebCore::sharedRadioCell):
(WebCore::sharedCheckboxCell):
(WebCore::paintToggleButton):
(WebCore::setUpButtonCell):
(WebCore::button):
(WebCore::paintButton):
(WebCore::paintStepper):
(WebCore::ThemeMac::ensuredView):
(WebCore::ThemeMac::inflateControlPaintRect):
(WebCore::ThemeMac::paint):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustRepaintRect):
(WebCore::RenderTheme::updateControlStatesForRenderer):

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::documentViewFor):

10:06 AM Changeset in webkit [187740] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when signing into twitter calling WebCore::DocumentLoader::responseReceived(WebCore::CachedResource*, WebCore::ResourceResponse const&).
<rdar://problem/22098457> and ​https://bugs.webkit.org/show_bug.cgi?id=147560

Reviewed by Alexey Proskuryakov.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest): Only grab identifierForLoadWithoutResourceLoader() if there's no ResourceLoader.

9:06 AM Changeset in webkit [187739] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

themePainted in RenderBox::paintBoxDecorations() is confusing.
​https://bugs.webkit.org/show_bug.cgi?id=147492

Reviewed by Andreas Kling.

What themePainted is supposed to indicate is whether the theme requires additional border and background painting.
Rename it to borderOrBackgroundPaintingIsNeeded.

No change in behaviour.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

8:55 AM Changeset in webkit [187738] by achristensen@apple.com
  • 2 edits in trunk/Tools

[Win] Build fix after r187733.

  • WinLauncher/PageLoadTestClient.cpp:

(PageLoadTestClient::dumpRunStatistics):
wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.

8:38 AM Changeset in webkit [187737] by youenn.fablet@crf.canon.fr
  • 4 edits
    2 deletes in trunk/Source/WebCore

[EFL] http/tests/media/media-stream/disconnected-frame-already.html is crashing after r185903
​https://bugs.webkit.org/show_bug.cgi?id=146834

Reviewed by Eric Carlson.

r185903 went to far in removing some tests, in particular whether the current process is related to a frame.
Readded that check.
Refactored the code to remove the need for NavigatorUserMedia class.

Covered by existing tests.

  • CMakeLists.txt: Removed NavigatorUserMedia.cpp.
  • Modules/mediastream/NavigatorUserMedia.cpp: Removed.
  • Modules/mediastream/NavigatorUserMedia.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSNavigatorCustom.cpp:

(WebCore::JSNavigator::webkitGetUserMedia): Inlined NavigatorUserMeia::webkitGetUserMedia.

5:48 AM Changeset in webkit [187736] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/Source/WebCore

JSXMLHttpRequest::visitAdditionalChildren does not need to explicitly mark m_response
​https://bugs.webkit.org/show_bug.cgi?id=147488

Reviewed by Andreas Kling.

Covered by existing tests.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitAdditionalChildren): Removed m_response marking.

1:36 AM Changeset in webkit [187735] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.9.5

WebKitGTK+ 2.9.5

1:34 AM Changeset in webkit [187734] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.9.5 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.9.5.
Note: See TracTimeline for information about the timeline view.