Timeline



Sep 24, 2015:

11:58 PM Changeset in webkit [190237] by dbates@webkit.org
  • 4 edits
    2 adds in trunk

Add WebKitSystemInterface for iOS 9.0
​https://bugs.webkit.org/show_bug.cgi?id=149550

Rubber-stamped by Alexey Proskuryakov.

Tools:

  • Scripts/copy-webkitlibraries-to-product-directory:

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceIOSDevice9.0.a: Added.
  • libWebKitSystemInterfaceIOSSimulator9.0.a: Added.
10:14 PM Changeset in webkit [190236] by Beth Dakin
  • 2 edits in trunk/LayoutTests

This started failing after this rollout:
​http://trac.webkit.org/changeset/190232

  • platform/mac/TestExpectations:
8:41 PM Changeset in webkit [190235] by Brent Fulgham
  • 8 edits in trunk/Source

[Win] Support composited content in WebView render-to-context methods
​https://bugs.webkit.org/show_bug.cgi?id=149516
<rdar://problem/22635080>

Reviewed by Simon Fraser.

Source/WebCore:

Extend the CACFLayerTreeHost implementation to render into a passed
device context when requested. When no context is provided (the default
case) paint as normal.

Will be tested by existing compositing tests in a future bug. DumpRenderTree
has to be extended to do this painting properly.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::paint): Accept an optional HDC argument, and
pass it to the render method.

  • platform/graphics/ca/win/CACFLayerTreeHost.h:
  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Add missing SOFT_LINK

command for the WKCACFViewDrawIntoDC.
(WebCore::WKCACFViewLayerTreeHost::paint): Accept optional HDC argument and
pass it to the parent class.
(WebCore::WKCACFViewLayerTreeHost::render): Accept new optional HDC argument.
If provided, call WKCACFViewDrawIntoDC. Otherwise, call WKCACFVIewDraw.
(WebCore::WKCACFViewLayerTreeHost::setShouldInvertColors):

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:

Source/WebKit/win:

  • WebView.cpp:

(WebView::paint): Call the new 'paintCompositedContentToHDC' method. If
it handles the pain, return.
(WebView::paintCompositedContentToHDC): New method to share code with other
paint methods.
(WebView::paintDocumentRectToContext): Call new 'paintCompositedContentToHDC'
to handle any composited layers. Otherwise, use slow drawing path.
(WebView::paintScrollViewRectToContextAtPoint): Ditto.

  • WebView.h:
7:56 PM Changeset in webkit [190234] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Drop [NotDeletable] from QuickTimePluginReplacement.postEvent()
​https://bugs.webkit.org/show_bug.cgi?id=149547

Reviewed by Eric Carlson.

Drop [NotDeletable] from QuickTimePluginReplacement.postEvent(). It does
not appear to be needed and this is the last user of this non-standard
IDL attribute. This patch also drops support for this IDL attribute.

  • Modules/plugins/QuickTimePluginReplacement.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(ComputeFunctionSpecial):

  • bindings/scripts/IDLAttributes.txt:
7:48 PM Changeset in webkit [190233] by Chris Dumez
  • 7 edits in trunk

Node.replaceChild() does not behave according to the specification
​https://bugs.webkit.org/show_bug.cgi?id=149546
<rdar://problem/22571887>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that one more check is passing.

  • web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt:

Source/WebCore:

Node.replaceChild() does not behave according to the specification. In
particular, when replacing |child| with |node| we are supposed to remove
|node| from its parent *before* removing |child| from its parent:

This patch reverses the order as per the specification. Our new behavior
matches Firefox's behavior. Note that this patch also remove an
optimization when replacing a child with its next sibling. This
optimization was observable from JS. It seems likely this case is not
common enough for it to be an issue. However, we can revisit if we see
it regresses things.

This leads to incorrect Mutation Records being queued in some cases.

No new tests, already covered by existing test.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild):

LayoutTests:

Update existing test that now throws a different exception.

  • fast/events/mutation-during-replace-child-expected.txt:
  • fast/events/mutation-during-replace-child.html:
6:50 PM Changeset in webkit [190232] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Unreviewed, roll out r187615 as it seems to have caused a ~1% PLT regression.
<rdar://problem/22657123>

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagsKey):

  • platform/graphics/FontCascade.cpp:

(WebCore::operator==):
(WebCore::makeFontSelectorFlags):
(WebCore::makeFontCascadeCacheKey):
(WebCore::computeFontCascadeCacheHash):

5:54 PM Changeset in webkit [190231] by hyatt@apple.com
  • 13 edits in trunk/Source/WebCore

Keep the already-parsed list of terms in custom property values so that we don't have to re-parse them
later when doing variable resolution.
​https://bugs.webkit.org/show_bug.cgi?id=149544

Reviewed by Dean Jackson.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::customPropertyText):
Add a helper for getting the raw text. More closely parallels how non-custom properties work with the
extractor.

(WebCore::ComputedStyleExtractor::propertyValue):
Change propertyValue to use customPropertyText.

(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
Don't copy CSS custom properties into the style declaration. This is just used for things like editing, so
we didn't need to be putting the custom properties into this set.

(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
Patched to go straight to the serialized string value.

(WebCore::ComputedStyleExtractor::customPropertyValue): Deleted.
Replaced by customPropertyText.

  • css/CSSComputedStyleDeclaration.h:

Rename customPropertyValue to customPropertyText and make it just return a String.

  • css/CSSCustomPropertyValue.h:

(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::customCSSText):
(WebCore::CSSCustomPropertyValue::name):
(WebCore::CSSCustomPropertyValue::equals):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
(WebCore::CSSCustomPropertyValue::value): Deleted.
Changed to hold both a CSSParserValueList, which it adopts from the CSSParser, and a string value that
is constructed lazily only if the value is serialized. Now the problematic serialization code will only
run if someone uses the CSS OM to trigger a serialization (this should be a rare occurrence, so perf
improves with this change).

  • css/CSSGrammar.y.in:

Change parsing of custom properties to be identical to regular properties. This refactoring allows
us to simply invoke the parser from style declarations as well and makes everything behave more
similarly to normal property parsing.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyValue):
(WebCore::CSSParser::parseCustomPropertyDeclaration):
(WebCore::CSSParser::addCustomPropertyDeclaration): Deleted.

  • css/CSSParser.h:

(WebCore::CSSParser::setCustomPropertyName):
We now have a method for parsing custom properties that can be invoked from style declarations. The
parser list is now adopted by the CSSCustomPropertyValue.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValueList::toString):
Build the string serialization code right into CSSParserValueList.

  • css/CSSParserValues.h:

Add a toString() method for serialization.

  • css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::setProperty):
(WebCore::MutableStyleProperties::setCustomProperty):
Changed to use the new CSSParser functions. This makes the code behave almost identically to regular
property parsing.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleCustomPropertyData.h:

Change the mapping on RenderStyle to store the custom CSS values. This way we can get to the original
parser lists for each variable when it comes time to do variable resolution.

5:17 PM Changeset in webkit [190230] by mark.lam@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Remove the use of "Immediate" in JIT function names.
​https://bugs.webkit.org/show_bug.cgi?id=149542

Reviewed by Geoffrey Garen.

We will rename the following:

isOperandConstantImmediateDouble => isOperandConstantDouble
isOperandConstantImmediateInt => isOperandConstantInt
isOperandConstantImmediateChar => isOperandConstantChar

getOperandConstantImmediateInt => getOperandConstantInt
getConstantOperandImmediateInt => getOperandConstantInt

emitJumpIfImmediateInteger => emitJumpIfInt
emitJumpIfNotImmediateInteger => emitJumpIfNotInt
emitJumpIfNotImmediateIntegers => emitJumpIfNotInt
emitPatchableJumpIfNotImmediateInteger => emitPatchableJumpIfNotInt
emitJumpSlowCaseIfNotImmediateInteger => emitJumpSlowCaseIfNotInt
emitJumpSlowCaseIfNotImmediateNumber => emitJumpSlowCaseIfNotNumber
emitJumpSlowCaseIfNotImmediateIntegers => emitJumpSlowCaseIfNotInt
emitFastArithReTagImmediate => emitTagInt
emitTagAsBoolImmediate => emitTagBool
emitJumpIfImmediateNumber => emitJumpIfNumber
emitJumpIfNotImmediateNumber => emitJumpIfNotNumber
emitFastArithImmToInt - Deleted because this is an empty function.
emitFastArithIntToImmNoCheck => emitTagInt
emitPutImmediateToCallFrameHeader => emitPutToCallFrameHeader

This is purely a refactoring patch to do the renaming. There is no behavior
change.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileSetupRegistersForEntry):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::AssemblyHelpers::emitPutImmediateToCallFrameHeader): Deleted.

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JSC::JIT::emitStoreCell):
(JSC::JIT::getSlowCase):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):

  • jit/JITInlines.h:

(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::isOperandConstantDouble):
(JSC::JIT::isOperandConstantChar):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
(JSC::JIT::isOperandConstantInt):
(JSC::JIT::getOperandConstantInt):
(JSC::JIT::emitGetVirtualRegisters):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitJumpIfInt):
(JSC::JIT::emitJumpIfNotInt):
(JSC::JIT::emitPatchableJumpIfNotInt):
(JSC::JIT::emitJumpSlowCaseIfNotInt):
(JSC::JIT::emitJumpSlowCaseIfNotNumber):
(JSC::JIT::emitTagBool):
(JSC::JIT::isOperandConstantImmediateDouble): Deleted.
(JSC::JIT::isOperandConstantImmediateChar): Deleted.
(JSC::JIT::isOperandConstantImmediateInt): Deleted.
(JSC::JIT::getOperandConstantImmediateInt): Deleted.
(JSC::JIT::getConstantOperandImmediateInt): Deleted.
(JSC::JIT::emitJumpIfImmediateInteger): Deleted.
(JSC::JIT::emitJumpIfNotImmediateInteger): Deleted.
(JSC::JIT::emitPatchableJumpIfNotImmediateInteger): Deleted.
(JSC::JIT::emitJumpIfNotImmediateIntegers): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateInteger): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegers): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateNumber): Deleted.
(JSC::JIT::emitFastArithReTagImmediate): Deleted.
(JSC::JIT::emitTagAsBoolImmediate): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_profile_type):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
(JSC::JSInterfaceJIT::emitJumpIfNumber):
(JSC::JSInterfaceJIT::emitJumpIfNotNumber):
(JSC::JSInterfaceJIT::emitLoadDouble):
(JSC::JSInterfaceJIT::emitTagInt):
(JSC::JSInterfaceJIT::emitPutToCallFrameHeader):
(JSC::JSInterfaceJIT::emitJumpIfImmediateNumber): Deleted.
(JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber): Deleted.
(JSC::JSInterfaceJIT::emitFastArithImmToInt): Deleted.
(JSC::JSInterfaceJIT::emitFastArithIntToImmNoCheck): Deleted.
(JSC::JSInterfaceJIT::emitPutImmediateToCallFrameHeader): Deleted.

  • jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::startFunction):
(JSC::WASMFunctionCompiler::endFunction):

4:33 PM Changeset in webkit [190229] by Chris Dumez
  • 8 edits in trunk

Rewrite Range::insertNode() as per the latest DOM specification
​https://bugs.webkit.org/show_bug.cgi?id=149528

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C DOM tests now that more tests are passing.

  • web-platform-tests/dom/ranges/Range-insertNode-expected.txt:
  • web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Rewrite Range::insertNode() as per the latest DOM specification:

Our previous implementation seemed outdated as we were failing a lot of
W3C tests that Firefox is passing.

No new tests, already covered by existing tests.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::ensurePreInsertionValidity):
(WebCore::checkPreReplacementValidity):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):

  • dom/ContainerNode.h:
  • dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::surroundContents):
(WebCore::Range::toString): Deleted.
(WebCore::Range::toHTML): Deleted.
(WebCore::Range::text): Deleted.
(WebCore::Range::createContextualFragment): Deleted.
(WebCore::Range::detach): Deleted.
(WebCore::Range::absoluteBoundingBox): Deleted.

  • dom/Range.h:
4:03 PM Changeset in webkit [190228] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Find hole drawn at subframe's 0x0 when a subframe find match is not rendered
​https://bugs.webkit.org/show_bug.cgi?id=149543

Reviewed by Beth Dakin.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::rectsForTextMatches):
Don't add empty rects to the list. Later code will just inflate them
and end up drawing a nonsensical find hole.

3:53 PM Changeset in webkit [190227] by Beth Dakin
  • 2 edits in trunk/LayoutTests

The same problem happens on El Capitan.

  • platform/mac/TestExpectations:
3:51 PM Changeset in webkit [190226] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.10.1

New tag.

3:40 PM Changeset in webkit [190225] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build failure.

  • bindings/js/WebCoreJSClientData.h: Make sure Streams API headers

are only included if the feature is on.

2:58 PM Changeset in webkit [190224] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46.10-branch

Merged r189997. rdar://problem/22845894

2:56 PM Changeset in webkit [190223] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46.10-branch/Source

Versioning.

2:53 PM Changeset in webkit [190222] by bshafiei@apple.com
  • 1 copy in branches/safari-601.1.46.10-branch

New Branch.

2:45 PM Changeset in webkit [190221] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline web-platform-tests/html/dom/interfaces.html for iOS after r190190

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
2:42 PM Changeset in webkit [190220] by msaboff@apple.com
  • 33 edits in trunk/Source/JavaScriptCore

[ES6] Implement tail calls in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=148663

Reviewed by Filip Pizlo.

jsc-tailcall: Implement the tail call opcodes in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=146850

This patch adds support for tail calls in the DFG. This requires a slightly high number of nodes:

  • TailCall and TailCallVarargs are straightforward. They are terminal nodes and have the semantics of an actual tail call.
  • TailCallInlinedCaller and TailCallVarargsInlinedCaller are here to perform a tail call inside an inlined function. They are non terminal nodes, and are performing the call as a regular call after popping an appropriate number of inlined tail call frames.
  • TailCallForwardVarargs and TailCallForwardVarargsInlinedCaller are the extension of TailCallVarargs and TailCallVarargsInlinedCaller to enable the varargs forwarding optimization so that we don't lose performance with a tail call instead of a regular call.

This also required two broad kind of changes:

  • Changes in the JIT itself (DFGSpeculativeJIT) are pretty straightforward since they are just an extension of the baseline JIT changes introduced previously.
  • Changes in the runtime are mostly related with handling inline call frames. The idea here is that we have a special TailCall type for call frames that indicates to the various pieces of code walking the inline call frame that they should (recursively) skip the caller in their analysis.
  • bytecode/CallMode.h:

(JSC::specializationKindFor):

  • bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::isApproximatelyEqualTo):
(JSC::CodeOrigin::approximateHash):
(JSC::CodeOrigin::inlineStack):

  • bytecode/CodeOrigin.h:
  • bytecode/InlineCallFrame.cpp:

(JSC::InlineCallFrame::dumpInContext):
(WTF::printInternal):

  • bytecode/InlineCallFrame.h:

(JSC::InlineCallFrame::callModeFor):
(JSC::InlineCallFrame::kindFor):
(JSC::InlineCallFrame::varargsKindFor):
(JSC::InlineCallFrame::specializationKindFor):
(JSC::InlineCallFrame::isVarargs):
(JSC::InlineCallFrame::isTail):
(JSC::InlineCallFrame::computeCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerInlineFrameSkippingDeadFrames):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArgumentsEliminationPhase.cpp:
  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::findTerminal):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inlineCallFrame):
(JSC::DFG::ByteCodeParser::allInlineFramesAreTailCalls):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::forAllLocalsLiveInBytecode):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::willCatchExceptionInMachineFrame):

  • dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::FlushLiveCatchVariablesInsertionPhase::willCatchException):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasCallVarargsData):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::osrWriteBarrier):

  • dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit):

  • dfg/DFGOperations.cpp:
  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateSSA):

  • dfg/DFGVarargsForwardingPhase.cpp:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::bytecodeOffset):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::gotoNextFrame):

2:39 PM Changeset in webkit [190219] by dbates@webkit.org
  • 2 edits in trunk/Tools

Support building for arbitrary architectures
​https://bugs.webkit.org/show_bug.cgi?id=149539

Reviewed by Alexey Proskuryakov.

Teach buildbot to pass the architectures associated with the builder to build-webkit
when building on OS X and iOS. As a side effect of this change we now support building
universal binaries when multiples architectures are specified.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

1:23 PM Changeset in webkit [190218] by dbates@webkit.org
  • 2 edits in trunk/Tools

Fix the build after <​http://trac.webkit.org/changeset/190212>
(​http://trac.webkit.org/changeset/190212)

I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().

  • BuildSlaveSupport/built-product-archive:

(main):

1:13 PM Changeset in webkit [190217] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove special case code for the no-parallel-GC case
​https://bugs.webkit.org/show_bug.cgi?id=149512

Reviewed by Mark Lam.

Make serial GC just a parallel GC where the helper threads don't do anything. Also make the
idle thread calculation a bit more explicit.

The main outcome is that we no longer use Options::numberOfGCMarkers() as much, so the code is
resilient against the number of GC markers changing.

  • heap/Heap.h:
  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):

12:36 PM Changeset in webkit [190216] by dbates@webkit.org
  • 2 edits in trunk/Tools

Support running unit tests on iOS Simulator test bot
​https://bugs.webkit.org/show_bug.cgi?id=149536

Reviewed by Alexey Proskuryakov.

Implements support for running unit tests on a iOS test bot. At the time of writing,
the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
(TestFactory.init): Add step RunUnitTests when the test bot is for the iOS Simulator platform.

12:23 PM Changeset in webkit [190215] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

PolymorphicAccess should remember that it checked an ObjectPropertyCondition with a check on some structure
​https://bugs.webkit.org/show_bug.cgi?id=149514

Reviewed by Oliver Hunt.

When we checked an ObjectPropertyCondition using an explicit structure check, we would forget to
note the structure in any weak reference table and we would attempt to regenerate the condition
check even if the condition became invalid.

We need to account for this better and we need to prune AccessCases that have an invalid condition
set. This change does both.

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::addWatchpoint):
(JSC::AccessCase::alternateBase):
(JSC::AccessCase::couldStillSucceed):
(JSC::AccessCase::canReplace):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::visitWeak):
(JSC::PolymorphicAccess::regenerate):

  • bytecode/PolymorphicAccess.h:

(JSC::AccessCase::callLinkInfo):

  • tests/stress/make-dictionary-repatch.js: Added. This used to crash on a release assert. If we removed the release assert, this would return bad results.
12:00 PM Changeset in webkit [190214] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Make event dispatching respect slotting
​https://bugs.webkit.org/show_bug.cgi?id=149243

Reviewed by Antti Koivisto.

Source/WebCore:

There are primarily two cases to consider: getting out of a shadow root to its host,
and moving into a slot from an assigned node.

When getting out of a shadow root, either the event originated in its shadow tree
including its nodes' shadow trees (1) or it moved into this shadow tree via a slot (2).
In (1), event.target should be set to the shadow host. In (2), it should be set to the
first node in the event path that belongs to the same tree as the shadow host. In order
to find such a node in O(1), we use a stack of event targets in each (shadow) tree. We
push event.target of the current tree whenever we move up to a slot from an assigned node
and pop it out of the stack when we move out of the shadow tree.

A follow up patch is needed to update the code to resolve related targets.

Tests: fast/shadow-dom/event-inside-shadow-tree.html

fast/shadow-dom/event-inside-slotted-node.html

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

LayoutTests:

Added tests for dispatching events inside shadow trees and nodes assigned to slots using testharness.js.

  • fast/shadow-dom/event-inside-shadow-tree-expected.txt: Added.
  • fast/shadow-dom/event-inside-shadow-tree.html: Added.
  • fast/shadow-dom/event-inside-slotted-node-expected.txt: Added.
  • fast/shadow-dom/event-inside-slotted-node.html: Added.
11:38 AM Changeset in webkit [190213] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

We should only expect a RareCaseProfile to exist if the rare case actually exists.
​https://bugs.webkit.org/show_bug.cgi?id=149531

Reviewed by Saam Barati.

The current code that calls rareCaseProfileForBytecodeOffset() assumes that it
will always return a non-null RareCaseProfile. As a result, op_add in the
baseline JIT is forced to add a dummy slow case that will never be taken, only to
ensure that the RareCaseProfile for that bytecode is created. This profile will
always produce a counter value of 0 (since that path will never be taken).

Instead, we'll make the callers of rareCaseProfileForBytecodeOffset() check if
the profile actually exist before dereferencing it.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::capabilityLevel):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::addRareCaseProfile):
(JSC::CodeBlock::numberOfRareCaseProfiles):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::rareCaseProfile): Deleted.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

11:36 AM Changeset in webkit [190212] by dbates@webkit.org
  • 6 edits in trunk/Tools

Add support infrastructure for OpenSource iOS builders and testers
​https://bugs.webkit.org/show_bug.cgi?id=149534

Reviewed by Darin Adler.

Towards setting up OpenSource iOS build bots, teach buildbot and its support
scripts about iOS.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
--ios-simulator or --device for a builder/tester whose full platform name begins with
"ios-simulator" or "ios", respectively.
(RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().

  • BuildSlaveSupport/built-product-archive:

(main): Pass the full platform name to determineWebKitBuildDirectory().
(determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
command line flag when building for iOS.
(archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
parameter fullPlatform. This parameter was originally added in r125066 to support the
Chromium Android port, which has since been removed from the OpenSource WebKit Project.
(extractBuiltProduct): Use the same logic for iOS as we do for Mac.

  • BuildSlaveSupport/clean-build:

(main): Call script webkit-build-directory with the appropriate command line flag when
building for iOS.

  • BuildSlaveSupport/delete-stale-build-files:

(main): Use the same logic for iOS as we do for Mac.
(webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
flag when building for iOS.

  • BuildSlaveSupport/test-result-archive:

(archiveTestResults): Use the same logic for iOS as we do for Mac.

11:29 AM Changeset in webkit [190211] by dbates@webkit.org
  • 2 edits in trunk/Tools

Remove Chromium-specific changes to script built-product-archive
​https://bugs.webkit.org/show_bug.cgi?id=149530

Rubber-stamped by Csaba Osztrogonác.

Reverts changes made in r113074 and r113067 to support Chromium testers. The
Chromium code has long since been removed from the OpenSource WebKit Project.

  • BuildSlaveSupport/built-product-archive:

(createZipManually):
(createZip):
(archiveBuiltProduct):

11:17 AM Changeset in webkit [190210] by Chris Dumez
  • 13 edits in trunk/Source

Drop XPATH_NAMESPACE_NODE from Node::NodeType enum
​https://bugs.webkit.org/show_bug.cgi?id=149532

Reviewed by Ryosuke Niwa.

Drop XPATH_NAMESPACE_NODE from Node::NodeType enum as there is currently
no way to construct such Node in WebKit. This avoid having to handle this
Node type everywhere.

Source/WebCore:

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap): Deleted.

  • bindings/objc/DOM.mm:

(kitClass): Deleted.

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::adoptNode): Deleted.
(WebCore::Document::childTypeAllowed): Deleted.
(WebCore::Document::canAcceptChild): Deleted.

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::ancestorElement): Deleted.

  • dom/Node.h:
  • dom/Range.cpp:

(WebCore::Range::checkNodeWOffset):
(WebCore::lengthOfContentsInNode): Deleted.
(WebCore::Range::processContentsBetweenOffsets): Deleted.
(WebCore::Range::surroundContents): Deleted.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup): Deleted.

  • xml/XPathFunctions.cpp:

(WebCore::XPath::expandedNameLocalPart): Deleted.

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):
(WebCore::XPath::primaryNodeType): Deleted.

  • xml/XPathUtil.cpp:

(WebCore::XPath::stringValue): Deleted.
(WebCore::XPath::isValidContextNode): Deleted.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass): Deleted.

11:15 AM Changeset in webkit [190209] by hyatt@apple.com
  • 19 edits
    19 adds in trunk

Add support for CSS Custom Properties (in preparation for implementing CSS Variables).
​https://bugs.webkit.org/show_bug.cgi?id=130397

Reviewed by Antti Koivisto.

Source/WebCore:

Added new tests in fast/css/custom-properties.

  • WebCore.xcodeproj/project.pbxproj:

Add new header files to the project (CSSCustomPropertyValue and StyleCustomPropertyData).

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):
If a custom property value is queried (i.e., it starts with "--"), then we use our
customPropertyValue lookup to go to the RenderStyle and fetch the appropriate custom property
value from the StyleCustomPropertyData.

(WebCore::CSSComputedStyleDeclaration::length):
(WebCore::CSSComputedStyleDeclaration::item):
Patched to include custom properties in the returned array. They appear at the end of the array
after the built-in properties.

(WebCore::ComputedStyleExtractor::propertyMatches):
Patched to check custom properties.

(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
Make sure the custom properties get copied into the StyleDeclaration.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
Patched to call customPropertyValue for custom properties.

  • css/CSSComputedStyleDeclaration.h:

Add customPropertyValue() to ComputedStyleExtractor.

  • css/CSSCustomPropertyValue.h: Added.

(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::equals):
(WebCore::CSSCustomPropertyValue::customCSSText):
(WebCore::CSSCustomPropertyValue::name):
(WebCore::CSSCustomPropertyValue::value):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
Custom properties are parsed as a property with an ID of CSSPropertyCustom and a CSSCustomPropertyValue
that holds both the name and the value of the property. Ultimately we might want to just ditch property IDs in
favor of AtomicStrings for all properties, and then the need to special case custom properties would go
away. For now, though, this is the way we work custom properties into the existing system.

  • css/CSSGrammar.y.in:

Add a production for recognizing custom properties and storing them using a property ID of CSSPropertyCustom
and a CSSCustomPropertyValue that has the name/value pair.

  • css/CSSParser.cpp:

(WebCore::filterProperties):
Patched to track seen custom properties and to handle them correctly.

(WebCore::CSSParser::createStyleProperties):
Pass in a seenCustomProperties table to ensure we bail when encountering the same custom property twice.

(WebCore::CSSParser::addCustomPropertyDeclaration):
Called from the grammar production to create the CSSCustomPropertyValue.

(WebCore::isCustomPropertyIdentifier):
Recognize the -- custom property during lexing.

(WebCore::CSSParser::parseIdentifier):
Patched to return a CUSTOM_PROPERTY token when a custom property is identified.

  • css/CSSParser.h:

(WebCore::isCustomPropertyName):
Add a helper function for asking if a property name is custom.

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

Patched to add support for CSSCustomPropertyValue.

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
Add code for handling custom properties in the CSS OM.

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::getCustomPropertyValue):
(WebCore::StyleProperties::getPropertyCSSValue):
(WebCore::StyleProperties::getCustomPropertyCSSValue):
(WebCore::MutableStyleProperties::removeProperty):
(WebCore::MutableStyleProperties::removeCustomProperty):
(WebCore::StyleProperties::propertyIsImportant):
(WebCore::StyleProperties::customPropertyIsImportant):
(WebCore::MutableStyleProperties::setProperty):
(WebCore::MutableStyleProperties::setCustomProperty):
(WebCore::MutableStyleProperties::addParsedProperty):
(WebCore::MutableStyleProperties::findPropertyIndex):
(WebCore::ImmutableStyleProperties::findCustomPropertyIndex):
(WebCore::MutableStyleProperties::findCustomPropertyIndex):
(WebCore::MutableStyleProperties::findCSSPropertyWithID):
(WebCore::MutableStyleProperties::findCustomCSSPropertyWithName):
(WebCore::StyleProperties::propertyMatches):
(WebCore::StyleProperties::PropertyReference::cssName):

  • css/StyleProperties.h:

(WebCore::StyleProperties::findCustomPropertyIndex):
Patched to support handling custom properties in the CSS OM. We have to create equivalent methods that operate
on AtomicString propertyNames instead of on property IDs.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::CascadedProperties::customProperties):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::CascadedProperties::set):
(WebCore::StyleResolver::applyCascadedProperties):
The resolver has to hold a HashMap from AtomicStrings to Properties. It matches identically to how built-in
properties work except that an extensible table (HashMap) is used to hold the property data.

  • css/makeprop.pl:

Patched to include the special CSSPropertyCustom value of 1 (just after the CSSPropertyInvalid id value but before the first
built-in property value).

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::getText):
(WebCore::lowercasePropertyName):
(WebCore::InspectorStyle::populateAllProperties):
Patch inspector to not lowercase CSS custom property names, since they are case-sensitive.

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleCustomPropertyData.h: Added.

(WebCore::StyleCustomPropertyData::create):
(WebCore::StyleCustomPropertyData::copy):
(WebCore::StyleCustomPropertyData::operator==):
(WebCore::StyleCustomPropertyData::operator!=):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::getCustomPropertyValue):
(WebCore::StyleCustomPropertyData::hasCustomProperty):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

The front end storage in the RenderStyle for custom properties. For now, custom properties are always inherited, so the
data is in StyleRareInheritedData.

LayoutTests:

  • fast/css/custom-properties: Added.
  • fast/css/custom-properties/computed-style-access-expected.html: Added.
  • fast/css/custom-properties/computed-style-access-inherited-expected.html: Added.
  • fast/css/custom-properties/computed-style-access-inherited.html: Added.
  • fast/css/custom-properties/computed-style-access.html: Added.
  • fast/css/custom-properties/inline-style-property-get-expected.html: Added.
  • fast/css/custom-properties/inline-style-property-get.html: Added.
  • fast/css/custom-properties/rule-property-get-css-value-expected.html: Added.
  • fast/css/custom-properties/rule-property-get-css-value.html: Added.
  • fast/css/custom-properties/rule-property-get-expected.html: Added.
  • fast/css/custom-properties/rule-property-get.html: Added.
  • fast/css/custom-properties/rule-property-priority-expected.html: Added.
  • fast/css/custom-properties/rule-property-priority.html: Added.
  • fast/css/custom-properties/rule-property-set-expected.html: Added.
  • fast/css/custom-properties/rule-property-set.html: Added.
  • fast/css/custom-properties/rule-serialization-expected.html: Added.
  • fast/css/custom-properties/rule-serialization.html: Added.
10:25 AM Changeset in webkit [190208] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Optimize Range's lengthOfContentsInNode() for DocumentType Nodes
​https://bugs.webkit.org/show_bug.cgi?id=149529

Reviewed by Darin Adler.

Optimize Range's lengthOfContentsInNode() for DocumentType Nodes:

We currently call Node::countChildNodes() unnecessarily on DocumentType
Nodes instead of simply returning 0.

  • dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContents):

10:00 AM Changeset in webkit [190207] by peavo@outlook.com
  • 2 edits in trunk/Source/WebKit/win

[WinCairo] NULL pointer crash when trying to use tiled backing for frame view.
​https://bugs.webkit.org/show_bug.cgi?id=149523

Reviewed by Brent Fulgham.

For WinCairo, disable tiled backing for frame view.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::shouldUseTiledBackingForFrameView):

9:32 AM Changeset in webkit [190206] by mitz@apple.com
  • 2 edits in trunk/Tools

Build fix.

  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
8:55 AM Changeset in webkit [190205] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix typo errors in a comment ("passed" -> "Passed", "Overwise" -> "Otherwise")

  • css/mediaControlsGtk.css:
8:48 AM Changeset in webkit [190204] by ChangSeok Oh
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline media/media-controls-play-button-updates.html.

  • platform/gtk/media/media-controls-play-button-updates-expected.txt:
8:39 AM Changeset in webkit [190203] by mark.lam@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Make Lucas Forschler a WebKit reviewer.

  • Scripts/webkitpy/common/config/contributors.json:
7:56 AM Changeset in webkit [190202] by Gyuyoung Kim
  • 17 edits in trunk/Source/WebCore

Reduce almost uses of PassRefPtr in Webcore/testing
​https://bugs.webkit.org/show_bug.cgi?id=149449

Reviewed by Darin Adler.

This patch removes all uses of PassRefPtr except for Internals::serializeObject() and Internals::deserializeObject().
It will be removed by upcoming patch.

  • Modules/encryptedmedia/CDMSessionClearKey.cpp:

(WebCore::CDMSessionClearKey::generateKeyRequest):

  • Modules/encryptedmedia/CDMSessionClearKey.h:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::jsTestOverrideBuiltinsPrototypeFunctionNamedItem):

  • platform/graphics/CDMSession.h:
  • platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

(WebCore::CDMSessionAVFoundationCF::generateKeyRequest):

  • platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:

(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):

  • testing/InternalSettings.h:

(WebCore::InternalSettings::create):

  • testing/Internals.cpp:

(WebCore::Internals::create):
(WebCore::Internals::computedStyleIncludingVisitedInfo):
(WebCore::Internals::markerRangeForNode):
(WebCore::Internals::rangeFromLocationAndLength):
(WebCore::Internals::subrange):
(WebCore::Internals::nodesFromRect):
(WebCore::Internals::mallocStatistics):
(WebCore::Internals::typeConversions):
(WebCore::Internals::memoryInfo):
(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):
(WebCore::Internals::createTimeRanges):

  • testing/Internals.h:
  • testing/MallocStatistics.h:

(WebCore::MallocStatistics::create):

  • testing/MemoryInfo.h:

(WebCore::MemoryInfo::create):

  • testing/MockCDM.cpp:

(WebCore::MockCDMSession::generateKeyRequest):

  • testing/TypeConversions.h:

(WebCore::TypeConversions::create):

7:26 AM Changeset in webkit [190201] by rniwa@webkit.org
  • 12 edits in trunk/Source

Ran sort-Xcode-project-file.

Source/JavaScriptCore:

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebInspectorUI:

  • WebInspectorUI.xcodeproj/project.pbxproj:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
5:35 AM WebKitIDL edited by youenn.fablet@crf.canon.fr
(diff)
5:32 AM WebKitIDL edited by youenn.fablet@crf.canon.fr
(diff)
2:41 AM Changeset in webkit [190200] by ChangSeok Oh
  • 5 edits
    5 adds in trunk

[GTK] playbutton in media controls is not changed when it is clicked.
​https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

  • css/mediaControlsGtk.css:

(video::-webkit-media-controls-play-button.paused):

LayoutTests:

  • media/media-controls-play-button-updates-expected.png: Added.
  • media/media-controls-play-button-updates-expected.txt: Added.
  • media/media-controls-play-button-updates.html: Added.
  • platform/efl/TestExpectations: Skip the test.
  • platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
  • platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
  • platform/mac/TestExpectations: Skip the test on yosemite.
2:24 AM Changeset in webkit [190199] by Carlos Garcia Campos
  • 10 edits in trunk

Unreviewed. Fix GObject DOM API breaks after r190120.

Source/WebCore:

EntityReference has been removed from the DOM spec. Generate an
empy GObject implementation to keep API and ABI
compatibility. also add a deprecated impementation for the methods
using WebKitEntityReference.

  • PlatformGTK.cmake: Do not generate bindings for EntityReference.idl.
  • bindings/gobject/WebKitDOMDeprecated.cpp:

(webkit_dom_entity_reference_init):
(webkit_dom_entity_reference_class_init):
(webkit_dom_node_iterator_get_expand_entity_references):
(webkit_dom_tree_walker_get_expand_entity_references):
(webkit_dom_document_create_entity_reference):

  • bindings/gobject/WebKitDOMDeprecated.h:
  • bindings/gobject/WebKitDOMDeprecated.symbols:
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Remove FIXME.

  • dom/Document.idl: Do not generate createEntityReference for GObject.
  • dom/EntityReference.idl: Do not generate empty files for GObject.

Tools:

Bring back code removed in r169931 to handle documentation of
deleted classes.

  • gtk/webkitdom.py:

(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.write_deleted_classes):
(WebKitDOMDocGenerator.generate):
(write_deleted_classes):
(WebKitDOMDocGeneratorSections._deleted_class):
(WebKitDOMDocGeneratorSections._deleted_class.in):
(WebKitDOMDocGeneratorSections.write_deleted_classes):
(WebKitDOMDocGeneratorSections.write_deleted_classes.with):

2:18 AM Changeset in webkit [190198] by youenn.fablet@crf.canon.fr
  • 37 edits
    1 add
    1 delete in trunk/Source

[Streams API] Add support for JS builtins constructor
​https://bugs.webkit.org/show_bug.cgi?id=149497

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/JSFunction.h: exporting createBuiltinFunction.

Source/WebCore:

Covered by existing tests.

Making CountQueuingStrategy fully JS built-in implemented.
Adding support for calling a JS builtin initialization function just after creating the JSXX object.
This JS function must be named initializeXX and be in XX.Js file.
The JSBuiltinConstructor keyword is added to the binding generator.

  • CMakeLists.txt: Adding CountQueuingStrategy.js, removing JSCountQueuingStrategyCustom.cpp.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • Modules/streams/CountQueuingStrategy.h: Making CountQueuingStrategy a dummy class.

(WebCore::CountQueuingStrategy::create):
(WebCore::CountQueuingStrategy::~CountQueuingStrategy):
(WebCore::CountQueuingStrategy::CountQueuingStrategy):

  • Modules/streams/CountQueuingStrategy.idl:
  • Modules/streams/CountQueuingStrategy.js: Added.

(size):
(initializeCountQueuingStrategy):

  • WebCore.vcxproj/WebCore.vcxproj: Removing JSCountQueuingStrategyCustom.cpp.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSBindingsAllInOne.cpp: Ditto.
  • bindings/js/JSCountQueuingStrategyCustom.cpp: Removed.
  • bindings/js/JSDOMBinding.cpp: Adding support for DOMConstructorJSBuiltinObject.

(WebCore::callInitializeFunction):
(WebCore::DOMConstructorJSBuiltinObject::visitChildren):

  • bindings/js/JSDOMBinding.h: Diitto.

(WebCore::createFromJSBuiltin):
(WebCore::DOMConstructorJSBuiltinObject::DOMConstructorJSBuiltinObject):

  • bindings/js/WebCoreJSClientData.h: Adding support for CQS builtins functions.

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetJSBuiltinFunctionName):
(GetFunctionName):
(InstanceNeedsVisitChildren): Generating visitChildren method in case of JSBuiltinConstructor.
(GetParentConstructorClassName): Refactoring to make JSXXConstructor derive from DOMConstructorJSBuiltinObject in case of JSBuiltinConstructor.
(GenerateConstructorDeclaration): Ditto.
(GenerateConstructorDefinition): Generate specific constructor in case of JSBuiltinConstructor.
(GenerateConstructorHelperMethods): Refactoring to use Base class.
(IsConstructable): Ditto.
(ConstructorHasProperties): Deleted.

  • bindings/scripts/IDLAttributes.txt: Adding JSBuiltinConstructor.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::JSTestActiveDOMObjectConstructor):

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallbackConstructor::JSTestCallbackConstructor):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::JSTestCustomConstructorWithNoInterfaceObjectConstructor):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::JSTestEventTargetConstructor):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::JSTestGenerateIsReachableConstructor):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::JSTestNodeConstructor):

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicConstructor::JSTestNondeterministicConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::JSTestObjConstructor):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::JSTestOverrideBuiltinsConstructor):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeConstructor::JSattributeConstructor):

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyConstructor::JSreadonlyConstructor):

Sep 23, 2015:

11:04 PM Changeset in webkit [190197] by bshafiei@apple.com
  • 25 edits
    2 deletes in tags/Safari-602.1.4

Merged r190190. rdar://problem/22825602

11:01 PM Changeset in webkit [190196] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.4

New tag.

9:23 PM Changeset in webkit [190195] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Simplify / Optimize Range::selectNode()
​https://bugs.webkit.org/show_bug.cgi?id=149515

Reviewed by Ryosuke Niwa.

Simplify / Optimize Range::selectNode():

  1. Do a null-check on refNode->parentNode() instead of checking the nodeType(), which is virtual. Attr, DocumentFragment and Document Nodes do not have a parent and thus are covered by this check. Also, setStartBefore() / setEndAfter() were already doing a null check on the parent.
  2. Call lower-level setStart() / setEnd() directly, instead of using setStartBefore() / setEndAfter() as intermediary. As a result: 2.a. We avoid doing a redundant null checks on refNode and its parent

(inside those intermediate functions)

2.b. We only call refNode->computeNodeIndex() once instead of twice

(in each of those intermediate functions). computeNodeIndex()
is not a trivial getter as its needs to traverse all the
previous siblings.

The implementation now matches exactly the text of the DOM specification
as well:
​https://dom.spec.whatwg.org/#concept-range-select

No new layout tests, no web-exposed behavior intended.

  • dom/Range.cpp:

(WebCore::Range::selectNode):

6:52 PM Changeset in webkit [190194] by Chris Dumez
  • 2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline web-platform-tests/html/dom/interfaces.html after r190190

  • web-platform-tests/html/dom/interfaces-expected.txt:
6:27 PM Changeset in webkit [190193] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Link highlight rect is too rounded on blocks with border-radius
​https://bugs.webkit.org/show_bug.cgi?id=149511

Reviewed by Dan Bernstein.

  • UIProcess/ios/WKContentViewInteraction.mm:

(nsSizeForTapHighlightBorderRadius):
(-[WKContentView _updateTapHighlight]):
Scale the border radius from content to view coordinates, just like
we do for the rects that WebKit returns us.

5:40 PM Changeset in webkit [190192] by mmaxfield@apple.com
  • 40 edits
    4 adds in trunk

[Cocoa] [Font Features] Implement font-variant-*
​https://bugs.webkit.org/show_bug.cgi?id=148413

Reviewed by Darin Adler.

Source/WebCore:

This patch is the first pass of implementing of the font-variant-* properties. Specifically,
these properties are:
font-variant-ligatures
font-variant-position
font-variant-caps
font-variant-numeric
font-variant-alternates
font-variant-east-asian

These new properties are held inside FontDescription as bit fields. At font creation time,
we consult with the FontDescription to figure out which variants are specified. We then
convert those variants to font features, and resolve these font features with the additional
features specified by font-feature-settings (as the spec requires). This patch also makes
our caches sensitive to these new properties of FontDescription so we don't look up cached,
stale fonts.

The implementation has some caveats, however. They are listed here:

  1. These new properties need to interact correctly with @font-face declarations. In

particular, only certain properties of the FontDescription should be considered when
detecting if a @font-face declaration applies to a particular element. This discrimination
does not happen correctly. In addition, any feature-specific CSS properties inside the
@font-face declaration need to be consulted at a particular point during the feature
resolve. This does not currently occur.

  1. One of the properties, font-variant-alternates, has a few values which require custom

CSS functions, which makes modeling the properties as bit fields tricky. These extra values
need to be implemented. This patch implements all the values which do not require extra CSS
features.

  1. These new properties have a shorthand, font-variant, which is designed to be backward-

compatible with CSS 2.1's concept of font-variant. In particular, CSS 2.1 allows you to use
"normal" and "small-caps" with font-variant. Both of these values are values of the new
property font-variant-caps. However, our existing implementation of small-caps does not
use font features when they exist; instead, it simply draws text at a smaller font size and
uses (effectively) text-transform to force capital letters. This implementation needs to be
unified with the new font-variant-caps property so that we can expand font-variant to be
a shorthand for the new properties.

  1. font-variant-position and font-variant-caps should provide appropriate synthesis if no

matching font-feature exists.

  1. FontCascade::typesettingFeatures() is now no-longer accurate. Fixing this would be large

enough to warrant its own patch.

  1. These properties are not tested with TrueType fonts.

Tests: css3/font-variant-all-webfont.html

css3/font-variant-parsing.html

  • css/CSSComputedStyleDeclaration.cpp: Reconstruct StyleProperties from a RenderStyle.

(WebCore::appendLigaturesValue):
(WebCore::fontVariantLigaturesPropertyValue):
(WebCore::fontVariantPositionPropertyValue):
(WebCore::fontVariantCapsPropertyValue):
(WebCore::fontVariantNumericPropertyValue):
(WebCore::fontVariantAlternatesPropertyValue):
(WebCore::fontVariantEastAsianPropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSFontFeatureValue.cpp: Update to FontFeatureTag instead of WTF::String.

(WebCore::CSSFontFeatureValue::CSSFontFeatureValue):
(WebCore::CSSFontFeatureValue::customCSSText):

  • css/CSSFontFeatureValue.h: Ditto.

(WebCore::CSSFontFeatureValue::create):
(WebCore::CSSFontFeatureValue::tag):

  • css/CSSParser.cpp: Parse the new properties according to the CSS3 fonts spec.

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFontFeatureTag):
(WebCore::CSSParser::parseFontVariantLigatures):
(WebCore::CSSParser::parseFontVariantNumeric):
(WebCore::CSSParser::parseFontVariantEastAsian):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h: For the three properties which are simple keyword value

properties, implement casting operators to automatically convert between RenderStyle
objects and CSS property objects.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontVariantPosition):
(WebCore::CSSPrimitiveValue::operator FontVariantCaps):
(WebCore::CSSPrimitiveValue::operator FontVariantAlternates):

  • css/CSSPropertyNames.in: New properties.
  • css/CSSValueKeywords.in: New values.
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontFeatureSettings): Update to not use
RefPtrs.

  • css/StyleBuilderCustom.h: Properties which are not simple keyword value properties are

decomposed into multiple members of FontDescription. These properties exist to convert
between these aggregate members and the CSS properties.
(WebCore::StyleBuilderCustom::applyInheritFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyInitialFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyValueFontVariantLigatures):
(WebCore::StyleBuilderCustom::applyInheritFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyInitialFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyValueFontVariantNumeric):
(WebCore::StyleBuilderCustom::applyInheritFontVariantEastAsian):
(WebCore::StyleBuilderCustom::applyInitialFontVariantEastAsian):
(WebCore::StyleBuilderCustom::applyValueFontVariantEastAsian):
(WebCore::StyleBuilderCustom::applyInitialWebkitFontVariantLigatures): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitFontVariantLigatures): Deleted.
(WebCore::StyleBuilderCustom::applyValueWebkitFontVariantLigatures): Deleted.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::computedAttributesForElement): Unprefix font-variant-ligatures.

  • platform/graphics/FontCache.h: Update cache to be sensitive to new state in

FontDescription.
(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
(WebCore::FontDescriptionKey::computeHash):
(WebCore::FontDescriptionKey::makeFlagsKey):
(WebCore::FontDescriptionKey::makeFlagKey): Deleted.

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::codePath): These new variants should trigger the complex text
codepath.

  • platform/graphics/FontCascade.h:

(WebCore::FontCascade::computeTypesettingFeatures): Update to use new state enum.

  • platform/graphics/FontDescription.cpp: Add state to hold new property values.

(WebCore::FontDescription::FontDescription):
(WebCore::FontCascadeDescription::FontCascadeDescription): Deleted.

  • platform/graphics/FontDescription.h: Add state to hold new property values.

(WebCore::FontDescription::featureSettings):
(WebCore::FontDescription::variantCommonLigatures):
(WebCore::FontDescription::variantDiscretionaryLigatures):
(WebCore::FontDescription::variantHistoricalLigatures):
(WebCore::FontDescription::variantContextualAlternates):
(WebCore::FontDescription::variantPosition):
(WebCore::FontDescription::variantCaps):
(WebCore::FontDescription::variantNumericFigure):
(WebCore::FontDescription::variantNumericSpacing):
(WebCore::FontDescription::variantNumericFraction):
(WebCore::FontDescription::variantNumericOrdinal):
(WebCore::FontDescription::variantNumericSlashedZero):
(WebCore::FontDescription::variantAlternates):
(WebCore::FontDescription::variantEastAsianVariant):
(WebCore::FontDescription::variantEastAsianWidth):
(WebCore::FontDescription::variantEastAsianRuby):
(WebCore::FontDescription::variantSettings):
(WebCore::FontDescription::setFeatureSettings):
(WebCore::FontDescription::setVariantCommonLigatures):
(WebCore::FontDescription::setVariantDiscretionaryLigatures):
(WebCore::FontDescription::setVariantHistoricalLigatures):
(WebCore::FontDescription::setVariantContextualAlternates):
(WebCore::FontDescription::setVariantPosition):
(WebCore::FontDescription::setVariantCaps):
(WebCore::FontDescription::setVariantNumericFigure):
(WebCore::FontDescription::setVariantNumericSpacing):
(WebCore::FontDescription::setVariantNumericFraction):
(WebCore::FontDescription::setVariantNumericOrdinal):
(WebCore::FontDescription::setVariantNumericSlashedZero):
(WebCore::FontDescription::setVariantAlternates):
(WebCore::FontDescription::setVariantEastAsianVariant):
(WebCore::FontDescription::setVariantEastAsianWidth):
(WebCore::FontDescription::setVariantEastAsianRuby):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::initialVariantPosition):
(WebCore::FontCascadeDescription::initialVariantCaps):
(WebCore::FontCascadeDescription::initialVariantAlternates):
(WebCore::FontCascadeDescription::commonLigaturesState): Deleted.
(WebCore::FontCascadeDescription::discretionaryLigaturesState): Deleted.
(WebCore::FontCascadeDescription::historicalLigaturesState): Deleted.
(WebCore::FontCascadeDescription::setCommonLigaturesState): Deleted.
(WebCore::FontCascadeDescription::setDiscretionaryLigaturesState): Deleted.
(WebCore::FontCascadeDescription::setHistoricalLigaturesState): Deleted.
(WebCore::FontCascadeDescription::operator==): Deleted.

  • platform/graphics/FontFeatureSettings.cpp: Update to use FontFeatureTag instead of

WTF::String.
(WebCore::FontFeature::FontFeature):
(WebCore::FontFeature::operator==):
(WebCore::FontFeature::operator<):
(WebCore::FontFeatureSettings::hash):
(WebCore::FontFeatureSettings::create): Deleted.

  • platform/graphics/FontFeatureSettings.h: Update to use FontFeatureTag instead of

WTF::String.
(WebCore::fontFeatureTag):
(WebCore::FontFeatureTagHash::hash):
(WebCore::FontFeatureTagHash::equal):
(WebCore::FontFeatureTagHashTraits::constructDeletedValue):
(WebCore::FontFeatureTagHashTraits::isDeletedValue):
(WebCore::FontFeature::tag):
(WebCore::FontFeatureSettings::operator==):
(WebCore::FontFeatureSettings::begin):
(WebCore::FontFeatureSettings::end):
(WebCore::FontFeatureSettings::FontFeatureSettings): Deleted.

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Ditto. Also, when computing font

features, consult with the state inside FontDescription.
(WebCore::tagEquals):
(WebCore::appendTrueTypeFeature):
(WebCore::appendOpenTypeFeature):
(WebCore::computeFeatureSettingsFromVariants):
(WebCore::preparePlatformFont):
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Update to use references instead of

pointers.
(WebCore::HarfBuzzShaper::setFontFeatures):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::platformFontWithFamily): Ditto.

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Be sensitive to new state inside FontDescription.

  • platform/text/TextFlags.h:

(WebCore::FontVariantSettings::isAllNormal): New state enums.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::updateCachedSystemFontDescription): Be sensitive to new state inside
FontDescription.

  • rendering/line/BreakingContext.h:

Tools:

Update test font to use "lnum" feature.

  • FontWithFeatures/FontWithFeatures/FontCreator.cpp:

(Generator::appendGSUBTable):

LayoutTests:

Updating tests because font-variant-ligatures is being unprefixed.

Also, update css3/resources/FontWithFeatures.otf to support "lnum" feature.

  • css3/font-feature-settings-rendering-2-expected.html:
  • css3/font-feature-settings-rendering-2.html:
  • css3/font-variant-all-webfont-expected.html: Added.
  • css3/font-variant-all-webfont.html: Added.
  • css3/font-variant-parsing-expected.txt: Added.
  • css3/font-variant-parsing.html: Added.
  • css3/resources/FontWithFeatures.otf:
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-font-family-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/css/parsing-font-variant-ligatures.html:
  • fast/text/font-variant-ligatures.html:
  • platform/mac/TestExpectations:
  • svg/css/getComputedStyle-basic-expected.txt:
5:19 PM Changeset in webkit [190191] by sbarati@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix broken inspector tests.

Reviewed by Joseph Pecoraro and Brian Burg.

We can't redeclare a "let" variable and "var" variable using the same
identifier at the top-level of a function.

  • UserInterface/Test/InspectorProtocol.js:

(InspectorProtocol.sendCommand):
(InspectorProtocol.addEventListener):
(InspectorProtocol.dispatchMessageFromBackend):

4:52 PM Changeset in webkit [190190] by Chris Dumez
  • 25 edits
    2 deletes in trunk

Unreviewed, roll out r190085 as it seems to cause crashes in JSC
<rdar://problem/22825602>

LayoutTests/imported/w3c:

  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:

LayoutTests:

  • fast/events/event-prototype-constructor-properties-expected.txt: Removed.
  • fast/events/event-prototype-constructor-properties.html: Removed.
3:59 PM Changeset in webkit [190189] by Chris Dumez
  • 15 edits
    2 adds in trunk

HTMLOutputElement.htmlFor should be settable
​https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

  • html/AttributeDOMTokenList.cpp:

(WebCore::AttributeDOMTokenList::AttributeDOMTokenList):
(WebCore::AttributeDOMTokenList::attributeValueChanged):

  • html/AttributeDOMTokenList.h:
  • Have AttributeDOMTokenList subclass DOMSettableTokenList instead of

DOMTokenList so that it can be used in places where the IDL expects
us to return a DOMSettableTokenList (e.g. HTMLOutputElement.htmlFor).

  • Mark AttributeDOMTokenList as fast allocated.
  • html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::setValue):

  • html/DOMSettableTokenList.h:
  • Move setValue() from DOMTokenList to DOMSettableTokenList as it is only needed by DOMSettableTokenList.
  • Get rid of the factory function as all call sites are using AttributeDOMTokenList now.
  • Stop inheriting RefCounted as AttributeDOMTokenList handles its own refcounting.
  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::setValueInternal):

  • html/DOMTokenList.h:

Rename setValue() to setValueInternal() as this version does not
update the associated attribute value, only the tokens.

  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:
  • Have HTMLLinkElement.sizes use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute. The previous code had a bug has setting HTMLLinkElement.sizes would not update the associated 'sizes' attribute. Switching to using AttributeDOMTokenList fixes this and a new layout test has been added to cover this.
  • Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.
  • html/HTMLOutputElement.cpp:
  • html/HTMLOutputElement.h:
  • Have HTMLLinkElement.htmlFor use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute.
  • Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.
  • html/HTMLOutputElement.idl:

Add [PutForwards=value] on the htmlFor attribute, as per the
HTML specification.

LayoutTests:

  • fast/dom/HTMLLinkElement/sizes-setter.html: Added
  • fast/dom/HTMLLinkElement/sizes-setter-expected.txt: Added

Add layout test to make sure that setting HTMLLinkElement.sizes actually
updates the 'sizes' associated attribute.

  • fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
  • fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:

Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

3:37 PM Changeset in webkit [190188] by sbarati@apple.com
  • 6 edits in trunk

JSC allows invalid var declarations when the declared name is the same as a let/const variable
​https://bugs.webkit.org/show_bug.cgi?id=147600

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

We had an ordering bug where if you first declared a "let"
variable then a "var" variable with the same name, you wouldn't
get a syntax error. But, if you did it in the reverse order,
you would. This patch fixes this syntax error to be order independent.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::parseFunctionDeclaration):

  • parser/Parser.h:

(JSC::Scope::declareVariable):

LayoutTests:

  • js/let-syntax-expected.txt:
  • js/script-tests/let-syntax.js:

(hasSyntaxError):

2:40 PM Changeset in webkit [190187] by Chris Dumez
  • 5 edits in trunk

TreeWalker.previousSibling() / nextSibling() does not behave according to the specification
​https://bugs.webkit.org/show_bug.cgi?id=149493

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing W3C DOM test now that more checks are passing.

  • web-platform-tests/dom/traversal/TreeWalker-expected.txt:

Source/WebCore:

TreeWalker.previousSibling() / nextSibling() does not behave according
to the specification:

In particular, the previous code would fail to update 'node' variable
in the case acceptNode() returned FILTER_REJECT. This patch fixes this
and refactors the function to match more closely the text of the spec
and avoid code duplication.

No new tests, already covered by existing test.

  • dom/TreeWalker.cpp:

(WebCore::TreeWalker::traverseSiblings):
(WebCore::TreeWalker::previousSibling):
(WebCore::TreeWalker::nextSibling):
(WebCore::TreeWalker::previousNode): Deleted.

  • dom/TreeWalker.h:
2:03 PM Changeset in webkit [190186] by sbarati@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't use bind() when creating internal AST, instead, pass in "this" parameter to map()
​https://bugs.webkit.org/show_bug.cgi?id=149483

Reviewed by Joseph Pecoraro.

  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

1:59 PM Changeset in webkit [190185] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Parallel copy phase synchronization should be simplified
​https://bugs.webkit.org/show_bug.cgi?id=149509

Reviewed by Mark Lam.

Before this change, we didn't wait for the copy phase to finish before starting to do things to
copied space that presumed that copying was done. Copied space would "detect" that nobody was
copying anymore by waiting for all loaned blocks to be returned. But that would succeed if some
thread had not yet started copying. So, we had weird hacks to ensure that a block was loaned
before any threads started. It also meant that we had two separate mechanisms for waiting for
copying threads to finish - one mechanism in the Heap phase logic and another in the
CopiedSpace::doneCopying() method.

We can get rid of a lot of the weirdness by just having a sound shutdown sequence:

1) Threads concur on when there is no more work. We already have this; once

Heap::getNextBlocksToCopy() returns no work in any thread, it will also return no work in
any other thread that asks for work.

2) Main thread waits for the threads to not be copying anymore.
3) Do whatever we need to do after copying finishes.

Currently, we do (3) before (2) and so we have weird problems. This just changes the code to do
(3) after (2), and so we can get rid of the synchronization in doneCopying() and we can safely
call startCopying() inside GCThread. This also means that we don't need to make CopyVisitor a
property of GCThread. Instead, GCThread just instantiates its own CopyVisitor when it needs to.

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::doneCopying):

  • heap/GCThread.cpp:

(JSC::GCThread::GCThread):
(JSC::GCThread::slotVisitor):
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):
(JSC::GCThread::copyVisitor): Deleted.

  • heap/GCThread.h:
  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::copyBackingStores):
(JSC::Heap::gatherStackRoots):

1:58 PM Changeset in webkit [190184] by sbarati@apple.com
  • 6 edits in trunk

Web Inspector: Type bubbles missing for computed methods and methods on object literals
​https://bugs.webkit.org/show_bug.cgi?id=148562

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

This patch makes sure that computed methods are working
for both classes and object literals. Also, methods now
work on object literals. This patch also cleans up the
"isGetterOrSetter" and "getterOrSetterRange" fields.
Basically, we used this as a way to ask the type profiler
for the return types of a function. Now, we just have
a field called "typeProfilingReturnDivot" that is set
on all functions so we don't need to conditionally ask
if it's a getter or setter.

  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):

  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.functionReturnDivot):
(WebInspector.ScriptSyntaxTree.prototype._recurseArray):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

  • inspector/model/parse-script-syntax-tree-expected.txt:
  • inspector/model/parse-script-syntax-tree.html:
1:34 PM Changeset in webkit [190183] by Beth Dakin
  • 2 edits in trunk/LayoutTests

accessibility/mac/aria-expanded-notifications.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=149510

Marking it as such.

  • platform/mac/TestExpectations:
1:07 PM Changeset in webkit [190182] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

Disable QuickLook on watchOS
​https://bugs.webkit.org/show_bug.cgi?id=149508
<rdar://problem/22517968>

Reviewed by Dan Bernstein.

  • wtf/Platform.h:
12:29 PM Changeset in webkit [190181] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix CMake build.

  • CMakeLists.txt:

Use {} instead of () for CMake variables.

12:12 PM Changeset in webkit [190180] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the CMake build.

  • CMakeLists.txt:
12:02 PM Changeset in webkit [190179] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove unimplemented method Heap::showStatistics
​https://bugs.webkit.org/show_bug.cgi?id=149507

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-23
Reviewed by Darin Adler.

  • heap/Heap.h:
11:49 AM Changeset in webkit [190178] by timothy_horton@apple.com
  • 9 edits in trunk/Source

Hopefully fix the production build.

  • DerivedSources.make:
  • WebCore.vcxproj/build-generated-files.pl:
  • WebCore.xcodeproj/project.pbxproj:
  • generate-js-builtins:
  • make-generated-sources.sh:
10:41 AM Changeset in webkit [190177] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:00 AM Changeset in webkit [190176] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac production build fix attempt after r190155.

  • WebCore.xcodeproj/project.pbxproj:
9:23 AM Changeset in webkit [190175] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Avoid unnecessary ancestor traversal in Range::selectNodeContents()
​https://bugs.webkit.org/show_bug.cgi?id=149491

Reviewed by Andreas Kling.

Avoid unnecessary ancestor traversal in Range::selectNodeContents().
A DocumentType Node cannot have children, therefore, there is no need
to check if ancestors are docTypes. We now simply check if the current
node is a DocumentType Node, as per the specification:

  • dom/Range.cpp:

(WebCore::Range::selectNodeContents):

9:21 AM Changeset in webkit [190174] by Chris Dumez
  • 9 edits in trunk

Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter() do not match the specification
​https://bugs.webkit.org/show_bug.cgi?id=149490

Reviewed by Andreas Kling.

LayoutTests/imported/w3c:

Rebaseline several W3C DOM tests now that more checks are passing.

  • web-platform-tests/dom/ranges/Range-selectNode-expected.txt:
  • web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Range's setStartBefore() / setStartAfter() / setEndBefore() / setEndAfter()
behavior do not match the DOM specification:

In particular, instead of step 2:
"If parent is null, throw an InvalidNodeTypeError exception."

Our implementation was doing more checks and throwing exceptions in cases
that the specification does not say we should. We were calling
checkNodeBA() which had restrictions on both the node type and its
root type. This is now replaced by a simple null check on the parent,
as per the specification.

Firefox's behavior matches the specification.

No new tests, already covered by existing tests.

  • dom/Range.cpp:

(WebCore::Range::setStartAfter):
(WebCore::Range::setEndBefore):
(WebCore::Range::setEndAfter):
(WebCore::Range::setStartBefore):
(WebCore::Range::cloneRange): Deleted.
(WebCore::Range::selectNode): Deleted.
(WebCore::Range::selectNodeContents): Deleted.
(WebCore::Range::absoluteTextRects): Deleted.

  • dom/Range.h:

LayoutTests:

Update test that expected an assertion in a case where we no longer
throw. I checked that Firefox does not throw in this case either.

  • fast/dom/Range/range-exceptions-expected.txt:
  • fast/dom/Range/script-tests/range-exceptions.js:
9:06 AM Changeset in webkit [190173] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk

Unreviewed, rolling out r190168.
​https://bugs.webkit.org/show_bug.cgi?id=149502

it broke debug builds. (Requested by zalan on #webkit).

Reverted changeset:

"HTMLOutputElement.htmlFor should be settable"
​https://bugs.webkit.org/show_bug.cgi?id=149418
​http://trac.webkit.org/changeset/190168

8:34 AM Changeset in webkit [190172] by commit-queue@webkit.org
  • 3 edits
    5 deletes in trunk

Unreviewed, rolling out r190160.
​https://bugs.webkit.org/show_bug.cgi?id=149501

media/media-controls-play-button-updates.html fails on
Yosemite and EFL (Requested by zalan on #webkit).

Reverted changeset:

"[GTK] playbutton in media controls is not changed when it is
clicked."
​https://bugs.webkit.org/show_bug.cgi?id=149113
​http://trac.webkit.org/changeset/190160

8:23 AM Changeset in webkit [190171] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Try to fix build.

  • css/DocumentRuleSets.h:
  • inspector/InspectorInstrumentation.h:
8:07 AM Changeset in webkit [190170] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Fix sorting

  • dom/DOMAllInOne.cpp:
8:04 AM Changeset in webkit [190169] by Antti Koivisto
  • 33 edits
    2 copies
    2 moves in trunk/Source/WebCore

Split author style code out from DocumentStyleSheetCollection
​https://bugs.webkit.org/show_bug.cgi?id=149446

Reviewed by Andreas Kling.

Shadow trees may have their own author style. Factor the related code out so we can use
it outside the document context.

DocumentStyleSheetCollection is replaced by two classes:

AuthorStyleSheets - author stylesheets and mutation optimization code
ExtensionStyleSheets - user stylesheets, injected author stylesheets, content extension stylesheets

  • WebCore.xcodeproj/project.pbxproj:
  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::didMutateRules):

  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle):

  • css/DocumentRuleSets.h:

(WebCore::DocumentRuleSets::sibling):
(WebCore::DocumentRuleSets::uncommonAttribute):

  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection): Deleted.

  • css/InspectorCSSOMWrappers.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):
(WebCore::StyleSheetList::length):

  • dom/AuthorStyleSheets.cpp: Added.

(WebCore::AuthorStyleSheets::AuthorStyleSheets):
(WebCore::AuthorStyleSheets::combineCSSFeatureFlags):
(WebCore::AuthorStyleSheets::resetCSSFeatureFlags):
(WebCore::AuthorStyleSheets::addAuthorSheet):
(WebCore::AuthorStyleSheets::removePendingSheet):
(WebCore::AuthorStyleSheets::addStyleSheetCandidateNode):
(WebCore::AuthorStyleSheets::removeStyleSheetCandidateNode):
(WebCore::AuthorStyleSheets::collectActiveStyleSheets):
(WebCore::AuthorStyleSheets::analyzeStyleSheetChange):
(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
(WebCore::AuthorStyleSheets::activeStyleSheetsForInspector):
(WebCore::AuthorStyleSheets::activeStyleSheetsContains):
(WebCore::AuthorStyleSheets::detachFromDocument):

  • dom/AuthorStyleSheets.h: Added.

(WebCore::AuthorStyleSheets::activeStyleSheets):
(WebCore::AuthorStyleSheets::styleSheets):
(WebCore::AuthorStyleSheets::styleSheetsForStyleSheetList):
(WebCore::AuthorStyleSheets::pendingUpdateType):
(WebCore::AuthorStyleSheets::setPendingUpdateType):
(WebCore::AuthorStyleSheets::flushPendingUpdates):
(WebCore::AuthorStyleSheets::preferredStylesheetSetName):
(WebCore::AuthorStyleSheets::selectedStylesheetSetName):
(WebCore::AuthorStyleSheets::setPreferredStylesheetSetName):
(WebCore::AuthorStyleSheets::setSelectedStylesheetSetName):
(WebCore::AuthorStyleSheets::addPendingSheet):
(WebCore::AuthorStyleSheets::hasPendingSheets):
(WebCore::AuthorStyleSheets::usesFirstLineRules):
(WebCore::AuthorStyleSheets::usesFirstLetterRules):
(WebCore::AuthorStyleSheets::usesRemUnits):
(WebCore::AuthorStyleSheets::setUsesRemUnit):
(WebCore::AuthorStyleSheets::usesStyleBasedEditability):
(WebCore::AuthorStyleSheets::setUsesStyleBasedEditability):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleResolver):
(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::usesStyleBasedEditability):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::haveStylesheetsLoaded):
(WebCore::Document::getCachedLocale):

  • dom/Document.h:

(WebCore::Document::authorStyleSheets):
(WebCore::Document::extensionStyleSheets):
(WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad):
(WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad):
(WebCore::Document::styleSheetCollection): Deleted.

  • dom/DocumentStyleSheetCollection.cpp: Removed.
  • dom/DocumentStyleSheetCollection.h: Removed.
  • dom/ExtensionStyleSheets.cpp: Copied from Source/WebCore/dom/DocumentStyleSheetCollection.cpp.

(WebCore::ExtensionStyleSheets::ExtensionStyleSheets):
(WebCore::ExtensionStyleSheets::pageUserSheet):
(WebCore::ExtensionStyleSheets::clearPageUserSheet):
(WebCore::ExtensionStyleSheets::updatePageUserSheet):
(WebCore::ExtensionStyleSheets::injectedUserStyleSheets):
(WebCore::ExtensionStyleSheets::injectedAuthorStyleSheets):
(WebCore::ExtensionStyleSheets::updateInjectedStyleSheetCache):
(WebCore::ExtensionStyleSheets::invalidateInjectedStyleSheetCache):
(WebCore::ExtensionStyleSheets::addUserSheet):
(WebCore::ExtensionStyleSheets::addDisplayNoneSelector):
(WebCore::ExtensionStyleSheets::maybeAddContentExtensionSheet):
(WebCore::ExtensionStyleSheets::styleResolverChangedTimerFired):
(WebCore::ExtensionStyleSheets::detachFromDocument):
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection): Deleted.
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags): Deleted.
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags): Deleted.
(WebCore::DocumentStyleSheetCollection::pageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::injectedUserStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::injectedAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache): Deleted.
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache): Deleted.
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addUserSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addDisplayNoneSelector): Deleted.
(WebCore::DocumentStyleSheetCollection::maybeAddContentExtensionSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::styleResolverChangedTimerFired): Deleted.
(WebCore::DocumentStyleSheetCollection::removePendingSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode): Deleted.
(WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode): Deleted.
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange): Deleted.
(WebCore::filterEnabledNonemptyCSSStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::activeStyleSheetsForInspector): Deleted.
(WebCore::DocumentStyleSheetCollection::activeStyleSheetsContains): Deleted.
(WebCore::DocumentStyleSheetCollection::detachFromDocument): Deleted.

  • dom/ExtensionStyleSheets.h: Copied from Source/WebCore/dom/DocumentStyleSheetCollection.h.

(WebCore::ExtensionStyleSheets::documentUserStyleSheets):
(WebCore::DocumentStyleSheetCollection::styleSheetsForStyleSheetList): Deleted.
(WebCore::DocumentStyleSheetCollection::activeAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::pendingUpdateType): Deleted.
(WebCore::DocumentStyleSheetCollection::setPendingUpdateType): Deleted.
(WebCore::DocumentStyleSheetCollection::flushPendingUpdates): Deleted.
(WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName): Deleted.
(WebCore::DocumentStyleSheetCollection::addPendingSheet): Deleted.
(WebCore::DocumentStyleSheetCollection::hasPendingSheets): Deleted.
(WebCore::DocumentStyleSheetCollection::usesFirstLineRules): Deleted.
(WebCore::DocumentStyleSheetCollection::usesFirstLetterRules): Deleted.
(WebCore::DocumentStyleSheetCollection::usesRemUnits): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesRemUnit): Deleted.
(WebCore::DocumentStyleSheetCollection::usesStyleBasedEditability): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesStyleBasedEditability): Deleted.

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::childrenChanged):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::nodeName):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):

  • html/HTMLQuoteElement.cpp:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::collectAllDocumentStyleSheets):
(WebCore::InspectorCSSAgent::buildObjectForRule):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):

  • page/Page.cpp:

(WebCore::Page::userStyleSheetLocationChanged):
(WebCore::Page::setUserContentController):

  • page/PageGroup.cpp:
  • page/UserContentController.cpp:

(WebCore::UserContentController::invalidateInjectedStyleSheetCacheInAllFrames):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::getFirstLetter):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::uncachedFirstLineStyle):
(WebCore::RenderElement::cachedFirstLineStyle):

  • rendering/RenderElement.h:

(WebCore::RenderElement::firstLineStyle):
(WebCore::RenderElement::setAncestorLineBoxDirty):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::lineHeight):

  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::lineHeight):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::verticalPositionForBox):

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveLocal):

7:32 AM Changeset in webkit [190168] by Chris Dumez
  • 15 edits
    2 adds in trunk

HTMLOutputElement.htmlFor should be settable
​https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Ryosuke Niwa.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

  • html/AttributeDOMTokenList.cpp:

(WebCore::AttributeDOMTokenList::AttributeDOMTokenList):
(WebCore::AttributeDOMTokenList::attributeValueChanged):

  • html/AttributeDOMTokenList.h:
  • Have AttributeDOMTokenList subclass DOMSettableTokenList instead of

DOMTokenList so that it can be used in places where the IDL expects
us to return a DOMSettableTokenList (e.g. HTMLOutputElement.htmlFor).

  • Mark AttributeDOMTokenList as fast allocated.
  • html/DOMSettableTokenList.cpp:

(WebCore::DOMSettableTokenList::setValue):

  • html/DOMSettableTokenList.h:
  • Move setValue() from DOMTokenList to DOMSettableTokenList as it is only needed by DOMSettableTokenList.
  • Get rid of the factory function as all call sites are using AttributeDOMTokenList now.
  • Stop inheriting RefCounted as AttributeDOMTokenList handles its own refcounting.
  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::setValueInternal):

  • html/DOMTokenList.h:

Rename setValue() to setValueInternal() as this version does not
update the associated attribute value, only the tokens.

  • html/HTMLLinkElement.cpp:
  • html/HTMLLinkElement.h:
  • Have HTMLLinkElement.sizes use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute. The previous code had a bug has setting HTMLLinkElement.sizes would not update the associated 'sizes' attribute. Switching to using AttributeDOMTokenList fixes this and a new layout test has been added to cover this.
  • Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.
  • html/HTMLOutputElement.cpp:
  • html/HTMLOutputElement.h:
  • Have HTMLLinkElement.htmlFor use an AttributeDOMTokenList instead of a DOMSettableTokenList as there is an associated attribute.
  • Create the AttributeDOMTokenList lazily to avoid updating it every time the sizes attribute changes until it is actually accessed.
  • html/HTMLOutputElement.idl:

Add [PutForwards=value] on the htmlFor attribute, as per the
HTML specification.

LayoutTests:

  • fast/dom/HTMLLinkElement/sizes-setter.html: Added
  • fast/dom/HTMLLinkElement/sizes-setter-expected.txt: Added

Add layout test to make sure that setting HTMLLinkElement.sizes actually
updates the 'sizes' associated attribute.

  • fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
  • fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:

Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

4:33 AM Changeset in webkit [190167] by calvaris@igalia.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Streams API] Add transform stream general tests
​https://bugs.webkit.org/show_bug.cgi?id=149267

Reviewed by Darin Adler.

  • streams/reference-implementation/transform-stream-expected.txt: Added.
  • streams/reference-implementation/transform-stream.html: Added.
4:27 AM Changeset in webkit [190166] by calvaris@igalia.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Streams API] Added transform stream error tests
​https://bugs.webkit.org/show_bug.cgi?id=149266

Reviewed by Darin Adler.

  • streams/reference-implementation/transform-stream-errors-expected.txt: Added.
  • streams/reference-implementation/transform-stream-errors.html: Added.
4:25 AM Changeset in webkit [190165] by calvaris@igalia.com
  • 2 edits
    2 adds in trunk/LayoutTests

[Streams API] Added pipe-through transform stream tests
​https://bugs.webkit.org/show_bug.cgi?id=149265

Reviewed by Darin Adler.

  • streams/reference-implementation/pipe-through-expected.txt: Added.
  • streams/reference-implementation/pipe-through.html: Added.
  • streams/reference-implementation/resources/streams-utils.js: Added duckTypedPassThroughTransform function.
4:23 AM Changeset in webkit [190164] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Add count queuing strategy tests for writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148303

Reviewed by Darin Adler.

  • streams/reference-implementation/count-queuing-strategy-expected.txt: Added new expectations.
  • streams/reference-implementation/count-queuing-strategy.html: Added new writable stream tests.
4:17 AM Changeset in webkit [190163] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Add byte length queuing strategy tests for writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148302

Reviewed by Darin Adler.

  • streams/reference-implementation/byte-length-queuing-strategy-expected.txt: Added new expectations.
  • streams/reference-implementation/byte-length-queuing-strategy.html: Added new writable stream tests.
4:14 AM Changeset in webkit [190162] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Add brand checks tests for writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148301

Reviewed by Darin Adler.

  • streams/reference-implementation/brand-checks-expected.txt: Added new expectations.
  • streams/reference-implementation/brand-checks.html: Added new writable stream tests.
4:12 AM Changeset in webkit [190161] by calvaris@igalia.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Streams API] bad underlying sinks tests about writable streams
​https://bugs.webkit.org/show_bug.cgi?id=148295

Reviewed by Darin Adler.

  • streams/reference-implementation/bad-underlying-sinks-expected.txt: Added.
  • streams/reference-implementation/bad-underlying-sinks.html: Added.
4:07 AM Changeset in webkit [190160] by ChangSeok Oh
  • 3 edits
    5 adds in trunk

[GTK] playbutton in media controls is not changed when it is clicked.
​https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

  • css/mediaControlsGtk.css:

(video::-webkit-media-controls-play-button.paused):

LayoutTests:

  • media/media-controls-play-button-updates-expected.png: Added.
  • media/media-controls-play-button-updates-expected.txt: Added.
  • media/media-controls-play-button-updates.html: Added.
  • platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
  • platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
4:03 AM Changeset in webkit [190159] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Add bad strategies writable streams tests
​https://bugs.webkit.org/show_bug.cgi?id=148300

Reviewed by Darin Adler.

  • streams/reference-implementation/bad-strategies-expected.txt: Added new expectations.
  • streams/reference-implementation/bad-strategies.html: Added new writable stream tests.
3:04 AM Changeset in webkit [190158] by calvaris@igalia.com
  • 2 edits in trunk/LayoutTests

[Streams API] Change a const in the tee tests
​https://bugs.webkit.org/show_bug.cgi?id=148294

Reviewed by Darin Adler.

  • streams/reference-implementation/readable-stream-tee.html: Dumb change, replaced a const with var and added

the checkpoint of the spec commit.

1:32 AM Changeset in webkit [190157] by ChangSeok Oh
  • 3 edits in trunk/LayoutTests

[GTK] media/media-controls-timeline-updates.html timeouts
​https://bugs.webkit.org/show_bug.cgi?id=139363

Reviewed by Philippe Normand.

The default timeout value of gtk port is 6000ms for release build layout tests.
But this is too short to pass some media tests such as media-controls-timeline-updates.html
Let's tweak the test to have shorter test time by seeking.

  • media/media-controls-timeline-updates.html:
  • platform/gtk/TestExpectations:
12:33 AM Changeset in webkit [190156] by aestes@apple.com
  • 4 edits in trunk/Source

Disable QuickLook on tvOS
​https://bugs.webkit.org/show_bug.cgi?id=149492
<rdar://problem/22741586>

Reviewed by Dan Bernstein.

Source/WebKit/mac:

We can't use USE(QUICK_LOOK) in a Private header, and postprocess-headers.sh doesn't know how to strip things
that aren't feature flags. So, if QuickLook is disabled, we'll just always define WebQuickLookFileNameKey and
WebQuickLookUTIKey, and we'll also define -quickLookContentForURL: but have it return nil.

  • WebView/WebView.mm:

(-[WebView quickLookContentForURL:]):

Source/WTF:

  • wtf/Platform.h: Stopped enabling QuickLook on tvOS.
12:24 AM Changeset in webkit [190155] by youenn.fablet@crf.canon.fr
  • 27 edits
    1 copy
    8 adds in trunk

[Streams API] Implement ReadableStream pipeThrough
​https://bugs.webkit.org/show_bug.cgi?id=147556

Reviewed by Darin Adler.

Source/JavaScriptCore:

Updating BuiltIns infrastructure to make it reusable from WebCore.
Extracting macros from BuiltinNames and createBuiltinExecutable from BuiltinExecutables.
Updated generate-js-builtins to allow generating builtin CPP/H files in WebCore namespace.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createDefaultConstructor):
(JSC::BuiltinExecutables::createBuiltinExecutable):
(JSC::createBuiltinExecutable):
(JSC::createExecutableInternal):

  • builtins/BuiltinExecutables.h:
  • builtins/BuiltinNames.h:

(JSC::BuiltinNames::BuiltinNames): Deleted.

  • builtins/BuiltinUtils.h: Extracting code from BuiltinNames and BuiltinExecutables.h.
  • bytecode/UnlinkedFunctionExecutable.h:
  • generate-js-builtins:

(getFunctions):
(writeIncludeDirectives):

Source/WebCore:

Adding initial support for JS builtins within WebCore.
This patch allows implementing IDL interface methods in JS, by using the new JSBuiltin keyword.
(No support yet for private identifiers, constructors or accessors).
Integration of the built-in executables and names is implemented within WebCoreJSClientData.
Two files are generated for each JS builtin file:

  • builtin h/cpp files similar to JSCBuiltins.cpp/.h, generated through WebCore/generate-js-builtins from JavaScriptCore/generate-js-builtins)
  • A builtin wrapper file mimicking BuiltinExecutables (generated from WebCore/generate-js-builtins)

Contrary to JSC, each js file is generating its own cpp/h file.
This allows including those files within the JSXX.cpp/.h files generated from the IDL where compilation guard may take effect.

Disabled GObject binding for JSBuiltin methods.

Test: streams/readable-stream-pipeThrough.html

  • CMakeLists.txt: Triggering generate-js-builtins for JS files.
  • DerivedSources.make: Ditto.
  • ForwardingHeaders/builtins/BuiltinUtils.h: Added.
  • ForwardingHeaders/bytecode/UnlinkedFunctionExecutable.h: Added.
  • ForwardingHeaders/runtime/ConstructAbility.h: Added.
  • Modules/streams/ReadableStream.idl: Marking pipeThrough as JS builtin
  • Modules/streams/ReadableStream.js: Added.

(pipeThrough):

  • bindings/js/JSReadableStreamCustom.cpp:
  • bindings/js/WebCoreJSClientData.h: Adding ReadableStreamBuiltinsWrapper to store ReadableStream builtin executable

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::initNormalWorldClientData):

  • bindings/scripts/CodeGeneratorGObject.pm: Disabled GObject binding for JSBuiltin methods.
  • bindings/scripts/CodeGeneratorJS.pm: Adding support for JSBuiltin keyword.

(GetFunctionName):
(GenerateHeader):
(GenerateImplementation):
(GenerateHashTableValueArray):
(ComputeFunctionSpecial):
(UseJSBuiltins):

  • bindings/scripts/IDLAttributes.txt: Adding JSBuiltin.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_js_builtin_method):
(webkit_dom_test_obj_js_builtin_method_with_args):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj jsBuiltinMethod]):
(-[DOMTestObj jsBuiltinMethodWithArgs:strArg:objArg:]):

  • bindings/scripts/test/TestObj.idl:
  • generate-js-builtins: Added.

LayoutTests:

Rebased test that is now passing.
Adding new tests to improve pipeThrough coverage.

  • streams/readable-stream-pipeThrough-expected.txt: Added.
  • streams/readable-stream-pipeThrough.html: Added.
  • streams/reference-implementation/brand-checks-expected.txt:

Sep 22, 2015:

11:43 PM Changeset in webkit [190154] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: speculative non-JIT build fix after r189999.

Not reviewed.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::jsValueRegs):

6:42 PM Changeset in webkit [190153] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

Event fired on a detached node does not bubble up
​https://bugs.webkit.org/show_bug.cgi?id=149488

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined a test now that one more test case passes.

  • web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:

Source/WebCore:

The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see r19897).
Since Firefox's behavior has changed to match DOM4: ​https://dom.spec.whatwg.org/#concept-event-dispatch

Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.

Test: fast/events/event-propagation-in-detached-tree.html

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

LayoutTests:

Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in r19897
since our new behavior matches that of the latest Firefox as well as Chrome.

  • fast/events/event-propagation-in-detached-tree-expected.txt: Added.
  • fast/events/event-propagation-in-detached-tree.html: Added.
  • fast/events/mouseout-dead-node-expected.txt:
  • fast/events/mouseout-dead-node.html:
6:37 PM Changeset in webkit [190152] by Gyuyoung Kim
  • 6 edits in trunk

Add a file of pointer-lock to cmake ports
​https://bugs.webkit.org/show_bug.cgi?id=149453

Reviewed by Csaba Osztrogonác.

.:

  • Source/cmake/OptionsEfl.cmake: Add a ENABLE_POINTER_LOCK.

Source/WebCore:

Some cmake ports will be able to enable POINTER_LOCK. To support it,
this patch adds PointerLockController.cpp, and fix a build break in WK2.

  • CMakeLists.txt:

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick): Fix a build break.

6:35 PM Changeset in webkit [190151] by fpizlo@apple.com
  • 18 edits
    2 deletes in trunk/Source/JavaScriptCore

GCThreadSharedData is just a bad way of saying Heap
​https://bugs.webkit.org/show_bug.cgi?id=149435

Reviewed by Mark Lam.

This removes the GCThreadSharedData class and moves its members into Heap. This is a net
simplification since GCThreadSharedData had a 1-to-1 mapping to Heap and the two classes had a
vast contract with a lot of interdependencies. Heap would call a lot of GCThreadSharedData
methods; now a lot of those are inlined since they were only called from the one place in Heap.
This makes it a lot easier to see what is going on. For example, you no longer have to look at
code in two places (Heap and GCThreadSharedData) to figure out the timing and synchronization
of GC phases - all of that code is in Heap now.

This also removes weird indirections in other places. It used to be that a lot of GC helper
classes woud have a pointer to GCThreadSharedData, and then would use that to get to Heap, VM,
and the visitors. Now these helpers just point to Heap.

I think that GCThreadSharedData was only useful for defining the set of things that we need to
know to collect garbage. That's how we decided if something would go into GCThreadSharedData
instead of Heap. But I think that separating things into multiple classes usually makes the
code less hackable, so there should be a very high bar for doing this in a way that produces a
1-to-1 mapping between two classes - where one instance of one of the classes is always paired
with exactly one instance of the other class and vice-versa.

(JSC::CopyVisitor::CopyVisitor):
(JSC::CopyVisitor::copyFromShared):

  • heap/CopyVisitor.h:
  • heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::allocateNewSpaceSlow):
(JSC::CopyVisitor::startCopying):
(JSC::CopyVisitor::doneCopying):
(JSC::CopyVisitor::didCopy):

  • heap/GCThread.cpp:

(JSC::GCThread::GCThread):
(JSC::GCThread::waitForNextPhase):
(JSC::GCThread::gcThreadMain):

  • heap/GCThread.h:
  • heap/GCThreadSharedData.cpp: Removed.
  • heap/GCThreadSharedData.h: Removed.
  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::isPagedOut):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::objectCount):
(JSC::Heap::sweepNextLogicallyEmptyWeakBlock):
(JSC::Heap::threadVisitCount):
(JSC::Heap::threadBytesVisited):
(JSC::Heap::threadBytesCopied):
(JSC::Heap::startNextPhase):
(JSC::Heap::endCurrentPhase):

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::unregisterWeakGCMap):
(JSC::Heap::getNextBlocksToCopy):

  • heap/ListableHandler.h:
  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::markStack):
(JSC::SlotVisitor::isEmpty):
(JSC::SlotVisitor::sharedData): Deleted.

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::addWeakReferenceHarvester):
(JSC::SlotVisitor::addUnconditionalFinalizer):
(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::heap):
(JSC::SlotVisitor::vm):

6:35 PM Changeset in webkit [190150] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Mark http/tests/notifications/events.html flaky again (crash/timeout this time).

Unreviewed.

6:29 PM Changeset in webkit [190149] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: The right sidebar always opens up on breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=149261

Patch by Devin Rousso <Devin Rousso> on 2015-09-22
Reviewed by Timothy Hatcher.

Whenever the debugger was paused, the sidebar was being forced to open.
This has been removed in favor of letting the user decide.

  • UserInterface/Base/Main.js:

(WebInspector._debuggerDidPause):

6:13 PM Changeset in webkit [190148] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

6:11 PM Changeset in webkit [190147] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-601.2.6

New Tag.

5:39 PM Changeset in webkit [190146] by sbarati@apple.com
  • 9 edits
    1 add in trunk

Web Inspector: [ES6] Improve Type Profiler Support for Arrow Functions
​https://bugs.webkit.org/show_bug.cgi?id=143171

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

We now need to take into account TypeProfilerSearchDescriptor when
hashing results for type profiler queries. Before, we've gotten
away with not doing this because before we would never have a text
collision between a return type text offset and a normal expression text
offset. But, with arrow functions, we will have collisions when
the arrow function doesn't have parens around its single parameter.
I.e: "param => { ... };"

  • runtime/TypeProfiler.cpp:

(JSC::TypeProfiler::findLocation):

  • runtime/TypeProfiler.h:

(JSC::QueryKey::QueryKey):
(JSC::QueryKey::isHashTableDeletedValue):
(JSC::QueryKey::operator==):
(JSC::QueryKey::hash):

  • tests/typeProfiler/arrow-functions.js: Added.

Source/WebInspectorUI:

Esprima and JSC both support arrow functions. We just
need to support it in our AST and do the right things
to include support in the type profiler bits.

  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
(WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList.isLineTerminator):
(WebInspector.TypeTokenAnnotator.prototype._translateToOffsetAfterFunctionParameterList):

  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement.removeFunctionsFilter):
(WebInspector.ScriptSyntaxTree.prototype.containsNonEmptyReturnStatement):
(WebInspector.ScriptSyntaxTree.functionReturnDivot):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

  • inspector/model/parse-script-syntax-tree-expected.txt:
  • inspector/model/parse-script-syntax-tree.html:
5:33 PM Changeset in webkit [190145] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop unnecessary ancestor traversal in Range::selectNode()
​https://bugs.webkit.org/show_bug.cgi?id=149482

Reviewed by Ryosuke Niwa.

Drop unnecessary ancestor traversal in Range::selectNode(). It traversed
the ancestors to throw a INVALID_NODE_TYPE_ERR if one of them was a
DocumentType Node. However, it is impossible for a DocumentType Node to
have children.

  • dom/Range.cpp:

(WebCore::Range::selectNode):

5:27 PM Changeset in webkit [190144] by Sukolsak Sakshuwong
  • 1 edit in trunk/Source/JavaScriptCore/wasm/WASMFunctionSyntaxChecker.h

Unreviewed, fix argument types in WASMFunctionSyntaxChecker.h.

  • wasm/WASMFunctionSyntaxChecker.h:
4:51 PM Changeset in webkit [190143] by bweinstein@apple.com
  • 2 edits in trunk/Source/WebCore

Error message in ContentExtensionError.cpp shouldn't have two spaces between sentences.
​https://bugs.webkit.org/show_bug.cgi?id=149479

Reviewed by Andy Estes.

  • contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

4:49 PM Changeset in webkit [190142] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch/Source/WebCore

Merge r189200. rdar://problem/22803080

4:32 PM Changeset in webkit [190141] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

URL of page visited in private browsing still appears in Activity Monitor after page is closed
​https://bugs.webkit.org/show_bug.cgi?id=149475
rdar://problem/22684521

Reviewed by Dan Bernstein.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
Make sure to call updateActivePages after removing the page from the page map.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateActivePages):
Don't include pages that have private browsing enabled.

4:28 PM Changeset in webkit [190140] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Rollout r189200. rdar://problem/22803080

4:14 PM Changeset in webkit [190139] by Chris Dumez
  • 4 edits in trunk

Range.surroundContents() should check for partially contained non-Text nodes first
​https://bugs.webkit.org/show_bug.cgi?id=149476

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing W3C DOM test now that more checks are passing.

  • web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Range.surroundContents() should check for partially contained non-Text
nodes first, before checking the type of the newParent parameter:

Firefox and Chrome follow the specification.

No new tests, already covered by existing test.

  • dom/Range.cpp:

(WebCore::Range::surroundContents):

4:06 PM Changeset in webkit [190138] by Chris Dumez
  • 19 edits in trunk

Unreviewed, rolling out r190134.
​https://bugs.webkit.org/show_bug.cgi?id=149481

"Seems to cause crashes during garbage collection" (Requested
by cdumez on #webkit).

Reverted changeset:

"HTMLOutputElement.htmlFor should be settable"
​https://bugs.webkit.org/show_bug.cgi?id=149418
​http://trac.webkit.org/changeset/190134

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-09-22

3:35 PM Changeset in webkit [190137] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merge r189200. rdar://problem/22803080

3:27 PM Changeset in webkit [190136] by Chris Dumez
  • 4 edits in trunk

Range.intersectsNode() does not behave according to the specification when start / end are equal
​https://bugs.webkit.org/show_bug.cgi?id=148774
<rdar://problem/22571418>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C Range test now that another check is passing.

  • web-platform-tests/dom/ranges/Range-intersectsNode-expected.txt:

Source/WebCore:

Range.intersectsNode() does not behave according to the specification
when start / end are equal:
​https://dom.spec.whatwg.org/#dom-range-intersectsnode

The specification says:
"If (parent, offset) is before end and (parent, offset + 1) is after
start, return true."

However, the way we were detecting "is before end" and "is after start"
was flawed in the case where start / end were equal. This is because when
comparePoint() return 0, then it means that the node/offset is not only
equal to start but also equal to end. As such, it is not "after start"
/ "before end".

No new tests, already covered by existing.

  • dom/Range.cpp:

(WebCore::Range::intersectsNode):
(WebCore::highestAncestorUnderCommonRoot): Deleted.

2:39 PM Changeset in webkit [190135] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Mark http/tests/notifications/events.html flaky.
​https://bugs.webkit.org/show_bug.cgi?id=149218

Unreviewed.

2:24 PM Changeset in webkit [190134] by Chris Dumez
  • 19 edits in trunk

HTMLOutputElement.htmlFor should be settable
​https://bugs.webkit.org/show_bug.cgi?id=149418

Reviewed by Darin Adler.

Source/WebCore:

HTMLOutputElement.htmlFor should be settable as per the latest HTML
specification:

It is supposed to call DOMSettableTokenList.setValue() with the input
String. This patch adds support for this by adding [PutForwards=value]
IDL extended attribute.

This aligns our behavior with the specification, Firefox and Chrome.

No new tests, already covered by existing test.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::classList):

  • dom/Element.cpp:

(WebCore::Element::classList):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::setClassList):

  • html/AttributeDOMTokenList.h:
  • html/DOMSettableTokenList.h:
  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::relList):

  • html/HTMLAnchorElement.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::relList):

  • html/HTMLLinkElement.h:
  • html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::HTMLOutputElement):
(WebCore::HTMLOutputElement::parseAttribute):
(WebCore::HTMLOutputElement::childrenChanged): Deleted.

  • html/HTMLOutputElement.h:
  • html/HTMLOutputElement.idl:

LayoutTests:

Update existing layout test now that HTMLOutputElement.htmlFor is
settable.

  • fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt:
  • fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js:
2:11 PM Changeset in webkit [190133] by aestes@apple.com
  • 2 edits in trunk/Tools

ContentFiltering.AllowDownloadAfterAddData is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=148885
<rdar://problem/22729563>

Reviewed by Alexey Proskuryakov.

The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
but there is no guarantee of this. For tests that should allow a download, spin the runloop until
-_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.

  • TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:

(downloadTest):

2:08 PM Changeset in webkit [190132] by timothy_horton@apple.com
  • 5 edits in trunk/LayoutTests

Demystify why a few text tests depend on threaded scrolling being disabled

  • fast/text/combining-character-sequence-vertical.html:
  • fast/text/descent-clip-in-scaled-page-expected.html:
  • fast/text/descent-clip-in-scaled-page.html:
  • fast/text/vertical-quotation-marks.html:
1:41 PM Changeset in webkit [190131] by fpizlo@apple.com
  • 13 edits in trunk/Source

Get rid of ENABLE(PARALLEL_GC)
​https://bugs.webkit.org/show_bug.cgi?id=149436

Reviewed by Mark Lam.

We always enable parallel GC everywhere but Windows, and it doesn't look like it was disabled
there for any good reason. So, get rid of the flag.

Source/JavaScriptCore:

The only effect of this change is that parallel GC will now be enabled on Windows, provided
that the CPU detection finds more than one.

  • heap/GCThread.cpp:

(JSC::GCThread::gcThreadMain):

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::resetChildren):
(JSC::GCThreadSharedData::childBytesCopied):
(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::~GCThreadSharedData):
(JSC::GCThreadSharedData::reset):
(JSC::GCThreadSharedData::didStartMarking):

  • heap/Heap.cpp:

(JSC::Heap::converge):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):

  • heap/MarkedBlock.h:
  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):

  • runtime/Options.cpp:

(JSC::computeNumberOfGCMarkers):

Source/WTF:

  • wtf/MainThread.cpp:

(WTF::canAccessThreadLocalDataForThread):
(WTF::initializeGCThreads):
(WTF::registerGCThread):
(WTF::isMainThreadOrGCThread):

  • wtf/Platform.h:
1:11 PM Changeset in webkit [190130] by Sukolsak Sakshuwong
  • 9 edits in trunk/Source/JavaScriptCore

Implement min and max instructions in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149454

Reviewed by Geoffrey Garen.

This patch implements min and max instructions in WebAssembly.

  • tests/stress/wasm-arithmetic-float64.js:
  • tests/stress/wasm-arithmetic-int32.js:
  • tests/stress/wasm/arithmetic-float64.wasm:
  • tests/stress/wasm/arithmetic-int32.wasm:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildMinOrMaxI32):
(JSC::WASMFunctionCompiler::buildMinOrMaxF64):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseMinOrMaxExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseMinOrMaxExpressionF64):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxI32):
(JSC::WASMFunctionSyntaxChecker::buildMinOrMaxF64):

1:01 PM Changeset in webkit [190129] by fpizlo@apple.com
  • 23 edits in trunk/Source

Get rid of ENABLE(GGC)
​https://bugs.webkit.org/show_bug.cgi?id=149472

Reviewed by Mark Hahnenberg and Mark Lam.

Source/JavaScriptCore:

Getting rid of this feature flag allows us to remove a lot of yuck.

  • bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::generate):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::linkBranches):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):
(JSC::DFG::SpeculativeJIT::writeBarrier):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::selectScratchGPR):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::moveTrueTo):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileBaseValueStoreBarrier):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::moveTrueTo):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):

  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::clearRememberedSet):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::flushWriteBarrierBuffer):
(JSC::Heap::shouldDoFullCollection):
(JSC::Heap::addLogicallyEmptyWeakBlock):

  • heap/HeapInlines.h:

(JSC::Heap::isWriteBarrierEnabled):
(JSC::Heap::writeBarrier):
(JSC::Heap::reportExtraMemoryAllocated):
(JSC::Heap::reportExtraMemoryVisited):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearMarks):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::didAllocateInBlock):
(JSC::MarkedSpace::objectCount):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):
(JSC::JIT::emitIdentifierCheck):
(JSC::JIT::privateCompilePutByVal):

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

Source/WebCore:

No new tests because no new behavior.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonVM):

Source/WTF:

  • wtf/Platform.h:
12:33 PM Changeset in webkit [190128] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

the toInt32 operation inside DFGSpeculativeJIT.cpp can't throw so we shouldn't emit an exceptionCheck after it.
​https://bugs.webkit.org/show_bug.cgi?id=149467

Reviewed by Mark Lam.

The callOperation for toInt32 won't store a call site index in the call frame.
Therefore, if this is the first callOperation in the current compilation,
and we emit an exception check inside a try block, we will hit an assertion
saying that we must have DFGCommonData::codeOrigins.size() be > 0 inside
DFGCommonData::lastCallSite(). Therefore, it is imperative that we don't
emit exception checks for callOperations that don't throw exceptions and
don't store a call site index in the call frame.

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::lastCallSite):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

12:28 PM Changeset in webkit [190127] by ap@apple.com
  • 4 edits in trunk/Tools

Mavericks: Media tests start to time out after a few days of bot uptime
​https://bugs.webkit.org/show_bug.cgi?id=149468

Reviewed by Chris Dumez.

  • Scripts/webkitpy/port/base.py:
  • Scripts/webkitpy/port/driver.py:
  • Scripts/webkitpy/port/mac.py:
12:15 PM Changeset in webkit [190126] by clopez@igalia.com
  • 2 edits in trunk

[CMake] Allow to enable OpenMP support.
​https://bugs.webkit.org/show_bug.cgi?id=149457

Reviewed by Csaba Osztrogonác.

  • Source/cmake/OptionsCommon.cmake: Add the option USE_OPENMP that

will enable the support for OpenMP. Currently this is only used as
an alternative implementation to native threads for the parallelization
of the SVG filters. But name the option with a generic name (USE_OPENMP)
as it could be also used to enable future features that depend on OpenMP.

11:46 AM Changeset in webkit [190125] by Sukolsak Sakshuwong
  • 5 edits in trunk/Source/JavaScriptCore

Implement the conditional instruction in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149451

Reviewed by Geoffrey Garen.

This patch implements the conditional (ternary) instruction in WebAssembly.
This is basically "condition ? exp1 : exp2" in JavaScript.

The use of context.discard() in WASMFunctionParser::parseConditional()
is not ideal. We don't discard anything. We just use it to decrement the
stack top in the WebAssembly baseline JIT. When we optimize the JIT by
storing results directly into the destination like the JavaScript
baseline JIT, the code will look like this:

ContextExpression temp = context.newTemporary();
ContextExpression condition = parseExpressionI32(context);
context.jumpToTargetIf(Context::JumpCondition::Zero, condition, elseTarget);

parseExpression(context, temp, expressionType);
context.jumpToTarget(end);

context.linkTarget(elseTarget);
parseExpression(context, temp, expressionType);
context.linkTarget(end);

return temp;

which looks cleaner than using discard().

  • tests/stress/wasm-control-flow.js:
  • tests/stress/wasm/control-flow.wasm:
  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseConditional):

  • wasm/WASMFunctionParser.h:
11:45 AM Changeset in webkit [190124] by timothy_horton@apple.com
  • 31 edits in trunk/Source

Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
​https://bugs.webkit.org/show_bug.cgi?id=149428

Reviewed by Simon Fraser and Darin Adler.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):
Make the RenderingMode parameter to ImageBuffer::create non-optional.

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::renderingMode):

  • platform/graphics/GraphicsTypes.h:

Add renderingMode() getter so that every caller doesn't need to do the conversion to RenderingMode.

  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):
These five callers create unconditionally unaccelerated ImageBuffers which
should probably instead respect the acceleration bit from the context
that the ImageBuffer will eventually be painted into. Bugs have been filed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):
Adjust the argument order and remove defaults which are passed explicitly.

  • page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
Snapshots are (currently) meant to be taken without accelerated drawing.
Make this explicit.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):
Make use of createCompatibleBuffer. This caller was previously creating
an unconditionally unaccelerated context!

  • platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::drawPattern):
Remove a comment.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::getScratchBuffer):
ShadowBlur is only used with unaccelerated contexts, so it's OK to hardcode Unaccelerated here.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
Flip the order of the arguments.

(WebCore::FilterEffect::openCLImageToImageBuffer):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded):
Adjust the argument order and remove defaults which are passed explicitly.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):
Get rid of the unneeded renderingMode local, and factor out retrieval of Frame.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
These two callers are unconditionally creating unaccelerated buffers,
and changing this to match the destination context seems to actually
break things. This needs further investigation.

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
Make use of renderingMode().

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
Adjust the argument order.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:

(WebKit::ThreadSafeCoordinatedSurface::create):

11:27 AM Changeset in webkit [190123] by Chris Dumez
  • 3 edits
    2 adds in trunk

XMLHttpRequest properties should be on the prototype
​https://bugs.webkit.org/show_bug.cgi?id=149465

Reviewed by Darin Adler.

Source/WebCore:

Move most XMLHttpRequest properties to the prototype, as per the Web IDL
specification. This should be web-compatible now that properties on the
prototype are configurable after r190104.

The 'response' / 'responseText' properties are still incorrectly on the
instance because they are currently using a [CustomGetter] in our IDL
and the bindings generator currently does not move such properties to
the prototype.

Test:
fast/xmlhttprequest/xmlhttprequest-properties-prototype.html
js/dom/xhr-prototype-define-property.html

  • bindings/scripts/CodeGeneratorJS.pm:

(InterfaceRequiresAttributesOnInstanceForCompatibility): Deleted.

LayoutTests:

Add layout test to check that XMLHttpRequest properties are on the
prototype and have the right properties (enumerable and configurable).

  • fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt: Added.
  • fast/xmlhttprequest/xmlhttprequest-properties-prototype.html: Added.
10:54 AM Changeset in webkit [190122] by n_wang@apple.com
  • 2 edits in trunk/Tools

Unreviewed, add myself to the committers list.

  • Scripts/webkitpy/common/config/contributors.json:
10:48 AM Changeset in webkit [190121] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] New entry bodies remain in dirty memory after being written to disk.
<​https://webkit.org/b/149463>

Reviewed by Antti Koivisto.

Call msync(MS_ASYNC) on cache entry bodies after writing their data to a
memory-mapped file. This turns the previously dirty memory into clean memory,
reducing our effective footprint.

I previously believed this would happen automatically when the kernel finds
itself under memory pressure, around the same time as it starts dropping
volatile pages. Turns out that's not the case. Even under considerable pressure,
we never flush this memory to file. So let's take care of it ourselves.

If this ends up generating more IO activity than we're comfortable with on some
scenario, we can look at throttling.

  • NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::Data::mapToFile):

10:17 AM Changeset in webkit [190120] by Chris Dumez
  • 72 edits
    134 deletes in trunk

Drop support for legacy EntityReference DOM Node type
​https://bugs.webkit.org/show_bug.cgi?id=149348

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that more checks are passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop support for legacy EntityReference DOM Node type.

EntityReference has been dropped from the DOM specification:

EntityReference is not supported in Firefox:

Chrome dropped support for EntityReference a while back (May 2013):

IE also dropped support for EntityReference Nodes:
​https://msdn.microsoft.com/library/ff974819(v=vs.85).aspx (Remarks section)

No new tests, already covered by existing test.

  • DerivedSources.cpp:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap): Deleted.

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline): Deleted.

  • bindings/objc/DOM.mm:

(kitClass): Deleted.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Skip webkit_dom_document_create_entity_reference until Carlos fixes it.

  • dom/Attr.cpp:

(WebCore::Attr::childTypeAllowed):
(WebCore::Attr::childrenChanged): Deleted.

  • dom/Attr.h:
  • dom/ContainerNode.cpp:

(WebCore::checkAcceptChild): Deleted.
(WebCore::checkAcceptChildGuaranteedNodeTypes): Deleted.
(WebCore::ContainerNode::removeChild): Deleted.

  • dom/Document.cpp:

(WebCore::Document::createEntityReference):
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
(WebCore::Document::createEditingTextNode): Deleted.
(WebCore::Document::importNode): Deleted.
(WebCore::Document::adoptNode): Deleted.
(WebCore::Document::scheduleForcedStyleRecalc): Deleted.
(WebCore::Document::scheduleStyleRecalc): Deleted.
(WebCore::Document::childTypeAllowed): Deleted.
(WebCore::Document::canAcceptChild): Deleted.

  • dom/Document.h:
  • dom/Document.idl:
  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::childTypeAllowed): Deleted.

  • dom/Element.cpp:

(WebCore::Element::childTypeAllowed): Deleted.

  • dom/EntityReference.cpp:

(WebCore::EntityReference::EntityReference):

  • dom/EntityReference.h:
  • dom/EntityReference.idl:
  • dom/Node.cpp:

(WebCore::Node::setNodeValue):
(WebCore::Node::dumpStatistics): Deleted.
(WebCore::Node::childNodes): Deleted.
(WebCore::Node::lastDescendant): Deleted.
(WebCore::Node::isDescendantOf): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::ancestorElement): Deleted.
(WebCore::hashPointer): Deleted.

  • dom/Node.h:

(WebCore::Node::isDocumentTypeNode): Deleted.

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodeIterator):

  • dom/NodeIterator.h:

(WebCore::NodeIterator::create):

  • dom/NodeIterator.idl:
  • dom/Range.cpp:

(WebCore::Range::checkDeleteExtract):
(WebCore::lengthOfContentsInNode): Deleted.
(WebCore::Range::processContentsBetweenOffsets): Deleted.
(WebCore::Range::insertNode): Deleted.
(WebCore::Range::checkNodeWOffset): Deleted.
(WebCore::Range::checkNodeBA): Deleted.
(WebCore::Range::cloneRange): Deleted.
(WebCore::Range::selectNode): Deleted.
(WebCore::Range::selectNodeContents): Deleted.
(WebCore::Range::surroundContents): Deleted.
(WebCore::Range::shadowRoot): Deleted.
(WebCore::Range::pastLastNode): Deleted.
(WebCore::Range::absoluteBoundingBox): Deleted.
(WebCore::Range::absoluteTextRects): Deleted.

  • dom/Range.h:
  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::childTypeAllowed): Deleted.

  • dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode): Deleted.

  • dom/Traversal.h:

(WebCore::NodeIteratorBase::expandEntityReferences):

  • dom/TreeWalker.cpp:

(WebCore::TreeWalker::TreeWalker):

  • dom/TreeWalker.h:

(WebCore::TreeWalker::create):

  • dom/TreeWalker.idl:
  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup): Deleted.

  • xml/XPathUtil.cpp:

(WebCore::XPath::isValidContextNode): Deleted.

Source/WebKit2:

Drop handling EntityReference Nodes.

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass): Deleted.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAssistableElement):

LayoutTests:

Drop several outdated DOM compliance tests. Update / Rebaseline others.

9:49 AM Changeset in webkit [190119] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

9:13 AM Changeset in webkit [190118] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, rebaseline several W3C html tests on iOS after r190106 and r190085.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt:
9:13 AM Changeset in webkit [190117] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed 32-bit Yosemite build fix.

  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):

9:11 AM Changeset in webkit [190116] by Chris Dumez
  • 4 edits in trunk/LayoutTests

Unreviewed, rebaseline fast/table/rowindex.html after r190099.

  • platform/efl/fast/table/rowindex-expected.txt:
  • platform/gtk/fast/table/rowindex-expected.txt:
  • platform/win/fast/table/rowindex-expected.txt:
7:31 AM Changeset in webkit [190115] by eric.carlson@apple.com
  • 19 edits
    2 adds in trunk/Source/WebCore

[MediaStream Mac] implement WebAudioSourceProvider
​https://bugs.webkit.org/show_bug.cgi?id=149419

Reviewed by Darin Adler.

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::audioSourceProvider): New.

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource): Rewrite.

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode): We know the Vector

size, so reserve capacity.

  • Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::audioSourceProvider): Add.

  • Modules/webaudio/MediaStreamAudioSource.h:

(WebCore::MediaStreamAudioSource::~MediaStreamAudioSource):
(WebCore::MediaStreamAudioSource::deviceId):
(WebCore::MediaStreamAudioSource::setDeviceId):
(WebCore::MediaStreamAudioSource::useIDForTrackID): Deleted.

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::create): Context and track can't be null so take references.
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode): Ditto.
(WebCore::MediaStreamAudioSourceNode::~MediaStreamAudioSourceNode): Clear provider client.
(WebCore::MediaStreamAudioSourceNode::setFormat): Create a resampler when necessary.
(WebCore::MediaStreamAudioSourceNode::process): Process.
(WebCore::MediaStreamAudioSourceNode::reset): Deleted.

  • Modules/webaudio/MediaStreamAudioSourceNode.h:

(WebCore::MediaStreamAudioSourceNode::mediaStream):
(WebCore::MediaStreamAudioSourceNode::audioSourceProvider): Deleted.

  • WebCore.xcodeproj/project.pbxproj: Add WebAudioSourceProviderAVFObjC.cpp/h.
  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::audioSourceProvider): New, passthrough to source.

  • platform/mediastream/MediaStreamTrackPrivate.h:
  • platform/mediastream/RealtimeMediaSource.h:

(WebCore::RealtimeMediaSource::audioSourceProvider):

  • platform/mediastream/mac/AVAudioCaptureSource.h:
  • platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::audioSourceProvider): New.

  • platform/mediastream/mac/AVCaptureDeviceManager.mm:
  • platform/mediastream/mac/AVMediaCaptureSource.h:
  • platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::audioSourceProvider): Assert, this shouldn't be reachable.

  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h: Added.
  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm: Added.

(WebCore::WebAudioSourceProviderAVFObjC::create):
(WebCore::WebAudioSourceProviderAVFObjC::WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::~WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::startProducingData):
(WebCore::WebAudioSourceProviderAVFObjC::stopProducingData):
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::setClient):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):
(WebCore::WebAudioSourceProviderAVFObjC::unprepare):
(WebCore::WebAudioSourceProviderAVFObjC::process):

6:59 AM Changeset in webkit [190114] by commit-queue@webkit.org
  • 6 edits in trunk

Source/WebCore:
CurrentTime on mediaController is set as 0 when playback is completed.
​https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <​sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

Test : media/media-controller-time-clamp.html

  • html/MediaController.cpp:

(MediaController::setCurrentTime):
(MediaController::updatePlaybackState):

  • html/MediaController.h:

LayoutTests:
Add test for checking currentTime of mediacontroller when playback is completed.
​https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <​sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

  • media/media-controller-time-clamp-expected.txt:
  • media/media-controller-time-clamp.html:
5:21 AM Changeset in webkit [190113] by commit-queue@webkit.org
  • 74 edits in trunk/Source

Unreviewed, rolling out r189616.
​https://bugs.webkit.org/show_bug.cgi?id=149456

suspected cause of multiple regressions (Requested by kling on
#webkit).

Reverted changeset:

"[JSC] Weak should only accept cell pointees."
​https://bugs.webkit.org/show_bug.cgi?id=148955
​http://trac.webkit.org/changeset/189616

3:06 AM Changeset in webkit [190112] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Fix the all-in-one build with GCC
​https://bugs.webkit.org/show_bug.cgi?id=148428

Reviewed by Darin Adler.

Removed Source/WebCore/inspector/InspectorIndexedDBAgent.cpp from the all-in-one build.

  • WebCore.vcxproj/WebCore.vcxproj:
  • inspector/InspectorAllInOne.cpp:
2:32 AM Changeset in webkit [190111] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix warnings in IDLParser.pm
​https://bugs.webkit.org/show_bug.cgi?id=149406

Reviewed by Alex Christensen.

  • bindings/scripts/IDLParser.pm:

(typeHasNullableSuffix):
(typeRemoveNullableSuffix):

1:26 AM Changeset in webkit [190110] by sbarati@apple.com
  • 7 edits in trunk

Web Inspector: update Esprima to latest version
​https://bugs.webkit.org/show_bug.cgi?id=148960

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Esprima version 2.6 further supports ES6. We're
updating to it so we can support more ES6 features
in our script syntax tree.

  • UserInterface/External/Esprima/LICENSE:
  • UserInterface/External/Esprima/esprima.js:
  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):
(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):

LayoutTests:

  • inspector/model/parse-script-syntax-tree-expected.txt:
  • inspector/model/parse-script-syntax-tree.html:
1:17 AM Changeset in webkit [190109] by rniwa@webkit.org
  • 11 edits in trunk

invalidateSlotAssignments should trigger style recalc
​https://bugs.webkit.org/show_bug.cgi?id=149447

Reviewed by Antti Koivisto.

Source/WebCore:

Invalidate the render tree of a shadow host when a new child is inserted, an existing child is removed,
or slot attribute of a child is modified.

No new tests. Covered by existing tests added in r190101.

  • dom/Element.cpp:

(WebCore::Element::childrenChanged): Call invalidateSlotAssignments or invalidateDefaultSlotAssignments
depending on the types of children being inserted or removed since text nodes can only be assigned into
a default slot.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::invalidateSlotAssignments):
(WebCore::ShadowRoot::invalidateDefaultSlotAssignments): Added.

  • dom/ShadowRoot.h:
  • dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::invalidate): Reconstruct the render tree for the whole host. We can optimize
in the future by only invalidating active slot elements instead.
(WebCore::SlotAssignment::invalidateDefaultSlot): Added.

  • dom/SlotAssignment.h:

LayoutTests:

Removed failing expectations from newly passing tests.

Also added test cases for inserting and removing text nodes, and modified the style recalc tests
to force layout between each DOM change to test case separately.

  • fast/shadow-dom/shadow-layout-after-host-child-changes.html:
  • fast/shadow-dom/shadow-layout-after-inserting-or-removing-host-child.html:
  • fast/shadow-dom/shadow-layout-after-slot-changes.html:
  • platform/mac/TestExpectations:
12:35 AM Changeset in webkit [190108] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Web Inspector: Basic Block Annotations and Type Profiler annotations wrong for script with "class" with default constructor
​https://bugs.webkit.org/show_bug.cgi?id=149248

Reviewed by Mark Lam.

We keep track of which functions have and have not
executed so we can show visually, inside the inspector,
which functions have and have not executed. With a default
constructor, our parser parses code that isn't in the actual
JavaScript source code of the user. Our parser would then
give us a range of starting at "1" to "1 + default constructor length"
as being the text range of a function. But, this would then pollute
actual source code that was at these ranges.

Therefore, we should treat these default constructor source
codes as having "invalid" ranges. We use [UINT_MAX, UINT_MAX]
as the invalid range. This range has the effect of not polluting
valid ranges inside the source code.

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
(JSC::UnlinkedFunctionExecutable::setInvalidTypeProfilingOffsets):

  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewDefaultConstructor):

12:29 AM Changeset in webkit [190107] by ryuan.choi@navercorp.com
  • 2 edits in trunk

[EFL] Build break when DEVELOPER_MODE is OFF
​https://bugs.webkit.org/show_bug.cgi?id=149448

Reviewed by Gyuyoung Kim.

Since r187191, DatabaseProcessMainUnix is missing in symbol filter.

  • Source/cmake/eflsymbols.filter:

Sep 21, 2015:

11:25 PM Changeset in webkit [190106] by Chris Dumez
  • 21 edits
    3 adds in trunk

time element should use HTMLTimeElement interface
​https://bugs.webkit.org/show_bug.cgi?id=148840
<rdar://problem/22586690>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C HTML test now that more checks are passing.

  • web-platform-tests/html/semantics/text-level-semantics/the-time-element/001-expected.txt:

Source/WebCore:

Time element should be an instance of HTMLTimeElement instead of generic
HTMLElement:
​https://html.spec.whatwg.org/multipage/semantics.html#the-time-element

Firefox exposes HTMLTimeElement. This patch aligns our behavior with
the specification and Firefox.

No new tests, already covered by existing test.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLElementsAllInOne.cpp:
  • html/HTMLTagNames.in:
  • html/HTMLTimeElement.cpp: Added.

(WebCore::HTMLTimeElement::create):
(WebCore::HTMLTimeElement::HTMLTimeElement):

  • html/HTMLTimeElement.h: Added.
  • html/HTMLTimeElement.idl: Added.

LayoutTests:

Rebaseline existing test now that HTMLTimeElement is exposed on the
global Window object.

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
11:01 PM Changeset in webkit [190105] by Sukolsak Sakshuwong
  • 5 edits
    2 adds in trunk/Source/JavaScriptCore

Implement the comma instruction in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149425

Reviewed by Geoffrey Garen.

This patch implements the comma instruction in WebAssembly. The comma
instruction evaluates the left operand and then the right operand and
returns the value of the right operand.

  • tests/stress/wasm-comma.js: Added.

(shouldBe):

  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::discard):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseComma):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::discard):

10:36 PM Changeset in webkit [190104] by Chris Dumez
  • 11 edits
    2 adds in trunk

DOM attributes on prototypes should be configurable
​https://bugs.webkit.org/show_bug.cgi?id=134364

Reviewed by Sam Weinig.

Source/WebCore:

DOM attributes on prototypes should be configurable as per the Web IDL
specification:
​https://heycam.github.io/webidl/#es-attributes

This patch aligns our behavior with the specification and Firefox.

Test: fast/dom/attributes-configurable.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):

LayoutTests:

Add a layout test to confirm that attributes on prototypes are configurable.

  • fast/dom/attributes-configurable-expected.txt: Added.
  • fast/dom/attributes-configurable.html: Added.
9:34 PM Changeset in webkit [190103] by fpizlo@apple.com
  • 9 edits in trunk/Source

Always use the compiler's CAS implementation and get rid of ENABLE(COMPARE_AND_SWAP)
​https://bugs.webkit.org/show_bug.cgi?id=149438

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • heap/HeapInlines.h:

(JSC::Heap::reportExtraMemoryVisited):
(JSC::Heap::deprecatedReportExtraMemory):

Source/WebCore:

No new tests because no new behavior.

  • platform/text/TextBreakIterator.cpp:

(WebCore::compareAndSwapNonSharedCharacterBreakIterator):
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator):

Source/WTF:

  • wtf/Atomics.h: Make weakCompareAndSwap() just forward to the system CAS via WTF::Atomic.

(WTF::weakCompareAndSwap):
(WTF::weakCompareAndSwapUIntPtr): Deleted.
(WTF::weakCompareAndSwapSize): Deleted.

  • wtf/Bitmap.h: Small changes to use the new API.

(WTF::WordType>::concurrentTestAndSet):

  • wtf/Platform.h: Remove ENABLE(COMPARE_AND_SWAP)
9:27 PM Changeset in webkit [190102] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Allow DataDetectors to pre-filter telephone number menu items
​https://bugs.webkit.org/show_bug.cgi?id=149444
<rdar://problem/19286320>

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/spi/mac/DataDetectorsSPI.h:

Add some SPI.

Source/WebKit2:

  • Platform/mac/MenuUtilities.mm:

(WebKit::menuItemForTelephoneNumber):
(WebKit::menuForTelephoneNumber):
Let DataDetectors know what kind of items we want, so that they can avoid
some unnecessary work in cases where we were just going to throw away the items anyway.

9:01 PM Changeset in webkit [190101] by rniwa@webkit.org
  • 2 edits
    4 copies
    4 adds in trunk/LayoutTests

Add some style recalc tests for shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=149445

Reviewed by Antti Koivisto.

Add tests to make sure we trigger necessary style recalc.

  • fast/shadow-dom/shadow-layout-after-attach-shadow-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/shadow-layout-after-attach-shadow.html: Added.
  • fast/shadow-dom/shadow-layout-after-host-child-changes-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/shadow-layout-after-host-child-changes.html: Added.
  • fast/shadow-dom/shadow-layout-after-inserting-or-removing-host-child-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/shadow-layout-after-inserting-or-removing-host-child.html: Added.
  • fast/shadow-dom/shadow-layout-after-slot-changes-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/shadow-layout-after-slot-changes.html: Added.
  • platform/mac/TestExpectations:
8:06 PM Changeset in webkit [190100] by ap@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

​https://bugs.webkit.org/show_bug.cgi?id=149415
REGRESSION (r182648): UIWebView does not set location.hash synchronously
<rdar://problem/22169467>

Reviewed by Darin Adler.

  • fast/loader/location-hash-user-gesture-expected.txt: Added.
  • fast/loader/location-hash-user-gesture.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
7:57 PM Changeset in webkit [190099] by Chris Dumez
  • 6 edits in trunk

Update HTMLTableRowElement.rowIndex to behave according to the specification
​https://bugs.webkit.org/show_bug.cgi?id=148842
<rdar://problem/22586914>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C HTML test now that one more check is passing.

  • web-platform-tests/html/semantics/tabular-data/the-tr-element/rowIndex-expected.txt:

Source/WebCore:

Update HTMLTableRowElement.rowIndex to behave according to the
specification:
​https://html.spec.whatwg.org/multipage/tables.html#dom-tr-rowindex

In particular, rowIndex no longer returns -1 for <tr> elements that are
direct children of the table Element. Also,<tr> Elements in all <thead> /
<tfoot> children of the table Element now get a rowIndex, as per the
specification:

Previously, only <tr> elements in the first <thead> and the first <tbody>
children of the table would get a rowIndex.

Also, we now abort early and return -1 if the row is a grand-child of a
table element but its direct parent is not a <thead> / <tbody> / <tfoot>.
This avoid unnecessary traversal and matches the specification.

The code is refactored a bit to leverage HTMLTableElement.rows(), as
per the specification:
"return the index of the tr element in that table element's rows collection"

Previously, we would duplicate the table traversal logic. This
simplifies the code and fixes a bug as the traversal logic was slightly
different here and in HTMLTableRowsCollection. Because of this, only
<tr> elements in the first <thead> / <tfoot> would get a rowIndex.
Performance should be similar.

No new tests, already covered by existing test.

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):
(WebCore::HTMLTableRowElement::sectionRowIndex): Deleted.
(WebCore::HTMLTableRowElement::insertCell): Deleted.

LayoutTests:

Rebaseline existing test because rows in all <thead> / <tfoot> children
of the <table> Element now get a rowIndex.

  • platform/mac/fast/table/rowindex-expected.txt:
7:26 PM Changeset in webkit [190098] by rniwa@webkit.org
  • 2 edits
    8 copies
    8 adds in trunk/LayoutTests

Add more rendering tests for shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=149437

Reviewed by Antti Koivisto.

Added various tests for shadow tree rendering as well as tests for :host pseudo class and ::slotted pseudo element.

  • fast/shadow-dom/css-scoping-shadow-assigned-node-with-before-after-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-assigned-node-with-before-after.html: Added.
  • fast/shadow-dom/css-scoping-shadow-assigned-node-with-rules-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-assigned-node-with-rules.html: Added.
  • fast/shadow-dom/css-scoping-shadow-host-functional-rule-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-host-functional-rule.html: Added.
  • fast/shadow-dom/css-scoping-shadow-host-rule-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-host-rule.html: Added.
  • fast/shadow-dom/css-scoping-shadow-host-with-before-after-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-host-with-before-after.html: Added.
  • fast/shadow-dom/css-scoping-shadow-slot-display-override-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-slot-display-override.html: Added.
  • fast/shadow-dom/css-scoping-shadow-slotted-rule-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-slotted-rule.html: Added.
  • fast/shadow-dom/css-scoping-shadow-with-outside-rules-expected.html: Copied from LayoutTests/fast/shadow-dom/css-scoping-shadow-root-hides-children-expected.html.
  • fast/shadow-dom/css-scoping-shadow-with-outside-rules.html: Added.
  • platform/mac/TestExpectations:
6:27 PM Changeset in webkit [190097] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix release builds with security assertion after r190007.

  • dom/DocumentOrderedMap.cpp:
  • dom/DocumentOrderedMap.h:
6:21 PM Changeset in webkit [190096] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

functionProtoFuncToString should not rely on typeProfilingEndOffset()
​https://bugs.webkit.org/show_bug.cgi?id=149429

Reviewed by Geoffrey Garen.

We should be able to freely change typeProfilingEndOffset()
without worrying we will break Function.prototype.toString.

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

5:51 PM Changeset in webkit [190095] by yoon@igalia.com
  • 13 edits in trunk/Source

[Threaded Compositor] Modified to use reference of GraphicsContext instead of pointer
​https://bugs.webkit.org/show_bug.cgi?id=149399

Reviewed by Darin Adler.

This fixes build failure after r189144

Source/WebCore:

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::tiledBackingStorePaint):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
  • platform/graphics/texmap/coordinated/CoordinatedSurface.h:
  • platform/graphics/texmap/coordinated/Tile.cpp:

(WebCore::Tile::paintToSurfaceContext):

  • platform/graphics/texmap/coordinated/Tile.h:
  • platform/graphics/texmap/coordinated/TiledBackingStoreClient.h:
  • platform/graphics/texmap/coordinated/UpdateAtlas.cpp:

Source/WebKit2:

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:

(WebKit::ThreadSafeCoordinatedSurface::paintToSurface):
(WebKit::ThreadSafeCoordinatedSurface::beginPaint):
(WebKit::ThreadSafeCoordinatedSurface::endPaint):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.h:
5:38 PM Changeset in webkit [190094] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Unreviewed build fix.

  • WebKit.vcxproj/WebKit/WebKitApple.props: We need to link against

libdispatch on Windows.

5:26 PM Changeset in webkit [190093] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

The binding for getDistributedNodes unnecessarily makes a vector of nodes
​https://bugs.webkit.org/show_bug.cgi?id=149434

Reviewed by Darin Adler.

Added a jsArray for const Vector<T*>* so that we can generate the binding code for getDistributedNodes()
without having to create Vector<RefPtr<Node>> out of Vector<Node*>*.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsArray): Added.

  • html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::assignedNodes):
(WebCore::HTMLSlotElement::getDistributedNodes): Deleted.

  • html/HTMLSlotElement.h:
  • html/HTMLSlotElement.idl:
5:21 PM Changeset in webkit [190092] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r182648): UIWebView does not set location.hash synchronously
​https://bugs.webkit.org/show_bug.cgi?id=149415
<rdar://problem/22169467>

Reviewed by Darin Adler.

The problem was that the delegate in UI thread became asynchronous due to calling
into LaunchServices.

  • WebCoreSupport/WebFrameLoaderClient.mm: (shouldTryAppLink): Don't attempt app

links for same domain navigations. This check is part of substantially more complicated
logic in WebKit2 that I don't understand, but that should be enough to demonstrate
that this fix is an improvement at least.

5:07 PM Changeset in webkit [190091] by Brent Fulgham
  • 19 edits in trunk

Source/WebCore:
[Win] Show tiled drawing debug overlay on Windows
​https://bugs.webkit.org/show_bug.cgi?id=149426

Reviewed by Dean Jackson.

No new tests: No change in behavior.

  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::drawRepaintIndicator): Revise signature to accept
a scale value and a font size.
(WebCore::PlatformCALayer::drawTextAtPoint): Revise signature for new arguments.

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::drawTileMapContents): Removing scaling and text drawing code,
and call common CALayer drawing routine.

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create): Switch to nullptr.
(WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Switch to C++14 initializers.
(WebCore::CACFLayerTreeHost::setPage): Added.
(WebCore::CACFLayerTreeHost::rootLayer): Update debug info layer if requested by settings.
(WebCore::CACFLayerTreeHost::layerTreeDidChange): Ditto.
(WebCore::CACFLayerTreeHost::mainFrameTiledBacking): Added.
(WebCore::CACFLayerTreeHost::updateDbugInfoLayer): Added.

  • platform/graphics/ca/win/CACFLayerTreeHost.h:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(WebCore::PlatformCALayerWin::drawTextAtPoint): Revised signature for new arguments. Use
argument for font size (rather than hard-coded '18'). Adjust font size by passed scale value.

  • platform/graphics/ca/win/PlatformCALayerWin.h:

Source/WebKit/win:
[Win] Show tiled drawing debug overlay on Windows
​https://bugs.webkit.org/show_bug.cgi?id=149426

Reviewed by Dean Jackson.

  • Interfaces/IWebPreferencesPrivate.idl: Add new IWebPreferencesPrivate3 API version

so we can add new methods this cycle.

  • WebPreferenceKeysPrivate.h: Add key for 'WebKitShowTiledScrollingIndicator'
  • WebPreferences.cpp:

(WebPreferences::QueryInterface): Recognize the new IWebPreferencesPrivate3 API.
(WebPreferences::showTiledScrollingIndicator): Added.
(WebPreferences::setShowTiledScrollingIndicator): Ditto.

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Update to recognize 'showTiledScrollingIndicator'.
(WebView::setAcceleratedCompositing): Link the CACFLayerTreeHost to the WebCore Page object
so that it can see settings information.

Tools:
Remove 'nullable' to fix older iOS builds.

Patch by Simon Fraser <Simon Fraser> on 2015-09-21

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):

5:05 PM Changeset in webkit [190090] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Remove old GCC cruft from wtf/StdLibExtras.h
​https://bugs.webkit.org/show_bug.cgi?id=149401

Reviewed by Alex Christensen.

  • wtf/StdLibExtras.h:
4:22 PM Changeset in webkit [190089] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

Disable Parental Controls on the Apple TV platform
​https://bugs.webkit.org/show_bug.cgi?id=149421

Reviewed by Darin Adler.

  • wtf/Platform.h:
4:03 PM Changeset in webkit [190088] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190086.
​https://bugs.webkit.org/show_bug.cgi?id=149427

Broke LayoutTests/inspector/model/remote-object.htm (Requested
by saamyjoon on #webkit).

Reverted changeset:

"Web Inspector: Basic Block Annotations and Type Profiler
annotations wrong for script with "class" with default
constructor"
​https://bugs.webkit.org/show_bug.cgi?id=149248
​http://trac.webkit.org/changeset/190086

3:50 PM Changeset in webkit [190087] by Simon Fraser
  • 2 edits in trunk/Tools

Remove 'nullable' to fix older iOS builds.

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):

3:42 PM Changeset in webkit [190086] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Web Inspector: Basic Block Annotations and Type Profiler annotations wrong for script with "class" with default constructor
​https://bugs.webkit.org/show_bug.cgi?id=149248

Reviewed by Mark Lam.

We keep track of which functions have and have not
executed so we can show visually, inside the inspector,
which functions have and have not executed. With a default
constructor, our parser parses code that isn't in the actual
JavaScript source code of the user. Our parser would then
give us a range of starting at "1" to "1 + default constructor length"
as being the text range of a function. But, this would then pollute
actual source code that was at these ranges.

Therefore, we should treat these default constructor source
codes as having "invalid" ranges. We use [UINT_MAX, UINT_MAX]
as the invalid range. This range has the effect of not polluting
valid ranges inside the source code.

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
(JSC::UnlinkedFunctionExecutable::setInvalidTypeProfilingOffsets):

  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewDefaultConstructor):

3:39 PM Changeset in webkit [190085] by Chris Dumez
  • 25 edits
    2 adds in trunk

[JS Bindings] prototype.constructor should be writable
​https://bugs.webkit.org/show_bug.cgi?id=149412
<rdar://problem/22545096>

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline W3C DOM / HTML tests now that more checks are passing.

  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

prototype.constructor should have the following properties:
{ Writable: true, Enumerable: false, Configurable: true }

as per the Web IDL specification:
​https://heycam.github.io/webidl/#interface-prototype-object

In WebKit, it is currently not writable. It is writable in Firefox.

Test: fast/events/event-prototype-constructor-properties.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:

LayoutTests:

Add layout test that checks that Event.prototype.constructor has the
expected properties and that it is actually writable.

  • fast/events/event-prototype-constructor-properties-expected.txt: Added.
  • fast/events/event-prototype-constructor-properties.html: Added.
3:27 PM Changeset in webkit [190084] by Antti Koivisto
  • 7 edits in trunk

HTMLSlotElement should render its assigned nodes
​https://bugs.webkit.org/show_bug.cgi?id=149242

Reviewed by Ryosuke Niwa.

Source/WebCore:

Support rendering the assigned nodes under HTMLSlotElement.

  • dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::assignSlots):

Move the empty slot finding to the loop as the hash table may mutate.

  • html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::attributeChanged):
(WebCore::HTMLSlotElement::assignedNodes):
(WebCore::HTMLSlotElement::getDistributedNodes):

  • html/HTMLSlotElement.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::attachBeforeOrAfterPseudoElementIfNeeded):
(WebCore::Style::attachSlot):
(WebCore::Style::attachRenderTree):
(WebCore::Style::detachChildren):
(WebCore::Style::detachShadowRoot):
(WebCore::Style::detachSlot):
(WebCore::Style::detachRenderTree):
(WebCore::Style::resolveChildren):
(WebCore::Style::resolveSlot):
(WebCore::Style::resolveTree):

LayoutTests:

Enable the relevant tests.

  • platform/mac/TestExpectations:
3:08 PM Changeset in webkit [190083] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.25

New tag.

3:02 PM Changeset in webkit [190082] by Brent Fulgham
  • 3 edits in trunk/Tools

[Win] Use command-line argument to launch in regular or High DPI mode.
​https://bugs.webkit.org/show_bug.cgi?id=149417

Reviewed by Dean Jackson.

  • MiniBrowser/win/Common.cpp:

(parseCommandLine): Ignore the '--highDPI' argument. It's used at the
very start of execution, before the MiniBrowser.dll is loaded.

  • win/DLLLauncher/DLLLauncherMain.cpp:

(shouldUseHighDPI): Check for '--highDPI', and use this mode if
present. On WinCairo, always use High DPI.

2:52 PM Changeset in webkit [190081] by achristensen@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove Windows-specific navigator-detached-no-crash-expected.
​https://bugs.webkit.org/show_bug.cgi?id=149414

Reviewed by Filip Pizlo.

When we switched to CMake, NAVIGATOR_HWCONCURRENCY got enabled.
There is no reason to disable it, and the expectations match the default expectations now.

  • platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
2:20 PM Changeset in webkit [190080] by Sukolsak Sakshuwong
  • 8 edits in trunk/Source/JavaScriptCore

Implement call statements and call expressions of type void in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149411

Reviewed by Mark Lam.

Call instructions in WebAssembly can be both statements and expressions.
This patch implements call statements. It also implements call
expressions of type void. The only place where call expressions of type
void can occur is the left-hand side of the comma (,) operator, which
will be implemented in a subsequent patch. The comma operator requires
both of its operands to be expressions.

  • tests/stress/wasm-calls.js:
  • tests/stress/wasm/calls.wasm:
  • wasm/WASMConstants.h:
  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseStatement):
(JSC::WASMFunctionParser::parseExpression):
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseExpressionVoid):
(JSC::WASMFunctionParser::parseCallInternal):
(JSC::WASMFunctionParser::parseCallIndirect):
(JSC::WASMFunctionParser::parseCallImport):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMReader.cpp:

(JSC::WASMReader::readOpExpressionVoid):

  • wasm/WASMReader.h:
2:01 PM Changeset in webkit [190079] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

svg/custom/hidpi-masking-clipping.svg fails with accelerated drawing on
​https://bugs.webkit.org/show_bug.cgi?id=149413
<rdar://problem/22787058>

Reviewed by Dean Jackson.

No new tests, this is covered by existing tests.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):

  • rendering/svg/RenderSVGResourcePattern.h:

Make pattern images respect the accelerated bit of the parent GraphicsContext.

1:59 PM Changeset in webkit [190078] by Chris Dumez
  • 10 edits in trunk

DOMTokenList.add() / remove() should run the update steps even if tokens were not modified
​https://bugs.webkit.org/show_bug.cgi?id=148780
<rdar://problem/22571794>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that more checks are passing.

  • web-platform-tests/dom/nodes/MutationObserver-attributes-expected.txt:

Source/WebCore:

DOMTokenList.add() / remove() should run the update steps even if tokens
were not modified, as per the DOM specification:

The update steps are specified at:

This will have several side effects if the DOMTokenList has an associated
attribute. It will overwrite the attribute value which will:

  1. Generate a Mutation event.
  2. Possibly change the attribute value as the new value is the "ordered set serializer for tokens". So it will get rid of extra spaces and duplicates in the attribute value.

Firefox already behaves according to the specification.

No new tests, already covered by existing tests.

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::addInternal):
(WebCore::DOMTokenList::removeInternal):
(WebCore::DOMTokenList::remove): Deleted.

LayoutTests:

Update / Rebaseline several classList /relList tests now that our
behavior has changed.

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:
  • fast/dom/rel-list-expected.txt:
  • fast/dom/rel-list.html:
1:57 PM Changeset in webkit [190077] by achristensen@apple.com
  • 2 edits in trunk

Disable PICTURE_SIZES in Windows CMake build like r189745.
​https://bugs.webkit.org/show_bug.cgi?id=149125

  • Source/cmake/OptionsWin.cmake:

Do the same thing as r189745.

1:49 PM Changeset in webkit [190076] by fpizlo@apple.com
  • 59 edits
    20 adds in trunk

JSC should infer property types
​https://bugs.webkit.org/show_bug.cgi?id=148610

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This change brings recursive type inference to JavaScript object properties in JSC. We check that a
value being stored into a property obeys a property's type before we do the store. If it doesn't,
we broaden the property's type to include the new value. If optimized code was relying on the old
type, we deoptimize that code.

The type system that this supports includes important primitive types like Int32 and Boolean. But
it goes further and also includes a type kind called ObjectWithStructure, which means that we
expect the property to always point to objects with a particular structure. This only works for
leaf structures (i.e. structures that have a valid transition watchpoint set). Invalidation of the
transition set causes the property type to become Object (meaning an object with any structure).
This capability gives us recursive type inference. It's possible for an expression like "o.f.g.h"
to execute without any type checks if .f and .g are both ObjectWithStructure.

The type inference of a property is tracked by an InferredType instance, which is a JSCell. This
means that it manages its own memory. That's convenient. For example, when the DFG is interested in
one of these, it can just list the InferredType as a weak reference in addition to setting a
watchpoint. This ensures that even if the InferredType is dropped by the owning structure, the DFG
won't read a dangling pointer. A mapping from property name to InferredType is implemented by
InferredTypeTable, which is also a JSCell. Each Structure may point to some InferredTypeTable.

This feature causes programs to be happier (run faster without otherwise doing bad things like
using lots of memory) when four conditions hold:

1) A property converges to one of the types that we support.
2) The property is loaded from more frequently than it is stored to.
3) The stores are all cached, so that we statically emit a type check.
4) We don't allocate a lot of meta-data for the property's type.

We maximize the likelihood of (1) by having a rich type system. But having a rich type system means
that a reflective put to a property has to have a large switch over the inferred type to decide how
to do the type check. That's why we need (3). We ensure (3) by having every reflective property
store (i.e. putDirectInternal in any context that isn't PutById) force the inferred type to become
Top. We don't really worry about ensuring (2); this is statistically true for most programs
already.

Probably the most subtle trickery goes into (4). Logically we'd like to say that each
(Structure, Property) maps to its own InferredType. If structure S1 has a transition edge to S2,
then we could ensure that the InferredType I1 where (S1, Property)->I1 has a data flow constraint
to I2 where (S2, Property)->I2. That would work, but it would involve a lot of memory. And when I1
gets invalidated in some way, it would have to tell I2 about it, and then I2 might tell other
InferredType objects downstream. That's madness. So, the first major compromise that we make here
is to say that if some property has some InferredType at some Structure, then anytime we
transition from that Structure, the new Structure shares the same InferredType for that property.
This unifies the type of the property over the entire transition tree starting at the Structure at
which the property was added. But this would still mean that each Structure would have its own
InferredTypeTable. We don't want that because experience with PropertyTable shows that this can be
a major memory hog. So, we don't create an InferredTypeTable until someone adds a property that is
subject to type inference (i.e. it was added non-reflectively), and we share that InferredTypeTable
with the entire structure transition tree rooted at the Structure that had the first inferred
property. We also drop the InferredTypeTable anytime that we do a dictionary transition, and we
don't allow further property type inference if a structure had ever been a dictionary.

This is a 3% speed-up on Octane and a 12% speed-up on Kraken on my setup. It's not a significant
slow-down on any benchmark I ran.

(JSC::MacroAssemblerARM64::branchTest64):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchTest64):
(JSC::MacroAssemblerX86_64::test64):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::generate):

  • bytecode/PutByIdFlags.cpp:

(WTF::printInternal):

  • bytecode/PutByIdFlags.h:

(JSC::encodeStructureID):
(JSC::decodeStructureID):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::operator=):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::setter):
(JSC::PutByIdVariant::attemptToMerge):
(JSC::PutByIdVariant::dumpInContext):

  • bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::newStructure):
(JSC::PutByIdVariant::requiredType):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedInstruction::UnlinkedInstruction):

  • bytecode/Watchpoint.h:

(JSC::InlineWatchpointSet::touch):
(JSC::InlineWatchpointSet::isBeingWatched):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addConstantValue):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):

  • dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::filter):
(JSC::DFG::AbstractInterpreter::filterByValue):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::filter):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::fixTypeForRepresentation):
(JSC::DFG::AbstractValue::mergeOSREntryValue):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::filterValueByType):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::isType):
(JSC::DFG::AbstractValue::validate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::store):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):

  • dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addBaseCheck):

  • dfg/DFGDesiredInferredType.h: Added.

(JSC::DFG::DesiredInferredType::DesiredInferredType):
(JSC::DFG::DesiredInferredType::operator bool):
(JSC::DFG::DesiredInferredType::object):
(JSC::DFG::DesiredInferredType::expected):
(JSC::DFG::DesiredInferredType::isStillValid):
(JSC::DFG::DesiredInferredType::add):
(JSC::DFG::DesiredInferredType::operator==):
(JSC::DFG::DesiredInferredType::operator!=):
(JSC::DFG::DesiredInferredType::isHashTableDeletedValue):
(JSC::DFG::DesiredInferredType::hash):
(JSC::DFG::DesiredInferredType::dumpInContext):
(JSC::DFG::DesiredInferredType::dump):
(JSC::DFG::DesiredInferredTypeHash::hash):
(JSC::DFG::DesiredInferredTypeHash::equal):

  • dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):
(JSC::DFG::InferredTypeAdaptor::add):
(JSC::DFG::DesiredWatchpoints::DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::~DesiredWatchpoints):
(JSC::DFG::DesiredWatchpoints::addLazily):
(JSC::DFG::DesiredWatchpoints::consider):
(JSC::DFG::DesiredWatchpoints::reallyAdd):
(JSC::DFG::DesiredWatchpoints::areStillValid):
(JSC::DFG::DesiredWatchpoints::dumpInContext):

  • dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::AdaptiveStructureWatchpointAdaptor::dumpInContext):
(JSC::DFG::InferredTypeAdaptor::hasBeenInvalidated):
(JSC::DFG::InferredTypeAdaptor::dumpInContext):
(JSC::DFG::DesiredWatchpoints::isWatched):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::isSafeToLoad):
(JSC::DFG::Graph::inferredTypeFor):
(JSC::DFG::Graph::livenessFor):
(JSC::DFG::Graph::tryGetConstantProperty):
(JSC::DFG::Graph::inferredValueForProperty):
(JSC::DFG::Graph::tryGetConstantClosureVar):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::registerInferredType):
(JSC::DFG::Graph::inferredTypeForProperty):

  • dfg/DFGInferredTypeCheck.cpp: Added.

(JSC::DFG::insertInferredTypeCheck):

  • dfg/DFGInferredTypeCheck.h: Added.
  • dfg/DFGNode.h:
  • dfg/DFGObjectAllocationSinkingPhase.cpp:
  • dfg/DFGPropertyTypeKey.h: Added.

(JSC::DFG::PropertyTypeKey::PropertyTypeKey):
(JSC::DFG::PropertyTypeKey::operator bool):
(JSC::DFG::PropertyTypeKey::structure):
(JSC::DFG::PropertyTypeKey::uid):
(JSC::DFG::PropertyTypeKey::operator==):
(JSC::DFG::PropertyTypeKey::operator!=):
(JSC::DFG::PropertyTypeKey::hash):
(JSC::DFG::PropertyTypeKey::isHashTableDeletedValue):
(JSC::DFG::PropertyTypeKey::dumpInContext):
(JSC::DFG::PropertyTypeKey::dump):
(JSC::DFG::PropertyTypeKey::deletedUID):
(JSC::DFG::PropertyTypeKeyHash::hash):
(JSC::DFG::PropertyTypeKeyHash::equal):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileTypeOf):
(JSC::DFG::SpeculativeJIT::compileCheckStructure):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::speculateCell):
(JSC::DFG::SpeculativeJIT::speculateCellOrOther):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStoreBarrierInsertionPhase.cpp:
  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::onlyStructure):
(JSC::DFG::StructureAbstractValue::forEach):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckCell):
(JSC::FTL::DFG::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToLLVM::numberOrNotCellToInt32):
(JSC::FTL::DFG::LowerDFGToLLVM::checkInferredType):
(JSC::FTL::DFG::LowerDFGToLLVM::loadProperty):
(JSC::FTL::DFG::LowerDFGToLLVM::speculate):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateCell):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateCellOrOther):
(JSC::FTL::DFG::LowerDFGToLLVM::speculateMachineInt):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::decodedCodeMapFor):
(JSC::AssemblyHelpers::branchIfNotType):
(JSC::AssemblyHelpers::purifyNaN):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchIfEqual):
(JSC::AssemblyHelpers::branchIfNotCell):
(JSC::AssemblyHelpers::branchIfCell):
(JSC::AssemblyHelpers::branchIfNotOther):
(JSC::AssemblyHelpers::branchIfInt32):
(JSC::AssemblyHelpers::branchIfNotInt32):
(JSC::AssemblyHelpers::branchIfNumber):
(JSC::AssemblyHelpers::branchIfNotNumber):
(JSC::AssemblyHelpers::branchIfEmpty):
(JSC::AssemblyHelpers::branchStructure):

  • jit/Repatch.cpp:

(JSC::tryCachePutByID):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/InferredType.cpp: Added.

(JSC::InferredType::create):
(JSC::InferredType::destroy):
(JSC::InferredType::createStructure):
(JSC::InferredType::visitChildren):
(JSC::InferredType::kindForFlags):
(JSC::InferredType::Descriptor::forValue):
(JSC::InferredType::Descriptor::forFlags):
(JSC::InferredType::Descriptor::putByIdFlags):
(JSC::InferredType::Descriptor::merge):
(JSC::InferredType::Descriptor::removeStructure):
(JSC::InferredType::Descriptor::subsumes):
(JSC::InferredType::Descriptor::dumpInContext):
(JSC::InferredType::Descriptor::dump):
(JSC::InferredType::InferredType):
(JSC::InferredType::~InferredType):
(JSC::InferredType::canWatch):
(JSC::InferredType::addWatchpoint):
(JSC::InferredType::dump):
(JSC::InferredType::willStoreValueSlow):
(JSC::InferredType::makeTopSlow):
(JSC::InferredType::set):
(JSC::InferredType::removeStructure):
(JSC::InferredType::InferredStructureWatchpoint::fireInternal):
(JSC::InferredType::InferredStructureFinalizer::finalizeUnconditionally):
(JSC::InferredType::InferredStructure::InferredStructure):
(WTF::printInternal):

  • runtime/InferredType.h: Added.
  • runtime/InferredTypeTable.cpp: Added.

(JSC::InferredTypeTable::create):
(JSC::InferredTypeTable::destroy):
(JSC::InferredTypeTable::createStructure):
(JSC::InferredTypeTable::visitChildren):
(JSC::InferredTypeTable::get):
(JSC::InferredTypeTable::willStoreValue):
(JSC::InferredTypeTable::makeTop):
(JSC::InferredTypeTable::InferredTypeTable):
(JSC::InferredTypeTable::~InferredTypeTable):

  • runtime/InferredTypeTable.h: Added.
  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::removePropertyTransition):
(JSC::Structure::startWatchingInternalProperties):
(JSC::Structure::willStoreValueSlow):
(JSC::Structure::visitChildren):
(JSC::Structure::prototypeChainMayInterceptStoreTo):

  • runtime/Structure.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

  • runtime/StructureInlines.h:

(JSC::Structure::get):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • tests/stress/prop-type-boolean-then-string.js: Added.
  • tests/stress/prop-type-int32-then-string.js: Added.
  • tests/stress/prop-type-number-then-string.js: Added.
  • tests/stress/prop-type-object-or-other-then-string.js: Added.
  • tests/stress/prop-type-object-then-string.js: Added.
  • tests/stress/prop-type-other-then-string.js: Added.
  • tests/stress/prop-type-string-then-object.js: Added.
  • tests/stress/prop-type-struct-or-other-then-string.js: Added.
  • tests/stress/prop-type-struct-then-object.js: Added.
  • tests/stress/prop-type-struct-then-object-opt.js: Added.
  • tests/stress/prop-type-struct-then-object-opt-fold.js: Added.
  • tests/stress/prop-type-struct-then-object-opt-multi.js: Added.

Source/WTF:

  • wtf/HashTable.h:

(WTF::HashTableAddResult::HashTableAddResult): Make it possible to say "HashMap::AddResult result" without assigning anything to it yet.

  • wtf/PrintStream.h:

(WTF::printInternal): Beef up printing of some common WTF types, in particular RefPtr<UniquedStringImpl>.

1:34 PM Changeset in webkit [190075] by rniwa@webkit.org
  • 2 edits in trunk/Tools

32-bit Mac build fix attempt after r190065.

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1:24 PM Changeset in webkit [190074] by rniwa@webkit.org
  • 2 edits
    6 adds in trunk/LayoutTests

Add some tests for shadow DOM rendering
​https://bugs.webkit.org/show_bug.cgi?id=149330

Reviewed by Antti Koivisto.

Added some ref tests for new shadow DOM API rendering with failing expectations everywhere.

This is a relanding of r189962 excluding css-scoping-shadow-rendering.html since it has since been added in r190006
as css-scoping-shadow-root-hides-children.html by Antti.

  • fast/shadow-dom/css-scoping-shadow-invisible-slot-expected.html: Added.
  • fast/shadow-dom/css-scoping-shadow-invisible-slot.html: Added.
  • fast/shadow-dom/css-scoping-shadow-slot-expected.html: Added.
  • fast/shadow-dom/css-scoping-shadow-slot.html: Added.
  • fast/shadow-dom/css-scoping-shadow-with-rules-expected.html: Added.
  • fast/shadow-dom/css-scoping-shadow-with-rules.html: Added.
  • platform/mac/TestExpectations:
1:10 PM Changeset in webkit [190073] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

WebCore shouldn't have to include DFG headers
​https://bugs.webkit.org/show_bug.cgi?id=149337

Reviewed by Michael Saboff.

This does some simple rewiring and outlining of CodeBlock/Heap functionality so that
those headers don't have to include DFG headers. As a result, WebCore no longer includes
DFG headers, except for two fairly innocent ones (DFGCommon.h and DFGCompilationMode.h).
This also changes the Xcode project file so that all but those two headers are Project
rather than Private. So, if WebCore accidentally includes any of them, we'll get a build
error.

The main group of headers that this prevents WebCore from including are the DFGDesired*.h
files and whatever those include. Those headers used to be fairly simple, but now they
are growing in complexity (especially with things like ​http://webkit.org/b/148610). So,
it makes sense to make sure they don't leak out of JSC.

(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::~CallLinkInfo):
(JSC::CallLinkInfo::clearStub):
(JSC::CallLinkInfo::visitWeak):
(JSC::CallLinkInfo::setFrameShuffleData):

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::isVarargsCallType):
(JSC::CallLinkInfo::specializationKindFor):
(JSC::CallLinkInfo::frameShuffleData):
(JSC::CallLinkInfo::CallLinkInfo): Deleted.
(JSC::CallLinkInfo::~CallLinkInfo): Deleted.
(JSC::CallLinkInfo::setFrameShuffleData): Deleted.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::getOrAddArrayProfile):
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::numberOfDFGIdentifiers):
(JSC::CodeBlock::identifier):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::hasExpressionInfo):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::numberOfIdentifiers):
(JSC::CodeBlock::identifier):
(JSC::CodeBlock::codeOrigins): Deleted.
(JSC::CodeBlock::numberOfDFGIdentifiers): Deleted.

  • bytecode/CodeOrigin.h:
  • dfg/DFGDesiredIdentifiers.cpp:
  • heap/Heap.cpp:

(JSC::Heap::didFinishIterating):
(JSC::Heap::completeAllDFGPlans):
(JSC::Heap::markRoots):
(JSC::Heap::deleteAllCodeBlocks):

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::deprecatedReportExtraMemory):
(JSC::Heap::forEachCodeBlock):
(JSC::Heap::forEachProtectedCell):

  • runtime/Executable.h:
  • runtime/JSCInlines.h:

(JSC::Heap::forEachCodeBlock): Deleted.

1:09 PM Changeset in webkit [190072] by eric.carlson@apple.com
  • 25 edits in trunk/Source/WebCore

[MediaStream] Clean up MediaStream private interfaces
​https://bugs.webkit.org/show_bug.cgi?id=149381

Reviewed by Jer Noble.

No new tests, no functional change.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::clone):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::getAudioTracks):
(WebCore::MediaStream::getVideoTracks):
(WebCore::MediaStream::getTracks):
(WebCore::MediaStream::activeStatusChanged):
(WebCore::MediaStream::didAddTrack):
(WebCore::MediaStream::didRemoveTrack):
(WebCore::MediaStream::registry):
(WebCore::MediaStream::trackVectorForType):
(WebCore::MediaStream::didAddTrackToPrivate): Deleted.
(WebCore::MediaStream::didRemoveTrackFromPrivate): Deleted.

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::lookup):
(WebCore::MediaStreamRegistry::MediaStreamRegistry):

  • Modules/mediastream/MediaStreamRegistry.h:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind):
(WebCore::MediaStreamTrack::removeObserver):
(WebCore::MediaStreamTrack::trackEnded):
(WebCore::MediaStreamTrack::trackMutedChanged):
(WebCore::MediaStreamTrack::trackStatesChanged):
(WebCore::MediaStreamTrack::configureTrackRendering):

  • Modules/mediastream/MediaStreamTrack.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::supportsType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load):

  • platform/graphics/avfoundation/objc/MediaStreamPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaStreamPrivateAVFObjC.mm:

(WebCore::MediaStreamPrivateAVFObjC::create):
(WebCore::MediaStreamPrivateAVFObjC::MediaStreamPrivateAVFObjC):

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::~MediaStreamPrivate):
(WebCore::MediaStreamPrivate::tracks):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):

  • platform/mediastream/MediaStreamPrivate.h:

(WebCore::MediaStreamPrivateClient::~MediaStreamPrivateClient):
(WebCore::MediaStreamPrivate::id):
(WebCore::MediaStreamPrivate::active):
(WebCore::MediaStreamPrivate::MediaStreamPrivate): Deleted.
(WebCore::MediaStreamPrivate::~MediaStreamPrivate): Deleted.

  • platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::~MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::addObserver):
(WebCore::MediaStreamTrackPrivate::removeObserver):
(WebCore::MediaStreamTrackPrivate::label):
(WebCore::MediaStreamTrackPrivate::endTrack):
(WebCore::MediaStreamTrackPrivate::sourceStopped):
(WebCore::MediaStreamTrackPrivate::sourceMutedChanged):
(WebCore::MediaStreamTrackPrivate::sourceStatesChanged):
(WebCore::MediaStreamTrackPrivate::preventSourceFromStopping):

  • platform/mediastream/MediaStreamTrackPrivate.h:

(WebCore::MediaStreamTrackPrivate::Observer::~Observer):
(WebCore::MediaStreamTrackPrivate::ended):
(WebCore::MediaStreamTrackPrivate::startProducingData):
(WebCore::MediaStreamTrackPrivate::stopProducingData):
(WebCore::MediaStreamTrackPrivate::setMuted):
(WebCore::MediaStreamTrackPrivateClient::~MediaStreamTrackPrivateClient): Deleted.
(WebCore::MediaStreamTrackPrivate::setClient): Deleted.
(WebCore::MediaStreamTrackPrivate::client): Deleted.

  • platform/mediastream/MediaStreamTrackSourcesRequestClient.h:

(WebCore::TrackSourceInfo::create):
(WebCore::TrackSourceInfo::id):
(WebCore::TrackSourceInfo::label):
(WebCore::TrackSourceInfo::groupId):
(WebCore::TrackSourceInfo::kind):
(WebCore::TrackSourceInfo::TrackSourceInfo):
(WebCore::TrackSourceInfo::deviceId): Deleted.

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::RealtimeMediaSource):
(WebCore::RealtimeMediaSource::reset):
(WebCore::RealtimeMediaSource::setMuted):
(WebCore::RealtimeMediaSource::statesDidChanged):
(WebCore::RealtimeMediaSource::readonly):

  • platform/mediastream/RealtimeMediaSource.h:

(WebCore::RealtimeMediaSource::id):
(WebCore::RealtimeMediaSource::persistentId):
(WebCore::RealtimeMediaSource::setPersistentId):
(WebCore::RealtimeMediaSource::type):
(WebCore::RealtimeMediaSource::stopped):

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::getSourcesInfo):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::~RealtimeMediaSourceCenterMac):
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):
(WebCore::RealtimeMediaSourceCenterMac::getMediaStreamTrackSources):

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::~RealtimeMediaSourceCenterOwr):
(WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints):

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::registerMockRealtimeMediaSourceCenter):
(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):
(WebCore::MockRealtimeMediaSourceCenter::getMediaStreamTrackSources):

  • platform/mock/MockRealtimeMediaSourceCenter.h:
1:05 PM Changeset in webkit [190071] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Add image-only failure expectation to fast/shadow-dom/css-scoping-shadow-root-hides-children.html on non-Mac ports.

12:43 PM Changeset in webkit [190070] by ap@apple.com
  • 5 edits in trunk/Tools

[OS X] Update for Xcode 7.0 on Yosemite
​https://bugs.webkit.org/show_bug.cgi?id=149389

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
  • WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:

Removed unneeded declarations - conforming to a protocol is sufficient.

  • DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
  • WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:

Changed the definitions to be compiled whenever the SDK requires it (so we will have
dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).

12:38 PM Changeset in webkit [190069] by achristensen@apple.com
  • 2 edits in trunk/LayoutTests

Skip tests on Windows after r189947.

  • platform/win/TestExpectations:

webkit-font-smoothing doesn't work on Windows.

12:15 PM Changeset in webkit [190068] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the !ENABLE(TEMPLATE_ELEMENT) build after r189945
​https://bugs.webkit.org/show_bug.cgi?id=149400

Reviewed by Darin Adler.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

12:15 PM Changeset in webkit [190067] by Chris Dumez
  • 6 edits
    7 adds in trunk

Range.cloneContents() / extractContents should throw a HierarchyRequestError when encountering a doctype
​https://bugs.webkit.org/show_bug.cgi?id=148770
<rdar://problem/22570898>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that more checks are passing.

  • web-platform-tests/dom/ranges/Range-cloneContents-expected.txt:

Source/WebCore:

Range.cloneContents() and Range.extractContents() should throw a
HierarchyRequestError when encountering a doctype:

However, Range.deleteContents() should not:

WebKit was not throwing in the Range.cloneContents() case. This
aligns updates our behavior to match the specification and
Firefox.

Tests: fast/dom/Range/clone-contents-document-type.html

fast/dom/Range/delete-contents-document-type.html
fast/dom/Range/extract-contents-document-type.html

  • dom/Range.cpp:

(WebCore::Range::processContentsBetweenOffsets):

LayoutTests:

Add new tests to cover the behaviour of Range's cloneContents() / extractContents()
and deleteContents() when encountering a doctype.

  • fast/dom/Range/clone-contents-document-type-expected.txt: Added.
  • fast/dom/Range/clone-contents-document-type.html: Added.
  • fast/dom/Range/delete-contents-document-type-expected.txt: Added.
  • fast/dom/Range/delete-contents-document-type.html: Added.
  • fast/dom/Range/extract-contents-document-type-expected.txt: Added.
  • fast/dom/Range/extract-contents-document-type.html: Added.
  • fast/dom/Range/resources/frame-with-doctype.html: Added.
12:11 PM Changeset in webkit [190066] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: arrow function names are never inferred, call frames are labeled (anonymous function)
​https://bugs.webkit.org/show_bug.cgi?id=148318

Patch by Aleksandr Skachkov <​gskachkov@gmail.com> on 2015-09-21
Reviewed by Saam Barati.

Tiny change to support of the inferred name in arrow function

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createAssignResolve):

12:10 PM Changeset in webkit [190065] by Simon Fraser
  • 26 edits
    6 copies
    13 adds in trunk

Add the ability for tests to run script in the UI process in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=149356

Reviewed by Tim Horton.

Source/WebKit2:

Expose a few private functions for testing.

  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

This change adds testRunner.runUIScript(script, callback), which allows a test
to execute script in a JSContext which runs in the UI process. That context
has bindings exposed through the UIScriptController interface; currently one test
function, and some iOS-specific functions are included. UIScriptController can be
async with a callback, and runUIScript() itself is asynchronous. When the UI
script is complete, it calls uiController.uiScriptComplete(result), where 'result'
is a string passed back to the web process, and given to the runUIScript()
callback function.

Thanks to Gyuyoung Kim for help with the Gtk/Efl build.

  • WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
complete, call back into TestRunner.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::nextUIScriptCallbackID):
(WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
(WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
(WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::shouldUseFixedLayout):
(WTR::TestInvocation::shouldUseThreadedScrolling):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::runUISideScript): Run the UI-side script!
(WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.

  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/TestOptions.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.

(-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
(-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.

(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::zoomToScale):
(WTR::UIScriptController::zoomScale):
(WTR::UIScriptController::minimumZoomScale):
(WTR::UIScriptController::maximumZoomScale):
(WTR::UIScriptController::contentVisibleRect):

  • WebKitTestRunner/mac/EventSenderProxy.mm:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
(WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.

  • WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
  • WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.

(UIScriptContext::UIScriptContext):
(UIScriptContext::~UIScriptContext):
(UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
asynchronous, call the callback.
(UIScriptContext::nextTaskCallbackID):
(UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
that has a callback). Has to store the callbackID of the script, so code called from the completion
callback knows which UI script invoked it.
(UIScriptContext::asyncTaskComplete): Called when one task is finished.
(UIScriptContext::uiScriptComplete):
(UIScriptContext::objectFromRect): Make a JS object from a rect.

  • WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.

(WTR::UIScriptContext::hasOutstandingAsyncTasks):

  • WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.

(WTR::UIScriptController::UIScriptController):
(WTR::UIScriptController::makeWindowObject):
(WTR::UIScriptController::wrapperClass):
(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::zoomToScale):
(WTR::UIScriptController::zoomScale):
(WTR::UIScriptController::minimumZoomScale):
(WTR::UIScriptController::maximumZoomScale):
(WTR::UIScriptController::contentVisibleRect):
(WTR::UIScriptController::uiScriptComplete):

  • WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.

(WTR::UIScriptController::create):

  • WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.

LayoutTests:

Some new tests that exercise testRunner.runUIScript().

  • TestExpectations:
  • fast/harness/concurrent-ui-side-scripts-expected.txt: Added.
  • fast/harness/concurrent-ui-side-scripts.html: Added.
  • fast/harness/ui-side-scripts-expected.txt: Added.
  • fast/harness/ui-side-scripts.html: Added.
  • fast/zooming/zoom-to-scale.html: Added.
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
12:03 PM Changeset in webkit [190064] by timothy_horton@apple.com
  • 19 edits in trunk/Source/WebKit2

Layout milestones aren't synchronized with UI-side compositing transactions
​https://bugs.webkit.org/show_bug.cgi?id=149362

Reviewed by Anders Carlsson.

Because layout milestones are primarily used to synchronize things with
the displayed layout/rendering of the page, they should fire at the same
time as the contents of the view change.

However, with UI-side compositing, the layer tree transaction will
most likely come in *after* the layout milestones associated with its
contents fire, breaking this synchronization.

Instead, put the layout milestones inside the transaction and fire them
immediately after it is committed in the UI process.

  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::setCallbackIDs):
(WebKit::RemoteLayerTreeTransaction::newlyReachedLayoutMilestones):
(WebKit::RemoteLayerTreeTransaction::setNewlyReachedLayoutMilestones):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::RemoteLayerTreeTransaction):
(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
Add LayoutMilestones to the transaction.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didLayout):

  • UIProcess/API/APINavigationClient.h:

(API::NavigationClient::renderingProgressDidChange):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):
(WKPageSetPageNavigationClient):

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::renderingProgressDidChange):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree):
Remove the UserData parameter from didLayout/renderingProgressDidChange,
except for at the API level where we'll always pass null.
Nobody uses UserData on didLayout, and we'll assert if any client sets it
(and it won't get passed through to the UI process).

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didLayoutForCustomContentProvider):
Just call didLayout with the relevant milestones instead of reimplementing it.

(WebKit::WebPageProxy::didLayout):

  • UIProcess/WebPageProxy.h:

Make didLayout public.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLayout):
Let WebPage handle dispatching didLayout.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::dispatchDidLayout):

  • WebProcess/WebPage/WebPage.h:

Let the DrawingArea handle dispatching didLayout.
If it doesn't want to handle it, we'll just do the normal thing
and dispatch an async message.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
If we reach a new layout milestone, dispatch didLayout client/delegate callbacks.

  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::dispatchDidLayout):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):
(WebKit::RemoteLayerTreeDrawingArea::dispatchDidLayout):
Queue up milestones as we reach them, and send them in the transaction.

11:59 AM Changeset in webkit [190063] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

New tests introduced in r188545 fail on 32 bit ARM
​https://bugs.webkit.org/show_bug.cgi?id=148376

Patch by Aleksandr Skachkov <​gskachkov@gmail.com> on 2015-09-19
Reviewed by Saam Barati.

Added correct support of the ARM CPU in JIT functions that are related to arrow function.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunction):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitNewFuncExprCommon):

11:47 AM Changeset in webkit [190062] by Sukolsak Sakshuwong
  • 7 edits in trunk/Source/JavaScriptCore

Implement Store expressions in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149395

Reviewed by Geoffrey Garen.

The Store instruction in WebAssembly stores a value in the linear memory
at the given index. It can be both a statement and an expression. When
it is an expression, it returns the assigned value. This patch
implements Store as an expression.

Since Store uses two operands, which are the index and the value, we
need to pop the two operands from the stack and push the value back to
the stack. We can simply implement this by copying the value to where
the index is in the stack.

  • tests/stress/wasm-linear-memory.js:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildStore):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseStatement):
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseStore):

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildStore):

11:03 AM Changeset in webkit [190061] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebCore

UserMediaClientMock leaks every test run
​https://bugs.webkit.org/show_bug.cgi?id=149358

Reviewed by Eric Carlson.

  • Modules/mediastream/UserMediaController.cpp:

(WebCore::provideUserMediaTo):
Make provideUserMediaTo operate unconditionally, just like all of the
other similar functions, reverting r165733.

  • Modules/mediastream/UserMediaController.h:
  • testing/Internals.cpp:

(WebCore::Internals::Internals):
Remove the existing UserMediaController supplement before installing a new one.
This way, we're replacing it with the one Internals is trying to install,
instead of leaking UserMediaClientMocks.

11:00 AM Changeset in webkit [190060] by timothy_horton@apple.com
  • 36 edits in trunk

Turn on threaded scrolling by default in the tests
​https://bugs.webkit.org/show_bug.cgi?id=149377

Reviewed by Simon Fraser.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
(WTR::shouldUseThreadedScrolling): Deleted.
Turn on threaded scrolling by default.

  • compositing/geometry/fixed-position-flipped-writing-mode.html:
  • compositing/layer-creation/no-compositing-for-sticky.html:
  • compositing/overflow/automatically-opt-into-composited-scrolling.html:
  • compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/composited-scrolling-creates-a-stacking-container.html:
  • compositing/overflow/composited-scrolling-paint-phases.html:
  • compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html:
  • compositing/overflow/dynamic-composited-scrolling-status.html:
  • compositing/overflow/iframe-inside-overflow-clipping.html:
  • compositing/overflow/nested-scrolling.html:
  • compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/scrolling-without-painting.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/overflow/updating-scrolling-content.html:
  • compositing/rtl/rtl-fixed-overflow-scrolled.html:
  • compositing/rtl/rtl-overflow-scrolling.html:
  • fast/block/positioning/rtl-fixed-positioning.html:
  • fast/block/positioning/vertical-rl/fixed-positioning.html:
  • fast/dom/horizontal-scrollbar-in-rtl.html:
  • fast/dom/horizontal-scrollbar-when-dir-change.html:
  • fast/dom/scroll-reveal-left-overflow.html:
  • fast/dom/scroll-reveal-top-overflow.html:
  • fast/dom/vertical-scrollbar-when-dir-change.html:
  • fast/multicol/pagination/RightToLeft-rl-hittest.html:
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html:
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:
  • swipe/main-frame-pinning-requirement.html:

Turn off threaded scrolling in the cases where it sensibly affects the test result.
These cases are:

  • tests that use scrollTo or similar, and then depend on the scrolling happening synchronously
  • tests that use setAcceleratedCompositingForOverflowScrollEnabled, which asserts if combined with threaded scrolling
  • fast/text/combining-character-sequence-vertical.html:
  • fast/text/descent-clip-in-scaled-page.html:
  • fast/text/descent-clip-in-scaled-page-expected.html:
  • fast/text/vertical-quotation-marks.html:

Turn off threaded scrolling in three tests where it shouldn't affect the test result,
but for some reason does.

10:00 AM Changeset in webkit [190059] by achristensen@apple.com
  • 5 edits in trunk/Source/WebCore

Generate WebCoreHeaderDetection.h with CMake on Windows
​https://bugs.webkit.org/show_bug.cgi?id=135861

Reviewed by Brent Fulgham.

This fixes many of the failing media tests.

  • AVFoundationSupport.py:

(lookFor):
(fileContains):
Use a command line parameter for the WebKitLibraries directory
to not require the WEBKIT_LIBRARIES environment variable with the CMake build.

  • DerivedSources.make:

Pass WEBKIT_LIBRARIES as a command line parameter.

  • PlatformAppleWin.cmake:

Added missing sources for video.

  • PlatformWin.cmake:

Generate WebCoreHeaderDetection.h correctly and copy the media controls sources to WebKit.resources.

9:30 AM Changeset in webkit [190058] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: requestAnimationFrame continues to be called after stopping the timeline recording
​https://bugs.webkit.org/show_bug.cgi?id=149390

Reviewed by Brian Burg.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._update):
Stop calling requestAnimationFrame if this._updating is false and recording end time is NaN.

2:38 AM Changeset in webkit [190057] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.10.0

WebKitGTK+ 2.10.0

2:37 AM Changeset in webkit [190056] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.10

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.0 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.10.0
2:14 AM Changeset in webkit [190055] by Sukolsak Sakshuwong
  • 2 edits in trunk/Source/JavaScriptCore/wasm

Build fix for WebAssembly.

  • wasm/JSWASMModule.cpp:
  • wasm/WASMFunctionParser.cpp:
1:53 AM Changeset in webkit [190054] by ChangSeok Oh
  • 3 edits
    2 adds in trunk

[GTK] media controls does not show up when playing video finishes.
​https://bugs.webkit.org/show_bug.cgi?id=149112

Reviewed by Philippe Normand.

Source/WebCore:

GTK port does not show controls after playing video. This behavior is different
from what Mac port does. They do show controls when playing video finishes.
At least, we should update the timeline before showing it up not to show incorrect numbers
when reappearing.

Test: media/media-controls-timeline-updates-after-playing.html

  • Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.setPlaying):
(Controller.prototype.showControls):

LayoutTests:

  • media/media-controls-timeline-updates-after-playing-expected.txt: Added.
  • media/media-controls-timeline-updates-after-playing.html: Added.
1:37 AM Changeset in webkit [190053] by ChangSeok Oh
  • 3 edits
    2 adds in trunk

[GTK] timeline is not updated after few seconds when mouse hovers on controls
​https://bugs.webkit.org/show_bug.cgi?id=149111

Reviewed by Philippe Normand.

Source/WebCore:

Timeline is not updated if controlsAreHidden is true. The problem here is that
the function does not mean actually 'hidden' since it only checkes 'show' and 'hidden'
class existences. The panel's visibility are not only controlled by the two classes,
but also by video::-webkit-media-controls-panel:hover. The panel could be visible
by setting the pseudo hover class. So we need to check if panel is hovered as well in controlsAreHidden().

Test: media/media-controls-timeline-updates-when-hovered.html

  • Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.controlsAreHidden):

LayoutTests:

  • media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
  • media/media-controls-timeline-updates-when-hovered.html: Added.
1:36 AM Changeset in webkit [190052] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190007 - REGRESSION(r150187): updateIdForTreeScope may not be called inside shadow trees
​https://bugs.webkit.org/show_bug.cgi?id=149364

Reviewed by Antti Koivisto.

Since the tree scope is set to that of Document's inside removeBetween when a node is removed from a shadow tree,
oldScope != &treeScope() was already true inside Element::removedFrom. This can introduce an inconsistency in
DocumentOrderedMap which could result in a crash. Fixed the bug by checking it against document(), which is the
behavior we had prior to r150187.

Also added a consistency check in DocumentOrderedMap to catch bugs like this.

No new tests. New assertions fail in existing tests without this fix.

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get):

  • dom/DocumentOrderedMap.h:
  • dom/Element.cpp:

(WebCore::Element::removedFrom):

1:36 AM Changeset in webkit [190051] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r190019 - [GTK] WebEditorClient::supportsGlobalSelection returns true under Wayland
​https://bugs.webkit.org/show_bug.cgi?id=149375

Reviewed by Darin Adler.

WebEditorClient::supportsGlobalSelection should return false when running under Wayland,
since Wayland does not have any equivalent for PRIMARY or the concept of a global selection.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::supportsGlobalSelection):

1:15 AM Changeset in webkit [190050] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r189954 - Multi-hop reference cycles not detected.
​https://bugs.webkit.org/show_bug.cgi?id=149181

Reviewed by John Honeycutt.

Source/WebCore:

SVG's cycle detection was not picking up a
case where an element was drawing a pattern, that
referenced another pattern, that referenced another
pattern, that referenced the original pattern.

The issue was that we were forgetting to check the
children of the renderer itself, rather than just
the children of the referenced renderers.

Found by running a test from Blink.

I also took the opportunity to clean up the debugging
code that logs cycle detection.

Test: svg/custom/pattern-3-step-cycle.html

  • platform/Logging.h: Add a new SVG channel. I can't believe we

didn't already have one!

  • rendering/svg/SVGResourcesCycleSolver.cpp:

(WebCore::SVGResourcesCycleSolver::resourceContainsCycles): Check the referenced
resources for cycles.
(WebCore::SVGResourcesCycleSolver::resolveCycles): Logging update.

LayoutTests:

Test comes from:
​https://chromium.googlesource.com/chromium/blink/+/master/LayoutTests/svg/custom/pattern-3-step-cycle.html

  • svg/custom/pattern-3-step-cycle-expected.txt: Added.
  • svg/custom/pattern-3-step-cycle.html: Added.
1:12 AM Changeset in webkit [190049] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Cyclic resources were not detected if the reference had deep containers
​https://bugs.webkit.org/show_bug.cgi?id=149182

Reviewed by John Honeycutt.

Source/WebCore:

During our examination of the SVG rendering tree looking for cycles,
if a resource pointed to something that had a nested structure, and
one of the parent nodes in that structure was a container object
without resources itself, we were not looking into the children.

Test: svg/custom/pattern-content-cycle-w-resourceless-container.html

  • rendering/svg/SVGResourcesCycleSolver.cpp:

(WebCore::SVGResourcesCycleSolver::resourceContainsCycles): We should still
check all children resources, but not exit early if there are none. Instead
we should recurse into any children.
(WebCore::SVGResourcesCycleSolver::resolveCycles): Changes to some debug
code that no longer compiled (it's still off by default, but at least
it will work now).

LayoutTests:

This test was ported from Blink. I believe it originally
came from:
​https://code.google.com/p/chromium/issues/detail?id=351713

  • svg/custom/pattern-content-cycle-w-resourceless-container-expected.txt: Added.
  • svg/custom/pattern-content-cycle-w-resourceless-container.html: Added.
1:10 AM Changeset in webkit [190048] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190045 - [GTK] REGRESSION(188031): ASSERTION FAILED: menu
​https://bugs.webkit.org/show_bug.cgi?id=149379

Reviewed by Carlos Garcia Campos.

Remove assert that no longer makes sense.

  • platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::setPlatformDescription): Deleted.

1:02 AM Changeset in webkit [190047] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10

Merge r188973 - [GTK] Disable ACCELERATED_2D_CANVAS by default
​https://bugs.webkit.org/show_bug.cgi?id=148473

Reviewed by Martin Robinson.

Currently ACCELERATED_2D_CANVAS is enabled by default on most systems (which have CairoGL)
but not on Debian (which does not). We've known this was problematic for a while, since it
means we have two different sets of distro-dependent bugs, but never decided whether that
outweighed the benefits of CarioGL or not. I'm making the call now: it's more important to
have the same bugs everywhere. We can turn this on again for other distros when we're ready
to turn it on for Debian.

Also, properly fail the build if ENABLE_ACCELERATED_2D_CANVAS is enabled but CairoGL is not
available.

  • Source/cmake/OptionsGTK.cmake:
12:28 AM Changeset in webkit [190046] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests doesn't provide feedback about crashing google tests
​https://bugs.webkit.org/show_bug.cgi?id=149252

Reviewed by Darin Adler.

In case of glib tests the test runner notifies about tests
crashing, but for google tests we don't get any feedback, which
means that in case of a test crashing we get a list of PASS
messages and at the summary we are notified that the test suite
has failed, but it's impossible to know which test cases have failed.

  • Scripts/run-gtk-tests:

(TestRunner._run_google_test): Add a CRASH message if test
case crashed.

12:22 AM Changeset in webkit [190045] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

[GTK] REGRESSION(188031): ASSERTION FAILED: menu
​https://bugs.webkit.org/show_bug.cgi?id=149379

Reviewed by Carlos Garcia Campos.

Remove assert that no longer makes sense.

  • platform/gtk/ContextMenuGtk.cpp:

(WebCore::ContextMenu::setPlatformDescription): Deleted.

12:12 AM Changeset in webkit [190044] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebKit2

Roll out r189944. rdar://problem/22763066

Sep 20, 2015:

10:06 PM Changeset in webkit [190043] by Sukolsak Sakshuwong
  • 10 edits in trunk/Source/JavaScriptCore

Implement SetLocal and SetGlobal expressions in WebAssembly
​https://bugs.webkit.org/show_bug.cgi?id=149383

Reviewed by Saam Barati.

SetLocal and SetGlobal in WebAssembly can be both statements and
expressions. We have implemented the statement version. This patch
implements the expression version.

SetLocal and SetGlobal expressions return the assigned value.
Since SetLocal and SetGlobal use only one operand, which is the assigned
value, we can simply implement them by not removing the value from the
top of the stack.

  • tests/stress/wasm-globals.js:
  • tests/stress/wasm-locals.js:
  • tests/stress/wasm/globals.wasm:
  • tests/stress/wasm/locals.wasm:
  • wasm/WASMConstants.h:
  • wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::buildSetLocal):
(JSC::WASMFunctionCompiler::buildSetGlobal):

  • wasm/WASMFunctionParser.cpp:

(JSC::WASMFunctionParser::parseStatement):
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseExpressionF32):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseSetLocal):
(JSC::WASMFunctionParser::parseSetGlobal):
(JSC::WASMFunctionParser::parseSetLocalStatement): Deleted.
(JSC::WASMFunctionParser::parseSetGlobalStatement): Deleted.

  • wasm/WASMFunctionParser.h:
  • wasm/WASMFunctionSyntaxChecker.h:

(JSC::WASMFunctionSyntaxChecker::buildSetLocal):
(JSC::WASMFunctionSyntaxChecker::buildSetGlobal):

9:36 PM Changeset in webkit [190042] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/JavaScriptCore

[ES6] Added controlFlowProfiler test for arrow function
​https://bugs.webkit.org/show_bug.cgi?id=145638

Patch by Aleksandr Skachkov <​gskachkov@gmail.com> on 2015-09-19
Reviewed by Saam Barati.

  • Source/JavaScriptCore/tests/controlFlowProfiler/arrowfunction-expression.js: added
9:26 PM Changeset in webkit [190041] by aestes@apple.com
  • 3 edits
    3 adds in trunk/LayoutTests

http/tests/contentfiltering/load-substitute-data-from-appcache.html crashes sometimes
​https://bugs.webkit.org/show_bug.cgi?id=148890

Reviewed by Alexey Proskuryakov.

Added a test to verify my theory that load-substitute-data-from-appcache.html will crash even with Content Filtering disabled.

  • TestExpectations: Skipped the new test since it only works in WebKit2.
  • http/tests/appcache/decide-navigation-policy-after-delay-expected.txt: Added.
  • http/tests/appcache/decide-navigation-policy-after-delay.html: Added.
  • http/tests/appcache/resources/decide-navigation-policy-after-delay-frame.html: Added.
  • platform/wk2/TestExpectations: Enabled the test in WebKit2.
8:39 PM Changeset in webkit [190040] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix GTK build after r190030.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_link_element_set_sizes):

8:33 PM Changeset in webkit [190039] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Unreviewed, another GTK build fix after r190017.

  • bindings/scripts/CodeGeneratorGObject.pm:

(IsPropertyWriteable):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_set_property): Deleted.

8:24 PM Changeset in webkit [190038] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Unreviewed attempt to fix the GTK build after r190017.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

8:01 PM Changeset in webkit [190037] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline W3C HTML DOM test on iOS after r190030.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
7:42 PM Changeset in webkit [190036] by Chris Dumez
  • 72 edits in trunk/Source/WebCore

Pass JSC::ExecState to the custom bindings by reference
​https://bugs.webkit.org/show_bug.cgi?id=149393

Reviewed by Sam Weinig.

Pass JSC::ExecState to the custom bindings by reference instead of by
pointer as it is expected to be non-null.

5:28 PM Changeset in webkit [190035] by ap@apple.com
  • 3 edits in trunk/Tools

WebKitTestRunner can leak user content script results between tests
​https://bugs.webkit.org/show_bug.cgi?id=149391

Reviewed by Sam Weinig.

Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
about:blank, and thus about:blank doesn't have unintended side effects.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::resetAfterTest):

4:24 PM Changeset in webkit [190034] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Regression(r190023): fast/dom/navigation-with-sideeffects-crash.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=149392

Reviewed by Alexey Proskuryakov.

In the generated code for [PutForwards=xxx], make sure the forwarded
implementation object is ref'd before calling toString() as toString()
can be overridden by JS and cause the object to get deref'd / destroyed.

No new tests, already covered by existing test.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjPutForwardsAttribute):
(WebCore::setJSTestObjPutForwardsNullableAttribute):

12:52 PM Changeset in webkit [190033] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Fix a relative path in accessibility/mac/removing-textarea-after-edit-crash.html
after moving the test.
​https://bugs.webkit.org/show_bug.cgi?id=149217

Patch by Chris Fleizach <Chris Fleizach> on 2015-09-20
Reviewed by Alexey Proskuryakov.

  • accessibility/mac/removing-textarea-after-edit-crash.html:
12:20 PM Changeset in webkit [190032] by Sukolsak Sakshuwong
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, updated my email address.

  • Scripts/webkitpy/common/config/contributors.json:
9:44 AM Changeset in webkit [190031] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46-branch

Merged r189997. rdar://problem/22772263

9:43 AM Changeset in webkit [190030] by Chris Dumez
  • 29 edits
    1 delete in trunk

Get rid of custom bindings for HTMLLinkElement.sizes setter
​https://bugs.webkit.org/show_bug.cgi?id=149382

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/html/dom/interfaces-expected.txt:

Rebaseline test. Our bindings generator does not move attributes that have
a custom setter from the instance to the prototype. Now that the 'sizes'
attribute no longer has a custom setter, it has moved to the prototype,
where it is expected to be.

Source/WebCore:

Get rid of custom bindings for HTMLLinkElement.sizes setter by leveraging
the new [PutForwards=xxx] Web IDL extended attribute, as per the HTML
specification:

Also add FIXME comments in our IDL for various attributes that should be
using [PutForwards=xxx] according to the HTML specification but are not
currently. Those were not updated in this patch because it will subtly
change their web-exposed behavior.

No new tests, no intended web-exposed behavior change. However, one side
effect of the change is that the attribtue has moved to the prototype.
Our bindings generator was keeping this attribute on the instance because
it has a custom setter.
Bindings tests coverage was extended.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLLinkElementCustom.cpp: Removed.

Drop custom bindings for HTMLLinkElement.sizes setter.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • Stop passing an extra isNull argument to getters of nullable attributes that have a wrapper type. These can return a null pointer so there is no need for an extra argument.
  • When [PutForwards=xxx] is used, only do the null-check on the attribute getter if the attribute is marked as nullable. If the attribute is not marked as nullable, the implementation is expected to return a C++ reference, otherwise a raw pointer. This was needed because HTMLLinkElement::sizes() returns a reference as it can never return null.
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl:

Add bindings tests coverage for using [PutForwards=xxx] on a
nullable attribute.

  • dom/Document.idl:

Mark Document.location as nullable as per the specification. The
implementation returns a raw pointer and can return null. The
bindings generator expects a raw pointer and will do a null check
on it.

  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLTableCellElement.idl:

Add FIXME comments for attributes that are supposed to use
[PutForwards=xxx] as per the HTML specification but currently don't.

  • html/HTMLLinkElement.idl:

Use [PutForwards=value] for the 'sizes' attribute, as per the
specification and stop using a custom setter.

9:41 AM Changeset in webkit [190029] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r189944. rdar://problem/22763066

9:41 AM Changeset in webkit [190028] by Chris Dumez
  • 52 edits in trunk/Source/WebCore

[CallWith=ScriptState] should pass ExecState to the implementation by reference
​https://bugs.webkit.org/show_bug.cgi?id=149378

Reviewed by Sam Weinig.

[CallWith=ScriptState] should pass ExecState to the implementation by
reference instead of pointer, as it is expected to be non-null.

Also rename the ExecState variables from 'exec' to 'state' in the
bindings as this is the preferred naming convention.

  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/legacy/LegacyCursor.cpp:

(WebCore::LegacyCursor::update):

  • Modules/indexeddb/legacy/LegacyCursor.h:
  • Modules/indexeddb/legacy/LegacyObjectStore.cpp:

(WebCore::LegacyObjectStore::add):
(WebCore::LegacyObjectStore::put):

  • Modules/indexeddb/legacy/LegacyObjectStore.h:
  • Modules/mediastream/CapabilityRange.cpp:

(WebCore::scriptValue):
(WebCore::CapabilityRange::min):
(WebCore::CapabilityRange::max):

  • Modules/mediastream/CapabilityRange.h:
  • Modules/streams/ReadableStreamController.h:

(WebCore::ReadableStreamController::error):
(WebCore::ReadableStreamController::enqueue):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateEventListenerCall):
(GenerateGetOwnPropertySlotBody):
(GenerateHeader):
(GenerateOverloadedFunction):
(GetIndexedGetterExpression):
(GenerateImplementation):
(GenerateFunctionCastedThis):
(GenerateCallWith):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateReturnParameters):
(GenerateCallbackHeader):
(GenerateCallbackImplementation):
(GenerateImplementationFunctionCall):
(JSValueToNative):
(NativeToJSValue):
(GenerateOverloadedConstructorDefinition):
(GenerateConstructorDefinition):

9:37 AM Changeset in webkit [190027] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

8:30 AM Changeset in webkit [190026] by ap@apple.com
  • 5 edits in trunk

[Mac, iOS] AccessibilityController doesn't uninstall global notification handler
​https://bugs.webkit.org/show_bug.cgi?id=149384

Reviewed by Chris Fleizach.

Tools:

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
(AccessibilityController::platformResetToConsistentState): Actually remove the handler,
regardless of whether someone else holds a reference (we also call -stopListening in
-dealloc).

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::platformResetToConsistentState):
(AccessibilityController::addNotificationListener):
Ditto.

LayoutTests:

  • accessibility/mac/loaded-notification.html: Cleaned up the test - js-test-pre is

incompatible with directly using waitUntilDone.

3:30 AM Changeset in webkit [190025] by youenn.fablet@crf.canon.fr
  • 21 edits in trunk

.:
Removing XHR_TIMEOUT guard

Remove XHR_TIMEOUT compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=149260

Reviewed by Benjamin Poulain.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:
Remove XHR_TIMEOUT compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=149260

Reviewed by Benjamin Poulain.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:
Remove XHR_TIMEOUT compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=149260

Reviewed by Benjamin Poulain.

Covered by existing tests.

  • Configurations/FeatureDefines.xcconfig:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::didFail):
(WebCore::XMLHttpRequest::didReachTimeout):
(WebCore::XMLHttpRequest::setTimeout):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::internalAbort):
(WebCore::XMLHttpRequest::didFailRedirectCheck):
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::suspend):

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequest.idl:

Source/WebKit/mac:
Remove XHR_TIMEOUT compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=149260

Reviewed by Benjamin Poulain.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:
Remove XHR_TIMEOUT compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=149260

Reviewed by Benjamin Poulain.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:
Remove XHR_TIMEOUT compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=149260

Reviewed by Benjamin Poulain.

  • wtf/FeatureDefines.h:

Tools:
Remove XHR_TIMEOUT compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=149260

Reviewed by Benjamin Poulain.

  • Scripts/webkitperl/FeatureList.pm:
12:38 AM Changeset in webkit [190024] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Add two missing files to the Xcode project

  • WebCore.xcodeproj/project.pbxproj:

These are imported by files that are built for Mac, but missing from the project.

Note: See TracTimeline for information about the timeline view.