Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 28, 2015:

11:51 PM Changeset in webkit [190304] by Carlos Garcia Campos

• 8 edits in trunk/Tools

[WTR] Pixel tests generate the snapshots twice in Web and UI processes
​https://bugs.webkit.org/show_bug.cgi?id=149595

Reviewed by Tim Horton.

All ports except IOS implement
PlatformWebView::windowSnapshotImage() to generate the snapshot
for the pixel tests in the UI process. But we are still generating
a snapshot for pixel tests in the Web process too, that is passed
to the UI process but ignored.
Whether a pixel result is needed or not, is only known by the web
process depending on whether the test called dumpAsText with
dumpPixels == true or not. Since the pixels are now dump in the UI
process, we need to pass that information to the UI process when
the test is done. For that we set a PixelResultIsPending bool
parameter to the Done message, and we only add the PixelResult
when UI process doesn't need to generate the pixels dump.

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage): Set
m_pixelResultIsPending to false on reset.
(WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
Done message, and set the PixelResult if m_pixelResultIsPending is false.

• WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
(WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
port.

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults): Use either the pixel result
from the web process or generate a pixel result from the web view
if need it.
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

• WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum

parameter to dumpPixelsAndCompareWithExpected, since the snapshot
is created by the caller now, but the CG implementation needs to
know if it's a Web or UI process snapshot.

• WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
cairo surface for the given image.

• WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
CGContext for the given image.

9:31 PM Changeset in webkit [190303] by commit-queue@webkit.org

• 5 edits in trunk/Tools

Fix JS errors on dashboard metrics page
​https://bugs.webkit.org/show_bug.cgi?id=149608

Patch by Dean Johnson <​dean_johnson@apple.com> on 2015-09-28
Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.

(initPlatformsByFamily):
(updateHiddenPlatforms):
(parsePlatformFamily): Deleted.
(updateToggleButtons): Deleted.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:

(updateHiddenPlatforms): Added to remove errors.
(initPlatformsByFamily): Added to remove errors.
(unhiddenQueues): Updated to use Settings.
(documentReady): Added logic to add toggle buttons to the settings menu.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:

(Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
MetricsMain.js to Settings.
(Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
MetricsMain.js to Settings.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:

(QueueView.prototype._updateHiddenState): Updated to use Settings.

7:38 PM Changeset in webkit [190302] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Remove unused parseMemoryAmount
​https://bugs.webkit.org/show_bug.cgi?id=149611

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-28
Reviewed by Mark Lam.

• heap/HeapStatistics.cpp:

(JSC::HeapStatistics::parseMemoryAmount): Deleted.

• heap/HeapStatistics.h:

6:55 PM Changeset in webkit [190301] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Web Inspector: JSGlobalRuntimeAgent unintentionally overrides InspectorRuntimeAgent destruction handling
​https://bugs.webkit.org/show_bug.cgi?id=149537

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-28
Reviewed by Darin Adler.

• inspector/agents/JSGlobalObjectRuntimeAgent.h:
• inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::willDestroyFrontendAndBackend): Deleted.
Do not override method, super class implementation is sufficient.

• JavaScriptCore.xcodeproj/project.pbxproj:

Fix file ordering.

• inspector/agents/InspectorDebuggerAgent.h:

Remove unused member variable.

6:08 PM Changeset in webkit [190300] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Appscale query fails because of missing index
​https://bugs.webkit.org/show_bug.cgi?id=149609

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-09-28
Reviewed by Darin Adler.

• QueueStatusServer/index.yaml: Added the required index.

5:39 PM Changeset in webkit [190299] by Brent Fulgham

• 2 edits in trunk/Tools

[Win] Fix the 64-bit build after switch to cmake.

Reviewed by Alex Christensen.

• Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
run a 64-bit build.

5:06 PM Changeset in webkit [190298] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Win] Fix build after r190295.

• PlatformWin.cmake: Add missing Forwarding Header.

4:58 PM Changeset in webkit [190297] by Alan Bujtas

• 3 edits in trunk/LayoutTests

fast/repaint/absolute-position-changed.html and fast/repaint/fixed.html are flaky.

Move .scrollTo() call to repaintTest() where we run the test code. (and add .offsetHeight call
to ensure that renderer tree is in clean state.)

Unreviewed gardening.

• fast/repaint/absolute-position-changed.html:
• fast/repaint/fixed.html:

4:45 PM Changeset in webkit [190296] by sbarati@apple.com

• 3 edits in trunk/LayoutTests

Follow up to bug: ​https://bugs.webkit.org/show_bug.cgi?id=149599

We're now skipping getter-richards-try-catch on debug builds.

Unreviewed: skip long running test on debug builds.

• js/regress/script-tests/getter-richards-try-catch.js:
• platform/mac/TestExpectations:

4:41 PM Changeset in webkit [190295] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Add an IDB Server that can roundtrip a request back to the client.
​https://bugs.webkit.org/show_bug.cgi?id=149603

Reviewed by NOBODY (Build fix).

• Modules/indexeddb/IDBRequest.h: Remove unneeded #include, fixing the WK/WK2 builds.

4:05 PM Changeset in webkit [190294] by sbarati@apple.com

• 2 edits in trunk/LayoutTests

Follow up to bug: ​https://bugs.webkit.org/show_bug.cgi?id=149599

This patch makes the test run for even less time.

Unreviewed attempted fix for flakiness.

• js/regress/script-tests/getter-richards-try-catch.js:

(Packet.prototype.toString):

3:55 PM Changeset in webkit [190293] by Brent Fulgham

• 2 edits in trunk

[Win] Unreviewed build fix for internal systems.

• Source/cmake/OptionsWin.cmake: Preferentially use the build target

location for include and link libraries, rather than the system locations.

3:47 PM Changeset in webkit [190292] by Brent Fulgham

• 9 edits in trunk/Source

Expose 'geometryFlipped' state for debugging/logging purposes
​https://bugs.webkit.org/show_bug.cgi?id=149557

Reviewed by Simon Fraser.

Source/WebCore:

No new tests: No new behavior.

• platform/graphics/ca/PlatformCALayer.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::geometryFlipped): Added.

• platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::geometryFlipped): Added.
(printLayer): Log flipped state of geometry.

• platform/graphics/ca/win/PlatformCALayerWin.h:

Source/WebKit2:

• WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::geometryFlipped): Added.

• WebProcess/WebPage/mac/PlatformCALayerRemote.h:

3:44 PM Changeset in webkit [190291] by beidson@apple.com

• 24 edits
  16 copies
  6 adds in trunk

Add an IDB Server that can roundtrip a request back to the client.
​https://bugs.webkit.org/show_bug.cgi?id=149603

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/deletedatabase-request-event.html

This is a critical piece of IDB infrastructure that:

• Puts a database client/server divide in place.
• Client synchronously sends requests to the server, and asynchronously receives a response back from it.
• Introduces a class structure that makes it easy for WebKit2 to add a thin layer to replace the in-process server with an out-of-process server.

To allow for the most basic of tests, the "delete database" request is hard coded as always failing
with an indeterminate error.

• Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::indexedDB):

• Modules/indexeddb/IDBDatabaseIdentifier.cpp:

(WebCore::IDBDatabaseIdentifier::debugString):

• Modules/indexeddb/IDBDatabaseIdentifier.h:

• Modules/indexeddb/client/IDBConnectionToServer.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp.

(WebCore::IDBClient::IDBConnectionToServer::create):
(WebCore::IDBClient::IDBConnectionToServer::IDBConnectionToServer):
(WebCore::IDBClient::IDBConnectionToServer::identifier):
(WebCore::IDBClient::IDBConnectionToServer::deleteDatabase):
(WebCore::IDBClient::IDBConnectionToServer::didDeleteDatabase):

• Modules/indexeddb/client/IDBConnectionToServer.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h.
• Modules/indexeddb/client/IDBConnectionToServerDelegate.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h.

(WebCore::IDBClient::IDBConnectionToServerDelegate::~IDBConnectionToServerDelegate):

• Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::IDBFactory::create):
(WebCore::IDBClient::IDBFactory::IDBFactory):
(WebCore::IDBClient::IDBFactory::openInternal):
(WebCore::IDBClient::IDBFactory::deleteDatabase):

• Modules/indexeddb/client/IDBFactoryImpl.h:

• Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:

(WebCore::IDBClient::IDBOpenDBRequest::createDeleteRequest):
(WebCore::IDBClient::IDBOpenDBRequest::createOpenRequest):
(WebCore::IDBClient::IDBOpenDBRequest::IDBOpenDBRequest):
(WebCore::IDBClient::IDBOpenDBRequest::~IDBOpenDBRequest):
(WebCore::IDBClient::IDBOpenDBRequest::requestCompleted):

• Modules/indexeddb/client/IDBOpenDBRequestImpl.h:

(WebCore::IDBClient::IDBOpenDBRequest::databaseIdentifier):
(WebCore::IDBClient::IDBOpenDBRequest::version):
(WebCore::IDBClient::IDBOpenDBRequest::create): Deleted.

• Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::IDBRequest):
(WebCore::IDBClient::IDBRequest::enqueueEvent):

• Modules/indexeddb/client/IDBRequestImpl.h:

(WebCore::IDBClient::IDBRequest::requestIdentifier):

• Modules/indexeddb/server/IDBConnectionToClient.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp.

(WebCore::IDBServer::IDBConnectionToClient::create):
(WebCore::IDBServer::IDBConnectionToClient::IDBConnectionToClient):
(WebCore::IDBServer::IDBConnectionToClient::identifier):
(WebCore::IDBServer::IDBConnectionToClient::didDeleteDatabase):

• Modules/indexeddb/server/IDBConnectionToClient.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h.
• Modules/indexeddb/server/IDBConnectionToClientDelegate.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h.

(WebCore::IDBServer::IDBConnectionToClientDelegate::~IDBConnectionToClientDelegate):

• Modules/indexeddb/server/IDBServer.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp.

(WebCore::IDBServer::IDBServer::create):
(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::registerConnection):
(WebCore::IDBServer::IDBServer::unregisterConnection):
(WebCore::IDBServer::IDBServer::deleteDatabase):

• Modules/indexeddb/server/IDBServer.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h.

• Modules/indexeddb/shared/IDBError.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp.

(WebCore::idbExceptionEntry):
(WebCore::IDBError::IDBError):
(WebCore::IDBError::operator=):
(WebCore::IDBError::name):
(WebCore::IDBError::message):

• Modules/indexeddb/shared/IDBError.h: Copied from Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp.

(WebCore::IDBError::IDBError):
(WebCore::IDBError::isNull):

• Modules/indexeddb/shared/IDBRequestData.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp.

(WebCore::IDBRequestData::IDBRequestData):

• Modules/indexeddb/shared/IDBRequestData.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h.

(WebCore::IDBRequestData::requestIdentifier):
(WebCore::IDBRequestData::databaseIdentifier):

• Modules/indexeddb/shared/IDBRequestIdentifier.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp.

(WebCore::nextRequestNumber):
(WebCore::IDBRequestIdentifier::IDBRequestIdentifier):
(WebCore::IDBRequestIdentifier::emptyValue):
(WebCore::IDBRequestIdentifier::deletedValue):
(WebCore::IDBRequestIdentifier::isHashTableDeletedValue):

• Modules/indexeddb/shared/IDBRequestIdentifier.h: Added.

(WebCore::IDBRequestIdentifier::isEmpty):
(WebCore::IDBRequestIdentifier::hash):
(WebCore::IDBRequestIdentifier::operator==):
(WebCore::IDBRequestIdentifier::connectionIdentifier):
(WebCore::IDBRequestIdentifierHash::hash):
(WebCore::IDBRequestIdentifierHash::equal):
(WebCore::IDBRequestIdentifierHashTraits::emptyValue):
(WebCore::IDBRequestIdentifierHashTraits::isEmptyValue):
(WebCore::IDBRequestIdentifierHashTraits::constructDeletedValue):
(WebCore::IDBRequestIdentifierHashTraits::isDeletedValue):

• Modules/indexeddb/shared/IDBResultData.cpp: Copied from Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.cpp.

(WebCore::IDBResultData::IDBResultData):

• Modules/indexeddb/shared/IDBResultData.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBOpenDBRequestImpl.h.

(WebCore::IDBResultData::requestIdentifier):
(WebCore::IDBResultData::error):

• Modules/indexeddb/shared/InProcessIDBServer.cpp: Added.

(WebCore::InProcessIDBServer::create):
(WebCore::InProcessIDBServer::InProcessIDBServer):
(WebCore::InProcessIDBServer::identifier):
(WebCore::InProcessIDBServer::connectionToServer):
(WebCore::InProcessIDBServer::connectionToClient):
(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::didDeleteDatabase):

• Modules/indexeddb/shared/InProcessIDBServer.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.h.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• loader/EmptyClients.cpp:

• page/DatabaseProvider.h:

• page/Page.cpp:

(WebCore::Page::idbConnection):

• page/Page.h:

• page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::debugString):

• page/SecurityOriginData.h:

Source/WebKit:

• Storage/WebDatabaseProvider.cpp:

(WebDatabaseProvider::idbConnectionToServerForSession):

• Storage/WebDatabaseProvider.h:

Source/WebKit2:

• WebProcess/Databases/WebDatabaseProvider.h:

LayoutTests:

• storage/indexeddb/modern/deletedatabase-request-event-expected.txt: Added.
• storage/indexeddb/modern/deletedatabase-request-event.html: Added.

3:44 PM Changeset in webkit [190290] by Brent Fulgham

• 6 edits in trunk/Tools

[Win] Allow Windows to run test-webkitpy without Cygwin
​https://bugs.webkit.org/show_bug.cgi?id=149602

Reviewed by Alex Christensen.

These changes mostly shift from hard-coded paths using UNIX-style
separators to Python's "os.path.join" syntax that uses the correct
path separator for each platform.

• Scripts/webkitpy/common/system/path.py:

(cygpath): Don't pass paths through Cygpath on native Windows.

• Scripts/webkitpy/port/win.py:

(WinPort._path_to_apache): Use os.path.join.
(WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
in 64-bit environments).

• Scripts/webkitpy/style/checker.py: Use os.path.join.
• Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
(GlobalVariablesTest.test_path_rules_specifier): Ditto.
(GlobalVariablesTest): Ditto.
(GlobalVariablesTest.test_max_reports_per_category): Ditto.
(CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
(CheckerDispatcherDispatchTest.test_js_paths): Ditto.
(CheckerDispatcherDispatchTest.test_json_paths): Ditto.
(CheckerDispatcherDispatchTest.test_python_paths): Ditto.
(CheckerDispatcherDispatchTest.test_text_paths): Ditto.
(CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
(StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
(StyleProcessor_CodeCoverageTest): Ditto.
(StyleProcessor_CodeCoverageTest.test_should_processskip_without_warning): Ditto.
(StyleProcessor_CodeCoverageTest.test_should_processskip_with_warning): Ditto.
(StyleProcessor_CodeCoverageTest.test_should_processtrue_result): Ditto.

• Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than

manual string concatenation of paths.

3:37 PM Changeset in webkit [190289] by msaboff@apple.com

• 33 edits
  8 adds in trunk

[ES6] Implement tail calls in the FTL
​https://bugs.webkit.org/show_bug.cgi?id=148664

Source/JavaScriptCore:

Patch by ​basile_clement@apple.com <​basile_clement@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2015-09-28
Reviewed by Filip Pizlo.

This patch implements the tail call opcodes in the FTL, making tail
calls available through all tiers. The changes are relatively
straightforward, although the frame shuffler had to be extended to
handle the possibility of running out of stack when spilling or
building a slow path frame. The other tiers always ensure that we have
enough stack space to build the new frame at the bottom of the old one,
but that is not true for the FTL.

Moreover, for efficiency, this adds to the shuffler the ability to
record the state of the TagTypeNumber, and to re-use the same register
when doing several consecutive integer boxings with no spilling in
between.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/ValueRecovery.h:

(JSC::ValueRecovery::inRegister):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGNode.h:

(JSC::DFG::Node::isFunctionTerminal):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

• ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfTailCallVarargs):
(JSC::FTL::sizeOfTailCallForwardVarargs):
(JSC::FTL::sizeOfICFor):

• ftl/FTLInlineCacheSize.h:
• ftl/FTLJSCall.cpp:

(JSC::FTL::JSCall::JSCall):

• ftl/FTLJSCallBase.cpp:

(JSC::FTL::JSCallBase::emit):
(JSC::FTL::JSCallBase::link):

• ftl/FTLJSCallBase.h:
• ftl/FTLJSCallVarargs.cpp:

(JSC::FTL::JSCallVarargs::JSCallVarargs):
(JSC::FTL::JSCallVarargs::emit):

• ftl/FTLJSTailCall.cpp: Added.

(JSC::FTL::getRegisterWithAddend):
(JSC::FTL::recoveryFor):
(JSC::FTL::sizeFor):
(JSC::FTL::JSTailCall::JSTailCall):
(JSC::FTL::m_instructionOffset):
(JSC::FTL::JSTailCall::emit):

• ftl/FTLJSTailCall.h: Copied from Source/JavaScriptCore/ftl/FTLJSCallBase.h.

(JSC::FTL::JSTailCall::stackmapID):
(JSC::FTL::JSTailCall::estimatedSize):
(JSC::FTL::JSTailCall::numArguments):
(JSC::FTL::JSTailCall::operator<):

• ftl/FTLLocation.h:

(JSC::FTL::Location::operator bool):
(JSC::FTL::Location::operator!):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileNode):
(JSC::FTL::DFG::LowerDFGToLLVM::compileTailCall):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):
(JSC::FTL::DFG::LowerDFGToLLVM::exitValueForTailCall):

• ftl/FTLState.h:
• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitExceptionCheck):

• jit/CallFrameShuffleData.h:
• jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::CallFrameShuffler):
(JSC::CallFrameShuffler::dump):
(JSC::CallFrameShuffler::spill):
(JSC::CallFrameShuffler::extendFrameIfNeeded):
(JSC::CallFrameShuffler::prepareForSlowPath):
(JSC::CallFrameShuffler::prepareAny):

• jit/CallFrameShuffler.h:

(JSC::CallFrameShuffler::restoreGPR):
(JSC::CallFrameShuffler::getFreeRegister):
(JSC::CallFrameShuffler::getFreeTempGPR):
(JSC::CallFrameShuffler::ensureTempGPR):
(JSC::CallFrameShuffler::addNew):

• jit/CallFrameShuffler64.cpp:

(JSC::CallFrameShuffler::emitBox):
(JSC::CallFrameShuffler::tryAcquireTagTypeNumber):

• jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

• jit/Reg.h:

(JSC::Reg::Reg):
(JSC::Reg::isHashTableDeletedValue):
(JSC::Reg::deleted):
(JSC::RegHash::hash):
(JSC::RegHash::equal):

• test/es6.yaml:

LayoutTests:

Reviewed by Filip Pizlo.

Added one new tail call test and enabled other tail call tests.

• js/caller-property-expected.txt:
• js/script-tests/caller-property.js:

(string_appeared_here.nonStrictCallee):
(strictCallee):
(nonStrictCaller):
(strictCaller):
(strictTailCaller):
(getFooGetter):

3:11 PM Changeset in webkit [190288] by rniwa@webkit.org

• 4 edits
  2 adds in trunk

relatedNode should be retargeted respecting slots
​https://bugs.webkit.org/show_bug.cgi?id=149591

Reviewed by Antti Koivisto.

Source/WebCore:

This patch retargets relatedNode with respect to shadow boundaries after r190214 as specified in
​https://w3c.github.io/webcomponents/spec/shadow/#retargeting-relatedtarget

Naively implementing the spec'ed behavior can result in O(n^{2) behavior since we need to find the common tree scope
ancestor for each target in the event path. This patch avoids this by implementing an O(1) incremental update step
for when target's tree scope changes in the event path. See the description for moveToNewTreeScope below.}

Test: fast/shadow-dom/event-with-related-target.html

• dom/EventContext.h: Replaced toMouseOrFocusEventContext by downcast<MouseOrFocusEventContext>.
• dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver): Removed the code for relatedNode. This class is now only used for touch events.
(WebCore::EventPath): Added m_event as a member variable.

(WebCore::RelatedNodeRetargeter): Added.

(WebCore::RelatedNodeRetargeter::RelatedNodeRetargeter): Does the initial retargeting of relatedNode. When the
tree scope of relatedNode and the target are the same, we immediately exit without collecting ancestor tree scopes
of relatedNode as an optimization. We also special case when the relatedNode and the target are in two different
documents (relatedNode should be nullptr) and when one is in document and the other one is not in the document
(relatedNode should be the host of the outermost shadow root). Otherwise we have to do the real work by collecting
all tree scope ancestors and walking downwards from the document tree scope (note target and relatedNode share the
same document scope here since we would have exited early otherwise).

(WebCore::RelatedNodeRetargeter::currentNode): Returned relatedNode retargeted for the current tree scope.

(WebCore::RelatedNodeRetargeter::moveToNewTreeScope): Moves to a new tree scope. If the original target and
relatedNode were in different trees, there is nothing to be done. Note that we can only move out of a shadow root
to its host or move into a slot so newTreeScope (current target's tree scope) and previousTreeScope (previous
target's tree scope) must have a child-parent relationship.

If previousTreeScope did not contain the retargeted relatedNode, then neither can its child shadow trees. Thus,
there is nothing to be done when moving into a slot in this case. If we're moving out of previousTreeScope, then
newTreeScope may contain the retargeted relatedNode but that still doesn't require any work. So we exit early in
both cases.

Otherwise (previousTreeScope contained retargeted relatedNode), if we're moving out of a child shadow root
(previousTreeScope) then relatedNode should also move to previousTreeScope's shadow host since previousTreeScope
is a direct-child shadow tree of newTreeScope and previousTreeScope's shadow host resides in newTreeScope.

If we're moving into a child shadow root via a slot, then there are three possibilities: relatedNode is in
previousTreeScope, newTreeScope and its child shadow trees, or newTreeScope's sibling tree scopes and its children.
If it is in previousTreeScope (m_lowestCommonAncestorIndex is zero) or in newTreeScope's sibling, then
previousTreeScope is the lowest common tree scope ancestor so there is nothing to be done. If relatedNode is in
newTreeScope, then the retargeted relatedNode is either the shadow host of the shadow tree that contains
relatedNode or relatedNode itself.

(WebCore::RelatedNodeRetargeter::checkConsistency): Finds the retargeted relatedNode in the simplest way to verify
the correctness of the algorithm. We can disable this consistency check if it slows down debug builds too much.
(WebCore::RelatedNodeRetargeter::nodeInLowestCommonAncestor): Finds the
(WebCore::RelatedNodeRetargeter::collectTreeScopes):
(WebCore::EventPath::setRelatedTarget): Rewritten using RelatedNodeRetargeter.

LayoutTests:

Added a new testharness.js test for retargeting relatedNode.

• fast/shadow-dom/event-with-related-target.html: Added.

3:08 PM Changeset in webkit [190287] by commit-queue@webkit.org

• 6 edits in trunk

Build WK1 with CMake on Mac
​https://bugs.webkit.org/show_bug.cgi?id=149604

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-09-28
Reviewed by Chris Dumez.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/WebKitMacros.cmake:

ObjC bindings now have their own list of IDL files, but some of them still don't generate a .mm file.

Source/WebCore:

• CMakeLists.txt:
• PlatformMac.cmake:

Make a list of IDL files for the ObjC bindings.

3:03 PM Changeset in webkit [190286] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Hitting ESC while editing element tag name leaves element in bad state
​https://bugs.webkit.org/show_bug.cgi?id=149506

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-28
Reviewed by Timothy Hatcher.

• UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._startEditingTagName.editingCancelled):
(WebInspector.DOMTreeElement.prototype._startEditingTagName):
When cancelling editing of a tag name, revert any changes we had
been making to the closing tag name.

2:44 PM Changeset in webkit [190285] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: search shortcut in split console moves focus to search box, but doesn't show caret
​https://bugs.webkit.org/show_bug.cgi?id=149223

Patch by João Oliveira <​hello@jxs.pt> on 2015-09-28
Reviewed by Timothy Hatcher.

When pressing console find shortcut (CMD+F) SearchBar now checks if there's text on _searchInput
if so text is selected, if the textbox is empty, textbox gains focus.

• UserInterface/Views/SearchBar.js:

(WebInspector.SearchBar.prototype.focus):

2:44 PM Changeset in webkit [190284] by Beth Dakin

• 3 edits in trunk/Source/WebKit2

Heavy taps on links are sometimes interpreted as the preview gesture
​https://bugs.webkit.org/show_bug.cgi?id=149304
-and corresponding-
rdar://problem/22689258

Rubber-stamped by Tim Horton.

Rolling out this patch. We should try to fix this at the UIKit-level.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _interactionStoppedFromPreviewItemController:]):

12:08 PM Changeset in webkit [190283] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

ObjectPropertyConditionSet::mergedWith does not produce a minimal intersection.
​https://bugs.webkit.org/show_bug.cgi?id=149598

Reviewed by Michael Saboff.

mergedWith sometimes creates duplicates of an ObjectPropertyCondition, which causes GetByIdVariant
in believe that the condition has more than one slotBaseCondition when only one was necessary.

• bytecode/ObjectPropertyConditionSet.cpp:

(JSC::ObjectPropertyConditionSet::mergedWith):

11:57 AM Changeset in webkit [190282] by sbarati@apple.com

• 3 edits in trunk/LayoutTests

js/regress/getter-richards-try-catch is timing out on debug layout tests
​https://bugs.webkit.org/show_bug.cgi?id=149599

Reviewed by Alexey Proskuryakov.

• js/regress/script-tests/getter-richards-try-catch.js:

(Packet.prototype.toString):

• platform/mac/TestExpectations:

11:26 AM Changeset in webkit [190281] by Chris Dumez

• 43 edits
  1 delete in trunk

Drop support for legacy EventException
​https://bugs.webkit.org/show_bug.cgi?id=149597
<rdar://problem/22879795>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that a new check is passing.

• web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop support for legacy EventException. Both Firefox and Chrome do not
support it, and our implementation no longer throws such exceptions.

No new tests, already covered by existing test.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• Modules/indexeddb/legacy/LegacyRequest.cpp:
• Modules/indexeddb/legacy/LegacyTransaction.cpp:
• Modules/websockets/WebSocket.cpp:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/gobject/WebKitDOMPrivate.cpp:
• bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase): Deleted.

• dom/DOMAllInOne.cpp:
• dom/DOMExceptions.in:
• dom/EventException.cpp: Removed.
• dom/EventException.h:

(WebCore::EventException::EventException): Deleted.

• dom/EventException.idl:
• dom/EventListenerMap.cpp:
• dom/EventTarget.cpp:
• dom/MessagePort.cpp:
• dom/Node.cpp:
• loader/appcache/DOMApplicationCache.cpp:
• page/DOMWindow.cpp:
• page/EventSource.cpp:
• page/PerformanceUserTiming.h:
• workers/AbstractWorker.cpp:
• workers/Worker.cpp:
• workers/WorkerGlobalScope.cpp:
• xml/XMLHttpRequest.cpp:
• xml/XMLHttpRequestUpload.cpp:

LayoutTests:

Update / rebaseline several tests now that we no longer expose
EventException on the global Window object.

• fast/dom/Window/resources/window-properties.js:
• fast/dom/Window/window-lookup-precedence-expected.txt:
• js/dom/global-constructors-attributes-expected.txt:
• platform/efl/js/dom/global-constructors-attributes-expected.txt:
• platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt:
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/win/js/dom/global-constructors-attributes-expected.txt:

10:43 AM Changeset in webkit [190280] by Chris Dumez

• 27 edits
  2 adds in trunk

Object.getOwnPropertyNames() does not return named properties
​https://bugs.webkit.org/show_bug.cgi?id=149562
<rdar://problem/22879779>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing W3C tests now that Object.getOwnPropertyNames()
returns named properties for HTMLCollection. We unfortunately still
don't pass those because 'length' / 'constructor' properties are
currently on the instance and they should be on the prototype.

• web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt:
• web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
• web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:

Source/WebCore:

Previously, Object.getOwnPropertyNames() did not return named properties
for interfaces with named property getters. This patch adds support for
this in the JS bindings generator and uses it for HTMLCollection only
for now. Other interfaces will be taken care of independently.

Note that currently, even though the named properties are returned by
Object.getOwnPropertyNames(), these properties are still not enumerated.
This is because these are always unenumerable for existing DOM interfaces:

• ​https://dom.spec.whatwg.org/#interface-htmlcollection
• ​https://dom.spec.whatwg.org/#namednodemap

In the future, we may need to extend support if some interfaces require
those to be enumerable.

Test: fast/dom/htmlcollection-getownpropertynames.html

• Modules/mediastream/RTCStatsResponse.cpp:

(WebCore::WebCore::RTCStatsResponse::supportedPropertyNames):

• Modules/mediastream/RTCStatsResponse.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

• css/StyleSheetList.cpp:

(WebCore::StyleSheetList::supportedPropertyNames):

• css/StyleSheetList.h:
• dom/DOMNamedFlowCollection.cpp:

(WebCore::DOMNamedFlowCollection::supportedPropertyNames):

• dom/DOMNamedFlowCollection.h:
• dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::supportedPropertyNames):

• dom/NamedNodeMap.h:
• html/HTMLCollection.cpp:

(WebCore::HTMLCollection::supportedPropertyNames):

• html/HTMLCollection.h:

(WebCore::CollectionNamedElementCache::propertyNames):
(WebCore::CollectionNamedElementCache::appendToIdCache):
(WebCore::CollectionNamedElementCache::appendToNameCache):
(WebCore::CollectionNamedElementCache::memoryCost):
(WebCore::CollectionNamedElementCache::append):

• plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::supportedPropertyNames):

• plugins/DOMMimeTypeArray.h:
• plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::supportedPropertyNames):

• plugins/DOMPlugin.h:
• plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::supportedPropertyNames):

• plugins/DOMPluginArray.h:

LayoutTests:

Add layout test that verifies that Object.getOwnPropertyNames() returns
an HTMLCollection's named properties, in addition to its indexes. It
also checks that they are not enumerable, as per the DOM specification.

• fast/dom/htmlcollection-getownpropertynames-expected.txt: Added.
• fast/dom/htmlcollection-getownpropertynames.html: Added.

10:33 AM Changeset in webkit [190279] by peavo@outlook.com

• 2 edits in trunk/Source/WebCore

[Curl] Deadlock when downloading.
​https://bugs.webkit.org/show_bug.cgi?id=149596

Reviewed by Alex Christensen.

Avoid grabbing the same lock twice.

• platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::init):
(WebCore::CurlDownload::addHeaders):

6:53 AM Changeset in webkit [190278] by Wenson Hsieh

• 8 edits in trunk/Source/WebKit2

Expose a WKWebView API for allowing programmatic focus to trigger node assistance
​https://bugs.webkit.org/show_bug.cgi?id=149567

Reviewed by Darin Adler.

Adds an API method to WKWebView that allows clients to override the default iOS behavior of not
starting node assistance when programmatically focusing. Also fixes a bug caused by naively
introducing the flag where the autofocus attribute could trigger node assistance before layout
occurs, causing an ASSERT to fail in EditorState::postLayoutData.

I fixed this issue by not assisting the node if the editor state is missing post layout data,
instead deferring node assistance until layout has occurred.

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): Initializes the new node assistance flag to NO, which

is the current default behavior.

(-[WKWebView canAssistOnProgrammaticFocus]):
(-[WKWebView setCanAssistOnProgrammaticFocus:]): New API method that allows clients to set node

assistance behavior upon programmatic focus.

• UIProcess/API/Cocoa/WKWebViewConfiguration.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]): Added new node assistance flag to configuration.
(-[WKWebViewConfiguration _canAssistOnProgrammaticFocus]):
(-[WKWebViewConfiguration _setCanAssistOnProgrammaticFocus:]):

• UIProcess/WebPageProxy.h: Added NodeAssistanceArguments struct.
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]): Do not return

early if the node assistance flag is set to allow programmatic focus.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCommitLayerTree): After committing the layer tree, if we have deferred

starting node assistance, immediately trigger node assistance.

(WebKit::WebPageProxy::startAssistingNode): Defer starting node assistance if we have not yet repainted.
(WebKit::WebPageProxy::stopAssistingNode): Also cancel any deferred node assistance.

2:19 AM Changeset in webkit [190277] by Csaba Osztrogonác

• 2 edits in trunk/Tools

Add bugzilla addresses of committers to contributors.json
​https://bugs.webkit.org/show_bug.cgi?id=149520

Reviewed by Darin Adler.

• Scripts/webkitpy/common/config/contributors.json:

2:15 AM Changeset in webkit [190276] by Csaba Osztrogonác

• 3 edits in trunk/Tools

validate-committer-lists -b shouldn't need edituser privileges
​https://bugs.webkit.org/show_bug.cgi?id=149519

Reviewed by Darin Adler.

• Scripts/validate-committer-lists:

(CommitterListBugzillaChecker._has_invalid_bugzilla_email):

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries.is_invalid_bugzilla_email):
(BugzillaQueries): Deleted.
(BugzillaQueries.fetch_logins_matching_substring): Deleted.

12:49 AM Changeset in webkit [190275] by rniwa@webkit.org

• 2 edits in trunk/LayoutTests

Update bug numbers for failing test expectations in fast/shadow-dom.

• platform/mac/TestExpectations:

12:43 AM Changeset in webkit [190274] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Source/WebCore:
An SVG inherits the container size of the previously drawn HTMLImageElement when drawing it on a canvas
​https://bugs.webkit.org/show_bug.cgi?id=148845

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-09-28
Reviewed by Darin Adler.

When drawing an SVG image on a canvas we need to make sure that the container
size of the SVG is set to the image source size. If we do not do that, the
previous container size will be used as the size of the image. When drawing
it as HTMLImageElement, the renderer calls SVGImage::drawForContainer() which
calls setContainerSize() and then calls draw(). This call ensures that the
size is set correctly for cached images. But when drawing the SVGImage on
CanvasRenderingContext2D, the SVGImage::draw() is called directly because
it calls it through the base class method Image::draw().

If the image.isSVGImage(), CanvasRenderingContext2D::drawImage() has to call
SVGImage::setContainerSize() before calling Image::draw().

Test: svg/as-image/svg-cached-draw-canvas.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
Call SVGImage::setContainerSize() before calling Image::draw().

LayoutTests:
An SVG inherits the container size of the previously drawn HTMLImageElement when drawing it on canvas
​https://bugs.webkit.org/show_bug.cgi?id=148845

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-09-28
Reviewed by Darin Adler.

Ensure that an SVG image with intrinsic size or with no intrinsic size can be
displayed on a canvas even if it is previously displayed by an HTMLImageElement.

• svg/as-image/svg-cached-draw-canvas-expected.html: Added.
• svg/as-image/svg-cached-draw-canvas.html: Added.

Sep 27, 2015:

8:43 PM Changeset in webkit [190273] by Said Abou-Hallawa

• 2 edits in trunk/Source/WebCore

Rename all the variables and parameters of type HTMLImageElement in CanvasRenderingContext2D.cpp from 'image' to 'imageElement'

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-09-27
Reviewed by Darin Adler.

This does not change functionality in this file. It is a preparation for
the fix of the ​https://bugs.webkit.org/show_bug.cgi?id=148845.

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::size):
(WebCore::normalizeRect):
(WebCore::CanvasRenderingContext2D::drawImageFromRect):
(WebCore::CanvasRenderingContext2D::setAlpha):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::drawImage):

3:24 PM Changeset in webkit [190272] by Yusuke Suzuki

• 10 edits
  6 adds in trunk/Source/WebCore

[ES6] Implement ES6 Module loader hook stubs in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=149574

Reviewed by Ryosuke Niwa.

In this patch, we implement the loader hooks in the WebCore side.
Since the fetcher and actual evaluation code are separated from
this patch, they become empty.

Here, WebCore implements 3 loader hooks.

1. resolve hook

Takes the module name and resolve it to the unique module key.
In WebCore, we use URL as a module key.
And for the inlined module tag (e.g. <script type="module">import ...</script>),
we use the ES6 symbol as a module key.
In WebCore, we take the module name like "./hello.js" and resolve it by using
the URL of the importer module.
This functionality is implemented in this patch.

2. fetch hook

Fetches the resource specified by the module key. In WebCore, the module key is
URL. We use CachedResource loading system to load the resource of the modules.
The actual code of the fetch hook will be implemented in the subsequent patch.

3. evaluate hook

This is additional hook to instrument the module's execution for the inspector.
The actual code of the evaluate hook will be implemented in the subsequent patch.

In addition to that, we added required JSC forward headers for the module loader
implementation.

• CMakeLists.txt:
• ForwardingHeaders/runtime/JSInternalPromise.h: Added.
• ForwardingHeaders/runtime/JSInternalPromiseDeferred.h: Added.
• ForwardingHeaders/runtime/JSModuleRecord.h: Added.
• ForwardingHeaders/runtime/Symbol.h: Added.
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSBindingsAllInOne.cpp:
• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::moduleLoaderResolve):
(WebCore::JSDOMWindowBase::moduleLoaderFetch):
(WebCore::JSDOMWindowBase::moduleLoaderEvaluate):

• bindings/js/JSDOMWindowBase.h:
• bindings/js/JSModuleLoader.cpp: Added.

(WebCore::JSModuleLoader::JSModuleLoader):
(WebCore::JSModuleLoader::resolve):
(WebCore::JSModuleLoader::fetch):
(WebCore::JSModuleLoader::evaluate):

• bindings/js/JSModuleLoader.h: Added.

(WebCore::JSModuleLoader::document):

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):

• dom/Document.h:

(WebCore::Document::moduleLoader):

Sep 26, 2015:

8:03 PM Changeset in webkit [190271] by commit-queue@webkit.org

• 20 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/inspector.
​https://bugs.webkit.org/show_bug.cgi?id=149579

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-26
Reviewed by Darin Adler.

No new tests because there is no behavior change.

• inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::diff):
(WebCore::DOMPatchSupport::innerPatchChildren):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):
(WebCore::DOMPatchSupport::markNodeAsUsed):

• inspector/InspectorCSSAgent.cpp:

(WebCore::computePseudoClassMask):
(WebCore::ChangeRegionOversetTask::timerFired):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::resetPseudoStates):

• inspector/InspectorDOMAgent.cpp:

(WebCore::RevalidateStyleAttributeTask::timerFired):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getEventListeners):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::styleAttributeInvalidated):

• inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

• inspector/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::enable):
(WebCore::InspectorDatabaseAgent::disable):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
(WebCore::InspectorDatabaseAgent::databaseId):
(WebCore::InspectorDatabaseAgent::findByFileName):

• inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::frontendLoaded):

• inspector/InspectorFrontendHost.cpp:
• inspector/InspectorIndexedDBAgent.cpp:
• inspector/InspectorOverlay.cpp:

(WebCore::buildRendererHighlight):
(WebCore::buildObjectForHighlight):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):

• inspector/InspectorReplayAgent.cpp:

(WebCore::buildInspectorObjectForSession):
(WebCore::InspectorReplayAgent::didCreateFrontendAndBackend):
(WebCore::InspectorReplayAgent::willDestroyFrontendAndBackend):

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore::InspectorResourceAgent::willRecalculateStyle):

• inspector/InspectorStyleSheet.cpp:

(flattenSourceData):
(WebCore::InspectorStyle::buildArrayForComputedStyle):
(WebCore::InspectorStyle::populateAllProperties):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::ruleIndexByStyle):
(WebCore::InspectorStyleSheet::buildArrayForRuleList):

• inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::createWorkerFrontendChannelsForExistingWorkers):
(WebCore::InspectorWorkerAgent::destroyWorkerFrontendChannels):

• inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore::NetworkResourcesData::clear):

• inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::reportExecutionContextCreation):

• inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

• inspector/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::frameWindowDiscarded):

• inspector/WebInjectedScriptManager.cpp:

(WebCore::WebInjectedScriptManager::discardInjectedScriptsFor):

2:47 PM Changeset in webkit [190270] by bshafiei@apple.com

• 1 copy in tags/Safari-601.2.7

New tag.

1:11 PM Changeset in webkit [190269] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix debug tests. Before marking, we need to call registerGCThreads().

• heap/Heap.cpp:

(JSC::Heap::markRoots):

11:41 AM Changeset in webkit [190268] by fpizlo@apple.com

• 2 edits in trunk/Source/WTF

Unreviewed, fix Windows build by adding WTF_EXPORT_PRIVATE in various places.

• wtf/ParallelHelperPool.h:

(WTF::ParallelHelperClient::setFunction):
(WTF::ParallelHelperPool::numberOfThreads):

11:07 AM Changeset in webkit [190267] by fpizlo@apple.com

• 19 edits
  1 move
  5 adds
  2 deletes in trunk/Source

VMs should share GC threads
​https://bugs.webkit.org/show_bug.cgi?id=149433
rdar://problem/12859344

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This changes the GC to use a new WTF abstraction for parallelism called ParallelHelperPool.
This allows us to remove GCThread and all of the GCPhase machinery. This kills a lot of
code and also gives our GC magical thread sharing powers. If two GCs in two different VMs
fire at the same time, then they will both get a random subset of the available shared GC
threads. If one GC happens before the other, then it will probably get all of the available
threads. If a GC happens while another VM already started GCing, then it will probably not
get any helper threads. This is probably fine, since in multi-VM scenarios we have no
reason to optimize for anything other than total throughput.

The GC has one static helper pool. This pool is available via JSC::heapHelperPool(). It
would be OK for other parts of JSC to use it in the future for parallel tasks. Each Heap
instance has a helper client attached to the pool.

The marking phase tells the ParallelHelperClient to asynchronously run a function that
joins parallel marking and finishes once marking reaches termination. It uses the
client.setFunction() idiom where the threads share work with each other using a specialized
worklist. The ParallelHelperPool is not involved in deciding when threads should terminate.

The copying phase tells the ParallelHelperClient to run a copying function in parallel. It
uses the client.runFunctionInParallel() idiom. The copying function gets work from the
m_blocksToCopy worklist inside Heap.

To test that multiple VMs work properly, this adds a multi-VM test to testapi.mm. This test
creates five concurrent VMs and has each of them allocate about 30MB of memory before doing
a full GC. I've confirmed that this tests uses only 6 total GC threads on my 8-core
computer (this is correct since we are currently configured for 7-way parallelism).

This shouldn't affect performance on benchmarks, but it will sure help apps with a lot of
VM instances.

• CMakeLists.txt:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/AbstractMacroAssembler.h:
• heap/GCThread.cpp: Removed.
• heap/GCThread.h: Removed.
• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::~Heap):
(JSC::Heap::isPagedOut):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::resetVisitors):
(JSC::Heap::threadVisitCount):
(JSC::Heap::threadBytesVisited):
(JSC::Heap::threadBytesCopied):
(JSC::Heap::startNextPhase): Deleted.
(JSC::Heap::endCurrentPhase): Deleted.

• heap/Heap.h:
• heap/HeapHelperPool.cpp: Added.

(JSC::heapHelperPool):

• heap/HeapHelperPool.h: Added.
• heap/MarkStack.cpp:

(JSC::MarkStackArray::stealSomeCellsFrom):

• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::drainFromShared):

• jit/BinarySwitch.h:
• runtime/CodeCache.h:
• runtime/VM.h:
• runtime/WeakRandom.h: Removed.
• API/tests/testapi.mm:

Source/WTF:

This adds two major things to WTF: WeakRandom and ParallelHelperPool. WeakRandom was
already in JSC; we're just hoisting it into WTF. It's just a weak random number generator
that's suitable for places where you need just a tiny bit of randomness.

ParallelHelperPool is a new API that simplifies data-parallel algorithms like the JSC GC.
In a data-parallel algorithm, we want to run one task on as many cores as possible and let
the task worry about which subset of the input data to work on. In some cases, the
algorithm will not need to do any load balancing - and if load balancing is required, it's
up to the user. This is appropriate in contexts where the load balancing needs to be
custom-tuned for performance, like the GC's marking phase.

This new API has three concepts: task, client, and pool. A task is a reference counted
object with a run() method, which may be run in parallel. It is usually used to wrap a
functor. A pool is a pool of threads that can run things. A client is a placeholder for a
task. A client can have zero or one tasks. A client must be registered with a pool. When a
client has a task, the pool's threads may choose to run it. If a thread starts running a
task, it will run it to completion. When the task returns on any thread, the client takes
it to mean that the task should be removed. That means that any currently running instances
of the task will finish but no new threads will attempt to run the task. You can easily ask
a client to wait until a task finishes. You can also easily ask a client to run a task on
the current thread in addition to possibly some helper threads from the pool.

For some data-parallel algorithms, programming with ParallelHelperPool is as easy as:

client.runFunctionInParallel(

[=] () {

do things;

});

Note that you cannot tell ahead of time how many threads will join to help the task.
Threads may become available after the task has already started running. Those threads may
join after the other threads have already started. It's not advisable to make algorithmic
decisions based on client.numberOfActiveThreads(), since that number may change. Usually
the best way to use ParallelHelperPool is with an algorithm that has its own custom
worklist. An example of a very simple custom worklist is the one in the JSC GC's copying
phase - it's just a Vector and an index that indicates the next set of elements to process.

This new API was initially designed to simplify how GCThread works, by replacing Phase with
a callback that contains the phase's workload. I then realized that with a few tweaks, I
could make this somewhat general enough that it might become interesting outside GC. I also
realized that I could use this to enable thread sharing. So, although the API is kinda
quirky, it's grounded in the reality of how the JSC GC does parallelism.

• WTF.vcxproj/WTF.vcxproj:
• WTF.vcxproj/WTF.vcxproj.filters:
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/ParallelHelperPool.cpp: Added.

(WTF::ParallelHelperClient::ParallelHelperClient):
(WTF::ParallelHelperClient::~ParallelHelperClient):
(WTF::ParallelHelperClient::setTask):
(WTF::ParallelHelperClient::finish):
(WTF::ParallelHelperClient::doSomeHelping):
(WTF::ParallelHelperClient::runTaskInParallel):
(WTF::ParallelHelperClient::claimTask):
(WTF::ParallelHelperClient::runTask):
(WTF::ParallelHelperPool::ParallelHelperPool):
(WTF::ParallelHelperPool::~ParallelHelperPool):
(WTF::ParallelHelperPool::addThreads):
(WTF::ParallelHelperPool::ensureThreads):
(WTF::ParallelHelperPool::doSomeHelping):
(WTF::ParallelHelperPool::didMakeWorkAvailable):
(WTF::ParallelHelperPool::helperThreadBody):
(WTF::ParallelHelperPool::hasClientWithTask):
(WTF::ParallelHelperPool::getClientWithTask):
(WTF::ParallelHelperPool::waitForClientWithTask):

• wtf/ParallelHelperPool.h: Added.

(WTF::ParallelHelperClient::setFunction):
(WTF::ParallelHelperClient::runFunctionInParallel):
(WTF::ParallelHelperClient::pool):
(WTF::ParallelHelperClient::numberOfActiveThreads):
(WTF::ParallelHelperPool::numberOfThreads):

• wtf/SharedTask.h: Added.

(WTF::SharedTask::SharedTask):
(WTF::SharedTask::~SharedTask):
(WTF::SharedTaskFunctor::SharedTaskFunctor):
(WTF::createSharedTask):

• wtf/WeakRandom.h: Copied from Source/JavaScriptCore/runtime/WeakRandom.h.

(WTF::WeakRandom::WeakRandom):
(WTF::WeakRandom::initializeSeed):
(WTF::WeakRandom::seedUnsafe):
(WTF::WeakRandom::getUint32):
(WTF::WeakRandom::advance):
(JSC::WeakRandom::WeakRandom): Deleted.
(JSC::WeakRandom::seedUnsafe): Deleted.
(JSC::WeakRandom::getUint32): Deleted.
(JSC::WeakRandom::advance): Deleted.
(JSC::WeakRandom::initializeSeed): Deleted.

2:35 AM Changeset in webkit [190266] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Gardening: skip media stream tests failing after r190262.

Tools:

• Scripts/run-gtk-tests:

(TestRunner):

LayoutTests:

• platform/gtk/TestExpectations:

1:40 AM Changeset in webkit [190265] by Carlos Garcia Campos

• 4 edits in trunk

REGRESSION(r188639): [GTK] Several inspector tests started to time out in GTK+ bots after r188639
​https://bugs.webkit.org/show_bug.cgi?id=148569

Reviewed by Darin Adler.

Source/WebKit2:

• PlatformGTK.cmake: Add missing inspector files required for

layout tests.

LayoutTests:

• platform/gtk/TestExpectations: Unskip the inspector tests.

Sep 25, 2015:

11:17 PM Changeset in webkit [190264] by ap@apple.com

• 2 edits in trunk/LayoutTests

Skip newly added js/regress/getter-richards-try-catch.html on debug builds,
because it times out.

• platform/mac/TestExpectations:

7:29 PM Changeset in webkit [190263] by ap@apple.com

• 12 edits
  1 delete in trunk/Tools

[Mac] USE_INTERNAL_SDK is used undefined in tools projects
​https://bugs.webkit.org/show_bug.cgi?id=149571

Reviewed by Dan Bernstein.

Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).

• DumpRenderTree/mac/Configurations/Base.xcconfig:
• DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
• LayoutTestRelay/Configurations/Base.xcconfig:
• MiniBrowser/Configurations/Base.xcconfig:
• MiniBrowser/Configurations/DebugRelease.xcconfig:
• TestWebKitAPI/Configurations/Base.xcconfig:
• TestWebKitAPI/Configurations/DebugRelease.xcconfig:
• WebEditingTester/Configurations/Base.xcconfig:
• WebEditingTester/Configurations/DebugRelease.xcconfig:
• WebKitTestRunner/Configurations/Base.xcconfig:
• WebKitTestRunner/Configurations/DebugRelease.xcconfig:
• WebKitTestRunner/iOS.xcconfig: Removed.

7:23 PM Changeset in webkit [190262] by eric.carlson@apple.com

• 28 edits in trunk

Clean up user media request internal API
​https://bugs.webkit.org/show_bug.cgi?id=149527

Reviewed by Tim Horton.

Source/WebCore:

No new tests, no functional change.

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::constraintsValidated): Use track persistent ID to create vectors

as that is what the platform code needs to map to a capture device.

(WebCore::UserMediaRequest::userMediaAccessGranted): m_chosenXXDeviceUID -> m_XXDeviceUIDAllowed.

Use the device IDs to create the MediaStream. Switch audio/video parameter order.

(WebCore::UserMediaRequest::didCreateStream): Don't assume constraints are valid.

• Modules/mediastream/UserMediaRequest.h:

(WebCore::UserMediaRequest::videoDeviceUIDs):
(WebCore::UserMediaRequest::audioDeviceUIDs):
(WebCore::UserMediaRequest::allowedVideoDeviceUID):
(WebCore::UserMediaRequest::allowedAudioDeviceUID):
(WebCore::UserMediaRequest::requiresAudio): Deleted.
(WebCore::UserMediaRequest::requiresVideo): Deleted.
(WebCore::UserMediaRequest::firstVideoDeviceUID): Deleted.
(WebCore::UserMediaRequest::firstAudioDeviceUID): Deleted.

• platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::AVMediaCaptureSource): Call setPersistentId.

Source/WebKit/mac:

• WebCoreSupport/WebUserMediaClient.mm:

(WebUserMediaClient::cancelRequest): Put UserMediaRequestsMap in a local instead or calling

userMediaRequestsMap() three times.

(-[WebUserMediaPolicyListener allow]): Get rid of unneeded local variables.
(-[WebUserMediaPolicyListener allowDeviceWithVideoUID]): Deleted, unused.

Source/WebKit2:

• UIProcess/API/C/WKUserMediaPermissionRequest.cpp:

(WKUserMediaPermissionRequestVideoDeviceUIDs): New, renamed from WKUserMediaPermissionRequestDeviceNamesVideo.
(WKUserMediaPermissionRequestAudioDeviceUIDs): New, renamed from WKUserMediaPermissionRequestDeviceNamesAudio.
(WKUserMediaPermissionRequestAllowBest): Deleted.
(WKUserMediaPermissionRequestDeviceNamesVideo): Deleted.
(WKUserMediaPermissionRequestDeviceNamesAudio): Deleted.
(WKUserMediaPermissionRequestFirstVideoDeviceUID): Deleted.
(WKUserMediaPermissionRequestFirstAudioDeviceUID): Deleted.

• UIProcess/API/C/WKUserMediaPermissionRequest.h:

• UIProcess/API/gtk/WebKitUserMediaPermissionRequest.cpp:

(webkitUserMediaPermissionRequestAllow): Update for UserMediaRequest API change.

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Get rid of the bool parameters.

Switch audio/video parameter order to be consistent with everywhere else.

(WebKit::UserMediaPermissionRequestManagerProxy::didReceiveUserMediaPermissionDecision): Ditto.

• UIProcess/UserMediaPermissionRequestManagerProxy.h:

• UIProcess/UserMediaPermissionRequestProxy.cpp:

(WebKit::UserMediaPermissionRequestProxy::UserMediaPermissionRequestProxy): Get rid of the bool parameters.

Switch audio/video parameter order to be consistent with everywhere else.

(WebKit::UserMediaPermissionRequestProxy::allow): Switch audio/video parameter order.
(WebKit::UserMediaPermissionRequestProxy::getDeviceNameForUID): Deleted.

• UIProcess/UserMediaPermissionRequestProxy.h:

(WebKit::UserMediaPermissionRequestProxy::create):
(WebKit::UserMediaPermissionRequestProxy::videoDeviceUIDs):
(WebKit::UserMediaPermissionRequestProxy::audioDeviceUIDs):
(WebKit::UserMediaPermissionRequestProxy::firstAudioDeviceUID):
(WebKit::UserMediaPermissionRequestProxy::requiresAudio): Deleted.
(WebKit::UserMediaPermissionRequestProxy::requiresVideo): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame): Get rid of the bool parameters.

Switch audio/video parameter order to be consistent with everywhere else.

• UIProcess/WebPageProxy.h: Ditto.
• UIProcess/WebPageProxy.messages.in: Ditto.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::startRequest): Get rid of bool params, the device

vectors have the same information.

(WebKit::UserMediaPermissionRequestManager::didReceiveUserMediaPermissionDecision): Switch audio/video

parameter order to be consistent with everywhere else. deviceUIDVideo -> videoDeviceUID,

deviceUIDAudio -> audioDeviceUID.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.h:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveUserMediaPermissionDecision): Switch audio/video parameter order.

• WebProcess/WebPage/WebPage.h:

Tools:

• TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.

7:10 PM Changeset in webkit [190261] by sbarati@apple.com

• 3 edits
  3 adds in trunk

DFG should use PhantomLocal instead of Flush as liveness preservation mechanism in LiveCatchVariablesPreservationPhase
​https://bugs.webkit.org/show_bug.cgi?id=149575

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

LiveCatchVariablesPreservationPhase is no longer forcing all live-at-catch
variables to be flushed to the stack. They are now kept alive to OSR exit
through PhantomLocal. This gives us a speed improvement for try-catch
programs (especially those that don't throw errors very often) because
we can keep locals in registers instead of forcing them onto the stack.

• dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::LiveCatchVariablePreservationPhase):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock):
(JSC::DFG::performLiveCatchVariablePreservationPhase):
(JSC::DFG::FlushLiveCatchVariablesInsertionPhase::FlushLiveCatchVariablesInsertionPhase): Deleted.
(JSC::DFG::FlushLiveCatchVariablesInsertionPhase::handleBlock): Deleted.

LayoutTests:

• js/regress/getter-richards-try-catch-expected.txt: Added.
• js/regress/getter-richards-try-catch.html: Added.
• js/regress/script-tests/getter-richards-try-catch.js: Added.

(randomException):
(runRichards):
(Scheduler):
(Scheduler.prototype.addIdleTask):
(Scheduler.prototype.addWorkerTask):
(Scheduler.prototype.addHandlerTask):
(Scheduler.prototype.addDeviceTask):
(Scheduler.prototype.addRunningTask):
(Scheduler.prototype.addTask):
(Scheduler.prototype.schedule):
(Scheduler.prototype.release):
(Scheduler.prototype.holdCurrent):
(Scheduler.prototype.suspendCurrent):
(Scheduler.prototype.queue):
(TaskControlBlock):
(TaskControlBlock.prototype.setRunning):
(TaskControlBlock.prototype.markAsNotHeld):
(TaskControlBlock.prototype.markAsHeld):
(TaskControlBlock.prototype.isHeldOrSuspended):
(TaskControlBlock.prototype.markAsSuspended):
(TaskControlBlock.prototype.markAsRunnable):
(TaskControlBlock.prototype.run):
(TaskControlBlock.prototype.checkPriorityAdd):
(TaskControlBlock.prototype.toString):
(IdleTask):
(IdleTask.prototype.run):
(IdleTask.prototype.toString):
(DeviceTask):
(DeviceTask.prototype.run):
(DeviceTask.prototype.toString):
(WorkerTask):
(WorkerTask.prototype.run):
(WorkerTask.prototype.toString):
(HandlerTask):
(HandlerTask.prototype.run):
(HandlerTask.prototype.toString):
(Packet):
(Packet.prototype.addTo):
(Packet.prototype.toString):

5:17 PM Changeset in webkit [190260] by Simon Fraser

• 15 edits
  12 adds in trunk

[iOS WK2] Add viewport tests and fix runUIScript() timing issues
​https://bugs.webkit.org/show_bug.cgi?id=149577

Reviewed by Tim Horton.

Source/WebKit2:

When calling testRunner.runUIScript() from a page load event, the script could run
in the UI process before the current remote layer tree transaction had been handled
there. This meant that runUIScript() could query state which was about to change.

Fix by delaying the execution of the UI script until a layer tree transaction has
been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().

This is done using a new C SPI function WKPageCallAfterNextPresentationUpdate(),
which is mirrored in the Obj-C SPI as -_doAfterNextPresentationUpdate:.

Move WKWebView SPI which is testing-related into a WKTesting category. It is expected
that this will grow significantly.

• UIProcess/API/C/WKPage.cpp:

(WKPageCallAfterNextPresentationUpdate):

• UIProcess/API/C/WKPagePrivate.h:
• UIProcess/API/Cocoa/WKWebView.mm:
• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::callAfterNextPresentationUpdate):

• UIProcess/WebPageProxy.h:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchAfterEnsuringDrawing):

Tools:

When calling testRunner.runUIScript() from a page load event, the script could run
in the UI process before the current remote layer tree transaction had been handled
there. This meant that runUIScript() could query state which was about to change.

Fix by delaying the execution of the UI script until a layer tree transaction has
been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::runUISideScriptAfterUpdateCallback):

• WebKitTestRunner/TestInvocation.h:

LayoutTests:

New viewport tests which read the scale etc. in the UI process.

• TestExpectations:
• fast/viewport/ios/resources/viewport-test-utils.js: Added.

(getUIScript):
(tableFromJSON):
(getViewport):
(runTest):

• fast/viewport/ios/width-is-device-width-expected.txt: Added.
• fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Added.
• fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall.html: Added.
• fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden.html: Added.
• fast/viewport/ios/width-is-device-width-overflowing-expected.txt: Added.
• fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit-expected.txt: Added.
• fast/viewport/ios/width-is-device-width-overflowing-no-shrink-to-fit.html: Added.
• fast/viewport/ios/width-is-device-width-overflowing.html: Added.
• fast/viewport/ios/width-is-device-width.html: Added.
• platform/ios-simulator-wk2/TestExpectations:

5:13 PM Changeset in webkit [190259] by Brent Fulgham

• 12 edits in branches/safari-601-branch/Source

Merge r190235. rdar://problem/22852382

2015-09-24 Brent Fulgham <Brent Fulgham>

[Win] Support composited content in WebView render-to-context methods
​https://bugs.webkit.org/show_bug.cgi?id=149516
<rdar://problem/22635080>

Reviewed by Simon Fraser.

Source/WebCore:

Extend the CACFLayerTreeHost implementation to render into a passed
device context when requested. When no context is provided (the default
case) paint as normal.

Will be tested by existing compositing tests in a future bug. DumpRenderTree
has to be extended to do this painting properly.

• platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::CACFLayerTreeHost::paint): Accept an optional HDC argument, and pass it to the render method.
• platform/graphics/ca/win/CACFLayerTreeHost.h:
• platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Add missing SOFT_LINK command for the WKCACFViewDrawIntoDC. (WebCore::LegacyCACFLayerTreeHost::paint): Accept optional HDC argument and pass it to the parent class. (WebCore::LegacyCACFLayerTreeHost::render): Accept new optional HDC argument. If provided, call WKCACFViewDrawIntoDC. Otherwise, call WKCACFVIewDraw.
• platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
• platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Add missing SOFT_LINK command for the WKCACFViewDrawIntoDC. (WebCore::WKCACFViewLayerTreeHost::paint): Accept optional HDC argument and pass it to the parent class. (WebCore::WKCACFViewLayerTreeHost::render): Accept new optional HDC argument. If provided, call WKCACFViewDrawIntoDC. Otherwise, call WKCACFVIewDraw.
• platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:

Source/WebKit/win:

• WebView.cpp: (WebView::paint): Call the new 'paintCompositedContentToHDC' method. If it handles the pain, return. (WebView::paintCompositedContentToHDC): New method to share code with other paint methods. (WebView::paintDocumentRectToContext): Call new 'paintCompositedContentToHDC' to handle any composited layers. Otherwise, use slow drawing path. (WebView::paintScrollViewRectToContextAtPoint): Ditto. (WebView::unused5): Work around a linker issue that may appear when building test infrastructure on this branch.
• WebView.h:

4:52 PM Changeset in webkit [190258] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

FTLOSRExitCompiler incorrectly excludes FPR registers in callee saves loop
​https://bugs.webkit.org/show_bug.cgi?id=149540

Reviewed by Saam Barati.

Eliminated the incorrect check that callee saves registers are only GPRs.

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

3:36 PM Changeset in webkit [190257] by ap@apple.com

• 17 edits in trunk

[Mac] Media tests start to time out after a few days of bot uptime
​https://bugs.webkit.org/show_bug.cgi?id=149468

Reviewed by Darin Adler.

Source/WebKit2:

Make the fix work with WebKit2, and avoid touching user's media cache for WebKit1.

When UI process is not sandboxed, inherit DIRHELPER_USER_DIR_SUFFIX from it.
This means that during testing, WebContent uses a temporary directory of the form
/private/var/folders/.../T/WebKitTestRunner-VKjmz0/com.apple.WebKit.WebContent.Development,
instead of /private/var/folders/.../T/com.apple.WebKit.WebContent.Development+WebKitTestRunner.

WebKit1 now also better respects a temporary directory of the form
/private/var/folders/.../T/DumpRenderTree-VKjmz0, instead of the default, which
makes CoreMedia put its cache inside it.

As a result, almost everything is isolated per testing process, and deleted at the end.
Same with cache directories. The only outliers that I know of are plug-in directories,
which are per-process, but are not under the testing root, and thus aren't deleted.

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::initializeSandbox):

• Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::fromConnection):
(WebKit::ChildProcessProxy::getLaunchOptions):
(WebKit::ChildProcessProxy::connect):

• Shared/ChildProcessProxy.h:
• Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):

• Shared/SandboxInitializationParameters.h:

(WebKit::SandboxInitializationParameters::sandboxProfile):
(WebKit::SandboxInitializationParameters::setUserDirectorySuffix):
(WebKit::SandboxInitializationParameters::userDirectorySuffix):
(WebKit::SandboxInitializationParameters::setSystemDirectorySuffix): Deleted.
(WebKit::SandboxInitializationParameters::systemDirectorySuffix): Deleted.

• Shared/ios/ChildProcessIOS.mm:

(WebKit::ChildProcess::initializeSandbox):

• Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

• UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::getLaunchOptions):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getLaunchOptions):

• UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::getLaunchOptions):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

Tools:

Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
all temporary and cache files go to a custom location.

• Scripts/webkitpy/port/base.py:
• Scripts/webkitpy/port/driver.py:
• Scripts/webkitpy/port/mac.py:
• Scripts/webkitpy/port/win.py:

(WinPort._driver_tempdir_for_environment): Deleted unused function.

3:06 PM Changeset in webkit [190256] by Antti Koivisto

• 12 edits
  2 adds in trunk

Implement scoped styling for shadow DOM
​https://bugs.webkit.org/show_bug.cgi?id=149230

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/shadow-dom/css-scoping-shadow-with-rules-no-style-leak.html

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):

Only use special path here for user agent shadow trees.

• dom/AuthorStyleSheets.cpp:

(WebCore::AuthorStyleSheets::AuthorStyleSheets):
(WebCore::AuthorStyleSheets::removePendingSheet):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):

Basic support for ShadowRoot scoped stylesheets.

• dom/AuthorStyleSheets.h:

(WebCore::AuthorStyleSheets::activeStyleSheets):

• dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::~InlineStyleSheetOwner):
(WebCore::authorStyleSheetsForElement):
(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::childrenChanged):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::isLoading):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):

Basic support for ShadowRoot scoped inline stylesheets.

• dom/InlineStyleSheetOwner.h:

(WebCore::InlineStyleSheetOwner::sheet):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::styleResolver):

Create and initialize ShadowRoot scoped style resolver.

(WebCore::ShadowRoot::resetStyleResolver):
(WebCore::ShadowRoot::authorStyleSheets):

Collection of author stylesheets in the shadow tree.

(WebCore::ShadowRoot::updateStyle):

Trigger style recalc when stylesheets change.

(WebCore::ShadowRoot::cloneNode):

• dom/ShadowRoot.h:

(WebCore::ShadowRoot::resetStyleInheritance):

• html/HTMLStyleElement.h:
• svg/SVGStyleElement.h:

LayoutTests:

• fast/shadow-dom/css-scoping-shadow-with-rules-no-style-leak-expected.html: Added.
• fast/shadow-dom/css-scoping-shadow-with-rules-no-style-leak.html: Added.

Add a test that verifies that shadow DOM style doesn't affect normal DOM.

• platform/mac/TestExpectations:

Enable fast/shadow-dom/css-scoping-shadow-with-rules.html

3:04 PM Changeset in webkit [190255] by achristensen@apple.com

• 12 edits in trunk

Clean up CMake build on Mac
​https://bugs.webkit.org/show_bug.cgi?id=149573

Reviewed by Chris Dumez.

.:

• Source/cmake/OptionsMac.cmake:

Source/WebCore:

• CMakeLists.txt:
• PlatformEfl.cmake:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• platform/graphics/DisplayRefreshMonitor.cpp:

Source/WebKit:

• PlatformMac.cmake:

Source/WTF:

• wtf/PlatformMac.cmake:

3:01 PM Changeset in webkit [190254] by timothy_horton@apple.com

• 6 edits
  2 adds in trunk

Scrolling a overflow: scroll region makes find overlay holes stick to the edge of the region
​https://bugs.webkit.org/show_bug.cgi?id=149572
<rdar://problem/13093602>

Reviewed by Simon Fraser.

Test: fast/text/mark-matches-overflow-clip.html

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintTextMatchMarker):
Clip the rendered marker rect to the overflow rect.

• testing/Internals.cpp:

(WebCore::Internals::dumpMarkerRectsForNode):

• testing/Internals.h:
• testing/Internals.idl:

Add a internals function to dump the rendered rects for a marker.

• fast/text/mark-matches-overflow-clip-expected.txt: Added.
• fast/text/mark-matches-overflow-clip.html: Added.

Add a test ensuring that a find match that is clipped out by overflow
ends up with a clipped rendered rect.

2:50 PM Changeset in webkit [190253] by achristensen@apple.com

• 9 edits
  2 copies
  2 adds in trunk

[Win] Switch to CMake
​https://bugs.webkit.org/show_bug.cgi?id=148111

Reviewed by Brent Fulgham.

.:

• Source/cmake/WinTools.make: Added.
• Source/cmake/tools: Added.
• Source/cmake/tools/scripts: Copied from WebKitLibraries/win/tools/scripts.
• Source/cmake/tools/scripts/auto-version.pl: Copied from WebKitLibraries/win/tools/scripts/auto-version.pl.

Source/JavaScriptCore:

• JavaScriptCore.vcxproj/JavaScriptCore.proj:

Source/WebCore:

• WebCore.vcxproj/WebCore.proj:

Source/WebKit:

• WebKit.vcxproj/WebKit.proj:

Source/WTF:

• WTF.vcxproj/WTF.proj:

2:35 PM Changeset in webkit [190252] by Beth Dakin

• 4 edits in trunk/Source

Clicking on a data detected item inside a form control always pops up a map
on force touch trackpad
​https://bugs.webkit.org/show_bug.cgi?id=149559
-and corresponding-
rdar://problem/22826796

Reviewed by Tim Horton.

Source/WebCore:

The real bug here appears to be a bug in Lookup, but we can work around it.
For normal text, we call directly into Data Detectors for map results, and
that works fine. For text within form controls, we did not properly extract
the text for DD, so we sent it to Lookup instead, and Lookup has this bug
where they will pop open the map right away. If we properly extract the text
for form controls, then we can work around this bug.

• editing/mac/DataDetection.mm:

(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::detectItemAroundHitTestResult):

Source/WebKit2:

Look for Data Detected text for text nodes and HitTestResults that are over
text inside form controls.

• WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performImmediateActionHitTestAtLocation):

2:30 PM Changeset in webkit [190251] by achristensen@apple.com

• 4 edits in trunk

Prepare internal AppleWin build for CMake
​https://bugs.webkit.org/show_bug.cgi?id=149570

Reviewed by Brent Fulgham.

.:

• Source/PlatformWin.cmake:

Include internal CMake files if they exist.

WebKitLibraries:

• win/tools/scripts/auto-version.pl:

Use the WEBKIT_LIBRARIES environment variable if it exists.

12:46 PM Changeset in webkit [190250] by beidson@apple.com

• 31 edits in trunk/Source/WebCore

PassRefPtr<> to RefPtr<> conversion in legacy IndexedDB code.
​https://bugs.webkit.org/show_bug.cgi?id=149558

Reviewed by Beth Dakin.

No new tests (No behavior change.)

This patch does not attempt to completely remove all PassRefPtr usage inside legacy IDB.

It just switches over all PassRefPtr usage at the top level IDB interfaces that
modern IDB is implementing.

The rest of the usage inside the legacy implementation can be dealt with later via git rm.

• Modules/indexeddb/IDBAny.h:
• Modules/indexeddb/IDBCursor.h:
• Modules/indexeddb/IDBDatabase.h:
• Modules/indexeddb/IDBDatabaseError.h:
• Modules/indexeddb/IDBFactory.h:
• Modules/indexeddb/IDBIndex.h:
• Modules/indexeddb/IDBObjectStore.h:
• Modules/indexeddb/IDBRequest.h:
• Modules/indexeddb/IDBTransaction.h:
• Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::IDBFactory::getDatabaseNames):
(WebCore::IDBClient::IDBFactory::open):
(WebCore::IDBClient::IDBFactory::deleteDatabase):

• Modules/indexeddb/client/IDBFactoryImpl.h:
• Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::result):
(WebCore::IDBClient::IDBRequest::error):
(WebCore::IDBClient::IDBRequest::source):
(WebCore::IDBClient::IDBRequest::transaction):

• Modules/indexeddb/client/IDBRequestImpl.h:
• Modules/indexeddb/legacy/LegacyAny.cpp:

(WebCore::LegacyAny::createInvalid):
(WebCore::LegacyAny::createNull):
(WebCore::LegacyAny::createString):
(WebCore::LegacyAny::domStringList):
(WebCore::LegacyAny::idbCursor):
(WebCore::LegacyAny::idbCursorWithValue):
(WebCore::LegacyAny::idbDatabase):
(WebCore::LegacyAny::idbFactory):
(WebCore::LegacyAny::idbIndex):
(WebCore::LegacyAny::idbObjectStore):
(WebCore::LegacyAny::idbTransaction):
(WebCore::LegacyAny::LegacyAny):

• Modules/indexeddb/legacy/LegacyAny.h:

(WebCore::LegacyAny::create):

• Modules/indexeddb/legacy/LegacyCursor.cpp:

(WebCore::LegacyCursor::update):
(WebCore::LegacyCursor::deleteFunction):

• Modules/indexeddb/legacy/LegacyCursor.h:
• Modules/indexeddb/legacy/LegacyDatabase.cpp:

(WebCore::LegacyDatabase::objectStoreNames):
(WebCore::LegacyDatabase::createObjectStore):
(WebCore::LegacyDatabase::transaction):

• Modules/indexeddb/legacy/LegacyDatabase.h:
• Modules/indexeddb/legacy/LegacyFactory.cpp:

(WebCore::LegacyFactory::getDatabaseNames):
(WebCore::LegacyFactory::open):
(WebCore::LegacyFactory::deleteDatabase):

• Modules/indexeddb/legacy/LegacyFactory.h:
• Modules/indexeddb/legacy/LegacyIndex.cpp:

(WebCore::LegacyIndex::openCursor):
(WebCore::LegacyIndex::count):
(WebCore::LegacyIndex::openKeyCursor):
(WebCore::LegacyIndex::get):
(WebCore::LegacyIndex::getKey):

• Modules/indexeddb/legacy/LegacyIndex.h:

(WebCore::LegacyIndex::legacyObjectStore):

• Modules/indexeddb/legacy/LegacyObjectStore.cpp:

(WebCore::LegacyObjectStore::indexNames):
(WebCore::LegacyObjectStore::get):
(WebCore::LegacyObjectStore::add):
(WebCore::LegacyObjectStore::put):
(WebCore::LegacyObjectStore::deleteFunction):
(WebCore::LegacyObjectStore::clear):
(WebCore::LegacyObjectStore::createIndex):
(WebCore::LegacyObjectStore::index):
(WebCore::LegacyObjectStore::openCursor):
(WebCore::LegacyObjectStore::count):

• Modules/indexeddb/legacy/LegacyObjectStore.h:

(WebCore::LegacyObjectStore::keyPathAny):
(WebCore::LegacyObjectStore::transaction):
(WebCore::LegacyObjectStore::createIndex):
(WebCore::LegacyObjectStore::count):

• Modules/indexeddb/legacy/LegacyRequest.cpp:

(WebCore::LegacyRequest::result):
(WebCore::LegacyRequest::error):
(WebCore::LegacyRequest::source):
(WebCore::LegacyRequest::transaction):
(WebCore::LegacyRequest::onSuccess):

• Modules/indexeddb/legacy/LegacyRequest.h:
• Modules/indexeddb/legacy/LegacyTransaction.cpp:

(WebCore::LegacyTransaction::objectStore):

• Modules/indexeddb/legacy/LegacyTransaction.h:
• inspector/InspectorIndexedDBAgent.cpp:

12:13 PM Changeset in webkit [190249] by peavo@outlook.com

• 5 edits in trunk/Source

[WinCairo] Incorrect position for windowless plugins.
​https://bugs.webkit.org/show_bug.cgi?id=149524

Reviewed by Alex Christensen.

Source/WebCore:

Added method to get graphics context HDC.

• platform/graphics/GraphicsContext.h:
• platform/graphics/win/GraphicsContextWin.cpp:

(WebCore::GraphicsContext::getWindowsContext):
(WebCore::GraphicsContext::hdc):
(WebCore::GraphicsContextPlatformPrivate::save):

Source/WebKit/win:

Only perform the device context transformation if the plugin is painting
directly into the GraphicsContext HDC. The previous check was not correct
in all cases.

• Plugins/PluginViewWin.cpp:

(WebCore::PluginView::paint):

10:52 AM Changeset in webkit [190248] by youenn.fablet@crf.canon.fr

• 2 edits in trunk/Source/WebCore

Fix the broken !ENABLE(STREAM_API) build
​https://bugs.webkit.org/show_bug.cgi?id=149525

Reviewed by Darin Adler.

Removed some #ifdef ENABLE(STREAMS_API) to make build work when STREAMS_API is off.
This is a temporary fix.

• bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::initNormalWorldClientData):

10:51 AM Changeset in webkit [190247] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Simplify Stopwatch::elapsedTime
​https://bugs.webkit.org/show_bug.cgi?id=149538

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-25
Reviewed by Darin Adler.

• wtf/Stopwatch.h:

(WTF::Stopwatch::elapsedTime):
Simplify by not starting/stopping but just computing without updating members.

10:51 AM Changeset in webkit [190246] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Reloading the page causes the inspector tab to switch back to "Resources" tab
​https://bugs.webkit.org/show_bug.cgi?id=148732

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-25
Reviewed by Darin Adler.

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
Suppress selection of sibiling tree elements when removing extra folders.

10:48 AM Changeset in webkit [190245] by Alan Bujtas

• 2 edits in trunk/LayoutTests

Mark media/media-controls-play-button-updates.html failed for all Mac platforms.

Unreviewed gardening.

• platform/mac/TestExpectations:

10:45 AM Changeset in webkit [190244] by mitz@apple.com

• 2 edits
  1 delete in trunk/Tools

Removed MiniBrowser.entitlements.

Rubber-stamped by Anders Carlsson.

The entitlements weren’t used anyway.

• MiniBrowser/MiniBrowser.entitlements: Removed.
• MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:

10:25 AM Changeset in webkit [190243] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, nit fix after r190229.

• dom/Range.cpp:

(WebCore::Range::insertNode):

9:11 AM Changeset in webkit [190242] by Chris Dumez

• 5 edits in trunk

Unreviewed, rolling out r190232 and r190236.
​https://bugs.webkit.org/show_bug.cgi?id=149555

"It did not help" (Requested by cdumez on #webkit).

Reverted changesets:

"Unreviewed, roll out r187615 as it seems to have caused a ~1%
PLT regression."
​http://trac.webkit.org/changeset/190232

"This started failing after this rollout:"
​http://trac.webkit.org/changeset/190236

Patch by Commit Queue <​commit-queue@webkit.org> on 2015-09-25

9:10 AM Changeset in webkit [190241] by Brent Fulgham

• 2 edits in trunk/WebKitLibraries

[Win] Unreviewed build fix.

• win/tools/vsprops/FeatureDefines.props: Let Windows build know about

the STREAMS_API feature.

9:09 AM Changeset in webkit [190240] by Brent Fulgham

• 2 edits in trunk/Source/WTF

[Win] Unreviewed build fix.

• wtf/FeatureDefines.h: Don't turn STREAMS_API on by default

on Windows.

2:57 AM Changeset in webkit [190239] by youenn.fablet@crf.canon.fr

• 4 edits
  1 delete in trunk/Source/WebCore

Remove the need for DOMClass in case of JSBuiltinConstructor WebIDL
​https://bugs.webkit.org/show_bug.cgi?id=149522

Reviewed by Darin Adler.

Adding generation of the dummy DOM class for JSBuiltinConstructor interfaces.
This is applied to CountQueuingStrategy.

Covered by existing tests of CountQueuingStrategy.

• Modules/streams/CountQueuingStrategy.h: Removed.
• WebCore.vcxproj/WebCore.vcxproj: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Removal of DOM class header include and generation of dummy class.
(GenerateImplementation): Removal of DOM class header include.
(UseDummyDOMClass): Helper routine.
(GenerateDummyDOMClassForJSBuiltin): Ditto.

2:42 AM Changeset in webkit [190238] by Carlos Garcia Campos

• 5 edits in trunk

[GTK] ASSERTION FAILED: !m_inUpdateBackingStoreState in DrawingAreaImpl::display() after DrawingAreaImpl::forceRepaint()
​https://bugs.webkit.org/show_bug.cgi?id=148956

Reviewed by Žan Doberšek.

Source/WebKit2:

This is because those tests call notifyDone in the onresize event
handler. InjectedBundlePage::dump() always calls WKBundlePageForceRepaint()
before dumping. When the view is resized DrawingAreaImpl::updateBackingStoreState()
is called, so if the size has changed the FrameView::resize()
method is called and all children are resized, so the onresize
handlers happen at that point, before the
m_inUpdateBackingStoreState is set to false again. For WTR we
could probably just return early from froceReapaint() when
m_inUpdateBackingStoreState is true, because in that case we know
the layout is updated because of the resize and the actual display
is not really needed. But the UI process can also request a force
repaint, so we could wait until the backing store update is done
and then force the repaint. For WTR it will happen after the
dump, but it shouldn't be a problem.

• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::updateBackingStoreState):

• WebProcess/WebPage/DrawingAreaImpl.h:

LayoutTests:

Unskip tests that should pass now.

• platform/gtk/TestExpectations:

Sep 24, 2015:

11:58 PM Changeset in webkit [190237] by dbates@webkit.org

• 4 edits
  2 adds in trunk

Add WebKitSystemInterface for iOS 9.0
​https://bugs.webkit.org/show_bug.cgi?id=149550

Rubber-stamped by Alexey Proskuryakov.

Tools:

• Scripts/copy-webkitlibraries-to-product-directory:

WebKitLibraries:

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceIOSDevice9.0.a: Added.
• libWebKitSystemInterfaceIOSSimulator9.0.a: Added.

10:14 PM Changeset in webkit [190236] by Beth Dakin

• 2 edits in trunk/LayoutTests

This started failing after this rollout:
​http://trac.webkit.org/changeset/190232

• platform/mac/TestExpectations:

8:41 PM Changeset in webkit [190235] by Brent Fulgham

• 8 edits in trunk/Source

[Win] Support composited content in WebView render-to-context methods
​https://bugs.webkit.org/show_bug.cgi?id=149516
<rdar://problem/22635080>

Reviewed by Simon Fraser.

Source/WebCore:

Extend the CACFLayerTreeHost implementation to render into a passed
device context when requested. When no context is provided (the default
case) paint as normal.

Will be tested by existing compositing tests in a future bug. DumpRenderTree
has to be extended to do this painting properly.

• platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::paint): Accept an optional HDC argument, and
pass it to the render method.

• platform/graphics/ca/win/CACFLayerTreeHost.h:
• platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp: Add missing SOFT_LINK

command for the WKCACFViewDrawIntoDC.
(WebCore::WKCACFViewLayerTreeHost::paint): Accept optional HDC argument and
pass it to the parent class.
(WebCore::WKCACFViewLayerTreeHost::render): Accept new optional HDC argument.
If provided, call WKCACFViewDrawIntoDC. Otherwise, call WKCACFVIewDraw.
(WebCore::WKCACFViewLayerTreeHost::setShouldInvertColors):

• platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:

Source/WebKit/win:

• WebView.cpp:

(WebView::paint): Call the new 'paintCompositedContentToHDC' method. If
it handles the pain, return.
(WebView::paintCompositedContentToHDC): New method to share code with other
paint methods.
(WebView::paintDocumentRectToContext): Call new 'paintCompositedContentToHDC'
to handle any composited layers. Otherwise, use slow drawing path.
(WebView::paintScrollViewRectToContextAtPoint): Ditto.

• WebView.h:

7:56 PM Changeset in webkit [190234] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Drop [NotDeletable] from QuickTimePluginReplacement.postEvent()
​https://bugs.webkit.org/show_bug.cgi?id=149547

Reviewed by Eric Carlson.

Drop [NotDeletable] from QuickTimePluginReplacement.postEvent(). It does
not appear to be needed and this is the last user of this non-standard
IDL attribute. This patch also drops support for this IDL attribute.

• Modules/plugins/QuickTimePluginReplacement.idl:
• bindings/scripts/CodeGeneratorJS.pm:

(ComputeFunctionSpecial):

• bindings/scripts/IDLAttributes.txt:

7:48 PM Changeset in webkit [190233] by Chris Dumez

• 7 edits in trunk

Node.replaceChild() does not behave according to the specification
​https://bugs.webkit.org/show_bug.cgi?id=149546
<rdar://problem/22571887>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C DOM test now that one more check is passing.

• web-platform-tests/dom/nodes/MutationObserver-childList-expected.txt:

Source/WebCore:

Node.replaceChild() does not behave according to the specification. In
particular, when replacing |child| with |node| we are supposed to remove
|node| from its parent *before* removing |child| from its parent:

• ​https://dom.spec.whatwg.org/#concept-node-replace (Steps 10 & 11)

This patch reverses the order as per the specification. Our new behavior
matches Firefox's behavior. Note that this patch also remove an
optimization when replacing a child with its next sibling. This
optimization was observable from JS. It seems likely this case is not
common enough for it to be an issue. However, we can revisit if we see
it regresses things.

This leads to incorrect Mutation Records being queued in some cases.

No new tests, already covered by existing test.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::replaceChild):

LayoutTests:

Update existing test that now throws a different exception.

• fast/events/mutation-during-replace-child-expected.txt:
• fast/events/mutation-during-replace-child.html:

6:50 PM Changeset in webkit [190232] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Unreviewed, roll out r187615 as it seems to have caused a ~1% PLT regression.
<rdar://problem/22657123>

• platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagsKey):

• platform/graphics/FontCascade.cpp:

(WebCore::operator==):
(WebCore::makeFontSelectorFlags):
(WebCore::makeFontCascadeCacheKey):
(WebCore::computeFontCascadeCacheHash):

5:54 PM Changeset in webkit [190231] by hyatt@apple.com

• 13 edits in trunk/Source/WebCore

Keep the already-parsed list of terms in custom property values so that we don't have to re-parse them
later when doing variable resolution.
​https://bugs.webkit.org/show_bug.cgi?id=149544

Reviewed by Dean Jackson.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::customPropertyText):
Add a helper for getting the raw text. More closely parallels how non-custom properties work with the
extractor.

(WebCore::ComputedStyleExtractor::propertyValue):
Change propertyValue to use customPropertyText.

(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
Don't copy CSS custom properties into the style declaration. This is just used for things like editing, so
we didn't need to be putting the custom properties into this set.

(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
Patched to go straight to the serialized string value.

(WebCore::ComputedStyleExtractor::customPropertyValue): Deleted.
Replaced by customPropertyText.

• css/CSSComputedStyleDeclaration.h:

Rename customPropertyValue to customPropertyText and make it just return a String.

• css/CSSCustomPropertyValue.h:

(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::customCSSText):
(WebCore::CSSCustomPropertyValue::name):
(WebCore::CSSCustomPropertyValue::equals):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
(WebCore::CSSCustomPropertyValue::value): Deleted.
Changed to hold both a CSSParserValueList, which it adopts from the CSSParser, and a string value that
is constructed lazily only if the value is serialized. Now the problematic serialization code will only
run if someone uses the CSS OM to trigger a serialization (this should be a rare occurrence, so perf
improves with this change).

• css/CSSGrammar.y.in:

Change parsing of custom properties to be identical to regular properties. This refactoring allows
us to simply invoke the parser from style declarations as well and makes everything behave more
similarly to normal property parsing.

• css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyValue):
(WebCore::CSSParser::parseCustomPropertyDeclaration):
(WebCore::CSSParser::addCustomPropertyDeclaration): Deleted.

• css/CSSParser.h:

(WebCore::CSSParser::setCustomPropertyName):
We now have a method for parsing custom properties that can be invoked from style declarations. The
parser list is now adopted by the CSSCustomPropertyValue.

• css/CSSParserValues.cpp:

(WebCore::CSSParserValueList::toString):
Build the string serialization code right into CSSParserValueList.

• css/CSSParserValues.h:

Add a toString() method for serialization.

• css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::setProperty):
(WebCore::MutableStyleProperties::setCustomProperty):
Changed to use the new CSSParser functions. This makes the code behave almost identically to regular
property parsing.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

• rendering/style/RenderStyle.h:
• rendering/style/StyleCustomPropertyData.h:

Change the mapping on RenderStyle to store the custom CSS values. This way we can get to the original
parser lists for each variable when it comes time to do variable resolution.

5:17 PM Changeset in webkit [190230] by mark.lam@apple.com

• 14 edits in trunk/Source/JavaScriptCore

Remove the use of "Immediate" in JIT function names.
​https://bugs.webkit.org/show_bug.cgi?id=149542

Reviewed by Geoffrey Garen.

We will rename the following:

isOperandConstantImmediateDouble => isOperandConstantDouble
isOperandConstantImmediateInt => isOperandConstantInt
isOperandConstantImmediateChar => isOperandConstantChar

getOperandConstantImmediateInt => getOperandConstantInt
getConstantOperandImmediateInt => getOperandConstantInt

emitJumpIfImmediateInteger => emitJumpIfInt
emitJumpIfNotImmediateInteger => emitJumpIfNotInt
emitJumpIfNotImmediateIntegers => emitJumpIfNotInt
emitPatchableJumpIfNotImmediateInteger => emitPatchableJumpIfNotInt
emitJumpSlowCaseIfNotImmediateInteger => emitJumpSlowCaseIfNotInt
emitJumpSlowCaseIfNotImmediateNumber => emitJumpSlowCaseIfNotNumber
emitJumpSlowCaseIfNotImmediateIntegers => emitJumpSlowCaseIfNotInt
emitFastArithReTagImmediate => emitTagInt
emitTagAsBoolImmediate => emitTagBool
emitJumpIfImmediateNumber => emitJumpIfNumber
emitJumpIfNotImmediateNumber => emitJumpIfNotNumber
emitFastArithImmToInt - Deleted because this is an empty function.
emitFastArithIntToImmNoCheck => emitTagInt
emitPutImmediateToCallFrameHeader => emitPutToCallFrameHeader

This is purely a refactoring patch to do the renaming. There is no behavior
change.

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileSetupRegistersForEntry):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::AssemblyHelpers::emitPutImmediateToCallFrameHeader): Deleted.

• jit/JIT.cpp:

(JSC::JIT::privateCompile):

• jit/JIT.h:

(JSC::JIT::emitStoreCell):
(JSC::JIT::getSlowCase):

• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_negate):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emit_op_mod):
(JSC::JIT::compileBinaryArithOp):
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_mul):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_div):
(JSC::JIT::emitSlow_op_div):

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub):

• jit/JITInlines.h:

(JSC::JIT::emitArrayStorageGetByVal):
(JSC::JIT::isOperandConstantDouble):
(JSC::JIT::isOperandConstantChar):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
(JSC::JIT::isOperandConstantInt):
(JSC::JIT::getOperandConstantInt):
(JSC::JIT::emitGetVirtualRegisters):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitJumpIfInt):
(JSC::JIT::emitJumpIfNotInt):
(JSC::JIT::emitPatchableJumpIfNotInt):
(JSC::JIT::emitJumpSlowCaseIfNotInt):
(JSC::JIT::emitJumpSlowCaseIfNotNumber):
(JSC::JIT::emitTagBool):
(JSC::JIT::isOperandConstantImmediateDouble): Deleted.
(JSC::JIT::isOperandConstantImmediateChar): Deleted.
(JSC::JIT::isOperandConstantImmediateInt): Deleted.
(JSC::JIT::getOperandConstantImmediateInt): Deleted.
(JSC::JIT::getConstantOperandImmediateInt): Deleted.
(JSC::JIT::emitJumpIfImmediateInteger): Deleted.
(JSC::JIT::emitJumpIfNotImmediateInteger): Deleted.
(JSC::JIT::emitPatchableJumpIfNotImmediateInteger): Deleted.
(JSC::JIT::emitJumpIfNotImmediateIntegers): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateInteger): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateIntegers): Deleted.
(JSC::JIT::emitJumpSlowCaseIfNotImmediateNumber): Deleted.
(JSC::JIT::emitFastArithReTagImmediate): Deleted.
(JSC::JIT::emitTagAsBoolImmediate): Deleted.

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_string):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_profile_type):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

• jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
(JSC::JSInterfaceJIT::emitJumpIfNumber):
(JSC::JSInterfaceJIT::emitJumpIfNotNumber):
(JSC::JSInterfaceJIT::emitLoadDouble):
(JSC::JSInterfaceJIT::emitTagInt):
(JSC::JSInterfaceJIT::emitPutToCallFrameHeader):
(JSC::JSInterfaceJIT::emitJumpIfImmediateNumber): Deleted.
(JSC::JSInterfaceJIT::emitJumpIfNotImmediateNumber): Deleted.
(JSC::JSInterfaceJIT::emitFastArithImmToInt): Deleted.
(JSC::JSInterfaceJIT::emitFastArithIntToImmNoCheck): Deleted.
(JSC::JSInterfaceJIT::emitPutImmediateToCallFrameHeader): Deleted.

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):

• wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::startFunction):
(JSC::WASMFunctionCompiler::endFunction):

4:33 PM Changeset in webkit [190229] by Chris Dumez

• 8 edits in trunk

Rewrite Range::insertNode() as per the latest DOM specification
​https://bugs.webkit.org/show_bug.cgi?id=149528

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C DOM tests now that more tests are passing.

• web-platform-tests/dom/ranges/Range-insertNode-expected.txt:
• web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Rewrite Range::insertNode() as per the latest DOM specification:

• ​https://dom.spec.whatwg.org/#concept-range-insert

Our previous implementation seemed outdated as we were failing a lot of
W3C tests that Firefox is passing.

No new tests, already covered by existing tests.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::ensurePreInsertionValidity):
(WebCore::checkPreReplacementValidity):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::appendChild):

• dom/ContainerNode.h:
• dom/Range.cpp:

(WebCore::Range::insertNode):
(WebCore::Range::surroundContents):
(WebCore::Range::toString): Deleted.
(WebCore::Range::toHTML): Deleted.
(WebCore::Range::text): Deleted.
(WebCore::Range::createContextualFragment): Deleted.
(WebCore::Range::detach): Deleted.
(WebCore::Range::absoluteBoundingBox): Deleted.

• dom/Range.h:

4:03 PM Changeset in webkit [190228] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Find hole drawn at subframe's 0x0 when a subframe find match is not rendered
​https://bugs.webkit.org/show_bug.cgi?id=149543

Reviewed by Beth Dakin.

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::rectsForTextMatches):
Don't add empty rects to the list. Later code will just inflate them
and end up drawing a nonsensical find hole.

3:53 PM Changeset in webkit [190227] by Beth Dakin

• 2 edits in trunk/LayoutTests

The same problem happens on El Capitan.

• platform/mac/TestExpectations:

3:51 PM Changeset in webkit [190226] by bshafiei@apple.com

• 1 copy in tags/Safari-601.1.46.10.1

New tag.

3:40 PM Changeset in webkit [190225] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[Win] Unreviewed build failure.

• bindings/js/WebCoreJSClientData.h: Make sure Streams API headers

are only included if the feature is on.

2:58 PM Changeset in webkit [190224] by bshafiei@apple.com

• 4 edits
  2 copies in branches/safari-601.1.46.10-branch

Merged r189997. rdar://problem/22845894

2:56 PM Changeset in webkit [190223] by bshafiei@apple.com

• 5 edits in branches/safari-601.1.46.10-branch/Source

Versioning.

2:53 PM Changeset in webkit [190222] by bshafiei@apple.com

• 1 copy in branches/safari-601.1.46.10-branch

New Branch.

2:45 PM Changeset in webkit [190221] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, rebaseline web-platform-tests/html/dom/interfaces.html for iOS after r190190

• platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

2:42 PM Changeset in webkit [190220] by msaboff@apple.com

• 33 edits in trunk/Source/JavaScriptCore

[ES6] Implement tail calls in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=148663

Reviewed by Filip Pizlo.

jsc-tailcall: Implement the tail call opcodes in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=146850

This patch adds support for tail calls in the DFG. This requires a slightly high number of nodes:

• TailCall and TailCallVarargs are straightforward. They are terminal nodes and have the semantics of an actual tail call.

• TailCallInlinedCaller and TailCallVarargsInlinedCaller are here to perform a tail call inside an inlined function. They are non terminal nodes, and are performing the call as a regular call after popping an appropriate number of inlined tail call frames.

• TailCallForwardVarargs and TailCallForwardVarargsInlinedCaller are the extension of TailCallVarargs and TailCallVarargsInlinedCaller to enable the varargs forwarding optimization so that we don't lose performance with a tail call instead of a regular call.

This also required two broad kind of changes:

• Changes in the JIT itself (DFGSpeculativeJIT) are pretty straightforward since they are just an extension of the baseline JIT changes introduced previously.

• Changes in the runtime are mostly related with handling inline call frames. The idea here is that we have a special TailCall type for call frames that indicates to the various pieces of code walking the inline call frame that they should (recursively) skip the caller in their analysis.

• bytecode/CallMode.h:

(JSC::specializationKindFor):

• bytecode/CodeOrigin.cpp:

(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::isApproximatelyEqualTo):
(JSC::CodeOrigin::approximateHash):
(JSC::CodeOrigin::inlineStack):

• bytecode/CodeOrigin.h:
• bytecode/InlineCallFrame.cpp:

(JSC::InlineCallFrame::dumpInContext):
(WTF::printInternal):

• bytecode/InlineCallFrame.h:

(JSC::InlineCallFrame::callModeFor):
(JSC::InlineCallFrame::kindFor):
(JSC::InlineCallFrame::varargsKindFor):
(JSC::InlineCallFrame::specializationKindFor):
(JSC::InlineCallFrame::isVarargs):
(JSC::InlineCallFrame::isTail):
(JSC::InlineCallFrame::computeCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerSkippingDeadFrames):
(JSC::InlineCallFrame::getCallerInlineFrameSkippingDeadFrames):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGArgumentsEliminationPhase.cpp:
• dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::findTerminal):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::inlineCallFrame):
(JSC::DFG::ByteCodeParser::allInlineFramesAreTailCalls):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCallWithoutSettingResult):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::forAllLocalsLiveInBytecode):

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::willCatchExceptionInMachineFrame):

• dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::FlushLiveCatchVariablesInsertionPhase::willCatchException):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasCallVarargsData):
(JSC::DFG::Node::isTerminal):
(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGNodeType.h:
• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::osrWriteBarrier):

• dfg/DFGOSRExitPreparation.cpp:

(JSC::DFG::prepareCodeOriginForOSRExit):

• dfg/DFGOperations.cpp:
• dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateSSA):

• dfg/DFGVarargsForwardingPhase.cpp:
• interpreter/CallFrame.cpp:

(JSC::CallFrame::bytecodeOffset):

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::gotoNextFrame):

2:39 PM Changeset in webkit [190219] by dbates@webkit.org

• 2 edits in trunk/Tools

Support building for arbitrary architectures
​https://bugs.webkit.org/show_bug.cgi?id=149539

Reviewed by Alexey Proskuryakov.

Teach buildbot to pass the architectures associated with the builder to build-webkit
when building on OS X and iOS. As a side effect of this change we now support building
universal binaries when multiples architectures are specified.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

1:23 PM Changeset in webkit [190218] by dbates@webkit.org

• 2 edits in trunk/Tools

Fix the build after <​http://trac.webkit.org/changeset/190212>
(​http://trac.webkit.org/changeset/190212)

I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().

• BuildSlaveSupport/built-product-archive:

(main):

1:13 PM Changeset in webkit [190217] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Remove special case code for the no-parallel-GC case
​https://bugs.webkit.org/show_bug.cgi?id=149512

Reviewed by Mark Lam.

Make serial GC just a parallel GC where the helper threads don't do anything. Also make the
idle thread calculation a bit more explicit.

The main outcome is that we no longer use Options::numberOfGCMarkers() as much, so the code is
resilient against the number of GC markers changing.

• heap/Heap.h:
• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):

12:36 PM Changeset in webkit [190216] by dbates@webkit.org

• 2 edits in trunk/Tools

Support running unit tests on iOS Simulator test bot
​https://bugs.webkit.org/show_bug.cgi?id=149536

Reviewed by Alexey Proskuryakov.

Implements support for running unit tests on a iOS test bot. At the time of writing,
the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
(TestFactory.init): Add step RunUnitTests when the test bot is for the iOS Simulator platform.

12:23 PM Changeset in webkit [190215] by fpizlo@apple.com

• 3 edits
  1 add in trunk/Source/JavaScriptCore

PolymorphicAccess should remember that it checked an ObjectPropertyCondition with a check on some structure
​https://bugs.webkit.org/show_bug.cgi?id=149514

Reviewed by Oliver Hunt.

When we checked an ObjectPropertyCondition using an explicit structure check, we would forget to
note the structure in any weak reference table and we would attempt to regenerate the condition
check even if the condition became invalid.

We need to account for this better and we need to prune AccessCases that have an invalid condition
set. This change does both.

• bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::addWatchpoint):
(JSC::AccessCase::alternateBase):
(JSC::AccessCase::couldStillSucceed):
(JSC::AccessCase::canReplace):
(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerateWithCases):
(JSC::PolymorphicAccess::visitWeak):
(JSC::PolymorphicAccess::regenerate):

• bytecode/PolymorphicAccess.h:

(JSC::AccessCase::callLinkInfo):

• tests/stress/make-dictionary-repatch.js: Added. This used to crash on a release assert. If we removed the release assert, this would return bad results.

12:00 PM Changeset in webkit [190214] by rniwa@webkit.org

• 3 edits
  4 adds in trunk

Make event dispatching respect slotting
​https://bugs.webkit.org/show_bug.cgi?id=149243

Reviewed by Antti Koivisto.

Source/WebCore:

There are primarily two cases to consider: getting out of a shadow root to its host,
and moving into a slot from an assigned node.

When getting out of a shadow root, either the event originated in its shadow tree
including its nodes' shadow trees (1) or it moved into this shadow tree via a slot (2).
In (1), event.target should be set to the shadow host. In (2), it should be set to the
first node in the event path that belongs to the same tree as the shadow host. In order
to find such a node in O(1), we use a stack of event targets in each (shadow) tree. We
push event.target of the current tree whenever we move up to a slot from an assigned node
and pop it out of the stack when we move out of the shadow tree.

A follow up patch is needed to update the code to resolve related targets.

Tests: fast/shadow-dom/event-inside-shadow-tree.html

fast/shadow-dom/event-inside-slotted-node.html

• dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

LayoutTests:

Added tests for dispatching events inside shadow trees and nodes assigned to slots using testharness.js.

• fast/shadow-dom/event-inside-shadow-tree-expected.txt: Added.
• fast/shadow-dom/event-inside-shadow-tree.html: Added.
• fast/shadow-dom/event-inside-slotted-node-expected.txt: Added.
• fast/shadow-dom/event-inside-slotted-node.html: Added.

11:38 AM Changeset in webkit [190213] by mark.lam@apple.com

• 5 edits in trunk/Source/JavaScriptCore

We should only expect a RareCaseProfile to exist if the rare case actually exists.
​https://bugs.webkit.org/show_bug.cgi?id=149531

Reviewed by Saam Barati.

The current code that calls rareCaseProfileForBytecodeOffset() assumes that it
will always return a non-null RareCaseProfile. As a result, op_add in the
baseline JIT is forced to add a dummy slow case that will never be taken, only to
ensure that the RareCaseProfile for that bytecode is created. This profile will
always produce a counter value of 0 (since that path will never be taken).

Instead, we'll make the callers of rareCaseProfileForBytecodeOffset() check if
the profile actually exist before dereferencing it.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::capabilityLevel):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::addRareCaseProfile):
(JSC::CodeBlock::numberOfRareCaseProfiles):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::rareCaseProfile): Deleted.

• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

• jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_add):
(JSC::JIT::emitSlow_op_add):

11:36 AM Changeset in webkit [190212] by dbates@webkit.org

• 6 edits in trunk/Tools

Add support infrastructure for OpenSource iOS builders and testers
​https://bugs.webkit.org/show_bug.cgi?id=149534

Reviewed by Darin Adler.

Towards setting up OpenSource iOS build bots, teach buildbot and its support
scripts about iOS.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
--ios-simulator or --device for a builder/tester whose full platform name begins with
"ios-simulator" or "ios", respectively.
(RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().

• BuildSlaveSupport/built-product-archive:

(main): Pass the full platform name to determineWebKitBuildDirectory().
(determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
command line flag when building for iOS.
(archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
parameter fullPlatform. This parameter was originally added in r125066 to support the
Chromium Android port, which has since been removed from the OpenSource WebKit Project.
(extractBuiltProduct): Use the same logic for iOS as we do for Mac.

• BuildSlaveSupport/clean-build:

(main): Call script webkit-build-directory with the appropriate command line flag when
building for iOS.

• BuildSlaveSupport/delete-stale-build-files:

(main): Use the same logic for iOS as we do for Mac.
(webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
flag when building for iOS.

• BuildSlaveSupport/test-result-archive:

(archiveTestResults): Use the same logic for iOS as we do for Mac.

11:29 AM Changeset in webkit [190211] by dbates@webkit.org

• 2 edits in trunk/Tools

Remove Chromium-specific changes to script built-product-archive
​https://bugs.webkit.org/show_bug.cgi?id=149530

Rubber-stamped by Csaba Osztrogonác.

Reverts changes made in r113074 and r113067 to support Chromium testers. The
Chromium code has long since been removed from the OpenSource WebKit Project.

• BuildSlaveSupport/built-product-archive:

(createZipManually):
(createZip):
(archiveBuiltProduct):

11:17 AM Changeset in webkit [190210] by Chris Dumez

• 13 edits in trunk/Source

Drop XPATH_NAMESPACE_NODE from Node::NodeType enum
​https://bugs.webkit.org/show_bug.cgi?id=149532

Reviewed by Ryosuke Niwa.

Drop XPATH_NAMESPACE_NODE from Node::NodeType enum as there is currently
no way to construct such Node in WebKit. This avoid having to handle this
Node type everywhere.

Source/WebCore:

• bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap): Deleted.

• bindings/objc/DOM.mm:

(kitClass): Deleted.

• dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::adoptNode): Deleted.
(WebCore::Document::childTypeAllowed): Deleted.
(WebCore::Document::canAcceptChild): Deleted.

• dom/Node.cpp:

(WebCore::Node::dumpStatistics): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::ancestorElement): Deleted.

• dom/Node.h:
• dom/Range.cpp:

(WebCore::Range::checkNodeWOffset):
(WebCore::lengthOfContentsInNode): Deleted.
(WebCore::Range::processContentsBetweenOffsets): Deleted.
(WebCore::Range::surroundContents): Deleted.

• editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendStartMarkup): Deleted.

• xml/XPathFunctions.cpp:

(WebCore::XPath::expandedNameLocalPart): Deleted.

• xml/XPathStep.cpp:

(WebCore::XPath::Step::nodesInAxis):
(WebCore::XPath::primaryNodeType): Deleted.

• xml/XPathUtil.cpp:

(WebCore::XPath::stringValue): Deleted.
(WebCore::XPath::isValidContextNode): Deleted.

Source/WebKit2:

• WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass): Deleted.

11:15 AM Changeset in webkit [190209] by hyatt@apple.com

• 19 edits
  19 adds in trunk

Add support for CSS Custom Properties (in preparation for implementing CSS Variables).
​https://bugs.webkit.org/show_bug.cgi?id=130397

Reviewed by Antti Koivisto.

Source/WebCore:

Added new tests in fast/css/custom-properties.

• WebCore.xcodeproj/project.pbxproj:

Add new header files to the project (CSSCustomPropertyValue and StyleCustomPropertyData).

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):
(WebCore::ComputedStyleExtractor::propertyValue):
If a custom property value is queried (i.e., it starts with "--"), then we use our
customPropertyValue lookup to go to the RenderStyle and fetch the appropriate custom property
value from the StyleCustomPropertyData.

(WebCore::CSSComputedStyleDeclaration::length):
(WebCore::CSSComputedStyleDeclaration::item):
Patched to include custom properties in the returned array. They appear at the end of the array
after the built-in properties.

(WebCore::ComputedStyleExtractor::propertyMatches):
Patched to check custom properties.

(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
Make sure the custom properties get copied into the StyleDeclaration.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyValue):
Patched to call customPropertyValue for custom properties.

• css/CSSComputedStyleDeclaration.h:

Add customPropertyValue() to ComputedStyleExtractor.

• css/CSSCustomPropertyValue.h: Added.

(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::equals):
(WebCore::CSSCustomPropertyValue::customCSSText):
(WebCore::CSSCustomPropertyValue::name):
(WebCore::CSSCustomPropertyValue::value):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
Custom properties are parsed as a property with an ID of CSSPropertyCustom and a CSSCustomPropertyValue
that holds both the name and the value of the property. Ultimately we might want to just ditch property IDs in
favor of AtomicStrings for all properties, and then the need to special case custom properties would go
away. For now, though, this is the way we work custom properties into the existing system.

• css/CSSGrammar.y.in:

Add a production for recognizing custom properties and storing them using a property ID of CSSPropertyCustom
and a CSSCustomPropertyValue that has the name/value pair.

• css/CSSParser.cpp:

(WebCore::filterProperties):
Patched to track seen custom properties and to handle them correctly.

(WebCore::CSSParser::createStyleProperties):
Pass in a seenCustomProperties table to ensure we bail when encountering the same custom property twice.

(WebCore::CSSParser::addCustomPropertyDeclaration):
Called from the grammar production to create the CSSCustomPropertyValue.

(WebCore::isCustomPropertyIdentifier):
Recognize the -- custom property during lexing.

(WebCore::CSSParser::parseIdentifier):
Patched to return a CUSTOM_PROPERTY token when a custom property is identified.

• css/CSSParser.h:

(WebCore::isCustomPropertyName):
Add a helper function for asking if a property name is custom.

• css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

• css/CSSValue.h:

Patched to add support for CSSCustomPropertyValue.

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
Add code for handling custom properties in the CSS OM.

• css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::getCustomPropertyValue):
(WebCore::StyleProperties::getPropertyCSSValue):
(WebCore::StyleProperties::getCustomPropertyCSSValue):
(WebCore::MutableStyleProperties::removeProperty):
(WebCore::MutableStyleProperties::removeCustomProperty):
(WebCore::StyleProperties::propertyIsImportant):
(WebCore::StyleProperties::customPropertyIsImportant):
(WebCore::MutableStyleProperties::setProperty):
(WebCore::MutableStyleProperties::setCustomProperty):
(WebCore::MutableStyleProperties::addParsedProperty):
(WebCore::MutableStyleProperties::findPropertyIndex):
(WebCore::ImmutableStyleProperties::findCustomPropertyIndex):
(WebCore::MutableStyleProperties::findCustomPropertyIndex):
(WebCore::MutableStyleProperties::findCSSPropertyWithID):
(WebCore::MutableStyleProperties::findCustomCSSPropertyWithName):
(WebCore::StyleProperties::propertyMatches):
(WebCore::StyleProperties::PropertyReference::cssName):

• css/StyleProperties.h:

(WebCore::StyleProperties::findCustomPropertyIndex):
Patched to support handling custom properties in the CSS OM. We have to create equivalent methods that operate
on AtomicString propertyNames instead of on property IDs.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::CascadedProperties::customProperties):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::CascadedProperties::set):
(WebCore::StyleResolver::applyCascadedProperties):
The resolver has to hold a HashMap from AtomicStrings to Properties. It matches identically to how built-in
properties work except that an extensible table (HashMap) is used to hold the property data.

• css/makeprop.pl:

Patched to include the special CSSPropertyCustom value of 1 (just after the CSSPropertyInvalid id value but before the first
built-in property value).

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::getText):
(WebCore::lowercasePropertyName):
(WebCore::InspectorStyle::populateAllProperties):
Patch inspector to not lowercase CSS custom property names, since they are case-sensitive.

• rendering/style/RenderStyle.h:
• rendering/style/StyleCustomPropertyData.h: Added.

(WebCore::StyleCustomPropertyData::create):
(WebCore::StyleCustomPropertyData::copy):
(WebCore::StyleCustomPropertyData::operator==):
(WebCore::StyleCustomPropertyData::operator!=):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::getCustomPropertyValue):
(WebCore::StyleCustomPropertyData::hasCustomProperty):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):

• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

• rendering/style/StyleRareInheritedData.h:

The front end storage in the RenderStyle for custom properties. For now, custom properties are always inherited, so the
data is in StyleRareInheritedData.

LayoutTests:

• fast/css/custom-properties: Added.
• fast/css/custom-properties/computed-style-access-expected.html: Added.
• fast/css/custom-properties/computed-style-access-inherited-expected.html: Added.
• fast/css/custom-properties/computed-style-access-inherited.html: Added.
• fast/css/custom-properties/computed-style-access.html: Added.
• fast/css/custom-properties/inline-style-property-get-expected.html: Added.
• fast/css/custom-properties/inline-style-property-get.html: Added.
• fast/css/custom-properties/rule-property-get-css-value-expected.html: Added.
• fast/css/custom-properties/rule-property-get-css-value.html: Added.
• fast/css/custom-properties/rule-property-get-expected.html: Added.
• fast/css/custom-properties/rule-property-get.html: Added.
• fast/css/custom-properties/rule-property-priority-expected.html: Added.
• fast/css/custom-properties/rule-property-priority.html: Added.
• fast/css/custom-properties/rule-property-set-expected.html: Added.
• fast/css/custom-properties/rule-property-set.html: Added.
• fast/css/custom-properties/rule-serialization-expected.html: Added.
• fast/css/custom-properties/rule-serialization.html: Added.

10:25 AM Changeset in webkit [190208] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Optimize Range's lengthOfContentsInNode() for DocumentType Nodes
​https://bugs.webkit.org/show_bug.cgi?id=149529

Reviewed by Darin Adler.

Optimize Range's lengthOfContentsInNode() for DocumentType Nodes:

• ​https://dom.spec.whatwg.org/#concept-node-length

We currently call Node::countChildNodes() unnecessarily on DocumentType
Nodes instead of simply returning 0.

• dom/Range.cpp:

(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContents):

10:00 AM Changeset in webkit [190207] by peavo@outlook.com

• 2 edits in trunk/Source/WebKit/win

[WinCairo] NULL pointer crash when trying to use tiled backing for frame view.
​https://bugs.webkit.org/show_bug.cgi?id=149523

Reviewed by Brent Fulgham.

For WinCairo, disable tiled backing for frame view.

• WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::shouldUseTiledBackingForFrameView):

9:32 AM Changeset in webkit [190206] by mitz@apple.com

• 2 edits in trunk/Tools

Build fix.

• WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:

8:55 AM Changeset in webkit [190205] by ChangSeok Oh

• 2 edits in trunk/Source/WebCore

Unreviewed, fix typo errors in a comment ("passed" -> "Passed", "Overwise" -> "Otherwise")

• css/mediaControlsGtk.css:

8:48 AM Changeset in webkit [190204] by ChangSeok Oh

• 2 edits in trunk/LayoutTests

Unreviewed, rebaseline media/media-controls-play-button-updates.html.

• platform/gtk/media/media-controls-play-button-updates-expected.txt:

8:39 AM Changeset in webkit [190203] by mark.lam@apple.com

• 2 edits in trunk/Tools

Unreviewed. Make Lucas Forschler a WebKit reviewer.

• Scripts/webkitpy/common/config/contributors.json:

7:56 AM Changeset in webkit [190202] by Gyuyoung Kim

• 17 edits in trunk/Source/WebCore

Reduce almost uses of PassRefPtr in Webcore/testing
​https://bugs.webkit.org/show_bug.cgi?id=149449

Reviewed by Darin Adler.

This patch removes all uses of PassRefPtr except for Internals::serializeObject() and Internals::deserializeObject().
It will be removed by upcoming patch.

• Modules/encryptedmedia/CDMSessionClearKey.cpp:

(WebCore::CDMSessionClearKey::generateKeyRequest):

• Modules/encryptedmedia/CDMSessionClearKey.h:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::jsTestOverrideBuiltinsPrototypeFunctionNamedItem):

• platform/graphics/CDMSession.h:
• platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

(WebCore::CDMSessionAVFoundationCF::generateKeyRequest):

• platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:
• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:

(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):

• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
• platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:

(WebCore::CDMSessionMediaSourceAVFObjC::generateKeyRequest):

• testing/InternalSettings.h:

(WebCore::InternalSettings::create):

• testing/Internals.cpp:

(WebCore::Internals::create):
(WebCore::Internals::computedStyleIncludingVisitedInfo):
(WebCore::Internals::markerRangeForNode):
(WebCore::Internals::rangeFromLocationAndLength):
(WebCore::Internals::subrange):
(WebCore::Internals::nodesFromRect):
(WebCore::Internals::mallocStatistics):
(WebCore::Internals::typeConversions):
(WebCore::Internals::memoryInfo):
(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):
(WebCore::Internals::createTimeRanges):

• testing/Internals.h:
• testing/MallocStatistics.h:

(WebCore::MallocStatistics::create):

• testing/MemoryInfo.h:

(WebCore::MemoryInfo::create):

• testing/MockCDM.cpp:

(WebCore::MockCDMSession::generateKeyRequest):

• testing/TypeConversions.h:

(WebCore::TypeConversions::create):

7:26 AM Changeset in webkit [190201] by rniwa@webkit.org

• 12 edits in trunk/Source

Ran sort-Xcode-project-file.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj:

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:

Source/WebInspectorUI:

• WebInspectorUI.xcodeproj/project.pbxproj:

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

• WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

• WTF.xcodeproj/project.pbxproj:

5:35 AM WebKitIDL edited by youenn.fablet@crf.canon.fr

(diff)

5:32 AM WebKitIDL edited by youenn.fablet@crf.canon.fr

(diff)

2:41 AM Changeset in webkit [190200] by ChangSeok Oh

• 5 edits
  5 adds in trunk

[GTK] playbutton in media controls is not changed when it is clicked.
​https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

• css/mediaControlsGtk.css:

(video::-webkit-media-controls-play-button.paused):

LayoutTests:

• media/media-controls-play-button-updates-expected.png: Added.
• media/media-controls-play-button-updates-expected.txt: Added.
• media/media-controls-play-button-updates.html: Added.
• platform/efl/TestExpectations: Skip the test.
• platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
• platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
• platform/mac/TestExpectations: Skip the test on yosemite.

2:24 AM Changeset in webkit [190199] by Carlos Garcia Campos

• 10 edits in trunk

Unreviewed. Fix GObject DOM API breaks after r190120.

Source/WebCore:

EntityReference has been removed from the DOM spec. Generate an
empy GObject implementation to keep API and ABI
compatibility. also add a deprecated impementation for the methods
using WebKitEntityReference.

• PlatformGTK.cmake: Do not generate bindings for EntityReference.idl.
• bindings/gobject/WebKitDOMDeprecated.cpp:

(webkit_dom_entity_reference_init):
(webkit_dom_entity_reference_class_init):
(webkit_dom_node_iterator_get_expand_entity_references):
(webkit_dom_tree_walker_get_expand_entity_references):
(webkit_dom_document_create_entity_reference):

• bindings/gobject/WebKitDOMDeprecated.h:
• bindings/gobject/WebKitDOMDeprecated.symbols:
• bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Remove FIXME.

• dom/Document.idl: Do not generate createEntityReference for GObject.
• dom/EntityReference.idl: Do not generate empty files for GObject.

Tools:

Bring back code removed in r169931 to handle documentation of
deleted classes.

• gtk/webkitdom.py:

(WebKitDOMDocGenerator):
(WebKitDOMDocGenerator.write_deleted_classes):
(WebKitDOMDocGenerator.generate):
(write_deleted_classes):
(WebKitDOMDocGeneratorSections._deleted_class):
(WebKitDOMDocGeneratorSections._deleted_class.in):
(WebKitDOMDocGeneratorSections.write_deleted_classes):
(WebKitDOMDocGeneratorSections.write_deleted_classes.with):

2:18 AM Changeset in webkit [190198] by youenn.fablet@crf.canon.fr

• 37 edits
  1 add
  1 delete in trunk/Source

[Streams API] Add support for JS builtins constructor
​https://bugs.webkit.org/show_bug.cgi?id=149497

Reviewed by Darin Adler.

Source/JavaScriptCore:

• runtime/JSFunction.h: exporting createBuiltinFunction.

Source/WebCore:

Covered by existing tests.

Making CountQueuingStrategy fully JS built-in implemented.
Adding support for calling a JS builtin initialization function just after creating the JSXX object.
This JS function must be named initializeXX and be in XX.Js file.
The JSBuiltinConstructor keyword is added to the binding generator.

• CMakeLists.txt: Adding CountQueuingStrategy.js, removing JSCountQueuingStrategyCustom.cpp.
• DerivedSources.cpp: Ditto.
• DerivedSources.make: Ditto.
• Modules/streams/CountQueuingStrategy.h: Making CountQueuingStrategy a dummy class.

(WebCore::CountQueuingStrategy::create):
(WebCore::CountQueuingStrategy::~CountQueuingStrategy):
(WebCore::CountQueuingStrategy::CountQueuingStrategy):

• Modules/streams/CountQueuingStrategy.idl:
• Modules/streams/CountQueuingStrategy.js: Added.

(size):
(initializeCountQueuingStrategy):

• WebCore.vcxproj/WebCore.vcxproj: Removing JSCountQueuingStrategyCustom.cpp.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• bindings/js/JSBindingsAllInOne.cpp: Ditto.
• bindings/js/JSCountQueuingStrategyCustom.cpp: Removed.
• bindings/js/JSDOMBinding.cpp: Adding support for DOMConstructorJSBuiltinObject.

(WebCore::callInitializeFunction):
(WebCore::DOMConstructorJSBuiltinObject::visitChildren):

• bindings/js/JSDOMBinding.h: Diitto.

(WebCore::createFromJSBuiltin):
(WebCore::DOMConstructorJSBuiltinObject::DOMConstructorJSBuiltinObject):

• bindings/js/WebCoreJSClientData.h: Adding support for CQS builtins functions.

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::countQueuingStrategyBuiltins):

• bindings/scripts/CodeGeneratorJS.pm:

(GetJSBuiltinFunctionName):
(GetFunctionName):
(InstanceNeedsVisitChildren): Generating visitChildren method in case of JSBuiltinConstructor.
(GetParentConstructorClassName): Refactoring to make JSXXConstructor derive from DOMConstructorJSBuiltinObject in case of JSBuiltinConstructor.
(GenerateConstructorDeclaration): Ditto.
(GenerateConstructorDefinition): Generate specific constructor in case of JSBuiltinConstructor.
(GenerateConstructorHelperMethods): Refactoring to use Base class.
(IsConstructable): Ditto.
(ConstructorHasProperties): Deleted.

• bindings/scripts/IDLAttributes.txt: Adding JSBuiltinConstructor.
• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::JSTestActiveDOMObjectConstructor):

• bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallbackConstructor::JSTestCallbackConstructor):

• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::JSTestCustomConstructorWithNoInterfaceObjectConstructor):

• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::JSTestCustomNamedGetterConstructor):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::JSTestEventConstructorConstructor):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::JSTestEventTargetConstructor):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::JSTestGenerateIsReachableConstructor):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::JSTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructorNamedConstructor::JSTestNamedConstructorNamedConstructor):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::JSTestNodeConstructor):

• bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicConstructor::JSTestNondeterministicConstructor):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::JSTestObjConstructor):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::JSTestOverloadedConstructorsConstructor):

• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::JSTestOverrideBuiltinsConstructor):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::JSTestTypedefsConstructor):

• bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeConstructor::JSattributeConstructor):

• bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyConstructor::JSreadonlyConstructor):