Timeline



Oct 5, 2015:

11:54 PM Changeset in webkit [190609] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL Gardening
https://bugs.webkit.org/show_bug.cgi?id=149830

Remove "--lint-test-files warnings".

Patch by Byung Jun Kim <bj1987.kim@samsung.com> on 2015-10-05

  • platform/efl/TestExpectations:
11:20 PM Changeset in webkit [190608] by youenn.fablet@crf.canon.fr
  • 20 edits
    1 copy
    5 adds
    8 deletes in trunk

Migrate streams API to JS Builtins
https://bugs.webkit.org/show_bug.cgi?id=147092

Reviewed by Darin Adler.

Source/WebCore:

Moved ReadableStream implementation from C++ to JS Builtins.
Created specific private constructors for ReadableStreamReader and ReadableStreamController.
Added these constructors to JSDOMWindowBase.
Constructors are based on a template found in JSDOMConstructor which might serve to webidl-generated classes as well.

Covered by existing tests.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/streams/ReadableStream.cpp: Removed.
  • Modules/streams/ReadableStream.h: Removed.
  • Modules/streams/ReadableStream.idl:
  • Modules/streams/ReadableStream.js:

(strategy.size):
(initializeReadableStream):
(cancel):
(getReader):
(pipeTo):
(tee):
(locked):

  • Modules/streams/ReadableStreamController.h:
  • Modules/streams/ReadableStreamController.idl:
  • Modules/streams/ReadableStreamController.js: Added.

(enqueue):
(error):
(close):
(desiredSize):

  • Modules/streams/ReadableStreamInternals.js:

(privateInitializeReadableStreamReader):
(privateInitializeReadableStreamController):
(isReadableStream):
(isReadableStreamReader):
(isReadableStreamController):
(errorReadableStream):
(requestReadableStreamPull):
(getReadableStreamDesiredSize):
(releaseReadableStreamReader):
(cancelReadableStream):
(finishClosingReadableStream):
(closeReadableStream):
(closeReadableStreamReader):
(enqueueInReadableStream):
(readFromReadableStreamReader):
(invokeOrNoop):
(promiseInvokeOrNoop):

  • Modules/streams/ReadableStreamReader.cpp: Removed.
  • Modules/streams/ReadableStreamReader.h:
  • Modules/streams/ReadableStreamReader.idl:
  • Modules/streams/ReadableStreamReader.js: Copied from Source/WebCore/Modules/streams/ReadableStream.js.

(cancel):
(read):
(releaseLock):
(closed):

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDOMConstructor.h: Added.

(WebCore::JSBuiltinConstructor::create):
(WebCore::JSBuiltinConstructor::createStructure):
(WebCore::JSBuiltinConstructor::JSBuiltinConstructor):
(WebCore::JSBuiltinConstructor::initializeProperties):
(WebCore::JSBuiltinConstructor<JSClass>::finishCreation):
(WebCore::JSBuiltinConstructor<JSClass>::construct):
(WebCore::JSBuiltinConstructor<JSClass>::getConstructData):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::finishCreation):

  • bindings/js/JSReadableStreamControllerCustom.cpp: Removed.
  • bindings/js/JSReadableStreamCustom.cpp: Removed.
  • bindings/js/JSReadableStreamPrivateConstructors.cpp: Added.

(WebCore::constructJSReadableStreamController):
(WebCore::constructJSReadableStreamReader):
(WebCore::JSBuiltinConstructor<JSReadableStreamReader>::createJSObject):
(WebCore::JSBuiltinConstructor<JSReadableStreamController>::createJSObject):
(WebCore::JSBuiltinReadableStreamReaderPrivateConstructor::createInitializeFunction):
(WebCore::JSBuiltinReadableStreamControllerPrivateConstructor::createInitializeFunction):
(WebCore::createReadableStreamReaderPrivateConstructor):
(WebCore::createReadableStreamControllerPrivateConstructor):

  • bindings/js/JSReadableStreamPrivateConstructors.h: Added.
  • bindings/js/JSReadableStreamReaderCustom.cpp: Removed.
  • bindings/js/ReadableJSStream.cpp: Removed.
  • bindings/js/ReadableJSStream.h: Removed.
  • bindings/js/WebCoreBuiltinNames.h: Added.

(WebCore::WebCoreBuiltinNames::WebCoreBuiltinNames):

  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData):
(WebCore::WebCoreJSClientData::builtinNames):
(WebCore::WebCoreJSClientData::readableStreamControllerBuiltins):
(WebCore::WebCoreJSClientData::readableStreamReaderBuiltins):

LayoutTests:

Rebasing some tests, one subtest passing, two others still failing but with different reasons.

  • streams/reference-implementation/brand-checks-expected.txt:
  • streams/reference-implementation/readable-stream-reader-expected.txt:
11:15 PM Changeset in webkit [190607] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190599.
https://bugs.webkit.org/show_bug.cgi?id=149836

Made perf tests randomly crash (Requested by ap on #webkit).

Reverted changeset:

"GC shouldn't cancel every FTL compilation"
https://bugs.webkit.org/show_bug.cgi?id=149821
http://trac.webkit.org/changeset/190599

10:51 PM Changeset in webkit [190606] by commit-queue@webkit.org
  • 57 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190589.
https://bugs.webkit.org/show_bug.cgi?id=149833

Caused lots of leaks, and possibly crashes (Requested by ap on
#webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190589

10:43 PM Changeset in webkit [190605] by Chris Dumez
  • 3 edits
    2 adds in trunk

data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update the HTMLPreloadScanner so that data: URLs do not get preloaded.
There is no need as the data is already available.

Test: fast/preloader/image-data-url.html

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

LayoutTests:

Add layout test to make sure that images with a data: URL do not
get preloaded.

  • fast/preloader/image-data-url-expected.txt: Added.
  • fast/preloader/image-data-url.html: Added.
9:13 PM Changeset in webkit [190604] by jer.noble@apple.com
  • 19 edits in trunk

[iOS] REGRESSION(r190434): Media continues to play when locking screen
https://bugs.webkit.org/show_bug.cgi?id=149822

Reviewed by Brent Fulgham.

Source/WebCore:

In MediaSessionManagerIOS.mm, both -applicationWillEnterForeground: and
-applicationDidBecomeActive: called
PlatformMediaSessionManager::applicationWillEnterForeground(), leading to the
PlatformMediaSession's m_interruptionCount becoming increasingly unbalanced.

Rename PlatformMediaSessionManager::applicationWillEnterForeground() to
applicationDidEnterForeground() to more correctly reflect when this notification will be
called. Add a new method, MediaSessionManagerIOS::applicationWillEnterForeground(bool),
whose paramater is whether the screen was locked. This allows the beginInterruption() and
endInterruption() methods to be correctly balanced.

Drive-by fix: remove the unimplemented declarations for application{will,did}Enter{Fore,Back}ground()
from PlatformMediaSession.h.

  • platform/audio/PlatformMediaSession.h:
  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationDidEnterForeground):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground): Deleted.

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::applicationDidEnterBackground):
(WebCore::MediaSessionManageriOS::applicationWillEnterForeground):
(-[WebMediaSessionHelper applicationWillEnterForeground:]):
(-[WebMediaSessionHelper applicationDidBecomeActive:]):

  • testing/Internals.cpp:

(WebCore::Internals::applicationDidEnterForeground):
(WebCore::Internals::applicationWillEnterForeground): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Pass through isSuspendedUnderLock when notifying the WebPage that the
applicationWillEnterForeground, and pass that boolean in the userInfo of the
WebUIApplicationWillEnterForegroundNotification.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationWillEnterForeground):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationWillEnterForeground):

LayoutTests:

applicationWillEnterForeground() -> applicationDidEnterForeground().

  • media/video-background-playback-expected.txt:
  • media/video-background-playback.html:
  • media/video-background-tab-playback-expected.txt:
  • media/video-background-tab-playback.html:
8:00 PM Changeset in webkit [190603] by Nikita Vasilyev
  • 2 edits in trunk/Websites/webkit.org

Modify the image to fit the width of the blog.

  • blog-files/web-inspector-keyboard-shortcuts/debugger-shortcuts.png:
7:47 PM Changeset in webkit [190602] by achristensen@apple.com
  • 3 edits
    3 adds in trunk

Invalid CSS Selector for Content Blockers invalidates others
https://bugs.webkit.org/show_bug.cgi?id=148446
rdar://problem/22918235

Reviewed by Benjamin Poulain.

Source/WebCore:

Test: http/tests/contentextensions/invalid-selector.html

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::isValidSelector):
(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::loadRule):
Add a check to see if a selector is valid before adding it.

LayoutTests:

  • http/tests/contentextensions/invalid-selector-expected.txt: Added.
  • http/tests/contentextensions/invalid-selector.html: Added.
  • http/tests/contentextensions/invalid-selector.html.json: Added.
6:59 PM Changeset in webkit [190601] by ggaren@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Remove a few includes from JSGlobalObject.h
https://bugs.webkit.org/show_bug.cgi?id=148004

Reviewed by Saam Barati.

  • parser/VariableEnvironment.cpp:
  • parser/VariableEnvironment.h:
  • runtime/JSGlobalObject.h:
  • runtime/JSString.cpp:

(JSC::JSString::createStructure):
(JSC::JSRopeString::RopeBuilder::expand):

  • runtime/JSString.h:

(JSC::JSString::canGetIndex):
(JSC::JSString::offsetOfLength):
(JSC::JSString::offsetOfFlags):
(JSC::JSString::createStructure): Deleted.

  • runtime/Structure.h:
  • runtime/StructureInlines.h:
  • runtime/StructureRareDataInlines.h:
6:57 PM Changeset in webkit [190600] by Nikita Vasilyev
  • 1 edit
    6 adds in trunk/Websites/webkit.org

Add more assets for Web Inspector Keyboard Shortcuts blog post.

  • blog-files/web-inspector-keyboard-shortcuts/icon-disable.png: Added.
  • blog-files/web-inspector-keyboard-shortcuts/icon-play.png: Added.
  • blog-files/web-inspector-keyboard-shortcuts/icon-step-in.png: Added.
  • blog-files/web-inspector-keyboard-shortcuts/icon-step-out.png: Added.
  • blog-files/web-inspector-keyboard-shortcuts/icon-step-over.png: Added.
  • blog-files/web-inspector-keyboard-shortcuts/search.png: Added.
6:33 PM Changeset in webkit [190599] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GC shouldn't cancel every FTL compilation
https://bugs.webkit.org/show_bug.cgi?id=149821

Reviewed by Saam Barati.

During one of the CodeBlock GC refactorings, we messed up the GC's compilation cancellation
code. The GC should be able to cancel compilation plans if it determines that the plan will
be DOA. But, prior to this fix, that code was killing every FTL compilation. This happened
because the meaning of CodeBlock::isKnownToBeLiveDuringGC() changed.

It's funny that this didn't show up as a bigger slow-down. Basically, those benchmarks that
GC a lot usually don't rely on good compilation, while those benchmarks that do rely on good
compilation usually don't GC a lot. That's probably why this wasn't super obvious when we
broke it.

This change just changes the cancellation logic so that it only cancels plans if the owning
executable is dead. This is safe; in fact the relevant method would be correct even if it
always returned true. It would also be correct if it always returned false. So, compared to
what we had before we changed isKnownToBeLiveDuringGC(), this new code will cancel fewer
compilations. But, that's better than cancelling every compilation. I've filed a bug and
written a FIXME for investigating ways to resurrect the old behavior:
https://bugs.webkit.org/show_bug.cgi?id=149823

Nonetheless, this change looks like it might be a 1% speed-up on Octane. It improves earley
and gbemu.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::isKnownToBeLiveDuringGC):

6:31 PM Changeset in webkit [190598] by Nikita Vasilyev
  • 1 edit
    8 adds in trunk/Websites/webkit.org

Add assets for Web Inspector Keyboard Shortcuts blog post.

  • blog-files/web-inspector-keyboard-shortcuts/clear-console.png: Added.
  • blog-files/web-inspector-keyboard-shortcuts/console-filters.m4v: Added.
  • blog-files/web-inspector-keyboard-shortcuts/debugger-shortcuts.png: Added.
  • blog-files/web-inspector-keyboard-shortcuts/hide-element.m4v: Added.
  • blog-files/web-inspector-keyboard-shortcuts/select-next-and-previous-tabs.m4v: Added.
  • blog-files/web-inspector-keyboard-shortcuts/toggle-split-console.m4v: Added.
  • blog-files/web-inspector-keyboard-shortcuts/tooltips.gif: Added.
6:22 PM Changeset in webkit [190597] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSSGradientValue should check whether gradientLength is zero or not.
https://bugs.webkit.org/show_bug.cgi?id=149373
<rdar://problem/22771418>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Darin Adler.

Source/WebCore:

This is a merge of Blink r158220,
https://chromiumcodereview.appspot.com/24350008

Test: fast/gradients/css3-repeating-radial-gradients-crash.html

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
Check whether gradientLength > 0 before using it as denominator.

LayoutTests:

  • fast/gradients/css3-repeating-radial-gradients-crash-expected.txt: Added.
  • fast/gradients/css3-repeating-radial-gradients-crash.html: Added.
6:09 PM Changeset in webkit [190596] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Get rid of some dead code
https://bugs.webkit.org/show_bug.cgi?id=149825

Reviewed by Tim Horton.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::didDraw): Deleted.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didDraw): Deleted.

  • UIProcess/WebPageProxy.h:
6:05 PM Changeset in webkit [190595] by dino@apple.com
  • 4 edits
    2 adds in trunk

EXT_texture_filter_anisotropic extension exposed with WEBKIT_ prefix
https://bugs.webkit.org/show_bug.cgi?id=149765
<rdar://problem/22983722>

Reviewed by Beth Dakin.

Source/WebCore:

We can now remove the WEBKIT_ prefix from this extension.

Test: fast/canvas/webgl/unprefixed-anisotropic-extension.html

  • html/canvas/WebGL2RenderingContext.cpp: Support the prefixed and unprefixed form.

(WebCore::WebGL2RenderingContext::getExtension):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

LayoutTests:

Simple test that the unprefixed form exists. The actual functionality
is exercised in the WebGL conformance tests.

  • fast/canvas/webgl/unprefixed-anisotropic-extension-expected.txt: Added.
  • fast/canvas/webgl/unprefixed-anisotropic-extension.html: Added.
5:27 PM Changeset in webkit [190594] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit2

Prospective Mavericks build fix.

Unreviewed.

  • UIProcess/API/cpp/WKRetainPtr.h:
4:45 PM Changeset in webkit [190593] by mmaxfield@apple.com
  • 5 edits in trunk

REGRESSION(189668?): http/tests/notifications/events.html flakily asserts or times out
https://bugs.webkit.org/show_bug.cgi?id=149218

Reviewed by Alexey Proskuryakov.

Tools:

Because of r189668, WebKitTestRunner now tears down and recreates its WKNotificationManagerRef
when the TestOptions change. Previously, WebNotificationProvider only could handle a single
WKNotificationManagerRef. Because the ower of the WKNotificationManagerRef is reference counted,
and AppKit internally retains some objects which end up retaining the WKNotificationManagerRef,
the old WKNotificationManager may not be destroyed before the new one is created. Therefore,
WebNotificationProvider must be updated to appropriately handle multiple
WKNotificationManagerRefs in flight at the same time.

  • WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::~WebNotificationProvider):
(WTR::WebNotificationProvider::showWebNotification):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::addNotificationManager):
(WTR::WebNotificationProvider::removeNotificationManager):
(WTR::WebNotificationProvider::simulateWebNotificationClick):
(WTR::WebNotificationProvider::reset):

  • WebKitTestRunner/WebNotificationProvider.h:

LayoutTests:

4:43 PM Changeset in webkit [190592] by dino@apple.com
  • 3 edits
    2 adds in trunk

Reference cycles during SVG dependency invalidation
https://bugs.webkit.org/show_bug.cgi?id=149824
<rdar://problem/22771412>

Reviewed by Tim Horton.

Source/WebCore:

Detect any reference cycles as we are invalidating.

This is mostly a merge of the following Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

Test: svg/custom/reference-cycle.svg

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies): Keep around a hash
table of dependencies, so that we can detect if an element is already
present before marking it.

LayoutTests:

Adding a test that has a cycle between feImage resources.

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

  • svg/custom/reference-cycle-expected.txt: Added.
  • svg/custom/reference-cycle.svg: Added.
4:36 PM Changeset in webkit [190591] by Sukolsak Sakshuwong
  • 6 edits in trunk/Source/JavaScriptCore

[Intl] Change the return type of canonicalizeLocaleList() from JSArray* to Vector<String>
https://bugs.webkit.org/show_bug.cgi?id=149807

Reviewed by Benjamin Poulain.

From ECMA-402, 9.2.1, the abstract operation CanonicalizeLocaleList
returns a List of Strings. From the spec, we never modify the result
from CanonicalizeLocaleList(). We never expose it to the user either.
This patch changes the return type of canonicalizeLocaleList() from
JSArray* to Vector<String>. This should ease the workload of the GC and
make the code a bit easier to read.

  • runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructorFuncSupportedLocalesOf):

  • runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf):

  • runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf):

  • runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList):
(JSC::lookupSupportedLocales):
(JSC::bestFitSupportedLocales):
(JSC::supportedLocales):

  • runtime/IntlObject.h:
4:36 PM Changeset in webkit [190590] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Marking compositing/video/video-poster.html as flaky for El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=149819
<rdar://problem/16622896> ASSERT(!needsLayout()) at com.apple.WebCore: WebCore::RenderView::paint

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-05
Reviewed by Simon Fraser.

  • platform/mac-elcapitan/TestExpectations: Added.
4:31 PM Changeset in webkit [190589] by ggaren@apple.com
  • 57 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the leak was VM shutdown, which happens in workers.

The fix is for CodeBlockSet to participate in lastChanceToFinalize,
since it's responsible for running CodeBlock destructors.

I ran the leaks tests locally and did not see any CodeBlock-related leaks.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

4:28 PM Changeset in webkit [190588] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Fix null pointer dereference in WebSocket::connect()
https://bugs.webkit.org/show_bug.cgi?id=149311
<rdar://problem/22748858>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r187441,
https://codereview.chromium.org/785933005

Test: http/tests/websocket/construct-in-detached-frame.html

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
Call function implemented below instead of duplicating the code.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::shouldBypassMainWorldContentSecurityPolicy):

  • page/ContentSecurityPolicy.h:

Factor the logic to check shouldBypassMainWorldContentSecurityPolicy into
a function in this class. Check Frame pointers are not null before getting
shouldBypassMainWorldContentSecurityPolicy via those pointers.

  • page/EventSource.cpp:

(WebCore::EventSource::create):
This got fixed as a bonus.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
This got fixed as a bonus too.

LayoutTests:

  • http/tests/websocket/construct-in-detached-frame-expected.txt: Added.
  • http/tests/websocket/construct-in-detached-frame.html: Added.
  • http/tests/websocket/resources/construct-in-detached-frame.html: Added.
4:17 PM Changeset in webkit [190587] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

WebCore::IOSurface should ask the IOSurface for the pixel format instead of
caching it
https://bugs.webkit.org/show_bug.cgi?id=149820
-and corresponding-
rdar://problem/22976230

Reviewed by Tim Horton.

Also there is no reason to make YUV be iOS only, so this patch removes those
PLATFORM checks.

  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::IOSurface):
(IOSurface::format):

  • platform/spi/cocoa/IOSurfaceSPI.h:
4:13 PM Changeset in webkit [190586] by ap@apple.com
  • 2 edits
    1 copy in trunk/LayoutTests

Revert LayoutTests parts of r190579, which were incorrect.

  • svg/custom/invalid-xslt-crash-expected.txt: Copied from LayoutTests/svg/custom/invalid-xslt-crash-expected.txt.
  • svg/custom/invalid-xslt-crash.svg:
3:49 PM Changeset in webkit [190585] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

ShadowRoot with leading or trailing white space cause a crash
https://bugs.webkit.org/show_bug.cgi?id=149782

Reviewed by Chris Dumez.

Source/WebCore:

Fixed the crash by adding a null pointer check since a TextNode that appears as a direct child
of a ShadowRoot doesn't have a parent element.

Test: fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html

  • style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::previousSiblingRenderer):

LayoutTests:

Added a regression test.

  • fast/shadow-dom/shadow-root-with-child-whitespace-text-crash-expected.txt: Added.
  • fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html: Added.
3:35 PM Changeset in webkit [190584] by dbates@webkit.org
  • 2 edits in trunk/Tools

Disable Bitcode when building for iOS device
https://bugs.webkit.org/show_bug.cgi?id=149818

Reviewed by Alexey Proskuryakov.

Xcode 7 generates bitcode for iOS device apps by default. Do not generate bitcode
when building for iOS device.

  • Scripts/webkitdirs.pm:

(XcodeOptions):

3:30 PM Changeset in webkit [190583] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] Make it possible to build WebKit using iphoneos SDK without a developer certificate installed
https://bugs.webkit.org/show_bug.cgi?id=140828
<rdar://problem/19520599>

Reviewed by Alexey Proskuryakov.

Support building WebKit for iOS device without an iOS Developer certificate installed. Otherwise,
we will pass CODE_SIGN_IDENTITY="iPhone Developer: " to Xcode to find a iOS Developer certificate
to use. To use a specific installed iOS Developer certificate, explicitly pass CODE_SIGN_IDENTITY
to build-webkit.

  • Scripts/webkitdirs.pm:

(XcodeOptions): Cleaned up code. When building for iOS device, pass to Xcode CODE_SIGN_IDENTITY="iPhone Developer: "
to code sign using the installed iOS development certificate (if it exists - we assume there is only one such certificate).
Otherwise, pass CODE_SIGN_IDENTITY="" and CODE_SIGNING_REQUIRED=NO to Xcode to disable code signing.
(hasIOSDevelopmentCertificate): Added.

3:16 PM Changeset in webkit [190582] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/spi/cocoa/IOSurfaceSPI.h:
3:13 PM Changeset in webkit [190581] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/spi/cocoa/IOSurfaceSPI.h:
2:29 PM Changeset in webkit [190580] by beidson@apple.com
  • 5 edits in trunk/Source/WebCore

Modernize IDBRequest::ReadyState into an enum class.
https://bugs.webkit.org/show_bug.cgi?id=149817

Reviewed by Alex Christensen.

No new tests (Refactor, no behavior change).

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/legacy/LegacyOpenDBRequest.cpp:

(WebCore::LegacyOpenDBRequest::shouldEnqueueEvent):

  • Modules/indexeddb/legacy/LegacyRequest.cpp:

(WebCore::LegacyRequest::LegacyRequest):
(WebCore::LegacyRequest::result):
(WebCore::LegacyRequest::error):
(WebCore::LegacyRequest::errorCode):
(WebCore::LegacyRequest::readyState):
(WebCore::LegacyRequest::markEarlyDeath):
(WebCore::LegacyRequest::abort):
(WebCore::LegacyRequest::setCursorDetails):
(WebCore::LegacyRequest::setPendingCursor):
(WebCore::LegacyRequest::setResultCursor):
(WebCore::LegacyRequest::finishCursor):
(WebCore::LegacyRequest::shouldEnqueueEvent):
(WebCore::LegacyRequest::stop):
(WebCore::LegacyRequest::dispatchEvent):
(WebCore::LegacyRequest::transactionDidFinishAndDispatch):
(WebCore::LegacyRequest::enqueueEvent):

  • Modules/indexeddb/legacy/LegacyRequest.h:
2:21 PM Changeset in webkit [190579] by commit-queue@webkit.org
  • 5 edits
    1 delete in trunk

Cleaning up after revision 190339
https://bugs.webkit.org/show_bug.cgi?id=149732

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Myles C. Maxfield.

Source/WebCore:

  • xml/XSLStyleSheet.h:
  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::compileStyleSheet):

LayoutTests:

  • svg/custom/invalid-xslt-crash.svg:
  • svg/custom/invalid-xslt-crash-expected.txt:

Replace render tree dump test with text dump.
Pass if no crash.

1:57 PM Changeset in webkit [190578] by dbates@webkit.org
  • 4 edits in trunk

DumpRenderTree built with public iOS SDK crashes under -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
https://bugs.webkit.org/show_bug.cgi?id=149766

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

Assert that we have a non-null pointer to a cookie storage.

  • WebView/WebPreferences.mm:

(+[WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]):

Tools:

Create network storage testing session on iOS.

Currently we do not create a network storage testing session on iOS. A network storage testing session always
has an associated cookie store. When WebKit is built without USE(CFNETWORK), NetworkStorageSession::defaultStorageSession().cookieStorage()
returns nullptr because the caller is expected to interact with NSHTTPCookieStorage instead of querying
NetworkStorageSession for the cookie store. When WebKit is built with USE(CFNETWORK) accessing
NetworkStorageSession::defaultStorageSession().cookieStorage() returns a valid cookie store (creating one if
it does not exist). Instead we should make use of NetworkStorageSession::switchToNewTestingSession() to
create a network storage testing session when building DumpRenderTree for iOS so as to ensure a consistent
testing environment regardless of whether we built with USE(CFNETWORK). This will also make the behavior of
DumpRenderTree on iOS more consistent with the behavior of DumpRenderTree on Mac.

As a side effect of this change DumpRenderTree no longer crashes in -[WebPreferences(WebPrivate) _setCurrentNetworkLoaderSessionCookieAcceptPolicy:]
when WebKit is built without USE(CFNETWORK) because NetworkStorageSession::defaultStorageSession().cookieStorage()
returns a non-null pointer to a cookie store.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(prepareConsistentTestingEnvironment):

1:52 PM Changeset in webkit [190577] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Rebaseline test for iOS

  • platform/ios-simulator/fast/text/mark-matches-overflow-clip-expected.txt:
1:46 PM Changeset in webkit [190576] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Errant space!!

  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::releaseGraphicsContext):
(IOSurface::convertToFormat):

1:38 PM Changeset in webkit [190575] by commit-queue@webkit.org
  • 3 edits
    45 adds in trunk/PerformanceTests

Add a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149053
<rdar://problem/18984169>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-05
Reviewed by Dean Jackson.

Instead of measuring the FPS of the animation, this benchmark measures the
test complexity when rendering at a set-point FPS which should be lower
than 60 FPS. This benchmark tries to stay at the set-point FPS by using
a closed loop control system PID function. The gain of the system is passed
as a parameter when running the test. Measuring the FPS faithfully results
very fluctuating values. A Kalman filter is used to give a better estimate
for the current FPS.

The animation of the tests is done manually. requestAnimationFrame() is
called with a callback. Inside this callback, the test is animating by
changing the positions of the elements inside the page. The test complexity
may change also if the current FPS is not equal to the desired FPS.

In this patch, the benchmark and the tests are included. The shared code
and the tests runner are included in separate patches.

  • Animometer/runner/animometer.html:
  • Animometer/runner/resources/animometer.js:

Add two new examples for more complex animation techniques.
Add an option to show/hide the test running results which is off by default.

  • Animometer/runner/resources/tests.js: Added.

(suiteFromName): Returns a suite given its name.
(testFromName): Returns a test given its suite and name.

  • Animometer/tests: Added.

This directory includes all the test suites to be run by the benchmark.
runner. All the tests should try to run on three stages: CSS, canvas and
SVG.

  • Animometer/tests/bouncing-particles: Added.
  • Animometer/tests/bouncing-particles/resources: Added.

The bouncing particles test is an example of a simple animation technique.

  • Animometer/tests/bouncing-particles/bouncing-canvas-images.html: Added.
  • Animometer/tests/bouncing-particles/bouncing-canvas-shapes.html: Added.
  • Animometer/tests/bouncing-particles/bouncing-css-images.html: Added.
  • Animometer/tests/bouncing-particles/bouncing-css-shapes.html: Added.
  • Animometer/tests/bouncing-particles/bouncing-svg-images.html: Added.
  • Animometer/tests/bouncing-particles/bouncing-svg-shapes.html: Added.

Bouncing particles test pages.

  • Animometer/tests/bouncing-particles/resources/bouncing-particles.js: Added.

(BouncingParticle): Base class for a bouncing particle.
(BouncingParticle.prototype.center): Returns the center point or the particle.
(BouncingParticle.prototype.animate): Moves the particle based on its current position, angle and velocity.

(BouncingParticlesAnimator): A sub class of Animator.

(BouncingParticlesStage): Represents the container of all the bouncing particles.
(BouncingParticlesStage.prototype.parseShapeParamters): Gets the shape parameters for shape animating tests.
(BouncingParticlesStage.prototype.randomRotater): Creates a rotater for the particles.
(BouncingParticlesStage.prototype.animate): Animates all the particles.
(BouncingParticlesStage.prototype.tune): Changes the test by adding or removing particles.

(BouncingParticlesBenchmark): Runs the benchmark for bouncing particles test.
(BouncingParticlesBenchmark.prototype.createAnimator): Creates an animator of type BouncingParticlesAnimator.

  • Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js: Added.

(BouncingCssShape): A sub class of BouncingParticle for animating CSS shapes.
(BouncingCssShape.prototype._createSpan): Creates a <span> element and takes the shape and clipping classes into consideration.
(BouncingCssShape.prototype._move): Moves the particle to a new location. Apply transform since it does not require layout.
(BouncingCssShape.prototype.animate): Rotates and moves the shape to a new location.

(BouncingCssShapesStage): A sub class of BouncingParticlesStage for animating CSS shapes.
(BouncingCssShapesStage.prototype.createParticle): Creates a particle of type BouncingCssShape.
(BouncingCssShapesStage.prototype.particleWillBeRemoved): Removes the corresponding element form the parent children list.

(BouncingCssShapesBenchmark): A sub class of BouncingParticlesBenchmark for animating CSS shapes.
(BouncingCssShapesBenchmark.prototype.createStage): Creates a stage of type BouncingCssShapesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCssShapesBenchmark.

  • Animometer/tests/bouncing-particles/resources/bouncing-css-images.js: Added.

(BouncingCssImage): A sub class of BouncingParticle for animating CSS images.
(BouncingCssImage.prototype._move): Move the particle to a new location. Apply transform since it does not require layout.
(BouncingCssImage.prototype.animate): Rotates and moves the shape to a new location.

(BouncingCssImagesStage): A sub class of BouncingParticlesStage for animating CSS images.
(BouncingCssImagesStage.prototype.createParticle): Creates a particle of type BouncingCssImage.
(BouncingCssImagesStage.prototype.particleWillBeRemoved): Removes the corresponding element form the parent children list.

(BouncingCssImagesBenchmark): A sub class of BouncingParticlesBenchmark for animating CSS images.
(BouncingCssImagesBenchmark.prototype.createStage): Creates a stage of type BouncingCssImagesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCssImagesBenchmark.

  • Animometer/tests/bouncing-particles/resources/bouncing-canvas-particles.js: Added.

(BouncingCanvasParticle): A base sub-class of BouncingParticle for animating canvas particles.
(BouncingCanvasParticle.prototype._applyRotation): Apply the particle rotation-around-center transform to the canvas context.
(BouncingCanvasParticle.prototype._applyClipping): Apply the particle clipping to the canvas context.
(BouncingCanvasParticle.prototype._draw): A non-implemented version of the drawing function.
(BouncingCanvasParticle.prototype.animate): Carries out all the steps to redraw the canvas particle.

(BouncingCanvasParticlesStage): A base sub-class of BouncingParticlesStage for animating canvas particles.

(BouncingCanvasParticlesAnimator): A concrete sub-class of BouncingParticlesAnimator for animating canvas particles.
(BouncingCanvasParticlesAnimator.prototype.animate): Overrides the base class method to clear the canvas before redrawing the stage.

(BouncingCanvasParticlesBenchmark): A base sub-class of StageBenchmark for animating canvas particles.
(BouncingCanvasParticlesBenchmark.prototype.createAnimator): Creates the canvas particles animator.

  • Animometer/tests/bouncing-particles/resources/bouncing-canvas-shapes.js: Added.

(BouncingCanvasShape): A concrete sub-class of BouncingCanvasParticle for animating canvas shapes.
(BouncingCanvasShape.prototype._applyFill): Sets the fillStyle in the canvas context.
(BouncingCanvasShape.prototype._drawShape): Carries out the actual drawing.
(BouncingCanvasShape.prototype._draw): Carries out all the steps to draw the shape.

(BouncingCanvasShapesStage): A concrete sub-class of BouncingCanvasParticle for animating canvas shapes.
(BouncingCanvasShapesStage.prototype.createParticle): Creates a particle of type BouncingCanvasShape.

(BouncingCanvasShapesBenchmark): A concrete sub-class of BouncingCanvasParticlesBenchmark for animating canvas shapes.
(BouncingCanvasShapesBenchmark.prototype.createStage): Creates a stage of type BouncingCanvasShapesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCanvasShapesBenchmark.

  • Animometer/tests/bouncing-particles/resources/bouncing-canvas-images.js: Added.

(BouncingCanvasImage): A concrete sub-class of BouncingCanvasParticle for animating canvas images.
(BouncingCanvasImage.prototype._draw): Draws an image on the context of a canvas.

(BouncingCanvasImagesStage): A concrete sub-class of BouncingCanvasParticlesBenchmark for animating canvas images.
(BouncingCanvasImagesStage.prototype.createParticle): Creates a particle of type BouncingCanvasImage.

(BouncingCanvasImagesBenchmark): A concrete sub-class of BouncingCanvasParticlesBenchmark for animating canvas images.
(BouncingCanvasImagesBenchmark.prototype.createStage): Creates a stage of type BouncingCanvasImagesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingCanvasImagesBenchmark.

  • Animometer/tests/bouncing-particles/resources/bouncing-svg-particles.js: Added.

(BouncingSvgParticle): A base sub-class of BouncingParticle for animating SVG particles.
(BouncingSvgParticle.prototype._applyClipping): Apply the particle clipping by setting the 'clip-path' attribute of the SVGElement.
(BouncingSvgParticle.prototype._move): Moves the particle to a new location. Apply transform since it does not require layout.
(BouncingSvgParticle.prototype.animate): Rotates and moves the shape to a new location.
(BouncingSvgParticlesStage): A sub class of BouncingParticlesStage for animating SVGElements.
(BouncingSvgParticlesStage.prototype._createDefs): Creates an SVGDefsElement.
(BouncingSvgParticlesStage.prototype._ensureDefsIsCreated): Ensures there is only one SVGDefsElement is created.
(BouncingSvgParticlesStage.prototype._createClipStar): Creates an SVGClipPathElement and sets its 'd' attribute to a star like shape.
(BouncingSvgParticlesStage.prototype.ensureClipStarIsCreated): Ensure there is only one star SVGClipPathElement is created.
(BouncingSvgParticlesStage.prototype.particleWillBeRemoved): Remove the corresponding element form the parent children list.

  • Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js: Added.

(BouncingSvgShape): A concrete sub-class of BouncingSVGParticle for animating SVG shapes.
(BouncingSvgShape.prototype._createShape): Creates an SVG shape.
(BouncingSvgShape.prototype._applyFill): Applies the selected fill style to the SVG shape.

(BouncingSvgShapesStage): A concrete sub-class of BouncingSvgParticlesStage for animating SVG shapes.
(BouncingSvgShapesStage.prototype.createGradient): Creates an SVGLinearGradientElement.
(BouncingSvgShapesStage.prototype.createParticle): Creates a particle of type BouncingSvgShape.
(BouncingSvgShapesStage.prototype.particleWillBeRemoved): Ensures the attached SVGLinearGradientElement is removed from the SVGDefsElement.

(BouncingSvgShapesBenchmark): A concrete sub-class of BouncingParticlesBenchmark for animating SVG images.
(BouncingSvgShapesBenchmark.prototype.createStage): Creates a stage of type BouncingSvgShapesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingSvgShapesBenchmark.

  • Animometer/tests/bouncing-particles/resources/bouncing-svg-images.js: Added.

(BouncingSvgImage): A concrete sub-class of BouncingSVGParticle for animating SVG images.

(BouncingSvgImagesStage): A concrete sub-class of BouncingSVGParticlesBenchmark for animating SVG images.
(BouncingSvgImagesStage.prototype.createParticle): Creates a particle of type BouncingSvgImage.

(BouncingSvgImagesBenchmark): A concrete sub-class of BouncingParticlesBenchmark for animating SVG images.
(BouncingSvgImagesBenchmark.prototype.createStage): Creates a stage of type BouncingSvgImagesStage.
(window.benchmarkClient.create): Creates a benchmark of type BouncingSvgImagesBenchmark.

  • Animometer/tests/examples: Added.
  • Animometer/tests/examples/canvas-electrons.html: Added.
  • Animometer/tests/examples/canvas-stars.html: Added.

Examples test pages.

  • Animometer/tests/examples/resources: Added.
  • Animometer/tests/examples/resources/canvas-electrons.js: Added.

(CanvasElectron): An object which draws and animate a electron object on a canvas stage.
(CanvasElectron.prototype._draw): Draws the electron object.
(CanvasElectron.prototype.animate): Animates the electron object.

(CanvasElectronsStage): A concrete sub-class of Stage for animating electrons.
(CanvasElectronsStage.prototype.tune): Changes the test by adding or removing elements.
(CanvasElectronsStage.prototype.animate): Animates the test elements.

(CanvasElectronsAnimator): A concrete sub-class of StageAnimator for animating canvas electrons.
(CanvasElectronsAnimator.prototype.animate): Overrides the base class method to clear the canvas before redrawing the stage.

(CanvasElectronsBenchmark): A concrete sub-class of StageBenchmark for animating electrons.
(CanvasElectronsBenchmark.prototype.createStage): Creates a stage of CanvasElectronsStage.
(CanvasElectronsBenchmark.prototype.createAnimator): Creates an animator of type CanvasElectronsAnimator.
(window.benchmarkClient.create): Creates a benchmark of type CanvasElectronsBenchmark.

  • Animometer/tests/examples/resources/canvas-stars.js: Added.

(CanvasStar): An object which draws and animate a star object on a canvas stage.
(CanvasStar.prototype._draw): Draws the star object.
(CanvasStar.prototype.animate): Animates the star object.

(CanvasStarsStage): A concrete sub-class of Stage for animating stars.
(CanvasStarsStage.prototype.tune): Changes the test by adding or removing elements.
(CanvasStarsStage.prototype.animate): Animates the test elements.

(CanvasStarsAnimator): A concrete sub-class of StageAnimator for animating canvas stars.
(CanvasStarsAnimator.prototype.animate): Overrides the base class method to clear the canvas before redrawing the stage.

(CanvasStarsBenchmark): A concrete sub-class of Benchmark for animating stars.
(CanvasStarsBenchmark.prototype.createStage): Creates a stage of CanvasStarsStage.
(CanvasStarsBenchmark.prototype.createAnimator): Creates an animator of type CanvasStarsAnimator.
(window.benchmarkClient.create): Creates a benchmark of type CanvasStarsBenchmark.

  • Animometer/tests/resources: Added.

This directory includes the script which is required to run an adaptive
graphics benchmark. From an empty test page, the set of classes in this
directory are responsible for measuring the current frame rate and
changing the test to reach a desired FPS. It keeps asking the test page
to tune itself by a certain value to increase or decrease the frame rate.
It's also responsible for sampling the test state and the corresponding
frame rate.

  • Animometer/tests/resources/main.js: Added.

(BenchmarkState): Tracks the state of the benchmark test.
(BenchmarkState.prototype._timeOffset): Returns the timeOffset of a stage.
(BenchmarkState.prototype._message): Returns the message of a stage.
(BenchmarkState.prototype.update): Sets the currentTimeOffset to a new value.
(BenchmarkState.prototype.samplingTimeOffset): Returns the timeOffset of the sampling stage.
(BenchmarkState.prototype.currentStage): Returns the current stage of the benchmark.
(BenchmarkState.prototype.currentMessage): Returns the message of the current stage and timeOffset.
(BenchmarkState.prototype.currentProgress): Returns a percentage of how much the benchmark is running.

(Animator): Manages animating the test.
(Animator.prototype.start): Called if animating using setInterval is requested.
(Animator.prototype.timeDelta): Returns the current timeDelta
(Animator.prototype.animate): Manages the test animation.
(Animator.prototype.animateLoop): Called if animating using requestAnimationFrame is requested.

(Benchmark): Manages running the test benchmark and recording the sampled data.
(Benchmark.prototype.start): Starts the benchmark.
(Benchmark.prototype.update): Called from the animator.animate() to change the complexity of the test.
(Benchmark.prototype.record): Shows the current (not final) results of the benchmark.
(Benchmark.prototype.resolveWhenFinished): Spins until the benchmark is finished and returns its results.
(Benchmark.prototype.run): Starts the test, runs it, waits until it is finished and return its results.
(window.runBenchmark): Called from the benchmark runner through the suite controller run-callback.

  • Animometer/tests/resources/math.js: Added.

(Matrix): A matrix object.
(Vector3): A vector of size 3 object.
(Matrix3): A matrix of size 3x3 object.

(PIDController): Closed-loop controller for a set-point y.
(PIDController.prototype._sat): Limits the output to a certain range.
(PIDController.prototype.tune): Given the current output of a system, it produces a new pid value for tuning it.

(KalmanEstimator): Implement Kalman filter to get an estimate for a sampled data point.
(KalmanEstimator.prototype.estimate): Returns an estimate for for a sampled data point.

  • Animometer/tests/resources/utilities.js: Added.

(window.Utilities._parse): Given a separator character, it pareses a string to a set of <key, value> pairs.
(window.Utilities.parseParameters): Parses a test parameters.
(window.Utilities.parseArguments): Parses a tag arguments.
(window.Utilities.extendObject): Adds the attributes and their values of an object to another object.
(window.Utilities.copyObject): Copies the attributes and their values of an object to a new object.
(window.Utilities.mergeObjects): Copies the attributes and their values of two objects to a new object.
(window.Utilities.createSvgElement): Creates an SVGElement given its name and its attributes.

  • Animometer/tests/resources/stage.css: Added.
  • Animometer/tests/resources/stage.js: Added.

(Rotater): Manages rotating an angle within a fixed time interval.
(Rotater.prototype.get interval): Returns the time interval which is required to rotate 360 degrees.
(Rotater.prototype.next): Moves the current time by a delta.
(Rotater.prototype.degree): Returns the current rotating degree.
(Rotater.prototype.rotateZ): Returns CSS formatted transform rotateZ() string for the current degree.
(Rotater.prototype.rotate): Returns SVG formatted transform rotate() string for the current degree.

(Stage): A base class for managing the test complexity and test animation.
(Stage.prototype.get size): Returns the size of the stage excluding the CSS padding.
(Stage.prototype.random): Returns a random float.
(Stage.prototype.randomInt): Returns a random integer.
(Stage.prototype.randomPosition): Returns a random position.
(Stage.prototype.randomSquareSize): Returns a square size.
(Stage.prototype.randomVelocity): Returns a random velocity.
(Stage.prototype.randomAngle): Returns a random angle.
(Stage.prototype.randomColor): Returns a random color not too dark and not too light.
(Stage.prototype.randomRotater): Creates a random rotater. Its velocity depends on choosing a random rotation time interval.
(Stage.prototype.tune): A not-implemented version of this function.
(Stage.prototype.animate): A not-implemented version of this function.
(Stage.prototype.clear): Clears the stage from all its animation elements.

(StageAnimator): A base class for the stage-based animators.
(StageAnimator.prototype.animate): Calls Animator.animate() which updates the test page and then calls Stage.animate() to force redraw.

(StageBenchmark): A base class for the stage-based benchmarks.
(StageBenchmark.prototype.createStage): Creates the default stage.
(StageBenchmark.prototype.createAnimator): Creates the default animator.
(StageBenchmark.prototype.tune): Delegates the call to stage.
(StageBenchmark.prototype.clear): Delegates the call to stage.
(StageBenchmark.prototype.showResults): Shows the results/progress through its recordTable and progressBar.

  • Animometer/tests/resources/yin-yang.png: Added.
  • Animometer/tests/resources/yin-yang.svg: Added.

These images are shared among all the tests.

  • Animometer/tests/template: Added.
  • Animometer/tests/template/resources: Added.

This directory includes template tests which do nothing. They can be used
to author new tests. Animated items can be created, moved and redrawn by
removing the TODO comments in the script files and writing actual code.

  • Animometer/tests/template/template-css.html: Added.
  • Animometer/tests/template/template-canvas.html: Added.
  • Animometer/tests/template/template-svg.html: Added.

Template test pages. They can be used as they are. CSS attributes or hidden
elements can be added to these derived test pages if needed.

  • Animometer/tests/template/resources/template-css.js: Added.

(TemplateCssStage): A stage to create and animate HTMLElements.
(TemplateCssStage.prototype.tune): Changes the test by adding or removing elements.
(TemplateCssStage.prototype.animate): Animates the test elements.
(TemplateCssBenchmark):
(TemplateCssBenchmark.prototype.createStage): Creates the test stage.
(window.benchmarkClient.create): Creates a benchmark of type TemplateCssBenchmark.

  • Animometer/tests/template/resources/template-canvas.js: Added.

(TemplateCanvasObject):
(TemplateCanvasObject.prototype._draw): Draws the objects on the canvas context.
(TemplateCanvasObject.prototype.animate): Moves and redraws the object.
(TemplateCanvasStage): A stage to create and animate drawing elements.
(TemplateCanvasStage.prototype.tune): hanges the test by adding or removing elements.
(TemplateCanvasStage.prototype.animate): Animates the test elements.
(TemplateCanvasAnimator.prototype.animate): Starts the animation every frame.
(TemplateCanvasBenchmark):
(TemplateCanvasBenchmark.prototype.createStage): Creates a stage of type TemplateCanvasStage.
(TemplateCanvasBenchmark.prototype.createAnimator): Creates a animator of type TemplateCanvasAnimator.
(window.benchmarkClient.create): Creates a benchmark of type TemplateCanvasBenchmark.

  • Animometer/tests/template/resources/template-svg.js: Added.

(TemplateSvgStage): A stage to create and animate SVGElements.
(TemplateSvgStage.prototype.tune): Changes the test by adding or removing elements.
(TemplateSvgStage.prototype.animate): Animates the test elements.
(TemplateSvgBenchmark.prototype.createStage): Creates a stage of type TemplateSvgStage.
(window.benchmarkClient.create): Creates a benchmark of type TemplateSvgBenchmark.

  • Animometer/tests/text: Added.
  • Animometer/tests/text/resources: Added.

This directory includes the text animating tests which currently runs
on CSS stage only.

  • Animometer/tests/text/layering-text.html: Added.

Text test page.

  • Animometer/tests/text/resources/layering-text.js: Added.

(LayeringTextStage): Represents the container of all the stacked text layers.
(LayeringTextStage.parseTextItem): Parses a textItem which may be an opening tag, a closing tag or a self-closing tag.
(LayeringTextStage.isOpeningTextItem): Returns true if the textItem is an opening tag e.g. '<ol>'.
(LayeringTextStage.isClosingTextItem): Returns true if the textItem is an closing tag e.g. '</ol>.
(LayeringTextStage.textItemsFlags.LayeringTextStage.textItems.map): Calculates and stores isOpening and isClosing flags for each textItem.
(LayeringTextStage.isColorableTextItem): Returns true if the textItem is self-closing tag e.g. '<p>...</p>'.
(LayeringTextStage.isInsertableTextItem): Returns true if the textItems causes a new element to be added to the text layers.
(LayeringTextStage.colorableTextItems.LayeringTextStage.textItemsFlags.filter): Number of colorable textItems.
(LayeringTextStage.insertableTextItems.LayeringTextStage.textItemsFlags.filter): Number of insertable textItems.
(LayeringTextStage.colorIndexToTextElementIndex): Maps from colorIndex [0..colorableTextItems-1] to textElementIndex [0..insertableTextItems-1].
(LayeringTextStage.prototype._nextTextItem): Moves the _textItemIndex one step forward in a loop [0..LayeringTextStage.textItems.length-1].
(LayeringTextStage.prototype._previousTextItem): Moves the _textItemIndex one step backward in a loop.
(LayeringTextStage.prototype._pushTextElement): Creates a new textItemElement and adds it to the topmost container <div>.
(LayeringTextStage.prototype._popTextElement): Removes the last textItemElement from the topmost container <div>.
(LayeringTextStage.prototype._colorTextItem): Changes the background color of a single colorable textElement. The index advances in a circle [0..colorableTextItems-1].
(LayeringTextStage.prototype.animate): Changes the background color and the text color of the textElements such that a redraw is enforced.
(LayeringTextStage.prototype.tune): Adds or removes textElements to the stage.

(LayeringTextBenchmark): Runs the benchmark for the layering text test.
(LayeringTextBenchmark.prototype.createStage): Creates a stage of type LayeringTextStage.
(window.benchmarkClient.create): Creates a benchmark of type LayeringTextBenchmark.

1:35 PM Changeset in webkit [190574] by Beth Dakin
  • 7 edits in trunk/Source

Compress snapshots on iOS
https://bugs.webkit.org/show_bug.cgi?id=149814
-and corresponding-
rdar://problem/22976230

Reviewed by Simon Fraser.

Source/WebCore:

Though the default is still RGBA, it is now possible to create an IOSurface
that uses the YUV422 pixel format.

  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::surfaceFromPool):
(IOSurface::create):
(IOSurface::createFromImage):
(IOSurface::IOSurface):
(IOSurface::releaseGraphicsContext):

In order to have a YUV IOSurface, we actually have to create an RGBA surface
first and then convert it to YUV, so this class method will handle that.
(IOSurface::convertToFormat):

Necessary SPI.

  • platform/spi/cocoa/IOSurfaceSPI.h:

Source/WebKit2:

Compress the snapshot.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):

Since the snapshots are converted to YUV asynchronously, it is possible to
get here and have a snapshot that does not yet have an image, so we have to
relax this constraint.

  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):

1:33 PM Changeset in webkit [190573] by Simon Fraser
  • 2 edits in trunk/Tools

Fix the iOS 8 build again, where -[UIApplication _enqueueHIDEvent:] is not
available.

  • WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):

1:31 PM Changeset in webkit [190572] by mmaxfield@apple.com
  • 5 edits
    1 add in trunk

Allow WKRetainPtrs to be used as keys in hashing data structures
https://bugs.webkit.org/show_bug.cgi?id=149762

Reviewed by Anders Carlsson.

Source/WebKit2:

Use RefPtr as a model.

  • UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
(WebKit::WKRetainPtr::isHashTableDeletedValue):
(WebKit::WKRetainPtr::hashTableDeletedValue):
(WTF::HashTraits<WKRetainPtr<P>>::emptyValue):
(WTF::HashTraits<WKRetainPtr<P>>::peek):

Tools:

  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/WKRetainPtr.cpp: Added.

(TestWebKitAPI::TEST):

1:00 PM Changeset in webkit [190571] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Error displayed as an object when passed as a second argument to console.log
https://bugs.webkit.org/show_bug.cgi?id=149799

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
Don't format errors as objects.

(WebInspector.ConsoleMessageView.prototype._formatParameter):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsString):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsError):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsArray):
Replace an unnecessary span element with a document fragment.

  • UserInterface/Views/ErrorObjectView.css:

(.error-object):
Display an error object on the same line as a list bullet.

12:55 PM Changeset in webkit [190570] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Mark the line dirty when RenderQuote's text changes.
https://bugs.webkit.org/show_bug.cgi?id=149784
rdar://problem/22558169

Reviewed by Antti Koivisto.

When quotation mark changes ( " -> ' or empty string), we
need to mark the line dirty to ensure its content gets laid out properly.

Source/WebCore:

Test: fast/inline/quotation-text-changes-dynamically.html

  • rendering/RenderQuote.cpp:

(WebCore::quoteTextRenderer):
(WebCore::RenderQuote::updateText):
(WebCore::fragmentChild): Deleted.

LayoutTests:

  • fast/inline/quotation-text-changes-dynamically-expected.txt: Added.
  • fast/inline/quotation-text-changes-dynamically.html: Added.
12:35 PM Changeset in webkit [190569] by fpizlo@apple.com
  • 31 edits
    2 adds in trunk/Source

Allow an object's marking state to track The Three Colors
https://bugs.webkit.org/show_bug.cgi?id=149654

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

I want to make GC marking concurrent (see https://bugs.webkit.org/show_bug.cgi?id=149432).
Concurrent GC require barriers to be executed during certain heap operations. We already have a
generational GC. Generational GCs also need barriers, and we already have those. The generational
GC barrier that we use is the "sticky mark bit" barrier. Ordinarily, mark bits get reset after a
collection. In our collector, there is a secondary mark bit that "sticks" - i.e. it does not get
reset. If the sticky mark bit is set in between two collections, then we know that the object is in
old space. This is sufficient to determine when to put things into remembered sets. Additionally,
the sticky mark bit is actually a tri-state that can also tell us if the object has been placed on
a remembered set.

This is awfully similar to what you want in a concurrent GC. Concurrent GCs typically want writes
to the heap that change the object graph to do different things depending on an object's marking
state, which is usually referred to as its color. White means that the object has never been seen
by the collector. All white objects are presumed dead at the flip. Grey objects are those that are
known to the collector but have not been scanned. Black objects are those that have been scanned,
and will not be scanned again. White is exactly just "not being marked", and both grey and black
mean "marked" - with "black" meaning "marked but not on any worklist". That's quite a bit like the
current "Marked" and "MarkedAndRemembered" states that we have for generational GC.
"MarkedAndRemembered" is a lot like "grey", and "Marked" is a lot like "black".

I want to make a concurrent GC that unifies the generational and concurrent barriers into a single
fast path check. Even better if the two barriers are entirely identical. You can do this using
Pirinen's technique #2 [1], originally due to Guy Steele [2]: when doing o.f=v where o is black and
v is white, turn o grey again. This is like remembering an object, in the sense that our gen GC
"rememberes" o when o is old and v is new. It remembers objects by putting them on the mark stack,
setting the generational state to MarkedAndRemembered, and doing nothing to the primary mark bit.

This makes our concurrent GC approach pretty obvious. We want to use one barrier for concurrent and
generational, and we want to basically keep our current barriers unchanged. The only things missing
are just some small changes to allow the concurrent GC to know precisely when an object is black,
and to know during object visiting if we are visiting the object for the first time during a
collection or a subsequent time due to barrier re-greying (concurrent GC) or barrier remembering
(generational GC). So, this patch does the following:

  • Changes the terminology used for the gcData header byte in JSCell. This changes the name of this to cellState, and introduces a new enumeration called CellState. This new enumeration behaves a lot like the old GCData did. It has the following members, with the following correspondence to the old GCData:

OldBlack: this is like Marked, with the exception that we ensure that an object becomes OldBlack

as soon as the object starts to be scanned. Previously, an object might be
MarkedAndRemembered during scanning and we'd turn all MarkedAndRemembered objects into Marked
objects during a post-processing step at the end of GC. This patch gets rid of that
post-processing. The act of visiting an object unconditionally makes it OldBlack. Note that
our definition of "black" is not that the object is done being scanned, but that it is either
being scanned right now or it has already been scanned. This is like a combination of
Siebert's anthracite and black states [3].

NewWhite: this is exactly NotMarked. It's the state that objects get when they are allocated.

It's impossible for an object to return to this state.

OldGrey: the object is on the mark stack and will be scanned at some point in the future. This

also means that this isn't the first time in this cycle that the object has been grey. In an
eden collection, an old object that has been remembered is thought of as being OldGrey, even
if this is the first time during this eden collection that it is grey. That's because an eden
collection must behave "as if" the grey->black transition for old objects magically happened
at the start of GC. Remembered objects are like old objects that underwent a concurrent
barrier re-greying just after the magical old object grey->black transition at the start of
GC. This state is almost exactly like MarkedAndRemembered, except that an object now
transitions from OldGrey to OldBlack at the beginning of visiting, rather than how previously
we transitioned from MarkedAndRemembered to Marked at the bitter end of GC.

NewGray: the object is on the mark stack and will be scanned at some point in the future. This

state has no clear relative in the old state system. It means that the object became grey due
to ordinary marking. Previously, ordinary marking would make the object Marked.

  • Removal of the post-processing phase that "clears" the remembered set by moving all remembered objects to the Marked state. This now happens magically during visiting, as described above.
  • SlotVisitor now remembers the state that the object did have just before visiting. While visiting that object, it's possible to query what the state was. This is used for copy space decisions and for extra memory usage accounting. We don't want to put the backing store on the copy worklist, and we don't want to count extra memory usage, if the object was OldGrey at the start of visiting. Previously, we would be able to just ask if the object was MarkedAndRemembered since that state wouldn't get cleared until after all marking finished. This change also simplifies some APIs, because there is no need to pass the JSCell* pointer, since these SlotVisitor methods no longer ask the cell for its state - instead they use the saved pre-visiting state.
  • Removal of a bunch of helpers and abstractions. Previously we had various methods for asking if an object was "marked" and if an object was "remembered". We had helpers for adjusting these states, and those helpers would assert that they were being used the right way. This is not very useful for concurrent GC, since now the set of possible state transitions is much larger. Also, the previous use of the word "marked" was pretty bad - for example in Heap, "marked" refers to the primary mark bit (that gets cleared at the flip), while in JSCell, "marked" refers to the sticky mark bit (that does not get cleared, ever). This change gets rid of a lot of those helpers and inlines their logic. This actually makes the code easier and more fun to read, since you can now look at the marking and barrier code and see how that code uses the four CellStates. For example, it's fun to see that the barrier gets fired for o.f=v exactly when o is OldBlack and v is NewWhite.

This change shouldn't have any effect on performance or GC behavior. It does put our code in a
weird state where we now have states and comments referencing a concurrent GC that doesn't exist
yet.

Finally, some thoughts about the concurrent GC barrier and its implications for performance. This
barrier exhibits very poor guarantees about collector progress, but maximizes throughput by just
reusing the existing barrier code we already emit and optimize. I believe that even our epoch-based
barrier insertion DFG phase is correct for the concurrent interpretation of our existing barrier.
But, the barrier can regress the progress that the collector has made for two reasons:

Incremental update: you don't want to use this barrier with a black stack, since that would mean
that heap loads of white objects will have to explicitly re-grey the stack. The way you implement
this kind of collector is that collector termination will rescan the stack. Termination is reached
only if the at-termination re-scan greys no objects. This means that the collector is a fixpoint.
Luckily, our collector is already a fixpoint because of opaque roots and structure transitions.

Marking ain't monotonic: normally, once an object is black, it stays that way. In this collector,
black objects may become grey again. I don't have personal experience with such concurrent GCs, but
I suspect that this will basically be fine. Concurrent collections finish pretty quickly, and the
mutator usually touches only a subset of the heap. Only that subset of the heap that the mutator is
touching could be re-greyed. Probably, the GC will have to be hybrid incremental and concurrent,
and towards the end of GC when we do the termination stack re-scan, we can ensure that the
collector does some minimal amount of marking. If the minimal amount of marking done by the
collector is large enough, we can ensure that we reach termination before the mutator can regress
progress. The barrier cannot un-terminate the collector; if the collector reaches termination and
the barrier re-greys an object then it's actually doing a generational remembering rather than a
concurrent re-greying.

That's sort of the cute thing about the barrier - it is exactly a re-greying barrier during GC and
it is exactly a remembering barrier in between GCs.

[1] http://www.cs.utexas.edu/ftp/garbage/submit/readable/ppirinen11.ps
[2] http://dl.acm.org/citation.cfm?id=361005
[3] http://www.aicas.com/papers/ISMM132-siebert.pdf

(JSC::CodeBlock::visitChildren):

  • ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::DFG::LowerDFGToLLVM::loadCellState):
(JSC::FTL::DFG::LowerDFGToLLVM::emitStoreBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::loadMarkByte): Deleted.

  • heap/CellState.h: Added.
  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):

  • heap/CopiedBlock.h:
  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):
(JSC::CopiedBlock::shouldReportLiveBytes): Deleted.

  • heap/GCLogging.cpp:

(JSC::LoggingFunctor::reviveCells):

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::clearRememberedSet): Deleted.

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::isLive):
(JSC::Heap::isMarked):
(JSC::Heap::writeBarrier):
(JSC::Heap::reportExtraMemoryAllocated):
(JSC::Heap::reportExtraMemoryVisited):
(JSC::Heap::isRemembered): Deleted.

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::append):
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::visitChildren): Deleted.

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::childCount):
(JSC::SlotVisitor::incrementChildCount):
(JSC::SlotVisitor::dataBeforeVisitingCurrentObject):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::reportExtraMemoryVisited):
(JSC::SlotVisitor::heap):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::jumpIfIsRememberedOrInEden):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSCell.h:

(JSC::JSCell::cellState):
(JSC::JSCell::setCellState):
(JSC::JSCell::structureIDOffset):
(JSC::JSCell::indexingTypeOffset):
(JSC::JSCell::cellStateOffset):
(JSC::JSCell::setMarked): Deleted.
(JSC::JSCell::setRemembered): Deleted.
(JSC::JSCell::isMarked): Deleted.
(JSC::JSCell::isRemembered): Deleted.
(JSC::JSCell::gcDataOffset): Deleted.

  • runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

  • runtime/JSObject.cpp:

(JSC::JSObject::copyBackingStore):

  • runtime/JSString.cpp:

(JSC::JSString::visitChildren):

  • runtime/StructureIDBlob.h:

(JSC::StructureIDBlob::StructureIDBlob):
(JSC::StructureIDBlob::operator=):

  • runtime/WeakMapData.cpp:

(JSC::WeakMapData::visitChildren):
(JSC::WeakMapData::set):

  • tests/stress/basic-eden-gc-test.js: Added.

Hilariously, an earlier version of this patch that didn't have the NewGrey/OldGrey distinction
would only crash super-big tests that GCd twice but it didn't crash any small focused test. All
it took to show the need for the NewGrey/OldGrey distinction was this super simple test.

Source/WebCore:

No new tests because no new behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

11:49 AM Changeset in webkit [190568] by enrica@apple.com
  • 7 edits in trunk/Source/WebKit2

Cannot select certain text on Wikipedia homepage even when zoomed in.
https://bugs.webkit.org/show_bug.cgi?id=149758
rdar://problem/22407947

Reviewed by Dan Bernstein.

Several functions that handle gestures for text selection are used for both
editable and non editable content. When used on editable content, the point
where the gesture occurs needs to be constrained within the boundaries of the
editable element. In the WebProcess we decide whether to constrain the point or not only based
on the presence of the assisted node.
That unfortunately does not guarantee that the user is actually editing the element,
but only that the element is focused. Since the knowledge about the interaction exists reliably
in the UI process, this patch adds a parameter to each gesture handler that tries to clip
the point, to indicate whether the user is actually interacting with the element so that
in the WebProcess the assisted node information can be used to constrain the point.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::deviceOrientation):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _isInteractingWithAssistedNode]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView selectPositionAtPoint:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:withBoundary:completionHandler:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::selectTextWithGranularityAtPoint):
(WebKit::WebPageProxy::selectPositionAtBoundaryWithDirection):
(WebKit::WebPageProxy::selectPositionAtPoint):
(WebKit::WebPageProxy::updateSelectionWithExtentPoint):
(WebKit::WebPageProxy::updateSelectionWithExtentPointAndBoundary):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::visiblePositionInFocusedNodeForPoint):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::rangeForGranularityAtPoint):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary):
(WebKit::WebPage::updateSelectionWithExtentPoint):

11:31 AM Changeset in webkit [190567] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Update setImageSmoothingQuality for additional reviews.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-10-05
Reviewed by Chris Dumez.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setImageSmoothingQuality):

11:13 AM Changeset in webkit [190566] by akling@apple.com
  • 6 edits in trunk/Source

Remove unused HistoryItem::targetItem()
<https://webkit.org/b/149803>

Reviewed by Anders Carlsson.

Source/WebCore:

This is ancient code with no remaining clients since 2010 (r53650)

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::findTargetItem): Deleted.
(WebCore::HistoryItem::targetItem): Deleted.

  • history/HistoryItem.h:

Source/WebKit/mac:

Remove the only (unused) client of HistoryItem::targetItem().

  • History/WebHistoryItem.mm:
  • History/WebHistoryItemPrivate.h:
10:58 AM Changeset in webkit [190565] by Simon Fraser
  • 3 edits in trunk/Tools

Fix the iOS 8 build, where -[UIApplication _enqueueHIDEvent:] is not
available, and tidy up the #ifdefs in the UIKitSPI header.

  • WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator _sendHIDEvent:]):

  • WebKitTestRunner/ios/UIKitSPI.h:
10:27 AM Changeset in webkit [190564] by mmaxfield@apple.com
  • 19 edits in trunk

Unprefix -webkit-font-feature-settings
https://bugs.webkit.org/show_bug.cgi?id=149722

Reviewed by Sam Weinig.

Source/WebCore:

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFontFeatureSettings):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialFontFeatureSettings):
(WebCore::StyleBuilderCustom::applyInheritFontFeatureSettings):
(WebCore::StyleBuilderCustom::applyInitialWebkitFontFeatureSettings): Deleted.
(WebCore::StyleBuilderCustom::applyInheritWebkitFontFeatureSettings): Deleted.

Source/WebInspectorUI:

  • UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

  • css3/font-feature-settings-parsing.html:
  • css3/font-feature-settings-preinstalled-fonts.html:
  • css3/font-feature-settings-rendering-2.html:
  • css3/font-feature-settings-rendering.html:
  • fast/css/inherited-properties-rare-text-expected.txt:
  • fast/css/inherited-properties-rare-text.html:
  • fast/text/shaping/shaping-script-order.html:
  • fast/text/shaping/shaping-selection-rect.html:
  • fonts/unicode-character-font-crash.html:
  • scrollbars/scrollbar-scrollbarparts-repaint-crash.html:
10:22 AM Changeset in webkit [190563] by ggaren@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

JSC::SlotVisitor should not be a hot mess
https://bugs.webkit.org/show_bug.cgi?id=149798

Reviewed by Andreas Kling.

I had to debug JSC::SlotVisitor the other day. It was hard to follow.
Let's make it easy to follow.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::resetVisitors):
(JSC::Heap::objectCount):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::collectAndSweep):

  • heap/Heap.h: Deleted the string hash-consing code. It

was dead code.

Since no benchmark noticed the commit that broke this feature, perhaps
it's not worth having.

Either way, the best thing to do with dead code is to delete it.
It's still there in svn if we ever want to pick it up again.

  • heap/HeapRootVisitor.h:

(JSC::HeapRootVisitor::visit):
(JSC::HeapRootVisitor::visitor): Removed the private append functions
for unsafe pointers and switched HeapRootVisitor over to the public
specially named functions for unsafe pointers.

In future, we should either remove the public specially named functions
or remove HeapRootVisitor, since they serve the same purpose. At least
for now we don't have pairs of functions on SlotVisitor that do the
exact same thing.

  • heap/SlotVisitor.cpp:

(JSC::validate): Moved this static function to the top of the file.

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset): More hash cons removal.

(JSC::SlotVisitor::append):

(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack): Renamed these functions to
distinguish them from the up-front helper functions that just do type
conversions. These are the functions that actually do stuff.

Moved these functions out of line to make it easier to set breakpoints,
and to enable code changes for debugging, like printf and synchronous
marking, without recompiling the world.

setMarkedAndAppendToMarkStack is roughly 258 bytes long (not including
function prologue and epilogue), so inlining it was probably not a
great idea in the first place.

(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared): Removed some stack probing code.
It was also dead.

(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):
(JSC::SlotVisitor::opaqueRootCount):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary):
(JSC::SlotVisitor::mergeOpaqueRootsIfProfitable):
(JSC::SlotVisitor::donate):
(JSC::SlotVisitor::donateAndDrain):
(JSC::SlotVisitor::copyLater):
(JSC::SlotVisitor::mergeOpaqueRoots):
(JSC::SlotVisitor::harvestWeakReferences):
(JSC::SlotVisitor::finalizeUnconditionalFinalizers):
(JSC::SlotVisitor::dump): Moved more code out-of-line. These code paths
are not hot and/or not small, so we need more evidence before we inline
them. The SlotVisitor headers are included everywhere, so we should
make them include less.

Removed "internal" from all function names because it wasn't applied in
any consistent way that would mean anything.

(JSC::JSString::tryHashConsLock): Deleted.
(JSC::JSString::releaseHashConsLock): Deleted.
(JSC::JSString::shouldTryHashCons): Deleted.
(JSC::SlotVisitor::internalAppend): Deleted.
(JSC::SlotVisitor::validate): Deleted.

  • heap/SlotVisitor.h:

(JSC::SlotVisitor::resetChildCount): Deleted.
(JSC::SlotVisitor::childCount): Deleted.
(JSC::SlotVisitor::incrementChildCount): Deleted. Removed this child
count thing. It was dead code.

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::appendUnbarrieredPointer):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyPointer):
(JSC::SlotVisitor::appendUnbarrieredValue):
(JSC::SlotVisitor::appendUnbarrieredReadOnlyValue): Some renaming and un-inlining.

(JSC::SlotVisitor::appendUnbarrieredWeak): Don't null check our input.
The one true place where null checking happens is our out-of-line
code. All inline functions do only type conversions.

(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendValues):
(JSC::SlotVisitor::addWeakReferenceHarvester):
(JSC::SlotVisitor::addUnconditionalFinalizer):
(JSC::SlotVisitor::reportExtraMemoryVisited): Some renaming and un-inlining.

(JSC::SlotVisitor::internalAppend): Deleted.
(JSC::SlotVisitor::unconditionallyAppend): Deleted.
(JSC::SlotVisitor::addOpaqueRoot): Deleted.
(JSC::SlotVisitor::containsOpaqueRoot): Deleted.
(JSC::SlotVisitor::containsOpaqueRootTriState): Deleted.
(JSC::SlotVisitor::opaqueRootCount): Deleted.
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary): Deleted.
(JSC::SlotVisitor::mergeOpaqueRootsIfProfitable): Deleted.
(JSC::SlotVisitor::donate): Deleted.
(JSC::SlotVisitor::donateAndDrain): Deleted.
(JSC::SlotVisitor::copyLater): Deleted.

  • runtime/JSString.h:

(JSC::JSString::finishCreation):
(JSC::JSString::setIs8Bit):
(JSC::JSString::isHashConsSingleton): Deleted.
(JSC::JSString::clearHashConsSingleton): Deleted.
(JSC::JSString::setHashConsSingleton): Deleted. More hash cons removal.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::currentThreadIsHoldingAPILock):
(JSC::VM::apiLock):
(JSC::VM::haveEnoughNewStringsToHashCons): Deleted.
(JSC::VM::resetNewStringsSinceLastHashCons): Deleted. More hash cons removal.

10:18 AM Changeset in webkit [190562] by zandobersek@gmail.com
  • 10 edits in trunk/Source/WebCore

[GStreamer] Replace uses of std::bind() with lambdas
https://bugs.webkit.org/show_bug.cgi?id=149802

Reviewed by Carlos Garcia Campos.

Instead of std::bind(), use C++ lambdas to create std::function<>
wrappers in GStreamer-related class implementations.

Ref-counted classes are protected by capturing a RefPtr object.
GstObject-derived objects are protected by capturing a GRefPtr object.
Necessary specializations for WebKitVideoSink and WebKitWebSrc are added.

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<WebKitVideoSink>):
(WTF::derefGPtr<WebKitVideoSink>):
(WTF::refGPtr<WebKitWebSrc>):
(WTF::derefGPtr<WebKitWebSrc>):

  • platform/graphics/gstreamer/GRefPtrGStreamer.h:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:

(WebCore::InbandTextTrackPrivateGStreamer::handleSample):
(WebCore::InbandTextTrackPrivateGStreamer::streamChanged):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::videoChanged):
(WebCore::MediaPlayerPrivateGStreamer::videoCapsChanged):
(WebCore::MediaPlayerPrivateGStreamer::audioChanged):
(WebCore::MediaPlayerPrivateGStreamer::textChanged):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::volumeChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChanged):

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::activeChanged):
(WebCore::TrackPrivateBaseGStreamer::tagsChanged):

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcChangeState):
(webKitWebSrcNeedDataCb):
(webKitWebSrcEnoughDataCb):
(webKitWebSrcSeekDataCb):

10:05 AM Changeset in webkit [190561] by fpizlo@apple.com
  • 15 edits in trunk/Source

Inline cache repatching should be throttled if it happens a lot
https://bugs.webkit.org/show_bug.cgi?id=149796
rdar://problem/22674436

Reviewed by Saam Barati.

Source/JavaScriptCore:

We noticed a slight PLT regression from http://trac.webkit.org/changeset/189586. It's because
some pages do things that our inline caches mishandle, in the sense that some ICs end up
repatching themselves very frequently. The cost of repatching outweighs the speed-up on those
pages. There are probably super smart things we could do to tune the IC heuristics to make the
ICs do the right thing on those pages. But more fundamentally, we should ensure that our ICs
back off from continuous repatching if they repatch a lot. That's what this change does.

With this change, StructureStubInfo counts the number of repatchings. If that exceeds a
threshold, we put the IC into a cool-down mode, where some number of future repatch events do
nothing but decrement the cool-down counter. The duration of cool-down increases exponentially
every time we have to do it.

This change also outlines a lot of code. The fact that StructureStubInfo had a lot of inline
methods was starting to get on my nerves. Now it only has inline methods for things that need
to be inlined. Also, I changed StructureStubInfo to be a class rather than a struct. Maybe
with enough such incremental changes, eventually StructureStubInfo will actually behave like a
proper class.

This has no effect on JSC benchmarks. It progresses one of the pages that was hit by the
regression by 15%. It's hard to see if this totally fixes the entire PLT regression since the
geomean regression was very close to noise.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):

  • bytecode/CodeBlock.h:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::GetByIdStatus::computeFor):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

  • bytecode/PolymorphicAccess.h:
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/StructureStubClearingWatchpoint.h:
  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::~StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::initStub):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::addAccessCase):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::considerCaching):
(JSC::StructureStubInfo::willRepatch):
(JSC::StructureStubInfo::willCoolDown):
(JSC::getStructureStubInfoCodeOrigin):
(JSC::StructureStubInfo::StructureStubInfo): Deleted.
(JSC::StructureStubInfo::initGetByIdSelf): Deleted.
(JSC::StructureStubInfo::initPutByIdReplace): Deleted.
(JSC::StructureStubInfo::initStub): Deleted.
(JSC::StructureStubInfo::seenOnce): Deleted.
(JSC::StructureStubInfo::setSeen): Deleted.

  • jit/JIT.h:
  • jit/JITOperations.cpp:
  • jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):

  • runtime/Options.h:

Source/WTF:

Add some helpers for saturated math.

  • wtf/MathExtras.h:

(WTF::incrementWithSaturation):
(WTF::leftShiftWithSaturation):

8:12 AM Changeset in webkit [190560] by Antti Koivisto
  • 4 edits in trunk/Source/WebKit2

Remove CancelResourceLoader message
https://bugs.webkit.org/show_bug.cgi?id=149801

Reviewed by Andreas Kling.

It has no clients.

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::messageSenderDestinationID):
(WebKit::WebResourceLoader::detachFromCoreLoader):
(WebKit::WebResourceLoader::cancelResourceLoader): Deleted.

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
7:38 AM Changeset in webkit [190559] by akling@apple.com
  • 7 edits in trunk/Source

Remove unused HistoryItem::parent
<https://webkit.org/b/149803>

Reviewed by Anders Carlsson.

Source/WebCore:

Remove the effectively-unused "parent" field from HistoryItem.
This also allows us to get rid of a HistoryItem constructor.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem): Deleted.
(WebCore::HistoryItem::reset): Deleted.
(WebCore::HistoryItem::parent): Deleted.
(WebCore::HistoryItem::setParent): Deleted.

  • history/HistoryItem.h:

(WebCore::HistoryItem::create): Deleted.

  • loader/HistoryController.cpp:

(WebCore::HistoryController::initializeItem): Deleted.

Source/WebKit/mac:

Remove the only (unused) client of HistoryItem's with-parent constructor.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem initWithURL:target:parent:title:]): Deleted.

  • History/WebHistoryItemInternal.h:
7:22 AM WebInspector edited by Csaba Osztrogonác
(diff)
7:20 AM BadContent edited by Csaba Osztrogonác
add more spammer (diff)
12:13 AM Changeset in webkit [190558] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

GLContext should control ownership of context-related objects
https://bugs.webkit.org/show_bug.cgi?id=149794

Reviewed by Martin Robinson.

Creation of GLContext objects can depend on various platform-specific
objects like native window representations. Since these objects are
used solely for the GLContext purposes, it would make sense to allow
GLContext to provide an extensible way to impose ownership on these
objects and control their lifetime.

GLContext::Data is declared with a defaulted virtual destructor.
Users of these implementations can declare classes that derive from
GLContext::Data and store context-related objects in instances of the
derived class, and ensure that these objects are properly cleaned up
when GLContext destroys the Data object.

The GLContext::Data object is managed through a protected
std::unique_ptr<> member in the GLContext class. For now the member
is only set in GLContextEGL::createWindowContext() and is destroyed
during the GLContext destruction.

The local OffscreenContextData class in
PlatformDisplayWayland::createSharingGLContext() derives from
GLContext::Data and is used to store the wl_surface and
EGLNativeWindowType (aka wl_egl_window) objects for offscreen
GLContexts under the Wayland platform that are used for the sharing
context and WebGL, effectively avoiding the leak that would further
propagate problems into the compositor and the graphics library.
(Such offscreen contexts are actually mimicked via a 1x1px
wl_egl_window object that acts as a dummy base for the related
wl_surface object).

  • platform/graphics/GLContext.h:
  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createWindowContext):

  • platform/graphics/egl/GLContextEGL.h:
  • platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::createSharingGLContext):

12:04 AM Changeset in webkit [190557] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Make gdk.h inclusion in FontPlatformDataFreeType.cpp properly GTK-specific
https://bugs.webkit.org/show_bug.cgi?id=149793

Reviewed by Carlos Garcia Campos.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

Instead of including <gdk/gdk.h> header for all platforms but EFL, only
include it for the GTK platform, since no other platform depends on the
GDK library.

Oct 4, 2015:

10:55 PM Changeset in webkit [190556] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Remove duplicate entries in WebKitTestRunner_SOURCES
https://bugs.webkit.org/show_bug.cgi?id=149792

Reviewed by Martin Robinson.

  • WebKitTestRunner/PlatformGTK.cmake: Don't list build targets

for WebKitTestRunner multiple times.

4:25 PM Changeset in webkit [190555] by fpizlo@apple.com
  • 14 edits
    1 delete in trunk/Source/JavaScriptCore

CodeBlock.h shouldn't be included from everywhere
https://bugs.webkit.org/show_bug.cgi?id=149785

Reviewed by Andreas Kling.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:
  • dfg/DFGAdaptiveStructureWatchpoint.cpp:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::callSiteBitsAreBytecodeOffset):
(JSC::CallFrame::callSiteBitsAreCodeOriginIndex):
(JSC::CallFrame::callSiteAsRawBits):
(JSC::CallFrame::callSiteIndex):
(JSC::CallFrame::hasActivation):
(JSC::CallFrame::uncheckedActivation):
(JSC::CallFrame::stack):

  • interpreter/CallFrameInlines.h: Removed.
  • interpreter/Interpreter.cpp:
  • interpreter/StackVisitor.cpp:
  • runtime/DirectArguments.cpp:
  • runtime/ErrorInstance.cpp:
  • runtime/JSArray.cpp:
  • runtime/JSCInlines.h:
  • runtime/LiteralParser.cpp:
  • runtime/NullSetterFunction.cpp:
  • tools/JSDollarVMPrototype.cpp:
3:30 PM Changeset in webkit [190554] by dbates@webkit.org
  • 2 edits in trunk/Tools

Fix the Apple Internal iOS build after <http://trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)

For now, support calling build-layouttestrelay without --ios-simulator so long
as we are building on a Mac.

  • Scripts/build-layouttestrelay:
1:49 PM Changeset in webkit [190553] by ap@apple.com
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix a typo in ChangeLog.

1:47 PM Changeset in webkit [190552] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Mark tests as flay for
https://bugs.webkit.org/show_bug.cgi?id=148890

http/tests/contentfiltering/load-substitute-data-from-appcache.html and
http/tests/appcache/decide-navigation-policy-after-delay.html crash
in DocumentLoader::dataReceived sometimes

  • platform/wk2/TestExpectations:
11:33 AM Changeset in webkit [190551] by Nikita Vasilyev
  • 4 edits in trunk

Web Inspector: Wrong column numbers in error object views
https://bugs.webkit.org/show_bug.cgi?id=149795

Source/WebInspectorUI:

Convert columnNumber and lineNumber properties from strings to numbers
to prevent accidental string concatenations.

Reviewed by Timothy Hatcher.

  • UserInterface/Models/StackTrace.js:

(WebInspector.StackTrace._parseStackTrace):

LayoutTests:

Reviewed by Timothy Hatcher.

  • inspector/debugger/js-stacktrace-expected.txt:
10:49 AM Changeset in webkit [190550] by ap@apple.com
  • 2 edits in trunk/Tools

Support Trac 1.0.x XML timeline link format
https://bugs.webkit.org/show_bug.cgi?id=149786

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype._convertCommitInfoElementToObject):

10:01 AM Changeset in webkit [190549] by ap@apple.com
  • 2 edits in trunk/Tools

Fix some errors on bot watcher's dashboard
https://bugs.webkit.org/show_bug.cgi?id=149789

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
tests step, in which case layoutTestResults.tooManyFailures would raise an exception.

9:57 AM Changeset in webkit [190548] by ap@apple.com
  • 2 edits in trunk/Tools

Bot watcher's dashboard builders should turn yellow when svn fails
https://bugs.webkit.org/show_bug.cgi?id=149791

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:

(BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
(BuildbotBuilderQueueView.prototype.update):

Oct 3, 2015:

7:38 PM Changeset in webkit [190547] by commit-queue@webkit.org
  • 5 edits in trunk/Source

"Plug-in is blocked" message doesn't draw correctly
https://bugs.webkit.org/show_bug.cgi?id=149741
<rdar://problem/22920949>

Patch by Conrad Shultz and Ricky Mondello.

Patch by Ricky Mondello <Ricky Mondello> on 2015-10-03
Reviewed by Anders Carlsson.

Source/WebCore:

No new tests are added.

Add PluginData API to check whether a MIME type is supported, regardless of plug-in visibility.

  • plugins/PluginData.cpp:

(WebCore::PluginData::getWebVisibleMimesAndPluginIndices): Adopt getMimesAndPluginIndiciesForPlugins.
(WebCore::PluginData::getMimesAndPluginIndices): Added.
(WebCore::PluginData::getMimesAndPluginIndiciesForPlugins): Essentially factored out of

getWebVisibleMimesAndPluginIndices.

(WebCore::PluginData::supportsMimeType): Added. Somewhat similar to preexisting supportsWebVisibleMimeType.

  • plugins/PluginData.h: Declare supportsMimeType.

Source/WebKit2:

If a WebKit client sets plug-in X to not be visible to the web, that doesn't mean we shouldn't consult
that plug-in when determining what kind of object type an object is. Properly classifying a non-web-visible
Netscape plug-in as such allows its bounds to properly measured, allowing it to be drawn properly.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType): Use PluginData's supportsMimeType, rather than its

supportsWebVisibleMimeType, when determining the ObjectContentType for a MIME type on a url.

6:45 PM Changeset in webkit [190546] by commit-queue@webkit.org
  • 56 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190522.
https://bugs.webkit.org/show_bug.cgi?id=149787

Caused a lot of leaks (Requested by ap on #webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190522

5:43 PM Changeset in webkit [190545] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/overflow-scroll-fake-mouse-move.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=138697

Reviewed by Brent Fulgham.

  • fast/events/overflow-scroll-fake-mouse-move.html:
3:13 AM Changeset in webkit [190544] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Make the test added in r190530 not time out on the ports that don't enable shadow DOM.

Call waitUntilDone after calling attachShadow so that an exception thrown by calling attachShadow
will prevent waitUntilDone from getting called on those ports.

  • fast/shadow-dom/insert-child-to-assigned-node.html:

Oct 2, 2015:

10:04 PM Changeset in webkit [190543] by dbates@webkit.org
  • 4 edits
    2 adds in trunk/Tools

Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=149769

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.ios-simulator-9 img.logo):

8:18 PM Changeset in webkit [190542] by Matt Baker
  • 13 edits in trunk/Source

Web Inspector: Add breakpoint option to ignore n times before stopping
https://bugs.webkit.org/show_bug.cgi?id=147664

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • debugger/Breakpoint.h:

(JSC::Breakpoint::Breakpoint):
Added ignoreCount and hitCount fields. Cleaned up initializers.

  • debugger/Debugger.cpp:

(JSC::Debugger::hasBreakpoint):
If a breakpoint matches the current text position, increment breakpoint hit count and
compare with ignore count before testing the breakpoint condition.

  • inspector/ScriptBreakpoint.h:

(Inspector::ScriptBreakpoint::ScriptBreakpoint):
Added ignoreCount field. Cleaned up initializers.

  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::setBreakpoint):
Added ignoreCount field.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::didParseSource):
Plumbing for ignoreCount property.

  • inspector/protocol/Debugger.json:

Added optional ignoreCount property to BreakpointOptions object.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:

New strings for breakpoint popover labels.

  • UserInterface/Controllers/BreakpointPopoverController.js:

(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
Add ignoreCount UI to popover, if backend support exists. UI based on same
feature in Xcode's breakpoint editing dialog.
(WebInspector.BreakpointPopoverController.prototype._popoverIgnoreInputChanged):
User input sanity checks on numeric input.

  • UserInterface/Controllers/DebuggerManager.js:

Listen for changes to breakpoint ignoreCount property.

  • UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get ignoreCount):
(WebInspector.Breakpoint.prototype.set ignoreCount):
New property for ignoreCount.
(WebInspector.Breakpoint.prototype.get options):
Added ignoreCount to options object.
(WebInspector.Breakpoint.prototype.get info):
Added ignoreCount to info object.

  • UserInterface/Views/BreakpointPopoverController.css:

(#edit-breakpoint-popover-ignore):
New styles for breakpoint popover.

8:10 PM Changeset in webkit [190541] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/PerformanceTests

Add shared code for a new a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149691

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-02
Reviewed by Ryosuke Niwa.

This set of classes will be shared and used by the tests and the runner
of a new graphics benchmark.

  • Animometer/resources: Added.
  • Animometer/resources/algorithm.js: Added.

(Array.prototype.swap): Swaps two elements in an array.
(Heap): Binary Min/Max Heap object
(Heap.prototype._parentIndex): Given the child node index, it returns the parent index.
(Heap.prototype._leftIndex): Given the parent node index, it returns the left node index.
(Heap.prototype._rightIndex): Given the parent node index, it returns the right node index.
(Heap.prototype._childIndex): Given the parent node index, it returns the child index that may violate the heap property.
(Heap.prototype.init): Initializes the heap state.
(Heap.prototype.top): Returns the value stored at the top of the heap.
(Heap.prototype.push): Pushes a new node at the top of the heap.
(Heap.prototype.pop): Extracts the top node of the heap.
(Heap.prototype._bubble): Fixes the heap property by moving upward.
(Heap.prototype._sink): Fixes the heap property by moving downward.
(Heap.prototype.str): Prints the nodes of the heap to a string.
(Heap.prototype.values): Returns the last "size" heap elements values.

(Algorithm.createMinHeap): Creates a size-bounded min-heap object.
(Algorithm.createMaxHeap): Creates a size-bounded max-heap object.

  • Animometer/resources/extensions.js: Added.

(Point): Point object but can be used as size also.
(Point.pointOnCircle): Given, the radius of the circle and the angle of the point, it returns a point object.
(Point.pointOnEllipse): Given, the radiuses of the ellipse and the angle of the point, it returns a point object.
(Point.prototype.get width): Should be called when the point is used as size.
(Point.prototype.get height): Should be called when the point is used as size.
(Point.prototype.get center): Should be called when the point is used as size.
(Point.prototype.add): Returns a new point = this + other.
(Point.prototype.subtract): Returns a new point = this - other.
(Point.prototype.multiply): Returns a new point = this * other.
(Point.prototype.move): Moves the point in a given direction, velocity, time period.

(Insets): Represents borders of a container.
(Insets.prototype.get width): Returns left + right.
(Insets.prototype.get height): Returns top + bottom.

(SimplePromise):
(SimplePromise.prototype.then):
(SimplePromise.prototype.resolve):
Moved from Animometer/runner/resources/benchmark-runner.js since tests also need it.

(Options): Benchmark running options as they are set by the user.

(ProgressBar): Manages a progress bar element. The progress bar is divided into equal length ranges.
(ProgressBar.prototype._progressToPercent): Converts the progress into a percentage.
(ProgressBar.prototype.incRange): Moves to the next range (a range is the running time of a single test).
(ProgressBar.prototype.setPos): Draws the current progress in the current range.

(RecordTable): Shows the results of running a benchmark in a tabular form.
(RecordTable.prototype.clear): Clears the results table.
(RecordTable.prototype._showTitles): Shows the header titles and appends the sub-titles to a queue.
(RecordTable.prototype._showHeader): Shows the table header titles.
(RecordTable.prototype._showEmpty): Shows an empty table cell.
(RecordTable.prototype._showValue): Shows a number value in the results table.
(RecordTable.prototype._showSamples): Shows a button for the sampled data graph.
(RecordTable.prototype._showTest): Shows the results of a single test.
(RecordTable.prototype._showSuite): Shows the results of a single suite.
(RecordTable.prototype.showRecord): Shows a single iteration for a single test.
(RecordTable.prototype.showIterations): Shows the results of all the suites of the iterations.

  • Animometer/resources/sampler.js: Added.

(Statistics.sampleMean): Returns the sample mean.
(Statistics.unbiasedSampleStandardDeviation): Returns the unbiased sample variance (i.e. with Bessel's correction)
(Statistics.geometricMean): Returns the geometric mean.

(Experiment): Represents a sampling experiment.
(Experiment.prototype._init): Called when the object is created and when startSampling() is called.
(Experiment.prototype.startSampling): Called after warmup period. Restarts collecting sampled data points.
(Experiment.prototype.sample): Add a new data point.
(Experiment.prototype.mean): Returns the sample mean for the current sampled data points.
(Experiment.prototype.standardDeviation): Returns the sample standard deviation for the current sampled data points.
(Experiment.prototype.percentage): Returns the percentage of the standard deviation divided to the mean.
(Experiment.prototype.confidenceIntervalDelta): Calculates the confidence delta for the current sampled data given a confidence level.
(Experiment.prototype.concern): Returns the average of the worst given percentage from the sampled data.
(Experiment.prototype.score): Returns a score for the sampled data. It is the geometric mean of sampleMean and concern.

(Sampler): Represents a compound experiment. It manages sampling multiple data points at the same time offset.
(Sampler.prototype.startSampling): Called after warming up period. Restarts collecting sampled data points.
(Sampler.prototype.sample): Add a new data vector at a given time offset.

7:28 PM Changeset in webkit [190540] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Cleanup DebuggerManager, reduce delete and use Maps instead of objects
https://bugs.webkit.org/show_bug.cgi?id=149760

Reviewed by Joseph Pecoraro.

Replaced objects used as hashmaps with Map.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
(WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
(WebInspector.DebuggerManager.prototype.scriptForIdentifier):
(WebInspector.DebuggerManager.prototype.scriptsForURL):
(WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
(WebInspector.DebuggerManager.prototype.removeBreakpoint):
(WebInspector.DebuggerManager.prototype.breakpointResolved):
(WebInspector.DebuggerManager.prototype.reset):
(WebInspector.DebuggerManager.prototype.scriptDidParse):
(WebInspector.DebuggerManager.prototype._sourceCodeLocationFromPayload):
(WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerManager.prototype._setBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint.didRemoveBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint):

6:13 PM Changeset in webkit [190539] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.40

New tag.

6:11 PM Changeset in webkit [190538] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Roll out r190447. rdar://problem/22865007

6:09 PM Changeset in webkit [190537] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/LayoutTests

Roll out r190438. rdar://problem/22865007

6:07 PM Changeset in webkit [190536] by bshafiei@apple.com
  • 18 edits in branches/safari-601.1.46-branch

Roll out r190434. rdar://problem/22865007

5:50 PM Changeset in webkit [190535] by rniwa@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r190370): Speedometer spits out an extra console message
https://bugs.webkit.org/show_bug.cgi?id=149720

Unreviewed. Temporarily ignore the console error message.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._filter_output):

5:37 PM Changeset in webkit [190534] by Simon Fraser
  • 2 edits
    3 adds in trunk/LayoutTests

New baselines for some compositing tests.

  • platform/ios-simulator/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/become-overlay-composited-layer-expected.txt:
  • platform/ios-simulator/compositing/visible-rect/animated-from-none-expected.txt: Added.
5:33 PM Changeset in webkit [190533] by bshafiei@apple.com
  • 3 edits
    6 copies in tags/Safari-601.3.1

Merged r190418. rdar://problem/22936771

5:26 PM Changeset in webkit [190532] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.3.2

New tag.

4:57 PM Changeset in webkit [190531] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.3.1

New tag.

4:32 PM Changeset in webkit [190530] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Inserting a child to a slot assigned node doesn't trigger repaint
https://bugs.webkit.org/show_bug.cgi?id=149739

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/shadow-dom/insert-child-to-assigned-node.html

  • dom/Node.cpp:

(WebCore::Node::derefEventTarget):
(WebCore::traverseStyleParent):
(WebCore::traverseFirstStyleParent):
(WebCore::Node::updateAncestorsForStyleRecalc):

Traverse in style parent order.

LayoutTests:

  • fast/shadow-dom/insert-child-to-assigned-node-expected.html: Added.
  • fast/shadow-dom/insert-child-to-assigned-node.html: Added.
4:09 PM Changeset in webkit [190529] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

We should not add InferredTypeTables to old Structures
https://bugs.webkit.org/show_bug.cgi?id=149767
rdar://problem/22825526

Patch by Filip Pizlo <fpizlo@apple.com> and Mark Lam <mark.lam@apple.com> on 2015-10-02
Reviewed by Saam Barati.

Our property type inference has an optimization where the absence of an InferredTypeTable is
taken to mean that all properties are TOP. This is great because most Structures come into
existence through reflective stores, and we don't want to waste time inferring types for
those.

But our code was not obeying this rule properly. If we were doing a transition, we would
assume that this meant that we were creating a new structure, and so we would give it an
InferredTypeTable if we were doing a non-reflective store (i.e. context = PutById). But that
same structure could already have been in use prior to us giving it an InferredTypeTable. At
that point bad things will start to happen because the objects created before we created the
table, and the inline caches compiled before then, will have types that disagree with the new
objects and inline caches despite them sharing the same structure and property names.

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Structure.h:
  • tests/stress/add-inferred-type-table-to-existing-structure.js: Added.

(foo):
(bar):
(baz):

3:33 PM Changeset in webkit [190528] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Web Inspector: Copying inline style text puts "undefined" in the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=149155

Patch by Devin Rousso <Devin Rousso> on 2015-10-02
Reviewed by Brian Burg.

Source/WebInspectorUI:

CSSStyleDeclarations for inline styles do not have a owner CSSRule, which means
that they do not have a selector or media list. CSS strings must have a selector
and, for inline styles without an owner rule and selector, this was a problem.

  • UserInterface/Models/CSSStyleDeclaration.js:

(WebInspector.CSSStyleDeclaration.prototype.get mediaList):
(WebInspector.CSSStyleDeclaration.prototype.get selectorText):
(WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):
Added getters for the list of media queries and selector text with fallbacks
for CSSStyleDeclarations that do not have an owner CSSRule (inline styles).

  • UserInterface/Test.html:

Added CSSMedia include for new inspector/css/generate-css-rule-string.html test.

  • UserInterface/Views/VisualStyleSelectorTreeItem.js:

(WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
Removed parameter that no longer exists.

LayoutTests:

Added test for generating CSS rule strings with default formatting.

  • inspector/css/generate-css-rule-string.html:
3:24 PM Changeset in webkit [190527] by Joseph Pecoraro
  • 35 edits
    11 deletes in trunk

Unreviewed, rolling out r190520, some tests assert / crash.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/Heap.cpp:

(JSC::Heap::willStartCollection): Deleted.
(JSC::Heap::didFinishCollection): Deleted.

  • heap/Heap.h:

(JSC::Heap::addObserver): Deleted.
(JSC::Heap::removeObserver): Deleted.

  • heap/HeapObserver.h: Removed.
  • heap/MarkedSpace.h:
  • inspector/InspectorEnvironment.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm): Deleted.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/agents/InspectorHeapAgent.cpp: Removed.
  • inspector/agents/InspectorHeapAgent.h: Removed.
  • inspector/protocol/Heap.json: Removed.

Source/WebCore:

  • ForwardingHeaders/heap/HeapObserver.h: Removed.
  • ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Removed.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController): Deleted.
(WebCore::InspectorController::vm): Deleted.

  • inspector/InspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::vm): Deleted.

  • inspector/WorkerInspectorController.h:

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.loaded): Deleted.

  • UserInterface/Base/Utilities.js:

(value): Deleted.

  • UserInterface/Controllers/HeapManager.js: Removed.
  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager): Deleted.
(WebInspector.TimelineManager.prototype._garbageCollected): Deleted.

  • UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
  • UserInterface/Main.html:
  • UserInterface/Models/GarbageCollection.js: Removed.
  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.EventType.displayName):
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection): Deleted.

  • UserInterface/Protocol/HeapObserver.js: Removed.
  • UserInterface/Test.html:
  • UserInterface/Test/Test.js:

(WebInspector.loaded): Deleted.

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
(WebInspector.ScriptTimelineDataGridNode): Deleted.

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._processPendingRecords):

  • UserInterface/Views/SourceCodeTimelineTreeElement.js:

(WebInspector.SourceCodeTimelineTreeElement):

  • UserInterface/Views/TimelineIcons.css:

(.garbage-collection-profile-record .icon): Deleted.

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment): Deleted.

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.createCombinedBars):

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):

LayoutTests:

  • inspector/heap/garbageCollected-expected.txt: Removed.
  • inspector/heap/garbageCollected.html: Removed.
  • inspector/heap/gc-expected.txt: Removed.
  • inspector/heap/gc.html: Removed.
3:15 PM Changeset in webkit [190526] by commit-queue@webkit.org
  • 2 edits
    9 adds in trunk/PerformanceTests

Add the test runner for a new a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149683

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-02
Reviewed by Ryosuke Niwa.

The test runner collects the selected test suites and the running options
from its home page. It loops through all the tests, runs them and collects
their running results. At the end, it shows summary results and a final
score. It can also show a chart for a test sampled data.

  • Animometer: Added.
  • Animometer/runner: Added.
  • Animometer/runner/resources: Added.
  • Animometer/runner/animometer.html: Added.
  • Animometer/runner/resources/animometer.css: Added.

The benchmark runner page and css.

  • Animometer/runner/resources/animometer.js: Added.

(window.benchmarkRunnerClient.willAddTestFrame): Called after the test <iframe> is created.
(window.benchmarkRunnerClient.didRunTest): Called after running a test is finished.
(window.benchmarkRunnerClient.willStartFirstIteration): Called at the beginning before running any test.
(window.benchmarkRunnerClient.didRunSuites): Called after running all tests of a suite.
(window.benchmarkRunnerClient.didFinishLastIteration): Called after running the last test.

(showSection): Shows a section in the animometer.html page.
(startTest): Called when the "Start Test" button is clicked.
(showResults): Called after finishing all the tests.
(showGraph): Called when "Click..." button in the "Samples" column of the results table is clicked

  • Animometer/runner/resources/benchmark-runner.js: Copied from PerformanceTests/Speedometer/resources/benchmark-runner.js.

(BenchmarkRunnerState): Tracks the current running <suite, test>
(BenchmarkRunnerState.prototype.currentSuite): Returns the current running suite.
(BenchmarkRunnerState.prototype.currentTest): Returns the current running test.
(BenchmarkRunnerState.prototype.isFirstTest): Returns true if we are running the first test in the current suite.
(BenchmarkRunnerState.prototype.next): Advances to the next test.
(BenchmarkRunnerState.prototype.prepareCurrentTest): Creates a new <iframe> and waits for it to load a test.

(BenchmarkRunner): Manages running the tests and communicating with the benchmarkRunnerClient.
(BenchmarkRunner.prototype.waitForElement): Waits for an element to be created.
(BenchmarkRunner.prototype._appendFrame): Creates a new <iframe> element.
(BenchmarkRunner.prototype._removeFrame): Removed the current <iframe> element.
(BenchmarkRunner.prototype._runTestAndRecordResults): Runs the current test and saves its results.
(BenchmarkRunner.prototype.step): Either runs the current test if there is or start a new iteration.
(BenchmarkRunner.prototype.runAllSteps): Loops to run all the tests and move to the next iteration.
(this._runNextIteration): Starts a new iteration or show the results.
(BenchmarkRunner.prototype.runMultipleIterations): Loops to run all the iterations and show the results
(BenchmarkRunner.prototype._finalize): Finalizes the current iteration and starts a new one.

(SimplePromise): Deleted.
(SimplePromise.prototype.then): Deleted.
(SimplePromise.prototype.resolve): Deleted.
(BenchmarkTestStep): Deleted.
(Fibonacci): Deleted.
SimplePromise was moved t Animometer/resources/extensions.js because it is used by the runner and the tests.

(BenchmarkRunner.prototype._waitAndWarmUp): Deleted.
(BenchmarkRunner.prototype._runTest): Deleted.
(BenchmarkState.prototype.currentSuite): Deleted.
(BenchmarkState.prototype.currentTest): Deleted.
(BenchmarkState.prototype.next): Deleted.
(BenchmarkState.prototype.isFirstTest): Deleted.
(BenchmarkState.prototype.prepareCurrentSuite): Deleted.
BenchmarkState was renamed to BenchmarkRunnerState to not be confused with the tests BenchmarkState.

  • Animometer/runner/resources/d3.min.js: Copied from Websites/perf.webkit.org/public/v2/js/d3/d3.min.js.

Needed for drawing charts for the sampled scores and frame rates.

  • Animometer/runner/resources/graph.js: Added.

(graph): Draws a chart for a test sampled data. It shows two y-axes: one for the animated items and the second for FPS.

  • Skipped: Skip the Animometer benchmark for now.
2:52 PM Changeset in webkit [190525] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

2:44 PM Changeset in webkit [190524] by Brent Fulgham
  • 2 edits in trunk/Tools

Provide "--no-ninja" option to avoid using Ninja
https://bugs.webkit.org/show_bug.cgi?id=149757

Reviewed by Alex Christensen.

Add a new command line argument understood by webkitdirs.pm so
that we can conditionally avoid using Ninja. This is an
'opt-out' argument, so no existing Ninja users should be affected.

  • Scripts/webkitdirs.pm:

(canUseNinja): Check for option and block ninja if present.

2:38 PM Changeset in webkit [190523] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648

Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-02
Reviewed by Alexey Proskuryakov.

  • TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
2:16 PM Changeset in webkit [190522] by ggaren@apple.com
  • 56 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the crash was a CodeBlock, after surviving a call to
deleteAllCode by virtue of being in the remembered set, trying to mark
its inlined CodeBlocks via pointers from its inlined executables.
Since deleteAllCode clears those pointers, the CodeBlock would ASSERT.
(Any other choice to retain a CodeBlock after deleteAllCode -- for
example, conservative marking -- could trigger the same bug.)

The fix is for InlineCallFrame to point directly to its inlined CodeBlock
instead of pointing indirectly via an executable. This guarantees that
CodeBlocks are GC safe regardless of whether we've called deleteAllCode.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

2:11 PM Changeset in webkit [190521] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Option-Click on a property name in the Computed view should jump to resource view
https://bugs.webkit.org/show_bug.cgi?id=149521

Patch by Devin Rousso <Devin Rousso> on 2015-10-02
Reviewed by Timothy Hatcher.

  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.effectivePropertyForName):
Now tries to search for a non-canonical property before falling back to
the canonical version.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
If the user option-clicks the goto arrow, it shows the source for the
property instead.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty.delegateShowProperty):
(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
Attempts to show the source of the given property. Will fallback to
highlighting the property in the rules panel.

1:40 PM Changeset in webkit [190520] by commit-queue@webkit.org
  • 35 edits
    4 copies
    11 adds in trunk

Web Inspector: Include Garbage Collection Event in Timeline
https://bugs.webkit.org/show_bug.cgi?id=142510

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-02
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/HeapObserver.h:
  • heap/Heap.cpp:

(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):

  • heap/Heap.h:

(JSC::Heap::addObserver):
(JSC::Heap::removeObserver):
Allow observers on heap to add hooks for starting / ending garbage collection.

  • inspector/InspectorEnvironment.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm):

  • inspector/JSGlobalObjectInspectorController.h:

Access the VM through the InspectorEnvironment as it won't change.

  • inspector/agents/InspectorHeapAgent.cpp: Added.

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::didCreateFrontendAndBackend):
(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorHeapAgent::enable):
(Inspector::InspectorHeapAgent::disable):
(Inspector::InspectorHeapAgent::gc):
(Inspector::protocolTypeForHeapOperation):
(Inspector::InspectorHeapAgent::willGarbageCollect):
(Inspector::InspectorHeapAgent::didGarbageCollect):

  • inspector/agents/InspectorHeapAgent.h: Added.
  • inspector/protocol/Heap.json: Added.

New domain and agent to handle tasks related to the JavaScriptCore heap.

Source/WebCore:

Tests: inspector/heap/garbageCollected.html

inspector/heap/gc.html

  • ForwardingHeaders/heap/HeapObserver.h: Added.
  • ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Added.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Forwarding headers.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::vm):

  • inspector/InspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::vm):

  • inspector/WorkerInspectorController.h:

Implement InspectorEnvironment::vm and create a Heap agent for the
Page inspector controller.

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:

(Array.prototype.parition):
Helper to partition an Array into two arrays.

  • UserInterface/Main.html:
  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.loaded):

  • UserInterface/Test.html:
  • UserInterface/Test/Test.js:

(WebInspector.loaded):

  • UserInterface/Protocol/HeapObserver.js:

(WebInspector.HeapObserver.prototype.garbageCollected):
(WebInspector.HeapObserver):
Create the new observer and manager.

  • UserInterface/Models/GarbageCollection.js:

(WebInspector.GarbageCollection):
(WebInspector.GarbageCollection.fromPayload):
(WebInspector.GarbageCollection.prototype.get type):
(WebInspector.GarbageCollection.prototype.get startTime):
(WebInspector.GarbageCollection.prototype.get endTime):
(WebInspector.GarbageCollection.prototype.get duration):
Model object for Heap.GarbageCollection.

  • UserInterface/Controllers/HeapManager.js:

(WebInspector.HeapManager):
(WebInspector.HeapManager.prototype.garbageCollected):
Dispatch events with.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype._garbageCollected):
Include new GC Timeline Events as Script events.

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
For the Script overview, make two sets of bars, one for Scripts and one for GCs.
The GCs bar will be on top of the the Scripts bar. This is particularly useful
since a GC can happen during script execution.

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ScriptTimelineDataGridNode):
Give a NaN call count to top level Script DataGridNodes.
In the UI, display the empty placeholder for NaN call counts.

  • UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.EventType.displayName):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._processPendingRecords):

  • UserInterface/Views/SourceCodeTimelineTreeElement.js:

(WebInspector.SourceCodeTimelineTreeElement):

  • UserInterface/Views/TimelineIcons.css:

(.garbage-collection-profile-record .icon):

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
UI for GC events.

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.createCombinedBars):
Simplify by storing start time into a variable.

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):
Icon for GC events.

LayoutTests:

  • inspector/heap/garbageCollected-expected.txt: Added.
  • inspector/heap/garbageCollected.html: Added.
  • inspector/heap/gc-expected.txt: Added.
  • inspector/heap/gc.html: Added.
1:38 PM Changeset in webkit [190519] by dbates@webkit.org
  • 2 edits in trunk/Tools

Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)

For now, pass --ios-simulator.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort._build_relay):

1:37 PM Changeset in webkit [190518] by Simon Fraser
  • 6 edits in trunk/LayoutTests

Test gardening.

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
1:18 PM Changeset in webkit [190517] by Simon Fraser
  • 2 edits in trunk/Tools

Remove a "nullable" that breaks the iOS 8 build.

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):

12:51 PM Changeset in webkit [190516] by jer.noble@apple.com
  • 3 edits
    3 adds in trunk

[MSE] Browser crashes when appending invalid data to MSE source buffer
https://bugs.webkit.org/show_bug.cgi?id=149689

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-stpp-crash.html

Bail out early (as specced) after disconnecting the SourceBuffer from its MediaSource.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):

LayoutTests:

  • media/content/stpp.mp4: Added.
  • media/media-source/media-source-stpp-crash-expected.txt: Added.
  • media/media-source/media-source-stpp-crash.html: Added.
12:43 PM Changeset in webkit [190515] by dbates@webkit.org
  • 4 edits in trunk/Tools

LayoutTestRelay is not built and archived when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=149753

Reviewed by Alexey Proskuryakov and Andy Estes.

Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
product archive when building for iOS Simulator, respectively.

  • BuildSlaveSupport/built-product-archive:

(main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
differentiate between iOS device and iOS Simulator platforms.
(webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
from determineWebKitBuildDirectories() into this function so that it can be used by both
determineWebKitBuildDirectories() and archiveBuiltProduct().
(determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
webkitBuildDirectoryForConfigurationAndPlatform().
(createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
for the limitation that ditto(1) can only accept a single directory to archive on its command line.
(archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.

  • Scripts/build-layouttestrelay:
    • Remove unnecessary include of Perl module POSIX.
    • Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
  • Scripts/build-webkit:
    • Invoke script build-layouttestrelay when building for iOS Simulator.
12:36 PM Changeset in webkit [190514] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
https://bugs.webkit.org/show_bug.cgi?id=149737
rdar://problem/19017465

Reviewed by Dean Jackson.

CoreAnimation can give us an animation beginTime that is slightly into the future,
which results in 'param' here being < 0, so relax the assertion slightly.

Fixes lots of assertions running iOS WK2 layout tests.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):

11:33 AM Changeset in webkit [190513] by peavo@outlook.com
  • 2 edits in trunk/Source/WebCore

[WinCairo] Fix linker warnings.
https://bugs.webkit.org/show_bug.cgi?id=149754

Reviewed by Alex Christensen.

Avoid compiling these files twice, they are already included in
RenderingAllInOne.cpp.

  • PlatformWinCairo.cmake:
11:29 AM Changeset in webkit [190512] by enrica@apple.com
  • 4 edits in trunk/Source/WebKit2

Text selection is inaccurate in Wikipedia pages when starting navigation from wikipedia.org.
https://bugs.webkit.org/show_bug.cgi?id=149756
rdar://problem/22332409

Reviewed by Tim Horton.

When loading a new document into the same WebPage object, we need
to clear the assisted node, since there is no guarantee that the
node will be blurred. The bug is caused by the use of a stale
assisted node to constrain the point where the gesture occurs.
A fix for this problem was landed in http://trac.webkit.org/changeset/179885
where the cleanup was added when FrameLoaderClient::detach2 was called.
This method doesn't seem to be called any longer for the main frame,
so the correct solution is to add the cleanup to didCommitLoad in WebPage.
I've also added some checks to webSelectionsRects and selectedTextRange to avoid
the use of postLayoutData when the selection is none.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView webSelectionRects]):
(-[WKContentView selectedTextRange]):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2): Removed call to resetAssistedNodeForFrame.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad): Added call to resetAssistedNodeForFrame.

10:58 AM Changeset in webkit [190511] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed test fix.

You cannot run 'run-webkit-tests' from the command line because it does not know
to append the binary subdirectory (bin32/bin64). We don't see this on our builders
because they explicitly set use the 'root' argument to provide the full path to
the test binaries.

  • Scripts/webkitpy/port/win.py:

(WinPort._build_path): Added.

10:46 AM Changeset in webkit [190510] by achristensen@apple.com
  • 15 edits
    3 adds in trunk

Source/WebCore:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

Test: http/tests/contentextensions/disable-blocker.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::userContentExtensionsEnabled):
(WebCore::DocumentLoader::setUserContentExtensionsEnabled):
Store and use the state of whether content blockers are enabled or not on the DocumentLoader
so that it stays constant for a document's entire life. This state comes from the Page when
making the DocumentLoader in WebKit2.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestInternal):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

  • page/UserContentController.cpp:

(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):

  • page/UserContentController.h:

Source/WebKit2:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createDocumentLoader):
Copy the state of whether content extensions are disabled from the Page to the DocumentLoader
when making a DocumentLoader.

Tools:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformConfigureViewForTest):
Test what happens when you disable content blockers from the SPI.

LayoutTests:
Reloading without content blockers doesn’t apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

  • http/tests/contentextensions/disable-blocker-expected.txt: Added.
  • http/tests/contentextensions/disable-blocker.html: Added.
  • http/tests/contentextensions/disable-blocker.html.json: Added.
10:30 AM Changeset in webkit [190509] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601-branch

Merged r190418. rdar://problem/22936771

10:28 AM Changeset in webkit [190508] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

9:55 AM Changeset in webkit [190507] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

8:13 AM Changeset in webkit [190506] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix indentation of console message parameters
https://bugs.webkit.org/show_bug.cgi?id=149740

Reviewed by Darin Adler.

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message .console-message-stack-trace-container > li):
(.console-message .console-message-extra-parameters-container > li::before):

8:13 AM Changeset in webkit [190505] by commit-queue@webkit.org
  • 28 edits in trunk

popstate is fired at the wrong time on load
https://bugs.webkit.org/show_bug.cgi?id=94265

Patch by Antoine Quint <Antoine Quint> on 2015-10-02
Reviewed by Darin Adler.

Source/WebCore:

Don't fire popstate event on initial document load

According to the specification [1], a popstate event should only be fired
when the document has a "last entry" and the entry being navigated to isn't
it. A document is created without a "last entry" and gets one just after
this check when it is first navigated to, so a popstate should be fired any
time a document is navigated to except for the first time after it has been
created.

Patch adapted from work by jl@opera.com on Blink [2].

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history (step 12-14 in particular)
[2] https://src.chromium.org/viewvc/blink?revision=165221&view=revision

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

Source/WebKit2:

Ensure we have a valid page before trying to get to its drawingArea as this could lead
to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

LayoutTests:

Updating tests that relied on a "popstate" event being fired at page load.

  • fast/history/same-document-iframes-changing-fragment-expected.txt:
  • fast/history/same-document-iframes-changing-pushstate-expected.txt:
  • fast/loader/javascript-url-iframe-remove-on-navigate.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
  • fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt:
  • fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
  • fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt:
  • fast/loader/stateobjects/popstate-fires-with-page-cache.html:
  • fast/loader/stateobjects/pushstate-object-types.html:
  • fast/loader/stateobjects/pushstate-then-replacestate.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
  • fast/loader/stateobjects/replacestate-then-pushstate.html:
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html:
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html:
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
  • http/tests/history/popstate-fires-with-pending-requests.html:
  • http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
  • http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:
7:08 AM Changeset in webkit [190504] by Andres Gomez
  • 2 edits
    1 copy
    1 move in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
https://bugs.webkit.org/show_bug.cgi?id=149227

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/NewTabPlus.svg: Updated.
  • UserInterface/Images/gtk/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
  • UserInterface/Images/gtk/Plus15.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
6:58 AM Changeset in webkit [190503] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r190380. rdar://problem/22888962

6:58 AM Changeset in webkit [190502] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601-branch/Source

Merge r190252. rdar://problem/22867962

6:58 AM Changeset in webkit [190501] by matthew_hanson@apple.com
  • 3 edits
    6 adds in branches/safari-601-branch

Merge r189560. rdar://problem/22824659

6:57 AM Changeset in webkit [190500] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch/Source/JavaScriptCore

Merge r189460. rdar://problem/22802036

6:57 AM Changeset in webkit [190499] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebKit/mac

Merge r189122. rdar://problem/22801996

6:57 AM Changeset in webkit [190498] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601-branch/Source

Merge r188990. rdar://problem/22802029

6:57 AM Changeset in webkit [190497] by matthew_hanson@apple.com
  • 3 edits
    4 adds in branches/safari-601-branch

Merge r188768. rdar://problem/22802019

6:57 AM Changeset in webkit [190496] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch

Merge r188755. rdar://problem/22802005

6:57 AM Changeset in webkit [190495] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebInspectorUI

Merge r188748. rdar://problem/22802023

6:57 AM Changeset in webkit [190494] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r188690. rdar://problem/22802006

6:56 AM Changeset in webkit [190493] by matthew_hanson@apple.com
  • 11 edits in branches/safari-601-branch/Source

Merge r189102. rdar://problem/22802034

6:56 AM Changeset in webkit [190492] by matthew_hanson@apple.com
  • 7 edits
    3 adds in branches/safari-601-branch

Merge r188640. rdar://problem/22802005

6:56 AM Changeset in webkit [190491] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601-branch

Merge r188634. rdar://problem/22802013

6:56 AM Changeset in webkit [190490] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r188622. rdar://problem/22802016

6:56 AM Changeset in webkit [190489] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch/Source/WebCore

Merge r188298. rdar://problem/22885242

6:56 AM Changeset in webkit [190488] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r187921. rdar://problem/22801988

6:56 AM Changeset in webkit [190487] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r187593. rdar://problem/22801973

6:56 AM Changeset in webkit [190486] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601-branch

Merge r187210. rdar://problem/22801995

6:56 AM Changeset in webkit [190485] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r187145. rdar://problem/22801952

5:14 AM Changeset in webkit [190484] by jfernandez@igalia.com
  • 9 edits
    42 adds in trunk

[CSS Grid Layout] Support for Content Alignment in grid layout
https://bugs.webkit.org/show_bug.cgi?id=145520

Reviewed by Darin Adler.

Source/WebCore:

According to CSS Box Alignment specification, Content Distribution
alignment controls alignment of the box's content within the box. The
alignment container is the grid container's content box. The alignment
subjects are the grid tracks.

This patch implements Grid Layout support for Content Distribution
alignment along both block/column and inline/row axis, which are handled
by align-content and justify-content properties respectively.

This patch provides support for overflow handling, similar to what
Self Alignment provides with grid items, and both <content-position>
and <content-distribution> values.

Baseline Alignment is still missing because it requires some additional
behavior to be supported on grids before considering its implementation.

Tests: css3/overwrite-content-alignment.html

css3/overwrite-self-alignment.html
fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html
fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html
fast/css-grid-layout/grid-align-content-distribution.html
fast/css-grid-layout/grid-align-content-vertical-lr.html
fast/css-grid-layout/grid-align-content-vertical-rl.html
fast/css-grid-layout/grid-align-content.html
fast/css-grid-layout/grid-content-alignment-overflow.html
fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html
fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html
fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html
fast/css-grid-layout/grid-content-alignment-with-span.html
fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html
fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html
fast/css-grid-layout/grid-justify-content-distribution.html
fast/css-grid-layout/grid-justify-content-vertical-lr.html
fast/css-grid-layout/grid-justify-content-vertical-rl.html
fast/css-grid-layout/grid-justify-content.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::RenderFlexibleBox::alignFlexLines):

  • rendering/RenderGrid.cpp:

(WebCore::ContentAlignmentData::ContentAlignmentData):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::resolveContentDistributionFallback):
(WebCore::offsetToStartEdge):
(WebCore::offsetToEndEdge):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionColumnOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionRowOffset):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::computePreferredLogicalWidths): Deleted.
(WebCore::RenderGrid::autoPlacementMajorAxisDirection): Deleted.
(WebCore::RenderGrid::autoPlacementMinorAxisDirection): Deleted.
(WebCore::RenderGrid::cachedGridCoordinate): Deleted.
(WebCore::RenderGrid::rowPositionForChild): Deleted.

  • rendering/RenderGrid.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::resolvedAlignContentPosition):
(WebCore::RenderStyle::resolvedAlignContentDistribution):
(WebCore::RenderStyle::resolvedJustifyContentPosition):
(WebCore::RenderStyle::resolvedJustifyContentDistribution):

  • rendering/style/RenderStyle.h:

LayoutTests:

Content Distribution alignment controls alignment of the box's
content within the box. The alignment container is the grid
container's content box. The alignment subjects are the grid
tracks.

In addition to the tests to verify the new functionality, I've
added some tests to check out that the new complex values are
overwritten properly.

I had to modify the grid-item-margin-auto-columns-rows-horizontal-rtl
test because when using RTL direction the whole grid must flow form
right to left, not only its items, so I rebaselined text expectations
to adapt it to the new behavior.

  • css3/overwrite-content-alignment-expected.txt: Added.
  • css3/overwrite-content-alignment.html: Added.
  • css3/overwrite-self-alignment-expected.txt: Added.
  • css3/overwrite-self-alignment.html: Added.
  • fast/css-grid-layout/grid-align-content-distribution-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-align-content-distribution.html: Added.
  • fast/css-grid-layout/grid-align-content-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-align-content-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-align-content.html: Added.
  • fast/css-grid-layout/grid-content-alignment-overflow-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-overflow.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl-expected.html:
  • fast/css-grid-layout/grid-justify-content-distribution-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-justify-content-distribution.html: Added.
  • fast/css-grid-layout/grid-justify-content-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-justify-content.html: Added.
  • fast/css-grid-layout/resources/grid.css:

(.firstRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowThirdColumn):
(.secondRowFourthColumn):
(.thirdRowFirstColumn):
(.thirdRowSecondColumn):
(.fourthRowFirstColumn):
(.fourthRowSecondColumn):

4:26 AM Changeset in webkit [190483] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

4:07 AM Changeset in webkit [190482] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Attempted build fix.

  • DerivedSources.make:
  • page/make_settings.pl:

(printGetterAndSetter):

3:53 AM Changeset in webkit [190481] by dino@apple.com
  • 8 edits
    2 adds in trunk

Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

  • html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.

  • html/canvas/WebGLRenderingContextBase.h:
  • page/Settings.in: Remove privilegedWebGLExtensions.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader

extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

  • fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
  • fast/canvas/webgl/webgl-debug-renderer-info.html: Added.
1:17 AM Changeset in webkit [190480] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r190447. rdar://problem/22865007

1:16 AM Changeset in webkit [190479] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/LayoutTests

Merged r190438. rdar://problem/22865007

1:15 AM Changeset in webkit [190478] by bshafiei@apple.com
  • 18 edits in branches/safari-601.1.46-branch

Merged r190434. rdar://problem/22865007

1:14 AM Changeset in webkit [190477] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r190380. rdar://problem/22888927

1:13 AM Changeset in webkit [190476] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46-branch

Merged r190375. rdar://problem/22881731

1:12 AM Changeset in webkit [190475] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r190327. rdar://problem/22865398

1:11 AM Changeset in webkit [190474] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit/mac

Merged r190092. rdar://problem/22824439

1:10 AM Changeset in webkit [190473] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r189773. rdar://problem/22824430

1:09 AM Changeset in webkit [190472] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46-branch

Merged r189560. rdar://problem/22824445

1:08 AM Changeset in webkit [190471] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r189366. rdar://problem/22824453

1:07 AM Changeset in webkit [190470] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r189322. rdar://problem/22824435

1:06 AM Changeset in webkit [190469] by bshafiei@apple.com
  • 3 edits
    4 copies in branches/safari-601.1.46-branch

Merged r188768. rdar://problem/22707478

1:05 AM Changeset in webkit [190468] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch

Merged r188755. rdar://problem/22707467

1:04 AM Changeset in webkit [190467] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188690. rdar://problem/22707471

1:03 AM Changeset in webkit [190466] by bshafiei@apple.com
  • 7 edits
    3 copies in branches/safari-601.1.46-branch

Merged r188640. rdar://problem/22707467

1:02 AM Changeset in webkit [190465] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188634. rdar://problem/22707475

1:01 AM Changeset in webkit [190464] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188622. rdar://problem/22823235

1:00 AM Changeset in webkit [190463] by bshafiei@apple.com
  • 11 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188405. rdar://problem/22707490

12:58 AM Changeset in webkit [190462] by bshafiei@apple.com
  • 8 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188182. rdar://problem/22707488

12:57 AM Changeset in webkit [190461] by bshafiei@apple.com
  • 1 edit
    4 copies in branches/safari-601.1.46-branch/LayoutTests

Merged r188016. rdar://problem/22707482

12:56 AM Changeset in webkit [190460] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r187994. rdar://problem/22707482

12:55 AM Changeset in webkit [190459] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46-branch

Merged r187921. rdar://problem/22707460

12:54 AM Changeset in webkit [190458] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-601.1.46-branch

Merged r187210. rdar://problem/22707464

12:53 AM Changeset in webkit [190457] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r187145. rdar://problem/22707457

Oct 1, 2015:

10:44 PM Changeset in webkit [190456] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the #if guard in PointerLockController.cpp
https://bugs.webkit.org/show_bug.cgi?id=149705

Reviewed by Gyuyoung Kim.

  • page/PointerLockController.cpp:
10:37 PM Changeset in webkit [190455] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46-branch

Merged r190418. rdar://problem/22936628

10:35 PM Changeset in webkit [190454] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188298. rdar://problem/22936040

9:48 PM Changeset in webkit [190453] by ggaren@apple.com
  • 44 edits in trunk/Source/JavaScriptCore

2015-10-01 Geoffrey Garen <ggaren@apple.com>

Unreviewed, rolling out r190450
https://bugs.webkit.org/show_bug.cgi?id=148560

Crashes seen on el cap wk1 bots.

Reverted changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::inferredName): (JSC::CodeBlock::dumpAssumingJITType): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::setNumParameters): (JSC::CodeBlock::specialOSREntryBlockOrNull): (JSC::CodeBlock::visitStrongly): (JSC::CodeBlock::visitAggregate): (JSC::CodeBlock::shouldVisitStrongly): (JSC::CodeBlock::isKnownToBeLiveDuringGC): (JSC::CodeBlock::shouldJettisonDueToWeakReference): (JSC::CodeBlock::shouldJettisonDueToOldAge): (JSC::CodeBlock::determineLiveness): (JSC::CodeBlock::visitWeakReferences): (JSC::CodeBlock::finalizeLLIntInlineCaches): (JSC::CodeBlock::finalizeBaselineJITInlineCaches): (JSC::CodeBlock::finalizeUnconditionally): (JSC::CodeBlock::visitOSRExitTargets): (JSC::CodeBlock::unlinkIncomingCalls): (JSC::CodeBlock::linkIncomingCall): (JSC::CodeBlock::newReplacement): (JSC::ProgramCodeBlock::replacement): (JSC::ModuleProgramCodeBlock::replacement): (JSC::EvalCodeBlock::replacement): (JSC::FunctionCodeBlock::replacement): (JSC::ProgramCodeBlock::capabilityLevelInternal): (JSC::ModuleProgramCodeBlock::capabilityLevelInternal): (JSC::EvalCodeBlock::capabilityLevelInternal): (JSC::FunctionCodeBlock::capabilityLevelInternal): (JSC::WebAssemblyCodeBlock::replacement): (JSC::WebAssemblyCodeBlock::capabilityLevelInternal): (JSC::CodeBlock::jettison): (JSC::CodeBlock::capabilityLevel): (JSC::FunctionCodeBlock::destroy): Deleted. (JSC::WebAssemblyCodeBlock::destroy): Deleted. (JSC::ProgramCodeBlock::destroy): Deleted. (JSC::ModuleProgramCodeBlock::destroy): Deleted. (JSC::EvalCodeBlock::destroy): Deleted. (JSC::CodeBlock::finishCreation): Deleted. (JSC::CodeBlock::setAlternative): Deleted. (JSC::CodeBlock::visitWeakly): Deleted. (JSC::CodeBlock::visitChildren): Deleted. (JSC::timeToLive): Deleted. (JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences): Deleted. (JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Deleted. (JSC::CodeBlock::replacement): Deleted. (JSC::CodeBlock::computeCapabilityLevel): Deleted.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::unlinkedCodeBlock): (JSC::CodeBlock::addressOfNumParameters): (JSC::CodeBlock::offsetOfNumParameters): (JSC::CodeBlock::alternative): (JSC::CodeBlock::setAlternative): (JSC::CodeBlock::forEachRelatedCodeBlock): (JSC::CodeBlock::specializationKind): (JSC::CodeBlock::instructionCount): (JSC::CodeBlock::setJITCode): (JSC::CodeBlock::hasBaselineJITProfiling): (JSC::CodeBlock::capabilityLevelState): (JSC::CodeBlock::addConstant): (JSC::CodeBlock::appendExceptionHandler): (JSC::CodeBlock::setConstantRegisters): (JSC::CodeBlock::replaceConstant): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::EvalCodeBlock::variable): (JSC::EvalCodeBlock::numVariables): (JSC::EvalCodeBlock::unlinkedEvalCodeBlock): (JSC::FunctionCodeBlock::FunctionCodeBlock): (JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock): (JSC::ExecState::uncheckedR): (JSC::CodeBlock::clearMarks): (JSC::CodeBlockSet::mark): (JSC::ScriptExecutable::forEachCodeBlock): (JSC::ProgramCodeBlock::create): Deleted. (JSC::ProgramCodeBlock::createStructure): Deleted. (JSC::ModuleProgramCodeBlock::create): Deleted. (JSC::ModuleProgramCodeBlock::createStructure): Deleted. (JSC::EvalCodeBlock::create): Deleted. (JSC::EvalCodeBlock::createStructure): Deleted. (JSC::FunctionCodeBlock::create): Deleted. (JSC::FunctionCodeBlock::createStructure): Deleted. (JSC::WebAssemblyCodeBlock::create): Deleted. (JSC::WebAssemblyCodeBlock::createStructure): Deleted. (JSC::CodeBlock::clearVisitWeaklyHasBeenCalled): Deleted.
  • bytecode/DeferredCompilationCallback.cpp: (JSC::DeferredCompilationCallback::DeferredCompilationCallback): (JSC::DeferredCompilationCallback::~DeferredCompilationCallback): (JSC::DeferredCompilationCallback::compilationDidComplete):
  • bytecode/DeferredCompilationCallback.h:
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::tryGet): (JSC::EvalCodeCache::getSlow):
  • bytecode/PolymorphicAccess.cpp: (JSC::AccessCase::generate): (JSC::PolymorphicAccess::regenerate):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::addAccessCase):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
  • dfg/DFGDesiredTransitions.cpp: (JSC::DFG::DesiredTransition::reallyAdd):
  • dfg/DFGDesiredWeakReferences.cpp: (JSC::DFG::DesiredWeakReferences::reallyAdd):
  • dfg/DFGDriver.cpp: (JSC::DFG::compile):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::Graph):
  • dfg/DFGJITCode.h: (JSC::DFG::JITCode::osrEntryBlock): Deleted. (JSC::DFG::JITCode::setOSREntryBlock): Deleted. (JSC::DFG::JITCode::clearOSREntryBlock): Deleted.
  • dfg/DFGJITFinalizer.cpp: (JSC::DFG::JITFinalizer::finalize): (JSC::DFG::JITFinalizer::finalizeFunction): (JSC::DFG::JITFinalizer::finalizeCommon):
  • dfg/DFGOSRExitCompilerCommon.cpp: (JSC::DFG::adjustAndJumpToTarget):
  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp: (JSC::DFG::Plan::Plan): (JSC::DFG::Plan::reallyAdd): (JSC::DFG::Plan::notifyReady): (JSC::DFG::Plan::finalizeWithoutNotifyingCallback): (JSC::DFG::Plan::finalizeAndNotifyCallback): (JSC::DFG::Plan::key): (JSC::DFG::Plan::clearCodeBlockMarks): (JSC::DFG::Plan::checkLivenessAndVisitChildren): (JSC::DFG::Plan::rememberCodeBlocks): Deleted.
  • dfg/DFGPlan.h:
  • dfg/DFGToFTLDeferredCompilationCallback.cpp: (JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback): (JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback): (JSC::DFG::ToFTLDeferredCompilationCallback::create): (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
  • dfg/DFGToFTLDeferredCompilationCallback.h:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp: (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback): (JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h:
  • dfg/DFGWorklist.cpp: (JSC::DFG::Worklist::completeAllPlansForVM): (JSC::DFG::Worklist::clearCodeBlockMarks): (JSC::DFG::completeAllPlansForVM): (JSC::DFG::clearCodeBlockMarks): (JSC::DFG::Worklist::rememberCodeBlocks): Deleted. (JSC::DFG::rememberCodeBlocks): Deleted.
  • dfg/DFGWorklist.h: (JSC::DFG::worklistForIndexOrNull):
  • ftl/FTLJITFinalizer.cpp: (JSC::FTL::JITFinalizer::finalizeFunction):
  • heap/CodeBlockSet.cpp: (JSC::CodeBlockSet::~CodeBlockSet): (JSC::CodeBlockSet::add): (JSC::CodeBlockSet::clearMarksForFullCollection): (JSC::CodeBlockSet::clearMarksForEdenCollection): (JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): (JSC::CodeBlockSet::remove): (JSC::CodeBlockSet::traceMarked): (JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks): (JSC::CodeBlockSet::dump):
  • heap/CodeBlockSet.h:
  • heap/Heap.cpp: (JSC::Heap::markRoots): (JSC::Heap::clearLivenessData): (JSC::Heap::traceCodeBlocksAndJITStubRoutines): (JSC::Heap::deleteAllCodeBlocks): (JSC::Heap::deleteAllUnlinkedCodeBlocks): (JSC::Heap::clearUnmarkedExecutables): (JSC::Heap::willStartCollection):
  • interpreter/Interpreter.cpp: (JSC::eval):
  • jit/GCAwareJITStubRoutine.h:
  • jit/JITCode.h: (JSC::JITCode::isJIT): (JSC::JITCode::timeToLive): (JSC::JITCode::isLowerTier):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_enter):
  • jit/JITOperations.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp: (JSC::JITToDFGDeferredCompilationCallback::create): (JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
  • jit/JITToDFGDeferredCompilationCallback.h:
  • jit/Repatch.cpp: (JSC::tryCacheGetByID): (JSC::tryCachePutByID): (JSC::tryRepatchIn): (JSC::linkFor): (JSC::linkPolymorphicCall):
  • llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): (JSC::LLInt::setUpCall):
  • runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):
  • runtime/CommonSlowPaths.h: (JSC::CommonSlowPaths::tryCachePutToScopeGlobal): (JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
  • runtime/Executable.cpp: (JSC::ExecutableBase::clearCode): (JSC::ScriptExecutable::installCode): (JSC::ScriptExecutable::newCodeBlockFor): (JSC::ScriptExecutable::newReplacementCodeBlockFor): (JSC::ScriptExecutable::prepareForExecutionImpl): (JSC::EvalExecutable::visitChildren): (JSC::EvalExecutable::clearCode): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::visitChildren): (JSC::ProgramExecutable::clearCode): (JSC::ModuleProgramExecutable::visitChildren): (JSC::ModuleProgramExecutable::clearCode): (JSC::FunctionExecutable::baselineCodeBlockFor): (JSC::FunctionExecutable::visitChildren): (JSC::FunctionExecutable::clearCode): (JSC::FunctionExecutable::fromGlobalCode): (JSC::WebAssemblyExecutable::visitChildren): (JSC::WebAssemblyExecutable::clearCode): (JSC::WebAssemblyExecutable::prepareForExecution):
  • runtime/Executable.h: (JSC::ExecutableBase::generatedJITCodeForCall): (JSC::ScriptExecutable::prepareForExecution): (JSC::ExecutableBase::clearCodeVirtual):
  • runtime/VM.cpp: (JSC::VM::VM):
  • runtime/VM.h:
9:35 PM Changeset in webkit [190452] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed build fix for run-api-tests

  • Scripts/run-api-tests:

(testToolPaths): Windows run needs to specify the binary path.

9:27 PM Changeset in webkit [190451] by wenson_hsieh@apple.com
  • 2 edits
    2 adds
    1 delete in trunk

Convert focused-input-should-assist-on-touch.html into an automated test
https://bugs.webkit.org/show_bug.cgi?id=149724

Reviewed by Simon Fraser.

.:

Remove a manual test that can now be rewritten as an automated test.

  • ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.

LayoutTests:

Tests that an input that focuses itself on touch and then prevents default is
able to trigger node assistance, even when it is already focused before the
user gesture.

  • fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
  • fast/events/ios/focused-input-should-assist-on-touch.html: Added.
8:45 PM Changeset in webkit [190450] by ggaren@apple.com
  • 44 edits in trunk/Source/JavaScriptCore

CodeBlock should be a GC object
https://bugs.webkit.org/show_bug.cgi?id=149727

Reviewed by Filip Pizlo.

We want CodeBlock to be a GC object:

(1) Sane write barriers. Because CodeBlock wasn't a GC object, we couldn't
execute a write barrier on it. This caused us to do weird things that
were hard to reason about, like executing a barrier on a related executable
(even though the executable might stop pointing to the CodeBlock before
the next GC), or pretending that an object had written to itself. Now,
when we write to a CodeBlock, we barrier the CodeBlock, and that's that.

(2) Simpler marking and destruction logic. There's no need to have a
custom remembered set or a destruction fixpoint if we just obey normal
GC rules.

  • bytecode/CodeBlock.cpp:

(JSC::FunctionCodeBlock::destroy):
(JSC::WebAssemblyCodeBlock::destroy):
(JSC::ProgramCodeBlock::destroy):
(JSC::ModuleProgramCodeBlock::destroy):
(JSC::EvalCodeBlock::destroy): Add ClassInfo and destroy functions
because our GC object model requires them.

Note that we do not set the needsDestruction flag. Since CodeBlock needs
eager destruction, it runs its destructors through CodeBlockSet,
and not through normal object sweeping.

(JSC::CodeBlock::finishCreation): Factor out finishCreation from the
constructor because our GC object model requires it. Change write
barriers to note the CodeBlock as the owner.

(JSC::CodeBlock::~CodeBlock): Refactor to use the shared
unlinkIncomingCalls() function instead of rolling a copy by hand.

(JSC::CodeBlock::visitWeakly): New helper function for owner executables
to do weak marking that might jettison a CodeBlock. Our new GC logic
says that a CodeBlock pointer is a strong reference by default, and
clients need to opt in if they want to allow a CodeBlock to jettison.
This is easier to get right because it means that only those
specific owners that want jettison behavior need to worry about it,
while all other pointers are valid by default.

(JSC::CodeBlock::visitChildren): The default visit function keeps
everything alive.

(JSC::CodeBlock::shouldVisitStrongly):
(JSC::CodeBlock::isKnownToBeLiveDuringGC): No need to keep special state
anymore. If we're marked, we're live -- just like any other object.

(JSC::timeToLive): Move this code into CodeBlock.cpp so you can mess
with it without recompiling, and also because it's really a CodeBlock
policy.

(JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences):
(JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Use
internal objects for virtual callbacks because GC objects can't have
vtables.

(JSC::CodeBlock::unlinkIncomingCalls): Remove a fast path check that does
not exist in the copy of this code in ~CodeBlock because it is not
actually an optimization.

(JSC::CodeBlock::replacement):
(JSC::CodeBlock::computeCapabilityLevel): Make these functions generic
instead of virtual because GC objects can't have vtables.

(JSC::CodeBlock::visitStrongly): Deleted.
(JSC::CodeBlock::visitAggregate): Deleted.
(JSC::CodeBlock::visitWeakReferences): Deleted.
(JSC::CodeBlock::finalizeUnconditionally): Deleted.
(JSC::ProgramCodeBlock::replacement): Deleted.
(JSC::ModuleProgramCodeBlock::replacement): Deleted.
(JSC::EvalCodeBlock::replacement): Deleted.
(JSC::FunctionCodeBlock::replacement): Deleted.
(JSC::ProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::ModuleProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::EvalCodeBlock::capabilityLevelInternal): Deleted.
(JSC::FunctionCodeBlock::capabilityLevelInternal): Deleted.
(JSC::WebAssemblyCodeBlock::replacement): Deleted.
(JSC::WebAssemblyCodeBlock::capabilityLevelInternal): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::unlinkedCodeBlock):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::alternative):
(JSC::CodeBlock::forEachRelatedCodeBlock):
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::capabilityLevelState):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::appendExceptionHandler):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::replaceConstant):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::create):
(JSC::ProgramCodeBlock::createStructure):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::ModuleProgramCodeBlock::create):
(JSC::ModuleProgramCodeBlock::createStructure):
(JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock):
(JSC::EvalCodeBlock::create):
(JSC::EvalCodeBlock::createStructure):
(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::EvalCodeBlock::unlinkedEvalCodeBlock):
(JSC::FunctionCodeBlock::create):
(JSC::FunctionCodeBlock::createStructure):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::WebAssemblyCodeBlock::create):
(JSC::WebAssemblyCodeBlock::createStructure):
(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock):
(JSC::ExecState::uncheckedR):
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled):
(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):
(JSC::CodeBlock::setAlternative): Deleted.
(JSC::CodeBlock::clearMarks): Deleted. Lots of mechanical changes to
match the logic changes above.

  • bytecode/DeferredCompilationCallback.cpp:

(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::compilationDidComplete):

  • bytecode/DeferredCompilationCallback.h: Provide a profiledDFGCodeBlock

to all compilation callbacks instead of requiring the callback to
store the profiledDFGCodeBlock. This is how the rest of compilation
around the callback works anyway, and it is easier to do things this
way than to think about how a non-GC malloc'd object should keep its
CodeBlock alive.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::addAccessCase): Change the owner for write
barrier purposes to CodeBlock.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::reallyAdd):

  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::reallyAdd):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph): Ditto.

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
(JSC::DFG::JITCode::clearOSREntryBlock): Use helper functions for
accessing osrEntryBlock to help with write barrier stuff.

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget): Use CodeBlock as owner instead of
executable.

  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
(JSC::DFG::Plan::key):
(JSC::DFG::Plan::rememberCodeBlocks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::clearCodeBlockMarks): Deleted.

  • dfg/DFGPlan.h: Use normal GC write barrier concepts to model the fact

that the compiler writes to CodeBlocks.

  • dfg/DFGToFTLDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::create):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):

  • dfg/DFGToFTLDeferredCompilationCallback.h:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):

  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h: We always have

a profiledDFGCodeBlock passed to use -- see above.

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::rememberCodeBlocks):
(JSC::DFG::completeAllPlansForVM):
(JSC::DFG::rememberCodeBlocks):
(JSC::DFG::Worklist::clearCodeBlockMarks): Deleted.
(JSC::DFG::clearCodeBlockMarks): Deleted.

  • dfg/DFGWorklist.h:

(JSC::DFG::worklistForIndexOrNull): Renamed to use remembered set terminology.

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::~CodeBlockSet):
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): No need for a fixpoint
anymore since the GC can tell us if we are live.

(JSC::CodeBlockSet::remove):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):
(JSC::CodeBlockSet::clearMarksForEdenCollection): Deleted. No need for
this logic anymore since the GC will clear our mark bit.

(JSC::CodeBlockSet::traceMarked): Deleted. No need for this marking
fixpoint anymore either.

  • heap/CodeBlockSet.h:
  • heap/Heap.cpp:

(JSC::Heap::markRoots): Moved some of this logic around to make the
algorithm clearer.

(JSC::Heap::deleteAllCodeBlocks): Deleting CodeBlocks can only clear
pointers immediately; they won't fully delete until the next GC and sweep.

  • interpreter/Interpreter.cpp:

(JSC::eval):

  • jit/GCAwareJITStubRoutine.h: CodeBlock is owner now.
  • jit/JITCode.h:

(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::timeToLive): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_enter): CodeBlock is owner now.

  • jit/JITOperations.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp:

(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

  • jit/JITToDFGDeferredCompilationCallback.h:
  • jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
(JSC::linkFor):
(JSC::linkPolymorphicCall):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal): CodeBlock is owner now.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode): Provide a generic clearCode() so that
it can be used on any Executable. This fixes a very subtle bug where
deleteAllCode() does not remove CodeBlocks from non-function executables
that have been saved in stack traces.

(JSC::ScriptExecutable::installCode): WriteBarrier requires special
handling for pointers that may be null.

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl): Update for interface
changes.

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::ModuleProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
(JSC::WebAssemblyExecutable::visitChildren): Visit weakly because we want
to participate in jettisoning.

(JSC::WebAssemblyExecutable::prepareForExecution):
(JSC::EvalExecutable::clearCode): Deleted.
(JSC::ProgramExecutable::clearCode): Deleted.
(JSC::ModuleProgramExecutable::clearCode): Deleted.
(JSC::FunctionExecutable::clearCode): Deleted.
(JSC::WebAssemblyExecutable::clearCode): Deleted.

  • runtime/Executable.h:

(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::ExecutableBase::clearCodeVirtual): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h: Provide structures because our GC requires it.
7:15 PM Changeset in webkit [190449] by dino@apple.com
  • 8 edits
    2 deletes in trunk

Rollout r190446 for the moment. It broke the build.

6:53 PM Changeset in webkit [190448] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Simplify filterableData processing
https://bugs.webkit.org/show_bug.cgi?id=149730

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-01
Reviewed by Timothy Hatcher.

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype.get filterableData):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):

  • UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype.get filterableData):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.

  • UserInterface/Views/SearchResultTreeElement.js:

(WebInspector.SearchResultTreeElement.prototype.get filterableData):
(WebInspector.SearchResultTreeElement):

6:29 PM Changeset in webkit [190447] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build warning after r190434

Fix error: variable ‘interruption’ set but not used [-Werror=unused-but-set-variable]

  • testing/Internals.cpp:

(WebCore::Internals::beginMediaSessionInterruption):

6:09 PM Changeset in webkit [190446] by dino@apple.com
  • 8 edits
    2 adds in trunk

Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

  • html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.

  • html/canvas/WebGLRenderingContextBase.h:
  • page/Settings.in: Remove privilegedWebGLExtensions.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader

extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

  • fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
  • fast/canvas/webgl/webgl-debug-renderer-info.html: Added.
6:03 PM Changeset in webkit [190445] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.2.7.2

New tag.

6:01 PM Changeset in webkit [190444] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

5:56 PM Changeset in webkit [190443] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.25.1

New tag.

5:56 PM Changeset in webkit [190442] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.2.7.1

New tag.

5:21 PM Changeset in webkit [190441] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaselining fast/text/mark-matches-overflow-clip.html for Win
https://webkit.org/b/149728

Unreviewed test gardening.

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-01

  • platform/win/fast/text/mark-matches-overflow-clip-expected.txt:
5:09 PM Changeset in webkit [190440] by Brent Fulgham
  • 4 edits in trunk

.:
[Win] Unreviewed CMake build fix.

  • Source/cmake/OptionsWin.cmake: Clean up options setttings,

and make sure exception handling is turned off.

Tools:
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

Patch by Daniel Bates <dabates@apple.com> on 2015-10-01

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

5:03 PM Changeset in webkit [190439] by dbates@webkit.org
  • 2 edits in trunk/Tools

Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

4:43 PM Changeset in webkit [190438] by Brent Fulgham
  • 3 edits in trunk/LayoutTests

Unreviewed test fix after r190434.

One test was not updated to pass the new required interruption type
argument to 'internals.beginMediaSessionInterruption'.

  • webaudio/audiocontext-state-interrupted-expected.txt:
  • webaudio/audiocontext-state-interrupted.html:
4:34 PM Changeset in webkit [190437] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149726

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-01
Reviewed by Timothy Hatcher.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
We were populating during filtering if there were any custom filters.
However the TimelineSidebarPanel has custom filters (based on time and type)
but those don't need to trigger population. Delay population until it
would actually be needed (like a text search).

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
Do not populate on filter via this custom filters.

4:33 PM Changeset in webkit [190436] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
https://bugs.webkit.org/show_bug.cgi?id=149725

Reviewed by Timothy Hatcher.

CSS Flexible Box Layout Module Level 1 introduces a new auto initial value for the min-{width|height}
of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
zero for the #main <div>.

  • UserInterface/Views/Main.css:

(#main):

4:21 PM Changeset in webkit [190435] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unnecessary SpecialFastCaseProfiles.
https://bugs.webkit.org/show_bug.cgi?id=149729

Reviewed by Saam Barati.

The current baseline code creates special fast case profiles records for
bytecodes that don't need them. This was done to keep the DFG from crashing when
it searches for such a profile and don't find one. Instead, we will fix the code
to check for the existence of the profile before dereferencing it to get a count.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(JSC::CodeBlock::likelyToTakeSpecialFastCase): Deleted. Not used.
(JSC::CodeBlock::likelyToTakeAnySlowCase): Deleted. Not used.

  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):

  • Only op_mul needs the profile. So, only allocate it in the op_mul case.

(JSC::JIT::emit_op_mul):

  • These op_mul cases create the profile but never increments its counter. Hence, we can get rid of these.
3:32 PM Changeset in webkit [190434] by Brent Fulgham
  • 18 edits in trunk

[iOS] AirPlay should not stop when the screen locks
https://bugs.webkit.org/show_bug.cgi?id=148315
<rdar://problem/22770703>

Patch by Eric Carlson <eric.carlson@apple.com> on 2015-10-01
Reviewed by Jer Noble.

Source/WebCore:

Tested by media/video-interruption-with-resume-allowing-play.html

media/video-interruption-with-resume-not-allowing-play.html

  • Modules/webaudio/AudioContext.h: overrideBackgroundPlaybackRestriction -> shouldOverrideBackgroundPlaybackRestriction.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspendPlayback): Fix a typo in the logging.
(WebCore::HTMLMediaElement::mayResumePlayback): Ditto.
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction): Renamed from

overrideBackgroundPlaybackRestriction.

(WebCore::HTMLMediaElement::overrideBackgroundPlaybackRestriction): Deleted.

  • html/HTMLMediaElement.h:
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::stateName):
(WebCore::interruptionName): New, log the name of the interruption.
(WebCore::PlatformMediaSession::beginInterruption): Log the interruption type. Don't

increment the interruption counter if we are going to ignore it. Incorporate logic
from doInterruption.

(WebCore::PlatformMediaSession::doInterruption): Deleted.
(WebCore::PlatformMediaSession::shouldDoInterruption): Deleted.
(WebCore::PlatformMediaSession::forceInterruption): Deleted.

  • platform/audio/PlatformMediaSession.h: Add SuspendedUnderLock interruption type.
  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): Deleted.

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::applicationDidEnterBackground): Call beginInterruption

when appropriate.

LayoutTests:

  • media/video-interruption-with-resume-allowing-play.html:
  • media/video-interruption-with-resume-not-allowing-play.html:
2:40 PM Changeset in webkit [190433] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.2.7-branch

Merged r190418. rdar://problem/22936771

2:37 PM Changeset in webkit [190432] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

1:47 PM Changeset in webkit [190431] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46.25-branch

Merged r190418. rdar://problem/22936628

1:36 PM Changeset in webkit [190430] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Slot elements should support fallback contents
https://bugs.webkit.org/show_bug.cgi?id=149701

Reviewed by Antti Koivisto.

Source/WebCore:

Following discussions on Github discussions [1] [2], we're adding the default rule of display: contents
on slot elements and making slot elements render its children when there are no assigned nodes [3].

Make these changes by attaching renderers on direct-children of slot elements when there are no assigned
nodes during render tree construction. Note display: contents will be aded in webkit.org/b/149439.

[1] https://github.com/w3c/webcomponents/issues/317
[2] https://github.com/w3c/webcomponents/issues/308
[3] https://github.com/w3c/webcomponents/issues/308#issuecomment-143655347

Tests: fast/shadow-dom/css-scoping-shadow-slot-fallback.html

fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachSlotAssignees):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::resolveSlotAssignees):

LayoutTests:

Added tests for fallback contents in slot elements. One of them could be safely submitted to CSS WG,
and the other one is a style recalc test.

  • fast/shadow-dom/css-scoping-shadow-slot-fallback-expected.html: Added.
  • fast/shadow-dom/css-scoping-shadow-slot-fallback.html: Added.
  • fast/shadow-dom/shadow-layout-after-slot-fallback-changes-expected.html: Added.
  • fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html: Added.
1:24 PM Writing Layout Tests to test iOS UI features edited by wenson_hsieh@apple.com
Added documentation on key event testing to UIScriptController wiki page (diff)
1:20 PM Changeset in webkit [190429] by keith_miller@apple.com
  • 19 edits
    1 copy
    21 adds in trunk

[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):

  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):

  • runtime/JSGenericTypedArrayViewInlines.h:
  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.

(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):

  • runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSObject.h:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrayPrototypes.h:
  • runtime/JSTypedArrayViewPrototype.cpp: Added.

(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):

  • runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
  • tests/es6.yaml:
  • tests/stress/resources/standalone-pre.js: Added.

(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):

  • tests/stress/resources/typedarray-test-helper-functions.js: Added.

(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(tester):
(testPrototypeReceivesArray):

  • tests/stress/typedarray-copyWithin.js: Added.
  • tests/stress/typedarray-every.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-fill.js: Added.
  • tests/stress/typedarray-filter.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-find.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-findIndex.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-forEach.js: Added.

(checkCorrect.let.list):
(checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):

  • tests/stress/typedarray-indexOf.js: Added.

(keepEven):

  • tests/stress/typedarray-lastIndexOf.js: Added.
  • tests/stress/typedarray-map.js: Added.

(even):
(evenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduce.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduceRight.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-slice.js: Added.
  • tests/stress/typedarray-some.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-sort.js: Added.

(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

  • fast/canvas/webgl/type-conversion-test-expected.txt:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
1:18 PM Changeset in webkit [190428] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Fix TestWebKitAPI build under CMake.

Reviewed by Alex Christensen.

  • TestWebKitAPI/PlatformWin.cmake: Add missing link command

for Psapi.lib.

1:05 PM Changeset in webkit [190427] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46.25-branch/Source/WebCore

Merged r188298. rdar://problem/22936040

12:54 PM Changeset in webkit [190426] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Clip string previews
https://bugs.webkit.org/show_bug.cgi?id=149708

Only show first 140 characters in strings previews.

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Utilities.js:

(String.prototype.truncate): Added.
A smart trancate function that doesn't split words.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForTypesAndValue):

12:50 PM Changeset in webkit [190425] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Another CMake build fix

  • PlatformWin.cmake: Add missing Psapi.lib to link list.
12:38 PM Changeset in webkit [190424] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Fix behavior of webkit-build-directory script
https://bugs.webkit.org/show_bug.cgi?id=149718

Reviewed by Alex Christensen.

  • Scripts/webkitdirs.pm:

(determineConfigurationProductDir): Do not include the binary
sub-directory in the configuration product directory output.
(jscProductDir): Append correct binary path for Windows build.
(setPathForRunningWebKitApp): Include properly binary subdirectories.
(runSafari): Update for revised productDir behavior.
(runMiniBrowser): Ditto.

12:31 PM Changeset in webkit [190423] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Latch does not clear when a scroll snap animation is triggered
https://bugs.webkit.org/show_bug.cgi?id=149681
<rdar://problem/22733922>

Reviewed by Simon Fraser.

Source/WebCore:

Test: tiled-drawing/scrolling/latched-div-with-scroll-snap.html

The scroll snap animation logic bypasses some of the normal clean-up code used
for wheel event handling. When this happens, the scroll latching state is not
cleared. In some cases this "stale" latch state is used when starting a new
gesture in the same frame. This causes the wrong page element to receive the
mouse wheel events, and hilarity ensues.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformNotifyIfEndGesture): Clear latched state when
ending the gesture.

LayoutTests:

Add a new test that confirms latched state is cleared when scroll snap animations
are triggered.

  • tiled-drawing/scrolling/latched-div-with-scroll-snap-expected.txt: Added.
  • tiled-drawing/scrolling/latched-div-with-scroll-snap.html: Added.
12:12 PM Changeset in webkit [190422] by Simon Fraser
  • 4 edits in trunk/LayoutTests

Remove some tests that now pass.

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
11:47 AM Changeset in webkit [190421] by Brent Fulgham
  • 9 edits in trunk/Source

[Win] Unreviewed CMake build fixes.

Source/WebCore:

  • CMakeLists.txt: Match original Windows build flags for WebCoreTest.
  • PlatformAppleWin.cmake: Use the same build defines as the

original Windows build.

Source/WebKit:

  • CMakeLists.txt: Set the same build definitions as the original

project file.

  • PlatformWin.cmake: Remove some soft-linked files from the static

link commands. Set build flags to match original project files.

Source/WTF:

  • wtf/CMakeLists.txt: Correct build flags to match

the original project files.

11:26 AM Changeset in webkit [190420] by Simon Fraser
  • 3 edits
    3 adds in trunk/LayoutTests

Add iOS touch event test
https://bugs.webkit.org/show_bug.cgi?id=149688

Reviewed by Ryosuke Niwa.

Basic touch event test that synthesizes touches in the UI process.

  • TestExpectations:
  • fast/events/touch/ios/touch-event-expected.txt: Added.
  • fast/events/touch/ios/touch-event.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
11:14 AM Changeset in webkit [190419] by ap@apple.com
  • 2 edits in trunk/Tools

Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
use iOS SDK, like with all the others.

  • Scripts/build-webkit:
11:09 AM Changeset in webkit [190418] by Antti Koivisto
  • 3 edits
    6 adds in trunk

Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174

Reviewed by Chris Dumez.

Source/WebKit2:

If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
runs through the same code paths as when receiving a redirect from network.

LayoutTests:

  • http/tests/cache/redirect-referer-expected.html: Added.
  • http/tests/cache/redirect-referer.html: Added.
  • http/tests/cache/resources/load-and-check-referer.php: Added.
  • http/tests/cache/resources/permanent-redirect.php: Added.
  • http/tests/cache/resources/redirect-referer-iframe.html: Added.
  • http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.
10:45 AM Changeset in webkit [190417] by mmaxfield@apple.com
  • 4 edits in trunk/LayoutTests

accessibility/mac/aria-expanded-notifications.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149510

Reviewed by Chris Fleizach.

The problem is triggered by our resumable parser. AXLoadComplete gets called
synchronously from DocumentLoader::finishedLoading(). This means that the order of
the AXLoadComplete message isn't FIFO.

If the parser yielded previously, the AXLoadComplete will be handled after some AX
messages had been handled.

If the parser hadn't yielded, the AXLoadComplete will be the first message
processed (no matter what had been queued up before it).

Because making the AXLoadComplete message asynchonous is not desirable, the
solution is to relax the test to handle various orderings.

  • accessibility/mac/aria-expanded-notifications-expected.txt:
  • accessibility/mac/aria-expanded-notifications.html:
  • platform/mac/TestExpectations:
10:42 AM Changeset in webkit [190416] by Brian Burg
  • 6 edits in trunk/Source

Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
https://bugs.webkit.org/show_bug.cgi?id=149590

Patch by João Oliveira <hello@jxs.pt> on 2015-09-30
Reviewed by Joseph Pecoraro.

Patch by João Oliveira and Brian Burg.

Source/WebCore:

Expose the frontend page's zoom factor so we can implement relative zoom.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::zoomFactor): Added.

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • page/Frame.h:

(WebCore::Frame::pageZoomFactor):

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.

10:38 AM Changeset in webkit [190415] by dbates@webkit.org
  • 3 edits in trunk/Tools

Attempt to fix the iOS 9 Simulator testers

Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
LayoutTestRelay when building for iOS Simulator.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/build-webkit:
10:20 AM Changeset in webkit [190414] by Yusuke Suzuki
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Introduce SymbolUse optimization into CompareEq and CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=149616

Reviewed by Saam Barati.

Since ES6 Symbols are used as an enum value[1] (And WebKit inspector do so for Esprima's type of nodes),
optimizing equality comparison for symbols makes much sense.

This patch leverages SymbolUse for CompareEq and CompareStrictEq.
Optimizations for both DFG and FTL are implemented.

[1]: http://www.2ality.com/2014/12/es6-symbols.html

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateSymbol):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::extractStringImplFromBinarySymbols):
(JSC::DFG::SpeculativeJIT::compileSymbolEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleSymbolEquality):

  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareStrictEq):

  • tests/stress/symbol-equality.js: Added.

(shouldBe):
(equal):
(strictEqual):
(list.forEach.result.set 1):

10:18 AM Changeset in webkit [190413] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710

Reviewed by Martin Robinson.

Source/WebCore:

We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.

  • platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):

Source/WebKit2:

Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

Tools:

Add test case to check that we can authenticate sites with an
empty realm.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:

(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):

10:16 AM Changeset in webkit [190412] by ap@apple.com
  • 2 edits in trunk/Tools

[Mac] Make run-api-tests work with System Integrity Protection
https://bugs.webkit.org/show_bug.cgi?id=149711
rdar://problem/22928202

Reviewed by Dan Bernstein.

  • Scripts/run-api-tests:

(runTest):
(archCommandLineArgumentsForRestrictedEnvironmentVariables):

10:10 AM Changeset in webkit [190411] by dbates@webkit.org
  • 2 edits in trunk/Tools

Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
For now, use the path to the top-level WebKit build directory instead of using the configuration-
specific build directory.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

9:43 AM Changeset in webkit [190410] by dbates@webkit.org
  • 3 edits
    7 moves
    7 adds
    1 delete in trunk/LayoutTests

Move <a ping> tests from LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute
https://bugs.webkit.org/show_bug.cgi?id=148828

Reviewed by Alexey Proskuryakov.

Towards adding <area ping> tests (bug #79438), we should move the existing <a ping> tests from
LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute and rename
them so as to make it clear from their name that they test the ping attribute on a HTML a element.

  • http/tests/navigation/ping-attribute/anchor-cookie-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cookie-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-cookie.html: Renamed from LayoutTests/http/tests/navigation/ping-cookie.html.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-expected.txt: Added.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-from-https-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https.html.
  • http/tests/navigation/ping-attribute/anchor-cross-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin.html.
  • http/tests/navigation/ping-attribute/anchor-same-origin-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-same-origin-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-same-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-same-origin.html.
  • http/tests/navigation/ping-attribute/resources/check-ping.php: Added.
  • http/tests/navigation/ping-attribute/resources/delete-ping.php: Added.
  • http/tests/navigation/ping-attribute/resources/ping-file-path.php: Added.
  • http/tests/navigation/ping-attribute/resources/save-Ping.php: Added.
  • http/tests/navigation/ping-cross-origin-expected.txt: Removed.
  • platform/ios-simulator-wk2/TestExpectations: Updated as needed for the above file renames.
  • platform/win/TestExpectations: Ditto.
8:39 AM Changeset in webkit [190409] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/Tools

[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
https://bugs.webkit.org/show_bug.cgi?id=145837

Reviewed by Philippe Normand.

  • efl/jhbuild.modules:
  • efl/patches/openwebrtc-clang-warning-fix.patch: Added.
  • efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
8:18 AM Changeset in webkit [190408] by wenson_hsieh@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix the iOS build after r190407.

  • WebKitTestRunner/ios/IOKitSPI.h:
7:28 AM Changeset in webkit [190407] by wenson_hsieh@apple.com
  • 11 edits
    2 adds in trunk

Implement keyboard event sending for iOS in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=149676

Reviewed by Simon Fraser.

Tools:

Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
allows us to run code when the keyboard is shown or hidden.

  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to

the notifications that the keyboard has been raised or lowered.

(-[TestRunnerWKWebView _keyboardDidShow:]):
(-[TestRunnerWKWebView _keyboardDidHide:]):

  • WebKitTestRunner/ios/HIDEventGenerator.h:
  • WebKitTestRunner/ios/HIDEventGenerator.m:

(-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
(shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
(hidUsageCodeForCharacter): Ditto.
(-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering

a keyDown event in WebKit.

  • WebKitTestRunner/ios/IOKitSPI.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

LayoutTests:

Adds a new basic test for the oninput event listener when typing in a text field.

  • fast/events/ios/input-value-after-oninput-expected.txt: Added.
  • fast/events/ios/input-value-after-oninput.html: Added.
6:38 AM Changeset in webkit [190406] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed, rolling out r190399.

Tests are still failing even after r190362

Reverted changeset:

"Unreviewed. Unskip GTK+ user media unit tests after r190362."
http://trac.webkit.org/changeset/190399

6:38 AM Changeset in webkit [190405] by Andres Gomez
  • 1 edit
    2 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
  • UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
6:36 AM Changeset in webkit [190404] by Andres Gomez
  • 3 edits
    19 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/AUTHORS: Updated.
  • UserInterface/Images/gtk/ClearBoth.svg: Added.
  • UserInterface/Images/gtk/ClearLeft.svg: Added.
  • UserInterface/Images/gtk/ClearRight.svg: Added.
  • UserInterface/Images/gtk/CubicBezier.svg: Updated.
  • UserInterface/Images/gtk/FloatLeft.svg: Added.
  • UserInterface/Images/gtk/FloatRight.svg: Added.
  • UserInterface/Images/gtk/FontStyleItalic.svg: Added.
  • UserInterface/Images/gtk/FontStyleNormal.svg: Added.
  • UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
  • UserInterface/Images/gtk/TextAlignCenter.svg: Added.
  • UserInterface/Images/gtk/TextAlignJustify.svg: Added.
  • UserInterface/Images/gtk/TextAlignLeft.svg: Added.
  • UserInterface/Images/gtk/TextAlignRight.svg: Added.
  • UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
  • UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
  • UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
  • UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
  • UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
  • UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
  • UserInterface/Images/gtk/VisualStyleNone.svg: Added.
6:07 AM Changeset in webkit [190403] by youenn.fablet@crf.canon.fr
  • 47 edits in trunk/Source/WebCore

Refactor binding generator to factor JS DOM class m_impl handling
https://bugs.webkit.org/show_bug.cgi?id=149660

Reviewed by Darin Adler.

Added JSDOMWrapperWithImplementation template class to move m_impl out of the binding generator.
Updated custom bindings to use impl() instead of m_impl directly.
Updated binding generator accordingly.

Covered by existing tests and binding tests.

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapperWithImplementation::impl):
(WebCore::JSDOMWrapperWithImplementation::~JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::releaseImpl):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):
(GetImplClassName):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::~JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1): Deleted.

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::~JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::~JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::~JSTestException):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::jsTestGenerateIsReachableConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachable::~JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::jsTestJSBuiltinConstructorConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:

(WebCore::JSTestJSBuiltinConstructor::~JSTestJSBuiltinConstructor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::jsTestMediaQueryListListenerConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::jsTestNondeterministicNondeterministicReadonlyAttr): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.h:

(WebCore::JSTestNondeterministic::~JSTestNondeterministic):
(WebCore::JSTestNondeterministic::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::~JSTestObj):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::jsTestOverloadedConstructorsConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:

(WebCore::JSTestOverrideBuiltins::~JSTestOverrideBuiltins):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue): Deleted.

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::~JSTestTypedefs):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::JSattribute):
(WebCore::jsattributeReadonly): Deleted.

  • bindings/scripts/test/JS/JSattribute.h:

(WebCore::JSattribute::~JSattribute):
(WebCore::JSattribute::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::JSreadonly):
(WebCore::jsreadonlyConstructor): Deleted.

  • bindings/scripts/test/JS/JSreadonly.h:

(WebCore::JSreadonly::~JSreadonly):
(WebCore::JSreadonly::finishCreation): Deleted.

5:59 AM WebKitGTK/2.10.x edited by Andres Gomez
Added Web Inspector icons bugs (diff)
5:35 AM Changeset in webkit [190402] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the ARM build after r190192
https://bugs.webkit.org/show_bug.cgi?id=149620

Reviewed by Darin Adler.

  • platform/graphics/FontFeatureSettings.h:

(WebCore::fontFeatureTag):

5:30 AM Changeset in webkit [190401] by youenn.fablet@crf.canon.fr
  • 20 edits
    1 copy in trunk

[Streams API] Add support for private WebCore JS builtins functions
https://bugs.webkit.org/show_bug.cgi?id=149518

Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding API to add private identifiers on the fly.
This is used to support private JS Builtin functions/private JS Builtin names in WebCore.

  • builtins/BuiltinNames.h:

(JSC::BuiltinNames::appendExternalName):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::appendExternalName):

  • runtime/CommonIdentifiers.h:

Source/WebCore:

Using ReadableStream tee method as a testbed to add support for private WebCore JS builtins functions.
Private functions are hooked to JSDOMWindowBase, as it is the one connected to WebCoreClientData.
WebCoreClientData is responsible to export the private function symbols to the VM.

Updated generate-js-builtins script to generate a class that can create and own all JS functions.
This class is used by JSDOMWindowBase to create the JS builtin functions.
It is also used to manage the GC of these objects.

Covered by rebased tests.

  • CMakeLists.txt: Adding ReadableStreamInternals builtin files.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • Modules/streams/ReadableStream.idl: Adding tee declaration as builtin
  • Modules/streams/ReadableStream.js:

(tee): Calling @teeReadableStream

  • Modules/streams/ReadableStreamInternals.js: Barebone @teeReadableStream implementation.

(teeReadableStream):

  • WebCore.vcxproj/WebCore.vcxproj: Adding ReadableStreamInternals builtin files.
  • WebCore.xcodeproj/project.pbxproj: Adding ReadableStreamInternals builtin files.
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase): Creating ReadableStreamInternalsBuiltinFunctions object.
(WebCore::JSDOMWindowBase::finishCreation): Creating builtin functions through ReadableStreamInternalsBuiltinFunctions and registering them to the JS engine.
(WebCore::JSDOMWindowBase::visitChildren): Ensuring GC does not collect private builtin functions through ReadableStreamInternalsBuiltinFunctions object

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData): Exporting private names of ReadableStreamInternalsBuiltins
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins):

  • generate-js-builtins: Adding support for ReadableStreamInternalsBuiltinFunctions and exportNames.

LayoutTests:

Rebasing tests now that tee is appearing in the IDL, although not yet conformant in its implementation.

  • streams/reference-implementation/readable-stream-expected.txt:
  • streams/reference-implementation/readable-stream-tee-expected.txt:
  • streams/reference-implementation/readable-stream-templated-expected.txt:
3:52 AM Changeset in webkit [190400] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[jhbuild] switch to new upstream usrsctp library
https://bugs.webkit.org/show_bug.cgi?id=149494

Reviewed by Philippe Normand.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
2:28 AM Changeset in webkit [190399] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Unskip GTK+ user media unit tests after r190362.

They should pass now.

  • Scripts/run-gtk-tests:

(TestRunner):

1:12 AM Changeset in webkit [190398] by youenn.fablet@crf.canon.fr
  • 9 edits in trunk/Source/WebCore

Binding generator should make mutable CachedAttribute member fields
https://bugs.webkit.org/show_bug.cgi?id=148056

Reviewed by Chris Dumez.

Making mutable CachedAttribute member fields.
Removing const_cast from custom binding code.
Rebased bindings tests.

No change in behavior.

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::state):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):

  • bindings/js/JSReadableStreamReaderEventCustom.cpp:

(WebCore::JSReadableStreamReader::closed):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::response):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
1:00 AM Changeset in webkit [190397] by bshafiei@apple.com
  • 1 copy in branches/safari-601.2.7-branch

New Branch.

12:44 AM Changeset in webkit [190396] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Update readable-stream tests against latest reference
https://bugs.webkit.org/show_bug.cgi?id=149668

Reviewed by Darin Adler.

  • streams/reference-implementation/readable-stream-expected.txt: Updated expectations.
  • streams/reference-implementation/readable-stream.html: Updated tests.
12:41 AM Changeset in webkit [190395] by calvaris@igalia.com
  • 10 edits in trunk/LayoutTests

[Stream API] Add pending checkpoints for up-to-date readable stream related tests and fix checkpoint URL
https://bugs.webkit.org/show_bug.cgi?id=149666

Reviewed by Darin Adler.

  • streams/readable-stream-reader-read.html:
  • streams/reference-implementation/abstract-ops.html:
  • streams/reference-implementation/bad-strategies.html:
  • streams/reference-implementation/bad-underlying-sources.html:
  • streams/reference-implementation/pipe-to-options.html:
  • streams/reference-implementation/pipe-to.html:
  • streams/reference-implementation/readable-stream-cancel.html:
  • streams/reference-implementation/writable-stream-abort.html:
  • streams/reference-implementation/writable-stream.html: Added and fixed checkpoint URLs.
12:38 AM Changeset in webkit [190394] by calvaris@igalia.com
  • 19 edits
    1 copy
    1 add
    1 delete in trunk

[Streams API] Create ByteLengthQueuingStrategy object as per spec
https://bugs.webkit.org/show_bug.cgi?id=147153

Reviewed by Darin Adler.

Source/WebCore:

Added ByteLengthQueuingStream class as the spec defines at https://streams.spec.whatwg.org/#blqs-class.

Tests are covered by current set.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreJSBuiltins.cpp: Added build instructions.
  • Modules/streams/ByteLengthQueuingStrategy.idl: Added.
  • Modules/streams/ByteLengthQueuingStrategy.js: Copied from Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp.

(size): Return byteLength attribute of the chunk.
(initializeByteLengthQueuingStrategy): Initialize the highWaterMark property.

  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData): Initialize the blqs builtins.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Return the attribute.

LayoutTests:

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt: Added ByteLengthQueuingStrategy to the

constructor expectations.

  • streams/reference-implementation/brand-checks.html:
  • streams/reference-implementation/byte-length-queuing-strategy.html: Removed reference to

byte-length-queuing-strategy.js as it should be now builtin in WebKit.

  • streams/reference-implementation/resources/byte-length-queuing-strategy.js: Removed.

(ByteLengthQueuingStrategy): Deleted.

12:31 AM Changeset in webkit [190393] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46.25-branch/Source

Versioning.

12:29 AM Changeset in webkit [190392] by bshafiei@apple.com
  • 1 copy in branches/safari-601.1.46.25-branch

New Branch.

12:22 AM Changeset in webkit [190391] by Gyuyoung Kim
  • 10 edits in trunk/Source/WebCore

Clean up all uses of PassRefPtr in Modules/geolocation
https://bugs.webkit.org/show_bug.cgi?id=149552

Reviewed by Darin Adler.

  • Modules/geolocation/GeoNotifier.cpp:

(WebCore::GeoNotifier::GeoNotifier):
(WebCore::GeoNotifier::setFatalError):

  • Modules/geolocation/GeoNotifier.h:

(WebCore::GeoNotifier::create):

  • Modules/geolocation/Geolocation.cpp:

(WebCore::createGeoposition):
(WebCore::createPositionError):
(WebCore::Geolocation::Watchers::add):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):

  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/GeolocationPosition.h:
  • Modules/geolocation/Geoposition.h:

(WebCore::Geoposition::create):
(WebCore::Geoposition::isolatedCopy):
(WebCore::Geoposition::Geoposition):

  • Modules/geolocation/PositionError.h:
  • Modules/geolocation/PositionOptions.h:
Note: See TracTimeline for information about the timeline view.