Context Navigation

← Previous Period
Next Period →

Timeline

Jun 13, 2016:

11:57 PM Changeset in webkit [202033] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

setUpStaticFunctionSlot does not handle Builtin|Accessor properties
https://bugs.webkit.org/show_bug.cgi?id=158637

Reviewed by Geoff Garen.

setUpStaticFunctionSlot contains a duplicate copy of the body of the function reifyStaticProperty

however it is missing handling for Accessor type under Builtin functions.

Fix the bug by de-duplicating - setUpStaticFunctionSlot should just call reifyStaticProperty.

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

should just call reifyStaticProperty.

runtime/Lookup.h:

(JSC::lookupPut):
(JSC::reifyStaticProperty):

changed reifyStaticProperty to take PropertyName.

11:36 PM Changeset in webkit [202032] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate)
https://bugs.webkit.org/show_bug.cgi?id=158431

Unreviewed build fix.

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

11:18 PM Changeset in webkit [202031] by barraclough@apple.com

3 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 4: JSHTMLDocument & JSStorage)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

JSHTMLDocument & JSStorage contain a number of static_asserts claiming that
various methods do not support static properties. These asserts were likely
correct at the time they were added, as JSObject::getOwnPropertySlot and
JSObject::deleteProperty did not support getting / deleting static value.
This is no longer the case, and these asserts are now incorrect.

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::deletePropertyByIndex):
(WebCore::JSStorage::putDelegate):

remove incorrect static_asserts.

11:17 PM Changeset in webkit [202030] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Geoff Garen.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

JSLocation::putDelegate checks the static property table redundantly.

In the case of same origin access, if the property is not in the static
table the method will call JSObject::put and return true (indicating the
delegate handled the put). If the property is in the static table, the
method will return false (indicating the the delegate did not handle the
access) - in which case the calling function will call JSObject::put.
Checking for the property in the static table is redundant - same origin
access does not require any special handling, and should just always
return false & let the caller handle the put.

In the case of cross origin access, if the property is not in the static
table we return true (indicating the access was handled, and silently
blocking it). If it is a static property, we check the name, and if the
name is not 'href' we also return true, silently blocking. In the case
that the name is 'href' we'll return false, indicating to the caller
that the access was not handled by the delegate, resulting in it taking
place. The additional check of the static table is redundant, since we
only have special behaviour in the case of 'href'. (Moreover it is
unnecesszarily fragile, since if we made a change such that 'href' was no
longer implemented as a static property with would fail.)

for same origin, always return false.
for cross origin, return false for 'href', otherwise return true.

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

restructure & remove static table check.

11:09 PM Changeset in webkit [202029] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 2: JSPluginElement)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

The check in pluginElementCustomGetOwnPropertySlot was somewhat dubious in the
first place (for types with static properties it would give precedence to both
static and also property storage properties; for types without static properties
it would check neither - an odd asymetry in the case of values in the storage
array, and was depending on an implementation detail that could change).

This is all now redundant anyway. None of these types have static properties.
All properties are now corretcly on the prototype (which is handled appropriately
below). This is just dead code.

bindings/js/JSPluginElementFunctions.h:

(WebCore::pluginElementCustomGetOwnPropertySlot):

remove dead code.

11:08 PM Changeset in webkit [202028] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 1: DOM bindings)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching): Deleted.
(WebCore::getStaticValueSlotEntryWithoutCaching<JSDOMObject>): Deleted.

this method is not used anywhere.

11:04 PM Changeset in webkit [202027] by barraclough@apple.com

10 edits
2 moves in trunk/Source/JavaScriptCore

JSBoundSlotBaseFunction no longer binds slot base
https://bugs.webkit.org/show_bug.cgi?id=157978

Reviewed by Geoff Garen.

This class is basically currently named after a bug. We should never have
been binding function to slot bases - this was not ever correct behavior.
This was fixed earlier in the year, but there is still some cruft including
the class name to clean up.

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction
removed m_boundSlotBase - don't retain the original slot base (we were not really using it anyway).
ASSERT customGetterSetter->getter/setter are non-null, rather than checking.
Store the PropertyName such that we can pass this to the getter (we're currently reperforming the String->Identifier conversion every time).
Removed JSFunction::lookUpOrCreateNativeExecutable - this is just overhead, and not used consistently.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSBoundSlotBaseFunction.cpp: Removed.
runtime/JSBoundSlotBaseFunction.h: Removed.
- JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction
runtime/JSCustomGetterSetterFunction.cpp: Copied from Source/JavaScriptCore/runtime/JSBoundSlotBaseFunction.cpp.

(JSC::JSCustomGetterSetterFunction::customGetterSetterFunctionCall):

made a static function on JSCustomGetterSetterFunction such that accessor to member properties could be made private. Call variant of callCustomSetter that does not require slotBase, ASSERT getter/setter present, pass stored PropertyName to getter.

(JSC::JSCustomGetterSetterFunction::JSCustomGetterSetterFunction):

renamed, store propertyName.

(JSC::JSCustomGetterSetterFunction::create):

use same function name to Executable as is being passed to Function::finishCreation.

(JSC::JSCustomGetterSetterFunction::visitChildren):
(JSC::JSCustomGetterSetterFunction::finishCreation):

removed m_boundSlotBase.

runtime/JSCustomGetterSetterFunction.h: Copied from Source/JavaScriptCore/runtime/JSBoundSlotBaseFunction.h.

(JSC::JSCustomGetterSetterFunction::customGetterSetter):
(JSC::JSCustomGetterSetterFunction::isSetter):

made private.

(JSC::JSCustomGetterSetterFunction::propertyName):

new accessor.

(JSC::JSBoundSlotBaseFunction::boundSlotBase): Deleted.

removed.

runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::lookUpOrCreateNativeExecutable): Deleted.

removed lookUpOrCreateNativeExecutable. This inconsistently used wrapper was providing no value, only bloat.

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::customGetterSetterFunctionStructure):
(JSC::JSGlobalObject::boundSlotBaseFunctionStructure): Deleted.

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::create):

removed lookUpOrCreateNativeExecutable.

runtime/JSObject.cpp:

(JSC::getCustomGetterSetterFunctionForGetterSetter):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::getBoundSlotBaseFunctionForGetterSetter): Deleted.

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

runtime/VM.h:
- renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

11:04 PM Changeset in webkit [202026] by adam.bergkvist@ericsson.com

15 edits in trunk

WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack()
https://bugs.webkit.org/show_bug.cgi?id=158688

Reviewed by Eric Carlson.

Source/WebCore:

Implement MediaEndpointPeerConnection::replaceTrack() that is the MediaEndpoint implementation
of RTCRtpSender.replaceTrack() [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcrtpsender-replacetrack

Updated fast/mediastream/RTCRtpSender-replaceTrack.html

Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::replaceTrack):
(WebCore::MediaEndpointPeerConnection::replaceTrackTask):
Implemented.

Modules/mediastream/MediaEndpointPeerConnection.h:
Modules/mediastream/PeerConnectionBackend.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::replaceTrack):

Modules/mediastream/RTCPeerConnection.h:

Move the MediaStreamTrack instance of sending a reference to it. This change is the main
reason many files are touched by this change.

Modules/mediastream/RTCRtpSender.h:
Modules/mediastream/RTCRtpSender.idl:
platform/mediastream/MediaEndpoint.h:

Use mid instead of mdescIndex to identify the media description in the backend.

platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::replaceSendSource):

platform/mock/MockMediaEndpoint.h:

LayoutTests:

Update existing test for RTCRtpSender.replaceTrack.

fast/mediastream/RTCRtpSender-replaceTrack-expected.txt:
fast/mediastream/RTCRtpSender-replaceTrack.html:

Add test cases where a "not yet negotiated track" is directly replaced. Also check that the
old track id is used in later offers.

fast/mediastream/resources/promise-utils.js:

(promiseShouldResolve):
Added utility method to test promise expressions that are expected to resolve.

9:33 PM Changeset in webkit [202025] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Show Exception Stack in UncaughtExceptionReporter view
https://bugs.webkit.org/show_bug.cgi?id=158657
<rdar://problem/26754441>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-13
Reviewed by Darin Adler.

UserInterface/Debug/UncaughtExceptionReporter.css:

(.uncaught-exception-sheet li):
Make newlines significant.

UserInterface/Debug/UncaughtExceptionReporter.js:

(unblockEventHandlers):
(handleError):
(handleLinkClick):
(formattedEntry):
Format the exception and a possible stack with a bit of sanitizing.

9:10 PM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

9:03 PM Changeset in webkit [202024] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Mac] Web Content service with a restricted entitlement may load arbitrary dylibs
https://bugs.webkit.org/show_bug.cgi?id=156668
<rdar://problem/26714558>

Reviewed by Anders Carlsson.

Configurations/WebContentService.xcconfig: Enable library validation when the Web Content service is given the XPC domain extension entitlement when targeting macOS Sierra or later.

8:28 PM Changeset in webkit [202023] by commit-queue@webkit.org

81 edits
3 copies
11 adds in trunk

window.onerror should pass the ErrorEvent's 'error' property as the 5th argument to the event handler
https://bugs.webkit.org/show_bug.cgi?id=55092
<rdar://problem/25731279>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-13
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

This includes the actual Error in window.error / ErrorEvent:
https://html.spec.whatwg.org/multipage/webappapis.html#the-errorevent-interface

This is useful for scripts to be able to get an error stack
from uncaught exceptions, by checking the error itself.

Tests: fast/events/window-onerror17.html

http/tests/security/cross-origin-script-error-event-redirected.html
http/tests/security/cross-origin-script-error-event.html
http/tests/security/script-crossorigin-error-event-information.html
http/tests/security/script-no-crossorigin-error-event-should-be-sanitized.html
userscripts/window-onerror-for-isolated-world-3.html

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:

Add new custom error event file.

bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Include the JSC::Exception when reporting exceptions, so the error value is available.

bindings/js/JSErrorEventCustom.cpp:

(WebCore::JSErrorEvent::error):
Sanitized access to the ErrorEvent's error property to prevent leaking objects
across isolated world boundaries. This is like CustomEvent's data property.

bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

bindings/js/JSErrorHandler.h:

Include the error object as the 4th argument to the window.onerror event handler.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::sanitizeScriptError):
(WebCore::ScriptExecutionContext::reportException):
(WebCore::ScriptExecutionContext::dispatchErrorEvent):

dom/ScriptExecutionContext.h:

Include the error object in the ErrorEvent constructed when dispatching error events.

dom/ErrorEvent.cpp:

(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::sanitizedErrorValue):
(WebCore::ErrorEvent::trySerializeError):

dom/ErrorEvent.h:
dom/ErrorEvent.idl:

Include an any "error" property on the ErrorEvent, and allow it in initialization.

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
Within the Worker world, the error is included in the event.
When re-dispatching the error on the world object in the world that spawned the
Worker the event does not include an error object. This matches other browsers
right now, but could be improved to have the same cross world serialization
as isolated worlds have with the error data.

dom/CustomEvent.h:

Remove unimplemented stale method.

LayoutTests:

platform/wk2/TestExpectations:

Skip new userscript test on WebKit2 like others.

fast/events/constructors/error-event-constructor-expected.txt:
fast/events/constructors/error-event-constructor.html:

Test for the new any "error" initialization property.

fast/events/event-leak-objects-expected.txt:
fast/events/event-leak-objects.html:
fast/events/event-properties-gc-expected.txt:
fast/events/event-properties-gc.html:

Like CustomEvent.details, ErrorEvent.error should not leak
objects across isolated worlds.

fast/events/window-onerror-exception-in-attr-expected.txt:
fast/events/window-onerror-exception-in-attr.html:
fast/events/window-onerror-syntax-error-in-attr-expected.txt:
fast/events/window-onerror-syntax-error-in-attr.html:
fast/events/window-onerror1-expected.txt:
fast/events/window-onerror1.html:
fast/events/window-onerror10-expected.txt:
fast/events/window-onerror10.html:
fast/events/window-onerror11-expected.txt:
fast/events/window-onerror11.html:
fast/events/window-onerror12-expected.txt:
fast/events/window-onerror12.html:
fast/events/window-onerror13.html:
fast/events/window-onerror14.html:
fast/events/window-onerror16.html:
fast/events/window-onerror17-expected.txt: Added.
fast/events/window-onerror17.html: Copied from LayoutTests/fast/events/window-onerror12.html.
fast/events/window-onerror2-expected.txt:
fast/events/window-onerror2.html:
fast/events/window-onerror3-expected.txt:
fast/events/window-onerror3.html:
fast/events/window-onerror4-expected.txt:
fast/events/window-onerror4.html:
fast/events/window-onerror5-expected.txt:
fast/events/window-onerror5.html:
fast/events/window-onerror6-expected.txt:
fast/events/window-onerror6.html:
fast/events/window-onerror7-expected.txt:
fast/events/window-onerror7.html:
fast/events/window-onerror8-expected.txt:
fast/events/window-onerror8.html:
fast/events/window-onerror9-expected.txt:
fast/events/window-onerror9.html:

Include output for the column number and error object where possible.

fast/files/resources/setup-for-read-common.js:
fast/files/workers/worker-apply-blob-url-to-xhr.html:
fast/workers/resources/worker-error-in-handling-script-error.js:
fast/workers/resources/worker-script-error-bubbled.js:
fast/workers/resources/worker-script-error-handled.js:
fast/workers/resources/worker-script-error.js:
fast/workers/worker-script-error-expected.txt:

Test "onerror" within Workers, and the "error" event on
the Worker from the spawning context.

http/tests/security/cross-origin-script-error-event-expected.txt: Added.
http/tests/security/cross-origin-script-error-event-redirected-expected.txt: Added.
http/tests/security/cross-origin-script-error-event-redirected.html: Added.
http/tests/security/cross-origin-script-error-event.html: Added.
http/tests/security/cross-origin-script-window-onerror-expected.txt:
http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt:
http/tests/security/cross-origin-script-window-onerror-redirected.html:
http/tests/security/cross-origin-script-window-onerror.html:
http/tests/security/script-crossorigin-error-event-information-expected.txt: Added.
http/tests/security/script-crossorigin-error-event-information.html: Added.
http/tests/security/script-crossorigin-onerror-information-expected.txt:
http/tests/security/script-crossorigin-onerror-information.html:
http/tests/security/script-no-crossorigin-error-event-should-be-sanitized-expected.txt: Added.
http/tests/security/script-no-crossorigin-error-event-should-be-sanitized.html: Copied from LayoutTests/http/tests/security/script-no-crossorigin-onerror-should-be-sanitized.html.
http/tests/security/script-no-crossorigin-onerror-should-be-sanitized-expected.txt:
http/tests/security/script-no-crossorigin-onerror-should-be-sanitized.html:
http/tests/security/window-onerror-exception-in-iframe-expected.txt:
http/tests/security/window-onerror-exception-in-iframe.html:
http/tests/workers/worker-importScriptsOnError-expected.txt:
js/dom/exception-line-number-expected.txt:
js/dom/script-tests/exception-line-number.js:

(window.onerror):

userscripts/window-onerror-for-isolated-world-1-expected.txt:
userscripts/window-onerror-for-isolated-world-1.html:
userscripts/window-onerror-for-isolated-world-2-expected.txt:
userscripts/window-onerror-for-isolated-world-2.html:
userscripts/window-onerror-for-isolated-world-3-expected.txt: Added.
userscripts/window-onerror-for-isolated-world-3.html: Added.

Add an explicit test for error objects crossing isolated world boundaries.
In the Isolated World case, serializable values are cloned, but unserializable
values cause the error object to return to null to avoid leaking across worlds.

8:05 PM Changeset in webkit [202022] by dino@apple.com

3 edits
2 adds in trunk

SVG elements don't blend correctly into HTML
https://bugs.webkit.org/show_bug.cgi?id=158718
<rdar://problem/26782004>

Reviewed by Antoine Quint.

Source/WebCore:

We were not creating any transparency layers for the root SVG nodes.
This is ok if the SVG is the root document, because it is the backdrop.
However, if it is inline SVG, it needs to apply the operation in
order to composite into the document.

Test: svg/css/mix-blend-mode-with-inline-svg.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::beginTransparencyLayers):

LayoutTests:

svg/css/mix-blend-mode-with-inline-svg-expected.html: Added.
svg/css/mix-blend-mode-with-inline-svg.html: Added.

7:29 PM Changeset in webkit [202021] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

The sampling profiler should further protect itself against certain forms of sampling bias that arise due to the sampling interval being in sync with some other system process
https://bugs.webkit.org/show_bug.cgi?id=158678

Reviewed by Benjamin Poulain.

I first became aware of this problem when I read this paper:
http://plv.colorado.edu/papers/mytkowicz-pldi10.pdf

To provide background for this change, I'll quote a paragraph
from section 6.2:
"One statically sound method for collecting random samples is to collect a
sample at every t + r milliseconds, where t is the desired sampling interval
and r is a random number between −t and t. One might think that sampling every
t seconds is enough (i.e., drop the r component) but it is not: specifically,
if a profiler samples every t seconds, the sampling rate would be synchronized
with any program or system activity that occurs at regular time intervals [17].
For example, if the thread scheduler switches between threads every 10ms and our
sampling interval was also 10ms, then we may always take samples immediately after
a thread switch. Because performance is often different immediately after a thread
switch than at other points (e.g., due to cache and TLB warm-up effects) we would
get biased data. The random component, r, guards against such situations."

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::timerLoop):

7:27 PM Changeset in webkit [202020] by ddkilzer@apple.com

3 edits in trunk/Tools

False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
<https://webkit.org/b/158716>

Reviewed by Andy Estes.

DumpRenderTree/mac/DumpRenderTree.mm:

(destroyWebViewAndOffscreenWindow): Change this function to take
a WebView, and assert that it's the same as [mainFrame webView].
(dumpRenderTree): Pass 'webView' into
destroyWebViewAndOffscreenWindow().

DumpRenderTree/mac/DumpRenderTreeMac.h:

(createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
this function returns a +1 WebView. Declare this method only for
Objective-C[++] source.

5:34 PM Changeset in webkit [202019] by beidson@apple.com

6 edits in trunk

storage/indexeddb/modern/leaks-1.html leaks the database connection handle.
https://bugs.webkit.org/show_bug.cgi?id=158643

Reviewed by Alex Christensen.

Source/WebCore:

Tested by changes to existing test.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::hasPendingActivity):

dom/EventTarget.h:

(WebCore::EventTarget::eventTargetData):
(WebCore::EventTarget::hasEventListeners):

LayoutTests:

storage/indexeddb/modern/leak-1-expected.txt:
storage/indexeddb/modern/resources/leak-1.js:

5:17 PM Changeset in webkit [202018] by enrica@apple.com

3 edits in trunk/Source/WebCore

REGRESSION(r201956): Failure to initialize new internal settings produced random test failures in release.
https://bugs.webkit.org/show_bug.cgi?id=158713
rdar://26769957

Reviewed by Simon Fraser.

Failed to initialize the new member variable in both Settings and InternalSettings classes.

page/Settings.cpp:

(WebCore::Settings::Settings):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):

5:11 PM Changeset in webkit [202017] by Chris Dumez

4 edits in trunk/Source/WebCore

Drop HipChat hack introduced in r197548
https://bugs.webkit.org/show_bug.cgi?id=158711

Reviewed by Geoffrey Garen.

Drop HipChat hack introduced in r197548. This hack is no longer needed
as the bug was fixed in HipChat since then:
https://support.atlassian.com/servicedesk/customer/portal/32/HCP-7532

I have confirmed locally that the latest version (4.0.12.665) is able
to connect without the hack.

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate): Deleted.

platform/RuntimeApplicationChecks.h:
platform/RuntimeApplicationChecks.mm:

(WebCore::MacApplication::isHipChat): Deleted.

4:52 PM Changeset in webkit [202016] by Jon Davis

2 edits in trunk/Websites/webkit.org

Minor style updates for figcaptions and post forewords.

wp-content/themes/webkit/style.css:

(article .foreword):
(figure.aligncenter figcaption):
(figure.aligncenter figcaption::before):

4:17 PM Changeset in webkit [202015] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG Validation fails when performing a concatenation with only a single entry
https://bugs.webkit.org/show_bug.cgi?id=158699

Reviewed by Saam Barati.

Fairly simple short circuiting of a single replacement template string
without any padding to be planted as a simple to string rather than
op_strcat.

bytecompiler/NodesCodegen.cpp:

(JSC::TemplateLiteralNode::emitBytecode):

tests/stress/template-literal.js:

(testSingleNode):

4:05 PM Changeset in webkit [202014] by Chris Fleizach

2 edits in trunk/Source/WebCore

AX: CrashTracer: com.apple.WebKit.WebContent at WebCore::AccessibilityRenderObject::remoteSVGRootElement const + 227
https://bugs.webkit.org/show_bug.cgi?id=158685

Reviewed by David Kilzer.

Crash reports show a null access at a line that tries to dereference a pointer.
I still don't have a way to layout test this, as it seems tied to tear down of the main document.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

3:57 PM Changeset in webkit [202013] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Use two video layer solution only on mac.
https://bugs.webkit.org/show_bug.cgi?id=158705
rdar://problem/26776360

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-06-13
Reviewed by Jer Noble.

Two video layer solution is only useful on the mac to prevent flicker, so don't do it elsewhere.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):

3:53 PM Changeset in webkit [202012] by Jon Davis

3 edits in trunk/Websites/webkit.org

Adds support for foreword custom meta and display styles on blog posts.
https://bugs.webkit.org/show_bug.cgi?id=158707.

Reviewed by Timothy Hatcher.

wp-content/themes/webkit/functions.php:
wp-content/themes/webkit/style.css:

(article .foreword):

3:44 PM Changeset in webkit [202011] by Matt Baker

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Filter Records not applying to new records
https://bugs.webkit.org/show_bug.cgi?id=158213
<rdar://problem/26543912>

Reviewed by Timothy Hatcher.

This patch makes the following improvements to timeline grid filtering:

Records are filtered as they are added to the grid.
Timeline view no longer triggers a filter refresh while the current time changes while recording.
Filters are refreshed whenever the current timeline view changes.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.hasFilters):
Helper function to check for custom and text filters.

(WebInspector.DataGrid.prototype._applyFiltersToNodeAndDispatchEvent):
Encapsulate node state change and event dispatch, which was previously
done in multiple places.

(WebInspector.DataGrid.prototype.insertChild):
Filter incoming node if needed.

(WebInspector.DataGrid.prototype._updateFilter.createIteratorForNodesToBeFiltered):
(WebInspector.DataGrid.prototype._updateFilter):
(WebInspector.DataGrid.prototype.yieldableTaskWillProcessItem):
Use new convenience functions.

(WebInspector.DataGrid.prototype.hasCustomFilters): Deleted.
Renamed hasFilters.

UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Refresh grid filters on view change.

UserInterface/Views/TimelineView.js:

(WebInspector.TimelineView.prototype.set startTime):
(WebInspector.TimelineView.prototype.set endTime):
Schedule filter change notification when selection bounds changes.

(WebInspector.TimelineView.prototype._timesDidChange):
(WebInspector.TimelineView.prototype._scheduleFilterDidChange):
(WebInspector.TimelineView):

3:43 PM Changeset in webkit [202010] by sbarati@apple.com

7 edits
2 adds in trunk/Source/WebInspectorUI

Web Inspector: Call Trees view should have a 'Top Functions'-like mode
https://bugs.webkit.org/show_bug.cgi?id=158555
<rdar://problem/26712544>

Reviewed by Timothy Hatcher.

This patch adds a Top Functions view that is similar to Instruments'
Top Functions view. I really wanted to add this view because I've
been doing a lot of performance debugging and I've exclusively
used the Top Functions view and I want the Inspector to also have
this view. I like to think of it as a more sophisticated version of the bottom-up view.

Top Functions works by treating every frame as a root in the tree.
Top functions view then presents a list of "roots". This is the same
as all other views, which also present a list of roots, but in this case,
every frame is a root. Bottom Up is great for nailing in specific performance
problems in exactly one frame. But Bottom Up doesn't give you good context about where
a specific frame is in the call tree and how frames are related by having
a caller or some path of shared callers. For example, consider this call tree:

(program)
/ \

/ \

(many nodes...)

/

/

(parent)
/ \

/ \

(leaf1) (leaf2)

Suppose that 'leaf1' is super hot, and 'leaf2' is moderately hot.
If we look at this through Bottom Up view, we will see 'leaf1'
is super hot, but it will take more scrolling to see that 'leaf2'
is moderately hot. Lets say that 'parent' is also moderately hot,
but that the majority of its time isn't self time. With Bottom Up view,
there is no good way to see that 'leaf1' and 'leaf2' are both nodes under 'parent'.
With Top Down, you can find this information, but it requires a ton of drilling down into
the tree (i.e, you must expand past the 'many nodes...' I drew above). It's inconvenient to
use Top Down here for indentation alone. Bottom up will tell you that 'leaf1' is super hot,
and that 'leaf2' and 'parent' are moderately hot, but it doesn't show how they're related
in the original tree. It's important to see that 'parent's total time is very high
because it itself is moderately hot, and it has a child node that is super hot, and
another child that's moderately 'hot'. For the sake of this example, let's pretend
that 85% of the program's time is spent inside 'parent'. Seeing this information through
'Top Functions' is easy because this information filters to the top of the list. Specifically,
when using 'Top Functions' sorted by Total Time. Because every node is a root, there will be
a top-level entry for every frame in the program. Specifically, there will be a top-level node
for 'parent' in my above example. Because I've sorted this view by Total Time, I will see '(program)'
first. That's because 100% of execution time is under the '(program)' frame. Then, I might see
a few other nodes that also run the entire time because '(program)' calls them, and they eventually
call into other things that never leave the stack. These will also have time ranges near 100%.
But, only a few nodes after that, I'll see 'parent' in the list because it accounts for 85% of
execution time. Immediately, I will see that it has some self time, and that it has two child
nodes that have self time. This is really helpful.

Let's consider another example where it's not easy in Top Down to get the full picture of 'parent':

(program)

/ | \

(... many nodes...)

/ \

(many nodes...) (many nodes...)

/ \

parent parent

| |

leaf1 leaf2

If we viewed this program in Top Down, we don't get a full picture of 'parent'
because it has its time distributed in two different subsections of the tree.
Specifically, lets say it has 70% of time in the leaf1 path, and 30% of the
time in the leaf2 path. We want a way to see these things together. It's impossible
to do this in Top Down or Bottom Up. But, in Top Functions view, we get the view that
we want to see because we treat 'parent' as a root of the tree. Because we do this,
we will create the following sub tree in the Top Functions view:

parent

/ \

leaf1 leaf2

This happens naturally because when 'parent' is a root, we add all its children
to its subtree.

Constructing this tree is really easy. What we do is take any arbitrary stack
trace of length n, and treat is as n separate stack traces. Specifically, we
perform the following operation for any stack trace S.

S = [A, B, C, D]
(A is the entry frame, and D is the top of the stack).
We will transform this into a list of stack traces S' like so:
S' = A, B, C, D], [B, C, D], [C, D], [D?

If we then run the normal top down tree algorithm on this set of stack
traces, all nodes get treated as roots, and voila, we get the Top Functions view.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/TimelineManager.js:
UserInterface/Main.html:
UserInterface/Models/CallingContextTree.js:
UserInterface/Models/TimelineRecording.js:
UserInterface/Views/ScriptProfileTimelineView.js:
UserInterface/Views/TextToggleButtonNavigationItem.css: Added.
UserInterface/Views/TextToggleButtonNavigationItem.js: Added.

3:41 PM Changeset in webkit [202009] by Matt Baker

7 edits in trunk/Source/WebInspectorUI

Web Inspector: Add ability to show/hide DataGird columns
https://bugs.webkit.org/show_bug.cgi?id=158676
<rdar://problem/26761573>

Reviewed by Timothy Hatcher.

Make it possible to show/hide grid columns using the grid header
context menu. This patch enables the new behavior for most of the
timeline grids.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.get identifier):
(WebInspector.DataGrid.prototype.set identifier):
An identifier for the grid instance, for managing per-grid settings.
Setting the id causes settings to be created, and their values to be
applied to the grid.

(WebInspector.DataGrid.prototype.get columnChooserEnabled):
(WebInspector.DataGrid.prototype.set columnChooserEnabled):
Enable showing/hiding columns via the grid header.

(WebInspector.DataGrid.prototype.insertColumn):
(WebInspector.DataGrid.prototype.showColumn):
Set column visibility and hidden column setting, then perform layout.

(WebInspector.DataGrid.prototype._collapseColumnGroupWithCell):
(WebInspector.DataGrid.prototype._contextMenuInHeader):
Create column chooser menu items if necessary.

(WebInspector.DataGrid.prototype._showColumn): Deleted.
(WebInspector.DataGrid.prototype._hideColumn): Deleted.
Replaced by showColumn.

UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView):
Always show "type" and "name" columns.

UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView):

UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView):

UserInterface/Views/ScriptDetailsTimelineView.js:

(WebInspector.ScriptDetailsTimelineView):
Always show "name" column.

UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid):
Enable column chooser.

3:25 PM Changeset in webkit [202008] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix. Strip out "use strict" everywhere so that the perf dashboard works on the shipping Safari.

tools/bundle-v3-scripts.py:

(main):

3:17 PM Changeset in webkit [202007] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

FTL::Output methods should be out-of-line whenever possible
https://bugs.webkit.org/show_bug.cgi?id=158704

Reviewed by Benjamin Poulain.

These methods turn into a non-trivial amount of code because of the template-based B3 API.
Inlining them didn't achieve any performance advantages for the FTL, but it did make the
code larger. This outlines most methods in FTL::Output. It makes FTL::LowerDFGToB3 smaller
and it doesn't change performance.

ftl/FTLOutput.cpp:

(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::framePointer):
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::constDouble):
(JSC::FTL::Output::phi):
(JSC::FTL::Output::add):
(JSC::FTL::Output::sub):
(JSC::FTL::Output::mul):
(JSC::FTL::Output::div):
(JSC::FTL::Output::chillDiv):
(JSC::FTL::Output::mod):
(JSC::FTL::Output::chillMod):
(JSC::FTL::Output::neg):
(JSC::FTL::Output::doubleAdd):
(JSC::FTL::Output::doubleSub):
(JSC::FTL::Output::doubleMul):
(JSC::FTL::Output::doubleDiv):
(JSC::FTL::Output::doubleMod):
(JSC::FTL::Output::bitAnd):
(JSC::FTL::Output::bitOr):
(JSC::FTL::Output::bitXor):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::lShr):
(JSC::FTL::Output::bitNot):
(JSC::FTL::Output::logicalNot):
(JSC::FTL::Output::ctlz32):
(JSC::FTL::Output::doubleAbs):
(JSC::FTL::Output::doubleCeil):
(JSC::FTL::Output::doubleFloor):
(JSC::FTL::Output::doubleTrunc):
(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):
(JSC::FTL::Output::doublePow):
(JSC::FTL::Output::doublePowi):
(JSC::FTL::Output::doubleSqrt):
(JSC::FTL::Output::doubleLog):
(JSC::FTL::Output::hasSensibleDoubleToInt):
(JSC::FTL::Output::doubleToUInt):
(JSC::FTL::Output::signExt32To64):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::intToDouble):
(JSC::FTL::Output::unsignedToDouble):
(JSC::FTL::Output::castToInt32):
(JSC::FTL::Output::doubleToFloat):
(JSC::FTL::Output::floatToDouble):
(JSC::FTL::Output::load):
(JSC::FTL::Output::load8SignExt32):
(JSC::FTL::Output::baseIndex):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::doubleEqual):
(JSC::FTL::Output::doubleEqualOrUnordered):
(JSC::FTL::Output::doubleNotEqualOrUnordered):
(JSC::FTL::Output::doubleLessThan):
(JSC::FTL::Output::doubleLessThanOrEqual):
(JSC::FTL::Output::doubleGreaterThan):
(JSC::FTL::Output::doubleGreaterThanOrEqual):
(JSC::FTL::Output::doubleNotEqualAndOrdered):
(JSC::FTL::Output::doubleLessThanOrUnordered):
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered):
(JSC::FTL::Output::isZero32):
(JSC::FTL::Output::notZero32):
(JSC::FTL::Output::isZero64):
(JSC::FTL::Output::notZero64):
(JSC::FTL::Output::select):
(JSC::FTL::Output::jump):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::check):
(JSC::FTL::Output::ret):
(JSC::FTL::Output::unreachable):
(JSC::FTL::Output::speculate):
(JSC::FTL::Output::speculateAdd):
(JSC::FTL::Output::speculateSub):
(JSC::FTL::Output::speculateMul):
(JSC::FTL::Output::patchpoint):
(JSC::FTL::Output::trap):
(JSC::FTL::Output::anchor):
(JSC::FTL::Output::bitCast):
(JSC::FTL::Output::fround):

ftl/FTLOutput.h:

(JSC::FTL::Output::setOrigin):
(JSC::FTL::Output::origin):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::doubleNeg):
(JSC::FTL::Output::zeroExtPtr):
(JSC::FTL::Output::load32NonNegative):
(JSC::FTL::Output::isNull):
(JSC::FTL::Output::notNull):
(JSC::FTL::Output::testIsZeroPtr):
(JSC::FTL::Output::testNonZeroPtr):
(JSC::FTL::Output::call):
(JSC::FTL::Output::operation):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::switchInstruction):
(JSC::FTL::Output::addIncomingToPhi):
(JSC::FTL::Output::framePointer): Deleted.
(JSC::FTL::Output::constBool): Deleted.
(JSC::FTL::Output::constInt32): Deleted.
(JSC::FTL::Output::constInt64): Deleted.
(JSC::FTL::Output::constDouble): Deleted.
(JSC::FTL::Output::phi): Deleted.
(JSC::FTL::Output::add): Deleted.
(JSC::FTL::Output::sub): Deleted.
(JSC::FTL::Output::mul): Deleted.
(JSC::FTL::Output::div): Deleted.
(JSC::FTL::Output::chillDiv): Deleted.
(JSC::FTL::Output::mod): Deleted.
(JSC::FTL::Output::chillMod): Deleted.
(JSC::FTL::Output::doubleAdd): Deleted.
(JSC::FTL::Output::doubleSub): Deleted.
(JSC::FTL::Output::doubleMul): Deleted.
(JSC::FTL::Output::doubleDiv): Deleted.
(JSC::FTL::Output::doubleMod): Deleted.
(JSC::FTL::Output::bitAnd): Deleted.
(JSC::FTL::Output::bitOr): Deleted.
(JSC::FTL::Output::bitXor): Deleted.
(JSC::FTL::Output::shl): Deleted.
(JSC::FTL::Output::aShr): Deleted.
(JSC::FTL::Output::lShr): Deleted.
(JSC::FTL::Output::ctlz32): Deleted.
(JSC::FTL::Output::addWithOverflow32): Deleted.
(JSC::FTL::Output::subWithOverflow32): Deleted.
(JSC::FTL::Output::mulWithOverflow32): Deleted.
(JSC::FTL::Output::addWithOverflow64): Deleted.
(JSC::FTL::Output::subWithOverflow64): Deleted.
(JSC::FTL::Output::mulWithOverflow64): Deleted.
(JSC::FTL::Output::doubleAbs): Deleted.
(JSC::FTL::Output::doubleCeil): Deleted.
(JSC::FTL::Output::doubleFloor): Deleted.
(JSC::FTL::Output::doubleSin): Deleted.
(JSC::FTL::Output::doubleCos): Deleted.
(JSC::FTL::Output::doublePow): Deleted.
(JSC::FTL::Output::doubleSqrt): Deleted.
(JSC::FTL::Output::doubleLog): Deleted.
(JSC::FTL::Output::signExt32To64): Deleted.
(JSC::FTL::Output::zeroExt): Deleted.
(JSC::FTL::Output::intToDouble): Deleted.
(JSC::FTL::Output::castToInt32): Deleted.
(JSC::FTL::Output::doubleToFloat): Deleted.
(JSC::FTL::Output::floatToDouble): Deleted.
(JSC::FTL::Output::equal): Deleted.
(JSC::FTL::Output::notEqual): Deleted.
(JSC::FTL::Output::above): Deleted.
(JSC::FTL::Output::aboveOrEqual): Deleted.
(JSC::FTL::Output::below): Deleted.
(JSC::FTL::Output::belowOrEqual): Deleted.
(JSC::FTL::Output::greaterThan): Deleted.
(JSC::FTL::Output::greaterThanOrEqual): Deleted.
(JSC::FTL::Output::lessThan): Deleted.
(JSC::FTL::Output::lessThanOrEqual): Deleted.
(JSC::FTL::Output::doubleEqual): Deleted.
(JSC::FTL::Output::doubleEqualOrUnordered): Deleted.
(JSC::FTL::Output::doubleNotEqualOrUnordered): Deleted.
(JSC::FTL::Output::doubleLessThan): Deleted.
(JSC::FTL::Output::doubleLessThanOrEqual): Deleted.
(JSC::FTL::Output::doubleGreaterThan): Deleted.
(JSC::FTL::Output::doubleGreaterThanOrEqual): Deleted.
(JSC::FTL::Output::doubleNotEqualAndOrdered): Deleted.
(JSC::FTL::Output::doubleLessThanOrUnordered): Deleted.
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered): Deleted.
(JSC::FTL::Output::doubleGreaterThanOrUnordered): Deleted.
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered): Deleted.
(JSC::FTL::Output::isZero32): Deleted.
(JSC::FTL::Output::notZero32): Deleted.
(JSC::FTL::Output::isZero64): Deleted.
(JSC::FTL::Output::notZero64): Deleted.
(JSC::FTL::Output::select): Deleted.
(JSC::FTL::Output::extractValue): Deleted.
(JSC::FTL::Output::jump): Deleted.
(JSC::FTL::Output::ret): Deleted.
(JSC::FTL::Output::unreachable): Deleted.
(JSC::FTL::Output::speculate): Deleted.
(JSC::FTL::Output::speculateAdd): Deleted.
(JSC::FTL::Output::speculateSub): Deleted.
(JSC::FTL::Output::speculateMul): Deleted.
(JSC::FTL::Output::patchpoint): Deleted.
(JSC::FTL::Output::trap): Deleted.
(JSC::FTL::Output::anchor): Deleted.
(JSC::FTL::Output::bitCast): Deleted.
(JSC::FTL::Output::fround): Deleted.

3:00 PM Changeset in webkit [202006] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Decrease PiP flicker by not removing window prematurely.
https://bugs.webkit.org/show_bug.cgi?id=158436
<rdar://problem/19052639>

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-06-13
Reviewed by Darin Adler.

UIWindow shouldn't be removed until cleanupFullscreen, so the video layer has a chance
to be reparented in the DOM first.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):

2:58 PM Changeset in webkit [202005] by achristensen@apple.com

44 edits
4 adds in trunk/Source

Add WebSocketProvider stub
https://bugs.webkit.org/show_bug.cgi?id=158702

Reviewed by Brady Eidson.

Source/WebCore:

No new tests. No change in behavior.

WebCore.xcodeproj/project.pbxproj:
dom/DocumentMarkerController.cpp:
dom/ScriptedAnimationController.cpp:
html/HTMLMediaElement.cpp:
html/MediaDocument.cpp:
html/shadow/MediaControlElements.cpp:
html/shadow/MediaControls.cpp:
html/shadow/MediaControls.h:
html/shadow/MediaControlsApple.cpp:
inspector/InspectorInstrumentation.cpp:
inspector/InspectorInstrumentation.h:
inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

loader/EmptyClients.h:
loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/appcache/ApplicationCacheHost.cpp:
loader/cache/CachedResource.cpp:
page/FrameView.cpp:
page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:

(WebCore::Page::applicationCacheStorage):
(WebCore::Page::databaseProvider):
(WebCore::Page::socketProvider):
(WebCore::Page::storageNamespaceProvider):

page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

page/PageConfiguration.h:
page/ResourceUsageOverlay.cpp:
page/SocketProvider.h: Added.

(WebCore::SocketProvider::~SocketProvider):

page/cocoa/ResourceUsageOverlayCocoa.mm:
rendering/RenderElement.cpp:
rendering/RenderLayerBacking.cpp:
style/StyleResolveForDocument.cpp:
style/StyleTreeResolver.cpp:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

testing/MockPageOverlayClient.cpp:

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Misc/WebSocketProvider.h: Added.
WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit/win:

WebSocketProvider.h: Added.
WebView.cpp:

(WebView::initWithFrame):

Source/WebKit2:

WebKit2.xcodeproj/project.pbxproj:
WebProcess/Network/WebSocketProvider.h: Added.
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):

Source/WTF:

wtf/UniqueRef.h:

(WTF::UniqueRef::operator->):
(WTF::UniqueRef::operator T&):
(WTF::UniqueRef::operator const T&):
Added operator T& to avoid unneeded .get() calls.

2:55 PM Changeset in webkit [202004] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, Cloop build fix.

bytecode/BytecodeList.json:

2:05 PM Changeset in webkit [202003] by keith_miller@apple.com

32 edits
1 add in trunk/Source/JavaScriptCore

Add new builtin opcode tailCallForwardArguments
https://bugs.webkit.org/show_bug.cgi?id=158666

Reviewed by Filip Pizlo.

We should support the ability to have a builtin forward its
arguments to a helper without allocating an arguments object. This
patch adds a new bytecode intrinsic @tailCallForwardArguments that
takes two values. The first is the target of the call and the
second is the new this value. This opcode will tail call to the
passed function without triggering an allocation of an arguments
object for the caller function.

In the LLInt and Baseline this function acts the same way a normal
tail call does. The bytecode will allocate a new stack frame
copying all the arguments of the caller function into the new
frame, along with the new this. Then when the actual call happens
the new frame is copied over the caller frame. While this is not
necessary, it allows the target function to have more arguments
than the caller function via arity fixup.

Once we get to the DFG we reuse existing DFG Nodes for forwarding
arguments, although there were some minor changes. This patch
swaps the meaning of the second and third children for each DFG
varargs node, exchanging the argmuments and this child,
respectively. It also makes the arguments child for each varargs
node, as well as the ForwardVarargs node optional. If the optional
child is missing, then forwarding node assumes that the arguments
for the node's inlineCallFrame should be used instead. Finally,
when inlining the target of an inlined
op_tail_call_forward_arguments we make sure the arguments of the
forwarding function are marked as non-unboxable since this would
normally be done by the caller's create arguments object node,
which does not exist in this case.

bytecode/BytecodeIntrinsicRegistry.h:
bytecode/BytecodeList.json:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callTypeFor):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallForwardArgumentsInTailPosition):
(JSC::BytecodeGenerator::emitCallVarargs):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_tailCallForwardArguments):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_tryGetById):

dfg/DFGArgumentsEliminationPhase.cpp:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasArgumentsChild):
(JSC::DFG::Node::argumentsChild):

dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileForwardVarargs):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGVarargsForwardingPhase.cpp:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs):

interpreter/Interpreter.cpp:

(JSC::sizeFrameForForwardArguments):
(JSC::setupForwardArgumentsFrame):
(JSC::setupForwardArgumentsFrameAndSetThis):

interpreter/Interpreter.h:
jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileSetupVarargsFrame):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_tail_call_forward_arguments):
(JSC::JIT::emitSlow_op_tail_call_forward_arguments):

jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_tail_call_forward_arguments):
(JSC::JIT::emit_op_tail_call_forward_arguments):
(JSC::JIT::compileSetupVarargsFrame):
(JSC::JIT::compileOpCall):

jit/JITOperations.cpp:
jit/JITOperations.h:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::varargsSetup):

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
tests/stress/tailCallForwardArguments.js: Added.

(putFuncToPrivateName.createBuiltin):
(putFuncToPrivateName):
(createTailCallForwardingFuncWith):
(baz):
(baz2):
(baz3):
(let.bodyText):
(baz4):
(baz5):
(arrayEq):

1:06 PM Changeset in webkit [202002] by commit-queue@webkit.org

12 edits in trunk

Make HashMap and HashSet work with Refs
https://bugs.webkit.org/show_bug.cgi?id=158638

Patch by Sam Weinig <sam@webkit.org> on 2016-06-13
Reviewed by Darin Adler.

Source/WTF:

wtf/GetPtr.h:

Move HashTableDeletedValueType and HashTableEmptyValueType here, as they are now shared
by more than one smart pointer. This file should probably be renamed to something else
at some point to indicate that it contains helpers for pointer and ref related functionality.

wtf/HashFunctions.h:

Add a DefaultHash for Refs. Customize the PtrHash to indicate that it is not safe to compare
to empty or deleted Refs.

wtf/HashMap.h:

(WTF::HashMapTranslator::equal):
(WTF::HashMapTranslator::translate):
(WTF::HashMapEnsureTranslator::equal):
(WTF::HashMapEnsureTranslator::translate):

wtf/HashSet.h:

(WTF::IdentityExtractor::extract):
(WTF::HashSetTranslator::hash):
(WTF::HashSetTranslator::equal):
(WTF::HashSetTranslator::translate):

wtf/HashTable.h:

(WTF::IdentityHashTranslator::hash):
(WTF::IdentityHashTranslator::equal):
(WTF::IdentityHashTranslator::translate):
Use the new assignToEmpty trait function to allow uninitialized Ref's to be safely assigned to.

wtf/HashTraits.h:

(WTF::HashTraits<Ref<P>>::emptyValue):
(WTF::HashTraits<Ref<P>>::isEmptyValue):
(WTF::HashTraits<Ref<P>>::assignToEmpty):
(WTF::HashTraits<Ref<P>>::peek):
(WTF::HashTraits<Ref<P>>::customDeleteBucket):
Add custom HashTraits for Ref. Also, introduce a new trait function, assignToEmpty, for use
in translation assignments. This is necessary since the default assignment operator for Ref
will not allow assignment to the empty Ref, which we need to do here.

wtf/Ref.h:

(WTF::Ref::operator=):
(WTF::Ref::Ref):
(WTF::Ref::isHashTableDeletedValue):
(WTF::Ref::hashTableDeletedValue):
(WTF::Ref::isHashTableEmptyValue):
(WTF::Ref::hashTableEmptyValue):
Add explicit constructors/predicates for making deleted/empty Refs.

(WTF::Ref::assignToHashTableEmptyValue):
Add a special function that allows assignment to an empty Ref, which the
assignment operator does not.

(WTF::IsSmartPtr):
Add an IsSmartPtr override to indicate that Ref is a smart pointer.

wtf/RefPtr.h:

Move HashTableDeletedValueType to GetPtr.h.

Tools:

TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):
Add tests for using Refs in HashMaps (both as key and value) and HashSets.

12:47 PM Changeset in webkit [202001] by rniwa@webkit.org

9 edits
3 adds in trunk/Websites/perf.webkit.org

Invalid token error when trying to create an A/B analysis for a range
https://bugs.webkit.org/show_bug.cgi?id=158679

Reviewed by Chris Dumez.

The problem in this particular case was due to another website overriding cookies for our subdomain.
Make PrivilegedAPI robust against its token becoming invalid in general to fix the bug since the cookie
is only available under /privileged-api/ and the v3 UI can't access it for security reasons.

This patch factors out PrivilegedAPI out of remote.js so that it can be tested separately in server tests
as well as unit tests even though RemoteAPI itself is implemented differently in each case.

init-database.sql: Added a forgotten default value "false" to run_marked_outlier.
public/v3/index.html:
public/v3/privileged-api.js: Added. Extracted out of public/v3/remote.js.

(PrivilegedAPI.sendRequest): Fixed the bug. When the initial request fails with "InvalidToken" error,
re-generate the token and re-issue the request.
(PrivilegedAPI.requestCSRFToken):

public/v3/remote.js:

(RemoteAPI.postJSON): Added to match tools/js/remote.js.
(RemoteAPI.postJSONWithStatus): Ditto.
(PrivilegedAPI): Moved to privileged-api.js.

server-tests/api-measurement-set-tests.js: Removed the unused require for crypto.
server-tests/privileged-api-upate-run-status.js: Added tests for /privileged-api/update-run-status.
server-tests/resources/test-server.js:

(TestServer.prototype.inject): Clear the cookies as well as tokens in PrivilegedAPI.

tools/js/remote.js:

(RemoteAPI): Added the support for PrivilegedAPI by making cookie set by the server persist.
(RemoteAPI.prototype.clearCookies): Added for tests.
(RemoteAPI.prototype.postJSON): Make sure sendHttpRequest always sends a valid JSON.
(RemoteAPI.prototype.postJSONWithStatus): Added since this API is used PrivilegedAPI.
(RemoteAPI.prototype.sendHttpRequest): Retain the cookie set by the server and send it back in each request.

tools/js/v3-models.js:
unit-tests/privileged-api-tests.js: Added unit tests for PrivilegedAPI.
unit-tests/resources/mock-remote-api.js:

(MockRemoteAPI.postJSON): Added for unit testing.
(MockRemoteAPI.postJSONWithStatus): Ditto.

12:40 PM Changeset in webkit [202000] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

/admin/tests is very slow
https://bugs.webkit.org/show_bug.cgi?id=158682

Reviewed by Chris Dumez.

The slowness came from TestNameResolver::construct, which was fetching the entire table of test_configurations,
which at this point contains more than 32,000 rows. Don't fetch the entire table in the constructor. Instead,
fetch a subset of rows as needed in configurations_for_metric_and_platform. Even though this results in many SQL
queries being issued, that's a lot more efficient in practice because we only fetch a few dozen rows in practice.

Also removed a whole bunch of features from /admin/tests to simplify the page. In particular, the ability to update
the list of triggerables has been removed now that sync-buildbot.js automatically updates that for us. This removed
the last use of test_exists_on_platform, which was also dependent on fetching test_configurations upfront.

public/admin/tests.php:
public/include/test-name-resolver.php:

(TestNameResolver::construct): Don't fetch the entire table of test_configurations.
(TestNameResolver::configurations_for_metric_and_platform): Just issue a SQL query for the specified platform and metric.
(TestNameResolver::test_exists_on_platform): Removed.

12:39 PM Changeset in webkit [201999] by adam.bergkvist@ericsson.com

2 edits
2 adds in trunk/LayoutTests

WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender
https://bugs.webkit.org/show_bug.cgi?id=158621

Reviewed by Eric Carlson.

Add test to verify that RTCPeerConnection.addTrack reuses an existing RTCRtpSender
under the right circumstances.

fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt: Added.
fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html: Added.
platform/mac/TestExpectations:

The mac port is not building with WEB_RTC yet.

12:38 PM Changeset in webkit [201998] by adam.bergkvist@ericsson.com

2 edits
2 adds in trunk/LayoutTests

WebRTC: Add media setup test with complete offer/answer dialog
https://bugs.webkit.org/show_bug.cgi?id=158620

Reviewed by Eric Carlson.

Test a complete SDP offer/answer dialog between two RTCPeerConnection instances in the same
page. Media is set up in both direction with a single dialog. Check the local- and
remoteDescription attributes and the RTCPeerConnection states.

fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt: Added.
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html: Added.
platform/mac/TestExpectations:

The mac port is not building with WEB_RTC yet.

11:56 AM Changeset in webkit [201997] by beidson@apple.com

2 edits in trunk/Source/WebCore

Crashes in WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask.
<rdar://problem/26768449> and https://bugs.webkit.org/show_bug.cgi?id=158696

Reviewed by David Kilzer.

No new tests (Covered by all existing tests in Gmalloc/ASAN configs).

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply):

11:08 AM Changeset in webkit [201996] by fpizlo@apple.com

2 edits in trunk/PerformanceTests

Fix round-down goof in Air.js's ShuffleCustom.forEachArg
https://bugs.webkit.org/show_bug.cgi?id=158674

Reviewed by Michael Saboff.

x / 3 * 3 is not how you round down to multiples of 3 in JavaScript. You need to do
Math.floor(x / 3) * 3 instead.

This is a benign change, because having extra arguments to a Shuffle is not something we
actually take advantage of yet. But I think it's best to match the original C++ code's
intent.

Air.js/custom.js:

(const.ShuffleCustom.forEachArg):

10:32 AM Changeset in webkit [201995] by beidson@apple.com

2 edits in trunk/Source/WebCore

Modern IDB: IDBOpenDBRequest objects leak.
https://bugs.webkit.org/show_bug.cgi?id=158694

Reviewed by Alex Christensen.

No new tests (Currently have no testing strategy for guaranteeing lifetime of WebCore DOM objects)

Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest): At this point we never need the

request again, so remove it from the map.

10:28 AM Changeset in webkit [201994] by Chris Dumez

3 edits in trunk/Source/WebCore

Make sure HTTPHeaderMap gets a move constructor / assignment operator
https://bugs.webkit.org/show_bug.cgi?id=158695
<rdar://problem/26729511>

Reviewed by Alex Christensen.

Make sure HTTPHeaderMap gets a move constructor / assignment operator.
It was not getting an implicit one because of its user-declared
destructor. This patch drops the user-declared destructor so that
HTTPHeaderMap now gets an implicit move constructor / assignment
operator.

Not having a move constructor / assignment operator is an issue because
we rely on HTTPHeaderMap::isolatedCopy() / WTFMove() since r201623 to
pass HTTPHeaderMap across thread.

platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::~HTTPHeaderMap): Deleted.

platform/network/HTTPHeaderMap.h:

9:52 AM Changeset in webkit [201993] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Unreviewed, follow up patch for r201964
https://bugs.webkit.org/show_bug.cgi?id=158619

Fix typo in the comment.

runtime/MathCommon.h:

(JSC::toInt32):

9:46 AM Changeset in webkit [201992] by nael.ouedraogo@crf.canon.fr

2 edits in trunk/Source/WebCore

Remove useless parameter from GenerateParametersCheck signature
https://bugs.webkit.org/show_bug.cgi?id=158692

Reviewed by Chris Dumez.

Remove one parameter which is passed to GenerateParametersCheck
but never used in the caller code.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(GenerateConstructorDefinition):

9:27 AM Changeset in webkit [201991] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Stack overflow at RefPtr::release on Windows port since r201782
https://bugs.webkit.org/show_bug.cgi?id=158687

Patch by Fujii Hironori <Fujii Hironori> on 2016-06-13
Reviewed by Chris Dumez.

RefPtr::release calls RefPtr::RefPtr, and RefPtr::RefPtr calls
RefPtr::release.

RefPtr::RefPtr does not need to call RefPtr::release.

wtf/RefPtr.h:

(WTF::RefPtr::RefPtr): Do not call RefPtr::release.

8:53 AM Changeset in webkit [201990] by mark.lam@apple.com

14 edits in trunk

Add a mechanism for collecting LLINT stats.
https://bugs.webkit.org/show_bug.cgi?id=158668

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch will add a mechanism for collecting the stats on LLINT opcode
execution counts. The changes made to enable this are:

Refactored how Options availability work so that we can add a new category: Configurable (in addition to the pre-existing Normal and Restricted availability).

Normal options - always available.
Restricted options - only available on debug builds.
Configurable options - depends on #define flag options.

This change is necessary so that:

we won't have to rebuild the world when we want to enable that #define flag to make that Configurable option available.
when the #define flag is disabled, the option will be invisible to the user.

With this, we add our first configurable option, JSC_reportLLIntStats, which
is dependent on the ENABLE_LLINT_STATS flag. See next.

Added the ENABLE_LLINT_STATS flag in LLIntCommon.h. To enable LLINT stats collection, we'll need to set this flag to a non-zero value, and rebuilding the project. By design, this will only require a minimal set of files to be rebuilt.

ENABLE_LLINT_STATS is 0 (i.e. disabled) by default.

Added a slow path callback to the LLINT's traceExecution() macro, to call _llint_count_opcode(), which in turns counts the opcode. This callback will only be built into the LLINT if ENABLE_LLINT_STATS is non-zero.

Added s_opcodeStatsArray to LLInt::Data. This is where the stats are recorded and stored.

Added calls to LLInt::Data::dumpStats() in jsc.cpp and DumpRenderTree.mm to dump the LLINT stats if enabled. If enabled, the LLINT stats will be sorted and dumped (via dataLog) before the programs terminate.

interpreter/Interpreter.h:
jsc.cpp:

(main):

llint/LLIntCommon.h:
llint/LLIntData.cpp:

(JSC::LLInt::initialize):
(JSC::LLInt::Data::dumpStats):

llint/LLIntData.h:

(JSC::LLInt::Data::opcodeStats):

llint/LLIntOfflineAsmConfig.h:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_crash):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
runtime/Options.cpp:

(JSC::parse):
(JSC::Options::isAvailable):
(JSC::overrideOptionWithHeuristic):
(JSC::scaleJITPolicy):
(JSC::Options::initialize):
(JSC::Options::setOptionWithoutAlias):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpOption):

runtime/Options.h:

(JSC::Option::Option):
(JSC::Option::operator!=):
(JSC::Option::id):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(DumpRenderTreeMain):

7:10 AM Changeset in webkit [201989] by commit-queue@webkit.org

6 edits in trunk

[GTK] Enabling Shadow DOM by default
https://bugs.webkit.org/show_bug.cgi?id=158686

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-06-13
Reviewed by Carlos Garcia Campos.

Added support for enabling Shadow DOM by default for GTK.

Source/cmake/OptionsGTK.cmake:

Tools:

Added support for enabling Shadow DOM by default for GTK.
Changed GTK test expectations for fast/shadow-dom tests (most tests
pass).

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Changed GTK test expectations for fast/shadow-dom tests (most tests
pass).

platform/gtk/TestExpectations:

6:40 AM Changeset in webkit [201988] by nael.ouedraogo@crf.canon.fr

9 edits in trunk/Source/WebCore

Improve code generator for functions with variadic parameters
https://bugs.webkit.org/show_bug.cgi?id=158529

Reviewed by Darin Adler.

JS bindings code of functions with variadic parameters is improved.

Functions with variadic parameters are skipped for ObjC and GObject code generators.

bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Skip functions with variadic parameters.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

bindings/scripts/CodeGeneratorObjC.pm:

(SkipFunction): Skip functions with variadic parameters.

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_any): Deleted.
(webkit_dom_test_obj_attach_shadow_root): Deleted.
(webkit_dom_test_obj_get_read_only_long_attr): Deleted.
(webkit_dom_test_obj_get_read_only_string_attr): Deleted.

bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):

bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:

2:06 AM Changeset in webkit [201987] by peavo@outlook.com

2 edits in trunk/LayoutTests

Unreviewed test gardening.

Unskip passing fast/workers tests.

platform/win/TestExpectations:

Jun 12, 2016:

8:57 PM Changeset in webkit [201986] by aakash_jain@apple.com

2 edits in trunk/Tools

run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
https://bugs.webkit.org/show_bug.cgi?id=158651
rdar://problem/26499824

Reviewed by Daniel Bates.

This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails
to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened,
so that Simulator is implicitly registered with LaunchServices while opening it.

Scripts/webkitdirs.pm:

(relaunchIOSSimulator):
Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
(quitIOSSimulator):
Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still
attempt to launch the simulator.
(waitUntilIOSSimulatorDeviceIsInState):
Added a FIXME.

1:57 PM Changeset in webkit [201985] by Alan Bujtas

3 edits in trunk/Source/WebCore

Cleanup RenderBlock::removePositionedObjects
https://bugs.webkit.org/show_bug.cgi?id=158670

Reviewed by Simon Fraser.

No change in functionality.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::removePositionedObjects):

rendering/RenderBlock.h:

1:45 PM Changeset in webkit [201984] by Alan Bujtas

3 edits
2 adds in trunk

Remove positioned descendants when RenderBlock is no longer a containing block.
https://bugs.webkit.org/show_bug.cgi?id=158655
<rdar://problem/26510032>

Reviewed by Simon Fraser.

Normally the RenderView is the containing block for fixed positioned renderers.
However when a renderer acquires some transform related properties, it becomes the containing
block for all the fixed positioned renderers in its descendant tree.
When the last transform related property is removed, the renderer is no longer a containing block
and we need to remove all these positioned renderers from the descendant tracker map (gPositionedDescendantsMap).
They will be inserted back into the tracker map during the next layout (either under the RenderView or
under the next transformed renderer in the ancestor chain).

Source/WebCore:

Test: fast/block/fixed-position-reparent-when-transition-is-removed.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removePositionedObjectsIfNeeded):

LayoutTests:

fast/block/fixed-position-reparent-when-transition-is-removed-expected.txt: Added.
fast/block/fixed-position-reparent-when-transition-is-removed.html: Added.

6:22 AM Changeset in webkit [201983] by ddkilzer@apple.com

3 edits in trunk/Source/bmalloc

Crash in com.apple.WebKit.WebContent at std::1::call_once_proxy<std::__1::tuple<CrashReporterSupportLibrary()::$_0&&> >
<https://webkit.org/b/158660>
<rdar://problem/25652686>

Reviewed by Darin Adler.

bmalloc/Logging.cpp: Switch to use

BSOFT_LINK_PRIVATE_FRAMEWORK() to link
CrashReporterSupport.framework.

bmalloc/darwin/BSoftLinking.h:

(BSOFT_LINK_PRIVATE_FRAMEWORK): Rename from BSOFT_LINK_FRAMEWORK.
Switch to use /System/Library/PrivateFrameworks/.

Jun 11, 2016:

6:14 PM Changeset in webkit [201982] by mmaxfield@apple.com

7 edits in trunk

Addressing post-review comments after r201978.
https://bugs.webkit.org/show_bug.cgi?id=158649
<rdar://problem/13258122>

Unreviewed.

Source/WebCore:

platform/graphics/FontCache.cpp:

(WebCore::FontCache::alternateFamilyName):

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

Source/WTF:

wtf/text/StringCommon.h:

(WTF::equal):
(WTF::naiveEqualWithoutPerformingUnicodeNormalization): Deleted.

Tools:

TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

4:44 PM Changeset in webkit [201981] by ap@apple.com

2 edits in trunk/Tools

Unreviewed leak fix after r201863.

DumpRenderTree/mac/DumpRenderTree.mm:

(dumpFramesAsText):

4:35 PM Changeset in webkit [201980] by Darin Adler

2 edits in trunk/Source/WebCore

Tighten code to build set of tag names
https://bugs.webkit.org/show_bug.cgi?id=158662

Reviewed by Alexey Proskuryakov.

dom/Element.cpp:

(WebCore::canAttachAuthorShadowRoot): Use an array of pointers that the loader
can initialize as part of loading the library, rather than an array that needs
to be initialized with code at runtime.

3:55 PM Changeset in webkit [201979] by mmaxfield@apple.com

3 edits in trunk/Source/WebCore

[Win] [EFL] Build fix after r201978.
https://bugs.webkit.org/show_bug.cgi?id=158649
<rdar://problem/13258122>

Unreviewed

platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

platform/graphics/win/FontCacheWin.cpp:

2:48 PM Changeset in webkit [201978] by mmaxfield@apple.com

16 edits
4 adds in trunk

[Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
https://bugs.webkit.org/show_bug.cgi?id=158649
<rdar://problem/13258122>

Reviewed by Darin Adler.

Source/WebCore:

There are many Chinese websites which hardcode Windows font names.
We should map these to fonts which best match them on Cocoa operating
systems. We can do this by using our existing fallback font name
infrastructure.

Tests: fast/text/chinese-font-name-aliases-2.html

fast/text/chinese-font-name-aliases.html

platform/graphics/FontCache.cpp:

(WebCore::FontCache::alternateFamilyName):
(WebCore::alternateFamilyName): Deleted.

platform/graphics/FontCache.h:
platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::platformAlternateFamilyName):

Source/WTF:

wtf/text/StringCommon.h:

(WTF::naiveEqualWithoutPerformingUnicodeNormalization): Added.

Tools:

TestWebKitAPI/Tests/WTF/WTFString.h:

(TestWebKitAPI::TEST):

LayoutTests:

Because this tests platform-specific font names, the test must
be platform-specific. Because it's a ref test, make two tests which
are mutually-exclusive on Cocoa platforms, and expected to fail
everywhere else.

fast/text/chinese-font-name-aliases-2-expected.html: Added.
fast/text/chinese-font-name-aliases-2.html: Added.
fast/text/chinese-font-name-aliases-expected.html: Added.
fast/text/chinese-font-name-aliases.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/mac/TestExpectations:
platform/win/TestExpectations:

1:05 PM Changeset in webkit [201977] by commit-queue@webkit.org

11 edits
1 delete in trunk

Unreviewed, rolling out r201967, r201968, and r201972.
https://bugs.webkit.org/show_bug.cgi?id=158665

Caused flaky failures on IndexedDB tests (Requested by ap on
#webkit).

Reverted changesets:

"Vary:Cookie validation doesn't work in private browsing"
https://bugs.webkit.org/show_bug.cgi?id=158616
http://trac.webkit.org/changeset/201967

"Build fix."
http://trac.webkit.org/changeset/201968

"WinCairo build fix attempt."
http://trac.webkit.org/changeset/201972

12:58 PM Changeset in webkit [201976] by mark.lam@apple.com

7 edits in trunk/Source/JavaScriptCore

Minimize the amount of memcpy done for allocating Error stacks.
https://bugs.webkit.org/show_bug.cgi?id=158664

Reviewed by Darin Adler.

Currently, Vector<StackFrame> are being copied around multiple times in the
process of creating Error stacks.

This patch avoids this unnecessary copying by:

Sizing the StackFrame vector correctly to begin with, and skipping undesirable top frames before filling in the vector.
Using perfect forwarding or passing by reference to pass the vector data around instead of copying the vectors.
Changing the Exception object to take a Vector<StackFrame> instead of a RefCountedArray<StackFrame>.

This patch has passed the JSC and layout tests. Benchmarks show that perf is
neutral.

API/tests/testapi.mm:

(testObjectiveCAPI):

inspector/ScriptCallStackFactory.cpp:

(Inspector::createScriptCallStackFromException):

interpreter/Interpreter.cpp:

(JSC::GetStackTraceFunctor::GetStackTraceFunctor):
(JSC::GetStackTraceFunctor::operator()):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::stackTraceAsString):
(JSC::findExceptionHandler):

interpreter/Interpreter.h:
runtime/Error.cpp:

(JSC::addErrorInfoAndGetBytecodeOffset):

runtime/Exception.cpp:

(JSC::Exception::finishCreation):

runtime/Exception.h:

(JSC::Exception::valueOffset):
(JSC::Exception::value):
(JSC::Exception::stack):
(JSC::Exception::didNotifyInspectorOfThrow):
(JSC::Exception::setDidNotifyInspectorOfThrow):

12:48 PM Changeset in webkit [201975] by fpizlo@apple.com

2 edits in trunk/PerformanceTests

Unreviewed, skip Air.js. It got unskipped when I renamed it from JSAir.

Skipped:

11:53 AM Changeset in webkit [201974] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Tests that overflows the stack should not be run with the sampling profiler.
https://bugs.webkit.org/show_bug.cgi?id=158663

Reviewed by Saam Barati.

The sampling profiler will be sampling the whole stack, and the amount of memory
churn will make this tests time out, especially with debug builds. Hence,
let's not run the test with the sampling profiler configuration.

tests/stress/mutual-tail-call-no-stack-overflow.js:

(shouldThrow):

11:07 AM Changeset in webkit [201973] by Konstantin Tokarev

2 edits in trunk/Source/WebCore

Fixed compilation of LocaleICU with ENABLE(DATE_AND_TIME_INPUT_TYPES)
https://bugs.webkit.org/show_bug.cgi?id=158659

Reviewed by Darin Adler.

No new tests needed.

platform/text/LocaleICU.cpp:

(WebCore::getFormatForSkeleton):
(WebCore::LocaleICU::monthFormat):
(WebCore::LocaleICU::shortMonthFormat):

10:58 AM Changeset in webkit [201972] by Antti Koivisto

4 edits in trunk/Source/WebCore

WinCairo build fix attempt.

platform/network/NetworkStorageSession.cpp:
platform/network/NetworkStorageSession.h:
platform/network/NetworkStorageSessionStub.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::context):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::~NetworkStorageSession): Deleted.
(WebCore::defaultSession): Deleted.
(WebCore::NetworkStorageSession::defaultStorageSession): Deleted.

10:52 AM Changeset in webkit [201971] by mmaxfield@apple.com

10 edits
2 adds in trunk

Deleting a CSSOM style rule invalidates any previously-added FontFaces
https://bugs.webkit.org/show_bug.cgi?id=158450

Reviewed by Darin Adler.

Source/WebCore:

This patch has two pieces: updating the CSSOM when the FontFace changes, and
updating the FontFace when the CSSOM changes.

1: Updating the CSSOM when the FontFace changes: CSSFontFaces already have a RefPtr
to their StyleRuleFontFace which represents their CSS-connection. When changing a
property of the CSSFontFace, we simply reach into the StyleRule and update it to
match. Our existing infrastructure of invalidation due to the attribute changes
makes sure that all the necessary updates occur.

Updating the FontFace when the CSSOM changes: If the CSSOM changes in a trivial

way (for example, a new @font-face is appended to the end of the last <style>
element), we can handle it directly. However, when something more invasive occurs,
we end up clearing the entire CSSFontSelector, and then adding all the style rules
from scratch. This involves three steps:

a) CSSFontSelector::buildStarted() is run, which means "we're about to start

building up all the @font-face rules from scratch." We take this opportunity
to purge as many fonts as possible. This is valuable because, for example,
this function gets run when the page gets put into the page cache, so we
want to destroy as much as possible. Not everything can be purged, however -
only CSS-connected fonts which have never been inspected by script are
purgeable. We don't allow fonts inspected by script to be purged because
purging might result in a font appearing from JavaScript to transition from
a success -> failure state, which we don't allow.

b) Upon style recalc (possibly asynchronously) CSSFontSelector::addFontFaceRule()

is called for each @font-face rule. We actually detect that we're in the
middle of a style rebuild, and defer this step.

c) When we're done adding all the font face rules, we call

CSSFontSelector::buildCompleted(). This is where we compare the newly built-
up list of font faces with what existed previously (as remembered in
CSSFontSelector::buildStarted()) in order to detect font faces which were
deleted from the document. Fonts which were newly added to the document
are handled naturally.
Fonts which have a property modified on them are created as if they were new.
However, instead of simply adding the CSSFontFace, we search for the existing
CSSFontFace (by CSS connection pointer) and tell the existing FontFace to
adopt this new CSSFontFace. This means that the JavaScript object will just
pick up any newly-written values in the CSSOM. It also means that the
"status" attribute of the JavaScript object is reset, but this is expected
and allowed by the spec. (For example, if you change the "src" attribute of
an @font-face block via the CSSOM, all bets are off when you inspect the
FontFace JS object representing that block.)

Test: fast/text/font-face-set-cssom.html

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::setFamilies):
(WebCore::CSSFontFace::setStyle):
(WebCore::CSSFontFace::setWeight):
(WebCore::CSSFontFace::setUnicodeRange):
(WebCore::CSSFontFace::setVariantLigatures):
(WebCore::CSSFontFace::setVariantPosition):
(WebCore::CSSFontFace::setVariantCaps):
(WebCore::CSSFontFace::setVariantNumeric):
(WebCore::CSSFontFace::setVariantAlternates):
(WebCore::CSSFontFace::setVariantEastAsian):
(WebCore::CSSFontFace::setFeatureSettings):
(WebCore::CSSFontFace::initializeWrapper):
(WebCore::CSSFontFace::wrapper):
(WebCore::CSSFontFace::setWrapper):
(WebCore::CSSFontFace::purgeable):
(WebCore::CSSFontFace::updateStyleIfNeeded):

css/CSSFontFace.h:
css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::remove):
(WebCore::CSSFontFaceSet::containsCSSConnection):
(WebCore::CSSFontFaceSet::purge):

css/CSSFontFaceSet.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::buildStarted):
(WebCore::CSSFontSelector::buildCompleted):
(WebCore::CSSFontSelector::addFontFaceRule):

css/CSSFontSelector.h:
css/FontFace.cpp:

(WebCore::FontFace::family):
(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::unicodeRange):
(WebCore::FontFace::variant):
(WebCore::FontFace::featureSettings):
(WebCore::FontFace::adopt):

css/FontFace.h:

LayoutTests:

fast/text/font-face-set-cssom-expected.txt: Added.
fast/text/font-face-set-cssom.html: Added.

10:44 AM Changeset in webkit [201970] by Chris Dumez

17 edits
4 copies in trunk

WorkerNavigator is missing some attributes
https://bugs.webkit.org/show_bug.cgi?id=158593
<rdar://problem/26731334>

Reviewed by Darin Adler.

Source/WebCore:

Add attributes that are missing on WorkerNavigator:

appCodeName
hardwareConcurrency
language
product
productSub
vendor
vendorSub

Firefox and Chrome already expose those attributes.

Relevant specification:
https://html.spec.whatwg.org/multipage/workers.html#the-workernavigator-object

This patch also refactors the IDL to match the specification more
closely and promote sharing between Navigator and WorkerNavigator.

No new tests, updated existing test.

CMakeLists.txt:
DerivedSources.make:

Add new supplemental IDL files.

page/Navigator.cpp:
page/Navigator.h:

Moved language() / hardwareConcurrency() from Navigator to NavigatorBase
so that it can be used by NavigatorWorker as well.

page/NavigatorBase.h:
page/NavigatorBase.cpp:

(WebCore::NavigatorBase::language):
The implementation still calls defaultLanguage() but I updated it to be
thread safe on all platforms.

(WebCore::NavigatorBase::hardwareConcurrency):
Use std::call_once() for thread safety.

page/Navigator.idl:
page/NavigatorConcurrentHardware.idl: Copied from Source/WebCore/page/WorkerNavigator.idl.
page/NavigatorID.idl: Copied from Source/WebCore/page/WorkerNavigator.idl.
page/NavigatorLanguage.idl: Copied from Source/WebCore/page/WorkerNavigator.idl.
page/NavigatorOnLine.idl: Copied from Source/WebCore/page/WorkerNavigator.idl.
page/WorkerNavigator.idl:

Move several attributes to their own supplemental interfaces to match
the specification and promote sharing with WorkerNavigator.

platform/Language.cpp:

(WebCore::userPreferredLanguages):

platform/Language.h:

Made thread-safe on all platforms.

Source/WTF:

wtf/PlatformUserPreferredLanguages.h:
wtf/PlatformUserPreferredLanguagesWin.cpp:

(WTF::platformLanguage):
(WTF::platformUserPreferredLanguages):

Make platformUserPreferredLanguages() thread safe on Windows. The
Mac and Unix implementations are already thread-safe.

LayoutTests:

Improved test coverage for WorkerNavigator.

fast/workers/resources/worker-navigator.js:

4:46 AM Changeset in webkit [201969] by ddkilzer@apple.com

5 edits in trunk/Source/bmalloc

Implement logging for RELEASE_BASSERT_WITH_MESSAGE() in BAssert.h
<http://webkit.org/b/155992>

Reviewed by Geoff Garen.

bmalloc/BAssert.h:

(BLOG_ERROR): Add method to always log error messages.
(RELEASE_BASSERT_WITH_MESSAGE): Use BLOG_ERROR() to implement
logging in Debug builds.

bmalloc/BPlatform.h:

(BPLATFORM_MAC): Add.
(BUSE): Add BUSE() macro.
(BATTRIBUTE_PRINTF): Add.
(BUSE_OS_LOG): Add.

bmalloc/Logging.cpp:

(bmalloc::reportAssertionFailureWithMessage): Add. Logs to
stderr.

bmalloc/Logging.h:

(bmalloc::reportAssertionFailureWithMessage): Add declaration.

4:20 AM Changeset in webkit [201968] by Antti Koivisto

2 edits in trunk/Source/WebCore

Build fix.

platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession):

4:09 AM Changeset in webkit [201967] by Antti Koivisto

10 edits
1 add in trunk

Vary:Cookie validation doesn't work in private browsing
https://bugs.webkit.org/show_bug.cgi?id=158616
Source/WebCore:

rdar://problem/26755067

Reviewed by Darin Adler.

This wasn't implemented because there was no way to get NetworkStorageSession from
a SessionID on WebCore side.

The patch adds a simple WebCore level weak map that allows getting NetworkStorageSessions
from SessionID. This seemed like the cleanest way to do this without a big refactoring
around the currently WebKit2 level SessionTracker.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
platform/network/CacheValidation.cpp:

(WebCore::headerValueForVary):

Get NetworkStorageSession from SessionID for cookies

(WebCore::verifyVaryingRequestHeaders):

platform/network/NetworkStorageSession.cpp: Added.

Add platform independent .cpp for NetworkStorageSession.
Implement a weak map for SessionID -> NetworkStorageSession.

(WebCore::sessionsMap):
(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::~NetworkStorageSession):
(WebCore::NetworkStorageSession::forSessionID):

Get NetworkStorageSession for sessionID.

platform/network/NetworkStorageSession.h:

(WebCore::NetworkStorageSession::sessionID):
(WebCore::NetworkStorageSession::credentialStorage):

platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):

Call to common constructor.

(WebCore::defaultNetworkStorageSession):

platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):

Call to common constructor.

(WebCore::defaultSession):
(WebCore::NetworkStorageSession::~NetworkStorageSession): Deleted.

LayoutTests:

Reviewed by Darin Adler.

http/tests/cache/disk-cache/disk-cache-vary-cookie-expected.txt:
http/tests/cache/disk-cache/disk-cache-vary-cookie.html:

Exapand the existing test to cover memory cache and private browsing.

Jun 10, 2016:

11:01 PM Changeset in webkit [201966] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Unreviewed, attempt to fix r201964 failure on Apple ports
https://bugs.webkit.org/show_bug.cgi?id=158619

Reviewed by Mark Lam.

Add Private attributes to MathCommon.h.

JavaScriptCore.xcodeproj/project.pbxproj:

10:32 PM Changeset in webkit [201965] by commit-queue@webkit.org

4 edits in trunk/Source/WebInspectorUI

Web Inspector: <template> content should not be hidden as Shadow Content
https://bugs.webkit.org/show_bug.cgi?id=158654

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-10
Reviewed by Ryosuke Niwa.

Localizations/en.lproj/localizedStrings.js:

New "Template Content" string.

UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode):
Don't treat template content as shadow content.

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
Custom string for template content fragment.

10:31 PM Changeset in webkit [201964] by Yusuke Suzuki

7 edits in trunk/Source/JavaScriptCore

[JSC] Inline JSC::toInt32 to improve kraken
https://bugs.webkit.org/show_bug.cgi?id=158619

Reviewed by Mark Lam.

Several kraken benchmarks show that JSC::toInt32 is frequently called.
For example, stanford-crypto-pbkdf2 reports that the hottest runtime function is JSC::toInt32.

The data is below (taken by Linux perf tools).
5.50% jsc libJavaScriptCore.so.1.0.0 . _ZN3JSC7toInt32Ed
3.96% jsc libJavaScriptCore.so.1.0.0 . _ZN3JSC20arrayProtoFuncConcatEPNS_9ExecStateE
2.48% jsc libJavaScriptCore.so.1.0.0 . _ZN3JSC19arrayProtoFuncSliceEPNS_9ExecStateE
1.69% jsc libJavaScriptCore.so.1.0.0 . _ZNK3JSC9Structure27holesMustForwardToPrototypeERNS_2VME

This is because of CommonSlowPaths' bit operations's JSValue::toInt32.
Due to the slow path, in value | 0, value may be a double number value. In that case, JSC::toInt32 is called.

While JSC::toIn32 is hot, the function itself is very small. It's worth inlining.

This change offers the following kraken improvements.

baseline patched

Kraken:

audio-beat-detection 47.492+-1.701 46.657+-1.232 might be 1.0179x faster
stanford-crypto-aes 43.669+-0.210 ^{42.862+-0.115} definitely 1.0188x faster
stanford-crypto-ccm 45.213+-1.424 44.490+-1.290 might be 1.0162x faster
stanford-crypto-pbkdf2 107.665+-0.581 ^{106.229+-0.807} definitely 1.0135x faster

This patch only focused on the call to toInt32 from the runtime functions.
So JSC::toInt32 calls from the baseline / DFG remain.
We ensure that JIT code uses operationToInt32 instead of JSC::toInt32 since JSC::toInt32 is now marked as ALWAYS_INLINE.
Linux perf profiler also finds that this operationToInt32 is frequently called in the above benchmarks.
It may be good to introduce asm emit for that instead of calling JSC::toInt32 operation in the separated patch.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::doubleToInt32):
(JSC::FTL::DFG::LowerDFGToB3::sensibleDoubleToInt32):

runtime/JSCJSValue.cpp:

(JSC::toInt32): Deleted.

runtime/JSCJSValueInlines.h:
runtime/MathCommon.cpp:

(JSC::operationToInt32):

runtime/MathCommon.h:

(JSC::toInt32):

9:37 PM Changeset in webkit [201963] by adachan@apple.com

5 edits in trunk/Source

Use the video element's video box when getting the inline video rect in WebVideoFullscreenManager
https://bugs.webkit.org/show_bug.cgi?id=158351
<rdar://problem/26567938>

Reviewed by Darin Adler.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:

Change the visibility of RenderVideo.h and RenderMedia.h since we'll be importing RenderVideo.h from WebKit2.

rendering/RenderVideo.h:

Source/WebKit2:

WebProcess/cocoa/WebVideoFullscreenManager.mm:

(WebKit::inlineVideoFrame):
(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::WebVideoFullscreenManager::exitVideoFullscreenForVideoElement):
(WebKit::WebVideoFullscreenManager::fullscreenMayReturnToInline):
(WebKit::WebVideoFullscreenManager::setVideoLayerFrameFenced):
(WebKit::clientRectForElement): Deleted.

9:24 PM Changeset in webkit [201962] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix CMake build.

PlatformMac.cmake:

6:52 PM Changeset in webkit [201961] by fpizlo@apple.com

2 edits
1 add in trunk/PerformanceTests

Make it easy to package Air.js
https://bugs.webkit.org/show_bug.cgi?id=158652

Reviewed by Benjamin Poulain.

If you want to give Air.js to someone, you can now do:

cd PerformanceTests/Air.js
./make_dist.sh

This will create Air.js.tar.gz and a directory called Air.js. If you want to send someone
the benchmark, just send either of those things and tell them to look at index.html.

You may have to edit make_dist.sh for wherever you have Markdown.pl. You can get that from
https://daringfireball.net/projects/markdown/

Air.js/make_dist.sh: Added.
Air.js/test.html:

6:32 PM Changeset in webkit [201960] by fpizlo@apple.com

2 edits in trunk/PerformanceTests

Unreviewed, make the link to test.html into an actual link.

Air.js/README.md:

6:20 PM Changeset in webkit [201959] by fpizlo@apple.com

2 edits in trunk/PerformanceTests

Fix some text in Air.js/README.md
https://bugs.webkit.org/show_bug.cgi?id=158650

Reviewed by Benjamin Poulain.

I read the text again and found bugs:

We never actually say how to run the benchmark. This change adds a blurb about how to run it.

We both say that allocateStack is responsible for the bulk of the running time and that we haven't measured where the bulk of the time is spent. This changes the text to say that it was a goal to make allocateStack be the hottest part of the benchmark, but that we did not measure this.

Air.js/README.md:

6:18 PM Changeset in webkit [201958] by benjamin@webkit.org

37 edits
10 adds in trunk

Add support for passive event listeners on touch events
https://bugs.webkit.org/show_bug.cgi?id=158601

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-10
Reviewed by Simon Fraser.

Source/WebCore:

This patch wires "passive" state of EventTarget to the delivery of touch
events in WebKit2.

Instead of having a NonFastScrollableRegion, we have a pair of regions
in EventTrackingRegions.
The "asynchronousDispatchRegion" tracks the area for which all event
listeners are passive. For those, events should be dispatched asynchronously.
The "synchronousDispatchRegion" tracks the area for which there is at
least one active event listener. Events have to be dispatched synchronously
for correctness.

Tests: fast/events/touch/ios/tap-with-active-listener-on-elements.html

fast/events/touch/ios/tap-with-active-listener-on-window.html
fast/events/touch/ios/tap-with-passive-listener-on-elements.html
fast/events/touch/ios/tap-with-passive-listener-on-window.html

WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::wheelEventHandlersChanged):
(WebCore::Document::Document): Deleted.

dom/Document.h:

dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::containsActive):
If a Target has multiple listener for an event type, we want to know
if any of them is active.

dom/EventListenerMap.h:
dom/EventTarget.cpp:

(WebCore::EventTarget::hasActiveEventListeners):
(WebCore::EventTarget::hasActiveTouchEventListeners):

dom/EventTarget.h:

page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):
I did not change the debug overlays.
The NonFastScrollable area is the region for which events needs
synchronous dispatch. Everything else should scroll without delay.

page/FrameView.cpp:

(WebCore::FrameView::scrollableAreaSetChanged):

page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setEventTrackingRegionsDirty):
(WebCore::AsyncScrollingCoordinator::willCommitTree):
(WebCore::AsyncScrollingCoordinator::updateEventTrackingRegions):
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):
(WebCore::AsyncScrollingCoordinator::scrollingStateTreeAsText):
(WebCore::AsyncScrollingCoordinator::setNonFastScrollableRegionDirty): Deleted.
(WebCore::AsyncScrollingCoordinator::updateNonFastScrollableRegion): Deleted.
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged): Deleted.

page/scrolling/AsyncScrollingCoordinator.h:

(WebCore::AsyncScrollingCoordinator::eventTrackingRegionsDirty):
(WebCore::AsyncScrollingCoordinator::nonFastScrollableRegionDirty): Deleted.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame):
(WebCore::ScrollingCoordinator::absoluteEventTrackingRegions):
(WebCore::ScrollingCoordinator::absoluteNonFastScrollableRegionForFrame): Deleted.
(WebCore::ScrollingCoordinator::absoluteNonFastScrollableRegion): Deleted.
I intentionally left the Wheel event with synchronous dispatch.
This use case will need its own set of tests.

page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::frameViewEventTrackingRegionsChanged):
(WebCore::ScrollingCoordinator::frameViewNonFastScrollableRegionChanged): Deleted.

page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::setEventTrackingRegions):
(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):
(WebCore::ScrollingStateFrameScrollingNode::setNonFastScrollableRegion): Deleted.

page/scrolling/ScrollingStateFrameScrollingNode.h:
page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::commitNewTreeState):
(WebCore::ScrollingTree::eventTrackingTypeForPoint):
(WebCore::ScrollingTree::isPointInNonFastScrollableRegion): Deleted.

page/scrolling/ScrollingTree.h:
page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::scheduleTreeStateCommit):

platform/EventTrackingRegions.h: Added.

(WebCore::EventTrackingRegions::isEmpty):
(WebCore::EventTrackingRegions::trackingTypeForPoint):
(WebCore::operator==):

Source/WebKit2:

Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode):
(WebKit::dump):

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<EventTrackingRegions>::encode):
(IPC::ArgumentCoder<EventTrackingRegions>::decode):

Shared/WebCoreArgumentCoders.h:
UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::eventTrackingTypeForPoint):
(WebKit::RemoteScrollingCoordinatorProxy::isPointInNonFastScrollableRegion): Deleted.

UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::touchEventTrackingType):
The type is the most restrictive type of all the touch points.
If any touch point needs synchronous tracking, everything has to be synchronous.

(WebKit::WebPageProxy::handleTouchEventSynchronously):
This is a very unfortunate design.

The upper layer dealing with UIKit knows about gesture and when something
can be dispatched asynchrnously because a gesture has started.
This layer knows about tracking and can use that extra inforamtion
to dispatch an event asynchrnously anyway.

In the future, we should refactor this to let WebPageProxy
always decide of the dispatch type. I am just concerned changing
the upper layer while we are stabilizing WebKit.

(WebKit::WebPageProxy::handleTouchEventAsynchronously):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::WebPageProxy): Deleted.
(WebKit::WebPageProxy::shouldStartTrackingTouchEvents): Deleted.

UIProcess/WebPageProxy.h:

LayoutTests:

fast/events/touch/ios/tap-with-active-listener-on-elements-expected.txt: Added.
fast/events/touch/ios/tap-with-active-listener-on-elements.html: Added.
fast/events/touch/ios/tap-with-active-listener-on-window-expected.txt: Added.
fast/events/touch/ios/tap-with-active-listener-on-window.html: Added.
fast/events/touch/ios/tap-with-passive-listener-inside-active-listener-expected.txt: Added.
fast/events/touch/ios/tap-with-passive-listener-on-elements-expected.txt: Added.
fast/events/touch/ios/tap-with-passive-listener-on-elements.html: Added.
fast/events/touch/ios/tap-with-passive-listener-on-window-expected.txt: Added.
fast/events/touch/ios/tap-with-passive-listener-on-window.html: Added.

5:48 PM Changeset in webkit [201957] by fpizlo@apple.com

1 edit
1 add in trunk/PerformanceTests

Air.js should have some documentation
https://bugs.webkit.org/show_bug.cgi?id=158648

Reviewed by Keith Miller.

I want to be able to point people at a document if they want to know more about this
benchmark.

Air.js/README.md: Added.

5:21 PM Changeset in webkit [201956] by enrica@apple.com

9 edits
2 adds in trunk

REGRESSION(r198177): Cannot paste an image when the pasteboard format is mime type.
https://bugs.webkit.org/show_bug.cgi?id=158590
rdar://problem/25471371

Reviewed by Darin Adler.

Source/WebCore:

When creating a fragment from an image resource, the resource needs to
be added to the document loader before setting the src attribute to the
image element, otherwise loading is triggered and the loading fails.
In r198177 the order of the operations was changed causing the bug.
This patch adds support to test the scenario where the image in the pasteboard
is available only as mime type (not WebArchive or RTFD), a situation that occurs
more frequently on iOS.

Test: editing/pasteboard/image-in-iframe.html

editing/ios/EditorIOS.mm:

(WebCore::Editor::createFragmentForImageResourceAndAddResource):

editing/mac/EditorMac.mm:

(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):

page/Settings.cpp:

(WebCore::Settings::setImagesEnabled):
(WebCore::Settings::setPreferMimeTypeForImages):
(WebCore::Settings::setForcePendingWebGLPolicy):

page/Settings.h:

(WebCore::Settings::areImagesEnabled):
(WebCore::Settings::preferMimeTypeForImages):
(WebCore::Settings::arePluginsEnabled):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
(WebCore::InternalSettings::setPreferMimeTypeForImages):
(WebCore::InternalSettings::setImagesEnabled):

testing/InternalSettings.h:
testing/InternalSettings.idl:

LayoutTests:

editing/pasteboard/image-in-iframe-expected.txt: Added.
editing/pasteboard/image-in-iframe.html: Added.

5:20 PM Changeset in webkit [201955] by achristensen@apple.com

2 edits in trunk/Tools

Fix CMake build.

TestWebKitAPI/PlatformMac.cmake:

5:15 PM Changeset in webkit [201954] by achristensen@apple.com

3 edits in trunk/Source/WebCore

Fix WinCairo build after r201943

platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveResponse):

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::handleLocalReceiveResponse):
(WebCore::headerCallback):
(WebCore::ResourceHandleManager::dispatchSynchronousJob):

4:54 PM Changeset in webkit [201953] by fpizlo@apple.com

3 edits
6 copies
1 move
2 deletes in trunk

PerformanceTests:
Rename JSAir to Air.js.

Rubber stamped by Mark Lam.

Air.js: Copied from PerformanceTests/JSAir.
Air.js/airjs-tests.yaml: Copied from PerformanceTests/JSAir/jsair-tests.yaml.
Air.js/benchmark.js: Copied from PerformanceTests/JSAir/benchmark.js.

(Benchmark):

Air.js/jsair-tests.yaml: Removed.
Air.js/payload-airjs-ACLj8C.js: Copied from PerformanceTests/JSAir/payload-jsair-ACLj8C.js.
Air.js/payload-jsair-ACLj8C.js: Removed.
Air.js/stress-test.js: Copied from PerformanceTests/JSAir/stress-test.js.
Air.js/test.html: Copied from PerformanceTests/JSAir/test.html.
Air.js/test.js: Copied from PerformanceTests/JSAir/test.js.
JSAir: Removed.
JSAir/all.js: Removed.
JSAir/allocate_stack.js: Removed.
JSAir/arg.js: Removed.
JSAir/basic_block.js: Removed.
JSAir/benchmark.js: Removed.
JSAir/code.js: Removed.
JSAir/custom.js: Removed.
JSAir/frequented_block.js: Removed.
JSAir/insertion_set.js: Removed.
JSAir/inst.js: Removed.
JSAir/jsair-tests.yaml: Removed.
JSAir/liveness.js: Removed.
JSAir/opcode.js: Removed.
JSAir/payload-gbemu-executeIteration.js: Removed.
JSAir/payload-imaging-gaussian-blur-gaussianBlur.js: Removed.
JSAir/payload-jsair-ACLj8C.js: Removed.
JSAir/payload-typescript-scanIdentifier.js: Removed.
JSAir/reg.js: Removed.
JSAir/stack_slot.js: Removed.
JSAir/stress-test.js: Removed.
JSAir/strip-hash.rb: Removed.
JSAir/symbols.js: Removed.
JSAir/test.html: Removed.
JSAir/test.js: Removed.
JSAir/tmp.js: Removed.
JSAir/tmp_base.js: Removed.
JSAir/util.js: Removed.

Tools:
Rename JSAir to Air.js

Rubber stamped by Mark Lam.

Scripts/run-javascriptcore-tests:

4:29 PM Changeset in webkit [201952] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking imported/blink/storage/indexeddb/blob-delete-objectstore-db.html as flaky on Yosemite Release WK2
https://bugs.webkit.org/show_bug.cgi?id=158639

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

4:18 PM Changeset in webkit [201951] by matthew_hanson@apple.com

2 edits in branches/safari-601.1.46-branch/LayoutTests

Roll out r201287. rdar://problem/26605164

4:10 PM Changeset in webkit [201950] by matthew_hanson@apple.com

2 edits in branches/safari-601-branch/LayoutTests

Merge r201287. rdar://problem/26228555

4:05 PM Changeset in webkit [201949] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: heap snapshot comparison view shows nothing if later snapshot is chosen first
https://bugs.webkit.org/show_bug.cgi?id=158584
<rdar://problem/26727849>

Reviewed by Timothy Hatcher.

ALways compare the the later snapshot to the earlier snapshot,
regardless of selection order.

UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype._dataGridNodeSelected):
Swap shapshots if the first has a greater identifier than the second.
Drive-by cleanup: null out _baselineDataGridNode since it isn't used
after the comparison completes.

4:00 PM Changeset in webkit [201948] by matthew_hanson@apple.com

2 edits in branches/safari-601.1.46-branch/LayoutTests

Merge r201287. rdar://problem/26605164

3:55 PM Changeset in webkit [201947] by fpizlo@apple.com

7 edits
1 add in trunk

JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
https://bugs.webkit.org/show_bug.cgi?id=158571

Reviewed by Keith Miller.

PerformanceTests:

Introduce a different harness for run-jsc-stress-tests, which runs for a minimum of 10
iterations and then tries to do any number of "bonus" iterations until it's been running for
two seconds. Since this is the sort of test that isn't really meant to stress anything in
particular, I think it's OK if it is time-limited in this way. The worst case is that some
of its failures will be flaky, but I think that they would have been flaky anyway given the
complexity of the test.

JSAir/benchmark.js:

(Benchmark):
(Benchmark.prototype.runIteration):
(benchmark): Deleted.

JSAir/jsair-tests.yaml:
JSAir/stress-test.js: Added.

(preciseTime):

JSAir/test.html:
JSAir/test.js:

Tools:

Unskip the JSAir test.

Scripts/run-javascriptcore-tests:

(runJSCStressTests):

3:26 PM Changeset in webkit [201946] by achristensen@apple.com

3 edits
2 deletes in trunk/Source/WebCore

handleDataURL is only used by curl
https://bugs.webkit.org/show_bug.cgi?id=158636

Reviewed by Tim Horton.

CMakeLists.txt:
platform/network/DataURL.cpp: Removed.
platform/network/DataURL.h: Removed.
platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::startScheduledJobs):
(WebCore::handleDataURL):
(WebCore::ResourceHandleManager::dispatchSynchronousJob):

3:18 PM Changeset in webkit [201945] by Beth Dakin

3 edits in trunk/Source/WebKit2

Add requestExitFullScreen to WKFullScreenWindowController
https://bugs.webkit.org/show_bug.cgi?id=158633
-and corresponding-
rdar://problem/26564036

Reviewed by Tim Horton.

UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController requestExitFullScreen]):

3:15 PM Changeset in webkit [201944] by weinig@apple.com

2 edits in trunk/Tools

Re-disable the UserMedia tests which are timing out.

They used to be accidentally disabled, due to not including
the FeatureDefines correctly, but not we explicitly disable it.

TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

(TestWebKitAPI::TEST):

3:02 PM Changeset in webkit [201943] by achristensen@apple.com

37 edits in trunk/Source

Reduce ResourceResponse copying
https://bugs.webkit.org/show_bug.cgi?id=158232

Reviewed by Darin Adler.

Source/WebCore:

No new tests. No change in behavior except removing an unnecessary copy on cocoa platforms.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):

loader/ResourceLoader.h:
loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):
(WebCore::ApplicationCacheGroup::didReceiveResponse):

loader/appcache/ApplicationCacheGroup.h:
platform/graphics/PlatformMediaResourceLoader.h:

(WebCore::PlatformMediaResourceClient::~PlatformMediaResourceClient):
(WebCore::PlatformMediaResourceClient::responseReceived):
(WebCore::PlatformMediaResourceClient::redirectReceived):
(WebCore::PlatformMediaResourceClient::shouldCacheResponse):
(WebCore::PlatformMediaResourceClient::dataSent):

platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(ResourceHandleStreamingClient::willSendRequest):
(ResourceHandleStreamingClient::didReceiveResponse):

platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::notifyResponseOnSuccess):
(WebCore::BlobResourceHandle::notifyResponseOnError):
(WebCore::BlobResourceHandle::notifyReceiveData):

platform/network/DataURL.cpp:

(WebCore::handleDataURL):

platform/network/PingHandle.h:

(WebCore::PingHandle::PingHandle):

platform/network/ResourceHandleClient.cpp:

(WebCore::ResourceHandleClient::willSendRequestAsync):
(WebCore::ResourceHandleClient::didReceiveResponseAsync):

platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didSendData):
(WebCore::ResourceHandleClient::didReceiveResponse):
(WebCore::ResourceHandleClient::didReceiveData):

platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::ResourceResponseBase::includeCertificateInfo):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::certificateInfo): Deleted.

platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::certificateInfo):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
(WebCore::ResourceResponseBase::containsCertificateInfo): Deleted.

platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):
(WebCore::SynchronousLoaderClient::didReceiveResponse):
(WebCore::SynchronousLoaderClient::didReceiveData):

platform/network/SynchronousLoaderClient.h:
platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):

platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveData):

platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):

Source/WebKit2:

NetworkProcess/Downloads/PendingDownload.h:
NetworkProcess/NetworkDataTask.h:
NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::continueDidReceiveResponse):
(WebKit::NetworkLoad::sharedDidReceiveResponse):
(WebKit::NetworkLoad::sharedWillSendRedirectedRequest):
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
(WebKit::NetworkLoad::didReceiveResponseAsync):

NetworkProcess/NetworkLoad.h:
NetworkProcess/NetworkLoadClient.h:
NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::abort):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/PingLoad.h:
NetworkProcess/cache/NetworkCacheCoders.h:

(WebKit::NetworkCache::Coder<Optional<T>>::encode):
(WebKit::NetworkCache::Coder<Optional<T>>::decode):

NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):

NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTask::didCompleteWithError):
(WebKit::NetworkDataTask::didReceiveResponse):

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::url):
(WebKit::WebFrame::certificateInfo):
(WebKit::WebFrame::innerText):

3:00 PM Changeset in webkit [201942] by rniwa@webkit.org

9 edits in trunk/Source

Add SPI to disable spellchecking on auto-fillable text fields
https://bugs.webkit.org/show_bug.cgi?id=158611

Reviewed by Anders Carlsson.

Source/WebCore:

Added a boolean flag m_isSpellCheckingEnabled to HTMLInputElement. This flag defaults to true, and can be set
to false by WebKit2 C API.

editing/Editor.cpp:

(WebCore::Editor::isSpellCheckingEnabledFor): Fixed a bug that we were calling isSpellCheckingEnabled on
the div inside an input element's shadow tree instead of the input element itself.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::HTMLInputElement): Initialize m_spellcheckEnabled to true (it's a bit field).
(WebCore::HTMLInputElement::isSpellCheckingEnabled): Added. Return false if m_spellcheckEnabled is false.

html/HTMLInputElement.h:

(WebCore::HTMLInputElement::setSpellcheckEnabled): Added.

Source/WebKit2:

Added WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled to disable spellchecking on a text field.

This is used by WebKit2 client which desires to disable spellchecking and notably autocorrection on
login forms, etc... where such feature would interfere with user's actions.

WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleSetHTMLInputElementSpellcheckEnabled): Added.

WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementSpellcheckEnabled): Added.

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

2:26 PM Changeset in webkit [201941] by achristensen@apple.com

20 edits
2 adds in trunk

Introduce WTF::UniqueRef
https://bugs.webkit.org/show_bug.cgi?id=158596

Reviewed by Brady Eidson.

Source/WebCore:

No new tests. No change in behavior.

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:

(WebCore::Page::canStartMedia):
(WebCore::Page::editorClient):
(WebCore::Page::plugInClient):
(WebCore::Page::mainFrame):
(WebCore::Page::groupPtr): Deleted.

page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

page/PageConfiguration.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit/win:

WebView.cpp:

(WebView::initWithFrame):

Source/WebKit2:

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):

Source/WTF:

WTF::UniqueRef is like a std::unique_ptr that is guaranteed to be non-null.
std::make_unique returns a non-null value that is put into a std::unique_ptr, a type
that could contain null values. To be able to pass such values around and store them
without wondering if they are null, we now have WTF::UniqueRef which cannot be null.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/UniqueRef.h: Added.

(WTF::makeUniqueRef):
(WTF::UniqueRef::UniqueRef):
(WTF::UniqueRef::get):
(WTF::UniqueRef::operator&):
(WTF::UniqueRef::operator->):

Tools:

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.

(TestWebKitAPI::B::B):
(TestWebKitAPI::C::C):
(TestWebKitAPI::function):
(TestWebKitAPI::TEST):

2:01 PM Changeset in webkit [201940] by beidson@apple.com

1 edit
3 adds in trunk/LayoutTests

Add an IDB leak test.
https://bugs.webkit.org/show_bug.cgi?id=158632

Reviewed by Alex Christensen.

storage/indexeddb/modern/leak-1-expected.txt: Added.
storage/indexeddb/modern/leak-1.html: Added.
storage/indexeddb/modern/resources/leak-1.js: Added.

1:59 PM Changeset in webkit [201939] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Cleanup InspectorIndexedDBAgent a bit
https://bugs.webkit.org/show_bug.cgi?id=158598

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-10
Reviewed by Darin Adler.

inspector/InspectorIndexedDBAgent.cpp:

1:38 PM Changeset in webkit [201938] by weinig@apple.com

8 edits
4 adds in trunk/Tools

Refactor TestWebKitAPI to allow just testing WTF
https://bugs.webkit.org/show_bug.cgi?id=158625

Reviewed by Tim Horton.

Extract all the WTF tests into a new target to allow a faster build / test / fix
cycle when working on WTF bugs and features.

By calling run-api-tests --wtf-only, you don't need to have a build of JavaScriptCore/WebCore/etc
to test WTF only changes.

Scripts/build-api-tests:
Scripts/run-api-tests:

(buildTestTool):
(testToolPaths):
Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
the test runner that runs the WTF tests.

TestWebKitAPI/Tests/WTF/RunLoop.cpp:

Use Utilities.h rather than PlatformUtilities.h.

TestWebKitAPI/Utilities.h: Added.
TestWebKitAPI/PlatformUtilities.h:
TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.

Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
that don't depend on anything in the WebKit project.

12:59 PM Changeset in webkit [201937] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: rendering frames timeline "60fps" horizontal guide is mispositioned after switching timeline modes
https://bugs.webkit.org/show_bug.cgi?id=158587
<rdar://problem/26728174>

Reviewed by Timothy Hatcher.

When the view mode changes we iterate over all overview graphs, updating
their visibility as needed. Graphs being shown perform layout, even though
the overview's state is in transition: its offset height may still change.

A simple fix is to use TimelineOverviewGraph.height instead of the graph
element's offset height when performing layout.

UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:

(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.layout):

12:56 PM Changeset in webkit [201936] by fpizlo@apple.com

7 edits in trunk/Source/JavaScriptCore

The backend should be happy to compile Unreachable even if AI didn't prove it to be unreachable
https://bugs.webkit.org/show_bug.cgi?id=158631

Reviewed by Keith Miller.

We've been slowly making the DFG Unreachable opcode behave like a grown-up. When we first
added it, it was a hack for Throw, and we could always rely on AI proving that Unreachable
was not reachable. But then we started using Unreachable as a proper Unreachable opcode,
like Oops in B3 for example, which has a more nuanced meaning: you use it whenever you
emit code that *you* know will not return, and you need some way of terminating the basic
block. The DFG is not a proof-carrying compiler, and it never will be. So, when you have
proved that something is not reachable, you should be able to use Unreachable even if
there is no guarantee that the compiler will later be able to replicate your proof. This
means that the backend may find itself compiling Unreachable because AI did not prove that
it was unreachable.

Prior to this change, we would crash compiling Unreachable because we would rely on AI
preventing us from reaching Unreachable in the backend. But that's silly! We don't want
users of Unreachable to have to also convince AI that their Unreachable is really
Unreachable.

This fixes crashes on real websites. I couldn't work out how to turn them into a reduced
test.

assembler/AbortReason.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitInvalidationPoint):
(JSC::DFG::SpeculativeJIT::unreachable):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compilePutDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compileUnreachable):
(JSC::FTL::DFG::LowerDFGToB3::compareEqObjectOrOtherToObject):

12:42 PM Changeset in webkit [201935] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

REGRESSION (r201538): Web Inspector: 1px gap above timeline progress view
https://bugs.webkit.org/show_bug.cgi?id=158626

Reviewed by Joseph Pecoraro.

Adjust progress view top position to account for grid border changes.

UserInterface/Views/TimelineRecordingContentView.css:

(.content-view.timeline-recording > .content-browser .recording-progress):

12:41 PM Changeset in webkit [201934] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r201538): Web Inspector: Border under JS Call Trees content view is too thick
https://bugs.webkit.org/show_bug.cgi?id=158624
<rdar://problem/26743633>

Reviewed by Joseph Pecoraro.

Remove top border from <th> elements.

UserInterface/Views/ProfileView.css:

(.profile > .data-grid th): Deleted.

11:49 AM Changeset in webkit [201933] by andersca@apple.com

2 edits
2 deletes in trunk/Source/WebKit2

Remove CommandLine class
https://bugs.webkit.org/show_bug.cgi?id=158628

Reviewed by Tim Horton.

Shared/CommandLine.h: Removed.

(WebKit::CommandLine::operator[]): Deleted.

Shared/posix/CommandLinePOSIX.cpp: Removed.

(WebKit::CommandLine::parse): Deleted.

WebKit2.xcodeproj/project.pbxproj:

11:49 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

11:49 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

11:43 AM Changeset in webkit [201932] by beidson@apple.com

2 edits in trunk/Tools

REGRESSION(r201928?) API test WTF.StringOperators failing
https://bugs.webkit.org/show_bug.cgi?id=158623

Unreviewed, but buddy coded with Alex Christensen.

TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:

(TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed

to use string concatenation, otherwise the linker will mess up on the symbol related to
this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.

11:41 AM Changeset in webkit [201931] by clopez@igalia.com

6 edits in trunk/LayoutTests

[GTK] Unreviewed gardening.

TestExpectations: shadow-dom tests timeout on the GTK port.

Update the general expectations file to include also Timeout as
an expected failure.

platform/gtk/TestExpectations: Since r200320 resource-timing feature is a runtime flag and this causes failures.

Remove also one test that has been removed.

platform/gtk/fast/table/border-collapsing/cached-change-row-border-width-expected.txt: rebaseline after r201234
platform/gtk/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: rebaseline after r201234
platform/gtk/fast/table/max-width-integer-overflow-expected.txt: rebaseline after r201234

11:17 AM Changeset in webkit [201930] by youenn.fablet@crf.canon.fr

8 edits
3 adds in trunk

Origin header is not included in CORS requests for preloaded cross-origin resources
https://bugs.webkit.org/show_bug.cgi?id=155761
<rdar://problem/25351850>

Reviewed by Alex Christensen.

Source/WebCore:

Making HTML preloader fully aware of crossorigin attribute value.
Introducing CachedResourceRequest::setAsPotentiallyCrossOrigin as a helper routine to activate CORS mode.
Making HTMLLinkElement and HTMLResourcePreloader use that routine.
Making TokenPreloadScanner store the crossorigin attribute value in preload requests.
Making TokenPreloadScanner store the crossorigin attribute value for link elements.

Test: http/tests/security/cross-origin-css-9.html

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

html/parser/HTMLResourcePreloader.cpp:

(WebCore::crossOriginModeAllowsCookies):
(WebCore::PreloadRequest::resourceRequest):

html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::setCrossOriginMode):
(WebCore::PreloadRequest::PreloadRequest): Deleted.
(WebCore::PreloadRequest::resourceType): Deleted.

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setAsPotentiallyCrossOrigin):

loader/cache/CachedResourceRequest.h:

LayoutTests:

http/tests/security/cross-origin-css-9-expected.txt: Added.
http/tests/security/cross-origin-css-9.html: Added.
http/tests/security/resources/get-css-if-origin-header.php: Added.

11:01 AM Changeset in webkit [201929] by Simon Fraser

3 edits in trunk/Source/WebKit2

[iOS WK2] Rare RELEASE_ASSERT under RemoteLayerTreeDrawingArea::flushLayers()
https://bugs.webkit.org/show_bug.cgi?id=158622
rdar://problem/26609452

Reviewed by Tim Horton.

It's possible for a CADisplayLink to fire after being paused sometimes, possibly
when an app is running another CADisplayLink whose callback takes some time. When
this happens, RemoteLayerTreeDrawingAreaProxy could erroneously send a second
didUpdate() to the web process between commits, which would clear the m_waitingForBackingStoreSwap
flag too early, and allow a subsequent RemoteLayerTreeDrawingArea::flushLayers()
to proceed when the m_pendingBackingStoreFlusher was still flushing.

Fix by preventing two didUpdates from being sent from the UI process between
commits.

Not easily testable.

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):

10:04 AM Changeset in webkit [201928] by beidson@apple.com

2 edits in trunk/Tools

WTF_CrossThreadTask.Basic fails in all non mac ports.
https://bugs.webkit.org/show_bug.cgi?id=158612

Reviewed by Alex Christensen.

The test is very sensitive to argument evaluation order which is explicitly undefined in C++.

Instead, we should just count the appropriate events to forget their order.

TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:

(TestWebKitAPI::LifetimeLogger::LifetimeLogger):
(TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
(TestWebKitAPI::LifetimeLogger::isolatedCopy):
(TestWebKitAPI::LifetimeLogger::fullName):
(TestWebKitAPI::testFunction):
(TestWebKitAPI::TEST):
(TestWebKitAPI::LifetimeLogger::log): Deleted.
(TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.

9:45 AM Changeset in webkit [201927] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking fast/hidpi/hidpi-3x-device-pixel-ratio.html as failing on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=158618

Unreviewed test gardening.

platform/ios-simulator/TestExpectations:

9:19 AM Changeset in webkit [201926] by Chris Dumez

5 edits in trunk

ErrorEvent / ProgressEvent should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=158606

Reviewed by Brady Eidson.

Source/WebCore:

ErrorEvent / ProgressEvent should be exposed to workers:

Firefox and Chrome both already expose those.

No new tests, rebaselined existing test.

dom/ErrorEvent.idl:
dom/ProgressEvent.idl:

LayoutTests:

Rebaseline test.

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

7:47 AM Changeset in webkit [201925] by Chris Dumez

4 edits in trunk

MessagePort should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=158607

Reviewed by Brady Eidson.

Source/WebCore:

MessagePort should be exposed to workers:
https://html.spec.whatwg.org/multipage/comms.html#messageport

Firefox and Chrome both already expose it.

No new tests, rebaselined existing test.

dom/MessagePort.idl:

LayoutTests:

Rebaseline test.

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

6:26 AM Changeset in webkit [201924] by youenn.fablet@crf.canon.fr

5 edits
2 adds in trunk/Source/WebCore

Move preflight check code outside of DocumentThreadableLoader
https://bugs.webkit.org/show_bug.cgi?id=158425

Reviewed by Darin Adler.

Moving preflight check code in its own class.
This allows code to be easier to read, use/reuse and update.

Behavior should be the same as before except in the case of a preflight response
being a 3XX redirect response.
Before this patch, the 3XX response was directly passed to the code processing regular responses.
To keep compatibility with existing tests, a didFailRedirectCheck callback is called.
This should be change to a preflight failure.

Covered by existing tests.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
loader/CrossOriginPreflightChecker.cpp: Added.

(WebCore::CrossOriginPreflightChecker::CrossOriginPreflightChecker):
(WebCore::CrossOriginPreflightChecker::~CrossOriginPreflightChecker):
(WebCore::CrossOriginPreflightChecker::handleLoadingFailure):
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):
(WebCore::CrossOriginPreflightChecker::notifyFinished):
(WebCore::CrossOriginPreflightChecker::startPreflight):
(WebCore::CrossOriginPreflightChecker::doPreflight):
(WebCore::CrossOriginPreflightChecker::redirectReceived):
(WebCore::CrossOriginPreflightChecker::setDefersLoading):
(WebCore::CrossOriginPreflightChecker::isXMLHttpRequest):

loader/CrossOriginPreflightChecker.h: Added.
loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::create):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
(WebCore::DocumentThreadableLoader::setDefersLoading):
(WebCore::DocumentThreadableLoader::clearResource):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::notifyFinished):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::preflightFailure):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::responseReceived): Deleted.
(WebCore::DocumentThreadableLoader::dataReceived): Deleted.
(WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy): Deleted.

loader/DocumentThreadableLoader.h:

(WebCore::DocumentThreadableLoader::options):
(WebCore::DocumentThreadableLoader::isLoading):
(WebCore::DocumentThreadableLoader::document):

5:58 AM Changeset in webkit [201923] by Carlos Garcia Campos

7 edits in trunk/Source/WebKit2

[Threaded Compositor] Content and viewport sizes are mixed
https://bugs.webkit.org/show_bug.cgi?id=158564

Reviewed by Žan Doberšek.

Make ThreadedCoordinatedLayerTreeHost::sizeDidChange() update the viewport size for consistency with all other
LayerTreeHost implementations and rename viewportSizeChanged() as contentsSizeChanged() and update the contents
size.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged): Remove ifdefed code here, the drawing area is notified two lines below.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::mainFrameContentSizeChanged): Update the viewport size to the contents size
only when using a fixed layout here instead of in cross-platform code.

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::contentsSizeChanged):
(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange):
(WebKit::ThreadedCoordinatedLayerTreeHost::viewportSizeChanged): Deleted.

WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::mainFrameContentSizeChanged): Call LayerTreeHost::contentsSizeChanged().
(WebKit::DrawingAreaImpl::updateBackingStoreState): Remove ifdefed code for the threadecd compositor since it's
now consistent with all other LayerTreeHost implementations.

WebProcess/WebPage/LayerTreeHost.h:

5:52 AM Changeset in webkit [201922] by Carlos Garcia Campos

5 edits in trunk/Source/WebKit2

[Threaded Compositor] Make it clear that compositing thread operations are always scheduled from the main thread
https://bugs.webkit.org/show_bug.cgi?id=158562

Reviewed by Žan Doberšek.

The code is written as if the compositor thread could also call callOnCompositingRunLoop() which makes the code
confusing. This patch no longer checks if the task was scheduled in the compositing thread, and instead it adds
an ASSERT to ensure it's always called from the main thread as expected. It also adds some more ASSERTS to ensure
and clarify the methods are called from the expected thread.

Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::performTask):
(WebKit::CompositingRunLoop::callOnCompositingRunLoop): Deleted.

Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing):
(WebKit::ThreadedCompositor::setDeviceScaleFactor):
(WebKit::ThreadedCompositor::didChangeViewportSize):
(WebKit::ThreadedCompositor::didChangeViewportAttribute):
(WebKit::ThreadedCompositor::didChangeContentsSize):
(WebKit::ThreadedCompositor::scrollTo):
(WebKit::ThreadedCompositor::scrollBy):
(WebKit::ThreadedCompositor::glContext):
(WebKit::ThreadedCompositor::didChangeVisibleRect):
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::callOnCompositingThread): Deleted.

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:

5:50 AM Changeset in webkit [201921] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Browser plugins crash under Wayland
https://bugs.webkit.org/show_bug.cgi?id=157605

Reviewed by Michael Catanzaro.

Fail the initialization of windowed plugins if we don't have a platform implementation.

WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp:

(WebKit::NetscapePlugin::platformPostInitialize):

2:15 AM Changeset in webkit [201920] by adam.bergkvist@ericsson.com

5 edits
2 adds in trunk

WebRTC: Imlement MediaEndpointPeerConnection::createAnswer()
https://bugs.webkit.org/show_bug.cgi?id=158566

Reviewed by Eric Carlson.

Source/WebCore:

Add the MediaEndpointPeerConnection implementation of RTCPeerConnection.createAnswer [1].
createAnswer() creates a 'reply' to an remote offer set with setRemoteDescription(),
completes the offer/answer dialog and brings the RTCPeerConnection back to the 'stable'
signaling state.

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-createanswer

Test: fast/mediastream/RTCPeerConnection-inspect-answer.html

Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::createOfferTask):
Align creation of RTCSessionDescription with createAnswerTask.
(WebCore::MediaEndpointPeerConnection::createAnswer):
(WebCore::MediaEndpointPeerConnection::createAnswerTask):
Add Implementation.

Modules/mediastream/MediaEndpointPeerConnection.h:

LayoutTests:

Add test for RTCPeerConnection.createAnswer.

fast/mediastream/RTCPeerConnection-inspect-answer-expected.txt: Added.
fast/mediastream/RTCPeerConnection-inspect-answer.html: Added.

Generate two answers, one with audio only and a second with audio and video, and inspect
the result.

platform/mac/TestExpectations:

Skip tests for mac that require building with WEB_RTC enabled.

12:41 AM Changeset in webkit [201919] by svillar@igalia.com

5 edits
2 adds in trunk

[css-grid] CRASH when getting the computed style of a grid with only absolutely positioned children
https://bugs.webkit.org/show_bug.cgi?id=158537

Reviewed by Darin Adler.

Source/WebCore:

Absolute positioning occurs after layout of the grid and its in-flow contents, and does not
contribute to the sizing of any grid tracks or affect the size/configuration of the grid in
any way. This means that we should treat as empty any grid whose only children are
absolutely positioned items.

Since r201510 empty grids are no longer internally represented by a 1x1 matrix. As we were
not considering grids-with-only-absolutely-positioned-children as empty, we were trying to
access some invalid position in the internal representation of the grid triggering an ASSERT
in debug builds and a crash in release.

Test: fast/css-grid-layout/grid-only-abspos-item-computed-style-crash.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackList):

LayoutTests:

fast/css-grid-layout/grid-only-abspos-item-computed-style-crash-expected.txt: Added.
fast/css-grid-layout/grid-only-abspos-item-computed-style-crash.html: Added.
fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt: Adjusted, grid-template

does create explicit tracks so we should return 0px instead of none.

fast/css-grid-layout/grid-template-shorthand-get-set.html: Ditto.

12:37 AM Changeset in webkit [201918] by Chris Dumez

4 edits in trunk

DOMException should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=158608

Reviewed by Alex Christensen.

Source/WebCore:

DOMException should be exposed to workers:
https://heycam.github.io/webidl/#es-DOMException-call

Both Firefox and Chrome expose DOMException to workers already.

No new tests, rebaselined existing test.

dom/DOMCoreException.idl:

LayoutTests:

Rebaseline existing test.

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

Jun 9, 2016:

11:50 PM Changeset in webkit [201917] by achristensen@apple.com

1 edit
2 deletes in trunk/WebKitLibraries

Clean up Visual Studio properties files after switching to CMake.

win/tools/WinTools.make: Removed.
win/tools/vsprops: Removed.
win/tools/vsprops/FeatureDefines.props: Removed.
win/tools/vsprops/FeatureDefinesCairo.props: Removed.
win/tools/vsprops/GStreamer32.props: Removed.
win/tools/vsprops/GStreamer64.props: Removed.
win/tools/vsprops/GStreamerCommon.props: Removed.
win/tools/vsprops/WinCairo.props: Removed.
win/tools/vsprops/cURL.props: Removed.
win/tools/vsprops/common.props: Removed.
win/tools/vsprops/debug.props: Removed.
win/tools/vsprops/debug_wincairo.props: Removed.
win/tools/vsprops/debugsuffix.props: Removed.
win/tools/vsprops/production.props: Removed.
win/tools/vsprops/release.props: Removed.

11:48 PM Changeset in webkit [201916] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix CMake build.

PlatformMac.cmake:

11:36 PM Changeset in webkit [201915] by achristensen@apple.com

3 edits in trunk/Source/WebCore

Fix AppleWin build after r201901.
https://bugs.webkit.org/show_bug.cgi?id=119839

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::backingStoreAttached):
(PlatformCALayerWin::userInteractionEnabled):
(PlatformCALayerWin::setUserInteractionEnabled):
(PlatformCALayerWin::geometryFlipped):

platform/graphics/ca/win/PlatformCALayerWin.h:

11:11 PM Changeset in webkit [201914] by achristensen@apple.com

3 edits
9 copies
5 deletes in trunk/Tools

Clean up Tools *.vcxproj after switching to CMake.

DumpRenderTree/DumpRenderTree.sln: Removed.
DumpRenderTree/DumpRenderTree.vcxproj: Removed.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
DumpRenderTree/PlatformWin.cmake:
DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
MiniBrowser/MiniBrowser.vcxproj: Removed.
MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
MiniBrowser/win/CMakeLists.txt:
MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
WebKitTestRunner/WebKitTestRunner.sln: Removed.
win/DLLLauncher/DLLLauncherWinCairo.props: Removed.

11:06 PM Changeset in webkit [201913] by Chris Fleizach

8 edits
1 add in trunk

AX: VoiceOver Unable to View Download Progress or Completion Status for Mail Attachments
https://bugs.webkit.org/show_bug.cgi?id=158581

Reviewed by Darin Adler.

Source/WebCore:

Update attachment element accessibility so that:

1) the action name comes first to match UI
2) on iOS, it has the updates frequently trait

Make sure this test now runs on iOS as well.

Modified tests: accessibility/attachment-element.html

accessibility/AccessibilityAttachment.cpp:

(WebCore::AccessibilityAttachment::accessibilityText):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):
(-[WebAccessibilityObjectWrapper accessibilityIsAttachmentElement]):
(-[WebAccessibilityObjectWrapper accessibilityIsComboBox]):

LayoutTests:

accessibility/attachment-element-expected.txt:
accessibility/attachment-element.html:
accessibility/ios-simulator/attributed-string-for-range-expected.txt:
platform/ios-simulator/TestExpectations:
platform/ios-simulator/accessibility/attachment-element-expected.txt: Added.

10:53 PM Changeset in webkit [201912] by achristensen@apple.com

2 edits
1 copy
4 deletes in trunk/Source/JavaScriptCore

Clean up JavaScriptCore.vcxproj directory after switching to CMake.

JavaScriptCore.vcxproj/LLInt: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntAssembly: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorDebug.props: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorProduction.props: Removed.
JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorRelease.props: Removed.
JavaScriptCore.vcxproj/jsc: Removed.
JavaScriptCore.vcxproj/jsc/DLLLauncherMain.cpp: Removed.
JavaScriptCore.vcxproj/jsc/DLLLauncherWinCairo.props: Removed.
JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Removed.
JavaScriptCore.vcxproj/jsc/jsc.vcxproj.filters: Removed.
JavaScriptCore.vcxproj/jsc/jscCommon.props: Removed.
JavaScriptCore.vcxproj/jsc/jscDebug.props: Removed.
JavaScriptCore.vcxproj/jsc/jscLauncher.vcxproj: Removed.
JavaScriptCore.vcxproj/jsc/jscLauncherPostBuild.cmd: Removed.
JavaScriptCore.vcxproj/jsc/jscLauncherPreBuild.cmd: Removed.
JavaScriptCore.vcxproj/jsc/jscLauncherPreLink.cmd: Removed.
JavaScriptCore.vcxproj/jsc/jscPostBuild.cmd: Removed.
JavaScriptCore.vcxproj/jsc/jscPreBuild.cmd: Removed.
JavaScriptCore.vcxproj/jsc/jscPreLink.cmd: Removed.
JavaScriptCore.vcxproj/jsc/jscProduction.props: Removed.
JavaScriptCore.vcxproj/jsc/jscRelease.props: Removed.
JavaScriptCore.vcxproj/testRegExp: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpDebug.props: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpLauncher.vcxproj: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpLauncherPostBuild.cmd: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpLauncherPreBuild.cmd: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpLauncherPreLink.cmd: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpPostBuild.cmd: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpPreBuild.cmd: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpPreLink.cmd: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpProduction.props: Removed.
JavaScriptCore.vcxproj/testRegExp/testRegExpRelease.props: Removed.
JavaScriptCore.vcxproj/testapi: Removed.
JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Removed.
JavaScriptCore.vcxproj/testapi/testapi.vcxproj.filters: Removed.
JavaScriptCore.vcxproj/testapi/testapiCommon.props: Removed.
JavaScriptCore.vcxproj/testapi/testapiCommonCFLite.props: Removed.
JavaScriptCore.vcxproj/testapi/testapiDebug.props: Removed.
JavaScriptCore.vcxproj/testapi/testapiDebugCFLite.props: Removed.
JavaScriptCore.vcxproj/testapi/testapiLauncher.vcxproj: Removed.
JavaScriptCore.vcxproj/testapi/testapiLauncherPostBuild.cmd: Removed.
JavaScriptCore.vcxproj/testapi/testapiLauncherPreBuild.cmd: Removed.
JavaScriptCore.vcxproj/testapi/testapiLauncherPreLink.cmd: Removed.
JavaScriptCore.vcxproj/testapi/testapiPostBuild.cmd: Removed.
JavaScriptCore.vcxproj/testapi/testapiPreBuild.cmd: Removed.
JavaScriptCore.vcxproj/testapi/testapiPreLink.cmd: Removed.
JavaScriptCore.vcxproj/testapi/testapiProduction.props: Removed.
JavaScriptCore.vcxproj/testapi/testapiRelease.props: Removed.
JavaScriptCore.vcxproj/testapi/testapiReleaseCFLite.props: Removed.
shell/DLLLauncherMain.cpp: Copied from JavaScriptCore.vcxproj/jsc/DLLLauncherMain.cpp.
shell/PlatformWin.cmake:

10:42 PM Changeset in webkit [201911] by achristensen@apple.com

1 edit
2 deletes in trunk/Source/WebCore

Clean up WebCore.vcxproj after switching to CMake.

WebCore.vcxproj/QTMovieWin: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinCairoDebug.props: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinCairoRelease.props: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinCommon.props: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinDebug.props: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinPostBuild.cmd: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinPreBuild.cmd: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinPreLink.cmd: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinProduction.props: Removed.
WebCore.vcxproj/QTMovieWin/QTMovieWinRelease.props: Removed.
WebCore.vcxproj/xcopy.excludes: Removed.

10:39 PM Changeset in webkit [201910] by achristensen@apple.com

1 edit
1 move in trunk/Source/WebKit/win

Fix Windows build.

WebKit.resources/resource.h: Removed.
resource.h: Copied from WebKit.resources/resource.h.

10:34 PM Changeset in webkit [201909] by achristensen@apple.com

2 edits in trunk/Source/WebKit/win

Actually fix Windows build after r201894
https://bugs.webkit.org/show_bug.cgi?id=158588

WebView.cpp:

(WebView::initWithFrame):

10:33 PM Changeset in webkit [201908] by achristensen@apple.com

3 edits
1 copy
3 deletes in trunk/Source/WebKit

Clean up WebKit.vcxproj directory after switching to CMake.

Source/WebKit:

PlatformWin.cmake:
WebKit.vcxproj/Interfaces: Removed.
WebKit.vcxproj/WebKit: Removed.
WebKit.vcxproj/WebKit/resource.h: Removed.
WebKit.vcxproj/WebKitGUID: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDCommon.props: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDDebug.props: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDDebugWinCairo.props: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDPostBuild.cmd: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDProduction.props: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDRelease.props: Removed.
WebKit.vcxproj/WebKitGUID/WebKitGUIDReleaseWinCairo.props: Removed.

Source/WebKit/win:

WebKit.resources/resource.h: Copied from WebKit.vcxproj/WebKit/resource.h.

10:27 PM Changeset in webkit [201907] by Alan Bujtas

4 edits
2 adds in trunk

Hairline borders do not show up on 3x displays.
https://bugs.webkit.org/show_bug.cgi?id=158604
<rdar://problem/26511679>

Reviewed by Simon Fraser.

On a 3x display, when we convert a 1/3px hairline border from float
to LayoutUnit and pixel floor the result, we end up with a 0px width border.
It's because float to LayoutUnit is lossy and since the current kFixedPointDenominator % 3 != 0,
flooring LayoutUnit(1/3px) ends up being 0px. (float: 1/3 -> LayoutUnit: (1/3 - 1/kFixedPointDenominator) -> floor: 0)
This patch eliminates the (unnecessary) float -> LayoutUnit - float conversion on border width.

Source/WebCore:

Test: fast/borders/hidpi-3x-input-hairline-border.html

rendering/BorderEdge.cpp:

(WebCore::BorderEdge::BorderEdge):

rendering/BorderEdge.h:

LayoutTests:

fast/borders/hidpi-3x-input-hairline-border-expected-mismatch.html: Added.
fast/borders/hidpi-3x-input-hairline-border.html: Added.

10:24 PM Changeset in webkit [201906] by Ryan Haddad

10 edits
2 deletes in trunk

Unreviewed, rolling out r201887.
https://bugs.webkit.org/show_bug.cgi?id=158610

This change caused LayoutTest crashes under GuardMalloc and
ASan (Requested by ryanhaddad on #webkit).

Reverted changeset:

"Deleting a CSSOM style rule invalidates any previously-added
FontFaces"
https://bugs.webkit.org/show_bug.cgi?id=158450
http://trac.webkit.org/changeset/201887

Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-09

10:17 PM Changeset in webkit [201905] by achristensen@apple.com

4 edits in trunk/Source/WebKit/win

Unreviewed build fix after r201894
https://bugs.webkit.org/show_bug.cgi?id=158588

WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::~WebEditorClient):
(WebEditorClient::isContinuousSpellCheckingEnabled):
(WebEditorClient::pageDestroyed): Deleted.

WebCoreSupport/WebEditorClient.h:
WebView.cpp:

(WebView::initWithFrame):

8:31 PM Changeset in webkit [201904] by Alan Bujtas

6 edits
2 adds in trunk

Add testing support for 3x device scale factor.
https://bugs.webkit.org/show_bug.cgi?id=158597

Reviewed by Simon Fraser.

Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-.

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(changeWindowScaleIfNeeded):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::updateWindowScaleForTest):

WebKitTestRunner/TestOptions.cpp:

(WTR::deviceScaleFactorForTest):
(WTR::TestOptions::TestOptions):
(WTR::isHiDPITestPath): Deleted.

WebKitTestRunner/TestOptions.h:

LayoutTests:

fast/hidpi/hidpi-3x-device-pixel-ratio-expected.txt: Added.
fast/hidpi/hidpi-3x-device-pixel-ratio.html: Added.

8:20 PM Changeset in webkit [201903] by Chris Dumez

2 edits in trunk/Source/WebCore

Address Darin's review comment on r201898.
https://bugs.webkit.org/show_bug.cgi?id=158576

Reviewed by Darin Adler.

page/Base64Utilities.h:

7:45 PM Changeset in webkit [201902] by rniwa@webkit.org

3 edits in trunk/LayoutTests

REGRESSION(r201823) editing/selection/selection-in-iframe-removed-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=158569

Commit the test fix that was supposed to be landed as a part of r201823,
and remove the flaky test expectation.

editing/selection/selection-in-iframe-removed-crash.html:
platform/mac/TestExpectations:

7:06 PM Changeset in webkit [201901] by commit-queue@webkit.org

16 edits
2 adds in trunk

[iOS] -webkit-overflow-scrolling: touch; ignores pointer-events: none;
https://bugs.webkit.org/show_bug.cgi?id=119839
<rdar://problem/9671514>

Patch by Antoine Quint <Antoine Quint> on 2016-06-09
Reviewed by Simon Fraser.

Source/WebCore:

Propagate a "userInteractionEnabled" flag from the Web process which is used to turn off
user interaction on a UIScrollView created for -webkit-overflow-scrolling: touch.

Test: fast/scrolling/ios/touch-scroll-pointer-events-none.html

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::userInteractionEnabled):
(WebCore::GraphicsLayer::setUserInteractionEnabled):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setUserInteractionEnabled):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateUserInteractionEnabled):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::userInteractionEnabled):
(PlatformCALayerCocoa::setUserInteractionEnabled):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):

Source/WebKit2:

Propagate a "userInteractionEnabled" flag from the Web process which is used to turn off
user interaction on a UIScrollView created for -webkit-overflow-scrolling: touch.

Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyProperties):

Shared/mac/RemoteLayerTreeTransaction.h:
Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::userInteractionEnabled):
(WebKit::PlatformCALayerRemote::setUserInteractionEnabled):

WebProcess/WebPage/mac/PlatformCALayerRemote.h:

LayoutTests:

fast/scrolling/ios/touch-scroll-pointer-events-none-expected.txt: Added.
fast/scrolling/ios/touch-scroll-pointer-events-none.html: Added.

7:03 PM Changeset in webkit [201900] by fpizlo@apple.com

4 edits
2 adds in trunk/Source/JavaScriptCore

Rare failure in stress/v8-deltablue-strict.js.ftl-eager
https://bugs.webkit.org/show_bug.cgi?id=158591

Reviewed by Saam Barati.

This is a simple and sensible fix to an amazing compiler bug that previously only
manifested rarely in the v8-deltablue-strict test. It required on average 1000 runs while
the system was under load for the bug to manifest. Fortunately, the bug is 100% repro with
concurrent JIT disabled in the new "constant-fold-multi-get-by-offset-to-get-by-offset-on-
prototype-and-sink-allocation.js" test.

The problem here is that we were allowing ourselves to be super sloppy with the meaning of
the two children of GetByOffset, and to a lesser extent, PutByOffset. The first two
children of these nodes have these meanings:

child1: the storage from which to load (or to which to store)
child2: the logical object base

Normally, child1 == child2, but child1 may point to a node that vends the storage pointer
in case we are using multiple indirections to get to the property. That's fairly common.

Where this gets nutty is that we don't validate the behavior of child1. Previously, the
DFG::Validate phase would accept code that had child1 point to one object and child2 point
to another object. That's bad because then, analyses will assume that we're loading from
one object while we are actually loading from another. One of the fixes is to make
Validate smarter about this, so that future problems with this get caught sooner.

The actual bug was in ConstantFoldingPhase. When we first wrote ConstantFoldingPhase's
logic for converting GetByIds and MultiGetByOffsets to GetByOffset, we assumed that this
was only for non-prototype loads. This was becuase the logic was originally written based
on a static GetByIdStatus analysis, which does not handle prototypes. So, as a shortcut,
we would convert the GetById (or MultiGetByOffset) to a GetByOffset by doing this
shuffling of children:

child1 got the storage pointer, which might be a new GetButterfly node that we created.
child2 got the old value of child1.

The bug was introduced when I later made it possible for a monomorphic prototype
MultiGetByOffset to be converted to a GetByOffset. Then this algorithm would mean that:

child1 got either a pointer to the prototype or a storage pointer derived from the

prototype.

child2 got the old value of child1, which was a pointer to the base object (i.e. not the

prototype).

This happens super rarely because most prototype loads that we can statically reason about
also happen to load constants, so we don't convert to GetByOffset at all. You need the
strange combination of a MultiGetByOffset (not GetById or GetByOffset) on some prototypes
and some static reasoning about the base so that we can convert it to a GetByOffset, but
not enough static reasoning that we can convert it to a constant.

Even if the bad thing happened, then this is not enough for it to cause symptons. If we
did nothing else - like none of the other optimizations succeeded - then this would
be OK because the backend will emit code based on child1, which is right. But disaster
strikes when the code otherwise looks sane enough for ObjectAllocationSinkingPhase to kick
in. This phase operates on child2, as any good phase should: child1 is only interesting
for knowing *how* to load, not *what* we are loading. The phase is right to ignore child1.

So the phase would assume that we are loading the prototype property ("f" in the new test
or "addToGraph" in deltablue) from the sunken base object allocation in the inlined
constructor. The base object has no such property, but the phase conservatively assumes
that it does indeed have such a property. That's just how the phase does things: it is
very abstract and general, so it assumes that the set of properties on an allocation is
the set of properties that accesses to the allocation speak of. Clearly, this GetByOffset
was speaking of the property as being on the allocation. When sinking completed, it would
convert the GetByOffset to the sunken (a.k.a. promoted) property. But nobody stored to
this property on the allocation, so we'd get the bottom value, which is 1927. Why 1927? I
don't remember anymore, but apparently I chose it. It helped here - when I started seeing
that value come up, it took a quick grep to realize that this was the object allocation
sinking phase's bottom value.

The real fix to the bug is to make Node::convertToGetByOffset() take an explicit new base
since its clients will use it to potentially create a load on a different object than the
base of the original operation, as in the relatively new
MultiGetByOffset(prototype)->GetByOffset optimization. As far as I know, the PutByOffset
code did not have the same bug because we don't have any optimizations that turn a PutById
or MultiPutByOffset into a PutByOffset on anything but the base object. But the logical
bug is definitely there: there's code in ConstantFoldingPhase that claims to be able to
convert any node to a PutByOffset on any base, but it actually silently reuses the
original node's child1 as the logical base (i.e. child2). This patch makes all of this
stuff explicit. You can't make this mistake anymore.

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToGetStack):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToMultiGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):

dfg/DFGValidate.cpp:
tests/stress/constant-fold-multi-get-by-offset-to-get-by-offset-on-prototype-and-sink-allocation.js: Added.

(ThingA):
(ThingB):
(foo):
(bar):

tests/stress/sink-to-impossible-multi-get-by-offset-on-prototypes.js: Added.

(ThingA):
(ThingB):
(ThingC):
(bar):
(foo):

6:54 PM Changeset in webkit [201899] by Chris Dumez

4 edits in trunk

WorkerNavigator property should exist on WorkerGlobalScope
https://bugs.webkit.org/show_bug.cgi?id=158574
<rdar://problem/26725108>

Reviewed by Darin Adler.

Source/WebCore:

WorkerNavigator property should exist on WorkerGlobalScope:
https://html.spec.whatwg.org/multipage/workers.html#the-workernavigator-object

Fixing this gets the number of failures on http://w3c-test.org/workers/interfaces.worker
from 34 to 23.

No new tests, rebaselined existing test.

page/WorkerNavigator.idl:

LayoutTests:

Rebaseline existing test now that WorkerNavigator is exposed to workers.

js/dom/global-constructors-attributes-dedicated-worker-expected.txt:

6:42 PM Changeset in webkit [201898] by Chris Dumez

12 edits
1 move
5 adds
1 delete in trunk

atob() / btoa() API should be exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=158576
<rdar://problem/26729340>

Reviewed by Sam Weinig.

Source/WebCore:

Expose atob() / btoa() API to workers as per:
https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope

This aligns our behavior with Firefox and Chrome as well.

Test: fast/workers/atob-btoa.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
PlatformMac.cmake:
WebCore.xcodeproj/project.pbxproj:
page/Base64Utilities.cpp: Added.

(WebCore::Base64Utilities::btoa):
(WebCore::Base64Utilities::atob):

page/Base64Utilities.h: Added.
page/DOMWindow.cpp:

(WebCore::DOMWindow::find): Deleted.
(WebCore::DOMWindow::offscreenBuffering): Deleted.
(WebCore::DOMWindow::outerHeight): Deleted.
(WebCore::DOMWindow::outerWidth): Deleted.

page/DOMWindow.h:
page/DOMWindow.idl:
page/WindowBase64.idl: Removed.
page/WindowOrWorkerGlobalScope.idl: Renamed from Source/WebCore/page/WindowTimers.idl.
workers/WorkerGlobalScope.h:
workers/WorkerGlobalScope.idl:

LayoutTests:

Add test for atob() / btoa() in workers.

fast/workers/atob-btoa-expected.txt: Added.
fast/workers/atob-btoa.html: Added.
fast/workers/resources/worker-atob-btoa.js: Added.

6:11 PM Changeset in webkit [201897] by andersca@apple.com

3 edits
2 deletes in trunk/Source/WebKit2

Remove OriginAndDatabases.cpp, it's unused
https://bugs.webkit.org/show_bug.cgi?id=158595

Reviewed by Sam Weinig.

CMakeLists.txt:
Shared/OriginAndDatabases.cpp: Removed.

(WebKit::OriginAndDatabases::encode): Deleted.
(WebKit::OriginAndDatabases::decode): Deleted.

Shared/OriginAndDatabases.h: Removed.
WebKit2.xcodeproj/project.pbxproj:

5:42 PM Changeset in webkit [201896] by mark.lam@apple.com

8 edits in trunk/Source/JavaScriptCore

Make some methods const.
https://bugs.webkit.org/show_bug.cgi?id=158594

Reviewed by Benjamin Poulain.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::columnNumberForBytecodeOffset):
(JSC::CodeBlock::expressionRangeForBytecodeOffset):

bytecode/CodeBlock.h:
bytecode/ExpressionRangeInfo.h:

(JSC::ExpressionRangeInfo::encodeFatColumnMode):
(JSC::ExpressionRangeInfo::decodeFatLineMode):
(JSC::ExpressionRangeInfo::decodeFatColumnMode):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::lineNumberForBytecodeOffset):
(JSC::UnlinkedCodeBlock::getLineAndColumn):
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):

interpreter/Interpreter.cpp:

(JSC::Interpreter::isOpcode):
(JSC::StackFrame::computeLineAndColumn):
(JSC::StackFrame::toString):

interpreter/Interpreter.h:

(JSC::StackFrame::isNative):

5:21 PM Changeset in webkit [201895] by Brent Fulgham

3 edits in trunk/Source/WebCore

Restrict HTTP/0.9 responses to default ports and cancel HTTP/0.9 resource loads if the document was loaded with another HTTP protocol
https://bugs.webkit.org/show_bug.cgi?id=158589
<rdar://problem/25757454>

Patch by John Wilander <wilander@apple.com> on 2016-06-09
Reviewed by Brent Fulgham.

No new tests. Our layout test environment does not allow for headerless responses
nor does it allow you to set an explicit HTTP/0.9 status header in PHP. I have
manually tested this change with a Python socket setup doing both headerless and
HTTP/0.9 header tests for positive and negative cases.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Cancel loads if the request was made to a non-default port.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveResponse):

Cancel loads if the request was made to a non-default port or if the document
was loaded with another protocol. Cancelation is handled as a fail so as to
fire the onerror event and allow sites to handle it gracefully.

4:53 PM Changeset in webkit [201894] by achristensen@apple.com

19 edits in trunk/Source

Clean up EditorClient lifetime
https://bugs.webkit.org/show_bug.cgi?id=158588

Reviewed by Anders Carlsson.

Source/WebCore:

No new tests. This patch does two things, all of which do not change behavior:

Use a std::unique_ptr<EditorClient> owned by the Page instead of allocating

with new in WebKit/WebKit2 and deleting in WebEditorClient::pageDestroyed.

Give the Page a PageConfiguration&& instead of a PageConfiguration& in its constructor.

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

loader/EmptyClients.h:

(WebCore::EmptyEditorClient::EmptyEditorClient):
(WebCore::EmptyEditorClient::~EmptyEditorClient):

page/EditorClient.h:

(WebCore::EditorClient::~EditorClient):

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::setViewMode):
(WebCore::Page::clearUndoRedoOperations):
(WebCore::Page::inLowQualityImageInterpolationMode):
(WebCore::Page::invalidateStylesForAllLinks):
(WebCore::Page::invalidateStylesForLink):
(WebCore::Page::invalidateInjectedStyleSheetCacheInAllFrames):
(WebCore::Page::setDebugger):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setAllowsMediaDocumentInlinePlayback):

page/Page.h:

(WebCore::Page::canStartMedia):
(WebCore::Page::editorClient):
(WebCore::Page::plugInClient):
(WebCore::Page::mainFrame):
(WebCore::Page::group):

page/PageConfiguration.cpp:
page/PageConfiguration.h:
page/mac/PageMac.mm:

(WebCore::Page::addSchedulePair):
(WebCore::Page::removeSchedulePair):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit/mac:

WebCoreSupport/WebEditorClient.h:
WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::WebEditorClient):
(WebEditorClient::pageDestroyed): Deleted.

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit2:

WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::generateTextCheckingRequestID):
(WebKit::WebEditorClient::shouldDeleteRange):
(WebKit::WebEditorClient::pageDestroyed): Deleted.

WebProcess/WebCoreSupport/WebEditorClient.h:

(WebKit::WebEditorClient::WebEditorClient):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):

4:48 PM Changeset in webkit [201893] by commit-queue@webkit.org

5 edits in trunk/Source

REGRESSION: Web Inspector: IndexedDB does not show ObjectStore data
https://bugs.webkit.org/show_bug.cgi?id=158592
<rdar://problem/26730696>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-09
Reviewed by Timothy Hatcher.

Source/WebCore:

inspector/InspectorIndexedDBAgent.cpp:

(WebCore::DataLoader::execute):
Ensure the IDBTransaction is active when attempting to open a cursor.

(WebCore::OpenCursorCallback::handleEvent):
End, when the cursor result is empty, like we do for script results.

Source/WebInspectorUI:

UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._noteRowRemoved):
(WebInspector.DataGridNode.prototype._detach):
When rows are removed in the non-Virtual DataGrids, we should
actually remove the row.

UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:

(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData.processEntries):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._fetchMoreData):
Don't use the delete operator. Use a boolean.

4:30 PM Changeset in webkit [201892] by msaboff@apple.com

5 edits in trunk

ES6: Reusing function name as a parameter name shouldn't throw Syntax Error
https://bugs.webkit.org/show_bug.cgi?id=158575

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

The check for a parameter with a duplicate name doesn't take into account the
type of the prior variable. Added a check that the duplicate is also a
parameter.

See the relevant spec section at:
http://www.ecma-international.org/ecma-262/6.0/#sec-function-definitions-static-semantics-early-errors

parser/Parser.h:

(JSC::Scope::declareParameter):

LayoutTests:

Added a new test case.

js/basic-strict-mode-expected.txt:
js/script-tests/basic-strict-mode.js:

3:55 PM Changeset in webkit [201891] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Support Command-P for quick open
https://bugs.webkit.org/show_bug.cgi?id=158579
<rdar://problem/26726751>

Reviewed by Timothy Hatcher.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

3:49 PM Changeset in webkit [201890] by Nikita Vasilyev

4 edits in trunk/Source/WebInspectorUI

REGRESSION (r194717): Web Inspector: Elements tab: an element loses focus when selected by Up/Down key
https://bugs.webkit.org/show_bug.cgi?id=157768
<rdar://problem/26311155>

Reviewed by Timothy Hatcher.

Remove _previousFocusedSection and _newInspectorRuleSelector since it was used only
to focus on a newly created section (added by clicking on "+" button).

Introduce _inspectorSection and _isInspectorSectionPendingFocus.

UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.cssStyleDeclarationTextEditorBlurActiveEditor): Deleted.
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste): Deleted.
No longer needed, it was only used by _previousFocusedSection and _newInspectorRuleSelector.

UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.): Deleted.
No londer needed, it was only used by _previousFocusedSection.

UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.appendStyleSection):
(WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonClicked):
(WebInspector.RulesStyleDetailsPanel.prototype.nodeStylesRefreshed):
(WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionEditorFocused): Deleted.
(WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionBlurActiveEditor): Deleted.
(WebInspector.RulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionFocusNewInspectorRuleWithSelector): Deleted.

3:34 PM Changeset in webkit [201889] by commit-queue@webkit.org

6 edits
2 adds in trunk

Changing canvas height immediately after page load does not relayout canvas
https://bugs.webkit.org/show_bug.cgi?id=156097

Patch by Antoine Quint <Antoine Quint> on 2016-06-09
Reviewed by Zalan Bujtas.

Source/WebCore:

Promote the logic use to identify whether we should perform a layout after a change of
intrinsic size from RenderImage to RenderReplaced such that RenderCanvas may use it
in canvasSizeChanged() and correctly update its layout in the case where the width
or height attribute is updated and there are no explicit sizing performed with CSS.
Additionally, this will also account for the object-fix property to only perform
a layout if necessary.

Test: fast/canvas/canvas-css-size-after-height-change-with-display-flex.html

rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasSizeChanged):

rendering/RenderImage.cpp:

(WebCore::RenderImage::repaintOrMarkForLayout):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::setNeedsLayoutIfNeededAfterIntrinsicSizeChange):

rendering/RenderReplaced.h:

LayoutTests:

fast/canvas/canvas-css-size-after-height-change-with-display-flex-expected.html: Added.
fast/canvas/canvas-css-size-after-height-change-with-display-flex.html: Added.

3:05 PM Changeset in webkit [201888] by aestes@apple.com

16 edits
1 add in trunk/Source/WebKit2

WKWebView does not render PDF pages in AirPrint
https://bugs.webkit.org/show_bug.cgi?id=151386
rdar://problem/22499157

Reviewed by Tim Horton.

_WKWebViewPrintFormatter originally attempted to handle PDFs, but the code path was never
properly tested since Safari prints PDFs by setting a printingItem on the
UIPrintInteractionController instead of going through a print formatter. The existing code
almost worked, if it weren't for CGContextScaleCTM() scaling each page into oblivion due to
_totalScaleFactor equaling 0.

This patch properly implements -[_WKWebViewPrintFormatter drawInRect:forPageAtIndex:] to
handle drawing both PDFs generated by WebKit and PDFs loaded in the main frame. It also
takes the opportunity to clean up a number of issues in the existing code:

Handling of -[_WKWebViewPrintFormatter startPage] is now correct. I had previously assumed this property represented the first page of output to print, but it actually represents the first page in the overall print job that the print formatter renders. In other words, regardless of -startPage, the print formatter should always print all its pages.
Code specific to webpage and PDF printing was factored out into WKContentView and WKPDFView, respectively. Each conforms to @protocol(_WKWebViewPrintProvider), and _WKWebViewPrintFormatter accesses the provider via -[WKWebView _printProvider].
Instead of piping the printed PDF data from WebPageProxy to WKWebView via PageClient, use the GenericCallback mechanism to have WebPageProxy call a lambda specified by WKContentView when the printed PDF is available.
Removed _totalScaleFactor and used CGPDFPageGetDrawingTransform() to transform both webpages and PDFs. For webpages, _totalScaleFactor will always equal the ratio of the paper width to the PDF page width, so CGPDFPageGetDrawingTransform() will apply the same scaling as CGContextScaleCTM(_totalScaleFactor, _totalScaleFactor) would.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _printProvider]): Added. Returns _currentContentView if it conforms to
@protocol(_WKWebViewPrintProvider).
(-[WKWebView _computePageCountAndStartDrawingToPDFForFrame:printInfo:firstPage:computedTotalScaleFactor:]):
Moved code to _wk_pageCountForPrintFormatter in WKContentView and WKPDFView.
(-[WKWebView _endPrinting]): Deleted.
(-[WKWebView _printedDocument]): Deleted.
(-[WKWebView _setPrintedDocument:]): Deleted.

UIProcess/API/Cocoa/WKWebViewInternal.h: Declared the _printProvider property.
UIProcess/PageClient.h: Removed didFinishDrawingPagesToPDF().
UIProcess/WebPageProxy.h: Declared computePagesForPrintingAndDrawToPDF() and

drawToPDFCallback().

UIProcess/WebPageProxy.messages.in: Renamed DidFinishDrawingPagesToPDF to

DrawToPDFCallback.

UIProcess/_WKWebViewPrintFormatter.mm: Backed the frameToPrint property with a RetainPtr

ivar so that it doesn't need to be released manually in -dealloc; removed _totalScaleFactor
and _printInfo ivars and added a _printedDocument ivar; removed the property declaration for
webView.
(-[_WKWebViewPrintFormatter frameToPrint]): Added a custom getter for the frameToPrint
property.
(-[_WKWebViewPrintFormatter setFrameToPrint:]): Added a custom setter for the frameToPrint
property.
(-[_WKWebViewPrintFormatter _webView]): Renamed from webView; added an underscore since this
is a private method.
(-[_WKWebViewPrintFormatter _recalcPageCount]): Retrieved the page count from the print
provider and clamped its value to NSIntegerMax.
(-[_WKWebViewPrintFormatter drawInRect:forPageAtIndex:]): Retrieved the printed document
from the print provider if needed; modified the CTM transformations to work for both
webpages and PDFs.
(-[_WKWebViewPrintFormatter dealloc]): Deleted.
(-[_WKWebViewPrintFormatter webView]): Renamed to _webView.
(-[_WKWebViewPrintFormatter rectForPageAtIndex:]): Deleted.

UIProcess/_WKWebViewPrintFormatterInternal.h: Added. Moved a UIPrintFormatter internal

method declaration to here and defined the _WKWebViewPrintProvider protocol.

UIProcess/ios/PageClientImplIOS.h: Removed didFinishDrawingPagesToPDF().
UIProcess/ios/PageClientImplIOS.mm: Ditto.

(WebKit::PageClientImpl::didFinishDrawingPagesToPDF): Deleted.

UIProcess/ios/WKContentView.mm: Conformed to @protocol(_WKWebViewPrintProvider).

(-[WKContentView _wk_pageCountForPrintFormatter:]): Moved the code to compute page count
from WKWebView to here.
(-[WKContentView _wk_printedDocument]): Moved the code to get the printed document from
WKWebView to here.

UIProcess/ios/WKPDFView.mm:

(-[WKPDFView _wk_pageCountForPrintFormatter:]): Moved the code to compute the page count
from WKWebView to here; added a call to CGPDFDocumentAllowsPrinting(), returning 0 if
printing is not allowed.
(-[WKPDFView _wk_printedDocument]): Moved the code to get the printed document from
WKWebView to here.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::computePagesForPrintingAndDrawToPDF): Registered the callback with
m_callbacks and sent Messages::WebPage::ComputePagesForPrintingAndDrawToPDF; returned the
synchronously-returned page count.
(WebKit::WebPageProxy::drawToPDFCallback): Added to perform the callback when drawing to PDF
is complete.
(WebKit::WebPageProxy::didFinishDrawingPagesToPDF): Deleted.

WebKit2.xcodeproj/project.pbxproj: Added _WKWebViewPrintFormatterInternal.h.
WebProcess/WebPage/WebPage.h: Renamed computePagesForPrintingAndStartDrawingToPDF() to

computePagesForPrintingAndDrawToPDF().

WebProcess/WebPage/WebPage.messages.in: Renamed

ComputePagesForPrintingAndStartDrawingToPDF to ComputePagesForPrintingAndDrawToPDF. Removed
the startPage parameter and added a callbackID.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::computePagesForPrintingAndDrawToPDF): Renamed from
computePagesForPrintingAndStartDrawingToPDF(). Added a call to endPrinting() after sending
Messages::WebPageProxy::DrawToPDFCallback.
(WebKit::WebPage::computePagesForPrintingAndStartDrawingToPDF): Renamed to
computePagesForPrintingAndDrawToPDF.

3:03 PM Changeset in webkit [201887] by mmaxfield@apple.com

10 edits
2 adds in trunk

Deleting a CSSOM style rule invalidates any previously-added FontFaces
https://bugs.webkit.org/show_bug.cgi?id=158450

Reviewed by Darin Adler.

Source/WebCore:

This patch has two pieces: updating the CSSOM when the FontFace changes, and
updating the FontFace when the CSSOM changes.

Updating the FontFace when the CSSOM changes: If the CSSOM changes in a trivial

a) CSSFontSelector::buildStarted() is run, which means "we're about to start

building up all the @font-face rules from scratch." We take this opportunity
to purge as many fonts as possible. This is valuable because, for example,
this function gets run when the page gets put into the page cache, so we
want to destroy as much as possible. Not everything can be purged, however -
only CSS-connected fonts which have never been inspected by script are
purgeable. We don't allow fonts inspected by script to be purged because
purging might result in a font appearing from JavaScript to transition from
a success -> failure state, which we don't allow.

b) Upon style recalc (possibly asynchronously) CSSFontSelector::addFontFaceRule()

is called for each @font-face rule. We actually detect that we're in the
middle of a style rebuild, and defer this step.

c) When we're done adding all the font face rules, we call

CSSFontSelector::buildCompleted(). This is where we compare the newly built-
up list of font faces with what existed previously (as remembered in
CSSFontSelector::buildStarted()) in order to detect font faces which were
deleted from the document. Fonts which were newly added to the document
are handled naturally.
Fonts which have a property modified on them are created as if they were new.
However, instead of simply adding the CSSFontFace, we search for the existing
CSSFontFace (by CSS connection pointer) and tell the existing FontFace to
adopt this new CSSFontFace. This means that the JavaScript object will just
pick up any newly-written values in the CSSOM. It also means that the
"status" attribute of the JavaScript object is reset, but this is expected
and allowed by the spec. (For example, if you change the "src" attribute of
an @font-face block via the CSSOM, all bets are off when you inspect the
FontFace JS object representing that block.)

Test: fast/text/font-face-set-cssom.html

css/CSSFontFace.cpp:

css/CSSFontFace.h:
css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::remove):
(WebCore::CSSFontFaceSet::containsCSSConnection):
(WebCore::CSSFontFaceSet::purge):

css/CSSFontFaceSet.h:
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::buildStarted):
(WebCore::CSSFontSelector::buildCompleted):
(WebCore::CSSFontSelector::addFontFaceRule):

css/CSSFontSelector.h:
css/FontFace.cpp:

css/FontFace.h:

LayoutTests:

fast/text/font-face-set-cssom-expected.txt: Added.
fast/text/font-face-set-cssom.html: Added.

2:41 PM Changeset in webkit [201886] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking webgl/webgl-backing-store-size-update.html as a flaky timeout on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=158585

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

2:38 PM Changeset in webkit [201885] by Ryan Haddad

2 edits in trunk/LayoutTests

Removing Mavericks-specific TestExpectations from mac-wk1 TestExpectations file.

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

2:34 PM Changeset in webkit [201884] by aestes@apple.com

5 edits in trunk/Source

Define printing{Minimum,Maximum}ShrinkFactor in only one place
https://bugs.webkit.org/show_bug.cgi?id=158580

Reviewed by Tim Horton.

Source/WebCore:

page/PrintContext.cpp: Removed printingMinimumShrinkFactor and printingMaximumShrinkFactor.

(WebCore::PrintContext::begin): Used minimumShrinkFactor() and maximumShrinkFactor() instead
of printingMinimumShrinkFactor and printingMaximumShrinkFactor.
(WebCore::PrintContext::computeAutomaticScaleFactor): Ditto.

page/PrintContext.h:

(WebCore::PrintContext::minimumShrinkFactor): Added to return the same value as
printingMinimumShrinkFactor.
(WebCore::PrintContext::maximumShrinkFactor): Added to return the same value as
printingMaximumShrinkFactor.

Source/WebKit/mac:

WebView/WebHTMLView.mm: Initialized _WebHTMLViewPrintingMinimumShrinkFactor and

_WebHTMLViewPrintingMaximumShrinkFactor with PrintContext::minimumShrinkFactor() and
PrintContext::maximumShrinkFactor() instead of with duplicated float literals.

2:30 PM Changeset in webkit [201883] by eric.carlson@apple.com

4 edits
2 adds in trunk

Don't show the caption menu if a video has only forced tracks
https://bugs.webkit.org/show_bug.cgi?id=158573
<rdar://problem/24632384>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/controls/forced-tracks-only.html

Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.updateCaptionButton): Don't show the button of there are no user-selectable

text or audio tracks.

page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Return an empty Vector if

there are no user-selectable tracks.

LayoutTests:

media/controls/forced-tracks-only-expected.txt: Added.
media/controls/forced-tracks-only.html: Added.

2:01 PM Changeset in webkit [201882] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

Pass through play state and toggle state to the WebPlaybackControlsManager
https://bugs.webkit.org/show_bug.cgi?id=158578
<rdar://problem/25045616>

Reviewed by Beth Dakin.

Pass through the isPlaying portion of setRate() and allow toggling when a model is present.

platform/mac/WebPlaybackControlsManager.h:
platform/mac/WebPlaybackControlsManager.mm:
platform/mac/WebPlaybackSessionInterfaceMac.mm:

(WebCore::WebPlaybackSessionInterfaceMac::setRate):
(WebCore::WebPlaybackSessionInterfaceMac::setPlayBackControlsManager):

1:54 PM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

1:50 PM Changeset in webkit [201881] by fred.wang@free.fr

4 edits in trunk/Source/WebCore

RenderMathOperator: Move calculation of preferred width into MathOperator
https://bugs.webkit.org/show_bug.cgi?id=157071

Reviewed by Brent Fulgham.

No new tests, behavior is not change.

rendering/mathml/MathOperator.cpp:

(WebCore::MathOperator::setOperator): Introduce a style parameter and call reset.
(WebCore::MathOperator::reset): New helper function to reset the operator.
For now we only set the width of the base glyph and the preferred max width.
(WebCore::MathOperator::calculateDisplayStyleLargeOperator): Calculate the m_maxPreferredWidth.
(WebCore::MathOperator::calculateStretchyData): Change the signature of the function and directly set m_maxPreferredWidth.

rendering/mathml/MathOperator.h: Add m_maxPreferredWidth member and update some declarations.

(WebCore::MathOperator::width): New helper function.
(WebCore::MathOperator::maxPreferredWidth): New helper function.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): This function performs wrong
operations that will be fixed in bug 152244 when we update the tests.
For now, let's just use maxPreferredWidth() for non-horizontal operators.
(WebCore::RenderMathMLOperator::updateStyle): Use the new signature of the functions.

1:10 PM Changeset in webkit [201880] by achristensen@apple.com

29 edits in trunk/Source

Clean up WebSocket code
https://bugs.webkit.org/show_bug.cgi?id=158551

Reviewed by Darin Adler.

Source/WebCore:

No new tests. There is no change in behavior.
There seems to be no reason why SocketStreamHandle should be an AuthenticationClient.

Modules/websockets/ThreadableWebSocketChannel.h:
Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::setSendRequestResult):
(WebCore::ThreadableWebSocketChannelClientWrapper::bufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::setBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):

Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Modules/websockets/WebSocket.cpp:

(WebCore::joinStrings):
(WebCore::saturateAdd):
(WebCore::WebSocket::send):
(WebCore::WebSocket::readyState):
(WebCore::WebSocket::bufferedAmount):
(WebCore::WebSocket::didReceiveBinaryData):
(WebCore::WebSocket::didReceiveMessageError):
(WebCore::WebSocket::didUpdateBufferedAmount):
(WebCore::WebSocket::didStartClosingHandshake):
(WebCore::WebSocket::didClose):

Modules/websockets/WebSocket.h:
Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::~WebSocketChannel):
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::bufferedAmount):
(WebCore::WebSocketChannel::resume):
(WebCore::WebSocketChannel::willOpenSocketStream):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):
(WebCore::WebSocketChannel::didUpdateBufferedAmount):
(WebCore::WebSocketChannel::didFailSocketStream):
(WebCore::WebSocketChannel::didStartLoading):
(WebCore::WebSocketChannel::appendToBuffer):
(WebCore::WebSocketChannel::processBuffer):
(WebCore::WebSocketChannel::resumeTimerFired):
(WebCore::WebSocketChannel::startClosingHandshake):
(WebCore::WebSocketChannel::didReceiveAuthenticationChallenge): Deleted.
(WebCore::WebSocketChannel::didCancelAuthenticationChallenge): Deleted.

Modules/websockets/WebSocketChannel.h:
Modules/websockets/WebSocketChannelClient.h:

(WebCore::WebSocketChannelClient::~WebSocketChannelClient):
(WebCore::WebSocketChannelClient::didConnect):
(WebCore::WebSocketChannelClient::didReceiveMessage):
(WebCore::WebSocketChannelClient::didReceiveBinaryData):
(WebCore::WebSocketChannelClient::didReceiveMessageError):
(WebCore::WebSocketChannelClient::didUpdateBufferedAmount):
(WebCore::WebSocketChannelClient::didStartClosingHandshake):
(WebCore::WebSocketChannelClient::didClose):
(WebCore::WebSocketChannelClient::WebSocketChannelClient):

Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::send):
(WebCore::WorkerThreadableWebSocketChannel::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::bufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveBinaryData):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didUpdateBufferedAmount):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::send):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::bufferedAmount):

Modules/websockets/WorkerThreadableWebSocketChannel.h:
platform/network/BlobData.cpp:

(WebCore::BlobData::appendData):
(WebCore::BlobData::appendFile):

platform/network/BlobData.h:

(WebCore::BlobDataItem::BlobDataItem):

platform/network/BlobRegistry.h:
platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::appendStorageItems):
(WebCore::BlobRegistryImpl::registerFileBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLOptionallyFileBacked):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):

platform/network/BlobRegistryImpl.h:
platform/network/SocketStreamHandleBase.cpp:

(WebCore::SocketStreamHandleBase::send):
(WebCore::SocketStreamHandleBase::disconnect):
(WebCore::SocketStreamHandleBase::sendPendingData):

platform/network/SocketStreamHandleBase.h:
platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::~SocketStreamHandleClient):
(WebCore::SocketStreamHandleClient::willOpenSocketStream):
(WebCore::SocketStreamHandleClient::didOpenSocketStream):
(WebCore::SocketStreamHandleClient::didCloseSocketStream):
(WebCore::SocketStreamHandleClient::didReceiveSocketStreamData):
(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount):
(WebCore::SocketStreamHandleClient::didFailSocketStream):
(WebCore::SocketStreamHandleClient::didReceiveAuthenticationChallenge): Deleted.
(WebCore::SocketStreamHandleClient::didCancelAuthenticationChallenge): Deleted.

platform/network/cf/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):
(WebCore::SocketStreamHandle::refAuthenticationClient): Deleted.
(WebCore::SocketStreamHandle::derefAuthenticationClient): Deleted.

platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::copyCFStreamDescription):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::port):
(WebCore::SocketStreamHandle::receivedCredential): Deleted.
(WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): Deleted.
(WebCore::SocketStreamHandle::receivedCancellation): Deleted.
(WebCore::SocketStreamHandle::receivedRequestToPerformDefaultHandling): Deleted.
(WebCore::SocketStreamHandle::receivedChallengeRejection): Deleted.

platform/network/curl/ResourceHandleCurl.cpp:
platform/network/curl/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::SocketData::SocketData):

platform/network/curl/SocketStreamHandleCurl.cpp:

(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::readData):
(WebCore::SocketStreamHandle::didReceiveData):
(WebCore::SocketStreamHandle::didOpenSocket):
(WebCore::SocketStreamHandle::createCopy):
(WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): Deleted.
(WebCore::SocketStreamHandle::receivedCredential): Deleted.
(WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): Deleted.
(WebCore::SocketStreamHandle::receivedCancellation): Deleted.
(WebCore::SocketStreamHandle::receivedRequestToPerformDefaultHandling): Deleted.
(WebCore::SocketStreamHandle::receivedChallengeRejection): Deleted.

platform/network/soup/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):

platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::getHandleFromId):
(WebCore::deactivateHandle):
(WebCore::activateHandle):
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandle::didReceiveAuthenticationChallenge): Deleted.
(WebCore::SocketStreamHandle::receivedCredential): Deleted.
(WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential): Deleted.
(WebCore::SocketStreamHandle::receivedCancellation): Deleted.
(WebCore::SocketStreamHandle::receivedRequestToPerformDefaultHandling): Deleted.
(WebCore::SocketStreamHandle::receivedChallengeRejection): Deleted.

Source/WebKit2:

WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerFileBlobURL):

WebProcess/FileAPI/BlobRegistryProxy.h:

1:09 PM Changeset in webkit [201879] by Michael Catanzaro

4 edits in trunk

Add comments to clarify feature enablement
https://bugs.webkit.org/show_bug.cgi?id=158567

Reviewed by Alex Christensen.

Source/cmake/WebKitFeatures.cmake:

Tools:

Scripts/webkitperl/FeatureList.pm:

12:24 PM Changeset in webkit [201878] by fpizlo@apple.com

4 edits in trunk

PerformanceTests:
Unreviewed, teach the perf bots not to run JSAir.

Skipped:

Tools:
Unreviewed, skip jsair tests while we figure out the debug timeouts.

Scripts/run-javascriptcore-tests:

(runJSCStressTests):

11:52 AM Changeset in webkit [201877] by commit-queue@webkit.org

5 edits in trunk

Unreviewed, rolling out r201815.
https://bugs.webkit.org/show_bug.cgi?id=158570

This broke the cmake build. (Requested by lforschler on
#webkit).

Reverted changeset:

"Teach cmake about libWebKitSystemInterfaceOSX10.12"
http://trac.webkit.org/changeset/201815

11:47 AM Changeset in webkit [201876] by Chris Dumez

5 edits
2 adds in trunk

WorkerGlobalScope attributes / operations should be on the prototype
https://bugs.webkit.org/show_bug.cgi?id=158568
<rdar://problem/26720079>

Reviewed by Geoffrey Garen.

Source/WebCore:

WorkerGlobalScope attributes / operations should be on the prototype
because WorkerGlobalScope is not marked as [Global] / [PrimaryGlobal]:

DedicatedWorkerGlobalScope is the interface that is marked as [Global]
and whose attributes / operations should be on the instance.

This brings the number of failures on http://w3c-test.org/workers/interfaces.worker
from 65 to 34. It also aligns our behavior with Firefox and Chrome.

Test: fast/workers/WorkerGlobalScope-properties-prototype.html

bindings/scripts/CodeGeneratorJS.pm:

(InterfaceRequiresAttributesOnInstance):
(OperationShouldBeOnInstance):

LayoutTests:

fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Added.
fast/workers/WorkerGlobalScope-properties-prototype.html: Added.

Add layout test coverage.

fast/workers/self-hasOwnProperty-expected.txt:
fast/workers/self-hasOwnProperty.html:

Update test I added a couple of days ago because it wrongly expected
the 'navigator' property to be on the instance. This check was failing
in other browsers (Firefox and Chrome).

11:33 AM Changeset in webkit [201875] by timothy_horton@apple.com

5 edits
2 adds in trunk

Writing-mode-dependent properties don't apply if their value is a variable
https://bugs.webkit.org/show_bug.cgi?id=158449
<rdar://problem/26662478>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/variables/direction-dependent-variable-properties.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseVariableDependentValue):

css/CSSParser.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::resolvedVariableValue):
CSSVariableDependentValue stores the unresolved (direction-dependent) property ID,
because the property that it resolves to cannot be determined until style resolution time.
Plumb the requisite direction and writing mode information into parseVariableDependentValue
at style resolution time so that the property can be resolved to the correct
non-direction-dependent property for each use of the value.

LayoutTests:

fast/css/variables/direction-dependent-variable-properties-expected.html: Added.
fast/css/variables/direction-dependent-variable-properties.html: Added.

Add a test ensuring that direction-dependent properties work correctly,
including flipping when the direction is flipped.

11:27 AM Changeset in webkit [201874] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking editing/selection/selection-in-iframe-removed-crash.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=158569

Unreviewed test gardening.

platform/mac/TestExpectations:

10:42 AM Changeset in webkit [201873] by beidson@apple.com

2 edits in trunk/Source/WTF

Unaddressed review feedback from r201872

wtf/CrossThreadTask.h:

(WTF::callFunctionForCrossThreadTask): Fix typo.

10:34 AM Changeset in webkit [201872] by beidson@apple.com

4 edits in trunk

Greatly simplify CrossThreadTask.h.
https://bugs.webkit.org/show_bug.cgi?id=158542

Reviewed by Darin Adler.

Source/WTF:

wtf/CrossThreadTask.h:

(WTF::crossThreadCopy):
(WTF::callFunctionForCrossThreadTaskImpl):
(WTF::callFunctionForCrossThreadTask):
(WTF::createCrossThreadTask):
(WTF::callMemberFunctionForCrossThreadTaskImpl):
(WTF::callMemberFunctionForCrossThreadTask):

Tools:

TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:

(TestWebKitAPI::TEST):

10:31 AM Changeset in webkit [201871] by beidson@apple.com

3 edits in trunk/LayoutTests

LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=158501

Reviewed by Darin Adler.

The order in which the transaction abort happens doesn't matter; It only matters that it happens.

Update the test to reflect this.

storage/indexeddb/modern/handle-user-delete-expected.txt:
storage/indexeddb/modern/resources/handle-user-delete.js:

10:12 AM Changeset in webkit [201870] by Ryan Haddad

2 edits in trunk/Source/WebCore

Attempt to fix the iOS build.

Unreviewed build fix.

platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::ResourceError):

10:07 AM Changeset in webkit [201869] by ddkilzer@apple.com

2 edits in trunk/Source/WebKit2

Update properties for UIWKTextInteractionAssistant
<https://webkit.org/b/158559>

Reviewed by Darin Adler.

Platform/spi/ios/UIKitSPI.h:

(UIWKTextInteractionAssistant.loupeGesture):
(UIWKTextInteractionAssistant.singleTapGesture):
Change from retain to assign since UIWKTextInteractionAssistant
is not responsible for their lifetime. Sort alphabetically.

9:59 AM Changeset in webkit [201868] by Simon Fraser

4 edits
7 adds in trunk

border-radius with different width and height rendered wrong
https://bugs.webkit.org/show_bug.cgi?id=158300
<rdar://problem/26672922>

Reviewed by Zalan Bujtas.
Source/WebCore:

Borders with border-radius close to 100% 100% got oddly clipped. This happened because
of the clipping we do to achieve the diagonal corner joins; RenderBoxModelObject::clipBorderSidePolygon()
created trapezoids for each side, but only extended them to the center of the inner border rect.
This clipped out parts of these borders.

Fix by computing the trapezoids by intersecting the corner diagonal line with a line that passes
through the adjacent corners of the inner rect, whose intersection is always going to be inside the
rounded border. Also fix the quads used to do the antialiased/non-antialiased clipping,
by adding a point rather than moving a corner point to ensure we don't mistakenly clip out any
parts of the border.

Finally, improve the rendering of non-renderable cases by actually doing the diagonal
corner joins rather than just giving up.

Tests: fast/borders/border-non-renderable-radius-inner-clip.html

fast/borders/border-radius-inner-clip-vertical.html
fast/borders/border-radius-inner-clip.html

rendering/RenderBoxModelObject.cpp:

(WebCore::calculateAdjustedInnerBorder): Moved up.
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::clipBorderSidePolygon):
(WebCore::findInnerVertex): Deleted.
(WebCore::calculateSideRectIncludingInner): Deleted.
(WebCore::RenderBoxModelObject::clipBorderSideForComplexInnerPath): Deleted.

rendering/RenderBoxModelObject.h:

LayoutTests:

fast/borders/border-non-renderable-radius-inner-clip-expected.html: Added.
fast/borders/border-non-renderable-radius-inner-clip.html: Added.
fast/borders/border-radius-inner-clip-expected-mismatch.html: Added.
fast/borders/border-radius-inner-clip-vertical-expected-mismatch.html: Added.
fast/borders/border-radius-inner-clip-vertical.html: Added.
fast/borders/border-radius-inner-clip.html: Added.
fast/borders/resources/border-radius-helpers.js: Added.

(createContainer):
(createReferenceContainer):

9:49 AM Changeset in webkit [201867] by peavo@outlook.com

2 edits in trunk/LayoutTests

Unreviewed test gardening.

Unskip passing websocket tests.

platform/win/TestExpectations:

9:31 AM Changeset in webkit [201866] by Chris Dumez

5 edits in trunk

Unreviewed, rolling out r201836, r201845, and r201848.

Looks like a 1-2% PLT regression on iOS

Reverted changesets:

"[JSC] Change some parameters based on a random search"
https://bugs.webkit.org/show_bug.cgi?id=158514
http://trac.webkit.org/changeset/201836

"Tempory fix for the debug bots"
http://trac.webkit.org/changeset/201845

"Change thresholdForOptimizeSoon to match
thresholdForOptimizeAfterWarmUp"
http://trac.webkit.org/changeset/201848

8:56 AM Changeset in webkit [201865] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed, rolling out r201842.

The change that prompted this rebaseline was rolled out.

Reverted changeset:

"Rebaseline js/dom/global-constructors-attributes.html for Mac
after r201810"
http://trac.webkit.org/changeset/201842

8:15 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

8:14 AM Changeset in webkit [201864] by calvaris@igalia.com

2 edits in trunk/Source/WebCore

Unreviewed, fixing compilation issue with WebRTC

The code dependencies of the SDP processor were not right.

PlatformGTK.cmake:

8:04 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

7:54 AM Changeset in webkit [201863] by msaboff@apple.com

7 edits
2 adds in trunk

WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
https://bugs.webkit.org/show_bug.cgi?id=154863

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
surrogates called WKStringGetUTF8CStringNonStrict().

Shared/API/c/WKString.cpp:

(WKStringGetUTF8CStringImpl):
(WKStringGetUTF8CString):
(WKStringGetUTF8CStringNonStrict):

Shared/API/c/WKString.h:

Tools:

Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
surrogates. Changed the extraction of inner text from frames in DumpRenderTree
to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
conversion since NSString doesn't have a way to handle dangling surrogates.
The code added in DumpRenderTree matches what was changed in WebKitTestRunner.

DumpRenderTree/mac/DumpRenderTree.mm:

(dumpFramesAsText):

WebKitTestRunner/StringFunctions.h:

(WTR::toWTFString):

LayoutTests:

New tests.

fast/text/dangling-surrogates-expected.txt: Added.
fast/text/dangling-surrogates.html: Added.

7:50 AM Changeset in webkit [201862] by fred.wang@free.fr

4 edits in trunk/Source/WebCore

Introduce MathOperator::Type
https://bugs.webkit.org/show_bug.cgi?id=156950

Patch by Frederic Wang <fwang@igalia.com> on 2016-06-09
Reviewed by Sergio Villar Senin.

No new tests, behavior is not change.

An enum Type is introduced in MathOperator in order to indicate
which kind of stretching is requested. In follow-up work, this will
allow to just call setOperator and stretchTo without having to
explicitly call calculateDisplayStyleLargeOperator or calculateStretchyData.

rendering/mathml/MathOperator.cpp:

(WebCore::MathOperator::setOperator): Use Type instead of a boolean.
(WebCore::MathOperator::setGlyphAssembly): Add an assert to ensure that the function is correctly used.
(WebCore::MathOperator::calculateDisplayStyleLargeOperator): Ditto, this makes the assert more accurate.
(WebCore::MathOperator::calculateStretchyData): Ditto and replace m_isVertical with a local isVertical variable.
(WebCore::MathOperator::fillWithVerticalExtensionGlyph): Ditto.
(WebCore::MathOperator::fillWithHorizontalExtensionGlyph): Ditto.
(WebCore::MathOperator::paintVerticalGlyphAssembly): Ditto.
(WebCore::MathOperator::paintHorizontalGlyphAssembly): Ditto.

rendering/mathml/MathOperator.h: Add the Type enum.

(WebCore::MathOperator::stretchSize): Use Type instead of a boolean and add an
assert to ensure that the function is correctly used.

rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Call setOperator with the correct value.
(WebCore::RenderMathMLOperator::updateStyle): Ditto.

5:59 AM Changeset in webkit [201861] by commit-queue@webkit.org

28 edits
11 deletes in trunk

Unreviewed, rolling out r201810.
https://bugs.webkit.org/show_bug.cgi?id=158563

breaks build without ENABLE_WEB_ANIMATION (Requested by
mcatanzaro on #webkit).

Reverted changeset:

"[web-animations] Add Animatable, AnimationEffect,
KeyframeEffect and Animation interface"
https://bugs.webkit.org/show_bug.cgi?id=156096
http://trac.webkit.org/changeset/201810

5:09 AM Changeset in webkit [201860] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[Threaded Compositor] Many layout tests crash when threaded compositor is enabled
https://bugs.webkit.org/show_bug.cgi?id=158560

Reviewed by Žan Doberšek.

This is because CoordinatedGraphicsLayer::notifyFlushRequired() assumes it has a valid compositor when it's
called. But the compositor is only present when GraphicsLayer::create() is called with a
GraphicsLayerFactory. When running the layout tests, layers are created without a factory because DrawingAreaImpl
is not entering AC mode as expected and the layer tree host is not created, making
DrawingAreaImpl::graphicsLayerFactory() always return nullptr. This happens because DrawingAreaImpl is checking
acceleratedDrawingEnabled setting to decide whether to always use compositing mode or not, and WTR sets that
setting to false (changing its default value). The thing is that acceleratedDrawingEnabled setting doesn't have
any effect in non-Mac ports, what we really want to check there is whether acceleratedCompositingEnabled is true
or false.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updatePreferences):

5:07 AM Changeset in webkit [201859] by Carlos Garcia Campos

3 edits in trunk/Source/WebKit2

[Threaded Compositor] Remove ThreadedCompositor::setNeedsDisplay()
https://bugs.webkit.org/show_bug.cgi?id=158523

Reviewed by Michael Catanzaro.

ThreadedCompositor::setNeedsDisplay() is always called from the main thread and schedules a task to the
compositing thread to schedule an immediate update. But RunLoop::Timer is thread-safe so we don't really need to
schedule a task to the update the timer in the compositing thread, we can do that directly in the main
thread. And that's exactly what scheduleDisplayImmediately() does, so we can use it instead of setNeedsDisplay().

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::setNeedsDisplay(): Deleted.
(WebKit::ThreadedCompositor::updateSceneState):

Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:

2:09 AM Changeset in webkit [201858] by rniwa@webkit.org

10 edits in trunk

slotchange event should be fired at the end of microtask
https://bugs.webkit.org/show_bug.cgi?id=157374
<rdar://problem/26154024>

Reviewed by Antti Koivisto.

Source/WebCore:

Dispatch slotchange event at the end of every microtask after delivering records to mutation observers
as specified in: https://dom.spec.whatwg.org/#notify-mutation-observers

Test: fast/shadow-dom/slotchange-event.html

dom/Document.cpp:

(WebCore::Document::enqueueSlotchangeEvent): Deleted.

dom/Document.h:
dom/MutationObserver.cpp:

(WebCore::signalSlotList): Added.
(WebCore::MutationObserverMicrotask::run): mutationObserverCompoundMicrotaskQueuedFlag is now unset in
notifyMutationObservers to better match the concept to "notify mutation observers".
(WebCore::MutationObserver::enqueueSlotChangeEvent): Added.
(WebCore::MutationObserver::notifyMutationObservers): Renamed from deliverAllMutations. Added the code
to dispatch slotchange events as spec'ed, and also added comments for each step.

dom/MutationObserver.h:
html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::enqueueSlotChangeEvent): Use MutationObserver::enqueueSlotChangeEvent. Don't
create an event here since that is only needed when dispatching the event, and to keep track of whether
we've already scheduled an event or not. Use a boolean flag instead for the latter.
(WebCore::HTMLSlotElement::dispatchSlotChangeEvent): Added. Creates and dispatches an event.
(WebCore::HTMLSlotElement::dispatchEvent): Deleted.

html/HTMLSlotElement.h:

(WebCore::HTMLSlotElement::didRemoveFromSignalSlotList): Added.

LayoutTests:

Added a test case to ensure slotchange event is dispatched at the end of a microtask.

fast/shadow-dom/slotchange-event-expected.txt:
fast/shadow-dom/slotchange-event.html:

2:07 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

1:41 AM Changeset in webkit [201857] by Antti Koivisto

2 edits in trunk/Source/WebKit2

Increase disk cache capacity when there is lots of free space
https://bugs.webkit.org/show_bug.cgi?id=158526

Reviewed by Chris Dumez.

Our maximum disk cache capacity has been 175MB for a very long time. Meanwhile the average resource size has grown
massively. 175MB is now enough for cacheable resources of a few dozen sites at most. Using bigger caches when there is
room for it can reduce network traffic, reduce disk writes, save battery and speed up page loading.

This patch changes cache size for PrimaryWebBrowser cache model

=16GB free: 175MB -> 500MB

8-16GB free: 150MB -> 250MB

and modestly for DocumentBrowser

=16GB free: 50MB -> 75MB

Note that if system (on Cocoa platforms) really needs disk space it will wipe out caches so this doesn't reduce
available disk space in scenarios like software installation.

Context Navigation

Timeline

Jun 13, 2016:

Jun 12, 2016:

Jun 11, 2016:

Jun 10, 2016:

Jun 9, 2016:

Download in other formats: