Timeline
Jun 21, 2016:
- 10:52 PM Changeset in webkit [202325] by
-
- 2 edits in trunk/LayoutTests
Land test expectations for rdar://problem/26422051.
- platform/mac-wk1/TestExpectations:
- 10:52 PM Changeset in webkit [202324] by
-
- 4 edits4 adds in trunk
:hover CSS pseudo-class sometimes keeps matching ever after mouse has left the element
https://bugs.webkit.org/show_bug.cgi?id=158340
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-21
Reviewed by Simon Fraser.
Source/WebCore:
When removing a hovered subtree from the document, we were getting
into an inconsistent state where m_hoveredElement is in the detached
subtree and we have no way of clearing the existing IsHovered flags.
What happens is:
-The root "a" has an child "b" that is hovered.
-"a" starts being removed from the tree, its renderer is destroyed.
-RenderTreeUpdater::tearDownRenderers() pushes "a" on the teardownStack
and calls hoveredElementDidDetach().
-hoveredElementDidDetach() is called with "a". "a" is not the hovered
element, the function does nothing.
-RenderTreeUpdater::tearDownRenderers() pushes "b" on the teardownStack
and calls hoveredElementDidDetach().
-hoveredElementDidDetach() is called with "b". The next parent with a renderer
is "a", m_hoveredElement is set to "a".
-"a"'s parent is set to nullptr.
-> We have a m_hoveredElement on the root of a detached tree, making
it impossible to clear the real dirty tree.
This patch changes the order in which we clear the flags.
It is done in the order in which we clear the renderers to ensure
the last element with a dead renderer is the last to update m_hoveredElement.
Tests: fast/css/ancestor-of-hovered-element-detached.html
fast/css/ancestor-of-hovered-element-removed.html
- Source/WebCore/style/RenderTreeUpdater.cpp:
LayoutTests:
- fast/css/ancestor-of-hovered-element-detached-expected.txt: Added.
- fast/css/ancestor-of-hovered-element-detached.html: Added.
- fast/css/ancestor-of-hovered-element-removed-expected.txt: Added.
- fast/css/ancestor-of-hovered-element-removed.html: Added.
- 10:47 PM Changeset in webkit [202323] by
-
- 13 edits in trunk
[Fetch API] Rename 'origin-only' referrer policy to 'origin'
https://bugs.webkit.org/show_bug.cgi?id=158982
Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-21
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Renaming origin-only to origin.
- web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
- web-platform-tests/fetch/api/request/request-clone.sub.html:
- web-platform-tests/fetch/api/request/request-idl.html:
- web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-001.sub.html:
- web-platform-tests/fetch/api/request/request-init-003.sub.html:
Source/WebCore:
Covered by updated tests.
- Modules/fetch/FetchRequest.cpp:
(WebCore::setReferrerPolicy): Renaming origin-only to origin.
- Modules/fetch/FetchRequest.idl: Ditto.
- loader/FetchOptions.h: Ditto.
- 10:42 PM Changeset in webkit [202322] by
-
- 3 edits in trunk/LayoutTests
Test expectations gardening.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 10:00 PM Changeset in webkit [202321] by
-
- 2 edits in trunk/Source/WebCore
Let the compiler generate the move constructor and assignment operator for ScriptExecutionContext::Task
https://bugs.webkit.org/show_bug.cgi?id=159013
Reviewed by Brady Eidson.
Let the compiler generate the move constructor and assignment operator for
ScriptExecutionContext::Task. We previously manually defined the move
constructor but there is no need as it doesn't do anything special.
- dom/ScriptExecutionContext.h:
- 8:53 PM Changeset in webkit [202320] by
-
- 2 edits in trunk/Source/WebCore
DumpRenderTree crashed in com.apple.WebCore: WebCore::HTMLSelectElement::updateSelectedState
https://bugs.webkit.org/show_bug.cgi?id=159009
<rdar://problem/23454623>
Reviewed by Jon Lee.
It seems we can get bogus indices from UIKit's implementation
of UIWebSelectMultiplePicker. Guard against this situation.
Covered by running the existing tests in WebKit1 with Guard Malloc,
such as fast/spatial-navigation/snav-multiple-select-optgroup.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::updateSelectedState): Early return
if we get an index out of range.
- 8:34 PM Changeset in webkit [202319] by
-
- 57 edits in trunk/Tools
Fix formatting issues reported by check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=159008
Reviewed by Alexey Proskuryakov.
Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
There is no functionality change.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Restart.execute):
(Rollout):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_exception_during_command):
(IRCBotTest.test_exception_during_command.CommandWithException):
(IRCBotTest.test_exception_during_command.CommandWithException.execute):
- Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(test_missing_unit_test_results_path):
(test_layout_test_results):
- Scripts/webkitpy/tool/bot/queueengine.py:
- Scripts/webkitpy/tool/bot/queueengine_unittest.py:
- Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
(AbstractSequencedCommand):
(AbstractSequencedCommand.init):
- Scripts/webkitpy/tool/commands/download.py:
(Land):
- Scripts/webkitpy/tool/commands/openbugs.py:
- Scripts/webkitpy/tool/commands/openbugs_unittest.py:
(OpenBugsTest):
- Scripts/webkitpy/tool/commands/queries.py:
(PatchesToCommitQueue):
(PatchesToCommitQueue.init):
(PatchesToCommitQueue._needs_commit_queue):
- Scripts/webkitpy/tool/commands/queries_unittest.py:
(PrintExpectationsTest.test_platform):
(PrintBaselinesTest):
(PrintBaselinesTest.setUp):
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue):
(AbstractQueue.init):
(AbstractQueue.execute):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(test_auto_retry):
- Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._rebaseline):
- Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone):
- Scripts/webkitpy/tool/commands/sheriffbot.py:
- Scripts/webkitpy/tool/commands/stepsequence.py:
- Scripts/webkitpy/tool/commands/upload.py:
(PostCommits._comment_text_for_commit):
(PostCommits):
(PostCommits.execute):
(MarkBugFixed):
(MarkBugFixed.init):
- Scripts/webkitpy/tool/commands/upload_unittest.py:
(UploadCommandsTest):
(UploadCommandsTest.test_commit_message_for_current_diff):
- Scripts/webkitpy/tool/grammar_unittest.py:
(GrammarTest):
(GrammarTest.test_join_with_separators):
- Scripts/webkitpy/tool/multicommandtool.py:
(HelpCommand.init):
(HelpCommand):
(HelpCommand._help_epilog):
(HelpCommand._remove_help_options):
(MultiCommandTool):
(MultiCommandTool.init):
(MultiCommandTool.main):
- Scripts/webkitpy/tool/multicommandtool_unittest.py:
(TrivialCommand):
(TrivialCommand.init):
(MultiCommandToolTest):
(MultiCommandToolTest._assert_tool_main_outputs):
(MultiCommandToolTest.test_retry):
(test_command_help):
- Scripts/webkitpy/tool/steps/init.py:
- Scripts/webkitpy/tool/steps/abstractstep.py:
- Scripts/webkitpy/tool/steps/applypatch.py:
- Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
(ApplyPatchWithLocalCommit):
(ApplyPatchWithLocalCommit.options):
- Scripts/webkitpy/tool/steps/build.py:
- Scripts/webkitpy/tool/steps/checkstyle.py:
(CheckStyle):
(CheckStyle.options):
- Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
- Scripts/webkitpy/tool/steps/closebug.py:
- Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
- Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
(CloseBugForLandDiffTest):
(CloseBugForLandDiffTest.test_empty_state):
- Scripts/webkitpy/tool/steps/closepatch.py:
- Scripts/webkitpy/tool/steps/commit.py:
(Commit.run):
- Scripts/webkitpy/tool/steps/confirmdiff.py:
- Scripts/webkitpy/tool/steps/editchangelog.py:
- Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
- Scripts/webkitpy/tool/steps/metastep.py:
(MetaStep):
(MetaStep.init):
(MetaStep.run):
- Scripts/webkitpy/tool/steps/obsoletepatches.py:
- Scripts/webkitpy/tool/steps/options.py:
(Options):
- Scripts/webkitpy/tool/steps/postdiff.py:
- Scripts/webkitpy/tool/steps/postdiffforcommit.py:
- Scripts/webkitpy/tool/steps/postdiffforrevert.py:
- Scripts/webkitpy/tool/steps/preparechangelog.py:
- Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
(PrepareChangeLogTest):
(PrepareChangeLogTest.test_resolve_existing_entry):
- Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
- Scripts/webkitpy/tool/steps/promptforbugortitle.py:
- Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
- Scripts/webkitpy/tool/steps/revertrevision.py:
- Scripts/webkitpy/tool/steps/runtests.py:
- Scripts/webkitpy/tool/steps/runtests_unittest.py:
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(StepsTest):
(StepsTest._step_options):
- Scripts/webkitpy/tool/steps/update.py:
- Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
(UpdateChangeLogsWithReviewerTest):
(UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
- Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
- Scripts/webkitpy/tool/steps/validatereviewer.py:
- 8:26 PM Changeset in webkit [202318] by
-
- 3 edits in trunk/PerformanceTests
Update canvas size when benchmark begins
https://bugs.webkit.org/show_bug.cgi?id=159010
Reviewed by Dean Jackson.
Previously we would evaluate the media queries and assign the canvas size to the test
on body.onload. Instead, do it once the user starts the benchmark.
- Animometer/resources/debug-runner/animometer.js: Move benchmarkController.determineCanvasSize()
to benchmarkController._startBenchmark.
- Animometer/resources/runner/animometer.js: Ditto.
- 8:26 PM Changeset in webkit [202317] by
-
- 3 edits in trunk/PerformanceTests
Add new timestamp option
https://bugs.webkit.org/show_bug.cgi?id=159006
Reviewed by Dean Jackson.
Add a new option to take timestamps from the rAF callback.
- Animometer/developer.html: Added option.
- Animometer/tests/resources/main.js:
(Benchmark): Fall back to using the rAF timestamp if performance.now()
is not available.
(Benchmark._animateLoop): Update how timestamp is set. Prefer to use
local var instead of accessing private var.
- 8:16 PM Changeset in webkit [202316] by
-
- 5 edits1 delete in trunk
Unreviewed, rolling out r202296.
Broke basic browsing in Safari
Reverted changeset:
"WKWebView with no WKNavigationDelegate does not follow
universal links"
https://bugs.webkit.org/show_bug.cgi?id=158997
http://trac.webkit.org/changeset/202296
- 8:12 PM Changeset in webkit [202315] by
-
- 5 edits in trunk/PerformanceTests
Improvements to Animometer benchmark
https://bugs.webkit.org/show_bug.cgi?id=157738
Reviewed by Dean Jackson.
Provisionally reviewed by Said Abou-Hallawa.
Update tests.
- Animometer/tests/master/text.html: Ensure only three text sizes for
the three canvases.
- Animometer/tests/master/focus.html: Reduce the text size to fit with smaller
particle sizes.
- Animometer/tests/master/resources/focus.js: Remove the quadratic distribution for
particle sizes, and make it linear. Reduce the size variance. Shuffle the math to
reduce some calculations per frame. Fix the placement of the particles which might
otherwise be culled.
- Animometer/tests/master/resources/image-data.js: Reduce the particle size
to encourage larger scores.
- 8:11 PM Changeset in webkit [202314] by
-
- 16 edits in trunk/PerformanceTests
Improvements to Animometer benchmark
https://bugs.webkit.org/show_bug.cgi?id=157738
Reviewed by Dean Jackson.
Provisionally reviewed by Said Abou-Hallawa.
Include confidence interval for the final score, and store the canvas
size in the serialization so that it is accurately shown in results.
- Animometer/developer.html: Add a "confidence" div.
- Animometer/index.html: Ditto. Convert "mean" to "confidence".
- Animometer/resources/debug-runner/animometer.js: Look at options, and
if the configuration is included, update the body class based on it
(similar to what we do when we first load the page). That way, if you
drag-and-drop previous results in, that configuration is reflected in
the dashboard. Show the full confidence interval.
- Animometer/resources/debug-runner/animometer.css:
- Animometer/resources/debug-runner/animometer.js: Style update.
- Animometer/resources/runner/animometer.css:
- Animometer/resources/runner/animometer.js:
(_processData): Propagate the confidence interval values out and calculate
the lower and upper bounds. For now, shortcut the aggregate calculation,
since we only go through one iteration.
(this._processData.calculateScore): Propagate the confidence interval out
to be next to the score. Depending on the controller these values are
calculated differently.
(this._processData._getResultsProperty): Convenience function.
(this._processData.get score): Refactor.
(this._processData.get scoreLowerBound): Get the aggregate lower bound.
(this._processData.get scoreUpperBound): Get the aggregate upper bound.
(window.sectionsManager.setSectionScore):
(window.benchmarkController._startBenchmark): When the benchmark starts, note
the canvas size and add it to options. That way it will be automatically be
serialized.
(window.benchmarkController.showResults): Include the maximum deviation
percentage.
- Animometer/resources/runner/lines.svg: Make the background line up with the
skew.
- Animometer/resources/runner/tests.js:
(Headers.details.text): Refactor.
- Animometer/resources/statistics.js:
(Statistics.largestDeviationPercentage): Convenience function to calculate
the deviation percentage on either end and return the largest deviation.
- Animometer/resources/strings.js:
Allow specifying a regression profile to use instead of taking the one
with the lowest error.
Address an issue in the focus test when the regression calculated ends
up overestimating the change point, causing a cascade of tougher
ramps. The reason behind this is that at max complexity of an initial
ramp, the frame length is very high, and it influences the second
segment of the piecewise regression strongly, causing it to be very
steep. As a result, the first segment, expected to be flat, ends up
covering a higher range of complexity. That makes the change point
much higher than it should be. To avoid this, we will add a sanity
check on the maximum value of the ramp. If the regression's projected
value at the maximum complexity of the current ramp is very slow (less
than 20 fps), 1) reduce the maximum complexity by 20%, and 2) do not
include the regression's change point in the change point estimator.
That estimator is used as the midpoint of the next ramp, and including
the change point from a poor regression can bake in the error. The
controller already knows how to adjust for ramps that are too easy for
the system.
- Animometer/resources/runner/animometer.js:
(this._processData.findRegression): Takes a preferred profile and gives that to
Regression.
(this._processData.calculateScore): With the ramp controller, take the profile
of the ramp that was used the most when calculating the ramp's regression. That
profile is what is used for the test's score.
- Animometer/resources/statistics.js:
(Regression.Utilities.createClass): Update to take an options object which can
specify a profile to calculate with. Otherwise it will continue to use both and
select the one with the lower error.
(_calculateRegression): Fix an issue where we claim 0 error if the regression
calculation fails due to divide-by-zero. Instead reject that regression calculation
by giving it Number.MAX_VALUE.
- Animometer/resources/strings.js: New strings for marking a regression as flat
or slope.
- Animometer/tests/resources/main.js:
(RampController): Rename the thresholds for clarity. Add a threshold that, if
exceeded, will lower the maximum complexity of the next ramp.
(tune): Relax the cdf check to consider whether the interval definitely falls in
the desired frame length threshold.
(processSamples): Include the profile in the ramp.
Update ramp controller test. Increase the length of the test to 30 seconds, and extend
the interval to 120 ms during sampling. Improve the estimation of the ramp parameters.
- Animometer/developer.html: Change default to 30 seconds, and don't show the progress bar
by default.
- Animometer/resources/runner/animometer.js: Change default to 30 seconds.
- Animometer/tests/resources/main.js: A number of improvements to the ramp controller, in
the order in which they appear in the patch:
- With a longer test length use longer ramps with longer intervals to get more data at each
complexity. Keep the 100 ms interval length during the ramp up phase since we don't need to
spend more time there to find the right order of magnitude, but increase it during the
ramps to 120 ms.
- The ramp linearly interpolates the complexity to render based on its timestamp, but it would
never sample the minimum complexity. Instead of lerping max to min complexity from time
0 to t where t is the ramp length, instead lerp from 0 to (t - intervalSampleLength) so that
we can have at least one interval sample at the min complexity for that ramp.
- Some regression calculations only come out with one line segment rather than the two
we expect. This could be due to a noisy ramp or the ramp's range is too narrow. If that's the
case, influence the minimum complexity of the next ramp towards the lowest bound of 1, so that
we ensure that at least part of the ramp is covering a complexity range that the system can
handle at full 60.
- Remove an assignment to interpolatedFrameLength since that is never subsequently used.
Update the format used to serialize the results for analysis.
Each data point used to have named properties for fields like complexity and frame rate.
In addition the serialized numbers had rounding errors that took up many characters.
Update the format by introducing a new data container called SampleData, which contains a
field map. The map maps a string to an array index. Each data point is an array, so, to
get a stat, use the field map to get the array index into the data point. This allows future
versions to track other data, and reduces the size of the output string by two-thirds.
- Animometer/resources/extensions.js:
(Utilities.toFixedNumber): Add convenience function that truncates the number to a fixed
precision, and converts it back to a number.
(SampleData): New class that contains sample data and a field map that maps properties to
an array index.
(get length): Number of data points.
(addField): Add a field to the field map.
(push): Add a data point.
(sort): Sort the data.
(slice): Return new SampleData object with sliced data.
(forEach): Iterate over the data with provided function.
(createDatum):
(getFieldInDatum): Returns the data point associated with the field name by looking it up
in the field map in the datum provided, which can be the datum object itself (an array) or
an index into the data member variable.
(setFieldInDatum): Sets the data point associated with the field name.
(at): Returns the data point at the provided index.
(toArray): Serializes the data where the field map serves as property names for each point.
- Animometer/resources/debug-runner/graph.js:
(updateGraphData): Remove unused _testData. Convert the data to the old array format for the
graph to use, since the old format was much easier to work with when displaying the graphs.
(onGraphTypeChanged): For some controllers, no alternative score or mean is provided.
- Animometer/resources/runner/animometer.css:
- Animometer/resources/runner/animometer.js: Refactor to use SampleData. Update JSON output
to only go to 3 digits of precision for purposes of reducing the data size.
- Animometer/resources/strings.js: Add new strings to put into the field maps.
- Animometer/tests/resources/main.js: Refactor to use SampleData.
- Animometer/developer.html:
- Animometer/index.html: Restructure results table for both pages. Add charset attribute to
tests.js include.
- Animometer/resources/debug-runner/animometer.css: Clear out styles from release runner.
- Animometer/resources/debug-runner/graph.js:
(onGraphTypeChanged): Update score and mean if bootstrap results are available from the
controller, since not all controllers do bootstrapping.
- Animometer/resources/debug-runner/tests.js: Update header text.
- Animometer/resources/runner/animometer.css: Include confidence interval in results.
- Animometer/resources/runner/animometer.js:
(ResultsTable._addHeader): Header contents can be HTML, so use innerHTML instead.
(ResultsTable._addBody): Add tbody element.
(ResultsTable._addTest): Allow a data cell to invoke a JS function to get its contents.
(window.benchmarkController.showResults): Add table that includes tests' confidence intervals.
- Animometer/resources/runner/tests.js:
(Headers.details.text): Add new details table that includes bootstrap confidence interval.
The interval can be asymmetric, but for simplicity, report the maximum deviation percentage
on either side of the bootstrap median.
- Animometer/resources/statistics.js:
(bootstrap): Include the confidence percentage in the return object.
Report canvas size in results.
- Animometer/developer.html: Add markup to indicate whether a small, medium, or large
canvas was used.
- Animometer/index.html: Ditto.
- Animometer/resources/debug-runner/animometer.js: Call determineCanvasSize().
- Animometer/resources/runner/animometer.css: Update styles to set the canvas based on the
body class size.
- Animometer/resources/runner/animometer.js:
(window.benchmarkController.initialize): Update styles to set the canvas based on the
body class size.
(window.benchmarkController.determineCanvasSize): Run various media queries and set the body
class based on the size of the device.
- Animometer/developer.html: Refactor to include the main CSS file, and redo
the layout so that it doesn't rely on flexbox.
- Animometer/resources/debug-runner/animometer.css:
- Animometer/resources/debug-runner/animometer.js:
(updateDisplay): Since various parts of the script alter the body class, we can't
replace the className directly. Instead, remove all display-based values and then add
the one that was selected.
- Animometer/resources/debug-runner/graph.js:
(updateGraphData): To set the size of the graph, use window.innerHeight.
- Animometer/resources/runner/animometer.js:
(window.sectionsManager.showSection): Since various parts of the script alter the body
class, we can't replace the className directly. Remove all of the section classes
individually and then add the one desired.
- Animometer/tests/resources/stage.css: Remove -apple-system as a font to use in the
stage.
- 8:06 PM Changeset in webkit [202313] by
-
- 6 edits in trunk/Source/WebCore
Pass ScriptExecutionContext::Task as rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=159007
Reviewed by Anders Carlsson.
Pass ScriptExecutionContext::Task as rvalue reference since its non-copyable
and has to be moved in.
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):
- workers/WorkerMessagingProxy.h:
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::Task):
- workers/WorkerRunLoop.h:
- 7:52 PM Changeset in webkit [202312] by
-
- 2 edits in trunk/Source/WebCore
Include IdentifierInlines.h.
- bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp:
- 7:02 PM Changeset in webkit [202311] by
-
- 2 edits1 add in trunk/Source/WebCore
Add PaymentHeaders.h file.
- Modules/applepay/PaymentHeaders.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- 6:36 PM Changeset in webkit [202310] by
-
- 2 edits in trunk/Source/WebCore
Make a bunch of Apple Pay headers private instead of project.
- WebCore.xcodeproj/project.pbxproj:
- 6:05 PM Changeset in webkit [202309] by
-
- 6 edits1 copy31 adds in trunk/Source/WebCore
Move the last Apple Pay WebCore files to the open source repository
https://bugs.webkit.org/show_bug.cgi?id=159005
Reviewed by Tim Horton.
- DerivedSources.make:
- Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp: Added.
- Modules/applepay/ApplePayPaymentAuthorizedEvent.h: Added.
- Modules/applepay/ApplePayPaymentAuthorizedEvent.idl: Added.
- Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp: Added.
- Modules/applepay/ApplePayPaymentMethodSelectedEvent.h: Added.
- Modules/applepay/ApplePayPaymentMethodSelectedEvent.idl: Added.
- Modules/applepay/ApplePaySession.cpp: Added.
- Modules/applepay/ApplePaySession.h: Added.
- Modules/applepay/ApplePaySession.idl: Added.
- Modules/applepay/ApplePayShippingContactSelectedEvent.cpp: Added.
- Modules/applepay/ApplePayShippingContactSelectedEvent.h: Added.
- Modules/applepay/ApplePayShippingContactSelectedEvent.idl: Added.
- Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp: Added.
- Modules/applepay/ApplePayShippingMethodSelectedEvent.h: Added.
- Modules/applepay/ApplePayShippingMethodSelectedEvent.idl: Added.
- Modules/applepay/ApplePayValidateMerchantEvent.cpp: Added.
- Modules/applepay/ApplePayValidateMerchantEvent.h: Added.
- Modules/applepay/ApplePayValidateMerchantEvent.idl: Added.
- Modules/applepay/Payment.h: Added.
- Modules/applepay/PaymentAuthorizationStatus.h: Added.
- Modules/applepay/PaymentContact.h: Added.
- Modules/applepay/PaymentMerchantSession.h: Added.
- Modules/applepay/PaymentMethod.h: Added.
- Modules/applepay/PaymentRequestValidator.cpp: Added.
- Modules/applepay/PaymentRequestValidator.h: Added.
- Modules/applepay/cocoa/PaymentContactCocoa.mm: Added.
- Modules/applepay/cocoa/PaymentMethodCocoa.mm: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSApplePayPaymentAuthorizedEventCustom.cpp: Added.
- bindings/js/JSApplePayPaymentMethodSelectedEventCustom.cpp: Added.
- bindings/js/JSApplePaySessionCustom.cpp: Added.
- bindings/js/JSApplePayShippingContactSelectedEventCustom.cpp: Added.
- bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp: Added.
- dom/EventNames.in:
- dom/EventTargetFactory.in:
- 5:08 PM Changeset in webkit [202308] by
-
- 10 edits in trunk
Fix build.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 5:04 PM Changeset in webkit [202307] by
-
- 17 edits2 adds in trunk
Unreviewed, rolling out r202302, r202303, r202305, and
r202306.
Roll out the rollouts because of breaking the build.
Reverted changesets:
"Unreviewed, rolling out r200678."
https://bugs.webkit.org/show_bug.cgi?id=157453
http://trac.webkit.org/changeset/202302
"Unreviewed, rolling out r200619."
https://bugs.webkit.org/show_bug.cgi?id=131443
http://trac.webkit.org/changeset/202303
"Unreviewed, attempt to fix the build after r202303."
http://trac.webkit.org/changeset/202305
"Unreviewed, attempt to fix the build after r202303."
http://trac.webkit.org/changeset/202306
- 4:52 PM Changeset in webkit [202306] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, attempt to fix the build after r202303.
- bindings/js/JSDOMIterator.h:
(WebCore::IteratorInspector::decltype):
(WebCore::IteratorInspector::test):
- 4:47 PM Changeset in webkit [202305] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, attempt to fix the build after r202303.
- bindings/js/JSDOMIterator.h:
(WebCore::toJS):
- 4:32 PM Changeset in webkit [202304] by
-
- 3 edits in trunk/LayoutTests
LayoutTest tiled-drawing/scrolling/latched-div-with-scroll-snap.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=158320
Reviewed by Simon Fraser.
This test case is flaky because:
- There are multiple mouseScrollByWithWheelAndMomentumPhases() event bundles and they all need their own
callbacks. (see additional eventSender.callAfterScrollingCompletes()) -> fail
- When the test fails, the testFailed() function is called with undefined variables. -> timeout
- platform/mac-wk2/TestExpectations:
- tiled-drawing/scrolling/latched-div-with-scroll-snap.html:
- 4:24 PM Changeset in webkit [202303] by
-
- 17 edits2 deletes in trunk
Unreviewed, rolling out r200619.
This incompleted feature broke http://m.yahoo.co.jp. Roll it
out together with r200678.
Reverted changeset:
"NodeList should be iterable"
https://bugs.webkit.org/show_bug.cgi?id=131443
http://trac.webkit.org/changeset/200619
- 4:21 PM Changeset in webkit [202302] by
-
- 5 edits in trunk
Unreviewed, rolling out r200678.
This incompleted feature broke http://m.yahoo.co.jp. Roll it
out together with r200619.
Reverted changeset:
"Ensure DOM iterators remain done"
https://bugs.webkit.org/show_bug.cgi?id=157453
http://trac.webkit.org/changeset/200678
- 4:09 PM Changeset in webkit [202301] by
-
- 2 edits in trunk/LayoutTests
Skip HeapSnapshot test on WebKit1. Shared VM skews the data.
Unreviewed gardening.
In this case, snapshots with snapshots with snapshots in the same VM
causes the test to run out of memory. This does not happen in WebKit2.
- platform/mac-wk1/TestExpectations:
- 4:07 PM Changeset in webkit [202300] by
-
- 2 edits2 adds in trunk/LayoutTests
Test gardening for platform-specific font-fallback on macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=159003
<rdar://problem/25807529>
Unreviewed.
- fast/text/font-cursive-italic-cjk-2-expected.html: Added.
- fast/text/font-cursive-italic-cjk-2.html: Added.
- platform/mac/TestExpectations:
- 4:06 PM Changeset in webkit [202299] by
-
- 5 edits in trunk/Source/JavaScriptCore
Options::useImmortalObjects is not safe for conservative GC
https://bugs.webkit.org/show_bug.cgi?id=158999
Reviewed by Geoffrey Garen.
useImmortalObjects set the mark bit to keep an object from being
reallocated. This had the negative side-effect of convincing the
conservative marker that the object was a valid and live cell, which
would cause us to visit garbage.
- heap/Heap.cpp:
(JSC::Heap::didFinishCollection):
(JSC::Heap::resumeCompilerThreads):
(JSC::Heap::setFullActivityCallback):
(JSC::Heap::markDeadObjects): Deleted.
- heap/Heap.h: Don't set the mark bit on a dead object. That's a bug in
a conservative GC.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::retire): New helper.
(JSC::MarkedAllocator::reset): Automatically retire old blocks when
we're doing the immortal objects thing. This has the effect of
preserving memory for debugging because we never recycle a previously
allocated block.
- 3:46 PM Changeset in webkit [202298] by
-
- 13 edits8 adds in trunk
Begin moving the Apple Pay code to the open source repository
https://bugs.webkit.org/show_bug.cgi?id=158998
Reviewed by Tim Horton.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_APPLE_PAY.
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_APPLE_PAY.
- Modules/applepay/PaymentCoordinator.cpp: Added.
- Modules/applepay/PaymentCoordinator.h: Added.
- Modules/applepay/PaymentCoordinatorClient.h: Added.
- Modules/applepay/PaymentRequest.cpp: Added.
- Modules/applepay/PaymentRequest.h: Added.
- Modules/applepay/cocoa/PaymentCocoa.mm: Added.
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- dom/EventNames.h:
Add new event names.
- page/MainFrame.h:
Use a forward declaration.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_APPLE_PAY.
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_APPLE_PAY.
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
Add ENABLE_APPLE_PAY.
- 3:29 PM Changeset in webkit [202297] by
-
- 12 edits in trunk
Add system tracing points for requestAnimationFrame() workflow
https://bugs.webkit.org/show_bug.cgi?id=158723
Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-06-21
Reviewed by Simon Fraser.
Source/WebCore:
Add trace points for requestAnimationFrame().
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::requestAnimationFrameEnabled):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/ScriptedAnimationController.h:
- platform/graphics/ios/DisplayRefreshMonitorIOS.mm:
(WebCore::DisplayRefreshMonitorIOS::requestRefreshCallback):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
Source/WebKit2:
Add trace points for requestAnimationFrame().
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
- WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:
(WebKit::RemoteLayerTreeContext::buildTransaction):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::didUpdate):
(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):
Source/WTF:
Define new trace score codes for requestAnimationFrame().
- wtf/SystemTracing.h:
(WTF::TracePoint):
(WTF::TraceScope::TraceScope):
(WTF::TraceScope::~TraceScope):
Tools:
Add new plist entries to be used by kdebug_trace() viewing tools.
- Tracing/SystemTracePoints.plist:
- 3:26 PM Changeset in webkit [202296] by
-
- 5 edits1 add in trunk
WKWebView with no WKNavigationDelegate does not follow universal links
<rdar://problem/24374110>
https://bugs.webkit.org/show_bug.cgi?id=158997
Patch by Sam Weinig <sam@webkit.org> on 2016-06-21
Reviewed by Dan Bernstein.
Source/WebKit2:
API Test:
WKWebView.DefaultNavigationDelegate
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
When initializing the WKWebView, set a default navigation client.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setLoaderClient):
Be sure to clear out a navigation client, if present, when setting a loader client,
as they are mutually exclusive.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
Add a new test that shows that we have a default navigation delegate by swizzling
-[NSWorkspace openURL:]. This will only be called if there is a default client.
- 3:19 PM Changeset in webkit [202295] by
-
- 3 edits2 adds in trunk
[iOS] Typing text into a text field or text area causes screen to scroll down (hiding text entry)
https://bugs.webkit.org/show_bug.cgi?id=158970
Reviewed by Ryosuke Niwa.
Source/WebCore:
insertTextWithoutSendingTextEvent() should only reveal the selection up to the main frame on iOS,
since the UI process can zoom and scroll the view to the text input.
Test: fast/forms/ios/typing-in-input-in-iframe.html
- editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
LayoutTests:
Test that focuses an input in a frame and then types a character, then checks for scrolling.
- fast/forms/ios/typing-in-input-in-iframe-expected.txt: Added.
- fast/forms/ios/typing-in-input-in-iframe.html: Added.
- 2:11 PM Changeset in webkit [202294] by
-
- 2 edits in trunk/Source/WebInspectorUI
REGRESSION(r201177): Web Inspector: ContentBrowser navigation bar should fit on a single line
https://bugs.webkit.org/show_bug.cgi?id=158700
<rdar://problem/26772058>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ContentBrowser.css:
(.content-browser > .navigation-bar > .item):
Set the height to 28px, as it was before r201177.
Make it one pixel shorter than the navigation bar for better vertical alignment.
- 1:58 PM Changeset in webkit [202293] by
-
- 4 edits in trunk/Source/WebCore
WebRTC: Remove unused MediaEndpointClient::gotRemoteSource function
https://bugs.webkit.org/show_bug.cgi?id=158986
Reviewed by Eric Carlson.
Remote sources are explicitly created with MediaEndpoint::createMutedRemoteSource so the
MediaEndpointClient::gotRemoteSource can be removed.
No change in behavior.
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::gotRemoteSource): Deleted.
- Modules/mediastream/MediaEndpointPeerConnection.h:
- platform/mediastream/MediaEndpoint.h:
- 1:57 PM Changeset in webkit [202292] by
-
- 25 edits1 copy15 adds in trunk
Focus event dispatched in iframe causes parent document to scroll incorrectly
https://bugs.webkit.org/show_bug.cgi?id=158629
rdar://problem/26521616
Reviewed by Tim Horton.
Source/WebCore:
When focussing elements in iframes, the page could scroll to an incorrect location.
This happened because code in Element::focus() tried to disable scrolling on focus,
but did so only for the current frame, so ancestor frames got programmatically scrolled.
On iOS we handle the scrolling in the UI process, so never want the web process to
do programmatic scrolling.
Fix by changing the focus and cache restore code to use SelectionRevealMode::DoNotReveal,
rather than manually prohibiting frame scrolling. Pass SelectionRevealMode through various callers,
and use RevealUpToMainFrame for iOS, allowing the UI process to do the zoomToRect: for the main frame.
Tests: fast/forms/ios/focus-input-in-iframe.html
fast/forms/ios/programmatic-focus-input-in-iframe.html
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::scrollIntoViewIfNotVisible):
(WebCore::Element::focus):
(WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::findStringAndScrollToVisible):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::FrameSelection): Deleted.
- editing/FrameSelection.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateFocusAppearance):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::autoscroll):
- rendering/RenderLayer.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scrollRectToVisible):
- rendering/RenderObject.h:
Source/WebKit/mac:
Pass SelectionRevealMode::Reveal in existing code.
- WebView/WebFrame.mm:
(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _scrollDOMRangeToVisible:withInset:]):
(-[WebFrame revealSelectionAtExtent:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):
Source/WebKit2:
Pass SelectionRevealMode::Reveal in existing code.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::centerSelectionInVisibleArea):
LayoutTests:
- fast/forms/ios/focus-input-in-iframe-expected.txt: Added.
- fast/forms/ios/focus-input-in-iframe.html: Added.
- fast/forms/ios/programmatic-focus-input-in-iframe-expected.txt: Added.
- fast/forms/ios/programmatic-focus-input-in-iframe.html: Added.
- 1:53 PM Changeset in webkit [202291] by
-
- 3 edits in trunk/Source/WebKit2
[iOS][WK2] When an animation frame is missed, the UI process should immediately notify the Web process once a frame is committed
https://bugs.webkit.org/show_bug.cgi?id=158933
Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-06-21
Reviewed by Simon Fraser.
When a frame is committed, the UI process schedules a CADisplayLink and waits until
the next didRefreshDisplay event is fired. This causes more delay in the scenario
where there are frames are dropped. didRefreshDisplay() should be called immediately
when commitLayerTree message is received and the last frame was dropped.
The fix is to have the CADisplayLink active all the times. It should be paused
only when we detect at least one frame is dropped. In this case we should not
send a message to the UI process since it has not sent the last requested LayerTree.
Also we should not waste the CPU time by scheduling a new CADisplayLink since we
have not processed the last event. We should resume CADisplayLink timer once a
commitLayerTree message is received.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(-[WKOneShotDisplayLinkHandler pause]):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
(-[WKOneShotDisplayLinkHandler displayLinkFired:]):
- 1:47 PM Changeset in webkit [202290] by
-
- 2 edits in trunk/LayoutTests
Add an expectation for another copy of fast/canvas/webgl/premultiplyalpha-test.html
- platform/mac/TestExpectations:
- 1:18 PM Changeset in webkit [202289] by
-
- 2 edits in trunk/LayoutTests
Update Sierra test expectations for fast/canvas/webgl/premultiplyalpha-test.html
- platform/mac/TestExpectations:
- 1:14 PM Changeset in webkit [202288] by
-
- 2 edits in trunk/Source/JavaScriptCore
CodeBlock::shrinkToFit is racy
https://bugs.webkit.org/show_bug.cgi?id=158994
<rdar://problem/26920212>
Reviewed by Filip Pizlo.
To see why this is racy, consider the following scenario:
- CodeBlock A is link()ing its baseline compile.
- CodeBlock B is inlining A, and asks A for a result profile in DFGBytecodeParser.
- The race occurs when the link() step of the baseline compile calls shrinkToFit on its m_resultProfiles field without grabbing a lock. This leads to a bad time because the DFG compile will be reading from that vector as it's getting changed by the baseline link() method.
This race has always existed, though the move to a concurrent baseline
JIT has made it more likely to occur. The solution is to have CodeBlock::shrinkToFit
grab its lock before shrinking the vector.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
- 12:06 PM Changeset in webkit [202287] by
-
- 3 edits in trunk/Source/JavaScriptCore
Migrate testair & testb3 settings from Xcode project to ToolExecutable.xcconfig
<https://webkit.org/b/158989>
Reviewed by Andy Estes.
- Configurations/ToolExecutable.xcconfig:
(CODE_SIGN_ENTITLEMENTS_ios_testair): Add from Xcode project.
- JavaScriptCore.xcodeproj/project.pbxproj:
(CODE_SIGN_ENTITLEMENTS_ios_testair): Move to
ToolExecutable.xcconfig.
(PRODUCT_NAME): Remove. This variable is already set for both
testair and testb3 since those build configurations use
ToolExecutable.xcconfig as a base.
- 12:03 PM Changeset in webkit [202286] by
-
- 3 edits1 add in trunk/Source/JavaScriptCore
LLInt doesn't throw stack exception overflow from parent frame
https://bugs.webkit.org/show_bug.cgi?id=158962
<rdar://problem/26902188>
Reviewed by Filip Pizlo.
All JIT tiers will throw stack overflow exceptions from the parent frame.
The LLInt, on the other hand, did not use to. I've changed the LLInt to be
consistent with the JITs. The reason I found this bug is because we had a
test that would give different results depending on if the function was compiled
in the baseline or the LLInt. Since Filip recently landed the concurrent baseline
JIT patch, this otherwise deterministic test became dependent on it being compiled
in the LLInt or one of the JIT tiers. I've added a new test that is deterministic
because it runs the test with --useJIT=false.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- tests/stress/llint-stack-overflow-location.js: Added.
(stackTraceDescription):
(foo):
(catch):
- 11:54 AM Changeset in webkit [202285] by
-
- 3 edits in trunk/Source/JavaScriptCore
CODE_SIGN_ENTITLEMENTS should be applied to iOS Simulator builds
<https://webkit.org/b/158990>
<rdar://problem/26906273>
Reviewed by Dan Bernstein.
- Configurations/JSC.xcconfig:
(CODE_SIGN_ENTITLEMENTS): Change [sdk=iphoneos*] to
[sdk=iphone*] to apply setting to iOS Simulator as well.
- Configurations/ToolExecutable.xcconfig:
(CODE_SIGN_ENTITLEMENTS): Ditto.
- 11:36 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 11:34 AM Changeset in webkit [202284] by
-
- 19 edits in trunk
Implement RenderMathMLOperator::layoutBlock
https://bugs.webkit.org/show_bug.cgi?id=157521
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-21
Reviewed by Brent Fulgham.
Source/WebCore:
No new tests, already covered by existing tests.
Add an initial implementation of RenderMathMLOperator::layoutBlock, which will perform
special layout when the MathOperator is used. We also improved how the logical height is
calculated and avoid updating the style when stretchTo is called.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::layoutBlock):
(WebCore::RenderMathMLOperator::computeLogicalHeight): Deleted.
- rendering/mathml/RenderMathMLOperator.h:
LayoutTests:
Update some tests to take into account improved width computation and how the anonymous text
node of operators using MathOperator is layout.
- platform/gtk/mathml/opentype/horizontal-expected.txt:
- platform/gtk/mathml/opentype/horizontal-munderover-expected.txt:
- platform/gtk/mathml/opentype/large-operators-expected.txt:
- platform/gtk/mathml/opentype/opentype-stretchy-expected.txt:
- platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- platform/gtk/mathml/opentype/vertical-expected.png:
- platform/gtk/mathml/opentype/vertical-expected.txt:
- platform/gtk/mathml/presentation/mo-stretch-expected.png:
- platform/gtk/mathml/presentation/mo-stretch-expected.txt:
- platform/mac/mathml/opentype/large-operators-expected.txt:
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt:
- platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- platform/mac/mathml/opentype/vertical-expected.txt:
- platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt:
- platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt:
- 11:26 AM Changeset in webkit [202283] by
-
- 2 edits in trunk/Tools
run-javascriptcore-tests should have flag to skip mozilla tests
https://bugs.webkit.org/show_bug.cgi?id=158963
rdar://problem/25838924
Reviewed by Alexey Proskuryakov.
- Scripts/run-javascriptcore-tests:
(runJSCStressTests): Added flag to skip mozilla tests.
- 11:15 AM Changeset in webkit [202282] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r202277.
https://bugs.webkit.org/show_bug.cgi?id=158992
imported/w3c/web-platform-tests/tools actually does exist, so
documentation files got executed as tests (Requested by ap on
#webkit).
Reverted changeset:
"Unskip non-existing imported/w3c/web-platform-tests/tools."
http://trac.webkit.org/changeset/202277
- 10:57 AM Changeset in webkit [202281] by
-
- 24 edits in trunk/Source/WebCore
Unreviewed, roll out r202268 as it looks like it was a ~50% regression on Dromaeo DOM Core
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GeneratePrototypeDeclaration):
- bindings/scripts/test/JS/JSInterfaceName.cpp:
(WebCore::JSInterfaceNamePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectPrototype::finishCreation):
(WebCore::JSTestActiveDOMObject::createPrototype): Deleted.
(WebCore::JSTestActiveDOMObject::prototype): Deleted.
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::JSTestClassWithJSBuiltinConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterPrototype::finishCreation):
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter): Deleted.
(WebCore::JSTestCustomNamedGetter::createPrototype): Deleted.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorPrototype::finishCreation):
(WebCore::JSTestEventConstructor::createPrototype): Deleted.
(WebCore::JSTestEventConstructor::prototype): Deleted.
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetPrototype::finishCreation):
(WebCore::JSTestEventTarget::JSTestEventTarget): Deleted.
(WebCore::JSTestEventTarget::createPrototype): Deleted.
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfacePrototype::finishCreation):
(WebCore::jsTestInterfaceImplementsStr2): Deleted.
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor): Deleted.
(WebCore::JSTestJSBuiltinConstructor::createPrototype): Deleted.
(WebCore::JSTestJSBuiltinConstructor::destroy): Deleted.
(WebCore::jsTestJSBuiltinConstructorTestAttributeCustom): Deleted.
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerPrototype::finishCreation):
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): Deleted.
(WebCore::JSTestMediaQueryListListener::createPrototype): Deleted.
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation):
(WebCore::JSTestNode::JSTestNode): Deleted.
(WebCore::JSTestNode::prototype): Deleted.
(WebCore::jsTestNodeName): Deleted.
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicPrototype::finishCreation):
(WebCore::JSTestNondeterministic::JSTestNondeterministic): Deleted.
(WebCore::JSTestNondeterministic::prototype): Deleted.
(WebCore::JSTestNondeterministic::destroy): Deleted.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::JSTestObj::JSTestObj): Deleted.
(WebCore::JSTestObj::createPrototype): Deleted.
(WebCore::JSTestObj::prototype): Deleted.
(WebCore::JSTestObj::destroy): Deleted.
(WebCore::JSTestObj::getOwnPropertySlot): Deleted.
(WebCore::JSTestObj::getOwnPropertySlotByIndex): Deleted.
(WebCore::jsTestObjReadOnlyLongAttr): Deleted.
(WebCore::jsTestObjReadOnlyStringAttr): Deleted.
(WebCore::jsTestObjReadOnlyTestObjAttr): Deleted.
(WebCore::jsTestObjConstructorStaticReadOnlyLongAttr): Deleted.
(WebCore::jsTestObjConstructorStaticStringAttr): Deleted.
(WebCore::jsTestObjConstructorTestSubObj): Deleted.
(WebCore::jsTestObjTestSubObjEnabledBySettingConstructor): Deleted.
(WebCore::jsTestObjEnumAttr): Deleted.
(WebCore::jsTestObjByteAttr): Deleted.
(WebCore::jsTestObjOctetAttr): Deleted.
(WebCore::jsTestObjShortAttr): Deleted.
(WebCore::jsTestObjClampedShortAttr): Deleted.
(WebCore::jsTestObjEnforceRangeShortAttr): Deleted.
(WebCore::jsTestObjUnsignedShortAttr): Deleted.
(WebCore::jsTestObjLongAttr): Deleted.
(WebCore::jsTestObjLongLongAttr): Deleted.
(WebCore::jsTestObjReflectedCustomBooleanAttr): Deleted.
(WebCore::jsTestObjReflectedCustomURLAttr): Deleted.
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsPrototype::finishCreation):
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins): Deleted.
(WebCore::JSTestOverrideBuiltins::createPrototype): Deleted.
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::finishCreation):
(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface): Deleted.
(WebCore::JSTestSerializedScriptValueInterface::prototype): Deleted.
(WebCore::JSTestSerializedScriptValueInterface::destroy): Deleted.
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsPrototype::finishCreation):
(WebCore::JSTestTypedefs::JSTestTypedefs): Deleted.
(WebCore::JSTestTypedefs::createPrototype): Deleted.
(WebCore::JSTestTypedefs::prototype): Deleted.
(WebCore::JSTestTypedefs::destroy): Deleted.
(WebCore::jsTestTypedefsUnsignedLongLongAttr): Deleted.
(WebCore::jsTestTypedefsImmutableSerializedScriptValue): Deleted.
(WebCore::jsTestTypedefsAttrWithGetterException): Deleted.
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributePrototype::finishCreation):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyPrototype::finishCreation):
- 10:54 AM Changeset in webkit [202280] by
-
- 59 edits2 deletes in trunk/Source
It should be easy to add a private global helper function for builtins
https://bugs.webkit.org/show_bug.cgi?id=158893
Reviewed by Mark Lam.
Source/JavaScriptCore:
This patch does two things. First it moves all the builtin names
out of CommonIdentifiers and into BuiltinNames. This means that
adding a new function to the Builtins does not require rebuilding
all of JavaScriptCore. This patch also adds a new decorator to our
builtins @privateGlobal that will automatically put the function
on the global object. The name of the property will be the same as
the private name of the function.
This patch, also, removes the JSArrayIterator.h/.cpp files
as they no longer appear to be used in any real way. Finally,
the builtins tests have been rebaselined. It appears this has
not been done for a while so the expected files contain other
changes.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/builtins/builtins_generate_combined_header.py:
(BuiltinsCombinedHeaderGenerator.generate_output):
(generate_section_for_code_name_macro):
(generate_section_for_global_private_code_name_macro):
- Scripts/builtins/builtins_model.py:
(BuiltinFunction.init):
(BuiltinFunction.fromString):
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
- Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
- builtins/ArrayIteratorPrototype.js:
- builtins/ArrayPrototype.js:
- builtins/BuiltinNames.h:
- builtins/GeneratorPrototype.js:
- builtins/GlobalObject.js:
- builtins/PromiseOperations.js:
- builtins/RegExpPrototype.js:
- builtins/StringPrototype.js:
- bytecode/BytecodeIntrinsicRegistry.cpp:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::expectedFunctionForIdentifier):
(JSC::BytecodeGenerator::emitGetTemplateObject):
(JSC::BytecodeGenerator::emitLoadNewTargetFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadDerivedConstructorFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitPutNewTargetToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitGeneratorStateChange):
- bytecompiler/NodesCodegen.cpp:
(JSC::emitHomeObjectForCallee):
(JSC::emitPutHomeObject):
(JSC::FunctionNode::emitBytecode):
- dfg/DFGOperations.cpp:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties): Deleted.
- parser/Lexer.cpp:
(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::createGeneratorParameters):
(JSC::Parser<LexerType>::parseExportDeclaration):
- runtime/ArrayIteratorPrototype.cpp:
- runtime/ArrayIteratorPrototype.h:
- runtime/ArrayPrototype.cpp:
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers): Deleted.
- runtime/CommonIdentifiers.h:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/IntlDateTimeFormat.cpp:
- runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):
- runtime/IntlObjectInlines.h:
(JSC::constructIntlInstanceWithWorkaroundForLegacyIntlConstructor):
- runtime/JSArrayIterator.cpp: Removed.
(JSC::JSArrayIterator::finishCreation): Deleted.
(JSC::JSArrayIterator::kind): Deleted.
(JSC::JSArrayIterator::iteratedValue): Deleted.
- runtime/JSArrayIterator.h: Removed.
(JSC::JSArrayIterator::createStructure): Deleted.
(JSC::JSArrayIterator::create): Deleted.
(JSC::JSArrayIterator::JSArrayIterator): Deleted.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSInternalPromise.cpp:
- runtime/JSInternalPromiseDeferred.cpp:
(JSC::JSInternalPromiseDeferred::create):
- runtime/JSPromise.cpp:
(JSC::JSPromise::finishCreation):
(JSC::JSPromise::result):
- runtime/JSPromiseDeferred.cpp:
(JSC::JSPromiseDeferred::create):
- runtime/JSStringIterator.cpp:
(JSC::JSStringIterator::finishCreation):
(JSC::JSStringIterator::iteratedValue):
(JSC::JSStringIterator::clone):
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/ReflectObject.cpp:
(JSC::ReflectObject::finishCreation):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
- runtime/TypedArrayInlines.h:
Source/WebCore:
Add JSCJSValueInlines.h to fix build issues.
- platform/mock/mediasource/MockBox.cpp:
- 10:20 AM Changeset in webkit [202279] by
-
- 10 edits in trunk/Source
Upstream WKHTTPCookiesForURL from WebKitSystemInterface to OpenSource
https://bugs.webkit.org/show_bug.cgi?id=158967
Patch by Amir Alavi <aalavi@apple.com> on 2016-06-21
Reviewed by Brent Fulgham.
Source/WebCore:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/network/mac/CookieJarMac.mm:
(WebCore::httpCookiesForURL): Upstreamed from WebKitSystemInterface.
(WebCore::cookiesForURL): Changed to call httpCookiesForURL.
(WebCore::deleteCookie): Ditto.
- platform/spi/cf/CFNetworkSPI.h:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted.
- 10:05 AM Changeset in webkit [202278] by
-
- 9 edits in trunk/Source/WebCore
Unreviewed, rolling out r202231.
Seems to have regressed PLT on both iOS and Mac (very obvious
on iOS Warm PLT)
Reverted changeset:
"When navigating, discard decoded image data that is only live
due to page cache."
https://bugs.webkit.org/show_bug.cgi?id=158941
http://trac.webkit.org/changeset/202231
- 9:43 AM Changeset in webkit [202277] by
-
- 2 edits in trunk/LayoutTests
Unskip non-existing imported/w3c/web-platform-tests/tools.
Unreviewed fix after r191043.
- 9:21 AM Changeset in webkit [202276] by
-
- 2 edits in trunk/LayoutTests
Correct which test is marked as flaky, copy/paste mistake.
- platform/mac-wk2/TestExpectations:
- 8:44 AM Changeset in webkit [202275] by
-
- 15 edits in trunk/Source/WebCore
Add bindings generator support to add a native JS function to both a 'name' and a private '@name' slot
https://bugs.webkit.org/show_bug.cgi?id=158777
Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-21
Reviewed by Eric Carlson.
Adding a new PublicIdentifier keyword to cover the case of the same function exposed publicly and privately.
Renaming Private keyword to PrivateIdentifier.
Functions exposed both publicly and privately should set both keywords.
By default, functions are publically exposed.
Updated binding generator to generate public exposure except if PrivateIdentifer is set and PublicIdentifier is
not set.
Keeping skipping of ObjC/GObject binding for PrivateIdentifier-only functions.
Covered by rebased binding tests.
- Modules/fetch/FetchHeaders.idl:
- Modules/fetch/FetchResponse.idl:
- Modules/mediastream/MediaDevices.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction):
- bindings/scripts/CodeGeneratorJS.pm:
(GeneratePropertiesHashTable):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorObjC.pm:
(SkipFunction):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_private_also_method):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjPrototypeFunctionPrivateMethod):
(WebCore::jsTestObjPrototypeFunctionPrivateAlsoMethod):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj privateAlsoMethod:]):
- bindings/scripts/test/TestObj.idl:
- 8:44 AM WebKitGTK/2.12.x edited by
- Propose change requested by Konstantin (diff)
- 6:15 AM Changeset in webkit [202274] by
-
- 18 edits1 add in trunk/Source
Inlined some picture-in-picture code.
https://bugs.webkit.org/show_bug.cgi?id=158977
Reviewed by Eric Carlsson.
This code was written primarily by Ada Chan, and originally reviewed by Alex Christensen,
Anders Carlsson, Conrad Shultz, Dan Bernstein, Eric Carlson, Jer Noble, Jeremy Jones,
Jon Lee, Remy Demarest, and Zach Li.
Source/WebCore:
- English.lproj/Localizable.strings: Updated using update-webkit-localizable-strings.
- Modules/mediacontrols/mediaControlsApple.css:
(video:-webkit-full-screen::-webkit-media-controls-panel .picture-in-picture-button):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.configureFullScreenControls):
- WebCore.xcodeproj/project.pbxproj: Added PIPSPI.h.
- html/HTMLMediaElement.cpp: Inlined code from HTMLMediaElementAdditions.cpp.
- html/HTMLVideoElement.cpp: Inlined code from HTMLVideoElementSupportsFullscreenAdditions.cpp.
- platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagEnterVideoEnhancedFullscreen): Brought in from ContextMenuLocalizedStringsAdditions.cpp.
(WebCore::contextMenuItemTagExitVideoEnhancedFullscreen): Ditto.
(WebCore::AXARIAContentGroupText): Made updates that should have been part of r198543.
- platform/mac/WebVideoFullscreenInterfaceMac.h: Removed USE(APPLE_INTERNAL_SDK) guards.
- platform/mac/WebVideoFullscreenInterfaceMac.mm: Inlined WebVideoFullscreenInterfaceMacAdditions.mm.
- platform/spi/mac/PIPSPI.h: Added.
- rendering/HitTestResult.cpp: Inlined HitTestResultAdditions.cpp.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::mediaControlsStyleSheet): Removed include of
RenderThemeMacMediaControlsStyleSheetAdditions.mm now that the content is in
mediaControlsApple.css.
(WebCore::RenderThemeMac::mediaControlsScript): Removed include of
RenderThemeMacMediaControlsScriptAdditions.mm now that the content is in mediaControlsApple.js.
Source/WebKit2:
- Shared/WebPreferencesStoreDefaultsAdditions.cpp: Define and use DEFAULT_ALLOWS_PICTURE_IN_PICTURE_MEDIA_PLAYBACK.
- Shared/WebPreferencesStore.cpp:
(WebKit::defaults): Removed include of WebPreferencesStoreDefaultsAdditions.cpp now that the
default is defined correctly in WebPreferencesStoreDefaultsAdditions.cpp.
- UIProcess/API/C/WKPreferences.cpp: Inlined WKPreferencesAdditions.cpp.
- UIProcess/API/C/WKPreferencesRefPrivate.h: Ditto.
- WebProcess/cocoa/WebVideoFullscreenManager.mm: Inlined WebVideoFullscreenManagerSupportsVideoFullscreenMac.mm.
- 4:04 AM Changeset in webkit [202273] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] Web view is not redrawn when reparented in force compositing mode
https://bugs.webkit.org/show_bug.cgi?id=158689
Reviewed by Žan Doberšek.
When the web view is reparented in accelerated compositing mode, the UI process always exits the accelerated
mode when the view is unrealized, because the native surface handle for compositing is destroyed, but it doesn't
enter again when the view is realized and a new native surface handle for compositing is used. This happens
because the UI and Web processes are not in sync regarding whether the page is in accelerated compositing or
not. The Web process never exits accelerated mode when compositing mode is forced, but the UI process doesn't
check that setting at all.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseResizeRedirectedWindow): Helper function to ensure the redirected window size is properly updated.
(webkitWebViewBaseRealize): Resize the redirected window if the view is already in AC mode when realized.
(webkitWebViewRenderAcceleratedCompositingResults): Use webkitWebViewBaseResizeRedirectedWindow().
(webkitWebViewBaseSizeAllocate): Ditto.
(webkitWebViewBaseWillEnterAcceleratedCompositingMode): Ditto.
- UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::alwaysUseCompositing): Return true in force compositing mode.
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode): Update assert.
(WebKit::DrawingAreaProxyImpl::exitAcceleratedCompositingMode): Do not exit AC mode compositing mode is always enabled.
- UIProcess/DrawingAreaProxyImpl.h:
(WebKit::DrawingAreaProxyImpl::isInAcceleratedCompositingMode): Return true also in force compositing mode.
- UIProcess/gtk/RedirectedXCompositeWindow.cpp:
(WebKit::RedirectedXCompositeWindow::surface): Ensure we never return an uninitialized surface to prevent
rendering artifacts in in force compositing mode when waiting for the first update on the redirected window.
- 2:56 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 1:54 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 1:32 AM Changeset in webkit [202272] by
-
- 9 edits6 adds in trunk
[GStreamer] video orientation support
https://bugs.webkit.org/show_bug.cgi?id=148524
Patch by Miguel Gomez <magomez@igalia.com> on 2016-06-21
Reviewed by Philippe Normand.
Source/WebCore:
Rotate video frames to follow the orientation metadata in the video file.
When accelerated compositing is disabled, the rotation is performed by a videoflip element added
to the playbin.
When accelerated compositing is enabled, the rotation is peformed by the TextureMapper in response
to a rotation flag set on the frame buffers.
Test: media/video-orientation.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
Handle the GST_MESSAGE_TAG message from the bin.
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
Add the videflip element to the bin when accelerated compositing is disabled.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
Receive and use extra flags for the TextureMapper.
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
When using accelerated compositing, transpose the video size if the rotation is 90 or 270 degrees.
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
Add rotation flag to frame holder and layer buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
Use rotation flag when requesting the TextureMapper to draw.
(WebCore::MediaPlayerPrivateGStreamerBase::setVideoSourceRotation):
Function to store the video rotation.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Add bits to store the video rotation.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
Modify the patternTransform according to the rotation flag passed.
- platform/graphics/texmap/TextureMapperGL.h:
Add new flags to handle the video souce rotation.
- platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp:
(WebCore::TextureMapperPlatformLayerBuffer::paintToTextureMapper):
Change the drawTexture method used so custom flags can be passed.
- platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
(WebCore::TextureMapperPlatformLayerBuffer::setExtraFlags):
New method to set TextureMapper flags.
LayoutTests:
Test whether the video is properly being displayed by checking the video
element size.
- media/content/no-rotation.mp4: Added.
- media/content/rotation-180.mp4: Added.
- media/content/rotation-270.mp4: Added.
- media/content/rotation-90.mp4: Added.
- media/video-orientation-expected.txt: Added.
- media/video-orientation.html: Added.
- 12:11 AM MathML/Early_2016_Refactoring edited by
- (diff)
Jun 20, 2016:
- 11:28 PM Changeset in webkit [202271] by
-
- 12 edits in trunk
Use the MathOperator to handle some non-stretchy operators
https://bugs.webkit.org/show_bug.cgi?id=157519
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-20
Reviewed by Brent Fulgham.
Source/WebCore:
To prepare for the removal of anonymous text node from the render classes of token elements
we use MathOperator to handle two cases where the actual text to display may not be
available in the DOM: mfenced and minus operators. This change removes support for the
case of mfenced operators with multiple characters since that it is not supported by
MathOperator. It is a edge case that is not used in practice since fences and separators are
only made of a single character. However, it would still be possible to duplicate some
code/logic to add it back if that turns out to be necessary.
No new tests, already covered by existing tests.
- rendering/mathml/MathOperator.cpp:
(WebCore::MathOperator::MathOperator): Rename UndefinedOperator.
(WebCore::RenderMathMLOperator::firstLineBaseline): Improve rounding of ascent so that mfenced operators are correctly aligned.
- rendering/mathml/MathOperator.h: Rename UndefinedOperator, since it can now be used to draw non-stretchy operators.
(WebCore::MathOperator::isStretched): Deleted. This function is no longer used by RenderMathMLOperator.
(WebCore::MathOperator::unstretch): Deleted. This function is no longer used by RenderMathMLOperator.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Use useMathOperator.
(WebCore::RenderMathMLOperator::rebuildTokenContent): Set the MathOperator when useMathOperator() is true.
When the operator is not likely to stretch we just leave its type as NormalOperator.
(WebCore::RenderMathMLOperator::useMathOperator): Helper function to determine when MathOperator should be used.
(WebCore::RenderMathMLOperator::firstLineBaseline): Use useMathOperator.
(WebCore::RenderMathMLOperator::computeLogicalHeight): Ditto.
(WebCore::RenderMathMLOperator::paint): Ditto.
(WebCore::RenderMathMLOperator::paintChildren): Ditto.
- rendering/mathml/RenderMathMLOperator.h: Declare useMathOperator.
LayoutTests:
We adjust fenced-mi.html to handle one edge case that we no longer support.
We also update some test references on Mac and iOS.
- mathml/presentation/fenced-mi-expected.html: Indicate that this is no longer supported.
- mathml/presentation/fenced-mi.html: Adjust the reference since no text is shown.
- platform/mac/mathml/opentype/large-operators-expected.txt: Update reference.
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
- platform/mac/mathml/opentype/vertical-expected.txt: Ditto.
- platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt: Ditto.
- platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
- 11:16 PM Changeset in webkit [202270] by
-
- 2 edits in trunk/LayoutTests
Test expectation update for media/click-placeholder-not-pausing.html
- platform/mac-wk2/TestExpectations:
- 11:08 PM Changeset in webkit [202269] by
-
- 2 edits in trunk/LayoutTests
Test expectation update for
https://bugs.webkit.org/show_bug.cgi?id=158320
REGRESSION (r201476?): LayoutTest tiled-drawing/scrolling/latched-div-with-scroll-snap.html is flaky
- platform/mac-wk2/TestExpectations:
- 9:56 PM Changeset in webkit [202268] by
-
- 24 edits in trunk/Source/WebCore
Don't eagerly reify DOM Prototype properties
https://bugs.webkit.org/show_bug.cgi?id=158557
Reviewed by Andreas Kling.
We were eagerly reifying these properties to avoid virtualizing getOwnPropertySlot,
but since bug #158059 this does not require a method table call in any case.
Eagerly reifying these values likely has some CPU and memory cost on page load.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- should generate compressed index for hashtable, prototype object ClassInfo should contain static table, don't reifyStaticProperties for prototype objects.
(GeneratePrototypeDeclaration):
- Set HasStaticPropertyTable for DOM prototype objects.
- bindings/scripts/test/JS/JSInterfaceName.cpp:
(WebCore::JSInterfaceNamePrototype::JSInterfaceNamePrototype):
(WebCore::JSInterfaceNamePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectPrototype::JSTestActiveDOMObjectPrototype):
(WebCore::JSTestActiveDOMObjectPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::JSTestClassWithJSBuiltinConstructorPrototype::JSTestClassWithJSBuiltinConstructorPrototype):
(WebCore::JSTestClassWithJSBuiltinConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::JSTestCustomConstructorWithNoInterfaceObjectPrototype):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):
(WebCore::JSTestEventConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetPrototype::JSTestEventTargetPrototype):
(WebCore::JSTestEventTargetPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(WebCore::JSTestExceptionPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachablePrototype::JSTestGenerateIsReachablePrototype):
(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
(WebCore::JSTestInterfacePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorPrototype::JSTestJSBuiltinConstructorPrototype):
(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
(WebCore::JSTestMediaQueryListListenerPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorPrototype::JSTestNamedConstructorPrototype):
(WebCore::JSTestNamedConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::JSTestNodePrototype):
(WebCore::JSTestNodePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNondeterministic.cpp:
(WebCore::JSTestNondeterministicPrototype::JSTestNondeterministicPrototype):
(WebCore::JSTestNondeterministicPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::JSTestObjPrototype):
(WebCore::JSTestObjPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):
(WebCore::JSTestOverloadedConstructorsPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsPrototype::JSTestOverrideBuiltinsPrototype):
(WebCore::JSTestOverrideBuiltinsPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsPrototype::JSTestTypedefsPrototype):
(WebCore::JSTestTypedefsPrototype::finishCreation):
- bindings/scripts/test/JS/JSattribute.cpp:
(WebCore::JSattributePrototype::JSattributePrototype):
(WebCore::JSattributePrototype::finishCreation):
- bindings/scripts/test/JS/JSreadonly.cpp:
(WebCore::JSreadonlyPrototype::JSreadonlyPrototype):
(WebCore::JSreadonlyPrototype::finishCreation):
- 9:51 PM Changeset in webkit [202267] by
-
- 5 edits in trunk
WebRTC: RTCIceCandidate init dictionary don't handle explicit null or undefined values correctly
https://bugs.webkit.org/show_bug.cgi?id=158873
Reviewed by Alejandro G. Castro.
Source/WebCore:
Prevent explicit null and undefined values from being converted to "null" and "undefined"
strings.
Test: Extended fast/mediastream/RTCIceCandidate.html
- Modules/mediastream/RTCIceCandidate.cpp:
(WebCore::RTCIceCandidate::create):
LayoutTests:
Updated test to verify that explicit null and undefined values, passed to the
RTCIceCandidate init dictionary, are handled correctly.
- fast/mediastream/RTCIceCandidate-expected.txt:
- fast/mediastream/RTCIceCandidate.html:
- 8:48 PM Changeset in webkit [202266] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: UncaughtExceptionReporter should handle null event.error
https://bugs.webkit.org/show_bug.cgi?id=158971
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-20
Reviewed by Brian Burg.
- UserInterface/Debug/UncaughtExceptionReporter.js:
Since
typeof null === "object"handle uncaught exceptions where the
Error object itself is null.
- 8:26 PM Changeset in webkit [202265] by
-
- 8 edits in trunk/Source/WebCore
Unreviewed, rolling out r202252.
https://bugs.webkit.org/show_bug.cgi?id=158974
See rdar://problem/26867866 for details (Requested by ap on
#webkit).
Reverted changeset:
"Adopt commitPriority to get rid of the 2 AVPL solution for
PiP"
https://bugs.webkit.org/show_bug.cgi?id=158949
http://trac.webkit.org/changeset/202252
- 8:22 PM Changeset in webkit [202264] by
-
- 3 edits in trunk/LayoutTests
REGRESSION(r202253): Broke inspector/unit-tests/heap-snapshot-collection-event.html
https://bugs.webkit.org/show_bug.cgi?id=158973
Unreviewed fix after r202253.
- inspector/unit-tests/heap-snapshot-collection-event-expected.txt:
- inspector/unit-tests/heap-snapshot-collection-event.html:
Update the method name.
- 8:07 PM Changeset in webkit [202263] by
-
- 21 edits4 deletes in trunk
Unreviewed, rolling out r202243.
https://bugs.webkit.org/show_bug.cgi?id=158972
Broke Windows build and iOS tests (Requested by ap on
#webkit).
Reverted changeset:
"Focus event dispatched in iframe causes parent document to
scroll incorrectly"
https://bugs.webkit.org/show_bug.cgi?id=158629
http://trac.webkit.org/changeset/202243
- 8:01 PM Changeset in webkit [202262] by
-
- 4 edits in trunk/Source/WebCore
Simplify / Optimize DataDetector's searchForLinkRemovingExistingDDLinks()
https://bugs.webkit.org/show_bug.cgi?id=158968
Reviewed by Ryosuke Niwa.
Simplify / Optimize DataDetector's searchForLinkRemovingExistingDDLinks():
- Use modern ancestorsOfType<HTMLAnchorElement>() to traverse anchor ancestors instead of traversing by hand.
- Use NodeTraversal::next() to traverse the tree until we find endNode and use a for loop instead of a while loop. Previously, the logic the determine the next node was at the end of the loop and was identical behavior-wise to NodeTraversal::next(). However, the previous code for a lot less efficient because it was calling Node::childNodes() to get a NodeList of the children, then calling length() on it to check if we had children and finally use the first item in the list as next node. This was very inefficient because NodeList::length() would need to traverse all children to figure out the length and would cache all the children in a Vector in CollectionIndexCache.
- dom/ElementAncestorIterator.h:
(WebCore::ancestorsOfType):
- dom/ElementIterator.h:
(WebCore::findElementAncestorOfType):
(WebCore::findElementAncestorOfType<Element>):
Update ancestorsOfType() to take a Node instead of an Element. There are no
performance benefits to taking an Element here and it is a valid use case to
want an Element ancestor of a non-Element node.
- editing/cocoa/DataDetection.mm:
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::dataDetectorTypeForCategory): Deleted.
- 6:48 PM Changeset in webkit [202261] by
-
- 5 edits in trunk/Source/JavaScriptCore
[JSC] Use bytecode intrinsic to expose Module's loading status to builtin JS
https://bugs.webkit.org/show_bug.cgi?id=158871
Reviewed by Sam Weinig.
Now JSC has bytecode intrinsic system. Use it instead of exposing status values through the loader's properties.
- builtins/ModuleLoaderObject.js:
(newRegistryEntry):
(fulfillFetch):
(fulfillTranslate):
(commitInstantiated):
(requestFetch):
(requestTranslate):
(requestInstantiate):
(requestResolveDependencies.):
(requestResolveDependencies):
(requestLink):
(link):
(provide):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- runtime/ModuleLoaderObject.cpp:
(JSC::ModuleLoaderObject::finishCreation): Deleted.
- 5:49 PM Changeset in webkit [202260] by
-
- 2 edits in tags/Safari-602.1.37.0.1/Source/WebKit2
Merged r202229. rdar://problem/26903312
- 5:48 PM Changeset in webkit [202259] by
-
- 2 edits in tags/Safari-602.1.37.0.1/Source/WebKit2
Merged r202224. rdar://problem/26903312
- 5:47 PM Changeset in webkit [202258] by
-
- 6 edits in tags/Safari-602.1.37.0.1/Source
Merged r202142. rdar://problem/26903312
- 5:45 PM Changeset in webkit [202257] by
-
- 5 edits in tags/Safari-602.1.37.0.1/Source
Versioning.
- 5:32 PM Changeset in webkit [202256] by
-
- 1 copy in tags/Safari-602.1.37.0.1
New tag.
- 5:26 PM Changeset in webkit [202255] by
-
- 58 edits2 copies in trunk/Source
Unreviewed, rolling out r202248.
https://bugs.webkit.org/show_bug.cgi?id=158960
breaks builds on the simulator (Requested by keith_mi_ on
#webkit).
Reverted changeset:
"It should be easy to add a private global helper function for
builtins"
https://bugs.webkit.org/show_bug.cgi?id=158893
http://trac.webkit.org/changeset/202248
- 5:24 PM Changeset in webkit [202254] by
-
- 12 edits in trunk
Unreviewed, rolling out r202136.
https://bugs.webkit.org/show_bug.cgi?id=158932
JSBench wasn't regressed by r202002 and r202111 on iOS after
all (Requested by rniwa_ on #webkit).
Reverted changeset:
"Unreviewed, rolling out r202002 and r202111."
https://bugs.webkit.org/show_bug.cgi?id=158638
http://trac.webkit.org/changeset/202136
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-20
- 5:01 PM Changeset in webkit [202253] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Snapshot List should show the total size and the total live size
https://bugs.webkit.org/show_bug.cgi?id=157904
<rdar://problem/26372833>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-20
Reviewed by Brian Burg.
Include the live size of a snapshot in the snapshot list.
- Localizations/en.lproj/localizedStrings.js:
New "Live Size" string.
- UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
(HeapSnapshot):
(HeapSnapshot.updateCategoriesAndMetadata):
(HeapSnapshot.prototype.update):
(HeapSnapshot.prototype.serialize):
(HeapSnapshotDiff):
(HeapSnapshotDiff.prototype.update):
(HeapSnapshot.buildCategories): Deleted.
(HeapSnapshot.prototype.updateCategories): Deleted.
(HeapSnapshotDiff.prototype.updateCategories): Deleted.
- UserInterface/Proxies/HeapSnapshotDiffProxy.js:
(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.update):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateCategories): Deleted.
- UserInterface/Proxies/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.deserialize):
(WebInspector.HeapSnapshotProxy.prototype.get liveSize):
(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.update):
(WebInspector.HeapSnapshotProxy.prototype.updateCategories): Deleted.
Rename "updateCategories" to "update" and update both categories
and metadata, like the liveSize.
- UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:
(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype._heapSnapshotCollectedNodes):
Update live size after collection.
- UserInterface/Views/HeapAllocationsTimelineView.js:
(WebInspector.HeapAllocationsTimelineView):
Include a live size column in the DataGrid.
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
Cleanup listeners appropriately.
- 4:26 PM Changeset in webkit [202252] by
-
- 8 edits in trunk/Source/WebCore
Adopt commitPriority to get rid of the 2 AVPL solution for PiP
https://bugs.webkit.org/show_bug.cgi?id=158949
rdar://problem/26867866
Reviewed by Simon Fraser.
No new tests because there is no behavior change. This reverts changes from
https://bugs.webkit.org/show_bug.cgi?id=158148 and instead uses -[CAContext commitPriority:]
to prevent flicker when moving a layer between contexts.
commitPriority allows the layer to be added to the destination context before it is
removed from the source context.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: remove m_secondaryVideoLayer.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: ditto
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity): ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: ditto
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): ditto
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: ditto
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createPreviewLayers):ditto
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h: ditto
- platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm: ditto
(WebCore::VideoFullscreenLayerManager::setVideoLayer): ditto
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer): ditto and adopt commitPriority.
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame): ditto
(WebCore::VideoFullscreenLayerManager::setVideoLayers): Deleted.
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer): remove m_secondaryVideoLayer.
- platform/spi/cocoa/QuartzCoreSPI.h: Add commitPriority.
- 4:24 PM Changeset in webkit [202251] by
-
- 3 edits2 adds in trunk
Set the end position on the placeholder BidiRun properly.
https://bugs.webkit.org/show_bug.cgi?id=158958
Reviewed by Myles C. Maxfield.
rdar://problem/26609266
The second paramenter for BidiRun indicates the end position and not the length of the run.
This was regressed at r102875 where only the start position was changed from 0 to pos.
Source/WebCore:
Test: fast/text/international/bidi-style-in-isolate-crash.html
- rendering/InlineIterator.h:
(WebCore::addPlaceholderRunForIsolatedInline):
LayoutTests:
- fast/text/international/bidi-style-in-isolate-crash-expected.txt: Added.
- fast/text/international/bidi-style-in-isolate-crash.html: Added.
- 4:23 PM Changeset in webkit [202250] by
-
- 3 edits2 adds in trunk
A composition underline is placed to wrong position in RTL
https://bugs.webkit.org/show_bug.cgi?id=158602
Patch by Fujii Hironori <Fujii Hironori> on 2016-06-20
Reviewed by Myles C. Maxfield.
Source/WebCore:
InlineTextBox::paintCompositionUnderline does not take RTL into
account. The position of composition underline should be
mirrored in RTL.
Test: editing/input/composition-underline-rtl.html
- rendering/InlineTextBox.cpp:
(WebCore::mirrorRTLSegment): New helper function to convert RTL start position to LTR.
(WebCore::InlineTextBox::paintDecoration): Use mirrorRTLSegment.
(WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
LayoutTests:
- editing/input/composition-underline-rtl-expected.html: Added.
- editing/input/composition-underline-rtl.html: Added.
- 3:41 PM Changeset in webkit [202249] by
-
- 3 edits in trunk/Source/WebKit2
Allow Spotlight suggestions to be read by any process
https://bugs.webkit.org/show_bug.cgi?id=158950
<rdar://problem/26865374>
Reviewed by Alexey Proskuryakov.
Extend sandbox to allow all web processes to read Spotlight results.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- WebProcess/com.apple.WebProcess.sb.in:
- 3:38 PM Changeset in webkit [202248] by
-
- 58 edits2 deletes in trunk/Source
It should be easy to add a private global helper function for builtins
https://bugs.webkit.org/show_bug.cgi?id=158893
Reviewed by Mark Lam.
Source/JavaScriptCore:
This patch does two things. First it moves all the builtin names
out of CommonIdentifiers and into BuiltinNames. This means that
adding a new function to the Builtins does not require rebuilding
all of JavaScriptCore. This patch also adds a new decorator to our
builtins @privateGlobal that will automatically put the function
on the global object. The name of the property will be the same as
the private name of the function.
This patch, also, removes the JSArrayIterator.h/.cpp files
as they no longer appear to be used in any real way. Finally,
the builtins tests have been rebaselined. It appears this has
not been done for a while so the expected files contain other
changes.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/builtins/builtins_generate_combined_header.py:
(BuiltinsCombinedHeaderGenerator.generate_output):
(generate_section_for_code_name_macro):
(generate_section_for_global_private_code_name_macro):
- Scripts/builtins/builtins_model.py:
(BuiltinFunction.init):
(BuiltinFunction.fromString):
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
- Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
- Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
- Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
- builtins/ArrayIteratorPrototype.js:
- builtins/ArrayPrototype.js:
- builtins/BuiltinNames.h:
- builtins/GeneratorPrototype.js:
- builtins/GlobalObject.js:
- builtins/PromiseOperations.js:
- builtins/RegExpPrototype.js:
- builtins/StringPrototype.js:
- bytecode/BytecodeIntrinsicRegistry.cpp:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::expectedFunctionForIdentifier):
(JSC::BytecodeGenerator::emitGetTemplateObject):
(JSC::BytecodeGenerator::emitLoadNewTargetFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadDerivedConstructorFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitPutNewTargetToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitGeneratorStateChange):
- bytecompiler/NodesCodegen.cpp:
(JSC::emitHomeObjectForCallee):
(JSC::emitPutHomeObject):
(JSC::FunctionNode::emitBytecode):
- dfg/DFGOperations.cpp:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties): Deleted.
- parser/Lexer.cpp:
(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::createGeneratorParameters):
(JSC::Parser<LexerType>::parseExportDeclaration):
- runtime/ArrayIteratorPrototype.cpp:
- runtime/ArrayIteratorPrototype.h:
- runtime/ArrayPrototype.cpp:
- runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers): Deleted.
- runtime/CommonIdentifiers.h:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/IntlDateTimeFormat.cpp:
- runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):
- runtime/IntlNumberFormatPrototype.cpp:
(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):
- runtime/IntlObjectInlines.h:
(JSC::constructIntlInstanceWithWorkaroundForLegacyIntlConstructor):
- runtime/JSArrayIterator.cpp: Removed.
(JSC::JSArrayIterator::finishCreation): Deleted.
(JSC::JSArrayIterator::kind): Deleted.
(JSC::JSArrayIterator::iteratedValue): Deleted.
- runtime/JSArrayIterator.h: Removed.
(JSC::JSArrayIterator::createStructure): Deleted.
(JSC::JSArrayIterator::create): Deleted.
(JSC::JSArrayIterator::JSArrayIterator): Deleted.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSInternalPromise.cpp:
- runtime/JSInternalPromiseDeferred.cpp:
(JSC::JSInternalPromiseDeferred::create):
- runtime/JSPromise.cpp:
(JSC::JSPromise::finishCreation):
(JSC::JSPromise::result):
- runtime/JSPromiseDeferred.cpp:
(JSC::JSPromiseDeferred::create):
- runtime/JSStringIterator.cpp:
(JSC::JSStringIterator::finishCreation):
(JSC::JSStringIterator::iteratedValue):
(JSC::JSStringIterator::clone):
- runtime/MapPrototype.cpp:
(JSC::MapPrototype::finishCreation):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/ReflectObject.cpp:
(JSC::ReflectObject::finishCreation):
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
- runtime/TypedArrayInlines.h:
Source/WebCore:
Add JSCJSValueInlines.h to fix build issues.
- platform/mock/mediasource/MockBox.cpp:
- 3:30 PM Changeset in webkit [202247] by
-
- 2 edits in trunk/LayoutTests
Test expectations gardening for
https://bugs.webkit.org/show_bug.cgi?id=155196
- platform/mac-wk1/TestExpectations:
- 2:37 PM Changeset in webkit [202246] by
-
- 2 edits in trunk/LayoutTests
Test result gardening.
- platform/mac-wk2/TestExpectations:
- 2:30 PM Changeset in webkit [202245] by
-
- 20 edits4 adds in trunk
:default CSS pseudo-class should match checkboxes+radios with a
checkedattribute
https://bugs.webkit.org/show_bug.cgi?id=156230
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt:
Source/WebCore:
This patch update the :default pseudo class matching to be closer to the spec:
https://html.spec.whatwg.org/multipage/scripting.html#selector-default
The main remaining difference with the spec is the definition of "default button".
This is an unrelated problem that should be addressed separately.
The implementation was missing support for:
-input elements of type "checkbox" or "radio" with the "checked" attribute defined.
-option elements with the "selected" attribute defined.
The existing support for default button was pretty bad, I fixed that too.
The owner form now has a resetDefaultButton() API. When a Form Associated Element
becomes a submit button or loses that property, the element calls its form
to update the style as needed.
Whenever the submit button changes, 2 elements needs to have their style invalidated:
-The former default button.
-The new default button.
To invalidate the former button, FormElement now caches the computed
default button. When the default button changes, the cached value is invalidated
in addition to the new value.
Computing the new default button takes linear time in the number of form associated element.
To mitigate that, resetDefaultButton() is only called when changes are related
to submit buttons. Since those changes are rare, I don't expect the invalidation
to be a problem.
Tests: fast/css/pseudo-default-basics.html
fast/selectors/default-style-update.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/SelectorCheckerTestFunctions.h:
(WebCore::matchesDefaultPseudoClass):
(WebCore::isDefaultButtonForForm): Deleted.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
- dom/Element.cpp:
(WebCore::Element::matchesValidPseudoClass):
(WebCore::Element::matchesInvalidPseudoClass):
(WebCore::Element::matchesDefaultPseudoClass):
- dom/Element.h:
(WebCore::Element::matchesValidPseudoClass): Deleted.
(WebCore::Element::matchesInvalidPseudoClass): Deleted.
(WebCore::Element::isDefaultButtonForForm): Deleted.
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::parseAttribute):
(WebCore::HTMLButtonElement::matchesDefaultPseudoClass):
- html/HTMLButtonElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isDefaultButtonForForm): Deleted.
- html/HTMLFormControlElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::registerFormElement):
(WebCore::HTMLFormElement::removeFormElement):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::resetDefaultButton):
- html/HTMLFormElement.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::matchesDefaultPseudoClass):
- html/HTMLInputElement.h:
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::matchesDefaultPseudoClass):
(WebCore::HTMLOptionElement::parseAttribute):
- html/HTMLOptionElement.h:
- style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement):
(WebCore::Style::canShareStyleWithControl): Deleted.
LayoutTests:
- fast/css/pseudo-default-basics-expected.html: Added.
- fast/css/pseudo-default-basics.html: Added.
- fast/selectors/default-style-update-expected.txt: Added.
- fast/selectors/default-style-update.html: Added.
- 2:25 PM Changeset in webkit [202244] by
-
- 3 edits in trunk/Source/JavaScriptCore
LLInt64 Float64 get_by_val doesn't purify NaN
https://bugs.webkit.org/show_bug.cgi?id=158956
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter64.asm: Fix the bug.
- tests/stress/float64-array-nan-inlined.js: Make this test also run in LLInt-only mode to catch this bug.
- 2:22 PM Changeset in webkit [202243] by
-
- 21 edits4 adds in trunk
Focus event dispatched in iframe causes parent document to scroll incorrectly
https://bugs.webkit.org/show_bug.cgi?id=158629
rdar://problem/26521616
Reviewed by Tim Horton.
Source/WebCore:
When focussing elements in iframes, the page could scroll to an incorrect location.
This happened because code in Element::focus() tried to disable scrolling on focus,
but did so only for the current frame, so ancestor frames got programmatically scrolled.
On iOS we handle the scrolling in the UI process, so never want the web process to
do programmatic scrolling.
Fix by changing the focus and cache restore code to use SelectionRevealMode::DoNotReveal,
rather than manually prohibiting frame scrolling. Pass SelectionRevealMode through various callers,
and use RevealUpToMainFrame for iOS, allowing the UI process to do the zoomToRect: for the main frame.
Tests: fast/forms/ios/focus-input-in-iframe.html
fast/forms/ios/programmatic-focus-input-in-iframe.html
- dom/Document.h:
- dom/Element.cpp:
(WebCore::Element::scrollIntoView):
(WebCore::Element::scrollIntoViewIfNeeded):
(WebCore::Element::scrollIntoViewIfNotVisible):
(WebCore::Element::focus):
(WebCore::Element::updateFocusAppearance):
- dom/Element.h:
- editing/Editor.cpp:
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::revealSelectionAfterEditingOperation):
(WebCore::Editor::findStringAndScrollToVisible):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::FrameSelection): Deleted.
- editing/FrameSelection.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateFocusAppearance):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updateFocusAppearance):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::autoscroll):
- rendering/RenderLayer.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::scrollRectToVisible):
- rendering/RenderObject.h:
Source/WebKit/mac:
Pass SelectionRevealMode::Reveal in existing code.
- WebView/WebFrame.mm:
(-[WebFrame _scrollDOMRangeToVisible:]):
(-[WebFrame _scrollDOMRangeToVisible:withInset:]):
(-[WebFrame revealSelectionAtExtent:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView jumpToSelection:]):
(-[WebHTMLView centerSelectionInVisibleArea:]):
Source/WebKit2:
Pass SelectionRevealMode::Reveal in existing code.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::centerSelectionInVisibleArea):
LayoutTests:
- fast/forms/ios/focus-input-in-iframe-expected.txt: Added.
- fast/forms/ios/focus-input-in-iframe.html: Added.
- fast/forms/ios/programmatic-focus-input-in-iframe-expected.txt: Added.
- fast/forms/ios/programmatic-focus-input-in-iframe.html: Added.
- 1:52 PM Changeset in webkit [202242] by
-
- 205 edits in trunk
Remove RefPtr::release() and change calls sites to use WTFMove()
https://bugs.webkit.org/show_bug.cgi?id=158369
Reviewed by Chris Dumez.
RefPtr::release() releases its managed pointer awkwardly. It's more
direct and clearer to use WTFMove to transfer ownership of the managed
pointer.
As part of this cleanup, also change a lot of explicit data types to
'auto'.
Source/JavaScriptCore:
- API/JSObjectRef.cpp:
(JSClassCreate):
- API/JSScriptRef.cpp:
- API/JSValueRef.cpp:
(JSValueToStringCopy):
- bytecompiler/StaticPropertyAnalyzer.h:
(JSC::StaticPropertyAnalyzer::newObject):
(JSC::StaticPropertyAnalyzer::mov):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::invalidate):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- inspector/InspectorValues.cpp:
(Inspector::InspectorValue::parseJSON):
- inspector/agents/InspectorAgent.cpp:
(Inspector::InspectorAgent::activateExtraDomain):
(Inspector::InspectorAgent::activateExtraDomains):
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::breakpointActionProbe):
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::receivedSetupMessage):
- jit/Repatch.cpp:
(JSC::linkPolymorphicCall):
- runtime/GenericTypedArrayViewInlines.h:
(JSC::GenericTypedArrayView<Adaptor>::create):
(JSC::GenericTypedArrayView<Adaptor>::createUninitialized):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer):
- runtime/PropertyNameArray.h:
(JSC::PropertyNameArray::releaseData):
- runtime/Structure.cpp:
(JSC::Structure::toStructureShape):
- runtime/TypeSet.cpp:
(JSC::StructureShape::merge):
- tools/FunctionOverrides.cpp:
(JSC::initializeOverrideInfo):
Source/WebCore:
No new tests: there's no new functionality, just a refactoring of
existing code.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBuffer::provideMediaData):
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::start):
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::clear):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::handlePostMessage):
- bindings/js/JSHistoryCustom.cpp:
(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):
- bindings/js/JSMessagePortCustom.h:
(WebCore::handlePostMessage):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readTerminal):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertShapeValue):
- css/StyleProperties.cpp:
(WebCore::StyleProperties::copyPropertiesInSet):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImages):
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::clearSheet):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::removeChildrenInRange):
(WebCore::CompositeEditCommand::removeNodeAndPruneAncestors):
(WebCore::CompositeEditCommand::prune):
(WebCore::CompositeEditCommand::replaceSelectedTextInNode):
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring):
- editing/CreateLinkCommand.cpp:
(WebCore::CreateLinkCommand::doApply):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeStyle):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
- editing/Editor.cpp:
(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
- editing/EditorCommand.cpp:
(WebCore::executeInsertNode):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::insertTab):
- editing/RemoveNodePreservingChildrenCommand.cpp:
(WebCore::RemoveNodePreservingChildrenCommand::doApply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::removeNodePreservingChildren):
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
- html/HTMLFontElement.cpp:
(WebCore::HTMLFontElement::collectStyleForPresentationAttribute):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::prepareForSubmission):
- html/HTMLTableElement.cpp:
(WebCore::leakBorderStyle):
(WebCore::leakGroupBorderStyle):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
- html/track/InbandDataTextTrack.cpp:
(WebCore::InbandDataTextTrack::addDataCue):
- html/track/InbandGenericTextTrack.cpp:
(WebCore::InbandGenericTextTrack::newCuesParsed):
- html/track/InbandWebVTTTextTrack.cpp:
(WebCore::InbandWebVTTTextTrack::newCuesParsed):
- html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getInlineStylesForNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
- inspector/InspectorIndexedDBAgent.cpp:
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::loadResource):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadPostRequest):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::finalProgressComplete):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::disassociateDocumentLoader):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
- loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::loadCacheGroup):
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::loadCache):
- loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::popSubframeArchive):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::extract):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::createImage):
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
- page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::createOverlayIfNeeded):
(WebCore::ServicesOverlayController::determineActiveHighlight):
- page/scrolling/AsyncScrollingCoordinator.h:
(WebCore::AsyncScrollingCoordinator::releaseScrollingTree):
- page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::cloneAndReset):
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::attachNode):
- platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
- platform/graphics/DisplayRefreshMonitorManager.cpp:
(WebCore::DisplayRefreshMonitorManager::createMonitorForClient):
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForSystemFallback):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):
- platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::processCodedFrame):
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/graphics/ca/PlatformCALayer.cpp:
(WebCore::PlatformCALayer::createCompatibleLayerOrTakeFromPool):
- platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::getData):
- platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):
- platform/graphics/mac/ImageMac.mm:
(WebCore::Image::loadPlatformResource):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::createForCurrentGLContext):
(WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
- platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream):
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLForSlice):
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::create):
- platform/network/cf/FormDataStreamCFNet.cpp:
(WebCore::formCreate):
- platform/text/BidiContext.cpp:
(WebCore::BidiContext::copyStackRemovingUnicodeEmbeddingContexts):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::createScrollbar):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::createScrollbar):
- rendering/RenderMenuList.cpp:
(RenderMenuList::createScrollbar):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::createScrollbar):
- replay/ReplayController.cpp:
(WebCore::ReplayController::unloadSegment):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::build):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::build):
- svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::internalAbort):
- xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
Source/WebKit:
- Storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::create):
(WebKit::NetscapePluginInstanceProxy::loadRequest):
(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
- WebCoreSupport/WebFrameLoaderClient.mm:
(-[WebFramePolicyListener receivedPolicyDecision:]):
- WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin initWithURL:]):
- WebView/WebArchive.mm:
(-[WebArchive initWithMainResource:subresources:subframeArchives:]):
(-[WebArchive initWithData:]):
- WebView/WebDataSource.mm:
(-[WebDataSource mainResource]):
- WebView/WebFrame.mm:
(-[WebFrame _documentFragmentWithNodesAsParagraphs:]):
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::createDatabaseToWebProcessConnection):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):
- Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::allocate):
(WebKit::SharedMemory::create):
(WebKit::SharedMemory::map):
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::createWebProcessConnection):
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
(encodeToObjectStream):
- Shared/API/c/WKImage.cpp:
(WKImageCreate):
- Shared/API/c/WKNumber.cpp:
(WKBooleanCreate):
(WKDoubleCreate):
(WKUInt64Create):
- Shared/API/c/WKSecurityOriginRef.cpp:
(WKSecurityOriginCreate):
- Shared/API/c/WKSerializedScriptValue.cpp:
(WKSerializedScriptValueCreate):
(WKSerializedScriptValueCreateWithInternalRepresentation):
- Shared/API/c/cairo/WKImageCairo.cpp:
(WKImageCreateFromCairoSurface):
- Shared/API/c/cg/WKImageCG.cpp:
(WKImageCreateFromCGImage):
- Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
- Shared/API/c/mac/WKObjCTypeWrapperRef.mm:
(WKObjCTypeWrapperCreate):
- Shared/API/c/mac/WKWebArchive.cpp:
(WKWebArchiveCreate):
(WKWebArchiveCreateWithData):
(WKWebArchiveCreateFromRange):
(WKWebArchiveCopyMainResource):
(WKWebArchiveCopySubresources):
(WKWebArchiveCopySubframeArchives):
- Shared/API/c/mac/WKWebArchiveResource.cpp:
(WKWebArchiveResourceCreate):
- Shared/APIWebArchive.mm:
(API::WebArchive::WebArchive):
- Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::getOrCreate):
- Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::create):
- Shared/ShareableResource.cpp:
(WebKit::ShareableResource::map):
- Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::ArgumentCoder<DragData>::decode):
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewCreate):
- UIProcess/API/C/WKBatteryStatus.cpp:
(WKBatteryStatusCreate):
- UIProcess/API/C/WKGeolocationPosition.cpp:
(WKGeolocationPositionCreate_b):
- UIProcess/API/C/WKGrammarDetail.cpp:
(WKGrammarDetailCreate):
- UIProcess/API/C/WKPage.cpp:
(WKPageCopySessionState):
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupCreateWithIdentifier):
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
(WKPreferencesCreateCopy):
- UIProcess/API/C/WKSessionRef.cpp:
(WKSessionCreate):
- UIProcess/API/C/WKSessionStateRef.cpp:
(WKSessionStateCopyData):
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextCopyPlugInInfoForBundleIdentifier):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadRequest:]):
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
(-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _loadData:MIMEType:characterEncodingName:baseURL:userData:]):
(-[WKWebView _reloadWithoutContentBlockers]):
(-[WKWebView _sessionStateData]):
(-[WKWebView _restoreSessionState:andNavigate:]):
- UIProcess/API/efl/ewk_database_manager.cpp:
(EwkDatabaseManager::createOriginList):
- UIProcess/API/efl/ewk_storage_manager.cpp:
(EwkStorageManager::createOriginList):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewCreateNewPage):
(webkitWebViewPrintFrame):
(getContentsAsMHTMLDataCallback):
- UIProcess/Cocoa/SessionStateCoding.mm:
(WebKit::encodeSessionState):
- UIProcess/GenericCallback.h:
(WebKit::CallbackMap::take):
- UIProcess/GeolocationPermissionRequestManagerProxy.cpp:
(WebKit::GeolocationPermissionRequestManagerProxy::createRequest):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:
(WebKit::NotificationPermissionRequestManagerProxy::createRequest):
- UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::createLocalStorageMap):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::clear):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::installViewStateChangeCompletionHandler):
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::copy):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::~WebProcessPool):
- UIProcess/mac/ViewSnapshotStore.mm:
(WebKit::ViewSnapshotStore::recordSnapshot):
- UIProcess/mac/WKImmediateActionController.mm:
(-[WKImmediateActionController _webHitTestResult]):
- UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _askPageToComputePageRects]):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setDragImage):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(-[WKWebProcessPlugInFrame hitTest:]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm:
(-[WKWebProcessPlugInHitTestResult nodeHandle]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
(+[WKWebProcessPlugInNodeHandle nodeHandleWithJSValue:inContext:]):
(-[WKWebProcessPlugInNodeHandle htmlIFrameElementContentFrame]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:
(+[WKWebProcessPlugInScriptWorld world]):
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostSynchronousMessage):
- WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp:
(WKBundleDOMWindowExtensionCreate):
- WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultCopyNodeHandle):
(WKBundleHitTestResultCopyURLElementHandle):
- WebProcess/InjectedBundle/API/c/WKBundleNavigationAction.cpp:
(WKBundleNavigationActionCopyHitTestResult):
(WKBundleNavigationActionCopyFormElement):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCreate):
(WKBundleNodeHandleCopyDocument):
(WKBundleNodeHandleCopySnapshotWithOptions):
(WKBundleNodeHandleCopyVisibleRange):
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCreateSnapshotWithOptions):
(WKBundlePageCreateSnapshotInViewCoordinates):
(WKBundlePageCreateSnapshotInDocumentCoordinates):
(WKBundlePageCreateScaledSnapshotInDocumentCoordinates):
(WKBundlePagePostSynchronousMessageForTesting):
- WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:
(WKBundleRangeHandleCreate):
(WKBundleRangeHandleCopySnapshotWithOptions):
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldCreateWorld):
- WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
(-[WKDOMNode _copyBundleNodeHandleRef]):
- WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:
(-[WKDOMRange _copyBundleRangeHandleRef]):
- WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp:
(WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
(WebKit::InjectedBundleNodeHandle::renderedImage):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::getOrCreate):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::create):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::createScrollbar):
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::applyChange):
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toFormData):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
(WebKit::WebFrameLoaderClient::recreatePlugin):
(WebKit::WebFrameLoaderClient::createJavaAppletWidget):
(WebKit::WebFrameLoaderClient::createNetworkingContext):
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
- WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::getOrCreate):
(WebKit::VisitedLinkTableController::setVisitedLinkTable):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::createSelectionSnapshot):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::snapshotAtSize):
(WebKit::WebPage::snapshotNode):
(WebKit::WebPage::willPerformLoadDragDestinationAction):
(WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
(WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad):
(WebKit::WebPage::drawRectToImage):
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::create):
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::Properties::decode):
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::create):
(WebKit::PlatformCALayerRemote::clone):
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::create):
(WebKit::PlatformCALayerRemoteCustom::clone):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::createDisplayRefreshMonitor):
Tools:
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):
(createPagedBitmapContext):
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setMockGeolocationPosition):
- TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- 1:48 PM Changeset in webkit [202241] by
-
- 1 copy in tags/Safari-601.1.46.145
New tag.
- 1:47 PM Changeset in webkit [202240] by
-
- 1 copy in tags/Safari-601.7.5
New tag.
- 1:40 PM Changeset in webkit [202239] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r202179.
https://bugs.webkit.org/show_bug.cgi?id=158946
The test either fails or times out 100% of the time (Requested
by ap on #webkit).
Reverted changeset:
"REGRESSION: Double tap to zoom does not work on yahoo
finance"
https://bugs.webkit.org/show_bug.cgi?id=158886
http://trac.webkit.org/changeset/202179
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-20
- 1:38 PM Changeset in webkit [202238] by
-
- 2 edits in trunk/Source/WebCore
Crash in PlatformMediaSession::clientWillPausePlayback
https://bugs.webkit.org/show_bug.cgi?id=158953
<rdar://problem/26121125>
Reviewed by Jer Noble.
No new tests, I have not been able to reproduce this in a test.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::stop): Ref the element before calling stopWithoutDestroyingMediaPlayer
because updatePlaybackControlsManager can release the last reference and cause the
destructor to be called.
(WebCore::HTMLMediaElement::suspend): Ditto.
- 1:35 PM Changeset in webkit [202237] by
-
- 2 edits in trunk/LayoutTests
Fix a run-webkit-tests --lint warning.
- platform/mac/TestExpectations:
- 1:34 PM Changeset in webkit [202236] by
-
- 3 edits in trunk/Source/WebCore
Clean up ResourceResponseBase after r201943
https://bugs.webkit.org/show_bug.cgi?id=158706
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-20
Reviewed by Michael Catanzaro.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
(WebCore::ResourceResponseBase::asResourceResponse): Deleted.
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformCompare):
- 1:30 PM Changeset in webkit [202235] by
-
- 3 edits in trunk/LayoutTests
Test expectations gardening for
https://bugs.webkit.org/show_bug.cgi?id=155196
Marked the tests as flaky instead of skipping, to make the results visible on the
flakiness dashboard. Also added video-with-data-url-allowed-by-media-src-star.html,
which is very flaky too.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 12:12 PM Changeset in webkit [202234] by
-
- 22 edits2 adds in trunk
Web Inspector: console.profile should use the new Sampling Profiler
https://bugs.webkit.org/show_bug.cgi?id=153499
<rdar://problem/24352431>
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Currently console.profile/profileEnd behave slightly differently
between JSContext and Web inspection. Unifying will be part of:
<https://webkit.org/b/158753> Generalize the concept of Instruments on the backend
Both JSContext and Web inspection keep track of active
profiles started and stopped via console.profile/profileEnd.
JSContext inspection sends its programmatic start/stop
via the ScriptProfiler domain.
Web inspection sends its programmatic start/stop
via the Timeline domain, and also will start/stop backend
list of Instruments.
The functional differences between these is that for JSContext
inspection, console.profile only starts/stops the ScriptProfiler
domain, and does not auto-start other instruments. This isn't really
a problem right now given the instruments available for JSContext
inspection; but it will be nice to unify as we add more instruments.
Also, JSContext inspection won't have "Profile (name)" records in
its Events view, since those are currently generated only by the
Web's Timeline domain.
- inspector/protocol/ScriptProfiler.json:
- inspector/protocol/Timeline.json:
Events to inform the frontend of programmatic start/stop.
- debugger/Debugger.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::breakpointsActive):
(Inspector::InspectorDebuggerAgent::isPaused):
- inspector/agents/InspectorDebuggerAgent.h:
Expose breakpoints active state, since programmatic recording
will temporarily disabled breakpoints if needed.
- inspector/JSGlobalObjectConsoleClient.cpp:
(Inspector::JSGlobalObjectConsoleClient::JSGlobalObjectConsoleClient):
(Inspector::JSGlobalObjectConsoleClient::profile):
(Inspector::JSGlobalObjectConsoleClient::profileEnd):
(Inspector::JSGlobalObjectConsoleClient::startConsoleProfile):
(Inspector::JSGlobalObjectConsoleClient::stopConsoleProfile):
- inspector/JSGlobalObjectConsoleClient.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::programmaticCaptureStarted):
(Inspector::InspectorScriptProfilerAgent::programmaticCaptureStopped):
- inspector/agents/InspectorScriptProfilerAgent.h:
JSContext implementation of console.profile/profileEnd.
Source/WebCore:
Test: inspector/timeline/setInstruments-programmatic-capture.html
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
(WebCore::InspectorTimelineAgent::startProgrammaticCapture):
(WebCore::InspectorTimelineAgent::stopProgrammaticCapture):
(WebCore::InspectorTimelineAgent::toggleInstruments):
(WebCore::InspectorTimelineAgent::toggleScriptProfilerInstrument):
(WebCore::InspectorTimelineAgent::toggleHeapInstrument):
(WebCore::InspectorTimelineAgent::toggleMemoryInstrument):
(WebCore::InspectorTimelineAgent::toggleTimelineInstrument):
- inspector/InspectorTimelineAgent.h:
Web implementation of console.profile/profileEnd.
Make helpers for startings / stopping instruments.
Source/WebInspectorUI:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.programmaticCaptureStarted):
(WebInspector.TimelineManager.prototype.programmaticCaptureStopped):
(WebInspector.TimelineManager.prototype.scriptProfilerProgrammaticCaptureStarted):
(WebInspector.TimelineManager.prototype.scriptProfilerProgrammaticCaptureStopped):
For programmatic captures, automatically show the Script Timeline, since
that is guarenteed to have been started by the backend. Start capturing
without creating a new recording.
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.stop):
(WebInspector.TimelineRecording.prototype.addScriptInstrumentForProgrammaticCapture):
When stopping for programmatic capture we don't need to disable
instruments, the backend would have already done this.
- UserInterface/Protocol/ScriptProfilerObserver.js:
(WebInspector.ScriptProfilerObserver.prototype.programmaticCaptureStarted):
(WebInspector.ScriptProfilerObserver.prototype.programmaticCaptureStopped):
(WebInspector.ScriptProfilerObserver):
- UserInterface/Protocol/TimelineObserver.js:
(WebInspector.TimelineObserver.prototype.programmaticCaptureStarted):
(WebInspector.TimelineObserver.prototype.programmaticCaptureStopped):
(WebInspector.TimelineObserver):
Pass through Web and JSContext programmatic capture events.
LayoutTests:
- inspector/timeline/setInstruments-programmatic-capture-expected.txt: Added.
- inspector/timeline/setInstruments-programmatic-capture.html: Added.
New test that the backend auto-starts instruments during programmatic capture.
- 12:10 PM Changeset in webkit [202233] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rebaseline test now that TouchEvent has a constructor.
- fast/events/touch/document-create-touch-list-ios-expected.txt:
- 11:52 AM Changeset in webkit [202232] by
-
- 2 edits1 add in trunk/Tools
Add a API test for *DeferringViewInWindowChanges as fixed in r202230
https://bugs.webkit.org/show_bug.cgi?id=158947
Reviewed by Simon Fraser.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):
Add a test ensuring that in-window state changes are deferred when using
the SPI for deferring them, as fixed in r202230.
- 10:23 AM Changeset in webkit [202231] by
-
- 9 edits in trunk/Source/WebCore
When navigating, discard decoded image data that is only live due to page cache.
<https://webkit.org/b/158941>
Reviewed by Antti Koivisto.
A resource is "live" if it's currently in use by a web page, and "dead" if it's
only kept alive by the memory cache.
This patch adds a mechanism that looks at CachedImage resources to see if all the
clients that make them appear "live" are actually pages in the page cache.
If so, we let the "jettison expensive objects on top-level navigation" mechanism
discard the decoded data for such half-live images. This can reduce the peak
memory usage during navigations quite a bit.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad): Move the call to MemoryPressureHandler
before we add the outgoing page to the page cache. This allows the jettisoning code
to make decisions based on which pages were cached *before* the navigation.
- loader/cache/CachedImageClient.h:
(WebCore::CachedImageClient::inPageCache):
- loader/ImageLoader.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::inPageCache):
- rendering/RenderObject.h:
(WebCore::RenderObject::inPageCache): Added a CachedImageClient::inPageCache() virtual
to determine which clients are currently in page cache (answered by their Document.)
- loader/cache/CachedImage.h:
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::areAllClientsInPageCache): Walks all CachedImageClient clients
and returns true if all of them are inPageCache().
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::jettisonExpensiveObjectsOnTopLevelNavigation):
Walk all the known CachedImages and nuke decoded data for those that have some but
are only considered live due to clients in the page cache.
- 10:13 AM Changeset in webkit [202230] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r191499): Tab content "jumps" down when focusing tabs that load in the background
https://bugs.webkit.org/show_bug.cgi?id=158904
<rdar://problem/26025831>
Reviewed by Sam Weinig.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::viewDidMoveToWindow):
During the large refactor that was r191499, we somehow ended up with two
different members for the same thing - one that got written, and one that
got read. We should only have one.
- 10:10 AM Changeset in webkit [202229] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the iOS build after r202142 and r202224.
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- 10:02 AM Nightly Builds edited by
- Add the link to El Capitan workarounds (diff)
- 9:10 AM Changeset in webkit [202228] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix post-landing review comment from Darin on r202188.
- platform/network/CacheValidation.cpp:
(WebCore::parseCacheHeader):
- 1:52 AM Changeset in webkit [202227] by
-
- 5 edits2 adds in trunk
Updating class name of a shadow host does not update the style applied by :host()
https://bugs.webkit.org/show_bug.cgi?id=158900
<rdar://problem/26883707>
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/shadow-dom/shadow-host-style-update.html
Teach style invalidation optimization code about :host.
- style/AttributeChangeInvalidation.cpp:
(WebCore::Style::mayBeAffectedByHostStyle):
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):
- style/ClassChangeInvalidation.cpp:
(WebCore::Style::computeClassChange):
(WebCore::Style::mayBeAffectedByHostStyle):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):
- style/IdChangeInvalidation.cpp:
(WebCore::Style::mayBeAffectedByHostStyle):
(WebCore::Style::IdChangeInvalidation::invalidateStyle):
LayoutTests:
- fast/shadow-dom/shadow-host-style-update-expected.html: Added.
- fast/shadow-dom/shadow-host-style-update.html: Added.
- 12:07 AM Changeset in webkit [202226] by
-
- 2 edits in trunk/Tools
WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
https://bugs.webkit.org/show_bug.cgi?id=158931
Patch by Fujii Hironori <Fujii Hironori> on 2016-06-20
Reviewed by Alexey Proskuryakov.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
Jun 19, 2016:
- 11:56 PM Changeset in webkit [202225] by
-
- 10 edits in trunk/Source/ThirdParty
Update Brotli to version 0.4.0
https://bugs.webkit.org/show_bug.cgi?id=158907
Reviewed by Michael Catanzaro.
- brotli/README.webkit:
- brotli/dec/bit_reader.h:
- brotli/dec/decode.c:
- brotli/dec/decode.h:
- brotli/dec/huffman.c:
- brotli/dec/huffman.h:
- brotli/dec/port.h:
(BrotliDump):
- brotli/dec/state.c:
- brotli/dec/state.h:
- 10:53 PM Changeset in webkit [202224] by
-
- 2 edits in trunk/Source/WebKit2
Fix erroneously commented line added in r202142.
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::applyBackingStoreToLayer):
- 8:57 PM Changeset in webkit [202223] by
-
- 3 edits in trunk/LayoutTests
Test expectation gardening.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 7:35 PM Changeset in webkit [202222] by
-
- 3 edits in trunk/LayoutTests
Test expectation gardening.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 6:59 PM Changeset in webkit [202221] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark shadow-dom tests to pass because it was enabled by r202091
https://bugs.webkit.org/show_bug.cgi?id=158930
Unreviewed EFL gardening.
- platform/efl/TestExpectations:
- 6:22 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 6:19 PM Changeset in webkit [202220] by
-
- 2 edits2 adds in trunk/LayoutTests
[GTK] Unreviewed test gardening
- fast/forms/select-non-native-rendering-direction-expected.txt: Added.
- fast/text/hyphenate-avoid-orphaned-word-expected.txt: Added.
- platform/gtk/TestExpectations:
- 5:17 PM Changeset in webkit [202219] by
-
- 36 edits27 copies3 moves38 adds3 deletes in trunk
Add test expectations for macOS Sierra
https://bugs.webkit.org/show_bug.cgi?id=158903
Reviewed by Alex Christensen.
Tools:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
Added dashboard support.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
Trigger the right build queues on check-in.
- Scripts/webkitpy/common/system/platforminfo.py:
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
- Scripts/webkitpy/port/mac.py:
- Scripts/webkitpy/port/mac_unittest.py:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
Added cases for Sierra, and updated tests for new baseline search paths.
LayoutTests:
- TestExpectations:
- media/click-placeholder-not-pausing-expected.txt: Added.
- media/click-placeholder-not-pausing.html: Added.
- media/controls/picture-in-picture-expected.txt: Added.
- media/controls/picture-in-picture.html: Added.
- media/element-containing-pip-video-going-into-fullscreen-expected.txt: Added.
- media/element-containing-pip-video-going-into-fullscreen.html: Added.
- media/fullscreen-api-enabled-media-with-presentation-mode-expected.txt: Added.
- media/fullscreen-api-enabled-media-with-presentation-mode.html: Added.
- media/fullscreen-video-going-into-pip-expected.txt: Added.
- media/fullscreen-video-going-into-pip.html: Added.
- media/navigate-with-pip-should-not-crash-expected.txt: Added.
- media/navigate-with-pip-should-not-crash.html: Added.
- media/pip-video-going-into-fullscreen-expected.txt: Added.
- media/pip-video-going-into-fullscreen.html: Added.
- media/video-contained-in-fullscreen-element-going-into-pip-expected.txt: Added.
- media/video-contained-in-fullscreen-element-going-into-pip.html: Added.
- platform/mac-elcapitan: Added.
- platform/mac-elcapitan/compositing: Added.
- platform/mac-elcapitan/compositing/rtl: Added.
- platform/mac-elcapitan/compositing/rtl/rtl-overflow-scrolling-expected.txt: Copied from LayoutTests/platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt.
- platform/mac-elcapitan/fast: Added.
- platform/mac-elcapitan/fast/block: Added.
- platform/mac-elcapitan/fast/block/float: Added.
- platform/mac-elcapitan/fast/block/float/026-expected.png: Copied from LayoutTests/platform/mac/fast/block/float/026-expected.png.
- platform/mac-elcapitan/fast/block/float/026-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/026-expected.txt.
- platform/mac-elcapitan/fast/block/float/028-expected.png: Copied from LayoutTests/platform/mac/fast/block/float/028-expected.png.
- platform/mac-elcapitan/fast/block/float/028-expected.txt: Copied from LayoutTests/platform/mac/fast/block/float/028-expected.txt.
- platform/mac-elcapitan/fast/overflow: Added.
- platform/mac-elcapitan/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Copied from LayoutTests/platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png.
- platform/mac-elcapitan/fast/overflow/unreachable-overflow-rtl-bug-expected.txt: Copied from LayoutTests/platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt.
- platform/mac-elcapitan/fast/ruby: Added.
- platform/mac-elcapitan/fast/ruby/bopomofo-expected.png: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-expected.png.
- platform/mac-elcapitan/fast/ruby/bopomofo-expected.txt: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-expected.txt.
- platform/mac-elcapitan/fast/ruby/bopomofo-letter-spacing-expected.png: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-letter-spacing-expected.png.
- platform/mac-elcapitan/fast/ruby/bopomofo-letter-spacing-expected.txt: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt.
- platform/mac-elcapitan/fast/ruby/bopomofo-rl-expected.png: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-rl-expected.png.
- platform/mac-elcapitan/fast/ruby/bopomofo-rl-expected.txt: Copied from LayoutTests/platform/mac/fast/ruby/bopomofo-rl-expected.txt.
- platform/mac-elcapitan/fast/text: Added.
- platform/mac-elcapitan/fast/text/crash-complex-text-surrogate-expected.txt: Copied from LayoutTests/platform/mac/fast/text/crash-complex-text-surrogate-expected.txt.
- platform/mac-elcapitan/fast/text/justify-ideograph-complex-expected.png: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-complex-expected.png.
- platform/mac-elcapitan/fast/text/justify-ideograph-complex-expected.txt: Copied from LayoutTests/platform/mac/fast/text/justify-ideograph-complex-expected.txt.
- platform/mac-elcapitan/fast/text/line-initial-and-final-swashes-expected.png: Copied from LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.png.
- platform/mac-elcapitan/fast/text/line-initial-and-final-swashes-expected.txt: Copied from LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt.
- platform/mac-elcapitan/http: Added.
- platform/mac-elcapitan/http/tests: Added.
- platform/mac-elcapitan/http/tests/cookies: Added.
- platform/mac-elcapitan/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Copied from LayoutTests/http/tests/cookies/third-party-cookie-relaxing-expected.txt.
- platform/mac-elcapitan/http/tests/security: Added.
- platform/mac-elcapitan/http/tests/security/mixedContent: Added.
- platform/mac-elcapitan/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Copied from LayoutTests/platform/mac/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt.
- platform/mac-elcapitan/media: Added.
- platform/mac-elcapitan/media/controls-strict-expected.png: Copied from LayoutTests/platform/mac/media/controls-strict-expected.png.
- platform/mac-elcapitan/media/controls-strict-expected.txt: Copied from LayoutTests/platform/mac/media/controls-strict-expected.txt.
- platform/mac-elcapitan/media/controls-without-preload-expected.png: Copied from LayoutTests/platform/mac/media/controls-without-preload-expected.png.
- platform/mac-elcapitan/media/controls-without-preload-expected.txt: Copied from LayoutTests/platform/mac/media/controls-without-preload-expected.txt.
- platform/mac-elcapitan/media/track: Added.
- platform/mac-elcapitan/media/track/video-track-alternate-groups-expected.txt: Copied from LayoutTests/platform/mac/media/track/video-track-alternate-groups-expected.txt.
- platform/mac-elcapitan/media/video-controls-rendering-expected.txt: Copied from LayoutTests/platform/mac/media/video-controls-rendering-expected.txt.
- platform/mac-elcapitan/media/video-display-toggle-expected.png: Copied from LayoutTests/platform/mac/media/video-display-toggle-expected.png.
- platform/mac-elcapitan/media/video-display-toggle-expected.txt: Copied from LayoutTests/platform/mac/media/video-display-toggle-expected.txt.
- platform/mac-elcapitan/media/video-no-audio-expected.txt: Copied from LayoutTests/platform/mac/media/video-no-audio-expected.txt.
- platform/mac-elcapitan/media/video-volume-slider-expected.txt: Copied from LayoutTests/platform/mac/media/video-volume-slider-expected.txt.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac-wk2/fast/scrolling: Added.
- platform/mac-wk2/fast/scrolling/rtl-scrollbars-animation-property-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
- platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt:
- platform/mac/fast/block/float/026-expected.png:
- platform/mac/fast/block/float/026-expected.txt:
- platform/mac/fast/block/float/028-expected.png:
- platform/mac/fast/block/float/028-expected.txt:
- platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png:
- platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- platform/mac/fast/ruby/bopomofo-expected.png:
- platform/mac/fast/ruby/bopomofo-expected.txt:
- platform/mac/fast/ruby/bopomofo-letter-spacing-expected.png:
- platform/mac/fast/ruby/bopomofo-letter-spacing-expected.txt:
- platform/mac/fast/ruby/bopomofo-rl-expected.png:
- platform/mac/fast/ruby/bopomofo-rl-expected.txt:
- platform/mac/fast/text/crash-complex-text-surrogate-expected.txt:
- platform/mac/fast/text/justify-ideograph-complex-expected.png:
- platform/mac/fast/text/justify-ideograph-complex-expected.txt:
- platform/mac/fast/text/line-initial-and-final-swashes-expected.png:
- platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
- platform/mac/http/tests/cookies/third-party-cookie-relaxing-expected.txt: Added.
- platform/mac/http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt:
- platform/mac/media/controls-strict-expected.png: Removed.
- platform/mac/media/controls-without-preload-expected.png: Removed.
- platform/mac/media/track/video-track-alternate-groups-expected.txt:
- platform/mac/media/video-controls-rendering-expected.png: Removed.
- platform/mac/media/video-display-toggle-expected.png: Removed.
- platform/mac/media/video-no-audio-expected.png: Removed.
- platform/mac/media/video-volume-slider-expected.png: Removed.
- 5:03 PM Changeset in webkit [202218] by
-
- 25 edits in trunk/Source/WebCore
Remove hasStaticPropertyTable (part 5: done!)
https://bugs.webkit.org/show_bug.cgi?id=158431
Reviewed by Chris Dumez.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- remove hasStaticPropertyTable.
- bindings/scripts/test/JS/JSInterfaceName.h:
(WebCore::JSInterfaceName::create):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::create):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:
(WebCore::JSTestClassWithJSBuiltinConstructor::create):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::create):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::create):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::create):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::create):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::create):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
(WebCore::JSTestGenerateIsReachable::create):
- bindings/scripts/test/JS/JSTestGlobalObject.h:
- bindings/scripts/test/JS/JSTestInterface.h:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
(WebCore::JSTestJSBuiltinConstructor::create):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::create):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::create):
- bindings/scripts/test/JS/JSTestNode.h:
- bindings/scripts/test/JS/JSTestNondeterministic.h:
(WebCore::JSTestNondeterministic::create):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::create):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::create):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
(WebCore::JSTestOverrideBuiltins::create):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::create):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::create):
- bindings/scripts/test/JS/JSattribute.h:
(WebCore::JSattribute::create):
- bindings/scripts/test/JS/JSreadonly.h:
(WebCore::JSreadonly::create):
- 3:19 PM Changeset in webkit [202217] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove Sidebar z-index:0 workaround for scrollbars and position:sticky section headers
https://bugs.webkit.org/show_bug.cgi?id=158882
Reviewed by Darin Adler.
The z-index:0 workaround is no longer needed as it doesn't change anything.
- UserInterface/Views/Sidebar.css:
(.sidebar > .panel): Deleted.
- 1:49 PM Changeset in webkit [202216] by
-
- 2 edits in trunk/Tools
Another buid fix for master.cfg.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
- 1:35 PM Changeset in webkit [202215] by
-
- 2 edits in trunk/Tools
Another buid fix for master.cfg.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
- 12:42 PM Changeset in webkit [202214] by
-
- 26 edits2 adds in trunk/Source/JavaScriptCore
We should be able to generate more types of ICs inline
https://bugs.webkit.org/show_bug.cgi?id=158719
<rdar://problem/26825641>
Reviewed by Filip Pizlo.
This patch changes how we emit code for *byId ICs inline.
We no longer keep data labels to patch structure checks, etc.
Instead, we just regenerate the entire IC into a designated
region of code that the Baseline/DFG/FTL JIT will emit inline.
This makes it much simpler to patch inline ICs. All that's
needed to patch an inline IC is to memcpy the code from
a macro assembler inline using LinkBuffer. This architecture
will be easy to extend into other forms of ICs, such as one
for add, in the future.
To support this change, I've reworked the fields inside
StructureStubInfo. It now has one field that is the CodeLocationLabel
of the start of the inline IC. Then it has a few ints that track deltas
to other locations in the IC such as the slow path start, slow path call, the
ICs 'done' location. We used to perform math on these ints in a bunch of different
places. I've consolidated that math into methods inside StructureStubInfo.
To generate inline ICs, I've implemented a new class called InlineAccess.
InlineAccess is stateless: it just has a bunch of static methods for
generating code into the inline region specified by StructureStubInfo.
Repatch will now decide when it wants to generate such an inline
IC, and it will ask InlineAccess to do so.
I've implemented three types of inline ICs to begin with (extending
this in the future should be easy):
- Self property loads (both inline and out of line offsets).
- Self property replace (both inline and out of line offsets).
- Array length on specific array types.
(An easy extension would be to implement JSString length.)
To know how much inline space to reserve, I've implemented a
method that stubs out the various inline cache shapes and
dumps their size. This is used to determine how much space
to save inline. When InlineAccess ends up generating more
code than can fit inline, we will fall back to generating
code with PolymorphicAccess instead.
To make generating code into already allocated executable memory
efficient, I've made AssemblerData have 128 bytes of inline storage.
This saves us a malloc when splatting code into the inline region.
This patch also tidies up LinkBuffer's API for generating
into already allocated executable memory. Now, when generating
code that has less size than the already allocated space, LinkBuffer
will fill the extra space with nops. Also, if branch compaction shrinks
the code, LinkBuffer will add a nop sled at the end of the shrunken
code to take up the entire allocated size.
This looks like it could be a 1% octane progression.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::nop):
(JSC::ARM64Assembler::fillNops):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::nopw):
(JSC::ARMv7Assembler::nopPseudo16):
(JSC::ARMv7Assembler::nopPseudo32):
(JSC::ARMv7Assembler::fillNops):
(JSC::ARMv7Assembler::dmbSY):
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::addLinkTask):
(JSC::AbstractMacroAssembler::emitNops):
(JSC::AbstractMacroAssembler::AbstractMacroAssembler):
- assembler/AssemblerBuffer.h:
(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerData::operator=):
(JSC::AssemblerData::~AssemblerData):
(JSC::AssemblerData::buffer):
(JSC::AssemblerData::grow):
(JSC::AssemblerData::isInlineBuffer):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::setCodeSize):
(JSC::AssemblerBuffer::label):
(JSC::AssemblerBuffer::debugOffset):
(JSC::AssemblerBuffer::releaseAssemblerData):
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::copyCompactAndLinkCode):
(JSC::LinkBuffer::linkCode):
(JSC::LinkBuffer::allocate):
(JSC::LinkBuffer::performFinalization):
(JSC::LinkBuffer::shrink): Deleted.
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::debugAddress):
(JSC::LinkBuffer::size):
(JSC::LinkBuffer::wasAlreadyDisassembled):
(JSC::LinkBuffer::didAlreadyDisassemble):
(JSC::LinkBuffer::applyOffset):
(JSC::LinkBuffer::code):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::patchableBranch32):
(JSC::MacroAssemblerARM64::patchableBranch64):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::patchableBranch32):
(JSC::MacroAssemblerARMv7::patchableBranchPtrWithPatch):
- assembler/X86Assembler.h:
(JSC::X86Assembler::nop):
(JSC::X86Assembler::fillNops):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus):
- bytecode/InlineAccess.cpp: Added.
(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::linkCodeInline):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::getScratchRegister):
(JSC::hasFreeRegister):
(JSC::InlineAccess::canGenerateSelfPropertyReplace):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::isCacheableArrayLength):
(JSC::InlineAccess::generateArrayLength):
(JSC::InlineAccess::rewireStubAsJump):
- bytecode/InlineAccess.h: Added.
(JSC::InlineAccess::sizeForPropertyAccess):
(JSC::InlineAccess::sizeForPropertyReplace):
(JSC::InlineAccess::sizeForLengthAccess):
- bytecode/PolymorphicAccess.cpp:
(JSC::PolymorphicAccess::regenerate):
- bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initArrayLength):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::aboutToDie):
(JSC::StructureStubInfo::propagateTransitions):
(JSC::StructureStubInfo::containsPC):
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::considerCaching):
(JSC::StructureStubInfo::slowPathCallLocation):
(JSC::StructureStubInfo::doneLocation):
(JSC::StructureStubInfo::slowPathStartLocation):
(JSC::StructureStubInfo::patchableJumpForIn):
(JSC::StructureStubInfo::valueRegs):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedGetById):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::getById):
- jit/JITInlineCacheGenerator.cpp:
(JSC::JITByIdGenerator::finalize):
(JSC::JITByIdGenerator::generateFastCommon):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
(JSC::JITGetByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):
(JSC::JITPutByIdGenerator::generateFastPath):
(JSC::JITPutByIdGenerator::slowPathFunction):
(JSC::JITByIdGenerator::generateFastPathChecks): Deleted.
- jit/JITInlineCacheGenerator.h:
(JSC::JITByIdGenerator::reportSlowPathCall):
(JSC::JITByIdGenerator::slowPathBegin):
(JSC::JITByIdGenerator::slowPathJump):
(JSC::JITGetByIdGenerator::JITGetByIdGenerator):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitGetByValWithCachedId):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id):
- jit/Repatch.cpp:
(JSC::repatchCall):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::appropriateGenericPutByIdFunction):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryRepatchIn):
(JSC::repatchIn):
(JSC::linkSlowFor):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
(JSC::repatchByIdSelfAccess): Deleted.
(JSC::resetGetByIDCheckAndLoad): Deleted.
(JSC::resetPutByIDCheckAndLoad): Deleted.
(JSC::replaceWithJump): Deleted.
- 11:26 AM Changeset in webkit [202213] by
-
- 2 edits in trunk/Tools
Fix master.cfg
Unreviewed build fix.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
- 11:02 AM Changeset in webkit [202212] by
-
- 1 edit in trunk/Tools/ChangeLog
Test another commit.
Unreviewed.
- 10:51 AM Changeset in webkit [202211] by
-
- 4 edits in trunk/Source/WebCore
The JSBuiltinConstructor feature can't handle a JS interface extending an other JS interface
https://bugs.webkit.org/show_bug.cgi?id=158834
Reviewed by Eric Carlson.
No change of behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Explicitly setting DOMWrapped type definition from
JSXX class deriving from another JSYY class.
- bindings/scripts/test/JS/JSTestEventTarget.h: Rebased.
- bindings/scripts/test/JS/JSTestNode.h: Ditto.
- 10:48 AM Changeset in webkit [202210] by
-
- 1 edit in trunk/Tools/ChangeLog
Test commit.
Unreviewed.
- 10:35 AM Changeset in webkit [202209] by
-
- 1 edit in trunk/Tools/ChangeLog
Test another commit.
Unreviewed.
- 10:31 AM Changeset in webkit [202208] by
-
- 1 edit in trunk/Tools/ChangeLog
Test commit.
Unreviewed.
- 10:19 AM Changeset in webkit [202207] by
-
- 1 edit in trunk/Tools/ChangeLog
Test yet another commit.
Unreviewed.
- 10:01 AM Changeset in webkit [202206] by
-
- 1 edit in trunk/Tools/ChangeLog
Test another commit.
Unreviewed.
- 9:42 AM Changeset in webkit [202205] by
-
- 3 edits in trunk/Source/JavaScriptCore
REGRESSION(concurrent baseline JIT): Kraken/ai-astar runs 20% slower
https://bugs.webkit.org/show_bug.cgi?id=158906
Reviewed by Benjamin Poulain.
The concurrent baseline JIT was a 2-3% progression on JSBench, possibly a 1% progression
on PLT3, but a 2-5% regression on Kraken. This patch fixes the Kraken regression without
affecting the other tests.
The problem is that Kraken/ai-astar's initialization code had a ginormous piece of init
code that took about 16ms to compile in baseline. There's no good way to avoid letting it
tier-up into baseline since it has a compute loop. The time it takes to run this code is
never measured. The concurrent baseline JIT caused us to schedule the compilation of this
huge code rather than doing it eagerly. This meant that after initialization was done and
we started actually running real stuff, all of the real stuff's compiles would be convoyed
behind this super-expensive baseline compile. Note that DFG and FTL compiles convoy behind
baseline compiles, since you can't schedule a DFG compile for a code block until that code
block is in baseline.
This uses the simplest fix: if we are thinking about scheduling some compile and the
thread is busy, do the compile on the main thread instead. This doesn't completely
eliminate the ai-astar regression (we still have a 4% regression on that test) but it now
results in concurrent baseline JIT being an overall progression on Kraken as a whole (1%
on my machine). This is because concurrent baseline appears to help on other tests.
In the future, we could fix this even better by allowing the JITWorklist to spawn more
threads or by being smarter about baseline compilation. I think it's nasty that if a giant
piece of initialization code ends in a compute loop, we compile all of the code instead of
just the loop. It's also gross that a constant-like object creation expression will result
in so much code. It would result in less code if we allowed ourselves to do a bit more
static reasoning about object literals.
But for now, I think that this is a great way to recover the Kraken regression while still
keeping the other progressions from concurrent baseline.
- jit/JITWorklist.cpp:
(JSC::JITWorklist::Plan::Plan):
(JSC::JITWorklist::Plan::compileInThread):
(JSC::JITWorklist::Plan::finalize):
(JSC::JITWorklist::Plan::codeBlock):
(JSC::JITWorklist::Plan::isFinishedCompiling):
(JSC::JITWorklist::Plan::compileNow):
(JSC::JITWorklist::JITWorklist):
(JSC::JITWorklist::compileLater):
(JSC::JITWorklist::compileNow):
(JSC::JITWorklist::runThread):
(JSC::JITWorklist::Plan::isFinalized): Deleted.
- jit/JITWorklist.h:
- 9:28 AM Changeset in webkit [202204] by
-
- 1 edit in trunk/Tools/ChangeLog
Test commit.
Unreviewed.
- 8:54 AM Changeset in webkit [202203] by
-
- 1 edit in trunk/Tools/ChangeLog
Test post-commit after apache restart.
Unreviewed.
- 8:22 AM Changeset in webkit [202202] by
-
- 1 edit in trunk/Tools/ChangeLog
Testing yet another fix for trac-mirror.
Unreviewed.
- 8:16 AM Changeset in webkit [202201] by
-
- 1 edit in trunk/Tools/ChangeLog
Testing another fix for trac-mirror.
Unreviewed.
- 8:10 AM Changeset in webkit [202200] by
-
- 1 edit in trunk/Tools/ChangeLog
Testing fix for trac-mirror.
Unreviewed.
- 7:53 AM Changeset in webkit [202199] by
-
- 1 edit in trunk/Tools/ChangeLog
Test a commit against the SVN 1.9 server upgrade.
Unreviewed.
Jun 18, 2016:
- 4:46 AM Changeset in webkit [202198] by
-
- 16 edits in trunk/Source/WebCore
Use time literals in WebCore
https://bugs.webkit.org/show_bug.cgi?id=158905
Reviewed by Andreas Kling.
std::chrono::milliseconds(1) -> 1ms etc.
- dom/Document.cpp:
(WebCore::Document::minimumLayoutDelay):
(WebCore::Document::elapsedTime):
- fileapi/FileReader.cpp:
(WebCore::FileReader::create):
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::showPaintRect):
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCache::CrossOriginPreflightResultCache):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime):
- page/ChromeClient.h:
- page/DOMTimer.cpp:
(WebCore::DOMTimer::intervalClampedToMinimum):
(WebCore::DOMTimer::alignedFireTime):
- page/DOMTimer.h:
- page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChanged):
- page/ResourceUsageThread.cpp:
(WebCore::ResourceUsageThread::threadBody):
- page/Settings.cpp:
(WebCore::Settings::Settings):
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::remainingTimeUntilHighlightShouldBeShown):
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::fontForFamily):
- platform/network/CacheValidation.cpp:
(WebCore::computeCurrentAge):
(WebCore::computeFreshnessLifetimeForHTTPFamily):
Jun 17, 2016:
- 10:53 PM Changeset in webkit [202197] by
-
- 21 edits8 adds1 delete in trunk
:indeterminate pseudo-class should match radios whose group has no checked radio
https://bugs.webkit.org/show_bug.cgi?id=156270
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/selectors/pseudo-classes/indeterminate-expected.txt:
One more pass on official tests :)
Source/WebCore:
The pseudo-class ":indeterminate" is supposed to match radio buttons
for which the entire group has no checked button.
Spec: https://html.spec.whatwg.org/#pseudo-classes:selector-indeterminate
The change is straightforward with one non-obvious choice:
I added matchesIndeterminatePseudoClass() in addition to shouldAppearIndeterminate().
The reason is shouldAppearIndeterminate() is used for styling and AX of elements
with an indeterminate states (check boxes and progress element). There is no such
UI for radio boxes.
I could have extended shouldAppearIndeterminate() to radio box
then filter out this case in RenderTheme. The problem is doing that would also requires
changes to the repaint logic to match :indeterminate. It seemed overkill to me to
change repaint() for a case that is never used in practice.
Tests: fast/css/pseudo-indeterminate-radio-buttons-basics.html
fast/css/pseudo-indeterminate-with-radio-buttons-style-invalidation.html
fast/selectors/detached-radio-button-checked-and-indeterminate-states.html
fast/selectors/pseudo-indeterminate-with-radio-buttons-style-update.html
- css/SelectorCheckerTestFunctions.h:
(WebCore::shouldAppearIndeterminate):
- dom/Element.cpp:
(WebCore::Element::matchesIndeterminatePseudoClass):
- dom/Element.h:
- dom/RadioButtonGroups.cpp:
(WebCore::RadioButtonGroup::setCheckedButton):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::setNeedsStyleRecalcForAllButtons):
(WebCore::RadioButtonGroups::hasCheckedButton):
- dom/RadioButtonGroups.h:
- html/CheckboxInputType.cpp:
(WebCore::CheckboxInputType::matchesIndeterminatePseudoClass):
(WebCore::CheckboxInputType::shouldAppearIndeterminate):
(WebCore::CheckboxInputType::supportsIndeterminateAppearance): Deleted.
- html/CheckboxInputType.h:
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::matchesIndeterminatePseudoClass):
(WebCore::HTMLInputElement::shouldAppearIndeterminate):
(WebCore::HTMLInputElement::radioButtonGroups):
- html/HTMLInputElement.h:
- html/InputType.cpp:
(WebCore::InputType::matchesIndeterminatePseudoClass):
(WebCore::InputType::shouldAppearIndeterminate):
(WebCore::InputType::supportsIndeterminateAppearance): Deleted.
- html/InputType.h:
- html/RadioInputType.cpp:
(WebCore::RadioInputType::matchesIndeterminatePseudoClass):
(WebCore::RadioInputType::willDispatchClick): Deleted.
(WebCore::RadioInputType::didDispatchClick): Deleted.
(WebCore::RadioInputType::supportsIndeterminateAppearance): Deleted.
The iOS specific code is just plain wrong.
It was changing the indeterminate state of the input element.
The spec clearly says that state is only used by checkbox:
https://html.spec.whatwg.org/#dom-input-indeterminate
Moreover, the style update would not change the indeterminate state
of other buttons in the Button Group, which is just bizarre.
RenderThemeIOS does not make use of any of this with the current style.
- html/RadioInputType.h:
- style/StyleSharingResolver.cpp:
(WebCore::Style::SharingResolver::canShareStyleWithElement):
(WebCore::Style::canShareStyleWithControl): Deleted.
(WebCore::Style::SharingResolver::sharingCandidateHasIdenticalStyleAffectingAttributes): Deleted.
Style sharing is unified behind the selector matching which is neat.
LayoutTests:
There are two important aspect to cover for this change:
1) The style is updated correctly when a Button Group composition change.
2) When the checkness changes for a Button Group, all its elements
are invalidated to match :indeterminate.
- fast/forms/radio/indeterminate-radio.html:
This test was verifying that the property "indeterminate" of the input element
is not reflected to the style through :indeterminate.
I updated the test to still verify that except that we now match :indeterminate
before changing the property.
- fast/css/pseudo-indeterminate-radio-buttons-basics-expected.html: Added.
- fast/css/pseudo-indeterminate-radio-buttons-basics.html: Added.
- fast/css/pseudo-indeterminate-with-radio-buttons-style-invalidation-expected.txt: Added.
- fast/css/pseudo-indeterminate-with-radio-buttons-style-invalidation.html: Added.
Verify that we don't invalidate everything when the checked button changes.
We only need to invalidate everything if the checked state of the whole group changes.
- fast/selectors/detached-radio-button-checked-and-indeterminate-states-expected.txt: Added.
- fast/selectors/detached-radio-button-checked-and-indeterminate-states.html: Added.
- fast/selectors/pseudo-indeterminate-with-radio-buttons-style-update-expected.txt: Added.
- fast/selectors/pseudo-indeterminate-with-radio-buttons-style-update.html: Added.
- 8:33 PM Changeset in webkit [202196] by
-
- 21 edits2 deletes in trunk
Unreviewed, rolling out r202152.
https://bugs.webkit.org/show_bug.cgi?id=158897
The new test is very unstable, timing out frequently
(Requested by ap on #webkit).
Reverted changeset:
"Web Inspector: console.profile should use the new Sampling
Profiler"
https://bugs.webkit.org/show_bug.cgi?id=153499
http://trac.webkit.org/changeset/202152
- 8:29 PM Changeset in webkit [202195] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r202068, r202115, and r202128.
https://bugs.webkit.org/show_bug.cgi?id=158896
The new test is very unstable, timing out frequently
(Requested by ap on #webkit).
Reverted changesets:
"decompose4 return value is unchecked, leading to potentially
uninitialized data."
https://bugs.webkit.org/show_bug.cgi?id=158761
http://trac.webkit.org/changeset/202068
"[mac] LayoutTest transforms/undecomposable.html is a flaky
timeout"
https://bugs.webkit.org/show_bug.cgi?id=158816
http://trac.webkit.org/changeset/202115
"[mac] LayoutTest transforms/undecomposable.html is a flaky
timeout"
https://bugs.webkit.org/show_bug.cgi?id=158816
http://trac.webkit.org/changeset/202128
- 6:19 PM Changeset in webkit [202194] by
-
- 4 edits2 adds in trunk
AX: HTML indeterminate IDL attribute not mapped to checkbox value=2 for native checkboxes
https://bugs.webkit.org/show_bug.cgi?id=158876
<rdar://problem/26842619>
Reviewed by Joanmarie Diggs.
Source/WebCore:
The indeterminate state was not being reported for native checkboxes.
Also the isIndeterminate() method was relying on whether the appearance changed, which does not happen on Mac, so that
was not being reported correctly. Changed that to check the actual attribute.
Test: accessibility/checkbox-mixed-value.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isIndeterminate):
(WebCore::AccessibilityNodeObject::isPressed):
(WebCore::AccessibilityNodeObject::checkboxOrRadioValue):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
LayoutTests:
- accessibility/checkbox-mixed-value-expected.txt: Added.
- accessibility/checkbox-mixed-value.html: Added.
- 6:09 PM Changeset in webkit [202193] by
-
- 3 edits2 copies in branches/safari-601-branch
Merged r202174. rdar://problem/26701322
- 6:06 PM Changeset in webkit [202192] by
-
- 4 edits2 adds in trunk
REGRESSION (r199819): CrashTracer: [GraphicsContext3D::getInternalFramebufferSize
https://bugs.webkit.org/show_bug.cgi?id=158895
<rdar://problem/26423617>
Reviewed by Zalan Bujtas.
Source/WebCore:
In r199819 we started resetting contexts if the page had too
many. Unfortunately there were entry points in the WebGL context
that didn't check for the validity of the object before trying
to access the lower level objects.
Test: webgl/many-contexts-access-after-loss.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::drawingBufferWidth): Return 0 if we're lost.
(WebCore::WebGLRenderingContextBase::drawingBufferHeight): Ditto.
LayoutTests:
New test to access the contexts after loss. Also cleaned
up the JavaScript code in the existing test (and made sure
it ran outside of the test system).
- webgl/many-contexts-access-after-loss-expected.txt: Added.
- webgl/many-contexts-access-after-loss.html: Added.
- webgl/many-contexts.html:
- 6:05 PM Changeset in webkit [202191] by
-
- 3 edits2 copies in branches/safari-601.1.46-branch
Merged r202174. rdar://problem/26701284
- 6:03 PM Changeset in webkit [202190] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r202186.
Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
builds.
Reverted changeset:
"File scheme should not allow access of a resource on a
different volume."
https://bugs.webkit.org/show_bug.cgi?id=158552
http://trac.webkit.org/changeset/202186
- 6:02 PM Changeset in webkit [202189] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r202187.
202186
Reverted changeset:
"Unreviewed clean-up after r202186."
http://trac.webkit.org/changeset/202187
- 5:25 PM Changeset in webkit [202188] by
-
- 4 edits in trunk/Source
Optimize parseCacheHeader() by using StringView
https://bugs.webkit.org/show_bug.cgi?id=158891
Reviewed by Darin Adler.
Source/WebCore:
Optimize parseCacheHeader() and avoid some temporary String allocations
by using StringView. We now strip the whitespaces in the input string
at the beginning of the function, at the same as as we strip the
control characters. We are then able to leverage StringView in the
rest of the function to get substrings without the need for extra
String allocations.
- platform/network/CacheValidation.cpp:
(WebCore::isControlCharacterOrSpace):
(WebCore::trimToNextSeparator):
(WebCore::parseCacheHeader):
Source/WTF:
Add a StringView::find() overload which takes a CharacterMatchFunction
to match the one on String.
- wtf/text/StringView.h:
(WTF::StringView::find):
- 5:09 PM Changeset in webkit [202187] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed clean-up after r202186.
- platform/FileSystem.cpp:
(WebCore::filesHaveSameVolume): Don't use C-style formatting.
- 5:03 PM Changeset in webkit [202186] by
-
- 6 edits2 adds in trunk
File scheme should not allow access of a resource on a different volume.
https://bugs.webkit.org/show_bug.cgi?id=158552
<rdar://problem/15307582>
Patch by Pranjal Jumde <pjumde@apple.com> on 2016-06-17
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: Tools/TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canDisplay):
- platform/FileSystem.cpp:
(WebCore::platformFileStat):
(WebCore::filesHaveSameVolume):
Returns true if the files are on the same volume
- platform/FileSystem.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
- TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
(-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
When the main page load is complete fetch the contents of the document to check if iframe was loaded
(createPartition):
Create a disk image and load the contents of the file.
(cleanUp):
(TestWebKitAPI::TEST):
- 4:31 PM Changeset in webkit [202185] by
-
- 15 edits in trunk/Source/WebKit2
Support configurable autocapitalization.
https://bugs.webkit.org/show_bug.cgi?id=158860
rdar://problem/26231403
Reviewed by Tim Horton.
The behavior of spellchecker should be configurable to avoid
unwanted autocapitalization.
- UIProcess/API/APIPageConfiguration.cpp:
(API::PageConfiguration::copy):
- UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::initialCapitalizationEnabled):
(API::PageConfiguration::setInitialCapitalizationEnabled):
- UIProcess/API/C/WKPageConfigurationRef.cpp:
(WKPageConfigurationSetIntialCapitalizationEnabled):
- UIProcess/API/C/WKPageConfigurationRef.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _initialCapitalizationEnabled]):
(-[WKWebViewConfiguration _setInitialCapitalizationEnabled:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- UIProcess/TextChecker.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::getGuessesForWord):
- UIProcess/WebPageProxy.h:
- UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::getGuessesForWord):
- UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::checkTextOfParagraph):
- UIProcess/ios/TextCheckerIOS.mm:
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::getGuessesForWord):
- UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::getGuessesForWord):
- 4:27 PM Changeset in webkit [202184] by
-
- 14 edits in trunk/Source/WebKit2
Use WTF::NoncopyableFunction in NetworkDataTaskClient
https://bugs.webkit.org/show_bug.cgi?id=158887
Reviewed by Alex Christensen.
Use WTF::NoncopyableFunction in NetworkDataTaskClient instead of std::function
and consistently move it around. This avoids some unnecessary copying.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::willDecidePendingDownloadDestination):
(WebKit::DownloadManager::continueDecidePendingDownloadDestination):
- NetworkProcess/Downloads/DownloadManager.h:
- NetworkProcess/NetworkDataTask.h:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::willPerformHTTPRedirection):
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didReceiveResponseNetworkSession):
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::findPendingDownloadLocation):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/PingLoad.h:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTask::didReceiveChallenge):
(WebKit::NetworkDataTask::didReceiveResponse):
(WebKit::NetworkDataTask::willPerformHTTPRedirection):
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::addChallengeToChallengeMap):
(WebKit::AuthenticationManager::coalesceChallengesMatching):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
- 3:24 PM Changeset in webkit [202183] by
-
- 34 edits1 move2 adds in trunk
Web video playback controls should have RTL volume slider
https://bugs.webkit.org/show_bug.cgi?id=158856
<rdar://problem/25971769>
Patch by Antoine Quint <Antoine Quint> on 2016-06-17
Reviewed by Tim Horton.
Source/WebCore:
We reproduce the system used to propagate the page scale factor from the WebPage to the media controls to
propagate the user interface layout direction.
The Page exposes a new setUserInterfaceLayoutDirection() method which is set by the WebPage. The Page
then notifies the Document of a change, which propagates down to registered media elements, and finally sets
the usesLTRUserInterfaceLayoutDirection property on the media controller object in the injected JavaScript.
Based on the value of that property we toggle a new .uses-ltr-user-interface-layout-direction CSS class on the
.volume-box which applies a translate to the right and flips the volume controls on the x axis.
Since we're setting a new JS property from HTMLMediaController, we refactor much of the code out of the existing
pageScaleFactorChanged() and setPageScaleFactorProperty() into the new setControllerJSProperty() method so that
can easily set a named JS property with a given JSValue.
For testing purposes, we expose the WebCore::Page::setUserInterfaceLayoutDirection() method through Internals.
Test: fullscreen/video-controls-rtl.html
- Modules/mediacontrols/mediaControlsApple.css:
(video:-webkit-full-screen::-webkit-media-controls-panel .volume-box:not(.uses-ltr-user-interface-layout-direction)):
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.set usesLTRUserInterfaceLayoutDirection):
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::registerForUserInterfaceLayoutDirectionChangedCallbacks):
(WebCore::Document::unregisterForUserInterfaceLayoutDirectionChangedCallbacks):
(WebCore::Document::userInterfaceLayoutDirectionChanged):
- dom/Document.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument):
(WebCore::HTMLMediaElement::unregisterWithDocument):
(WebCore::HTMLMediaElement::updatePageScaleFactorJSProperty):
(WebCore::HTMLMediaElement::updateUsesLTRUserInterfaceLayoutDirectionJSProperty):
(WebCore::HTMLMediaElement::setControllerJSProperty):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::pageScaleFactorChanged):
(WebCore::HTMLMediaElement::userInterfaceLayoutDirectionChanged):
(WebCore::setPageScaleFactorProperty): Deleted.
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::Page::setUserInterfaceLayoutDirection):
- page/Page.h:
(WebCore::Page::userInterfaceLayoutDirection):
- platform/UserInterfaceLayoutDirection.h: Renamed from Source/WebKit2/UIProcess/UserInterfaceLayoutDirection.h.
- testing/Internals.cpp:
(WebCore::Internals::setUserInterfaceLayoutDirection):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
We now call setUserInterfaceLayoutDirection() on WebCore::Page to propagate
the user interface layout direction down to the Web content. To facilitate this,
the UserInterfaceLayoutDirection enum is now defined in WebCore.
- Shared/WebPageCreationParameters.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(convertSystemLayoutDirection):
(toUserInterfaceLayoutDirection):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::toUserInterfaceLayoutDirection):
(WebKit::WebViewImpl::userInterfaceLayoutDirection):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::userInterfaceLayoutDirection):
(WebKit::WebPageProxy::setUserInterfaceLayoutDirection):
- UIProcess/WebPageProxy.h:
- UIProcess/efl/WebView.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::userInterfaceLayoutDirection):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::userInterfaceLayoutDirection):
- UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::PendingSwipeTracker::scrollEventCanBecomeSwipe):
(WebKit::ViewGestureController::isPhysicallySwipingLeft):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_userInterfaceLayoutDirection):
(WebKit::WebPage::setUserInterfaceLayoutDirection):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performNonEditingBehaviorForSelector):
LayoutTests:
New test that checks that the volume box has the correct CSS class name and the expected
CSS transform value applied to it when the user interface layout direction is right-to-left
and that changing the user interface layout direction dynamically update the media element
shadow tree as expected.
- fullscreen/video-controls-rtl-expected.txt: Added.
- fullscreen/video-controls-rtl.html: Added.
- 2:46 PM Changeset in webkit [202182] by
-
- 2 edits in trunk/LayoutTests
Update LayoutTest fast/canvas/canvas-composite-text-alpha.html
https://bugs.webkit.org/show_bug.cgi?id=158710
Reviewed by Alexey Proskuryakov.
Though this test passes, opening the test file directly reports multiple failures. Updating the
readback locations to get the correct results.
- fast/canvas/canvas-composite-text-alpha.html:
- 2:46 PM Changeset in webkit [202181] by
-
- 2 edits in trunk/LayoutTests
Marking media/video-controls-show-on-kb-or-ax-event.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=158889
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:30 PM Changeset in webkit [202180] by
-
- 2 edits in trunk/LayoutTests
Skip security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html on Mac
https://bugs.webkit.org/show_bug.cgi?id=155196
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:21 PM Changeset in webkit [202179] by
-
- 3 edits2 adds in trunk
REGRESSION: Double tap to zoom does not work on yahoo finance
https://bugs.webkit.org/show_bug.cgi?id=158886
<rdar://problem/24917760>
Reviewed by Simon Fraser.
Source/WebKit2:
We shouldn't enable fast click on pages that have
had to shrink to fit. In other words, we should enable
double-tap-to-zoom if the page has already zoomed.
Test: fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allowsDoubleTapGestures]):
LayoutTests:
- fast/events/ios/viewport-shrink-to-fit-allows-double-tap-expected.txt: Added.
- fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html: Added.
- 1:51 PM Changeset in webkit [202178] by
-
- 7 edits2 adds in trunk
TouchEvent should have a constructor
https://bugs.webkit.org/show_bug.cgi?id=158883
<rdar://problem/26063585>
Reviewed by Benjamin Poulain.
Source/WebCore:
TouchEvent should have a constructor:
Chrome already ships this:
Test: fast/events/touch/touch-event-constructor.html
- bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
- bindings/js/JSDictionary.h:
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
- dom/TouchEvent.h:
- dom/TouchEvent.idl:
LayoutTests:
Add layout test coverage for the TouchEvent constructor.
- fast/events/touch/touch-event-constructor-expected.txt: Added.
- fast/events/touch/touch-event-constructor.html: Added.
- 1:21 PM Changeset in webkit [202177] by
-
- 3 edits in trunk/Source/WebCore
Potential null dereferencing on a detached positioned renderer.
https://bugs.webkit.org/show_bug.cgi?id=158879
Reviewed by Simon Fraser.
This patch fixes the case when the while loop to search for the absolute positioned ancestor
returns null (it happens when positioned renderer has been detached from the render tree).
Speculative fix.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
- rendering/RenderBlock.h:
- 1:18 PM Changeset in webkit [202176] by
-
- 9 edits in trunk
URL hash setter does not remove fragment identifier if argument is an empty string
https://bugs.webkit.org/show_bug.cgi?id=158869
<rdar://problem/26863430>
Reviewed by Darin Adler.
Source/WebCore:
URL hash setter and URLUtils hash setter should remove the fragment identifier
if set to "#" or "":
- https://url.spec.whatwg.org/#dom-url-hash
- https://html.spec.whatwg.org/multipage/semantics.html#dom-hyperlink-hash
This patch aligns our behavior with the specification and with other browsers
(tested Firefox and Chrome).
This patch also updates HTMLAnchorElement to inherit URLUtils to avoid code
duplication. HTMLAnchorElement already implements URLUtils in the IDL, as per
the specification:
No new tests, rebaselined existing tests.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::origin): Deleted.
(WebCore::HTMLAnchorElement::text): Deleted.
(WebCore::HTMLAnchorElement::setText): Deleted.
(WebCore::HTMLAnchorElement::toString): Deleted.
(WebCore::HTMLAnchorElement::isLiveLink): Deleted.
(WebCore::HTMLAnchorElement::sendPings): Deleted.
(WebCore::HTMLAnchorElement::handleClick): Deleted.
(WebCore::HTMLAnchorElement::eventType): Deleted.
(WebCore::HTMLAnchorElement::treatLinkAsLiveForEventType): Deleted.
(WebCore::isEnterKeyKeydownEvent): Deleted.
(WebCore::shouldProhibitLinks): Deleted.
(WebCore::HTMLAnchorElement::willRespondToMouseClickEvents): Deleted.
(WebCore::rootEditableElementMap): Deleted.
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown): Deleted.
(WebCore::HTMLAnchorElement::clearRootEditableElementForSelectionOnMouseDown): Deleted.
(WebCore::HTMLAnchorElement::setRootEditableElementForSelectionOnMouseDown): Deleted.
- html/HTMLAnchorElement.h:
(WebCore::HTMLAnchorElement::invalidateCachedVisitedLinkHash): Deleted.
- html/URLUtils.h:
(WebCore::URLUtils<T>::setHash):
LayoutTests:
Update existing layout tests now that setting hash to "" or "#" clears
the fragment identifier.
- fast/dom/DOMURL/set-href-attribute-hash-expected.txt:
- fast/dom/DOMURL/set-href-attribute-hash.html:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-hash.js:
- fast/dom/HTMLAnchorElement/set-href-attribute-hash-expected.txt:
- 12:51 PM Changeset in webkit [202175] by
-
- 5 edits4 copies in branches/safari-601-branch
Merged r202151. rdar://problem/26701322
- 12:50 PM Changeset in webkit [202174] by
-
- 3 edits2 adds in trunk
Ignore case in the check for security origin inheritance
https://bugs.webkit.org/show_bug.cgi?id=158878
Reviewed by Alex Christensen.
Source/WebCore:
Darin Adler commented in https://bugs.webkit.org/show_bug.cgi?id=158855:
"Are these comparisons intentionally case sensitive? Shouldn’t they ignore ASCII
case? We could use equalIgnoringASCIICase and equalLettersIgnoringASCIICase for
those two lines instead of using ==. URL::parse normalizes letters in the scheme
and host by using toASCIILower, but does not normalize letters elsewhere in the
URL, such as in the "blank" or "srcdoc" in the above URLs."
Test: http/tests/dom/window-open-about-uppercase-blank-and-access-document.html
- platform/URL.cpp:
(WebCore::URL::shouldInheritSecurityOriginFromOwner):
LayoutTests:
- http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt: Added.
- http/tests/dom/window-open-about-uppercase-blank-and-access-document.html: Added.
- 12:22 PM Changeset in webkit [202173] by
-
- 3 edits in trunk/Source/WTF
OOM Assertion failure in JSON.stringify.
https://bugs.webkit.org/show_bug.cgi?id=158794
<rdar://problem/26826254>
Reviewed by Saam Barati.
The bug was actually in StringBuilder::appendQuotedJSONString() where it failed
to detect an imminent unsigned int overflow. The fix is to use Checked<unsigned>
for the needed math, and RELEASE_ASSERT afterwards that we did not overflow.
I also added more assertions to detect sooner if any there are any problems with
StringBuilder's m_buffer or m_length being incorrectly sized. These assertions
have been run on the JSC and layout tests without any issue.
- wtf/text/StringBuilder.cpp:
(WTF::StringBuilder::resize):
(WTF::StringBuilder::allocateBuffer):
(WTF::StringBuilder::allocateBufferUpConvert):
(WTF::StringBuilder::reallocateBuffer<LChar>):
(WTF::StringBuilder::reallocateBuffer<UChar>):
(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append):
(WTF::StringBuilder::appendQuotedJSONString):
- wtf/text/StringBuilder.h:
(WTF::StringBuilder::swap):
- 12:10 PM Changeset in webkit [202172] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation errors when we enable DUMP_NODE_STATISTICS in Node.h
https://bugs.webkit.org/show_bug.cgi?id=158868
Reviewed by Alex Christensen.
Fix compilation errors in Node.cpp when we enable DUMP_NODE_STATISTICS
- dom/Node.cpp:
(WebCore::Node::dumpStatistics):
- 11:47 AM Changeset in webkit [202171] by
-
- 5 edits4 copies in branches/safari-601.1.46-branch
Merged r202151. rdar://problem/26701284
- 10:24 AM Changeset in webkit [202170] by
-
- 2 edits in trunk/LayoutTests
Skipping two new LayoutTests that rely on mouse events on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=158855
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 10:20 AM Changeset in webkit [202169] by
-
- 2 edits in trunk/Source/WebCore
[Win] Scrolling in popup menu scrolls past last entry.
https://bugs.webkit.org/show_bug.cgi?id=158870
Reviewed by Brent Fulgham.
When the popup has a scrollbar, the content size is not equal to the popup window size.
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::contentsSize):
- 9:54 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 9:54 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 9:53 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 9:30 AM Changeset in webkit [202168] by
-
- 27 edits1 add4 deletes in trunk
Refactor RenderMathMLRoot layout function to avoid using flexbox
https://bugs.webkit.org/show_bug.cgi?id=153987
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-17
Reviewed by Brent Fulgham.
Source/WebCore:
No new tests, already covered by existing tests.
A case for RTL root has been added to roots.xhtml.
We reimplement RenderMathMLRoot without any flexbox or anonymous.
The anonymous RenderMathMLRadicalOperator used to draw the radical sign is replaced with
the MathOperator class introduced in bug 152244.
msqrt (row of children under a square root) is now implemented directly in RenderMathMLRoot,
so RenderMathMLSquareRoot is removed and RenderMathMLRoot now inherits from RenderMathMLRow.
- CMakeLists.txt: Remove files for RenderMathMLRadicalOperator and RenderMathMLSquareRoot.
- WebCore.xcodeproj/project.pbxproj: ditto.
- accessibility/AccessibilityRenderObject.cpp: Update code now that we do not use any
radical wrappers.
(WebCore::AccessibilityRenderObject::isMathRow): Now that RenderMathMLRoot inherits from
RenderMathMLRow, we must exclude MathRoot or otherwise some accessibility code may treat
roots as rows.
(WebCore::AccessibilityRenderObject::mathRadicandObject): Return the first child for
Root/SquareRoot or nullptr.
(WebCore::AccessibilityRenderObject::mathRootIndexObject): Return the second child for
Root and nullptr for SquareRoot.
- mathml/MathMLInlineContainerElement.cpp:
(WebCore::MathMLInlineContainerElement::childrenChanged): We no longer need a special case
for msqrt, it is treated as a normal RenderMathMLRow.
(WebCore::MathMLInlineContainerElement::createElementRenderer): Make msqrt create a
RenderMathMLRoot object.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderMathMLRadicalOperator): Deleted.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::mirrorIfNeeded): New function to mirror a child horizontal
offset according to the parent width.
(WebCore::RenderMathMLBlock::renderName):
- rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLBlock::mirrorIfNeeded): Moved from RenderMathMLScripts, just forward
call to the other mirrorIfNeeded function.
- rendering/mathml/RenderMathMLOperator.cpp: We no longer need this trailingSpaceError hack.
(WebCore::RenderMathMLOperator::trailingSpaceError): Deleted.
- rendering/mathml/RenderMathMLOperator.h: ditto.
- rendering/mathml/RenderMathMLRadicalOperator.cpp: Removed. The radical sign is now drawn
with a MathOperator.
- rendering/mathml/RenderMathMLRadicalOperator.h: Removed.
- rendering/mathml/RenderMathMLRoot.cpp: Complete refactoring to avoid using flexbox and
anonymous wrappers.
(WebCore::RenderMathMLRoot::RenderMathMLRoot): Set m_kind parameters to distinguish between
square root and general root and set the MathOperator member to draw the radical sign.
(WebCore::RenderMathMLRoot::isValid): Helper function to verify whether the child list is valid.
(WebCore::RenderMathMLRoot::getBase): Get the base of an mroot.
(WebCore::RenderMathMLRoot::getIndex): Get the index of an mroot.
(WebCore::RenderMathMLRoot::styleDidChange): Be sure to keep the style of the
MathOperator in sync with ours ; no need to skip empty roots.
(WebCore::RenderMathMLRoot::updateFromElement): Call the function from the new parent class ;
no need to skip empty roots.
(WebCore::RenderMathMLRoot::updateStyle): Remove the isEmpty ASSERT as it is valid to have
empty square root. Set the m_kernBeforeDegree, m_kernBeforeDegree members.
No need to set style for anonymous.
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Implement this function.
(WebCore::RenderMathMLRoot::layoutBlock): Implement this function.
(WebCore::RenderMathMLRoot::paintChildren): Implement this function.
(WebCore::RenderMathMLRoot::paint): Remove the trailingSpaceError hack ;
paint the radical sign via MathOperator::paint
(WebCore::RenderMathMLRoot::baseWrapper): Deleted.
(WebCore::RenderMathMLRoot::radicalWrapper): Deleted.
(WebCore::RenderMathMLRoot::indexWrapper): Deleted.
(WebCore::RenderMathMLRoot::radicalOperator): Deleted.
(WebCore::RenderMathMLRoot::restructureWrappers): Deleted.
(WebCore::RenderMathMLRoot::addChild): Deleted.
(WebCore::RenderMathMLRoot::firstLineBaseline): Deleted.
(WebCore::RenderMathMLRoot::layout): Deleted.
(WebCore::RenderMathMLRootWrapper::createAnonymousWrapper): Deleted.
(WebCore::RenderMathMLRootWrapper::removeChildWithoutRestructuring): Deleted.
(WebCore::RenderMathMLRootWrapper::removeChild): Deleted.
- rendering/mathml/RenderMathMLRoot.h: Make RenderMathMLRoot inherit from RenderMathMLRow.
Make RenderMathMLRoot support <msqrt>.
Remove all the anonymous wrapper stuff and instead use a MathOperator for the radical symbol.
Update function declaration to implement layout without flexbox and add some helper functions.
- rendering/mathml/RenderMathMLRow.cpp: Allow to get the exact metrics of the chid row,
for use in RenderMathMLRoot.
(WebCore::RenderMathMLRow::computeLineVerticalStretch): rename parameters.
(WebCore::RenderMathMLRow::layoutRowItems): Set parameters to the final ascent, descent and
logical width of the chid row. Set the temporary logical width for RenderMathRoot before
laying the children out.
(WebCore::RenderMathMLRow::layoutBlock): Rename parameters ; add a dummy logicalWidth
parameter.
- rendering/mathml/RenderMathMLRow.h: Make some functions accessible or overridable by
RenderMathMLRoot. Make layoutRowItems return the final ascent, descent and logical width
after the chid row is laid out.
- rendering/mathml/RenderMathMLScripts.cpp: Move mirrorIfNeeded to RenderMathMLBlock.
(WebCore::RenderMathMLScripts::mirrorIfNeeded): Deleted.
- rendering/mathml/RenderMathMLScripts.h: Move mirrorIfNeeded to RenderMathMLBlock.
- rendering/mathml/RenderMathMLSquareRoot.cpp: Removed.
- rendering/mathml/RenderMathMLSquareRoot.h: Removed.
- rendering/mathml/MathOperator.cpp:
(WebCore::MathOperator::paint): Apply a mirroring scale transform to radical symbol
in RTL direction.
LayoutTests:
Update expectations for some MathML tests containing radical operators.
- TestExpectations: mathml/roots-removeChild.html works as expected now
that we do not manage anonymous wrappers anymore.
- mathml/presentation/roots.xhtml: Add one test for RTL roots.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: Update expectation to
take into change in the render tree.
- platform/gtk/mathml/presentation/roots-expected.txt: Ditto.
- platform/gtk/mathml/presentation/roots-expected.png: Update expectation to take
into account small rendering changes.
- platform/ios-simulator/mathml/presentation/roots-expected.txt: Ditto.
- platform/gtk/mathml/radical-fallback-expected.txt: Ditto.
- platform/gtk/mathml/radical-fallback-expected.png: Ditto.
- platform/mac/mathml/radical-fallback-expected.txt: Ditto.
- platform/mac/mathml/radical-fallback-expected.png: Ditto.
- platform/ios-simulator/mathml/radical-fallback-expected.txt: Ditto.
- platform/ios-simulator/mathml/radical-fallback-expected.png: Added.
- 8:43 AM Changeset in webkit [202167] by
-
- 33 edits1 add in trunk/Source/WebCore
Drop some unnecessary header includes
https://bugs.webkit.org/show_bug.cgi?id=158864
Reviewed by Alexey Proskuryakov.
Drop some unnecessary header includes to try and reduce build times.
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AccessibilityList.cpp:
- css/CSSComputedStyleDeclaration.cpp:
- css/MediaQueryMatcher.cpp:
- css/StyleMedia.cpp:
- css/TransformFunctions.cpp:
- dom/NodeRenderStyle.h:
- dom/PseudoElement.h:
(isType): Deleted.
- html/HTMLTitleElement.cpp:
- html/shadow/MediaControlElementTypes.h:
- html/shadow/MediaControls.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorPageAgent.cpp:
- page/scrolling/AsyncScrollingCoordinator.cpp:
- page/scrolling/ScrollingCoordinator.h:
- rendering/BidiRun.h:
- rendering/BorderEdge.h:
- rendering/RenderElement.h:
- rendering/RenderObject.h:
(WebCore::AnnotatedRegionValue::operator==): Deleted.
(WebCore::AnnotatedRegionValue::operator!=): Deleted.
- rendering/RenderObjectEnums.h: Added.
- rendering/RenderTheme.h:
- rendering/SimpleLineLayoutFlowContents.h:
- rendering/SimpleLineLayoutTextFragmentIterator.h:
- rendering/TextPainter.h:
- rendering/style/RenderStyle.h:
(WebCore::pseudoElementRendererIsNeeded):
- rendering/style/ShapeValue.cpp:
- rendering/style/ShapeValue.h:
- style/ClassChangeInvalidation.cpp:
- style/ClassChangeInvalidation.h:
- style/InlineTextBoxStyle.h:
- style/StyleUpdate.cpp:
- 6:35 AM Changeset in webkit [202166] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Throw away linked code when navigating to a new page.
<https://webkit.org/b/153851>
Reviewed by Antti Koivisto.
When navigating to a new page, tell JSC to throw out any linked code it has lying around.
Linked code is tied to a specific global object, and as we're creating a new one for the
new page, none of it is useful to us here.
In the event that the user navigates back, the cost of relinking some code will be far
lower than the memory cost of keeping all of it around.
This was in-tree before but was rolled out due to regressing JSBench. It was a slowdown
due to the benchmark harness using top-level navigations to drive the tests.
This new version avoids that problem by only throwing out code if we haven't navigated
in the last 2 seconds. This also prevents excessive work in response to redirects.
I've also moved this into MemoryPressureHandler so we don't make a mess in FrameLoader.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::jettisonExpensiveObjectsOnTopLevelNavigation):
- platform/MemoryPressureHandler.h:
- 4:50 AM Changeset in webkit [202165] by
-
- 2 edits in trunk/Tools
Unreviewed. Added myself to the list of committers.
- Scripts/webkitpy/common/config/contributors.json:
- 4:46 AM Changeset in webkit [202164] by
-
- 2 edits3 deletes in trunk/LayoutTests
Update test-expected file for failing fullscreen test
https://bugs.webkit.org/show_bug.cgi?id=158838
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-06-17
Reviewed by Carlos Garcia Campos.
Used MAC version of the test as the default version since only MAC and
GTK do not skip this test and expect the same result. Removed
test-expected files specific to each port when there was one. Prior to
this patch, GTK test was failing unexpectedly.
- fullscreen/video-controls-override-expected.txt:
- platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
- platform/gtk/fullscreen/video-controls-override-expected.txt: Removed.
- platform/mac/fullscreen/video-controls-override-expected.txt: Removed.
- 4:19 AM Changeset in webkit [202163] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Rendering is not scaled correctly if process is DPI aware.
https://bugs.webkit.org/show_bug.cgi?id=158781
Reviewed by Brent Fulgham.
Scale the root graphics layer with the device scale factor.
- WebView.cpp:
(WebView::setAcceleratedCompositing):
- 3:34 AM Changeset in webkit [202162] by
-
- 13 edits in trunk
CORS preflight with a non-200 response should be a preflight failure
https://bugs.webkit.org/show_bug.cgi?id=111008
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/XMLHttpRequest/data-uri-expected.txt:
Source/WebCore:
Covered by rebased tests.
- Modules/fetch/FetchResponse.h: Making use of ResourceResponse::isSuccessful.
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::validatePreflightResponse): Checking that response status is code is
successful. If not, calling preflight failure callback.
(WebCore::CrossOriginPreflightChecker::startPreflight): Putting in manual redirection mode so that redirection
responses are processed as other responses.
- loader/ResourceLoaderOptions.h:
(WebCore::ResourceLoaderOptions::fetchOptions): Adding a non-const getter and fixing const getter to return a
const reference.
(WebCore::ResourceLoaderOptions::setFetchOptions): Passing options by reference.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isSuccessful): Utility function.
- platform/network/ResourceResponseBase.h:
LayoutTests:
- http/tests/xmlhttprequest/access-control-and-redirects-async-expected.txt:
- http/tests/xmlhttprequest/access-control-and-redirects-async.html:
- http/tests/xmlhttprequest/access-control-basic-get-fail-non-simple-expected.txt:
- http/tests/xmlhttprequest/workers/access-control-basic-get-fail-non-simple-expected.txt:
- 2:27 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 2:24 AM Changeset in webkit [202161] by
-
- 8 edits6 adds in trunk
MathOperator: Add fallback mechanisms for stretching and mirroring radical symbols
https://bugs.webkit.org/show_bug.cgi?id=156836
Source/WebCore:
Patch by Frederic Wang <fwang@igalia.com> on 2016-06-17
Reviewed by Sergio Villar Senin.
Some platforms do not have OpenType MATH fonts pre-installed and thus can not draw stretchy
operators using size variants or glyph assembly. This is especially problematic for the
radical symbol which is used to write roots. Currently, we have some fallback code to draw
that symbol using graphical primitives but it is a bit complex and makes the style of radical
inconsistent with the font used. We solve these issues by just scaling the base glyph via a
scale transform. Such scale transform is also used to mirror the radical symbol so that we
have some support for right-to-left roots until we can do glyph-level mirroring
via the OpenType rtlm feature.
Test: mathml/radical-fallback.html
- rendering/mathml/MathOperator.cpp: Add a constant for the code point U+221A of the radical.
(WebCore::MathOperator::reset): In general, we don't need any vertical scaling for radical
symbols so m_radicalVerticalScale is initialized to 1.
(WebCore::MathOperator::calculateStretchyData): If we don't have a font with a MATH table and we
try streching a radical, then we update the vertical metrics to match the target size and
set m_radicalVerticalScale to the value necessary to make the base glyph scaled to that size.
(WebCore::MathOperator::paint): For a radical operator, we may apply a scale transform of
parameters (radicalHorizontalScale, m_radicalVerticalScale) in order to support RTL
mirroring or vertical stretching.
- rendering/mathml/MathOperator.h: We add a m_radicalVerticalScale member to indicate the
scaling to apply to the base radical glyph when the stretchy fallback is necessary.
(WebCore::MathOperator::isStretched): The operator is also considered stretched when the
m_radicalVerticalScale is applied to the base size.
- rendering/mathml/RenderMathMLRadicalOperator.cpp: Remove code specific to the old fallback mechanism.
- rendering/mathml/RenderMathMLRadicalOperator.h: Ditto.
LayoutTests:
Reviewed by Sergio Villar Senin.
We add a pixel test to verify the result of stretching a radical operator.
We test RTL/LTR direction as well as default/sans-serif font in order to check the fallback code.
- mathml/radical-fallback.html: Added.
- platform/gtk/mathml/radical-fallback-expected.png: Added.
- platform/gtk/mathml/radical-fallback-expected.txt: Added.
- platform/ios-simulator/mathml/radical-fallback-expected.txt: Added.
- platform/mac/mathml/radical-fallback-expected.png: Added.
- platform/mac/mathml/radical-fallback-expected.txt: Added.
- platform/ios-simulator/mathml/presentation/roots.txt: Updated.
