Timeline



Jul 3, 2016:

11:30 PM Changeset in webkit [202800] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebCore

[image-decoders] Make ImageDecoder::size() lazily decode the image if needed to return a valid size
https://bugs.webkit.org/show_bug.cgi?id=159297

Reviewed by Antonio Gomes.

It's otherwise confusing leading to bugs like #159089.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Check the size at the beginning and return early if it's
empty. We no longer need to check the size after calling frameBufferAtIndex().

  • platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::size): Check first is size is available, which lazily decodes the image.
(WebCore::ImageDecoder::scaledSize): Remove const.
(WebCore::ImageDecoder::frameSizeAtIndex): Ditto.

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::size): Ditto.
(WebCore::ICOImageDecoder::frameSizeAtIndex): Ditto.

  • platform/image-decoders/ico/ICOImageDecoder.h:
11:27 PM Changeset in webkit [202799] by pvollan@apple.com
  • 7 edits in trunk/Source

[Win] DLLs are missing version information.
https://bugs.webkit.org/show_bug.cgi?id=159349

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

Run perl version stamp utility.

  • CMakeLists.txt:

Source/WebKit:

WTF will generate autoversion.h in the prebuild step.
Run the perl version stamp utility.

  • CMakeLists.txt:
  • PlatformWin.cmake:

Source/WTF:

Generate autoversion.h in the prebuild step.
Run the perl version stamp utility.

  • wtf/CMakeLists.txt:
10:59 PM Changeset in webkit [202798] by mitz@apple.com
  • 2 edits in trunk

[Xcode] With default verbosity, make(1) output no longer hides environment variable listings
https://bugs.webkit.org/show_bug.cgi?id=159392

Reviewed by Alexey Proskuryakov.

  • Makefile.shared: Pass the -hideShellScriptEnvironment option to xcodebuild instead of piping its output through an ineffective "grep -v setenv",
10:39 PM Changeset in webkit [202797] by Yusuke Suzuki
  • 5 edits
    3 adds in trunk

[JSC] MacroAssemblerX86::branch8 should accept unsigned 8bit value
https://bugs.webkit.org/show_bug.cgi?id=159334

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

As described in branchTest8 functions, byte in TrustedImm32 is not well defined.
So the assertion here should be a little permissive; accepting -128 to 255.

This assertion is originally fired when executing misc-bugs-847389-jpeg2000 benchmark in Debug build.
So this patch includes misc-bugs-847389-jpeg2000 benchmark.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branch8):

  • b3/testb3.cpp:

(JSC::B3::testBranch8WithLoad8ZIndex):
(JSC::B3::run):

LayoutTests:

  • TestExpectations:
  • js/regress/misc-bugs-847389-jpeg2000-expected.txt: Added.
  • js/regress/misc-bugs-847389-jpeg2000.html: Added.
  • js/regress/script-tests/misc-bugs-847389-jpeg2000.js: Added.

(error):
(warn):
(JpxImage.JpxImageClosure.JpxImage):
(JpxImage.JpxImageClosure.JpxImage.prototype.load.JpxImage_load.xhr.onload):
(JpxImage.JpxImageClosure.JpxImage.prototype.load):
(JpxImage.JpxImageClosure.JpxImage.prototype.parse.JpxImage_parse.readUint):
(JpxImage.JpxImageClosure.JpxImage.prototype.parse):
(JpxImage.JpxImageClosure.JpxImage.prototype.parseCodestream):
(JpxImage.JpxImageClosure.readUint32):
(JpxImage.JpxImageClosure.readUint16):
(JpxImage.JpxImageClosure.log2):
(JpxImage.JpxImageClosure.calculateComponentDimensions):
(JpxImage.JpxImageClosure.calculateTileGrids):
(JpxImage.JpxImageClosure.getBlocksDimensions):
(JpxImage.JpxImageClosure.buildPrecincts):
(JpxImage.JpxImageClosure.buildCodeblocks):
(JpxImage.JpxImageClosure.createPacket):
(JpxImage.JpxImageClosure.LayerResolutionComponentPositionIterator.this.nextPacket):
(JpxImage.JpxImageClosure.LayerResolutionComponentPositionIterator):
(JpxImage.JpxImageClosure.ResolutionLayerComponentPositionIterator.this.nextPacket):
(JpxImage.JpxImageClosure.ResolutionLayerComponentPositionIterator):
(JpxImage.JpxImageClosure.buildPackets):
(JpxImage.JpxImageClosure.readBits):
(JpxImage.JpxImageClosure.alignToByte):
(JpxImage.JpxImageClosure.readCodingpasses):
(JpxImage.JpxImageClosure.parseTilePackets):
(JpxImage.JpxImageClosure.copyCoefficients):
(JpxImage.JpxImageClosure.transformTile):
(JpxImage.JpxImageClosure.transformComponents):
(JpxImage.JpxImageClosure.initializeTile):
(JpxImage.JpxImageClosure.):
(JpxImage.JpxImageClosure.TagTree):
(JpxImage.JpxImageClosure.InclusionTree):
(JpxImage.JpxImageClosure.ArithmeticDecoder):
(JpxImage.JpxImageClosure.BitModel):
(JpxImage.JpxImageClosure.Transform):
(JpxImage.JpxImageClosure.IrreversibleTransform):
(JpxImage.JpxImageClosure.ReversibleTransform):
(JpxImage):
(atob):

8:25 PM Changeset in webkit [202796] by commit-queue@webkit.org
  • 5 edits in trunk

[JSC] lookupGetter and lookupSetter should not ignore exceptions
https://bugs.webkit.org/show_bug.cgi?id=159390

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-03
Reviewed by Mark Lam.

Source/JavaScriptCore:

See:
-https://tc39.github.io/ecma262/#sec-object.prototype.__lookupGetter
-https://tc39.github.io/ecma262/#sec-object.prototype.__lookupSetter

They are both supposed to be regular GetOwnProperty?.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

LayoutTests:

  • js/property-getters-and-setters-expected.txt:
  • js/script-tests/property-getters-and-setters.js:

(getter17):
(get getter17):
(getOwnPropertyDescriptor):
(setter18):
(set setter18):

2:36 PM Changeset in webkit [202795] by sbarati@apple.com
  • 4 edits in trunk/Source

BytecodeGenerator::getVariablesUnderTDZ is too conservative
https://bugs.webkit.org/show_bug.cgi?id=159387

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

We were too conservative in the following type of programs:
`
{

{

let x;
...

}
let x;

}
`
We used to report "x" as under TDZ when calling getVariablesUnderTDZ at the
"...", even though "x" is not under TDZ. This patch removes this conservatism
and makes the algorithm precise.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::getVariablesUnderTDZ):

  • bytecompiler/BytecodeGenerator.h:

Source/WTF:

I've templatized SmallPtrSet on its SmallArraySize instead
of it always being 8.

  • wtf/SmallPtrSet.h:

(WTF::SmallPtrSet::SmallPtrSet):
(WTF::SmallPtrSet::add):
(WTF::SmallPtrSet::iterator::operator!=):
(WTF::SmallPtrSet::bucket):

1:01 PM Changeset in webkit [202794] by fred.wang@free.fr
  • 2 edits
    1 add in trunk/LayoutTests

Update windows test expectations for some MathML tests.

Unreviewed test gardening.

  • platform/win/TestExpectations:
  • platform/win/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Added.
12:44 PM Changeset in webkit [202793] by mitz@apple.com
  • 11 edits in trunk/Source/WebKit2

Follow-up to r202789.

Reviewed by Sam Weinig.

Ensure that API that isn’t available at all on a platform is declared under an appropriate
TARGET_OS_* conditional.

  • Shared/API/Cocoa/_WKHitTestResult.h:
  • Shared/API/Cocoa/_WKHitTestResult.mm:
  • Shared/API/Cocoa/_WKHitTestResultInternal.h:
  • UIProcess/API/Cocoa/WKOpenPanelParameters.h:
  • UIProcess/API/Cocoa/WKOpenPanelParameters.mm:
  • UIProcess/API/Cocoa/WKOpenPanelParametersInternal.h:
  • UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.h:
  • UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.mm:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
12:34 PM Changeset in webkit [202792] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should refer to B3 types directly
https://bugs.webkit.org/show_bug.cgi?id=159389

Reviewed by Saam Barati.

When we used LLVM, types were objects that were allocated by the LLVMContext. We had to
remember pointers to them or else call through the C API every time we wanted the type. We
stored the type pointers inside FTL::CommonValues.

But in B3, types are just members of an enum. We don't have to remember pointers to them.

This change replaces all prior uses of things like "m_out.int32" with just "Int32", and
likewise for m_out.boolean, m_out.int64, m_out.intPtr, m_out.floatType, m_out.doubleType,
and m_out.voidType.

We still use FTL::CommonValues for common constants that we have pre-hoisted. Hopefully we
will come up with a better story for those eventually, since that's still kinda ugly.

  • ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::createPhiVariables):
(JSC::FTL::DFG::LowerDFGToB3::compileDoubleRep):
(JSC::FTL::DFG::LowerDFGToB3::compileBooleanToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileCallObjectConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToThis):
(JSC::FTL::DFG::LowerDFGToB3::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToB3::compileStrCat):
(JSC::FTL::DFG::LowerDFGToB3::compileArithMinOrMax):
(JSC::FTL::DFG::LowerDFGToB3::compileArithPow):
(JSC::FTL::DFG::LowerDFGToB3::compileArithRound):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayifyToStructure):
(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByIdWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByValWithThis):
(JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileGetArrayLength):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutGetterSetterById):
(JSC::FTL::DFG::LowerDFGToB3::compilePutAccessorByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPush):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPop):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateScopedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCopyRest):
(JSC::FTL::DFG::LowerDFGToB3::compileGetRestLength):
(JSC::FTL::DFG::LowerDFGToB3::compileNewObject):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArray):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileToPrimitive):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringCharCodeAt):
(JSC::FTL::DFG::LowerDFGToB3::compileStringFromCharCode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileMultiGetByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compilePutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileSwitch):
(JSC::FTL::DFG::LowerDFGToB3::compileIsString):
(JSC::FTL::DFG::LowerDFGToB3::compileIsJSArray):
(JSC::FTL::DFG::LowerDFGToB3::compileIsObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsObjectOrNull):
(JSC::FTL::DFG::LowerDFGToB3::compileIsFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileIsRegExpObject):
(JSC::FTL::DFG::LowerDFGToB3::compileIsTypedArrayView):
(JSC::FTL::DFG::LowerDFGToB3::compileTypeOf):
(JSC::FTL::DFG::LowerDFGToB3::compileIn):
(JSC::FTL::DFG::LowerDFGToB3::compileOverridesHasInstance):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckTypeInfoFlags):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOf):
(JSC::FTL::DFG::LowerDFGToB3::compileInstanceOfCustom):
(JSC::FTL::DFG::LowerDFGToB3::compileCountExecution):
(JSC::FTL::DFG::LowerDFGToB3::compileHasIndexedProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasGenericProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileHasStructureProperty):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToB3::compileGetEnumerableLength):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPropertyEnumerator):
(JSC::FTL::DFG::LowerDFGToB3::compileGetEnumeratorStructurePname):
(JSC::FTL::DFG::LowerDFGToB3::compileGetEnumeratorGenericPname):
(JSC::FTL::DFG::LowerDFGToB3::compileToIndexString):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckStructureImmediate):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileSetFunctionName):
(JSC::FTL::DFG::LowerDFGToB3::numberOrNotCellToInt32):
(JSC::FTL::DFG::LowerDFGToB3::checkInferredType):
(JSC::FTL::DFG::LowerDFGToB3::initializeArrayElements):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::reallocatePropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::getById):
(JSC::FTL::DFG::LowerDFGToB3::compare):
(JSC::FTL::DFG::LowerDFGToB3::compileResolveScope):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDynamicVar):
(JSC::FTL::DFG::LowerDFGToB3::compareEqObjectOrOtherToObject):
(JSC::FTL::DFG::LowerDFGToB3::speculateTruthyObject):
(JSC::FTL::DFG::LowerDFGToB3::nonSpeculativeCompare):
(JSC::FTL::DFG::LowerDFGToB3::stringsEqual):
(JSC::FTL::DFG::LowerDFGToB3::allocateVariableSizedObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::ensureShadowChickenPacket):
(JSC::FTL::DFG::LowerDFGToB3::boolify):
(JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined):
(JSC::FTL::DFG::LowerDFGToB3::contiguousPutByValOutOfBounds):
(JSC::FTL::DFG::LowerDFGToB3::buildSwitch):
(JSC::FTL::DFG::LowerDFGToB3::switchStringSlow):
(JSC::FTL::DFG::LowerDFGToB3::doubleToInt32):
(JSC::FTL::DFG::LowerDFGToB3::sensibleDoubleToInt32):
(JSC::FTL::DFG::LowerDFGToB3::strictInt52ToJSValue):
(JSC::FTL::DFG::LowerDFGToB3::strictInt52ToInt52):
(JSC::FTL::DFG::LowerDFGToB3::unboxInt32):
(JSC::FTL::DFG::LowerDFGToB3::boxInt32):
(JSC::FTL::DFG::LowerDFGToB3::isCellOrMisc):
(JSC::FTL::DFG::LowerDFGToB3::unboxDouble):
(JSC::FTL::DFG::LowerDFGToB3::boxDouble):
(JSC::FTL::DFG::LowerDFGToB3::jsValueToStrictInt52):
(JSC::FTL::DFG::LowerDFGToB3::doubleToStrictInt52):
(JSC::FTL::DFG::LowerDFGToB3::convertDoubleToInt32):
(JSC::FTL::DFG::LowerDFGToB3::callCheck):
(JSC::FTL::DFG::LowerDFGToB3::crash):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::bitCast):

10:47 AM Changeset in webkit [202791] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Ugh. Once again, unreviewed, roll out unintentional commit in r202790.

  • benchmarks/LockFairnessTest.cpp:

(main):

10:46 AM Changeset in webkit [202790] by fpizlo@apple.com
  • 3 edits
    2 adds in trunk/Source

DFG LICM needs to go all-in on the idea that some loops can't be LICMed
https://bugs.webkit.org/show_bug.cgi?id=159388

Reviewed by Mark Lam.

Some time ago I acknowledged that LICM required loops to meet certain requirements that
may get broken by the time we do LICM, like that the terminal of the pre-header is ExitOK.
It used to be that we just ignored that requirement and would hoist anyway, but since
r189126 we've stopped hoisting out of loops that don't have ExitOK. We also added tests
for the case that the pre-header doesn't exist or is invalid.

It turns out that this patch didn't go far enough: even though it made LICM avoid loops
that had an invalid pre-header, the part that updated the AI state in nested loops still
assumed that these loops had valid pre-headers. We would crash in null dereference in
that loop if a nested loop had an invalid pre-header.

The fix is simple: don't update the AI state of nested loops that don't have pre-headers,
since we won't try to hoist out of those loops anyway.

  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::attemptHoist):

  • tests/stress/licm-no-pre-header-nested.js: Added. This would always crash before this fix.

(foo):

  • tests/stress/licm-pre-header-cannot-exit-nested.js: Added. This was a failed attempt at a test, but I figure it's good to have weird code anyway.

(foo):
(valueOf):

10:08 AM Changeset in webkit [202789] by mitz@apple.com
  • 94 edits in trunk/Source/WebKit2

[Cocoa] Adopt modern API availability macros
https://bugs.webkit.org/show_bug.cgi?id=159378

Reviewed by Sam Weinig.

iOS 10 and macOS Sierra introduce new macros for declaring API availability, defined in
CFAvailability.h, including API_AVAILABLE, API_DEPRECATED, and
API_DEPRECATED_WITH_REPLACEMENT. Rather than having positional parameters for macOS and iOS
versions, the new macros take a variable number of function-like parameters, where the
function specifies the platform to which it applies.

To have WebKit2’s postprocessed headers use the new macros, we make the following changes:

  • Replace instances of WK_AVAILABLE(_mac, _ios) with WK_API_AVAILABLE(macosx(_mac), ios(_ios)), eliding a platform if its current availability is NA.
  • Change instances of WK_CLASS_AVAILABLE(_mac, _ios) to WK_CLASS_AVAILABLE(macosx(_mac), ios(_ios)), eliding a platform if its current availability is NA.
  • Replace instances of WK_DEPRECATED(_macIntro, _macDep, _iosIntro, _iosDep, ...) with WK_API_DEPRECATED_WITH_REPLACEMENT(_replacement, macosx(_macIntro, _macDep), ios(_iosIntro, _iosDep)) when there is a one-for-one replacement, and with WK_API_DEPRECATED(_message, macosx(_macIntro, _macDep), ios(_iosIntro, _iosDep)) when the replacement isn’t one-for-one. Again, if the API doesn’t apply to a platform, then it’s elided.
  • Replace instances of WK_CLASS_DEPRECATED with WK_CLASS_DEPRECATED_WITH_REPLACEMENT, following the same rules.
  • Replace instances of the WK_ENUM_* macros with corresponding WK_API_* macros, now that all supported compilers support availability attributes on enum values.
  • Configurations/WebKit.xcconfig: Disable header postprocessing when building for iOS 9.x, which doesn’t have the new macros.
  • mac/postprocess-framework-headers.sh: Handle the new WK_* macros: WK_API_AVAILABLE becomes API_AVAILABLE; WK_API_DEPRECATED(_WITH_REPLACEMENT) become API_DEPRECATED(_WITH_REPLACEMENT); WK_CLASS_AVAILABLE and WK_CLASS_DEPRECATED(_WITH_REPLACEMENT) change to the corresponding API_ macros, prefixed with WK_EXTERN.
  • Shared/API/Cocoa/WKFoundation.h: When header postprocessing is disabled, provide definitions of the new WK_* macros we use.
  • UIProcess/API/Cocoa/WKWebViewConfiguration.h: In addition to the above, changed one instance of (iOS) 10_0 to WK_IOS_TBA.

Made the above changes in the following headers:

  • Shared/API/Cocoa/WKBrowsingContextHandle.h:
  • Shared/API/Cocoa/_WKFrameHandle.h:
  • Shared/API/Cocoa/_WKHitTestResult.h:
  • Shared/API/Cocoa/_WKRemoteObjectInterface.h:
  • Shared/API/Cocoa/_WKRemoteObjectRegistry.h:
  • Shared/API/Cocoa/_WKRenderingProgressEvents.h:
  • Shared/API/Cocoa/_WKSameDocumentNavigationType.h:
  • UIProcess/API/Cocoa/WKBackForwardList.h:
  • UIProcess/API/Cocoa/WKBackForwardListItem.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.h:
  • UIProcess/API/Cocoa/WKBrowsingContextGroup.h:
  • UIProcess/API/Cocoa/WKConnection.h:
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKErrorPrivate.h:
  • UIProcess/API/Cocoa/WKFrameInfo.h:
  • UIProcess/API/Cocoa/WKFrameInfoPrivate.h:
  • UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h:
  • UIProcess/API/Cocoa/WKNavigation.h:
  • UIProcess/API/Cocoa/WKNavigationAction.h:
  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/API/Cocoa/WKNavigationData.h:
  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKNavigationResponse.h:
  • UIProcess/API/Cocoa/WKOpenPanelParameters.h:
  • UIProcess/API/Cocoa/WKPreferences.h:
  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKPreviewActionItem.h:
  • UIProcess/API/Cocoa/WKPreviewActionItemIdentifiers.h:
  • UIProcess/API/Cocoa/WKPreviewElementInfo.h:
  • UIProcess/API/Cocoa/WKProcessGroup.h:
  • UIProcess/API/Cocoa/WKProcessPool.h:
  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/API/Cocoa/WKScriptMessage.h:
  • UIProcess/API/Cocoa/WKSecurityOrigin.h:
  • UIProcess/API/Cocoa/WKTypeRefWrapper.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKUserContentController.h:
  • UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:
  • UIProcess/API/Cocoa/WKUserScript.h:
  • UIProcess/API/Cocoa/WKUserScriptPrivate.h:
  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecordPrivate.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/API/Cocoa/WKWindowFeatures.h:
  • UIProcess/API/Cocoa/_WKActivatedElementInfo.h:
  • UIProcess/API/Cocoa/_WKAutomationSession.h:
  • UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
  • UIProcess/API/Cocoa/_WKDownload.h:
  • UIProcess/API/Cocoa/_WKElementAction.h:
  • UIProcess/API/Cocoa/_WKExperimentalFeature.h:
  • UIProcess/API/Cocoa/_WKFindOptions.h:
  • UIProcess/API/Cocoa/_WKFormInputSession.h:
  • UIProcess/API/Cocoa/_WKInputDelegate.h:
  • UIProcess/API/Cocoa/_WKLayoutMode.h:
  • UIProcess/API/Cocoa/_WKOverlayScrollbarStyle.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKSessionState.h:
  • UIProcess/API/Cocoa/_WKThumbnailView.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentFilter.h:
  • UIProcess/API/Cocoa/_WKUserContentWorld.h:
  • UIProcess/API/Cocoa/_WKUserStyleSheet.h:
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.h:
  • UIProcess/API/Cocoa/_WKVisitedLinkStore.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataSize.h:
  • UIProcess/API/Cocoa/_WKWebsiteDataStore.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMElement.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMNode.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMRange.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMText.h:
  • WebProcess/InjectedBundle/API/mac/WKDOMTextIterator.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:
9:38 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)
9:27 AM Changeset in webkit [202788] by fred.wang@free.fr
  • 2 edits in trunk/LayoutTests

[win] Update TestExpectations after the MathML refactoring
https://bugs.webkit.org/show_bug.cgi?id=159386

Reviewed by Alex Christensen.

  • platform/win/TestExpectations:
9:18 AM Changeset in webkit [202787] by fred.wang@free.fr
  • 4 edits in trunk/LayoutTests

Update windows test expectations for some MathML tests.

Unreviewed test gardening.

  • platform/win/TestExpectations:
  • platform/win/mathml/opentype/horizontal-expected.txt:
  • platform/win/mathml/opentype/horizontal-munderover-expected.txt:
4:59 AM Changeset in webkit [202786] by ddkilzer@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

fast/css/image-set-unprefixed.html fails on iOS Simulator

Follow-up fix for:

"image-src" support is missing. We only support "-webkit-image-src"
https://bugs.webkit.org/show_bug.cgi?id=159373
<rdar://problem/27140443>

  • platform/ios-simulator/fast/css/image-set-unprefixed-expected.txt: Added.

Cursor tests are expected to fail on iOS Simulator.

Jul 2, 2016:

8:36 PM Changeset in webkit [202785] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation)
https://bugs.webkit.org/show_bug.cgi?id=159368

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-02
Reviewed by Timothy Hatcher.

  • UserInterface/Test.html:

SourceCodeLocation was already included earlier. This redefines it and
thereby breaks some things.

8:33 PM Changeset in webkit [202784] by commit-queue@webkit.org
  • 8 edits in trunk

inspector/debugger/command-line-api-exception.html flakily times out on mac
https://bugs.webkit.org/show_bug.cgi?id=152029
<rdar://problem/23813812>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-02
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Base/Object.js:

(WebInspector.Object.addEventListener):
Return the listener, this makes it cleaner to write tests.

LayoutTests:

  • inspector/debugger/command-line-api-exception-expected.txt:
  • inspector/debugger/command-line-api-exception-nested-catch-expected.txt:
  • inspector/debugger/command-line-api-exception-nested-catch.html:
  • inspector/debugger/command-line-api-exception.html:
  • platform/mac/TestExpectations:

Rewrite these tests to use the new test harness.
This also is more careful about Pause/Resume timing differences
between Release and Debug builds.

8:32 PM Changeset in webkit [202783] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Web Inspector: Fix inspector/debugger/pause-reason.html
https://bugs.webkit.org/show_bug.cgi?id=159325

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-02
Reviewed by Timothy Hatcher.

  • platform/mac/TestExpectations:
  • inspector/debugger/pause-reason.html:

This test was pausing on inspector code (evaluateInPage) and
auto-resuming. Instead change the test to pause on the page
doing the setTimeout, so we get the expected pause on next
statement evaluation.

10:52 AM Changeset in webkit [202782] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Build fix.

  • wtf/Assertions.cpp:
10:47 AM Changeset in webkit [202781] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed, roll back unintentional commit in r202778.

  • benchmarks/LockFairnessTest.cpp:

(main):

10:45 AM Changeset in webkit [202780] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
https://bugs.webkit.org/show_bug.cgi?id=152486

Patch by Youenn Fablet <youennf@gmail.com> on 2016-07-02
Reviewed by Daniel Bates.

Add launch of web-platform-tests server by run-webkit-httpd.
Add two options to disable starting httpd and web-platform-tests servers.

  • Scripts/run-webkit-httpd:

(parse_args):
(main):

10:44 AM Changeset in webkit [202779] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Synchronous preflight checker should set loading options to not use credentials
https://bugs.webkit.org/show_bug.cgi?id=159351

Patch by Youenn Fablet <youenn@apple.com> on 2016-07-02
Reviewed by Alex Christensen.

Like for asynchronous preflighting, synchronous preflighting loading options should disqble any credentials.

No change of behavior as preflight request is expressly set to not use credentials in
createAccessControlPreflightRequest.

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::doPreflight):

10:43 AM Changeset in webkit [202778] by fpizlo@apple.com
  • 7 edits
    1 add in trunk/Source

Scopes that are not under TDZ should still push their variables onto the TDZ stack so that lifting TDZ doesn't bypass that scope
https://bugs.webkit.org/show_bug.cgi?id=159332
rdar://problem/27018958

Reviewed by Saam Barati.

This fixes an instacrash in this code:

try{}catch(e){}print(e);let e;


We lift TDZ for "e" in "catch (e){}", but since that scope doesn't push anything onto the
TDZ stack, we lift TDZ from "let e".

The problem is that we weren't tracking the set of variables that do not have TDZ. We need
to track them to "block" the traversal that lifts TDZ. This change fixes this issue by
using a map that tracks all known variables, and tells you if they are under TDZ or not.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numParameters):

  • bytecode/CodeOrigin.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::Label::setLocation):
(JSC::Variable::dump):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::popLexicalScope):
(JSC::BytecodeGenerator::popLexicalScopeInternal):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::needsTDZCheck):
(JSC::BytecodeGenerator::liftTDZCheckIfPossible):
(JSC::BytecodeGenerator::pushTDZVariables):
(JSC::BytecodeGenerator::getVariablesUnderTDZ):
(JSC::BytecodeGenerator::endGenerator):
(WTF::printInternal):

  • bytecompiler/BytecodeGenerator.h:

(JSC::Variable::isConst):
(JSC::Variable::setIsReadOnly):

  • interpreter/CallFrame.h:

(JSC::ExecState::topOfFrame):

  • tests/stress/lift-tdz-bypass-catch.js: Added.

(foo):
(catch):

4:29 AM Changeset in webkit [202777] by fred.wang@free.fr
  • 5 edits in trunk/LayoutTests

Update EFL expectations for some MathML tests.

Unreviewed test gardening.

  • platform/efl/TestExpectations: Mark mathml/presentation/radical-bar-visibility.html as failing.
  • platform/efl/mathml/opentype/horizontal-munderover-expected.txt: Update expectation using latest buildbot results.
  • platform/efl/mathml/presentation/menclose-notation-values-expected.txt: Ditto.
  • platform/efl/mathml/presentation/mspace-children-expected.txt: Ditto.
1:24 AM Changeset in webkit [202776] by fred.wang@free.fr
  • 4 edits
    7 adds
    1 delete in trunk/LayoutTests

Update windows expectations for some MathML tests.

Unreviewed test gardening.

  • platform/win/TestExpectations:
  • platform/win/mathml/opentype/large-operators-expected.txt: Added.
  • platform/win/mathml/opentype/opentype-stretchy-expected.txt: Added.
  • platform/win/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Removed.
  • platform/win/mathml/opentype/vertical-expected.txt: Added.
  • platform/win/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
  • platform/win/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/win/mathml/presentation/roots-expected.txt: Added.
  • platform/win/mathml/radical-fallback-expected.png: Added.
  • platform/win/mathml/radical-fallback-expected.txt: Added.
  • platform/efl/mathml/radical-fallback-expected.txt:
12:54 AM Changeset in webkit [202775] by fred.wang@free.fr
  • 11 edits
    2 adds
    6 deletes in trunk/LayoutTests

Update EFL expectations for some MathML tests.

Unreviewed test gardening.

  • platform/efl/accessibility/math-mo-fences-and-separators-expected.txt: Added.
  • platform/efl/mathml/opentype/horizontal-expected.txt:
  • platform/efl/mathml/opentype/horizontal-munderover-expected.txt:
  • platform/efl/mathml/opentype/large-operators-expected.png: Removed.
  • platform/efl/mathml/opentype/large-operators-expected.txt:
  • platform/efl/mathml/opentype/opentype-stretchy-expected.png: Removed.
  • platform/efl/mathml/opentype/opentype-stretchy-expected.txt:
  • platform/efl/mathml/opentype/vertical-expected.png: Removed.
  • platform/efl/mathml/opentype/vertical-expected.txt:
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.png: Removed.
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
  • platform/efl/mathml/presentation/menclose-notation-values-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.png: Removed.
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/mspace-children-expected.txt:
  • platform/efl/mathml/presentation/roots-expected.png: Removed.
  • platform/efl/mathml/presentation/roots-expected.txt:
  • platform/efl/mathml/radical-fallback-expected.txt: Added.
12:11 AM Changeset in webkit [202774] by fred.wang@free.fr
  • 4 edits
    1 add in trunk/LayoutTests

Update iOS expectations for some MathML tests.

Unreviewed test gardening.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/mathml/mathml-in-dashboard-actual.txt: Added.

Jul 1, 2016:

8:03 PM Changeset in webkit [202773] by Hunseop Jeong
  • 3 edits in trunk/Source/WebKit2

[EFL] Many layout tests are timeout after r202532.
https://bugs.webkit.org/show_bug.cgi?id=159337

Reviewed by Gyuyoung Kim.

WebPageProxy::forceRepaint() wait for the next commit from the web process
after r202532, but WebPageProxy::callAfterNextPresentationUpdate() is not
implemented in CoordinatedDrawingAreaProxy.

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::contentsRect):
(WebKit::CoordinatedDrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::CoordinatedDrawingAreaProxy::sizeDidChange):

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:

(WebKit::CoordinatedDrawingAreaProxy::page):

7:53 PM Changeset in webkit [202772] by mmaxfield@apple.com
  • 12 edits in trunk

REGRESSION(r189668): Notification tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=159375
<rdar://problem/22760990>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Implement WKNotificationManagerGetLocalID(). For more information, see the entry in Tools/ChangeLog.

  • UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerGetLocalID):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::notificationLocalIDForTesting):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:

Tools:

Notifications are objects which must exist in both the UI Process and the Web Process. Each process
identifies a notification object by a unique ID. When the Web Process sends a message regarding a
notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
(Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.

Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
global notification ID mapping, causing the wrong notification to be investigated.

The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
manually perform this same mapping. Luckily, this object already receives callbacks every time a
notification is created or destroyed. However, because this object is implemented outside WebKit,
it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
WebNotificationProvider can properly map between the different IDs.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTestingServerLoop):
(WTR::TestController::simulateWebNotificationClick):

  • WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::showWebNotification):
(WTR::removeGlobalIDFromIDMap):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::removeNotificationManager):
(WTR::WebNotificationProvider::simulateWebNotificationClick):
(WTR::WebNotificationProvider::reset):

  • WebKitTestRunner/WebNotificationProvider.h:

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac-wk2/TestExpectations:
7:32 PM Changeset in webkit [202771] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk

Unreviewed, rolling out r202766.
https://bugs.webkit.org/show_bug.cgi?id=159382

The new test asserts every time (Requested by ap on #webkit).

Reverted changeset:

"Web Inspector: Sending XHR with UTF8 encoded data shows
garbled data in Resource sidebar"
https://bugs.webkit.org/show_bug.cgi?id=159358
http://trac.webkit.org/changeset/202766

7:20 PM Changeset in webkit [202770] by commit-queue@webkit.org
  • 5 edits in trunk

[JSC] RegExp.compile is not returning the regexp when it succeed
https://bugs.webkit.org/show_bug.cgi?id=159381

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.

Source/JavaScriptCore:

Spec:
-https://tc39.github.io/ecma262/#sec-regexp.prototype.compile
-https://tc39.github.io/ecma262/#sec-regexpinitialize

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

LayoutTests:

  • js/regexp-compile-expected.txt:
  • js/script-tests/regexp-compile.js:
6:15 PM Changeset in webkit [202769] by Alan Bujtas
  • 5 edits
    3 adds in trunk

prepareForDestruction() always needs to be called before destroying the Document object.
https://bugs.webkit.org/show_bug.cgi?id=159372
rdar://problem/26788150

Reviewed by Antti Koivisto.

We should never start destroying the Document object without calling prepareForDestruction() first.
It ensures that render tree gets nuked before we start tearing down the node tree.

Source/WebCore:

Test: fast/history/page-cache-destroy-document.html

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):

LayoutTests:

  • fast/history/page-cache-destroy-document-expected.txt: Added.
  • fast/history/page-cache-destroy-document.html: Added.
  • fast/history/resources/page-cache-destroy-helper.html: Added.
5:59 PM Changeset in webkit [202768] by sbarati@apple.com
  • 6 edits
    1 add in trunk

fix "ASSERTION FAILED: currentOffset() >= currentLineStartOffset()"
https://bugs.webkit.org/show_bug.cgi?id=158572
<rdar://problem/26884092>

Reviewed by Mark Lam.

Source/JavaScriptCore:

There is a bug in our lexer when we notice the pattern:
<return|continue|break|...etc> // some comment here
Our code will say that the token for the comment is a semicolon.
This is the correct semantics, however, it would give the semicolon
a start offset of the comment, but it will give its line start offset
the newline after the comment. This breaks the invariant in the lexer/parser
that the offset for the current line starting point must be less than or equal to
than the start offset of any token on that line. This invariant was broken because
the line start offset was greater than the token start offset. To maintain this
invariant, we claim that the semicolon token is located where the comment starts,
and that its line start offset is the line start offset for the line with the
comment on it. There are other solutions that maintain this invariant, but this
solution provides the best error messages.

  • parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

  • parser/Parser.h:

(JSC::Parser::internalSaveLexerState):

  • tests/stress/obscure-error-message-dont-crash.js: Added.

(try.eval.or.catch):

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:

(invalid.or.break.catch):
(catch): Deleted.

5:56 PM Changeset in webkit [202767] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking fast/history/page-cache-webdatabase-pending-transaction.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=159379

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:55 PM Changeset in webkit [202766] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Web Inspector: Sending XHR with UTF8 encoded data shows garbled data in Resource sidebar
https://bugs.webkit.org/show_bug.cgi?id=159358

Patch by Johan K. Jensen <jj@johanjensen.dk> on 2016-07-01
Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/inspector/network/xhr-request-data-encoded-correctly.html

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::buildObjectForResourceRequest):

LayoutTests:

Based on Chromium patch:
<https://chromium.googlesource.com/chromium/src/+/bcbb663864624ab38b36731eb2edc839a90f9e65%5E%21/#F2>

  • http/tests/inspector/network/xhr-request-data-encoded-correctly-expected.txt:
  • http/tests/inspector/network/xhr-request-data-encoded-correctly.html:
5:22 PM Changeset in webkit [202765] by dino@apple.com
  • 10 edits
    2 adds in trunk

"image-src" support is missing. We only support "-webkit-image-src"
https://bugs.webkit.org/show_bug.cgi?id=159373
<rdar://problem/27140443>

Patch by Brent Fulgham and Dean Jackson.
Reviewed by Dean Jackson and Brent Fulgham.

Source/WebCore:

Support unprefixed image-set.

Test: fast/css/image-set-unprefixed.html

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::customCSSText):

  • css/CSSParser.cpp:

(WebCore::isImageSetFunctionValue): New helper function
that checks prefixed and unprefixed form.
(WebCore::CSSParser::parseValue): Use the helper.
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):

LayoutTests:

Convert some existing tests to use the unprefixed form,
and add a test that checks we are compatible with
the prefixed form.

  • cssom/cssvalue-comparison-expected.txt:
  • cssom/cssvalue-comparison.html:
  • fast/css/cursor-parsing-image-set-expected.txt:
  • fast/css/cursor-parsing-image-set.html:
  • fast/css/image-set-setting-expected.txt:
  • fast/css/image-set-unprefixed-expected.txt: Added.
  • fast/css/image-set-unprefixed.html: Added.
  • fast/css/script-tests/image-set-setting.js:

(testImageSetRule):

4:58 PM Changeset in webkit [202764] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Land test expectations for rdar://problem/27141291.

  • platform/mac/TestExpectations:
4:41 PM Changeset in webkit [202763] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebKit2

REGRESSION(r201405): Fullscreen video no longer enters low-power mode
https://bugs.webkit.org/show_bug.cgi?id=159220
<rdar://problem/26701056>

Reviewed by Beth Dakin.

In r201405, we removed the call to setTopContentInset(0) to avoid a flash
during repainting where the WebProcess still thought it had an inset and
the UIProcess did not, but the >0 inset breaks low power video playback
in fullscreen. So, instead, fix the repaint issue by setting a CALayer
fence which makes sure both the UIProcess and WebProcess paint simultaneously
after resizing and changing the top content inset.

This requires a new message from WebPageProxy -> WebPage: setTopContentInsetFenced().

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setTopContentInset):

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTopContentInsetFenced):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:25 PM Changeset in webkit [202762] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Possible null Range dereference under AXObjectCache::visiblePositionFromCharacterOffset()
https://bugs.webkit.org/show_bug.cgi?id=159330
<rdar://problem/27123752>

Reviewed by Benjamin Poulain.

rangeForUnorderedCharacterOffsets() can return a null Range but we failed
to do a null check before dereferencing it.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):

4:22 PM Changeset in webkit [202761] by Chris Dumez
  • 16 edits
    2 adds in trunk

Regression(r199087): window.focus() / window.close() can no longer be called by a Window's opener
https://bugs.webkit.org/show_bug.cgi?id=159364
<rdar://problem/27117169>

Reviewed by Gavin Barraclough.

Source/WebCore:

window.focus() / window.close() could no longer be called by a Window's opener
after r199087, which would break focusing of open iWork documents on icloud.com.

Before r199087, we would construct a new function in the caller's context every
time window.focus and window.close was accessed. r199087 fixed the issue so that
we always call the same function. However, those functions are using
[CallWith=Document] and they are were no longer passed the *caller*'s document
as a result. This broke focus / close permission checking as the code needed the
caller's document to do the check.

This patch introduces [CallWith=CallerDocument] and [CallWith=CallerWindow] so
that the implementation can now pass the caller's Document / Window to the
implementation. The bindings rely on JSDOMWindow's callerDOMWindow() to get the
caller DOMWindow / document. This new functionality is now used for window.close
and window.focus to unbreak their permission checking.

Test: fast/dom/Window/child-window-focus.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

  • bindings/scripts/IDLAttributes.txt:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Add layout test coverage.

  • fast/dom/Window/child-window-focus-expected.txt: Added.
  • fast/dom/Window/child-window-focus.html: Added.
4:15 PM Changeset in webkit [202760] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Test gardening for Sierra WK1

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:50 PM Changeset in webkit [202759] by fred.wang@free.fr
  • 2 edits in trunk/LayoutTests

Remove failure expectation for mathml/presentation/bug97990.html on ios-simulator

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • platform/ios-simulator-wk2/TestExpectations:
2:43 PM Changeset in webkit [202758] by mitz@apple.com
  • 22 edits in trunk/Source/WebKit2

[Mac] Get rid of support for old SDKs
https://bugs.webkit.org/show_bug.cgi?id=159369

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKFoundation.h: Removed the WK_ARRAY, WK_DICTIONARY, and WK_SET macros, which were only needed for pre-10.11 SDKs.
  • Shared/mac/WebEventFactory.mm:

(WebKit::mouseButtonForEvent): Removed checking for pre-10.10.3 SDKs.
(WebKit::globalPointForEvent): Ditto.
(WebKit::pointForEvent): Ditto.
(WebKit::WebEventFactory::createWebMouseEvent): Ditto.

  • UIProcess/API/Cocoa/WKBackForwardList.h: Replaced WK_ARRAY(...) with NSArray<...>.
  • UIProcess/API/Cocoa/WKPreferences.mm: Ditto.

(-[WKPreferences _setFixedPitchFontFamily:]):
(+[WKPreferences _experimentalFeatures]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKUIDelegate.h: Ditto.
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKUserContentController.h: Ditto.
  • UIProcess/API/Cocoa/WKUserContentControllerPrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKUserScriptPrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h: Replaced WK_SET(...) with NSSet<...>.
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h: Ditto.
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm: Ditto.

(-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]):
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: Ditto.
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: Replaced WK_ARRAY(...) with NSArray<...>.
  • UIProcess/API/Cocoa/_WKUserStyleSheet.h: Ditto.
  • UIProcess/API/Cocoa/_WKUserStyleSheet.mm: Ditto.

(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:userContentWorld:]):

  • UIProcess/API/Cocoa/_WKWebsiteDataSize.h: Replaced WK_SET(...) with NSSet<...>.
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pressureChangeWithEvent): Removed checking for pre-10.10.3 SDKs.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Replaced WK_ARRAY(...) with NSArray<...>.
  • mac/postprocess-framework-headers.sh: Removed sed rules for WK_ARRAY, WK_DICTIONARY and WK_SET.
1:59 PM Changeset in webkit [202757] by Chris Dumez
  • 5 edits in trunk/Source

[iOS] Possible null Range dereference under computeAutocorrectionContext()
https://bugs.webkit.org/show_bug.cgi?id=159328
<rdar://problem/26766720>

Reviewed by Benjamin Poulain.

Source/WebCore:

  • editing/Editor.cpp:

(WebCore::Editor::compositionRange):

  • editing/Editor.h:

Update to return a RefPtr instead of a PassRefPtr and use nullptr
instead of 0 in the implementation.

Source/WebKit2:

The code in computeAutocorrectionContext() was checking Editor::hasComposition()
before dereferencing Editor::compositionRange(). However, compositionRange()
can also return null in other cases (e.g. compositionStart == compositionEnd).

Drop the check for hasComposition() and do a null check on the value returned
by compositionRange() instead.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::computeAutocorrectionContext):

1:58 PM Changeset in webkit [202756] by Jon Davis
  • 3 edits in trunk/Websites/webkit.org

Added a colorful new image and fixed the Open Graph attribute.
https://bugs.webkit.org/show_bug.cgi?id=159359

Reviewed by Timothy Hatcher.

The Open Graph image tag should use the property attribute not
the itemprop attribute.

  • wp-content/plugins/social-meta.php:
  • wp-content/themes/webkit/images/ogimage.png:
1:55 PM Changeset in webkit [202755] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

defineGetter/defineSetter should throw exceptions
https://bugs.webkit.org/show_bug.cgi?id=142934

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.

Source/JavaScriptCore:

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):

LayoutTests:

  • js/dom/dom-properties-are-configurable-expected.txt: Added.
  • js/dom/dom-properties-are-configurable.html: Added.
  • js/object-literal-duplicate-properties-expected.txt:
  • js/property-getters-and-setters-expected.txt:
  • js/script-tests/object-literal-duplicate-properties.js:
  • js/script-tests/property-getters-and-setters.js:
1:52 PM Changeset in webkit [202754] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

Prevent crash when attempting to copy an image
https://bugs.webkit.org/show_bug.cgi?id=159288
<rdar://problem/23507828>

Reviewed by Brady Eidson.

WebKit could crash if the HTMLImageElement had a null cachedImage member.
A little investigation showed that the URL we retrieve from the cachedImage
is never used, so rather than adding a null check, let's just pass a
default argument. The actual URL gets read from elsewhere in the pasteboard
processing code.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performActionOnElement): Don't bother passing the
unused URL argument to the pasteboard method.

1:51 PM Changeset in webkit [202753] by Jon Davis
  • 4 edits in trunk/Source

Source/JavaScriptCore:
Moved Web Animations and Resource Timing feature entries to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=159356

Reviewed by Timothy Hatcher.

  • features.json:

Source/WebCore:
Updated Picture element and WOFF 2 status
https://bugs.webkit.org/show_bug.cgi?id=159356

Reviewed by Timothy Hatcher.

Status updates and clean-up to move Web Animations and Resource Timing entries from JSC to WebCore.

  • features.json:
1:49 PM Changeset in webkit [202752] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[JSC] Date.toGMTString should be the Date.toUTCString function
https://bugs.webkit.org/show_bug.cgi?id=159318

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.

Source/JavaScriptCore:

See https://tc39.github.io/ecma262/#sec-date.prototype.togmtstring

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncToGMTString): Deleted.

LayoutTests:

  • js/date-prototype-expected.txt: Added.
  • js/date-prototype.html: Added.
  • js/script-tests/date-prototype.js: Added.
1:46 PM Changeset in webkit [202751] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Add early return when processing content extensions if there aren't any.
<https://webkit.org/b/159363>

Reviewed by Antti Koivisto.

Short-circuit outta there if there aren't any extensions to query.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):

1:44 PM Changeset in webkit [202750] by fred.wang@free.fr
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

Rebaseline some MathML tests.

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • platform/gtk/mathml/opentype/munderover-window-resize-expected.txt: Removed.
  • platform/ios-simulator/mathml/presentation/roots-expected.png: Added.
  • platform/mac/mathml/opentype/munderover-window-resize-expected.png: Removed.
1:31 PM Changeset in webkit [202749] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

HTMLMediaElement::resume() may cause JavaScript execution
https://bugs.webkit.org/show_bug.cgi?id=159327
<rdar://problem/27131641>

Reviewed by Jer Noble.

HTMLMediaElement::updatePlayState can cause an element to begin playing and enter fullscreen,
which can result in a call to the media controls and JavaScript execution. Javascript is not
allowed allowed to run when a page resumes, so make the call to updatePlayState asynchronous.

No new tests, I wasn't able to create a test that triggers the crash.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::scheduleDelayedAction): Support UpdatePlayState.
(WebCore::HTMLMediaElement::pendingActionTimerFired): Ditto.
(WebCore::HTMLMediaElement::setReadyState): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::playInternal): Don't call updateMediaController, it is called

by updatePlayState.

(WebCore::HTMLMediaElement::setMuted): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
(WebCore::HTMLMediaElement::mediaEngineWasUpdated): Update media state asynchronously.
(WebCore::HTMLMediaElement::updatePlayState): Add parameter to allow update to happen

asynchronously.

(WebCore::HTMLMediaElement::setPlaying): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::setPausedInternal): Update media state asynchronously.
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):

UpdateMediaState -> UpdateState.

(WebCore::HTMLMediaElement::removeEventListener): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
(WebCore::HTMLMediaElement::updateMediaState): UpdateMediaState -> UpdateState

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElementEnums.h: Add UpdatePlayState.
12:41 PM Changeset in webkit [202748] by fred.wang@free.fr
  • 26 edits
    8 adds
    9 deletes in trunk/LayoutTests

Update OS X and iOS expectations for some MathML pixel tests.
https://bugs.webkit.org/show_bug.cgi?id=159339

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • mathml/opentype/fraction-line.html: Add a comment about font requirements.
  • mathml/opentype/horizontal-munderover.html: Ditto.
  • mathml/opentype/horizontal.html: Ditto.
  • mathml/opentype/large-operators-italic-correction.html: Ditto.
  • mathml/opentype/large-operators.html: Ditto.
  • mathml/opentype/vertical.html: Ditto.
  • mathml/presentation/attributes-mathvariant.html: Ditto.
  • mathml/presentation/fractions-linethickness.html: Ditto.
  • mathml/presentation/tokenElements-mathvariant.html: Ditto.
  • mathml/radical-fallback.html: Ditto.
  • platform/ios-simulator-wk1/TestExpectations: Update expectations.
  • platform/ios-simulator-wk2/TestExpectations: Ditto.
  • platform/ios-simulator-wk2/mathml/opentype/large-operators-expected.png: Removed.
  • platform/ios-simulator-wk2/mathml/opentype/vertical-expected.png: Removed.
  • platform/ios-simulator-wk2/mathml/presentation/mo-stretch-expected.png: Removed.
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/mathml/opentype/horizontal-expected.txt: Removed.
  • platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt: Removed.
  • platform/ios-simulator/mathml/opentype/large-operators-expected.txt: Removed.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.png: Added.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-horizontal-expected.png: Added.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/ios-simulator/mathml/opentype/vertical-expected.txt: Removed.
  • platform/ios-simulator/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
  • platform/ios-simulator/mathml/presentation/menclose-notation-values-expected.png: Added.
  • platform/ios-simulator/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/ios-simulator/mathml/presentation/mo-stretch-expected.txt:
  • platform/ios-simulator/mathml/presentation/mspace-children-expected.png: Added.
  • platform/ios-simulator/mathml/radical-fallback-expected.png:
  • platform/mac/TestExpectations: Update expectations.
  • platform/mac/mathml/opentype/horizontal-expected.txt: Removed.
  • platform/mac/mathml/opentype/horizontal-munderover-expected.txt: Removed.
  • platform/mac/mathml/opentype/large-operators-expected.txt: Removed.
  • platform/mac/mathml/opentype/opentype-stretchy-expected.png: Added.
  • platform/mac/mathml/opentype/vertical-expected.txt: Removed.
  • platform/mac/mathml/presentation/menclose-notation-values-expected.png:
  • platform/mac/mathml/presentation/menclose-notation-values-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mspace-children-expected.png: Added.
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/radical-fallback-expected.png:
  • platform/mac/mathml/radical-fallback-expected.txt:
12:10 PM Changeset in webkit [202747] by beidson@apple.com
  • 16 edits
    5 adds in trunk

Blob content type not preserved when retrieving blobs from IndexedDB.
<rdar://problem/27057357> and https://bugs.webkit.org/show_bug.cgi?id=159360

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/blob-svg-image.html

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::postToMainThread):
(WebCore::ThreadableBlobRegistry::registerBlobURLOptionallyFileBacked): Pass along the content type

to the blob registry so that if the file-backed blob takes over, it has the content type.

(WebCore::threadableQueue): Deleted.

  • fileapi/ThreadableBlobRegistry.h:
  • platform/network/BlobRegistry.h:
  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLOptionallyFileBacked):

  • platform/network/BlobRegistryImpl.h:

Source/WebKit2:

  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURLOptionallyFileBacked):

  • NetworkProcess/FileAPI/NetworkBlobRegistry.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::registerBlobURLOptionallyFileBacked):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerBlobURLOptionallyFileBacked):

  • WebProcess/FileAPI/BlobRegistryProxy.h:

LayoutTests:

  • storage/indexeddb/modern/blob-svg-image-expected.txt: Added.
  • storage/indexeddb/modern/blob-svg-image.html: Added.
  • storage/indexeddb/modern/resources/blob-svg-image.js: Added.
  • storage/indexeddb/modern/resources/blob-svg-image1.html: Added.
  • storage/indexeddb/modern/resources/blob-svg-image2.html: Added.
12:07 PM Changeset in webkit [202746] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

[Cocoa] Get rid of WK_NULLABLE_SPECIFIER now that all supported compilers understand _Nullable
https://bugs.webkit.org/show_bug.cgi?id=159361

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKFoundation.h:
  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • mac/postprocess-framework-headers.sh:
11:36 AM Changeset in webkit [202745] by bshafiei@apple.com
  • 1 delete in tags/Safari-602.1.38.2.100

Delete tag.

11:08 AM Changeset in webkit [202744] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit/win

ASSERTION FAILED: info.bmBitsPixel == 32
https://bugs.webkit.org/show_bug.cgi?id=17737

Reviewed by Brent Fulgham.

The ::SelectObject call will fail if m_backingStoreBitmap is already selected into a device context.
This happens when this method is called indirectly from WebView::updateBackingStore during normal
painting. There is no point continuing, since we would just be scrolling a 1x1 bitmap which is
selected into the device context by default. We can just scroll by repainting the scroll rectangle.

  • WebView.cpp:

(WebView::scrollBackingStore): Invalidate the scroll rectangle if the ::SelectObject call fails.

10:08 AM Changeset in webkit [202743] by ap@apple.com
  • 9 edits in trunk/Tools

Simplify LayoutTestRelay
https://bugs.webkit.org/show_bug.cgi?id=159353

Reviewed by Daniel Bates.

  1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it

by name and runtime makes no sense.

  1. Removed code to create devices, webkitpy always does this in advance.
  2. Don't create copies of testing apps - we can install the same one into

each simulator, now that we don't run multiple tester processes in a single simulator.

  1. Pass information on how to find I/O pipes via environment, not via Info.plist.
  2. Removed code that kept testing apps alive in the background.
  3. Slightly updated coding style in functions that I touched.
  • LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:

Updated for what we acually use at this point.

  • LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m:

(-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
(-[LTRelayController ipcIdentifier]):
(-[LTRelayController processName]):
(-[LTRelayController didReceiveStdoutData:]):
(-[LTRelayController didCrashWithMessage:]):
(-[LTRelayController installApp]):
(-[LTRelayController _environmentVariables]):
(-[LTRelayController launchApp]):
(-[LTRelayController start]):
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
(-[LTRelayController uniqueAppPath]): Deleted.
(-[LTRelayController uniqueAppURL]): Deleted.
(-[LTRelayController uniqueAppIdentifier]): Deleted.
(-[LTRelayController createUniqueApp]): Deleted.

  • LayoutTestRelay/LayoutTestRelay/main.m:

(usage):
(getRequiredStringArgument):
(main):
(getTestingSimDevice): Deleted.

  • Scripts/webkitpy/port/driver.py:

(IOSSimulatorDriver.cmd_line):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformInitialize):

  • WebKitTestRunner/ios/mainIOS.mm:

(-[WebKitTestRunnerApp applicationDidEnterBackground:]):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):
(-[DumpRenderTree applicationDidEnterBackground:]):

10:06 AM Changeset in webkit [202742] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Make enabling protocol logging in inspector tests easy to remember
https://bugs.webkit.org/show_bug.cgi?id=159323

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-01
Reviewed by Brian Burg.

Now you just need to type InspectorTest.debug() or
ProtocolTest.debug() and it will include stderr logging.

  • UserInterface/Test/FrontendTestHarness.js:

(FrontendTestHarness.prototype.debug):

  • UserInterface/Test/ProtocolTestHarness.js:

(ProtocolTestHarness.prototype.debug):
(ProtocolTestHarness):

  • UserInterface/Test/TestHarness.js:

(TestHarness.prototype.debug):

10:03 AM Changeset in webkit [202741] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Make ResourceLoaderOptions derive from FetchOptions
https://bugs.webkit.org/show_bug.cgi?id=159345

Patch by Youenn Fablet <youenn@apple.com> on 2016-07-01
Reviewed by Alex Christensen.

No change of behavior.

  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

  • loader/ResourceLoaderOptions.h:

(WebCore::ResourceLoaderOptions::fetchOptions): Deleted.
(WebCore::ResourceLoaderOptions::setFetchOptions): Deleted.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):

10:00 AM Changeset in webkit [202740] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Web Inspector: Cleanup inspector/console/console-message.html
https://bugs.webkit.org/show_bug.cgi?id=159324

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-01
Reviewed by Brian Burg.

  • inspector/console/console-message.html:
9:43 AM Changeset in webkit [202739] by Konstantin Tokarev
  • 2 edits in trunk/Tools

[cmake] Build TestNetscapePlugin only if NPAPI is enabled.
https://bugs.webkit.org/show_bug.cgi?id=159344

Reviewed by Alex Christensen.

  • DumpRenderTree/CMakeLists.txt:
9:39 AM Changeset in webkit [202738] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Animations tests are crashing in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=159335

Reviewed by Alex Christensen.

A MSVC runtime check fails because an uninitialized variable is being used.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::keyframeStylesForAnimation):

9:38 AM Changeset in webkit [202737] by mark.lam@apple.com
  • 7 edits
    3 adds in trunk/Source/JavaScriptCore

Update JSC_functionOverrides to handle the new SourceCode strings that have params.
https://bugs.webkit.org/show_bug.cgi?id=159321

Reviewed by Geoffrey Garen.

And add tests so that this won't fail silently and bit rot anymore.

  • API/tests/FunctionOverridesTest.cpp: Added.

(testFunctionOverrides):

  • API/tests/FunctionOverridesTest.h: Added.
  • API/tests/testapi-function-overrides.js: Added.
  • API/tests/testapi.c:

(main):

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::link):

  • shell/PlatformWin.cmake:
  • tools/FunctionOverrides.cpp:

(JSC::FunctionOverrides::FunctionOverrides):
(JSC::FunctionOverrides::reinstallOverrides):
(JSC::initializeOverrideInfo):
(JSC::FunctionOverrides::initializeOverrideFor):

  • tools/FunctionOverrides.h:

(JSC::FunctionOverrides::clear):

8:40 AM Changeset in webkit [202736] by jer.noble@apple.com
  • 2 edits in trunk/Source/WTF

Deadlock inside -[WebCoreNSURLSession dealloc]
https://bugs.webkit.org/show_bug.cgi?id=159331
<rdar://problem/27122716>

Reviewed by Alex Christensen.

A Function<> object can wrap any callable type, including a C++ lambda.

dispatchFunctionsFromMainThread() holds a lock while iterating over the functions in
functionQueue(), and during ths iteration, the previous callable object is destroyed by
assigning the result of functionQueue().takeFirst(). Because lambdas (and other callables,
like functors) can own objects, destroying this callable can have side effects, and if one
of those side effects is to call callOnMainThread(), this can deadlock.

Move this side-effect-having call outside the locked block by clearing the function object
immediately after calling it.

  • wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread):

8:29 AM Changeset in webkit [202735] by Konstantin Tokarev
  • 2 edits in trunk

[cmake] Make LEGACY_WEB_AUDIO depend on WEB_AUDIO.
https://bugs.webkit.org/show_bug.cgi?id=159338

Reviewed by Michael Catanzaro.

Enabling LEGACY_WEB_AUDIO makes no sense when WEB_AUDIO is
disabled.

  • Source/cmake/WebKitFeatures.cmake:
8:25 AM Changeset in webkit [202734] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk/Source/JavaScriptCore

ES6: Implement HasRestrictedGlobalProperty when checking for global lexical tier conflicts
https://bugs.webkit.org/show_bug.cgi?id=148763

Patch by Caio Lima <Caio Lima> on 2016-07-01
Reviewed by Saam Barati

I've implemented the ES6 spec 8.1.1.4.14
(http://www.ecma-international.org/ecma-262/6.0/index.html#sec-hasrestrictedglobalproperty)
that defines when a global property can be shadowed.

Added some test cases into global-lexical-redeclare-variable.js

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

  • tests/stress/global-lexical-redeclare-variable.js:

(catch):

  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/eighth.js: Added.
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/nineth.js: Added.
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/seventh.js: Added.
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/sixth.js:
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/tenth.js: Added.
5:46 AM Changeset in webkit [202733] by fred.wang@free.fr
  • 3 edits in trunk/LayoutTests

Rebaseline opentype-stretchy-horizontal.html for EFL.
https://bugs.webkit.org/show_bug.cgi?id=135561

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • platform/efl/TestExpectations:
  • platform/efl/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
5:36 AM Changeset in webkit [202732] by fred.wang@free.fr
  • 2 edits
    1 add in trunk/LayoutTests

Regenerate EFL expectation for foreign-element-in-token.html
https://bugs.webkit.org/show_bug.cgi?id=133972

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • platform/efl/TestExpectations:
  • platform/efl/mathml/presentation/foreign-element-in-token-expected.txt: Added.
5:07 AM Changeset in webkit [202731] by fred.wang@free.fr
  • 4 edits in trunk/LayoutTests

Fix warnings about non existent paths in TestExpectations

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
5:07 AM QtWebKitSecurity edited by Konstantin Tokarev
qtwebkit-announce mailing list does not exist anymore (diff)
5:01 AM QtWebKitReleases edited by Konstantin Tokarev
qtwebkit-announce mailing list does not exist anymore (diff)
4:48 AM Acronyms edited by Konstantin Tokarev
Remove GYP and KURL (diff)
4:47 AM Acronyms edited by Konstantin Tokarev
Added definition for DFG and cross-reference for JSC (diff)
4:16 AM Acronyms edited by Konstantin Tokarev
(diff)
3:53 AM LayoutTestDashboards edited by Konstantin Tokarev
NWRT has superceded old run-webkit-tests (diff)
3:52 AM Writing Reftests edited by Konstantin Tokarev
NWRT has superceded old run-webkit-tests (diff)
3:30 AM Changeset in webkit [202730] by fred.wang@free.fr
  • 2 edits in trunk/LayoutTests

Fix error in r202729

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • platform/ios-simulator/TestExpectations: Revert unintentional change of horizontal-munderover.
2:52 AM Changeset in webkit [202729] by fred.wang@free.fr
  • 4 edits in trunk/LayoutTests

Reorganize and improve comments for MathML test expectations on ios and mac.

Unreviewed test gardening.

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
12:47 AM Changeset in webkit [202728] by commit-queue@webkit.org
  • 35 edits in trunk

Add a runtime flag for DOM iterators
https://bugs.webkit.org/show_bug.cgi?id=159300

Patch by Youenn Fablet <youennf@gmail.com> on 2016-07-01
Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

Source/WebCore:

  • Modules/fetch/FetchHeaders.idl: Making iterator runtime-enabled.
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDOMIteratorEnabled):
(WebCore::RuntimeEnabledFeatures::domIteratorEnabled):

  • bindings/scripts/CodeGeneratorJS.pm:

(ToMethodName): Fixing dOM -> dom casing issue.
(GenerateImplementation): Using addIterableProperties new method.
(addIterableProperties): Activating property addition according runtime flag if iterator is rnutime flagged.

  • bindings/scripts/IDLParser.pm:

(parseOptionalIterableInterface): Adding extendedAttributes to iterable.

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):

  • bindings/scripts/test/TestNode.idl: Making iterator runtime-enabled.
  • bindings/scripts/test/TestObj.idl: Ditto.
  • css/FontFaceSet.idl: Ditto.
  • dom/NodeList.idl: Ditto.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences DOMIteratorEnabled]):
(-[WebPreferences setDOMIteratorEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::domIteratorEnabled):
(WebPreferences::setDOMIteratorEnabled):
(WebView::notifyPreferencesChanged):

  • WebPreferencesreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

  • Scripts/webkitperl/FeatureList.pm:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDOMIteratorEnabled):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
12:29 AM Changeset in webkit [202727] by fred.wang@free.fr
  • 25 edits in trunk/Source/WebCore

Eliminate trailing whitespace in MathML code
https://bugs.webkit.org/show_bug.cgi?id=159091

Patch by Frederic Wang <fwang.igalia.com> on 2016-07-01
Reviewed by Alex Christensen.

No new tests, behavior is unchanged.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::baselinePosition):
(WebCore::RenderMathMLBlock::paint):
(WebCore::parseMathMLNamedSpace):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):
(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFenced.h:
  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::styleDidChange):
(WebCore::RenderMathMLFraction::paint):

  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLMenclose.h:
  • rendering/mathml/RenderMathMLOperator.cpp:
  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):

  • rendering/mathml/RenderMathMLScripts.cpp:
  • rendering/mathml/RenderMathMLSpace.cpp:
  • rendering/mathml/RenderMathMLSpace.h:
  • rendering/mathml/RenderMathMLToken.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:
  • rendering/mathml/RenderMathMLUnderOver.h:
12:06 AM Changeset in webkit [202726] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Small cleanup: Remove unused functions RenderObject::isRenderMathML*Wrapper
https://bugs.webkit.org/show_bug.cgi?id=159333

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-01
Reviewed by Alex Christensen.

After the refactoring of RenderMathMLRoot and RenderMathMLScripts, the anonymous flexbox
wrappers used in the old layout implementation have been removed. We thus remove the
corresponding isRender* function from RenderObject.

No new tests, behavior is unchanged.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLRootWrapper): Deleted.
(WebCore::RenderObject::isRenderMathMLScriptsWrapper): Deleted.

Jun 30, 2016:

11:58 PM Changeset in webkit [202725] by akling@apple.com
  • 10 edits in trunk/Source

[Mac] Get rid of the old timey rubber-banding linen pattern.
<https://webkit.org/b/159329>

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove the "ScrollingOverhang" custom GraphicsLayer appearance since that was only used to
install the old timey linen pattern behind the web content.

We now always just set the overhang area's background color to the document background color.

This fixes an issue where we could end up loading the linen pattern and keeping it in memory
despite never actually showing it on screen.

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::setUpOverhangAreasLayerContents): Deleted.

  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::updateCustomAppearance):

  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::linenBackgroundColor): Deleted.
(WebCore::ScrollbarThemeMac::setUpOverhangAreaBackground): Deleted.
(WebCore::ScrollbarThemeMac::removeOverhangAreaBackground): Deleted.
(WebCore::ScrollbarThemeMac::setUpOverhangAreasLayerContents): Deleted.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::setRootExtendedBackgroundColor):

Source/WebKit2:

  • Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::updateCustomAppearance):

10:23 PM Changeset in webkit [202724] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

Source/WebKit2:
Add SPI to allow restoring session state without navigation in WKPage
https://bugs.webkit.org/show_bug.cgi?id=159326

Patch by Tina Liu <iting_liu@apple.com> on 2016-06-30
Reviewed by Brady Eidson.

  • UIProcess/API/C/WKPage.cpp:

(restoreFromSessionState):
Added a helper function that takes a bool parameter to specify whether
to navigate or not when restoring from the session state.
(WKPageRestoreFromSessionState):
Calling restoreFromSessionState, passing navigate = true.
(WKPageRestoreFromSessionStateWithoutNavigation):
Ditto but passing navigate = false.

  • UIProcess/API/C/WKPagePrivate.h:

Tools:
Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
https://bugs.webkit.org/show_bug.cgi?id=159326

Patch by Tina Liu <iting_liu@apple.com> on 2016-06-30
Reviewed by Brady Eidson.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::didChangeBackForwardListForPage):
(TestWebKitAPI::setPageLoaderClient):
Set the page loader client and register for didFinishLoadForFrame and
didChangeBackForwardList callbacks.
(TestWebKitAPI::createSessionStateData):
Load a webpage ("simple.html") and return the session state for this page.
(TestWebKitAPI::TEST):
Restore the page session state with that of "simple.html" without navigation.
Verify that the committed URL is NULL since there's no navigation involved.
Verify that the current item in the back forward list, which should be what
we restored from the session state, has the expected URL.

6:29 PM Changeset in webkit [202723] by Chris Dumez
  • 12 edits in trunk/Source

[iOS] WebContent processes do not exit promptly
https://bugs.webkit.org/show_bug.cgi?id=159301
<rdar://problem/26965488>

Reviewed by Anders Carlsson.

WebContent processes do not exit promptly, they hang around for 10 seconds
until the watchdog forcefully calls exit().

This patch addresses the issue by asking XPC to exit when clean. It also
fixes 2 XPC transactions that were leaking so that XPC can become clean.

  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:

(DatabaseServiceInitializer):

  • NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:

(NetworkServiceInitializer):

  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(PluginServiceInitializer):

  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):
Add extra priorityBoostMessage parameter which is then passed along to
ChildProcess via initialization parameters. ChildProcess is now in
charge of retaining the message for as long as it needs the priority
boost. In particular, ChildProcess now takes care of releasing the
boost message before existing to avoid leaking an XPC transaction.

  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::initialize):
Retain priorityBoostMessage as a data member.

(WebKit::ChildProcess::stopRunLoop):
(WebKit::ChildProcess::platformStopRunLoop):

  • Shared/ios/ChildProcessIOS.mm:

(WebKit::ChildProcess::platformStopRunLoop):
On iOS, call XPCServiceExit() to exit instead of RunLoop::main().stop()
which did not work.

  • Shared/ChildProcess.h:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):
Set priorityBoostMessage on ChildProcessInitializationParameters.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceExit):
Add XPCServiceExit() function which destroys the priority boost
message, calls xpc_transaction_end() to balance the
xpc_transaction_begin() in XPCServiceInitializer() and then call
xpc_transaction_exit_clean() to ask XPC to exit when clean.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceEventHandler):
Leaking the "pre-bootstrap" event for priority boosting would cause us to
leak an XPC transaction, which would prevent XPC from becoming clean and
exiting. Instead, we now pass it along to the initialization function.
We then pass it to ChildProcess which manages the lifetime of this message
instead of leaking it.

5:13 PM Changeset in webkit [202722] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Unreviewed build fix.

  • Localizations/en.lproj/localizedStrings.js:

Add "Area" localized string.

5:13 PM Changeset in webkit [202721] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.4

New tag.

5:07 PM Changeset in webkit [202720] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skipping flaky inspector/debugger/break-on-* tests
https://bugs.webkit.org/show_bug.cgi?id=159272

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:03 PM Changeset in webkit [202719] by jiewen_tan@apple.com
  • 5 edits in trunk/Source

Create a generic "linked-on-or-after" check for new CSP Rules
https://bugs.webkit.org/show_bug.cgi?id=159322
<rdar://problem/27117220>

Reviewed by Brent Fulgham.

Source/WebCore:

Create a generic "linked-on-or-after" check for new CSP Rules and cleanup
quirks for Ecobee, Quora and XtraMat.

  • platform/RuntimeApplicationChecks.h:
  • platform/RuntimeApplicationChecks.mm:

(WebCore::IOSApplication::isEcobee): Deleted.
(WebCore::IOSApplication::isQuora): Deleted.
(WebCore::IOSApplication::isXtraMath): Deleted.

Source/WebKit/mac:

  • WebView/WebView.mm:

(shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol):

4:48 PM Changeset in webkit [202718] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Moving flaky expectation for inspector/codemirror/prettyprinting-css-rules.html from mac-wk1 to mac.
https://bugs.webkit.org/show_bug.cgi?id=153460

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
4:24 PM Changeset in webkit [202717] by commit-queue@webkit.org
  • 24 edits
    4 adds in trunk

Web Inspector: Wrong function name next to scope
https://bugs.webkit.org/show_bug.cgi?id=158210
<rdar://problem/26543093>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-30
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Add DebuggerLocation. A helper for describing a unique location.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantRegisters):
When compiled with debug info, add a SymbolTable rare data pointer
back to the CodeBlock. This will be used later to get JSScope debug
info if Web Inspector pauses.

  • runtime/SymbolTable.h:
  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::cloneScopePart):
(JSC::SymbolTable::prepareForTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForOffset):
(JSC::SymbolTable::globalTypeSetForOffset):
(JSC::SymbolTable::globalTypeSetForVariable):
Rename rareData and include a CodeBlock pointer.

(JSC::SymbolTable::rareDataCodeBlock):
(JSC::SymbolTable::setRareDataCodeBlock):
Setter and getter for the rare data. It should only be set once.

(JSC::SymbolTable::visitChildren):
Visit the rare data code block if we have one.

  • runtime/JSSymbolTableObject.h:
  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::deleteProperty):
(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
Give JSSymbolTable its own class info. JSWithScope was unexpectedly
inheriting from JSSymbolTable since it did not have its own and
was using JSScope's class info. Also do a bit of cleanup.

  • debugger/DebuggerLocation.cpp: Added.

(JSC::DebuggerLocation::DebuggerLocation):

  • debugger/DebuggerLocation.h: Added.

(JSC::DebuggerLocation::DebuggerLocation):
Construction from a ScriptExecutable.

  • runtime/JSScope.cpp:

(JSC::JSScope::symbolTable):

  • runtime/JSScope.h:
  • debugger/DebuggerScope.h:
  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::name):
(JSC::DebuggerScope::location):
Name and location for a scope. This uses:
JSScope -> SymbolTable -> CodeBlock -> Executable

  • inspector/protocol/Debugger.json:
  • inspector/InjectedScriptSource.js:

(InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
(InjectedScript.CallFrameProxy._createScopeJson):

  • inspector/JSJavaScriptCallFrame.cpp:

(Inspector::valueForScopeType):
(Inspector::valueForScopeLocation):
(Inspector::JSJavaScriptCallFrame::scopeDescriptions):
(Inspector::JSJavaScriptCallFrame::scopeType): Deleted.

  • inspector/JSJavaScriptCallFrame.h:
  • inspector/JSJavaScriptCallFramePrototype.cpp:

(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeDescriptions):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeType): Deleted.
Simplify this code to build the objects we will send across the protocol
to descript a Scope.

Source/WebInspectorUI:

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
Include new payload data in the construction call.
All the new data is optional, so we gracefully handle
legacy backends.

  • UserInterface/Models/ScopeChainNode.js:

(WebInspector.ScopeChainNode):
(WebInspector.ScopeChainNode.prototype.get type):
(WebInspector.ScopeChainNode.prototype.get objects):
(WebInspector.ScopeChainNode.prototype.get name):
(WebInspector.ScopeChainNode.prototype.get location):
(WebInspector.ScopeChainNode.prototype.get hash):
Hash is a rough (name:sourceId:line:column) string for quick comparisons.

(WebInspector.ScopeChainNode.prototype.makeLocalScope):
Make this an action you take on a scope, to avoid having to
do it at construction time, or making it a generic setting.

  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
This was wrong before. Move the work to CallFrame
and change it to be correct.

  • UserInterface/CallFrame.js:

(WebInspector.CallFrame.prototype.mergedScopeChain):

This transforms the scope chain for a call frame from:

scope1 scope2 scope3 scope4 scope5 scope6 scope7

foo foo foo bar bar - -

Block Closure Closure Closure Closure GLE GBL

To:

scope1 scope2&3 scope4&5 scope6 scope7

foo foo* bar* - -

Block Local Closure GLE GBL

Doing a few things:

  • Merge the first two Closure scopes sharing a location. These are the "var" and "let" Closure scopes in a function, and it is better to present these together in the UI.
  • Mark the first Closure scope within a function (*). When this is displayed in the UI, we can provide the name of the function: "Closure Scope (name)", and we even have location information that we can use to display a goto arrow if needed.
  • Make the first Closure scope the Local scope if it matches the Call Frame's function name. This lets us display the section as "Local Variables".

LayoutTests:

  • inspector/debugger/paused-scopes-expected.txt: Added.
  • inspector/debugger/paused-scopes.html: Added.
  • inspector/debugger/resources/paused-scopes.js: Added.

Test dumps the call frames and scope chains for each call frame
when pausing at different locations in a program. Outputting
the hashes we can see even identically named functions have
different hashes because their location is different.

  • inspector/model/scope-chain-node.html:

Make the test more stable on debug builds which run slower.

4:12 PM Changeset in webkit [202716] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

WebContent crash due to RELEASE_ASSERT(!m_inLoadPendingImages) in StyleResolver::~StyleResolver()
https://bugs.webkit.org/show_bug.cgi?id=159307
<rdar://problem/26184868>

Reviewed by Andreas Kling.

Pseudo elements are resolved in RenderTreeUpdater (instead of Style::TreeResolver). Their resolution may trigger
resource loads which can cause synchronous layout (when failing synchronously) and lead to destruction of the
the style resolver in post layout task.

No known reliable way to test this.

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Use PostResolutionCallbackDisabler in RenderTreeUpdater similarly to Style::TreeResolver. This prevents
post layout tasks from running synchronously and closes this particular crash path.

3:54 PM Changeset in webkit [202715] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.7.6

New tag.

3:35 PM Changeset in webkit [202714] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

missing exception checks in arrayProtoFuncReverse
https://bugs.webkit.org/show_bug.cgi?id=159319
<rdar://problem/27083696>

Reviewed by Filip Pizlo.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncReverse):

3:29 PM Changeset in webkit [202713] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: add pixel area column to layout timeline view
https://bugs.webkit.org/show_bug.cgi?id=148677
<rdar://problem/22518762>

Reviewed by Timothy Hatcher.

The view can simply add the column. LayoutTimelineDataGridNode
already includes area data and cell formatting.

  • UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView):

3:18 PM Changeset in webkit [202712] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

Drawing an SVG image into a <canvas> that is not in the DOM draws the wrong region
https://bugs.webkit.org/show_bug.cgi?id=159276

Patch by Antoine Quint <Antoine Quint> on 2016-06-30
Reviewed by Dean Jackson.

Source/WebCore:

In the event where the <img> element that we are passing to CanvasRenderingContext2D.drawImage()
points to an SVG resource, we ensure that the container for the SVG image is sized to match the
HTML element. The necessity for setting this container size, explained in webkit.org/b/148845,
is that we must ensure a cached image does not have an outdated container size.

Tests: svg/as-image/img-with-svg-resource-in-dom-and-drawImage.html

svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage.html
svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage.html
svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

Adding a series of new tests to check we correctly respect mismatching source and
destination rectangles with SVG images as sources, both with the source <img> element
being present and absent from the DOM, and explicit sizes being set or not set.

  • svg/as-image/img-with-svg-resource-in-dom-and-drawImage-expected.html: Added.
  • svg/as-image/img-with-svg-resource-in-dom-and-drawImage.html: Added.
  • svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage-expected.html: Added.
  • svg/as-image/img-with-svg-resource-in-dom-no-size-and-drawImage.html: Added.
  • svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage-expected.html: Added.
  • svg/as-image/img-with-svg-resource-not-in-dom-and-drawImage.html: Added.
  • svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage-expected.html: Added.
  • svg/as-image/img-with-svg-resource-not-in-dom-no-size-and-drawImage.html: Added.
3:14 PM Changeset in webkit [202711] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: the last normal tab cannot be closed with "Close Tab" context menu item
https://bugs.webkit.org/show_bug.cgi?id=159317
<rdar://problem/27042491>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TabBarItem.js:

(WebInspector.TabBarItem.prototype._handleContextMenuEvent):
(WebInspector.TabBarItem): fix the expression that controls whether the item is disabled.

3:06 PM Changeset in webkit [202710] by sbarati@apple.com
  • 2 edits
    3 adds in trunk/Source/JavaScriptCore

get_by_id_with_this does not trigger a to_this in caller.
https://bugs.webkit.org/show_bug.cgi?id=159226

Reviewed by Keith Miller.

This is a bug if the caller is in sloppy mode and the callee is in strict
mode. This can't happen with ES6 classes because they're all in strict mode,
but it can happen with method syntax on an object literal. The caller must
to_this on |this| when it knows that it performs super property accesses.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • tests/stress/super-property-access-object-literal-to-this-2.js: Added.

(assert):
(test):
(let.o1.get foo):
(let.o2.a):
(let.o2.aa):

  • tests/stress/super-property-access-object-literal-to-this.js: Added.

(assert):
(test):
(let.o1.get foo):
(let.o2.a):
(let.o2.aa):
(let.o2.b):
(let.o2.bb):

  • tests/stress/super-property-access-to-this.js: Added.

(assert):
(test):
(Base.prototype.get foo):
(Base):
(Child.prototype.a):
(Child.prototype.b):
(Child):

2:50 PM Changeset in webkit [202709] by dino@apple.com
  • 2 edits in trunk/Websites/webkit.org

Tab pointed out a typo that made the overdamped case fail.

  • demos/spring/spring.js:

(SpringSolver.prototype.solve):

2:29 PM Changeset in webkit [202708] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.38.2.2/Source

Versioning.

2:28 PM Changeset in webkit [202707] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.2.2

New tag.

2:23 PM Changeset in webkit [202706] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.38.2.100/Source

Versioning.

2:22 PM Changeset in webkit [202705] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.2.100

New tag.

2:20 PM Changeset in webkit [202704] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

getUserMedia() exposed, but not functional
https://bugs.webkit.org/show_bug.cgi?id=158393
<rdar://problem/26642259>

Reviewed by Dean Jackson.

Set default value of the Media Stream runtime flag to false on Mac OS X and iOS until the
browser support is in place.

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures): Disable media stream by default
on Mac OS X and iOS.

  • bindings/generic/RuntimeEnabledFeatures.h:
2:20 PM Changeset in webkit [202703] by bshafiei@apple.com
  • 1 delete in tags/Safari-602.1.38.2.100

Delete tag.

2:19 PM Changeset in webkit [202702] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Add "spring" to transition-timing-function value autocompletion
https://bugs.webkit.org/show_bug.cgi?id=159313
<rdar://problem/27114269>

Reviewed by Timothy Hatcher.

  • UserInterface/Models/CSSKeywordCompletions.js:
2:18 PM Changeset in webkit [202701] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.2.100

New tag.

2:17 PM Changeset in webkit [202700] by Brian Burg
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r202329): WebInspectorProxy's WKPagePolicyClient callbacks are not being called
https://bugs.webkit.org/show_bug.cgi?id=159308
<rdar://problem/27111764>

Reviewed by Tim Horton.

Adopt WKPageNavigationClient and ditch WKPolicyClient and WKPageLoaderClient.
After r202329, it's not possible to set a WKPolicyClient for a WKPage/WebPageProxy that backs a WKWebView.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::isMainOrTestInspectorPage): Take a WebCore::ResourceRequest.
(WebKit::processDidCrash): Deleted.
(WebKit::webProcessDidCrash): Rename to match new client callback name.
(WebKit::decidePolicyForNavigationAction): Rework this to take new argument types.
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
Install a WKPageNavigationClient.

1:51 PM Changeset in webkit [202699] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

1:44 PM Changeset in webkit [202698] by Ryan Haddad
  • 18 edits in trunk/Source/WebCore

Unreviewed, rolling out r202676.
https://bugs.webkit.org/show_bug.cgi?id=159314

This change caused storage/websql tests to crash on Mac and
iOS WK1 (Requested by ryanhaddad on #webkit).

Reverted changeset:

"Purge PassRefPtr in Modules/webdatabase"
https://bugs.webkit.org/show_bug.cgi?id=159255
http://trac.webkit.org/changeset/202676

Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-30

1:29 PM Changeset in webkit [202697] by dino@apple.com
  • 2 edits in trunk/Websites/webkit.org

Fixed a typo in the link to the other version.

  • blog-files/color-gamut/index.html:
1:17 PM Changeset in webkit [202696] by Chris Dumez
  • 5 edits in trunk/Source/WebKit2

[iOS] Process suspension is prevented for 30 seconds after closing a tab
https://bugs.webkit.org/show_bug.cgi?id=159280
<rdar://problem/27014867>

Reviewed by Gavin Barraclough.

When closing a tab, ConnectionTerminationWatchdog takes a background
assertion on behalf of the WebContent process and only releases it
after 30 seconds, allowing for the WebContent process to exit cleanly
without worrying about getting suspended too early.

However, the child process normally exits much sooner than this and
we end up holding a process assertion for no reason for a full 30
seconds anyway. This patch addresses the issue by registering an
invalidation handler with the BKSProcessAssertion and releasing our
our assertion in such case. The invalidation handler gets called
as soon as the child process exits.

  • Platform/spi/ios/AssertionServicesSPI.h:
  • UIProcess/ProcessAssertion.cpp:

(WebKit::ProcessAssertion::ProcessAssertion):

  • UIProcess/ProcessAssertion.h:

(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::validity):

  • UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):
(WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount):
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):
(WebKit::ProcessAssertion::setState): Deleted.

12:15 PM Changeset in webkit [202695] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Keep track of when a WKWebView is blank before the initial non-empty layout
https://bugs.webkit.org/show_bug.cgi?id=159217
<rdar://problem/26071766>

Reviewed by Beth Dakin.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setIsBlankBeforeFirstNonEmptyLayout:]):
(-[WKWebView _didFirstVisuallyNonEmptyLayoutForMainFrame]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):

12:10 PM Changeset in webkit [202694] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[iOS] Media controls are too cramped with small video
https://bugs.webkit.org/show_bug.cgi?id=158815
<rdar://problem/26824238>

Patch by Antoine Quint <Antoine Quint> on 2016-06-30
Reviewed by Eric Carlson.

Source/WebCore:

In updateLayoutForDisplayedWidth(), we try to ensure a minimum width is guaranteed
for the progress indicator. However, we were not accounting for the width used by
the current and remaining time labels on either side of it, so we would incorrectly
conclude that we were guaranteeing the minimum time and yield incorrect layouts since
we were trying to fit more buttons than we had room for.

In order to correctly compute the available width for the progress indicator, we now
have clones of the current and remaining time labels, hidden from video and VoiceOver,
that we update along with the originals. The same styles apply to both clones and
originals, so we may measure the clones to determine the space used by the time labels.
The reason we need to use clones is that if the time labels had previously been hidden
from view, precisely because there was not enough space to display them along with the
progress indicator, then trying to obtain metrics from them would yield 0 since they had
"display: none" styles applied. In order to avoid extra layouts and possible flashing, we
use the clones so that we never have to toggle the "display" property of the originals
just to obtain their measurements.

As a result of this change, we adjust the constant used to set the minimum required
width available to display the progress indicator after all other essential controls
and labels have been measured. That constant used to account for the width of the
time labels, and this is no longer correct.

Test: media/video-controls-drop-and-restore-timeline.html

  • Modules/mediacontrols/mediaControlsApple.css:

(::-webkit-media-controls-time-remaining-display.clone):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.createTimeClones):
(Controller.prototype.removeTimeClass):
(Controller.prototype.addTimeClass):
(Controller.prototype.updateDuration):
(Controller.prototype.updateLayoutForDisplayedWidth):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):

  • Modules/mediacontrols/mediaControlsiOS.css:

(::-webkit-media-controls-time-remaining-display.clone):

  • Modules/mediacontrols/mediaControlsiOS.js:

LayoutTests:

Adjust the output of a couple of tests to account for the time label clones, ensure the video
is wide enough to always have its timeline visible for tests that rely on the timeline being
visible to drag and seek, and finally add a new test.

  • media/controls-drag-timebar.html:
  • media/media-controls-drag-timeline-set-controls-property.html:
  • media/video-controls-drop-and-restore-timeline-expected.txt: Added.
  • media/video-controls-drop-and-restore-timeline.html: Added.
  • platform/mac-yosemite/http/tests/media/hls/video-controls-live-stream-expected.txt:
  • platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
11:46 AM Changeset in webkit [202693] by sbarati@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

We need to to_this when an inner arrow function uses 'this'
https://bugs.webkit.org/show_bug.cgi?id=159290
<rdar://problem/27058322>

Reviewed by Geoffrey Garen.

We put the |this| value into the closure object when there
is an arrow function that uses |this|. However, an arrow function
using |this| wasn't causing the creator of the closure that
holds |this| to to_this its value before putting it in the
closure. That's a huge bug because it means some arrow functions
can capture the raw |this| value, which might be a JSLexicalEnvironment.
This patch fixes this by adding an easy to check to see if any
inner arrow functions use |this|, and if any do, it will to_this
the |this| value.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • tests/stress/to-this-before-arrow-function-closes-over-this-that-starts-as-lexical-environment.js: Added.

(assert):
(obj):
(foo.capture):
(foo.wrapper.let.x.):
(foo2.capture):
(foo2.wrapper.let.x.):
(foo2.wrapper.bar):

11:19 AM Changeset in webkit [202692] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Removing duplicated line from Mac TestExpectations file.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:18 AM Changeset in webkit [202691] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.39/Source/WebKit/mac

Merged r202685. rdar://problem/27092107

11:15 AM Changeset in webkit [202690] by barraclough@apple.com
  • 3 edits in trunk/Source/WebKit2

Cleanup ProcessAssertion RunInBackground management
https://bugs.webkit.org/show_bug.cgi?id=159284

Reviewed by Chris Dumez.

Factor out code that handles taking a background assertion on the UI app into
ProcessAndUIAssertion::updateRunInBackgroundCount helper.

This patch just cleanup to enable a futher fix.

  • UIProcess/ProcessAssertion.h:

(WebKit::ProcessAssertion::state):

  • Added ProcessAndUIAssertion::updateRunInBackgroundCount
  • Added ProcessAndUIAssertion::m_isHoldingBackgroundAssertionOnApp
  • UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount):

  • helper to manage calls to incrementNeedsToRunInBackgroundCount/decrementNeedsToRunInBackgroundCount

(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):

  • call updateRunInBackgroundCount

(WebKit::ProcessAndUIAssertion::~ProcessAndUIAssertion):

changed to use m_isHoldingBackgroundAssertionOnApp

(WebKit::ProcessAndUIAssertion::setState):

  • call updateRunInBackgroundCount
11:13 AM Changeset in webkit [202689] by fpizlo@apple.com
  • 10 edits
    2 adds in trunk

Generators violate bytecode liveness validation
https://bugs.webkit.org/show_bug.cgi?id=159279

Reviewed by Yusuke Suzuki.
PerformanceTests:

Add Basic to our test harness.

Also made some cosmetic changes to the benchmark harness.

  • ES6SampleBench/Basic/basic-tests.yaml: Added.
  • ES6SampleBench/Basic/stress-test.js: Added.

(preciseTime):

  • ES6SampleBench/driver.js:

(Driver):
(Driver.prototype.start):
(Driver.prototype.reportError):

  • ES6SampleBench/glue.js:
  • ES6SampleBench/index.html:

Source/JavaScriptCore:


Fix a liveness bug found by Basic. The problem is that resume's intended liveness rule is:
"live-in is just the token argument", but the liveness analysis thought that the rule was
"live-in is live-out minus defs plus live-at-catch". Clearly these two rules are quite
different. The way this sort of worked before is that we would define the defs of resume
as being equal to our prediction of what the live-outs would be. We did this in the hope
that we would subtract all live-outs. But, this misses the live-at-catch part. So, this
change adds another hack to neutralize live-at-catch.

This would make a lot more sense if we wrote a new liveness analysis that was just for
generator conversion. It could reuse BytecodeUseDef but otherwise it would be a new thing.
It would be easy to write crazy rules for save/resume in such an analysis, especially if
that analysis rewrote the bytecode. We could then just have an op_yield that is a no-op.
We would just record the live-outs of op_yield and use that for rewriting the code in terms
of a switch statement.

  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::stepOverInstruction):
(JSC::BytecodeLivenessAnalysis::dumpResults):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

Tools:


Add Basic to our test harness.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests):

11:06 AM Changeset in webkit [202688] by Brian Burg
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix the macOS Sierra Release configuration after r202642.

  • platform/audio/mac/MediaSessionManagerMac.mm:

(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):
Add missing UNUSED_PARAM for when logging is not enabled.

10:49 AM Changeset in webkit [202687] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking fast/shrink-wrap/rect-shrink-wrap.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=159275

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
10:48 AM Changeset in webkit [202686] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win][Debug] Assertion fails in TestWTF.
https://bugs.webkit.org/show_bug.cgi?id=159299

Reviewed by Alex Christensen.

The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
the assertion failure. Since the variable is actually used, there is no need to use the
UNUSED_PARAM macro.

  • TestWebKitAPI/Tests/WTF/UniqueRef.cpp:

(TestWebKitAPI::TEST):

10:47 AM Changeset in webkit [202685] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Mail crashes on launch at WebCore::PaymentCoordinator::~PaymentCoordinator() + 20
https://bugs.webkit.org/show_bug.cgi?id=159306
rdar://problem/27092107

Reviewed by Tim Horton.

  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Create a WebPaymentCoordinatorClient. Remove an unneeded #import.

(-[WebView _commonInitializationWithFrameName:groupName:]):
Remove an unneeded #import.

10:31 AM Changeset in webkit [202684] by Ryan Haddad
  • 21 edits
    5 deletes in trunk

Unreviewed, rolling out r202659.
https://bugs.webkit.org/show_bug.cgi?id=159305

The test for this change times out on mac-wk2 debug and caused
an existing test to crash. (Requested by ryanhaddad on
#webkit).

Reverted changeset:

"Web Inspector: Wrong function name next to scope"
https://bugs.webkit.org/show_bug.cgi?id=158210
http://trac.webkit.org/changeset/202659

Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-30

10:16 AM Changeset in webkit [202683] by commit-queue@webkit.org
  • 5 edits in trunk

[JSC] Date.setYear() misses timeClip()
https://bugs.webkit.org/show_bug.cgi?id=159289

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-30
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncSetYear):

LayoutTests:

  • js/date-timeClip-large-values-expected.txt:
  • js/script-tests/date-timeClip-large-values.js:

The failures are caused by bugs related to GregorianDateTime.
The last test case is the one covering this patch.

9:19 AM Changeset in webkit [202682] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r202679.
https://bugs.webkit.org/show_bug.cgi?id=159302

Still causing timeouts on media/controls-drag-timebar.html
(Requested by ap on #webkit).

Reverted changeset:

"[iOS] Media controls are too cramped with small video"
https://bugs.webkit.org/show_bug.cgi?id=158815
http://trac.webkit.org/changeset/202679

9:14 AM Changeset in webkit [202681] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk

LayoutTests intermittently failing to run due to issues starting Web Platform Test server
https://bugs.webkit.org/show_bug.cgi?id=159166
<rdar://problem/27051759>

Patch by Youenn Fablet <youennf@gmail.com> on 2016-06-30
Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

Pregenerating certificates.

  • resources/_wpt_certs/.gitignore: Added.
  • resources/_wpt_certs/localhost.key: Added.
  • resources/_wpt_certs/localhost.pem: Added.
  • resources/config.json:

Tools:

Setting the certificate directory to the copied config.json.

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer._copy_webkit_test_files):

8:26 AM Changeset in webkit [202680] by Yusuke Suzuki
  • 45 edits
    1 copy
    47 adds in trunk

[JSC] Implement isFinite / isNaN in JS and make DFG ToNumber accept non number values
https://bugs.webkit.org/show_bug.cgi?id=154022

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

We aim at optimizing @toInteger operation.
While it still has an unoptimized part[1], this patch should be a first step.

We introduce the @toNumber builtin intrinsic operation.
This converts the given value to the JS number by emitting op_to_number bytecode.
Previously @toInteger called C++ @Number constructor for that purpose.

And in DFG, op_to_number is converted to DFG ToNumber node.
During DFG, we attempt to convert this to edge filtering and Identity, but if we fail,
we just fall back to calling the C++ function.

To utilize ToNumber in user-land side, we add a path attempting to convert Number constructor calls
to ToNumber DFG nodes. This conversion is useful because Number(value) is used to convert a value to a number in JS.

Before this patch, we emit simple edge filtering (NumberUse) instead of emitting DFG node like ToNumber for op_to_number.
But emitting ToNumber is useful, because in the case of Number(value), considering value may not be a number is reasonable.

By leveraging @toNumber operation, we rewrite Number.{isFinite, isNaN}, global.{isFinite, isNaN} and @toInteger.

ToNumber DFG node has a value profiling. This profiling is leveraged to determine the result number type of the ToNumber operation.
This value profiling is provided from either NumberConstructor's call operation or op_to_number.

The results (with the added performance tests) show that, while existing cases are performance neutral, the newly added cases gain the performance benefit.
And ASMBench/n-body.c also shows stable ~2% progression.

[1]: https://bugs.webkit.org/show_bug.cgi?id=153738

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/BuiltinNames.h:
  • builtins/GlobalObject.js:

(globalPrivate.isFinite):
(globalPrivate.isNaN):
(globalPrivate.toInteger): Deleted.
(globalPrivate.toLength): Deleted.
(globalPrivate.isDictionary): Deleted.
(globalPrivate.speciesGetter): Deleted.
(globalPrivate.speciesConstructor): Deleted.

  • builtins/GlobalOperations.js: Copied from Source/JavaScriptCore/builtins/GlobalObject.js.

(globalPrivate.toInteger):
(globalPrivate.toLength):
(globalPrivate.isDictionary):
(globalPrivate.speciesGetter):
(globalPrivate.speciesConstructor):

  • builtins/NumberConstructor.js: Added.

(isFinite):
(isNaN):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.json:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitUnaryOp):
(JSC::BytecodeGenerator::emitUnaryOpProfiled):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToNumber):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_toNumber):
(JSC::UnaryPlusNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
We use getPrediction() to retrieve the heap prediction from the to_number bytecode.
According to the benchmark results, choosing getPredictionWithoutOSRExit() causes performance regression (1.5%) in kraken stanford-crypto-aes.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToNumber):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

Always on the heap prediction.

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
As of 64bit version, we carefully manage the register reuse. The largest difference between 32bit and 64bit is
branchIfNotNumber() requires the temporary register. We should not use the result registers for that since
it may be reuse the argument registers and it can break the argument registers before using them to call the operation.
Currently, we allocate the additional temporary register for that scratch register.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
Reuse the argument register for the result if possible. And manually decrement the use count in the middle of the node.
This is similar technique used in ToPrimitive. Typically, the child of ToNumber is only used by this ToNumber node since
we would like to perform the type conversion onto this child node here. So this careful register reuse effectively removes
the spills to call the operation. The example of the actually emitted code is the following.

76:<!2:loc11> ToNumber(Untyped:@68, JS|MustGen|UseAsOther, DoubleimpurenanTopEmpty, R:World, W:Heap, Exits, ClobbersExit, bc#48) predicting DoubleimpurenanTopEmpty

0x7f986d5fe693: test %rax, %r14
0x7f986d5fe696: jz 0x7f986d5fe6a1
0x7f986d5fe69c: jmp 0x7f986d5fe6d1
0x7f986d5fe6a1: mov %rax, %rsi
0x7f986d5fe6a4: mov %rbp, %rdi
0x7f986d5fe6a7: mov $0x2, 0x24(%rbp)
0x7f986d5fe6ae: mov $0x7f98711ea5f0, %r11
0x7f986d5fe6b8: call *%r11
0x7f986d5fe6bb: mov $0x7f982d3f72d0, %r11
0x7f986d5fe6c5: mov (%r11), %r11
0x7f986d5fe6c8: test %r11, %r11
0x7f986d5fe6cb: jnz 0x7f986d5fe88c

It effectively removes the unnecessary spill to call the operation!

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchIfNumber):
(JSC::AssemblyHelpers::branchIfNotNumber):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_number):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_number):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • parser/Nodes.h:

(JSC::UnaryOpNode::opcodeID):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsNaN): Deleted.
(JSC::globalFuncIsFinite): Deleted.

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/MathCommon.h:

(JSC::maxSafeInteger):
(JSC::minSafeInteger):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):
(JSC::numberConstructorFuncIsFinite): Deleted.
(JSC::numberConstructorFuncIsNaN): Deleted.

  • runtime/NumberConstructor.h:
  • tests/stress/Number-isNaN-basics.js: Added.

(numberIsNaNOnInteger):
(testNumberIsNaNOnIntegers):
(verifyNumberIsNaNOnIntegerWithOtherTypes):
(numberIsNaNOnDouble):
(testNumberIsNaNOnDoubles):
(verifyNumberIsNaNOnDoublesWithOtherTypes):
(numberIsNaNNoArguments):
(numberIsNaNTooManyArguments):
(testNumberIsNaNOnConstants):
(numberIsNaNStructTransition):
(Number.isNaN):

  • tests/stress/global-is-finite.js: Added.

(shouldBe):

  • tests/stress/global-is-nan.js: Added.

(shouldBe):

  • tests/stress/global-isNaN-basics.js: Added.

(isNaNOnInteger):
(testIsNaNOnIntegers):
(verifyIsNaNOnIntegerWithOtherTypes):
(isNaNOnDouble):
(testIsNaNOnDoubles):
(verifyIsNaNOnDoublesWithOtherTypes):
(verifyIsNaNOnCoercedTypes):
(isNaNNoArguments):
(isNaNTooManyArguments):
(testIsNaNOnConstants):
(isNaNTypeCoercionSideEffects):
(i.value.isNaNTypeCoercionSideEffects.valueOf):
(isNaNStructTransition):
(isNaN):

  • tests/stress/number-is-finite.js: Added.

(shouldBe):
(test2):
(test3):

  • tests/stress/number-is-nan.js: Added.

(shouldBe):
(test2):
(test3):

  • tests/stress/to-number-basics.js: Added.

(shouldBe):

  • tests/stress/to-number-convert-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

  • tests/stress/to-number-int52.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-convert-to-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

  • tests/stress/to-number-intrinsic-int52.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-intrinsic-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

  • tests/stress/to-number-object.js: Added.

(shouldBe):
(test12):
(object1.valueOf):
(test2):
(test22):
(object2.valueOf):
(test3):
(test32):
(object3.valueOf):

  • tests/stress/to-number-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

LayoutTests:

  • js/regress/Number-isNaN-expected.txt: Added.
  • js/regress/Number-isNaN.html: Added.
  • js/regress/global-isNaN-expected.txt: Added.
  • js/regress/global-isNaN.html: Added.
  • js/regress/script-tests/Number-isNaN.js: Added.
  • js/regress/script-tests/global-isNaN.js: Added.
  • js/regress/script-tests/many-foreach-calls.js:

(i.4.forEach):
(i.array.forEach): Deleted.

  • js/regress/script-tests/to-number-constructor-number-string-number-string.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-only-number.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-only-string.js: Added.

(test):

  • js/regress/script-tests/to-number-constructor-string-number-string-number.js: Added.

(test):

  • js/regress/script-tests/to-number-number-string-number-string.js: Added.

(test):

  • js/regress/script-tests/to-number-only-number.js: Added.

(test):

  • js/regress/script-tests/to-number-only-string.js: Added.

(test):

  • js/regress/script-tests/to-number-string-number-string-number.js: Added.

(test):

  • js/regress/to-number-constructor-number-string-number-string-expected.txt: Added.
  • js/regress/to-number-constructor-number-string-number-string.html: Added.
  • js/regress/to-number-constructor-only-number-expected.txt: Added.
  • js/regress/to-number-constructor-only-number.html: Added.
  • js/regress/to-number-constructor-only-string-expected.txt: Added.
  • js/regress/to-number-constructor-only-string.html: Added.
  • js/regress/to-number-constructor-string-number-string-number-expected.txt: Added.
  • js/regress/to-number-constructor-string-number-string-number.html: Added.
  • js/regress/to-number-number-string-number-string-expected.txt: Added.
  • js/regress/to-number-number-string-number-string.html: Added.
  • js/regress/to-number-only-number-expected.txt: Added.
  • js/regress/to-number-only-number.html: Added.
  • js/regress/to-number-only-string-expected.txt: Added.
  • js/regress/to-number-only-string.html: Added.
  • js/regress/to-number-string-number-string-number-expected.txt: Added.
  • js/regress/to-number-string-number-string-number.html: Added.
8:09 AM Changeset in webkit [202679] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk

[iOS] Media controls are too cramped with small video
https://bugs.webkit.org/show_bug.cgi?id=158815
<rdar://problem/26824238>

Patch by Antoine Quint <Antoine Quint> on 2016-06-30
Reviewed by Eric Carlson.

Source/WebCore:

In updateLayoutForDisplayedWidth(), we try to ensure a minimum width is guaranteed
for the progress indicator. However, we were not accounting for the width used by
the current and remaining time labels on either side of it, so we would incorrectly
conclude that we were guaranteeing the minimum time and yield incorrect layouts since
we were trying to fit more buttons than we had room for.

In order to correctly compute the available width for the progress indicator, we now
have clones of the current and remaining time labels, hidden from video and VoiceOver,
that we update along with the originals. The same styles apply to both clones and
originals, so we may measure the clones to determine the space used by the time labels.
The reason we need to use clones is that if the time labels had previously been hidden
from view, precisely because there was not enough space to display them along with the
progress indicator, then trying to obtain metrics from them would yield 0 since they had
"display: none" styles applied. In order to avoid extra layouts and possible flashing, we
use the clones so that we never have to toggle the "display" property of the originals
just to obtain their measurements.

As a result of this change, we adjust the constant used to set the minimum required
width available to display the progress indicator after all other essential controls
and labels have been measured. That constant used to account for the width of the
time labels, and this is no longer correct.

Test: media/video-controls-drop-and-restore-timeline.html

  • Modules/mediacontrols/mediaControlsApple.css:

(::-webkit-media-controls-time-remaining-display.clone):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.createTimeClones):
(Controller.prototype.removeTimeClass):
(Controller.prototype.addTimeClass):
(Controller.prototype.updateDuration):
(Controller.prototype.updateLayoutForDisplayedWidth):
(Controller.prototype.updateTime):
(Controller.prototype.updateControlsWhileScrubbing):

  • Modules/mediacontrols/mediaControlsiOS.css:

(::-webkit-media-controls-time-remaining-display.clone):

  • Modules/mediacontrols/mediaControlsiOS.js:

LayoutTests:

Adjust the output of this test to account for the time label clones and add a new test.

  • media/video-controls-drop-and-restore-timeline-expected.txt: Added.
  • media/video-controls-drop-and-restore-timeline.html: Added.
  • platform/mac-yosemite/http/tests/media/hls/video-controls-live-stream-expected.txt:
  • platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
7:26 AM Changeset in webkit [202678] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Crash registering AVFoundation media engine
https://bugs.webkit.org/show_bug.cgi?id=159269
<rdar://problem/27017656>

Reviewed by Brent Fulgham.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::mediaEngineVectorLock): New, return the static Lock.
(WebCore::haveMediaEnginesVector): Wrap the naked bool.
(WebCore::buildMediaEnginesVector): Assert that the lock is locked.
(WebCore::installedMediaEngines): Hold the lock while checking/rebuilding the vector.
(WebCore::MediaPlayer::resetMediaEngines): Hold the lock while clearing the vector.

Use SOFT_LINK_CLASS_FOR_SOURCE instead of SOFT_LINK_CLASS because the former uses dispatch_once
to ensure that class loading is thread safe.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::assetCacheForPath):
(WebCore::MediaPlayerPrivateAVFoundationObjC::originsInMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCache):
(WebCore::MediaPlayerPrivateAVFoundationObjC::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createOpenGLVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::waitForVideoOutputMediaDataWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange):
(-[WebCoreAVFPullDelegate setCallback:]):
(-[WebCoreAVFPullDelegate outputMediaDataWillChange:]):
(-[WebCoreAVFPullDelegate outputSequenceWasFlushed:]):

6:37 AM Changeset in webkit [202677] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebCore

[image-decoders] Use final and override in ImageDecoder subclasses
https://bugs.webkit.org/show_bug.cgi?id=159291

Reviewed by Antonio Gomes.

  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::frameSizeAtIndex):

  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/webp/WEBPImageDecoder.h:
1:14 AM Changeset in webkit [202676] by Gyuyoung Kim
  • 18 edits in trunk/Source/WebCore

Purge PassRefPtr in Modules/webdatabase
https://bugs.webkit.org/show_bug.cgi?id=159255

Reviewed by Benjamin Poulain.

As a step to remove PassRefPtr use, this patch cleans it up in Modules/webdatabase.

Additionally unnecessary spaces and tabs are removed too.

  • Modules/webdatabase/ChangeVersionWrapper.cpp:
  • Modules/webdatabase/DOMWindowWebDatabase.h:
  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::~Database):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::runTransaction):

  • Modules/webdatabase/Database.h:
  • Modules/webdatabase/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::allowRead):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):

  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTransactionTask::DatabaseTransactionTask):

  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/SQLCallbackWrapper.h:

(WebCore::SQLCallbackWrapper::SQLCallbackWrapper):

  • Modules/webdatabase/SQLResultSetRowList.h:
  • Modules/webdatabase/SQLStatement.cpp:

(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::sqlError):
(WebCore::SQLStatement::sqlResultSet):

  • Modules/webdatabase/SQLStatement.h:
  • Modules/webdatabase/SQLTransaction.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::transactionError):

  • Modules/webdatabase/SQLTransactionBackend.h:
12:32 AM Changeset in webkit [202675] by Carlos Garcia Campos
  • 6 edits
    6 moves in trunk/Source

[Coordinated Graphics] Move CompositingCoordinator from platform to WebKit2 layer
https://bugs.webkit.org/show_bug.cgi?id=159209

Reviewed by Žan Doberšek.

Source/WebCore:

Remove CompositingCoordinator and its helper classes from the platform layer.

  • platform/TextureMapper.cmake:

Source/WebKit2:

Move CompositingCoordinator and its helper classes to the WebKit2 layer.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/AreaAllocator.cpp.

(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):

  • WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/AreaAllocator.h.

(WebKit::nextPowerOfTwo):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.cpp.

(WebKit::CompositingCoordinator::CompositingCoordinator):
(WebKit::CompositingCoordinator::~CompositingCoordinator):
(WebKit::CompositingCoordinator::setRootCompositingLayer):
(WebKit::CompositingCoordinator::setViewOverlayRootLayer):
(WebKit::CompositingCoordinator::sizeDidChange):
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::timestamp):
(WebKit::CompositingCoordinator::syncDisplayState):
(WebKit::CompositingCoordinator::nextAnimationServiceTime):
(WebKit::CompositingCoordinator::clearPendingStateChanges):
(WebKit::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit::CompositingCoordinator::createRootLayer):
(WebKit::CompositingCoordinator::syncLayerState):
(WebKit::CompositingCoordinator::createImageBackingIfNeeded):
(WebKit::CompositingCoordinator::createImageBacking):
(WebKit::CompositingCoordinator::updateImageBacking):
(WebKit::CompositingCoordinator::clearImageBackingContents):
(WebKit::CompositingCoordinator::removeImageBacking):
(WebKit::CompositingCoordinator::flushPendingImageBackingChanges):
(WebKit::CompositingCoordinator::notifyAnimationStarted):
(WebKit::CompositingCoordinator::notifyFlushRequired):
(WebKit::CompositingCoordinator::paintContents):
(WebKit::CompositingCoordinator::createGraphicsLayer):
(WebKit::CompositingCoordinator::deviceScaleFactor):
(WebKit::CompositingCoordinator::pageScaleFactor):
(WebKit::CompositingCoordinator::createUpdateAtlas):
(WebKit::CompositingCoordinator::removeUpdateAtlas):
(WebKit::CompositingCoordinator::visibleContentsRect):
(WebKit::CompositingCoordinator::mainContentsLayer):
(WebKit::CompositingCoordinator::setVisibleContentsRect):
(WebKit::CompositingCoordinator::deviceOrPageScaleFactorChanged):
(WebKit::CompositingCoordinator::detachLayer):
(WebKit::CompositingCoordinator::commitScrollOffset):
(WebKit::CompositingCoordinator::renderNextFrame):
(WebKit::CompositingCoordinator::purgeBackingStores):
(WebKit::CompositingCoordinator::paintToSurface):
(WebKit::CompositingCoordinator::scheduleReleaseInactiveAtlases):
(WebKit::CompositingCoordinator::releaseInactiveAtlasesTimerFired):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/CompositingCoordinator.h.

(WebKit::CompositingCoordinator::clearRootLayer):
(WebKit::CompositingCoordinator::rootLayer):
(WebKit::CompositingCoordinator::state):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.cpp.

(WebKit::UpdateAtlasSurfaceClient::UpdateAtlasSurfaceClient):
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::paintOnAvailableBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h: Renamed from Source/WebCore/platform/graphics/texmap/coordinated/UpdateAtlas.h.

(WebKit::UpdateAtlas::size):
(WebKit::UpdateAtlas::supportsAlpha):
(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):

Jun 29, 2016:

11:28 PM Changeset in webkit [202674] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

Pass SecurityOrigin as references in CORS check code
https://bugs.webkit.org/show_bug.cgi?id=159263

Patch by Youenn Fablet <youenn@apple.com> on 2016-06-29
Reviewed by Alex Christensen.

No change of behavior.

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cachedImageSet):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestScript):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::updateRequestForAccessControl):
(WebCore::createAccessControlPreflightRequest):
(WebCore::passesAccessControlCheck):

  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::preflightSuccess):
(WebCore::DocumentThreadableLoader::isAllowedRedirect):
(WebCore::DocumentThreadableLoader::securityOrigin):

  • loader/DocumentThreadableLoader.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/LinkLoader.cpp:

(WebCore::preloadIfNeeded):

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::checkCrossOriginAccessControl):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::passesAccessControlCheck):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setAsPotentiallyCrossOrigin):

10:57 PM Changeset in webkit [202673] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix the debug build after r202667

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):
The putDirect was missing the Accessor flag for the GetterSetter.

10:10 PM Changeset in webkit [202672] by benjamin@webkit.org
  • 7 edits in trunk/LayoutTests

Attempt to fix constructor-length.html

I did a rebaseline of constructor-length.html.
I should have updated the test instead.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-29

  • js/dom/constructor-length.html:
  • platform/efl/js/dom/constructor-length-expected.txt:
  • platform/gtk/js/dom/constructor-length-expected.txt:
  • platform/ios-simulator/js/dom/constructor-length-expected.txt:
  • platform/mac/js/dom/constructor-length-expected.txt:
  • platform/win/js/dom/constructor-length-expected.txt:
9:49 PM Changeset in webkit [202671] by adam.bergkvist@ericsson.com
  • 11 edits
    1 move in trunk

WebRTC: Implement MediaEndpointPeerConnection::setConfiguration()
https://bugs.webkit.org/show_bug.cgi?id=159254

Reviewed by Eric Carlson.

Source/WebCore:

Implement MediaEndpointPeerConnection::setConfiguration() which is the
MediaEndpointPeerConnection implementation of RTCPeerConnection.setConfiguration() [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-setconfiguration

Testing: Updated existing test.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setConfiguration):
Implemented.

  • Modules/mediastream/RTCConfiguration.cpp:

(WebCore::RTCConfiguration::initialize):

  • Modules/mediastream/RTCConfiguration.h:

Use shared enums.

  • Modules/mediastream/RTCConfiguration.idl:

Remove 'None'/'Public' IceTransportPolicy enum value (removed from WebRTC 1.0).

  • platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

  • platform/mediastream/MediaEndpointConfiguration.h:

Use shared enums.
(WebCore::MediaEndpointConfiguration::create):

  • platform/mediastream/PeerConnectionStates.h: Renamed from Source/WebCore/Modules/mediastream/PeerConnectionStates.h.

Make shared enums accessible to platform objects (currently MediaEndpointConfiguration).

LayoutTests:

Test configuring an RTCPeerConnection object via the constructor and setConfiguration() and
check the resulting configuration with getConfiguration().

  • fast/mediastream/RTCPeerConnection-getConfiguration-expected.txt:
  • fast/mediastream/RTCPeerConnection-getConfiguration.html:

Remove 'requestIdentity' tests (dictionary member removed from WebRTC 1.0). Add tests for
'bundlePolicy'.

  • platform/gtk/TestExpectations:

Unskip above test.

9:46 PM Changeset in webkit [202670] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(200114): Netflix app does not see ChromeCast
https://bugs.webkit.org/show_bug.cgi?id=159287

Reviewed by Benjamin Poulain.

Change set 200114 changed the behavior of how we check for whether or not we
wrap Objective C init methods in JavaScript constructors. The prior method
checked the version of JavaScriptCore that was linked with the application.
If the application was not directly linked with JavaScriptCore the prior
method indicated that we shouldn't create constructors. The new method uses
the SDK the application was compiled with. Using the new method, an
application compiled with iOS SDK 8.0 or greater would create constructors
and not export init methods to JavaScript. The problem is that an existing
application that hasn't been recompiled will get a different answer using
the new method. We need to come up with a method that works in a compatible
way with existing programs, but provides a newly compiled program with the
"is built with SDK N or greater" check.

Added back the prior check of the version of JavaScriptCore the program was
directly linked against. However we only use this check if we directly linked
with JavaScriptCore. Otherwise we fall through to check against the SDK the
program was built with. Changed the iOS SDK version we check
against to be the new version of iOS, iOS 10.

This provides compatible behavior for existing programs. It may be the case
that some of those programs may require changes when they are rebuilt with the
iOS 10 SDK or later.

  • API/JSWrapperMap.mm:

(supportsInitMethodConstructors):

9:46 PM Changeset in webkit [202669] by dino@apple.com
  • 1 edit in trunk/Websites/webkit.org/demos/spring/index.html

Add a link to the proposal.

  • demos/spring/index.html:
9:39 PM Changeset in webkit [202668] by dino@apple.com
  • 2 edits
    1 add in trunk/Websites/webkit.org

Add the UI JavaScript library to make
other browsers happy.

  • demos/spring/dat.gui.min.js: Added.
  • demos/spring/index.html:
9:24 PM Changeset in webkit [202667] by commit-queue@webkit.org
  • 9 edits in trunk

[JSC] Minor TypedArray fixes
https://bugs.webkit.org/show_bug.cgi?id=159286

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-29
Reviewed by Keith Miller.

Source/JavaScriptCore:

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
See https://tc39.github.io/ecma262/#sec-%typedarray%

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::typedArrayViewPrivateFuncLength):
See https://tc39.github.io/ecma262/#sec-get-%typedarray%.prototype.length

(JSC::typedArrayViewProtoGetterFuncToStringTag):
Yep, that's odd.
See https://tc39.github.io/ecma262/#sec-get-%typedarray%.prototype-@@tostringtag

(JSC::JSTypedArrayViewPrototype::finishCreation):
See the last paragraph of https://tc39.github.io/ecma262/#sec-ecmascript-standard-built-in-objects

LayoutTests:

  • js/script-tests/typedarray-constructors.js:
  • js/script-tests/typedarray-prototype.js:
  • js/typedarray-constructors-expected.txt:
  • js/typedarray-prototype-expected.txt:
9:19 PM Changeset in webkit [202666] by Joseph Pecoraro
  • 5 edits in trunk

Web Inspector: API View of Native DOM APIs looks poor (TypeErrors for native getters)
https://bugs.webkit.org/show_bug.cgi?id=158334
<rdar://problem/26615366>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/InjectedScriptSource.js:

(InjectedScript.prototype._getProperties):
(InjectedScript.prototype._propertyDescriptors):
Do not create fake value property descriptors for native accessors
unless requested. This means, getProperties for a native prototype
should return accessors for native accessors just like it does
for normal non-native accessors (getters/setters).

(InjectedScript.prototype.getProperties):
Do not produce fake value accessors for native accessors.

(InjectedScript.prototype.getDisplayableProperties):
(InjectedScript.RemoteObject.prototype._generatePreview):
Do produce fake value accessors for native accessors.

LayoutTests:

  • inspector/runtime/getProperties-expected.txt:
  • inspector/runtime/getProperties.html:

Improve output for accessors now that getProperties
returns real accessor descriptors for native accessors
instead of fake value descriptors.

9:17 PM Changeset in webkit [202665] by dino@apple.com
  • 1 edit
    3 adds in trunk/Websites/webkit.org

Demo and JS implementation of our spring() animation
timing function.

  • demos/spring/index.html: Added.
  • demos/spring/spring.js: Added.

(SpringSolver):
(SpringSolver.prototype.solve):

8:55 PM Changeset in webkit [202664] by sbarati@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

JSGlobalLexicalEnvironment needs a toThis implementation
https://bugs.webkit.org/show_bug.cgi?id=159285

Reviewed by Mark Lam.

This was a huge oversight of my original implementation. It gave users
of the language direct access to the JSGlobalLexicalEnvironment object.

  • runtime/JSGlobalLexicalEnvironment.cpp:

(JSC::JSGlobalLexicalEnvironment::isConstVariable):
(JSC::JSGlobalLexicalEnvironment::toThis):

  • runtime/JSGlobalLexicalEnvironment.h:

(JSC::JSGlobalLexicalEnvironment::isEmpty):

  • tests/stress/global-lexical-environment-to-this.js: Added.

(assert):
(let.f):
(let.fStrict):

7:34 PM Changeset in webkit [202663] by dino@apple.com
  • 2 edits in trunk/Websites/webkit.org

Small change to wording, and link to the interactive version.

  • blog-files/color-gamut/index.html:
7:09 PM Changeset in webkit [202662] by Hunseop Jeong
  • 2 edits in trunk/Source/WebCore

Unreviewed, CMake build fix - 2.

  • PlatformMac.cmake:
6:03 PM Changeset in webkit [202661] by Hunseop Jeong
  • 4 edits in trunk/Source

Source/WebCore:
Unreviewed, CMake build fix.

  • PlatformMac.cmake:

Source/WebKit2:
Unreviewed, CMake build fix.

  • PlatformMac.cmake:
5:12 PM Changeset in webkit [202660] by jer.noble@apple.com
  • 4 edits
    4 adds in trunk

Unprefix webkit-playsinline.
https://bugs.webkit.org/show_bug.cgi?id=159283

Reviewed by Eric Carlson.

Tests: media/video-playsinline.html

media/video-webkit-playsinline.html

Unprefix the webkit-playsinline content attribute, as an unprefixed version
was added to the HTML spec by <https://github.com/whatwg/html/pull/1444>.
The new 'playsinline' content attribute reflects to a new DOM property of
the same name.

  • html/HTMLAttributeNames.in:
  • html/HTMLVideoElement.idl:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):

4:59 PM Changeset in webkit [202659] by Joseph Pecoraro
  • 21 edits
    5 adds in trunk

Web Inspector: Wrong function name next to scope
https://bugs.webkit.org/show_bug.cgi?id=158210
<rdar://problem/26543093>

Reviewed by Brian Burg.

Source/JavaScriptCore:

Add DebuggerLocation. A helper for describing a unique location.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantRegisters):
When compiled with debug info, add a SymbolTable rare data pointer
back to the CodeBlock. This will be used later to get JSScope debug
info if Web Inspector pauses.

  • runtime/SymbolTable.h:
  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::cloneScopePart):
(JSC::SymbolTable::prepareForTypeProfiling):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForOffset):
(JSC::SymbolTable::globalTypeSetForOffset):
(JSC::SymbolTable::globalTypeSetForVariable):
Rename rareData and include a CodeBlock pointer.

(JSC::SymbolTable::rareDataCodeBlock):
(JSC::SymbolTable::setRareDataCodeBlock):
Setter and getter for the rare data. It should only be set once.

(JSC::SymbolTable::visitChildren):
Visit the rare data code block if we have one.

  • debugger/DebuggerLocation.cpp: Added.

(JSC::DebuggerLocation::DebuggerLocation):

  • debugger/DebuggerLocation.h: Added.

(JSC::DebuggerLocation::DebuggerLocation):
Construction from a ScriptExecutable.

  • runtime/JSScope.cpp:

(JSC::JSScope::symbolTable):

  • runtime/JSScope.h:
  • debugger/DebuggerScope.h:
  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::name):
(JSC::DebuggerScope::location):
Name and location for a scope. This uses:
JSScope -> SymbolTable -> CodeBlock -> Executable

  • inspector/protocol/Debugger.json:
  • inspector/InjectedScriptSource.js:

(InjectedScript.CallFrameProxy.prototype._wrapScopeChain):
(InjectedScript.CallFrameProxy._createScopeJson):

  • inspector/JSJavaScriptCallFrame.cpp:

(Inspector::valueForScopeType):
(Inspector::valueForScopeLocation):
(Inspector::JSJavaScriptCallFrame::scopeDescriptions):
(Inspector::JSJavaScriptCallFrame::scopeType): Deleted.

  • inspector/JSJavaScriptCallFrame.h:
  • inspector/JSJavaScriptCallFramePrototype.cpp:

(Inspector::JSJavaScriptCallFramePrototype::finishCreation):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeDescriptions):
(Inspector::jsJavaScriptCallFramePrototypeFunctionScopeType): Deleted.
Simplify this code to build the objects we will send across the protocol
to descript a Scope.

Source/WebInspectorUI:

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype._scopeChainNodeFromPayload):
Include new payload data in the construction call.
All the new data is optional, so we gracefully handle
legacy backends.

  • UserInterface/Models/ScopeChainNode.js:

(WebInspector.ScopeChainNode):
(WebInspector.ScopeChainNode.prototype.get type):
(WebInspector.ScopeChainNode.prototype.get objects):
(WebInspector.ScopeChainNode.prototype.get name):
(WebInspector.ScopeChainNode.prototype.get location):
(WebInspector.ScopeChainNode.prototype.get hash):
Hash is a rough (name:sourceId:line:column) string for quick comparisons.

(WebInspector.ScopeChainNode.prototype.makeLocalScope):
Make this an action you take on a scope, to avoid having to
do it at construction time, or making it a generic setting.

  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
This was wrong before. Move the work to CallFrame
and change it to be correct.

  • UserInterface/CallFrame.js:

(WebInspector.CallFrame.prototype.mergedScopeChain):

This transforms the scope chain for a call frame from:

scope1 scope2 scope3 scope4 scope5 scope6 scope7

foo foo foo bar bar - -

Block Closure Closure Closure Closure GLE GBL

To:

scope1 scope2&3 scope4&5 scope6 scope7

foo foo* bar* - -

Block Local Closure GLE GBL

Doing a few things:

  • Merge the first two Closure scopes sharing a location. These are the "var" and "let" Closure scopes in a function, and it is better to present these together in the UI.
  • Mark the first Closure scope within a function (*). When this is displayed in the UI, we can provide the name of the function: "Closure Scope (name)", and we even have location information that we can use to display a goto arrow if needed.
  • Make the first Closure scope the Local scope if it matches the Call Frame's function name. This lets us display the section as "Local Variables".

LayoutTests:

  • inspector/debugger/paused-scopes-expected.txt: Added.
  • inspector/debugger/paused-scopes.html: Added.
  • inspector/debugger/resources/paused-scopes.js: Added.

Test dumps the call frames and scope chains for each call frame
when pausing at different locations in a program. Outputting
the hashes we can see even identically named functions have
different hashes because their location is different.

4:28 PM Changeset in webkit [202658] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix null dereferencing after r201441
https://bugs.webkit.org/show_bug.cgi?id=159282
rdar://problem/27082559

Reviewed by Andreas Kling.

No new tests. This is reproducible when dragging from regular to high-DPI displays,
and we don't have testing infrastructure for simulating that.

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::styleResolverChanged):
MediaQueryListListener::queryChanged can mutate the Vector of listeners while we are iterating it.
Copy the Vector of listeners and iterate the copy so we don't go out of bounds.

4:05 PM Changeset in webkit [202657] by Brian Burg
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception page never shows if exception is thrown while processing a protocol event
https://bugs.webkit.org/show_bug.cgi?id=159182

Reviewed by Joseph Pecoraro.

Since we catch exceptions raised during the handling of protocol responses and events, there
is no way for these exceptions to trigger the global exception handler that shows the Uncaught
Exception Reporter sheet. We should show these in the sheet because it makes them get fixed faster.

Add a new entry point, WebInspector.reportInternalError, that takes an error or string and
a free-form map of strings to strings for storing additional information such as message data.
Pass the error and any other relevant details to this entry point, which decides whether to
show the uncaught exception reporter or quietly log the error to Inspector2 console.

In future patches, I would like to do the following once the common errors are fixed:

  • enable reporting via Uncaught Exception Reporter for all engineering builds
  • move internal console.error call sites to use WebInspector.reportInternalError
  • UserInterface/Base/Main.js: Add reportInternalError, which redirects to the uncaught

exception reporter sheet or does console.error. It also adds a console.assert that could
cause the debugger to pause if desired.

  • UserInterface/Debug/UncaughtExceptionReporter.css:

(.sheet-container): Make the report scrollable now that we could potentially show a lot of text.

  • UserInterface/Debug/UncaughtExceptionReporter.js:

(handleError): Also pass along the 'details' poperty.
(formattedEntry): Refactor the code so it additionally prints out the keys and values of
the 'details' property. It does not do any coercions, so callers must convert values to strings.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype._dispatchResponse): Inlined a function.
(InspectorBackendClass.prototype._dispatchResponseToCallback):
(InspectorBackendClass.prototype._dispatchEvent):
Report uncaught exceptions via WebInspector.reportInternalError.

(InspectorBackendClass.prototype._reportProtocolError): Deleted, inlined into the single use site.

4:01 PM Changeset in webkit [202656] by Antti Koivisto
  • 11 edits
    2 adds in trunk/Source/WebCore

Factor pending CSS resources into a struct
https://bugs.webkit.org/show_bug.cgi?id=159268

Reviewed by Andreas Kling.

To fix resource loading related re-entrancy issues in StyleResolver we should move the triggering of
resource loads outside the style resolver. The first step for that is to capture pending resources to a struct.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):

  • css/CSSCursorImageValue.h:
  • css/CSSGradientValue.cpp:

(WebCore::GradientStop::GradientStop):
(WebCore::CSSGradientValue::gradientWithStylesResolved):

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::loadSubimages):
(WebCore::CSSGradientValue::CSSGradientValue):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cachedImageSet):
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):

  • css/CSSImageSetValue.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::State::setParentStyle):
(WebCore::StyleResolver::State::ensurePendingResources):
(WebCore::isAtShadowBoundary):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::filterOperationForType):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingResources):
(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
(WebCore::StyleResolver::loadPendingSVGDocuments): Deleted.
(WebCore::StyleResolver::loadPendingImage): Deleted.
(WebCore::StyleResolver::loadPendingShapeImage): Deleted.
(WebCore::StyleResolver::loadPendingImages): Deleted.

  • css/StyleResolver.h:

(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::document):
(WebCore::StyleResolver::documentSettings):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::applyPropertyToRegularStyle):
(WebCore::StyleResolver::State::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::setFontDirty):
(WebCore::StyleResolver::State::fontDirty):
(WebCore::StyleResolver::State::useSVGZoomRules):
(WebCore::StyleResolver::State::takePendingResources):
(WebCore::StyleResolver::State::cssToLengthConversionData):
(WebCore::StyleResolver::State::cascadeLevel):
(WebCore::StyleResolver::State::setCascadeLevel):
(WebCore::StyleResolver::state):
(WebCore::StyleResolver::State::pendingImageProperties): Deleted.
(WebCore::StyleResolver::State::filtersWithPendingSVGDocuments): Deleted.

  • style/StylePendingResources.cpp: Added.

(WebCore::Style::loadPendingImage):
(WebCore::Style::loadPendingImages):
(WebCore::Style::loadPendingSVGFilters):
(WebCore::Style::loadPendingResources):

Move the functions for triggering the resource loads from StyleResolver.

  • style/StylePendingResources.h: Added.

Add struct for pending resources.

3:41 PM Changeset in webkit [202655] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add "type" and "paymentPass" properties in PaymentMethod
https://bugs.webkit.org/show_bug.cgi?id=159278
rdar://problem/26999112

Reviewed by Dean Jackson.

  • Modules/applepay/cocoa/PaymentMethodCocoa.mm:

(WebCore::toString):
(WebCore::toDictionary):

3:34 PM Changeset in webkit [202654] by sbarati@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

We don't emit TDZ checks for call_eval
https://bugs.webkit.org/show_bug.cgi?id=159277
<rdar://problem/27018801>

Reviewed by Benjamin Poulain.

This is a problem if you're trying to call a TDZ variable
that is named 'eval'.

  • bytecompiler/NodesCodegen.cpp:

(JSC::EvalFunctionCallNode::emitBytecode):

  • tests/stress/variable-named-eval-under-tdz.js: Added.

(shouldThrowTDZ):
(test):
(test.foo):
(throw.new.Error):

3:18 PM Changeset in webkit [202653] by Beth Dakin
  • 2 edits
    1 add in trunk/Source/WebKit2

Add media_icon to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=159273
-and corresponding-
rdar://problem/27087714

Reviewed by Dean Jackson.

  • Resources/mediaIcon.pdf: Added.
  • WebKit2.xcodeproj/project.pbxproj:
3:15 PM Changeset in webkit [202652] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.3

New tag.

3:04 PM Changeset in webkit [202651] by bshafiei@apple.com
  • 1 delete in tags/Safari-602.1.38.2.2

Delete tag.

3:00 PM Changeset in webkit [202650] by mark.lam@apple.com
  • 8 edits in trunk

Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
https://bugs.webkit.org/show_bug.cgi?id=159274

Reviewed by Keith Miller.

Source/JavaScriptCore:

  • jsc.cpp:

(main):

  • llint/LLIntData.cpp:

(JSC::LLInt::initialize):
(JSC::LLInt::Data::finalizeStats):
(JSC::LLInt::compareStats):
(JSC::LLInt::Data::dumpStats):
(JSC::LLInt::Data::ensureStats):
(JSC::LLInt::Data::loadStats):
(JSC::LLInt::Data::resetStats):
(JSC::LLInt::Data::saveStats):

  • llint/LLIntData.h:

(JSC::LLInt::Data::opcodeStats):

  • runtime/Options.cpp:

(JSC::Options::isAvailable):
(JSC::recomputeDependentOptions):
(JSC::Options::initialize):

  • runtime/Options.h:

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(DumpRenderTreeMain):

2:54 PM Changeset in webkit [202649] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking perf/rel-list-remove.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=156561

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
2:48 PM Changeset in webkit [202648] by sbarati@apple.com
  • 5 edits in trunk

Destructuring variable declaration is missing a validation of the syntax of a sub production when there is a rhs
https://bugs.webkit.org/show_bug.cgi?id=159267

Reviewed by Mark Lam.

Source/JavaScriptCore:

We were parsing something without checking if it had a syntax error.
This is wrong for many reasons, but it could actually cause a crash
in a debug build if you parsed particular programs.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVariableDeclarationList):

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
2:23 PM Changeset in webkit [202647] by n_wang@apple.com
  • 4 edits
    2 adds in trunk

AX: Crash in WebCore::Document::focusNavigationStartingNode(WebCore::FocusDirection) const + 128
https://bugs.webkit.org/show_bug.cgi?id=159240

Reviewed by Ryosuke Niwa.

Source/WebCore:

This crash is caused by passing an empty node to ElementTraversal::previous(Node&). When the
focusNavigationStartingNode has been removed and it has no next sibling, we should fallback
to itself for calculating the next focused element.

Test: fast/events/remove-focus-navigation-starting-point-crash.html

  • dom/Document.cpp:

(WebCore::Document::focusNavigationStartingNode):

LayoutTests:

  • fast/events/remove-focus-navigation-starting-point-crash-expected.txt: Added.
  • fast/events/remove-focus-navigation-starting-point-crash.html: Added.
  • platform/ios-simulator/TestExpectations:
1:59 PM Changeset in webkit [202646] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking animations/multiple-backgrounds.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=150942

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
1:17 PM Changeset in webkit [202645] by Ryan Haddad
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r202617.

The LayoutTest from this change crashes under GuardMalloc

Reverted changeset:

"Throw exceptions for invalid number of channels for
ConvolverNode"
https://bugs.webkit.org/show_bug.cgi?id=159238
http://trac.webkit.org/changeset/202617

1:14 PM Changeset in webkit [202644] by andersca@apple.com
  • 7 edits in trunk/Source

Rename addressFields to contactFields
https://bugs.webkit.org/show_bug.cgi?id=159271
rdar://problem/27086955

Reviewed by Beth Dakin.

Source/WebCore:

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::createContactFields):
(WebCore::isValidPaymentRequestPropertyName):
(WebCore::createPaymentRequest):
(WebCore::createAddressFields): Deleted.

  • Modules/applepay/PaymentRequest.h:

(WebCore::PaymentRequest::requiredBillingContactFields):
(WebCore::PaymentRequest::setRequiredBillingContactFields):
(WebCore::PaymentRequest::requiredShippingContactFields):
(WebCore::PaymentRequest::setRequiredShippingContactFields):
(WebCore::PaymentRequest::requiredBillingAddressFields): Deleted.
(WebCore::PaymentRequest::setRequiredBillingAddressFields): Deleted.
(WebCore::PaymentRequest::requiredShippingAddressFields): Deleted.
(WebCore::PaymentRequest::setRequiredShippingAddressFields): Deleted.

Source/WebKit2:

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<PaymentRequest>::encode):
(IPC::ArgumentCoder<PaymentRequest>::decode):
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::encode):
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::decode):
(IPC::ArgumentCoder<PaymentRequest::AddressFields>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::AddressFields>::decode): Deleted.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toPKAddressField):
(WebKit::toPKPaymentRequest):

12:54 PM Changeset in webkit [202643] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, third attempt to fix ASAN build for r202599

  • platform/text/TextCodecReplacement.cpp:

(WebCore::TextCodecReplacement::decode):

12:29 PM Changeset in webkit [202642] by jer.noble@apple.com
  • 9 edits
    1 move
    8 adds in trunk/Source

Adopt MediaRemote.
https://bugs.webkit.org/show_bug.cgi?id=159250

Reviewed by Eric Carlson.

Source/WebCore:

Adopt MediaRemote and use the framework to implement MediaSessionManageMac
and RemoteCommandListenerMac.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/RemoteCommandListener.cpp:
  • platform/audio/PlatformMediaSessionManager.cpp:
  • platform/audio/cocoa/MediaSessionManagerCocoa.cpp: Renamed from Source/WebCore/platform/audio/mac/MediaSessionManagerMac.cpp.

(PlatformMediaSessionManager::updateSessionState):

  • platform/audio/mac/MediaSessionManagerMac.h: Added.
  • platform/audio/mac/MediaSessionManagerMac.mm: Added.

(WebCore::PlatformMediaSessionManager::sharedManager):
(WebCore::PlatformMediaSessionManager::sharedManagerIfExists):
(WebCore::MediaSessionManagerMac::MediaSessionManagerMac):
(WebCore::MediaSessionManagerMac::~MediaSessionManagerMac):
(WebCore::MediaSessionManagerMac::sessionWillBeginPlayback):
(WebCore::MediaSessionManagerMac::removeSession):
(WebCore::MediaSessionManagerMac::sessionWillEndPlayback):
(WebCore::MediaSessionManagerMac::clientCharacteristicsChanged):
(WebCore::MediaSessionManagerMac::nowPlayingEligibleSession):
(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):

  • platform/cocoa/SoftLinking.h:
  • platform/mac/MediaRemoteSoftLink.cpp: Added.
  • platform/mac/MediaRemoteSoftLink.h: Added.
  • platform/mac/RemoteCommandListenerMac.h: Added.

(WebCore::RemoteCommandListenerMac::createWeakPtr):

  • platform/mac/RemoteCommandListenerMac.mm: Added.

(WebCore::RemoteCommandListener::create):
(WebCore::RemoteCommandListenerMac::RemoteCommandListenerMac):
(WebCore::RemoteCommandListenerMac::~RemoteCommandListenerMac):

  • platform/spi/mac/MediaRemoteSPI.h: Added.

Source/WebKit2:

Add a sandbox exception allowing access to the mediaremoted XPC service.

  • WebProcess/com.apple.WebProcess.sb.in:

Source/WTF:

Add USE_MEDIAREMOTE.

  • wtf/Platform.h:
12:22 PM Changeset in webkit [202641] by jer.noble@apple.com
  • 5 edits in trunk

Cannot clear a MediaSource SourceBuffer in Safari 9 and WebKit nightly
https://bugs.webkit.org/show_bug.cgi?id=159230

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-remove.html (modified)

Move to using a MediaTime directly (rather than as a double) to add
and removed buffered ranges. Also, drop the use of the "microsecond"
fudge factor when adding buffered ranges.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

LayoutTests:

  • media/media-source/media-source-remove.html:
  • media/media-source/media-source-remove-expected.txt:
12:19 PM Changeset in webkit [202640] by commit-queue@webkit.org
  • 4 edits in trunk

WKWebView should ask WKNavigationDelegate about bad ssl certificates
https://bugs.webkit.org/show_bug.cgi?id=159176
Source/WebKit2:

rdar://problem/26864882

Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-29
Reviewed by Sam Weinig.

This can be tested manually by visiting a site in MiniBrowser that has invalid ssl certificates, but we don't have proper ssl testing yet.
Before this change, we would just open the site as if nothing were invalid, now we call the WKNavigationDelegate's didReceiveAuthenticationChallenge
like we did before using NSURLSession, and we do not open the page, also like we did before using NSURLSession.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
When using NSURLConnection and responding to canAuthenticateAgainstProtectionSpace with YES,
we get an NSURLAuthenticationChallenge when a bad ssl certificate is encountered in the handshake.
When using NSURLSession, we want to call webView:didReceiveAuthenticationChallenge:completionHandler: in this case.
The default implementation of NavigationState::NavigationClient::canAuthenticateAgainstProtectionSpace returns true
if there is an implementation of webView:didReceiveAuthenticationChallenge:completionHandler: in its WKNavigationDelegate.
Internal clients can implement _webView:canAuthenticateAgainstProtectionSpace:
and Safari uses canHandleHTTPSServerTrustEvaluation, so it will be unaffected.

Tools:

Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-29
Reviewed by Sam Weinig.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
(-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
(-[WK2BrowserWindowController webView:didFailNavigation:withError:]):

11:49 AM Changeset in webkit [202639] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.38.2.2/Source

Versioning.

11:48 AM Changeset in webkit [202638] by Beth Dakin
  • 8 edits
    3 deletes in trunk/Source/WebKit2

Delete WKElementInfo since it's not used
https://bugs.webkit.org/show_bug.cgi?id=159265

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WebKit.h:
  • UIProcess/API/Cocoa/WKElementInfo.h: Removed.
  • UIProcess/API/Cocoa/WKElementInfo.mm: Removed.
  • UIProcess/API/Cocoa/WKElementInfoInternal.h: Removed.
  • UIProcess/API/Cocoa/WKPreviewElementInfo.h:
  • UIProcess/API/Cocoa/WKPreviewElementInfo.mm:

(-[WKPreviewElementInfo _initWithLinkURL:]):
(-[WKPreviewElementInfo copyWithZone:]):
(-[WKPreviewElementInfo linkURL]):

  • UIProcess/API/Cocoa/WKPreviewElementInfoInternal.h:
  • UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
  • UIProcess/API/Cocoa/_WKContextMenuElementInfo.mm:

(-[_WKContextMenuElementInfo copyWithZone:]):

  • WebKit2.xcodeproj/project.pbxproj:
11:45 AM Changeset in webkit [202637] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.38.2.2

New tag.

11:43 AM Changeset in webkit [202636] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, second attempt to fix ASAN build for r202599

  • platform/text/TextCodecReplacement.cpp:
11:40 AM Changeset in webkit [202635] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, first attempt to fix ASAN build for r202599

  • platform/text/TextCodecReplacement.cpp:
11:36 AM Changeset in webkit [202634] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Web Inspector: Show Shadow Root type in DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=159236
<rdar://problem/27068521>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-29
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/DOM.json:

Include optional shadowRootType property for DOMNodes.

Source/WebCore:

Test: inspector/dom/shadowRootType.html

  • inspector/InspectorDOMAgent.cpp:

(WebCore::shadowRootType):
(WebCore::InspectorDOMAgent::buildObjectForNode):
Set the shadowRootType property when a node is a ShadowRoot.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:

"Shadow Content (type)" string.

  • UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.shadowRoots):
(WebInspector.DOMNode.prototype.shadowRootType):
Initialize state and add accessors.

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.shadowRootTypeDisplayName):
(WebInspector.DOMTreeElement.prototype._nodeTitleInfo):
Better string when an element is a Shadow Root.

  • UserInterface/Views/DOMTreeElementPathComponent.js:

(WebInspector.DOMTreeElementPathComponent):
Better to check the Shadow Root type.

  • UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom .html-fragment.shadow):
Opacity looks poor when there is a selection. Switch to gray.

LayoutTests:

  • inspector/dom/shadowRootType-expected.txt: Added.
  • inspector/dom/shadowRootType.html: Added.
11:25 AM Changeset in webkit [202633] by commit-queue@webkit.org
  • 15 edits
    2 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r202627.
https://bugs.webkit.org/show_bug.cgi?id=159266

patch is broken on arm (Requested by keith_miller on #webkit).

Reverted changeset:

"LLInt should support other types of prototype GetById
caching."
https://bugs.webkit.org/show_bug.cgi?id=158083
http://trac.webkit.org/changeset/202627

11:17 AM Changeset in webkit [202632] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

11:16 AM Changeset in webkit [202631] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

[JSC] Fix small issues of TypedArray prototype
https://bugs.webkit.org/show_bug.cgi?id=159248

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-29
Reviewed by Saam Barati.

Source/JavaScriptCore:

First, TypedArray's toString and Array's toString
should be the same function.
I moved the function to GlobalObject and each array type
gets it as needed.

Then TypedArray length was supposed to be configurable.
I removed the "DontDelete" flag accordingly.

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::arrayProtoToStringFunction):

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

LayoutTests:

  • js/script-tests/typedarray-prototype.js: Added.
  • js/typedarray-prototype-expected.txt: Added.
  • js/typedarray-prototype.html: Added.
11:11 AM Changeset in webkit [202630] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.39

New tag.

10:42 AM Changeset in webkit [202629] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Replace MPAudioVideoRoutingActionSheet with MPAVRoutingSheet.
https://bugs.webkit.org/show_bug.cgi?id=159161
<rdar://problem/26017691>

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-06-29
Reviewed by Sam Weinig.

Source/WebCore:

Replace MPAudioVideoRoutingActionSheet SPI with MPAVRoutingSheet SPI.

  • platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit2:

MPAudioVideoRoutingActionSheet is being replaced by MPAVRoutingSheet,
with only minor changes to the interface.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]):

10:36 AM Changeset in webkit [202628] by commit-queue@webkit.org
  • 4 edits in trunk

WebRTC: ice-char can not contain '=' characters for credentials
https://bugs.webkit.org/show_bug.cgi?id=159207

Patch by Alejandro G. Castro <alex@igalia.com> on 2016-06-29
Reviewed by Eric Carlson.

Source/WebCore:

Avoid a general calculation to get a base64 without padding which
was wrong in the randomString function. Because each parameter
using the function requires a different setup depending of the
specification and this is not a general API, it is a better
solution to calculate and store the sizes we want to use, comment
them and test them, considering we use base64 to generate the
strings we just need to avoid padding.

Existing test modified to match the correct behavior.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::randomString): Now the size is the one passed.
(WebCore::MediaEndpointPeerConnection::MediaEndpointPeerConnection):
Used different valid values following the sdp parser in each case.

LayoutTests:

Modified the parser to make the regexp similar to the one we have
in WebCore.

  • fast/mediastream/resources/sdp-utils.js:

(printComparableSessionDescription):

9:53 AM Changeset in webkit [202627] by commit-queue@webkit.org
  • 15 edits
    2 adds in trunk/Source/JavaScriptCore

LLInt should support other types of prototype GetById caching.
https://bugs.webkit.org/show_bug.cgi?id=158083

Recently, we started supporting prototype load caching for get_by_id
in the LLInt. This patch is expading the caching strategy to enable
cache the prototype accessor and custom acessors.

Similarly to the get_by_id_proto_load bytecode, we are adding new
bytecodes called get_by_id_proto_accessor that uses the calculated
offset of a object to call a getter function and get_by_id_proto_custom
that stores the pointer to the custom function and call them directly
from LowLevelInterpreter.

Patch by Caio Lima <Caio Lima> on 2016-06-29
Reviewed by Keith Miller

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeLLIntInlineCaches):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setupGetByIdPrototypeCache):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
9:50 AM Changeset in webkit [202626] by ddkilzer@apple.com
  • 4 edits
    2 adds in trunk

Crash when 'input' event handler for input[type=color] changes the input type
<https://webkit.org/b/159262>
<rdar://problem/27020404>

Reviewed by Daniel Bates.

Source/WebCore:

Fix based on a Blink change (patch by <tkent@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/a17cb3ecef49a078657524cdeaba33ad2083646c>

Test: fast/forms/color/color-type-change-on-input-crash.html

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::didChooseColor): Add EventQueueScope
before setValueFromRenderer() to fix the bug.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::setValueFromRenderer): Add comment
about how to use this method.

LayoutTests:

Test based on a Blink change (patch by <tkent@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/a17cb3ecef49a078657524cdeaba33ad2083646c>

  • fast/forms/color/color-type-change-on-input-crash-expected.txt: Added.
  • fast/forms/color/color-type-change-on-input-crash.html: Added.
9:18 AM Changeset in webkit [202625] by adam.bergkvist@ericsson.com
  • 10 edits in trunk

WebRTC: Misc MediaStreamEvent fixes: Update build flag and remove PassRefPtr usage
https://bugs.webkit.org/show_bug.cgi?id=159132

Reviewed by Eric Carlson.

Source/WebCore:

Use the WEB_RTC build flag instead of MEDIA_STREAM since this event is related to
RTCPeerConnection. Also remove PassRefPtr usage.

Updated existing expected results.

  • Modules/mediastream/MediaStreamEvent.cpp:

(WebCore::MediaStreamEvent::create):
(WebCore::MediaStreamEvent::MediaStreamEvent):

  • Modules/mediastream/MediaStreamEvent.h:
  • Modules/mediastream/MediaStreamEvent.idl:
  • dom/EventNames.in:

LayoutTests:

Update skip lists and expected results to not expect the MediaStreamEvent constructor in
the global scope (it's under the WEB_RTC build flag).

  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:

(all above) Remove expected results associated with MediaStreamEvent constructor.

  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:

Skip MediaStreamEvent constructor test on ports that dont't build with WEB_RTC yet.

9:10 AM Changeset in webkit [202624] by adam.bergkvist@ericsson.com
  • 3 edits in trunk/Source/WebCore

REGRESSION(r202337) [WebRTC] Crash when loading html5test.com
https://bugs.webkit.org/show_bug.cgi?id=159145

Reviewed by Eric Carlson.

MediaEndpointPeerConnection uses an implementation of the MediaEndpoint interface to
interact with the port's WebRTC backend. A mock (MockMediaEndpoint) is used for testing.
This change adds an "empty" MediaEndpoint implementation that simplifies the case when a
port builds and tests with MediaEndpointPeerConnection/MockMediaEndpoint, but doesn't have
a "real" MediaEndpoint implementation yet (to use with MiniBrowser).

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::MediaEndpointPeerConnection):

  • platform/mediastream/MediaEndpoint.cpp:

(WebCore::EmptyRealtimeMediaSource::create):
(WebCore::EmptyRealtimeMediaSource::EmptyRealtimeMediaSource):
(WebCore::EmptyMediaEndpoint::EmptyMediaEndpoint):
(WebCore::createMediaEndpoint):

6:14 AM Changeset in webkit [202623] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Fix the expectations for crypto/subtle tests after r202535.
https://bugs.webkit.org/show_bug.cgi?id=159260

Unreviewed.

  • platform/gtk/TestExpectations: Skip properly the crypto/subtle tests.
5:21 AM Changeset in webkit [202622] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Add missing install dependency after r202619
https://bugs.webkit.org/show_bug.cgi?id=156716

Unreviewed.

  • gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
5:16 AM Changeset in webkit [202621] by Carlos Garcia Campos
  • 14 edits in trunk/Source/WebKit2

Too much duplicated code in LayerTreeHosts implementations
https://bugs.webkit.org/show_bug.cgi?id=159144

Reviewed by Žan Doberšek.

There's some code common and duplicated in all current LayerTreeHosts implementations (Gtk, Coordinated, and
ThreadedCoordinated). The thing is even worse in the case of ThreadedCoordinated and Coordinated, where the
former is actually a special case of the later, and it seems like code was copy pasted and then modified to add
ThreadedCoordinated specific code. The problem of that approach, apart from the code duplication, is that common
parts end up diverging too. This patch moves the common parts to the base class LayerTreeHost and makes
ThreadedCoordinatedLayerTreeHost inherit from CoordinatedLayerTreeHost, to share the common code and simply add
the specific one.

  • PlatformGTK.cmake:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::scheduleLayerFlush):
(WebKit::CoordinatedLayerTreeHost::setViewOverlayRootLayer):
(WebKit::CoordinatedLayerTreeHost::setRootCompositingLayer):
(WebKit::CoordinatedLayerTreeHost::invalidate):
(WebKit::CoordinatedLayerTreeHost::sizeDidChange):
(WebKit::CoordinatedLayerTreeHost::layerFlushTimerFired):
(WebKit::CoordinatedLayerTreeHost::commitSceneState):
(WebKit::CoordinatedLayerTreeHost::createCoordinatedSurface):
(WebKit::CoordinatedLayerTreeHost::cancelPendingLayerFlush): Deleted.
(WebKit::CoordinatedLayerTreeHost::forceRepaint): Deleted.
(WebKit::CoordinatedLayerTreeHost::forceRepaintAsync): Deleted.
(WebKit::CoordinatedLayerTreeHost::didFlushRootLayer): Deleted.
(WebKit::CoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged): Deleted.
(WebKit::CoordinatedLayerTreeHost::pageBackgroundTransparencyChanged): Deleted.
(WebKit::CoordinatedLayerTreeHost::graphicsLayerFactory): Deleted.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost):
(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange):
(WebKit::ThreadedCoordinatedLayerTreeHost::setVisibleContentsRect):
(WebKit::ThreadedCoordinatedLayerTreeHost::commitSceneState):
(WebKit::ThreadedCoordinatedLayerTreeHost::create): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::contentsSizeChanged): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportProperties): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::didScaleFactorChanged): Deleted.
(WebKit::ThreadedCoordinatedLayerTreeHost::setNativeSurfaceHandleForCompositing): Deleted.

  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerHostDidFlushLayers):

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::~LayerTreeHost):
(WebKit::LayerTreeHost::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHost::pauseRendering):
(WebKit::LayerTreeHost::resumeRendering):
(WebKit::LayerTreeHost::invalidate):

  • WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::layerTreeContext):
(WebKit::LayerTreeHost::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHost::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHost::scrollNonCompositedContents):
(WebKit::LayerTreeHost::graphicsLayerFactory):
(WebKit::LayerTreeHost::contentsSizeChanged):
(WebKit::LayerTreeHost::didChangeViewportProperties):
(WebKit::LayerTreeHost::setNativeSurfaceHandleForCompositing):
(WebKit::LayerTreeHost::setViewOverlayRootLayer):
(WebKit::LayerTreeHost::forceRepaintAsync): Deleted.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::invalidate):
(WebKit::LayerTreeHostGtk::setViewOverlayRootLayer):
(WebKit::LayerTreeHostGtk::LayerTreeHostGtk): Deleted.
(WebKit::LayerTreeHostGtk::setRootCompositingLayer): Deleted.
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay): Deleted.
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents): Deleted.
(WebKit::LayerTreeHostGtk::setNativeSurfaceHandleForCompositing): Deleted.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
4:52 AM Changeset in webkit [202620] by alex
  • 2 edits in trunk/Source/WebCore

Fix assertion in debug build when creating the SocketStreamHandle object.

We have to call relaxAdoptionRequirement to avoid the assertion
when protecting the non-adopted SocketStreamHandle we are
creating. Update to r202370.

Rubber-stamped by Carlos Garcia Campos.

  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):

3:52 AM RebaselineServer edited by Konstantin Tokarev
NWRT has superceded old run-webkit-tests (diff)
3:47 AM WikiStart edited by Konstantin Tokarev
Fixed typo momory -> memory (diff)
3:31 AM Changeset in webkit [202619] by clopez@igalia.com
  • 9 edits
    3 adds in trunk

[GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
https://bugs.webkit.org/show_bug.cgi?id=156716

Reviewed by Carlos Garcia Campos and Michael Catanzaro.

Tools:

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland

(parse_args):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.init):
(GtkPort._driver_class):
(GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
(GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
platform directory for storing the wayland specific layout test results and expectations for ${port}.
For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
test expectations file on the GTK port when running the tests with the --wayland command line switch.
Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.

  • Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.

(WestonDriver.check_driver):
(WestonDriver.init):
(WestonDriver._start):

  • Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.

(WestonXvfbDriverDisplayTest):
(WestonXvfbDriverDisplayTest.init):
(WestonXvfbDriverDisplayTest._xvfb_run):
(WestonDriverTest.make_driver):
(WestonDriverTest.test_start):

  • gtk/install-dependencies: Add the new dependencies that are required for either building weston,

or to satisfy the pkg-config check of the new added modules in JHBuild.

  • gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland

and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
provided by the system are already new enough.
Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
It was the only way to get the software EGL rasterizer working without depending on user drivers.
Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
feature to avoid building libdrm when the one provided by the system is new enough.

  • gtk/jhbuildrc:
  • gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.

Xorg had no support for searching the DRI drivers on a custom path at runtime.
This patch implements support for that reusing the same variable that we use with Mesa to set the
custom path for the DRI drivers path.

LayoutTests:

  • platform/gtk-wayland/TestExpectations: Added. Add initial Wayland specific test expectations.
3:28 AM Changeset in webkit [202618] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
https://bugs.webkit.org/show_bug.cgi?id=159256

Patch by Alejandro G. Castro <alex@igalia.com> on 2016-06-29
Reviewed by Philippe Normand.

We need the last fixes in the repository to make the scream queue
work with apprtc.

  • gtk/jhbuild.modules:
3:19 AM Changeset in webkit [202617] by ddkilzer@apple.com
  • 3 edits
    3 adds in trunk

Throw exceptions for invalid number of channels for ConvolverNode
<https://webkit.org/b/159238>
<rdar://problem/27020410>

Reviewed by Brent Fulgham.

Source/WebCore:

Fix based on a Blink change (patch by <rtoy@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/0cc26bbb7175aec77910d0b47faf9f8c8a640fe5>

Test: webaudio/convolver-channels.html

  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::setBuffer): Throw an exception for
anything but 1, 2 or 4 channels.

LayoutTests:

Test based on a Blink change (patch by <rtoy@chromium.org>):
<https://chromium.googlesource.com/chromium/src.git/+/0cc26bbb7175aec77910d0b47faf9f8c8a640fe5>

compatibility.js based on a Blink change (patch by <Raymond Toy>):
<https://chromium.googlesource.com/chromium/src.git/+/f846f5a461d1fcdbe5152898576c125058079ed1>

  • webaudio/convolver-channels-expected.txt: Added.
  • webaudio/convolver-channels.html: Added.
  • webaudio/resources/compatibility.js: Added.
12:23 AM Changeset in webkit [202616] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

REGRESSION(r198782, r201043): [image-decoders] Flickering with some animated gif
https://bugs.webkit.org/show_bug.cgi?id=159089

Reviewed by Antonio Gomes.

There's some flickering when loading big enough animated gifs running the animation in a loop. The first time it
loads everything is fine, but after the first loop iteration there are several flickering effects, once every
time the animation finishes and some others happening in the middle of the animation loop. The flickering
happens because we fail to render some of the frames, and it has two diferent causes:

  • In r198782, ImageDecoder::createFrameImageAtIndex(), was modified to check first if the image is empty to

return early, and then try to get the frame image from the decoder. This is the aone causing the flickering
always on the first frame after one iteration. It happens because ImageDecoder::size() is always empty at that
point. The first time doesn't happen because the gif is loaded and BitmapImage calls isSizeAvailable() from
BitmapImage::dataChanged(). The isSizeAvailable call makes the gif decoder calculate the size. But for the next
iterations, frames are cached and BitmapImage already has the decoded data so isSizeAvailable is not called
again. When createFrameImageAtIndex() is called again for the first frame, size is empty until the gif decoder
creates the reader again, which happens when frameBufferAtIndex() is called, so after that the size is
available. So, we could call isSizeAvailable before checking the size, or simply do the check after the
frameBufferAtIndex() call as we used to do.

  • In r201043 BitmapImage::destroyDecodedDataIfNecessary() was fixed to use the actual bytes used by the frame

in order to decide whether to destroy decoded data or not. This actually revealed a bug, it didn't happen before
because we were never destroying frames before. The bug is in the gif decoder that doesn't correctly handle the
case of destroying only some of the frames from the buffer cache. The gif decoder is designed to always process the
frames in order, the reader keeps an index of the currently processed frame, so when some frames are read from the
cache, and then we ask the decoder for a not cached frame, the currently processed frame is not in sync with the
actual frame we are asking for, and we end do not processing any frame at all.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Check the size after calling frameBufferAtIndex().

  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::clearFrameBufferCache): Delete the reader when clearing the cache since it's out of sync.

Note: See TracTimeline for information about the timeline view.