Timeline



Aug 18, 2016:

10:42 PM Changeset in webkit [204628] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore

Merge r204572. rdar://problem/27889416

8:07 PM Changeset in webkit [204627] by dbates@webkit.org
  • 7 edits in trunk/Source

Ld warns of non-existent PrivateFrameworks directory when building WebKit with the public iOS 9.3 SDK
​https://bugs.webkit.org/show_bug.cgi?id=160979

Rubber-stamped by Simon Fraser.

Only add the SDK PrivateFrameworks directory to the FRAMEWORK_SEARCH_PATH when building for
iOS Simulator, building with an iOS SDK that does not support text-based stubs, or building
an Apple-internal build.

Source/WebCore:

  • Configurations/Base.xcconfig: Define WK_TARGET_IOS_VERSION_MAJOR.
  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

  • Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

  • Configurations/BaseTarget.xcconfig:
7:53 PM Changeset in webkit [204626] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Re-landing:

Support WebIDL unions (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=160769

Reviewed by Chris Dumez.

This is the first part of an effort to add support for union types
in our code generators. This change:

  • Adds a domType struct to hold the parsed type information. For now, we only use it temporarily while parsing, and don't expose it to the code generators, but that will change in a later patch.
  • Remove support for scoped identifiers for types. They are not supported by WebIDL.
  • Make debugging the parser easier by providing backtraces when asserting.

There should be no observable changes.

  • bindings/scripts/IDLParser.pm:
7:44 PM Changeset in webkit [204625] by Hunseop Jeong
  • 2 edits in trunk/Source/WebKit2

Unreviewed, Fix CMake build after r204614

  • PlatformMac.cmake:
7:40 PM Changeset in webkit [204624] by Chris Dumez
  • 19 edits in trunk

Move prefix / namespaceURI / localName attributes from Node to Attr / Element
​https://bugs.webkit.org/show_bug.cgi?id=160988

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C test now that more checks are passing.

  • web-platform-tests/dom/historical-expected.txt:
  • web-platform-tests/dom/interfaces-expected.txt:

Source/WebCore:

Move prefix / namespaceURI / localName attributes from Node to Attr / Element
as per the latest DOM specification:

Firefox and Chrome match the specification.

No new tests, rebaselined existing tests.

  • dom/Attr.h:
  • dom/Attr.idl:
  • dom/Element.h:
  • dom/Element.idl:
  • dom/Node.idl:

LayoutTests:

Update existing layout tests to reflect behavior change.

  • fast/dom/Node/initial-values-expected.txt:
  • fast/dom/Node/script-tests/initial-values.js:
  • http/tests/misc/createElementNamespace1-expected.txt:
  • http/tests/misc/createElementNamespace1.xml:
  • http/tests/misc/createElementNamespace2-expected.txt:
  • http/tests/misc/createElementNamespace2.xhtml:
  • http/tests/misc/createElementNamespace3-expected.txt:
  • http/tests/misc/createElementNamespace3.html:
  • js/dom/dom-static-property-for-in-iteration-expected.txt:
7:37 PM Changeset in webkit [204623] by Chris Dumez
  • 7 edits in trunk/LayoutTests/imported/w3c

Re-sync DOM web platform tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=160980

Reviewed by Ryosuke Niwa.

Re-sync DOM web platform tests from upstream.

  • web-platform-tests/dom/events/Event-initEvent-expected.txt:
  • web-platform-tests/dom/events/Event-initEvent.html:
  • web-platform-tests/dom/events/Event-propagation-expected.txt:
  • web-platform-tests/dom/events/Event-propagation.html:
  • web-platform-tests/dom/nodes/Node-properties.html:
6:41 PM Changeset in webkit [204622] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.2.2

New tag.

6:07 PM Changeset in webkit [204621] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

[iOS] Network Processes & Database processes do not exit promptly
​https://bugs.webkit.org/show_bug.cgi?id=160978
<rdar://problem/27914081>

Reviewed by Anders Carlsson.

Network Processes & Database processes do not exit promptly. They hang
for 10 seconds until they log the following message:

com.apple.WebKit.Networking: (WebKit) #WK: Exiting process early due to unacknowledged closed-connection

Then forcefully call exit(0).

To address the issue, we now call ChildProcess::stopRunLoop() instead
of RunLoop::current().stop(). stopRunLoop() works as expected on iOS
after r202723.

There is no impact on Mac because stopRunLoop() calls
RunLoop::current().stop().

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):

6:01 PM Changeset in webkit [204620] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Binding NULL pointer to reference in WebCore::RenderObject
​https://bugs.webkit.org/show_bug.cgi?id=160830

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-18
Reviewed by Myles C. Maxfield.

No new tests needed, existing functionality not changed.

Fixes a dereferenced NULL pointer bound to a reference through a minor re-factor.

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::clear): Explicit clear occurs, instead of a call to moveTo.
(WebCore::InlineIterator::moveToStartOf): Swapped pointer for reference.
(WebCore::InlineIterator::moveTo): Swapped pointer for reference.
(WebCore::InlineIterator::increment): Explicitly call clear for clarity.

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::commitLineBreakClear): Commit a line break and clear the iterator.
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth): Swapped pointer for reference.
(WebCore::BreakingContext::InlineIteratorHistory::moveTo): Swapped pointer for reference.
(WebCore::BreakingContext::increment): Explicitly call clear for clarity.
(WebCore::BreakingContext::handleBR): Swapped pointer for passed reference.
(WebCore::BreakingContext::handleReplaced): Explicitly call clear for clarity.
(WebCore::tryHyphenating): Swapped pointer for passed reference.
(WebCore::BreakingContext::handleText): Replaced all render object passing with references. Note that the caller explicitly checks if m_current.renderer() exists before calling this function.
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded): Explicitly call clear for clarity.
(WebCore::BreakingContext::handleEndOfLine): Explicitly call clear for clarity.

5:55 PM Changeset in webkit [204619] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Windows build fix after r204611. Use the fully qualified name to avoid the ambiguity in VC++.

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::invokeCallback):

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):

5:50 PM Changeset in webkit [204618] by dino@apple.com
  • 7 edits
    2 adds in trunk

Support passing preferLowPowerToHighPerformance and failIfMajorPerformanceCaveat
​https://bugs.webkit.org/show_bug.cgi?id=160982
<rdar://problem/27915946>

Reviewed by Simon Fraser.

Source/WebCore:

Update WebGLContextAttributes to be compliant with the specification,
by adding preferLowPowerToHighPerformance and failIfMajorPerformanceCaveat.
They are not implemented yet, so asking the created context what
values it used should give the default.

Test: fast/canvas/webgl/context-creation-attributes.html

  • html/canvas/WebGLContextAttributes.cpp:

(WebCore::WebGLContextAttributes::preferLowPowerToHighPerformance):
(WebCore::WebGLContextAttributes::setPreferLowPowerToHighPerformance):
(WebCore::WebGLContextAttributes::failIfMajorPerformanceCaveat):
(WebCore::WebGLContextAttributes::setFailIfMajorPerformanceCaveat):

  • html/canvas/WebGLContextAttributes.h:
  • html/canvas/WebGLContextAttributes.idl:
  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create): Deleted.

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::Attributes::Attributes): Deleted.

LayoutTests:

Very simple test that creates some WebGL contexts with various
creation attributes and outputs the result.

  • fast/canvas/webgl/context-creation-attributes-expected.txt: Added.
  • fast/canvas/webgl/context-creation-attributes.html: Added.
5:12 PM Changeset in webkit [204617] by andersca@apple.com
  • 13 edits in trunk/Source

Move an NPAPI-only function from WebCore to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=160967

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createScriptObjectForPluginElement): Deleted.

  • bindings/js/ScriptController.h:
  • bridge/NP_jsobject.h:

Source/WebKit/mac:

  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:value:]):
(-[WebNetscapePluginView _destroyPlugin]):

Source/WebKit/win:

  • Plugins/PluginView.cpp:

(WebCore::PluginView::~PluginView):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::getValue):

  • Plugins/PluginView.h:
4:21 PM Changeset in webkit [204616] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.5

New tag.

4:15 PM Changeset in webkit [204615] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Building test fix after r204611.

  • bindings/scripts/test/TestObj.idl:
4:11 PM Changeset in webkit [204614] by mitz@apple.com
  • 5 edits
    3 adds in trunk

[Cocoa] API::Number needs to be wrapped by an NSNumber
​https://bugs.webkit.org/show_bug.cgi?id=160977
<rdar://problem/27877735>

Reviewed by Anders Carlsson.

Source/WebKit2:

We introduce a single WKNSNumber class to wrap three distinct API::Number instantiations
corresponding to the Boolean, UInt64 and Double types.

Test: TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Create a WKNSNumber to contain any of the number types, and set

its _type ivar accordingly.

  • Shared/Cocoa/WKNSNumber.h: Added.

(WebKit::wrapper):

  • Shared/Cocoa/WKNSNumber.mm: Added.

(-[WKNSNumber dealloc]): Call the appropriate destructor.
(-[WKNSNumber objCType]): Implement this NSValue primitive method.
(-[WKNSNumber getValue:]): Ditto.
(-[WKNSNumber boolValue]): Implement this NSNumber method corresponding to one of our

possible types.

(-[WKNSNumber doubleValue]): Ditto.
(-[WKNSNumber unsignedLongLongValue]): Ditto.
(-[WKNSNumber copyWithZone:]): Implement this NSCopying method by retaining self.
(-[WKNSNumber _apiObject]): Implement this WKObject method by returning the appropriate

API object.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.

(TestWebKitAPI::TEST):

4:03 PM Changeset in webkit [204613] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, nit fix after r204605 reported by Darin.

  • platform/text/TextCodecICU.cpp:
3:55 PM Changeset in webkit [204612] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

ScopedArguments is using the wrong owner object for a write barrier.
​https://bugs.webkit.org/show_bug.cgi?id=160976
<rdar://problem/27328506>

Reviewed by Keith Miller.

JSTests:

  • stress/scoped-arguments-write-barrier-should-be-on-scope-object.js: Added.

Source/JavaScriptCore:

  • runtime/ScopedArguments.h:

(JSC::ScopedArguments::setIndexQuickly):

3:19 PM Changeset in webkit [204611] by rniwa@webkit.org
  • 13 edits
    4 adds in trunk

Add basic support for connected and disconnected callbacks
​https://bugs.webkit.org/show_bug.cgi?id=160950

Reviewed by Chris Dumez.

Source/WebCore:

Added the basic support for custom elements' connectedCallback and disconnectedCallback. These callbacks
are enqueued by inserting and removing a node as spec'ed by ​https://dom.spec.whatwg.org/#concept-node-insert
and ​https://dom.spec.whatwg.org/#concept-node-remove

For now, we only support callbacks on appendChild and removeChild to limit the amount of code changes and
tests that need to be included in this patch.

This patch also renames InvokesCustomElementLifecycleCallbacks IDL attribute to CEReactions to match
the latest specification: ​https://html.spec.whatwg.org/multipage/scripting.html#cereactions

Tests: fast/custom-elements/connected-callbacks.html

fast/custom-elements/disconnected-callbacks.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::invokeCallback): Extracted from invokeAttributeChangedCallback.
(WebCore::JSCustomElementInterface::setConnectedCallback): Added.
(WebCore::JSCustomElementInterface::invokeConnectedCallback): Added.
(WebCore::JSCustomElementInterface::setDisconnectedCallback): Added.
(WebCore::JSCustomElementInterface::invokeDisconnectedCallback): Added.
(WebCore::JSCustomElementInterface::setAttributeChangedCallback):
(WebCore::JSCustomElementInterface::invokeAttributeChangedCallback): Renamed from attributeChanged.

  • bindings/js/JSCustomElementInterface.h: Added m_connectedCallback and m_disconnectedCallback as instance

variables. Also removed the superfluous mutable qualifier from m_constructor m_attributeChangedCallback.

  • bindings/js/JSCustomElementsRegistryCustom.cpp:

(WebCore::JSCustomElementsRegistry::define): Store connectedCallback and disconnectedCallback.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • dom/CustomElementsRegistry.idl:
  • dom/Element.cpp:

(WebCore::Element::insertedInto): Call enqueueConnectedCallbackIfNeeded.
(WebCore::Element::removedFrom): Call enqueueDisconnectedCallbackIfNeeded.

  • dom/Element.idl:
  • dom/LifecycleCallbackQueue.cpp:

(WebCore::LifecycleQueueItem::invoke): Added calls to invokeConnectedCallback and invokeDisconnectedCallback.
(WebCore::findInterfaceForCustomElement): Extracted from enqueueAttributeChangedCallbackIfNeeded.
(WebCore::LifecycleCallbackQueue::enqueueConnectedCallbackIfNeeded): Added.
(WebCore::LifecycleCallbackQueue::enqueueDisconnectedCallbackIfNeeded): Added.
(WebCore::LifecycleCallbackQueue::enqueueAttributeChangedCallbackIfNeeded):
(WebCore::CustomElementLifecycleProcessingStack::ensureCurrentQueue):

  • dom/LifecycleCallbackQueue.h:
  • dom/Node.idl:

LayoutTests:

Added W3C style testharness.js tests for connectedCallback and disconnectedCallback.

Four test cases are failing due to a bug in window-less document's custom element registry,
which will be addressed in a future patch.

  • fast/custom-elements/connected-callbacks-expected.txt: Added.
  • fast/custom-elements/connected-callbacks.html: Added.
  • fast/custom-elements/disconnected-callbacks-expected.txt: Added.
  • fast/custom-elements/disconnected-callbacks.html: Added.
2:19 PM Changeset in webkit [204610] by Beth Dakin
  • 4 edits in trunk/Source/WebCore

Update the accessibility titles for list insertion
​https://bugs.webkit.org/show_bug.cgi?id=160972
-and corresponding-
rdar://problem/27750446

Reviewed by Chris Fleizach.

Update accessibility titles based on feedback.

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:

(WebCore::insertListTypeNone):
(WebCore::insertListTypeBulleted):
(WebCore::insertListTypeBulletedAccessibilityTitle):
(WebCore::insertListTypeNumbered):
(WebCore::insertListTypeNumberedAccessibilityTitle):
(WebCore::insertListTypeNoneAccessibilityTitle): Deleted.

  • platform/LocalizedStrings.h:
2:11 PM Changeset in webkit [204609] by bshafiei@apple.com
  • 3 edits in branches/safari-602.1.50.0-branch/Source/JavaScriptCore

Merge r204572. rdar://problem/27889416

1:53 PM Changeset in webkit [204608] by bshafiei@apple.com
  • 5 edits in branches/safari-602-branch/Source

Versioning.

1:25 PM Changeset in webkit [204607] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add LLINT probe() macro for X86_64.
​https://bugs.webkit.org/show_bug.cgi?id=160968

Reviewed by Geoffrey Garen.

  • llint/LowLevelInterpreter.asm:
12:55 PM Changeset in webkit [204606] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning
​https://bugs.webkit.org/show_bug.cgi?id=160964

Reviewed by Anders Carlsson.

Followed the guidelines for SPI naming.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _isCookieStoragePartitioningEnabled]): Renamed from -cookieStoragePartitioningEnabled.
(-[WKProcessPool _setCookieStoragePartitioningEnabled:]): Renamed from -setCookieStoragePartitioningEnabled:.
(-[WKProcessPool cookieStoragePartitioningEnabled]): Renamed to -_isCookieStoragePartitioningEnabled.
(-[WKProcessPool setCookieStoragePartitioningEnabled:]): Renamed to -_setCookieStoragePartitioningEnabled:.

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
12:53 PM Changeset in webkit [204605] by Chris Dumez
  • 18 edits in trunk

Align our encoding labels with the encoding specification
​https://bugs.webkit.org/show_bug.cgi?id=160931

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C test now that we are passing a lot more checks. For reference,
Firefox 48 passes 624 out of 654, and Chrome 52 passes 651 out of 654.
Before this change, WebKit was only passing 501 out of 654 and is now passing

  1. The only checks we're failing is due to "Big5-HKSCS" not being an alias

to "Big5".

  • web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:

Source/WebCore:

Align our encoding labels with the encoding specification:

This also aligns with Firefox and Chrome.

No new tests, rebaselined existing test.

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::registerEncodingNames):

  • platform/text/TextCodecLatin1.cpp:

(WebCore::TextCodecLatin1::registerEncodingNames):
(WebCore::newStreamingTextDecoderWindowsLatin1): Deleted.
(WebCore::TextCodecLatin1::registerCodecs): Deleted.

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::registerEncodingNames):

LayoutTests:

Update / rebaseline existing tests to reflect the code change.
The new baselines match Chrome and Firefox.

  • fast/encoding/bracket-in-tag-expected.txt:
  • fast/encoding/charset-invalid-expected.txt:
  • fast/encoding/charset-replacement-expected.txt:
  • fast/encoding/misplaced-xml-declaration-expected.txt:
  • fast/encoding/pseudo-xml-expected.txt:
  • http/tests/misc/char-encoding-bocu-1-blacklisted-expected.txt:
  • http/tests/misc/char-encoding-bocu-1-blacklisted.html:
  • http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt:
  • http/tests/misc/char-encoding-scsu-blacklisted-expected.txt:
  • http/tests/misc/char-encoding-scsu-blacklisted.html:
  • http/tests/misc/frame-default-enc-different-domain-expected.txt:
12:04 PM Changeset in webkit [204604] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Generated messages headers should use #pragma once
​https://bugs.webkit.org/show_bug.cgi?id=160965

Reviewed by Anders Carlsson.

  • Scripts/webkit/messages.py:

(generate_messages_header): Used #pragma once instead of a header guard.

11:59 AM Changeset in webkit [204603] by aestes@apple.com
  • 15 edits in trunk/Source

[Cocoa] Add SPI to WKProcessPool for enabling cookie storage partitioning
​https://bugs.webkit.org/show_bug.cgi?id=160964

Reviewed by Brent Fulgham.

Source/WebCore:

  • page/Settings.cpp:

(WebCore::Settings::setCookieStoragePartitioningEnabled): Deleted.

  • page/Settings.h:

(WebCore::Settings::cookieStoragePartitioningEnabled): Deleted.

  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp: Defined cookieStoragePartitioningEnabled.

(WebCore::NetworkStorageSession::setCookieStoragePartitioningEnabled): Set cookieStoragePartitioningEnabled.
(WebCore::cookieStoragePartition): Used cookieStoragePartitioningEnabled instead of Settings::cookieStoragePartitioningEnabled().

Source/WebKit2:

  • NetworkProcess/NetworkProcess.h: Declared setCookieStoragePartitioningEnabled().
  • NetworkProcess/NetworkProcess.messages.in: Added message SetCookieStoragePartitioningEnabled.
  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode): Encoded cookieStoragePartitioningEnabled.
(WebKit::NetworkProcessCreationParameters::decode): Decoded cookieStoragePartitioningEnabled.

  • NetworkProcess/NetworkProcessCreationParameters.h: Declared cookieStoragePartitioningEnabled.
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
Called NetworkStorageSession::setCookieStoragePartitioningEnabled() given the cookieStoragePartitioningEnabled parameter.
(WebKit::NetworkProcess::setCookieStoragePartitioningEnabled):
Called NetworkStorageSession::setCookieStoragePartitioningEnabled().

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool cookieStoragePartitioningEnabled]): Returned WebProcessPool::cookieStoragePartitioningEnabled().
(-[WKProcessPool setCookieStoragePartitioningEnabled:]): Called WebProcessPool::setCookieStoragePartitioningEnabled().

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h: Declared cookieStoragePartitioningEnabled as a property.
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):
Set the cookieStoragePartitioningEnabled parameter from m_cookieStoragePartitioningEnabled.
(WebKit::WebProcessPool::setCookieStoragePartitioningEnabled):
Set m_cookieStoragePartitioningEnabled and sent the NetworkProcess::SetCookieStoragePartitioningEnabled message.

  • UIProcess/WebProcessPool.h: Declared cookieStoragePartitioningEnabled.
11:06 AM Changeset in webkit [204602] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Land test expectations for rdar://problem/27723718.

  • platform/mac-wk1/TestExpectations:
11:05 AM Changeset in webkit [204601] by eric.carlson@apple.com
  • 13 edits
    2 adds in trunk

AX: Audio Description tracks are not labeled correctly, causing user confusion
​https://bugs.webkit.org/show_bug.cgi?id=160652
<rdar://problem/27742208>

Reviewed by Antoine Quint.

  • http/tests/media/hls/hls-accessiblity-describes-video-menu-expected.txt: Added.
  • http/tests/media/hls/hls-accessiblity-describes-video-menu.html: Added.
  • media/trackmenu-test.js:

(clickCCButton): Fail immediately if "video" is null or not a media element. Make failure
logging more descriptive.

  • platform/gtk/TestExpectations: Skip new test.
  • platform/ios-simulator/media/video-controls-captions-trackmenu-expected.txt: Updated for

clickCCButton error message change.

  • platform/ios-simulator/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Ditto.
  • platform/ios-simulator/media/video-controls-captions-trackmenu-localized-expected.txt: Ditto.
  • platform/ios-simulator/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
10:54 AM Changeset in webkit [204600] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused SlotVisitor::append() variant.
​https://bugs.webkit.org/show_bug.cgi?id=160961

Reviewed by Saam Barati.

  • heap/SlotVisitor.h:
  • jit/JITWriteBarrier.h:

(JSC::JITWriteBarrier::get):
(JSC::SlotVisitor::append): Deleted.

10:26 AM Changeset in webkit [204599] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix WinCairo build after r204592.

  • PlatformAppleWin.cmake:
  • PlatformWin.cmake:
10:23 AM Changeset in webkit [204598] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

10:17 AM Changeset in webkit [204597] by sbarati@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Make @Array(size) a bytecode intrinsic
​https://bugs.webkit.org/show_bug.cgi?id=160867

Reviewed by Mark Lam.

There were a few places in the code where we were emitting @Array(size)
or new @Array(size). Since we have a bytecode operation that already
represents this, called new_array_with_size, it's faster to just make a
bytecode intrinsic for the this operation. This patch does that and
the intrinsic is called @newArrayWithSize. This might be around a
1% speedup on ES6 sample bench, but it's within the noise. This is just
a good bytecode operation to have because it's common enough to
create arrays and it's good to make that fast in all tiers.

  • builtins/ArrayConstructor.js:

(of):
(from):

  • builtins/ArrayPrototype.js:

(filter):
(map):
(sort.stringSort):
(sort):
(concatSlowPath):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_isObject):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_newArrayWithSize):

9:10 AM Changeset in webkit [204596] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r204594.

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:06 AM Changeset in webkit [204595] by eric.carlson@apple.com
  • 10 edits in trunk/Source/WebCore

[MediaStream] cleanup MediaConstraints
​https://bugs.webkit.org/show_bug.cgi?id=160957

Reviewed by Antoine Quint.

No new tests, no behavior change.

  • Modules/mediastream/CaptureDeviceManager.cpp:

(CaptureDeviceManager::sessionSupportsConstraint): Use MediaConstraint::type

  • bindings/js/JSMediaDevicesCustom.cpp:

(WebCore::initializeStringConstraintWithList): MediaConstraint::create now takes the constraint
type, not name.
(WebCore::createStringConstraint): Ditto.
(WebCore::createBooleanConstraint): Ditto.
(WebCore::createDoubleConstraint): Ditto.
(WebCore::createIntConstraint): Ditto.
(WebCore::parseMediaTrackConstraintSetForKey): Pass constraint type.

  • platform/mediastream/MediaConstraints.cpp:

(WebCore::MediaConstraint::create): MediaConstraint constructor now takes the constraint.
(WebCore::IntConstraint::create): Take type, not name.
(WebCore::IntConstraint::setMin): Ditto.
(WebCore::DoubleConstraint::create): Ditto.
(WebCore::BooleanConstraint::create): Ditto.
(WebCore::StringConstraint::create): Ditto.

  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Make static.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Ditto.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::sessionSupportsConstraint): Use MediaConstraint::type

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::applyConstraints): nameForConstraint is a static method. Add
error logging.

  • platform/mock/MediaConstraintsMock.cpp:

(WebCore::isSatisfiable): Use constraint type.

6:58 AM Changeset in webkit [204594] by commit-queue@webkit.org
  • 28 edits
    10 copies
    6 adds in trunk

[web-animations] Add Animatable, AnimationEffect, KeyframeEffect and Animation interface
​https://bugs.webkit.org/show_bug.cgi?id=156096

Patch by Rawinder Singh <​rawinder.singh-webkit@cisra.canon.com.au> on 2016-08-18
Reviewed by Dean Jackson.

Adds:
Source/JavaScriptCore:

  • Animatable interface and implementation of getAnimations in Element.
  • Interface and implementation for Document getAnimations method.
  • AnimationEffect interface and class stub.
  • KeyframeEffect interface and constructor implementation.
  • 'Animation' interface, constructor and query methods for effect and timeline.
  • Remove runtime condition on Web animation interfaces (compile time flag is specified).
  • runtime/CommonIdentifiers.h:

Source/WebCore:

  • Animatable interface and implementation of getAnimations in Element.
  • Interface and implementation for Document getAnimations method.
  • AnimationEffect interface and class stub.
  • KeyframeEffect interface and constructor implementation.
  • 'Animation' interface, constructor and query methods for effect and timeline.
  • Remove runtime condition on Web animation interfaces (compile time flag is specified).

Test: webanimations/Document.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformGTK.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/Animatable.idl: Copied from Source/WebCore/animation/AnimationTimeline.idl.
  • animation/AnimationEffect.cpp: Copied from Source/WebCore/animation/AnimationTimeline.cpp.

(WebCore::AnimationEffect::AnimationEffect):
(WebCore::AnimationEffect::~AnimationEffect):
(WebCore::AnimationEffect::setAnimation):
(WebCore::AnimationEffect::isCurrent):
(WebCore::AnimationEffect::isInEffect):

  • animation/AnimationEffect.h: Copied from Source/WebCore/animation/DocumentTimeline.cpp.
  • animation/AnimationEffect.idl: Copied from Source/WebCore/animation/DocumentAnimation.idl.
  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::destroy):
(WebCore::AnimationTimeline::attachAnimation):
(WebCore::AnimationTimeline::detachAnimation):

  • animation/AnimationTimeline.h:
  • animation/AnimationTimeline.idl:
  • animation/DocumentAnimation.cpp:

(WebCore::DocumentAnimation::timeline):
(WebCore::DocumentAnimation::getAnimations):
(WebCore::DocumentAnimation::addAnimation):
(WebCore::DocumentAnimation::removeAnimation):

  • animation/DocumentAnimation.h:

(WebCore::DocumentAnimation::getAnimations):

  • animation/DocumentAnimation.idl:
  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::create):
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::attach):
(WebCore::DocumentTimeline::detach):

  • animation/DocumentTimeline.h:
  • animation/DocumentTimeline.idl:
  • animation/KeyframeEffect.cpp: Copied from Source/WebCore/animation/DocumentTimeline.cpp.

(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
(WebCore::KeyframeEffect::~KeyframeEffect):

  • animation/KeyframeEffect.h: Copied from Source/WebCore/animation/DocumentTimeline.h.
  • animation/KeyframeEffect.idl: Copied from Source/WebCore/animation/DocumentTimeline.idl.
  • animation/WebAnimation.cpp: Copied from Source/WebCore/animation/DocumentAnimation.cpp.

(WebCore::WebAnimation::create):
(WebCore::WebAnimation::WebAnimation):
(WebCore::WebAnimation::~WebAnimation):

  • animation/WebAnimation.h: Copied from Source/WebCore/animation/DocumentAnimation.h.
  • animation/WebAnimation.idl: Copied from Source/WebCore/animation/DocumentTimeline.idl.
  • bindings/scripts/CodeGeneratorGObject.pm:
  • dom/Element.cpp:

(WebCore::Element::getAnimations):

  • dom/Element.h:
  • dom/Element.idl:

Source/WebKit/mac:

  • Setup interface for enabling runtime flag for Web animations through preferences.
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences webAnimationsEnabled]):
(-[WebPreferences setWebAnimationsEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

LayoutTests:

  • Animatable interface and implementation of getAnimations in Element.
  • Interface and implementation for Document getAnimations method.
  • AnimationEffect interface and class stub.
  • KeyframeEffect interface and constructor implementation.
  • 'Animation' interface, constructor and query methods for effect and timeline.
  • Remove runtime condition on Web animation interfaces (compile time flag is specified).
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • webanimations/Document-expected.txt: Added.
  • webanimations/Document.html: Added.
  • webanimations/script-tests/Document.js: Added.
2:23 AM Changeset in webkit [204593] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations on Windows for failing tests. These failures are tracked in
​https://bugs.webkit.org/show_bug.cgi?id=160447.

  • platform/win/TestExpectations:

Aug 17, 2016:

11:38 PM Changeset in webkit [204592] by mmaxfield@apple.com
  • 10 edits
    3 adds in trunk

[Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
​https://bugs.webkit.org/show_bug.cgi?id=160895

Reviewed by Dean Jackson.

Source/WebCore:

Migrate to CTLineDraw() instead.

This patch also adds support for linking to the existing CoreText framework on Windows.

No new tests because there is no behavior change.

  • PlatformWin.cmake:
  • page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::showText):

  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::drawTextAtPoint):

  • platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::drawLayer):

  • platform/spi/win/CoreTextSPIWin.cpp: Added.
  • platform/spi/win/CoreTextSPIWin.h: Added.

Source/WebKit:

Link to the existing CoreText framework.

  • PlatformWin.cmake:

Tools:

Link to the existing CoreText framework.

  • DumpRenderTree/PlatformWin.cmake:
  • TestWebKitAPI/PlatformWin.cmake:
11:22 PM Changeset in webkit [204591] by benjamin@webkit.org
  • 15 edits
    2 adds in trunk

[CSS] The parser should not get rid of empty namespace specification in front of element name selectors
​https://bugs.webkit.org/show_bug.cgi?id=160936

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:

Source/WebCore:

There are two places where you can specify an empty namespace
in selectors:

  • Element name (e.g. "|name")
  • Attribute name (e.g. "[|name]")

In the first case, if we have an empty namespace, the selector
should match that.
In the second case, the default namespace of attribute is already
empty so it is just the same as "[name]".

Our code was just discarding any empty namespace. This is fine
for attributes but for names that is transforming "|name" into "name"
which is invalid.

This patch updates those cases to differentiate:

  • Null prefix -> There was no namespace specified.
  • Empty prefix -> There was a namespace prefix and it is empty.

Test: fast/selectors/empty-namespace-with-element-selector.html

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::determineNameInNamespace):
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):

  • css/CSSParser.h:
  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelectorList.cpp:

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::determineNamespace): Deleted.

LayoutTests:

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/selectors/empty-namespace-with-element-selector-expected.txt: Added.
  • fast/selectors/empty-namespace-with-element-selector.html: Added.
10:37 PM Changeset in webkit [204590] by bshafiei@apple.com
  • 11 edits in branches/safari-602-branch/Source

Merge r204587. rdar://problem/27807479

8:07 PM Changeset in webkit [204589] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

[Web IDL] Add support for dictionary members of dictionary types
​https://bugs.webkit.org/show_bug.cgi?id=160902

Reviewed by Sam Weinig.

Add support for dictionary members of dictionary types.

No new tests, updated bindings tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionaryImplementationContent):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldNotTolerateNull>):

  • bindings/scripts/test/TestObj.idl:
6:35 PM Changeset in webkit [204588] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add WASM support for i64 simple opcodes.
​https://bugs.webkit.org/show_bug.cgi?id=160928

Reviewed by Michael Saboff.

This patch also removes the unsigned int32 mod operator, which is not supported by B3 yet.

  • wasm/WASMB3IRGenerator.cpp:

(JSC::WASM::toB3Op):
(JSC::WASM::B3IRGenerator::unaryOp):

  • wasm/WASMFunctionParser.h:

(JSC::WASM::WASMFunctionParser<Context>::parseExpression):

  • wasm/WASMOps.h:
5:46 PM Changeset in webkit [204587] by andersca@apple.com
  • 11 edits in trunk/Source

Add support for additional networks
​https://bugs.webkit.org/show_bug.cgi?id=160951
rdar://problem/27807479

Reviewed by Sam Weinig.

Source/WebCore:

  • Modules/applepay/ApplePaySession.cpp:

(WebCore::createSupportedNetworks):
(WebCore::createPaymentRequest):
(WebCore::ApplePaySession::create):

  • Modules/applepay/PaymentRequest.cpp:

(WebCore::isAdditionalValidSupportedNetwork):
(WebCore::PaymentRequest::isValidSupportedNetwork):

  • Modules/applepay/PaymentRequest.h:

(WebCore::PaymentRequest::supportedNetworks):
(WebCore::PaymentRequest::setSupportedNetworks):

  • Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validateSupportedNetworks):

  • Modules/applepay/PaymentRequestValidator.h:

Source/WebKit2:

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<PaymentRequest>::decode):
(IPC::ArgumentCoder<PaymentRequest::SupportedNetworks>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::SupportedNetworks>::decode): Deleted.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toAdditionalSupportedNetwork):
(WebKit::toSupportedNetwork):
(WebKit::toSupportedNetworks):

  • WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::supportsVersion):

4:57 PM Changeset in webkit [204586] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

We allow assignments to const variables when in a for-in/for-of loop
​https://bugs.webkit.org/show_bug.cgi?id=156673

Patch by JF Bastien <​jfbastien@apple.com> on 2016-08-17
Reviewed by Filip Pizlo.

JSTests:

  • stress/for-in-of-const.js: Added.

(expect_nothrow):
(expect_throw):
(capture):

Source/JavaScriptCore:

for-in and for-of weren't checking whether iteration variable from
parent scopes were const. Assigning to such variables should
throw, but used not to.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitLoopHeader):
(JSC::ForOfNode::emitBytecode):

4:54 PM Changeset in webkit [204585] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

4:48 PM Changeset in webkit [204584] by bshafiei@apple.com
  • 3 edits in branches/safari-602-branch/Source/WebKit/win

Merge r204575. rdar://problem/27850667

4:46 PM Changeset in webkit [204583] by bshafiei@apple.com
  • 3 edits in branches/safari-602-branch/Source/JavaScriptCore

Merge r204572. rdar://problem/27889416

4:44 PM Changeset in webkit [204582] by bshafiei@apple.com
  • 5 edits in branches/safari-602-branch/Source

Versioning.

4:29 PM Changeset in webkit [204581] by commit-queue@webkit.org
  • 5 edits in trunk

Use find_library within Windows build
​https://bugs.webkit.org/show_bug.cgi?id=160904

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2016-08-17
Reviewed by Brent Fulgham.

.:

  • Source/cmake/FindICU.cmake:
  • Source/cmake/OptionsWin.cmake:

Source/WTF:

  • wtf/CMakeLists.txt:
4:08 PM Changeset in webkit [204580] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Remove old libraries from build inputs
​https://bugs.webkit.org/show_bug.cgi?id=160949

Reviewed by Dean Jackson.

Modify the download script to remove the old 'icuuc.lib' and
'icuin.lib' files for Windows builds.

  • Scripts/update-webkit-auxiliary-libs:
4:02 PM Changeset in webkit [204579] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab should not layout if not visible
​https://bugs.webkit.org/show_bug.cgi?id=160920
<rdar://problem/27876629>

Reviewed by Timothy Hatcher.

Avoid updating the current time when the Network tab is hidden.
The timer, and any debounced timer cancellations, need to be stopped
as soon as the view is hidden.

  • UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView.prototype.hidden):
(WebInspector.NetworkGridContentView.prototype._networkTimelineRecordAdded):
(WebInspector.NetworkGridContentView.prototype._stopUpdatingCurrentTime):
(WebInspector.NetworkGridContentView):

3:24 PM Changeset in webkit [204578] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.1.3

New tag.

3:18 PM Changeset in webkit [204577] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Extra logging for crash reason
​https://bugs.webkit.org/show_bug.cgi?id=160943

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-17
Reviewed by Alexey Proskuryakov.

A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
(ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
(ServerProcess.has_crashed): Ditto.

3:04 PM Changeset in webkit [204576] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.4

New tag.

3:02 PM Changeset in webkit [204575] by bshafiei@apple.com
  • 3 edits in branches/safari-602.1.50.0-branch/Source/WebKit/win

Merge patch for rdar://problem/27850667.

2:31 PM Changeset in webkit [204574] by bshafiei@apple.com
  • 3 edits in branches/safari-602.1.50.1-branch/Source/JavaScriptCore

Merge r204572. rdar://problem/27889416

2:24 PM Changeset in webkit [204573] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

2:22 PM Changeset in webkit [204572] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fixed a potential bug in MarkedArgumentBuffer.
​https://bugs.webkit.org/show_bug.cgi?id=160948
<rdar://problem/27889416>

Reviewed by Oliver Hunt.

I haven't been able to produce an observable test case after some trying.

  • runtime/ArgList.cpp:

(JSC::MarkedArgumentBuffer::addMarkSet): New helper function -- I broke
this out from existing code for clarity, but the behavior is the same.

(JSC::MarkedArgumentBuffer::expandCapacity): Ditto.

(JSC::MarkedArgumentBuffer::slowAppend): Always addMarkSet() on the slow
path. This is faster than the old linear scan, and I think it might
avoid cases the old scan could miss.

  • runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::append): Account for the case where someone
has called clear() or removeLast().

(JSC::MarkedArgumentBuffer::mallocBase): No behavior change -- but it's
clearer to test the buffers directly instead of inferring what they
might be based on capacity.

2:20 PM Changeset in webkit [204571] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Select elements in DOM hierarchy are misaligned
​https://bugs.webkit.org/show_bug.cgi?id=160885

Patch by Devin Rousso <Devin Rousso> on 2016-08-17
Reviewed by Timothy Hatcher.

  • UserInterface/Views/HierarchicalPathComponent.css:

(.hierarchical-path-component > select):

2:00 PM Changeset in webkit [204570] by mark.lam@apple.com
  • 4 edits
    1 add in trunk

Remove an invalid assertion in the DFG backend's GetById emitter.
​https://bugs.webkit.org/show_bug.cgi?id=160925
<rdar://problem/27248961>

Reviewed by Filip Pizlo.

JSTests:

  • stress/dfg-get-by-id-should-not-assert-non-null-prediction.js: Added.

Source/JavaScriptCore:

The DFG backend's GetById assertion that the node's prediction not be SpecNone
is just plain wrong. It assumes that we can never have a GetById node without a
type prediction, but this is not true. The following test case proves otherwise:

function foo() {

"use strict";
return --argumentscallee;

}

Will remove the assertion. Nothing else needs to change as the DFG is working
correctly without the assertion.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

1:41 PM Changeset in webkit [204569] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.1-branch/Source

Versioning.

1:22 PM Changeset in webkit [204568] by andersca@apple.com
  • 7 edits in trunk/Source

Remove a couple of unused WKSI function pointers
​https://bugs.webkit.org/show_bug.cgi?id=160946

Reviewed by Dan Bernstein.

Source/WebCore:

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

12:58 PM Changeset in webkit [204567] by andersca@apple.com
  • 5 edits in trunk/Source

Move WKSignedPublicKeyAndChallengeString into WebCore and make it proper C++
​https://bugs.webkit.org/show_bug.cgi?id=160945

Reviewed by Dan Bernstein.

Source/WebCore:

  • platform/mac/SSLKeyGeneratorMac.mm:

(WebCore::getSubjectPublicKey):
(WebCore::signPublicKeyAndChallenge):
(WebCore::signedPublicKeyAndChallengeString):

Source/WTF:

  • wtf/RetainPtr.h:

(WTF::RetainPtr::operator&):
Cast this to the right type.

  • wtf/spi/cocoa/SecuritySPI.h:

Add new SPI.

12:56 PM Changeset in webkit [204566] by Antti Koivisto
  • 24 edits in trunk/Source

Remove CSS_IMAGE_SET feature define
​https://bugs.webkit.org/show_bug.cgi?id=160944

Reviewed by Dean Jackson.

Source/WebCore:

This seems to be enabled everywhere already (except Mac cmake build which it keep breaking).

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::CSSCursorImageValue):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cloneForCSSOM):

  • css/CSSImageSetValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseVariableDependentValue):
(WebCore::isImageSetFunctionValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::parseImageSet):

  • css/CSSParser.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapNinePieceImage):

  • css/CSSValue.cpp:

(WebCore::CSSValue::traverseSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

  • css/CSSValue.h:

(WebCore::CSSValue::isImageGeneratorValue):
(WebCore::CSSValue::isGradientValue):
(WebCore::CSSValue::isNamedImageValue):
(WebCore::CSSValue::isImageSetValue):
(WebCore::CSSValue::isImageValue):
(WebCore::CSSValue::isInheritedValue):

  • css/StyleBuilderConverter.h:

(WebCore::isImageShape):

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueContent):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):

  • css/StyleResolver.h:

(WebCore::StyleResolver::applyPropertyToRegularStyle):

  • css/makeprop.pl:

(generateFillLayerPropertyValueSetter):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::cssValue):

  • rendering/style/StylePendingImage.h:
  • style/StylePendingResources.cpp:

(WebCore::Style::loadPendingImage):

Source/WTF:

  • wtf/FeatureDefines.h:
12:19 PM Changeset in webkit [204565] by mitz@apple.com
  • 6 edits
    2 adds in trunk

[Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
​https://bugs.webkit.org/show_bug.cgi?id=160938
<rdar://problem/27876652>

Reviewed by Anders Carlsson.

Source/WebKit2:

-[NSString isEqualToString:] calls an internal NSObject method on its argument, which
NSString subclasses override to return YES, but WKObject does not override and does not
forward to its target NSString.

To fix this issue and other similar issues, we make WKObject a root class instead of an
NSObject subclass.

Test: TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm

  • Platform/spi/Cocoa/objcSPI.h: Added.
  • Shared/Cocoa/WKObject.h: Make WKObject a root class instead of inhereting from NSObject.
  • Shared/Cocoa/WKObject.mm:

(+[WKObject class]): Return self.
(-[WKObject allowsWeakReference]): Added. Called by the Objective-C runtime.
(-[WKObject retainWeakReference]): Ditto.
(-[WKObject hash]): If we don’t have a target, return our address.
(-[WKObject superclass]): Implement this NSObject protocol method.
(-[WKObject class]): Ditto.
(-[WKObject self]): Ditto.
(-[WKObject performSelector:]): Ditto.
(-[WKObject performSelector:withObject:]): Ditto.
(-[WKObject performSelector:withObject:withObject:]): Ditto.
(-[WKObject isProxy]): Ditto.
(-[WKObject respondsToSelector:]): Changed to not call super.
(-[WKObject conformsToProtocol:]): Ditto.
(-[WKObject description]): Ditto.
(-[WKObject retain]): Implement this NSObject protocol method.
(-[WKObject release]): Ditto.
(-[WKObject autorelease]): Ditto.
(-[WKObject retainCount]): Ditto.
(-[WKObject zone]): Ditto.
(-[WKObject dealloc]): Deleted.
(-[WKObject classForCoder]): Deleted.
(-[WKObject classForKeyedArchiver]): Deleted.
(-[WKObject _cfTypeID]): Deleted.

  • WebKit2.xcodeproj/project.pbxproj: Added reference to new file.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.

(TestWebKitAPI::TEST):

11:15 AM Changeset in webkit [204564] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix CMake build.

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::cssValue):

11:01 AM Changeset in webkit [204563] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: Support abbreviations in iOS
​https://bugs.webkit.org/show_bug.cgi?id=160907

Reviewed by Joanmarie Diggs.

Source/WebCore:

Expose the expandedTextValue attribute for iOS, so that VoiceOver can speak abbreviations correctly.

Test: accessibility/ios-simulator/abbreviation.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper textMarkersForRange:]):
(-[WebAccessibilityObjectWrapper accessibilityExpandedTextValue]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetSpelling):
(AXAttributeStringSetExpandedTextValue):
(AXAttributedStringAppendText):
(AXAttributeStringSetexpandedTextValue): Deleted.

Tools:

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::stringAttributeValue):

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::stringAttributeValue):

LayoutTests:

  • accessibility/ios-simulator/abbreviation-expected.txt: Added.
  • accessibility/ios-simulator/abbreviation.html: Added.
10:48 AM Changeset in webkit [204562] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: rapid updates to status icons in Visual Styles sidebar causes flicker
​https://bugs.webkit.org/show_bug.cgi?id=160887

Patch by Devin Rousso <Devin Rousso> on 2016-08-17
Reviewed by Timothy Hatcher.

  • UserInterface/Views/VisualStyleBasicInput.js:

(WebInspector.VisualStyleBasicInput):

  • UserInterface/Views/VisualStyleColorPicker.js:

(WebInspector.VisualStyleColorPicker):

  • UserInterface/Views/VisualStyleNumberInputBox.js:

(WebInspector.VisualStyleNumberInputBox):
(WebInspector.VisualStyleNumberInputBox.prototype._valueNumberInputKeyDown):

  • UserInterface/Views/VisualStylePropertyNameInput.js:

(WebInspector.VisualStylePropertyNameInput):

10:12 AM Changeset in webkit [204561] by mitz@apple.com
  • 8 copies
    1 add in releases/Apple/Safari Technology Preview 11

Added a tag for Safari Technology Preview release 11.

9:37 AM Changeset in webkit [204560] by Antti Koivisto
  • 14 edits
    2 deletes in trunk/Source/WebCore

Remove StyleCachedImageSet
​https://bugs.webkit.org/show_bug.cgi?id=160941

Reviewed by Simon Fraser.

It is almost the same as StyleCachedImage. Just use that.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::cachedImage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::detachPendingImage):
(WebCore::CSSImageSetValue::~CSSImageSetValue):
(WebCore::CSSImageSetValue::fillImageSet):
(WebCore::CSSImageSetValue::bestImageForScaleFactor):
(WebCore::CSSImageSetValue::bestFitImage):
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):
(WebCore::CSSImageSetValue::customCSSText):
(WebCore::CSSImageSetValue::traverseSubresources):
(WebCore::CSSImageSetValue::cachedImageSet): Deleted.

  • css/CSSImageSetValue.h:

(WebCore::CSSImageSetValue::create):
(WebCore::CSSImageSetValue::compareByScaleFactor):

  • css/StyleResolver.cpp:
  • page/EventHandler.cpp:
  • rendering/style/ShapeValue.cpp:

(WebCore::ShapeValue::isImageValid):

  • rendering/style/StyleAllInOne.cpp:
  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::StyleCachedImage):

Add scale factor and CSSImageSetValue backpointer, the only additional features of StyleCachedImageSet.

(WebCore::StyleCachedImage::cssValue):
(WebCore::StyleCachedImage::imageSize):
(WebCore::StyleCachedImage::imageHasRelativeWidth):

  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleCachedImageSet.cpp: Removed.
  • rendering/style/StyleCachedImageSet.h: Removed.
  • rendering/style/StyleImage.h:

(WebCore::StyleImage::isCachedImage):
(WebCore::StyleImage::isPendingImage):
(WebCore::StyleImage::isGeneratedImage):
(WebCore::StyleImage::StyleImage):
(WebCore::StyleImage::isCachedImageSet): Deleted.

  • style/StylePendingResources.cpp:

(WebCore::Style::loadPendingImage):

7:59 AM Changeset in webkit [204559] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Bump efl version from 1.17 to 1.18
​https://bugs.webkit.org/show_bug.cgi?id=160899

Patch by Gyuyoung Kim <​gyuyoung.kim@navercorp.com> on 2016-08-17
Reviewed by Antonio Gomes.

.:

  • Source/cmake/OptionsEfl.cmake: Update ewebkit version to 1.18.0.

Tools:

To use efl-1.18, EFL port needs to update install dependencies as well.

  • efl/install-dependencies:
  • efl/jhbuild.modules:
7:39 AM Changeset in webkit [204558] by pvollan@apple.com
  • 4 edits
    1 add in trunk

[Win] Add tests for linked fonts.
​https://bugs.webkit.org/show_bug.cgi?id=160898

Reviewed by Brent Fulgham.

Add tests for ​https://trac.webkit.org/changeset/204502.

Source/WebCore:

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::appendLinkedFonts):
(WebCore::getLinkedFonts):

Tools:

  • TestWebKitAPI/PlatformWin.cmake:
  • TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.

(TestWebKitAPI::TEST):

4:12 AM Changeset in webkit [204557] by Hunseop Jeong
  • 2 edits in trunk/Source/WebKit2

[EFL] Fix test_ewk2_view after r203612
​https://bugs.webkit.org/show_bug.cgi?id=160937

Reviewed by Gyuyoung Kim.

Default parameter values for window.alert() / prompt() / confirm() was
changed from "undefined" to the empty string after r203612.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

4:07 AM Changeset in webkit [204556] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebCore

Unreviewed. Fix GObject DOM bindings API break after r204449, r204450 and r204451.

Attributes designMode, embeds, plugins, scripts and compatMode have been moved from HTMLDocument to Document.

  • bindings/gobject/WebKitDOMDeprecated.cpp:

(webkit_dom_html_document_get_design_mode):
(webkit_dom_html_document_set_design_mode):
(webkit_dom_html_document_get_compat_mode):
(webkit_dom_html_document_get_embeds):
(webkit_dom_html_document_get_plugins):
(webkit_dom_html_document_get_scripts):

  • bindings/gobject/WebKitDOMDeprecated.h:
  • bindings/gobject/WebKitDOMDeprecated.symbols:
  • bindings/gobject/webkitdom.symbols:
1:50 AM Changeset in webkit [204555] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebCore

Unreviewed. Fix GObject DOM bindings API break after r204312.

HTMLInputElement capture attribute now returns the actual capture value, instead of whether it's present or
not. This patch renames webkit_dom_html_input_element_get_capture as
webkit_dom_html_input_element_get_capture_type and deprecates webkit_dom_html_input_element_get_capture.

  • bindings/gobject/WebKitDOMDeprecated.cpp:

(webkit_dom_html_input_element_get_capture):

  • bindings/gobject/WebKitDOMDeprecated.h:
  • bindings/gobject/WebKitDOMDeprecated.symbols:
  • bindings/gobject/webkitdom.symbols:
  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GetEffectiveFunctionName):

Aug 16, 2016:

10:48 PM Changeset in webkit [204554] by Simon Fraser
  • 3 edits
    2 adds in trunk

[iOS WK2] Don't throw touchMove events on the floor
​https://bugs.webkit.org/show_bug.cgi?id=160935

Reviewed by Tim Horton.

Source/WebKit2:

EventDispatcher claimed to coalesce touchMove events, but actually threw away any
touchMove if there was one in the queue when the next non-move event came along.

Fix to strictly coalesce touchMove events, so a start/move/end stream always fires
a move event. This is necessary for move-based interaction to work in testing,
for example the added range slider test.

Test: fast/forms/ios/drag-range-thumb.html

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::touchEvent):

LayoutTests:

Test for range slider interaction with synthesized touch events.

  • fast/forms/ios/drag-range-thumb-expected.txt: Added.
  • fast/forms/ios/drag-range-thumb.html: Added.
9:42 PM Changeset in webkit [204553] by rniwa@webkit.org
  • 11 edits
    2 moves in trunk

customElements.define should retrieve lifecycle callbacks
​https://bugs.webkit.org/show_bug.cgi?id=160797

Reviewed by Chris Dumez.

Source/WebCore:

Updated JSCustomElementInterface to invoke Get(constructor, "prototype") and Get(prototype, callbackName)
for each lifecycle callback as required by the latest specification:
​https://html.spec.whatwg.org/#dom-customelementsregistry-define

Also added the support for "observedAttributes" property on the custom elements constructor which defines
the list of attributes for which attributeChangedCallback is invoked.

Test: fast/custom-elements/CustomElementsRegistry.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::setAttributeChangedCallback): Added.
(WebCore::JSCustomElementInterface::attributeChanged): Invoke m_attributeChangedCallback instead of on the
result of Get(element, "attributeChangedCallback").

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::observesAttribute): Added.

  • bindings/js/JSCustomElementsRegistryCustom.cpp:

(WebCore::getLifecycleCallback): Added.
(WebCore::JSCustomElementsRegistry::define): Invoke Get(prototype, callbackName) for each callback. Also
store attributedChangedCallback and observedAttributes to JSCustomElementInterface. Other callbacks will
be stored in the future when the support for those callbacks are added.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged): Moved more code into enqueueAttributeChangedCallbackIfNeeded.

  • dom/LifecycleCallbackQueue.cpp:

(WebCore::LifecycleCallbackQueue::enqueueAttributeChangedCallbackIfNeeded): Added an early exit for when
the given attribute is not observed by the custom element. Also moved the logic to retrieve
JSCustomElementInterface from Element::attributeChanged and renamed it from enqueueAttributeChangedCallback.

  • bindings/js/JSDOMBinding.h:

(WebCore::toNativeArray): Throw a TypeError when the argument is not an object.

  • bindings/js/JSDOMConvert.h:

(WebCore::Converter<Vector<T>>::convert): Removed a FIXME comment.

LayoutTests:

Added test cases for CustomElementsRegistry.define to make sure it invokes Get(constructor, "prototype")
and Get(prototype, callbackName) for each lifecycle callback.

Also updated the tests to reflect the support for observedAttributes which specifies the list of attributes
for which attributeChangedCallback is invoked.

  • fast/custom-elements/CustomElementsRegistry-expected.txt: Renamed from Document-defineElement-expected.txt.
  • fast/custom-elements/CustomElementsRegistry.html: Renamed from Document-defineElement.html.
  • fast/custom-elements/Document-defineElement-expected.txt: Removed.
  • fast/custom-elements/Document-defineElement.html: Removed.
  • fast/custom-elements/attribute-changed-callback-expected.txt:
  • fast/custom-elements/attribute-changed-callback.html: Added test cases for "observedAttributes".
  • fast/custom-elements/lifecycle-callback-timing.html:
8:18 PM Changeset in webkit [204552] by Alan Bujtas
  • 6 edits
    8 adds in trunk

Subpixel rendering: Cleanup RenderLayerBacking::updateGeometry.
​https://bugs.webkit.org/show_bug.cgi?id=156860
<rdar://problem/25432352>

Reviewed by Simon Fraser.

Source/WebCore:

This patch cleans up the subpixel adjustment computation for the graphics layers
in RenderLayerBacking::updateGeometry.
It also fixes subpixel jiggling with clipping layers (both ancestor and child containment layers).

Tests: compositing/hidpi-ancestor-subpixel-clipping.html

compositing/hidpi-sibling-composited-content-offset.html
compositing/hidpi-subpixel-transform-origin.html
fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::paintChildClippingMaskForFragments):
(WebCore::RenderLayer::paintOverflowControlsForFragments):
(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::subpixelOffsetFromRendererChanged):
(WebCore::subpixelForLayerPainting):
(WebCore::computeOffsetFromRenderer):
(WebCore::snappedGraphicsLayerRect):
(WebCore::computeOffsetFromAncestorGraphicsLayer):
(WebCore::ComputedOffsets::ComputedOffsets): This is a helper class to hold offset values.
(WebCore::ComputedOffsets::fromAncestorGraphicsLayer):
(WebCore::ComputedOffsets::fromParentGraphicsLayer):
(WebCore::ComputedOffsets::fromPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::computePrimaryGraphicsLayerRect):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):
(WebCore::RenderLayerBacking::contentOffsetInCompostingLayer):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::devicePixelFractionGapFromRendererChanged): Deleted.
(WebCore::pixelFractionForLayerPainting): Deleted.
(WebCore::calculateDevicePixelOffsetFromRenderer): Deleted.
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Deleted.

  • rendering/RenderLayerBacking.h:

LayoutTests:

  • compositing/hidpi-ancestor-subpixel-clipping-expected.html: Added.
  • compositing/hidpi-ancestor-subpixel-clipping.html: Added.
  • compositing/hidpi-sibling-composited-content-offset-expected.html: Added.
  • compositing/hidpi-sibling-composited-content-offset.html: Added.
  • compositing/hidpi-subpixel-transform-origin-expected.html: Added.
  • compositing/hidpi-subpixel-transform-origin.html: Added.
  • fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt: Added.
  • fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html: Added.
8:17 PM Changeset in webkit [204551] by commit-queue@webkit.org
  • 12 edits
    2 adds
    2 deletes in trunk

Unreviewed, rolling out r204540, r204545, and r204547.
​https://bugs.webkit.org/show_bug.cgi?id=160932

Broke Windows builds (Requested by rniwa on #webkit).

Reverted changesets:

"customElements.define should retrieve lifecycle callbacks"
​https://bugs.webkit.org/show_bug.cgi?id=160797
​http://trac.webkit.org/changeset/204540

"Windows build fix attempt after r204540."
​http://trac.webkit.org/changeset/204545

"Another Windows build fix attempt. The error message doesn't
make any sense to me."
​http://trac.webkit.org/changeset/204547

7:42 PM Changeset in webkit [204550] by Hunseop Jeong
  • 2 edits in trunk/Source/WebCore

Unreviewed, CMake build fix after r204532

  • PlatformMac.cmake:
7:30 PM Changeset in webkit [204549] by dbates@webkit.org
  • 3 edits in trunk/Tools

prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
​https://bugs.webkit.org/show_bug.cgi?id=160924

Reviewed by Stephanie Lewis.

Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
test the generate function list machinery without requiring a SCM checkout by substituting a delegate
object that mocks out the file system and SCM operations.

  • Scripts/VCSUtils.pm:

(parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.

  • Scripts/prepare-ChangeLog:

(generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
abstracting the logic to query the file system and SCM into functions on a delegate object that
we pass to it.
(actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
(diffHeaderFormat): Deleted.

7:29 PM Changeset in webkit [204548] by Hunseop Jeong
  • 4 edits in trunk/Source

Unreviewed, CMake build fix

  • PlatformMac.cmake:
7:23 PM Changeset in webkit [204547] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Another Windows build fix attempt. The error message doesn't make any sense to me.

  • bindings/js/JSCustomElementsRegistryCustom.cpp:

(WebCore::JSCustomElementsRegistry::define):

7:01 PM Changeset in webkit [204546] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

[JSC] Update the documentation of B3's Return opcode
​https://bugs.webkit.org/show_bug.cgi?id=160912

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-08-16
Reviewed by Filip Pizlo.

  • docs/b3/intermediate-representation.html:
6:55 PM Changeset in webkit [204545] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt after r204540.

  • bindings/js/JSBindingsAllInOne.cpp:
5:41 PM Changeset in webkit [204544] by achristensen@apple.com
  • 6 edits in trunk

URLParser should parse URLs without credentials
​https://bugs.webkit.org/show_bug.cgi?id=160913

Reviewed by Brady Eidson.

Source/WebCore:

When parsing a URL, after the scheme we do not know if we are parsing a username and password
or if we are parsing the host until we hit a '@' indicating the end of the credentials or a /, ?, or #
indicating the end of the host. Because there are significantly different rules for serializing usernames,
passwords, and hosts (all of which have yet to be implemented in URLParser) we put the code points after the
scheme in a special buffer that will be processed once we know what we are parsing.

In the future, this could be optimized by assuming that we are parsing the host and if we encounter a '@' character,
then do some extra work. This would save us the effort of copying the host twice because most URLs don't have credentials.

This is covered by a new URLParser API test.

  • platform/Logging.h:
  • platform/URLParser.cpp:

(WebCore::isC0Control):
(WebCore::isC0ControlOrSpace):
(WebCore::isTabOrNewline):
(WebCore::isSpecialScheme):
(WebCore::URLParser::parse):
(WebCore::URLParser::authorityEndReached):
(WebCore::URLParser::hostEndReached):
(WebCore::URLParser::allValuesEqual):
(WebCore::isASCIIDigit): Deleted.
(WebCore::isASCIIAlpha): Deleted.
(WebCore::isASCIIAlphanumeric): Deleted.

  • platform/URLParser.h:

(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::s):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):

5:25 PM Changeset in webkit [204543] by Chris Dumez
  • 19 edits
    2 adds in trunk

Add support for ShadowRoot.mode attribute
​https://bugs.webkit.org/show_bug.cgi?id=160919

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

  • web-platform-tests/dom/interfaces-expected.txt:

Source/WebCore:

Add support for ShadowRoot.mode attribute:

Test: fast/shadow-dom/ShadowRoot-mode.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRules):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):

  • dom/Element.cpp:

(WebCore::Element::bindingsOffsetParent):
(WebCore::Element::addShadowRoot):
(WebCore::Element::attachShadow):
(WebCore::Element::shadowRootForBindings):
(WebCore::Element::userAgentShadowRoot):
(WebCore::Element::ensureUserAgentShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::isUnclosedNode):
(WebCore::Node::assignedSlotForBindings):
(WebCore::Node::isInUserAgentShadowTree):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::styleResolver):

  • dom/ShadowRoot.h:
  • dom/ShadowRoot.idl:
  • dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::didChangeSlot):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::create):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::shadowRootType):
(WebCore::InspectorDOMAgent::buildObjectForNode):

  • rendering/HitTestResult.cpp:

(WebCore::moveOutOfUserAgentShadowTree):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::selectionPseudoStyle):

  • rendering/RenderLayer.cpp:

(WebCore::rendererForScrollbar):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::correspondingUseElement):

  • testing/Internals.cpp:

(WebCore::Internals::shadowRootType):

LayoutTests:

Add layout test coverage.

  • fast/shadow-dom/ShadowRoot-mode-expected.txt: Added.
  • fast/shadow-dom/ShadowRoot-mode.html: Added.
5:18 PM Changeset in webkit [204542] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Heap::collectAllGarbage() should work with JSC_useImmortalObjects=true.
​https://bugs.webkit.org/show_bug.cgi?id=160917

Reviewed by Filip Pizlo.

If we do an synchronous GC when JSC_useImmortalObjects=true, we'll get a
RELEASE_ASSERT failure:

$ JSC_useImmortalObjects=true jsc

gc()

Trace/BPT trap: 5

This is because Heap::collectAllGarbage() is doing an explicit sweep of the
MarkedSpace, and the sweeper is expecting to see no RetiredBlocks. However, we
make objects immortal by retiring their blocks. As a result, there is a mismatch
in expectancy.

The fix is simply to not run the sweeper when JSC_useImmortalObjects=true.

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):

4:59 PM Changeset in webkit [204541] by keith_miller@apple.com
  • 2 edits in trunk/Source/WTF

Enable WebAssembly in the build.
​https://bugs.webkit.org/show_bug.cgi?id=160916

Reviewed by Benjamin Poulain.

This patch turns on WebAssembly on all the platforms that support B3.
Turning on WebAssembly by default lets us check the build on every
platform.

  • wtf/FeatureDefines.h:
4:55 PM Changeset in webkit [204540] by rniwa@webkit.org
  • 11 edits
    2 moves in trunk

customElements.define should retrieve lifecycle callbacks
​https://bugs.webkit.org/show_bug.cgi?id=160797

Reviewed by Chris Dumez.

Source/WebCore:

Updated JSCustomElementInterface to invoke Get(constructor, "prototype") and Get(prototype, callbackName)
for each lifecycle callback as required by the latest specification:
​https://html.spec.whatwg.org/#dom-customelementsregistry-define

Also added the support for "observedAttributes" property on the custom elements constructor which defines
the list of attributes for which attributeChangedCallback is invoked.

Test: fast/custom-elements/CustomElementsRegistry.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::setAttributeChangedCallback): Added.
(WebCore::JSCustomElementInterface::attributeChanged): Invoke m_attributeChangedCallback instead of on the
result of Get(element, "attributeChangedCallback").

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::observesAttribute): Added.

  • bindings/js/JSCustomElementsRegistryCustom.cpp:

(WebCore::getLifecycleCallback): Added.
(WebCore::JSCustomElementsRegistry::define): Invoke Get(prototype, callbackName) for each callback. Also
store attributedChangedCallback and observedAttributes to JSCustomElementInterface. Other callbacks will
be stored in the future when the support for those callbacks are added.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged): Moved more code into enqueueAttributeChangedCallbackIfNeeded.

  • dom/LifecycleCallbackQueue.cpp:

(WebCore::LifecycleCallbackQueue::enqueueAttributeChangedCallbackIfNeeded): Added an early exit for when
the given attribute is not observed by the custom element. Also moved the logic to retrieve
JSCustomElementInterface from Element::attributeChanged and renamed it from enqueueAttributeChangedCallback.

  • bindings/js/JSDOMBinding.h:

(WebCore::toNativeArray): Throw a TypeError when the argument is not an object.

  • bindings/js/JSDOMConvert.h:

(WebCore::Converter<Vector<T>>::convert): Removed a FIXME comment.

LayoutTests:

Added test cases for CustomElementsRegistry.define to make sure it invokes Get(constructor, "prototype")
and Get(prototype, callbackName) for each lifecycle callback.

Also updated the tests to reflect the support for observedAttributes which specifies the list of attributes
for which attributeChangedCallback is invoked.

  • fast/custom-elements/CustomElementsRegistry-expected.txt: Renamed from Document-defineElement-expected.txt.
  • fast/custom-elements/CustomElementsRegistry.html: Renamed from Document-defineElement.html.
  • fast/custom-elements/Document-defineElement-expected.txt: Removed.
  • fast/custom-elements/Document-defineElement.html: Removed.
  • fast/custom-elements/attribute-changed-callback-expected.txt:
  • fast/custom-elements/attribute-changed-callback.html: Added test cases for "observedAttributes".
  • fast/custom-elements/lifecycle-callback-timing.html:
4:31 PM Changeset in webkit [204539] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add WASM I32 simple operators.
​https://bugs.webkit.org/show_bug.cgi?id=160914

Reviewed by Benjamin Poulain.

This patch adds support for the i32 simple binary operators.

  • wasm/WASMB3IRGenerator.cpp:

(JSC::WASM::toB3Op):
(JSC::WASM::B3IRGenerator::binaryOp):

  • wasm/WASMFunctionParser.h:

(JSC::WASM::WASMFunctionParser<Context>::parseExpression):

  • wasm/WASMOps.h:
4:05 PM Changeset in webkit [204538] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Fix a thinko.

  • wtf/Scope.h:
4:00 PM Changeset in webkit [204537] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • Configurations/WebCore.xcconfig:
3:56 PM Changeset in webkit [204536] by Chris Dumez
  • 7 edits
    9 deletes in trunk

Align isDefaultNamespace() / lookupPrefix() / lookupNamespaceURI() with the specification
​https://bugs.webkit.org/show_bug.cgi?id=160911

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/dom/nodes/Node-lookupNamespaceURI-expected.txt:

Source/WebCore:

Align isDefaultNamespace() / lookupPrefix() / lookupNamespaceURI() with the specification:

Our implementation now matches closely the text of the DOM specification
and we pass more W3C tests as it fixes the following bug:

  • isDefaultNamespace(null) / isDefaultNamespace() was not returning true for in cases where the node's default namespace was null. Our implementation was returning false instead of comparing the node's default namespace (in this case null) with the input namespace (in this case null).

No new tests, rebaselined existing test.

  • dom/Node.cpp:

(WebCore::locateDefaultNamespace):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::lookupNamespaceURI):
(WebCore::locateNamespacePrefix):
(WebCore::Node::lookupPrefix):
(WebCore::appendTextContent): Deleted.
(WebCore::Node::textContent): Deleted.
(WebCore::Node::setTextContent): Deleted.

  • dom/Node.h:
  • xml/NativeXPathNSResolver.cpp:

(WebCore::NativeXPathNSResolver::lookupNamespaceURI):

LayoutTests:

Drop several outdated tests.

  • dom/xhtml/level3/core/nodeisdefaultnamespace03-expected.txt: Removed.
  • dom/xhtml/level3/core/nodeisdefaultnamespace03.js: Removed.
  • dom/xhtml/level3/core/nodeisdefaultnamespace03.xhtml: Removed.
  • dom/xhtml/level3/core/nodelookupnamespaceuri08-expected.txt: Removed.
  • dom/xhtml/level3/core/nodelookupnamespaceuri08.js: Removed.
  • dom/xhtml/level3/core/nodelookupnamespaceuri08.xhtml: Removed.
  • dom/xhtml/level3/core/nodelookupnamespaceuri09-expected.txt: Removed.
  • dom/xhtml/level3/core/nodelookupnamespaceuri09.js: Removed.
  • dom/xhtml/level3/core/nodelookupnamespaceuri09.xhtml: Removed.
3:51 PM Changeset in webkit [204535] by Simon Fraser
  • 8 edits
    2 copies in trunk/Source/WebKit2

[iOS WK2] Clean up form select code
​https://bugs.webkit.org/show_bug.cgi?id=160915

Reviewed by Enrica Casucci.

Some minor forms-related cleanup:

  1. Give WKFormSelectPopover and WKFormSelectPicker their own header files, making

things easier to find.

  1. Remove WKContentView *_view member variables from classes which also stored

the view in their base classes.

Sort the project file.

  • UIProcess/ios/forms/WKFormPopover.h:
  • UIProcess/ios/forms/WKFormPopover.mm:

(-[WKFormRotatingAccessoryPopover accessoryDone]):
(-[WKFormRotatingAccessoryPopover initWithView:]): Deleted.

  • UIProcess/ios/forms/WKFormSelectControl.h:
  • UIProcess/ios/forms/WKFormSelectControl.mm:
  • UIProcess/ios/forms/WKFormSelectPicker.h: Copied from Source/WebKit2/UIProcess/ios/forms/WKFormSelectControl.h.
  • UIProcess/ios/forms/WKFormSelectPicker.mm:
  • UIProcess/ios/forms/WKFormSelectPopover.h: Copied from Source/WebKit2/UIProcess/ios/forms/WKFormSelectControl.h.
  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover initWithView:hasGroups:]):

  • WebKit2.xcodeproj/project.pbxproj:
3:48 PM Changeset in webkit [204534] by adachan@apple.com
  • 7 edits
    2 adds in trunk

Placeholder does not show the first time going into picture-in-picture on video without controls
​https://bugs.webkit.org/show_bug.cgi?id=160868

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/controls/pip-placeholder-without-video-controls.html

If the media controls script is not injected by the time webkitpresentationmodechanged
event fires, the script that updates the stylesheet to show the placeholder won't execute.

To fix this, doing one of the following would work:

  • Ensure the shadow dom for the video is set up when we schedule the

webkitpresentationmodechanged event.

  • Make sure the styles are set up correctly to show the placeholder if needed

when the Controller object (in mediaControlsApple.js) is created.

Doing both here following what we did for the wireless playback status.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
Call updatePictureInPicturePlaceholder() so it updates the styles to show the
placeholder if needed.
(Controller.prototype.updatePictureInPicturePlaceholder):
Extract the logic that updates the placeholder into a separate method so it can
be called when we initialize Controller.
(Controller.prototype.handlePresentationModeChange):
Call updatePictureInPicturePlaceholder().

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.updatePictureInPicturePlaceholder):
Renamed from handlePresentationModeChange().
(ControllerIOS.prototype.handlePresentationModeChange): Deleted.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::enterFullscreen):
Call configureMediaControls() which ensures the shadow root gets added if needed.

LayoutTests:

Test that a video without controls attribute does show after going into picture-in-picture.

  • TestExpectations:
  • media/controls/pip-placeholder-without-video-controls-expected.txt: Added.
  • media/controls/pip-placeholder-without-video-controls.html: Added.
  • platform/mac-wk2/TestExpectations:
3:44 PM Changeset in webkit [204533] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Rename FrameView::m_layoutDisallowed to m_layoutDisallowedCount
​https://bugs.webkit.org/show_bug.cgi?id=160918

Reviewed by Zalan Bujtas.

m_layoutDisallowedCount makes it clearer that it's accumulated.

  • page/FrameView.h:
3:41 PM Changeset in webkit [204532] by andersca@apple.com
  • 2 edits
    1 move in trunk/Source/WebCore

Rename SSLKeyGeneratorMac.cpp to SSLKeyGeneratorMac.mm.

Rubber-stamped by Dan Bernstein.

  • platform/mac/SSLKeyGeneratorMac.mm: Renamed from platform/mac/SSLKeyGeneratorMac.cpp.
3:39 PM Changeset in webkit [204531] by mmaxfield@apple.com
  • 13 edits
    1 move
    1 add
    1 delete in trunk/Source

Migrate line breaking code from ints to Optional<unsigned>s
​https://bugs.webkit.org/show_bug.cgi?id=160859

Reviewed by Darin Adler.

Source/WebCore:

Previously, we were using -1 to mean "before the beginning of the string". Now,
Nullopt means that.

This patch also renames break_lines.{h,cpp} to BreakLines.{h.cpp}. This file was
originally named during the KHTML days.

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/BreakLines.cpp: Renamed from Source/WebCore/rendering/break_lines.cpp.
  • rendering/BreakLines.h: Renamed from Source/WebCore/rendering/break_lines.h.

(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePositionNonLoosely):
(WebCore::nextBreakablePositionLoosely):
(WebCore::nextBreakablePositionKeepingAllWords):
(WebCore::nextBreakablePositionKeepingAllWordsIgnoringNBSP):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
(WebCore::nextBreakablePositionLoose):
(WebCore::nextBreakablePositionIgnoringNBSPLoose):
(WebCore::isBreakable):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::moveTo):
(WebCore::InlineIterator::nextBreakablePosition):
(WebCore::InlineIterator::setNextBreakablePosition):
(WebCore::InlineIterator::InlineIterator): Deleted.

  • rendering/InlineTextBox.cpp:
  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/RenderingAllInOne.cpp:
  • rendering/SimpleLineLayoutTextFragmentIterator.h:
  • rendering/break_lines.h:

(WebCore::isBreakableSpace): Deleted.
(WebCore::shouldBreakAfter): Deleted.
(WebCore::needsLineBreakIterator): Deleted.
(WebCore::nextBreakablePositionNonLoosely): Deleted.
(WebCore::nextBreakablePositionLoosely): Deleted.
(WebCore::nextBreakablePositionKeepingAllWords): Deleted.
(WebCore::nextBreakablePositionKeepingAllWordsIgnoringNBSP): Deleted.
(WebCore::nextBreakablePosition): Deleted.
(WebCore::nextBreakablePositionIgnoringNBSP): Deleted.
(WebCore::nextBreakablePositionLoose): Deleted.
(WebCore::nextBreakablePositionIgnoringNBSPLoose): Deleted.
(WebCore::isBreakable): Deleted.

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::InlineIteratorHistory::nextBreakablePosition):
(WebCore::BreakingContext::InlineIteratorHistory::moveTo):
(WebCore::tryHyphenating):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord):

Source/WebKit/ios:

  • Misc/WebUIKitSupport.mm:

(WebKitGetLastLineBreakInBuffer):

3:33 PM Changeset in webkit [204530] by Chris Dumez
  • 3 edits in trunk/LayoutTests/imported/w3c

Re-sync imported/w3c/web-platform-tests/dom/ranges/Range-mutations.html with upstream
​https://bugs.webkit.org/show_bug.cgi?id=160903

Reviewed by Ryosuke Niwa.

Re-sync imported/w3c/web-platform-tests/dom/ranges/Range-mutations.html with upstream
after ​https://github.com/w3c/web-platform-tests/pull/3468.

  • web-platform-tests/dom/ranges/Range-mutations-expected.txt:
  • web-platform-tests/dom/ranges/Range-mutations.html:
3:32 PM Changeset in webkit [204529] by andersca@apple.com
  • 5 edits
    2 adds in trunk

Add WTF::ScopeExit
​https://bugs.webkit.org/show_bug.cgi?id=160908

Reviewed by Geoffrey Garen.

Source/WTF:

WTF::ScopeExit and WTF::makeScopeExit let you define an object that will invoke a function when the
object goes out of scope. This is going to be used to avoid spagetti-code and gotos in a future patch.

The class is modeled after the LWG paper "P0052 - Generic Scope Guard and RAII Wrapper for the Standard Library".

  • WTF.xcodeproj/project.pbxproj:
  • wtf/Scope.h: Added.

(WTF::makeScopeExit):

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/Scope.cpp: Added.

(TestWebKitAPI::TEST):

3:26 PM Changeset in webkit [204528] by Chris Dumez
  • 3 edits
    2 adds
    2 deletes in trunk

DOM4: getElementsByClassName should include non StyledElements
​https://bugs.webkit.org/show_bug.cgi?id=94718

Reviewed by Ryosuke Niwa.

Source/WebCore:

getElementsByClassName() now includes non StyledElements as per the latest
DOM specification:

The new behavior is consistent with Firefox and Chrome.

Test: fast/dom/getElementsByClassName/non-styled-element.html

  • dom/ClassCollection.h:

(WebCore::ClassCollection::elementMatches):

LayoutTests:

  • fast/dom/getElementsByClassName/011-expected.txt: Removed.
  • fast/dom/getElementsByClassName/011.xml: Removed.

Drop outdated test. It is failing in Firefox and Chrome.

  • fast/dom/getElementsByClassName/non-styled-element-expected.txt: Added.
  • fast/dom/getElementsByClassName/non-styled-element.html: Added.

Add layout test coverage.

3:24 PM Changeset in webkit [204527] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

EWS logs file are rotated too quickly
​https://bugs.webkit.org/show_bug.cgi?id=160724

Reviewed by Daniel Bates.

Currently we are rotating the log file after 10 iterations of queue. If the queue
doesn't have any pending patches, these iterations result in very small amount of
logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
This results in a lot of log files in a day. This patch ensures that we rotate the
log file when its file size is greater than or equal to 100 KB.

  • EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
3:20 PM Changeset in webkit [204526] by dbates@webkit.org
  • 15 edits
    2 moves
    4 deletes in trunk

WKSI static library should be named by major iOS revision, not individual updates
​https://bugs.webkit.org/show_bug.cgi?id=160727
<rdar://problem/22274848>

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac:

  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

  • Configurations/Base.xcconfig:
  • Configurations/BaseTarget.xcconfig:
  • Configurations/DebugRelease.xcconfig:

Tools:

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • Scripts/copy-webkitlibraries-to-product-directory:
  • WebKitTestRunner/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:

WebKitLibraries:

  • libWebKitSystemInterfaceIOSDevice9.0.a: Removed.
  • libWebKitSystemInterfaceIOSDevice9.2.a: Removed.
  • libWebKitSystemInterfaceIOSDevice9.a: Renamed from WebKitLibraries/libWebKitSystemInterfaceIOSDevice9.3.a.
  • libWebKitSystemInterfaceIOSSimulator9.0.a: Removed.
  • libWebKitSystemInterfaceIOSSimulator9.2.a: Removed.
  • libWebKitSystemInterfaceIOSSimulator9.a: Renamed from WebKitLibraries/libWebKitSystemInterfaceIOSSimulator9.3.a.
3:15 PM Changeset in webkit [204525] by Simon Fraser
  • 15 edits
    4 adds in trunk

Make it possible to test iOS select elements, and add iPhone and iPad tests for them
​https://bugs.webkit.org/show_bug.cgi?id=160909

Reviewed by Enrica Casucci.

Source/WebKit2:

Hook up form-related UIScriptController functions, and plumb through the various
<select> pickers the ability to select a row.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView dismissFormAccessoryView]):
(-[WKWebView selectFormAccessoryPickerRow:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView selectFormAccessoryPickerRow:]):

  • UIProcess/ios/forms/WKFormSelectControl.h:
  • UIProcess/ios/forms/WKFormSelectControl.mm:

(-[WKFormSelectControl selectRow:inComponent:extendingSelection:]):

  • UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker selectRow:inComponent:extendingSelection:]):
(-[WKSelectSinglePicker selectRow:inComponent:extendingSelection:]):

  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectPopover selectRow:inComponent:extendingSelection:]):

Tools:

Add functions to UIScriptController to dismiss the form accessory view for iOS,
and to programmatically pick a row from a <select> picker.

  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::dismissFormAccessoryView):
(WTR::UIScriptController::selectFormAccessoryPickerRow):

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::dismissFormAccessoryView):
(WTR::UIScriptController::selectFormAccessoryPickerRow):

LayoutTests:

Add iPhone and iPad tests for the <select> pickers. The iPhone test has to
use a didShowKeyboardCallback to know when to select the appropriate row,
and to dismiss the picker. The iPad test can just select the row, which also
dismisses the popover.

  • fast/forms/ios/choose-select-option-expected.txt: Added.
  • fast/forms/ios/choose-select-option.html: Added.
  • fast/forms/ios/ipad/choose-select-option-expected.txt: Added.
  • fast/forms/ios/ipad/choose-select-option.html: Added.
2:44 PM Changeset in webkit [204524] by beidson@apple.com
  • 16 edits in trunk/Source

Cleanup WK2 platform gamepad handling.
​https://bugs.webkit.org/show_bug.cgi?id=160871

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (No currently testable change in behavior).

This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently

monitoring gamepad inputs because an interested WKWebView is not front and center.

3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.

  • platform/gamepad/GamepadProviderClient.h:

(WebCore::GamepadProviderClient::setInitialConnectedGamepads):

  • platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::stopMonitoringInput):
(WebCore::HIDGamepadProvider::startMonitoringInput):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired):

  • platform/gamepad/mac/HIDGamepadProvider.h:

Source/WebKit2:

This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently

monitoring gamepad inputs because an interested WKWebView is not front and center.

3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.

  • Platform/Logging.h:
  • UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::setInitialConnectedGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::viewBecameActive):
(WebKit::UIGamepadProvider::viewBecameInactive):
(WebKit::UIGamepadProvider::stopMonitoringGamepads):
(WebKit::UIGamepadProvider::snapshotGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):
(WebKit::UIGamepadProvider::UIGamepadProvider): Deleted.
(WebKit::UIGamepadProvider::scheduleDisableGamepadMonitoring): Deleted.
(WebKit::UIGamepadProvider::disableMonitoringTimerFired): Deleted.

  • UIProcess/Gamepad/UIGamepadProvider.h:
  • UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp:

(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setInitialConnectedGamepads):

  • UIProcess/WebProcessPool.h:
  • WebProcess/Gamepad/WebGamepadProvider.cpp:

(WebKit::WebGamepadProvider::setInitialGamepads):

  • WebProcess/Gamepad/WebGamepadProvider.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setInitialGamepads):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
2:18 PM Changeset in webkit [204523] by Simon Fraser
  • 14 edits
    2 moves
    4 adds in trunk

[iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
​https://bugs.webkit.org/show_bug.cgi?id=160878

Reviewed by Tim Horton.
Source/WebKit2:

Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
now that we have the ability to run tests in the iPad simulator.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView forceIPadStyleZoomOnInputFocus]): Deleted.
(-[WKWebView setForceIPadStyleZoomOnInputFocus:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView inputAccessoryView]):
(-[WKContentView requiresAccessoryView:]): Deleted.
(-[WKContentView forceIPadStyleZoomOnInputFocus]): Deleted.
(-[WKContentView setForceIPadStyleZoomOnInputFocus:]): Deleted.

Tools:

Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
now that we have the ability to run tests in the iPad simulator.

  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
(WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues): Deleted.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
(WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.

LayoutTests:

Move forms/ios/focus-input-via-button-ipad.html into fast/forms/ios/ipad, making it
an iPad test, which allows for the removal of the "useIPadBehavior" flag.

Add fast/viewport/ios/ipad/width-is-device-width.html with iPad-specific results.

  • fast/forms/ios/ipad/focus-input-via-button-expected.txt: Renamed from LayoutTests/fast/forms/ios/focus-input-via-button-ipad-expected.txt.
  • fast/forms/ios/ipad/focus-input-via-button.html: Renamed from LayoutTests/fast/forms/ios/focus-input-via-button-ipad.html.
  • fast/forms/ios/resources/zooming-test-utils.js:

(testZoomAfterTap):

  • fast/viewport/ios/ipad/width-is-device-width-expected.txt: Added.
  • fast/viewport/ios/ipad/width-is-device-width.html: Added.
  • platform/ios-simulator-wk2/TestExpectations: Enable fast/viewport/ios, because leaving

them skipped from the base TestExpectations is evil.

1:58 PM Changeset in webkit [204522] by Chris Dumez
  • 10 edits in trunk

querySelector() / querySelectorAll() should always throw a SyntaxError when failing to parse selector string
​https://bugs.webkit.org/show_bug.cgi?id=160906

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/nodes/Element-matches-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:

Source/WebCore:

querySelector() / querySelectorAll() should always throw a SyntaxError
when failing to parse selector string:

In some cases, WebKit was throwing a NamespaceError instead.

No new tests, rebaselined existing tests.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add):

LayoutTests:

Rebaseline several layout tests now that we throw a different exception type.

  • fast/css/parsing-css-attribute-case-insensitive-value-1-expected.txt:
  • fast/css/parsing-css-attribute-case-insensitive-value-2-expected.txt:
  • fast/dom/SelectorAPI/not-supported-namespace-in-selector-expected.txt:
1:32 PM Changeset in webkit [204521] by Brent Fulgham
  • 6 edits
    3 adds in trunk

Upgrade-Insecure-Request state is improperly retained between navigations
​https://bugs.webkit.org/show_bug.cgi?id=160905
<rdar://problem/27075526>

Reviewed by Andy Estes.

Source/WebCore:

Correct the handling of Upgrade-Insecure-Request state to match the specification, so that
performing top-level navigation to sites that do not have the Upgrade-Insecure-Request header
does not automatically upgrade insecure loads. The same loads performed in an iframe should
be upgraded.

The iframe case was already handled in our tests, but a new test is added that models the top-level
navigation and confirms that an upgrade is not performed.

Tests: http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation.html

  • dom/Document.cpp:

(WebCore::Document::initContentSecurityPolicy): Properly inherit Upgrade-Insecure-Request state for children
of existing frames.

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin): Retain the history of upgraded resources (per the specification) so that
we continue to upgrade resources that were upgraded during earlier navigations. Note that we do NOT want to
retain the state of the Upgrade-Insecure-Requests header itself.

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::copyStateFrom): Update to use new helper function.
(WebCore::ContentSecurityPolicy::copyUpgradeInsecureRequestStateFrom): New helper function.

  • page/csp/ContentSecurityPolicy.h:

LayoutTests:

  • http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation.html: Added.
  • http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-site.html: Added.
12:57 PM Changeset in webkit [204520] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: DOM nodes shift when hovering over them in Console
​https://bugs.webkit.org/show_bug.cgi?id=160789
<rdar://problem/27815600>

Reviewed by Matt Baker.

  • UserInterface/Views/FormattedValue.css:

(.formatted-node > .tree-outline.dom ol): Deleted.

12:29 PM Changeset in webkit [204519] by andersca@apple.com
  • 9 edits
    1 add in trunk

Add an address-of operator to RetainPtr
​https://bugs.webkit.org/show_bug.cgi?id=160879

Reviewed by Tim Horton.

Source/WTF:

This will make some security-related code from WebKitSystemInterface easier to port.

  • wtf/HashIterators.h:

(WTF::HashTableValuesIterator::get):

  • wtf/HashTable.h:

(WTF::HashTableBucketInitializer<true>::initialize):
Use std::addressof instead of &, in case & is overloaded.

  • wtf/RetainPtr.h:

(WTF::RetainPtr::operator&):
Implement this.

Tools:

Test HashMap and HashSet with an object whose operator& is deleted.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Sort the Xcode project.

  • TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.

(DeletedAddressOfOperator::DeletedAddressOfOperator):
(DeletedAddressOfOperator::value):
(DeletedAddressOfOperator::operator==):
(WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
(WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
(WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):

12:25 PM Changeset in webkit [204518] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Data grid has a double left border when the first column is hidden
​https://bugs.webkit.org/show_bug.cgi?id=160723
<rdar://problem/27778081>

Reviewed by Timothy Hatcher.

This patch exploits the fact hiding columns that aren't first in DataGrid don't create double
borders.

  • UserInterface/Views/DataGrid.css:

(.data-grid table.header,):
(.data-grid :matches(th, td):first-child):
(@media (-webkit-min-device-pixel-ratio: 2)):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):

12:08 PM Changeset in webkit [204517] by Chris Dumez
  • 3 edits
    2 adds in trunk

ctx.drawImage should clip source rect if it is outside the source image
​https://bugs.webkit.org/show_bug.cgi?id=160804

Reviewed by Simon Fraser.

Source/WebCore:

According to the specification [1]"
"When the source rectangle is outside the source image, the source rectangle
must be clipped to the source image and the destination rectangle must be
clipped in the same proportion."

Firefox and Chrome behave according to the specification. This patch aligns
our behavior.

[1] ​https://html.spec.whatwg.org/multipage/scripting.html#dom-context-2d-drawimage

Test: fast/canvas/drawImage-srcRect-clipping.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

LayoutTests:

Add layout test coverage.

  • fast/canvas/drawImage-srcRect-clipping-expected.html: Added.
  • fast/canvas/drawImage-srcRect-clipping.html: Added.
12:04 PM Changeset in webkit [204516] by commit-queue@webkit.org
  • 34 edits
    2 adds in trunk

⛱ : Implement parsing of Media Constraints for getUserMedia algorithm in Media Capture and Streaming Spec
​https://bugs.webkit.org/show_bug.cgi?id=160533
<rdar://problem/27688483>

Patch by George Ruan <​gruan@apple.com> on 2016-08-16
Reviewed by Chris Dumez.

Source/WebCore:

Two getUserMedia tests have been updated to reflect changes and cover limited
testing of the parsing of media constraints when given to getUserMedia().
Current testing infrastructure doesn't support full testing of the parsing
of media constraints. Either a mock needs to be created or the selectSettings()
algorithm will need to be implemented so we can see the constraints reflected
by the settings of media stream tracks. See ​https://bugs.webkit.org/show_bug.cgi?id=160791.

The specification on media constraints and how they are provided to getUserMedia() and
applyConstraints() has changed. These constraints are parsed in the bindings and are
stored in a new class MediaConstraint with derived classes LongConstraint, DoubleConstraint,
BooleanConstraint, and StringConstraint, each holding their respective type of constraint
value.

  • CMakeLists.txt: Add JSMediaDevicesCustom.cpp and MediaConstraints.cpp.
  • Modules/mediastream/CaptureDeviceManager.cpp:

(CaptureDeviceManager::verifyConstraintsForMediaType): Make changes according
to how format of MediaConstraint was changed.
(CaptureDeviceManager::sessionSupportsConstraint): Ditto.
(CaptureDeviceManager::isSupportedFrameRate): Ditto. Also for the time being
support constraint validation with a static acceptable frame rate range of 0-60.
See relevant ​https://bugs.webkit.org/show_bug.cgi?id=160794 for supporting
constraint validation of frame rate dynamically.

  • Modules/mediastream/CaptureDeviceManager.h: Make changes according to how

format of MediaConstraint was changed.

  • Modules/mediastream/MediaConstraintsImpl.cpp: Remove code for parsing media

constraints in the legacy format with keys 'mandatory' and 'optional'. Removal
of legacy code is fine since MEDIA_STREAM feature flag is not enabled for any port.
(WebCore::MediaConstraintsImpl::create): Ditto
(WebCore::MediaConstraintsImpl::initialize): Still used by applyConstraints().
Added FIXME to remove after applyConstraints implementation is changed according
to w3c spec changes.
(WebCore::MediaConstraintsImpl::mandatoryConstraints): Make changes according to
how media constraint data is now stored.
(WebCore::MediaConstraintsImpl::advancedConstraints): Ditto.
(WebCore::MediaConstraintsImpl::getMandatoryConstraints): Deleted.
(WebCore::MediaConstraintsImpl::getOptionalConstraints): Deleted.
(WebCore::MediaConstraintsImpl::getMandatoryConstraintValue): Deleted.
(WebCore::MediaConstraintsImpl::getOptionalConstraintValue): Deleted.

  • Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsImpl::MediaConstraintsImpl): Add a constructor to allow
construction of MediaConstraintsImpl object based on how the custom binding code
for MediaDevices would parse the media constraints given to getUserMedia().

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::getUserMedia): Make changes according to how media constraint
data is now stored.

  • Modules/mediastream/MediaDevices.h: Ditto.
  • Modules/mediastream/MediaDevices.idl: Add custom binding to parse media constraints,

since we do not have support for automatic binding generation of sequence of dictionaries,
dictionary inheritance, dictionaries inside of dictionaries, disjunctions, or dictionaries
without an interface.

  • Modules/mediastream/MediaStreamTrack.cpp: Add FIXME with related bug.

(WebCore::MediaStreamTrack::applyConstraints): Ditto.

  • Modules/mediastream/UserMediaRequest.cpp: Make changes according to how media constraint

data is now parsed and stored.
(WebCore::UserMediaRequest::start): Ditto.
(WebCore::UserMediaRequest::UserMediaRequest): Ditto.
(WebCore::UserMediaRequest::didCreateStream): Ditto.
(WebCore::parseOptions): Deleted.

  • Modules/mediastream/UserMediaRequest.h: Ditto.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp: Added JSMediaDevicesCustom.cpp.
  • bindings/js/JSMediaDevicesCustom.cpp: Added. Custom bindings to parse media constraints.

(WebCore::initializeStringConstraintWithList): Initialize string constraint 'exact' or 'ideal'
value according to an ArrayValue.
(WebCore::createStringConstraint): Given a dictionary acting as a 'MediaTrackConstraintSet'
and a string constraint key (e.g for facingMode), creates a native StringConstraint class to hold
the data.
(WebCore::createBooleanConstraint): Ditto but for constraints of type boolean.
(WebCore::createDoubleConstraint): Ditto but for constraints of type double.
(WebCore::createIntConstraint): Ditto but for constraints of type long.
(WebCore::parseMediaTrackConstraintSetForKey): Parses a given dictionary acting as a
'MediaTrackConstraintSet' for a constraint as the key and creates the correct native object to hold
the data.
(WebCore::parseAdvancedConstraints): Parses the advanced constraints.
(WebCore::parseConstraints): Parses the constraints of a Dictionary acting as a
'MediaTrackConstraints'.
(WebCore::JSMediaDevices::getUserMedia): Parses the constraint input to getUserMedia.

  • platform/mediastream/MediaConstraints.cpp: Added. Add MediaConstraint classes with derived

classes IntConstraint, DoubleConstraint, BooleanConstraint, and StringConstraint to act as
containers for the parsed data from getUserMedia().
(WebCore::MediaConstraint::create): Factory that creates the correct derived class based on the
name of a media constraint.
(WebCore::MediaConstraint::getMin): Interface for getting the min value for a constraint.
ASSERT checks are in place to prevent calling getMin with the incorrect constraint type.
(WebCore::MediaConstraint::getMax): Ditto but for max value of constraint.
(WebCore::MediaConstraint::getExact): Ditto but for exact value of constraint.
(WebCore::MediaConstraint::getIdeal): Ditto but for ideal value of constraint.
(WebCore::IntConstraint::create): Creates a long constraint.
(WebCore::IntConstraint::setMin): Sets min value of constraint.
(WebCore::IntConstraint::setMax): Sets max value of constraint.
(WebCore::IntConstraint::setExact): Sets exact value of constraint.
(WebCore::IntConstraint::setIdeal): Sets ideal value of constraint.
(WebCore::IntConstraint::getMin): Overrides interface function and gets min value of constraint.
(WebCore::IntConstraint::getMax): Ditto but for max value of constraint.
(WebCore::IntConstraint::getExact): Ditto but for exact value of constraint.
(WebCore::IntConstraint::getIdeal): Ditto but for ideal value of constraint.
(WebCore::DoubleConstraint::create): Ditto, DoubleConstraint instead of IntConstraint.
(WebCore::DoubleConstraint::setMin): Ditto.
(WebCore::DoubleConstraint::setMax): Ditto.
(WebCore::DoubleConstraint::setExact): Ditto.
(WebCore::DoubleConstraint::setIdeal): Ditto.
(WebCore::DoubleConstraint::getMin): Ditto.
(WebCore::DoubleConstraint::getMax): Ditto.
(WebCore::DoubleConstraint::getExact): Ditto.
(WebCore::DoubleConstraint::getIdeal): Ditto.
(WebCore::BooleanConstraint::create): Ditto, BooleanConstraint instead of IntConstraint.
(WebCore::BooleanConstraint::setExact): Ditto.
(WebCore::BooleanConstraint::setIdeal): Ditto.
(WebCore::BooleanConstraint::getExact): Ditto.
(WebCore::BooleanConstraint::getIdeal): Ditto.
(WebCore::StringConstraint::create): Ditto, StringConstraint instead of IntConstraint.
(WebCore::StringConstraint::setExact): Ditto.
(WebCore::StringConstraint::appendExact): Appends string to 'exact' value of StringConstraint.
(WebCore::StringConstraint::setIdeal): Ditto.
(WebCore::StringConstraint::appendIdeal): Appends string to 'ideal' value of StringConstraint.
(WebCore::StringConstraint::getExact): Ditto.
(WebCore::StringConstraint::getIdeal): Ditto.

  • platform/mediastream/MediaConstraints.h: Add MediaConstraint classes with derived

classes IntConstraint, DoubleConstraint, BooleanConstraint, and StringConstraint to act as
containers for the parsed data from getUserMedia().
(WebCore::MediaConstraint::~MediaConstraint):
(WebCore::MediaConstraint::name): Get name of constraint.
(WebCore::MediaConstraint::MediaConstraint): Constructor.
(WebCore::NumericConstraint::NumericConstraint): Base class of DoubleConstraint and IntConstraint.
(WebCore::NumericConstraint::setHasMin): Sets whether object has min vlaue.
(WebCore::NumericConstraint::setHasMax): Ditto but for max.
(WebCore::NumericConstraint::setHasExact): Ditto but for exact.
(WebCore::NumericConstraint::setHasIdeal): Ditto but for ideal.
(WebCore::NumericConstraint::hasMin): Gets whether object has min value.
(WebCore::NumericConstraint::hasMax): Ditto but for max.
(WebCore::NumericConstraint::hasExact): Ditto but for exact.
(WebCore::NumericConstraint::hasIdeal): Ditto but for ideal.

  • platform/mediastream/RealtimeMediaSourceCenter.h: Parameters can be reference since

lifetime is guaranteed and ownership is not taken.

  • platform/mediastream/mac/AVCaptureDeviceManager.h: Ditto.
  • platform/mediastream/mac/AVCaptureDeviceManager.mm: Ditto.

(WebCore::AVCaptureDeviceManager::verifyConstraintsForMediaType): Ditto.
(WebCore::AVCaptureDeviceManager::sessionSupportsConstraint): Make changes according to
how media constraint data is stored.
(WebCore::AVCaptureDeviceManager::createMediaSourceForCaptureDeviceWithConstraints):
Ditto.
(WebCore::AVCaptureDeviceManager::isSupportedFrameRate): Ditto.

  • platform/mediastream/mac/AVVideoCaptureSource.h: Change frame rate from 'float' to 'double'.
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setFrameRateConstraint): Ditto.
(WebCore::AVVideoCaptureSource::applyConstraints): Make changes according to how media constraint
data is stored. The implementation of applyConstraints has also drastically changed, and a FIXME
is associated.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints):
The bindings will always pass a non-null MediaConstraints object to
getUserMedia() so a pointer MediaConstraints parameter is not necessary.
(WebCore::RealtimeMediaSourceCenterMac::createMediaStream): Ditto.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h: Change 'override' to 'final'

since RealtimeMediaSourceCenterMac is a 'final' class.

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp: Ditto to

RealtimeMediaSourceCenterMac.
(WebCore::RealtimeMediaSourceCenterOwr::createMediaStream): Ditto.
(WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints):

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h: Ditto.
  • platform/mock/MediaConstraintsMock.cpp: Change how constraint validation is mocked.

(WebCore::isLongMediaConstraintSatisfiable): Sets arbitrary min and max supported value to be 0 and 10,
respectively. Then checks if constraint is satisfiable.
(WebCore::isDoubleMediaConstraintSatisfiable): Ditto but with double.
(WebCore::isBooleanMediaConstraintSatisfiable): Mock a boolean constraint to only be satisfiable if the
'exact' value is true.
(WebCore::isStringMediaConstraintSatisfiable): Mock a string constraint to only be satisfiable if the
'exact' value has the string 'valid'
(WebCore::isSatisfiable): Checks if a certain constraint is satisfiable.
(WebCore::MediaConstraintsMock::verifyConstraints): Verifies if the constraints are satisfiable.
(WebCore::isSupported): Deleted.
(WebCore::isValid): Deleted.

  • platform/mock/MediaConstraintsMock.h: Change argument of MediaConstraints to raw pointer.
  • platform/mock/MockRealtimeMediaSourceCenter.cpp: Change arguments of MediaConstraints to a raw pointer

and make changes according to how the MediaConstraint was changed.
(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):

  • platform/mock/MockRealtimeMediaSourceCenter.h: Change argument of MediaConstraints to raw pointer.

LayoutTests:

Implementation of parsing of media constraints passed to getUserMedia has changed to meet
the current w3c standards. Three major changes have been introduced

  • If the parameter in getUserMedia is missing a TypeError is thrown, according to the IDL spec
  • Given a Dictionary value with neither 'audio' nor 'video' keys having dictionary values

or 'true', the promise is rejected with a TypeError

  • If the constraints cannot be satisfied the promise is rejected with a DataError. This should

be changed to an OverConstrainedError in the future. See
​https://bugs.webkit.org/show_bug.cgi?id=160790

  • fast/mediastream/MediaDevices-getUserMedia-expected.txt:
  • fast/mediastream/MediaDevices-getUserMedia.html: Added limited testing of parsing of

media constraints for getUserMedia(), this includes only testing of mandatory constraints
and whether the promise is rejected if the constraints cannot be satisfied.

  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html: As format of media constraints have changed, the test

has been updated to reflect those changes.

11:11 AM Changeset in webkit [204515] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix WinCairo build after r204512.

  • platform/network/curl/SocketStreamHandleImpl.h:
  • platform/network/curl/SocketStreamHandleImplCurl.cpp:

(WebCore::createCopy):
(WebCore::SocketStreamHandleImpl::createCopy): Deleted.

11:03 AM Changeset in webkit [204514] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

False crashes in fast/text/emoji-gender-* tests
​https://bugs.webkit.org/show_bug.cgi?id=160779

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-16
Reviewed by Alexey Proskuryakov.

Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.

  • Scripts/webkitpy/port/driver.py:

(Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.

  • Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
  • Scripts/webkitpy/port/server_process.py:

(ServerProcess.write): Allow caller to disable crash flag on exception.

10:26 AM Changeset in webkit [204513] by commit-queue@webkit.org
  • 4 edits
    1 move in trunk/Source/WebInspectorUI

Web Inspector: Do not request Scope Chain lists if section is collapsed (mainly Global Variables)
​https://bugs.webkit.org/show_bug.cgi?id=140567
<rdar://problem/19504745>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-16
Reviewed by Timothy Hatcher.

  • UserInterface/Main.html:

New file name.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties.fillSection):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
Avoid fetching object properties until the user expands the section.

  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateCallFramesSection):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._generateWatchExpressionsSection):
Avoid fetching scope variable properties until the user expands the section.

  • UserInterface/Views/ObjectPropertiesDetailSectionRow.js: Renamed from Source/WebInspectorUI/UserInterface/Views/DetailsSectionPropertiesRow.js.

(WebInspector.ObjectPropertiesDetailSectionRow):
(WebInspector.ObjectPropertiesDetailSectionRow.prototype.get objectTree):
(WebInspector.ObjectPropertiesDetailSectionRow.prototype._detailsSectionCollapsedStateChanged):
Rename and simplify the class since it always has an ObjectTreeView.
By default the section will auto-expand the ObjectTreeView, however
if provided a details section group, it will defer expanion until
the group expands.

10:14 AM Changeset in webkit [204512] by achristensen@apple.com
  • 15 edits in trunk/Source

Clean up WebSockets
​https://bugs.webkit.org/show_bug.cgi?id=160889

Reviewed by Darin Adler.

Source/WebCore:

We should use size_t's instead of ints for data lengths.
SocketStreamHandleClient is now purely virtual.
A few places that will need SocketStreamHandleImpls instead of SocketStreamHandles now have them.
This patch doesn't change behavior.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didCloseSocketStream):
(WebCore::WebSocketChannel::didReceiveSocketStreamData):

  • Modules/websockets/WebSocketChannel.h:
  • platform/network/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandle::state):
(WebCore::SocketStreamHandle::send):

  • platform/network/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::bufferedAmount):
(WebCore::SocketStreamHandle::client): Deleted.

  • platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::~SocketStreamHandleClient):
(WebCore::SocketStreamHandleClient::didOpenSocketStream): Deleted.
(WebCore::SocketStreamHandleClient::didCloseSocketStream): Deleted.
(WebCore::SocketStreamHandleClient::didReceiveSocketStreamData): Deleted.
(WebCore::SocketStreamHandleClient::didUpdateBufferedAmount): Deleted.
(WebCore::SocketStreamHandleClient::didFailSocketStream): Deleted.

  • platform/network/cf/SocketStreamHandleImpl.h:

(WebCore::SocketStreamHandleImpl::create):

  • platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):

  • platform/network/curl/SocketStreamHandleImpl.h:

(WebCore::SocketStreamHandleImpl::create):

  • platform/network/soup/SocketStreamHandleImpl.h:
  • platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::create):

Source/WebKit2:

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::didCloseSocketStream):
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):

  • UIProcess/InspectorServer/WebSocketServerConnection.h:
10:05 AM Changeset in webkit [204511] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: add "Copy Selected" context menu item to Console
​https://bugs.webkit.org/show_bug.cgi?id=151836

Patch by Devin Rousso <Devin Rousso> on 2016-08-16
Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._previousMessageRepeatCountUpdated):
(WebInspector.LogContentView.prototype._handleContextMenuEvent):
(WebInspector.LogContentView.prototype._mousedown):

9:57 AM Changeset in webkit [204510] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Visual Styles: "Text -> Content" isn't escaped
​https://bugs.webkit.org/show_bug.cgi?id=158271

Patch by Devin Rousso <Devin Rousso> on 2016-08-16
Reviewed by Timothy Hatcher.

  • UserInterface/Base/Utilities.js:

(String.prototype.hasMatchingEscapedQuotes):
Checks that the given string has property escaped quotes (single or double).

  • UserInterface/Views/VisualStyleBasicInput.js:

(WebInspector.VisualStyleBasicInput):
(WebInspector.VisualStyleBasicInput.prototype._handleInputElementInput):

9:57 AM Changeset in webkit [204509] by Chris Dumez
  • 16 edits in trunk/Source

Unreviewed, rolling out r204506.

Broke the build

Reverted changeset:

"Cleanup WK2 platform gamepad handling."
​https://bugs.webkit.org/show_bug.cgi?id=160871
​http://trac.webkit.org/changeset/204506

9:56 AM Changeset in webkit [204508] by Darin Adler
  • 18 edits
    1 delete in trunk/Source

[Cocoa] Remove dependency on Objective-C bindings in WebKit2 editing code
​https://bugs.webkit.org/show_bug.cgi?id=160891

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Removed EditorCocoa.h.
  • editing/Editor.cpp: Removed member initialization for members now

initialized in the class definition.

  • editing/Editor.h: Added FragmentAndResources struct, createFragment

member function, and _WebCreateFragment function. Also initialize all the
scalar data members here instead of in the constructor.

  • editing/cocoa/EditorCocoa.h: Removed. This was unused.
  • editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::createFragment): Added. Calls through to WebKitLegacy
using soft linking for now, but later should be implemented here in WebCore.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::createFragmentAndAddResources): Call createFragment.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::createFragmentAndAddResources): Call createFragment.

  • loader/EmptyClients.h: Removed documentFragmentFromAttributedString

implementation.

  • page/EditorClient.h: Removed documentFragmentFromAttributedString.

Two reasons: The first is that this is now implemented in WebCore. While
there is a call through to WebKitLegacy, it's a temporary thing and done
with soft linking. The second reason is that this returned a raw pointer,
which is not safe in general. Was safe here because it was returning a
pointer owned by an autoreleased Objective-C object.

Source/WebKit/mac:

  • WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
  • WebCoreSupport/WebEditorClient.mm:

(attributesForAttributedStringConversion): Replaced the
createExcludedElementsForAttributedStringConversion function with this one.
No good reason to keep the array around instead of the dictionary.
(_WebCreateFragment): Renamed from documentFragmentFromAttributedString.
This is now a global function exported so it can be called by WebCore with
a different way of returning its value.

  • WebKit.exp: Added _WebCreateFragment.
  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
Removed long-ago-obsolete workaround for Radar bug 5052369.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebEditorClient.h: Removed documentFragmentFromAttributedString.
  • WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

(WebKit::WebEditorClient::documentFragmentFromAttributedString): Deleted.

  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

(WebKit::createExcludedElementsForAttributedStringConversion): Deleted.
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Deleted.

9:52 AM Changeset in webkit [204507] by commit-queue@webkit.org
  • 30 edits in trunk/Source/WebInspectorUI

Modernize model objects simple getters
​https://bugs.webkit.org/show_bug.cgi?id=160863

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-16
Reviewed by Timothy Hatcher.

Simplify the style of many Model objects with basic accessors.
We reduce them to a single line and group them together so
that they can be more easily read at a glance.

  • UserInterface/Models/AnalyzerMessage.js:
  • UserInterface/Models/ApplicationCacheFrame.js:
  • UserInterface/Models/ApplicationCacheManifest.js:
  • UserInterface/Models/BreakpointAction.js:
  • UserInterface/Models/CSSMedia.js:
  • UserInterface/Models/CSSSelector.js:
  • UserInterface/Models/CollectionEntry.js:
  • UserInterface/Models/CollectionEntryPreview.js:
  • UserInterface/Models/DOMStorageObject.js:
  • UserInterface/Models/DatabaseObject.js:
  • UserInterface/Models/DatabaseTableObject.js:
  • UserInterface/Models/ExecutionContext.js:
  • UserInterface/Models/GarbageCollection.js:
  • UserInterface/Models/IndexedDatabase.js:
  • UserInterface/Models/IndexedDatabaseObjectStore.js:
  • UserInterface/Models/IndexedDatabaseObjectStoreIndex.js:
  • UserInterface/Models/ObjectPreview.js:
  • UserInterface/Models/ProbeSet.js:
  • UserInterface/Models/PropertyDescriptor.js:
  • UserInterface/Models/PropertyPath.js:
  • UserInterface/Models/PropertyPreview.js:
  • UserInterface/Models/SourceCodePosition.js:
  • UserInterface/Models/SourceCodeSearchMatchObject.js:
  • UserInterface/Models/SourceCodeTimeline.js:
  • UserInterface/Models/StructureDescription.js:
  • UserInterface/Models/TextRange.js:
  • UserInterface/Models/Timeline.js:
  • UserInterface/Models/TimelineRecording.js:
  • UserInterface/Models/TypeDescription.js:
9:27 AM Changeset in webkit [204506] by beidson@apple.com
  • 16 edits in trunk/Source

Cleanup WK2 platform gamepad handling.
​https://bugs.webkit.org/show_bug.cgi?id=160871

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (No currently testable change in behavior).

This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently

monitoring gamepad inputs because an interested WKWebView is not front and center.

3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.

  • platform/gamepad/GamepadProviderClient.h:

(WebCore::GamepadProviderClient::setInitialConnectedGamepads):

  • platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::stopMonitoringInput):
(WebCore::HIDGamepadProvider::startMonitoringInput):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired):

  • platform/gamepad/mac/HIDGamepadProvider.h:

Source/WebKit2:

This patch does a few things:
1 - Separates the concepts of "monitoring gamepads" and "monitoring gamepad inputs"
2 - Uses this new concept to much more cleanly handle the case where we are not currently

monitoring gamepad inputs because an interested WKWebView is not front and center.

3 - Pre-populates the "initial set of gamepads" in WebProcesses that start listening for gamepads.

  • Platform/Logging.h:
  • UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::setInitialConnectedGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::viewBecameActive):
(WebKit::UIGamepadProvider::viewBecameInactive):
(WebKit::UIGamepadProvider::stopMonitoringGamepads):
(WebKit::UIGamepadProvider::snapshotGamepads):
(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):
(WebKit::UIGamepadProvider::UIGamepadProvider): Deleted.
(WebKit::UIGamepadProvider::scheduleDisableGamepadMonitoring): Deleted.
(WebKit::UIGamepadProvider::disableMonitoringTimerFired): Deleted.

  • UIProcess/Gamepad/UIGamepadProvider.h:
  • UIProcess/Gamepad/mac/UIGamepadProviderHID.cpp:

(WebKit::UIGamepadProvider::platformStopMonitoringInput):
(WebKit::UIGamepadProvider::platformStartMonitoringInput):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setInitialConnectedGamepads):

  • UIProcess/WebProcessPool.h:
  • WebProcess/Gamepad/WebGamepadProvider.cpp:

(WebKit::WebGamepadProvider::setInitialGamepads):

  • WebProcess/Gamepad/WebGamepadProvider.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setInitialGamepads):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
9:23 AM Changeset in webkit [204505] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r204494.
​https://bugs.webkit.org/show_bug.cgi?id=160901

Broke the iOS build (Requested by cdumez on #webkit).

Reverted changeset:

"Drop unused EventTarget::hasActiveEventListeners()"
​https://bugs.webkit.org/show_bug.cgi?id=160869
​http://trac.webkit.org/changeset/204494

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-08-16

8:58 AM Changeset in webkit [204504] by Ryan Haddad
  • 2 edits in trunk/JSTests

Unreviewed, rolling out r204464.

This is no longer needed after r204495.

Reverted changeset:

"Skip failing test mozilla/ecma/LexicalConventions/7.7.3.js"
​https://bugs.webkit.org/show_bug.cgi?id=160662
​http://trac.webkit.org/changeset/204464

8:53 AM Changeset in webkit [204503] by Darin Adler
  • 2 edits in trunk/Source/WebCore
  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: Regenerated results, which were affected by the sequence<T> change last night.
2:43 AM Changeset in webkit [204502] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Hardening of getLinkedFonts function.
​https://bugs.webkit.org/show_bug.cgi?id=160850

The SUCCEEDED macro should only be used for functions returning a HRESULT type.
Also, make sure a string array index will not exceed the string length.

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::getLinkedFonts):

12:55 AM Changeset in webkit [204501] by commit-queue@webkit.org
  • 3 edits
    1 move
    4 deletes in trunk/Source/WebCore

Simplify SocketStreamError
​https://bugs.webkit.org/show_bug.cgi?id=160888

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-08-16
Reviewed by Darin Adler.

SocketStreamErrorBase and platform-specific SocketStreamError were overly complicated.
They had many functions that were never used. There's no reason to have two separate classes.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/SocketStreamError.h: Copied from Source/WebCore/platform/network/SocketStreamErrorBase.h.

(WebCore::SocketStreamError::SocketStreamError):
(WebCore::SocketStreamError::isNull):
(WebCore::SocketStreamError::errorCode):
(WebCore::SocketStreamError::failingURL):
(WebCore::SocketStreamError::localizedDescription):
(WebCore::SocketStreamErrorBase::isNull): Deleted.
(WebCore::SocketStreamErrorBase::errorCode): Deleted.
(WebCore::SocketStreamErrorBase::failingURL): Deleted.
(WebCore::SocketStreamErrorBase::localizedDescription): Deleted.
(WebCore::SocketStreamErrorBase::SocketStreamErrorBase): Deleted.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.

  • platform/network/SocketStreamErrorBase.cpp: Removed.
  • platform/network/SocketStreamErrorBase.h: Removed.
  • platform/network/cf/SocketStreamError.h: Removed.
  • platform/network/curl/SocketStreamError.h: Removed.
  • platform/network/soup/SocketStreamError.h: Removed.

Aug 15, 2016:

11:50 PM Changeset in webkit [204500] by rniwa@webkit.org
  • 19 edits
    8 adds in trunk

Conversion to sequence<T> is broken for iterable objects
​https://bugs.webkit.org/show_bug.cgi?id=160801

Reviewed by Darin Adler.

Source/JavaScriptCore:

Export functions used to iterate over iterable objects.

  • runtime/IteratorOperations.h:

(JSC::forEachInIterable):

Source/WebCore:

Added the proper iterator support for sequence<T> with one caveat that we don't check for RegExp object
per ​https://github.com/heycam/webidl/issues/145.

See ​http://heycam.github.io/webidl/#es-sequence and ​http://heycam.github.io/webidl/#es-overloads

Tests: bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl

  • bindings/js/JSDOMBinding.cpp:

(WebCore::hasIteratorMethod): Added. A helper function for checking whether a JSValue is iterable or not.

  • bindings/js/JSDOMBinding.h:

(WebCore::NativeValueTraits<unsigned>::nativeValue): Removed the check for isNumber to match the spec'ed
behavior at ​http://heycam.github.io/webidl/#es-unsigned-long which calls ToNumber first without checking
whether the value is a number or not.
(WebCore::toRefPtrNativeArray): Replaced isJSArray check by isObject check and throw a TypeError. Deployed
forEachInIterable to support non-JSArray iterable objects. Also removed the function pointer from the third
argument since we were always calling JSCT::toWrapped.
(WebCore::toNativeArray): Ditto.

  • bindings/js/JSDOMConvert.h:

(WebCore::Converter<Vector<T>>::convert): Removed the comment about toNativeArray not throwing when value
is not an object.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateOverloadedFunctionOrConstructor): Removed the check for isJSArray for sequence<T> as an iterable
object is not necessary a JSArray.
(WillConvertUndefinedToDefaultParameterValue): Don't return 1 for all sequences since toNativeArray and
toRefPtrNativeArray now throws on undefined due to isObject check.
(JSValueToNative): Removed the third argument from toRefPtrNativeArray.

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequence.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequence.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequencePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequenceIsEmpty):

  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: Added.
  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h: Added.
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionFunc):

  • bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl: Added.

LayoutTests:

Added test cases for converting non-JSArray objects to sequence<T> for MutationObserver, FontFaceSet, and WebSocket.

  • fast/dom/MutationObserver/observe-exceptions-expected.txt:
  • fast/dom/MutationObserver/observe-exceptions.html:
  • fast/text/font-face-set-javascript-expected.txt:
  • fast/text/font-face-set-javascript.html:
  • http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Rebaselined due to js-test-pre.js change.
  • http/tests/resources/js-test-pre.js: Merged ToT from resources/js-test-pre.js.
  • http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt: Rebaselined due to js-test-pre.js change.
  • http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt: Ditto.
  • http/tests/websocket/tests/hybi/websocket-constructor-protocols-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-constructor-protocols.html: Added.
11:48 PM Changeset in webkit [204499] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Rename RegisteredEventListener::listener() to callback() for clarity
​https://bugs.webkit.org/show_bug.cgi?id=160873

Reviewed by Darin Adler.

Rename RegisteredEventListener::listener() to callback() for clarity
and to match the specification:

Always calling listener->listener() seems wrong.

  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::getJSListenerFunctions):

  • dom/EventListenerMap.cpp:

(WebCore::findListener):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::getAttributeEventListener):
(WebCore::EventTarget::fireEventListeners):

  • dom/RegisteredEventListener.h:

(WebCore::RegisteredEventListener::callback):
(WebCore::RegisteredEventListener::RegisteredEventListener):
(WebCore::RegisteredEventListener::listener): Deleted.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListeners):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

11:41 PM Changeset in webkit [204498] by Simon Fraser
  • 2 edits in trunk/Tools

webkitpy error in TestRunResults.merge()
​https://bugs.webkit.org/show_bug.cgi?id=160882

Reviewed by Daniel Bates.

The argument to TestRunResults.merge() can be None if there are no device-specifc
initial results or retry results in Manager.run(), so just return early in that case.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.merge):

11:24 PM Changeset in webkit [204497] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Add support for dictionary members of non nullable wrapper types
​https://bugs.webkit.org/show_bug.cgi?id=160876

Reviewed by Darin Adler.

Add support for dictionary members of non nullable wrapper types. We
only supported nullable wrapper types as dictionary members so far.

No new tests, updated bindings tests.

  • bindings/js/JSDOMConvert.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionaryImplementationContent):
(GenerateParametersCheck):
(JSValueToNative):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldNotTolerateNull>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldTolerateNull>):
(WebCore::jsTestObjPrototypeFunctionAttachShadowRoot):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):

  • bindings/scripts/test/TestObj.idl:
10:14 PM Changeset in webkit [204496] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle
​https://bugs.webkit.org/show_bug.cgi?id=160856

Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Joseph Pecoraro.

  • UserInterface/Base/DOMUtilities.js:

(WebInspector.linkifyNodeReference):
Add option to truncate the text of the linkified node.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
Increase the max-height to partially show additional classes if many are set.

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
Trucate the name of inherited nodes so they don't take up as much space in the sidebar.

  • UserInterface/Views/VisualStyleSelectorSection.css:

(.details-section.visual-style-selector-section > .header > .current-selector): Deleted.
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles): Deleted.
Removed since they are already inherited.

9:17 PM Changeset in webkit [204495] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Regression 204203-204210] 32-bit ASSERTION FAILED: !m_data[index].name.isValid()
​https://bugs.webkit.org/show_bug.cgi?id=160881

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-08-15
Reviewed by Mark Lam.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
We were trying to set the result of the Identity node to the same
value as the source of the Identity.
That is pretty messed up.

8:32 PM Changeset in webkit [204494] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Drop unused EventTarget::hasActiveEventListeners()
​https://bugs.webkit.org/show_bug.cgi?id=160869

Reviewed by Alex Christensen.

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::containsActive): Deleted.

  • dom/EventListenerMap.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::hasActiveEventListeners): Deleted.

  • dom/EventTarget.h:
7:27 PM Changeset in webkit [204493] by commit-queue@webkit.org
  • 12 edits in trunk

Speed up compile times by not including wtf/Variant.h so much
​https://bugs.webkit.org/show_bug.cgi?id=160847

Patch by Sam Weinig <​sam@webkit.org> on 2016-08-15
Reviewed by Alex Christensen and Saam Barati.

Source/WebCore:

"using std::experimental::variant" caused internal compiler errors in MSVC2015,
so we are just writing std::experimental where we use it for now.
We should move variant into the std::experimental namespace.

  • bindings/js/JSNodeOrString.cpp:

(WebCore::toNodeOrStringVector):

  • bindings/js/JSNodeOrString.h:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childElementCount):
(WebCore::ContainerNode::append):
(WebCore::ContainerNode::prepend):

  • dom/ContainerNode.h:
  • dom/Node.cpp:

(WebCore::Node::appendChild):
(WebCore::nodeSetPreTransformedFromNodeOrStringVector):
(WebCore::firstFollowingSiblingNotInNodeSet):
(WebCore::Node::convertNodesOrStringsIntoNode):
(WebCore::Node::before):
(WebCore::Node::after):
(WebCore::Node::replaceWith):

  • dom/Node.h:

(WebCore::Node::setStyleChange):
(WebCore::Node::customPseudoId):

Source/WTF:

  • wtf/Forward.h:

Add forward declaration of std::variant.

  • wtf/StdLibExtras.h:

Remove references to std::variant. Move them to wtf/Variant.h

Tools:

  • TestWebKitAPI/Tests/WTF/Variant.cpp:

(TestWebKitAPI::TEST):
Explicitly use std::experimental::variant.

7:06 PM Changeset in webkit [204492] by dbates@webkit.org
  • 5 edits
    5 adds in trunk

ASSERTION FAILURE: [[videoLayer delegate] isKindOfClass:getUIViewClass()] in WebAVPlayerLayerView_videoView()
​https://bugs.webkit.org/show_bug.cgi?id=160433

Reviewed by Eric Carlson.

Source/WebCore:

Early return from WebAVPlayerLayerView_videoView() if the PiP layer does not have a non-nil delegate view.

Test: media/controls/close-page-with-picture-in-picture-video-assertion-failure.html

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebAVPlayerLayerView_videoView):

LayoutTests:

Add a layout test to ensure that we do not cause an assertion failure when exiting PiP by closing the tab.

  • TestExpectations: Skip media/control/ipad tests on all ports. We will re-enable these tests for iOS.
  • media/controls/close-page-with-picture-in-picture-video-assertion-failure-expected.txt: Added.
  • media/controls/close-page-with-picture-in-picture-video-assertion-failure.html: Added.
  • media/controls/resources/picture-in-picture.html: Added.
  • platform/ios-simulator/TestExpectations: Mark tests media/control/ipad as Pass so that we run them

in the iPad simulator.

6:43 PM Changeset in webkit [204491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Close button on selected item in Network tab is misaligned
​https://bugs.webkit.org/show_bug.cgi?id=160884

Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Matt Baker.

  • UserInterface/Views/NetworkSidebarPanel.css:

(.sidebar > .panel.navigation.network .status .close.status-button):

6:34 PM Changeset in webkit [204490] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Error/Warning icons are misplaced in the Visual sidebar
​https://bugs.webkit.org/show_bug.cgi?id=160875

Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Matt Baker.

  • UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:

(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder): Deleted.
Reworked to apply more generally to editors without titles.

  • UserInterface/Views/VisualStylePropertyEditor.css:

(.visual-style-property-container.missing-dependency > .visual-style-property-editor-warning):
(.visual-style-property-container.invalid-value > .visual-style-property-editor-warning):
(.visual-style-property-container:matches(.missing-dependency, .invalid-value) > *:first-child:matches(.visual-style-property-value-container)):
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container) > .visual-style-special-property-placeholder):
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency): Deleted.
(.visual-style-property-container > .visual-style-property-editor-warning.invalid-value): Deleted.
Reworked class names to be on the element container instead of the icon.

  • UserInterface/Views/VisualStylePropertyEditor.js:

(WebInspector.VisualStylePropertyEditor.prototype.update):
(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):

4:32 PM Changeset in webkit [204489] by sbarati@apple.com
  • 7 edits in trunk/Source

Web Inspector: Introduce a method to enable code coverage profiler without enabling type profiler
​https://bugs.webkit.org/show_bug.cgi?id=160750
<rdar://problem/27793469>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::disableTypeProfiler):
(Inspector::InspectorRuntimeAgent::enableControlFlowProfiler):
(Inspector::InspectorRuntimeAgent::disableControlFlowProfiler):
(Inspector::InspectorRuntimeAgent::setTypeProfilerEnabledState):
(Inspector::InspectorRuntimeAgent::setControlFlowProfilerEnabledState):

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/protocol/Runtime.json:

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector.loaded):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):

4:31 PM Changeset in webkit [204488] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array.prototype.map builtin should go on the fast path when constructor===@Array
​https://bugs.webkit.org/show_bug.cgi?id=160836

Reviewed by Keith Miller.

In the FTL, we were not compiling the result array in Array.prototype.map
efficiently when the result array should use the Array constructor
(which is the common case). We used to compile it as:
x: JSConstant(Array)
y: Construct(@x, ...)
instead of
y: NewArrayWithSize(...)

This patch changes the builtin to go down the fast path when certain
conditions are met. Often, the check to go down the fast path will
be constant folded because we always create a normal array from the
Array constructor.

This is around a 5% speedup on ES6 Sample Bench.

I also made similar changes for Array.prototype.filter
and Array.prototype.concat on its slow path.

  • builtins/ArrayPrototype.js:
3:43 PM Changeset in webkit [204487] by Ryan Haddad
  • 2 edits
    1 add in branches/safari-602-branch/LayoutTests

Test gardening for rdar://problem/27595142.

3:42 PM Changeset in webkit [204486] by keith_miller@apple.com
  • 8 edits
    27545 adds
    1 delete in branches/safari-602.1.50.1-branch

Merge r203972.

2016-08-01 Keith Miller <​keith_miller@apple.com>

We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
​https://bugs.webkit.org/show_bug.cgi?id=160372

Rubber stamped by Geoffrey Garen.

This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.

  • JSTests/: Copied from Source/JavaScriptCore/tests.
  • Source/JavaScriptCore/tests/: Deleted.
  • Scripts/import-test262-tests:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-res:
2:52 PM Changeset in webkit [204485] by mark.lam@apple.com
  • 7 edits
    1 add in trunk/Source/JavaScriptCore

Make JSValue::strictEqual() handle failures to resolve JSRopeStrings.
​https://bugs.webkit.org/show_bug.cgi?id=160832
<rdar://problem/27577556>

Reviewed by Geoffrey Garen.

Currently, JSValue::strictEqualSlowCaseInline() (and peers) will blindly try to
access the StringImpl of a JSRopeString that fails to resolve its rope. As a
result, we'll crash with null pointer dereferences.

We can fix this by introducing a JSString::equal() method that will do the
equality comparison, but is aware of the potential failures to resolve ropes.
JSValue::strictEqualSlowCaseInline() (and peers) will now call JSString::equal()
instead of accessing the underlying StringImpl directly.

Also added some exception checks.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITOperations.cpp:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):

  • runtime/JSString.cpp:

(JSC::JSString::equalSlowCase):

  • runtime/JSString.h:
  • runtime/JSStringInlines.h: Added.

(JSC::JSString::equal):

2:35 PM Changeset in webkit [204484] by keith_miller@apple.com
  • 8 edits
    7 copies
    4 adds in trunk/Source

Implement WASM Parser and B3 IR generator
​https://bugs.webkit.org/show_bug.cgi?id=160681

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

This patch adds the skeleton for a WebAssembly pipeline. The
pipeline is designed in order to make it easy to have as much of
the compilation process threaded as possible. The flow of the
pipeline roughly goes as follows:

1) Create a WASMPlan with the VM and a Vector of the
assembly. Currently the plan will process all the work
synchronously, however, in the future this can be offloaded to
other threads.

2) The plan will run the WASMModuleParser, which collates all the
information needed to compile each module function
independently. Since, we are still in the early phases, the only
information is the starting and ending byte of the function's
body. The module parser, however, still scans both and
semi-validates the type and the function sections.

3) Each function is decoded and compiled. In the future this
should also include a opcode validation phase. The
WASMFunctionParser is templatized so that a validator should be
able to use most of the same code the B3 IR generator does.

4) When the plan has finished it will fill a Vector of
B3::Compilation objects that correspond to the respective function
in the WASM module.

The current testing plan for the modules is to inline the the
binary generated by the spec's OCaml prototype. The inlined binary
is passed to a WASMPlan then invoked to check the result of the
function. In the future we should add a more robust testing
infrastructure.

(printUsageStatement):
(CommandLine::parseArguments):
(invoke):
(runWASMTests):
(main):

  • wasm/JSWASMModule.h:

(JSC::JSWASMModule::globalVariableTypes):

  • wasm/WASMB3IRGenerator.cpp: Added.

(JSC::WASM::B3IRGenerator::B3IRGenerator):
(JSC::WASM::B3IRGenerator::addLocal):
(JSC::WASM::B3IRGenerator::binaryOp):
(JSC::WASM::B3IRGenerator::addConstant):
(JSC::WASM::B3IRGenerator::addBlock):
(JSC::WASM::B3IRGenerator::endBlock):
(JSC::WASM::B3IRGenerator::addReturn):
(JSC::WASM::B3IRGenerator::unify):
(JSC::WASM::B3IRGenerator::initializeIncommingTypes):
(JSC::WASM::B3IRGenerator::unifyValuesWithLevel):
(JSC::WASM::B3IRGenerator::stackForControlLevel):
(JSC::WASM::B3IRGenerator::blockForControlLevel):
(JSC::WASM::parseAndCompile):

  • wasm/WASMB3IRGenerator.h: Copied from Source/WTF/wtf/DataLog.h.
  • wasm/WASMFormat.h:
  • wasm/WASMFunctionParser.h: Added.

(JSC::WASM::WASMFunctionParser<Context>::WASMFunctionParser):
(JSC::WASM::WASMFunctionParser<Context>::parse):
(JSC::WASM::WASMFunctionParser<Context>::parseBlock):
(JSC::WASM::WASMFunctionParser<Context>::parseExpression):

  • wasm/WASMModuleParser.cpp: Added.

(JSC::WASM::WASMModuleParser::parse):
(JSC::WASM::WASMModuleParser::parseFunctionTypes):
(JSC::WASM::WASMModuleParser::parseFunctionSignatures):
(JSC::WASM::WASMModuleParser::parseFunctionDefinitions):

  • wasm/WASMModuleParser.h: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::WASMModuleParser::WASMModuleParser):
(JSC::WASM::WASMModuleParser::functionInformation):

  • wasm/WASMOps.h: Copied from Source/WTF/wtf/DataLog.h.
  • wasm/WASMParser.h: Added.

(JSC::WASM::WASMParser::parseVarUInt32):
(JSC::WASM::WASMParser::WASMParser):
(JSC::WASM::WASMParser::consumeCharacter):
(JSC::WASM::WASMParser::consumeString):
(JSC::WASM::WASMParser::parseUInt32):
(JSC::WASM::WASMParser::parseUInt7):
(JSC::WASM::WASMParser::parseVarUInt1):
(JSC::WASM::WASMParser::parseValueType):

  • wasm/WASMPlan.cpp: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::Plan::Plan):

  • wasm/WASMPlan.h: Copied from Source/WTF/wtf/DataLog.h.
  • wasm/WASMSections.cpp: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::WASMSections::lookup):

  • wasm/WASMSections.h: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::WASMSections::validateOrder):

Source/WTF:

  • wtf/DataLog.h:

(WTF::dataLogLn): Add a new dataLog function, dataLogLn that
automagically includes a new line at the end of the print.

  • wtf/LEBDecoder.h:

(decodeUInt32):
(decodeInt32): Change the LEBDecoder to take a pointer and length
rather than a Vector.

2:23 PM Changeset in webkit [204483] by achristensen@apple.com
  • 12 edits
    8 moves in trunk/Source

Rename SocketStreamHandleBase to SocketStreamHandle and SocketStreamHandle to SocketStreamHandleImpl
​https://bugs.webkit.org/show_bug.cgi?id=160858

Reviewed by Brady Eidson.

Source/WebCore:

No new tests. No change in behavior, except GTK's SocketStreamHandleImpl is now safely ThreadSafeRefCounted.
This is preparation for making a new kind of SocketStreamHandle which is a proxy that communicates with the NetworkProcess in WebKit2.

  • CMakeLists.txt:
  • PlatformAppleWin.cmake:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • PlatformWinCairo.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • page/SocketProvider.cpp:

(WebCore::SocketProvider::createSocketStreamHandle):

  • platform/network/SocketStreamHandle.cpp: Copied from Source/WebCore/platform/network/SocketStreamHandleBase.cpp.

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::state):
(WebCore::SocketStreamHandle::send):
(WebCore::SocketStreamHandle::close):
(WebCore::SocketStreamHandle::disconnect):
(WebCore::SocketStreamHandle::sendPendingData):
(WebCore::SocketStreamHandleBase::SocketStreamHandleBase): Deleted.
(WebCore::SocketStreamHandleBase::state): Deleted.
(WebCore::SocketStreamHandleBase::send): Deleted.
(WebCore::SocketStreamHandleBase::close): Deleted.
(WebCore::SocketStreamHandleBase::disconnect): Deleted.
(WebCore::SocketStreamHandleBase::sendPendingData): Deleted.

  • platform/network/SocketStreamHandle.h: Copied from Source/WebCore/platform/network/SocketStreamHandleBase.h.

(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::client):
(WebCore::SocketStreamHandleBase::~SocketStreamHandleBase): Deleted.
(WebCore::SocketStreamHandleBase::client): Deleted.

  • platform/network/SocketStreamHandleBase.cpp: Removed.
  • platform/network/SocketStreamHandleBase.h: Removed.
  • platform/network/cf/SocketStreamHandle.h: Removed.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: Removed.
  • platform/network/cf/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/cf/SocketStreamHandle.h.

(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandle::create): Deleted.

  • platform/network/cf/SocketStreamHandleImplCFNet.cpp: Copied from Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp.

(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::scheduleStreams):
(WebCore::SocketStreamHandleImpl::retainSocketStreamHandle):
(WebCore::SocketStreamHandleImpl::releaseSocketStreamHandle):
(WebCore::SocketStreamHandleImpl::copyPACExecutionDescription):
(WebCore::SocketStreamHandleImpl::pacExecutionCallback):
(WebCore::SocketStreamHandleImpl::executePACFileURL):
(WebCore::SocketStreamHandleImpl::removePACRunLoopSource):
(WebCore::SocketStreamHandleImpl::chooseProxy):
(WebCore::SocketStreamHandleImpl::chooseProxyFromArray):
(WebCore::SocketStreamHandleImpl::createStreams):
(WebCore::SocketStreamHandleImpl::getStoredCONNECTProxyCredentials):
(WebCore::authenticationSchemeFromAuthenticationMethod):
(WebCore::SocketStreamHandleImpl::addCONNECTCredentials):
(WebCore::SocketStreamHandleImpl::copyCFStreamDescription):
(WebCore::SocketStreamHandleImpl::readStreamCallback):
(WebCore::SocketStreamHandleImpl::writeStreamCallback):
(WebCore::SocketStreamHandleImpl::reportErrorToClient):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::port):
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::scheduleStreams): Deleted.
(WebCore::SocketStreamHandle::retainSocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::releaseSocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::copyPACExecutionDescription): Deleted.
(WebCore::SocketStreamHandle::pacExecutionCallback): Deleted.
(WebCore::SocketStreamHandle::executePACFileURL): Deleted.
(WebCore::SocketStreamHandle::removePACRunLoopSource): Deleted.
(WebCore::SocketStreamHandle::chooseProxy): Deleted.
(WebCore::SocketStreamHandle::chooseProxyFromArray): Deleted.
(WebCore::SocketStreamHandle::createStreams): Deleted.
(WebCore::SocketStreamHandle::getStoredCONNECTProxyCredentials): Deleted.
(WebCore::SocketStreamHandle::addCONNECTCredentials): Deleted.
(WebCore::SocketStreamHandle::copyCFStreamDescription): Deleted.
(WebCore::SocketStreamHandle::readStreamCallback): Deleted.
(WebCore::SocketStreamHandle::writeStreamCallback): Deleted.
(WebCore::SocketStreamHandle::reportErrorToClient): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::port): Deleted.

  • platform/network/curl/SocketStreamHandle.h: Removed.
  • platform/network/curl/SocketStreamHandleCurl.cpp: Removed.
  • platform/network/curl/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/curl/SocketStreamHandle.h.

(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandle::create): Deleted.

  • platform/network/curl/SocketStreamHandleImplCurl.cpp: Copied from Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp.

(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::readData):
(WebCore::SocketStreamHandleImpl::sendData):
(WebCore::SocketStreamHandleImpl::waitForAvailableData):
(WebCore::SocketStreamHandleImpl::startThread):
(WebCore::SocketStreamHandleImpl::stopThread):
(WebCore::SocketStreamHandleImpl::didReceiveData):
(WebCore::SocketStreamHandleImpl::didOpenSocket):
(WebCore::SocketStreamHandleImpl::createCopy):
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::readData): Deleted.
(WebCore::SocketStreamHandle::sendData): Deleted.
(WebCore::SocketStreamHandle::waitForAvailableData): Deleted.
(WebCore::SocketStreamHandle::startThread): Deleted.
(WebCore::SocketStreamHandle::stopThread): Deleted.
(WebCore::SocketStreamHandle::didReceiveData): Deleted.
(WebCore::SocketStreamHandle::didOpenSocket): Deleted.
(WebCore::SocketStreamHandle::createCopy): Deleted.

  • platform/network/soup/SocketStreamHandle.h: Removed.
  • platform/network/soup/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/soup/SocketStreamHandle.h.
  • platform/network/soup/SocketStreamHandleImplSoup.cpp: Copied from Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp.

(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::connected):
(WebCore::SocketStreamHandleImpl::connectedCallback):
(WebCore::SocketStreamHandleImpl::readBytes):
(WebCore::SocketStreamHandleImpl::readReadyCallback):
(WebCore::SocketStreamHandleImpl::didFail):
(WebCore::SocketStreamHandleImpl::writeReady):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandleImpl::stopWaitingForSocketWritability):
(WebCore::SocketStreamHandleImpl::writeReadyCallback):
(WebCore::SocketStreamHandle::create): Deleted.
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::connected): Deleted.
(WebCore::SocketStreamHandle::connectedCallback): Deleted.
(WebCore::SocketStreamHandle::readBytes): Deleted.
(WebCore::SocketStreamHandle::readReadyCallback): Deleted.
(WebCore::SocketStreamHandle::didFail): Deleted.
(WebCore::SocketStreamHandle::writeReady): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Deleted.
(WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Deleted.
(WebCore::SocketStreamHandle::writeReadyCallback): Deleted.

  • platform/network/soup/SocketStreamHandleSoup.cpp: Removed.

Source/WebKit2:

  • WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

2:11 PM Changeset in webkit [204482] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Another build fix.

  • WebKit.exp:
2:08 PM Changeset in webkit [204481] by jiewen_tan@apple.com
  • 22 edits
    2 copies
    17 adds in trunk

Expose crypto.getRandomValues to Web Workers
​https://bugs.webkit.org/show_bug.cgi?id=104851
<rdar://problem/27285714>

Reviewed by Darin Adler.

Source/WebCore:

Tests: crypto/webkitSubtle/disallowed-in-worker.html

crypto/workers/crypto-gc-worker.html
crypto/workers/crypto-random-values-limits-worker.html
crypto/workers/crypto-random-values-types-worker.html
crypto/workers/crypto-random-values-worker.html

Expose both crypto and crypto.getRandomValues to Web Workers. However, webkitSubtle is
disabled in Web Workers. This change also refactors a bit on IDLs related to Crypto
interface.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

Introduce GlobalCrypto Interface which is used to repalace the partial IDL in both
DOMWindow and WorkerGlobalScope with sub-implememtations.

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::visitAdditionalChildren):

  • bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::visitAdditionalChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • dom/Document.idl:

Add support of GenerateIsReachable=ImplScriptExecutionContext, which allow registered
JS Objects to live as long as ScriptExecutionContext lives, i.e. Document and
WorkerGlobalScope.

  • page/Crypto.cpp:

(WebCore::Crypto::Crypto):
(WebCore::Crypto::webkitSubtle):
(WebCore::Crypto::document): Deleted.

  • page/Crypto.h:

(WebCore::Crypto::create):

  • page/Crypto.idl:

Change the opaque root of Crypto to ScriptExecutionContext such that it perserves
the same live time in both Window and Web Worker. And disable WebKitSubtle in Web
Workers.

  • page/DOMWindow.idl:
  • page/GlobalCrypto.idl: Added.

Replace partial IDL to sub-implementation of crypto attribute.

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::crypto):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerGlobalScope.idl:

Introduce crypto attribute to Web Workers.

LayoutTests:

  • crypto/crypto-random-values-limits.html:
  • crypto/crypto-random-values-types.html:
  • crypto/crypto-random-values.html:
  • crypto/webkitSubtle/disallowed-in-worker-expected.txt: Added.
  • crypto/webkitSubtle/disallowed-in-worker.html: Added.
  • crypto/webkitSubtle/resources/disallowed-in-worker.js: Added.
  • crypto/workers/crypto-gc-worker-expected.txt: Added.
  • crypto/workers/crypto-gc-worker.html: Added.
  • crypto/workers/crypto-random-values-limits-worker-expected.txt: Added.
  • crypto/workers/crypto-random-values-limits-worker.html: Added.
  • crypto/workers/crypto-random-values-types-worker-expected.txt: Added.
  • crypto/workers/crypto-random-values-types-worker.html: Added.
  • crypto/workers/crypto-random-values-worker-expected.txt: Added.
  • crypto/workers/crypto-random-values-worker.html: Added.
  • crypto/workers/resources/crypto-gc-worker.js: Added.

(startTest):
(continueTest):
(finishTest):

  • crypto/workers/resources/crypto-random-limits-worker.js: Added.

(catch):

  • crypto/workers/resources/crypto-random-values-types-worker.js: Copied from LayoutTests/crypto/crypto-random-values-types.html.

(checkIntegerTypes):
(checkNonIntegerTypes):

  • crypto/workers/resources/crypto-random-values-worker.js: Copied from LayoutTests/crypto/crypto-random-values.html.

(catch):

  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
2:04 PM Changeset in webkit [204480] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

[JSC] B3 Neg opcode should support float
​https://bugs.webkit.org/show_bug.cgi?id=160795

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-08-15
Reviewed by Geoffrey Garen.

This is required to implement WASM f32.neg opcode.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::negateFloat):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

  • b3/B3ReduceDoubleToFloat.cpp:
  • b3/air/AirOpcode.opcodes:
  • b3/testb3.cpp:

(JSC::B3::testNegDouble):
(JSC::B3::testNegFloat):
(JSC::B3::testNegFloatWithUselessDoubleConversion):
(JSC::B3::run):

1:55 PM Changeset in webkit [204479] by commit-queue@webkit.org
  • 96 edits in trunk/Source

Use #pragma once in inspector headers
​https://bugs.webkit.org/show_bug.cgi?id=160861

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-15
Reviewed by Mark Lam.

  • inspector/*.h:
1:51 PM Changeset in webkit [204478] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix build.

  • Configurations/WebKitLegacy.xcconfig:
  • WebKit.mac.exp:
1:50 PM Changeset in webkit [204477] by Simon Fraser
  • 13 edits in trunk/Tools

Allow a port to run tests with a custom device setup
​https://bugs.webkit.org/show_bug.cgi?id=160833

Reviewed by Daniel Bates.

These changes allow the IOSSimulator port to run tests in iPad mode.

This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
in this case 'ipad'. When specified, any test in a directory with a suffix that matches
a custom device will be collected into a set, and run in that device's environment after
the other tests have run.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._custom_device_for_test): If the test contains a directory matching a
custom device suffix, return that custom device.
(Manager._set_up_run): Push the custom device class, if any, into options so
that the Worker can get to it.
(Manager.run): Go through the list of tests, and break it down into device-generic
tests, and tests for each device class. _run_test_subset is then called for
each collection of tests, and the results merged.
(Manager._run_test_subset): Some lines unwrapped.
(Manager._end_test_run):
(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init): Unwrapped a line.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.merge): Add this function to merge TestRunResults

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_workers_and_shards): Print the custom device, if any.

  • Scripts/webkitpy/port/base.py:

(Port): Base port has empty array of custom devices.
(Port.setup_test_run): Add device_class argument.

  • Scripts/webkitpy/port/driver.py:

(DriverInput.repr):
(Driver.check_driver.implementation):

  • Scripts/webkitpy/port/efl.py:

(EflPort.setup_test_run):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_test_run):

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
(IOSSimulatorPort.init):
(IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
based on the custom device class.
(IOSSimulatorPort._set_device_class):
(IOSSimulatorPort._create_simulators): Factor some code into this function.
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort.testing_device):
(IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
seemed wrong for this function. That was moved to setup_test_run().
(IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
but this happened too early, before we knew which kind of devices to create. Devices
are now created in setup_test_run().

  • Scripts/webkitpy/port/win.py:

(WinPort.setup_test_run):

1:45 PM Changeset in webkit [204476] by andersca@apple.com
  • 3 edits
    1 delete in trunk/Source/WebKit

Remove OldWebAssertions.c
​https://bugs.webkit.org/show_bug.cgi?id=160862

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.

  • Misc/OldWebAssertions.c: Removed.

(WebReportAssertionFailure): Deleted.
(WebReportError): Deleted.

1:40 PM Changeset in webkit [204475] by keith_miller@apple.com
  • 8 edits
    27545 adds
    1 delete in branches/safari-602.1.50.0-branch

Merge r203972.

2016-08-01 Keith Miller <​keith_miller@apple.com>

We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
​https://bugs.webkit.org/show_bug.cgi?id=160372

Rubber stamped by Geoffrey Garen.

This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.

  • JSTests/: Copied from Source/JavaScriptCore/tests.
  • Source/JavaScriptCore/tests/: Deleted.
  • Scripts/import-test262-tests:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-res:
12:16 PM Changeset in webkit [204474] by andersca@apple.com
  • 4 edits
    2 deletes in trunk/Source/WebKit

Remove WebKeyGenerator
​https://bugs.webkit.org/show_bug.cgi?id=160854

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

This SPI class is no longer used by Safari.

  • WebCoreSupport/WebKeyGenerator.h: Removed.
  • WebCoreSupport/WebKeyGenerator.mm: Removed.

(+[WebKeyGenerator sharedGenerator]): Deleted.
(toWebCertificateParseResult): Deleted.
(-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.

  • WebView/WebFrameView.mm:
12:11 PM Changeset in webkit [204473] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix iOS build.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

11:59 AM Changeset in webkit [204472] by Keith Rollin
  • 23 edits in trunk/Source

Rename LOG_ALWAYS
​https://bugs.webkit.org/show_bug.cgi?id=160768

Rename LOG_ALWAYS and friends, given that the first parameter to it is
a boolean expression that determines whether or not logging should be
performed.

Reviewed by Chris Dumez.

Source/WebCore:

No new tests. No new functionality is added. Only some macro names
have been changed.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::ReliefLogger::logMemoryUsageChange):

  • platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::IOSurface):

Source/WebKit2:

  • NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::didReceiveResponse):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::cancelPrepareToSuspend):
(WebKit::NetworkProcess::processDidResume):

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::continueWillSendRequest):

  • Platform/IPC/Connection.cpp:

(IPC::Connection::waitForSyncReply):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles):

  • UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::updateAssertionNow):
(WebKit::ProcessThrottler::updateAssertion):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateActivityToken):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::WebProcessProxy::didSetAssertionState):
(WebKit::WebProcessProxy::setIsHoldingLockedFiles):

  • UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
(WebKit::ProcessAssertion::ProcessAssertion):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didReceiveResource):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::layerVolatilityTimerFired):
(WebKit::WebPage::markLayersVolatile):
(WebKit::WebPage::cancelMarkLayersVolatile):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::processWillSuspendImminently):
(WebKit::WebProcess::prepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::processDidResume):

Source/WTF:

  • wtf/Assertions.h:
11:57 AM Changeset in webkit [204471] by dbates@webkit.org
  • 12 edits
    24 adds in trunk

Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
private frameworks and libraries
​https://bugs.webkit.org/show_bug.cgi?id=155931
<rdar://problem/25807989>

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/Base.xcconfig:

Source/WebCore:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/BaseTarget.xcconfig:

Tools:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:

WebKitLibraries:

Add text-based stubs for private frameworks in iOS 9 and iOS 10 beta.

  • WebKitPrivateFrameworkStubs: Added.
  • WebKitPrivateFrameworkStubs/iOS: Added.
  • WebKitPrivateFrameworkStubs/iOS/10: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AppSupport.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AppSupport.framework/AppSupport.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AssertionServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AssertionServices.framework/AssertionServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/CorePDF.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/CorePDF.framework/CorePDF.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/GraphicsServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/GraphicsServices.framework/GraphicsServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/IOSurface.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/IOSurface.framework/IOSurface.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AppSupport.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AppSupport.framework/AppSupport.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AssertionServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AssertionServices.framework/AssertionServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/CorePDF.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/CorePDF.framework/CorePDF.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/GraphicsServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/GraphicsServices.framework/GraphicsServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/IOSurface.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/IOSurface.framework/IOSurface.tbd: Added.
11:48 AM Changeset in webkit [204470] by Joseph Pecoraro
  • 27 edits in trunk/Source/JavaScriptCore

Reduce includes of Debugger.h
​https://bugs.webkit.org/show_bug.cgi?id=160827

Reviewed by Mark Lam.

  • API/JSTypedArray.cpp:
  • bytecode/UnlinkedCodeBlock.h:
  • bytecode/UnlinkedFunctionExecutable.cpp:
  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:
  • dfg/DFGPlan.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • ftl/FTLJITCode.h:
  • inspector/ScriptCallStackFactory.cpp:
  • inspector/agents/InspectorDebuggerAgent.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITOperations.cpp:
  • llint/LLIntOffsetsExtractor.cpp:
  • parser/Nodes.cpp:
  • parser/Parser.cpp:
  • parser/Parser.h:
  • runtime/Completion.cpp:
  • runtime/Executable.cpp:
  • runtime/Executable.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/SamplingProfiler.cpp:
  • runtime/SamplingProfiler.h:
  • runtime/VMEntryScope.cpp:
11:16 AM Changeset in webkit [204469] by Simon Fraser
  • 17 edits in trunk

Add a setting and preferences to enable visual viewport mode
​https://bugs.webkit.org/show_bug.cgi?id=160843

Reviewed by Sam Weinig.
Source/WebCore:

Add a visualViewportEnabled setting, in the start of a group at the bottom
of the file which is intended as the future home for all runtime-enabled
settings.

  • page/Settings.in:

Source/WebKit/mac:

Hook up the visualViewportEnabled setting for WebKit1.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences visualViewportEnabled]):
(-[WebPreferences setVisualViewportEnabled:]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Hook up the visualViewportEnabled setting for WebKit2.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _visualViewportEnabled]):
(-[WKPreferences _setVisualViewportEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.

  • MiniBrowser/mac/SettingsController.h:
  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController visualViewportEnabled]):
(-[SettingsController toggleVisualViewportEnabled:]):

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]):

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]):

10:53 AM Changeset in webkit [204468] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WinCairo build after r204466.

  • platform/network/curl/SocketStreamHandleCurl.cpp:
10:37 AM Changeset in webkit [204467] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix GTK build after r204466.

  • platform/gtk/DataObjectGtk.h:
10:21 AM Changeset in webkit [204466] by achristensen@apple.com
  • 519 edits in trunk/Source

Remove unused includes of wtf headers
​https://bugs.webkit.org/show_bug.cgi?id=160839

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-15
Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • Lots of files.

Source/WebCore:

  • Lots of files.

Source/WebKit:

  • Storage/StorageSyncManager.h:
  • Storage/StorageThread.cpp:
  • Storage/StorageThread.h:
  • Storage/WebDatabaseProvider.cpp:

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/ios:

  • Misc/WebGeolocationCoreLocationProvider.h:
  • WebView/WebPDFViewIOS.mm:
  • WebView/WebPlainWhiteView.mm:

Source/WebKit/mac:

  • History/BinaryPropertyList.cpp:
  • History/WebBackForwardList.mm:
  • History/WebHistoryItemInternal.h:
  • Misc/WebNSFileManagerExtras.mm:
  • Plugins/Hosted/NetscapePluginHostProxy.h:
  • WebCoreSupport/WebPlatformStrategies.mm:
  • WebCoreSupport/WebSelectionServiceController.mm:
  • WebCoreSupport/WebUserMediaClient.h:

Source/WebKit/win:

  • WebFrame.h:

Source/WebKit2:

  • Lots of files.

Source/WTF:

  • wtf/BackwardsGraph.h:
  • wtf/DataLog.cpp:
  • wtf/WorkQueue.cpp:
  • wtf/text/StringImpl.cpp:
  • wtf/unicode/icu/CollatorICU.cpp:
10:15 AM Changeset in webkit [204465] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

Remove unused WebSocketChannel::willOpenSocketStream
​https://bugs.webkit.org/show_bug.cgi?id=160851

Reviewed by Daniel Bates.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::willOpenSocketStream): Deleted.

  • Modules/websockets/WebSocketChannel.h:
  • platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::willOpenSocketStream): Deleted.

10:14 AM Changeset in webkit [204464] by Ryan Haddad
  • 2 edits in trunk/JSTests

Skip failing test mozilla/ecma/LexicalConventions/7.7.3.js
​https://bugs.webkit.org/show_bug.cgi?id=160662

Unreviewed test gardening.

  • mozilla/ecma/LexicalConventions/7.7.3.js:
9:53 AM Changeset in webkit [204463] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for mac-wk1, mark as failing on Yosemite.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
9:43 AM Changeset in webkit [204462] by andersca@apple.com
  • 9 edits
    3 copies
    4 adds in trunk/Source

Move the plug-in and WebGL blacklist code to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=160831

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/BlacklistUpdater.h: Added.

(WebCore::BlacklistUpdater::queue):
(WebCore::BlacklistUpdater::pluginBlacklist):
(WebCore::BlacklistUpdater::webGLBlacklist):

  • platform/mac/BlacklistUpdater.mm: Added.

(WebCore::BlacklistUpdater::readBlacklistData):
(WebCore::BlacklistUpdater::reloadIfNecessary):
(WebCore::BlacklistUpdater::initializeQueue):

  • platform/mac/PluginBlacklist.h: Added.
  • platform/mac/PluginBlacklist.mm: Added.

(WebCore::PluginBlacklist::loadPolicyForPluginVersion):
(WebCore::PluginBlacklist::isPluginUpdateAvailable):
(WebCore::PluginBlacklist::create):
(WebCore::PluginBlacklist::~PluginBlacklist):
(WebCore::PluginBlacklist::splitOSVersion):
(WebCore::PluginBlacklist::loadPolicyForPlugin):
(WebCore::PluginBlacklist::isUpdateAvailable):
(WebCore::PluginBlacklist::PluginBlacklist):

  • platform/mac/WebGLBlacklist.h: Added.
  • platform/mac/WebGLBlacklist.mm: Added.

(WebCore::OSBuildInfo::OSBuildInfo):
(WebCore::OSBuildInfo::operator==):
(WebCore::OSBuildInfo::operator>):
(WebCore::OSBuildInfo::operator<=):
(WebCore::OSBuildInfo::operator<):
(WebCore::buildInfoFromOSBuildString):
(WebCore::WebGLBlacklist::shouldBlockWebGL):
(WebCore::WebGLBlacklist::shouldSuggestBlockingWebGL):
(WebCore::matchesGPU):
(WebCore::gpuMaskFromString):
(WebCore::matchesBuildInfo):
(WebCore::WebGLBlacklist::create):
(WebCore::WebGLBlacklist::shouldBlock):
(WebCore::WebGLBlacklist::shouldSuggestBlocking):
(WebCore::WebGLBlacklist::WebGLBlacklist):
(WebCore::WebGLBlacklist::~WebGLBlacklist):

  • platform/spi/cf/CFUtilitiesSPI.h: Added.

Source/WebKit/mac:

Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(shouldBlockPlugin):
(WebFrameLoaderClient::createPlugin):
(WebFrameLoaderClient::createJavaAppletWidget):
(shouldBlockWebGL):
(WebFrameLoaderClient::webGLPolicyForURL):
(WebFrameLoaderClient::resolveWebGLPolicyForURL):

Source/WebKit2:

Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.

  • Shared/Plugins/Netscape/mac/PluginInformationMac.mm:

(WebKit::getPlatformPluginModuleInformation):

  • Shared/Plugins/PluginModuleInfo.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextIsPlugInUpdateAvailable):
(WKContextShouldBlockWebGL):
(WKContextShouldSuggestBlockWebGL):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::shouldBlockPlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
(WebKit::WKPlugInModuleLoadPolicyToPluginModuleLoadPolicy): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

9:10 AM Changeset in webkit [204461] by Brent Fulgham
  • 2 edits
    1 add in trunk/Source/WebKit2

Add Sandbox profile for Enterprise support version of Flash Player
​https://bugs.webkit.org/show_bug.cgi?id=160753
<rdar://problem/17614483>

Reviewed by Andy Estes.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player ESR.plugin.sb: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add reference to new sandbox profile.
2:56 AM Changeset in webkit [204460] by Konstantin Tokarev
  • 2 edits in trunk/Tools

Allow using make-dist with non-GTK ports
​https://bugs.webkit.org/show_bug.cgi?id=160842

Reviewed by Michael Catanzaro.

This patch adds support for setting base name of tarball and argument
passed to cmake's -DPORT= via command line arguments.

  • gtk/make-dist.py:

(Distcheck.configure):
(Distcheck.check):
(get_tarball_root_and_output_filename_from_arguments):

Aug 14, 2016:

5:48 PM Changeset in webkit [204459] by Chris Dumez
  • 13 edits
    1 delete in trunk/Source/WebCore

Align the event listener firing code with the latest DOM Specification and simplify it
​https://bugs.webkit.org/show_bug.cgi?id=160828

Reviewed by Darin Adler.

Align the event listener firing code with the latest DOM specification:

The following changes were made:

  1. RegisteredEventListener (equivalent to "event listener" in the spec) is now RefCounted
  2. RegisteredEventListener now has a wasRemoved flag as in specification.
  3. fireEventListeners() is now iterating over a copy of the event listeners, as in the specification. We rely on the wasRemoved removed flag to avoid executing event listeners that were removed while we iterate.

Previously, the code was modifying the event listeners vector we were
iterating on. Doing so safely lead to complicated and error prone code.
The new code is much simpler and easier to reason about.

This change seems to be perf-neutral on Speedometer.

No new tests, no web-exposed behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::getJSListenerFunctions):

  • dom/DOMAllInOne.cpp:
  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::assertNoActiveIterators):
(WebCore::EventListenerMap::containsCapturing):
(WebCore::EventListenerMap::containsActive):
(WebCore::findListener):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):
(WebCore::EventListenerMap::clear): Deleted.

  • dom/EventListenerMap.h:

(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::assertNoActiveIterators):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::getAttributeEventListener):
(WebCore::FiringEventListenersScope::FiringEventListenersScope):
(WebCore::FiringEventListenersScope::~FiringEventListenersScope):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::setAttributeEventListener): Deleted.
(WebCore::EventTarget::hasActiveEventListeners): Deleted.
(WebCore::EventTarget::dispatchEventForBindings): Deleted.
(WebCore::EventTarget::getEventListeners): Deleted.

  • dom/EventTarget.h:

(WebCore::EventTarget::isFiringEventListeners):

  • dom/RegisteredEventListener.cpp: Removed.
  • dom/RegisteredEventListener.h:

(WebCore::RegisteredEventListener::Options::Options):
(WebCore::RegisteredEventListener::create):
(WebCore::RegisteredEventListener::listener):
(WebCore::RegisteredEventListener::useCapture):
(WebCore::RegisteredEventListener::isPassive):
(WebCore::RegisteredEventListener::isOnce):
(WebCore::RegisteredEventListener::wasRemoved):
(WebCore::RegisteredEventListener::markAsRemoved):
(WebCore::RegisteredEventListener::RegisteredEventListener):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getEventListeners):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDOMAgent.h:

(WebCore::EventListenerInfo::EventListenerInfo):

  • svg/SVGElement.cpp:

(WebCore::hasLoadListener):

5:02 PM Changeset in webkit [204458] by mitz@apple.com
  • 6 edits
    1 delete in trunk/Source/WebKit2

[Cocoa] Remove deprecated _WKFormDelegate
​https://bugs.webkit.org/show_bug.cgi?id=160848

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WebKitPrivate.h: Removed #import.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _formDelegate]): Moved into WKBinaryCompatibilityIOS10 cateogry implementation,

chaged type to id <_WKInputDelegate>.

(-[WKWebView _setFormDelegate:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed property declaration.
  • UIProcess/API/Cocoa/_WKFormDelegate.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj: Removed reference to header.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Fixed comment.
4:04 PM Changeset in webkit [204457] by gskachkov@gmail.com
  • 4 edits in trunk/JSTests

[2016] Set correct status for test262 after implementation of Object.values&Object.entries
​https://bugs.webkit.org/show_bug.cgi?id=160844

Reviewed by Saam Barati.

Patch contains fix statuses of specs in the test262 test collection after implementation of
Object.values and Object.entries functions. Also patch contains small fixes in tests of the
tests for Object.values/entries functions.

  • stress/object-entries.js:

(Object.getOwnPropertyDescriptor):

  • stress/object-values.js:

(Object.getOwnPropertyDescriptor):

  • test262.yaml:
3:42 PM Changeset in webkit [204456] by dbates@webkit.org
  • 12 edits in trunk/Source

Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
​https://bugs.webkit.org/show_bug.cgi?id=160725

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/cocoa/ThemeCocoa.mm: Unconditionally include header dlfcn.h as it

exists in both the public iOS 9.3 SDK and iOS 10 beta SDK.

  • platform/spi/cocoa/CoreTextSPI.h: Add SPI declarations for constants that were

used in r204107.

  • platform/spi/cocoa/PassKitSPI.h: Remove unnecessary #import statements when

building with the Apple Internal SDK. Include header PassKit/PassKit.h when
building for iOS.

  • platform/spi/cocoa/QuartzCoreSPI.h: No need to define CLayer.contentsFormat

when building with the iOS 10 beta SDK as it is now part of the public API.

Source/WebKit/mac:

OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
silence the complier warning.

  • WebView/WebView.mm:

(-[WebView _dispatchTileDidDraw:]):

Source/WebKit2:

  • Platform/spi/ios/UIKitSPI.h: Add SPI for UITextInputSuggestionDelegate.
  • UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Remove unnecessary include of PKPaymentMerchantSession.h.

Source/WTF:

For now, disable OS_LOG when building with the iOS 10 beta SDK until
we have the fix for <rdar://problem/27758343>.

  • wtf/Platform.h:
3:38 PM Changeset in webkit [204455] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Dereferenced NULL pointer in StyleResolver
​https://bugs.webkit.org/show_bug.cgi?id=160823

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-14
Reviewed by Darin Adler.

No behavior changed, new tests unneeded.

This change was initiated by a NULL pointer dereference to provide this unused argument.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::CascadedProperties::addStyleProperties): Removed unused function argument.
(WebCore::StyleResolver::CascadedProperties::addMatch): Ditto.

  • css/StyleResolver.h: Ditto.
2:45 PM Changeset in webkit [204454] by mitz@apple.com
  • 5 edits
    1 delete in trunk/Source/WebKit2

[Cocoa] Remove deprecated _WKVisitedLinkProvider declarations that aren’t needed
​https://bugs.webkit.org/show_bug.cgi?id=160846

Reviewed by Darin Adler.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _visitedLinkProvider]): Moved into WKBinaryCompatibilityIOS10

cateogry implementation, changed type to _WKVisitedLinkStore.

(-[WKWebViewConfiguration _setVisitedLinkProvider:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Removed property declaration.
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.h: Removed.
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm: Moved declaration in here.
  • WebKit2.xcodeproj/project.pbxproj: Updated for header removal.
11:29 AM Changeset in webkit [204453] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix GTK Debug bots after r204400
​https://bugs.webkit.org/show_bug.cgi?id=160818

Reviewed by Carlos Garcia Campos.

Because the GTK EWS bot doesn't run tests, I missed this.

No new tests because there is no behavior change.

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::selectionRect):

Note: See TracTimeline for information about the timeline view.