Timeline



Mar 21, 2017:

8:49 PM Changeset in webkit [214241] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Make non-decoded image flashing less intrusive
​https://bugs.webkit.org/show_bug.cgi?id=169942

Reviewed by Said Abou-Hallawa.

When compositing borders are enabled, we paint yellow for images that paint but don't yet have a decoded
frame. Give this yellow 50% alpha to make it less intrusive

Also log to the images log channel when we destroy decoded data.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::draw):

6:55 PM Changeset in webkit [214240] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

The DFG Integer Check Combining phase should force an OSR exit for CheckInBounds on a negative constant min bound.
​https://bugs.webkit.org/show_bug.cgi?id=169933
<rdar://problem/31105125>

Reviewed by Filip Pizlo and Geoffrey Garen.

Also fixed the bit-rotted RangeKey::dump() function.

  • dfg/DFGIntegerCheckCombiningPhase.cpp:

(JSC::DFG::IntegerCheckCombiningPhase::handleBlock):

6:44 PM Changeset in webkit [214239] by mrajca@apple.com
  • 5 edits
    1 add in trunk

Loosen audio playback restrictions when the volume is 0.
​https://bugs.webkit.org/show_bug.cgi?id=169897

Reviewed by Eric Carlson.

Source/WebCore:

Added API tests.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/autoplay-zero-volume-check.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST):

6:03 PM WikiProcessors edited by trac
(diff)
6:03 PM WikiPageNames edited by trac
(diff)
6:03 PM WikiNewPage created by trac
6:03 PM WikiMacros edited by trac
(diff)
6:03 PM WikiHtml edited by trac
(diff)
6:03 PM WikiFormatting edited by trac
(diff)
6:03 PM WikiDeletePage edited by trac
(diff)
6:03 PM TracWorkflow edited by trac
(diff)
6:03 PM TracWiki edited by trac
(diff)
6:03 PM TracUpgrade edited by trac
(diff)
6:03 PM TracUnicode edited by trac
(diff)
6:03 PM TracTimeline edited by trac
(diff)
6:03 PM TracTicketsCustomFields edited by trac
(diff)
6:03 PM WikiRestructuredTextLinks edited by trac
(diff)
6:03 PM TracTickets edited by trac
(diff)
6:03 PM TracSyntaxColoring edited by trac
(diff)
6:03 PM TracSupport edited by trac
(diff)
6:03 PM TracStandalone edited by trac
(diff)
6:03 PM TracSearch edited by trac
(diff)
6:03 PM TracRss edited by trac
(diff)
6:03 PM TracRoadmap edited by trac
(diff)
6:03 PM TracRevisionLog edited by trac
(diff)
6:03 PM TracRepositoryAdmin edited by trac
(diff)
6:03 PM TracReports edited by trac
(diff)
6:03 PM TracQuery edited by trac
(diff)
6:03 PM TracPlugins edited by trac
(diff)
6:03 PM TracPermissions edited by trac
(diff)
6:03 PM TracNotification edited by trac
(diff)
6:03 PM TracNavigation edited by trac
(diff)
6:03 PM TracModWSGI edited by trac
(diff)
6:03 PM TracModPython edited by trac
(diff)
6:03 PM TracLogging edited by trac
(diff)
6:03 PM TracLinks edited by trac
(diff)
6:03 PM TracInterfaceCustomization edited by trac
(diff)
6:03 PM WikiRestructuredText edited by trac
(diff)
6:03 PM TracInstall edited by trac
(diff)
6:03 PM TracIni edited by trac
(diff)
6:03 PM TracImport edited by trac
(diff)
6:03 PM TracGuide edited by trac
(diff)
6:03 PM TracFineGrainedPermissions edited by trac
(diff)
6:03 PM TracFastCgi edited by trac
(diff)
6:03 PM TracEnvironment edited by trac
(diff)
6:03 PM TracChangeset edited by trac
(diff)
6:03 PM TracChangeLog created by trac
6:03 PM TracCgi edited by trac
(diff)
6:03 PM TracBrowser edited by trac
(diff)
6:03 PM TracBatchModify created by trac
6:03 PM TracBackup edited by trac
(diff)
6:03 PM TracAdmin edited by trac
(diff)
6:03 PM TracAccessibility edited by trac
(diff)
6:03 PM TicketQuery created by trac
6:03 PM PageTemplates edited by trac
(diff)
6:03 PM InterWiki edited by trac
(diff)
6:03 PM InterTrac edited by trac
(diff)
6:03 PM CamelCase edited by trac
(diff)
5:45 PM Changeset in webkit [214238] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade
​https://bugs.webkit.org/show_bug.cgi?id=169937
<rdar://problem/31181859>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._parse_bug_id_from_attachment_page): Since rel tag is no longer present, parsing the bug id from bug_title.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fixed unit test.
5:08 PM Changeset in webkit [214237] by beidson@apple.com
  • 5 edits in trunk

Disable all virtual tables.
<rdar://problem/31081972> and ​https://bugs.webkit.org/show_bug.cgi?id=169928
Source/WebCore:

Reviewed by Jer Noble.

No new tests (Covered by changes to existing test).

  • Modules/webdatabase/DatabaseAuthorizer.cpp:

(WebCore::DatabaseAuthorizer::createVTable):
(WebCore::DatabaseAuthorizer::dropVTable):

LayoutTests:

Reviewed by Jer Noble.

  • storage/websql/test-authorizer-expected.txt:
  • storage/websql/test-authorizer.js:

(createStatementsCallback):

5:06 PM Changeset in webkit [214236] by jmarcell@apple.com
  • 6 edits in branches/safari-603-branch/Source/WebCore

Merge r214014. rdar://problem/30921815

4:40 PM Changeset in webkit [214235] by andersca@apple.com
  • 9 edits in trunk/Source

Remove bogus availability annotations from DOM SPI headers.
rdar://problem/31015675

Rubber-stamped by Dan Bernstein.

Source/WebCore:

  • platform/cocoa/WebKitAvailability.h:

Remove NSi_9876_5 #define.

Source/WebKit/mac:

  • DOM/DOMHTMLMediaElement.h:
  • DOM/DOMHTMLVideoElement.h:
  • DOM/DOMMediaError.h:
  • DOM/DOMTextEvent.h:
  • DOM/DOMTimeRanges.h:
  • DOM/DOMTokenList.h:
4:02 PM Changeset in webkit [214234] by jmarcell@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

3:33 PM Changeset in webkit [214233] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

ews should indicate in logs when it fails to parse_bug_id_from_attachment_page
​https://bugs.webkit.org/show_bug.cgi?id=169927

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._parse_bug_id_from_attachment_page): Added log statement.

2:39 PM Changeset in webkit [214232] by Alan Bujtas
  • 3 edits
    2 adds in trunk

2017-03-21 Zalan Bujtas <Alan Bujtas>

Tear down descendant renderers when <slot>'s display value is set to no "contents".
​https://bugs.webkit.org/show_bug.cgi?id=169921
<rdar://problem/30336417>

Reviewed by Antti Koivisto.

Since "display: contents" does not generate a renderer, when an element's display value is
changed to something other than "contents", we not only create a renderer but also reparent its descendant
subtree (e.g from slot's parent to the newly constructed slot renderer). During this reparenting, we
need to tear down the descendant subtree tree and build it up again to reflect the new rendering context.

Test: fast/shadow-dom/slot-with-continuation-descendants.html

  • style/RenderTreeUpdater.cpp: (WebCore::RenderTreeUpdater::updateElementRenderer):
2:25 PM Changeset in webkit [214231] by Wenson Hsieh
  • 9 edits in trunk/Source

Teach TextIndicator to estimate the background color of the given Range
​https://bugs.webkit.org/show_bug.cgi?id=169869
<rdar://problem/31127272>

Reviewed by Anders Carlsson and Simon Fraser.

Source/WebCore:

Introduces a simple heuristic to compute a background color that is appropriate to use as a border surrounding
the snapshot of the given Range. This work is only carried out if TextIndicatorOptionComputeEstimatedBackgroundColor
is specified. The details of how this background color is estimated (as well as when to fall back) can be improved
in several ways (one idea is to sample colors along the edge of the snapshot). For the time being, this patch
naively walks up the render tree in search of enclosing parent renderers that have background colors. If any
renderers have a style that is deemed too complex to capture in a single background color, then fall back to the
base document background color; otherwise, the estimated background color is the result of blending these
background colors together.

  • page/TextIndicator.cpp:

(WebCore::styleContainsComplexBackground):

Bail out of the background color codepath if the renderer has backdrop filters, has a background image, or uses
a non-normal blend mode.

(WebCore::fallbackBackgroundColorForTextSelection):
(WebCore::estimatedBackgroundColorForRange):
(WebCore::initializeIndicator):

  • page/TextIndicator.h:

Source/WebKit/mac:

Plumb the estimated background color for WebKit1 clients through a new property in WebUITextIndicatorData.

  • WebView/WebView.mm:

(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):
(-[WebUITextIndicatorData dealloc]):

  • WebView/WebViewPrivate.h:

Source/WebKit2:

Send the estimated background color over XPC, and adopt TextIndicatorOptionComputeEstimatedBackgroundColor when
snapshotting after performing an edit data interaction.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDataInteraction):

2:08 PM Changeset in webkit [214230] by Chris Dumez
  • 4 edits in trunk/Source/WebKit2

[WK2] Call processDidCrash() right away when terminating a process that exceeded background CPU limit
​https://bugs.webkit.org/show_bug.cgi?id=169573
<rdar://problem/30960968>

Reviewed by Andreas Kling.

Call processDidCrash() right away when terminating a process that exceeded background CPU limit
and let the client decide when to reload the content.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::dispatchActivityStateChange):
(WebKit::WebPageProxy::terminateProcess):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didExceedBackgroundCPULimit):

1:52 PM Changeset in webkit [214229] by clopez@igalia.com
  • 3 edits in trunk/LayoutTests

[GTK][Wayland] Enable WebGL, 3D and compositing layout tests
​https://bugs.webkit.org/show_bug.cgi?id=71849

Unreviewed test gardening.

  • platform/gtk-wayland/TestExpectations: Add the diff of native Wayland compared to Xvfb.
  • platform/gtk/TestExpectations: This two tests seem flaky.
12:49 PM Changeset in webkit [214228] by jmarcell@apple.com
  • 2 edits in tags/Safari-604.1.13/Source/WebKit2

Merge r214179. rdar://problem/31030944

12:45 PM Changeset in webkit [214227] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Crash in WebCore: WebCore::CARingBuffer::getCurrentFrameBounds + 28
​https://bugs.webkit.org/show_bug.cgi?id=169887
<rdar://problem/23648082>

Reviewed by Eric Carlson.

Because AudioSourceProviderAVFObjC::prepareCallback() can concievably be called after the AudioSourceProviderAVFObjC
it refers to has been destroyed, add an extra layer of indirection between the tap and the provider, and invalidate
that level of indirection before the AudioSourceProviderAVFObjC is destroyed.

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::initCallback):
(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):
(WebCore::AudioSourceProviderAVFObjC::prepareCallback):
(WebCore::AudioSourceProviderAVFObjC::unprepareCallback):
(WebCore::AudioSourceProviderAVFObjC::processCallback):

11:18 AM Changeset in webkit [214226] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Remove logging left in by mistake.

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::willBeDestroyed):

9:54 AM Changeset in webkit [214225] by ddkilzer@apple.com
  • 2 edits
    1 delete in trunk/Websites/bugs.webkit.org

Commit local changes for Bugzilla 5.0.3

  • images/favicon.ico: Update favicon from Dec 11, 2015.
  • data/params.json: Deleted.
9:27 AM Changeset in webkit [214224] by ddkilzer@apple.com
  • 597 edits
    3 moves
    189 adds
    35 deletes in trunk/Websites/bugs.webkit.org

Upgrade to Bugzilla 5.0.3.

8:52 AM Changeset in webkit [214223] by clopez@igalia.com
  • 3 edits
    199 adds in trunk/LayoutTests

[GTK] Enable WebGL, 3D and compositing layout tests
​https://bugs.webkit.org/show_bug.cgi?id=71849

Unreviewed test gardeninng.

  • http/tests/webgl/1.0.2/origin-clean-conformance-expected.txt: Rebaseline after r208049.
  • platform/gtk/TestExpectations: Mark new expected failures.
  • platform/gtk/compositing/animation/state-at-end-event-transform-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/animation/state-at-end-event-transform-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/backface-visibility-in-3dtransformed-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/child-layer-no-backing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/inline-block-no-backing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/no-backing-for-clip-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/no-backing-for-clip-overhang-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/no-backing-for-clip-overlap-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/backing/replaced-child-no-backing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/image-color-matching-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/image-color-matching-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/pdf-image-match-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/color-matching/pdf-image-match-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/compositing-visible-descendant-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/compositing-visible-descendant-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/direct-image-compositing-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/direct-image-compositing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/generated-content-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/generated-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/abs-position-inside-opacity-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/abs-position-inside-opacity-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/clipping-foreground-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/clipping-foreground-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-html-size-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-html-size-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-in-columns-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/composited-in-columns-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-in-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-in-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-position-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/fixed-position-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/horizontal-scroll-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/horizontal-scroll-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-deep-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-deep-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/layer-due-to-layer-children-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/outline-change-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/outline-change-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/partial-layout-update-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/partial-layout-update-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/root-layer-update-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/root-layer-update-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/vertical-scroll-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/vertical-scroll-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-fixed-scrolling-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-fixed-scrolling-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-opacity-overlay-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/geometry/video-opacity-overlay-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/composited-iframe-alignment-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/iframes/composited-iframe-alignment-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-copy-on-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-in-composited-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/iframes/iframe-in-composited-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/iframes/resizer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/images/direct-image-background-color-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/images/direct-image-background-color-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/fixed-position-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/fixed-position-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/overlap-animation-container-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/overlap-animation-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/will-change-layer-creation-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layer-creation/will-change-on-normal-flow-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/layers-inside-overflow-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/layers-inside-overflow-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/direct-image-mask-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/direct-image-mask-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/masked-ancestor-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/masked-ancestor-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/multiple-masks-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/multiple-masks-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/masks/simple-composited-mask-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/masks/simple-composited-mask-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/media-controls-bar-appearance-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/fixed-position-ancestor-clip-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/fixed-position-ancestor-clip-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/nested-scrolling-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/nested-scrolling-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-compositing-descendant-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-compositing-descendant-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-positioning-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-positioning-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/overflow-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/parent-overflow-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/parent-overflow-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/remove-overflow-crash2-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/remove-overflow-crash2-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scroll-ancestor-update-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scroll-ancestor-update-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scrollbar-painting-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/scrollbar-painting-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/overflow/theme-affects-visual-overflow-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/overflow/theme-affects-visual-overflow-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/reflections/reflection-in-composited-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/reflections/reflection-in-composited-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/become-overlay-composited-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/become-overlay-composited-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/composited-document-element-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/composited-document-element-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/content-into-overflow-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/content-into-overflow-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-rects-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/layer-repaint-rects-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/newly-composited-on-scroll-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/newly-composited-on-scroll-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute2-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/opacity-between-absolute2-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/repaint/overflow-into-content-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/repaint/overflow-into-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-iframe-absolute-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-iframe-relative-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/self-painting-layers-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/self-painting-layers-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/shadows/shadow-drawing-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/shadows/shadow-drawing-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/sibling-positioning-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/sibling-positioning-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/text-on-large-layer-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/text-on-large-layer-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/tiling/visiblerect-accumulated-offset-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/tiling/visiblerect-accumulated-offset-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/visibility/layer-visible-content-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-background-color-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-background-color-expected.txt: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-nonpremultiplied-blend-expected.png: Added. Rebaselined.
  • platform/gtk/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-default-value-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-default-value-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-different-image-formats-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-different-image-formats-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-2-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-2-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-gif-color-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-color-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-color-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-image-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-image-image-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-single-layer-no-blending-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/background-blend-mode-single-layer-no-blending-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-background-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-background-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-non-stacking-context-blending-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/blend-mode-isolation-flags-remove-stacking-context-blending-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-blend-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-blend-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-filter-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-filter-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-mask-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-mask-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-opacity-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-opacity-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-shadow-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-layer-shadow-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-multiply-alpha-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-multiply-alpha-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-normal-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-normal-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-darker-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-darker-expected.txt: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-lighter-expected.png: Added. Rebaselined.
  • platform/gtk/css3/blending/svg-blend-plus-lighter-expected.txt: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-expected.png: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-expected.txt: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added. Rebaselined.
  • platform/gtk/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt: Added. Rebaselined.
7:34 AM Changeset in webkit [214222] by Manuel Rego Casasnovas
  • 2 edits in trunk/Websites/planet.webkit.org

[Planet WebKit] Use HTTPS instead of HTTP for Igalia blog

Unreviewed patch just updating the Igalia WebKit blog configuration.

  • config.ini:
7:12 AM Changeset in webkit [214221] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Remove expectations for imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm.

It no longer works with current version of wptserve and it's already skipped globally.

  • platform/gtk/TestExpectations:
4:42 AM Changeset in webkit [214220] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Add missing MacroAssembler functions after r214187
​https://bugs.webkit.org/show_bug.cgi?id=169912

Reviewed by Yusuke Suzuki.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::loadFloat):
(JSC::MacroAssemblerARM::storeFloat):

4:31 AM Changeset in webkit [214219] by Yusuke Suzuki
  • 25 edits
    3 adds in trunk

[JSC] Optimize Number.prototype.toString on Int32 / Int52 / Double
​https://bugs.webkit.org/show_bug.cgi?id=167454

Reviewed by Saam Barati.

JSTests:

  • stress/number-to-string-abstract-operation.js: Added.

(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):

  • stress/number-to-string-radix.js: Added.

(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):

  • stress/number-to-string.js: Added.

(shouldBe):
(int32ToString):
(shouldBe.int32ToString.new.Number.int52ToString):
(shouldBe.int32ToString.new.Number):
(shouldBe.doubleToString):

Source/JavaScriptCore:

This patch improves Number.toString(radix) performance
by introducing NumberToStringWithRadix DFG node. It directly
calls the operation and it always returns String.

baseline patched

stanford-crypto-sha256-iterative 45.130+-0.928 44.032+-1.184 might be 1.0250x faster

4:16 AM Changeset in webkit [214218] by Yusuke Suzuki
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] Add JSPromiseDeferred::reject(ExecState*, Exception*) interface
​https://bugs.webkit.org/show_bug.cgi?id=169908

Reviewed by Sam Weinig.

To avoid calling reject(ExecState*, JSValue) with Exception* accidentally,
we add a new interface reject(ExecState*, Exception*).
Such an interface is already added in DOMPromise in WebCore.

  • runtime/JSInternalPromiseDeferred.cpp:

(JSC::JSInternalPromiseDeferred::reject):

  • runtime/JSInternalPromiseDeferred.h:
  • runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::reject):

  • runtime/JSPromiseDeferred.h:
2:43 AM Changeset in webkit [214217] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Remove duplicated entry.

  • platform/gtk/TestExpectations:
2:12 AM Changeset in webkit [214216] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark more tests that are failing.

  • platform/gtk/TestExpectations:
2:11 AM Changeset in webkit [214215] by commit-queue@webkit.org
  • 9 edits
    8 adds in trunk

[GTK] Add function webkit_dom_element_get_bounding_client_rect
​https://bugs.webkit.org/show_bug.cgi?id=163892

Patch by Aidan Holm <​aidanholm+webkit@gmail.com> on 2017-03-21
Reviewed by Carlos Garcia Campos.

Wrap WebCore::ClientRect as WebKitDOMClientRect.
Wrap WebCore::ClientRectList as WebKitDOMClientRectList.
Implement webkit_dom_element_get_bounding_client_rect().
Implement webkit_dom_element_get_client_rects().

  • PlatformGTK.cmake:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.cpp: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.cpp: Added.

(WebKit::kit):
(WebKit::core):
(WebKit::wrapClientRect):
(webkit_dom_client_rect_finalize):
(webkit_dom_client_rect_get_property):
(webkit_dom_client_rect_constructed):
(webkit_dom_client_rect_class_init):
(webkit_dom_client_rect_init):
(webkit_dom_client_rect_get_top):
(webkit_dom_client_rect_get_right):
(webkit_dom_client_rect_get_bottom):
(webkit_dom_client_rect_get_left):
(webkit_dom_client_rect_get_width):
(webkit_dom_client_rect_get_height):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRect.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectListPrivate.h: Added.
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:

(webkit_dom_element_get_property):
(webkit_dom_element_class_init):
(webkit_dom_element_get_scroll_height):
(webkit_dom_element_get_bounding_client_rect):
(webkit_dom_element_get_client_rects):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMPrivate.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/docs/webkitdomgtk-4.0-sections.txt:
  • WebProcess/InjectedBundle/API/gtk/DOM/webkitdom.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/webkitdomautocleanups.h:
  • WebProcess/InjectedBundle/API/gtk/DOM/webkitdomdefines.h:
1:59 AM Changeset in webkit [214214] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark several tests as failing and skip others.

  • platform/gtk/TestExpectations:
1:34 AM Changeset in webkit [214213] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[jsc] MacroAssemblerMIPS: implement the branchPtr(RelationalCondition, BaseIndex, RegisterID) overload.
​https://bugs.webkit.org/show_bug.cgi?id=169717

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2017-03-21
Reviewed by Yusuke Suzuki.

  • assembler/MacroAssembler.h: Expose branchPtr() on MIPS as well.
  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchPtr): Added.

12:50 AM Changeset in webkit [214212] by jonlee@apple.com
  • 34 edits
    7 copies
    1 move
    5 deletes in trunk/Source/WebCore

Clean up RTCSdpType, RTC enums and headers
​https://bugs.webkit.org/show_bug.cgi?id=169741

Reviewed by Youenn Fablet.

Convert to RTCSdpType.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:
  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/MediaEndpointSessionDescription.cpp:
  • Modules/mediastream/MediaEndpointSessionDescription.h:
  • Modules/mediastream/PeerConnectionBackend.cpp:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

Convert SDP argument to lvalue.

  • Modules/mediastream/RTCSessionDescription.cpp:
  • Modules/mediastream/RTCSessionDescription.h:
  • Modules/mediastream/RTCSessionDescription.idl:

Keep RTC enum IDLs above platform. Move the C++ enum headers into platform.

  • Modules/mediastream/RTCEnums.h: Removed.
  • Modules/mediastream/RTCIceConnectionState.h: Removed.
  • Modules/mediastream/RTCIceGatheringState.h: Removed.
  • Modules/mediastream/RTCIceTransportState.h: Removed.
  • Modules/mediastream/RTCSignalingState.h: Removed.
  • platform/mediastream/PeerConnectionStates.h: Remove from .xcodeproj. Move enums to separate headers.
  • platform/mediastream/RTCBundlePolicy.h:
  • platform/mediastream/RTCIceConnectionState.h:
  • platform/mediastream/RTCIceGatheringState.h:
  • platform/mediastream/RTCIceTransportPolicy.h:
  • platform/mediastream/RTCIceTransportState.h:
  • platform/mediastream/RTCRtpTransceiverDirection.h: Renamed from Source/WebCore/Modules/mediastream/RTCRtpTransceiverDirection.h.
  • platform/mediastream/RTCSdpType.h:
  • platform/mediastream/RTCSignalingState.h:

Move RtpTransceiverDirection out to a separate IDL.

  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCRtpTransceiver.cpp:
  • Modules/mediastream/RTCRtpTransceiver.h:
  • WebCore.xcodeproj/project.pbxproj:

Replace RTCEnums include with specific headers per enum.

  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCIceTransport.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::completeAddTransceiver): Remove unneeded static_cast.

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCRtpTransceiver.h:
  • platform/mediastream/MediaEndpoint.h:
  • platform/mediastream/MediaEndpointConfiguration.h:
  • platform/mock/MockMediaEndpoint.h:

Clean up license.

  • Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

Modernize header to use #pragma once.

  • platform/mediastream/RTCDTMFSenderHandler.h:
  • platform/mediastream/RTCDTMFSenderHandlerClient.h:
  • platform/mediastream/RTCIceCandidateDescriptor.h:
  • platform/mediastream/RTCPeerConnectionHandlerClient.h:
  • platform/mediastream/RTCSessionDescriptionDescriptor.h:
  • platform/mediastream/RTCSessionDescriptionRequest.h:
  • platform/mediastream/RTCVoidRequest.h:
  • platform/mock/RTCNotifiersMock.h:

Mar 20, 2017:

11:07 PM Changeset in webkit [214211] by jonlee@apple.com
  • 2 edits in trunk/LayoutTests/imported/w3c

Update progression in wpt test for WebRTC.

  • web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
8:27 PM Changeset in webkit [214210] by webkit@devinrousso.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: minor layout issues in Breakpoint Editor popover
​https://bugs.webkit.org/show_bug.cgi?id=169765

Reviewed by Brian Burg.

  • UserInterface/Controllers/BreakpointPopoverController.js:

(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
Fix typo.

  • UserInterface/Views/BreakpointActionView.css:

(body[dir=ltr] .breakpoint-action-button-container):
(body[dir=rtl] .breakpoint-action-button-container):
(:matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)):
(body[dir=ltr] :matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)):
(body[dir=rtl] :matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)):
(.breakpoint-action-block-body > .description):
(body[dir=ltr] .breakpoint-action-block-body > .description):
(body[dir=rtl] .breakpoint-action-block-body > .description):
(.breakpoint-action-block-body > input):
(.breakpoint-action-button-container): Deleted.
(.breakpoint-action-append-button, .breakpoint-action-remove-button): Deleted.

  • UserInterface/Views/BreakpointActionView.js:

(WebInspector.BreakpointActionView.prototype._updateBody):
Manually apply dir="ltr" to the description element to force proper rendering.

  • UserInterface/Views/BreakpointPopoverController.css:

(.popover .edit-breakpoint-popover-content):
(.popover .edit-breakpoint-popover-content > table > tr > th):
(#edit-breakpoint-popover-ignore):
(body[dir=ltr] :matches(#edit-breakpoint-popover-ignore, #edit-breakpoint-popover-auto-continue)):
(body[dir=rtl] :matches(#edit-breakpoint-popover-ignore, #edit-breakpoint-popover-auto-continue)):
(#edit-breakpoint-popoover-auto-continue): Deleted.

8:16 PM Changeset in webkit [214209] by jonlee@apple.com
  • 8 edits
    2 adds in trunk

Add iceCandidatePoolSize to RTCConfiguration
​https://bugs.webkit.org/show_bug.cgi?id=169866

Reviewed by Youenn Fablet.

Source/WebCore:

Test: webrtc/rtcconfiguration-icecandidatepoolsize.html

  • Modules/mediastream/RTCConfiguration.h:
  • Modules/mediastream/RTCConfiguration.idl: Add iceCandidatePoolSize.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::setConfiguration):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration): Set the size in libwebrtc.

  • platform/mediastream/MediaEndpointConfiguration.cpp:

(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):

  • platform/mediastream/MediaEndpointConfiguration.h:

LayoutTests:

  • webrtc/rtcconfiguration-icecandidatepoolsize-expected.txt: Added.
  • webrtc/rtcconfiguration-icecandidatepoolsize.html: Added.
7:55 PM Changeset in webkit [214208] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Icon next to "An error occurred..." message changes size when Inspector window is resized
​https://bugs.webkit.org/show_bug.cgi?id=169901

Reviewed by Brian Burg.

  • UserInterface/Views/Main.css:

(.message-text-view.error::before):

7:51 PM Changeset in webkit [214207] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Follow-up on comments for bug 169664
​https://bugs.webkit.org/show_bug.cgi?id=169709

Reviewed by Youenn Fablet.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::deriveAggregatedIceConnectionState): Update deriveAggregatedIceConnectionState.
(WebCore::MediaEndpointPeerConnection::iceTransportStateChanged): Set a capacity and used
uncheckedAppend.

7:15 PM Changeset in webkit [214206] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Delete another function that was supposed to be removed in the previous commit.

  • public/v3/models/build-request.js:

(BuildRequest.cachedRequestsForTriggerableID): Deleted.

7:13 PM Changeset in webkit [214205] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Modernize BuildRequestQueuePage
​https://bugs.webkit.org/show_bug.cgi?id=169903

Reviewed by Antti Koivisto.

Modernized the code for /v3/#/analysis/queue.

  • public/v3/models/build-request.js:

(BuildRequest.fetchTriggerables): Deleted since the manifest JSON now contains all the triggerables.

  • public/v3/pages/build-request-queue-page.js:

(BuildRequestQueuePage): Deleted this._triggerables. Added this._buildRequestsByTriggerable.
(BuildRequestQueuePage.prototype.open): Modernized the code.
(BuildRequestQueuePage.prototype.render): Ditto.
(BuildRequestQueuePage.prototype._constructBuildRequestTable): Ditto.

7:04 PM Changeset in webkit [214204] by Simon Fraser
  • 6 edits in trunk

Add a system trace point for memory warning handling
​https://bugs.webkit.org/show_bug.cgi?id=169893

Reviewed by Zalan Bujtas.

Source/WebCore:

Add a TraceScope for low memory handling, which logs 'critical' and 'synchronous'.

  • page/MemoryRelease.cpp:

(WebCore::releaseMemory):

Source/WTF:

Make it possible to pass data to the Begin trace point.

  • wtf/SystemTracing.h:

(WTF::TraceScope::TraceScope):

Tools:

Describe the new trace points.

  • Tracing/SystemTracePoints.plist:
7:04 PM Changeset in webkit [214203] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Optimize packing of Document and superclass data members
​https://bugs.webkit.org/show_bug.cgi?id=169880

Reviewed by Antti Koivisto.

Move data members around to optimize packing in SecurityContext, SuspendableTimer and Document.
This saves as few hundred bytes on Document.

Padding detected via Tools/Scripts/dump-class-layout

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:
  • dom/ScriptExecutionContext.h:
  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):

  • dom/SecurityContext.h:
  • page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

  • page/SuspendableTimer.h:
6:19 PM Changeset in webkit [214202] by rniwa@webkit.org
  • 12 edits
    1 move
    1 add in trunk/Websites/perf.webkit.org

Charts page show an inconsistent list of revisions for Git and Subversion
​https://bugs.webkit.org/show_bug.cgi?id=169888

Reviewed by Andreas Kling.

With Git, CommitLogViewer was showing the list of revisions including the starting hash,
which was the last data point's revision instead of all revisions after the last data point.

Fixed the bug by always specifying the revision at the last data point in both Subversion
and Git and then making /api/commits/<repository>/?from=X&to=Y exclude the first revision.
For clarity, "from" and "to" query parameters have been renamed to "precedingRevision" and
"lastRevision" respectively.

We also no longer adds 1 to the starting revision of Subversion-like starting revisions. e.g.
when the last data point was at r1234, new data point is at r1250, the label is now "r1234-r1250"
instead of "r1235-r1250".

  • browser-tests/chart-revision-range-tests.js: Fixed the tests since revisionList no longer

specifies from/to revisions.

  • browser-tests/commit-log-viewer-tests.js: Added. Added tests for CommitLogViewer.
  • browser-tests/index.html: Include the new test. Also use a local copy of mocha.js/css.
  • public/api/commits.php:

(main): Renamed "from" and "to" query parameters.

  • public/include/commit-log-fetcher.php:

(CommitLogFetcher::fetch_between): Added a check that commit time should either be specified
in both rows or not specified in either. Also reject when before_first_revision is identical
or after last_revision instead of re-ordering them since it no longer makes sense to do so with
new query parameter names.

  • public/v3/components/base.js:

(ComponentBase._addContentToElement): Use Array.isArray instead of instanceof. It's resilient
againt realm (global object) differences.

  • public/v3/components/chart-pane-base.js:

(ChartPaneBase.prototype._updateCommitLogViewer): No longer calls enqueueToRender on this since
CommitLogViewer does that on its own now.
(ChartPaneBase.prototype.render): Juse use this._openRepository instead of relying on CommitLogViewer
to remember which repository is current. This was the only use of currentRepository.

  • public/v3/components/commit-log-viewer.js:

(CommitLogViewer):
(CommitLogViewer.prototype.currentRepository): Deleted.
(CommitLogViewer.prototype.view):
(CommitLogViewer.prototype._fetchCommitLogs): Modernized and extracted from view to make it lazy.
Call fetchForSingleRevision when precedingRevision is not specified or it's identical to lastRevision
since the generic JSON API no longer supports being called with the identical revisions.
(CommitLogViewer.prototype.render): Modernized & simplified the code.
(CommitLogViewer.prototype._renderCommitList): Extracted from render to make it lazy.
(CommitLogViewer.htmlTemplate): Add ID on caption & tbody so that they're more easily addressable.
(CommitLogViewer.cssTemplate):

  • public/v3/models/commit-log.js:

(CommitLog.prototype.diff): No longer includes from/to revisions in the result. Also avoid adding
1 to a Subversion-like starting revision for creating the label. See above. But we still do this
for forming URLs due to the way tools like Trac work with Subversion revisions.
(CommitLog.fetchBetweenRevisions): Rewritten using DataModel.prototype.cachedFetch with FIXME for
what this function is supposed to be doing.
(CommitLog._cachedCommitLogs): Deleted.
(CommitLog.fetchForSingleRevision): Added.
(CommitLog._constructFromRawData): Added.

  • public/v3/models/data-model.js:

(DataModelObject.cachedFetch): Don't parse query values as an integer. Just URL-escape them.

  • public/v3/remote.js:

(BrowserRemoteAPI.prototype.sendHttpRequest): Fixed a typo.

  • server-tests/api-commits-tests.js: Renamed from api-commits.js. Updated the existing tests to

use new query parameters and added more test cases.

  • unit-tests/commit-log-tests.js: Updated the test cases now that CommitLog.prototype.diff no longer

includes from/to values. They're computed in ChartRevisionRange instead.

6:13 PM Changeset in webkit [214201] by achristensen@apple.com
  • 8 edits in trunk

WebPageProxy DecidePolicyForNavigationAction and DecidePolicyForResponseSync should be Delayed reply messages
​https://bugs.webkit.org/show_bug.cgi?id=167183
<rdar://problem/30203539>

Reviewed by Andy Estes.

Source/WebKit2:

Before this patch, the WKNavigationDelegate's decidePolicyForNavigationAction must synchronously call the decisionHandler.
If it stores the decisionHandler and calls it after decidePolicyForNavigationAction returns, we can get incorrect behavior.
This can be seen when the _WKWebsitePolicies given to the decisionHandler had no effect.
Now, we will have the WebProcess waiting on the UIProcess to respond to the Delayed reply before continuing.
This will not be a regression because currently everybody is either calling the decisionHandler immediately or getting incorrect behavior,
and the behavior will be the same if the decisionHandler is called immediately. It is possible that we could make the WebProcess
not wait on the response, but we would need to make WebCore's loading truly asynchronous first
(getting rid of ResourceHandleClient's synchronous methods).

Covered by making an API test asynchronously call the decisionHandler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseSync):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):

6:10 PM Changeset in webkit [214200] by jmarcell@apple.com
  • 1 copy in tags/Safari-603.2.1

Tag Safari-603.2.1.

6:01 PM Changeset in webkit [214199] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking on Clear Network Items icon throws an exception if timing popover is visible
​https://bugs.webkit.org/show_bug.cgi?id=169852
<rdar://problem/31132652>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
(WebInspector.ResourceTimelineDataGridNode):

5:46 PM Changeset in webkit [214198] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r187873): Web Inspector: When resizing, prevent DataGrid columns from collapsing entirely
​https://bugs.webkit.org/show_bug.cgi?id=169899

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.resizerDragging):
leftMinimum and rightMaximum variables were always NaN because this.ColumnResizePadding is undefined.

5:19 PM Changeset in webkit [214197] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix GTK build after r214190
​https://bugs.webkit.org/show_bug.cgi?id=169885

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendWebSocketMessage):
(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
(WebKit::WebSocketServerConnection::sendRawData):
Finish renaming send to sendData.

5:14 PM Changeset in webkit [214196] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Pseudo-class markers overlap DOM breakpoints and disclosure triangle
​https://bugs.webkit.org/show_bug.cgi?id=169850
<rdar://problem/31132335>

Reviewed by Joseph Pecoraro.

DOMTreeContentView should always have at least 7px of gutter space to
accomodate pseudo-class markers. When DOM breakpoints are visible the
gutter size is increased so breakpoints and markers do not overlap.

  • UserInterface/Views/DOMTreeContentView.css:

(.content-view.dom-tree .tree-outline.dom):
(.content-view.dom-tree.show-gutter .tree-outline.dom):
(body[dir=ltr] .content-view.dom-tree .tree-outline.dom):
(body[dir=rtl] .content-view.dom-tree .tree-outline.dom):
(body[dir=ltr] .content-view.dom-tree.show-gutter .tree-outline.dom): Deleted.
(body[dir=rtl] .content-view.dom-tree.show-gutter .tree-outline.dom): Deleted.

  • UserInterface/Views/DOMTreeOutline.css:

(.content-view.dom-tree.show-gutter .tree-outline.dom):
Change pseudo-class marker indent when showing DOM breakpoint gutter.
(body[dir=ltr] .tree-outline.dom li.pseudo-class-enabled > .selection-area::before):
Drive-by fix: copy paste error.

4:47 PM Changeset in webkit [214195] by Chris Dumez
  • 4 edits
    2 adds in trunk

Suspend media playback in background tabs
​https://bugs.webkit.org/show_bug.cgi?id=169883
<rdar://problem/28056151>

Reviewed by Eric Carlson.

Source/WebCore:

Suspend media playback in background tabs to save battery
except in cases where we cannot (e.g. PiP, AirPlay).

Test: media/media-playback-page-visibility.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::visibilityStateChanged):
When page visibility state changes, begin / end media session
interruption with reason PlatformMediaSession::EnteringBackground.
This reason was already used on iOS when the application enters
or exist background. HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction()
takes care of preventing interruption in case of AirPlay or PiP.

LayoutTests:

Add layout test coverage.

  • media/media-playback-page-visibility-expected.txt: Added.
  • media/media-playback-page-visibility.html: Added.
4:07 PM Changeset in webkit [214194] by dbates@webkit.org
  • 5 edits in trunk

Prevent new navigations from onbeforeunload handler
​https://bugs.webkit.org/show_bug.cgi?id=169891
<rdar://problem/31155736>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Ensure that all navigations initiated from an onbeforeunload handler are disallowed
regardless of how they were scheduled. Such navigations go against the expectation
of a user.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::isNavigationAllowed): Added.
(WebCore::FrameLoader::loadURL): Modified code to call FrameLoader::isNavigationAllowed().
(WebCore::FrameLoader::loadWithDocumentLoader): Ditto.
(WebCore::FrameLoader::stopAllLoaders): Ditto.

  • loader/FrameLoader.h:

LayoutTests:

Update test to ensure that we disallow navigation initiated via a DOM click event from
an onbeforeunload handler.

  • fast/events/before-unload-forbidden-navigation.html:
3:36 PM Changeset in webkit [214193] by rniwa@webkit.org
  • 5 edits
    1 move in trunk/Websites/perf.webkit.org

Fix os-build-fetcher.js and subprocess.js to make them work
​https://bugs.webkit.org/show_bug.cgi?id=169844

Reviewed by Antti Koivisto.

The script added in r213976 has a bug that it can execute commands to fetch subcommits in parallel.
Some commands to poll the lsit of system components is not desirable to be ran in parallel.

  • server-tests/resources/mock-subprocess.js:

(MockSubprocess): Use const declaration.
(MockSubprocess.resetAndWaitForInvocation): Added.
(MockSubprocess.waitForInvocation): Renamed from waitingForInvocation. A function name must be a verb.
See ​https://webkit.org/code-style-guidelines/#names-verb
(MockSubprocess.reset): Set invocations.length to 0 so that tests can store a reference to the array
regardless of whether reset is called or when it's called.

  • server-tests/tools-os-build-fetcher-tests.js: Updated tests per the code change. Most of codes now

expect each command to be ran seprately. e.g. if there were two commands to run, instead of expecting
them to be both ran, and resolving invocation promises, we'd wait for one command to run, resolve,
its subcommand to run, and then move onto the second top-level command. Also use a local reference
to MockSubprocess.invocations instead of using the fully qualified name.

  • tools/js/os-build-fetcher.js:

(mapInSerialPromiseChain): Added. Calling a closure that returns a promise on each item in an array
in serial (not asynchronous) is a very common pattern in this class.
(OSBuildFetcher.fetchAndReportAllInOrder): Added.
(OSBuildFetcher.prototype.fetchAndReportNewBuilds): Log what the number of builds being submitted.
(OSBuildFetcher.prototype._fetchAvailableBuilds): Fixed the main bug. Using Promise.all would result
in each top-level command to be execued in parallel. Since each subcommand is executed as soon as
its parent command is executed, this results in commands to be executed in parallel.
Added a whole bunch of logging so that we can at least detect a bug like this in the future.
(OSBuildFetcher.prototype._commitsForAvailableBuilds): Cleanup the coding style.
(OSBuildFetcher.prototype._addSubCommitsForBuild): Use mapInSerialPromiseChain. Tightened the assertion
about the content returned by a subcommand.

  • tools/js/subprocess.js: Fixed the bug that we were importing require('child_process').ChildProcess.

execFile is defined on require('child_process') itself.
(Subprocess.prototype.execute): Fixed a typo. this._childProcess doesn't exist.
(Subprocess):

  • tools/sync-os-versions.js: Renamed from tools/pull-os-versions.js.

(syncLoop): Cleaned up the coding style a little. Also added logging about how long we're about to sleep.

2:33 PM Changeset in webkit [214192] by Jonathan Bedard
  • 4 edits in trunk/Tools

webkitpy: Work around simctl launch returning dead processes
​https://bugs.webkit.org/show_bug.cgi?id=169878

Reviewed by Daniel Bates.

simctl launch will sometimes give the PID of a process which has just been terminated.
To work around this, we will always check if the returned PID is of a process which is
still running.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.Popen.init): Accept device argument.
(SimulatorProcess.Popen.poll): Call device.poll().
(SimulatorProcess._start): Pass device into Popen object.

  • Scripts/webkitpy/xcode/device.py:

(Device.poll): Added.

  • Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.install_app): Change attempts to timeout.
(SimulatedDevice.launch_app): Check that the process being returned is active, use a
timeout instead of attempts.
(SimulatedDevice):
(SimulatedDevice.poll): Added.

1:09 PM Changeset in webkit [214191] by Ryan Haddad
  • 2 edits in branches/safari-603.1.30.0-branch/LayoutTests

Merge r209999.

1:05 PM Changeset in webkit [214190] by achristensen@apple.com
  • 7 edits in trunk/Source/WebCore

Prepare SocketStreamHandle for being created from WK2
​https://bugs.webkit.org/show_bug.cgi?id=169885

Reviewed by Andy Estes.

No change in behavior.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::sendFrame):
Rename send to sendData to prevent name collisions with IPC::MessageSender::send.

  • platform/network/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandle::sendData):
(WebCore::SocketStreamHandle::send): Deleted.

  • platform/network/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleImpl.h:
  • platform/network/curl/SocketStreamHandleImpl.h:
  • platform/network/soup/SocketStreamHandleImpl.h:

Make platformSend and platformClose public so I can call them from IPC proxies.

12:50 PM Changeset in webkit [214189] by aestes@apple.com
  • 4 edits
    3 adds in trunk

[QuickLook] Subresources should be in the same origin as the main document
​https://bugs.webkit.org/show_bug.cgi?id=169868
<rdar://problem/29898214>

Reviewed by Daniel Bates.

Source/WebCore:

Prior to this change, QuickLook documents were placed in a unique origin, which meant all
subresources were loaded as cross-origin requests. This prevented XMLHttpRequests to the
QuickLook custom protocol, since cross-origin XHRs must be made to a protocol that
understands CORS.

Instead of a unique origin, we now create an origin for QuickLook documents from the preview
response URL (an x-apple-ql-id: URL), which will allow QuickLook to make same-origin XHRs by
using a URL with the same scheme and host as the preview response URL.

Test: http/tests/quicklook/same-origin-xmlhttprequest-allowed.html

  • dom/Document.cpp:

(WebCore::Document::applyQuickLookSandbox):

LayoutTests:

  • http/tests/quicklook/resources/same-origin-xmlhttprequest-allowed.rtf: Added.
  • http/tests/quicklook/resources/tap-run-test-hyperlink.js:

(runTest):

  • http/tests/quicklook/same-origin-xmlhttprequest-allowed-expected.txt: Added.
  • http/tests/quicklook/same-origin-xmlhttprequest-allowed.html: Added.
12:46 PM Changeset in webkit [214188] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebCore

window.crypto.getRandomValues() uses the insecure RC4 RNG
​https://bugs.webkit.org/show_bug.cgi?id=169623
<rdar://problem/31044229>

Reviewed by Brent Fulgham.

This patch replaces the RC4 RNG with one based on AES-CTR.

No change of behavior.

  • page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

11:58 AM Changeset in webkit [214187] by fpizlo@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Graph coloring should use coalescable moves when spilling
​https://bugs.webkit.org/show_bug.cgi?id=169820

Reviewed by Michael Saboff.

This makes our graph coloring register allocator use a new family of move instructions when
spilling both operands of the move. It's a three-operand move:

Move (src), (dst), %scratch

Previously, if both operands got spilled, we would emit a new instruction to load or store that
spill slot. But this made it hard for allocateStack to see that the two spill locations are
coalescable. This new kind of instruction makes it obvious that it's a coalescable move.

This change implements the coalescing of spill slots inside allocateStack.

This is an outrageous speed-up on the tsf_ir_speed benchmark from ​http://filpizlo.com/tsf/. This
is an interesting benchmark because it has a super ugly interpreter loop with ~20 live variables
carried around the loop back edge. This change makes that interpreter run 5x faster.

This isn't a speed-up on any other benchmarks. It also doesn't regress anything. Compile time is
neither progressed or regressed, since the coalescing is super cheap, and this does not add any
significant new machinery to the register allocator (it's just a small change to spill codegen).
Overall on our wasm benchmarks, this is a 16% throughput progression.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::move):
(JSC::MacroAssembler::move32):
(JSC::MacroAssembler::moveFloat):
(JSC::MacroAssembler::moveDouble):

  • b3/air/AirAllocateRegistersByGraphColoring.cpp:

(JSC::B3::Air::allocateRegistersByGraphColoring):

  • b3/air/AirAllocateStack.cpp:

(JSC::B3::Air::allocateStack):

  • b3/air/AirInst.cpp:

(JSC::B3::Air::Inst::hasEarlyDef):
(JSC::B3::Air::Inst::hasLateUseOrDef):
(JSC::B3::Air::Inst::needsPadding):

  • b3/air/AirInst.h:
  • b3/air/AirOpcode.opcodes:
  • b3/air/AirPadInterference.cpp:

(JSC::B3::Air::padInterference):

  • runtime/Options.h:
11:51 AM Changeset in webkit [214186] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r214096.

11:51 AM Changeset in webkit [214185] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/LayoutTests

Merge r214095.

11:51 AM Changeset in webkit [214184] by matthew_hanson@apple.com
  • 1 edit
    3 adds in branches/safari-603-branch/LayoutTests

Merge r214094.

11:51 AM Changeset in webkit [214183] by matthew_hanson@apple.com
  • 7 edits
    2 deletes in branches/safari-603-branch/LayoutTests

Merge r214081.

11:43 AM Changeset in webkit [214182] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r213953. rdar://problem/31049771

11:43 AM Changeset in webkit [214181] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Merge r213949. rdar://problem/31049771

11:40 AM Changeset in webkit [214180] by matthew_hanson@apple.com
  • 9 edits
    2 adds in branches/safari-603-branch

Merge r213253. rdar://problem/30773140

11:30 AM Changeset in webkit [214179] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix a paste-o in WebPaymentCoordinatorProxy::platformCompletePaymentSession
​https://bugs.webkit.org/show_bug.cgi?id=169881
rdar://problem/31030944

Reviewed by Dan Bernstein.

Don't always pass PKPaymentAuthorizationStatusFailure to the completion handler.

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentSession):

10:55 AM Changeset in webkit [214178] by eric.carlson@apple.com
  • 17 edits in trunk

[MediaStream] Respect constraints passed to getUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=169870
<rdar://problem/31138936>

Reviewed by Youenn Fablet and Jer Noble.
Source/WebCore:

Remember the fitness score calculated when evaluating constraints passed to getUserMedia, so
the best device is chosen when more than one device supports the constraints. Register two
mock video and two mock audio devices with different capabilities so these changes can
be tested.

No new tests, existing tests updated.

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::selectSettings): Store fitness score in m_fitnessScore.

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
  • platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSource::create): Don't assume sampleRate is 44.1K
(WebCore::MockRealtimeAudioSourceMac::emitSampleBuffers): Use sampleRate() instead of m_sampleRate.
(WebCore::MockRealtimeAudioSourceMac::reconfigure): Ditto.
(WebCore::MockRealtimeAudioSourceMac::render): Ditto.
(WebCore::MockRealtimeAudioSourceMac::applySampleRate): Ditto.

  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::updateSettings): Don't assume sampleRate is 44.1K
(WebCore::MockRealtimeAudioSource::initializeCapabilities): Support a range of sample rates.
(WebCore::MockRealtimeAudioSource::startProducingData): Initialize sampleRate if it hasn't
already been set.

  • platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::MockRealtimeMediaSource::audioDevices): Return an array of devices.
(WebCore::MockRealtimeMediaSource::videoDevices): Ditto.
(WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):
(WebCore::MockRealtimeMediaSource::mockAudioSourcePersistentID): Deleted.
(WebCore::MockRealtimeMediaSource::mockVideoSourcePersistentID): Deleted.
(WebCore::MockRealtimeMediaSource::mockAudioSourceName): Deleted.
(WebCore::MockRealtimeMediaSource::mockVideoSourceName): Deleted.
(WebCore::MockRealtimeMediaSource::audioDeviceInfo): Deleted.
(WebCore::MockRealtimeMediaSource::videoDeviceInfo): Deleted.

  • platform/mock/MockRealtimeMediaSource.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints):
(WebCore::MockRealtimeMediaSourceCenter::createMediaStream):
(WebCore::MockRealtimeMediaSourceCenter::getMediaStreamDevices):

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):

LayoutTests:

  • fast/mediastream/MediaDevices-enumerateDevices-expected.txt:
  • fast/mediastream/MediaDevices-getUserMedia-expected.txt:
  • fast/mediastream/MediaDevices-getUserMedia.html:
  • fast/mediastream/MediaStream-video-element-expected.txt:
  • fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt:
10:51 AM Changeset in webkit [214177] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit

[Xcode] Incremental builds of WebKitLegacy are slow because of the Postprocess Headers phase
​https://bugs.webkit.org/show_bug.cgi?id=169861

Reviewed by Sam Weinig.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Specified that the Postprocess Headers script build phase has the Headers and PrivateHeaders directories as its inputs and a timestamp file as its output.

Source/WebKit/mac:

  • MigrateHeaders.make: Touch the PrivateHeaders directory when migrating a header into it.
  • postprocess-headers.sh: Preserve the timestamp on the headers directories. Write out the timestamp file used by the Xcode project to determine whether to run the script.
10:49 AM Changeset in webkit [214176] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

10:47 AM Changeset in webkit [214175] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.13

Tag Safari-604.1.13.

10:32 AM Changeset in webkit [214174] by Wenson Hsieh
  • 7 edits in trunk/Source

TextIndicator should support a mode where selection rects are used to size the snapshot
​https://bugs.webkit.org/show_bug.cgi?id=169845
<rdar://problem/31127818>

Reviewed by Beth Dakin.

Source/WebCore:

Adds TextIndicator support in iOS for using the would-be selection rects of a given range to determine
snapshotting bounds. See below changes for more details.

  • dom/Range.cpp:

(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines):
(WebCore::Range::collectSelectionRects):

Mark these helper methods as const.

  • dom/Range.h:
  • page/TextIndicator.cpp:

(WebCore::getSelectionRectsForRange):
(WebCore::initializeIndicator):

If TextIndicatorOptionUseSelectionRectForSizing is enabled, then compute selection rects and set the text rects
to be the resulting selection rects. These are in document coordinates.

  • page/TextIndicator.h:

Source/WebKit2:

Adopt the new TextIndicatorOptionUseSelectionRectForSizing flag when generating an edit data interaction snapshot.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDataInteraction):

10:28 AM Changeset in webkit [214173] by Simon Fraser
  • 42 edits in trunk/Source/WebCore

Move code out of renderer destructors into willBeDestroyed()
​https://bugs.webkit.org/show_bug.cgi?id=169650

Reviewed by Antti Koivisto.

This is done for four reasons. First, code in willBeDestroyed() is able to call
virtual functions on derived classes. Second, this code will run before we've destroyed
the renderer's rareData, so can safely access it. Third, RenderWidget is special, and can have
its lifetime extended via manual ref-counting, and we want all cleanup to complete
before it goes into this weird zombie state. Fourth, in a shiny future where we have
ref-counted RenderObjects, we want cleanup code to be run explicitly and not tied
to object lifetime, and this is a step in that direction.

For all classes that derive from RenderObject, move code from the destructor into
willBeDestroyed(). New willBeDestroyed() implementations must call the base class.

RenderBlock and RenderBlockFlow are special; RenderBlockFlow::willBeDestroyed()
skips over RenderBlock::willBeDestroyed(), but they both need to run some code, which
I moved into RenderBlock::blockWillBeDestroyed().

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::blockWillBeDestroyed):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::~RenderBlockFlow):
(WebCore::RenderBlockFlow::willBeDestroyed):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::~RenderBox):
(WebCore::RenderBox::willBeDestroyed):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::~RenderBoxModelObject):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::~RenderCounter):
(WebCore::RenderCounter::willBeDestroyed):

  • rendering/RenderCounter.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::willBeDestroyed):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::~RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::willBeDestroyed):

  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::~RenderImage):
(WebCore::RenderImage::willBeDestroyed):

  • rendering/RenderImage.h:
  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::~RenderLayerModelObject):
(WebCore::RenderLayerModelObject::willBeDestroyed):

  • rendering/RenderLayerModelObject.h:
  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::~RenderLineBreak):
(WebCore::RenderLineBreak::willBeDestroyed):

  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::~RenderListBox):
(WebCore::RenderListBox::willBeDestroyed):

  • rendering/RenderListBox.h:
  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::~RenderListItem):
(WebCore::RenderListItem::willBeDestroyed):

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::~RenderListMarker):
(WebCore::RenderListMarker::willBeDestroyed):

  • rendering/RenderListMarker.h:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::~RenderMenuList):
(WebCore::RenderMenuList::willBeDestroyed):

  • rendering/RenderMenuList.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::willBeDestroyed):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::~RenderQuote):
(WebCore::RenderQuote::willBeDestroyed):

  • rendering/RenderQuote.h:
  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::~RenderSearchField):
(WebCore::RenderSearchField::willBeDestroyed):

  • rendering/RenderSearchField.h:
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::willBeDestroyed):

  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::~RenderText):
(WebCore::RenderText::willBeDestroyed):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::~RenderTextControlMultiLine):
(WebCore::RenderTextControlMultiLine::willBeDestroyed):

  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::~RenderVideo):
(WebCore::RenderVideo::willBeDestroyed):

  • rendering/RenderVideo.h:
  • rendering/RenderWidget.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::~RenderSVGImage):
(WebCore::RenderSVGImage::willBeDestroyed):

  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::~RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::willBeDestroyed):

10:11 AM Changeset in webkit [214172] by Jonathan Bedard
  • 2 edits in trunk/Tools

buildbot: run-webkit-tests should display test failures and run exceptions differently
​https://bugs.webkit.org/show_bug.cgi?id=169793
<rdar://problem/30987863>

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.evaluateCommand): Return EXCEPTION when run-webkit-tests returns with a code of 254.

9:46 AM Changeset in webkit [214171] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/XMLHttpRequest/timeout-multiple-fetches.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169637

Unreviewed test gardening.

  • platform/mac/TestExpectations:
8:40 AM Changeset in webkit [214170] by jonlee@apple.com
  • 12 edits in trunk/Source/WebCore

Mark differences in media stream implementation
​https://bugs.webkit.org/show_bug.cgi?id=169873

Reviewed by Eric Carlson.

Rearrange IDL and add comments based on 05 February 2017 Editor's Draft of Media
Capture and Streams spec.

  • Modules/mediastream/DOMURLMediaStream.idl:
  • Modules/mediastream/MediaDeviceInfo.idl:
  • Modules/mediastream/MediaDevices.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamEvent.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/MediaStreamTrackEvent.idl:
  • Modules/mediastream/MediaTrackConstraints.idl:
  • Modules/mediastream/MediaTrackSupportedConstraints.idl:
  • Modules/mediastream/NavigatorMediaDevices.idl:
  • Modules/mediastream/NavigatorUserMedia.idl:
5:02 AM Changeset in webkit [214169] by pvollan@apple.com
  • 8 edits in trunk/Source/WebCore

Use CopyFontDescriptorWithStrokeForStyle to get correct stroke width for captions.
​https://bugs.webkit.org/show_bug.cgi?id=169674

Reviewed by Eric Carlson.

Use the MediaAccessibility function MACopyFontDescriptorWithStrokeForStyle to get
correct video captions stroke width from a given font size.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateTextStrokeStyle):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

  • html/shadow/MediaControlElements.h:
  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::captionStrokeWidth):

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionStrokeWidth):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS):
(WebCore::CaptionUserPreferencesMediaAF::strokeWidth): Deleted.

  • page/CaptionUserPreferencesMediaAF.h:
  • platform/cf/MediaAccessibilitySoftLink.cpp:
  • platform/cf/MediaAccessibilitySoftLink.h:
3:01 AM Changeset in webkit [214168] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.16.0

WebKitGTK+ 2.16.0

3:01 AM Changeset in webkit [214167] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.0 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.16.0.
2:19 AM WebKitGTK/2.16.x edited by Carlos Garcia Campos
(diff)
2:18 AM Changeset in webkit [214166] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/po

Update Ukrainian translation
​https://bugs.webkit.org/show_bug.cgi?id=169812

Patch by Yuri Chornoivan <​yurchor@ukr.net> on 2017-03-18
Rubber-stamped by Michael Catanzaro.

  • uk.po:
2:18 AM Changeset in webkit [214165] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/po

Merge r213855 - Updated Swedish translation
​https://bugs.webkit.org/show_bug.cgi?id=169549

Patch by Josef Andersson <​l10nl18nsweja@gmail.com> on 2017-03-13
Rubber-stamped by Michael Catanzaro.

  • sv.po:
2:18 AM Changeset in webkit [214164] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r214163 - Unreviewed. Add missing types to WebKitAutocleanups.

  • UIProcess/API/gtk/WebKitAutocleanups.h:
2:15 AM Changeset in webkit [214163] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Add missing types to WebKitAutocleanups.

  • UIProcess/API/gtk/WebKitAutocleanups.h:
1:47 AM Changeset in webkit [214162] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Cairo] Ensure depth and stencil renderbuffers are created on GLESv2
​https://bugs.webkit.org/show_bug.cgi?id=166643

Patch by Emanuele Aina <Emanuele Aina> on 2017-03-20
Reviewed by Darin Adler.

If the gfx device doesn't support GL_OES_packed_depth_stencil, the
separate depth and stencil buffers are not generated.

Copy what GraphicsContext3DEfl used to do and apply it in
GraphicsContext3DCairo.

The Intel gfx driver seem to tolerate unbound renderbuffers, but
enabling debugging in Mesa yields an error:

$ MESA_DEBUG=1 \

MESA_EXTENSION_OVERRIDE=-GL_OES_packed_depth_stencil
./bin/MiniBrowser ​http://webglsamples.org/aquarium/aquarium.html

Mesa: User error: GL_INVALID_OPERATION in glRenderbufferStorage(no renderbuffer bound)

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
Ensure separate depth and stencil renderbuffers are created.
(WebCore::GraphicsContext3D::~GraphicsContext3D):
Ensure separate depth and stencil renderbuffers are released.

Mar 19, 2017:

6:32 PM Changeset in webkit [214161] by jmarcell@apple.com
  • 2 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r214079. rdar://problem/31116372

6:32 PM Changeset in webkit [214160] by jmarcell@apple.com
  • 8 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r214071. rdar://problem/31077016

6:32 PM Changeset in webkit [214159] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Merge r214059. rdar://problem/31099341

6:32 PM Changeset in webkit [214158] by jmarcell@apple.com
  • 5 edits
    2 adds in branches/safari-603-branch

Merge r214023. rdar://problem/31091039

6:32 PM Changeset in webkit [214157] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Merge r213967. rdar://problem/30921827

6:32 PM Changeset in webkit [214156] by jmarcell@apple.com
  • 7 edits
    3 adds in branches/safari-603-branch

Merge r213897. rdar://problem/30921833

6:32 PM Changeset in webkit [214155] by jmarcell@apple.com
  • 8 edits in branches/safari-603-branch/Source/WebCore

Merge r213833. rdar://problem/31092879

6:32 PM Changeset in webkit [214154] by jmarcell@apple.com
  • 3 edits
    1 add in branches/safari-603-branch

Merge r213742. rdar://problem/30921818

6:32 PM Changeset in webkit [214153] by jmarcell@apple.com
  • 2 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r213648. rdar://problem/30921824

6:32 PM Changeset in webkit [214152] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Merge r213501. rdar://problem/30921830

6:31 PM Changeset in webkit [214151] by jmarcell@apple.com
  • 5 edits in branches/safari-603-branch

Merge r213385. rdar://problem/30921816

6:31 PM Changeset in webkit [214150] by jmarcell@apple.com
  • 5 edits
    2 adds in branches/safari-603-branch

Merge r213311. rdar://problem/30812769

6:31 PM Changeset in webkit [214149] by jmarcell@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebKit2

Merge r212726. rdar://problem/30921822

5:26 PM Changeset in webkit [214148] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

WebHTMLView is useless as WebResourceHandler
​https://bugs.webkit.org/show_bug.cgi?id=169857

Reviewed by Dan Bernstein.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
WebHTMLView doesnt implement any of WebResourceHandler methods.

2:51 PM Changeset in webkit [214147] by Chris Dumez
  • 20 edits
    8 adds in trunk

Implement self.origin
​https://bugs.webkit.org/show_bug.cgi?id=168023

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/self-origin.any-expected.txt:
  • web-platform-tests/html/dom/self-origin.sub-expected.txt:

Rebaseline several WPT tests now that more checks are passing.

  • web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/Worker_Self_Origin-expected.txt: Added.
  • web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/Worker_Self_Origin.html: Added.
  • web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/support/WorkerSelfOriginSharedWorker.js: Added.

(onconnect):

  • web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/support/WorkerSelfOriginWorker.js: Added.
  • web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/support/w3c-import.log: Added.
  • web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/w3c-import.log: Added.

Import test coverage for self.origin in workers.

Source/WebCore:

Implement self.origin:

Firefox and Chrome already support this.

Test: imported/w3c/web-platform-tests/html/webappapis/the-windoworworkerglobalscope-mixin/Worker_Self_Origin.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::origin):

  • page/DOMWindow.h:
  • page/WindowOrWorkerGlobalScope.idl:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::origin):

  • workers/WorkerGlobalScope.h:

LayoutTests:

  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-maxlength.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-no-cr.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-null-char-in-status.html:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null-expected.txt:
  • http/tests/websocket/tests/hybi/handshake-fail-by-prepended-null.html:

Rename origin to wsOrigin in tests to avoid conflict with window.origin.

2:11 PM Changeset in webkit [214146] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r212910): Active call frame status icon has incorrect left margin
​https://bugs.webkit.org/show_bug.cgi?id=169862

Reviewed by Brian Burg.

  • UserInterface/Views/CallFrameTreeElement.css:

(.tree-outline .item.call-frame .status):
(body[dir=ltr] .tree-outline .item.call-frame .status):
(body[dir=rtl] .tree-outline .item.call-frame .status):

10:45 AM Changeset in webkit [214145] by Chris Dumez
  • 9 edits
    5 adds in trunk

const location = "foo" throws in a worker
​https://bugs.webkit.org/show_bug.cgi?id=169839

Reviewed by Mark Lam.

JSTests:

  • ChakraCore/test/es6/letconst_global_shadow_builtins_nonconfigurable.baseline-jsc:

Update expected jsc result now that we throw a SyntaxError when trying to shadow undefined
with a let variable. We used not to throw because the value is undefined but this was not
as per EcmaScript. Both Firefox and Chrome throw in this case.

  • stress/global-lexical-redeclare-variable.js:

(catch):
Update test that defines a non-configurable 'zoo' property on the global object and then
expected shadowing it with a 'let zoo' variable to work because its value was undefined.
This was not as per EcmaScript spec and both Firefox and Chrome throw in this case.

Source/JavaScriptCore:

Our HasRestrictedGlobalProperty check in JSC was slightly wrong, causing us
to sometimes throw a Syntax exception when we shouldn't when declaring a
const/let variable and sometimes not throw an exception when we should have.

This aligns our behavior with ES6, Firefox and Chrome.

  • runtime/ProgramExecutable.cpp:

(JSC::hasRestrictedGlobalProperty):
(JSC::ProgramExecutable::initializeGlobalProperties):
Rewrite hasRestrictedGlobalProperty logic as per the EcmaScript spec:

In particular, they were 2 issues:

  • We should throw a SyntaxError if hasProperty() returned true but getOwnProperty() would fail to return a descriptor. This would happen for properties that are not OWN properties, but defined somewhere in the prototype chain. The spec does not say to use hasProperty(), only getOwnProperty() and says we should return false if getOwnProperty() does not return a descriptor. This is what we do now.
  • We would fail to throw when declaring a let/const variable that shadows an own property whose value is undefined. This is because the previous code was explicitly checking for this case. I believe this was a misinterpretation of ES6 which says: """ Let desc be O.GetOwnProperty(P). If desc is undefined, return false. """ We should check that desc is undefined, not desc.value. This is now fixed.

LayoutTests:

  • fast/dom/window-const-variable-shadowing-expected.txt: Added.
  • fast/dom/window-const-variable-shadowing.html: Added.
  • fast/workers/const-location-variable-expected.txt: Added.
  • fast/workers/const-location-variable.html: Added.
  • fast/workers/resources/worker-const-location.js: Added.

Add layout test coverage for behavior changes. Those tests pass in Firefox and Chrome.

  • js/dom/const-expected.txt:
  • js/dom/const.html:

Update test which wrongly expected a let variable not to be able to shadow a
window named property. This test was failing in Chrome and Firefox. The reason
this does not throw is because window named properties are not on the window
object, they are on the WindowProperties object in the Window prototype chain.

8:54 AM Changeset in webkit [214144] by BJ Burg
  • 5 edits in trunk/Source/WebKit2

[Cocoa] Web Automation: non-sticky virtual keys like 'left arrow' don't work properly
​https://bugs.webkit.org/show_bug.cgi?id=169733
<rdar://problem/30162608>

Reviewed by Joseph Pecoraro.

There were several issues that caused certain virtual keys to not work correctly.
When a virtual key like 'left arrow' was dispatched as a keydown event, it was
ultimately being translated into an insertText: command instead of moveLeft:.

  • The automation browser window was not properly made key window and active, so AppKit never tried to match the NSEvent as a key equivalent. That code path must be taken in this case, as it translates arrow keys into command selectors.
  • AppKit relies on its own private use area (PUA) unicode characters to encode control keys that do not affect key modifier state, like the arrow keys. Since these PUA characters were not being used as the 'characters' of the NSEvents we synthesize, the events are treated as unknown and AppKit falls back to inserting the codepoint as uninterpreted text.
  • The Mac implementation of platformSimulateKeyStroke did not allow non-sticky virtual keys to use the 'InsertByKey' interaction which sends keydown+keyup. This is a programming mistake that causes such inputs to assert in debug builds and bail out to do nothing in non-debug builds.
  • A few simulated virtual keys that are matched to key equivalents did not properly set 'charactersIgnoringModifiers' on NSEvents, which may use the wrong editing command.
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::performKeyboardInteractions):
Fix this guard so that we actually call into key event synthesis code for iOS.

  • UIProcess/Automation/WebAutomationSession.h: Add declarations.
  • UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:

(WebKit::WebAutomationSession::charCodeForVirtualKey): Moved from iOS implementation.
(WebKit::WebAutomationSession::charCodeIgnoringModifiersForVirtualKey): Added.
There are only a few special cases for now. We will probably need to hardcode
the decomposition for other ASCII characters so the expected DOM events are fired
when entering a shifted character (i.e., 'A' should be 'Shift'+'a', not 'A').

  • UIProcess/Automation/ios/WebAutomationSessionIOS.mm:

(WebKit::WebAutomationSession::platformSimulateKeyStroke):
Use charCodeIgnoringModifiersForVirtualKey().

  • UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::sendSynthesizedEventsToPage): use -becomeKeyWindow.
(WebKit::keyHasStickyModifier): Added.
(WebKit::keyCodeForVirtualKey): Added.
(WebKit::eventModifierFlagsForVirtualKey):Added.
(WebKit::WebAutomationSession::platformSimulateKeyStroke):
Separately compute key stickiness, keyCode, event modifier, and charCode for
the simulated keystroke. The code to compute charCode is now shared between
iOS and macOS since the PUA characters are the same for both AppKit and UIKit.

8:41 AM Changeset in webkit [214143] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

import(arg) crashes when ToString(arg) throws
​https://bugs.webkit.org/show_bug.cgi?id=169778

Reviewed by Saam Barati.

JSTests:

  • stress/import-reject-with-exception.js: Added.

(shouldBe):
(let.x.get toString):

Source/JavaScriptCore:

JSPromiseDeferred should not be rejected with Exception*.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncImportModule):

Mar 18, 2017:

6:06 PM WebKitGTK/2.16.x edited by Michael Catanzaro
(diff)
5:58 PM Changeset in webkit [214142] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Update Ukrainian translation
​https://bugs.webkit.org/show_bug.cgi?id=169812

Patch by Yuri Chornoivan <​yurchor@ukr.net> on 2017-03-18
Rubber-stamped by Michael Catanzaro.

  • uk.po:
5:58 PM Changeset in webkit [214141] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Empty attribute added to a DOM tree outline element should not add whitespace within the tag
​https://bugs.webkit.org/show_bug.cgi?id=139623

Reviewed by Brian Burg.

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._attributeEditingCommitted):
If the newText after editing has no content, remove the element for that attribute.

5:41 PM Changeset in webkit [214140] by webkit@devinrousso.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: add keyboard shortcut to clear timeline records
​https://bugs.webkit.org/show_bug.cgi?id=132485

Reviewed by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype.handleClearShortcut):

1:22 PM Changeset in webkit [214139] by jonlee@apple.com
  • 13 edits in trunk

Add support for ImplementedAs, Clamp, EnforceRange, TreatNullAs for dictionary members
​https://bugs.webkit.org/show_bug.cgi?id=169731

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline tests. The results seem to show a problem in the original tests.

  • web-platform-tests/WebCryptoAPI/encrypt_decrypt/aes_gcm.worker-expected.txt:
  • web-platform-tests/WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt:

Source/WebCore:

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionaryImplementationContent): Create a new $implementationAsKey. Look for
ImplementedAs, and if it exists, override the value with the alias. Set the parameters of
convert<>() using JSValueToNative.
(IsValidContextForJSValueToNative): Update to include IDLDictionaryMembers.
(JSValueToNative): Bypass parseEnumeration serialization for enums if the context is an
IDLDictionaryMember. Dictionary members need convert<IDLEnumeration> which throw a TypeError
or return the enum (and utilizes parseEnumeration). parseEnumeration, in contrast, returns
an optional.

  • bindings/scripts/test/TestObj.idl: Add test cases in TestDictionary.

Update test results.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:

LayoutTests:

Rebaseline. The enhancement progressed the results of these tests.

  • crypto/subtle/aes-gcm-encrypt-malformed-parameters-expected.txt:
  • crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
  • crypto/subtle/hmac-generate-key-malformed-parameters-expected.txt:
1:21 PM Changeset in webkit [214138] by gskachkov@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Remove unnecessary condition from needsDerivedConstructorInArrowFunctionLexicalEnvironment in BytecodeGenerator.cpp
​https://bugs.webkit.org/show_bug.cgi?id=169832

Reviewed by Mark Lam.

Remove already covered condition in needsDerivedConstructorInArrowFunctionLexicalEnvironment
function. Condition isConstructor() && constructorKind() == ConstructorKind::Extends is already
isClassContext.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::needsDerivedConstructorInArrowFunctionLexicalEnvironment):

1:03 PM Changeset in webkit [214137] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Use initializers for Document member variables
​https://bugs.webkit.org/show_bug.cgi?id=169848

Reviewed by Chris Dumez.

Move Document to use C++11 brace initializers.

No behavior change.

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::xmlStandaloneStatus):
(WebCore::Document::setHasXMLDeclaration):

12:51 PM Changeset in webkit [214136] by Chris Dumez
  • 8 edits in trunk

innerText setter inserts empty text node if value starts with newline
​https://bugs.webkit.org/show_bug.cgi?id=169600

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Re-sync tests with upstream to gain test coverage.

  • web-platform-tests/innerText/getter-expected.txt:
  • web-platform-tests/innerText/getter-tests.js:
  • web-platform-tests/innerText/setter-expected.txt:
  • web-platform-tests/innerText/setter-tests.js:
  • web-platform-tests/innerText/setter.html:

Source/WebCore:

innerText setter should not create empty text nodes as per:

No new tests, updated existing test.

  • html/HTMLElement.cpp:

(WebCore::textToFragment):

10:52 AM Changeset in webkit [214135] by Chris Dumez
  • 19 edits
    21 adds in trunk

Allow setting the prototype of cross-origin objects, as long as they don't change
​https://bugs.webkit.org/show_bug.cgi?id=169787

Reviewed by Mark Lam.

LayoutTests/imported/w3c:

Import test coverage from W3C web-platform-tests.

  • web-platform-tests/common/domain-setter.sub.html: Added.
  • web-platform-tests/common/test-setting-immutable-prototype.js: Added.

(self.testSettingImmutablePrototypeToNewValueOnly.test):
(self.testSettingImmutablePrototypeToNewValueOnly):
(self.testSettingImmutablePrototype.else.test):
(self.testSettingImmutablePrototype):

  • web-platform-tests/common/w3c-import.log:
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-cross-origin-domain.sub-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-cross-origin-domain.sub.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-goes-cross-origin-domain.sub-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-goes-cross-origin-domain.sub.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-domain.sub-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-domain.sub.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-expected.txt: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-same-origin.html: Added.
  • web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log:
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/w3c-import.log: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-cross-origin-domain.sub-expected.txt: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-cross-origin-domain.sub.html: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-goes-cross-origin-domain.sub-expected.txt: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-goes-cross-origin-domain.sub.html: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin-domain.sub-expected.txt: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin-domain.sub.html: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin-expected.txt: Added.
  • web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin.html: Added.

Source/JavaScriptCore:

  • runtime/JSGlobalObject.h:

Mark JS global object as an immutable prototype exotic object to match Window.

  • runtime/JSObject.cpp:

(JSC::JSObject::setPrototypeWithCycleCheck):
Update setPrototypeWithCycleCheck() for immutable prototype exotic objects in order
to align with:

In particular, we need to call GetPrototypeOf and return true if it returns the same
value as the new prototype. We really need to call GetPrototypeOf and not merely
getting the prototype slot via getPrototypeDirect() since Location and Window override
GetPrototypeOf to return null in the cross-origin case.

  • runtime/JSProxy.cpp:

(JSC::JSProxy::setPrototype):
Update JSProxy::setPrototype() to forward such calls to its target. This is needed so
we end up calling JSObject::setPrototypeWithCycleCheck() for the Window object.
Handling immutable prototype exotic objects in that method does the right thing for
Window.

Source/WebCore:

Allow setting the prototype of cross-origin objects, as long as they don't change:

Tests: imported/w3c/web-platform-tests/common/domain-setter.sub.html

imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-cross-origin-domain.sub.html
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-goes-cross-origin-domain.sub.html
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-same-origin-domain.sub.html
imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-prototype-setting-same-origin.html
imported/w3c/web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-cross-origin-domain.sub.html
imported/w3c/web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-goes-cross-origin-domain.sub.html
imported/w3c/web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin-domain.sub.html
imported/w3c/web-platform-tests/html/browsers/the-windowproxy-exotic-object/windowproxy-prototype-setting-same-origin.html

  • bindings/js/JSLocationCustom.cpp:
  • page/Location.idl:

Drop custom setPrototype() implementation for Location and mark Location as an immutable
prototype exotic object now that JSC does the right thing for those.

LayoutTests:

  • http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
  • http/tests/security/cross-frame-access-object-setPrototypeOf.html:
  • js/dom/setPrototypeOf-location-window-expected.txt:
  • js/dom/setPrototypeOf-location-window.html:

Add checks for setting prototype of window and location objects to the same value
to make sure it does not throw, both in the same origin and the cross origin
cases.

  • fast/dom/Window/window-custom-prototype-crash-expected.txt:
  • http/tests/security/xss-DENIED-regular-propterty-with-iframe-proto-expected.txt:
  • js/object-literal-shorthand-construction-expected.txt:

Rebaseline tests now that the exception message is a bit different.

  • js/script-tests/prototype-assignment.js:

Remove special casing for Window, it now behaves like a regular immutable prototype
exotic object.

Mar 17, 2017:

9:32 PM Changeset in webkit [214134] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Stop sending media data as soon as peer connection is closed
​https://bugs.webkit.org/show_bug.cgi?id=169813

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-17
Reviewed by Eric Carlson.

Stopping sending of media data as soon as the peer connection is closed.
By stopping sending at source level, this may stop by a few frames/chunks earlier than before.
Making sure RealtimeOutgoingVideoSource is stopping observing the media source when being stopped and deleted.

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doStop):

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::stop):

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::stop):

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
8:49 PM Changeset in webkit [214133] by webkit@devinrousso.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: wrong filename when saving resource from ResourceImageContentView
​https://bugs.webkit.org/show_bug.cgi?id=54454

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/ResourceContentView.js:

(WebInspector.ResourceContentView.prototype.get supportsSave):
(WebInspector.ResourceContentView.prototype.get saveData):

  • UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype.get supportsSave): Deleted.
Add save data getter to the parent class, so that both Images and Fonts can be saved.

  • UserInterface/Views/Resource.js:

(WebInspector.Resource.prototype.canRequestContent):
Drive-by: remove unused function.

7:36 PM Changeset in webkit [214132] by commit-queue@webkit.org
  • 13 edits
    1 copy
    1 add in trunk

Implement incoming webrtc data based on tracksCurr
​https://bugs.webkit.org/show_bug.cgi?id=169836

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-17
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/video-with-receiver.html

Constructing incoming tracks based on libwebrtc OnAddTrack.
Constructing incoming media streams based on libwebrtc OnAddStream.
Firing only addstream if legacy API flag is on.

Ensuring that media stream and media stream tracks relationship is still correctly implemented.
For that, we keep a map that relates libwebrtc media streams with WebCore media streams.
Adding the ability to get a receiver related to the track on the track event.

Implementing the possibility to create a transceiver ahead of track arrival time.
Created transceivers that are not related to any real source are kept in the peer connection back end.
When a libwebrtc track is appearing, it is associated with the track source of the corresponding transceiver based on track type.

Added the ability to create empty real time sources and set their data libwebrtc track when being available.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::addTrackFromPlatform):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::removeRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::OnAddStream):
(WebCore::LibWebRTCMediaEndpoint::OnRemoveStream):
(WebCore::LibWebRTCMediaEndpoint::OnAddTrack):
(WebCore::LibWebRTCMediaEndpoint::stop):
(WebCore::createMediaStreamTrack): Deleted.
(WebCore::LibWebRTCMediaEndpoint::addStream): Deleted.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doStop):
(WebCore::createReceiverForSource):
(WebCore::createEmptySource):
(WebCore::LibWebRTCPeerConnectionBackend::createReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::videoReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::audioReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::removeRemoteStream):
(WebCore::LibWebRTCPeerConnectionBackend::addRemoteStream):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::setSourceTrack):

  • platform/mediastream/mac/RealtimeIncomingAudioSource.h:
  • platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::setSourceTrack):

  • platform/mediastream/mac/RealtimeIncomingVideoSource.h:

LayoutTests:

  • webrtc/video-with-receiver-expected.txt: Added.
  • webrtc/video-with-receiver.html: Copied from LayoutTests/webrtc/video.html.
  • webrtc/video.html:
5:39 PM Changeset in webkit [214131] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove TestExpectation for a test that is no longer in the tree.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:34 PM Changeset in webkit [214130] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[MediaStream] Compensate for video capture orientation
​https://bugs.webkit.org/show_bug.cgi?id=169313
<rdar://problem/30994785>

Unreviewed, fix a crash in r214120 found by the bots.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener invalidate]): Drive-by removal of unnecessary code.
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
Actually retain self before callOnMainThread.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
Invalidate the change listener first.

4:40 PM Changeset in webkit [214129] by dino@apple.com
  • 3 edits
    2 adds in trunk

MediaQueryList instances do not update for prefers-reduced-motion
​https://bugs.webkit.org/show_bug.cgi?id=169835
<rdar://problem/30339378>

Reviewed by Anders Carlsson.

Source/WebCore:

Tell the document it needs to evaluate the MediaQueryLists
if accessibility settings change.

Test: fast/media/mq-prefers-reduced-motion-matchMedia.html

  • page/Page.cpp:

(WebCore::Page::accessibilitySettingsDidChange):

LayoutTests:

  • fast/media/mq-prefers-reduced-motion-matchMedia-expected.txt: Added.
  • fast/media/mq-prefers-reduced-motion-matchMedia.html: Added.
4:33 PM Changeset in webkit [214128] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/airplay-placard/airplay-placard-text-section.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169654

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:23 PM Changeset in webkit [214127] by beidson@apple.com
  • 11 edits in trunk/Source

Make HTTPCookieStorage operate in the UIProcess in absence of a WebProcessPool.
<rdar://problem/31102330> and ​https://bugs.webkit.org/show_bug.cgi?id=169797

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (No behavior change).

  • platform/network/NetworkStorageSession.h:
  • platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::flushCookieStore):

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::flushCookieStore):

Source/WebKit2:

  • UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::~HTTPCookieStore):
(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::setCookie):
(API::HTTPCookieStore::deleteCookie):
(API::HTTPCookieStore::registerObserver):
(API::HTTPCookieStore::unregisterObserver):
(API::HTTPCookieStore::cookieManagerDestroyed):
(API::HTTPCookieStore::registerForNewProcessPoolNotifications):

  • UIProcess/API/APIHTTPCookieStore.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::create):
(WebKit::WebProcessPool::notifyThisWebProcessPoolWasCreated):
(WebKit::m_hiddenPageThrottlingTimer):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::processPoolForCookieStorageOperations):
(WebKit::WebsiteDataStore::processPoolForCookieStorageNotifications): Deleted.

  • UIProcess/WebsiteData/WebsiteDataStore.h:
2:59 PM Changeset in webkit [214126] by hyatt@apple.com
  • 4 edits
    2 adds in trunk

Disable per-region boxes for multicolumn
​https://bugs.webkit.org/show_bug.cgi?id=169830

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/multicol/float-adjacent-to-overflow-block.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
Limit all of the per-region box code to RenderNamedFlowThreads.
This code should never be used by multicolumn layout.

LayoutTests:

  • fast/multicol/float-adjacent-to-overflow-block-expected.html: Added.
  • fast/multicol/float-adjacent-to-overflow-block.html: Added.
2:51 PM Changeset in webkit [214125] by Said Abou-Hallawa
  • 7 edits in trunk/Source

Time channel attack on SVG Filters
​https://bugs.webkit.org/show_bug.cgi?id=118689

Reviewed by Simon Fraser.

Source/WebCore:

The time channel attack can happen if the attacker applies FEColorMatrix
or FEConvolveMatrix and provides a matrix which is filled with subnormal
floating point values. Performing floating-point operations on subnormals
is very expensive unless the pixel in the source graphics is black (or
zero). By measuring the time a filter takes to be applied, the attacker
can know whether the pixel he wants to steal from an iframe is black or
white. By repeating the same process on all the pixels in the iframe, the
attacker can reconstruct the whole page of the iframe.

To fix this issue, the values in the matrices of these filters will clamped
to FLT_MIN. We do not want to consume too much time calculating filtered
pixels because of such tiny values. The difference between applying FLT_MIN
and applying a subnormal should not be even noticeable. Normalizing the
floating-point matrices should happen only at the beginning of the filter
platformApplySoftware().

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::normalizedFloats):

Source/WTF:

Performing arithmetic operations on subnormal floating-point numbers is
very expensive. Normalizing the floating-point number to the minimum normal
value should accelerate the calculations and there won't be a noticeable
difference in the result since all the subnormal values and the minimum
normal value are all very close to zero.

  • wtf/MathExtras.h:

(normalizedFloat):

2:31 PM Changeset in webkit [214124] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Explicitly resize the audio buffer in RealtimeOutgoingAudioSource.
​https://bugs.webkit.org/show_bug.cgi?id=169814
<rdar://problem/30975496>

Reviewed by Eric Carlson.

Rather than just reserving sufficient capacity, actually change the buffer's underlying size to match.

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::pullAudioData):

2:28 PM Changeset in webkit [214123] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2] Disable background tab responsiveness detection on iOS
​https://bugs.webkit.org/show_bug.cgi?id=169824
<rdar://problem/30913776>

Reviewed by Dan Bernstein.

Disable background tab responsiveness detection on iOS where background tabs
often get suspended. This feature was not tested or meant to be enabled on
iOS, this was an oversight on my part.

  • UIProcess/BackgroundProcessResponsivenessTimer.cpp:

(WebKit::BackgroundProcessResponsivenessTimer::shouldBeActive):

2:18 PM Changeset in webkit [214122] by jiewen_tan@apple.com
  • 12 edits
    1 copy
    5 adds in trunk

[WebCrypto] Make sure all CryptoKey classes are structured clonable
​https://bugs.webkit.org/show_bug.cgi?id=169232
<rdar://problem/31106660>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch does the following few things: 1) It makes CryptoKeyEC and CryptoKeyRaw
structured clonable; 2) It makes CryptoKeyAES and CryptoKeyHMAC to use a move importer
during deserialization; 3) It adds some tests to make sure CryptoKeyAES, CryptoKeyHMAC
and CryptoKeyRSA won't lose their internal data during serialization/deserialization.

Tests: crypto/workers/subtle/ec-postMessage-worker.html

crypto/workers/subtle/raw-postMessage-worker.html

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::readHMACKey):
(WebCore::CloneDeserializer::readAESKey):
(WebCore::CloneDeserializer::readECKey):
(WebCore::CloneDeserializer::readRawKey):
(WebCore::CloneDeserializer::readCryptoKey):

  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::namedCurveString):
(WebCore::CryptoKeyEC::isValidECAlgorithm):

  • crypto/keys/CryptoKeyEC.h:

LayoutTests:

  • crypto/workers/subtle/aes-postMessage-worker-expected.txt:
  • crypto/workers/subtle/aes-postMessage-worker.html:
  • crypto/workers/subtle/ec-postMessage-worker-expected.txt: Added.
  • crypto/workers/subtle/ec-postMessage-worker.html: Added.
  • crypto/workers/subtle/hmac-postMessage-worker-expected.txt:
  • crypto/workers/subtle/hmac-postMessage-worker.html:
  • crypto/workers/subtle/raw-postMessage-worker-expected.txt: Added.
  • crypto/workers/subtle/raw-postMessage-worker.html: Added.
  • crypto/workers/subtle/resources/ec-postMessage-worker.js: Added.
  • crypto/workers/subtle/resources/raw-postMessage-worker.js: Added.
  • crypto/workers/subtle/resources/rsa-postMessage-worker.js:
  • crypto/workers/subtle/rsa-postMessage-worker-expected.txt:
  • crypto/workers/subtle/rsa-postMessage-worker.html:
2:16 PM Changeset in webkit [214121] by msaboff@apple.com
  • 12 edits in trunk

Use USE_INTERNAL_SDK to compute ENABLE_FAST_JIT_PERMISSIONS instead of HAVE_INTERNAL_SDK
​https://bugs.webkit.org/show_bug.cgi?id=169817

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2:14 PM Changeset in webkit [214120] by eric.carlson@apple.com
  • 9 edits in trunk/Source/WebCore

[MediaStream] Compensate for video capture orientation
​https://bugs.webkit.org/show_bug.cgi?id=169313
<rdar://problem/30994785>

Reviewed by Jer Noble.

No new tests, the mock video source doesn't support rotation. Test will be added when this
is fixed in ​https://bugs.webkit.org/show_bug.cgi?id=169822.

Add 'orientation' and 'mirrored' attributes to MediaSample

  • platform/MediaSample.h:

(WebCore::MediaSample::videoOrientation):
(WebCore::MediaSample::videoMirrored):

  • platform/graphics/avfoundation/MediaSampleAVFObjC.h:

A video sample can be rotated and/or mirrored, so the video layer may need to be rotated
and resized for display. We don't want expose this information to the renderer, so allocate
return a generic CALayer as the player's platforLayer, and add the video layer as a sublayer
so we can adjust it to display correctly. Add an enum for playback state as well as display
mode so we correctly display a black frame when video frames are available but playback has
not yet started.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener initWithParent:]):
(-[WebAVSampleBufferStatusChangeListener invalidate]):
(-[WebAVSampleBufferStatusChangeListener beginObservingLayers]):
(-[WebAVSampleBufferStatusChangeListener stopObservingLayers]): Ditto.
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoTransformationMatrix):
(WebCore::runWithoutAnimations):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layerErrorDidChange):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::cancelLoad):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::displayLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::backgroundLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentDisplayMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentMediaTime):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::activeStatusChanged):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateRenderingMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setShouldBufferData):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::backgroundLayerBoundsChanged):
(-[WebAVSampleBufferStatusChangeListener beginObservingLayer:]): Deleted.
(-[WebAVSampleBufferStatusChangeListener stopObservingLayer:]): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paused): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::shouldBePlaying): Deleted.

  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::processNewFrame): Add connection parameter so we can get the
video orientation.
(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):

Pass sample orientation to libwebrtc.

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::sendFrame):
(WebCore::RealtimeOutgoingVideoSource::videoSampleAvailable):

  • platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
2:12 PM Changeset in webkit [214119] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Fix the flow thread state on the descendants of out of flow positioned replaced elements.
​https://bugs.webkit.org/show_bug.cgi?id=169821
<rdar://problem/30964017>

Reviewed by Simon Fraser.

Source/WebCore:

Descendants of a replaced out of flow elmement should inherit the flowthread state
from the replaced element and not from the replaced element's parent.

Test: fast/multicol/fix-inherit-when-container-is-replaced.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::computedFlowThreadState):

LayoutTests:

  • fast/multicol/fix-inherit-when-container-is-replaced-expected.txt: Added.
  • fast/multicol/fix-inherit-when-container-is-replaced.html: Added.
1:59 PM Changeset in webkit [214118] by Jon Davis
  • 2 edits in trunk/Source/WebCore

Update feature status for outdated entries: CSS Shapes, Force Click Events
​https://bugs.webkit.org/show_bug.cgi?id=169829

Reviewed by Matt Baker.

  • features.json:
1:45 PM Changeset in webkit [214117] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Make SocketStreamError a private header.
​https://bugs.webkit.org/show_bug.cgi?id=169831

  • WebCore.xcodeproj/project.pbxproj:

I'll need this from WebKit2.

1:45 PM Changeset in webkit [214116] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update webrtc tests expectations
​https://bugs.webkit.org/show_bug.cgi?id=169828

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-17

1:42 PM Changeset in webkit [214115] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Add encoder for SocketStreamError
​https://bugs.webkit.org/show_bug.cgi?id=169831

Reviewed by Andy Estes.

This isn't used yet, but we'll soon need to send these across IPC.

  • platform/network/SocketStreamError.h:

(WebCore::SocketStreamError::encode):
(WebCore::SocketStreamError::decode):

1:30 PM Changeset in webkit [214114] by achristensen@apple.com
  • 11 edits
    1 add in trunk/Source/WebCore

Make SocketStreamHandle virtual functions asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=169818

Reviewed by Andy Estes.

No change in behavior. Instead of returning immediately, call a completion handler.
This is in preparation for making them truly asynchronous.

I still need to be able to synchronously get the number of buffered bytes, but the
buffer itself will soon be in the NetworkProcess with a new subclass of SocketStreamHandle
that messages across IPC. The number of buffered bytes will still be stored in the WebProcess,
and when it updates, the message from SocketStreamHandleClient::didUpdateBufferedAmount will update it.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/network/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandle::send):
(WebCore::SocketStreamHandle::close):
(WebCore::SocketStreamHandle::sendPendingData): Deleted.

  • platform/network/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::bufferedAmount): Deleted.

  • platform/network/SocketStreamHandleImpl.cpp: Added.

(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::sendPendingData):
(WebCore::SocketStreamHandleImpl::bufferedAmount):
m_buffer was moved from SocketStreamHandle to SocketStreamHandleImpl, so some of the logic must move with it.
I moved as much logic that was shared in the superclass to a new shared location for code shared among the subclass implementations.

  • platform/network/cf/SocketStreamHandleImpl.h:
  • platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformSend): Deleted.

  • platform/network/curl/SocketStreamHandleImpl.h:
  • platform/network/curl/SocketStreamHandleImplCurl.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformSend): Deleted.

  • platform/network/soup/SocketStreamHandleImpl.h:
  • platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformSend): Deleted.

12:52 PM Changeset in webkit [214113] by Antti Koivisto
  • 33 edits
    3 adds in trunk

Add a reload policy where only expired subresources are revalidated
​https://bugs.webkit.org/show_bug.cgi?id=169756

Reviewed by Andreas Kling.

Source/WebCore:

Test: http/tests/cache/reload-expired-only.html

The default reload behavior revalidates all resources on the page. This patch adds
a new policy that revalidates expired (and uncacheable) resources only. Using this
policy can speed up reloads significantly and also reduce network traffic and server
load.

  • history/PageCache.cpp:

(WebCore::canCachePage):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::reload):

  • loader/FrameLoader.cpp:

(WebCore::isBackForwardLoadType):
(WebCore::isReload):

Add a helper function.

(WebCore::FrameLoader::loadURL):
(WebCore::logNavigation):
(WebCore::FrameLoader::reload):

Replace bool arguments with OptionSet<ReloadOption>. Most of the patch is about adapting to this.

(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::subresourceCachePolicy):

Return CachePolicyVerify for 'ReloadExpiredOnly' frame load type. This is the substantive
change that causes the behavior difference.

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::defaultRequestCachingPolicy):

Flip the isMainResource condition for better readability.

(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::reload):

  • loader/FrameLoaderTypes.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreDocumentState):

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::reloadRevalidatingExpiredKey):

  • page/DiagnosticLoggingKeys.h:
  • replay/UserInputBridge.cpp:

(WebCore::UserInputBridge::reloadFrame):

  • replay/UserInputBridge.h:
  • testing/Internals.cpp:

(WebCore::Internals::forceReload):
(WebCore::Internals::reloadExpiredOnly):

Testing support.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(toWebFrameLoadType):
(-[WebFrame reload]):
(-[WebFrame reloadFromOrigin]):

Source/WebKit2:

  • UIProcess/API/C/WKPage.cpp:

(WKPageReload):
(WKPageReloadWithoutContentBlockers):
(WKPageReloadFromOrigin):
(WKPageReloadExpiredOnly):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _reloadWithoutContentBlockers]):
(-[WKWebView _reloadExpiredOnly]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::reloadBrowsingContext):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didHandleContentFilterUnblockNavigation):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reload):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reload):
(WebKit::shouldReuseCommittedSandboxExtension):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

  • http/tests/cache/reload-expired-only-expected.txt: Added.
  • http/tests/cache/reload-expired-only.html: Added.
  • http/tests/cache/resources/document-with-cached-unique-script.html: Added.
  • http/tests/cache/resources/random-cached.cgi:
12:48 PM Changeset in webkit [214112] by n_wang@apple.com
  • 4 edits
    4 adds in trunk

AX: VoiceOver no longer works corectly with editable text in the web
​https://bugs.webkit.org/show_bug.cgi?id=169801

Reviewed by Chris Fleizach.

Source/WebCore:

The issue is that since we are entering text controls when getting the text marker,
the end text marker of the input tag might associate to the placeholder div instead of
the input tag itself.
Fixed the issue by checking the shadow elements using shadowHost() instead of isShadowRoot().
Also, only enter text controls when navigating by characters/indexes, so that both Mac and
iOS will get the correct text marker ranges for shadow host elements.

Tests: accessibility/ios-simulator/element-text-range-for-text-control.html

accessibility/mac/text-markers-for-input-with-placeholder.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::startOrEndCharacterOffsetForRange):
(WebCore::AXObjectCache::characterOffsetForIndex):

  • accessibility/AXObjectCache.h:

LayoutTests:

  • accessibility/ios-simulator/element-text-range-for-text-control-expected.txt: Added.
  • accessibility/ios-simulator/element-text-range-for-text-control.html: Added.
  • accessibility/mac/text-markers-for-input-with-placeholder-expected.txt: Added.
  • accessibility/mac/text-markers-for-input-with-placeholder.html: Added.
12:30 PM Changeset in webkit [214111] by Wenson Hsieh
  • 11 edits in trunk/Source

[WK1] Support animated transitions when performing a data interaction operation
​https://bugs.webkit.org/show_bug.cgi?id=169805
<rdar://problem/31045767>

Reviewed by Beth Dakin and Megan Gardner.

Source/WebCore:

When performing a snapshot excluding the current selection, use ScrollableArea::visibleContentRect to compute
the visible content rect rather than FrameView::visualViewportRect. In WebKit1, the latter will return the
entire content view's bounds.

  • page/TextIndicator.cpp:

(WebCore::takeSnapshots):

Source/WebKit/mac:

Adds WebKit1 support for animated transitions when performing a data interaction operation. See per-method changes
for more details.

  • DOM/DOMElement.h:
  • DOM/DOMElement.mm:

(-[DOMElement boundsInRootViewSpace]):

Introduce -[DOMElement boundsInRootViewSpace], which returns the bounds of the element in root view coordinates.

  • WebCoreSupport/WebDragClient.h:

(): Deleted.

  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::didConcludeEditDrag):

Add boilerplate plumbing.

  • WebView/WebView.mm:

(-[WebUITextIndicatorData initWithImage:textIndicatorData:scale:]):

Add contentImageWithoutSelection and contentImageWithoutSelectionRectInRootViewCoordinates to WebUITextIndicatorData.

(floatRectsForCGRectArray):
(-[WebView _createImageWithPlatterForImage:boundingRect:contentScaleFactor:clippingRects:]):

Introduces a SPI helper method in WebView that clients can use to generate an image of a text platter given an
image of some text, as well as clipping rects to apply to the image.

(-[WebView _dataOperationTextIndicator]):

Add SPI to fetch the text indicator used to drive animations for the current data operation.

(-[WebView _didConcludeEditDataInteraction]):

  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
11:54 AM Changeset in webkit [214110] by hyatt@apple.com
  • 12 edits
    8 adds in trunk

Initial letter does not paginate properly.
​https://bugs.webkit.org/show_bug.cgi?id=169795
<rdar://problem/23715770>

Reviewed by Zalan Bujtas.

Source/WebCore:

Tests: fast/css-generated-content/initial-letter-pagination-raised.html

fast/css-generated-content/initial-letter-pagination-raised-rl.html
fast/css-generated-content/initial-letter-pagination-sunken.html
fast/css-generated-content/initial-letter-pagination-sunken-rl.html

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::FloatingObject):
(WebCore::FloatingObject::copyToNewContainer):
(WebCore::FloatingObject::cloneForNewParent):
(WebCore::FloatingObject::translationOffsetToAncestor):

  • rendering/FloatingObjects.h:

(WebCore::FloatingObject::setMarginOffset):
(WebCore::FloatingObject::locationOffsetOfBorderBox):
(WebCore::FloatingObject::marginOffset):
Add the margin offset to the FloatingObject so that we can control the
placement of the border box relative to the margin box without relying
on only the CSS-specified margins. This allows for sunken initial letter
FloatingObjects to be created and propagated out to ancestor blocks for painting
without altering the CSS margins of the sunken letter.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustForUnsplittableChild):
Update the logical height for initial letter containers after the initial
letter shifts to the next page, since the lines that follow need to lay out
relative to the initial letter, i.e., they shift down if it shifts down.

(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
Patched to use the new helpers on FloatingObject rather than
xPositionForFloatIncludingMargins and yPositionForFloatIncludingMargins.

(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
Updated to set the placement and margins of the floating object before
returning. The initial letter adjustments have been factored out into their
own function.

(WebCore::RenderBlockFlow::adjustInitialLetterPosition):
A helper function called by computeLogicalLocationForFloat that handles
the placement and margin adjustments for initial letters. Note that sunken
letters no longer "hack" the top margin of the child but instead rely on
the fact that the FloatingObject has its own independent margin offset now
that can be set to a value that is distinct from the CSS supplied margin.

(WebCore::RenderBlockFlow::positionNewFloats):
Revised to no longer do the placement, but to let computeLogicalLocationForFloat
do it. The height is still set here however, since we don't know that until after
the child has received a layout.

(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):
Patched to use the new FloatingObject helpers rather than
xPositionForFloatIncludingMargins and yPositionForFloatIncludingMargins.

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::setLogicalMarginsForFloat):
New helper function for setting the margin offsets on a FloatingObject.

(WebCore::RenderBlockFlow::xPositionForFloatIncludingMargin): Deleted.
(WebCore::RenderBlockFlow::yPositionForFloatIncludingMargin): Deleted.
Deleted in favor of new FloatingObject helpers.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::isUnsplittableForPagination):
Make initial letter unsplittable as far as pagination is concerned.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::fitsToGlyphs):
Turn off the restriction that you can't fit to vertical glyphs. The numbers returned
are fine now. This allows vertical initial letters to work.

LayoutTests:

  • fast/css-generated-content/initial-letter-pagination-raised-expected.html: Added.
  • fast/css-generated-content/initial-letter-pagination-raised.html: Added.
  • fast/css-generated-content/initial-letter-pagination-sunken-expected.html: Added.
  • fast/css-generated-content/initial-letter-pagination-sunken.html: Added.
  • platform/ios-simulator/TestExpectations:
10:58 AM Changeset in webkit [214109] by fpizlo@apple.com
  • 12 edits
    2 adds in trunk/Source

Air should be powerful enough to support Tmp-splitting
​https://bugs.webkit.org/show_bug.cgi?id=169515

Reviewed by Saam Barati.

Source/JavaScriptCore:

In the process of implementing the Tmp-splitting optimization, I made some small
clean-ups. They don't affect anything - it's basically moving code around and adding
utility functions.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::allocate): testb3 was sometimes failing its checkDoesNotUseInstruction check because of uninitialized memory. This initializes the internal fragmentation slop of every JIT allocation.

  • b3/air/AirAllocateRegistersByGraphColoring.cpp:
  • b3/air/AirAllocateRegistersByGraphColoring.h:

(JSC::B3::Air::useIRC): It's useful to be able to query which register allocator we're using.

  • b3/air/AirArg.cpp:

(WTF::printInternal):

  • b3/air/AirArg.h:

(JSC::B3::Air::Arg::temperature): The temperature of a role is a useful concept to have factored out.

  • b3/air/AirBreakCriticalEdges.cpp: Added.

(JSC::B3::Air::breakCriticalEdges): I was surprised that we didn't have this already. It's a pretty fundamental CFG utility.

  • b3/air/AirBreakCriticalEdges.h: Added.
  • b3/air/AirGenerate.cpp:
  • b3/air/AirInsertionSet.h: You can't use & if you want copy-constructibility, which seems to be a prerequisite to IndexMap<BasicBlock, InsertionSet>.

(JSC::B3::Air::InsertionSet::InsertionSet):
(JSC::B3::Air::InsertionSet::code):

  • b3/air/AirLiveness.h: Teach Liveness to track only warm liveness.

(JSC::B3::Air::TmpLivenessAdapter::acceptsRole):
(JSC::B3::Air::StackSlotLivenessAdapter::acceptsRole):
(JSC::B3::Air::RegLivenessAdapter::acceptsRole):
(JSC::B3::Air::AbstractLiveness::AbstractLiveness):
(JSC::B3::Air::AbstractLiveness::LocalCalc::execute):

Source/WTF:

Teach IndexMap how to handle types that don't have a default constructor. This makes it
easy to create a IndexMap<BasicBlock, InsertionSet>, which is a super powerful
construct.

  • wtf/IndexMap.h:

(WTF::IndexMap::IndexMap):
(WTF::IndexMap::resize):
(WTF::IndexMap::clear):

10:16 AM Changeset in webkit [214108] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

RealtimeIncomingAudioSource is not stopping properly
​https://bugs.webkit.org/show_bug.cgi?id=169807

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-17
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/release-after-getting-track.html

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::~RealtimeIncomingAudioSource):
(WebCore::RealtimeIncomingAudioSource::stopProducingData):

LayoutTests:

  • webrtc/release-after-getting-track-expected.txt: Added.
  • webrtc/release-after-getting-track.html: Added.
10:09 AM Changeset in webkit [214107] by bshafiei@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

8:57 AM Changeset in webkit [214106] by achristensen@apple.com
  • 8 edits in trunk/Source

Use completion handlers instead of return values for sending websocket data
​https://bugs.webkit.org/show_bug.cgi?id=169802

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No change in behavior, but this is a baby step towards making things more asynchronous.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::processOutgoingFrameQueue):
(WebCore::WebSocketChannel::sendFrame):

  • Modules/websockets/WebSocketChannel.h:
  • platform/network/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandle::send):

  • platform/network/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleImpl.h:

Source/WebKit2:

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::sendWebSocketMessage):
(WebKit::WebSocketServerConnection::sendHTTPResponseHeader):
(WebKit::WebSocketServerConnection::sendRawData):

7:11 AM Changeset in webkit [214105] by zandobersek@gmail.com
  • 7 edits in trunk/Source/WebCore

WebGPU: build fixes for non-Cocoa platforms
​https://bugs.webkit.org/show_bug.cgi?id=169781

Reviewed by Alex Christensen.

Enable building WebGPU code for other ports and fix various build
failures. This still leaves the GPUDevice::platformLayer() method
missing for other ports, as well as the general implementation of
the WebGPU platform abstractions under platform/graphics/gpu/.

  • CMakeLists.txt: Move the WebGPU build targets here.
  • PlatformMac.cmake:
  • html/canvas/WebGPULibrary.h: Explicitly include the WTFString.h

header to suppress missing WTF::String definition errors.

  • platform/graphics/gpu/GPUBuffer.cpp:

(WebCore::GPUBuffer::contents): Avoid ambiguous calls to
ArrayBuffer::create() by passing nullptr as the first argument.

  • platform/graphics/gpu/GPUDevice.h: Include the Forward.h header

to forward-declare the WTF::String class. Also remove the unused
PlatformGPUDevice typedef for non-Cocoa platforms.
(WebCore::GPUDevice::layer): Move this and the related m_layer
member variable under the PLATFORM(COCOA) guard.

  • platform/graphics/gpu/GPUFunction.cpp:

(WebCore::GPUFunction::GPUFunction): Remove the GPULibrary
parameter checks in this no-op constructor that's used on
non-Cocoa platforms.

6:13 AM Changeset in webkit [214104] by tpopela@redhat.com
  • 5 edits in trunk/Source/WebKit2

Fix uninitialized public members in WebProcess
​https://bugs.webkit.org/show_bug.cgi?id=169604

Reviewed by Michael Catanzaro.

Found by Coverity scan.

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePluginX11::NetscapePluginX11):

5:22 AM Changeset in webkit [214103] by magomez@igalia.com
  • 7 edits
    2 adds in trunk

Follow-up (r213833): write a layout test for 169199
​https://bugs.webkit.org/show_bug.cgi?id=169576
<rdar://problem/31024766>

Reviewed by Said Abou-Hallawa.

Source/WebCore:

Add a function to Internals to force the deletion of the ImageDecoder just after
requesting the async decoding of a frame, and implement that behaviour in BitmapImage.

Test: fast/images/clear-animation-decoder.html

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::internalStartAnimation):

  • platform/graphics/BitmapImage.h:
  • testing/Internals.cpp:

(WebCore::Internals::setClearDecoderAfterAsyncFrameRequestForTesting):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Add a test that ensures there's no crash when deleting the ImageDecoder after requesting
an async decoding operation.

  • fast/images/clear-animation-decoder-expected.txt: Added.
  • fast/images/clear-animation-decoder.html: Added.
2:46 AM Changeset in webkit [214102] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark mediastream and webrtc new failures.

  • platform/gtk/TestExpectations:
2:45 AM Changeset in webkit [214101] by tpopela@redhat.com
  • 3 edits in trunk/Source/WebKit2

Fix uninitialized public members in NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=169598

Reviewed by Alex Christensen.

Found by Coverity scan.

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:
1:22 AM Changeset in webkit [214100] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[Cairo] Handle the blend mode in GraphicsContext::drawPattern
​https://bugs.webkit.org/show_bug.cgi?id=169746

Reviewed by Žan Doberšek.

We are not taking into account the blend mode when passing the cairo operator to drawPatternToCairoContext().
This is based on patch by Žan Doberšek, just adding the toCairoOperator changes to make it easier to handle
it. Instead of checking everywhere if blend mode is Normal to decide whether to use toCairoOperator with
CompositeOperator or BlendMode, there's no a single toCairoOperator that receives both parameters, but BlendMode
is optional and defaults to Normal.

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::toCairoCompositeOperator):
(WebCore::toCairoOperator):

  • platform/graphics/cairo/CairoUtilities.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::drawPattern):

Note: See TracTimeline for information about the timeline view.