Timeline

Mar 28, 2017:

11:15 PM Changeset in webkit [214531] by sbarati@apple.com

• 51 edits in trunk/Source/JavaScriptCore

AssemblyHelpers should not have a VM field
​https://bugs.webkit.org/show_bug.cgi?id=170207

Reviewed by Yusuke Suzuki.

APIs that need VM should take one as a parameter. When doing position
independent code for Wasm, we can't tie code generation to a VM.

• b3/B3Compile.cpp:

(JSC::B3::compile):

• b3/air/testair.cpp:
• b3/testb3.cpp:

(JSC::B3::testEntrySwitchSimple):
(JSC::B3::testEntrySwitchNoEntrySwitch):
(JSC::B3::testEntrySwitchWithCommonPaths):
(JSC::B3::testEntrySwitchWithCommonPathsAndNonTrivialEntrypoint):
(JSC::B3::testEntrySwitchLoop):

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateWithGuard):
(JSC::AccessCase::generateImpl):

• bytecode/DOMJITAccessCasePatchpointParams.cpp:

(JSC::SlowPathCallGeneratorWithArguments::generateImpl):

• bytecode/InlineAccess.cpp:

(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):
(JSC::InlineAccess::rewireStubAsJump):

• bytecode/InlineAccess.h:
• bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::emitExplicitExceptionHandler):
(JSC::PolymorphicAccess::regenerate):

• bytecode/PolymorphicAccess.h:

(JSC::AccessGenerationState::AccessGenerationState):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::exceptionCheck):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::exceptionCheckWithCallFrameRollback):
(JSC::DFG::JITCompiler::fastExceptionCheck):
(JSC::DFG::JITCompiler::vm):

• dfg/DFGOSRExitCompiler.cpp:
• dfg/DFGOSRExitCompiler.h:
• dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget):

• dfg/DFGOSRExitCompilerCommon.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::compileInstanceOfForObject):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(JSC::DFG::SpeculativeJIT::compileGetGlobalObject):
(JSC::DFG::SpeculativeJIT::compileNewFunctionCommon):
(JSC::DFG::SpeculativeJIT::compileCreateActivation):
(JSC::DFG::SpeculativeJIT::compileCreateDirectArguments):
(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileNukeStructureAndSetButterfly):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
(JSC::DFG::SpeculativeJIT::compileStoreBarrier):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSObjectWithKnownSize):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):
(JSC::DFG::SpeculativeJIT::emitAllocateVariableSizedJSObject):
(JSC::DFG::SpeculativeJIT::emitAllocateDestructibleObject):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNullOrUndefined):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNullOrUndefined):
(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):

• dfg/DFGThunks.cpp:

(JSC::DFG::osrEntryThunkGenerator):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

• ftl/FTLJITFinalizer.h:
• ftl/FTLLazySlowPath.cpp:

(JSC::FTL::LazySlowPath::generate):

• ftl/FTLLazySlowPathCall.h:

(JSC::FTL::createLazyCallGenerator):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileNotifyWrite):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::compileIsObjectOrNull):
(JSC::FTL::DFG::LowerDFGToB3::compileIsFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeCreateActivation):
(JSC::FTL::DFG::LowerDFGToB3::compileCheckTraps):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::allocateObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::buildTypeOf):

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

• ftl/FTLSlowPathCall.h:

(JSC::FTL::callOperation):

• ftl/FTLState.h:

(JSC::FTL::State::vm):

• ftl/FTLThunks.cpp:

(JSC::FTL::genericGenerationThunkGenerator):
(JSC::FTL::slowPathCallThunkGenerator):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::jitReleaseAssertNoException):
(JSC::AssemblyHelpers::callExceptionFuzz):
(JSC::AssemblyHelpers::emitJumpIfException):
(JSC::AssemblyHelpers::emitExceptionCheck):
(JSC::AssemblyHelpers::emitNonPatchableExceptionCheck):
(JSC::AssemblyHelpers::emitLoadStructure):
(JSC::AssemblyHelpers::emitRandomThunk):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::emitConvertValueToBoolean):
(JSC::AssemblyHelpers::debugCall):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::AssemblyHelpers):
(JSC::AssemblyHelpers::codeBlock):
(JSC::AssemblyHelpers::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::barrierBranch):
(JSC::AssemblyHelpers::barrierStoreLoadFence):
(JSC::AssemblyHelpers::mutatorFence):
(JSC::AssemblyHelpers::storeButterfly):
(JSC::AssemblyHelpers::nukeStructureAndStoreButterfly):
(JSC::AssemblyHelpers::jumpIfMutatorFenceNotNeeded):
(JSC::AssemblyHelpers::emitAllocateJSObjectWithKnownSize):
(JSC::AssemblyHelpers::emitAllocateJSObject):
(JSC::AssemblyHelpers::emitAllocateVariableSizedCell):
(JSC::AssemblyHelpers::emitAllocateVariableSizedJSObject):
(JSC::AssemblyHelpers::emitAllocateDestructibleObject):
(JSC::AssemblyHelpers::vm): Deleted.
(JSC::AssemblyHelpers::debugCall): Deleted.

• jit/CCallHelpers.cpp:

(JSC::CCallHelpers::ensureShadowChickenPacket):

• jit/CCallHelpers.h:

(JSC::CCallHelpers::CCallHelpers):
(JSC::CCallHelpers::jumpToExceptionHandler):

• jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileExceptionHandlers):

• jit/JIT.h:

(JSC::JIT::exceptionCheck):
(JSC::JIT::exceptionCheckWithCallFrameRollback):

• jit/JITMathIC.h:

(JSC::JITMathIC::generateOutOfLine):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):

• jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):
(JSC::JSInterfaceJIT::vm):

• jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::linkPolymorphicCall):
(JSC::resetGetByID):
(JSC::resetPutByID):

• jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

• jit/SetupVarargsFrame.h:
• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::loadArgumentWithSpecificClass):

• jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkPolymorphicCallThunkGenerator):
(JSC::virtualThunkFor):
(JSC::nativeForGenerator):
(JSC::randomThunkGenerator):
(JSC::boundThisNoArgsFunctionCallGenerator):
(JSC::throwExceptionFromWasmThunkGenerator):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompile):

• wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToJs):
(JSC::Wasm::wasmToWasm):

11:07 PM Changeset in webkit [214530] by jmarcell@apple.com

• 2 edits in trunk/Tools

Fix index-expected.txt for dashboard test results.
​https://bugs.webkit.org/show_bug.cgi?id=170214

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt:

10:32 PM Changeset in webkit [214529] by keith_miller@apple.com

• 9 edits
  2 adds in trunk/Source/JavaScriptCore

WebAssembly: We should have Origins
​https://bugs.webkit.org/show_bug.cgi?id=170217

Reviewed by Mark Lam.

This patch adds wasm origins for B3::Values, called OpcodeOrigin. Currently,
OpcodeOrigin just tracks the original opcode and the location of that opcode.

Here's a sample:

BB#0: ; frequency = 1.000000

Int64 @4 = Patchpoint(generator = 0x10f487fa8, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = SomeRegister)
Int64 @5 = FramePointer()
Void @8 = Store(@4, @5, offset = 24, ControlDependent|Writes:Top)
Int64 @10 = Const64(0)
Void @12 = Store($0(@10), @5, offset = 16, ControlDependent|Writes:Top)
Int64 @13 = Patchpoint(generator = 0x10f4be7f0, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = SomeRegister, ExitsSideways|ControlDependent|WritesPinned|ReadsPinned|Fence|Writes:Top|Reads:Top)
Int64 @16 = ArgumentReg(%rdi)
Int64 @18 = ArgumentReg(%rsi)
Int32 @22 = Trunc(@18, Wasm: {opcode: I64Rotl, location: 5})
Int64 @23 = RotL(@16, @22, Wasm: {opcode: I64Rotl, location: 5})
Void @27 = Return(@23, Terminal, Wasm: {opcode: End, location: 6})

• JavaScriptCore.xcodeproj/project.pbxproj:
• b3/B3Value.cpp:

(JSC::B3::Value::deepDump):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::setParser):
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::emitLoadOp):
(JSC::Wasm::B3IRGenerator::emitStoreOp):
(JSC::Wasm::B3IRGenerator::addConstant):
(JSC::Wasm::B3IRGenerator::addLoop):
(JSC::Wasm::B3IRGenerator::unify):
(JSC::Wasm::parseAndCompile):
(JSC::Wasm::B3IRGenerator::emitChecksForModOrDiv):
(JSC::Wasm::getMemoryBaseAndSize): Deleted.

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser::currentOpcode):
(JSC::Wasm::FunctionParser::currentOpcodeStartingOffset):
(JSC::Wasm::FunctionParser<Context>::FunctionParser):

• wasm/WasmOpcodeOrigin.cpp: Added.

(JSC::Wasm::OpcodeOrigin::dump):

• wasm/WasmOpcodeOrigin.h: Added.

(JSC::Wasm::OpcodeOrigin::OpcodeOrigin):

• wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::setParser):

• wasm/generateWasmB3IRGeneratorInlinesHeader.py:

(CodeGenerator.generate):
(generateB3OpCode):
(generateConstCode):

9:13 PM Changeset in webkit [214528] by jmarcell@apple.com

• 2 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r214240. rdar://problem/31178794

9:09 PM Changeset in webkit [214527] by commit-queue@webkit.org

• 9 edits in trunk

[WebRTC] After r214441 addIceCandidate no longer accepts an RTCIceCandidateInit dictionary
​https://bugs.webkit.org/show_bug.cgi?id=170192

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-28
Reviewed by Jon Lee.

Source/WebCore:

Covered by updated tests.

• Modules/mediastream/RTCIceCandidate.idl: Candidate is no longer a required field in RTCIceCandidateInit.
• Modules/mediastream/RTCPeerConnectionInternals.js: Reworking defaultsToNull to handle both undefined and null cases.

LayoutTests:

• fast/mediastream/RTCIceCandidate-expected.txt:
• fast/mediastream/RTCIceCandidate.html: Removing no longer valid tests.
• fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
• fast/mediastream/RTCPeerConnection-addIceCandidate.html: Adding more tests to cover null/undefined cases.

Ensuring sdpMid has a valid value.

• fast/mediastream/resources/promise-utils.js: Improving error logging.

9:02 PM Changeset in webkit [214526] by jfbastien@apple.com

• 3 edits in trunk/Source/JavaScriptCore

WebAssembly: option to crash if no fast memory is available
​https://bugs.webkit.org/show_bug.cgi?id=170219

Reviewed by Mark Lam.

• runtime/Options.h:
• wasm/WasmMemory.cpp:

(JSC::Wasm::webAssemblyCouldntGetFastMemory):
(JSC::Wasm::tryGetFastMemory):

8:51 PM Changeset in webkit [214525] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

LibWebRTCProvider should allow setting encoder and decoder factories
​https://bugs.webkit.org/show_bug.cgi?id=170212

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-28
Reviewed by Eric Carlson.

No change of behavior.
Adding the ability to set encoder/decoder libwebrtc factory getters.
Setting default cocoa factory getters.

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::staticFactoryAndThreads):
(WebCore::initializePeerConnectionFactoryAndThreads):
(WebCore::LibWebRTCProvider::setDecoderFactoryGetter):
(WebCore::LibWebRTCProvider::setEncoderFactoryGetter):
(WebCore::LibWebRTCProvider::setPeerConnectionFactory):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:

8:50 PM Changeset in webkit [214524] by mitz@apple.com

• 7 copies
  1 add in releases/Apple/iOS 10.3

Added a tag for iOS 10.3.

8:49 PM Changeset in webkit [214523] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/Safari 10.1

Added a tag for Safari 10.1.

8:28 PM Changeset in webkit [214522] by jmarcell@apple.com

• 3 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r214374. rdar://problem/31249971

8:28 PM Changeset in webkit [214521] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-603-branch

Merge r214365. rdar://problem/30922115

8:28 PM Changeset in webkit [214520] by jmarcell@apple.com

• 5 edits in branches/safari-603-branch

Merge r214194. rdar://problem/31101594

8:28 PM Changeset in webkit [214519] by jmarcell@apple.com

• 5 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r212310. rdar://problem/30922106

8:28 PM Changeset in webkit [214518] by jmarcell@apple.com

• 5 edits in branches/safari-603-branch

Merge r214237. rdar://problem/31178134

8:28 PM Changeset in webkit [214517] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-603-branch

Merge r214232. rdar://problem/30922105

8:28 PM Changeset in webkit [214516] by jmarcell@apple.com

• 3 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r213966. rdar://problem/31178551

8:28 PM Changeset in webkit [214515] by jmarcell@apple.com

• 3 edits
  2 adds in branches/safari-603-branch

Merge r211645. rdar://problem/30922105

6:56 PM Changeset in webkit [214514] by BJ Burg

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: keyboard shortcuts with directionality need to be flipped (forward/back, etc)
​https://bugs.webkit.org/show_bug.cgi?id=165761

Reviewed by Matt Baker.

Original patch by Devin Rousso.

• UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser):

• UserInterface/Views/TabBrowser.js:

(WebInspector.TabBrowser):
Flip the functionality of keyboard shortcuts when in RTL so that the action of
pressing the left or right arrows/curly braces matches what happens when the
corresponding left or right buttons are clicked.

• UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._keyDown):

• UserInterface/Views/TreeOutline.js:

(WebInspector.TreeOutline.prototype._treeKeyDown):
Flip the Left and Right keyboard shortcuts to expand/collapse the selected item when in RTL.

6:32 PM Changeset in webkit [214513] by ap@apple.com

• 2 edits in trunk/Tools

Bot watcher's dashboard has separate settings for "mac" and "macos"
​https://bugs.webkit.org/show_bug.cgi?id=170164

Reviewed by Tim Horton.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:

(Settings.prototype.parsePlatformFamily): Aded a special case for "macos".

6:31 PM Changeset in webkit [214512] by ap@apple.com

• 4 edits in trunk/Tools

Fix dashboard test results on the dashboard
​https://bugs.webkit.org/show_bug.cgi?id=170158

Reviewed by Tim Horton.

Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
further improved, as it's not super readable, but stdio is entirely useless in this context.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Fixed a typo in step name, so that it's actually treated as productive.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update):
(BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
Added special handling for dashboard test results.

6:14 PM Changeset in webkit [214511] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Stop overriding scroll view inset defaults
​https://bugs.webkit.org/show_bug.cgi?id=170221
<rdar://problem/31260325>

Reviewed by Simon Fraser.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
The default behavior is sufficient for us.

6:00 PM Changeset in webkit [214510] by Brent Fulgham

• 6 edits
  2 adds in trunk

Only attach Attributes to a given element one time
​https://bugs.webkit.org/show_bug.cgi?id=170125
<rdar://problem/31279676>

Reviewed by Chris Dumez.

Source/WebCore:

Attach the attribute node to the Element before calling 'setAttributeInternal', since that method may cause
arbitrary JavaScript events to fire.

Test: fast/dom/Attr/only-attach-attr-once.html

• dom/Element.cpp:

(WebCore::Element::attachAttributeNodeIfNeeded): Added.
(WebCore::Element::setAttributeNode): Use new method. Revise to attach attribute before calling 'setAttributeInternal'.
(WebCore::Element::setAttributeNodeNS): Ditto.

• dom/Element.h:

LayoutTests:

• fast/dom/Attr/make-unique-element-data-while-replacing-attr-expected.txt: Rebaselined.
• fast/dom/Attr/make-unique-element-data-while-replacing-attr.html: Add check before setting new value.
• fast/dom/Attr/only-attach-attr-once-expected.txt: Added.
• fast/dom/Attr/only-attach-attr-once.html: Added.

5:43 PM Changeset in webkit [214509] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

The Mutator should not be able to steal the conn if the Collector hasn't reached the NotRunning phase yet.
​https://bugs.webkit.org/show_bug.cgi?id=170213
<rdar://problem/30755345>

Reviewed by Filip Pizlo.

The current condition for stealing the conn isn't tight enough. Restricting the
stealing to when m_currentPhase == NotRunning ensures that the Collector is
really done running.

No test because this issue only manifests with a race condition that is difficult
to reproduce on demand.

• heap/Heap.cpp:

(JSC::Heap::requestCollection):

5:06 PM Changeset in webkit [214508] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Stop RTCDataChannel when closing page
​https://bugs.webkit.org/show_bug.cgi?id=170166

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-28
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/datachannel/datachannel-gc.html

Making RTCDataChannel an ActiveDOMObject.
Closing the data channel backend and freeing upon close and stop.

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):
(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::close):
(WebCore::RTCDataChannel::stop):

• Modules/mediastream/RTCDataChannel.h:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCPeerConnection.h:

LayoutTests:

• webrtc/datachannel/datachannel-gc-expected.txt: Added.
• webrtc/datachannel/datachannel-gc.html: Added.

4:53 PM Changeset in webkit [214507] by mmaxfield@apple.com

• 12 edits
  2 adds in trunk

Ranges for variation font properties are not enforced
​https://bugs.webkit.org/show_bug.cgi?id=169979

Reviewed by David Hyatt.

Source/WebCore:

The spec specifies that:

• Font weights less than or equal to 0, or greater than or equal to 1000 are parse errors
• Font stretch values less than or equal to 0% are parse errors
• Font style values less than or equal to -90deg or greater than or equal to 90deg are parse errors

Test: fast/text/variations/out-of-bounds-selection-properties.html

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontWeightRange):
(WebCore::fontStretchIsWithinRange):
(WebCore::consumeFontStretch):
(WebCore::consumeFontStretchRange):
(WebCore::fontStyleIsWithinRange):
(WebCore::consumeFontStyle):
(WebCore::consumeFontStyleRange):

LayoutTests:

• fast/text/font-selection-font-face-parse-expected.txt:
• fast/text/font-selection-font-face-parse.html:
• fast/text/font-selection-font-loading-api-parse-expected.txt:
• fast/text/font-selection-font-loading-api-parse.html:
• fast/text/font-style-parse-expected.txt:
• fast/text/font-style-parse.html:
• fast/text/variations/font-loading-api-parse-ranges-expected.txt:
• fast/text/variations/font-loading-api-parse-ranges.html:
• fast/text/variations/out-of-bounds-selection-properties-expected.txt: Added.
• fast/text/variations/out-of-bounds-selection-properties.html: Added.
• platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:

4:50 PM Changeset in webkit [214506] by aestes@apple.com

• 4 edits
  1 add in trunk

[iOS] Crash in -[WebPreviewLoader failed] when running http/tests/multipart/policy-ignore-crash.php
​https://bugs.webkit.org/show_bug.cgi?id=170197
<rdar://problem/30314067>

Reviewed by Brady Eidson.

Source/WebCore:

If QuickLook conversion fails, we call ResourceLoader::didFail() with the NSError from
QuickLook, which will call back into PreviewLoader::didFail(). We only care about network
failures in PreviewLoader, not conversion failures, so check if
m_finishedLoadingDataIntoConverter is set before continuing (like we do in
PreviewLoader::didFinishLoading()).

Fixes crash in http/tests/multipart/policy-ignore-crash.php.

• loader/ios/PreviewLoader.mm:

(WebCore::PreviewLoader::didFail):

LayoutTests:

• platform/ios/TestExpectations: Unskipped http/tests/multipart/policy-ignore-crash.php.
• platform/ios/http/tests/multipart/policy-ignore-crash-expected.txt: Added an iOS-specific result.

4:12 PM Changeset in webkit [214505] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Audio indicator is visible on uni-watch.com but there is no audible audio
​https://bugs.webkit.org/show_bug.cgi?id=170200
<rdar://problem/31289132>

Reviewed by Eric Carlson.

Cherry-pick the following patch from Blink by <​rtoy@chromium.org>:

• ​https://chromium.googlesource.com/chromium/src.git/+/439de5bb2a31384666db1a0e2dadb2b97d2f3ce4

When the gain of a GainNode is 0 or 1, the operation of the node can
be optimized. When gain = 1, just copy the input to the output. When
gain = 0; just zero out the output. Currently, the input is
multiplied by the gain to produce the output. This just optimizes the
multiplication away for the two special cases.

Also, have the GainNode set the silence hint if the gain is 0.

And fix a bug in processIfNecessary when unsilenceOutputs was causing the
silence hint to be cleared after the node's process method was finished
and may have set the silence hint. The processing should come after
unsilenceOutputs to preserve any hints from processing the node.

• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::processIfNecessary):

• Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::process):

• platform/audio/AudioBus.cpp:

(WebCore::AudioBus::copyWithGainFrom):

4:12 PM Changeset in webkit [214504] by keith_miller@apple.com

• 45 edits
  2 copies
  2 moves
  5 adds in trunk

WebAssembly: Make WebAssembly.instantiate/compile truly asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=169187

Reviewed by Saam Barati.

JSTests:

• wasm/assert.js:
• wasm/js-api/Module-compile.js:

(async.testPromiseAPI):

• wasm/js-api/web-assembly-compile-parallel.js: Added.

(async.throwExn):
(async.test):

• wasm/js-api/web-assembly-instantiate-parallel.js: Added.

(async.test):

• wasm/js-api/web-assembly-instantiate.js:

(assert.eq.async.test):
(assert.eq):
(assert.asyncTest.async.test):
(assert.asyncTest):
(assert.truthy.async.test): Deleted.
(assert.truthy): Deleted.

Source/JavaScriptCore:

This patch allows WebAssembly compilations to happen asynchronously.
To do so, it refactors how much of the compilation happens and adds
new infrastructure for async promises.

First, there is a new class, PromiseDeferredTimer that lives on
the VM. PromiseDeferredTimer will manage the life-cycle of async
pending promises and any dependencies that promise
needs. PromiseDeferredTimer automagically releases the pending
promise and dependencies once the JSPromiseDeferred is resolved or
rejected. Additionally, PromiseDeferredTimer provides a mechanism
to poll the run-loop whenever the async task needs to synchronize
with the JS thread. Normally, that will be whenever the async task
finishes. In the case of Web Assembly we also use this feature for
the compile + instantiate case, where we might have more work
after the first async task completes (more on that later).

The next class is Wasm::Worklist, which is used to manage Wasm
compilation tasks. The worklist class works similarly to the
DFG/FTL Worklists. It has a pool of threads that it manages. One
interesting aspect of Wasm Worklist is that it can synchronously
compile a plan that is already potentially running
asynchronously. This can occur if a user calls
WebAssembly.instantiate() then new WebAssembly.instantiate() on
the same module. In that case the Wasm Worklist will bump the
priority of the running pending Plan and block the JS thread.

This patch also makes some of the Wasm Plan code cleaner. Since we
now defer all compilation to instantiation time, we no longer need
to guess at which memory we are going to get. Also, Wasm Plans now
track the work they have done with a state enum.

Finally, this patch makes renamed HeapTimer to JSRunLoopTimer. It
also adds changes test262AsyncTest to a more generic testing
infrastructure. Now, in addition to the old functionality, you can
call asyncTest() with the number of tests you expect. When the jsc
CLI exits, it will guarantee that asyncTestPassed() is called that
many times.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• heap/GCActivityCallback.h:
• heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::scheduleTimer):
(JSC::IncrementalSweeper::IncrementalSweeper):

• heap/IncrementalSweeper.h:
• heap/StopIfNecessaryTimer.cpp:

(JSC::StopIfNecessaryTimer::StopIfNecessaryTimer):

• heap/StopIfNecessaryTimer.h:
• heap/StrongInlines.h:
• jsc.cpp:

(GlobalObject::finishCreation):
(printInternal):
(functionAsyncTestStart):
(functionAsyncTestPassed):
(functionTestWasmModuleFunctions):
(CommandLine::parseArguments):
(runJSC):

• runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::resolve):
(JSC::JSPromiseDeferred::reject):

• runtime/JSPromiseDeferred.h:

(JSC::JSPromiseDeferred::promiseAsyncPending):

• runtime/JSRunLoopTimer.cpp: Renamed from Source/JavaScriptCore/heap/HeapTimer.cpp.

(JSC::JSRunLoopTimer::JSRunLoopTimer):
(JSC::JSRunLoopTimer::setRunLoop):
(JSC::JSRunLoopTimer::~JSRunLoopTimer):
(JSC::JSRunLoopTimer::timerDidFire):
(JSC::JSRunLoopTimer::scheduleTimer):
(JSC::JSRunLoopTimer::cancelTimer):
(JSC::JSRunLoopTimer::invalidate):

• runtime/JSRunLoopTimer.h: Copied from Source/JavaScriptCore/heap/HeapTimer.h.
• runtime/Options.h:
• runtime/PromiseDeferredTimer.cpp: Added.

(JSC::PromiseDeferredTimer::PromiseDeferredTimer):
(JSC::PromiseDeferredTimer::doWork):
(JSC::PromiseDeferredTimer::runRunLoop):
(JSC::PromiseDeferredTimer::addPendingPromise):
(JSC::PromiseDeferredTimer::cancelPendingPromise):
(JSC::PromiseDeferredTimer::scheduleWorkSoon):
(JSC::PromiseDeferredTimer::scheduleBlockedTask):

• runtime/PromiseDeferredTimer.h: Renamed from Source/JavaScriptCore/heap/HeapTimer.h.

(JSC::PromiseDeferredTimer::stopRunningTasks):

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):

• runtime/VM.h:
• wasm/JSWebAssembly.cpp:

(JSC::reject):
(JSC::webAssemblyCompileFunc):
(JSC::resolve):
(JSC::instantiate):
(JSC::compileAndInstantiate):
(JSC::webAssemblyInstantiateFunc):
(JSC::webAssemblyValidateFunc):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::memoryKind):
(JSC::Wasm::parseAndCompile):

• wasm/WasmB3IRGenerator.h:
• wasm/WasmFormat.h:

(JSC::Wasm::ModuleInformation::internalFunctionCount):

• wasm/WasmFunctionParser.h:
• wasm/WasmMemory.h:
• wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::MemoryInformation::MemoryInformation):

• wasm/WasmMemoryInformation.h:

(JSC::Wasm::MemoryInformation::maximum):
(JSC::Wasm::MemoryInformation::hasReservedMemory): Deleted.
(JSC::Wasm::MemoryInformation::takeReservedMemory): Deleted.
(JSC::Wasm::MemoryInformation::mode): Deleted.

• wasm/WasmModuleParser.cpp:
• wasm/WasmModuleParser.h:

(JSC::Wasm::ModuleParser::ModuleParser):

• wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::Plan):
(JSC::Wasm::Plan::stateString):
(JSC::Wasm::Plan::moveToState):
(JSC::Wasm::Plan::fail):
(JSC::Wasm::Plan::parseAndValidateModule):
(JSC::Wasm::Plan::prepare):
(JSC::Wasm::Plan::ThreadCountHolder::ThreadCountHolder):
(JSC::Wasm::Plan::ThreadCountHolder::~ThreadCountHolder):
(JSC::Wasm::Plan::compileFunctions):
(JSC::Wasm::Plan::complete):
(JSC::Wasm::Plan::waitForCompletion):
(JSC::Wasm::Plan::cancel):
(JSC::Wasm::Plan::run): Deleted.
(JSC::Wasm::Plan::initializeCallees): Deleted.

• wasm/WasmPlan.h:

(JSC::Wasm::Plan::dontFinalize):
(JSC::Wasm::Plan::exports):
(JSC::Wasm::Plan::internalFunctionCount):
(JSC::Wasm::Plan::takeModuleInformation):
(JSC::Wasm::Plan::takeCallLinkInfos):
(JSC::Wasm::Plan::takeWasmExitStubs):
(JSC::Wasm::Plan::setModeAndPromise):
(JSC::Wasm::Plan::mode):
(JSC::Wasm::Plan::pendingPromise):
(JSC::Wasm::Plan::vm):
(JSC::Wasm::Plan::errorMessage):
(JSC::Wasm::Plan::failed):
(JSC::Wasm::Plan::hasWork):
(JSC::Wasm::Plan::hasBeenPrepared):

• wasm/WasmPlanInlines.h: Copied from Source/JavaScriptCore/wasm/WasmB3IRGenerator.h.

(JSC::Wasm::Plan::initializeCallees):

• wasm/WasmValidate.cpp:
• wasm/WasmWorklist.cpp: Added.

(JSC::Wasm::Worklist::priorityString):
(JSC::Wasm::Worklist::QueueElement::setToNextPriority):
(JSC::Wasm::Worklist::iterate):
(JSC::Wasm::Worklist::enqueue):
(JSC::Wasm::Worklist::completePlanSynchronously):
(JSC::Wasm::Worklist::stopAllPlansForVM):
(JSC::Wasm::Worklist::Worklist):
(JSC::Wasm::Worklist::~Worklist):
(JSC::Wasm::existingWorklistOrNull):
(JSC::Wasm::ensureWorklist):

• wasm/WasmWorklist.h: Added.

(JSC::Wasm::Worklist::nextTicket):
(JSC::Wasm::Worklist::Comparator::operator()):

• wasm/js/JSWebAssemblyCallee.h:
• wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):
(JSC::JSWebAssemblyCodeBlock::initialize):
(JSC::JSWebAssemblyCodeBlock::isSafeToRun):

• wasm/js/JSWebAssemblyCodeBlock.h:

(JSC::JSWebAssemblyCodeBlock::create):
(JSC::JSWebAssemblyCodeBlock::initialized):
(JSC::JSWebAssemblyCodeBlock::plan):
(JSC::JSWebAssemblyCodeBlock::runnable):
(JSC::JSWebAssemblyCodeBlock::errorMessage):
(JSC::JSWebAssemblyCodeBlock::callees):

• wasm/js/JSWebAssemblyHelpers.h:

(JSC::createSourceBufferFromValue):

• wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):
(JSC::JSWebAssemblyInstance::addUnitializedCodeBlock):
(JSC::JSWebAssemblyInstance::finalizeCreation):
(JSC::JSWebAssemblyInstance::create):
(JSC::JSWebAssemblyInstance::setMemory): Deleted.

• wasm/js/JSWebAssemblyInstance.h:

(JSC::JSWebAssemblyInstance::codeBlock):
(JSC::JSWebAssemblyInstance::initialized):
(JSC::JSWebAssemblyInstance::module):
(JSC::JSWebAssemblyInstance::importFunction):
(JSC::JSWebAssemblyInstance::setMemory):
(JSC::JSWebAssemblyInstance::table):
(JSC::JSWebAssemblyInstance::importFunctions):
(JSC::JSWebAssemblyInstance::setImportFunction): Deleted.
(JSC::JSWebAssemblyInstance::setTable): Deleted.

• wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::createStub):
(JSC::JSWebAssemblyModule::JSWebAssemblyModule):
(JSC::JSWebAssemblyModule::finishCreation):
(JSC::JSWebAssemblyModule::setCodeBlock):
(JSC::JSWebAssemblyModule::buildCodeBlock): Deleted.
(JSC::JSWebAssemblyModule::create): Deleted.
(JSC::JSWebAssemblyModule::codeBlock): Deleted.

• wasm/js/JSWebAssemblyModule.h:

(JSC::JSWebAssemblyModule::moduleInformation):
(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::source):
(JSC::JSWebAssemblyModule::takeReservedMemory): Deleted.
(JSC::JSWebAssemblyModule::codeBlockFor): Deleted.

• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):
(JSC::WebAssemblyInstanceConstructor::createInstance): Deleted.

• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::WebAssemblyModuleConstructor::createModule):

• wasm/js/WebAssemblyModulePrototype.cpp:

(JSC::webAssemblyModuleProtoImports):
(JSC::webAssemblyModuleProtoExports):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::finishCreation):
(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):

• wasm/js/WebAssemblyModuleRecord.h:

4:11 PM Changeset in webkit [214503] by Chris Dumez

• 21 edits
  5 adds in trunk

Animated SVG images are not paused when outside viewport
​https://bugs.webkit.org/show_bug.cgi?id=170155
<rdar://problem/31288893>

Reviewed by Antti Koivisto.

Source/WebCore:

Make sure animated SVG images get paused when outside the viewport,
similarly to what was already done for animated GIF images. Also
make sure they are paused when they no longer have any renderers
using them.

Tests: svg/animations/animated-svg-image-outside-viewport-paused.html

svg/animations/animated-svg-image-removed-from-document-paused.html

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::didAddClient):
Restart the animation whenever a new CachedImage client is added. This
will cause us the re-evaluate if the animation should run. The animation
will pause again if the new renderer is not inside the viewport.

(WebCore::CachedImage::animationAdvanced):
Add a flag to newImageAnimationFrameAvailable() so that the renderers can
let us know if we can pause the animation. Pause the animation if all no
renderer requires it (i.e. they are all outside the viewport, or there
are no renderers).

• loader/cache/CachedImageClient.h:

(WebCore::CachedImageClient::newImageAnimationFrameAvailable):
By default, the CachedImageClients allow pausing. Only renderer will
potentially prevent pausing if they are inside the viewport.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::isAnimating):

• platform/graphics/BitmapImage.h:
• platform/graphics/Image.h:

(WebCore::Image::isAnimating):
Add isAnimating() flag on Image for layout testing purposes.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::newImageAnimationFrameAvailable):
Set canPause flag to true if the renderer is not inside the viewport.

(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded):
Call startAnimation() if the renderer is now visible to resume SVG
animations. Repainting is enough for GIF animations but not for SVG
animations, we have to explicitly resume them.

• rendering/RenderElement.h:
• rendering/RenderView.cpp:

(WebCore::RenderView::addRendererWithPausedImageAnimations):
(WebCore::RenderView::removeRendererWithPausedImageAnimations):
(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):

• rendering/RenderView.h:

Store CachedImages with the renderers that have paused animations.
This is required for SVG where we need to explicitly resume the
animation on the CachedImage when the renderer becomes visible
again. Having access to the Image will also allow us to do smarter
visibility checks in RenderElement's shouldRepaintForImageAnimation(),
in the future.

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::hasActiveAnimation):

• svg/SVGSVGElement.h:

Add hasActiveAnimation() method.

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::startAnimation):
Check that animations are paused before starting them. This avoid
jumping due to unnecessary calls to rootElement->setCurrentTime(0).

(WebCore::SVGImage::isAnimating):
Add isAnimating() method for layout tests purposes.

• svg/graphics/SVGImage.h:
• svg/graphics/SVGImageClients.h:

Call animationAdvanced() on the observer instead of the generic
changedInRect() when the SVGImage is animating. This way, we go
through the same code path as GIF animations and we end up calling
CachedImage::animationAdvanced() which calls newImageAnimationFrameAvailable()
on RenderElement, which determines if the animation should keep
running or not.

• testing/Internals.cpp:

(WebCore::Internals::isImageAnimating):

• testing/Internals.h:
• testing/Internals.idl:

Add layout testing infrastructure.

LayoutTests:

Add layout test coverage.

• platform/mac-wk1/TestExpectations:
• svg/animations/animated-svg-image-outside-viewport-paused-expected.txt: Added.
• svg/animations/animated-svg-image-outside-viewport-paused.html: Added.
• svg/animations/animated-svg-image-removed-from-document-paused-expected.txt: Added.
• svg/animations/animated-svg-image-removed-from-document-paused.html: Added.
• svg/animations/resources/smilAnimation.svg: Added.

4:00 PM Changeset in webkit [214502] by rniwa@webkit.org

• 14 edits
  1 add in trunk/Websites/perf.webkit.org

Modernize AnalysisTaskPage
​https://bugs.webkit.org/show_bug.cgi?id=170165

Reviewed by Antti Koivisto.

Modernized AnalysisTaskPage and related components. The main refactoring happened in AnalysisTaskPage
from which AnalysisTaskResultsPane and AnalysisTaskTestGroupPane have been extracted.

Decoupled BuildRequest from its results. AnalysisResultsViewer and TestGroupResultsTable now stores
a reference to AnalysisResultsView and Metric to find the results for each build request.
This refactoring is necessary in order to view results of an arbitrary metric in the future.

Also refactored ResultsTable and its subclasses extensively. Instead of making its render() to invoke
subclass' methods such as buildRowGroups, heading, and additionalHeading, rely on each subclass call
to invoke renderTable(), renamed from render(), with callbacks to add extra headers and columns.

This patch also fixes a number of usability issues found by the user such as changing the test name
resets the customized revisions by the virtue of the modern code being naturally more correct.

• public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer):
(AnalysisResultsViewer.prototype.setTestGroupCallback): Deleted. Replaced by "testGroupClick" action.
(AnalysisResultsViewer.prototype.setRangeSelectorLabels): Moved here from ResultsTable since it's
never used in ResultsTable or TestGroupResultsTable.
(AnalysisResultsViewer.prototype.selectedRange): Ditto.
(AnalysisResultsViewer.prototype.setPoints): Now takes metric as the third argument.
(AnalysisResultsViewer.prototype.setTestGroups): Now takes the current test group.
(AnalysisResultsViewer.prototype.didUpdateResults): Deleted.
(AnalysisResultsViewer.prototype.setAnalysisResultsView): Added.
(AnalysisResultsViewer.prototype.render): Invoke _renderTestGroups lazily. Also simplified the logic
to find the selected list item. Since we always use a shadow DOM now, we can simply look for an element
with ".seleted" instead of crafting a unique class name.
(AnalysisResultsViewer.prototype.renderTestGroups): Renamed from buildRowGroups. Specify callbacks to
insert headers for A/B radio buttons, which has been moved from ResultsTable.prototype.render, and the
stacked blocks of testing results.
(AnalysisResultsViewer.prototype._classForTestGroup): Deleted.
(AnalysisResultsViewer.prototype._openStackingBlock): Deleted.
(AnalysisResultsViewer.prototype._expandBetween): Create a new set for expandedPoints to make
_renderTestGroupsLazily.evaluate do the work.
(AnalysisResultsViewer._layoutBlocks): Moved from TestGroupStackingGrid.layout.
(AnalysisResultsViewer._sortBlocksByRow): Moved from AnalysisResultsViewer.TestGroupStackingGrid.
(AnalysisResultsViewer._insertAfterBlockWithSameRange): Ditto.
(AnalysisResultsViewer._insertBlockInFirstAvailableColumn): Ditto.
(AnalysisResultsViewer._createCellsForRow): Ditto.

(AnalysisResultsViewer.TestGroupStackingBlock):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.addRowIndex):
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.createStackingCell): No longer creates a unique
class name here. See the inline comment for AnalysisResultsViewer.prototype.render.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype.isThin): Deleted. We used to collapse "failed"
test groups as a thin vertical line, and we wanted to show them next to each other in _layoutBlock but
we don't do that anymore.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype._valuesForCommitSet): Added. Uses
this._analysisResultsView to extract the results for the current metrics.
(AnalysisResultsViewer.TestGroupStackingBlock.prototype._computeTestGroupStatus):

• public/v3/components/analysis-task-bug-list.js: Added.

(AnalysisTaskBugList): Added. Extracted from AnalysisTaskChartPane.
(AnalysisTaskBugList.prototype.setTask): Added.
(AnalysisTaskBugList.prototype.didConstructShadowTree): Added.
(AnalysisTaskBugList.prototype.render): Added.
(AnalysisTaskBugList.prototype._associateBug): Added.
(AnalysisTaskBugList.prototype._dissociateBug): Added.
(AnalysisTaskBugList.htmlTemplate): Added.

• public/v3/components/chart-pane-base.js:

(ChartPaneBase.htmlTemplate): Added a hook to insert more content at the end in AnalysisTaskChartPane.
(ChartPaneBase.paneFooterTemplate): Added.

• public/v3/components/customizable-test-group-form.js:

(CustomizableTestGroupForm):
(CustomizableTestGroupForm.prototype.setCommitSetMap):
(CustomizableTestGroupForm.prototype.startTesting): Renamed from _submitted. Now dispatches an action
by the name of "startTesting" instead of calling this._startCallback.
(CustomizableTestGroupForm.prototype.didConstructShadowTree): Added. Moved the logic to attach event
handlers here to avoid eagerly creating the shadow tree in the constructor.
(CustomizableTestGroupForm.prototype._computeCommitSetMap): Use the newly added this._revisionEditorMap
to find the relevant input element instead of running a querySelector.
(CustomizableTestGroupForm.prototype.render): Lazily invoke _renderCustomRevisionTable. This avoids
overriding the customized revisions when the user finally types in the test group name.
(CustomizableTestGroupForm.prototype._renderCustomRevisionTable): Extracted from render.
(CustomizableTestGroupForm.prototype._constructRevisionRadioButtons): Made this a non-static method
since it needs to update this._revisionEditorMap now. Merged _constructRevisionRadioButtons.
(CustomizableTestGroupForm.prototype._createRadioButton): Deleted. See above.
(CustomizableTestGroupForm.cssTemplate):
(CustomizableTestGroupForm.formContent): Use IDs instead of classes to make this.content(ID) work.

• public/v3/components/mutable-list-view.js:

(MutableListView.prototype.setList):
(MutableListView.prototype.setKindList):
(MutableListView.prototype.setAddCallback): Deleted. Replaced by "addItem" action.
(MutableListView.prototype.render):
(MutableListItem.prototype.content):

• public/v3/components/results-table.js:

(ResultsTable): Removed this._rangeSelectorLabels, this._rangeSelectorCallback, and this._selectedRange
as they are only used by AnalysisResultsViewer. Also replaced this._valueFormatter by
this._analysisResultsView which knows a metric.
(ResultsTable.prototype.setValueFormatter): Deleted.
(ResultsTable.prototype.setRangeSelectorLabels): Deleted.
(ResultsTable.prototype.setRangeSelectorCallback): Deleted.
(ResultsTable.prototype.selectedRange): Deleted.
(ResultsTable.prototype._rangeSelectorClicked): Deleted.
(ResultsTable.prototype.setAnalysisResultsView): Added.
(ResultsTable.prototype.renderTable): Added. Removed the logic to add _rangeSelectorLabels since it has
been moved to AnalysisResultsViewer.prototype.render inside buildColumns, which also inserts additional
columns which used to be stored on each ResultsTableRow. Use the same technique to insert additional
headers. Also take the name (thead tr th) of row header (tbody tr td) as an argument and automatically
create a table cell of an appropriate colspan.
(ResultsTable.prototype._createRevisionListCells):
(ResultsTable.prototype.heading): Deleted. Superseded by buildHeaders callback.
(ResultsTable.prototype.additionalHeading): Ditto.
(ResultsTable.prototype.buildRowGroups): Deleted. It is now the responsibility of each subclass to call
ResultsTable's renderTable() in the subclass' render() function.
(ResultsTable.prototype._computeRepositoryList): No longer takes extraRepositories as an argument.
Instead, this function now returns a pair of the repository list and the list of constant commits.
(ResultsTable.htmlTemplate):
(ResultsTable.cssTemplate):

• public/v3/components/test-group-form.js:

(TestGroupForm): Avoid eagerly creating the shadow tree. Also removed the removed the dead code.
(TestGroupForm.prototype.setRepetitionCount): Simply override the value of the select element.
(TestGroupForm.prototype.didConstructShadowTree): Added. Attach event handlers here to avoid eagerly
creating the shadow tree in the constructor.
(TestGroupForm.prototype.startTesting): Renamed from _submitted. Dispatch "startTesting" action instead
of invoking _startCallback which has been removed.
(TestGroupForm.htmlTemplate):
(TestGroupForm.formContent):

• public/v3/components/test-group-results-table.js:

(TestGroupResultsTable):
(TestGroupResultsTable.prototype.didUpdateResults): Deleted. No longer neeed per setAnalysisResultsView
in ResultsTable.
(TestGroupResultsTable.prototype.setTestGroup):
(TestGroupResultsTable.prototype.heading): Deleted.
(TestGroupResultsTable.prototype.render):
(TestGroupResultsTable.prototype._renderTestGroup): Extracted from render.
(TestGroupResultsTable.prototype._buildRowGroups): Renamed from buildRowGroups.
(TestGroupResultsTable.prototype._buildRowGroupForCommitSet): Extracted from buildRowGroups.
(TestGroupResultsTable.prototype._buildComparisonRow): Extracted from buildRowGroups.buildRowGroups

• public/v3/index.html: Include analysis-task-bug-list.js.

• public/v3/models/analysis-results.js:

(AnalysisResults): Inverted the map so that we can easily create a view based on metric.
(AnalysisResults.prototype.find): Ditto.
(AnalysisResults.prototype.add): Ditto.
(AnalysisResults.prototype.viewForMetric): Added.
(AnalysisResults.fetch):
(AnalysisResultsView): Added.
(AnalysisResultsView.prototype.metric): Added.
(AnalysisResultsView.prototype.resultForBuildId): Added.

• public/v3/models/build-request.js:

(BuildRequest.result): Deleted.
(BuildRequest.setResult): Deleted.

• public/v3/models/test-group.js:

(TestGroup): Removed this._allCommitSets since it was never used.
(TestGroup.prototype.didSetResult): Deleted since it was never used.
(TestGroup.prototype.compareTestResults): Now takes an array of measurement set values.
(TestGroup.prototype._valuesForCommitSet): Deleted.

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskChartPane): This class now includes the form to cutomize the revisions.
(AnalysisTaskChartPane.prototype.setShowForm): Added.
(AnalysisTaskChartPane.prototype._mainSelectionDidChange):
(AnalysisTaskChartPane.prototype.didConstructShadowTree): Added. Dispatches "newTestGroup" action when
the user presses the button to start a new A/B testing from the chart.
(AnalysisTaskChartPane.prototype.render): Added.
(AnalysisTaskChartPane.prototype.paneFooterTemplate): Added.
(AnalysisTaskChartPane.cssTemplate):

(AnalysisTaskResultsPane): Added. Encapsulates AnalysisResultsViewer and CustomizableTestGroupForm.
(AnalysisTaskResultsPane.prototype.setPoints): Added.
(AnalysisTaskResultsPane.prototype.setTestGroups): Added.
(AnalysisTaskResultsPane.prototype.setAnalysisResultsView): Added.
(AnalysisTaskResultsPane.prototype.setShowForm): Added.
(AnalysisTaskResultsPane.prototype.didConstructShadowTree): Added. Dispatches "newTestGroup" action
when the user presses the button to start a new A/B testing from the chart.
(AnalysisTaskResultsPane.prototype.render): Added.
(AnalysisTaskResultsPane.htmlTemplate): Added.
(AnalysisTaskResultsPane.cssTemplate): Added.

(AnalysisTaskTestGroupPane): Added. Encapsulates TestGroupResultsTable and CustomizableTestGroupForm.
(AnalysisTaskTestGroupPane.prototype.didConstructShadowTree): Added.
(AnalysisTaskTestGroupPane.prototype.setTestGroups): Added.
(AnalysisTaskTestGroupPane.prototype.setAnalysisResultsView): Added.
(AnalysisTaskTestGroupPane.prototype.render): Added.
(AnalysisTaskTestGroupPane.prototype._renderTestGroups): Added. Updates the list of test groups. Hide
the hidden groups unless showHiddenGroups is set. Updates this._testGroupMap so that the visibility of
groups and their names can be updated without having to re-render the entire list.
(AnalysisTaskTestGroupPane.prototype._renderTestGroupVisibility): Added.
(AnalysisTaskTestGroupPane.prototype._renderTestGroupNames): Added.
(AnalysisTaskTestGroupPane.prototype._renderCurrentTestGroup): Added. Update TestGroupResultsTable with
the selected test group. Also highlight the list view, and update the hide-unhide toggle button's label
as needed.
(AnalysisTaskTestGroupPane.htmlTemplate): Added.
(AnalysisTaskTestGroupPane.cssTemplate): Added.

(AnalysisTaskPage): Deleted a massive number of instance variables. They are now manged by newly added
AnalysisTaskChartPane, AnalysisTaskResultsPane, and AnalysisTaskTestGroupPane
(AnalysisTaskPage.prototype.didConstructShadowTree): Added. Attach various event handlers here to avoid
eagerly creating the shadow tree in the constructor.
(AnalysisTaskPage.prototype._fetchRelatedInfoForTaskId):
(AnalysisTaskPage.prototype._didFetchTask): No longer sets the value formatter to the results viewer
and the results table as they now recieve AnalysisResultsView later in _assignTestResultsIfPossible.
(AnalysisTaskPage.prototype._didFetchMeasurement): Set the metric to the results viewer.
(AnalysisTaskPage.prototype._didUpdateTestGroupHiddenState):
(AnalysisTaskPage.prototype._assignTestResultsIfPossible): Create AnalysisResultsView from the newly
retrieved AnalysisResults and pass it to AnalysisTaskResultsPane and AnalysisTaskTestGroupPane.
(AnalysisTaskPage.prototype.render): Dramatically simplified.
(AnalysisTaskPage.prototype._renderTaskNameAndStatus): Extracted from render.
(AnalysisTaskPage.prototype._renderRelatedTasks): Ditto.
(AnalysisTaskPage.prototype._renderCauseAndFixes): Ditto.
(AnalysisTaskPage.prototype._showTestGroup):
(AnalysisTaskPage.prototype._updateTaskName): Now takes the new name as an argument.
(AnalysisTaskPage.prototype._updateTestGroupName): Now takes the new name as the second argument.
(AnalysisTaskPage.prototype._hideCurrentTestGroup): Now takes the test group to hide.
(AnalysisTaskPage.prototype._associateCommit): Moved to AnalysisTaskBugList.
(AnalysisTaskPage.prototype._dissociateCommit): Ditto.
(AnalysisTaskPage.prototype._retryCurrentTestGroup): Now takes the test group as the first argument.
(AnalysisTaskPage.prototype._chartSelectionDidChange): Deleted.
(AnalysisTaskPage.prototype._createNewTestGroupFromChart): Deleted.
(AnalysisTaskPage.prototype._selectedRowInAnalysisResultsViewer): Deleted.
(AnalysisTaskPage.prototype._createNewTestGroupFromViewer): Deleted.
(AnalysisTaskPage.htmlTemplate):
(AnalysisTaskPage.cssTemplate):

• unit-tests/test-groups-tests.js: Updated a test case which was expecting BuildReqeust's result, which

has been removed, to exist.

3:48 PM Changeset in webkit [214501] by Antti Koivisto

• 3 edits
  2 adds in trunk

Missing render tree position invalidation when tearing down renderers for display:contents subtree
​https://bugs.webkit.org/show_bug.cgi?id=170199
<rdar://problem/31260856>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/shadow-dom/slot-renderer-teardown.html

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateElementRenderer):

Invalidate the render tree position in case we do a teardown for an element without renderer.

LayoutTests:

• fast/shadow-dom/slot-renderer-teardown-expected.txt: Added.
• fast/shadow-dom/slot-renderer-teardown.html: Added.

3:32 PM Changeset in webkit [214500] by Ryan Haddad

• 6 edits
  2 deletes in trunk

Unreviewed, rolling out r214485.

This change caused LayoutTest crashes.

Reverted changeset:

"Stop RTCDataChannel when closing page"
​https://bugs.webkit.org/show_bug.cgi?id=170166
​http://trac.webkit.org/changeset/214485

3:26 PM Changeset in webkit [214499] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

ApplePayShippingContactUpdate.idl shouldn't have status field
​https://bugs.webkit.org/show_bug.cgi?id=170202
rdar://problem/31307106

Reviewed by Beth Dakin.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
If status isn't set, infer it based on whether there are errors present or not.

• Modules/applepay/ApplePayShippingContactUpdate.h:

Make status optional here; it's still used by the old code path.

• Modules/applepay/ApplePayShippingContactUpdate.idl:

Remove status here.

3:16 PM Changeset in webkit [214498] by Yusuke Suzuki

• 27 edits in trunk/Source/JavaScriptCore

WebAssembly: add fallback to use pinned register to load/store state
​https://bugs.webkit.org/show_bug.cgi?id=169773

Reviewed by Saam Barati.

This patch adds a new pinned register to hold JSWebAssemblyInstance,
which is used to represent the context of running Wasm code.
While we use fast TLS to hold the context in macOS, we do not have
any system reserved fast TLS slot in the other systems. This pinned
register approach is used in these systems. These changes decouple
VM from Wasm module to make Wasm module position independent code.

While using fast TLS could be beneficial in x64 systems which number of
registers is relatively small, pinned register approach could be
beneficial in ARM64 which has plenty of registers. In macOS, we can
switch the implementation with the runtime flag. Thus macOS port can
compare the performance and decide which implementation is used after
landing this patch.

• heap/MarkedBlock.h:

(JSC::MarkedBlock::offsetOfVM):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::loadWasmContext):
(JSC::AssemblyHelpers::storeWasmContext):
(JSC::AssemblyHelpers::loadWasmContextNeedsMacroScratchRegister):
(JSC::AssemblyHelpers::storeWasmContextNeedsMacroScratchRegister):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::loadWasmContext): Deleted.
(JSC::AssemblyHelpers::storeWasmContext): Deleted.
(JSC::AssemblyHelpers::loadWasmContextNeedsMacroScratchRegister): Deleted.
(JSC::AssemblyHelpers::storeWasmContextNeedsMacroScratchRegister): Deleted.

• jit/Repatch.cpp:

(JSC::webAssemblyOwner):
(JSC::linkFor):
(JSC::linkPolymorphicCall):
(JSC::isWebAssemblyToJSCallee): Deleted.

• jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromWasmThunkGenerator):

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LowLevelInterpreter.asm:
• runtime/JSCell.cpp:

(JSC::JSCell::isAnyWasmCallee):

• runtime/JSCellInlines.h:

(JSC::isWebAssemblyToJSCallee):

• runtime/JSType.h:
• runtime/StackFrame.cpp:

(JSC::StackFrame::functionName):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

(JSC::VM::wasmContextOffset):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::materializeWasmContext):
(JSC::Wasm::B3IRGenerator::restoreWasmContext):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::getMemoryBaseAndSize):
(JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState):
(JSC::Wasm::createJSToWasmWrapper):
(JSC::Wasm::loadWasmContext): Deleted.
(JSC::Wasm::storeWasmContext): Deleted.
(JSC::Wasm::restoreWebAssemblyGlobalState): Deleted.

• wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToJs):

• wasm/WasmContext.cpp:

(JSC::loadWasmContext):
(JSC::storeWasmContext):

• wasm/WasmContext.h:
• wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::getPinnedRegisters):
(JSC::Wasm::PinnedRegisterInfo::get):
(JSC::Wasm::PinnedRegisterInfo::PinnedRegisterInfo):

• wasm/WasmMemoryInformation.h:

(JSC::Wasm::PinnedRegisterInfo::toSave):
(JSC::Wasm::useFastTLS):
(JSC::Wasm::useFastTLSForWasmContext):

• wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):

• wasm/js/JSWebAssemblyInstance.h:

(JSC::JSWebAssemblyInstance::offsetOfCallee):

• wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::finishCreation):
(JSC::JSWebAssemblyModule::visitChildren):

• wasm/js/JSWebAssemblyModule.h:

(JSC::JSWebAssemblyModule::callee):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):
(JSC::WebAssemblyFunction::create):

• wasm/js/WebAssemblyToJSCallee.cpp:

(JSC::WebAssemblyToJSCallee::create):
(JSC::WebAssemblyToJSCallee::createStructure):
(JSC::WebAssemblyToJSCallee::finishCreation):
(JSC::WebAssemblyToJSCallee::visitChildren):
(JSC::WebAssemblyToJSCallee::destroy): Deleted.

• wasm/js/WebAssemblyToJSCallee.h:

3:14 PM Changeset in webkit [214497] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
​https://bugs.webkit.org/show_bug.cgi?id=170193

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:

Fixed the order of arguments.

2:56 PM Changeset in webkit [214496] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Dashboard tests fails to fetch the revision from commits
​https://bugs.webkit.org/show_bug.cgi?id=170191

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:

Added recordedCommitIndicesByRevisionNumber.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:

(setup): Populated trac.recordedCommitIndicesByRevisionNumber since the dashboard code uses this variable.

2:43 PM Changeset in webkit [214495] by timothy_horton@apple.com

• 4 edits in trunk

Safari crashes when attempting to close tab that is displaying PDF
​https://bugs.webkit.org/show_bug.cgi?id=170201
<rdar://problem/31242019>

Reviewed by Wenson Hsieh.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _doAfterNextStablePresentationUpdate:]):
Adopt BlockPtr to fix a leak.

(-[WKWebView _firePresentationUpdateForPendingStableStatePresentationCallbacks]):
dispatch_async in the doAfterNextPresentationUpdate callback; since this
recursively calls itself, in cases where doAfterNextPresentationUpdate
returns synchronously (e.g. if the Web Process is missing), we would
recurse infinitely.

• TestWebKitAPI/Tests/WebKit2Cocoa/DoAfterNextPresentationUpdateAfterCrash.mm:

(TEST):
Add a test for doAfterNextStablePresentationUpdate just like the existing
non-stable one.

2:41 PM Changeset in webkit [214494] by BJ Burg

• 23 edits
  4 adds in trunk

Web Inspector: Add "Disable Caches" option that only applies to the inspected page while Web Inspector is open
​https://bugs.webkit.org/show_bug.cgi?id=169865
<rdar://problem/31250573>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/Network.json:

Rename the command for disabling resource caching to match the WebCore::Page
flag. This also removes the possibility that this could be confused for the old,
buggy command that this patch rips out.

Source/WebCore:

Rewrite the network agent's command for disabling resource caching to use Page::setResourceCachingEnabled.
The old implementation was doing weird stuff like setting no-cache headers and evicting the
contents of the memory cache, neither of which is correct. The new approach has no side effects
on the network, disk, or memory cache so it can be turned on temporarily without causing problems.

New tests:

• http/tests/inspector/network/set-resource-caching-disabled-disk-cache.html
• http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html

• inspector/InspectorNetworkAgent.h:
• inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::setCacheDisabled): Deleted.
(WebCore::InspectorNetworkAgent::setResourceCachingDisabled): Added.
Implement new command.

(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::mainFrameNavigated):
Remove crufty attempts to break caches. I believe these are intended to defeat caching
proxies and similar middlemen, but this is just as likely to cause unusual loading behavior.

• page/Page.h:

(WebCore::Page::isResourceCachingDisabled):
(WebCore::Page::setResourceCachingDisabledOverride):
Add an override setting so that Web Inspector's override does not mess up the value
of isResourceCachingDisabled that may have been set by a WebKit API client.

Source/WebInspectorUI:

Hook up a button in the Network tab to WebCore::Page's resourceCachingDisabled flag.
If it is active, resource loads are subject to a cache policy that never uses a cached response.

• Localizations/en.lproj/localizedStrings.js:

Add localized strings.

• UserInterface/Base/Main.js:

(WebInspector.loaded):
Add a setting for whether to disable resource caching and inform the backend
of our preference. If someone changes the setting, tell the backend again.

• UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView):
(WebInspector.NetworkGridContentView.prototype.get navigationItems):
(WebInspector.NetworkGridContentView.prototype._resourceCachingDisabledSettingChanged):
(WebInspector.NetworkGridContentView.prototype._toggleDisableResourceCache):
Add a new activatable navigation item that toggles disableResourceCaching for the inspected page.

• UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
• Versions/Inspector-iOS-10.0.json:
• Versions/Inspector-iOS-10.3.json:
• Versions/Inspector-iOS-7.0.json:
• Versions/Inspector-iOS-8.0.json:
• Versions/Inspector-iOS-9.0.json:
• Versions/Inspector-iOS-9.3.json:

Update legacy backend commands to remove the old/broken Network.setCacheDisabled command.

LayoutTests:

Add tests that verify the new command works as expected when it disables resource caching.
I also manually verified that the override setting is cleared when Web Inspector disconnects.
This is not easy to check in a layout test since we rely on the Web Inspector to tell whether
a load happened or not.

• http/tests/inspector/network/set-resource-caching-disabled-disk-cache-expected.txt: Added.
• http/tests/inspector/network/set-resource-caching-disabled-disk-cache.html: Added.
• http/tests/inspector/network/set-resource-caching-disabled-memory-cache-expected.txt: Added.
• http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html: Added.

2:17 PM Changeset in webkit [214493] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

Update LayoutTests/fast/mediastream/RTCPeerConnection-addIceCandidate.html to get more coverage
​https://bugs.webkit.org/show_bug.cgi?id=170194

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-28
Reviewed by Chris Dumez.

• fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
• fast/mediastream/RTCPeerConnection-addIceCandidate.html: Making test more robust to failures to get more coverage.

1:57 PM Changeset in webkit [214492] by commit-queue@webkit.org

• 3 edits
  8 adds in trunk

Web Inspector: Inspecting a Main Resource that is JS/JSON does not format / syntax highlight it properly
​https://bugs.webkit.org/show_bug.cgi?id=166862
<rdar://problem/29835977>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-28
Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Models/Resource.js:

(WebInspector.Resource.prototype.get syntheticMIMEType):
Don't override the mime type for Document resources. They should always
have a mime type and we should use whatever it is.

LayoutTests:

• http/tests/inspector/network/resource-mime-type-expected.txt: Added.
• http/tests/inspector/network/resource-mime-type.html: Added.

Test resource mime types for different resources.

• http/tests/inspector/network/resources/json.php: Added.
• http/tests/inspector/network/resources/script.js: Added.
• http/tests/inspector/network/resources/script.txt: Added.
• http/tests/inspector/network/resources/stylesheet.css: Added.
• http/tests/inspector/network/resources/stylesheet.txt: Added.
• http/tests/resources/square20.jpg: Added.

Resources for various requests and different mime types.

1:50 PM Changeset in webkit [214491] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/xmlhttprequest/simple-cross-origin-progress-events.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=168132

Unreviewed test gardening.

• platform/mac/TestExpectations:

1:40 PM Changeset in webkit [214490] by commit-queue@webkit.org

• 4 edits in trunk

Fix addIceCandidate after r214441
​https://bugs.webkit.org/show_bug.cgi?id=170146

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-28
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:

Source/WebCore:

Covered by rebased test.

• Modules/mediastream/RTCPeerConnection.js:

(addIceCandidate): Setting function length to 1 and throwing if no parameter is passed.

1:08 PM Changeset in webkit [214489] by Yusuke Suzuki

• 9 edits in trunk/Source

[JSC] Move platformThreadSignal to WTF
​https://bugs.webkit.org/show_bug.cgi?id=170097

Reviewed by Mark Lam.

Source/JavaScriptCore:

It is a small clean up towards ​https://bugs.webkit.org/show_bug.cgi?id=170027.
platformThreadSignal uses PlatformThread in JSC, but it can be implemented in
WTF ThreadIdentifier.

• runtime/JSLock.cpp:

(JSC::JSLock::lock):

• runtime/JSLock.h:

(JSC::JSLock::ownerThread):
(JSC::JSLock::currentThreadIsHoldingLock):

• runtime/PlatformThread.h:

(JSC::platformThreadSignal): Deleted.

• runtime/VM.h:

(JSC::VM::ownerThread):

• runtime/VMTraps.cpp:

(JSC::VMTraps::SignalSender::send):

Source/WTF:

• wtf/Threading.h:
• wtf/ThreadingPthreads.cpp:

(WTF::signalThread):

1:02 PM Changeset in webkit [214488] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark two fast/scrolling/ios/touch-scroll tests as failing.
​https://bugs.webkit.org/show_bug.cgi?id=170153

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

12:21 PM Changeset in webkit [214487] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Unable to Format JSON Request Data
​https://bugs.webkit.org/show_bug.cgi?id=170189

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-28
Reviewed by Matt Baker.

• UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor.prototype._startWorkerPrettyPrint):
When we are viewing request data we are looking at a TextResourceContentView
which has a TextEditor without a delegate. In these cases we can just assume
a JavaScript Program. In the majority of cases this will typically be JSON
data, and either Program or Module will highlight and format as expected.

12:05 PM Changeset in webkit [214486] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Remove failure expectation for media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html.

Unreviewed test gardening.

• platform/ios/TestExpectations:

12:03 PM Changeset in webkit [214485] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Stop RTCDataChannel when closing page
​https://bugs.webkit.org/show_bug.cgi?id=170166

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-28
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/datachannel/datachannel-gc.html

Making RTCDataChannel an ActiveDOMObject.
Closing the data channel backend and freeing upon close and stop.

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create):
(WebCore::RTCDataChannel::RTCDataChannel):
(WebCore::RTCDataChannel::close):
(WebCore::RTCDataChannel::stop):

• Modules/mediastream/RTCDataChannel.h:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCPeerConnection.h:

LayoutTests:

• webrtc/datachannel/datachannel-gc-expected.txt: Added.
• webrtc/datachannel/datachannel-gc.html: Added.

11:41 AM Changeset in webkit [214484] by jfbastien@apple.com

• 4 edits
  2 adds in trunk

WebAssembly: implement Module imports/exports
​https://bugs.webkit.org/show_bug.cgi?id=166982

Reviewed by Saam Barati.

JSTests:

• wasm/js-api/Module.exports.js: Added.

(assert.throws.WebAssembly.Module.prototype.exports):
(assert.eq):

• wasm/js-api/Module.imports.js: Added.

(assert.throws.WebAssembly.Module.prototype.imports):
(assert.eq):

Source/JavaScriptCore:

As defined in: ​https://github.com/WebAssembly/design/commit/18cbacb90cd3584dd5c9aa3d392e4e55f66af6ab

• wasm/WasmFormat.h:

(JSC::Wasm::makeString): use uppercase instead, it was only used
for diagnostic but is now used for the expected JS property's
capitalization

• wasm/js/WebAssemblyModulePrototype.cpp:

(JSC::webAssemblyModuleProtoImports):
(JSC::webAssemblyModuleProtoExports):

11:29 AM Changeset in webkit [214483] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Enhance the touch region debug overlay to show regions for the different events
​https://bugs.webkit.org/show_bug.cgi?id=170162

Reviewed by Tim Horton.

Have NonFastScrollableRegionOverlay use a different color for each region in EventTrackingRegions,
and to draw a legend showing what the colors mean.

On Mac, this overlay displays the non-fast scrollable region (which we don't keep separate from the wheel event
region).

• page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):
(WebCore::touchEventRegionColors):
(WebCore::drawRightAlignedText):
(WebCore::NonFastScrollableRegionOverlay::drawRect):
(WebCore::RegionOverlay::drawRect):
(WebCore::RegionOverlay::drawRegion):

11:29 AM Changeset in webkit [214482] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Make sure the non-fast scrolling debug overlay is correctly updated
​https://bugs.webkit.org/show_bug.cgi?id=170142

Reviewed by Tim Horton.

AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged() is called on a timer
from Document code, so the existing DebugPageOverlays::didLayout() call at the end
of FrameView::layout() wasn't sufficient to keep the non-fast scrollable region up-to-date
on iOS.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):

11:27 AM Changeset in webkit [214481] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Modern Media Controls] AirPlay placard text looks bad on 1x displays
​https://bugs.webkit.org/show_bug.cgi?id=170183
<rdar://problem/30663416>

Patch by Antoine Quint <Antoine Quint> on 2017-03-28
Reviewed by Dean Jackson.

Use subpixel antialiasing for all text in modern media controls.

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls-container,):

10:36 AM Changeset in webkit [214480] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

REGRESSION (r214386): [ios-simulator] LayoutTest media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=170180

Unreviewed. Restore a value that was mistakenly changed in the fix for webkit.org/b/169962.

Patch by Antoine Quint <Antoine Quint> on 2017-03-28

• media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt:
• media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html:

9:42 AM Changeset in webkit [214479] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark fast/history/ios/history-scroll-restoration.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169558

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:

9:29 AM Changeset in webkit [214478] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html as failing on ios-simulator.
​https://bugs.webkit.org/show_bug.cgi?id=170180

Unreviewed test gardening.

• platform/ios/TestExpectations:

9:12 AM Changeset in webkit [214477] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

LayoutTest webrtc/video-getParameters.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=170148

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-28

• TestExpectations: Marking webrtc/video-getParameters.html as failing.

9:09 AM Changeset in webkit [214476] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark webrtc/video-replace-track-to-null.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=170178

Unreviewed test gardening.

• TestExpectations:

8:55 AM Changeset in webkit [214475] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Modern Media Controls] Improve appearance of tracks panel on macOS
​https://bugs.webkit.org/show_bug.cgi?id=168929
<rdar://problem/30741589>

Patch by Antoine Quint <Antoine Quint> on 2017-03-28
Reviewed by Eric Carlson.

We use a solid color for the focus state that matches the style used on macOS
and blend the titles the same way we blend other non-solid labels in the controls bar.

• Modules/modern-media-controls/controls/tracks-panel.css:

(.tracks-panel section):
(.tracks-panel section > h3):
(.tracks-panel section > ul > li:focus):

8:30 AM Changeset in webkit [214474] by Jonathan Bedard

• 4 edits
  3 copies
  12 adds in trunk/LayoutTests

Moved gardened ios-simulator tests to ios folders
<rdar://problem/30948691>

Unreviewed test re-organization.

Moving ios-simulator test expectations to share as many expectations
as possible with on-device testing.

• platform/ios: Moved from platform/ios-simulator.
• platform/ios-device: Added.
• platform/ios-device-wk1: Added.
• platform/ios-device-wk2: Added.
• platform/ios-simulator: Moved to platform/ios.
• platform/ios-simulator-wk1: Moved to platform/ios-wk1.
• platform/ios-simulator-wk2: Moved to platform/ios-wk2.
• platform/ios-wk1: Moved from platform/ios-simulator-wk1.
• platform/ios-wk2: Moved from platform/ios-simulator-wk2.

7:06 AM Changeset in webkit [214473] by Jonathan Bedard

• 4 edits in trunk/Tools

webkitpy: Use host pattern for devices
​https://bugs.webkit.org/show_bug.cgi?id=170121

Reviewed by Daniel Bates.

Devices should be treated like hosts throughout webkitpy
so that more code can be re-used. Add the needed properties
and use executive over custom implemented polling/killing
functions.

• Scripts/webkitpy/port/device.py:

(Device):
(Device.executive): Add optional executive property.
(Device.filesystem): Add optional filesystem property.
(Device.user): Add optional user property.
(Device.platform): Add optional platform property.
(Device.workspace): Add optional workspace property.
(Device.poll): Deleted.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.Popen.poll): Use the devices executive.
(SimulatorProcess.stop): Ditto.
(SimulatorProcess._kill): Ditto.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.init): Add executive, filesystem, user, platform
and workspace to the platform device.
(SimulatedDevice.poll): Deleted.

4:56 AM Changeset in webkit [214472] by yoav@yoav.ws

• 18 edits
  1 copy
  3 adds in trunk

Add a warning for unused link preloads.
​https://bugs.webkit.org/show_bug.cgi?id=165670

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: http/tests/preload/single_download_preload_headers_charset.php

http/tests/preload/unused_preload_warning.html

• dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Stop the timer once the document is destructed.

• loader/LinkPreloadResourceClients.h: Add shouldMarkAsReferenced overides for the LinkPreloadResourceClient classes.
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClientToSet): Make sure LinkPreloadResourceClients don't set resource to be referenced.

• loader/cache/CachedResourceClient.h:

(WebCore::CachedResourceClient::shouldMarkAsReferenced): Make sure that ResourceClients mark preloads as referenced by default.

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader): Initialize timer.
(WebCore::CachedResourceLoader::~CachedResourceLoader): Stop timer.
(WebCore::CachedResourceLoader::documentDidFinishLoadEvent): Trigger a timer if preloads weren't cleared at load time.
(WebCore::CachedResourceLoader::stopUnusedPreloadsTimer): Stop the timer.
(WebCore::CachedResourceLoader::warnUnusedPreloads): Iterate over m_preloads and issue a warning for non-referenced preloads.

• loader/cache/CachedResourceLoader.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::willDetachDocumentFromFrame): Clear Resource Timing buffer when document detaches, to avoid test flakiness.

LayoutTests:

• TestExpectations: Added a "Failure Pass" for the flaky charset header test.
• http/tests/preload/download_resources-expected.txt:
• http/tests/preload/download_resources.html: Added references to preloaded resources.
• http/tests/preload/onerror_event-expected.txt:
• http/tests/preload/onerror_event.html: Added references to preloaded resources.
• http/tests/preload/onload_event-expected.txt:
• http/tests/preload/onload_event.html: Added references to preloaded resources.
• http/tests/preload/single_download_preload.html: Deflaked.
• http/tests/preload/single_download_preload_headers.php: Removed the charset to avoid double download bug.
• http/tests/preload/single_download_preload_headers_charset-expected.txt: Added.
• http/tests/preload/single_download_preload_headers_charset.php: Flaky test showing the double download bug when charset is declared.
• http/tests/preload/unused_preload_warning-expected.txt: Added.
• http/tests/preload/unused_preload_warning.html: Added.

3:42 AM Changeset in webkit [214471] by commit-queue@webkit.org

• 5 edits
  2 adds in trunk

REGRESSION: Double-clicking the captions button while the captions popover is open prevents the popover from being opened again
​https://bugs.webkit.org/show_bug.cgi?id=170171
<rdar://problem/31095500>

Patch by Antoine Quint <Antoine Quint> on 2017-03-28
Reviewed by Dean Jackson.

Source/WebCore:

We used to consider that the tracks panel was presented as long as it had a parent, but since we were using for the animated
transition to complete before actually removing the panel from the node hierarchy, consecutive calls to hide then present
would fail to present the panel. We now use a private instance variable to track the presented state which is set immediately
as presentInParent() and hide() are called.

Test: media/modern-media-controls/tracks-support/tracks-support-show-panel-then-double-click-on-tracks-button.html

• Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype.get presented):
(TracksPanel.prototype.presentInParent):
(TracksPanel.prototype.hide):

LayoutTests:

Adding a new test that runs the steps to reproduce the issue, and rebaselining an existing one now that
the "presented" property returns false immediately after calling hide() on the panel.

• media/modern-media-controls/tracks-panel/tracks-panel-hide-expected.txt:
• media/modern-media-controls/tracks-panel/tracks-panel-hide.html:
• media/modern-media-controls/tracks-support/tracks-support-show-panel-then-double-click-on-tracks-button-expected.txt: Added.
• media/modern-media-controls/tracks-support/tracks-support-show-panel-then-double-click-on-tracks-button.html: Added.

2:33 AM Changeset in webkit [214470] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Dashboard test fails with error: latestIterationGetter is not a function
​https://bugs.webkit.org/show_bug.cgi?id=170167

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:

(this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.

12:49 AM Changeset in webkit [214469] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

AX: Media controls should be able to be re-activated after faded away
​https://bugs.webkit.org/show_bug.cgi?id=170048
<rdar://problem/30157179>

Patch by Aaron Chu <​aaron_chu@apple.com> on 2017-03-28
Reviewed by Antoine Quint.

Source/WebCore:

Added a "foucsin" listener for the controls bar so that when an element
within fires a "focusin" event, the controls bar reappears if it is faded.

Test: media/modern-media-controls/media-controls/media-controls-appear-when-focus.html

• Modules/modern-media-controls/controls/controls-bar.js:

(ControlsBar.prototype.handleEvent):

LayoutTests:

• media/modern-media-controls/media-controls/media-controls-appear-when-focus-expected.txt: Added.
• media/modern-media-controls/media-controls/media-controls-appear-when-focus.html: Added.

12:34 AM Changeset in webkit [214468] by graouts@webkit.org

• 11 edits
  2 copies
  17 adds in trunk

[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
​https://bugs.webkit.org/show_bug.cgi?id=169145
<rdar://problem/17048858>

Reviewed by Dean Jackson.

Source/WebCore:

There were a variety of issues with media documents, some longstanding, and some specifically
about modern media controls.

One issue was that fullscreen and picture-in-picture buttons would show for audio media documents,
due to using a <video> element to load the audio file. We now have additional logic in MediaController
to identify if the loaded media is really an audio file, and using this information to hide the
fullscreen and picture-in-picture buttons.

Another issue was that we would inject style in MediaDocument.cpp that was specific to modern media
controls when we could have the modern-media-controls module injected CSS handle this styling. We now
use the injected style in the shadow root to size media documents based on the device characteristics
and ensuring that page styles are overridden.

We also simplify how MediaDocument.cpp sets the source of the media element to simply use the "src"
attribute and not a <source> element.

Finally, we introduce a MediaDocumentController class that is instantiated when we're dealing with
a media document to hide the controls while we determine the type of media we're loading (audio vs.
video) in order to apply the appropriate styling without flashes.

As a result of the new styles applied by the modern-media-controls module, media documents have a
similar behavior on macOS and iPad, where we only enforce a min-width for video allowing them
to play at their natural size otherwise, and enforcing a fixed width for audio. On iPhone however,
we want to always play the media at full width, with some padding in the case of audio.

Tests: media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html

media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html
media/modern-media-controls/media-documents/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-video-mac-sizing.html
media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html

• Modules/modern-media-controls/controls/ios-inline-media-controls.css:

(:host(audio) .media-controls.ios.inline > .controls-bar:before,):
(:host(audio) .media-controls.ios.inline > .controls-bar:before): Deleted.

• Modules/modern-media-controls/controls/macos-media-controls.css:

(:host(audio) .media-controls.mac.inline > .controls-bar,):
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint,):
(:host(audio) .media-controls.mac.inline > .controls-bar): Deleted.
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint): Deleted.

• Modules/modern-media-controls/controls/media-document.css: Copied from Source/WebCore/Modules/modern-media-controls/controls/macos-media-controls.css.

(:host(.media-document)):
(:host(.media-document.ready)):
(:host(.media-document.audio.mac)):
(:host(.media-document.audio.ipad)):
(:host(.media-document.audio.iphone)):
(:host(.media-document.video.mac)):
(:host(.media-document.video.ipad)):
(:host(.media-document.video.iphone)):

• Modules/modern-media-controls/js-files:
• Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.get isAudio):

• Modules/modern-media-controls/media/media-document-controller.js: Copied from Source/WebCore/Modules/modern-media-controls/media/fullscreen-support.js.

(MediaDocumentController):
(MediaDocumentController.prototype.handleEvent):
(MediaDocumentController.prototype._mediaDocumentHasMetadata):
(MediaDocumentController.prototype._mediaDocumentHasSize):

• Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.syncControl):
(PiPSupport):

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

We add new tests for media documents and related features that cover the following cases:

• checking <video> with only audio tracks does not show the fullscreen button
• checking <video> with only audio tracks does not show the picture-in-picture button
• checking the size used in media documents for audio and video across macOS, iPhone and iPad

• media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
• media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html: Added.
• media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-audio-mac-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-video-mac-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-video-mac-sizing.html: Added.
• media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
• media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html: Added.
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

12:31 AM Changeset in webkit [214467] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

Follow-up patch after r214364.
​https://bugs.webkit.org/show_bug.cgi?id=168895

Unreviewed.

• platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::FontDescription):

Mar 27, 2017:

11:35 PM Changeset in webkit [214466] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Fixes for libwebrtc logging after r214288
​https://bugs.webkit.org/show_bug.cgi?id=170116

Patch by Alejandro G. Castro <​alex@igalia.com> on 2017-03-27
Reviewed by Youenn Fablet.

• Source/webrtc/base/logging.cc: Added the critical section

requirement and the call to the new getter for g_log_crit.

11:20 PM Changeset in webkit [214465] by jfbastien@apple.com

• 2 edits
  1 move in trunk/Source/JavaScriptCore

WebAssembly: JSWebAssemblyCodeBlock.h belongs in JavaScriptCore/wasm/js not JavaScriptCore/wasm
​https://bugs.webkit.org/show_bug.cgi?id=170160

Reviewed by Mark Lam.

• JavaScriptCore.xcodeproj/project.pbxproj:
• wasm/js/JSWebAssemblyCodeBlock.h: Renamed from Source/JavaScriptCore/wasm/JSWebAssemblyCodeBlock.h.

11:17 PM Changeset in webkit [214464] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Option-clicking the close tab button should close all other tabs
​https://bugs.webkit.org/show_bug.cgi?id=169046

Reviewed by Matt Baker.

• UserInterface/Views/TabBar.js:

(WebInspector.TabBar.prototype._handleClick):

10:43 PM Changeset in webkit [214463] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test v8.

10:30 PM Changeset in webkit [214462] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test v7.

10:19 PM Changeset in webkit [214461] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test v6.

9:39 PM Changeset in webkit [214460] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Remove WebPage::m_shouldDoICECandidateFiltering
​https://bugs.webkit.org/show_bug.cgi?id=170150

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-27
Reviewed by Sam Weinig.

It is redundant with RTCController::m_shouldFilterICECandidates.
Manually tested on webrtc test samples.
This code path is currently untested by rwt as we hook it to getUserMedia which is mocked in rwt.
Additional testing will be added as a follow-up patch.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::disableICECandidateFiltering):
(WebKit::WebPage::enableICECandidateFiltering):

• WebProcess/WebPage/WebPage.h:

9:08 PM Changeset in webkit [214459] by jfbastien@apple.com

• 2 edits in trunk/Source/WebKit

make build fix for WebDefaultUIDelegate.m
​https://bugs.webkit.org/show_bug.cgi?id=170163

Unreviewed build fix.

• PlatformMac.cmake: WebDefaultUIDelegate.m was renamed

8:55 PM Changeset in webkit [214458] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test v5.

8:50 PM Changeset in webkit [214457] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test v4.

8:41 PM Changeset in webkit [214456] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test v3.

8:06 PM Changeset in webkit [214455] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

[WK2] UIKit assertion when rotating device after dismissing popover
​https://bugs.webkit.org/show_bug.cgi?id=170159
<rdar://problem/31283829>

Reviewed by Tim Horton.

Ensure that when we are finished presenting a WKActionSheet, we unregister with the shared notifications center.

• UIProcess/ios/WKActionSheet.mm:

(-[WKActionSheet dealloc]):
(-[WKActionSheet _cleanup]):
(-[WKActionSheet doneWithSheet:]):

8:05 PM Changeset in webkit [214454] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test v2.

8:03 PM Changeset in webkit [214453] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Another test.

7:53 PM Changeset in webkit [214452] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

<rdar://problem/30949128>
Update build.webkit.org to use port 16000 for PBChangeSource.

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

7:43 PM Changeset in webkit [214451] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Test commit to verify post-commit hook.

7:23 PM Changeset in webkit [214450] by commit-queue@webkit.org

• 42 edits
  8 adds in trunk

REGRESSION(213764): Large images should not be decoded asynchronously when they are drawn on a canvas
​https://bugs.webkit.org/show_bug.cgi?id=169771

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-03-27
Reviewed by Simon Fraser.

Source/WebCore:

Sometimes we have to draw the image immediately like when a canvas calls
drawImage. In this case we have to decode the image synchronously to guarantee
the drawing. Other times we need to decode with the native size of the image.
The animated images have to be decoded with native size always. Otherwise
the frame cache will be messed up if the same image is animated with different
sizes. Currently we always decode asynchronously with sizeForDrawing. We need
to decouple the decoding mode from the sizeForDrawing.

This patch introduce the DecodingOptions class which can store and compare the
following four cases:

-- Synchronous: The frame has be decoded with native size only.
-- Asynchronous + anySize: This is passed from the Image::draw() callers.
-- Asynchronous + fullSize: The image has to be decoded with its full size.
-- Asynchronous + sizeForDrawing: The image can be decoded with sizeForDrawing unless
it was decoded with either a full size or sizeForDrawing which is larger than the
requested sizeForDrawing.

A new argument of type DecodingMode will be added to Image::draw() function.
Only when the drawing comes from the render tree, it will be Asynchronous.
Otherwise it will be Synchronous.

Tests: fast/images/animated-image-different-dest-size.html

fast/images/async-image-background-image.html
fast/images/async-image-canvas-draw-image.html

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameImageAtIndexCacheIfNeeded): Gets the frame image, cache it synchronously if
the current one is invalid. frameImageAtIndex() returns whatever stored in the cache.
(WebCore::BitmapImage::nativeImage): Call frameImageAtIndexCacheIfNeeded() instead of frameImageAtIndex().
(WebCore::BitmapImage::nativeImageForCurrentFrame): Ditto.
(WebCore::BitmapImage::nativeImageOfSize): Ditto.
(WebCore::BitmapImage::framesNativeImages): Ditto.
(WebCore::BitmapImage::draw): Change the logic to do the following:
-- The animated image has to be decoded with its full size.
-- The animated image expects the current frame to be ready for drawing.
-- The large image decoding does not need to call internalStartAnimation().
-- The large image has to request async image decoding but draw the current one if it exists.
(WebCore::BitmapImage::drawPattern): Draw the pattern synchronously.
(WebCore::BitmapImage::shouldUseAsyncDecodingForLargeImages): Delete the call to shouldUseAsyncDecodingForTesting()
since it is only applied for animated images.
(WebCore::BitmapImage::shouldUseAsyncDecodingForAnimatedImages): Call shouldUseAsyncDecodingForAnimatedImageForTesting().
(WebCore::BitmapImage::internalStartAnimation): Request decoding with the full size.
(WebCore::BitmapImage::advanceAnimation): Call shouldUseAsyncDecodingForAnimatedImageForTesting().
(WebCore::BitmapImage::internalAdvanceAnimation): Assert the current frame is not being decoding asynchronously for any size.
(WebCore::BitmapImage::frameImageAtIndex): Deleted. Moved to the header file but with a new purpose: return
the current frame from the frame cache as is; do not cache a new one.
(WebCore::BitmapImage::shouldUseAsyncDecodingForLargeImage): Deleted. Function was renamed to shouldUseAsyncDecodingForLargeImages.
(WebCore::BitmapImage::shouldUseAsyncDecodingForAnimatedImage): Deleted. Function was renamed to shouldUseAsyncDecodingForAnimatedImages.

• platform/graphics/BitmapImage.h:
• platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw): Add a new argument of type DecodingMode.

• platform/graphics/CrossfadeGeneratedImage.h:
• platform/graphics/DecodingOptions.h: Added.

(WebCore::DecodingOptions::DecodingOptions): Default constructor: Synchronous mode.
(WebCore::DecodingOptions::operator==): Compares two DecodingOptions for equality.
(WebCore::DecodingOptions::isSynchronous): Is the frame decoded synchronously?
(WebCore::DecodingOptions::isAsynchronous): Is the frame decoded asynchronously?
(WebCore::DecodingOptions::isAsynchronousCompatibleWith): Is this DecodingOptions compatible with another one?
(WebCore::DecodingOptions::hasFullSize): Is the decoding mode asynchronous but for the image full size?
(WebCore::DecodingOptions::hasSizeForDrawing): Is this decoding mode asynchronous but for a sizeForDrawing?
(WebCore::DecodingOptions::sizeForDrawing): Returns the sizeForDrawing. m_decodingModeOrSize has to hold an IntSize.
(WebCore::DecodingOptions::maxDimension): Moved form ImageFrame.cpp.
(WebCore::DecodingOptions::has): A helper function.
(WebCore::DecodingOptions::hasDecodingMode): Does m_decodingModeOrSize a DecodingMode?
(WebCore::DecodingOptions::hasSize): Does m_decodingModeOrSize an IntSize?

• platform/graphics/GeneratedImage.h: Add a new argument of type DecodingMode.
• platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::draw): Ditto.

• platform/graphics/GradientImage.h: Ditto.
• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage): Pass the ImagePaintingOptions::m_DecodingMode to Image::draw().

• platform/graphics/GraphicsContext.h:

(WebCore::ImagePaintingOptions::ImagePaintingOptions): Add a new member of type DecodingMode to ImagePaintingOptions.

• platform/graphics/Image.cpp:

(WebCore::Image::drawTiled): Pass DecodingMode::Synchronous to Image::draw().

• platform/graphics/Image.h: Add a new argument of type DecodingMode to Image::draw().
• platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::operator=): Replace m_sizeForDrawing by m_decodingOptions.
(WebCore::ImageFrame::hasNativeImage): Check if m_nativeImage is valid and the subsamplingLevels match.
(WebCore::ImageFrame::hasFullSizeNativeImage): Checks hasNativeImage() and whether the image frame was
decoded for the image full size.
(WebCore::ImageFrame::hasDecodedNativeImageCompatibleWithOptions): Checks hasNativeImage() and the DecodingOptions match.
(WebCore::maxDimension): Deleted. Moved to DecodingOptions.h.
(WebCore::ImageFrame::isBeingDecoded): Deleted. The check for having an ImageFrame being decoded is
moved to ImageFrameCache.
(WebCore::ImageFrame::hasValidNativeImage): Deleted. No need to this function.

• platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::hasNativeImage): Add an std::optional<SubsamplingLevel> argument.
(WebCore::ImageFrame::hasFullSizeNativeImage): Checks whether the ImageFrame was decoded for the image full size.
(WebCore::ImageFrame::enqueueSizeForDecoding): Deleted.
(WebCore::ImageFrame::dequeueSizeForDecoding): Deleted.
(WebCore::ImageFrame::clearSizeForDecoding): Deleted.
(WebCore::ImageFrame::isBeingDecoded): Deleted.
(WebCore::ImageFrame::sizeForDrawing): Deleted.
(WebCore::ImageFrame::hasDecodedNativeImage): Deleted.
The logic of knowing whether an ImageFrame is being decoded is moved to ImageFrameCache.

• platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::cacheFrameMetadataAtIndex): Caches the metadata of an ImageFrame. If the NativeImage
was decoded for a sizeForDrawing, the size of the ImageFrame will be the nativeImageSize(). Otherwise, the
frameSizeAtIndex() will be called.
(WebCore::ImageFrameCache::cacheFrameNativeImageAtIndex): Cache a new NativeImage which involves caching new
metadata and updating the memory cache. No need to check if the existing native image is valid or not for the
DecodingOptions. Actually it would be a bug if it happens. This is why cacheNativeImageForFrameRequest() asserts
!frame.hasAsyncNativeImage() before calling cacheFrameNativeImageAtIndex().
(WebCore::ImageFrameCache::cacheAsyncFrameNativeImageAtIndex): Cache new NativeImage which was decoded asynchronously.
(WebCore::ImageFrameCache::startAsyncDecodingQueue): Call cacheAsyncFrameNativeImageAtIndex() instead of
cacheNativeImageForFrameRequest() for clarity.
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex): Call hasAsyncNativeImage() instead of hasValidNativeImage()
Call frameIsDecodingCompatibleWithOptionsAtIndex() instead of frame.isBeingDecoded(). Replace the call to enqueueSizeForDecoding()
by appending the same ImageFrameRequest to m_frameCommitQueue.
(WebCore::ImageFrameCache::isAsyncDecodingQueueIdle): Use m_frameCommitQueue to answer the question whether the decodingQueue is idle.
(WebCore::ImageFrameCache::stopAsyncDecodingQueue): Use m_frameCommitQueue to loop through all the ImageFrames which are currently being decoded.
(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded): For getting the metadata, this function needs a valid frame. If it is requested
to decode the nativeImage, it has to do it synchronously.
(WebCore::ImageFrameCache::singlePixelSolidColor): Don't cache the frame if it is an animated image or the size is not a single pixel.
(WebCore::ImageFrameCache::frameIsBeingDecodedAndIsCompatibleWithOptionsAtIndex): Use m_frameCommitQueue to answer the question whether an ImageFrame
is being decoded and is compatible with DecodingOptions.
(WebCore::ImageFrameCache::frameHasFullSizeNativeImageAtIndex): Calls ImageFrame::hasFullNativeImage() for a frame.
(WebCore::ImageFrameCache::frameHasDecodedNativeImageCompatibleWithOptionsAtIndex): Calls ImageFrame::hasDecodedNativeImageCompatibleWithOptions() for a frame.
(WebCore::ImageFrameCache::frameImageAtIndex): Returns the current NativeImage without caching.
(WebCore::ImageFrameCache::frameImageAtIndexCacheIfNeeded): Returns the current NativeImage but cache it synchronously if needed.
(WebCore::ImageFrameCache::setFrameNativeImageAtIndex): Deleted.
(WebCore::ImageFrameCache::setFrameMetadataAtIndex): Deleted.
(WebCore::ImageFrameCache::replaceFrameNativeImageAtIndex): Deleted.
(WebCore::ImageFrameCache::frameIsBeingDecodedAtIndex): Deleted.
(WebCore::ImageFrameCache::frameHasImageAtIndex): Deleted.
(WebCore::ImageFrameCache::frameHasValidNativeImageAtIndex): Deleted.
(WebCore::ImageFrameCache::frameHasDecodedNativeImage): Deleted.

• platform/graphics/ImageFrameCache.h: Two ImageFrameRequest queues will be used.

-- The existing one m_frameRequestQueue which is shared between the main thread and decoding thread. The requests will be
dequeued from it before starting the decoding. The decoded NativeImage will be cached only on the main thread. The decoding
thread is not blocked by the callOnMainThread(). This means there might be multiple ImageFrameRequests which were dequeued
while their NativeImages have not been cached yet.
-- A new one m_frameCommitQueue which is track all the ImageFrameRequests whose NativeImages have not been cached yet.
(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded): Be explicit about caching the image frame. frameImageAtIndex()
returns the current image frame without caching. frameAtIndexCacheIfNeeded(). returns the current image frame but cache
it if needed.
(WebCore::ImageFrameCache::ImageFrameRequest::operator==): Compares two ImageFrameRequests for equality.

• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameImageAtIndexCacheIfNeeded):
(WebCore::ImageSource::frameImageAtIndex): Deleted.

• platform/graphics/ImageSource.h:

(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex): Change the type of the argument from IntSize to be const std::optional<IntSize>.
(WebCore::ImageSource::frameIsBeingDecodedAndIsCompatibleWithOptionsAtIndex): Rename of frameIsBeingDecodedAtIndex(). Replace the argument of type
std::optional<IntSize> by an argument of type DecodingOptions.
(WebCore::ImageSource::frameHasFullSizeNativeImageAtIndex): A wrapper around the ImageFrameCache function.
(WebCore::ImageSource::frameHasDecodedNativeImageCompatibleWithOptionsAtIndex): Ditto.
(WebCore::ImageSource::frameImageAtIndex): Ditto.
(WebCore::ImageSource::frameIsBeingDecodedAtIndex): Deleted.
(WebCore::ImageSource::frameHasValidNativeImageAtIndex): Deleted.
(WebCore::ImageSource::frameHasDecodedNativeImage): Deleted.

• platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::draw): Add a new argument of type DecodingMode.

• platform/graphics/NamedImageGeneratedImage.h: Ditto.
• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw): Add a new argument of type DecodingMode.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the sizeForDrawing argument by a DecodingMode argument. Add a new handling
for decoding asynchronously for the image full size.

• platform/graphics/cg/ImageDecoderCG.h: Change the prototype of the function.
• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw): Add a new argument of type DecodingMode.

• platform/graphics/cg/PDFDocumentImage.h:
• platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize): Pass DecodingMode::Synchronous to Image::draw().
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Ditto.

• platform/graphics/win/ImageDecoderDirect2D.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the sizeForDrawing argument by a DecodingMode argument.

• platform/graphics/win/ImageDecoderDirect2D.h: Change the prototype of the function.
• platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the sizeForDrawing argument by a DecodingMode argument.

• platform/image-decoders/ImageDecoder.h: Change the prototype of the function.
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Draw the background image asynchronously if the image size is large.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect): Draw the background image element asynchronously if the image size is large.

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawForContainer): Pass DecodingMode::Synchronous to draw().
(WebCore::SVGImage::nativeImageForCurrentFrame): Ditto.
(WebCore::SVGImage::nativeImage): Ditto.
(WebCore::SVGImage::draw): Add a new argument of type DecodingMode.

• svg/graphics/SVGImage.h: Change the prototype of the function.
• svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::draw): Add a new argument of type DecodingMode.

• svg/graphics/SVGImageForContainer.h: Change the prototype of the function.

LayoutTests:

• fast/images/animated-image-different-dest-size-expected.html: Added.
• fast/images/animated-image-different-dest-size.html: Added.

This test crashes without this patch.

• fast/images/animated-image-loop-count.html:

Clear the memory cache so the test can be not flaky. Running it with -repeat-each was failing.

• fast/images/async-image-background-image-expected.html: Added.
• fast/images/async-image-background-image.html: Added.

Ensures the background image can be drawn asynchronously if it is large.

• fast/images/async-image-canvas-draw-image-expected.html: Added.
• fast/images/async-image-canvas-draw-image.html: Added.

Ensures the image is drawn synchronously on the canvas regardless of its size.

• fast/images/ordered-animated-image-frames.html:

Clear the memory cache so the test can be not flaky. Running it with -repeat-each was failing.

• fast/images/reset-image-animation-expected.txt:
• fast/images/reset-image-animation.html:

Change how the steps of the test are ordered so the test can be not flaky.
Running it with -repeat-each was failing.

• fast/images/resources/red-green-blue-900-300.png: Added.

7:06 PM Changeset in webkit [214449] by aestes@apple.com

• 3 edits in trunk/Source/WebKit2

[iOS] Suppress page count recalc when setting a snapshot paper rect
​https://bugs.webkit.org/show_bug.cgi?id=170156
<rdar://problem/30787872>

Reviewed by Tim Horton.

When _WKWebViewPrintFormatter computes a page count for snapshotting, it updates the paper
rect, which triggers UIKit to ask for the page count again while we're in the middle of
printing, putting us in a bad state.

Suppress page count recalc while setting the new paper rect, since we know this will not
cause it to change.

• UIProcess/_WKWebViewPrintFormatter.mm:

(-[_WKWebViewPrintFormatter _setSnapshotPaperRect:]): Temporarily set
_suppressPageCountRecalc to YES before updating the paper rect.
(-[_WKWebViewPrintFormatter _setNeedsRecalc]): Only call [super _setNeedsRecalc] if
_suppressPageCountRecalc is NO.

• UIProcess/_WKWebViewPrintFormatterInternal.h: Declared -_setNeedsRecalc.

7:02 PM Changeset in webkit [214448] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

[WK2] Callout Bar should be dismissed during data interaction
​https://bugs.webkit.org/show_bug.cgi?id=170109
<rdar://problem/31171570>

Reviewed by Tim Horton.

Minor tweak to get the callout bar to duck during data interaction. Import a new UIKit SPI header in WebKit2.

• Platform/spi/ios/UIKitSPI.h:

6:48 PM Changeset in webkit [214447] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Test commit against new svn server.

6:31 PM Changeset in webkit [214446] by Lucas Forschler

• 2 edits in trunk/Tools

<rdar://problem/30949128>
Update build.webkit.org to use port 16000 for PBChangeSource.

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

5:32 PM Changeset in webkit [214445] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Activate release libwebrtc logging when WebRTC log channel is on
​https://bugs.webkit.org/show_bug.cgi?id=169659

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-27
Reviewed by Alex Christensen.

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::initializePeerConnectionFactoryAndThreads):

5:16 PM Changeset in webkit [214444] by Keith Rollin

• 2 edits in trunk/Source/WebKit2

Update NetworkResourceLoader logging statement
​https://bugs.webkit.org/show_bug.cgi?id=170126

Reviewed by Alex Christensen.

NetworkResourceLoader contains a logging statement that prints, in
part: "start: Retrieving resource from cache". This is misleading,
since it's not necessarily the case that the resource will be loaded
from the cache. What is actually happening at the point where that is
logged is that the cache is being checked for the resource. It still
remains to be seen if the resource will be found in it. To address
this, change the logging to say "start: Checking cache for resource".

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

5:06 PM Changeset in webkit [214443] by Antti Koivisto

• 10 edits in trunk/Source/WebCore

Move visibleInViewportStateChanged callback from Element to render tree
​https://bugs.webkit.org/show_bug.cgi?id=170039

Reviewed by Zalan Bujtas.

Make it easier to use from the render tree.

Also for simplicity move the bits from RenderObject rare data to RenderElement.
There is plenty of space there.

• dom/Element.h:

(WebCore::Element::isVisibleInViewportChanged): Deleted.

• html/HTMLMediaElement.h:
• rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::registerForVisibleInViewportCallback):
(WebCore::RenderElement::unregisterForVisibleInViewportCallback):
(WebCore::RenderElement::setVisibleInViewportState):
(WebCore::RenderElement::visibleInViewportStateChanged):

• rendering/RenderElement.h:

(WebCore::RenderElement::visibleInViewportState):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::setIsRegisteredForVisibleInViewportCallback): Deleted.
(WebCore::RenderObject::setVisibleInViewportState): Deleted.

• rendering/RenderObject.h:

(WebCore::RenderObject::hasOutlineAutoAncestor):
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
(WebCore::RenderObject::isRegisteredForVisibleInViewportCallback): Deleted.
(WebCore::RenderObject::visibleInViewportState): Deleted.

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::visibleInViewportStateChanged):

• rendering/RenderVideo.h:
• rendering/RenderView.cpp:

(WebCore::RenderView::updateVisibleViewportRect):

4:37 PM Changeset in webkit [214442] by commit-queue@webkit.org

• 5 edits in trunk/Source

Web Inspector: Saving files should not suggest the top level directory
​https://bugs.webkit.org/show_bug.cgi?id=170085
<rdar://problem/30197794>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-27
Reviewed by Matt Baker.

Source/WebKit/mac:

• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
Don't set panel.directoryURL unless we have a good suggestion.

Source/WebKit2:

• UIProcess/mac/RemoteWebInspectorProxyMac.mm:

(WebKit::RemoteWebInspectorProxy::platformSave):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformSave):
Don't set panel.directoryURL unless we have a good suggestion.

4:36 PM Changeset in webkit [214441] by commit-queue@webkit.org

• 13 edits in trunk

addIceCandidate should not throw if passed null or undefined
​https://bugs.webkit.org/show_bug.cgi?id=170118

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-27
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:

Source/WebCore:

Covered by updated test.

A null/undefined candidate passed to addIceCandidate means end of Ice candidate..

• Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::addIceCandidate):

• Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::endOfIceCandidates):

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::queuedAddIceCandidate):

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnection.js:

(addIceCandidate):

LayoutTests:

Updating test to log addIceCandidate rejection.

• webrtc/datachannel/basic.html:
• webrtc/routines.js:

(iceCallback1):
(iceCallback2):
(onAddIceCandidateError):

4:32 PM Changeset in webkit [214440] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Add delegate method to let an WebKit client provide a custom image preview controller.
​https://bugs.webkit.org/show_bug.cgi?id=170076
rdar://problem/31153051

Add a new delegate method (_webView:previewViewControllerForImage:alternateURL:defaultActions:elementInfo:) to
WKUIDelegatePrivate, an client can use this method to provide a custom image preview view controller if the image
has alternated URL or custom image info.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2017-03-27
Reviewed by Beth Dakin.

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Add delegate method _webView:previewViewControllerForImage:alternateURL:defaultActions:elementInfo:.
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _presentedViewControllerForPreviewItemController:]): If the image has alternated URL or custom info, try to use the client-provided

preview view controller. Otherwise, use the default WKImagePreviewViewController.

4:31 PM Changeset in webkit [214439] by webkit@devinrousso.com

• 12 edits in trunk/Source/WebInspectorUI

Web Inspector: The inspector sidebar has weird sub-column sizing issues
​https://bugs.webkit.org/show_bug.cgi?id=161966

Reviewed by Joseph Pecoraro.

• UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.resizerDragEnded):
(WebInspector.Sidebar.prototype._recalculateWidth):
Ensure that the selected sidebar panel is notified of the size change (sizeDidChange) when
the resizer drag ends.

• UserInterface/Views/DetailsSectionDataGridRow.js:

(WebInspector.DetailsSectionDataGridRow.prototype.sizeDidChange):

• UserInterface/Views/ProbeSetDetailsSection.js:

(WebInspector.ProbeSetDetailsSection.prototype.sizeDidChange):
Add/update the sizeDidChange protected function.

• UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel.prototype.initialLayout):
(WebInspector.ComputedStyleDetailsPanel.prototype.sizeDidChange):

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype.sizeDidChange):

• UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WebInspector.LayerTreeDetailsSidebarPanel.prototype.sizeDidChange):

• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype.sizeDidChange):

• UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel.prototype.sizeDidChange):
Update the contained DataGrid elements whenever the sidebar size changes so that the resizer
elements are positioned correctly.

• UserInterface/Views/View.js:

(WebInspector.View.prototype.updateLayoutIfNeeded):

• UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):

• UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype.updateLayoutIfNeeded):
Ensure the layoutReason is also propagated.

4:24 PM Changeset in webkit [214438] by jfbastien@apple.com

• 4 edits
  2 adds in trunk

WebAssembly: misc memory testing
​https://bugs.webkit.org/show_bug.cgi?id=170137

Reviewed by Keith Miller.

JSTests:

• wasm/assert.js: handle newlines in code we print out, avoid regex
• wasm/function-tests/memory-import-and-grow.js: Added.

(const.instantiate):
(const.test):

• wasm/function-tests/memory-section-and-import.js: Added.

(const.instantiate):

Source/JavaScriptCore:

• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::WebAssemblyInstanceConstructor::createInstance): improve error messages

4:21 PM Changeset in webkit [214437] by Ryan Haddad

• 1 edit
  3 adds in trunk/LayoutTests

Rebaseline svg/css/getComputedStyle-basic.xhtml for macOS.

Unreviewed test gardening.

• platform/mac-elcapitan/svg/css/getComputedStyle-basic-expected.txt: Added.
• platform/mac/svg/css/getComputedStyle-basic-expected.txt: Added.

4:19 PM Changeset in webkit [214436] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Resource Details Sidebar displays previous image metrics when viewing resource where content load failed
​https://bugs.webkit.org/show_bug.cgi?id=170065
<rdar://problem/27081591>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-27
Reviewed by Matt Baker.

• UserInterface/Models/Resource.js:

(WebInspector.Resource.prototype.getImageSize.imageDidLoad):
(WebInspector.Resource.prototype.getImageSize.requestContentFailure):
(WebInspector.Resource.prototype.getImageSize):
If the requestContent failed, return a null image size.

• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection.hideImageSection):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):
If the callback is called with a null size, hide the image size section.

3:56 PM Changeset in webkit [214435] by Antti Koivisto

• 15 edits
  2 adds in trunk

Source/WebCore:
Allow the page to render before <link> stylesheet tags in body
​https://bugs.webkit.org/show_bug.cgi?id=149157
<rdar://problem/24658830>

Reviewed by Simon Fraser.

Currently we block style and renderer building completely if document has any loading
stylesheets. In case a script queries something layout dependent we construct the render
tree with whatever style we have but block painting in it.

This patch changes behavior so that a loading stylesheet in body only blocks rendering for elements
that are after it. The expectation is that such stylesheets rarely affect elements before them
and the elements can be rendered without causing ugly visible styling changes.

The patch replaces the old flash-of-unstyled-content (FOUC) preventation mechanism with a more
fine-grained one. Paint blocking is now done on per-renderer basis with based on isNonFinal flag in
RenderStyle.

For stylesheets in head the behavior should be largely unchanged.

Test: http/tests/incremental/stylesheet-body-incremental-rendering.html

• css/StyleResolver.cpp:

(WebCore::StyleResolver::pseudoStyleRulesForElement):

• dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::resolveStyle):
(WebCore::Document::updateLayoutIgnorePendingStylesheets):

Remove the old FOUC preventation state tracking.

(WebCore::Document::shouldScheduleLayout):
(WebCore::Document::didRemoveAllPendingStylesheet):

Repaints will now get triggered by the normal style mechanism.

• dom/Document.h:

(WebCore::Document::hasNodesWithNonFinalStyle):
(WebCore::Document::setHasNodesWithNonFinalStyle):

Track if we need to recompute the style later because non-final or unstyled elements.

(WebCore::Document::didLayoutWithPendingStylesheets): Deleted.
(WebCore::Document::hasNodesWithPlaceholderStyle): Deleted.
(WebCore::Document::setHasNodesWithPlaceholderStyle): Deleted.

• html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::rendererIsNeeded):

• page/FrameView.cpp:

(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):

Don't qualify as visually non-empty if we have loading stylesheets in head (even if there is
a fouc-prevented render tree).

(WebCore::FrameView::fireLayoutRelatedMilestonesIfNeeded):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintContents):

Instead of a global test, block painting if isNonFinal is set in the renderer's style.

• rendering/RenderLayer.cpp:

(WebCore::shouldSuppressPaintingLayer):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaint):

The isNonFinal flag prevents painting so we need to trigger repaint when it gets cleared.

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::isNotFinal):
(WebCore::RenderStyle::setIsNotFinal):
(WebCore::RenderStyle::isPlaceholderStyle): Deleted.
(WebCore::RenderStyle::setIsPlaceholderStyle): Deleted.

There is no need for placeholder styles anymore. Reuse the bit for isNotFinal.

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

• rendering/style/StyleRareNonInheritedData.h:
• style/StyleScope.cpp:

(WebCore::Style::Scope::analyzeStyleSheetChange):
(WebCore::Style::Scope::updateActiveStyleSheets):

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::TreeResolver::resolveElement):

If we have seens a loading stylesheet and don't have a renderer yet don't style the element.
In case there is a renderer or we are ignoring pending sheets, resolve the style normally
but mark it as non-final.

(WebCore::Style::makePlaceholderStyle): Deleted.

LayoutTests:
Loading in-body stylesheets should not block rendering of elements before them
​https://bugs.webkit.org/show_bug.cgi?id=169345

Reviewed by Simon Fraser.

• http/tests/incremental/resources/delayed-css.php: Added.
• http/tests/incremental/stylesheet-body-incremental-rendering-expected.html: Added.
• http/tests/incremental/stylesheet-body-incremental-rendering.html: Added.

3:22 PM Changeset in webkit [214434] by jmarcell@apple.com

• 4 edits in trunk/Tools

Bots should run the dashboard tests
​https://bugs.webkit.org/show_bug.cgi?id=168994

Reviewed by Daniel Bates and David Kilzer.

We pull the --results-directory argument value out so that RunDashboardTests can override it so that we can separately run the dashboard layout tests.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests): Define a class variable called resultDirectory for the --results-directory argument so that subclasses can override this if needed.
(RunWebKitTests.start): Set the --results-directory argument value to the value of self.resultDirectory.
(RunDashboardTests): Subclass of RunWebKitTests in which we run the layout tests for the Bot Watcher's Dashboard.
(RunDashboardTests.start): Override the --layout-tests-directory to point to the dashboard layout tests.
(ExtractTestResults.addCustomURLs): Update the current results URL label to indicate that it links to layout tests results and add a new link to link to dashboard layout test results.
(TestFactory.init): Update unit tests to account for new RunDashboardTests step.

• BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

3:09 PM Changeset in webkit [214433] by mmaxfield@apple.com

• 5 edits
  2 adds in trunk

Test variation font ranges in the CSS Font Loading API
​https://bugs.webkit.org/show_bug.cgi?id=170022

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/text/variations/font-loading-api-parse-ranges.html

Don't use keywords when reporting font variation range values.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::fontNonKeywordWeightFromStyleValue):
(WebCore::ComputedStyleExtractor::fontWeightFromStyleValue):
(WebCore::ComputedStyleExtractor::fontNonKeywordStretchFromStyleValue):
(WebCore::ComputedStyleExtractor::fontStretchFromStyleValue):
(WebCore::ComputedStyleExtractor::fontNonKeywordStyleFromStyleValue):
(WebCore::ComputedStyleExtractor::fontStyleFromStyleValue):

• css/CSSComputedStyleDeclaration.h:
• css/FontFace.cpp:

(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):

LayoutTests:

• fast/text/variations/font-loading-api-parse-ranges-expected.txt: Added.
• fast/text/variations/font-loading-api-parse-ranges.html: Added.

2:49 PM Changeset in webkit [214432] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Look for 'ios' test expectations for IOSPorts
​https://bugs.webkit.org/show_bug.cgi?id=169413

Reviewed by Alexey Proskuryakov.

Test expectations for iOS tests should include the 'ios' folder. Modify
default_baseline_search_path to include 'ios' folder and derivatives for
IOSPort.

• Scripts/webkitpy/port/ios.py:

(IOSPort._generate_all_test_configurations): Moved from IOSSimulatorPort.
(IOSPort.default_baseline_search_path): Add ios expectations along with port specific expectations.
(IOSPort.test_expectations_file_position): Added for testing.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._generate_all_test_configurations): Moved to IOSPort.
(IOSSimulatorPort.default_baseline_search_path): Moved to IOSPort.

2:42 PM Changeset in webkit [214431] by Jonathan Bedard

• 2 edits in trunk/Tools

REGRESSION: Reseting _device_map on each child process
<rdar://problem/31274476>

Unreviewed infrastructure fix.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort): Add _DEVICE_MAP class variable.
(IOSSimulatorPort.init): Use shared class variable
(IOSSimulatorPort._device_for_worker_number_map): Use _DEVICE_MAP class variable
(IOSSimulatorPort._create_devices): Ditto.
(IOSSimulatorPort._quit_ios_simulator): Ditto.
(IOSSimulatorPort.clean_up_test_run): Ditto.

2:32 PM Changeset in webkit [214430] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Propagate shipping contact update errors
​https://bugs.webkit.org/show_bug.cgi?id=170141
rdar://problem/31276576

Reviewed by Tim Horton.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

2:20 PM Changeset in webkit [214429] by Ryan Haddad

• 11 edits
  15 deletes in trunk

Unreviewed, rolling out r214411.

Two of the LayoutTests for this change time out on ios-
simulator.

Reverted changeset:

"[Modern Media Controls] Improve media documents across macOS,
iPhone and iPad"
​https://bugs.webkit.org/show_bug.cgi?id=169145
​http://trac.webkit.org/changeset/214411

1:55 PM Changeset in webkit [214428] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix uses of deprecated API
​https://bugs.webkit.org/show_bug.cgi?id=170138
rdar://problem/28882449

Reviewed by Tim Horton.

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toPKContactFields):
(WebKit::toPKAddressField):
(WebKit::toPKPaymentRequest):
Don't use deprecated APIs.

(WebKit::toNSError):
Don't try to insert nil in a dictionary.

12:57 PM Changeset in webkit [214427] by achristensen@apple.com

• 4 edits in trunk/Source/ThirdParty/libwebrtc

Build libwebrtc with even more warnings
​https://bugs.webkit.org/show_bug.cgi?id=169997

Reviewed by Tim Horton.

There are still OSAtomic* functions I don't want to worry about right now,
so I'm keeping a few -Wno-deprecated-declarations, but everything else can go.

• Configurations/libsrtp.xcconfig:
• Configurations/libwebrtc.xcconfig:
• Configurations/libwebrtcpcrtc.xcconfig:

12:44 PM Changeset in webkit [214426] by graouts@webkit.org

• 5 edits in trunk

[Modern Media Controls] Clicking on the tracks button when the tracks panel is up in a media document pauses the video
​https://bugs.webkit.org/show_bug.cgi?id=168517
<rdar://problem/30577636>

Reviewed by Dean Jackson.

Source/WebCore:

We completely turn off default event handling in MediaDocument.cpp since we're implementing the
behavior we expect to pause and resume the video in the modern-media-controls module already. This
gets rid of this odd case where the content would not see the "click" event while the C++ side would
handle it and pause the video.

• Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.handleEvent):
(MediaController.prototype._containerWasClicked): Deleted.

• html/MediaDocument.cpp:

(WebCore::MediaDocument::defaultEventHandler):

LayoutTests:

• media/video-click-dblckick-standalone.html: We disable modern-media-controls here since we know that this test won't pass with them on.

12:40 PM Changeset in webkit [214425] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/time-label/time-label-white-space-nowrap.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169679

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:36 PM Changeset in webkit [214424] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark inspector/dom-debugger/dom-breakpoints.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=170127

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:16 PM Changeset in webkit [214423] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/time-label/time-label.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169678

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

12:09 PM Changeset in webkit [214422] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking two modern-media-controls tests as timeouts.
​https://bugs.webkit.org/show_bug.cgi?id=170123

Unreviewed test gardening.

• platform/ios-simulator/TestExpectations:

11:13 AM Changeset in webkit [214421] by commit-queue@webkit.org

• 10 edits in trunk

Tighten RTCDatachannel creation and parameter getters
​https://bugs.webkit.org/show_bug.cgi?id=170081

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-27
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated tests.

Adding some parameter checks when creating data channels.
Making some getters nullable as per the spec.

• Modules/mediastream/RTCDataChannel.h:
• Modules/mediastream/RTCDataChannel.idl:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::createDataChannel):

• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::createDataChannel):
(WebCore::LibWebRTCMediaEndpoint::addDataChannel):

• platform/mediastream/RTCDataChannelHandler.h:

(): Deleted.

LayoutTests:

• webrtc/datachannel/basic-expected.txt:
• webrtc/datachannel/basic.html:

11:10 AM Changeset in webkit [214420] by commit-queue@webkit.org

• 23 edits
  4 adds in trunk

Add support for RTCRtpReceiver/RTCRtpSender getParameters
​https://bugs.webkit.org/show_bug.cgi?id=170057

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-27
Reviewed by Alex Christensen.

Source/ThirdParty/libwebrtc:

• Source/webrtc/api/mediatypes.h:

Source/WebCore:

Test: webrtc/video-getParameters.html

getParameters returns a dictionary of values taken from libwebrtc RtpReceiverInterface/RtpSenderInrterface objects.
Added a direct link between WebCore RTCRtpReceiver and libwebrtc RtpReceiverInterface object.
Making the link between WebCore RTCRtpSender and libwebrtc RtpSenderInrterface object through
PeerConnectionBackend to keep the current architecture shared with OpenWebRTC.
In the future, we should try to make the link more direct.

Added routines to support the conversion from libwebrtc to WebCore.
Ensured that RTCRtpReceiver is cleaning its backend when being stopped.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):

• Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::getParameters):

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::doClose):
(WebCore::RTCPeerConnection::getParameters):

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCRtpParameters.h: Added.
• Modules/mediastream/RTCRtpParameters.idl: Added.
• Modules/mediastream/RTCRtpReceiver.cpp:

(WebCore::RTCRtpReceiver::RTCRtpReceiver):

• Modules/mediastream/RTCRtpReceiver.h:

(WebCore::RTCRtpReceiver::Backend::~Backend):
(WebCore::RTCRtpReceiver::Backend::getParameters):
(WebCore::RTCRtpReceiver::create):
(WebCore::RTCRtpReceiver::stop):
(WebCore::RTCRtpReceiver::setBackend):
(WebCore::RTCRtpReceiver::getParameters):

• Modules/mediastream/RTCRtpReceiver.idl:
• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::RTCRtpSender):
(WebCore::RTCRtpSender::replaceTrack):
(WebCore::RTCRtpSender::getParameters):

• Modules/mediastream/RTCRtpSender.h:

(WebCore::RTCRtpSender::Backend::~Backend):
(WebCore::RTCRtpSender::isStopped):
(WebCore::RTCRtpSender::stop):

• Modules/mediastream/RTCRtpSender.idl:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTrack):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):
(WebCore::LibWebRTCMediaEndpoint::OnAddTrack):
(WebCore::LibWebRTCMediaEndpoint::stop):
(WebCore::fillEncodingParameters):
(WebCore::fillHeaderExtensionParameters):
(WebCore::fillCodecParameters):
(WebCore::fillRtpParameters):
(WebCore::RTCRtpReceiverBackend::getParameters):
(WebCore::LibWebRTCMediaEndpoint::getRTCRtpSenderParameters):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::notifyAddedTrack):
(WebCore::LibWebRTCPeerConnectionBackend::getParameters):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• WebCore.xcodeproj/project.pbxproj:
• platform/mediastream/mac/RealtimeOutgoingAudioSource.h:

LayoutTests:

• webrtc/video-getParameters-expected.txt: Added.
• webrtc/video-getParameters.html: Added.

10:50 AM Changeset in webkit [214419] by mmaxfield@apple.com

• 17 edits in trunk

font variation properties don't need to accept numbers
​https://bugs.webkit.org/show_bug.cgi?id=169357

Reviewed by Antti Koivisto.

Source/WebCore:

The CSS Fonts level 4 spec stabilized the grammar accepted by font-weight,
font-style, and font-stretch. The changes are that font-style and
font-stretch no longer accept raw numbers, and the @font-face descriptor
ranges are now separated by spaces instead of slashes.

Tests: fast/text/font-selection-font-face-parse.html

fast/text/font-selection-font-loading-api-parse.html
fast/text/font-stretch-parse.html
fast/text/font-style-parse.html
fast/text/variations/font-selection-properties.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::fontWeightFromStyleValue):
(WebCore::fontWeightFromStyle):
(WebCore::ComputedStyleExtractor::fontStretchFromStyleValue):
(WebCore::fontStretchFromStyle):
(WebCore::ComputedStyleExtractor::fontStyleFromStyleValue):
(WebCore::fontStyleFromStyle):

• css/CSSComputedStyleDeclaration.h:
• css/FontFace.cpp:

(WebCore::FontFace::style):
(WebCore::FontFace::weight):
(WebCore::FontFace::stretch):
(WebCore::rangeIsSingleValue): Deleted.

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontStretchFromValue):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontWeightRange):
(WebCore::consumeFontStretch):
(WebCore::consumeFontStretchRange):
(WebCore::consumeFontStyle):
(WebCore::consumeFontStyleRange):

LayoutTests:

• fast/text/font-selection-font-face-parse-expected.txt:
• fast/text/font-selection-font-face-parse.html:
• fast/text/font-selection-font-loading-api-parse-expected.txt:
• fast/text/font-selection-font-loading-api-parse.html:
• fast/text/font-stretch-parse-expected.txt:
• fast/text/font-stretch-parse.html:
• fast/text/font-style-parse-expected.txt:
• fast/text/font-style-parse.html:
• fast/text/variations/font-selection-properties.html:
• platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:

10:48 AM Changeset in webkit [214418] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Further optimize checkWebRTCAvailability
​https://bugs.webkit.org/show_bug.cgi?id=169147

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-27
Reviewed by Alex Christensen.

Tested locally by removing libwebrtc.dylib.
Replacing dlopen check by checking an exported symbol, rtc::LogMessage::LogToDebug.
This check is more efficient and accurate. It should work in more configurations than the previous one.

• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::isNullFunctionPointer):
(WebCore::LibWebRTCProvider::webRTCAvailable):

10:21 AM Changeset in webkit [214417] by Jonathan Bedard

• 2 edits in trunk/Tools

REGRESSION: Failing to iterate over Simulator.managed_devices map
<rdar://problem/31274476>

Unreviewed infrastructure fix.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._create_devices): Iterate through managed_devices by worker number.

9:39 AM Changeset in webkit [214416] by msaboff@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Add ARM64 system instructions to disassembler
​https://bugs.webkit.org/show_bug.cgi?id=170084

Reviewed by Saam Barati.

This changes adds support for MRS and MSR instructions, and refactors the DMB
disassembly to handle all of the barrier instructions.

• disassembler/ARM64/A64DOpcode.cpp:

(JSC::ARM64Disassembler::A64DOpcodeMSRImmediate::format):
(JSC::ARM64Disassembler::A64DOpcodeMSROrMRSRegister::format):
(JSC::ARM64Disassembler::A64DOpcodeSystemSync::format):
(JSC::ARM64Disassembler::A64DOpcodeDmb::format): Deleted.

• disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64DOpcodeSystem::lBit):
(JSC::ARM64Disassembler::A64DOpcodeSystem::op0):
(JSC::ARM64Disassembler::A64DOpcodeSystem::op1):
(JSC::ARM64Disassembler::A64DOpcodeSystem::crN):
(JSC::ARM64Disassembler::A64DOpcodeSystem::crM):
(JSC::ARM64Disassembler::A64DOpcodeSystem::op2):
(JSC::ARM64Disassembler::A64DOpcodeMSROrMRSRegister::opName):
(JSC::ARM64Disassembler::A64DOpcodeMSROrMRSRegister::systemRegister):
(JSC::ARM64Disassembler::A64DOpcodeSystemSync::opName):
(JSC::ARM64Disassembler::A64DOpcodeSystemSync::option):
(JSC::ARM64Disassembler::A64DOpcodeDmb::opName): Deleted.
(JSC::ARM64Disassembler::A64DOpcodeDmb::option): Deleted.
(JSC::ARM64Disassembler::A64DOpcodeDmb::crM): Deleted.

9:18 AM Changeset in webkit [214415] by mmaxfield@apple.com

• 3 edits
  2 adds in trunk

Implement format specifier for variation fonts
​https://bugs.webkit.org/show_bug.cgi?id=169327

Reviewed by Simon Fraser.

Source/WebCore:

Variation fonts require the format("woff-variations"), format("truetype-variations"),
and format("opentype-variations") format specifies in @font-face rules.

Test: fast/text/variations/font-face-format.html

• platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::supportsFormat):

LayoutTests:

• fast/text/variations/font-face-format-expected.html: Added.
• fast/text/variations/font-face-format.html: Added.

9:12 AM Changeset in webkit [214414] by mmaxfield@apple.com

• 6 edits
  6 adds in trunk

Make sure animation works for font-weight, font-stretch, and font-style
​https://bugs.webkit.org/show_bug.cgi?id=169683

Reviewed by Simon Fraser.

Source/WebCore:

Hook up animation code for FontSelectionValues.

Tests: animations/font-variations/font-stretch.html

animations/font-variations/font-style.html
animations/font-variations/font-weight.html

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setFontWeight):
(WebCore::RenderStyle::setFontStretch):
(WebCore::RenderStyle::setFontItalic):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::fontWeight):
(WebCore::RenderStyle::fontStretch):
(WebCore::RenderStyle::fontItalic):

LayoutTests:

• animations/font-variations/font-stretch-expected.txt: Added.
• animations/font-variations/font-stretch.html: Added.
• animations/font-variations/font-style-expected.txt: Added.
• animations/font-variations/font-style.html: Added.
• animations/font-variations/font-weight-expected.txt: Added.
• animations/font-variations/font-weight.html: Added.
• animations/resources/animation-test-helpers.js:

(compareFontStyle):
(getPropertyValue):
(comparePropertyValue):

8:43 AM Changeset in webkit [214413] by achristensen@apple.com

• 33 edits
  9 adds in trunk

Make WebSockets work in network process
​https://bugs.webkit.org/show_bug.cgi?id=169930

Reviewed by Youenn Fablet.

Source/WebCore:

Covered by 136 existing tests in http/tests/websocket/tests/hybi
This also does fine with the 544 websocket tests in the web-platform-tests which we have not yet imported.
Also added http/tests/websocket/tests/hybi/network-process-crash-error.html
to test a new condition that couldn't happen before this move: the NetworkProcess crashing.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):
We were asserting that didCloseSocketStream was called. It is still called,
but not synchronously like it used to. This assertion is now invalid, but tests
that would hit it still pass.

• platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):
CFWriteStreamCanAcceptBytes crashes if you give it a null parameter, and that can happen now.
If we have no write stream, then we cannot write. Tests that hit this pass still.

Source/WebKit2:

This adds WebSocketStream, which is a SocketStreamHandle that sends asynchronous
messages to a NetworkSocketStream in the NetworkProcess. WebKit1 uses a SocketStreamHandleImpl
still, but WebKit2 now has a SocketStreamHandleImpl in the NetworkProcess owned by the
NetworkSocketStream, which is a SocketStreamHandleClient that sends asynchronous messages back
to the WebProcess. WebSocketStream's implementation of SocketStreamHandle::platformSend is special
because it stores the completion handler in a map and asynchronously reports to the caller whether
it succeeded or not. If the network processes crashes before the completion handlers are called,
then they are called indicating failure and an error is reported, but that never happens, right?

• CMakeLists.txt:
• DerivedSources.make:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::createSocketStream):
(WebKit::NetworkConnectionToWebProcess::destroySocketStream):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::setAllowsAnySSLCertificateForWebSocket):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkSocketStream.cpp: Added.

(WebKit::NetworkSocketStream::create):
(WebKit::NetworkSocketStream::NetworkSocketStream):
(WebKit::NetworkSocketStream::sendData):
(WebKit::NetworkSocketStream::close):
(WebKit::NetworkSocketStream::didOpenSocketStream):
(WebKit::NetworkSocketStream::didCloseSocketStream):
(WebKit::NetworkSocketStream::didReceiveSocketStreamData):
(WebKit::NetworkSocketStream::didFailToReceiveSocketStreamData):
(WebKit::NetworkSocketStream::didUpdateBufferedAmount):
(WebKit::NetworkSocketStream::didFailSocketStream):
(WebKit::NetworkSocketStream::messageSenderConnection):
(WebKit::NetworkSocketStream::messageSenderDestinationID):

• NetworkProcess/NetworkSocketStream.h: Added.
• NetworkProcess/NetworkSocketStream.messages.in: Added.
• UIProcess/API/C/WKContext.cpp:

(WKContextSetAllowsAnySSLCertificateForWebSocketTesting):
(WKContextTerminateNetworkProcess):

• UIProcess/API/C/WKContextPrivate.h:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::sendSyncToNetworkingProcess):
(WebKit::WebProcessPool::setAllowsAnySSLCertificateForWebSocket):
(WebKit::WebProcessPool::terminateNetworkProcess):

• UIProcess/WebProcessPool.h:
• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):

• WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

• WebProcess/Network/WebSocketStream.cpp: Added.

(WebKit::globalWebSocketStreamMap):
(WebKit::WebSocketStream::streamWithIdentifier):
(WebKit::WebSocketStream::networkProcessCrashed):
(WebKit::WebSocketStream::create):
(WebKit::WebSocketStream::WebSocketStream):
(WebKit::WebSocketStream::~WebSocketStream):
(WebKit::WebSocketStream::messageSenderConnection):
(WebKit::WebSocketStream::messageSenderDestinationID):
(WebKit::WebSocketStream::platformSend):
(WebKit::WebSocketStream::didSendData):
(WebKit::WebSocketStream::platformClose):
(WebKit::WebSocketStream::bufferedAmount):
(WebKit::WebSocketStream::didOpenSocketStream):
(WebKit::WebSocketStream::didCloseSocketStream):
(WebKit::WebSocketStream::didReceiveSocketStreamData):
(WebKit::WebSocketStream::didFailToReceiveSocketStreamData):
(WebKit::WebSocketStream::didUpdateBufferedAmount):
(WebKit::WebSocketStream::didFailSocketStream):

• WebProcess/Network/WebSocketStream.h: Added.
• WebProcess/Network/WebSocketStream.messages.in: Added.
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::networkProcessConnectionClosed):

Tools:

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

Add terminateNetworkProcess for the new test
http/tests/websocket/tests/hybi/network-process-crash-error.html

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAllowsAnySSLCertificate):
(WTR::TestRunner::terminateNetworkProcess):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::setAllowsAnySSLCertificate):
(WTR::TestController::terminateNetworkProcess):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformContext):

• WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformContext):
(WTR::TestController::platformLibraryPathForTesting):
Add some infrastructure for http/tests/websocket/tests/hybi/simple-wss.html
which calls testRunner.setAllowsAnySSLCertificate. It used to only be effective
for the WebProcess, but SocketStreamHandleImpl::createStreams is now in the NetworkProcess,
and we need its call to Settings::allowsAnySSLCertificate to be loosened for this test,
which tests that wss works, but our test certificate has an invalid certificate chain.
We want production software to not have the ability to have its security weakened, so this
is a test code path that is only implemented in WebKitTestRunner.

LayoutTests:

• http/tests/websocket/tests/hybi/network-process-crash-error-expected.txt: Added.
• http/tests/websocket/tests/hybi/network-process-crash-error.html: Added.
• http/tests/websocket/tests/hybi/slow-reply_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

• platform/ios-simulator-wk1/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

6:38 AM Changeset in webkit [214412] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

[GTK] NetscapePluginX11::m_windowID is unused/unneeded
​https://bugs.webkit.org/show_bug.cgi?id=170115

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-03-27
Reviewed by Michael Catanzaro.

• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePluginX11::NetscapePluginX11):
Remove the unneeded NetscapePluginX11::m_windowID member.

• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:

Remove the unneeded NetscapePluginX11::m_windowID member.

2:37 AM Changeset in webkit [214411] by commit-queue@webkit.org

• 11 edits
  2 copies
  17 adds in trunk

[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
​https://bugs.webkit.org/show_bug.cgi?id=169145
<rdar://problem/17048858>

Patch by Antoine Quint <Antoine Quint> on 2017-03-27
Reviewed by Dean Jackson.

Source/WebCore:

There were a variety of issues with media documents, some longstanding, and some specifically
about modern media controls.

One issue was that fullscreen and picture-in-picture buttons would show for audio media documents,
due to using a <video> element to load the audio file. We now have additional logic in MediaController
to identify if the loaded media is really an audio file, and using this information to hide the
fullscreen and picture-in-picture buttons.

Another issue was that we would inject style in MediaDocument.cpp that was specific to modern media
controls when we could have the modern-media-controls module injected CSS handle this styling. We now
use the injected style in the shadow root to size media documents based on the device characteristics
and ensuring that page styles are overridden.

We also simplify how MediaDocument.cpp sets the source of the media element to simply use the "src"
attribute and not a <source> element.

Finally, we introduce a MediaDocumentController class that is instantiated when we're dealing with
a media document to hide the controls while we determine the type of media we're loading (audio vs.
video) in order to apply the appropriate styling without flashes.

As a result of the new styles applied by the modern-media-controls module, media documents have a
similar behavior on macOS and iPad, where we only enforce a min-width for video allowing them
to play at their natural size otherwise, and enforcing a fixed width for audio. On iPhone however,
we want to always play the media at full width, with some padding in the case of audio.

Tests: media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html

media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html
media/modern-media-controls/media-documents/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-video-mac-sizing.html
media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html

• Modules/modern-media-controls/controls/ios-inline-media-controls.css:

(:host(audio) .media-controls.ios.inline > .controls-bar:before,):
(:host(audio) .media-controls.ios.inline > .controls-bar:before): Deleted.

• Modules/modern-media-controls/controls/macos-media-controls.css:

(:host(audio) .media-controls.mac.inline > .controls-bar,):
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint,):
(:host(audio) .media-controls.mac.inline > .controls-bar): Deleted.
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint): Deleted.

• Modules/modern-media-controls/controls/media-document.css: Added.

(:host(.media-document)):
(:host(.media-document.ready)):
(:host(.media-document.audio.mac)):
(:host(.media-document.audio.ipad)):
(:host(.media-document.audio.iphone)):
(:host(.media-document.video.mac)):
(:host(.media-document.video.ipad)):
(:host(.media-document.video.iphone)):

• Modules/modern-media-controls/js-files:
• Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.get isAudio):

• Modules/modern-media-controls/media/media-document-controller.js: Added.

(MediaDocumentController):
(MediaDocumentController.prototype.handleEvent):
(MediaDocumentController.prototype._mediaDocumentHasMetadata):
(MediaDocumentController.prototype._mediaDocumentHasSize):

• Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.syncControl):
(PiPSupport):

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

We add new tests for media documents and related features that cover the following cases:

• checking <video> with only audio tracks does not show the fullscreen button
• checking <video> with only audio tracks does not show the picture-in-picture button
• checking the size used in media documents for audio and video across macOS, iPhone and iPad

• media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
• media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html: Added.
• media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-audio-mac-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
• media/modern-media-controls/media-documents/media-document-video-mac-sizing-expected.txt: Added.
• media/modern-media-controls/media-documents/media-document-video-mac-sizing.html: Added.
• media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
• media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html: Added.
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations: