Timeline
May 30, 2017:
- 10:48 PM Changeset in webkit [217591] by
-
- 4 edits in trunk
Include ScrollingTreeScrollingNode properties in ScrollingTreeFrameScrollingNode::dumpProperties
https://bugs.webkit.org/show_bug.cgi?id=172287
Patch by Frederic Wang <fwang@igalia.com> on 2017-05-30
Reviewed by Simon Fraser.
Source/WebCore:
No new tests, only changes in dumped tree.
- page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
(WebCore::ScrollingTreeFrameScrollingNode::dumpProperties): Print properties of the parent class.
LayoutTests:
Update iOS expectation to include the new node properties.
- scrollingcoordinator/ios/ui-scrolling-tree-expected.txt: Update expectation.
- 10:15 PM Changeset in webkit [217590] by
-
- 2 edits in trunk/Source/WebCore
Update test result after r217585.
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
(WebCore::JSTestNamedDeleterWithIndexedGetter::deleteProperty):
(WebCore::JSTestNamedDeleterWithIndexedGetter::deletePropertyByIndex):
- 8:09 PM Changeset in webkit [217589] by
-
- 2 edits in trunk/Source/WebCore
Fixed the build after r217588.
- page/FrameView.h: Stopped exporting a function defined inline.
- 8:01 PM Changeset in webkit [217588] by
-
- 2 edits in trunk/Source/WebCore
ASSERTION FAILED: m_layoutPhase == InPostLayerPositionsUpdatedAfterLayout m_layoutPhase == OutsideLayout https://bugs.webkit.org/show_bug.cgi?id=171501
<rdar://problem/31977453>
Reviewed by Simon Fraser.
We should be able to paint as long as the tree is clean and we are in paintable state.
- page/FrameView.cpp:
(WebCore::FrameView::paintContents):
- 5:44 PM Changeset in webkit [217587] by
-
- 11 edits2 adds in trunk
Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
https://bugs.webkit.org/show_bug.cgi?id=172735
<rdar://problem/32015977>
Reviewed by Enrica Casucci.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView applyAutocorrection:toString:withCompletionHandler:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Expose applyAutocorrection on the WKTesting category for use from UIScriptController.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::syncApplyAutocorrection):
If there is a range selection and it precisely matches the autocorrection's "before"
string, allow the autocorrection to take place.
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::applyAutocorrection):
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::applyAutocorrection):
- TestRunnerShared/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::applyAutocorrection):
Expose applyAutocorrection to UIScriptController. Use a WKTesting method
because I don't know how to tap the button in the autocorrection bar from a test.
- fast/events/ios/autocorrect-with-range-selection-expected.txt: Added.
- fast/events/ios/autocorrect-with-range-selection.html: Added.
Add a test that ensures that autocorrection with a selection succeeds.
- 4:55 PM Changeset in webkit [217586] by
-
- 3 edits in trunk/Source/WebCore
Revert accidentally checked in change.
- crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp:
- crypto/mac/CryptoDigestAlgorithm.h:
- 4:54 PM Changeset in webkit [217585] by
-
- 18 edits15 adds in trunk
[WebIDL] Generate named property deleters
https://bugs.webkit.org/show_bug.cgi?id=172688
Reviewed by Chris Dumez.
Source/WebCore:
Test: js/dom/named-property-deleter.html
- WebCore.xcodeproj/project.pbxproj:
Add new file, JSDOMAbstractOperations.h
- bindings/js/JSDOMAbstractOperations.h: Added.
(WebCore::isVisibleNamedProperty):
Add an implementation of the abstract operation WebIDL calls the 'named property visibility algorithm'.
It is used by many WebIDL algorithms, but currently I am only using this implementation for deleters.
In the future, we should try and move the other property access generators to use it as well.
- bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty): Deleted.
(WebCore::JSDOMStringMap::deletePropertyByIndex): Deleted.
- bindings/js/JSStorageCustom.cpp:
(WebCore::JSStorage::deleteProperty): Deleted.
(WebCore::JSStorage::deletePropertyByIndex): Deleted.
Remove now generated deleteProperty and deletePropertyByIndex implementations.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateDeletePropertyCommon):
(GenerateDeletePropertyDefinition):
(GenerateDeletePropertyByIndexDefinition):
(GenerateNamedDeleterDefinition):
Added generation for named deleters. We generate both deleteProperty and deletePropertyByIndex.
(InstanceOverridesDelete):
Add predicate for whether the header should declare deleteProperty and deletePropertyByIndex.
(GenerateHeader):
Move property access hook declarations closer to each other. Use new InstanceOverridesDelete
predicate for deleteProperty and deletePropertyByIndex.
(GenerateImplementation):
Add call to generate named deleter if one exists.
(GenerateConstructorHelperMethods):
Remove an old FIXME that that was no longer true, there are no more interfaces that inherit from
an interface with [NoInterfaceObject].
- dom/DOMStringMap.idl:
Removes CustomDeleteProperty and sorts extended attributes.
- dom/DatasetDOMStringMap.h:
- dom/DatasetDOMStringMap.cpp:
(WebCore::DatasetDOMStringMap::isSupportedPropertyName):
Added. This is a bindings support function (much like supportedPropertyNames()) that is
used JSDOMAbstractOperations.h's isVisibleNamedProperty.
(WebCore::DatasetDOMStringMap::supportedPropertyNames):
Convert to an early return.
(WebCore::DatasetDOMStringMap::deleteNamedProperty):
(WebCore::DatasetDOMStringMap::deleteItem): Deleted.
Renamed deleteItem to deleteNamedProperty, which is the name the bindings use for deleter
operations without an identifier.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
Fix incorrect indentation that bothered me.
- storage/Storage.cpp:
- storage/Storage.h:
- Remove isDisabledByPrivateBrowsing(), which had no definition.
- Add isSupportedPropertyName(), which the deleter code (via the isVisibleNamedProperty algorithm) needs.
- storage/Storage.idl:
Removes CustomDeleteProperty, sorts the extended attributes, adds 'deleter' special
to the removeItem operation and adds a commented out 'setter' special to the 'setItem'
operation.
- bindings/scripts/test/JS/JSTestObj.h:
Update result for declarations moving around.
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp: Added.
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.h: Added.
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp: Added.
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.h: Added.
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp: Added.
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.h: Added.
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp: Added.
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.h: Added.
- bindings/scripts/test/TestNamedDeleterNoIdentifier.idl: Added.
- bindings/scripts/test/TestNamedDeleterThrowingException.idl: Added.
- bindings/scripts/test/TestNamedDeleterWithIdentifier.idl: Added.
- bindings/scripts/test/TestNamedDeleterWithIndexedGetter.idl: Added.
Add new tests for named deleters.
LayoutTests:
- js/dom/named-property-deleter-expected.txt: Added.
- js/dom/named-property-deleter.html: Added.
Add test for various named deleter conditions.
- storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
- storage/domstorage/localstorage/delete-defineproperty-removal.html:
Update test to log more information about what its doing and log it to the DOM rather
than the console, to make comparing results in browsers easier. Also, note in the
bug that the results are wrong, and have been wrong, due to https://webkit.org/b/172687.
- 4:40 PM Changeset in webkit [217584] by
-
- 6 edits in trunk/Source
Web Inspector: images dragged from Inspector to Desktop are named "Unknown.png"
https://bugs.webkit.org/show_bug.cgi?id=141515
<rdar://problem/9251308>
Reviewed by Wenson Hsieh.
Source/WebCore:
- html/HTMLAttributeNames.in:
Source/WebInspectorUI:
- UserInterface/Views/ImageResourceContentView.js:
(WebInspector.ImageResourceContentView.prototype.contentAvailable):
Set a non-standard "filename" attribute to provide a suggested filename
for this <img> containing data: or blob: content.
Source/WebKit2:
In Web Inspector these images are <img src="..."> with data: or blob:
content. In these cases we have the image data but the URL does not
provide a useful name. In fact the name "Unknown.png" comes from
-[NSURLResponse suggestedFilename] for this URL / content.
To start, improve this situation for drags in Web Inspector pages.
If the image element being dragged has a filename attribute use that
as the suggested filename for the drag.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::declareAndWriteDragImage):
- 4:32 PM Changeset in webkit [217583] by
-
- 6 edits in trunk
Add support for Certificate and IceCandidatePair stats
https://bugs.webkit.org/show_bug.cgi?id=172734
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-30
Reviewed by Geoff Garen.
Source/WebCore:
Covered by updated test.
Adding support for these two stats in the IDL and in the libwebrtc binding code.
- Modules/mediastream/RTCStatsReport.h:
(WebCore::RTCStatsReport::IceCandidatePairStats::IceCandidatePairStats):
(WebCore::RTCStatsReport::CertificateStats::CertificateStats):
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::iceCandidatePairState):
(WebCore::fillRTCIceCandidatePairStats):
(WebCore::fillRTCCertificateStats):
(WebCore::LibWebRTCMediaEndpoint::StatsCollector::OnStatsDelivered):
LayoutTests:
- webrtc/video-stats.html:
- 4:23 PM Changeset in webkit [217582] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, add some comments to HKDF/PBKDF2 Mac implementations
- crypto/mac/CryptoAlgorithmHKDFMac.cpp:
(WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
- crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp:
(WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
- 2:59 PM Changeset in webkit [217581] by
-
- 2 edits in trunk/Source/WebCore
m_resourceSelectionTaskQueue tasks should be cleared when player is destroyed to prevent invalid state.
https://bugs.webkit.org/show_bug.cgi?id=172726
rdar://problem/30867764
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-30
Reviewed by Eric Carlson.
I haven't found a reproducible way to make a test case for this race condition.
If m_player is cleared while there is an outstanding task in m_resourceSelectionTaskQueue,
that task may assume m_player is not null and crash. It is better to cancel that task than
to perform it part way with null checks.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::clearMediaPlayer):
- 2:54 PM Changeset in webkit [217580] by
-
- 23 edits in trunk/Source
Only include DataDetectorsUI headers in iOS
https://bugs.webkit.org/show_bug.cgi?id=172633
Reviewed by David Kilzer.
Enable data detectors only on iOS and not other variants of iOS.
Source/WebCore:
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetection.mm:
- page/DragController.cpp:
(WebCore::isDraggableLink):
- platform/cocoa/DataDetectorsCoreSoftLink.h:
- platform/cocoa/DataDetectorsCoreSoftLink.mm:
- platform/spi/cocoa/DataDetectorsCoreSPI.h:
- platform/spi/ios/DataDetectorsUISPI.h:
- platform/spi/mac/DataDetectorsSPI.h:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit2:
- Platform/spi/ios/ManagedConfigurationSPI.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _dataDetectionResults]):
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showDataDetectorsSheet]):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView _didNotHandleTapAsClick:]):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:
(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleTap):
(WebKit::WebPage::handleTwoFingerTapAtPoint):
(WebKit::WebPage::commitPotentialTap):
Source/WTF:
- wtf/FeatureDefines.h:
- wtf/Platform.h:
- 2:42 PM Changeset in webkit [217579] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Merge r210012. rdar://problem/32472141
- 2:35 PM Changeset in webkit [217578] by
-
- 4 edits in trunk
Prevent async methods named 'function' in Object literal
https://bugs.webkit.org/show_bug.cgi?id=172660
Reviewed by Saam Barati.
JSTests:
- stress/async-await-syntax.js:
(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntaxError):
Source/JavaScriptCore:
Prevent async method named 'function' in object.
https://github.com/tc39/ecma262/pull/884
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parsePropertyMethod):
- 2:29 PM Changeset in webkit [217577] by
-
- 6 edits in trunk
ASSERTION FAILED: generator.isConstructor() generator.derivedContextType() == DerivedContextType::DerivedConstructorContext https://bugs.webkit.org/show_bug.cgi?id=171274
Reviewed by Saam Barati.
JSTests:
- stress/async-arrow-functions-lexical-binding-in-class.js:
(shouldBeAsync):
(shouldBeAsyncAndStoreBind):
(promise.new.Promise):
(ChildClass4):
(ChildClass4.prototype.classValue):
(ChildClass4.prototype.get classProperty):
- stress/async-arrow-functions-lexical-super-binding.js:
(A):
(const.childA1.new.prototype.var.f.async):
(const.childA1.new.var):
(const.childA1.new):
(const.childA2.new.prototype.var.f.async):
(const.childA2.new.var):
(const.childA2.new):
(const.childA3.new.prototype.var.f.async):
(const.childA3.new.var):
(const.childA3.new):
(try.childA4.new.prototype.var.f.async):
(try.childA4.new.var):
(try.childA4.new):
(catch):
(const.childA5.new.prototype.var.f.async):
(const.childA5.new.var):
(const.childA5.new):
(checkClass):
(checkClass.new.prototype.var.f.async):
(checkClass.new.var):
(checkClass.new):
(checkClass.new.prototype.method):
(checkClass.new.prototype.prop):
Source/JavaScriptCore:
Current patch allow to use async arrow function within constructor,
and allow to access tothis. Current patch force load 'this' from
virtual scope each time as we access tothisin async arrow function
within constructor it is neccessary because async function can be
suspended andsuperCallcan be called and async function resumed.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPutGeneratorFields):
(JSC::BytecodeGenerator::ensureThis):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::makeFunction):
- 2:19 PM Changeset in webkit [217576] by
-
- 25 edits2 copies1 move in trunk
REGRESSION(r215946): Can't reference a table cell in Google spreadsheet
https://bugs.webkit.org/show_bug.cgi?id=172703
<rdar://problem/32458086>
Reviewed by Ryosuke Niwa.
Source/WebCore:
We updated getClientRects() to return an array of DOMRect objects instead of
a ClientRectList type, to match the latest specification. As it turns out, this
is not Web-compatible as some content (as Google Spreadsheet) relies on the
return type having an item() operation.
This patch re-introduces a DOMRectList type, with an item() operation. The
DOMRectList name is currently not exposed to the Web as we do not know what's
going to get specified yet (https://github.com/w3c/csswg-drafts/issues/1479).
No new tests, updated existing tests.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- dom/DOMRect.h:
- dom/DOMRectList.cpp: Copied from Source/WebCore/dom/DOMRect.cpp.
(WebCore::DOMRectList::DOMRectList):
(WebCore::DOMRectList::~DOMRectList):
- dom/DOMRectList.h: Copied from Source/WebCore/dom/DOMRect.cpp.
(WebCore::DOMRectList::create):
(WebCore::DOMRectList::length):
(WebCore::DOMRectList::item):
- dom/DOMRectList.idl: Renamed from Source/WebCore/dom/DOMRect.cpp.
- dom/Element.cpp:
(WebCore::Element::getClientRects):
- dom/Element.h:
- dom/Element.idl:
- dom/Range.cpp:
(WebCore::Range::getClientRects):
- dom/Range.h:
- dom/Range.idl:
- page/Page.cpp:
(WebCore::Page::nonFastScrollableRects):
(WebCore::Page::touchEventRectsForEvent):
(WebCore::Page::passiveTouchEventListenerRects):
- page/Page.h:
- testing/Internals.cpp:
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::touchEventRectsForEvent):
(WebCore::Internals::passiveTouchEventListenerRects):
(WebCore::Internals::nonFastScrollableRects):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit2:
Fix GObject bindings accordingly.
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectList.cpp:
(WebKit::kit):
(WebKit::core):
(WebKit::wrapDOMRectList):
(webkit_dom_client_rect_list_constructed):
(webkit_dom_client_rect_list_item):
(webkit_dom_client_rect_list_get_length):
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMClientRectListPrivate.h:
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:
(webkit_dom_element_get_client_rects):
LayoutTests:
Update existing tests to reflect behavior change.
- fast/dom/Element/getClientRects-return-type-expected.txt:
- fast/dom/Element/getClientRects-return-type.html:
- fast/dom/Range/getBoundingClientRect-getClientRects-return-type-expected.txt:
- fast/dom/Range/getBoundingClientRect-getClientRects-return-type.html:
- 2:18 PM Changeset in webkit [217575] by
-
- 3 edits50 adds in trunk/LayoutTests
[css-align] Import W3C web platform tests for the CSS Box Alignment feature
https://bugs.webkit.org/show_bug.cgi?id=172705
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
This patch imports the new alignment tests for the CSS Box Alignment test suite
from WPT repository.
- resources/import-expectations.json:
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-001-expected.txt: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-001.html: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-002-expected.txt: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-002.html: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-003-expected.txt: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-003.html: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-004-expected.txt: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-004.html: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-005-expected.txt: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-005.html: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-006-expected.txt: Added.
- web-platform-tests/css/css-align-3/content-distribution/place-content-shorthand-006.html: Added.
- web-platform-tests/css/css-align-3/content-distribution/w3c-import.log: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-001-expected.txt: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-001.html: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-002-expected.txt: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-002.html: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-003-expected.txt: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-003.html: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-004-expected.txt: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-004.html: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-005-expected.txt: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-005.html: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-006-expected.txt: Added.
- web-platform-tests/css/css-align-3/default-alignment/place-items-shorthand-006.html: Added.
- web-platform-tests/css/css-align-3/default-alignment/w3c-import.log: Added.
- web-platform-tests/css/css-align-3/distribution-values/space-evenly-001-expected.xht: Added.
- web-platform-tests/css/css-align-3/distribution-values/space-evenly-001.html: Added.
- web-platform-tests/css/css-align-3/distribution-values/w3c-import.log: Added.
- web-platform-tests/css/css-align-3/resources/alignment-parsing-utils.js: Added.
(checkPlaceShorhand):
(checkPlaceShorhandLonghands):
(checkPlaceShorthandInvalidValues):
- web-platform-tests/css/css-align-3/resources/w3c-import.log: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-001-expected.txt: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-001.html: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-002-expected.txt: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-002.html: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-003-expected.txt: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-003.html: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-004-expected.txt: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-004.html: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-005-expected.txt: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-005.html: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-006-expected.txt: Added.
- web-platform-tests/css/css-align-3/self-alignment/place-self-shorthand-006.html: Added.
- web-platform-tests/css/css-align-3/self-alignment/w3c-import.log: Added.
LayoutTests:
- TestExpectations: Mark as failure a few tests due to bug #172707.
- 2:12 PM Changeset in webkit [217574] by
-
- 2 edits in trunk/Tools
Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
https://bugs.webkit.org/show_bug.cgi?id=172671
Reviewed by Alex Christensen.
We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
- TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
(TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
to trigger a navigation to test it.
(TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
(TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
- 2:08 PM Changeset in webkit [217573] by
-
- 13 edits15 copies5 moves1 add in trunk
[CredentialManagement] Incorporate IDL updates from latest spec
https://bugs.webkit.org/show_bug.cgi?id=172011
Patch by Ali Juma <ajuma@chromium.org> on 2017-05-30
Reviewed by Daniel Bates.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
Source/WebCore:
This patch adds IDL definitions for the CredentialsContainer, CredentialsUserData and
FederatedCredentials interfaces, the NavigatorCredentials partial interface, and the
CredentialCreationOptions, CredentialRequestOptions, FederatedCredentialRequestOptions,
and PasswordCredentialData dictionaries. It also deletes IDL definitions for the
SiteBoundCredential interface and the SiteBoundCredentialData dictionary.
Test: credentials/idlharness.html
- CMakeLists.txt:
- DerivedSources.make:
- Modules/credentials/BasicCredential.idl:
- Modules/credentials/CredentialCreationOptions.h: Copied from Source/WebCore/Modules/credentials/PasswordCredential.cpp.
- Modules/credentials/CredentialCreationOptions.idl: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
- Modules/credentials/CredentialRequestOptions.h: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
- Modules/credentials/CredentialRequestOptions.idl: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
- Modules/credentials/CredentialUserData.h: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
(WebCore::CredentialUserData::~CredentialUserData):
- Modules/credentials/CredentialUserData.idl: Copied from Source/WebCore/Modules/credentials/SiteBoundCredential.idl.
- Modules/credentials/CredentialsContainer.cpp: Copied from Source/WebCore/Modules/credentials/PasswordCredential.cpp.
(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::store):
(WebCore::CredentialsContainer::isCreate):
(WebCore::CredentialsContainer::preventSilentAccess):
- Modules/credentials/CredentialsContainer.h: Copied from Source/WebCore/Modules/credentials/SiteBoundCredential.h.
(WebCore::CredentialsContainer::create):
(WebCore::CredentialsContainer::CredentialsContainer):
- Modules/credentials/CredentialsContainer.idl: Copied from Source/WebCore/Modules/credentials/SiteBoundCredential.idl.
- Modules/credentials/FederatedCredential.cpp: Copied from Source/WebCore/Modules/credentials/SiteBoundCredential.cpp.
(WebCore::FederatedCredential::FederatedCredential):
(WebCore::FederatedCredential::~FederatedCredential):
- Modules/credentials/FederatedCredential.h: Renamed from Source/WebCore/Modules/credentials/SiteBoundCredential.h.
(WebCore::FederatedCredential::create):
(WebCore::FederatedCredential::provider):
(WebCore::FederatedCredential::protocol):
- Modules/credentials/FederatedCredential.idl: Copied from Source/WebCore/Modules/credentials/BasicCredential.idl.
- Modules/credentials/FederatedCredentialInit.h: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
- Modules/credentials/FederatedCredentialInit.idl: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.idl.
- Modules/credentials/FederatedCredentialRequestOptions.h: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
- Modules/credentials/FederatedCredentialRequestOptions.idl: Added.
- Modules/credentials/NavigatorCredentials.cpp: Renamed from Source/WebCore/Modules/credentials/SiteBoundCredential.cpp.
(WebCore::NavigatorCredentials::NavigatorCredentials):
(WebCore::NavigatorCredentials::~NavigatorCredentials):
(WebCore::NavigatorCredentials::supplementName):
(WebCore::NavigatorCredentials::credentials):
(WebCore::NavigatorCredentials::from):
- Modules/credentials/NavigatorCredentials.h: Copied from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
- Modules/credentials/NavigatorCredentials.idl: Renamed from Source/WebCore/Modules/credentials/SiteBoundCredential.idl.
- Modules/credentials/PasswordCredential.cpp:
(WebCore::PasswordCredential::PasswordCredential):
(WebCore::PasswordCredential::~PasswordCredential):
- Modules/credentials/PasswordCredential.h:
(WebCore::PasswordCredential::create):
(WebCore::PasswordCredential::password):
(WebCore::PasswordCredential::setIdName): Deleted.
(WebCore::PasswordCredential::idName): Deleted.
(WebCore::PasswordCredential::setPasswordName): Deleted.
(WebCore::PasswordCredential::passwordName): Deleted.
(WebCore::PasswordCredential::setAdditionalData): Deleted.
(WebCore::PasswordCredential::additionalData): Deleted.
- Modules/credentials/PasswordCredential.idl:
- Modules/credentials/PasswordCredentialData.h: Renamed from Source/WebCore/Modules/credentials/SiteBoundCredentialData.h.
- Modules/credentials/PasswordCredentialData.idl: Renamed from Source/WebCore/Modules/credentials/SiteBoundCredentialData.idl.
- WebCore.xcodeproj/project.pbxproj:
LayoutTests:
- credentials/idlharness-expected.txt:
- credentials/idlharness.html:
- 2:08 PM Changeset in webkit [217572] by
-
- 6 edits in trunk/Tools
webkitpy: Start servers before setting-up for testing
https://bugs.webkit.org/show_bug.cgi?id=172176
<rdar://problem/32225538>
Reviewed by Alexey Proskuryakov.
On-device testing requires that servers are started before ports set-up their
test environments.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.init): Start servers when initializing LayoutTestRunner.
Servers are unconditionally stopped on exit.
(LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
Manager now stops servers.
(LayoutTestRunner.start_servers): Set flag to indicate servers are running.
(LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.init): Delay construction of the test runner until we can determine
if servers need to be started.
(Manager.run): Determine if servers need to be started and construct the test runner.
Shut servers down when the test run is finished.
(Manager._run_tests): Move the determination of servers to run into Manager.run.
- Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
(is_wpt_server_running): Server is not running if no config is found.
- Scripts/webkitpy/layout_tests/servers/websocket_server.py:
(PyWebSocket.is_running): Check if this WebSocket server is running.
- Scripts/webkitpy/port/base.py:
(Port.init): Define secure WebSocket server.
(Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
- 2:01 PM Changeset in webkit [217571] by
-
- 16 edits in trunk
[WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=172603
<rdar://problem/32471306>
Reviewed by Brady Eidson.
Source/WebKit2:
A page loaded in MiniBrowser using WebKit2 cannot show a beforeunload confirm panel (by registering
an onbeforeunload event handler) when it is unloaded. The same page loaded in MiniBrowser using
WebKit1 can show such a confirm panel. We need to add WKUIDelegate SPI so that an embedding client,
such as MiniBrowser, can register to receive a callback to show a beforeunload confirm panel.
- UIProcess/API/APIUIClient.h:
(API::UIClient::runBeforeUnloadConfirmPanel): Modified to take a SecurityOriginData object. This
makes the API consistent with the existing JavaScript dialog callbacks.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Add SPI -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView setUIDelegate:]): Set the delegate of WebKit::UIDelegate to the specified WKUIDelegate
before we set the UI client on the page so as to ensure that API::UIClient callbacks that depend
-respondsToSelector: checks (e.g. API::UIClient::canRunBeforeUnloadConfirmPanel()) return the correct
result. To elaborate further, a API::UIClient client must override both canRunBeforeUnloadConfirmPanel()
and runBeforeUnloadConfirmPanel() to support running a beforeunload confirm dialog. When mapping
the Cocoa SPI, WKUIDelegatePrivate, to API::UIClient we implement API::UIClient::canRunBeforeUnloadConfirmPanel()
in terms of whether the Cocoa delegate responds at runtime to the selector -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:.
We need to do such runtime checks before we pass the API::UIClient to the page. Otherwise, querying
API::UIClient::canRunBeforeUnloadConfirmPanel() will return the wrong result.
- UIProcess/API/gtk/WebKitUIClient.cpp: Modified runBeforeUnloadConfirmPanel() to take a SecurityOriginData object.
- UIProcess/Cocoa/UIDelegate.h: Add declarations for API::UIClient overrides: canRunBeforeUnloadConfirmPanel()
and runBeforeUnloadConfirmPanel(). Add a bit to m_delegateMethods as to whether the Cocoa delegate
responds to selector -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:.
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate): Set the above m_delegateMethods bit if the Cocoa delegate responds
to selector -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:.
(WebKit::UIDelegate::UIClient::canRunBeforeUnloadConfirmPanel): Return whether the above m_delegateMethods
bit was set.
(WebKit::UIDelegate::UIClient::runBeforeUnloadConfirmPanel): Turn around and call -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: (if applicable).
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Modified to take a SecurityOriginData object
and pass it to API::UIClient::runBeforeUnloadConfirmPanel().
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in: Add SecurityOriginData argument to message RunBeforeUnloadConfirmPanel.
Also pass the message for the panel as the last argument so as to make the order of arguments to message
RunBeforeUnloadConfirmPanel more closely match the order of arguments passed to other JavaScript dialog
messages (e.g. RunJavaScriptAlert) for consistency.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel): Include the SecurityOriginData object for the
frame in message RunBeforeUnloadConfirmPanel.
Tools:
Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
unloading is initiated for a page that registered a onbeforeunload handler.
Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
- TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
- TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
(sawDialog):
(-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
- 1:56 PM Changeset in webkit [217570] by
-
- 12 edits in trunk
Update libwebrtc configuration
https://bugs.webkit.org/show_bug.cgi?id=172727
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 1:37 PM Changeset in webkit [217569] by
-
- 2 edits in trunk/LayoutTests
Skip imported/w3c/web-platform-tests/innerText/getter.html.
https://bugs.webkit.org/show_bug.cgi?id=172514
Unreviewed test gardening.
- 1:34 PM Changeset in webkit [217568] by
-
- 6 edits in trunk/Source/WebCore
convertEnumerationToJS() should not stash ASCIILiteral strings in NeverDestroyed arrays.
https://bugs.webkit.org/show_bug.cgi?id=172724
<rdar://problem/31193201>
Reviewed by Chris Dumez.
Use MAKE_STATIC_STRING_IMPL instead, which is guaranteed to be thread-safe and
satisfies the promise of immortality promised by NeverDestroyed (while ASCIILiteral
does not always satisfy this promise).
Also converted the ASSERT in convertEnumerationToJS() to a RELEASE_ASSERT as a
debugging aid to check if it is ever passed an invalid enumerationValue.
No new tests because this is a speculative fix for an issue observed in the wild
whose root cause is not known yet. This patch also adds a release assert to
gather more info about the nature of the issue.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateEnumerationImplementationContent):
- bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
(WebCore::convertEnumerationToJS):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::convertEnumerationToJS):
- bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
(WebCore::convertEnumerationToJS):
- bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
(WebCore::convertEnumerationToJS):
- re-baselined these test results.
- 1:02 PM Changeset in webkit [217567] by
-
- 3 edits2 adds in trunk
REGRESSION(r216882): No image decoding is needed if the BitmapImage is created with a NativeImage
https://bugs.webkit.org/show_bug.cgi?id=172670
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-05-30
Reviewed by Tim Horton.
Source/WebCore:
Test: fast/images/large-image-webkit-canvas.html
Check whether the BitmapImage has created an ImageDecoder before trying
to decode its image frame.
- platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::shouldUseAsyncDecoding):
LayoutTests:
Use the css property -webkit-canvas to force capturing the canvas context
in a NativeImage. This NativeImage will be used to create a BitmapImage
which will be later used as the background-image of an element.
- fast/images/large-image-webkit-canvas-expected.html: Added.
- fast/images/large-image-webkit-canvas.html: Added.
- 12:57 PM Changeset in webkit [217566] by
-
- 7 edits in trunk/Source/WebKit2
Dictionary lookup disappears after a few seconds on observer.com
https://bugs.webkit.org/show_bug.cgi?id=172725
<rdar://problem/32328324>
Reviewed by Beth Dakin.
Only dismiss content-relative child windows on main frame loads,
not all subframes. This was causing e.g. dictionary popovers
relative to main-frame content to be dismissed when subframe
ads finished loading, which is likely the cause of most incidents
of this problem.
If the popover is relative to subframe content and the subframe
navigates out from under the popover, the popover will persist until
dismissed by the user (or one of the other automatic dismissal
mechanisms), but that seems preferable to the old behavior.
- UIProcess/Cocoa/WebViewImpl.h:
Remove an unimplemented and unused declaration.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::processDidExit):
Move dismissContentRelativeChildWindows call here from WebPageProxy.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::resetStateAfterProcessExited):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::navigationGestureDidBegin):
(WebKit::PageClientImpl::dismissContentRelativeChildWindows):
Remove dismissContentRelativeChildWindows from PageClient(Impl),
call it from inside PageClientImpl and other Mac-specific places
instead of inside ifdefs in WebPageProxy.
- 12:51 PM Changeset in webkit [217565] by
-
- 2 edits in trunk/LayoutTests
Changed Text Expectations of imported/blink/storage/indexeddb/blob-valid-after-deletion.html
https://bugs.webkit.org/show_bug.cgi?id=172403
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 11:34 AM Changeset in webkit [217564] by
-
- 2 edits in trunk/Source/WebKit2
Don't use designated initializers in WebBackForwardListProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=172667
Reviewed by Alex Christensen.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::addItemFromUIProcess):
(WebKit::WebBackForwardListProxy::addItem):
- 11:29 AM Changeset in webkit [217563] by
-
- 3 edits in trunk/Tools
[WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
https://bugs.webkit.org/show_bug.cgi?id=172702
Patch by Fujii Hironori <Fujii Hironori> on 2017-05-30
Reviewed by Alex Christensen.
EGL PlatformDisplay needs to be shut down before existing a
program on Windows.
- TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
(TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
- TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
(TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
- 11:29 AM Changeset in webkit [217562] by
-
- 15 edits2 adds in trunk
RealtimeOutgoingVideoSource should not rotate muted frames
https://bugs.webkit.org/show_bug.cgi?id=172659
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-30
Reviewed by Eric Carlson.
Source/WebCore:
Test: webrtc/video-rotation.html
When sending black frames, it is unnecessary to rotate frames.
Instead, it is better to create frame with the expected width and height.
Making sure libwebrtc rotated images are not null, as only YUV rotation is supported.
Adding internals API to test part of that code path.
Full coverage should be added when mock source is producing YUV images.
- Modules/mediastream/PeerConnectionBackend.h:
(WebCore::PeerConnectionBackend::applyRotationForOutgoingVideoSources):
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::applyRotationForOutgoingVideoSources):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
- platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:
(WebCore::RealtimeOutgoingVideoSource::sendBlackFrames):
(WebCore::RealtimeOutgoingVideoSource::sendFrame):
- platform/mediastream/mac/RealtimeOutgoingVideoSource.h:
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::applyRotationForOutgoingVideoSources):
(WebCore::Internals::setCameraMediaStreamTrackOrientation):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- webrtc/routines.js:
- webrtc/video-rotation-expected.txt: Added.
- webrtc/video-rotation.html: Added.
- 10:47 AM Changeset in webkit [217561] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed typo correction.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logFrameNavigation): I used an extra colon in my comment.
- 10:39 AM Changeset in webkit [217560] by
-
- 3 edits in trunk/LayoutTests
Mark js/intl-datetimeformat.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=172720
Unreviewed test gardening.
- js/script-tests/intl-datetimeformat.js:
- platform/mac/TestExpectations:
- 10:09 AM Changeset in webkit [217559] by
-
- 3 edits in trunk/Websites/perf.webkit.org
sync-builedbot.js fails to schedule the second request to test with a patch
https://bugs.webkit.org/show_bug.cgi?id=172701
Reviewed by Antti Koivisto.
The bug was caused by an assertion failure in BuildbotTriggerable's _pullBuildbotOnAllSyncers failing to
take into account that for a test group with a patch could be associated with two syncers, one to build
a patch and another to run tests. Fixed the bug by differentiating the two types of syncers by buildSyncer
and testSyncer per test group.
- server-tests/tools-sync-buildbot-integration-tests.js: Extended a test case so that it would hit the
assertion without the fix.
- tools/js/buildbot-triggerable.js:
(BuildbotTriggerable.prototype.syncOnce): Use the right kind of the syncer to schedule a build or a test.
(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers): Associate a given syncer based on the kind of
the build request it processed, and assert accordingly.
- 9:57 AM Changeset in webkit [217558] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r217515): Correct iterator invalidation bug (AGAIN)
https://bugs.webkit.org/show_bug.cgi?id=172722
<rdar://problem/32462876>
Reviewed by Zalan Bujtas.
Over-enthusiastic clean-up during r217515 re-introduced a bug caused by holding a reference
to an iterator that gets invalidated while handling the frame navigation. This patch returns
to the copy/set behavior used prior to r217515.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logFrameNavigation): Make a copy of the returned value, since
the iterator will be invalidated during the function call. Then set the copy back in the data
store with the updated counts.
- 8:41 AM Changeset in webkit [217557] by
-
- 8 edits in trunk
[Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=172709
Reviewed by Brent Fulgham.
Source/WebKit/win:
Add method to exit fullscreen mode.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp:
(WebView::exitFullscreenIfNeeded):
- WebView.h:
Tools:
Exit fullscreen mode after a fullscreen test.
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
LayoutTests:
- platform/win/TestExpectations:
- 8:33 AM Changeset in webkit [217556] by
-
- 2 edits in trunk/Tools
ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
https://bugs.webkit.org/show_bug.cgi?id=172713
Reviewed by Zalan Bujtas.
- DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
Remove forced display from plugin resource load delegate. It is testing some long-obsolete
Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
because on Mac WK1 it may get invoked from middle of a layout.
Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
- 7:43 AM Changeset in webkit [217555] by
-
- 7 edits in trunk/Tools
Add a WPE EWS queue
https://bugs.webkit.org/show_bug.cgi?id=172693
Reviewed by Carlos Garcia Campos.
- QueueStatusServer/config/queues.py:
- QueueStatusServer/model/queues.py: Capitalize the name of the
port on the tooltip of the bubbles. Do the same for the GTK port.
(Queue.display_name):
- Scripts/webkitpy/common/config/ews.json: Update the watcher mail
for the GTK+ EWS also. Set for both ports as watcher the alias
bugs-noreply@webkitgtk.org that maintainers of both ports follow.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(WpePort):
(WpePort.build_webkit_command):
(WpePort.run_webkit_tests_command):
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest):
(DeprecatedPortTest.test_wpe_port):
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(test_ews_name):
- 7:33 AM Changeset in webkit [217554] by
-
- 2 edits in trunk/LayoutTests
[GTK] Test cases for typehead in form menu lists should start from known state
https://bugs.webkit.org/show_bug.cgi?id=171792
Reviewed by Carlos Garcia Campos.
Since r215188 opening a popup menu in a form pre-selects the active
element to mimic GtkComboxBox behavior, but the layout test implicitly
assumed that type ahead search always started the beginning of the
list, which is no longer true now that GTK+ is informed of which one
is the active element.
- platform/gtk/fast/forms/menulist-typeahead-find.html: Reset menu
list to the initial state (no element selected, unfocused) at the
beginning of testTypeAheadFunction().
- 7:31 AM Changeset in webkit [217553] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] TestWebKitAPI: SHOULD NEVER BE REACHED in WebCore::cairoSurfaceSize
https://bugs.webkit.org/show_bug.cgi?id=172699
Patch by Fujii Hironori <Fujii Hironori> on 2017-05-30
Reviewed by Brent Fulgham.
Tests: WebCore.BitmapImageEmptyFrameTest in TestWebKitAPI
- platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::cairoSurfaceSize): Added a case for win32 surface type.
- 7:02 AM Changeset in webkit [217552] by
-
- 15 edits in trunk/Source/WebKit2
REGRESSION(r191402?): Safari, Mail crash at com.apple.WebKit: WebKit::WebContextMenuListenerProxy::invalidate + 4
https://bugs.webkit.org/show_bug.cgi?id=172704
Reviewed by Andreas Kling.
r191402 made WebContextMenuProxy non-refcounted. However there are several potential ways for WebContextMenuProxyMac::show()
to re-enter WebPageProxy and delete itself. This patch partially reverts r191402 bringing refcounting back and protects
WebContextMenuProxy during show().
Speculative fix. No test, can't repro the crash.
- UIProcess/PageClient.h:
- UIProcess/WebContextMenuProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu):
Protect WebContextMenuProxy during show().
- UIProcess/WebPageProxy.h:
- UIProcess/gtk/WebContextMenuProxyGtk.h:
(WebKit::WebContextMenuProxyGtk::create):
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createContextMenuProxy):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createContextMenuProxy):
- UIProcess/mac/WebContextMenuProxyMac.h:
(WebKit::WebContextMenuProxyMac::create):
- 6:02 AM Changeset in webkit [217551] by
-
- 5 edits in trunk/Source/WebCore
[GTK][WPE][GSTREAMER_GL] Do not use cairo to copy video textures to an accelerated canvas
https://bugs.webkit.org/show_bug.cgi?id=172542
Reviewed by Žan Doberšek.
When drawing gstreamer-gl video frames into an accelerated canvas, we are currently using cairo to copy
the video textures into a new texture that will be painted into de destination canvas. While this eases
the code, it doesn't allow us to control the copy process. This is a problem because in order to use
gstreamer-gl properly, we will need to perform colorspace transformations during the copy. So, remove
this cairo copy and use VideoTextureCopierGStreamer instead.
The usage of VideoTextureCopierGStreamer is pretty much the same than in the webgl case, except that
no destination texture is provided. For that case, add a custom texture to hold the result that can
be requested after the copy.
Covered by existent tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
(WebCore::MediaPlayerPrivateGStreamerBase::prepareContextForCairoPaint): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToCairoSurface): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(WebCore::MediaPlayerPrivateGStreamerBase::gstGLDisplay):
- platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:
(WebCore::VideoTextureCopierGStreamer::VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::~VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):
- platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:
(WebCore::VideoTextureCopierGStreamer::resultTexture):
- 4:03 AM Changeset in webkit [217550] by
-
- 2 edits in trunk/Source/WebKit2
Invalidate the LayerTreeHost when destroying the DrawingAreaWPE object.
Rubber-stamped by Carlos Garcia Campos.
- WebProcess/WebPage/wpe/DrawingAreaWPE.cpp:
(WebKit::DrawingAreaWPE::~DrawingAreaWPE): Invalidate the LayerTreeHost
object, properly deconstructing the graphics pipeline.
- 1:35 AM Changeset in webkit [217549] by
-
- 4 edits in trunk
Crash on display-contents-replaced-001.html
https://bugs.webkit.org/show_bug.cgi?id=172596
Reviewed by Andreas Kling.
Source/WebCore:
This is crashing because some code can't handle display:contents on form controls. Turns
out the draft specification tell us to disable it for them in any case.
See https://drafts.csswg.org/css-display-3/#unbox
- css/StyleResolver.cpp:
(WebCore::hasEffectiveDisplayNoneForDisplayContents):
For certain HTML elements (replaced elements, form controls) display:contents should
behave like display:none.
Also disable it for SVG and MathML elements.
(WebCore::StyleResolver::adjustRenderStyle):
Also compute to display:none when there is no associated element (pseudos etc).
LayoutTests:
- TestExpectations: Enable the test.
- 1:27 AM Changeset in webkit [217548] by
-
- 4 edits in trunk
[GCrypt] RSA-OAEP support
https://bugs.webkit.org/show_bug.cgi?id=171222
Reviewed by Michael Catanzaro.
Source/WebCore:
Add RSA-OAEP support for configurations that use libgcrypt.
The encryption operation embeds the plain-text data into a data s-expression,
specifying OAEP as the padding method of choice and also adding information
about the hash algorithm and any label data. This is then passed to the
gcry_pk_encrypt() call together with the provided key, returning the enc-val
s-expression containing the resulting cipher text. That's retrieved from the
relevant MPI and returned to the caller.
The decryption operation embeds the cipher-text data into an enc-val
s-expression, again specifying the hash algorithm and also filling in any
label data. This is then passed, along with the key, to the gcry_pk_decrypt()
call. The returned data s-expression contains the decrypted plain-text data
inside the 'value' MPI, from which this data is extracted and returned to the
caller.
No new tests -- the revelant tests are passing and are unskipped, apart from
the ones using PKSC#8 and SPKI formats.
- crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
(WebCore::hashAlgorithmName):
(WebCore::mpiData):
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
LayoutTests:
- platform/gtk/TestExpectations: Enable the RSA-OAEP layout tests that we pass.
- 1:06 AM Changeset in webkit [217547] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed follow-up to r217546. Address some review comments that I forgot about.
- crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
(WebCore::gcryptEncrypt): Use quotations when referencing s-expression names in
comments to avoid confusion.
(WebCore::gcryptDecrypt): Ditto.
- 12:45 AM Changeset in webkit [217546] by
-
- 4 edits in trunk
[GCrypt] RSAES-PKCS1-v1_5 support
https://bugs.webkit.org/show_bug.cgi?id=171219
Reviewed by Michael Catanzaro.
Source/WebCore:
Add RSAES-PKCS1-v1_5 support for configurations that use libgcrypt.
The encryption operation embeds the plain-text data into a data s-expression,
specifying PKCS#1 as the padding method of choice. That's passed to the
gcry_pk_encrypt() call together with the specified key. The returned enc-val
expression contains the 'a' MPI from which the data is extracted and returned.
The decryption operation goes in reverse -- the cipher-text data is embedded
into an enc-val s-expression that again also specifies PKCS#1 as the padding
method. The s-expression is passed to gcry_pk_decrypt() together with the
specified key. The returned data s-expression contains the decrypted text
inside the 'value' parameter, so the data is extracted from that and returned
to the caller.
No new tests -- the revelant tests are passing and are unskipped, apart from
the ones using PKCS#8 and SPKI formats.
- crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
(WebCore::mpiData):
(WebCore::gcryptEncrypt):
(WebCore::gcryptDecrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):
LayoutTests:
- platform/gtk/TestExpectations: Enable the RSAES-PKCS1-v1_5 layout tests that we pass.
- 12:27 AM Changeset in webkit [217545] by
-
- 4 edits in trunk
[GCrypt] RSASSA-PKCS1-v1_5 support
https://bugs.webkit.org/show_bug.cgi?id=171220
Reviewed by Michael Catanzaro.
Source/WebCore:
Add RSASSA-PKSC1-V_15 support for configurations that use libgcrypt.
The signing operation first digests data with the specified hash algorithm.
That's then embedded in the data s-expression. That's then passed to the
gcry_pk_sign() call together with the specified key, returning a sig-val
s-expression containing the signature. The signature data is then retrieved
from the relevant MPI and returned to the caller.
The verification operation first digests data with the specified hash
algorithm. That's then embedded in the data s-expression. A sig-val
s-expression is constructed, embedding the signature data. The data and
sig-val s-expressions are passed to the gcry_sexp_verify() call which returns
the resulting error code. The verification succeeds if the returned value is
GPG_ERR_NO_ERROR, fails if it's GPG_ERR_BAD_SIGNATURE, or errors out with an
OperationError otherwise.
No new tests -- the revelant tests are passing and are unskipped, apart from
the ones using PKCS#8 and SPKI formats.
- crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
(WebCore::hashCryptoDigestAlgorithm):
(WebCore::hashAlgorithmName):
(WebCore::mpiData):
(WebCore::gcryptSign):
(WebCore::gcryptVerify):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):
LayoutTests:
- platform/gtk/TestExpectations: Enable the RSASSA-PKCS1-v1_5 layout tests that we pass.
- 12:25 AM Changeset in webkit [217544] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Add DOM breakpoint image for GTK+
https://bugs.webkit.org/show_bug.cgi?id=169326
Patch by Fujii Hironori <Fujii Hironori> on 2017-05-30
Reviewed by Carlos Garcia Campos.
- UserInterface/Images/gtk/DOMBreakpoint.svg: Added.
May 29, 2017:
- 10:42 PM Changeset in webkit [217543] by
-
- 7 edits in tags/Safari-604.1.23.0.2/Source
Versioning.
- 10:37 PM Changeset in webkit [217542] by
-
- 1 copy in tags/Safari-604.1.23.0.2
New tag.
- 10:03 PM Changeset in webkit [217541] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Fix UI glitches with a custom analysis test group with a patch
https://bugs.webkit.org/show_bug.cgi?id=172694
Reviewed by Sam Weinig.
Fix the following UI glitches with perf try bots:
- Retrying an A/B testing with a patch fails.
- A patch specified in an test group does not get specified in the configurator.
- Drag & dropping a patch doesn't work.
- Results for custom analysis tasks don't get shown.
- public/api/test-groups.php:
(main): Fix a bug that test group's platform does not match that of the request'ed platform. Since each test
group is associated with platform, just use that instead of querying test_configurations. This resulted in
the configurator not being able to find a triggerable in some cases.
- public/v3/components/custom-analysis-task-configurator.js:
(CustomAnalysisTaskConfigurator):
(CustomAnalysisTaskConfigurator.prototype.setCommitSets): Add patches in the commit set.
(CustomAnalysisTaskConfigurator.prototype._setUploadedFilesToUploader): Now clears the exiting uploaded files
Also renamed from _setUploadedFilesIfEmpty.
(CustomAnalysisTaskConfigurator.prototype._setPatchFiles): Added.
(CustomAnalysisTaskConfigurator.prototype.didConstructShadowTree): We no longer update the list of roots
for the comparsion when a new root is added to the baseline.
(CustomAnalysisTaskConfigurator.prototype._configureComparison): Copy over the list of patches and roots when
starting to configure the comparsion.
- public/v3/components/instant-file-uploader.js:
(InstantFileUploader.prototype.clear): Added.
(InstantFileUploader.prototype.didConstructShadowTree): Added event handlers for dragover & drop events to
allow specifying a patch and root using drag & drop. Unfortunately, this still doesn't work in WebKit due to
a bug in our shadow DOM implementation.
(InstantFileUploader.prototype._didFileInputChange):
(InstantFileUploader.prototype._uploadFiles): Extracted from _didFileInputChange.
- public/v3/pages/analysis-task-page.js:
(AnalysisTaskTestGroupPane.prototype.setAnalysisResults): No longer takes metric.
(AnalysisTaskTestGroupPane.cssTemplate): Removed unused rules. Also disallow flexing on the list of test groups
to avoid the name of a test froup from overflowing on top of the results pane.
(AnalysisTaskPage.prototype._assignTestResultsIfPossible): Set setAnalysisResults even when metric is not set
as is the case for a custom analysis task.
(AnalysisTaskPage.prototype._retryCurrentTestGroup): Use createWithCustomConfiguration to allow retrying of
an A/B testing with a patch in a custom analysis task.
(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingCommitSetList):
- 11:20 AM Changeset in webkit [217540] by
-
- 2 edits in trunk/LayoutTests
[WPE] Mark a couple of tests as slow/timing out
Unreviewed gardening. These are all known ones.
- platform/wpe/TestExpectations:
- 10:35 AM Changeset in webkit [217539] by
-
- 2 edits in trunk/LayoutTests
[WPE] Marking workers/bomb.html test as slow.
Unreviewed gardening.
- platform/wpe/TestExpectations:
- 9:17 AM Changeset in webkit [217538] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Remove unneeded forward declaration
Rubber-stamped by Zan Dobersek.
- UIProcess/API/C/gtk/WKAPICastGtk.h: Remove WebGrammarDetail as
its header is included in the same file.
- 9:05 AM Changeset in webkit [217537] by
-
- 2 edits in trunk/Tools
Unreviewed. Bumping the WPEBackend-mesa dependency version.
- wpe/jhbuild.modules: Use the latest version that uses proper GLib
priorities for IPC communication.
- 7:09 AM Changeset in webkit [217536] by
-
- 4 edits in trunk
Use the parent box style to adjust RenderStyle for alignment.
https://bugs.webkit.org/show_bug.cgi?id=172215
Patch by Emilio Cobos Álvarez <ecobos@igalia.com> on 2017-05-29
Reviewed by Antti Koivisto.
Source/WebCore:
The css-flexbox spec defined align-self in terms of the parent
element, which is what this code did.
The css-align spec defines these properties in terms of the style of
the containing box instead, which means display: contents styles
should not be used for this adjustment, but the parent box style
instead.
For example, align-items is defined as:
This property specifies the default align-self for all of the boxes
(including anonymous boxes) participating in this box’s formatting
context.
Note that the css-align spec was recently updated to align (no pun
intended) with Gecko, and make the |auto| value compute to itself.
This patch puts us in a more recent spec than before, but not totally
up-to-date.
Tests: imported/w3c/web-platform-tests/css/css-display-3/display-contents-alignment-001.html
imported/w3c/web-platform-tests/css/css-display-3/display-contents-alignment-002.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustStyleForAlignment):
LayoutTests:
- 3:37 AM Changeset in webkit [217535] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, disable faster Interpreter::getOpcodeID for ARM_THUMB2 with non-Darwin OSes
https://bugs.webkit.org/show_bug.cgi?id=172686
Because of test failures.
- wtf/Platform.h:
- 2:03 AM Changeset in webkit [217534] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Windows test gardening, update expected results after r217418.
- platform/win/fast/block/float/032-expected.txt:
- 1:41 AM Changeset in webkit [217533] by
-
- 2 edits in trunk/Source/WebKit2
[WPE] Build fix after r217531
Unreviewed.
- UIProcess/API/C/wpe/WKAPICastWPE.h:
(WebKit::toAPI): Add missing WebGrammarDetail API cast.
- 12:15 AM Changeset in webkit [217532] by
-
- 7 edits in trunk/LayoutTests
Unreviewed Windows test gardening, update expected results after r217418.
- platform/win/fast/forms/input-appearance-spinbutton-expected.txt:
- platform/win/fast/forms/input-appearance-spinbutton-up-expected.txt:
- platform/win/fast/forms/number/number-appearance-rtl-expected.txt:
- platform/win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
- platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
- platform/win/fast/forms/search-vertical-alignment-expected.txt:
May 28, 2017:
- 10:30 PM Changeset in webkit [217531] by
-
- 39 edits in trunk/Source
[Xcode] ALWAYS_SEARCH_USER_PATHS is set to YES
https://bugs.webkit.org/show_bug.cgi?id=172691
Reviewed by Tim Horton.
- Configurations/Base.xcconfig: Set ALWAYS_SEARCH_USER_PATHS to NO.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj: Added ParseInt.h to the JavaScriptCore target.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Added DateTimeChooser.h, DateTimeChooserClient.h, PerformanceMark.h, PerformanceMeasure.h, SVGUnknownElement.h, and MathMLUnknownElement.h to the WebCore target.
Source/WebKit2:
- UIProcess/API/C/WKAPICast.h: Moved GTK-only definitions that used WebGrammarDetail.h to WKAPICastGtk.h. This had the effect of no longer including APIArray.h from this header.
- UIProcess/API/C/gtk/WKAPICastGtk.h: Moved GTK-only definitions to here.
(WebKit::toAPI):
- UIProcess/WebGrammarDetail.h: Replaced include of APIArray.h with a forward declaration.
- Shared/API/c/WKRenderLayer.cpp:
- Shared/API/c/WKRenderObject.cpp:
- UIProcess/API/C/WKApplicationCacheManager.cpp:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKContextConfigurationRef.cpp:
- UIProcess/API/C/WKCookieManager.cpp:
- UIProcess/API/C/WKKeyValueStorageManager.cpp:
- UIProcess/API/C/WKNotificationManager.cpp:
- UIProcess/API/C/WKOpenPanelResultListener.cpp:
- UIProcess/API/C/WKPageGroup.cpp:
- UIProcess/API/C/WKResourceCacheManager.cpp:
- UIProcess/API/C/WKUserContentControllerRef.cpp:
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
- UIProcess/WebContextMenuListenerProxy.cpp:
Added #include "APIArray.h" to these files now that WKAPICast.h does not include it.
- 10:09 PM Changeset in webkit [217530] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Provide better type information of toLength and tighten bytecode
https://bugs.webkit.org/show_bug.cgi?id=172690
Reviewed by Sam Weinig.
In this patch, we carefully leverage operator + in order to
- tighten bytecode
operator+ emits to_number bytecode. What this bytecode does is the same
to @Number() call. It is more efficient, and it is smaller bytecode
than @Number() call (load global variable @Number, set up arguments, and
call it).
- offer better type prediction data
Now, we have code like
length > 0 ? (length < @MAX_SAFE_INTEGER ? length : @MAX_SAFE_INTEGER) : 0
This is not good because DFG prediction propagation phase predicts as Double
since @MAX_SAFE_INTEGER is double. But actually it rarely becomes Double.
Usually, the result becomes Int32. This patch leverages to_number in a bit
interesting way: to_number has value profiling to offer better type prediction.
This value profiling can offer a chance to change the prediction to Int32 efficiently.
It is a bit tricky. But it is worth doing to speed up our builtin functions,
which should leverage all the JSC's tricky things to be optimized.
Related microbenchmarks show performance improvement.
baseline patched
array-prototype-forEach 50.2348+-2.2331 49.7568+-2.3507
array-prototype-map 51.0574+-1.8166 47.9531+-2.1653 might be 1.0647x faster
array-prototype-some 52.3926+-1.8882 48.3632+-2.0852 definitely 1.0833x faster
array-prototype-every 52.7394+-2.0712 50.2896+-2.1480 might be 1.0487x faster
array-prototype-reduce 54.9994+-2.3638 51.8716+-2.6253 might be 1.0603x faster
array-prototype-reduceRight 209.7594+-9.2594 51.5867+-2.5745 definitely 4.0662x faster
- builtins/GlobalOperations.js:
(globalPrivate.toInteger):
(globalPrivate.toLength):
- 6:30 PM Changeset in webkit [217529] by
-
- 7 edits2 adds in trunk
[WebIDL] @@iterator should only be accessed once when disambiguating a union type
https://bugs.webkit.org/show_bug.cgi?id=172684
Patch by Sam Weinig <sam@webkit.org> on 2017-05-28
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- runtime/IteratorOperations.cpp:
(JSC::iteratorMethod):
(JSC::iteratorForIterable):
- runtime/IteratorOperations.h:
(JSC::forEachInIterable):
Add additional iterator helpers to allow union + sequence conversion code
to check for iterability by getting the iterator method, and iterate using
that method later on.
Source/WebCore:
WebIDL specifies that when determining if the value you are converting to a union
is a sequence, you must get the @@iterator property and, should it exist, use it
to iterate the sequence. While we correctly accessing the property to make the
determination, we were not passing it into the sequence conversion code, and thus
the sequence conversion code re-accessed it, which is observable and wrong.
This patch pipes the @@iterator method through the sequence conversion code to avoid
this.
Test: js/dom/sequence-in-union-iterator-access.html
- bindings/js/JSDOMConvertSequences.h:
(WebCore::Detail::GenericSequenceConverter::convert):
(WebCore::Detail::NumericSequenceConverter::convertArray):
(WebCore::Detail::NumericSequenceConverter::convert):
(WebCore::Detail::SequenceConverter::convertArray):
(WebCore::Detail::SequenceConverter::convert):
(WebCore::Detail::SequenceConverter<IDLLong>::convert):
(WebCore::Detail::SequenceConverter<IDLFloat>::convert):
(WebCore::Detail::SequenceConverter<IDLUnrestrictedFloat>::convert):
(WebCore::Detail::SequenceConverter<IDLDouble>::convert):
(WebCore::Detail::SequenceConverter<IDLUnrestrictedDouble>::convert):
(WebCore::Converter<IDLSequence<T>>::convert):
(WebCore::Converter<IDLFrozenArray<T>>::convert):
Add variants of convert that take a JSObject* (sequence) / JSValue (iterator method)
rather than just the JSValue (sequence). To avoid too much duplication, split some
parts of SequenceConverter and NumericSequenceConverter up so they could be reused.
- bindings/js/JSDOMConvertUnion.h:
- Fix incorrect step 3 (WebIDL got updated at some point and we didn't notice) to remove records.
- Update sequence and FrozenArray checking/conversion to get the iterator method and pass it along, using the new ConditionalSequenceConverter helper which forwards to the new sequence converters that accept the iterator method.
LayoutTests:
- js/dom/sequence-in-union-iterator-access-expected.txt: Added.
- js/dom/sequence-in-union-iterator-access.html: Added.
Add test case showing that @@iterator is only accessed once when converting a sequence
as part of a union.
- 7:11 AM Changeset in webkit [217528] by
-
- 2 edits in trunk/Source/WTF
[JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID()
https://bugs.webkit.org/show_bug.cgi?id=172686
Reviewed by Mark Lam.
As of r217526, JSC gets faster Interpreter::getOpcodeID() by
embedding OpcodeID value just before the LLInt machine code
handler pointer. By doing so, we can retrieve OpcodeID from
the LLInt machine code handler by dereferencing the code
pointer.*((int*)ptr - 1).
This patch allows Linux and FreeBSD environments to use this
optimization.
- wtf/Platform.h:
- 4:33 AM Changeset in webkit [217527] by
-
- 5 edits in trunk/Source/JavaScriptCore
Unreviewed, build fix for Windows
https://bugs.webkit.org/show_bug.cgi?id=172413
Optimized jsDynamicCast for JSMap and JSSet will be handled in [1].
[1]: https://bugs.webkit.org/show_bug.cgi?id=172685
- runtime/JSMap.h:
(JSC::isJSMap):
(JSC::jsDynamicCast): Deleted.
(JSC::>): Deleted.
- runtime/JSSet.h:
(JSC::isJSSet):
(JSC::jsDynamicCast): Deleted.
(JSC::>): Deleted.
- runtime/MapConstructor.cpp:
(JSC::constructMap):
- runtime/SetConstructor.cpp:
(JSC::constructSet):
- 1:12 AM Changeset in webkit [217526] by
-
- 9 edits in trunk/Source
Implement a faster Interpreter::getOpcodeID().
https://bugs.webkit.org/show_bug.cgi?id=172669
Reviewed by Saam Barati.
Source/JavaScriptCore:
We can implement Interpreter::getOpcodeID() without a hash table lookup by always
embedding the OpcodeID in the 32-bit word just before the start of the LLInt
handler code that executes each opcode. getOpcodeID() can therefore just read
the 32-bits before the opcode address to get its OpcodeID.
This is currently only enabled for CPU(X86), CPU(X86_64), CPU(ARM64),
CPU(ARM_THUMB2), and only for OS(DARWIN). It'll probably just work for linux as
well, but I'll let the Linux folks turn that on after they have verified that it
works on linux too.
I'll also take this opportunity to clean up how we initialize the opcodeIDTable:
- we only need to initialize it once per process, not once per VM / interpreter instance.
- we can initialize it in the Interpreter constructor instead of requiring a separate call to an initialize() function.
On debug builds, the Interpreter constructor will also verify that getOpcodeID()
is working correctly for each opcode when USE(LLINT_EMBEDDED_OPCODE_ID).
- bytecode/BytecodeList.json:
- generate-bytecode-files:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::opcodeIDTable):
(JSC::Interpreter::initialize): Deleted.
- interpreter/Interpreter.h:
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
- llint/LowLevelInterpreter.cpp:
- runtime/VM.cpp:
(JSC::VM::VM):
Source/WTF:
Added the USE(LLINT_EMBEDDED_OPCODE_ID) configuration.
- wtf/Platform.h:
May 27, 2017:
- 4:21 PM Changeset in webkit [217525] by
-
- 18 edits1 move10 adds1 delete in trunk
[JSC] Map and Set constructors should have fast path for cloning
https://bugs.webkit.org/show_bug.cgi?id=172413
Reviewed by Saam Barati.
JSTests:
- stress/map-clone-instance-iterator-change.js: Added.
(shouldBe):
(map.Symbol.iterator):
- stress/map-clone-iterator-change.js: Added.
(shouldBe):
(Map.prototype.Symbol.iterator):
- stress/map-clone-next-change.js: Added.
(shouldBe):
(map.Symbol.iterator.proto.next):
- stress/map-clone.js: Added.
(shouldBe):
(Map.prototype):
- stress/map-inherit-set.js: Added.
(shouldBe):
(DerivedMap):
(set for):
- stress/set-clone-instance-iterator-change.js: Added.
(shouldBe):
(set Symbol.iterator):
- stress/set-clone-iterator-change.js: Added.
(shouldBe):
(set Set.prototype.Symbol.iterator):
- stress/set-clone-next-change.js: Added.
(shouldBe):
(set Symbol.iterator.proto.next):
- stress/set-clone.js: Added.
(shouldBe):
(set Set.prototype.add):
- stress/set-inherit-add.js: Added.
(shouldBe):
(DerivedSet.set add):
Source/JavaScriptCore:
In this patch, we add a fast path for cloning in Set and Map constructors.
In ARES-6 Air, we have code like
new Set(set)to clone the given set.
At that time, our generic path just iterates the given set object and add
it to the newly created one. It is quite slow because we need to follow
the iterator protocol inside C++ and we need to call set.add() repeatedly
while the given set guarantees the elements are unique.
This patch implements clone() function to JSMap and JSSet. Cloning JSMap
and JSSet are done really fast without invoking any observable JS functions.
To check whether we can use this clone() function in Set and Map constructors,
we set several watchpoints.
In the case of Set,
- Set.prototype[Symbol.iterator] is not changed.
- SetIterator.prototype.next is not changed.
- Set.prototype.add is not changed.
- The given Set does not have [Symbol.iterator] function in its instance.
- The given Set's Prototype? is Set.prototype.
- Newly created set's Prototype? is Set.prototype.
If the above requirements are met, cloning the given Set is not observable to users.
Thus we can take a fast path.
Currently, we do not integrate this optimization into DFG and FTL.
And we do not optimize other iterables. For example, we can optimize Set
constructor taking Int32 Array. And we should optimize generic iterator cases too.
They are planned as part of a separate bug[1].
This change improves ARES-6 Air by 5.3% in steady state.
Baseline:
Running... Air ( 1 to go)
firstIteration: 76.41 +- 15.60 ms
averageWorstCase: 40.63 +- 7.54 ms
steadyState: 9.13 +- 0.51 ms
Patched:
Running... Air ( 1 to go)
firstIteration: 75.00 +- 22.54 ms
averageWorstCase: 39.18 +- 8.45 ms
steadyState: 8.67 +- 0.28 ms
[1]: https://bugs.webkit.org/show_bug.cgi?id=172419
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/ArrayIteratorAdaptiveWatchpoint.cpp: Removed.
- runtime/HashMapImpl.h:
(JSC::HashMapBucket::extractValue):
(JSC::HashMapImpl::finishCreation):
(JSC::HashMapImpl::add):
(JSC::HashMapImpl::setUpHeadAndTail):
(JSC::HashMapImpl::addNormalizedNonExistingForCloning):
(JSC::HashMapImpl::addNormalizedInternal):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::createSubclassStructureSlow):
(JSC::InternalFunction::createSubclassStructure): Deleted.
- runtime/InternalFunction.h:
(JSC::InternalFunction::createSubclassStructure):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::mapIteratorProtocolWatchpoint):
(JSC::JSGlobalObject::setIteratorProtocolWatchpoint):
(JSC::JSGlobalObject::mapSetWatchpoint):
(JSC::JSGlobalObject::setAddWatchpoint):
(JSC::JSGlobalObject::mapPrototype):
(JSC::JSGlobalObject::jsSetPrototype):
(JSC::JSGlobalObject::setStructure):
- runtime/JSGlobalObjectInlines.h:
(JSC::JSGlobalObject::isMapPrototypeIteratorProtocolFastAndNonObservable):
(JSC::JSGlobalObject::isSetPrototypeIteratorProtocolFastAndNonObservable):
(JSC::JSGlobalObject::isMapPrototypeSetFastAndNonObservable):
(JSC::JSGlobalObject::isSetPrototypeAddFastAndNonObservable):
- runtime/JSMap.cpp:
(JSC::JSMap::clone):
(JSC::JSMap::canCloneFastAndNonObservable):
- runtime/JSMap.h:
(JSC::jsDynamicCast):
(JSC::>):
(JSC::JSMap::createStructure): Deleted.
(JSC::JSMap::create): Deleted.
(JSC::JSMap::set): Deleted.
(JSC::JSMap::JSMap): Deleted.
- runtime/JSSet.cpp:
(JSC::JSSet::clone):
(JSC::JSSet::canCloneFastAndNonObservable):
- runtime/JSSet.h:
(JSC::jsDynamicCast):
(JSC::>):
(JSC::JSSet::createStructure): Deleted.
(JSC::JSSet::create): Deleted.
(JSC::JSSet::JSSet): Deleted.
- runtime/MapConstructor.cpp:
(JSC::constructMap):
- runtime/ObjectPropertyChangeAdaptiveWatchpoint.h: Renamed from Source/JavaScriptCore/runtime/ArrayIteratorAdaptiveWatchpoint.h.
(JSC::ObjectPropertyChangeAdaptiveWatchpoint::ObjectPropertyChangeAdaptiveWatchpoint):
- runtime/SetConstructor.cpp:
(JSC::constructSet):
Tools:
- TestWebKitAPI/Tests/WTF/MathExtras.cpp:
(TestWebKitAPI::TEST):
- 1:15 PM Changeset in webkit [217524] by
-
- 11 edits2 adds in trunk
imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form_attribute.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=172472
<rdar://problem/32334831>
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/form-control-infrastructure/form_attribute-expected.txt:
Rebaseline test now that more checks are passing. We were previously wrongly resetting the input form owner
to null when removing the form from the document and the input had a form attribute set and was a descendant
of the form.
Source/WebCore:
Fix assertion hit when running imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form_attribute.html.
When the form was removed from the document, A descendant would try to find a new form owner in the document. If the descendant had
a form content attribute and there was another form in the document with this ID, then we would erroneously associate the descendant with
that other form, even though that descendant is being disconnected. This is because when the form with the given id is removed, we
notify the IdTargetObservers of the change. In this case, the form control is an IdTargetObserver and gets notified after
removedFrom() has been called on the form but *before* removedFrom() has been called on its descendant form control. As a result, the
form control still thinks it is in the tree (i.e. isConnected() wrongly returns true) and we make the wrong decision and try to
associate it with another form in the document.
To address the problem, we leverage the fact that when a form element is being removed, it already notifies its associated form
controls that it is being removed. When it does, we make sure to clear the control's id observer if the form is its ancestor.
The ID observer is no longer needed beyond this point since the control is now disconnected from the document, and the ID observer
callback would erroneously associate it with another form element in the document of the same ID because isConnected() still returns
true at that point.
As a result, the control's form owner is kept unchanged, which is the right thing to do here, since it is its ancestor, even
though both are detached.
Test: fast/dom/HTMLFormElement/form-removal-duplicate-id-crash.html
- dom/ContainerNode.h:
(WebCore::Node::rootNode):
Inline rootNode to avoid an extra function call in the fast path case. For the slow path, we now
call traverseToRootNode() to avoid duolicating logic.
- dom/Node.cpp:
(WebCore::Node::traverseToRootNode):
Add a traverseToRootNode() method which gets the root node by traversing the ancestors. This logic was duplicated in 3 places:
- Slow path in Node::rootNode()
- computeRootNode() in FormAssociatedElement.cpp
- findRoot() in HTMLFormElement.cpp
They are now consolidated in a single place to avoid duplication.
- dom/Node.h:
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::removedFrom):
Just simplify the logic a bit:
- Clear the id observer (i.e. m_formAttributeTargetObserver) no matter what. Since the element is no longer part of the document, it is no longer needed. We would previously have checks that would basically avoid resetting m_formAttributeTargetObserver to null if it is already null. Settign m_formAttributeTargetObserver to null is cheap so there is no reason for those checks. Those checks were also confusing because they made it look like we would sometimes keep on id observer after being removed from the document.
- Use new traverseToRootNode() utility function (no behavior change)
- Drop unnecessary |element| local variable
(WebCore::FormAssociatedElement::formOwnerRemovedFromTree):
- Rename to formOwnerRemovedFromTree() to make it clear that it is the element's form owner that is removed, and not just any form.
- As we traverse the tree up to find the root, also check if we find the form owner. If we do, clear the id observer since we are effectively detached from the document and return early since there is no need to reset our form owner in this case.
- html/FormAssociatedElement.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::removedFrom):
- Use new traverseToRootNode() utility function (no behavior change)
LayoutTests:
Unskip test that is no longer crashing in Debug builds.
- fast/dom/HTMLFormElement/form-removal-duplicate-id-crash-expected.txt: Added.
- fast/dom/HTMLFormElement/form-removal-duplicate-id-crash.html: Added.
Add reduced test case reproducing the crash.
- 12:03 PM Changeset in webkit [217523] by
-
- 26 edits13 moves1 delete in trunk/Source
[DOMJIT] Move DOMJIT patchpoint infrastructure out of domjit
https://bugs.webkit.org/show_bug.cgi?id=172260
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
DOMJIT::Patchpoint is now used for generalized CheckSubClass. And it becomes mature enough
to be used as a general-purpose injectable compiler over all the JIT tiers.
We extract DOMJIT::Patchpoint to jit/ and rename it JSC::Snippet.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/AccessCaseSnippetParams.cpp: Renamed from Source/JavaScriptCore/bytecode/DOMJITAccessCasePatchpointParams.cpp.
(JSC::SlowPathCallGeneratorWithArguments::generateImpl):
(JSC::AccessCaseSnippetParams::emitSlowPathCalls):
- bytecode/AccessCaseSnippetParams.h: Renamed from Source/JavaScriptCore/bytecode/DOMJITAccessCasePatchpointParams.h.
(JSC::AccessCaseSnippetParams::AccessCaseSnippetParams):
- bytecode/GetterSetterAccessCase.cpp:
(JSC::GetterSetterAccessCase::emitDOMJITGetter):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::blessCallDOMGetter):
(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
- dfg/DFGNode.h:
- dfg/DFGSnippetParams.cpp: Renamed from Source/JavaScriptCore/dfg/DFGDOMJITPatchpointParams.cpp.
- dfg/DFGSnippetParams.h: Renamed from Source/JavaScriptCore/dfg/DFGDOMJITPatchpointParams.h.
(JSC::DFG::SnippetParams::SnippetParams):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::allocateTemporaryRegistersForSnippet):
(JSC::DFG::SpeculativeJIT::compileCallDOMGetter):
(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::allocateTemporaryRegistersForPatchpoint): Deleted.
- domjit/DOMJITCallDOMGetterSnippet.h: Renamed from Source/JavaScriptCore/domjit/DOMJITCallDOMGetterPatchpoint.h.
(JSC::DOMJIT::CallDOMGetterSnippet::create):
- domjit/DOMJITGetterSetter.h:
- domjit/DOMJITSignature.h:
- domjit/DOMJITValue.h: Removed.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
- ftl/FTLSnippetParams.cpp: Renamed from Source/JavaScriptCore/ftl/FTLDOMJITPatchpointParams.cpp.
- ftl/FTLSnippetParams.h: Renamed from Source/JavaScriptCore/ftl/FTLDOMJITPatchpointParams.h.
(JSC::FTL::SnippetParams::SnippetParams):
- jit/Snippet.h: Renamed from Source/JavaScriptCore/domjit/DOMJITPatchpoint.h.
(JSC::Snippet::create):
(JSC::Snippet::setGenerator):
(JSC::Snippet::generator):
- jit/SnippetParams.h: Renamed from Source/JavaScriptCore/domjit/DOMJITPatchpointParams.h.
(JSC::SnippetParams::~SnippetParams):
(JSC::SnippetParams::Value::Value):
(JSC::SnippetParams::Value::isGPR):
(JSC::SnippetParams::Value::isFPR):
(JSC::SnippetParams::Value::isJSValueRegs):
(JSC::SnippetParams::Value::gpr):
(JSC::SnippetParams::Value::fpr):
(JSC::SnippetParams::Value::jsValueRegs):
(JSC::SnippetParams::Value::reg):
(JSC::SnippetParams::Value::value):
(JSC::SnippetParams::SnippetParams):
- jit/SnippetReg.h: Renamed from Source/JavaScriptCore/domjit/DOMJITReg.h.
(JSC::SnippetReg::SnippetReg):
- jit/SnippetSlowPathCalls.h: Renamed from Source/JavaScriptCore/domjit/DOMJITSlowPathCalls.h.
- jsc.cpp:
(WTF::DOMJITNode::checkSubClassSnippet):
(WTF::DOMJITFunctionObject::checkSubClassSnippet):
(WTF::DOMJITNode::checkSubClassPatchpoint): Deleted.
(WTF::DOMJITFunctionObject::checkSubClassPatchpoint): Deleted.
- runtime/ClassInfo.h:
Source/WebCore:
- ForwardingHeaders/jit/Snippet.h: Renamed from Source/WebCore/ForwardingHeaders/domjit/DOMJITPatchpoint.h.
- ForwardingHeaders/jit/SnippetParams.h: Renamed from Source/WebCore/ForwardingHeaders/domjit/DOMJITPatchpointParams.h.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestDOMJIT.h:
- domjit/DOMJITCheckDOM.h:
(WebCore::DOMJIT::checkDOM):
- domjit/DOMJITHelpers.h:
(WebCore::DOMJIT::toWrapper):
- domjit/JSDocumentDOMJIT.cpp:
(WebCore::checkSubClassSnippetForJSDocument):
(WebCore::DocumentDocumentElementDOMJIT::callDOMGetter):
(WebCore::DocumentBodyDOMJIT::callDOMGetter):
(WebCore::checkSubClassPatchpointForJSDocument): Deleted.
- domjit/JSDocumentFragmentDOMJIT.cpp:
(WebCore::checkSubClassSnippetForJSDocumentFragment):
(WebCore::checkSubClassPatchpointForJSDocumentFragment): Deleted.
- domjit/JSElementDOMJIT.cpp:
(WebCore::checkSubClassSnippetForJSElement):
(WebCore::checkSubClassPatchpointForJSElement): Deleted.
- domjit/JSEventDOMJIT.cpp:
(WebCore::checkSubClassSnippetForJSEvent):
(WebCore::checkSubClassPatchpointForJSEvent): Deleted.
- domjit/JSNodeDOMJIT.cpp:
(WebCore::checkSubClassSnippetForJSNode):
(WebCore::createCallDOMGetterForOffsetAccess):
(WebCore::NodeFirstChildDOMJIT::callDOMGetter):
(WebCore::NodeLastChildDOMJIT::callDOMGetter):
(WebCore::NodeNextSiblingDOMJIT::callDOMGetter):
(WebCore::NodePreviousSiblingDOMJIT::callDOMGetter):
(WebCore::NodeParentNodeDOMJIT::callDOMGetter):
(WebCore::NodeNodeTypeDOMJIT::callDOMGetter):
(WebCore::NodeOwnerDocumentDOMJIT::callDOMGetter):
(WebCore::checkSubClassPatchpointForJSNode): Deleted.
- 10:13 AM Changeset in webkit [217522] by
-
- 22 edits1 copy4 adds in trunk
getComputedStyle returns percentage values for left / right / top / bottom
https://bugs.webkit.org/show_bug.cgi?id=29084
Reviewed by Zalan Bujtas.
LayoutTests/imported/w3c:
New baselines (still failing).
- web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/centering-expected.txt:
Source/WebCore:
Fix getComputedStyle() to return pixel values for left / right / top / bottom, per spec.
This is mostly a merge of https://codereview.chromium.org/13871003/.
Behavior now matches Chrome and Firefox.
Test: fast/css/getComputedStyle/getComputedStyle-offsets.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::getOffsetComputedLength):
(WebCore::getOffsetUsedStyleRelative):
(WebCore::getOffsetUsedStyleAbsolute):
(WebCore::positionOffsetValue):
(WebCore::positionOffsetValueIsRendererDependent):
(WebCore::isNonReplacedInline):
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):
LayoutTests:
Some new baselines, a new test, and an improved test.
- animations/trigger-container-scroll-boundaries-expected.txt:
- animations/trigger-container-scroll-boundaries.html:
- animations/trigger-container-scroll-empty-expected.txt:
- animations/trigger-container-scroll-empty.html:
- animations/trigger-container-scroll-simple-expected.txt:
- animations/trigger-container-scroll-simple.html:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-negative-top-expected.txt:
- fast/css/getComputedStyle/computed-style-negative-top.html: Convert to a real JS test, add more cases.
- fast/css/getComputedStyle/getComputedStyle-offsets-expected.txt: Added.
- fast/css/getComputedStyle/getComputedStyle-offsets.html: Added.
- fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-zoom-and-background-size.html: It doesn't make any sense to test right/bottom.
- fast/css/hover-affects-child-expected.txt:
- fast/css/hover-affects-child.html:
- platform/mac-elcapitan/fast/css/getComputedStyle/computed-style-expected.txt:
- transitions/transition-to-from-auto-expected.txt:
- transitions/transition-to-from-auto.html:
- 9:23 AM Changeset in webkit [217521] by
-
- 4 edits in trunk
enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
https://bugs.webkit.org/show_bug.cgi?id=172676
Reviewed by Simon Fraser.
Source/WebCore:
Clamp integer values soon after the enclosing rectangle is resolved.
- platform/graphics/FloatRect.cpp:
(WebCore::enclosingIntRect):
Tools:
- TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
(TestWebKitAPI::TEST):
May 26, 2017:
- 10:25 PM Changeset in webkit [217520] by
-
- 11 edits in trunk/Source
Simply some NSNumber usage
https://bugs.webkit.org/show_bug.cgi?id=172677
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-26
Reviewed by Sam Weinig.
Source/WebCore:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _addAccessibilityObject:toTextMarkerArray:]):
(AXAttributeStringSetFont):
(AXAttributeStringSetStyle):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetStyle):
(AXAttributeStringSetSpelling):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
- platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::levelIndicatorFor):
Source/WebKit2:
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::platformGeometryDidChange):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::registerUserDefaultsIfNeeded):
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
- 8:27 PM Changeset in webkit [217519] by
-
- 7 edits in trunk
WebRTC stats should be in milliseconds
https://bugs.webkit.org/show_bug.cgi?id=172644
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-26
Reviewed by Eric Carlson.
Source/WebCore:
Covered by updated tests.
- Modules/mediastream/RTCStatsReport.h:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCStats):
LayoutTests:
- TestExpectations:
- webrtc/video-stats.html: Making it less flaky prone.
- 7:54 PM Changeset in webkit [217518] by
-
- 25 edits2 adds in trunk
[WebIDL] Overloaded functions should throw this object check exception before argument check exception
https://bugs.webkit.org/show_bug.cgi?id=172480
Reviewed by Chris Dumez.
Source/WebCore:
- Codifies naming for both parts of the operation/attribute function implementation:
- The 'trampoline' which is the actual host function and simply calls IDLOperation, IDLOperationReturningPromise or IDLAttribute.
- The 'body' which is where argument checking and calling into the implementation takes place.
- Made it so all operations, including static ones, use the trampoline / body model, simplifying code generation. The one exception is for overloaded operations, which now have a trampoline and body for the dispatcher, and only bodies for all the overloads. This is what fixes the bug, since now that the dispatcher has a trampoline, it can do the correct this object checking via IDLOperation / IDLOperationReturningPromise.
- Split out code generation for trampoline and body into separate subroutines and simplified their implementations.
- Changed GenerateOverloadDispatcher to only generate the body of the function, leaving it up to the caller to generate the signature, braces and conditionals if needed.
- Made more subroutines take an output array and indent, in support of future endeavors that will need that support.
- Remove unnecessary #includes of <runtime/Error.h>, which gets included already by virtue of JSDOMExceptionHandling.h
Test: js/dom/overloaded-operation-exception-order.html
- bindings/js/JSDOMOperation.h:
- bindings/js/JSDOMOperationReturningPromise.h:
Add no-op static versions of the bouncer functions.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateOverloadDispatcher):
(GenerateOperationTrampolineDefinition):
(GenerateOperationBodyDefinition):
(GenerateOperationDefinition):
(GenerateSerializerDefinition):
(GenerateLegacyCallerDefinitions):
(GenerateLegacyCallerDefinition):
(GenerateArgumentsCountCheck):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(GenerateImplementationCustomFunctionCall):
(GenerateConstructorDefinitions):
(GenerateConstructorDefinition):
- bindings/scripts/test/JS/JSInterfaceName.cpp:
- bindings/scripts/test/JS/JSMapLike.cpp:
- bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestCEReactions.cpp:
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestDOMJIT.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
- bindings/scripts/test/JS/JSTestIterable.cpp:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
- bindings/scripts/test/JS/JSTestSerialization.cpp:
- bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
Update test results.
LayoutTests:
Add test case that shows that using the wrong this object on an overloaded function,
even if you are passing the wrong number of arguments, results in an invalid this
object exception.
- js/dom/overloaded-operation-exception-order-expected.txt: Added.
- js/dom/overloaded-operation-exception-order.html: Added.
- 7:33 PM Changeset in webkit [217517] by
-
- 2 edits in trunk/Source/JavaScriptCore
REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject().
https://bugs.webkit.org/show_bug.cgi?id=172654
Reviewed by Mark Lam.
The test's intent is to assert that an exception has not been
thrown (as indicated by the message string), but the test was
erroneously checking for ! the right condition. This is now fixed.
- API/tests/JSExportTests.mm:
(wrapperForNSObjectisObject):
- 6:32 PM Changeset in webkit [217516] by
-
- 2 edits in trunk/Tools
TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
https://bugs.webkit.org/show_bug.cgi?id=172674
Reviewed by Simon Fraser.
- TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
(TestWebKitAPI::TEST):
- 5:38 PM Changeset in webkit [217515] by
-
- 14 edits in trunk/Source
[WK2] Address thread safety issues with ResourceLoadStatistics
https://bugs.webkit.org/show_bug.cgi?id=172519
<rdar://problem/31707642>
Reviewed by Chris Dumez.
Source/WebCore:
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::setStatisticsQueue): Added.
(WebCore::ResourceLoadObserver::clearInMemoryStore): Only interact with the HashTable on the statistics queue.
(WebCore::ResourceLoadObserver::clearInMemoryAndPersistentStore): Ditto.
(WebCore::ResourceLoadObserver::logFrameNavigation): Ditto.
(WebCore::ResourceLoadObserver::logSubresourceLoading): Ditto.
(WebCore::ResourceLoadObserver::logWebSocketLoading): Ditto.
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution): Ditto.
(WebCore::ResourceLoadObserver::logUserInteraction): Ditto.
(WebCore::ResourceLoadObserver::clearUserInteraction): Protect HashTable while reading.
(WebCore::ResourceLoadObserver::hasHadUserInteraction): Ditto.
(WebCore::ResourceLoadObserver::setPrevalentResource): Ditto.
(WebCore::ResourceLoadObserver::isPrevalentResource): Ditto.
(WebCore::ResourceLoadObserver::clearPrevalentResource): Ditto.
(WebCore::ResourceLoadObserver::setGrandfathered): Ditto.
(WebCore::ResourceLoadObserver::isGrandfathered): Ditto.
(WebCore::ResourceLoadObserver::setSubframeUnderTopFrameOrigin): Only interact with the HashTable on the statistics queue.
(WebCore::ResourceLoadObserver::setSubresourceUnderTopFrameOrigin): Ditto.
(WebCore::ResourceLoadObserver::setSubresourceUniqueRedirectTo): Ditto.
(WebCore::ResourceLoadObserver::fireDataModificationHandler): ASSERT this is only called from the main thread, since this is
only meant to be used as part of the testing harness.
(WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler): Ditto.
(WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler): Ditto.
- loader/ResourceLoadObserver.h:
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::isPrevalentResource): Protect HashTable while using it.
(WebCore::ResourceLoadStatisticsStore::ensureResourceStatisticsForPrimaryDomain): Ditto.
(WebCore::ResourceLoadStatisticsStore::setResourceStatisticsForPrimaryDomain): Ditto.
(WebCore::ResourceLoadStatisticsStore::createEncoderFromData): ASSERT this isn't being done on the main thread, and
protect HashTable while using it.
(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder): Ditto.
(WebCore::ResourceLoadStatisticsStore::clearInMemory): Ditto.
(WebCore::ResourceLoadStatisticsStore::clearInMemoryAndPersistent): Ditto.
(WebCore::ResourceLoadStatisticsStore::statisticsForOrigin): Protect HashTable while using it.
(WebCore::ResourceLoadStatisticsStore::takeStatistics): Ditto.
(WebCore::ResourceLoadStatisticsStore::mergeStatistics): Ditto.
(WebCore::ResourceLoadStatisticsStore::setNotificationCallback): Use WTF::Function.
(WebCore::ResourceLoadStatisticsStore::setShouldPartitionCookiesCallback): Ditto.
(WebCore::ResourceLoadStatisticsStore::setWritePersistentStoreCallback): Ditto.
(WebCore::ResourceLoadStatisticsStore::setGrandfatherExistingWebsiteDataCallback): Ditto.
(WebCore::ResourceLoadStatisticsStore::fireDataModificationHandler): ASSERT this is not called on the main thread,
but dispatch the registered handler on the main thread.
(WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler): Ditto.
(WebCore::ResourceLoadStatisticsStore::processStatistics): ASSERT this isn't being done on the main thread, and
protect the HashTable while using it. Also switch to WTF::Function.
(WebCore::ResourceLoadStatisticsStore::hasHadRecentUserInteraction): Make const correct.
(WebCore::ResourceLoadStatisticsStore::topPrivatelyControlledDomainsToRemoveWebsiteDataFor): Protect HashTable while using it.
(WebCore::ResourceLoadStatisticsStore::updateStatisticsForRemovedDataRecords): Ditto.
(WebCore::ResourceLoadStatisticsStore::handleFreshStartWithEmptyOrNoStore): Ditto.
(WebCore::ResourceLoadStatisticsStore::shouldRemoveDataRecords): Make const correct. ASSERT this is not being called
on the main thread.
(WebCore::ResourceLoadStatisticsStore::dataRecordsBeingRemoved): ASSERT this is not being called on the main thread.
(WebCore::ResourceLoadStatisticsStore::dataRecordsWereRemoved): Ditto.
(WebCore::ResourceLoadStatisticsStore::statisticsLock): Added.
- loader/ResourceLoadStatisticsStore.h:
Source/WebKit/mac:
Create a new WorkQueue for the ResourceLoadStatistics store to use for processing data.
- WebView/WebView.mm:
(WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Pass WorkQueue to the observer.
Source/WebKit2:
Address some thread safety issues with the ResourceLoadStatistics architecture.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords): Assert that this is never called on the main thread. Also
ensure that coreStore is only accessed on the statistics queue, not the main thread.
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords): Dispatch coreStore-accessing code
on the statistics queue.
(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated): Assert we do not hit this method
on the main thread.
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Assert that this is being called on the
main thread. Also ensure that coreStore is only accessed on the statistics queue, not the main thread.
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData): Dispatch coreStore-accessing code
on the statistics queue.
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded): Lock data before operating on it.
(WebKit::WebResourceLoadStatisticsStore::writeStoreToDisk): Assert we do not hit this method on the main thread.
(WebKit::WebResourceLoadStatisticsStore::writeEncoderToDisk): Ditto.
- UIProcess/WebResourceLoadStatisticsStore.h:
- WebProcess/WebProcess.cpp: Add a queue for the local WebProcess ResourceLoadStatisticsStore to use while processing data.
(WebKit::m_statisticsQueue): Added.
- WebProcess/WebProcess.h:
Source/WTF:
Add a new specialization for HashSet.
- wtf/CrossThreadCopier.h:
- 5:22 PM Changeset in webkit [217514] by
-
- 2 edits in trunk/LayoutTests
Skip fast/events/before-unload-returnValue.html on iOS.
https://bugs.webkit.org/show_bug.cgi?id=172672
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 5:22 PM Changeset in webkit [217513] by
-
- 2 edits in trunk/LayoutTests
Mark workers/wasm-long-compile-many.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=172331
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 5:05 PM Changeset in webkit [217512] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Merge r217217.
- 4:00 PM Changeset in webkit [217511] by
-
- 3 edits in trunk/Source/WebKit2
[Cocoa] Simplify some WebViewImpl pasteboard code
https://bugs.webkit.org/show_bug.cgi?id=172668
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-26
Reviewed by Tim Horton.
- Shared/mac/PasteboardTypes.mm:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setFileAndURLTypes):
(WebKit::WebViewImpl::setPromisedDataForAttachment):
- 3:57 PM Changeset in webkit [217510] by
-
- 1 copy in tags/Safari-604.1.21.10
Tag Safari-604.1.21.10.
- 3:56 PM Changeset in webkit [217509] by
-
- 17 edits in trunk/Source
JSContext Inspector: Improve the reliability of automatically pausing in auto-attach
https://bugs.webkit.org/show_bug.cgi?id=172664
<rdar://problem/32362933>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-26
Reviewed by Matt Baker.
Source/JavaScriptCore:
Automatically pause on connection was triggering a pause before the
frontend may have initialized. Often during frontend initialization
the frontend may perform an action that clears the pause state requested
by the developer. This change defers the pause until after the frontend
has initialized, right before returning to the application's code.
- inspector/remote/RemoteControllableTarget.h:
- inspector/remote/RemoteInspectionTarget.h:
- inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:
(Inspector::RemoteConnectionToTarget::setup):
- inspector/remote/glib/RemoteConnectionToTargetGlib.cpp:
(Inspector::RemoteConnectionToTarget::setup):
- runtime/JSGlobalObjectDebuggable.cpp:
(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::pause): Deleted.
- runtime/JSGlobalObjectDebuggable.h:
Pass an immediatelyPause boolean on to the controller. Remove
the current path that invokes a pause before initialization.
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
Manage should immediately pause state.
(Inspector::JSGlobalObjectInspectorController::frontendInitialized):
(Inspector::JSGlobalObjectInspectorController::pause): Deleted.
When initialized, trigger a pause if requested.
Source/WebCore:
- inspector/InspectorController.h:
- page/PageDebuggable.cpp:
(WebCore::PageDebuggable::connect):
- page/PageDebuggable.h:
Pass an immediatelyPause boolean on to the controller.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::disconnectAllFrontends):
Manage should immediately pause state.
(WebCore::InspectorController::frontendInitialized):
When initialized, trigger a pause if requested.
Source/WebKit2:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::connect):
- UIProcess/Automation/WebAutomationSession.h:
Special connection options are ignored in automation sessions.
- 2:41 PM Changeset in webkit [217508] by
-
- 3 edits1 add in trunk/Source/WebCore
[CMake] Consolidate CMake code related to FreeType
https://bugs.webkit.org/show_bug.cgi?id=172656
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-26
Reviewed by Michael Catanzaro.
No new tests. No change in behavior.
- PlatformGTK.cmake:
- PlatformWPE.cmake:
- platform/FreeType.cmake: Added.
- 2:33 PM Changeset in webkit [217507] by
-
- 34 edits in trunk/Source/WebCore
[WebIDL] Another bindings cleanup pass, this time focusing on attributes
https://bugs.webkit.org/show_bug.cgi?id=172619
Patch by Sam Weinig <sam@webkit.org> on 2017-05-26
Reviewed by Chris Dumez.
- Moved attribute getter / setter generation into their own subroutines.
- As was done for operations, moved trampoline functions for attributes below their implementation functions to avoid unseemly forward declaration.
- Changed to place the getter and setter for an attribute next to each other, rather than having all the getters and then all the setters.
- Moved JSFoo::getConstructor and JSFoo::getNamedConstructor up to be with other member functions.
- Fix an issue where we were generating a setJSFooConstructor function and not installing it anywhere. Now we always generate either both the getter and setter or neither for the constructor property. Also moved their definition to just above all the attributes, rather than the odd placements of between the getters and setters which is where they had been.
- Made InstanceNeedsVisitChildren a complete answer, rather than relying on some loop of the attributes to update needsVisitChildren bit.
- Move use of passing conditionals when adding headers.
- bindings/scripts/CodeGeneratorJS.pm:
(InstanceNeedsVisitChildren):
(GenerateHeader):
(GenerateImplementation):
(GenerateAttributeGetterDefinition):
(GenerateAttributeSetterDefinition):
(NeedsConstructorProperty):
- bindings/scripts/test/JS/JSInterfaceName.cpp:
- bindings/scripts/test/JS/JSMapLike.cpp:
- bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
- bindings/scripts/test/JS/JSTestCEReactions.cpp:
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
- bindings/scripts/test/JS/JSTestDOMJIT.cpp:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestException.cpp:
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
- bindings/scripts/test/JS/JSTestIterable.cpp:
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestObj.h:
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
- bindings/scripts/test/JS/JSTestSerialization.cpp:
- bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
Update test results.
- 2:28 PM Changeset in webkit [217506] by
-
- 4 edits in trunk
[CMake] Wrap CODE_GENERATOR_PREPROCESSOR_EXECUTABLE on Windows hosts
https://bugs.webkit.org/show_bug.cgi?id=172553
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-26
Reviewed by Brent Fulgham.
.:
- Source/cmake/OptionsCommon.cmake:
Source/WebCore:
No new tests. No change in behavior.
- bindings/scripts/preprocessor.pm:
(applyPreprocessor): Use shellwords() instead of splitting
preprocessor command by space. Combine it back in open3() call on
Windows to work around Cygwin-specific issue.
- 2:14 PM Changeset in webkit [217505] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Reloading the page after switching from the Resource tab switches back
https://bugs.webkit.org/show_bug.cgi?id=172622
Reviewed by Joseph Pecoraro.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeSelectionDidChange):
- UserInterface/Views/SearchSidebarPanel.js:
(WebInspector.SearchSidebarPanel.prototype._treeSelectionDidChange):
Don't show the newly selected tree element's represented object if the sidebar is not visible.
- 1:59 PM Changeset in webkit [217504] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
Provide bug information when https://webkit.org/b/# URLs are added in comments
https://bugs.webkit.org/show_bug.cgi?id=169707
Reviewed by David Kilzer.
- Bugzilla/Template.pm:
(quoteUrls):
- 1:47 PM Changeset in webkit [217503] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: New Tab contents have extra vertical spacing when wrapped
https://bugs.webkit.org/show_bug.cgi?id=172530
Reviewed by Joseph Pecoraro.
- UserInterface/Views/NewTabContentView.css:
(.new-tab.tab.content-view):
- 1:40 PM Changeset in webkit [217502] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Unreviewed, land TestExpectations for rdar://problem/30555012.
- platform/ios-simulator/TestExpectations:
- 1:22 PM Changeset in webkit [217501] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the build using the latest SDK
Add deprecation guards around newly introduced (and deprecated) SPI.
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard setItemsUsingRegistrationInfoLists:]):
- 12:45 PM Changeset in webkit [217500] by
-
- 2 edits in trunk/Source/JavaScriptCore
Temporarily commenting out a JSExportTest test until webkit.org/b/172654 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=172655
Reviewed by Saam Barati.
- API/tests/JSExportTests.mm:
(wrapperForNSObjectisObject):
- 12:27 PM Changeset in webkit [217499] by
-
- 10 edits3 adds in trunk
Unreviewed, rolling out r217458.
This change caused 55 JSC test failures.
Reverted changeset:
"Date should use historical data if it's available."
https://bugs.webkit.org/show_bug.cgi?id=172592
http://trac.webkit.org/changeset/217458
- 11:45 AM Changeset in webkit [217498] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(216914): testCFStrings encounters an invalid ExecState callee pointer.
https://bugs.webkit.org/show_bug.cgi?id=172651
Reviewed by Saam Barati.
This is because the assertion utility functions used in testCFStrings() expects
to get the JSGlobalContextRef from the global context variable. However,
testCFStrings() creates its own JSGlobalContextRef but does not set the global
context variable to it.
The fix is to make testCFStrings() initialize the global context variable properly.
- API/tests/testapi.c:
(testCFStrings):
- 11:20 AM Changeset in webkit [217497] by
-
- 2 edits in trunk/Tools
Add test resources back into TestWebKitAPI Copy Resources phase
Rubber-stamped by Beth Dakin.
Add two files back into the Copy Resources phase after they were unintentionally
removed in r217447 and r217496.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 10:18 AM Changeset in webkit [217496] by
-
- 5 edits1 add in trunk
Media documents inside iframes should not get controls in the TouchBar unless the
video is playing
https://bugs.webkit.org/show_bug.cgi?id=172620
-and corresponding-
rdar://problem/32165477
Reviewed by Jon Lee.
Source/WebCore:
Media documents get to return early with true, but that should only apply to
mainframe media documents.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::canShowControlsManager):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
- 10:12 AM Changeset in webkit [217495] by
-
- 7 edits1 add in trunk
Give ModuleProgram the same treatment that we did for ProgramCode in bug#167725
https://bugs.webkit.org/show_bug.cgi?id=167805
Reviewed by Saam Barati.
JSTests:
- modules/module-jit-reachability.js: Added.
Source/JavaScriptCore:
Since ModuleProgramExecutable is executed only once, we can skip compiling
code unreachable from the current program count. This can skip massive
initialization code.
We already do this for global code in bug#167725. This patch extends it to
module code.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeModuleProgram):
- interpreter/Interpreter.h:
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::evaluate):
- runtime/JSModuleRecord.h:
(JSC::JSModuleRecord::moduleProgramExecutable): Deleted.
- 10:08 AM Changeset in webkit [217494] by
-
- 4 edits in trunk/Source/WebCore
Minor clean-up related to DocumentThreadableLoader redirections
https://bugs.webkit.org/show_bug.cgi?id=172647
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-26
Reviewed by Chris Dumez.
No change of behavior.
Decrementing m_options redirect count directly instead of using an
additional counter.
To compare whether two URLs are same-origin, use scheme+host+port check
as per the spec.
This is fine as only the initial origin may have specific rules and we
are using the scheme+host+port checks when already being gone to
another origin.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::redirectReceived):
- loader/DocumentThreadableLoader.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):
- 10:03 AM Changeset in webkit [217493] by
-
- 5 edits in branches/safari-604.1.21-branch/Source/WebKit2
Cherry-pick r217475. rdar://problem/32414363
- 10:03 AM Changeset in webkit [217492] by
-
- 61 edits1 add in branches/safari-604.1.21-branch
Cherry-pick r217296. rdar://problem/32414363
- 9:13 AM Changeset in webkit [217491] by
-
- 4 edits in trunk/LayoutTests
Rebaseline js/dom/global-constructors-attributes.html.
Unreviewed test gardening.
- platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 9:03 AM Changeset in webkit [217490] by
-
- 3 edits in trunk/LayoutTests
Skip two LayoutTests that are failing due missing results.
Unreviewed test gardening.
- TestExpectations:
- platform/ios/TestExpectations:
- 7:36 AM Changeset in webkit [217489] by
-
- 2 edits in trunk/Source/WebCore
Fix memory leaks in MediaSampleAVFObjC::create
https://bugs.webkit.org/show_bug.cgi?id=172600
Patch by Youenn Fablet <youenn@apple.com> on 2017-05-26
Reviewed by Eric Carlson.
No change of behavior.
- platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:
(WebCore::MediaSampleAVFObjC::createImageSample):
- 6:28 AM Changeset in webkit [217488] by
-
- 8 edits2 copies2 adds in trunk/Source/WebKit2
Unreviewed, rolling out r217479.
https://bugs.webkit.org/show_bug.cgi?id=172642
Exposes an underlying bug in WPEBackend-mesa that we have to
resolve separately (Requested by zdobersek on #webkit).
Reverted changeset:
"[WPE] Use AcceleratedDrawingArea instead of its fork"
https://bugs.webkit.org/show_bug.cgi?id=172496
http://trac.webkit.org/changeset/217479
- 5:02 AM Changeset in webkit [217487] by
-
- 2 edits in trunk/LayoutTests
[WPE] Mark animations/animation-delay-changed.htm as flaky
Unreviewed gardening. It's flaky on all platforms so why bother.
- platform/wpe/TestExpectations:
- 3:18 AM Changeset in webkit [217486] by
-
- 7 edits34 adds in trunk
[css-grid] Add support for orthogonal positioned grid items
https://bugs.webkit.org/show_bug.cgi?id=172591
Reviewed by Sergio Villar Senin.
LayoutTests/imported/w3c:
Imported new tests for this feature from WPT repository.
- resources/import-expectations.json:
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-001-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-001.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-002-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-002.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-003-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-003.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-004-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-004.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-005-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-005.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-006-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-006.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-007-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-007.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-008-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-008.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-009-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-009.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-010-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-010.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-011-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-011.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-012-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-012.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-013-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-013.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-014-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-014.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-015-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-015.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-016-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-016.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-017-expected.html: Added.
- web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-017.html: Added.
- web-platform-tests/css/css-grid-1/abspos/w3c-import.log:
Source/WebCore:
This patch adds support for positioned grid items with orthogonal flows.
Basically it just needs to check if the item is orthogonal to use
the column or row offset as logical left or top depending on the case.
Tests: imported/w3c/web-platform-tests/css/css-grid-1/abspos/orthogonal-positioned-grid-items-*.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutPositionedObject):
LayoutTests:
Two of the new imported tests are failing due to an issue with margins
and orthogonal items, which is unrelated to this patch (see bug #172590).
- 3:16 AM Changeset in webkit [217485] by
-
- 2 edits in trunk
[CMake] Pass -fdiagnostics-color=always to GCC when building with Ninja
https://bugs.webkit.org/show_bug.cgi?id=172638
Reviewed by Yusuke Suzuki.
The oldest version of GCC supported for building WebKit is 4.9, which already accepts
-fdiagnostics-color=, therefore it is not needed to check the compiler version.
- Source/cmake/OptionsCommon.cmake:
- 2:50 AM Changeset in webkit [217484] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed Mac cmake buildfix after r217137, just for fun.
https://bugs.webkit.org/show_bug.cgi?id=172362
- PlatformMac.cmake:
- 2:33 AM Changeset in webkit [217483] by
-
- 7 edits11 adds in releases/WebKitGTK/webkit-2.16
Merge r214378 - Handle recursive calls to ProcessingInstruction::checkStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=169982
<rdar://problem/31083051>
Reviewed by Antti Koivisto.
Source/WebCore:
See if we triggered a recursive load of the stylesheet during the 'beforeload'
event handler. If so, reset to a valid state before completing the load.
We should also check after 'beforeload' that we were not disconnected from (or
moved to a new) document.
I also looked for other cases of this pattern and fixed them, too.
Tests: fast/dom/beforeload/image-removed-during-before-load.html
fast/dom/beforeload/recursive-css-pi-before-load.html
fast/dom/beforeload/recursive-link-before-load.html
fast/dom/beforeload/recursive-xsl-pi-before-load.html
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::clearExistingCachedSheet): Added.
(WebCore::ProcessingInstruction::checkStyleSheet): Prevent recursive calls into
this function during 'beforeload' handling. Also, safely handle the case where
the element was disconnected in the 'beforeload' handler (similar to what
we do in HTMLLinkElement).
(WebCore::ProcessingInstruction::setCSSStyleSheet): Drive-by Fix: Protect the
current document to match what we do in setXSLStyleSheet.
- dom/ProcessingInstruction.h:
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::process): Prevent recursive calls into
this function during 'beforeload' handling.
- html/HTMLLinkElement.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent): safely handle the case where
the element was disconnected in the 'beforeload' handler (similar to what
we do in HTMLLinkElement).
- style/StyleScope.cpp:
(WebCore::Style::Scope::hasPendingSheet): Added.
- style/StyleScope.h:
LayoutTests:
- fast/dom/beforeload/image-removed-during-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/image-removed-during-before-load-expected.txt.
- fast/dom/beforeload/image-removed-during-before-load.html: Copied from LayoutTests/fast/dom/beforeload/image-removed-during-before-load.html.
- fast/dom/beforeload/recursive-css-pi-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-css-pi-before-load-expected.txt.
- fast/dom/beforeload/recursive-css-pi-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-css-pi-before-load.html.
- fast/dom/beforeload/recursive-link-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-link-before-load-expected.txt.
- fast/dom/beforeload/recursive-link-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-link-before-load.html.
- fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt: Copied from LayoutTests/fast/dom/beforeload/recursive-xsl-pi-before-load-expected.txt.
- fast/dom/beforeload/recursive-xsl-pi-before-load.html: Copied from LayoutTests/fast/dom/beforeload/recursive-xsl-pi-before-load.html.
- fast/dom/beforeload/resources/content.xhtml: Copied from LayoutTests/fast/dom/beforeload/resources/content.xhtml.
- fast/dom/beforeload/resources/pass.css: Copied from LayoutTests/fast/dom/beforeload/resources/pass.css.
- fast/dom/beforeload/resources/test.xsl: Copied from LayoutTests/fast/dom/beforeload/resources/test.xsl.
- 1:17 AM Changeset in webkit [217482] by
-
- 2 edits4 adds in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Add new GTK+ icons for Web Sockets
https://bugs.webkit.org/show_bug.cgi?id=172296
Patch by Fujii Hironori <Fujii Hironori> on 2017-05-26
Reviewed by Carlos Garcia Campos.
Add more free icons for the Web Inspector of GTK+ port.
- UserInterface/Images/gtk/WebSocket.png: Added.
- UserInterface/Images/gtk/WebSocket@2x.png: Added.
- UserInterface/Images/gtk/WebSocketLarge.png: Added.
- UserInterface/Images/gtk/WebSocketLarge@2x.png: Added.
- UserInterface/Views/ResourceIcons.css:
(.resource-icon.resource-type-websocket .icon):
(.large .resource-icon.resource-type-websocket .icon):
(body:matches(.mac-platform, .windows-platform) .resource-icon.resource-type-websocket .icon): Deleted.
(body:matches(.mac-platform, .windows-platform) .large .resource-icon.resource-type-websocket .icon): Deleted.
- 1:16 AM Changeset in webkit [217481] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Show patches applied in each A/B testing build requests
https://bugs.webkit.org/show_bug.cgi?id=172636
Reviewed by Antti Koivisto.
List patches applied along side revisions inn the list of revisions for an A/B tesing build requests if there
are any patches applied.
- public/v3/components/test-group-revision-table.js:
(TestGroupRevisionTable.prototype._renderTable): Indicate which request is to build a patch and which one is
to run tests.
(TestGroupRevisionTable.prototype._buildCommitCell): Include the patch file's information when there is one.
We need to use the requested commit set instead of the one reported by testers or builders since they don't
include patch or root information.
(TestGroupRevisionTable.prototype._buildCustomRootsCell):
(TestGroupRevisionTable.prototype._buildFileInfo): Extracted from _buildCustomRootsCell.
- 1:15 AM Changeset in webkit [217480] by
-
- 3 edits in trunk/Websites/perf.webkit.org
The queue page is broke when there is a custom analysis task
https://bugs.webkit.org/show_bug.cgi?id=172631
Reviewed by Antti Koivisto.
Fix the bug that we were always assuming each build request to have a test associated.
- public/v3/models/test-group.js:
(TestGroup.createAndRefetchTestGroups): Fixed the bug that we were referring to a non-existent variable task.
- public/v3/pages/build-request-queue-page.js:
(BuildRequestQueuePage.prototype._constructBuildRequestTable): Fixed the bug. Collect every request in the group
and then find the first test request's test name. Make it clear that we're waiting for a build as needed.
- 1:07 AM Changeset in webkit [217479] by
-
- 8 edits4 deletes in trunk/Source/WebKit2
[WPE] Use AcceleratedDrawingArea instead of its fork
https://bugs.webkit.org/show_bug.cgi?id=172496
Reviewed by Žan Doberšek.
WPE uses its own drawing area implementation, which is actually a fork of AcceleratedDrawingArea, but simplified
for the case of compositing being always forced. AcceleratedDrawingArea already handles the case of compositing
being forced, so now that WPE is upstream we could simply use AcceleratedDrawingArea instead.
- PlatformWPE.cmake:
- Shared/DrawingAreaInfo.h: Remove DrawingAreaTypeWPE type.
- UIProcess/API/wpe/DrawingAreaProxyWPE.cpp: Removed.
- UIProcess/API/wpe/DrawingAreaProxyWPE.h: Removed.
- UIProcess/API/wpe/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDrawingAreaProxy): Create an AcceleratedDrawingAreaProxy.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::mainFrameContentSizeChanged): Moved from DrawingAreaImpl since it actually
belongs here.
- WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create): Create an AcceleratedDrawingArea for WPE port.
- WebProcess/WebPage/DrawingAreaImpl.cpp: Remove mainFrameContentSizeChanged() that doesn't belong here.
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/wpe/DrawingAreaWPE.cpp: Removed.
- WebProcess/WebPage/wpe/DrawingAreaWPE.h: Removed.
- 12:00 AM Changeset in webkit [217478] by
-
- 4 edits in trunk
Prevent async methods named 'function'
https://bugs.webkit.org/show_bug.cgi?id=172598
Reviewed by Mark Lam.
JSTests:
- stress/async-await-syntax.js:
(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntax):
(testTopLevelAsyncAwaitSyntaxSloppyMode):
(prototype.testTopLevelAsyncAwaitSyntaxStrictMode.testSyntax):
(prototype.testTopLevelAsyncAwaitSyntaxStrictMode):
(testTopLevelAsyncAwaitSyntaxSloppyMode.testSyntaxError):
Source/JavaScriptCore:
Prevent async method named 'function' in class.
Link to change in ecma262 specification
https://github.com/tc39/ecma262/pull/884
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseClass):
