Timeline
Jun 28, 2017:
- 11:07 PM Changeset in webkit [218920] by
-
- 2 edits in trunk/LayoutTests
[Win] Update expectations for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=172437
Unreviewed test gardening, update test expectations for failing tests.
- platform/win/TestExpectations:
- 10:45 PM Changeset in webkit [218919] by
-
- 2 edits in trunk/Source/WebCore
Only apply font features for the particular type of font they are being applied to
https://bugs.webkit.org/show_bug.cgi?id=172661
<rdar://problem/31534119>
<rdar://problem/32799624>
Reviewed by Simon Fraser.
There are two types of font formats which support features: AAT and OTF. Each of them has
a different idea about what the identity of a feature is. We were specifying both types
of feature identities to Core Text; however, this is causing Core Text to get confused.
Instead, we should only apply AAT features to AAT fonts and OTF features to OTF fonts.
Test: Un-marking these tests as failure on High Sierra:
css3/font-variant-petite-caps-synthesis-coverage.html
css3/font-variant-small-caps-synthesis-coverage.html
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontType::FontType):
(WebCore::preparePlatformFont):
(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::isGXVariableFont): Deleted.
- 10:43 PM Changeset in webkit [218918] by
-
- 3 edits in trunk/Source/WebCore
[ResourceLoadStatistics] Simplify PrevalentResourceTelemetry struct
https://bugs.webkit.org/show_bug.cgi?id=173953
Reviewed by Sam Weinig.
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::sortedPrevalentResourceTelemetry):
- loader/ResourceLoadStatisticsStore.h:
(WebCore::PrevalentResourceTelemetry::PrevalentResourceTelemetry): Deleted.
- 10:25 PM WebIDLToDo edited by
- (diff)
- 9:37 PM Changeset in webkit [218917] by
-
- 4 edits1 add in trunk
MobileSafari was constantly using 10-15% CPU viewing a PDF
https://bugs.webkit.org/show_bug.cgi?id=173944
<rdar://problem/33039910>
Reviewed by Simon Fraser.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _doAfterNextStablePresentationUpdate:]):
(-[WKWebView _doAfterNextPresentationUpdate:]):
(-[WKWebView _doAfterNextPresentationUpdateWithoutWaitingForPainting:]):
Bail early and just dispatch_async the completion block if we are using a custom
content view; these methods are very specific to the implementation of WKContentView
and don't make sense with custom content views.
doAfterNextStablePresentationUpdate is particularly egregious because, since
we will never call the stable update callbacks (because we bail from didCommitLayerTree
if we aren't using WKContentView), it will keep calling doAfterNextPresentationUpdate
over and over again.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
Add a test that we ever call the stable presentation update callback
when we have a WKPDFView up, instead of infinitely looping.
- 9:04 PM Changeset in webkit [218916] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][macOS][iOS] Don't request microphone access for clients that don't need it.
https://bugs.webkit.org/show_bug.cgi?id=173948
<rdar://problem/32103275>
Reviewed by Eric Carlson.
Don't bother requesting a sandbox extension to access the microphone for any clients
on the Cocoa platform that are not Safari. Other clients don't have the necessary
system entitlements, and always fail leading to annoying SandboxViolation reports.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- 8:58 PM Changeset in webkit [218915] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange
https://bugs.webkit.org/show_bug.cgi?id=173958
Reviewed by Simon Fraser.
The crashed is most likely caused by updateLayersAfterAncestorChange calling [CALayer setPosition]
with a CGPoint which contains the x coordinate or the y coordinate of NaN.
Simon and I inpected the code but we couldn't figure out how we get there. Detect this case and bail out.
Also log the relevant values and debug assert when this condition is hit to help identifying the root cause.
- page/scrolling/mac/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::updateLayersAfterAncestorChange):
- 8:55 PM Changeset in webkit [218914] by
-
- 2 edits in trunk/Source/WebCore
ResourceLoadObserver clean up
https://bugs.webkit.org/show_bug.cgi?id=173955
Reviewed by Sam Weinig and Brent Fulgham.
ResourceLoadObserver clean up: Modernize code a bit and get rid of unused variables.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::clearInMemoryStore):
(WebCore::ResourceLoadObserver::clearInMemoryAndPersistentStore):
(WebCore::ResourceLoadObserver::shouldLog):
(WebCore::ResourceLoadObserver::logFrameNavigation):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
(WebCore::ResourceLoadObserver::logUserInteraction):
(WebCore::ResourceLoadObserver::setSubframeUnderTopFrameOrigin):
(WebCore::ResourceLoadObserver::setSubresourceUnderTopFrameOrigin):
(WebCore::ResourceLoadObserver::setSubresourceUniqueRedirectTo):
(WebCore::ResourceLoadObserver::fireDataModificationHandler):
(WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler):
(WebCore::ResourceLoadObserver::primaryDomain):
(WebCore::ResourceLoadObserver::statisticsForOrigin):
- 8:54 PM Changeset in webkit [218913] by
-
- 8 edits in trunk/Source
Move RenderEmbeddedObject::isReplacementObscured to HTMLPlugInElement
https://bugs.webkit.org/show_bug.cgi?id=173802
<rdar://problem/32884389>
Reviewed by Simon Fraser.
Source/WebCore:
Hittesting could potentially destroy "this" renderer so calling it inside RenderEmbeddedObject
could leave the caller with a stale pointer.
This patch protects the plugin element from getting destroyed and checks if the renderer got
deleted during the hittest to avoid nullptr dereference.
Speculative fix.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::isReplacementObscured):
- html/HTMLPlugInElement.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::isReplacementObscured): Deleted.
- rendering/RenderEmbeddedObject.h:
- testing/Internals.cpp:
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
- 8:28 PM Changeset in webkit [218912] by
-
- 2 edits in trunk/Source/WebCore
Avoid copying statistics in ResourceLoadStatisticsStore::readDataFromDecoder()
https://bugs.webkit.org/show_bug.cgi?id=173951
Reviewed by Ryosuke Niwa.
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):
- 7:56 PM Changeset in webkit [218911] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r218842): com.apple.WebKit crash in WebKit::ProcessLauncher::launchProcess
https://bugs.webkit.org/show_bug.cgi?id=173950
Reviewed by Chris Dumez.
Added a null check as m_xpcConnection could be nullptr here in the case platformInvalidate had been called.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- 7:54 PM Changeset in webkit [218910] by
-
- 13 edits2 adds in trunk/Source/WebCore
Safari's Speedometer score massively regresses when accessibility is enabled
https://bugs.webkit.org/show_bug.cgi?id=173912
Reviewed by Chris Fleizach.
The bug was caused by HTMLTextFormControlElement::setInnerTextValue triggering a synchronous layout
via constructing VisiblePosition when the accessibility tree is present.
Added AXObjectCache::postTextReplacementNotificationForTextControl which avoids the construction of
VisiblePosition and other means of triggering a synchronous layout. This patch also fixes a subtle bug
that HTMLTextFormControlElement was creating TextMarkerData with axID set to that of the text control
element instead of the root editable element inside its shadow tree even though the typing command uses
axID of the root editable element. While I couldn't find any user-visible behavioral change from this
code change, new code is more self-consistent.
Also added LayoutDisallowedScope which asserts that no synchronous layout happens in setInnerTextValue
so that we don't introduce a new performance regression like this in the future.
No new tests. Existing tests in accessibility directory covers this.
- CMakeLists.txt: Added LayoutDisallowedScope.cpp.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::postTextReplacementNotificationForTextControl): Added.
(WebCore::AXObjectCache::textMarkerDataForVisiblePosition): Modernized. Returns optional<TextMarkerData>
instead of taking TextMarkerData as an out-argument, and returning with axID of 0.
(WebCore::AXObjectCache::textMarkerDataForFirstPositionInTextControl): Added. This specialized version
constructs TextMarkerData for the first position inside the editable region in a text control without
triggering a synchronous layout.
- accessibility/AXObjectCache.h:
(WebCore::TextMarkerData): Initialize each member automatically.
(WebCore::AXObjectCache::postTextReplacementNotificationForTextControl):
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl): Added.
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(+[WebAccessibilityTextMarker textMarkerWithVisiblePosition:cache:]):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::addTextMarkerFor): Extracted from textReplacementChangeDictionary. Added a new variant which
takes a text form control instead.
(WebCore::textReplacementChangeDictionary): Templatized this function to either take VisiblePosition
and call textMarkerForVisiblePosition or take HTMLTextFormControlElement and call
textMarkerForFirstPositionInTextControl.
(WebCore::postUserInfoForChanges): Extracted from postTextReplacementPlatformNotification.
(WebCore::AXObjectCache::postTextReplacementPlatformNotification):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl): Added.
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(textMarkerForVisiblePosition):
(-[WebAccessibilityObjectWrapper textMarkerForFirstPositionInTextControl:]): Added.
- dom/Document.cpp:
(WebCore::Document::updateLayout): Assert that LayoutDisallowedScope is not in the stack frame.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue): Call postTextReplacementNotificationForTextControl
to avoid triggering a synchronous layout. Also create LayoutDisallowedScope to avoid a similar performance
regression from being introduced in the future in this function. Finally, made innerText a RefPtr for extra
safety since we're using it after updating the DOM tree.
- rendering/LayoutDisallowedScope.cpp: Added.
- rendering/LayoutDisallowedScope.h: Added.
(WebCore::LayoutDisallowedScope::LayoutDisallowedScope):
(WebCore::LayoutDisallowedScope::~LayoutDisallowedScope):
(WebCore::LayoutDisallowedScope::isLayoutAllowed):
- 7:46 PM Changeset in webkit [218909] by
-
- 5 edits3 adds in trunk
[iOS] Cannot italicize or bold text rendered with text styles
https://bugs.webkit.org/show_bug.cgi?id=173634
Reviewed by Darin Adler.
Source/WebCore:
r218616 enabled the new cascade list codepath for "system-ui," but didn't do it for the named
text styles (like "font: -apple-system-tall-body;"). This new codepath is better because it
correctly specifies weights and italics (using kCTFontWeightTrait and kCTFontSlantTrait) instead
of using symbolic traits, and because it correctly handles fonts in the Core Text fallback chain.
This patch migrates the named text styles to this new codepath.
Test: fast/text/ipad/bold-tall-body-text-style.html
- platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::CoreTextCascadeListParameters):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::isHashTableDeletedValue):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::operator==):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::hash):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::CoreTextCascadeListParametersHash::hash):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::CoreTextCascadeListParametersHash::equal):
(WebCore::SystemFontDatabase::systemFontCascadeList):
(WebCore::convertArray):
(WebCore::convertArray):
(WebCore::makeNeverDestroyed):
(WebCore::isUIFontTextStyle):
(WebCore::systemFontParameters):
(WebCore::FontCascadeDescription::effectiveFamilyCount):
(WebCore::FontCascadeDescription::effectiveFamilyAt):
(WebCore::SystemFontDatabase::CoreTextCascadeListParametersHash::hash): Deleted.
(WebCore::SystemFontDatabase::CoreTextCascadeListParametersHash::equal): Deleted.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::platformFontWithFamilySpecialCase):
LayoutTests:
- fast/text/ipad/bold-tall-body-text-style-expected-mismatch.html: Added.
- fast/text/ipad/bold-tall-body-text-style.html: Added.
- 6:43 PM WebIDLToDo edited by
- More WebIDL todos (diff)
- 6:34 PM Changeset in webkit [218908] by
-
- 17 edits2 adds in trunk
Web Inspector: Instrument active pixel memory used by canvases
https://bugs.webkit.org/show_bug.cgi?id=173087
<rdar://problem/32719261>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/Canvas.json:
- Add optional
memoryCostattribute to theCanvastype. - Add
canvasMemoryChangedevent that is dispatched when thememoryCostof a canvas changes.
- Add optional
Source/WebCore:
Test: inspector/canvas/memory.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::setImageBuffer):
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didChangeCanvasMemory):
(WebCore::InspectorCanvasAgent::buildObjectForCanvas):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didChangeCanvasMemory):
(WebCore::InspectorInstrumentation::didChangeCanvasMemoryImpl):
Source/WebInspectorUI:
- .eslintrc:
- UserInterface/Controllers/CanvasManager.js:
(WebInspector.CanvasManager.prototype.canvasMemoryChanged):
- UserInterface/Models/Canvas.js:
(WebInspector.Canvas.fromPayload):
(WebInspector.Canvas.prototype.get memoryCost):
(WebInspector.Canvas.prototype.set memoryCost):
- UserInterface/Protocol/CanvasObserver.js:
(WebInspector.CanvasObserver.prototype.canvasMemoryChanged):
- UserInterface/Views/CanvasDetailsSidebarPanel.js:
(WebInspector.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshIdentitySection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._formatMemoryRow):
(WebInspector.CanvasDetailsSidebarPanel.prototype._canvasMemoryChanged):
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Utilities.js:
(Number.bytesToString.value):
Add support for gigabyte numbers.
LayoutTests:
- inspector/canvas/memory-expected.txt: Added.
- inspector/canvas/memory.html: Added.
- 6:28 PM WebIDLToDo edited by
- Add more todos (diff)
- 6:11 PM Changeset in webkit [218907] by
-
- 4 edits in trunk
Prevent displaying URLs with small capital letters
https://bugs.webkit.org/show_bug.cgi?id=173949
<rdar://problem/32952058>
Reviewed by Brent Fulgham.
Source/WebCore:
Covered by new API tests.
- platform/mac/WebCoreNSURLExtras.mm:
(WebCore::isLookalikeCharacter):
Tools:
- TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
- 5:51 PM Changeset in webkit [218906] by
-
- 2 edits in trunk/Tools
Unreviewed test fix.
Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
- TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
- 5:34 PM WebIDLToDo edited by
- Update WebIDL todos to note complete tasks (diff)
- 5:21 PM Changeset in webkit [218905] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Unreviewed, fix a bad ChangeLog entry in r218899.
Remove a leading space from the first line of the ChangeLog entry.
- 5:08 PM Changeset in webkit [218904] by
-
- 2 edits in trunk/Websites/webkit.org
Add a Object rest/spread test to the experimental features test page
https://bugs.webkit.org/show_bug.cgi?id=173947
Rubber stamped by Dean Jackson.
- experimental-features.html:
- 4:24 PM Changeset in webkit [218903] by
-
- 15 edits in trunk/Source
Support PeerConnectionStates::BundlePolicy::MaxBundle when setting rtc configuration
https://bugs.webkit.org/show_bug.cgi?id=169389
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-28
Reviewed by Alex Christensen.
Source/WebCore:
Covered by manual testing (appr.tc and https://youennf.github.io/webrtc-tests/src/content/peerconnection/trickle-ice/).
Previously, we were creating a libwebrtc peer connection and then setting its configuration.
libwebrtc does not like the configuration to be changed and may refuse to set the configuration.
Instead of doing that, we are now creating the libwebrtc peer connection with the provided configuration.
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::setConfiguration):
- Modules/mediastream/MediaEndpointPeerConnection.h:
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::initializeWith):
(WebCore::iceServersFromConfiguration):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):
- Modules/mediastream/RTCPeerConnection.h:
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
(WebCore::LibWebRTCMediaEndpoint::setConfiguration):
(WebCore::LibWebRTCMediaEndpoint::stop):
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::configurationFromMediaEndpointConfiguration):
(WebCore::LibWebRTCPeerConnectionBackend::setConfiguration):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::createActualPeerConnection):
(WebCore::LibWebRTCProvider::createPeerConnection):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
Source/WebKit2:
Updating according new WebCore LIbWebRTCProvider API.
- WebProcess/Network/webrtc/LibWebRTCProvider.cpp:
(WebKit::LibWebRTCProvider::createPeerConnection):
- WebProcess/Network/webrtc/LibWebRTCProvider.h:
- 4:22 PM Changeset in webkit [218902] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Allow WKWebView clients to play audio in the background
https://bugs.webkit.org/show_bug.cgi?id=173932
<rdar://problem/32851547>
Reviewed by Ryosuke Niwa.
Allow WKWebView clients (such as MobileSafari) to play audio in the background
by taking a process assertion whenever a WebPage is audible.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::updateThrottleState):
- 4:21 PM Changeset in webkit [218901] by
-
- 17 edits5 adds in trunk
Teach ResourceLoadStatistics to recognize changes in the file system
https://bugs.webkit.org/show_bug.cgi?id=173800
<rdar://problem/32937842>
Reviewed by Chris Dumez.
Source/WebCore:
We want to support the case where multiple UI processes choose to share the same
statistics file. To support this, update the ResourceLoadStatistics logic to be aware
that the statistics data file might change underneath it, and to take appropriate
action when it does.
- WebCore.xcodeproj/project.pbxproj: Update for new sources.
- WebCore/CMakeLists.txt: Update for new FileMonitor source file.
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::clearInMemoryAndPersistent): Use the new deletion
handler for the data file instead of writing out an empty file.
(WebCore::ResourceLoadStatisticsStore::setDeletePersistentStoreCallback): Added.
- loader/ResourceLoadStatisticsStore.h:
- platform/FileMonitor.cpp: Added.
(WebCore::FileMonitor::create):
(WebCore::FileMonitor::FileMonitor): Register handlers and begin monitoring file.
(WebCore::FileMonitor::~FileMonitor): Stop any active file monitoring.
(WebCore::FileMonitor::startMonitoringPath): Stub implementation.
(WebCore::FileMonitor::stopMonitoring): Ditto.
- platform/FileMonitor.h: Added.
- platform/FileSystem.h: Export files needed by WebKit2. Add support for O_EVTONLY
Darwin file handles.
- platform/Logging.h: Add 'ResourceLoadStatistics' category.
- platform/cocoa/FileMonitorCocoa.mm: Added.
(WebCore::FileMonitor::startMonitoringPath): Create a new VNODE type dispatch_source
to receive notifications when the specified file changes.
(WebCore::FileMonitor::stopMonitoring): Cancel the dispatch_source when we are done
monitoring the file.
- platform/posix/FileSystemPOSIX.cpp: Update 'openFile' to understand the O_EVTONLY
mode of file handles (Darwin-only).
Source/WebKit2:
We want to support the case where multiple UI processes choose to share the same
statistics file. To support this, update the ResourceLoadStatistics logic to be aware
that the statistics data file might change underneath it, and to take appropriate
action when it does.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::setResourceLoadStatisticsEnabled): When we enable
the statistics, read in the data and then watch for changes.
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Add a
'delete data' handler to remove the file on disk, not just write an empty store.
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded): Use ASCIILiteral.
(WebKit::WebResourceLoadStatisticsStore::refreshFromDisk): Convenience function.
(WebKit::WebResourceLoadStatisticsStore::writeStoreToDisk): Sync with any on-disk
storage before writing out.
(WebKit::openAndLockFile): Convenience function.
(WebKit::closeAndUnlockFile): Ditto.
(WebKit::WebResourceLoadStatisticsStore::writeEncoderToDisk): Revise to lock file (on
platforms that support it) before writing to disk.
(WebKit::WebResourceLoadStatisticsStore::deleteStoreFromDisk): Added convenience function.
(WebKit::WebResourceLoadStatisticsStore::clearInMemoryData): Ditto.
(WebKit::WebResourceLoadStatisticsStore::startMonitoringStatisticsStorage): Create a
file system monitor to watch for file changes.
(WebKit::WebResourceLoadStatisticsStore::syncWithExistingStatisticsStorageIfNeeded): Added
convenience function.
(WebKit::WebResourceLoadStatisticsStore::createDecoderFromDisk): Revise to read data
directly so we can control file locking.
- UIProcess/WebResourceLoadStatisticsStore.h:
2017-06-28 Wenson Hsieh <Wenson Hsieh>
Followup to r218885: adjust for further UIKit SPI changes
https://bugs.webkit.org/show_bug.cgi?id=173927
<rdar://problem/33020792>
Reviewed by Tim Horton.
On ToT, UIKit now invokes -_dragInteraction:item:shouldDelaySetDownAnimationWithCompletion: before the
completion block of -dragInteraction:willAnimateLiftWithAnimator:session: is called. This means we now need to
store the completion block in -shouldDelaySetDownAnimationWithCompletion: and wait until the UIDragAnimating
completion block in -willAnimateCancelWithAnimator: before invoking it.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanUpDragSourceSessionState]):
Ensure that the set-down completion block is invoked when a drag session ends (e.g., if the web content process
crashes).
(-[WKContentView _dragInteraction:item:shouldDelaySetDownAnimationWithCompletion:]):
(-[WKContentView _api_dragInteraction:item:willAnimateCancelWithAnimator:]):
Source/WTF:
- wtf/DispatchPtr.h: Added (moved from WebKit2)
- wtf/Platform.h: Make sure USE_FILE_LOCK is enabled.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
(TestWebKitAPI::FileMonitorTest::tempFilePath):
(TestWebKitAPI::handleFileModification):
(TestWebKitAPI::handleFileDeletion):
(TestWebKitAPI::resetTestState):
(TestWebKitAPI::TEST_F):
- 4:04 PM Changeset in webkit [218900] by
-
- 4 edits in trunk
[Win] Build JSCOnly on Windows with clang-cl
https://bugs.webkit.org/show_bug.cgi?id=173889
Patch by Stephan Szabo <stephan.szabo@am.sony.com> on 2017-06-28
Reviewed by Konstantin Tokarev.
- CMakeLists.txt:
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsMSVC.cmake:
- 3:58 PM Changeset in webkit [218899] by
-
- 3 edits in trunk/Source/WebKit2
2017-06-28 Wenson Hsieh <Wenson Hsieh>
Followup to r218885: adjust for further UIKit SPI changes
https://bugs.webkit.org/show_bug.cgi?id=173927
<rdar://problem/33020792>
Reviewed by Tim Horton.
On ToT, UIKit now invokes -_dragInteraction:item:shouldDelaySetDownAnimationWithCompletion: before the
completion block of -dragInteraction:willAnimateLiftWithAnimator:session: is called. This means we now need to
store the completion block in -shouldDelaySetDownAnimationWithCompletion: and wait until the UIDragAnimating
completion block in -willAnimateCancelWithAnimator: before invoking it.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanUpDragSourceSessionState]):
Ensure that the set-down completion block is invoked when a drag session ends (e.g., if the web content process
crashes).
(-[WKContentView _dragInteraction:item:shouldDelaySetDownAnimationWithCompletion:]):
(-[WKContentView _api_dragInteraction:item:willAnimateCancelWithAnimator:]):
- 3:53 PM Changeset in webkit [218898] by
-
- 11 edits in trunk/Source/JavaScriptCore
Web Inspector: Cleanup Protocol JSON files
https://bugs.webkit.org/show_bug.cgi?id=173934
Reviewed by Matt Baker.
- inspector/protocol/ApplicationCache.json:
- inspector/protocol/CSS.json:
- inspector/protocol/Console.json:
- inspector/protocol/DOM.json:
- inspector/protocol/DOMDebugger.json:
- inspector/protocol/Debugger.json:
- inspector/protocol/LayerTree.json:
- inspector/protocol/Network.json:
- inspector/protocol/Page.json:
- inspector/protocol/Runtime.json:
Be more consistent about placement of
descriptionproperty.
- 3:53 PM Changeset in webkit [218897] by
-
- 16 edits in trunk/Source
Web Inspector: Remove unused Inspector domain events
https://bugs.webkit.org/show_bug.cgi?id=173905
Reviewed by Matt Baker.
Source/JavaScriptCore:
- inspector/protocol/Inspector.json:
Source/WebInspectorUI:
- UserInterface/Protocol/InspectorObserver.js:
(WebInspector.InspectorObserver.prototype.detached): Deleted.
- UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
- UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
- Versions/Inspector-iOS-10.0.json:
- Versions/Inspector-iOS-10.3.json:
- Versions/Inspector-iOS-7.0.json:
- Versions/Inspector-iOS-8.0.json:
- Versions/Inspector-iOS-9.0.json:
- Versions/Inspector-iOS-9.3.json:
Remove from legacy backends as well since they did not send it.
- 3:40 PM Changeset in webkit [218896] by
-
- 5 edits in trunk
DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
https://bugs.webkit.org/show_bug.cgi?id=173874
Reviewed by Alex Christensen.
Source/WebCore:
Covered by API tests.
Patch started by Carlos Garcia Campos, finished by me.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading): Make all of the callbacks for cancelled IconLoaders.
(WebCore::DocumentLoader::didGetLoadDecisionForIcon): Make the callback even if there's no IconLoader.
(WebCore::DocumentLoader::finishedLoadingIcon):
(WebCore::DocumentLoader::notifyFinishedLoadingIcon):
- loader/DocumentLoader.h:
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
- 3:27 PM Changeset in webkit [218895] by
-
- 2 edits in trunk/Tools
Unreviewed, adding Don Olmstead to contributors.json
- Scripts/webkitpy/common/config/contributors.json:
- 3:06 PM Changeset in webkit [218894] by
-
- 2 edits in trunk/Source/WebKit2
dropInteraction:sessionDidEnd: invokes dragEnded with a UIDragOperation rather than a WebCore::DragOperation
https://bugs.webkit.org/show_bug.cgi?id=173935
Reviewed by Tim Horton.
Replaces a use of UIDragOperationNone with DragOperationNone.
Currently, there is no change in behavior since these are currently the same value (0).
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dropInteraction:sessionDidEnd:]):
- 2:22 PM Changeset in webkit [218893] by
-
- 2 edits in trunk/LayoutTests
Skip webrtc/video-replace-muted-track.html on iOS.
https://bugs.webkit.org/show_bug.cgi?id=173608
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 2:04 PM Changeset in webkit [218892] by
-
- 4 edits in trunk
WebsitePolicies given with navigation policy for redirects should apply to the provisional document
https://bugs.webkit.org/show_bug.cgi?id=173886
<rdar://problem/32543191>
Reviewed by Andy Estes.
Source/WebKit2:
If, for example, we deny video autoplay for the initial request but allow it for the redirect destination
location, the document should allow video autoplay. We were putting these settings onto the wrong DocumentLoader.
When a navigation policy is given to a response of a redirect location, we currently have the DocumentLoader
for the loading document in the FrameLoader's provisionalDocumentLoader, not the documentLoader.
Covered by a new API test.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
(ParsedRange::ParsedRange):
(-[TestSchemeHandler initWithVideoData:]):
(-[TestSchemeHandler webView:startURLSchemeTask:]):
(-[TestSchemeHandler webView:stopURLSchemeTask:]):
(TEST):
- 1:59 PM Changeset in webkit [218891] by
-
- 8 edits4 adds in trunk
Volume controls should be hidden when AirPlay is active
https://bugs.webkit.org/show_bug.cgi?id=173933
<rdar://problem/33011931>
Patch by Antoine Quint <Antoine Quint> on 2017-06-28
Reviewed by Dean Jackson.
Source/WebCore:
Ensure we don't show any volume controls during AirPlay. We set the mute button's enabled state to "false"
when AirPlay is active and key off this enabled stated to control the display of all volume-related controls
throughout the UI.
Tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-controls-hidden-when-mute-button-disabled.html
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html
- Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype._addTopRightBarWithMuteButtonToChildren):
(InlineMediaControls):
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
(MacOSFullscreenMediaControls.prototype.layout):
- Modules/modern-media-controls/media/airplay-support.js:
(AirplaySupport.prototype.syncControl):
(AirplaySupport):
LayoutTests:
Expand the AirplaySupport testing to check that the mute button's enabled state is set to "false"
in AirPlay and add new tests to check that volume controls are correctly hidden when the mute button
is disabled.
- media/modern-media-controls/airplay-support/airplay-support-expected.txt:
- media/modern-media-controls/airplay-support/airplay-support.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-controls-hidden-when-mute-button-disabled-expected.txt: Added.
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-controls-hidden-when-mute-button-disabled.html: Added.
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled-expected.txt: Added.
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html: Added.
- platform/mac/TestExpectations:
- 1:58 PM Changeset in webkit [218890] by
-
- 60 edits in trunk/Source/WebCore
Remove excessive includes from WebCore/css sources
https://bugs.webkit.org/show_bug.cgi?id=173919
Reviewed by Simon Fraser.
No new tests needed.
- css/CSSCanvasValue.cpp:
- css/CSSComputedStyleDeclaration.cpp:
- css/CSSContentDistributionValue.cpp:
- css/CSSCrossfadeValue.cpp:
- css/CSSCursorImageValue.cpp:
- css/CSSCustomPropertyValue.cpp:
- css/CSSDefaultStyleSheets.cpp:
- css/CSSFilterImageValue.cpp:
- css/CSSFontFace.cpp:
- css/CSSFontFaceSet.cpp:
- css/CSSFontFaceSource.cpp:
- css/CSSFontFaceSrcValue.cpp:
- css/CSSFontFeatureValue.cpp:
- css/CSSFontSelector.cpp:
- css/CSSFontValue.cpp:
- css/CSSImageGeneratorValue.cpp:
- css/CSSImageSetValue.cpp:
- css/CSSImageValue.cpp:
- css/CSSImportRule.cpp:
- css/CSSKeyframesRule.cpp:
- css/CSSMediaRule.cpp:
- css/CSSNamedImageValue.cpp:
- css/CSSPrimitiveValue.cpp:
- css/CSSProperty.cpp:
- css/CSSPropertySourceData.cpp:
- css/CSSReflectValue.cpp:
- css/CSSRuleList.cpp:
- css/CSSSegmentedFontFace.cpp:
- css/CSSSelector.cpp:
- css/CSSStyleRule.cpp:
- css/CSSStyleSheet.cpp:
- css/CSSSupportsRule.cpp:
- css/CSSToStyleMap.cpp:
- css/CSSValueList.cpp:
- css/CSSValuePool.cpp:
- css/CSSVariableData.cpp:
- css/ElementRuleCollector.cpp:
- css/InspectorCSSOMWrappers.cpp:
- css/MediaList.cpp:
- css/MediaQueryEvaluator.cpp:
- css/MediaQueryExpression.cpp:
- css/PropertySetCSSStyleDeclaration.cpp:
- css/RGBColor.cpp:
- css/SelectorChecker.cpp:
- css/StyleProperties.cpp:
- css/StyleResolver.cpp:
- css/StyleRule.cpp:
- css/StyleSheetContents.cpp:
- css/TransformFunctions.cpp:
- css/ViewportStyleResolver.cpp:
- css/WebKitCSSRegionRule.cpp:
- css/parser/CSSParser.cpp:
- css/parser/CSSParserFastPaths.cpp:
- css/parser/CSSParserIdioms.cpp:
- css/parser/CSSParserSelector.cpp:
- css/parser/CSSParserToken.cpp:
- css/parser/CSSPropertyParser.cpp:
- css/parser/CSSSelectorParser.cpp:
- css/parser/MediaQueryParser.cpp:
- 1:24 PM Changeset in webkit [218889] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/IndexedDB/idbindex_getAllKeys.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172834
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:02 PM Changeset in webkit [218888] by
-
- 3 edits in trunk/Source/WebKit2
[cmake] Improve configuration tests for librt and libatomic
https://bugs.webkit.org/show_bug.cgi?id=173921
Reviewed by Michael Catanzaro.
- Both tests are converted to use specialized CMake modules
- Both libraries are now linked only if they are really needed and usable by compiler
- librt is no more required to be detected by find_library(), which may fail in case of cross-compilation
- libatomic test moved to port-independent CMakeLists.txt
- CMakeLists.txt:
- PlatformGTK.cmake:
- 12:53 PM Changeset in webkit [218887] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview 34
Added a tag for Safari Technology Preview release 34.
- 12:46 PM Changeset in webkit [218886] by
-
- 4 edits in trunk/Source
Fix CMake build.
- PlatformMac.cmake:
- 12:35 PM Changeset in webkit [218885] by
-
- 2 edits in trunk/Source/WebKit2
[iOS DnD] [WK2] Dragged content flashes after the preview sets down when cancelling a drag
https://bugs.webkit.org/show_bug.cgi?id=173927
<rdar://problem/33020792>
Reviewed by Tim Horton.
When a drag is cancelled, UIKit normally animates fly-back and set-down animations back-to-back. However, for
WebKit2, we need to call out to the web process in order to trigger a repaint of the dragged content at normal
opacity when the drag cancel animation completes. Thus, we can hook into UIKit SPI to split the cancellation
animation into two discrete phases: the fly-back and the set-down (the latter of which may be deferred using a
completion block).
To do this, we implement a new SPI hook, _dragInteraction:item:shouldDelaySetDownAnimationWithCompletion:, to
indicate that the set-down should be deferred, and call the completion block after the next layer tree commit.
Since -shouldDelaySetDownAnimationWithCompletion: is invoked after the UIDragAnimating completion block in
-willAnimateCancelWithAnimator:, this layer tree commit is guaranteed to come after we've told the web process
to repaint at full opacity.
This patch also accounts for additional changes in UIKit. Once -shouldDelaySetDownAnimationWithCompletion:
becomes available, -sessionDidEnd: will no longer be invoked after a cancelled drag lift if the user did not
begin moving. This means that our cleanup logic in -sessionDidEnd: will no longer be executed in this case,
leaving the view with an inconsistent dragging state. To fix this, we need to implement
-dragInteraction:willAnimateLiftWithAnimator:session: to perform drag session cleanup following a cancelled drag
lift, for which the drag animator's final position will be UIViewAnimatingPositionStart.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dragInteraction:willAnimateLiftWithAnimator:session:]):
(-[WKContentView _dragInteraction:item:shouldDelaySetDownAnimationWithCompletion:]):
- 12:17 PM Changeset in webkit [218884] by
-
- 2 edits in trunk/Source/WebCore/PAL
Build fix for PAL
https://bugs.webkit.org/show_bug.cgi?id=173896
Reviewed by Dan Bernstein.
Remove the workaround build fix in r218863.
- PAL.xcodeproj/project.pbxproj: We should be using PROJECT_DIR instead of SRCROOT
when in a nested Xcode project.
- 11:12 AM Changeset in webkit [218883] by
-
- 16 edits1 add in trunk/Source/JavaScriptCore
Ensure that computed new stack pointer values do not underflow.
Re-apply this patch, it originally broke the ARM build because the llint code
generatedsubs xzr, x3, spwhich isn't valid ARM64: the third operand cannot
be SP (that encoding would be ZR instead, subtracting zero). Flip the comparison
and operands to emit valid code (because the second operand can be SP).
- 10:47 AM Changeset in webkit [218882] by
-
- 2 edits in trunk/LayoutTests
Adjusted test expectations for http/tests/loading/resourceLoadStatistics/telemetry-generation.html.
https://bugs.webkit.org/show_bug.cgi?id=173499
Unreviewed test gardening.
- platform/wk2/TestExpectations:
- 10:16 AM Changeset in webkit [218881] by
-
- 5 edits in trunk/Source/WebCore
Remove unnecessary
const doublemethod arguments
https://bugs.webkit.org/show_bug.cgi?id=173925
Patch by Antoine Quint <Antoine Quint> on 2017-06-28
Reviewed by Dean Jackson.
Addressing post-landing feedback from webkit.org/b/173858.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::formattedStringForDuration):
- Modules/mediacontrols/MediaControlsHost.h:
- rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsFormattedStringForDuration):
- rendering/RenderThemeCocoa.h:
- 9:57 AM Changeset in webkit [218880] by
-
- 4 edits in trunk/Source/WebKit/mac
Mark the GraphicsContext as accelerated when the WebHTMLView's layer is drawing asynchronously
https://bugs.webkit.org/show_bug.cgi?id=173899
rdar://problem/32994474
Reviewed by Tim Horton.
When the WebHTMLView is layer-backed, and -drawsAsynchronously on its layer is YES,
then mark the GraphicsContext that WebCore is using for drawing as accelerated, so
that ImageBuffer::createCompatibleBuffer() creates appropriately matched buffers.
Also clean up WebFrame a little, sharing code that checks whether the WebFrame's
documentView is a WebHTMLView.
- WebView/WebFrame.mm:
(-[WebFrame _webHTMLDocumentView]):
(-[WebFrame _paintBehaviorForDestinationContext:]):
(-[WebFrame _drawRect:contentsOnly:]):
(-[WebFrame setTimeoutsPaused:]):
(-[WebFrame prepareForPause]):
(-[WebFrame resumeFromPause]):
(-[WebFrame resetTextAutosizingBeforeLayout]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView drawLayer:inContext:]):
(-[WebHTMLView _web_isDrawingIntoAcceleratedLayer]):
- WebView/WebHTMLViewInternal.h:
- 9:45 AM Changeset in webkit [218879] by
-
- 35 edits in trunk/Source/WebCore
Unreviewed, rolling out r218373.
Output is not right
Reverted changeset:
"Use WTFLogAlways for debug logging so that it shows up in
device system logs"
https://bugs.webkit.org/show_bug.cgi?id=173450
http://trac.webkit.org/changeset/218373
- 9:32 AM Changeset in webkit [218878] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Some web pages disappear immediately after rendering
https://bugs.webkit.org/show_bug.cgi?id=173768
Reviewed by Xabier Rodriguez-Calvar.
This is happening with websites having a "hidden" class in HTML tag when a media element is added. In the GTK+
port the media controls CSS contains the following code:
.hidden {
display: none !important;
}
That causes the whole HTML document to become display: none. That's why we just render a white page, and also
the reason why it only happens with the GTK+ port and only with some specific websites. We should limit the
scope of the hidden class to the media control elements.
- css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel.hidden,):
(audio::-webkit-media-controls-panel div.mute-box.hidden,):
(audio::-webkit-media-controls-current-time-display.hidden,):
(audio::-webkit-media-controls-timeline.hidden,):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-toggle-closed-captions-button.hidden,):
(video::-webkit-media-controls-closed-captions-container.hidden):
(audio::-webkit-media-controls-fullscreen-button.hidden,):
(.hidden): Deleted.
- 9:05 AM Changeset in webkit [218877] by
-
- 6 edits2 adds in trunk
Media controls volume glyph does not have the correct material
https://bugs.webkit.org/show_bug.cgi?id=173918
<rdar://problem/33012697>
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-mute-button-in-bottom-or-top-right-controls-bar.html
All buttons were hosted in a ControlsBar save for the MuteButton, so we now host it in a controls bar as well
to ensure compositing is similar to all other buttons.
- Modules/modern-media-controls/controls/inline-media-controls.css:
(.media-controls.inline > .controls-bar.top-right):
(.media-controls.inline > button.mute): Deleted.
- Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls):
(InlineMediaControls.prototype.layout):
(InlineMediaControls.prototype._addTopRightBarWithMuteButtonToChildren):
- Modules/modern-media-controls/controls/macos-inline-media-controls.js:
(MacOSInlineMediaControls.prototype.handleEvent):
LayoutTests:
Add a new test to check the mute button is correctly hosted in the top-right controls bar
when width becomes scarce.
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-mute-button-in-bottom-or-top-right-controls-bar-expected.txt: Added.
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-mute-button-in-bottom-or-top-right-controls-bar.html: Added.
- platform/mac/TestExpectations:
- 8:55 AM Changeset in webkit [218876] by
-
- 16 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r218869.
Broke the iOS build
Reverted changeset:
"Ensure that computed new stack pointer values do not
underflow."
https://bugs.webkit.org/show_bug.cgi?id=173700
http://trac.webkit.org/changeset/218869
- 8:54 AM Changeset in webkit [218875] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r218873.
Broke the iOS build
Reverted changeset:
"Gardening: CLoop build fix."
https://bugs.webkit.org/show_bug.cgi?id=173700
http://trac.webkit.org/changeset/218873
- 7:24 AM Changeset in webkit [218874] by
-
- 2 edits in trunk/LayoutTests
[GTK] LayoutTest webaudio/silent-audio-interrupted-in-background.html makes its subsequent test flaky crash
https://bugs.webkit.org/show_bug.cgi?id=173916
Unreviewed test gardening.
Patch by Fujii Hironori <Fujii Hironori> on 2017-06-28
- platform/gtk/TestExpectations: Marked it Skip.
- 5:35 AM Changeset in webkit [218873] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: CLoop build fix.
https://bugs.webkit.org/show_bug.cgi?id=173700
<rdar://problem/32926032>
Not reviewed.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- 4:23 AM Changeset in webkit [218872] by
-
- 2 edits in trunk/Source/WTF
Fix typo in comment: WordResult => WorkResult
- wtf/AutomaticThread.h:
- 12:34 AM Changeset in webkit [218871] by
-
- 3 edits in trunk/Source/WebKit2
Avoid double thread dispatch in WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains()
https://bugs.webkit.org/show_bug.cgi?id=173904
Reviewed by Brent Fulgham.
Avoid double thread dispatch in WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains().
It calls fetchData() which dispatches to the main queue, then fetchDataForTopPrivatelyControlledDomains()
dispatches to the background queue. It should be possible to get fetchData() to dispatch directly
on the right queue.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 12:20 AM Changeset in webkit [218870] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(r218799): [GTK][WPE] Critical warning at exit
https://bugs.webkit.org/show_bug.cgi?id=173907
Reviewed by Konstantin Tokarev.
GLib-GObject-CRITICAL : g_object_unref: assertion 'G_IS_OBJECT (object)' failed
This is now always happening when closing the MeiniBrowser and it's causing a lot of unit tests to fail. In
r218799, GRefPtrGtk.h include was removed from PasteboardHelper.h that contains a GRefPtr<GtkTargetList>. The
targets are destroyed at exit, but now trying to use g_object_unref instead of gtk_target_list_unref(). I've
found two more cases like this in r218799, that removes GUniquePtrSoup.h from ResourceHandleInternal.h and
ResourceRequest.h that have GUniquePtr<SoupBuffer> and GUniquePtr<SoupURI>.
Fixes several GTK+ and WPE unit tests.
- platform/gtk/PasteboardHelper.h: Bring back GRefPtrGtk.h.
- platform/network/ResourceHandleInternal.h: Bring back GUniquePtrSoup.h.
- platform/network/soup/ResourceRequest.h: Ditto.
- 12:11 AM Changeset in webkit [218869] by
-
- 16 edits1 add in trunk/Source/JavaScriptCore
Ensure that computed new stack pointer values do not underflow.
https://bugs.webkit.org/show_bug.cgi?id=173700
<rdar://problem/32926032>
Reviewed by Filip Pizlo and Saam Barati.
- Added a RELEASE_ASSERT to BytecodeGenerator::generate() to ensure that m_numCalleeLocals is sane.
- Added underflow checks in LLInt code and VarargsFrame code.
- Introduce minimumReservedZoneSize, which is hardcoded to 16K. Ensure that Options::reservedZoneSize() is at least minimumReservedZoneSize. Ensure that Options::softReservedZoneSize() is at least greater than Options::reservedZoneSize() by minimumReservedZoneSize.
- Ensure that stack checks emitted by JIT tiers include an underflow check if and only if the max size of the frame is greater than Options::reservedZoneSize().
By design, we are guaranteed to have at least Options::reservedZoneSize() bytes
of memory at the bottom (end) of the stack. This means that, at any time, the
frame pointer must be at least Options::reservedZoneSize() bytes away from the
end of the stack. Hence, if the max frame size is less than
Options::reservedZoneSize(), there's no way that frame pointer - max
frame size can underflow, and we can elide the underflow check.
Note that we use Options::reservedZoneSize() instead of
Options::softReservedZoneSize() for determine if we need an underflow check.
This is because the softStackLimit that is used for stack checks can be set
based on Options::reservedZoneSize() during error handling (e.g. when creating
strings for instantiating the Error object). Hence, the guaranteed minimum of
distance between the frame pointer and the end of the stack is
Options::reservedZoneSize() and nor Options::softReservedZoneSize().
Note also that we ensure that Options::reservedZoneSize() is at least
minimumReservedZoneSize (i.e. 16K). In typical deployments,
Options::reservedZoneSize() may be larger. Using Options::reservedZoneSize()
instead of minimumReservedZoneSize gives us more chances to elide underflow
checks.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::requiredRegisterCountForExecutionAndExit):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- jit/JIT.cpp:
(JSC::JIT::compileWithoutLinking):
- jit/SetupVarargsFrame.cpp:
(JSC::emitSetupVarargsFrameFastCase):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/MinimumReservedZoneSize.h: Added.
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/VM.cpp:
(JSC::VM::updateStackLimits):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
- wasm/js/WebAssemblyFunction.cpp:
(JSC::callWebAssemblyFunction):
Jun 27, 2017:
- 11:42 PM Changeset in webkit [218868] by
-
- 15 edits4 adds in trunk
WebAssembly: running out of executable memory should throw OoM
https://bugs.webkit.org/show_bug.cgi?id=171537
<rdar://problem/32963338>
Reviewed by Saam Barati.
JSTests:
- wasm.yaml:
- wasm/lowExecutableMemory/executable-memory-oom.js: Added.
(const.invoke):
(failCount.0.catch):
(failCount.0.module.undefined.catch):
- wasm/lowExecutableMemory/exports-oom.js: Added.
(const.type):
(const.params):
(const.randomProgram):
(failCount.0.catch):
(failCount.0.module.undefined.catch):
- wasm/lowExecutableMemory/imports-oom.js: Added.
(const.type):
(const.params):
(const.randomProgram):
(f.imports.push):
(failCount.0.catch):
(failCount.0.module.undefined.catch):
Source/JavaScriptCore:
Both on first compile with BBQ as well as on tier-up with OMG,
running out of X memory shouldn't cause the entire program to
terminate. An exception will do when compiling initial code (since
we don't have any other fallback at the moment), and refusal to
tier up will do as well (it'll just be slower).
This is useful because programs which generate huge amounts of
code simply look like crashes, which developers report to
us. Getting a JavaScript exception instead is much clearer.
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::shouldJIT):
- runtime/Options.h:
- wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::prepare):
(JSC::Wasm::BBQPlan::complete):
- wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToJs):
(JSC::Wasm::wasmToWasm):
- wasm/WasmBinding.h:
- wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::work):
- wasm/js/JSWebAssemblyCodeBlock.cpp:
(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):
- wasm/js/JSWebAssemblyCodeBlock.h:
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::finalizeCreation):
Tools:
- Scripts/run-jsc-stress-tests: add a configuration which runs the
tests under limited executable memory and avoids non-WebAssembly
code generation so that we more reliably run out of executable
memory in WebAssembly.
- 11:23 PM Changeset in webkit [218867] by
-
- 4 edits in trunk/Source/JavaScriptCore
JITStubRoutine::passesFilter should use isJITPC
https://bugs.webkit.org/show_bug.cgi?id=173906
Reviewed by JF Bastien.
This patch makes JITStubRoutine use the isJITPC abstraction defined
inside ExecutableAllocator.h. Before, JITStubRoutine was using a
hardcoded platform size constant. This means it'd do the wrong thing
if Options::jitMemoryReservationSize() was larger than the defined
constant for that platform. This patch also removes a bunch of
dead code in that file.
- jit/ExecutableAllocator.cpp:
- jit/ExecutableAllocator.h:
- jit/JITStubRoutine.h:
(JSC::JITStubRoutine::passesFilter):
(JSC::JITStubRoutine::canPerformRangeFilter): Deleted.
(JSC::JITStubRoutine::filteringStartAddress): Deleted.
(JSC::JITStubRoutine::filteringExtentSize): Deleted.
- 10:45 PM Changeset in webkit [218866] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix some stale comments in Wasm code base
https://bugs.webkit.org/show_bug.cgi?id=173814
Reviewed by Mark Lam.
- wasm/WasmBinding.cpp:
(JSC::Wasm::wasmToJs):
- wasm/WasmOMGPlan.cpp:
(JSC::Wasm::runOMGPlanForIndex):
- 10:14 PM Changeset in webkit [218865] by
-
- 12 edits in trunk/Source
[ResourceLoadStatistics] Update minimumTimeBetweeenDataRecordsRemoval to 1 hour instead of 1 minute
https://bugs.webkit.org/show_bug.cgi?id=173895
<rdar://problem/32984366>
Reviewed by Brent Fulgham.
Update minimumTimeBetweeenDataRecordsRemoval to 1 hour instead of 1 minute to save battery.
Also port code to modern time types.
Source/WebCore:
- loader/ResourceLoadObserver.cpp:
(WebCore::reduceTimeResolution):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
(WebCore::ResourceLoadObserver::setTimeToLiveUserInteraction):
(WebCore::ResourceLoadObserver::setTimeToLiveCookiePartitionFree):
(WebCore::ResourceLoadObserver::setMinimumTimeBetweeenDataRecordsRemoval):
(WebCore::ResourceLoadObserver::setReducedTimestampResolution):
(WebCore::ResourceLoadObserver::setGrandfatheringTime):
- loader/ResourceLoadObserver.h:
- loader/ResourceLoadStatistics.h:
(WebCore::ResourceLoadStatistics::mostRecentUserInteractionTime):
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::createEncoderFromData):
(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):
(WebCore::shouldPartitionCookies):
(WebCore::ResourceLoadStatisticsStore::setTimeToLiveUserInteraction):
(WebCore::ResourceLoadStatisticsStore::setTimeToLiveCookiePartitionFree):
(WebCore::ResourceLoadStatisticsStore::setMinimumTimeBetweeenDataRecordsRemoval):
(WebCore::ResourceLoadStatisticsStore::setGrandfatheringTime):
(WebCore::ResourceLoadStatisticsStore::hasHadRecentUserInteraction):
(WebCore::ResourceLoadStatisticsStore::topPrivatelyControlledDomainsToRemoveWebsiteDataFor):
(WebCore::ResourceLoadStatisticsStore::handleFreshStartWithEmptyOrNoStore):
(WebCore::ResourceLoadStatisticsStore::shouldRemoveDataRecords):
(WebCore::ResourceLoadStatisticsStore::dataRecordsBeingRemoved):
- loader/ResourceLoadStatisticsStore.h:
Source/WebKit2:
- UIProcess/API/C/WKResourceLoadStatisticsManager.cpp:
(WKResourceLoadStatisticsManagerSetTimeToLiveUserInteraction):
(WKResourceLoadStatisticsManagerSetTimeToLiveCookiePartitionFree):
(WKResourceLoadStatisticsManagerSetMinimumTimeBetweeenDataRecordsRemoval):
(WKResourceLoadStatisticsManagerSetGrandfatheringTime):
- UIProcess/WebResourceLoadStatisticsManager.cpp:
(WebKit::WebResourceLoadStatisticsManager::setTimeToLiveUserInteraction):
(WebKit::WebResourceLoadStatisticsManager::setTimeToLiveCookiePartitionFree):
(WebKit::WebResourceLoadStatisticsManager::setMinimumTimeBetweeenDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsManager::setGrandfatheringTime):
- UIProcess/WebResourceLoadStatisticsManager.h:
- UIProcess/WebResourceLoadStatisticsStore.h:
- 10:06 PM Changeset in webkit [218864] by
-
- 5 edits in trunk/Source
Port HysteresisActivity to Seconds type
https://bugs.webkit.org/show_bug.cgi?id=173902
Reviewed by Simon Fraser.
Source/WebCore:
- platform/HysteresisActivity.h:
(WebCore::HysteresisActivity::HysteresisActivity):
(WebCore::HysteresisActivity::stop):
- platform/ios/WebSQLiteDatabaseTrackerClient.mm:
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_pageScrolledHysteresis):
- 9:52 PM Changeset in webkit [218863] by
-
- 2 edits in trunk/Source/WebCore/PAL
Build fix for PAL
https://bugs.webkit.org/show_bug.cgi?id=173896
Reviewed by Myles C. Maxfield.
- PAL.xcodeproj/project.pbxproj: Ensure that the SRCROOT is WebCore/PAL and not
just WebCore.
- 9:23 PM Changeset in webkit [218862] by
-
- 4 edits2 adds1 delete in trunk/LayoutTests
Web Inspector: Cleanup RemoteObject tests
https://bugs.webkit.org/show_bug.cgi?id=173885
Reviewed by Matt Baker.
- inspector/model/remote-object-dom.html: Added.
- inspector/model/remote-object-expected.txt:
- inspector/model/remote-object.html:
Split out DOM results (which differ across ports and features).
- inspector/model/resources/remote-object-utilities.js:
(TestPage.registerInitializer.window.runSteps):
This should have been a continue not a return.
- platform/mac/inspector/model/remote-object-dom-expected.txt: Added.
- platform/mac/inspector/model/remote-object-expected.txt: Removed.
Platform expectations are now limited to just the DOM test.
- 8:05 PM Changeset in webkit [218861] by
-
- 25 edits1 add in trunk
[ESnext] Implement Object Rest - Implementing Object Rest Destructuring
https://bugs.webkit.org/show_bug.cgi?id=167962
Reviewed by Saam Barati.
JSTests:
- stress/object-rest-deconstruct.js: Added.
(let.assert):
(let.assertPropDescriptor):
(catch):
(get 3):
(foo):
(let.src.get y):
(let.src.set y):
(let.gen):
Source/JavaScriptCore:
Object Rest/Spread Destructing proposal is in stage 3[1] and this
Patch is a prototype implementation of it. A simple change over the
parser was necessary to support the new '...' token on Object Pattern
destruction rule. In the bytecode generator side, We changed the
bytecode generated on ObjectPatternNode::bindValue to store in an
set the identifiers of already destructured properties, following spec draft
section[2], and then pass it as excludedNames to CopyDataProperties.
The rest destructuring calls copyDataProperties to perform the
copy of rest properties in rhs.
We also implemented CopyDataProperties as private JS global operation
on builtins/GlobalOperations.js following it's specification on [3].
It is implemented using Set object to verify if a property is on
excludedNames to keep this algorithm with O(n + m) complexity, where n
number of source's own properties and m = excludedNames.length.
In this implementation we aren't using excludeList as constant if
destructuring pattern contains computed property, i.e. we can
just determine the key to be excluded at runtime. If we can define all
identifiers in the pattern in compile time, we then create a
constant JSSet. This approach gives a good performance improvement,
since we allocate the excludeSet just once, reducing GC pressure.
[1] - https://github.com/tc39/proposal-object-rest-spread
[2] - https://tc39.github.io/proposal-object-rest-spread/#Rest-RuntimeSemantics-PropertyDestructuringAssignmentEvaluation
[3] - https://tc39.github.io/proposal-object-rest-spread/#AbstractOperations-CopyDataProperties
- builtins/BuiltinNames.h:
- builtins/GlobalOperations.js:
(globalPrivate.copyDataProperties):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
- bytecompiler/NodesCodegen.cpp:
(JSC::ObjectPatternNode::bindValue):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::appendObjectPatternEntry):
(JSC::ASTBuilder::appendObjectPatternRestEntry):
(JSC::ASTBuilder::setContainsObjectRestElement):
- parser/Nodes.h:
(JSC::ObjectPatternNode::appendEntry):
(JSC::ObjectPatternNode::setContainsRestElement):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseProperty):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::operatorStackPop):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::asyncFunctionStructure):
(JSC::JSGlobalObject::setStructure): Deleted.
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::privateToObject):
- runtime/JSGlobalObjectFunctions.h:
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/SetPrototype.cpp:
(JSC::SetPrototype::finishCreation):
Source/WTF:
- wtf/HashSet.h:
(WTF::=):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 6:47 PM Changeset in webkit [218860] by
-
- 2 edits in trunk/Source/WebKit2
Move WebsiteDataRecord processing off-thread in WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains()
https://bugs.webkit.org/show_bug.cgi?id=173882
<rdar://problem/32984366>
Reviewed by Darin Adler.
Move WebsiteDataRecord processing off-thread in WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains()
as we have data showing it is slow and hangs the UIProcess' main thread.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):
- 6:09 PM Changeset in webkit [218859] by
-
- 5 edits in trunk/LayoutTests
Unreviewed, unmark workers/bomb.html flakiness after r218856
- platform/gtk-wayland/TestExpectations:
- platform/ios-device/TestExpectations:
- platform/ios-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 6:06 PM Changeset in webkit [218858] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][macOS] Expand sandbox to allow access to the CoreMedia volume control endpoint
https://bugs.webkit.org/show_bug.cgi?id=173898
<rdar://problem/32930754>
Reviewed by Ryosuke Niwa.
- WebProcess/com.apple.WebProcess.sb.in:
- 6:04 PM Changeset in webkit [218857] by
-
- 2 edits in trunk/Source/WebCore
MediaPlayerPrivate m_private may not yet be created when setPrivateBrowsingMode is called.
https://bugs.webkit.org/show_bug.cgi?id=173893
rdar://problem/32986872
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-06-27
Reviewed by Ryosuke Niwa.
No new tests because no reproducable case.
setPrivateBrowsingMode can be called on MediaPlayer before the MediaPlayerPrivate is created.
The value should only be pushed down the m_private if it has been created.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setPrivateBrowsingMode):
- 5:46 PM Changeset in webkit [218856] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Do not touch VM after notifying Ready in DFG::Worklist
https://bugs.webkit.org/show_bug.cgi?id=173888
Reviewed by Saam Barati.
After notifying Plan::Ready and releasing Worklist lock, VM can be destroyed.
Thus, Plan::vm() can return a destroyed VM. Do not touch it.
This causes occasional SEGV / assertion failures in workers/bomb test.
- dfg/DFGWorklist.cpp:
- 5:36 PM Changeset in webkit [218855] by
-
- 12 edits1 add in trunk
[iOS DnD] Support dragging out of contenteditable areas without a prior selection
https://bugs.webkit.org/show_bug.cgi?id=173854
<rdar://problem/32236827>
Reviewed by Ryosuke Niwa and Tim Horton.
Source/WebCore:
Allows elements to be dragged from contenteditable areas for both WebKit1 and WebKit2 iOS. There are two main
changes in WebCore: move the touch point adjustment code into EventHandler::tryToBeginDataInteractionAtPoint, so
that the clientPosition specified will be adjusted to an appropriate clickable node if needed. This is necessary
because UIWebDocumentView and WKContentView no longer send adjusted points to WebCore when requesting drag
start. See <https://bugs.webkit.org/show_bug.cgi?id=173855> for a followup regarding the globalPosition and
clientPositions passed in to the MouseEvents when performing a drag or synthetic click.
Secondly, image elements in Mail's contenteditable area are not draggable unless the heuristic in
DragController::draggableElement is tweaked to not reject image dragging across the board if the
loadsImagesAutomatically setting is turned off. Instead, even if images are not automatically loaded, allow the
image drag to commence if the image renderer already has a cached image.
Test: DataInteractionTests.DragImageFromContentEditable
- page/DragController.cpp:
(WebCore::imageElementIsDraggable):
(WebCore::DragController::draggableElement):
- page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::tryToBeginDataInteractionAtPoint):
Source/WebKit/mac:
Vends some information from the DragItem passed into -[WebView _startDrag:] through the WebView as SPI for
WebKit1 clients. No behavior change with these changes alone -- see <rdar://problem/32991062> for more detail.
- WebView/WebView.mm:
(-[WebView _startDrag:]):
(-[WebView _dragSourceAction]):
(-[WebView _draggedLinkTitle]):
(-[WebView _draggedLinkURL]):
(-[WebView _draggedElementBounds]):
(-[WebView _endedDataInteraction:global:]):
- WebView/WebViewData.h:
- WebView/WebViewPrivate.h:
Source/WebKit2:
Instead of allowing a drag to occur only if a position information request discovers a clickable node, remove
the position information request entirely and just call into WebCore to try and begin the drag. Currently, the
position information request serves two purposes:
- To adjust the hit-test location to account for nearby clickable nodes.
- To obtain information about the content being dragged.
The first requirement is fulfilled by performing the drag location adjustment in WebCore instead (see
ChangeLogs for more detail). The second requirement is fulfilled by refactoring in
https://bugs.webkit.org/show_bug.cgi?id=173832 to fold all information relevant to starting a drag into the
DragItem struct, and then propagating the DragItem struct. The relevant information from the position
information update is now populated when the UI process receives the drag start response.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _startDrag:item:]):
(-[WKContentView computeClientAndGlobalPointsForDropSession:outClientPoint:outGlobalPoint:]):
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
(-[WKContentView _api_dropInteraction:sessionDidEnter:]):
(-[WKContentView _api_dropInteraction:sessionDidUpdate:]):
(positionInformationMayStartDataInteraction): Deleted.
Tools:
Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- 4:55 PM Changeset in webkit [218854] by
-
- 2 edits in trunk/LayoutTests
Marked http/tests/loading/resourceLoadStatistics/telemetry-generation.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173499
Unreviewed test gardening.
- platform/wk2/TestExpectations:
- 4:48 PM Changeset in webkit [218853] by
-
- 14 edits in trunk
[Modern Media Controls] Accessibility labels should be formatted using NSDateComponentsFormatter
https://bugs.webkit.org/show_bug.cgi?id=173858
<rdar://problem/32643171>
Patch by Antoine Quint <Antoine Quint> on 2017-06-27
Reviewed by Dean Jackson.
Source/WebCore:
We shouldn't be manually trying to create a formatted string for media controls and instead rely
on NSDateComponentsFormatter to perform this task for us. So we remove the ad-hoc code in the JS
media controls code and instead add a new MediaControlsHost method to format durations which calls
into RenderTheme to provide a formatted duration string relevant to the current platform and locale.
- English.lproj/modern-media-controls-localized-strings.js:
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::formattedStringForDuration):
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediacontrols/MediaControlsHost.idl:
- Modules/modern-media-controls/controls/slider.js:
(Slider.prototype.set inputAccessibleLabel):
- Modules/modern-media-controls/controls/time-label.js:
(TimeLabel.prototype.commitProperty):
- Modules/modern-media-controls/main.js:
(createControls):
(formattedStringForDuration):
(formatTimeToString): Deleted.
- rendering/RenderTheme.h:
(WebCore::RenderTheme::mediaControlsFormattedStringForDuration):
- rendering/RenderThemeCocoa.h:
- rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::mediaControlsFormattedStringForDuration):
LayoutTests:
- media/modern-media-controls/scrubber/scrubber-has-correct-ax-label-expected.txt:
- media/modern-media-controls/scrubber/scrubber-has-correct-ax-label.html:
- 4:40 PM Changeset in webkit [218852] by
-
- 2 edits in trunk/Source/WebCore
r218647 causes getUserMedia to fail on some machines
https://bugs.webkit.org/show_bug.cgi?id=173894
Reviewed by Youenn Fablet.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::isFrameRateSupported): Change frame rate epsilon from 0.00001
to 0.001.
- 4:29 PM Changeset in webkit [218851] by
-
- 5 edits in trunk
Placard icons act like buttons (can get keyboard focus and shows up in VoiceOver)
https://bugs.webkit.org/show_bug.cgi?id=173891
<rdar://problem/33011855>
Patch by Antoine Quint <Antoine Quint> on 2017-06-27
Reviewed by Dean Jackson.
Source/WebCore:
Ensure that we disable buttons inside placards as they're only decorative and should
not be interactive.
- Modules/modern-media-controls/controls/placard.js:
(Placard.):
LayoutTests:
Update the Placard test to check that its <button> is disabled.
- media/modern-media-controls/placard/placard-expected.txt:
- media/modern-media-controls/placard/placard.html:
- 4:05 PM Changeset in webkit [218850] by
-
- 343 edits269 adds60 deletes in trunk/Source/ThirdParty/libwebrtc
Update boringssl to c8ff30cbe716c72279a6f6a9d7d7d0d4091220fa
https://bugs.webkit.org/show_bug.cgi?id=173676
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-27
Reviewed by Alex Christensen.
- Configurations/boringssl.xcconfig: Enabling ASM.
- Source/third_party/boringssl/BUILD.generated.gni:
- Source/third_party/boringssl: Updated folder according new revision.
- WebKit/patch-boringssl: Added, needed to fix some files to disable warnings.
- libwebrtc.xcodeproj/project.pbxproj:
- 3:54 PM Changeset in webkit [218849] by
-
- 48 edits5 adds in trunk/Source/ThirdParty/libwebrtc
Refresh usrsctp to Source/ThirdParty/libwebrtc/WebKit/patch-usrsctp and libsrtp to ccf84786f8ef803cb9c75e919e5a3976b9f5a67
https://bugs.webkit.org/show_bug.cgi?id=173673
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-27
Reviewed by Sam Weinig.
- Source/third_party/libsrtp/README.chromium:
- Source/third_party/libsrtp/srtp/srtp.c:
(srtp_stream_init_keys):
(srtp_calc_aead_iv_srtcp):
(srtp_protect_rtcp_aead):
(srtp_unprotect_rtcp_aead):
- Source/third_party/libsrtp/test/srtp_driver.c:
(srtp_validate_encrypted_extensions_headers_gcm):
- Source/third_party/usrsctp/usrsctplib/.gitignore: Added.
- Source/third_party/usrsctp/usrsctplib/CMakeLists.txt:
- Source/third_party/usrsctp/usrsctplib/Makefile.am:
- Source/third_party/usrsctp/usrsctplib/README.md:
- Source/third_party/usrsctp/usrsctplib/configure.ac:
- Source/third_party/usrsctp/usrsctplib/programs/CMakeLists.txt:
- Source/third_party/usrsctp/usrsctplib/programs/Makefile.am:
- Source/third_party/usrsctp/usrsctplib/programs/client.c:
(main):
- Source/third_party/usrsctp/usrsctplib/programs/datachan_serv.c:
(main):
- Source/third_party/usrsctp/usrsctplib/programs/ekr_loop_offload.c: Added.
(handle_packets):
- Source/third_party/usrsctp/usrsctplib/programs/test_timer.c: Added.
(main):
- Source/third_party/usrsctp/usrsctplib/usrsctp.pc.in: Added.
- Source/third_party/usrsctp/usrsctplib/usrsctplib/CMakeLists.txt:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_asconf.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_auth.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_auth.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_bsd_addr.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_bsd_addr.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_cc_functions.c:
(sctp_cwnd_update_after_fr):
(sctp_hs_cwnd_update_after_fr):
(sctp_htcp_cwnd_update_after_fr):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_constants.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_crc32.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_crc32.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_header.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_indata.c:
(sctp_build_readq_entry):
(sctp_place_control_in_stream):
(sctp_abort_in_reasm):
(sctp_queue_data_to_stream):
(sctp_build_readq_entry_from_ctl):
(sctp_handle_old_unordered_data):
(sctp_inject_old_unordered_data):
(sctp_deliver_reasm_check):
(sctp_add_chk_to_control):
(sctp_queue_data_for_reasm):
(sctp_find_reasm_entry):
(sctp_process_a_data_chunk):
(sctp_sack_check):
(sctp_process_segment_range):
(sctp_check_for_revoked):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_indata.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:
(sctp_process_init):
(sctp_process_cookie_existing):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_output.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_output.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_pcb.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_pcb.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_peeloff.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_ss_functions.c:
(sctp_ss_rr_add):
(sctp_ss_fcfs_select):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_structs.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_sysctl.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_timer.c:
(sctp_recover_sent_list):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_uio.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_usrreq.c:
(sctp_init):
(sctp_pathmtu_adjustment):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_var.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctputil.c:
(sctp_log_strm_del):
(sctp_init_asoc):
(sctp_notify_send_failed):
(sctp_notify_send_failed2):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctputil.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet6/sctp6_usrreq.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet6/sctp6_var.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/user_mbuf.c:
(m_get):
(mbuf_initialize):
- Source/third_party/usrsctp/usrsctplib/usrsctplib/user_mbuf.h:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/user_socket.c:
- Source/third_party/usrsctp/usrsctplib/usrsctplib/usrsctp.h:
- WebKit/patch-usrsctp: Added.
- 3:43 PM Changeset in webkit [218848] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove an inaccurate comment inside DFGClobberize.h
https://bugs.webkit.org/show_bug.cgi?id=163874
Reviewed by Filip Pizlo.
The comment said that Clobberize may or may not be sound if run prior to
doing type inference. This is not correct, though. Clobberize *must* be sound
prior do doing type inference since we use it inside the BytecodeParser, which
is the very first thing the DFG does.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- 3:39 PM Changeset in webkit [218847] by
-
- 4 edits2 adds in trunk
Disable m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause
https://bugs.webkit.org/show_bug.cgi?id=173843
rdar://problem/32982431
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-06-27
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-fullscreen-pause-inline.html
Some pages may not have a fullscreen button, so disabled m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::pause):
LayoutTests:
Some pages may not have a fullscreen button, so disabled m_temporarilyAllowingInlinePlaybackAfterFullscreen on pause.
- media/media-fullscreen-pause-inline-expected.txt: Added.
- media/media-fullscreen-pause-inline.html: Added.
- platform/mac-wk2/TestExpectations:
- 2:49 PM Changeset in webkit [218846] by
-
- 5 edits in trunk/Source
[iOS] Avoid taking / releasing process assertions too quickly due to database activity
https://bugs.webkit.org/show_bug.cgi?id=173879
<rdar://problem/32412701>
Reviewed by Antti Koivisto.
Source/WebCore:
Add HysteresisActivity to WebSQLiteDatabaseTrackerClient to avoid taking / releasing
process assertion too quickly due to database activity.
- platform/ios/WebSQLiteDatabaseTrackerClient.h:
- platform/ios/WebSQLiteDatabaseTrackerClient.mm:
(WebCore::WebSQLiteDatabaseTrackerClient::WebSQLiteDatabaseTrackerClient):
(WebCore::WebSQLiteDatabaseTrackerClient::willBeginFirstTransaction):
(WebCore::WebSQLiteDatabaseTrackerClient::didFinishLastTransaction):
(WebCore::WebSQLiteDatabaseTrackerClient::hysteresisUpdated):
Source/WebKit2:
Specify an activity name when taking the process assertion to facilitate
debugging in the future. It took me a while to figure out this assertion
was the one that was too aggressive because it was anonymous.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setUpSQLiteDatabaseTrackerClient]):
- 2:37 PM Changeset in webkit [218845] by
-
- 14 edits1 add in trunk
Function constructor needs to follow the spec and validate parameters and body independently
https://bugs.webkit.org/show_bug.cgi?id=173303
<rdar://problem/32732526>
Reviewed by Keith Miller.
JSTests:
- ChakraCore/test/Function/FuncBodyES5.baseline-jsc:
- stress/function-constructor-semantics.js: Added.
(assert):
(hasSyntaxError):
(foo):
(async.foo):
(testError):
(testOK.toString):
(toString):
LayoutTests/imported/w3c:
- web-platform-tests/html/webappapis/scripting/events/inline-event-handler-ordering-expected.txt:
- web-platform-tests/html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-late-expected.txt:
- web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-attribute-expected.txt:
- web-platform-tests/html/webappapis/scripting/processing-model-2/compile-error-in-body-onerror-expected.txt:
Source/JavaScriptCore:
The Function constructor must check the arguments and body strings
independently for syntax errors. People rely on this specified behavior
to verify that a particular string is a valid function body. We used
to check these things strings concatenated together, instead of
independently. For example, this used to be valid:Function("/*", "*/){").
However, we should throw a syntax error here since "(/*)" is not a valid
parameter list, and "*/){" is not a valid body.
To implement the specified behavior, we check the syntax independently of
both the body and the parameter list. To check that the parameter list has
valid syntax, we check that it is valid if in a function with an empty body.
To check that the body has valid syntax, we check it is valid in a function
with an empty parameter list.
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
LayoutTests:
- fast/dom/attribute-event-listener-errors-expected.txt:
- fast/events/attribute-listener-deletion-crash-expected.txt:
- fast/events/window-onerror-syntax-error-in-attr-expected.txt:
- js/dom/invalid-syntax-for-function-expected.txt:
- 2:35 PM Changeset in webkit [218844] by
-
- 4 edits in trunk/Source/WebCore
Using public logging for WebRTC release logging
https://bugs.webkit.org/show_bug.cgi?id=173881
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-27
Reviewed by Eric Carlson.
No change of behavior.
- Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createOfferFailed):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::createAnswerFailed):
(WebCore::PeerConnectionBackend::setLocalDescriptionFailed):
(WebCore::PeerConnectionBackend::setRemoteDescriptionFailed):
(WebCore::PeerConnectionBackend::addIceCandidateFailed):
(WebCore::PeerConnectionBackend::newICECandidate):
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
- 2:30 PM Changeset in webkit [218843] by
-
- 16 edits1 copy1 add in trunk
[PAL] Add symbol export macros for PAL
https://bugs.webkit.org/show_bug.cgi?id=171519
Reviewed by Konstantin Tokarev.
Source/WebCore:
No new tests. No change in behavior.
- CMakeLists.txt:
- config.h:
- platform/PlatformExportMacros.h:
Source/WebCore/PAL:
No new tests. No change in behavior.
- Configurations/CopyPALHeaders.xcconfig: Added.
- PAL.xcodeproj/project.pbxproj:
- config.h:
- pal/ExportMacros.h: Copied from Source/WebCore/platform/PlatformExportMacros.h.
- pal/PlatformWin.cmake:
- pal/crypto/CryptoDigest.h:
Source/WebKit2:
- config.h:
Tools:
- DumpRenderTree/config.h:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/config.h:
- WebKitTestRunner/config.h:
- 2:23 PM Changeset in webkit [218842] by
-
- 2 edits in trunk/Source/WebKit2
ProcessLauncherMac could leak a xpc connection when the process had failed to launch
https://bugs.webkit.org/show_bug.cgi?id=173865
Reviewed by Antti Koivisto.
Explicitly cancel the XPC connection even When the process launch had failed to avoid a leak.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- 2:10 PM Changeset in webkit [218841] by
-
- 30 edits4 adds in trunk
Resource Load Statistics: Add telemetry
https://bugs.webkit.org/show_bug.cgi?id=173499
<rdar://problem/32826094>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/loading/resourceLoadStatistics/telemetry-generation.html
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::fireTelemetryHandler):
Test infrastructure.
- loader/ResourceLoadObserver.h:
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::setFireTelemetryCallback):
(WebCore::ResourceLoadStatisticsStore::fireTelemetryHandler):
Test infrastructure.
(WebCore::ResourceLoadStatisticsStore::sortedPrevalentResourceTelemetry):
Convenience function for telemetry.
- loader/ResourceLoadStatisticsStore.h:
Added struct WebCore::PrevalentResourceTelemetry.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey):
Added.
- page/DiagnosticLoggingKeys.h:
Source/WebKit2:
- PlatformGTK.cmake:
Added UIProcess/WebResourceLoadStatisticsTelemetry.cpp
- PlatformMac.cmake:
Added UIProcess/WebResourceLoadStatisticsTelemetry.cpp
- PlatformWPE.cmake:
Added UIProcess/WebResourceLoadStatisticsTelemetry.cpp
- UIProcess/API/C/WKResourceLoadStatisticsManager.cpp:
(WKResourceLoadStatisticsManagerFireTelemetryHandler):
(WKResourceLoadStatisticsManagerSetNotifyPagesWhenTelemetryWasCaptured):
Test infrastructure.
- UIProcess/API/C/WKResourceLoadStatisticsManager.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::notifyPageStatisticsTelemetryFinished):
Test infrastructure.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebResourceLoadStatisticsManager.cpp:
(WebKit::WebResourceLoadStatisticsManager::fireTelemetryHandler):
(WebKit::WebResourceLoadStatisticsManager::setNotifyPagesWhenTelemetryWasCaptured):
(WebKit::WebResourceLoadStatisticsManager::resetToConsistentState):
Test infrastructure.
- UIProcess/WebResourceLoadStatisticsManager.h:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
Configures a timer for telemetry capture. Fires 5 seconds after launch
and then every 24 hours.
(WebKit::WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned):
Variable renamed notifyPages -> notifyPagesWhenDataRecordsWereScanned.
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
Variable renamed notifyPages -> notifyPagesWhenDataRecordsWereScanned.
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):
Variable renamed notifyPages -> notifyPagesWhenDataRecordsWereScanned.
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
Variable renamed notifyPages -> notifyPagesWhenDataRecordsWereScanned.
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
Variable renamed notifyPages -> notifyPagesWhenDataRecordsWereScanned.
(WebKit::WebResourceLoadStatisticsStore::telemetryTimerFired):
Calls WebResourceLoadStatisticsTelemetry::calculateAndSubmit().
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/WebResourceLoadStatisticsTelemetry.cpp: Added.
(WebKit::numberOfResourcesWithUserInteraction):
(WebKit::median):
(WebKit::nonEphemeralWebPageProxy):
(WebKit::submitTopList):
(WebKit::submitTopLists):
(WebKit::notifyPages):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):
(WebKit::WebResourceLoadStatisticsTelemetry::setNotifyPagesWhenTelemetryWasCaptured):
- UIProcess/WebResourceLoadStatisticsTelemetry.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
Tools:
Adds three new testRunner functions:
- installStatisticsDidRunTelemetryCallback()
- statisticsFireTelemetryHandler()
- setStatisticsNotifyPagesWhenTelemetryWasCaptured()
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::didReceiveMessageToPage):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
(WTR::TestRunner::statisticsDidRunTelemetryCallback):
(WTR::TestRunner::statisticsFireTelemetryHandler):
(WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::statisticsFireTelemetryHandler):
(WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
LayoutTests:
- http/tests/loading/resourceLoadStatistics/telemetry-generation-expected.txt: Added.
- http/tests/loading/resourceLoadStatistics/telemetry-generation.html: Added.
- platform/wk2/TestExpectations:
Enabled here since ResourceLoadStatistics is WK2-only.
- 2:06 PM Changeset in webkit [218840] by
-
- 13 edits in trunk
Add missing includes to fix compilation error on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=172919
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2017-06-27
Reviewed by Mark Lam.
Source/JavaScriptCore:
- API/JSRemoteInspector.h:
- API/tests/GlobalContextWithFinalizerTest.cpp:
- API/tests/TypedArrayCTest.cpp:
Source/WebCore:
No new tests needed.
- crypto/gcrypt/CryptoKeyECGCrypt.cpp:
- platform/audio/ReverbAccumulationBuffer.cpp:
Source/WebKit2:
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/ProcessAssertion.h:
Tools:
- ImageDiff/cairo/PlatformImageCairo.cpp:
- 2:01 PM Changeset in webkit [218839] by
-
- 7 edits1 move3 adds in trunk/Source/WebInspectorUI
Web Inspector: no discoverable way to dismiss the split console
https://bugs.webkit.org/show_bug.cgi?id=167034
<rdar://problem/30023436>
Reviewed by Devin Rousso.
This patch adds an Xcode-style toggle button to the left of the
split console navigation bar. Additionally, the split console code
has been broken out into it's own class to reduce the clutter in
Main.js/css, and simplify future console maintenance.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Main.js:
(WebInspector.loaded):
Replace the "split" ContentBrowser with a new ConsoleDrawer class,
which encapsulates the drawer height setting and resize behavior.
(WebInspector.contentLoaded):
The console drawer manages its own height.
- UserInterface/Images/HideConsoleDrawer.svg: Added.
- UserInterface/Images/ShowConsoleDrawer.svg: Added.
Console drawer toggle button images. Styled after corresponding Xcode button.
- UserInterface/Main.html:
- UserInterface/Views/ConsoleDrawer.css: Added.
Moved old #split-content-browser styles over from Main.css.
(.console-drawer):
(.console-drawer > .navigation-bar):
(.console-drawer > .navigation-bar > .item.button:not(.clear-log)):
Make button spacing less cramped.
(.console-drawer > .navigation-bar > .item:not(.flexible-space)):
(.console-drawer > .navigation-bar > :matches(.item.button, .log-scope-bar)):
(.console-drawer > .navigation-bar > .item > .glyph,):
- UserInterface/Views/ConsoleDrawer.js: Added.
New class responsible for console drawer expand / collapse and resizer
dragging, which was previously part of Main.js. The console drawer toolbar
now has a toggle button, debugging controls, and a call frames path item.
The "Show Console Tab" button has been removed.
(WebInspector.ConsoleDrawer):
(WebInspector.ConsoleDrawer.prototype.get collapsed):
(WebInspector.ConsoleDrawer.prototype.set collapsed):
(WebInspector.ConsoleDrawer.prototype.get height):
(WebInspector.ConsoleDrawer.prototype.shown):
(WebInspector.ConsoleDrawer.prototype.layout):
(WebInspector.ConsoleDrawer.prototype._consoleResizerMouseDown.dockedResizerDrag):
(WebInspector.ConsoleDrawer.prototype._consoleResizerMouseDown.dockedResizerDragEnd):
(WebInspector.ConsoleDrawer.prototype._consoleResizerMouseDown):
(WebInspector.ConsoleDrawer.prototype._restoreDrawerHeight):
(WebInspector.ConsoleDrawer.prototype._updateDrawerHeight):
(WebInspector.ConsoleDrawer.prototype._selectedTabContentViewDidChange):
When switching to a tab that doesn't support showing the console drawer,
hide it without altering the collapsed state.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype.get navigationItems):
- UserInterface/Views/Main.css:
Renamed #split-content-browser to #console-drawer, and moved related
styles to ConsoleDrawer.css.
(#split-content-browser): Deleted.
(#split-content-browser > .navigation-bar): Deleted.
(#split-content-browser > .navigation-bar :matches(.find-banner, .find-banner + .divider)): Deleted.
(#split-content-browser > .navigation-bar .item): Deleted.
(#split-content-browser > .navigation-bar .item:not(.flexible-space)): Deleted.
(#split-content-browser .hierarchical-path-component.log-icon .icon): Deleted.
(#split-content-browser .hierarchical-path-component.log-icon .title): Deleted.
(#split-content-browser .hierarchical-path-component.log-icon select): Deleted.
(#split-content-browser > .navigation-bar > :matches(.hierarchical-path, .log-scope-bar)): Deleted.
(#split-content-browser > .navigation-bar > .log-scope-bar > li): Deleted.
- UserInterface/Views/QuickConsole.js:
(WebInspector.QuickConsole):
(WebInspector.QuickConsole.prototype._toggleOrFocus):
(WebInspector.QuickConsole.prototype._updateStyles):
Update top border style in response to change in selected TabBrowser
tab or the console drawer collapsed state.
(WebInspector.QuickConsole.prototype.consoleLogVisibilityChanged): Deleted.
(WebInspector.QuickConsole.prototype.set keyboardShortcutDisabled): Deleted.
- 12:52 PM Changeset in webkit [218838] by
-
- 3 edits in trunk/Source/WebCore
Add RenderEmbeddedObject::getReplacementTextGeometry helper.
https://bugs.webkit.org/show_bug.cgi?id=173847
Reviewed by Simon Fraser.
...and remove getReplacementTextGeometry's redundant return value.
No change in functionality.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
(WebCore::RenderEmbeddedObject::unavailablePluginIndicatorBounds):
(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):
- rendering/RenderEmbeddedObject.h:
- 12:11 PM Changeset in webkit [218837] by
-
- 31 edits in trunk/Source
Refactor drag start codepaths to plumb a DragItem to client layers
https://bugs.webkit.org/show_bug.cgi?id=173832
Work towards <rdar://problem/32236827>
Reviewed by Ryosuke Niwa and Tim Horton.
Source/WebCore:
Refactor drag start logic in WebCore to set up a DragItem and propagate it to WebDragClient. No change in behavior.
- loader/EmptyClients.cpp:
- page/DragClient.h:
- page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
Refactor to pass along a DragItem. Also, remove unused drag image anchor computation.
- page/DragController.h:
- platform/DragImage.h:
- platform/DragItem.h:
Add additional information needed to begin a drag on iOS.
(WebCore::DragItem::encode):
(WebCore::DragItem::decode):
Add IPC serialization/deserialization support for DragItem.
- platform/PasteboardWriterData.cpp:
(WebCore::PasteboardWriterData::isEmpty):
- platform/PasteboardWriterData.h:
Source/WebKit/mac:
Refactor code used to start a drag in WebKit1 to plumb a single DragItem from DragController to the client layer
in WebDragClient that contains all the information needed to begin a drag. Also renames _setDataInteractionData:
to _startDrag: to match logic used to start a drag on other platforms.
No behavior change -- the same information should be propagated to AppKit and UIKit when beginning a drag, only
through the DragItem struct.
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
(WebDragClient::dragSourceActionMaskForPoint):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::beginDrag):
- WebView/WebView.mm:
(-[WebView _startDrag:]):
(-[WebView _setDataInteractionData:textIndicator:atClientPosition:anchorPoint:action:]): Deleted.
- WebView/WebViewInternal.h:
Source/WebKit/win:
Adjust for changes to WebDragClient::startDrag by pulling information out of DragItem.
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::startDrag):
- WebCoreSupport/WebDragClient.h:
Source/WebKit2:
Add support for serializing a DragItem over IPC. This encodes and decodes all members of DragItem except for the
PasteboardWriterData and the DragImage's image. The DragItem is sent over to the UI process in
WebDragClient::startDrag via the WebPageProxy::startDrag IPC message (renamed from WebPageProxy::setDragImage)
which now takes a DragItem.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::setDragImage): Deleted.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Rename SetDragImage to StartDrag and refactor to receive only a DragItem and shareable bitmap handle.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::startDrag):
(WebKit::PageClientImpl::startDataInteractionWithImage): Deleted.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _startDrag:item:]):
(-[WKContentView _startDataInteractionWithImage:withIndicatorData:atClientPosition:anchorPoint:action:]): Deleted.
Rename startDataInteractionWithImage to startDrag.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::startDrag):
(WebKit::WebPageProxy::setDragImage): Deleted.
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
- 10:43 AM Changeset in webkit [218836] by
-
- 15 edits3 adds in trunk
Web Inspector: Crash generating object preview for ArrayIterator
https://bugs.webkit.org/show_bug.cgi?id=173754
<rdar://problem/32859012>
Reviewed by Saam Barati.
Source/JavaScriptCore:
When Inspector generates an object preview for an ArrayIterator instance it made
a "clone" of the original ArrayIterator instance by constructing a new object with
the instance's structure. However, user code could have modified that instance's
structure, such as adding / removing properties. Thereturnproperty had special
meaning, and our clone did not fill that slot. This approach is brittle in that
we weren't satisfying the expectations of an object with a particular Structure,
and the original goal of having Web Inspector peek values of built-in Iterators
was to avoid observable behavior.
This tightens Web Inspector's Iterator preview to only peek values if the
Iterators would actually be non-observable. It also builds an ArrayIterator
clone like a regular object construction.
- inspector/JSInjectedScriptHost.cpp:
(Inspector::cloneArrayIteratorObject):
Build up the Object from scratch with a new ArrayIterator prototype.
(Inspector::JSInjectedScriptHost::iteratorEntries):
Only clone and peek iterators if it would not be observable.
Also update iteration to be more in line with IterationOperations, such as when
we call iteratorClose.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::stringIteratorProtocolWatchpoint):
- runtime/JSGlobalObjectInlines.h:
(JSC::JSGlobalObject::isStringPrototypeIteratorProtocolFastAndNonObservable):
Add a StringIterator WatchPoint in line with the Array/Map/Set iterator watchpoints.
- runtime/JSMap.cpp:
(JSC::JSMap::isIteratorProtocolFastAndNonObservable):
(JSC::JSMap::canCloneFastAndNonObservable):
- runtime/JSMap.h:
- runtime/JSSet.cpp:
(JSC::JSSet::isIteratorProtocolFastAndNonObservable):
(JSC::JSSet::canCloneFastAndNonObservable):
- runtime/JSSet.h:
Promote isIteratorProtocolFastAndNonObservable to a method.
- runtime/JSObject.cpp:
(JSC::canDoFastPutDirectIndex):
- runtime/JSTypeInfo.h:
(JSC::TypeInfo::isArgumentsType):
Helper to detect if an Object is an Arguments type.
LayoutTests:
- platform/mac/inspector/model/remote-object-expected.txt:
- inspector/model/remote-object-expected.txt:
- inspector/model/remote-object.html:
Test generating a preview for an ArrayIterator that has had a
returnproperty added to it.
- inspector/model/remote-object-mutated-iterators-expected.txt: Added.
- inspector/model/remote-object-mutated-iterators.html: Added.
Test generating a preview for different iterators after the IteratorPrototypes have been mutated.
- inspector/model/resources/remote-object-utilities.js: Added.
(runInBrowserTest):
(TestPage.registerInitializer):
(TestPage.registerInitializer.checkComplete):
(TestPage.registerInitializer.window.runSteps):
Share code for remote-object dump tests.
- 8:59 AM Changeset in webkit [218835] by
-
- 14 edits in trunk
Some tests to verify forbidden frame navigation time out
https://bugs.webkit.org/show_bug.cgi?id=173657
Patch by Frederic Wang <fwang@igalia.com> on 2017-06-27
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-2-expected.txt: Update the text expectation to PASS.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture-expected.txt: Ditto.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_ancestor-1-expected.txt: Ditto.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3-expected.txt: Add the security error until bug 173162 is fixed.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3-expected.txt: Ditto.
Source/WebCore:
Currently some tests try and perform a forbidden frame navigation and verify the
corresponding console error. However, WebKit does not raise any exception for such error so
the tests have to wait until the timeout limit to complete, which makes execution slow.
This patch modifies the setters of window.location for which such error may happen in order
to raise an exception so the tests behave as expected.
No new tests, already covered by existing tests.
- page/Location.cpp: Adjust Location::setLocation to return a security exception and pass it
to the callers.
(WebCore::Location::setHref): Adjust function to possibly return an exception.
(WebCore::Location::setProtocol): Ditto.
(WebCore::Location::setHost): Ditto.
(WebCore::Location::setHostname): Ditto.
(WebCore::Location::setPort): Ditto.
(WebCore::Location::setPathname): Ditto.
(WebCore::Location::setSearch): Ditto.
(WebCore::Location::setHash): Ditto.
(WebCore::Location::assign): Ditto.
(WebCore::Location::setLocation): FrameLoader::findFrameForNavigation is really only used
to verify whether navigating m_frame is permitted so it is more simple and clearer to do it
directly. When navigation is not permitted, this function now raises a security exception.
- page/Location.h: Modify some setters to return an ExceptionOr<void>.
- page/Location.idl: Allow some setters to raise an exception.
LayoutTests:
- fast/frames/sandboxed-iframe-navigation-top-denied-expected.txt: Add the security error.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html: Adjust
the test to catch and dump the exception and complete immediately.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child-expected.txt:
Add the dumped security error exception.
- 7:49 AM Changeset in webkit [218834] by
-
- 2 edits in trunk/Source/WebKit2
[iOS DnD] [WK2] WKWebView does not handle drag sessions that exit and re-enter
https://bugs.webkit.org/show_bug.cgi?id=173856
<rdar://problem/32957100>
Reviewed by Ryosuke Niwa.
Upon exiting a WKContentView, the dropSession tracked by _dataInteractionState is not cleared out. If the drag
session re-enters the WKWebView, a _different_ UIDropSession is sent to the drop delegate, causing us to bail
from handling the session altogether in -dropInteraction:canHandleSession:. To fix this, we need to clear out
the dropSession when the drag session exits the view.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView dropInteraction:sessionDidExit:]):
- 7:47 AM Changeset in webkit [218833] by
-
- 2 edits in trunk/LayoutTests
LayoutTest webrtc/datachannel/multiple-connections.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=173853
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-27
Reviewed by Eric Carlson.
- webrtc/datachannel/multiple-connections.html:
- 4:13 AM WebKitGTK/2.16.x edited by
- (diff)
Jun 26, 2017:
- 11:41 PM Changeset in webkit [218832] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Layout Test webrtc/video.html issues "stack smashing detected"
https://bugs.webkit.org/show_bug.cgi?id=173862
Patch by Fujii Hironori <Fujii Hironori> on 2017-06-26
Reviewed by Carlos Garcia Campos.
Tests: webrtc/video.html
Passing a bool variable to g_object_get causes out-of-bound write.
gboolean should be used, which is 4 bytes while bool is one byte.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::muted): Use gboolean instead of bool.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::trackEnded): Ditto.
- 11:12 PM Changeset in webkit [218831] by
-
- 1 copy in releases/WebKitGTK/webkit-2.16.5
WebKitGTK+ 2.16.5
- 11:11 PM Changeset in webkit [218830] by
-
- 4 edits in releases/WebKitGTK/webkit-2.16
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.5 release.
.:
- Source/cmake/OptionsGTK.cmake:
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.16.5.
- 11:01 PM Changeset in webkit [218829] by
-
- 5 edits in releases/WebKitGTK/webkit-2.16
Merge r218798 - Unreviewed, rolling out r215190.
Broke product select element on GNOME Bugzilla
Reverted changeset:
"[GTK] Misplaced right click menu on web page due to
deprecated gtk_menu_popup()"
https://bugs.webkit.org/show_bug.cgi?id=170553
http://trac.webkit.org/changeset/215190
- 10:49 PM Changeset in webkit [218828] by
-
- 3 edits1 add in trunk
RegExpPrototype.js builtin uses for-of iteration which is almost certainly incorrect
https://bugs.webkit.org/show_bug.cgi?id=173740
Reviewed by Mark Lam.
JSTests:
- stress/regexp-prototype-replace-builtin-should-not-use-for-of.js: Added.
(Array.prototype.Symbol.iterator):
Source/JavaScriptCore:
The builtin was using for-of iteration to iterate over an internal
list in its algorithm. For-of iteration is observable via user code
in the global object, so this approach was wrong as it would break if
a user changed the Array iteration protocol in some way.
- builtins/RegExpPrototype.js:
(replace):
- 8:33 PM Changeset in webkit [218827] by
-
- 10 edits in trunk/Source
WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains() is inefficient
https://bugs.webkit.org/show_bug.cgi?id=173850
Reviewed by Ryosuke Niwa.
Source/WebCore:
- loader/ResourceLoadStatisticsStore.cpp:
(WebCore::ResourceLoadStatisticsStore::updateStatisticsForRemovedDataRecords):
- loader/ResourceLoadStatisticsStore.h:
Source/WebKit2:
Update WebsiteDataRecord::matchesTopPrivatelyControlledDomain() to rely on
SecurityOriginData::host rather than SecurityOriginData::securityOrigin()->host().
SecurityOriginData::securityOrigin() is expensive and it seems unnecessary to call
it here since we already have the host.
Also update WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains() to return
domains as a HashSet rather than a Vector to avoid having duplicate domains.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
- UIProcess/WebsiteData/WebsiteDataRecord.cpp:
(WebKit::WebsiteDataRecord::matchesTopPrivatelyControlledDomain):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains):
(WebKit::WebsiteDataStore::removeDataForTopPrivatelyControlledDomains):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 8:28 PM Changeset in webkit [218826] by
-
- 9 edits2 adds in trunk
REGRESSION (AsyncImageDecoding): A tab with the WWDC keynote paused is killed for using excessive power (Image thrashing)
https://bugs.webkit.org/show_bug.cgi?id=173804
<rdar://problem/32623745>
Reviewed by Simon Fraser.
Source/WebCore:
When under memory pressure MemoryCache::singleton().pruneLiveResources(true) is called inFrameView::didPaintContents()
after top level paint. We end up decoding and pruning bitmaps repeatedly for each tile, which is not great.
Situation gets worse with async decoding. Painting now doesn’t actually decode the image, it just starts the decoding.
When it completes we trigger another paint to get the bits to the tiles. The paint for the first tile then calls
pruneLiveResources and loses the bitmap and the second tile triggers another round of async decoding. We have code
that prevents pruning of visible images but non-visible images in tiling area can hit this bug easily.
Test: fast/images/low-memory-decode.html
- page/FrameView.cpp:
(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::didPaintContents):
Eliminate synchronous pruning during painting. This is an obsolete mechanism from early iOS times.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::imageFrameAvailableAtIndex):
(WebCore::BitmapImage::decodeCountForTesting):
Testing support.
- platform/graphics/BitmapImage.h:
- testing/Internals.cpp:
(WebCore::Internals::imageDecodeCount):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/images/low-memory-decode-expected.txt: Added.
- fast/images/low-memory-decode.html: Added.
- 5:26 PM Changeset in webkit [218825] by
-
- 2 edits in trunk/LayoutTests
Marked media/media-source/media-source-paint-to-canvas.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173565
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:47 PM Changeset in webkit [218824] by
-
- 2 edits in trunk/LayoutTests
Marked animations/play-state-suspend.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173726
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 4:39 PM Changeset in webkit [218823] by
-
- 2 edits in trunk/JSTests
Skip a test on 32-bit platforms since we run out of address space.
Rubber stamped by Mark Lam.
- stress/dont-reserve-huge-capacity-lexer.js:
- 3:36 PM Changeset in webkit [218822] by
-
- 4 edits in trunk/Source/WebKit2
Invalidate WebVideoFullscreenManager when WebPage is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=173835
rdar://problem/32969161
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-06-26
Reviewed by Jer Noble.
WebVideoFullscreenManager has a pointer to WebPage, and even null checks it in a few places,
but the only place it is nulled out is in the destructor. This allows a dangling reference.
This changes invalidates that reference when WebPage is destructed and adds nullchecks
or asserts throughout WebVideoFullscreenManager as appropriate.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::~WebPage):
- WebProcess/cocoa/WebVideoFullscreenManager.h:
(WebKit::WebVideoFullscreenManager::invalidate):
- WebProcess/cocoa/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::~WebVideoFullscreenManager):
(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement):
(WebKit::WebVideoFullscreenManager::exitVideoFullscreenForVideoElement):
(WebKit::WebVideoFullscreenManager::exitVideoFullscreenToModeWithoutAnimation):
(WebKit::WebVideoFullscreenManager::hasVideoChanged):
(WebKit::WebVideoFullscreenManager::videoDimensionsChanged):
(WebKit::WebVideoFullscreenManager::didSetupFullscreen):
(WebKit::WebVideoFullscreenManager::didEnterFullscreen):
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen):
(WebKit::WebVideoFullscreenManager::fullscreenMayReturnToInline):
- 2:09 PM Changeset in webkit [218821] by
-
- 2 edits in trunk/Source/WebKit2
Disable diagnostic logging in ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=173849
<rdar://problem/32987341>
Reviewed by Geoffrey Garen.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setDiagnosticLoggingClient):
Construct a dummy logging client if the page's session is ephemeral.
(WebKit::WebPageProxy::logDiagnosticMessage):
(WebKit::WebPageProxy::logDiagnosticMessageWithResult):
(WebKit::WebPageProxy::logDiagnosticMessageWithValue):
(WebKit::WebPageProxy::logDiagnosticMessageWithEnhancedPrivacy):
Slight cleanup to make the code look a bit safer.
- 1:17 PM Changeset in webkit [218820] by
-
- 2 edits in trunk/Source/JavaScriptCore
Renamed DumpRegisterFunctor to DumpReturnVirtualPCFunctor.
https://bugs.webkit.org/show_bug.cgi?id=173848
Reviewed by JF Bastien.
This functor only dumps the return VirtualPC.
- interpreter/Interpreter.cpp:
(JSC::DumpReturnVirtualPCFunctor::DumpReturnVirtualPCFunctor):
(JSC::Interpreter::dumpRegisters):
(JSC::DumpRegisterFunctor::DumpRegisterFunctor): Deleted.
(JSC::DumpRegisterFunctor::operator()): Deleted.
- 12:34 PM Changeset in webkit [218819] by
-
- 3 edits1 add in trunk
Crash in JSC::Lexer<unsigned char>::setCode
https://bugs.webkit.org/show_bug.cgi?id=172754
Reviewed by Mark Lam.
JSTests:
- stress/dont-reserve-huge-capacity-lexer.js: Added.
(catch):
Source/JavaScriptCore:
The lexer was asking one of its buffers to reserve initial space that
was O(text size in bytes). For large sources, this would end up causing
the vector to overflow and crash. This patch changes this code be like
the Lexer's other buffers and to only reserve a small starting buffer.
- parser/Lexer.cpp:
(JSC::Lexer<T>::setCode):
- 12:13 PM Changeset in webkit [218818] by
-
- 2 edits in trunk/Source/WebCore
ImageFrameCache::startAsyncDecodingQueue() unsafely passes Strings across threads
https://bugs.webkit.org/show_bug.cgi?id=173842
Reviewed by Simon Fraser.
The URL string was passed across thread without isolated copy.
- platform/graphics/ImageFrameCache.cpp:
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
- 11:51 AM Changeset in webkit [218817] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r218783.
Causing accessibility/mac/setting-attributes-is-
asynchronous.html to crash consistently on mac-wk2 Debug
Reverted changeset:
"AX: Cannot call setValue() on contenteditable or ARIA text
controls"
https://bugs.webkit.org/show_bug.cgi?id=173520
http://trac.webkit.org/changeset/218783
- 11:19 AM Changeset in webkit [218816] by
-
- 39 edits in trunk
[WTF] Drop Thread::create(obsolete things) API since we can use lambda
https://bugs.webkit.org/show_bug.cgi?id=173825
Reviewed by Saam Barati.
Source/JavaScriptCore:
- jsc.cpp:
(startTimeoutThreadIfNeeded):
(timeoutThreadMain): Deleted.
Source/WebCore:
No behavior change.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::databaseThreadEntry): Deleted.
- Modules/indexeddb/server/IDBServer.h:
- Modules/webaudio/AsyncAudioDecoder.cpp:
(WebCore::AsyncAudioDecoder::AsyncAudioDecoder):
(WebCore::AsyncAudioDecoder::threadEntry): Deleted.
- Modules/webaudio/AsyncAudioDecoder.h:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::startRendering):
(WebCore::OfflineAudioDestinationNode::offlineRenderEntry): Deleted.
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::start):
(WebCore::DatabaseThread::databaseThreadStart): Deleted.
- Modules/webdatabase/DatabaseThread.h:
- bindings/js/GCController.cpp:
(WebCore::collect):
(WebCore::GCController::gcTimerFired):
(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::open):
(WebCore::IconDatabase::iconDatabaseSyncThreadStart): Deleted.
- loader/icon/IconDatabase.h:
- page/ResourceUsageThread.cpp:
(WebCore::ResourceUsageThread::createThreadIfNeeded):
(WebCore::ResourceUsageThread::threadCallback): Deleted.
- page/ResourceUsageThread.h:
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::threadCallback): Deleted.
(WebCore::ScrollingThread::threadBody): Deleted.
- page/scrolling/ScrollingThread.h:
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::loadAsynchronously):
(WebCore::databaseLoaderEntry): Deleted.
- platform/audio/HRTFDatabaseLoader.h:
- platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::backgroundThreadEntry): Deleted.
- platform/audio/ReverbConvolver.h:
(WebCore::ReverbConvolver::useBackgroundThreads):
- platform/network/cf/LoaderRunLoopCF.cpp:
(WebCore::loaderRunLoop):
(WebCore::runLoaderThread): Deleted.
- platform/network/curl/CurlManager.cpp:
(WebCore::CurlManager::startThreadIfNeeded):
(WebCore::CurlManager::workerThread):
- platform/network/curl/CurlManager.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThreadStart): Deleted.
- workers/WorkerThread.h:
Source/WebKit:
- Storage/StorageThread.cpp:
(WebCore::StorageThread::start):
(WebCore::StorageThread::threadEntryPointCallback): Deleted.
- Storage/StorageThread.h:
Source/WTF:
Thread::create(ThreadFunction, void* data, const char* name) is a bit old API.
Since we have C++ lambda, the above API is simply unnecessary. And C++ lambda
based one is better since the above API needs casting data to and from void*.
- wtf/Function.h:
Avoid ambiguity.
- wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ThreadPrivate::tryLockFor):
(WTF::ParallelEnvironment::ThreadPrivate::workerThread): Deleted.
- wtf/ParallelJobsGeneric.h:
- wtf/Threading.cpp:
- wtf/ThreadingWin.cpp:
(WTF::createThread):
Tools:
- DumpRenderTree/JavaScriptThreading.cpp:
(runJavaScriptThread):
(startJavaScriptThreads):
- DumpRenderTree/mac/DumpRenderTree.mm:
(runThread):
(runPthread):
(testThreadIdentifierMap):
- 11:02 AM Changeset in webkit [218815] by
-
- 3 edits in trunk/Tools
[TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
<https://webkit.org/b/173837>
Reviewed by Geoffrey Garen.
The clang static analyzer can't reason about objects that are
assigned to a delegate as +1 retained, and then released
later in a different method when the delegate is cleared.
Instead, use a common idiom where the object setting the
delegate retains it as an instance variable on initialization.
Then the same object clears the delegate and releases its
instance variable during teardown.
Also add EXPECT_TRUE() tests to make sure the delegate objects
match before teardown.
- TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
(TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
(TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
- 11:01 AM Changeset in webkit [218814] by
-
- 2 edits in trunk/Source/WebKit2
[GCrypt] Properly initialize libgcrypt before using it
https://bugs.webkit.org/show_bug.cgi?id=173589
Reviewed by Michael Catanzaro.
Initialize libgcrypt in the Unix-specific main() entrypoint. This is early enough
to ensure no other libgcrypt API function is invoked and to also ensure this is
done in a thread-safe manner.
Initialization is initiated through the gcry_check_version() call. 16 kilobytes of
secure memory is pre-allocated before we mark the initialization as complete, as
recommended by the libgcrypt documentation.
- WebProcess/EntryPoint/unix/WebProcessMain.cpp:
(main):
- 11:00 AM Changeset in webkit [218813] by
-
- 2 edits in trunk/Source/WebKit2
When Mission Control closes fullscreen window, allow media element to update its state.
https://bugs.webkit.org/show_bug.cgi?id=173671
rdar://problem/32892671
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-06-26
Reviewed by Eric Carlson.
When Mission Control closes element fullscreen without an animation, we need to notify the
media element that fullscreen has exited.
Without this change, the page still behaves like the element is in fullscreen.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
- 10:54 AM Changeset in webkit [218812] by
-
- 2 edits in trunk/Source/WebKit2
[iOS DnD] [WK2] Beginning a drag session should prevent clicking via long press
https://bugs.webkit.org/show_bug.cgi?id=173838
Reviewed by Tim Horton.
After r218579, WebKit no longer attempts to replace out-of-the-box UIKit long-press/drag lift disambiguation by
firing events immediately. However, this means that dragging will defer the highlight long press gesture
recognizer until dragging ends rather than cancel it immediately, which causes WKContentView to dispatch a
synthetic click immediately upon lift. To fix this, we should bail out of the highlight long press gesture when
beginning a drag.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _dragInteraction:prepareForSession:completion:]):
- 10:52 AM Changeset in webkit [218811] by
-
- 2 edits in trunk/LayoutTests
Make webrtc/video-replace-track-to-null.html more robust
https://bugs.webkit.org/show_bug.cgi?id=173834
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-26
Reviewed by Eric Carlson.
- webrtc/video-replace-track-to-null.html:
- 10:48 AM Changeset in webkit [218810] by
-
- 2 edits in trunk/Tools
[TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
<https://webkit.org/b/173836>
Reviewed by Brady Eidson.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
(-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
adoptNS() to fix the leak. Also use auto/adoptNS() for other
objects in this test.
- 9:45 AM Changeset in webkit [218809] by
-
- 14 edits in trunk
[ATK] Add support for aria-details and aria-errormessage
https://bugs.webkit.org/show_bug.cgi?id=172588
Reviewed by Chris Fleizach.
Source/WebCore:
Add methods to retrieve elements referenced by or referencing the new
aria-details and aria-errormessage attributes. Include aria-details and
aria-errormessage in AccessibilityObject::supportsARIAAttributes() to ensure
elements with these attributes will be included in the accessibility tree.
New test cases added to accessibility/gtk/relation-types.html.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAAttributes):
(WebCore::AccessibilityObject::ariaDetailsElements):
(WebCore::AccessibilityObject::ariaDetailsReferencingElements):
(WebCore::AccessibilityObject::ariaErrorMessageElements):
(WebCore::AccessibilityObject::ariaErrorMessageReferencingElements):
- accessibility/AccessibilityObject.h:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkRelationSetFromCoreObject):
- html/HTMLAttributeNames.in:
Tools:
Add additional methods to test ARIA properties which are exposed via
AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
to versions which support the details and error-message relation types.
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
(WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
(WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
- gtk/jhbuild.modules:
LayoutTests:
Add new test cases to relation-types.html.
- accessibility/gtk/relation-types-expected.txt:
- accessibility/gtk/relation-types.html:
- 7:12 AM Changeset in webkit [218808] by
-
- 1 edit5 adds in trunk/LayoutTests
[WPE][GCrypt] Unreviewed gardening
After r218744, land new expectations for AES-CFB tests.
- platform/wpe/crypto/subtle/aes-cbc-cfb-decrypt-malformed-parameters-expected.txt: Added.
- platform/wpe/crypto/subtle/aes-cbc-cfb-encrypt-malformed-parameters-expected.txt: Added.
- platform/wpe/crypto/subtle/aes-export-key-malformed-parameters-expected.txt: Added.
- platform/wpe/crypto/subtle/aes-generate-key-malformed-parameters-expected.txt: Added.
- platform/wpe/crypto/subtle/aes-import-key-malformed-parameters-expected.txt: Added.
- 2:30 AM Changeset in webkit [218807] by
-
- 2 edits in trunk/Tools
Unreviewed. Add libfii to GTK+ install dependencies script.
- gtk/install-dependencies:
- 2:02 AM Changeset in webkit [218806] by
-
- 2 edits in trunk/LayoutTests
[Win] Update expectations for layout tests.
https://bugs.webkit.org/show_bug.cgi?id=172437
Unreviewed test gardening, update test expectations for failing tests.
- platform/win/TestExpectations:
- 1:47 AM Changeset in webkit [218805] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, add missing header for CLoop
- runtime/SymbolTable.cpp:
- 1:23 AM Changeset in webkit [218804] by
-
- 4 edits in trunk/Source
Unreviewed, add missing header icncludes
Source/JavaScriptCore:
- parser/Lexer.h:
Source/WebKit2:
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
- 1:13 AM Changeset in webkit [218803] by
-
- 50 edits in trunk/Source
Remove excessive headers from WebCore/{Modules,animation,crypto,domjit}
https://bugs.webkit.org/show_bug.cgi?id=173824
Reviewed by Darin Adler.
No new tests needed.
- Modules/credentials/CredentialCreationOptions.h:
- Modules/credentials/PasswordCredential.h:
- Modules/fetch/FetchBody.h:
- Modules/fetch/FetchBodyOwner.h:
- Modules/gamepad/GamepadManager.h:
- Modules/geolocation/Coordinates.h:
- Modules/geolocation/Geoposition.h:
- Modules/indexeddb/IDBActiveDOMObject.h:
- Modules/indexeddb/IDBCursor.h:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseIdentifier.h:
- Modules/indexeddb/IDBObjectStore.cpp:
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/shared/InProcessIDBServer.h:
- Modules/indexeddb/shared/IndexKey.h:
- Modules/mediacontrols/MediaControlsHost.h:
- Modules/mediasession/WebMediaSessionManager.h:
- Modules/mediasource/SourceBufferList.h:
- Modules/mediasource/VideoPlaybackQuality.h:
- Modules/notifications/Notification.h:
- Modules/quota/WorkerNavigatorStorageQuota.h:
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioParamTimeline.h:
- Modules/webaudio/ConvolverNode.cpp:
- Modules/webaudio/MediaStreamAudioSource.h:
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/PeriodicWave.h:
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseTask.h:
- Modules/webdatabase/SQLTransaction.h:
- Modules/webdatabase/SQLTransactionBackend.h:
- Modules/webdatabase/SQLTransactionStateMachine.h:
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- Modules/websockets/WebSocketDeflater.h:
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
- animation/AnimationEffect.h:
- crypto/CryptoKeyPair.h:
- crypto/parameters/CryptoAlgorithmEcdhKeyDeriveParams.h:
- dom/ScriptExecutionContext.h:
- domjit/DOMJITHelpers.h:
- domjit/DOMJITIDLConvert.h:
- domjit/DOMJITIDLType.h:
- 12:57 AM Changeset in webkit [218802] by
-
- 4 edits in trunk/Source
[GTK] Unreviewed, added missing includes to fix debug build
Source/WebCore:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
Source/WebKit2:
- NetworkProcess/NetworkSession.cpp:
Jun 25, 2017:
- 11:51 PM Changeset in webkit [218801] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.16
Merge r215387 - ParseInt intrinsic in DFG backend doesn't properly flush its operands
https://bugs.webkit.org/show_bug.cgi?id=170865
Reviewed by Mark Lam and Geoffrey Garen.
JSTests:
- stress/parse-int-intrinsic-dfg-backend-flush.js: Added.
(assert):
(foo):
Source/JavaScriptCore:
The DFG backend code needed to first call .gpr()/.jsValueRegs()
before calling flushRegisters(), or the input JSValueOperand would
not be flushed.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileParseInt):
- 2:41 PM Changeset in webkit [218800] by
-
- 2 edits in trunk/Source/WTF
initializeThreading() [first] causes WTFCrash due to maxSingleAllocationSize not being initialized
https://bugs.webkit.org/show_bug.cgi?id=173720
Reviewed by Mark Lam.
When using std::numeric_limits<size_t>::max() for global variable's initialization,
it seems that it invokes static constructor to initialize this in VC++.
We avoid this edge case by introducing a workaround using SIZE_MAX here.
When I perform git-grep, there is only one site (this) using std::numeric_limits<>::xxx()
to initialize global variable.
- wtf/FastMalloc.cpp:
- 1:35 PM Changeset in webkit [218799] by
-
- 90 edits in trunk
Remove excessive headers from WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=173822
Reviewed by Tim Horton.
Source/WebCore:
No new tests needed.
- html/ColorInputType.h:
- html/MediaElementSession.h:
- page/SecurityOriginData.cpp:
- platform/CalculationValue.cpp:
- platform/CalculationValue.h:
- platform/ColorChooserClient.h:
- platform/ContentType.h:
- platform/LogMacros.h:
- platform/PODRedBlackTree.h:
- platform/PasteboardStrategy.h:
- platform/PlatformPasteboard.h:
- platform/PopupMenuStyle.h:
- platform/ScrollAnimator.h:
- platform/Theme.h:
- platform/ThreadGlobalData.h:
- platform/animation/AnimationList.h:
- platform/audio/AudioArray.h:
- platform/audio/AudioChannel.h:
- platform/audio/DynamicsCompressor.h:
- platform/audio/DynamicsCompressorKernel.h:
- platform/audio/FFTFrame.h:
- platform/audio/HRTFDatabaseLoader.cpp:
- platform/audio/HRTFDatabaseLoader.h:
- platform/audio/HRTFElevation.h:
- platform/audio/MultiChannelResampler.h:
- platform/audio/PlatformMediaSession.h:
- platform/audio/ReverbConvolver.h:
- platform/audio/ReverbConvolverStage.cpp:
- platform/graphics/ANGLEWebKitBridge.h:
- platform/graphics/BitmapImage.h:
- platform/graphics/CrossfadeGeneratedImage.h:
- platform/graphics/FloatPolygon.h:
- platform/graphics/FloatSizeHash.h:
- platform/graphics/Font.h:
- platform/graphics/FontMetrics.h:
- platform/graphics/FontPlatformData.h:
- platform/graphics/FontRanges.h:
- platform/graphics/FontTaggedSettings.h:
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsContext3DPrivate.h:
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/Image.cpp:
- platform/graphics/ImageFrame.h:
- platform/graphics/ImageFrameCache.h:
- platform/graphics/ImageSource.h:
- platform/graphics/IntRectHash.h:
- platform/graphics/IntSizeHash.h:
- platform/graphics/MediaPlaybackTargetClient.h:
- platform/graphics/Pattern.h:
- platform/graphics/PlatformTimeRanges.h:
- platform/graphics/TextRun.h:
- platform/graphics/TiledBacking.h:
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/filters/FEConvolveMatrix.h:
- platform/graphics/filters/FELighting.h:
- platform/graphics/filters/SourceAlpha.h:
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
- platform/graphics/harfbuzz/HarfBuzzShaper.h:
- platform/graphics/opengl/Extensions3DOpenGL.h:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperBackingStore.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
- platform/graphics/texmap/TextureMapperTile.h:
- platform/graphics/texmap/coordinated/Tile.h:
- platform/graphics/texmap/coordinated/TiledBackingStore.h:
- platform/graphics/transforms/TransformState.h:
- platform/gtk/PasteboardHelper.h:
- platform/gtk/ScrollbarThemeGtk.h:
- platform/image-decoders/ImageDecoder.h:
- platform/network/BlobData.h:
- platform/network/BlobDataFileReference.h:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/SocketStreamHandleClient.h:
- platform/network/soup/ResourceRequest.h:
- platform/network/soup/SocketStreamHandleImpl.h:
- platform/network/soup/SoupNetworkSession.h:
- platform/sql/SQLiteFileSystem.h:
- platform/text/LocaleICU.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
- 12:56 PM Changeset in webkit [218798] by
-
- 5 edits in trunk
Unreviewed, rolling out r215190.
Broke product select element on GNOME Bugzilla
Reverted changeset:
"[GTK] Misplaced right click menu on web page due to
deprecated gtk_menu_popup()"
https://bugs.webkit.org/show_bug.cgi?id=170553
http://trac.webkit.org/changeset/215190
- 11:20 AM Changeset in webkit [218797] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WPE] Unreviewed, fix typo in translatable string
Thanks to Yuri Chornoivan for reporting this typo.
- UIProcess/API/glib/WebKitWebView.cpp:
(webkit_web_view_class_init):
- 11:18 AM Changeset in webkit [218796] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] [l10n] Updated Ukrainian translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=173823
Patch by Yuri Chornoivan <yurchor@ukr.net> on 2017-06-25
Rubber-stamped by Michael Catanzaro.
- uk.po:
- 11:06 AM Changeset in webkit [218795] by
-
- 15 edits2 adds in trunk
Remove use of mock webrtc backend factory at injected bundle reset time
https://bugs.webkit.org/show_bug.cgi?id=173817
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-25
Reviewed by Darin Adler.
Source/WebCore:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Resetting the peer connection backend.
- testing/MockLibWebRTCPeerConnection.cpp: Doing some clean-up
(WebCore::useRealRTCPeerConnectionFactory):
(WebCore::MockLibWebRTCPeerConnectionFactory::MockLibWebRTCPeerConnectionFactory):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreatePeerConnection):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreateVideoTrack):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreateAudioTrack):
- testing/MockLibWebRTCPeerConnection.h:
LayoutTests:
Making some tests less flaky.
- TestExpectations:
- fast/mediastream/RTCPeerConnection-media-setup-two-dialogs-expected.txt:
- platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
- webrtc/audio-peer-connection-webaudio.html:
- webrtc/captureCanvas-webrtc.html:
- webrtc/datachannel/bufferedAmountLowThreshold-default-expected.txt: Added.
- webrtc/datachannel/bufferedAmountLowThreshold-default.html: Added.
- webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
- webrtc/datachannel/bufferedAmountLowThreshold.html:
- webrtc/routines.js:
- webrtc/video-replace-muted-track.html:
- webrtc/video-unmute.html:
- 10:40 AM Changeset in webkit [218794] by
-
- 305 edits in trunk/Source
Remove excessive headers from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=173812
Reviewed by Darin Adler.
Source/JavaScriptCore:
- API/APIUtils.h:
- assembler/LinkBuffer.cpp:
- assembler/MacroAssemblerCodeRef.cpp:
- b3/air/AirLiveness.h:
- b3/air/AirLowerAfterRegAlloc.cpp:
- bindings/ScriptValue.cpp:
- bindings/ScriptValue.h:
- bytecode/AccessCase.cpp:
- bytecode/AccessCase.h:
- bytecode/ArrayProfile.h:
- bytecode/BytecodeDumper.h:
- bytecode/BytecodeIntrinsicRegistry.cpp:
- bytecode/BytecodeKills.h:
- bytecode/BytecodeLivenessAnalysis.h:
- bytecode/BytecodeUseDef.h:
- bytecode/CallLinkStatus.h:
- bytecode/CodeBlock.h:
- bytecode/CodeOrigin.h:
- bytecode/ComplexGetStatus.h:
- bytecode/GetByIdStatus.h:
- bytecode/GetByIdVariant.h:
- bytecode/InlineCallFrame.h:
- bytecode/InlineCallFrameSet.h:
- bytecode/Instruction.h:
- bytecode/InternalFunctionAllocationProfile.h:
- bytecode/JumpTable.h:
- bytecode/MethodOfGettingAValueProfile.h:
- bytecode/ObjectPropertyConditionSet.h:
- bytecode/Operands.h:
- bytecode/PolymorphicAccess.h:
- bytecode/PutByIdStatus.h:
- bytecode/SpeculatedType.cpp:
- bytecode/StructureSet.h:
- bytecode/StructureStubInfo.h:
- bytecode/UnlinkedCodeBlock.h:
- bytecode/UnlinkedFunctionExecutable.h:
- bytecode/ValueProfile.h:
- bytecompiler/BytecodeGenerator.cpp:
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/Label.h:
- bytecompiler/StaticPropertyAnalysis.h:
- debugger/DebuggerCallFrame.cpp:
- dfg/DFGAbstractInterpreter.h:
- dfg/DFGAdjacencyList.h:
- dfg/DFGArgumentsUtilities.h:
- dfg/DFGArrayMode.h:
- dfg/DFGArrayifySlowPathGenerator.h:
- dfg/DFGBackwardsPropagationPhase.h:
- dfg/DFGBasicBlock.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
- dfg/DFGCallCreateDirectArgumentsSlowPathGenerator.h:
- dfg/DFGCapabilities.h:
- dfg/DFGCommon.h:
- dfg/DFGCommonData.h:
- dfg/DFGDesiredIdentifiers.h:
- dfg/DFGDesiredWatchpoints.h:
- dfg/DFGDisassembler.cpp:
- dfg/DFGDominators.h:
- dfg/DFGDriver.cpp:
- dfg/DFGDriver.h:
- dfg/DFGEdgeDominates.h:
- dfg/DFGFinalizer.h:
- dfg/DFGGenerationInfo.h:
- dfg/DFGJITCompiler.cpp:
- dfg/DFGJITCompiler.h:
- dfg/DFGJITFinalizer.h:
- dfg/DFGLivenessAnalysisPhase.h:
- dfg/DFGMinifiedNode.h:
- dfg/DFGMultiGetByOffsetData.h:
- dfg/DFGNaturalLoops.cpp:
- dfg/DFGNaturalLoops.h:
- dfg/DFGNode.h:
- dfg/DFGOSRAvailabilityAnalysisPhase.h:
- dfg/DFGOSRExit.h:
- dfg/DFGOSRExitCompilationInfo.h:
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOSRExitJumpPlaceholder.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPlan.h:
- dfg/DFGPreciseLocalClobberize.h:
- dfg/DFGPromotedHeapLocation.h:
- dfg/DFGRegisteredStructure.h:
- dfg/DFGRegisteredStructureSet.h:
- dfg/DFGSaneStringGetByValSlowPathGenerator.h:
- dfg/DFGSlowPathGenerator.h:
- dfg/DFGSnippetParams.h:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGToFTLDeferredCompilationCallback.h:
- dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h:
- dfg/DFGValidate.h:
- dfg/DFGValueSource.h:
- dfg/DFGVariableEvent.h:
- dfg/DFGVariableEventStream.h:
- dfg/DFGWorklist.h:
- domjit/DOMJITCallDOMGetterSnippet.h:
- domjit/DOMJITEffect.h:
- ftl/FTLLink.cpp:
- ftl/FTLLowerDFGToB3.cpp:
- ftl/FTLPatchpointExceptionHandle.h:
- heap/AllocatorAttributes.h:
- heap/CodeBlockSet.h:
- heap/DeferGC.h:
- heap/GCSegmentedArray.h:
- heap/Heap.cpp:
- heap/Heap.h:
- heap/IncrementalSweeper.h:
- heap/ListableHandler.h:
- heap/MachineStackMarker.h:
- heap/MarkedAllocator.h:
- heap/MarkedBlock.cpp:
- heap/MarkedBlock.h:
- heap/MarkingConstraint.h:
- heap/SlotVisitor.cpp:
- heap/SlotVisitor.h:
- inspector/ConsoleMessage.cpp:
- inspector/ConsoleMessage.h:
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.h:
- inspector/InjectedScriptManager.cpp:
- inspector/JSGlobalObjectInspectorController.cpp:
- inspector/JavaScriptCallFrame.h:
- inspector/ScriptCallStack.h:
- inspector/ScriptCallStackFactory.cpp:
- inspector/ScriptDebugServer.h:
- inspector/agents/InspectorConsoleAgent.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/agents/InspectorHeapAgent.cpp:
- inspector/agents/InspectorHeapAgent.h:
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/agents/InspectorScriptProfilerAgent.cpp:
- inspector/agents/InspectorScriptProfilerAgent.h:
- inspector/agents/JSGlobalObjectConsoleAgent.h:
- inspector/agents/JSGlobalObjectDebuggerAgent.cpp:
- inspector/agents/JSGlobalObjectDebuggerAgent.h:
- inspector/agents/JSGlobalObjectRuntimeAgent.h:
- inspector/augmentable/AlternateDispatchableAgent.h:
- interpreter/CLoopStack.h:
- interpreter/CachedCall.h:
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
- interpreter/Interpreter.h:
- jit/AssemblyHelpers.cpp:
- jit/AssemblyHelpers.h:
- jit/CCallHelpers.h:
- jit/CallFrameShuffler.h:
- jit/ExecutableAllocator.h:
- jit/GCAwareJITStubRoutine.h:
- jit/HostCallReturnValue.h:
- jit/ICStats.h:
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITAddGenerator.h:
- jit/JITCall32_64.cpp:
- jit/JITCode.h:
- jit/JITDisassembler.cpp:
- jit/JITExceptions.cpp:
- jit/JITMathIC.h:
- jit/JITOpcodes.cpp:
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/JITThunks.cpp:
- jit/JITThunks.h:
- jit/JSInterfaceJIT.h:
- jit/PCToCodeOriginMap.h:
- jit/PolymorphicCallStubRoutine.h:
- jit/RegisterSet.h:
- jit/Repatch.h:
- jit/SetupVarargsFrame.h:
- jit/Snippet.h:
- jit/SnippetParams.h:
- jit/ThunkGenerators.h:
- jsc.cpp:
- llint/LLIntCLoop.h:
- llint/LLIntEntrypoint.h:
- llint/LLIntExceptions.h:
- llint/LLIntOfflineAsmConfig.h:
- llint/LLIntSlowPaths.cpp:
- parser/NodeConstructors.h:
- parser/Nodes.cpp:
- parser/Nodes.h:
- parser/Parser.cpp:
- parser/Parser.h:
- parser/ParserTokens.h:
- parser/SourceProviderCacheItem.h:
- profiler/ProfilerBytecodeSequence.h:
- profiler/ProfilerDatabase.cpp:
- profiler/ProfilerDatabase.h:
- profiler/ProfilerOrigin.h:
- profiler/ProfilerOriginStack.h:
- profiler/ProfilerProfiledBytecodes.h:
- profiler/ProfilerUID.h:
- runtime/AbstractModuleRecord.h:
- runtime/ArrayConstructor.h:
- runtime/ArrayConventions.h:
- runtime/ArrayIteratorPrototype.h:
- runtime/ArrayPrototype.h:
- runtime/BasicBlockLocation.h:
- runtime/Butterfly.h:
- runtime/CallData.cpp:
- runtime/CodeCache.h:
- runtime/CommonSlowPaths.cpp:
- runtime/CommonSlowPaths.h:
- runtime/CommonSlowPathsExceptions.cpp:
- runtime/Completion.cpp:
- runtime/ControlFlowProfiler.h:
- runtime/DateInstanceCache.h:
- runtime/ErrorConstructor.h:
- runtime/ErrorInstance.h:
- runtime/ExceptionHelpers.cpp:
- runtime/ExceptionHelpers.h:
- runtime/ExecutableBase.h:
- runtime/FunctionExecutable.h:
- runtime/HasOwnPropertyCache.h:
- runtime/Identifier.h:
- runtime/InternalFunction.h:
- runtime/IntlCollator.cpp:
- runtime/IntlCollatorPrototype.h:
- runtime/IntlDateTimeFormatPrototype.h:
- runtime/IntlNumberFormat.cpp:
- runtime/IntlNumberFormatPrototype.h:
- runtime/IteratorOperations.cpp:
- runtime/JSArray.h:
- runtime/JSArrayBufferPrototype.h:
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
- runtime/JSCell.h:
- runtime/JSFunction.cpp:
- runtime/JSFunction.h:
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/JSGlobalObjectDebuggable.cpp:
- runtime/JSGlobalObjectDebuggable.h:
- runtime/JSGlobalObjectFunctions.cpp:
- runtime/JSGlobalObjectFunctions.h:
- runtime/JSJob.cpp:
- runtime/JSLock.h:
- runtime/JSModuleLoader.cpp:
- runtime/JSModuleNamespaceObject.h:
- runtime/JSModuleRecord.h:
- runtime/JSObject.cpp:
- runtime/JSObject.h:
- runtime/JSRunLoopTimer.h:
- runtime/JSTemplateRegistryKey.h:
- runtime/JSTypedArrayPrototypes.cpp:
- runtime/JSTypedArrayPrototypes.h:
- runtime/JSTypedArrays.h:
- runtime/LiteralParser.h:
- runtime/MatchResult.h:
- runtime/MemoryStatistics.h:
- runtime/PrivateName.h:
- runtime/PromiseDeferredTimer.h:
- runtime/ProxyObject.h:
- runtime/RegExp.h:
- runtime/SamplingProfiler.cpp:
- runtime/SmallStrings.h:
- runtime/StringPrototype.cpp:
- runtime/StringRecursionChecker.h:
- runtime/Structure.h:
- runtime/SymbolConstructor.h:
- runtime/SymbolPrototype.cpp:
- runtime/SymbolPrototype.h:
- runtime/TypeProfiler.h:
- runtime/TypeProfilerLog.h:
- runtime/TypedArrayType.h:
- runtime/VM.cpp:
- runtime/VM.h:
- runtime/VMEntryScope.h:
- runtime/WeakMapData.h:
- runtime/WriteBarrier.h:
- tools/FunctionOverrides.cpp:
- tools/FunctionOverrides.h:
- wasm/WasmBinding.cpp:
- wasm/js/JSWebAssemblyCodeBlock.h:
- wasm/js/WebAssemblyPrototype.cpp:
- yarr/Yarr.h:
- yarr/YarrJIT.cpp:
- yarr/YarrJIT.h:
- yarr/YarrParser.h:
Source/WebCore:
No new tests needed.
- Modules/indexeddb/IDBObjectStore.cpp:
- bindings/js/JSDOMPromiseDeferred.h:
- bindings/js/JSLazyEventListener.cpp:
- bindings/js/JSMainThreadExecState.h:
- bindings/js/ReadableStreamDefaultController.cpp:
- bindings/js/ScriptGlobalObject.cpp:
- bindings/js/SerializedScriptValue.cpp:
- bridge/NP_jsobject.cpp:
- dom/ScriptExecutionContext.cpp:
- html/HTMLPlugInImageElement.cpp:
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
- WebView/WebView.mm:
Source/WebKit/win:
- Plugins/PluginPackage.cpp:
Source/WebKit2:
- WebProcess/Plugins/Netscape/NPJSObject.cpp:
Source/WTF:
- wtf/Bag.h:
- 3:01 AM Changeset in webkit [218793] by
-
- 96 edits in trunk/Source/WebCore
Remove excessive headers from WebCore/{rendering,style,svg}
https://bugs.webkit.org/show_bug.cgi?id=173773
Reviewed by Darin Adler.
No new tests needed.
- css/StyleBuilderConverter.h:
- editing/TextIterator.cpp:
- rendering/CounterNode.h:
- rendering/FlexibleBoxAlgorithm.h:
- rendering/HitTestLocation.h:
- rendering/HitTestResult.h:
- rendering/HitTestingTransformState.h:
- rendering/OrderIterator.h:
- rendering/RenderButton.h:
- rendering/RenderCombineText.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.h:
- rendering/RenderGeometryMap.h:
- rendering/RenderListItem.h:
- rendering/RenderMediaControlElements.cpp:
- rendering/RenderMediaControlElements.h:
- rendering/RenderMediaControls.h:
- rendering/RenderMeter.h:
- rendering/RenderMultiColumnSet.cpp:
- rendering/RenderObject.h:
- rendering/RenderRegion.h:
- rendering/RenderRegionSet.cpp:
- rendering/RenderRegionSet.h:
- rendering/RenderTheme.h:
- rendering/RenderVTTCue.cpp:
- rendering/RenderVTTCue.h:
- rendering/SimpleLineLayoutFunctions.h:
- rendering/SimpleLineLayoutResolver.h:
- rendering/line/BreakingContext.h:
- rendering/line/LineBreaker.h:
- rendering/mathml/MathMLStyle.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRoot.h:
- rendering/shapes/RectangleShape.h:
- rendering/style/BasicShapes.h:
- rendering/style/BorderData.h:
- rendering/style/CounterDirectives.h:
- rendering/style/GridArea.h:
- rendering/style/KeyframeList.h:
- rendering/style/RenderStyle.h:
- rendering/style/SVGRenderStyle.h:
- rendering/style/ShapeValue.h:
- rendering/style/StyleCachedImage.h:
- rendering/style/StyleMultiColData.h:
- rendering/style/StyleRareNonInheritedData.h:
- rendering/style/WillChangeData.h:
- rendering/svg/RenderSVGBlock.h:
- rendering/svg/RenderSVGRect.h:
- rendering/svg/RenderSVGResource.h:
- rendering/svg/RenderSVGResourceContainer.h:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/SVGInlineFlowBox.cpp:
- rendering/svg/SVGInlineTextBox.h:
- rendering/svg/SVGRootInlineBox.h:
- rendering/svg/SVGTextChunk.cpp:
- rendering/svg/SVGTextChunk.h:
- rendering/svg/SVGTextChunkBuilder.cpp:
- rendering/svg/SVGTextLayoutEngine.cpp:
- rendering/svg/SVGTextLayoutEngineSpacing.h:
- style/RenderTreePosition.cpp:
- style/RenderTreePosition.h:
- style/RenderTreeUpdater.h:
- style/StyleFontSizeFunctions.h:
- style/StyleInvalidator.h:
- style/StyleResolveForDocument.h:
- style/StyleScope.h:
- style/StyleTreeResolver.cpp:
- style/StyleTreeResolver.h:
- style/StyleUpdate.h:
- svg/SVGAnimationElement.h:
- svg/SVGFEBlendElement.cpp:
- svg/SVGFEBlendElement.h:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFEFloodElement.cpp:
- svg/SVGFEFloodElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFEMergeElement.cpp:
- svg/SVGFEMergeElement.h:
- svg/SVGFEOffsetElement.cpp:
- svg/SVGFEOffsetElement.h:
- svg/SVGFETileElement.cpp:
- svg/SVGFETileElement.h:
- svg/SVGParserUtilities.h:
- svg/SVGPathByteStream.h:
- svg/SVGPathElement.cpp:
- svg/SVGPolyElement.cpp:
- svg/SVGSVGElement.cpp:
- svg/SVGTRefElement.cpp:
- svg/SVGTextPathElement.cpp:
- svg/SVGUseElement.cpp:
- svg/animation/SMILTimeContainer.h:
- svg/graphics/SVGImageCache.h:
- svg/graphics/filters/SVGFilter.h:
- 2:22 AM Changeset in webkit [218792] by
-
- 6 edits in trunk/Source/WebCore
Remove rAf suspension logging
https://bugs.webkit.org/show_bug.cgi?id=173821
Reviewed by Tim Horton.
Now that webkit.org/b/173628 is fixed, we can remove the logging code we added.
- dom/Document.cpp:
(WebCore::Document::requestAnimationFrame):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::suspend):
(WebCore::ScriptedAnimationController::resume):
- page/Page.cpp:
(WebCore::Page::suspendScriptedAnimations):
(WebCore::Page::resumeScriptedAnimations):
(WebCore::Page::setIsVisibleInternal):
- platform/RuntimeApplicationChecks.h:
- platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::MacApplication::isDumpRenderTree): Deleted.
Jun 24, 2017:
- 5:07 PM Changeset in webkit [218791] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly
https://bugs.webkit.org/show_bug.cgi?id=173813
Reviewed by Ryosuke Niwa.
Make sure encodeClientTypesAndData() / decodeClientTypesAndData() match exactly. The previous
IPC encoder code would assume types and data vector have the same length. It would first encode
the length of data using |data.size()| but then would encode types.size() values from the
data vector. While there are debug assertions to ensure both vectors have the same size, this
seems unnecessarily fragile in release builds. If both vectors happen to have different sizes,
this will lead to weird IPC bugs.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeClientTypesAndData):
(IPC::decodeClientTypesAndData):
- 3:29 PM Changeset in webkit [218790] by
-
- 7 edits1 add in trunk
[JSC] Clean up Object.entries implementation
https://bugs.webkit.org/show_bug.cgi?id=173759
Reviewed by Sam Weinig.
JSTests:
- microbenchmarks/object-entries.js: Added.
(test):
Source/JavaScriptCore:
This patch cleans up Object.entries implementation.
We drop unused private functions. And we merge the
implementation into Object.entries.
It slightly speeds up Object.entries speed.
baseline patched
object-entries 148.0101+-5.6627 142.1877+-4.8661 might be 1.0409x faster
- builtins/BuiltinNames.h:
- builtins/ObjectConstructor.js:
(entries):
(globalPrivate.enumerableOwnProperties): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/ObjectConstructor.cpp:
(JSC::ownEnumerablePropertyKeys): Deleted.
- runtime/ObjectConstructor.h:
- 2:47 PM Changeset in webkit [218789] by
-
- 7 edits21 adds in trunk/Source/WebCore
[WebIDL] Add complete support for stringifier
https://bugs.webkit.org/show_bug.cgi?id=173724
Patch by Sam Weinig <sam@webkit.org> on 2017-06-24
Reviewed by Darin Adler.
- bindings/scripts/CodeGeneratorJS.pm:
(AddStringifierOperationIfNeeded):
Update AddStringifierOperationIfNeeded to support stringifier on operations and be more
strict about the allowed types. Also copies over all extended attributes to the synthetic
operation.
- bindings/scripts/IDLParser.pm:
(parseInterfaceMember):
(parseOperationOrReadWriteAttributeOrMaplike):
(parseReadOnlyMember):
(parseStringifier):
(parseStaticMember):
(parseAttributeOrOperationForStringifierOrStatic):
(parseReadWriteAttribute):
(parseAttributeRest):
(parseOperation):
(parseSpecialOperation):
(parseMapLikeProperties):
(parseOperationRest):
(parseAttributeOrOperationOrIterator): Deleted.
(parseQualifier): Deleted.
(parseAttributeOrOperationRest): Deleted.
(parseAttribute): Deleted.
(parseOperationOrIterator): Deleted.
- Update parser to more closely resemble the WebIDL grammar, splitting out parseStringifier and parseStaticMember into their own subroutines.
- Move those and parseSerializer, parseStringifier, parseStaticMember, parseIterableRest and a split out parseReadOnlyMembers up into parseInterfaceMember to make it clearer that they are top level members and match the grammar.
- Rename parseAttributeOrOperationOrIterator to parseOperationOrReadWriteAttributeOrMaplike to match the grammar language and make it clear what it does.
- Add parseAttributeOrOperationForStringifierOrStatic which contains most of the logic for parsing stringifiers and static members, which have almost identical grammars.
- Remove creator special which no longer exists in the spec.
- css/DOMMatrixReadOnly.idl:
- css/WebKitCSSMatrix.idl:
- dom/Range.idl:
- html/URLSearchParams.idl:
Fix FIXMEs by switching to use stringifier.
- bindings/scripts/test/JS/JSTestStringifier.cpp: Added.
- bindings/scripts/test/JS/JSTestStringifier.h: Added.
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp: Added.
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.h: Added.
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp: Added.
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.h: Added.
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp: Added.
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.h: Added.
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp: Added.
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.h: Added.
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp: Added.
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.h: Added.
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp: Added.
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.h: Added.
- bindings/scripts/test/TestStringifier.idl: Added.
- bindings/scripts/test/TestStringifierAnonymousOperation.idl: Added.
- bindings/scripts/test/TestStringifierNamedOperation.idl: Added.
- bindings/scripts/test/TestStringifierOperationImplementedAs.idl: Added.
- bindings/scripts/test/TestStringifierOperationNamedToString.idl: Added.
- bindings/scripts/test/TestStringifierReadOnlyAttribute.idl: Added.
- bindings/scripts/test/TestStringifierReadWriteAttribute.idl: Added.
Add new tests.
- 1:14 PM Changeset in webkit [218788] by
-
- 8 edits in trunk/Source/bmalloc
bmalloc: Add a per-thread line cache
https://bugs.webkit.org/show_bug.cgi?id=173552
Reviewed by Darin Adler.
Previously, any thread could allocate out of any page with free lines.
Now, the first thread to free a line in a page owns that page's free
lines until the whole page becomes free.
This patch is a big speedup on multi-threaded benchmarks.
tree_churn --parallel gets 14% faster on a 2-core (4-hyper-core) MacBook
Air and 2.85X faster on 12-core (24-hyper-core) Mac Pro. Other parallel
benchmarks show significant but smaller speedups.
Thread affinity is a great predictor of object lifetime. The per-thread
line cache avoids the pathology of shuffling pages between threads,
turning predictable lifetimes into unpredictable lifetimes, increasing
fragmentation. On tree_churn --parallel, the per-thread line cache
increases free memory found per page scanned by 2.85X.
Free line scanning in fragmented pages is pretty expensive relative to
other allocate / initialize / free operations. According to Instruments,
on tree_churn --parallel, scanning is about 10X more expensive than
freeing. This explains why a 2.85X improvement in scanning efficiency
translates into a 2.85X overall speedup on tree_churn --parallel.
- bmalloc/Allocator.cpp:
(bmalloc::Allocator::refillAllocatorSlowCase): Pass through our line
cache so the Heap can fill it.
- bmalloc/Deallocator.cpp:
(bmalloc::Deallocator::scavenge): Scavenge our line cache.
(bmalloc::Deallocator::processObjectLog): Deleted.
- bmalloc/Deallocator.h:
(bmalloc::Deallocator::lineCache): Added a line cache.
- bmalloc/Heap.cpp:
(bmalloc::Heap::deallocateLineCache): Deallocation function for thread
destruction.
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::allocateSmallBumpRangesByMetadata):
(bmalloc::Heap::allocateSmallBumpRangesByObject): Consult the new per-thread line
cache for allocation and deallocation.
- bmalloc/Heap.h:
(bmalloc::Heap::allocateSmallBumpRanges):
(bmalloc::Heap::derefSmallLine):
- bmalloc/List.h:
(bmalloc::List::remove): Remove has always been a logically static
operation. Declare it static now so that the Heap can remove a page from
a thread's line cache without holding a direct pointer to the cache.
- bmalloc/SmallPage.h:
- 8:14 AM Changeset in webkit [218787] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Introspection: webkit_web_view_new_with_related_view needs to be marked as a constructor
https://bugs.webkit.org/show_bug.cgi?id=173765
Reviewed by Carlos Garcia Campos.
Because the first parameter to this WebKitWebView constructor is itself a WebKitWebView,
the gi-scanner's heuristics decide that it's probably an object method rather than a
constructor, resulting in improper introspection generation. Annotate it with (constructor)
to override this behavior.
- UIProcess/API/gtk/WebKitWebViewGtk.cpp:
- UIProcess/API/wpe/WebKitWebViewWPE.cpp:
- 3:24 AM Changeset in webkit [218786] by
-
- 4 edits in trunk/Source/WebKit2
Unreviewed, rolling out r218785.
https://bugs.webkit.org/show_bug.cgi?id=173808
This change broke the macOS Sierra build (Requested by
annulen|home on #webkit).
Reverted changeset:
"Removed unused lambda captures from WebKit2"
https://bugs.webkit.org/show_bug.cgi?id=173555
http://trac.webkit.org/changeset/218785
Patch by Commit Queue <commit-queue@webkit.org> on 2017-06-24
- 3:16 AM Changeset in webkit [218785] by
-
- 4 edits in trunk/Source/WebKit2
Removed unused lambda captures from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=173555
Reviewed by Alex Christensen.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):
- 1:06 AM Changeset in webkit [218784] by
-
- 19 edits3 deletes in trunk
Remove Reflect.enumerate
https://bugs.webkit.org/show_bug.cgi?id=173806
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-06-24
Reviewed by Yusuke Suzuki.
JSTests:
- ChakraCore.yaml:
- es6.yaml:
These tests now fail because they use Reflect.enumerate.
- test262.yaml:
This test now passes, it checked that Reflect.enumerate is undefined!
- stress/property-name-enumerator-should-not-look-into-indexed-values-when-it-is-a-dictionary.js:
Convert to for..in which presented the original issue. See bug <https://webkit.org/b/149811>
- stress/reflect-enumerate.js: Removed.
Remove a test solely for Reflect.enumerate.
Source/JavaScriptCore:
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::JSInjectedScriptHost::iteratorEntries):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSPropertyNameIterator.cpp: Removed.
- runtime/JSPropertyNameIterator.h: Removed.
- runtime/ReflectObject.cpp:
(JSC::reflectObjectEnumerate): Deleted.
Source/WebInspectorUI:
- UserInterface/Models/NativeFunctionParameters.js:
Tools:
- Scripts/run-jsc-stress-tests:
LayoutTests:
- inspector/model/remote-object-expected.txt:
- inspector/model/remote-object.html:
- platform/mac/inspector/model/remote-object-expected.txt:
- 12:14 AM Changeset in webkit [218783] by
-
- 8 edits2 adds in trunk
AX: Cannot call setValue() on contenteditable or ARIA text controls
https://bugs.webkit.org/show_bug.cgi?id=173520
Reviewed by Ryosuke Niwa.
Source/WebCore:
Add support for changing the value of a contenteditable and any other aria text control in setValue().
Test: accessibility/mac/set-value-editable-types.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setValue):
Tools:
Add setValue() method to WKTR (already existed in DRT).
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::setValue):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::setValue):
LayoutTests:
- accessibility/mac/set-value-editable-types-expected.txt: Added.
- accessibility/mac/set-value-editable-types.html: Added.
