Timeline



Aug 16, 2017:

11:58 PM Changeset in webkit [220832] by Carlos Garcia Campos
  • 33 edits
    35 deletes in releases/WebKitGTK/webkit-2.18

Merge r220734 - Remove Proximity Events and related code
https://bugs.webkit.org/show_bug.cgi?id=175545

Reviewed by Daniel Bates.

No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
and other related code.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • Modules/proximity/DeviceProximityClient.h: Removed.
  • Modules/proximity/DeviceProximityController.cpp: Removed.
  • Modules/proximity/DeviceProximityController.h: Removed.
  • Modules/proximity/DeviceProximityEvent.cpp: Removed.
  • Modules/proximity/DeviceProximityEvent.h: Removed.
  • Modules/proximity/DeviceProximityEvent.idl: Removed.
  • dom/EventNames.h:
  • dom/EventNames.in:
  • history/PageCache.cpp:

(WebCore::canCachePage):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • page/DOMWindow.idl:
  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::deviceProximityKey): Deleted.

  • page/DiagnosticLoggingKeys.h:
  • testing/Internals.cpp:

(WebCore::Internals::setDeviceProximity): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

  • UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

Source/WebKit:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.cpp: Removed.
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.h: Removed.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/events/constructors/device-proximity-event-constructor-expected.txt: Removed.
  • fast/events/constructors/device-proximity-event-constructor.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • proximity/add-listener-from-callback-expected.txt: Removed.
  • proximity/add-listener-from-callback.html: Removed.
  • proximity/basic-operation-expected.txt: Removed.
  • proximity/basic-operation.html: Removed.
  • proximity/check-event-deviceproximity-expected.txt: Removed.
  • proximity/check-event-deviceproximity.html: Removed.
  • proximity/create-event-deviceproximity-expected.txt: Removed.
  • proximity/create-event-deviceproximity.html: Removed.
  • proximity/create-event-expected.txt: Removed.
  • proximity/create-event.html: Removed.
  • proximity/event-after-navigation-expected.txt: Removed.
  • proximity/event-after-navigation.html: Removed.
  • proximity/multiple-frames-expected.txt: Removed.
  • proximity/multiple-frames.html: Removed.
  • proximity/no-page-cache-expected.txt: Removed.
  • proximity/no-page-cache.html: Removed.
  • proximity/optional-event-properties-expected.txt: Removed.
  • proximity/optional-event-properties.html: Removed.
  • proximity/resources/cached-page-1.html: Removed.
  • proximity/resources/cached-page-2.html: Removed.
  • proximity/resources/event-after-navigation-new.html: Removed.
  • proximity/updates-expected.txt: Removed.
  • proximity/updates.html: Removed.
  • proximity/window-property-expected.txt: Removed.
  • proximity/window-property.html: Removed.
11:58 PM Changeset in webkit [220831] by Carlos Garcia Campos
  • 21 edits
    6 deletes in releases/WebKitGTK/webkit-2.18

Merge r220732 - Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
https://bugs.webkit.org/show_bug.cgi?id=175504

Reviewed by Sam Weinig.
Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

REQUEST_AUTOCOMPLETE was added in r133396 then removed in r148731, but brought back in r173596,
however no further work was done, and it was left disabled. So remove the code.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AutocompleteErrorEvent.h: Removed.
  • dom/AutocompleteErrorEvent.idl: Removed.
  • dom/EventNames.in:
  • dom/GlobalEventHandlers.idl:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocomplete): Deleted.
(WebCore::HTMLFormElement::finishRequestAutocomplete): Deleted.
(WebCore::HTMLFormElement::requestAutocompleteTimerFired): Deleted.

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
  • loader/EmptyClients.cpp:
  • loader/FrameLoaderClient.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didRequestAutocomplete): Deleted.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:
  • DOM/DOMHTMLFormElement.mm:

(-[DOMHTMLFormElement requestAutocomplete]): Deleted.

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
11:57 PM Changeset in webkit [220830] by Carlos Garcia Campos
  • 29 edits
    12 deletes in releases/WebKitGTK/webkit-2.18

Merge r220730 - Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
https://bugs.webkit.org/show_bug.cgi?id=175557

Reviewed by Jon Lee.
.:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::viewModeEvaluate): Deleted.

  • css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent):
(WebCore::isFeatureValidWithoutValue):

  • page/Page.cpp:

(WebCore::Page::stringToViewMode): Deleted.
(WebCore::Page::setViewMode): Deleted.

  • page/Page.h:

(WebCore::Page::viewMode const): Deleted.

Source/WebCore/PAL:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • wtf/FeatureDefines.h:

Tools:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setViewModeMediaFeatureCallback): Deleted.

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setViewModeMediaFeature): Deleted.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setViewModeMediaFeature): Deleted.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • fast/media/media-query-list-02-expected.txt: Removed.
  • fast/media/media-query-list-02.html: Removed.
  • fast/media/media-query-list-03-expected.txt: Removed.
  • fast/media/media-query-list-03.html: Removed.
  • fast/media/media-query-list-04-expected.txt: Removed.
  • fast/media/media-query-list-04.html: Removed.
  • fast/media/media-query-list-05-expected.txt: Removed.
  • fast/media/media-query-list-05.html: Removed.
  • fast/media/media-query-list-06-expected.txt: Removed.
  • fast/media/media-query-list-06.html: Removed.
  • fast/media/view-mode-media-feature-expected.html: Removed.
  • fast/media/view-mode-media-feature.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
11:17 PM Changeset in webkit [220829] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk

Add the support for mutating clipboard data via DataTransferItemList
https://bugs.webkit.org/show_bug.cgi?id=175639

Reviewed by Wenson Hsieh.

Source/WebCore:

Added the support for adding plaintext data via dataTransfer.items.add, clearing data via clear,
and removing an entry via remove. When DataTransferItem is removed from DataTransferItemList,
we must put into the disabled mode.

To support the removal of DataTransferItem, this patch replaces a reference to DataTransfer by
a WeakPtr to DataTransferItemList, and stops forwarding ref from DataTransferItem to DataTransfer.
This means that DataTransfer can now be GC'ed before DataTransferItem is GC'ed.

Because the identify and the order of DataTransferItems need to be preserved, we can't simply
re-popluate m_itemList in DataTransferItemList. Instead, whenever the clipboard content is mutated,
we make the parallel modifications to m_itemList. This includes changes made via DataTransfer
methods such as setData and clearData.

Test: editing/pasteboard/datatransfer-items-copy-plaintext.html

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::clearData): Invoke didClearStringData when m_itemList exists.
(WebCore::DataTransfer::setData): Ditto.
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):

  • dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::create):
(WebCore::DataTransferItem::DataTransferItem):
(WebCore::DataTransferItem::clearListAndPutIntoDisabledMode): Added.
(WebCore::DataTransferItem::type const): Moved from the header.
(WebCore::DataTransferItem::getAsString const):
(WebCore::DataTransferItem::getAsFile const):

  • dom/DataTransferItem.h:

(WebCore::DataTransferItem::ref): Deleted.
(WebCore::DataTransferItem::deref): Deleted.
(WebCore::DataTransferItem::isFile const): Added.
(WebCore::DataTransferItem::type const): Move to the cpp file.

  • dom/DataTransferItemList.cpp:

(WebCore::isSupportedType): Moved.
(WebCore::DataTransferItemList::DataTransferItemList): Moved from the header.
(WebCore::DataTransferItemList::~DataTransferItemList): Added.
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::add): Implemented the variant to add string data.
(WebCore::DataTransferItemList::remove): Implemented. For now, we don't have to deal with removing
a file since a writable dataTransfer never contains a File object.
(WebCore::DataTransferItemList::clear): Implemented.
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::removeStringItemOfLowercasedType): Added.
(WebCore::DataTransferItemList::didClearStringData): Called when dataTransfer.clear is called.
(WebCore::DataTransferItemList::didSetStringData): Ditto for

  • dom/DataTransferItemList.h:

(WebCore::DataTransferItemList): Added a WeakPtrFactory. Also use a vector of Ref<DataTransferItem>
instead of unique_ptr<DataTransferItem> since DataTransferItem can outlive DataTransferItemList.
(WebCore::DataTransferItemList::dataTransfer): Added.

  • dom/DataTransferItemList.idl:

LayoutTests:

Rebaselined the IDL test which now passes all test cases, and added a regression test for mutating clipboard data
via dataTransfer.items and methods on dataTransfer for plaintext.

  • editing/pasteboard/datatransfer-idl-expected.txt:
  • editing/pasteboard/datatransfer-items-copy-plaintext-expected.txt: Added.
  • editing/pasteboard/datatransfer-items-copy-plaintext.html: Added.
11:11 PM Changeset in webkit [220828] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.18

Merge r220717 - The none smooth stroke applied to an SVG shape breaks its hit testing
https://bugs.webkit.org/show_bug.cgi?id=175506

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-14
Reviewed by Simon Fraser.

Source/WebCore:

Clear RenderSVGShape::m_path when calling RenderSVGRect::updateShapeFromElement().
The m_path will be recalculated when RenderSVGShape::updateShapeFromElement()
is called from RenderSVGRect::shapeDependentStrokeContains().

Test: svg/stroke/stroke-linejoin-click.html

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::clearPath):

LayoutTests:

  • svg/stroke/stroke-linejoin-click-expected.html: Added.
  • svg/stroke/stroke-linejoin-click.html: Added.
11:08 PM Changeset in webkit [220827] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220522 - Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

  • platform/graphics/texmap/TextureMapperGLHeaders.h:

Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

11:08 PM Changeset in webkit [220826] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220521 - [TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

11:08 PM Changeset in webkit [220825] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18

Merge r220699 - REGRESSION(r220517-r220521) [GTK] Various compositing tests fail
https://bugs.webkit.org/show_bug.cgi?id=175478

Reviewed by Sergio Villar Senin.

Source/WebCore:

Fix a regression introduced in r220519. Move a framebuffer binding in TextureMapperGL
away from GraphicsContext3D and onto the OpenGL API to work around the framebuffer
binding state that's kept in the GraphicsContext3D class. This mismatch in how the
framebuffer was bound was causing a couple of test failures in compositing tests.

No new tests -- regressed tests have their failure expectations removed.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindDefaultSurface): Don't use GraphicsContext3D for the
glBindFramebuffer() call. This would be done in subsequent patches that would move
TextureMapperGL off the GraphicsContext3D usage, but this specific use case clashes
with the framebuffer binding that's done in BitmapTextureGL and was causing test
failures.

LayoutTests:

  • platform/gtk/TestExpectations: Remove failure and flakiness expectations.
11:08 PM Changeset in webkit [220824] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220519 - [TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

  • platform/graphics/texmap/BitmapTextureGL.cpp:

Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):

  • platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

10:09 PM Changeset in webkit [220823] by mark.lam@apple.com
  • 16 edits in trunk/Source

Add back the ability to disable MASM_PROBE from the build.
https://bugs.webkit.org/show_bug.cgi?id=175656
<rdar://problem/33933720>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This is needed for ports that the existing MASM_PROBE implementation doesn't work
well with e.g. GTK with ARM_THUMB2. Note that if the DFG_JIT will be disabled by
default if !ENABLE(MASM_PROBE).

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.cpp:
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:
  • assembler/MacroAssemblerARM64.cpp:
  • assembler/MacroAssemblerARMv7.cpp:
  • assembler/MacroAssemblerPrinter.cpp:
  • assembler/MacroAssemblerPrinter.h:
  • assembler/MacroAssemblerX86Common.cpp:
  • assembler/testmasm.cpp:

(JSC::run):

  • b3/B3LowerToAir.cpp:
  • b3/air/AirPrintSpecial.cpp:
  • b3/air/AirPrintSpecial.h:

Source/WTF:

  • wtf/Platform.h:
8:32 PM Changeset in webkit [220822] by mitz@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Cocoa] Older-iOS install name symbols are being exported on other platforms
https://bugs.webkit.org/show_bug.cgi?id=175654

Reviewed by Tim Horton.

  • API/JSBase.cpp: Define the symbols only when targeting iOS.
6:24 PM Changeset in webkit [220821] by aestes@apple.com
  • 33 edits
    2 moves in trunk/Source

[Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
https://bugs.webkit.org/show_bug.cgi?id=175648

Reviewed by Tim Horton.

Source/WebCore:

The W3C Payment Request API defines an interface called PaymentRequest, which conflicts with
an existing Apple Pay class. This patch renames PaymentRequest to
ApplePaySessionPaymentRequest so that a follow-on patch can introduce PaymentRequest for the
W3C API.

  • Modules/applepay/ApplePayError.h:
  • Modules/applepay/ApplePayLineItem.h:
  • Modules/applepay/ApplePayPaymentRequest.h:
  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidateTotal):
(WebCore::convertAndValidate):
(WebCore::ApplePaySession::ApplePaySession):
(WebCore::ApplePaySession::didSelectShippingMethod):

  • Modules/applepay/ApplePaySession.h:
  • Modules/applepay/ApplePaySessionPaymentRequest.cpp: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.cpp.

(WebCore::ApplePaySessionPaymentRequest::ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::~ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::isValidSupportedNetwork):

  • Modules/applepay/ApplePaySessionPaymentRequest.h: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.h.
  • Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:

(WebCore::convert):
(WebCore::ApplePayShippingMethodSelectedEvent::ApplePayShippingMethodSelectedEvent):

  • Modules/applepay/ApplePayShippingMethodSelectedEvent.h:
  • Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::beginPaymentSession):
(WebCore::PaymentCoordinator::didSelectShippingMethod):

  • Modules/applepay/PaymentCoordinator.h:
  • Modules/applepay/PaymentCoordinatorClient.h:
  • Modules/applepay/PaymentHeaders.h:
  • Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):
(WebCore::PaymentRequestValidator::validateTotal):
(WebCore::validateMerchantCapabilities):
(WebCore::validateShippingMethod):
(WebCore::validateShippingMethods):

  • Modules/applepay/PaymentRequestValidator.h:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.cpp:

Source/WebKit:

  • Scripts/webkit/messages.py:

(headers_for_type):

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::decode):
(IPC::ArgumentCoder<PaymentRequest>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::decode): Deleted.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
(WebKit::WebPaymentCoordinatorProxy::didSelectShippingMethod):

  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(toShippingMethod):
(WebKit::toPKContactFields):
(WebKit::toPKAddressField):
(WebKit::toPKPaymentSummaryItemType):
(WebKit::toPKPaymentSummaryItem):
(WebKit::toPKPaymentSummaryItems):
(WebKit::toPKMerchantCapabilities):
(WebKit::toPKShippingType):
(WebKit::toPKShippingMethod):
(WebKit::toPKPaymentRequest):

  • UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

  • UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

  • WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::showPaymentUI):
(WebKit::WebPaymentCoordinator::didSelectShippingMethod):

  • WebProcess/ApplePay/WebPaymentCoordinator.h:
  • WebProcess/ApplePay/WebPaymentCoordinator.messages.in:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebPaymentCoordinatorClient.h:
  • WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::showPaymentUI):

5:45 PM Changeset in webkit [220820] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fullscreen/full-screen-iframe-legacy.html as flaky on Sierra WK1.
https://bugs.webkit.org/show_bug.cgi?id=175554

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
5:43 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
5:40 PM Changeset in webkit [220819] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Correct a typo in a test name.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:33 PM Changeset in webkit [220818] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline crypto/subtle/rsa-generate-key-malformed-parameters.html after r220811.

Unreviewed test gardening.

  • platform/ios-11/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
5:28 PM Changeset in webkit [220817] by Chris Dumez
  • 31 edits
    1 move
    1 add
    3 deletes in trunk

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight
https://bugs.webkit.org/show_bug.cgi?id=175628
<rdar://problem/33919278>

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline a few web-platform-tests due to revert of r220779.

  • web-platform-tests/beacon/headers/header-content-type-expected.txt:
  • web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
  • web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:

  1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
  2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS preflight merely because the fetch mode is set to "cors").

Test: http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

  • loader/CrossOriginAccessControl.h:
  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::CachedResourceRequest):

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::releaseOriginalRequestHeaders):

  • platform/network/HTTPHeaderValues.cpp:
  • platform/network/HTTPHeaderValues.h:

Source/WebKit:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:

  1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
  2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS preflight merely because the fetch mode is set to "cors").
  • NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::startPreflight):

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::originalRequestHeaders const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::isAllowedRedirect const):
(WebKit::PingLoad::makeCrossOriginAccessRequest):
(WebKit::PingLoad::makeSimpleCrossOriginAccessRequest):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):
(WebKit::PingLoad::preflightSuccess):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

  • http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
  • http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt:
  • http/wpt/fetch/fetch-request-arraybuffer-content-type.html:

Rebaseline test due to revert of r220779.

  • http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Removed.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Removed.

Drop outdated test. CORS preflight failure is still covered by the corresponding Blob payload test.

  • http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Removed.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Removed.
  • http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight-expected.txt: Added.
  • http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html: Added.

Rename and update test so that it checks that we no longer do a CORS preflight for cross origin
beacons that have an ArrayBuffer payload.

4:29 PM Changeset in webkit [220816] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Gardening: fix GTK ARM_THUMB2 build.
https://bugs.webkit.org/show_bug.cgi?id=175446

Not reviewed.

Disable the use of the DFG for GTK ARM_THUMB2 builds until
https://bugs.webkit.org/show_bug.cgi?id=175514 is fixed.

  • wtf/Platform.h:
4:15 PM Changeset in webkit [220815] by Matt Baker
  • 12 edits
    1 add in trunk

Web Inspector: capture async stack trace when workers/main context posts a message
https://bugs.webkit.org/show_bug.cgi?id=167084
<rdar://problem/30033673>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/agents/InspectorDebuggerAgent.h:

Add PostMessage async call type.

Source/WebCore:

Add instrumentation to DOMWindow to support showing asynchronous
stack traces when the debugger pauses in a MessageEvent handler.

Test: inspector/debugger/async-stack-trace.html

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didPostMessageImpl):
(WebCore::InspectorInstrumentation::didFailPostMessageImpl):
(WebCore::InspectorInstrumentation::willDispatchPostMessageImpl):
(WebCore::InspectorInstrumentation::didDispatchPostMessageImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didPostMessage):
(WebCore::InspectorInstrumentation::didFailPostMessage):
(WebCore::InspectorInstrumentation::willDispatchPostMessage):
(WebCore::InspectorInstrumentation::didDispatchPostMessage):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearAsyncStackTraceData):
(WebCore::PageDebuggerAgent::didPostMessage):
(WebCore::PageDebuggerAgent::didFailPostMessage):
(WebCore::PageDebuggerAgent::willDispatchPostMessage):
(WebCore::PageDebuggerAgent::didDispatchPostMessage):

  • inspector/PageDebuggerAgent.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add a test to check for asynchronous stack trace data when the debugger
pauses inside a MessageEvent handler.

  • inspector/debugger/async-stack-trace-expected.txt:
  • inspector/debugger/async-stack-trace.html:
  • inspector/debugger/resources/postMessage-echo.html: Added.
4:00 PM Changeset in webkit [220814] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the build

  • platform/ios/PlatformPasteboardIOS.mm:
3:58 PM Changeset in webkit [220813] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Build fix after r220812

Fix builds where LOG_DISABLED is defined.

  • css/MediaQueryEvaluator.cpp:
3:12 PM Changeset in webkit [220812] by Simon Fraser
  • 20 edits in trunk/Source/WebCore

Add a log channel for media queries
https://bugs.webkit.org/show_bug.cgi?id=175591

Reviewed by Zalan Bujtas.

Add a "MediaQueries" log channel which logs data about media query evaluation.

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::MediaQuerySet):
(WebCore::operator<<):

  • css/MediaList.h:
  • css/MediaQuery.cpp:

(WebCore::operator<<):

  • css/MediaQuery.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::operator<<):
(WebCore::MediaQueryEvaluator::evaluate const):
(WebCore::aspectRatioValueAsString):
(WebCore::orientationEvaluate):
(WebCore::aspectRatioEvaluate):
(WebCore::deviceAspectRatioEvaluate):
(WebCore::evaluateResolution):
(WebCore::deviceHeightEvaluate):
(WebCore::deviceWidthEvaluate):
(WebCore::heightEvaluate):
(WebCore::widthEvaluate):

  • css/MediaQueryExpression.cpp:

(WebCore::operator<<):

  • css/MediaQueryExpression.h:
  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::styleResolverChanged):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::hasMediaQueriesAffectedByViewportChange const):
(WebCore::StyleResolver::hasMediaQueriesAffectedByAccessibilitySettingsChange const):

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectNextSourceChild):

  • html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::viewportChangeAffectedPicture const):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

  • platform/Logging.cpp:

(WebCore::initializeLogChannelsIfNecessary):

  • platform/Logging.h:
  • platform/URL.cpp:

(WebCore::isSchemeFirstChar):
(WebCore::operator<<):

  • platform/URL.h:
3:11 PM Changeset in webkit [220811] by commit-queue@webkit.org
  • 62 edits
    1 copy
    1 delete in trunk

[WebIDL] Remove the need for JSSubtleCryptoCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=175526

Patch by Sam Weinig <sam@webkit.org> on 2017-08-16
Reviewed by Chris Dumez.

Source/WebCore:

  • Generates bindings for all of SubtleCrypto except AlgorithmIdentifier normalization, which is defined in the WebCrypto spec to happen after normal IDL operations.
  • Adds initial support for IDL object types in unions (some, unneeded at the moment, edge cases remain).
  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSubtleCryptoCustom.cpp: Removed.

Remove JSSubtleCryptoCustom.cpp, added CryptoKeyFormat.h

  • bindings/js/JSDOMConvertObject.h:

Add needed, when included in generated code, #include of StrongInlines.h

  • bindings/js/JSDOMConvertUnion.h:

Add initial support for object (needed for AlgorithmIdentifier which is
(object or DOMString)). Remaining support will be handled by https://webkit.org/b/175616

Also add remaining spec comments while in the area.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::reject):

Add support for the special ExistingExceptionError error code. Capturing
the current exception and using it as the rejection value.

  • crypto/SubtleCrypto.cpp:

(WebCore::SubtleCrypto::~SubtleCrypto):
(WebCore::toHashIdentifier):
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::toCryptoKeyUsageBitmap):
(WebCore::rejectWithException):
(WebCore::normalizeJsonWebKey):
(WebCore::toKeyData):
(WebCore::copyToVector):
(WebCore::isSupportedExportKey):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::digest):
(WebCore::SubtleCrypto::generateKey):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::importKey):
(WebCore::SubtleCrypto::exportKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):

  • crypto/SubtleCrypto.h:
  • crypto/SubtleCrypto.idl:

Moves implementation from JSSubtleCryptoCustom.cpp -> here. Important changes that come
with that are:

  • All parameters are now converted / type checked for us.
  • Rather than throwing exceptions and expecting the bindings layer to convert them to promise rejections, all rejections are now explicitly made.
  • Algorithms are no longer checked for being supported twice, once in normalizeCryptoAlgorithmParameters and then again in the operation. We instead rely on normalizeCryptoAlgorithmParameters to return an Exception if its not supported.
  • Shaves 251 lines off the file.
  • crypto/CryptoKeyFormat.h: Added.

Add new header for unified key format enum. (For bindings purposes, SubtleCrypto
re aliases it to SubtleCrypto::KeyFormat).

  • bindings/js/JSWebKitSubtleCryptoCustom.cpp:
  • crypto/CryptoAlgorithm.cpp:
  • crypto/CryptoAlgorithm.h:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_CFB.h:
  • crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_CTR.h:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_GCM.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmECDH.cpp:
  • crypto/algorithms/CryptoAlgorithmECDH.h:
  • crypto/algorithms/CryptoAlgorithmECDSA.cpp:
  • crypto/algorithms/CryptoAlgorithmECDSA.h:
  • crypto/algorithms/CryptoAlgorithmHKDF.cpp:
  • crypto/algorithms/CryptoAlgorithmHKDF.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:
  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
  • crypto/algorithms/CryptoAlgorithmPBKDF2.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.h:

Use CryptoKeyFormat enum directly, rather than SubtleCrypto::KeyFormat,
to allow not including SubtleCrypto.h.

  • crypto/parameters/CryptoAlgorithmEcdsaParams.h:
  • crypto/parameters/CryptoAlgorithmHkdfParams.h:
  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
  • crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
  • crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
  • crypto/parameters/CryptoAlgorithmRsaHashedKeyGenParams.h:
  • crypto/parameters/EcdsaParams.idl:
  • crypto/parameters/HkdfParams.idl:
  • crypto/parameters/HmacKeyParams.idl:
  • crypto/parameters/Pbkdf2Params.idl:
  • crypto/parameters/RsaHashedImportParams.idl:
  • crypto/parameters/RsaHashedKeyGenParams.idl:

Update IDLs and implementations to use the correct definition of HashAlgorithmIdentifier,
which is (object or DOMString), now that it is supported.

LayoutTests:

  • crypto/subtle/encrypt-malformed-parameters-expected.txt:
  • crypto/subtle/export-key-malformed-parameters-expected.txt:
  • crypto/subtle/generate-key-malformed-parameters-expected.txt:
  • crypto/subtle/hkdf-derive-bits-malformed-parametrs-expected.txt:
  • crypto/subtle/hmac-generate-key-malformed-parameters-expected.txt:
  • crypto/subtle/import-key-malformed-parameters-expected.txt:
  • crypto/subtle/pbkdf2-derive-bits-malformed-parametrs-expected.txt:
  • crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
  • platform/mac-highsierra/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:

Update expectations with improved error messages.

3:09 PM Changeset in webkit [220810] by commit-queue@webkit.org
  • 10 edits
    1 copy
    1 add in trunk/Source/WebCore

[Cache API] Implement Worker connection to the Cache storage engine
https://bugs.webkit.org/show_bug.cgi?id=175599

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-16
Reviewed by Chris Dumez.

Covered by existing tests.

Adding a WorkerCacheStorageConnection to connect workers Cache/CacheStorage
to the cache storage engine.
WorkerCacheStorageConnection does this by hopping to the main thread to call the document cache storage connection to do the actual job.
Doing some CacheStorageConnection refactoring to share code with WK2 implementation of the cache storage connection.

  • Modules/cache/CacheQueryOptions.h:

(WebCore::CacheQueryOptions::isolatedCopy const):

  • Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::retrieveCaches):
(WebCore::CacheStorageConnection::retrieveRecords):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):
(WebCore::CacheStorageConnection::openOrRemoveCompleted):
(WebCore::CacheStorageConnection::updateCaches):
(WebCore::CacheStorageConnection::updateRecords):
(WebCore::CacheStorageConnection::removeRecordsCompleted):
(WebCore::CacheStorageConnection::putRecordsCompleted):

  • Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doRetrieveCaches):
(WebCore::CacheStorageConnection::doRetrieveRecords):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):

  • Modules/cache/WorkerCacheStorageConnection.cpp: Added.

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
(WebCore::WorkerCacheStorageConnection::create):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):

  • Modules/cache/WorkerCacheStorageConnection.h: Added.
  • Modules/cache/WorkerGlobalScopeCaches.cpp:

(WebCore::WorkerGlobalScopeCaches::caches const):

  • WebCore.xcodeproj/project.pbxproj:
  • loader/FetchOptions.h:

(WebCore::FetchOptions::isolatedCopy const):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::cacheStorageConnection):

  • workers/WorkerGlobalScope.h:
2:42 PM Changeset in webkit [220809] by commit-queue@webkit.org
  • 43 edits
    11 copies
    2 adds
    2 deletes in trunk

[PAL] Move spi/ios and spi/win directories into PAL
https://bugs.webkit.org/show_bug.cgi?id=175171

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-16
Reviewed by Antti Koivisto.

Source/WebCore:

  • PlatformWin.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa/DataDetection.mm:
  • loader/ios/PreviewLoader.mm:
  • page/CaptionUserPreferencesMediaAF.cpp:
  • page/cocoa/MemoryReleaseCocoa.mm:
  • page/cocoa/SettingsCocoa.mm:
  • page/ios/UserAgentIOS.mm:
  • platform/audio/ios/MediaSessionManagerIOS.mm:
  • platform/graphics/ca/PlatformCALayer.cpp:
  • platform/graphics/cocoa/FontCascadeCocoa.mm:
  • platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
  • platform/graphics/opentype/OpenTypeCG.h:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/SimpleFontDataDirect2D.cpp:
  • platform/ios/Device.h:
  • platform/ios/PlatformPasteboardIOS.mm:
  • platform/ios/PlatformScreenIOS.mm:
  • platform/ios/QuickLookSoftLink.h:
  • platform/ios/QuickLookSoftLink.mm:
  • platform/ios/ValidationBubbleIOS.mm:
  • platform/ios/WebItemProviderPasteboard.mm:
  • platform/network/ios/PreviewConverter.mm:
  • platform/sql/SQLiteFileSystem.cpp:
  • rendering/RenderThemeIOS.mm:

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/spi/ios/CoreUISPI.h: Renamed from Source/WebCore/platform/spi/ios/CoreUISPI.h.
  • pal/spi/ios/DataDetectorsUISPI.h: Renamed from Source/WebCore/platform/spi/ios/DataDetectorsUISPI.h.
  • pal/spi/ios/GraphicsServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/GraphicsServicesSPI.h.
  • pal/spi/ios/LaunchServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/LaunchServicesSPI.h.
  • pal/spi/ios/MediaPlayerSPI.h: Renamed from Source/WebCore/platform/spi/ios/MediaPlayerSPI.h.
  • pal/spi/ios/MobileGestaltSPI.h: Renamed from Source/WebCore/platform/spi/ios/MobileGestaltSPI.h.
  • pal/spi/ios/OpenGLESSPI.h: Renamed from Source/WebCore/platform/spi/ios/OpenGLESSPI.h.
  • pal/spi/ios/QuickLookSPI.h: Renamed from Source/WebCore/platform/spi/ios/QuickLookSPI.h.
  • pal/spi/ios/SQLite3SPI.h: Renamed from Source/WebCore/platform/spi/ios/SQLite3SPI.h.
  • pal/spi/ios/UIKitSPI.h: Renamed from Source/WebCore/platform/spi/ios/UIKitSPI.h.
  • pal/spi/win/CoreTextSPIWin.h: Renamed from Source/WebCore/platform/spi/win/CoreTextSPIWin.h.

Source/WebKit:

  • UIProcess/Cocoa/NavigationState.mm:
  • UIProcess/ios/WKActionSheetAssistant.h:
  • UIProcess/ios/WKActionSheetAssistant.mm:
  • UIProcess/ios/WKContentViewInteraction.mm:
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy:

  • Storage/StorageTracker.cpp:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebView.mm:

Tools:

  • DumpRenderTree/mac/EventSendingController.mm:
1:49 PM Changeset in webkit [220808] by timothy_horton@apple.com
  • 16 edits in trunk/Source/WebCore

2-3% of main thread time under UTTypeCreatePreferredIdentifierForTag on wunderground map
https://bugs.webkit.org/show_bug.cgi?id=175618

Reviewed by Simon Fraser.

No new tests, just a perf win.

UTTypeCreatePreferredIdentifierForTag is fairly expensive, and is called
under every toDataURL, which the Wunderground wundermap does a /lot/.

Keep a 16-item LRU cache of MIMEType->UTI mappings.

Also, make other callers of UTTypeCreatePreferredIdentifierForTag use
the UTIUtilities version so they can share in the caching.

Also, as a drive-by, add and make other callers use mimeTypeFromUTI too,
and make the UTIUtilities operate on Strings for a slightly more WebCore-y feel.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::readImage):

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::createFileTypesSet):

  • platform/graphics/cg/ImageSourceCGMac.mm:

(WebCore::MIMETypeForImageSourceType):
Adopt newly-added MIMETypeFromUTI().

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::utiFromImageBufferMIMEType):
(WebCore::ImageBuffer::toCFData const):
(WebCore::cfData):
(WebCore::utiFromMIMEType): Deleted.
Adopt UTIFromMIMEType, and rename the local helper that does something
different (a small static map) on iOS and Windows to not have an overlapping name.

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::resourceMIMEType):
(WebCore::utiTypeFromCocoaType):
Adopt UTIFromMIMEType().

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::writeObjectRepresentations):

  • platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
Adopt isDeclaredUTI and UTIFromMIMEType().

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::responseReceived):

  • platform/network/ios/WebCoreURLResponseIOS.mm:

(WebCore::adjustMIMETypeIfNecessary):

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

  • rendering/RenderThemeIOS.mm:

(WebCore::iconForAttachment):

  • rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):
Deal with the fact that UTI utilities deal in Strings now.

  • platform/network/mac/UTIUtilities.h:
  • platform/network/mac/UTIUtilities.mm:

(WebCore::MIMETypeFromUTI):
Added. This doesn't crawl up the UTI tree if the first conversion fails,
which is what most of the existing code does. It's possible we want to
use MIMETypeFromUTITree's logic everywhere, but I didn't want to change
that in this patch.

(WebCore::MIMETypeFromUTITree):
(WebCore::isDeclaredUTI):
Take and return strings.

(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::UTIFromMIMEType):
Add the aforementioned cache.

1:38 PM Changeset in webkit [220807] by mark.lam@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Enhance MacroAssembler::probe() to support an initializeStackFunction callback.
https://bugs.webkit.org/show_bug.cgi?id=175617
<rdar://problem/33912104>

Reviewed by JF Bastien.

This patch adds a new feature to MacroAssembler::probe() where the probe function
can provide a ProbeFunction callback to fill in stack values after the stack
pointer has been adjusted. The probe function can use this feature as follows:

  1. Set the new sp value in the ProbeContext's CPUState.
  1. Set the ProbeContext's initializeStackFunction to a ProbeFunction callback which will do the work of filling in the stack values after the probe trampoline has adjusted the machine stack pointer.
  1. Set the ProbeContext's initializeStackArgs to any value that the client wants to pass to the initializeStackFunction callback.
  1. Return from the probe function.

Upon returning from the probe function, the probe trampoline will adjust the
the stack pointer based on the sp value in CPUState. If initializeStackFunction
is not set, the probe trampoline will restore registers and return to its caller.

If initializeStackFunction is set, the trampoline will move the ProbeContext
beyond the range of the stack pointer i.e. it will place the new ProbeContext at
an address lower than where CPUState.sp() points. This ensures that the
ProbeContext will not be trashed by the initializeStackFunction when it writes to
the stack. Then, the trampoline will call back to the initializeStackFunction
ProbeFunction to let it fill in the stack values as desired. The
initializeStackFunction ProbeFunction will be passed the moved ProbeContext at
the new location.

initializeStackFunction may now write to the stack at addresses greater or
equal to CPUState.sp(), but not below that. initializeStackFunction is also
not allowed to change CPUState.sp(). If the initializeStackFunction does not
abide by these rules, then behavior is undefined, and bad things may happen.

For future reference, some implementation details that this patch needed to
be mindful of:

  1. When the probe trampoline allocates stack space for the ProbeContext, it should include OUT_SIZE as well. This ensures that it doesn't have to move the ProbeContext on exit if the probe function didn't change the sp.
  1. If the trampoline has to move the ProbeContext, it needs to point the machine sp to new ProbeContext first before copying over the ProbeContext data. This protects the new ProbeContext from possibly being trashed by interrupts.
  1. When computing the new address of ProbeContext to move to, we need to make sure that it is properly aligned in accordance with stack ABI requirements (just like we did when we allocated the ProbeContext on entry to the probe trampoline).
  1. When copying the ProbeContext to its new location, the trampoline should always copy words from low addresses to high addresses. This is because if we're moving the ProbeContext, we'll always be moving it to a lower address.
  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:
  • assembler/MacroAssemblerARM64.cpp:
  • assembler/MacroAssemblerARMv7.cpp:
  • assembler/MacroAssemblerX86Common.cpp:
  • assembler/testmasm.cpp:

(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):

1:30 PM Changeset in webkit [220806] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

Make RenderLayer and RenderLayerBacking TextStream-loggable, and clean up compositing logging
https://bugs.webkit.org/show_bug.cgi?id=175634

Reviewed by Zalan Bujtas.

Add operator<<(TextStream&) for RenderLayer and RenderLayer backing, and use them for compositing logging.

Convert CompositingUpdateType to an enum class.

  • page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):

  • page/ios/FrameIOS.mm:

(WebCore::Frame::viewportOffsetChanged):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::operator<<):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::operator<<):

  • rendering/RenderLayerCompositor.h:
1:20 PM Changeset in webkit [220805] by eric.carlson@apple.com
  • 5 edits
    4 adds in trunk

Consider allow gUM to be called from localhost without https
https://bugs.webkit.org/show_bug.cgi?id=173457
<rdar://problem/33900527>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: http/tests/media/media-stream/get-user-media-localhost.html

http/tests/media/media-stream/get-user-media-loopback-ip.html

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::isSecure): Call SchemeRegistry::shouldTreatURLSchemeAsSecure instead of looking for
the string 'https'.
(WebCore::canCallGetUserMedia): Allow localhost or loopback address.

  • page/SecurityOrigin.cpp:

(WebCore::isLoopbackIPAddress): Add a comment.
(WebCore::shouldTreatAsPotentionallyTrustworthy): Move tests for localhost and loopback address
to isLocalHostOrLoopbackIPAddress, call it.
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):

  • page/SecurityOrigin.h:

LayoutTests:

  • http/tests/media/media-stream/get-user-media-localhost-expected.txt: Added.
  • http/tests/media/media-stream/get-user-media-localhost.html: Added.
  • http/tests/media/media-stream/get-user-media-loopback-ip-expected.txt: Added.
  • http/tests/media/media-stream/get-user-media-loopback-ip.html: Added.
1:19 PM Changeset in webkit [220804] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html
https://bugs.webkit.org/show_bug.cgi?id=175102

Unreviewed test gardening.

  • platform/mac/TestExpectations:
12:53 PM WebKitGTK/2.18.x edited by Michael Catanzaro
Propose r220797 (diff)
12:42 PM Changeset in webkit [220803] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

12:36 PM Changeset in webkit [220802] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.3

Tag Safari-605.1.3.

12:17 PM Changeset in webkit [220801] by commit-queue@webkit.org
  • 9 edits
    7 adds in trunk/PerformanceTests

Speedometer: Update Angular 1 TodoMVC example to v1.6.5
https://bugs.webkit.org/show_bug.cgi?id=175623

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/architecture-examples/angularjs/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js.map: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js.map: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js.map: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/package.json: Updated per build steps.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/package.json: Updated per build steps.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/package-lock.json: Added to pin dependencies.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/package.json: Updated per build steps.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md: Document the build process.
11:59 AM Changeset in webkit [220800] by commit-queue@webkit.org
  • 5 edits
    7 adds in trunk/PerformanceTests

Speedometer: Document Backbone example
https://bugs.webkit.org/show_bug.cgi?id=175626

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/architecture-examples/backbone/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.map: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js: Updated per build steps.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.map: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css: Updated per build steps.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.map: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/package-lock.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/readme.md: Documented build steps.
10:30 AM Changeset in webkit [220799] by Chris Dumez
  • 5 edits
    2 adds in trunk

EventSource: ignore IDs with U+0000
https://bugs.webkit.org/show_bug.cgi?id=175178

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import WPT test coverage from:

  • web-platform-tests/eventsource/format-field-id-null-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-id-null.htm: Added.
  • web-platform-tests/eventsource/resources/last-event-id.py:

(main):

  • web-platform-tests/eventsource/w3c-import.log:

Source/WebCore:

EventSource: ignore IDs with U+0000 as per:
https://github.com/whatwg/html/pull/2849

Test: imported/w3c/web-platform-tests/eventsource/format-field-id-null.htm

  • page/EventSource.cpp:

(WebCore::EventSource::parseEventStreamLine):

9:46 AM Changeset in webkit [220798] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
9:36 AM Changeset in webkit [220797] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

[HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
https://bugs.webkit.org/show_bug.cgi?id=174418

Patch by Fujii Hironori <Fujii Hironori> on 2017-08-16
Reviewed by Michael Catanzaro.

Source/WebCore:

HarfBuzzShaper should normalize the input text before collecting
HarfBuzzRuns. Actually, HarfBuzzShaper::setNormalizedBuffer does
the task. But, this function hasn't been called from anywhere
since Bug 90951.

Test: fast/text/international/vietnamese-nfd.html

imported/blink/fast/text/international/text-shaping-arabic-diffs.html

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Call setNormalizedBuffer instead of normalizeCharacters.
(WebCore::normalizeCharacters): Deleted.
(WebCore::normalizeSpacesAndMirrorChars) Use
FontCascade::treatAsZeroWidthSpaceInComplexScript instead of
FontCascade::treatAsZeroWidthSpace to preserve ZWJ and ZWNJ.

LayoutTests:

  • fast/text/international/vietnamese-nfd-expected.html: Added.
  • fast/text/international/vietnamese-nfd.html: Added.
9:08 AM WebKitGTK/2.18.x edited by Michael Catanzaro
Propose r220746 (diff)
8:43 AM Changeset in webkit [220796] by Chris Dumez
  • 4 edits in trunk/LayoutTests

Unreviewed, rebaseline a few tests after r220779.

  • http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html:
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html:
6:15 AM Changeset in webkit [220795] by Antti Koivisto
  • 14 edits
    2 adds in trunk/Source/WebCore

Move first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175627

Reviewed by Andreas Kling.

Render tree should not mutate itself. We already fixed this for first-letter, supporting code
can now move to RenderTreeUpdater too.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp:

(WebCore::styleForFirstLetter): Deleted.
(WebCore::isPunctuationForFirstLetter): Deleted.
(WebCore::shouldSkipForFirstLetter): Deleted.
(WebCore::RenderBlock::updateFirstLetterStyle): Deleted.
(WebCore::RenderBlock::createFirstLetterRenderer): Deleted.
(WebCore::RenderBlock::updateFirstLetter): Deleted.

  • rendering/RenderBlock.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter): Deleted.

  • rendering/RenderRubyRun.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter): Deleted.

  • rendering/RenderTable.h:

Virtual overrides just disabled first letter for some RenderBlock subclasses. This is now achieved via
supportsFirstLetter test in the first letter updater.

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter): Deleted.

  • rendering/svg/RenderSVGText.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

  • style/RenderTreeUpdater.h:
  • style/RenderTreeUpdaterFirstLetter.cpp: Added.

(WebCore::styleForFirstLetter):
(WebCore::isPunctuationForFirstLetter):
(WebCore::shouldSkipForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):
(WebCore::supportsFirstLetter):
(WebCore::RenderTreeUpdater::FirstLetter::update):

  • style/RenderTreeUpdaterFirstLetter.h: Added.
4:38 AM Changeset in webkit [220794] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebDriver

WebDriver: fix return value of close window command
https://bugs.webkit.org/show_bug.cgi?id=174861

Reviewed by Brian Burg.

We are currently returning null, but we should return the list of window handles, and try to close the session
if there aren't more window handles.

10.2 Close Window
https://w3c.github.io/webdriver/webdriver-spec.html#close-window

  1. If there are no more open top-level browsing contexts, then try to close the session.
  2. Return the result of running the remote end steps for the Get Window Handles command.
  • Session.cpp:

(WebDriver::Session::closeAllToplevelBrowsingContexts): Helper function to close the given toplevel browsing
context and the next one if there are more.
(WebDriver::Session::close): Call closeAllToplevelBrowsingContexts() to delete all toplevel browsing contexts of
the session.
(WebDriver::Session::closeTopLevelBrowsingContext): Close the given toplevel browsing context and call
getWindowHandles() when done.
(WebDriver::Session::closeWindow): Call closeTopLevelBrowsingContext() passing the current toplevel browsing context.
(WebDriver::Session::getWindowHandles): Remove the early return, this command doesn't depend on a current
toplevel browsing context.

  • Session.h:
  • SessionHost.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::run): Disconnect the server when main loop quits.
(WebDriver::WebDriverService::deleteSession): Do not fail if the given session is not active.
(WebDriver::WebDriverService::closeWindow): Remove the session if the closed window was the last one.

  • WebDriverService.h: Remove unused quit() method.
  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::isConnected): Return whether host is connected to a browser instance.
(WebDriver::SessionHost::dbusConnectionClosedCallback): Delete m_browser.

4:26 AM Changeset in webkit [220793] by magomez@igalia.com
  • 2 edits in trunk/Source/WebKit

[GTK] Crash of WebProcess with on-demand AC
https://bugs.webkit.org/show_bug.cgi?id=171161

Reviewed by Carlos Garcia Campos.

Set the viewOverlayRootLayer to the previous layerTreeHost if it exists. This avoids a
crash when reusing the previous layerTreeHost, because it would keep a reference to an
already destroyed viewOverlayRootLayer.

  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::attachViewOverlayGraphicsLayer):

4:21 AM Changeset in webkit [220792] by zandobersek@gmail.com
  • 10 edits in trunk/Source/WebKit

[CoordGraphics] Simplify CoordinatedGraphicsScene state updates
https://bugs.webkit.org/show_bug.cgi?id=175528
<rdar://problem/33876795>

Reviewed by Carlos Garcia Campos.

Hold the information about state updates in ThreadedCompositor, in the
m_attributes struct. This way we don't need to store the updates in
functors and accumulate them in the CoordinatedGraphicsScene class, but
instead just apply any pending state update or atlas removal before the
scene is rendered.

This removes the need to update the CoordinatedGraphicsScene object from
the main thread with data that ultimately has to be handled on the
composition thread. Similarly, when updating CoordinatedGraphicsScene, we
only need to synchronize on the m_attributes lock object once in order to
retrieve the scene update information, instead of having each functor do
that repeatedly.

Outside of CoordinatedGraphicsScene and ThreadedCompositor classes, the
CompositingCoordinator class now passes the atlases-to-remove Vector by
a const lvalue reference down to ThreadedCompositor, and then manually
clears the Vector. Before the Vector was passed as an rvalue reference,
depending on the ThreadedCompositor code to clear out the original Vector
object by moving its resources into the functor object. This doesn't occur
anymore because the Vector object is now appended to another Vector.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::applyStateChanges):
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebKit::CoordinatedGraphicsScene::detach):
(WebKit::CoordinatedGraphicsScene::setActive):
(WebKit::CoordinatedGraphicsScene::syncRemoteContent): Deleted.
(WebKit::CoordinatedGraphicsScene::appendUpdate): Deleted.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::releaseAtlases):
(WebKit::CompositingCoordinator::clearUpdateAtlases):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::releaseUpdateAtlases):

  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
3:06 AM Changeset in webkit [220791] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Fix JSCOnly ARM buildbots after r220047 and r220184
https://bugs.webkit.org/show_bug.cgi?id=174993

Reviewed by Carlos Alberto Lopez Perez.

  • CMakeLists.txt: Generate only one backend on Linux to save build time.
1:25 AM Changeset in webkit [220790] by calvaris@igalia.com
  • 5 edits
    2 adds in trunk/Source/WebCore

[GStreamer][EME] Rework handling key systems and UUIDs
https://bugs.webkit.org/show_bug.cgi?id=175567

Reviewed by Žan Doberšek.

The UUIDs and key system strings were moved to the
GStreamerEMEUtilities class because so far they were managed by
the decryptors and that was ugly.

  • platform/GStreamer.cmake:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):

  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.
  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h: Added.

(WebCore::GStreamerEMEUtilities::isClearKeyKeySystem):
(WebCore::GStreamerEMEUtilities::keySystemToUuid):

  • platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_class_init):

  • platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.h:
12:49 AM Changeset in webkit [220789] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220723. rdar://problem/33901127

12:49 AM Changeset in webkit [220788] by jmarcell@apple.com
  • 12 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220286. rdar://problem/33904738

12:34 AM Changeset in webkit [220787] by aestes@apple.com
  • 20 edits in trunk

[Payment Request] Add an ENABLE flag and an experimental feature preference
https://bugs.webkit.org/show_bug.cgi?id=175622

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • page/Settings.in:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPaymentRequestEnabled):
(WKPreferencesGetPaymentRequestEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

Aug 15, 2017:

11:09 PM Changeset in webkit [220786] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] WebKitAutomationSession should set session client to nullptr on dispose
https://bugs.webkit.org/show_bug.cgi?id=175564

Reviewed by Carlos Alberto Lopez Perez.

WebAutomationSession expects its client to be nullptr in the destructor.

  • UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionDispose):

8:52 PM Changeset in webkit [220785] by aestes@apple.com
  • 5 edits
    53 adds in trunk/LayoutTests

[Payment Request] Import test suite from web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=175612
<rdar://problem/33906070>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

Imported the payment-request test suite using import-w3c-tests. Generated failing expected
results for each test and skipped 5 tests that currently time out.

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/payment-request/OWNERS: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/basic.https.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/common.sub.js: Added.

(window.onmessage):
(string_appeared_here.forEach):

  • web-platform-tests/payment-request/allowpaymentrequest/echo-PaymentRequest.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub-expected.txt: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html: Added.
  • web-platform-tests/payment-request/allowpaymentrequest/w3c-import.log: Added.
  • web-platform-tests/payment-request/historical.https-expected.txt: Added.
  • web-platform-tests/payment-request/historical.https.html: Added.
  • web-platform-tests/payment-request/interfaces.https-expected.txt: Added.
  • web-platform-tests/payment-request/interfaces.https.html: Added.
  • web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-abort-method.https.html: Added.
  • web-platform-tests/payment-request/payment-request-canmakepayment-method.https.http: Added.
  • web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-constructor-crash.https.html: Added.
  • web-platform-tests/payment-request/payment-request-constructor.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-constructor.https.html: Added.
  • web-platform-tests/payment-request/payment-request-id.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-id.https.html: Added.
  • web-platform-tests/payment-request/payment-request-in-iframe-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-in-iframe.html: Added.
  • web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https.html: Added.
  • web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https.html: Added.
  • web-platform-tests/payment-request/payment-request-response-id.html: Added.
  • web-platform-tests/payment-request/payment-request-show-method.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-show-method.https.html: Added.
  • web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-update-event-constructor.http.html: Added.
  • web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt: Added.
  • web-platform-tests/payment-request/payment-request-update-event-constructor.https.html: Added.
  • web-platform-tests/payment-request/w3c-import.log: Added.

LayoutTests:

8:06 PM Changeset in webkit [220784] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

WKSnapshotConfiguration is missing from the WebKit umbrella header
https://bugs.webkit.org/show_bug.cgi?id=175614
<rdar://problem/33812691>

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WebKit.h:

Add WKSnapshotConfiguration, which is a public header.

7:49 PM Changeset in webkit [220783] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

We are too conservative about the effects of PushWithScope
https://bugs.webkit.org/show_bug.cgi?id=175584

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

PushWithScope converts its argument to an object (this can throw a type error,
but has no other observable effect), and allocates a new scope, that it then
makes the new current scope. We were a bit too
conservative in saying that it clobbers the world.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

7:23 PM Changeset in webkit [220782] by rniwa@webkit.org
  • 22 edits
    5 adds in trunk

Make DataTransferItemList work with plain text entries
https://bugs.webkit.org/show_bug.cgi?id=175596

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

Added DataTransferItem as a common identifier since it's a runtime enabled feature.

  • runtime/CommonIdentifiers.h:

Source/WebCore:

Added the basic machinery to get the list of plain text items to DataTransferItemList and DataTransferItem.

Each DataTransferItem now depends on DataTransfer so it does ref-forwarding like DataTransferItemList to make
DataTransfer alive as long as any DataTransferItem is alive.

Specifications: https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitem-interface

https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface

Tests: editing/pasteboard/datatransfer-items-drop-plaintext-file.html

editing/pasteboard/datatransfer-items-paste-plaintext.html

  • dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::DataTransferItem): Added two variants one for plain text and another one for a file.
(WebCore::DataTransferItem::kind const): Rewritten.
(WebCore::DataTransferItem::getAsString const): Implemented.
(WebCore::DataTransferItem::getAsFile const): Implemented.

  • dom/DataTransferItem.h:

(WebCore::DataTransferItem::ref): Added.
(WebCore::DataTransferItem::deref): Added.
(WebCore::DataTransferItem::type const): Returns String instead of AtomicString.
(WebCore::DataTransferItem::kind const): Moved to cpp.

  • dom/DataTransferItem.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.
  • dom/DataTransferItemList.cpp:

(WebCore::DataTransferItemList::length): Implemented.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::isSupportedType): Added. For now, we only support text/plain.
(WebCore::DataTransferItemList::ensureItems): Added. Constructs the list of DataTransferItems.

  • dom/DataTransferItemList.h:

(DataTransferItemList): Added m_items. The list is filled lazily by ensureItems.

  • dom/DataTransferItemList.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.

LayoutTests:

Rebaselined the tests and added two regression tests for pasting plain text and dropping a plain text file.

Unfortunately, dropping a file is only supported by DumpRenderTree on Mac :( so it's disabled elsewhere.

  • editing/pasteboard/datatransfer-idl-expected.txt: Rebaselined now that NoInterfaceObject has been dropped from

DataTransferItem.idl and DataTransferItemList.idl as expected.

  • editing/pasteboard/datatransfer-idl.html: Fixed the bug that it wasn't testing IDL for DataTransferItem.
  • editing/pasteboard/datatransfer-items-drop-plaintext-file-expected.txt: Added.
  • editing/pasteboard/datatransfer-items-drop-plaintext-file.html: Added.
  • editing/pasteboard/datatransfer-items-paste-plaintext-expected.txt: Added.
  • editing/pasteboard/datatransfer-items-paste-plaintext.html: Added.
  • editing/resources/text-pasteboard-data.txt: Added.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/ios/TestExpectations:
  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/TestExpectations:
  • platform/wk2/TestExpectations:
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt:
7:05 PM Changeset in webkit [220781] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Remove ScrollView::clipsRepaints() which was only used by Chromium
https://bugs.webkit.org/show_bug.cgi?id=175594

Reviewed by Tim Horton.

clipsRepaints() was added in r74568 but was only used by Chromium. It's always
true for other platforms, so remove conditionals that test for it and assume true.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::setClipsRepaints): Deleted.

  • platform/ScrollView.h:

(WebCore::ScrollView::clipsRepaints const): Deleted.

6:37 PM Changeset in webkit [220780] by Simon Fraser
  • 8 edits in trunk/Source

Allow WebCore logging channels to be set from the UI process
https://bugs.webkit.org/show_bug.cgi?id=175608

Reviewed by Tim Horton.

Source/WebCore:

Change initializeLogChannelsIfNecessary() to take an optional String, which can
be a list of log channels passed from the UI process.

  • platform/LogInitialization.h:
  • platform/Logging.cpp:

(WebCore::initializeLogChannelsIfNecessary):

Source/WebKit:

The UI process can now read the "WebCoreLogging" default, and pass it to the web process
via WebProcessCreationParameters, where WebProcess::platformInitializeWebProcess() uses
it to set up WebCore logging channels. Note that these will override channels read from
the web process user defaults domain (but those are hard to set anyway).

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

6:23 PM Changeset in webkit [220779] by Chris Dumez
  • 11 edits
    2 adds in trunk

Fetch / Beacon: Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=175600

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/beacon/headers/header-content-type-expected.txt:
  • web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
  • web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView in Fetch & Beacon.
If we don't set a Content-Type header, our underlying network stack is going to add a "application/x-www-form-urlencoded"
Content-Type header, which is worse.

Chrome is already using "application/octet-stream" Content-Type in Beacon, but use no Content-Type in Fetch.
The Fetch/Beacon specification says we should have no Content-Type header in this case but this is unfortunately
not something we can support at the moment. Using "application/octet-stream" Content-Type for now seems like the
lesser evil.

Test: http/wpt/fetch/fetch-request-arraybuffer-content-type.html

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

  • platform/network/HTTPHeaderValues.cpp:

(WebCore::HTTPHeaderValues::octetStreamContentType):

  • platform/network/HTTPHeaderValues.h:

LayoutTests:

  • http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt: Added.
  • http/wpt/fetch/fetch-request-arraybuffer-content-type.html: Added.
  • platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
  • platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:
6:10 PM Changeset in webkit [220778] by commit-queue@webkit.org
  • 18 edits in trunk

JSTests:
Support the 'with' keyword in FTL.
https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also improve the JSTest/stress/with.js file to test
what happens when non-objects are passed to with.

  • stress/with.js:

(foo):
(i.catch):
(i.with): Deleted.

Source/JavaScriptCore:
Support the 'with' keyword in FTL
https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also makes sure that the order of arguments of PushWithScope, op_push_with_scope, JSWithScope::create()
and so on is consistent (always parentScope first, the new scopeObject second). We used to go from one
to the other at different step which was quite confusing. I picked this order for consistency with CreateActivation
that takes its parentScope argument first.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPushWithScope):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithScopeExtension):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePushWithScope):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):

  • jit/JITOperations.cpp:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/Completion.cpp:

(JSC::evaluateWithScopeExtension):

  • runtime/JSWithScope.cpp:

(JSC::JSWithScope::create):

  • runtime/JSWithScope.h:

Source/WebCore:
Change the order of arguments of JSWithScope::create() for consistency
https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

No change of behavior.

  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::JSHTMLElement::pushEventHandlerScope const):

5:03 PM Changeset in webkit [220777] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Make VM::scratchBufferForSize thread safe
https://bugs.webkit.org/show_bug.cgi?id=175604

Reviewed by Geoffrey Garen and Mark Lam.

I want to use the VM::scratchBufferForSize in another patch I'm writing.
The use case for my other patch is to call it from the compiler thread.
When reading the code, I saw that this API was not thread safe. This patch
makes it thread safe. It actually turns out we were calling this API from
the compiler thread already when we created FTL::State for an FTL OSR entry
compilation, and from FTLLowerDFGToB3. That code was racy and wrong, but
is now correct with this patch.

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::gatherConservativeRoots):
(JSC::VM::scratchBufferForSize):

  • runtime/VM.h:

(JSC::VM::scratchBufferForSize): Deleted.

5:02 PM Changeset in webkit [220776] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Skipped media/modern-media-controls/time-labels-support/elapsed-time.html.
<rdar://problem/33731086>

Unreviewed test gardening.

  • platform/mac-highsierra/TestExpectations:
4:56 PM Changeset in webkit [220775] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:54 PM Changeset in webkit [220774] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.6

Tag Safari-604.1.38.1.6.

4:48 PM Changeset in webkit [220773] by jfbastien@apple.com
  • 2 edits
    6 adds in trunk/LayoutTests

LayoutTests: test that an XMLHttpRequest with Content-Encoding: gzip is properly decompressed
https://bugs.webkit.org/show_bug.cgi?id=175579

Also test that without Content-Encoding proper sniffing takes place, and gzip
decoding occurs. This test is disabled and tracked by #175597.

Reviewed by Daniel Bates.

  • TestExpectations:
  • http/tests/xmlhttprequest/gzip-content-type-expected.txt: Added.
  • http/tests/xmlhttprequest/gzip-content-type-no-content-encoding-expected.txt: Added.
  • http/tests/xmlhttprequest/gzip-content-type-no-content-encoding.html: Added.
  • http/tests/xmlhttprequest/gzip-content-type.html: Added.
  • http/tests/xmlhttprequest/resources/gzip-lorem-no-content-encoding.php: Added.
  • http/tests/xmlhttprequest/resources/gzip-lorem.php: Added.
4:23 PM Changeset in webkit [220772] by Chris Dumez
  • 32 edits
    1 copy
    30 adds
    4 deletes in trunk/LayoutTests

Re-sync DOM Web-Platform-Tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=175588

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-sync DOM Web-Platform-Tests from upstream b5129e92ce.

  • web-platform-tests/dom/abort/event.any-expected.txt: Added.
  • web-platform-tests/dom/abort/event.any.html: Added.
  • web-platform-tests/dom/abort/event.any.js: Added.
  • web-platform-tests/dom/abort/event.any.worker-expected.txt: Added.
  • web-platform-tests/dom/abort/event.any.worker.html: Added.
  • web-platform-tests/dom/abort/w3c-import.log: Added.
  • web-platform-tests/dom/events/Event-dispatch-click-expected.txt:
  • web-platform-tests/dom/events/Event-dispatch-click.html:
  • web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt: Added.
  • web-platform-tests/dom/events/Event-timestamp-high-resolution.html: Added.
  • web-platform-tests/dom/events/Event-timestamp-safe-resolution-expected.txt: Added.
  • web-platform-tests/dom/events/Event-timestamp-safe-resolution.html: Added.
  • web-platform-tests/dom/events/EventTarget-constructible.any-expected.txt: Added.
  • web-platform-tests/dom/events/EventTarget-constructible.any.html: Added.
  • web-platform-tests/dom/events/EventTarget-constructible.any.js: Added.

(test.listener):
(test):
(test.prototype.on):
(test.prototype.off):
(test.prototype.dispatch):

  • web-platform-tests/dom/events/EventTarget-constructible.any.worker-expected.txt: Added.
  • web-platform-tests/dom/events/EventTarget-constructible.any.worker.html: Added.
  • web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
  • web-platform-tests/dom/events/w3c-import.log:
  • web-platform-tests/dom/interface-objects-expected.txt:
  • web-platform-tests/dom/interface-objects.html:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces.html:
  • web-platform-tests/dom/nodes/Document-constructor-svg.svg: Removed.
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt: Removed.
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html: Removed.
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/w3c-import.log:
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/w3c-import.log:
  • web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
  • web-platform-tests/dom/nodes/Document-createEvent.html:
  • web-platform-tests/dom/nodes/Document-createEvent.js:
  • web-platform-tests/dom/nodes/Element-classlist-expected.txt:
  • web-platform-tests/dom/nodes/Element-classlist.html:
  • web-platform-tests/dom/nodes/Element-matches-init.js: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-matches.html.

(init):

  • web-platform-tests/dom/nodes/Element-matches.html:
  • web-platform-tests/dom/nodes/Element-webkitMatchesSelector.html:
  • web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
  • web-platform-tests/dom/nodes/Node-cloneNode.html:
  • web-platform-tests/dom/nodes/w3c-import.log:
  • web-platform-tests/interfaces/OWNERS: Added.
  • web-platform-tests/interfaces/clipboard.idl: Added.
  • web-platform-tests/interfaces/cssom.idl: Added.
  • web-platform-tests/interfaces/dedicated-workers.idl: Added.
  • web-platform-tests/interfaces/dom.idl: Added.
  • web-platform-tests/interfaces/fullscreen.idl: Added.
  • web-platform-tests/interfaces/geometry.idl: Added.
  • web-platform-tests/interfaces/html.idl: Added.
  • web-platform-tests/interfaces/mediacapture-main.idl: Added.
  • web-platform-tests/interfaces/remoteplayback.idl: Added.
  • web-platform-tests/interfaces/touchevents.idl: Added.
  • web-platform-tests/interfaces/uievents.idl: Added.
  • web-platform-tests/interfaces/web-share.idl: Added.
  • web-platform-tests/interfaces/webrtc-pc.idl: Added.
  • web-platform-tests/interfaces/webusb.idl: Added.

LayoutTests:

  • platform/mac/TestExpectations:
3:58 PM Changeset in webkit [220771] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

undefined URL in PopoverTracker for failed step
https://bugs.webkit.org/show_bug.cgi?id=175593
<rdar://problem/33898769>

Reviewed by Daniel Bates.

This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
(BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults): Accept URL in constructor.

3:54 PM Changeset in webkit [220770] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSC named bytecode offsets should use references rather than pointers
https://bugs.webkit.org/show_bug.cgi?id=175601

Reviewed by Saam Barati.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

3:50 PM Changeset in webkit [220769] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

3:48 PM Changeset in webkit [220768] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.3

Tag Safari-604.2.3.

3:43 PM Changeset in webkit [220767] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175263

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
3:43 PM Changeset in webkit [220766] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:41 PM Changeset in webkit [220765] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.6

Tag Safari-604.1.38.0.6.

3:38 PM Changeset in webkit [220764] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields are set
https://bugs.webkit.org/show_bug.cgi?id=175538

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-15
Reviewed by Chris Dumez.

No change of behavior.
This change ensures that response type is preserved when encoding/decoding ResourceResponse, in particular the error type.
This will allow Cache API to preserve responses when reading them from a different process.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setType):

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::setType):

3:34 PM Changeset in webkit [220763] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fast/images/animated-gif-scrolling-crash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175345.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
3:06 PM Changeset in webkit [220762] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=175592

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:44 PM Changeset in webkit [220761] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/appcache/deferred-events-delete-while-raising-timer.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=87633

Unreviewed test gardening.

2:15 PM Changeset in webkit [220760] by Chris Dumez
  • 28 edits in trunk/Source/WebCore

Update CachedResourceLoader::requestResource() to return a WTF::Expected
https://bugs.webkit.org/show_bug.cgi?id=175505

Reviewed by Youenn Fablet.

Update CachedResourceLoader::requestResource() to return a WTF::Expected
type instead of using an out parameter for the ResourceError in case of
synchronous failure.

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::loadBestFitImage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::loadImage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache):

  • loader/FrameLoader.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::castCachedResourceTo):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::load):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::updateExternalDocument):

  • xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

2:08 PM Changeset in webkit [220759] by don.olmstead@sony.com
  • 19 edits
    8 moves
    1 add in trunk/Source

[PAL] Move Sleep classes into PAL
https://bugs.webkit.org/show_bug.cgi?id=175456

Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests. No change in behavior.

  • CMakeLists.txt:
  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:
  • html/HTMLMediaElement.h:
  • platform/audio/PlatformMediaSessionManager.cpp:
  • platform/audio/PlatformMediaSessionManager.h:
  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/CMakeLists.txt:
  • pal/PlatformMac.cmake:
  • pal/system/SleepDisabler.cpp: Renamed from Source/WebCore/platform/SleepDisabler.cpp.
  • pal/system/SleepDisabler.h: Renamed from Source/WebCore/platform/SleepDisabler.h.
  • pal/system/SystemSleepListener.cpp: Renamed from Source/WebCore/platform/SystemSleepListener.cpp.
  • pal/system/SystemSleepListener.h: Renamed from Source/WebCore/platform/SystemSleepListener.h.
  • pal/system/cocoa/SleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.cpp.
  • pal/system/cocoa/SleepDisablerCocoa.h: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.h.
  • pal/system/mac/SystemSleepListenerMac.h: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.h.
  • pal/system/mac/SystemSleepListenerMac.mm: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.mm.

Source/WebKit:

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

Source/WebKitLegacy/mac:

  • WebView/WebFullScreenController.h:
2:04 PM Changeset in webkit [220758] by commit-queue@webkit.org
  • 58 edits
    3 copies
    3 adds in trunk

[Cache API] Adding generic support for CacheStorage and Cache methods
https://bugs.webkit.org/show_bug.cgi?id=175455

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-15
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

Covered by existing tests.

Adding a CacheStorageProvider abstraction that creates a CacheStorageConnection.
The CacheStorageProvider is accessed from the page for Document calls.
The CacheStorageConnection is responsible to implement the read/write operations on the cache database.
At the moment, it does nothing but return not implemented errors.

Implementing CacheStorage APIs and Cache APIs based on the CacheStorageConnection except for Cache add and addAll which will be implemented later on.
CacheStoragConnection is responsible to read/write CacheStorage list of caches and each individual cache.
The CacheStorageConnection is a generic connection and not tied to any document/context.
CacheStorage objects are manipulated by providing to the connection the origin of the context.
CacheStorage are global to all contexts with the same origin.
Cache objects are manipulated by an ID that is given initially by the CacheStorageEngine when opening the Cache object.

Adding various accessors and constructors for Fetch constructs as needed by the Cache API implementation.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::Cache):
(WebCore::Cache::~Cache):
The CacheStorageConnection is a generic connection and not tied to any document/context.
(WebCore::Cache::match): Implementation of https://www.w3.org/TR/service-workers-1/#cache-match.
Redirect to matchAll as per spec.
(WebCore::Cache::matchAll): Implementation of https://www.w3.org/TR/service-workers-1/#cache-matchAll.
Checks for request as per spec. Then either refresh the request to response map and return all responses.
Or call the query cache algorithm and return copies of the responses (using clone).
(WebCore::Cache::put):
Check the request and response as per spec.
Add temporary rejection cases (being loaded responses, responses with ReadableStream) as there is no support for them right now.
Call the batch put operation.
(WebCore::Cache::remove):
Check the request and response as per spec.
Call the batch delete operation.
(WebCore::Cache::keys):
Refresh the request to response map and return corresponding requests.
Making sure to reuse the same request objects as per spec.
As per spec, the request to response map is ordered. We implement it as a Vector.
(WebCore::Cache::refreshRequestToResponseMap):
Use the cache storage connection to get an up-to-date list of cached records.
(WebCore::Cache::queryCacheMatch):
Implements the match algorithm defined in https://www.w3.org/TR/service-workers-1/#query-cache-algorithm.
This is split for queryCache as cache storage engine will need to use it when implementing the delete operation.
(WebCore::Cache::queryCache):
Full implementation of https://www.w3.org/TR/service-workers-1/#query-cache-algorithm with no targetStorage argument.
(WebCore::Cache::queryCacheWithTargetStorage):
Full implementation of https://www.w3.org/TR/service-workers-1/#query-cache-algorithm with a provided targetStorage argument.
(WebCore::Cache::batchDeleteOperation):
Implementation of https://www.w3.org/TR/service-workers-1/#batch-cache-operations-algorithm but dedicated to a delete operation.
Delete operation are always done one at a time.
(WebCore::Cache::batchPutOperation):
Implementation of https://www.w3.org/TR/service-workers-1/#batch-cache-operations-algorithm dedicated to a put operation.
Put operation takes one record for put but can take several records in the case of addAll, hence the current design.
(WebCore::Cache::updateRequestToResponseMap):
Update the cache request to response map based on the records retrieved from the cache storage connection.

  • Modules/cache/Cache.h:

(WebCore::Cache::create):
(WebCore::Cache::name const):

  • Modules/cache/Cache.idl:
  • Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::origin const):
Computing the cache origin that is passed to the CacheStorageConnection.
(WebCore::CacheStorage::has):
Implementation of https://www.w3.org/TR/service-workers-1/#cache-storage-has.
Call the cache storage connection to refresh its cache map.
Then use it to check whether a cache exists.
(WebCore::CacheStorage::refreshCacheMap):
Use the cache storage connection to get the list of existing caches.
(WebCore::CacheStorage::open):
Implementation of https://www.w3.org/TR/service-workers-1/#cache-storage-open.
Refreshing the cache map so as to return a pre-existing cache if any.
(WebCore::CacheStorage::remove):
Implementation of https://www.w3.org/TR/service-workers-1/#cache-storage-delete-method.
Refreshing the cache map so as to do nothing if there is no cache to remove.
(WebCore::CacheStorage::keys):
Implementation of https://www.w3.org/TR/service-workers-1/#cache-storage-keys-method.
Refreshing the cache map and returnin its keys.
As per spec, the cache map is ordered. We implement it as a Vector.
(WebCore::CacheStorage::cacheMap):
Get the list of cache objects, used as a private accessor for JS built-ins.

  • Modules/cache/CacheStorage.h:

(WebCore::CacheStorage::create):
(WebCore::CacheStorage::CacheStorage):

  • Modules/cache/CacheStorageConnection.cpp: Added.

(WebCore::CacheStorageConnection::exceptionFromError):

  • Modules/cache/CacheStorageConnection.h: Added.

Makes the link between Web facing Cache API and the cache storage engine.
Envisioned implementation are:

  • One main thread connection used by all documents in the given process.
  • One connection per worker that forwards the calls to the main thread and use the main thread connection afterwards.

(WebCore::CacheStorageConnection::create):
(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::refreshCacheMap):
(WebCore::CacheStorageConnection::refreshRequestToResponseMap):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):

  • Modules/cache/CacheStorageRecord.h: Added. A fetch record from the Web facing cache API perspective.
  • Modules/cache/DOMWindowCaches.cpp:

(WebCore::DOMWindowCaches::caches const):

  • Modules/cache/WorkerGlobalScopeCaches.cpp:

(WebCore::WorkerGlobalScopeCaches::from):
(WebCore::WorkerGlobalScopeCaches::caches const):

  • Modules/cache/WorkerGlobalScopeCaches.h:

(WebCore::WorkerGlobalScopeCaches::WorkerGlobalScopeCaches):

  • Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::isReadableStreamBody const): Added getter as it is used by cache API.

  • Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::create): Add another create as used by the cache API.
(WebCore::FetchHeaders::guard const): Added getter and IPC serializer as this is something that will be stored by the cache engine.

  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

  • Modules/fetch/FetchRequest.cpp:

(WebCore::buildOptions): In case FetchRequest::create is called from C++, there is no need to set init.window to a null value.
Add a check so that no value at all is the same as a null/undefined value.
(WebCore::FetchRequest::resourceRequest const):

  • Modules/fetch/FetchRequest.h:
  • Modules/fetch/FetchResponse.h:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

  • page/CacheStorageProvider.h: Added.

Interface to create main thread cache storage connection for the given page.
There will be one provider for each process.
Passing a sessionID so that we will create a connection per session.

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::cacheStorageProvider):

  • page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

  • page/PageConfiguration.h:
  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Cache/WebCacheStorageProvider.h: Added.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::cacheStorageProvider):

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::initWithFrame):

LayoutTests:

  • TestExpectations: Skipping a test that would timeout otherwise due to the current implementation limitations.
1:45 PM Changeset in webkit [220757] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.1-branch/Source/WebCore

Cherry-pick r220723. rdar://problem/33901117

1:41 PM Changeset in webkit [220756] by jmarcell@apple.com
  • 6 edits
    2 adds in branches/safari-604-branch

Cherry-pick r217197. rdar://problem/33890650

1:36 PM Changeset in webkit [220755] by jmarcell@apple.com
  • 6 edits
    2 adds in branches/safari-604.1.38.0-branch

Cherry-pick r217197. rdar://problem/33890636

1:21 PM Changeset in webkit [220754] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests/imported/w3c

WPT harness errors on leaks bot
https://bugs.webkit.org/show_bug.cgi?id=175269

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-15
Reviewed by Alexey Proskuryakov.

To try debugging these errors, let's check whether the WPT server is
sending back resources of the expected size.

  • web-platform-tests/tools/wptserve/wptserve/response.py:

(Response.write_content):
(ResponseWriter.write_content):
(ResponseWriter.write):
(ResponseWriter.write_content_file):

1:13 PM Changeset in webkit [220753] by keith_miller@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Enable named offsets into JSC bytecodes
https://bugs.webkit.org/show_bug.cgi?id=175561

Reviewed by Mark Lam.

This patch adds the ability to add named offsets into JSC's
bytecodes. In the bytecode json file, instead of listing a
length, you can now list a set of names and their types. Each
opcode with an offsets property will have a struct named after the
opcode by in our C++ naming style. For example,
op_overrides_has_instance would become OpOverridesHasInstance. The
struct has the same memory layout as the instruction list has but
comes with handy named accessors.

As a first cut I converted the various instanceof bytecodes to use
named offsets.

As an example op_overrides_has_instance produces the following struct:

struct OpOverridesHasInstance {
public:

Opcode& opcode() { return *reinterpret_cast<Opcode*>(&m_opcode); }
const Opcode& opcode() const { return *reinterpret_cast<const Opcode*>(&m_opcode); }
int& dst() { return *reinterpret_cast<int*>(&m_dst); }
const int& dst() const { return *reinterpret_cast<const int*>(&m_dst); }
int& constructor() { return *reinterpret_cast<int*>(&m_constructor); }
const int& constructor() const { return *reinterpret_cast<const int*>(&m_constructor); }
int& hasInstanceValue() { return *reinterpret_cast<int*>(&m_hasInstanceValue); }
const int& hasInstanceValue() const { return *reinterpret_cast<const int*>(&m_hasInstanceValue); }

private:

friend class LLIntOffsetsExtractor;
std::aligned_storage<sizeof(Opcode), sizeof(Instruction)>::type m_opcode;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_dst;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_constructor;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_hasInstanceValue;

};

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeList.json:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • generate-bytecode-files:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

  • llint/LLIntOffsetsExtractor.cpp:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
1:11 PM Changeset in webkit [220752] by msaboff@apple.com
  • 5 edits
    19 adds in trunk/PerformanceTests

Add Offline Assembler parsing test to RexBench
https://bugs.webkit.org/show_bug.cgi?id=175581

Reviewed by Saam Barati.

This is a port of the JavaScriptCore offline assmebler's lexer, parser, AST and
supporting code from Ruby to JavaScript turned into a benchmark. The benchmark
timing includes parsing through AST. The validation processing time is not
part of the benchmark measurement.

The input data is the current tip of tree LLInt .asm source files. Those file
were converted to JavaScript using the python script, convert_asm_to_js.py.
There is also a new JavaScript file, generate_expected.js, to create the
expected output JavaScript file.

  • RexBench/OfflineAssembler: Added.
  • RexBench/OfflineAssembler/ast.js: Added.
  • RexBench/OfflineAssembler/instructions.js: Added.
  • RexBench/OfflineAssembler/parser.js: Added.
  • RexBench/OfflineAssembler/registers.js: Added.

These are JavaScript translation of the Ruby Offline Assembler. Code not
needed for the benchmark was not translated and therefore missing.

  • RexBench/OfflineAssembler/InitBytecodes.asm: Added.
  • RexBench/OfflineAssembler/InitBytecodes.js: Added.
  • RexBench/OfflineAssembler/LowLevelInterpreter.asm: Added.
  • RexBench/OfflineAssembler/LowLevelInterpreter.js: Added.
  • RexBench/OfflineAssembler/LowLevelInterpreter32_64.asm: Added.
  • RexBench/OfflineAssembler/LowLevelInterpreter32_64.js: Added.
  • RexBench/OfflineAssembler/LowLevelInterpreter64.asm: Added.
  • RexBench/OfflineAssembler/LowLevelInterpreter64.js: Added.

Copies of the current LLInt source and conversion to JavaScript.

  • RexBench/OfflineAssembler/file.js: Added.

(File):
(File.open):
(File.prototype.read):
Mock File class used to simulate filesystem access.

  • RexBench/OfflineAssembler/expected.js: Added.

Expected output of the AST dumped and split into individual lines.

  • RexBench/OfflineAssembler/benchmark.js: Added.

(OfflineAssemblerBenchmark):
(OfflineAssemblerBenchmark.prototype.runOnce):
(OfflineAssemblerBenchmark.prototype.validate):
Benchmark sub class for this test.

  • RexBench/OfflineAssembler/convert_asm_to_js.py: Added.

(convertFile):
Converts .asm into .js files compatible to the benchmark.

  • RexBench/OfflineAssembler/generate_expected.js: Added.

Converts AST output into the expected file format.

  • RexBench/about.html: Added description of this sub-benchmark test.
  • RexBench/cli.js:
  • RexBench/glue.js:
  • RexBench/index.html:
  • RexBench/offline_assembler_benchmark.js: Added.

Updates to add this sub-benchmark.

12:35 PM Changeset in webkit [220751] by Chris Dumez
  • 38 edits
    4 adds in trunk

Implement quota limitation for keepalive Fetch requests
https://bugs.webkit.org/show_bug.cgi?id=175482

Reviewed by Sam Weinig and Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
  • web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Rebaseline tests now that we provide a more helpful error message when rejecting
the fetch() promise.

  • web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:

Rebaseline test for keepalive Fetch requests quota which is now passing.

Source/WebCore:

Implement quota limitation for keepalive Fetch requests as per:

This partly works for Beacon as well, meaning that no Beacon with a body
over 64Kb can be sent. However, we don't keep track about wether or not
beacon loads are inflight or not.

Also update CachedResourceLoader::requestResource() so that the caller
can get a ResourceError when it returns null. This is useful for both
Fetch and Beacon to return better error messages.

Test: http/wpt/beacon/beacon-quota.html

  • CMakeLists.txt:
  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

  • Modules/fetch/FetchLoaderClient.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

  • Modules/fetch/FetchResponse.h:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/KeepaliveRequestTracker.cpp: Added.

(WebCore::KeepaliveRequestTracker::~KeepaliveRequestTracker):
(WebCore::KeepaliveRequestTracker::canLoadRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
(WebCore::KeepaliveRequestTracker::responseReceived):
(WebCore::KeepaliveRequestTracker::notifyFinished):
(WebCore::KeepaliveRequestTracker::unregisterRequest):

  • loader/cache/KeepaliveRequestTracker.h: Added.
  • platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::lengthInBytes const):

  • platform/network/FormData.h:

LayoutTests:

  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • http/tests/contentextensions/async-xhr-onerror-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:

Rebaseline a few tests now that we provide a more helpful error message when an XHR is failing synchronously.

  • http/wpt/beacon/beacon-quota-expected.txt: Added.
  • http/wpt/beacon/beacon-quota.html: Added.

Add layout test coverage for keepalive Fetch requests quota in the context of sendBeacon().
The second part of the test is still failing because WebCore does not currently know when
ping loads (e.g. beacon loads) complete. This will be addressed via Bug 175443.

11:13 AM Changeset in webkit [220750] by Darin Adler
  • 4 edits in trunk

REGRESSION(r220052): http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing.
https://bugs.webkit.org/show_bug.cgi?id=175107

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadComplete): Moved the assertion to after the null page check.

LayoutTests:

10:57 AM Changeset in webkit [220749] by matthew_hanson@apple.com
  • 6 edits
    1 copy
    1 add in branches/safari-604-branch

Cherry-pick r220722. rdar://problem/33890577

10:55 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
10:50 AM Changeset in webkit [220748] by matthew_hanson@apple.com
  • 6 edits
    1 copy
    1 add in branches/safari-604.1.38.0-branch

Cherry-pick r220722. rdar://problem/33890575

10:47 AM Changeset in webkit [220747] by Michael Catanzaro
  • 6 edits
    4 adds in trunk/LayoutTests

Unreviewed GTK test gardening

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Added.
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
10:15 AM Changeset in webkit [220746] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r219504.
https://bugs.webkit.org/show_bug.cgi?id=175580

Broke Arabic text shaping (Requested by mcatanzaro on
#webkit).

Reverted changeset:

"[HarfBuzz] Decomposed Vietnamese characters are rendered
incorrectly"
https://bugs.webkit.org/show_bug.cgi?id=174418
http://trac.webkit.org/changeset/219504

10:05 AM Changeset in webkit [220745] by Ryan Haddad
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Cherry-pick r219572.

9:42 AM Changeset in webkit [220744] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Update testmasm to use new CPUState APIs.
https://bugs.webkit.org/show_bug.cgi?id=175573

Reviewed by Keith Miller.

  1. Applied convenience CPUState accessors to minimize casting.
  2. Converted the CHECK macro to CHECK_EQ to get more friendly failure debugging messages.
  3. Removed the CHECK_DOUBLE_BITWISE_EQ macro. We can just use CHECK_EQ now since casting is (mostly) no longer an issue.
  4. Replaced the use of testDoubleWord(id) with bitwise_cast<double>(testWord64(id)) to make it clear that we're comparing against the bit values of testWord64(id).
  5. Added a "Completed N tests" message at the end of running all tests. This makes it easy to tell at a glance that testmasm completed successfully versus when it crashed midway in a test. The number of tests also serves as a quick checksum to confirm that we ran the number of tests we expected.
  • assembler/testmasm.cpp:

(WTF::printInternal):
(JSC::testSimple):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

8:31 AM Changeset in webkit [220743] by Ryan Haddad
  • 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r219697.

7:16 AM Changeset in webkit [220742] by Michael Catanzaro
  • 5 edits in trunk/Source/WebKit

Unreviewed, rolling out r220700.

Broke debug bot

Reverted changeset:

"[CoordGraphics] Simplify CoordinatedGraphicsScene state
updates"
https://bugs.webkit.org/show_bug.cgi?id=175528
http://trac.webkit.org/changeset/220700

12:17 AM Changeset in webkit [220741] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit

WebDriver: timeout when JavaScript alert is shown in onload handler
https://bugs.webkit.org/show_bug.cgi?id=175315
<rdar://problem/33788294>

Reviewed by Brian Burg.

When a JavaScript alert is shown in an onload handler, the alert prevents the load from finishing in case of
normal page load strategy, so navigation commands or any other command for which we wait for navigation to
complete end up timing out. There are two selenium tests covering this that are currently timing out:
testShouldHandleAlertOnPageLoad and testShouldHandleAlertOnPageLoadUsingGet. The spec says that in case of page
load timeout we should only fail with timeout error when there isn't an active alert dialog. If the next command
expects an alert it will just work, otherwise it will fail with UnexpectedAlertOpen error when trying to handle
user prompts.

9 Navigation.
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-wait-for-navigation-to-complete

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::waitForNavigationToComplete): Do not wait for the timeout when the page is
loading and there's an active alert in case of normal page load strategy.
(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout): Respond with timeout unless
the page is showing a JavaScript dialog.
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout): Ditto.
(WebKit::WebAutomationSession::loadTimerFired): Use respondToPendingPageNavigationCallbacksWithTimeout() and
respondToPendingFrameNavigationCallbacksWithTimeout().
(WebKit::WebAutomationSession::willShowJavaScriptDialog): The page is about to show a JavaScript dialog, so
we wait until the next run loop iteration to give time for the client to show the dialog, then check if page is
loading and the dialog is still present. If that's the case we finish all normal strategy pending navigations.

  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptAlert): If controlled by automation, notify the session.
(WebKit::WebPageProxy::runJavaScriptConfirm): Ditto.
(WebKit::WebPageProxy::runJavaScriptPrompt): Ditto.
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Ditto.

12:03 AM Changeset in webkit [220740] by Carlos Garcia Campos
  • 16 edits in trunk/Source

WebDriver: handle click events on option elements
https://bugs.webkit.org/show_bug.cgi?id=174710
<rdar://problem/33459305>

Reviewed by Brian Burg.

Source/WebCore:

Export WebCore symbols required by WebKit layer.

  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:

Source/WebDriver:

Option elements are considered as a special case by the specification. When clicking an option element, we
should get its container and use it when scrolling into view and calculating in-view center point instead of the
option element itself. Then, we should not emulate a click, but change the selected status of the option element
like if it were done by a user action, firing the corresponding events. Now we check whether the element is an
option to call selectOptionElement() or performMouseInteraction().

This fixes more than 20 selenium tests.

  • CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ElementNotSelectable protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add ElementNotSelectable.
(WebDriver::CommandResult::errorString const): Ditto.

  • CommandResult.h:
  • Session.cpp:

(WebDriver::Session::selectOptionElement): Ask automation to select the given option element.
(WebDriver::Session::elementClick): Call selectOptionElement() or performMouseInteraction() depending on whether
the element is an option or not.

  • Session.h:

Source/WebKit:

Add selectOptionElement method to automation to select an option element according to the WebDriver
specification.

14.1 Element Click.
https://w3c.github.io/webdriver/webdriver-spec.html#element-click

  • UIProcess/Automation/Automation.json: Add selectOptionElement method and ElementNotSelectable error.
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::selectOptionElement):Send SelectOptionElement message to the web process.
(WebKit::WebAutomationSession::didSelectOptionElement): Notify the driver.

  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/Automation/WebAutomationSession.messages.in: Add DidSelectOptionElement message.
  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::elementContainer): Helper to get the container of an element according to the spec.
(WebKit::WebAutomationSessionProxy::computeElementLayout): Use the container element to scroll the view and
compute the in-view center point.
(WebKit::WebAutomationSessionProxy::selectOptionElement): Use HTMLSelectElement::optionSelectedByUser().

  • WebProcess/Automation/WebAutomationSessionProxy.h:
  • WebProcess/Automation/WebAutomationSessionProxy.messages.in: Add SelectOptionElement message.

Aug 14, 2017:

11:51 PM Changeset in webkit [220739] by jmarcell@apple.com
  • 6 edits
    2 deletes in branches/safari-604.1.38.0-branch

Revert r217197. rdar://problem/33890636

11:51 PM Changeset in webkit [220738] by jmarcell@apple.com
  • 5 edits
    3 deletes in branches/safari-604.1.38.0-branch

Revert r220112. rdar://problem/33890629

11:45 PM Changeset in webkit [220737] by jmarcell@apple.com
  • 6 edits
    2 deletes in branches/safari-604-branch

Revert r217197. rdar://problem/33890650

11:45 PM Changeset in webkit [220736] by jmarcell@apple.com
  • 5 edits
    3 deletes in branches/safari-604-branch

Revert r220112. rdar://problem/33890661

9:18 PM Changeset in webkit [220735] by keith_miller@apple.com
  • 30 edits
    1 add in trunk

Add testing tool to lie to the DFG about profiles
https://bugs.webkit.org/show_bug.cgi?id=175487

Reviewed by Saam Barati.

JSTests:

  • stress/compare-eq-incomplete-profile.js: Added.

(const.test.createBuiltin):

Source/JavaScriptCore:

This patch adds a new bytecode identity_with_profile that lets
us lie to the DFG about what profiles it has seen as the input to
another bytecode. Previously, there was no reliable way to force
a given profile when we tired up.

  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/SpeculatedType.cpp:

(JSC::speculationFromString):

  • bytecode/SpeculatedType.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitIdWithProfile):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_idWithProfile):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNode.h:

(JSC::DFG::Node::getForcedPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGValidate.cpp:
  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_identity_with_profile):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_identity_with_profile):

  • llint/LowLevelInterpreter.asm:
8:55 PM WebKitGTK/2.16.x edited by tpopela@redhat.com
(diff)
6:49 PM Changeset in webkit [220734] by Simon Fraser
  • 41 edits
    35 deletes in trunk

Remove Proximity Events and related code
https://bugs.webkit.org/show_bug.cgi?id=175545

Reviewed by Daniel Bates.

No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
and other related code.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • Modules/proximity/DeviceProximityClient.h: Removed.
  • Modules/proximity/DeviceProximityController.cpp: Removed.
  • Modules/proximity/DeviceProximityController.h: Removed.
  • Modules/proximity/DeviceProximityEvent.cpp: Removed.
  • Modules/proximity/DeviceProximityEvent.h: Removed.
  • Modules/proximity/DeviceProximityEvent.idl: Removed.
  • dom/EventNames.h:
  • dom/EventNames.in:
  • history/PageCache.cpp:

(WebCore::canCachePage):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

  • page/DOMWindow.idl:
  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::deviceProximityKey): Deleted.

  • page/DiagnosticLoggingKeys.h:
  • testing/Internals.cpp:

(WebCore::Internals::setDeviceProximity): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

  • UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

Source/WebKit:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.cpp: Removed.
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.h: Removed.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • fast/events/constructors/device-proximity-event-constructor-expected.txt: Removed.
  • fast/events/constructors/device-proximity-event-constructor.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • proximity/add-listener-from-callback-expected.txt: Removed.
  • proximity/add-listener-from-callback.html: Removed.
  • proximity/basic-operation-expected.txt: Removed.
  • proximity/basic-operation.html: Removed.
  • proximity/check-event-deviceproximity-expected.txt: Removed.
  • proximity/check-event-deviceproximity.html: Removed.
  • proximity/create-event-deviceproximity-expected.txt: Removed.
  • proximity/create-event-deviceproximity.html: Removed.
  • proximity/create-event-expected.txt: Removed.
  • proximity/create-event.html: Removed.
  • proximity/event-after-navigation-expected.txt: Removed.
  • proximity/event-after-navigation.html: Removed.
  • proximity/multiple-frames-expected.txt: Removed.
  • proximity/multiple-frames.html: Removed.
  • proximity/no-page-cache-expected.txt: Removed.
  • proximity/no-page-cache.html: Removed.
  • proximity/optional-event-properties-expected.txt: Removed.
  • proximity/optional-event-properties.html: Removed.
  • proximity/resources/cached-page-1.html: Removed.
  • proximity/resources/cached-page-2.html: Removed.
  • proximity/resources/event-after-navigation-new.html: Removed.
  • proximity/updates-expected.txt: Removed.
  • proximity/updates.html: Removed.
  • proximity/window-property-expected.txt: Removed.
  • proximity/window-property.html: Removed.
6:44 PM Changeset in webkit [220733] by Chris Dumez
  • 5 edits
    115 adds in trunk/LayoutTests

Import eventsource Web-Platform-Tests
https://bugs.webkit.org/show_bug.cgi?id=175556

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/eventsource/OWNERS: Added.
  • web-platform-tests/eventsource/README.md: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-close-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-close.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-url-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-constructor-url-bogus.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-eventtarget.worker-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-eventtarget.worker.html: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-eventtarget.worker.js: Added.

(async_test):

  • web-platform-tests/eventsource/dedicated-worker/eventsource-onmesage-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onmesage.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onopen-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-onopen.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-prototype-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-prototype.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-url-expected.txt: Added.
  • web-platform-tests/eventsource/dedicated-worker/eventsource-url.htm: Added.
  • web-platform-tests/eventsource/dedicated-worker/w3c-import.log: Added.
  • web-platform-tests/eventsource/event-data-expected.txt: Added.
  • web-platform-tests/eventsource/event-data.html: Added.
  • web-platform-tests/eventsource/eventsource-close-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-close.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-document-domain-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-document-domain.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-non-same-origin.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-stringify-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-stringify.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-bogus.htm: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-multi-window-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-constructor-url-multi-window.htm: Added.
  • web-platform-tests/eventsource/eventsource-eventtarget-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-eventtarget.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-realm-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-realm-support.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-realm.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-trusted-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onmessage-trusted.htm: Added.
  • web-platform-tests/eventsource/eventsource-onmessage.htm: Added.
  • web-platform-tests/eventsource/eventsource-onopen-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-onopen.htm: Added.
  • web-platform-tests/eventsource/eventsource-prototype-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-prototype.htm: Added.
  • web-platform-tests/eventsource/eventsource-reconnect-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-reconnect.htm: Added.
  • web-platform-tests/eventsource/eventsource-url-expected.txt: Added.
  • web-platform-tests/eventsource/eventsource-url.htm: Added.
  • web-platform-tests/eventsource/format-bom-2-expected.txt: Added.
  • web-platform-tests/eventsource/format-bom-2.htm: Added.
  • web-platform-tests/eventsource/format-bom-expected.txt: Added.
  • web-platform-tests/eventsource/format-bom.htm: Added.
  • web-platform-tests/eventsource/format-comments-expected.txt: Added.
  • web-platform-tests/eventsource/format-comments.htm: Added.
  • web-platform-tests/eventsource/format-data-before-final-empty-line-expected.txt: Added.
  • web-platform-tests/eventsource/format-data-before-final-empty-line.htm: Added.
  • web-platform-tests/eventsource/format-field-data-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-data.htm: Added.
  • web-platform-tests/eventsource/format-field-event-empty-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-event-empty.htm: Added.
  • web-platform-tests/eventsource/format-field-event-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-event.htm: Added.
  • web-platform-tests/eventsource/format-field-id-2-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-id-2.htm: Added.
  • web-platform-tests/eventsource/format-field-id-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-id.htm: Added.
  • web-platform-tests/eventsource/format-field-parsing-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-parsing.htm: Added.
  • web-platform-tests/eventsource/format-field-retry-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-retry-bogus.htm: Added.
  • web-platform-tests/eventsource/format-field-retry-empty-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-retry-empty.htm: Added.
  • web-platform-tests/eventsource/format-field-retry-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-retry.htm: Added.
  • web-platform-tests/eventsource/format-field-unknown-expected.txt: Added.
  • web-platform-tests/eventsource/format-field-unknown.htm: Added.
  • web-platform-tests/eventsource/format-leading-space-expected.txt: Added.
  • web-platform-tests/eventsource/format-leading-space.htm: Added.
  • web-platform-tests/eventsource/format-mime-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/format-mime-bogus.htm: Added.
  • web-platform-tests/eventsource/format-mime-trailing-semicolon-expected.txt: Added.
  • web-platform-tests/eventsource/format-mime-trailing-semicolon.htm: Added.
  • web-platform-tests/eventsource/format-mime-valid-bogus-expected.txt: Added.
  • web-platform-tests/eventsource/format-mime-valid-bogus.htm: Added.
  • web-platform-tests/eventsource/format-newlines-expected.txt: Added.
  • web-platform-tests/eventsource/format-newlines.htm: Added.
  • web-platform-tests/eventsource/format-null-character-expected.txt: Added.
  • web-platform-tests/eventsource/format-null-character.html: Added.
  • web-platform-tests/eventsource/format-utf-8-expected.txt: Added.
  • web-platform-tests/eventsource/format-utf-8.htm: Added.
  • web-platform-tests/eventsource/interfaces-expected.txt: Added.
  • web-platform-tests/eventsource/interfaces.html: Added.
  • web-platform-tests/eventsource/request-accept-expected.txt: Added.
  • web-platform-tests/eventsource/request-accept.htm: Added.
  • web-platform-tests/eventsource/request-redirect-expected.txt: Added.
  • web-platform-tests/eventsource/request-redirect.htm: Added.
  • web-platform-tests/eventsource/request-status-error-expected.txt: Added.
  • web-platform-tests/eventsource/request-status-error.htm: Added.
  • web-platform-tests/eventsource/resources/accept.event_stream: Added.
  • web-platform-tests/eventsource/resources/cache-control.event_stream: Added.
  • web-platform-tests/eventsource/resources/cors-cookie.py: Added.

(main):

  • web-platform-tests/eventsource/resources/cors.py: Added.

(run_other):
(main):

  • web-platform-tests/eventsource/resources/init.htm: Added.
  • web-platform-tests/eventsource/resources/last-event-id.py: Added.

(main):

  • web-platform-tests/eventsource/resources/message.py: Added.

(main):

  • web-platform-tests/eventsource/resources/message2.py: Added.

(main):

  • web-platform-tests/eventsource/resources/reconnect-fail.py: Added.

(main):

  • web-platform-tests/eventsource/resources/status-error.py: Added.

(main):

  • web-platform-tests/eventsource/resources/status-reconnect.py: Added.

(main):

  • web-platform-tests/eventsource/resources/w3c-import.log: Added.
  • web-platform-tests/eventsource/w3c-import.log: Added.

LayoutTests:

  • tests-options.json:
6:39 PM Changeset in webkit [220732] by Simon Fraser
  • 27 edits
    6 deletes in trunk

Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
https://bugs.webkit.org/show_bug.cgi?id=175504

Reviewed by Sam Weinig.
Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

REQUEST_AUTOCOMPLETE was added in r133396 then removed in r148731, but brought back in r173596,
however no further work was done, and it was left disabled. So remove the code.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/AutocompleteErrorEvent.h: Removed.
  • dom/AutocompleteErrorEvent.idl: Removed.
  • dom/EventNames.in:
  • dom/GlobalEventHandlers.idl:
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocomplete): Deleted.
(WebCore::HTMLFormElement::finishRequestAutocomplete): Deleted.
(WebCore::HTMLFormElement::requestAutocompleteTimerFired): Deleted.

  • html/HTMLFormElement.h:
  • html/HTMLFormElement.idl:
  • loader/EmptyClients.cpp:
  • loader/FrameLoaderClient.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didRequestAutocomplete): Deleted.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:
  • DOM/DOMHTMLFormElement.mm:

(-[DOMHTMLFormElement requestAutocomplete]): Deleted.

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
6:36 PM Changeset in webkit [220731] by Chris Dumez
  • 26 edits
    2 copies in trunk

XHR should only fire an abort event if the cancellation was requested by the client
https://bugs.webkit.org/show_bug.cgi?id=175546

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that a different error is sometimes used and that
more checks are passing.

  • web-platform-tests/XMLHttpRequest/open-url-multi-window-4-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt:
  • web-platform-tests/cors/allow-headers-expected.txt:
  • web-platform-tests/cors/origin-expected.txt:
  • web-platform-tests/cors/request-headers-expected.txt:
  • web-platform-tests/cors/response-headers-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_match_origin-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_match_wildcard-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_multi-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_null-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_origin-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_origin_uppercase-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_space-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_wildcard-expected.txt:
  • web-platform-tests/resource-timing/resource_TAO_zero-expected.txt:

Source/WebCore:

XHR should only fire an abort event if the cancellation was requested by the client, otherwise it should fire an error event.
Blink and Gecko already match the specification.

Specification:

Test: http/tests/navigation/page-cache-xhr-in-pagehide.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::abortError):
(WebCore::XMLHttpRequest::didFail):

  • xml/XMLHttpRequest.h:

LayoutTests:

  • http/tests/navigation/page-cache-xhr-expected.txt:
  • http/tests/navigation/page-cache-xhr-in-pagehide-expected.txt: Copied from LayoutTests/http/tests/navigation/page-cache-xhr-expected.txt.
  • http/tests/navigation/page-cache-xhr-in-pagehide.html: Copied from LayoutTests/http/tests/navigation/page-cache-xhr.html.
  • http/tests/navigation/page-cache-xhr.html:

When an XHR is pending and navigating away, we would send an abort event before the navigation and an error event after
restoring from PageCache. This bug was not seen before because the test only checked for error events, not abort ones.
The expected behavior is now that we fire an error event before navigating away, similar to the non-PageCache case.
The only case where the error event should be fired after restoring from PageCache is when an XHR is done in the pagehide
event handler, because it is too late to send the error event to the page before navigating in this case. I added test
coverage for this case.

  • http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
  • http/tests/xmlhttprequest/navigation-should-abort.html:

This test was expecting an abort event on navigation which is against spec. This test was failing in Blink too.
Update the test to expect an error event instead.

5:53 PM Changeset in webkit [220730] by Simon Fraser
  • 37 edits
    12 deletes in trunk

Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
https://bugs.webkit.org/show_bug.cgi?id=175557

Reviewed by Jon Lee.
.:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:
  • css/CSSValueKeywords.in:
  • css/MediaFeatureNames.h:
  • css/MediaQueryEvaluator.cpp:

(WebCore::viewModeEvaluate): Deleted.

  • css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent):
(WebCore::isFeatureValidWithoutValue):

  • page/Page.cpp:

(WebCore::Page::stringToViewMode): Deleted.
(WebCore::Page::setViewMode): Deleted.

  • page/Page.h:

(WebCore::Page::viewMode const): Deleted.

Source/WebCore/PAL:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • wtf/FeatureDefines.h:

Tools:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setViewModeMediaFeatureCallback): Deleted.

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setViewModeMediaFeature): Deleted.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setViewModeMediaFeature): Deleted.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

  • fast/media/media-query-list-02-expected.txt: Removed.
  • fast/media/media-query-list-02.html: Removed.
  • fast/media/media-query-list-03-expected.txt: Removed.
  • fast/media/media-query-list-03.html: Removed.
  • fast/media/media-query-list-04-expected.txt: Removed.
  • fast/media/media-query-list-04.html: Removed.
  • fast/media/media-query-list-05-expected.txt: Removed.
  • fast/media/media-query-list-05.html: Removed.
  • fast/media/media-query-list-06-expected.txt: Removed.
  • fast/media/media-query-list-06.html: Removed.
  • fast/media/view-mode-media-feature-expected.html: Removed.
  • fast/media/view-mode-media-feature.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
5:44 PM Changeset in webkit [220729] by Ryan Haddad
  • 1 edit
    1 delete in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed test gardening, remove unneeded expected.txt file.

  • platform/mac-highsierra/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Removed.
5:36 PM Changeset in webkit [220728] by Ryan Haddad
  • 1 edit
    2 adds in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220727.

5:33 PM Changeset in webkit [220727] by Ryan Haddad
  • 1 edit
    2 adds in trunk/LayoutTests

Rebaseline editing/mac/input/firstrectforcharacterrange-styled.html.

Unreviewed test gardening.

  • platform/mac-highsierra/editing/mac/input/firstrectforcharacterrange-styled-expected.txt: Added.
5:30 PM Changeset in webkit [220726] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
5:03 PM Changeset in webkit [220725] by mmaxfield@apple.com
  • 12 edits
    3 adds in trunk

Parse font-display
https://bugs.webkit.org/show_bug.cgi?id=175382

Reviewed by Simon Fraser.

Source/WebCore:

The syntax is very simple: font-display: auto | block | swap | fallback | optional.
So, parsing support is quite straightfoward.

Test: fast/text/font-display/parse.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::setLoadingBehavior):

  • css/CSSFontFace.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontLoadingBehavior const):

  • css/CSSProperties.json:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isDescriptorOnly):

  • css/CSSValueKeywords.in:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontFaceFontDisplay):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):

  • rendering/style/RenderStyleConstants.h:

LayoutTests:

  • fast/text/font-display/parse-expected.txt: Added.
  • fast/text/font-display/parse.html: Added.
4:37 PM Changeset in webkit [220724] by commit-queue@webkit.org
  • 17 edits
    1 add in trunk

JSTests:
Support the with keyword in DFG
https://bugs.webkit.org/show_bug.cgi?id=175470

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-14
Reviewed by Saam Barati.

Added a new stress-test for the 'with' keyword, that caught a bug in a
previous version of this code.

  • stress/with.js: Added.

(i.with):

Source/JavaScriptCore:
Support the 'with' keyword in DFG
https://bugs.webkit.org/show_bug.cgi?id=175470

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-14
Reviewed by Saam Barati.

Not particularly optimized at the moment, the goal is just to avoid
the DFG bailing out of any function with this keyword.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePushWithScope):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
4:33 PM Changeset in webkit [220723] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Obj-C exception crash in AVStreamSession when using EME in Private Browsing mode
https://bugs.webkit.org/show_bug.cgi?id=175547

Reviewed by Eric Carlson.

When the storagePath() is empty, do not use those AVStreamSession APIs which require a valid file path to stored
proof-of-key-release data.

Drive-by fix: return emptyString() from HTMLMediaElement::mediaPlayerMediaKeysStorageDirectory() when in Private
Browsing mode, to match the behavior of WebKitMediaKeySession.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerMediaKeysStorageDirectory const):

  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::releaseKeys):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):

4:21 PM Changeset in webkit [220722] by aestes@apple.com
  • 6 edits
    1 copy
    1 add in trunk

REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
https://bugs.webkit.org/show_bug.cgi?id=175548
<rdar://problem/33866206>

Reviewed by Brady Eidson.

Source/WebCore:

New API test: QuickLook.ShouldCreateForMIMEType

  • WebCore.xcodeproj/project.pbxproj:
  • loader/ios/PreviewLoader.h:
  • loader/ios/PreviewLoader.mm:

(WebCore::PreviewLoader::shouldCreateForMIMEType): Check if mimeType is a null String before
calling HashSet::contains().

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.

(TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().

4:04 PM Changeset in webkit [220721] by Ryan Haddad
  • 2 edits in trunk/JSTests

Skip flaky JSC test test/fieldopts/objtypespec-newobj-invalidation.1.js
https://bugs.webkit.org/show_bug.cgi?id=175544

Unreviewed test gardening.

  • ChakraCore.yaml:
3:55 PM Changeset in webkit [220720] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add some convenience utility accessor methods to MacroAssembler::CPUState.
https://bugs.webkit.org/show_bug.cgi?id=175549
<rdar://problem/33884868>

Reviewed by Saam Barati.

Previously, in order to read ProbeContext CPUState registers, we used to need to
do it this way:

ExecState* exec = reinterpret_cast<ExecState*>(cpu.fp());
uint32_t i32 = static_cast<uint32_t>(cpu.gpr(GPRInfo::regT0));
void* p = reinterpret_cast<void*>(cpu.gpr(GPRInfo::regT1));
uint64_t u64 = bitwise_cast<uint64_t>(cpu.fpr(FPRInfo::fpRegT0));

With this patch, we can now read them this way instead:

ExecState* exec = cpu.fp<ExecState*>();
uint32_t i32 = cpu.gpr<uint32_t>(GPRInfo::regT0);
void* p = cpu.gpr<void*>(GPRInfo::regT1);
uint64_t u64 = cpu.fpr<uint64_t>(FPRInfo::fpRegT0);

  • assembler/MacroAssembler.h:

(JSC:: const):
(JSC::MacroAssembler::CPUState::fpr const):
(JSC::MacroAssembler::CPUState::pc const):
(JSC::MacroAssembler::CPUState::fp const):
(JSC::MacroAssembler::CPUState::sp const):
(JSC::ProbeContext::pc):
(JSC::ProbeContext::fp):
(JSC::ProbeContext::sp):

3:38 PM Changeset in webkit [220719] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

WPT server should be able to do logging even if its output folder is not created at launch time
https://bugs.webkit.org/show_bug.cgi?id=175543

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-14
Reviewed by Alexey Proskuryakov.

Removing no longer used stdout/stderr member variables.
Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init):
(WebPlatformTestServer._prepare_config):
(WebPlatformTestServer._spawn_process):
(WebPlatformTestServer._stop_running_server):

3:04 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
Add ms2ger and aboya (diff)
3:03 PM Changeset in webkit [220718] by aestes@apple.com
  • 19 edits in trunk

[Apple Pay] Add support for phonetic contact names
https://bugs.webkit.org/show_bug.cgi?id=175537
<rdar://problem/32002644>

Reviewed by Tim Horton.

Source/WebCore:

  • Modules/applepay/ApplePayError.idl: Defined "phoneticName" in ApplePayErrorContactField.
  • Modules/applepay/ApplePayPaymentContact.h: Defined phoneticGivenName and phoneticFamilyName

in ApplePayPaymentContact.

  • Modules/applepay/ApplePayPaymentContact.idl: Ditto.
  • Modules/applepay/ApplePayPaymentRequest.h: Defined PhoneticName in

ApplePayPaymentRequest::ContactField.

  • Modules/applepay/ApplePayPaymentRequest.idl: Defined "phoneticName" in ApplePayContactField.
  • Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate): Added a version parameter. Added code to convert
ContactField::PhoneticName, throwing an exception if version is less than 3.

  • Modules/applepay/PaymentContact.h: Added a version parameter to fromApplePayPaymentContact().
  • Modules/applepay/PaymentRequest.h: Defined phoneticName in PaymentRequest::ContactFields

and defined PhoneticName in PaymentError::ContactField.

  • Modules/applepay/cocoa/PaymentContactCocoa.mm:

(WebCore::convert): Added a version parameter. Set a phoneticRepresentation on the
PKContact's name if there are non-empty phonetic names and version is 3 or greater.
(WebCore::PaymentContact::fromApplePayPaymentContact): Passed version to convert().

Source/WebKit:

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: Soft-linked PKContactFieldPhoneticName.

(WebKit::toPKContactFields): Added code to append PKContactFieldPhoneticName to result if
contactFields.phoneticName is true.
(WebKit::toNSError): Specified PKContactFieldPhoneticName as the contact field for
PaymentError::ContactField::PhoneticName.

LayoutTests:

  • http/tests/ssl/applepay/ApplePayError-expected.txt:
  • http/tests/ssl/applepay/ApplePayError.html:
  • http/tests/ssl/applepay/ApplePaySession-expected.txt:
  • http/tests/ssl/applepay/ApplePaySession.html:
  • http/tests/ssl/applepay/ApplePaySessionV3-expected.txt:
  • http/tests/ssl/applepay/ApplePaySessionV3.html:
3:00 PM Changeset in webkit [220717] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

The none smooth stroke applied to an SVG shape breaks its hit testing
https://bugs.webkit.org/show_bug.cgi?id=175506

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-14
Reviewed by Simon Fraser.

Source/WebCore:

Clear RenderSVGShape::m_path when calling RenderSVGRect::updateShapeFromElement().
The m_path will be recalculated when RenderSVGShape::updateShapeFromElement()
is called from RenderSVGRect::shapeDependentStrokeContains().

Test: svg/stroke/stroke-linejoin-click.html

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::clearPath):

LayoutTests:

  • svg/stroke/stroke-linejoin-click-expected.html: Added.
  • svg/stroke/stroke-linejoin-click.html: Added.
2:28 PM Changeset in webkit [220716] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
2:14 PM Changeset in webkit [220715] by dbates@webkit.org
  • 9 edits
    1 add in trunk/Tools

webkit-patch: Passing --no-review should submit patch to EWS by default
https://bugs.webkit.org/show_bug.cgi?id=148899

Reviewed by David Kilzer.

Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
to these commands to not submit a non-reviewed patch(es) for EWS analysis.

Frequently I want to post a draft of a patch without review to have the EWS bots process
it to catch build and test breakage before I clean it up and post it for formal review.
Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
parse the attachment id from the response page after adding an attachment to the bug.
(Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
HTTP response after uploading the patch.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(testparse_attachment_id_from_add_patch_to_bug_response): Added.

  • Scripts/webkitpy/tool/commands/upload.py:

(Upload): Add step SubmitToEWS to the list of steps when uploading a patch.
(PostCommits.init): Add --no-ews option to the list of applicable option flags for
this command.
(PostCommits.execute): Submit the patch to EWS, if applicable.

  • Scripts/webkitpy/tool/commands/upload_unittest.py:

(test_upload): Set options.ews to False as the upload command expects this option
to be specified.
(test_upload_with_no_review_and_ews): Added.

  • Scripts/webkitpy/tool/steps/init.py: Import module SubmitToEWS.
  • Scripts/webkitpy/tool/steps/options.py:

(Options): Added command line option --no-ews (defaults: False - submit to EWS).

  • Scripts/webkitpy/tool/steps/postdiff.py:

(PostDiff.options): Add --no-ews option to the list of applicable option flags for
this command.
(PostDiff.run): Submit the patch to EWS, if applicable.

  • Scripts/webkitpy/tool/steps/submittoews.py: Added.

(SubmitToEWS):
(SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
(SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.

12:28 PM Changeset in webkit [220714] by dbates@webkit.org
  • 3 edits in trunk/LayoutTests

[css-ui] Implement caret-color support
https://bugs.webkit.org/show_bug.cgi?id=166572
<rdar://problem/33852589>

Update GTK expected results following r220706.

  • platform/gtk/editing/style/5065910-expected.txt:
  • platform/gtk/editing/style/5084241-expected.txt:
11:42 AM Changeset in webkit [220713] by Adrian Perez de Castro
  • 5 edits in trunk

[WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507

Reviewed by Michael Catanzaro.

Remove "_GLIB" from user-agent version macros.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Source/WebCore:

  • platform/glib/UserAgentGLib.cpp:

(WebCore::versionForUAString):

11:33 AM Changeset in webkit [220712] by fpizlo@apple.com
  • 12 edits
    1 add in trunk/Source

Put the ScopedArgumentsTable's ScopeOffset array in some gigacage
https://bugs.webkit.org/show_bug.cgi?id=174921

Reviewed by Mark Lam.

Source/JavaScriptCore:

Uses CagedUniquePtr<> to cage the ScopeOffset array.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitScopedArgumentsGetByVal):

  • runtime/ScopedArgumentsTable.cpp:

(JSC::ScopedArgumentsTable::create):
(JSC::ScopedArgumentsTable::setLength):

  • runtime/ScopedArgumentsTable.h:

Source/WTF:

If you want to std::unique_ptr a class that knows that it should be in the Gigacage, then we
would create the Gigacage equivalent of WTF_MAKE_FAST_ALLOCATED and it would just work.

But this does not work if we want to std::unique_ptr a primitive type. So, this patch adds a
solution for this problem: CagedUniquePtr<>. This will handle allocation
(CagedUniquePtr<>::create()) and deallocation (in the style of std::unique_ptr). It has three
variants:

  • Non-array types.
  • Arrays that don't have destructors.
  • Arrays that have destructors.


Just like std::unique_ptr, the array case is triggered by saying "[]" at the end of the type.

Unlike std::unique_ptr and most other smart pointers, the whole point of this smart pointer is
to dictate where the thing you're pointing at is allocated. For this reason, it has to know how
to do things like the array destructor protocol. So it creates its own: the CagedUniquePtr for
arrays with destructors is a fat pointer that remembers the length of the array.

CagedUniquePtr<> makes it impossible to leak/release the pointer. This is stricter than what
std::unique_ptr does, and is probably appropriate for all of the places where we would use this
type.

So far, we only use it for ScopedArgumentsTable::m_arguments, but I suspect that it will be
useful in other places.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/CagedUniquePtr.h: Added.

(WTF::CagedUniquePtr::CagedUniquePtr):
(WTF::CagedUniquePtr::create):
(WTF::CagedUniquePtr::operator=):
(WTF::CagedUniquePtr::~CagedUniquePtr):
(WTF::CagedUniquePtr::get const):
(WTF::CagedUniquePtr::getMayBeNull const):
(WTF::CagedUniquePtr::operator== const):
(WTF::CagedUniquePtr::operator!= const):
(WTF::CagedUniquePtr::operator bool const):
(WTF::CagedUniquePtr::operator* const):
(WTF::CagedUniquePtr::operator-> const):
(WTF::CagedUniquePtr::operator[] const):
(WTF::CagedUniquePtr::destroy):

  • wtf/Gigacage.cpp:

(Gigacage::tryMallocArray):
(Gigacage::malloc):
(Gigacage::mallocArray):

  • wtf/Gigacage.h:
11:32 AM Changeset in webkit [220711] by Ryan Haddad
  • 2 edits in trunk/Tools

Disable two flaky VideoControlsManager API tests.

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:

(TestWebKitAPI::TEST):

10:56 AM Changeset in webkit [220710] by Matt Baker
  • 14 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove text-shadow and gradient backgrounds
https://bugs.webkit.org/show_bug.cgi?id=175430

Reviewed by Brian Burg.

Inspector should more closely match flat system look. Remove text-shadow
embossing and replace linear gradients in popover backgrounds and selected
tree item background color.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content > .pseudo-classes > .group > label):

  • UserInterface/Views/CompletionSuggestionsView.css:

(.completion-suggestions-container:not(:active) > .item.selected,):

  • UserInterface/Views/DebuggerDashboardView.css:

(.toolbar .dashboard.debugger):

  • UserInterface/Views/HierarchicalPathComponent.css:

(.hierarchical-path-component > .title):

  • UserInterface/Views/Main.css:

(.bouncy-highlight):

  • UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .content .empty-content-placeholder > .message):

  • UserInterface/Views/Popover.js:

(WI.Popover.prototype._drawBackground):

  • UserInterface/Views/RecordingTraceDetailsSidebarPanel.css:

(.sidebar > .details.recording-trace > .content > .no-trace-data > .message):

  • UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style .rules .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results > .no-filter-results-message):
(@media (-webkit-min-device-pixel-ratio: 2)): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label,): Deleted.

  • UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css:

(.style-spreadsheet .inherited):

  • UserInterface/Views/TimelineDataGrid.css:

(.tree-outline.timeline-data-grid .item:hover):

  • UserInterface/Views/TimelineDataGrid.js:

(WI.TimelineDataGrid.prototype._createPopoverContent):

  • UserInterface/Views/Variables.css:

(:root):

10:56 AM Changeset in webkit [220709] by timothy_horton@apple.com
  • 4 edits
    1 add in trunk

Only create directory and sandbox extension handle for storage directories if they are set
https://bugs.webkit.org/show_bug.cgi?id=175522

Reviewed by Brady Eidson.

Source/WebKit:

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
If using a non-persistent WebsiteDataStore, all the storage directories
are unset, but we still try to create them and make sandbox extensions
for them. This has no effect except a ton of noisy logging, but that
is reason enough to stop.

This is similar to r216053, but for more directories.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.

(TEST):
Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
doesn't log anything to stderr.

10:44 AM Changeset in webkit [220708] by Jonathan Bedard
  • 4 edits in trunk/Tools

sub-categorize Sandbox violation logs
https://bugs.webkit.org/show_bug.cgi?id=175536
<rdar://problem/33834416>

Reviewed by David Kilzer.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
a Sandbox violation.
(CrashLogs._find_all_logs_darwin): Update comment.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing.
(CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
(CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
(CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.

  • Scripts/webkitpy/port/darwin.py:

(DarwinPort._merge_crash_logs): Handle Sandbox violation case.

10:42 AM Changeset in webkit [220707] by Chris Dumez
  • 38 edits
    4 deletes in trunk

Unreviewed, rollout r220622 & r220696
https://bugs.webkit.org/show_bug.cgi?id=175482
<rdar://problem/33860695>

Seems to have caused failures on iOS.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
  • web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:
  • web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Source/WebCore:

  • CMakeLists.txt:
  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

  • Modules/fetch/FetchLoaderClient.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

  • Modules/fetch/FetchResponse.h:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::finishLoading):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/KeepaliveRequestTracker.cpp: Removed.
  • loader/cache/KeepaliveRequestTracker.h: Removed.
  • platform/network/FormData.cpp:

(WebCore::FormData::appendFile):
(WebCore::FormData::appendFileRange):
(WebCore::FormData::appendBlob):
(WebCore::FormData::expandDataStore):

  • platform/network/FormData.h:

LayoutTests:

  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • http/tests/contentextensions/async-xhr-onerror-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:
  • http/wpt/beacon/beacon-quota-expected.txt: Removed.
  • http/wpt/beacon/beacon-quota.html: Removed.
  • inspector/worker/resources-in-worker-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/fetch/http-cache/cc-request-expected.txt:
10:29 AM Changeset in webkit [220706] by dbates@webkit.org
  • 28 edits
    14 adds in trunk

[css-ui] Implement caret-color support
https://bugs.webkit.org/show_bug.cgi?id=166572
<rdar://problem/33852589>

Reviewed by David Hyatt.

Source/WebCore:

Add support for the CSS property caret-color as per <https://www.w3.org/TR/css-ui-3/#caret-color> (02 March 2017).
The property caret-color specifies the color of the text insertion caret in an editable element,
say an HTML textarea element.

Unlike other CSS color properties caret-color can have value "auto" and this is its initial
value. Internally we treat value "auto" as an invalid caret color to simplify the code.

Tests: editing/pasteboard/preserve-caret-color.html

fast/css/caret-color-auto.html
fast/css/caret-color-fallback-to-color.html
fast/css/caret-color-inherit.html
fast/css/caret-color-span-inside-editable-parent.html
fast/css/caret-color.html
fast/history/visited-link-caret-color.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSProperties.json: Add property caret-color. We represent the initial "auto" Also, fix up

wording in a comment while I am here.

  • css/StyleResolver.cpp:

(WebCore::isValidVisitedLinkProperty): Add caret-color to the list of properties that can be
applied to visited hyperlinks.

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::parseCaretColor): Added.
(WebCore::CSSParserFastPaths::maybeParseValue): Unlike other CSS color properties caret-color
can be defined to be "auto". We explicitly check if the property is caret-color and use
parseCaretColor() to parse its value.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::consumeCaretColor): Added.
(WebCore::CSSPropertyParser::parseSingleValue): Similar to the change to CSSParserFastPaths::maybeParseValue()
use a dedicated code path to parse caret-color.

  • editing/EditingStyle.cpp: Preserve caret-color during editing operations.
  • editing/FrameSelection.cpp:

(WebCore::CaretBase::paintCaret const): Modified code to query property caret-color instead of
color for the color of the text insertion caret. Always honor the caret-color of the editable
element if it is valid color. Note that "caret-color: auto" is treated as an invalid color
internally. A caret-color can have an invalid color if its inherits from the CSS color property
with an invalid color. If caret-color is a valid color then we take it to be the color of the
text insertion caret. Otherwise, we do what we do today and use a heuristic to determine the
color of the text-insertion caret.
(WebCore::disappearsIntoBackground): Deleted; moved logic into CaretBase::paintCaret().

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): Add property wrapper
to support animating caret-color.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline const): Modified to consider
changes to caret color.
(WebCore::RenderStyle::colorIncludingFallback const): Modified to compute the appropriate
color for property caret-color with respect to an unvisited or visited link.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setCaretColor): Added.
(WebCore::RenderStyle::setVisitedLinkCaretColor): Added.
(WebCore::RenderStyle::caretColor const): Added.
(WebCore::RenderStyle::visitedLinkCaretColor const): Added.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Modified to consider caret color.
(WebCore::StyleRareInheritedData::operator== const): Ditto.

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

Add reference tests to ensure that we do not regress CSS property caret-color.

  • TestExpectations: Unskip Web Platform Tests that now pass.
  • editing/deleting/maintain-style-after-delete-expected.txt: Updated expected result.
  • editing/inserting/insert-paragraph-with-font-and-background-color-expected.txt: Ditto.
  • editing/pasteboard/do-not-copy-unnecessary-styles-2-expected.txt: Ditto.
  • editing/pasteboard/onpaste-text-html-expected.txt: Ditto.
  • editing/pasteboard/preserve-caret-color-expected.txt: Added.
  • editing/pasteboard/preserve-caret-color.html: Added.
  • editing/pasteboard/preserve-underline-color-expected.txt:
  • fast/css/caret-color-auto-expected.html: Added.
  • fast/css/caret-color-auto.html: Added.
  • fast/css/caret-color-expected.html: Added.
  • fast/css/caret-color-fallback-to-color-expected.html: Added.
  • fast/css/caret-color-fallback-to-color.html: Added.
  • fast/css/caret-color-inherit-expected.html: Added.
  • fast/css/caret-color-inherit.html: Added.
  • fast/css/caret-color-span-inside-editable-parent-expected.html: Added.
  • fast/css/caret-color-span-inside-editable-parent.html: Added.
  • fast/css/caret-color.html: Added.
  • fast/events/before-input-events-prevent-drag-and-drop-expected.txt: Updated expected result.
  • fast/events/input-events-paste-rich-datatransfer-expected.txt: Ditto.
  • fast/events/ondrop-text-html-expected.txt: Ditto.
  • fast/history/visited-link-caret-color-expected.html: Added.
  • fast/history/visited-link-caret-color.html: Added.
  • platform/ios/TestExpectations: Skip the tests on iOS as iOS does not enable

ENABLE(TEXT_CARET). UIKit renders the text insertion caret on iOS.

  • platform/mac/editing/style/5065910-expected.txt: Updated expected result.
  • platform/mac/editing/style/5084241-expected.png: Ditto.
  • platform/mac/editing/style/5084241-expected.txt: Ditto.
  • platform/ios-wk2/editing/style/5084241-expected.txt: Ditto.
10:25 AM Changeset in webkit [220705] by dbates@webkit.org
  • 1 edit
    6 adds in trunk/Tools

Add Automator service to copy permalink to Clipboard
https://bugs.webkit.org/show_bug.cgi?id=170978

Reviewed by Joseph Pecoraro.

It is helpful to reference using a hyperlink a particular line of code when having
a discussion on IRC or in a bug. You can get such a link by navigating to the file
in the Trac Browse Source viewer and selecting the line your are interested in.
I found myself doing this often enough that I wrote an Automator service to do it
for me.

This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.

  • CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
  • CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
  • CopyPermalink/README: Added.
10:14 AM Changeset in webkit [220704] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
10:09 AM Changeset in webkit [220703] by Chris Dumez
  • 2 edits in trunk/Tools

Address flakiness related to download tests
https://bugs.webkit.org/show_bug.cgi?id=175338
<rdar://problem/33865119>

Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
between tests.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

10:08 AM Changeset in webkit [220702] by Ryan Haddad
  • 3 edits in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220474.

9:41 AM Changeset in webkit [220701] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix Windows build.
https://bugs.webkit.org/show_bug.cgi?id=175446

Not reviewed.

  • assembler/MacroAssemblerX86Common.cpp:

(JSC::booleanTrueForAvoidingNoReturnDeclaration):
(JSC::ctiMasmProbeTrampoline):

9:41 AM Changeset in webkit [220700] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebKit

[CoordGraphics] Simplify CoordinatedGraphicsScene state updates
https://bugs.webkit.org/show_bug.cgi?id=175528

Reviewed by Carlos Garcia Campos.

Hold the information about state updates in ThreadedCompositor, in the
m_attributes struct. This way we don't need to store the updates in
functors and accumulate them in the CoordinatedGraphicsScene class, but
instead just apply any pending state update or atlas removal before the
scene is rendered.

This removes the need to update the CoordinatedGraphicsScene object from
the main thread with data that ultimately has to be handled on the
composition thread. Similarly, when updating CoordinatedGraphicsScene, we
only need to synchronize on the m_attributes lock object once in order to
retrieve the scene update information, instead of having each functor do
that repeatedly.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::applyStateChanges):
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebKit::CoordinatedGraphicsScene::detach):
(WebKit::CoordinatedGraphicsScene::setActive):
(WebKit::CoordinatedGraphicsScene::syncRemoteContent): Deleted.
(WebKit::CoordinatedGraphicsScene::appendUpdate): Deleted.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
9:37 AM Changeset in webkit [220699] by zandobersek@gmail.com
  • 4 edits in trunk

REGRESSION(r220517-r220521) [GTK] Various compositing tests fail
https://bugs.webkit.org/show_bug.cgi?id=175478

Reviewed by Sergio Villar Senin.

Source/WebCore:

Fix a regression introduced in r220519. Move a framebuffer binding in TextureMapperGL
away from GraphicsContext3D and onto the OpenGL API to work around the framebuffer
binding state that's kept in the GraphicsContext3D class. This mismatch in how the
framebuffer was bound was causing a couple of test failures in compositing tests.

No new tests -- regressed tests have their failure expectations removed.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindDefaultSurface): Don't use GraphicsContext3D for the
glBindFramebuffer() call. This would be done in subsequent patches that would move
TextureMapperGL off the GraphicsContext3D usage, but this specific use case clashes
with the framebuffer binding that's done in BitmapTextureGL and was causing test
failures.

LayoutTests:

  • platform/gtk/TestExpectations: Remove failure and flakiness expectations.
9:08 AM Changeset in webkit [220698] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220694 - [GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon
https://bugs.webkit.org/show_bug.cgi?id=175531

Reviewed by Michael Catanzaro.

When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL()
might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling
webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by
webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a
new icon.

  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(webkitFaviconDatabaseSetIconURLForPageURL): Return early if isSettingIcon is true.
(webkitFaviconDatabaseSetIconForPageURL): Set isSettingIcon to true for the scope.

9:06 AM Changeset in webkit [220697] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220685 - Factor text autosizing into a class
https://bugs.webkit.org/show_bug.cgi?id=175530

Reviewed by Andreas Kling.

Move the remaining parts out of Document.

  • css/StyleBuilderCustom.h:

(WebCore::computeLineHeightMultiplierDueToFontSize):

  • dom/Document.cpp:

(WebCore::Document::destroyRenderTree):
(WebCore::Document::textAutoSizing):
(WebCore::TextAutoSizingTraits::constructDeletedValue): Deleted.
(WebCore::TextAutoSizingTraits::isDeletedValue): Deleted.
(WebCore::Document::addAutoSizedNode): Deleted.
(WebCore::Document::updateAutoSizedNodes): Deleted.
(WebCore::Document::clearAutoSizedNodes): Deleted.

  • dom/Document.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustComputedFontSizes):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingTraits::constructDeletedValue):
(WebCore::TextAutoSizingTraits::isDeletedValue):
(WebCore::TextAutoSizing::addTextNode):
(WebCore::TextAutoSizing::updateRenderTree):
(WebCore::TextAutoSizing::reset):

  • rendering/TextAutoSizing.h:
8:54 AM Changeset in webkit [220696] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed fix after r220622 to address crashes on iOS.

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::finishLoading):

8:49 AM Changeset in webkit [220695] by Carlos Garcia Campos
  • 7 edits
    3 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220681 - GTK-focused gardening.
https://bugs.webkit.org/show_bug.cgi?id=175529

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • http/wpt/css/css-pseudo-4/marker-font-properties-expected.html: Set line-height for more reliable rendering.
  • http/wpt/css/css-pseudo-4/marker-font-properties.html: Set line-height for more reliable rendering.
  • media/video-fullscreen-restriction-removed-expected.txt: DOMException's toString was changed in r219663; rebaseline. (The test is marked as flaky on mac.)
  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt: SecurityError got a new message in r220376; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Added: GTK does not yet enable the in-progress ServiceWorker implementation.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: TypeError got a new message in r220622; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt: Added: TypeError uses a different message on GTK.
8:44 AM Changeset in webkit [220694] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon
https://bugs.webkit.org/show_bug.cgi?id=175531

Reviewed by Michael Catanzaro.

When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL()
might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling
webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by
webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a
new icon.

  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(webkitFaviconDatabaseSetIconURLForPageURL): Return early if isSettingIcon is true.
(webkitFaviconDatabaseSetIconForPageURL): Set isSettingIcon to true for the scope.

8:38 AM Changeset in webkit [220693] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220677 - [GTK][WPE] Crash in IconDatabase::IconRecord::setImageData()
https://bugs.webkit.org/show_bug.cgi?id=175527

Reviewed by Žan Doberšek.

The problem is that when setImageData() is called from IconDatabase::readFromDatabase() the shared buffer might
be nullptr, because getImageDataForIconURLFromSQLDatabase() returns nullptr if the icon data is not in the database.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::setImageData): Return early if passed in buffer is nullptr.

8:38 AM Changeset in webkit [220692] by Carlos Garcia Campos
  • 1 edit
    5 adds in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220655 - [GTK] Update some test expectations.
https://bugs.webkit.org/show_bug.cgi?id=175480

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/webrtc/simplecall-expected.txt: Added.
8:35 AM Changeset in webkit [220691] by Carlos Garcia Campos
  • 15 edits
    1 add
    2 deletes in releases/WebKitGTK/webkit-2.18

Merge r220646 - [Render Tree Mutation] First letter should not mutate the render tree while in layout.
https://bugs.webkit.org/show_bug.cgi?id=163848
Source/WebCore:

Reviewed by Zalan Bujtas.

RenderBlock::updateFirstLetter shouldn't be called during layout. Instead it should
be invoked by the RenderTreeUpdater.

With this future patches can move updateFirstLetter() and the related functions
completely out of the render tree.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout):

No more updateFirstLetter calls during layout...

(WebCore::RenderBlock::computePreferredLogicalWidths):

...or preferred width computation.

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlock.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter):

  • rendering/RenderRubyRun.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter):

  • rendering/RenderTable.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter):

  • rendering/svg/RenderSVGText.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

Call updateFirstLetter when closing the element. All of of descedant renderers are known here
so this can be resolved correctly.

LayoutTests:

<rdar://problem/33402718>

Reviewed by Zalan Bujtas.

  • fast/text-autosizing/ios/first-letter-expected.html: Added.

Turn into reftest for easier debugging and robustness.

  • imported/blink/fast/css/first-letter-range-insert-expected.txt:

This is crash-or-assert test and the output change here doesn't matter.

  • platform/ios/fast/text-autosizing/ios/first-letter-expected.txt: Removed.
  • platform/mac/fast/text-autosizing/ios/first-letter-expected.txt: Removed.
8:29 AM Changeset in webkit [220690] by Carlos Garcia Campos
  • 12 edits
    2 adds in releases/WebKitGTK/webkit-2.18

Merge r220639 - Composition underline color is always black
https://bugs.webkit.org/show_bug.cgi?id=174675

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

Test: editing/composition-underline-color.html

  • editing/CompositionUnderline.h:

(WebCore::CompositionUnderline::CompositionUnderline):
Added new attribute compositionUnderlineColor.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionUnderline):
Use the text color if compositionUnderlineColor is TextColor.

Source/WebKit:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(WebKit::WebViewImpl::setMarkedText): Use text color
for composition underline in the plain text case.

  • UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
Use text color for composition underline.
(WebKit::InputMethodFilter::updatePreedit): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting): Ditto.

Source/WebKitLegacy/mac:

  • WebView/WebHTMLView.mm:

(extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(-[WebHTMLView setMarkedText:selectedRange:]): Use text color
for composition underline in the plain text case.

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::setCompositionForTesting): Use text color for
composition underline.

LayoutTests:

Added new test to check that the composition underline
is using the text color.
The test hides the text and the caret, so it only shows
the composition underline and checks against an -expected-mismatch
that the color of the composition marker is different.

  • editing/composition-underline-color-expected-mismatch.html: Added.
  • editing/composition-underline-color.html: Added.
8:26 AM Changeset in webkit [220689] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220638 - [GTK] stop kinetic scrolling when a zero movement is reached
https://bugs.webkit.org/show_bug.cgi?id=175468

Reviewed by Michael Catanzaro.

This is GTK+ change by Christian Hergert.
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6

When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.

  • platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):

8:25 AM Changeset in webkit [220688] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220632 - Drop non-const getter for CachedResource::resourceRequest()
https://bugs.webkit.org/show_bug.cgi?id=175524

Reviewed by Youenn Fablet.

Drop non-const getter for CachedResource::resourceRequest(). It would be unsafe to modify the request of a CachedResource
after it has been cached. Exposing such a getter is therefore a footgun.

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceRequest const):
(WebCore::CachedResource::ignoreForRequestCount const):
(WebCore::CachedResource::setIgnoreForRequestCount):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::ignoreForRequestCount const):
(WebCore::CachedResourceRequest::setIgnoreForRequestCount):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

  • platform/network/ResourceRequestBase.h:
8:09 AM Changeset in webkit [220687] by Carlos Garcia Campos
  • 9 edits
    1 move in releases/WebKitGTK/webkit-2.18

Merge r220631 - [WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507

Reviewed by Carlos Alberto Lopez Perez.

Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.

.:

  • Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
  • Source/cmake/OptionsWPE.cmake: Add UA version macros.

Source/WebCore:

  • PlatformGTK.cmake: Handlde renaming of UserAgentGtk.cpp to UserAgentGLib.cpp.
  • PlatformWPE.cmake: Add UserAgentGLib.cpp and UserAgentQuirks.cpp to the list of built WebCore sources.
  • platform/glib/UserAgentGLib.cpp: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.cpp.

(WebCore::versionForUAString): Change "GTK" in UA version macros to "GLIB".

Source/WebKit:

  • UIProcess/API/glib/WebKitSettings.cpp: Remove preprocessor conditionals for the WPE port.

(webkit_settings_set_user_agent):
(webkit_settings_set_user_agent_with_application_details):

  • UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::standardUserAgent): Remove hardcoded value and make use of WebCore::standardUserAgent().

8:09 AM Changeset in webkit [220686] by Carlos Garcia Campos
  • 13 edits
    1 move in releases/WebKitGTK/webkit-2.18/Source

Merge r220621 - [WTF] Move ValueToString into WTF
https://bugs.webkit.org/show_bug.cgi?id=175469

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.h:

(WTF::ValueToString<WebCore::TextTrackCue::string):
(WebCore::ValueToString<TextTrackCue::string): Deleted.
(WebCore::ValueToString<MediaTime>::string): Deleted.

  • platform/LayoutUnit.h:

(WTF::ValueToString<WebCore::LayoutUnit>::string):
(WebCore::ValueToString<LayoutUnit>::string): Deleted.

  • platform/PODInterval.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/graphics/FloatPolygon.h:

(WTF::ValueToString<WebCore::FloatPolygonEdge::string):
(WebCore::ValueToString<FloatPolygonEdge::string): Deleted.

  • rendering/FloatingObjects.h:

(WTF::ValueToString<WebCore::FloatingObject::string):
(WebCore::ValueToString<FloatingObject::string): Deleted.

  • rendering/RenderFlowThread.h:

(WTF::ValueToString<WebCore::RenderRegion::string):
(WebCore::ValueToString<RenderRegion::string): Deleted.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/ValueToString.h: Renamed from Source/WebCore/platform/ValueToString.h.
6:20 AM Changeset in webkit [220685] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Factor text autosizing into a class
https://bugs.webkit.org/show_bug.cgi?id=175530

Reviewed by Andreas Kling.

Move the remaining parts out of Document.

  • css/StyleBuilderCustom.h:

(WebCore::computeLineHeightMultiplierDueToFontSize):

  • dom/Document.cpp:

(WebCore::Document::destroyRenderTree):
(WebCore::Document::textAutoSizing):
(WebCore::TextAutoSizingTraits::constructDeletedValue): Deleted.
(WebCore::TextAutoSizingTraits::isDeletedValue): Deleted.
(WebCore::Document::addAutoSizedNode): Deleted.
(WebCore::Document::updateAutoSizedNodes): Deleted.
(WebCore::Document::clearAutoSizedNodes): Deleted.

  • dom/Document.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustComputedFontSizes):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingTraits::constructDeletedValue):
(WebCore::TextAutoSizingTraits::isDeletedValue):
(WebCore::TextAutoSizing::addTextNode):
(WebCore::TextAutoSizing::updateRenderTree):
(WebCore::TextAutoSizing::reset):

  • rendering/TextAutoSizing.h:
6:12 AM Changeset in webkit [220684] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220620 - [Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
https://bugs.webkit.org/show_bug.cgi?id=175394

Patch by Sam Weinig <sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • bindings/IDLTypes.h:

(WebCore::IDLWrapper::convertToParameterType): Deleted.

Remove no longer used convertToParameterType.

  • bindings/js/DOMPromiseProxy.h:
  • Replace Variant<Value, Exception> with ExceptionOr<Value> / ExceptionOr<void>.
  • Update ResolveCallback to have a return type of IDLType::ParameterType, rather than IDLType::ImplementationType, now that WTF::Function supports references as the return type. This is needed, since the IDLType::ParameterType for an interface T is T&.
  • css/FontFace.cpp:
  • css/FontFace.h:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:

Update resolve callbacks to return a reference rather than a RefPtr, matching
the new signature requirement.

6:02 AM Changeset in webkit [220683] by Carlos Garcia Campos
  • 17 edits
    11 copies
    1 move
    2 deletes in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220619 - [WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
https://bugs.webkit.org/show_bug.cgi?id=175457

Patch by Sam Weinig <sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp: Removed.
  • bindings/js/JSCryptoAlgorithmBuilder.h: Removed.
  • bindings/js/JSCryptoKeyCustom.cpp: Removed.

Remove JSCryptoAlgorithmBuilder and JSCryptoKeyCustom, add KeyAlgorithm
IDLs and headers.

  • crypto/CryptoKey.cpp:
  • crypto/CryptoKey.h:
  • crypto/CryptoKey.idl:

Replace custom algorithm attribute with a union of the supported key algorithms.

  • crypto/keys/CryptoAesKeyAlgorithm.h: Added.
  • crypto/keys/CryptoAesKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.h: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.h: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoKeyAlgorithm.h: Added.
  • crypto/keys/CryptoKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.idl: Added.

Add IDLs and headers fo the supported key algorithms.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeyRaw.h:

Give each of the existing KeyAlgorithm subclasses a dictionary() function
that returns the populated corresponding spec'd dictionary.

5:57 AM Changeset in webkit [220682] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220616 - Some RenderSVGResource cleanup
https://bugs.webkit.org/show_bug.cgi?id=175494

Reviewed by Zalan Bujtas.

Use more initializers. Remove spurious use of bitfields that didn't save any space at all.
0 -> nullptr.

No behavior change.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokeShape):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

5:28 AM Changeset in webkit [220681] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/LayoutTests

GTK-focused gardening.
https://bugs.webkit.org/show_bug.cgi?id=175529

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • http/wpt/css/css-pseudo-4/marker-font-properties-expected.html: Set line-height for more reliable rendering.
  • http/wpt/css/css-pseudo-4/marker-font-properties.html: Set line-height for more reliable rendering.
  • media/video-fullscreen-restriction-removed-expected.txt: DOMException's toString was changed in r219663; rebaseline. (The test is marked as flaky on mac.)
  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/dom/document-attributes-null-handling-expected.txt: SecurityError got a new message in r220376; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/FileAPI/historical.https-expected.txt: Added: GTK does not yet enable the in-progress ServiceWorker implementation.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt: TypeError got a new message in r220622; rebaseline.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt: Added: TypeError uses a different message on GTK.
5:11 AM Changeset in webkit [220680] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18

Merge r220601 - WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244
Source/JavaScriptCore:

Reviewed by Chris Dumez.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

Reviewed by Chris Dumez.

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

Reviewed by Chris Dumez.

  • UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

Reviewed by Chris Dumez.

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

  • wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

Tools:

<rdar://problem/33801582>

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WTF/Function.cpp:

(TestWebKitAPI::TEST):

4:25 AM Changeset in webkit [220679] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220594 - Remove RenderQuote collection from RenderView
https://bugs.webkit.org/show_bug.cgi?id=175479

Reviewed by Andreas Kling.

We can do it well enough without maintaining this pointer structure.

Global updating doesn't work well with future direction for first-letter and similar anyway.
We need to update quote immediately when updating its style.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Just tell the view that there are renderers to update.

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::isOpen const):
(WebCore::RenderQuote::updateRenderer):
(WebCore::RenderQuote::updateRenderers): Deleted.

Update single renderer only. RenderTreeUpdater provides the previous renderer to compute the depth.

  • rendering/RenderQuote.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote): Deleted.
(WebCore::RenderView::unregisterQuote): Deleted.
(WebCore::RenderView::updateSpecialRenderers): Deleted.

Remove the quote list.

  • rendering/RenderView.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Ensure that all quotes are updated.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
(WebCore::RenderTreeUpdater::updateQuotesUpTo):

Traverse render tree to find quotes to update starting from the previous updated quote.

  • style/RenderTreeUpdater.h:
4:16 AM Changeset in webkit [220678] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220586 - [GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
https://bugs.webkit.org/show_bug.cgi?id=175476

Reviewed by Carlos Garcia Campos.

  • platform/graphics/cairo/ImageBufferDataCairo.h: Add missing "override" qualifier.
4:12 AM Changeset in webkit [220677] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] Crash in IconDatabase::IconRecord::setImageData()
https://bugs.webkit.org/show_bug.cgi?id=175527

Reviewed by Žan Doberšek.

The problem is that when setImageData() is called from IconDatabase::readFromDatabase() the shared buffer might
be nullptr, because getImageDataForIconURLFromSQLDatabase() returns nullptr if the icon data is not in the database.

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::setImageData): Return early if passed in buffer is nullptr.

4:08 AM Changeset in webkit [220676] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r220584 - Fix build warning in WebDriverService.h
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

  • WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]
4:07 AM Changeset in webkit [220675] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18

Merge r220583 - [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=175378

Reviewed by Sergio Villar Senin.

Source/WebCore:

Bring back part of the code removed in r206732, to keep a reference to the SoupMessage in the
AuthenticationChallenge since it can be different to the resource message.

  • platform/network/soup/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::soupAuth const): Deleted.
(WebCore::AuthenticationChallenge::setProposedCredential): Deleted.

  • platform/network/soup/AuthenticationChallengeSoup.cpp:

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::platformCompare):

Source/WebKit:

In case of HTTPS resource with a proxy, libsoup uses a tunnel internally, that uses its own SoupMessage during
the proxy authentication. We were ignoring authentication requests for other messages.

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback): Only return early if the message does't match and it's not
HTTPS resource over a proxy.
(WebKit::NetworkDataTaskSoup::authenticate): Use the soup message from the authentication challenge.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Ditto.

Tools:

Add two test cases to check proxy authentication.

  • TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(Tunnel::Tunnel):
(Tunnel::~Tunnel):
(Tunnel::connect):
(Tunnel::connected):
(serverCallback):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(ProxyAuthenticationTest::~ProxyAuthenticationTest):
(ProxyAuthenticationTest::proxyServerPortAsString):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
(beforeAll):

4:06 AM Changeset in webkit [220674] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220581 - [Soup] Do not spawn the network process to setup cookie persistent storage
https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

4:05 AM Changeset in webkit [220673] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220580 - [GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
https://bugs.webkit.org/show_bug.cgi?id=173866
<rdar://problem/33122050>

Reviewed by Michael Catanzaro.

IconDatabase creates and destroys IconRecord objects in both database and main thread. If the IconRecord has a
valid icon, its Image could be created in one thread and destroyed in another, something that is not expected to
happen, because Image has a Timer member. Since we have all the data and we are decoding it right after creating
the Image, we don't really need to keep the Image object around, we could simply take a reference of the encoded
data and the decoded native image to be returned by synchronousIconForPageURL().

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::image): Return NativeImagePtr now.
(WebKit::IconDatabase::IconRecord::setImageData): Create a BitmapImage to decode it and keep a reference to the
encoded data and decoded native image.
(WebKit::IconDatabase::IconRecord::snapshot const): Use m_imageData to get the encoded data.
(WebKit::IconDatabase::synchronousIconForPageURL): Return the native image and whether the icon is known or not.
(WebKit::IconDatabase::IconRecord::loadImageFromResource): Deleted.

  • UIProcess/API/glib/IconDatabase.h:
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Use new API.

3:23 AM Changeset in webkit [220672] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebKit

[ThreadedCompositor] Improve composition and update state handling
https://bugs.webkit.org/show_bug.cgi?id=172448

Reviewed by Carlos Garcia Campos.

In the ThreadedCompositor and related classes, we now track composition
and scene update states separately. This enables properly piping in the
DisplayRefreshMonitor object, leveraging it for both display refresh
notifications and signalling to the client that the scene update is
completed.

In CompositingRunLoop, two separate states are now used, one for
compositing and the other for scene update. Access to both should be done
while the related Lock object is held. The pending update state is also
tracked in order to schedule any required updates as soon as the current
state update is completed.

In ThreadedCompositor, the information about client notification and
update completion coordination is now also kept under a Lock object,
moving away from atomics. DisplayRefreshMonitor can now utilize just
two methods in order to either schedule an update or report that update
as finished.

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop):
(WebKit::CompositingRunLoop::scheduleUpdate):
(WebKit::CompositingRunLoop::stopUpdates):
(WebKit::CompositingRunLoop::compositionCompleted):
(WebKit::CompositingRunLoop::updateCompleted):
(WebKit::CompositingRunLoop::updateTimerFired):
(WebKit::CompositingRunLoop::isActive): Deleted.

  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

(WebKit::CompositingRunLoop::stateLock):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::requestDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCompositor::handleDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCompositor::renderNextFrameIfNeeded): Deleted.
(WebKit::ThreadedCompositor::completeCoordinatedUpdateIfNeeded): Deleted.
(WebKit::ThreadedCompositor::coordinateUpdateCompletionWithClient): Deleted.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):

2:46 AM Changeset in webkit [220671] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220570 - Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

  • accessibility/press-target-uses-text-descendant-node.html:
2:45 AM Changeset in webkit [220670] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220569 - Make ThreadGlobalData RefCounted for web thread
https://bugs.webkit.org/show_bug.cgi?id=175439

Reviewed by Mark Lam.

When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.

Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.

In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.

2:42 AM Changeset in webkit [220669] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Merge r220567 - Unreviewed, attempt to fix build failure with VC2017

Source/WTF:

  • wtf/PriorityQueue.h:

Tools:

  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

2:41 AM Changeset in webkit [220668] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220566 - [JSC] Use @toNumber in builtins
https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):

  • Modules/streams/StreamInternals.js:

(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

2:40 AM Changeset in webkit [220667] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Tools

Merge r220565 - Unreviewed, suppress warnings on GCC

  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

2:39 AM Changeset in webkit [220666] by Carlos Garcia Campos
  • 7 edits
    1 copy in releases/WebKitGTK/webkit-2.18

Merge r220562 - Run more WTF tests
https://bugs.webkit.org/show_bug.cgi?id=174970

Reviewed by Michael Catanzaro.

Source/WTF:

CHAR_BIT is not defined.

  • wtf/LEBDecoder.h:

Tools:

Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(isHigherPriority):
(TEST):

  • TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.

(TEST):

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(TEST):

2:38 AM Changeset in webkit [220665] by Carlos Garcia Campos
  • 15 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220556 - Apply the UNLIKELY macro to some unlikely things.
https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/33834767>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileOSRExit):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeCommon):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):

  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::installCode):

  • runtime/VM.cpp:

(JSC::VM::VM):

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getBytecodeProfile):

2:37 AM Changeset in webkit [220664] by Carlos Garcia Campos
  • 6 edits
    3 adds in releases/WebKitGTK/webkit-2.18

Merge r220551 - AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.

Test: accessibility/add-children-pseudo-element.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::createWeakPtr):

  • accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):

  • accessibility/AccessibilitySVGRoot.h:

LayoutTests:

  • accessibility/add-children-pseudo-element-expected.txt: Added.
  • accessibility/add-children-pseudo-element.html: Added.
  • accessibility/resources/svg-circle.svg: Added.
2:35 AM Changeset in webkit [220663] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220548 - [WTF] ThreadSpecific should not introduce additional indirection
https://bugs.webkit.org/show_bug.cgi?id=175187

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • runtime/Identifier.cpp:

Source/WebCore:

We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.

While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.

And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.

  • platform/ThreadGlobalData.h:

We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.

Source/WTF:

ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.

This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.

  • wtf/ThreadSpecific.h:

(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.

(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.

(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.

2:03 AM Changeset in webkit [220662] by Carlos Garcia Campos
  • 10 edits in releases/WebKitGTK/webkit-2.18

Merge r220538 - Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

Source/WebCore:

  • platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

  • TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

2:00 AM Changeset in webkit [220661] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220531 - Addressing post-review comments after r219173.
https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

  • css/CSSFontStyleValue.h:
  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):

1:59 AM Changeset in webkit [220660] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220528 - Try to fix windows build.

  • style/StyleUpdate.h:

(WebCore::Style::TextUpdate::TextUpdate):

1:57 AM Changeset in webkit [220659] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220527 - [GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

  • PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction

for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

1:56 AM Changeset in webkit [220658] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220525 - [GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

1:55 AM Changeset in webkit [220657] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220524 - Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

  • platform/gtk/TestExpectations:
1:50 AM Changeset in webkit [220656] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220523 - Text renderer updates should be done by RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

  • dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Add range argument.

  • dom/Document.h:
  • dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

Remove call to setTextWithOffset and pass the range to updateTextRenderer

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

Call setTextWithOffset here.

  • style/RenderTreeUpdater.h:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

  • style/StyleUpdate.h:
1:28 AM Changeset in webkit [220655] by commit-queue@webkit.org
  • 2 edits
    5 adds in trunk/LayoutTests

[GTK] Update some test expectations.
https://bugs.webkit.org/show_bug.cgi?id=175480

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-14

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/webrtc/simplecall-expected.txt: Added.
1:19 AM Changeset in webkit [220654] by Carlos Garcia Campos
  • 258 edits
    2 moves in releases/WebKitGTK/webkit-2.18

Merge r220503 - [WTF] Move TextStream into WTF
https://bugs.webkit.org/show_bug.cgi?id=175211

Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedTreeIterator.cpp:
  • dom/Position.cpp:
  • dom/Position.h:
  • dom/Range.cpp:

(WebCore::operator<<):

  • dom/Range.h:
  • dom/ViewportArguments.cpp:
  • dom/ViewportArguments.h:
  • editing/VisiblePosition.cpp:
  • editing/VisiblePosition.h:
  • editing/VisibleSelection.cpp:
  • editing/VisibleSelection.h:
  • html/HTMLVideoElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • page/FrameView.cpp:
  • page/ViewportConfiguration.cpp:
  • page/ViewportConfiguration.h:
  • page/WheelEventDeltaFilter.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • page/scrolling/AsyncScrollingCoordinator.cpp:
  • page/scrolling/ScrollingConstraints.cpp:
  • page/scrolling/ScrollingConstraints.h:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.cpp:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:
  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateNode.cpp:
  • page/scrolling/ScrollingStateNode.h:
  • page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
  • page/scrolling/ScrollingStateOverflowScrollingNode.h:
  • page/scrolling/ScrollingStateScrollingNode.cpp:
  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.cpp:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTree.cpp:
  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeNode.cpp:
  • page/scrolling/ScrollingTreeNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.cpp:
  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.mm:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:
  • platform/CalculationValue.cpp:
  • platform/CalculationValue.h:
  • platform/LayoutUnit.cpp:
  • platform/LayoutUnit.h:
  • platform/Length.cpp:
  • platform/Length.h:
  • platform/LengthBox.cpp:
  • platform/LengthBox.h:
  • platform/LengthPoint.cpp:
  • platform/LengthPoint.h:
  • platform/LengthSize.cpp:
  • platform/LengthSize.h:
  • platform/LogMacros.h:
  • platform/ScrollView.cpp:
  • platform/ScrollableArea.cpp:
  • platform/animation/TimingFunction.cpp:
  • platform/animation/TimingFunction.h:
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.cpp:
  • platform/graphics/Color.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatRoundedRect.cpp:
  • platform/graphics/FloatRoundedRect.h:
  • platform/graphics/FloatSize.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontTaggedSettings.cpp:
  • platform/graphics/FontTaggedSettings.h:
  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::dump const):

  • platform/graphics/GradientImage.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::dumpAdditionalProperties const):

  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.cpp:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.cpp:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.cpp:
  • platform/graphics/IntSize.h:
  • platform/graphics/LayoutPoint.cpp:
  • platform/graphics/LayoutPoint.h:
  • platform/graphics/LayoutRect.cpp:
  • platform/graphics/LayoutRect.h:
  • platform/graphics/LayoutSize.cpp:
  • platform/graphics/LayoutSize.h:
  • platform/graphics/NamedImageGeneratedImage.cpp:
  • platform/graphics/NamedImageGeneratedImage.h:
  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCAAnimation.cpp:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/PlatformCALayer.cpp:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/TileController.cpp:
  • platform/graphics/ca/TileGrid.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:
  • platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::description const):

  • platform/graphics/displaylists/DisplayList.h:
  • platform/graphics/displaylists/DisplayListItems.cpp:
  • platform/graphics/displaylists/DisplayListItems.h:
  • platform/graphics/displaylists/DisplayListRecorder.cpp:
  • platform/graphics/displaylists/DisplayListReplayer.cpp:
  • platform/graphics/filters/DistantLightSource.cpp:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:
  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:
  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FEMerge.cpp:
  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:
  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:
  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:
  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/FilterOperations.cpp:
  • platform/graphics/filters/FilterOperations.h:
  • platform/graphics/filters/LightSource.h:
  • platform/graphics/filters/PointLightSource.cpp:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • platform/graphics/filters/SpotLightSource.cpp:
  • platform/graphics/filters/SpotLightSource.h:
  • platform/graphics/transforms/AffineTransform.cpp:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:
  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.cpp:
  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.cpp:
  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.cpp:
  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.cpp:
  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TransformOperations.cpp:
  • platform/graphics/transforms/TransformOperations.h:
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/transforms/TranslateTransformOperation.cpp:
  • platform/graphics/transforms/TranslateTransformOperation.h:
  • platform/ios/SelectionRect.cpp:

(WebCore::operator<<):

  • platform/ios/SelectionRect.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/text/TextAllInOne.cpp:
  • rendering/InlineBox.cpp:
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::outputLineTreeAndMark const):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::outputLineTreeAndMark const):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/RenderTreeAsText.h:
  • rendering/ScrollAlignment.cpp:
  • rendering/ScrollAlignment.h:
  • rendering/SimpleLineLayoutCoverage.cpp:
  • rendering/SimpleLineLayoutFunctions.cpp:
  • rendering/SimpleLineLayoutFunctions.h:
  • rendering/style/FillLayer.cpp:
  • rendering/style/FillLayer.h:
  • rendering/style/NinePieceImage.cpp:
  • rendering/style/NinePieceImage.h:
  • rendering/style/RenderStyleConstants.cpp:
  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderTreeAsText.h:

(WebCore::operator<<):

  • svg/SVGLengthValue.cpp:
  • svg/SVGLengthValue.h:
  • svg/graphics/SVGImage.cpp:
  • svg/graphics/SVGImage.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:

Source/WebKit:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
  • Shared/VisibleContentRectUpdateInfo.cpp:
  • Shared/VisibleContentRectUpdateInfo.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/ios/WKContentView.mm:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(WebKit::operator<<):

  • UIProcess/ios/WebPageProxyIOS.mm:
  • WebProcess/WebPage/ios/WebPageIOS.mm:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/TextStream.cpp: Renamed from Source/WebCore/platform/text/TextStream.cpp.

(WTF::TextStream::writeIndent):

  • wtf/text/TextStream.h: Renamed from Source/WebCore/platform/text/TextStream.h.

(WTF::TextStream::FormatNumberRespectingIntegers::FormatNumberRespectingIntegers):

Tools:

  • TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
12:40 AM Changeset in webkit [220653] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r220500 - [JSC] Create JSSet constructor that accepts it's size as parameter
https://bugs.webkit.org/show_bug.cgi?id=173297

Reviewed by Saam Barati.

This patch is adding a new constructor to JSSet that gives its
expected initial size. It is important to avoid re-hashing and mutiple
allocations when we know the final size of JSSet, such as in
CodeBlock::setConstantIdentifierSetRegisters.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantIdentifierSetRegisters):

  • runtime/HashMapImpl.h:

(JSC::HashMapImpl::HashMapImpl):

  • runtime/JSSet.h:
12:34 AM Changeset in webkit [220652] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220486 - LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

  • accessibility/presentation-role-iframe.html:
12:33 AM Changeset in webkit [220651] by Carlos Garcia Campos
  • 3 edits
    2 deletes in releases/WebKitGTK/webkit-2.18

Merge r220484 - Unreviewed, rolling out r219334.
https://bugs.webkit.org/show_bug.cgi?id=175398

Caused bug 175023 (Requested by ap on #webkit).

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219334

12:25 AM Changeset in webkit [220650] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.18

Merge r220481 - Early error on ANY operator before new.target
https://bugs.webkit.org/show_bug.cgi?id=157970

Reviewed by Saam Barati.

Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.

The following become legal in JSC:

`
!new.target
~new.target
typeof new.target
delete new.target
void new.target
`

All of which are legal in v8 and SpiderMonkey in strict and sloppy mode

JSTests:

  • stress/new-target-syntax-errors.js:
  • stress/new-target.js:

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseUnaryExpression):

12:23 AM Changeset in webkit [220649] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220479 - [Repaint from Layout Removal] Move layer repaint rects into a map
https://bugs.webkit.org/show_bug.cgi?id=175393

Reviewed by Zalan Bujtas.

Move the two repaint rects held by RenderLayer into a RenderLayerModelObject -> RepaintLayoutRects hash map.
RepaintLayoutRects is a new struct that holds both rects.

Eventually more objects than just self painting layers will be caching repaint rects, so this takes a first
step towards having a common cache for these repaint rects. In addition this change saves memory, since
layers that aren't self-painting no longer have empty repaint rects taking up space in RenderLayer.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutRunsAndFloats):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerModelObject.cpp:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::hasRepaintLayoutRects):
(WebCore::RenderLayerModelObject::setRepaintLayoutRects):
(WebCore::RenderLayerModelObject::clearRepaintLayoutRects):
(WebCore::RenderLayerModelObject::repaintLayoutRects):
(WebCore::RenderLayerModelObject::computeRepaintLayoutRects):

  • rendering/RenderLayerModelObject.h:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):

12:15 AM Changeset in webkit [220648] by Carlos Garcia Campos
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-2.18

Merge r220472 - Old subtitle track is not deleted on 'src' attribute change event
https://bugs.webkit.org/show_bug.cgi?id=175031

Patch by Kirill Ovchinnikov <kirill.ovchinnikov@lge.com> on 2017-08-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/text-track-src-change.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackReadyStateChanged):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::clearTextDisplayContainer):

  • html/shadow/MediaControls.h:

LayoutTests:

  • media/track/text-track-src-change-expected.txt: Added.
  • media/track/text-track-src-change.html: Added.
12:13 AM Changeset in webkit [220647] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r220471 - Make JSC_validateExceptionChecks=1 succeed on JSTests/stress/v8-deltablue-strict.js.
https://bugs.webkit.org/show_bug.cgi?id=175358

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-09
Reviewed by Mark Lam.

  • jit/JITOperations.cpp:
  • runtime/JSObjectInlines.h:

(JSC::JSObject::putInlineForJSObject):

12:10 AM Changeset in webkit [220646] by Antti Koivisto
  • 15 edits
    1 add
    2 deletes in trunk

[Render Tree Mutation] First letter should not mutate the render tree while in layout.
https://bugs.webkit.org/show_bug.cgi?id=163848
Source/WebCore:

Reviewed by Zalan Bujtas.

RenderBlock::updateFirstLetter shouldn't be called during layout. Instead it should
be invoked by the RenderTreeUpdater.

With this future patches can move updateFirstLetter() and the related functions
completely out of the render tree.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout):

No more updateFirstLetter calls during layout...

(WebCore::RenderBlock::computePreferredLogicalWidths):

...or preferred width computation.

(WebCore::RenderBlock::updateFirstLetter):

  • rendering/RenderBlock.h:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter):

  • rendering/RenderRubyRun.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter):

  • rendering/RenderTable.h:
  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter):

  • rendering/svg/RenderSVGText.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

Call updateFirstLetter when closing the element. All of of descedant renderers are known here
so this can be resolved correctly.

LayoutTests:

<rdar://problem/33402718>

Reviewed by Zalan Bujtas.

  • fast/text-autosizing/ios/first-letter-expected.html: Added.

Turn into reftest for easier debugging and robustness.

  • imported/blink/fast/css/first-letter-range-insert-expected.txt:

This is crash-or-assert test and the output change here doesn't matter.

  • platform/ios/fast/text-autosizing/ios/first-letter-expected.txt: Removed.
  • platform/mac/fast/text-autosizing/ios/first-letter-expected.txt: Removed.

Aug 13, 2017:

11:55 PM Changeset in webkit [220645] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220467 - ServiceWorker experimental feature should not be on by default (definitely not ready).
https://bugs.webkit.org/show_bug.cgi?id=175389

Rubberstamped by Andy Estes.

  • Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
11:53 PM Changeset in webkit [220644] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220464 - [WinCairo] Fix build after rev 220399
https://bugs.webkit.org/show_bug.cgi?id=175360

Reviewed by Žan Doberšek.

No new tests. No change in behavior.

  • platform/graphics/texmap/TextureMapperGLHeaders.h:
11:52 PM Changeset in webkit [220643] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220461 - [GStreamer][MSE] Add missing lock around getStreamByTrackId
https://bugs.webkit.org/show_bug.cgi?id=175323

Patch by Charlie Turner <cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

  • platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.

11:49 PM Changeset in webkit [220642] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/JSTests

Merge r220458 - Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
https://bugs.webkit.org/show_bug.cgi?id=175255

Unreviewed test gardening.

  • stress/regress-169783.js:
  • wasm/stress/oom.js:
11:46 PM Changeset in webkit [220641] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220454 - Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
https://bugs.webkit.org/show_bug.cgi?id=175375

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.

These should have been removed in r207688.

No new tests: no behavior change.

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):

11:44 PM Changeset in webkit [220640] by Carlos Garcia Campos
  • 11 edits in releases/WebKitGTK/webkit-2.18

Merge r220453 - Reinstate active flag for iterators
https://bugs.webkit.org/show_bug.cgi?id=175312

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync WPT tests from upstream to gain test coverage.

  • web-platform-tests/dom/traversal/NodeIterator-expected.txt:
  • web-platform-tests/dom/traversal/NodeIterator.html:
  • web-platform-tests/dom/traversal/TreeWalker-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker.html:

Source/WebCore:

NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:

This patch aligns our behavior with the latest specification.

No new tests, updated existing tests.

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).

  • dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):

  • dom/Traversal.h:
  • dom/TreeWalker.cpp:
11:31 PM Changeset in webkit [220639] by Manuel Rego Casasnovas
  • 12 edits
    2 adds in trunk

Composition underline color is always black
https://bugs.webkit.org/show_bug.cgi?id=174675

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

Test: editing/composition-underline-color.html

  • editing/CompositionUnderline.h:

(WebCore::CompositionUnderline::CompositionUnderline):
Added new attribute compositionUnderlineColor.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionUnderline):
Use the text color if compositionUnderlineColor is TextColor.

Source/WebKit:

This patch uses the current color of the text instead of black
for the composition underline marker.
This makes it visible in the case we have a black/dark background.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(WebKit::WebViewImpl::setMarkedText): Use text color
for composition underline in the plain text case.

  • UIProcess/gtk/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
Use text color for composition underline.
(WebKit::InputMethodFilter::updatePreedit): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setCompositionForTesting): Ditto.

Source/WebKitLegacy/mac:

  • WebView/WebHTMLView.mm:

(extractUnderlines): If NSUnderlineColorAttributeName
is not present use text color for composition underline.
(-[WebHTMLView setMarkedText:selectedRange:]): Use text color
for composition underline in the plain text case.

Source/WebKitLegacy/win:

  • WebView.cpp:

(WebView::setCompositionForTesting): Use text color for
composition underline.

LayoutTests:

Added new test to check that the composition underline
is using the text color.
The test hides the text and the caret, so it only shows
the composition underline and checks against an -expected-mismatch
that the color of the composition marker is different.

  • editing/composition-underline-color-expected-mismatch.html: Added.
  • editing/composition-underline-color.html: Added.
11:23 PM Changeset in webkit [220638] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] stop kinetic scrolling when a zero movement is reached
https://bugs.webkit.org/show_bug.cgi?id=175468

Reviewed by Michael Catanzaro.

This is GTK+ change by Christian Hergert.
https://git.gnome.org/browse/gtk+/commit/?h=gtk-3-22&id=4f63d839550f7a9038b391e7d3e1e6fc8bdfafa6

When the kinetic scrolling reduces its speed, there can be multiple frames where the movement is zero pixels,
followed by a 1 pixel movement later on. This causes a "jitter" right at the end of the scroll which makes it
feel less quality than other platforms. Instead, we should just clamp it as soon as we get a zero movement.

  • platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):

11:06 PM Changeset in webkit [220637] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220450 - [GTK] [WPE] Update expectations for global-constructors-attributes.html.
https://bugs.webkit.org/show_bug.cgi?id=175373

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-09

  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt:
11:00 PM Changeset in webkit [220636] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.18

Merge r220449 - REGRESSION: 2 test262/test/language/statements/async-function failures
https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

  • stress/async-await-syntax.js:
  • stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

  • runtime/Options.h:
10:56 PM Changeset in webkit [220635] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829966

10:56 PM Changeset in webkit [220634] by jmarcell@apple.com
  • 6 edits
    3 adds in branches/safari-604-branch

Cherry-pick r220551. rdar://problem/33843388

10:55 PM Changeset in webkit [220633] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829966

2:07 PM Changeset in webkit [220632] by Chris Dumez
  • 10 edits in trunk/Source/WebCore

Drop non-const getter for CachedResource::resourceRequest()
https://bugs.webkit.org/show_bug.cgi?id=175524

Reviewed by Youenn Fablet.

Drop non-const getter for CachedResource::resourceRequest(). It would be unsafe to modify the request of a CachedResource
after it has been cached. Exposing such a getter is therefore a footgun.

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceRequest const):
(WebCore::CachedResource::ignoreForRequestCount const):
(WebCore::CachedResource::setIgnoreForRequestCount):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::ignoreForRequestCount const):
(WebCore::CachedResourceRequest::setIgnoreForRequestCount):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

  • platform/network/ResourceRequestBase.h:
5:13 AM Changeset in webkit [220631] by Adrian Perez de Castro
  • 9 edits
    1 move in trunk

[WPE] Implement WebCore::standardUserAgent()
https://bugs.webkit.org/show_bug.cgi?id=175507

Reviewed by Carlos Alberto Lopez Perez.

Implement missing User-Agent handling for the WPE port by sharing the code with the GTK+ port.

.:

  • Source/cmake/OptionsGTK.cmake: Rename "GTK" with "GLIB" in UA version macros.
  • Source/cmake/OptionsWPE.cmake: Add UA version macros.

Source/WebCore:

  • PlatformGTK.cmake: Handlde renaming of UserAgentGtk.cpp to UserAgentGLib.cpp.
  • PlatformWPE.cmake: Add UserAgentGLib.cpp and UserAgentQuirks.cpp to the list of built WebCore sources.
  • platform/glib/UserAgentGLib.cpp: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.cpp.

(WebCore::versionForUAString): Change "GTK" in UA version macros to "GLIB".

Source/WebKit:

  • UIProcess/API/glib/WebKitSettings.cpp: Remove preprocessor conditionals for the WPE port.

(webkit_settings_set_user_agent):
(webkit_settings_set_user_agent_with_application_details):

  • UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::standardUserAgent): Remove hardcoded value and make use of WebCore::standardUserAgent().

Aug 12, 2017:

11:47 PM Changeset in webkit [220630] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

[ARM64] Use x29 and x30 instead of fp and lr to make GCC happy
https://bugs.webkit.org/show_bug.cgi?id=175512
<rdar://problem/33863584>

Reviewed by Mark Lam.

  • CMakeLists.txt: Added MacroAssemblerARM64.cpp.
  • assembler/MacroAssemblerARM64.cpp: Use x29 and x30 instead of fp and lr to make GCC happy.
11:22 PM Changeset in webkit [220629] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

ARM_TRADITIONAL: static assertion failed: ProbeContext_size_matches_ctiMasmProbeTrampoline
https://bugs.webkit.org/show_bug.cgi?id=175513

Reviewed by Mark Lam.

  • assembler/MacroAssemblerARM.cpp: Added d16-d31 FP registers too.
6:59 PM Changeset in webkit [220628] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL's compileGetTypedArrayByteOffset needs to do caging
https://bugs.webkit.org/show_bug.cgi?id=175366

Reviewed by Saam Barati.

While implementing boxing in the DFG, I noticed that there was some missing boxing in the FTL. This
fixes the case in GetTypedArrayByteOffset, and files FIXMEs for more such cases.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetTypedArrayByteOffset):
(JSC::FTL::DFG::LowerDFGToB3::cagedMayBeNull):

  • runtime/ArrayBuffer.h:
  • runtime/ArrayBufferView.h:
  • runtime/JSArrayBufferView.h:
3:14 PM Changeset in webkit [220627] by rniwa@webkit.org
  • 43 edits
    3 adds in trunk

Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
https://bugs.webkit.org/show_bug.cgi?id=175474
.:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

  • Configurations/FeatureDefines.xcconfig:
  • runtime/CommonIdentifiers.h:

Source/WebCore:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and added a stub implementation for DataTransferItemList
and DataTransferItem to make it compile. DataTransferItemList is created lazily by DataTransfer.items,
and its lifetime is tied to DataTransfer by forwarding ref and deref.

See https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface

Tests: editing/pasteboard/datatransfer-idl.html

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::items): Added. Create DataTransferItemList lazily

  • dom/DataTransfer.h:
  • dom/DataTransfer.idl:
  • dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::DataTransferItem): Added a stub implementation.
(WebCore::DataTransferItem::~DataTransferItem): Ditto.
(WebCore::DataTransferItem::getAsString const): Ditto.
(WebCore::DataTransferItem::getAsFile const): Ditto.

  • dom/DataTransferItem.h:

(WebCore::DataTransferItemList): Devirtualized functions.
(WebCore::DataTransferItemList::kind const):
(WebCore::DataTransferItemList::type const):

  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.cpp: Added.

(WebCore::DataTransferItemList::length const): Added a stub implementation.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::DataTransferItemList::add): Ditto.
(WebCore::DataTransferItemList::remove): Ditto.
(WebCore::DataTransferItemList::clear): Ditto.

  • dom/DataTransferItemList.h:

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::~DataTransferItemList): Deleted.
(WebCore::DataTransferItemList::ref): Forwards to DataTransfer's ref.
(WebCore::DataTransferItemList::deref): Ditto.

  • dom/DataTransferItemList.idl: Updated to match the latest specification.
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Added.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled const): Added.

Source/WebCore/PAL:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and disabled the feature by default.

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDataTransferItemsEnabled): Added to be used by WebKitTestRunner.
(WKPreferencesGetDataTransferItemsEnabled): Ditto.

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Replaced the build flag by a runtime flag and disabled the feature by default.

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Disables dataTransfer.items by default.
(-[WebPreferences dataTransferItemsEnabled]): Added.
(-[WebPreferences setDataTransferItemsEnabled:]): Added.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WTF:

Reviewed by Wenson Hsieh.

  • wtf/FeatureDefines.h:

Tools:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

<rdar://problem/33844628>

Reviewed by Wenson Hsieh.

Added a W3C-style IDL test.

  • editing/pasteboard/datatransfer-idl.html: Added.
2:58 PM Changeset in webkit [220626] by Chris Dumez
  • 34 edits in trunk

Address flakiness related to download tests
https://bugs.webkit.org/show_bug.cgi?id=175338

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that download callbacks are no longer logged.

  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click-expected.txt:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click-expected.txt:

Tools:

  • Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished() is actually queried when a download completes. Previously, this would be identical to a call to testRunner.waitUntilDone() because any download completion would call testRunner.notifyDone().
  • Disable logging of download callbacks by default and add a testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to enable such logging.
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setShouldLogDownloadCallbacks):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::downloadDidStart):
(WTR::TestController::decideDestinationWithSuggestedFilename):
(WTR::TestController::downloadDidFinish):
(WTR::TestController::downloadDidFail):
(WTR::TestController::downloadDidCancel):

  • WebKitTestRunner/TestController.h:

(WTR::TestController::setShouldLogDownloadCallbacks):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

LayoutTests:

Unmark several download tests as flaky.

  • fast/dom/HTMLAnchorElement/anchor-download-synthetic-click.html:
  • fast/dom/HTMLAnchorElement/anchor-download-user-triggered-synthetic-click.html:
  • fast/dom/HTMLAnchorElement/anchor-download.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-convert-to-download.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-backslash.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-no-extension.html:
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download.html:
  • fast/dom/HTMLAnchorElement/anchor-nodownload-set.html:
  • http/tests/download/anchor-download-attribute-content-disposition.html:
  • http/tests/download/anchor-download-no-extension.html:
  • http/tests/download/anchor-download-no-value.html:
  • http/tests/download/area-download-expected.txt:
  • http/tests/download/area-download.html:
  • http/tests/security/anchor-download-allow-blob-expected.txt:
  • http/tests/security/anchor-download-allow-blob.html:
  • http/tests/security/anchor-download-allow-data-expected.txt:
  • http/tests/security/anchor-download-allow-data.html:
  • http/tests/security/anchor-download-allow-sameorigin.html:

Update download tests to explicitly enable download callbacks logging.

11:44 AM Changeset in webkit [220625] by fpizlo@apple.com
  • 14 edits in trunk

Caging shouldn't have to use a patchpoint for adding
https://bugs.webkit.org/show_bug.cgi?id=175483

Reviewed by Mark Lam.
Source/JavaScriptCore:

Caging involves doing a Add(ptr, largeConstant). All of B3's heuristics for how to deal with
constants and associative operations dictate that you always want to sink constants. For example,
Add(Add(a, constant), b) always becomes Add(Add(a, b), constant). This is profitable because in
typical code, it reveals downstream optimizations. But it's terrible in the case of caging, because
we want the large constant (which is shared by all caging operations) to be hoisted. Reassociating to
sink constants obscures the constant in this case. Currently, moveConstants is not smart enough to
reassociate, so instead of sinking largeConstant, it tries (and often fails) to sink some other
constants instead. Without some hacks, this is a 5% Kraken regression and a 1.6% Octane regression.
It's not clear that moveConstants could ever be smart enough to rematerialize that constant and then
hoist it - that would require quite a bit of algebraic reasoning. But the only case we know of where
our current constant reassociation heuristics are wrong is caging. So, we can get away with some
hacks for just stopping B3's reassociation only in this specific case.

Previously, we achieved this by concealing the Add(ptr, largeConstant) inside a patchpoint. That's
OK, but patchpoints are expensive. They require a SharedTask instance. They require callbacks from
the backend, including during register allocation. And they cannot be CSE'd. We do want B3 to know
that if we cage the same pointer in two places, both places will compute the same value.

This patch improves the situation by introducing the Opaque opcode. This is handled by LowerToAir as
if it was Identity, but all prior phases treat it as an unknown pure unary idempotent operation. I.e.
they know that Opaque(x) == Opaque(x) and that Opaque(Opaque(x)) == Opaque(x). But they don't know
that Opaque(x) == x until LowerToAir. So, you can use Opaque exactly when you know that B3 will mess
up your code but Air won't. (Currently we know of no cases where Air messes things up on a large
enough scale to warrant new opcodes.)

This change is perf-neutral, but may start to help as I add more uses of caged() in the FTL. It also
makes the code a bit less ugly.

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::shouldCopyPropagate):
(JSC::B3::Air::LowerToAir::lower):

  • b3/B3Opcode.cpp:

(WTF::printInternal):

  • b3/B3Opcode.h:
  • b3/B3ReduceStrength.cpp:
  • b3/B3Validate.cpp:
  • b3/B3Value.cpp:

(JSC::B3::Value::effects const):
(JSC::B3::Value::key const):
(JSC::B3::Value::isFree const):
(JSC::B3::Value::typeFor):

  • b3/B3Value.h:
  • b3/B3ValueKey.cpp:

(JSC::B3::ValueKey::materialize const):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::opaque):

  • ftl/FTLOutput.h:

Websites/webkit.org:


Write documentation for the new Opaque opcode.

  • docs/b3/intermediate-representation.html:
11:40 AM Changeset in webkit [220624] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

ScopedArguments overflow storage needs to be in the JSValue gigacage
https://bugs.webkit.org/show_bug.cgi?id=174923

Reviewed by Saam Barati.

ScopedArguments overflow storage sits at the end of the ScopedArguments object, so we put that
object into the JSValue gigacage.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitScopedArgumentsGetByVal):

  • runtime/ScopedArguments.h:

(JSC::ScopedArguments::subspaceFor):
(JSC::ScopedArguments::overflowStorage const):

Note: See TracTimeline for information about the timeline view.