Timeline
Oct 2, 2017:
- 11:42 PM Changeset in webkit [222771] by
-
- 8 edits2 moves in trunk/Source
Move LineEnding.{h,cpp} from WebCore/platform/text to wtf/text
https://bugs.webkit.org/show_bug.cgi?id=176575
Reviewed by Alex Christensen.
Source/WebCore:
No new tests because there is no behavior change.
- WebCore.xcodeproj/project.pbxproj:
- fileapi/BlobBuilder.cpp:
- html/FormDataList.cpp:
Source/WTF:
As part of the PAL effort, we're trying to move everything out of WebCore/platform, one-by-one.
These LineEnding files belong in WTF.
- WTF.xcodeproj/project.pbxproj:
- wtf/text/LineEnding.cpp: Renamed from Source/WebCore/platform/text/LineEnding.cpp.
(WTF::normalizeLineEndingsToCRLF):
- wtf/text/LineEnding.h: Renamed from Source/WebCore/platform/text/LineEnding.h.
- 11:36 PM Changeset in webkit [222770] by
-
- 2 edits in trunk/Tools
Make WSL demo compatible with Microsoft Edge
https://bugs.webkit.org/show_bug.cgi?id=177643
Reviewed by Saam Barati.
This patch does two things. The first is it migrates a loop over ParentNode.children to a legacy style loop
because Microsoft Edge throws an exception when trying to use a for...of loop with it. This patch also hides
the compilation behind a setTimeout(0) so there is some indication that something is happening during a
compile.
- Tools/WebGPUShadingLanguageRI/index.html:
- 10:31 PM Changeset in webkit [222769] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: Rename methods ending in *Json() as *JSON()
https://bugs.webkit.org/show_bug.cgi?id=177793
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-02
Reviewed by Matt Baker.
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceTypeJSON):
(WebCore::InspectorPageAgent::cachedResourceTypeJSON):
(WebCore::InspectorPageAgent::buildObjectForFrameTree):
(WebCore::InspectorPageAgent::resourceTypeJson): Deleted.
(WebCore::InspectorPageAgent::cachedResourceTypeJson): Deleted.
- inspector/InspectorPageAgent.h:
- 10:10 PM Changeset in webkit [222768] by
-
- 5 edits2 adds in trunk
REGRESSION(r222595): Intermittent crash while accessing DataTransferItemList
https://bugs.webkit.org/show_bug.cgi?id=177791
<rdar://problem/34781456>
Reviewed by Ryosuke Niwa.
Source/WebCore:
DataTransfer::moveDragState() currently attempts to move the other DataTransfer's DataTransferItemList and
DragImageLoader as members of its own. This is incorrect, since both of these entities hold raw references of
some form to the other DataTransfer, yet they are held as unique_ptrs in the new DataTransfer. To fix this, we
(1) remove the line of code that moves the item list, since item lists will be lazily generated on the new
DataTransfer anyways, and (2) update the DataTransfer pointer on the old DataTransfer's DragImageLoader after
moving it to the new DataTransfer.
Test: editing/pasteboard/drag-end-crash-accessing-item-list.html
- dom/DataTransfer.cpp:
(WebCore::DragImageLoader::moveToDataTransfer):
(WebCore::DataTransfer::moveDragState):
LayoutTests:
Add a new layout test that simulates the crash encountered in this bug by forcing a garbage collection sweep
right before accessing the pasteboard in a "dragend" event handler.
- TestExpectations:
- editing/pasteboard/drag-end-crash-accessing-item-list-expected.txt: Added.
- editing/pasteboard/drag-end-crash-accessing-item-list.html: Added.
- platform/mac-wk1/TestExpectations:
- 9:35 PM Changeset in webkit [222767] by
-
- 5 edits in trunk/Source/WebCore
Rename computeSharedStringHash() overload taking a URL to computedVisitedLinkHash()
https://bugs.webkit.org/show_bug.cgi?id=177776
Reviewed by Alex Christensen.
- dom/VisitedLinkState.cpp:
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- html/HTMLAnchorElement.h:
(WebCore::HTMLAnchorElement::visitedLinkHash const):
- platform/SharedStringHash.cpp:
(WebCore::computeVisitedLinkHash):
- platform/SharedStringHash.h:
- 8:07 PM Changeset in webkit [222766] by
-
- 1 edit6 adds in trunk/LayoutTests
Merge three Blink test cases
https://bugs.webkit.org/show_bug.cgi?id=177797
<rdar://problem/27331975>
Unreviewed merge of Blink test cases.
Merge three test cases from the following Blink change:
https://chromium.googlesource.com/chromium/blink/+/17c5b48f130e4ebb796f9db89628f887624db4ef
Relevant fixes had been made in WebKit over the years, but we did not include proper
test coverage.
- fast/dom/assertion-on-node-removal-expected.txt: Added.
- fast/dom/assertion-on-node-removal.html: Added.
- fast/forms/control-detach-crash-expected.txt: Added.
- fast/forms/control-detach-crash.html: Added.
- svg/custom/assert-on-node-removal-expected.txt: Added.
- svg/custom/assert-on-node-removal.html: Added.
- 6:02 PM Changeset in webkit [222765] by
-
- 5 edits2 adds in trunk
AX: [ATK] The value of aria-level is not exposed on non-heading roles
https://bugs.webkit.org/show_bug.cgi?id=177775
Reviewed by Chris Fleizach.
Source/WebCore:
Expose the value of aria-level via the "level" AtkObject attribute, as is currently
done for headings.
Test: accessibility/gtk/aria-level.html
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetAttributes):
Tools:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::hierarchicalLevel const):
LayoutTests:
- accessibility/gtk/aria-level-expected.txt: Added.
- accessibility/gtk/aria-level.html: Added.
- 5:42 PM Changeset in webkit [222764] by
-
- 4 edits in trunk
WeakPtr should have a move constructor
https://bugs.webkit.org/show_bug.cgi?id=177789
Reviewed by Chris Dumez.
Source/WTF:
- wtf/WeakPtr.h: Now that we just have a RefPtr data member,
the default operators are sufficient.
Tools:
Chris made me write an API test. It wasn't that painful.
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::TEST):
- 5:37 PM Changeset in webkit [222763] by
-
- 5 edits in trunk
[Payment Request] Validate payment method identifiers
https://bugs.webkit.org/show_bug.cgi?id=177794
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
- web-platform-tests/payment-request/payment-request-ctor-pmi-handling.https-expected.txt:
Source/WebCore:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::isValidStandardizedPaymentMethodIdentifier):
(WebCore::isValidURLBasedPaymentMethodIdentifier):
(WebCore::convertAndValidatePaymentMethodIdentifier):
(WebCore::PaymentRequest::create):
- Modules/paymentrequest/PaymentRequest.h:
- 5:29 PM Changeset in webkit [222762] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Escape more characters in posix string conversion
https://bugs.webkit.org/show_bug.cgi?id=177761
<rdar://problem/34506832>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-02
Reviewed by Brian Burg.
- UserInterface/Models/Resource.js:
(WI.Resource.prototype.generateCURLCommand.escapeStringPosix):
Escape '!' to '\041' in posix strings ($'...') since '!' may have special behavior at times.
- 5:22 PM Changeset in webkit [222761] by
-
- 10 edits in trunk/Source
Move more code into PasteboardCustomData
https://bugs.webkit.org/show_bug.cgi?id=177795
Reviewed by Wenson Hsieh.
Source/WebCore:
Moved sharedBufferFromCustomData, customDataFromSharedBuffer, and customWebKitPasteboardDataType into
PasteboardCustomData as createSharedBuffer, fromSharedBuffer, and cocoaType respectively.
- platform/Pasteboard.cpp:
(WebCore::PasteboardCustomData::createSharedBuffer const): Renamed from sharedBufferFromCustomData.
(WebCore::PasteboardCustomData::fromSharedBuffer): Renamed from customDataFromSharedBuffer.
- platform/Pasteboard.h:
- platform/StaticPasteboard.cpp:
(WebCore::StaticPasteboard::commitToPasteboard): Now initializes with an empty origin string.
- platform/cocoa/PasteboardCocoa.mm:
(WebCore::PasteboardCustomData::cocoaType): Moved here from Pasteboard.h
(WebCore::Pasteboard::readStringInCustomData):
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard typeIdentifiersToLoadForRegisteredTypeIdentfiers:]):
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::write):
Source/WebKit:
Added the support for encoding and decoding the origin string in PasteboardCustomData.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<PasteboardCustomData>::encode):
(IPC::ArgumentCoder<PasteboardCustomData>::decode):
- 5:13 PM Changeset in webkit [222760] by
-
- 6 edits in trunk
[Mac] Use safer decoding practices for NSKeyedUnarchiver
https://bugs.webkit.org/show_bug.cgi?id=175887
<rdar://problem/33435281>
Reviewed by Daniel Bates.
Source/WebCore:
- loader/archive/cf/LegacyWebArchiveMac.mm:
(WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Use NSSecureCoding to unarchive.
(WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto for archiving.
- testing/cocoa/WebArchiveDumpSupport.mm:
(WebCoreTestSupport::createCFURLResponseFromResponseData): Update to use NSSecureCoding if possible.
LayoutTests:
Mark two tests as flaky for now, until the relevant CFNetwork changes are available on the test systems.
- webarchive/loading/cache-expired-subresource.html
- webarchive/loading/test-loading-archive-subresource-null-mimetype.html
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
- 5:09 PM WebKitGTK/2.18.x edited by
- (diff)
- 4:55 PM Changeset in webkit [222759] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Selecting child layers with keyboard causes Compositing Reason popover to become misaligned
https://bugs.webkit.org/show_bug.cgi?id=150551
Patch by Ross Kirsling <Ross Kirsling> on 2017-10-02
Reviewed by Matt Baker.
contentsetter should only be used when NOT repositioning the popover.
presentNewContentWithFrameexists to update content and position at once.
- UserInterface/Views/LayerDetailsSidebarPanel.js:
(WI.LayerDetailsSidebarPanel.prototype._showPopoverForSelectedNode):
(WI.LayerDetailsSidebarPanel.prototype._presentPopover):
Fix new sidebar.
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WI.LayerTreeDetailsSidebarPanel.prototype._updatePopoverForSelectedNode):
Fix legacy sidebar.
- 4:44 PM Changeset in webkit [222758] by
-
- 3 edits in trunk/Source/WebCore
Use InlineTextBox::lineFont() in more places
https://bugs.webkit.org/show_bug.cgi?id=177749
Reviewed by Zalan Bujtas.
Currently InlineTextBox::paint() calls InlineTextBox::lineFont() to compute the font for the
line and then passes this value to various paint helper functions. The computation is not
expensive and it is sufficient to have the individual paint helper functions compute it
directly. We should have the individual paint helper functions compute it directly. This
will help towards sharing more code throughout InlineTextBox by reducing the noise of
passing the font for the line.
No functionality changed. So, no new tests.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintTextSubrangeBackground):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintDocumentMarkers):
- rendering/InlineTextBox.h:
- 4:40 PM Changeset in webkit [222757] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 4:34 PM Changeset in webkit [222756] by
-
- 8 edits in trunk/Source/WebCore
[Curl] Implement missing async method in RecourceHandle and make it actually async
https://bugs.webkit.org/show_bug.cgi?id=173964
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-02
Reviewed by Alex Christensen.
- platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::continueWillSendRequest): Deleted.
(WebCore::ResourceHandle::continueDidReceiveResponse): Deleted.
(WebCore::ResourceHandle::continueCanAuthenticateAgainstProtectionSpace): Deleted.
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::start):
(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::suspend):
(WebCore::CurlRequest::resume):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::didCancelTransfer):
(WebCore::CurlRequest::finalizeTransfer):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::invokeDidReceiveResponse):
(WebCore::CurlRequest::completeDidReceiveResponse):
(WebCore::CurlRequest::setRequestPaused):
(WebCore::CurlRequest::setCallbackPaused):
(WebCore::CurlRequest::pausedStatusChanged):
(WebCore::CurlRequest::setPaused): Deleted.
- platform/network/curl/CurlRequest.h:
(WebCore::CurlRequest::needToInvokeDidReceiveResponse const):
(WebCore::CurlRequest::isPaused const):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::platformContinueSynchronousDidReceiveResponse):
- platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::curlDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::continueDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::platformContinueSynchronousDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::continueAfterDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::shouldRedirectAsGET):
- platform/network/curl/ResourceHandleCurlDelegate.h:
- platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::shouldRedirect):
(WebCore::ResourceResponse::isMovedPermanently const):
(WebCore::ResourceResponse::isFound const):
(WebCore::ResourceResponse::isSeeOther const):
(WebCore::ResourceResponse::isNotModified const):
(WebCore::ResourceResponse::isUnauthorized const):
- 4:33 PM Changeset in webkit [222755] by
-
- 1 copy in tags/Safari-604.3.4
Tag Safari-604.3.4.
- 4:04 PM Changeset in webkit [222754] by
-
- 10 edits18 adds in trunk/LayoutTests
[Payment Request] Update payment-request imported tests
https://bugs.webkit.org/show_bug.cgi?id=177786
Reviewed by Zalan Bujtas.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- web-platform-tests/payment-request/PaymentAddress/attributes-and-toJSON-method-manual.https.html: Added.
- web-platform-tests/payment-request/PaymentAddress/w3c-import.log: Added.
- web-platform-tests/payment-request/algorithms-manual.https.html: Added.
- web-platform-tests/payment-request/change-shipping-option-manual.https.html: Added.
- web-platform-tests/payment-request/payment-request-canmakepayment-method.https.html:
- web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
- web-platform-tests/payment-request/payment-request-constructor.https.html:
- web-platform-tests/payment-request/payment-request-ctor-pmi-handling.https.html:
- web-platform-tests/payment-request/payment-response/complete-method-manual.https.html: Added.
- web-platform-tests/payment-request/payment-response/helpers.js:
(async.runManualTest):
- web-platform-tests/payment-request/payment-response/methodName-attribute-manual.https.html: Added.
- web-platform-tests/payment-request/payment-response/payerEmail-attribute-manual.https.html: Added.
- web-platform-tests/payment-request/payment-response/payerName-attribute-manual.https.html: Added.
- web-platform-tests/payment-request/payment-response/payerPhone-attribute-manual.https.html: Added.
- web-platform-tests/payment-request/payment-response/requestId-attribute-manual.https.html: Added.
- web-platform-tests/payment-request/payment-response/shippingAddress-attribute-manual.https.html: Added.
- web-platform-tests/payment-request/payment-response/shippingOption-attribute-manual.https.html: Added.
- web-platform-tests/payment-request/rejects_if_not_active.https.html: Added.
- web-platform-tests/payment-request/shipping-address-changed-manual.https.html: Added.
- web-platform-tests/payment-request/updateWith-method-pmi-handling-manual.https.html: Added.
- web-platform-tests/payment-request/user-abort-algorithm-manual.https.html: Added.
- web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html: Added.
- web-platform-tests/payment-request/w3c-import.log:
LayoutTests:
- platform/mac-wk2/TestExpectations:
- 3:28 PM Changeset in webkit [222753] by
-
- 2 edits1 move2 adds1 delete in trunk/LayoutTests
Additional rebaselining of js/dom/global-constructors-attributes.html.
Unreviewed test gardening.
- platform/mac-sierra-wk1/js/dom/global-constructors-attributes-expected.txt: Renamed from LayoutTests/platform/mac-sierra-wk2/js/dom/global-constructors-attributes-expected.txt.
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk2/js/dom/global-constructors-attributes-expected.txt: Removed.
- 3:21 PM Changeset in webkit [222752] by
-
- 2 edits in trunk/Source/WTF
NULL WeakPtr should not malloc!
https://bugs.webkit.org/show_bug.cgi?id=177773
Reviewed by Antti Koivisto.
Translating NULL into malloc is... inefficient.
- wtf/WeakPtr.h:
(WTF::WeakPtr::WeakPtr):
(WTF::WeakPtr::operator=):
(WTF::WeakPtr::clear): Make m_ref lazy so that a NULL m_ref can represent
a NULL pointer. Normal dereference is no slower because we can rely on
the fact that dereference of NULL should crash. operator bool() and get()
incur an extra branch. That's probably worth it to avoid malloc
for NULL.
- 3:10 PM Changeset in webkit [222751] by
-
- 7 edits in trunk/Tools
WSL should be *
https://bugs.webkit.org/show_bug.cgi?id=177705
Rubber stamped by Keith Miller.
When I first wrote the prototype, I thought it would be cool to use for pointers. Nobody agrees. I've
gotten so much feedback to use *. This changes pointers to use *.
- WebGPUShadingLanguageRI/DereferenceExpression.js:
(DereferenceExpression.prototype.toString):
(DereferenceExpression):
- WebGPUShadingLanguageRI/Intrinsics.js:
(Intrinsics):
- WebGPUShadingLanguageRI/Parse.js:
(parseType):
(parsePossiblePrefix):
- WebGPUShadingLanguageRI/PtrType.js:
(PtrType.prototype.toString):
(PtrType):
- WebGPUShadingLanguageRI/StandardLibrary.js:
- WebGPUShadingLanguageRI/Test.js:
(tests.simpleDereference):
(tests.dereferenceStore):
(tests.simpleMakePtr):
(tests.loadNull):
(tests.storeNull):
(tests.returnNull):
(tests.dereferenceDefaultNull):
(tests.defaultInitializedNull):
(tests.passNullToPtrMonomorphic):
(tests.passNullToPtrPolymorphic):
(tests.passNullAndNotNull):
(tests.passNullAndNotNullFullPoly):
(tests.passNullAndNotNullFullPolyReverse):
(tests.chainGeneric):
(tests.chainStruct):
(tests.chainStructNewlyValid):
(tests.chainStructDevice):
(tests.paramChainStructDevice):
(tests.simpleProtocolExtends):
(tests.protocolExtendsTwo):
(tests.overrideSubscriptStruct):
(tests.overrideSubscriptStructAndDoStores):
(tests.overrideSubscriptStructAndUsePointers):
(tests.overrideSubscriptStructAndUsePointersIncorrectly):
(tests.makeArrayRefFromPointer):
(tests.nonArrayRefArrayLengthFail):
(tests.constexprIsNotLValuePtr):
(tests.genericAccessors):
(tests.nestedSubscriptLValueEmulationSimple):
(tests.nestedSubscriptLValueEmulationGeneric):
(tests.shaderTypes):
(tests.enumPtrBase):
(tests.mutuallyRecursiveStructWithPointersBroken):
(tests.mutuallyRecursiveStructWithPointers):
(tests.linkedList):
(tests.pointerToPointer):
(tests.pointerGetter):
(tests.operatorCastWithTypeVariableInferredFromReturnType):
(tests.loneSetterPointer):
(tests.anderWithNothingWrong):
(tests.anderWithWrongNumberOfArguments):
(tests.anderDoesntReturnPointer):
(tests.anderDoesntTakeReference):
(tests.anderWithArrayRef):
(tests.pointerIndexGetter):
(tests.loneIndexSetterPointer):
(tests.indexAnderWithNothingWrong):
(tests.indexAnderWithWrongNumberOfArguments):
(tests.indexAnderDoesntReturnPointer):
(tests.indexAnderDoesntTakeReference):
(tests.indexAnderWithArrayRef):
(tests.devicePtrPtr):
(tests.threadgroupPtrPtr):
(tests.constantPtrPtr):
(tests.pointerIndexGetterInProtocol):
(tests.loneIndexSetterPointerInProtocol):
(tests.indexAnderWithNothingWrongInProtocol):
(tests.indexAnderWithWrongNumberOfArgumentsInProtocol):
(tests.indexAnderDoesntReturnPointerInProtocol):
(tests.indexAnderDoesntTakeReferenceInProtocol):
(tests.indexAnderWithArrayRefInProtocol):
(tests.andReturnedArrayRef):
- 3:01 PM Changeset in webkit [222750] by
-
- 8 edits in trunk/Tools
WSL should be fine with &foo()[i] if foo() returns a []
https://bugs.webkit.org/show_bug.cgi?id=177704
Reviewed by Saam Barati.
Previously, we'd determine if a property access expression (base.field or base[index]) was an lvalue by
asking if its base was an lvalue. This is right in all cases except if the base is of type []. Then, the
property access expression is an lvalue so long as there is a setter or ander.
This fixes the issue and adds a test.
Also, this makes error messages in the case that something is not an lvalue a lot better. If something
is not an lvalue because we could not find anders or setters, then we will tell you why we could not
find them.
- WebGPUShadingLanguageRI/Checker.js:
(Checker.prototype.visitAssignment):
(Checker.prototype.visitReadModifyWriteExpression):
(Checker.prototype.visitMakePtrExpression):
(Checker.prototype._finishVisitingPropertyAccess):
- WebGPUShadingLanguageRI/DotExpression.js:
(DotExpression.prototype.get fieldName):
(DotExpression.prototype.get isLValue): Deleted.
(DotExpression.prototype.get addressSpace): Deleted.
- WebGPUShadingLanguageRI/IndexExpression.js:
(IndexExpression.prototype.get index):
(IndexExpression.prototype.get isLValue): Deleted.
(IndexExpression.prototype.get addressSpace): Deleted.
- WebGPUShadingLanguageRI/PropertyAccessExpression.js:
(PropertyAccessExpression):
(PropertyAccessExpression.prototype.get isLValue):
(PropertyAccessExpression.prototype.set isLValue):
- WebGPUShadingLanguageRI/PropertyResolver.js:
(PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder.prototype.visitMakeArrayRefExpression):
(PropertyResolver.prototype._visitRValuesWithinLValue.RValueFinder):
(PropertyResolver.prototype._visitRValuesWithinLValue):
- WebGPUShadingLanguageRI/Test.js:
(tests.storeNullArrayRef):
(tests.andReturnedArrayRef):
- 3:00 PM Changeset in webkit [222749] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Do not hardcode font family in served remote inspector HTML snippets
https://bugs.webkit.org/show_bug.cgi?id=177742
Reviewed by Carlos Garcia Campos.
Instead of hardcoding Cantarell as the font used for the HTML snippets served
by the remote inspector handler, use "font: menu" to obtain the system UI
font, plus a "font-size" rule for adjusting the size.
- UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
(WebKit::RemoteInspectorProtocolHandler::handleRequest): Change the
CSS rules in the served snippet.
- 2:58 PM Changeset in webkit [222748] by
-
- 2 edits in trunk/Source/JavaScriptCore
VMTraps shouldn't crash if it sees an exception it doesn't understand.
https://bugs.webkit.org/show_bug.cgi?id=177780
Reviewed by Mark Lam.
VMTraps could see a JIT breakpoint (SegV) for any number of
reasons it doesn't understand. e.g. a bug in JIT code, Wasm OOB,
etc. This patch makes it handle that case gracefully. It's worth
noting that this means there's no way to know if, due to a bug, we
didn't accurately track all the VMTraps we installed. I'm not sure
if there is a good solution to that problem though.
- runtime/VMTraps.cpp:
- 2:46 PM Changeset in webkit [222747] by
-
- 2 edits in trunk/Source/WebKitLegacy
[Win] Link error: cannot open file 'WebKitGUID.lib'
https://bugs.webkit.org/show_bug.cgi?id=177759
Reviewed by Alex Christensen.
For backward compatibility reasons, this library should not be renamed from
WebKitGUID.lib to WebKitLegacyGUID.lib.
- PlatformWin.cmake:
- 2:44 PM Changeset in webkit [222746] by
-
- 3 edits in trunk/Source/WebCore
PasteImage tests are failing on debug builds
https://bugs.webkit.org/show_bug.cgi?id=177778
Reviewed by Wenson Hsieh.
After r222702, PlatformPasteboard is no longer responsible for adding "Files" as a type"
as DataTransfer takes care of it now. Removed the code to do this from PlatformPasteboardIOS.mm
and PlatformPasteboardMac.mm so that we don't fail assertions in debug builds.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
- 2:42 PM Changeset in webkit [222745] by
-
- 2 edits in trunk/Source/WebCore
No need to truncate text after calling InlineTextBox::text()
https://bugs.webkit.org/show_bug.cgi?id=177748
Reviewed by Zalan Bujtas.
Following r222670 it is no longer necessary to explicitly truncate the text run length
as InlineTextBox::text() returns a text run with respect to the truncation of the text box.
No functionality changed. So, no new tests.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- 2:40 PM Changeset in webkit [222744] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Add missing exception check for the custom-get-set-inline-caching-one-level-up-proto-chain.js
test that I added. It uncovered a pre-existing missing exception check.
- runtime/JSObject.cpp:
(JSC::JSObject::putInlineSlow):
- 2:31 PM Changeset in webkit [222743] by
-
- 2 edits in trunk/Tools
Guard iOS webkitGetAsEntry API tests on older iOS versions
Unreviewed test gardening. After r222688, these tests require custom pasteboard data to be enabled by default,
so don't run them against shipping iOS.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
- 2:31 PM Changeset in webkit [222742] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Ensure popovers are not malformed on window resize.
https://bugs.webkit.org/show_bug.cgi?id=177771
Patch by Ross Kirsling <Ross Kirsling> on 2017-10-02
Reviewed by Joseph Pecoraro.
- UserInterface/Views/Popover.js:
Ensure stale
arrow-*CSS classes are removed on update, even if our content didn't change.
- 2:31 PM Changeset in webkit [222741] by
-
- 4 edits in trunk/Source
Add makeWeakPtr variant that takes pointer
https://bugs.webkit.org/show_bug.cgi?id=177767
Reviewed by Zalan Bujtas.
Source/WebCore:
Use it.
- rendering/SelectionRangeData.h:
(WebCore::SelectionRangeData::Context::Context):
Source/WTF:
- wtf/WeakPtr.h:
(WTF::makeWeakPtr):
This version deals with the nullptr.
- 2:15 PM WebKitGTK/2.18.x edited by
- (diff)
- 2:06 PM Changeset in webkit [222740] by
-
- 6 edits in trunk/Source/WebCore
Make RenderPtr a type alias of std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=177739
Reviewed by Sam Weinig.
It just needs a custom deleter.
- page/FrameView.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::insertChildInternal):
- rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):
- rendering/RenderObject.cpp:
(WebCore::RenderObjectDeleter::operator() const):
(WebCore::RenderObject::willBeDestroyed):
- rendering/RenderPtr.h:
(WebCore::createRenderer):
(WebCore::static_pointer_cast):
Make this safer with downcast.
(WebCore::RenderPtr::RenderPtr): Deleted.
(WebCore::RenderPtr::~RenderPtr): Deleted.
(WebCore::RenderPtr::get const): Deleted.
(WebCore::RenderPtr::operator* const): Deleted.
(WebCore::RenderPtr::operator-> const): Deleted.
(WebCore::RenderPtr::operator! const): Deleted.
(WebCore::RenderPtr::operator UnspecifiedBoolType const): Deleted.
(WebCore::RenderPtr::operator=): Deleted.
(WebCore::RenderPtr::swap): Deleted.
(WebCore::RenderPtr::operator==): Deleted.
(WebCore::RenderPtr::operator!=): Deleted.
(WebCore::RenderPtr<T>::clear): Deleted.
(WebCore::RenderPtr<T>::leakPtr): Deleted.
(WebCore::RenderPtr<T>::RenderPtr): Deleted.
(WebCore::=): Deleted.
(WebCore::swap): Deleted.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.
(WebCore::getPtr): Deleted.
(WTF::HashTraits<WebCore::RenderPtr<T>>::emptyValue): Deleted.
(WTF::HashTraits<WebCore::RenderPtr<T>>::peek): Deleted.
We already have hash traits for std::unique_ptr.
- 1:24 PM Changeset in webkit [222739] by
-
- 40 edits7 adds in trunk
Web Inspector: Include Beacon and Ping requests in Network tab
https://bugs.webkit.org/show_bug.cgi?id=177641
<rdar://problem/33086839>
Reviewed by Chris Dumez.
Source/JavaScriptCore:
- inspector/protocol/Page.json:
Include new "Beacon" and "Ping" resource types.
Source/WebCore:
Tests: http/tests/inspector/network/beacon-type.html
http/tests/inspector/network/ping-type.html
- Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):
Fix a typo.
- loader/PingLoader.cpp:
(WebCore::PingLoader::startPingLoad):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
Include InspectorInstrumentation hooks for ping network loads.
- loader/LoaderStrategy.h:
- platform/network/PingHandle.h:
Include an optional ResourceResponse in the ping load completion callback.
If available this will be enough for Web Inspector to include details such
as the response statusCode.
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willSendRequestOfTypeImpl):
(WebCore::InspectorInstrumentation::continueAfterPingLoaderImpl): Deleted.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willSendRequestOfType):
(WebCore::InspectorInstrumentation::continueAfterPingLoader): Deleted.
- inspector/InspectorNetworkAgent.cpp:
(WebCore::resourceTypeForCachedResource):
(WebCore::resourceTypeForLoadType):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::willSendRequestOfType):
- inspector/InspectorNetworkAgent.h:
Make a general willSendRequestOfType hook when sending a request that does
not go through normal CachedResource loading. The Ping and Beacon requests
go through this process, we may also use this path for Preflight requests.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::resourceTypeJson):
(WebCore::InspectorPageAgent::cachedResourceType):
- inspector/InspectorPageAgent.h:
Small refactoring.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
New strings for Beacon/Ping.
- UserInterface/Images/Beacon.svg: Added.
- UserInterface/Views/ResourceIcons.css:
(.resource-icon.resource-type-ping .icon,):
(body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-ping .icon,):
(body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-ping .icon,):
New icon for Beacon/Ping. They share an icon since they are similiar in concept:
a request that is sent and the page doesn't expect a response.
- UserInterface/Controllers/FrameResourceManager.js:
(WI.FrameResourceManager.prototype._addNewResourceToFrameOrTarget):
When a sub-resource and a main-resource have the same URL we were not
distinguishing them. Use the resource type to distinguish them better.
- UserInterface/Models/SourceCode.js:
(WI.SourceCode.prototype._processContent):
Safer handling if the body was base64 encoded but an empty string.
- UserInterface/Models/Resource.js:
(WI.Resource.displayNameForType):
- UserInterface/Models/ResourceCollection.js:
(WI.ResourceCollection.verifierForType):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.shortDisplayNameForResourceType):
- UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype.get responseContentView):
New resource types.
- UserInterface/Views/ResourceContentView.js:
(WI.ResourceContentView.prototype.showMessage):
- UserInterface/Views/TextResourceContentView.js:
(WI.TextResourceContentView.prototype._contentDidPopulate):
Nicer display for empty content, which may be common for these requests.
Source/WebKit:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::didFinish):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
- NetworkProcess/PingLoad.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didFinishPingLoad):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.messages.in:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):
- WebProcess/Network/WebLoaderStrategy.h:
Pass an optional ResourceResponse back to the ping completion handler.
LayoutTests:
- http/tests/inspector/network/beacon-type-expected.txt: Added.
- http/tests/inspector/network/beacon-type.html: Added.
- http/tests/inspector/network/ping-type-expected.txt: Added.
- http/tests/inspector/network/ping-type.html: Added.
- http/tests/inspector/network/resources/beacon.php: Added.
- http/tests/inspector/network/resources/ping.php: Added.
Test for Beacon and Ping resource loads.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/win/TestExpectations:
Skip beacon tests where beacon is not supported.
- 1:06 PM Changeset in webkit [222738] by
-
- 5 edits in trunk/Source/WebCore
SelectionRangeData should not hold raw RenderObject pointers
https://bugs.webkit.org/show_bug.cgi?id=177677
<rdar://problem/34763060>
Reviewed by Sam Weinig.
SelectionRangeData::Context start and end renderers' lifetime is not strictly tied
to the lifetime of SelectionRangeData.
Covered by existing tests.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
- platform/DragImage.cpp:
(WebCore::createDragImageForRange):
- rendering/SelectionRangeData.cpp:
(WebCore::isValidRendererForSelection):
(WebCore::collect):
(WebCore::SelectionRangeData::set):
(WebCore::SelectionRangeData::clear):
(WebCore::SelectionRangeData::repaint const):
(WebCore::SelectionRangeData::collectBounds const):
(WebCore::SelectionRangeData::apply):
- rendering/SelectionRangeData.h:
(WebCore::SelectionRangeData::Context::Context):
(WebCore::SelectionRangeData::Context::start const):
(WebCore::SelectionRangeData::Context::end const):
(WebCore::SelectionRangeData::Context::startPosition const):
(WebCore::SelectionRangeData::Context::endPosition const):
(WebCore::SelectionRangeData::Context::operator== const):
(WebCore::SelectionRangeData::start const):
(WebCore::SelectionRangeData::end const):
(WebCore::SelectionRangeData::startPosition const):
(WebCore::SelectionRangeData::endPosition const):
- 1:04 PM October 2017 Meeting edited by
- Add clipboard API as a topic for 2017 contributor's meeting (diff)
- 1:00 PM Changeset in webkit [222737] by
-
- 4 edits in trunk
[WPE] Remove GnuTLS dependency
https://bugs.webkit.org/show_bug.cgi?id=177750
Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.
libgcrypt is used by default instead of GnuTLS.
See bug 163125
.:
- Source/cmake/OptionsWPE.cmake:
Source/WebCore:
- PlatformWPE.cmake:
- 12:49 PM Changeset in webkit [222736] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION: API tests WebKit.ProcessDidTerminateRequestedByClient and WebKit.ProcessDidTerminateWithReasonCrash are timing out
https://bugs.webkit.org/show_bug.cgi?id=177764
Reviewed by Chris Dumez.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageNavigationClient):
I shouldn't have reverted the A API telling the listener to continue if there's no client function.
- 12:48 PM Changeset in webkit [222735] by
-
- 4 edits in trunk
[WPE][GTK] Crash in webkit_web_resource_get_data_finish()
https://bugs.webkit.org/show_bug.cgi?id=177107
Reviewed by Michael Catanzaro.
Source/WebKit:
Handle errors in webkit_web_resource_get_data() callback.
- UIProcess/API/glib/WebKitWebResource.cpp:
(resourceDataCallback):
(webkit_web_resource_get_data):
Tools:
Add a test case to check we handle errors when webkit_web_resource_get_data() fails.
- TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
(webViewloadChanged):
(testWebResourceGetDataError):
(beforeAll):
- 12:40 PM Changeset in webkit [222734] by
-
- 3 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html as slow
https://bugs.webkit.org/show_bug.cgi?id=177615
Unreviewed test gardening.
- TestExpectations:
- platform/mac-wk2/TestExpectations:
- 12:34 PM Changeset in webkit [222733] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments after r222621
https://bugs.webkit.org/show_bug.cgi?id=177610
Reviewed by Darin Adler.
- rendering/RenderMenuList.cpp:
(RenderMenuList::didUpdateActiveOption):
- 12:23 PM Changeset in webkit [222732] by
-
- 5 edits in trunk/Source/WebCore
Remove length argument from TextPainter::paint()
https://bugs.webkit.org/show_bug.cgi?id=177758
Reviewed by Alex Christensen.
Have TextPainter.paint() use the length of the specified TextRun as opposed to
taking an explicit argument for the length of the TextRun.
Following r222670 InlineTextBox creates a TextRun with respect to the truncated
line. Prior to r222670 InlineTextBox did not do this and hence it had to pass both
the TextRun and truncated length to TextPainter.paint() to have the line painted.
Code that needs to paint a substring of a TextRun can still do so by using TextPainter.paintRange().
No functionality changed. So, no new tests.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
- rendering/TextPainter.cpp:
(WebCore::TextPainter::paint):
- rendering/TextPainter.h:
- 12:20 PM Changeset in webkit [222731] by
-
- 2 edits in trunk/Source/bmalloc
[Linux] Enable Gigacage in x64 Linux environment
https://bugs.webkit.org/show_bug.cgi?id=177745
Reviewed by Carlos Garcia Campos.
This patch enables Gigacage in x64 Linux environment.
Gigacage enforces a caged pointer to reference to the
specific memory region. This reduces the effectiveness
of some types of attacks setting a pointer to ArrayBuffer
and modifying arbitrary memory region.
- bmalloc/Gigacage.h:
- 12:04 PM Changeset in webkit [222730] by
-
- 2 edits in trunk/Source/WebCore
[curl] Crashes in CurlRequest::setupPUT()
https://bugs.webkit.org/show_bug.cgi?id=177733
Patch by Fujii Hironori <Fujii Hironori> on 2017-10-02
Reviewed by Alex Christensen.
Tests: http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupPUT): Null-check the result of request.httpBody().
- 12:02 PM Changeset in webkit [222729] by
-
- 2 edits in trunk/Source/WebKit
[WPE] Fix UIProcess build with GStreamer and without VIDEO
https://bugs.webkit.org/show_bug.cgi?id=177753
Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.
GStreamer builds fail when WebAudio is enabled but VIDEO disabled.
This is the WPE counterpart of bug 153135.
- UIProcess/API/wpe/PageClientImpl.h:
- 12:00 PM Changeset in webkit [222728] by
-
- 10 edits in trunk/Source/WebCore
[CURL] Should handle redirects in WebCore
https://bugs.webkit.org/show_bug.cgi?id=21242
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-02
Reviewed by Alex Christensen.
- platform/network/ResourceHandle.cpp:
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::enableAutoReferer): Deleted.
- platform/network/curl/CurlContext.h:
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didReceiveData):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::continueDidReceiveResponse):
(WebCore::ResourceHandle::continueWillSendRequest):
- platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::curlDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::shouldRedirectAsGET):
(WebCore::ResourceHandleCurlDelegate::willSendRequest):
(WebCore::ResourceHandleCurlDelegate::continueWillSendRequest):
(WebCore::ResourceHandleCurlDelegate::continueAfterWillSendRequest):
- platform/network/curl/ResourceHandleCurlDelegate.h:
- platform/network/curl/ResourceResponse.h:
- platform/network/curl/ResourceResponseCurl.cpp:
(WebCore::ResourceResponse::shouldRedirect):
(WebCore::ResourceResponse::isMovedPermanently const):
(WebCore::ResourceResponse::isFound const):
(WebCore::ResourceResponse::isSeeOther const):
(WebCore::ResourceResponse::isRedirection const): Deleted.
- 11:58 AM Changeset in webkit [222727] by
-
- 2 edits in trunk
[WPE] Do not require XSLT if disabled
https://bugs.webkit.org/show_bug.cgi?id=177752
Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.
- Source/cmake/OptionsWPE.cmake: libxslt is not a hard dep
- 11:29 AM Changeset in webkit [222726] by
-
- 2 edits in trunk/Source/WebCore
Crashes with guard malloc under RenderFullScreen::unwrapRenderer
https://bugs.webkit.org/show_bug.cgi?id=177760
Unreviewed.
- rendering/RenderFullScreen.cpp:
(WebCore::RenderFullScreen::unwrapRenderer):
The assert accesses 'this' after it has been deleted. It is not very valuable so remove the assert.
- 11:17 AM Changeset in webkit [222725] by
-
- 3 edits in trunk/Source/WebCore
GraphicsContext: remove unused ENABLE(3D_TRANSFORMS) && USE(TEXTURE_MAPPER)
https://bugs.webkit.org/show_bug.cgi?id=177757
Reviewed by Michael Catanzaro.
Remove three methods from the GraphicsContext class that were conditioned
with the ENABLE(3D_TRANSFORMS) and USE(TEXTURE_MAPPER) guards. These aren't
used anywhere at this point, but apparently used to be in the TextureMapper
implementation.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::get3DTransform const): Deleted.
(WebCore::GraphicsContext::concat3DTransform): Deleted.
(WebCore::GraphicsContext::set3DTransform): Deleted.
- 11:15 AM Changeset in webkit [222724] by
-
- 4 edits in trunk
ChakraCore/test/Function/apply3.js is resulting wrong result in x86_64
https://bugs.webkit.org/show_bug.cgi?id=175642
Reviewed by Darin Adler.
JSTests:
- ChakraCore/test/Function/apply3.baseline-jsc:
Source/JavaScriptCore:
According JS spec, the ToLength operation[1] has a range of 0..(253)
- 1. In Interpreter.cpp::sizeFrameForVarargs, the call to
sizeOfVarargs() was being assigned to "unsigned length", forcing a
type cast that results in different value among architectures JSC supports.
For instance, in x86_64 "4294967295 + 1" results in 0, while in ARMv6 it
results 4294967295. This patch is changing "sizeOfVarargs" to clamp the
result from "toLength" to unsigned and then get desired behavior for
all supported platforms.
[1] - https://tc39.github.io/ecma262/#sec-tolength
- interpreter/Interpreter.cpp:
(JSC::sizeOfVarargs):
- interpreter/Interpreter.h:
- 11:08 AM Changeset in webkit [222723] by
-
- 5 edits2 adds in trunk/Source/WebCore
[GLib] NetworkStateNotifier implementation missing
https://bugs.webkit.org/show_bug.cgi?id=177741
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2017-10-02
Reviewed by Carlos Garcia Campos.
No new tests. The DOM support is already being tested, but we would need a way
of simulating a network outage to test GNetworkMonitor.
- PlatformGTK.cmake: add new file.
- PlatformWPE.cmake: add new file.
- platform/network/NetworkStateNotifier.cpp: no longer need the empty implementations, all platforms covered.
- platform/network/NetworkStateNotifier.h:
- platform/network/glib/NetworkStateNotifierGLib.cpp: Added.
(WebCore::NetworkStateNotifier::updateStateWithoutNotifying): update the network state using GNetworkMonitor's availability.
(WebCore::NetworkStateNotifier::networkChangedCallback): when network-changed is emitted, trigger a state update.
(WebCore::NetworkStateNotifier::startObserving): watch GNetworkMonitor's network-changed signal.
- 11:04 AM Changeset in webkit [222722] by
-
- 2 edits in trunk/LayoutTests
Rebaseline of js/dom/global-constructors-attributes-dedicated-worker.html after r222692.
Unreviewed test gardening.
- platform/mac-wk1/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
- 10:59 AM Changeset in webkit [222721] by
-
- 3 edits in trunk/Source/WebCore
Fix build with MathML disabled
https://bugs.webkit.org/show_bug.cgi?id=177744
Patch by Olivier Blin <Olivier Blin> on 2017-10-02
Reviewed by Michael Catanzaro.
These are regressions from r217549 (StyleResolver) and r221379 (RenderBlockFlow), which do not guard MathML usage.
- css/StyleResolver.cpp:
(WebCore::hasEffectiveDisplayNoneForDisplayContents):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns const):
- 10:58 AM Changeset in webkit [222720] by
-
- 2 edits in trunk/LayoutTests
Unreviewed WPE gardening.
- platform/wpe/TestExpectations: Unskip some more tests, and add
failure expectations for whatever is still failing from that subset.
- 10:52 AM Changeset in webkit [222719] by
-
- 3 edits in trunk/Source/WebCore
Use ThreadIdentifier instead of thread::this_thread::get_id
https://bugs.webkit.org/show_bug.cgi?id=177729
Reviewed by Sam Weinig.
We can use WTF::ThreadIdentifier instead of thread::this_thread::get_id
to make use of ThreadIdentifier consistent in WebKit. In the other places,
we use ThreadIdentifier for this debugging purpose. And this is the only
place using thread::this_thread::get_id for the exact same purpose.
Furthermore, thread::this_thread::get_id in Windows platform. So we prefer
using ThreadIdentifier than thread::this_thread::get_id.
- Modules/webdatabase/DatabaseDetails.h:
(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::threadID const):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- 10:35 AM Changeset in webkit [222718] by
-
- 2 edits in trunk/Tools
Fix build after r222715
https://bugs.webkit.org/show_bug.cgi?id=177697
- TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(TEST):
Use the public API instead of the removed SPI.
- 10:26 AM Changeset in webkit [222717] by
-
- 1 edit1 add in trunk/Websites/webkit.org
Add a WebKit Build Archives page
https://bugs.webkit.org/show_bug.cgi?id=177654
Reviewed by Alexey Proskuryakov.
- wp-content/themes/webkit/build-archives.php: Added.
- 10:22 AM Changeset in webkit [222716] by
-
- 4 edits in trunk/LayoutTests
Rebaseline of js/dom/global-constructors-attributes.html after r222692.
Unreviewed test gardening.
- platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-sierra/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- 10:13 AM Changeset in webkit [222715] by
-
- 3 edits in trunk/Source/WebKit
Expose more WKPreferences SPI to match C SPI
https://bugs.webkit.org/show_bug.cgi?id=177697
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _javaEnabledForLocalFiles]):
(-[WKPreferences _setPlugInsEnabled:]): Deleted.
(-[WKPreferences _plugInsEnabled]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
_javaEnabledForLocalFiles should return the correct value.
_plugInsEnabled has public API. This SPI is not needed.
- 10:09 AM Changeset in webkit [222714] by
-
- 15 edits1 add in trunk
REGRESSION(r214201): WebProcess hangs during policy decisions
https://bugs.webkit.org/show_bug.cgi?id=177590
<rdar://problem/33362929>
Reviewed by Andy Estes.
Source/WebKit:
This is like r222431 but for trunk instead of a branch.
It includes the same regression API test so I don't make the same mistake again.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageNavigationClient):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseSync):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::applyToDocumentLoader):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebDocumentLoader.cpp:
(WebKit::WebDocumentLoader::setNavigationID):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::setUpPolicyListener):
(WebKit::WebFrame::invalidatePolicyListener):
(WebKit::WebFrame::didReceivePolicyDecision):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceivePolicyDecision):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/JavaScriptDuringNavigation.mm: Added.
(-[JSNavigationDelegate webView:didFinishNavigation:]):
(-[JSNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[JSNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[JSNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):
- 10:09 AM Changeset in webkit [222713] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix debug assertion after r222671.
JSTestCustomGetterSetter::finishCreation needs to call its base's finishCreation implementation.
- jsc.cpp:
(JSTestCustomGetterSetter::finishCreation):
- 9:54 AM Changeset in webkit [222712] by
-
- 3 edits in trunk/Source/WebKit
Remove unnecessary copy of SessionID in WebPageProxy
https://bugs.webkit.org/show_bug.cgi?id=177702
Reviewed by Darin Adler.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sessionID const):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::sessionID const): Deleted.
- 9:50 AM Changeset in webkit [222711] by
-
- 3 edits in trunk/Source/WebKit
Expose more WKPreferences SPI to match C SPI
https://bugs.webkit.org/show_bug.cgi?id=177697
<rdar://problem/24110556>
Reviewed by Darin Adler.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setJavaEnabledForLocalFiles:]):
(-[WKPreferences _javaEnabledForLocalFiles]):
(-[WKPreferences _setCanvasUsesAcceleratedDrawing:]):
(-[WKPreferences _canvasUsesAcceleratedDrawing]):
(-[WKPreferences _setAcceleratedCompositingEnabled:]):
(-[WKPreferences _acceleratedCompositingEnabled]):
(-[WKPreferences _setDefaultTextEncodingName:]):
(-[WKPreferences _defaultTextEncodingName]):
(-[WKPreferences _setNeedsSiteSpecificQuirks:]):
(-[WKPreferences _needsSiteSpecificQuirks]):
(-[WKPreferences _setAuthorAndUserStylesEnabled:]):
(-[WKPreferences _authorAndUserStylesEnabled]):
(-[WKPreferences _setDOMTimersThrottlingEnabled:]):
(-[WKPreferences _domTimersThrottlingEnabled]):
(-[WKPreferences _setWebArchiveDebugModeEnabled:]):
(-[WKPreferences _webArchiveDebugModeEnabled]):
(-[WKPreferences _setLocalFileContentSniffingEnabled:]):
(-[WKPreferences _localFileContentSniffingEnabled]):
(-[WKPreferences _setUsesPageCache:]):
(-[WKPreferences _usesPageCache]):
(-[WKPreferences _setPageCacheSupportsPlugins:]):
(-[WKPreferences _pageCacheSupportsPlugins]):
(-[WKPreferences _setShouldPrintBackgrounds:]):
(-[WKPreferences _shouldPrintBackgrounds]):
(-[WKPreferences _setWebSecurityEnabled:]):
(-[WKPreferences _webSecurityEnabled]):
(-[WKPreferences _setUniversalAccessFromFileURLsAllowed:]):
(-[WKPreferences _universalAccessFromFileURLsAllowed]):
(-[WKPreferences _setAVFoundationEnabled:]):
(-[WKPreferences _avFoundationEnabled]):
(-[WKPreferences _setSuppressesIncrementalRendering:]):
(-[WKPreferences _suppressesIncrementalRendering]):
(-[WKPreferences _setAsynchronousPluginInitializationEnabled:]):
(-[WKPreferences _asynchronousPluginInitializationEnabled]):
(-[WKPreferences _setArtificialPluginInitializationDelayEnabled:]):
(-[WKPreferences _artificialPluginInitializationDelayEnabled]):
(-[WKPreferences _setCookieEnabled:]):
(-[WKPreferences _cookieEnabled]):
(-[WKPreferences _setPlugInSnapshottingEnabled:]):
(-[WKPreferences _plugInSnapshottingEnabled]):
(-[WKPreferences _setQTKitEnabled:]):
(-[WKPreferences _qtKitEnabled]):
(-[WKPreferences _setSubpixelCSSOMElementMetricsEnabled:]):
(-[WKPreferences _subpixelCSSOMElementMetricsEnabled]):
(-[WKPreferences _setMediaSourceEnabled:]):
(-[WKPreferences _mediaSourceEnabled]):
(-[WKPreferences _setViewGestureDebuggingEnabled:]):
(-[WKPreferences _viewGestureDebuggingEnabled]):
(-[WKPreferences _setCSSAnimationTriggersEnabled:]):
(-[WKPreferences _cssAnimationTriggersEnabled]):
(-[WKPreferences _setStandardFontFamily:]):
(-[WKPreferences _standardFontFamily]):
(-[WKPreferences _setNotificationsEnabled:]):
(-[WKPreferences _notificationsEnabled]):
(-[WKPreferences _setBackspaceKeyNavigationEnabled:]):
(-[WKPreferences _backspaceKeyNavigationEnabled]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- 9:00 AM Changeset in webkit [222710] by
-
- 2 edits in trunk/Source/WebCore
Fix memory leaks in RenderMultiColumnFlow
https://bugs.webkit.org/show_bug.cgi?id=177735
Reviewed by Zalan Bujtas.
- rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::evacuateAndDestroy):
Switch from destroy() to removeFromParentAndDestroy() (they are currently equivalent in practice).
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
Destroy the placeholders instead of leaking them.
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):
Destroy the placeholder instead of leaking it.
- 7:59 AM Changeset in webkit [222709] by
-
- 2 edits1 add in trunk/Tools
Log stack-trace for run-webkit-tests when interrupted
https://bugs.webkit.org/show_bug.cgi?id=176393
<rdar://problem/34262310>
Reviewed by Darin Adler.
When run-webkit-tests is stuck, it is difficult to immediately tell
why. Saving a stack-trace when run-webkit-tests is terminated
or stopped with CNTRL-C will make such issues easier to debug.
- Scripts/webkitpy/common/interupt_debugging.py: Added.
(log_stack_trace): Given a Python frame object, log a stack trace to
the provided file.
(log_stack_trace_on_term): Attach a listener to SIGTERM so that a
stack-trace can be logged when a program is terminated.
(log_stack_trace_on_cntrl_c): Attach a listener to SIGINT so that a
stack-trace can be logged when a program is CNTRL-Ced.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main): Set handlers to log stack trace on interruption.
- 7:32 AM Changeset in webkit [222708] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] Enable interactive forms validation by default
https://bugs.webkit.org/show_bug.cgi?id=177737
Reviewed by Michael Catanzaro.
It's currently disabled for no reason.
- Shared/WebPreferencesDefinitions.h:
- 6:17 AM Changeset in webkit [222707] by
-
- 2 edits in trunk/Source/WebCore
Try to play AVC codec even if H.264 decoder only advertises byte-stream profile.
https://bugs.webkit.org/show_bug.cgi?id=177550
GStreamer's element factory filters will claim they can't play videos with AVC
codec strings, but the elements really are capable of playing them when filters
like videoconvert are inserted by playbin. Videos of this variety are in the YouTube
2018 EME conformance tests.
Also replace std::array with a stack array, this saves having to count
the number of elements (the compiler does that now) and reduces braces.
Reviewed by Carlos Alberto Lopez Perez.
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::codecSet):
- 5:55 AM Changeset in webkit [222706] by
-
- 4 edits in trunk/Source/WebCore
[SOUP] Default kerberos authentication credentials are used in ephemeral (private) mode
https://bugs.webkit.org/show_bug.cgi?id=177738
Reviewed by Carlos Garcia Campos.
If the session is ephemeral then don't enable the Negotiate support in
our SoupSession.
- platform/network/soup/NetworkStorageSessionSoup.cpp: Pass the
session ID if it's known to the SoupNetworkSession.
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::getOrCreateSoupNetworkSession const):
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession): If the session is
ephemeral (based on given session ID) then don't activate the
Negotiate support in SoupSession.
- platform/network/soup/SoupNetworkSession.h:
Change the constructor to accept the PAL::SessionID with the default
value set to PAL::SessionID::emptySessionID.
- 5:17 AM Changeset in webkit [222705] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r222640) [GTK] Build broken with ATK 2.14
https://bugs.webkit.org/show_bug.cgi?id=177634
Reviewed by Michael Catanzaro.
Use ATK_CHECK_VERSION to prevent the build failure.
No new tests. This fixes a downstream build failure.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
- 5:05 AM Changeset in webkit [222704] by
-
- 15 edits in trunk
Remove ENABLE_CSS_REGIONS
https://bugs.webkit.org/show_bug.cgi?id=177689
Reviewed by Darin Adler.
.:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/WebKit:
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:
(webkit_dom_element_get_webkit_region_overset):
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.h:
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:
(webkit_dom_element_get_webkit_region_overset): Deleted.
- WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 2:09 AM Changeset in webkit [222703] by
-
- 2 edits in trunk/Source/WebDriver
WebDriver: HTTP status code is not correct for some of the errors
https://bugs.webkit.org/show_bug.cgi?id=177354
Reviewed by Brian Burg.
I think this changed in the spec at some point. The thing is that no such alert, frame and window and stale
element reference errors should return 404 instead of 400.
https://w3c.github.io/webdriver/webdriver-spec.html#handling-errors
- CommandResult.cpp:
(WebDriver::CommandResult::httpStatusCode const):
- 1:55 AM Changeset in webkit [222702] by
-
- 8 edits in trunk/Source/WebCore
Pasteboard shouldn't add "Files" as a type
https://bugs.webkit.org/show_bug.cgi?id=177731
Reviewed by Wenson Hsieh.
Removed the platform specific code to add "Files" when there is a file present in platform's pasteboard.
DataTransfer::types now adds "Files" automatically when Pasteboard::containsFiles returns true.
No new tests since there should be no behavioral change.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::types const):
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::typesForLegacyUnsafeBindings):
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):
- platform/win/PasteboardWin.cpp:
(WebCore::addMimeTypesForFormat): Removed the code to add "Text" and "URL" as separate types since
this is not what the rest of ports do, and this type normalization is now taken care of by DataTransfer
since r221063.
- 1:25 AM Changeset in webkit [222701] by
-
- 5 edits in trunk/Source/WebCore
Another attempt to fix Windows build after r222697.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::updateAppearance):
- platform/DragImage.cpp:
(WebCore::createDragImageForRange):
- rendering/SelectionRangeData.cpp:
(WebCore::SelectionRangeData::clear):
- rendering/SelectionRangeData.h:
(WebCore::SelectionRangeData::Context::Context):
- 12:26 AM Changeset in webkit [222700] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix attempt after r222697.
- platform/DragImage.cpp:
(WebCore::createDragImageForRange):
- 12:03 AM Changeset in webkit [222699] by
-
- 10 edits in trunk/Source/WebCore
Merge readFilenames() and read(PasteboardFileReader)
https://bugs.webkit.org/show_bug.cgi?id=177728
<rdar://problem/34761725>
Reviewed by Sam Weinig.
Generalized PasteboardFileReader to return multiple files instead of just one file, and replaced the use
of Pasteboard::readFilenames() with it. Because eliminates the need for finding the list of types to read
as files in addition to file names, this patch also removes Pasteboard::typesTreatedAsFiles().
Note that Pasteboard::readFilenames() continues to exist in macOS and iOS as it's internally used by
Pasteboard::read(PasteboardFileReader) in PasteboardCocoa.mm.
No new tests since there should be no behavioral change.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::files const): Now makes a single call to Pasteboard::read(PasteboardFileReader)
instead of reading filenames and then falling back to it. Also got rid of if-def for drag drop checks
since forDrag() and forFileDrag() are always defined since r222688.
(WebCore::PasteboardFileTypeReader): Added. Gets the list of all file types.
(WebCore::PasteboardFileTypeReader::readFilename): Added. Gets the list of all file types.
(WebCore::PasteboardFileTypeReader::readBuffer): Added. Gets the list of all file types.
(WebCore::DataTransfer::hasFileOfType): Reimplemented using PasteboardFileTypeReader.
- editing/WebCorePasteboardFileReader.cpp:
(WebCore::WebCorePasteboardFileReader::readFilename): Added.
(WebCore::WebCorePasteboardFileReader::readBuffer): Renamed from read.
- editing/WebCorePasteboardFileReader.h:
- platform/Pasteboard.h:
(WebCore::PasteboardFileReader): Removed the constructor since we no longer specify a specific type to
read off of pasteboard, and renamed the existing read function to readBuffer, and added a new variant
which takes a filename.
- platform/StaticPasteboard.h:
- platform/cocoa/PasteboardCocoa.mm:
(WebCore::imageTypeToFakeFilename): Return "image/png" for ImageType::TIFF (to do TIFF-to-PNG conversion;
see r222656 for why this is needed) now that this function is used to convert directly from image type
converted from cocoa type instead of the one reverse-converted from MIME type.
(WebCore::mimeTypeToImageType): Deleted.
(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::Pasteboard::typesForLegacyUnsafeBindings): Use newly added readTypesWithSecurityCheck.
(WebCore::convertTIFFToPNG): Extracted out of read(PasteboardFileReader).
(WebCore::Pasteboard::read): Generalized to add filenames as well as image buffers as files. Because now
we're concerting Cocoa types to ImageType, we no longer have to detect when TIFF-as-PNG conversion is
happening here. We just treat ImageType::TIFF as PNG and do the conversion.
(WebCore::Pasteboard::readStringInCustomData): Use newly added readBufferForTypeWithSecurityCheck.
(WebCore::Pasteboard::readTypesWithSecurityCheck): Added.
(WebCore::Pasteboard::readBufferForTypeWithSecurityCheck): Added.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::read): Implemented.
(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::Pasteboard::containsFiles): Implemented without calling readFilenames, which has been deleted.
(WebCore::Pasteboard::readFilenames): Deleted.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::PasteboardFileCounter): Added. Used to counts the number of files in the pasteboard.
(WebCore::PasteboardFileCounter::readFilename):
(WebCore::PasteboardFileCounter::readBuffer):
(WebCore::Pasteboard::containsFiles):
(WebCore::Pasteboard::read): Moved the code to extract filenames out of readFilenames.
(WebCore::Pasteboard::readFilenames): Deleted.
- platform/wpe/PasteboardWPE.cpp:
(WebCore::Pasteboard::typesTreatedAsFiles): Deleted.
(WebCore::Pasteboard::readFilenames): Deleted.
Oct 1, 2017:
- 11:02 PM Changeset in webkit [222698] by
-
- 10 edits1 add in trunk/Source/WebCore
[Settings] Move remaining simple settings to Settings.in
https://bugs.webkit.org/show_bug.cgi?id=177730
Patch by Sam Weinig <sam@webkit.org> on 2017-10-01
Reviewed by Darin Adler.
- Adds new option type for Settings.in, 'getter', which allows you to specify a custom name for the setting's getter. For instance, the setting javaEnabled has a custom getter name, 'isJavaEnabled'.
- Adds support for WTF::Seconds as a type of setting. Used by only timeWithoutMouseMovementBeforeHidingControls at the moment.
- Moves non-generated settings from Settings.h/cpp that don't require custom action when set, to Settings.in
- Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py:
- Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:
- Scripts/GenerateSettings/Settings.py:
Add support for 'getter' and the Seconds type.
- WebCore.xcodeproj/project.pbxproj:
- platform/text/FontRenderingMode.h: Copied from Source/WebCore/platform/text/TextFlags.h.
- platform/text/TextFlags.h:
Add FontRenderingMode.h. Moved out of TextFlags.h to be accessible by
the settings generator.
- page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setJavaEnabled): Deleted.
(WebCore::Settings::setJavaEnabledForLocalFiles): Deleted.
(WebCore::Settings::setPreferMIMETypeForImages): Deleted.
(WebCore::Settings::setForcePendingWebGLPolicy): Deleted.
(WebCore::Settings::setNeedsAdobeFrameReloadingQuirk): Deleted.
(WebCore::Settings::setFontRenderingMode): Deleted.
(WebCore::Settings::fontRenderingMode const): Deleted.
(WebCore::Settings::setShowTiledScrollingIndicator): Deleted.
(WebCore::Settings::setFontFallbackPrefersPictographs): Deleted.
(WebCore::Settings::setWebFontsAlwaysFallBack): Deleted.
- page/Settings.h:
(WebCore::Settings::isJavaEnabled const): Deleted.
(WebCore::Settings::isJavaEnabledForLocalFiles const): Deleted.
(WebCore::Settings::preferMIMETypeForImages const): Deleted.
(WebCore::Settings::needsAcrobatFrameReloadingQuirk const): Deleted.
(WebCore::Settings::showTiledScrollingIndicator const): Deleted.
(WebCore::Settings::setTouchEventEmulationEnabled): Deleted.
(WebCore::Settings::isTouchEventEmulationEnabled const): Deleted.
(WebCore::Settings::setTimeWithoutMouseMovementBeforeHidingControls): Deleted.
(WebCore::Settings::timeWithoutMouseMovementBeforeHidingControls const): Deleted.
(WebCore::Settings::fontFallbackPrefersPictographs const): Deleted.
(WebCore::Settings::webFontsAlwaysFallBack const): Deleted.
(WebCore::Settings::setMediaKeysStorageDirectory): Deleted.
(WebCore::Settings::mediaKeysStorageDirectory const): Deleted.
(WebCore::Settings::setMediaDeviceIdentifierStorageDirectory): Deleted.
(WebCore::Settings::mediaDeviceIdentifierStorageDirectory const): Deleted.
(WebCore::Settings::applePayEnabled const): Deleted.
(WebCore::Settings::setApplePayEnabled): Deleted.
(WebCore::Settings::applePayCapabilityDisclosureAllowed const): Deleted.
(WebCore::Settings::setApplePayCapabilityDisclosureAllowed): Deleted.
(WebCore::Settings::isForcePendingWebGLPolicy const): Deleted.
- page/Settings.in:
Moved hand-written settings to be Settings.in based.
- 9:46 PM Changeset in webkit [222697] by
-
- 16 edits2 adds2 deletes in trunk/Source/WebCore
RenderView does not need to be a SelectionSubtreeRoot
https://bugs.webkit.org/show_bug.cgi?id=177713
Reviewed by Darin Adler and Antti Koivisto.
- SelectionSubtreeRoot -> SelectionRangeData
- Move all selection logic from RenderView to SelectionRangeData
- class RenderView : public SelectionSubtreeRoot -> SelectionRangeData m_selection;
- Remove redundant code
- General modernization
No change in functionality.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setNeedsSelectionUpdate):
(WebCore::DragCaretController::nodeWillBeRemoved):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::FrameSelection::prepareForDestruction):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::selectionBounds const):
- page/FrameView.cpp:
(WebCore::FrameView::paintContentsForSnapshot):
- platform/DragImage.cpp:
(WebCore::ScopedFrameSelectionState::ScopedFrameSelectionState):
(WebCore::ScopedFrameSelectionState::~ScopedFrameSelectionState):
(WebCore::createDragImageForRange):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::selectionStartEnd const):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isSelectionRoot const):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::isSelectionBorder const):
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::isSelected const):
- rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::setSelectionState):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::SelectionIterator::SelectionIterator): Deleted.
(WebCore::SelectionIterator::current const): Deleted.
(WebCore::SelectionIterator::next): Deleted.
(WebCore::SelectionIterator::checkForSpanner): Deleted.
(WebCore::rendererAfterPosition): Deleted.
(WebCore::RenderView::selectionBounds const): Deleted.
(WebCore::RenderView::subtreeSelectionBounds const): Deleted.
(WebCore::RenderView::repaintSelection const): Deleted.
(WebCore::RenderView::repaintSubtreeSelection const): Deleted.
(WebCore::RenderView::setSelection): Deleted.
(WebCore::isValidObjectForNewSelection): Deleted.
(WebCore::RenderView::clearSubtreeSelection const): Deleted.
(WebCore::RenderView::applySubtreeSelection): Deleted.
(WebCore::RenderView::getSelection const): Deleted.
(WebCore::RenderView::clearSelection): Deleted.
- rendering/RenderView.h:
- rendering/SelectionSubtreeRoot.cpp:
(WebCore::rendererAfterPosition):
(WebCore::SelectionIterator::SelectionIterator):
(WebCore::SelectionIterator::current const):
(WebCore::SelectionIterator::next):
(WebCore::SelectionIterator::checkForSpanner):
(WebCore::SelectionRangeData::SelectionRangeData):
(WebCore::SelectionRangeData::set):
(WebCore::SelectionRangeData::clear):
(WebCore::SelectionRangeData::repaint const):
(WebCore::SelectionRangeData::bounds const):
(WebCore::SelectionRangeData::collectAndClear const):
(WebCore::SelectionRangeData::apply):
(WebCore::SelectionRangeData::isValidRendererForNewSelection const):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot): Deleted.
- rendering/SelectionSubtreeRoot.h:
(WebCore::SelectionRangeData::Context::operator== const):
(WebCore::SelectionRangeData::get const):
(WebCore::SelectionRangeData::start const):
(WebCore::SelectionRangeData::end const):
(WebCore::SelectionRangeData::startPosition const):
(WebCore::SelectionRangeData::endPosition const):
(WebCore::SelectionSubtreeRoot::OldSelectionData::OldSelectionData): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::SelectionSubtreeData): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStart const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartPos const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEnd const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEndPos const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartEndPositions const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::clearSelection): Deleted.
(WebCore::SelectionSubtreeRoot::selectionData): Deleted.
(WebCore::SelectionSubtreeRoot::selectionData const): Deleted.
(WebCore::SelectionSubtreeRoot::setSelectionData): Deleted.
- 8:33 PM Changeset in webkit [222696] by
-
- 3 edits2 adds in branches/safari-604-branch
Cherry-pick r222588. rdar://problem/34717517
- 8:17 PM Changeset in webkit [222695] by
-
- 4 edits in trunk/Source/WebCore
[Settings] Enums should not be passed by const reference
https://bugs.webkit.org/show_bug.cgi?id=177727
Patch by Sam Weinig <sam@webkit.org> on 2017-10-01
Reviewed by Darin Adler.
- Scripts/GenerateSettings/GenerateSettingsImplementationFile.py:
- Scripts/GenerateSettings/GenerateSettingsHeaderFile.py:
(printGetterAndSetter):
Use the new typeIsAggregate predicate to determine whether to
use const reference or not.
(includeForSetting): Deleted.
Move includeForSetting to Settings.py with the rest of the Setting
helpers.
- Scripts/GenerateSettings/Settings.py:
(mapToIDLType):
(typeIsPrimitive):
(typeIsAggregate):
Add predicate to determine if a setting's type is an aggregate (struct or class)
or a primitive. Remove references to size_t, which is not used.
- 6:35 PM Changeset in webkit [222694] by
-
- 2 edits in trunk/LayoutTests
Skip failing tests from r222692 that have different output on each run.
Skips imported/w3c/web-platform-tests/fetch/api/abort/general.any.html
and imported/w3c/web-platform-tests/fetch/api/abort/general.any.worker.html
- 6:28 PM Changeset in webkit [222693] by
-
- 1 edit2 adds in trunk/LayoutTests/imported/w3c
Add missing results from r222690.
- web-platform-tests/XMLHttpRequest/responseType-document-in-worker-expected.txt: Added.
- web-platform-tests/XMLHttpRequest/responseXML-unavailable-in-worker-expected.txt: Added.
- 3:32 PM Changeset in webkit [222692] by
-
- 16 edits6 adds in trunk
Add support for DOM aborting (https://dom.spec.whatwg.org/#aborting-ongoing-activities)
https://bugs.webkit.org/show_bug.cgi?id=177718
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/dom/abort/event.any-expected.txt:
- web-platform-tests/dom/abort/event.any.worker-expected.txt:
- web-platform-tests/dom/interface-objects-expected.txt:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/fetch/api/abort/cache.https-expected.txt:
- web-platform-tests/fetch/api/abort/general.any-expected.txt:
- web-platform-tests/fetch/api/abort/general.any.worker-expected.txt:
- web-platform-tests/payment-request/interfaces.https-expected.txt:
Update test results.
Source/WebCore:
Adds standalone support for AbortController and AbortSignal. No integration
with other specs yet.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
Add new files.
- dom/AbortController.cpp: Added.
- dom/AbortController.h: Added.
- dom/AbortController.idl: Added.
- dom/AbortSignal.cpp: Added.
- dom/AbortSignal.h: Added.
- dom/AbortSignal.idl: Added.
Add basic support AbortController and AbortSignal.
- dom/EventTargetFactory.in:
Add AbortSignal to the list of EventTargets.
LayoutTests:
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
Update test results.
- 2:24 PM Changeset in webkit [222691] by
-
- 4 edits in trunk/Source/WebCore
Use WeakPtr for first-letter memory management
https://bugs.webkit.org/show_bug.cgi?id=177716
Reviewed by Darin Adler.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::destroyLeftoverChildren):
Remove first-letter special case.
Use removeAndDestroyChild instead of calling destroy() directly. The latter should
eventually stop calling takeChild and assert that the renderer is not in the tree.
- rendering/RenderTextFragment.cpp:
(WebCore::RenderTextFragment::willBeDestroyed):
(WebCore::RenderTextFragment::setText):
- rendering/RenderTextFragment.h:
Use WeakPtr.
- 2:12 PM Changeset in webkit [222690] by
-
- 6 edits4 adds in trunk
XMLHttpRequest's responseXML should be annotated with [Exposed=Window]
https://bugs.webkit.org/show_bug.cgi?id=177714
Patch by Sam Weinig <sam@webkit.org> on 2017-10-01
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/XMLHttpRequest/resources/responseType-document-in-worker.js: Added.
- web-platform-tests/XMLHttpRequest/resources/responseXML-unavailable-in-worker.js: Added.
- web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
- web-platform-tests/XMLHttpRequest/responseType-document-in-worker.html: Added.
- web-platform-tests/XMLHttpRequest/responseXML-unavailable-in-worker.html: Added.
- web-platform-tests/XMLHttpRequest/w3c-import.log:
Import latest XMLHttpRequest tests that include tests for responseXML not
being available in workers and setting a responseType of 'document' being
a no-op in workers.
Source/WebCore:
Tests: imported/w3c/web-platform-tests/XMLHttpRequest/responseType-document-in-worker.html
imported/w3c/web-platform-tests/XMLHttpRequest/responseXML-unavailable-in-worker.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::responseXML):
Replace returning null for non-document contexts with an assertion now
that the bindings layer ensures this doesn't get called.
(WebCore::XMLHttpRequest::setResponseType):
Match the spec and turn attempts to set a responseType of 'document' in
non-documents contexts as a no-op.
- xml/XMLHttpRequest.idl:
Address FIXME and annotate responseXML with [Exposed=Window] now that it
is supported.
- 10:23 AM Changeset in webkit [222689] by
-
- 36 edits2 deletes in trunk
Unreviewed, rolling out r222564.
https://bugs.webkit.org/show_bug.cgi?id=177720
"It regressed JetStream by 2% on iOS caused by a 50%
regression on the bigfib subtest" (Requested by saamyjoon on
#webkit).
Reverted changeset:
"Add Above/Below comparisons for UInt32 patterns"
https://bugs.webkit.org/show_bug.cgi?id=177281
http://trac.webkit.org/changeset/222564
Sep 30, 2017:
- 11:59 PM Changeset in webkit [222688] by
-
- 11 edits2 adds in trunk
Don't reveal file URL when pasting an image
https://bugs.webkit.org/show_bug.cgi?id=177710
<rdar://problem/34757924>
Reviewed by Wenson Hsieh.
Source/WebCore:
Fixed the bug by generalizing the code we had for drag & drop to hide string types when there is a file.
We don't hide string types when customPasteboardDataEnabled() is false to preserve the backwards compatiblity
with apps that are relying on being able to read files URLs in the pasteboard.
Test: editing/pasteboard/paste-image-does-not-reveal-file-url.html
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::getData const): Pretend there is no string data when there is a file in the pasteboard
custom pasteboard data is enabled.
(WebCore::DataTransfer::setData): Ditto.
(WebCore::DataTransfer::types const): Ditto.
- dom/DataTransfer.h:
(WebCore::DataTransfer::forDrag const): Added for when drag & drop support is disabled at compilation time.
(WebCore::DataTransfer::forFileDrag const): Ditto.
- platform/Pasteboard.h:
- platform/StaticPasteboard.h:
- platform/cocoa/PasteboardCocoa.mm:
(WebCore::Pasteboard::containsFiles): Added.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::containsFiles): Added.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::containsFiles): Added.
- platform/wpe/PasteboardWPE.cpp:
(WebCore::Pasteboard::containsFiles): Added.
(WebCore::Pasteboard::readFilenames): Annotated this function with notImplemented().
LayoutTests:
Added a regression test for pasting an image. We enable this protection only when custom data is enabled
to preserve the backwards compatibility.
- editing/pasteboard/paste-image-does-not-reveal-file-url-expected.txt: Added.
- editing/pasteboard/paste-image-does-not-reveal-file-url.html: Added.
- 10:00 PM Changeset in webkit [222687] by
-
- 3 edits in trunk/LayoutTests
Augment editing/pasteboard/data-transfer-get-data-non-normalized-types.html to check whitespace stripping
https://bugs.webkit.org/show_bug.cgi?id=177707
Reviewed by Ryosuke Niwa.
Augment an existing layout test to check that whitespace is stripped from types passed into DataTransfer's
getData and setData methods.
- editing/pasteboard/data-transfer-get-data-non-normalized-types-expected.txt:
- editing/pasteboard/data-transfer-get-data-non-normalized-types.html:
- 6:13 PM Changeset in webkit [222686] by
-
- 20 edits1 copy1 move12 adds1 delete in trunk/Source/WebCore
[Settings] Replace SettingsMacros.h with a generated base class for Settings
https://bugs.webkit.org/show_bug.cgi?id=177681
Patch by Sam Weinig <sam@webkit.org> on 2017-09-30
Reviewed by Darin Adler.
- Adds a SettingsGenerated class that Settings inherits from. The new class has the members and getters/setters for all the generated bindings.
- Some default values for settings are literals in Settings.in, but rather constants or functions defined externally. These have all been moved to SettingsDefaultValues.h to allow for the script to include them all for SettingsGenerated.
- Previously, a few enums were declared in Settings.h for use by Settings. Now that SettingsGenerated needs access, we standarize the same way that exists for the IDL generator; expecting the enum to be in a header of the same name.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreMacros.cmake:
Add new files / generation steps.
- Scripts/GenerateSettings.py:
- Scripts/GenerateSettings/GenerateSettings.py:
- Scripts/GenerateSettings/GenerateSettingsHeaderFile.py: Added.
- Scripts/GenerateSettings/GenerateSettingsImplementationFile.py: Added.
- Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py: Removed.
- Scripts/GenerateSettings/Settings.py:
Replace script to generate SettingsMacros.h with scripts to generate a SettingsGenerated.{h,cpp}.
- accessibility/ForcedAccessibilityValue.h: Added.
- editing/EditableLinkBehavior.h: Added.
- editing/EditingBehavior.h:
- editing/EditingBehaviorType.h: Copied from editing/EditingBehaviorTypes.h.
- editing/EditingBehaviorTypes.h: Removed.
- editing/cocoa/DataDetection.h:
- editing/cocoa/DataDetectorTypes.h: Added.
- page/DebugOverlayRegions.h: Added.
- page/FrameFlattening.h: Added.
- page/PDFImageCachingPolicy.h: Added.
- page/TextDirectionSubmenuInclusionBehavior.h: Added.
- page/UserInterfaceDirectionPolicy.h: Added.
- platform/text/TextDirection.h: Added.
- platform/text/WritingMode.h:
Split out enums from Settings.h
- css/MediaQueryEvaluator.cpp:
Update for new name of ForcedAccessibilityValue.
- html/parser/HTMLParserOptions.cpp:
Update for new name of defaultMaximumHTMLParserDOMTreeDepth.
- page/Settings.cpp:
- page/Settings.h:
- Move defaults to SettingsDefaultValues.h (and SettingsDefaultValuesCocoa.mm for defaultTextAutosizingEnabled).
- Move enums to their own files.
- Inherit from SettingsGenerated.h
- page/Settings.in:
- Use new 'include' option for javaScriptRuntimeFlags setting to include <runtime/RuntimeFlags.h>, as it doesn't fit the normal idiomatic model.
- Replace call to defaultMinimumZoomFontSize() with direct constant access.
- page/SettingsDefaultValues.h: Added.
- page/cocoa/SettingsDefaultValuesCocoa.mm: Added.
Move default values from Settings to this new file.
- page/cocoa/SettingsCocoa.mm:
Move defaultTextAutosizingEnabled() out of here and into SettingsDefaultValuesCocoa.mm.
- style/StyleTreeResolver.cpp:
- Update for new scoping of defaultMaximumRenderTreeDepth.
- Move defaultMaximumRenderTreeDepth from Settings here. This is the only use.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::forcedColorsAreInvertedAccessibilityValue const):
(WebCore::InternalSettings::setForcedColorsAreInvertedAccessibilityValue):
(WebCore::InternalSettings::forcedDisplayIsMonochromeAccessibilityValue const):
(WebCore::InternalSettings::setForcedDisplayIsMonochromeAccessibilityValue):
(WebCore::InternalSettings::forcedPrefersReducedMotionAccessibilityValue const):
(WebCore::InternalSettings::setForcedPrefersReducedMotionAccessibilityValue):
(WebCore::settingsToInternalSettingsValue): Deleted.
(WebCore::internalSettingsToSettingsValue): Deleted.
- testing/InternalSettings.h:
Replace duplicate definition of ForcedAccessibilityValue with a using declaration
and simplify code now that it doesn't need to map between the two enums.
- 4:33 PM Changeset in webkit [222685] by
-
- 2 edits2 adds in trunk/LayoutTests
Add a layout test test that exercises setData and getData for non-normalized types
https://bugs.webkit.org/show_bug.cgi?id=177707
Reviewed by Darin Adler.
We have test coverage for getData and setData with non-normalized types on some of our bots where custom
pasteboard data is enabled by default, but this is not the case in EWS. This patch adds a copy and paste test
that exercises this codepath across all Cocoa platforms.
- editing/pasteboard/data-transfer-get-data-non-normalized-types-expected.txt: Added.
- editing/pasteboard/data-transfer-get-data-non-normalized-types.html: Added.
- platform/ios-simulator-wk1/TestExpectations:
- 3:50 PM Changeset in webkit [222684] by
-
- 12 edits in trunk/Source/WebKit
Have IPC::Connection::Client objects consistently invalidate the connection when destroyed
https://bugs.webkit.org/show_bug.cgi?id=177708
Reviewed by Anders Carlsson.
I ran into an intermittent crash when running regression tests. It looked like a connection
client was being called after it was destroyed. I did an audit of the all the connection
clients to make sure they all invalidate their connection before they are destroyed.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess): Invalidate the
connection since this object opened the connection. There is no obvious
guarantee that the connection will already be invalid when this is destroyed.
- StorageProcess/StorageToWebProcessConnection.cpp:
(WebKit::StorageToWebProcessConnection::~StorageToWebProcessConnection): Ditto.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::~PluginProcessProxy): Ditto.
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::~NetworkProcessConnection): Ditto.
- WebProcess/Storage/WebToStorageProcessConnection.cpp:
(WebKit::WebToStorageProcessConnection::~WebToStorageProcessConnection): Ditto.
- StorageProcess/StorageToWebProcessConnection.h: Derive privately rather than publicly
from IPC::Connection::Client because we can, and this means we don't have to study quite
as much code to understand how this is used as a connection client.
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h: Ditto.
- WebProcess/Storage/WebToStorageProcessConnection.h: Ditto.
- WebProcess/WebPage/WebInspector.h: Ditto.
- WebProcess/WebPage/WebInspectorUI.h: Ditto.
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer): Added a comment about a
reference cycle cycle leading to a leak that I believe exists here.
- 2:25 PM Changeset in webkit [222683] by
-
- 2 edits in trunk/Source/WebCore
[iOS WK2] API test EditorStateTests.ContentViewHasTextInContentEditableElement is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=177698
Reviewed by Ryosuke Niwa.
The WebKit2 API test EditorStateTests.ContentViewHasTextInContentEditableElement is currently hitting
intermittent failures on test runners. After inserting just an image in the editable element, we would expect
that -hasText should return NO because the text content is an empty string, but we find that -hasText is YES.
This is because we're bailing on an early return in computeEditableRootHasContentAndPlainText because the
EditorState's PostLayoutData contains non-zero characters near the selection, which is incorrect.
However, upon closer inspection, this is due to a latent bug in the charactersAroundPosition helper function.
This function attempts to compute characters before and after the current selection by initializing a Vector
of size 3 with the relevant character data, and then sets oneAfter, oneBefore and twoBefore to the UChar32
values in the vector. However, in the case where there are less than three characters, we end up assigning
the uninitialized values in the vector to one or more of oneAfter, oneBefore and twoBefore, which causes the
helper added in r222654 to bail early when it should not.
To fix this, we initialize the values in
charactersto 0 (which is the initial value for the 3 corresponding
members in the PostLayoutData struct). We also turncharactersinto a UChar32 array on the stack, to avoid the
heap allocations using a Vector<UChar32>.
No new tests; fixes a flaky API test.
- editing/VisibleUnits.cpp:
(WebCore::charactersAroundPosition):
- 6:44 AM Changeset in webkit [222682] by
-
- 9 edits in trunk/Source
Add makeWeakPtr for easier WeakPtr construction
https://bugs.webkit.org/show_bug.cgi?id=177706
Reviewed by Sam Weinig.
Source/WebCore:
Use it in render tree.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
- page/FrameView.cpp:
(WebCore::FrameView::updateEmbeddedObject):
- rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
- rendering/RenderObject.h:
(WebCore::RenderObject::weakFactory const):
(WebCore::RenderObject::createWeakPtr): Deleted.
- rendering/RenderView.cpp:
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
Source/WTF:
Standalone makeWeakPtr() returns a WeakPtr of the same type as the argument.
For this to work the argument type needs to expose a (possibly base type) WeakPtrFactory
as a public weakPtrFactory() member function.
- wtf/WeakPtr.h:
(WTF::WeakPtr::operator-> const):
(WTF::WeakPtr::operator* const): Also add operator*.
(WTF::makeWeakPtr):
- 6:00 AM Changeset in webkit [222681] by
-
- 231 edits1 add in trunk
Unreviewed. Upgrade webkitgtk-test-fonts to version 0.0.7.
Tools:
This version upgrades liberation fonts to version 2, that has a wider glyph coverage.
- gtk/jhbuild.modules:
LayoutTests:
Rebaseline tests affected by the new fonts.
- platform/gtk/css3/unicode-bidi-isolate-basic-expected.png:
- platform/gtk/css3/unicode-bidi-isolate-basic-expected.txt:
- platform/gtk/editing/selection/caret-rtl-2-expected.png:
- platform/gtk/editing/selection/caret-rtl-2-expected.txt:
- platform/gtk/editing/selection/caret-rtl-2-left-expected.png:
- platform/gtk/editing/selection/caret-rtl-2-left-expected.txt:
- platform/gtk/editing/selection/caret-rtl-expected.png:
- platform/gtk/editing/selection/caret-rtl-expected.txt:
- platform/gtk/editing/selection/caret-rtl-right-expected.png:
- platform/gtk/editing/selection/caret-rtl-right-expected.txt:
- platform/gtk/editing/selection/extend-by-word-002-expected.png:
- platform/gtk/editing/selection/extend-by-word-002-expected.txt:
- platform/gtk/editing/selection/extend-selection-bidi-expected.png:
- platform/gtk/editing/selection/extend-selection-bidi-expected.txt:
- platform/gtk/editing/selection/move-past-trailing-space-expected.png:
- platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
- platform/gtk/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
- platform/gtk/fast/borders/rtl-border-04-expected.png:
- platform/gtk/fast/borders/rtl-border-04-expected.txt:
- platform/gtk/fast/borders/rtl-border-05-expected.png:
- platform/gtk/fast/borders/rtl-border-05-expected.txt:
- platform/gtk/fast/css/rtl-ordering-expected.png:
- platform/gtk/fast/css/rtl-ordering-expected.txt:
- platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.png:
- platform/gtk/fast/css/text-overflow-ellipsis-bidi-expected.txt:
- platform/gtk/fast/css/text-overflow-ellipsis-expected.png:
- platform/gtk/fast/css/text-overflow-ellipsis-expected.txt:
- platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.png:
- platform/gtk/fast/css/text-overflow-ellipsis-strict-expected.txt:
- platform/gtk/fast/css/word-space-extra-expected.png:
- platform/gtk/fast/css/word-space-extra-expected.txt:
- platform/gtk/fast/dom/34176-expected.png:
- platform/gtk/fast/dom/34176-expected.txt:
- platform/gtk/fast/dom/52776-expected.png:
- platform/gtk/fast/dom/52776-expected.txt:
- platform/gtk/fast/forms/listbox-bidi-align-expected.png:
- platform/gtk/fast/forms/listbox-bidi-align-expected.txt:
- platform/gtk/fast/forms/search-rtl-expected.png:
- platform/gtk/fast/forms/search-rtl-expected.txt:
- platform/gtk/fast/forms/select-visual-hebrew-expected.png:
- platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
- platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/gtk/fast/inline/inline-box-background-expected.png:
- platform/gtk/fast/inline/inline-box-background-expected.txt:
- platform/gtk/fast/inline/inline-box-background-long-image-expected.png:
- platform/gtk/fast/inline/inline-box-background-long-image-expected.txt:
- platform/gtk/fast/inline/inline-box-background-repeat-x-expected.png:
- platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt:
- platform/gtk/fast/inline/inline-box-background-repeat-y-expected.png:
- platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt:
- platform/gtk/fast/text/atsui-negative-spacing-features-expected.png:
- platform/gtk/fast/text/atsui-negative-spacing-features-expected.txt:
- platform/gtk/fast/text/atsui-spacing-features-expected.png:
- platform/gtk/fast/text/atsui-spacing-features-expected.txt:
- platform/gtk/fast/text/basic/006-expected.png:
- platform/gtk/fast/text/basic/006-expected.txt:
- platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.png:
- platform/gtk/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
- platform/gtk/fast/text/capitalize-boundaries-expected.png:
- platform/gtk/fast/text/capitalize-boundaries-expected.txt:
- platform/gtk/fast/text/cg-fallback-bolding-expected.png:
- platform/gtk/fast/text/cg-fallback-bolding-expected.txt:
- platform/gtk/fast/text/drawBidiText-expected.png:
- platform/gtk/fast/text/drawBidiText-expected.txt:
- platform/gtk/fast/text/hyphenate-avoid-orphaned-word-expected.txt:
- platform/gtk/fast/text/hyphenate-character-expected.png:
- platform/gtk/fast/text/hyphenate-character-expected.txt:
- platform/gtk/fast/text/hyphenate-first-word-expected.png:
- platform/gtk/fast/text/hyphenate-first-word-expected.txt:
- platform/gtk/fast/text/hyphenate-limit-before-after-expected.png:
- platform/gtk/fast/text/hyphenate-limit-before-after-expected.txt:
- platform/gtk/fast/text/hyphenate-limit-lines-expected.png:
- platform/gtk/fast/text/hyphenate-limit-lines-expected.txt:
- platform/gtk/fast/text/hyphens-expected.png:
- platform/gtk/fast/text/hyphens-expected.txt:
- platform/gtk/fast/text/in-rendered-text-rtl-expected.png:
- platform/gtk/fast/text/in-rendered-text-rtl-expected.txt:
- platform/gtk/fast/text/international/bidi-AN-after-L-expected.png:
- platform/gtk/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.png:
- platform/gtk/fast/text/international/bidi-L2-run-reordering-expected.txt:
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-CSS-expected.txt:
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-HTML-expected.txt:
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
- platform/gtk/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
- platform/gtk/fast/text/international/bidi-explicit-embedding-expected.png:
- platform/gtk/fast/text/international/bidi-explicit-embedding-expected.txt:
- platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
- platform/gtk/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
- platform/gtk/fast/text/international/bidi-innertext-expected.png:
- platform/gtk/fast/text/international/bidi-innertext-expected.txt:
- platform/gtk/fast/text/international/bidi-linebreak-001-expected.png:
- platform/gtk/fast/text/international/bidi-linebreak-001-expected.txt:
- platform/gtk/fast/text/international/bidi-linebreak-002-expected.png:
- platform/gtk/fast/text/international/bidi-linebreak-002-expected.txt:
- platform/gtk/fast/text/international/bidi-linebreak-003-expected.png:
- platform/gtk/fast/text/international/bidi-linebreak-003-expected.txt:
- platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.png:
- platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
- platform/gtk/fast/text/international/bidi-neutral-run-expected.png:
- platform/gtk/fast/text/international/bidi-neutral-run-expected.txt:
- platform/gtk/fast/text/international/bidi-override-expected.png:
- platform/gtk/fast/text/international/bidi-override-expected.txt:
- platform/gtk/fast/text/international/hebrew-vowels-expected.png:
- platform/gtk/fast/text/international/hebrew-vowels-expected.txt:
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/gtk/fast/text/international/rtl-caret-expected.png:
- platform/gtk/fast/text/international/rtl-caret-expected.txt:
- platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.png:
- platform/gtk/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
- platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
- platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
- platform/gtk/fast/text/line-breaks-expected.png:
- platform/gtk/fast/text/line-breaks-expected.txt:
- platform/gtk/fast/text/midword-break-after-breakable-char-expected.png:
- platform/gtk/fast/text/midword-break-after-breakable-char-expected.txt:
- platform/gtk/fast/text/trailing-white-space-2-expected.png:
- platform/gtk/fast/text/trailing-white-space-2-expected.txt:
- platform/gtk/fast/text/trailing-white-space-expected.png:
- platform/gtk/fast/text/trailing-white-space-expected.txt:
- platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.png:
- platform/gtk/fast/text/vertical-rl-rtl-linebreak-expected.txt:
- platform/gtk/fast/text/whitespace/026-expected.png:
- platform/gtk/fast/text/whitespace/026-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
- platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.png:
- platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png:
- platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
- platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
- platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
- platform/gtk/svg/custom/glyph-selection-bidi-mirror-expected.png:
- platform/gtk/svg/custom/glyph-selection-bidi-mirror-expected.txt:
- platform/gtk/svg/text/bidi-embedded-direction-expected.png:
- platform/gtk/svg/text/bidi-embedded-direction-expected.txt:
- platform/gtk/svg/text/bidi-reorder-value-lists-expected.png:
- platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt: Added.
- platform/gtk/svg/text/bidi-text-anchor-direction-expected.png:
- platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt:
- platform/gtk/svg/text/text-tselect-02-f-expected.png:
- platform/gtk/svg/text/text-tselect-02-f-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_position-table-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
- platform/gtk/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
- platform/gtk/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
- 3:31 AM Changeset in webkit [222680] by
-
- 15 edits in trunk/Source/WebCore
Share more pasteboard code between iOS and macOS and remove dependency on Settings
https://bugs.webkit.org/show_bug.cgi?id=177700
Reviewed by Wenson Hsieh.
Moved more code from PasteboardIOS.mm and PasteboardMac.mm into PasteboardCocoa.mm to share code.
This patch also removes the layering violation inadvertently introduced in r222595 whereby which
Pasteboard code depends on Settings. To do this, this patch splits readStringForBindings is into
readString and readStringInCustomData and typesForBindings into typesSafeForBindings and
typesForLegacyUnsafeBindings, and moves the logic to decide whether a given type or string is read
off of the native pasteboard entry or our custom data entry is moved to DataTransfer.
No new tests since there should be no behavioral change.
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::getData const): Moved the code to decide whether string is
read off of custom data or native pasteboard from readStringForBindings.
(WebCore::DataTransfer::types const): Ditto from typesForBindings.
- platform/Pasteboard.cpp:
(WebCore::Pasteboard::isSafeTypeForDOMToReadAndWrite): Moved into Pasteboard.
- platform/Pasteboard.h:
- platform/StaticPasteboard.cpp:
(WebCore::StaticPasteboard::readString): Renamed from readStringForBindings.
(WebCore::StaticPasteboard::readStringInCustomData): Added.
(WebCore::StaticPasteboard::writeString):
- platform/StaticPasteboard.h:
- platform/cocoa/PasteboardCocoa.mm:
(WebCore::Pasteboard::typesSafeForBindings): Extracted out of typesForBindings in PasteboardIOS.mm
and PasteboardMac.mm.
(WebCore::Pasteboard::typesForLegacyUnsafeBindings): Ditto.
(WebCore::Pasteboard::readString): Ditto.
(WebCore::Pasteboard::readStringInCustomData): Ditto.
(WebCore::Pasteboard::writeCustomData): Moved here from PasteboardIOS.mm and PasteboardCocoa.mm.
(WebCore::Pasteboard::changeCount const): Ditto.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::typesSafeForBindings): Added.
(WebCore::Pasteboard::typesForLegacyUnsafeBindings): Renamed from readStringForBindings.
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::readStringInCustomData): Added.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::writeCustomData): Moved to PasteboardCocoa.mm.
(WebCore::Pasteboard::changeCount const): Ditto.
(WebCore::Pasteboard::readPlatformValueAsString): Moved into Pasteboard.
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType): Ditto.
(WebCore::Pasteboard::readStringForBindings): Moved to PasteboardCocoa.mm.
(WebCore::Pasteboard::typesForBindings): Ditto.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::changeCount const): Moved to PasteboardCocoa.mm.
(WebCore::Pasteboard::writeCustomData): Ditto.
(WebCore::Pasteboard::readPlatformValueAsString): Moved into Pasteboard.
(WebCore::Pasteboard::readStringForBindings): Moved to PasteboardCocoa.mm.
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType): Moved into Pasteboard.
(WebCore::Pasteboard::typesForBindings): Moved to PasteboardCocoa.mm.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::typesSafeForBindings): Added.
(WebCore::Pasteboard::typesForLegacyUnsafeBindings): Renamed from readStringForBindings.
(WebCore::Pasteboard::readString): Renamed from readStringForBindings.
(WebCore::Pasteboard::readStringInCustomData): Added.
- platform/wpe/PasteboardWPE.cpp:
(WebCore::Pasteboard::typesSafeForBindings): Added.
(WebCore::PasteboardtypesForLegacyUnsafeBindings): Renamed from readStringForBindings.
(WebCore::Pasteboard::readString): Renamed from readStringForBindings.
(WebCore::Pasteboard::readStringInCustomData): Added.
Sep 29, 2017:
- 11:45 PM Changeset in webkit [222679] by
-
- 56 edits in trunk/Source/WebCore
Use smart pointers for creating, adding and removing renderers
https://bugs.webkit.org/show_bug.cgi?id=177603
Reviewed by Zalan Bujtas.
With this patch RenderObject ownership is consistently managed using RenderPtrs. It also
clarifies that in-tree renderers are always owned by the parent renderer.
- renderers are constructed with createRenderer<> which returns RenderPtr
- addChild and related functions take RenderPtrs
- removeChild is replaced with takeChild that returns a RenderPtr
- only addChildInternal/takeChildInternal deal with raw ownder renderer pointers.
There are still a few exception left, noted below, to be fixed later.
- dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildToContinuation):
(WebCore::RenderBlock::addChild):
(WebCore::RenderBlock::addChildIgnoringContinuation):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::dropAnonymousBoxChild):
(WebCore::RenderBlock::takeChild):
(WebCore::RenderBlock::createAnonymousBlockWithStyleAndDisplay):
(WebCore::RenderBlock::removeChild): Deleted.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousBoxWithSameTypeAs const):
(WebCore::RenderBlock::createAnonymousBlock const):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::addChild):
(WebCore::RenderBlockFlow::takeChild):
(WebCore::RenderBlockFlow::removeChild): Deleted.
- rendering/RenderBlockFlow.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::splitAnonymousBoxesAroundChild):
- rendering/RenderBox.h:
(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs const):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::addChild):
(WebCore::RenderButton::takeChild):
(WebCore::RenderButton::setText):
(WebCore::RenderButton::removeChild): Deleted.
- rendering/RenderButton.h:
- rendering/RenderElement.cpp:
(WebCore::RenderElement::addChild):
(WebCore::RenderElement::takeChild):
(WebCore::RenderElement::removeAndDestroyChild):
(WebCore::RenderElement::destroyLeftoverChildren):
Keep the existing behavior and leak the firstLetter renderer. The comment claims they get destroyed by RenderTextFragment.
To be cleaned up later.
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::takeChildInternal):
(WebCore::RenderElement::handleDynamicFloatPositionChange):
(WebCore::RenderElement::removeChild): Deleted.
(WebCore::RenderElement::removeChildInternal): Deleted.
- rendering/RenderElement.h:
(WebCore::RenderElement::addChildIgnoringContinuation):
- rendering/RenderFullScreen.cpp:
(WebCore::RenderFullScreen::willBeDestroyed):
(WebCore::RenderFullScreen::wrapNewRenderer):
(WebCore::RenderFullScreen::wrapExistingRenderer):
Split wrapRenderer() into two functions, wrapNewRenderer() and wrapExistingRenderer().
The first one deals with adding new renderers to the tree while the latter mutates
existing render tree in-place.
(WebCore::RenderFullScreen::unwrapRenderer):
(WebCore::RenderFullScreen::createPlaceholder):
(WebCore::RenderFullScreen::wrapRenderer): Deleted.
- rendering/RenderFullScreen.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::addChild):
(WebCore::RenderGrid::takeChild):
(WebCore::RenderGrid::removeChild): Deleted.
- rendering/RenderGrid.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addChild):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::addChildToContinuation):
(WebCore::RenderInline::childBecameNonInline):
- rendering/RenderInline.h:
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::createInnerBlock):
(RenderMenuList::addChild):
(RenderMenuList::takeChild):
(RenderMenuList::setText):
(RenderMenuList::removeChild): Deleted.
- rendering/RenderMenuList.h:
- rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::evacuateAndDestroy):
(WebCore::RenderMultiColumnFlow::processPossibleSpannerDescendant):
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
Keep the existing behavior and leak the placeholder renderer.
To be cleaned up later.
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):
Keep the existing behavior and leak the placeholder renderer.
To be cleaned up later.
- rendering/RenderMultiColumnSpannerPlaceholder.cpp:
(WebCore::RenderMultiColumnSpannerPlaceholder::createAnonymous):
- rendering/RenderMultiColumnSpannerPlaceholder.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::removeFromParentAndDestroy):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::destroy):
(WebCore::RenderObject::removeFromParent): Deleted.
- rendering/RenderObject.h:
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateTextRenderer):
- rendering/RenderRuby.cpp:
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderRubyAsInline::addChild):
(WebCore::RenderRubyAsInline::takeChild):
(WebCore::RenderRubyAsBlock::addChild):
(WebCore::RenderRubyAsBlock::takeChild):
(WebCore::RenderRubyAsInline::removeChild): Deleted.
(WebCore::RenderRubyAsBlock::removeChild): Deleted.
- rendering/RenderRuby.h:
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveInlineChildren):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::rubyBaseSafe):
(WebCore::RenderRubyRun::addChild):
(WebCore::RenderRubyRun::takeChild):
(WebCore::RenderRubyRun::createRubyBase const):
(WebCore::RenderRubyRun::staticCreateRubyRun):
(WebCore::RenderRubyRun::removeChild): Deleted.
- rendering/RenderRubyRun.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::createTableWithStyle):
(WebCore::RenderTable::createAnonymousWithParentRenderer):
- rendering/RenderTable.h:
(WebCore::RenderTable::createAnonymousBoxWithSameTypeAs const):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::createTableCellWithStyle):
(WebCore::RenderTableCell::createAnonymousWithParentRenderer):
- rendering/RenderTableCell.h:
(WebCore::RenderTableCell::createAnonymousBoxWithSameTypeAs const):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild):
(WebCore::RenderTableRow::createTableRowWithStyle):
(WebCore::RenderTableRow::createAnonymousWithParentRenderer):
- rendering/RenderTableRow.h:
(WebCore::RenderTableRow::createAnonymousBoxWithSameTypeAs const):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild):
(WebCore::RenderTableSection::createTableSectionWithStyle):
(WebCore::RenderTableSection::createAnonymousWithParentRenderer):
- rendering/RenderTableSection.h:
(WebCore::RenderTableSection::createAnonymousBoxWithSameTypeAs const):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::makeFences):
(WebCore::RenderMathMLFenced::addChild):
- rendering/mathml/RenderMathMLFenced.h:
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::addChild):
(WebCore::RenderSVGContainer::takeChild):
(WebCore::RenderSVGContainer::removeChild): Deleted.
- rendering/svg/RenderSVGContainer.h:
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
(WebCore::RenderSVGInline::takeChild):
(WebCore::RenderSVGInline::removeChild): Deleted.
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addChild):
(WebCore::RenderSVGRoot::takeChild):
(WebCore::RenderSVGRoot::removeChild): Deleted.
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::takeChild):
(WebCore::RenderSVGText::removeChild): Deleted.
- rendering/svg/RenderSVGText.h:
- style/RenderTreePosition.h:
(WebCore::RenderTreePosition::insert):
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::createRenderer):
(WebCore::createTextRenderer):
- style/RenderTreeUpdaterFirstLetter.cpp:
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):
- style/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::createContentRenderers):
- style/RenderTreeUpdaterListItem.cpp:
(WebCore::RenderTreeUpdater::ListItem::updateMarker):
- style/RenderTreeUpdaterMultiColumn.cpp:
(WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow):
- 10:07 PM Changeset in webkit [222678] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: support undo/redo of manual edits
https://bugs.webkit.org/show_bug.cgi?id=177314
Reviewed by Joseph Pecoraro.
Make sure Command-Z and Command-Shift-Z undo changes in the styles sidebar
when not focused on a contentEditable field.
- UserInterface/Views/EditingSupport.js:
(WI.isEventTargetAnEditableField):
Make sure WI._undoKeyboardShortcut doesn't call WI.undo() when editing inside of a contentEditable element.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor):
Call style setter to setup event listeners during instantiation.
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.set style):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
Update style declaration section when it isn't focused.
This is the same logic as in the old styles sidebar (CSSStyleDeclarationTextEditor style setter).
- 9:31 PM Changeset in webkit [222677] by
-
- 8 edits in trunk/Source/WebCore
Remove redundant RenderObject::selectionRoot and dependencies
https://bugs.webkit.org/show_bug.cgi?id=177696
Reviewed by Ryosuke Niwa.
There's only one selection root (RenderView).
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::selectionStartEnd const):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::selectionRoot const): Deleted.
(WebCore::RenderObject::selectionStartEnd const): Deleted.
- rendering/RenderObject.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::isSelected const):
- rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionRectsForLineBoxes):
- rendering/RenderTextLineBoxes.cpp:
(WebCore::RenderTextLineBoxes::setSelectionState):
- rendering/RenderView.h:
- rendering/SelectionSubtreeRoot.h:
- 7:11 PM Changeset in webkit [222676] by
-
- 2 edits in trunk/Source/WebKitLegacy/mac
Follow-up to https://trac.webkit.org/r222239 to fix crashes.
rdar://problem/34705779
Addressing review comments that I somehow landed without.
- WebView/WebHTMLView.mm: Undo adding #if guards around -_web_uniqueWebDataURL
- 6:16 PM Changeset in webkit [222675] by
-
- 18 edits14 adds in trunk
[DFG] Support ArrayPush with multiple args
https://bugs.webkit.org/show_bug.cgi?id=175823
Reviewed by Saam Barati.
JSTests:
- microbenchmarks/array-push-0.js: Added.
(arrayPush0):
- microbenchmarks/array-push-1.js: Added.
(arrayPush1):
- microbenchmarks/array-push-2.js: Added.
(arrayPush2):
- microbenchmarks/array-push-3.js: Added.
(arrayPush3):
- stress/array-push-multiple-contiguous.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-double-nan.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-double.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-int32.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-many-contiguous.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-many-double.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-many-int32.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-many-storage.js: Added.
(shouldBe):
(test):
- stress/array-push-multiple-storage.js: Added.
(shouldBe):
(test):
- stress/array-push-with-force-exit.js: Added.
(target.createBuiltin):
Source/JavaScriptCore:
Reviewed by Saam Barati.
This patch implements ArrayPush(with multiple arguments) in DFG and FTL. Previously, they are not handled
by ArrayPush. Then they go to generic direct call to Array#push and it does in slow path. This patch
extends ArrayPush to push multiple arguments in a bulk push manner.
The problem of ArrayPush is that we need to perform ArrayPush atomically: If OSR exit occurs in the middle
of ArrayPush, we incorrectly push pushed elements twice. Once we start pushing values, we should not exit.
But we do not want to iterate elements twice, once for type checks and once for actually pushing it. It
could move elements between registers and memory back and forth.
This patch achieves the above goal by separating type checks from ArrayPush. When starting ArrayPush, type
checks for elements are already done by separately emitted Check nodes.
We also add JSArray::pushInline for DFG operations just calling JSArray::push. And we also use it in
arrayProtoFuncPush's fast path.
This patch significantly improves performance of
push(multiple args).
baseline patched
Microbenchmarks:
array-push-0 461.8455+-28.9995 151.3438+-6.5653 definitely 3.0516x faster
array-push-1 133.8845+-7.0349 ? 136.1775+-5.8327 ? might be 1.0171x slower
array-push-2 675.6555+-13.4645 145.8747+-6.4621 definitely 4.6318x faster
array-push-3 849.5284+-15.2540 253.4421+-9.1249 definitely 3.3520x faster
baseline patched
SixSpeed:
spread-literal.es5 90.3482+-6.6514 24.8123+-2.3304 definitely 3.6413x faster
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArrayPush):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStoreBarrierInsertionPhase.cpp:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArrayPush):
- jit/JITOperations.h:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
- runtime/JSArray.cpp:
(JSC::JSArray::push):
- runtime/JSArray.h:
- runtime/JSArrayInlines.h:
(JSC::JSArray::pushInline):
- 5:54 PM Changeset in webkit [222674] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION: ASSERTION FAILED: m_provisionalURL.isEmpty() in WebKit::FrameLoadState::didStartProvisionalLoad
https://bugs.webkit.org/show_bug.cgi?id=177491
Patch by Alex Christensen <achristensen@webkit.org> on 2017-09-29
Reviewed by Andy Estes.
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::setUpWillSubmitFormListener):
(WebKit::WebFrame::continueWillSubmitForm):
(WebKit::WebFrame::invalidatePolicyListener):
Speculative fix for a flaky assertion.
Restore the clearing of the policy listeners we used to have when form submission was treated as a policy.
- 5:35 PM Changeset in webkit [222673] by
-
- 21 edits in trunk
http/tests/preconnect/link-rel-preconnect-https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=177673
Reviewed by Alex Christensen.
Source/WebCore:
No new tests, unskipped test that is now passing consistently.
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
- loader/LoaderStrategy.h:
Source/WebKit:
Update PreconnectTask to query the client when a certificate needs to be
validated. This allows WebKitTestRunner to ignore invalid certificates
and this causes http/tests/preconnect/link-rel-preconnect-https.html
to pass consistently.
To avoid duplicating code, PreconnectTask now uses NetworkLoad internally
instead of using a NetworkDataTask directly.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::preconnectTo):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::generateCanAuthenticateIdentifier):
(WebKit::NetworkProcess::canAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::preconnectTo):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
- NetworkProcess/PreconnectTask.cpp:
(WebKit::PreconnectTask::PreconnectTask):
(WebKit::PreconnectTask::~PreconnectTask):
(WebKit::PreconnectTask::willSendRedirectedRequest):
(WebKit::PreconnectTask::didReceiveResponse):
(WebKit::PreconnectTask::didReceiveBuffer):
(WebKit::PreconnectTask::didFinishLoading):
(WebKit::PreconnectTask::didFailLoading):
(WebKit::PreconnectTask::didSendData):
(WebKit::PreconnectTask::canAuthenticateAgainstProtectionSpaceAsync):
(WebKit::PreconnectTask::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::PreconnectTask::frameID const):
(WebKit::PreconnectTask::pageID const):
- NetworkProcess/PreconnectTask.h:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::preconnectTo):
- WebProcess/Network/WebLoaderStrategy.h:
Source/WebKitLegacy:
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::preconnectTo):
- WebCoreSupport/WebResourceLoadScheduler.h:
LayoutTests:
- http/tests/preconnect/link-rel-preconnect-https-expected.txt:
Rebaseline test now that it is passing.
- platform/wk2/TestExpectations:
Uskip test as it should no longer be flaky.
- 5:29 PM Changeset in webkit [222672] by
-
- 5 edits in trunk
Expose WebPreferences::webGLEnabled through WKPreferences
https://bugs.webkit.org/show_bug.cgi?id=177692
<rdar://problem/24110556>
Reviewed by Andy Estes.
Source/WebKit:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setWebGLEnabled:]):
(-[WKPreferences _webGLEnabled]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/Preferences.mm:
(-[AlertSaver alert]):
(-[AlertSaver webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):
- 4:48 PM Changeset in webkit [222671] by
-
- 7 edits1 add in trunk
Custom GetterSetterAccessCase does not use the correct slotBase when making call
https://bugs.webkit.org/show_bug.cgi?id=177639
Reviewed by Geoffrey Garen.
JSTests:
- stress/custom-get-set-inline-caching-one-level-up-proto-chain.js: Added.
(assert):
(Class):
(items.forEach):
(set get for):
Source/JavaScriptCore:
The bug occurred when you had a custom set value. Custom set/get
values are passed the property holder, not the base of the access.
If we had an object chain like this:
o = {proto: thingWithCustomSetValue}
We would end up not providing thingWithCustomSetValue as the argument
to the PutValueFunc. The reason is, we would use generateConditionsForPrototypePropertyHitCustom
for custom sets. This would return to us an empty ConditionSet, because
the property holder was only one level up the prototype chain. The reason
is, it didn't generate a condition for the slot holder, because the
protocol for custom set/get is that if an object responds to a custom
setter/getter, it will continue to respond to that getter/setter for
the lifetime of that object. Therefore, it's not strictly necessary to
generate an OPC for the slot base for custom accesses. However, AccessCase
uses !m_conditionSet.isEmtpy() to indicate that the IC is doing a prototype
access. With the above object "o", we were doing a prototype access, but we
had an empty condition set. This lead us to passing the base instead of
the property holder to the custom set value function, which is incorrect.
With custom getters, we never called to into the generateConditionsForPrototypePropertyHitCustom
API. Gets would always call into generateConditionsForPrototypePropertyHit, which
will generate an OPC on the slot base, even if it isn't strictly necessary for custom accessors.
This patch simply removes generateConditionsForPrototypePropertyHitCustom
and aligns the set case with the get case. It makes us properly detect
when we're doing a prototype access with the above object "o". If we find
that generateConditionsForPrototypePropertyHitCustom was a worthwhile
optimization to have, we can re-introduce it. We'll just need to pipe through
a new notion of when we're doing prototype accesses that doesn't rely solely
on !m_conditionSet.isEmpty().
- bytecode/ObjectPropertyConditionSet.cpp:
(JSC::generateConditionsForPrototypePropertyHitCustom): Deleted.
- bytecode/ObjectPropertyConditionSet.h:
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
- jsc.cpp:
(JSTestCustomGetterSetter::JSTestCustomGetterSetter):
(JSTestCustomGetterSetter::create):
(JSTestCustomGetterSetter::createStructure):
(customGetAccessor):
(customGetValue):
(customSetAccessor):
(customSetValue):
(JSTestCustomGetterSetter::finishCreation):
(GlobalObject::finishCreation):
(functionLoadGetterFromGetterSetter):
(functionCreateCustomTestGetterSetter):
- runtime/PropertySlot.h:
(JSC::PropertySlot::setCustomGetterSetter):
- 4:42 PM Changeset in webkit [222670] by
-
- 3 edits in trunk/Source/WebCore
Extract logic to compute text to render into common function
https://bugs.webkit.org/show_bug.cgi?id=177607
Reviewed by Zalan Bujtas.
Currently we duplicate the logic to compute the text to render
throughout InlineTextBox. Instead we should move this common
code into a member function. This will allow us to audit the
the code paths that render text and ensure such code paths
account for hyphenation and combined text, if applicable.
Note that a TextRun does not own the text. The caller owns it.
No functionality changed. So, no new tests.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect const): Modified to
use text() and createTextRun() to compute the text to render
and the text run for it.
(WebCore::InlineTextBox::paint): Ditto.
(WebCore::InlineTextBox::paintSelection): Ditto. Additionally query
lineStyle() for the style of the line instead of requiring it to be
passed as an argument.
(WebCore::InlineTextBox::paintTextSubrangeBackground): Modified
to use text() and createTextRun() to compute the text to render
and the text run for it.
(WebCore::InlineTextBox::paintDocumentMarker): Ditto.
(WebCore::InlineTextBox::offsetForPosition const): Ditto.
(WebCore::InlineTextBox::positionForOffset const): Ditto.
(WebCore::InlineTextBox::createTextRun const): Added; formerly named constructTextRun.
(WebCore::InlineTextBox::text const): Added.
(WebCore::InlineTextBox::substringToRender const): Deleted.
(WebCore::InlineTextBox::hyphenatedStringForTextRun const): Deleted.
(WebCore::InlineTextBox::constructTextRun const): Deleted.
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::substringToRender): Deleted.
(WebCore::InlineTextBox::hyphenatedStringForTextRun): Deleted.
(WebCore::InlineTextBox::constructTextRun): Deleted; renamed to createTextRun.
- 3:50 PM Changeset in webkit [222669] by
-
- 4 edits in trunk/Source/WebCore
Remove SelectionSubtreeRoot::RenderSubtreesMap
https://bugs.webkit.org/show_bug.cgi?id=177685
Reviewed by Andy Estes.
This is in preparation of removing redundant SelectionSubtreeRoot.
(Now that we removed regions, RenderView is the only selection root)
No change in functionality.
- rendering/RenderView.cpp:
(WebCore::RenderView::selectionBounds const):
(WebCore::RenderView::subtreeSelectionBounds const):
(WebCore::RenderView::repaintSelection const):
(WebCore::RenderView::repaintSubtreeSelection const):
(WebCore::RenderView::setSelection):
(WebCore::isValidObjectForNewSelection):
(WebCore::RenderView::clearSubtreeSelection const):
(WebCore::RenderView::applySubtreeSelection):
(WebCore::RenderView::updateSelectionForSubtrees): Deleted.
- rendering/RenderView.h:
- rendering/SelectionSubtreeRoot.h:
- 3:25 PM Changeset in webkit [222668] by
-
- 13 edits3 deletes in trunk
Unreviewed, rolling out r222652.
This broke an internal build.
Reverted changeset:
"Build libwebrtc unit tests executables"
https://bugs.webkit.org/show_bug.cgi?id=177211
http://trac.webkit.org/changeset/222652
- 3:08 PM Changeset in webkit [222667] by
-
- 10 edits in trunk/Source/WebKit
[WK2][NETWORK_SESSION] Move some authentication-related code to avoid duplication
https://bugs.webkit.org/show_bug.cgi?id=177667
Reviewed by Alex Christensen.
Move some authentication-related code to avoid duplication.
This is a preparation code supporting Download authentication
as Download uses a NSURLSessionDownloadTask and not a
NetworkDataTask.
- NetworkProcess/NetworkDataTask.h:
(WebKit::NetworkDataTask::setSuggestedFilename):
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::allowsSpecificHTTPSCertificateForHost):
- NetworkProcess/NetworkSession.h:
- NetworkProcess/PreconnectTask.cpp:
(WebKit::PreconnectTask::didReceiveChallenge):
- NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::didReceiveChallenge):
- NetworkProcess/cocoa/NetworkSessionCocoa.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(WebKit::certificatesMatch):
(WebKit::NetworkSessionCocoa::allowsSpecificHTTPSCertificateForHost):
- 2:35 PM Changeset in webkit [222666] by
-
- 5 edits1 add in trunk
Fix WKWebViewConfigurationPrivate after r222663
https://bugs.webkit.org/show_bug.cgi?id=177644
Source/WebKit:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm: Added.
(TEST):
- 2:19 PM Changeset in webkit [222665] by
-
- 5 edits3 adds in trunk/Source/WebCore
[Curl] Extract a features to manage HTTP communication from ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=175148
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-09-29
Reviewed by Alex Christensen.
- platform/Curl.cmake:
- platform/network/curl/CurlRequest.cpp: Added.
(WebCore::CurlRequest::CurlRequest):
(WebCore::CurlRequest::setUserPass):
(WebCore::CurlRequest::start):
(WebCore::CurlRequest::startWithJobManager):
(WebCore::CurlRequest::cancel):
(WebCore::CurlRequest::suspend):
(WebCore::CurlRequest::resume):
(WebCore::CurlRequest::callDelegate):
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::willSetupSslCtx):
(WebCore::CurlRequest::willSendData):
(WebCore::CurlRequest::didReceiveHeader):
(WebCore::CurlRequest::didReceiveData):
(WebCore::CurlRequest::didCompleteTransfer):
(WebCore::CurlRequest::didCancelTransfer):
(WebCore::CurlRequest::resolveBlobReferences):
(WebCore::CurlRequest::setupPUT):
(WebCore::CurlRequest::setupPOST):
(WebCore::CurlRequest::setupFormData):
(WebCore::CurlRequest::invokeDidReceiveResponseForFile):
(WebCore::CurlRequest::invokeDidReceiveResponse):
(WebCore::CurlRequest::setPaused):
(WebCore::CurlRequest::willSetupSslCtxCallback):
(WebCore::CurlRequest::willSendDataCallback):
(WebCore::CurlRequest::didReceiveHeaderCallback):
(WebCore::CurlRequest::didReceiveDataCallback):
- platform/network/curl/CurlRequest.h: Added.
(WebCore::CurlRequest::~CurlRequest):
(WebCore::CurlRequest::setDelegate):
(WebCore::CurlRequest::isSyncRequest):
(WebCore::CurlRequest::getNetworkLoadMetrics):
- platform/network/curl/CurlRequestDelegate.h: Added.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::receivedCancellation):
- platform/network/curl/ResourceHandleCurlDelegate.cpp:
(WebCore::ResourceHandleCurlDelegate::ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::~ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::start):
(WebCore::ResourceHandleCurlDelegate::cancel):
(WebCore::ResourceHandleCurlDelegate::setDefersLoading):
(WebCore::ResourceHandleCurlDelegate::setAuthentication):
(WebCore::ResourceHandleCurlDelegate::dispatchSynchronousJob):
(WebCore::ResourceHandleCurlDelegate::createCurlRequest):
(WebCore::ResourceHandleCurlDelegate::cancelledOrClientless):
(WebCore::ResourceHandleCurlDelegate::curlDidReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::curlDidReceiveBuffer):
(WebCore::ResourceHandleCurlDelegate::curlDidComplete):
(WebCore::ResourceHandleCurlDelegate::curlDidFailWithError):
(WebCore::ResourceHandleCurlDelegate::response):
(WebCore::ResourceHandleCurlDelegate::getCredential):
(WebCore::ResourceHandleCurlDelegate::retain): Deleted.
(WebCore::ResourceHandleCurlDelegate::release): Deleted.
(WebCore::ResourceHandleCurlDelegate::setupTransfer): Deleted.
(WebCore::ResourceHandleCurlDelegate::didCompleteTransfer): Deleted.
(WebCore::ResourceHandleCurlDelegate::didCancelTransfer): Deleted.
(WebCore::ResourceHandleCurlDelegate::setupAuthentication): Deleted.
(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders): Deleted.
(WebCore::ResourceHandleCurlDelegate::didReceiveContentData): Deleted.
(WebCore::ResourceHandleCurlDelegate::handleLocalReceiveResponse): Deleted.
(WebCore::ResourceHandleCurlDelegate::prepareSendData): Deleted.
(WebCore::ResourceHandleCurlDelegate::didFinish): Deleted.
(WebCore::ResourceHandleCurlDelegate::didFail): Deleted.
(WebCore::ResourceHandleCurlDelegate::setupPOST): Deleted.
(WebCore::ResourceHandleCurlDelegate::setupPUT): Deleted.
(WebCore::ResourceHandleCurlDelegate::getFormElementsCount): Deleted.
(WebCore::ResourceHandleCurlDelegate::setupFormData): Deleted.
(WebCore::ResourceHandleCurlDelegate::applyAuthentication): Deleted.
(WebCore::ResourceHandleCurlDelegate::getNetworkLoadMetrics): Deleted.
(WebCore::ResourceHandleCurlDelegate::willSetupSslCtx): Deleted.
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader): Deleted.
(WebCore::ResourceHandleCurlDelegate::didReceiveData): Deleted.
(WebCore::ResourceHandleCurlDelegate::willSendData): Deleted.
(WebCore::ResourceHandleCurlDelegate::willSetupSslCtxCallback): Deleted.
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderCallback): Deleted.
(WebCore::ResourceHandleCurlDelegate::didReceiveDataCallback): Deleted.
(WebCore::ResourceHandleCurlDelegate::willSendDataCallback): Deleted.
- platform/network/curl/ResourceHandleCurlDelegate.h:
- 2:14 PM Changeset in webkit [222664] by
-
- 32 edits1 copy4 moves1 add in trunk/Source
Split some logic out of VisitedLinkStore and make it reusable
https://bugs.webkit.org/show_bug.cgi?id=177575
Reviewed by Alex Christensen.
Source/WebCore:
Rename LinkHash to SharedStringHash to make it more reusable.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/StyleResolver.cpp:
- dom/VisitedLinkState.cpp:
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- dom/VisitedLinkState.h:
- html/HTMLAnchorElement.h:
(WebCore::HTMLAnchorElement::visitedLinkHash const):
- loader/EmptyClients.cpp:
- loader/HistoryController.cpp:
(WebCore::addVisitedLink):
- page/Page.cpp:
(WebCore::Page::invalidateStylesForLink):
- page/Page.h:
- page/VisitedLinkStore.cpp:
(WebCore::VisitedLinkStore::invalidateStylesForLink):
- page/VisitedLinkStore.h:
- platform/SharedStringHash.cpp: Renamed from Source/WebCore/platform/LinkHash.cpp.
(WebCore::needsTrailingSlash):
(WebCore::computeSharedStringHashInline):
(WebCore::computeSharedStringHash):
- platform/SharedStringHash.h: Renamed from Source/WebCore/platform/LinkHash.h.
(WebCore::SharedStringHashHash::hash):
(WebCore::SharedStringHashHash::equal):
(WebCore::SharedStringHashHash::avoidDeletedValue):
Source/WebKit:
Split some logic out of VisitedLinkStore and make it reusable for other purposes than
visited links and from other processes than the UIProcess.
The plan is to reuse the new SharedStringHashStore for Service Worker registration
on StorageProcess side and querying on WebContent process side.
- CMakeLists.txt:
- Shared/SharedStringHashStore.cpp: Added.
(WebKit::nextPowerOf2):
(WebKit::tableSizeForKeyCount):
(WebKit::SharedStringHashStore::SharedStringHashStore):
(WebKit::SharedStringHashStore::createSharedMemoryHandle):
(WebKit::SharedStringHashStore::add):
(WebKit::SharedStringHashStore::clear):
(WebKit::SharedStringHashStore::resizeTable):
(WebKit::SharedStringHashStore::pendingSharedStringHashesTimerFired):
- Shared/SharedStringHashStore.h: Copied from Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.h.
(WebKit::SharedStringHashStore::Client::~Client):
(WebKit::SharedStringHashStore::isEmpty const):
- Shared/SharedStringHashTable.cpp: Renamed from Source/WebKit/Shared/VisitedLinkTable.cpp.
(WebKit::SharedStringHashTable::SharedStringHashTable):
(WebKit::SharedStringHashTable::~SharedStringHashTable):
(WebKit::SharedStringHashTable::setSharedMemory):
(WebKit::SharedStringHashTable::add):
(WebKit::SharedStringHashTable::contains const):
(WebKit::SharedStringHashTable::clear):
- Shared/SharedStringHashTable.h: Renamed from Source/WebKit/Shared/VisitedLinkTable.h.
- UIProcess/API/C/WKContext.cpp:
(WKContextAddVisitedLink):
- UIProcess/API/Cocoa/_WKVisitedLinkStore.mm:
(-[_WKVisitedLinkStore addVisitedLinkWithURL:]):
- UIProcess/VisitedLinkStore.cpp:
(WebKit::VisitedLinkStore::VisitedLinkStore):
(WebKit::VisitedLinkStore::addProcess):
(WebKit::VisitedLinkStore::addVisitedLinkHash):
(WebKit::VisitedLinkStore::removeAll):
(WebKit::VisitedLinkStore::addVisitedLinkHashFromPage):
(WebKit::VisitedLinkStore::sendStoreHandleToProcess):
(WebKit::VisitedLinkStore::didInvalidateSharedMemory):
(WebKit::VisitedLinkStore::didAddSharedStringHashes):
- UIProcess/VisitedLinkStore.h:
- UIProcess/WebProcessPool.cpp:
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::isLinkVisited):
(WebKit::VisitedLinkTableController::addVisitedLink):
(WebKit::VisitedLinkTableController::visitedLinkStateChanged):
- WebProcess/WebPage/VisitedLinkTableController.h:
- WebProcess/WebPage/VisitedLinkTableController.messages.in:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebVisitedLinkStore.h:
- WebCoreSupport/WebVisitedLinkStore.mm:
(WebVisitedLinkStore::addVisitedLink):
(WebVisitedLinkStore::removeVisitedLink):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLinkHash):
Source/WebKitLegacy/win:
- WebCoreSupport/WebVisitedLinkStore.cpp:
(WebVisitedLinkStore::addVisitedLink):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLinkHash):
- WebCoreSupport/WebVisitedLinkStore.h:
- 1:50 PM Changeset in webkit [222663] by
-
- 4 edits in trunk/Source/WebKit
Add WKWebViewConfiguration SPI equivalent to WKPageConfigurationSetBackgroundCPULimit
https://bugs.webkit.org/show_bug.cgi?id=177644
<rdar://problem/34338698>
Reviewed by Geoffrey Garen.
WKPageConfigurationSetBackgroundCPULimit is a setter of a std::optional<double> with no accessor.
It's never set to 0 in practice, so I guess the ObjC equivalent is a double that is zero or nonzero.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _setCPULimit:]):
(-[WKWebViewConfiguration _cpuLimit]):
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- 12:54 PM Changeset in webkit [222662] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Open Resource Dialog icons are blurry (24x24 instead of 32x32)
https://bugs.webkit.org/show_bug.cgi?id=177631
<rdar://problem/34729636>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-29
Reviewed by Matt Baker.
- UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .tree-outline.large .item):
(.open-resource-dialog > .tree-outline.large .item .icon):
(.open-resource-dialog .tree-outline.large .item .titles):
Make the rows large enough to fit the full 32x32 icon instead of a blurry 24x24.
- 12:47 PM Changeset in webkit [222661] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught exception with populate find keyboard shortcut
https://bugs.webkit.org/show_bug.cgi?id=177672
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-29
Reviewed by Matt Baker.
- UserInterface/Base/Main.js:
The focusedContentView can be null so bail if that is the case.
- 12:32 PM Changeset in webkit [222660] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Fix build after rev 222610
https://bugs.webkit.org/show_bug.cgi?id=177674
Reviewed by Per Arne Vollan.
No new tests. No change in behavior.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
- 11:53 AM Changeset in webkit [222659] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Remove unused pre-iOS 11 codepaths for writing to the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=177669
Reviewed by Tim Horton.
Now that PlatformPasteboardIOS codepaths for writing data on drag and copy have been unified to both use
NSItemProviders, we can remove the legacy codepath that called -setItems on UIPasteboard, since nothing uses it
any more. No change in behavior.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const):
(WebCore::PlatformPasteboard::allowReadingURLAtIndex const):
(WebCore::PlatformPasteboard::readURL):
(WebCore::richTextRepresentationsForPasteboardWebContent): Deleted.
- 11:49 AM Changeset in webkit [222658] by
-
- 18 edits13 deletes in trunk
Unreviewed, rolling out r222563, r222565, and r222581.
https://bugs.webkit.org/show_bug.cgi?id=177675
"It causes a crash when playing youtube videos" (Requested by
saamyjoon on #webkit).
Reverted changesets:
"[DFG] Support ArrayPush with multiple args"
https://bugs.webkit.org/show_bug.cgi?id=175823
http://trac.webkit.org/changeset/222563
"Unreviewed, build fix after r222563"
https://bugs.webkit.org/show_bug.cgi?id=175823
http://trac.webkit.org/changeset/222565
"Unreviewed, fix x86 breaking due to exhausted registers"
https://bugs.webkit.org/show_bug.cgi?id=175823
http://trac.webkit.org/changeset/222581
- 11:48 AM Changeset in webkit [222657] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, temporarily mark http/tests/preconnect/link-rel-preconnect-https.html as flaky.
- platform/wk2/TestExpectations:
- 11:46 AM Changeset in webkit [222656] by
-
- 25 edits9 adds in trunk
Image pasting is not working on tineye.com / gmail.com / GitHub.com due to lack of support for DataTransfer.items
https://bugs.webkit.org/show_bug.cgi?id=170449
<rdar://problem/31432525>
Reviewed by Wenson Hsieh.
Source/WebCore:
The bug was caused by image types in NSPasteboard or UIPasteboard not being treated as file items in dataTransfer.
Because there is no Web API to get binary data out of dataTransfer unlike text data, we need to treat any image
data as files even if they're entirely in the memory.
This patch introduces the notion of pasteboard types to be treated as files and expose them on dataTransfer.files
as well as dataTransfer.items of type "file". Because in-memory images are stored as TIFF in macOS and websites
don't typically support image/tiff, we convert all such in-memory TIFF images into PNG images ourselves for
a better web compatibility. This is done inside read(PasteboardFileReader&) in PasteboardCocoa.mm.
Note that PasteboardFileReader cannot directly have RefPtr<File> as a member variable as code in WebCore/platform
including Pasteboard code is not supposed to depend on WebCore types. WebCorePasteboardFileReader, a subclass of
PasteboardFileReader was introduced to resolve this reverse dependency.
In addition, this patch removes the restriction on dataTransfer.items that it only includes files of the supported
MIME types. This was unwarranted since 1. we don't have any restriction on what an user can drag & drop into a web
page via input element so there is no security benefit in this, and 2. the user should be able to copy & paste
whatever file he/she desires regardless of the MIME type on websites like Google Drive.
Tests: PasteImage
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- WebCore/PlatformMac.cmake:
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::types const): Now excludes image/gif, image/png, image/jpeg, and image/tiff.
(WebCore::DataTransfer::files const): Add fake files we create for in-memory images but only when there are no real
files in the pasteboard since it's expensive to copy image data across UI/Web processes to create a blob URL.
- dom/DataTransferItemList.cpp:
(WebCore::DataTransferItemList::ensureItems const): Just expose every file type. If the user had decided to paste
a file, it's okay for the page to access that file regardless of whether it's a zip file, JPEG image, etc...
- editing/WebCorePasteboardFileReader.cpp:
(WebCorePasteboardFileReader::~WebCorePasteboardFileReader):
(WebCorePasteboardFileReader::read):
- editing/WebCorePasteboardFileReader.h:
(WebCorePasteboardFileReader):
- platform/Pasteboard.cpp:
(WebCore::PasteboardImage::PasteboardImage): Moved from platform specific translation units.
(WebCore::PasteboardImage::~PasteboardImage): Ditto.
- platform/Pasteboard.h:
(PasteboardFileReader): Added.
(* platform/StaticPasteboard.h:
(StaticPasteboard::typesForBindings): Added.
(StaticPasteboard::typesTreatedAsFiles): Added. Returns an empty list we don't support the web content writing image
files into pasteboard at the moment.
- platform/cocoa/PasteboardCocoa.mm: Added.
(WebCore::PasteboardWebContent::PasteboardWebContent): Moved from PasteboardMac.mm and PasteboardIOS.mm.
(WebCore::PasteboardWebContent::~PasteboardWebContent):
(WebCore::cocoaTypeToImageType): Added.
(WebCore::imageTypeToMIMEType): Added. Pretends to have image/png when the Cocoa type is image/tiff since most of
websites don't support image/tiff.
(WebCore::imageTypeToFakeFilename): Added.
(WebCore::mimeTypeToImageType): Added.
(WebCore::Pasteboard::shouldTreatCocoaTypeAsFile): Added. Pasteboard::typesForBindings excludes the type for which
this function returns true.
(WebCore::Pasteboard::typesTreatedAsFiles): Returns the list of all in-memory image types in the pasteboard.
(WebCore::Pasteboard::read): Added. On macOS, we convert TIFF to PNG for web compatibility. We don't do this rather
memory intensive coercion on iOS where most of apps like Photos put PNG file into the pasteboard in the first place.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::PasteboardImage::PasteboardImage): Deleted.
(WebCore::PasteboardImage::~PasteboardImage): Deleted.
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::typesForBindings): Renamed from types.
(WebCore::Pasteboard::typesTreatedAsFiles):
- platform/ios/PasteboardIOS.mm:
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::Pasteboard::typesForBindings):
(WebCore::PasteboardWebContent::PasteboardWebContent): Deleted.
(WebCore::PasteboardWebContent::~PasteboardWebContent): Deleted.
(WebCore::PasteboardImage::PasteboardImage): Deleted.
(WebCore::PasteboardImage::~PasteboardImage): Deleted.
(WebCore::Pasteboard::types): Deleted.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType): Add "Files" to dataTransfer.types when there is an in-memory
image type in the pasteboard.
- platform/mac/PasteboardMac.mm:
(WebCore::PasteboardWebContent::PasteboardWebContent): Deleted.
(WebCore::PasteboardWebContent::~PasteboardWebContent): Deleted.
(WebCore::PasteboardImage::PasteboardImage): Deleted.
(WebCore::PasteboardImage::~PasteboardImage): Deleted.
(WebCore::addHTMLClipboardTypesForCocoaType): Moved the check for the legacy NeXT plain text check here. Also add
"Files" to dataTransfer.types when there is an in-memory image type in the pasteboard.
(WebCore::Pasteboard::typesForBindings): Renamed from types.
- platform/mac/PlatformPasteboardMac.mm:
(WebCore::safeTypeForDOMToReadAndWriteForPlatformType): Ditto to add "Files".
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::typesForBindings): Renamed from types.
(WebCore::Pasteboard::typesTreatedAsFiles):
(WebCore::Pasteboard::read):
- platform/wpe/PasteboardWPE.cpp:
(WebCore::Pasteboard::typesForBindings): Renamed from types.
(WebCore::Pasteboard::typesTreatedAsFiles):
(WebCore::Pasteboard::read):
Source/WebKit:
Add sandbox extensions for files in the pasteboard to make copying & pasting image files work.
This is what we do for drag & drop but we should consider adding a mechanism to rekoke the extension in the future.
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::getPasteboardPathnamesForType): Add sandbox extensions to the pasted files.
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::getPathnamesForType): Consume the sandbox tokens sent by the UI process permanently
since WebCore will now create File objects for these pasted files.
Tools:
Added an API test to paste an image from pasteboard. The test is shared between iOS and macOS.
The tests to paste image files are only enabled on macOS since putting files into pasteboard isn't a thing on iOS.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm: Added.
(writeImageDataToPasteboard):
(writeBundleFileToPasteboard):
- TestWebKitAPI/Tests/WebKitCocoa/paste-image.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-100px.tiff: Added.
- TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-200px.png: Added.
- TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-400px.gif: Added.
- TestWebKitAPI/Tests/WebKitCocoa/sunset-in-cupertino-600px.jpg: Added.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Rebaselined the test now that types contain "Files".
- 11:37 AM Changeset in webkit [222655] by
-
- 2 edits in trunk/LayoutTests
Re-enable more pasteboard tests on iOS after r222595
https://bugs.webkit.org/show_bug.cgi?id=177637
Reviewed by Wenson Hsieh.
- platform/ios/TestExpectations:
- 11:33 AM Changeset in webkit [222654] by
-
- 14 edits in trunk
[iOS WK2] Implement -[WKContentView hasText] for compatibility with the UITextInput protocol
https://bugs.webkit.org/show_bug.cgi?id=177662
<rdar://problem/33410373>
Reviewed by Tim Horton.
Source/WebCore:
Adds a new TextIterator helper function to determine whether a Range has any plain text.
Tests: EditorStateTests.ContentViewHasTextInContentEditableElement
EditorStateTests.ContentViewHasTextInTextarea
- editing/TextIterator.cpp:
(WebCore::hasAnyPlainText):
Add a new helper to determine whether a Range contains any plain text. While inspired by and very similar to the
plainText() helper function, this variant does not create a new string buffer when invoked, and is therefore
more efficient for the purposes of determining whether there is any plain text at all.
- editing/TextIterator.h:
Source/WebKit:
Implements -[WKContentView hasText] by propagating a flag through post-layout editor state.
- Shared/EditorState.cpp:
(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
- Shared/EditorState.h:
Add a new flag to EditorState indicating whether or not the current editable root containing the selection has
any plain text. Add IPC support for this new flag.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView hasText]):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::computeEditableRootHasContentAndPlainText):
Add a new helper to compute whether or not the editable root has any content, and any plain text. This
is used as the last cached value for -hasText on WKContentView that we will deliver to UIKit. Some important
things to note here:
- If post layout data already indicates that we have selected some plain text, or that there is a plain text character near the selection, just set the flags to true and bail, since the editable root necessarily has content that is plain text.
- If hasContent is false, don't even bother computing hasPlainText, because it must also be false.
- Otherwise, use hasAnyPlainText to compute the value of hasPlainText, which is a faster variant of plainText.
These optimizations help us avoid doing extra work at all when running Speedometer, apart from checking the
values of a few PostLayoutData flags. This also fixes the value of hasContent, which was previously always false
if we had a range selection rather than a caret selection even when the editable root has content, because the
logic to compute the value of hasContent only existed in the branch where we have a caret selection.
(WebKit::WebPage::platformEditorState const):
Tools:
Add EditorState API tests to check that the value of -[WKContentView hasText] is correct when editing both plain
and rich text areas.
- TestWebKitAPI/EditingTestHarness.h:
- TestWebKitAPI/EditingTestHarness.mm:
(-[EditingTestHarness insertParagraph]):
(-[EditingTestHarness insertText:]):
(-[EditingTestHarness insertHTML:]):
(-[EditingTestHarness selectAll]):
(-[EditingTestHarness deleteBackwards]):
- TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
Add versions of EditingTestHarness helpers that don't require us to expect any editor state after executing the
edit command.
(TestWebKitAPI::checkContentViewHasTextWithFailureDescription):
(TestWebKitAPI::TEST):
- TestWebKitAPI/cocoa/TestWKWebView.h:
- TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView textInputContentView]):
- 10:50 AM Changeset in webkit [222653] by
-
- 11 edits in trunk/Source/WebCore
Add WeakPtr support to RenderObject.
https://bugs.webkit.org/show_bug.cgi?id=177429
<rdar://problem/34625212>
Reviewed by Dean Jackson.
This is in preparation to start using weak pointers extensively in rendering.
No change in functionality.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadPlugin):
- page/FrameView.cpp:
(WebCore::FrameView::updateEmbeddedObject):
- rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
- rendering/RenderMultiColumnSpannerPlaceholder.h:
- rendering/RenderObject.cpp:
- rendering/RenderObject.h:
(WebCore::RenderObject::createWeakPtr):
- rendering/RenderView.cpp:
(WebCore::RenderView::RepaintRegionAccumulator::RepaintRegionAccumulator):
(WebCore::RenderView::RepaintRegionAccumulator::~RepaintRegionAccumulator):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::setWidget):
(WebCore::RenderWidget::updateWidgetPosition):
- rendering/RenderWidget.h:
(WebCore::RenderWidget::createWeakPtr): Deleted.
- 10:05 AM Changeset in webkit [222652] by
-
- 13 edits3 adds in trunk
Build libwebrtc unit tests executables
https://bugs.webkit.org/show_bug.cgi?id=177211
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-29
Reviewed by Alex Christensen.
.:
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
Source/ThirdParty/libwebrtc:
Adding support for a new target called unittests that will be several executables.
Each executable run unit tests dedicated to a part of libwebrtc.
Adding one target/executable per unit test suite.
Adding one composite target to build all unit test targets.
Adding a target to build a static libwebrtctest library.
The static libwebrtctest library is then linked to each unit test executable which is also linked to libwebrtc dylib.
Some unit tests require a default codec (VP8) that is disabled in libwebrtc.
This ends up making some tests crashing.
An additional work should follow to execute only the meaningful subset of tests.
- Configurations/libwebrtc-base.xcconfig: Added.
- Configurations/libwebrtc-test-static.xcconfig: Added.
- Configurations/rtc_pc_unittests.xcconfig: Added.
- Source/third_party/gflags/gen/posix/include/private/config.h:
- Source/webrtc/modules/audio_coding/neteq/tools/neteq_test.cc: Replacing FATAL by RTC_FATAL.
- Source/webrtc/sdk/objc/Framework/Classes/Common/helpers.mm: Removing UIKit dependency.
- Source/webrtc/test/gmock.h: Using googletest version instead of checking in testing folder.
- Source/webrtc/test/gtest.h: Ditto.
- Source/webrtc/test/rtp_file_reader.cc: Replacing FATAL by RTC_FATAL.
- libwebrtc.xcodeproj/project.pbxproj:
- 9:47 AM Changeset in webkit [222651] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r222625.
https://bugs.webkit.org/show_bug.cgi?id=177664
causes crashes on iOS (Requested by pizlo-mbp on #webkit).
Reverted changeset:
"Enable gigacage on iOS"
https://bugs.webkit.org/show_bug.cgi?id=177586
http://trac.webkit.org/changeset/222625
- 5:33 AM Changeset in webkit [222650] by
-
- 2 edits in trunk/Tools
Update my status.
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 3:22 AM Changeset in webkit [222649] by
-
- 12 edits in trunk/Source/WebCore
[GStreamer] Refactor media player to use MediaTime consistently
https://bugs.webkit.org/show_bug.cgi?id=174817
Reviewed by Xabier Rodriguez-Calvar.
Make consistent use of the MediaTime class in the GStreamer media
player implementations.
This patch is authored by Charlie Turner <cturner@igalia.com> plus
some minor modifications by Enrique: migration of m_cachedPosition,
usage of m_seekTime as MediaTime in the MSE player and more logging
using toString().
Covered by existing tests.
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
(WebCore::toGstUnsigned64Time): Scales MediaTime to the precision used
by GStreamer and returns a value compatible with GstClockTime.
(WebCore::toGstClockTime): Deleted.
- platform/graphics/gstreamer/GStreamerUtilities.h:
(WebCore::toGstClockTime): Inlined, now it takes MediaTime and converts
to GstClockTime.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Several changes to use MediaTime instead of float and to log MediaTime
values converting them toString().
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
(WebCore::MediaPlayerPrivateGStreamer::durationMediaTime const):
(WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
(WebCore::MediaPlayerPrivateGStreamer::seek): Uses MediaTime.
(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::buffered const):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::maxMediaTimeSeekable const):
(WebCore::MediaPlayerPrivateGStreamer::maxTimeLoaded const):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress const):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
(WebCore::MediaPlayerPrivateGStreamer::didEnd):
(WebCore::MediaPlayerPrivateGStreamer::durationChanged):
(WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable const): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Changed
seek(), playBackposition(), m_cachedPosition, m_durationAtEOS,
m_seekTime and m_timeOfOverlappingSeek to be of MediaTime type.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Prefer the methods based on MediaTime over those based on fload/double.
(WebCore::MediaPlayerPrivateGStreamerBase::maxTimeLoaded const):
- platform/graphics/gstreamer/mse/GStreamerMediaSample.cpp:
(WebCore::GStreamerMediaSample::offsetTimestampsBy): toGstClockTime()
now can handle MediaTime.
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
Several changes to use MediaTime instead of float and to log MediaTime
values converting them toString().
(WebCore::MediaPlayerPrivateGStreamerMSE::seek):
(WebCore::MediaPlayerPrivateGStreamerMSE::notifySeekNeedsDataForTime):
(WebCore::MediaPlayerPrivateGStreamerMSE::doSeek):
(WebCore::MediaPlayerPrivateGStreamerMSE::maybeFinishSeek):
(WebCore::MediaPlayerPrivateGStreamerMSE::isTimeBuffered const):
(WebCore::MediaPlayerPrivateGStreamerMSE::durationChanged):
(WebCore::MediaPlayerPrivateGStreamerMSE::currentMediaTime const):
(WebCore::MediaPlayerPrivateGStreamerMSE::maxTimeSeekable const):
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
seek() now takes a MediaTime argument.
- platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
(WebCore::PlaybackPipeline::enqueueSample): Use MediaTime values in
MediaSample.
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcQueryWithParent): Use MediaTime values in
durationMediaTime().
- 12:34 AM Changeset in webkit [222648] by
-
- 8 edits in trunk/Websites/perf.webkit.org
Update syncing script to be able to build binary for commit set with owned commits.
https://bugs.webkit.org/show_bug.cgi?id=177225
Reviewed by Ryosuke Niwa.
Added support for syncing script to be able to schedule builds to build binary for owned commits.
Introduces 'ifRepositorySet' and 'ownedRevisions' in 'buildProperties'.
'ifRepositorySet' will conditionaly set a build property if at least one of the repositories it specified requires build.
'ownedRevisions' specifies owned commits revision informations.
- public/v3/models/commit-set.js:
(CommitSet): Added '_ownerRepositoryToOwnedRepositoriesMap'.
(CommitSet.prototype.updateSingleton): Reset '_ownerRepositoryToOwnedRepositoriesMap'.
(CommitSet.prototype._updateFromObject): Only update '_repositoryToCommitOwnerMap' and '_ownerRepositoryToOwnedRepositoriesMap' when 'commitOwner' exists.
(CommitSet.prototype.ownerCommitForRepository): Returns a sorted list of top level repositories.
(CommitSet.prototype.ownedRepositoriesForOwnerRepository): Returns owned repositories given a owner repository.
(CustomCommitSet.prototype.ownerCommitForRepository): Returns a sorted list of top level repositories.
- public/v3/models/triggerable.js:
(prototype.accepts): It should only check against top-level repositories. Removed a deprecated 'FIXME'.
- server-tests/tools-sync-buildbot-integration-tests.js: Added unit test for building owned commits binary.
(createTriggerable): Added conditional 'ifRepositorySet' and 'ownedRevisions' in the repository groups.
- tools/js/buildbot-syncer.js:
(BuildbotSyncer.prototype._propertiesForBuildRequest):
Added logic to conditionaly create build property for 'ifRepositorySet'.
Added logic to create 'ownedRevisions' based on the owner repositories it specified.
(BuildbotSyncer._parseRepositoryGroup): Build property template should be able to handle 'ifRepositorySet' and 'ownedRevisions'.
- unit-tests/buildbot-syncer-tests.js: Added unit tests for 'ifRepositorySet' and 'ownedRevisions'.
- unit-tests/commit-set-tests.js: Added unit tests for 'topLevelRepositoriesSortedByNamePreferringOnesWithURL'.
- unit-tests/resources/mock-v3-models.js: Added a repository group contains 'ios', 'webkit' and 'ownerRepository'.
Sep 28, 2017:
- 10:37 PM Changeset in webkit [222647] by
-
- 5 edits9 adds1 delete in trunk/Source/WebCore
Re-write Settings generation in python for some reason
https://bugs.webkit.org/show_bug.cgi?id=177621
Patch by Sam Weinig <sam@webkit.org> on 2017-09-28
Reviewed by Tim Horton.
Re-writes and splits up generation of InternalSettingsGenerated.{h|cpp|idl}
and SettingsMacros.h in python in preparation for larger changes.
- DerivedSources.make:
- Scripts/GenerateSettings: Added.
- Scripts/GenerateSettings.py: Added.
- Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py: Added.
- Scripts/GenerateSettings/GenerateInternalSettingsIDLFile.py: Added.
- Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py: Added.
- Scripts/GenerateSettings/GenerateSettings.py: Added.
- Scripts/GenerateSettings/GenerateSettingsMacrosHeader.py: Added.
- Scripts/GenerateSettings/Settings.py: Added.
- Scripts/GenerateSettings/init.py: Added.
- WebCore.xcodeproj/project.pbxproj:
- page/make_settings.pl: Removed.
- 8:07 PM Changeset in webkit [222646] by
-
- 2 edits in trunk/Source/WebKit
Fix the macOS CMake build
- CMakeLists.txt:
- 7:42 PM Changeset in webkit [222645] by
-
- 1 edit1 copy in trunk/Websites/browserbench.org
Merge the latest version of Speedometer 2.0 to browserbench.org against at r222534.
Rubber-stamped by Saam Barati (a while ago).
- Speedometer2.0: Replaced with PerformanceTests/Speedometer.
- 7:35 PM Changeset in webkit [222644] by
-
- 2 edits in trunk/LayoutTests
[GTK] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=177635
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- 7:22 PM Changeset in webkit [222643] by
-
- 10 edits in trunk/LayoutTests
Clean up Long Press Selection Tests
https://bugs.webkit.org/show_bug.cgi?id=177636
Reviewed by Tim Horton.
Clean up tests to use better methods of finding selection locations so that
tests are more robust and less likely to be affected by unrelated changes.
- fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html:
- fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:
- fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html:
- fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html:
- fast/events/touch/ios/long-press-to-select-and-tap-to-clear-expected.txt:
- fast/events/touch/ios/long-press-to-select-and-tap-to-clear.html:
- fast/events/touch/ios/long-press-to-select-text-expected.txt:
- fast/events/touch/ios/long-press-to-select-text.html:
- fast/events/touch/ios/resources/basic-gestures.js:
(longPressAtPoint):
(tapAtPoint):
(touchAndDragFromPointToPoint):
(pressAtPoint): Deleted.
(dragFromPointToPoint): Deleted.
- 7:01 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 5:15 PM Changeset in webkit [222642] by
-
- 3 edits in trunk/Source/WebCore
Simplify PLATFORM ifdefs within Editor around writing selections
https://bugs.webkit.org/show_bug.cgi?id=177624
Reviewed by Alex Christensen.
No new tests. No change in behavior.
- editing/Editor.cpp:
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::copyImage):
- editing/Editor.h:
- 5:15 PM Changeset in webkit [222641] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r222639.
https://bugs.webkit.org/show_bug.cgi?id=177630
Breaks AppleWin build (Requested by dolmstead on #webkit).
Reverted changeset:
"[WinCairo][MiniBrowser] Add ca-bundle to display secure
pages."
https://bugs.webkit.org/show_bug.cgi?id=168486
http://trac.webkit.org/changeset/222639
- 5:13 PM Changeset in webkit [222640] by
-
- 7 edits10 adds in trunk
AX: [ATK] object:state-changed notifications missing for multiple ARIA attributes
https://bugs.webkit.org/show_bug.cgi?id=177542
Source/WebCore:
Add new notification types to AXObjectCache in order to support the notifications
needed, post the notifications to all platforms, emit the signals for ATK.
Reviewed by Chris Fleizach.
Tests: accessibility/gtk/aria-disabled-changed-notification.html
accessibility/gtk/aria-expanded-changed-notification.html
accessibility/gtk/aria-pressed-changed-notification.html
accessibility/gtk/aria-readonly-changed-notification.html
accessibility/gtk/aria-required-changed-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
Tools:
Add platform support for the notifications. Also add support for getting the
boolean argument indicating whether the state has been set or unset.
Reviewed by Chris Fleizach.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
LayoutTests:
Reviewed by Chris Fleizach.
- accessibility/gtk/aria-disabled-changed-notification-expected.txt: Added.
- accessibility/gtk/aria-disabled-changed-notification.html: Added.
- accessibility/gtk/aria-expanded-changed-notification-expected.txt: Added.
- accessibility/gtk/aria-expanded-changed-notification.html: Added.
- accessibility/gtk/aria-pressed-changed-notification-expected.txt: Added.
- accessibility/gtk/aria-pressed-changed-notification.html: Added.
- accessibility/gtk/aria-readonly-changed-notification-expected.txt: Added.
- accessibility/gtk/aria-readonly-changed-notification.html: Added.
- accessibility/gtk/aria-required-changed-notification-expected.txt: Added.
- accessibility/gtk/aria-required-changed-notification.html: Added.
- 4:52 PM Changeset in webkit [222639] by
-
- 2 edits in trunk/Tools
[WinCairo][MiniBrowser] Add ca-bundle to display secure pages.
Copy cacert.pem file into bundle directory.
https://bugs.webkit.org/show_bug.cgi?id=168486
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-09-28
Reviewed by Brent Fulgham.
- MiniBrowser/win/CMakeLists.txt:
- 4:32 PM Changeset in webkit [222638] by
-
- 4 edits in trunk
test262: Unexpected passes after r222617 and r222618.
https://bugs.webkit.org/show_bug.cgi?id=177622
<rdar://problem/34725960>
Reviewed by Saam Barati.
JSTests:
Update test262.yaml for tests that are now passing.
- test262.yaml:
Source/JavaScriptCore:
Now that these tests are marked as "normal", we will run them and discover a few
missing exception checks. This patch also adds those missing exception checks.
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingDateArgs):
- 4:08 PM Changeset in webkit [222637] by
-
- 11 edits in trunk/Source/WebCore
Remove TextRun::setCharactersLength() and TextRun::charactersLength()
https://bugs.webkit.org/show_bug.cgi?id=177620
Reviewed by Zalan Bujtas.
The purpose of TextRun::setCharactersLength() and TextRun::charactersLength() predate the
use of WidthIterator to safely iterate over characters in a TextRun that may contain
surrogate halves due to how it was created (without thought of surrogate pairs). Historically
TextRun::charactersLength() complemented TextRun::length() and represented the length of the
text to render ignoring and respecting truncation, respectively. We not longer need either
of these member functions with the advent of WidthIterator.
No functionality changed. So, no new tests.
- platform/graphics/ComplexTextController.cpp:
(WebCore::TextLayout::constructTextRun):
- platform/graphics/TextRun.cpp: Remove one unsigned field from ExpectedTextRunSize as we
reduced the size of TextRun with the removal of TextRun::m_charactersLength.
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun):
(WebCore::TextRun::charactersLength const): Deleted.
(WebCore::TextRun::setCharactersLength): Deleted.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::constructTextRun const):
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::constructTextRun): Deleted overload that took const RenderStyle& style
and StringView.
- rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache const):
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::width const):
- rendering/line/BreakingContext.h:
(WebCore::textWidth):
(WebCore::tryHyphenating):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::constructTextRun const):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::constructTextRun):
- rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::currentCharacterStartsSurrogatePair const): Use TextRun::length().
(WebCore::SVGTextMetricsBuilder::advance): Ditto.
- 4:04 PM Changeset in webkit [222636] by
-
- 2 edits in trunk/Source/WebInspectorUI
WebInspector: Uncaught Exception: TypeError: this._delegate.completionControllerCSSFunctionValuesNeeded is not a function.
https://bugs.webkit.org/show_bug.cgi?id=177619
Reviewed by Joseph Pecoraro.
- UserInterface/Controllers/CodeMirrorCompletionController.js:
(WI.CodeMirrorCompletionController.prototype._generateCSSCompletions):
Remove accidentaltypeofkeyword.
- 3:22 PM Changeset in webkit [222635] by
-
- 2 edits in trunk/LayoutTests
Skip failing preconnect tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177626
Unreviewed test gardening.
- platform/win/TestExpectations:
- 2:43 PM Changeset in webkit [222634] by
-
- 1 edit5 adds in trunk/Tools
check in AWS Lambda code used for WebKitArchiveSupport
https://bugs.webkit.org/show_bug.cgi?id=177614
Rubber-stamped by Alexey Proskuryakov.
- WebKitArchiveSupport/lambda: Added.
- WebKitArchiveSupport/lambda/delete-minified-s3-archive-from-dynamodb.py: Added.
(lambda_handler):
- WebKitArchiveSupport/lambda/delete-s3-archive-from-dynamodb.py: Added.
(lambda_handler):
- WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py: Added.
(lambda_handler):
- WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py: Added.
(lambda_handler):
- 2:31 PM Changeset in webkit [222633] by
-
- 5 edits in trunk
WeakPtrFactory should allow downcasting
https://bugs.webkit.org/show_bug.cgi?id=177389
<rdar://problem/34604174>
Reviewed by Geoffrey Garen.
Source/WTF:
In this patch, WeakPtrFactory is enhanced with the ability to create WeakPtrs
of its owner's sub classes and have them point to the same WeakReference.
- wtf/WeakPtr.h:
(WTF::WeakPtr::WeakPtr):
We cannot determine the base class of type T, thus no friends. It is made public
such that WeakPtrFactory with a base class type U can create a derived type T
WeakPtr.
(WTF::WeakPtrFactory::createWeakPtr const):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
(TestWebKitAPI::Base::foo):
(TestWebKitAPI::Base::createWeakPtr):
(TestWebKitAPI::Derived::foo):
(TestWebKitAPI::TEST):
- 2:13 PM Changeset in webkit [222632] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/storageAccess/request-storage-access-top-frame.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=177617
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 1:41 PM Changeset in webkit [222631] by
-
- 11 edits in trunk/Tools
Add debug flag to WebKitTestRunner to show where touches are being generated
https://bugs.webkit.org/show_bug.cgi?id=177583
Reviewed by Tim Horton and Wenson Hsieh.
Add a flag, and the ability to paint a dot where the HIDEventGenerator is creating fake touches to
send through UIKit. This will help in debugging touch tests, because it will be easier to see if
one is actually sending the touches at the locations that they expect. This will help differentiate between
problems in the locations of the touches, and other problems that can come up when writing tests.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- Scripts/webkitpy/port/driver.py:
(Driver.cmd_line):
- WebKitTestRunner/Options.cpp:
(WTR::Options::Options):
(WTR::handleOptionShowTouches):
(WTR::OptionsHandler::OptionsHandler):
- WebKitTestRunner/Options.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- WebKitTestRunner/TestController.h:
(WTR::TestController::shouldShowTouches const):
- WebKitTestRunner/TestOptions.h:
- WebKitTestRunner/ios/HIDEventGenerator.h:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[DebugTouchView pointInside:withEvent:]):
(-[HIDEventGenerator setShouldShowTouches:]):
(-[HIDEventGenerator initDebugViews]):
(-[HIDEventGenerator updateDebugUI:withPoint:isTouching:]):
(-[HIDEventGenerator _createIOHIDEventWithInfo:]):
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _updateTouchPoints:count:]):
(-[HIDEventGenerator touchDownAtPoints:touchCount:]):
(-[HIDEventGenerator liftUpAtPoints:touchCount:]):
(-[HIDEventGenerator moveToPoints:touchCount:duration:]):
(-[HIDEventGenerator markerEventReceived:]):
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest const):
- WebKitTestRunner/ios/mainIOS.mm:
(-[WebKitTestRunnerApp _runTestController]):
- 1:18 PM Changeset in webkit [222630] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove Error icon in error message for resources it looks poor
https://bugs.webkit.org/show_bug.cgi?id=177613
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-28
Reviewed by Matt Baker.
- UserInterface/Views/Main.css:
(.message-text-view.error::before): Deleted.
- 1:12 PM Changeset in webkit [222629] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177615
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 1:07 PM Changeset in webkit [222628] by
-
- 2 edits in tags/Safari-605.1.8/Source/WTF
Cherry-pick r222593. rdar://problem/34695516
- 1:03 PM Changeset in webkit [222627] by
-
- 10 edits1 delete in trunk
Remove constant() in favor of env()
https://bugs.webkit.org/show_bug.cgi?id=177581
<rdar://problem/34701321>
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, removing a feature.
- css/CSSValueKeywords.in:
- css/CSSVariableData.cpp:
(WebCore::CSSVariableData::checkVariablesForCyclesWithRange const):
(WebCore::CSSVariableData::resolveTokenRange const):
- css/parser/CSSVariableParser.cpp:
(WebCore::classifyBlock):
Source/WebInspectorUI:
- UserInterface/Models/CSSCompletions.js:
- UserInterface/Models/CSSKeywordCompletions.js:
(WI.CSSKeywordCompletions.forProperty):
(WI.CSSKeywordCompletions.forFunction):
LayoutTests:
- fast/css/variables/constants/invalid-constant-name-fallback-expected.html: Removed.
- fast/css/variables/constants/invalid-constant-name-fallback.html: Removed.
- fast/css/variables/constants/ios/safe-area-inset-set-expected.html: Removed.
- fast/css/variables/constants/ios/safe-area-inset-set.html: Removed.
- fast/css/variables/constants/safe-area-inset-cannot-override-expected.html: Removed.
- fast/css/variables/constants/safe-area-inset-cannot-override.html: Removed.
- fast/css/variables/constants/safe-area-inset-zero-expected.html: Removed.
- fast/css/variables/constants/safe-area-inset-zero.html: Removed.
- 1:01 PM Changeset in webkit [222626] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, fix a test name in TestExpectations.
- platform/mac-wk1/TestExpectations:
- 12:50 PM Changeset in webkit [222625] by
-
- 6 edits in trunk/Source
Enable gigacage on iOS
https://bugs.webkit.org/show_bug.cgi?id=177586
Reviewed by Michael Saboff.
Source/bmalloc:
This enables Gigacage on iOS using a much smaller cage size. It's not necessary for it to be so
small, but this is a good conservative starting point to start to exercise the code.
- bmalloc/Gigacage.h:
Source/JavaScriptCore:
The hardest part of enabling Gigacage on iOS is that it requires loading global variables whil
executing JS, so the LLInt needs to know how to load from global variables on all platforms that
have Gigacage. So, this teaches ARM64 how to load from global variables.
- offlineasm/arm64.rb:
- offlineasm/asm.rb:
- offlineasm/instructions.rb:
- 12:35 PM Changeset in webkit [222624] by
-
- 3 edits in trunk/Source/WebKit
Revise deployment target macros from r222620
Rubber-stamped by Wenson Hsieh.
- WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfDocumentDidLoad):
- 12:22 PM Changeset in webkit [222623] by
-
- 8 edits in trunk
Add ports 6679 and 6697 (IRC SSL) to port blacklist
https://bugs.webkit.org/show_bug.cgi?id=177544
<rdar://problem/34666525>
Reviewed by Alex Christensen.
Source/WebCore:
Test: security/block-test.html
- platform/URL.cpp:
(WebCore::portAllowed): Also block port 6679.
LayoutTests:
Update test and expectations for new port.
- security/block-test-expected.txt:
- security/block-test.html:
- platform/gtk/security/block-test-expected.txt:
- platform/mac/security/block-test-expected.txt:
- platform/wpe/security/block-test-expected.txt:
- 11:52 AM Changeset in webkit [222622] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, speculative Windows build fix after r222613.
- dom/StringCallback.idl:
- 11:50 AM Changeset in webkit [222621] by
-
- 3 edits in trunk/Source/WebCore
Small cleanup in RenderMenuList::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=177610
Reviewed by Dean Jackson.
No change in functionality.
- rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(RenderMenuList::didUpdateActiveOption):
- rendering/RenderMenuList.h:
- 11:40 AM Changeset in webkit [222620] by
-
- 3 edits in trunk/Source/WebKit
Request for PDF URL targets for specific pages, sections, etc.
https://bugs.webkit.org/show_bug.cgi?id=177582
<rdar://problem/5692679>
Patch by Aishwarya Nirmal <anirmal@apple.com> on 2017-09-28
Reviewed by Tim Horton.
This change sets the URL fragment for scroll anchoring in PDFs.
- WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::pdfDocumentDidLoad):
- 11:37 AM Changeset in webkit [222619] by
-
- 18 edits1 move in trunk/Source
[PAL] Move HysteresisActivity into PAL
https://bugs.webkit.org/show_bug.cgi?id=177516
Patch by Ross Kirsling <Ross Kirsling> on 2017-09-28
Reviewed by Alex Christensen.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- platform/UserActivity.cpp:
(WebCore::UserActivity::UserActivity):
(WebCore::UserActivity::hysteresisUpdated):
- platform/UserActivity.h:
- platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:
(WebCore::BackingStoreBackendCairoImpl::BackingStoreBackendCairoImpl):
- platform/graphics/cairo/BackingStoreBackendCairoImpl.h:
- platform/ios/WebSQLiteDatabaseTrackerClient.h:
- platform/ios/WebSQLiteDatabaseTrackerClient.mm:
(WebCore::WebSQLiteDatabaseTrackerClient::WebSQLiteDatabaseTrackerClient):
(WebCore::WebSQLiteDatabaseTrackerClient::hysteresisUpdated):
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
- pal/HysteresisActivity.h: Renamed from Source/WebCore/platform/HysteresisActivity.h.
Source/WebKit:
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::PendingFrameLoad):
- Shared/WebSQLiteDatabaseTracker.cpp:
(WebKit::WebSQLiteDatabaseTracker::WebSQLiteDatabaseTracker):
(WebKit::WebSQLiteDatabaseTracker::hysteresisUpdated):
- Shared/WebSQLiteDatabaseTracker.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_pageScrolledHysteresis):
(WebKit::m_userActivityHysteresis):
(WebKit::WebPage::updateUserActivity):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- WebProcess/WebProcess.h:
- 11:25 AM Changeset in webkit [222618] by
-
- 2 edits in trunk/Tools
[Re-landing] Turn on exception scope verification for JSC tests.
https://bugs.webkit.org/show_bug.cgi?id=162351
<rdar://problem/29563911>
Reviewed by Saam Barati.
Update: I'm re-landing this patch now that test262 exception check validation
failures have been fixed in r222617. testapi still has some validation failures,
but this patch does not affect testapi.
Added the option to --validateExceptionChecks=true option to BASE_OPTIONS in
run-jsc-stress-tests. This turns on exception scope verification on JSC test
runs (which currently does not include testapi).
Some stats on time to run JSC stress and mozilla tests:
- Release build w/o --validateExceptionChecks=true: real 16m22.544s, user 156m24.080s, sys 123m3.649s
- Debug build w/o --validateExceptionChecks=true: real 78m34.206s, user 1661m57.008s, sys 73m21.177s
- Debug build w/ --validateExceptionChecks=true: real 77m41.106s, user 1656m13.924s, sys 73m42.309s
- Debug build w/ --validateExceptionChecks=true --dumpSimulatedThrows=true: real 92m56.918s, user 2012m56.441s, sys 75m14.174s
The stats shows that (2) and (3) has effectively no time difference. Hence, the
cost of enabling --validateExceptionChecks=true is not significant.
It would be nice to enable --dumpSimulatedThrows=true as well, but (4) is about
21% slower than (3). To avoid making debug test runs a lot slower, we'll leave
--dumpSimulatedThrows=true off. We can manually add that when we see a regression
and need to debug the issue. Otherwise, we wont pay the price for it.
- Scripts/run-jsc-stress-tests:
- 11:09 AM Changeset in webkit [222617] by
-
- 14 edits in trunk/Source/JavaScriptCore
Add missing exception checks and book-keeping for exception check validation.
https://bugs.webkit.org/show_bug.cgi?id=177609
<rdar://problem/34717972>
Reviewed by Keith Miller.
This resolves exception check validation failures when running test262 tests and
a few other tests.
- API/APIUtils.h:
(handleExceptionIfNeeded):
- API/JSObjectRef.cpp:
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectSetPrototype):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
- API/JSTypedArray.cpp:
(JSObjectMakeTypedArray):
(JSObjectMakeTypedArrayWithBytesNoCopy):
(JSObjectMakeTypedArrayWithArrayBuffer):
(JSObjectMakeTypedArrayWithArrayBufferAndOffset):
(JSObjectMakeArrayBufferWithBytesNoCopy):
- API/JSValueRef.cpp:
(JSValueIsEqual):
(JSValueIsInstanceOfConstructor):
(JSValueCreateJSONString):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeProgram):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
- runtime/JSModuleEnvironment.cpp:
(JSC::JSModuleEnvironment::put):
- runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::toStringName):
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplitFast):
(JSC::stringProtoFuncSubstr):
- 10:56 AM Changeset in webkit [222616] by
-
- 4 edits in trunk/LayoutTests
[mac-wk1] Layout test webrtc/datachannel/bufferedAmountLowThreshold tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=177462
Patch by Youenn Fablet <youenn@apple.com> on 2017-09-28
Reviewed by Alex Christensen.
- webrtc/datachannel/bufferedAmountLowThreshold-default.html: Filling buffer until bufferedAmount is bug enough to trigger bufferedAmountLow event.
- webrtc/datachannel/bufferedAmountLowThreshold-expected.txt:
- webrtc/datachannel/bufferedAmountLowThreshold.html: Removing test that is inherently flaky on bots that are not fast enough
to continue filling the webrtc data channel buffer.
- 10:37 AM Changeset in webkit [222615] by
-
- 2 edits in trunk/Source/WTF
Sync SYSTEM_MALLOC implementation of Gigacage
https://bugs.webkit.org/show_bug.cgi?id=177569
Reviewed by Mark Lam.
- wtf/Gigacage.h:
(Gigacage::basePtr):
(Gigacage::basePtrs):
- 10:34 AM Changeset in webkit [222614] by
-
- 3 edits in trunk/Source/WebKitLegacy/mac
Build fix for High Sierra 32 bit Mac
https://bugs.webkit.org/show_bug.cgi?id=177551
<rdar://problem/34690283>
Reviewed by Alexey Proskuryakov.
Some assertions have been removed from the SDK. Replace these assertions with equivalent
WTF assert code. Since the files in this patch are using tabs, some style changes were
also made.
- Carbon/CarbonWindowAdapter.mm:
(+[CarbonWindowAdapter frameViewClassForStyleMask:]):
(-[CarbonWindowAdapter initWithContentRect:styleMask:backing:defer:]):
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
(-[CarbonWindowAdapter setViewsNeedDisplay:]):
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:]):
(-[CarbonWindowAdapter dealloc]):
(-[CarbonWindowAdapter windowRef]):
(-[CarbonWindowAdapter _hasWindowRef]):
(-[CarbonWindowAdapter _managesWindowRef]):
(-[CarbonWindowAdapter _removeWindowRef]):
(-[CarbonWindowAdapter _carbonWindowClass]):
(-[CarbonWindowAdapter reconcileToCarbonWindowBounds]):
(-[CarbonWindowAdapter sendSuperEvent:]):
(-[CarbonWindowAdapter relinquishFocus]):
(-[CarbonWindowAdapter _cancelKey:]):
(-[CarbonWindowAdapter _commonAwake]):
(-[CarbonWindowAdapter _destroyRealWindow:]):
(-[CarbonWindowAdapter _oldPlaceWindow:]):
(-[CarbonWindowAdapter _termWindowIfOwner]):
(-[CarbonWindowAdapter _windowMovedToRect:]):
(-[CarbonWindowAdapter constrainFrameRect:toScreen:]):
(-[CarbonWindowAdapter selectKeyViewFollowingView:]):
(-[CarbonWindowAdapter selectKeyViewPrecedingView:]):
(-[CarbonWindowAdapter canBecomeKeyWindow]):
(-[CarbonWindowAdapter canBecomeMainWindow]):
(-[CarbonWindowAdapter encodeWithCoder:]):
(-[CarbonWindowAdapter initWithCoder:]):
(-[CarbonWindowAdapter setContentView:]):
(-[CarbonWindowAdapter worksWhenModal]):
(-[CarbonWindowAdapter _setModalWindowLevel]):
(-[CarbonWindowAdapter _clearModalWindowLevel]):
(-[CarbonWindowAdapter carbonHICommandIDFromActionSelector:]):
(-[CarbonWindowAdapter sendCarbonProcessHICommandEvent:]):
(-[CarbonWindowAdapter sendCarbonUpdateHICommandStatusEvent:withMenuRef:andMenuItemIndex:]):
(-[CarbonWindowAdapter _handleRootBoundsChanged]):
(-[CarbonWindowAdapter _handleContentBoundsChanged]):
(-[CarbonWindowAdapter _handleCarbonEvent:callRef:]):
(NSCarbonWindowHandleEvent):
(-[CarbonWindowAdapter _reallyDoOrderWindow:relativeTo:findKey:forCounter:force:isModal:]):
(-[CarbonWindowAdapter _growBoxRect]):
- Carbon/HIWebView.mm:
(HIWebViewGetWebView):
(HIWebViewConstructor):
(HIWebViewDestructor):
(HIWebViewRegisterClass):
(GetBehaviors):
(Draw):
(HitTest):
(GetRegion):
(GetWindowRef):
(CreateNSEventAdoptingCGEvent):
(CopyEventCGEvent):
(CreateNSEventWithCarbonClickEvent):
(Click):
(CreateNSEventWithCarbonEvent):
(MouseUp):
(CreateNSEventWithCarbonMouseMoveEvent):
(MouseMoved):
(MouseDragged):
(MouseWheelMoved):
(ContextMenuClick):
(GetKind):
(BoundsChanged):
(OwningWindowChanged):
(WindowHandler):
(SyncFrame):
(SetFocusPart):
(AdvanceFocus):
(RelinquishFocus):
(ActiveStateChanged):
(ProcessCommand):
(UpdateCommandStatus):
(_NSSelectorForHICommand):
(HIWebViewEventHandler):
(StartUpdateObserver):
(StopUpdateObserver):
(UpdateObserver):
- 10:05 AM Changeset in webkit [222613] by
-
- 56 edits17 adds in trunk
Add support for <link rel=preconnect>
https://bugs.webkit.org/show_bug.cgi?id=177474
<rdar://problem/33141380>
Reviewed by Alex Christensen.
Source/WebCore:
Add support for <link rel=preconnect>:
It is currently only enabled for WK2 on MacOS High Sierra+
and iOS 11+.
Tests: fast/dom/HTMLLinkElement/preconnect-support.html
http/tests/preconnect/link-rel-preconnect-http.html
http/tests/preconnect/link-rel-preconnect-https.html
- bindings/js/JSDOMExceptionHandling.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackHeaderContent):
- bindings/scripts/IDLAttributes.json:
- dom/Document.cpp:
(WebCore::Document::addConsoleMessage):
(WebCore::Document::setConsoleMessageListener):
- dom/Document.h:
- dom/StringCallback.idl:
- html/DOMTokenList.cpp:
(WebCore::DOMTokenList::DOMTokenList):
(WebCore::DOMTokenList::supports):
- html/DOMTokenList.h:
(WebCore::DOMTokenList::DOMTokenList):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::relList):
- html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::sandbox):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::relList):
- html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
(WebCore::LinkRelAttribute::isSupported):
- html/LinkRelAttribute.h:
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLinksFromHeader):
(WebCore::LinkLoader::loadLink):
- loader/LoaderStrategy.h:
- page/Settings.in:
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::setConsoleMessageListener):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebCore/PAL:
Add new CFNetwork SPI for preconnecting.
- pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
Add support for <link rel=preconnect>:
Also add corresponding native private API.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::preconnectTo):
(WebKit::NetworkConnectionToWebProcess::didFinishPreconnection):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkDataTask.cpp:
(WebKit::NetworkDataTask::create):
- NetworkProcess/NetworkLoadParameters.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/PreconnectTask.cpp: Added.
(WebKit::PreconnectTask::PreconnectTask):
(WebKit::PreconnectTask::~PreconnectTask):
(WebKit::PreconnectTask::willPerformHTTPRedirection):
(WebKit::PreconnectTask::didReceiveChallenge):
(WebKit::PreconnectTask::didReceiveResponseNetworkSession):
(WebKit::PreconnectTask::didReceiveData):
(WebKit::PreconnectTask::didCompleteWithError):
(WebKit::PreconnectTask::didSendData):
(WebKit::PreconnectTask::wasBlocked):
(WebKit::PreconnectTask::cannotShowURL):
(WebKit::PreconnectTask::didFinish):
- NetworkProcess/PreconnectTask.h: Copied from Source/WebKit/NetworkProcess/NetworkLoadParameters.h.
- NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
- NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
- Shared/WebCoreArgumentCoders.h:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextPreconnectToServer):
- UIProcess/API/C/WKContextPrivate.h:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _preconnectToServer:]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::preconnectToServer):
- UIProcess/WebProcessPool.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didFinishPreconnection):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.messages.in:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::generateLoadIdentifier):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::preconnectTo):
(WebKit::WebLoaderStrategy::didFinishPreconnection):
- WebProcess/Network/WebLoaderStrategy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- config.h:
Source/WebKitLegacy:
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::preconnectTo):
- WebCoreSupport/WebResourceLoadScheduler.h:
LayoutTests:
- fast/dom/HTMLLinkElement/preconnect-support-expected.txt: Added.
- fast/dom/HTMLLinkElement/preconnect-support.html: Added.
- http/tests/preconnect/link-rel-preconnect-http-expected.txt: Added.
- http/tests/preconnect/link-rel-preconnect-http.html: Added.
- http/tests/preconnect/link-rel-preconnect-https-expected.txt: Added.
- http/tests/preconnect/link-rel-preconnect-https.html: Added.
Add layout test coverage.
- platform/mac-elcapitan-wk2/fast/dom/HTMLLinkElement/preconnect-support-expected.txt: Added.
- platform/mac-wk1/TestExpectations:
- platform/mac-wk1/fast/dom/HTMLLinkElement/preconnect-support-expected.txt: Added.
- platform/mac-wk2/TestExpectations:
Skip or land failure expectations for platforms where the feature is disabled.
- 9:31 AM Changeset in webkit [222612] by
-
- 4 edits in trunk/Source/WebCore
AX: Defer RenderListBox selectionChanged event until after layout is done.
https://bugs.webkit.org/show_bug.cgi?id=177589
<rdar://problem/34705785>
Reviewed by Chris Fleizach.
Defer AX update when the selection changed event is followed by a layout.
Covered by existing tests.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferSelectedChildrenChangedIfNeeded):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::deferSelectedChildrenChangedIfNeeded):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::selectionChanged):
- 8:53 AM Changeset in webkit [222611] by
-
- 2 edits in trunk/LayoutTests
Update TestExpectations for two http/tests/xmlhttprequest/response-* tests.
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 7:54 AM Changeset in webkit [222610] by
-
- 8 edits in trunk/Source
[Cairo] Remove the cairo_glyph_t complexity from GlyphBuffer
https://bugs.webkit.org/show_bug.cgi?id=177598
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Remove the decade-old use of cairo_glyph_t as the underlying type for
Glyph. The former spans 24 bytes in size, while the latte is just 2
bytes. The x and y coordinate attributes of cairo_glyph_t were only
used in FontCascade::drawGlyphs() implementation, where they were
overridden even if the same GlyphBuffer object was used here repeatedly.
FontCascade::drawGlyphs() now creates a new Vector<cairo_glyph_t> object
and fills it only with the glyph index and coordinates data for glyphs
that will actually be drawn. This will likely in the future be leveraged
to pack the necessary data and perform the drawing operations in
parallelized tasks. GlyphBuffer usages that before required USE(CAIRO)
special-casing can now be simplified.
This also removes the need for <cairo.h> header inclusion in the
GlyphBuffer.h header. This further removes Cairo header inclusion in
roughly 600 build targets.
No new tests -- no change in behavior.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::widthForSimpleText const):
- platform/graphics/GlyphBuffer.h:
(WebCore::GlyphBuffer::glyphAt const):
(WebCore::GlyphBuffer::add):
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::drawGlyphsToContext):
(WebCore::drawGlyphsShadow):
(WebCore::FontCascade::drawGlyphs):
- platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::DrawGlyphs::generateGlyphBuffer const):
Source/WebKit:
- Shared/API/c/cairo/WKImageCairo.cpp: Explicitly include the <cairo.h>
header here now that it's not included in GlyphBuffer.h.
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp: Ditto.
- 7:53 AM Changeset in webkit [222609] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r222606.
The debug assertion hit in these API tests should be fixed by
r222608.
Reverted changeset:
"REGRESSION(r222595): Assertion failure in
_preLoadedDataConformingToType"
https://bugs.webkit.org/show_bug.cgi?id=177599
http://trac.webkit.org/changeset/222606
- 7:47 AM Changeset in webkit [222608] by
-
- 2 edits in trunk/Source/WebCore
[iOS WK2] DataTransfer DataInteractionTests debug assert under -_preLoadedDataConformingToType:forItemProviderAtIndex:
https://bugs.webkit.org/show_bug.cgi?id=177594
Reviewed by Tim Horton.
Currently, some API tests added in r222595 currently hit debug assertions under -preloadedDataConformingToType:
forItemProviderAtIndex:. This is because the page may call DataTransfer.types, which now calls into
PlatformPasteboard::typesSafeForDOMToReadAndWrite(). This calls on the AbstractPasteboard (either the
UIPasteboard or WebItemProviderPasteboard, in the case of drag and drop) to fetch the custom WebKit pasteboard
data blob, if it exists. For WebItemProviderPasteboard, this ends up calling into -[WebItemProviderPasteboard
_preLoadedDataConformingToType:forItemProviderAtIndex:], which was previously only called after loading data off
of the item providers. There's an existing sanity check in this preloaded data helper to make sure that the
number of load results is equal to the number of item providers loaded from, but this sanity check only makes
sense *after* the drop has happened, not before, since we should only attempt to read dropped data after any
data at all has been dropped.
We need to check whether or not this custom data blob exists in PlatformPasteboard::typesSafeForDOMToReadAndWrite
to fetch the list of DOM-exposed types to propagate back to the page. So to fix this, we make the helper methods
for fetching dropped data (-dataForPasteboardType:inItemSet: and -valuesForPasteboardType:inItemSet:) fail
gracefully when invoked prior to drop, when PlatformPasteboard::typesSafeForDOMToReadAndWrite is invoked.
No new tests; fixes iOS drag and drop API tests that currently hit this debug assertion.
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard dataForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
- 4:20 AM Changeset in webkit [222607] by
-
- 1 edit in trunk/Source/JavaScriptCore/ChangeLog
Unreviewed fix of description in Changelog.
- 2:30 AM Changeset in webkit [222606] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r222595): Assertion failure in _preLoadedDataConformingToType
https://bugs.webkit.org/show_bug.cgi?id=177599
Temporarily remove the debug assertion to make API tests not crash since the relevant API tests are passing.
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard _preLoadedDataConformingToType:forItemProviderAtIndex:]):
