Timeline
Oct 25, 2017:
- 11:21 PM Changeset in webkit [224008] by
-
- 4 edits in trunk/Source/WebCore
Start moving Cocoa specific unified sources
https://bugs.webkit.org/show_bug.cgi?id=178850
Rubber-stamped by Tim Horton.
- PlatformMac.cmake:
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- 11:03 PM Changeset in webkit [224007] by
-
- 3 edits in trunk/Source/WebCore
[HarfBuzz] ComplexTextRun should initialize direction from the harfbuzz buffer
https://bugs.webkit.org/show_bug.cgi?id=178788
Reviewed by Michael Catanzaro.
Instead of using the TextRun direction. If the TextRun is ltr, but the harfbuzz buffer is rtl, the character
indexes will be swapped in m_coreTextIndices.
- platform/graphics/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create): Remove the ltr parameter.
- platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_isLTR using hb_buffer_get_direction().
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Do not pass ltr to ComplexTextRun::create().
- 10:23 PM Changeset in webkit [224006] by
-
- 4 edits in trunk/Source/WebCore
Move remaining platform independent sources to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178849
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 9:57 PM Changeset in webkit [224005] by
-
- 4 edits in trunk/Source/WebCore
Move plugins and rendering to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178848
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 9:27 PM Changeset in webkit [224004] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, add FEMorphology.cpp back to the regular build after r224003.
- WebCore.xcodeproj/project.pbxproj:
- 9:24 PM Changeset in webkit [224003] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Windows build fix.
- Sources.txt:
- 9:07 PM Changeset in webkit [224002] by
-
- 16 edits2 adds in trunk
Web Inspector: provide a way to enable/disable event listeners
https://bugs.webkit.org/show_bug.cgi?id=177451
<rdar://problem/34994925>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/DOM.json:
Add
setEventListenerDisabledcommand that enables/disables a specific event listener
during event dispatch. When a disabled event listener is fired, the listener's callback will
not be called.
Source/WebCore:
Test: inspector/dom/setEventListenerDisabled.html
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
Add InspectorInstrumentation call to isEventListenerDisabled. If true, the event listener's
callback will not be called.
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::setEventListenerDisabled):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
(WebCore::InspectorDOMAgent::willRemoveEventListener):
(WebCore::InspectorDOMAgent::isEventListenerDisabled):
Introduce a mapping ofEventListener*toInspectorEventListener, a struct for uniquely
identifying event listeners so they can be referenced from the frontend. We only add items
to this mapping whengetEventListenersForNodeis called, as that is when EventListener
data is sent to the frontend. This allows us to defer creating an Inspector "mirror" object
for each EventListener until it is needed. Items are removed whenever an event listener is
removed or when the document changes.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::isEventListenerDisabled):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willRemoveEventListenerImpl):
(WebCore::InspectorInstrumentation::isEventListenerDisabledImpl):
Pass additional parameters to InspectorDOMAgent so it can determine if the event listener
actually exists. If not, don't dispatch an event to the frontend as nothing will change.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Controllers/DOMTreeManager.js:
(WI.DOMTreeManager.prototype.setEventListenerDisabled):
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WI.DOMNodeDetailsSidebarPanel.prototype.attached):
(WI.DOMNodeDetailsSidebarPanel.prototype.detached):
(WI.DOMNodeDetailsSidebarPanel.prototype._eventListenersChanged):
(WI.DOMNodeDetailsSidebarPanel.prototype.addEventListeners): Deleted.
(WI.DOMNodeDetailsSidebarPanel.prototype.removeEventListeners): Deleted.
Listen forWI.DOMNode.Event.EventListenersChangedon all instances of WI.DOMNode, since we
will still want to refresh the event listeners section in the event that an event listener
is removed from a parent node.
- UserInterface/Views/EventListenerSectionGroup.js:
(WI.EventListenerSectionGroup):
(WI.EventListenerSectionGroup.prototype._eventText):
(WI.EventListenerSectionGroup.prototype._nodeTextOrLink):
(WI.EventListenerSectionGroup.prototype._createDisabledToggleElement):
(WI.EventListenerSectionGroup.prototype._createDisabledToggleElement.updateTitle):
- UserInterface/Views/EventListenerSectionGroup.css:
(.event-listener-section > .content input[type="checkbox"]):
- UserInterface/Views/DetailsSectionSimpleRow.js:
(WI.DetailsSectionSimpleRow.prototype.get label):
(WI.DetailsSectionSimpleRow.prototype.set label):
LayoutTests:
- inspector/dom/setEventListenerDisabled-expected.txt: Added.
- inspector/dom/setEventListenerDisabled.html: Added.
- 8:59 PM Changeset in webkit [224001] by
-
- 6 edits in trunk/Source/WebCore
Move Platform to unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178829
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- platform/Cursor.cpp:
- platform/sql/SQLiteDatabase.h:
- 7:57 PM Changeset in webkit [224000] by
-
- 4 edits in trunk/Source/WebCore
messageEvent.source can also be a ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=178839
Reviewed by Brady Eidson.
messageEvent.source can also be a ServiceWorker:
This enables calling postMessage() from a ServiceWorker via Bug 178794.
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::source const): Deleted.
- dom/MessageEvent.h:
- dom/MessageEvent.idl:
- 5:30 PM Changeset in webkit [223999] by
-
- 7 edits in trunk/Source/WebCore
Style::Scope::flushPendingUpdate() can replace the entire document in XSLTProcessor::createDocumentFromSource
https://bugs.webkit.org/show_bug.cgi?id=178715
<rdar://problem/35144665>
Reviewed by Brent Fulgham.
Apply XLS tranforms when a 0s timer fires or the document finishes parsing or loading whichever comes first
instead of in the middle of collecting a list of stylesheets.
- dom/Document.cpp:
(WebCore::Document::Document): Initialize the newly added timer.
(WebCore::Document::implicitClose): Apply any pending XSLT before we fire load events since some of the event
handlers may be expecting to see the document after XSLT had been applied.
(WebCore::Document::scheduleToApplyXSLTransforms): Added.
(WebCore::Document::applyPendingXSLTransformsNowIfScheduled): Added.
(WebCore::Document::applyPendingXSLTransformsTimerFired): Added. Moved the logic to apply XSL transforms from
Style::Scope::collectActiveStyleSheets, and merged applyXSLTransform into this function.
(WebCore::Document::applyXSLTransform): Deleted.
(WebCore::Document::finishedParsing): Apply XSLT right before updating the style. This is where used to apply
inline XSLT and it happens much earlier than implicitClose.
- dom/Document.h:
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet): Schedule XSLT in the document instead of flushing pending
stylesheets, which would have synchronously applied XSLT. We can't apply XSLT synchronously here because this
function can be called from a non-script-resilient call stack.
(WebCore::ProcessingInstruction::sheetLoaded): Ditto.
- style/StyleScope.cpp:
(WebCore::Style::Scope::collectXSLTransforms): Added.
(WebCore::Style::Scope::collectActiveStyleSheets): Removed the code to apply XSLT. Skip ProcessingInstructions
that applies XSLT. Also use RefPtr<StyleSheet> instead of a raw pointer to store StyleSheet.
- style/StyleScope.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::doEnd): Apply any pending XSLTs synchronously here as the comment suggests.
- 4:50 PM Changeset in webkit [223998] by
-
- 5 edits in trunk
Web Inspector: Canvas Tab: starting a second recording doesn't show red titlebar if the first recording was empty
https://bugs.webkit.org/show_bug.cgi?id=178805
<rdar://problem/35176303>
Reviewed by Brian Burg.
Source/WebCore:
No new tests, updated existing tests.
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
If the recording was stopped and had no data, reset the CallTracingActive flag to false.
LayoutTests:
- inspector/canvas/recording-2d-expected.txt:
- inspector/canvas/recording-2d.html:
- 4:49 PM Changeset in webkit [223997] by
-
- 16 edits in trunk
Web Inspector: replace TypeVerifier with subclasses of WI.Collection
https://bugs.webkit.org/show_bug.cgi?id=178045
<rdar://problem/35174307>
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Models/Collection.js:
(WI.Collection):
(WI.Collection.prototype.get displayName):
(WI.Collection.prototype.objectIsRequiredType):
(WI.Collection.prototype.add):
(WI.Collection.prototype.get typeVerifier): Deleted.
Instead of exposing the typeVerifier, we create a public predicate that returns whether the
given object matches the expected type of the Collection. Subclasses can override it to
limit the scope of the collection to a particular type.
- UserInterface/Models/CollectionTypes.js:
(WI.FrameCollection.prototype.get displayName):
(WI.FrameCollection.prototype.objectIsRequiredType):
(WI.FrameCollection): Deleted.
(WI.ScriptCollection.prototype.get displayName):
(WI.ScriptCollection.prototype.objectIsRequiredType):
(WI.ScriptCollection): Deleted.
(WI.CSSStyleSheetCollection.prototype.get displayName):
(WI.CSSStyleSheetCollection.prototype.objectIsRequiredType):
(WI.CSSStyleSheetCollection): Deleted.
(WI.CanvasCollection.prototype.get displayName):
(WI.CanvasCollection.prototype.objectIsRequiredType):
(WI.CanvasCollection): Deleted.
(WI.ShaderProgramCollection.prototype.get displayName):
(WI.ShaderProgramCollection.prototype.objectIsRequiredType):
(WI.ShaderProgramCollection): Deleted.
(WI.RecordingCollection.prototype.get displayName):
(WI.RecordingCollection.prototype.objectIsRequiredType):
(WI.RecordingCollection): Deleted.
- UserInterface/Models/ResourceCollection.js:
(WI.ResourceCollection):
(WI.ResourceCollection.prototype.get displayName):
(WI.ResourceCollection.prototype.objectIsRequiredType):
(WI.ResourceCollection.verifierForType): Deleted.
- UserInterface/Views/TreeOutlineGroup.js:
(WI.TreeOutlineGroup.prototype.objectIsRequiredType):
(WI.TreeOutlineGroup): Deleted.
Introduce additional subclasses of Collection for other model types. Modify existing
subclasses to removetypeVerifierand instead extendobjectIsRequiredType.
- UserInterface/Models/Canvas.js:
(WI.Canvas):
- UserInterface/Models/Frame.js:
(WI.Frame):
- UserInterface/Protocol/Target.js:
(WI.Target):
- UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel.prototype.treeElementForRepresentedObject):
(WI.ResourceSidebarPanel.prototype._addScript):
- UserInterface/Views/CollectionContentView.js:
(WI.CollectionContentView):
(WI.CollectionContentView.titleForCollection): Delete.
- UserInterface/Views/ResourceCollectionContentView.js:
(WI.ResourceCollectionContentView):
Require that subclasses of Collection overrideget displayNameif the CollectionContentView
is not provided with acontentPlaceholderText.
(WI.CollectionContentView.prototype.initialLayout):
We don't need to create and add ContentView for each item of the Collection, as this is
already done by attached().
(WI.CollectionContentView.prototype._showContentPlaceholder):
Remove the 250ms delay before showing the placeholder TitleView.
- UserInterface/Views/FolderizedTreeElement.js:
(WI.FolderizedTreeElement.prototype._settingsForRepresentedObject):
LayoutTests:
- inspector/unit-tests/collection-expected.txt:
- inspector/unit-tests/collection.html:
- 4:47 PM Changeset in webkit [223996] by
-
- 4 edits in trunk/Source/WebCore
Move html to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178709
Reviewed by Alex Christensen.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 4:39 PM Changeset in webkit [223995] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Delete temporally downloaded file when it cancelled
https://bugs.webkit.org/show_bug.cgi?id=134393
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-25
Reviewed by Alex Christensen.
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::didCancelTransfer):
(WebCore::CurlRequest::writeDataToDownloadFileIfEnabled):
(WebCore::CurlRequest::closeDownloadFile):
(WebCore::CurlRequest::cleanupDownloadFile):
- platform/network/curl/CurlRequest.h:
- 4:32 PM Changeset in webkit [223994] by
-
- 7 edits4 adds in trunk
Add service worker handle fetch support for all subresource requests
https://bugs.webkit.org/show_bug.cgi?id=178769
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-25
Reviewed by Chris Dumez.
Source/WebCore:
Test: http/tests/workers/service/image-fetch.https.html
Moving DocumentThreadableLoader logic to CachedResourceLoader to apply it for all resource loads.
Setting the selected service worker identifier for subresource only at the moment.
Testing is limited to images, future wpt tests should cover other subresource cases.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::prepareFetch):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setSelectedServiceWorkerIdentifierIfNeeded):
- loader/cache/CachedResourceRequest.h:
LayoutTests:
- http/tests/workers/service/image-fetch.https-expected.txt: Added.
- http/tests/workers/service/image-fetch.https.html: Added.
- http/tests/workers/service/resources/image-fetch-worker.js: Added.
(event.event.request.url.indexOf):
(event.event.request.url.endsWith):
- http/tests/workers/service/resources/image-fetch.js: Added.
(done):
(async.loadedImage):
(async.erroredImage):
(async.logStatus):
(async.test):
- 4:24 PM Changeset in webkit [223993] by
-
- 4 edits in trunk/Source/WebKit
Network process crash under WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge.
https://bugs.webkit.org/show_bug.cgi?id=160234
rdar://problem/30675510
Reviewed by Geoffrey Garen.
An exception is raised because we call the method rejectProtectionSpaceAndContinueWithChallenge on the CFNetwork
challenge sender, which does not implement this optional method. The methods on the authentication challenge
sender are deprecated when network session is used, so we should not call them in that case.
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
- Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):
- Shared/Authentication/soup/AuthenticationManagerSoup.cpp:
- 4:21 PM Changeset in webkit [223992] by
-
- 3 edits3 adds in trunk
Aliasing of text in CSS specs is blocky and ugly
https://bugs.webkit.org/show_bug.cgi?id=174946
Source/WebCore:
rdar://problem/33594542
Reviewed by Dean Jackson.
The PaintedContentRequest relating to subpixel-antialiased text was failing to be
satisfied if the text content in a composited layer was nested inside descendant
RenderLayers, because RenderLayer::isVisuallyNonEmpty() returned early. If this
function is passed a request, we can't return until we've satisfied the request
(which triggers the checking of descendant layers).
Test: compositing/contents-format/subpixel-antialiased-nested-layer.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects const):
LayoutTests:
Reviewed by Dean Jackson.
- compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt: Added.
- compositing/contents-format/subpixel-antialiased-nested-layer.html: Added.
- 4:13 PM Changeset in webkit [223991] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas Tab: clicking on a canvas card causes details sidebar to show and mess up card arrangement
https://bugs.webkit.org/show_bug.cgi?id=178803
<rdar://problem/35176082>
Reviewed by Brian Burg.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/CanvasDetailsSidebarPanel.css:
(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder):
(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder > .message):
- UserInterface/Views/CanvasDetailsSidebarPanel.js:
(WI.CanvasDetailsSidebarPanel):
(WI.CanvasDetailsSidebarPanel.prototype.inspect):
(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WI.CanvasDetailsSidebarPanel.prototype.layout):
- UserInterface/Views/RecordingNavigationSidebarPanel.js:
(WI.RecordingNavigationSidebarPanel.disallowInstanceForClass): Deleted.
- UserInterface/Views/RecordingStateDetailsSidebarPanel.js:
(WI.RecordingStateDetailsSidebarPanel.disallowInstanceForClass): Deleted.
- UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:
(WI.RecordingTraceDetailsSidebarPanel.disallowInstanceForClass): Deleted.
Drive-by: these sidebar panels are now only used by the Canvas tab, so we no longer need to
provide support for multiple instances of them.
- 4:04 PM CommitterTips edited by
- (diff)
- 3:27 PM Changeset in webkit [223990] by
-
- 4 edits2 adds in trunk/Source/WebKit
Move DNS resolution outside of NetworkRTCProvider
https://bugs.webkit.org/show_bug.cgi?id=178796
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-25
Reviewed by Geoffrey Garen.
Tested through manual testing on external STUN servers.
Moving NetworkRTCProvider::Resolver into NetworkRTCResolver.
Updating the implementation to use a completion handler.
- NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createResolver):
- NetworkProcess/webrtc/NetworkRTCProvider.h:
- NetworkProcess/webrtc/NetworkRTCResolver.cpp:
(WebKit::NetworkRTCResolver::NetworkRTCResolver):
(WebKit::NetworkRTCResolver::~NetworkRTCResolver):
(WebKit::NetworkRTCResolver::start):
(WebKit::NetworkRTCResolver::stop):
(WebKit::NetworkRTCResolver::completed):
(WebKit::NetworkRTCProvider::Resolver::~Resolver): Deleted.
(WebKit::NetworkRTCProvider::stop): Deleted.
(WebKit::NetworkRTCProvider::resolutionCompleted): Deleted.
- NetworkProcess/webrtc/NetworkRTCResolver.h:
- WebKit.xcodeproj/project.pbxproj:
- 3:15 PM Changeset in webkit [223989] by
-
- 8 edits1 delete in trunk
Unreviewed, rolling out r223691 and r223729.
https://bugs.webkit.org/show_bug.cgi?id=178834
Broke Speedometer 2 React-Redux-TodoMVC test case (Requested
by rniwa on #webkit).
Reverted changesets:
"Turn recursive tail calls into loops"
https://bugs.webkit.org/show_bug.cgi?id=176601
https://trac.webkit.org/changeset/223691
"REGRESSION(r223691): DFGByteCodeParser.cpp:1483:83: warning:
comparison is always false due to limited range of data type
[-Wtype-limits]"
https://bugs.webkit.org/show_bug.cgi?id=178543
https://trac.webkit.org/changeset/223729
- 3:15 PM Changeset in webkit [223988] by
-
- 12 edits1 add in trunk
[MediaStream] Clear cached gUM prompt state
https://bugs.webkit.org/show_bug.cgi?id=178754
<rdar://problem/32742356>
Reviewed by Youenn Fablet.
Source/WebKit:
- Shared/WebPreferences.yaml: Define new settings.
- Shared/WebPreferencesDefinitionsBase.h: New default values.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetInactiveMediaCaptureSteamRepromptIntervalInMinutes): New.
(WKPreferencesGetInactiveMediaCaptureSteamRepromptIntervalInMinutes): Ditto.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _inactiveMediaCaptureSteamRepromptIntervalInMinutes]): Ditto.
(-[WKPreferences _setInactiveMediaCaptureSteamRepromptIntervalInMinutes:]): Ditto.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::UserMediaPermissionRequestManagerProxy): Initialize
the timer.
(WebKit::UserMediaPermissionRequestManagerProxy::createRequest): Remove unneeded namespace.
(WebKit::toWebCore): Remove unneeded breaks.
(WebKit::UserMediaPermissionRequestManagerProxy::searchForGrantedRequest const): Remove unneeded namespace.
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs const): Ditto.
(WebKit::UserMediaPermissionRequestManagerProxy::captureStateChanged): Set the watchdog timer
to the correct interval based on capture state.
(WebKit::UserMediaPermissionRequestManagerProxy::watchdogTimerFired): Clear cached state.
- UIProcess/UserMediaPermissionRequestManagerProxy.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test
- TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm: Added.
(-[GetUserMediaRepromptUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(-[GetUserMediaRepromptUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit/getUserMedia.html:
- 3:06 PM Changeset in webkit [223987] by
-
- 2 edits in trunk/Tools
Add committer status for Ross Kirsling
https://bugs.webkit.org/show_bug.cgi?id=178832
Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 2:47 PM Changeset in webkit [223986] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, add missing copyright header to ServiceWorkerClientType.idl.
- workers/service/ServiceWorkerClientType.idl:
- 2:36 PM Changeset in webkit [223985] by
-
- 8 edits1 copy in trunk/Source/WebCore
Make toJS() do the right thing for ServiceWorkerClient
https://bugs.webkit.org/show_bug.cgi?id=178816
Reviewed by Youenn Fablet.
Make toJS() do the right thing for ServiceWorkerClient. In particular,
it needs to construct a JSServiceWorkerWindowClient wrapper if the
implementation object is a ServiceWorkerWindowClient.
Also, ServiceWorkerClient does not need to be an ActiveDOMObject as
it does not have any long-running tasks. Make it a ContextDestructionObject
instead for now.
- CMakeLists.txt:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::postMessage):
- workers/service/ServiceWorkerClient.h:
(WebCore::ServiceWorkerClient::create):
- workers/service/ServiceWorkerClient.idl:
- workers/service/ServiceWorkerClientType.h: Copied from Source/WebCore/workers/service/ServiceWorkerClient.idl.
- workers/service/ServiceWorkerClientType.idl: Added.
- workers/service/ServiceWorkerClients.h:
- workers/service/ServiceWorkerClients.idl:
- 2:32 PM Changeset in webkit [223984] by
-
- 16 edits1 move3 adds in trunk
When navigating back to a page, compositing layers may not use accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=178749
rdar://problem/35158946
Reviewed by Dean Jackson.
Source/WebCore:
There were two issues with setting GraphicsLayerCA's "acceleratesDrawing" state which
occurred on back navigation, related to the ordering of style recalcs and layout.
First, at style recalc time, we created a RenderLayerCompositor but hadn't yet called
its cacheAcceleratedCompositingFlags(), so any layers created during style update
didn't get accelerated drawing. Fix by making cacheAcceleratedCompositingFlags() internal
to RenderLayerCompositor and calling it from willRecalcStyle() and updateCompositingLayers().
Secondly, GraphicsLayerCA::commitLayerChangesBeforeSublayers() needs to updateAcceleratesDrawing()
before updating tiles, so that new tiles fetch the right acceleratesDrawing state from
the TileController.
Test: compositing/accelerated-layers-after-back.html
- page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterLayout):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
- rendering/RenderLayerCompositor.h:
Source/WebKit:
Avoid assertions when a test enables accelerated drawing (which we can't support
in the iOS simulator).
- Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::ensureBackingStore):
Tools:
Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
and use it to set the state of the web view.
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/TestOptions.mm:
(TestOptions::TestOptions):
- DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
LayoutTests:
Moved iframes/resources/page-cache-helper.html up to compositing/resources/go-back.html.
- compositing/accelerated-layers-after-back-expected.txt: Added.
- compositing/accelerated-layers-after-back.html: Added.
- compositing/iframes/page-cache-layer-tree.html:
- compositing/page-cache-back-crash.html:
- compositing/resources/go-back.html: Renamed from LayoutTests/compositing/iframes/resources/page-cache-helper.html.
- platform/ios/compositing/accelerated-layers-after-back-expected.txt: Added.
- 2:30 PM Changeset in webkit [223983] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Display fetch() initiated loads as "fetch" instead of "xhr" in the Network Tab
https://bugs.webkit.org/show_bug.cgi?id=178826
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-25
Reviewed by Youenn Fablet.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.shortDisplayNameForResourceType):
Fetch and XHR loads are still grouped under the succinct "XHR" filter, but
at least display the better type name in the "Type" column of the table.
- 2:19 PM Changeset in webkit [223982] by
-
- 5 edits in trunk/LayoutTests
LayoutTest http/tests/loading/basic-credentials-sent-automatically.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=159427
Reviewed by Youenn Fablet.
Use setTimeout to make load delegate callback printing more deterministic.
The important part is that the credentials are printed, and they still are.
- http/tests/loading/basic-credentials-sent-automatically-expected.txt:
- http/tests/loading/basic-credentials-sent-automatically.html:
- platform/mac/TestExpectations:
- platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
- 2:17 PM Changeset in webkit [223981] by
-
- 35 edits2 copies5 adds in trunk
Enable ServiceWorker to fetch resources
https://bugs.webkit.org/show_bug.cgi?id=178673
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-25
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/workers/service/service-worker-fetch.html
Allow reusing of EmptyFrameLoaderClient for network loading in WebKit Service Worker environment.
Allow overriding the creation of a document loader, pageID, frameID and sessionID getters.
Allow the possibility to create synthetic documents for all ports.
Beefing up ServiceWorkerThreadProxy as it owns a Document and a Page that do nothing but server
the purpose of loading resources for a service worker thread.
- WebCore.xcodeproj/project.pbxproj:
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::setResponse):
- loader/EmptyClients.cpp:
(WebCore::EmptyFrameLoaderClient::sessionID const):
(WebCore::EmptyFrameLoaderClient::createNetworkingContext):
(WebCore::createEmptyFrameNetworkingContext):
- loader/EmptyClients.h:
- loader/EmptyFrameLoaderClient.h: Added.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::initForSynthesizedDocument):
- loader/FrameLoader.h:
- loader/FrameLoaderClient.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::m_workerObjectProxy):
- workers/service/context/ServiceWorkerThread.h:
- workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::create):
(WebCore::createPageForServiceWorker):
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::postTaskToLoader):
- workers/service/context/ServiceWorkerThreadProxy.h:
Test: http/tests/workers/service/service-worker-fetch.html
Source/WebKit:
ServiceWorkerContextManager makes use of the new ServiceWorkerThreadProxy.
It creates the necessary environment for the thread to make use of network loads, web sockets and cache storage.
Fetch is functional with these changes.
ServiceWorkerProcessProxy is introduced as a UIProcess proxy to the service worker process.
This process proxy is responsible to give the pageID used by all service worker thread instances for network loads.
ServiceWorkerContextManager is responsible to give a unique frameID for all service worker threads.
This is necessary as these two ids are currently needed for any network load.
ServiceWorkerThreadProxy creates its own FrameLoaderClient which is now used to get pageID, frameID and sessionID.
- UIProcess/ServiceWorkerProcessProxy.cpp: Added.
(WebKit::ServiceWorkerProcessProxy::ServiceWorkerProcessProxy):
(WebKit::m_serviceWorkerPageID):
(WebKit::ServiceWorkerProcessProxy::~ServiceWorkerProcessProxy):
(WebKit::ServiceWorkerProcessProxy::start):
- UIProcess/ServiceWorkerProcessProxy.h: Added.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getWorkerContextProcessConnection):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
(WebKit::WebProcessPool::createWebPage):
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::generatePageID):
- UIProcess/WebProcessProxy.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::startPingLoad):
- WebProcess/Network/WebLoaderStrategy.h:
- WebProcess/Storage/ServiceWorkerContextManager.cpp:
(WebKit::ServiceWorkerContextManager::ServiceWorkerContextManager):
(WebKit::ServiceWorkerContextManager::startServiceWorker):
(WebKit::ServiceWorkerContextManager::startFetch):
- WebProcess/Storage/ServiceWorkerContextManager.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::pageID const):
(WebKit::WebFrameLoaderClient::frameID const):
(WebKit::WebFrameLoaderClient::sessionID const):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getWorkerContextConnection):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Source/WebKitLegacy/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::pageID const):
(WebFrameLoaderClient::frameID const):
(WebFrameLoaderClient::sessionID const):
Added implementation to the new getters.
They are noop in the context of WK1.
Source/WebKitLegacy/win:
Added implementation to the new getters.
They are noop in the context of WK1.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::pageID const):
(WebFrameLoaderClient::frameID const):
(WebFrameLoaderClient::sessionID const):
- WebCoreSupport/WebFrameLoaderClient.h:
LayoutTests:
- http/tests/workers/service/resources/service-worker-fetch-worker.js: Added.
- http/tests/workers/service/resources/service-worker-fetch.js: Added.
- http/tests/workers/service/service-worker-fetch-expected.txt: Added.
- http/tests/workers/service/service-worker-fetch.html: Added.
- 2:12 PM Changeset in webkit [223980] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r223937): Use of -fobjc-weak causes build failures with older compilers
https://bugs.webkit.org/show_bug.cgi?id=178825
Reviewed by Mark Lam.
Enable ARC for ARM64_32. This eliminate the need for setting CLANG_ENABLE_OBJC_WEAK.
- Configurations/ToolExecutable.xcconfig:
- 2:12 PM Changeset in webkit [223979] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas Tab: selected canvas card loses selection outline style while recording
https://bugs.webkit.org/show_bug.cgi?id=178814
<rdar://problem/35177317>
Reviewed by Brian Burg.
- UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview .content-view.canvas):
(.content-view.canvas-overview .content-view.canvas > :matches(header, .preview, footer)):
(.content-view.canvas-overview .content-view.canvas.selected > :matches(.preview, footer),):
(.content-view.canvas-overview .content-view.canvas > header):
(.content-view.canvas-overview .content-view.canvas.is-recording > header):
(.content-view.canvas-overview .content-view.canvas > .preview):
(.content-view.canvas-overview .content-view.canvas > footer):
(.content-view.canvas-overview .content-view.canvas.selected:not(.is-recording)): Deleted.
Instead of applying the border to the entire element, apply parts of the border to each of
its children so that we can choose what colors to use for each part.
- 2:09 PM Changeset in webkit [223978] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: [PARITY] Styles Redesign: Add color gradient, bezier curve, and spring inline widgets
https://bugs.webkit.org/show_bug.cgi?id=178404
<rdar://problem/35035992>
Reviewed by Devin Rousso.
Add inline widgets for the following CSS values:
- Gradients, e.g.
background-image: linear-gradient(yellow, orange) - Bezier curves, e.g.
transition-timing-function: cubic-bezier(0.68, -0.55, 0.265, 1.55) - Spring functions, e.g.
transition-timing-function: spring(1, 2, 2, 4)
- UserInterface/Models/Color.js:
(WI.Color.prototype.toString):
Don't throw. The are never try/catch blocks on the callsites.
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):
(WI.SpreadsheetStyleProperty.prototype._addGradientTokens):
(WI.SpreadsheetStyleProperty.prototype._addColorTokens):
(WI.SpreadsheetStyleProperty.prototype._addTimingFunctionTokens):
- 1:44 PM Changeset in webkit [223977] by
-
- 7 edits in trunk/Source
Versioning.
- 1:18 PM Changeset in webkit [223976] by
-
- 1 copy in tags/Safari-605.1.12
Tag Safari-605.1.12.
- 12:48 PM Changeset in webkit [223975] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Fix a bug in syncing script that test/build syncer is never set.
https://bugs.webkit.org/show_bug.cgi?id=178772
Reviewed by Ryosuke Niwa.
Neither 'buildSyncer' nor 'testSyncer' is ever set.
Added a unit test to cover this case.
- server-tests/tools-sync-buildbot-integration-tests.js:
(createTriggerable): Refactor it to allow customized name.
- tools/js/buildbot-triggerable.js:
(BuildbotTriggerable.prototype._pullBuildbotOnAllSyncers): Update syncer info accordingly.
(BuildbotTriggerable._testGroupMapForBuildRequests): Initialize build and test syncer to null.
- 12:42 PM Changeset in webkit [223974] by
-
- 6 edits6 adds in trunk
UNPACK_FLIP_Y is broken for MSE-backed videos
https://bugs.webkit.org/show_bug.cgi?id=178774
Reviewed by Dean Jackson.
Source/WebCore:
The global GLSL variable gl_Position can apparently only be set once, and any modifications
made after that initial set are ignored. So rather than implement flipping by changing
gl_Position.y, flip the texture coordinates instead.
Drive-by fix: some of the constants used in VideoTextureCopierCV are not defined on older
macOS versions, so make them optional.
Tests: fast/canvas/webgl/texImage2D-mse-flipY-false.html
fast/canvas/webgl/texImage2D-mse-flipY-true.html
- platform/graphics/cv/VideoTextureCopierCV.cpp:
(WebCore::transferFunctionFromString):
(WebCore::VideoTextureCopierCV::initializeUVContextObjects):
- platform/cocoa/CoreVideoSoftLink.cpp:
- platform/cocoa/CoreVideoSoftLink.h:
LayoutTests:
- fast/canvas/webgl/resources/orientation-flipped-fragmented.mp4: Added.
- fast/canvas/webgl/resources/orientation-normal-fragmented.mp4: Added.
- fast/canvas/webgl/texImage2D-mse-flipY-false-expected.txt: Added.
- fast/canvas/webgl/texImage2D-mse-flipY-false.html: Added.
- fast/canvas/webgl/texImage2D-mse-flipY-true-expected.txt: Added.
- fast/canvas/webgl/texImage2D-mse-flipY-true.html: Added.
- platform/ios/TestExpectations:
- 12:36 PM Changeset in webkit [223973] by
-
- 10 edits1 copy1 add in trunk/Source/WebCore
[Service Worker] Add stubs for serviceWorkerClient.type
https://bugs.webkit.org/show_bug.cgi?id=178812
Reviewed by Youenn Fablet.
Add stubs for serviceWorkerClient.type to match the latest specification:
- CMakeLists.txt:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- workers/service/ServiceWorkerClient.cpp:
(WebCore::ServiceWorkerClient::type const):
- workers/service/ServiceWorkerClient.h:
- workers/service/ServiceWorkerClient.idl:
- workers/service/ServiceWorkerClientType.h: Added.
- workers/service/ServiceWorkerClientType.idl: Added.
- workers/service/ServiceWorkerClients.h:
- workers/service/ServiceWorkerClients.idl:
- 12:27 PM Changeset in webkit [223972] by
-
- 4 edits in trunk/Source/WebCore
Move mathml and page to unified souces
https://bugs.webkit.org/show_bug.cgi?id=178770
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 12:06 PM Changeset in webkit [223971] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix implicit cast of enum, which seems to break the windows build of unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178822
Reviewed by Saam Barati.
- bytecode/DFGExitProfile.h:
(JSC::DFG::FrequentExitSite::hash const):
- 12:02 PM Changeset in webkit [223970] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: Newly added invalid property isn't immediately shown as invalid
https://bugs.webkit.org/show_bug.cgi?id=178488
Reviewed by Brian Burg.
- UserInterface/Models/CSSStyleDeclaration.js:
(WI.CSSStyleDeclaration.prototype.newBlankProperty):
Call this.update to update _properties, _allProperties, _visibleProperties, and _allVisibleProperties.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled)):
(.spreadsheet-style-declaration-editor .property.invalid-name:not(.disabled)):
(.spreadsheet-style-declaration-editor .property.invalid-value:not(.disabled) .value):
When the property name is valid, but the value isn't, display red line-through only for the value.
This is how it works in the old styles sidebar as well.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
(WI.SpreadsheetCSSStyleDeclarationEditor):
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.updateClassNames):
(WI.SpreadsheetStyleProperty.prototype._update):
Introduce updateClassNames method. Unlike _update, it doesn't change text selection or focus and
can be safely called on a property while it's being edited.
- 12:01 PM Changeset in webkit [223969] by
-
- 5 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r223960. rdar://problem/35178892
- 11:54 AM Changeset in webkit [223968] by
-
- 3 edits in trunk/Source/WebCore
fast/images/animated-gif-paint-after-animation.html flaky crash
https://bugs.webkit.org/show_bug.cgi?id=178510
Patch by Fujii Hironori <Fujii Hironori> on 2017-10-25
Reviewed by Said Abou-Hallawa.
ScalableImageDecoder was accessed from the main thread and the
image decoding thread without a mutex.
No new tests because there is no behavior change.
- platform/image-decoders/ScalableImageDecoder.h: Add m_mutex. Lock the mutex in setData.
- platform/image-decoders/ScalableImageDecoder.cpp:
(WebCore::ScalableImageDecoder::frameIsCompleteAtIndex const): Lock the mutex.
(WebCore::ScalableImageDecoder::frameHasAlphaAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::frameBytesAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::frameDurationAtIndex const): Ditto.
(WebCore::ScalableImageDecoder::createFrameImageAtIndex): Ditto.
- 11:42 AM Changeset in webkit [223967] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/loading/basic-credentials-sent-automatically.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=159427
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 11:38 AM Changeset in webkit [223966] by
-
- 4 edits2 copies2 adds in trunk/Source/WebKit
[WinCairo] Add WebKit platform files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=178000
Patch by Yousuke Kimoto <yousuke.kimoto@sony.com> on 2017-10-25
Reviewed by Alex Christensen.
- Platform/Module.h:
- Platform/SharedMemory.h:
(WebKit::SharedMemory::handle const):
- Platform/win/LoggingWin.cpp: Added. It is based on Source/WebCore/platform/win/LoggingWin.cpp
(WebKit::logLevelString):
- Platform/win/ModuleWin.cpp: Added.
(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer const):
- Platform/win/SharedMemoryWin.cpp: Added.
(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull const):
(WebKit::SharedMemory::Handle::encode const):
(WebKit::SharedMemory::Handle::clear):
(WebKit::getDuplicatedHandle):
(WebKit::SharedMemory::Handle::decode):
(WebKit::protectAttribute):
(WebKit::SharedMemory::allocate):
(WebKit::SharedMemory::create):
(WebKit::accessRights):
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::adopt):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::SharedMemory::createHandle):
(WebKit::SharedMemory::systemPageSize):
- PlatformWin.cmake:
- 11:32 AM Changeset in webkit [223965] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r222945.
https://bugs.webkit.org/show_bug.cgi?id=178818
"It made WasmBench crash" (Requested by saamyjoon on #webkit).
Reverted changeset:
"bmalloc mutex should be adaptive"
https://bugs.webkit.org/show_bug.cgi?id=177839
https://trac.webkit.org/changeset/222945
- 11:28 AM Changeset in webkit [223964] by
-
- 20 edits3 adds in trunk
Add support for unregistering a service worker
https://bugs.webkit.org/show_bug.cgi?id=178735
Reviewed by Brady Eidson.
Source/WebCore:
Add support for unregistering a service worker:
Test: http/tests/workers/service/basic-unregister.https.html
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::resolvedWithUnregistrationResult):
- workers/service/ServiceWorkerJob.h:
- workers/service/ServiceWorkerJobClient.h:
- workers/service/ServiceWorkerJobData.h:
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):
- workers/service/ServiceWorkerJobType.h:
- workers/service/ServiceWorkerRegistration.cpp:
(WebCore::containerForScriptExecutionContext):
(WebCore::ServiceWorkerRegistration::unregister):
- workers/service/server/SWClientConnection.cpp:
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
- workers/service/server/SWClientConnection.h:
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::resolveRegistationJob):
(WebCore::SWServer::resolveUnregistrationJob):
- workers/service/server/SWServer.h:
- workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::scriptContextStarted):
(WebCore::SWServerRegistration::startNextJob):
(WebCore::SWServerRegistration::runUnregisterJob):
(WebCore::SWServerRegistration::resolveWithRegistrationOnMainThread):
(WebCore::SWServerRegistration::resolveWithUnregistrationResultOnMainThread):
(WebCore::SWServerRegistration::resolveCurrentRegistrationJob):
(WebCore::SWServerRegistration::resolveCurrentUnregistrationJob):
- workers/service/server/SWServerRegistration.h:
Source/WebKit:
Add support for unregistering a service worker:
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- WebProcess/Storage/WebSWClientConnection.messages.in:
LayoutTests:
Add layout test coverage.
- http/tests/workers/service/basic-unregister.https-expected.txt: Added.
- http/tests/workers/service/basic-unregister.https.html: Added.
- http/tests/workers/service/resources/basic-unregister.js: Added.
- 11:21 AM Changeset in webkit [223963] by
-
- 3 edits in trunk/Source/WebCore
MediaSessionManager* needs to catch Obj-C exceptions
https://bugs.webkit.org/show_bug.cgi?id=178813
Reviewed by Tim Horton.
Wrap all calls out to Objective-C with BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS):
(WebCore::MediaSessionManageriOS::hasWirelessTargetsAvailable):
(WebCore::MediaSessionManageriOS::configureWireLessTargetMonitoring):
(WebCore::MediaSessionManageriOS::updateNowPlayingInfo):
(WebCore::MediaSessionManageriOS::externalOutputDeviceAvailableDidChange):
(-[WebMediaSessionHelper allocateVolumeView]):
(-[WebMediaSessionHelper initWithCallback:]):
- platform/audio/mac/MediaSessionManagerMac.mm:
(WebCore::MediaSessionManagerMac::updateNowPlayingInfo):
- 11:00 AM Changeset in webkit [223962] by
-
- 11 edits in trunk
[Payment Request] Implement the "user aborts the payment request" algorithm
https://bugs.webkit.org/show_bug.cgi?id=178810
Reviewed by Tim Horton.
Source/WebCore:
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::didCancelPaymentSession):
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::cancel):
- Modules/paymentrequest/PaymentRequest.h:
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::cancelPayment):
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.idl:
LayoutTests:
- http/tests/paymentrequest/payment-request-show-method.https-expected.txt:
- http/tests/paymentrequest/payment-request-show-method.https.html:
- 10:42 AM Changeset in webkit [223961] by
-
- 2 edits in trunk/JSTests
Mark test262.yaml/test262/test/language/statements/try/tco-catch.js as passing.
https://bugs.webkit.org/show_bug.cgi?id=178592
Unreviewed test gardening.
- test262.yaml:
- 10:39 AM Changeset in webkit [223960] by
-
- 5 edits in trunk/Source/WebCore
Autoplay muted videos still stop playback of other streaming apps in the background
https://bugs.webkit.org/show_bug.cgi?id=177920
Reviewed by Eric Carlson.
When creating a new <video> or <audio> element, the global AudioSession can sometimes have
its sessionCategory() set to "MediaPlayback", even if the element does not yet have a
source. This is because the constructor for the MediaElementSession is called before
m_isPlayingToWirelessTarget is initialized, and so in the MediaElementSession constructor,
the media element's m_isPlayingToWirelessTarget ivar is sometimes (uninitialized) true.
We could move the MediaElementSession ivar to the very end of the header, so it's
initialized last, but that still leaves the possibility of the MediaElementSession et. all
calling into the HTMLMediaElement before it's subclass's constructors have a chance to
initialize their own ivars (much less their vtables). So instead, we'll create and set the
MediaElementSession in a finishInitialization() method called from the HTMLVideoElement and
HTMLAudioElement's create() factory methods.
- html/HTMLAudioElement.cpp:
(WebCore::HTMLAudioElement::create):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::finishInitialization):
- html/HTMLMediaElement.h:
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::create):
- 10:27 AM Changeset in webkit [223959] by
-
- 3 edits in trunk/LayoutTests
Attempt to fix flaky test fast/writing-mode/english-bt-text-with-spelling-marker.html following r223938
(https://bugs.webkit.org/show_bug.cgi?id=178759)
Call internals.updateEditorUINowIfScheduled() to force the editor UI to update and add spelling markers.
- fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
- fast/writing-mode/english-bt-text-with-spelling-marker.html:
- 10:19 AM Changeset in webkit [223958] by
-
- 8 edits2 copies in trunk/Source/WebKit
Make SharedStringHashTable less error prone
https://bugs.webkit.org/show_bug.cgi?id=178764
Reviewed by Youenn Fablet.
SharedStringHashTable is backed by SharedMemory and this SharedMemory
may be readonly (and is when used in the WebContent process). As a result,
some of the operations on SharedStringHashTable that write to this shared
memory will crash if called and the SharedMemory is readonly.
To make this less error prone, introduce a new SharedStringHashTableReadOnly
base class for SharedStringHashTable and only keep the operations that
write to the shared memory on SharedStringHashTableReadOnly (namely, add() /
remove() / clear(). Update VisitedLinkTableController and WebSWOriginTable
to use SharedStringHashTableReadOnly since they are instantiated in the
WebContent process and use readonly shared memory.
- Shared/SharedStringHashTable.cpp:
(WebKit::SharedStringHashTableReadOnly::SharedStringHashTableReadOnly):
(WebKit::SharedStringHashTableReadOnly::~SharedStringHashTableReadOnly):
(WebKit::SharedStringHashTableReadOnly::setSharedMemory):
(WebKit::doubleHash):
(WebKit::SharedStringHashTableReadOnly::contains const):
(WebKit::SharedStringHashTableReadOnly::findSlot const):
(WebKit::SharedStringHashTable::SharedStringHashTable):
(WebKit::SharedStringHashTable::~SharedStringHashTable):
(WebKit::SharedStringHashTable::add):
(WebKit::SharedStringHashTable::remove):
(WebKit::SharedStringHashTable::clear):
- Shared/SharedStringHashTable.h:
- WebProcess/Storage/WebSWOriginTable.h:
- WebProcess/WebPage/VisitedLinkTableController.cpp:
(WebKit::VisitedLinkTableController::removeAllVisitedLinks):
- WebProcess/WebPage/VisitedLinkTableController.h:
- 10:18 AM Changeset in webkit [223957] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: Enable WebKit logging configuration and display
https://bugs.webkit.org/show_bug.cgi?id=177027
<rdar://problem/33964767>
Unreviewed, fix flakey test.
- inspector/console/webcore-logging-expected.txt:
- inspector/console/webcore-logging.html:
- 9:58 AM Changeset in webkit [223956] by
-
- 5 edits2 deletes in trunk
Support the TailBench9000 benchmark in run-jsc-benchmarks
https://bugs.webkit.org/show_bug.cgi?id=178451
Reviewed by Saam Barati.
PerformanceTests:
The separation between the definition of the benchmarks (in merge-sort.js and n-body.js) and their loops (in *-run.js)
was causing trouble since the load of the js files only succeeded from the same directory. So I chose to merge them, following
the example of the other benchmarks.
- TailBench9000/merge-sort-run.js: Removed.
- TailBench9000/merge-sort.js:
- TailBench9000/n-body-run.js: Removed.
- TailBench9000/n-body.js:
Tools:
- Scripts/run-jsc-benchmarks:
- 9:38 AM Changeset in webkit [223955] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Avoid clearing the overrideContainingBlockWidth if possible
https://bugs.webkit.org/show_bug.cgi?id=178260
Reviewed by Sergio Villar Senin.
Since the intrinsic width computation uses the same logic than the
track sizing algorithm we are clearing the overrideContainingBlockWidth
of some grid items that are required to laid out them properly.
It's very uncommon that any intrinsic size computation isn't performed
as part of a layout process. However, if it happens, once cleared the
overrideContainingBlockWidth it may lead to an incorrect layout of the
affected grid items.
This change is a defensive approach to avoid the issues caused by
such off-layout preferred size requests, which may imply recomputing
the grid container intrinsic size.
No new tests, because we are only removing some redundant logic.
- rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const):
(WebCore::IndefiniteSizeStrategy::minLogicalWidthForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalWidthForChild const):
- rendering/GridTrackSizingAlgorithm.h:
- 8:33 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 8:11 AM Changeset in webkit [223954] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed follow up changing one more enum value as discussed in the bug
https://bugs.webkit.org/show_bug.cgi?id=177810
- platform/glib/LowPowerModeNotifierGLib.cpp:
(WebCore::LowPowerModeNotifier::updateState): use NONE instead of DISCHARGING, to ensure
it will build even with older upower.
- 2:00 AM WebKitGTK/2.18.x edited by
- (diff)
- 1:34 AM Changeset in webkit [223953] by
-
- 15 edits in trunk
[WPE] Remove GLib API functions which use Cairo
https://bugs.webkit.org/show_bug.cgi?id=178205
Reviewed by Michael Catanzaro.
Source/WebKit:
Add PLATFORM(GTK) guards for the parts of of the GLib API which use cairo_surface_t (web
page snapshots and favicons), and remove the affected function prototypes from public API
headers. This way, the WPE version of the API is not tied to Cairo.
- PlatformWPE.cmake:
- UIProcess/API/glib/WebKitFaviconDatabase.cpp:
- UIProcess/API/glib/WebKitFaviconDatabasePrivate.h:
- UIProcess/API/glib/WebKitInjectedBundleClient.cpp:
- UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkitWebViewGetProperty):
(webkitWebViewDispose):
(webkit_web_view_class_init):
(webkitWebViewLoadChanged):
- UIProcess/API/glib/WebKitWebViewPrivate.h:
- UIProcess/API/wpe/WebKitFaviconDatabase.h:
- UIProcess/API/wpe/WebKitWebView.h:
- WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:
(webkitWebPageDidReceiveMessage):
Tools:
Add PLATFORM(GTK) guards for the API tests (or parts of them) which use cairo_surface_t (web
page snapshots and favicons) which are not available in the WPE version of the GLib API.
- TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
(testNotInitialized):
(testPrivateBrowsing):
(testFaviconDatabase):
- TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
(testFindControllerHide):
(beforeAll):
- TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
- TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
- 12:39 AM Changeset in webkit [223952] by
-
- 9 edits in trunk
Web Inspector: preserve Recordings for each Canvas after closing the Canvas tab
https://bugs.webkit.org/show_bug.cgi?id=178767
<rdar://problem/35167239>
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Test.html:
Include CollectionTypes for tests.
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype.recordingFinished):
- UserInterface/Models/Canvas.js:
(WI.Canvas):
(WI.Canvas.prototype.get recordingCollection):
- UserInterface/Models/CollectionTypes.js:
(WI.CanvasCollection):
(WI.RecordingCollection):
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype._addRecording):
(WI.CanvasContentView.prototype._recordingStopped):
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype._recordingAdded):
LayoutTests:
- inspector/canvas/resources/recording-utilities.js:
(TestPage.registerInitializer.window.startRecording):
Add assertions that the recording is added to the canvas' RecordingCollection.
- 12:17 AM Changeset in webkit [223951] by
-
- 16 edits in trunk
Make SERVICE_WORKER feature buildable on GTK, WPE
https://bugs.webkit.org/show_bug.cgi?id=178574
Reviewed by Carlos Garcia Campos.
Source/WebCore:
- CMakeLists.txt: Add missing include paths and files to the build.
- Sources.txt: Add missing files to the build.
- WebCore.xcodeproj/project.pbxproj: Remove the JSDOMPromise.cpp and
JSFetchEventCustom.cpp targets, they're now built via unified sources.
- bindings/js/JSFetchEventCustom.cpp: Guard custom JSFetchEvent code
with the ENABLE(SERVICE_WORKER) guards.
Source/WebKit:
- CMakeLists.txt: Add missing files to the build.
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didGetWorkerContextProcessConnection):
IPC::Attachment object should be accessed through an rvalue reference,
making it mutable and enabling releasing the file descriptor.
- StorageProcess/StorageProcess.h: Adjust the method signature.
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
Explicitly include the ResourceError header from WebCore (using a forwarding header).
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
Include the CachedResource header from WebCore (again using a forwarding header).
- WebProcess/Storage/WebServiceWorkerProvider.h: Forward-declare the WebCore::CachedResource type.
Source/WTF:
- wtf/Identified.h: Explicitly include the <atomic> header since
std::atomic<> is used in the ThreadSafeIdentified definition.
Tools:
- Scripts/webkitperl/FeatureList.pm: Add the --service-worker option
that enables the SERVICE_WORKER feature flag. For now it's enabled
on Apple's Cocoa ports (even when build-webkit isn't used for those
builds, the flag is enabled here for consistency).
Oct 24, 2017:
- 11:55 PM Changeset in webkit [223950] by
-
- 3 edits in trunk/Source/bmalloc
[Linux] Enable Gigacage in x64 Linux environment
https://bugs.webkit.org/show_bug.cgi?id=177745
<rdar://problem/34773148>
Reviewed by Yusuke Suzuki.
Re-enable Gigacage on x86_64 Linux platforms after it was disabled in 223877.
The cause for the revert was problems with huge coredumps being generated
while Gigacage was enabled. The feature virtually allocates about 80GB of
memory at the beginning of the process lifetime. This is not a problem in
itself since the memory range is marked as not needed through madvise(),
but all this memory was still included upon core dump generation on Linux.
Since there are reasonable limits enforced upon core dumps, these were
being truncated every time, not yielding any useful information.
To avoid this, on Linux, invocations of madvise() with the MADV_NORMAL and
MADV_DONTNEED advice parameters should be accompanied with respectively
matching MADV_DODUMP and MADV_DONTDUMP madvise() calls. This correctly
avoids core-dumping any memory that's not yet been physically allocated.
- bmalloc/Gigacage.h:
- bmalloc/VMAllocate.h:
(bmalloc::vmDeallocatePhysicalPages):
(bmalloc::vmAllocatePhysicalPages):
- 11:26 PM Changeset in webkit [223949] by
-
- 3 edits in trunk/Source/WebCore
Clean up gcc build warnings about reaching the end of a non void function for webrtc classes
https://bugs.webkit.org/show_bug.cgi?id=178721
Patch by Alejandro G. Castro <alex@igalia.com> on 2017-10-24
Reviewed by Youenn Fablet.
Assert when we reach those situations and return some value after that to avoid warning.
No new tests, this is a clean up.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::sessionDescriptionType):
(WebCore::signalingState):
(WebCore::toRTCIceConnectionState):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::bundlePolicyfromConfiguration):
(WebCore::iceTransportPolicyfromConfiguration):
- 10:37 PM Changeset in webkit [223948] by
-
- 3 edits in trunk/Source/WebInspectorUI
REGRESSION(r222181): Web Inspector: Augmenting Agents Domains are not getting activated
https://bugs.webkit.org/show_bug.cgi?id=178768
<rdar://problem/35081334>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-24
Reviewed by Brian Burg.
- UserInterface/Base/Main.js:
Simplify event dispatch.
- UserInterface/Controllers/AppController.js:
(WI.AppController.prototype.activateExtraDomains):
Pass the domains on.
- 6:35 PM Changeset in webkit [223947] by
-
- 5 edits2 adds in trunk
RenderSVGModelObject::checkIntersection triggers layout
https://bugs.webkit.org/show_bug.cgi?id=178710
Reviewed by Simon Fraser.
Source/WebCore:
Fixed the bug that checkIntersection and checkEnclosure no longer updates the layout after r223882.
Test: svg/custom/check-intersection-basic.svg
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):
- svg/SVGSVGElement.h:
LayoutTests:
Added the support for SVG documents to js-test.js, and added a basic test for checkIntersection
and checkEnclosure using it.
- resources/js-test.js:
(ensureRootElement): Added. Creates a foreignObject element inside a SVG document.
(moveForeignObjectToTopIfNeeded): Added. In SVG, z-index order is determined by the element order.
In order to make the results visible, we move the foreignObject to the top by appending to the end
of the document element.
(getOrCreate):
(debug): Run innerHTML before appendChild as setting namespaceURI before running innerHTML would
result in span's being parsed as SVG elements.
(insertStyleSheet):
(finishJSTest):
- svg/custom/check-intersection-basic-expected.txt: Added.
- svg/custom/check-intersection-basic.svg: Added.
- 6:34 PM Changeset in webkit [223946] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Owner commit does not necessarily exist in the same commit set for an owned commit.
https://bugs.webkit.org/show_bug.cgi?id=178763
Reviewed by Ryosuke Niwa.
Remove the check based on previous incorrect assumption.
Added unit tests to cover this change.
- public/privileged-api/create-test-group.php:
- server-tests/privileged-api-create-test-group-tests.js:
(return.addTriggerableAndCreateTask.string_appeared_here.then.id.taskId.id.then):
- 5:52 PM Changeset in webkit [223945] by
-
- 20 edits4 copies2 adds in trunk
[Apple Pay] Implement a paymentmethodselected event for PaymentRequest
https://bugs.webkit.org/show_bug.cgi?id=178765
Reviewed by Tim Horton.
Source/WebCore:
When the Apple Pay payment method changes, fire an applepaypaymentmethodchanged event on the
PaymentRequest object. The event has a paymentMethod property and an updateWith() method
which behaves identically to PaymentRequestUpdateEvent.updateWith().
Test: http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https.html
- DerivedSources.make:
- Modules/applepay/ApplePayPaymentMethod.idl:
- Modules/applepay/ApplePayPaymentMethodSelectedEvent.h:
- Modules/applepay/PaymentMethod.h:
(WebCore::PaymentMethod::PaymentMethod): Deleted.
(WebCore::PaymentMethod::pkPaymentMethod const): Deleted.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::detailsUpdated):
(WebCore::ApplePayPaymentHandler::paymentMethodUpdated):
(WebCore::ApplePayPaymentHandler::didSelectPaymentMethod):
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
- Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp: Added.
(WebCore::ApplePayPaymentMethodUpdateEvent::ApplePayPaymentMethodUpdateEvent):
(WebCore::ApplePayPaymentMethodUpdateEvent::eventInterface const):
- Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.h: Added.
- Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.idl: Added.
- Modules/paymentrequest/PaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::shippingAddressChanged):
(WebCore::PaymentRequest::shippingOptionChanged):
(WebCore::PaymentRequest::dispatchEvent):
(WebCore::PaymentRequest::updateWith):
(WebCore::PaymentRequest::settleDetailsPromise):
(WebCore::PaymentRequest::dispatchUpdateEvent): Deleted.
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentRequest.idl:
- Modules/paymentrequest/PaymentRequestUpdateEvent.cpp:
(WebCore::PaymentRequestUpdateEvent::updateWith):
- Modules/paymentrequest/PaymentRequestUpdateEvent.h:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- dom/EventNames.in:
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::changePaymentMethod):
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.idl:
- testing/MockPaymentMethod.h: Added.
LayoutTests:
- http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https-expected.txt: Added.
- http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https.html: Added.
- 5:47 PM Changeset in webkit [223944] by
-
- 6 edits in trunk/Source
ServiceWorkerClientFetch should return an error that is not null in case of failure
https://bugs.webkit.org/show_bug.cgi?id=178761
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-24
Reviewed by Geoffrey Garen.
Source/WebCore:
Covered by existing tests.
As per spec, ServiceWorkerJob should not go through Service Worker Handle Fetch
for fetching scripts.
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadAsynchronously):
- workers/WorkerScriptLoaderClient.h:
(WebCore::WorkerScriptLoaderClient::isServiceWorkerClient const):
- workers/service/ServiceWorkerJob.h:
Source/WebKit:
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didFail): Generating a General error.
- 5:36 PM Changeset in webkit [223943] by
-
- 3 edits in trunk/Tools
Unreviewed, fix name of Perl LibXML package on Fedora
https://bugs.webkit.org/show_bug.cgi?id=178206
<rdar://problem/35028586>
- gtk/install-dependencies:
- wpe/install-dependencies:
- 5:33 PM Changeset in webkit [223942] by
-
- 4 edits in trunk/Source/WebCore
Move inspector and loader to unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178760
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 5:27 PM Changeset in webkit [223941] by
-
- 2 edits in trunk/Source/WebCore
Fix build after r223940
- inspector/WebConsoleAgent.cpp:
- 5:12 PM Changeset in webkit [223940] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build after r223929.
https://bugs.webkit.org/show_bug.cgi?id=177027
- inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::getLoggingChannels):
Always initialize the variable "level". Visual studio was complaining about the possibility of not initializing it
but this is only possible if logChannel->level is an invalid enum value.
- 5:09 PM Changeset in webkit [223939] by
-
- 2 edits in trunk/Source/WebCore
Fix Windows build after r223925
https://bugs.webkit.org/show_bug.cgi?id=178687
- html/ImageBitmap.cpp:
(WebCore::interpolationQualityForResizeQuality):
Visual Studio was complaining that not all control paths returned a value.
- 4:33 PM Changeset in webkit [223938] by
-
- 3 edits in trunk/LayoutTests
Test fast/writing-mode/english-bt-text-with-spelling-marker.html should wait for editing commands to complete
https://bugs.webkit.org/show_bug.cgi?id=178759
Reviewed by Ryosuke Niwa.
Make use of typeCharacterCommand() from (LayoutTests/editing/editing.js) to type each character
with a delay and delay test completion until all characters have been typed.
- fast/writing-mode/english-bt-text-with-spelling-marker-expected.html:
- fast/writing-mode/english-bt-text-with-spelling-marker.html:
- 3:59 PM Changeset in webkit [223937] by
-
- 3 edits in trunk/Source/JavaScriptCore
Allow OjbC Weak References when building TestAPI
https://bugs.webkit.org/show_bug.cgi?id=178748
Reviewed by Dan Bernstein.
Set TestAPI build flag Weak References in Manual Retain Release to true.
- JavaScriptCore.xcodeproj/project.pbxproj: Reverted.
- Configurations/ToolExecutable.xcconfig: Changed the flag here instead.
- 3:30 PM Changeset in webkit [223936] by
-
- 5 edits in trunk/Source/bmalloc
Need to pass non-nil argument to SimulateCrash() in bmalloc::logVMFailure()
<https://webkit.org/b/178740>
<rdar://problem/35154943>
Reviewed by Saam Barati.
- bmalloc/BPlatform.h:
(BUNUSED_PARAM): Define macro.
- bmalloc/Logging.cpp:
(SimulateCrash): Change third argument of SimulateCrash() to
CFStringRef since it's an NSString * in Objective-C.
(bmalloc::logVMFailure): Create a CFStringRef to use as a
description string. Use new vmSize parameter to log size.
- bmalloc/Logging.h:
(bmalloc::logVMFailure): Update function signature to take a
size_t parameter representing vmSize.
- bmalloc/VMAllocate.h:
(bmalloc::tryVMAllocate): Pass vmSize into logVMFailure().
- 3:28 PM Changeset in webkit [223935] by
-
- 17 edits1 copy5 adds in trunk
Enable service worker to use cache storage api
https://bugs.webkit.org/show_bug.cgi?id=178684
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-24
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/workers/service/service-worker-cache-api.https.html
Updated WorkerLoaderProxy so that it can create a CacheStorageConnection.
Update WorkerCacheStorageConnection to take benefit of that.
This allows creating a CacheStorageConnection based on the page for regular workers and differently for Service Worker context.
Added ServiceWorkerThreadProxy as a proxy to ServiceWorkerThread.
It is in particular responsible to do proxy for loading tasks.
It implements cache API support for service worker by creating a dedicated CacheStorageConnection.
- Modules/cache/WorkerCacheStorageConnection.cpp:
(WebCore::WorkerCacheStorageConnection::create):
(WebCore::WorkerCacheStorageConnection::~WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):
- WebCore.xcodeproj/project.pbxproj:
- workers/WorkerLoaderProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::createCacheStorageConnection):
- workers/WorkerMessagingProxy.h:
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
- workers/service/context/ServiceWorkerThread.h:
- workers/service/context/ServiceWorkerThreadProxy.cpp: Added.
(WebCore::ServiceWorkerThreadProxy::create):
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::postTaskForModeToWorkerGlobalScope):
(WebCore::ServiceWorkerThreadProxy::postTaskToLoader):
(WebCore::ServiceWorkerThreadProxy::createCacheStorageConnection):
- workers/service/context/ServiceWorkerThreadProxy.h: Added.
Source/WebKit:
Passing the WebPreferences store of the default page group of the WebProcessPool to its ServiceWorker process.
ServiceWorkerContextManager then uses it to initialize the preferences accordingly.
Patch is covered by new test which is using cache api previously disabled and now enabled through the store.
Made use of the new ServiceWorkerThreadProxy in ServiceWorkerContextManager to enable a cache storage connection.
Fixed the default size of quota in WebsiteDataStore.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getWorkerContextProcessConnection):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- WebProcess/Storage/ServiceWorkerContextManager.cpp:
(WebKit::ServiceWorkerContextManager::ServiceWorkerContextManager):
(WebKit::ServiceWorkerContextManager::updatePreferences):
(WebKit::ServiceWorkerContextManager::startServiceWorker):
(WebKit::ServiceWorkerContextManager::startFetch):
- WebProcess/Storage/ServiceWorkerContextManager.h:
(WebKit::ServiceWorkerContextManager::ServiceWorkerContextManager): Deleted.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getWorkerContextConnection):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
LayoutTests:
- http/tests/workers/service/resources/service-worker-cache-api-worker.js: Added.
- http/tests/workers/service/resources/service-worker-cache-api.js: Added.
- http/tests/workers/service/service-worker-cache-api.https-expected.txt: Added.
- http/tests/workers/service/service-worker-cache-api.https.html: Added.
- 3:23 PM Changeset in webkit [223934] by
-
- 4 edits in trunk
Selecting and right-clicking URL-like strings with IDNA-disallowed characters in host or authority causes rendering engine crash
https://bugs.webkit.org/show_bug.cgi?id=174267
Reviewed by Tim Horton.
Source/WebKit:
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCanHandleRequest):
Tools:
- TestWebKitAPI/Tests/WebKit/CanHandleRequest_Bundle.cpp:
(TestWebKitAPI::runTest):
- 3:20 PM Changeset in webkit [223933] by
-
- 4 edits in trunk/Source/WebCore
Optionally store entire ResourceRequest for ping loads
https://bugs.webkit.org/show_bug.cgi?id=178756
Reviewed by Tim Horton.
No change in behavior.
This uses less memory in the common loading case.
This will be needed for moving appcache loading to the Networking Process.
See https://bugs.webkit.org/show_bug.cgi?id=178540
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::setOriginalRequest):
(WebCore::CachedResource::originalRequest const):
(WebCore::CachedResource::setOriginalRequestHeaders): Deleted.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- 3:19 PM Changeset in webkit [223932] by
-
- 2 edits in trunk/LayoutTests
Skipped imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/011.html on High Sierra Release.
https://bugs.webkit.org/show_bug.cgi?id=178553
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 3:11 PM Changeset in webkit [223931] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Console Drawer resizing doesn't match cursor position
https://bugs.webkit.org/show_bug.cgi?id=178753
<rdar://problem/35160484>
Reviewed by Brian Burg.
- UserInterface/Views/ConsoleDrawer.js:
(WI.ConsoleDrawer.prototype._updateDrawerHeight):
Drive-by fix an early return that would never have worked.
- UserInterface/Views/Main.css:
(#content):
Give the #content a flex grow of 1. This causes the space to grow as it
already was but now it does not affect the size of the fixed height sibling.
- 3:05 PM Changeset in webkit [223930] by
-
- 4 edits in trunk/Source/WebCore
[WebIDL] Support the ExportMacro attribute for dictionaries
https://bugs.webkit.org/show_bug.cgi?id=178752
Reviewed by Sam Weinig.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateDictionaryHeaderContent):
- bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
- bindings/scripts/test/TestStandaloneDictionary.idl:
- 3:00 PM Changeset in webkit [223929] by
-
- 43 edits1 copy2 adds in trunk
Web Inspector: Enable WebKit logging configuration and display
https://bugs.webkit.org/show_bug.cgi?id=177027
<rdar://problem/33964767>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/ConsoleMessage.cpp:
(Inspector::messageSourceValue): Inspector::Protocol::Console::ConsoleMessage ->
Inspector::Protocol::Console::ChannelSource.
- inspector/agents/JSGlobalObjectConsoleAgent.cpp:
(Inspector::JSGlobalObjectConsoleAgent::getLoggingChannels): There are no logging channels
specific to a JSContext yet, so return an empty channel array.
(Inspector::JSGlobalObjectConsoleAgent::setLoggingChannelLevel): No channels, return an error.
- inspector/agents/JSGlobalObjectConsoleAgent.h:
- inspector/protocol/Console.json: Add ChannelSource, ChannelLevel, and Channel. Add getLoggingChannels
and setLoggingChannelLevel.
- inspector/scripts/codegen/generator.py: Special case "webrtc"-> "WebRTC".
- inspector/scripts/tests/generic/expected/enum-values.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
- runtime/ConsoleTypes.h: Add Media and WebRTC.
Source/WebCore:
Test: inspector/console/webcore-logging.html
- dom/Document.cpp:
(WebCore::Document::~Document): Stop observing the logger.
(WebCore::Document::logger): Observe the logger.
(WebCore::Document::didLogMessage): Forward logging messages to the inspector.
- dom/Document.h:
- inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::getLoggingChannels): New, return the state of log runtime channels.
(WebCore::WebConsoleAgent::setLoggingChannelLevel): New, set the state of a channel.
- inspector/WebConsoleAgent.h:
- platform/Logging.cpp:
(WebCore::getLogChannel): New, get a log channel by name.
- platform/Logging.h:
Source/WebCore/PAL:
- pal/Logger.h:
(PAL::Logger::willLog const): Always return true for Always and Error so those messages are
always logged to the system.
(PAL::Logger::log): Always log Always and Error to the system, but pay strict attention to level
and channel state for logging to observers so logging only shows up in the inspector when
explicitly enabled by the user.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js: Add new localized strings.
- UserInterface/Controllers/LogManager.js:
(WI.LogManager): Initialize _loggingChannelSources, fetch _customLoggingChannels.
(WI.LogManager.supportsLogChannels): New.
(WI.LogManager.prototype.get customLoggingChannels): New.
(WI.LogManager.prototype.get logChannelSources): New.
- UserInterface/Main.html:
- UserInterface/Models/ConsoleMessage.js: Add Media and WebRTC.
- UserInterface/Models/IssueMessage.js:
(WI.IssueMessage): Add media and webrtc.
- UserInterface/Models/LoggingChannel.js: Added.
(WI.LoggingChannel):
(WI.LoggingChannel.fromPayload):
(WI.LoggingChannel.prototype.get source):
(WI.LoggingChannel.prototype.get level):
- UserInterface/Views/LogContentView.js:
(WI.LogContentView): Add new scope buttons for "Log", "Info", and "Debug". Create log channel
scope buttons once logging has started.
(WI.LogContentView.prototype.get navigationItems): Add the log message scope bar when necessary.
(WI.LogContentView.prototype._scopeFromMessageSource): New.
(WI.LogContentView.prototype._scopeFromMessageLevel): Don't group Info, Log, and Debug.
(WI.LogContentView.prototype._messageAdded): Force a UI update the first time a WebKit log
message is added.
(WI.LogContentView.prototype._messageShouldBeVisible): New, deal with message source bar buttons.
(WI.LogContentView.prototype._messageSourceBarSelectionDidChange): New.
(WI.LogContentView.prototype._filterMessageElements): Deal with message source bar buttons.
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView): Create and initialize menus
for each log channel.
Source/WebKitLegacy/mac:
- WebCoreSupport/WebChromeClient.mm:
(stringForMessageSource): Deal with Media and WebRTC message sources.
Tools:
Allow new 'dumpJSConsoleLogInStdErr' test header to redirect log console output to stderr.
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/TestOptions.mm:
(TestOptions::TestOptions):
- DumpRenderTree/mac/DumpRenderTree.mm:
(runTest):
- WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::runTest):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
LayoutTests:
- inspector/console/webcore-logging-expected.txt: Added.
- inspector/console/webcore-logging.html: Added.
- platform/mac/TestExpectations: Skip new test on Yosemite and ElCapitan.
- platform/win/TestExpectations: Skip new test.
- 2:58 PM Changeset in webkit [223928] by
-
- 2 edits in trunk/Source/WebCore
Attempted build fix for Sierra.
- html/ImageBitmap.cpp:
(WebCore::croppedSourceRectangleWithFormatting):
- 2:55 PM Changeset in webkit [223927] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: null is not an object (evaluating 'this.treeOutline.isXMLMimeType')
https://bugs.webkit.org/show_bug.cgi?id=178745
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-24
Reviewed by Brian Burg.
- UserInterface/Views/DOMTreeUpdater.js:
(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
An earlier tree element update might have caused this other tree element's
waiting to be updated to actually be removed. So just skip past them.
- 2:48 PM Changeset in webkit [223926] by
-
- 2 edits in trunk/Source/WTF
WTF: Eliminated PLATFORM checks for HAVE_MACH_EXCEPTIONS
https://bugs.webkit.org/show_bug.cgi?id=178747
Reviewed by Saam Barati.
Removed unnecessary PLATFORM checks as they can cause build failures
when the include file is present.
- wtf/Platform.h:
- 2:46 PM Changeset in webkit [223925] by
-
- 7 edits1 move5 adds in trunk
Implement resizing options for ImageBitmap rendering
https://bugs.webkit.org/show_bug.cgi?id=178687
<rdar://problem/35135417>
Reviewed by Sam Weinig.
Source/WebCore:
Implement many of the sizing options for createImageBitmap.
Test: http/wpt/2dcontext/imagebitmap/createImageBitmap-sizing.html
- html/ImageBitmap.cpp:
(WebCore::croppedSourceRectangleWithFormatting):
Implement the first bit of the algorithm from
the HTML specification.
(WebCore::outputSizeForSourceRectangle):
... and then the second bit. Leave the rest in
comments for now.
(WebCore::interpolationQualityForResizeQuality):
Helper function to map ImageBitmapOptions to
GraphicsContext.
(WebCore::ImageBitmap::createPromise):
Implement more of the sizing algorithm.
- html/ImageBitmap.h: Origin tainting is defined to be false by default.
LayoutTests:
More ImageBitmap tests, this time focusing on sizing.
- http/wpt/2dcontext/imagebitmap/common.js:
(createCanvasOfSize):
(create9x9CanvasWith2dContext):
(create18x18CanvasWith2dContext):
Helper functions.
- http/wpt/2dcontext/imagebitmap/createImageBitmap-sizing-expected.txt: Added.
- http/wpt/2dcontext/imagebitmap/createImageBitmap-sizing.html: Added.
- http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap.html:
- http/wpt/2dcontext/imagebitmap/resources/target-blue-dot-no-intrinsic.svg: Added.
- http/wpt/2dcontext/imagebitmap/resources/target-blue-dot.png: Renamed from LayoutTests/http/wpt/2dcontext/imagebitmap/target-blue-dot.png.
- http/wpt/2dcontext/imagebitmap/resources/target-blue-dot.svg: Added.
- 2:35 PM Changeset in webkit [223924] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Add Recording.svg
https://bugs.webkit.org/show_bug.cgi?id=175045
Patch by Fujii Hironori <Fujii Hironori> on 2017-10-24
Reviewed by Brian Burg.
- UserInterface/Images/gtk/Recording.svg: Added.
- 2:31 PM Changeset in webkit [223923] by
-
- 2 edits in trunk/Source/JavaScriptCore
Allow OjbC Weak References when building TestAPI
https://bugs.webkit.org/show_bug.cgi?id=178748
Reviewed by Saam Barati.
Set TestAPI build flag Weak References in Manual Retain Release to true.
- JavaScriptCore.xcodeproj/project.pbxproj:
- 2:22 PM Changeset in webkit [223922] by
-
- 34 edits3 copies5 adds in trunk
Add initial implementation for serviceWorker.postMessage()
https://bugs.webkit.org/show_bug.cgi?id=178534
Reviewed by Youenn Fablet.
Source/WebCore:
Add initial implementation for serviceWorker.postMessage():
Test: http/tests/workers/service/basic-ServiceWorker-postMessage.https.html
- CMakeLists.txt:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSExtendableMessageEvent.cpp: Added.
(WebCore::JSExtendableMessageEvent::data const):
- bindings/js/WebCoreBuiltinNames.h:
- dom/Document.h:
- dom/EventNames.in:
- dom/MessagePortChannel.h:
- dom/ScriptExecutionContext.h:
- workers/WorkerGlobalScope.h:
- workers/service/ExtendableEvent.cpp:
(WebCore::ExtendableEvent::ExtendableEvent):
(WebCore::ExtendableEvent::~ExtendableEvent):
- workers/service/ExtendableEvent.h:
- workers/service/ExtendableMessageEvent.cpp: Added.
(WebCore::ExtendableMessageEvent::create):
(WebCore::ExtendableMessageEvent::ExtendableMessageEvent):
(WebCore::ExtendableMessageEvent::~ExtendableMessageEvent):
- workers/service/ExtendableMessageEvent.h: Added.
- workers/service/ExtendableMessageEvent.idl: Added.
- workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::postMessage):
(WebCore::ServiceWorker::state const):
(WebCore::ServiceWorker::scriptExecutionContext const):
- workers/service/ServiceWorker.h:
- workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::controller const):
- workers/service/ServiceWorkerContainer.h:
- workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::thread):
- workers/service/ServiceWorkerGlobalScope.h:
(isType):
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
- workers/service/context/ServiceWorkerThread.h:
- workers/service/server/SWClientConnection.h:
Source/WebKit:
Add initial implementation for serviceWorker.postMessage():
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/ServiceWorkerContextManager.cpp:
(WebKit::ServiceWorkerContextManager::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/ServiceWorkerContextManager.h:
- WebProcess/Storage/ServiceWorkerContextManager.messages.in:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):
- WebProcess/Storage/WebSWClientConnection.h:
LayoutTests:
Add layout test coverage.
- http/tests/workers/service/basic-ServiceWorker-postMessage.https-expected.txt: Added.
- http/tests/workers/service/basic-ServiceWorker-postMessage.https.html: Added.
- http/tests/workers/service/resources/basic-ServiceWorker-postMessage-worker.js: Added.
- http/tests/workers/service/resources/basic-ServiceWorker-postMessage.js: Added.
- 2:17 PM Changeset in webkit [223921] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: allow ShaderProgram to be shown in CanvasContentView
https://bugs.webkit.org/show_bug.cgi?id=178714
Reviewed by Brian Burg.
- UserInterface/Views/CanvasDetailsSidebarPanel.js:
(WI.CanvasDetailsSidebarPanel.prototype.inspect):
Allow ShaderProgram to show the related Canvas information.
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype.canShowRepresentedObject):
(WI.CanvasTabContentView.prototype.showRepresentedObject):
(WI.CanvasTabContentView.prototype._canvasTreeOutlineSelectionDidChange):
If a ShaderProgram is selected in the path component, display a ShaderProgramContentView.
- 2:08 PM Changeset in webkit [223920] by
-
- 11 edits in trunk/Source/WebInspectorUI
Web Inspector: remove canvases from Resources and experimental setting/UI
https://bugs.webkit.org/show_bug.cgi?id=178711
Reviewed by Brian Burg.
- UserInterface/Base/Main.js:
(WI.tabContentViewClassForRepresentedObject):
- UserInterface/Base/Setting.js:
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype.canvasAdded):
(WI.CanvasManager.prototype.canvasRemoved):
- UserInterface/Models/Canvas.js:
- UserInterface/Models/Frame.js:
(WI.Frame):
(WI.Frame.prototype.get extraScriptCollection):
(WI.Frame.prototype.commitProvisionalLoad):
(WI.Frame.prototype.get canvasCollection): Deleted.
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.isTabAllowed):
- UserInterface/Views/FrameTreeElement.js:
(WI.FrameTreeElement):
(WI.FrameTreeElement.prototype.onattach):
(WI.FrameTreeElement.prototype.ondetach):
(WI.FrameTreeElement.prototype.onpopulate):
(WI.FrameTreeElement.prototype._styleSheetAdded):
(WI.FrameTreeElement.prototype._canvasWasAdded): Deleted.
(WI.FrameTreeElement.prototype._canvasWasRemoved): Deleted.
- UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel):
(WI.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
(WI.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):
- UserInterface/Views/ResourcesTabContentView.js:
(WI.ResourcesTabContentView):
(WI.ResourcesTabContentView.prototype.canShowRepresentedObject):
- UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
- 1:48 PM Changeset in webkit [223919] by
-
- 5 edits1 add in trunk
[FTL] Support NewStringObject
https://bugs.webkit.org/show_bug.cgi?id=178737
Reviewed by Saam Barati.
JSTests:
- stress/new-string-object.js: Added.
(shouldBe):
(test):
Source/JavaScriptCore:
FTL should support NewStringObject and encourage use of NewStringObject in DFG pipeline.
After this change, we can convertCallObjectConstructor(String)toNewStringObject(String).
- ftl/FTLAbstractHeapRepository.h:
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewStringObject):
- 1:47 PM Changeset in webkit [223918] by
-
- 18 edits1 delete in trunk/Source/WebInspectorUI
Web Inspector: Show recordings in CanvasTabContentView
https://bugs.webkit.org/show_bug.cgi?id=177606
<rdar://problem/34715819>
Reviewed by Brian Burg.
Original patch by Matt Baker <Matt Baker>.
This patch folds canvas recordings into the new Canvas tab, which now
supports showing both CanvasCollections and Recordings.
When viewing recordings, a back button is shown at the start of the
navigation bar, allowing the user to return to the overview. It has been
styled with a back arrow, to make its function as clear as possible.
Like other navigation path components, the item for the recording can
clicked to select another recording taken from the same canvas.
The recording action scrubber has been moved from the content browser's
navigation bar to a more prominent location in the recording content view.
Selecting a frame tree element in the navigation sidebar no longer selects
the last action for that frame. This was changed to prevent the scrubber
position from behaving non-monotonically when selecting actions in sequential
order.
While this patch retains support for importing recordings, the feature
is not polished. Currently it is not possible to return to an imported
recording after leaving closing the view. In the future we may want to
consider including a navigation sidebar panel for the overview, which
could list canvas recordings (and eventually shaders).
- .eslintrc:
Drive-by: remove duplicate key.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Main.js:
(WI.contentLoaded):
(WI.tabContentViewClassForRepresentedObject):
- UserInterface/Main.html:
- UserInterface/Views/RecordingTabContentView.js: Removed.
Remove RecordingTabContentView.
- UserInterface/Images/Recording.svg:
New recording icon, used for tree elements and canvas preview UI.
- UserInterface/Models/Recording.js:
(WI.Recording):
(WI.Recording.prototype.get visualActionIndexes):
Visual action indexes should be computed by the recording.
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView):
(WI.CanvasContentView.prototype.refresh):
(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype.attached):
(WI.CanvasContentView.prototype._recordingStopped):
(WI.CanvasContentView.prototype._handleRecordingSelectElementChange):
New UI for showing CanvasContentView as a CollectionView item. Includes
recordings button and select for choosing a recording to view.
- UserInterface/Views/CanvasOverviewContentView.css:
(.content-view.canvas-overview .content-view.canvas > header):
Switch to 13px, which is more frequently used.
(.content-view.canvas-overview .content-view.canvas > header .subtitle::before):
Switch to literal em dash. Surrounding spaces were ignored when using
the backslash-escaped character.
(.content-view.canvas-overview .content-view.canvas:not(:hover, .is-recording, .selected) > header > .navigation-bar):
(.content-view.canvas-overview .content-view.canvas > footer > .recordings):
(.content-view.canvas-overview .content-view.canvas > footer > .recordings::before):
(.content-view.canvas-overview .content-view.canvas > footer > .recordings > select):
(.content-view.canvas-overview .content-view.canvas > footer .recordings > select:focus):
(.content-view.canvas-overview .content-view.canvas > footer > .flexible-space):
(.popover-content > .tree-outline .item.recording > .icon):
(.popover-content > .tree-outline .item.recording:hover):
(.popover-content > .tree-outline .item.recording:hover > .icon):
(.content-view.canvas-overview .content-view.canvas:not(:hover, .is-recording) > header > .navigation-bar): Deleted.
(.content-view.canvas-overview .content-view.canvas > footer): Deleted.
New styles for the recording picker.
- UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype.get selectionPathComponents):
(WI.CanvasOverviewContentView.prototype.contentViewAdded):
(WI.CanvasOverviewContentView.prototype.contentViewRemoved):
(WI.CanvasOverviewContentView.prototype._supplementalRepresentedObjectsDidChange):
(WI.CanvasOverviewContentView.prototype._selectedPathComponentChanged): Deleted.
(WI.CanvasOverviewContentView.prototype._supplementalRepresentedObjectsDidChange.createCanvasPathComponent): Deleted.
Canvas tree elements are now managed by CanvasTabContentView, which is
now responsible for maintaining the tree of canvas objects. For now the
tree holds canvases and recordings, but will eventually include shader programs.
- UserInterface/Views/CanvasTabContentView.css:
(.content-view.tab.canvas .navigation-bar > .item .recording > .icon):
(.content-view.tab.canvas .navigation-bar > .item > .canvas-overview > .icon): Deleted.
Add styles for recording path components.
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView):
(WI.CanvasTabContentView.prototype.treeElementForRepresentedObject):
(WI.CanvasTabContentView.prototype.canShowRepresentedObject):
(WI.CanvasTabContentView.prototype.showRepresentedObject):
(WI.CanvasTabContentView.prototype.shown):
(WI.CanvasTabContentView.prototype.restoreStateFromCookie):
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype.detached):
(WI.CanvasTabContentView.prototype._canvasAdded):
(WI.CanvasTabContentView.prototype._canvasRemoved):
(WI.CanvasTabContentView.prototype._canvasTreeOutlineSelectionDidChange):
(WI.CanvasTabContentView.prototype._recordingStopped):
(WI.CanvasTabContentView.prototype._navigationSidebarImport):
(WI.CanvasTabContentView.prototype._navigationSidebarTreeOutlineSelectionChanged):
(WI.CanvasTabContentView.prototype._recordingAdded):
(WI.CanvasTabContentView.prototype._recordingActionIndexChanged):
(WI.CanvasTabContentView.prototype._updateActionIndex):
(WI.CanvasTabContentView.prototype.restoreFromCookie): Deleted.
(WI.CanvasTabContentView.prototype._overviewPathComponentClicked): Deleted.
- UserInterface/Views/ContentView.js:
(WI.ContentView.createFromRepresentedObject):
- UserInterface/Views/RecordingActionTreeElement.css:
(body:not(.window-inactive, .window-docked-inactive) .tree-outline:matches(:focus, .force-focus) .item.action.selected > .titles .parameter.swizzled,):
(body:not(.window-inactive, .window-docked-inactive) :matches(:focus, .force-focus) .item.action.selected > .titles .parameter.swizzled,): Deleted.
- UserInterface/Views/RecordingContentView.css:
(.content-view:not(.tab).recording):
(.content-view:not(.tab).recording > header):
(.content-view:not(.tab).recording > header > .slider-container):
(.content-view:not(.tab).recording > header > .slider-container > input[type=range]):
(.content-view:not(.tab).recording > header > .slider-container > input[type=range]::-webkit-slider-runnable-track):
(.content-view:not(.tab).recording > header > .slider-container > input[type=range]::-webkit-slider-thumb):
(.content-view:not(.tab).recording > .preview-container):
- UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView):
(WI.RecordingContentView.prototype.updateActionIndex):
(WI.RecordingContentView.prototype.initialLayout):
(WI.RecordingContentView.prototype.async._generateContentCanvas2D):
(WI.RecordingContentView.prototype._updateSliderValue):
(WI.RecordingContentView.prototype._sliderChanged):
(WI.RecordingContentView.prototype.get supplementalRepresentedObjects): Deleted.
- UserInterface/Views/RecordingNavigationSidebarPanel.js:
(WI.RecordingNavigationSidebarPanel.prototype.set recording):
(WI.RecordingNavigationSidebarPanel.prototype.updateActionIndex):
- UserInterface/Views/ResourceIcons.css:
(.canvas .icon):
(.canvas.canvas-2d .icon): Deleted.
(.canvas:matches(.webgl, .webgl2, .webgpu) .icon): Deleted.
- 1:45 PM Changeset in webkit [223917] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening. Update inspector/network/har tests.
- http/tests/inspector/network/har/har-page-expected.txt:
Size of the test file changed and results needed to be updated.
- 1:36 PM Changeset in webkit [223916] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] fix offsets of branches that have to go over a jump
https://bugs.webkit.org/show_bug.cgi?id=153464
The jump() function creates 8 instructions, but the offsets of branches
meant to go over them only account for 6. In most cases, this is not an
issue as the last two instructions of jump() would be nops, but in the
rarer case where the jump destination is in a different 256 MB segment,
MIPSAssembler::linkWithOffset() will rewrite the code in a way in which
the last 4 instructions would be a 2 instruction load (lui/ori) into
$t9, a "j $t9" and then a nop. The wrong offset will mean that the
previous branches meant to go over the whole jump will branch to the
"j $t9" instruction, which would jump to whatever is currently in $t9
(since lui/ori would not be executed).
Reviewed by Michael Catanzaro.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
Fix the offsets of branches meant to go over code generated by jump().
- 1:21 PM Changeset in webkit [223915] by
-
- 2 edits in trunk/LayoutTests
Skip fast/html/marquee-reparent-check.html on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=178465
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:11 PM Changeset in webkit [223914] by
-
- 5 edits in trunk
Web Inspector: Layer mutations should be purely based on layerId, not based on nodeId
https://bugs.webkit.org/show_bug.cgi?id=178554
Patch by Ross Kirsling <Ross Kirsling> on 2017-10-24
Reviewed by Devin Rousso.
Source/WebInspectorUI:
- UserInterface/Controllers/LayerTreeManager.js:
(WI.LayerTreeManager.prototype.layerTreeMutations):
Looking for special cases involving nodeIds is incorrect, as nodeIds need not be unique in the layer list (such
as when an element and a pseudo-element thereof each give rise to a layer). A layer object marked "preserved" in
this way shares no data with its predecessor, meaning that no consumer can act upon this so-called preservation.
A preserved layer should be nothing more or less than a recycled layerId (the thing that *is* unique).
LayoutTests:
- inspector/layers/layer-tree-manager-expected.txt:
- inspector/layers/layer-tree-manager.html:
- 1:08 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 1:06 PM Changeset in webkit [223913] by
-
- 2 edits2 adds in trunk/LayoutTests
[GTK] Unskip layout tests editing/deleting/delete-emoji-1.html & editing/deleting/delete-emoji-1.html
https://bugs.webkit.org/show_bug.cgi?id=178742
Unreviewed test gardening.
- platform/gtk/TestExpectations: Updated expectations for the emoji deletion layout tests.
- platform/gtk/editing/deleting/delete-emoji-1-expected.txt: Added.
- platform/gtk/editing/deleting/delete-emoji-expected.txt: Added.
- 1:04 PM Changeset in webkit [223912] by
-
- 2 edits in trunk/LayoutTests
[WPE] Remove expectations for tests which do not exist anymore
https://bugs.webkit.org/show_bug.cgi?id=178717
Unreviewed WPE test gardening.
This avoids the following warning being emitted by run-webkit-tests:
--lint-test-files warnings:
LayoutTests/platform/wpe/TestExpectations:366 Path does not exist. fast/events/constructors/device-proximity-event-constructor.html
LayoutTests/platform/wpe/TestExpectations:902 Path does not exist. http/tests/dom/document-attributes-null-handling
- platform/wpe/TestExpectations:
- 12:56 PM Changeset in webkit [223911] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK+ test gardening.
- platform/gtk/TestExpectations:
- 12:53 PM Changeset in webkit [223910] by
-
- 16 edits6 adds in trunk
[Payment Request] Implement the "PaymentRequest updated" algorithm
https://bugs.webkit.org/show_bug.cgi?id=178689
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/payment-request/payment-request-update-event-updatewith-method.https-expected.txt:
Source/WebCore:
Implemented the "PaymentRequest updated" algorithm by firing shippingaddresschange and
shippingoptionchange events at the right times and implementing
PaymentRequestUpdateEvent.updateWith().
Tests: http/tests/paymentrequest/payment-request-change-shipping-address.https.html
http/tests/paymentrequest/payment-request-change-shipping-option.https.html
http/tests/paymentrequest/updateWith-method-pmi-handling.https.html
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::convertAndValidate): Added. Converts a PaymentDetailsInit to a
ApplePaySessionPaymentRequest::TotalAndLineItems.
(WebCore::ApplePayPaymentHandler::shippingAddressUpdated): Created a ShippingContactUpdate
and passed it to PaymentCoordinator::completeShippingContactSelection().
(WebCore::ApplePayPaymentHandler::shippingOptionUpdated): Created a ShippingMethodUpdate and
passed it to PaymentCoordinator::completeShippingMethodSelection().
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
- Modules/paymentrequest/PaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::checkAndCanonicalizeDetails): Moved the logic for checking and canonicalizing a
PaymentDetailsBase from PaymentRequest::create() to here.
(WebCore::PaymentRequest::create): Called checkAndCanonicalizeDetails().
(WebCore::PaymentRequest::abortWithException): Moved the body of stop() to here and
parameterized the Exception with which to abort m_showPromise.
(WebCore::PaymentRequest::stop): Called abortWithException() with an AbortError.
(WebCore::PaymentRequest::shippingAddressChanged): Called dispatchUpdateEvent() with
shippingaddresschangeEvent.
(WebCore::PaymentRequest::shippingOptionChanged): Ditto with shippingoptionchangeEvent.
(WebCore::PaymentRequest::dispatchUpdateEvent): Created a PaymentRequestUpdateEvent and
dispatched it.
(WebCore::PaymentRequest::updateWith): Added a settle handler to m_detailsPromise.
(WebCore::PaymentRequest::settleDetailsPromise): Updated the PaymentRequest with the new
details and called PaymentHandler::shippingAddressUpdated() or
PaymentHandler::shippingOptionUpdated().
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentRequestUpdateEvent.cpp:
(WebCore::PaymentRequestUpdateEvent::PaymentRequestUpdateEvent):
(WebCore::PaymentRequestUpdateEvent::updateWith): Called PaymentRequest::updateWith().
(WebCore::PaymentRequestUpdateEvent::eventInterface const): Returned
PaymentRequestUpdateEventInterfaceType.
- Modules/paymentrequest/PaymentRequestUpdateEvent.h:
- Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::canMakePaymentsWithActiveCard):
(WebCore::MockPaymentCoordinator::openPaymentSetup):
(WebCore::MockPaymentCoordinator::completeMerchantValidation): Stopped calling
PaymentCoordinator::didAuthorizePayment().
(WebCore::MockPaymentCoordinator::changeShippingOption): Called
PaymentCoordinator::didSelectShippingMethod().
(WebCore::MockPaymentCoordinator::acceptPayment): Called
PaymentCoordinator::didAuthorizePayment().
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.idl:
LayoutTests:
- http/tests/paymentrequest/payment-request-change-shipping-address.https-expected.txt: Added.
- http/tests/paymentrequest/payment-request-change-shipping-address.https.html: Copied from imported/w3c/web-platform-tests/payment-request/shipping-address-changed-manual.https.html.
- http/tests/paymentrequest/payment-request-change-shipping-option.https-expected.txt: Added.
- http/tests/paymentrequest/payment-request-change-shipping-option.https.html: Copied from imported/w3c/web-platform-tests/payment-request/change-shipping-option-manual.https.html.
- http/tests/paymentrequest/resources/helpers.js:
(async.getPaymentRequestResponse):
- http/tests/paymentrequest/updateWith-method-pmi-handling.https-expected.txt: Added.
- http/tests/paymentrequest/updateWith-method-pmi-handling.https.html: Copied from imported/w3c/web-platform-tests/payment-request/updateWith-method-pmi-handling-manual.https.html.
- 12:33 PM Changeset in webkit [223909] by
-
- 5 edits in trunk
Apply custom header fields from WebsitePolicies to same-domain requests
https://bugs.webkit.org/show_bug.cgi?id=178356
Source/WebCore:
<rdar://problem/31073436>
Reviewed by Brady Eidson.
Covered by new API tests.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::clearHTTPAuthorization):
(WebCore::ResourceRequestBase::clearHTTPContentType):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPOrigin):
(WebCore::ResourceRequestBase::clearHTTPUserAgent):
(WebCore::ResourceRequestBase::clearHTTPAccept):
(WebCore::ResourceRequestBase::clearHTTPAcceptEncoding):
(WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::setAllowCookies):
(WebCore::ResourceRequestBase::setPriority):
(WebCore::ResourceRequestBase::addHTTPHeaderFieldIfNotPresent):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderFields):
If we only update the platform request when headers are added (or other changes) for HTTP requests,
then the changes will not affect the NSURLRequest that is sent over IPC or visible to the API.
This is necessary for these new tests to work, but it's also of growing importance since our
introduction of WKURLSchemeHandler.
Tools:
Reviewed by Brady Eidson.
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(expectHeaders):
- 12:07 PM Changeset in webkit [223908] by
-
- 20 edits1 add in trunk/Source
Adopt new secure coding APIs
https://bugs.webkit.org/show_bug.cgi?id=178484
<rdar://problem/34837193>
Reviewed by Tim Horton.
Source/WebCore:
Switch to new NSKeyed[Un]Archiver methods that active and use
NSSecureCoding by default.
Most of the new API is wrapped in a set of convenience methods so we can
build without the new API on older systems.
No change in behavior.
- editing/cocoa/EditorCocoa.mm:
(WebCore::archivedDataForAttributedString): Use new convenience method
to archive the string object.
- loader/archive/cf/LegacyWebArchiveMac.mm:
(WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Update to
use secure coding where possible.
(WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write): Use new secure API.
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const): Ditto.
- testing/cocoa/WebArchiveDumpSupport.mm:
(WebCoreTestSupport::createCFURLResponseFromResponseData): Update to
secure coding API where possible.
Source/WebCore/PAL:
Add new convenience methods (and SPI headers) so we can adopt new NSKeyedArchiver
API that uses secure coding by default.
- PAL.xcodeproj/project.pbxproj:
- pal/spi/cocoa/NSKeyedArchiverSPI.h: Added.
(securelyArchivedDataWithRootObject): New convenience method.
(securelyUnarchiveRootObjectOfClassFromData): Ditto.
(secureArchiverFromMutableData): Ditto.
(secureUnarchiverFromData): Ditto.
Source/WebKit:
Switch to new NSKeyed[Un]Archiver methods that active and use
NSSecureCoding by default.
- Platform/ios/AccessibilityIOS.mm:
(WebKit::newAccessibilityRemoteToken): Use secure-by-default API.
- Shared/Cocoa/DataDetectionResult.mm:
(WebKit::DataDetectionResult::encode const): Ditto.
(WebKit::DataDetectionResult::decode): Ditto.
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::Payment>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::Payment>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentContact>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentContact>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMethod>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMethod>::decode): Ditto.
- Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode const): Ditto.
(WebKit::InteractionInformationAtPosition::decode): Ditto.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::decode): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::decodePlatformData): Ditto.
- Shared/mac/WebHitTestResultData.mm:
(WebKit::WebHitTestResultData::platformEncode const): Ditto.
(WebKit::WebHitTestResultData::platformDecode): Ditto.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setObject:forBundleParameter:]): Ditto.
(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]): Ditto.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setInputDelegate:]): Ditto.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess): Ditto.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::startAssistingNode): Ditto.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Ditto.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::initialize): Ditto.
(WebKit::InjectedBundle::setBundleParameter): Ditto.
(WebKit::InjectedBundle::setBundleParameters): Ditto.
- 11:55 AM Changeset in webkit [223907] by
-
- 9 edits in trunk/Source/JavaScriptCore
WebAssembly: NFC renames of things that aren't JS-specific
https://bugs.webkit.org/show_bug.cgi?id=178738
Reviewed by Saam Barati.
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::parseAndCompile):
- wasm/WasmB3IRGenerator.h:
- wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::complete):
- wasm/WasmCodeBlock.cpp:
(JSC::Wasm::CodeBlock::CodeBlock):
- wasm/WasmCodeBlock.h:
(JSC::Wasm::CodeBlock::embedderEntrypointCalleeFromFunctionIndexSpace):
(JSC::Wasm::CodeBlock::jsEntrypointCalleeFromFunctionIndexSpace): Deleted.
- wasm/WasmFormat.h:
- wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapper):
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):
- 11:52 AM Changeset in webkit [223906] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement should iterate HTMLTrackElements consistently.
https://bugs.webkit.org/show_bug.cgi?id=178423
rdar://problem/35044967
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-10-24
Reviewed by Eric Carlson.
No new tests because no expected behavior change.
HTMLMediaElement iterates HTMLTrackElements as children in every place but one, where it iterates them
as descendants. It should always iterate them as children.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren):
- 11:50 AM Changeset in webkit [223905] by
-
- 4 edits in trunk/Source/WebCore
SerializedScriptValue::deserialize() should take ports as a const Vector&
https://bugs.webkit.org/show_bug.cgi?id=178727
Reviewed by Alex Christensen.
SerializedScriptValue::deserialize() should take ports as a const Vector&, not a Vector&.
It does not modify the input vector.
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data const):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::CloneDeserializer):
(WebCore::SerializedScriptValue::deserialize):
- bindings/js/SerializedScriptValue.h:
- 11:46 AM Changeset in webkit [223904] by
-
- 6 edits1 add in trunk
[Win][JSCOnly] Make jsconly build testapi and dlls and copy dlls when running tests
https://bugs.webkit.org/show_bug.cgi?id=177279
Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-10-24
Reviewed by Yusuke Suzuki.
.:
- Source/cmake/OptionsJSCOnly.cmake:
Source/JavaScriptCore:
- shell/PlatformJSCOnly.cmake: Added.
Tools:
- Scripts/build-jsc:
- Scripts/run-jsc-stress-tests:
- 11:43 AM Changeset in webkit [223903] by
-
- 4 edits5 adds1 delete in trunk/Source/WebKit
[Settings] Add initial support for generating preferences related code
https://bugs.webkit.org/show_bug.cgi?id=178656
Patch by Sam Weinig <sam@webkit.org> on 2017-10-24
Reviewed by Dean Jackson.
As a first step towards getting off the macros in WebPreferencesDefinitions.h
and reducing the overhead of adding a preference, this change generates adds
WebPreferences.yaml where preference changes will go, and generates much of
WebPreferencesDefinitions.h from it (all the custom defaults moved to
WebPreferencesDefinitionsBase.h). Subsequent changes will remove the need for
the macros in WebPreferencesDefinitions.h entirely.
- CMakeLists.txt:
- DerivedSources.make:
- WebKit.xcodeproj/project.pbxproj:
Add new files / rules to generate WebPreferencesDefinitions.h.
- Scripts/GeneratePreferences.rb: Added.
- Scripts/PreferencesTemplates: Added.
- Scripts/PreferencesTemplates/WebPreferencesDefinitions.h.erb: Added.
Add scripts and template to generate WebPreferencesDefinitions.h from
WebPreferences.yaml.
- Shared/WebPreferences.yaml: Added.
Configuration file for preferences.
- Shared/WebPreferencesDefinitions.h: Removed.
- Shared/WebPreferencesDefinitionsBase.h: Copied from Source/WebKit/Shared/WebPreferencesDefinitions.h.
Moved custom defaults to new WebPreferencesDefinitionsBase.h. Removed the need for
FOR_EACH_WEBKIT_STRING_PREFERENCE by using custom defaults for the font family values.
- 11:40 AM Changeset in webkit [223902] by
-
- 3 edits in trunk/Source/WebCore
[MediaFoundation] Videos are always autoplaying for local files
https://bugs.webkit.org/show_bug.cgi?id=178693
Patch by Doug Massay.
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2017-10-24
Reviewed by Alex Christensen.
r199114 fixes autoplay issue only if starting session invokes
buffering stage. However when local files are played, onBufferingStarted
and onBufferingStopped are not called, and video is not paused.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::onSessionStarted):
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
- 11:19 AM Changeset in webkit [223901] by
-
- 1 edit2 copies1 delete in trunk
[Regression] Webkit "-apple-system" font fallback token handles font weights of PingFang incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=177345
<rdar://problem/32975942>
Unreviewed fix to move tests into LayoutTests.
If these tests start failing, please roll out this commit and
r223589.
- fast/text/system-ui-chinese-bold-fallback-expected.html: Renamed from fast/text/system-ui-chinese-bold-fallback-expected.html.
- fast/text/system-ui-chinese-bold-fallback.html: Renamed from fast/text/system-ui-chinese-bold-fallback.html.
- 11:14 AM Changeset in webkit [223900] by
-
- 20 edits1 delete in trunk/Source
Unreviewed, rolling out r223889.
This caused multiple crashes on all platforms
Reverted changeset:
"Adopt new secure coding APIs"
https://bugs.webkit.org/show_bug.cgi?id=178484
https://trac.webkit.org/changeset/223889
- 11:04 AM Changeset in webkit [223899] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening. Improved attempt to reduce flakiness of inspector/network/har tests.
- http/tests/inspector/network/har/har-page-expected.txt:
- http/tests/inspector/network/har/har-page.html:
Earlier filters were taking affect, so move these checks up.
- 10:50 AM Changeset in webkit [223898] by
-
- 8 edits in trunk
Create inline wrappers for before/after pseudo elements that have display:contents
https://bugs.webkit.org/show_bug.cgi?id=178722
Reviewed by Ryosuke Niwa.
Source/WebCore:
We can handle before and after pseudo elements with display:contents by giving them
inline renderers with style inherited from display:contents style. This removes
need for complicated logic for this case and handles everything correctly.
This is a better approach and replaces the one taken in bug 178584.
It also fixes two display:contents WPTs.
- dom/PseudoElement.h:
There is no need to track content renderers separately anymore. They always descendants of
pseudo element's renderer (which is an inline wrapper in case of display:contents).
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::copyContentFrom):
- rendering/style/RenderStyle.h:
- style/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::createContentRenderers):
(WebCore::updateStyleForContentRenderers):
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
(WebCore::removeAndDestroyContentRenderers): Deleted.
Since content renderers are now always descendants of the pseudo renderer
there is no need for a separate destruction path.
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolvePseudoStyle):
Create ElementUpdate with a style that will produce an inline wrapper.
LayoutTests:
Enable
imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-first-letter-001.html and
imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-001.html
- 10:49 AM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 10:38 AM Changeset in webkit [223897] by
-
- 2 edits in trunk/Source/WebCore
[iOS] MediaPlayer::isAvailable() takes ~150 ms during web process initialization
https://bugs.webkit.org/show_bug.cgi?id=178713
<rdar://problem/35115906>
Reviewed by Eric Carlson.
Loading AVFoundation should not be required to answer the question of MediaPlayer::isAvailable() on iOS, where
both AVFoundation and CoreMedia frameworks should always exist. As such, we can bail early and return true to
avoid always dynamically loading AVFoundation and CoreMedia.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::isAvailable):
- 10:32 AM Changeset in webkit [223896] by
-
- 2 edits in trunk/Source/WebCore
RenderThemeCocoa::mediaControlsFormattedStringForDuration may cause a crash due to unhandled Obj-C exception
https://bugs.webkit.org/show_bug.cgi?id=178716
<rdar://problem/35112900>
Patch by Antoine Quint <Antoine Quint> on 2017-10-24
Reviewed by Dean Jackson.
- rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::mediaControlsFormattedStringForDuration):
- 10:24 AM Changeset in webkit [223895] by
-
- 3 edits in trunk
SizesAttributeParser::SizesAttributeParser triggers layout
https://bugs.webkit.org/show_bug.cgi?id=178712
Reviewed by Antti Koivisto.
Revert r213711 as this change introduced an unwated synchronous layout inside Node::insertedIntoAncestor.
The test had been marked as timing out since r191379 and changed to failing expectation in r199225
as the test result's error message changes from run to run.
Disabled Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change.html
had been marked failing since r199225, prior to which it was marked as timeout in r191379.
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute.html
is now marked as flaky.
- css/parser/SizesAttributeParser.cpp:
(WebCore::SizesAttributeParser::SizesAttributeParser):
- 10:11 AM Changeset in webkit [223894] by
-
- 4 edits in trunk
[JSC] modules can be visited more than once when resolving bindings through "star" exports as long as the exportName is different each time
https://bugs.webkit.org/show_bug.cgi?id=178308
Reviewed by Mark Lam.
JSTests:
- test262.yaml:
Source/JavaScriptCore:
With the change of the spec[1], we now do not need to remember star resolution modules.
We reflect this change to our implementation. Since this change is covered by test262,
this patch improves the score of test262.
We also add logging to ResolveExport to debug it easily.
[1]: https://github.com/tc39/ecma262/commit/a865e778ff0fc60e26e3e1c589635103710766a1
- runtime/AbstractModuleRecord.cpp:
(JSC::AbstractModuleRecord::ResolveQuery::dump const):
(JSC::AbstractModuleRecord::resolveExportImpl):
- 10:05 AM Changeset in webkit [223893] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix internal iOS build.
- Sources.txt:
- 9:42 AM Changeset in webkit [223892] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Use emitDumbVirtualCall in 32bit JIT
https://bugs.webkit.org/show_bug.cgi?id=178644
Reviewed by Mark Lam.
This patch aligns 32bit JIT op_call_eval slow case to 64bit version by using emitDumbVirtualCall.
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
- 9:36 AM Changeset in webkit [223891] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] Drop ArityCheckData
https://bugs.webkit.org/show_bug.cgi?id=178648
Reviewed by Mark Lam.
ArityCheckData is used to return a pair of
slotsToAddandthunkToCall.
However, use ofthunkToCallis removed in 64bit environment at r189575.
We remove
thunkToCalland align 32bit implementation to 64bit implementation.
Since we no longer need to have the above pair, we can remove ArityCheckData too.
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
(JSC::setupArityCheckData): Deleted.
- runtime/CommonSlowPaths.h:
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 9:33 AM Changeset in webkit [223890] by
-
- 2 edits in trunk/Source/WebKit
ASSERTION FAILED: !m_serviceWorkerManager in WebProcess::getWorkerContextConnection() on API tests
https://bugs.webkit.org/show_bug.cgi?id=178586
<rdar://problem/35115902>
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-24
Reviewed by Brady Eidson.
Covered by API tests no longer crashing.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::getWorkerContextProcessConnection): Sending a worker context process connection message only at creation of the service worker process.
- 9:21 AM Changeset in webkit [223889] by
-
- 20 edits1 add in trunk/Source
Adopt new secure coding APIs
https://bugs.webkit.org/show_bug.cgi?id=178484
<rdar://problem/34837193>
Reviewed by Tim Horton.
Source/WebCore:
Switch to new NSKeyed[Un]Archiver methods that active and use
NSSecureCoding by default.
Most of the new API is wrapped in a set of convenience methods so we can
build without the new API on older systems.
No change in behavior.
- editing/cocoa/EditorCocoa.mm:
(WebCore::archivedDataForAttributedString): Use new convenience method
to archive the string object.
- loader/archive/cf/LegacyWebArchiveMac.mm:
(WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Update to
use secure coding where possible.
(WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write): Use new secure API.
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const): Ditto.
- testing/cocoa/WebArchiveDumpSupport.mm:
(WebCoreTestSupport::createCFURLResponseFromResponseData): Update to
secure coding API where possible.
Source/WebCore/PAL:
Add new convenience methods (and SPI headers) so we can adopt new NSKeyedArchiver
API that uses secure coding by default.
- PAL.xcodeproj/project.pbxproj:
- pal/spi/cocoa/NSKeyedArchiverSPI.h: Added.
(securelyArchivedDataWithRootObject): New convenience method.
(securelyUnarchiveRootObjectOfClassFromData): Ditto.
(secureArchiverFromMutableData): Ditto.
(secureUnarchiverFromData): Ditto.
Source/WebKit:
Switch to new NSKeyed[Un]Archiver methods that active and use
NSSecureCoding by default.
- Platform/ios/AccessibilityIOS.mm:
(WebKit::newAccessibilityRemoteToken): Use secure-by-default API.
- Shared/Cocoa/DataDetectionResult.mm:
(WebKit::DataDetectionResult::encode const): Ditto.
(WebKit::DataDetectionResult::decode): Ditto.
- Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::ArgumentCoder<WebCore::Payment>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::Payment>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentContact>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentContact>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMethod>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMethod>::decode): Ditto.
- Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode const): Ditto.
(WebKit::InteractionInformationAtPosition::decode): Ditto.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::decode): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::decodePlatformData): Ditto.
- Shared/mac/WebHitTestResultData.mm:
(WebKit::WebHitTestResultData::platformEncode const): Ditto.
(WebKit::WebHitTestResultData::platformDecode): Ditto.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _setObject:forBundleParameter:]): Ditto.
(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]): Ditto.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setInputDelegate:]): Ditto.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess): Ditto.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::startAssistingNode): Ditto.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Ditto.
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::initialize): Ditto.
(WebKit::InjectedBundle::setBundleParameter): Ditto.
(WebKit::InjectedBundle::setBundleParameters): Ditto.
- 7:14 AM Changeset in webkit [223888] by
-
- 2 edits in trunk/LayoutTests
Mark fast/css-generated-content/details-summary-before-after.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=178724
Unreviewed test gardening.
- platform/win/TestExpectations:
- 5:06 AM Changeset in webkit [223887] by
-
- 3 edits in trunk/Source/WebCore
[GTK][X11] Windy.com shows always straight wind lines
https://bugs.webkit.org/show_bug.cgi?id=176718
Reviewed by Carlos Garcia Campos.
WebGL's GL_LUMINANCE_ALPHA format is not available in OpenGL when using a version >= 3.2
and a core profile. In that case, we need to replace it with GL_RG and swizzle the color
components appropriately.
No new behavior.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::texSubImage2D):
- 1:54 AM Changeset in webkit [223886] by
-
- 2 edits in trunk/Source/WebCore
DocumentOrderedMap::add should release assert that tree scopes match
https://bugs.webkit.org/show_bug.cgi?id=178708
Reviewed by Antti Koivisto.
Assert that the tree scope of element matches the given tree scope instead of asserting that
element is in tree scope, and replaced the use of RELEASE_ASSERT by the newly added
RELEASE_ASSERT_WITH_SECURITY_IMPLICATION to clarify the semantics of these assertions.
Also removed now redudnant early exits which would never execute due to release assertions.
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::remove):
(WebCore::DocumentOrderedMap::get const):
- 1:38 AM Changeset in webkit [223885] by
-
- 2 edits in trunk/Source/WebCore
-Wsubobject-linkage warning in InspectorIndexedDBAgent.cpp
https://bugs.webkit.org/show_bug.cgi?id=178698
Reviewed by Joseph Pecoraro.
- inspector/InspectorIndexedDBAgent.cpp:
- 1:20 AM Changeset in webkit [223884] by
-
- 3 edits in trunk/Source/WebKit
[GTK][WPE] generate-forwarding-headers.pl should also scan derived sources in WebKit framework
https://bugs.webkit.org/show_bug.cgi?id=178579
Reviewed by Carlos Garcia Campos.
- PlatformGTK.cmake: When generating forwarding headers, derived sources
should be scanned as well. The DERIVED_SOURCES_WEBKIT_DIR value has to
be passed as an include path to the generate-forward-headers.pl script
to achieve that. This target then also has to depend on all the derived
source files to be generated before this can be performed.
- PlatformWPE.cmake: Ditto.
- 12:51 AM Changeset in webkit [223883] by
-
- 10 edits10 copies12 adds in trunk
[Web Animations] Add basic timing and target properties
https://bugs.webkit.org/show_bug.cgi?id=178674
Patch by Antoine Quint <Antoine Quint> on 2017-10-24
Reviewed by Dean Jackson.
Source/WebCore:
We add three new interfaces to expose enough properties to establish basic timing properties,
a start time and duration, and the target of an animation. The startTime property is set on
the Animation object, the target is set on the KeyframeEffect set as the effect property on
the Animation object, and the duration is set on the AnimationEffectTiming set on the effect.
Tests: webanimations/animation-effect-timing.html
webanimations/animation-effect.html
webanimations/animation-interface-effect-property.html
webanimations/animation-interface-start-time-property.html
webanimations/keyframe-effect-interface-timing-duration.html
webanimations/keyframe-effect.html
- CMakeLists.txt:
- DerivedSources.make:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- animation/AnimationEffect.cpp: Copied from Source/WebCore/animation/WebAnimation.idl.
(WebCore::AnimationEffect::AnimationEffect):
(WebCore::AnimationEffect::~AnimationEffect):
- animation/AnimationEffect.h: Copied from Source/WebCore/animation/WebAnimation.h.
(WebCore::AnimationEffect::isKeyframeEffect const):
(WebCore::AnimationEffect::timing const):
(WebCore::AnimationEffect::classType const):
- animation/AnimationEffect.idl: Copied from Source/WebCore/animation/WebAnimation.idl.
- animation/AnimationEffectTiming.cpp: Copied from Source/WebCore/animation/WebAnimation.idl.
(WebCore::AnimationEffectTiming::create):
(WebCore::AnimationEffectTiming::AnimationEffectTiming):
(WebCore::AnimationEffectTiming::~AnimationEffectTiming):
- animation/AnimationEffectTiming.h: Copied from Source/WebCore/animation/WebAnimation.h.
- animation/AnimationEffectTiming.idl: Copied from Source/WebCore/animation/WebAnimation.idl.
- animation/KeyframeEffect.cpp: Copied from Source/WebCore/animation/WebAnimation.idl.
(WebCore::KeyframeEffect::create):
(WebCore::KeyframeEffect::KeyframeEffect):
- animation/KeyframeEffect.h: Copied from Source/WebCore/animation/WebAnimation.h.
- animation/KeyframeEffect.idl: Copied from Source/WebCore/animation/WebAnimation.idl.
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::setEffect):
- animation/WebAnimation.h:
- animation/WebAnimation.idl:
- bindings/js/JSAnimationEffectCustom.cpp: Copied from Source/WebCore/animation/WebAnimation.cpp.
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
- bindings/js/WebCoreBuiltinNames.h:
LayoutTests:
Add new tests to check the behavior of the newly exposed interfaces,
constructors and properties.
- webanimations/animation-effect-expected.txt: Added.
- webanimations/animation-effect-timing-expected.txt: Added.
- webanimations/animation-effect-timing.html: Added.
- webanimations/animation-effect.html: Added.
- webanimations/animation-interface-effect-property-expected.txt: Added.
- webanimations/animation-interface-effect-property.html: Added.
- webanimations/animation-interface-start-time-property-expected.txt: Added.
- webanimations/animation-interface-start-time-property.html: Added.
- webanimations/keyframe-effect-expected.txt: Added.
- webanimations/keyframe-effect-interface-timing-duration-expected.txt: Added.
- webanimations/keyframe-effect-interface-timing-duration.html: Added.
- webanimations/keyframe-effect.html: Added.
- 12:41 AM Changeset in webkit [223882] by
-
- 3 edits in trunk/Source/WebCore
RenderSVGModelObject::checkIntersection triggers layout
https://bugs.webkit.org/show_bug.cgi?id=178710
Reviewed by Antti Koivisto.
Don't trigger a layout inside getElementCTM. Update the layout upfront in getEnclosureList.
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::getElementCTM):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::getEnclosureList):
- 12:25 AM Changeset in webkit [223881] by
-
- 3 edits2 adds in trunk
AX: Crash at -[WebAccessibilityObjectWrapper _accessibilityMinValue] + 24
https://bugs.webkit.org/show_bug.cgi?id=178697
Reviewed by Chris Fleizach.
Source/WebCore:
When we are calling _accessibilityMinValue and _accessibilityMaxValue on iOS,
it might cause crash if the AX object has already been detached. Fixed this
by adding the necessary checks.
Test: accessibility/ios-simulator/slider-min-value-crash.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper _accessibilityMinValue]):
(-[WebAccessibilityObjectWrapper _accessibilityMaxValue]):
LayoutTests:
- accessibility/ios-simulator/slider-min-value-crash-expected.txt: Added.
- accessibility/ios-simulator/slider-min-value-crash.html: Added.
Oct 23, 2017:
- 10:13 PM Changeset in webkit [223880] by
-
- 6 edits in trunk/Source/WebKit
[Cocoa] Web Automation: add SPI to tell whether the automation session is currently simulating user interactions
https://bugs.webkit.org/show_bug.cgi?id=178616
Reviewed by Joseph Pecoraro.
This is needed to disambiguate whether an action (such as selectAll:) came from
a user clicking on "Edit > Select All" in a menu or whether it was produced by
simulating the keystrokes to produce the chord for "Command + a". Some clients,
such as Safari, would allow the latter but not the former during automation.
- UIProcess/API/Cocoa/_WKAutomationSession.h:
- UIProcess/API/Cocoa/_WKAutomationSession.mm:
(-[_WKAutomationSession isSimulatingUserInteraction]):
Add new SPI property that's backed by the same WebAutomationSession method.
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::keyboardEventsFlushedForPage):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
Set m_simulatingUserInteraction prior to sending the synthesized events. It will
be cleared when keyboardEventsFlushedForPage() is called by WebPageProxy.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveEvent):
Notify the automation session that the key event queue was flushed *after* giving
delegates a chance to do something with the key event. This is necessary so that
any actions that are created from the NSEvent by the delegates are handled prior
to the automation session finishing its keyboard interaction command.
- 9:23 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 9:21 PM Changeset in webkit [223879] by
-
- 2 edits in trunk/LayoutTests
Unreviewed WPE test gardening
- platform/wpe/TestExpectations:
- 9:17 PM Changeset in webkit [223878] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, restore unneeded all in ones.
- CMakeLists.txt:
- 8:32 PM Changeset in webkit [223877] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed, roll out r222731
https://bugs.webkit.org/show_bug.cgi?id=177745
<rdar://problem/34773148>
Unfortunately Gigacage has broken core dump generation.
- bmalloc/Gigacage.h:
- 8:26 PM Changeset in webkit [223876] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r223870 and r223871.
https://bugs.webkit.org/show_bug.cgi?id=178702
broke the windows build (Requested by keith_miller on
#webkit).
Reverted changesets:
"Add html, inspector, loader to unified sources"
https://bugs.webkit.org/show_bug.cgi?id=178695
https://trac.webkit.org/changeset/223870
"Unrievwed, fix windows build."
https://trac.webkit.org/changeset/223871
- 8:20 PM Changeset in webkit [223875] by
-
- 19 edits in trunk/Source/JavaScriptCore
Unreviewed, reland r223866
Didn't break the windows build...
Restored changeset:
"WebAssembly: topEntryFrame on Wasm::Instance"
https://bugs.webkit.org/show_bug.cgi?id=178690
https://trac.webkit.org/changeset/223866
- 7:33 PM Changeset in webkit [223874] by
-
- 19 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r223866.
https://bugs.webkit.org/show_bug.cgi?id=178699
Probably broke the windows build (Requested by keith_miller on
#webkit).
Reverted changeset:
"WebAssembly: topEntryFrame on Wasm::Instance"
https://bugs.webkit.org/show_bug.cgi?id=178690
https://trac.webkit.org/changeset/223866
- 6:44 PM Changeset in webkit [223873] by
-
- 3 edits in trunk/LayoutTests
Unreviewed test gardening. Try to reduce flakiness of inspector/network/har tests.
- http/tests/inspector/network/har/har-page-expected.txt:
- http/tests/inspector/network/har/har-page.html:
Remove properties which may sometimes be optional.
Filter contents which are shared across tests and might change.
- 6:42 PM Changeset in webkit [223872] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, attempt to fix initializeSupportedImageMIMETypes after r223860
https://bugs.webkit.org/show_bug.cgi?id=178618
<rdar://problem/35108852>
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 6:31 PM Changeset in webkit [223871] by
-
- 2 edits in trunk/Source/WebCore
Unrievwed, fix windows build.
- CMakeLists.txt:
- 6:25 PM Changeset in webkit [223870] by
-
- 4 edits in trunk/Source/WebCore
Add html, inspector, loader to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178695
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 6:16 PM Changeset in webkit [223869] by
-
- 3 edits in trunk/Source/WebKit
[Mac] Web Automation: key modifiers for synthesized NSEvents are incorrect
https://bugs.webkit.org/show_bug.cgi?id=178615
Reviewed by Joseph Pecoraro.
In both PLATFORM(MAC) platform methods for simulating keyboard interactions,
we errantly relied on +[NSEvent modifierFlags] to get the current state of
sticky modifiers when creating synthesized events. This is incorrect for two reasons:
modifierFlags is never updated when simulating a sequence of events (because
all the events are synthesized before any are delivered); and the NSEvent class
method only reflects the modifier state of the primary physical keyboard, which
is not affected by synthesized NSEvents that happen to have modifier flags.
Instead, just keep our own m_currentModifiers state in the session and compute
the necessary NSEventModifierFlags to put on each synthesized event. This aligns
the implementation with the treatment of sticky keys in the iOS and GTK platform methods.
- UIProcess/Automation/WebAutomationSession.h: Every port gets this variable now.
- UIProcess/Automation/mac/WebAutomationSessionMac.mm:
(WebKit::WebAutomationSession::platformSimulateKeyStroke):
(WebKit::WebAutomationSession::platformSimulateKeySequence):
Use and update m_currentModifiers.
- 5:55 PM Changeset in webkit [223868] by
-
- 14 edits2 deletes in trunk/Source
Web Inspector: Remove unused Console.setMonitoringXHREnabled
https://bugs.webkit.org/show_bug.cgi?id=178617
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-23
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- inspector/agents/InspectorConsoleAgent.h:
- inspector/agents/JSGlobalObjectConsoleAgent.cpp: Removed.
- inspector/agents/JSGlobalObjectConsoleAgent.h: Removed.
- inspector/protocol/Console.json:
Removed files and method.
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
This can use the base ConsoleAgent now.
Source/WebCore:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
- inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::setMonitoringXHREnabled): Deleted.
(WebCore::WebConsoleAgent::didFinishXHRLoading): Deleted.
- inspector/WebConsoleAgent.h:
Remove XHR monitoring code.
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber): Deleted.
- xml/XMLHttpRequest.idl:
Remove now unused state on XHR and ExecState requirement for send().
- 5:35 PM Changeset in webkit [223867] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
https://bugs.webkit.org/show_bug.cgi?id=178638
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
Blur event on the property name text field caused WI.SpreadsheetStyleProperty.prototype._renderValue,
which displayed inline swatches. Display inline swatches only after blur event on the property value.
- 5:29 PM Changeset in webkit [223866] by
-
- 19 edits in trunk/Source/JavaScriptCore
WebAssembly: topEntryFrame on Wasm::Instance
https://bugs.webkit.org/show_bug.cgi?id=178690
Reviewed by Saam Barati.
topEntryFrame is usually on VM, but for a no-VM WebAssembly we
need to hold topEntryFrame elsewhere, and generated code cannot
hard-code where topEntryFrame live. Do this at creation time of
Wasm::Instance, and then generated code will just load from
wherever Wasm::Instance was told topEntryFrame is. In a JavaScript
embedding this is still from VM, so all of the unwinding machinery
stays the same.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::copyCalleeSavesToEntryFrameCalleeSavesBuffer const):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::restoreCalleeSavesFromEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBufferImpl):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::copyCalleeSavesToEntryFrameCalleeSavesBuffer):
The default parameter was never non-defaulted from any of the
callers. The new version calls the impl directly because it
doesn't have VM and doesn't hard-code the address of
topEntryFrame.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::vmCalleeSaveRegisterOffsets): This was weird on
VM because it's not really VM-specific.
- jit/RegisterSet.h:
- runtime/VM.cpp:
(JSC::VM::getAllCalleeSaveRegisterOffsets): Deleted.
- runtime/VM.h:
(JSC::VM::getCTIStub):
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addCall):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
- wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
- wasm/WasmInstance.h: topEntryFramePointer will eventually live
here for real. Right now it's mirrored in JSWebAssemblyInstance
because that's the acting Context.
(JSC::Wasm::Instance::create):
(JSC::Wasm::Instance::offsetOfTopEntryFramePointer):
- wasm/WasmThunks.cpp:
(JSC::Wasm::throwExceptionFromWasmThunkGenerator):
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::JSWebAssemblyInstance):
- wasm/js/JSWebAssemblyInstance.h: Mirror Wasm::Instance temporarily.
(JSC::JSWebAssemblyInstance::offsetOfCallee):
(JSC::JSWebAssemblyInstance::offsetOfTopEntryFramePointer):
(JSC::JSWebAssemblyInstance::offsetOfVM): Deleted.
- wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
- wasm/js/WebAssemblyPrototype.cpp:
(JSC::instantiate):
- 5:27 PM Changeset in webkit [223865] by
-
- 4 edits in trunk/Source/WebCore
Add dom, editing, fileapi, and history to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178694
Rubber-stamped by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 5:22 PM Changeset in webkit [223864] by
-
- 4 edits in trunk/Websites/perf.webkit.org
Update perf dashboard upload logic to support uploading binaries from owned commits.
https://bugs.webkit.org/show_bug.cgi?id=178610
Reviewed by Ryosuke Niwa.
Update build requests to 'completed' only when all commit set items are satisfied.
Extend 'repositoryList' parameter to be able to specified own commit information.
Items in 'repositoryList' can either be a string for top level repository,
or a dictionary with two keys: 'ownerRepository' and 'ownedRepository'.
- public/api/upload-root.php: Extend upload logic for support uploading binaries from owned commits.
- server-tests/api-upload-root-tests.js: Added unit tests.
- server-tests/tools-sync-buildbot-integration-tests.js: Added unit tests.
- 5:08 PM Changeset in webkit [223863] by
-
- 4 edits in trunk/Source/WebCore
Move bridge, contentextensions, crypto, and css to unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178691
Reviewed by Tim Horton.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 4:40 PM Changeset in webkit [223862] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the Windows build after r223860
UTIUtilities only exists on Cocoa platforms, so we need to guard it accordingly.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
- 4:23 PM Changeset in webkit [223861] by
-
- 2 edits in trunk/Source/WebKit
Fix ASAN test after r222824
https://bugs.webkit.org/show_bug.cgi?id=178688
<rdar://problem/35104706>
Reviewed by Tim Horton.
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::clear):
Resizing a list of Ref<T> after we've WTFMoved all the elements doesn't make ASAN happy.
- 4:17 PM AddingFiles edited by
- (diff)
- 4:12 PM AddingFiles edited by
- (diff)
- 4:11 PM AddingFiles edited by
- (diff)
- 4:03 PM AddingFiles edited by
- (diff)
- 3:37 PM Changeset in webkit [223860] by
-
- 3 edits in trunk/Source/WebCore
[iOS] DocumentWriter::createDocument can spend ~100ms unnecessarily converting image UTIs to MIME types
https://bugs.webkit.org/show_bug.cgi?id=178618
<rdar://problem/35108852>
Reviewed by Said Abou-Hallawa.
Currently, in setting up a new Document, DocumentWriter::createDocument() always asks whether or not the
Document should be a PDF document by calling MIMETypeRegistry::isPDFMIMEType(), which forces lazy initialization
of every MIME type dictionary (e.g. image types, PDF types, JavaScript types, etc.). As evidenced by traces,
this can be an expensive operation on certain devices.
This patch implements two optimizations. First, we refactor the initializeSupportedImageMIMETypes() helper to
stop asking for MIMETypeForImageSourceType for each of the supported UTIs. This is because the known MIME types
corresponding to these hard-coded UTI types is a fixed set anyways, so we can simply iterate over a constant
array of MIME types and populate the supported image (and image resource) types. Also, add assertions to ensure
that we keep allowed image MIME types in sync with allowed image UTIs.
The second optimization removes initializeMIMETypeRegistry() altogether in favor of calling just the
initialize*MIMETypes() functions needed to ensure the information required. For instance, getPDFMIMETypes()
currently calls initializeMIMETypeRegistry() if the pdfMIMETypes dictionary doesn't exist, when it really only
needs to ensure that the pdfMIMETypes is initialized, for which initializePDFMIMETypes() is sufficient.
- platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedJavaScriptMIMETypes):
(WebCore::initializePDFMIMETypes):
(WebCore::initializeSupportedNonImageMimeTypes):
(WebCore::initializeUnsupportedTextMIMETypes):
Move MIME type dictionary creation into initialize*MIMETypes() helpers. Additionally, remove
initializePDFAndPostScriptMIMETypes, which is no longer necessary.
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
(WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
(WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
(WebCore::MIMETypeRegistry::isUnsupportedTextMIMEType):
(WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType):
Tweak to check that the type isPDFMIMEType(), or that it's otherwise "application/postscript".
(WebCore::MIMETypeRegistry::isPDFMIMEType):
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes):
(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes):
(WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes):
(WebCore::MIMETypeRegistry::getPDFMIMETypes):
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes):
Call only the relevant MIME type initializers when needed.
(WebCore::initializePostScriptMIMETypes): Deleted.
(WebCore::initializeMIMETypeRegistry): Deleted.
(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Deleted.
Remove an unused and unexported function.
- platform/MIMETypeRegistry.h:
- 3:30 PM Changeset in webkit [223859] by
-
- 2 edits in trunk/LayoutTests
Multiple imported layout tests are crashing and timing out.
https://bugs.webkit.org/show_bug.cgi?id=178685
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
- TestExpectations: skipping cache storage tests in service worker context until it is functional.
- 3:14 PM Changeset in webkit [223858] by
-
- 2 edits in trunk/Source/WebCore
[Payment Request] Take the JSC API lock before creating the PaymentResponse.details object
https://bugs.webkit.org/show_bug.cgi?id=178686
Reviewed by Keith Miller.
This fixes several flaky crashes in http/tests/paymentrequest/ after r223855.
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::didAuthorizePayment):
- 2:58 PM Changeset in webkit [223857] by
-
- 3 edits in trunk/Source/WebKit
Stop using _UIApplicationUsesLegacyUI()
https://bugs.webkit.org/show_bug.cgi?id=178680
<rdar://problem/35131949>
Reviewed by Dan Bernstein.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectPopover initWithView:hasGroups:]):
Resolve _UIApplicationUsesLegacyUI to false and simplify.
- 2:34 PM Changeset in webkit [223856] by
-
- 22 edits6 adds in trunk
Web Inspector: Please support HAR Export for network traffic
https://bugs.webkit.org/show_bug.cgi?id=146692
<rdar://problem/7463672>
Reviewed by Brian Burg.
Source/JavaScriptCore:
- inspector/protocol/Network.json:
Add a walltime to each send request.
Source/WebCore:
Tests: http/tests/inspector/network/har/har-basic.html
http/tests/inspector/network/har/har-page.html
- inspector/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::willSendRequest):
Include the wall time when sending a request. This is needed for HAR to
include a wall time, and can be used for Cookie expiration time calculation
as well.
Source/WebInspectorUI:
- UserInterface/Main.html:
- UserInterface/Test.html:
New resources.
- UserInterface/Base/Platform.js:
Include a build number as well.
- UserInterface/Base/URLUtilities.js:
(parseLocationQueryParameters): Deleted.
Remove unused function.
- UserInterface/Controllers/FrameResourceManager.js:
(WI.FrameResourceManager.prototype.frameDidNavigate):
(WI.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WI.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
(WI.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
(WI.FrameResourceManager.prototype._addNewResourceToFrameOrTarget):
Pass along a walltime.
- UserInterface/Protocol/NetworkObserver.js:
(WI.NetworkObserver.prototype.requestWillBeSent):
Pass along a walltime. This new parameter shifts old parameters.
- UserInterface/Controllers/HARBuilder.js: Added.
(WI.HARBuilder.async.buildArchive):
(WI.HARBuilder.creator):
(WI.HARBuilder.pages):
(WI.HARBuilder.pageTimings):
(WI.HARBuilder.entry):
(WI.HARBuilder.request):
(WI.HARBuilder.response):
(WI.HARBuilder.cookies):
(WI.HARBuilder.headers):
(WI.HARBuilder.content):
(WI.HARBuilder.postData):
(WI.HARBuilder.cache):
(WI.HARBuilder.timings):
(WI.HARBuilder.ipAddress):
(WI.HARBuilder.date):
(WI.HARBuilder.fetchType):
HAR construction and helpers.
- UserInterface/Models/Cookie.js:
(WI.Cookie.prototype.expirationDate):
- UserInterface/Models/Resource.js:
(WI.Resource.prototype.get queryStringParameters):
(WI.Resource.prototype.get requestFormParameters):
(WI.Resource.prototype.get requestSentWalltime):
(WI.Resource.prototype.get requestSentDate):
(WI.Resource.prototype.hasRequestFormParameters):
Helpers for HAR generation and sub-sets of data.
- UserInterface/Models/SourceCode.js:
(WI.SourceCode.prototype._processContent):
Capture the raw, unmodified, base64 encoded flag and content. This ends
up getting used by HAR generation and is otherwise lost.
- UserInterface/Test/TestHarness.js:
(TestHarness.prototype.json):
Helper for just logging JSON data with a filter. This defaults to
a reasonable 2 space indent for JSON logs in our test output.
- UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype.get saveData):
(WI.DOMTreeContentView.get saveData.saveHandler): Deleted.
Drive-by simplify while looking at other save handlers.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.get supportsSave):
(WI.NetworkTableContentView.prototype.get saveData):
(WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
(WI.NetworkTableContentView.prototype._HARResources):
(WI.NetworkTableContentView.prototype._exportHAR):
Provide a context menu and save keyboard handler to export a HAR.
This matches other browsers.
- UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype._canShowRequestContentView):
Use code that is now available in Resource.
LayoutTests:
- http/tests/inspector/network/har/har-basic-expected.txt: Added.
- http/tests/inspector/network/har/har-basic.html: Added.
- http/tests/inspector/network/har/har-page-expected.txt: Added.
- http/tests/inspector/network/har/har-page.html: Added.
Tests with mock resources / data and real resources.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
Skip on platforms that cannot provide complete metrics, so some optional
fields may be missing.
- 2:00 PM Changeset in webkit [223855] by
-
- 23 edits6 copies14 adds in trunk
[Payment Request] Resolve PaymentRequest.show()'s accept promise when a payment is authorized
https://bugs.webkit.org/show_bug.cgi?id=178609
<rdar://problem/33542813>
Reviewed by Alex Christensen.
Source/WebCore:
This patch implements the logic for resolving PaymentRequest.show()'s accept promise when
the user authorizes a payment, and implements PaymentResponse.complete().
Tests: http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html
http/tests/paymentrequest/payment-response-complete-method.https.html
http/tests/paymentrequest/payment-response-methodName-attribute.https.html
http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html
http/tests/paymentrequest/payment-response-payerName-attribute.https.html
http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html
- DerivedSources.make:
- Modules/applepay/ApplePayPaymentContact.h:
- Modules/applepay/Payment.h:
(WebCore::Payment::Payment): Deleted.
(WebCore::Payment::pkPayment const): Deleted.
- Modules/applepay/PaymentContact.h:
(WebCore::PaymentContact::PaymentContact): Deleted.
(WebCore::PaymentContact::pkContact const): Deleted.
- Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::convert):
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:
(WebCore::ApplePayPaymentHandler::hasActiveSession):
(WebCore::ApplePayPaymentHandler::ApplePayPaymentHandler):
(WebCore::ApplePayPaymentHandler::document):
(WebCore::ApplePayPaymentHandler::paymentCoordinator):
(WebCore::ApplePayPaymentHandler::convertData):
(WebCore::ApplePayPaymentHandler::show):
(WebCore::ApplePayPaymentHandler::hide):
(WebCore::ApplePayPaymentHandler::canMakePayment):
(WebCore::ApplePayPaymentHandler::complete):
(WebCore::convert):
(WebCore::ApplePayPaymentHandler::didAuthorizePayment):
(WebCore::ApplePayPaymentHandler::didSelectShippingMethod):
(WebCore::ApplePayPaymentHandler::didSelectShippingContact):
- Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
- Modules/paymentrequest/PaymentAddress.h:
- Modules/paymentrequest/PaymentAddress.idl:
- Modules/paymentrequest/PaymentHandler.cpp:
(WebCore::PaymentHandler::create):
- Modules/paymentrequest/PaymentHandler.h:
- Modules/paymentrequest/PaymentRequest.cpp:
(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::stop):
(WebCore::PaymentRequest::canMakePayment):
(WebCore::PaymentRequest::canSuspendForDocumentSuspension const):
(WebCore::PaymentRequest::shippingAddressChanged):
(WebCore::PaymentRequest::shippingOptionChanged):
(WebCore::PaymentRequest::accept):
(WebCore::PaymentRequest::complete):
- Modules/paymentrequest/PaymentRequest.h:
- Modules/paymentrequest/PaymentResponse.cpp:
(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::complete):
- Modules/paymentrequest/PaymentResponse.h:
- WebCore.xcodeproj/project.pbxproj:
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::mockPaymentCoordinator const):
- testing/Internals.h:
- testing/Internals.idl:
- testing/MockPayment.h: Added.
- testing/MockPaymentAddress.h: Added.
- testing/MockPaymentAddress.idl: Added.
- testing/MockPaymentContact.h: Added.
- testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::canMakePaymentsWithActiveCard):
(WebCore::MockPaymentCoordinator::openPaymentSetup):
(WebCore::dispatchIfShowing):
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeMerchantValidation):
(WebCore::MockPaymentCoordinator::completePaymentSession):
(WebCore::MockPaymentCoordinator::abortPaymentSession):
(WebCore::MockPaymentCoordinator::cancelPaymentSession):
(WebCore::MockPaymentCoordinator::paymentCoordinatorDestroyed):
- testing/MockPaymentCoordinator.h:
- testing/MockPaymentCoordinator.idl: Added.
LayoutTests:
- http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https-expected.txt: Added.
- http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html: Copied from imported/w3c/web-platform-tests/payment-request/PaymentAddress/attributes-and-toJSON-method-manual.https.html.
- http/tests/paymentrequest/payment-response-complete-method.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-complete-method.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/complete-method-manual.https.html.
- http/tests/paymentrequest/payment-response-methodName-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-methodName-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/methodName-attribute-manual.https.html.
- http/tests/paymentrequest/payment-response-payerEmail-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/payerEmail-attribute-manual.https.html.
- http/tests/paymentrequest/payment-response-payerName-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-payerName-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/payerName-attribute-manual.https.html.
- http/tests/paymentrequest/payment-response-payerPhone-attribute.https-expected.txt: Added.
- http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/payerPhone-attribute-manual.https.html.
- http/tests/paymentrequest/resources/helpers.js: Copied from imported/w3c/web-platform-tests/payment-request/payment-response/helpers.js.
(test):
(async.getPaymentResponse):
(async.getPaymentRequestResponse):
(async.runTest):
- 1:59 PM Changeset in webkit [223854] by
-
- 2 edits in trunk/Source/WebCore
Attempt to stop iOS Simulator tests from failing because
we don't support Accelerated ImageBuffer.
- html/ImageBitmap.cpp:
- 1:42 PM Changeset in webkit [223853] by
-
- 3 edits in trunk/Source/WebCore
[FrameView::layout cleanup] Make m_subtreeLayoutRoot weak.
https://bugs.webkit.org/show_bug.cgi?id=178621
<rdar://problem/35110321>
Reviewed by Simon Fraser.
This patch turn m_subtreeLayoutRoot into a weak pointer to handle both the optional and the mutation cases.
Covered by existing cases.
- page/FrameView.cpp:
(WebCore::FrameView::reset):
(WebCore::FrameView::willDestroyRenderTree):
(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::handleLayoutWithFrameFlatteningIfNeeded):
(WebCore::FrameView::canPerformLayout const):
(WebCore::FrameView::layout): WeakPtr<RenderElement> protects us from recursive layouts triggering UAF on layoutRoot.
(WebCore::FrameView::convertSubtreeLayoutToFullLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout const):
(WebCore::FrameView::autoSizeIfEnabled):
- page/FrameView.h:
- 1:40 PM Changeset in webkit [223852] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix windows build.
- CMakeLists.txt:
- 1:37 PM WebKitGTK/2.18.x edited by
- (diff)
- 1:32 PM Changeset in webkit [223851] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, suppress deprecation warnings to fix the build.
<rdar://problem/35131949>
- UIProcess/ios/forms/WKFormSelectPopover.mm:
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectPopover initWithView:hasGroups:]):
- 1:23 PM Changeset in webkit [223850] by
-
- 4 edits in trunk/Source/WebCore
Move shared accessibility and animiations files to unified sources.
https://bugs.webkit.org/show_bug.cgi?id=178677
Reviewed by Tim Horton.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 12:36 PM Changeset in webkit [223849] by
-
- 16 edits2 adds in trunk
Drop confusing Event::dispatched() method
https://bugs.webkit.org/show_bug.cgi?id=178670
Reviewed by Youenn Fablet.
Source/WebCore:
Drop confusing Event::dispatched() method. What the call sites want to do is check
that the Event's "dispatch" flag is set:
This flag gets set at the beginning of dispatchEvent() and unset at the end of
dispatchEvent():
See as an example event.initEvent():
The right way to check the Event's "dispatch" flag is the Event::isBeingDispatched()
method, so use this instead. One side effect of this change is that it is now
possible to call the init*Event() method on events that have already been dispatched
in order to dispatch them again, as per the specification.
Test: fast/events/initEvent-after-dispatching.html
- dom/CompositionEvent.cpp:
(WebCore::CompositionEvent::initCompositionEvent):
- dom/DeviceMotionEvent.cpp:
(WebCore::DeviceMotionEvent::initDeviceMotionEvent):
- dom/DeviceOrientationEvent.cpp:
(WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
- dom/Event.h:
- dom/HashChangeEvent.h:
- dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::initKeyboardEvent):
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::initMessageEvent):
- dom/MouseEvent.cpp:
(WebCore::MouseEvent::initMouseEvent):
- dom/OverflowEvent.cpp:
(WebCore::OverflowEvent::initOverflowEvent):
- dom/TextEvent.cpp:
(WebCore::TextEvent::initTextEvent):
- dom/TouchEvent.cpp:
(WebCore::TouchEvent::initTouchEvent):
- dom/UIEvent.cpp:
(WebCore::UIEvent::initUIEvent):
- dom/WheelEvent.cpp:
(WebCore::WheelEvent::initWheelEvent):
- storage/StorageEvent.cpp:
(WebCore::StorageEvent::initStorageEvent):
LayoutTests:
Add layout test coverage.
- fast/events/initEvent-after-dispatching-expected.txt: Added.
- fast/events/initEvent-after-dispatching.html: Added.
- 11:59 AM Changeset in webkit [223848] by
-
- 8 edits in trunk
Remember previous child renderer during render tree update
https://bugs.webkit.org/show_bug.cgi?id=178659
Reviewed by Zalan Bujtas.
Source/WebCore:
We shouldn't need to recompute the previous renderer, we know it already.
- style/RenderTreePosition.cpp:
(WebCore::RenderTreePosition::previousSiblingRenderer const): Deleted.
No longer needed. This was also subtly wrong as doesn't take display:contents into account.
- style/RenderTreePosition.h:
- style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::textRendererIsNeeded):
Use the saved previous renderer.
(WebCore::RenderTreeUpdater::updateTextRenderer):
(WebCore::RenderTreeUpdater::storePreviousRenderer):
Save the previous renderere as we walk the tree.
(WebCore::textRendererIsNeeded): Deleted.
- style/RenderTreeUpdater.h:
LayoutTests:
- fast/block/float/float-not-removed-from-pre-block-expected.txt:
- platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
- 11:57 AM Changeset in webkit [223847] by
-
- 4 edits in trunk/Source/WebCore
Add Shared Modules files to the unified source build.
https://bugs.webkit.org/show_bug.cgi?id=178675
Reviewed by Tim Horton.
This patch all the Modules sources files shared across all ports to
unified sources.
- CMakeLists.txt:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 11:42 AM Changeset in webkit [223846] by
-
- 2 edits in trunk/Tools
<rdar://problem/35045445>
Update README to reference WebKit build archives, instead of 'nightly'
Reviewed by Aakash Jain.
- WebKitArchiveSupport/README:
- 11:10 AM Changeset in webkit [223845] by
-
- 3 edits4 adds in trunk/LayoutTests
Add tests to ensure spelling error dots are drawn in the correct place in bottom-to-top
and right-to-left writing modes
https://bugs.webkit.org/show_bug.cgi?id=178671
Reviewed by Simon Fraser.
- fast/writing-mode/english-bt-text-with-spelling-marker-expected.html: Added.
- fast/writing-mode/english-bt-text-with-spelling-marker.html: Added.
- fast/writing-mode/english-rl-text-with-spelling-marker-expected.html: Added.
- fast/writing-mode/english-rl-text-with-spelling-marker.html: Added.
- platform/ios/TestExpectations: Skip the test on iOS as it does not support spelling and grammar
marker painting.
- platform/mac-wk2/TestExpectations: Mark the test as an image failure until we fix <https://bugs.webkit.org/show_bug.cgi?id=105616>.
- 10:56 AM Changeset in webkit [223844] by
-
- 2 edits in trunk/Source/bmalloc
bmalloc::api::tryLargeMemalignVirtual() shouldn't assert on a failed allocation
https://bugs.webkit.org/show_bug.cgi?id=178654
Reviewed by Geoffrey Garen.
- bmalloc/bmalloc.h:
(bmalloc::api::tryLargeMemalignVirtual): Call Heap::tryAllocateLarge()
instead of Heap::allocateLarge(). The former will return a null pointer
upon a failed allocation, allowing the caller to fail gracefully just as
the API entrypoint implies, while the latter currently provokes a crash
in these circumstances.
- 10:51 AM Changeset in webkit [223843] by
-
- 9 edits4 adds in trunk
Implement drawImage(ImageBitmap) on 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=178653
<rdar://problem/35104360>
Reviewed by Antoine Quint.
LayoutTests/imported/w3c:
Update expected results now that drawImage is implemented.
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
Source/WebCore:
Implement CanvasRenderingContext2D::drawImage with ImageBitmap.
It's probably not going to be a very common operation, but
it importantly allows us to test the ImageBitmap creation
code.
Test: http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap.html
- html/ImageBitmap.cpp:
(WebCore::taintsOrigin): New helper function to determine if a
CachedImage would provide a clean origin.
(WebCore::ImageBitmap::createPromise): Set the flag that records
if this ImageBitmap has a clean origin.
- html/ImageBitmap.h:
(WebCore::ImageBitmap::buffer): Exposes the ImageBuffer backing
store, allowing access to the data for drawing.
(WebCore::ImageBitmap::originClean const): Is this ImageBitmap
going to taint a destination.
- html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin): Implement
the ImageBitmap version of this template function.
- html/canvas/CanvasRenderingContext.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage): Implement the
actual drawing of an ImageBitmap.
LayoutTests:
Add a new test that exercises drawImage(ImageBitmap)
that will be contributed back to Web Platform Tests.
- http/wpt/2dcontext/imagebitmap/common.js: Copied (mostly) from WPT.
(create9x9CanvasWith2dContext): New helper function to create a canvas
and provide a rendering context.
- http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap-expected.txt: Added.
- http/wpt/2dcontext/imagebitmap/drawImage-ImageBitmap.html: Added.
- http/wpt/2dcontext/imagebitmap/target-blue-dot.png: Added.
- 10:49 AM Changeset in webkit [223842] by
-
- 3 edits4 adds in trunk/LayoutTests
Add tests to ensure spelling error dots are drawn in the correct place for overlapping lines
https://bugs.webkit.org/show_bug.cgi?id=178611
<rdar://problem/35105805>
Reviewed by Zalan Bujtas.
Add tests to ensure that we paint the spelling error dots in the correct place for
overlapping lines.
- editing/spelling/spelling-markers-in-overlapping-lines-expected.html: Added.
- editing/spelling/spelling-markers-in-overlapping-lines-large-font-expected.html: Added.
- editing/spelling/spelling-markers-in-overlapping-lines-large-font.html: Added.
- editing/spelling/spelling-markers-in-overlapping-lines.html: Added.
- platform/ios/TestExpectations: Skip the test on iOS as it does not support spelling and grammar
marker painting.
- platform/mac-wk2/TestExpectations: Mark the test as an image failure until we fix <https://bugs.webkit.org/show_bug.cgi?id=105616>.
- 10:35 AM Changeset in webkit [223841] by
-
- 2 edits839 adds in trunk/LayoutTests
Unreviewed WPE gardening. Unskip the SVG tests and generate the
required platform-specific baselines.
- platform/wpe/TestExpectations:
- platform/wpe/svg: Added ~800 baselines.
- 10:28 AM Changeset in webkit [223840] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r223699.
Caused regressions with right-to-left text selection and
painting of markers in flipped writing mode and in overlapping
lines. Will investigate offline.
Reverted changeset:
"Share logic in InlineTextBox to compute selection rect"
https://bugs.webkit.org/show_bug.cgi?id=178232
https://trac.webkit.org/changeset/223699
- 10:25 AM Changeset in webkit [223839] by
-
- 27 edits2 copies2 adds in trunk
Source/WebCore:
Create a Fetch event when ServiceWorker has to handle a fetch
https://bugs.webkit.org/show_bug.cgi?id=178491
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
Reviewed by Chris Dumez.
Covered by existing test.
Updating FetchEvent to pass a FetchResponse* within its onResponse callback.
Making it a CompletionHandler.
Fixing a check on respondWith to ensure that event is dispatched when respondWith is called.
Adding ServiceWorkerFetch class to handle the creation of the fetch event, waiting for the fetch event to be responded
and processing when fetch event is responded.
ServiceWorkerFetchTask takes a client to which will be sent the response body or the error.
WebKit implementation of it will be to send the related IPC message back to the WebProcess that made the fetch request.
Adding a method to ServiceWorkerThread to create the fetch event on worker thread and dispatch on the global scope.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/ResourceResponseBase.h:
- testing/Internals.cpp:
(WebCore::Internals::waitForFetchEventToFinish):
- workers/service/FetchEvent.cpp:
(WebCore::FetchEvent::~FetchEvent):
(WebCore::FetchEvent::respondWith):
(WebCore::FetchEvent::onResponse):
(WebCore::FetchEvent::respondWithError):
(WebCore::FetchEvent::processResponse):
(WebCore::FetchEvent::promiseIsSettled):
- workers/service/FetchEvent.h:
- workers/service/context/ServiceWorkerFetch.cpp: Added.
(WebCore::ServiceWorkerFetch::dispatchFetchTask):
(WebCore::ServiceWorkerFetch::processResponse):
- workers/service/context/ServiceWorkerFetch.h: Added.
- workers/service/context/ServiceWorkerThread.cpp:
(WebCore::m_workerObjectProxy):
(WebCore::ServiceWorkerThread::dispatchFetchEvent):
- workers/service/context/ServiceWorkerThread.h:
Source/WebKit:
TestController should clear all fetch caches when resetting its state
https://bugs.webkit.org/show_bug.cgi?id=178486
<rdar://problem/35066305>
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
Reviewed by Chris Dumez.
Adding a new DidNotHandle message to disambiguate with the DidFail fetch case.
With DidNotHandle, the loading should go the network process.
With DidFail, the loading should return a network error.
On receiving an order to start a fetch, ServiceWorkerThread will dispatch a fetch event.
The client of this event will retrieve the response and return it to the WebProcess through IPC.
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::didNotHandleFetch):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didNotHandleFetch):
- StorageProcess/StorageProcess.h:
- StorageProcess/StorageProcess.messages.in:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::didFail):
(WebKit::ServiceWorkerClientFetch::didNotHandle):
- WebProcess/Storage/ServiceWorkerClientFetch.h:
- WebProcess/Storage/ServiceWorkerClientFetch.messages.in:
- WebProcess/Storage/ServiceWorkerContextManager.cpp:
(WebKit::ServiceWorkerContextManager::startFetch):
- WebProcess/Storage/ServiceWorkerContextManager.h:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: Added.
(WebKit::WebServiceWorkerFetchTaskClient::~WebServiceWorkerFetchTaskClient):
(WebKit::WebServiceWorkerFetchTaskClient::WebServiceWorkerFetchTaskClient):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveResponse):
(WebKit::WebServiceWorkerFetchTaskClient::didReceiveData):
(WebKit::WebServiceWorkerFetchTaskClient::didFail):
(WebKit::WebServiceWorkerFetchTaskClient::didFinish):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.h: Added.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::startFetchInServiceWorker):
- WebProcess/WebProcess.h:
LayoutTests:
TestController should clear all fetch caches when resetting its state
https://bugs.webkit.org/show_bug.cgi?id=178486
<rdar://problem/35066305>
Patch by Youenn Fablet <youenn@apple.com> on 2017-10-23
Reviewed by Chris Dumez.
Beefing up the test by using fetch event handler to return responses
previously hard coded in ServiceWorkerContextManager.
- http/tests/workers/service/basic-fetch.https-expected.txt:
- http/tests/workers/service/resources/basic-fetch-worker.js:
(event.event.request.url.indexOf):
- http/tests/workers/service/resources/basic-fetch.js:
- 10:21 AM Changeset in webkit [223838] by
-
- 5 edits in trunk/Source/WebCore
[Curl] Fix authentication related bugs
https://bugs.webkit.org/show_bug.cgi?id=178652
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-10-23
Reviewed by Alex Christensen.
- platform/network/curl/AuthenticationChallengeCurl.cpp:
(WebCore::AuthenticationChallenge::protectionSpaceFromHandle):
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlHandle::setHttpAuthUserPass):
- platform/network/curl/CurlRequest.cpp:
(WebCore::CurlRequest::setUserPass):
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::didReceiveHeader):
- platform/network/curl/CurlRequest.h:
- 10:10 AM Changeset in webkit [223837] by
-
- 2 edits in trunk/LayoutTests
Mark compositing/visible-rect/iframe-no-layers.html as a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=178669
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 9:44 AM Changeset in webkit [223836] by
-
- 14 edits2 adds in trunk/Source
Unreviewed, rolling out r223820.
This caused a build break on Windows.
Reverted changeset:
"Web Inspector: Remove unused Console.setMonitoringXHREnabled"
https://bugs.webkit.org/show_bug.cgi?id=178617
https://trac.webkit.org/changeset/223820
- 8:57 AM Changeset in webkit [223835] by
-
- 4 edits in trunk/Source/WebCore
Call FrameView::scheduleSelectionUpdate when selection needs repainting after layout instead of setting the RenderView dirty.
https://bugs.webkit.org/show_bug.cgi?id=178651
<rdar://problem/35117448>
Reviewed by Antti Koivisto.
Calling setNeedsLayout() on the RenderView to trigger selection update is problematic in 2 different ways:
- marking the root renderer dirty does not trigger layout (this is very specific to the root,
other renderers do trigger layout). It means that it works as long as someone else schedules a layout.
- when a subtree layout is already scheduled and we mark the root renderer dirty, the root gets stuck with
the dirty flag (since the entry point for the subsequent layout is a descendant of the root and not the root itself).
This patch addresses these issues by scheduling/converting subtree layout when needed.
Covered by fast/dynamic/remove-invisible-node-inside-selection.html/remove-node-inside-selection.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::respondToNodeModification):
- page/FrameView.cpp:
(WebCore::FrameView::scheduleSelectionUpdate):
- page/FrameView.h:
- 4:50 AM Changeset in webkit [223834] by
-
- 6 edits4 adds in trunk
[JSC] Use fastJoin in Array#toString
https://bugs.webkit.org/show_bug.cgi?id=178062
Reviewed by Darin Adler.
JSTests:
- microbenchmarks/contiguous-array-to-string.js: Added.
(target):
- microbenchmarks/double-array-to-string.js: Added.
(target):
- microbenchmarks/int32-array-to-string.js: Added.
(target):
Source/JavaScriptCore:
Array#toString()'s fast path uses original join operation.
But this should use fastJoin if possible.
This patch adds a fast path using fastJoin in Array#toString.
And we also extend fastJoin to perform fast joining for int32
arrays.
baseline patched
double-array-to-string 126.6157+-5.8625 103.7343+-4.4968 definitely 1.2206x faster
int32-array-to-string 64.7792+-2.6524 61.2390+-2.1749 might be 1.0578x faster
contiguous-array-to-string 62.6224+-2.6388 56.9899+-2.0852 definitely 1.0988x faster
- runtime/ArrayPrototype.cpp:
(JSC::fastJoin):
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
- runtime/JSStringJoiner.h:
(JSC::JSStringJoiner::appendWithoutSideEffects):
(JSC::JSStringJoiner::appendInt32):
(JSC::JSStringJoiner::appendDouble):
Source/WTF:
A bit cleaning up to use StringImpl::copyChars instead of
using for-loop directly.
- wtf/text/StringView.h:
(WTF::StringView::getCharactersWithUpconvert const):
- 3:11 AM Changeset in webkit [223833] by
-
- 6 edits in trunk/Source/WebCore
[TexMap] Remove GraphicsContext3D usage from TextureMapperShaderProgram
https://bugs.webkit.org/show_bug.cgi?id=175425
Reviewed by Žan Doberšek.
Remove usage of the GraphicsContext3D class in TextureMapperShaderProgram.
Direct OpenGL API calls, types and constants are used instead.
By removing GraphicsContext3D, we don't use ANGLE anymore to perform the
shader adaptation to the used OpenGL/GLES2 version, so we need to do that
inside TextureMapperShaderProgram. The main changes required for this are
adding the #version directive and use in/out to define input/output parameters
when using OpenGL >= 3.2, and defining the default precision only when using
GLES2.
Besides that, now that VideoTextureCopierGStreamer doesn't have its own
GraphicsContext3D, we need to add a VAO to it when using OpenGL >= 3.2.
Based on a previous patch by Žan Doberšek <zdobersek@igalia.com>.
No behavior change.
- platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:
(WebCore::VideoTextureCopierGStreamer::VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::~VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):
- platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::getShaderProgram):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawFiltered):
- platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore::TextureMapperShaderProgram::create):
(WebCore::getShaderLog):
(WebCore::getProgramLog):
(WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::~TextureMapperShaderProgram):
(WebCore::TextureMapperShaderProgram::setMatrix):
(WebCore::TextureMapperShaderProgram::getLocation):
- platform/graphics/texmap/TextureMapperShaderProgram.h:
(WebCore::TextureMapperShaderProgram::programID const):
Oct 22, 2017:
- 10:27 PM Changeset in webkit [223832] by
-
- 2 edits in trunk/JSTests
stress/check-string-ident.js is improperly skipped
https://bugs.webkit.org/show_bug.cgi?id=178642
Reviewed by Saam Barati.
- stress/check-string-ident.js: Drop the defaultNoEagerRun directive
since it enforces the run-jsc-stress-tests script to still set up the
test to run, despite the skip directive that's used before.
- 10:26 PM Changeset in webkit [223831] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove !(OS(LINUX) && CPU(ARM64)) guards in RegisterState.h
https://bugs.webkit.org/show_bug.cgi?id=178452
Reviewed by Yusuke Suzuki.
- heap/RegisterState.h: Re-enable the custom RegisterState and
ALLOCATE_AND_GET_REGISTER_STATE definitions on ARM64 Linux. These don't
cause any crashes nowadays.
- 8:38 PM Changeset in webkit [223830] by
-
- 7 edits in tags/Safari-604.4.5.1/Source
Versioning.
- 8:24 PM Changeset in webkit [223829] by
-
- 1 copy in tags/Safari-604.4.5.1
New tag.
- 8:13 PM Changeset in webkit [223828] by
-
- 5 edits8 adds3 deletes in trunk/Source/WebCore
[Settings] Replace current Settings generation with template file based approach
https://bugs.webkit.org/show_bug.cgi?id=178634
Patch by Sam Weinig <sam@webkit.org> on 2017-10-22
Reviewed by Joseph Pecoraro.
This replaces the recently added python based Settings generation with a generator
built in ruby, so we can take advantage of ERB for templating. The result has much
of the logic in the templates and as a result feels much easier to follow and cleaner.
Since I was moving things to ruby, I took the opertunity to switch the Settings definition
file from our .in format to yaml, which is quite a bit easier to read.
- CMakeLists.txt:
- DerivedSources.make:
- Scripts/GenerateSettings: Removed.
- Scripts/GenerateSettings.py: Removed.
- Scripts/GenerateSettings.rb: Added.
- Scripts/GenerateSettings/GenerateInternalSettingsHeaderFile.py: Removed.
- Scripts/GenerateSettings/GenerateInternalSettingsIDLFile.py: Removed.
- Scripts/GenerateSettings/GenerateInternalSettingsImplementationFile.py: Removed.
- Scripts/GenerateSettings/GenerateSettings.py: Removed.
- Scripts/GenerateSettings/GenerateSettingsHeaderFile.py: Removed.
- Scripts/GenerateSettings/GenerateSettingsImplementationFile.py: Removed.
- Scripts/GenerateSettings/Settings.py: Removed.
- Scripts/GenerateSettings/init.py: Removed.
- Scripts/SettingsTemplates: Added.
- Scripts/SettingsTemplates/InternalSettingsGenerated.cpp.erb: Added.
- Scripts/SettingsTemplates/InternalSettingsGenerated.h.erb: Added.
- Scripts/SettingsTemplates/InternalSettingsGenerated.idl.erb: Added.
- Scripts/SettingsTemplates/Settings.cpp.erb: Added.
- Scripts/SettingsTemplates/Settings.h.erb: Added.
- WebCore.xcodeproj/project.pbxproj:
- WebCoreMacros.cmake:
- page/Settings.in: Removed.
- page/Settings.yaml: Added.
- 7:20 PM Changeset in webkit [223827] by
-
- 6 edits in trunk/Source/WebKit
[iOS] WebProcess::initializeWebProcess spends ~150ms spinning up AVSystemController on some devices
https://bugs.webkit.org/show_bug.cgi?id=178640
<rdar://problem/35113105>
Reviewed by Youenn Fablet.
In r213933, we added a mechanism to allow the web process to drive media capture, by setting an attribute on the
shared AVSystemController. This requires us to fault in the Celestial framework, which is a slight performance
hit on some hardware. Instead of doing this at the start of every web process launch, we can just do this work
lazily, the first time the web process requests permissions for user media access.
- WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
(WebKit::WebUserMediaClient::requestUserMediaAccess):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::prepareToSendUserMediaPermissionRequest):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::prepareToSendUserMediaPermissionRequest):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 5:43 PM Changeset in webkit [223826] by
-
- 5 edits2 adds in trunk
REGRESSION(r219675): Web Inspector: CommandLineAPI getEventListeners does not work
https://bugs.webkit.org/show_bug.cgi?id=178650
<rdar://problem/35116347>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-22
Reviewed by Sam Weinig.
Source/WebCore:
Test: inspector/console/command-line-api-getEventListeners.html
- inspector/CommandLineAPIHost.cpp:
(WebCore::listenerEntriesFromListenerInfo):
Fix typo.
(WebCore::CommandLineAPIHost::getEventListeners):
Fix incorrect early return.
- inspector/CommandLineAPIHost.h:
- inspector/CommandLineAPIHost.idl:
Add more attributes about the listener. These new attributes match output from Chrome.
LayoutTests:
- inspector/console/command-line-api-getEventListeners-expected.txt: Added.
- inspector/console/command-line-api-getEventListeners.html: Added.
- 2:31 PM Changeset in webkit [223825] by
-
- 10 edits2 adds in trunk
[Web Animations] Add animations to the timeline
https://bugs.webkit.org/show_bug.cgi?id=178643
Patch by Antoine Quint <Antoine Quint> on 2017-10-22
Reviewed by Dean Jackson.
Source/WebCore:
If a timeline is provided as a parameter to the Animation constructor,
add it to the timeline, and remove it when the object is destroyed.
We also start the basic mechanism to dump the contents of a timeline
as text for testing purposes, currently only logging the number of
animations in a timeline and just logging the class name for animation
themselves.
Test: webanimations/animation-creation-addition.html
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::description):
- animation/AnimationTimeline.h:
- animation/AnimationTimeline.idl:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::create):
(WebCore::WebAnimation::~WebAnimation):
(WebCore::WebAnimation::description):
- animation/WebAnimation.h:
- testing/Internals.cpp:
(WebCore::Internals::timelineDescription):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add a new test that checks that animations created with a timeline
are added to the provided timeline.
- webanimations/animation-creation-addition-expected.txt: Added.
- webanimations/animation-creation-addition.html: Added.
- 11:28 AM Changeset in webkit [223824] by
-
- 11 edits in trunk/Source/JavaScriptCore
[JSC][Baseline] Use linkAllSlowCasesForBytecodeOffset as much as possible to simplify slow cases handling
https://bugs.webkit.org/show_bug.cgi?id=178647
Reviewed by Saam Barati.
There is much code counting slow cases in fast paths to call
linkSlowCasecarefully. This is really error-prone
since the number of slow cases depends on values of instruction's metadata. We have linkAllSlowCasesForBytecodeOffset,
which drains all slow cases for a specified bytecode offset. In typical cases like just calling a slow path function,
this is enough. We use linkAllSlowCasesForBytecodeOffset as much as possible. It significantly simplifies the code.
- jit/JIT.h:
(JSC::JIT::linkAllSlowCases):
- jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_unsigned):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emitSlow_op_urshift):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_div):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emitSlow_op_sub):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emitSlow_op_unsigned):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emitSlow_op_dec):
(JSC::JIT::emitSlow_op_mod):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITInlines.h:
(JSC::JIT::linkAllSlowCasesForBytecodeOffset):
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_check_tdz):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_to_string):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emitSlow_op_check_traps):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emitSlow_op_get_direct_pname):
(JSC::JIT::emitSlow_op_has_structure_property):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emitSlow_op_to_primitive):
(JSC::JIT::emitSlow_op_not):
(JSC::JIT::emitSlow_op_stricteq):
(JSC::JIT::emitSlow_op_nstricteq):
(JSC::JIT::emitSlow_op_to_number):
(JSC::JIT::emitSlow_op_to_string):
(JSC::JIT::emitSlow_op_create_this):
(JSC::JIT::emitSlow_op_to_this):
(JSC::JIT::emitSlow_op_check_tdz):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emitSlow_op_get_direct_pname):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
- 9:47 AM Changeset in webkit [223823] by
-
- 9 edits in trunk/Source/JavaScriptCore
[JSC] Clean up baseline slow path
https://bugs.webkit.org/show_bug.cgi?id=178646
Reviewed by Saam Barati.
If the given op is just calling a slow path function, we should use DEFINE_SLOW_OP instead.
It is good since (1) we can reduce the manual emitting code and (2) it can clarify which
function is implemented as a slow path call. This patch is an attempt to reduce 32bit specific
code in baseline JIT.
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_pow): Deleted.
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_mod):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_strcat): Deleted.
(JSC::JIT::emit_op_push_with_scope): Deleted.
(JSC::JIT::emit_op_assert): Deleted.
(JSC::JIT::emit_op_create_lexical_environment): Deleted.
(JSC::JIT::emit_op_throw_static_error): Deleted.
(JSC::JIT::emit_op_new_array_with_spread): Deleted.
(JSC::JIT::emit_op_spread): Deleted.
(JSC::JIT::emit_op_get_enumerable_length): Deleted.
(JSC::JIT::emit_op_has_generic_property): Deleted.
(JSC::JIT::emit_op_get_property_enumerator): Deleted.
(JSC::JIT::emit_op_to_index_string): Deleted.
(JSC::JIT::emit_op_create_direct_arguments): Deleted.
(JSC::JIT::emit_op_create_scoped_arguments): Deleted.
(JSC::JIT::emit_op_create_cloned_arguments): Deleted.
(JSC::JIT::emit_op_create_rest): Deleted.
(JSC::JIT::emit_op_unreachable): Deleted.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_strcat): Deleted.
(JSC::JIT::emit_op_push_with_scope): Deleted.
(JSC::JIT::emit_op_assert): Deleted.
(JSC::JIT::emit_op_create_lexical_environment): Deleted.
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val_with_this): Deleted.
(JSC::JIT::emit_op_get_by_val_with_this): Deleted.
(JSC::JIT::emit_op_put_by_id_with_this): Deleted.
(JSC::JIT::emit_op_resolve_scope_for_hoisting_func_decl_in_eval): Deleted.
(JSC::JIT::emit_op_define_data_property): Deleted.
(JSC::JIT::emit_op_define_accessor_property): Deleted.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope_for_hoisting_func_decl_in_eval): Deleted.
(JSC::JIT::emit_op_get_by_val_with_this): Deleted.
(JSC::JIT::emit_op_put_by_id_with_this): Deleted.
(JSC::JIT::emit_op_put_by_val_with_this): Deleted.
Oct 21, 2017:
- 8:41 PM Changeset in webkit [223822] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, silence a -Wunused-but-set-variable warning
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- 7:05 PM Changeset in webkit [223821] by
-
- 3 edits in trunk/Source/WebCore
[FrameView::layout cleanup] Drop allowSubtree parameter
https://bugs.webkit.org/show_bug.cgi?id=178623
<rdar://problem/35111012>
Reviewed by Sam Weinig.
This flag is only set through ::forceLayout(). Let's just convert the subtree layout
to full layout right before calling ::layout().
No change in functionality.
- page/FrameView.cpp:
(WebCore::FrameView::handleLayoutWithFrameFlatteningIfNeeded):
(WebCore::FrameView::layout):
(WebCore::FrameView::startLayoutAtMainFrameViewIfNeeded):
(WebCore::FrameView::forceLayout):
- page/FrameView.h:
- 3:23 PM Changeset in webkit [223820] by
-
- 14 edits2 deletes in trunk/Source
Web Inspector: Remove unused Console.setMonitoringXHREnabled
https://bugs.webkit.org/show_bug.cgi?id=178617
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-21
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- inspector/agents/InspectorConsoleAgent.h:
- inspector/agents/JSGlobalObjectConsoleAgent.cpp: Removed.
- inspector/agents/JSGlobalObjectConsoleAgent.h: Removed.
- inspector/protocol/Console.json:
Removed files and method.
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
This can use the base ConsoleAgent now.
Source/WebCore:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didFinishXHRLoading):
- inspector/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::setMonitoringXHREnabled): Deleted.
(WebCore::WebConsoleAgent::didFinishXHRLoading): Deleted.
- inspector/WebConsoleAgent.h:
Remove XHR monitoring code.
- xml/XMLHttpRequest.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber): Deleted.
- xml/XMLHttpRequest.idl:
Remove now unused state on XHR and ExecState requirement for send().
- 2:48 PM Changeset in webkit [223819] by
-
- 4 edits9 adds in trunk
createImageBitmap with basic HTMLImageElement
https://bugs.webkit.org/show_bug.cgi?id=178619
<rdar://problem/35104118>
Reviewed by Antoine Quint.
Source/WebCore:
Implement the basic infrastructure for creating
an ImageBitmap from an HTMLImageElement.
Test: http/wpt/2dcontext/imagebitmap/createImageBitmap.html
- html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createPromise): Create the image buffer
and draw the image into its backing store.
- html/ImageBitmap.h:
LayoutTests:
Make a better test for createImageBitmap. This will be
submitted to Web Platform Tests.
- http/wpt/2dcontext/imagebitmap/createImageBitmap-expected.txt: Added.
- http/wpt/2dcontext/imagebitmap/createImageBitmap.html: Added.
- http/wpt/common/canvas-tests.css: Added.
- http/wpt/common/canvas-tests.js: Added.
- http/wpt/images/pattern.png: Added.
- 2:42 PM Changeset in webkit [223818] by
-
- 5 edits1 copy1 add in trunk
Turn on ccache for Mac cmake builds by default
https://bugs.webkit.org/show_bug.cgi?id=177059
Reviewed by Sam Weinig.
.:
- Source/cmake/WebKitCCache.cmake: Added.
- Source/cmake/WebKitCommon.cmake:
Turn on ccache for Mac CMake builds (Makefile and Ninja generators only)
if it's installed, making use of CMake's ability to wrap the compiler invocation.
Tools:
- ccache/ccache-clang:
- ccache/ccache-wrapper: Added.
Add a pass-through ccache wrapper to be used with CMake, in addition
to the existing faux-clang wrappers.
- Scripts/build-webkit:
Add --use-ccache and --no-use-ccache option, which will define
WK_USE_CCACHE to YES or NO, respectively, which the underlying
build systems respect. We do not define WK_USE_CCACHE if the option
is not specified, because the underlying build systems have different
default values.
- 12:23 PM Changeset in webkit [223817] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 12:19 PM Changeset in webkit [223816] by
-
- 3 edits1 add in branches/safari-604-branch
Cherry-pick r223731. rdar://problem/35100279
- 12:19 PM Changeset in webkit [223815] by
-
- 3 edits1 add in branches/safari-604-branch
Cherry-pick r223645. rdar://problem/34820875
- 12:19 PM Changeset in webkit [223814] by
-
- 7 edits49 adds in branches/safari-604-branch
Cherry-pick r223578. rdar://problem/34891313
- 8:34 AM Changeset in webkit [223813] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC] Remove per-host-function CTI stub in 32bit environment
https://bugs.webkit.org/show_bug.cgi?id=178581
Reviewed by Saam Barati.
JIT::privateCompileCTINativeCall only exists in 32bit environment and it is almost the same to native call CTI stub.
The only difference is that it embed the address of the host function directly in the generated stub. This means
that we have per-host-function CTI stub only in 32bit environment.
This patch just removes it and use one CTI stub instead. This design is the same to the current 64bit implementation.
- jit/JIT.cpp:
(JSC::JIT::compileCTINativeCall): Deleted.
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTINativeCall): Deleted.
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTINativeCall): Deleted.
- jit/JITThunks.cpp:
(JSC::JITThunks::hostFunctionStub):
- 7:11 AM Changeset in webkit [223812] by
-
- 3 edits in trunk/Source/WebCore
[Web Animations] Add bindings to unified sources
https://bugs.webkit.org/show_bug.cgi?id=178620
Patch by Antoine Quint <Antoine Quint> on 2017-10-21
Reviewed by Dean Jackson.
Removing the Web Animations bindings from the WebCore target and adding them to the unified sources list instead.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- 1:26 AM Changeset in webkit [223811] by
-
- 2 edits in trunk/Source/WebCore
Fix the Mac CMake build
- PlatformMac.cmake:
- 1:15 AM Changeset in webkit [223810] by
-
- 7 edits in trunk
Support ::before/::after pseudo elements with display:contents
https://bugs.webkit.org/show_bug.cgi?id=178584
Reviewed by Ryosuke Niwa.
Source/WebCore:
This is cases like
::before { display:contents; content:'foo' }
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustDisplayContentsStyle): Added.
Allow display:contents on pseudo elements.
Factor into function.
(WebCore::StyleResolver::adjustRenderStyle):
- dom/PseudoElement.h:
Add a weak vector of content renderers.
- style/RenderTreePosition.h:
(WebCore::RenderTreePosition::moveToLastChild):
Add a way to set a valid render tree position without a node.
- style/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::createContentRenderers):
Take RenderTreePosition.
(WebCore::updateStyleForContentRenderers):
Update based on the content renderer vector instead of doing a tree walk.
(WebCore::removeAndDestroyContentRenderers):
Helper for destroying content renderers.
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
In the normal case create a render tree position for the pseudo element renderer and
use RenderTreePosition::moveToLastChild to make it a valid position. (The existing
RenderTreePosition interface didn't have way to move to positions in anonymous boxes)
In the case of a non box generating display:contents pseudo element, use the current
render tree position instead.
Ensure that pseudo element renderers are destroyed before creating the new ones since in
display:contents case they are not descendants of the pseudo renderer and don't get cleared
automatically.
LayoutTests:
- TestExpectations: Enable imported/w3c/web-platform-tests/css/css-display-3/display-contents-before-after-002.html
