Context Navigation

Implemented setCookie(), getCookies() and deleteCookie() in the Soup
backend, and refactored some utility functions and conversions out of
NetworkStorageSessionSoup into a new CookieSoup.cpp file, so
that we now can convert between SoupCookie* and WebCore::Cookie
easily from anywhere (this is now needed from the UI Process).

platform/Cookie.h: Add declarations for the new conversions.
platform/SourcesSoup.txt: Add CookieSoup.cpp.
platform/network/soup/CookieSoup.cpp: Added.

(WebCore::Cookie::Cookie): New constructor, creates a WebCore::Cookie out of a SoupCookie*.
(WebCore::msToSoupDate): Moved from NetworkStorageSessionSoup.cpp.
(WebCore::Cookie::toSoupCookie): New, based on toSoupCookie() from NetworkStorageSessionSoup.cpp.

platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::setCookies): Used the new implicit conversion.
(WebCore::NetworkStorageSession::setCookie): Newly implemented.
(WebCore::NetworkStorageSession::deleteCookie): Newly implemented.
(WebCore::NetworkStorageSession::getCookies): Newly implemented.

Source/WebKit:

Added new API to WebKitCookieManager to add, retrieve and delete complete
cookies into/out-of a running session, and updated documentation sections.

UIProcess/API/glib/WebKitCookieManager.cpp:

(webkit_cookie_manager_add_cookie): New function.
(webkit_cookie_manager_add_cookie_finish): Ditto.
(webkit_cookie_manager_get_cookies): Ditto.
(webkit_cookie_manager_get_cookies_finish): Ditto.
(webkit_cookie_manager_delete_cookie): Ditto.
(webkit_cookie_manager_delete_cookie_finish): Ditto.

UIProcess/API/gtk/WebKitCookieManager.h: Added new functions.
UIProcess/API/wpe/WebKitCookieManager.h: Ditto.
UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Ditto.

Tools:

Added new test cases to cover the newly added API for WebKitCookieManager:
webkit_cookie_manager_add_cookie, webkit_cookie_manager_get_cookies and
webkit_cookie_manager_delete_cookie.

TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerAddCookie): Added.
(testCookieManagerGetCookies): Added.
(testCookieManagerDeleteCookie): Added.
(serverCallback): Small update to avoid hardcoding strings we reuse.
(beforeAll): Added the new test cases to the test suite.

1:20 PM Changeset in webkit [225053] by commit-queue@webkit.org

2 edits in trunk/Tools

[Win] Update ruby JSC test writer for gigacage changes
https://bugs.webkit.org/show_bug.cgi?id=178757

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-11-20
Reviewed by Keith Miller.

Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:

Add additionalEnv to ruby test writer Plan

11:28 AM WebKitGTK/GCCRequirement edited by Michael Catanzaro

(diff)

9:18 AM Changeset in webkit [225052] by Alan Bujtas

5 edits
2 adds in trunk

Remove slow repaint object from FrameView when style changes.
https://bugs.webkit.org/show_bug.cgi?id=179871

Reviewed by Antti Koivisto.

Source/WebCore:

The "oldStyleSlowScroll" value does not need to be computed. We already know its value
by checking the HashSet. This code is also unnecessarily complicated and error prone
(could lead to UAF errors by leaving stale renderers in the slow paint list).

Test: fast/repaint/slow-repaint-object-crash.html

rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):

LayoutTests:

fast/repaint/slow-repaint-object-crash-expected.txt: Added.
fast/repaint/slow-repaint-object-crash.html: Added.

9:17 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

8:33 AM WebKitGTK/DependenciesPolicy edited by Michael Catanzaro

(diff)

8:33 AM WebKitGTK/DependenciesPolicy edited by Michael Catanzaro

(diff)

8:30 AM WebKitGTK/DependenciesPolicy edited by Michael Catanzaro

(diff)

8:26 AM WebKitGTK/GCCRequirement edited by Michael Catanzaro

(diff)

8:26 AM WebKitGTK/GCCRequirement edited by Michael Catanzaro

(diff)

8:25 AM WebKitGTK/GCCRequirement created by Michael Catanzaro

7:57 AM Changeset in webkit [225051] by clopez@igalia.com

2 edits in trunk/Source/WebCore

[WPE] GLContextEGLWPE.cpp:44:96: error: invalid cast from type ‘GLNativeWindowType {aka long long unsigned int}’ to type ‘EGLNativeWindowType {aka unsigned int}
https://bugs.webkit.org/show_bug.cgi?id=179511

Reviewed by Žan Doberšek.

r217208 changed the definition of GLNativeWindowType from EGLNativeWindowType to uint64_t for platform WPE.
This built fine on a 64-bit platform since uint64_t matches the size of a pointer, but fails on 32-bits.

This switches back the definition to EGLNativeWindowType.
And we need to include <EGL/eglplatform.h> first in order to get a definition for EGLNativeWindowType itself.

This commit pretty much reverts the changes r217208 did on platform/graphics/GLContext.h

No new tests, it is a build fix.

platform/graphics/GLContext.h:

7:46 AM Changeset in webkit [225050] by Michael Catanzaro

7 edits in trunk

Remove ENABLE_ALLINONE_BUILD option
https://bugs.webkit.org/show_bug.cgi?id=179823

Reviewed by Darin Adler.

Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

CMakeLists.txt:

Tools:

Scripts/webkitperl/FeatureList.pm:

4:32 AM Changeset in webkit [225049] by emilio

8 edits in trunk

Incorrect computed style in pseudo-elements with display: contents
https://bugs.webkit.org/show_bug.cgi?id=179812

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/cssom/getComputedStyle-pseudo-expected.txt:
web-platform-tests/cssom/getComputedStyle-pseudo.html: Extended the testcase to cover this bug.

Source/WebCore:

Bug 178513 gave them an anon renderer as the main renderer. Unfortunately, the
style of that box is exposed via getComputedStyle, so that needs to be handled
somehow to return the correct style.

Tests: imported/w3c/web-platform-tests/cssom/getComputedStyle-pseudo.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::styledRenderer const):

Don't return a display: contents pseudo anon box.

dom/Element.cpp:

(WebCore::Element::hasDisplayContents const):

Just look at the rare data style.

(WebCore::Element::existingComputedStyle const):

Look at the rare data first. This also fixes an inefficiency in the
sense that before then we'd compare the anon box style to the
pseudo-element style during style update, that may be more changes
than needed.

style/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):

style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolvePseudoStyle):

Move the anon box creation to render tree update instead of style
resolution.

3:22 AM Changeset in webkit [225048] by Carlos Garcia Campos

3 edits in trunk/Tools

Unreviewed. Fix WPE build after r225047.

Remove changes from an old patch committed by mistake in r225047.

WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::windowSnapshotImage):

3:03 AM Changeset in webkit [225047] by Carlos Garcia Campos

8 edits
1 copy
1 move
3 adds in trunk/Tools

[WPE] Add run-wpe-tests script to run WPE glib API tests
https://bugs.webkit.org/show_bug.cgi?id=173772

Reviewed by Michael Catanzaro.

Move common code from run-gtk-tests to api_test_runner.py, to be shared by both run-gtk-tests and un-wpe-tests.

Scripts/run-gtk-tests:

(GtkTestRunner):
(GtkTestRunner.init):
(GtkTestRunner._start_accessibility_daemons):
(GtkTestRunner._setup_testing_environment):
(GtkTestRunner._tear_down_testing_environment):
(GtkTestRunner.is_glib_test):
(GtkTestRunner.is_google_test):

Scripts/run-wpe-tests: Added.

(WPETestRunner):
(WPETestRunner.init):
(WPETestRunner.is_glib_test):
(WPETestRunner.is_google_test):

Scripts/webkitpy/port/headlessdriver.py: Added.

(HeadlessDriver):
(HeadlessDriver._setup_environ_for_test):
(HeadlessDriver._start):

Scripts/webkitpy/port/headlessdriver_unittest.py: Added.

(HeadlessDriverTest):
(HeadlessDriverTest.make_driver):
(HeadlessDriverTest.make_environment):
(HeadlessDriverTest.test_environment_needed_variables):
(HeadlessDriverTest.test_environment_forbidden_variables):

Scripts/webkitpy/port/wpe.py:

(WPEPort._driver_class):

WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::windowSnapshotImage):

glib/api_test_runner.py: Copied from Tools/Scripts/run-gtk-tests.

(SkippedTest):
(SkippedTest.init):
(SkippedTest.str):
(SkippedTest.skip_entire_suite):
(SkippedTest.skip_for_build_type):
(TestTimeout):
(TestRunner):
(TestRunner.init):
(TestRunner._test_programs_base_dir):
(TestRunner._get_tests_from_dir):
(TestRunner._get_tests):
(TestRunner._create_driver):
(TestRunner._setup_testing_environment):
(TestRunner._tear_down_testing_environment):
(TestRunner._test_cases_to_skip):
(TestRunner._should_run_test_program):
(TestRunner._kill_process):
(TestRunner._start_timeout):
(TestRunner._start_timeout._alarm_handler):
(TestRunner._stop_timeout):
(TestRunner._waitpid):
(TestRunner._run_test_glib):
(TestRunner._run_test_glib.parse_line):
(TestRunner._run_test_glib.parse_line.set_test_result):
(TestRunner._get_tests_from_google_test_suite):
(TestRunner._run_google_test):
(TestRunner._run_google_test_suite):
(TestRunner.is_glib_test):
(TestRunner.is_google_test):
(TestRunner._run_test):
(TestRunner.run_tests):
(add_options):

glib/common.py: Renamed from Tools/gtk/common.py.

(get_build_path.is_valid_build_directory):

gtk/generate-gtkdoc:
gtk/jhbuildrc:
gtk/ycm_extra_conf.py:

1:51 AM Changeset in webkit [225046] by Carlos Garcia Campos

6 edits
1 add in trunk/Tools

[WPE] Build C API tests
https://bugs.webkit.org/show_bug.cgi?id=179817

Reviewed by Michael Catanzaro.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/PlatformWPE.cmake:
TestWebKitAPI/PlatformWebView.h:
TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp:

(TestWebKitAPI::Util::URLForNonExistentResource):
(TestWebKitAPI::Util::isKeyDown):

TestWebKitAPI/wpe/PlatformWebViewWPE.cpp: Added.

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::initialize):
(TestWebKitAPI::PlatformWebView::page const):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
(TestWebKitAPI::PlatformWebView::simulateRightClick):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):

1:47 AM Changeset in webkit [225045] by Carlos Garcia Campos

11 edits
2 moves
2 adds in trunk/Tools

[WPE] Add env var WPE_USE_HEADLESS_VIEW_BACKEND
https://bugs.webkit.org/show_bug.cgi?id=173770

Reviewed by Michael Catanzaro.

Move HeadlessViewBackend implementation to a common place and build it as a private static library to be used by
WTR, GLib API tests and eventually C API tests too. WTR uses the HeadlessViewBackend unconditionally, but GLib
API tests use it only when WPE_USE_HEADLESS_VIEW_BACKEND environment variable is present and not "0".

CMakeLists.txt: Include wpe/HeadlessViewBackend directory for developer builds.
TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

(testAutomationSessionRequestSession):

TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerEphemeral):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:

(testPrivateBrowsing):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextProxySettings):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewWebContext):
(testWebViewEphemeral):

TestWebKitAPI/glib/PlatformWPE.cmake:
TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::createWebViewBackend):
(Test::createWebView):

TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:

(WebViewTest::initializeWebView):

WebKitTestRunner/PlatformWPE.cmake:
wpe/HeadlessViewBackend/CMakeLists.txt: Added.
wpe/HeadlessViewBackend/HeadlessViewBackend.cpp: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.cpp.

(HeadlessViewBackend::HeadlessViewBackend):

wpe/HeadlessViewBackend/HeadlessViewBackend.h: Renamed from Tools/WebKitTestRunner/wpe/HeadlessViewBackend.h.

12:38 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

12:16 AM Changeset in webkit [225044] by Carlos Garcia Campos

22 edits
3 adds in trunk

[WPE] webkit_web_view_new() should enable specifying wpe_view_backend object
https://bugs.webkit.org/show_bug.cgi?id=178655

Reviewed by Michael Catanzaro.

Source/WebKit:

Update all WebKitWebView constructors to receive a WebKitWebViewBackend as argument. It's now required to
provide a backend to create a web view, but it can be NULL to use the default one. WebKitWebViewBackend is a
boxed type wrapping a struct wpe_view_backend* used as construct only property of WebKitWebView. The view always
takes the ownership of the WebKitWebViewBackend which owns the struct wpe_view_backend*. An optional
GDestroyNotify and user data pointer can be passed to the WebKitWebViewBackend constructor to provide a custom
deleter for the backend. In the C API the struct wpe_view_backend* is also mandatory now, but it can't be NULL
and it's owned by the caller, not the view.

PlatformWPE.cmake:
UIProcess/API/C/wpe/WKView.cpp:

(WKViewCreate):

UIProcess/API/C/wpe/WKView.h:
UIProcess/API/glib/WebKitWebView.cpp:

(_WebKitWebViewPrivate::~_WebKitWebViewPrivate):
(webkitWebViewConstructed):
(webkitWebViewSetProperty):
(webkitWebViewGetProperty):
(webkit_web_view_class_init):
(webkitWebViewCreatePage):
(webkit_web_view_get_backend):

UIProcess/API/wpe/WPEView.cpp:

(WKWPE::m_backend):
(WKWPE::View::~View):

UIProcess/API/wpe/WebKitWebView.h:
UIProcess/API/wpe/WebKitWebViewBackend.cpp: Added.

(_WebKitWebViewBackend::_WebKitWebViewBackend):
(_WebKitWebViewBackend::~_WebKitWebViewBackend):
(webkitWebViewBackendRef):
(webkitWebViewBackendUnref):
(webkitWebViewBackendCreateDefault):
(webkit_web_view_backend_new):
(webkit_web_view_backend_get_wpe_backend):

UIProcess/API/wpe/WebKitWebViewBackend.h: Added.
UIProcess/API/wpe/WebKitWebViewBackendPrivate.h: Added.
UIProcess/API/wpe/WebKitWebViewWPE.cpp:

(webkit_web_view_new):
(webkit_web_view_new_with_context):
(webkit_web_view_new_with_related_view):
(webkit_web_view_new_with_settings):
(webkit_web_view_new_with_user_content_manager):

UIProcess/API/wpe/webkit.h:

Tools:

Update unit tests to create web views using helper methods that have a different implementation for GTK and
WPE. Also add a new test case to check the new API to create a WebKitWebView with a WPE backend. Use
WKViewCreate in WTR and fix a memory leak in HeadlessViewBackend.

TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

(testAutomationSessionRequestSession):

TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:

(testWebKitWebViewSessionState):
(testWebKitWebViewSessionStateWithFormData):
(testWebKitWebViewNavigationAfterSessionRestore):

TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:

(testWebResourceGetDataError):

TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:

(testWebViewNewWithUserContentManager):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(testWebContextEphemeral):

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:

(testWebViewWebContext):
(testWebViewWebContextLifetime):
(testWebViewWebBackend):
(testWebViewSettings):
(beforeAll):

TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:

(testWebsiteDataEphemeral):

TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::createWebView):

WebKitTestRunner/wpe/HeadlessViewBackend.cpp:

(HeadlessViewBackend::~HeadlessViewBackend):

WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::PlatformWebView):

12:11 AM Changeset in webkit [225043] by Carlos Garcia Campos

4 edits in trunk

[GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running
https://bugs.webkit.org/show_bug.cgi?id=175265

Reviewed by Michael Catanzaro.

Source/WebKit:

This is what happens:

1- We create our WebKitWebContext that creates its WebProcessPool.
2- We set a persistent cookies storage.
3- We ask the website data store to delete all cookies, but since website data store is a web process observer

and we haven't spawned any web process yet, it creates a new WebProcessPool with the default configuration
(no persistent cookies) and sends the message to delete the cookies there.

4- The network process of the second process pool does nothing because it doesn't have cookies at all.

We need to set the primary data store of the WebProcessPool when WebKitWebContext is constructed to ensure that
one is used before the web process is launched.

UIProcess/API/glib/WebKitWebContext.cpp:

(webkitWebContextConstructed):

Tools:

Add test case.

TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:

(testCookieManagerPersistentStorageDeleteAll):
(serverCallback):
(beforeAll):

Nov 19, 2017:

9:10 PM Changeset in webkit [225042] by timothy_horton@apple.com

18 edits in trunk

Remove unused TOUCH_ICON_LOADING feature flag
https://bugs.webkit.org/show_bug.cgi?id=179873

Reviewed by Simon Fraser.

Source/cmake/OptionsMac.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

7:53 PM Changeset in webkit [225041] by Ms2ger@igalia.com

2 edits
5 adds in trunk/LayoutTests

[WPE] Enable the XMLHttpRequest/ directory of web-platform-tests.
https://bugs.webkit.org/show_bug.cgi?id=179820

Reviewed by Sam Weinig.

Added test expectations are copied from platform/gtk/

platform/wpe/TestExpectations:
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-expected.txt: Added.
platform/wpe/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Added.

5:41 PM Changeset in webkit [225040] by Yusuke Suzuki

8 edits in trunk

Add CPU(UNKNOWN) to cover all the unknown CPU types
https://bugs.webkit.org/show_bug.cgi?id=179243

Reviewed by JF Bastien.

Drop SH4, S390, and S390X explicit support. They are handled as CPU(UNKNOWN).

CMakeLists.txt:

Source/JavaScriptCore:

CMakeLists.txt:

Source/WTF:

This patch adds a new CPU type, CPU(UNKNOWN) to cover all the unknown CPUs.
This CPU architecture tells conservative assumption to make JSC work on all
the unknown generic CPUs. And we make several CPUs (ALPHA, SH4, S390, S390X, IA64, IA64_32)
UNKNOWN.

We also make InlineASM available only for !CPU(UNKNOWN). In an unknown CPU, inline asm is not useful.

And we also introduce a generic way to detect 64bit pointer environment by using
SIZEOF_POINTER predefined macro, or UINTPTR_MAX > UINT32_MAX.

wtf/InlineASM.h:
wtf/Platform.h:
wtf/dtoa/utils.h:

5:31 PM Changeset in webkit [225039] by timothy_horton@apple.com

19 edits in trunk

Remove unused LEGACY_VENDOR_PREFIXES feature flag
https://bugs.webkit.org/show_bug.cgi?id=179872

Reviewed by Darin Adler.

Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

5:08 PM Changeset in webkit [225038] by Chris Dumez

2 edits in trunk/Source/WTF

Fix potential thread safety issue in ThreadSafeIdentified
https://bugs.webkit.org/show_bug.cgi?id=179879

Reviewed by Darin Adler.

Fix potential thread safety issue in ThreadSafeIdentified. Protect static std::atomic
initialization with an std::call_once() given that we build with
--fno-threadsafe-statics.

wtf/Identified.h:

(WTF::Identified::Identified):
(WTF::Identified::generateIdentifier):
(WTF::ThreadSafeIdentified::ThreadSafeIdentified):
(WTF::ThreadSafeIdentified::generateIdentifier):

4:56 PM Changeset in webkit [225037] by Darin Adler

38 edits in trunk/Source

Eliminate some cases of double hashing, other related refactoring
https://bugs.webkit.org/show_bug.cgi?id=179867

Reviewed by Sam Weinig.

Source/WebCore:

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore): Use get instead of find.

Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::unregisterURL): Use take instead of find/remove.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::~AXObjectCache): Call setAXObjectID instead of
using the removeAXID, which doesn't do anything else useful in the destructor.
(WebCore::AXObjectCache::remove): Use take instead of get/remove. Also rearrange
logic to eliminate the removeAXID function.
(WebCore::AXObjectCache::removeAXID): Deleted. This only did two things,
setAXObjectID(0) and remove from m_idsInUse, and was only called in one place
besides the destructor. Clearer to not have this funtion.
(WebCore::AXObjectCache::visiblePositionForTextMarkerData): Use m_idsInUse
directly instead of using a function.

accessibility/AXObjectCache.h: Deleted removeAXID and isIDinUse.

dom/Document.cpp:

(WebCore::Document::removedLastRef): Call UserActionElementSet::clear instead
of UserActionElementSet::documentDidRemoveLastRef; new name fo the same function.
(WebCore::Document::updateHoverActiveState): Use a reference when calling
setInActiveChain.

dom/Element.cpp:

(WebCore::Element::isUserActionElementInActiveChain const): Pass reference
instead of pointer.
(WebCore::Element::isUserActionElementActive const): Ditto.
(WebCore::Element::isUserActionElementFocused const): Ditto.
(WebCore::Element::isUserActionElementHovered const): Ditto.
(WebCore::Element::setActive): Ditto.
(WebCore::Element::setFocus): Ditto.
(WebCore::Element::setHovered): Ditto.
(WebCore::Element::clearHoverAndActiveStatusBeforeDetachingRenderer): Ditto.

dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::resume): Removed unneeded speical case for
empty vector.

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet): Updated now that
parseAttributes returns an optional instead of using a boolean "OK" out argument.

dom/SelectorQuery.cpp:

(WebCore::SelectorQueryCache::add): Use get instead of find.

dom/UserActionElementSet.cpp:

(WebCore::UserActionElementSet::didDetach): Deleted. Moved to class definition and
named clearActiveAndHovered.
(WebCore::UserActionElementSet::clear): Renamed documentDidRemoveLastRef to clear.
(WebCore::UserActionElementSet::hasFlag const): Renamed from hasFlags and also
take reference and enumeration instead of pointer and unsigned. Makes it clearer
this does not allow null and that it works on a single flag, not a set of flags.
(WebCore::UserActionElementSet::clearFlags): Changed argument types to reference
and OptionSet to make it clear this works on a set of flags.
(WebCore::UserActionElementSet::setFlags): Ditto.

dom/UserActionElementSet.h: Updated for changes above. Also made some name

changes, and used an enum class instead of an enum.

html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState const): Updated since
FormControlState is now just a vector, not a class.

html/FileInputType.cpp:

(WebCore::FileInputType::filesFromFormControlState): Ditto.
(WebCore::FileInputType::restoreFormControlState): Removed unneeded check that
valueSize is a multiple of 2. Code will ignore any extra strings at the end, so
there is no need for the validity check.

html/FormController.cpp:

(WebCore::serializeFormControlStateTo): Made a non-member function since
FormControlState is now just a vector, not a class.
(WebCore::deserializeFormControlState): Ditto. Also return optional instead
of relying on a special failure state.
(WebCore::SavedFormState::deserialize): Updated for above changes.
(WebCore::SavedFormState::serializeTo const): Ditto.
(WebCore::SavedFormState::appendControlState): Use add instead of both find and add
to avoid double hashing.
(WebCore::SavedFormState::takeControlState): Removed unneeded check for empty
hash table and tweaked coding style.
(WebCore::SavedFormState::referencedFilePaths const): Renamed to remove "get".
(WebCore::FormKeyGenerator::formKey): Use ensure instead of find and add.
(WebCore::FormController::formElementsCharacterCount const): Don't call
saveFormControlState for non-text-form-controls since we ignored those values.
(WebCore::FormController::willDeleteForm): Take a reference.
(WebCore::FormController::restoreControlStateFor): Update since FormControlState
is now a vector.
(WebCore::FormController::restoreControlStateIn): Use is/downcast and update
since FormControlState is now a vector.
(WebCore::FormController::referencedFilePaths): Renamed to remove "get".
(WebCore::FormController::registerFormElementWithState):Take a reference.
(WebCore::FormController::unregisterFormElementWithState): Ditto.

html/FormController.h: Removed FormControlState class since it was just a

Vector<String> with various unneeded features, such as a "failure" state,
and a never-looked-at type of "skip" or "restore". Updated for other changes
above.

html/HTMLFormControlElementWithState.cpp:

(WebCore::HTMLFormControlElementWithState::insertedIntoAncestor): Pass reference.
(WebCore::HTMLFormControlElementWithState::removedFromAncestor): Ditto.

html/HTMLFormControlElementWithState.h: Updated for the above. Also added

support for using is/downcast on this.

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::~HTMLFormElement): Pass reference.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::saveFormControlState const): Use reserveInitialCapacit
and uncheckedAppend.
(WebCore::HTMLSelectElement::restoreFormControlState): Updated since state is now
a vector.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::saveFormControlState const): Ditto.

html/HiddenInputType.cpp:

(WebCore::HiddenInputType::saveFormControlState const): Ditto.

html/InputType.cpp:

(WebCore::InputType::saveFormControlState const): Ditto.

inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::forcePseudoState): Use get instead of find/end and got
rid of uneeded special case. In another overload, ue add and remove instead of
a find followed by a set or a remove.
(WebCore::InspectorCSSAgent::asInspectorStyleSheet): Use ensure instead of find/set.
(WebCore::InspectorCSSAgent::didRemoveDOMNode): Use take instead of find/remove.
(WebCore::InspectorCSSAgent::didModifyDOMAttr): Use get instead of find.

inspector/agents/InspectorCSSAgent.h: Removed unneeded NodeToInspectorStyleSheet

typedef and changed value type to Ref instead of RefPtr.

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::unbind): Use remove instead of contains/remove.
(WebCore::InspectorDOMAgent::nodeForId): Use isValidKey instead of just checking for
0 and use get instead of find.
(WebCore::InspectorDOMAgent::setAttributesAsText): Take out bogus const.
(WebCore::InspectorDOMAgent::moveTo): Ditto.
(WebCore::InspectorDOMAgent::resolveNode): Ditto.
(WebCore::InspectorDOMAgent::isWhitespace): Added FIXME. Use is<Text> instead of
slower nodeType.

inspector/agents/InspectorDOMAgent.h: Removed bogus const.

inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::bind): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbind): Use take instead of find/remove.
(WebCore::InspectorLayerTreeAgent::bindPseudoElement): Use ensure instead of get/set.
(WebCore::InspectorLayerTreeAgent::unbindPseudoElement): Use take instead of
find/remove.

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies): Use add instead of contains/add.
(WebCore::InspectorPageAgent::frameDetached): Use take instead of find/remove.
(WebCore::InspectorPageAgent::frameId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::loaderId): Use ensure instead of get/set.
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Got rid of unneeded
local variable.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::sessionID const): Tweaked coding style and added
a null check for page.
(WebCore::CachedResourceLoader::requestResource): Call page directly on the frame
instead of first getting the main frame. Also use take instead of find/remove.
(WebCore::CachedResourceLoader::removeCachedResource): Rewrite assertion.

platform/graphics/FontGenericFamilies.cpp:

(WebCore::setGenericFontFamilyForScript): Use remove instead of find/remove.
Simplified the logic a bit in the add case.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::pauseAnimation): Use add instead of find/add.
Removed code that said "if (action != Remove) action = Pause" since that is a
no-op; there are only two actions, Remove and Pause.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsScript): Use makeString instead of StringBuilder.
(WebCore::RenderThemeMac::systemColor const): Rewrote to use ensure instead of add.
Also crunched the code a little.

testing/Internals.cpp:

(WebCore::Internals::getReferencedFilePaths const): Updated function name.

xml/parser/XMLDocumentParser.h: Updated for change below.
xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::attributesStartElementNsHandler): Updated to use std::optional instead of
a separate boolean for AttributeParseState.
(WebCore::parseAttributes): Ditto. Also changed the return value to work the same way.

Source/WTF:

wtf/text/StringImpl.cpp:

(WTF::StringImpl::containsOnlyWhitespace): Added FIXME.

3:06 PM Changeset in webkit [225036] by commit-queue@webkit.org

15 edits in trunk/Source/WebCore

Clean up gradient code in preparation for conic gradients
https://bugs.webkit.org/show_bug.cgi?id=179595

Patch by Sam Weinig <sam@webkit.org> on 2017-11-19
Reviewed by Darin Adler.

Switches Gradient to use a Varient with type specific data structs and makes the points / radii immutable.
Replaces CSSGradientValue::addStops with template function CSSGradientValue::computeStops which dispatches to a helper adoptor struct which is passed in for gradient type specific values, rather than switching on type in the function itself. In addition, the function no longer mutates a Gradient, but rather mutates type specific the data struct (e.g. Linear or Radial for now).

css/CSSGradientValue.cpp:

(WebCore::LinearGradientAdaptor::LinearGradientAdaptor):
(WebCore::RadialGradientAdaptor::RadialGradientAdaptor):

Add helper structs for the now templatized CSSGradientValue::computeStops that
implement type specific functionality.

(WebCore::CSSGradientValue::computeStops):

Renamed from addStops. Now takes a GradientAdaptor wrapper which abstracts out
the gradient type specific functionlity.

(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::createGradient):
(WebCore::CSSConicGradientValue::createGradient):

Update to call computeStops and use new Gradient create function.

css/CSSGradientValue.h:

Update for new signature for computeStops.

html/canvas/CanvasGradient.cpp:

(WebCore::CanvasGradient::CanvasGradient):

Update to use new Gradient create function.

inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildArrayForCanvasGradient):

Update to get gradient point / radii information from the data accessor.

platform/graphics/Gradient.cpp:

(WebCore::Gradient::Gradient):

Update constructors to the new data structs.

(WebCore::Gradient::type const):

Add helper to get the type of the varient, need for inspector code.

(WebCore::Gradient::adjustParametersForTiledDrawing):
(WebCore::Gradient::isZeroSize const):
(WebCore::Gradient::hash const):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::addColorStop):

Simplify by having one addColorStop call the other.

(WebCore::Gradient::setSortedColorStops):

Added. Replaces setStopsSorted. Used now that CSSGradientValue computes and sorts
its color stops before creating the gradient.

platform/graphics/Gradient.h:

(WebCore::Gradient::create):

Replace create functions with ones that take data structs.

(WebCore::Gradient::data const):

Add accessor for the underlying variant.

(WebCore::Gradient::isRadial const): Deleted.

Replaced by type accessor.

(WebCore::Gradient::p0 const): Deleted.
(WebCore::Gradient::p1 const): Deleted.
(WebCore::Gradient::setP0): Deleted.
(WebCore::Gradient::setP1): Deleted.
(WebCore::Gradient::startRadius const): Deleted.
(WebCore::Gradient::endRadius const): Deleted.
(WebCore::Gradient::setStartRadius): Deleted.
(WebCore::Gradient::setEndRadius): Deleted.

Point and radii are now immutable.

(WebCore::Gradient::setStopsSorted): Deleted.

Replaced by setSortedColorStops function.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillRect):

Pass the GraphicsContext by reference.

platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::createPlatformGradient):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::platformDestroy):

Use nullptr.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

(WebCore::Gradient::paint):

Update to switch on the underlying variant to get data values.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):

Pass the GraphicsContext by reference.

platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::generateGradient):

Update to switch on the underlying variant to get data values.

(WebCore::Gradient::fill):

Pass the GraphicsContext by reference.

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintProgressBar):

rendering/svg/RenderSVGResourceLinearGradient.cpp:

(WebCore::RenderSVGResourceLinearGradient::buildGradient const):

rendering/svg/RenderSVGResourceRadialGradient.cpp:

(WebCore::RenderSVGResourceRadialGradient::buildGradient const):

Update for new Gradient create function signature.

1:57 PM Changeset in webkit [225035] by Simon Fraser

2 edits in trunk/Source/WebCore

Use TypedArrayView's setRange() in FETurbulence
https://bugs.webkit.org/show_bug.cgi?id=179878

Reviewed by Sam Weinig.

Writing the 4 component values at once makes the function about 10% faster.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):

1:56 PM Changeset in webkit [225034] by Chris Dumez

2 edits in trunk/Source/WTF

Fix potential thread safety issue in generateThreadSafeObjectIdentifier()
https://bugs.webkit.org/show_bug.cgi?id=179877

Reviewed by Sam Weinig.

Fix potential thread safety issue in generateThreadSafeObjectIdentifier().
Protect std::atomic initialization with an std::call_once() given that we
build with --fno-threadsafe-statics.

wtf/ObjectIdentifier.h:

(WTF::generateThreadSafeObjectIdentifier):

7:06 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

12:19 AM Changeset in webkit [225033] by Yusuke Suzuki

5 edits
2 deletes in trunk/Tools

Unreviewed, rolling out r225016.

Break webkit-patch on Ubuntu and Debian Linux

Reverted changeset:

"webkitpy: Better name-version mapping (Part 1)"
https://bugs.webkit.org/show_bug.cgi?id=179621
https://trac.webkit.org/changeset/225016

12:07 AM Changeset in webkit [225032] by Yusuke Suzuki

2 edits in trunk/Source/WTF

[WTF] Use system endianess information instead of relying CPU information
https://bugs.webkit.org/show_bug.cgi?id=179861

Reviewed by JF Bastien.

Currently, we use known CPU information to determine endianess of the current
architecture. But this means that unknown CPU does not work well in WebKit
withou modifying code. Instead, we use compiler or system's macro to determine
endianess. This paves the way to dropping many CPUs in Platform.h by replacing
them with CPU(UNKNOWN)[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=179243

wtf/Platform.h:

Nov 18, 2017:

11:19 PM Changeset in webkit [225031] by Chris Dumez

35 edits
1 copy in trunk

ASSERTION FAILED: registration in WebCore::SWServerJobQueue::scriptContextStarted(ServiceWorkerIdentifier)
https://bugs.webkit.org/show_bug.cgi?id=179846

Reviewed by Darin Adler.

Source/WebCore:

We have seen crashes on the bots in SWServerJobQueue because methods such as scriptContextStarted()
can get called after the jobQueue has been cleared. This is because when a jobQueue is cleared,
an asynchronous operation may be pending (e.g. script fetch, service worker starting, install event).

To address the issue, we now pass the identifier of the job that started the asynchronous operation
when calling the methods on SWServerJobQueue. If the identifier does not match the identifier of
the current job in the JobQueue, we ignore it.

This patch also starts using a strongly typed identifier (ServiceWorkerJobIdentifier) for
ServiceWorkerJob, instead of a uint64_t. It also introduces a ServiceWorkerJobDataIdentifier type
which contains both a SWServerConnectionIdentifier and a ServiceWorkerJobIdentifier. This is useful
because ServiceWorkerJobData is passed to the StorageProcess and it needs a globally unique identifier.
ServiceWorkerJobIdentifier is only guaranteed to be unique within a single WebProcess. Augmenting it
with the SWServerConnectionIdentifier of the WebProcess makes it globally unique.

No new tests, unskipped exiting test.

WebCore.xcodeproj/project.pbxproj:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerContextData.cpp:

(WebCore::ServiceWorkerContextData::isolatedCopy const):

workers/service/ServiceWorkerContextData.h:

(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

workers/service/ServiceWorkerFetchResult.h:

(WebCore::ServiceWorkerFetchResult::encode const):
(WebCore::ServiceWorkerFetchResult::decode):

workers/service/ServiceWorkerJob.h:

(WebCore::ServiceWorkerJob::identifier const):

workers/service/ServiceWorkerJobData.cpp:

(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):
(WebCore::ServiceWorkerJobData::isolatedCopy const):

workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::identifier const):
(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

workers/service/ServiceWorkerJobDataIdentifier.h: Copied from Source/WebCore/workers/service/ServiceWorkerFetchResult.h.

(WebCore::ServiceWorkerJobDataIdentifier::operator== const):
(WebCore::ServiceWorkerJobDataIdentifier::loggingString const):
(WebCore::ServiceWorkerJobDataIdentifier::encode const):
(WebCore::ServiceWorkerJobDataIdentifier::decode):

workers/service/ServiceWorkerTypes.h:
workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::registerServiceWorkerThreadForInstall):

workers/service/context/SWContextManager.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::fireInstallEvent):

workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::finishedFetchingScript):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):

workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::didFinishInstall):
(WebCore::SWServer::updateWorker):

workers/service/server/SWServer.h:
workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::isCurrentlyProcessingJob const):
(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::scriptContextStarted):
(WebCore::SWServerJobQueue::didFinishInstall):

workers/service/server/SWServerJobQueue.h:
workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::scriptContextFailedToStart):
(WebCore::SWServerToContextConnection::scriptContextStarted):
(WebCore::SWServerToContextConnection::didFinishInstall):

workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::scriptContextFailedToStart):
(WebCore::SWServerWorker::scriptContextStarted):
(WebCore::SWServerWorker::didFinishInstall):

workers/service/server/SWServerWorker.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::rejectJobInClient):
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
(WebKit::WebSWServerConnection::startScriptFetchInClient):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.messages.in:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::didFinishInstall):

WebProcess/Storage/WebSWContextManagerConnection.h:

Source/WTF:

Add a generateThreadSafeObjectIdentifier() for generating an ObjectIdentifier
in a thread-safe manner, using std::atomic.

wtf/ObjectIdentifier.h:

(WTF::generateObjectIdentifier):
(WTF::generateThreadSafeObjectIdentifier):

LayoutTests:

Unskip test that use to flakily crash.

platform/mac/TestExpectations:

10:59 PM Changeset in webkit [225030] by n_wang@apple.com

24 edits
2 adds in trunk

AX: AOM: Implement number type properties
https://bugs.webkit.org/show_bug.cgi?id=179497

Reviewed by Chris Fleizach.

Source/WebCore:

Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/

Implemented the number type properties for Accessibility Object Modal.

Test: accessibility/mac/AOM-number-properties.html

accessibility/AXObjectCache.cpp:

(WebCore::isNodeAriaVisible):

accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::isMultiSelectable const):

accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange const):
(WebCore::AccessibilityARIAGridCell::axRowSpanWithRowIndex const):
(WebCore::AccessibilityARIAGridCell::columnIndexRange const):
(WebCore::AccessibilityARIAGridCell::ariaRowSpanWithRowIndex const): Deleted.

accessibility/AccessibilityARIAGridCell.h:
accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled const):
(WebCore::AccessibilityNodeObject::isMultiSelectable const):
(WebCore::AccessibilityNodeObject::isRequired const):
(WebCore::AccessibilityNodeObject::headingLevel const):
(WebCore::AccessibilityNodeObject::valueForRange const):
(WebCore::AccessibilityNodeObject::maxValueForRange const):
(WebCore::AccessibilityNodeObject::minValueForRange const):
(WebCore::AccessibilityNodeObject::hierarchicalLevel const):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::intValueForProperty const):
(WebCore::AccessibilityObject::unsignedValueForProperty const):
(WebCore::AccessibilityObject::doubleValueForProperty const):
(WebCore::AccessibilityObject::supportsSetSize const):
(WebCore::AccessibilityObject::supportsPosInSet const):
(WebCore::AccessibilityObject::setSize const):
(WebCore::AccessibilityObject::posInSet const):
(WebCore::AccessibilityObject::supportsARIASetSize const): Deleted.
(WebCore::AccessibilityObject::supportsARIAPosInSet const): Deleted.
(WebCore::AccessibilityObject::ariaSetSize const): Deleted.
(WebCore::AccessibilityObject::ariaPosInSet const): Deleted.

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable const):
(WebCore::AccessibilityTable::axColumnCount const):
(WebCore::AccessibilityTable::axRowCount const):
(WebCore::AccessibilityTable::ariaColumnCount const): Deleted.
(WebCore::AccessibilityTable::ariaRowCount const): Deleted.

accessibility/AccessibilityTable.h:
accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::AccessibilityTableCell):
(WebCore::AccessibilityTableCell::rowIndexRange const):
(WebCore::AccessibilityTableCell::columnIndexRange const):
(WebCore::AccessibilityTableCell::axColumnIndex const):
(WebCore::AccessibilityTableCell::axRowIndex const):
(WebCore::AccessibilityTableCell::axColumnSpan const):
(WebCore::AccessibilityTableCell::axRowSpan const):
(WebCore::AccessibilityTableCell::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowIndex const): Deleted.
(WebCore::AccessibilityTableCell::ariaColumnSpan const): Deleted.
(WebCore::AccessibilityTableCell::ariaRowSpan const): Deleted.

accessibility/AccessibilityTableCell.h:

(WebCore::AccessibilityTableCell::setAXColIndexFromRow):
(WebCore::AccessibilityTableCell::setARIAColIndexFromRow): Deleted.

accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::addChildren):
(WebCore::AccessibilityTableRow::axColumnIndex const):
(WebCore::AccessibilityTableRow::axRowIndex const):
(WebCore::AccessibilityTableRow::ariaColumnIndex const): Deleted.
(WebCore::AccessibilityTableRow::ariaRowIndex const): Deleted.

accessibility/AccessibilityTableRow.h:
accessibility/AccessibleNode.cpp:

(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueInt):
(WebCore::isPropertyValueUnsigned):
(WebCore::isPropertyValueFloat):
(WebCore::AccessibleNode::setProperty):
(WebCore::AccessibleNode::setOptionalProperty):
(WebCore::AccessibleNode::setStringProperty):
(WebCore::AccessibleNode::optionalValueForProperty):
(WebCore::AccessibleNode::effectiveBoolValueForElement):
(WebCore::AccessibleNode::effectiveIntValueForElement):
(WebCore::AccessibleNode::effectiveUnsignedValueForElement):
(WebCore::AccessibleNode::effectiveDoubleValueForElement):
(WebCore::AccessibleNode::atomic const):
(WebCore::AccessibleNode::setAtomic):
(WebCore::AccessibleNode::setAutocomplete):
(WebCore::AccessibleNode::busy const):
(WebCore::AccessibleNode::setBusy):
(WebCore::AccessibleNode::setChecked):
(WebCore::AccessibleNode::colCount const):
(WebCore::AccessibleNode::setColCount):
(WebCore::AccessibleNode::colIndex const):
(WebCore::AccessibleNode::setColIndex):
(WebCore::AccessibleNode::colSpan const):
(WebCore::AccessibleNode::setColSpan):
(WebCore::AccessibleNode::setCurrent):
(WebCore::AccessibleNode::disabled const):
(WebCore::AccessibleNode::setDisabled):
(WebCore::AccessibleNode::expanded const):
(WebCore::AccessibleNode::setExpanded):
(WebCore::AccessibleNode::setHasPopUp):
(WebCore::AccessibleNode::hidden const):
(WebCore::AccessibleNode::setHidden):
(WebCore::AccessibleNode::setInvalid):
(WebCore::AccessibleNode::setKeyShortcuts):
(WebCore::AccessibleNode::label const):
(WebCore::AccessibleNode::setLabel):
(WebCore::AccessibleNode::level const):
(WebCore::AccessibleNode::setLevel):
(WebCore::AccessibleNode::live const):
(WebCore::AccessibleNode::setLive):
(WebCore::AccessibleNode::modal const):
(WebCore::AccessibleNode::setModal):
(WebCore::AccessibleNode::multiline const):
(WebCore::AccessibleNode::setMultiline):
(WebCore::AccessibleNode::multiselectable const):
(WebCore::AccessibleNode::setMultiselectable):
(WebCore::AccessibleNode::setOrientation):
(WebCore::AccessibleNode::setPlaceholder):
(WebCore::AccessibleNode::posInSet const):
(WebCore::AccessibleNode::setPosInSet):
(WebCore::AccessibleNode::setPressed):
(WebCore::AccessibleNode::readOnly const):
(WebCore::AccessibleNode::setReadOnly):
(WebCore::AccessibleNode::setRelevant):
(WebCore::AccessibleNode::required const):
(WebCore::AccessibleNode::setRequired):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::setRoleDescription):
(WebCore::AccessibleNode::rowCount const):
(WebCore::AccessibleNode::setRowCount):
(WebCore::AccessibleNode::rowIndex const):
(WebCore::AccessibleNode::setRowIndex):
(WebCore::AccessibleNode::rowSpan const):
(WebCore::AccessibleNode::setRowSpan):
(WebCore::AccessibleNode::selected const):
(WebCore::AccessibleNode::setSelected):
(WebCore::AccessibleNode::setSize const):
(WebCore::AccessibleNode::setSetSize):
(WebCore::AccessibleNode::setSort):
(WebCore::AccessibleNode::valueMax const):
(WebCore::AccessibleNode::setValueMax):
(WebCore::AccessibleNode::valueMin const):
(WebCore::AccessibleNode::setValueMin):
(WebCore::AccessibleNode::valueNow const):
(WebCore::AccessibleNode::setValueNow):
(WebCore::AccessibleNode::setValueText):
(WebCore::AccessibleNode::boolValueForProperty): Deleted.
(WebCore::AccessibleNode::setBoolProperty): Deleted.

accessibility/AccessibleNode.h:
accessibility/AccessibleNode.idl:
accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):

accessibility/atk/WebKitAccessibleInterfaceTableCell.cpp:

(webkitAccessibleTableCellGetPosition):

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityARIARowCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnCount]):
(-[WebAccessibilityObjectWrapper accessibilityARIARowIndex]):
(-[WebAccessibilityObjectWrapper accessibilityARIAColumnIndex]):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

accessibility/mac/AOM-number-properties-expected.txt: Added.
accessibility/mac/AOM-number-properties.html: Added.

9:05 PM Changeset in webkit [225029] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit

Rename some Network Capture debugging defines
https://bugs.webkit.org/show_bug.cgi?id=179870

Reviewed by Darin Adler.

NetworkProcess/capture/NetworkCaptureLogging.h:
NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::findMatch):
(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
These shouldn't have WTF in their name - they have nothing to do with WTF.
These shouldn't use ENABLE(), since they're not features, just debugging macros.

7:48 PM Changeset in webkit [225028] by timothy_horton@apple.com

6 edits in trunk/Source

Fix typos in closing ENABLE() comments
https://bugs.webkit.org/show_bug.cgi?id=179869

Unreviewed.

Source/JavaScriptCore:

wasm/WasmMemory.h:
wasm/WasmMemoryMode.h:

Source/WebCore:

platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h:
platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:

7:42 PM Changeset in webkit [225027] by mjs@apple.com

11 edits
2 adds
9 deletes in trunk

Remove TEC support and all TEC-only encodings except EUC-TW (which now uses ICU)
https://bugs.webkit.org/show_bug.cgi?id=179582

Reviewed by Darin Adler.

Source/WebCore:

Already covered by fast/encoding/legacy-tec-encodings.html

platform/text/TextCodecICU.cpp: Add support for EUC-TW.

Remove all vestiges of TEC text codec and its related autogeneration scripts.

DerivedSources.make:
PlatformMac.cmake:
SourcesMac.txt:
WebCore.order:
WebCore.xcodeproj/project.pbxproj:
platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData): No more cached TEC decoder.
(WebCore::ThreadGlobalData::destroy): ditto

platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::ThreadGlobalData::cachedConverterTEC): Deleted.

platform/text/TextEncodingRegistry.cpp:

(WebCore::extendTextCodecMaps): Don't add TEC decoders on MAc.

platform/text/mac/CharsetData.h: Removed.
platform/text/mac/TextCodecMac.cpp: Removed.
platform/text/mac/TextCodecMac.h: Removed.
platform/text/mac/character-sets.txt: Removed.
platform/text/mac/ios-encodings.txt: Removed.
platform/text/mac/mac-encodings.txt: Removed.
platform/text/mac/make-charset-table.pl: Removed.

LayoutTests:

fast/encoding/legacy-tec-encodings.html: Added. Verify that we

no longer support these encodings.

fast/encoding/legacy-tec-encodings-expected.txt: Added.
platform/mac/fast/encoding/xnextstep-decoding.html: Removed. We no longer support this encoding.
platform/mac/fast/encoding/xnextstep-decoding-expected.txt: Removed.

5:55 PM Changeset in webkit [225026] by Simon Fraser

42 edits in trunk/Source/WebCore

Mechanical cleanup of FE* files
https://bugs.webkit.org/show_bug.cgi?id=179868

Reviewed by Wenson Hsieh.

Remove unused dump() functions.
Make overridden member functions in derived classes private.
Make simple getters inline.

Move common FESpecularLighting and FEDiffuseLighting functions into the
FELighting base class.

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::blendMode const): Deleted.
(WebCore::FEBlend::dump): Deleted.

platform/graphics/filters/FEBlend.h:

(WebCore::FEBlend::blendMode const):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::type const): Deleted.
(WebCore::FEColorMatrix::values const): Deleted.
(WebCore::FEColorMatrix::dump): Deleted.

platform/graphics/filters/FEColorMatrix.h:

(WebCore::FEColorMatrix::type const):
(WebCore::FEColorMatrix::values const):

platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::redFunction const): Deleted.
(WebCore::FEComponentTransfer::greenFunction const): Deleted.
(WebCore::FEComponentTransfer::blueFunction const): Deleted.
(WebCore::FEComponentTransfer::alphaFunction const): Deleted.
(WebCore::FEComponentTransfer::dump): Deleted.

platform/graphics/filters/FEComponentTransfer.h:

(WebCore::FEComponentTransfer::redFunction const):
(WebCore::FEComponentTransfer::greenFunction const):
(WebCore::FEComponentTransfer::blueFunction const):
(WebCore::FEComponentTransfer::alphaFunction const):

platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::operation const): Deleted.
(WebCore::FEComposite::k1 const): Deleted.
(WebCore::FEComposite::k2 const): Deleted.
(WebCore::FEComposite::k3 const): Deleted.
(WebCore::FEComposite::k4 const): Deleted.
(WebCore::FEComposite::dump): Deleted.

platform/graphics/filters/FEComposite.h:

(WebCore::FEComposite::operation const):
(WebCore::FEComposite::k1 const):
(WebCore::FEComposite::k2 const):
(WebCore::FEComposite::k3 const):
(WebCore::FEComposite::k4 const):

platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::kernelSize const): Deleted.
(WebCore::FEConvolveMatrix::kernel const): Deleted.
(WebCore::FEConvolveMatrix::divisor const): Deleted.
(WebCore::FEConvolveMatrix::bias const): Deleted.
(WebCore::FEConvolveMatrix::targetOffset const): Deleted.
(WebCore::FEConvolveMatrix::edgeMode const): Deleted.
(WebCore::FEConvolveMatrix::kernelUnitLength const): Deleted.
(WebCore::FEConvolveMatrix::preserveAlpha const): Deleted.
(WebCore::FEConvolveMatrix::dump): Deleted.

platform/graphics/filters/FEConvolveMatrix.h:

(WebCore::FEConvolveMatrix::kernelSize const):
(WebCore::FEConvolveMatrix::kernel const):
(WebCore::FEConvolveMatrix::divisor const):
(WebCore::FEConvolveMatrix::bias const):
(WebCore::FEConvolveMatrix::targetOffset const):
(WebCore::FEConvolveMatrix::edgeMode const):
(WebCore::FEConvolveMatrix::kernelUnitLength const):
(WebCore::FEConvolveMatrix::preserveAlpha const):

platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::lightingColor const): Deleted.
(WebCore::FEDiffuseLighting::setLightingColor): Deleted.
(WebCore::FEDiffuseLighting::surfaceScale const): Deleted.
(WebCore::FEDiffuseLighting::setSurfaceScale): Deleted.
(WebCore::FEDiffuseLighting::diffuseConstant const): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthX const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthX): Deleted.
(WebCore::FEDiffuseLighting::kernelUnitLengthY const): Deleted.
(WebCore::FEDiffuseLighting::setKernelUnitLengthY): Deleted.
(WebCore::FEDiffuseLighting::lightSource const): Deleted.
(WebCore::FEDiffuseLighting::dump): Deleted.

platform/graphics/filters/FEDiffuseLighting.h:

(WebCore::FEDiffuseLighting::diffuseConstant const):

platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::xChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::yChannelSelector const): Deleted.
(WebCore::FEDisplacementMap::scale const): Deleted.
(WebCore::FEDisplacementMap::dump): Deleted.

platform/graphics/filters/FEDisplacementMap.h:

(WebCore::FEDisplacementMap::xChannelSelector const):
(WebCore::FEDisplacementMap::yChannelSelector const):
(WebCore::FEDisplacementMap::scale const):

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::dump): Deleted.

platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::floodColor const): Deleted.
(WebCore::FEFlood::floodOpacity const): Deleted.
(WebCore::FEFlood::dump): Deleted.

platform/graphics/filters/FEFlood.h:

(WebCore::FEFlood::floodColor const):
(WebCore::FEFlood::floodOpacity const):

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::stdDeviationX const): Deleted.
(WebCore::FEGaussianBlur::stdDeviationY const): Deleted.
(WebCore::FEGaussianBlur::edgeMode const): Deleted.
(WebCore::FEGaussianBlur::dump): Deleted.

platform/graphics/filters/FEGaussianBlur.h:

(WebCore::FEGaussianBlur::stdDeviationX const):
(WebCore::FEGaussianBlur::stdDeviationY const):
(WebCore::FEGaussianBlur::edgeMode const):

platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::setSurfaceScale):
(WebCore::FELighting::setLightingColor):
(WebCore::FELighting::setKernelUnitLengthX):
(WebCore::FELighting::setKernelUnitLengthY):

platform/graphics/filters/FELighting.h:

(WebCore::FELighting::surfaceScale const):
(WebCore::FELighting::lightingColor const):
(WebCore::FELighting::kernelUnitLengthX const):
(WebCore::FELighting::kernelUnitLengthY const):
(WebCore::FELighting::lightSource const):

platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::dump): Deleted.

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::dump): Deleted.

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::dx const): Deleted.
(WebCore::FEOffset::dy const): Deleted.
(WebCore::FEOffset::dump): Deleted.

platform/graphics/filters/FEOffset.h:

(WebCore::FEOffset::dx const):
(WebCore::FEOffset::dy const):

platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::lightingColor const): Deleted.
(WebCore::FESpecularLighting::setLightingColor): Deleted.
(WebCore::FESpecularLighting::surfaceScale const): Deleted.
(WebCore::FESpecularLighting::setSurfaceScale): Deleted.
(WebCore::FESpecularLighting::specularConstant const): Deleted.
(WebCore::FESpecularLighting::specularExponent const): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthX const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthX): Deleted.
(WebCore::FESpecularLighting::kernelUnitLengthY const): Deleted.
(WebCore::FESpecularLighting::setKernelUnitLengthY): Deleted.
(WebCore::FESpecularLighting::lightSource const): Deleted.
(WebCore::FESpecularLighting::dump): Deleted.

platform/graphics/filters/FESpecularLighting.h:

(WebCore::FESpecularLighting::specularConstant const):
(WebCore::FESpecularLighting::specularExponent const):

platform/graphics/filters/FETile.cpp:

(WebCore::FETile::dump): Deleted.

platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::dump): Deleted.

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.h:
platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::dump): Deleted.

platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::dump): Deleted.

platform/graphics/filters/SourceGraphic.h:
svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::dump): Deleted.

svg/graphics/filters/SVGFEImage.h:

5:35 PM Changeset in webkit [225025] by Simon Fraser

2 edits in trunk/Source/WebCore

Attempt to fix Windows build failures seen in EWS.

Remove default constructor for ColorComponents, which was ambiguous with the
one that takes 4 values.

platform/graphics/ColorUtilities.h:

4:48 PM Changeset in webkit [225024] by Simon Fraser

3 edits
2 adds in trunk

Line of garbage pixels at the bottom of an feTurbulence sometimes
https://bugs.webkit.org/show_bug.cgi?id=179866

Reviewed by Wenson Hsieh.
Source/WebCore:

The ParallelJobs logic was broken in that the sum of the computed job
heights was one too short sometimes. Fix and clean up the logic.

Test: svg/filters/feTurbulence-parallel-jobs.html

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

LayoutTests:

svg/filters/feTurbulence-parallel-jobs-expected.html: Added.
svg/filters/feTurbulence-parallel-jobs.html: Added.

2:50 PM Changeset in webkit [225023] by Simon Fraser

16 edits in trunk/Source/WebCore

Use #pragma once in FE* files.

Rubber-stamped by Dan Bates.

platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDiffuseLighting.h:
platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FELighting.h:
platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FESpecularLighting.h:
platform/graphics/filters/FETile.h:

2:44 PM Changeset in webkit [225022] by Simon Fraser

2 edits in trunk/Source/WebCore

Remove a TimingScope that I left in by mistake.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

2:40 PM Changeset in webkit [225021] by Simon Fraser

3 edits in trunk/Source/WebCore

FETurbulence: round the result according to the spec
https://bugs.webkit.org/show_bug.cgi?id=179865

Reviewed by Zalan Bujtas.

The spec explicitly says that the floating point results are multiplied by 255 then
clamped between 0 and 255, so do this instead of using lroundf().

This is also faster (about 10%).

platform/graphics/ColorUtilities.h:

(WebCore::ColorComponents::ColorComponents):

platform/graphics/filters/FETurbulence.cpp:

(WebCore::toColorComponents):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):

2:06 PM Changeset in webkit [225020] by Simon Fraser

25 edits in trunk

More FETurbulence cleanup
https://bugs.webkit.org/show_bug.cgi?id=179863

Reviewed by Zalan Bujtas.

Source/WebCore:

Hoist computation of initial StitchData up to be done once per filter,
not once per pixel. Passing initial StitchData by value to calculateTurbulenceValueForPoint()
ensures that each pixel gets the initial state.

Also, adjusted baseFrequencyX and baseFrequencyY can be computed just once at the start,
and passed through via PaintingData.

Change enum TurbulenceType to be an enum class (requiring casts in a couple of places)
and undo the capitalization of the values.

Fix spelling of TURBULANCE -> TURBULENCE in test output.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::computeStitching const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):
(WebCore::operator<<):

platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::PaintingData::PaintingData):
(WebCore::FETurbulence::StitchData::StitchData): Deleted.

svg/SVGAnimatedEnumeration.cpp:

(WebCore::enumerationValueForTargetAttribute):

svg/SVGFETurbulenceElement.cpp:

(WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
(WebCore::SVGFETurbulenceElement::parseAttribute):

svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<TurbulenceType>::highestEnumValue):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::fromString):

LayoutTests:

Fix spelling of TURBULANCE -> TURBULENCE.

platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/gtk/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/ios/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/ios/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/ios/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/win/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
platform/wpe/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/wpe/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
platform/wpe/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:

1:59 PM Changeset in webkit [225019] by commit-queue@webkit.org

6 edits in trunk/Source/WebInspectorUI

Web Inspector: Update the Trash / Clear icon
https://bugs.webkit.org/show_bug.cgi?id=179850

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-18
Reviewed by Matt Baker.

UserInterface/Images/NavigationItemTrash.svg:

Update the icon.

UserInterface/Views/ProbeDetailsSidebarPanel.css:

(.sidebar > .panel.probes > .navigation-bar .item.clear-samples):

UserInterface/Views/ProbeSetDetailsSection.js:

(WI.ProbeSetDetailsSection):

UserInterface/Views/ScopeChainDetailsSidebarPanel.css:

(.scope-chain .navigation-bar .item.clear-watch-expressions):

UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WI.ScopeChainDetailsSidebarPanel):
Resize to 15x15 and move it down a pixel.

12:37 PM Changeset in webkit [225018] by Simon Fraser

5 edits
2 adds in trunk

feTurbulence with stitchTiles is broken
https://bugs.webkit.org/show_bug.cgi?id=179862

Reviewed by Zalan Bujtas.

Source/WebCore:

The "stitchTiles" logic was broken, and not equivalent to the spec sample code,
because it didn't compute and wrap the bx1 and by1 equivalents separately from
bx0 and by0.

Annotated the code with the equivalent sample code from the spec for ease of
comparison.

Also make some functions const.

Test: svg/filters/feTurbulence-stitchTiles.html

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::noise2D const):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint const):
(WebCore::FETurbulence::fillRegion const):
(WebCore::checkNoise): Deleted.
(WebCore::FETurbulence::noise2D): Deleted.
(WebCore::FETurbulence::calculateTurbulenceValueForPoint): Deleted.
(WebCore::FETurbulence::fillRegion): Deleted.

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filter const):

LayoutTests:

Ref test that masks out an empty area of the filter and compares with a green rectangle.

svg/filters/feTurbulence-stitchTiles-expected.html: Added.
svg/filters/feTurbulence-stitchTiles.html: Added.

9:25 AM Changeset in webkit [225017] by Antti Koivisto

1 edit
2 adds in trunk/LayoutTests

Add test for a multicolumn render tree update issue
https://bugs.webkit.org/show_bug.cgi?id=179860

Reviewed by Zalan Bujtas.

fast/multicol/column-span-range-crash-expected.txt: Added.
fast/multicol/column-span-range-crash.html: Added.

7:17 AM Changeset in webkit [225016] by Jonathan Bedard

5 edits
2 adds in trunk/Tools

webkitpy: Better name-version mapping (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=179621
<rdar://problem/35589585>

Reviewed by David Kilzer.

Mapping version numbers to version names should occur in a central location.
This has a few advantages. First, it makes iterating through versions easier.
Second, it allows for apple_additions to define an additional set of name
mappings. Lastly, it will allow, in a future patch, for us to track version
instead of version name, only mapping version to version name when required.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
mapping version to name.
(PlatformInfo._determine_linux_version): Deleted.
(PlatformInfo._determine_mac_version): Deleted.
(PlatformInfo._determine_win_version): Deleted.

Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_display_name):
(TestPlatformInfo.test_total_bytes_memory):

Scripts/webkitpy/common/version.py:

(Version.contained_in): Add partial version mapping.

Scripts/webkitpy/common/version_name_map.py: Added.

(VersionNameMap): Holds a mapping of version name to version object.
(VersionNameMap.map): Don't re-create VersionNameMap every time.
(VersionNameMap.init): Initialize mapping, use platform to
define the default system platform.
(VersionNameMap._automap_to_major_version): Some operating systems, such
as iOS, have a naming scheme based on their major version and os name.
Automatically generate such mappings.
(VersionNameMap.to_name): Given a version object, platform name and
table, find the closest matching version name.
(VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
if a version string is included in the name.
(VersionNameMap.from_name): Return an os name and version given a version name.

Scripts/webkitpy/common/version_name_map_unittest.py: Added.

(VersionMapTestCase):
(VersionMapTestCase.test_default_system_platform):
(VersionMapTestCase.test_mac_version_by_name):
(VersionMapTestCase.test_ios_version_by_name):
(VersionMapTestCase.test_mac_name_by_version):
(VersionMapTestCase.test_ios_name_by_version):

Scripts/webkitpy/common/version_unittest.py:

(VersionTestCase.test_contained_in):

6:09 AM Changeset in webkit [225015] by Yusuke Suzuki

3 edits in trunk/Source/WTF

[WTF] Remove CPU(HPPA) in StackBounds by using runtime stack direction test
https://bugs.webkit.org/show_bug.cgi?id=179859

Reviewed by JF Bastien.

Currently, we know that CPU(HPPA)'s stack direction is upward! But listing
CPU architectures here is not a scalable way.

Instead, we use runtime stack direction test. By doing so, we can handle
such a strange architecture without listing the CPU to Platform.h. This paves
the way to dropping many CPUs in Platform.h by replacing them with CPU(UNKNOWN)[1].

We also fix StackBounds::isGrowingDownward().

[1]: https://bugs.webkit.org/show_bug.cgi?id=179243

wtf/StackBounds.cpp:

(WTF::StackBounds::stackDirection):
(WTF::testStackDirection2):
(WTF::testStackDirection):
(WTF::StackBounds::newThreadStackBounds):
(WTF::StackBounds::currentThreadStackBoundsInternal):

wtf/StackBounds.h:

(WTF::StackBounds::isGrowingDownward const):

3:46 AM Changeset in webkit [225014] by Antti Koivisto

3 edits
2 adds in trunk

Source/WebCore:
REGRESSION (r220646): REGRESSION (r220646): RenderTreePosition::computeNextSibling hits assertion with certain first-letter mutations
https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>

Reviewed by Zalan Bujtas.

Test: fast/css-generated-content/first-letter-update-crash.html

style/RenderTreeUpdaterFirstLetter.cpp:

(WebCore::styleForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):

Tighten these to take RenderBlock.

(WebCore::supportsFirstLetter):

Test exact conditions where first letter renderer is allowed for fast rejection.

(WebCore::RenderTreeUpdater::FirstLetter::update):

If update was called on a block that doesn't support first letter, getFirstLetter could in
some cases return an ancestor of the block and we would end up mutating a first letter renderer
that wasn't current block's descendant. This violates assumptions of the RenderTreeUpdater
and could cause cached render tree position to become invalid.

Fix by ensuring we are always updating first letter for the current block only.

LayoutTests:

REGRESSION (r220646): ASSERTION FAILED: skipAssert

nextSiblingRenderer(node) == m_nextSibling

https://bugs.webkit.org/show_bug.cgi?id=179855
<rdar://problem/35464071>

Reviewed by Zalan Bujtas.

fast/css-generated-content/first-letter-update-crash-expected.txt: Added.
fast/css-generated-content/first-letter-update-crash.html: Added.

Nov 17, 2017:

10:32 PM Changeset in webkit [225013] by Megan Gardner

7 edits in trunk/LayoutTests

Rebaseline and/or turn on more iOS selection tests that either already pass, or need minimal visual tweaking
https://bugs.webkit.org/show_bug.cgi?id=179856

Reviewed by Myles C. Maxfield.

These tests all neither to either be minimally rebaselined, or they worked, but were marked as failing.
All were checked for flakiness, and none were found to be flakey on the open source bots.

platform/ios-wk2/TestExpectations:
platform/ios/editing/selection/extend-by-word-002-expected.txt:
platform/ios/editing/selection/iframe-expected.png: Modified property svn:mime-type.
platform/ios/editing/selection/iframe-expected.txt:
platform/ios/editing/selection/inline-table-expected.png: Modified property svn:mime-type.
platform/ios/editing/selection/inline-table-expected.txt:

8:46 PM Changeset in webkit [225012] by Alan Bujtas

1 edit
2 adds in trunk/LayoutTests

Test case for r224995.
https://bugs.webkit.org/show_bug.cgi?id=179854

fast/dom/getSVGDocument-on-object-crash-expected.txt: Added.
fast/dom/getSVGDocument-on-object-crash.html: Added.

7:42 PM Changeset in webkit [225011] by Chris Dumez

16 edits
2 adds in trunk

[Service Workers] Implement "Notify Controller Change" algorithm
https://bugs.webkit.org/show_bug.cgi?id=179822

Reviewed by Youenn Fablet.

Source/WebCore:

Implement "Notify Controller Change" algorithm:

https://w3c.github.io/ServiceWorker/#notify-controller-change

Use it to support step 7 of "Activate" algorithm:

https://w3c.github.io/ServiceWorker/#activate

Test: http/tests/workers/service/controller-change.html

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleTaskToFireControllerChangeEvent):

workers/service/ServiceWorkerContainer.h:
workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::notifyClientsOfControllerChange):

workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.h:
workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::activate):

workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::notifyClientsOfControllerChange):

workers/service/server/SWServerRegistration.h:

Source/WebKit:

Scripts/webkit/messages.py:

(class_template_headers):

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::notifyClientsOfControllerChange):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
WebProcess/Storage/WebSWClientConnection.messages.in:

LayoutTests:

Add layout test coverage.

http/tests/workers/service/controller-change-expected.txt: Added.
http/tests/workers/service/controller-change.html: Added.

7:02 PM Changeset in webkit [225010] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed attempt to fix build after r225006.

platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setStorageAccessGranted):

6:32 PM Changeset in webkit [225009] by Simon Fraser

5 edits
2 adds in trunk/Source/WebCore

FETurbulence: compute all 4 channels at once
https://bugs.webkit.org/show_bug.cgi?id=179833

Reviewed by Sam Weinig.

Introduce some new helper classes for storing float color components, and use
them in calculateTurbulenceValueForPoint() and noise2D() for all the channels in one
pass. This makes FETurbulence about twice as fast.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/ColorUtilities.cpp: Added.

(WebCore::ColorComponents::ColorComponents):

platform/graphics/ColorUtilities.h: Added.

(WebCore::FloatComponents::FloatComponents):
(WebCore::FloatComponents::operator +=):
(WebCore::FloatComponents::operator + const):
(WebCore::FloatComponents::operator / const):
(WebCore::FloatComponents::operator * const):
(WebCore::FloatComponents::abs const):
(WebCore::clampedColorComponent):

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::noise2D):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):
(WebCore::FETurbulence::platformApplySoftware):

platform/graphics/filters/FETurbulence.h:

6:27 PM Changeset in webkit [225008] by Chris Dumez

47 edits in trunk/Source

Use a strongly typed identifier for SWServer::Connection
https://bugs.webkit.org/show_bug.cgi?id=179848

Reviewed by Brady Eidson.

Source/WebCore:

Use a strongly typed identifier for SWServer::Connection, for clarity.

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::ServiceWorkerClient):
(WebCore::ServiceWorkerClient::id const):
(WebCore::ServiceWorkerClient::postMessage):

workers/service/ServiceWorkerClient.h:

(WebCore::ServiceWorkerClient::create):
(WebCore::ServiceWorkerClient::identifier const):

workers/service/ServiceWorkerClientData.cpp:

(WebCore::ServiceWorkerClientData::isolatedCopy const):
(WebCore::ServiceWorkerClientData::from):

workers/service/ServiceWorkerClientData.h:

(WebCore::ServiceWorkerClientData::encode const):
(WebCore::ServiceWorkerClientData::decode):

workers/service/ServiceWorkerClientIdentifier.h:

(WebCore::ServiceWorkerClientIdentifier::toString const):
(WebCore::ServiceWorkerClientIdentifier::decode):

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::updateRegistration):
(WebCore::ServiceWorkerContainer::connectionIdentifier):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerFetchResult.h:

(WebCore::ServiceWorkerFetchResult::decode):

workers/service/ServiceWorkerJobClient.h:
workers/service/ServiceWorkerJobData.cpp:

(WebCore::ServiceWorkerJobData::ServiceWorkerJobData):

workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::connectionIdentifier const):
(WebCore::ServiceWorkerJobData::decode):

workers/service/ServiceWorkerTypes.h:
workers/service/ServiceWorkerWindowClient.cpp:

(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):

workers/service/ServiceWorkerWindowClient.h:
workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postMessageToServiceWorkerGlobalScope):

workers/service/context/SWContextManager.h:
workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):

workers/service/context/ServiceWorkerThread.h:
workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::rejectJob):
(WebCore::SWServer::resolveRegistrationJob):
(WebCore::SWServer::startScriptFetch):
(WebCore::SWServer::scriptFetchFinished):

workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::identifier const):
(WebCore::SWServer::getConnection):

workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::forEachConnection):
(WebCore::SWServerRegistration::addClientServiceWorkerRegistration):
(WebCore::SWServerRegistration::removeClientServiceWorkerRegistration):
(WebCore::SWServerRegistration::unregisterServerConnection):

workers/service/server/SWServerRegistration.h:

Source/WebKit:

Use a strongly typed identifier for SWServer::Connection, for clarity.

Scripts/webkit/messages.py:

(forward_declarations_and_headers):
(forward_declarations_and_headers.templates):
(headers_for_type):

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::didFailFetch):
(WebKit::StorageProcess::didNotHandleFetch):
(WebKit::StorageProcess::didReceiveFetchResponse):
(WebKit::StorageProcess::didReceiveFetchData):
(WebKit::StorageProcess::didReceiveFetchFormData):
(WebKit::StorageProcess::didFinishFetch):

StorageProcess/StorageProcess.h:
StorageProcess/StorageProcess.messages.in:
StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):
(WebKit::generateIDBConnectionToServerIdentifier):
(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):

StorageProcess/StorageToWebProcessConnection.h:
StorageProcess/StorageToWebProcessConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):

WebProcess/Storage/WebSWClientConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::startFetch):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerGlobalScope):

WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.messages.in:
WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:

(WebKit::WebServiceWorkerFetchTaskClient::WebServiceWorkerFetchTaskClient):

WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

WebProcess/Storage/WebToStorageProcessConnection.h:

Source/WTF:

Make ObjectIdentifier a little more flexible to support more use cases.

wtf/ObjectIdentifier.h:

(WTF::ObjectIdentifier::toUInt64 const):
(WTF::makeObjectIdentifier):

5:57 PM Changeset in webkit [225007] by commit-queue@webkit.org

7 edits in trunk/LayoutTests

Web Inspector: Fix grammar typo in tests
https://bugs.webkit.org/show_bug.cgi?id=179852

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Matt Baker.

http/tests/inspector/network/resource-response-source-memory-cache-expected.txt:
http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only-expected.txt:
http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html:
http/tests/inspector/network/resource-response-source-memory-cache.html:
http/tests/inspector/network/set-resource-caching-disabled-memory-cache-expected.txt:
http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html:

5:27 PM Changeset in webkit [225006] by wilander@apple.com

39 edits
2 moves
4 adds in trunk

Storage Access API: UI process should update network process about granted access
https://bugs.webkit.org/show_bug.cgi?id=176943
<rdar://problem/34440612>

Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction.html

http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction.html

platform/network/NetworkStorageSession.h:
platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::setStorageAccessAPIEnabled):
(WebCore::NetworkStorageSession::cookieStoragePartition const):

Now also checks if the resource has been granted storage access
under this partition and if so, does not return a partition.

(WebCore::NetworkStorageSession::setPrevalentDomainsToPartitionOrBlockCookies):

Now clears storage access when it is told to clear first.

(WebCore::NetworkStorageSession::isStorageAccessGranted const):
(WebCore::NetworkStorageSession::setStorageAccessGranted):

Source/WebKit:

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updateStorageAccessForPrevalentDomains):

Updates storage access on the session.

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
(WebKit::NetworkProcess::setStorageAccessAPIEnabled):

UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetStorageAccessAPIEnabled):

UIProcess/API/C/WKCookieManager.h:
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreSetStatisticsHasHadNonRecentUserInteraction):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _isStorageAccessAPIEnabled]):
(-[WKProcessPool _setStorageAccessAPIEnabled:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsSetHasHadNonRecentUserInteractionForHost:]):

Test infrastructure.

UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):
(WebKit::WebProcessPool::setStorageAccessAPIEnabled):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::nextRequestStorageAccessContextId):
(WebKit::NetworkProcessProxy::updateStorageAccessForPrevalentDomains):

Sends a message to the network process to update storage access.

(WebKit::NetworkProcessProxy::storageAccessRequestResult):

Receives a message from the network process that storage access
was updated.

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setStorageAccessAPIEnabled):

UIProcess/WebCookieManagerProxy.h:
UIProcess/WebProcessPool.h:
UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::logNonRecentUserInteraction):

Test infrastructure.

(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):

Now makes the API call even if the only operation is to clear first.

UIProcess/WebResourceLoadStatisticsStore.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updateStorageAccessForPrevalentDomainsHandler):

Propagates the storage access directive to the network process proxy.

(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):

UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

This adds the TestRunner function setStatisticsHasHadNonRecentUserInteraction()
which enables testing of prevalent resources with user interaction outside the
24 hour window.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setStorageAccessAPIEnabled):
(WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):

WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):
(WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):

LayoutTests:

http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-expected.txt: Added.
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction.html: Added.
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction-expected.txt: Added.
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-recent-user-interaction.html: Added.
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-expected.txt: Removed.
http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction.html: Removed.

Renamed to make the recent and non-recent user interaction explicit.

http/tests/storageAccess/resources/get-cookies.php: Added.
http/tests/storageAccess/resources/set-cookie.php: Added.
platform/mac-wk2/TestExpectations:

Added the new tests as [ Pass ] for High Sierra and up.

5:18 PM Changeset in webkit [225005] by Simon Fraser

2 edits in trunk/Source/WebCore

Inadvertently swapped m_baseFrequencyX and m_baseFrequencyY in the previous commit.

platform/graphics/filters/FETurbulence.h:

(WebCore::FETurbulence::baseFrequencyY const):
(WebCore::FETurbulence::baseFrequencyX const):

5:07 PM Changeset in webkit [225004] by Ryan Haddad

2 edits in trunk/LayoutTests

Skip imported/w3c/web-platform-tests/service-workers/service-worker/getregistration.https.html on debug bots.
https://bugs.webkit.org/show_bug.cgi?id=179846

Unreviewed test gardening.

platform/mac/TestExpectations:

5:00 PM Changeset in webkit [225003] by achristensen@apple.com

2 edits in trunk/Source/WebCore

REGRESSION(224348): [mac-wk1] LayoutTest media/video-src-remove.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=179806

Reviewed by Jer Noble.

In r224348 I used callOnMainThread to fix UIWebView which uses the web thread, but Mac doesn't
use the web thread. Something about the timing of operations in the media stack requires that
dispatch_async be used instead of performSelectorOnMainThread.

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate callFunctionOnMainThread:]):
Use callOnMainThread on iOS, dispatch_async on Mac.

4:49 PM Changeset in webkit [225002] by Ryan Haddad

2 edits in trunk/LayoutTests

Update TestExpectations for service-worker tests.

Unreviewed test gardening.

TestExpectations:

4:48 PM Changeset in webkit [225001] by Ryan Haddad

2 edits in trunk/LayoutTests

Update TestExpectations for inspector/canvas/shaderProgram-add-remove-webgl2.html.
https://bugs.webkit.org/show_bug.cgi?id=179827

Unreviewed test gardening.

platform/mac/TestExpectations:

4:48 PM Changeset in webkit [225000] by pvollan@apple.com

2 edits in trunk/Source/WebCore

[Win] Compile error in InbandTextTrackPrivateAVCF::readNativeSampleBuffer.
https://bugs.webkit.org/show_bug.cgi?id=179845

Reviewed by Jer Noble.

platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:

(WebCore::InbandTextTrackPrivateAVCF::readNativeSampleBuffer):

4:22 PM Changeset in webkit [224999] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark svg/in-html/by-reference.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=179784

Unreviewed test gardening.

platform/ios/TestExpectations:

4:19 PM Changeset in webkit [224998] by Ryan Haddad

2 edits in trunk/Tools

Disable failing API tests for rdar://problem/35344202.

Unreviewed test gardening.

TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:

3:44 PM Changeset in webkit [224997] by Chris Fleizach

5 edits
2 adds in trunk

AX: VoiceOver in Safari does not read table header for first cell in first body row
https://bugs.webkit.org/show_bug.cgi?id=179780
<rdar://problem/35590551>

Reviewed by Joanmarie Diggs.

Source/WebCore:

A table cell shouldn't be considered a row header if it's in a row of other headers.

Test: accessibility/table-header-calculation-for-header-rows.html

accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::headerObject):

LayoutTests:

accessibility/table-header-calculation-for-header-rows-expected.txt: Added.
accessibility/table-header-calculation-for-header-rows.html: Added.
accessibility/table-attributes-expected.txt: Updated.
platform/gtk/accessibility/table-attributes-expected.txt: Updated.

3:36 PM Changeset in webkit [224996] by Simon Fraser

4 edits in trunk/Source/WebCore

Don't invert a matrix for every channel of every pixel of an FETurbulence filter
https://bugs.webkit.org/show_bug.cgi?id=179829

Reviewed by Dean Jackson.

FETurbulence::fillRegion() called filter().mapAbsolutePointToLocalPoint(point) for each
of the 4 channels on a point, which is stupid.

Fix to invert the matrix once, and then map the point once for each pixel. This reduces
the time in fillRegion() function by about 30%.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion):

platform/graphics/filters/Filter.h:

(WebCore::Filter::absoluteTransform const):
(WebCore::Filter::mapAbsolutePointToLocalPoint const): Deleted.

3:34 PM Changeset in webkit [224995] by Brent Fulgham

2 edits in trunk/Source/WebCore

REGRESSION(r224390): Revert unneeded Ref use.
https://bugs.webkit.org/show_bug.cgi?id=179844
<rdar://problem/35624718>

Reviewed by Chris Dumez.

A Ref was added to a simple code path used for type checking, which introduced a nullptr
deref. The original change was not needed, so let's revert it.

html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::contentDocument const): Use 'nullptr' instead of 0.
(WebCore::HTMLFrameOwnerElement::contentWindow const): Ditto.
(WebCore::HTMLFrameOwnerElement::getSVGDocument const): Revert to original code here.

3:32 PM Changeset in webkit [224994] by Joseph Pecoraro

4 edits
2 adds in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Add HAR Export button
https://bugs.webkit.org/show_bug.cgi?id=179570
<rdar://problem/35484918>

Reviewed by Matt Baker.

Localizations/en.lproj/localizedStrings.js:

New strings.

UserInterface/Images/Export.svg: Added.
UserInterface/Images/Import.svg: Added.

Add symmetric import/export buttons.

UserInterface/Base/Main.js:

(WI.contentLoaded):
Expose the save keyboard shortcut so we can show its display name in a tooltip.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get navigationItems):
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._updateExportButton):
Include the export button and enable/disable it when appropriate.

(WI.NetworkTableContentView.prototype.closed):
Add a missing event listener removal.

3:18 PM Changeset in webkit [224993] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Disabled ImageAndText-style buttons should have gray text
https://bugs.webkit.org/show_bug.cgi?id=179843
<rdar://problem/35624337>

Reviewed by Joseph Pecoraro.

UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.disabled.image-and-text,):
(.navigation-bar .item.button.disabled > .glyph): Deleted.

3:14 PM Changeset in webkit [224992] by n_wang@apple.com

18 edits
2 adds in trunk

AX: AOM: Implement boolean type properties
https://bugs.webkit.org/show_bug.cgi?id=179496

Reviewed by Chris Fleizach.

Source/WebCore:

Accessibility Object Model
Explainer: https://wicg.github.io/aom/explainer.html
Spec: https://wicg.github.io/aom/spec/

Implemented the boolean type properties for Accessibility Object Modal.

Test: accessibility/mac/AOM-bool-properties.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::findModalNodes):
(WebCore::AXObjectCache::updateCurrentModalNode):
(WebCore::AXObjectCache::modalNode):
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::focusModalNode):
(WebCore::AXObjectCache::focusModalNodeTimerFired):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::handleModalChange):
(WebCore::isNodeAriaVisible):
(WebCore::AXObjectCache::findAriaModalNodes): Deleted.
(WebCore::AXObjectCache::updateCurrentAriaModalNode): Deleted.
(WebCore::AXObjectCache::ariaModalNode): Deleted.
(WebCore::AXObjectCache::focusAriaModalNode): Deleted.
(WebCore::AXObjectCache::focusAriaModalNodeTimerFired): Deleted.
(WebCore::AXObjectCache::handleAriaModalChange): Deleted.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::modalNode):
(WebCore::AXObjectCache::focusModalNodeTimerFired):
(WebCore::AXObjectCache::handleModalChange):
(WebCore::AXObjectCache::ariaModalNode): Deleted.
(WebCore::AXObjectCache::focusAriaModalNodeTimerFired): Deleted.
(WebCore::AXObjectCache::handleAriaModalChange): Deleted.

accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::isMultiSelectable const):

accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::readOnlyValue const):
(WebCore::AccessibilityARIAGridCell::ariaReadOnlyValue const): Deleted.

accessibility/AccessibilityARIAGridCell.h:
accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled const):

accessibility/AccessibilityNodeObject.cpp:

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsReadOnly const):
(WebCore::AccessibilityObject::readOnlyValue const):
(WebCore::AccessibilityObject::ariaIsMultiline const):
(WebCore::AccessibilityObject::isModalDescendant const):
(WebCore::AccessibilityObject::isModalNode const):
(WebCore::AccessibilityObject::ignoredFromModalPresence const):
(WebCore::AccessibilityObject::boolValueForProperty const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
(WebCore::AccessibilityObject::supportsExpanded const):
(WebCore::AccessibilityObject::isExpanded const):
(WebCore::AccessibilityObject::isAXHidden const):
(WebCore::AccessibilityObject::defaultObjectInclusion const):
(WebCore::AccessibilityObject::setIsIgnoredFromParentDataForChild):
(WebCore::AccessibilityObject::supportsARIAReadOnly const): Deleted.
(WebCore::AccessibilityObject::ariaReadOnlyValue const): Deleted.
(WebCore::AccessibilityObject::isAriaModalDescendant const): Deleted.
(WebCore::AccessibilityObject::isAriaModalNode const): Deleted.
(WebCore::AccessibilityObject::ignoredFromARIAModalPresence const): Deleted.
(WebCore::AccessibilityObject::isARIAHidden const): Deleted.

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isHidden const):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::defaultObjectInclusion const):
(WebCore::AccessibilityRenderObject::isSelected const):
(WebCore::AccessibilityRenderObject::canSetExpandedAttribute const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):
(WebCore::AccessibilityRenderObject::isBusy const):

accessibility/AccessibleNode.cpp:

(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueBoolean):
(WebCore::AccessibleNode::effectiveBoolValueForElement):
(WebCore::AccessibleNode::boolValueForProperty):
(WebCore::AccessibleNode::setBoolProperty):
(WebCore::AccessibleNode::atomic const):
(WebCore::AccessibleNode::setAtomic):
(WebCore::AccessibleNode::busy const):
(WebCore::AccessibleNode::setBusy):
(WebCore::AccessibleNode::disabled const):
(WebCore::AccessibleNode::setDisabled):
(WebCore::AccessibleNode::expanded const):
(WebCore::AccessibleNode::setExpanded):
(WebCore::AccessibleNode::hidden const):
(WebCore::AccessibleNode::setHidden):
(WebCore::AccessibleNode::modal const):
(WebCore::AccessibleNode::setModal):
(WebCore::AccessibleNode::multiline const):
(WebCore::AccessibleNode::setMultiline):
(WebCore::AccessibleNode::multiselectable const):
(WebCore::AccessibleNode::setMultiselectable):
(WebCore::AccessibleNode::readOnly const):
(WebCore::AccessibleNode::setReadOnly):
(WebCore::AccessibleNode::required const):
(WebCore::AccessibleNode::setRequired):
(WebCore::AccessibleNode::selected const):
(WebCore::AccessibleNode::setSelected):

accessibility/AccessibleNode.h:
accessibility/AccessibleNode.idl:
accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):
(setAtkStateSetFromCoreObject):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

LayoutTests:

accessibility/mac/AOM-bool-properties-expected.txt: Added.
accessibility/mac/AOM-bool-properties.html: Added.

3:10 PM Changeset in webkit [224991] by jfbastien@apple.com

2 edits in trunk/Source/JavaScriptCore

NFC update ClassInfo to C++14
https://bugs.webkit.org/show_bug.cgi?id=179783

Reviewed by Mark Lam.

Forked from #179734, use using instead of typedef. It's easier
to read.

runtime/ClassInfo.h:

3:00 PM Changeset in webkit [224990] by Simon Fraser

3 edits
2 adds in trunk/Source/WTF

Add a TimingScope class for microbenchmarking sections of code
https://bugs.webkit.org/show_bug.cgi?id=179825

Reviewed by Zalan Bujtas.

Add a class, similar to B3TimingScope, which makes it easy to microbenchmark
sections of code. Use looks like:

TimingScope scope("some label", 100);

where this will print mean scope duration every 100 calls. Sample output:

FETurbulence::platformApplySoftware: 100 calls, mean duration: 3.073181ms
FETurbulence::platformApplySoftware: 200 calls, mean duration: 3.074612ms
FETurbulence::platformApplySoftware: 300 calls, mean duration: 3.065722ms

Because TimingScope needs to store state beween invocations, and there may be
multiple TimingScopes in use at the same time, data is stored in a global
hash map with atomic access.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/TimingScope.cpp: Added.

(WTF::TimingScope::scopeDidEnd):

wtf/TimingScope.h: Added.

(WTF::TimingScope::TimingScope):
(WTF::TimingScope::~TimingScope):

2:53 PM Changeset in webkit [224989] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Update Ignore Caches button
https://bugs.webkit.org/show_bug.cgi?id=179841

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Matt Baker.

UserInterface/Images/IgnoreCaches.svg:

This changes from an arrow over a cache to a slash through a cache.

2:12 PM Changeset in webkit [224988] by Megan Gardner

2 edits in trunk/LayoutTests

Turn on selection layout tests that are already working on iOS
https://bugs.webkit.org/show_bug.cgi?id=179842

Reviewed by Tim Horton.

I have checked these test manually and on the flakiness dashboard and they are all
working on iOS. No reason to not run them on iOS now.

platform/ios-wk2/TestExpectations:

2:12 PM Changeset in webkit [224987] by jmarcell@apple.com

2 edits in tags/Safari-605.1.14.1/Source/WebCore

Cherry-pick r224960. rdar://problem/35485349

2:09 PM Changeset in webkit [224986] by jdiggs@igalia.com

5 edits
2 adds in trunk

AX: [ATK] Fix WKTR's methods for testing row header and column header presence and count
https://bugs.webkit.org/show_bug.cgi?id=179837

Reviewed by Chris Fleizach.

Tools:

Add support to rowHeaders() for tables. Return an empty array in rowHeaders()
and columnHeaders() upon failure. Rename getRowHeaders() and getColumnHeaders()
to getTableRowHeaders() and getTableColumnHeaders() respectively.

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::rowHeaders const):
(WTR::AccessibilityUIElement::columnHeaders const):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):

LayoutTests:

accessibility/gtk/table-headers-count-expected.txt: Added.
accessibility/gtk/table-headers-count.html: Added.
platform/gtk/TestExpectations: Remove a couple of "crash" failures.
platform/gtk/accessibility/table-sections-expected.txt: Remove null objects.

1:57 PM Changeset in webkit [224985] by jfbastien@apple.com

3 edits
1 add in trunk

WebAssembly JS API: throw when a promise can't be created
https://bugs.webkit.org/show_bug.cgi?id=179826
<rdar://problem/35455813>

Reviewed by Mark Lam.

JSTests:

Test WebAssembly.{compile,instantiate} where promise creation
fails because of a stack overflow.

wasm/js-api/promise-stack-overflow.js: Added.

(const.runNearStackLimit.f.const.t):
(async.testCompile):
(async.testInstantiate):

Source/JavaScriptCore:

Failure *in* a promise causes rejection, but failure to create a
promise (because of stack overflow) isn't really spec'd (as all
stack things JS). This applies to WebAssembly.compile and
WebAssembly.instantiate.

Dan's current proposal says:

https://littledan.github.io/spec/document/js-api/index.html#stack-overflow

Whenever a stack overflow occurs in WebAssembly code, the same
class of exception is thrown as for a stack overflow in
JavaScript. The particular exception here is
implementation-defined in both cases.

Note: ECMAScript doesn’t specify any sort of behavior on stack
overflow; implementations have been observed to throw RangeError,
InternalError or Error. Any is valid here.

This is for general stack overflow within WebAssembly, not
specifically for promise creation within JavaScript, but it seems
like a stack overflow in promise creation should follow the same
rule instead of, say, swallowing the overflow and returning
undefined.

wasm/js/WebAssemblyPrototype.cpp:

(JSC::webAssemblyCompileFunc):
(JSC::webAssemblyInstantiateFunc):

1:38 PM Changeset in webkit [224984] by achristensen@apple.com

6 edits in trunk/Source/WebCore

Clean up URL.h
https://bugs.webkit.org/show_bug.cgi?id=179710

Reviewed by Brady Eidson.

No change in behavior.

Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::urlString const):

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::url const):

platform/URL.cpp:

(WebCore::URL::serialize const): Deleted.

platform/URL.h:
platform/mac/URLMac.mm:

(WebCore::URL::createCFURL const):

1:35 PM Changeset in webkit [224983] by achristensen@apple.com

6 edits in trunk/Source/WTF

Clean up after r224952
https://bugs.webkit.org/show_bug.cgi?id=179809

Reviewed by Brady Eidson.

wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):

wtf/MainThread.h:
wtf/generic/MainThreadGeneric.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::currentRunLoopInCommonMode): Deleted.

wtf/mac/MainThreadMac.mm:

(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::currentRunLoopInCommonMode): Deleted.

wtf/win/MainThreadWin.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):
(WTF::currentRunLoopInCommonMode): Deleted.

1:33 PM Changeset in webkit [224982] by achristensen@apple.com

3 edits in trunk

Use RunLoop and Mode from NetworkingContext if they are given
https://bugs.webkit.org/show_bug.cgi?id=179800
<rdar://problem/35519421>

Reviewed by Brady Eidson.

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(callOnMainThreadOrSchedule):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveAuthenticationChallenge:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveData:lengthReceived:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didSendBodyData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didFailWithError:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

1:29 PM Changeset in webkit [224981] by Matt Baker

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove WI.instanceForClass
https://bugs.webkit.org/show_bug.cgi?id=179746

Reviewed by Timothy Hatcher.

The implementations of DetailsSidebarPanel subclasses assume that panels
are closed and released when no longer needed. Keeping them alive with
instanceForClass isn't the right choice, since sidebar panels remove their
event listeners when closed.

UserInterface/Base/Main.js:

(WI.instanceForClass): Deleted.

UserInterface/Views/DebuggerTabContentView.js:

(WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):

UserInterface/Views/TabContentView.js:

(WI.TabContentView.prototype.get detailsSidebarPanels):

1:11 PM Changeset in webkit [224980] by jmarcell@apple.com

7 edits in branches/safari-604.4.7.10-branch/Source

Versioning.

12:43 PM Changeset in webkit [224979] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

LayoutTest http/tests/inspector/network/har/har-page.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179781

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Alexey Proskuryakov.

http/tests/inspector/network/har/har-page-expected.txt:
http/tests/inspector/network/har/har-page.html:

Filter out the protocol value since it might not be available if the resource was cached.

12:38 PM Changeset in webkit [224978] by Matt Baker

5 edits
1 copy in trunk/Source/WebInspectorUI

Web Inspector: ButtonNavigationItem should support image and text button style
https://bugs.webkit.org/show_bug.cgi?id=179625
<rdar://problem/35512238>

Reviewed by Joseph Pecoraro.

UserInterface/Main.html:

UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button):
(.navigation-bar .item.button.image-only):
(.navigation-bar .item.button.image-and-text):
(.navigation-bar .item.button.image-and-text > span):
(.navigation-bar .item.button.text-only):
(.navigation-bar .item.button.text-only.checkbox): Deleted.
(.navigation-bar .item.button.text-only.checkbox label): Deleted.
Checkbox styles have been moved to a separate CSS file.

UserInterface/Views/ButtonNavigationItem.js:

Add backing data members for the image and label, allowing the DOM
representation of the button to change as needed.

(WI.ButtonNavigationItem):
Remove duplicate role logic. The base class sets the role.

(WI.ButtonNavigationItem.prototype.set label):
(WI.ButtonNavigationItem.prototype.set image):
(WI.ButtonNavigationItem.prototype.get buttonStyle):
(WI.ButtonNavigationItem.prototype.set buttonStyle):
(WI.ButtonNavigationItem.prototype.get additionalClassNames):
(WI.ButtonNavigationItem.prototype._mouseClicked):
(WI.ButtonNavigationItem.prototype._update):
(WI.ButtonNavigationItem.prototype.updateButtonText): Deleted.

UserInterface/Views/CheckboxNavigationItem.css: Added.

(.navigation-bar .item.checkbox):
(.navigation-bar .item.checkbox label):

UserInterface/Views/CheckboxNavigationItem.js:

Change base class to NavigationItem, since this item lacks an image
and makes use of an actual label element instead of a span for its text.

(WI.CheckboxNavigationItem):
(WI.CheckboxNavigationItem.prototype._checkboxChanged):
(WI.CheckboxNavigationItem.prototype.updateButtonText): Deleted.

11:39 AM Changeset in webkit [224977] by Simon Fraser

3 edits in trunk/Source/WebCore

FETurbulence const and inline cleanup
https://bugs.webkit.org/show_bug.cgi?id=179832

Reviewed by Dean Jackson.

Pass the PaintingData& around as const, and remove some 'inline', letting the compiler
decide. Also declare a few variables closer to first use.

Speeds up FETurbulence by about 1%.

platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::initPaint):
(WebCore::FETurbulence::noise2D):
(WebCore::FETurbulence::calculateTurbulenceValueForPoint):
(WebCore::FETurbulence::fillRegion):

platform/graphics/filters/FETurbulence.h:

11:34 AM Changeset in webkit [224976] by Antti Koivisto

7 edits in trunk/Source/WebCore

Move destroyLeftoverChildren call to RenderObject::destroy
https://bugs.webkit.org/show_bug.cgi?id=179819

Reviewed by Zalan Bujtas.

This is currently called inconsistenly from various willBeDestroyed implementations.
We should always call it before invoking willBeDestroyed.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willBeDestroyed):

rendering/RenderElement.cpp:

(WebCore::RenderElement::willBeDestroyed):

rendering/RenderElement.h:

(WebCore::RenderElement::setLastChild):

rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):

Add some release asserts verifying layer has been detached before destruction.
This would reveal cases where destroyLeftoverChildren was called too late.

rendering/RenderObject.cpp:

(WebCore::RenderObject::destroy):

Call destroyLeftoverChildren.

11:29 AM Changeset in webkit [224975] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove FIXMEs for GTK+ missing icons
https://bugs.webkit.org/show_bug.cgi?id=155282
<rdar://problem/25076615>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Michael Catanzaro.

UserInterface/Views/PathComponentIcons.css:

(.source-icon .icon):
(body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon,): Deleted.

UserInterface/Views/ResourceIcons.css:

(.large .resource-icon.resource-type-websocket .icon):
(body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-ping .icon,): Deleted.
(body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-ping .icon,): Deleted.
All ports now share the same images.

11:16 AM Changeset in webkit [224974] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=179773

Unreviewed test gardening.

platform/ios/TestExpectations:

10:40 AM Changeset in webkit [224973] by commit-queue@webkit.org

7 edits
2 adds in trunk

SVG scrolling anchor should be reset if the fragmentIdentifier does not exist or is not provided
https://bugs.webkit.org/show_bug.cgi?id=176577

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-11-17
Reviewed by Simon Fraser.

Source/WebCore:

Because the SVGImage can be cached only once but used multiple times with
different fragmentIdentifiers, SVGImage has to call FrameView::scrollToFragment()
before the image is displayed. If the fragmentIdentifier is not provided
in the URL or it does not exist in the SVGImage, FrameView::scrollToFragment()
has to reset the scrolling anchor of the SVG as if it was not displayed before.
We do not want the previous scrolling anchor to be used when the FrameView
of SVGImage can't scroll to the current fragmentIdentifier for any reason.

Test: http/tests/svg/svg-fragment-url-special-cases.html

page/FrameView.cpp:

(WebCore::FrameView::scrollToFragment):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::resetScrollAnchor):

page/FrameView.h:
platform/URL.cpp:

(WebCore::URL::fragmentIdentifier const): Call hasFragmentIdentifier()
instead of repeating the same condition.
(WebCore::decodeURLEscapeSequences):

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::findViewAnchor const):
(WebCore::SVGSVGElement::findRootAnchor const):
(WebCore::SVGSVGElement::scrollToAnchor): We want to know whether the SVG
root element could scroll to the fragmentIdentifier or not. If it could not,
FrameView::scrollToAnchor() can still try one last time to do the scrolling
only if anchorElement is not nullptr.
(WebCore::SVGSVGElement::resetScrollAnchor): Reset the FrameView scrolling
state to its initial value.

svg/SVGSVGElement.h:

LayoutTests:

http/tests/svg/svg-fragment-url-special-cases-expected.html: Added.
http/tests/svg/svg-fragment-url-special-cases.html: Added.

10:38 AM Changeset in webkit [224972] by jmarcell@apple.com

1 copy in tags/Safari-604.4.7.10.4

Tag Safari-604.4.7.10.4.

10:33 AM Changeset in webkit [224971] by commit-queue@webkit.org

5 edits in trunk

ServiceWorker intercepted FetchRequest should have their referrer set appropriately.
https://bugs.webkit.org/show_bug.cgi?id=179803

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-17
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/service-workers/service-worker/referer.https-expected.txt:
web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:

Source/WebCore:

Covered by updated tests.

workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

10:27 AM Changeset in webkit [224970] by jdiggs@igalia.com

2 edits in trunk/Source/WebCore

AX: [GTK] Regression: accessibility/gtk/aria-keyshortcuts.html fails after r224953
https://bugs.webkit.org/show_bug.cgi?id=179824

Reviewed by Chris Fleizach.

The failure was due to AXPropertyName::KeyShortcuts not being included in
the group of properties whose value is a string. As a result, the new method
to get string values, AccessibleNode::effectiveStringValueForElement(), was
returning an empty String. This was not caught by the shared set of tests
because at the present time, only WebKitGtk supports aria-keyshortcuts.

No new tests needed. The regression was caught by an existing test.

accessibility/AccessibleNode.cpp:

(WebCore::isPropertyValueString):

10:02 AM Changeset in webkit [224969] by Ryan Haddad

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r224952.

This change introduced LayoutTest failures on WK1.

Reverted changeset:

"Use RunLoop and Mode from NetworkingContext if they are
given"
https://bugs.webkit.org/show_bug.cgi?id=179800
https://trac.webkit.org/changeset/224952

9:42 AM Changeset in webkit [224968] by graouts@webkit.org

4 edits
2 adds in trunk

[Web Animations] Force a stacking context during animations that animate properties that will force a stacking context
https://bugs.webkit.org/show_bug.cgi?id=179811

Reviewed by Dean Jackson.

Source/WebCore:

The Web Animations specification mandates in section 4.7 (w3c.github.io/web-animations/#side-effects-section) that
"for every property targeted by at least one animation effect that is current or in effect, the user agent must act
as if the will-change property ([css-will-change-1]) on the target element includes the property."

After parsing new keyframes, we check if any of the CSS properties that get animated would end up forcing a stacking
context, and if so, enforce a stacking context during the entire active lifetime of the animation.

Test: webanimations/animation-opacity-animation-crash.html

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::processKeyframes):
(WebCore::KeyframeEffect::computeStackingContextImpact):
(WebCore::KeyframeEffect::applyAtLocalTime):

animation/KeyframeEffect.h:

LayoutTests:

Adding a new test that would crash otherwise because we wouldn't adequately force a stacking
context as the animation would begin.

webanimations/animation-opacity-animation-crash-expected.txt: Added.
webanimations/animation-opacity-animation-crash.html: Added.

8:25 AM Changeset in webkit [224967] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Update feature status for Visual Viewport API to "In Development"
https://bugs.webkit.org/show_bug.cgi?id=179818

Patch by Ali Juma <ajuma@chromium.org> on 2017-11-17
Reviewed by Frédéric Wang.

Work on this feature has started, tracked by bug 170982.

No new tests since there's no change in behavior.

features.json:

Nov 16, 2017:

10:43 PM Changeset in webkit [224966] by jmarcell@apple.com

2 edits in tags/Safari-605.1.14.1/Source/WebCore

Cherry-pick r224952. rdar://problem/35581599

10:41 PM Changeset in webkit [224965] by jmarcell@apple.com

7 edits in tags/Safari-605.1.14.1/Source

Versioning.

10:39 PM Changeset in webkit [224964] by jmarcell@apple.com

1 copy in tags/Safari-605.1.14.1

New tag.

10:33 PM Changeset in webkit [224963] by Yusuke Suzuki

2 edits in trunk/JSTests

Unreviewed, mark regress-178385.js as memory exhausting

stress/regress-178385.js:

10:17 PM Changeset in webkit [224962] by commit-queue@webkit.org

3 edits
56 copies
32 adds
1 delete in trunk/LayoutTests

Unreviewed, rolling out r224921.
https://bugs.webkit.org/show_bug.cgi?id=179813

We shouldn't be doing this (Requested by ap on #webkit).

Reverted changeset:

"Remove the outdated and unmaintained copies of the tests in
wpt/2dcontext/the-canvas-state/."
https://bugs.webkit.org/show_bug.cgi?id=179769
https://trac.webkit.org/changeset/224921

10:14 PM Changeset in webkit [224961] by commit-queue@webkit.org

5 edits
1 copy
3 moves
1 add in trunk/Source

[WinCairo] Add network (curl) files for wincairo webkit
https://bugs.webkit.org/show_bug.cgi?id=179474

Patch by Yousuke Kimoto <yousuke.kimoto@sony.com> on 2017-11-16
Reviewed by Alex Christensen.

Source/WebCore:

No new behvaior, no new tests.

PlatformWinCairo.cmake:
platform/Curl.cmake:
platform/network/curl/CookieStorageCurl.cpp: Added.

(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

platform/network/curl/NetworkStorageSessionCurl.cpp: Added.

(WebCore::NetworkStorageSession::~NetworkStorageSession):
(WebCore::NetworkStorageSession::context const):
(WebCore::defaultSession):
(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::setCookies):
(WebCore::NetworkStorageSession::setCookie):
(WebCore::NetworkStorageSession::deleteCookie):
(WebCore::NetworkStorageSession::getAllCookies):
(WebCore::NetworkStorageSession::getCookies):
(WebCore::NetworkStorageSession::flushCookieStore):

Source/WebKit:

Shared/curl/WebCoreArgumentCodersCurl.cpp:

(IPC::ArgumentCoder<CertificateInfo>::decode): Fidex return value since currently no operation is needed for wincairo webkit.
(IPC::ArgumentCoder<ResourceError>::decodePlatformData): Fidex return value since currently no operation is needed for wincairo webkit.

WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.cpp: Renamed from Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.cpp.

(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):

WebProcess/WebCoreSupport/curl/WebFrameNetworkingContext.h: Renamed from Source/WebKit/WebProcess/WebCoreSupport/win/WebFrameNetworkingContext.h.

9:49 PM Changeset in webkit [224960] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Fix occasional crash when adding and removing videos
https://bugs.webkit.org/show_bug.cgi?id=179792

Reviewed by Geoffrey Garen.

In taskCompleted we null out session, and in resume we call _restart on the main thread.
If _restart is called after taskCompleted, we want to do nothing.
Right now we are calling a method on self.session.loader which is a PlatformMediaResourceLoader&
but in ObjC if session is null it will call PlatformMediaResourceLoader::requestResource with a
null this pointer, which crashes. Let's not crash.

platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask _restart]):
Early return if we don't have a session.

7:36 PM Changeset in webkit [224959] by don.olmstead@sony.com

8 edits in trunk

[WinCairo] Update WinCairoRequirements
https://bugs.webkit.org/show_bug.cgi?id=179790

Reviewed by Alex Christensen.

Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

PlatformWin.cmake:

Source/WebKit:

PlatformWin.cmake:

Tools:

TestWebKitAPI/PlatformWin.cmake:

7:28 PM Changeset in webkit [224958] by Chris Dumez

6 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline skipped / flaky service worker tests

web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https-expected.txt:
web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:

7:25 PM Changeset in webkit [224957] by graouts@webkit.org

7 edits
1 copy in trunk/Source/WebCore

[Web Animations] Allow KeyframeEffect to support CSS property animation blending
https://bugs.webkit.org/show_bug.cgi?id=179810

Reviewed by Tim Horton.

We used to pass nullptr instead of a valid AnimationBase when calling CSSPropertyAnimation::blendProperties()
in KeyframeEffect::applyAtLocalTime() when blending CSS styles during a keyframe animation. Without this
AnimationBase, some blending functions would crash as certain supporting calls couldn't be made.

We now add a new CSSPropertyBlendingClient virtual interface that both KeyframeEffect and AnimationBase
implement and that CSSPropertyAnimation::blendProperties() take as a parameter in order to support
blending code.

WebCore.xcodeproj/project.pbxproj:
animation/CSSPropertyBlendingClient.h: Added.
animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::applyAtLocalTime):
(WebCore::KeyframeEffect::renderer const):
(WebCore::KeyframeEffect::currentStyle const):

animation/KeyframeEffect.h:
page/animation/AnimationBase.h:

(WebCore::AnimationBase::isAccelerated const):
(WebCore::AnimationBase::transformFunctionListsMatch const):
(WebCore::AnimationBase::filterFunctionListsMatch const):
(WebCore::AnimationBase::backdropFilterFunctionListsMatch const):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):
(WebCore::blendFilterOperations):
(WebCore::blendFilter):
(WebCore::crossfadeBlend):
(WebCore::PropertyWrapperAcceleratedBackdropFilter::blend const):
(WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists const):
(WebCore::PropertyWrapperShadow::blendMismatchedShadowLists const):
(WebCore::CSSPropertyAnimation::blendProperties):

page/animation/CSSPropertyAnimation.h:

6:36 PM Changeset in webkit [224956] by commit-queue@webkit.org

29 edits
3 adds in trunk

Service Worker should get the body of intercepted requests
https://bugs.webkit.org/show_bug.cgi?id=179776

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

imported/w3c/web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
imported/w3c/web-platform-tests/fetch/api/request/request-init-002-expected.txt:
imported/w3c/web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:
imported/w3c/web-platform-tests/fetch/api/response/response-consume-expected.txt:
imported/w3c/web-platform-tests/fetch/api/response/response-init-002-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-request-xhr.https-expected.txt:

Source/WebCore:

Test: http/tests/workers/service/service-worker-request-with-body.https.html

Make use of FetchBodyConsumer to store raw data for FetchRequest.
This is used when setting FetchRequest body from a FormData.
If FormData is only bytes (no blob, no file), FetchBodyConsumer will store that data.
This allows Service Worker to get access to simple request bodies.

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::fromFormData):
(WebCore::FetchBody::consume):
(WebCore::FetchBody::bodyAsFormData const): Making sure body is set appropriately when used to make fetch load.

Modules/fetch/FetchBody.h: Making some methods private.
Modules/fetch/FetchBodyConsumer.h: Adding accessors.

(WebCore::FetchBodyConsumer::hasData const):
(WebCore::FetchBodyConsumer::data const):

Modules/fetch/FetchRequest.h:

(WebCore::FetchRequest::FetchRequest):

platform/network/FormData.cpp:

(WebCore::FormData::asSharedBuffer const):

platform/network/FormData.h:
workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent): Setting FetchRequest body based on given FormData.

Source/WebKit:

Pass a FormDataReference when starting fetch IPC.
Convert this FormDataReference in a FormData and using it to set the FetchRequest body properly in Service Worker process.
Forbid fetch interception when URL is not HTTP/HTTPS.

Platform/IPC/FormDataReference.h:

(IPC::FormDataReference::FormDataReference):
(IPC::FormDataReference::takeData):
(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::startFetch):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::startFetch):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::startFetch):

WebProcess/Storage/WebSWContextManagerConnection.h:
WebProcess/Storage/WebSWContextManagerConnection.messages.in:
WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::handleFetch):

LayoutTests:

http/tests/workers/service/resources/service-worker-fetch.js:
http/tests/workers/service/service-worker-fetch.https-expected.txt:
http/tests/workers/service/resources/service-worker-request-with-body-worker.js: Added.
http/tests/workers/service/service-worker-request-with-body.https-expected.txt: Added.
http/tests/workers/service/service-worker-request-with-body.https.html: Added.

6:32 PM Changeset in webkit [224955] by Chris Dumez

5 edits in trunk/Source/WebCore

Make sure service workers get terminated between tests
https://bugs.webkit.org/show_bug.cgi?id=179774

Reviewed by Alex Christensen.

Make sure service workers get terminated between tests. Previously, we
would merely clear all registrations and job queues but it would not
cause the registrations' service workers to get terminated.

workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::updateExtendedEventsSet):

workers/service/server/SWServer.cpp:

(WebCore::SWServer::clearAll):

workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::scriptFetchFinished):
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::tryClearRegistration):
(WebCore::SWServerJobQueue::clearRegistration):

workers/service/server/SWServerJobQueue.h:

6:29 PM Changeset in webkit [224954] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

FetchLoader should unregister its blob URL
https://bugs.webkit.org/show_bug.cgi?id=179768

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16
Reviewed by Alex Christensen.

No observable change.

Keep the blob URL used for reading and unregister it in destructor.

Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::~FetchLoader):
(WebCore::FetchLoader::start):

Modules/fetch/FetchLoader.h:

6:24 PM Changeset in webkit [224953] by n_wang@apple.com

17 edits
2 adds in trunk

AX: AOM: Implement string type properties
https://bugs.webkit.org/show_bug.cgi?id=179495

Reviewed by Chris Fleizach.

Source/WebCore:

Implemented the rest of the string type properties for Accessibility
Object Model.

Test: accessibility/mac/AOM-string-properties.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleLiveRegionCreated):

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::isPressed const):
(WebCore::AccessibilityNodeObject::isChecked const):
(WebCore::AccessibilityNodeObject::valueDescription const):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::AccessibilityObject::supportsAutoComplete const):
(WebCore::AccessibilityObject::autoCompleteValue const):
(WebCore::AccessibilityObject::invalidStatus const):
(WebCore::AccessibilityObject::supportsCurrent const):
(WebCore::AccessibilityObject::currentState const):
(WebCore::AccessibilityObject::currentValue const):
(WebCore::AccessibilityObject::roleDescription const):
(WebCore::AccessibilityObject::keyShortcutsValue const):
(WebCore::AccessibilityObject::placeholderValue const):
(WebCore::AccessibilityObject::isInsideLiveRegion const):
(WebCore::AccessibilityObject::liveRegionAncestor const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
(WebCore::AccessibilityObject::supportsLiveRegion const):
(WebCore::AccessibilityObject::sortDirection const):
(WebCore::AccessibilityObject::supportsHasPopup const):
(WebCore::AccessibilityObject::hasPopupValue const):
(WebCore::AccessibilityObject::supportsPressed const):
(WebCore::AccessibilityObject::checkboxOrRadioValue const):
(WebCore::AccessibilityObject::pressedIsPresent const):
(WebCore::AccessibilityObject::buttonRoleType const):
(WebCore::AccessibilityObject::supportsARIAAutoComplete const): Deleted.
(WebCore::AccessibilityObject::ariaAutoCompleteValue const): Deleted.
(WebCore::AccessibilityObject::supportsARIACurrent const): Deleted.
(WebCore::AccessibilityObject::ariaCurrentState const): Deleted.
(WebCore::AccessibilityObject::ariaCurrentValue const): Deleted.
(WebCore::AccessibilityObject::ariaKeyShortcutsValue const): Deleted.
(WebCore::AccessibilityObject::isInsideARIALiveRegion const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionAncestor const): Deleted.
(WebCore::AccessibilityObject::supportsARIALiveRegion const): Deleted.
(WebCore::AccessibilityObject::supportsARIAHasPopup const): Deleted.
(WebCore::AccessibilityObject::ariaPopupValue const): Deleted.
(WebCore::AccessibilityObject::supportsARIAPressed const): Deleted.
(WebCore::AccessibilityObject::ariaPressedIsPresent const): Deleted.

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::hasPopup const):
(WebCore::AccessibilityObject::liveRegionStatus const):
(WebCore::AccessibilityObject::liveRegionRelevant const):
(WebCore::AccessibilityObject::liveRegionAtomic const):
(WebCore::AccessibilityObject::ariaHasPopup const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionStatus const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionRelevant const): Deleted.
(WebCore::AccessibilityObject::ariaLiveRegionAtomic const): Deleted.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::hasPopup const):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::orientation const):
(WebCore::AccessibilityRenderObject::textChanged):
(WebCore::AccessibilityRenderObject::liveRegionStatus const):
(WebCore::AccessibilityRenderObject::liveRegionRelevant const):
(WebCore::AccessibilityRenderObject::liveRegionAtomic const):
(WebCore::AccessibilityRenderObject::ariaHasPopup const): Deleted.
(WebCore::AccessibilityRenderObject::ariaLiveRegionStatus const): Deleted.
(WebCore::AccessibilityRenderObject::ariaLiveRegionRelevant const): Deleted.
(WebCore::AccessibilityRenderObject::ariaLiveRegionAtomic const): Deleted.

accessibility/AccessibilityRenderObject.h:
accessibility/AccessibleNode.cpp:

(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueString):
(WebCore::AccessibleNode::notifyAttributeChanged):
(WebCore::AccessibleNode::autocomplete const):
(WebCore::AccessibleNode::setAutocomplete):
(WebCore::AccessibleNode::checked const):
(WebCore::AccessibleNode::setChecked):
(WebCore::AccessibleNode::current const):
(WebCore::AccessibleNode::setCurrent):
(WebCore::AccessibleNode::hasPopUp const):
(WebCore::AccessibleNode::setHasPopUp):
(WebCore::AccessibleNode::invalid const):
(WebCore::AccessibleNode::setInvalid):
(WebCore::AccessibleNode::keyShortcuts const):
(WebCore::AccessibleNode::setKeyShortcuts):
(WebCore::AccessibleNode::live const):
(WebCore::AccessibleNode::setLive):
(WebCore::AccessibleNode::setLabel):
(WebCore::AccessibleNode::orientation const):
(WebCore::AccessibleNode::setOrientation):
(WebCore::AccessibleNode::placeholder const):
(WebCore::AccessibleNode::setPlaceholder):
(WebCore::AccessibleNode::pressed const):
(WebCore::AccessibleNode::setPressed):
(WebCore::AccessibleNode::relevant const):
(WebCore::AccessibleNode::setRelevant):
(WebCore::AccessibleNode::role const):
(WebCore::AccessibleNode::setRole):
(WebCore::AccessibleNode::roleDescription const):
(WebCore::AccessibleNode::setRoleDescription):
(WebCore::AccessibleNode::sort const):
(WebCore::AccessibleNode::setSort):
(WebCore::AccessibleNode::valueText const):
(WebCore::AccessibleNode::setValueText):

accessibility/AccessibleNode.h:

(WebCore::AXPropertyHashTraits::constructDeletedValue):
(WebCore::AXPropertyHashTraits::isDeletedValue):

accessibility/AccessibleNode.idl:
accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):
(atkRole):
(setAtkStateSetFromCoreObject):

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityHasPopup]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIARelevantStatus]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAPressed]):
(-[WebAccessibilityObjectWrapper accessibilityARIACurrentStatus]):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

LayoutTests:

accessibility/accessibility-object-model.html:
accessibility/mac/AOM-string-properties-expected.txt: Added.
accessibility/mac/AOM-string-properties.html: Added.

5:34 PM Changeset in webkit [224952] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Use RunLoop and Mode from NetworkingContext if they are given
https://bugs.webkit.org/show_bug.cgi?id=179800
<rdar://problem/35519421>

Reviewed by Brady Eidson.

We used to call [NSURLConnection scheduleInRunLoop:forMode:] before r224267.
That change broke WebKitLegacy clients using custom run loop modes, which I partially fixed in r224687 and r224896,
but that hangs if there are any non-scheduled calls to callOnMainThread and it ignores the CFRunLoop part of the SchedulePair.
This is a more elegant solution that fixes all known bugs with custom run loop modes and makes the
behavior as close to the pre-r224267 behavior as possible by using all parameters in a good way.

I verified the bug in the radar is fixed, the API test WebKitLegacy.ScheduleInRunLoop still passes,
and UIWebView still works on iOS.

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

5:30 PM Changeset in webkit [224951] by jmarcell@apple.com

2 edits in tags/Safari-605.1.14/Source/WTF

Revert r224907. rdar://problem/35519421

5:17 PM Changeset in webkit [224950] by dbates@webkit.org

17 edits in trunk

Add feature define for alternative presentation button element
https://bugs.webkit.org/show_bug.cgi?id=179692
Part of <rdar://problem/34917108>

Reviewed by Andy Estes.

Only enabled on Cocoa platforms by default.

Source/cmake/OptionsMac.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

5:15 PM Changeset in webkit [224949] by jmarcell@apple.com

7 edits in trunk/Source

Versioning.

5:04 PM Changeset in webkit [224948] by Ryan Haddad

2 edits in trunk/JSTests

Mark test262/test/language/statements/class/definition/fn-name-static-precedence.js as passing after r224927.

Unreviewed test gardening.

test262.yaml:

4:59 PM Changeset in webkit [224947] by Chris Dumez

21 edits in trunk

[Service Worker] Implement "Try Clear Registration" algorithm
https://bugs.webkit.org/show_bug.cgi?id=179791

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline several WPT tests that are now passing or failing later.

web-platform-tests/service-workers/service-worker/clients-matchall-client-types.https-expected.txt:
web-platform-tests/service-workers/service-worker/getregistrations.https-expected.txt:
web-platform-tests/service-workers/service-worker/ready.https-expected.txt:
web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:
web-platform-tests/service-workers/service-worker/unregister-then-register.https-expected.txt:

Source/WebCore:

Implement "Try Clear Registration" algorithm:

https://w3c.github.io/ServiceWorker/#try-clear-registration-algorithm

In particular, a SWServerRegistration now knows if it is "in use" by a given
service worker client (i.e. The registration's active service worker is
controlling the service worker client). See:

https://w3c.github.io/ServiceWorker/#selection (last paragraph)

No new tests, rebaselined existing tests.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::setActiveServiceWorker):

workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::serviceWorkerStartedControllingClient):
(WebCore::SWServer::Connection::serviceWorkerStoppedControllingClient):
(WebCore::SWServer::serviceWorkerStartedControllingClient):
(WebCore::SWServer::serviceWorkerStoppedControllingClient):

workers/service/server/SWServer.h:
workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::tryClearRegistration):

workers/service/server/SWServerRegistration.h:

(WebCore::SWServerRegistration::hasClientsUsingRegistration const):
(WebCore::SWServerRegistration::addClientUsingRegistration):
(WebCore::SWServerRegistration::removeClientUsingRegistration):

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::serviceWorkerStartedControllingClient):
(WebKit::WebSWClientConnection::serviceWorkerStoppedControllingClient):

WebProcess/Storage/WebSWClientConnection.h:

4:52 PM Changeset in webkit [224946] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/fetch/api/abort/serviceworker-intercepted.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179773

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

4:48 PM Changeset in webkit [224945] by Michael Catanzaro

11 edits in trunk/Source

REGRESSION(r224179): layer flush now requires sync IPC to compute undo/redo availability in EditorState
https://bugs.webkit.org/show_bug.cgi?id=179797

Reviewed by Simon Fraser.

Source/WebCore:

Editor::canUndo and Editor::CanRedo no longer need to be exported.

editing/Editor.h:

Source/WebKit:

r224179 introduced a performance regression. The newly-added code in WebPage::editorState is
part of a performance-critical path. (The editor state is computed and sent to the UI
process during the layer flush.) Calls to Editor::canUndo and Editor::canRedo were added,
but these calls are both implemented with sync IPC calls to WebPageProxy in the UI process.
WebPageProxy passes them along to PageClientImpl to compute the availability of the
commands.

That's all pointless because this code only exists for the purpose of getting editing
command availability to the UI process. In the case of undo and redo, it's not needed at
all. I did not realize that when writing the code. So canUndo and canRedo should be removed
from EditorState. This ought to be sufficient to avoid the perf regression.

No changes are needed to the GTK/WPE WebKitEditorState API. The API is reimplemented using
WebPageProxy::canUndoRedo instead of EditorState. There should be no changes in behavior,
only performance.

Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):

Shared/EditorState.h:
UIProcess/API/glib/WebKitEditorState.cpp:

(webkitEditorStateCreate):
(webkitEditorStateChanged):

UIProcess/API/glib/WebKitEditorStatePrivate.h:
UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_get_editor_state):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::canUndo):
(WebKit::WebPageProxy::canRedo):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

4:45 PM Changeset in webkit [224944] by Chris Dumez

6 edits
2 adds in trunk

Dispatching an event on a ServiceWorkerRegistration may fail or crash due to GC
https://bugs.webkit.org/show_bug.cgi?id=179751

Reviewed by Geoffrey Garen.

Source/WebCore:

Dispatching an event on a ServiceWorkerRegistration may fail or crash due to GC. We
need to make sure that a ServiceWorkerRegistration's wrapper stays alive as long as
we may dispatch events on it.

Keep the wrapper alive by making ServiceWorker an ActiveDOMObject and making sure the
implementation object keeps a PendingActivity alive while it may dispatch JS events.
The only event dispatched on ServiceWorkerRegistration objects is the "updatefound"
one. We may dispatch updatefound events on a ServiceWorkerRegistration until the
registration gets cleared on server side, in which case the ServiceWorkerRegistration
object ends up with no service worker. We therefore take a PendingActivity when the
ServiceWorkerRegistration is constructed and we release it once the registration has
no more associated ServiceWorker or the ActiveDOMObject is stopped (to avoid leaks on
navigation).

Test: http/tests/workers/service/service-worker-registration-gc-event.html

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):

workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::getOrCreate):
(WebCore::ServiceWorkerRegistration::updateStateFromServer):
(WebCore::ServiceWorkerRegistration::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerRegistration::stop):
(WebCore::ServiceWorkerRegistration::updatePendingActivityForEventDispatch):

workers/service/ServiceWorkerRegistration.h:
workers/service/ServiceWorkerRegistration.idl:

LayoutTests:

Add layout test coverage.

http/tests/workers/service/service-worker-registration-gc-event-expected.txt: Added.
http/tests/workers/service/service-worker-registration-gc-event.html: Added.

4:35 PM Changeset in webkit [224943] by Chris Dumez

3 edits in trunk/Source/WebCore

Crash in WebCore::SWServerJobQueue::scriptFetchFinished(WebCore::SWServer::Connection&, WebCore::ServiceWorkerFetchResult const&) + 77
https://bugs.webkit.org/show_bug.cgi?id=179394
<rdar://problem/35478190>

Reviewed by Youenn Fablet.

In SWServerJobQueue::scriptFetchFinished(), make sure the job queue is still processing the
job that triggered the fetch. If it is not, ignore the callback.

This could happen when calling SWServer::clear() while a script fetch was pending.

No new tests, already covered by existing tests that sometimes crash on the bots.

workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::isCurrentlyProcessingJob const):
(WebCore::SWServerJobQueue::scriptFetchFinished):

workers/service/server/SWServerJobQueue.h:

4:35 PM Changeset in webkit [224942] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix a bug with cpuid in the FTL.

Rubber stamped by Mark Lam.

Before uploading the previous patch, I tried to condense the code. I
accidentally removed a crucial line saying that CPUID clobbers various
registers.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCPUIntrinsic):

4:28 PM Changeset in webkit [224941] by beidson@apple.com

2 edits in trunk/Source/WebCore

Crash in worker tests handling the m_stoppedCallback.
<rdar://problem/35590875> and https://bugs.webkit.org/show_bug.cgi?id=179798

Reviewed by Chris Dumez.

No new tests (Covered by existing tests).

Protect manipulation of m_stoppedCallback with m_threadCreationAndWorkerGlobalScopeMutex.

workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

4:26 PM Changeset in webkit [224940] by Matt Lewis

3 edits in trunk/LayoutTests

Marked svg/wicd/test-rightsizing-a.xhtml as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179176

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

3:56 PM Changeset in webkit [224939] by commit-queue@webkit.org

11 edits in trunk

[Web Animations] Express time in milliseconds through the API
https://bugs.webkit.org/show_bug.cgi?id=179799

Patch by Antoine Quint <Antoine Quint> on 2017-11-16
Reviewed by Simon Fraser.

Source/WebCore:

While internally we use seconds to specify times and durations, the Web Animations API
uses milliseconds, so we have to convert times and durations from and to milliseconds.

animation/AnimationEffectTiming.h:
animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::bindingsCurrentTime):

animation/WebAnimation.cpp:

(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::setBindingsStartTime):
(WebCore::WebAnimation::bindingsCurrentTime const):
(WebCore::WebAnimation::setBindingsCurrentTime):

testing/Internals.cpp:

(WebCore::Internals::setTimelineCurrentTime):

LayoutTests:

Update tests to use milliseconds rather than seconds.

http/wpt/wk-web-animations/timing-model/animation-current-time.html:
http/wpt/wk-web-animations/timing-model/animation-interface-start-time-property.html:
http/wpt/wk-web-animations/timing-model/animation-playback-rate.html:
http/wpt/wk-web-animations/timing-model/keyframe-effect-interface-timing-duration.html:
http/wpt/wk-web-animations/timing-model/timeline-current-time.html:

3:44 PM Changeset in webkit [224938] by sbarati@apple.com

21 edits in trunk/Source/JavaScriptCore

Add some X86 intrinsics to $vm to help with some perf testing
https://bugs.webkit.org/show_bug.cgi?id=179693

Reviewed by Mark Lam.

I've been doing some local perf testing of various ideas and have
had these come in handy. I'm going to land them to dollarVM to prevent
having to add them to my local build every time I do perf testing.

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::mfence):
(JSC::MacroAssemblerX86Common::rdtsc):
(JSC::MacroAssemblerX86Common::pause):
(JSC::MacroAssemblerX86Common::cpuid):

assembler/X86Assembler.h:

(JSC::X86Assembler::rdtsc):
(JSC::X86Assembler::pause):
(JSC::X86Assembler::cpuid):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGNode.h:

(JSC::DFG::Node::intrinsic):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGValidate.cpp:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCPUIntrinsic):

runtime/Intrinsic.cpp:

(JSC::intrinsicName):

runtime/Intrinsic.h:
tools/JSDollarVM.cpp:

(JSC::functionCpuMfence):
(JSC::functionCpuRdtsc):
(JSC::functionCpuCpuid):
(JSC::functionCpuPause):
(JSC::functionCpuClflush):
(JSC::JSDollarVM::finishCreation):

3:27 PM Changeset in webkit [224937] by Michael Catanzaro

6 edits in trunk/Source/WebCore

REGRESSION(r224887): GCC 5 build broken
https://bugs.webkit.org/show_bug.cgi?id=179750

Reviewed by Jer Noble.

Add a legacy FourCC constructor that will be used only when building with GCC 5. This is
bad, but it seems acceptable for use with a fallback codepath.

Unfortunately, this requires adjusting some initializations to avoid ambiguity with the
uint32_t constructor.

platform/graphics/FourCC.h:

(WebCore::FourCC::FourCC):

platform/graphics/iso/ISOBox.cpp:

(WebCore::ISOBox::peekBox):

platform/graphics/iso/ISOBox.h:
platform/graphics/iso/ISOOriginalFormatBox.h:
platform/graphics/iso/ISOSchemeTypeBox.h:

2:27 PM Changeset in webkit [224936] by Matt Lewis

2 edits in trunk/LayoutTests

Marked multiple http/tests/cache/disk-cache/ tests as flaky.

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

1:59 PM Changeset in webkit [224935] by aestes@apple.com

2 edits in trunk/Source/WebCore

[Payment Request] Update feature status to "Supported In Preview"
https://bugs.webkit.org/show_bug.cgi?id=179793

Reviewed by Tim Horton.

features.json:

12:38 PM Changeset in webkit [224934] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Clean up KeyframeEffect
https://bugs.webkit.org/show_bug.cgi?id=179777

Patch by Antoine Quint <Antoine Quint> on 2017-11-16
Reviewed by Daniel Bates.

A few review comments came in after https://bugs.webkit.org/show_bug.cgi?id=179707 landed,
addressing them with this follow-up patch.

animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::create): Use "keyframeEffect" instead of "result" for clarity.
(WebCore::KeyframeEffect::processKeyframes): Use consistent index and length types while iterating
over properties in PropertyNameArray and explicitly size the properties array since we already
know its final size.

dom/Element.cpp:

(WebCore::Element::getAnimations):

12:26 PM Changeset in webkit [224933] by Alan Bujtas

16 edits in trunk/Source/WebCore

Always invoke RenderObject::insertedIntoTree/willBeRemovedFromTree
https://bugs.webkit.org/show_bug.cgi?id=178007

Reviewed by Antti Koivisto.

Based on Antti Koivisto's patch:
These call are currently skipped in some cases making them bug prone and difficult to reason about.
This is done as an optimization that doesn't appear to be valuable anymore.

Covered by existing tests.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::dropAnonymousBoxChild):
(WebCore::RenderBlock::takeChild):

rendering/RenderBlock.h:

(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::moveAllChildrenIncludingFloatsTo):

rendering/RenderBlockFlow.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::splitAnonymousBoxesAroundChild):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):

rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveAllChildrenTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):

rendering/RenderElement.cpp:

(WebCore::RenderElement::addChild):
(WebCore::RenderElement::takeChild):
(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::takeChildInternal):
(WebCore::RenderElement::handleDynamicFloatPositionChange):

rendering/RenderElement.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::childBecameNonInline):

rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):

rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):

rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::takeChild):

rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::collapseAndDestroyAnonymousSiblingRows):

style/RenderTreeUpdaterMultiColumn.cpp:

(WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow):
(WebCore::RenderTreeUpdater::MultiColumn::destroyFragmentedFlow):

12:07 PM Changeset in webkit [224932] by jmarcell@apple.com

2 edits in tags/Safari-605.1.14/Source/WTF

Cherry-pick r224907. rdar://problem/35519421

12:02 PM Changeset in webkit [224931] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/2dcontext/the-canvas-state/canvas_state_restore_001.htm is an ImageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=179786

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16

TestExpectations: Temporarily marking test as failing.

11:33 AM Changeset in webkit [224930] by Megan Gardner

13 edits in trunk/Source/WebKit

Remove allowBlockSelection as block selection is not supported anymore
https://bugs.webkit.org/show_bug.cgi?id=179738

Reviewed by Tim Horton.

Remove all instances of the alloweBlockSelection flag. Blocks selection is fully disabled
and thus this flag will do nothing. This was only added as a debug measure last year, and nothing
ever actually used it.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _allowsBlockSelection]): Deleted.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsBlockSelection]): Deleted.
(-[WKWebViewConfiguration _setAllowsBlockSelection:]): Deleted.

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::allowsBlockSelection): Deleted.

WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:

11:19 AM Changeset in webkit [224929] by dino@apple.com

27 edits
2 copies in trunk/Source/WebCore

Add a base class for HTMLCanvasElement and OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=179701
<rdar://problem/35545195>

Reviewed by Sam Weinig.

In order for OffscreenCanvas to be able to create a WebGLRenderingContext,
there needs to be a shared base class with HTMLCanvasElement. Add such a
class called CanvasBase.

There is a lot of potential for functionality to move into the base class, but
unfortunately HTMLCanvasElement is a bit messy. It implements a lot of the 2d
rendering context functionality, and also many const functions that actually
cause changes. Thus, things like the canvas size have to remain in the subclasses
for now.

The existence of the new base class meant the canvas() accessor in CanvasRenderingContext
had to move out into the subclasses, and do the correct casting. Eventually, at least
for WebGLRenderingContext, this will have a change in behaviour, but for now we only
ever use HTMLCanvasElements, so most of these changes are just for the sake of
compilation.

No behaviour change - covered by existing tests.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
html/CanvasBase.cpp: Copied from Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h.

(WebCore::CanvasBase::CanvasBase): New base class.
(WebCore::CanvasBase::asHTMLCanvasElement): Casts to an HTMLCanvasElement*, which many of the
rendering context code uses.

html/CanvasBase.h: Copied from Source/WebCore/html/canvas/GPUBasedCanvasRenderingContext.h.

(WebCore::CanvasBase::isHTMLCanvasElement const):
(WebCore::CanvasBase::isOffscreenCanvas const):
(WebCore::CanvasBase::setOriginClean):
(WebCore::CanvasBase::setOriginTainted):
(WebCore::CanvasBase::originClean const):
(WebCore::CanvasBase::securityOrigin const):
(WebCore::CanvasBase::scriptExecutionContext const):

html/HTMLCanvasElement.cpp: Use the base class methods where possible.

(WebCore::HTMLCanvasElement::HTMLCanvasElement):
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::toBlob):
(WebCore::HTMLCanvasElement::createImageBuffer const): Be explict as to
which of the derived classes scriptExecutionContext() method we are calling.

html/HTMLCanvasElement.h: Use the base class, mark a few things as virtual,

and remove the parts that are now in CanvasBase.

html/OffscreenCanvas.cpp: Use the base class.

(WebCore::OffscreenCanvas::OffscreenCanvas):
(WebCore::OffscreenCanvas::size const):
(WebCore::OffscreenCanvas::setSize):

html/OffscreenCanvas.h:

html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::CanvasRenderingContext):
(WebCore::CanvasRenderingContext::ref): Call the correct ref/deref functions, depending
on the base class type.
(WebCore::CanvasRenderingContext::deref):
(WebCore::CanvasRenderingContext::wouldTaintOrigin): We no longer have a canvas() method.
(WebCore::CanvasRenderingContext::checkOrigin):

html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::canvasBase const): Add this accessor to the base canvas object
to replace the canvas() call.
(WebCore::CanvasRenderingContext::checkOrigin):
(WebCore::CanvasRenderingContext::ref): Deleted.
(WebCore::CanvasRenderingContext::deref): Deleted.
(WebCore::CanvasRenderingContext::canvas const): Deleted.

html/canvas/CanvasRenderingContext2D.cpp: Use the base class.

(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/GPUBasedCanvasRenderingContext.h:

(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

html/canvas/ImageBitmapRenderingContext.cpp:

(WebCore::ImageBitmapRenderingContext::ImageBitmapRenderingContext):
(WebCore::ImageBitmapRenderingContext::canvas const):
(WebCore::ImageBitmapRenderingContext::setOutputBitmap):

html/canvas/ImageBitmapRenderingContext.h:
html/canvas/PlaceholderRenderingContext.cpp:

(WebCore::PlaceholderRenderingContext::PlaceholderRenderingContext):

html/canvas/PlaceholderRenderingContext.h:
html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::WebGL2RenderingContext):

html/canvas/WebGL2RenderingContext.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::WebGLRenderingContext):

html/canvas/WebGLRenderingContext.h:
html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create): Assume that we're still getting an HTMLCanvasElement,
but protect some of the logic just in case we don't.
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::canvas):
(WebCore::WebGLRenderingContextBase::checkForContextLossHandling):
(WebCore::WebGLRenderingContextBase::registerWithWebGLStateTracker):
(WebCore::WebGLRenderingContextBase::setupFlags):
(WebCore::WebGLRenderingContextBase::addActivityStateChangeObserverIfNecessary):
(WebCore::WebGLRenderingContextBase::removeActivityStateChangeObserver):
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContextBase::reshape):
(WebCore::WebGLRenderingContextBase::compileShader):
(WebCore::WebGLRenderingContextBase::isContextLostOrPending):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::printToConsole):
(WebCore::WebGLRenderingContextBase::dispatchContextLostEvent):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::dispatchContextChangedEvent):
(WebCore::WebGLRenderingContextBase::clampedCanvasSize):

html/canvas/WebGLRenderingContextBase.h:
html/canvas/WebGLRenderingContextBase.idl:
html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::create):
(WebCore::WebGPURenderingContext::WebGPURenderingContext):
(WebCore::WebGPURenderingContext::canvas const):
(WebCore::WebGPURenderingContext::clampedCanvasSize const):

html/canvas/WebGPURenderingContext.h:
inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::didEnableExtension):
(WebCore::InspectorInstrumentation::didCreateProgram):
(WebCore::InspectorInstrumentation::willDeleteProgram):
(WebCore::InspectorInstrumentation::isShaderProgramDisabled):

inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::recordCanvasAction):
(WebCore::InspectorCanvasAgent::didEnableExtension):
(WebCore::InspectorCanvasAgent::didCreateProgram):

11:13 AM Changeset in webkit [224928] by commit-queue@webkit.org

3 edits
2 adds in trunk

Source/WebCore:
Added mime type check to the picture source preloader to avoid downloading incompatible resources.
https://bugs.webkit.org/show_bug.cgi?id=179231

Patch by Colin Bendell <colin> on 2017-11-16
Reviewed by Alex Christensen.

Test: http/tests/loading/preload-picture-type.html

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): include type match state when selecting candidate imgs
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): added type attribute evaluation and matching

LayoutTests:
Add tests to ensure that <source> tags are only preloaded when the type
attribute matches.
https://bugs.webkit.org/show_bug.cgi?id=179231

Patch by Colin Bendell <colin> on 2017-11-16
Reviewed by Alex Christensen.

http/tests/preload/picture-type-expected.txt: Added.
http/tests/preload/picture-type.html: Added.

11:08 AM Changeset in webkit [224927] by jfbastien@apple.com

7 edits in trunk/Source/JavaScriptCore

It should be easier to reify lazy property names
https://bugs.webkit.org/show_bug.cgi?id=179734
<rdar://problem/35492521>

Reviewed by Keith Miller.

We reify lazy property names in a few different ways, each
specific to the JSCell implementation, in put() instead of having
a special function to do reification. Let's make that simpler.

This patch makes it easier to reify property names in a uniform
manner, and does so in JSFunction. As a follow up I'll use the
same mechanics for:

ClonedArguments callee, iteratorSymbol (Symbol.iterator)
ErrorConstructor stackTraceLimit
ErrorInstance line, column, sourceURL, stack
GenericArguments length, callee, iteratorSymbol (Symbol.iterator)
GetterSetter RELEASE_ASSERT_NOT_REACHED()
JSArray length
RegExpObject lastIndex
StringObject length

runtime/ClassInfo.h: Add reifyPropertyNameIfNeeded to method table.
runtime/JSCell.cpp:

(JSC::JSCell::reifyPropertyNameIfNeeded): by default, don't reify.

runtime/JSCell.h:
runtime/JSFunction.cpp: name and length can be reified.

(JSC::JSFunction::reifyPropertyNameIfNeeded):
(JSC::JSFunction::put):
(JSC::JSFunction::reifyLength):
(JSC::JSFunction::reifyName):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyLazyPropertyForHostOrBuiltinIfNeeded):
(JSC::JSFunction::reifyLazyLengthIfNeeded):
(JSC::JSFunction::reifyLazyNameIfNeeded):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):

runtime/JSFunction.h:

(JSC::JSFunction::isLazy):
(JSC::JSFunction::isReified):

runtime/JSObjectInlines.h:

(JSC::JSObject::putDirectInternal): do the reification here.

11:07 AM Changeset in webkit [224926] by Michael Catanzaro

2 edits in trunk

[WPE] Expose ENABLE_JIT and USE_SYSTEM_MALLOC options
https://bugs.webkit.org/show_bug.cgi?id=179730

Reviewed by Carlos Alberto Lopez Perez.

Source/cmake/OptionsWPE.cmake:

10:47 AM Changeset in webkit [224925] by Brent Fulgham

2 edits in trunk/Source/WebKit

Whitelist additional IOKit properties based on customer feedback
https://bugs.webkit.org/show_bug.cgi?id=179782
<rdar://problem/35508246>

Reviewed by Dean Jackson.

Expand the IOKit property whitelist to recognize a few more properties as valid based on review of logs
from customer systems and our test infrastructure.

WebProcess/com.apple.WebProcess.sb.in:

10:21 AM Changeset in webkit [224924] by Chris Dumez

6 edits
2 adds in trunk

Dispatching an event on a ServiceWorker may fail or crash due to GC
https://bugs.webkit.org/show_bug.cgi?id=179745

Reviewed by Geoffrey Garen.

Source/WebCore:

Dispatching an event on a ServiceWorker may fail or crash due to GC. We need to make sure
that a ServiceWorker's wrapper stays alive as long as we may dispatch events on it.

Keep the wrapper alive by making ServiceWorker an ActiveDOMObject and making sure the
implementation object keeps a PendingActivity alive while it may dispatch JS events.
The only event dispatched on ServiceWorker objects is the "statechange" one. We may
dispatch statechange events on a ServiceWorker until its state becomes "redundant".
We therefore take a PendingActivity when the ServiceWorker's state is or becomes
non-redundant (becoming non redundant can only happen when switching initially from
redundant to installing, at which point the ServiceWorker object is not exposed to
the JS yet). We release the PendingActivity when the ServiceWorker's state becomes
redundant or the ActiveDOMObject is stopped (to avoid leaks on navigation).

Test: http/tests/workers/service/service-worker-gc-event.html

workers/service/ServiceWorker.cpp:

(WebCore::mutableAllWorkers):
(WebCore::ServiceWorker::removeFromAllWorkers):
(WebCore::ServiceWorker::getOrCreate):
(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::~ServiceWorker):
(WebCore::ServiceWorker::scheduleTaskToUpdateState):
(WebCore::ServiceWorker::activeDOMObjectName const):
(WebCore::ServiceWorker::canSuspendForDocumentSuspension const):
(WebCore::ServiceWorker::stop):
(WebCore::ServiceWorker::updatePendingActivityForEventDispatch):

workers/service/ServiceWorker.h:
workers/service/ServiceWorker.idl:

LayoutTests:

Add layout test coverage.

http/tests/workers/service/resources/sw-test-pre.js:
http/tests/workers/service/service-worker-gc-event.html: Added.
http/tests/workers/service/service-worker-gc-event-expected.txt: Added.

10:05 AM Changeset in webkit [224923] by Chris Dumez

10 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline skipped and flaky service workers tests.

web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
web-platform-tests/service-workers/service-worker/respond-with-body-accessed-response.https-expected.txt:
web-platform-tests/service-workers/service-worker/uncontrolled-page.https-expected.txt:
web-platform-tests/service-workers/service-worker/unregister-controller.https-expected.txt:
web-platform-tests/service-workers/service-worker/update-bytecheck.https-expected.txt:
web-platform-tests/service-workers/service-worker/worker-interception.https-expected.txt:

9:37 AM Changeset in webkit [224922] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179771

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-16

TestExpectations: Marking test as flaky until we have full support of SW opaque responses.

9:30 AM Changeset in webkit [224921] by Ms2ger@igalia.com

3 edits
41 moves
9 adds
47 deletes in trunk/LayoutTests

LayoutTests/imported/w3c:
Import 2dcontext/the-canvas-state/ from wpt.
https://bugs.webkit.org/show_bug.cgi?id=179769

Reviewed by Youenn Fablet.

Also remove the outdated and unmaintained copies of those tests.

The only substantive changes are changes from _assertEqual to _assertSame;
that is, from comparing with == to comparing with ===. (I made this
change upstream in 2014.)

resources/import-expectations.json:
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.bitmap-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.bitmap-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.bitmap.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.bitmap.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.clip-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.clip-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.clip.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.clip.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.fillStyle-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.fillStyle-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.fillStyle.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.fillStyle.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.font-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.font-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.font.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.font.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalAlpha-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalAlpha-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalAlpha.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalAlpha.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalCompositeOperation-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalCompositeOperation-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.globalCompositeOperation.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.globalCompositeOperation.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.imageSmoothingEnabled-expected.txt: Added.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.imageSmoothingEnabled.html: Added.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineCap-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineCap-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineCap.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineCap.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineJoin-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineJoin-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineJoin.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineJoin.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineWidth-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineWidth-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.lineWidth.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.lineWidth.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.miterLimit-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.miterLimit-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.miterLimit.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.miterLimit.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.path-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.path-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.path.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.path.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowBlur-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowBlur-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowBlur.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowBlur.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowColor-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowColor-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowColor.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowColor.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetX-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetX-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetX.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetX.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetY-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetY-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.shadowOffsetY.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.shadowOffsetY.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stack-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stack-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stack.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stack.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stackdepth-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stackdepth-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.stackdepth.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.stackdepth.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.strokeStyle-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.strokeStyle-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.strokeStyle.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.strokeStyle.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textAlign-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textAlign-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textAlign.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textAlign.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textBaseline-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textBaseline-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.textBaseline.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.textBaseline.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.transformation-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.transformation-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.transformation.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.transformation.html.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.underflow-expected.txt: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.underflow-expected.txt.
web-platform-tests/2dcontext/the-canvas-state/2d.state.saverestore.underflow.html: Renamed from LayoutTests/imported/w3c/canvas/2d.state.saverestore.underflow.html.
web-platform-tests/2dcontext/the-canvas-state/canvas_state_restore_001-expected.htm: Added.
web-platform-tests/2dcontext/the-canvas-state/canvas_state_restore_001.htm: Added.
web-platform-tests/2dcontext/the-canvas-state/w3c-import.log: Added.

LayoutTests:
Remove the outdated and unmaintained copies of the tests in wpt/2dcontext/the-canvas-state/.
https://bugs.webkit.org/show_bug.cgi?id=179769

Reviewed by Youenn Fablet.

canvas/philip/tests/2d.state.saverestore.bitmap-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.bitmap.html: Removed.
canvas/philip/tests/2d.state.saverestore.clip-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.clip.html: Removed.
canvas/philip/tests/2d.state.saverestore.fillStyle-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.fillStyle.html: Removed.
canvas/philip/tests/2d.state.saverestore.font-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.font.html: Removed.
canvas/philip/tests/2d.state.saverestore.globalAlpha-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.globalAlpha.html: Removed.
canvas/philip/tests/2d.state.saverestore.globalCompositeOperation-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.globalCompositeOperation.html: Removed.
canvas/philip/tests/2d.state.saverestore.lineCap-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.lineCap.html: Removed.
canvas/philip/tests/2d.state.saverestore.lineJoin-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.lineJoin.html: Removed.
canvas/philip/tests/2d.state.saverestore.lineWidth-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.lineWidth.html: Removed.
canvas/philip/tests/2d.state.saverestore.miterLimit-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.miterLimit.html: Removed.
canvas/philip/tests/2d.state.saverestore.path-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.path.html: Removed.
canvas/philip/tests/2d.state.saverestore.shadowBlur-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.shadowBlur.html: Removed.
canvas/philip/tests/2d.state.saverestore.shadowColor-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.shadowColor.html: Removed.
canvas/philip/tests/2d.state.saverestore.shadowOffsetX-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.shadowOffsetX.html: Removed.
canvas/philip/tests/2d.state.saverestore.shadowOffsetY-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.shadowOffsetY.html: Removed.
canvas/philip/tests/2d.state.saverestore.stack-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.stack.html: Removed.
canvas/philip/tests/2d.state.saverestore.stackdepth-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.stackdepth.html: Removed.
canvas/philip/tests/2d.state.saverestore.strokeStyle-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.strokeStyle.html: Removed.
canvas/philip/tests/2d.state.saverestore.textAlign-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.textAlign.html: Removed.
canvas/philip/tests/2d.state.saverestore.textBaseline-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.textBaseline.html: Removed.
canvas/philip/tests/2d.state.saverestore.transformation-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.transformation.html: Removed.
canvas/philip/tests/2d.state.saverestore.underflow-expected.txt: Removed.
canvas/philip/tests/2d.state.saverestore.underflow.html: Removed.

7:52 AM Changeset in webkit [224920] by pvollan@apple.com

2 edits in trunk/Tools

Win EWS bots should reboot after N webkit-patch iterations.
https://bugs.webkit.org/show_bug.cgi?id=177970

Reviewed by Brent Fulgham.

EWSTools/start-queue-win.sh:

7:49 AM Changeset in webkit [224919] by pvollan@apple.com

2 edits in trunk/LayoutTests

Mark http/wpt/offscreen-canvas/getContext-webgl.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=179767

Unreviewed test gardening.

platform/win/TestExpectations:

7:48 AM Changeset in webkit [224918] by rmorisset@apple.com

5 edits in trunk/Source/JavaScriptCore

Provide a runtime option for disabling the optimization of recursive tail calls
https://bugs.webkit.org/show_bug.cgi?id=179765

Reviewed by Mark Lam.

bytecode/PreciseJumpTargets.cpp:

(JSC::getJumpTargetsForBytecodeOffset):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnter):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):

runtime/Options.h:

7:41 AM Changeset in webkit [224917] by pvollan@apple.com

2 edits in trunk/LayoutTests

Mark accessibility/accessibility-object-model.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=179766

Unreviewed test gardening.

platform/win/TestExpectations:

7:08 AM Changeset in webkit [224916] by rmorisset@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix null pointer dereference in bytecodeDumper
https://bugs.webkit.org/show_bug.cgi?id=179764

Reviewed by Mark Lam.

The problem was just a call to lastSeenCallee() that was unguarded by haveLastSeenCallee().

bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::printCallOp):

7:04 AM Changeset in webkit [224915] by rmorisset@apple.com

3 edits
1 add in trunk

REGRESSION (r224592): oss-fuzz: jsc: Null-dereference READ in JSC::JSCell::isObject (4216)
https://bugs.webkit.org/show_bug.cgi?id=179763
<rdar://problem/35550513>

Reviewed by Keith Miller.

JSTests:

Just adding a slightly cleaned-up version of the original fuzzer-found test.

stress/tdz-this-in-try-catch.js: Added.

(v_6388):
(v_6392):

Source/JavaScriptCore:

Fix null pointer dereference caused by an eliminated tdz_check

The problem was when doing an OSR entry in DFG while |this| was null
(because super() had not yet been called in the constructor of this
subclass), it would be marked as non-null, and the tdz_check eliminated.

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):

5:49 AM Changeset in webkit [224914] by fred.wang@free.fr

2 edits in trunk/Source/WebCore

Consider non-main frames for frameViewRootLayerDidChange
https://bugs.webkit.org/show_bug.cgi?id=178508

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-16
Reviewed by Antonio Gomes.

No new tests, behavior unchanged.

AsyncScrollingCoordinator::frameViewRootLayerDidChange assumes that frameView is always a
main-frame. It calls ensureRootStateNodeForFrameView, which always attaches a frame node with
null parent ID. It also has an ASSERT to check m_scrollingStateTree->rootStateNode(), instead
of m_scrollingStateTree->stateNodeForID(frameView.scrollLayerID()). This patch makes the
ASSERT more generic. It also adds an early return into ensureRootStateNodeForFrameView when the
node already exists so that the call to attachToStateTree can be skipped. It turns out that that
call is actually only necessary for main frame, so another ASSERT is added to verify it.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange): Modify the ASSERT to
verify the availability of a scrolling node for the frame, not just the root node.
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView): Add an early return to
skip the call to attachToStateTree when the node is actually already available. Add an ASSERT to
ensure that attaching a new node is only necessary for main frames.

4:48 AM Changeset in webkit [224913] by Carlos Garcia Campos

12 edits
3 copies
2 adds in trunk

[WPE] Add initial support for WebDriver
https://bugs.webkit.org/show_bug.cgi?id=179727

Reviewed by Michael Catanzaro.

Enable WebDriver by default in WPE.

Source/cmake/OptionsWPE.cmake:

Source/WebDriver:

Add WPE implementation for platform-specific methods. Move the version handling to a common file
WebDriverServiceGLib.cpp.

Capabilities.h:
PlatformGTK.cmake:
PlatformWPE.cmake:
glib/WebDriverServiceGLib.cpp: Added.

(WebDriver::parseVersion):
(WebDriver::WebDriverService::platformCompareBrowserVersions):

gtk/WebDriverServiceGtk.cpp:
wpe/WebDriverServiceWPE.cpp: Copied from Source/WebDriver/gtk/WebDriverServiceGtk.cpp.

(WebDriver::WebDriverService::platformCapabilities):
(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformMatchCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

Tools:

Make it possible to run WebDriver tests with WPE.

Scripts/run-webdriver-tests: Add --wpe alias for --platform=wpe.
Scripts/webkitpy/port/wpe.py:

(WPEPort.init): Initialize _display_server from options.
(WPEPort._driver_class): Use WaylandDriver when wayland is passed as display server option.

Scripts/webkitpy/webdriver_tests/webdriver_driver.py:

(WebDriver.browser_env): Add virtual method to get the environment that should be used.

Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py: Copied from Tools/Scripts/webkitpy/webdriver_tests/webdriver_driver.py.

(WebDriverWPE):
(WebDriverWPE.init):
(WebDriverWPE.binary_path):
(WebDriverWPE.browser_name):
(WebDriverWPE.capabilities):
(WebDriverWPE.browser_env):

Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:

(WebDriverW3CExecutor.init): Update the environment with the one provided by the driver.

wpe/jhbuild.modules: Upgrade dyz to newer version that supports automation.

4:22 AM Changeset in webkit [224912] by magomez@igalia.com

15 edits in trunk/Source/WebCore

[TexMap] Remove use of GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=174860

Reviewed by Žan Doberšek.

Remove remaining uses of GC3D that are not WebGL related:

Remove the option to create a GC3D to render to the curren OpenGL context.
Remove the remaining usage of GC3D inside MediaPlayerPrivateGStreamerBase.
Replace the usage inside TextureMapper with direct OpenGL calls, and use a

VAO when the OpenGL version is higher than 3.2.

This also modifies TextureMapperContextAttributes so all the tested features are
supported when using OpenGL, and we only check for the extensions when using GLES2.

No new tests as there's no behavior change.

platform/graphics/GraphicsContext3D.h:
platform/graphics/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):

platform/graphics/GraphicsContext3DPrivate.h:
platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::~GraphicsContext3D):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
platform/graphics/texmap/TextureMapper.h:
platform/graphics/texmap/TextureMapperContextAttributes.cpp:

(WebCore::TextureMapperContextAttributes::initialize):

platform/graphics/texmap/TextureMapperContextAttributes.h:
platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:

(WebCore::TextureMapperGC3DPlatformLayer::TextureMapperGC3DPlatformLayer):
(WebCore::TextureMapperGC3DPlatformLayer::makeContextCurrent):
(WebCore::TextureMapperGC3DPlatformLayer::platformContext):
(WebCore::TextureMapperGC3DPlatformLayer::swapBuffersIfNeeded):
(WebCore::TextureMapperGC3DPlatformLayer::paintToTextureMapper):

platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::SharedGLData::currentSharedGLData):
(WebCore::TextureMapperGLData::TextureMapperGLData):
(WebCore::TextureMapperGLData::~TextureMapperGLData):
(WebCore::TextureMapperGLData::initializeStencil):
(WebCore::TextureMapperGLData::getStaticVBO):
(WebCore::TextureMapperGLData::getVAO):
(WebCore::TextureMapperGLData::getShaderProgram):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::TextureMapperGL::endPainting):
(WebCore::TextureMapperGL::drawBorder):
(WebCore::prepareFilterProgram):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::TextureMapperGL::clearColor):
(WebCore::TextureMapperGL::drawEdgeTriangles):
(WebCore::TextureMapperGL::drawUnitRect):
(WebCore::TextureMapperGL::draw):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawFiltered):
(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::createTexture):

platform/graphics/texmap/TextureMapperGL.h:

3:26 AM WebKitGTK/Gardening/Calendar edited by magomez@igalia.com

(diff)

3:20 AM Changeset in webkit [224911] by magomez@igalia.com

3 edits in trunk/LayoutTests

Unreviewed GTK+ and WPE gardening after r224910.

platform/gtk/TestExpectations:
platform/wpe/TestExpectations:

12:14 AM Changeset in webkit [224910] by fred.wang@free.fr

3 edits
2 adds in trunk

ASSERTION FAILED: !isAnonymous() in WebCore::RenderMathMLOperator::updateTokenContent
https://bugs.webkit.org/show_bug.cgi?id=166011

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-16
Reviewed by Alejandro G. Castro.

Source/WebCore:

RenderMathMLFencedOperator does not support mathvariant or displaystyle transforms. This is
one of several issues of the mfenced element (see bug 160509). However,
MathMLStyle::updateStyleIfNeeded() still tries to use the implementation of the parent
RenderMathMLOperator class, which only works for non-anonymous operators. This patch skips
the updateTokenContent() calls for anonymous mfenced operators in order to avoid ASSERTION
failures.

Test: mathml/mfenced-displaystyle-and-mathvariant-crash.html

rendering/mathml/MathMLStyle.cpp:

(WebCore::MathMLStyle::updateStyleIfNeeded): Skip anonymous token elements.

LayoutTests:

Add a crash test checking displaystyle and mathvariant on mfenced operators.

mathml/mfenced-displaystyle-and-mathvariant-crash-expected.txt: Added.
mathml/mfenced-displaystyle-and-mathvariant-crash.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed