Context Navigation

← Previous Period
Next Period →

Timeline

Nov 28, 2017:

11:52 PM Changeset in webkit [225264] by Brent Fulgham

20 edits
1 add in trunk/Source

Adopt updated NSKeyed[Un]Archiver API when available
https://bugs.webkit.org/show_bug.cgi?id=180127
<rdar://problem/35710738>

Reviewed by Alex Christensen.

Source/WebCore:

Switch to new NSKeyed[Un]Archiver methods when available. We do not attempt
to adopt secure coding in places we were not under the original API.

Most of the new API is wrapped in a set of convenience methods so we can
build without the new API on older systems.

No change in behavior.

editing/cocoa/EditorCocoa.mm:

(WebCore::archivedDataForAttributedString): Use new convenience method
to archive the string object.

loader/archive/cf/LegacyWebArchiveMac.mm:

(WebCore::LegacyWebArchive::createResourceResponseFromMacArchivedData): Update to
use secure coding where possible.
(WebCore::LegacyWebArchive::createPropertyListRepresentation): Ditto.

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::write): Use new secure API.
(WebCore::PlatformPasteboard::typesSafeForDOMToReadAndWrite const): Ditto.

testing/cocoa/WebArchiveDumpSupport.mm:

(WebCoreTestSupport::createCFURLResponseFromResponseData): Update to
secure coding API where possible.

Source/WebCore/PAL:

Add new convenience methods (and SPI headers) so we can adopt new NSKeyedArchiver
API that uses secure coding by default.

PAL.xcodeproj/project.pbxproj:
pal/spi/cocoa/NSKeyedArchiverSPI.h: Added.

(securelyArchivedDataWithRootObject): New convenience method.
(securelyUnarchiveRootObjectOfClassFromData): Ditto.
(secureArchiverFromMutableData): Ditto.
(secureUnarchiverFromData): Ditto.

Source/WebKit:

Switch to new NSKeyed[Un]Archiver methods when available. We do not attempt
to adopt secure coding in places we were not under the original API.

Platform/ios/AccessibilityIOS.mm:

(WebKit::newAccessibilityRemoteToken): Use secure-by-default API.

Shared/Cocoa/DataDetectionResult.mm:

(WebKit::DataDetectionResult::encode const): Ditto.
(WebKit::DataDetectionResult::decode): Ditto.

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::Payment>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::Payment>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentContact>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentContact>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMerchantSession>::decode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMethod>::encode): Ditto.
(IPC::ArgumentCoder<WebCore::PaymentMethod>::decode): Ditto.

Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const): Ditto.
(WebKit::InteractionInformationAtPosition::decode): Ditto.

Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<Credential>::decodePlatformData): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode): Ditto.
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::decode): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::encodePlatformData): Ditto.
(IPC::ArgumentCoder<MediaPlaybackTargetContext>::decodePlatformData): Ditto.

Shared/mac/WebHitTestResultData.mm:

(WebKit::WebHitTestResultData::platformEncode const): Ditto.
(WebKit::WebHitTestResultData::platformDecode): Ditto.

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setObject:forBundleParameter:]): Ditto.
(-[WKProcessPool _setObjectsForBundleParametersWithDictionary:]): Ditto.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setInputDelegate:]): Ditto.

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess): Ditto.

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::startAssistingNode): Ditto.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Ditto.

WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::initialize): Ditto.
(WebKit::InjectedBundle::setBundleParameter): Ditto.
(WebKit::InjectedBundle::setBundleParameters): Ditto.

11:26 PM Changeset in webkit [225263] by commit-queue@webkit.org

54 edits in trunk/Source

Web Inspector: Cleanup Inspector classes be more consistent about using fast malloc / noncopyable
https://bugs.webkit.org/show_bug.cgi?id=180119

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Devin Rousso.

Source/JavaScriptCore:

inspector/InjectedScriptManager.h:
inspector/JSGlobalObjectScriptDebugServer.h:
inspector/agents/InspectorHeapAgent.h:
inspector/agents/InspectorRuntimeAgent.h:
inspector/agents/InspectorScriptProfilerAgent.h:
inspector/agents/JSGlobalObjectRuntimeAgent.h:

Source/WebCore:

inspector/InspectorCanvas.cpp:
inspector/InspectorDatabaseResource.cpp:
inspector/InspectorFrontendClientLocal.cpp:
inspector/InspectorFrontendClientLocal.h:
inspector/InspectorFrontendHost.cpp:
inspector/InspectorHistory.h:
inspector/InspectorInstrumentation.cpp:
inspector/InspectorOverlay.cpp:
inspector/InspectorShaderProgram.cpp:
inspector/InspectorStyleSheet.cpp:
inspector/InstrumentingAgents.cpp:
inspector/PageScriptDebugServer.h:
inspector/TimelineRecordFactory.cpp:
inspector/WebInjectedScriptManager.cpp:
inspector/WebInjectedScriptManager.h:
inspector/WorkerScriptDebugServer.cpp:
inspector/WorkerScriptDebugServer.h:
inspector/agents/*

Be more consistent about namespace / fast malloc / noncopyable.

11:25 PM Changeset in webkit [225262] by Carlos Garcia Campos

5 edits in trunk/Tools

WebDriver: add an option to dump test results to a json file
https://bugs.webkit.org/show_bug.cgi?id=180082

Reviewed by Brian Burg.

Add --json-output command line option to run-webdriver-tests to dump test results to a json file in a format
compatible with the W3C report. WebDriverTestResult now represents a test file and contains a list of
subtests, instead of having one WebDriverTestResult per subtest. This way we can store also the harness result
and dump the results to different formats.

Scripts/run-webdriver-tests:
Scripts/webkitpy/webdriver_tests/webdriver_test_result.py:

(WebDriverTestResult.init):
(WebDriverTestResult):
(WebDriverTestResult.add_subtest_results):

Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner.print_results):
(WebDriverTestRunner):
(WebDriverTestRunner.dump_results_to_json_file):

Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

(WebDriverTestRunnerW3C.run):

11:09 PM Changeset in webkit [225261] by webkit@devinrousso.com

3 edits in trunk/Source/WebInspectorUI

Web Inspector: remove extra space before call frames in Canvas backtraces
https://bugs.webkit.org/show_bug.cgi?id=180129

Reviewed by Matt Baker.

UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):

UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:

(WI.RecordingTraceDetailsSidebarPanel):
Hide the disclosure buttons of these TreeOutlines as they don't have children.

11:07 PM Changeset in webkit [225260] by zandobersek@gmail.com

5 edits in trunk

[Cairo] Limit the number of active contexts in GraphicsContext3DCairo
https://bugs.webkit.org/show_bug.cgi?id=166968

Reviewed by Alex Christensen.

Source/WebCore:

Cairo's implementation of GraphicsContext3D should follow the Mac's
and limit the number of active GraphicsContext3D objects.

The active contexts are listed in a global Deque, with the first
among them being recycled when the GraphicsContext3D::create()
function sees that the limit has been reached. That function still
returns null if even after recycling the number of contexts didn't
decrease.

Finally, in the GraphicsContext3D destructor, the context being
destroyed is removed from the list of active contexts.

No new tests -- relevant tests are now passing.

platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::activeContexts):
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::~GraphicsContext3D):

LayoutTests:

platform/gtk/TestExpectations: Unskip WebGL tests that were failing

due to missing active context limit management.

platform/wpe/TestExpectations: Ditto.

10:16 PM Changeset in webkit [225259] by Matt Baker

9 edits
1 add in trunk/Source/WebInspectorUI

Web Inspector: Clean up backtrace in Canvas details sidebar
https://bugs.webkit.org/show_bug.cgi?id=179807
<rdar://problem/35604378>

Reviewed by Devin Rousso.

UserInterface/Controllers/CallFrameTreeController.js: Added.

Display a list of call frames in a tree outline. Browse to the represented
call frame's source code location when a tree element is clicked or selected.

(WI.CallFrameTreeController):
(WI.CallFrameTreeController.prototype.get treeOutline):
(WI.CallFrameTreeController.prototype.get callFrames):
(WI.CallFrameTreeController.prototype.set callFrames):
(WI.CallFrameTreeController.prototype.disconnect):
(WI.CallFrameTreeController.prototype._treeElementClicked):
(WI.CallFrameTreeController.prototype._treeSelectionDidChange):
(WI.CallFrameTreeController.prototype._showSourceCodeLocation):

UserInterface/Main.html:

UserInterface/Views/CanvasDetailsSidebarPanel.css:

(.sidebar > .panel.details.canvas .details-section.canvas-backtrace .call-frame): Deleted.

UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):
(WI.CanvasDetailsSidebarPanel.prototype._refreshBacktraceSection):

UserInterface/Views/RecordingTraceDetailsSidebarPanel.css:

(.sidebar > .panel.details.recording-trace > .content > .call-frame): Deleted.

UserInterface/Views/RecordingTraceDetailsSidebarPanel.js:

(WI.RecordingTraceDetailsSidebarPanel):
(WI.RecordingTraceDetailsSidebarPanel.prototype.updateAction):

UserInterface/Views/TreeElement.js:

(WI.TreeElement.treeElementToggled):
(WI.TreeElement.prototype.selectOnMouseDown):
Prevent selection if parent tree outline is not selectable.

UserInterface/Views/TreeOutline.css:

(.tree-outline.non-selectable .item:hover):

UserInterface/Views/TreeOutline.js:

Add selectable behavior, set at construction time. When false,
clicking a tree element dispatches an event instead of selecting
the tree element. Default true.

(WI.TreeOutline):
(WI.TreeOutline.prototype.get selectable):
Dispatch click event when not selectable, and some drive-by cleanup.

10:10 PM Changeset in webkit [225258] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Web Inspector: Write script syntax tree tests for template literals and default parameter values
https://bugs.webkit.org/show_bug.cgi?id=149450
<rdar://problem/22796879>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Devin Rousso.

inspector/model/parse-script-syntax-tree-expected.txt:
inspector/model/parse-script-syntax-tree.html:

9:08 PM Changeset in webkit [225257] by commit-queue@webkit.org

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Move console Preserve Log setting from Setting tab to Console navigation bar
https://bugs.webkit.org/show_bug.cgi?id=180125

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Matt Baker.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Views/LogContentView.js:

(WI.LogContentView):
(WI.LogContentView.prototype.get navigationItems):
(WI.LogContentView.prototype._clearLogOnNavigateSettingChanged):

UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createGeneralSettingsView):

8:44 PM Changeset in webkit [225256] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove Network "Clear on load" from Settings tab now that Network tab has a toggle for it
https://bugs.webkit.org/show_bug.cgi?id=180123

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Matt Baker.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createGeneralSettingsView):

8:12 PM Changeset in webkit [225255] by Alan Bujtas

4 edits
2 adds in trunk

Clean up spanners before creating nested column context
https://bugs.webkit.org/show_bug.cgi?id=180107
<rdar://problem/35686655>

Reviewed by Antti Koivisto.

Source/WebCore:

When an existing spanner placeholder is moved into a newly constructed (and nested)
multicolumn context, we figure it's not valid anymore and end up destroying it
(see RenderMultiColumnFlow::fragmentedFlowDescendantInserted).
This is very unfortunate since as we climb back on the stack, we could hit this renderer as
the newly inserted child.

This patch proactively removes the invalid placeholders and moves the associated spanners back to their
original position.

Test: fast/multicol/crash-when-constructing-nested-columns.html

rendering/RenderMultiColumnFlow.h:
style/RenderTreeUpdaterMultiColumn.cpp:

(WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow):
RenderTreeUpdater::MultiColumn::destroyFragmentedFlow still relies on the placeholder removal
logic in RenderMultiColumnFlow::fragmentedFlowDescendantInserted.

LayoutTests:

fast/multicol/crash-when-constructing-nested-columns-expected.txt: Added.
fast/multicol/crash-when-constructing-nested-columns.html: Added.

6:59 PM Changeset in webkit [225254] by timothy_horton@apple.com

4 edits in trunk/Source/WebCore

REGRESSION (High Sierra): Layout Test fast/multicol/newmulticol/spanner2.html is a flaky image failure on WK1
https://bugs.webkit.org/show_bug.cgi?id=177826
<rdar://problem/34876498>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests, fixes some already-broken tests.

platform/graphics/mac/PDFDocumentImageMac.mm:

(WebCore::PDFDocumentImage::drawPDFPage):
Save and restore one more piece of context state that
PDFKit mutates while drawing.

Source/WebCore/PAL:

pal/spi/cg/CoreGraphicsSPI.h:

6:23 PM Changeset in webkit [225253] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

NetworkCache::Storage should protect itself when removing operations from its maps
https://bugs.webkit.org/show_bug.cgi?id=180118

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-28
Reviewed by Antti Koivisto.

The operations can contain ref to the Storage object and removing them from the map may destroy the Storage object

NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::remove):
(WebKit::NetworkCache::Storage::finishReadOperation):
(WebKit::NetworkCache::Storage::finishWriteOperation):
(WebKit::NetworkCache::Storage::traverse):

6:06 PM Changeset in webkit [225252] by Wenson Hsieh

6 edits
2 adds in trunk

Allow attachment elements with no appearance to defer rendering to child nodes
https://bugs.webkit.org/show_bug.cgi?id=180117
<rdar://problem/35735339>

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/attachment/attachment-without-appearance.html

When -webkit-appearance: none; is specified on an attachment element, allow it to fall back to rendering its
subtree. Currently, attachment elements without an appearance don't allow this and truncate the render tree at
the RenderAttachment, since RenderAttachment cannot have any children.

In a followup, this will enable us to render a shadow subtree under the attachment element to display in-place
attachment content, and easily toggle between in-place and icon display by changing the appearance.

html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::createElementRenderer):

If no appearance is specified, emit a RenderBlockFlow instead of a RenderAttachment.

(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::attachmentRenderer const):

Renamed from renderer(). HTMLAttachmentElement::renderer() now uses the superclass' implementation, and no
longer returns a RenderAttachment in all circumstances. Instead, places that expect a RenderAttachment now go
through HTMLAttachmentElement::renderAttachment() instead.

(WebCore::HTMLAttachmentElement::parseAttribute):

html/HTMLAttachmentElement.h:
page/DragController.cpp:

(WebCore::DragController::startDrag):

rendering/RenderAttachment.h:

(WebCore::HTMLAttachmentElement::renderer const): Deleted.

LayoutTests:

Adds a ref test verifying that an appearance-less attachment can render child nodes. More extensive testing to
come in a followup patch.

fast/attachment/attachment-without-appearance-expected.html: Added.
fast/attachment/attachment-without-appearance.html: Added.

5:50 PM Changeset in webkit [225251] by commit-queue@webkit.org

15 edits
1 add in trunk/Source

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-28
Reviewed by Brady Eidson.

Source/WebCore:

No change of behavior.
These changes will be covered when implementing ServiceWorker Clients API.

Registering a document when being created by DocumentLoader.
In the future, we may restrict registration to only documents related to origins that have some ongoing service worker activity.
This would require to keep track of which documents are registered so that we unregister these ones.
This would also require to register existing documents when one of the document with the same origin starts registering a service worker.
Unregistering a document inside prepareForDestruction.

Storing all clients in SWServer as a HasMap keyed by ClientOrigin.
Processing will then iterate through the list of clients scoped by the client origin.

Adding a ClientOrigin class as a pair of top origin and frame origin since service workers will be related based on that information.

WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::prepareForDestruction):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):

page/ClientOrigin.h: Added.

(WebCore::ClientOrigin::emptyKey):
(WebCore::ClientOrigin::hash const):
(WebCore::ClientOrigin::operator== const):
(WTF::ClientOriginKeyHash::hash):
(WTF::ClientOriginKeyHash::equal):
(WTF::HashTraits<WebCore::ClientOrigin>::emptyValue):
(WTF::HashTraits<WebCore::ClientOrigin>::constructDeletedValue):
(WTF::HashTraits<WebCore::ClientOrigin>::isDeletedValue):

workers/service/ServiceWorkerClientIdentifier.h:

(WebCore::ServiceWorkerClientIdentifier::operator== const):

workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::registerServiceWorkerClient):
(WebCore::SWServer::unregisterServiceWorkerClient):

workers/service/server/SWServer.h:

Source/WebKit:

Adding IPC to register/unregister clients to the storage process.
This will be used to enable service worker termination, and implementation of Clients API.

WebSWServerConnection keeps a hash map of all its related clients.
This allows unregistering these clients if the corresponding web process crashes.

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
(WebKit::WebSWServerConnection::unregisterServiceWorkerClient):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::registerServiceWorkerClient):
(WebKit::WebSWClientConnection::unregisterServiceWorkerClient):

WebProcess/Storage/WebSWClientConnection.h:

5:47 PM Changeset in webkit [225250] by commit-queue@webkit.org

10 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Add a toggle in the network tab to control automatically clearing or preserving log across loads
https://bugs.webkit.org/show_bug.cgi?id=180110
<rdar://problem/34071789>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Timothy Hatcher.

Localizations/en.lproj/localizedStrings.js:

New strings.

UserInterface/Views/CheckboxNavigationItem.css:

(.navigation-bar .item.checkbox input[type=checkbox]):
Tweak style to more center the checkbox vertically.

UserInterface/Views/CheckboxNavigationItem.js:

(WI.CheckboxNavigationItem):
Fix setting the initial value of a checkbox navigation item.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get navigationItems):
(WI.NetworkTableContentView.prototype.closed):
(WI.NetworkTableContentView.prototype._clearNetworkOnNavigateSettingChanged):
Add a new checkbox for the clear on navigation setting.

UserInterface/Views/SettingEditor.js:

(WI.SettingEditor.createForSetting):
Update the editor checkbox if the setting changes outside of the setting editor.

UserInterface/Views/NavigationItem.js:

(WI.NavigationItem.prototype.get tooltip):
(WI.NavigationItem.prototype.set tooltip):

UserInterface/Views/ActivateButtonNavigationItem.js:

(WI.ActivateButtonNavigationItem.prototype.set activated):

UserInterface/Views/ButtonNavigationItem.js:

(WI.ButtonNavigationItem):
(WI.ButtonNavigationItem.prototype.get toolTip): Deleted.
(WI.ButtonNavigationItem.prototype.set toolTip): Deleted.

UserInterface/Views/ToggleButtonNavigationItem.js:

(WI.ToggleButtonNavigationItem.prototype.set alternateToolTip):
(WI.ToggleButtonNavigationItem.prototype.set toggled):
Move tooltip to the base class and rename it from toolTip to tooltip to
match existing generic places like TreeElement.

5:33 PM Changeset in webkit [225249] by Chris Dumez

7 edits
1 copy
3 adds in trunk

ServiceWorkerGlobalScope.clients should always return the same object
https://bugs.webkit.org/show_bug.cgi?id=180116

Reviewed by Geoffrey Garen.

Source/WebCore:

ServiceWorkerGlobalScope.clients should always return the same object, as per the specification:

https://w3c.github.io/ServiceWorker/#serviceworkerglobalscope-interface

Test: http/tests/workers/service/ServiceWorkerGlobalScope_clients_SameObject.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSServiceWorkerGlobalScopeCustom.cpp: Added.

(WebCore::JSServiceWorkerGlobalScope::visitAdditionalChildren):

workers/service/ServiceWorkerClients.idl:
workers/service/ServiceWorkerGlobalScope.idl:

LayoutTests:

Add layout test coverage.

http/tests/workers/service/ServiceWorkerGlobalScope_clients_SameObject-expected.txt: Added.
http/tests/workers/service/ServiceWorkerGlobalScope_clients_SameObject.html: Added.
http/tests/workers/service/resources/ServiceWorkerGlobalScope_clients_SameObject-worker.js: Added.

4:28 PM Changeset in webkit [225248] by Chris Dumez

6 edits in trunk/Source/WebCore

Get rid of ServiceWorker::allWorkers() hashmap
https://bugs.webkit.org/show_bug.cgi?id=180111

Reviewed by Brady Eidson.

Get rid of ServiceWorker::allWorkers() hashmap as it is not thread safe and we'll soon have
ServiceWorker objects living in various service worker threads.

Instead, we now have a per-ScriptExecutionContext map, which is inherently thread-safe.

No new tests, no web-facing behavior change.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::registerServiceWorker):
(WebCore::ScriptExecutionContext::unregisterServiceWorker):

dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::serviceWorker):

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::getOrCreate):
(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::~ServiceWorker):
(WebCore::ServiceWorker::stop):

workers/service/ServiceWorker.h:
workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::updateWorkerState):

4:23 PM Changeset in webkit [225247] by Ryan Haddad

1 edit
1 copy
1 add
1 delete in trunk/LayoutTests

Unreviewed, correct the location for an expected result file.

platform/mac-elcapitan/fast/forms/alternative-presentation-button/replacement-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan/fast/alternative-presentation-button/replacement-expected.txt.

4:01 PM Changeset in webkit [225246] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Include Beacon loads in the Network Table's "Other" filter
https://bugs.webkit.org/show_bug.cgi?id=180113

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Matt Baker.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
Ensure the Other filter will handle any type that hasn't already been handled.

3:46 PM Changeset in webkit [225245] by Matt Lewis

2 edits in trunk/LayoutTests

Marked accessibility/ios-simulator/video-elements-ios.html as flaky timout.
https://bugs.webkit.org/show_bug.cgi?id=178195

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:

3:45 PM Changeset in webkit [225244] by Joseph Pecoraro

22 edits in trunk

ServiceWorker Inspector: Frontend changes to support Network tab and sub resources
https://bugs.webkit.org/show_bug.cgi?id=179642
<rdar://problem/35517704>

Reviewed by Brian Burg.

Source/WebInspectorUI:

This patch makes use of the NetworkAgent and ServiceWorker agents in the frontend
for a ServiceWorker inspection target. It also makes changes to ensure that the
subresources requested by a ServiceWorker appear as expected in both the Resources
and Network Tabs.

The backends of ServiceWorkers and DedicatedWorkers for network requests are
different, but we want the presentation to be very similiar. Ultimately we'd like
to move to more similiar backends if possible.

The first (after Inspector.enable) message a ServiceWorker inspector sends to the
backend is ServiceWorker.getInitializationInfo. This parallels a Page inspector
sending Page.getResourceTree. From the response we get enough information to
setup the MainTarget with enough information (targetId, URL) to know what its main
resource URL will be. Like DedicatedWorkers, the target's main resource will be
filled in with the first WI.Script matching the URL. With this initialization
message alone the ServiceWorker Target behaves almost identically to a Worker
target and Network loads associated with the target (by targetId) are added as
sub-resources as expected.

The biggest tension in this patch is within FrameResourceManager. The class, as
its name indicates, assumes page resources with Frames, navigation, and loader
semantics. It takes a few modifications to make it better handle resources not
associated with a Page. A follow-up will rename this to just ResourceManager as
the class' main task is now to associate Resources with Targets.

UserInterface/Base/Main.js:

(WI.loaded):
There are assumptions in a few places that the main target is a Page. Those
places can now be reached when the main target is a ServiceWorker. Add a
convenience WI.pageTarget that can be used in these places.

UserInterface/Test/Test.js:

(WI.loaded):
Add pageTarget.

UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype.scriptDidParse):
Generalize the condition so the main target can have its main resource populated.
This will be the case when a ServiceWorker is the main target and its main resource
needs to be populated from a Script.

UserInterface/Controllers/FrameResourceManager.js:

(WI.FrameResourceManager):
(WI.FrameResourceManager.prototype._processServiceWorkerInitializationInfo):
Handle ServiceWorker Resource initialization which is different from Page initialization.

(WI.FrameResourceManager.prototype._addNewResourceToFrameOrTarget):
(WI.FrameResourceManager.prototype._addResourceToTarget):
(WI.FrameResourceManager.prototype._addFrameTreeFromFrameResourceTreePayload):
Eliminate PageAgent, which might not be available in some targets.
Use pageTarget instead of mainTarget where appropriate.

UserInterface/Controllers/TargetManager.js:

(WI.TargetManager.prototype.targetForIdentifier):
A ServiceWorker is the first time that the main target has an identifier,
so let TargetManager find it by target id.

UserInterface/Models/Resource.js:

(WI.Resource):
(WI.Resource.resolvedType):
(WI.Resource.prototype.updateForResponse):
For Resource.Type.Other resources include a better type inferred from the MIME type.
ServiceWorker loads currently don't have type information and this provides a great
type for such loads. This should also provide nice types for CacheStorage.add*
populated resources which are otherwise type-less fetches.

UserInterface/Protocol/Connection.js:

Rename the class since this may no longer be a "Page".

UserInterface/Protocol/MainTarget.js:

(WI.MainTarget):
(WI.MainTarget.mainConnectionInfo):
(WI.MainTarget.prototype.get mainResource):
(WI.MainTarget.prototype.set mainResource):
(WI.MainTarget.prototype.get displayName): Deleted.

UserInterface/Protocol/Target.js:

(WI.Target.prototype.set identifier):
(WI.Target.prototype.set name):
(WI.Target.prototype.get mainResource):
(WI.Target.prototype.set mainResource):
(WI.Target.prototype.get displayName):
Give richer types for the main target. And allow a few things to be initialized
lazily, which will be necessary from an initialization message.

UserInterface/Views/NetworkTabContentView.js:

(WI.NetworkTabContentView.isTabAllowed):
Remove a PageAgent requirement for the Network tab. A ServiceWorker will not
have a PageAgent, but it will have a NetworkAgent, which should be good enough.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._populateWithInitialResourcesIfNeeded):
Initial populate should populate all subresources of all targets.

UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype.contentAvailable):
This was getting used by ResourceType.Other without warning. Make it warn.

UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype._addScript):
(WI.ResourceSidebarPanel.prototype._addTargetWithMainResource):

UserInterface/Views/ScriptTreeElement.js:

(WI.ScriptTreeElement):
Allow WorkerTreeElements for ServiceWorker targets which may also be the main target.
Also when adding such a tree element, promote the resource sidebar to a full tree
outline, and stop hiding disclosure buttons.

Source/WebInspectorUI/../../LayoutTests:

inspector/unit-tests/target-manager-expected.txt:
inspector/unit-tests/target-manager.html:

Generalize.

Source/WebInspectorUI/../JavaScriptCore:

inspector/protocol/Network.json:

Expose the NetworkAgent for a Service Worker inspector.

3:34 PM Changeset in webkit [225243] by BJ Burg

14 edits in trunk/Source/JavaScriptCore

2017-11-28 Brian Burg <BJ Burg>

[Cocoa] Clean up names of conversion methods after renaming InspectorValue to JSON::Value
https://bugs.webkit.org/show_bug.cgi?id=179696

Reviewed by Timothy Hatcher.

inspector/scripts/codegen/generate_objc_header.py:

(ObjCHeaderGenerator._generate_type_interface):

inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:

(ObjCProtocolTypesImplementationGenerator.generate_type_implementation):
(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_protocol_object):
(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_json_object): Deleted.

inspector/scripts/codegen/objc_generator.py:

(ObjCGenerator.protocol_type_for_raw_name):
(ObjCGenerator.objc_protocol_export_expression_for_variable):
(ObjCGenerator.objc_protocol_export_expression_for_variable.is):
(ObjCGenerator.objc_protocol_import_expression_for_variable):
(ObjCGenerator.objc_protocol_import_expression_for_variable.is):
(ObjCGenerator.objc_to_protocol_expression_for_member.is):
(ObjCGenerator.objc_to_protocol_expression_for_member):
(ObjCGenerator.protocol_to_objc_expression_for_member.is):
(ObjCGenerator.protocol_to_objc_expression_for_member):
(ObjCGenerator.protocol_to_objc_code_block_for_object_member):
(ObjCGenerator.objc_setter_method_for_member_internal):
(ObjCGenerator.objc_getter_method_for_member_internal):

inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:

3:11 PM Changeset in webkit [225242] by Ryan Haddad

1 edit
2 adds in trunk/LayoutTests

Rebaseline fast/forms/alternative-presentation-button/replacement.html for El Capitan.

Unreviewed test gardening.

platform/mac-elcapitan/fast/alternative-presentation-button/replacement-expected.txt: Added.

3:09 PM Changeset in webkit [225241] by commit-queue@webkit.org

13 edits
3 adds in trunk

[CG] PostScript images should be supported if they are sub-resource images
https://bugs.webkit.org/show_bug.cgi?id=178502
Source/WebCore:

<rdar://problem/35102988>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-11-28
Reviewed by Simon Fraser.

Make CachedImage detect the PostScript mime type and the file extension.
Let PDFDocumentImage replaces the PostScript data with the equivalent PDF
data and use it when creating the PDFDocument.

Test: fast/images/eps-as-image.html

WebCore.xcodeproj/project.pbxproj:
loader/cache/CachedImage.cpp:

(WebCore::CachedImage::isPDFRequest const):
(WebCore::CachedImage::isPostScriptRequest const):
These functions return whether the request is for a PDF or a PostScript
image. They check for the same conditions we do in WebPage::createPlugin().

(WebCore::CachedImage::createImage): Create a PDFDocumentImage for either
a PDF or a PostScript image. For PostScript, the data will be converted
to PDF when all the data is received.

(WebCore::CachedImage::updateBufferInternal): Use the size() of m_data
instead of using the m_image->data() to setEncodedSize(). Image::m_data
and CachedImage::m_data point to the same SharedBuffer.

(WebCore::CachedImage::convertedDataIfNeeded const): Convert the PostScript
data to PDF if the system can convert it. If the same can't convert it,
return null so loading the image will be canceled.

(WebCore::CachedImage::updateImageData): Get rid of the data argument since
we always send the member m_data to this function.

(WebCore::CachedImage::finishLoading): Convert the PostScript data to PDF
data since all the data is received. Use m_data to set setEncodedSize().

loader/cache/CachedImage.h:
platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isPostScriptMIMEType):
(WebCore::MIMETypeRegistry::isPDFOrPostScriptMIMEType):

platform/MIMETypeRegistry.h:
platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::PDFDocumentImage):
(WebCore::PDFDocumentImage::convertPostScriptDataToPDF):

platform/graphics/cg/PDFDocumentImage.h:

Source/WebKit:

<rdar://problem/35102988>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-11-28
Reviewed by Simon Fraser.

Make convertPostScriptDataToPDF() be as static function of PDFDocumentImage
in WebCore.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::convertPostScriptDataIfNeeded):
(WebKit::convertPostScriptDataToPDF): Deleted.

LayoutTests:

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-11-28
Reviewed by Simon Fraser.

TestExpectations:
fast/images/eps-as-image-expected.html: Added.
fast/images/eps-as-image.html: Added.
fast/images/resources/green-100x100.eps: Added.
platform/mac/TestExpectations:

2:39 PM Changeset in webkit [225240] by ap@apple.com

3 edits in trunk/Tools

Stop silencing leaks in TextCodecICU::registerCodecs, as the problem was fixed a while ago.
https://bugs.webkit.org/show_bug.cgi?id=118505

Reviewed by Joseph Pecoraro.

Scripts/valgrind/suppressions.txt:
Scripts/webkitpy/port/leakdetector.py:

(LeakDetector._callstacks_to_exclude_from_leaks):

1:58 PM Changeset in webkit [225239] by jfbastien@apple.com

3 edits
1 add in trunk

JavaScript rest function parameter with negative index leads to bad DFG abstract interpretation

1:43 PM Changeset in webkit [225238] by achristensen@apple.com

3 edits in trunk/Source/WebKit

Add SPI for adding strings directly to a _WKVisitedLinkStore
https://bugs.webkit.org/show_bug.cgi?id=180100

Reviewed by Geoffrey Garen.

UIProcess/API/Cocoa/_WKVisitedLinkStore.h:
UIProcess/API/Cocoa/_WKVisitedLinkStore.mm:

(-[_WKVisitedLinkStore addVisitedLinkWithString:]):
This is a performance optimization for rdar://problem/16321391

1:20 PM Changeset in webkit [225237] by dbates@webkit.org

2 edits in trunk/LayoutTests

[Cocoa] First pass at implementing alternative presentation button element
https://bugs.webkit.org/show_bug.cgi?id=179785
Part of <rdar://problem/34917108>

Update expected result.

fast/forms/alternative-presentation-button/replacement-expected.txt:

1:11 PM Changeset in webkit [225236] by Ms2ger@igalia.com

2 edits in trunk/Tools

Stop modifying self.expectations in TestExpectationLine.expected_behavior.
https://bugs.webkit.org/show_bug.cgi?id=180074

Reviewed by Simon Fraser.

In particular, getting the property multiple times on a skipped test
expectation line (which happens when using
Tools/Scripts/run-webkit-tests --print-expectations if a directory
containing multiple tests is skipped) would yield [pass, skip], then
[pass, skip, skip], then [pass, skip, skip, skip], and so on.

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationLine.expected_behavior): copy self.expectations before modifying it.

1:10 PM Changeset in webkit [225235] by dino@apple.com

3 edits
1 add in trunk/Websites/webkit.org

Include gl-matrix directly since github doesn't serve the correct mime type
https://bugs.webkit.org/show_bug.cgi?id=180102
<rdar://problem/35301622>

Reviewed by Antoine Quint.

demos/webgpu/cubes.html:
demos/webgpu/gl-matrix-min.js: Added.
demos/webgpu/simple.html:

1:02 PM Changeset in webkit [225234] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

REGRESSION: Web Inspector: context menu actions "Download Image" and "Open Image in New Window" don't work
https://bugs.webkit.org/show_bug.cgi?id=178808
<rdar://problem/35176608>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-28
Reviewed by Brian Burg.

UIProcess/mac/WKInspectorViewController.mm:

(-[WKInspectorViewController _webView:contextMenu:forElement:]):
Continue to hide the image context menu actions like we used to.
Investigating making these context menus work can be done as a
follow-up task.

UIProcess/mac/WKWebInspectorWKWebView.mm:

(-[WKWebInspectorWKWebView initWithFrame:configuration:]):
Use nullptr instead of 0.

12:54 PM Changeset in webkit [225233] by cturner@igalia.com

2 edits in trunk/LayoutTests

[GTK] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=180099

Unreviewed test gardening

platform/gtk/TestExpectations:

12:26 PM Changeset in webkit [225232] by Chris Dumez

5 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline a few skipped / flaky service worker tests

web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:

11:58 AM Changeset in webkit [225231] by BJ Burg

115 edits
3 copies
2 moves
1 add
2 deletes in trunk

Move JSONValues to WTF and convert uses of InspectorValues.h to JSONValues.h
https://bugs.webkit.org/show_bug.cgi?id=173793

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-11-14
Source/JavaScriptCore:

Reviewed by Joseph Pecoraro.

Based on patch by Brian Burg.

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
bindings/ScriptValue.cpp:

(Inspector::jsToInspectorValue):
(Inspector::toInspectorValue):
(Deprecated::ScriptValue::toInspectorValue const):

bindings/ScriptValue.h:
inspector/AsyncStackTrace.cpp:
inspector/ConsoleMessage.cpp:
inspector/ContentSearchUtilities.cpp:
inspector/DeprecatedInspectorValues.cpp: Added.
inspector/DeprecatedInspectorValues.h: Added.

Keep the old symbols around in JavaScriptCore so that builds with the
public iOS SDK continue to work. These older SDKs include a version of
WebInspector.framework that expects to find InspectorArray and other
symbols in JavaScriptCore.framework.

inspector/InjectedScript.cpp:

(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
(Inspector::InjectedScript::inspectObject):
(Inspector::InjectedScript::releaseObject):

inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeCall):
(Inspector::InjectedScriptBase::makeEvalCall):

inspector/InjectedScriptBase.h:
inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptForObjectId):

inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::CallbackBase::sendSuccess):
(Inspector::BackendDispatcher::dispatch):
(Inspector::BackendDispatcher::sendResponse):
(Inspector::BackendDispatcher::sendPendingErrors):
(Inspector::BackendDispatcher::getPropertyValue):
(Inspector::castToInteger):
(Inspector::castToNumber):
(Inspector::BackendDispatcher::getInteger):
(Inspector::BackendDispatcher::getDouble):
(Inspector::BackendDispatcher::getString):
(Inspector::BackendDispatcher::getBoolean):
(Inspector::BackendDispatcher::getObject):
(Inspector::BackendDispatcher::getArray):
(Inspector::BackendDispatcher::getValue):

inspector/InspectorBackendDispatcher.h:

We need to keep around the sendResponse() variant with a parameter that
has the InspectorObject type, as older WebInspector.framework versions
expect this symbol to exist. Introduce a variant with arity 3 that can
be used in TOT so as to avoid having two methods with the same name, arity, and
different parameter types.

When system WebInspector.framework is updated, we can remove the legacy
method variant that uses the InspectorObject type. At that point, we can
transition TOT to use the 2-arity variant, and delete the 3-arity variant
when system WebInspector.framework is updated once more to use the 2-arity one.

inspector/InspectorProtocolTypes.h:

(Inspector::Protocol::Array::openAccessors):
(Inspector::Protocol::PrimitiveBindingTraits::assertValueHasExpectedType):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::runtimeCast):
(Inspector::Protocol::BindingTraits<Protocol::Array<T>>::assertValueHasExpectedType):
(Inspector::Protocol::BindingTraits<JSON::Value>::assertValueHasExpectedType):

inspector/ScriptCallFrame.cpp:
inspector/ScriptCallStack.cpp:
inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::inspect):

inspector/agents/InspectorAgent.h:
inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::buildAssertPauseReason):
(Inspector::buildCSPViolationPauseReason):
(Inspector::InspectorDebuggerAgent::buildBreakpointPauseReason):
(Inspector::InspectorDebuggerAgent::buildExceptionPauseReason):
(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::schedulePauseOnNextStatement):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::breakProgram):

inspector/agents/InspectorDebuggerAgent.h:
inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::saveResult):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

inspector/agents/InspectorRuntimeAgent.h:
inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:

(CppBackendDispatcherHeaderGenerator._generate_dispatcher_declaration_for_command):

inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator.generate_output):
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:

(CppFrontendDispatcherHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):

inspector/scripts/codegen/generate_cpp_protocol_types_header.py:

(_generate_unchecked_setter_for_member):

inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator):

inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:

(ObjCBackendDispatcherImplementationGenerator.generate_output):
(ObjCBackendDispatcherImplementationGenerator._generate_success_block_for_command):

inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:

(ObjCFrontendDispatcherImplementationGenerator.generate_output):
(ObjCFrontendDispatcherImplementationGenerator._generate_event):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters):

inspector/scripts/codegen/generate_objc_internal_header.py:

(ObjCInternalHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:

(ObjCProtocolTypesImplementationGenerator.generate_output):

inspector/scripts/codegen/generator.py:
inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
inspector/scripts/tests/generic/expected/domain-availability.json-result:
inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
inspector/scripts/tests/generic/expected/enum-values.json-result:
inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:

Source/WebCore:

Reviewed by Joseph Pecoraro.

Based on patch by Brian Burg.

ForwardingHeaders/inspector/InspectorValues.h: Removed.
Modules/encryptedmedia/InitDataRegistry.cpp:

(WebCore::extractKeyIDsKeyids):
(WebCore::sanitizeKeyids):

html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::generateViolationReport):

inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::inspect):

inspector/CommandLineAPIHost.h:
inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseData):
(WebCore::InspectorCanvas::indexForData):
(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):
(WebCore::InspectorCanvas::buildArrayForImageData):
(WebCore::InspectorCanvas::buildArrayForImageBitmap):

inspector/InspectorCanvas.h:
inspector/InspectorDatabaseResource.cpp:
inspector/InspectorOverlay.cpp:

(WebCore::evaluateCommandInOverlay):
(WebCore::InspectorOverlay::evaluateInOverlay):

inspector/InspectorOverlay.h:
inspector/InspectorShaderProgram.h:
inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId):

inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createConsoleProfileData):
(WebCore::TimelineRecordFactory::createProbeSampleData):
(WebCore::TimelineRecordFactory::createEventDispatchData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createTimeStampData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::createQuad):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):

inspector/TimelineRecordFactory.h:
inspector/agents/InspectorApplicationCacheAgent.cpp:
inspector/agents/InspectorApplicationCacheAgent.h:
inspector/agents/InspectorCSSAgent.cpp:

(WebCore::computePseudoClassMask):
(WebCore::InspectorCSSAgent::setStyleText):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::forcePseudoState):

inspector/agents/InspectorCSSAgent.h:
inspector/agents/InspectorDOMAgent.cpp:

(WebCore::parseColor):
(WebCore::parseConfigColor):
(WebCore::parseQuad):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::setInspectModeEnabled):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
(WebCore::InspectorDOMAgent::highlightSelector):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightNodeList):
(WebCore::InspectorDOMAgent::highlightFrame):

inspector/agents/InspectorDOMAgent.h:
inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::didInvalidateStyleAttr):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest):

inspector/agents/InspectorDOMDebuggerAgent.h:
inspector/agents/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::findStorageArea):

inspector/agents/InspectorDOMStorageAgent.h:
inspector/agents/InspectorDatabaseAgent.cpp:
inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::Inspector::idbKeyFromInspectorObject):
(WebCore::Inspector::idbKeyRangeFromKeyRange):
(WebCore::InspectorIndexedDBAgent::requestData):

inspector/agents/InspectorIndexedDBAgent.h:
inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::buildObjectForHeaders):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::setExtraHTTPHeaders):

inspector/agents/InspectorNetworkAgent.h:
inspector/agents/InspectorPageAgent.cpp:
inspector/agents/InspectorPageAgent.h:
inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::setInstruments):
(WebCore::InspectorTimelineAgent::internalStart):
(WebCore::InspectorTimelineAgent::didInvalidateLayout):
(WebCore::InspectorTimelineAgent::willLayout):
(WebCore::InspectorTimelineAgent::didScheduleStyleRecalculation):
(WebCore::InspectorTimelineAgent::willRecalculateStyle):
(WebCore::InspectorTimelineAgent::willComposite):
(WebCore::InspectorTimelineAgent::willPaint):
(WebCore::InspectorTimelineAgent::addRecordToTimeline):
(WebCore::InspectorTimelineAgent::setFrameIdentifier):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::sendEvent):
(WebCore::InspectorTimelineAgent::createRecordEntry):
(WebCore::InspectorTimelineAgent::pushCurrentRecord):

inspector/agents/InspectorTimelineAgent.h:
page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):

platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::parseJSONObject):
(WebCore::parseLicenseFormat):
(WebCore::parseLicenseReleaseAcknowledgementFormat):
(WebCore::CDMInstanceClearKey::updateLicense):
(WebCore::CDMInstanceClearKey::removeSessionData):

platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::extractSinfData):

testing/Internals.cpp:

Source/WebDriver:

Reviewed by Joseph Pecoraro.

CMakeLists.txt:
CommandResult.cpp:

(WebDriver::CommandResult::CommandResult):

CommandResult.h:

(WebDriver::CommandResult::success):
(WebDriver::CommandResult::fail):
(WebDriver::CommandResult::result const):
(WebDriver::CommandResult::setAdditionalErrorData):
(WebDriver::CommandResult::additionalErrorData const):

Session.cpp:

(WebDriver::firstWindowHandleInResult):
(WebDriver::Session::handleUserPrompts):
(WebDriver::Session::reportUnexpectedAlertOpen):
(WebDriver::Session::go):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::getTitle):
(WebDriver::Session::getWindowHandle):
(WebDriver::Session::closeTopLevelBrowsingContext):
(WebDriver::Session::switchToWindow):
(WebDriver::Session::getWindowHandles):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::getToplevelBrowsingContextRect):
(WebDriver::Session::moveToplevelBrowsingContextWindow):
(WebDriver::Session::resizeToplevelBrowsingContextWindow):
(WebDriver::Session::createElement):
(WebDriver::Session::extractElement):
(WebDriver::Session::extractElementID):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::selectOptionElement):
(WebDriver::Session::elementClick):
(WebDriver::Session::elementClear):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::elementSubmit):
(WebDriver::Session::handleScriptResult):
(WebDriver::Session::executeScript):
(WebDriver::Session::performMouseInteraction):
(WebDriver::Session::performKeyboardInteractions):
(WebDriver::parseAutomationCookie):
(WebDriver::builtAutomationCookie):
(WebDriver::serializeCookie):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
(WebDriver::Session::takeScreenshot):

Session.h:
SessionHost.cpp:

(WebDriver::SessionHost::sendCommandToBackend):
(WebDriver::SessionHost::dispatchMessage):

SessionHost.h:
WebDriverService.cpp:

(WebDriver::WebDriverService::handleRequest):
(WebDriver::WebDriverService::sendResponse const):
(WebDriver::deserializeTimeouts):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::findSessionOrCompleteWithError):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::mergeCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):
(WebDriver::WebDriverService::newSession):
(WebDriver::WebDriverService::deleteSession):
(WebDriver::WebDriverService::setTimeouts):
(WebDriver::WebDriverService::go):
(WebDriver::WebDriverService::getCurrentURL):
(WebDriver::WebDriverService::back):
(WebDriver::WebDriverService::forward):
(WebDriver::WebDriverService::refresh):
(WebDriver::WebDriverService::getTitle):
(WebDriver::WebDriverService::getWindowHandle):
(WebDriver::WebDriverService::getWindowRect):
(WebDriver::valueAsNumberInRange):
(WebDriver::WebDriverService::setWindowRect):
(WebDriver::WebDriverService::closeWindow):
(WebDriver::WebDriverService::switchToWindow):
(WebDriver::WebDriverService::getWindowHandles):
(WebDriver::WebDriverService::switchToFrame):
(WebDriver::WebDriverService::switchToParentFrame):
(WebDriver::findElementOrCompleteWithError):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::WebDriverService::findElement):
(WebDriver::WebDriverService::findElements):
(WebDriver::WebDriverService::findElementFromElement):
(WebDriver::WebDriverService::findElementsFromElement):
(WebDriver::WebDriverService::isElementSelected):
(WebDriver::WebDriverService::getElementAttribute):
(WebDriver::WebDriverService::getElementText):
(WebDriver::WebDriverService::getElementTagName):
(WebDriver::WebDriverService::getElementRect):
(WebDriver::WebDriverService::isElementEnabled):
(WebDriver::WebDriverService::isElementDisplayed):
(WebDriver::WebDriverService::elementClick):
(WebDriver::WebDriverService::elementClear):
(WebDriver::WebDriverService::elementSendKeys):
(WebDriver::WebDriverService::elementSubmit):
(WebDriver::findScriptAndArgumentsOrCompleteWithError):
(WebDriver::WebDriverService::executeScript):
(WebDriver::WebDriverService::executeAsyncScript):
(WebDriver::WebDriverService::getAllCookies):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::WebDriverService::deleteAllCookies):
(WebDriver::WebDriverService::dismissAlert):
(WebDriver::WebDriverService::acceptAlert):
(WebDriver::WebDriverService::getAlertText):
(WebDriver::WebDriverService::sendAlertText):
(WebDriver::WebDriverService::takeScreenshot):
(WebDriver::WebDriverService::takeElementScreenshot):

WebDriverService.h:
gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformMatchCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformMatchCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

Source/WebKit:

Reviewed by Joseph Pecocaro.

Based on patch by Brian Burg.

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::resizeWindowOfBrowsingContext):
(WebKit::WebAutomationSession::moveWindowOfBrowsingContext):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnPage):
(WebKit::WebAutomationSession::waitForNavigationToCompleteOnFrame):
(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout):
(WebKit::WebAutomationSession::navigationOccurredForFrame):
(WebKit::WebAutomationSession::documentLoadedForFrame):
(WebKit::WebAutomationSession::inspectorFrontendLoaded):
(WebKit::WebAutomationSession::keyboardEventsFlushedForPage):
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
(WebKit::WebAutomationSession::setFilesToSelectForFileUpload):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):

UIProcess/Automation/WebAutomationSession.h:

Source/WTF:

Reviewed by Joseph Pecoraro.

Based on patch by Brian Burg.

Move the implementation into WTF. Put the actual implementation inside
namespace WTF::JSONImpl so that the symbols in libwtf start with the WTF prefix.
Also provide a top-level JSON namespace so that clients can write JSON::Value.
This is essentially a typedef for the entire WTF::JSONImpl namespace.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/JSONValues.cpp: Renamed from Source/JavaScriptCore/inspector/InspectorValues.cpp.

(JSON::Value::null):
(JSON::Value::create):
(JSON::Value::asValue):
(JSON::Value::asObject):
(JSON::Value::asArray):
(JSON::Value::parseJSON):
(JSON::Value::toJSONString const):
(JSON::Value::asBoolean const):
(JSON::Value::asDouble const):
(JSON::Value::asInteger const):
(JSON::Value::asString const):
(JSON::Value::writeJSON const):
(JSON::Value::memoryCost const):
(JSON::ObjectBase::~ObjectBase):
(JSON::ObjectBase::asObject):
(JSON::ObjectBase::openAccessors):
(JSON::ObjectBase::memoryCost const):
(JSON::ObjectBase::getBoolean const):
(JSON::ObjectBase::getString const):
(JSON::ObjectBase::getObject const):
(JSON::ObjectBase::getArray const):
(JSON::ObjectBase::getValue const):
(JSON::ObjectBase::remove):
(JSON::ObjectBase::writeJSON const):
(JSON::ObjectBase::ObjectBase):
(JSON::ArrayBase::~ArrayBase):
(JSON::ArrayBase::asArray):
(JSON::ArrayBase::writeJSON const):
(JSON::ArrayBase::ArrayBase):
(JSON::ArrayBase::get const):
(JSON::Object::create):
(JSON::Array::create):
(JSON::ArrayBase::memoryCost const):

wtf/JSONValues.h: Renamed from Source/JavaScriptCore/inspector/InspectorValues.h.

(JSON::ObjectBase::find):
(JSON::ObjectBase::find const):
(JSON::ObjectBase::setBoolean):
(JSON::ObjectBase::setInteger):
(JSON::ObjectBase::setDouble):
(JSON::ObjectBase::setString):
(JSON::ObjectBase::setValue):
(JSON::ObjectBase::setObject):
(JSON::ObjectBase::setArray):
(JSON::ArrayBase::pushBoolean):
(JSON::ArrayBase::pushInteger):
(JSON::ArrayBase::pushDouble):
(JSON::ArrayBase::pushString):
(JSON::ArrayBase::pushValue):
(JSON::ArrayBase::pushObject):
(JSON::ArrayBase::pushArray):

Tools:

Reviewed by Joseph Pecoraro.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/PlatformGTK.cmake:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/JSONValue.cpp: Renamed from Tools/TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp.

(TestWebKitAPI::TEST):

11:17 AM Changeset in webkit [225230] by Ryan Haddad

2 edits in trunk/Tools

Bugs filed from the flakiness dashboard should include a link to the dashboard
https://bugs.webkit.org/show_bug.cgi?id=180090

Reviewed by Aakash Jain.

TestResultServer/static-dashboards/flakiness_dashboard.js:

(createBugHTML):
Open the bug compose page in a new tab and include a link
to the flakiness dashboard results for the selected test.

11:10 AM Changeset in webkit [225229] by Jonathan Bedard

12 edits in trunk/Tools

webkitpy: Standardize Version representation
https://bugs.webkit.org/show_bug.cgi?id=179677
<rdar://problem/35711277>

Reviewed by Alex Christensen.

Standardize a single method of representing versions in the Version object
constructor. Provide static methods for converting string and lists/tuples
to Version objects.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init): Parse Version object from string instead of using
the constructor.
(PlatformInfo.xcode_sdk_version): Ditto.
(PlatformInfo.xcode_version): Ditto.
(PlatformInfo._win_version): Construct Version object from list.

Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.xcode_sdk_version):
(MockPlatformInfo.xcode_version):

Scripts/webkitpy/common/version.py:

(Version):
(Version.from_string): Parse string of the form 'x.x.x'.
(Version.from_iterable): Construct a version object from a list, tuple or
other indexable object.
(Version.init): Construct a Version object from integers.

Scripts/webkitpy/common/version_name_map.py:

(VersionNameMap.init): Use integer Version constructor.
(VersionNameMap._automap_to_major_version): Ditto.
(VersionNameMap.to_name):
(VersionNameMap.strip_name_formatting): Construct Version from string.

Scripts/webkitpy/common/version_name_map_unittest.py:

(VersionMapTestCase.test_mac_version_by_name): Use integer Version constructor.
(VersionMapTestCase.test_mac_name_by_version): Ditto.
(VersionMapTestCase.test_ios_name_by_version): Ditto.

Scripts/webkitpy/common/version_unittest.py:

(VersionTestCase.test_string_constructor):
(VersionTestCase.test_from_list):
(VersionTestCase.test_from_tuple):
(VersionTestCase.test_int_constructor):
(VersionTestCase.test_len):
(VersionTestCase.test_set_by_int):
(VersionTestCase.test_set_by_string):
(VersionTestCase.test_get_by_int):
(VersionTestCase.test_get_by_string):
(VersionTestCase.test_string):
(VersionTestCase.test_contained_in):
(VersionTestCase.test_compare_versions):
(VersionTestCase.test_list_constructor): Deleted.
(VersionTestCase.test_tuple_constructor): Deleted.
(VersionTestCase.test_copy_constructor): Deleted.
(VersionTestCase.test_none_constructor): Deleted.

Scripts/webkitpy/port/ios.py:

(IOSPort.default_baseline_search_path): Handle case where ios_version is None.

Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.ios_version): Return None rather than an empty version.

Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort.simulator_runtime): Parse Version object from string instead
of using the constructor.
(IOSSimulatorPort.ios_version): Return None rather than an empty version.

Scripts/webkitpy/xcode/simulator.py:

(Simulator._parse_runtimes): Parse Version object from string instead of using
the constructor.
(Simulator._parse_devices): Ditto.

Scripts/webkitpy/xcode/simulator_unittest.py:

10:56 AM Changeset in webkit [225228] by Ryan Haddad

6 edits
3 adds in trunk/LayoutTests

[iOS] Rebaseline editing/execCommand tests
https://bugs.webkit.org/show_bug.cgi?id=180085

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/ios-wk2/editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
platform/ios-wk2/editing/execCommand/indent-pre-expected.txt: Added.
platform/ios-wk2/editing/execCommand/selectAll-expected.txt: Added.
platform/ios/editing/execCommand/create-list-with-hr-expected.txt:
platform/ios/editing/execCommand/indent-selection-expected.txt:
platform/ios/editing/execCommand/insert-list-and-stitch-expected.txt:
platform/ios/editing/execCommand/nsresponder-indent-expected.txt:

10:54 AM Changeset in webkit [225227] by Simon Fraser

6 edits in trunk/Source/WebCore

Use the TextStream indent manipulator in more places
https://bugs.webkit.org/show_bug.cgi?id=180065

Reviewed by Sam Weinig.

Replace writeIndent() with << indent, and use an IndentScope in a few places.

dom/ViewportArguments.cpp:

(WebCore::operator<<):

page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::dumpProperties const):

page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::dump const):

platform/graphics/FloatRoundedRect.cpp:

(WebCore::operator<<):

platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::operator<<):

10:50 AM Changeset in webkit [225226] by commit-queue@webkit.org

5 edits in trunk

Web Audio's AnalyserNode.fftSize cannot be greater than 2048 in Safari; spec says it can be up to 32768
https://bugs.webkit.org/show_bug.cgi?id=180040

Patch by Noah Chase <nchase@gmail.com> on 2017-11-28
Reviewed by Alex Christensen.

Source/WebCore:

I fixed up the existing test/output for realtimeanalyser-fft-sizing.
one thing that I'm a bit unsure of here is whether or not there are other
places in WebKit's Web Audio implementation that use fftSize and
should have the wider range available (instead of capping out at
2048). based on a quick naive scan I think that there are.

Modules/webaudio/RealtimeAnalyser.cpp:

LayoutTests:

webaudio/realtimeanalyser-fft-sizing-expected.txt:
webaudio/realtimeanalyser-fft-sizing.html:

10:34 AM Changeset in webkit [225225] by Ms2ger@igalia.com

2 edits in trunk/LayoutTests

[WPE] Enable the wpt top-level directory.
https://bugs.webkit.org/show_bug.cgi?id=180088

Unreviewed test gardening.

This does not change the output of Tools/Scripts/run-webkit-tests --print-expectations.

platform/wpe/TestExpectations:

10:33 AM Changeset in webkit [225224] by dbates@webkit.org

2 edits in trunk/Source/WebCore

[Cocoa] First pass at implementing alternative presentation button element
https://bugs.webkit.org/show_bug.cgi?id=179785
Part of <rdar://problem/34917108>

Reviewed by Brent Fulgham.

Implement support for substituting a button for one or more elements in a page.
This is a first pass. We will refine the logic and the API/SPI in subsequent
commits.

Tests: accessibility/alternative-presentation-button-input-type.html

accessibility/alternative-presentation-button.html
fast/forms/alternative-presentation-button/replace-and-remove.html
fast/forms/alternative-presentation-button/replacement.html

English.lproj/Localizable.strings: Add placeholder strings for localization.
SourcesCocoa.txt: Add some files.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/Element.h:
editing/Editor.cpp:

(WebCore::Editor::clear): Clear out all substitutions. This is called whenever
we are navigating between pages.
(WebCore::Editor::substituteWithAlternativePresentationButton): Added.
(WebCore::Editor::removeAlternativePresentationButton): Added.
(WebCore::Editor::didInsertAlternativePresentationButtonElement): Added.
(WebCore::Editor::didRemoveAlternativePresentationButtonElement): Added.

editing/Editor.h:
editing/cocoa/AlternativePresentationButtonSubstitution.cpp: Added.

(WebCore::AlternativePresentationButtonSubstitution::AlternativePresentationButtonSubstitution):
(WebCore::AlternativePresentationButtonSubstitution::initializeSavedDisplayStyles):
(WebCore::AlternativePresentationButtonSubstitution::apply):
(WebCore::AlternativePresentationButtonSubstitution::unapply):

editing/cocoa/AlternativePresentationButtonSubstitution.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::alternativePresentationButtonElement const): Added.
(WebCore::HTMLInputElement::setTypeWithoutUpdatingAttribute): Added.
(WebCore::HTMLInputElement::createInputType): Extracted the logic to create the InputType from
HTMLInputElement::updateType() to here and added logic to create the input type for the
alternative presentation button. This input type is not web exposed.
(WebCore::HTMLInputElement::updateType): Modified to take the name of the InputType object to
create as an argument and pass it through to HTMLInputElement::createInputType() to actually
create it. Reordered the logic for destroying the shadow tree of the old InputType, deallocating
the old InputType, and assigning the new InputType such that we assign the new InputType,
destroy the shadow tree of the old InputType, and deallocate the old InputType. This ordering
allows AlternativePresentationButtonSubstitution::substitute() to avoid restoring the input
type saved before the substitution when the input type is changed by the page as opposed to
by SPI.
(WebCore::HTMLInputElement::parseAttribute): Pass the parsed type.
(WebCore::HTMLInputElement::willAttachRenderers): Ditto.

html/HTMLInputElement.h: Change visibility of removeShadowRoot() from private to public so

that it can be called from AlternativePresentationButtonSubstitution.

html/InputType.h:

(WebCore::InputType::alternativePresentationButtonElement const): Added.

html/InputTypeNames.cpp:

(WebCore::InputTypeNames::alternativePresentationButton): Added.

html/InputTypeNames.h:
html/shadow/cocoa/AlternativePresentationButtonElement.cpp: Added.

(WebCore::AlternativePresentationButtonElement::create):
(WebCore::AlternativePresentationButtonElement::AlternativePresentationButtonElement):
(WebCore::AlternativePresentationButtonElement::insertedIntoAncestor):
(WebCore::AlternativePresentationButtonElement::removedFromAncestor):
(WebCore::AlternativePresentationButtonElement::didFinishInsertingNode):
(WebCore::AlternativePresentationButtonElement::defaultEventHandler):

html/shadow/cocoa/AlternativePresentationButtonElement.h:
html/shadow/cocoa/AlternativePresentationButtonInputType.cpp: Added.

(WebCore::AlternativePresentationButtonInputType::AlternativePresentationButtonInputType):
(WebCore::AlternativePresentationButtonInputType::formControlType const):
(WebCore::AlternativePresentationButtonInputType::appendFormData const):
(WebCore::AlternativePresentationButtonInputType::supportsValidation const):
(WebCore::AlternativePresentationButtonInputType::isTextButton const):
(WebCore::AlternativePresentationButtonInputType::alternativePresentationButtonElement const):
(WebCore::AlternativePresentationButtonInputType::createShadowSubtree):
(WebCore::AlternativePresentationButtonInputType::destroyShadowSubtree):

html/shadow/cocoa/AlternativePresentationButtonInputType.h:
page/ChromeClient.h:
platform/LocalizedStrings.cpp:

(WebCore::AXAlternativePresentationButtonLabel):
(WebCore::alternativePresentationButtonTitle):
(WebCore::alternativePresentationButtonSubtitle):

platform/LocalizedStrings.h:
testing/Internals.cpp:

(WebCore::Internals::substituteWithAlternativePresentationButton): Added.
(WebCore::Internals::removeAlternativePresentationButton): Added.

testing/Internals.h:
testing/Internals.idl:

10:31 AM Changeset in webkit [225223] by dbates@webkit.org

45 edits
3 copies
16 adds in trunk

[Cocoa] First pass at implementing alternative presentation button element
https://bugs.webkit.org/show_bug.cgi?id=179785
Part of <rdar://problem/34917108>

Reviewed by Brent Fulgham.

Source/WebCore:

Implement support for substituting a button for one or more elements in a page.
This is a first pass. We will refine the logic and the API/SPI in subsequent
commits.

Tests: accessibility/alternative-presentation-button-input-type.html

accessibility/alternative-presentation-button.html
fast/forms/alternative-presentation-button/replace-and-remove.html
fast/forms/alternative-presentation-button/replacement.html

English.lproj/Localizable.strings: Add placeholder strings for localization.
SourcesCocoa.txt: Add some files.
WebCore.xcodeproj/project.pbxproj: Ditto.
dom/Element.h:
editing/Editor.cpp:

editing/Editor.h:
editing/cocoa/AlternativePresentationButtonSubstitution.cpp: Added.

editing/cocoa/AlternativePresentationButtonSubstitution.h:
html/HTMLInputElement.cpp:

html/HTMLInputElement.h: Change visibility of removeShadowRoot() from private to public so

that it can be called from AlternativePresentationButtonSubstitution.

html/InputType.h:

(WebCore::InputType::alternativePresentationButtonElement const): Added.

html/InputTypeNames.cpp:

(WebCore::InputTypeNames::alternativePresentationButton): Added.

html/InputTypeNames.h:
html/shadow/cocoa/AlternativePresentationButtonElement.cpp: Added.

html/shadow/cocoa/AlternativePresentationButtonElement.h:
html/shadow/cocoa/AlternativePresentationButtonInputType.cpp: Added.

html/shadow/cocoa/AlternativePresentationButtonInputType.h:
page/ChromeClient.h:
platform/LocalizedStrings.cpp:

(WebCore::AXAlternativePresentationButtonLabel):
(WebCore::alternativePresentationButtonTitle):
(WebCore::alternativePresentationButtonSubtitle):

platform/LocalizedStrings.h:
testing/Internals.cpp:

(WebCore::Internals::substituteWithAlternativePresentationButton): Added.
(WebCore::Internals::removeAlternativePresentationButton): Added.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

Expose SPI to substitute the alternative presentation button for one or more elements
and remove the alternative presentation button. Add a private delegate callback when
the alternative presentation button is clicked.

UIProcess/API/APIUIClient.h:

(API::UIClient::didClickAlternativePresentationButton): Added.

UIProcess/API/C/WKPageUIClient.h:
UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/Cocoa/UIDelegate.h:
UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate): Wired up delegate callback.
(WebKit::UIDelegate::UIClient::didClickAlternativePresentationButton): Added.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleAlternativePresentationButtonClick): Added.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:

(API::InjectedBundle::PageUIClient::didClickAlternativePresentationButton): Added.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame substituteElements:withAlternativePresentationButtonWithIdentifier:]): Added.
(-[WKWebProcessPlugInFrame removeAlternativePresentationButton:]): Added.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleSubstituteWithAlternativePresentationButton): Added.
(WKBundleRemoveAlternativePresentationButton): Added.

WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::didClickAlternativePresentationButton): Added.

WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::handleAlternativePresentationButtonClick): Added.

WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

Add a test that substitutes the alternative presentation button for an element in
the page and clicks it.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add test.
TestWebKitAPI/Tests/WebKitCocoa/ClickAlternativePresentationButton.mm: Added.

(didClickAlternativePresentationButton):
(-[ClickAlternativePresentationButton webProcessPlugIn:didCreateBrowserContextController:]):

TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(TEST):
(-[AlternativePresentationButtonDelegate _webView:didClickAlternativePresentationButtonWithUserInfo:]):
(-[AlternativePresentationButtonDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):

LayoutTests:

Adds tests to ensure that we can apply and remove the substitution of one or more
elements with the alternative presentation button.

Also added some accessibility tests to ensure that the alternative presentation button
can be seen and hit tested by the accessibility machinery. When the alternative presentation
button is substituted for an <input> it masquerades as a text button and when it is
substituted for an arbitrary HTML element it masquerades as the original element. As a
result the accessibility machinery shows an empty role description in the former case
because it does find the ARIA label for the button and the accessibility element hierarchy
may be incorrect in the latter case. We will fix these issues in a subsequent commit(s).

TestExpectations: Skip the test on all platforms. We will selectively enable

tests on Cocoa platforms (below).

accessibility/alternative-presentation-button-expected.txt: Added.
accessibility/alternative-presentation-button-input-type-expected.txt: Added.
accessibility/alternative-presentation-button-input-type.html: Added.
accessibility/alternative-presentation-button.html: Added.
fast/forms/alternative-presentation-button/replace-and-remove-expected.html: Added.
fast/forms/alternative-presentation-button/replace-and-remove.html: Added.
fast/forms/alternative-presentation-button/replacement-expected.txt: Added.
fast/forms/alternative-presentation-button/replacement.html: Added.
platform/ios/TestExpectations: Mark tests as PASS so that we run them.
platform/ios/fast/forms/alternative-presentation-button/replacement-expected.txt: Added.
platform/mac/TestExpectations: Mark tests as PASS so that we run them.

10:28 AM Changeset in webkit [225222] by commit-queue@webkit.org

4 edits
2 deletes in trunk

Unreviewed, rolling out r225209.
https://bugs.webkit.org/show_bug.cgi?id=180092

Tests are still timing out (Requested by ap on #webkit).

Reverted changeset:

"Pressing the space bar while watching a fullscreen video
doesn't play or pause"
https://bugs.webkit.org/show_bug.cgi?id=180033
https://trac.webkit.org/changeset/225209

10:22 AM Changeset in webkit [225221] by Chris Dumez

10 edits
1 copy
3 adds in trunk

Start exposing navigator.serviceWorker inside service workers
https://bugs.webkit.org/show_bug.cgi?id=180087

Reviewed by Brady Eidson.

Source/WebCore:

Start exposing navigator.serviceWorker inside service workers as per:

https://w3c.github.io/ServiceWorker/#navigator-serviceworker

Although the property is now exposed, the API on ServiceWorkerContainer is not
supported yet inside service workers and the promise will be rejected. This will
be implemented in a follow-up.

Test: http/tests/workers/service/WorkerNavigator_serviceWorker.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSWorkerNavigatorCustom.cpp: Added.

(WebCore::JSWorkerNavigator::visitAdditionalChildren):

page/WorkerNavigator.idl:
workers/service/ServiceWorker.idl:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::controller const):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):

workers/service/ServiceWorkerContainer.idl:
workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):

workers/service/ServiceWorkerRegistration.idl:

LayoutTests:

Add layout test coverage.

http/tests/workers/service/WorkerNavigator_serviceWorker-expected.txt: Added.
http/tests/workers/service/WorkerNavigator_serviceWorker.html: Added.
http/tests/workers/service/resources/WorkerNavigator_serviceWorker-worker.js: Added.

9:39 AM Changeset in webkit [225220] by Simon Fraser

7 edits in trunk/Source

Modernize GraphicsLayer dumping
https://bugs.webkit.org/show_bug.cgi?id=180067

Reviewed by Sam Weinig.
Source/WebCore:

Use the indent stream manipulator, and TextStream's built-in indent amount
for GraphicsLayer dumping.

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpLayer const):
(WebCore::dumpChildren):
(WebCore::GraphicsLayer::dumpProperties const):
(WebCore::GraphicsLayer::layerTreeAsText const):

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::dumpAdditionalProperties const):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::dumpInnerLayer):
(WebCore::GraphicsLayerCA::dumpAdditionalProperties const):

platform/graphics/ca/GraphicsLayerCA.h:

Source/WTF:

Expose the current indent.

wtf/text/TextStream.h:

(WTF::TextStream::indent const):

8:41 AM Changeset in webkit [225219] by Michael Catanzaro

4 edits in trunk

REGRESSION(r225098): [WPE] Some features have changed of value (70 new failures)
https://bugs.webkit.org/show_bug.cgi?id=180004

Reviewed by Alex Christensen.

Turn on ENABLE_ENCRYPTED_MEDIA and ENABLE_WEBGL2 when building with
ENABLE_EXPERIMENTAL_FEATURES. Also, let's stop turning off ENABLE_USERSELECT_ALL, as I doubt
there's any good reason for that.

Source/cmake/OptionsWPE.cmake:

LayoutTests:

Remove failure expectations for layout tests that will stop failing once the buildbot master
is restarted. A restart is required for the build to begin using
-DENABLE_EXPERIMENTAL_FEATURES=ON.

platform/wpe/TestExpectations:

8:30 AM Changeset in webkit [225218] by Carlos Garcia Campos

2 edits
1 add in trunk/Tools

REGRESSION(r225166): [GTK] Skipped unit tests are considered failures after glib upgrade
https://bugs.webkit.org/show_bug.cgi?id=180072

Reviewed by Michael Catanzaro.

This is a bug in GLib that has already been fixed. Backport the patch to fix it until there's a new GLib release
we can depend on.

gtk/jhbuild.modules:
gtk/patches/glib-gtester-do-not-consider-skipped-tests-as-failures.patch: Added.

7:13 AM Changeset in webkit [225217] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove dead debugging code in modern media controls
https://bugs.webkit.org/show_bug.cgi?id=180079

Patch by Antoine Quint <Antoine Quint> on 2017-11-28
Reviewed by Eric Carlson.

This debug utility is no longer necessary and is just dead code.

Modules/modern-media-controls/controls/scheduler.js:

(const.scheduler.new.prototype.scheduleLayout):
(const.scheduler.new.prototype.unscheduleLayout):
(const.scheduler.new.prototype._requestFrameIfNeeded):
(const.scheduler.new.prototype._frameDidFire):
(const.scheduler.new.prototype._layout):

7:01 AM Changeset in webkit [225216] by commit-queue@webkit.org

6 edits
3 adds in trunk

Skip back and forward buttons should not hard-code their numeric amount in localised strings
https://bugs.webkit.org/show_bug.cgi?id=180077

Patch by Antoine Quint <Antoine Quint> on 2017-11-28
Reviewed by Eric Carlson.

Source/WebCore:

Split out the numeric value used in the skip forward and skip back localized strings to make
it easier to localized the numeric value itself.

Test: media/modern-media-controls/localized-strings/replaced-string.html

English.lproj/modern-media-controls-localized-strings.js:
Modules/modern-media-controls/main.js:

(UIString):

LayoutTests:

Add a new test to check replaced localized string work as expected.

media/modern-media-controls/localized-strings/replaced-string-expected.txt: Added.
media/modern-media-controls/localized-strings/replaced-string.html: Added.
platform/ios-simulator/TestExpectations:
platform/mac/TestExpectations:

6:43 AM Changeset in webkit [225215] by commit-queue@webkit.org

2 edits in trunk/Tools

webkitpy: PlatformInfo raises AssertionError "assert self.os_version is not None" in Cygwin since Bug 179621
https://bugs.webkit.org/show_bug.cgi?id=180069

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-28
Reviewed by Daniel Bates.

"Version 10.0.16299" was interpreted as 0.0.16299. Fix the wrong
regexp for 'ver' command.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo._win_version_from_cmd): Replace \d with \d+.

5:23 AM Changeset in webkit [225214] by Carlos Garcia Campos

2 edits in trunk/Tools

[GTK] WebDriver: disable XSS auditor when running WebDriver tests
https://bugs.webkit.org/show_bug.cgi?id=180075

Reviewed by Carlos Alberto Lopez Perez.

Some tests are now doing inline('<script>window.alert()</script>') which is rejected by the XSS auditor because
the script source is part of the request URL.

Scripts/webkitpy/webdriver_tests/webdriver_driver_gtk.py:

(WebDriverGtk.capabilities): Disable XSS auditor.

5:15 AM Changeset in webkit [225213] by Carlos Garcia Campos

19 edits
9 adds
1 delete in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

imported/w3c/importer.json:
imported/w3c/tools/webdriver/webdriver/client.py:
imported/w3c/tools/webdriver/webdriver/error.py:
imported/w3c/tools/wptrunner/docs/conf.py:
imported/w3c/tools/wptrunner/wptrunner/browsers/ie.py:
imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
imported/w3c/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py:
imported/w3c/tools/wptrunner/wptrunner/stability.py:
imported/w3c/tools/wptrunner/wptrunner/testdriver-vendor.js: Added.
imported/w3c/tools/wptrunner/wptrunner/update/sync.py:
imported/w3c/tools/wptrunner/wptrunner/wptcommandline.py:
imported/w3c/webdriver/interface/interface.html:
imported/w3c/webdriver/tests/document_handling/page_source.py: Added.
imported/w3c/webdriver/tests/element_click/bubbling.py: Added.
imported/w3c/webdriver/tests/element_retrieval/get_active_element.py:
imported/w3c/webdriver/tests/execute_async_script/user_prompts.py: Added.
imported/w3c/webdriver/tests/execute_script/user_prompts.py: Added.
imported/w3c/webdriver/tests/sessions/status.py: Added.
imported/w3c/webdriver/tests/status.py: Removed.
imported/w3c/webdriver/tests/support/fixtures.py:
imported/w3c/webdriver/tests/support/wait.py:
imported/w3c/webdriver/tests/user_prompts/accept_alert.py:
imported/w3c/webdriver/tests/user_prompts/dismiss_alert.py:
imported/w3c/webdriver/tests/user_prompts/get_alert_text.py:
imported/w3c/webdriver/tests/user_prompts/send_alert_text.py:

5:11 AM Changeset in webkit [225212] by rmorisset@apple.com

2 edits in trunk/Source/JavaScriptCore

Support recursive tail call optimization for polymorphic calls
https://bugs.webkit.org/show_bug.cgi?id=178390

Reviewed by Saam Barati.

Comes with a large but fairly simple refactoring: the inlining path for varargs and non-varargs calls now converge a lot later,
eliminating some redundant checks, and simplifying a few parts of the inlining pipeline.

Also removes some dead code from inlineCall(): there was a special path for when m_continuationBlock is null, but it should never be (now checked with RELEASE_ASSERT).

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::handleCallVariant):
(JSC::DFG::ByteCodeParser::handleVarargsInlining):
(JSC::DFG::ByteCodeParser::getInliningBalance):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::attemptToInlineCall): Deleted.

4:45 AM Changeset in webkit [225211] by Carlos Garcia Campos

6 edits
1 add in trunk

WebDriver: add timeout option to run-webdriver-tests script
https://bugs.webkit.org/show_bug.cgi?id=179940

Reviewed by Carlos Alberto Lopez Perez.

Tools:

We need to handle timeouts to be able to run the tests in the bots. pytest doesn't support timeouts, but there's
a plugin pytest_timeout that can be used for that.

Scripts/run-webdriver-tests: Add --timeout command line option.
Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module): Check if pytest_timeout is imported to install it.
(AutoinstallImportHook._install_pytest_timeout): Install pytest_timeout from pypi.

Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:

(WebDriverTestRunnerW3C.init): Set PYTEST_TIMEOUT env var with the timeout given.

Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:

(WebDriverW3CExecutor.run): Clarify that the timeout received by do_wdspec() is ignored, and pass 0 instead of 25.

WebDriverTests:

Add a base conftest.py to load pytest_timeout plugin.

imported/w3c/conftest.py: Added.

4:43 AM Changeset in webkit [225210] by Carlos Garcia Campos

2 edits in trunk/Source/WebDriver

[GTK] WebDriver: stop making mandatory to provide a browser path if webkitgtk:browserOptions is present in capabilities
https://bugs.webkit.org/show_bug.cgi?id=180012

Reviewed by Carlos Alberto Lopez Perez.

Everything should be optional. We might want to disable overlay scrollbars, but still using the default browser,
for example, as I'm doing when running the selenium tests. We might also want to provide additional browser
arguments, but using the default browser.

gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const): Do not consider invalid to not provide a
browser binary when webkitgtk:browserOptions is present.
(WebDriver::WebDriverService::platformParseCapabilities const): Override default capabilities with the ones
provided.

4:31 AM Changeset in webkit [225209] by graouts@webkit.org

4 edits
2 adds in trunk

Pressing the space bar while watching a fullscreen video doesn't play or pause
https://bugs.webkit.org/show_bug.cgi?id=180033
<rdar://problem/33610443>

Reviewed by Eric Carlson.

Source/WebCore:

We register a "keydown" event to track when the space bar is pressed, and if the media is playing
in fullscreen, we toggle playback. This does not interfere with full keyboard access since activating
one of the media controls using the keyboard will not let the events we register for be dispatched
this far along the event dispatch phase.

Test: media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html

Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.togglePlayback): Add a catch() statement since calling play() could sometime
lead to some extraneous unhandled promise console logging that pollutes test output.
(MediaController.prototype.handleEvent):

LayoutTests:

Adding a new macOS-only test that checks that pressing the space bar while playing fullscreen
pauses the media and resumes it when pressing the space bar again.

media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback-expected.txt: Added.
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html: Added.
platform/ios-simulator/TestExpectations:

Nov 27, 2017:

11:55 PM Changeset in webkit [225208] by Carlos Garcia Campos

5 edits in trunk/Source/WebDriver

WebDriver: Implement get active element command
https://bugs.webkit.org/show_bug.cgi?id=180001

Reviewed by Brian Burg.

12.6 Get Active Element
https://w3c.github.io/webdriver/webdriver-spec.html#get-active-element

Fixes imported/w3c/webdriver/tests/element_retrieval/get_active_element.py.

Session.cpp:

(WebDriver::Session::getActiveElement):

Session.h:
WebDriverService.cpp:

(WebDriver::WebDriverService::getActiveElement):

WebDriverService.h:

6:10 PM Changeset in webkit [225207] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Web Content process crashes when dragging a link in recovery mode
https://bugs.webkit.org/show_bug.cgi?id=180058
<rdar://problem/35172170>

Reviewed by Alexey Proskuryakov.

platform/mac/DragImageMac.mm:

(WebCore::LinkImageLayout::LinkImageLayout):
LinkPresentation isn't available in the base system. Make it optional,
and fall back to the full URL like we do on platforms where it doesn't
exist at all.

5:21 PM Changeset in webkit [225206] by aakash_jain@apple.com

2 edits in trunk/Tools

Do not run webkitpy tests on multiple EWSes
https://bugs.webkit.org/show_bug.cgi?id=179834

Reviewed by Alexey Proskuryakov.

Do not run webkitpy tests in every EWS. We now have
a dedicated webkitpy test EWS.

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run): Do not run webkitpy tests in EWSes. These tests will still run
when --non-interactive option is not passed.

4:46 PM Changeset in webkit [225205] by Chris Dumez

5 edits in trunk/Source

Move callOnMainThreadAndWait() from SocketStreamHandleImplCFNet.cpp to MainThread.h
https://bugs.webkit.org/show_bug.cgi?id=180060

Reviewed by Alex Christensen.

Move callOnMainThreadAndWait() from SocketStreamHandleImplCFNet.cpp to MainThread.h so that it can be reused.

Source/WebCore:

platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::callOnMainThreadAndWait): Deleted.

Source/WTF:

wtf/MainThread.cpp:

(WTF::callOnMainThreadAndWait):

wtf/MainThread.h:

4:22 PM Changeset in webkit [225204] by Matt Lewis

4 edits
2 deletes in trunk

Unreviewed, rolling out r225201.

This caused multiple tests to timeout consistently.

Reverted changeset:

"Pressing the space bar while watching a fullscreen video
doesn't play or pause"
https://bugs.webkit.org/show_bug.cgi?id=180033
https://trac.webkit.org/changeset/225201

4:22 PM Changeset in webkit [225203] by Chris Dumez

5 edits in trunk/Source/WebCore

NavigatorBase::serviceWorker() should return a reference instead of a raw pointer
https://bugs.webkit.org/show_bug.cgi?id=180059

Reviewed by Geoffrey Garen.

NavigatorBase::serviceWorker() should return a reference instead of a raw pointer
as it can never return null.

bindings/js/JSNavigatorCustom.cpp:

(WebCore::JSNavigator::visitAdditionalChildren):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::serviceWorkerContainer):

page/NavigatorBase.cpp:

(WebCore::NavigatorBase::serviceWorker):

page/NavigatorBase.h:

4:14 PM Changeset in webkit [225202] by sbarati@apple.com

7 edits
1 add in trunk

Spread can escape when CreateRest does not
https://bugs.webkit.org/show_bug.cgi?id=180057
<rdar://problem/35676119>

Reviewed by JF Bastien.

JSTests:

stress/spread-escapes-but-create-rest-does-not.js: Added.

(assert):
(getProperties):
(theFunc):
(let.obj.valueOf):

Source/JavaScriptCore:

We previously did not handle Spread(PhantomCreateRest) only because I did not
think it was possible to generate this IR. I was wrong. We can generate
such IR when we have a PutStack(Spread) but nothing escapes the CreateRest.
This IR is rare to generate since we normally don't PutStack(Spread) because
the SetLocal almost always gets eliminated because of how our bytecode generates
op_spread. However, there exists a test case showing it is possible. Supporting
this IR pattern in FTLLower is trivial. This patch implements it and rewrites
the Validation rule for Spread.

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGValidate.cpp:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileSpread):

runtime/JSFixedArray.h:

(JSC::JSFixedArray::tryCreate):

3:51 PM Changeset in webkit [225201] by commit-queue@webkit.org

4 edits
2 adds in trunk

Pressing the space bar while watching a fullscreen video doesn't play or pause
https://bugs.webkit.org/show_bug.cgi?id=180033
<rdar://problem/33610443>

Patch by Antoine Quint <Antoine Quint> on 2017-11-27
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html

Modules/modern-media-controls/media/media-controller.js:

LayoutTests:

Adding a new macOS-only test that checks that pressing the space bar while playing fullscreen
pauses the media and resumes it when pressing the space bar again.

media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback-expected.txt: Added.
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html: Added.
platform/ios-simulator/TestExpectations:

3:30 PM Changeset in webkit [225200] by Matt Lewis

4 edits
2 deletes in trunk

Unreviewed, rolling out r225173.

This caused multiple tests to timeout consistently.

Reverted changeset:

"Pressing the space bar while watching a fullscreen video
doesn't play or pause"
https://bugs.webkit.org/show_bug.cgi?id=180033
https://trac.webkit.org/changeset/225173

3:21 PM Changeset in webkit [225199] by Jonathan Bedard

6 edits
2 adds in trunk/Tools

webkitpy: Better name-version mapping (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=179621
<rdar://problem/35589585>

Reviewed by David Kilzer.

Mapping version numbers to version names should occur in a central location.
This has a few advantages. First, it makes iterating through versions easier.
Second, it allows for apple_additions to define an additional set of name
mappings. Lastly, it will allow, in a future patch, for us to track version
instead of version name, only mapping version to version name when required.

Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init):
(PlatformInfo._determine_os_name): Use VersionNameMap instead of custom functions
mapping version to name.
(PlatformInfo._determine_linux_version): Deleted.
(PlatformInfo._determine_mac_version): Deleted.
(PlatformInfo._determine_win_version): Deleted.

Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_os_name_and_wrappers):
(TestPlatformInfo.test_os_version):
(TestPlatformInfo.test_display_name):
(TestPlatformInfo.test_total_bytes_memory):

Scripts/webkitpy/common/version.py:

(Version.contained_in): Add partial version mapping.

Scripts/webkitpy/common/version_name_map.py: Added.

(VersionNameMap): Holds a mapping of version name to version object.
(VersionNameMap.map): Don't re-create VersionNameMap every time.
(VersionNameMap.init): Initialize mapping, use platform to
define the default system platform.
(VersionNameMap._automap_to_major_version): Some operating systems, such
as iOS, have a naming scheme based on their major version and os name.
Automatically generate such mappings.
(VersionNameMap.to_name): Given a version object, platform name and
table, find the closest matching version name.
(VersionNameMap.strip_name_formatting): Remove spaces and extract the major version,
if a version string is included in the name.
(VersionNameMap.from_name): Return an os name and version given a version name.

Scripts/webkitpy/common/version_name_map_unittest.py: Added.

(VersionMapTestCase):
(VersionMapTestCase.test_default_system_platform):
(VersionMapTestCase.test_mac_version_by_name):
(VersionMapTestCase.test_ios_version_by_name):
(VersionMapTestCase.test_mac_name_by_version):
(VersionMapTestCase.test_ios_name_by_version):

Scripts/webkitpy/common/version_unittest.py:

(VersionTestCase.test_contained_in):

Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.ios_version): Map os_version name to version number.

3:13 PM Changeset in webkit [225198] by Chris Dumez

15 edits in trunk/Source

ASSERTION FAILED: addResult.isNewEntry WebCore::SWServerRegistration::addClientUsingRegistration(WebCore::ServiceWorkerClientIdentifier const&) + 141
https://bugs.webkit.org/show_bug.cgi?id=180049

Reviewed by Brady Eidson.

Source/WebCore:

SWServer::serviceWorkerStoppedControllingClient() was failing to remove the client from the
SWServerRegistration in some cases. This is because we relied on the Service Worker Identifier
to get the SWServerRegistration, via the corresponding SWServerServiceWorker object. However,
It is possible for the SWServerServiceWorker to have been destroyed already.

In serviceWorkerStartedControllingClient / serviceWorkerStoppedControllingClient, we now
pass the registration identifier, so that we are able to look up the registration directly,
without going through the service worker object.

No new tests, already covered by imported/w3c/web-platform-tests/service-workers/service-worker/claim-affect-other-registration.https.html.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::setActiveServiceWorker):

workers/service/ServiceWorker.h:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):

workers/service/ServiceWorkerData.cpp:

(WebCore::ServiceWorkerData::isolatedCopy const):

workers/service/ServiceWorkerData.h:

(WebCore::ServiceWorkerData::encode const):
(WebCore::ServiceWorkerData::decode):

workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::addRegistration):
(WebCore::SWServer::removeRegistration):
(WebCore::SWServer::clearAll):
(WebCore::SWServer::Connection::addServiceWorkerRegistrationInServer):
(WebCore::SWServer::Connection::removeServiceWorkerRegistrationInServer):
(WebCore::SWServer::Connection::serviceWorkerStartedControllingClient):
(WebCore::SWServer::Connection::serviceWorkerStoppedControllingClient):
(WebCore::SWServer::addClientServiceWorkerRegistration):
(WebCore::SWServer::removeClientServiceWorkerRegistration):
(WebCore::SWServer::serviceWorkerStartedControllingClient):
(WebCore::SWServer::serviceWorkerStoppedControllingClient):
(WebCore::SWServer::installContextData):

workers/service/server/SWServer.h:
workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::SWServerWorker):

workers/service/server/SWServerWorker.h:

Source/WebKit:

StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::addServiceWorkerRegistrationInServer):
(WebKit::WebSWClientConnection::removeServiceWorkerRegistrationInServer):
(WebKit::WebSWClientConnection::serviceWorkerStartedControllingClient):
(WebKit::WebSWClientConnection::serviceWorkerStoppedControllingClient):

WebProcess/Storage/WebSWClientConnection.h:

3:05 PM Changeset in webkit [225197] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=179137

Unreviewed test gardening.

TestExpectations:

3:04 PM Changeset in webkit [225196] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r225142): Crashes when command clicking or force touching links
https://bugs.webkit.org/show_bug.cgi?id=180055
<rdar://problem/35703910>

Reviewed by Wenson Hsieh.

No new tests; affects an existing API test.

editing/mac/DictionaryLookup.mm:

(WebCore::tokenRange):
The 'options' out argument from tokenRangeForString is autoreleased.

2:29 PM Changeset in webkit [225195] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

downcast to WebKit::FullscreenClient can sometimes fail.
https://bugs.webkit.org/show_bug.cgi?id=179849

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-11-27
Reviewed by Darin Adler.

There are cases during teardown where fullscreenClient() has been cleared back to an API::FullscreenClient.
Because those cases, WKWebView should test before downcasting to WebKit::FullscreenClient.

This is causing a crash when fullscreen delegate is cleared after a page is closed.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setFullscreenDelegate:]):
(-[WKWebView _fullscreenDelegate]):

2:18 PM Changeset in webkit [225194] by dino@apple.com

1 edit in trunk/Source/WebCore/html/OffscreenCanvas.h

Attempt to fix Windows build.

html/OffscreenCanvas.h:

2:12 PM Changeset in webkit [225193] by dino@apple.com

10 edits in trunk

Implement OffscreenCanvas.getContext("webgl")
https://bugs.webkit.org/show_bug.cgi?id=180050
<rdar://problem/35705473>

Reviewed by Sam Weinig.

Source/WebCore:

Implement enough of getContext("webgl") to actually return an
active WebGLRenderingContext, even though it isn't actually
hooked up to draw.

Introduce a new type, WebGLCanvas, which is a variant of HTMLCanvasElement
and OffscreenCanvas, so that it can be exposed by the 'canvas' attribute
on WebGLRenderingContext.

At the moment we still assume that all uses of WebGLRenderingContext come
from HTMLCanvasElement, so add a bunch of logic to detect that case.

Updated the existing (proposed) WPT.

html/OffscreenCanvas.cpp:

(WebCore::OffscreenCanvas::getContext): Implement enough of getContext to
return a WebGLRenderingContext.

html/OffscreenCanvas.h: Use the new OffscreenRenderingContext type, even

though it's just a WebGLRenderingContext at the moment.

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::canvas): Now returns a WebGLCanvas.
(WebCore::WebGLRenderingContextBase::htmlCanvas): Helper to get the HTMLCanvasElement if it exists.
(WebCore::WebGLRenderingContextBase::offscreenCanvas): Ditto for OffscreenCanvas.
(WebCore::WebGLRenderingContextBase::checkForContextLossHandling): Guard for htmlCanvas().
(WebCore::WebGLRenderingContextBase::registerWithWebGLStateTracker):
(WebCore::WebGLRenderingContextBase::setupFlags):
(WebCore::WebGLRenderingContextBase::addActivityStateChangeObserverIfNecessary):
(WebCore::WebGLRenderingContextBase::removeActivityStateChangeObserver):
(WebCore::WebGLRenderingContextBase::markContextChanged):
(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver):
(WebCore::WebGLRenderingContextBase::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContextBase::reshape):
(WebCore::WebGLRenderingContextBase::compileShader):
(WebCore::WebGLRenderingContextBase::isContextLostOrPending):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::printToConsole):
(WebCore::WebGLRenderingContextBase::dispatchContextLostEvent):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::dispatchContextChangedEvent):
(WebCore::WebGLRenderingContextBase::clampedCanvasSize):

html/canvas/WebGLRenderingContextBase.h: Define WebGLCanvas.
html/canvas/WebGLRenderingContextBase.idl:

inspector/InspectorInstrumentation.h: Handle the variant options, although leave OffscreenCanvas

unimplemented for the moment.
(WebCore::InspectorInstrumentation::didEnableExtension):
(WebCore::InspectorInstrumentation::didCreateProgram):
(WebCore::InspectorInstrumentation::willDeleteProgram):
(WebCore::InspectorInstrumentation::isShaderProgramDisabled):

inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didEnableExtension):
(WebCore::InspectorCanvasAgent::didCreateProgram):

LayoutTests:

Update expected results.

http/wpt/offscreen-canvas/getContext-webgl.html:

1:21 PM Changeset in webkit [225192] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Unreviewed, fix an improper #include

platform/network/soup/NetworkStorageSessionSoup.cpp:

1:16 PM Changeset in webkit [225191] by don.olmstead@sony.com

10 edits in trunk

[CMake][Win] Conditionally select DLL CRT or static CRT
https://bugs.webkit.org/show_bug.cgi?id=170594

Reviewed by Alex Christensen.

Source/cmake/OptionsAppleWin.cmake:
Source/cmake/OptionsMSVC.cmake:

Source/JavaScriptCore:

shell/PlatformWin.cmake:

Source/WebKitLegacy:

PlatformWin.cmake:

Tools:

DumpRenderTree/PlatformWin.cmake:
MiniBrowser/win/CMakeLists.txt:

1:05 PM Changeset in webkit [225190] by Matt Lewis

3 edits in trunk/LayoutTests

Fixed incorrectly marked test expectations.

Unreviewed test gardening.

platform/ios-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

12:49 PM Changeset in webkit [225189] by achristensen@apple.com

2 edits in trunk/LayoutTests

Run imported/w3c/web-platform-tests/url/failure.html on debug builds after r225186.

TestExpectations:

It's still flaky, but it doesn't assert any more.

12:40 PM Changeset in webkit [225188] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

Having a bad time watchpoint firing during compilation revealed a racy assertion
https://bugs.webkit.org/show_bug.cgi?id=180048
<rdar://problem/35700009>

Reviewed by Mark Lam.

While a DFG compilation is watching the having a bad time watchpoint, it was
asserting that the rest parameter structure has indexing type ArrayWithContiguous.
However, if the having a bad time watchpoint fires during the compilation,
this particular structure will no longer have ArrayWithContiguous indexing type.
This patch fixes this racy assertion to be aware that the watchpoint may fire
during compilation.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):

12:39 PM Changeset in webkit [225187] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, rebaseline http/tests/workers/service/service-worker-cache-api.https.html

This test is currently marked as flaky.

http/tests/workers/service/service-worker-cache-api.https-expected.txt:

12:23 PM Changeset in webkit [225186] by achristensen@apple.com

2 edits in trunk/Source/WebCore

imported/w3c/web-platform-tests/url/failure.html crashes on debug builds
https://bugs.webkit.org/show_bug.cgi?id=172337

Reviewed by Chris Dumez.

There were two problems:

Invalid URLs can contain non-ASCII characters in its UTF8 representation.

We should not put these URLs into content extension finite state machines. They won't load anyways.

If we don't have any content extensions installed, we still call String.utf8 unnecessarily. Let's not.

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):

12:02 PM Changeset in webkit [225185] by Simon Fraser

47 edits in trunk/Source

Use TextStream's indent tracking, rather than passing indent to all the externalRepresentation() functions
https://bugs.webkit.org/show_bug.cgi?id=180027

Reviewed by Jon Lee.

Remove all the indent arguments, and make use of TextStream::IndentScope to control
output indentation.
Source/WebCore:

Add an indent stream manipulator so you can say

ts << indent << "text"

to write the indent.

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::externalRepresentation const):

platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::externalRepresentation const):

platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::externalRepresentation const):

platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::externalRepresentation const):

platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::externalRepresentation const):

platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::externalRepresentation const):

platform/graphics/filters/FEDiffuseLighting.h:
platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::externalRepresentation const):

platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::externalRepresentation const):

platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::externalRepresentation const):

platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::externalRepresentation const):

platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::externalRepresentation const):

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::externalRepresentation const):

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::externalRepresentation const):

platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::externalRepresentation const):

platform/graphics/filters/FESpecularLighting.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::externalRepresentation const):

platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::externalRepresentation const):

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::externalRepresentation const):

platform/graphics/filters/FilterEffect.h:
platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::externalRepresentation const):

platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::externalRepresentation const):

platform/graphics/filters/SourceGraphic.h:
rendering/RenderTreeAsText.cpp:

(WebCore::write):
(WebCore::writeLayer):
(WebCore::writeLayerRenderers):
(WebCore::writeLayers):
(WebCore::externalRepresentation):

rendering/RenderTreeAsText.h:
rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGInlineTextBox):
(WebCore::writeSVGInlineTextBoxes):
(WebCore::writeStandardPrefix):
(WebCore::writeChildren):
(WebCore::writeSVGResourceContainer):
(WebCore::writeSVGContainer):
(WebCore::write):
(WebCore::writeSVGText):
(WebCore::writeSVGInlineText):
(WebCore::writeSVGImage):
(WebCore::writeSVGGradientStop):
(WebCore::writeResources):

rendering/svg/SVGRenderTreeAsText.h:
svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::externalRepresentation const):

svg/graphics/filters/SVGFEImage.h:

Source/WTF:

Add an indent stream manipulator so you can say

ts << indent << "text"

to write the indent.

wtf/text/TextStream.h:

(WTF::TextStream::IndentScope::IndentScope):
(WTF::TextStream::IndentScope::~IndentScope):

11:51 AM Changeset in webkit [225184] by Chris Dumez

21 edits
1 copy in trunk/Source

Give Document a strongly typed identifier instead of a uint64_t
https://bugs.webkit.org/show_bug.cgi?id=180041

Reviewed by Youenn Fablet.

Give Document a strongly typed identifier instead of a uint64_t, for clarity.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::m_identifier):

dom/Document.h:

(WebCore::Document::identifier const):

dom/DocumentIdentifier.h: Copied from Source/WebCore/workers/service/ServiceWorkerClientIdentifier.h.
workers/service/ServiceWorkerClientIdentifier.h:

(WebCore::ServiceWorkerClientIdentifier::toString const):
(WebCore::ServiceWorkerClientIdentifier::encode const):
(WebCore::ServiceWorkerClientIdentifier::decode):

workers/service/server/SWClientConnection.cpp:

(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::notifyClientsOfControllerChange):

workers/service/server/SWClientConnection.h:
workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::serviceWorkerStartedControllingClient):
(WebCore::SWServer::Connection::serviceWorkerStoppedControllingClient):
(WebCore::SWServer::serviceWorkerStartedControllingClient):
(WebCore::SWServer::serviceWorkerStoppedControllingClient):

workers/service/server/SWServer.h:
workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::addClientUsingRegistration):
(WebCore::SWServerRegistration::removeClientUsingRegistration):

workers/service/server/SWServerRegistration.h:

Source/WebKit:

Platform/IPC/ArgumentCoders.h:
Scripts/webkit/messages.py:

(forward_declarations_and_headers):

StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::notifyClientsOfControllerChange):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):

StorageProcess/ServiceWorker/WebSWServerConnection.h:
StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::postMessageToServiceWorkerClient):

WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorkerGlobalScope):
(WebKit::WebSWClientConnection::serviceWorkerStartedControllingClient):
(WebKit::WebSWClientConnection::serviceWorkerStoppedControllingClient):
(WebKit::WebSWClientConnection::postMessageToServiceWorkerClient):

WebProcess/Storage/WebSWClientConnection.h:
WebProcess/Storage/WebSWClientConnection.messages.in:

11:40 AM Changeset in webkit [225183] by Simon Fraser

4 edits in trunk/Source/WebCore

Optimize FEDisplacementMap
https://bugs.webkit.org/show_bug.cgi?id=180023

Reviewed by Sam Weinig.

Make FEDisplacementMap about 3x faster by operating on whole pixels rather than
individual channels. There's no per-channel logic once the srcX and srcY are computed.

Other sundry cleanup.

platform/graphics/ColorUtilities.h:

(WebCore::byteOffsetOfPixel): Will use this in more places in future.

platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

platform/graphics/filters/FEDisplacementMap.h:

(WebCore::FEDisplacementMap::xChannelIndex const):
(WebCore::FEDisplacementMap::yChannelIndex const):

11:36 AM Changeset in webkit [225182] by commit-queue@webkit.org

7 edits in trunk

[GTK][WPE] Add "enable-encrypted-media" property to WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=18005

Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2017-11-27
Reviewed by Michael Catanzaro.

Source/WebKit:

EncryptedMedia is an experimental JavaScript API for playing encrypted media in HTML.
This property will only work as intended if the EncryptedMedia feature is enabled at build time
with the ENABLE_ENCRYPTED_MEDIA flag.

UIProcess/API/glib/WebKitSettings.cpp:

(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_encrypted_media):
(webkit_settings_set_enable_encrypted_media):

UIProcess/API/gtk/WebKitSettings.h:
UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
UIProcess/API/wpe/WebKitSettings.h:

Tools:

TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:

(testWebKitSettings):

10:33 AM Changeset in webkit [225181] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, unskip service worker tests that are no longer flaky.

TestExpectations:

10:24 AM Changeset in webkit [225180] by fpizlo@apple.com

3 edits in trunk/Source/bmalloc

Don't crash in forEachEntry when DebugHeap is enabled.

Unreviewed, fixing crashes on leaks bots by removing an assertion.

bmalloc/IsoTLS.cpp:

(bmalloc::IsoTLS::forEachEntry):

test/testbmalloc.cpp: Make this test work with DebugHeap so I can catch this kind of problem in the future.

9:59 AM Changeset in webkit [225179] by timothy_horton@apple.com

12 edits in trunk

One too many zeroes in macOS version number in FeatureDefines
https://bugs.webkit.org/show_bug.cgi?id=180011

Reviewed by Dan Bernstein.

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
Configurations/FeatureDefines.xcconfig:

9:43 AM Changeset in webkit [225178] by pvollan@apple.com

2 edits in trunk/Tools

[Win] The number of webkit-patch iterations on EWS should be configurable.
https://bugs.webkit.org/show_bug.cgi?id=178517

Reviewed by Darin Adler.

Add a new RESET_AFTER_ITERATION argument to the EWS shell script.

EWSTools/start-queue-win.sh:

9:19 AM Changeset in webkit [225177] by pvollan@apple.com

2 edits in trunk/Tools

[Win] Switch to VS2017 on EWS bots.
https://bugs.webkit.org/show_bug.cgi?id=178516

Reviewed by Darin Adler.

EWSTools/start-queue-win.sh:

9:08 AM Changeset in webkit [225176] by zandobersek@gmail.com

5 edits in trunk/Source/WebKit

[CoordGraphics] Prettify ID value handling in UpdateAtlas and UpdateAtlas::Client
https://bugs.webkit.org/show_bug.cgi?id=180038

Reviewed by Carlos Garcia Campos.

In the UpdateAtlas class, provide an ID type that aliases to uint32_t.
The m_id member variable (ex-m_ID) uses this type, and it's also now
used in the Client interface.

While poking around, the header is modified to use '#pragma once',
and m_id is moved to the more logical first position among member
variables.

The static ID variable is modified to use the new type, and renamed
to s_nextID. Comment alongside the namespace scope closure is fixed
to use the appropriate name.

createUpdateAtlas() and removeUpdateAtlas() methods in the
CompositingCoordinator class are modified to use the UpdateAtlas::ID
type, and the former has the second parameter changed from RefPtr<>
to Ref<>.

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::createUpdateAtlas):
(WebKit::CompositingCoordinator::removeUpdateAtlas):

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::getCoordinatedBuffer):

WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

9:06 AM Changeset in webkit [225175] by zandobersek@gmail.com

5 edits in trunk/Source/WebKit

[CoordGraphics] CompositingCoordinator: clean up Client vtable, GraphicsLayerClient overrides
https://bugs.webkit.org/show_bug.cgi?id=180037

Reviewed by Carlos Garcia Campos.

Remove the CompositingCoordinator::Client::paintLayerContents() method since
the only implementation in CoordinatedLayerTreeHost was empty.

Subsequently, the CompositingCoordinator::paintContents() override of the
GraphicsLayerClient method can also be removed. The notifyAnimationStarted()
override is empty, just like the base method, so it's removed as well.

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::deviceScaleFactor const): Bring method up
to the notifyFlushRequired() code, since both are overrides of the
GraphicsLayerClient-inherited methods.
(WebKit::CompositingCoordinator::pageScaleFactor const): Ditto.
(WebKit::CompositingCoordinator::notifyAnimationStarted): Deleted.
(WebKit::CompositingCoordinator::paintContents): Deleted.

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::paintLayerContents): Deleted.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

9:05 AM Changeset in webkit [225174] by zandobersek@gmail.com

3 edits in trunk/Source/WebCore

[CoordGraphics] CoordinatedGraphicsLayer doesn't need to inherit from TextureMapperPlatformLayer::Client
https://bugs.webkit.org/show_bug.cgi?id=180036

Reviewed by Carlos Garcia Campos.

There's no reason CoordinatedGraphicsLayer should inherit from
TextureMapperPlatformLayer::Client. CoordinatedGraphicsLayer objects are
not used anywhere through that type, and all the overridden methods are
empty anyway. The TextureMapperPlatformLayer::Client class (along with
TextureMapperPlatformLayer) is nowadays only used in the direct
TextureMapper implementation of GraphicsLayer.

No new tests -- no change in behavior.

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::platformLayerWillBeDestroyed): Deleted.
(WebCore::CoordinatedGraphicsLayer::setPlatformLayerNeedsDisplay): Deleted.

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

8:54 AM Changeset in webkit [225173] by graouts@webkit.org

4 edits
2 adds in trunk

Pressing the space bar while watching a fullscreen video doesn't play or pause
https://bugs.webkit.org/show_bug.cgi?id=180033
<rdar://problem/33610443>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html

Modules/modern-media-controls/media/media-controller.js:

LayoutTests:

Adding a new macOS-only test that checks that pressing the space bar while playing fullscreen
pauses the media and resumes it when pressing the space bar again.

media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback-expected.txt: Added.
media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html: Added.
platform/ios-simulator/TestExpectations:

8:37 AM Changeset in webkit [225172] by Simon Fraser

5 edits in trunk/Source/WebCore

Optimize FEMorphology
https://bugs.webkit.org/show_bug.cgi?id=180020

Reviewed by Sam Weinig.

Use const PaintingData&.
Compute all components at once.
Avoid Vector<> capacity changes during the pixel loop.
Tweak the parallel jobs scaling.
Templatize the the inner loop functions that compute min or max based
on the filter type to avoid conditionals in tight loops.

This is about a 4x speedup before the parallel jobs tweaking. With fixed parallelism,
a 200x200 filter went from 15ms to about 1ms with these changes.

platform/graphics/ColorUtilities.h:

(WebCore::ColorComponents::fromRGBA):
(WebCore::ColorComponents::toRGBA const):
(WebCore::perComponentMax):
(WebCore::perComponentMin):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware): Remove some old perf logging code.
TimingScope now does something similar.

platform/graphics/filters/FEMorphology.cpp:

(WebCore::pixelArrayIndex):
(WebCore::minOrMax):
(WebCore::columnExtremum):
(WebCore::kernelExtremum):
(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplyWorker):
(WebCore::FEMorphology::platformApply):
(WebCore::FEMorphology::platformApplySoftware):
(WebCore::shouldSupersedeExtremum): Deleted.

platform/graphics/filters/FEMorphology.h:

8:30 AM Changeset in webkit [225171] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

REGRESSION(r223073): disk cache directory is no longer copied in ProcessPoolConfiguration::copy()
https://bugs.webkit.org/show_bug.cgi?id=180031

Reviewed by Youenn Fablet.

This has caused GTK/WPE test /webkit2/WebKitWebsiteData/configuration to fail, and the wrong directory is used
by the network process. I think it was removed by mistake in r223073.

UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy): Copy m_diskCacheDirectory too.

8:22 AM Changeset in webkit [225170] by rmorisset@apple.com

2 edits in trunk/Source/JavaScriptCore

Update DFGSafeToExecute to be aware that ArrayPush is now a varargs node
https://bugs.webkit.org/show_bug.cgi?id=179821

Reviewed by Saam Barati.

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

8:02 AM Changeset in webkit [225169] by Ms2ger@igalia.com

4 edits
1 delete in trunk/LayoutTests

[GTK][WPE] Enable http/wpt/resource-timing/rt-initiatorType-media.html.
https://bugs.webkit.org/show_bug.cgi?id=180034

Unreviewed test gardening.

If this test fails, it will fail with random numbers in the failure
message. The current platform-neutral expectation file contains one
pair of these random numbers, ensuring that this test will never be
interpreted as passing -- not while the bug exists, and not when it
is fixed.

This change updates the expectation file to contain only passes and
enables the test for WPE and GTK, as the bug does not seem to exist
there.

http/wpt/resource-timing/rt-initiatorType-media-expected.txt:
platform/gtk/TestExpectations:
platform/wpe/TestExpectations:
platform/wpe/http/wpt/resource-timing/rt-initiatorType-media-expected.txt: Removed.

7:34 AM Changeset in webkit [225168] by Adrian Perez de Castro

2 edits in trunk

[CMake] Values of CMAKE_BUILD_TYPE from toolchain file are ignored
https://bugs.webkit.org/show_bug.cgi?id=179971

Reviewed by Carlos Alberto Lopez Perez.

CMakeLists.txt: Call project() first, as it loads the toolchain

file, so that's done before checking CMAKE_BUILD_TYPE.

6:23 AM WebKitGTK/Gardening/Calendar edited by Carlos Garcia Campos

(diff)

6:16 AM Changeset in webkit [225167] by Adrian Perez de Castro

4 edits in trunk/Source/WebKit

[WPE][GTK] Improve contents of pkg-config .pc files
https://bugs.webkit.org/show_bug.cgi?id=180032

Reviewed by Carlos Garcia Campos.

gtk/webkit2gtk-web-extension.pc.in: Add URL, edit Name and Description.
gtk/webkit2gtk.pc.in: Add URL, edit Name.
wpe/wpe-webkit.pc.in: Add URL, edit Name and Description.

5:20 AM Changeset in webkit [225166] by Carlos Garcia Campos

4 edits
1 delete in trunk

[SOUP] Layout test media/track/track-text-track-cue-list.html crash with g_source_set_ready_time: assertion 'source->ref_count > 0' failed
https://bugs.webkit.org/show_bug.cgi?id=176806

Reviewed by Carlos Alberto Lopez Perez.

Tools:

This was caused by a GLib bug that has already been fixed. Upgrade glib to 2.54.2.

gtk/jhbuild.modules:
gtk/patches/gdate-suppress-string-format-literal-warning.patch: Removed.

LayoutTests:

platform/gtk/TestExpectations:

3:02 AM Changeset in webkit [225165] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: selector's field shadow is clipped at the bottom
https://bugs.webkit.org/show_bug.cgi?id=179961

Reviewed by Matt Baker.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration .selector):

1:41 AM Changeset in webkit [225164] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EME][GStreamer] Change the ClearKey's SystemID value
https://bugs.webkit.org/show_bug.cgi?id=180007

Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2017-11-27
Reviewed by Xabier Rodriguez-Calvar.

Use 1077efec-c0b2-4d02-ace3-3c1e52e2fb4b instead of
58147ec8-0423-4659-92e6-f52c5ce8c3cc, as is specified in W3C.
https://www.w3.org/TR/eme-initdata-cenc/#common-system-definition

platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:

1:29 AM Changeset in webkit [225163] by jfernandez@igalia.com

3 edits
2 adds in trunk

[css-grid] Display issues with child with max-width
https://bugs.webkit.org/show_bug.cgi?id=178973

Reviewed by Darin Adler.

Source/WebCore:

We have an utility function to compute the grid item's margins
when the item still needs to layout. We used the function
RenderStyle::hasMarings to decide whether such margin computation
worths. However, we need that function to operate on a specific
axis, hence I added a new function adding such logic.

Additionally, we must treat any 'auto' margin as 0px during the
tracks sizing algorithm, as the CSS Grid spec states:

https://drafts.csswg.org/css-grid/#auto-margins

Test: fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html

rendering/GridLayoutFunctions.cpp:

(WebCore::GridLayoutFunctions::childHasMargin): New funciton with axis dependent logic.
(WebCore::GridLayoutFunctions::computeMarginLogicalSizeForChild): Ignore auto margins.
(WebCore::GridLayoutFunctions::marginLogicalSizeForChild): Ignore auto margins.

LayoutTests:

Regression test for the bug.

fast/css-grid-layout/auto-margins-ignored-during-track-sizing-expected.html: Added.
fast/css-grid-layout/auto-margins-ignored-during-track-sizing.html: Added.

12:53 AM Changeset in webkit [225162] by fred.wang@free.fr

16 edits
57 copies
12 moves
86 adds
5 deletes in trunk/LayoutTests

Import MathML WPT tests
https://bugs.webkit.org/show_bug.cgi?id=179110

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-25
Reviewed by Darin Adler.

This patch imports the MathML WPT tests and remove the corresponding unmaintained copies
from LayoutTests/imported/mathml-in-html5/. The only exception is for MathML tests testing
OpenType MATH parameters: They require Web fonts and do not work well in WebKit without
some tweaks because of bug 174030. For now, we only move the web fonts required by the tests
and keep running the legacy versions.

LayoutTests/imported/w3c:

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/mathml/OWNERS: Added.
web-platform-tests/mathml/README.md: Added.
web-platform-tests/mathml/presentation-markup/fractions/frac-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-1-expected.txt.
web-platform-tests/mathml/presentation-markup/fractions/frac-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-1.html.
web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-1.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html.
web-platform-tests/mathml/presentation-markup/fractions/frac-parameters-2.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html.
web-platform-tests/mathml/presentation-markup/fractions/w3c-import.log: Added.
web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1-expected.txt.
web-platform-tests/mathml/presentation-markup/operators/mo-axis-height-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1.html.
web-platform-tests/mathml/presentation-markup/operators/w3c-import.log: Added.
web-platform-tests/mathml/presentation-markup/radicals/root-parameters-1.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html.
web-platform-tests/mathml/presentation-markup/radicals/w3c-import.log: Added.
web-platform-tests/mathml/presentation-markup/scripts/subsup-1-expected.txt: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-1-expected.txt.
web-platform-tests/mathml/presentation-markup/scripts/subsup-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-1.html.
web-platform-tests/mathml/presentation-markup/scripts/subsup-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-2-expected.txt.
web-platform-tests/mathml/presentation-markup/scripts/subsup-2.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-2.html.
web-platform-tests/mathml/presentation-markup/scripts/subsup-3-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-3-expected.txt.
web-platform-tests/mathml/presentation-markup/scripts/subsup-3.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-3.html.
web-platform-tests/mathml/presentation-markup/scripts/subsup-4-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-4-expected.txt.
web-platform-tests/mathml/presentation-markup/scripts/subsup-4.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-4.html.
web-platform-tests/mathml/presentation-markup/scripts/subsup-5-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-5-expected.txt.
web-platform-tests/mathml/presentation-markup/scripts/subsup-5.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-5.html.
web-platform-tests/mathml/presentation-markup/scripts/subsup-parameters-1.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html.
web-platform-tests/mathml/presentation-markup/scripts/underover-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-1-expected.txt.
web-platform-tests/mathml/presentation-markup/scripts/underover-1.html: Added.
web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-1.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html.
web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-2.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html.
web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-3.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html.
web-platform-tests/mathml/presentation-markup/scripts/underover-parameters-4.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html.
web-platform-tests/mathml/presentation-markup/scripts/w3c-import.log: Added.
web-platform-tests/mathml/presentation-markup/spaces/space-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/spaces/space-1-expected.txt.
web-platform-tests/mathml/presentation-markup/spaces/space-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/spaces/space-1.html.
web-platform-tests/mathml/presentation-markup/spaces/space-2-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/spaces/space-2-expected.html.
web-platform-tests/mathml/presentation-markup/spaces/space-2.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/spaces/space-2.html.
web-platform-tests/mathml/presentation-markup/spaces/w3c-import.log: Added.
web-platform-tests/mathml/presentation-markup/tables/table-axis-height-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/tables/table-axis-height-expected.txt.
web-platform-tests/mathml/presentation-markup/tables/table-axis-height.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/presentation-markup/tables/table-axis-height.html.
web-platform-tests/mathml/presentation-markup/tables/w3c-import.log: Added.
web-platform-tests/mathml/relations/css-styling/color-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/color-1-expected.html.
web-platform-tests/mathml/relations/css-styling/color-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/color-1.html.
web-platform-tests/mathml/relations/css-styling/display-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/display-1-expected.html.
web-platform-tests/mathml/relations/css-styling/display-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/display-1.html.
web-platform-tests/mathml/relations/css-styling/displaystyle-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/displaystyle-1-expected.txt.
web-platform-tests/mathml/relations/css-styling/displaystyle-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/displaystyle-1.html.
web-platform-tests/mathml/relations/css-styling/lengths-1-expected.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1-expected.html.
web-platform-tests/mathml/relations/css-styling/lengths-1.html: Added.
web-platform-tests/mathml/relations/css-styling/lengths-2-expected.html: Copied from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1-expected.html.
web-platform-tests/mathml/relations/css-styling/lengths-2.html: Added.
web-platform-tests/mathml/relations/css-styling/lengths-3-expected.txt: Added.
web-platform-tests/mathml/relations/css-styling/lengths-3.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-fraktur.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-italic.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-sans-serif.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold-script.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-bold.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-double-struck.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-fraktur.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-initial-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-initial.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-italic-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-italic.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-looped-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-looped.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-monospace-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-monospace.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-bold-italic.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif-italic.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-sans-serif.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-script-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-script.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-stretched-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-stretched.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-tailed-expected.html: Added.
web-platform-tests/mathml/relations/css-styling/mathvariant-tailed.html: Added.
web-platform-tests/mathml/relations/css-styling/visibility-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/visibility-1-expected.html.
web-platform-tests/mathml/relations/css-styling/visibility-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/css-styling/visibility-1.html.
web-platform-tests/mathml/relations/css-styling/w3c-import.log: Added.
web-platform-tests/mathml/relations/html5-tree/class-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/class-1-expected.html.
web-platform-tests/mathml/relations/html5-tree/class-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/class-1.html.
web-platform-tests/mathml/relations/html5-tree/class-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/class-2-expected.txt.
web-platform-tests/mathml/relations/html5-tree/class-2.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/class-2.html.
web-platform-tests/mathml/relations/html5-tree/color-attributes-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/color-attributes-1-expected.html.
web-platform-tests/mathml/relations/html5-tree/color-attributes-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/color-attributes-1.html.
web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/display-1-expected.txt.
web-platform-tests/mathml/relations/html5-tree/display-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/display-1.html.
web-platform-tests/mathml/relations/html5-tree/dynamic-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/dynamic-1-expected.html.
web-platform-tests/mathml/relations/html5-tree/dynamic-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/dynamic-1.html.
web-platform-tests/mathml/relations/html5-tree/href-click-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/href-click-1-expected.html.
web-platform-tests/mathml/relations/html5-tree/href-click-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/href-click-1.html.
web-platform-tests/mathml/relations/html5-tree/href-click-2-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/href-click-2-expected.html.
web-platform-tests/mathml/relations/html5-tree/href-click-2.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/href-click-2.html.
web-platform-tests/mathml/relations/html5-tree/integration-point-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1-expected.html.
web-platform-tests/mathml/relations/html5-tree/integration-point-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1.html.
web-platform-tests/mathml/relations/html5-tree/integration-point-2-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-2-expected.html.
web-platform-tests/mathml/relations/html5-tree/integration-point-2.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-2.html.
web-platform-tests/mathml/relations/html5-tree/integration-point-3-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-3-expected.html.
web-platform-tests/mathml/relations/html5-tree/integration-point-3.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-3.html.
web-platform-tests/mathml/relations/html5-tree/required-extensions-1-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-1-expected.txt.
web-platform-tests/mathml/relations/html5-tree/required-extensions-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-1.html.
web-platform-tests/mathml/relations/html5-tree/required-extensions-2-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-2-expected.html.
web-platform-tests/mathml/relations/html5-tree/required-extensions-2.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-2.html.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-1-expected.html: Added.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-1-iframe-1.html: Added.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-1-iframe-2.html: Added.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-1.html: Added.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-2-expected.txt: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-2-expected.txt.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-2.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-2.html.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-3-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-3-expected.html.
web-platform-tests/mathml/relations/html5-tree/unique-identifier-3.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-3.html.
web-platform-tests/mathml/relations/html5-tree/w3c-import.log: Added.
web-platform-tests/mathml/relations/text-and-math/use-typo-metrics-1-expected.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1-expected.html.
web-platform-tests/mathml/relations/text-and-math/use-typo-metrics-1.html: Renamed from LayoutTests/imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html.
web-platform-tests/mathml/relations/text-and-math/w3c-import.log: Added.
web-platform-tests/mathml/tools/axisheight.py: Added.
web-platform-tests/mathml/tools/fractions.py: Added.
web-platform-tests/mathml/tools/largeop.py: Added.
web-platform-tests/mathml/tools/limits.py: Added.
web-platform-tests/mathml/tools/mathvariant-transforms.py: Added.

(parseCodePoint):

web-platform-tests/mathml/tools/radicals.py: Added.

(createStretchyRadical):

web-platform-tests/mathml/tools/scripts.py: Added.
web-platform-tests/mathml/tools/stacks.py: Added.
web-platform-tests/mathml/tools/stretchstacks.py: Added.
web-platform-tests/mathml/tools/underover.py: Added.
web-platform-tests/mathml/tools/use-typo-lineheight.py: Added.
web-platform-tests/mathml/tools/utils/init.py: Added.
web-platform-tests/mathml/tools/utils/mathfont.py: Added.

(create):
(drawRectangleGlyph):
(createSquareGlyph):
(drawHexaDigit):
(createGlyphFromValue):
(save):

web-platform-tests/mathml/tools/utils/misc.py: Added.

(downloadWithProgressBar):

web-platform-tests/mathml/tools/utils/w3c-import.log: Added.
web-platform-tests/mathml/tools/w3c-import.log: Added.
web-platform-tests/mathml/tools/xHeight.py: Added.
web-platform-tests/mathml/w3c-import.log: Added.

LayoutTests:

TestExpectations: Skip MathML tests requiring web fonts and mark some MathML tests as failing.
imported/mathml-in-html5/fonts/math/axisheight5000-verticalarrow14000.woff: Moved to imported/w3c/web-platform-tests/fonts/math/.
imported/mathml-in-html5/fonts/math/fraction-axisheight7000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-denominatordisplaystylegapmin5000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-denominatordisplaystyleshiftdown6000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-denominatorgapmin4000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-denominatorshiftdown3000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-numeratordisplaystylegapmin8000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-numeratordisplaystyleshiftup2000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-numeratorgapmin9000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-numeratorshiftup11000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/fraction-rulethickness10000.woff: Ditto.
imported/mathml-in-html5/fonts/math/largeop-displayoperatorminheight5000.woff: Ditto.
imported/mathml-in-html5/fonts/math/limits-lowerlimitbaselinedropmin3000.woff: Ditto.
imported/mathml-in-html5/fonts/math/limits-lowerlimitgapmin11000.woff: Ditto.
imported/mathml-in-html5/fonts/math/limits-upperlimitbaselinerisemin5000.woff: Ditto.
imported/mathml-in-html5/fonts/math/limits-upperlimitgapmin7000.woff: Ditto.
imported/mathml-in-html5/fonts/math/lineheight5000-typolineheight2300.woff: Ditto.
imported/mathml-in-html5/fonts/math/mathvariant-transforms.woff: Ditto.
imported/mathml-in-html5/fonts/math/radical-degreebottomraisepercent25-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/radical-displaystyleverticalgap7000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/radical-extraascender3000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/radical-kernafterdegreeminus5000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/radical-kernbeforedegree4000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/radical-rulethickness8000.woff: Ditto.
imported/mathml-in-html5/fonts/math/radical-verticalgap6000-rulethickness1000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-spaceafterscript3000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-subscriptbaselinedropmin9000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-subscriptshiftdown6000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-subscripttopmax4000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-subsuperscriptgapmin11000-superscriptbottommaxwithsubscript3000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-subsuperscriptgapmin11000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-superscriptbaselinedropmax10000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-superscriptbottommin8000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-superscriptshiftup7000.woff: Ditto.
imported/mathml-in-html5/fonts/math/scripts-superscriptshiftupcramped5000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stack-axisheight7000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stack-bottomdisplaystyleshiftdown5000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stack-bottomshiftdown6000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stack-displaystylegapmin4000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stack-gapmin8000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stack-topdisplaystyleshiftup3000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stack-topshiftup9000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stretchstack-bottomshiftdown3000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stretchstack-gapabovemin7000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stretchstack-gapbelowmin11000.woff: Ditto.
imported/mathml-in-html5/fonts/math/stretchstack-topshiftup5000.woff: Ditto.
imported/mathml-in-html5/fonts/math/underover-accentbaseheight4000-overbarextraascender3000.woff: Ditto.
imported/mathml-in-html5/fonts/math/underover-accentbaseheight4000-overbarverticalgap11000.woff: Ditto.
imported/mathml-in-html5/fonts/math/underover-accentbaseheight4000-underbarextradescender5000.woff: Ditto.
imported/mathml-in-html5/fonts/math/underover-accentbaseheight4000-underbarverticalgap7000.woff: Ditto.
imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-1.html:

Update the URL to use the fonts in w3c/web-platform-tests/fonts/math/.

imported/mathml-in-html5/mathml/presentation-markup/fractions/frac-parameters-2.html: Ditto.
imported/mathml-in-html5/mathml/presentation-markup/radicals/root-parameters-1.html: Ditto.
imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-parameters-1.html: Ditto.
imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-1.html: Ditto.
imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-2.html: Ditto.
imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-3.html: Ditto.
imported/mathml-in-html5/mathml/presentation-markup/scripts/underover-parameters-4.html: Ditto.
imported/mathml-in-html5/mathml/relations/css-styling/mathvariant-transforms-1-expected.html: Removed.
imported/mathml-in-html5/mathml/relations/css-styling/mathvariant-transforms-1.html: Removed.
imported/mathml-in-html5/mathml/relations/css-styling/mathvariant-transforms-2-expected.html: Removed.
imported/mathml-in-html5/mathml/relations/css-styling/mathvariant-transforms-2.html: Removed.
imported/mathml-in-html5/mathml/relations/html5-tree/namespace-1-expected.txt: Removed.
imported/mathml-in-html5/mathml/relations/html5-tree/namespace-1.html: Removed.
platform/ios/TestExpectations: Updated to match the new version in imported/w3c.
platform/mac/TestExpectations: Ditto.
platform/win/TestExpectations: Ditto.

12:21 AM Changeset in webkit [225161] by jmarcell@apple.com

2 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r224426. rdar://problem/35364697

12:21 AM Changeset in webkit [225160] by jmarcell@apple.com

3 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r224416. rdar://problem/35339833

12:21 AM Changeset in webkit [225159] by jmarcell@apple.com

6 edits
2 adds in branches/safari-604-branch

Cherry-pick r224405. rdar://problem/35339758

12:21 AM Changeset in webkit [225158] by jmarcell@apple.com

3 edits
2 adds in branches/safari-604-branch

Cherry-pick r224398. rdar://problem/35329715

12:21 AM Changeset in webkit [225157] by jmarcell@apple.com

3 edits
1 add in branches/safari-604-branch

Cherry-pick r224366. rdar://problem/35329723

12:21 AM Changeset in webkit [225156] by jmarcell@apple.com

3 edits
1 add in branches/safari-604-branch

Cherry-pick r224349. rdar://problem/35329732

12:21 AM Changeset in webkit [225155] by jmarcell@apple.com

5 edits
1 add in branches/safari-604-branch

Cherry-pick r224302. rdar://problem/35323829

Nov 26, 2017:

11:51 PM Changeset in webkit [225154] by Yusuke Suzuki

19 edits
5 adds in trunk

[DFG] Add NormalizeMapKey DFG IR
https://bugs.webkit.org/show_bug.cgi?id=179912

Reviewed by Saam Barati.

JSTests:

stress/map-untyped-normalize-cse.js: Added.

(shouldBe):
(test):

stress/map-untyped-normalize.js: Added.

(shouldBe):
(test):

stress/set-untyped-normalize-cse.js: Added.

(shouldBe):
(set return.set has.set has):

stress/set-untyped-normalize.js: Added.

(shouldBe):
(set return.set has):

Source/JavaScriptCore:

This patch introduces NormalizeMapKey DFG node. It executes what normalizeMapKey does in inlined manner.
By separating this from MapHash and Map/Set related operations, we can perform CSE onto that, and we
do not need to call normalizeMapKey conservatively in DFG operations.
This can reduce slow path case in Untyped GetMapBucket since we can normalize keys in DFG/FTL.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupNormalizeMapKey):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNormalizeMapKey):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileNormalizeMapKey):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):

runtime/HashMapImpl.h:

7:45 PM Changeset in webkit [225153] by Yusuke Suzuki

4 edits
2 adds in trunk

[FTL] Support DeleteById and DeleteByVal
https://bugs.webkit.org/show_bug.cgi?id=180022

Reviewed by Saam Barati.

JSTests:

stress/delete-by-id.js: Added.

(shouldBe):
(test1):
(test2):

stress/delete-by-val-ftl.js: Added.

(shouldBe):
(test1):
(test2):

Source/JavaScriptCore:

We should increase the coverage of FTL. Even if the code includes DeleteById,
it does not mean that remaining part of the code should not be optimized in FTL.
Right now, even CallEval and with scope are handled in FTL.

This patch just adds DeleteById and DeleteByVal handling to FTL to allow optimizing
code including them.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteById):
(JSC::FTL::DFG::LowerDFGToB3::compileDeleteByVal):

6:19 PM Changeset in webkit [225152] by Simon Fraser

3 edits
2 adds in trunk

feImage as filter input has skewed colors
https://bugs.webkit.org/show_bug.cgi?id=180021

Reviewed by Sam Weinig.
Source/WebCore:

Using an <feImage> as a filter input sometimes results in incorrect colors, because
the image is being sourced as linearRGB when it should always be sRGB.

Fix by setting the result colorspace in FEImage before we allocate the output
buffer.

Tests: svg/filters/feImage-color-fidelity-expected.svg

svg/filters/feImage-color-fidelity.svg

svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

LayoutTests:

svg/filters/feImage-color-fidelity-expected.svg: Added.
svg/filters/feImage-color-fidelity.svg: Added.

5:46 PM Changeset in webkit [225151] by Yusuke Suzuki

8 edits
5 adds in trunk

[DFG] Introduce {Set,Map,WeakMap}Fields
https://bugs.webkit.org/show_bug.cgi?id=179925

Reviewed by Saam Barati.

JSTests:

stress/map-set-clobber-map-get.js: Added.

(shouldBe):
(test):

stress/map-set-does-not-clobber-set-has.js: Added.

(shouldBe):

stress/map-set-does-not-clobber-weak-map-get.js: Added.

(shouldBe):
(test):

stress/set-add-clobber-set-has.js: Added.

(shouldBe):

stress/set-add-does-not-clobber-map-get.js: Added.

(shouldBe):

Source/JavaScriptCore:

SetAdd and MapSet uses write(MiscFields), but it is not correct. It accidentally
writes readonly MiscFields which is used by various nodes and make optimization
conservative.

We introduce JSSetFields, JSMapFields, and JSWeakMapFields to precisely model clobberizing of Map, Set, and WeakMap.

dfg/DFGAbstractHeap.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

dfg/DFGHeapLocation.h:
dfg/DFGNode.h:

(JSC::DFG::Node::hasBucketOwnerType):

5:22 PM Changeset in webkit [225150] by Yusuke Suzuki

12 edits
1 delete in trunk/Source/JavaScriptCore

[JSC] Remove JSStringBuilder
https://bugs.webkit.org/show_bug.cgi?id=180016

Reviewed by Saam Barati.

JSStringBuilder is replaced with WTF::StringBuilder.
This patch removes remaning uses and drop JSStringBuilder.

JavaScriptCore.xcodeproj/project.pbxproj:
runtime/ArrayPrototype.cpp:
runtime/AsyncFunctionPrototype.cpp:
runtime/AsyncGeneratorFunctionPrototype.cpp:
runtime/ErrorPrototype.cpp:
runtime/FunctionPrototype.cpp:
runtime/GeneratorFunctionPrototype.cpp:
runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::globalFuncEscape):

runtime/JSStringBuilder.h: Removed.
runtime/JSStringInlines.h:

(JSC::jsMakeNontrivialString):

runtime/RegExpPrototype.cpp:
runtime/StringPrototype.cpp:

5:15 PM Changeset in webkit [225149] by Yusuke Suzuki

15 edits in trunk/Source/JavaScriptCore

[DFG] Remove GetLocalUnlinked
https://bugs.webkit.org/show_bug.cgi?id=180017

Reviewed by Saam Barati.

Since DFGArgumentsSimplificationPhase is removed 2 years ago, GetLocalUnlinked is no longer used in DFG.
This patch just removes it.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGCommon.h:
dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGNode.h:

(JSC::DFG::Node::hasUnlinkedLocal):
(JSC::DFG::Node::convertToGetLocalUnlinked): Deleted.
(JSC::DFG::Node::convertToGetLocal): Deleted.
(JSC::DFG::Node::hasUnlinkedMachineLocal): Deleted.
(JSC::DFG::Node::setUnlinkedMachineLocal): Deleted.
(JSC::DFG::Node::unlinkedMachineLocal): Deleted.

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

dfg/DFGValidate.cpp:

2:13 PM Changeset in webkit [225148] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Cleanup code for RenderMathMLUnderOver::layoutBlock
https://bugs.webkit.org/show_bug.cgi?id=179681

Patch by Minsheng Liu <lambda@liu.ms> on 2017-11-26
Reviewed by Frédéric Wang.

The patch removes some unnecessary calls to layoutIfNeeds() and guards the change
with assertion. Since there is no behavior change, no new tests are required.

rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::stretchHorizontalOperatorsAndLayoutChildren):
(WebCore::RenderMathMLUnderOver::layoutBlock):
(WebCore::RenderMathMLUnderOver::computeOperatorsHorizontalStretch): Deleted.

rendering/mathml/RenderMathMLUnderOver.h:

12:03 PM Changeset in webkit [225147] by Simon Fraser

36 edits in trunk

Use more Uint8ClampedArray& and constness in filter and image buffer code
https://bugs.webkit.org/show_bug.cgi?id=180008

Reviewed by Darin Adler.

Source/WebCore:

Use references to Uint8ClampedArrays rather than pointers where necessary.

Use const for source data buffers when possible, and uint8_t for the underlying
data type.

Fix a bug in FEGaussianBlur where the output of the last blur pass wasn't
copied to the result buffer, which required a test adjustment.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::putImageData):

platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::genericConvertToLuminanceMask):

platform/graphics/ImageBuffer.h:
platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::blurShadowBuffer):

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::putByteArray):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):

platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData const):
(WebCore::ImageBufferData::putData):

platform/graphics/cg/ImageBufferDataCG.h:
platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h:

(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):

platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h:

(WebCore::boxBlurNEON):

platform/graphics/cpu/arm/filters/NEONHelpers.h:

(WebCore::loadRGBA8AsFloat):

platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::effectApplyAccelerated):
(WebCore::effectType):
(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

platform/graphics/filters/FEComposite.cpp:

(WebCore::computeArithmeticPixels):
(WebCore::FEComposite::platformArithmeticSoftware):
(WebCore::FEComposite::platformApplySoftware):

platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::setDestinationPixels):
(WebCore::FEConvolveMatrix::fastSetInteriorPixels):
(WebCore::FEConvolveMatrix::fastSetOuterPixels):
(WebCore::FEConvolveMatrix::platformApplySoftware):

platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlurAlphaOnly):
(WebCore::boxBlur):
(WebCore::accelerateBoxBlur):
(WebCore::standardBoxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::platformApplyWorker):
(WebCore::FEGaussianBlur::platformApply):
(WebCore::FEGaussianBlur::platformApplySoftware):

platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::drawLighting):
(WebCore::FELighting::platformApplySoftware):

platform/graphics/filters/FELighting.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::columnExtremum):
(WebCore::FEMorphology::platformApplyGeneric):
(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware):

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::fillRegionWorker):
(WebCore::FETurbulence::platformApplySoftware):

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::forceValidPreMultipliedPixels):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::unmultipliedResult):
(WebCore::FilterEffect::premultipliedResult):
(WebCore::FilterEffect::copyImageBytes const):
(WebCore::copyPremultiplyingAlpha):
(WebCore::copyUnpremultiplyingAlpha):
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):

platform/graphics/filters/FilterEffect.h:
platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::putData):

platform/graphics/win/ImageBufferDataDirect2D.h:

LayoutTests:

Fix a bug in FEGaussianBlur where the output of the last blur pass wasn't
copied to the result buffer, which required a test adjustment.

css3/filters/filter-on-overflow-hidden-expected.html:
css3/filters/filter-on-overflow-hidden.html:

7:56 AM Changeset in webkit [225146] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Make ArgList::data() private again when we can remove callWasmFunction().
https://bugs.webkit.org/show_bug.cgi?id=168582

Reviewed by JF Bastien.

Make ArgList::data() private since we already removed callWasmFunction.

runtime/ArgList.h:

Nov 25, 2017:

8:59 AM Changeset in webkit [225145] by Alan Bujtas

3 edits in trunk/Source/WebCore

Make RenderSnapshottedPlugIn ISO allocated
https://bugs.webkit.org/show_bug.cgi?id=180010
<rdar://problem/35671977>

Reviewed by David Kilzer.

RenderEmbeddedObject, the base class is ISO allocated since r224537.

rendering/RenderSnapshottedPlugIn.cpp:
rendering/RenderSnapshottedPlugIn.h:

Nov 24, 2017:

6:44 PM Changeset in webkit [225144] by Darin Adler

14 edits in trunk/Source

Fix some minor problems in the StringImpl header
https://bugs.webkit.org/show_bug.cgi?id=160630

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

inspector/ContentSearchUtilities.cpp: Removed a lot of unneeded explicit

Yarr namespacing since we use "using namespace" in this file.

Source/WebCore:

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::text): Use stripLeadingAndTrailingHTMLSpaces
instead of stripWhiteSpace(isHTMLSpace).
(WebCore::HTMLOptionElement::value): Ditto.
(WebCore::HTMLOptionElement::label): Ditto.
(WebCore::HTMLOptionElement::displayLabel): Ditto.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument): Use stripLeadingAndTrailingHTMLSpaces
instead of calling the general purpose one and passing isHTMLSpace.

platform/network/HTTPParsers.h:

(WebCore::stripLeadingAndTrailingHTTPSpaces): Updated to use the
new name, stripLeadingAndTrailingCharacters.

Source/WTF:

wtf/text/AtomicString.h: Update since CharacterMatchFunctionPtr is now

CodeUnitMatchFunction.

wtf/text/StringCommon.h: Added CodeUnitMatchFunction, which replaces

CharacterMatchFunctionPtr.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::stripMatchedCharacters): Changed template argument name
to CodeUnitPredicate to help make it clear this works on code units, not
code points.
(WTF::UCharPredicate): Deleted.
(WTF::SpaceOrNewlinePredicate): Deleted.
(WTF::StringImpl::stripWhiteSpace): Removed unneeded use of predicate class to
turn a function into a functor; functions already work fine as functors without
a class wrapping them.
(WTF::StringImpl::stripLeadingAndTrailingCharacters): Ditto. Also renamed
from stripWhiteSpace, since it strips arbitrary characters.
(WTF::StringImpl::removeCharacters): Fixed various minor style issues and
updated to new type name.
(WTF::StringImpl::simplifyMatchedCharactersToSpace): Ditto.
(WTF::StringImpl::simplifyWhiteSpace): More of the same.
(WTF::StringImpl::find): Ditto.

wtf/text/StringImpl.h: Removed unneeded include of uchar.h, since it's

included by StringCommon.h. Removed =CharacterMatchFunctionPtr and
IsWhiteSpaceFunctionPtr, both replaced by CodeUnitMatchFunction. Fixed
a mistake recently introduced in isSpaceOrNewline, which was unnecessarily,
inefficiently using ICU for non-ASCII Latin-1 characters.

wtf/text/StringView.h: Use CodeUnitMatchFunction instead of CharacterMatchFunction.

wtf/text/WTFString.cpp:

(WTF::String::stripLeadingAndTrailingCharacters): Updated function name and type.
(WTF::String::simplifyWhiteSpace): Updated type.
(WTF::String::removeCharacters): Updated type.

wtf/text/WTFString.h: Ditto.

5:49 PM Changeset in webkit [225143] by Darin Adler

2 edits in trunk/Tools

TestWebKitAPI/Tests/WTF/OptionSet.cpp:

(TestWebKitAPI::TEST): Added a test for OptionSet operator|.

5:09 PM Changeset in webkit [225142] by Darin Adler

34 edits in trunk/Source

Fix dictionary leak in lookup, convert FindOptions to OptionSet, tweak code style nearby
https://bugs.webkit.org/show_bug.cgi?id=179981

Reviewed by Sam Weinig.

Source/WebCore:

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rangeMatchesTextNearRange): Pass { } instead of 0.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::rangeOfStringClosestToRangeInDirection const): Use { }
instead of | to construct value.

editing/Editor.cpp:

(WebCore::Editor::findString): Use contains instead of & to test an option.
(WebCore::Editor::rangeOfString): Ditto.
(WebCore::Editor::countMatchesForText): Ditto.

editing/EditorCommand.cpp:

(WebCore::executeFindString): Use { } instead of | to construct value.

editing/FindOptions.h: Use OptionSet for type.
editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer): Use contains instead of &. Also use -= instead
of &= coupled with ~ to remove a flag.
(WebCore::SearchBuffer::isWordEndMatch const): Ditto.
(WebCore::SearchBuffer::isWordStartMatch const): Ditto.
(WebCore::SearchBuffer::search): Ditto.
(WebCore::findIteratorOptions): Ditto.
(WebCore::findClosestPlainText): Ditto.
(WebCore::findPlainText): Ditto.

editing/mac/DictionaryLookup.h: Changed optional dictionary out arguments to

RetainPtr<NSDictionary>. Before, they were returning a retained object, but callers
did not seem to realize that.

editing/mac/DictionaryLookup.mm:

(WebCore::tokenRange): Added helper. Takes care of doing adoptNS on the options
dictionary, and also handles the Objective-C exception possibility cleanly. Also
fixed the exception case to return NSNotFound instead of a zero-length range at
the location we are searching, which is what the code expects.
(WebCore::DictionaryLookup::rangeForSelection): Refactored to use the tokenRange
helper function, and also to do much less work when the options pointer is null.
(WebCore::DictionaryLookup::rangeAtHitTestResult): Use the tokenRange helper
function and also use auto a bunch to tighten up the code a bit.
(WebCore::DictionaryLookup::stringForPDFSelection): Ditto.

page/DOMWindow.cpp:

(WebCore::DOMWindow::find const): Use |= instead of | to build find options.

page/Page.cpp:

(WebCore::Page::findString): Use contains instead of & and also - instead of
& combined with ~.
(WebCore::Page::findStringMatchingRanges): Ditto.
(WebCore::Page::rangeOfString): Ditto.

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::selectClosestWordFromHitTestResultBasedOnLookup):
Pass nullptr to indicate we don't need the options dictionary. The code before
was passing a pointer to a null, which meant we would do the work to get the
options dictionary, not use it, and also leak it.

testing/Internals.cpp:

(WebCore::Internals::rangeOfStringNearLocation): Pass { } instead of 0.
(WebCore::Internals::rangeForDictionaryLookupAtLocation): Pass nullptr to
indicate we don't need the options dictionary as above.
(WebCore::parseFindOptions): Initialize options without an explicit 0, since
an OptionSet starts out empty rather than uninitialized.

Source/WebKit:

WebProcess/Plugins/PDF/PDFPlugin.h: Use some references instead of pointers. Made more

things final and private. Changed functions with multiple return values to use tuples
instead of out arguments for clarity, especially because some were using pointers and it
was ambiguous whether the pointers could be nullptr. Tweaked formatting. Moved initialization
of data members into the class definition.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::create): Take a reference.
(WebKit::PDFPlugin::PDFPlugin): Ditto. Also moved some initialization to the class definition.
(WebKit::PDFPlugin::countFindMatches): Added comment about ignored maxMatchCount argument.
(WebKit::PDFPlugin::findString): Use contains instead of & to check bits in options.
Simplified slightly confusing match count code that was doing some unnecessary comparisons
with the maximum match count. Use auto a bit.
(WebKit::coreCursor): Renamed from pdfLayerControllerCursorTypeToCursor since this is C++
and overloading works based on the argument type.
(WebKit::PDFPlugin::notifyCursorChanged): Updated for name change.
(WebKit::PDFPlugin::lookupTextAtLocation const): Return a tuple instead of using two out
arguments and use a RetainPtr so we don't leak the options dictionary.

WebProcess/Plugins/PluginProxy.h: Removed unneeded include of FindOptions.h.

WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

(WebKit::WebContextMenuClient::lookUpInDictionary): Pass a reference.

WebProcess/WebPage/FindController.cpp:

(WebKit::core): Use |= instead of | to build up a FindOptions.
(WebKit::FindController::FindController): Initialize data members in the class definition.
(WebKit::pluginViewForFrame): Deleted. Callers now use WebPage::pluginViewForFrame.
(WebKit::FindController::updateFindUIAfterPageScroll): Added a FIXME about some peculiar code.
(WebKit::FindController::findString): Use |= rather than | to add in an option.
(WebKit::FindController::hideFindUI): Use { } rather than 0 for no options.

WebProcess/WebPage/FindController.h: Moved initialization to the header. Exported the core

function that converts WebKit::FindOptions to WebCore::FindOptions.

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::handlesPageScaleGesture const): Use WebPage::pluginViewForFrame.
(WebKit::WebFrame::requiresUnifiedScaleFactor const): Use WebPage::pluginViewForFrame.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Removed unneeded local variable and UNUSED_PARAM.
(WebKit::WebPage::focusedPluginViewForFrame): Use pluginViewForFrame.
(WebKit::WebPage::pluginViewForFrame): Added a null check since this takes a pointer.
Use is/downcast insteadof more ad hoc coding style.
(WebKit::WebPage::findStringFromInjectedBundle): Call core to convert WebKit::FindOptions
to WebCore::FindOptions. Before, this was accidentally relying on the bits from the two
enumrations matching! The stricter type checking of OptionSet helps us catch mistakes
like this.

WebProcess/WebPage/WebPage.h: Updated for the above. Also flattened out nested #if

statements, made forward declarations unconditional, and re-sorted them. Changed the
Mac-specific lookupTextAtLocation to return a tuple (see below).

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupForSelection): Take a reference instead of a pointer.
(WebKit::WebPage::performDictionaryLookupForRange): Ditto.
(WebKit::rangeNearPositionMatchesText): Use { } rather than 0 for no options.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation): Use RetainPtr<NSDictionary> to fix
code that used to leak.
(WebKit::WebPage::performDictionaryLookupForSelection): Ditto.
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection): Use a reference.
(WebKit::WebPage::dictionaryPopupInfoForRange): Updated for changed argument types.
(WebKit::WebPage::dictionaryPopupInfoForSelectionInPDFPlugin): Ditto.
(WebKit::WebPage::performDictionaryLookupForRange): Ditto.
(WebKit::WebPage::performImmediateActionHitTestAtLocation): Updated to handle the
tuple result from the lookupTextAtLocation functions.
(WebKit::WebPage::lookupTextAtLocation): Changed to return a tuple and use RetainPtr
for the NSDictionary to help fix the leak.

Source/WebKitLegacy/mac:

WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _animationControllerForText]): Use RetainPtr so we don't leak.

WebView/WebView.mm:

(coreOptions): Use |= instead of | to build up FindOptions.

Source/WebKitLegacy/win:

WebView.cpp:

(WebView::searchFor): Use |= instead of | to build FindOptions.
(WebView::markAllMatchesForText): Create FindOptions with |= instead of |.
(WebView::findString): Create FindOptions with |=; the old code just passed a
WebKit FindOptions through without converting to WebCore::FindOptions.

Source/WTF:

wtf/OptionSet.h: Added some operators so it's easier to use | and - with individual

options from the set.

1:15 PM Changeset in webkit [225141] by Antti Koivisto

4 edits
2 adds in trunk

Style resolution spin due to calc() values always comparing inequal (seen on arstechnica.com)
https://bugs.webkit.org/show_bug.cgi?id=179982
<rdar://problem/35677991>

Reviewed by Darin Adler.

Source/WebCore:

Test: transitions/transition-with-calc-spin.html

Something like calc(100% - 10px) would compare inequal to itself. This causes the implicit animation engine think that
there is a new target value after style resolution and restart the transition. Starting the transition triggers another style
resolution on zero duration timer and so on.

platform/CalculationValue.cpp:

(WebCore::operator==):

platform/CalculationValue.h:

Deep compare the child vectors.

LayoutTests:

transitions/transition-with-calc-spin-expected.txt: Added.
transitions/transition-with-calc-spin.html: Added.

1:02 PM Changeset in webkit [225140] by mark.lam@apple.com

7 edits in trunk/Source/JavaScriptCore

Fix CLoop::sanitizeStack() bug where it was clearing part of the JS stack in use.
https://bugs.webkit.org/show_bug.cgi?id=179936
<rdar://problem/35623998>

Reviewed by Saam Barati.

This issue was uncovered when we enabled --useDollarVM=true on the JSC tests.
See https://bugs.webkit.org/show_bug.cgi?id=179684.

Basically, in the case of the failing test we observed, op_tail_call_forward_arguments
was allocating stack space to stash arguments (to be forwarded) and new frame
info. The location of this new stash space happens to lie beyond the top of frame
of the tail call caller frame. After stashing the arguments, the code proceeded
to load the callee codeBlock. This triggered an allocation, which in turn,
triggered stack sanitization. The CLoop stack sanitizer was relying on
frame->topOfFrame() to tell it where the top of the used stack is. In this case,
that turned out to be inadequate. As a result, part of the stashed data was
zeroed out, and subsequently led to a crash.

This bug does not affect JIT builds (i.e. the ASM LLint) for 2 reasons:

JIT builds do stack sanitization in the LLInt code itself (different from the CLoop implementation), and the sanitizer there is aware of the true top of stack value (i.e. the stack pointer).
JIT builds don't use a parallel stack like the CLoop. The presence of the parallel stack is one condition necessary for reproducing this issue.

The fix is to make the CLoop record the stack pointer in CLoopStack::m_currentStackPointer
every time before it calls out to native C++ code. This also brings the CLoop's
behavior closer to hardware behavior where we can know where the stack pointer
is after calling from JS back into native C++ code, which makes it easier to
reason about correctness.

Also simplified the various stack boundary calculations (removed the +1 and -1
adjustments). The CLoopStack bounds are now:

reservationTop(): the lowest reserved address that can be within stack bounds.
m_commitTop: the lowest address within stack bounds that has been committed.
lowAddress() aka m_end: the lowest stack address that JS code can use.
m_lastStackPointer: cache of the last m_currentStackPointer value.
m_currentStackPointer: the CLoopStack stack pointer value when calling from JS into C++ code.
highAddress(): the highest address just beyond the bounds of the stack.

Also deleted some unneeded code.

interpreter/CLoopStack.cpp:

(JSC::CLoopStack::CLoopStack):
(JSC::CLoopStack::gatherConservativeRoots):
(JSC::CLoopStack::sanitizeStack):
(JSC::CLoopStack::setSoftReservedZoneSize):

interpreter/CLoopStack.h:

(JSC::CLoopStack::setCurrentStackPointer):
(JSC::CLoopStack::lowAddress const):

(JSC::CLoopStack::baseOfStack const): Deleted.

Not needed after we simplified the code and removed all the +1/-1 adjustments. Now, it has the exact same value as highAddress() and can be removed.

interpreter/CLoopStackInlines.h:

(JSC::CLoopStack::ensureCapacityFor):
(JSC::CLoopStack::currentStackPointer):
(JSC::CLoopStack::setCLoopStackLimit):

(JSC::CLoopStack::topOfFrameFor): Deleted.

Not needed.

(JSC::CLoopStack::topOfStack): Deleted.

Supplanted by currentStackPointer().

(JSC::CLoopStack::shrink): Deleted.

This is unused.

llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

Introduce a StackPointerScope to restore the original CLoopStack::m_currentStackPointer upon exitting the interpreter loop.

offlineasm/cloop.rb:
Added setting of CLoopStack::m_currentStackPointer at boundary points where we call from JS into C++ code.

tools/VMInspector.h:
Added some default argument values. These were being used while debugging this issue.

11:52 AM Changeset in webkit [225139] by commit-queue@webkit.org

2 edits in trunk/Source/WebKitLegacy

[WinCairo] WebPreferences IDL not regenerating
https://bugs.webkit.org/show_bug.cgi?id=179960

Patch by Fujii Hironori <Fujii Hironori> on 2017-11-24
Reviewed by Darin Adler.

WebKitLegacy shouldn't include the forwarding header of
WebKitLegacy itself.

CMakeLists.txt: Add ${FORWARDING_HEADERS_DIR} and remove

${FORWARDING_HEADERS_DIR}/JavaScriptCore and
${FORWARDING_HEADERS_DIR}/WebKitLegacy from
WebKitLegacy_INCLUDE_DIRECTORIES.

11:27 AM Changeset in webkit [225138] by commit-queue@webkit.org

4 edits
5 adds in trunk

Captions move when <video> with no controls is hovered
https://bugs.webkit.org/show_bug.cgi?id=178600
<rdar://problem/35112309>

Patch by Antoine Quint <Antoine Quint> on 2017-11-24
Reviewed by Jer Noble.

Source/WebCore:

We should only reduce the text tracks container height to make room for the controls
bar when controls are enabled.

Tests: media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html

media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html

Modules/modern-media-controls/controls/text-tracks.css:

(video[controls]::-webkit-media-text-track-container.visible-controls-bar):
(video::-webkit-media-text-track-container.visible-controls-bar): Deleted.

LayoutTests:

We add two tests to check that we correctly reduce the height of the text tracks container
when the controls bar should be visible, and that we do not reduce it when the controls are
not visible.

media/modern-media-controls/text-tracks/text-tracks-height-no-controls-expected.txt: Added.
media/modern-media-controls/text-tracks/text-tracks-height-no-controls.html: Added.
media/modern-media-controls/text-tracks/text-tracks-height-with-controls-expected.txt: Added.
media/modern-media-controls/text-tracks/text-tracks-height-with-controls.html: Added.
platform/mac/TestExpectations:

9:26 AM Changeset in webkit [225137] by Simon Fraser

41 edits in trunk/Source/WebCore

Some FilterEffect cleanup and logging
https://bugs.webkit.org/show_bug.cgi?id=179932

Reviewed by Darin Adler.

Rename the FilterEffect functions that get the result of the filter
to have "result" in the name.

Re-order FilterEffect member variables and use initializers. webkit.org/b/45614
is closed so remove the comment about things moving to RenderSVGResourceFilterPrimitive.

Add a virtual filterName() function for use by logging.

Add a Filters log channel. Log some stuff.

Rename RenderSVGResourceFilter::m_filter to m_rendererFilterDataMap.

platform/Logging.h:
platform/graphics/cpu/arm/filters/FEBlendNEON.h:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

platform/graphics/filters/FEComposite.h:
platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

platform/graphics/filters/FEDisplacementMap.h:
platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEFlood.h:
platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::platformApplySoftware):

platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

platform/graphics/filters/FELighting.h:
platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::platformApplyDegenerate):
(WebCore::FEMorphology::platformApplySoftware):

platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.cpp:

(WebCore::operator<<):

platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::FilterEffect):
(WebCore::FilterEffect::imageBufferResult):
(WebCore::FilterEffect::unmultipliedResult):
(WebCore::FilterEffect::premultipliedResult):
(WebCore::FilterEffect::copyImageBytes const): This can be const. It'a also crazy
to mark a large, slow function like this as 'inline'.
(WebCore::FilterEffect::copyUnmultipliedResult):
(WebCore::FilterEffect::copyPremultipliedResult):
(WebCore::FilterEffect::createImageBufferResult):
(WebCore::FilterEffect::createUnmultipliedImageResult):
(WebCore::FilterEffect::createPremultipliedImageResult):
(WebCore::FilterEffect::transformResultColorSpace):
(WebCore::FilterEffect::asImageBuffer): Deleted.
(WebCore::FilterEffect::asUnmultipliedImage): Deleted.
(WebCore::FilterEffect::asPremultipliedImage): Deleted.
(WebCore::FilterEffect::copyImageBytes): Deleted.
(WebCore::FilterEffect::copyUnmultipliedImage): Deleted.
(WebCore::FilterEffect::copyPremultipliedImage): Deleted.

platform/graphics/filters/FilterEffect.h:
platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.h:
rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::output const):

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
(WebCore::RenderSVGResourceFilter::removeClientFromCache):
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
(WebCore::RenderSVGResourceFilter::drawingRegion const):
(WebCore::operator<<):

rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData): Deleted.

svg/graphics/filters/SVGFEImage.h:

7:36 AM Changeset in webkit [225136] by Ms2ger@igalia.com

4 edits
1 delete in trunk/LayoutTests

LayoutTests/imported/w3c:
Stop importing css-shapes-1/test-plan/index.html.
https://bugs.webkit.org/show_bug.cgi?id=168553

Unreviewed test gardening.

It's not a test; there's no good reason to import it.

resources/import-expectations.json:
web-platform-tests/css/css-shapes-1/test-plan/index-expected.txt: Removed.
web-platform-tests/css/css-shapes-1/test-plan/index.html: Removed.
web-platform-tests/css/css-shapes-1/test-plan/w3c-import.log: Removed.

LayoutTests:
[GTK] Remove reference to css-shapes-1/test-plan/index.html.
https://bugs.webkit.org/show_bug.cgi?id=168553

Unreviewed test gardening.

platform/gtk/TestExpectations:

6:23 AM Changeset in webkit [225135] by Ms2ger@igalia.com

2 edits in trunk/LayoutTests

[WPE] Update some test expectations
https://bugs.webkit.org/show_bug.cgi?id=180000

Unreviewed test gardening.

platform/wpe/TestExpectations:
- Mark as intermittently passing:
  - animations/negative-delay.html (also noted the bug)
  - fast/canvas/canvas-overflow-hidden-animation.html
  - imported/w3c/i18n/bidi/bidi-plaintext-011.html

Enable tests fixed in r224580:
- imported/w3c/IndexedDB-private-browsing/idb_webworkers.html
- storage/indexeddb/basics-workers.html
- storage/indexeddb/cursor-advance-workers.html
- storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html
- storage/indexeddb/dont-commit-on-blocked.html
- storage/indexeddb/index-basics-workers.html
- storage/indexeddb/modern/blob-simple-workers.html
- storage/indexeddb/modern/worker-getall.html
- storage/indexeddb/modern/workers-enable.html
- storage/indexeddb/objectstore-basics-workers.html
- storage/indexeddb/open-twice-workers.html
- storage/indexeddb/pending-activity-workers.html
- storage/indexeddb/pending-version-change-on-exit.html
- storage/indexeddb/pending-version-change-on-exit-private.html
- storage/indexeddb/pending-version-change-stuck.html
- storage/indexeddb/pending-version-change-stuck-private.html
- storage/indexeddb/pending-version-change-stuck-works-with-terminate.html
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html
- storage/indexeddb/transaction-complete-workers.html
- storage/indexeddb/transaction-complete-workers-private.html
- storage/indexeddb/unprefix-workers.html

Remove failure expectations for tests that are passing on the bot:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html: passing since r225060.
- fast/events/event-view-toString.html: passing since r221858.
- fast/events/offsetX-offsetY.html: passing since r221858.
- fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html: passing since r221858.
- webgl/1.0.2/conformance/context/context-creation-and-destruction.html: passing since its missing resource was added in r223632.

Add some passing expectations for tests that are marked as failing in the platform-neutral file:
- css2.1/20110323/replaced-intrinsic-001.htm: has been passing for a long time; the baseline probably does not reflect the actual pass condition. (The upstream test is claimed to be invalid, and fails in all browsers.)
- css2.1/20110323/replaced-intrinsic-002.htm: has been passing for a long time; the baseline probably does not reflect the actual pass condition. (The upstream test is claimed to be invalid, and fails in all browsers.)
- css3/flexbox/csswg/flexbox_flex-natural-mixed-basis-auto.html: passing since r222128.
- transitions/svg-text-shadow-transition.html: passing since expectation rebaseline in r222084.

6:17 AM Changeset in webkit [225134] by clopez@igalia.com

2 edits in trunk/LayoutTests

REGRESSION(r225098): [WPE] Gardening of tests after r225098.

70 new failures after some features changed of value.
Reported on https://bugs.webkit.org/show_bug.cgi?id=180004
Remove also 2 duplicated entries on the expectations file.

Unreviewed gardening.

platform/wpe/TestExpectations:

5:30 AM Changeset in webkit [225133] by graouts@webkit.org

7 edits
2 adds in trunk

[Web Animations] Allow getComputedStyle() to return animated values for accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=179975
<rdar://problem/35676811>

Reviewed by Dean Jackson.

Source/WebCore:

In case we're running an accelerated animation, we are not blending RenderStyles as the animation
progresses and thus we need to hook into computeRenderStyleForProperty() to query the DocumentTimeline
for the animated style of running accelerated animations where we blend styles manually for the
animation's current time.

Test: http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html

animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animatedStyleForRenderer): Iterate through all running accelerated animations
for the element to which the provided renderer is attached and ask for their animated styles.

animation/DocumentTimeline.h:
animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::getAnimatedStyle): Manually blend all animated properties and populate the provided
RenderStyle with their values, creating the RenderStyle if needed.

animation/KeyframeEffect.h:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty): Query the DocumentTimeline for accelerated animated properties in
case such animations are running, otherwise let the CSS animation controller report the animated values.

LayoutTests:

Add a new test that checks that the computed style of accelerated animation returns the animated value.
This test would fail for the accelerated case prior to this patch.

http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle-expected.txt: Added.
http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html: Added.

5:04 AM Changeset in webkit [225132] by zandobersek@gmail.com

6 edits in trunk/Source

[CoordGraphics] CoordinatedGraphicsLayer::updateContentBuffers() should always assume a non-null CoordinatedBuffer
https://bugs.webkit.org/show_bug.cgi?id=179977

Reviewed by Carlos Garcia Campos.

Source/WebCore:

CoordinatedGraphicsLayer::updateContentBuffers() retrieves a RefPtr<CoordinatedBuffer>
from the CompositingCoordinator. This pointer should never be null since if no
existing UpdateAtlas can provide the necessary memory area, a fresh UpdateAtlas is
created and its buffer returned. This can't fail in theory since the tiles that are
being updated are smaller than the UpdateAtlas area.

The CoordinatedGraphicsLayerClient::getCoordinatedBuffer() method is updated to
always return a Ref<CoordinatedBuffer> value. Code in updateContentBuffers() is
updated to remove a null-check on what is now the Ref<CoordinatedBuffer> value.

No new tests -- no change in functionality.

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updateContentBuffers):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

Make CompositingCoordinator::getCoordinatedBuffer() return a Ref<CoordinatedBuffer>
value. In case an UpdateAtlas with enough free area is found, its CoordinatedBuffer
is dereferenced into the return value. In case a new UpdateAtlas is created, the
returned CoordinatedBuffer pointer is asserted to be non-null and dereferenced.

The retrieved CoordinatedBuffer pointer on a newly-created UpdateAtlas should never
be null since the tiles are smaller in size than the UpdateAtlas area. The assert
is done in release configurations as well since the code in CoordinatedGraphicsLayer
assumes the returned pointer will be non-null, so it's just a matter of where to
crash first in case somehow a null value is returned.

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::getCoordinatedBuffer):

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

3:27 AM Changeset in webkit [225131] by zandobersek@gmail.com

4 edits in trunk/Source/WebKit

[CoordGraphics] UpdateAtlas constructor should receive an IntSize, not a dimension value
https://bugs.webkit.org/show_bug.cgi?id=179976

Reviewed by Carlos Garcia Campos.

Have the UpdateAtlas constructor receive an IntSize object that specifies
the desired size for the CoordinatedBuffer. Passing in a dimension doesn't
really make sense since this value isn't dynamically configurable, and
the only value that is passed in is already a power-of-two.

WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::getCoordinatedBuffer):

WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:

(WebKit::UpdateAtlas::UpdateAtlas):

WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h:

3:04 AM Changeset in webkit [225130] by Yusuke Suzuki

5 edits in trunk/Source/JavaScriptCore

[JSC] Make empty key as deleted mark in HashMapBucket and drop m_deleted field
https://bugs.webkit.org/show_bug.cgi?id=179923

Reviewed by Darin Adler.

We do not set empty as a key in HashMapBucket since JSMap / JSSet can expose it to users.
So we can use it as a marker of deleted bucket.

This patch uses empty key as a deleted flag, and drop m_deleted field of HashMapBucket.
It shrinks the size of HashMapBucket much.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetMapBucketNext):

ftl/FTLAbstractHeapRepository.h:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):

runtime/HashMapImpl.h:

(JSC::HashMapBucket::createSentinel):
We make sentinel bucket as (undefined, undefined) since DFG/FTL can load a value from sentinels.
While the sentinel's deleted flag becomes false since key is set, it is not a problem since deleted
flag of sentinel bucket is not used.

(JSC::HashMapBucket::HashMapBucket):
(JSC::HashMapBucket::deleted const):
(JSC::HashMapBucket::makeDeleted):
(JSC::HashMapImpl::remove):
(JSC::HashMapImpl::clear):
(JSC::HashMapImpl::setUpHeadAndTail):
(JSC::HashMapImpl::addNormalizedInternal):
(JSC::HashMapBucket::setDeleted): Deleted.
(JSC::HashMapBucket::offsetOfDeleted): Deleted.
(): Deleted.

2:58 AM Changeset in webkit [225129] by mark.lam@apple.com

113 edits in trunk

Move unsafe jsc shell test functions to the $vm object.
https://bugs.webkit.org/show_bug.cgi?id=179980

Reviewed by Yusuke Suzuki.

JSTests:

controlFlowProfiler/driver/driver.js:
controlFlowProfiler/execution-count.js:
controlFlowProfiler/if-statement.js:
controlFlowProfiler/loop-statements.js:
controlFlowProfiler/switch-statements.js:
controlFlowProfiler/test-jit.js:
exceptionFuzz/3d-cube.js:
exceptionFuzz/date-format-xparb.js:
exceptionFuzz/earley-boyer.js:
heapProfiler/basic-edges.js:
heapProfiler/property-edge-types.js:
microbenchmarks/try-get-by-id-basic.js:
microbenchmarks/try-get-by-id-polymorphic.js:
modules/namespace-object-try-get.js:
stress/argument-count-bytecode.js:
stress/argument-intrinsic-basic.js:
stress/argument-intrinsic-inlining-use-caller-arg.js:
stress/argument-intrinsic-inlining-with-result-escape.js:
stress/argument-intrinsic-inlining-with-vararg-with-enough-arguments.js:
stress/argument-intrinsic-inlining-with-vararg.js:
stress/argument-intrinsic-nested-inlining.js:
stress/argument-intrinsic-not-convert-to-get-argument.js:
stress/argument-intrinsic-with-stack-write.js:
stress/arity-mismatch-get-argument.js:
stress/array-message-passing.js:
stress/array-push-with-force-exit.js:
stress/check-dom-with-signature.js:
stress/check-sub-class.js:
stress/compare-eq-incomplete-profile.js:
stress/custom-get-set-inline-caching-one-level-up-proto-chain.js:
stress/do-eval-virtual-call-correctly.js:
stress/dom-jit-with-poly-proto.js:
stress/domjit-exception-ic.js:
stress/domjit-exception.js:
stress/domjit-getter-complex-with-incorrect-object.js:
stress/domjit-getter-complex.js:
stress/domjit-getter-poly.js:
stress/domjit-getter-proto.js:
stress/domjit-getter-super-poly.js:
stress/domjit-getter-try-catch-getter-as-get-by-id-register-restoration.js:
stress/domjit-getter-type-check.js:
stress/domjit-getter.js:
stress/exit-during-inlined-arity-fixup-recover-proper-frame.js:
stress/for-in-proxy-target-changed-structure.js:
stress/for-in-proxy.js:
stress/generational-opaque-roots.js:
stress/global-const-redeclaration-setting-2.js:
stress/global-const-redeclaration-setting-3.js:
stress/global-const-redeclaration-setting-4.js:
stress/global-const-redeclaration-setting-5.js:
stress/global-const-redeclaration-setting.js:
stress/import-basic.js:
stress/import-from-eval.js:
stress/import-reject-with-exception.js:
stress/import-syntax.js:
stress/impure-get-own-property-slot-inline-cache.js:
stress/is-constructor.js:
stress/istypedarrayview-intrinsic.js:
stress/jsc-setImpureGetterDelegate-on-bad-type.js:
stress/jsc-test-functions-should-be-more-robust.js:
stress/object-toString-with-proxy.js:
stress/poly-proto-custom-value-and-accessor.js:
stress/proxy-inline-cache.js:
stress/re-execute-error-module.js:
stress/regress-150532.js:
stress/regress-156992.js:
stress/regress-179619.js:
stress/resources/shadow-chicken-support.js:
stress/runtime-array.js:
stress/sampling-profiler-microtasks.js:
stress/shadow-chicken-enabled.js:
stress/spread-correct-global-object-on-exception.js:
stress/super-get-by-id.js:
stress/tailCallForwardArguments.js:
stress/to-object-intrinsic-boolean-edge.js:
stress/to-object-intrinsic-null-or-undefined-edge.js:
stress/to-object-intrinsic-number-edge.js:
stress/to-object-intrinsic-object-edge.js:
stress/to-object-intrinsic-string-edge.js:
stress/to-object-intrinsic-symbol-edge.js:
stress/to-object-intrinsic.js:
stress/try-catch-custom-getter-as-get-by-id.js:
stress/try-get-by-id-poly-proto.js:
stress/try-get-by-id-should-spill-registers-dfg.js:
stress/try-get-by-id.js:
typeProfiler/arrow-functions.js:
typeProfiler/basic.js:
typeProfiler/captured.js:
typeProfiler/classes.js:
typeProfiler/dfg-jit-optimizations.js:
typeProfiler/dictionary-mode.js:
typeProfiler/es6-block-scoping.js:
typeProfiler/es6-classes.js:
typeProfiler/inheritance.js:
typeProfiler/int52-dfg.js:
typeProfiler/loop.js:
typeProfiler/optional-fields.js:
typeProfiler/overflow.js:
typeProfiler/return.js:
typeProfiler/symbol.js:
typeProfiler/weird-prototype-chain.js:

Source/JavaScriptCore:

Also removed setElementRoot() which was not used.

jsc.cpp:

(GlobalObject::finishCreation):
(WTF::Element::Element): Deleted.
(WTF::Element::root const): Deleted.
(WTF::Element::setRoot): Deleted.
(WTF::Element::create): Deleted.
(WTF::Element::visitChildren): Deleted.
(WTF::Element::createStructure): Deleted.
(WTF::Root::Root): Deleted.
(WTF::Root::element): Deleted.
(WTF::Root::setElement): Deleted.
(WTF::Root::create): Deleted.
(WTF::Root::createStructure): Deleted.
(WTF::Root::visitChildren): Deleted.
(WTF::ImpureGetter::ImpureGetter): Deleted.
(WTF::ImpureGetter::createStructure): Deleted.
(WTF::ImpureGetter::create): Deleted.
(WTF::ImpureGetter::finishCreation): Deleted.
(WTF::ImpureGetter::getOwnPropertySlot): Deleted.
(WTF::ImpureGetter::visitChildren): Deleted.
(WTF::ImpureGetter::setDelegate): Deleted.
(WTF::CustomGetter::CustomGetter): Deleted.
(WTF::CustomGetter::createStructure): Deleted.
(WTF::CustomGetter::create): Deleted.
(WTF::CustomGetter::getOwnPropertySlot): Deleted.
(WTF::CustomGetter::customGetter): Deleted.
(WTF::CustomGetter::customGetterAcessor): Deleted.
(WTF::RuntimeArray::create): Deleted.
(WTF::RuntimeArray::~RuntimeArray): Deleted.
(WTF::RuntimeArray::destroy): Deleted.
(WTF::RuntimeArray::getOwnPropertySlot): Deleted.
(WTF::RuntimeArray::getOwnPropertySlotByIndex): Deleted.
(WTF::RuntimeArray::put): Deleted.
(WTF::RuntimeArray::deleteProperty): Deleted.
(WTF::RuntimeArray::getLength const): Deleted.
(WTF::RuntimeArray::createPrototype): Deleted.
(WTF::RuntimeArray::createStructure): Deleted.
(WTF::RuntimeArray::finishCreation): Deleted.
(WTF::RuntimeArray::RuntimeArray): Deleted.
(WTF::RuntimeArray::lengthGetter): Deleted.
(WTF::SimpleObject::SimpleObject): Deleted.
(WTF::SimpleObject::create): Deleted.
(WTF::SimpleObject::visitChildren): Deleted.
(WTF::SimpleObject::createStructure): Deleted.
(WTF::SimpleObject::hiddenValue): Deleted.
(WTF::SimpleObject::setHiddenValue): Deleted.
(WTF::DOMJITNode::DOMJITNode): Deleted.
(WTF::DOMJITNode::createStructure): Deleted.
(WTF::DOMJITNode::checkSubClassSnippet): Deleted.
(WTF::DOMJITNode::create): Deleted.
(WTF::DOMJITNode::value const): Deleted.
(WTF::DOMJITNode::offsetOfValue): Deleted.
(WTF::DOMJITGetter::DOMJITGetter): Deleted.
(WTF::DOMJITGetter::createStructure): Deleted.
(WTF::DOMJITGetter::create): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetter::customGetter): Deleted.
(WTF::DOMJITGetter::finishCreation): Deleted.
(WTF::DOMJITGetterComplex::DOMJITGetterComplex): Deleted.
(WTF::DOMJITGetterComplex::createStructure): Deleted.
(WTF::DOMJITGetterComplex::create): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterComplex::functionEnableException): Deleted.
(WTF::DOMJITGetterComplex::customGetter): Deleted.
(WTF::DOMJITGetterComplex::finishCreation): Deleted.
(WTF::DOMJITFunctionObject::DOMJITFunctionObject): Deleted.
(WTF::DOMJITFunctionObject::createStructure): Deleted.
(WTF::DOMJITFunctionObject::create): Deleted.
(WTF::DOMJITFunctionObject::safeFunction): Deleted.
(WTF::DOMJITFunctionObject::unsafeFunction): Deleted.
(WTF::DOMJITFunctionObject::checkSubClassSnippet): Deleted.
(WTF::DOMJITFunctionObject::finishCreation): Deleted.
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject): Deleted.
(WTF::DOMJITCheckSubClassObject::createStructure): Deleted.
(WTF::DOMJITCheckSubClassObject::create): Deleted.
(WTF::DOMJITCheckSubClassObject::safeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::unsafeFunction): Deleted.
(WTF::DOMJITCheckSubClassObject::finishCreation): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject): Deleted.
(WTF::DOMJITGetterBaseJSObject::createStructure): Deleted.
(WTF::DOMJITGetterBaseJSObject::create): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall): Deleted.
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::customGetter): Deleted.
(WTF::DOMJITGetterBaseJSObject::finishCreation): Deleted.
(WTF::Element::handleOwner): Deleted.
(WTF::Element::finishCreation): Deleted.
(JSTestCustomGetterSetter::JSTestCustomGetterSetter): Deleted.
(JSTestCustomGetterSetter::create): Deleted.
(JSTestCustomGetterSetter::createStructure): Deleted.
(customGetAccessor): Deleted.
(customGetValue): Deleted.
(customSetAccessor): Deleted.
(customSetValue): Deleted.
(JSTestCustomGetterSetter::finishCreation): Deleted.
(GlobalObject::addConstructableFunction): Deleted.
(functionCreateRoot): Deleted.
(functionCreateElement): Deleted.
(functionGetElement): Deleted.
(functionSetElementRoot): Deleted.
(functionCreateSimpleObject): Deleted.
(functionGetHiddenValue): Deleted.
(functionSetHiddenValue): Deleted.
(functionCreateProxy): Deleted.
(functionCreateRuntimeArray): Deleted.
(functionCreateImpureGetter): Deleted.
(functionCreateCustomGetterObject): Deleted.
(functionCreateDOMJITNodeObject): Deleted.
(functionCreateDOMJITGetterObject): Deleted.
(functionCreateDOMJITGetterComplexObject): Deleted.
(functionCreateDOMJITFunctionObject): Deleted.
(functionCreateDOMJITCheckSubClassObject): Deleted.
(functionCreateDOMJITGetterBaseJSObject): Deleted.
(functionSetImpureGetterDelegate): Deleted.
(functionGetGetterSetter): Deleted.
(functionShadowChickenFunctionsOnStack): Deleted.
(functionSetGlobalConstRedeclarationShouldNotThrow): Deleted.
(functionGlobalObjectForObject): Deleted.
(functionLoadGetterFromGetterSetter): Deleted.
(functionCreateCustomTestGetterSetter): Deleted.
(functionAbort): Deleted.
(functionFindTypeForExpression): Deleted.
(functionReturnTypeFor): Deleted.
(functionDumpBasicBlockExecutionRanges): Deleted.
(functionHasBasicBlockExecuted): Deleted.
(functionBasicBlockExecutionCount): Deleted.
(functionEnableExceptionFuzz): Deleted.
(functionCreateBuiltin): Deleted.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

tools/JSDollarVM.cpp:

(WTF::Element::Element):
(WTF::Element::root const):
(WTF::Element::setRoot):
(WTF::Element::create):
(WTF::Element::visitChildren):
(WTF::Element::createStructure):
(WTF::Root::Root):
(WTF::Root::element):
(WTF::Root::setElement):
(WTF::Root::create):
(WTF::Root::createStructure):
(WTF::Root::visitChildren):
(WTF::SimpleObject::SimpleObject):
(WTF::SimpleObject::create):
(WTF::SimpleObject::visitChildren):
(WTF::SimpleObject::createStructure):
(WTF::SimpleObject::hiddenValue):
(WTF::SimpleObject::setHiddenValue):
(WTF::ImpureGetter::ImpureGetter):
(WTF::ImpureGetter::createStructure):
(WTF::ImpureGetter::create):
(WTF::ImpureGetter::finishCreation):
(WTF::ImpureGetter::getOwnPropertySlot):
(WTF::ImpureGetter::visitChildren):
(WTF::ImpureGetter::setDelegate):
(WTF::CustomGetter::CustomGetter):
(WTF::CustomGetter::createStructure):
(WTF::CustomGetter::create):
(WTF::CustomGetter::getOwnPropertySlot):
(WTF::CustomGetter::customGetter):
(WTF::CustomGetter::customGetterAcessor):
(WTF::RuntimeArray::create):
(WTF::RuntimeArray::~RuntimeArray):
(WTF::RuntimeArray::destroy):
(WTF::RuntimeArray::getOwnPropertySlot):
(WTF::RuntimeArray::getOwnPropertySlotByIndex):
(WTF::RuntimeArray::put):
(WTF::RuntimeArray::deleteProperty):
(WTF::RuntimeArray::getLength const):
(WTF::RuntimeArray::createPrototype):
(WTF::RuntimeArray::createStructure):
(WTF::RuntimeArray::finishCreation):
(WTF::RuntimeArray::RuntimeArray):
(WTF::RuntimeArray::lengthGetter):
(WTF::DOMJITNode::DOMJITNode):
(WTF::DOMJITNode::createStructure):
(WTF::DOMJITNode::checkSubClassSnippet):
(WTF::DOMJITNode::create):
(WTF::DOMJITNode::value const):
(WTF::DOMJITNode::offsetOfValue):
(WTF::DOMJITGetter::DOMJITGetter):
(WTF::DOMJITGetter::createStructure):
(WTF::DOMJITGetter::create):
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetter::DOMJITAttribute::slowCall):
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetter::customGetter):
(WTF::DOMJITGetter::finishCreation):
(WTF::DOMJITGetterComplex::DOMJITGetterComplex):
(WTF::DOMJITGetterComplex::createStructure):
(WTF::DOMJITGetterComplex::create):
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterComplex::functionEnableException):
(WTF::DOMJITGetterComplex::customGetter):
(WTF::DOMJITGetterComplex::finishCreation):
(WTF::DOMJITFunctionObject::DOMJITFunctionObject):
(WTF::DOMJITFunctionObject::createStructure):
(WTF::DOMJITFunctionObject::create):
(WTF::DOMJITFunctionObject::safeFunction):
(WTF::DOMJITFunctionObject::unsafeFunction):
(WTF::DOMJITFunctionObject::checkSubClassSnippet):
(WTF::DOMJITFunctionObject::finishCreation):
(WTF::DOMJITCheckSubClassObject::DOMJITCheckSubClassObject):
(WTF::DOMJITCheckSubClassObject::createStructure):
(WTF::DOMJITCheckSubClassObject::create):
(WTF::DOMJITCheckSubClassObject::safeFunction):
(WTF::DOMJITCheckSubClassObject::unsafeFunction):
(WTF::DOMJITCheckSubClassObject::finishCreation):
(WTF::DOMJITGetterBaseJSObject::DOMJITGetterBaseJSObject):
(WTF::DOMJITGetterBaseJSObject::createStructure):
(WTF::DOMJITGetterBaseJSObject::create):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterBaseJSObject::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterBaseJSObject::customGetter):
(WTF::DOMJITGetterBaseJSObject::finishCreation):
(WTF::Message::releaseContents):
(WTF::Message::index const):
(WTF::JSTestCustomGetterSetter::JSTestCustomGetterSetter):
(WTF::JSTestCustomGetterSetter::create):
(WTF::JSTestCustomGetterSetter::createStructure):
(WTF::customGetAccessor):
(WTF::customGetValue):
(WTF::customSetAccessor):
(WTF::customSetValue):
(WTF::JSTestCustomGetterSetter::finishCreation):
(WTF::Element::handleOwner):
(WTF::Element::finishCreation):
(JSC::functionCrash):
(JSC::functionCreateProxy):
(JSC::functionCreateRuntimeArray):
(JSC::functionCreateImpureGetter):
(JSC::functionCreateCustomGetterObject):
(JSC::functionCreateDOMJITNodeObject):
(JSC::functionCreateDOMJITGetterObject):
(JSC::functionCreateDOMJITGetterComplexObject):
(JSC::functionCreateDOMJITFunctionObject):
(JSC::functionCreateDOMJITCheckSubClassObject):
(JSC::functionCreateDOMJITGetterBaseJSObject):
(JSC::functionSetImpureGetterDelegate):
(JSC::functionCreateBuiltin):
(JSC::functionCreateRoot):
(JSC::functionCreateElement):
(JSC::functionGetElement):
(JSC::functionCreateSimpleObject):
(JSC::functionGetHiddenValue):
(JSC::functionSetHiddenValue):
(JSC::functionShadowChickenFunctionsOnStack):
(JSC::functionSetGlobalConstRedeclarationShouldNotThrow):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionDumpBasicBlockExecutionRanges):
(JSC::functionHasBasicBlockExecuted):
(JSC::functionBasicBlockExecutionCount):
(JSC::functionEnableExceptionFuzz):
(JSC::functionGlobalObjectForObject):
(JSC::functionGetGetterSetter):
(JSC::functionLoadGetterFromGetterSetter):
(JSC::functionCreateCustomTestGetterSetter):
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):

tools/JSDollarVM.h:

(JSC::JSDollarVM::create):

Tools:

Always set --useDollarVM=true for jsc runs of benchmarks. This is needed because
some microbenchmarks relies on createBuiltin().

Also set --useDollarVM=true for runExceptionFuzz and runExecutableAllocationFuzz.

Scripts/run-jsc-benchmarks:
Scripts/run-jsc-stress-tests:

LayoutTests:

js/script-tests/stack-trace.js:
js/stack-trace-expected.txt:

1:45 AM Changeset in webkit [225128] by graouts@webkit.org

9 edits
8 adds in trunk

Source/WebCore:
[Web Animations] Perform accelerated animations when possible
https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

When we're entering and leaving the active duration of an animation effect, we now check
whether the animation can be accelerated, using the existing CSSPropertyAnimation::animationOfPropertyIsAccelerated()
utility, and start and stop animations using the startAnimation() and animationFinished() functions on RenderBoxModelObject.

This patch is only a first step towards full support for accelerated animations,
there are two known issues at the moment. Because we're not blending the styles to perform
the animation, getComputedStyle() will not return the animated value (webkit.org/b/179974).
Additionally, if other animations happen to run later during the active state of an animation
that can run accelerated, we will not fall back to software-only animation for this
element and these animations will appear not to run (webkit.org/b/179975). These will be
addressed in follow-up patches.

Tests: webanimations/left-and-opacity-animation-yields-no-compositing.html

webanimations/opacity-animation-no-longer-composited-upon-completion.html
webanimations/opacity-animation-yields-compositing.html
webanimations/width-and-opacity-separate-animation-yields-no-compositing.html

animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::updateAnimations): Check in the map of pending accelerated animations
to see if any animation requires toggling their active state after their styles have been invalidated.
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange): New function to
let animations indicate that they need to have their accelerated backing animation toggled after
style invalidation has been completed.
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated): This function is used
in RenderLayerCompositor::requiresCompositingForAnimation() to identify whether an element requires
hardware compositing due to running accelerated animations. We check all running animations for the
provided element to see if they can all be running accelerated and return true in this situation only.

animation/DocumentTimeline.h:
animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::applyAtLocalTime): Identify if we're crossing into or out of the active state
for an animation and check if it will be or has been running accelerated such that we can notify the
DocumentTimeline, through the associated animation, that the accelerated backing animation will need to
be toggled after style invalidation has been completed.
(WebCore::KeyframeEffect::shouldRunAccelerated): Check that all properties for this animation
effect can be accelerated according to CSSPropertyAnimation::animationOfPropertyIsAccelerated().
(WebCore::KeyframeEffect::startOrStopAccelerated): Start or stop the associated accelerated
animation through the associated element's RenderBoxModelObject renderer.

animation/KeyframeEffect.h:
animation/WebAnimation.cpp:

(WebCore::WebAnimation::acceleratedRunningStateDidChange): Called from AnimationEffect::applyAtLocalTime(),
we forward to the DocumentTimeline the information that the animation will cross an active state boundary while
allowing to be backed by hardware compositing.
(WebCore::WebAnimation::startOrStopAccelerated): Forward to the associated KeyframeEffect that accelerated
animation backing should be toggled.

animation/WebAnimation.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const): Check via the renderer's element's
DocumentTimeline that all running animations for this particular element are accelerated to ensure that
the element will be hardware-composited.

LayoutTests:
[Web Animations] Perform hardware-composited animations when possible
https://bugs.webkit.org/show_bug.cgi?id=179973
<rdar://problem/34953922>

Reviewed by Dean Jackson.

Add a series of tests to check that we use hardware-compositing for animations when possible.
Specifically, we check that:

Specifying both accelerated and non-accelerated properties for a single animation does *not*

yield hardware compositing (left-and-opacity-animation-yields-no-compositing.html).

Specifying both accelerated and non-accelerated properties via multiple animations does *not*

yield hardware compositing (width-and-opacity-separate-animation-yields-no-compositing.html).

Specifying only accelerated properties *does* yield hardware compositing

(opacity-animation-yields-compositing.html).

Hardware-composited animations no longer enforce hardware compositing after their completion

(opacity-animation-no-longer-composited-upon-completion.html).

webanimations/left-and-opacity-animation-yields-no-compositing-expected.txt: Added.
webanimations/left-and-opacity-animation-yields-no-compositing.html: Added.
webanimations/opacity-animation-no-longer-composited-upon-completion-expected.txt: Added.
webanimations/opacity-animation-no-longer-composited-upon-completion.html: Added.
webanimations/opacity-animation-yields-compositing-expected.txt: Added.
webanimations/opacity-animation-yields-compositing.html: Added.
webanimations/width-and-opacity-separate-animation-yields-no-compositing-expected.txt: Added.
webanimations/width-and-opacity-separate-animation-yields-no-compositing.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed