Timeline
Jan 16, 2018:
- 11:14 PM Changeset in webkit [227049] by
-
- 13 edits in trunk
[CMake] Remove WebCoreDerivedSources library target
https://bugs.webkit.org/show_bug.cgi?id=181664
Patch by Fujii Hironori <Fujii Hironori> on 2018-01-16
Reviewed by Carlos Garcia Campos.
Source/WebCore:
After unified source build has been introduced, CMake Visual
Studio build suffers complicated unnecessary recompilation issues
because Visual Studio invokes scripts twice in both WebCore and
WebCoreDerivedSources projects (Bug 181117).
WebCoreDerivedSources library has been introduced in r198766 to
avoid command line length limit of CMake Ninja build on macOS.
Fortunately, unified source build has reduced the number of source
files to compile, WebCore doesn't need to be split anymore.
No new tests (No behavior change)
- CMakeLists.txt: Replaced WebCore_DERIVED_SOURCES with WebCore_SOURCES. Removed WebCoreDerivedSources library target.
Do not compile each JavaScript Builtins.cpp files because the unified source WebCoreJSBuiltins.cpp is already included.
- PlatformGTK.cmake: Replaced WebCore_DERIVED_SOURCES with WebCore_SOURCES.
- PlatformWin.cmake: Ditto.
Source/WebKit:
- CMakeLists.txt: Do not link WebCoreDerivedSources.
- PlatformGTK.cmake: Appended WebCore after WebCorePlatformGTK in WebKit_LIBRARIES.
- PlatformWin.cmake: Ditto.
Source/WebKitLegacy:
- PlatformWin.cmake: Do not link WebCoreDerivedSources.
Tools:
- TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
- TestWebKitAPI/PlatformWin.cmake: Ditto.
- 11:04 PM Changeset in webkit [227048] by
-
- 3 edits in trunk/Tools
Move Debug Test262, Release Test262 and Performance queues to Sierra
https://bugs.webkit.org/show_bug.cgi?id=181692
Unreviewed
- 9:40 PM Changeset in webkit [227047] by
-
- 3 edits in trunk/Source/JavaScriptCore
Allow dangerous disabling of poison
https://bugs.webkit.org/show_bug.cgi?id=181685
<rdar://problem/36546265>
Reviewed by Keith Miller.
Some tools such as leak detectors and such like to look at real
pointers, and poisoned ones confuse them. Add a JSC option to
disable poisoning, but log to the console when this is done.
- runtime/JSCPoison.cpp:
(JSC::initializePoison):
- runtime/Options.h:
- 9:38 PM Changeset in webkit [227046] by
-
- 2 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r226880. rdar://problem/36569616
- 9:05 PM Changeset in webkit [227045] by
-
- 3 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r227010. rdar://problem/36567991
- 9:05 PM Changeset in webkit [227044] by
-
- 2 edits in branches/safari-605-branch/Source/WebInspectorUI
Cherry-pick r226995. rdar://problem/36568070
- 9:05 PM Changeset in webkit [227043] by
-
- 7 edits2 adds in branches/safari-605-branch
Cherry-pick r226916. rdar://problem/36568057
- 9:05 PM Changeset in webkit [227042] by
-
- 3 edits2 adds in branches/safari-605-branch
Cherry-pick r227009. rdar://problem/36567976
- 9:05 PM Changeset in webkit [227041] by
-
- 4 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r227006. rdar://problem/36567998
- 9:04 PM Changeset in webkit [227040] by
-
- 2 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r227000. rdar://problem/36567987
- 9:04 PM Changeset in webkit [227039] by
-
- 2 edits in branches/safari-605-branch/Source/WebInspectorUI
Cherry-pick r226996. rdar://problem/36568089
- 9:04 PM Changeset in webkit [227038] by
-
- 2 edits in branches/safari-605-branch/Source/WebInspectorUI
Cherry-pick r226994. rdar://problem/36568074
- 9:04 PM Changeset in webkit [227037] by
-
- 13 edits in branches/safari-605-branch
Cherry-pick r226993. rdar://problem/36567965
- 9:04 PM Changeset in webkit [227036] by
-
- 2 edits in branches/safari-605-branch/Source/WebInspectorUI
Cherry-pick r226992. rdar://problem/36568053
- 9:04 PM Changeset in webkit [227035] by
-
- 15 edits1 add in branches/safari-605-branch/Source
Cherry-pick r226990. rdar://problem/36568066
- 9:04 PM Changeset in webkit [227034] by
-
- 2 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r226982. rdar://problem/36567983
- 9:04 PM Changeset in webkit [227033] by
-
- 2 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r226951. rdar://problem/36568098
- 9:04 PM Changeset in webkit [227032] by
-
- 2 edits in branches/safari-605-branch/Source/WebKit
Cherry-pick r226946. rdar://problem/36568013
- 9:04 PM Changeset in webkit [227031] by
-
- 2 edits in branches/safari-605-branch/Source/JavaScriptCore
Cherry-pick r226942. rdar://problem/36567945
- 9:04 PM Changeset in webkit [227030] by
-
- 10 edits4 adds in branches/safari-605-branch
Cherry-pick r226930. rdar://problem/36567972
- 9:04 PM Changeset in webkit [227029] by
-
- 4 edits in branches/safari-605-branch
Cherry-pick r226929. rdar://problem/36567962
- 9:04 PM Changeset in webkit [227028] by
-
- 17 edits in branches/safari-605-branch/Source/JavaScriptCore
Cherry-pick r226928. rdar://problem/36567945
- 9:04 PM Changeset in webkit [227027] by
-
- 28 edits1 copy in branches/safari-605-branch/Source
Cherry-pick r226920. rdar://problem/36567951
- 9:04 PM Changeset in webkit [227026] by
-
- 2 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r226919. rdar://problem/36567968
- 9:04 PM Changeset in webkit [227025] by
-
- 3 edits2 adds in branches/safari-605-branch
Cherry-pick r226908. rdar://problem/36568060
- 9:04 PM Changeset in webkit [227024] by
-
- 14 edits1 add in branches/safari-605-branch
Cherry-pick r226907. rdar://problem/36567949
- 9:04 PM Changeset in webkit [227023] by
-
- 12 edits in branches/safari-605-branch
Cherry-pick r226906. rdar://problem/36568006
- 9:03 PM Changeset in webkit [227022] by
-
- 19 edits5 adds in branches/safari-605-branch
Cherry-pick r226904. rdar://problem/36568017
- 9:03 PM Changeset in webkit [227021] by
-
- 3 edits in branches/safari-605-branch/LayoutTests
Cherry-pick r226902. rdar://problem/36567966
- 9:03 PM Changeset in webkit [227020] by
-
- 2 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r226898. rdar://problem/36568103
- 9:03 PM Changeset in webkit [227019] by
-
- 3 edits in branches/safari-605-branch/Source/JavaScriptCore
Cherry-pick r226895. rdar://problem/36568085
- 9:03 PM Changeset in webkit [227018] by
-
- 3 edits1 add in branches/safari-605-branch
Cherry-pick r226881. rdar://problem/36567948
- 9:03 PM Changeset in webkit [227017] by
-
- 6 edits4 adds in branches/safari-605-branch
Cherry-pick r226842. rdar://problem/36568025
- 9:03 PM Changeset in webkit [227016] by
-
- 3 edits in branches/safari-605-branch/Source/WebInspectorUI
Cherry-pick r226821. rdar://problem/36568038
- 9:03 PM Changeset in webkit [227015] by
-
- 5 edits1 add in branches/safari-605-branch
Cherry-pick r226806. rdar://problem/36567946
- 9:03 PM Changeset in webkit [227014] by
-
- 9 edits in branches/safari-605-branch/Source
Cherry-pick r226790. rdar://problem/36568094
- 9:03 PM Changeset in webkit [227013] by
-
- 3 edits in branches/safari-605-branch/Source/WebInspectorUI
Cherry-pick r226765. rdar://problem/36568045
- 9:03 PM Changeset in webkit [227012] by
-
- 2 edits in branches/safari-605-branch/Source/WebInspectorUI
Cherry-pick r226674. rdar://problem/36568078
- 5:34 PM Changeset in webkit [227011] by
-
- 5 edits2 adds in trunk
Can't scroll iframe after toggling it to display:none and back
https://bugs.webkit.org/show_bug.cgi?id=181708
rdar://problem/13234778
Reviewed by Tim Horton.
Source/WebCore:
Nothing updated the FrameView's set of scrollable areas when a subframe came back from display:none.
Mirror the existing virtual removeChild() by making addChild() virtual, and using it to mark
the FrameView's scrollable area set as dirty.
Test: tiled-drawing/scrolling/non-fast-region/non-fast-scrollable-region-hide-show-iframe.html
- page/FrameView.cpp:
(WebCore::FrameView::addChild):
- page/FrameView.h:
- platform/ScrollView.h:
LayoutTests:
- tiled-drawing/scrolling/non-fast-region/non-fast-scrollable-region-hide-show-iframe-expected.txt: Added.
- tiled-drawing/scrolling/non-fast-region/non-fast-scrollable-region-hide-show-iframe.html: Added.
- 4:49 PM Changeset in webkit [227010] by
-
- 3 edits in trunk/Source/WebCore
SWServerWorker::m_contextConnectionIdentifier may get out of date
https://bugs.webkit.org/show_bug.cgi?id=181687
<rdar://problem/36548111>
Reviewed by Brady Eidson.
SWServerWorker::m_contextConnectionIdentifier may get out of date. This happens when the
context process crashes and is relaunched.
No new tests, added assertion in terminateWorkerInternal() that hits without this fix.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::runServiceWorker):
(WebCore::SWServer::terminateWorkerInternal):
(WebCore::SWServer::unregisterServiceWorkerClient):
- workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::setContextConnectionIdentifier):
- 4:04 PM Changeset in webkit [227009] by
-
- 3 edits2 adds in trunk
Reset MediaSourcePrivateAVFObjC's m_sourceBufferWithSelectedVideo when the underlying SourceBufferPrivate is removed.
https://bugs.webkit.org/show_bug.cgi?id=181707
<rdar://problem/34809474>
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/media-source/media-source-remove-unload-crash.html
- platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:
(WebCore::MediaSourcePrivateAVFObjC::removeSourceBuffer):
LayoutTests:
- media/media-source/media-source-remove-unload-crash-expected.txt: Added.
- media/media-source/media-source-remove-unload-crash.html: Added.
- 3:17 PM Changeset in webkit [227008] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Canvas tab: typing a "space" in the QuickConsole shouldn't trigger a recording
https://bugs.webkit.org/show_bug.cgi?id=181706
<rdar://problem/36558221>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype._handleSpace):
- 3:08 PM Changeset in webkit [227007] by
-
- 20 edits17 copies in trunk
[WebAuthN] Implement dummy WebAuthN IDLs
https://bugs.webkit.org/show_bug.cgi?id=181627
<rdar://problem/36459864>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/credential-management/credentialscontainer-create-basics.https-expected.txt:
Source/WebCore:
This patch implements dummy WebAuthN IDLs and connect them with Credential Management as well.
All implementations in this patch are subject to change when real implementations land. The
purpose here on the other hand is to have IDLs, bindings and implementations connected. This
patch should handle all IDLs that we need.
No tests.
- CMakeLists.txt:
- DerivedSources.make:
- Modules/credentialmanagement/CredentialCreationOptions.h:
- Modules/credentialmanagement/CredentialCreationOptions.idl:
- Modules/credentialmanagement/CredentialRequestOptions.h:
- Modules/credentialmanagement/CredentialRequestOptions.idl:
- Modules/webauthn/AuthenticatorAssertionResponse.cpp: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp.
(WebCore::AuthenticatorAssertionResponse::AuthenticatorAssertionResponse):
(WebCore::AuthenticatorAssertionResponse::~AuthenticatorAssertionResponse):
(WebCore::AuthenticatorAssertionResponse::authenticatorData):
(WebCore::AuthenticatorAssertionResponse::signature):
(WebCore::AuthenticatorAssertionResponse::userHandle):
- Modules/webauthn/AuthenticatorAssertionResponse.h: Copied from Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h.
- Modules/webauthn/AuthenticatorAssertionResponse.idl: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
- Modules/webauthn/AuthenticatorAttestationResponse.cpp: Copied from Source/WebCore/Modules/credentialmanagement/CredentialCreationOptions.h.
(WebCore::AuthenticatorAttestationResponse::AuthenticatorAttestationResponse):
(WebCore::AuthenticatorAttestationResponse::~AuthenticatorAttestationResponse):
(WebCore::AuthenticatorAttestationResponse::attestationObject):
- Modules/webauthn/AuthenticatorAttestationResponse.h: Copied from Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h.
- Modules/webauthn/AuthenticatorAttestationResponse.idl: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
- Modules/webauthn/AuthenticatorResponse.cpp: Copied from Source/WebCore/Modules/credentialmanagement/CredentialCreationOptions.h.
(WebCore::AuthenticatorResponse::AuthenticatorResponse):
(WebCore::AuthenticatorResponse::~AuthenticatorResponse):
(WebCore::AuthenticatorResponse::clientDataJSON):
- Modules/webauthn/AuthenticatorResponse.h: Copied from Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h.
- Modules/webauthn/AuthenticatorResponse.idl: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
- Modules/webauthn/PublicKeyCredential.cpp:
(WebCore::PublicKeyCredential::rawId):
(WebCore::PublicKeyCredential::response):
(WebCore::PublicKeyCredential::getClientExtensionResults):
(WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable):
- Modules/webauthn/PublicKeyCredential.h:
- Modules/webauthn/PublicKeyCredential.idl:
- Modules/webauthn/PublicKeyCredentialCreationOptions.h: Copied from Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h.
- Modules/webauthn/PublicKeyCredentialCreationOptions.idl: Added.
- Modules/webauthn/PublicKeyCredentialDescriptor.h: Copied from Source/WebCore/Modules/credentialmanagement/CredentialCreationOptions.h.
- Modules/webauthn/PublicKeyCredentialDescriptor.idl: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
- Modules/webauthn/PublicKeyCredentialRequestOptions.h: Copied from Source/WebCore/Modules/credentialmanagement/CredentialCreationOptions.h.
- Modules/webauthn/PublicKeyCredentialRequestOptions.idl: Copied from Source/WebCore/Modules/credentialmanagement/CredentialRequestOptions.h.
- Modules/webauthn/PublicKeyCredentialType.h: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
- Modules/webauthn/PublicKeyCredentialType.idl: Copied from Source/WebCore/Modules/webauthn/PublicKeyCredential.idl.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
LayoutTests:
Modify some tests to reflect the update.
- http/wpt/credential-management/credentialscontainer-create-basics.https-expected.txt:
- http/wpt/credential-management/credentialscontainer-create-basics.https.html:
- http/wpt/credential-management/credentialscontainer-get-basics.https-expected.txt:
- http/wpt/credential-management/credentialscontainer-get-basics.https.html:
- 3:06 PM Changeset in webkit [227006] by
-
- 4 edits in trunk/Source/WebCore
AX: Do not trigger layout in updateBackingStore() unless it is safe to do so
https://bugs.webkit.org/show_bug.cgi?id=181703
<rdar://problem/36365706>
Reviewed by Ryosuke Niwa.
Document::isSafeToUpdateStyleOrLayout() can tell whether it is safe to run layout.
Unable to create test with WebInspector involved.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::updateBackingStore):
- dom/Document.cpp:
(WebCore::Document::isSafeToUpdateStyleOrLayout const):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayout):
(WebCore::isSafeToUpdateStyleOrLayout): Deleted.
- dom/Document.h:
- 2:52 PM Changeset in webkit [227005] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r226962.
The LayoutTest added with this change is a flaky timeout.
Reverted changeset:
"Support for preconnect Link headers"
https://bugs.webkit.org/show_bug.cgi?id=181657
https://trac.webkit.org/changeset/226962
- 2:35 PM Changeset in webkit [227004] by
-
- 7 edits6 deletes in trunk
Unreviewed, rolling out r226937.
Tests added with this change are failing due to a missing
exception check.
Reverted changeset:
"[JSC] NumberPrototype::extractRadixFromArgs incorrectly cast
double to int32_t"
https://bugs.webkit.org/show_bug.cgi?id=181182
https://trac.webkit.org/changeset/226937
- 2:26 PM Changeset in webkit [227003] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Make Console's Execution Context picker stand out when it is non-default
https://bugs.webkit.org/show_bug.cgi?id=181628
<rdar://problem/36492044>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-16
Reviewed by Matt Baker.
- UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component > .selector-arrows):
- UserInterface/Views/HierarchicalPathComponent.js:
(WI.HierarchicalPathComponent.prototype.set selectorArrows):
Switch to SVG element so we can style the arrows.
- UserInterface/Views/QuickConsole.css:
(.quick-console > .navigation-bar > .hierarchical-path .execution-context):
(.quick-console > .navigation-bar > .hierarchical-path .execution-context .separator):
(.quick-console > .navigation-bar > .hierarchical-path.non-default-execution-context .execution-context):
(.quick-console > .navigation-bar > .hierarchical-path.non-default-execution-context .execution-context .selector-arrows):
Styles for the execution context picker. We hide the unused separator
and instead use margin so that the selected background and border don't
have an extra 7px on the right/end side.
- UserInterface/Views/QuickConsole.js:
(WI.QuickConsole.prototype._activeExecutionContextChanged):
Toggle the non-default class name on the path.
- 2:04 PM Changeset in webkit [227002] by
-
- 2 edits in branches/safari-605-branch/Source/WTF
Cherry-pick r226983. rdar://problem/36480409
- 1:58 PM Changeset in webkit [227001] by
-
- 12 edits in trunk/Source/WebKit
Merge sync and async code paths for getting context menus
https://bugs.webkit.org/show_bug.cgi?id=181423
Reviewed by Joseph Pecoraro.
What a mess. We had a code path for asynchronous context menu generation and a different one for synchronous context menu generation.
This makes it so there is just one. At the API level we see if there is an asynchronous delegate to call, then synchronous.
There is a subtle theoretical change in behaviour because m_page.contextMenuClient().showContextMenu is now called for the asynchronous
case and it wasn't before, but the one C API client that uses this has nullptr as it's WKPageShowContextMenuCallback, so we won't break anything!
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::getContextMenuFromProposedMenu):
(API::ContextMenuClient::getContextMenuFromProposedMenuAsync): Deleted.
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageContextMenuClient):
- UIProcess/API/glib/WebKitContextMenuClient.cpp:
- UIProcess/WebContextMenuProxy.h:
- UIProcess/gtk/WebContextMenuProxyGtk.cpp:
(WebKit::WebContextMenuProxyGtk::show):
(WebKit::WebContextMenuProxyGtk::showContextMenuWithItems):
- UIProcess/gtk/WebContextMenuProxyGtk.h:
- UIProcess/mac/WebContextMenuProxyMac.h:
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
(WebKit::WebContextMenuProxyMac::showContextMenu):
- UIProcess/wpe/WebContextMenuProxyWPE.h:
- 1:52 PM Changeset in webkit [227000] by
-
- 2 edits in trunk/Source/WebCore
Text looks bad on some CSS spec pages
https://bugs.webkit.org/show_bug.cgi?id=181700
rdar://problem/36552107
Reviewed by Tim Horton.
When making new tiles in a TileController, we failed to set their "supports antialiased layer text"
setting, so tile caches could end up with a mixture of layers that do and do not support
antialiased layer text.
No tests because the tiled drawing tests don't dump out tiles inside of tile caches.
- platform/graphics/ca/TileController.cpp:
(WebCore::TileController::createTileLayer):
- 1:14 PM Changeset in webkit [226999] by
-
- 7 edits in branches/safari-605-branch/Source
Versioning.
- 1:10 PM Changeset in webkit [226998] by
-
- 2 edits in tags/Safari-605.1.23/Source/WTF
Cherry-pick r226983. rdar://problem/36480409
- 1:07 PM Changeset in webkit [226997] by
-
- 1 copy in tags/Safari-605.1.23
Tag Safari-605.1.23.
- 12:54 PM Changeset in webkit [226996] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: pressing down key should select first item from completion list when focusing on empty value
https://bugs.webkit.org/show_bug.cgi?id=181633
<rdar://problem/36501797>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SpreadsheetTextField.js:
(WI.SpreadsheetTextField.prototype._updateCompletions):
- 12:31 PM Changeset in webkit [226995] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: Long value causes bad wrapping
https://bugs.webkit.org/show_bug.cgi?id=181618
<rdar://problem/36485175>
Reviewed by Joseph Pecoraro.
Wrap long values only when editing.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .value.editing):
- 12:23 PM Changeset in webkit [226994] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: clicking on the white space after the property sometimes places a blank property at the wrong index
https://bugs.webkit.org/show_bug.cgi?id=179585
<rdar://problem/35490780>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyRemoved):
Layout call is needed to update data-property-index attributes on the property views.
- 12:21 PM Changeset in webkit [226993] by
-
- 13 edits in trunk
REGRESSION(r221292): svg/animations/animateTransform-pattern-transform.html crashes with security assertion
https://bugs.webkit.org/show_bug.cgi?id=179986
Reviewed by Simon Fraser.
Source/WebCore:
This patch reverts all or parts of the following changes-sets
<http://trac.webkit.org/changeset/221292>
<http://trac.webkit.org/changeset/197967>
<http://trac.webkit.org/changeset/196670>
A JS statement like this:
var item = text.x.animVal.getItem(0);
Creates the following C++ objects:
SVGAnimatedListPropertyTearOff<SVGLengthListValues> for 'text.x'
SVGListPropertyTearOff<SVGLengthListValues> for 'text.x.animVal'
SVGPropertyTearOff<SVGLengthValue> for 'text.x.animVal.getItem(0)'
If 'item' changes, the attribute 'x' of the element '<text>' will change
as well. But this binding works only in one direction. If the attribute
'x' of the element '<text>' changes, e.g.:
text.setAttribute('x', '10,20,30');
This will detach 'item' from the element <text> and any further changes
in 'item' won't affect the attribute 'x' of element <text>.
The one direction binding can only work if this chain of tear-off objects
is kept connected. This is implemented by RefCounted back pointers from
SVGPropertyTearOff and SVGListPropertyTearOff to SVGAnimatedListPropertyTearOff.
The security crashes and the memory leaks are happening because of the
raw forward pointers:
-- SVGAnimatedListPropertyTearOff maintains raw pointers of type
SVGListPropertyTearOff for m_baseVal and m_animVal
-- The m_wrappers and m_animatedWrappers of SVGAnimatedListPropertyTearOff
are vectors of raw pointer Vector<SVGLength*>
To control the life cycle of the raw pointers, SVGListPropertyTearOff and
SVGPropertyTearOff call SVGAnimatedListPropertyTearOff::propertyWillBeDeleted()
to notify it they are going to be deleted. In propertyWillBeDeleted(), we
clear the pointers so they are not used after being freed. This mechanism
has been error-prone and we've never got it 100% right.
The solution we need to adopt with SVG tear-off objects is the following:
-- All the forward pointers should be weak pointers.
-- All the back pointers should be ref pointers.
This solution may not look intuitive but it solves the bugs and keeps the
one direction binding. The forward weak pointers allows the tear-off
objects to go aways if no reference from JS exists. The back ref pointers
maintains the chain of objects and guarantees the correct binding.
- svg/SVGPathSegList.h:
- svg/SVGTransformList.h:
- svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedListPropertyTearOff::animVal):
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
- svg/properties/SVGAnimatedProperty.h:
(WebCore::SVGAnimatedProperty::isAnimatedListTearOff const):
(WebCore::SVGAnimatedProperty::propertyWillBeDeleted): Deleted.
- svg/properties/SVGAnimatedPropertyTearOff.h:
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
- svg/properties/SVGListProperty.h:
(WebCore::SVGListProperty::initializeValuesAndWrappers):
(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):
(WebCore::SVGListProperty::appendItemValuesAndWrappers):
(WebCore::SVGListProperty::createWeakPtr const):
- svg/properties/SVGListPropertyTearOff.h:
(WebCore::SVGListPropertyTearOff::removeItemFromList):
(WebCore::SVGListPropertyTearOff::~SVGListPropertyTearOff): Deleted.
- svg/properties/SVGPropertyTearOff.h:
(WebCore::SVGPropertyTearOff::createWeakPtr const):
(WebCore::SVGPropertyTearOff::~SVGPropertyTearOff):
LayoutTests:
- svg/dom/SVGAnimatedListPropertyTearOff-leak.html:
- 12:20 PM Changeset in webkit [226992] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Network Tab - Export HAR Context Menu not working
https://bugs.webkit.org/show_bug.cgi?id=181694
<rdar://problem/36479197>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-16
Reviewed by Brian Burg.
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
Ensurethisworks in the handler.
- 11:47 AM Changeset in webkit [226991] by
-
- 4 edits in trunk/Source/WebKit
Don't link WebKit target directly to JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=181688
Reviewed by Alex Christensen.
It's safer if we only link to the next lower-layered lib in the stack, so let's just link
directly to WebCore instead.
And WPE doesn't need to specify it twice.
- CMakeLists.txt:
- PlatformMac.cmake:
- PlatformWPE.cmake:
- 11:46 AM Changeset in webkit [226990] by
-
- 15 edits1 add in trunk/Source
AVSampleBufferDisplayLayer should be flushed when application activates
https://bugs.webkit.org/show_bug.cgi?id=181623
<rdar://problem/36487738>
Reviewed by Darin Adler.
Source/WebCore:
No new tests, I wasn't able to reproduce it in a test.
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::addApplicationStateChangeListener): New.
(WebCore::Document::removeApplicationStateChangeListener): Ditto.
(WebCore::Document::forEachApplicationStateChangeListener): Ditto.
- dom/Document.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::registerWithDocument): Register for application state changes.
(WebCore::HTMLMediaElement::unregisterWithDocument): Unregister.
(WebCore::HTMLMediaElement::applicationWillResignActive): Pass through to the player.
(WebCore::HTMLMediaElement::applicationDidBecomeActive): Ditto.
- html/HTMLMediaElement.h:
- page/ApplicationStateChangeListener.h: Added.
(WebCore::ApplicationStateChangeListener::applicationWillResignActive):
(WebCore::ApplicationStateChangeListener::applicationDidBecomeActive):
- page/Page.cpp:
(WebCore::Page::forEachDocument):
(WebCore::Page::applicationWillResignActive):
(WebCore::Page::applicationDidEnterBackground):
(WebCore::Page::applicationWillEnterForeground):
(WebCore::Page::applicationDidBecomeActive):
- page/Page.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::applicationWillResignActive):
(WebCore::MediaPlayer::applicationDidBecomeActive):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::applicationWillResignActive):
(WebCore::MediaPlayerPrivateInterface::applicationDidBecomeActive):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC): Switch
to release logging.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueCorrectedVideoSample): Split out of enqueueVideoSample.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample): Move code that updates
the display later to enqueueCorrectedVideoSample. Rearrange logic to the image painter sample
buffer has the correct timestamp.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layerErrorDidChange): Switch to release logging.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layerStatusDidChange): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::applicationDidBecomeActive): f the display
layer is in the "failed" state, flush the renderer and update the display mode.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayers): Switch to release logging.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::prepareToPlay): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateDisplayMode): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVolume): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setMuted): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateReadyState) Ditto.:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::logChannel const): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateSampleTimes): Deleted.
Source/WebKit:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationWillResignActive): Call page.
(WebKit::WebPage::applicationDidEnterBackground): Ditto, let it call libWebRTCProvider.
(WebKit::WebPage::applicationWillEnterForeground): Call page.
(WebKit::WebPage::applicationDidBecomeActive): Ditto, let it call libWebRTCProvider.
- 11:41 AM Changeset in webkit [226989] by
-
- 4 edits in trunk/Source/WebCore
PAL should link to JavaScriptCore rather than WTF
https://bugs.webkit.org/show_bug.cgi?id=181683
Reviewed by Konstantin Tokarev.
Source/WebCore:
Do not link directly to JavaScriptCore. Get it via PAL.
- CMakeLists.txt:
Source/WebCore/PAL:
Currently we are accidentally linking WTF into both libjavascriptcoregtk and libwebkit2gtk,
which could in theory cause problems similar to bug #179914. There are only two possible
solutions:
- Ensure WTF always built as a shared library if JavaScriptCore is built as a shared library
- Change PAL to link to JavaScriptCore instead of WTF
The problem here is caused by layer hopping. It can never be a problem if each library only
links to the next lowest-layered library.
The downside is this allows PAL to use JavaScriptCore symbols, which is not super desirable.
I came up with a hack yesterday for PAL to link to WTF usually, but link to JavaScriptCore
instead if ${JavaScriptCore_LIBRARY_TYPE} MATCHES "SHARED" AND ${WTF_LIBRARY_TYPE} MATCHES
"STATIC". But that is getting too complex and introduces more possibility for platform-
dependent build failures. Better to just accept that PAL will depend on JavaScriptCore.
Note: I'm not brave enough to update the XCode build. We can use that to enforce that no
JavaScriptCore symbols actually get used, I guess....
- pal/CMakeLists.txt:
- 11:26 AM Changeset in webkit [226988] by
-
- 2 edits in tags/Safari-606.1.1.1/Source/WebCore
Cherry-pick r226915. rdar://problem/36480797
- 11:26 AM Changeset in webkit [226987] by
-
- 6 edits2 adds in tags/Safari-606.1.1.1
Cherry-pick r226796. rdar://problem/35947650
- 11:26 AM Changeset in webkit [226986] by
-
- 6 edits in tags/Safari-606.1.1.1
Cherry-pick r226787. rdar://problem/36324813
- 11:25 AM Changeset in webkit [226985] by
-
- 13 edits in tags/Safari-606.1.1.1
Cherry-pick r226779. rdar://problem/36299316
- 11:12 AM Changeset in webkit [226984] by
-
- 16 edits1 copy1 add in trunk
Add pop-up policy support in website policies.
https://bugs.webkit.org/show_bug.cgi?id=181544.
rdar://problem/30521400.
Patch by Zach Li <zachli@apple.com> on 2018-01-16
Reviewed by Alex Christensen.
Source/WebCore:
- loader/DocumentLoader.h:
Introduce pop-up policy getter and setter. Initialize
the policy as Default.
(WebCore::DocumentLoader::popUpPolicy const):
(WebCore::DocumentLoader::setPopUpPolicy):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::allowPopUp):
Pop-up policy specified on a per-page basis holds
precedence over the global policy. If no pop-up policy
is specified during navigation, global policy is used.
Source/WebKit:
- Shared/WebsitePoliciesData.cpp: Encode and decode
pop-up policy.
(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):
Apply the pop-up policy from website policies to the
document loader.
- Shared/WebsitePoliciesData.h:
- Shared/WebsitePopUpPolicy.h:
Added for declaring enum WebsitePopUpPolicy.
- UIProcess/API/APIWforebsitePolicies.cpp:
Include pop-up policy in website policies.
(API::WebsitePolicies::WebsitePolicies):
(API::WebsitePolicies::data):
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/C/WKWebsitePolicies.cpp:
Added C API to get and set pop-up policy on
website policies.
(WKWebsitePoliciesGetPopUpPolicy):
(WKWebsitePoliciesSetPopUpPolicy):
- UIProcess/API/C/WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
Added Obj-C API to get and set pop-up policy
on website policies.
- UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setPopUpPolicy:]):
(-[_WKWebsitePolicies popUpPolicy]):
- WebKit.xcodeproj/project.pbxproj:
Added WebsitePopUpPolicy.h.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Added pop-up-check.html.
- TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
(-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TEST):
- 11:09 AM Changeset in webkit [226983] by
-
- 2 edits in trunk/Source/WTF
[Win] JSC compile error in runtime/DateConversion.cpp.
https://bugs.webkit.org/show_bug.cgi?id=181690
<rdar://problem/36480409>
Reviewed by Brent Fulgham.
Add 'text/win' folder to list of forwarding headers directories.
- wtf/PlatformWin.cmake:
- 11:04 AM Changeset in webkit [226982] by
-
- 2 edits in trunk/Source/WebCore
Crash playing audio-only HLS stream via hls.js (MSE)
https://bugs.webkit.org/show_bug.cgi?id=181691
<rdar://problem/32967295>
Reviewed by Eric Carlson.
Add a weak-link check to the block called by -[AVSampleBufferDisplayLayer requestMediaDataWhenReadyOnQueue:usingBlock:].
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::notifyClientWhenReadyForMoreSamples):
(WebCore::SourceBufferPrivateAVFObjC::setVideoLayer):
- 10:59 AM Changeset in webkit [226981] by
-
- 15 edits in trunk/Source/WebCore
Rename applyHorizontalScale/applyVerticalScale in SVG filters, and related cleanup
https://bugs.webkit.org/show_bug.cgi?id=181684
Reviewed by Alex Christensen.
Rename the confusing applyHorizontalScale/applyVerticalScale to scaledByFilterResolution(),
and have it take and return a FloatSize. Change callers to do math in terms of FloatSizes.
Add inflate(size) to each of the rect classes.
- platform/graphics/FloatRect.h:
(WebCore::FloatRect::inflate):
- platform/graphics/IntRect.h:
(WebCore::IntRect::inflate):
- platform/graphics/LayoutRect.h:
(WebCore::LayoutRect::inflate):
- platform/graphics/filters/FEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::platformApplySoftware):
- platform/graphics/filters/FEDropShadow.cpp:
(WebCore::FEDropShadow::determineAbsolutePaintRect):
(WebCore::FEDropShadow::platformApplySoftware):
- platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateKernelSize):
(WebCore::FEGaussianBlur::determineAbsolutePaintRect):
(WebCore::FEGaussianBlur::platformApplySoftware):
- platform/graphics/filters/FEGaussianBlur.h:
- platform/graphics/filters/FEMorphology.cpp:
(WebCore::FEMorphology::determineAbsolutePaintRect):
(WebCore::FEMorphology::platformApplySoftware):
- platform/graphics/filters/FEOffset.cpp:
(WebCore::FEOffset::determineAbsolutePaintRect):
(WebCore::FEOffset::platformApplySoftware):
- platform/graphics/filters/Filter.h:
(WebCore::Filter::setSourceImage):
(WebCore::Filter::scaledByFilterResolution const):
(WebCore::Filter::applyHorizontalScale const): Deleted.
(WebCore::Filter::applyVerticalScale const): Deleted.
- platform/graphics/filters/FilterOperations.cpp:
(WebCore::outsetSizeForBlur):
- rendering/FilterEffectRenderer.h:
- svg/graphics/filters/SVGFilter.cpp:
(WebCore::SVGFilter::scaledByFilterResolution const):
(WebCore::SVGFilter::applyHorizontalScale const): Deleted.
(WebCore::SVGFilter::applyVerticalScale const): Deleted.
- svg/graphics/filters/SVGFilter.h:
- 10:58 AM Changeset in webkit [226980] by
-
- 2 edits in trunk/PerformanceTests
Fix Mac CMake build after r222900
- MallocBench/MallocBench/CMakeLists.txt:
The mbmalloc target doesn't exist if we're not in developer mode, so only use it if we are.
- 10:55 AM Changeset in webkit [226979] by
-
- 7 edits in trunk/Source
[CMake][Mac] Fix the build errors
https://bugs.webkit.org/show_bug.cgi?id=181665
Patch by Fujii Hironori <Fujii Hironori> on 2018-01-16
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (No behavior change)
- CMakeLists.txt: Added Modules/paymentrequest/MerchantValidationEvent.idl to compile.
- PlatformMac.cmake: Added Modules/paymentrequest/MerchantValidationEvent.cpp to compile.
Added workers/service/context and Modules/applicationmanifest as forwarding header paths.
Source/WebKit:
- CMakeLists.txt: Added TouchBarMenuData.cpp and TouchBarMenuItemData.cpp to compile.
- PlatformMac.cmake: Added _WKApplicationManifest.mm, WKInspectorWKWebView.mm and WKInspectorWindow.mm to compile.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _webPageContentProcessCount]): Call WebProcessPool::serviceWorkerProxy() only if ENABLE(SERVICE_WORKER).
- 10:52 AM Changeset in webkit [226978] by
-
- 7 edits in tags/Safari-606.1.1.1/Source
Versioning.
- 10:46 AM Changeset in webkit [226977] by
-
- 19 edits in trunk
[Attachment Support] Provide the
srcof an attachment to the UI delegate when an attachment is inserted
https://bugs.webkit.org/show_bug.cgi?id=181638
<rdar://problem/36508702>
Reviewed by Dan Bernstein.
Source/WebCore:
Adjust the
didInsertAttachmentcodepath to additionally propagate the attachment element'ssrc.
Additionally, fix an issue with insertion and removal client notifications wherein the client can receive
insertion calls without corresponding removal calls, or vice versa. This is an existing issue, but matters more
now because we actually need to access the attachment element for itssrcwhen propagating changes to the
client. See below for details.
Test: WKAttachmentTests.AttachmentUpdatesWhenInsertingRichMarkup
- dom/Document.h:
(WebCore::Document::attachmentElementsByIdentifier const):
- editing/Editor.cpp:
(WebCore::Editor::notifyClientOfAttachmentUpdates):
- page/EditorClient.h:
(WebCore::EditorClient::didInsertAttachment):
- page/Frame.cpp:
(WebCore::Frame::setDocument):
When a Frame's document changes, inform the client that the attachments in the previous document are going away.
For each attachment currently connected to the document, we have either (1) already informed the client that it
was inserted, or (2) the attachment is pending an insertion call to the client. If (1) is the case, then we'll
tell the client that the attachment is removed, which will balance out the earlier insertion call. If (2) is the
case, then we'll remove the previously inserted attachment identifier from the set of attachment identifiers
pending insertion, and the client won't be informed of insertions or removals.
Source/WebKit:
Add a
sourceparameter to thedidInsertAttachmentcodepath for notifying WebKit2 clients when attachment
elements are inserted into the document.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didInsertAttachment:withSource:]):
(-[WKWebView _didInsertAttachment:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/Cocoa/PageClientImplCocoa.h:
- UIProcess/Cocoa/PageClientImplCocoa.mm:
(WebKit::PageClientImplCocoa::didInsertAttachment):
- UIProcess/PageClient.h:
(WebKit::PageClient::didInsertAttachment):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didInsertAttachment):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::didInsertAttachment):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Tools:
Tweak an existing API test to check that the
srcof an attachment element inserted via script matches the
sourceprovided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(-[AttachmentUpdateObserver init]):
(-[AttachmentUpdateObserver sourceForIdentifier:]):
(-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
(TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
(TestWebKitAPI::TEST):
(-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
- 10:45 AM Changeset in webkit [226976] by
-
- 5 edits in trunk/Source/WebCore
Use traits for animation timing functions
https://bugs.webkit.org/show_bug.cgi?id=181651
Patch by Antoine Quint <Antoine Quint> on 2018-01-16
Reviewed by Dean Jackson.
Cleaning up Dean's previous patch as suggested by Darin's post-commit review comments. The
downcast function can match const automatically and it's a better style to put the * inside
the downcast call rather than outside.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTimingFunctionValue):
- platform/animation/TimingFunction.cpp:
(WebCore::operator<<):
(WebCore::TimingFunction::transformTime const):
- platform/animation/TimingFunction.h:
- platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
(WebCore::toCAMediaTimingFunction):
- 10:29 AM Changeset in webkit [226975] by
-
- 1 copy in tags/Safari-606.1.1.1
New tag.
- 8:01 AM Changeset in webkit [226974] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Live streaming cleanups
https://bugs.webkit.org/show_bug.cgi?id=181672
Reviewed by Michael Catanzaro.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Switch to
streaming code path when no content-length was reported by the
http source element.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes const): Return early when streaming.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(CachedResourceStreamingClient::responseReceived): Emit headers as
an element message, like souphttpsrc.
- 7:59 AM Changeset in webkit [226973] by
-
- 9 edits in trunk/Source/WebCore
[GStreamer] misc fixes and cleanups
https://bugs.webkit.org/show_bug.cgi?id=181647
Reviewed by Michael Catanzaro.
- platform/graphics/MediaPlayer.cpp:
(WebCore::convertEnumerationToString): New utility function to convert preload enum to string.
- platform/graphics/MediaPlayerEnums.h: Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): Debug tweak
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Ditto
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto
(WebCore::MediaPlayerPrivateGStreamer::paused const): Ditto
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats): Prevent useless state update.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Debug tweak.
(WebCore::MediaPlayerPrivateGStreamer::setDownloadBuffering): Ditto.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
Remove useless handlesSyncMessage method.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::setMuted): Prevent useless state update.
(WebCore::MediaPlayerPrivateGStreamerBase::muted const): Debug tweak.
(WebCore::MediaPlayerPrivateGStreamerBase::setStreamVolumeElement): Ditto.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init): Enable keepAlive by default like in souphttpsrc.
(webKitWebSrcStart): Debug tweak.
(webKitWebSrcQueryWithParent): Ditto.
(webKitWebSrcNeedData): Ditto.
(CachedResourceStreamingClient::responseReceived): Change appsrc
stream-type when we wan't seek. Also update caps like souphttpsrc
does.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.h: Add forward declaration of MediaPlayer.
- platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:
(WebCore::MediaSourceClientGStreamerMSE::append): Fix compilation warning.
- 7:34 AM Changeset in webkit [226972] by
-
- 2 edits in trunk/Source/bmalloc
mbmalloc should only be built in developer mode
https://bugs.webkit.org/show_bug.cgi?id=181654
Reviewed by Carlos Garcia Campos.
- CMakeLists.txt:
- 7:33 AM Changeset in webkit [226971] by
-
- 2 edits in trunk/Source/JavaScriptCore
Test programs should only be built in developer mode
https://bugs.webkit.org/show_bug.cgi?id=181653
Reviewed by Carlos Garcia Campos.
Build test programs only in developer mode, and fix code style.
- shell/CMakeLists.txt:
- 6:18 AM Changeset in webkit [226970] by
-
- 3 edits in trunk/Tools
Unreviewed. Fix GTK unit tests execution in the bots after r226967.
I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
- glib/api_test_runner.py:
(TestRunner._run_test_glib): Pass env to GLibTestRunner.
- glib/glib_test_runner.py:
(GLibTestRunner.run): Use given env.
- 4:10 AM Changeset in webkit [226969] by
-
- 2 edits in trunk/Tools
[GTK][WPE] Stop passing --verbose to run-api-tests from the bots
https://bugs.webkit.org/show_bug.cgi?id=181676
Reviewed by Carlos Alberto Lopez Perez.
The option was removed in r226967.
- BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunGtkAPITests):
(RunWPEAPITests):
- 3:38 AM Changeset in webkit [226968] by
-
- 2 edits in trunk/Tools
Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
The bots are still passing that option and the step is failing because it was removed in r226967.
- glib/api_test_runner.py:
(add_options):
- 2:42 AM Changeset in webkit [226967] by
-
- 2 edits1 add in trunk/Tools
[GTK][WPE] Improve the way glib tests are run
https://bugs.webkit.org/show_bug.cgi?id=181674
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2018-01-16
Reviewed by Žan Doberšek.
Stop using gtester external program and use our own tester from python directly. This way we no longer need to
parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
tests failing due to an expected assert in the test and unexpected crashes.
This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
not showing the subtest name in stdout in case of timeouts.
I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
of every test case.
- glib/api_test_runner.py:
(TestRunner._run_test_glib): Use GLibTestRunner.
(TestRunner._run_google_test): Wrote tests timing out to stdout too.
(add_options):
- glib/glib_test_runner.py: Added.
(TestTimeout):
(Message):
(Message.init):
(Message.create):
(Message.create.read_unsigned):
(Message.create.read_double):
(Message.create.read_string):
(GLibTestRunner):
(GLibTestRunner.init):
(GLibTestRunner._process_data):
(GLibTestRunner._process_message):
(GLibTestRunner._read_from_pipe):
(GLibTestRunner._read_from_stderr):
(GLibTestRunner._start_timeout):
(GLibTestRunner._start_timeout._alarm_handler):
(GLibTestRunner._stop_timeout):
(GLibTestRunner._subtest_start):
(GLibTestRunner._subtest_message):
(GLibTestRunner._subtest_stderr):
(GLibTestRunner._subtest_end):
(GLibTestRunner.run):
- 12:16 AM Changeset in webkit [226966] by
-
- 5 edits11 adds in trunk/LayoutTests
[EME] Add layout test for the MSE playback of ClearKey encrypted audio and video
https://bugs.webkit.org/show_bug.cgi?id=181594
Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-01-16
Reviewed by Xabier Rodriguez-Calvar.
Add new layout tests in order to test the playback of ClearKey encrypted content:
clearKey-cenc-audio-playback-mse : Tests the MSE playback of ClearKey encrypted audio track.
clearKey-cenc-video-playback-mse : Tests the MSE playback of ClearKey encrypted video track.
- media/content/encrypted/segments/AudioClearKeyCenc-seg-0.mp4: Added.
- media/content/encrypted/segments/AudioClearKeyCenc-seg-1.mp4: Added.
- media/content/encrypted/segments/AudioClearKeyCenc-seg-2.mp4: Added.
- media/content/encrypted/segments/AudioClearKeyCenc-seg-3.mp4: Added.
These are a simple encrypted audio fragments used in MSE playback.
They have been fragmented and encrypted with BENTO4. https://www.bento4.com/
Use full-sample encryption because they are not NAL Structured.
- media/content/encrypted/segments/VideoClearKeyCenc-seg-1.mp4: Added.
- media/content/encrypted/segments/VideoClearKeyCenc-seg-2.mp4: Added.
- media/content/encrypted/segments/VideoClearKeyCenc-seg-3.mp4: Added.
These are a simple encrypted video fragments used in MSE playback.
They have been fragmented and encrypted with BENTO4. https://www.bento4.com/
Use sub-sample encryption because they are NAL Structured.
- media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse-expected.txt: Added.
- media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html: Added.
- media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse-expected.txt: Added.
- media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html: Added.
- media/encrypted-media/medias-enc.js:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/wpe/TestExpectations:
The test clearKey-cenc-audio-playback-mse crashes because the clearKey decryptor plugin doesn't
support yet the Full-sample encryption, see bug 180080.
- 12:13 AM Changeset in webkit [226965] by
-
- 5 edits in trunk
[WPE] Two clearkey tests failing since r226621
https://bugs.webkit.org/show_bug.cgi?id=181532
Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-01-16
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Whith a fake initData, we can have a pssh size nul, thus we should check it.
We saw this issue in the subtest "initData longer than 64Kb characters" in
the clearkey-generate-request-disallowed-input layout test.
- platform/encryptedmedia/clearkey/CDMClearKey.cpp:
(WebCore::extractKeyidsLocationFromCencInitData):
LayoutTests:
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin-expected.txt:
Since r226621 initDataType "cenc" is supported in clearKey, so we should update the expected result of these tests.
- 12:04 AM Changeset in webkit [226964] by
-
- 7 edits in trunk/LayoutTests
[EME] some fixes in clearKey-encrypted-cenc-event LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=181526
Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-01-16
Reviewed by Xabier Rodriguez-Calvar.
Update the TestExpectation files as it was done with clearKey-message-cenc-event
LayoutTest, the test should be pass in all platforms except gtk and mac.
Use const or let instead of var in JS when it's possible.
- TestExpectations:
- media/encrypted-media/clearKey/clearKey-encrypted-cenc-event.html:
- media/media-source/media-source-loader-simple.js:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/wpe/TestExpectations:
Jan 15, 2018:
- 11:03 PM Changeset in webkit [226963] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: TabBar redesign: add context menu to TabBar for toggling available tabs
https://bugs.webkit.org/show_bug.cgi?id=181448
<rdar://problem/36383298>
Reviewed by Devin Rousso.
- UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):
Reorder production tab classes and default (open) tabs.
(WI.registerTabClass): Removed.
Not used.
- UserInterface/Base/Object.js:
Remove notification that is no longer used.
- UserInterface/Views/GeneralTabBarItem.js:
(WI.GeneralTabBarItem):
(WI.GeneralTabBarItem.prototype.set title):
(WI.GeneralTabBarItem.prototype._handleContextMenuEvent): Deleted.
Remove per-tab context menu (provided Close Tab and Close Other Tabs).
- UserInterface/Views/NewTabContentView.js:
(WI.NewTabContentView):
- UserInterface/Views/TabBar.js:
(WI.TabBar):
(WI.TabBar.prototype._handleContextMenu):
- UserInterface/Views/TabBrowser.js:
(WI.TabBrowser):
(WI.TabBrowser._handleNewTabContextMenu): Deleted.
No longer needed.
- 10:44 PM Changeset in webkit [226962] by
-
- 4 edits2 adds in trunk
Support for preconnect Link headers
https://bugs.webkit.org/show_bug.cgi?id=181657
Reviewed by Darin Adler.
Source/WebCore:
Move the preconnect functionality into its own function, and
also call this function when Link headers are processed.
Test: http/tests/preconnect/link-header-rel-preconnect-http.php
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLinksFromHeader): Call preconnect.
(WebCore::LinkLoader::preconnect): Preconnect to a host functionality moved here.
(WebCore::LinkLoader::preload): RenamedpreloadIfNeededtopreload.
(WebCore::LinkLoader::loadLink): Call preconnect.
- loader/LinkLoader.h:
LayoutTests:
Add test to see Link preconnect headers trigger a connection.
- http/tests/preconnect/link-header-rel-preconnect-http-expected.txt: Added.
- http/tests/preconnect/link-header-rel-preconnect-http.php: Added.
- 6:47 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 6:46 PM WebKitGTK/Gardening/Calendar edited by
- (diff)
- 6:44 PM Changeset in webkit [226961] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK layout test gardening
- TestExpectations:
- platform/gtk/TestExpectations:
- 6:36 PM Changeset in webkit [226960] by
-
- 2 edits in trunk/Websites/browserbench.org
ΩUpdate the default hyperlink for Speedometer to Speedometer 2.0.
Rubber-stamped by Saam Barati.
- index.html:
- 6:20 PM Changeset in webkit [226959] by
-
- 2 edits in trunk/Tools
Unreviewed, add Thibault to contributors.json
It's a bit weird to add someone here before their first contribution, but this affects
Bugzilla autocomplete, and that is serious business.
- Scripts/webkitpy/common/config/contributors.json:
- 3:49 PM Changeset in webkit [226958] by
-
- 14 edits in trunk/Source
Improve use of ExportMacros
https://bugs.webkit.org/show_bug.cgi?id=181652
Reviewed by Konstantin Tokarev.
Source/bmalloc:
Disable BEXPORT on Linux ports.
- bmalloc/BExport.h: Check for BUSE(EXPORT_MACROS).
- bmalloc/BPlatform.h: Add BUSE(EXPORT_MACROS) and define it on macOS and iOS.
Source/JavaScriptCore:
- API/JSBase.h: Update a comment.
- inspector/InspectorBackendDispatcher.h: Use a better, yet equivalent, WTF macro.
- runtime/JSExportMacros.h: Simplify the #defines in this file.
Source/WebCore:
Remove a comment.
- platform/PlatformExportMacros.h:
Source/WebCore/PAL:
Remove a comment.
- pal/ExportMacros.h:
Source/WTF:
- wtf/ExportMacros.h: Simplify the #defines in this file.
- wtf/Platform.h: Remove unneeded define. Remove comment that expects all ports to eventually enable the export macros. WPE will never want these. We don't currently want them for GTK either, though how we link GTK has been in flux recently.
- 2:56 PM Changeset in webkit [226957] by
-
- 3 edits3 adds in trunk
image-rendering should affect scaling of border-image
https://bugs.webkit.org/show_bug.cgi?id=169440
Reviewed by Michael Catanzaro.
Source/WebCore:
Test: fast/borders/border-image-pixelated.html
- rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::paint):
LayoutTests:
- fast/borders/border-image-pixelated-expected.html: Added.
- fast/borders/border-image-pixelated.html: Added.
- fast/borders/resources/border-image-pixelated.png: Added.
- 2:02 PM Changeset in webkit [226956] by
-
- 9 edits in trunk
Remove makePoisonedUnique
https://bugs.webkit.org/show_bug.cgi?id=181630
<rdar://problem/36498623>
Reviewed by Mark Lam.
Source/JavaScriptCore:
I added a conversion from std::unique_ptr, so we can just use
std::make_unique and it'll auto-poison when converted.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::makePoisonedUnique): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::makePoisonedUnique): Deleted.
Source/WTF:
I added a conversion from std::unique_ptr, so we can just use
std::make_unique and it'll auto-poison when converted.
- wtf/PoisonedUniquePtr.h:
(WTF::makePoisonedUnique): Deleted.
Tools:
Update tests.
- TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
(TestWebKitAPI::TEST):
- 1:24 PM Changeset in webkit [226955] by
-
- 2 edits in trunk/Source/WebCore
2.19.3 ACCELERATED_2D_CANVAS support is broken
https://bugs.webkit.org/show_bug.cgi?id=180799
Reviewed by Michael Catanzaro.
- html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::didDraw):
- 1:21 PM Changeset in webkit [226954] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Enable HTTP/2
https://bugs.webkit.org/show_bug.cgi?id=181551
Patch by Basuke Suzuki <Basuke Suzuki> on 2018-01-15
Reviewed by Michael Catanzaro.
Start supporting HTTP/2 protocol. The first step is just enabling the HTTP/2 on Curl backend.
Next step will be to enable multiplexing feature.
No new tests because we don't have HTTP/2 test backend yet.
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlContext::isHttp2Enabled const):
(WebCore::CurlHandle::enableHttp):
(WebCore::CurlHandle::enableHttpGetRequest):
(WebCore::CurlHandle::enableHttpHeadRequest):
(WebCore::CurlHandle::enableHttpPostRequest):
(WebCore::CurlHandle::enableHttpPutRequest):
(WebCore::CurlHandle::setHttpCustomRequest):
- platform/network/curl/CurlContext.h:
- 12:43 PM Changeset in webkit [226953] by
-
- 5 edits in trunk/Source/WebCore
Use a helper function for checked arithmetic in WebGL validation
https://bugs.webkit.org/show_bug.cgi?id=181620
<rdar://problem/36485879>
Reviewed by Eric Carlson.
Eric recommended using a templated helper function to do
a common arithmetic check in WebGL validation.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::validateIndexArrayConservative):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContextBase::validateDrawArrays):
(WebCore::WebGLRenderingContextBase::validateSimulatedVertexAttrib0):
(WebCore::WebGLRenderingContextBase::simulateVertexAttrib0):
- html/canvas/WebGLRenderingContextBase.h:
(WebCore::WebGLRenderingContextBase::checkedAddAndMultiply): New helper.
- 11:16 AM Changeset in webkit [226952] by
-
- 6 edits in trunk/Source/WebCore
Use traits for animation timing functions
https://bugs.webkit.org/show_bug.cgi?id=181651
<rdar://problem/36525328>
Reviewed by Antoine Quint.
Use the type traits for TimingFunction classes, so
we can is<> and downcast<>.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTimingFunctionValue):
- platform/animation/TimingFunction.cpp:
(WebCore::TimingFunction::transformTime const):
- platform/animation/TimingFunction.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::animationHasStepsTimingFunction):
(WebCore::animationHasFramesTimingFunction):
- platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
(WebCore::toCAMediaTimingFunction):
- 9:54 AM Changeset in webkit [226951] by
-
- 2 edits in trunk/Source/WebCore
RealtimeMediaSource should be ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=181649
Patch by Youenn Fablet <youenn@apple.com> on 2018-01-15
Reviewed by Eric Carlson.
Difficult to write a test as this is really racy.
RealtimeIncomingVideoSourceCocoa::OnFrame is taking a reference on a background thread
to send a task to the main thread.
This requires it to be thread safe ref counted.
- platform/mediastream/RealtimeMediaSource.h:
- 9:36 AM Changeset in webkit [226950] by
-
- 3 edits in trunk/Tools
[GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
https://bugs.webkit.org/show_bug.cgi?id=181476
Reviewed by Michael Catanzaro.
Update to xorg-server 1.19.6 which depends on libxfont2, and change
the lists of packages to install libxfont2-devel (or equivalent).
- gtk/install-dependencies:
- gtk/jhbuild.modules:
- 7:49 AM Changeset in webkit [226949] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening
- platform/gtk/TestExpectations: Skip
media/media-fullscreen-pause-inline.html as advised by Eric
Carlson.
- 7:27 AM Changeset in webkit [226948] by
-
- 5 edits in trunk
Prevent useless MediaPlayer mute state notifications
https://bugs.webkit.org/show_bug.cgi?id=181646
Reviewed by Carlos Garcia Campos.
Source/WebCore:
On GTK port the mute change notification was triggering the test
runner to think the whole page mute state had changed and that
media elements were muted. The simplest solution is to propagate
the notification only if the state actually changed.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::muteChanged): Propagate mute notification
only if the mute state actually changed.
LayoutTests:
Unflag tests depending on muted state and media session
restrictions, most of those are now passing.
- platform/gtk/TestExpectations:
- platform/gtk/media/video-controls-no-scripting-expected.txt:
- 2:50 AM Changeset in webkit [226947] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Don't wait for draw condition variable when shutting down.
https://bugs.webkit.org/show_bug.cgi?id=180978
Patch by Sebastian Dröge <sebastian@centricular.com> on 2018-01-15
Reviewed by Carlos Garcia Campos.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
By also waiting for the draw condition variable while shutting down,
it is possible that the GStreamer video sink is waiting for the main
thread to actually render the current frame, while at the same time
the main thread is waiting for the GStreamer video sink to shut down,
resulting in a deadlock.
- 1:36 AM Changeset in webkit [226946] by
-
- 2 edits in trunk/Source/WebKit
ASSERTION FAILED: m_ptr under WebKit::CacheStorage::Caches::writeRecord
https://bugs.webkit.org/show_bug.cgi?id=181401
<rdar://problem/36379022>
Patch by Youenn Fablet <youenn@apple.com> on 2018-01-15
Reviewed by Darin Adler.
m_isInitialized is true but m_storage is set to nullptr when calling writeRecord.
The only case seems to be if:
- We are doing persistent storage
- We are traversing the storage to do the initialization. At that point m_storage is set to a correct value.
- clearMemoryRepresentation is called, thus setting m_storage to nullptr and m_isInitialized to false.
We fix this by making clearMemoryRepresentation a no-op if we are initializing the caches.
clearMemoryRepresentation is about cleaning the in-memory information of the caches and the memory representation is empty at init time.
Nullifying m_storage is a memory consumption optimization.
- NetworkProcess/cache/CacheStorageEngineCaches.cpp:
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):
- 12:45 AM Changeset in webkit [226945] by
-
- 5 edits1 delete in trunk
REGRESSION(r226266): [GTK] RELEASE_ASSERT(reservedZoneSize >= minimumReservedZoneSize) in JSC::VM::updateStackLimits
https://bugs.webkit.org/show_bug.cgi?id=181438
<rdar://problem/36376724>
Reviewed by Carlos Garcia Campos.
.:
Build JSC as a shared library.
Stop using -fvisibility=hidden. This is a shame, but it is causing problems that I don't
know how to fix.
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitCompilerFlags.cmake:
Source/JavaScriptCore:
Roll out the functional changes of r226266. We'll keep the minor CMake library type setting
cleanup, but we have to switch back to building JSC only as a shared library, and we have to
get rid of the version script.
- PlatformGTK.cmake:
- javascriptcoregtk-symbols.map: Removed.
- 12:17 AM Changeset in webkit [226944] by
-
- 4 edits3 adds in trunk/Tools
[GTK][WPE] Add support for unit test expectations
https://bugs.webkit.org/show_bug.cgi?id=181589
Reviewed by Michael Catanzaro.
We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
script itself is not a good idea either.
This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
convenient methods to query them.
- Scripts/run-gtk-tests:
(GtkTestRunner): Remove all Skipped and Slow tests marked here.
- Scripts/run-wpe-tests:
(WPETestRunner): Ditto.
- Scripts/webkitpy/common/test_expectations.py: Added.
(TestExpectations):
(TestExpectations.init):
(TestExpectations._port_name_for_expected):
(TestExpectations._expected_value):
(TestExpectations.skipped_tests):
(TestExpectations.skipped_subtests):
(TestExpectations._expectation_value):
(TestExpectations.is_slow):
(TestExpectations.get_expectation):
- Scripts/webkitpy/common/test_expectations_unittest.py: Added.
(MockTestExpectations):
(MockTestExpectations.init):
(MockTestExpectations.is_skip):
(ExpectationsTest):
(assert_exp):
(assert_not_exp):
(assert_bad_exp):
(assert_skip):
(test_basic):
(test_skip):
(test_flaky):
(test_build_type):
- TestWebKitAPI/glib/TestExpectations.json: Added.
- glib/api_test_runner.py:
(TestRunner): Remove SkippedTest implementation.
(TestRunner.init): Create a TestExpectations.
(TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
(TestRunner._should_run_test_program): Ditto.
(TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
(TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
(TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
(TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
(TestRunner.run_tests.report): Helper to write report to stdout.
Jan 14, 2018:
- 3:02 PM Changeset in webkit [226943] by
-
- 2 edits in trunk/LayoutTests
[macOS] [WK2] Unskip some consistently-passing tests
https://bugs.webkit.org/show_bug.cgi?id=181226
<rdar://problem/23023848>
Reviewed by Simon Fraser.
According to the flakiness dashboard, these tests consistently pass now.
- platform/mac-wk2/TestExpectations:
- 11:43 AM Changeset in webkit [226942] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. r226928 broke the CLOOP build. This patch fixes the CLOOP build.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
(JSC::CallLinkStatus::computeExitSiteData):
Jan 13, 2018:
- 11:16 PM Changeset in webkit [226941] by
-
- 3 edits in trunk/LayoutTests
Extend testing added in r226842
https://bugs.webkit.org/show_bug.cgi?id=181634
Reviewed by Darin Adler.
I have verified that the behavior is consistent with Chrome and Firefox.
- fast/dom/Window/window-opener-shadowing-expected.txt:
- fast/dom/Window/window-opener-shadowing.html:
- 10:11 PM Changeset in webkit [226940] by
-
- 62 edits1 move2 deletes in trunk
Replace all use of ConstExprPoisoned with Poisoned.
https://bugs.webkit.org/show_bug.cgi?id=181542
<rdar://problem/36442138>
Reviewed by JF Bastien.
Source/JavaScriptCore:
- All JSC poisons are now defined in JSCPoison.h.
- Change all clients to use the new poison values via the POISON() macro.
- The LLInt code has been updated to handle CodeBlock poison. Some of this code uses the t5 temp register, which is not available on the Windows port. Fortunately, we don't currently do poisoning on the Windows port yet. So, it will just work for now.
When poisoning is enabled for the Windows port, this LLInt code will need a
Windows specific implementation to workaround its lack of a t5 register.
- API/JSAPIWrapperObject.h:
- API/JSCallbackFunction.h:
- API/JSCallbackObject.h:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
- b3/B3LowerMacros.cpp:
- b3/testb3.cpp:
(JSC::B3::testInterpreter):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::instructions):
(JSC::CodeBlock::instructions const):
(JSC::CodeBlock::makePoisonedUnique):
- dfg/DFGOSRExitCompilerCommon.h:
(JSC::DFG::adjustFrameAndStackInOSRExitCompilerThunk):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCheckSubClass):
(JSC::DFG::SpeculativeJIT::emitSwitchIntJump):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCheckSubClass):
- jit/JIT.h:
- jit/ThunkGenerators.cpp:
(JSC::virtualThunkFor):
(JSC::nativeForGenerator):
(JSC::boundThisNoArgsFunctionCallGenerator):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/UnlinkedSourceCode.h:
- runtime/ArrayPrototype.h:
- runtime/CustomGetterSetter.h:
- runtime/DateInstance.h:
- runtime/InternalFunction.h:
- runtime/JSArrayBuffer.h:
- runtime/JSCPoison.cpp: Copied from Source/JavaScriptCore/runtime/JSCPoisonedPtr.cpp.
(JSC::initializePoison):
- runtime/JSCPoison.h:
(): Deleted.
- runtime/JSCPoisonedPtr.cpp: Removed.
- runtime/JSCPoisonedPtr.h: Removed.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::makePoisonedUnique):
- runtime/JSScriptFetchParameters.h:
- runtime/JSScriptFetcher.h:
- runtime/NativeExecutable.h:
- runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::map const):
(JSC::StructureTransitionTable::weakImpl const):
- runtime/WriteBarrier.h:
(JSC::WriteBarrier::poison):
- wasm/js/JSToWasm.cpp:
(JSC::Wasm::createJSToWasmWrapper):
- wasm/js/JSWebAssemblyCodeBlock.cpp:
(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):
- wasm/js/JSWebAssemblyCodeBlock.h:
- wasm/js/JSWebAssemblyInstance.h:
- wasm/js/JSWebAssemblyMemory.h:
- wasm/js/JSWebAssemblyModule.h:
- wasm/js/JSWebAssemblyTable.h:
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::handleBadI64Use):
(JSC::Wasm::wasmToJS):
- wasm/js/WebAssemblyFunctionBase.h:
- wasm/js/WebAssemblyModuleRecord.h:
- wasm/js/WebAssemblyToJSCallee.h:
- wasm/js/WebAssemblyWrapperFunction.h:
Source/WTF:
- Removed ConstExprPoisoned and its artifacts.
- Consolidated Poisoned into PoisonedImpl. PoisonedImpl is not more.
- Changed all clients of ConstExprPoisoned to use Poisoned instead.
- Worked around the GCC and Clang compiler bug that confuses an intptr_t& template arg with intptr_t. See use of std::enable_if_t<Other::isPoisoned> in Poisoned.h.
- Removed ENABLE(MIXED_POISON) since we now have a workaround (3) that makes it possible to use the mixed poison code.
- Also fixed broken implementation of comparison operators in Poisoned.
- wtf/Bag.h:
- wtf/DumbPtrTraits.h:
(WTF::DumbPtrTraits::poison):
- wtf/DumbValueTraits.h:
(WTF::DumbValueTraits::poison):
- wtf/Poisoned.h:
(WTF::Poisoned::Poisoned):
(WTF::Poisoned::operator== const):
(WTF::Poisoned::operator!= const):
(WTF::Poisoned::operator< const):
(WTF::Poisoned::operator<= const):
(WTF::Poisoned::operator> const):
(WTF::Poisoned::operator>= const):
(WTF::Poisoned::operator=):
(WTF::Poisoned::swap):
(WTF::swap):
(WTF::PoisonedPtrTraits::poison):
(WTF::PoisonedPtrTraits::swap):
(WTF::PoisonedValueTraits::poison):
(WTF::PoisonedValueTraits::swap):
(WTF::PoisonedImpl::PoisonedImpl): Deleted.
(WTF::PoisonedImpl::assertIsPoisoned const): Deleted.
(WTF::PoisonedImpl::assertIsNotPoisoned const): Deleted.
(WTF::PoisonedImpl::unpoisoned const): Deleted.
(WTF::PoisonedImpl::clear): Deleted.
(WTF::PoisonedImpl::operator* const): Deleted.
(WTF::PoisonedImpl::operator-> const): Deleted.
(WTF::PoisonedImpl::bits const): Deleted.
(WTF::PoisonedImpl::operator! const): Deleted.
(WTF::PoisonedImpl::operator bool const): Deleted.
(WTF::PoisonedImpl::operator== const): Deleted.
(WTF::PoisonedImpl::operator!= const): Deleted.
(WTF::PoisonedImpl::operator< const): Deleted.
(WTF::PoisonedImpl::operator<= const): Deleted.
(WTF::PoisonedImpl::operator> const): Deleted.
(WTF::PoisonedImpl::operator>= const): Deleted.
(WTF::PoisonedImpl::operator=): Deleted.
(WTF::PoisonedImpl::swap): Deleted.
(WTF::PoisonedImpl::exchange): Deleted.
(WTF::PoisonedImpl::poison): Deleted.
(WTF::PoisonedImpl::unpoison): Deleted.
(WTF::constExprPoisonRandom): Deleted.
(WTF::makeConstExprPoison): Deleted.
(WTF::ConstExprPoisonedPtrTraits::exchange): Deleted.
(WTF::ConstExprPoisonedPtrTraits::swap): Deleted.
(WTF::ConstExprPoisonedPtrTraits::unwrap): Deleted.
(WTF::ConstExprPoisonedValueTraits::exchange): Deleted.
(WTF::ConstExprPoisonedValueTraits::swap): Deleted.
(WTF::ConstExprPoisonedValueTraits::unwrap): Deleted.
- wtf/PoisonedUniquePtr.h:
(WTF::PoisonedUniquePtr::PoisonedUniquePtr):
(WTF::PoisonedUniquePtr::operator=):
- wtf/Ref.h:
- wtf/RefCountedArray.h:
(WTF::RefCountedArray::RefCountedArray):
- wtf/RefPtr.h:
- wtf/WTFAssertions.cpp:
Tools:
- Converted tests to using new uintptr_t& poison type.
- Added tests for Poisoned comparison operators.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
- TestWebKitAPI/Tests/WTF/Poisoned.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::initializeTestPoison): Deleted.
- TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::passWithRef):
- TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::f1):
- TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::poisonedPtrFoo):
- TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
(TestWebKitAPI::TEST):
- 8:06 PM Changeset in webkit [226939] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: properties should never be semitransparent or crossed out while editing
https://bugs.webkit.org/show_bug.cgi?id=180793
<rdar://problem/36038813>
Reviewed by Devin Rousso.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(.spreadsheet-style-declaration-editor .value.editing):
(.spreadsheet-style-declaration-editor .property:matches(.invalid-name, .other-vendor, .overridden):not(.disabled) .content > *):
(.spreadsheet-style-declaration-editor .property.invalid-name:not(.disabled) .content > *):
(.spreadsheet-style-declaration-editor .property.invalid-value:not(.disabled) .content .value):
(.spreadsheet-style-declaration-editor .property.not-inherited .content > *):
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype._update):
- 12:38 PM Changeset in webkit [226938] by
-
- 3 edits in trunk/Tools
check-webkit-style: false positive for [whitespace/braces] with os_log format string
<https://webkit.org/b/181606>
Reviewed by Darin Adler.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing): Modify regular expression to ignore
os_log format strings like '%{public}'.
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_spacing_before_braces): Add os_log
format string test.
- 7:16 AM Changeset in webkit [226937] by
-
- 7 edits6 adds in trunk
[JSC] NumberPrototype::extractRadixFromArgs incorrectly cast double to int32_t
https://bugs.webkit.org/show_bug.cgi?id=181182
Reviewed by Darin Adler.
JSTests:
- bigIntTests.yaml:
- stress/big-int-constructor.js:
- stress/big-int-prototype-to-string-cast-overflow.js: Added.
(assert):
(assertThrowRangeError):
- stress/number-prototype-to-string-cast-overflow.js: Added.
(assert):
(assertThrowRangeError):
Source/JavaScriptCore:
Casting double to integer is undefined behavior when the truncation
results into a value that doesn't fit into integer size, according C++
spec[1]. Thus, we are changing bigIntProtoFuncToString and
numberProtoFuncToString to remove these source of undefined behavior.
[1] - http://en.cppreference.com/w/cpp/language/implicit_conversion
- runtime/BigIntPrototype.cpp:
(JSC::bigIntProtoFuncToString):
- runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToString):
(JSC::extractRadixFromArgs): Deleted.
(JSC::extractToStringRadixArgument): Added.
- 4:07 AM Changeset in webkit [226936] by
-
- 3 edits2 adds in trunk
MathML Lengths should take zoom level into account
https://bugs.webkit.org/show_bug.cgi?id=180029
Patch by Minsheng Liu <lambda@liu.ms> on 2018-01-13
Reviewed by Frédéric Wang.
Source/WebCore:
The patch applies the effective zoom factor to physical units in toUserUnits().
Test: mathml/presentation/mspace-units-with-zoom.html
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::toUserUnits):
LayoutTests:
Add a testcase for MathML lengths where zoom factor is set.
- mathml/presentation/mspace-units-with-zoom-expected.html: Added.
- mathml/presentation/mspace-units-with-zoom.html: Added.
Jan 12, 2018:
- 9:30 PM Changeset in webkit [226935] by
-
- 2 edits in trunk/Tools
[macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
https://bugs.webkit.org/show_bug.cgi?id=181626
Reviewed by Joseph Pecoraro.
Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
Additionally, write a new API test covering the change in r226915.
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(webViewForTestingAttachments):
(TestWebKitAPI::TEST):
- 8:09 PM Changeset in webkit [226934] by
-
- 5 edits in trunk/Source/WebCore
ASSERTION FAILED: registration isTerminating() in WebCore::SWServerWorker::skipWaiting() https://bugs.webkit.org/show_bug.cgi?id=181603
<rdar://problem/36476050>
Reviewed by Youenn Fablet.
No new tests, covered by existing tests that crash flakily.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::terminateWorkerInternal):
If the connection to the context process is gone, make sure we make the worker as terminated
so that it does not stay in Running state and in SWServer::m_runningOrTerminatingWorkers.
- workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::~SWServerRegistration):
Add assertions to make sure none of the registration's workers are still running when
the registration is destroyed.
(WebCore::SWServerRegistration::updateRegistrationState):
Make sure registration workers that are overwritten are not still running.
- workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::setState):
If a worker's state is set to redundant, make sure we also terminate it.
- 5:11 PM Changeset in webkit [226933] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, speculative build fix after r226899.
Add an empty implementation for PageClient::startDrag.
- UIProcess/PageClient.h:
(WebKit::PageClient::startDrag):
- 5:03 PM Changeset in webkit [226932] by
-
- 1 edit2 adds in trunk/LayoutTests
Touch events not received with initial-scale=1 viewport
https://bugs.webkit.org/show_bug.cgi?id=181566
rdar://problem/36460221
Reviewed by Tim Horton.
Add a testcase for this touch event case.
- fast/events/touch/ios/target-taller-than-view-expected.txt: Added.
- fast/events/touch/ios/target-taller-than-view.html: Added.
- 4:46 PM Changeset in webkit [226931] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r226927.
https://bugs.webkit.org/show_bug.cgi?id=181621
Breaks 32-bit and iOS release for some reason that i don't
understand yet (Requested by dino on #webkit).
Reverted changeset:
"Use a helper function for checked arithmetic in WebGL
validation"
https://bugs.webkit.org/show_bug.cgi?id=181620
https://trac.webkit.org/changeset/226927
- 4:45 PM Changeset in webkit [226930] by
-
- 10 edits4 adds in trunk
Data URL fonts split in the middle of an alphabet cause random letters to disappear
https://bugs.webkit.org/show_bug.cgi?id=175845
<rdar://problem/33996578>
Reviewed by Brent Fulgham.
Source/WebCore:
It is fairly common practice for a font foundry to split a font up into two files such that a semi-random
half of the alphabet is present in one of the files, and the other half is present in the other file. This
practice involves representing the files as data URLs, so as to minimize the time it takes to load them.
Because resource loading is asynchronous (even for data URLs), it is possible today to get a paint after
the first file is loaded but before the second file is loaded. Indeed, because of the way font fallback
works, we will never start loading the second file until a layout has occurred with the first font.
Because a site usually only uses this pattern for a handful of fonts, and I've never seen this pattern
being used for CJK fonts, it isn't very expensive to opportunistically decode these data URLs eagerly.
Using this method doesn't actually guarantee that the two fonts will load in between successive paints,
but it at least makes this much more likely. This patch implements this strategy, along with a size
threshold to make sure that we won't decode any super large data URLs when it isn't necessary.
Test: fast/text/font-load-data-partitioned-alphabet.html
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::opportunisticallyStartFontDataURLLoading):
- css/CSSFontFace.h:
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::opportunisticallyStartFontDataURLLoading):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::opportunisticallyStartFontDataURLLoading):
- css/CSSFontSelector.h:
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::opportunisticallyStartFontDataURLLoading):
(WebCore::FontCascadeFonts::glyphDataForVariant):
- platform/graphics/FontSelector.h:
LayoutTests:
Make sure that the requests for both fonts are sent before either of the responses are received.
- fast/text/font-load-data-partitioned-alphabet-expected.txt: Added.
- fast/text/font-load-data-partitioned-alphabet.html: Added.
- platform/mac-wk1/fast/text/font-load-data-partitioned-alphabet-expected.txt: Added.
- 4:39 PM Changeset in webkit [226929] by
-
- 4 edits in trunk
History state should be updated during client redirects with asynchronous policy decisions
https://bugs.webkit.org/show_bug.cgi?id=181358
<rdar://problem/35547689>
Reviewed by Andy Estes.
Source/WebCore:
When decidePolicyForNavigationAction is responded to asynchronously during a client redirect,
HistoryController::updateForRedirectWithLockedBackForwardList does not update the history because
the document loader has not been marked as a client redirect because the FrameLoader only looks
at its provisional document loader to mark it as a client redirect. When decidePolicyForNavigationAction
is responded to asynchronously, though, the FrameLoader's provisional document loader has moved to
its policy document loader. To get both asynchronous and synchronous cases, let's just mark the document
loader as a client redirect whether it's the provisional or policy document loader.
Covered by a new API test.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadPostRequest):
Tools:
- TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
(-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
(-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST):
- 4:36 PM Changeset in webkit [226928] by
-
- 17 edits in trunk/Source/JavaScriptCore
Move ExitProfile to UnlinkedCodeBlock so it can be shared amongst CodeBlocks backed by the same UnlinkedCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=181545
Reviewed by Michael Saboff.
This patch follows the theme of putting optimization profiling information on
UnlinkedCodeBlock. This allows the unlinked code cache to remember OSR exit data.
This often leads to the first compile of a CodeBlock, backed by an UnlinkedCodeBlock
pulled from the code cache, making better compilation decisions, usually
resulting in fewer exits, and fewer recompilations.
This is a 1% Speedometer progression in my testing.
- bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<CodeBlock>::dumpProfilesForBytecodeOffset):
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::computeExitSiteData):
(JSC::CallLinkStatus::computeDFGStatuses):
- bytecode/CallLinkStatus.h:
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addFrequentExitSite): Deleted.
(JSC::CodeBlock::hasExitSite const): Deleted.
(JSC::CodeBlock::exitProfile): Deleted.
- bytecode/DFGExitProfile.cpp:
(JSC::DFG::ExitProfile::add):
(JSC::DFG::QueryableExitProfile::initialize):
- bytecode/DFGExitProfile.h:
(JSC::DFG::ExitProfile::hasExitSite const):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::hasExitSite):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/GetByIdStatus.h:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::hasExitSite):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):
- bytecode/PutByIdStatus.h:
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::livenessAnalysisSlow):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::hasExitSite const):
(JSC::UnlinkedCodeBlock::hasExitSite):
(JSC::UnlinkedCodeBlock::exitProfile):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::hasGlobalExitSite):
(JSC::DFG::Graph::hasExitSite):
- dfg/DFGLICMPhase.cpp:
(JSC::DFG::LICMPhase::attemptHoist):
- dfg/DFGOSRExitBase.cpp:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
- 4:30 PM Changeset in webkit [226927] by
-
- 5 edits in trunk/Source/WebCore
Use a helper function for checked arithmetic in WebGL validation
https://bugs.webkit.org/show_bug.cgi?id=181620
<rdar://problem/36485879>
Reviewed by Eric Carlson.
Eric recommended using a templated helper function to do
a common arithmetic check in WebGL validation.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::validateIndexArrayConservative):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::checkedAddAndMultiply): New helper.
(WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContextBase::validateDrawArrays):
(WebCore::WebGLRenderingContextBase::validateSimulatedVertexAttrib0):
(WebCore::WebGLRenderingContextBase::simulateVertexAttrib0):
- html/canvas/WebGLRenderingContextBase.h:
- 4:28 PM Changeset in webkit [226926] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Remove unneeded accessibility-related sandbox rules
https://bugs.webkit.org/show_bug.cgi?id=181619
<rdar://problem/36485356>
Reviewed by Eric Carlson.
Remove a number of sandbox exceptions that were in place for accessibility support. These are
not needed in the WebContent process, since Safari (not WebKit) handles the accessibility
interactions.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 4:07 PM Changeset in webkit [226925] by
-
- 1 copy in tags/Safari-605.1.22
Tag Safari-605.1.22.
- 3:56 PM Changeset in webkit [226924] by
-
- 10 edits in branches/safari-605-branch
Cherry-pick r226838. rdar://problem/36480711
- 3:56 PM Changeset in webkit [226923] by
-
- 8 edits in branches/safari-605-branch/Source
Apply patch. rdar://problem/36303061
Disable WebKit features we don't want to ship after branching
<rdar://problem/36303061>
- 3:56 PM Changeset in webkit [226922] by
-
- 4 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r226905. rdar://problem/36483899
- 3:56 PM Changeset in webkit [226921] by
-
- 7 edits in branches/safari-605-branch/Source
Versioning.
- 3:47 PM Changeset in webkit [226920] by
-
- 28 edits1 copy in trunk/Source
PoisonedWriteBarrier
https://bugs.webkit.org/show_bug.cgi?id=181599
<rdar://problem/36474351>
Reviewed by Mark Lam.
Source/JavaScriptCore:
Allow poisoning of WriteBarrier objects, and use this for
WebAssembly because it is perf-neutral, at least on WasmBench on
my MBP. If it indeed is perf-neutral according to the bots, start
using it in more performance-sensitive places.
- heap/HandleTypes.h:
- heap/SlotVisitor.h:
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendHidden):
- runtime/JSCJSValue.h:
- runtime/JSCPoison.h:
- runtime/Structure.h:
- runtime/StructureInlines.h:
(JSC::Structure::setPrototypeWithoutTransition):
(JSC::Structure::setGlobalObject):
(JSC::Structure::setPreviousID):
- runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::copyFrom):
(JSC::WriteBarrierBase::get const):
(JSC::WriteBarrierBase::operator* const):
(JSC::WriteBarrierBase::operator-> const):
(JSC::WriteBarrierBase::clear):
(JSC::WriteBarrierBase::slot):
(JSC::WriteBarrierBase::operator bool const):
(JSC::WriteBarrierBase::setWithoutWriteBarrier):
(JSC::WriteBarrierBase::unvalidatedGet const):
(JSC::operator==):
- runtime/WriteBarrierInlines.h:
(JSC::Traits>::set):
(JSC::Traits>::setMayBeNull):
(JSC::Traits>::setEarlyValue):
(JSC::DumbValueTraits<Unknown>>::set):
- wasm/WasmInstance.h:
- wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::JSWebAssemblyInstance):
(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):
(JSC::JSWebAssemblyInstance::create):
- wasm/js/JSWebAssemblyInstance.h:
(JSC::JSWebAssemblyInstance::offsetOfPoisonedCallee):
- wasm/js/JSWebAssemblyMemory.h:
- wasm/js/JSWebAssemblyModule.h:
- wasm/js/JSWebAssemblyTable.cpp:
(JSC::JSWebAssemblyTable::JSWebAssemblyTable):
(JSC::JSWebAssemblyTable::grow):
(JSC::JSWebAssemblyTable::clearFunction):
- wasm/js/JSWebAssemblyTable.h:
- wasm/js/WasmToJS.cpp:
(JSC::Wasm::materializeImportJSCell):
(JSC::Wasm::handleBadI64Use):
(JSC::Wasm::wasmToJS):
- wasm/js/WebAssemblyFunctionBase.h:
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):
- wasm/js/WebAssemblyModuleRecord.h:
- wasm/js/WebAssemblyToJSCallee.h:
- wasm/js/WebAssemblyWrapperFunction.h:
Source/WTF:
Supporting changes needed to allow poisoning of WriteBarrier
objects.
- WTF.xcodeproj/project.pbxproj:
- wtf/DumbPtrTraits.h:
- wtf/DumbValueTraits.h: Copied from Source/WTF/wtf/DumbPtrTraits.h.
(WTF::DumbValueTraits::exchange):
(WTF::DumbValueTraits::swap):
(WTF::DumbValueTraits::unwrap):
- wtf/Forward.h:
- wtf/Poisoned.h:
(WTF::ConstExprPoisonedValueTraits::exchange):
(WTF::ConstExprPoisonedValueTraits::swap):
(WTF::ConstExprPoisonedValueTraits::unwrap):
- 3:35 PM Changeset in webkit [226919] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] CTFontCopyDefaultCascadeListForLanguages() can return nullptr
https://bugs.webkit.org/show_bug.cgi?id=181615
<rdar://problem/36334637>
Reviewed by Jon Lee.
Speculative fix. We are getting crash reports saying that this call can return nullptr, and we
don't check for it.
No new tests because I couldn't find the specific input that causes it to return nullptr. (I
tried running this code with every 0, 1, and 2 length locale string, every weight value, and
every italic value, and couldn't get it to crash. I also inspected the code to figure out what
values would cause it to return nullptr, and I couldn't find anything other than if the system
has a totally busted font setup.)
- platform/graphics/cocoa/FontDescriptionCocoa.cpp:
(WebCore::SystemFontDatabase::computeCascadeList):
- 3:29 PM Changeset in webkit [226918] by
-
- 2 edits2 moves in trunk/Tools
webkitpy: Refactor simulator code (Part 4)
https://bugs.webkit.org/show_bug.cgi?id=180555
<rdar://problem/36131381>
Reviewed by Aakash Jain.
Move new_simulated_device.py to simulated_device.py.
- Scripts/webkitpy/port/ios_simulator.py: Update import statement.
- Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
- Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
- Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
- Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
- 3:15 PM Changeset in webkit [226917] by
-
- 2 edits in branches/safari-605-branch/Source/JavaScriptCore
Cherry-pick r226840. rdar://problem/36479468
- 3:01 PM Changeset in webkit [226916] by
-
- 7 edits2 adds in trunk
[WebGL] Simulated vertexAttrib0 can sometimes cause OUT_OF_MEMORY errors
https://bugs.webkit.org/show_bug.cgi?id=181558
<rdar://problem/36189833>
Reviewed by Eric Carlson.
Source/WebCore:
Very large element indices in the ELEMENT_ARRAY_BUFFER meant that
our simulated vertexAttrib0 buffer might be too large. We need
to check for out-of-memory, but we can also detect some of the issues
earlier in our validation code. Additionally, make sure that we don't
accidentally cast an unsigned to a signed.
Test: fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::validateIndexArrayConservative): Update validation
code to look for overflow, rather than relying on looking for sign changes.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateIndexArrayConservative): Ditto.
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContextBase::drawArrays): Check that we were able to simulate.
(WebCore::WebGLRenderingContextBase::drawElements):
(WebCore::WebGLRenderingContextBase::validateSimulatedVertexAttrib0): Update validation code, and
use GC3Duint, since that's what the indicies are.
(WebCore::WebGLRenderingContextBase::simulateVertexAttrib0): Ditto.
(WebCore::WebGLRenderingContextBase::drawArraysInstanced): Check that we were able to simulate.
(WebCore::WebGLRenderingContextBase::drawElementsInstanced):
- html/canvas/WebGLRenderingContextBase.h:
LayoutTests:
- fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies-expected.txt: Added.
- fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html: Added.
- platform/mac/TestExpectations: Test crashes on Sierra and earlier.
- 2:00 PM Changeset in webkit [226915] by
-
- 2 edits in trunk/Source/WebCore
Large in-place attachment elements cause the document width to expand when inserted
https://bugs.webkit.org/show_bug.cgi?id=181614
Reviewed by Dan Bernstein.
Make in-place images and videos have a max-width of 100%, so that large attachments aren't inserted with full
display size, causing the document and viewport width to expand.
- html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::populateShadowRootIfNecessary):
- 1:47 PM Changeset in webkit [226914] by
-
- 11 edits2 deletes in trunk/Source/WebInspectorUI
Web Inspector: Drop support for iOS 7 targets
https://bugs.webkit.org/show_bug.cgi?id=181549
<rdar://problem/36444813>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-12
Reviewed by Brian Burg.
- Versions/Inspector-iOS-7.0.json: Removed.
- UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js: Removed.
Remove protocol snapshot and generated commands for iOS 7.
- UserInterface/Base/Main.js:
- UserInterface/Controllers/BreakpointPopoverController.js:
(WI.BreakpointPopoverController.prototype._createPopoverContent):
- UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype._setBreakpoint):
- UserInterface/Controllers/SourceMapManager.js:
(WI.SourceMapManager.prototype._loadAndParseSourceMap):
- UserInterface/Models/Instrument.js:
(WI.Instrument.startLegacyTimelineAgent):
- UserInterface/Models/ResourceTimingData.js:
- UserInterface/Models/ScriptTimelineRecord.js:
(WI.ScriptTimelineRecord.EventType.displayName):
- UserInterface/Models/SourceMapResource.js:
(WI.SourceMapResource.prototype.requestContentFromBackend):
- UserInterface/Protocol/CSSObserver.js:
(WI.CSSObserver.prototype.regionLayoutUpdated): Deleted.
- UserInterface/Protocol/RemoteObject.js:
(WI.RemoteObject.fromPayload):
Remove code that was only necessary to support iOS 7.
- 1:39 PM Changeset in webkit [226913] by
-
- 4 edits in trunk/Source
Logged JSON should escape "'s and \'s in strings.
https://bugs.webkit.org/show_bug.cgi?id=181608
Reviewed by Brent Fulgham.
Source/WebCore:
No new tests -- no new functionality, just changed logging. The
efficacy of the logging was verified by inspecting its output.
- loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
Source/WebKit:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::logCookieInformation const):
- 1:38 PM Changeset in webkit [226912] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fixing error in UIKitSPI.h.
- Platform/spi/ios/UIKitSPI.h:
- 1:32 PM Changeset in webkit [226911] by
-
- 4 edits in trunk/Source/WebKit
Implement MultiDocument protocol for restoring focus to a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=181510
Reviewed by Dan Bernstein.
Support the UIKit protocol for restoring focus to a what previously had focus.
WebKit already knows what node was previously being focused by the DOM, we merely
need to be asked to turn the focus on again.
Resubmitting https://trac.webkit.org/changeset/226826 as it broke internal builds
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _restoreFocusWithToken:]):
(-[WKContentView _preserveFocusWithToken:destructively:]):
- 1:30 PM Changeset in webkit [226910] by
-
- 56 edits2 deletes in branches/safari-605-branch/Source/WebCore
Revert r226007. rdar://problem/36072040
- 1:03 PM Changeset in webkit [226909] by
-
- 5 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Support JSX (React) syntax highlighting
https://bugs.webkit.org/show_bug.cgi?id=181607
<rdar://problem/36442564>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-12
Reviewed by Brian Burg.
- UserInterface/Base/MIMETypeUtilities.js:
(WI.mimeTypeForFileExtension):
(WI.fileExtensionForMIMEType):
- UserInterface/Models/Resource.js:
Support the jsx extension and mime types.
- UserInterface/Main.html:
- Scripts/update-codemirror-resources.rb:
- UserInterface/External/CodeMirror/jsx.js: Added.
Include new mode from CodeMirror@d8926768.
- 1:01 PM Changeset in webkit [226908] by
-
- 3 edits2 adds in trunk
drawElements should be invalid if vertexAttrib0 doesn't have data
https://bugs.webkit.org/show_bug.cgi?id=181609
<rdar://problem/36392883>
Reviewed by Antoine Quint.
Source/WebCore:
If a vertex attribute has been enabled, but no data provided, then
draw validation should fail.
Test: fast/canvas/webgl/drawElements-empty-vertex-data.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateVertexAttributes): If there were
never any data in the vertex buffer, then we incorrectly compared with 0.
LayoutTests:
- fast/canvas/webgl/drawElements-empty-vertex-data-expected.txt: Added.
- fast/canvas/webgl/drawElements-empty-vertex-data.html: Added.
- 12:47 PM Changeset in webkit [226907] by
-
- 14 edits1 add in trunk
CheckStructure can be incorrectly subsumed by CheckStructureOrEmpty
https://bugs.webkit.org/show_bug.cgi?id=181177
<rdar://problem/36205704>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/check-structure-ir-ensures-empty-does-not-flow-through.js: Added.
(runNearStackLimit.t):
(runNearStackLimit):
(test.f):
(test):
Source/JavaScriptCore:
The semantics of CheckStructure are such that it does not allow the empty value to flow through it.
However, we may eliminate a CheckStructure if it's preceded by a CheckStructureOrEmpty. This doesn't
have semantic consequences when validation is turned off. However, with validation on, this trips up
our OSR exit machinery that says when an exit is allowed to happen.
Consider the following IR:
a: GetClosureVar Or any other node that produces BytecodeTop
...
c: CheckStructure(Cell:@a, {s2})
d: PutByOffset(KnownCell:@a, KnownCell:@a, @value)
In the TypeCheckHoistingPhase, we may insert CheckStructureOrEmptys like this:
a: GetClosureVar
e: CheckStructureOrEmpty(@a, {s1})
...
f: CheckStructureOrEmpty(@a, {s2})
c: CheckStructure(Cell:@a, {s2})
d: PutByOffset(KnownCell:@a, KnownCell:@a, @value)
This will cause constant folding to change the IR to:
a: GetClosureVar
e: CheckStructureOrEmpty(@a, {s1})
...
f: CheckStructureOrEmpty(@a, {s2})
d: PutByOffset(KnownCell:@a, KnownCell:@a, @value)
Our mayExit analysis determines that the PutByOffset should not exit. Note
that AI will determine the only value the PutByOffset can see in @a is
the empty value. Because KnownCell filters SpecCell and not SpecCellCheck,
when lowering the PutByOffset, we reach a contradiction in AI and emit
an OSR exit. However, because mayExit said we couldn't exit, we assert.
Note that if we did not run the TypeCheckHoistingPhase on this IR, AI
would have determined we would OSR exit at the second CheckStructure.
This patch makes it so constant folding produces the following IR:
a: GetClosureVar
e: CheckStructureOrEmpty(@a, {s1})
g: AssertNotEmpty(@a)
...
f: CheckStructureOrEmpty(@a, {s2})
h: AssertNotEmpty(@a)
d: PutByOffset(KnownCell:@a, KnownCell:@a, @value)
This modification will cause AI to know we will OSR exit before even reaching
the PutByOffset. Note that in the original IR, the GetClosureVar won't
actually produce the TDZ value. If it did, bytecode would have caused us
to emit a CheckNotEmpty before the CheckStructure/PutByOffset combo. That's
why this bug is about IR bookkeeping and not an actual error in IR analysis.
This patch introduces AssertNotEmpty instead of using CheckNotEmpty to be
more congruous with CheckStructure's semantics of crashing on the empty value
as input (on 64 bit platforms).
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileAssertNotEmpty):
- 12:41 PM Changeset in webkit [226906] by
-
- 12 edits in trunk
FormDataElement::lengthInBytes should use ThreadableBlobRegistry
https://bugs.webkit.org/show_bug.cgi?id=181554
Patch by Youenn Fablet <youenn@apple.com> on 2018-01-12
Reviewed by Chris Dumez.
Source/WebCore:
Covered by updated test.
Fix blobRegistry() use and add support for creating a response that may trigger the issue.
- platform/network/FormData.cpp:
(WebCore::FormDataElement::lengthInBytes const): Was using directly blobRegistry() while ThreadableBlobRegistry is more appropriate
in case this is called from workers.
- Modules/fetch/FetchBody.h:
- Modules/fetch/FetchResponse.h:
- fileapi/Blob.h:
- testing/ServiceWorkerInternals.cpp:
(WebCore::ServiceWorkerInternals::createOpaqueWithBlobBodyResponse):
- testing/ServiceWorkerInternals.h:
- testing/ServiceWorkerInternals.idl:
LayoutTests:
- http/tests/workers/service/resources/service-worker-cache-api-worker.js:
(async):
(event.event.request.url.indexOf): Deleted.
(event.event.request.url.endsWith): Deleted.
(event.event.respondWith.promise.then): Deleted.
- http/tests/workers/service/service-worker-cache-api.https-expected.txt:
- http/tests/workers/service/service-worker-cache-api.https.html:
- 12:01 PM Changeset in webkit [226905] by
-
- 4 edits in trunk/Source/WebCore
Wrap CDMFairPlayStreaming and related classes in ENABLE(ENCRYPTED_MEDIA) checks
https://bugs.webkit.org/show_bug.cgi?id=181602
Reviewed by Maciej Stachowiak.
- platform/graphics/avfoundation/CDMFairPlayStreaming.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
- 11:43 AM Changeset in webkit [226904] by
-
- 19 edits5 adds in trunk
WebProcess should pass the registration identifier and not the worker identifier for fetch events
https://bugs.webkit.org/show_bug.cgi?id=181591
Patch by Youenn Fablet <youenn@apple.com> on 2018-01-12
Reviewed by Chris Dumez.
Source/WebCore:
Test: http/wpt/service-workers/update-service-worker.https.html
Store service worker registration identifier in ResourceLoaderOptions instead of service worker identifier.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
- loader/ResourceLoaderOptions.h:
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::prepareFetch):
(WebCore::CachedResourceLoader::determineRevalidationPolicy const):
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setSelectedServiceWorkerRegistrationIdentifierIfNeeded):
(WebCore::CachedResourceRequest::setNavigationServiceWorkerRegistrationData):
(WebCore::CachedResourceRequest::setSelectedServiceWorkerIdentifierIfNeeded): Deleted.
- loader/cache/CachedResourceRequest.h:
- workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::loadAsynchronously):
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::activeWorkerFromRegistrationID):
- workers/service/server/SWServer.h:
Source/WebKit:
Use service worker registration identifier to compute the active service worker identifier responsible to handle the fetch event.
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::startFetch):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::start):
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::startFetch):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::shouldHandleFetch):
LayoutTests:
- http/wpt/service-workers/resources/empty.html: Added.
- http/wpt/service-workers/update-service-worker.https-expected.txt: Added.
- http/wpt/service-workers/update-service-worker.https.html: Added.
- http/wpt/service-workers/update-worker.py: Added.
(main):
- 11:21 AM Changeset in webkit [226903] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed, rolling out r226826.
Breaks internal builds.
Reverted changeset:
"Implement MultiDocument protocol for restoring focus to a
WKWebView"
https://bugs.webkit.org/show_bug.cgi?id=181510
https://trac.webkit.org/changeset/226826
- 11:19 AM Changeset in webkit [226902] by
-
- 3 edits in trunk/LayoutTests
fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=181569
rdar://problem/34117680
Reviewed by Zalan Bujtas.
Wait a tick before starting the rotation, otherwise -[WKWebView _beginAnimatedResizeWithUpdates:]
can bail because the unobscuredRect is empty.
Also wait for both the rotation UI script to complete, and the receipt of the
orientationchange event.
- fast/events/ios/rotation/layout-viewport-during-safari-type-rotation.html:
- fast/events/ios/rotation/resources/rotation-utils.js:
(doTest):
- 11:05 AM Changeset in webkit [226901] by
-
- 3 edits1 delete in trunk/Source/WebCore
[Win][CMake] Remove all-in-one file for WebCore DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=181582
Patch by Fujii Hironori <Fujii Hironori> on 2018-01-12
Reviewed by Alex Christensen.
Those source files are compiled in unified source build nowadays.
No new tests (No behavior change)
- CMakeLists.txt: Removed calling PROCESS_ALLINONE_FILE.
- DerivedSources.cpp: Removed.
- WebCoreMacros.cmake: Removed a macro PROCESS_ALLINONE_FILE.
- 10:52 AM Changeset in webkit [226900] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo][CMake] Use ${CURL_LIBRARY} instead of specifying the library name libcurl_imp explicitly
https://bugs.webkit.org/show_bug.cgi?id=181578
Patch by Fujii Hironori <Fujii Hironori> on 2018-01-12
Reviewed by Alex Christensen.
vcpkg has libcurl.lib, not libcurl_imp.lib.
No new tests because no behavior change.
- PlatformWinCairo.cmake: Link ${CURL_LIBRARY} instead of libcurl_imp.
- 10:49 AM Changeset in webkit [226899] by
-
- 10 edits in trunk/Source/WebKit
[WK2] Unify macOS and iOS codepaths in the UI process when starting a drag
https://bugs.webkit.org/show_bug.cgi?id=181574
Reviewed by Tim Horton.
Rearrange some macOS drag start logic in the UI process so that it uses the same codepaths in WebPageProxy as
iOS. Namely, startDrag should just forward the DragItem and drag image handle along to the appropriate views on
each platform (WKContentView and WebViewImpl).
There should be no change in behavior.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
Both macOS and iOS now funnel through this method.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::startDrag):
(WebKit::WebViewImpl::dragImageForView): Deleted.
Rename dragImageForView to startDrag. Move the call to didStartDrag() here, and call dragCancelled() in the
case where we bailed from starting the drag (due to failing to create a drag image).
- UIProcess/PageClient.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::setDragImage): Deleted.
Rename setDragImage to startDrag.
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::startDrag):
(WebKit::PageClientImpl::setDragImage): Deleted.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::startDrag): Deleted.
- 10:30 AM Changeset in webkit [226898] by
-
- 2 edits in trunk/Source/WebCore
WebGL video texture black in Safari 11.0.2 and wrong colored in Safari Preview 11.1
https://bugs.webkit.org/show_bug.cgi?id=181445
<rdar://problem/36383183>
Reviewed by Dean Jackson.
Tests: added compile-time correctness tests for YCbCrMatrix values.
Perform the derivation from YCbCr coefficients into matrices in constexpr expressions
at compile-time. This allows us to also perform compile-time correctness checks to catch
regressions which may cause incorrect color conversions.
Since we now have general-purpose derivation of matrix values from coefficients,
adding missing specificed matrices is trivial, so add support for SMPTE 240M and BT.2020
matrices.
- platform/graphics/cv/VideoTextureCopierCV.cpp:
(WebCore::GLfloatColor::GLfloatColor):
(WebCore::GLfloatColor::abs):
(WebCore::GLfloatColor::isApproximatelyEqualTo const):
(WebCore::YCbCrMatrix::operator Vector<GLfloat> const):
(WebCore::YCbCrMatrix::YCbCrMatrix):
(WebCore::YCbCrMatrix::operator* const):
(WebCore::YCbCrToRGBMatrixForRangeAndTransferFunction):
- 10:26 AM Changeset in webkit [226897] by
-
- 3 edits in trunk/Tools
REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
https://bugs.webkit.org/show_bug.cgi?id=181595
This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
I change the < and > to $ to make this test pass and continue to test what it used to.
- TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
- TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
(-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
- 9:39 AM Changeset in webkit [226896] by
-
- 2 edits in trunk/LayoutTests
Skipped http/tests/resourceLoadStatistics/grandfathering.html on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=181482
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 9:32 AM Changeset in webkit [226895] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: Remove unnecessary raw pointer in InspectorConsoleAgent
https://bugs.webkit.org/show_bug.cgi?id=181579
<rdar://problem/36193759>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-01-12
Reviewed by Brian Burg.
- inspector/agents/InspectorConsoleAgent.h:
- inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::clearMessages):
(Inspector::InspectorConsoleAgent::addConsoleMessage):
Switch from a raw pointer to m_consoleMessages.last().
Also move the expiration check into the if block since it can only
happen inside here when the number of console messages changes.
(Inspector::InspectorConsoleAgent::discardValues):
Also clear the expired message count when messages are cleared.
- 9:28 AM Changeset in webkit [226894] by
-
- 9 edits in branches/safari-605-branch
Cherry-pick r226745. rdar://problem/36392368
- 8:36 AM Changeset in webkit [226893] by
-
- 6 edits in branches/safari-605-branch
Cherry-pick r226825. rdar://problem/36458902
- 8:36 AM Changeset in webkit [226892] by
-
- 48 edits5 moves1 add1 delete in branches/safari-605-branch/Source
Cherry-pick r226822. rdar://problem/36458924
- 7:21 AM Changeset in webkit [226891] by
-
- 3 edits in branches/safari-605-branch
Cherry-pick r226813. rdar://problem/36458922
- 7:21 AM Changeset in webkit [226890] by
-
- 8 edits in branches/safari-605-branch
Cherry-pick r226792. rdar://problem/36450742
- 7:21 AM Changeset in webkit [226889] by
-
- 3 edits in branches/safari-605-branch/LayoutTests
Cherry-pick r226785. rdar://problem/36450812
- 7:21 AM Changeset in webkit [226888] by
-
- 4 edits in branches/safari-605-branch/LayoutTests
Cherry-pick r226771. rdar://problem/36450734
- 7:21 AM Changeset in webkit [226887] by
-
- 2 edits in branches/safari-605-branch/LayoutTests
Cherry-pick r226731. rdar://problem/36450734
- 5:26 AM Changeset in webkit [226886] by
-
- 21 edits2 adds in trunk
Add support for the frames() timing function
https://bugs.webkit.org/show_bug.cgi?id=181585
<rdar://problem/36463317>
Reviewed by Dean.
Source/WebCore:
Implement the frames() timing function as specified in the CSS Timing Functions Level 1
specification, specifically https://www.w3.org/TR/css-timing-1/#frames-timing-functions.
A frames timing function is a type of timing function that divides the input time into a
specified number of intervals of equal length.
Test: transitions/frames-timing-function.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::createTimingFunctionValue):
- css/CSSTimingFunctionValue.cpp:
(WebCore::CSSFramesTimingFunctionValue::customCSSText const):
(WebCore::CSSFramesTimingFunctionValue::equals const):
- css/CSSTimingFunctionValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals const):
(WebCore::CSSValue::cssText const):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isFramesTimingFunctionValue const):
- css/CSSValueKeywords.in:
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeSteps):
(WebCore::consumeFrames):
(WebCore::consumeAnimationTimingFunction):
- platform/animation/TimingFunction.cpp:
(WebCore::operator<<):
(WebCore::TimingFunction::transformTime const):
- platform/animation/TimingFunction.h:
(WebCore::TimingFunction::isFramesTimingFunction const):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::animationHasFramesTimingFunction):
(WebCore::GraphicsLayerCA::animationCanBeAccelerated const):
Source/WebKit:
Add the ability to endode and decode the frames() timing function.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<FramesTimingFunction>::encode):
(IPC::ArgumentCoder<FramesTimingFunction>::decode):
- Shared/WebCoreArgumentCoders.h:
- WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:
(WebKit::PlatformCAAnimationRemote::Properties::encode const):
(WebKit::PlatformCAAnimationRemote::Properties::decode):
LayoutTests:
Add a new test that checks that the frames() timing function applies as expected
and expand an existing test to check that the frames() timing function is parsed
correctly. We also mark progressions in imported WPT tests.
- imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-output-expected.txt:
- imported/w3c/web-platform-tests/css-timing-1/frames-timing-functions-syntax-expected.txt:
- transitions/frames-timing-function-expected.txt: Added.
- transitions/frames-timing-function.html: Added.
- transitions/transitions-parsing-expected.txt:
- transitions/transitions-parsing.html:
- 4:16 AM Changeset in webkit [226885] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC] Create parallel SlotVisitors apriori
https://bugs.webkit.org/show_bug.cgi?id=180907
Reviewed by Saam Barati.
The number of SlotVisitors are capped with the number of HeapHelperPool's threads + 2.
If we create these SlotVisitors apropri, we do not need to create SlotVisitors dynamically.
Then we do not need to grab locks while iterating all the SlotVisitors.
In addition, we do not need to consider the case that the number of SlotVisitors increases
after setting up VisitCounters in MarkingConstraintSolver since the number of SlotVisitors
does not increase any more.
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::runBeginPhase):
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::forEachSlotVisitor):
(JSC::Heap::numberOfSlotVisitors): Deleted.
- heap/MarkingConstraintSolver.cpp:
(JSC::MarkingConstraintSolver::didVisitSomething const):
- 3:26 AM Changeset in webkit [226884] by
-
- 4 edits in releases/WebKitGTK/webkit-2.18/WebDriverTests
Merge r226764 - Unreviewed. Update W3C WebDriver imported tests.
- imported/w3c/importer.json:
- imported/w3c/webdriver/tests/sessions/new_session/invalid_capabilities.py:
- imported/w3c/webdriver/tests/sessions/new_session/support/create.py:
- 3:26 AM Changeset in webkit [226883] by
-
- 2 edits in releases/WebKitGTK/webkit-2.18/Tools
Merge r226711 - WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
https://bugs.webkit.org/show_bug.cgi?id=181474
Reviewed by Carlos Alberto Lopez Perez.
We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
name as the name.
- Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
(WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
(WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
- 3:26 AM Changeset in webkit [226882] by
-
- 25 edits1 copy5 moves6 adds1 delete in releases/WebKitGTK/webkit-2.18/WebDriverTests
Merge r226708 - Unreviewed. Update W3C WebDriver imported tests.
- imported/w3c/importer.json:
- imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py:
- imported/w3c/tools/wptrunner/wptrunner/browsers/servo.py:
- imported/w3c/tools/wptrunner/wptrunner/environment.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/executorservo.py:
- imported/w3c/tools/wptrunner/wptrunner/executors/pytestrunner/runner.py:
- imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
- imported/w3c/tools/wptrunner/wptrunner/update/update.py:
- imported/w3c/tools/wptrunner/wptrunner/webdriver_server.py:
- imported/w3c/tools/wptrunner/wptrunner/wptlogging.py:
- imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
- imported/w3c/webdriver/OWNERS:
- imported/w3c/webdriver/interface/interface.html: Removed.
- imported/w3c/webdriver/tests/actions/modifier_click.py:
- imported/w3c/webdriver/tests/actions/mouse.py:
- imported/w3c/webdriver/tests/actions/mouse_dblclick.py: Added.
- imported/w3c/webdriver/tests/actions/sequence.py:
- imported/w3c/webdriver/tests/actions/support/mouse.py: Added.
- imported/w3c/webdriver/tests/cookies/add_cookie.py:
- imported/w3c/webdriver/tests/cookies/get_named_cookie.py:
- imported/w3c/webdriver/tests/element_retrieval/init.py: Copied from WebDriverTests/imported/w3c/webdriver/tests/retrieval/init.py.
- imported/w3c/webdriver/tests/element_retrieval/find_element.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_element.py.
- imported/w3c/webdriver/tests/element_retrieval/find_element_from_element.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_element_from_element.py.
- imported/w3c/webdriver/tests/element_retrieval/find_elements.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_elements.py.
- imported/w3c/webdriver/tests/element_retrieval/find_elements_from_element.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/find_element_from_elements.py.
- imported/w3c/webdriver/tests/element_send_keys/init.py: Renamed from WebDriverTests/imported/w3c/webdriver/tests/retrieval/init.py.
- imported/w3c/webdriver/tests/element_send_keys/interactability.py: Added.
- imported/w3c/webdriver/tests/element_send_keys/scroll_into_view.py: Added.
- imported/w3c/webdriver/tests/execute_script/cyclic.py: Added.
- imported/w3c/webdriver/tests/get_window_rect.py:
- imported/w3c/webdriver/tests/interface.html:
- imported/w3c/webdriver/tests/navigation/current_url.py:
- imported/w3c/webdriver/tests/support/asserts.py:
- imported/w3c/webdriver/tests/support/fixtures.py:
- 2:15 AM Changeset in webkit [226881] by
-
- 3 edits1 add in trunk
Each variant of a polymorphic inlined call should be exitOK at the top of the block
https://bugs.webkit.org/show_bug.cgi?id=181562
<rdar://problem/36445624>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/each-block-at-top-of-polymorphic-call-inlining-should-be-exitOK.js: Added.
(f):
(foo):
Source/JavaScriptCore:
Before this patch, the very first block in the switch for polymorphic call
inlining will have exitOK at the top. The others are not guaranteed to.
That was just a bug. They're all exitOK at the top. This will lead to crashes
in FixupPhase because we won't have a node in a block that has ExitOK, so
when we fixup various type checks, we assert out.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
- 12:39 AM Changeset in webkit [226880] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r226721.
https://bugs.webkit.org/show_bug.cgi?id=181583
Lets do a slightly different fix (Requested by anttik on
#webkit).
Reverted changeset:
"REGRESSION(r225650): The scores of MotionMark tests Multiply
and Leaves dropped by 8%"
https://bugs.webkit.org/show_bug.cgi?id=181460
https://trac.webkit.org/changeset/226721
