Timeline
May 8, 2018:
- 11:29 PM Changeset in webkit [231547] by
-
- 2 edits in trunk/Source/JavaScriptCore
[MIPS] Collect callee-saved register using inline assembly
https://bugs.webkit.org/show_bug.cgi?id=185428
Patch by Dominik Infuehr <dinfuehr@igalia.com> on 2018-05-08
Reviewed by Yusuke Suzuki.
MIPS used setjmp instead of collecting registers with inline assembly like
other architectures.
- heap/RegisterState.h:
- 11:01 PM Changeset in webkit [231546] by
-
- 2 edits in trunk/Source/JavaScriptCore
[BigInt] Simplifying JSBigInt by using bool addition
https://bugs.webkit.org/show_bug.cgi?id=185374
Reviewed by Alex Christensen.
Since using TWO_DIGIT does not produce good code, we remove this part from digitAdd and digitSub.
Just adding overflow flag to carry/borrow produces setb + add in x86.
Also we annotate small helper functions and accessors with
inlinenot to call these functions
inside internalMultiplyAdd loop.
- runtime/JSBigInt.cpp:
(JSC::JSBigInt::isZero):
(JSC::JSBigInt::inplaceMultiplyAdd):
(JSC::JSBigInt::digitAdd):
(JSC::JSBigInt::digitSub):
(JSC::JSBigInt::digitMul):
(JSC::JSBigInt::digitPow):
(JSC::JSBigInt::digitDiv):
(JSC::JSBigInt::offsetOfData):
(JSC::JSBigInt::dataStorage):
(JSC::JSBigInt::digit):
(JSC::JSBigInt::setDigit):
- 10:50 PM Changeset in webkit [231545] by
-
- 5 edits2 adds in branches/safari-605-branch
Cherry-pick r231441. rdar://problem/40050720
WebGL: Reset simulated values after validation fails
https://bugs.webkit.org/show_bug.cgi?id=185363
<rdar://problem/39733417>
Reviewed by Anders Carlsson.
Source/WebCore:
While fixing a previous bug, I forgot to reset some values
when validation fails. This caused a bug where a subsequent
invalid call might use those values and escape detection.
Test: fast/canvas/webgl/index-validation-with-subsequent-draws.html
- html/canvas/WebGLRenderingContextBase.cpp: (WebCore::WebGLRenderingContextBase::simulateVertexAttrib0): Reset the sizes when validation fails.
- html/canvas/WebGLRenderingContextBase.h:
LayoutTests:
- fast/canvas/webgl/index-validation-with-subsequent-draws-expected.txt: Added.
- fast/canvas/webgl/index-validation-with-subsequent-draws.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:50 PM Changeset in webkit [231544] by
-
- 6 edits2 adds in branches/safari-605-branch
Cherry-pick r231236. rdar://problem/40050705
Source/WebCore:
Prevent Debug ASSERT when changing forms
https://bugs.webkit.org/show_bug.cgi?id=185173
<rdar://problem/39738669>
Reviewed by Ryosuke Niwa.
Form submission could trigger a debug assertion during validation when
a form is changed during an input submission. Fix this by cleaning up
the event handling logic and make it more consistent with modern WebKit
coding style.
Test: fast/forms/form-submission-crash-3.html
- html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::defaultEventHandler): Make sure layout runs before attempting to perform event handling.
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::reportValidity): Ditto. (WebCore::HTMLFormElement::validateInteractively): Remove call to perform layout here, since we expect this to happen earlier in the layout pass. Add an assertion that the tree is not dirty.
- html/ImageInputType.cpp: (WebCore::ImageInputType::handleDOMActivateEvent): Make sure layout runs before attempting to perform event handling.
- html/SubmitInputType.cpp: (WebCore::SubmitInputType::handleDOMActivateEvent): Ditto.
LayoutTests:
Prevent assertion when changing forms
https://bugs.webkit.org/show_bug.cgi?id=185173
<rdar://problem/39738669>
Reviewed by Ryosuke Niwa.
- fast/forms/form-submission-crash-3-expected.txt: Added.
- fast/forms/form-submission-crash-3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:01 PM Changeset in webkit [231543] by
-
- 3 edits in branches/safari-605-branch/JSTests
Cherry-pick r230972. rdar://problem/40050818
Gardening: test fix after r230863.
https://bugs.webkit.org/show_bug.cgi?id=184846
<rdar://problem/39390672>
Not reviewed.
- stress/json-stringified-overflow-2.js: (catch):
- stress/json-stringified-overflow.js: (catch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:01 PM Changeset in webkit [231542] by
-
- 4 edits1 add in branches/safari-605-branch
Cherry-pick r230863. rdar://problem/40050818
Handle more JSON stringify OOM
https://bugs.webkit.org/show_bug.cgi?id=184846
<rdar://problem/39390672>
Reviewed by Mark Lam.
JSTests:
- stress/json-stringified-overflow-2.js: Added. Same as the one below, but with a bigger input which will trigger a different code path. (catch):
- stress/json-stringified-overflow.js: Modify the test to only catch OOM on stringification. not on string creation.
Source/WTF:
JSON stringification can OOM easily. Here's another case.
- wtf/text/StringBuilderJSON.cpp: (WTF::StringBuilder::appendQuotedJSONString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:01 PM Changeset in webkit [231541] by
-
- 4 edits in branches/safari-605-branch/Source/WebCore
Cherry-pick r231335. rdar://problem/40050807
Widgets should hold a WeakPtr to their parents
https://bugs.webkit.org/show_bug.cgi?id=185239
<rdar://problem/39741250>
Reviewed by Zalan Bujtas.
- platform/ScrollView.h: (WebCore::ScrollView::weakPtrFactory): Added.
- platform/Widget.cpp: (WebCore::Widget::init): Don't perform an unnecessary assignment. (WebCore::Widget::setParent): Grab a WeakPtr to the parent ScrollView.
- platform/Widget.h: (WebCore::Widget::parent const): Change type to a WeakPtr.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:01 PM Changeset in webkit [231540] by
-
- 2 edits in branches/safari-605-branch/Source/JavaScriptCore
Cherry-pick r231332. rdar://problem/40050814
Unreviewed, fix 32-bit profile offset for change in bytecode
length of the get_by_id and get_array_length opcodes.
- llint/LowLevelInterpreter32_64.asm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:01 PM Changeset in webkit [231539] by
-
- 3 edits1 add in branches/safari-605-branch
Cherry-pick r230980. rdar://problem/40050820
fromCharCode is missing some exception checks
https://bugs.webkit.org/show_bug.cgi?id=184952
Reviewed by Saam Barati.
JSTests:
- stress/fromCharCode-exception-check.js: Added. (get catch):
Source/JavaScriptCore:
I also removed the pointless slow path function and moved it into the
main function.
- runtime/StringConstructor.cpp: (JSC::stringFromCharCode): (JSC::stringFromCharCodeSlowCase): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:32 PM Changeset in webkit [231538] by
-
- 2 edits in trunk/Source/WebCore
Disable system preview link fetching
https://bugs.webkit.org/show_bug.cgi?id=185463
Reviewed by Jon Lee.
Temporarily disable system preview detection when a link
is clicked.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick):
- 9:14 PM Changeset in webkit [231537] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the internal iOS build
Add a missing import statement in an implementation file.
- editing/cocoa/WebContentReaderCocoa.mm:
- 6:48 PM Changeset in webkit [231536] by
-
- 11 edits in trunk/Source
Adopt new async _savecookies SPI for keeping networking process active during flushing cookies
https://bugs.webkit.org/show_bug.cgi?id=185261
<rdar://problem/37214391>
Patch by Sihui Liu <sihui_liu@apple.com> on 2018-05-08
Reviewed by Chris Dumez.
Source/WebCore/PAL:
- pal/spi/cf/CFNetworkSPI.h:
Source/WebKit:
By adopting new async SPI _savecookies, we can keep networking process active(not suspended)
until cookies are fully synced to disk with process assertion.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didSyncAllCookies):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::syncAllCookies):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::syncAllCookies):
(WebKit::NetworkProcessProxy::didSyncAllCookies):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::syncNetworkProcessCookies):
- 6:34 PM Changeset in webkit [231535] by
-
- 3 edits in trunk/Source/WebKit
Set colorspace in the PDF plugin.
https://bugs.webkit.org/show_bug.cgi?id=185445
<rdar://problem/40030981>
Reviewed by Simon Fraser.
- WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
- 6:11 PM Changeset in webkit [231534] by
-
- 2 edits in trunk/Source/JavaScriptCore
Replace multiple Watchpoint Set fireAll() methods with templates
https://bugs.webkit.org/show_bug.cgi?id=185456
Reviewed by Saam Barati.
Refactored to minimize duplicate code.
- bytecode/Watchpoint.h:
(JSC::WatchpointSet::fireAll):
(JSC::InlineWatchpointSet::fireAll):
- 5:41 PM Changeset in webkit [231533] by
-
- 2 edits in trunk/Source/WebKit
Don't clear selection until we are actually interacting with a Node.
https://bugs.webkit.org/show_bug.cgi?id=185455
Reviewed by Wenson Hsieh.
The presence of TextInteractionAssistant should not be used as a proxy for it we are actually editing content.
We need to check to see if we have an active node, and then we should clear the selection.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setSelectedTextRange:]):
- 5:40 PM Changeset in webkit [231532] by
-
- 25 edits1 delete in trunk/Source
Unreviewed, rolling out r231486.
Caused service worker LayoutTest failures on macOS Debug WK2.
Reverted changeset:
"Allow WebResourceLoader to cancel a load served from a
service worker"
https://bugs.webkit.org/show_bug.cgi?id=185274
https://trac.webkit.org/changeset/231486
- 5:37 PM Changeset in webkit [231531] by
-
- 6 edits2 deletes in trunk
Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
https://bugs.webkit.org/show_bug.cgi?id=185340
Reviewed by Tim Horton.
Source/WebCore:
WebContentReader::readURL is currently the only method implemented separately in iOS and macOS platform
WebContentReader files. The implementation across macOS and iOS is nearly identical (with some exceptions with
the way iOS handles file URLs and plain text editing), so we can merge these into a single method
WebContentReaderCocoa and delete WebContentReaderIOS and WebContentReaderMac.
This also has the added bonus of fixing a latent bug in WebContentReaderMac, wherein URLs written to the
pasteboard using -[NSPasteboard writeObjects:] are currently pasted as empty anchor elements. In this case, the
link title isn't made explicit, so thetitlepassed in to WebContentReader::readURL is empty. On iOS, we have
code to fall back to pasting the absolute string of the URL if the title is empty, but on macOS, we'll just use
this empty string as the title of the anchor.
Test: PasteMixedContent.PasteURLWrittenToPasteboardUsingWriteObjects
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj:
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::WebContentReader::readURL):
- editing/ios/WebContentReaderIOS.mm: Removed.
- editing/mac/WebContentReaderMac.mm: Removed.
Tools:
Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
non-empty text in a contenteditable.
- TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
(TestWebKitAPI::TEST):
- 5:31 PM Changeset in webkit [231530] by
-
- 2 edits in trunk/Source/WebKit
[iOS] _WKWebViewPrintFormatter should return a page count of 0 for PDF documents that do not allow printing
https://bugs.webkit.org/show_bug.cgi?id=185133
Reviewed by Andreas Kling.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView _ensureDocumentForPrinting]):
(-[WKPDFView _wk_pageCountForPrintFormatter:]):
(-[WKPDFView _wk_printedDocument]):
- 5:20 PM Changeset in webkit [231529] by
-
- 6 edits in trunk/Source/WebCore
[Simple line layout] Cache run resolver.
https://bugs.webkit.org/show_bug.cgi?id=185411
Reviewed by Antti Koivisto.
This patch caches the run resolver on the [SimpleLine]Layout object.
In certain cases, when the block container has thousands of elements (foobar1<br>foobar2<br>.....foobar9999<br>),
constructing the resolver (and its dependencies) in a repeating fashion could hang the WebProcess.
Covered by existing tests.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::create):
(WebCore::SimpleLineLayout::Layout::create):
(WebCore::SimpleLineLayout::Layout::Layout):
- rendering/SimpleLineLayout.h:
(WebCore::SimpleLineLayout::Layout::runResolver const):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
(WebCore::SimpleLineLayout::hitTestFlow):
(WebCore::SimpleLineLayout::collectFlowOverflow):
(WebCore::SimpleLineLayout::computeBoundingBox):
(WebCore::SimpleLineLayout::computeFirstRunLocation):
(WebCore::SimpleLineLayout::collectAbsoluteRects):
(WebCore::SimpleLineLayout::collectAbsoluteQuads):
(WebCore::SimpleLineLayout::textOffsetForPoint):
(WebCore::SimpleLineLayout::collectAbsoluteQuadsForRange):
(WebCore::SimpleLineLayout::generateLineBoxTree):
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::LineResolver::LineResolver):
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::lineResolver):
- 5:13 PM Changeset in webkit [231528] by
-
- 2 edits in trunk/Source/WebKit
[iOS] WKPDFView remains in the view hierarchy after navigating away
https://bugs.webkit.org/show_bug.cgi?id=185449
<rdar://problem/39693469>
Reviewed by Tim Horton.
WKPDFView removes the PDF host view from the view hierarchy in its -dealloc
method, and relies on WKWebView releasing its last reference in
-_setHasCustomContentView:loadedMIMEType: when the user navigates.
However, WKWPDFView was capturing a strong reference to self in the block passed
to +[PDFHostViewController createHostView:forExtensionIdentifier:], and PDFKit
(actually UIKit) is retaining this block beyond its being called. This results in
the PDF host view remaining as a child of the WKScrollView even after the user
navigates to another page.
Changed the aforementioned block to a lambda that captures a weak reference to
self to prevent WKPDFView from outliving the current navigation.
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView retain]):
(-[WKPDFView web_setContentProviderData:suggestedFilename:]):
- 5:09 PM Changeset in webkit [231527] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Console drawer resizing is broken when console prompt has >1 line of code
https://bugs.webkit.org/show_bug.cgi?id=185369
<rdar://problem/40013202>
Reviewed by Devin Rousso.
Mouse offset calculation should account for the height of the quick console.
The only reason resizing worked with the single-line quick console is that
the offset calculation included the resizer height, which is very close
to that of the single-line quick console (27px and 30px respectively).
- UserInterface/Views/ConsoleDrawer.js:
- 5:04 PM Changeset in webkit [231526] by
-
- 4 edits in trunk
test262/Runner.pm: create results dir for results of test262 run
https://bugs.webkit.org/show_bug.cgi?id=185392
Patch by Valerie R Young <valerie@bocoup.com> on 2018-05-08
Reviewed by Michael Saboff.
.:
Remove reference to no longer existing files.
- .gitignore:
Tools:
New directory test262-results created from where ever script is
called.
- Scripts/test262/Runner.pm:
(processCLI):
- 5:00 PM Changeset in webkit [231525] by
-
- 2 edits in trunk/Tools
test262/Runner.pm: lower number of processes per core
https://bugs.webkit.org/show_bug.cgi?id=185426
Patch by Valerie R Young <valerie@bocoup.com> on 2018-05-08
Reviewed by Michael Saboff.
- Scripts/test262/Runner.pm:
(getProcesses):
- 4:59 PM Changeset in webkit [231524] by
-
- 3 edits in trunk/Source/WebKit
Storage Access API: Make user opt-in sticky
https://bugs.webkit.org/show_bug.cgi?id=185454
<rdar://problem/40003946>
Reviewed by Alex Christensen.
This patch persists the user's choice to opt-in to access under specific domains.
Such storage access should age out with the accessing domain's cookies and website
data. The opt-in prompt is still an experimental feature.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::hasStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessInternal):
(WebKit::WebResourceLoadStatisticsStore::hasUserGrantedStorageAccessThroughPrompt const):
(WebKit::WebResourceLoadStatisticsStore::hasHadUnexpiredRecentUserInteraction const):
- UIProcess/WebResourceLoadStatisticsStore.h:
- 4:33 PM Changeset in webkit [231523] by
-
- 1 edit4 adds in trunk/Tools
Test262-Runner: Add base Perl UnicodeData
https://bugs.webkit.org/show_bug.cgi?id=185444
Patch by Leo Balter <Leo Balter> on 2018-05-08
Reviewed by Michael Saboff.
- Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
- Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
- 4:30 PM Changeset in webkit [231522] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG::FlowMap::resize() shouldn't resize the shadow map unless we're in SSA
https://bugs.webkit.org/show_bug.cgi?id=185453
Reviewed by Michael Saboff.
Tiny improvement for compile times.
- dfg/DFGFlowMap.h:
(JSC::DFG::FlowMap::resize): Remove one Vector::resize() when we're not in SSA.
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::beginBasicBlock): Record some data about how long we spend in different parts of this and add a FIXME linking bug 185452.
- 4:28 PM Changeset in webkit [231521] by
-
- 4 edits in trunk
Do not apply X-Frame-Options and CSP frame-ancestors to Quick Look-applicable responses in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=185442
<rdar://problem/40067209>
Reviewed by Andy Estes.
Source/WebKit:
Just as we exempt responses in WebContent process that will be handled by Quick Look from the Content
Security Policy frame-ancestors directive and X-Frame-Options checking we need to do the same when
such checks are performed in NetworkProcess following r231479.
HTTP responses that will be previewed using Quick Look are not considered web pages and are subject
to the security model for Quick Look documents. That is, they are exempt from Content Security Policy
and X-Frame-Options processing.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions):
LayoutTests:
Remove test http/tests/quicklook/csp-header-ignored.html from TestExpectations now that it passes.
- platform/ios/TestExpectations:
- 4:26 PM Changeset in webkit [231520] by
-
- 2 edits in trunk/Source/WebCore
Switch some RELEASE_ASSERTS to plain debug ASSERTS in PlatformScreenMac.mm
https://bugs.webkit.org/show_bug.cgi?id=185451
<rdar://problem/39620348>
Reviewed by Zalan Bujtas.
Change a set of RELEASE_ASSERTS used to prevent accessing NSScreen related functions in the
PlatformScreenMac implementation to less expensive Debug ASSERTS.
No change in behavior.
- platform/mac/PlatformScreenMac.mm:
(WebCore::screenHasInvertedColors):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenRectForDisplay):
(WebCore::screenRect):
(WebCore::screenAvailableRect):
(WebCore::screenColorSpace):
(WebCore::screenSupportsExtendedColor):
- 4:22 PM Changeset in webkit [231519] by
-
- 4 edits2 adds in trunk
Add tests to ensure that the Strong Password appearance is removed on form reset
https://bugs.webkit.org/show_bug.cgi?id=185440
Reviewed by Ryosuke Niwa.
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
(-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
- TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(TEST):
LayoutTests:
- fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset-expected.html: Added.
- fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html: Added.
- 4:20 PM Changeset in webkit [231518] by
-
- 7 edits in trunk/Source/JavaScriptCore
Deferred firing of structure transition watchpoints is racy
https://bugs.webkit.org/show_bug.cgi?id=185438
Reviewed by Saam Barati.
Changed DeferredStructureTransitionWatchpointFire to take the watchpoints to fire
and fire them in the destructor. When the watchpoints are taken from the
original WatchpointSet, that WatchpointSet if marked invalid.
- bytecode/Watchpoint.cpp:
(JSC::WatchpointSet::fireAllSlow):
(JSC::WatchpointSet::take):
(JSC::DeferredWatchpointFire::DeferredWatchpointFire):
(JSC::DeferredWatchpointFire::~DeferredWatchpointFire):
(JSC::DeferredWatchpointFire::fireAll):
(JSC::DeferredWatchpointFire::takeWatchpointsToFire):
- bytecode/Watchpoint.h:
(JSC::WatchpointSet::fireAll):
(JSC::InlineWatchpointSet::fireAll):
- runtime/JSObject.cpp:
(JSC::JSObject::setPrototypeDirect):
(JSC::JSObject::convertToDictionary):
- runtime/JSObjectInlines.h:
(JSC::JSObject::putDirectInternal):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::DeferredStructureTransitionWatchpointFire::DeferredStructureTransitionWatchpointFire):
(JSC::DeferredStructureTransitionWatchpointFire::~DeferredStructureTransitionWatchpointFire):
(JSC::DeferredStructureTransitionWatchpointFire::dump const):
(JSC::Structure::didTransitionFromThisStructure const):
(JSC::DeferredStructureTransitionWatchpointFire::add): Deleted.
- runtime/Structure.h:
(JSC::DeferredStructureTransitionWatchpointFire::structure const):
- 4:16 PM Changeset in webkit [231517] by
-
- 7 edits6 adds in trunk
Resign Strong Password appearance when text field value changes
https://bugs.webkit.org/show_bug.cgi?id=185433
<rdar://problem/39958508>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Remove the Strong Password decoration when the text field's value changes to avoid interfering
with web sites that allow a person to clear the password field.
Tests: fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html
fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html
fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::resignStrongPasswordAppearance): Extracted from HTMLInputElement::updateType().
(WebCore::HTMLInputElement::updateType): Extract out logic to resign the Strong Password appearance
into a function that can be shared by this function and HTMLInputElement::setValue().
(WebCore::HTMLInputElement::setValue): Resign the Strong Password appearance if this field was
changed programmatically (i.e. no DOM change event was dispatched).
- html/HTMLInputElement.h:
Tools:
Add a unit test to ensure the injected bundle API and WebKit UI delegate SPI is invoked
when the field has the Strong Password button and its value changes.
- TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
(testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
(TEST):
LayoutTests:
Add a test to ensure we remove the Strong Password appearance when the value of the text field value changes.
- fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes-expected.html: Added.
- fast/forms/auto-fill-button/auto-fill-strong-password-button-when-maxlength-changes.html: Added.
- fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes-expected.html: Added.
- fast/forms/auto-fill-button/auto-fill-strong-password-button-when-minlength-changes.html: Added.
- fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes-expected.html: Added.
- fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-value-changes.html: Added.
- fast/forms/auto-fill-button/resources/process-auto-fill-button-type-and-invoke-runTest.js: Add support for
setting the autofilled state of a field.
(window.onload):
- 4:12 PM Changeset in webkit [231516] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; add missing function definition.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::didPassCORSAccessCheck const):
- 2:53 PM Changeset in webkit [231515] by
-
- 5 edits in trunk
Consecutive messages logged as JSON are coalesced
https://bugs.webkit.org/show_bug.cgi?id=185432
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/ConsoleMessage.cpp:
(Inspector::ConsoleMessage::isEqual const): Messages with JSON arguments are not equal.
LayoutTests:
- inspector/console/webcore-logging-expected.txt:
- inspector/console/webcore-logging.html:
- 2:49 PM Changeset in webkit [231514] by
-
- 14 edits in trunk
InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
https://bugs.webkit.org/show_bug.cgi?id=185365
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch does three things to improve compile times:
- Fixes some inlining goofs.
- Adds the ability to measure compile times with run-jsc-benchmarks.
- Dramatically improves the performance of InPlaceAbstractState::beginBasicBlock by removing the code that clears abstract values. It turns out that on constant folding "needed" this, in the sense that this was the only thing protecting it from loading the abstract value of a no-result node and then concluding that because it had a non-empty m_value, it could be constant-folded. Any node that produces a result will explicitly set its abstract value, so this problem can also be guarded by just having constant folding check if the node it wants to fold returns any result.
Solid 0.96% compile time speed-up across SunSpider-CompileTime and V8Spider-CompileTime.
Rolling back in after fixing cloop build.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::merge):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::doToChildrenWithNode):
(JSC::DFG::Graph::doToChildren):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::beginBasicBlock):
- jit/JIT.cpp:
(JSC::JIT::totalCompileTime):
- jit/JIT.h:
- jsc.cpp:
(GlobalObject::finishCreation):
(functionTotalCompileTime):
Source/WTF:
Fix some inlining goof-ups.
Rolling back in after fixing cloop build.
- wtf/TinyPtrSet.h:
(WTF::TinyPtrSet::add):
(WTF::TinyPtrSet::merge):
(WTF::TinyPtrSet::addOutOfLine):
(WTF::TinyPtrSet::mergeOtherOutOfLine):
Tools:
Make it possible to measure compile times.
Rolling back in after fixing cloop builds.
- Scripts/run-jsc-benchmarks:
- 2:32 PM Changeset in webkit [231513] by
-
- 6 edits5 adds in trunk
Mute MediaElementSourceNode when tainted.
https://bugs.webkit.org/show_bug.cgi?id=184866
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin.html
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::wouldTaintOrigin const):
- Modules/webaudio/AudioContext.h:
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
(WebCore::MediaElementAudioSourceNode::wouldTaintOrigin):
(WebCore::MediaElementAudioSourceNode::process):
- Modules/webaudio/MediaElementAudioSourceNode.h:
LayoutTests:
- http/tests/media/resources/1000Hz-sin.wav: Added.
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin-expected.txt: Added.
- http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html: Added.
- http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin-expected.txt: Added.
- http/tests/security/webaudio-render-remote-audio-blocked-no-crossorigin.html: Added.
- 2:22 PM Changeset in webkit [231512] by
-
- 3 edits in trunk/Source/WebCore
Log rtcstats as JSON
https://bugs.webkit.org/show_bug.cgi?id=185437
<rdar://problem/40065332>
Reviewed by Youenn Fablet.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::RTCStatsLogger::RTCStatsLogger): Create a wrapper class so we don't have to add a
toJSONString method to libwebrtc.
(WebCore::RTCStatsLogger::toJSONString const): Log stats as JSON.
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered): Don't use the LOGIDENTIFIER macro because
it doesn't work well inside of a lambda.
(WTF::LogArgument<WebCore::RTCStatsLogger>::toString): Move into .cpp file because it is only
used here.
- Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
(WTF::LogArgument<webrtc::RTCStats>::toString): Deleted. Move to .cpp file.
- 2:19 PM Changeset in webkit [231511] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r230743): Mousemove events are not coalesced properly, mousemove/drag is very laggy
https://bugs.webkit.org/show_bug.cgi?id=185425
<rdar://problem/39323336>
Reviewed by Simon Fraser.
When mousemove events come in faster than they can be processed, we should coalesce
pending mousemoves that have not yet been sent to WebProcess. This has the effect of
processing the most recent mousemove location, which is the old behavior that regressed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleMouseEvent):
If there is >1 event in the mouse queue, then the first one is being processed by WebProcess
and the second one is eligible for coalescing. Replace it if the last event and new event
are both mousemoves.
- 1:34 PM Changeset in webkit [231510] by
-
- 6 edits1 add in trunk/Source/WebKit
The PDF context menu should not be created in the WebContent process.
https://bugs.webkit.org/show_bug.cgi?id=185401
Reviewed by Tim Horton.
Send a sync IPC message from the WebContent process to the UI process with the necessary context
menu information when the menu is requested. The NSMenu will then be created and shown in the
UI process. The reply will contain the selected menu item index.
- Shared/mac/PDFContextMenu.h: Added.
(WebKit::PDFContextMenuItem::encode const):
(WebKit::PDFContextMenuItem::decode):
(WebKit::PDFContextMenu::encode const):
(WebKit::PDFContextMenu::decode):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(-[WKPDFMenuTarget menuItem]):
(-[WKPDFMenuTarget contextMenuAction:]):
(WebKit::WebPageProxy::showPDFContextMenu):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::handleContextMenuEvent):
- 1:29 PM Changeset in webkit [231509] by
-
- 2 edits in trunk/LayoutTests
Skip test http/tests/appcache/x-frame-options-prevents-framing.php for now in WebKit2.
Will address in <https://bugs.webkit.org/show_bug.cgi?id=185443>.
- platform/wk2/TestExpectations:
- 1:16 PM Changeset in webkit [231508] by
-
- 2 edits in trunk/Tools
[iOS] WKAttachmentTestsIOS.InsertDroppedItemProvidersInOrder fails after r231396
https://bugs.webkit.org/show_bug.cgi?id=185414
Reviewed by Tim Horton.
Adjust a test expectation to check that the resulting DOM contains an attachment element,
anchor element, and another attachment element in that order. This ensures that the test
still passes, even after the anchor element is followed by a line break.
- TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(TestWebKitAPI::TEST):
- 1:12 PM Changeset in webkit [231507] by
-
- 11 edits in trunk/Source
System Preview links should trigger a download
https://bugs.webkit.org/show_bug.cgi?id=185439
<rdar://problem/40065545>
Reviewed by Jon Lee.
Source/WebCore:
Add a new field to FrameLoadRequest, which then is copied
into ResourceRequest, identifying if the link clicked
is a system preview.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick): Look for isSystemPreviewLink().
- loader/FrameLoadRequest.cpp:
(WebCore::FrameLoadRequest::FrameLoadRequest):
- loader/FrameLoadRequest.h: New property.
(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isSystemPreview const):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadURL):
- loader/FrameLoader.h:
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::isSystemPreview const):
(WebCore::ResourceRequestBase::setSystemPreview):
- platform/network/ResourceRequestBase.h:
Source/WebKit:
Encode the new field identifying a system preview. And
if you encounter such a resource request, trigger
a download.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<ResourceRequest>::encode):
(IPC::ArgumentCoder<ResourceRequest>::decode):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- 12:42 PM Changeset in webkit [231506] by
-
- 6 edits2 adds in branches/safari-605-branch
Cherry-pick r231291. rdar://problem/40050729
Use RetainPtr for form input type
https://bugs.webkit.org/show_bug.cgi?id=185210
<rdar://problem/39734040>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Refactor our HTMLInputElement class to store its InputType member as a RefPtr.
Test: fast/forms/access-key-mutation-2.html.
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::HTMLInputElement): (WebCore::HTMLInputElement::didAddUserAgentShadowRoot): (WebCore::HTMLInputElement::accessKeyAction): (WebCore::HTMLInputElement::parseAttribute): (WebCore::HTMLInputElement::appendFormData):
- html/HTMLInputElement.h:
- html/InputType.cpp: (WebCore::createInputType): (WebCore::InputType::create): (WebCore::InputType::createText):
- html/InputType.h:
LayoutTests:
- fast/forms/access-key-mutation-2-expected.txt: Added.
- fast/forms/access-key-mutation-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:42 PM Changeset in webkit [231505] by
-
- 3 edits1 add in branches/safari-605-branch
Cherry-pick r231196. rdar://problem/40050709
IntlObject.cpp::removeUnicodeLocaleExtension() should not touch locales that end in '-u'
https://bugs.webkit.org/show_bug.cgi?id=185162
Reviewed by Filip Pizlo.
JSTests:
- stress/incomplete-unicode-locale.js: Added. (catch):
Source/JavaScriptCore:
- runtime/IntlObject.cpp: (JSC::removeUnicodeLocaleExtension):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:42 PM Changeset in webkit [231504] by
-
- 3 edits1 add in branches/safari-605-branch
Cherry-pick r231187. rdar://problem/39987469
Improve the performance of FontCascadeDescription's effectiveFamilies
https://bugs.webkit.org/show_bug.cgi?id=184720
PerformanceTests:
Reviewed by Simon Fraser.
This performance test calls SystemFontDatabase::systemFontCascadeList() around 2,000,000 times (before
this patch is applied), which is roughly equivalent to the page we found the performance problem on.
The calling pattern is roughly equivalent in this test.
- Layout/system-ui.html: Added.
Source/WebCore:
<rdar://problem/38970927>
Reviewed by Simon Fraser.
The page that had the performance problem renders many different Chinese characters in system-ui
with only a small number of individual fonts. It turns out we were calling into the system-ui
machinery for each character in order to opportunistically start loading data URLs (see also:
https://bugs.webkit.org/show_bug.cgi?id=175845). These data URLS will never represent the system
font, so we don't need to invoke the system-ui machinery at all.
This patch makes a 92x performance improvement on the associated performance test. This test is
designed to test Chinese text rendered with system-ui.
Performance test: Layout/system-ui.html
- platform/graphics/FontCascadeFonts.cpp: (WebCore::opportunisticallyStartFontDataURLLoading):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:42 PM Changeset in webkit [231503] by
-
- 4 edits1 add in branches/safari-605-branch
Cherry-pick r231034. rdar://problem/40050717
In FTLLowerDFGToB3.cpp::compileCreateRest, always use a contiguous array as the indexing type when under isWatchingHavingABadTimeWatchpoint
https://bugs.webkit.org/show_bug.cgi?id=184773
<rdar://problem/37773612>
Reviewed by Filip Pizlo.
JSTests:
This bug requires a race between the thread doing FTL compilation and the main thread, but it triggers in 100% of cases (before the fix) on my machine
so I decided to add it to the stress tests nonetheless.
- stress/create-rest-while-having-a-bad-time.js: Added. (f): (g): (h):
Source/JavaScriptCore:
We were calling restParameterStructure(), which returns arrayStructureForIndexingTypeDuringAllocation(ArrayWithContiguous).
arrayStructureForIndexingTypeDuringAllocation uses m_arrayStructureForIndexingShapeDuringAllocation, which is set to SlowPutArrayStorage when we are 'having a bad time'.
This is problematic, because the structure is then passed to allocateUninitializedContiguousJSArray, which ASSERTs that the indexing type is contiguous (or int32).
We solve the problem by using originalArrayStructureForIndexingType which always returns a structure with the right indexing type (contiguous), even if we are having a bad time.
This is safe, as we are under isWatchingHavingABadTimeWatchpoint, so if we have a bad time, the code we generate will never be installed.
- ftl/FTLLowerDFGToB3.cpp: (JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:42 PM Changeset in webkit [231502] by
-
- 3 edits4 adds in branches/safari-605-branch
Cherry-pick r230740. rdar://problem/40050731
A put is not an ExistingProperty put when we transition a structure because of an attributes change
https://bugs.webkit.org/show_bug.cgi?id=184706
<rdar://problem/38871451>
Reviewed by Saam Barati.
JSTests:
- stress/put-by-id-direct-strict-transition.js: Added. (const.foo): (j.const.obj.set hello):
- stress/put-by-id-direct-transition.js: Added. (const.foo): (j.const.obj.set hello):
- stress/put-getter-setter-by-id-strict-transition.js: Added. (const.foo): (j.const.obj.set hello):
- stress/put-getter-setter-by-id-transition.js: Added. (const.foo): (j.const.obj.set hello):
Source/JavaScriptCore:
When putting a property on a structure and the slot is a different
type, the slot can't be said to have already been existing.
- runtime/JSObjectInlines.h: (JSC::JSObject::putDirectInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [231501] by
-
- 7 edits in trunk/Source/WebKit
Storage Access API: Add a request roundtrip to check whether prompting is needed
https://bugs.webkit.org/show_bug.cgi?id=185368
<rdar://problem/40011556>
Reviewed by Alex Christensen and Youenn Fablet.
This patch adds an enum WebKit::StorageAccessStatus to handle our three access
states:
- WebKit::StorageAccessStatus::CannotRequestAccess.
This means the domain is blocked from cookie access.
- WebKit::StorageAccessStatus::RequiresUserPrompt.
This means that access has not been granted yet and a prompt is required.
- WebKit::StorageAccessStatus::HasAccess.
This either means that this domain does not need to ask for access,
access was already granted, or access was granted now.
If the call to WebResourceLoadStatisticsStore::requestStorageAccess() comes
back as WebKit::StorageAccessStatus::RequiresUserPrompt, the WebPageProxy
prompts the user and if the user said yes, calls a direct
WebResourceLoadStatisticsStore::grantStorageAccess().
Existing test cases pass because requestStorageAccessConfirm in WKPage.cpp
does not have m_client.requestStorageAccessConfirm and thus returns true.
- UIProcess/Network/NetworkProcessProxy.messages.in:
Added a missing #endif.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestStorageAccess):
Here we now handle the various cases encoded in WebKit::StorageAccessStatus.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
Now covers the optional prompt case.
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessInternal):
Granting access is broken out to allow WebKit::WebPageProxy to call it
directly.
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::requestStorageAccess):
(WebKit::WebsiteDataStore::grantStorageAccess):
Piping through calls from from WebKit::WebResourceLoadStatisticsStore
to WebKit::WebPageProxy.
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 12:34 PM Changeset in webkit [231500] by
-
- 2 edits in trunk/LayoutTests
Mark test http/tests/quicklook/csp-header-ignored.html as Failure.
Will fix in <https://bugs.webkit.org/show_bug.cgi?id=185442>.
- platform/ios/TestExpectations:
- 12:23 PM Changeset in webkit [231499] by
-
- 8 edits in trunk/LayoutTests
Some appcache crash tests are flaky due to console messages
https://bugs.webkit.org/show_bug.cgi?id=185431
Reviewed by Geoffrey Garen.
Mark 3 tests that were written to test crashes as DumpJSConsoleLogInStdErr.
It is better to mark them as such than to changing them since they might no longer cover the crash reasons.
Rebase two other tests that might need further work to stop being flaky.
- TestExpectations:
- http/tests/appcache/404-resource-with-slow-main-resource-expected.txt:
- http/tests/appcache/abort-cache-onchecking-manifest-404-expected.txt:
- http/tests/appcache/deferred-events-expected.txt:
- http/tests/appcache/fail-on-update-2-expected.txt:
- http/tests/appcache/fail-on-update-expected.txt:
- platform/mac/TestExpectations:
- 11:58 AM Changeset in webkit [231498] by
-
- 4 edits in trunk/Source/WebKit
Unreviewed, rolling out r231376 and r231458.
Caused some API tests failures on iOS
Reverted changesets:
"[iOS] Apps that are not visible may not get suspended if they
trigger page loads while in the background"
https://bugs.webkit.org/show_bug.cgi?id=185318
https://trac.webkit.org/changeset/231376
"[iOS] Release page load process assertion if the screen is
locked"
https://bugs.webkit.org/show_bug.cgi?id=185333
https://trac.webkit.org/changeset/231458
- 11:57 AM Changeset in webkit [231497] by
-
- 8 edits1 copy in trunk/Source
Use thumbnails in System Previews
https://bugs.webkit.org/show_bug.cgi?id=185397
<rdar://problem/40039376>
Reviewed by Jon Lee.
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
- pal/spi/ios/SystemPreviewSPI.h: New file holding the non-public parts of System Preview.
Source/WebKit:
A system preview that goes through the WKWebViewContentProvider will
show a static thumbnail/snapshot of the item, rather than jumping
directly to QuickLook.
This means we have to link to the AssetViewer framework. That provides
a ASVThumbnailView that will trigger QuickLook for us.
- Configurations/WebKit.xcconfig: Link to AssetViewer.
- UIProcess/ios/WKSystemPreviewView.h: Better macro use. Remove some unneeded protocols.
- UIProcess/ios/WKSystemPreviewView.mm:
(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]): Update this
to use an ASVThumbnailView, when on the internal SDK (because it is private).
(-[WKSystemPreviewView _layoutThumbnailView]): Use the content insets to put
the thumbnail in the right place.
(-[WKSystemPreviewView thumbnailView:wantsToPresentPreviewController:forItem:]):
Delegate method.
(-[WKSystemPreviewView web_contentView]):
(-[WKSystemPreviewView web_computedContentInsetDidChange]):
(-[WKSystemPreviewView numberOfPreviewItemsInPreviewController:]): Deleted.
(-[WKSystemPreviewView previewController:previewItemAtIndex:]): Deleted.
(-[WKSystemPreviewView previewControllerWillDismiss:]): Deleted.
Source/WTF:
SYSTEM_PREVIEW is only available on some platforms.
- wtf/Platform.h:
- 11:32 AM Changeset in webkit [231496] by
-
- 2 edits in trunk/LayoutTests
Skip http/tests/appcache/load-from-appcache-defer-resume-crash.html for iOS sim WK2
https://bugs.webkit.org/show_bug.cgi?id=185430
Unreviewed.
Skip the test as it is using WK1-only test runner API.
- platform/ios-wk2/TestExpectations:
- 11:27 AM Changeset in webkit [231495] by
-
- 4 edits in trunk
Unreviewed, rolling out r231491.
https://bugs.webkit.org/show_bug.cgi?id=185434
Setting the Created key on a cookie does not work yet, due a
bug in CFNetwork (Requested by ggaren on #webkit).
Reverted changeset:
"[WKHTTPCookieStore getAllCookies] returns inconsistent
creation time"
https://bugs.webkit.org/show_bug.cgi?id=185041
https://trac.webkit.org/changeset/231491
- 11:05 AM Changeset in webkit [231494] by
-
- 3 edits2 moves in trunk
test262/Runner.pm: move input files to JSTests/test262
https://bugs.webkit.org/show_bug.cgi?id=185389
Patch by Valerie R Young <valerie@bocoup.com> on 2018-05-08
Reviewed by Michael Saboff.
JSTests:
- test262/config.yaml: Renamed from Tools/Scripts/test262/config.yaml.
- test262/expectations.yaml: Renamed from Tools/Scripts/test262/expectations.yaml.
Tools:
- Scripts/test262/Runner.pm:
(processCLI):
- 10:56 AM Changeset in webkit [231493] by
-
- 2 edits in trunk/Tools
Unreviewed, simplify Speedometer fixes landed in r231489, r231483 & r231474.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
- 10:52 AM Changeset in webkit [231492] by
-
- 14 edits in trunk
Unreviewed, rolling out r231468.
Broke the CLoop build
Reverted changeset:
"InPlaceAbstractState::beginBasicBlock shouldn't have to clear
any abstract values"
https://bugs.webkit.org/show_bug.cgi?id=185365
https://trac.webkit.org/changeset/231468
- 10:44 AM Changeset in webkit [231491] by
-
- 4 edits in trunk
[WKHTTPCookieStore getAllCookies] returns inconsistent creation time
https://bugs.webkit.org/show_bug.cgi?id=185041
<rdar://problem/34684214>
Patch by Sihui Liu <sihui_liu@apple.com> on 2018-05-08
Reviewed by Geoffrey Garen.
Source/WebCore:
Set creationtime property when creating Cookie object to keep consistency after conversion.
New API test: WebKit.WKHTTPCookieStoreCreationTime.
- platform/network/cocoa/CookieCocoa.mm:
(WebCore::Cookie::operator NSHTTPCookie * const):
Tools:
Add API test Coverage.
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(TEST):
- 10:20 AM Changeset in webkit [231490] by
-
- 4 edits in trunk/Source/WebCore
Text track cue logging should include cue text
https://bugs.webkit.org/show_bug.cgi?id=185353
<rdar://problem/40003565>
Reviewed by Brent Fulgham.
No new tests, tested manually.
- html/track/VTTCue.cpp:
(WebCore::VTTCue::toJSON const):
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::toJSONString const):
- platform/graphics/iso/ISOVTTCue.cpp:
(WebCore::ISOWebVTTCue::toJSONString const):
- 10:15 AM Changeset in webkit [231489] by
-
- 2 edits in trunk/Tools
Unreviewed, fix issue with running Speedometer PerfTest after r231450.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
- 9:34 AM Changeset in webkit [231488] by
-
- 3 edits in trunk/Source/WebCore
More cleanup of XMLHttpRequestUpload
https://bugs.webkit.org/show_bug.cgi?id=185409
Patch by Sam Weinig <sam@webkit.org> on 2018-05-08
Reviewed by Alex Christensen.
- Remove unneeded #includes
- Rename m_xmlHttpRequest to m_request
- Make some overloaded some methods private, and mark them as final rather than override.
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
- xml/XMLHttpRequestUpload.h:
- 9:31 AM Changeset in webkit [231487] by
-
- 4 edits in trunk/Source/WebCore
[LFC] Start using BlockMarginCollapse
https://bugs.webkit.org/show_bug.cgi?id=185424
Reviewed by Antti Koivisto.
BlockMarginCollapse could be all static.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::marginTop const):
(WebCore::Layout::BlockFormattingContext::marginBottom const):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::isMarginTopCollapsedWithSibling):
(WebCore::Layout::isMarginBottomCollapsedWithSibling):
(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::isMarginBottomCollapsedWithParent):
(WebCore::Layout::collapsedMarginTopFromFirstChild):
(WebCore::Layout::collapsedMarginBottomFromLastChild):
(WebCore::Layout::nonCollapsedMarginTop):
(WebCore::Layout::nonCollapsedMarginBottom):
(WebCore::Layout::BlockMarginCollapse::marginTop):
(WebCore::Layout::BlockMarginCollapse::marginBottom):
(WebCore::Layout::BlockMarginCollapse::BlockMarginCollapse): Deleted.
(WebCore::Layout::BlockMarginCollapse::marginTop const): Deleted.
(WebCore::Layout::BlockMarginCollapse::marginBottom const): Deleted.
(WebCore::Layout::BlockMarginCollapse::isMarginTopCollapsedWithSibling const): Deleted.
(WebCore::Layout::BlockMarginCollapse::isMarginBottomCollapsedWithSibling const): Deleted.
(WebCore::Layout::BlockMarginCollapse::isMarginTopCollapsedWithParent const): Deleted.
(WebCore::Layout::BlockMarginCollapse::isMarginBottomCollapsedWithParent const): Deleted.
(WebCore::Layout::BlockMarginCollapse::nonCollapsedMarginTop const): Deleted.
(WebCore::Layout::BlockMarginCollapse::nonCollapsedMarginBottom const): Deleted.
(WebCore::Layout::BlockMarginCollapse::collapsedMarginTopFromFirstChild const): Deleted.
(WebCore::Layout::BlockMarginCollapse::collapsedMarginBottomFromLastChild const): Deleted.
(WebCore::Layout::BlockMarginCollapse::hasAdjoiningMarginTopAndBottom const): Deleted.
- layout/blockformatting/BlockMarginCollapse.h:
- 9:26 AM Changeset in webkit [231486] by
-
- 25 edits1 copy in trunk/Source
Allow WebResourceLoader to cancel a load served from a service worker
https://bugs.webkit.org/show_bug.cgi?id=185274
Reviewed by Chris Dumez.
Source/WebCore:
Add support for cancelling a fetch from WebProcess to service worker process.
Use FetchIdentifier instead of uint64_t.
- Modules/fetch/FetchIdentifier.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- workers/service/context/ServiceWorkerFetch.h:
- workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::startFetch):
(WebCore::ServiceWorkerThreadProxy::cancelFetch):
- workers/service/context/ServiceWorkerThreadProxy.h:
Source/WebKit:
Use FetchIdentifier instead of uint64_t.
Add IPC support for cancelling a fetch from WebProcess to service worker process.
Ask service worker process to cancel the fetch when its corresponding WebResourceLoader is cancelled.
No change of behavior as once a WebResourceLoader is cancelled, any related IPC is not processed.
A follow-up patch should try to cancel the FetchResponse load, meaning to either cancel the network load
or to abort reading the readable stream.
- Scripts/webkit/messages.py:
- StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::cancelFetch):
(WebKit::WebSWServerConnection::startFetch):
(WebKit::WebSWServerConnection::didReceiveFetchResponse):
(WebKit::WebSWServerConnection::didReceiveFetchData):
(WebKit::WebSWServerConnection::didReceiveFetchFormData):
(WebKit::WebSWServerConnection::didFinishFetch):
(WebKit::WebSWServerConnection::didFailFetch):
(WebKit::WebSWServerConnection::didNotHandleFetch):
- StorageProcess/ServiceWorker/WebSWServerConnection.h:
- StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didFailFetch):
(WebKit::StorageProcess::didNotHandleFetch):
(WebKit::StorageProcess::didReceiveFetchResponse):
(WebKit::StorageProcess::didReceiveFetchData):
(WebKit::StorageProcess::didReceiveFetchFormData):
(WebKit::StorageProcess::didFinishFetch):
- StorageProcess/StorageProcess.h:
- StorageProcess/StorageProcess.messages.in:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::remove):
- WebProcess/Storage/ServiceWorkerClientFetch.cpp:
(WebKit::ServiceWorkerClientFetch::create):
(WebKit::ServiceWorkerClientFetch::ServiceWorkerClientFetch):
(WebKit::ServiceWorkerClientFetch::start):
(WebKit::ServiceWorkerClientFetch::cancel):
- WebProcess/Storage/ServiceWorkerClientFetch.h:
- WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::startFetch):
(WebKit::WebSWClientConnection::cancelFetch):
- WebProcess/Storage/WebSWClientConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::cancelFetch):
(WebKit::WebSWContextManagerConnection::startFetch):
- WebProcess/Storage/WebSWContextManagerConnection.h:
- WebProcess/Storage/WebSWContextManagerConnection.messages.in:
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp:
(WebKit::WebServiceWorkerFetchTaskClient::WebServiceWorkerFetchTaskClient):
(WebKit::WebServiceWorkerFetchTaskClient::cancel):
- WebProcess/Storage/WebServiceWorkerFetchTaskClient.h:
- WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::WebServiceWorkerProvider::handleFetch):
(WebKit::WebServiceWorkerProvider::cancelFetch):
(WebKit::WebServiceWorkerProvider::fetchFinished):
- WebProcess/Storage/WebServiceWorkerProvider.h:
- 9:20 AM Changeset in webkit [231485] by
-
- 3 edits2 adds in trunk
feTurbulence is not rendered correctly on Retina display
https://bugs.webkit.org/show_bug.cgi?id=183798
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-05-08
Reviewed by Simon Fraser.
Source/WebCore:
On 2x display the feTurbulence filter creates a scaled ImageBuffer but
processes only the unscaled size. This is a remaining work of r168577 and
is very similar to what was done for the feMorphology filter in r188271.
Test: fast/hidpi/filters-turbulence.html
- platform/graphics/filters/FETurbulence.cpp:
(WebCore::FETurbulence::fillRegion const):
(WebCore::FETurbulence::platformApplySoftware):
LayoutTests:
- fast/hidpi/filters-turbulence-expected.html: Added.
- fast/hidpi/filters-turbulence.html: Added.
- 9:15 AM Changeset in webkit [231484] by
-
- 8 edits in trunk/Source/WebKit
Don't use mapped cache files in case of Class A/B protected app
https://bugs.webkit.org/show_bug.cgi?id=185422
<rdar://problem/34001688>
Reviewed by Chris Dumez.
Currently we don't use shared memory maps in these cases. This still leaves us open for crashes
in the network process when the device is locked.
This patch disables use of blob storage (mapped cache files) in apps that use class A/B protection.
Normally we use blobs for resources > 16KB. Since use of shared memory is already disabled,
the only optimization lost for these apps is body data deduplication.
Any existing cache entries with blobs are ignored and deleted. New entries are created with
body data inlined with the metadata.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::store):
- NetworkProcess/cache/NetworkCache.h:
(WebKit::NetworkCache::Cache::canUseSharedMemoryForBodyData const): Deleted.
- NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord const):
Remove the code the prevented use of shared memory in these cases. Non-mapped Data objects
are never shareable.
(WebKit::NetworkCache::Entry::setNeedsValidation):
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::isSafeToUseMemoryMapForPath):
(WebKit::NetworkCache::canUseSharedMemoryForPath): Deleted.
- NetworkProcess/cache/NetworkCacheFileSystem.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::mayContainBlob const):
(WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob):
(WebKit::NetworkCache::shouldStoreBodyAsBlob): Deleted.
- NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCache::Storage::canUseSharedMemoryForBodyData const): Deleted.
- 7:57 AM WebKitGTK/2.20.x edited by
- (diff)
- 7:02 AM Changeset in webkit [231483] by
-
- 2 edits in trunk/Tools
Unreviewed, fix issue with running Speedometer PerfTest after r231450.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
May 7, 2018:
- 11:09 PM Changeset in webkit [231482] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Add missing exit not included in r231298.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureWebToStorageProcessConnection):
- 11:05 PM Changeset in webkit [231481] by
-
- 2 edits in trunk/Source/WTF
[JSCONLY] Enable ARMv7 DFG
https://bugs.webkit.org/show_bug.cgi?id=185415
Reviewed by Mark Lam.
Enable ARMv7 DFG JIT by default on Linux and FreeBSD.
- wtf/Platform.h:
- 10:26 PM Changeset in webkit [231480] by
-
- 8 edits in trunk/Source/WebCore
[LFC] Add FormattingContext::layoutOutOfFlowDescendants implementation
https://bugs.webkit.org/show_bug.cgi?id=185377
Reviewed by Antti Koivisto.
Also, remove FormattingContext's m_layoutContext member and pass it in to ::layout() instead.
In theory LayoutContext is needed only during ::layout() call.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
- layout/FormattingContext.h:
(WebCore::Layout::FormattingContext::layoutContext const):
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::updateLayout):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout const):
- layout/inlineformatting/InlineFormattingContext.h:
- 10:02 PM Changeset in webkit [231479] by
-
- 29 edits in trunk/Source
Check X-Frame-Options and CSP frame-ancestors in network process
https://bugs.webkit.org/show_bug.cgi?id=185410
<rdar://problem/37733934>
Reviewed by Ryosuke Niwa.
Source/JavaScriptCore:
Add enum traits for MessageSource and MessageLevel so that we can encode and decode them for IPC.
- runtime/ConsoleTypes.h:
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Make PingLoader.h a private header so that we can include it in WebKit.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived): Only check CSP frame-ancestors and X-Frame-Options here if
we are not checking them in the NetworkProcess and HTTP response access is restricted. I code is otherwise kept
unchanged. There may be opportunities to clean this code up more and share more of it. We should look into this
in subsequent bugs.
- loader/DocumentLoader.h: Change visibility of stopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied() from
private to public and export it so that we can call it from the WebKit.
- loader/PingLoader.h:
- page/Settings.yaml: Add a new setting called networkProcessCSPFrameAncestorsCheckingEnabled (defaults: false)
and is hardcoded in WebPage.cpp to be enabled. This setting is used to determine if we will be using the NetworkProcess.
Ideally we wouldn't have this setting and just key off RuntimeEnabledFeatures::sharedFeatures().restrictedHTTPResponseAccess().
However RuntimeEnabledFeatures::sharedFeatures().restrictedHTTPResponseAccess() is always enabled in WebKit Legacy
at the time of writing (why?). And, strangely, RuntimeEnabledFeatures::sharedFeatures().restrictedHTTPResponseAccess()
is conditionally enabled in WebKit. For now, we add a new setting, networkProcessCSPFrameAncestorsCheckingEnabled,
to determine if CSP checking should be performed in NetworkProcess. For checking to actually happen in NetworkProcess
and not in DocumentLoader::responseReceived() RuntimeEnabledFeatures::sharedFeatures().restrictedHTTPResponseAccess()
will also need to be enabled.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowFrameAncestors const): Added a variant that takes a vector of ancestor origins.
- page/csp/ContentSecurityPolicy.h:
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::checkFrameAncestors): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForFrameAncestorOrigins const): Ditto.
- page/csp/ContentSecurityPolicyDirectiveList.h: Export constructor so that we can invoke it from NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions().
- page/csp/ContentSecurityPolicyResponseHeaders.h:
- platform/network/HTTPParsers.h: Export XFrameOptionsDisposition() so that we can use in WebKit.
Source/WebKit:
- NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const): Always encode the frame ancestor origins.
(WebKit::NetworkResourceLoadParameters::decode): Always decode the frame ancestor origins.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::shouldInterruptLoadForXFrameOptions): Added.
(WebKit::NetworkResourceLoader::shouldInterruptLoadForCSPFrameAncestorsOrXFrameOptions): Added.
(WebKit::NetworkResourceLoader::didReceiveResponse): Check if the load needs to be interrupted due
to a violation of the CSP frame-ancestors directive or X-Frame-Options. If there is a violation
then stop the load.
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry): Ditto.
(NetworkResourceLoader::addConsoleMessage): Added.
(NetworkResourceLoader::sendCSPViolationReport): Added.
- NetworkProcess/NetworkResourceLoader.h:
- Scripts/webkit/messages.py: Teach the generator about data types MessageLevel and MessageSource
as they are both defined in file JavaScriptCore/ConsoleTypes.h as opposed to independent headers.
Also tell the generator that these types should not be forward declared so that we can use these
types without their JSC:: prefix in WebPage.messages.in.
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveMessage): Route WebPage messages to the appropriate
web page.
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): Added message StopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::stopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied): Added.
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::addConsoleMessage):
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addConsoleMessage): Added.
(WebKit::WebPage::sendCSPViolationReport): Added.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in: Add messages AddConsoleMessage and SendCSPViolationReport
for adding a console message to Web Inspector and sending a CSP report, respectively.
- 9:19 PM Changeset in webkit [231478] by
-
- 2 edits in trunk
[JSCOnly] Enable Intl.PluralRules
https://bugs.webkit.org/show_bug.cgi?id=185359
Reviewed by Daniel Bates.
Enable Intl.PluralRules because JSCOnly port enables features aggressively.
- Source/cmake/OptionsJSCOnly.cmake:
- 9:18 PM Changeset in webkit [231477] by
-
- 7 edits in trunk/Source/JavaScriptCore
Make a compact version of VariableEnvironment that UnlinkedFunctionExecutable stores and hash-cons these compact environments as we make them
https://bugs.webkit.org/show_bug.cgi?id=185329
<rdar://problem/39961536>
Reviewed by Michael Saboff.
I was made aware of a memory goof inside of JSC where we would inefficiently
use space to represent an UnlinkedFunctionExecutable's parent TDZ variables.
We did two things badly:
- We used a HashMap instead of a Vector to represent the environment. Having
a HashMap is useful when looking things up when generating bytecode, but it's
space inefficient. Because UnlinkedFunctionExecutables live a long time because
of the code cache, we should have them store this information efficiently
inside of a Vector.
- We didn't hash-cons these environments together. If you think about how
some programs are structured, hash-consing these together is hugely profitable.
Consider some code like this:
`
const/let V_1 = ...;
const/let V_2 = ...;
...
const/let V_n = ...;
function f_1() { ... };
function f_2() { ... };
...
function f_n() { ... };
`
Each f_i would store an identical hash map for its parent TDZ variables
consisting of {V_1, ..., V_n}. This was incredibly dumb. With hash-consing,
each f_i just holds onto a reference to the environment.
I benchmarked this change against an app that made heavy use of the
above code pattern and it reduced its peak memory footprint from ~220MB
to ~160MB.
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
- parser/VariableEnvironment.cpp:
(JSC::CompactVariableEnvironment::CompactVariableEnvironment):
(JSC::CompactVariableEnvironment::operator== const):
(JSC::CompactVariableEnvironment::toVariableEnvironment const):
(JSC::CompactVariableMap::get):
(JSC::CompactVariableMap::Handle::~Handle):
- parser/VariableEnvironment.h:
(JSC::VariableEnvironmentEntry::bits const):
(JSC::VariableEnvironmentEntry::operator== const):
(JSC::VariableEnvironment::isEverythingCaptured const):
(JSC::CompactVariableEnvironment::hash const):
(JSC::CompactVariableMapKey::CompactVariableMapKey):
(JSC::CompactVariableMapKey::hash):
(JSC::CompactVariableMapKey::equal):
(JSC::CompactVariableMapKey::makeDeletedValue):
(JSC::CompactVariableMapKey::isHashTableDeletedValue const):
(JSC::CompactVariableMapKey::isHashTableEmptyValue const):
(JSC::CompactVariableMapKey::environment):
(WTF::HashTraits<JSC::CompactVariableMapKey>::emptyValue):
(WTF::HashTraits<JSC::CompactVariableMapKey>::isEmptyValue):
(WTF::HashTraits<JSC::CompactVariableMapKey>::constructDeletedValue):
(WTF::HashTraits<JSC::CompactVariableMapKey>::isDeletedValue):
(JSC::CompactVariableMap::Handle::Handle):
(JSC::CompactVariableMap::Handle::environment const):
(JSC::VariableEnvironment::VariableEnvironment): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 8:51 PM Changeset in webkit [231476] by
-
- 16 edits2 adds in trunk/Source
Abstract logic to log console messages and send CSP violation reports into a client
https://bugs.webkit.org/show_bug.cgi?id=185393
<rdar://problem/40036053>
Reviewed by Brent Fulgham.
Source/WebCore:
First pass at adding infrastructure to supporting CSP reporting from NetworkProcess and workers.
Replaces the existing ContentSecurityPolicy constructor that takes a Frame with one that
takes a ContentSecurityPolicyClient to delegate to for logging and sending reports. We will look
to remove ContentSecurityPolicy constructor that takes a ScriptExecutionContext in a follow up.
Standardize on instantiating a ContentSecurityPolicy with the full URL to resource that it protects
instead of taking only the SecurityOrigin of this URL. By taking the full URL the ContentSecurityPolicy
object is now capable of resolving a relative report URL without needing a Document/ScriptExecutionContext.
We are underutilizing the CSPInfo struct and ContentSecurityPolicyClient::willSendCSPViolationReport()
delegate callback in this patch. We will make use of this functionality in a subsequent patch to
support collecting script state (e.g. source line number) when reporting CSP violations in worker
threads. We also no longer go through the unnecessary motions to try to collect script state for a
frame-ancestors violation (since DocumentLoader extends ContentSecurityPolicyClient and does not
implement ContentSecurityPolicyClient::willSendCSPViolationReport()). The frame-ancestors directive
is checked before a document is parsed and executes script; => there will never be any script state
to collect; => it is not necessary to try to collect it as we currently do.
- Sources.txt: Add file ContentSecurityPolicyClient.cpp. See the remarks for ContentSecurityPolicyClient.cpp
below on why we have this file.
- WebCore.xcodeproj/project.pbxproj: Add files ContentSecurityPolicyClient.{h, cpp}.
- dom/Document.cpp:
(WebCore::Document::initSecurityContext): Pass the URL of the protected document.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived): Ditto.
(WebCore::DocumentLoader::addConsoleMessage): Added.
(WebCore::DocumentLoader::sendCSPViolationReport): Added.
(WebCore::DocumentLoader::dispatchSecurityPolicyViolationEvent): Added.
- loader/DocumentLoader.h:
- loader/FrameLoaderClient.h: Fix typo in comment.
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Pass the URL of the worker script.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy): Added overload that takes a URL&& and an optional
ContentSecurityPolicyClient*.
(WebCore::ContentSecurityPolicy::deprecatedURLForReporting const): Extracted and simplified stripURLForUseInReport()
into this member function.
(WebCore::ContentSecurityPolicy::reportViolation const): Modified to make use of the client, if we have
one and removed code for handling a ContentSecurityPolicy that was instantiated with a Frame.
(WebCore::ContentSecurityPolicy::logToConsole const): Ditto.
(WebCore::stripURLForUseInReport): Deleted; incorporated into ContentSecurityPolicy::deprecatedURLForReporting().
- page/csp/ContentSecurityPolicy.h:
- page/csp/ContentSecurityPolicyClient.cpp: Added. This file exists so that we can define the virtual
destructor out-of-line and export this abstract class so as to avoid the need for the vtable to be
defined in the translation unit of each derived class.
- page/csp/ContentSecurityPolicyClient.h: Added.
- page/csp/ContentSecurityPolicySource.cpp:
(WebCore::ContentSecurityPolicySource::operator SecurityOriginData const): Added.
- page/csp/ContentSecurityPolicySource.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope): Instantiate the ContentSecurityPolicy object with the
URL of the worker script.
Source/WebKit:
For now, build a URL from the source origin associated with the NetworkResourceLoader
and pass this to the ContentSecurityPolicy constructor.
Additionally, make NetworkLoadChecker::contentSecurityPolicy() non-const since it returns
a non-const pointer to a ContentSecurityPolicy object; => callers can mutate this object
right from under NetworkLoadChecker. Making this non-const makes this clear to a reader.
Also remove the mutable keyword from the definition of NetworkLoadChecker::m_contentSecurityPolicy.
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::contentSecurityPolicy):
(WebKit::NetworkLoadChecker::contentSecurityPolicy const): Deleted.
- NetworkProcess/NetworkLoadChecker.h:
- 7:16 PM Changeset in webkit [231475] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, add frame name in form-iframe-target-before-load-crash.html
https://bugs.webkit.org/show_bug.cgi?id=185408
The test started causing flakiness after r231456 because it would submit
the form in the main frame instead of the test frame.
- fast/events/form-iframe-target-before-load-crash.html:
- 6:54 PM Changeset in webkit [231474] by
-
- 2 edits in trunk/Tools
Unreviewed, fix issue with running Speedometer PerfTest after r231450.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
- 6:34 PM Changeset in webkit [231473] by
-
- 3 edits2 adds in trunk
CSS filters which reference SVG filters fail to respect the "color-interpolation-filters" of the filter
https://bugs.webkit.org/show_bug.cgi?id=185343
Reviewed by Dean Jackson.
Source/WebCore:
Test: css3/filters/color-interpolation-filters.html
When applying CSS reference filters, apply the value of "color-interpolation-filters" for the
referenced filter effect element, just as we do for SVG filters.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::buildReferenceFilter):
LayoutTests:
- css3/filters/color-interpolation-filters-expected.html: Added.
- css3/filters/color-interpolation-filters.html: Added.
- 6:13 PM Changeset in webkit [231472] by
-
- 7 edits in trunk/Source/JavaScriptCore
[DFG][MIPS] Simplify DFG code by increasing MIPS temporary registers
https://bugs.webkit.org/show_bug.cgi?id=185371
Reviewed by Mark Lam.
Since MIPS GPRInfo claims it has only 7 registers, some of DFG code exhausts registers.
As a result, we need to maintain separated code for MIPS. This increases DFG maintenance burden,
but actually MIPS have much more registers.
This patch adds $a0 - $a3 to temporary registers. This is OK since our temporary registers can be overlapped with
argument registers (see ARM, X86 implementations). These registers are caller-save ones, so we do not need to
have extra mechanism.
Then, we remove several unnecessary MIPS code in our JIT infrastructure.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- jit/CCallHelpers.h:
- jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
- offlineasm/mips.rb:
- 6:05 PM Changeset in webkit [231471] by
-
- 18 edits3 adds in trunk
DFG AI should have O(1) clobbering
https://bugs.webkit.org/show_bug.cgi?id=185287
Reviewed by Saam Barati.
JSTests:
- stress/simple-ai-effect.js: Added.
(bar):
(foo):
Source/JavaScriptCore:
This fixes an old scalability probem in AI. Previously, if we did clobberWorld(), then we
would traverse all of the state available to the AI at that time and clobber it.
This changes clobberWorld() to be O(1). It just does some math to a clobber epoch.
This is a ~1% speed-up for compile times.
- JavaScriptCore.xcodeproj/project.pbxproj:
- Sources.txt:
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::forNode):
(JSC::DFG::AbstractInterpreter::setForNode):
(JSC::DFG::AbstractInterpreter::clearForNode):
(JSC::DFG::AbstractInterpreter::variables): Deleted.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::clobberWorld):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::forAllValues):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::clobberStructures):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeDoubleUnaryOpEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::fastForwardToSlow):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::fastForwardTo):
(JSC::DFG::AbstractValue::clobberStructuresFor): Deleted.
(JSC::DFG::AbstractValue::observeInvalidationPoint): Deleted.
(JSC::DFG::AbstractValue::observeInvalidationPointFor): Deleted.
- dfg/DFGAbstractValueClobberEpoch.cpp: Added.
(JSC::DFG::AbstractValueClobberEpoch::dump const):
- dfg/DFGAbstractValueClobberEpoch.h: Added.
(JSC::DFG::AbstractValueClobberEpoch::AbstractValueClobberEpoch):
(JSC::DFG::AbstractValueClobberEpoch::first):
(JSC::DFG::AbstractValueClobberEpoch::clobber):
(JSC::DFG::AbstractValueClobberEpoch::observeInvalidationPoint):
(JSC::DFG::AbstractValueClobberEpoch::operator== const):
(JSC::DFG::AbstractValueClobberEpoch::operator!= const):
(JSC::DFG::AbstractValueClobberEpoch::structureClobberState const):
(JSC::DFG::AbstractValueClobberEpoch::clobberEpoch const):
- dfg/DFGAtTailAbstractState.h:
(JSC::DFG::AtTailAbstractState::setForNode):
(JSC::DFG::AtTailAbstractState::clearForNode):
(JSC::DFG::AtTailAbstractState::numberOfArguments const):
(JSC::DFG::AtTailAbstractState::numberOfLocals const):
(JSC::DFG::AtTailAbstractState::operand):
(JSC::DFG::AtTailAbstractState::local):
(JSC::DFG::AtTailAbstractState::argument):
(JSC::DFG::AtTailAbstractState::clobberStructures):
(JSC::DFG::AtTailAbstractState::observeInvalidationPoint):
(JSC::DFG::AtTailAbstractState::variables): Deleted.
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFlowMap.h:
(JSC::DFG::FlowMap::at):
(JSC::DFG::FlowMap::atShadow):
(JSC::DFG::FlowMap::at const):
(JSC::DFG::FlowMap::atShadow const):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::beginBasicBlock):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
- dfg/DFGInPlaceAbstractState.h:
(JSC::DFG::InPlaceAbstractState::forNode):
(JSC::DFG::InPlaceAbstractState::setForNode):
(JSC::DFG::InPlaceAbstractState::clearForNode):
(JSC::DFG::InPlaceAbstractState::variablesForDebugging):
(JSC::DFG::InPlaceAbstractState::numberOfArguments const):
(JSC::DFG::InPlaceAbstractState::numberOfLocals const):
(JSC::DFG::InPlaceAbstractState::operand):
(JSC::DFG::InPlaceAbstractState::local):
(JSC::DFG::InPlaceAbstractState::argument):
(JSC::DFG::InPlaceAbstractState::variableAt):
(JSC::DFG::InPlaceAbstractState::clobberStructures):
(JSC::DFG::InPlaceAbstractState::observeInvalidationPoint):
(JSC::DFG::InPlaceAbstractState::fastForward):
(JSC::DFG::InPlaceAbstractState::variables): Deleted.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetStack):
- 5:28 PM Changeset in webkit [231470] by
-
- 2 edits in trunk/LayoutTests
Update TestExpectations for imported/w3c/web-platform-tests/html/dom/interfaces.worker.html.
https://bugs.webkit.org/show_bug.cgi?id=185407
Unreviewed test gardening.
- 5:08 PM Changeset in webkit [231469] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/security/contentTypeOptions/nosniff-importScript-blocked.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184802
Unreviewed test gardening.
- 5:07 PM Changeset in webkit [231468] by
-
- 14 edits in trunk
InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values
https://bugs.webkit.org/show_bug.cgi?id=185365
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch does three things to improve compile times:
- Fixes some inlining goofs.
- Adds the ability to measure compile times with run-jsc-benchmarks.
- Dramatically improves the performance of InPlaceAbstractState::beginBasicBlock by removing the code that clears abstract values. It turns out that on constant folding "needed" this, in the sense that this was the only thing protecting it from loading the abstract value of a no-result node and then concluding that because it had a non-empty m_value, it could be constant-folded. Any node that produces a result will explicitly set its abstract value, so this problem can also be guarded by just having constant folding check if the node it wants to fold returns any result.
Solid 0.96% compile time speed-up across SunSpider-CompileTime and V8Spider-CompileTime.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::set):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::merge):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::doToChildrenWithNode):
(JSC::DFG::Graph::doToChildren):
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::beginBasicBlock):
- jit/JIT.cpp:
(JSC::JIT::totalCompileTime):
- jit/JIT.h:
- jsc.cpp:
(GlobalObject::finishCreation):
(functionTotalCompileTime):
Source/WTF:
Fix some inlining goof-ups.
- wtf/TinyPtrSet.h:
(WTF::TinyPtrSet::add):
(WTF::TinyPtrSet::merge):
(WTF::TinyPtrSet::addOutOfLine):
(WTF::TinyPtrSet::mergeOtherOutOfLine):
Tools:
Make it possible to measure compile times.
- Scripts/run-jsc-benchmarks:
- 5:05 PM Changeset in webkit [231467] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG AI doesn't need to merge valuesAtTail - it can just assign them
https://bugs.webkit.org/show_bug.cgi?id=185355
Reviewed by Mark Lam.
This is a further attempt to improve compile times. Assigning AbstractValue ought to always
be faster than merging. There's no need to merge valuesAtTail. In most cases, assigning and
merging will get the same answer because the value computed this time will be either the same
as or more general than the value computed last time. If the value does change for some
reason, then valuesAtHead are already merged, which ensures monotonicity. Also, if the value
changes, then we have no reason to believe that this new value is less right than the last
one we computed. Finally, the one client of valuesAtTail (AtTailAbstractState) doesn't care
if it's getting the merged valuesAtTail or just some correct answer for valuesAtTail.
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
- 4:59 PM Changeset in webkit [231466] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-main-frame.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=185404
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 4:57 PM Changeset in webkit [231465] by
-
- 2 edits in trunk/Source/WebKit
WebResourceLoadStatisticsStore::requestStorageAccess should call its completion handler on the main thread
https://bugs.webkit.org/show_bug.cgi?id=185403
Reviewed by Brent Fulgham.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
- 4:37 PM Changeset in webkit [231464] by
-
- 9 edits in trunk
CSP status-code incorrect for document blocked due to violation of its frame-ancestors directive
https://bugs.webkit.org/show_bug.cgi?id=185366
<rdar://problem/40035116>
Reviewed by Brent Fulgham.
Source/WebCore:
Fixes an issue where the status-code in the sent CSP report for an HTTP document blocked because
its frame-ancestors directive was violated would be the status code of the previously loaded
document in the frame. If the previously loaded document was about:blank then this would be 0.
Currently whenever we send a CSP report we ask the document's loader (Document::loader()) for the
HTTP status code for the last response. Document::loader() returns the loader for the last committed
document its frame. For a frame-ancestors violation, a CSP report is sent before the document
that had the frame-ancestors directive has been committed and after it has been associate with a frame.
As a result we are in are in a transient transition state for the frame and hence the last response
for new document's loader (Document::loader()) is actually the last response of the previously loaded
document in the frame. Instead we need to take care to tell CSP about the HTTP status code for the
response associated with the document the CSP came from.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
(WebCore::Document::initSecurityContext):
Pass the HTTP status code to CSP.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::responseHeaders const):
(WebCore::ContentSecurityPolicy::didReceiveHeaders):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::reportViolation const):
- page/csp/ContentSecurityPolicy.h:
Modify existing functions to take the HTTP status code, store it in a instance variable,
and reference this variable when reporting a violation.
- page/csp/ContentSecurityPolicyResponseHeaders.cpp:
(WebCore::ContentSecurityPolicyResponseHeaders::ContentSecurityPolicyResponseHeaders):
(WebCore::ContentSecurityPolicyResponseHeaders::isolatedCopy const):
- page/csp/ContentSecurityPolicyResponseHeaders.h:
(WebCore::ContentSecurityPolicyResponseHeaders::encode const):
(WebCore::ContentSecurityPolicyResponseHeaders::decode):
Store the HTTP status code along with the response headers.
LayoutTests:
Update existing test results now that we send the HTTP status code for the correct document.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-expected.txt:
- 4:32 PM Changeset in webkit [231463] by
-
- 3 edits in trunk/LayoutTests
Update TestExpectations for inspector/sampling-profiler/named-function-expression.html.
https://bugs.webkit.org/show_bug.cgi?id=170830
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 4:32 PM Changeset in webkit [231462] by
-
- 2 edits in trunk/LayoutTests
Mark platform/mac/media/audio-session-category-video-track-change.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184609
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:21 PM Changeset in webkit [231461] by
-
- 7 edits in trunk
CSP referrer incorrect for document blocked due to violation of its frame-ancestors directive
https://bugs.webkit.org/show_bug.cgi?id=185380
Reviewed by Brent Fulgham.
Source/WebCore:
Similar to <https://bugs.webkit.org/show_bug.cgi?id=185366>, fixes an issue where the referrer
in the sent CSP report for an HTTP document blocked because its frame-ancestors directive was
violated would be the referrer of the previously loaded document in the frame.
Currently whenever we send a CSP report we ask the document's loader (Document::loader()) for
the referrer for the last request. Document::loader() returns the loader for the last committed
document in its frame. For a frame-ancestors violation, a CSP report is sent before the document
that had the frame-ancestors directive has been committed and after it has been associate with a
frame. As a result we are in a transient transition state for the frame and hence the last request
for the new document's loader (Document::loader()) is actually the last request of the previously
loaded document in the frame. Instead we need to take care to tell CSP about the referrer for the
request associated with the document the CSP came from.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
LayoutTests:
Update existing test results now that we send the referrer for the correct document.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-https-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-https-expected.txt:
- 3:44 PM Changeset in webkit [231460] by
-
- 30 edits in trunk/Source/JavaScriptCore
Remove defunct email address
https://bugs.webkit.org/show_bug.cgi?id=185396
Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-05-07
Reviewed by Mark Lam.
The email address thetalecrafter@gmail.com is no longer valid, as the
associated google account has been closed. This updates the email
address so questions about these Intl contributions go to the right
place.
- builtins/DatePrototype.js:
- builtins/NumberPrototype.js:
- builtins/StringPrototype.js:
- runtime/IntlCollator.cpp:
- runtime/IntlCollator.h:
- runtime/IntlCollatorConstructor.cpp:
- runtime/IntlCollatorConstructor.h:
- runtime/IntlCollatorPrototype.cpp:
- runtime/IntlCollatorPrototype.h:
- runtime/IntlDateTimeFormat.cpp:
- runtime/IntlDateTimeFormat.h:
- runtime/IntlDateTimeFormatConstructor.cpp:
- runtime/IntlDateTimeFormatConstructor.h:
- runtime/IntlDateTimeFormatPrototype.cpp:
- runtime/IntlDateTimeFormatPrototype.h:
- runtime/IntlNumberFormat.cpp:
- runtime/IntlNumberFormat.h:
- runtime/IntlNumberFormatConstructor.cpp:
- runtime/IntlNumberFormatConstructor.h:
- runtime/IntlNumberFormatPrototype.cpp:
- runtime/IntlNumberFormatPrototype.h:
- runtime/IntlObject.cpp:
- runtime/IntlObject.h:
- runtime/IntlPluralRules.cpp:
- runtime/IntlPluralRules.h:
- runtime/IntlPluralRulesConstructor.cpp:
- runtime/IntlPluralRulesConstructor.h:
- runtime/IntlPluralRulesPrototype.cpp:
- runtime/IntlPluralRulesPrototype.h:
- 2:58 PM Changeset in webkit [231459] by
-
- 11 edits in trunk/Source/ThirdParty/libwebrtc
Activate ARC for libwebrtc Objective C files
https://bugs.webkit.org/show_bug.cgi?id=185324
Reviewed by David Kilzer.
Revert changes made to libwebrtc to accomodate from not using ARC.
Use ARC for all libwebrtc objective C files.
Remove no longer needed export symbols and stop compiling the related files.
- Configurations/libwebrtc.iOS.exp:
- Configurations/libwebrtc.iOSsim.exp:
- Configurations/libwebrtc.mac.exp:
- Configurations/libwebrtc.xcconfig:
- Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:
- Source/webrtc/sdk/objc/Framework/Classes/Video/RTCCVPixelBuffer.mm:
(-[RTCCVPixelBuffer dealloc]):
- Source/webrtc/sdk/objc/Framework/Classes/Video/objc_frame_buffer.mm:
(webrtc::ObjCFrameBuffer::~ObjCFrameBuffer):
- Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoDecoderH264.mm:
(-[RTCVideoDecoderH264 dealloc]):
(-[RTCVideoDecoderH264 setCallback:]):
(-[RTCVideoDecoderH264 releaseDecoder]):
- Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:
(-[RTCVideoEncoderH264 dealloc]):
(-[RTCVideoEncoderH264 setCallback:]):
(-[RTCVideoEncoderH264 releaseEncoder]):
- libwebrtc.xcodeproj/project.pbxproj:
- 2:57 PM Changeset in webkit [231458] by
-
- 4 edits in trunk/Source/WebKit
[iOS] Release page load process assertion if the screen is locked
https://bugs.webkit.org/show_bug.cgi?id=185333
Reviewed by Geoffrey Garen.
We normally take a background process assertion during page loads to allow them to complete
even if the tab / app is backgrounded. We should however avoid doing so when the backgrounding
is caused by the screen locking. Keeping the process assertion in this case would prevent the
whole device from sleeping longer than it should, thus negatively impacting power.
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationState):
(WebKit::NavigationState::releaseNetworkActivityToken):
(WebKit::NavigationState::didChangeIsLoading):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::applicationDidEnterBackground):
- 2:56 PM Changeset in webkit [231457] by
-
- 25 edits in trunk/Source
Add experimental feature to prompt for Storage Access API use
https://bugs.webkit.org/show_bug.cgi?id=185335
<rdar://problem/39994649>
Patch by Brent Fulgham <Brent Fulgham> on 2018-05-07
Reviewed by Alex Christensen and Youenn Fablet.
Create a new experimental feature that gates the ability of WebKit clients to prompt the user when
Storage Access API is invoked.
Currently this feature doesn't have any user-visible impact.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setStorageAccessPromptsEnabled):
(WebCore::RuntimeEnabledFeatures::storageAccessPromptsEnabled const):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setStorageAccessPromptsEnabled):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Source/WebKit:
- Shared/API/APIObject.h:
- Shared/API/c/WKBase.h:
- Shared/WebPreferences.yaml:
- UIProcess/API/APIUIClient.h:
(API::UIClient::requestStorageAccessConfirm):
- UIProcess/API/C/WKPage.cpp:
(WebKit::RequestStorageAccessConfirmResultListener::create):
(WebKit::RequestStorageAccessConfirmResultListener::~RequestStorageAccessConfirmResultListener):
(WebKit::RequestStorageAccessConfirmResultListener::call):
(WebKit::RequestStorageAccessConfirmResultListener::RequestStorageAccessConfirmResultListener):
(WKPageRequestStorageAccessConfirmResultListenerGetTypeID):
(WKPageRequestStorageAccessConfirmResultListenerCall):
(WKPageSetPageUIClient):
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _storageAccessPromptsEnabled]):
(-[WKPreferences _setStorageAccessPromptsEnabled:]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::requestStorageAccessConfirm):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestStorageAccessConfirm):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::update):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::requestStorageAccess):
- 2:42 PM Changeset in webkit [231456] by
-
- 25 edits2 adds in trunk
Stop using an iframe's id as fallback if its name attribute is not set
https://bugs.webkit.org/show_bug.cgi?id=11388
Reviewed by Geoff Garen.
Source/WebCore:
WebKit had logic to use an iframe's id as fallback name when its name
content attribute is not set. This behavior was not standard and did not
match other browsers:
Gecko / Trident never behaved this way. Blink was aligned with us until
they started to match the specification in:
This WebKit quirk was causing some Web-compatibility issues because it
would affect the behavior of Window's name property getter when trying
to look up an iframe by id. Because of Window's named property getter
behavior [1], we would return the frame's contentWindow instead of the
iframe element itself.
[1] https://html.spec.whatwg.org/multipage/window-object.html#named-access-on-the-window-object
Test: fast/dom/Window/named-getter-frame-id.html
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::openURL):
(WebCore::HTMLFrameElementBase::parseAttribute):
(WebCore::HTMLFrameElementBase::didFinishInsertingNode):
- html/HTMLFrameElementBase.h:
LayoutTests:
- fast/dom/Window/named-getter-frame-id-expected.txt: Added.
- fast/dom/Window/named-getter-frame-id.html: Added.
Add layout test coverage.
- fast/dom/Geolocation/srcdoc-getCurrentPosition-expected.txt:
- fast/dom/Geolocation/srcdoc-watchPosition-expected.txt:
- fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe-crash.html:
- fast/dom/Window/window-special-properties-expected.txt:
- fast/frames/iframe-no-name-expected.txt:
- fast/frames/iframe-no-name.html:
- fast/layers/prevent-hit-test-during-layout.html:
- fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
- http/tests/security/clipboard/copy-paste-html-cross-origin-iframe-across-origin.html:
- http/tests/security/contentSecurityPolicy/iframe-blank-url-programmatically-add-external-script-expected.txt:
- http/tests/security/cross-origin-reified-window-property-access.html:
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame-expected.txt:
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-but-try-access-from-wrong-frame-expected.txt:
- http/tests/webrtc/filtering-ice-candidate-same-origin-frame.html:
- http/wpt/beacon/keepalive-after-navigation-expected.txt:
- http/wpt/cache-storage/cache-remove-twice.html:
Update some layout tests that relied on our old (non-standard) behavior.
- 2:06 PM Changeset in webkit [231455] by
-
- 1 edit1 add in trunk/Tools
Test262-Runner: Add base module to the local deps - unicore/Exact.pl
https://bugs.webkit.org/show_bug.cgi?id=185390
Patch by Leo Balter <Leo Balter> on 2018-05-07
Reviewed by Michael Saboff.
- Scripts/test262/local/lib/perl5/unicore/Exact.pl: Added.
- 2:00 PM Changeset in webkit [231454] by
-
- 2 edits in trunk/Source/WebKit
Use a dark gray for system preview bbackground
https://bugs.webkit.org/show_bug.cgi?id=185391
<rdar://problem/40035120>
Reviewed by Eric Carlson.
Throw some darker shade at this view.
- UIProcess/ios/WKSystemPreviewView.mm:
(-[WKSystemPreviewView web_initWithFrame:webView:]):
- 1:48 PM Changeset in webkit [231453] by
-
- 2 edits in trunk/LayoutTests
Layout Test webrtc/addICECandidate-closed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=185384
Reviewed by Eric Carlson.
Given that we are calling addIceCandidate and close the peer connection,
addIceCandidate might throw an error sometimes.
Catch the exception to make the test output stable.
- webrtc/addICECandidate-closed.html:
- 1:08 PM Changeset in webkit [231452] by
-
- 4 edits in trunk/Tools
Check for com.apple.datamigrator before declaring simulators booted
https://bugs.webkit.org/show_bug.cgi?id=185315
<rdar://problem/39986261>
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(waitUntilProcessNotRunning): Wait until a process is not found.
(relaunchIOSSimulator): Wait until com.apple.datamigrator stops running to declare
a simulator booted.
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive2.init): Define _running_pids.
- Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager.initialize_devices): Call wait_until_data_migration_is_done before
declaring that devices have been booted, increase the timeout since data migration will frequently
take longer than 60 seconds, especially with multiple simulators booting.
(SimulatedDeviceManager.swap): Ditto.
(SimulatedDeviceManager):
(SimulatedDeviceManager.wait_until_data_migration_is_done): Wait until there are no com.apple.datamigrator
processes running.
- 12:42 PM Changeset in webkit [231451] by
-
- 2 edits in trunk/Source/WebKit
[Win] Add missing methods to WebChromeClient
https://bugs.webkit.org/show_bug.cgi?id=185325
Reviewed by Brent Fulgham.
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 11:55 AM Changeset in webkit [231450] by
-
- 569 edits2 deletes in trunk
ASSERT(!childItemWithTarget(child->target())) is hit in HistoryItem::addChildItem()
https://bugs.webkit.org/show_bug.cgi?id=185322
Reviewed by Geoff Garen.
LayoutTests/imported/w3c:
Rebaseline layout tests due to frame name changes.
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/001-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/003-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_data_url-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/navigation_unload_same_origin-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/001-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/002-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/003-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/004-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/005-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/003-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/004-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/007-expected.txt:
- web-platform-tests/html/browsers/browsing-the-web/unloading-documents/unload/009-expected.txt:
Source/WebCore:
We generate unique names for Frame to be used in HistoryItem. Those names not only
need to be unique, they also need to be repeatable to avoid layout tests flakiness
and for things like restoring form state from a HistoryItem.
The previously generated frame names were relying on the Frame's index among a
parent Frame's children. The issue was that we could end up with duplicate names
because one could insert a Frame *before* an existing one. This is because the code
would not take care of updating existing Frames' unique name on frame tree mutation.
Updating frame tree names on mutation would be inefficient and is also not necessary.
The approach chosen in this patch is to stop using the Frame's index and instead rely
on an increasing counter stored on the top-frame's FrameTree. To make the names
repeatable, we reset the counter on page navigation.
- page/Frame.cpp:
(WebCore::Frame::setDocument):
- page/FrameTree.cpp:
(WebCore::FrameTree::uniqueChildName const):
(WebCore::FrameTree::generateUniqueName const):
- page/FrameTree.h:
(WebCore::FrameTree::resetFrameIdentifiers):
LayoutTests:
Rebaseline layout tests due to frame name changes.
- applicationmanifest/display-mode-subframe-expected.txt:
- contentfiltering/allow-after-add-data-expected.txt:
- contentfiltering/allow-after-finished-adding-data-expected.txt:
- contentfiltering/allow-after-response-expected.txt:
- contentfiltering/allow-after-will-send-request-expected.txt:
- contentfiltering/allow-never-expected.txt:
- contentfiltering/block-after-add-data-expected.txt:
- contentfiltering/block-after-add-data-then-allow-unblock-expected.txt:
- contentfiltering/block-after-add-data-then-deny-unblock-expected.txt:
- contentfiltering/block-after-finished-adding-data-expected.txt:
- contentfiltering/block-after-finished-adding-data-then-allow-unblock-expected.txt:
- contentfiltering/block-after-finished-adding-data-then-deny-unblock-expected.txt:
- contentfiltering/block-after-response-expected.txt:
- contentfiltering/block-after-response-then-allow-unblock-expected.txt:
- contentfiltering/block-after-response-then-deny-unblock-expected.txt:
- contentfiltering/block-after-will-send-request-expected.txt:
- contentfiltering/block-after-will-send-request-then-allow-unblock-expected.txt:
- contentfiltering/block-after-will-send-request-then-deny-unblock-expected.txt:
- contentfiltering/block-never-expected.txt:
- fast/dom/Geolocation/callback-to-deleted-context-expected.txt:
- fast/dom/Geolocation/disconnected-frame-expected.txt:
- fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
- fast/dom/Window/messageevent-source-postmessage-expected.txt:
- fast/dom/Window/messageevent-source-postmessage-reified-expected.txt:
- fast/dom/javascript-url-crash-function-expected.txt:
- fast/encoding/meta-overrules-auto-expected.txt:
- fast/events/before-unload-forbidden-navigation-expected.txt:
- fast/events/before-unload-in-subframe-expected.txt:
- fast/events/before-unload-with-subframes-expected.txt:
- fast/events/focusingUnloadedFrame-expected.txt:
- fast/events/onloadFrameCrash-expected.txt:
- fast/events/onunload-not-on-body-expected.txt:
- fast/events/pageshow-pagehide-expected.txt:
- fast/events/stop-load-in-unload-handler-using-document-write-expected.txt:
- fast/events/stop-load-in-unload-handler-using-window-stop-expected.txt:
- fast/forms/form-and-frame-interaction-retains-values-expected.txt:
- fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery-expected.txt:
- fast/frames/frame-element-name-expected.txt:
- fast/frames/frame-src-attribute-expected.txt:
- fast/frames/frame-unload-crash-expected.txt:
- fast/frames/iframe-reparenting-unique-name-expected.txt:
- fast/frames/iframe-set-inner-html-expected.txt:
- fast/frames/layout-after-destruction-expected.txt:
- fast/frames/long-names-in-nested-subframes-expected.txt:
- fast/frames/page-unload-document-open-expected.txt:
- fast/frames/reparent-in-unload-contentdocument-expected.txt:
- fast/frames/sandboxed-iframe-noscript-expected.txt:
- fast/frames/sandboxed-iframe-storage-expected.txt:
- fast/frames/srcdoc/setting-src-does-nothing-expected.txt:
- fast/frames/srcdoc/srcdoc-can-navigate-expected.txt:
- fast/frames/srcdoc/srcdoc-loads-content-expected.txt:
- fast/history/back-from-page-with-focused-iframe-expected.txt:
- fast/history/history-back-initial-vs-final-url-expected.txt:
- fast/history/redirect-via-iframe-expected.txt:
- fast/loader/child-frame-add-after-back-forward-expected.txt:
- fast/loader/dynamic-iframe-extra-back-forward-item-expected.txt:
- fast/loader/fragment-navigation-base-blank-expected.txt:
- fast/loader/frame-location-change-not-added-to-history-expected.txt:
- fast/loader/frame-src-change-added-to-history-expected.txt:
- fast/loader/frame-src-change-not-added-to-history-expected.txt:
- fast/loader/frames-with-unload-handlers-in-page-cache-expected.txt:
- fast/loader/grandparent-completion-starts-redirect-expected.txt:
- fast/loader/iframe-meta-refresh-base-blank-expected.txt:
- fast/loader/iframe-set-location-base-blank-expected.txt:
- fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-async-delegate-expected.txt:
- fast/loader/inner-iframe-loads-data-url-into-parent-on-unload-crash-expected.txt:
- fast/loader/page-dismissal-modal-dialogs-expected.txt:
- fast/loader/ping-error-expected.txt:
- fast/loader/plain-text-document-expected.txt:
- fast/loader/refresh-iframe-base-blank-expected.txt:
- fast/loader/stateobjects/pushstate-frequency-iframe-expected.txt:
- fast/loader/stateobjects/pushstate-in-iframe-expected.txt:
- fast/loader/stateobjects/replacestate-frequency-iframe-expected.txt:
- fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
- fast/loader/stop-provisional-loads-expected.txt:
- fast/loader/subframe-removes-itself-expected.txt:
- fast/loader/subframe-self-close-expected.txt:
- fast/loader/unload-hyperlink-targeted-expected.txt:
- fast/parser/double-write-from-closed-iframe-expected.txt:
- fast/parser/iframe-sets-parent-to-javascript-url-expected.txt:
- fast/parser/javascript-url-compat-mode-expected.txt:
- fast/parser/move-during-parsing-expected.txt:
- fast/parser/noscript-with-javascript-disabled-expected.txt:
- fast/parser/pre-html5-parser-quirks-expected.txt:
- fast/preloader/iframe-srcdoc-expected.txt:
- fast/tokenizer/text-plain-expected.txt:
- fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
- fast/xsl/xslt-text-expected.txt:
- http/tests/appcache/x-frame-options-prevents-framing-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin-expected.txt:
- http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url-expected.txt:
- http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page-expected.txt:
- http/tests/cookies/same-site/fetch-in-cross-origin-iframe-expected.txt:
- http/tests/cookies/same-site/fetch-in-cross-origin-service-worker-expected.txt:
- http/tests/cookies/same-site/fetch-in-same-origin-service-worker-expected.txt:
- http/tests/from-origin/document-from-origin-same-accepted-expected.txt:
- http/tests/from-origin/document-from-origin-same-blocked-expected.txt:
- http/tests/from-origin/document-from-origin-same-site-accepted-expected.txt:
- http/tests/from-origin/document-from-origin-same-site-blocked-expected.txt:
- http/tests/from-origin/document-nested-from-origin-same-accepted-expected.txt:
- http/tests/from-origin/document-nested-from-origin-same-blocked-expected.txt:
- http/tests/from-origin/fetch-data-iframe-from-origin-same-blocked-expected.txt:
- http/tests/from-origin/fetch-iframe-from-origin-same-accepted-expected.txt:
- http/tests/from-origin/fetch-iframe-from-origin-same-blocked-expected.txt:
- http/tests/from-origin/redirect-document-from-origin-same-blocked-expected.txt:
- http/tests/from-origin/sandboxed-sub-frame-from-origin-same-blocked-expected.txt:
- http/tests/from-origin/sandboxed-sub-frame-nested-cross-origin-from-origin-same-blocked-expected.txt:
- http/tests/from-origin/sandboxed-sub-frame-nested-same-origin-from-origin-same-blocked-expected.txt:
- http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:
- http/tests/loading/basic-auth-remove-credentials-expected.txt:
- http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
- http/tests/loading/basic-credentials-sent-automatically-expected.txt:
- http/tests/loading/pdf-commit-load-callbacks-expected.txt:
- http/tests/loading/redirect-with-no-location-crash-expected.txt:
- http/tests/loading/server-redirect-for-provisional-load-caching-expected.txt:
- http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt:
- http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt:
- http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt:
- http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt:
- http/tests/misc/last-modified-parsing-expected.txt:
- http/tests/misc/policy-delegate-called-twice-expected.txt:
- http/tests/misc/redirect-to-external-url-expected.txt:
- http/tests/misc/webtiming-origins-expected.txt: Removed.
- http/tests/navigation/back-to-slow-frame-expected.txt:
- http/tests/navigation/forward-and-cancel-expected.txt:
- http/tests/navigation/image-load-in-subframe-unload-handler-expected.txt:
- http/tests/navigation/lockedhistory-iframe-expected.txt:
- http/tests/navigation/post-frames-expected.txt:
- http/tests/navigation/reload-subframe-frame-expected.txt:
- http/tests/navigation/reload-subframe-iframe-expected.txt:
- http/tests/navigation/reload-subframe-object-expected.txt:
- http/tests/preload/download_resources_from_header_iframe-expected.txt:
- http/tests/preload/download_resources_from_invalid_headers-expected.txt:
- http/tests/quicklook/at-import-stylesheet-blocked-expected.txt:
- http/tests/quicklook/cross-origin-iframe-blocked-expected.txt:
- http/tests/quicklook/document-domain-is-empty-string-expected.txt:
- http/tests/quicklook/external-stylesheet-blocked-expected.txt:
- http/tests/quicklook/hide-referer-on-navigation-expected.txt:
- http/tests/quicklook/rtf-document-domain-is-empty-string-expected.txt:
- http/tests/quicklook/same-origin-xmlhttprequest-allowed-expected.txt:
- http/tests/quicklook/top-navigation-blocked-expected.txt:
- http/tests/resourceLoadStatistics/add-blocking-to-redirect-expected.txt:
- http/tests/resourceLoadStatistics/add-partitioning-to-redirect-expected.txt:
- http/tests/resourceLoadStatistics/non-prevalent-resources-can-access-cookies-in-a-third-party-context-expected.txt:
- http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-deletion-expected.txt:
- http/tests/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-partitioning-timeout-expected.txt:
- http/tests/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction-expected.txt:
- http/tests/resourceLoadStatistics/remove-blocking-in-redirect-expected.txt:
- http/tests/resourceLoadStatistics/remove-partitioning-in-redirect-expected.txt:
- http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-redirects-expected.txt:
- http/tests/resourceLoadStatistics/strip-referrer-to-origin-for-prevalent-subresource-requests-expected.txt:
- http/tests/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-allow-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
- http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
- http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
- http/tests/security/appcache-in-private-browsing-expected.txt:
- http/tests/security/appcache-switching-private-browsing-expected.txt:
- http/tests/security/canvas-cors-with-two-hosts-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-in-meta-element-ignored-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-in-report-only-ignored-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-allow-same-origin-sandboxed-cross-url-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-none-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-self-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-star-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-none-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-self-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-sandboxed-cross-url-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-none-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-self-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-star-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-none-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-self-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-star-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-none-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-protocolless-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-crossorigin-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-sameorigin-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-allow-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-block-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-in-enforced-policy-and-not-in-report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-in-one-enforced-policy-neither-in-another-enforced-policy-nor-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-invalidnonce-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-01-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-url-02-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-in-enforced-policy-and-not-in-report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-in-one-enforced-policy-neither-in-another-enforced-policy-nor-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-in-enforced-policy-and-not-in-report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-in-one-enforced-policy-neither-in-another-enforced-policy-nor-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-https-expected.txt:
- http/tests/security/contentSecurityPolicy/WebAssembly-blocked-in-subframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/data-url-iframe-in-main-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-main-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-enforced-and-report-policies-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-inherited-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-javascript-url-iframe-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-plugin-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-with-inherited-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-synchronous-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/secure-image-after-upgrade-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/block-all-mixed-content/secure-image-after-upgrade-redirect-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-01-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-02-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-03-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-04-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-05-expected.txt:
- http/tests/security/contentSecurityPolicy/directive-parsing-multiple-headers-expected.txt:
- http/tests/security/contentSecurityPolicy/eval-blocked-in-subframe-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-none-allowed-expected.txt:
- http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
- http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-self-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-02-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-04-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-05-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-06-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-07-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-08-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-09-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-deprecated-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-no-semicolon-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-none-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-02-expected.txt:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-nested-upgrades-expected.txt:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-css-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-http-to-https-script-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-https-to-http-script-in-iframe-expected.txt:
- http/tests/security/contentSecurityPolicy/xsl-redirect-allowed-expected.txt:
- http/tests/security/contentSecurityPolicy/xsl-redirect-allowed2-expected.txt:
- http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt:
- http/tests/security/cookies/third-party-cookie-blocking-redirect-expected.txt:
- http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt:
- http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
- http/tests/security/cross-frame-access-delete-expected.txt:
- http/tests/security/cross-frame-access-frameelement-expected.txt:
- http/tests/security/cross-frame-access-history-put-expected.txt: Removed.
- http/tests/security/cross-frame-access-location-put-expected.txt:
- http/tests/security/cross-frame-access-private-browsing-expected.txt:
- http/tests/security/cross-origin-appcache-allowed-expected.txt:
- http/tests/security/cross-origin-appcache-expected.txt:
- http/tests/security/cross-origin-css-primitive-expected.txt:
- http/tests/security/cross-origin-indexeddb-allowed-expected.txt:
- http/tests/security/cross-origin-indexeddb-expected.txt:
- http/tests/security/cross-origin-plugin-allowed-expected.txt:
- http/tests/security/cross-origin-plugin-expected.txt:
- http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed-expected.txt:
- http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt:
- http/tests/security/cross-origin-session-storage-allowed-expected.txt:
- http/tests/security/cross-origin-session-storage-third-party-blocked-expected.txt:
- http/tests/security/cross-origin-websql-allowed-expected.txt:
- http/tests/security/cross-origin-websql-expected.txt:
- http/tests/security/cross-origin-worker-indexeddb-allowed-expected.txt:
- http/tests/security/cross-origin-worker-indexeddb-expected.txt:
- http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
- http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
- http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change-expected.txt:
- http/tests/security/frameNavigation/xss-DENIED-plugin-navigation-expected.txt:
- http/tests/security/frameNavigation/xss-DENIED-targeted-link-navigation-expected.txt:
- http/tests/security/history-pushState-replaceState-from-sandboxed-iframe-expected.txt:
- http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt:
- http/tests/security/http-0.9/default-port-script-blocked-expected.txt:
- http/tests/security/http-0.9/iframe-blocked-expected.txt:
- http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-expected.txt:
- http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked-expected.txt:
- http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-sub-frame-2-level-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-to-javscript-url-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-from-javscript-url-expected.txt:
- http/tests/security/javascriptURL/xss-ALLOWED-to-javascript-url-sub-frame-2-level-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
- http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt:
- http/tests/security/mixedContent/blob-url-in-iframe-expected.txt:
- http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt:
- http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt:
- http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt:
- http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
- http/tests/security/mixedContent/insecure-form-in-iframe-expected.txt:
- http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt:
- http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
- http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt:
- http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
- http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
- http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
- http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt:
- http/tests/security/private-browsing-http-auth-expected.txt:
- http/tests/security/referrer-policy-always-expected.txt:
- http/tests/security/referrer-policy-default-expected.txt:
- http/tests/security/referrer-policy-https-always-expected.txt:
- http/tests/security/referrer-policy-https-default-expected.txt:
- http/tests/security/referrer-policy-https-never-expected.txt:
- http/tests/security/referrer-policy-https-no-referrer-expected.txt:
- http/tests/security/referrer-policy-https-no-referrer-when-downgrade-expected.txt:
- http/tests/security/referrer-policy-https-origin-expected.txt:
- http/tests/security/referrer-policy-https-unsafe-url-expected.txt:
- http/tests/security/referrer-policy-invalid-expected.txt:
- http/tests/security/referrer-policy-never-expected.txt:
- http/tests/security/referrer-policy-no-referrer-expected.txt:
- http/tests/security/referrer-policy-no-referrer-when-downgrade-expected.txt:
- http/tests/security/referrer-policy-origin-expected.txt:
- http/tests/security/referrer-policy-redirect-expected.txt:
- http/tests/security/referrer-policy-rel-noreferrer-expected.txt:
- http/tests/security/same-origin-appcache-blocked-expected.txt:
- http/tests/security/same-origin-document-domain-storage-allowed-expected.txt:
- http/tests/security/same-origin-storage-blocked-expected.txt:
- http/tests/security/same-origin-websql-blocked-expected.txt:
- http/tests/security/sandboxed-iframe-document-cookie-expected.txt:
- http/tests/security/sandboxed-iframe-geolocation-getCurrentPosition-expected.txt:
- http/tests/security/sandboxed-iframe-geolocation-watchPosition-expected.txt:
- http/tests/security/srcdoc-inherits-referrer-expected.txt:
- http/tests/security/srcdoc-inherits-referrer-for-forms-expected.txt:
- http/tests/security/storage-blocking-loosened-local-storage-expected.txt:
- http/tests/security/storage-blocking-loosened-plugin-expected.txt:
- http/tests/security/storage-blocking-loosened-private-browsing-plugin-expected.txt:
- http/tests/security/storage-blocking-loosened-websql-expected.txt:
- http/tests/security/storage-blocking-strengthened-local-storage-expected.txt:
- http/tests/security/storage-blocking-strengthened-plugin-expected.txt:
- http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt:
- http/tests/security/storage-blocking-strengthened-websql-expected.txt:
- http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode-expected.txt:
- http/tests/security/strip-referrer-to-origin-for-third-party-requests-in-private-mode-expected.txt:
- http/tests/security/window-properties-clear-domain-expected.txt:
- http/tests/security/window-properties-clear-port-expected.txt:
- http/tests/security/window-properties-pass-expected.txt:
- http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
- http/tests/security/xss-DENIED-defineProperty-expected.txt:
- http/tests/security/xssAuditor/faux-script1-expected.txt:
- http/tests/security/xssAuditor/faux-script2-expected.txt:
- http/tests/security/xssAuditor/faux-script3-expected.txt:
- http/tests/security/xssAuditor/malformed-HTML-expected.txt:
- http/tests/security/xssAuditor/non-block-javascript-url-frame-expected.txt:
- http/tests/security/xssAuditor/reflection-in-path-expected.txt:
- http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
- http/tests/security/xssAuditor/svg-animate-expected.txt:
- http/tests/ssl/media-stream/get-user-media-different-host-expected.txt:
- http/tests/ssl/media-stream/get-user-media-nested-expected.txt:
- http/tests/ssl/media-stream/get-user-media-secure-connection-expected.txt:
- http/tests/ssl/ping-with-unsafe-redirect-expected.txt:
- http/tests/storageAccess/deny-storage-access-under-opener-expected.txt:
- http/tests/storageAccess/grant-storage-access-under-opener-expected.txt:
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame-expected.txt:
- http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-but-try-access-from-wrong-frame-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-origin-null-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt:
- http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt:
- http/tests/xmlhttprequest/frame-load-cancelled-abort-expected.txt:
- http/tests/xmlhttprequest/frame-unload-abort-crash-expected.txt:
- http/tests/xmlhttprequest/origin-exact-matching-expected.txt:
- http/tests/xmlhttprequest/uri-resolution-opera-open-004-expected.txt:
- http/tests/xmlhttprequest/uri-resolution-opera-open-005-expected.txt:
- http/tests/xmlhttprequest/uri-resolution-opera-open-006-expected.txt:
- http/tests/xmlhttprequest/uri-resolution-opera-open-007-expected.txt:
- http/tests/xmlhttprequest/uri-resolution-opera-open-008-expected.txt:
- http/tests/xmlhttprequest/uri-resolution-opera-open-009-expected.txt:
- http/tests/xmlhttprequest/uri-resolution-opera-open-010-expected.txt:
- http/tests/xsl/xslt-transform-with-javascript-disabled-expected.txt:
- imported/blink/fast/plugins/empty-url-object-expected.txt:
- loader/stateobjects/pushstate-size-iframe-expected.txt:
- loader/stateobjects/replacestate-size-iframe-expected.txt:
- media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
- platform/ios-wk1/http/tests/quicklook/top-navigation-blocked-expected.txt:
- platform/ios-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/001-expected.txt:
- platform/ios/http/tests/quicklook/at-import-stylesheet-blocked-expected.txt:
- platform/ios/http/tests/quicklook/cross-origin-iframe-blocked-expected.txt:
- platform/ios/http/tests/quicklook/document-domain-is-empty-string-expected.txt:
- platform/ios/http/tests/quicklook/external-stylesheet-blocked-expected.txt:
- platform/ios/http/tests/quicklook/hide-referer-on-navigation-expected.txt:
- platform/ios/http/tests/quicklook/top-navigation-blocked-expected.txt:
- platform/ios/quicklook/excel-expected.txt:
- platform/ios/quicklook/excel-legacy-expected.txt:
- platform/ios/quicklook/excel-macro-enabled-expected.txt:
- platform/ios/quicklook/powerpoint-expected.txt:
- platform/ios/quicklook/powerpoint-legacy-expected.txt:
- platform/ios/quicklook/word-expected.txt:
- platform/ios/quicklook/word-legacy-expected.txt:
- platform/ios/webarchive/loading/cache-expired-subresource-expected.txt:
- platform/mac-wk2/http/tests/security/cross-origin-plugin-expected.txt:
- platform/mac-wk2/http/tests/security/cross-origin-plugin-private-browsing-toggled-expected.txt:
- platform/mac-wk2/http/tests/security/storage-blocking-strengthened-plugin-expected.txt:
- platform/mac-wk2/http/tests/security/storage-blocking-strengthened-private-browsing-plugin-expected.txt:
- platform/mac-wk2/plugins/resize-from-plugin-expected.txt:
- platform/mac/fast/loader/webarchive-encoding-respected-expected.txt:
- platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.txt:
- platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
- platform/mac/webarchive/test-duplicate-resources-expected.txt:
- platform/win/plugins/resize-from-plugin-expected.txt:
- platform/win/webarchive/loading/cache-expired-subresource-expected.txt:
- platform/wk2/fast/loader/fragment-navigation-base-blank-expected.txt:
- platform/wk2/fast/loader/iframe-meta-refresh-base-blank-expected.txt:
- platform/wk2/fast/loader/iframe-set-location-base-blank-expected.txt:
- platform/wk2/fast/loader/refresh-iframe-base-blank-expected.txt:
- platform/wk2/fast/loader/subframe-removes-itself-expected.txt:
- platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt:
- platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt:
- platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt:
- platform/wk2/http/tests/loading/redirect-with-no-location-crash-expected.txt:
- platform/wk2/http/tests/loading/server-redirect-for-provisional-load-caching-expected.txt:
- platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt:
- platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt:
- platform/wk2/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt:
- platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-in-body-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-allow-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt:
- platform/wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/data-url-iframe-in-main-frame-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-css-in-iframe-report-only-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-iframe-in-main-frame-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-enforced-and-report-policies-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-iframe-with-inherited-policy-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-javascript-url-iframe-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-image-in-xslt-document-in-iframe-with-inherited-policy-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-plugin-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-script-in-iframe-with-inherited-policy-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-synchronous-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/secure-image-after-upgrade-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/block-all-mixed-content/secure-image-after-upgrade-redirect-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-nested-upgrades-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-insecure-css-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-http-to-https-script-in-iframe-expected.txt:
- platform/wk2/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/upgrade-redirect-https-to-http-script-in-iframe-expected.txt:
- platform/wk2/http/tests/security/http-0.9/iframe-blocked-expected.txt:
- platform/wk2/http/tests/security/mixedContent/about-blank-iframe-in-main-frame-expected.txt:
- platform/wk2/http/tests/security/mixedContent/data-url-iframe-in-main-frame-expected.txt:
- platform/wk2/http/tests/security/mixedContent/data-url-script-in-iframe-expected.txt:
- platform/wk2/http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt:
- platform/wk2/http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
- platform/wk2/http/tests/security/mixedContent/insecure-form-in-iframe-expected.txt:
- platform/wk2/http/tests/security/mixedContent/insecure-iframe-in-iframe-expected.txt:
- platform/wk2/http/tests/security/mixedContent/insecure-iframe-in-main-frame-expected.txt:
- platform/wk2/http/tests/security/mixedContent/insecure-image-in-iframe-expected.txt:
- platform/wk2/http/tests/security/mixedContent/redirect-http-to-https-iframe-in-main-frame-expected.txt:
- platform/wk2/http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
- platform/wk2/http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
- platform/wk2/http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe-expected.txt:
- platform/wk2/http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
- platform/wk2/webarchive/loading/javascript-url-iframe-crash-expected.txt:
- platform/wk2/webarchive/loading/mainresource-null-mimetype-crash-expected.txt:
- platform/wk2/webarchive/loading/missing-data-expected.txt:
- platform/wk2/webarchive/loading/object-expected.txt:
- platform/wk2/webarchive/loading/test-loading-archive-expected.txt:
- platform/wk2/webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
- platform/wk2/webarchive/loading/video-in-webarchive-expected.txt:
- plugins/resize-from-plugin-expected.txt:
- quicklook/excel-expected.txt:
- quicklook/excel-legacy-expected.txt:
- quicklook/excel-macro-enabled-expected.txt:
- quicklook/keynote-09-expected.txt:
- quicklook/multi-sheet-numbers-09-expected.txt:
- quicklook/numbers-09-expected.txt:
- quicklook/pages-09-expected.txt:
- quicklook/powerpoint-expected.txt:
- quicklook/powerpoint-legacy-expected.txt:
- quicklook/word-expected.txt:
- quicklook/word-legacy-expected.txt:
- userscripts/user-script-all-frames-expected.txt:
- userscripts/user-script-top-frame-only-expected.txt:
- userscripts/user-style-all-frames-expected.txt:
- userscripts/user-style-top-frame-only-expected.txt:
- webarchive/loading/javascript-url-iframe-crash-expected.txt:
- webarchive/loading/mainresource-null-mimetype-crash-expected.txt:
- webarchive/loading/missing-data-expected.txt:
- webarchive/loading/object-expected.txt:
- webarchive/loading/test-loading-archive-expected.txt:
- webarchive/loading/test-loading-archive-subresource-null-mimetype-expected.txt:
- webarchive/loading/video-in-webarchive-expected.txt:
- 11:32 AM Changeset in webkit [231449] by
-
- 3 edits in trunk/Tools
REGRESSION (r229955): run-webkit-tests runs tests in skipped directories and subdirectories of directory given on command line
https://bugs.webkit.org/show_bug.cgi?id=185054
<rdar://problem/39773209>
Reviewed by Ryosuke Niwa.
Fallback to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not have Apple Additions.
Darwin-based ports have OS version-specific test expectations and are certified to support running tests using
the currently shipping OS by way of a hardcoded class variable CURRENT_VERSION. The run-webkit-tests script
depends on the OS version to find the applicable TestExpectations files to parse to compute the list of skipped
tests for the port.
- Scripts/webkitpy/port/mac.py:
(MacPort.init): Fall back to MacPort.CURRENT_VERSION if we are not using a known named macOS and do not
have Apple Additions.
- Scripts/webkitpy/port/mac_unittest.py:
(MacTest.test_factory_with_future_version): Added.
(MacTest.test_factory_with_future_version_and_apple_additions): Renamed from MacTest.test_factory_with_future_version()
and added code to use the mock Apple Additions so that running this code with- and without- the real Apple Additions
produces consistent results now that the Mac port's OS version falls back to MacPort.CURRENT_VERSION when Apple Additions
is absent.
- 11:27 AM Changeset in webkit [231448] by
-
- 2 edits in trunk/Source/WebCore
[EME][GStreamer] Fix wrong subsample parsing on r227067
https://bugs.webkit.org/show_bug.cgi?id=185382
Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-05-07
Reviewed by Philippe Normand.
The initialization of sampleIndex should be moved outside of the loop.
Without this patch we will have a bad log and the check of the subsample
count will be useless.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorDecrypt):
- 11:16 AM Changeset in webkit [231447] by
-
- 2 edits in trunk/Source/WebKit
Allow Web Touch events to timeout
https://bugs.webkit.org/show_bug.cgi?id=185282
Reviewed by Tim Horton.
This is backwards, fixing.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleTouchEventSynchronously):
- 11:07 AM Changeset in webkit [231446] by
-
- 2 edits in trunk/Source/WebKit
[Win] LoggingWin is missing includes
https://bugs.webkit.org/show_bug.cgi?id=185326
Reviewed by Per Arne Vollan.
- Platform/win/LoggingWin.cpp:
- 10:52 AM Changeset in webkit [231445] by
-
- 12 edits in trunk/Source
CSP should be passed the referrer
https://bugs.webkit.org/show_bug.cgi?id=185367
Reviewed by Per Arne Vollan.
Source/WebCore:
As a step towards formalizing a CSP delegate object and removing the dependencies
on ScriptExecutionContext and Frame, we should pass the document's referrer directly
instead of indirectly obtaining it from the ScriptExecutionContext or Frame used
to instantiate the ContentSecurityPolicy object.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Pass the document's referrer.
(WebCore::Document::initSecurityContext): Ditto.
(WebCore::Document::applyQuickLookSandbox): Ditto.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived): Ditto.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument): Ditto.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::copyStateFrom): We pass a null string for the referrer
to didReceiveHeader() as a placeholder since it requires the referrer be given to it. We
fix up the referrer (m_referrer) after copying all the policy headers.
(WebCore::ContentSecurityPolicy::didReceiveHeaders): Ditto.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Modified to take a referrer and WTFMove()s
it into an instance variable (m_referrer).
(WebCore::ContentSecurityPolicy::reportViolation const): Modified to use the stored referrer.
- page/csp/ContentSecurityPolicy.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyResponseHeaders): Pass a null string
for the referrer as a worker does not have a referrer.
Source/WebKit:
Pass the referrer through NetworkLoadChecker so that it can pass it to the ContentSecurityPolicy
object it instantiates.
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::contentSecurityPolicy const):
- NetworkProcess/NetworkLoadChecker.h:
(WebKit::NetworkLoadChecker::create):
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
- 10:47 AM Changeset in webkit [231444] by
-
- 1 edit6 adds in trunk/LayoutTests
Add tests to ensure Same-Site cookies are included when performing a top-level redirect
https://bugs.webkit.org/show_bug.cgi?id=185235
Reviewed by Alex Christensen.
- http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect-expected.txt: Added.
- http/tests/cookies/same-site/fetch-after-top-level-cross-origin-redirect.html: Added.
- http/tests/cookies/same-site/fetch-after-top-level-same-origin-redirect-expected.txt: Added.
- http/tests/cookies/same-site/fetch-after-top-level-same-origin-redirect.html: Added.
- http/tests/cookies/same-site/resources/fetch-after-top-level-cross-origin-redirect.php: Added.
- http/tests/cookies/same-site/resources/fetch-after-top-level-same-origin-redirect.php: Added.
- 10:41 AM Changeset in webkit [231443] by
-
- 2 edits in trunk/Source/WebCore
CSP should only notify Inspector to pause the debugger on the first policy to violate a directive
https://bugs.webkit.org/show_bug.cgi?id=185364
Reviewed by Brent Fulgham.
Notify Web Inspector that a script was blocked on the first enforced CSP policy that it
violates.
A page can have more than one enforced Content Security Policy. Currently for inline
scripts, inline event handlers, JavaScript URLs, and eval() that are blocked by CSP
we notify Web Inspector that it was blocked for each CSP policy that blocked it. When
Web Inspector is notified it pauses script execution. It does not seem very meaningful
to pause script execution on the same script for each CSP policy that blocked it.
Therefore, only tell Web Inspector that a script was blocked for the first enforced CSP
policy that blocked it.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs const):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers const):
(WebCore::ContentSecurityPolicy::allowInlineScript const):
(WebCore::ContentSecurityPolicy::allowEval const):
- 10:38 AM Changeset in webkit [231442] by
-
- 9 edits in trunk/Source
Substitute CrossOriginPreflightResultCache::clear() for CrossOriginPreflightResultCache::empty()
https://bugs.webkit.org/show_bug.cgi?id=185170
Reviewed by Per Arne Vollan.
Source/WebCore:
Rename CrossOriginPreflightResultCache::empty() to CrossOriginPreflightResultCache::clear() make
it consistent with the terminology we use in WebKit to signify a function that clears a collection.
A member function named "empty" is expected to return an instance of a class in its "empty state".
For example, StringImpl::empty() returns a StringImpl instance that represents the empty string.
However CrossOriginPreflightResultCache::empty() clears out the cache in-place. We should rename
this function to better describe its purpose.
- loader/CrossOriginPreflightResultCache.cpp:
(WebCore::CrossOriginPreflightResultCache::clear):
(WebCore::CrossOriginPreflightResultCache::empty): Deleted.
- loader/CrossOriginPreflightResultCache.h:
Source/WebKit:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::clearResourceCaches):
(WebKit::WebProcess::deleteWebsiteData):
Source/WebKitLegacy/mac:
- Misc/WebCache.mm:
(+[WebCache empty]):
Source/WebKitLegacy/win:
- WebCache.cpp:
(WebCache::empty):
- 10:36 AM Changeset in webkit [231441] by
-
- 5 edits2 adds in trunk
WebGL: Reset simulated values after validation fails
https://bugs.webkit.org/show_bug.cgi?id=185363
<rdar://problem/39733417>
Reviewed by Anders Carlsson.
Source/WebCore:
While fixing a previous bug, I forgot to reset some values
when validation fails. This caused a bug where a subsequent
invalid call might use those values and escape detection.
Test: fast/canvas/webgl/index-validation-with-subsequent-draws.html
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::simulateVertexAttrib0): Reset the
sizes when validation fails.
- html/canvas/WebGLRenderingContextBase.h:
LayoutTests:
- fast/canvas/webgl/index-validation-with-subsequent-draws-expected.txt: Added.
- fast/canvas/webgl/index-validation-with-subsequent-draws.html: Added.
- 10:20 AM Changeset in webkit [231440] by
-
- 7 edits in trunk
Support negative sw/sh values in createImageBitmap().
https://bugs.webkit.org/show_bug.cgi?id=184449
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:
Update expectations.
- web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt:
Source/WebCore:
Tests: LayoutTests/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage.html
LayoutTests/http/wpt/2dcontext/imagebitmap/createImageBitmap.html
- html/ImageBitmap.cpp:
(WebCore::ImageBitmap::createPromise): handle negative values per spec.
LayoutTests:
- http/wpt/2dcontext/imagebitmap/createImageBitmap-expected.txt: update test name
- http/wpt/2dcontext/imagebitmap/createImageBitmap.html: update expected result
- 10:10 AM Changeset in webkit [231439] by
-
- 14 edits in trunk
Web Inspector: opt out of process swap on navigation if a Web Inspector frontend is connected
https://bugs.webkit.org/show_bug.cgi?id=184861
<rdar://problem/39153768>
Reviewed by Timothy Hatcher.
Source/WebCore:
Notify the client of the current connection count whenever a frontend connects or disconnects.
Covered by new API test.
- inspector/InspectorClient.h:
(WebCore::InspectorClient::frontendCountChanged):
- inspector/InspectorController.cpp:
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::disconnectAllFrontends):
- inspector/InspectorController.h:
Source/WebKit:
We need to track how many frontends are attached to the web page (both local and remote).
InspectorController propagates this out to WebKit via InspectorClient. This is then
kept in UIProcess as a member of WebPageProxy. When making a decision whether to use a
new process for a navigation, return early with "no" if any frontends are open for the
page being navigated.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::didChangeInspectorFrontendCount):
(WebKit::WebPageProxy::inspectorFrontendCount const):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::frontendCountChanged):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::inspectorFrontendCountChanged):
- WebProcess/WebPage/WebPage.h:
Tools:
Add a new test that checks whether a new process is used for navigation when
an Inspector is shown. Also check that the behavior reverts to normal after
the Inspector has been closed.
- TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
- 8:54 AM Changeset in webkit [231438] by
-
- 6 edits in trunk/Source/WebCore
Text track cue logging should include cue text
https://bugs.webkit.org/show_bug.cgi?id=185353
<rdar://problem/40003565>
Reviewed by Youenn Fablet.
No new tests, tested manually.
- html/track/VTTCue.cpp:
(WebCore::VTTCue::toJSONString const): Use toJSON.
(WebCore::VTTCue::toJSON const): New.
- html/track/VTTCue.h:
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::toJSONString const): Log m_content.
- platform/graphics/iso/ISOVTTCue.cpp:
(WebCore::ISOWebVTTCue::toJSONString const): Log m_cueText.
- 6:36 AM Changeset in webkit [231437] by
-
- 2 edits in trunk
[WinCairo] Disable plugin api when building modern WebKit
https://bugs.webkit.org/show_bug.cgi?id=185312
Reviewed by Michael Catanzaro.
- Source/cmake/OptionsWin.cmake:
- 3:49 AM Changeset in webkit [231436] by
-
- 1 copy in releases/WebKitGTK/webkit-2.20.2
WebKitGTK+ 2.20.2
- 3:49 AM Changeset in webkit [231435] by
-
- 4 edits in releases/WebKitGTK/webkit-2.20
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.20.2 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.20.2.
- 3:40 AM WebKitGTK/2.20.x edited by
- (diff)
- 3:07 AM Changeset in webkit [231434] by
-
- 9 edits in releases/WebKitGTK/webkit-2.20
Merge r231350 - [GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
https://bugs.webkit.org/show_bug.cgi?id=174730
Reviewed by Michael Catanzaro.
Source/WebCore:
Export ResourceRequestBase::hasHTTPHeaderField().
- platform/network/ResourceRequestBase.h:
Source/WebKit:
The problem is that we don't send any User-Agent HTTP header for downloads started by WebProcessPool::download().
- UIProcess/API/glib/WebKitDownload.cpp:
(webkitDownloadUpdateRequest): Helper to update the cached request.
(webkitDownloadStarted): Updated the cached request if we have one.
(webkit_download_get_request): Use webkitDownloadUpdateRequest().
- UIProcess/API/glib/WebKitDownloadClient.cpp:
- UIProcess/API/glib/WebKitDownloadPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::download): Set the User-Agent HTTP header if there isn't any.
Tools:
Update unit tests to check that User-Agent header is included in HTTP download requests.
- TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(testDownloadRemoteFile):
(testWebViewDownloadURI):
(testPolicyResponseDownload):
(testPolicyResponseDownloadCancel):
(testDownloadMIMEType):
(testContextMenuDownloadActions):
- 2:49 AM Changeset in webkit [231433] by
-
- 3 edits in releases/WebKitGTK/webkit-2.20/Source/WebCore
Merge r231300 - WebCore::TextureMapperLayer object used after freed
https://bugs.webkit.org/show_bug.cgi?id=184729
Reviewed by Michael Catanzaro.
Replace the raw pointers with WeakPtr for effectTarget, maskLayer and replicaLayer
inside TextureMapperLayer.
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::~TextureMapperLayer):
(WebCore::TextureMapperLayer::setMaskLayer):
(WebCore::TextureMapperLayer::setReplicaLayer):
- platform/graphics/texmap/TextureMapperLayer.h:
- 2:49 AM Changeset in webkit [231432] by
-
- 17 edits1 add in releases/WebKitGTK/webkit-2.20
Merge r231195 - Add SetCallee as DFG-Operation
https://bugs.webkit.org/show_bug.cgi?id=184582
Patch by Dominik Infuehr <dinfuehr@igalia.com> on 2018-05-01
Reviewed by Filip Pizlo.
JSTests:
Added test that runs into infinite loop without updating the callee and
therefore emitting SetCallee in DFG for recursive tail calls.
- stress/closure-recursive-tail-call-infinite-loop.js: Added.
(Foo):
(second):
(first):
(return.closure):
(createClosure):
Source/JavaScriptCore:
For recursive tail calls not only the argument count can change but also the
callee. Add SetCallee to DFG that sets the callee slot in the current call frame.
Also update the callee when optimizing a recursive tail call.
Enable recursive tail call optimization also for closures.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
(JSC::DFG::ByteCodeParser::handleCallVariant):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGMayExit.cpp:
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSetCallee):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileSetCallee):
- 2:49 AM Changeset in webkit [231431] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.20
Merge r231187 - Improve the performance of FontCascadeDescription's effectiveFamilies
https://bugs.webkit.org/show_bug.cgi?id=184720
PerformanceTests:
Reviewed by Simon Fraser.
This performance test calls SystemFontDatabase::systemFontCascadeList() around 2,000,000 times (before
this patch is applied), which is roughly equivalent to the page we found the performance problem on.
The calling pattern is roughly equivalent in this test.
- Layout/system-ui.html: Added.
Source/WebCore:
<rdar://problem/38970927>
Reviewed by Simon Fraser.
The page that had the performance problem renders many different Chinese characters in system-ui
with only a small number of individual fonts. It turns out we were calling into the system-ui
machinery for each character in order to opportunistically start loading data URLs (see also:
https://bugs.webkit.org/show_bug.cgi?id=175845). These data URLS will never represent the system
font, so we don't need to invoke the system-ui machinery at all.
This patch makes a 92x performance improvement on the associated performance test. This test is
designed to test Chinese text rendered with system-ui.
Performance test: Layout/system-ui.html
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::opportunisticallyStartFontDataURLLoading):
- 2:49 AM Changeset in webkit [231430] by
-
- 4 edits in releases/WebKitGTK/webkit-2.20
Merge r231156 - [GTK] Webkit should spoof as Safari on a Mac when on Chase.com
https://bugs.webkit.org/show_bug.cgi?id=185103
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Send a fake user agent to chase.com to make it work.
- platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresMacintoshPlatform):
(WebCore::UserAgentQuirks::stringForQuirk): Also, remove this stale comment.
Tools:
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
- 2:29 AM Changeset in webkit [231429] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/WebKit
Merge r231132 - [GTK] WebProcess from WebKitGtk+ 2.19.92 SIGSEVs in WebCore::TextureMapperGL::~TextureMapperGL
https://bugs.webkit.org/show_bug.cgi?id=184040
Reviewed by Michael Catanzaro.
This can happen when using single shared process model or when the process limit is reached in multiple process
model. In this case, all pages in the same web process with accelerated compositing enabled share the same
compositing thread. Every page sets its GL context as current when rendering a frame, but not when invalidating
the threaded compositor when the page is closed. So, if a hidden tab is closed, the threaded compositor is
invalidated and the GL resources of the current context (the visible page) are destroyed. This is also causing
the blank pages issue when closing a tab related to another one, the current one stops rendering anything because
its GL context has been released. We should make the threaded compositor context current when invalidating it.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::invalidate):
- 2:29 AM Changeset in webkit [231428] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.20
Merge r230980 - fromCharCode is missing some exception checks
https://bugs.webkit.org/show_bug.cgi?id=184952
Reviewed by Saam Barati.
JSTests:
- stress/fromCharCode-exception-check.js: Added.
(get catch):
Source/JavaScriptCore:
I also removed the pointless slow path function and moved it into the
main function.
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCode):
(JSC::stringFromCharCodeSlowCase): Deleted.
- 2:29 AM Changeset in webkit [231427] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.20
Merge r230963 - REGRESSION(r221839): Fix requests with FormData containing empty files
https://bugs.webkit.org/show_bug.cgi?id=184490
<rdar://problem/39385169>
Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-04-24
Reviewed by Geoffrey Garen.
Source/WebCore:
We should not append the blob to the FormData when it is a file but has no path. It broke
the submission since the request was failing to read the file in FormDataStreamCFNet.h:156
Test: http/tests/local/formdata/send-form-data-with-empty-file.html
- platform/network/FormData.cpp:
(WebCore::FormData::appendMultiPartFileValue):
LayoutTests:
Verify that the final boundary is present in the request body when submitting FormData containing an empty file.
- http/tests/local/formdata/send-form-data-with-empty-file-expected.txt: Added.
- http/tests/local/formdata/send-form-data-with-empty-file.html: Added.
- 2:18 AM Changeset in webkit [231426] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/WebKit
Merge r230954 - REGRESSION(r230950): Faulty commit sequencing in CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=184917
Reviewed by Michael Catanzaro.
After r230950, current animation state for a given layer is also taken
into account when determining whether or not the layer requires a
backing store. For that to work properly, all the animation state has
to be updated before the backing store work. This patch changes the
order of helper method invocations in
CoordinatedGraphicsScene::setLayerState() to address that.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::setLayerState):
- 2:18 AM Changeset in webkit [231425] by
-
- 5 edits in releases/WebKitGTK/webkit-2.20/Source
Merge r230950 - [CoordGraphics] Avoid painting backing stores for zero-opacity layers
https://bugs.webkit.org/show_bug.cgi?id=184143
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Skip generating backing stores for layers that have zero opacity and do
not animate the opacity value. In the current CoordinatedGraphics system
this can end up saving loads of memory on Web content that deploys a
large number of such elements.
- platform/graphics/texmap/TextureMapperLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
Source/WebKit:
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::layerShouldHaveBackingStore):
Mirror CoordinatedGraphicsLayer's backing store requirements.
- 2:17 AM Changeset in webkit [231424] by
-
- 6 edits3 deletes in releases/WebKitGTK/webkit-2.20
Merge r230933 - REGRESSION (r220112): reCAPTCHA images render off screen on Twitch.tv app Log In or Sign Up
https://bugs.webkit.org/show_bug.cgi?id=182859
<rdar://problem/37595065>
Source/WebCore:
Reviewed by Zalan Bujtas.
Roll out this change from the trunk as the issue it fixed no longer occurs.
- css/MediaQueryEvaluator.cpp:
(WebCore::orientationEvaluate):
(WebCore::aspectRatioEvaluate):
(WebCore::heightEvaluate):
(WebCore::widthEvaluate):
- page/FrameView.cpp:
(WebCore::FrameView::layoutSizeForMediaQuery const): Deleted.
- page/FrameView.h:
- page/LayoutContext.cpp:
(WebCore::LayoutContext::handleLayoutWithFrameFlatteningIfNeeded):
LayoutTests:
Reviewed by Zalan Bujtas
- fast/frames/flattening/media-query-growing-content-expected.txt: Removed.
- fast/frames/flattening/media-query-growing-content.html: Removed.
- fast/frames/flattening/resources/media-query-min-height-with-flattening.html: Removed.
- 2:04 AM Changeset in webkit [231423] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/JavaScriptCore
Merge r230928 - Roll out r226655 because it broke OSR entry when the pre-header is inadequately profiled.
Rubber stamped by Saam Barati.
This is a >2x speed-up in SunSpider/bitops-bitwise-and. We don't really care about SunSpider
anymore, but r226655 didn't result in any benchmark wins and just regressed this test by a lot.
Seems sensible to just roll it out.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parse):
- 2:04 AM Changeset in webkit [231422] by
-
- 2 edits2 adds in releases/WebKitGTK/webkit-2.20/Tools
Merge r230911 - [GTK][WPE] TestSSL fails due to additional TLS errors returned
https://bugs.webkit.org/show_bug.cgi?id=184860
Reviewed by Carlos Garcia Campos.
Add script and config file for regenerating the test certificate.
Regenerate it. TestSSL no longer fails on my machine.
I do see a ton of network process crashes and JavaScript errors, none of
which prevent the test from passing, but this commit only claims to fix
the certificate validation portion of the test.
- TestWebKitAPI/Tests/WebKitGLib/resources/generate-test-cert.sh: Added.
- TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.conf: Added.
- TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem:
- 1:59 AM Changeset in webkit [231421] by
-
- 5 edits in releases/WebKitGTK/webkit-2.20
Merge r230886 - REGRESSION(r228088): [SOUP] Check TLS errors for WebSockets on GTlsConnection::accept-certificate
https://bugs.webkit.org/show_bug.cgi?id=184804
Source/WebCore:
Reviewed by Michael Catanzaro.
- platform/network/soup/SocketStreamHandleImpl.h: Add a public url getter.
- platform/network/soup/SocketStreamHandleImplSoup.cpp:
(WebCore::acceptCertificateCallback): Call SoupNetworkSession::checkTLSErrors() to decide whether to accept the
certificate or not.
(WebCore::connectProgressCallback): Receive the SocketStreamHandle and pass it to acceptCertificateCallback callback.
(WebCore::socketClientEventCallback): Ditto.
(WebCore::SocketStreamHandleImpl::create): Always connect to network events.
(WebCore::wssConnectionAcceptCertificateCallback): Deleted.
(WebCore::wssSocketClientEventCallback): Deleted.
Tools:
Patch by Michael Catanzaro <Michael Catanzaro> on 2018-04-20
Reviewed by Carlos Garcia Campos.
- TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
(WebSocketTest::WebSocketTest):
(WebSocketTest::~WebSocketTest):
(WebSocketTest::serverWebSocketCallback):
(WebSocketTest::webSocketTestResultCallback):
(WebSocketTest::connectToServerAndWaitForEvents):
(testWebSocketTLSErrors):
(beforeAll):
- 1:58 AM Changeset in webkit [231420] by
-
- 9 edits in releases/WebKitGTK/webkit-2.20/Source
Merge r230885 - [SOUP] Do TLS error checking on GTlsConnection::accept-certificate
https://bugs.webkit.org/show_bug.cgi?id=184480
Reviewed by Michael Catanzaro.
Source/WebCore:
- platform/network/soup/ResourceError.h: Change tlsError to recieve a failing URL instead of a SoupRequest,
since the request was only used to get the failing URL.
- platform/network/soup/ResourceErrorSoup.cpp:
(WebCore::ResourceError::tlsError): Use the given failing URL.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession): Use ssl-strict when creating the SoupSession to handle the
certificates ourselves by connecting to GTlsConnection::accept-certificate.
(WebCore::SoupNetworkSession::checkTLSErrors): Updated to receive a URL, certificate and errors instead of
receiving a SoupRequest and SoupMessage and extract the url, certirficate and errors from them. Also return the
optional error directly instead of using a completion handler since the function is always synchronous.
- platform/network/soup/SoupNetworkSession.h:
Source/WebKit:
Connect to GTlsConnection::accept-certificate signal instead of SoupMessage::notify::tls-errors to perform the
TLS errors check.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::createRequest): Do not connect to SoupMessage::notify::tls-errors.
(WebKit::NetworkDataTaskSoup::tlsConnectionAcceptCertificateCallback): Call tlsConnectionAcceptCertificate() is
the task is still ongoing.
(WebKit::NetworkDataTaskSoup::tlsConnectionAcceptCertificate): Check TLS errors here.
(WebKit::NetworkDataTaskSoup::networkEventCallback): Pass the stream to networkEvent.
(WebKit::NetworkDataTaskSoup::networkEvent): Connect to GTlsConnection::accept-certificate.
- NetworkProcess/soup/NetworkDataTaskSoup.h:
- 1:58 AM Changeset in webkit [231419] by
-
- 5 edits in releases/WebKitGTK/webkit-2.20
Merge r230837 - [GTK] Local cross references are broken in API documentation
https://bugs.webkit.org/show_bug.cgi?id=184771
Reviewed by Michael Catanzaro.
.:
Update the documentation html paths and install the JSC GLib API too.
- Source/PlatformGTK.cmake:
Tools:
The problem is that gtkdoc-fixxref expects the links to be in the form html/modulename (like the installed
ones), but we generate the documentation as modulename/html. So, links to WebKitDOM or JSC are generated as
../html/Foo. The rebase command considers html to be the module name in this case, creating broken links in all
the cases.
- gtk/gtkdoc.py:
(GTKDoc._copy_doc_files_to_output_dir): We don't have any html dir in the source tree so, we are not copying
anything here.
(GTKDoc._run_gtkdoc_mkhtml): Create the html dir here using html/modulename instead now.
(GTKDoc._run_gtkdoc_fixxref): Pass the new directory as module dir to gtkdoc-fixxref and fix several links for
which gtkdoc-fixxref always uses absolute paths.
- gtk/manifest.txt.in: Update the documentation html paths and include the JSC GLib API in the tarball too.
- 1:26 AM Changeset in webkit [231418] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.20
Merge r229505 - Turn off offset*/scroll* optimization for input elements with shadow content
https://bugs.webkit.org/show_bug.cgi?id=182383
<rdar://problem/37114190>
Reviewed by Antti Koivisto.
Source/WebCore:
We normally ensure clean tree before calling offsetHeight/Width, scrollHeight/Width.
In certain cases (see updateLayoutIfDimensionsOutOfDate() for details), it's okay to return
the previously computed values even when some part of the tree is dirty.
In case of shadow content, updateLayoutIfDimensionsOutOfDate() might return false (no need to layout)
for the root, while true (needs layout) for the shadow content.
This could confuse the caller (Element::scrollWidth/Height etc) and lead to incorrect result.
Test: fast/forms/scrollheight-with-mutation-crash.html
- dom/Document.cpp:
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
LayoutTests:
- fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
- fast/forms/scrollheight-with-mutation-crash.html: Added.
- 1:26 AM Changeset in webkit [231417] by
-
- 4 edits in releases/WebKitGTK/webkit-2.20
Merge r230749 - [GTK] Webkit should spoof as Safari on a Mac for Outlook.com
https://bugs.webkit.org/show_bug.cgi?id=184573
Reviewed by Carlos Alberto Lopez Perez.
Source/WebCore:
Add quirk for outlook.live.com.
- platform/UserAgentQuirks.cpp:
(WebCore::urlRequiresMacintoshPlatform):
Tools:
- TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
(TestWebKitAPI::TEST):
- 1:26 AM Changeset in webkit [231416] by
-
- 3 edits in releases/WebKitGTK/webkit-2.20/Source/WebKit
Merge r230718 - [WPE][GTK] GObject introspection annotation fixes: BackForwardList, NetworkProxySettings
https://bugs.webkit.org/show_bug.cgi?id=184658
Reviewed by Carlos Garcia Campos.
Thanks to Dylan Simon for recommending these annotation fixes.
- UIProcess/API/glib/WebKitBackForwardList.cpp:
- UIProcess/API/glib/WebKitNetworkProxySettings.cpp:
- 1:18 AM Changeset in webkit [231415] by
-
- 3 edits in releases/WebKitGTK/webkit-2.20/Source/WebCore
Merge r230629 - REGRESSION(r230627): [GTK][WPE] Possible deadlock when destroying the player in non AC mode
https://bugs.webkit.org/show_bug.cgi?id=184583
Reviewed by Carlos Garcia Campos.
In non AC mode, ensure that a deadlock can't happen when destroying MediaPlayerPrivateGStreamerBase.
Covered by existent tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 1:18 AM Changeset in webkit [231414] by
-
- 3 edits in releases/WebKitGTK/webkit-2.20/Source/WebCore
Merge r230627 - [GTK] [gstreamer] video won't unpause when built with -DUSE_GSTREAMER_GL=OFF
https://bugs.webkit.org/show_bug.cgi?id=183362
Reviewed by Carlos Garcia Campos.
Remove the drawCancelled flag and use a new one to indicate that the player is being destroyed.
That new flag is only enabled on destruction and it's not modified by cancelRepaint(), which
can be used to handle the pause event without avoiding future renderings. Also cancelRepaint()
has only effect when not in AC mode.
Covered by existent tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::cancelRepaint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 1:18 AM Changeset in webkit [231413] by
-
- 13 edits in releases/WebKitGTK/webkit-2.20/Source
Merge r230380 - Use alignas instead of compiler-specific attributes
https://bugs.webkit.org/show_bug.cgi?id=183508
Reviewed by Mark Lam.
Source/bmalloc:
Use alignas for g_gigacageBasePtr. We also add reinterpret_cast to fix
compile errors in ARMv7 and MIPS JSCOnly ports.
- bmalloc/Gigacage.cpp:
- bmalloc/Gigacage.h:
(Gigacage::basePtrs):
Source/JavaScriptCore:
Use C++11 alignas specifier. It is portable compared to compiler-specific aligned attributes.
- heap/RegisterState.h:
- jit/JIT.h:
(JSC::JIT::compile): Deleted.
(JSC::JIT::compileGetByVal): Deleted.
(JSC::JIT::compileGetByValWithCachedId): Deleted.
(JSC::JIT::compilePutByVal): Deleted.
(JSC::JIT::compileDirectPutByVal): Deleted.
(JSC::JIT::compilePutByValWithCachedId): Deleted.
(JSC::JIT::compileHasIndexedProperty): Deleted.
(JSC::JIT::appendCall): Deleted.
(JSC::JIT::appendCallWithSlowPathReturnType): Deleted.
(JSC::JIT::exceptionCheck): Deleted.
(JSC::JIT::exceptionCheckWithCallFrameRollback): Deleted.
(JSC::JIT::emitInt32Load): Deleted.
(JSC::JIT::emitInt32GetByVal): Deleted.
(JSC::JIT::emitInt32PutByVal): Deleted.
(JSC::JIT::emitDoublePutByVal): Deleted.
(JSC::JIT::emitContiguousPutByVal): Deleted.
(JSC::JIT::emitStoreCell): Deleted.
(JSC::JIT::getSlowCase): Deleted.
(JSC::JIT::linkSlowCase): Deleted.
(JSC::JIT::linkDummySlowCase): Deleted.
(JSC::JIT::linkAllSlowCases): Deleted.
(JSC::JIT::callOperation): Deleted.
(JSC::JIT::callOperationWithProfile): Deleted.
(JSC::JIT::callOperationWithResult): Deleted.
(JSC::JIT::callOperationNoExceptionCheck): Deleted.
(JSC::JIT::callOperationWithCallFrameRollbackOnException): Deleted.
(JSC::JIT::emitEnterOptimizationCheck): Deleted.
(JSC::JIT::sampleCodeBlock): Deleted.
(JSC::JIT::canBeOptimized): Deleted.
(JSC::JIT::canBeOptimizedOrInlined): Deleted.
(JSC::JIT::shouldEmitProfiling): Deleted.
- runtime/VM.h:
Source/WebCore:
Use alignas instead of aligned.
- platform/graphics/cpu/arm/filters/FELightingNEON.cpp:
- platform/graphics/cpu/arm/filters/FELightingNEON.h:
(WebCore::FELighting::platformApplyNeon):
Source/WTF:
Use alignas for g_gigacageBasePtr. We also add reinterpret_cast to fix
compile errors in ARMv7 and MIPS JSCOnly ports.
- wtf/Gigacage.cpp:
- wtf/Gigacage.h:
(Gigacage::basePtrs):
- 12:54 AM Changeset in webkit [231412] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/WebCore
Merge r230706 - [GTK] Build fix after r230529 (WaylandCompositorDisplay leaks its wl_display)
https://bugs.webkit.org/show_bug.cgi?id=184406
Rubber-stamped by Michael Catanzaro.
Fix build with clang 3.8
No new tests, it is a build fix.
- platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::create):
- 12:54 AM Changeset in webkit [231411] by
-
- 12 edits in releases/WebKitGTK/webkit-2.20/Source
Merge r230529 - [GTK] WaylandCompositorDisplay leaks its wl_display
https://bugs.webkit.org/show_bug.cgi?id=184406
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Well, this was harder than expected. We really just want to fix a small leak in the WebKit
layer, but that requires a change in how WaylandCompositorDisplay calls the
PlatformDisplayWayland constructor, to pass NativeDisplayOwned::Yes. That means
WaylandCompositorDisplay can no longer use PlatformDisplayWayland's protected default
constructor. Problem is that the normal PlatformDisplayWayland constructor calls
PlatformDisplayWayland::initialize, which calls PlatformDisplayWayland::registryGlobal,
which is a virtual function. The WaylandCompositorDisplay portion of the object is not
constructed yet at this point, so WaylandCompositorDisplay::registryGlobal will never be
called if we do that. I had to revert the previous version of this fix due to this problem.
It had broken accelerated compositing.
I'm reminded of Effective C++ item #9: Never call virtual functions during construction or
destruction ("because such calls will never go to a more derived class than that of the
currently executing constructor or destructor"). This code is fragile and likely to break
again in the future, so let's refactor it a bit. Instead of calling initialize in the
constructor, we'll call it from create functions. We'll have to add a couple create
functions, and make the constructor protected to ensure it's not possible to create a
PlatformDisplayWayland without initializing it. For good parallelism, do the same for the
other PlatformDisplay classes.
This commit additionally removes PlatformDisplayWayland's protected default constructor,
since it's not needed anymore.
The NativeDisplayOwned arguments to the PlatformDisplay constructors are now mandatory,
instead of using NativeDisplayOwned::No as the default value, since that was dangerously
close to being the cause of this leak, and the constructors are now accessed from private
create functions anyway. Some more caution when using default parameter values is warranted
in the future.
Lastly, since we have to change PlatformDisplay::createPlatformDisplay to use the new create
functions, take the opportunity to move things around a bit for clarity. There should be no
change in behavior. I was just disappointed that the PlatformDisplayWPE creation was at the
bottom of the function, after a comment indicating that normal display creation has failed,
which is not the case for WPE.
This all might have been a bit overkill, since the leak could probably have been fixed by
passing nullptr to the PlatformDisplayWayland constructor for the wl_display and not
removing WaylandCompositorDisplay's call to PlatformDisplayWayland::initialize. But the
correctness of that code would then rely on implementation details of initialize, so this
refactor seems better.
No new tests since there *should* be no behavior change. Then again, I'm touching
PlatformDisplay, and history shows we don't have the greatest track record of touching this
code without introducing problems.
- platform/graphics/PlatformDisplay.cpp:
(WebCore::PlatformDisplay::createPlatformDisplay):
- platform/graphics/PlatformDisplay.h:
- platform/graphics/wayland/PlatformDisplayWayland.cpp:
(WebCore::PlatformDisplayWayland::create):
(WebCore::PlatformDisplayWayland::create):
(WebCore::PlatformDisplayWayland::createHeadless):
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::initialize):
- platform/graphics/wayland/PlatformDisplayWayland.h:
- platform/graphics/win/PlatformDisplayWin.h:
- platform/graphics/wpe/PlatformDisplayWPE.cpp:
(WebCore::create):
- platform/graphics/wpe/PlatformDisplayWPE.h:
- platform/graphics/x11/PlatformDisplayX11.cpp:
(WebCore::PlatformDisplayX11::create):
(WebCore::PlatformDisplayX11::create):
(WebCore::PlatformDisplayX11::createHeadless):
- platform/graphics/x11/PlatformDisplayX11.h:
Source/WebKit:
Since we allocate our own wl_display here, need to chain up to the parent constructor
passing NativeDisplayOwned::Yes, or it won't ever be released. Move the initialize call to
the create function to ensure it's called after the constructor completes.
- WebProcess/gtk/WaylandCompositorDisplay.cpp:
(WebKit::WaylandCompositorDisplay::create): Fix a log message (drive-by).
(WebKit::WaylandCompositorDisplay::WaylandCompositorDisplay):
- 12:54 AM Changeset in webkit [231410] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.20
Merge r230513 - FrameSelection::appearanceUpdateTimerFired should be robust against layout passes underneath it
https://bugs.webkit.org/show_bug.cgi?id=183395
<rdar://problem/38055732>
Reviewed by Zalan Bujtas.
Source/WebCore:
In the case where a FrameSelection updates its appearance when m_appearanceUpdateTimer is fired, the
FrameSelection's Frame is unprotected, and can be removed by arbitrary script. This patch applies a simple
mitigation by wrapping the Frame in a Ref when firing the appearance update timer.
Test: editing/selection/iframe-update-selection-appearance.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::appearanceUpdateTimerFired):
LayoutTests:
Add a new layout test that passes if we didn't crash.
- editing/selection/iframe-update-selection-appearance-expected.txt: Added.
- editing/selection/iframe-update-selection-appearance.html: Added.
- 12:54 AM Changeset in webkit [231409] by
-
- 3 edits in releases/WebKitGTK/webkit-2.20/Source/JavaScriptCore
Merge r230485 - REGRESSION(r227341 and r227742): AI and clobberize should be precise and consistent about the effectfulness of CompareEq
https://bugs.webkit.org/show_bug.cgi?id=184455
Reviewed by Michael Saboff.
LICM is sort of an assertion that AI is as precise as clobberize about effects. If clobberize
says that something is not effectful, then LICM will try to hoist it. But LICM's AI hack
(AtTailAbstractState) cannot handle hoisting of things that have effects. So, if AI thinks that
the thing being hoisted does have effects, then we get a crash.
In r227341, we incorrectly told AI that CompareEq(Untyped:, _) is effectful. In fact, only
ComapreEq(Untyped:, Untyped:) is effectful, and clobberize knew this already. As a result, LICM
would blow up if we hoisted CompareEq(Untyped:, Other:), which clobberize knew wasn't
effectful.
Instead of fixing this by making AI precise, in r227742 we made matters worse by then breaking
clobberize to also think that CompareEq(Untyped:, _) is effectful.
This fixes the whole situation by teaching both clobberize and AI that the only effectful form
of CompareEq is ComapreEq(Untyped:, Untyped:).
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- 12:46 AM Changeset in webkit [231408] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/WebKit
Merge r230481 - [GTK][WPE] Race condition when destroying webprocesses
https://bugs.webkit.org/show_bug.cgi?id=184445
Reviewed by Carlos Garcia Campos.
Ensure that the WebProcess is properly closing its pages when it's exiting because
the UIProcess has invalidated the IPC connection.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
- 12:46 AM Changeset in webkit [231407] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/WebCore
Merge r230480 - Do not layout images when we only need the overflow information.
https://bugs.webkit.org/show_bug.cgi?id=175331
Reviewed by Simon Fraser.
This improves MotionMark's Simple Leaves by ~10%.
Covered by existing tests.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::layout):
- 12:46 AM Changeset in webkit [231406] by
-
- 4 edits in releases/WebKitGTK/webkit-2.20
Merge r231298 - REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127
https://bugs.webkit.org/show_bug.cgi?id=183348
Reviewed by Michael Catanzaro.
Source/WebKit:
When connection doesn't exit in case of sync message failure, always exit in case of failing to send
GetNetworkProcessConnection or GetStorageProcessConnection messages. This can happen when the WebView is created
and destroyed quickly.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::ensureWebToStorageProcessConnection):
Tools:
Add a test case to reproduce the crash.
- TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
(testWebViewCloseQuickly):
(beforeAll):
- 12:46 AM Changeset in webkit [231405] by
-
- 5 edits in releases/WebKitGTK/webkit-2.20
Revert "REGRESSION(r222772): [GTK][WPE] WebProcess from WebKitGtk+ 2.19.9x SIGSEVs in WebKit::WebProcess::ensureNetworkProcessConnection() at Source/WebKit/WebProcess/WebProcess.cpp:1127"
This reverts commit r230476.
May 6, 2018:
- 10:24 PM Changeset in webkit [231404] by
-
- 5 edits in trunk/Source/WTF
[WTF] Embed default atomic string table in Thread
https://bugs.webkit.org/show_bug.cgi?id=185349
Reviewed by Darin Adler.
Do not need to allocate AtomicStringTable separate from Thread
since the table's lifetime is completely the same as Thread.
This patch just embeds it as a data member of Thread.
- wtf/Threading.cpp:
(WTF::Thread::initializeInThread):
(WTF::Thread::didExit):
- wtf/Threading.h:
- wtf/text/AtomicStringTable.cpp:
(WTF::AtomicStringTable::create): Deleted.
(WTF::AtomicStringTable::destroy): Deleted.
- wtf/text/AtomicStringTable.h:
- 7:46 PM Changeset in webkit [231403] by
-
- 16 edits in trunk/Source
[JSC] Remove "using namespace std;" from JSC, bmalloc, WTF
https://bugs.webkit.org/show_bug.cgi?id=185362
Reviewed by Sam Weinig.
Source/bmalloc:
- bmalloc/Allocator.cpp:
- bmalloc/Deallocator.cpp:
Source/JavaScriptCore:
"namespace std" may include many names. It can conflict with names defined by our code,
and the other platform provided headers. For example, std::byte conflicts with Windows'
::byte.
This patch removes "using namespace std;" from JSC and bmalloc.
- API/JSClassRef.cpp:
(OpaqueJSClass::create):
- bytecode/Opcode.cpp:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newRegister):
- heap/Heap.cpp:
(JSC::Heap::updateAllocationLimits):
- interpreter/Interpreter.cpp:
- jit/JIT.cpp:
- parser/Parser.cpp:
- runtime/JSArray.cpp:
- runtime/JSLexicalEnvironment.cpp:
- runtime/JSModuleEnvironment.cpp:
- runtime/Structure.cpp:
- shell/DLLLauncherMain.cpp:
(getStringValue):
(applePathFromRegistry):
(appleApplicationSupportDirectory):
(copyEnvironmentVariable):
(prependPath):
(fatalError):
(directoryExists):
(modifyPath):
(getLastErrorString):
(wWinMain):
- 7:46 PM Changeset in webkit [231402] by
-
- 4 edits in trunk/Source/WTF
[WTF] Use static initializers for WTF::Mutex and WTF::ThreadCondition
https://bugs.webkit.org/show_bug.cgi?id=185361
Reviewed by Sam Weinig.
Use static initializers for WTF::Mutex and WTF::ThreadCondition to make
constructors of them simple and constexpr.
- wtf/ThreadingPrimitives.h:
- wtf/ThreadingPthreads.cpp:
(WTF::Mutex::Mutex): Deleted.
(WTF::ThreadCondition::ThreadCondition): Deleted.
- wtf/ThreadingWin.cpp:
(WTF::Mutex::Mutex): Deleted.
(WTF::ThreadCondition::ThreadCondition): Deleted.
- 7:09 PM Changeset in webkit [231401] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Add assertions for stale Display::Box geometry
https://bugs.webkit.org/show_bug.cgi?id=185357
Reviewed by Antti Koivisto.
Ensure that we don't access stale geometry of other boxes during layout.
For example, in order to layout a block child we need the containing block's content box top/left and width (but not the height)
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::invalidateTop):
(WebCore::Display::Box::invalidateLeft):
(WebCore::Display::Box::invalidateWidth):
(WebCore::Display::Box::invalidateHeight):
(WebCore::Display::Box::hasValidPosition const):
(WebCore::Display::Box::hasValidSize const):
(WebCore::Display::Box::hasValidGeometry const):
(WebCore::Display::Box::invalidatePosition):
(WebCore::Display::Box::invalidateSize):
(WebCore::Display::Box::setHasValidPosition):
(WebCore::Display::Box::setHasValidSize):
(WebCore::Display::Box::setHasValidGeometry):
(WebCore::Display::Box::rect const):
(WebCore::Display::Box::top const):
(WebCore::Display::Box::left const):
(WebCore::Display::Box::bottom const):
(WebCore::Display::Box::right const):
(WebCore::Display::Box::topLeft const):
(WebCore::Display::Box::bottomRight const):
(WebCore::Display::Box::size const):
(WebCore::Display::Box::width const):
(WebCore::Display::Box::height const):
(WebCore::Display::Box::setRect):
(WebCore::Display::Box::setTopLeft):
(WebCore::Display::Box::setTop):
(WebCore::Display::Box::setLeft):
(WebCore::Display::Box::setSize):
(WebCore::Display::Box::setWidth):
(WebCore::Display::Box::setHeight):
- 1:00 PM Changeset in webkit [231400] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Add BlockFormattingContext::computeStaticPosition
https://bugs.webkit.org/show_bug.cgi?id=185352
Reviewed by Antti Koivisto.
This is the core logic for positioning inflow boxes in a block formatting context (very naive though).
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
- layout/displaytree/DisplayBox.h:
May 5, 2018:
- 6:06 PM Changeset in webkit [231399] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG CFA phase should only do clobber asserts in debug
https://bugs.webkit.org/show_bug.cgi?id=185354
Reviewed by Saam Barati.
Clobber asserts are responsible for 1% of compile time. That's too much. This disables them
unless asserts are enabled.
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- 4:45 PM Changeset in webkit [231398] by
-
- 6 edits in trunk/Source/WebCore
Cleanup XMLHttpRequestUpload a little
https://bugs.webkit.org/show_bug.cgi?id=185344
Patch by Sam Weinig <sam@webkit.org> on 2018-05-05
Reviewed by Yusuke Suzuki.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitAdditionalChildren):
Use auto to reduce redundancy.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::upload):
- xml/XMLHttpRequest.h:
Switch upload() to return a reference.
- xml/XMLHttpRequestUpload.cpp:
(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):
- xml/XMLHttpRequestUpload.h:
Cleanup formatting, modernize and switch XMLHttpRequest member from a pointer
to a reference.
- 3:42 PM Changeset in webkit [231397] by
-
- 2 edits in trunk/Source/WebCore
Draw a drop-shadow behind the system preview badge
https://bugs.webkit.org/show_bug.cgi?id=185356
<rdar://problem/40004936>
Reviewed by Wenson Hsieh.
Draw a very subtle drop-shadow under the system
preview badge so that it is more visible on a pure
white background.
I also moved some code around to make it more clear
and improved comments.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSystemPreviewBadge):
May 4, 2018:
- 9:39 PM Changeset in webkit [231396] by
-
- 4 edits in trunk
[iOS] Multiple links in Mail are dropped in a single line, and are difficult to tell apart
https://bugs.webkit.org/show_bug.cgi?id=185289
<rdar://problem/35756912>
Reviewed by Tim Horton and Darin Adler.
Source/WebCore:
When inserting multiple URLs as individual items in a single drop, we currently separate each item with a space
(see r217284). However, it still seems difficult to tell dropped links apart. This patch makes some slight
tweaks to WebContentReader::readURL so that it inserts line breaks before dropped URLs, if the dropped URL isn't
the first item to be inserted in the resulting document fragment.
Augments existing API tests in DataInteractionTests.
- editing/ios/WebContentReaderIOS.mm:
Additionally remove some extraneous header imports from this implementation file.
(WebCore::WebContentReader::readURL):
Tools:
Augment and rebaseline some iOS drag-and-drop API tests that handle dropping URLs as a part of multi-item drop
sessions.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- 7:11 PM Changeset in webkit [231395] by
-
- 2 edits in trunk/LayoutTests
webrtc/addICECandidate-closed.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=185336
Reviewed by Eric Carlson.
- webrtc/addICECandidate-closed.html:
- 5:26 PM Changeset in webkit [231394] by
-
- 3 edits in trunk/Source/WebCore
Use IOSurfaces for CoreImage operations where possible
https://bugs.webkit.org/show_bug.cgi?id=185230
<rdar://problem/39926929>
Reviewed by Jon Lee.
On iOS hardware, we can use IOSurfaces as a rendering destination
for CoreImage, which means we're keeping data on the GPU
for rendering.
As a drive-by fix, I used a convenience method for Gaussian blurs.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintSystemPreviewBadge):
- 5:16 PM Changeset in webkit [231393] by
-
- 11 edits1 move in trunk/Source
Shift to a lower-level framework for simplifying URLs
https://bugs.webkit.org/show_bug.cgi?id=185334
Reviewed by Dan Bernstein.
Source/WebCore:
- Configurations/WebCore.xcconfig:
- platform/mac/DragImageMac.mm:
(WebCore::LinkImageLayout::LinkImageLayout):
Source/WebCore/PAL:
- PAL.xcodeproj/project.pbxproj:
- pal/PlatformMac.cmake:
- pal/spi/cocoa/URLFormattingSPI.h: Renamed from Source/WebCore/PAL/pal/spi/cocoa/LinkPresentationSPI.h.
Source/WebKit:
- Configurations/WebKit.xcconfig:
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _updateLocationInfo]):
Source/WTF:
- wtf/Platform.h:
- 4:58 PM Changeset in webkit [231392] by
-
- 4 edits in trunk/Source/WebCore
Release assert in ScriptController::canExecuteScripts via HTMLMediaElement::~HTMLMediaElement()
https://bugs.webkit.org/show_bug.cgi?id=185288
Reviewed by Jer Noble.
The crash is caused by HTMLMediaElement::~HTMLMediaElement canceling the resource load via CachedResource
which ends up calling FrameLoader::checkCompleted() and fire load event on the document synchronously.
Speculatively fix the crash by scheduling the check instead.
In long term, ResourceLoader::cancel should never fire load event synchronously: webkit.org/b/185284.
Unfortunately, no new tests since I can't get MediaResource to get destructed at the right time.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isRunningDestructor): Added to detect this specific case.
(WebCore::HTMLMediaElementDestructorScope): Added.
(WebCore::HTMLMediaElementDestructorScope::HTMLMediaElementDestructorScope): Added.
(WebCore::HTMLMediaElementDestructorScope::~HTMLMediaElementDestructorScope): Added.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Instantiate HTMLMediaElement.
- html/HTMLMediaElement.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Call scheduleCheckCompleted instead of synchronously calling
checkCompleted if we're in the middle of destructing a HTMLMediaElement.
- 4:56 PM Changeset in webkit [231391] by
-
- 43 edits in trunk
Web Inspector: simplify the WI.Collection interface
https://bugs.webkit.org/show_bug.cgi?id=185187
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Models/Collection.js:
(WI.Collection.prototype.get size): Added.
(WI.Collection.prototype.has): Added.
(WI.Collection.prototype.toJSON):
(WI.Collection.prototype.[Symbol.iterator]): Added.
(WI.Collection.prototype.get items): Deleted.
(WI.Collection.prototype.toArray): Deleted.
- UserInterface/Controllers/CanvasManager.js:
(WI.CanvasManager.prototype._removeCanvas):
- UserInterface/Controllers/DOMDebuggerManager.js:
(WebInspector.DOMDebuggerManager.prototype.get domBreakpoints):
- UserInterface/Models/Frame.js:
(WI.Frame.prototype.removeAllChildFrames):
(WI.Frame.prototype.resourceForURL):
(WI.Frame.prototype.removeAllResources):
- UserInterface/Models/Script.js:
(WI.Script):
- UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype.initialLayout):
- UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView.prototype._updateNavigationItems):
- UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype._recordingRemoved):
(WI.CanvasSidebarPanel.prototype._canvasChanged):
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
- UserInterface/Views/CanvasTabContentView.js:
(WI.CanvasTabContentView.prototype.attached):
(WI.CanvasTabContentView.prototype._addCanvas):
(WI.CanvasTabContentView.prototype._removeCanvas):
- UserInterface/Views/CanvasTreeElement.js:
(WI.CanvasTreeElement.prototype.onpopulate):
- UserInterface/Views/CollectionContentView.js:
(WI.CollectionContentView.prototype.initialLayout):
(WI.CollectionContentView.prototype.attached):
- UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView.prototype._filterCookies):
- UserInterface/Views/DebuggerSidebarPanel.js:
(WI.DebuggerSidebarPanel.prototype._addResourcesRecursivelyForFrame):
- UserInterface/Views/FolderizedTreeElement.js:
(WI.FolderizedTreeElement.prototype.updateParentStatus):
(WI.FolderizedTreeElement.prototype._shouldGroupIntoFolders):
- UserInterface/Views/FrameTreeElement.js:
(WI.FrameTreeElement.prototype.onpopulate):
- UserInterface/Views/NavigationSidebarPanel.js:
(WI.NavigationSidebarPanel.prototype.get contentTreeOutlines):
- UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._populateWithInitialResourcesIfNeeded):
- UserInterface/Views/OpenResourceDialog.js:
(WI.OpenResourceDialog.prototype._addResourcesForFrame):
(WI.OpenResourceDialog.prototype._addResourcesForTarget):
- UserInterface/Views/TreeOutlineGroup.js:
(WI.TreeOutlineGroup.prototype.get selectedTreeElement):
(WI.TreeOutlineGroup.prototype._removeConflictingTreeSelections):
- UserInterface/Views/WorkerTreeElement.js:
(WI.WorkerTreeElement.prototype.onpopulate):
LayoutTests:
- http/tests/inspector/dom/cross-domain-inspected-node-access.html:
- http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html:
- http/tests/inspector/network/har/har-page.html:
- http/tests/inspector/network/har/har-page-expected.txt:
- http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html:
- http/tests/inspector/network/resource-response-source-memory-cache.html:
- http/tests/inspector/network/resource-sizes-memory-cache.html:
- http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html:
- http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html:
- http/tests/websocket/tests/hybi/inspector/before-load.html:
- inspector/canvas/resources/recording-utilities.js:
- inspector/css/manager-preferredInspectorStyleSheetForFrame.html:
- inspector/debugger/resources/log-pause-location.js:
(TestPage.registerInitializer.window.findScript):
- inspector/dom/highlightFrame.html:
- inspector/dom/highlightNode.html:
- inspector/dom/highlightNodeList.html:
- inspector/dom/highlightSelector.html:
- inspector/model/frame-extra-scripts.html:
- inspector/page/empty-or-missing-resources.html:
- inspector/unit-tests/resource-collection.html:
- inspector/worker/resources-in-worker.html:
- 4:52 PM Changeset in webkit [231390] by
-
- 7 edits2 moves in trunk/Source/WebCore
Rename DocumentOrderedMap to TreeScopeOrderedMap
https://bugs.webkit.org/show_bug.cgi?id=185290
Reviewed by Zalan Bujtas.
Renamed the class since it's almost always a mistake to use this class as a member variable of Document.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/MouseRelatedEvent.cpp: Include the forgotten DOMWindow.h. Unified build files bit us here.
- dom/TreeScope.cpp:
(WebCore::TreeScope::addElementById):
(WebCore::TreeScope::addElementByName):
(WebCore::TreeScope::addImageMap):
(WebCore::TreeScope::addImageElementByUsemap):
(WebCore::TreeScope::labelElementForId):
- dom/TreeScope.h:
- dom/TreeScopeOrderedMap.cpp: Renamed from DocumentOrderedMap.cpp
- dom/TreeScopeOrderedMap.h: Renamed from DocumentOrderedMap.h
- html/HTMLDocument.h:
- 4:42 PM Changeset in webkit [231389] by
-
- 2 edits in trunk/Source/WebKit
Shutdown WindowServer connections after checking in with launch services
https://bugs.webkit.org/show_bug.cgi?id=185082
<rdar://problem/39613173>
Reviewed by Brent Fulgham.
When WindowServer access is blocked in the WebContent process, we should shutdown all connections
after checking in with launch services.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
- 4:41 PM Changeset in webkit [231388] by
-
- 4 edits1 delete in trunk/LayoutTests
REGRESSION (r230326?): Layout Test http/tests/contentextensions/make-https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=184476
<rdar://problem/39384226>
Reviewed by Ryosuke Niwa.
Removed flakiness expectation.
Updated test to no longer log load callbacks.
Instead, we rely on the fact that the four content extension upgrades
are also logged as console log messages.
- http/tests/contentextensions/make-https-expected.txt:
- http/tests/contentextensions/make-https.html:
- platform/mac-sierra-wk2/http/tests/contentextensions/make-https-expected.txt: Removed.
- platform/mac-wk2/TestExpectations:
- 4:29 PM Changeset in webkit [231387] by
-
- 8 edits in trunk/Source
[Win][WebKit] Fix forwarding headers for Windows build
https://bugs.webkit.org/show_bug.cgi?id=184412
Reviewed by Alex Christensen.
Source/WebCore:
No new tests. No change in behavior.
- PlatformWin.cmake:
Source/WebKit:
- PlatformWin.cmake:
- UIProcess/API/APIAttachment.h:
- UIProcess/API/APIContextMenuClient.h:
- UIProcess/API/C/WKProcessTerminationReason.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
- 4:07 PM Changeset in webkit [231386] by
-
- 2 edits in trunk/LayoutTests
Mark animations/duplicate-keys.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=185332
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 3:34 PM Changeset in webkit [231385] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests for iOS after r231359.
Unreviewed test gardening.
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- 3:23 PM Changeset in webkit [231384] by
-
- 4 edits in trunk/Source/WebCore
[Simple line layout] Add support for line layout box generation with multiple text renderers.
https://bugs.webkit.org/show_bug.cgi?id=185276
Reviewed by Antti Koivisto.
Covered by existing tests.
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::canUseForLineBoxTree):
(WebCore::SimpleLineLayout::generateLineBoxTree):
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::Run::renderer const):
(WebCore::SimpleLineLayout::RunResolver::Run::localStart const):
(WebCore::SimpleLineLayout::RunResolver::Run::localEnd const):
- rendering/SimpleLineLayoutResolver.h:
- 2:43 PM Changeset in webkit [231383] by
-
- 155 edits in trunk
Deprecate legacy WebView and friends
https://bugs.webkit.org/show_bug.cgi?id=185279
rdar://problem/33268700
Reviewed by Tim Horton.
Source/WebCore:
- Configurations/WebCore.xcconfig:
Added BUILDING_WEBKIT define to disable the deprecation macros.
- bridge/objc/WebScriptObject.h:
Added deprecation macros to WebScriptObject and WebUndefined.
- platform/cocoa/WebKitAvailability.h:
Added more macros and a way to disable deprecation warnings for
WebKit build and in clients like Safari.
Source/WebKitLegacy/mac:
Added deprecation macros to all the classes, extern strings, and enums.
- Configurations/WebKitLegacy.xcconfig:
Added BUILDING_WEBKIT define to disable the deprecation macros.
- DOM/DOMAbstractView.h:
- DOM/DOMAttr.h:
- DOM/DOMBlob.h:
- DOM/DOMCDATASection.h:
- DOM/DOMCSSCharsetRule.h:
- DOM/DOMCSSFontFaceRule.h:
- DOM/DOMCSSImportRule.h:
- DOM/DOMCSSMediaRule.h:
- DOM/DOMCSSPageRule.h:
- DOM/DOMCSSPrimitiveValue.h:
- DOM/DOMCSSRule.h:
- DOM/DOMCSSRuleList.h:
- DOM/DOMCSSStyleDeclaration.h:
- DOM/DOMCSSStyleRule.h:
- DOM/DOMCSSStyleSheet.h:
- DOM/DOMCSSUnknownRule.h:
- DOM/DOMCSSValue.h:
- DOM/DOMCSSValueList.h:
- DOM/DOMCharacterData.h:
- DOM/DOMComment.h:
- DOM/DOMCounter.h:
- DOM/DOMDocument.h:
- DOM/DOMDocumentFragment.h:
- DOM/DOMDocumentType.h:
- DOM/DOMElement.h:
- DOM/DOMEntity.h:
- DOM/DOMEntityReference.h:
- DOM/DOMEvent.h:
- DOM/DOMEventException.h:
- DOM/DOMEventListener.h:
- DOM/DOMEventTarget.h:
- DOM/DOMException.h:
- DOM/DOMFile.h:
- DOM/DOMFileList.h:
- DOM/DOMHTMLAnchorElement.h:
- DOM/DOMHTMLAppletElement.h:
- DOM/DOMHTMLAreaElement.h:
- DOM/DOMHTMLBRElement.h:
- DOM/DOMHTMLBaseElement.h:
- DOM/DOMHTMLBaseFontElement.h:
- DOM/DOMHTMLBodyElement.h:
- DOM/DOMHTMLButtonElement.h:
- DOM/DOMHTMLCanvasElement.h:
- DOM/DOMHTMLCollection.h:
- DOM/DOMHTMLDListElement.h:
- DOM/DOMHTMLDirectoryElement.h:
- DOM/DOMHTMLDivElement.h:
- DOM/DOMHTMLDocument.h:
- DOM/DOMHTMLElement.h:
- DOM/DOMHTMLEmbedElement.h:
- DOM/DOMHTMLFieldSetElement.h:
- DOM/DOMHTMLFontElement.h:
- DOM/DOMHTMLFormElement.h:
- DOM/DOMHTMLFrameElement.h:
- DOM/DOMHTMLFrameSetElement.h:
- DOM/DOMHTMLHRElement.h:
- DOM/DOMHTMLHeadElement.h:
- DOM/DOMHTMLHeadingElement.h:
- DOM/DOMHTMLHtmlElement.h:
- DOM/DOMHTMLIFrameElement.h:
- DOM/DOMHTMLImageElement.h:
- DOM/DOMHTMLInputElement.h:
- DOM/DOMHTMLLIElement.h:
- DOM/DOMHTMLLabelElement.h:
- DOM/DOMHTMLLegendElement.h:
- DOM/DOMHTMLLinkElement.h:
- DOM/DOMHTMLMapElement.h:
- DOM/DOMHTMLMarqueeElement.h:
- DOM/DOMHTMLMediaElement.h:
- DOM/DOMHTMLMenuElement.h:
- DOM/DOMHTMLMetaElement.h:
- DOM/DOMHTMLModElement.h:
- DOM/DOMHTMLOListElement.h:
- DOM/DOMHTMLObjectElement.h:
- DOM/DOMHTMLOptGroupElement.h:
- DOM/DOMHTMLOptionElement.h:
- DOM/DOMHTMLOptionsCollection.h:
- DOM/DOMHTMLParagraphElement.h:
- DOM/DOMHTMLParamElement.h:
- DOM/DOMHTMLPreElement.h:
- DOM/DOMHTMLQuoteElement.h:
- DOM/DOMHTMLScriptElement.h:
- DOM/DOMHTMLSelectElement.h:
- DOM/DOMHTMLStyleElement.h:
- DOM/DOMHTMLTableCaptionElement.h:
- DOM/DOMHTMLTableCellElement.h:
- DOM/DOMHTMLTableColElement.h:
- DOM/DOMHTMLTableElement.h:
- DOM/DOMHTMLTableRowElement.h:
- DOM/DOMHTMLTableSectionElement.h:
- DOM/DOMHTMLTextAreaElement.h:
- DOM/DOMHTMLTitleElement.h:
- DOM/DOMHTMLUListElement.h:
- DOM/DOMHTMLVideoElement.h:
- DOM/DOMImplementation.h:
- DOM/DOMKeyboardEvent.h:
- DOM/DOMMediaError.h:
- DOM/DOMMediaList.h:
- DOM/DOMMouseEvent.h:
- DOM/DOMMutationEvent.h:
- DOM/DOMNamedNodeMap.h:
- DOM/DOMNode.h:
- DOM/DOMNodeFilter.h:
- DOM/DOMNodeIterator.h:
- DOM/DOMNodeList.h:
- DOM/DOMObject.h:
- DOM/DOMOverflowEvent.h:
- DOM/DOMProcessingInstruction.h:
- DOM/DOMProgressEvent.h:
- DOM/DOMRGBColor.h:
- DOM/DOMRange.h:
- DOM/DOMRangeException.h:
- DOM/DOMRect.h:
- DOM/DOMStyleSheet.h:
- DOM/DOMStyleSheetList.h:
- DOM/DOMText.h:
- DOM/DOMTextEvent.h:
- DOM/DOMTimeRanges.h:
- DOM/DOMTokenList.h:
- DOM/DOMTreeWalker.h:
- DOM/DOMUIEvent.h:
- DOM/DOMWheelEvent.h:
- DOM/DOMXPathException.h:
- DOM/DOMXPathExpression.h:
- DOM/DOMXPathNSResolver.h:
- DOM/DOMXPathResult.h:
- History/WebBackForwardList.h:
- History/WebHistory.h:
- History/WebHistoryItem.h:
- Misc/WebDownload.h:
- Misc/WebKitErrors.h:
- Plugins/WebPluginViewFactory.h:
- WebView/WebArchive.h:
- WebView/WebDataSource.h:
- WebView/WebDocument.h:
- WebView/WebEditingDelegate.h:
- WebView/WebFormDelegate.h:
- WebView/WebFrame.h:
- WebView/WebFrameLoadDelegate.h:
- WebView/WebFrameView.h:
- WebView/WebPolicyDelegate.h:
- WebView/WebPreferences.h:
- WebView/WebPreferencesPrivate.h:
- WebView/WebResourceLoadDelegate.h:
- WebView/WebUIDelegate.h:
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.h:
- WebView/WebViewPrivate.h:
- postprocess-headers.sh:
Remove step that converts WEBKIT macros to NS macros.
Change it to just remove the macros on iOS builds.
Tools:
- MiniBrowser/Configurations/Base.xcconfig: Added GCC_PREPROCESSOR_DEFINITIONS
to define DISABLE_LEGACY_WEBKIT_DEPRECATIONS.
- 2:39 PM Changeset in webkit [231382] by
-
- 7 edits in trunk/Source
Log media time range as JSON
https://bugs.webkit.org/show_bug.cgi?id=185321
<rdar://problem/39986746>
Reviewed by Youenn Fablet.
Source/WebCore:
No new tests, tested manually.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::addPlayedRange): Log as time range.
(WebCore::HTMLMediaElement::visibilityStateChanged): Cleanup.
- platform/graphics/MediaPlayer.h:
(WTF::LogArgument<MediaTime>::toString):
(WTF::LogArgument<MediaTimeRange>::toString):
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Log error as time range.
Source/WTF:
- wtf/MediaTime.cpp:
(WTF::toJSONStringInternal): Extract guts of MediaTime::toJSONString to this static function
so it can be used by MediaTimeRange::toJSONString as well.
(WTF::MediaTime::toJSONString const):
(WTF::MediaTimeRange::toJSONString const):
- wtf/MediaTime.h:
- 2:26 PM Changeset in webkit [231381] by
-
- 4 edits in trunk/LayoutTests
Rebaseline tests after r231359.
Unreviewed test gardening.
- platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- 2:26 PM Changeset in webkit [231380] by
-
- 3 edits in trunk/LayoutTests
Update TestExpectations for media/video-aspect-ratio.html.
https://bugs.webkit.org/show_bug.cgi?id=184457
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 2:15 PM Changeset in webkit [231379] by
-
- 3 edits2 adds in trunk
Use the containing block to compute the pagination gap when the container is inline.
https://bugs.webkit.org/show_bug.cgi?id=184724
<rdar://problem/39521800>
Reviewed by Simon Fraser.
Source/WebCore:
Test: fast/overflow/page-overflow-with-inline-body-crash.html
- page/FrameView.cpp:
(WebCore::FrameView::applyPaginationToViewport):
LayoutTests:
- fast/overflow/page-overflow-with-inline-body-crash-expected.txt: Added.
- fast/overflow/page-overflow-with-inline-body-crash.html: Added.
- 1:54 PM Changeset in webkit [231378] by
-
- 2 edits in trunk/Source/WebCore
Don't use GSFont* in minimal simulator mode
https://bugs.webkit.org/show_bug.cgi?id=185320
<rdar://problem/39734478>
Reviewed by Beth Dakin.
- page/cocoa/MemoryReleaseCocoa.mm:
(WebCore::platformReleaseMemory):
- 1:51 PM Changeset in webkit [231377] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: Newly added unsupported properties sometimes don't have warnings
https://bugs.webkit.org/show_bug.cgi?id=183097
<rdar://problem/37843816>
Reviewed by Matt Baker.
Update status of properties warnings every time focus moves.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.layout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyFocusMoved):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._propertiesChanged):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._updatePropertiesStatus):
- UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
- 1:48 PM Changeset in webkit [231376] by
-
- 2 edits in trunk/Source/WebKit
[iOS] Apps that are not visible may not get suspended if they trigger page loads while in the background
https://bugs.webkit.org/show_bug.cgi?id=185318
Reviewed by Geoffrey Garen.
Whenever there is a page load going on, we take a background process assertion to delay process
suspension until this load completes. However, there is also a 3 seconds grace period after
a load is complete to allow the app to trigger a new load shortly after. This grace period was
introduced to support use cases where a visible app does loads in an offscreen view. However,
it can be abused by apps running in the background as they could trigger new page loads while
in the background to delay process suspension. This patch tightens the policy so that only
apps that are currently visible get to use this grace period. Apps that are in the background
get to finish their current load and will then get suspended.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::didChangeIsLoading):
- 1:47 PM Changeset in webkit [231375] by
-
- 3 edits1 add in trunk
isCacheableArrayLength should return true for undecided arrays
https://bugs.webkit.org/show_bug.cgi?id=185309
Reviewed by Michael Saboff.
JSTests:
- stress/get-array-length-undecided.js: Added.
(test):
Source/JavaScriptCore:
Undecided arrays have butterflies so there is no reason why we
should not be able to cache their length.
- bytecode/InlineAccess.cpp:
(JSC::InlineAccess::isCacheableArrayLength):
- 1:44 PM Changeset in webkit [231374] by
-
- 2 edits in trunk/Source/WebKit
Adjust sandbox profile for simulator.
https://bugs.webkit.org/show_bug.cgi?id=185319
Reviewed by Brent Fulgham.
Disable Kerberos rules, as well as rules related to NSApplication initialization.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:40 PM Changeset in webkit [231373] by
-
- 1 edit2 adds in trunk/Tools
Test262-Runner: Add base module to the local deps - unicore/PVA.pl
https://bugs.webkit.org/show_bug.cgi?id=185314
Patch by Leo Balter <Leo Balter> on 2018-05-04
Reviewed by Michael Saboff.
- Scripts/test262/local/lib/perl5/unicore/PVA.pl: Added.
- 1:29 PM Changeset in webkit [231372] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles Redesign: ensure that tabbing through the last section wraps back to the first
https://bugs.webkit.org/show_bug.cgi?id=181973
Reviewed by Matt Baker.
Unified delegate functions to start editing previous/next rules into a single function for
simplicity.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetCSSStyleDeclarationEditorFocusMoved):
- UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.startEditingRuleSelector):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetSelectorFieldDidChange):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorStartEditingAdjacentRule):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.cssStyleDeclarationEditorStartEditingAdjacentRule): Deleted.
- UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.focusFirstSection):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.focusLastSection):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.spreadsheetCSSStyleDeclarationSectionStartEditingAdjacentRule):
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionStartEditingNextRule): Deleted.
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.cssStyleDeclarationSectionStartEditingPreviousRule): Deleted.
- UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype.styleDetailsPanelFocusLastPseudoClassCheckbox):
(WI.GeneralStyleDetailsSidebarPanel.prototype.styleDetailsPanelFocusFilterBar):
(WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout):
(WI.GeneralStyleDetailsSidebarPanel.prototype._handleForcedPseudoClassCheckboxKeydown):
(WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
(WI.GeneralStyleDetailsSidebarPanel.prototype._handleFilterBarInputFieldKeyDown):
Drive-by fix: provide tabbing support for the Computed styles panel.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WI.CSSStyleDeclarationTextEditor.prototype._handleShiftTabKey.switchRule):
(WI.CSSStyleDeclarationTextEditor.prototype._handleTabKey.switchRule):
- UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.focusFirstSection):
(WI.ComputedStyleDetailsPanel.prototype.focusLastSection):
(WI.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorStartEditingAdjacentRule):
- 12:42 PM Changeset in webkit [231371] by
-
- 3 edits in trunk/Source/WebKit
Wasted time dlopening Lookup when tearing down a WKWebView
https://bugs.webkit.org/show_bug.cgi?id=185310
<rdar://problem/39934085>
Reviewed by Wenson Hsieh.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(-[WKWindowVisibilityObserver dealloc]):
(-[WKWindowVisibilityObserver startObservingLookupDismissalIfNeeded]):
(WebKit::WebViewImpl::prepareForDictionaryLookup):
(-[WKWindowVisibilityObserver startObservingLookupDismissal]): Deleted.
Avoid un-registering as a Lookup dismissal observer if we never
registered in the first place, because that involves dlopening Lookup.
- 12:16 PM Changeset in webkit [231370] by
-
- 2 edits in trunk/Source/WebKit
Allow Web Touch events to timeout
https://bugs.webkit.org/show_bug.cgi?id=185282
<rdar://problem/38728319>
Reviewed by Tim Horton.
Web Touch events currently never time out, which blocks the user from interacting with the UI Process at all.
We should allow these events to time out so that the user can interact with the rest of the UI.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleTouchEventSynchronously):
- 11:52 AM Changeset in webkit [231369] by
-
- 4 edits in trunk
REGRESSION: [ios-simulator] 3 WKWebViewAutofillTests API test failures seen with 11.3 SDK
https://bugs.webkit.org/show_bug.cgi?id=184196
<rdar://problem/39054481>
Patch by Wenson Hsieh <whsieh@berkeley.edu> on 2018-05-04
Reviewed by Tim Horton.
Source/WebKit:
Remove an unnecessary call to NSClassFromString, now that trunk WebKit only supports iOS 11.3+.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertTextSuggestion:]):
Tools:
Removes some unnecessary workarounds to enable running app autofill tests against iOS versions
earlier than 11.3. Also re-enables these tests.
- TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
(TestWebKitAPI::TEST):
(-[UITextAutofillSuggestion initWithUsername:password:]): Deleted.
(+[UITextAutofillSuggestion autofillSuggestionWithUsername:password:]): Deleted.
- 11:50 AM Changeset in webkit [231368] by
-
- 4 edits in trunk
Web Inspector: Canvas tab: Determine isFunction by looking at the prototype
https://bugs.webkit.org/show_bug.cgi?id=184990
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction._prototypeForType):
(WI.RecordingAction.prototype.async.swizzle):
LayoutTests:
- inspector/canvas/recording-2d-expected.txt:
- 11:44 AM Changeset in webkit [231367] by
-
- 24 edits2 deletes in trunk
Unreviewed, rolling out r231331.
Caused a few tests to assert
Reverted changeset:
"Stop using an iframe's id as fallback if its name attribute
is not set"
https://bugs.webkit.org/show_bug.cgi?id=11388
https://trac.webkit.org/changeset/231331
- 11:37 AM Changeset in webkit [231366] by
-
- 2 edits in trunk/Source/WebCore
Use more references in updateTracksOfType
https://bugs.webkit.org/show_bug.cgi?id=185305
Reviewed by Eric Carlson.
No change of behavior.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::updateTracksOfType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
- 11:35 AM Changeset in webkit [231365] by
-
- 7 edits in trunk/Source/WebKit
NetworkProcessProxy::didReceiveAuthenticationChallenge should take an AuthenticationChallenge r-value
https://bugs.webkit.org/show_bug.cgi?id=185302
Reviewed by Geoffrey Garen.
Pass AuthenticationChallenge as an r-value since it comes from IPC.
No change of behavior.
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::AuthenticationChallengeProxy):
- UIProcess/Authentication/AuthenticationChallengeProxy.h:
(WebKit::AuthenticationChallengeProxy::create):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
- UIProcess/Network/NetworkProcessProxy.h:
- 11:01 AM Changeset in webkit [231364] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/contentextensions/make-https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184476
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 11:01 AM Changeset in webkit [231363] by
-
- 2 edits in trunk/LayoutTests
Mark media/navigate-with-pip-should-not-crash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173119
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:46 AM Changeset in webkit [231362] by
-
- 2 edits in trunk/JSTests
Disable tests on systems with limited memory
https://bugs.webkit.org/show_bug.cgi?id=185296
Patch by Dominik Infuehr <dinfuehr@igalia.com> on 2018-05-04
Reviewed by Saam Barati.
Test doesn't work with a limited amount of memory. I tried to reduce memory usage
but then it was hard to reproduce the failure the test was originally made to test.
- stress/array-reverse-doesnt-clobber.js:
- 10:38 AM Changeset in webkit [231361] by
-
- 6 edits6 adds in trunk
Text shaping in the simple path is flipped in the y direction
https://bugs.webkit.org/show_bug.cgi?id=185062
<rdar://problem/39778678>
Reviewed by Simon Fraser.
Source/WebCore:
Shaping in our simple codepath occurs in an "increasing-y-goes-up" coordinate system, but our painting
code uses an "increasing-y-goes-down" coordinate system. We weren't fixing up the coordinate systems
because we never noticed. This is because the simple codepath is only designed for kerning and ligatures,
neither of which move glyphs vertically in the common case.
Test: fast/text/vertical-displacement-simple-codepath.html
- platform/graphics/Font.cpp:
(WebCore::Font::applyTransforms const):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyFontTransforms):
Tools:
Huge thanks to Ulrike Rausch of LiebeFonts for contributing the test fonts!!!
- Scripts/webkitpy/common/config/contributors.json:
LayoutTests:
This test renders a font which uses our fast text codepath but also includes vertical
displacements inside its liga feature. The test makes sure that the vertical displacement
occurs in the correct direction.
The test fonts were created by Ulrike Rausch of LiebeFonts specifically for the purpose
of testing. Huge thanks to her!! Figuring out this bug would not have been possible if
not for her huge help!
- fast/text/resources/LiebeTest-calt.woff: Added.
- fast/text/resources/LiebeTest-dlig.woff: Added.
- fast/text/resources/LiebeTest-liga.woff: Added.
- fast/text/resources/LiebeTest-swsh.woff: Added.
- fast/text/vertical-displacement-simple-codepath-expected.html: Added.
- fast/text/vertical-displacement-simple-codepath.html: Added.
- 10:36 AM Changeset in webkit [231360] by
-
- 2 edits in trunk/Tools
Test262-Runner: place the processCLI inside the main call
https://bugs.webkit.org/show_bug.cgi?id=185304
Patch by Leo Balter <Leo Balter> on 2018-05-04
Reviewed by Michael Saboff.
- Scripts/test262/Runner.pm:
(main):
- 10:32 AM Changeset in webkit [231359] by
-
- 80 edits1 delete in trunk
Serialize all URLs with double-quotes per CSSOM spec
https://bugs.webkit.org/show_bug.cgi?id=184935
Patch by Chris Nardi <cnardi@chromium.org> on 2018-05-04
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Update expectations for using double quotes when serializing URLs.
- web-platform-tests/cssom/serialize-values-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
Source/WebCore:
According to https://drafts.csswg.org/cssom/#serialize-a-url, all URLs should be serialized as strings,
which means they should have double quotes around the text of the URL. Update our implementation to match
this (and Firefox/Chrome). Also remove isCSSTokenizerURL() as this method is no longer needed.
Tests: Many LayoutTests updated to use double quotes.
- css/CSSMarkup.cpp:
(WebCore::serializeString): Remove FIXME as this was already fixed in a previous patch.
(WebCore::serializeURL): Remove FIXME and update implementation.
LayoutTests:
Update tests to use double quotes when serializing URLs, and fixes for using double quotes in the test.
- css3/calc/cross-fade-calc.html:
- css3/filters/backdrop/backdropfilter-property-computed-style-expected.txt:
- css3/filters/backdrop/backdropfilter-property-computed-style.html:
- css3/filters/backdrop/backdropfilter-property-parsing-expected.txt:
- css3/filters/backdrop/backdropfilter-property-parsing.html:
- css3/filters/filter-property-computed-style-expected.txt:
- css3/filters/filter-property-computed-style.html:
- css3/filters/filter-property-expected.txt:
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/filter-property-parsing.html:
- css3/filters/filter-property.html:
- css3/filters/unprefixed-expected.txt:
- css3/filters/unprefixed.html:
- fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt:
- fast/backgrounds/background-shorthand-after-set-backgroundSize.html:
- fast/backgrounds/background-shorthand-with-backgroundSize-style-expected.txt:
- fast/backgrounds/background-shorthand-with-backgroundSize-style.html:
- fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
- fast/backgrounds/multiple-backgrounds-computed-style.html:
- fast/css/background-position-serialize-expected.txt:
- fast/css/cursor-parsing-expected.txt:
- fast/css/cursor-parsing-image-set-expected.txt:
- fast/css/cursor-parsing-image-set.html:
- fast/css/cursor-parsing.html:
- fast/css/getComputedStyle/computed-style-border-image-expected.txt:
- fast/css/getComputedStyle/computed-style-border-image.html:
- fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
- fast/css/getComputedStyle/computed-style-cross-fade.html:
- fast/css/getComputedStyle/computed-style-properties-expected.txt:
- fast/css/getComputedStyle/computed-style-properties.html:
- fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
- fast/css/getComputedStyle/getComputedStyle-list-style-shorthand-expected.txt:
- fast/css/getComputedStyle/getComputedStyle-list-style-shorthand.html:
- fast/css/image-set-parsing.html:
- fast/css/image-set-setting-expected.txt:
- fast/css/image-set-setting.html:
- fast/css/image-set-unprefixed-expected.txt:
- fast/css/image-set-unprefixed.html:
- fast/css/invalid-cursor-property-crash.html:
- fast/css/parse-border-image-repeat-null-crash-expected.txt:
- fast/css/uri-token-parsing-expected.txt:
- fast/css/uri-token-parsing.html:
- fast/css/url-with-multi-byte-unicode-escape-expected.txt:
- fast/css/url-with-multi-byte-unicode-escape.html:
- fast/filter-image/parse-filter-image-expected.txt:
- fast/filter-image/parse-filter-image.html:
- fast/innerHTML/innerHTML-uri-resolution.html:
- fast/inspector-support/cssURLQuotes-expected.txt:
- fast/inspector-support/cssURLQuotes.html:
- fast/masking/parsing-clip-path-iri-expected.txt:
- fast/masking/parsing-clip-path-iri.html:
- fast/masking/parsing-mask-expected.txt:
- fast/masking/parsing-mask.html:
- fast/shapes/parsing/parsing-shape-outside-expected.txt:
- fast/shapes/parsing/parsing-shape-outside.html:
- fast/shapes/parsing/parsing-test-utils.js:
(removeBaseURL):
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- platform/ios/fast/css/image-set-unprefixed-expected.txt: Removed.
- platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- platform/win/fast/css/parse-border-image-repeat-null-crash-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
- platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- resources/image-preload-helper.js:
(preloadImagesFromStyle):
- svg/css/svg-attribute-parser-mode-expected.txt:
- svg/css/svg-attribute-parser-mode.html:
- svg/custom/marker-getPropertyValue-expected.txt:
- svg/custom/marker-getPropertyValue.svg:
- 10:24 AM Changeset in webkit [231358] by
-
- 2 edits in trunk/Source/WebCore
LayoutTests/fast/mediastream/change-tracks-media-stream-being-played.html is crashing after r231304
https://bugs.webkit.org/show_bug.cgi?id=185303
Reviewed by Eric Carlson.
We need to stop observing the audio track like we do for video track once we are no longer interested in it.
Covered by test no longer crashing.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks):
- 10:21 AM Changeset in webkit [231357] by
-
- 2 edits in trunk/LayoutTests
Improve test at media/modern-media-controls/airplay-button/airplay-button-on.html to not hardcode the -apple-wireless-playback-target-active color
https://bugs.webkit.org/show_bug.cgi?id=185297
<rdar://problem/39737716>
Patch by Antoine Quint <Antoine Quint> on 2018-05-04
Reviewed by Dean Jackson.
Create an element and set its "color" property to "-apple-wireless-playback-target-active" so we can use
getComputedStyle() to query the applied value instead of hard-coding the expected color.
- media/modern-media-controls/airplay-button/airplay-button-on.html:
- 9:51 AM Changeset in webkit [231356] by
-
- 2 edits in trunk/Source/WebKit
Assertion failure in NetworkStorageSession::setCookie: privilege of UI process is not set
https://bugs.webkit.org/show_bug.cgi?id=185262
Patch by Sihui Liu <sihui_liu@apple.com> on 2018-05-04
Reviewed by Chris Dumez.
Fix an assertion failure by setting UI process privileges in constructor of WebsiteDataStore
because UI process may use the cookie API before creating a WebView.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::WebsiteDataStore):
- 9:30 AM Changeset in webkit [231355] by
-
- 8 edits1 copy in trunk/Source/WebCore
[LFC] Set the invalidation root as the result of style change.
https://bugs.webkit.org/show_bug.cgi?id=185301
Reviewed by Antti Koivisto.
Compute/propagate the update type on the ancestor chain and return the invalidation root
so that LayoutContext could use it as the entry point for the next layout frame.
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::updateLayout):
(WebCore::Layout::LayoutContext::styleChanged):
- layout/LayoutContext.h: order is not important.
- layout/blockformatting/BlockInvalidation.cpp:
(WebCore::Layout::invalidationStopsAtFormattingContextBoundary):
(WebCore::Layout::computeUpdateType):
(WebCore::Layout::computeUpdateTypeForAncestor):
(WebCore::Layout::BlockInvalidation::invalidate):
- layout/blockformatting/BlockInvalidation.h:
- layout/inlineformatting/InlineInvalidation.cpp:
(WebCore::Layout::InlineInvalidation::invalidate):
- layout/inlineformatting/InlineInvalidation.h:
- 9:15 AM Changeset in webkit [231354] by
-
- 2 edits in trunk/Source/WebKit
Adjust sandbox rules for simulator.
https://bugs.webkit.org/show_bug.cgi?id=185275
Reviewed by Brent Fulgham.
Enable rules related to CoreMedia for minimal simulator.
- WebProcess/com.apple.WebProcess.sb.in:
- 8:35 AM Changeset in webkit [231353] by
-
- 2 edits in trunk/Source/WTF
OptionsSet initializer list constructor should be constexpr
https://bugs.webkit.org/show_bug.cgi?id=185298
Reviewed by Anders Carlsson.
- wtf/OptionSet.h:
(WTF::OptionSet::OptionSet):
- 8:18 AM Changeset in webkit [231352] by
-
- 3 edits2 adds in trunk
PeerConnection should have its connectionState closed even if doing gathering
https://bugs.webkit.org/show_bug.cgi?id=185267
Reviewed by Darin Adler.
Source/WebCore:
Test: webrtc/addICECandidate-closed.html
In case m_iceConnectionState is closed, m_connectionState should also be set to closed
and RTCPeerConnection should be closed so as to reject any other call.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::updateConnectionState):
LayoutTests:
- webrtc/addICECandidate-closed-expected.txt: Added.
- webrtc/addICECandidate-closed.html: Added.
- 6:26 AM Changeset in webkit [231351] by
-
- 2 edits in trunk/Source/WebCore
[MSE][GStreamer] Delete properly the stream from the WebKitMediaSource
https://bugs.webkit.org/show_bug.cgi?id=185242
Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-05-04
Reviewed by Xabier Rodriguez-Calvar.
When the sourceBuffer is removed from mediasource, the appropriate stream is not
properly deleted from WebKitMediaSource, because the appsrc and parser elements
of the stream are not removed from the WebKitMediaSource bin.
This patch avoids the regression of r231089, see https://bugs.webkit.org/show_bug.cgi?id=185071
- platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webKitMediaSrcFreeStream):
- 3:14 AM Changeset in webkit [231350] by
-
- 9 edits in trunk
[GTK] Epiphany (GNOME Web) says "Error downloading: Service Unavailable." when trying to download an image from discogs.com
https://bugs.webkit.org/show_bug.cgi?id=174730
Reviewed by Michael Catanzaro.
Source/WebCore:
Export ResourceRequestBase::hasHTTPHeaderField().
- platform/network/ResourceRequestBase.h:
Source/WebKit:
The problem is that we don't send any User-Agent HTTP header for downloads started by WebProcessPool::download().
- UIProcess/API/glib/WebKitDownload.cpp:
(webkitDownloadUpdateRequest): Helper to update the cached request.
(webkitDownloadStarted): Updated the cached request if we have one.
(webkit_download_get_request): Use webkitDownloadUpdateRequest().
- UIProcess/API/glib/WebKitDownloadClient.cpp:
- UIProcess/API/glib/WebKitDownloadPrivate.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::download): Set the User-Agent HTTP header if there isn't any.
Tools:
Update unit tests to check that User-Agent header is included in HTTP download requests.
- TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(testDownloadRemoteFile):
(testWebViewDownloadURI):
(testPolicyResponseDownload):
(testPolicyResponseDownloadCancel):
(testDownloadMIMEType):
(testContextMenuDownloadActions):
- 3:12 AM Changeset in webkit [231349] by
-
- 4 edits in trunk
[GTK] Some event tests failing after r230817
https://bugs.webkit.org/show_bug.cgi?id=185072
Reviewed by Michael Catanzaro.
Source/WebKit:
Do not send mouse move events to the WebProcess for crossing events during testing. WTR never generates crossing
events and they can confuse tests.
Fixes: editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
fast/css/user-drag-none.html
fast/events/context-activated-by-key-event.html
fast/events/drag-selects-image.html
fast/events/dropzone-005.html
fast/events/mouse-click-events.html
fast/events/mouse-cursor-change.html
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseCrossingNotifyEvent):
LayoutTests:
Remove expectations for tests that are passing now.
- platform/gtk/TestExpectations:
