Context Navigation

← Previous Period
Next Period →

Timeline

Jun 25, 2018:

10:47 PM Changeset in webkit [233191] by youenn@apple.com

6 edits
25 adds in trunk/LayoutTests

Import WPT fetch destination tests
https://bugs.webkit.org/show_bug.cgi?id=186984

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/fetch/api/request/destination/fetch-destination-iframe.https-expected.txt: Added.
web-platform-tests/fetch/api/request/destination/fetch-destination-iframe.https.html: Added.
web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html: Added.
web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https-expected.txt: Added.
web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html: Added.
web-platform-tests/fetch/api/request/destination/fetch-destination.https.html: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy.es: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy.es.headers: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy.html: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy.png: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy.ttf: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy_audio.mp3: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy_audio.oga: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy_video.mp4: Added.
web-platform-tests/fetch/api/request/destination/resources/dummy_video.ogv: Added.
web-platform-tests/fetch/api/request/destination/resources/empty.https.html: Added.
web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker-iframe.js: Added.

(event.request.url.includes.):
(event.request.url.includes):

web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker-no-load-event.js: Added.

(event.request.url.includes):

web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker.js: Added.

(event.request.url.includes):

web-platform-tests/fetch/api/request/destination/resources/importer.js: Added.
web-platform-tests/fetch/api/request/destination/resources/w3c-import.log: Added.
web-platform-tests/fetch/api/request/destination/w3c-import.log: Added.

LayoutTests:

Skipping tests for WK1 since they use service worker.

TestExpectations: Skipping timing out tests.
platform/ios-wk1/TestExpectations:
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:

9:58 PM Changeset in webkit [233190] by dbates@webkit.org

2 edits in trunk/Tools

Log a message when fetching attachment data from the status server
https://bugs.webkit.org/show_bug.cgi?id=187032

Reviewed by Zalan Bujtas.

Currently we silently fetch from the status server an attachment when fetching
the attachment from Bugzilla fails due to an access denied error. Instead we
should emit a message when fetching data from the status server to indicate
that webkit-patch/EWS is still processing the command/trying to obtain the
patch.

Scripts/webkitpy/common/net/statusserver.py:

(StatusServer._fetch_attachment_page):

7:05 PM Changeset in webkit [233189] by Keith Rollin

18 edits in trunk/Source/WebCore

Adjust WEBCORE_EXPORT annotations for LTO
https://bugs.webkit.org/show_bug.cgi?id=186944
<rdar://problem/41384880>

Reviewed by David Kilzer.

Adjust a number of places that result in WebKit's
'check-for-weak-vtables-and-externals' script reporting weak external
symbols:

ERROR: WebCore has a weak external symbol in it (/Volumes/Data/dev/webkit/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
...

These cases are caused by inline methods being marked with WTF_EXPORT
(or related macro) or with an inline function being in a class marked
as such, and when enabling LTO builds.

For the most part, address these by removing the WEBCORE_EXPORT
annotation from inline methods. In some cases, move the implementation
out-of-line because it's the class that has the WEBCORE_EXPORT on it
and removing the annotation from the class would be too disruptive.
Finally, in other cases, move the implementation out-of-line because
check-for-weak-vtables-and-externals still complains when keeping the
implementation inline and removing the annotation; this seems to
typically (but not always) happen with destructors.

No new tests. There is no changed functionality. Only the annotation
and treatment of inline methods are altered.

animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::pause):

page/CacheStorageProvider.h:

(): Deleted.

page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ScrollingTree::reportExposedUnfilledArea):

platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::hasActiveNowPlayingSession const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingTitle const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingDuration const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingElapsedTime const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingInfoUniqueIdentifier const):
(WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):

platform/audio/mac/CARingBuffer.cpp:

(WebCore::CARingBuffer::~CARingBuffer):

platform/audio/mac/CARingBuffer.h:

(WebCore::CARingBuffer::~CARingBuffer): Deleted.

platform/cocoa/VideoFullscreenModelVideoElement.h:
platform/gamepad/GamepadProvider.h:
platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::displayListAsText const):
(WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayer::isTrackingDisplayListReplay const):
(WebCore::GraphicsLayer::replayDisplayListAsText const):

platform/mac/PlaybackSessionInterfaceMac.h:
platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):

platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::setActive):
(WebCore::LibWebRTCProvider::createDecoderFactory):
(WebCore::LibWebRTCProvider::createEncoderFactory):
(WebCore::LibWebRTCProvider::disableEnumeratingAllNetworkInterfaces):
(WebCore::LibWebRTCProvider::enableEnumeratingAllNetworkInterfaces):

platform/mediastream/libwebrtc/LibWebRTCProvider.h:
platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::willCacheResponseAsync):

testing/MockGamepadProvider.h:
workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::~Connection):

6:22 PM Changeset in webkit [233188] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC] Adjust static position for out-of-flow positioned boxes.
https://bugs.webkit.org/show_bug.cgi?id=187000

Reviewed by Antti Koivisto.

The static position of an out-of-flow positioned box is the the position where box would go
if it was in-flow positioned. This position needs to the resolved in the containing block's coordinate system.

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):

5:43 PM Changeset in webkit [233187] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Box Model section should have dark background
https://bugs.webkit.org/show_bug.cgi?id=186976

Reviewed by Brian Burg.

Replace all instances of black text on white background with the default text and background colors.

UserInterface/Views/BoxModelDetailsSectionRow.css:

(@media (prefers-dark-interface)):
(.details-section .row.box-model):
(.details-section .row.box-model .label):
(.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
(.details-section .row.box-model:not(.hovered) :matches(.margin, .border, .padding, .content),):
(.details-section .row.box-model .margin):
(.details-section .row.box-model .border):

5:40 PM Changeset in webkit [233186] by david_fenton@apple.com

5 edits
3 copies
1 move
2 adds
1 delete in trunk/Source/WTF

Unreviewed, rolling out r233120.

caused regression in ios API tests

Reverted changeset:

"[Cocoa] reduce unnecessary use of .mm source files in WTF,
spruce up some implementation details"
https://bugs.webkit.org/show_bug.cgi?id=186924
https://trac.webkit.org/changeset/233120

5:38 PM Changeset in webkit [233185] by david_fenton@apple.com

2 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.https.any.worker.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=187025

Unreviewed test gardening, update Test Expectations to [Pass Failure Slow]

TestExpectations:

4:56 PM Changeset in webkit [233184] by sbarati@apple.com

13 edits in trunk

JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary
https://bugs.webkit.org/show_bug.cgi?id=186878
<rdar://problem/40568659>

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch fixes a bug in our JSImmutableButterfly implementation uncovered by
our stress GC bots. Before this patch, JSImmutableButterfly was allocated
with HeapCell::Kind::Auxiliary. This is wrong. Things that are JSCells must be
allocated from HeapCell::Kind::JSCell. The way this broke on the stress GC
bots is that our conservative marking won't do cell marking for things that
are Auxiliary. This means that if the stack is the only thing pointing to a
JSImmutableButterfly when a GC took place, that JSImmutableButterfly would
not be visited. This patch fixes this bug. This patch also extends our conservative
marking to understand that there may be interior pointers to things that are HeapCell::Kind::JSCell.

bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):

heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):

runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::subspaceFor):

LayoutTests:

Make these test not susceptible to conservative scan leaks by ensuring at least
one object gets collected when we allocate many of them. Before, these were just
testing that a fixed number of objects were collected.

editing/selection/navigation-clears-editor-state-expected.txt:
editing/selection/navigation-clears-editor-state.html:
fast/dom/reference-cycle-leaks.html:
fast/misc/resources/test-observegc.js:
fast/misc/test-observegc-expected.txt:
platform/mac-wk2/plugins/refcount-leaks-expected.txt:
plugins/refcount-leaks-expected.txt:
plugins/refcount-leaks.html:

4:56 PM Changeset in webkit [233183] by beidson@apple.com

2 edits in trunk/Source/WebCore

Remove RELEASE_ASSERT added in r230875.
<rdar://problem/40860061> and https://bugs.webkit.org/show_bug.cgi?id=187022

Reviewed by Brent Fulgham.

There's actually more than one way for a network session to be destroyed, and that can happen
asynchronously and unpredictably.

And the request to start up a WebSocket and do its handshake is also asynchronous and unpredictable

It's an expected race.

If the NetworkStorageSession cannot be found then the WebSocket handshake should just fail.

platform/network/SocketStreamHandleImpl.cpp:

(WebCore::cookieDataForHandshake): If the NetworkStorageSession cannot be found, return std::nullopt.
(WebCore::SocketStreamHandleImpl::platformSendHandshake): If the cookieData is null, fail the handshake.

4:54 PM Changeset in webkit [233182] by Wenson Hsieh

4 edits in trunk/Source/WebCore

[iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News
https://bugs.webkit.org/show_bug.cgi?id=187011
<rdar://problem/40906808>

Reviewed by Tim Horton.

Disable remote media commands when running iOS WebKit on macOS. The iOS flavor of RemoteCommandListener
currently throws an exception when attempting to soft-link the MediaPlayer framework, which prevents video from
being played altogether. For a followup tracking touch bar integration in iOS WebKit on macOS, see:
<rdar://problem/39164732>.

Manually tested by playing a YouTube video in News.

platform/RemoteCommandListener.cpp:
platform/ios/RemoteCommandListenerIOS.h:
platform/ios/RemoteCommandListenerIOS.mm:

4:40 PM Changeset in webkit [233181] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

WKThumbnailView fallback background is blindingly bright in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=187017
<rdar://problem/41036209>

Reviewed by Simon Fraser.

UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:]):
(-[_WKThumbnailView wantsUpdateLayer]):
(-[_WKThumbnailView updateLayer]):
Use a semantic color for the WKThumbnailView background color
instead of flat white.

4:37 PM Changeset in webkit [233180] by wilander@apple.com

14 edits in trunk

Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback
https://bugs.webkit.org/show_bug.cgi?id=186903
<rdar://problem/41350182>

Reviewed by Chris Dumez.

Source/WebKit:

This patch stores the callback sent to
WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains(),
sets up a context ID, and sends that ID to the network process when
asking it to update cookie partitioning and blocking. The network
process then tells the UI process when it's done, at which point the
callback is called.

This change is meant to address layout test flakiness.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updatePrevalentDomainsToPartitionOrBlockCookies):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::NetworkProcessProxy::didUpdatePartitionOrBlockCookies):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):

UIProcess/WebResourceLoadStatisticsStore.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):

UIProcess/WebsiteData/WebsiteDataStore.h:

LayoutTests:

http/tests/storageAccess/grant-storage-access-under-opener-expected.txt:
http/tests/storageAccess/grant-storage-access-under-opener.html:

Moved the code block to the page's body instead of its head.
Added an initial console log statement. The reason for these
changes is that we're seeing flaky timeouts with no output.

4:07 PM Changeset in webkit [233179] by Brent Fulgham

2 edits in trunk/Source/WebKit

Allow access to APTDevice in iOS WebContent process
https://bugs.webkit.org/show_bug.cgi?id=187021
<rdar://problem/41339769>

Reviewed by Youenn Fablet.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

3:34 PM Changeset in webkit [233178] by Keith Rollin

8 edits in trunk/Source

Unreviewed, rolling out r233087.

Causes 5% Mac PLT regression.

Reverted changeset:

"Recalc styles every time defaultAppearance changes."
https://bugs.webkit.org/show_bug.cgi?id=186866
https://trac.webkit.org/changeset/233087

3:29 PM Changeset in webkit [233177] by youenn@apple.com

2 edits
1 add in trunk/Source/WebKit

Add a sandbox profile to Hangout plug-in
https://bugs.webkit.org/show_bug.cgi?id=187005
<rdar://problem/41428391>

Reviewed by Brent Fulgham.

Add a sandbox profile so that this plug-in can be run when UIProcess is sandboxed.

Resources/PlugInSandboxProfiles/com.google.googletalkbrowserplugin.sb: Added.
WebKit.xcodeproj/project.pbxproj:

2:29 PM Changeset in webkit [233176] by Brent Fulgham

3 edits in trunk/Source/WebCore

REGRESSION(r229722): WebKitLegacy clients can crash when loading alternate page
https://bugs.webkit.org/show_bug.cgi?id=187008

Reviewed by Chris Dumez.

The new call to 'clearProvisionalLoadForPolicyCheck' added in r229722 broke loading
behavior in WebKitLegacy.

We can now enter 'cancelPolicyCheckIfNeeded' without a Frame loader, in what appears to be a recursive call during the load cancellation (the 'm_waitingForContentPolicy' and 'm_waitingForNavigationPolicy' have already been nulled). It seems like we should return early here, or perhaps just move the RELEASE_ASSERT inside the case where we have an active policy check happening.

We also enter FrameLoader::checkContentPolicy without an active document loader. We should recognize this case and handle it, rather than trying to dereference a nullptr document loader.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded): Move the RELEASE_ASSERT inside the
conditional where the frameLoader is actually used.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkContentPolicy): Recognize that the activeDocumentLoader may
be nullptr at this point, and take appropriate action (rather than crashing).

2:28 PM Changeset in webkit [233175] by aakash_jain@apple.com

4 edits in trunk/Tools

[ews-build] Add support for Bindings-tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187014

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/factories.py:

(BindingsFactory): Added RunBindingsTests build step to BindingsFactory.

BuildSlaveSupport/ews-build/steps.py:

(RunBindingsTests): Added build-step for running Bindings tests.

BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

2:27 PM Changeset in webkit [233174] by Chris Dumez

2 edits in trunk/LayoutTests

performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938
<rdar://problem/41379336>

Unreviewed, skip test again as it is apparently still flaky.

TestExpectations:

2:15 PM Changeset in webkit [233173] by Simon Fraser

3 edits in trunk/Source/WebCore

MatchedPropertiesCacheItem wastes 388KB of vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186990

Reviewed by Antti Koivisto.

MatchedPropertiesCacheItem.matchedProperties was appended to, so it allocated capacity
in 16-size chunks. Instead, assign to it so it only allocates as much capacity as is needed.
Copy-constructing is more wasteful, since it copies the 64-chunk size from the right-hand side.

css/StyleResolver.cpp:

(WebCore::StyleResolver::addToMatchedPropertiesCache):

css/StyleResolver.h:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem):

2:14 PM Changeset in webkit [233172] by youenn@apple.com

3 edits
3 adds in trunk

NetworkLoadChecker should not check CORS for 304 responses triggered by WebProcess revalidation
https://bugs.webkit.org/show_bug.cgi?id=186939
<rdar://problem/40941725>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/cors/resources/cache-304.py: Added.
web-platform-tests/cors/script-304-expected.txt: Added.
web-platform-tests/cors/script-304.html: Added.

Source/WebKit:

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::validateResponse):

2:04 PM Changeset in webkit [233171] by Chris Dumez

2 edits in trunk/Source/WebCore

Null dereference crash un ApplicationCacheGroup::startLoadingEntry()
https://bugs.webkit.org/show_bug.cgi?id=187012
<rdar://problem/40793716>

Reviewed by Youenn Fablet.

m_entryLoader can be null because ApplicationCacheResourceLoader::create() return null when
CachedResourceLoader::requestRawResource() fails synchronously. In such case, the completion
handler gets called with a ApplicationCacheResourceLoader::Error::CannotRequestResource error.

To address the issue, we capture the request's URL in the lambda and use it instead of trying
to get the URL from the loader's resource.

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::startLoadingEntry):

1:31 PM Changeset in webkit [233170] by Ross Kirsling

2 edits in trunk/Source/WebCore

REGRESSION (r233140): Windows build failure due to incomplete FrameView and RenderBox types
https://bugs.webkit.org/show_bug.cgi?id=186997

animation/KeyframeEffectReadOnly.cpp:

1:30 PM Changeset in webkit [233169] by Chris Dumez

3 edits in trunk/LayoutTests

performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938
<rdar://problem/41379336>

Unreviewed, move the call to gc() inside the setInterval() so we keep
trying to gc() until the frame / document are destroyed (instead of
only doing a single garbage collection).

TestExpectations:
performance-api/performance-observer-no-document-leak.html:

1:16 PM Changeset in webkit [233168] by Keith Rollin

2 edits in trunk/Source/WebKit

Adjust UNEXPORTED_SYMBOL_LDFLAGS for LTO
https://bugs.webkit.org/show_bug.cgi?id=186949
<rdar://problem/41386438>

Reviewed by David Kilzer.

When building with LTO, WebKit's
'check-for-weak-vtables-and-externals' script reports weak external
symbols:

ERROR: WebKit has a weak external symbol in it (.../OpenSource/WebKitBuild/Release/WebKit.framework/Versions/A/WebKit)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_14basic_iostreamIcS2_EE
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE16_NS_13basic_ostreamIcS2_EE
ERROR: symbol ZTTNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
ERROR: symbol ZTVNSt3115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEEE
ERROR: symbol ZTVNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
Command /bin/sh failed with exit code 1

Address these by adding those symbols to UNEXPORTED_SYMBOL_LDFLAGS in
WebKit.xcconfig.

Configurations/WebKit.xcconfig:

1:12 PM Changeset in webkit [233167] by mark.lam@apple.com

3 edits
1 add in trunk

constructArray() should set m_numValuesInVector to the specified length.
https://bugs.webkit.org/show_bug.cgi?id=187010
<rdar://problem/41392167>

Reviewed by Filip Pizlo.

JSTests:

stress/regress-187010.js: Added.

Source/JavaScriptCore:

Its client will fill in the storage vector with some values using initializeIndex()
and expects m_numValuesInVector to be set to the length i.e. the number of values
to be initialized.

runtime/JSArray.cpp:

(JSC::constructArray):

1:00 PM Changeset in webkit [233166] by aakash_jain@apple.com

3 edits
3 adds in trunk/Tools

[ews-build] Add support for Style-EWS
https://bugs.webkit.org/show_bug.cgi?id=186955

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/factories.py:

(Factory): Base class for all the factory.

BuildSlaveSupport/ews-build/loadConfig.py: Initialize factory with required parameters.
BuildSlaveSupport/ews-build/runUnittests.py: Added, script to run all the unit tests.
BuildSlaveSupport/ews-build/steps.py: Added.
BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

12:54 PM Changeset in webkit [233165] by Chris Dumez

6 edits in trunk/Source/WebKit

Make sure API::IconLoadingClient::getLoadDecisionForIcon()'s completion handler gets called
https://bugs.webkit.org/show_bug.cgi?id=187007
<rdar://problem/41293989>

Reviewed by Brady Eidson.

Make sure API::IconLoadingClient::getLoadDecisionForIcon()'s completion handler gets called by
switching its type to WTF::CompletionHandler instead of WTF::Function. This also has the benefit
of destroying our captured objects when the completion handler gets called by the client on the
main thread instead of whatever thread the ObjC block gets released on.

UIProcess/API/APIIconLoadingClient.h:

(API::IconLoadingClient::getLoadDecisionForIcon):

UIProcess/API/glib/WebKitIconLoadingClient.cpp:
UIProcess/API/mac/WKView.mm:

(-[WKView maybeInstallIconLoadingClient]):

UIProcess/Cocoa/IconLoadingDelegate.h:
UIProcess/Cocoa/IconLoadingDelegate.mm:

(WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon):

12:24 PM Changeset in webkit [233164] by graouts@webkit.org

7 edits
1 copy
1 add in trunk

REGRESSION: hardware-accelerated animation fails on inline element
https://bugs.webkit.org/show_bug.cgi?id=186981
<rdar://problem/41418697>

Reviewed by Dean Jackson.

Source/WebCore:

Ensure we only queue accelerated actions when we have a renderer so we don't attempt
to start an accelerated animation too soon.

Test: webanimations/opacity-animation-yields-compositing-span.html

animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::updateAcceleratedAnimationState):

LayoutTests:

platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
webanimations/opacity-animation-yields-compositing-expected.txt:
webanimations/opacity-animation-yields-compositing-span-expected.txt:
webanimations/opacity-animation-yields-compositing-span.html: Added.
webanimations/opacity-animation-yields-compositing.html:

12:23 PM Changeset in webkit [233163] by ddkilzer@apple.com

3 edits in trunk/Source/WebCore

REGRESSION (r233140): v2: Windows build failure due to incomplete DocumentAnimationScheduler type
<https://webkit.org/b/186997>

dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::windowScreenDidChange):

dom/Document.h:
DocumentAnimationScheduler is behind the USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) macro, which is disabled on Windows.
This also reverts my fix in r233144 since it didn't work.

12:19 PM Changeset in webkit [233162] by youenn@apple.com

29 edits
1 copy
4 adds in trunk

Add API to control mock media devices
https://bugs.webkit.org/show_bug.cgi?id=186958

Reviewed by Eric Carlson.

Source/WebCore:

Refactor code to introduce a MockDevice structure that can be used in multiple processes.
Update mock sources and center to use MockDevice.
Add API to update mock media devices.

Make MediaDevices an ActiveDOMObject so that it does not get collected when ondevicechange is set.

Test: fast/mediastream/device-change-event-2.html

Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::stop):
(WebCore::MediaDevices::scheduledEventTimerFired):
(WebCore::MediaDevices::hasPendingActivity const):
(WebCore::MediaDevices::activeDOMObjectName const):
(WebCore::MediaDevices::canSuspendForDocumentSuspension const):

Modules/mediastream/MediaDevices.h:
Modules/mediastream/MediaDevices.idl:
WebCore.xcodeproj/project.pbxproj:
platform/mediastream/RealtimeMediaSourceCenter.h:
platform/mock/MockMediaDevice.h: Added.

(WebCore::MockMicrophoneProperties::encode const):
(WebCore::MockMicrophoneProperties::decode):
(WebCore::MockCameraProperties::encode const):
(WebCore::MockCameraProperties::decode):
(WebCore::MockDisplayProperties::encode const):
(WebCore::MockDisplayProperties::decode):
(WebCore::MockMediaDevice::isMicrophone const):
(WebCore::MockMediaDevice::isCamera const):
(WebCore::MockMediaDevice::isDisplay const):
(WebCore::MockMediaDevice::type const):
(WebCore::MockMediaDevice::encode const):
(WebCore::MockMediaDevice::decodeMockMediaDevice):
(WebCore::MockMediaDevice::decode):

platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::startProducingData):

platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::defaultDevices):
(WebCore::devices):
(WebCore::deviceMap):
(WebCore::deviceListForDevice):
(WebCore::MockRealtimeMediaSource::createCaptureDevice):
(WebCore::MockRealtimeMediaSource::resetDevices):
(WebCore::MockRealtimeMediaSource::setDevices):
(WebCore::MockRealtimeMediaSource::addDevice):
(WebCore::MockRealtimeMediaSource::removeDevice):
(WebCore::MockRealtimeMediaSource::captureDeviceWithPersistentID):
(WebCore::MockRealtimeMediaSource::audioDevices):
(WebCore::MockRealtimeMediaSource::videoDevices):
(WebCore::MockRealtimeMediaSource::displayDevices):
(WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):
(WebCore::MockRealtimeMediaSource::initializeCapabilities):
(WebCore::MockRealtimeMediaSource::initializeSettings):
(WebCore::MockRealtimeMediaSource::settings const):
(WebCore::MockRealtimeMediaSource::supportedConstraints):

platform/mock/MockRealtimeMediaSource.h:

(WebCore::MockRealtimeMediaSource::device const):

platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::singleton):
(WebCore::MockRealtimeMediaSourceCenter::setMockRealtimeMediaSourceCenterEnabled):
(WebCore::MockRealtimeMediaSourceCenter::setDevices):
(WebCore::MockRealtimeMediaSourceCenter::addDevice):
(WebCore::MockRealtimeMediaSourceCenter::removeDevice):

platform/mock/MockRealtimeMediaSourceCenter.h:
platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::initializeCapabilities):
(WebCore::MockRealtimeVideoSource::drawText):
(WebCore::MockRealtimeVideoSource::generateFrame):

platform/mock/MockRealtimeVideoSource.h:

(WebCore::MockRealtimeVideoSource::mockCamera const):
(WebCore::MockRealtimeVideoSource::mockScreen const):

Source/WebKit:

Add API to clear, set, remove and reset mock media devices.
The mock media center of UIProcess and all WebProcesses are updated.

CMakeLists.txt:
UIProcess/API/C/WKMockMediaDevice.cpp: Added.

(typeFromString):
(WKAddMockMediaDevice):
(WKClearMockMediaDevices):
(WKRemoveMockMediaDevice):
(WKResetMockMediaDevices):

UIProcess/API/C/WKMockMediaDevice.h: Added.
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::addMockMediaDevice):
(WebKit::WebProcessPool::clearMockMediaDevices):
(WebKit::WebProcessPool::removeMockMediaDevice):
(WebKit::WebProcessPool::resetMockMediaDevices):

UIProcess/WebProcessPool.h:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addMockMediaDevice):
(WebKit::WebProcess::clearMockMediaDevices):
(WebKit::WebProcess::removeMockMediaDevice):
(WebKit::WebProcess::resetMockMediaDevices):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

Tools:

Add test runner API to clear/add/remove/reset mock media devices.

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::addMockMediaDevice):
(WTR::TestRunner::addMockCameraDevice):
(WTR::TestRunner::addMockMicrophoneDevice):
(WTR::TestRunner::addMockScreenDevice):
(WTR::TestRunner::clearMockMediaDevices):
(WTR::TestRunner::removeMockMediaDevice):
(WTR::TestRunner::resetMockMediaDevices):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::addMockMediaDevice):
(WTR::TestController::clearMockMediaDevices):
(WTR::TestController::removeMockMediaDevice):
(WTR::TestController::resetMockMediaDevices):

WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

fast/mediastream/device-change-event-2-expected.txt: Added.
fast/mediastream/device-change-event-2.html: Added.

11:53 AM Changeset in webkit [233161] by mark.lam@apple.com

3 edits
1 add in trunk

Add missing exception check in RegExpObjectInlines.h's collectMatches.
https://bugs.webkit.org/show_bug.cgi?id=187006
<rdar://problem/41418412>

Reviewed by Keith Miller.

JSTests:

stress/regress-187006.js: Added.

Source/JavaScriptCore:

runtime/RegExpObjectInlines.h:

(JSC::collectMatches):

11:52 AM Changeset in webkit [233160] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] Add support for try Buildbot try schedulers
https://bugs.webkit.org/show_bug.cgi?id=186948

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/config.json: Use Try_Userpass scheduler.
BuildSlaveSupport/ews-build/loadConfig.py: Updated to use try scheduler.

11:43 AM Changeset in webkit [233159] by Wenson Hsieh

2 edits in trunk/Source/WebKit

[iPad apps on macOS] Click events are broken in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=186964
<rdar://problem/41369145>

Reviewed by Tim Horton.

Tapping in WKWebView currently does not dispatch click events to the page. This is because the long press loupe
gesture (in the text interaction assistant) has a delay of 0 when running iOS apps on macOS, but on iOS, it's
0.5. The zero delay on macOS means that the loupe gesture will be recognized before the synthetic click gesture;
this, in turn, causes the synthetic click gesture to be excluded by the loupe gesture. To address this, we
simply allow the click and loupe gesture to recognize simultaneously.

Additionally, a new hover gesture was added recently to handle macOS cursor types when hovering over selectable
text. This patch also allows other gestures to recognize alongside hover gestures, which matches macOS behavior.

We don't have the capacity to write automated tests for this yet; I manually tested text selection, editing in
some text form controls, as well as clicking on links, buttons, and other elements with click event handlers.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):

11:30 AM Changeset in webkit [233158] by commit-queue@webkit.org

6 edits in trunk/Source/JavaScriptCore

Add API for configuring the number of threads used by DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=186859
<rdar://problem/41093519>

Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-06-25
Reviewed by Filip Pizlo.

Add new private APIs for limiting the number of threads to be used by
the DFG and FTL compilers. It was already possible to configure the
limit through JSC Options, but now it can be changed at runtime, even
in the case when the VM is already running.

Add a test for both cases: when trying to configure the limit before
and after the Worklist has been created, but in order to simulate the
first scenario, we must guarantee that the test runs at the very
beginning, so I also added a check for that.

API/JSVirtualMachine.mm:

(+[JSVirtualMachine setNumberOfDFGCompilerThreads:]):
(+[JSVirtualMachine setNumberOfFTLCompilerThreads:]):

API/JSVirtualMachinePrivate.h:
API/tests/testapi.mm:

(runJITThreadLimitTests):
(testObjectiveCAPIMain):

dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::createNewThread):
(JSC::DFG::Worklist::setNumberOfThreads):

dfg/DFGWorklist.h:

10:58 AM Changeset in webkit [233157] by aboya@igalia.com

3 edits in trunk/Source/WTF

Fix ASAN_ENABLED in GCC
https://bugs.webkit.org/show_bug.cgi?id=186957

Reviewed by Michael Catanzaro.

ASAN_ENABLED used to rely on Clang-specific features for detection.
This patch enables ASAN_ENABLED to work on GCC too.

It also fixes compilation errors and warnings that were triggered when
compiling code guarded by ASAN_ENABLED in gcc.

wtf/Compiler.h:
wtf/Vector.h:

(WTF::VectorBuffer::endOfBuffer):

10:42 AM Changeset in webkit [233156] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: color outline is too dark
https://bugs.webkit.org/show_bug.cgi?id=186975

Reviewed by Brian Burg.

Make the outline lighter than the background.

UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(.hover-menu > svg > :matches(path, rect)):

10:39 AM Changeset in webkit [233155] by Keith Rollin

2 edits in trunk/Source/ThirdParty/libwebrtc

Adjust webrtc library for LTO
https://bugs.webkit.org/show_bug.cgi?id=186952
<rdar://problem/41387815>

Reviewed by Youenn Fablet.

There are a number of files in webrtc that have main() functions (in
particular, rtpcat.cc and click_annotate.cc). When compiling with LTO,
these symbols are exposed to each other, leading to the following
build failure:

Ld libwebrtc.dylib
duplicate symbol _main in:
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
BUILD FAILED

Address this by removing the indicated files from the build.

libwebrtc.xcodeproj/project.pbxproj:

10:38 AM Changeset in webkit [233154] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Media query names are unreadable
https://bugs.webkit.org/show_bug.cgi?id=186974

Reviewed by Brian Burg.

Change media query names from dark blue to light blue.

UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(.CodeMirror .CodeMirror-lines .CodeMirror-matchingbracket):
(.cm-s-default .cm-attribute):

10:35 AM Changeset in webkit [233153] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Network headers colors are too dim
https://bugs.webkit.org/show_bug.cgi?id=186985

Reviewed by Brian Burg.

Increasing the luminance of network header colors by increasing lightness and brightness.

UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(:root):

10:34 AM Changeset in webkit [233152] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Font guideline colors are too bright
https://bugs.webkit.org/show_bug.cgi?id=186986

Reviewed by Brian Burg.

Make the guidelines less distractive from the font glyphs.

UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(.content-view.resource.font .preview > .line):
(.content-view.resource.font .metric.top):
(.content-view.resource.font .metric.baseline):
(.content-view.resource.font .metric.middle):
(.content-view.resource.font .metric.xheight):
(.content-view.resource.font .metric.bottom):

9:48 AM Changeset in webkit [233151] by Ross Kirsling

2 edits in trunk/Tools

[WinCairo] Unreviewed build fix for r233088.

BuildSlaveSupport/built-product-archive:

(extractBuiltProduct):
"move" throws instead of overwriting, so just use "copy" instead.

9:31 AM Changeset in webkit [233150] by commit-queue@webkit.org

2 edits in trunk/Tools

[test262-runner] Sort the list of failing files in the HTML report
https://bugs.webkit.org/show_bug.cgi?id=186998

Patch by Leo Balter <Leo Balter> on 2018-06-25
Reviewed by Michael Saboff.

Scripts/test262/Runner.pm:

(printHTMLResults): The current list of failing files it not ordered and it's hard to read.
This small patch will sort the list.

9:22 AM Changeset in webkit [233149] by BJ Burg

2 edits in trunk/Source/WebKit

[Mac] Web Automation: include correct key code with synthesized NSEvents used for keystrokes
https://bugs.webkit.org/show_bug.cgi?id=186937

Reviewed by Timothy Hatcher.

In some cases, a missing keyCode for an ASCII letter/number can cause synthesized
NSEvents to not be converted into a key equivalent action like copy: or paste:.

UIProcess/Automation/mac/WebAutomationSessionMac.mm:

Drive by, always initialize keyCode.

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
(WebKit::keyCodeForCharKey): Compute the keyCode as defined by HLTB headers.
This only needs to be computed for characters with physical keys, excluding the
number pad and some traditional virtual keys that do not usually have glyphs.

8:57 AM Changeset in webkit [233148] by Simon Fraser

3 edits in trunk/Source/WebCore

AutoTableLayout wastes 52KB of Vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186710

Reviewed by Zalan Bujtas.

Call resizeToFit() to only allocate enough capacity for the number of columns.

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::insertSpanCell): Whitespace fix.

rendering/AutoTableLayout.h:

8:38 AM Changeset in webkit [233147] by jonlee@apple.com

10 edits in trunk/PerformanceTests

[MotionMark] Add support for version numbers
https://bugs.webkit.org/show_bug.cgi?id=186479

Reviewed by Said Abou-Hallawa.

Add support for displaying the version number as well as including it in the JSON results.

When loading the front page, script replaces any element with classname version with the
version number of the benchmark, which is stored in Strings.version.

The JSON structure for the results includes a new version property:

{

"version": "1.0",
"options": { ... },
"data": [ ... ]

}

When dragging a results file, the version listed will come from the JSON file. Older
results will not have had the version property, in which case it will default to "1.0".

MotionMark/index.html: Update title to some other default. Script will update it.

Include the version number in the logo title.

MotionMark/developer.html: Ditto.
MotionMark/about.html: Ditto.

MotionMark/resources/runner/motionmark.js:

(ResultsDashboard): Update constructor to include version. This is used when serializing
results out to JSON, and displaying the results panel in developer mode.
(ResultsDashboard._processData): When running the benchmark, include benchmark version string
in the results object.
(ResultsDashboard.version):
(window.benchmarkRunnerClient.willStartFirstIteration): When running the benchmark, pass the
benchmark version string to the dashboard, which holds the results.
(window.sectionsManager.setSectionVersion): Helper function to update the element in the
section with the class name version.
(window.benchmarkController.initialize): Populate all DOM elements with class name "version"
with the version string. Update the page title.
(window.benchmarkController.showResults): When showing results, update the version string
based on what is included in the JSON results, which would be the same as the benchmark version.

MotionMark/resources/runner/motionmark.css: Include missing copyright. Wrap the SVG logo

in a div and include the version string.

MotionMark/resources/strings.js: Add strings for the page title template, and the version.

MotionMark/resources/debug-runner/motionmark.css:
MotionMark/resources/debug-runner/motionmark.js:

(window.benchmarkRunnerClient.willStartFirstIteration): When running the benchmark, pass the
benchmark version string to the dashboard, which holds the results.
(window.benchmarkController.initialize): Populate all DOM elements with class name "version"
with the version string. Update the page title. When dragging in JSON results, look for
version to pass to the dashboard. If it doesn't exist, default to "1.0".
(window.benchmarkController.showResults): When showing results, update the version string
based on what is included in the JSON results, instead of the current benchmark version.

MotionMark/resources/debug-runner/tests.js: Update page title template.

8:15 AM Changeset in webkit [233146] by rmorisset@apple.com

5 edits in trunk/Tools

[WSL] Start writing the Sphinx document
https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

Very early work, just has the lexer and a few fragments of the parser so far.
Also fixing some minor mistake in the formal rules.

8:01 AM Changeset in webkit [233145] by Alan Bujtas

4 edits in trunk/Source/WebCore

[LFC] Adjust static position with containing block's content box top/left
https://bugs.webkit.org/show_bug.cgi?id=186999

Reviewed by Antti Koivisto.

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):

layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::contentBox const):

layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::contentBoxTop const):
(WebCore::Display::Box::contentBoxLeft const):

5:43 AM Changeset in webkit [233144] by ddkilzer@apple.com

3 edits in trunk/Source/WebCore

REGRESSION (r233140): Windows build failure due to incomplete DocumentAnimationScheduler type
<https://webkit.org/b/186997>

dom/Document.cpp:
dom/Document.h:
Attempt to fix Windows build failure by moving include of DocumentAnimationScheduler.h from Document.cpp to Document.h.

3:58 AM Changeset in webkit [233143] by Philippe Normand

2 edits in trunk/Source/WebCore

[GStreamer] Remove useless workaround
https://bugs.webkit.org/show_bug.cgi?id=186921

Reviewed by Xabier Rodriguez-Calvar.

In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
the media/video-reverse-play-duration.html test passes without any
workaround needed. The other test mentioned in that bug was
removed, it seems.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):

3:22 AM Changeset in webkit [233142] by tpopela@redhat.com

2 edits in trunk/Source/WebCore

Unreviewed, address Darin's comment
https://bugs.webkit.org/show_bug.cgi?id=186757

page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::cpuPeriod):

3:00 AM Changeset in webkit [233141] by graouts@webkit.org

7 edits in trunk

[Web Animations] Make imported/mozilla/css-animations/test_animation-pausing.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=183826
<rdar://problem/40997412>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions in the Mozilla CSS Animations tests.

css-animations/test_animation-pausing-expected.txt:

Source/WebCore:

The CSS Animations Level 2 specification defines that calling pause() on a CSSAnimation object is "sticky"
until a call to play() is made, meaning that any changes to the running state via the CSS animation-play-state
property is overridden by the stickiness of the pause() call. In this patch we add an m_stickyPaused flag which
is set in API calls to pause() and play(). While this flag is true, changes to the animation-play-state property
to the "running" value are ignored.

animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
(WebCore::CSSAnimation::bindingsPlay):
(WebCore::CSSAnimation::bindingsPause):

animation/CSSAnimation.h:

LayoutTests:

This test now passes reliably.

TestExpectations:

2:54 AM Changeset in webkit [233140] by graouts@webkit.org

12 edits
2 adds in trunk

[Web Animations] Ensure animations are updated prior to requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=186997
<rdar://problem/41419414>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions in the Mozilla CSS Animations tests.

css-animations/test_animation-pausing-expected.txt:

Source/WebCore:

Some sub-tests of imported/mozilla/css-animations/test_animation-pausing.html clearly expect that animations
would be resolved prior to firing a requestAnimationFrame() callback, as the HTML5 event loop mandates. But until
now, both DocumentTimeline and ScriptedAnimationController would make calls to DisplayRefreshMonitorManager::scheduleAnimation()
that were not coordinated and so the order in which the DocumentTimeline and ScriptedAnimationController callbacks
were performed was not guaranteed.

In this patch we add a new DocumentAnimationScheduler class which is created by a Document to manage this specific
situation. Now DocumentTimeline and ScriptedAnimationController use this supporting object instead of being their
own DisplayRefreshMonitorClient and call scheduleWebAnimationsResolution() and scheduleScriptedAnimationResolution()
respectively to indicate the need to schedule an animation through the DisplayRefreshMonitorManager to serve the specific
needs of either, or both, classes. Then DocumentAnimationScheduler ensures that Web Animations resolution happens
prior to requestAnimationFrame callbacks when both are scheduled.

In the future we should be able to move more code from DocumentTimeline and ScriptedAnimationController over to
DocumentAnimationScheduler, such as support for throttling and using a timer-based fallback, but this patch provides
the minimal functionality required to provide a sounder foundation.

Modules/webvr/VRDisplay.cpp:

(WebCore::VRDisplay::requestAnimationFrame):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
animation/DocumentAnimationScheduler.cpp: Added.

(WebCore::DocumentAnimationScheduler::create):
(WebCore::DocumentAnimationScheduler::DocumentAnimationScheduler):
(WebCore::DocumentAnimationScheduler::detachFromDocument):
(WebCore::DocumentAnimationScheduler::scheduleWebAnimationsResolution):
(WebCore::DocumentAnimationScheduler::scheduleScriptedAnimationResolution):
(WebCore::DocumentAnimationScheduler::displayRefreshFired):
(WebCore::DocumentAnimationScheduler::windowScreenDidChange):
(WebCore::DocumentAnimationScheduler::createDisplayRefreshMonitor const):

animation/DocumentAnimationScheduler.h: Copied from Source/WebCore/animation/CSSAnimation.h.
animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::create):
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::scheduleAnimationResolution):
(WebCore::DocumentTimeline::windowScreenDidChange): Deleted.
(WebCore::DocumentTimeline::createDisplayRefreshMonitor const): Deleted.

animation/DocumentTimeline.h:
dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::windowScreenDidChange):
(WebCore::Document::requestAnimationFrame):
(WebCore::Document::animationScheduler):
(WebCore::Document::timeline):

dom/Document.h:
dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::documentAnimationSchedulerDidFire):
(WebCore::ScriptedAnimationController::windowScreenDidChange): Deleted.
(WebCore::ScriptedAnimationController::displayRefreshFired): Deleted.
(WebCore::ScriptedAnimationController::createDisplayRefreshMonitor const): Deleted.

dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::create):

2:26 AM Changeset in webkit [233139] by Yusuke Suzuki

3 edits in trunk/Source/JavaScriptCore

[JSC] Remove unnecessary PLATFORM guards
https://bugs.webkit.org/show_bug.cgi?id=186995

Reviewed by Mark Lam.

assembler/AssemblerCommon.h:

(JSC::isIOS):
Add constexpr.

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
StackFrame works in all the platforms. If StackFrame::demangle failed,
it just returns std::nullopt. And it is correctly handled in this code.

12:05 AM Changeset in webkit [233138] by zandobersek@gmail.com

10 edits in trunk

Source/WebCore:
[GCrypt] Zero-prefix (if necessary) output of RSA-based encryption and signing operations
https://bugs.webkit.org/show_bug.cgi?id=186967

Reviewed by Michael Catanzaro.

Output for RSA-based encryption and signing operations should match the
length of the RSA key. The way we retrieve the MPI data means libgcrypt
can ignore the high-bit zero values and leave us with a valid result
that's shorter in length compared to the RSA key. For instance, if the
output MPI fits into 2040 bits while a 2048-bit key was used we'll end
up with MPI data that will be fitted into a 255-byte Vector, one byte
short of the expected output length.

To avoid this, mpiZeroPrefixedData() is now used when retrieving output
of these RSA operations, and the value of the key size in bytes is
passed to it. This efficiently prepares the output Vector and then
copies the MPI data into it, respecting the MPI data length as well as
the desired length of the output.

No new tests -- relevant tests are now stable (i.e. not sporadically
failing anymore), associated expectations are removed.

crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:

(WebCore::gcryptDerive): Also use mpiZeroPrefixedData().

crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):

crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):

crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):

crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::gcryptSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):

crypto/gcrypt/GCryptUtilities.h:

(WebCore::mpiZeroPrefixedData):

LayoutTests:
[GCrypt] Zero-prefix (if necessary) RSA-OAEP encryption, RSA-PSS signing output
https://bugs.webkit.org/show_bug.cgi?id=186967

Reviewed by Michael Catanzaro.

platform/gtk/TestExpectations: Remove flaky failures for RSA-OAEP and RSA-PSS tests.
platform/wpe/TestExpectations: Ditto.

Jun 24, 2018:

11:31 PM Changeset in webkit [233137] by Carlos Garcia Campos

3 edits in trunk/Source/WebDriver

Unreviewed. Fix WebDriver tests after r233077.

WebDriver process is crashing because GVariant doesn't allow to pass a nullptr array when using @ modifier.

SessionHost.h:
glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::buildSessionCapabilities const): Receive a GVariantBuilder and return true if there are
session capabilities.
(WebDriver::SessionHost::startAutomationSession): Remove the @ modifier and use a GVariantBuilder instead, or
nullptr if there aren't session capabilities.

9:40 PM Changeset in webkit [233136] by Simon Fraser

2 edits in trunk/Source/WebCore

Fix the DUMP_NODE_STATISTICS code so that it compiles
https://bugs.webkit.org/show_bug.cgi?id=186982

Reviewed by Anders Carlsson.

The DUMP_NODE_STATISTICS code had bitrotted. ENTITY_NODE no longer exists.
liveNodeSet needs to be a static function with a NeverDestroyed<>.

dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::trackForDebugging):
(WebCore::Node::~Node):

6:52 PM Changeset in webkit [233135] by Simon Fraser

3 edits
2 adds in trunk

Fix the composition underline to be transformed by -apple-color-filter
https://bugs.webkit.org/show_bug.cgi?id=186983
rdar://problem/40515558

Reviewed by Zalan Bujtas.

Source/WebCore:

Transform the composition underline color with the color filter.

Test: css3/color-filters/color-filter-composition-underline-color.html

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionUnderline const):

LayoutTests:

css3/color-filters/color-filter-composition-underline-color-expected.html: Added.
css3/color-filters/color-filter-composition-underline-color.html: Added.

12:01 PM Changeset in webkit [233134] by Yusuke Suzuki

2 edits in trunk/Source/bmalloc

[bmalloc][Linux] Remove static initializers for PerProcess<>::s_object
https://bugs.webkit.org/show_bug.cgi?id=186966

Reviewed by Anders Carlsson.

chrome/tools/linux/dump-static-initializers.py can dump static initializers
in the binary and we found that PerProcess<>::s_object initialization is done
by static initializers in GCC + Linux environments. The example is the following.

Scavenger.cpp (initializer offset 0x38c210 size 0x3e)

_GLOBALsub_I_Scavenger.cpp+0x1e
_GLOBALsub_I_Scavenger.cpp+0x2d
_GLOBALsub_I_Scavenger.cpp+0x3c
_GLOBALsub_I_Scavenger.cpp+0xf
guard variable for bmalloc::PerProcess<bmalloc::AllIsoHeaps>::s_object@@Base-0x3f0d8
guard variable for bmalloc::PerProcess<bmalloc::Environment>::s_object@@Base-0x3f0e8
guard variable for bmalloc::PerProcess<bmalloc::PerHeapKind<bmalloc::Heap> >::s_object@@Base-0x3c600
guard variable for bmalloc::PerProcess<bmalloc::Scavenger>::s_object@@Base-0x38ce8

We can remove this by initializing nullptr, which leads to constexpr initialization.
After this change, Linux JSCOnly libJavaScriptCore.so has no static initializers.

bmalloc/PerProcess.h:

9:59 AM Changeset in webkit [233133] by Michael Catanzaro

2 edits in trunk/Source/WebKit

Unreviewed, fix GTK debug build after r233131
https://bugs.webkit.org/show_bug.cgi?id=186899
<rdar://problem/38222248>

This assertion was intended to be removed.

UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):

Jun 23, 2018:

2:07 PM Changeset in webkit [233132] by Alan Bujtas

6 edits
2 adds in trunk

[Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
https://bugs.webkit.org/show_bug.cgi?id=186585
<rdar://problem/30685325>

Reviewed by Tim Horton.

Source/WebCore:

Use the existing "override viewport size for viewport units" mechanism to compute the preferred
viewport unit values for the Mail Viewer html content.

Test: fast/dynamic/mail-autosize-viewport-unit.html

page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::enableAutoSizeMode):
(WebCore::FrameView::clearViewportSizeOverrideForCSSViewportUnits):
(WebCore::FrameView::setViewportSizeForCSSViewportUnits):
(WebCore::FrameView::overrideViewportSizeForCSSViewportUnits):
(WebCore::FrameView::viewportSizeForCSSViewportUnits const):

page/FrameView.h:

LayoutTests:

fast/dynamic/mail-autosize-viewport-unit-expected.txt: Added.
fast/dynamic/mail-autosize-viewport-unit.html: Added.

12:17 PM Changeset in webkit [233131] by BJ Burg

11 edits in trunk/Source

Web Automation: key actions should support multiple pressed virtual keys
https://bugs.webkit.org/show_bug.cgi?id=186899
<rdar://problem/38222248>

Reviewed by Timothy Hatcher.

Source/WebDriver:

Adopt new protocol command argument types.

Session.cpp:

(WebDriver::Session::performActions):

Source/WebKit:

This patch changes the protocol to allow multiple virtual keys per input source state.
Chords like Cmd-Shift-A and Shift-F12 must be represented this way as they are encoded
in the VirtualKey enum rather than as an ASCII char.

UIProcess/Automation/Automation.json:
UIProcess/Automation/SimulatedInputDispatcher.h:
UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::simulateKeyboardInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::performInteractionSequence):

UIProcess/Automation/WebAutomationSession.h:
UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):

UIProcess/Automation/ios/WebAutomationSessionIOS.mm:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):

UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
Also clean up the signature of WebAutomationSession::platformSimulateKeyboardInteraction
to use a variant instead of mutually exclusive optional values with different types.

8:51 AM Changeset in webkit [233130] by pvollan@apple.com

2 edits in trunk/LayoutTests

Layout Test imported/mozilla/css-animations/test_animation-ready.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=186807

Unreviewed test gardening.

platform/win/TestExpectations:

8:48 AM Changeset in webkit [233129] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Add more debugging features to $vm.
https://bugs.webkit.org/show_bug.cgi?id=186947

Reviewed by Keith Miller.

Adding the following features:

We now have println in addition to print.
println automatically adds a '\n' at the end.
$vm.println("Hello");

We can now capture some info about a stack frame.
var currentFrame = $vm.callFrame(); Same as $vm.callFrame(0);
var callerCallerFrame = $vm.callFrame(2);

We can inspect the following values associated with the frame:
if (currentFrame.valid) {

$vm.println("name is ", currentFrame.name));

Note: For a WASM frame, all of these will be undefined.
$vm.println("callee is ", $vm.value(currentFrame.callee));
$vm.println("codeBlock is ", currentFrame.codeBlock);
$vm.println("unlinkedCodeBlock is ", currentFrame.unlinkedCodeBlock);
$vm.println("executable is ", currentFrame.executable);

}

Note that callee is a JSObject. I printed its $vm.value() because I wanted
to dataLog its JSValue instead of its toString() result.

Note that $vm.println() (and $vm.print()) can now print internal JSCells
(and Symbols) as JSValue dumps. It won't just fail on trying to do a
toString on a non-object.

Does what it says about enabling/disabling debugger mode.
$vm.enableDebuggerModeWhenIdle();
$vm.disableDebuggerModeWhenIdle();

tools/JSDollarVM.cpp:

(WTF::JSDollarVMCallFrame::JSDollarVMCallFrame):
(WTF::JSDollarVMCallFrame::createStructure):
(WTF::JSDollarVMCallFrame::create):
(WTF::JSDollarVMCallFrame::finishCreation):
(WTF::JSDollarVMCallFrame::addProperty):
(JSC::functionCallFrame):
(JSC::functionCodeBlockForFrame):
(JSC::codeBlockFromArg):
(JSC::doPrintln):
(JSC::functionPrint):
(JSC::functionPrintln):
(JSC::changeDebuggerModeWhenIdle):
(JSC::functionEnableDebuggerModeWhenIdle):
(JSC::functionDisableDebuggerModeWhenIdle):
(JSC::JSDollarVM::finishCreation):

8:30 AM Changeset in webkit [233128] by Darin Adler

4 edits in trunk/Source/WTF

[Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC
https://bugs.webkit.org/show_bug.cgi?id=186961

Reviewed by Anders Carlsson.

Configurations/Base.xcconfig: Turn on ARC.

wtf/cocoa/MemoryPressureHandlerCocoa.mm:

(WTF::MemoryPressureHandler::uninstall): Remove calls to dispatch_release.
(WTF::MemoryPressureHandler::holdOff): Ditto.

wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform): Remove call to retain.
(WTF::initializeWebThreadPlatform): Ditto.

8:30 AM Changeset in webkit [233127] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview 59

Added a tag for Safari Technology Preview release 59.

7:39 AM Changeset in webkit [233126] by Alan Bujtas

3 edits in trunk/Source/WebCore

[LFC] Relatively positioned renderer needs offsetting for validation
https://bugs.webkit.org/show_bug.cgi?id=186959

Reviewed by Antti Koivisto.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBoxInformationIfNeeded):

7:38 AM Changeset in webkit [233125] by Alan Bujtas

5 edits in trunk/Source/WebCore

[LFC] Miscellaneous fixes to fix simple absolute positioning.
https://bugs.webkit.org/show_bug.cgi?id=186962

Reviewed by Antti Koivisto.

Collect out-of-flow formatting root descendants.
Remove invalid and redundant ASSERTs invalid because the assertion is missing border, padding etc. redundant becasue we assert on geometry correctness in validateGeometryConstraintsAfterLayout.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

layout/layouttree/LayoutContainer.cpp:

(WebCore::Layout::Container::addOutOfFlowDescendant):
(WebCore::Layout::Container::setOutOfFlowDescendants): Deleted.

layout/layouttree/LayoutContainer.h:
layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createSubTree):

3:47 AM Changeset in webkit [233124] by keith_miller@apple.com

5 edits in trunk/Source/JavaScriptCore

We need to have a getDirectConcurrently for use in the compilers
https://bugs.webkit.org/show_bug.cgi?id=186954

Reviewed by Mark Lam.

It used to be that the propertyStorage of an object never shrunk
so if you called getDirect with some offset it would never be an
OOB read. However, this property storage can shrink when calling
flattenDictionaryStructure. Fortunately, flattenDictionaryStructure
holds the Structure's ConcurrentJSLock while shrinking. This patch,
adds a getDirectConcurrently that will safely try to load from the
butterfly.

bytecode/ObjectPropertyConditionSet.cpp:
bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::attemptToMakeEquivalenceWithoutBarrier const):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetConstantProperty):

runtime/JSObject.h:

(JSC::JSObject::getDirectConcurrently const):

2:59 AM Changeset in webkit [233123] by Yusuke Suzuki

19 edits in trunk/Source

[WTF] Use Ref<> for the result type of non-failing factory functions
https://bugs.webkit.org/show_bug.cgi?id=186920

Reviewed by Darin Adler.

Source/JavaScriptCore:

dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::ThreadBody::ThreadBody):
(JSC::DFG::Worklist::finishCreation):

dfg/DFGWorklist.h:
heap/Heap.cpp:

(JSC::Heap::Thread::Thread):

heap/Heap.h:
jit/JITWorklist.cpp:

(JSC::JITWorklist::Thread::Thread):

jit/JITWorklist.h:
runtime/VMTraps.cpp:
runtime/VMTraps.h:
wasm/WasmWorklist.cpp:
wasm/WasmWorklist.h:

Source/WTF:

Use Ref<> instead of RefPtr<> if the create function do not return nullptr.

wtf/AutomaticThread.cpp:

(WTF::AutomaticThreadCondition::create):
(WTF::AutomaticThread::AutomaticThread):

wtf/AutomaticThread.h:
wtf/ParallelHelperPool.cpp:

(WTF::ParallelHelperPool::Thread::Thread):

wtf/ParallelHelperPool.h:
wtf/WorkerPool.cpp:

(WTF::WorkerPool::WorkerPool):

wtf/WorkerPool.h:
wtf/win/WorkQueueWin.cpp:

(WTF::TimerContext::create):
(WTF::WorkQueue::dispatchAfter):

1:39 AM Changeset in webkit [233122] by Yusuke Suzuki

711 edits
2 copies in trunk

[WTF] Add user-defined literal for ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=186839

Reviewed by Darin Adler.

Source/JavaScriptCore:

API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::staticFunctionGetter):
(JSC::JSCallbackObject<Parent>::callbackGetter):

API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):

API/JSTypedArray.cpp:

(JSObjectGetArrayBufferBytesPtr):

API/JSValue.mm:

(valueToArray):
(valueToDictionary):

API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsFunction):
(JSC::objCCallbackFunctionCallAsConstructor):
(JSC::ObjCCallbackFunctionImpl::call):

API/glib/JSCCallbackFunction.cpp:

(JSC::JSCCallbackFunction::call):
(JSC::JSCCallbackFunction::construct):

API/glib/JSCContext.cpp:

(jscContextJSValueToGValue):

API/glib/JSCValue.cpp:

(jsc_value_object_define_property_accessor):
(jscValueFunctionCreate):

builtins/BuiltinUtils.h:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::emitIteratorNext):
(JSC::BytecodeGenerator::emitIteratorClose):
(JSC::BytecodeGenerator::emitDelegateYield):

bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallValueNode::emitBytecode):
(JSC::PostfixNode::emitBytecode):
(JSC::PrefixNode::emitBytecode):
(JSC::AssignErrorNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):
(JSC::ObjectPatternNode::bindValue const):

dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

dfg/DFGOperations.cpp:

(JSC::DFG::newTypedArrayWithSize):

dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::addToFrontend):
(Inspector::ConsoleMessage::clear):

inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findStylesheetSourceMapURL):

inspector/InjectedScript.cpp:

(Inspector::InjectedScript::InjectedScript):
(Inspector::InjectedScript::evaluate):
(Inspector::InjectedScript::callFunctionOn):
(Inspector::InjectedScript::evaluateOnCallFrame):
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapJSONString const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
(Inspector::InjectedScript::findObjectById const):
(Inspector::InjectedScript::inspectObject):
(Inspector::InjectedScript::releaseObject):
(Inspector::InjectedScript::releaseObjectGroup):

inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeEvalCall):

inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptForObjectId):

inspector/InjectedScriptModule.cpp:

(Inspector::InjectedScriptModule::ensureInjected):

inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::dispatch):
(Inspector::BackendDispatcher::sendResponse):
(Inspector::BackendDispatcher::sendPendingErrors):

inspector/JSGlobalObjectConsoleClient.cpp:

(Inspector::JSGlobalObjectConsoleClient::profile):
(Inspector::JSGlobalObjectConsoleClient::profileEnd):
(Inspector::JSGlobalObjectConsoleClient::timeStamp):

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::evaluateWithScopeExtension):
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):

inspector/JSJavaScriptCallFrame.cpp:

(Inspector::JSJavaScriptCallFrame::evaluateWithScopeExtension):
(Inspector::JSJavaScriptCallFrame::type const):

inspector/ScriptArguments.cpp:

(Inspector::ScriptArguments::getFirstArgumentAsString):

inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):

inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::InspectorAgent):

inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::InspectorConsoleAgent):
(Inspector::InspectorConsoleAgent::clearMessages):
(Inspector::InspectorConsoleAgent::count):
(Inspector::InspectorConsoleAgent::setLoggingChannelLevel):

inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::setAsyncStackTraceDepth):
(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::searchInContent):
(Inspector::InspectorDebuggerAgent::getScriptSource):
(Inspector::InspectorDebuggerAgent::getFunctionDetails):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::setPauseOnExceptions):
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::assertPaused):

inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::nodeForHeapObjectIdentifier):
(Inspector::InspectorHeapAgent::getPreview):
(Inspector::InspectorHeapAgent::getRemoteObject):

inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):
(Inspector::InspectorRuntimeAgent::getCollectionEntries):
(Inspector::InspectorRuntimeAgent::saveResult):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::InspectorRuntimeAgent::getBasicBlocks):

inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::InspectorScriptProfilerAgent):

inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::injectedScriptForEval):

inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::injectedScriptForEval):

inspector/scripts/codegen/cpp_generator_templates.py:
inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator._generate_async_dispatcher_class_for_domain):
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):

inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator):

inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:

(ObjCBackendDispatcherImplementationGenerator._generate_success_block_for_command):
(ObjCBackendDispatcherImplementationGenerator._generate_conversions_for_command):

inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:

(ObjCFrontendDispatcherImplementationGenerator._generate_event):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters):

inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:

(ObjCProtocolTypeConversionsHeaderGenerator._generate_enum_objc_to_protocol_string):

inspector/scripts/codegen/objc_generator_templates.py:
inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
inspector/scripts/tests/generic/expected/domain-availability.json-result:
inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
inspector/scripts/tests/generic/expected/enum-values.json-result:
inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
interpreter/CallFrame.cpp:

(JSC::CallFrame::friendlyFunctionName):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::functionName const):
(JSC::StackVisitor::Frame::sourceURL const):

jit/JIT.cpp:

(JSC::JIT::doMainThreadPreparationBeforeCompile):

jit/JITOperations.cpp:
jsc.cpp:

(resolvePath):
(GlobalObject::moduleLoaderImportModule):
(GlobalObject::moduleLoaderResolve):
(functionDescribeArray):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(functionDollarEvalScript):
(functionDollarAgentStart):
(functionDollarAgentReceiveBroadcast):
(functionDollarAgentBroadcast):
(functionTransferArrayBuffer):
(functionLoadModule):
(functionSamplingProfilerStackTraces):
(functionAsyncTestStart):
(functionWebAssemblyMemoryMode):
(runWithOptions):

parser/Lexer.cpp:

(JSC::Lexer<T>::invalidCharacterMessage const):
(JSC::Lexer<T>::parseString):
(JSC::Lexer<T>::parseComplexEscape):
(JSC::Lexer<T>::parseStringSlowCase):
(JSC::Lexer<T>::parseTemplateLiteral):
(JSC::Lexer<T>::lex):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):

parser/Parser.h:

(JSC::Parser::setErrorMessage):

runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::finishCreation):

runtime/ArrayBuffer.cpp:

(JSC::errorMesasgeForTransfer):

runtime/ArrayBufferSharingMode.h:

(JSC::arrayBufferSharingModeName):

runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):
(JSC::isArraySlowInline):

runtime/ArrayPrototype.cpp:

(JSC::setLength):
(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncUnShift):

runtime/AtomicsObject.cpp:

(JSC::atomicsFuncWait):
(JSC::atomicsFuncWake):

runtime/BigIntConstructor.cpp:

(JSC::BigIntConstructor::finishCreation):
(JSC::toBigInt):
(JSC::callBigIntConstructor):

runtime/BigIntObject.cpp:

(JSC::BigIntObject::toStringName):

runtime/BigIntPrototype.cpp:

(JSC::bigIntProtoFuncToString):
(JSC::bigIntProtoFuncValueOf):

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/ConsoleClient.cpp:

(JSC::ConsoleClient::printConsoleMessageWithArguments):

runtime/ConsoleObject.cpp:

(JSC::valueOrDefaultLabelString):
(JSC::consoleProtoFuncTime):
(JSC::consoleProtoFuncTimeEnd):

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::formateDateInstance):
(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToJSON):

runtime/Error.cpp:

(JSC::createNotEnoughArgumentsError):
(JSC::throwSyntaxError):
(JSC::createTypeError):
(JSC::createOutOfMemoryError):

runtime/Error.h:

(JSC::throwVMError):

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::finishCreation):

runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::sanitizedToString):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):
(JSC::errorProtoFuncToString):

runtime/ExceptionFuzz.cpp:

(JSC::doExceptionFuzzing):

runtime/ExceptionHelpers.cpp:

(JSC::TerminatedExecutionError::defaultValue):
(JSC::createStackOverflowError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

runtime/GetterSetter.cpp:

(JSC::callSetter):

runtime/IntlCollator.cpp:

(JSC::sortLocaleData):
(JSC::searchLocaleData):
(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::compareStrings):
(JSC::IntlCollator::usageString):
(JSC::IntlCollator::sensitivityString):
(JSC::IntlCollator::caseFirstString):
(JSC::IntlCollator::resolvedOptions):

runtime/IntlCollator.h:
runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructor::finishCreation):

runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototypeGetterCompare):
(JSC::IntlCollatorPrototypeFuncResolvedOptions):

runtime/IntlDateTimeFormat.cpp:

(JSC::defaultTimeZone):
(JSC::canonicalizeTimeZoneName):
(JSC::IntlDTFInternal::localeData):
(JSC::IntlDTFInternal::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::weekdayString):
(JSC::IntlDateTimeFormat::eraString):
(JSC::IntlDateTimeFormat::yearString):
(JSC::IntlDateTimeFormat::monthString):
(JSC::IntlDateTimeFormat::dayString):
(JSC::IntlDateTimeFormat::hourString):
(JSC::IntlDateTimeFormat::minuteString):
(JSC::IntlDateTimeFormat::secondString):
(JSC::IntlDateTimeFormat::timeZoneNameString):
(JSC::IntlDateTimeFormat::resolvedOptions):
(JSC::IntlDateTimeFormat::format):
(JSC::IntlDateTimeFormat::partTypeString):
(JSC::IntlDateTimeFormat::formatToParts):

runtime/IntlDateTimeFormat.h:
runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructor::finishCreation):

runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):

runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::formatNumber):
(JSC::IntlNumberFormat::styleString):
(JSC::IntlNumberFormat::currencyDisplayString):
(JSC::IntlNumberFormat::resolvedOptions):
(JSC::IntlNumberFormat::partTypeString):
(JSC::IntlNumberFormat::formatToParts):

runtime/IntlNumberFormat.h:
runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructor::finishCreation):

runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncFormatToParts):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):

runtime/IntlObject.cpp:

(JSC::grandfatheredLangTag):
(JSC::canonicalizeLocaleList):
(JSC::resolveLocale):
(JSC::supportedLocales):

runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions):
(JSC::IntlPluralRules::select):

runtime/IntlPluralRulesConstructor.cpp:

(JSC::IntlPluralRulesConstructor::finishCreation):

runtime/IntlPluralRulesPrototype.cpp:

(JSC::IntlPluralRulesPrototypeFuncSelect):
(JSC::IntlPluralRulesPrototypeFuncResolvedOptions):

runtime/IteratorOperations.cpp:

(JSC::iteratorNext):
(JSC::iteratorClose):
(JSC::hasIteratorMethod):
(JSC::iteratorMethod):

runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::appendMemcpy):
(JSC::JSArray::pop):

runtime/JSArray.h:
runtime/JSArrayBufferConstructor.cpp:

(JSC::JSArrayBufferConstructor::finishCreation):

runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice):
(JSC::arrayBufferProtoGetterFuncByteLength):
(JSC::sharedArrayBufferProtoGetterFuncByteLength):

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::toStringName):

runtime/JSArrayInlines.h:

(JSC::JSArray::pushInline):

runtime/JSBigInt.cpp:

(JSC::JSBigInt::divide):
(JSC::JSBigInt::remainder):
(JSC::JSBigInt::toNumber const):

runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):
(JSC::JSValue::putToPrimitiveByIndex):
(JSC::JSValue::toStringSlowCase const):

runtime/JSCJSValueInlines.h:

(JSC::toPreferredPrimitiveType):

runtime/JSDataView.cpp:

(JSC::JSDataView::create):
(JSC::JSDataView::put):
(JSC::JSDataView::defineOwnProperty):

runtime/JSDataViewPrototype.cpp:

(JSC::getData):
(JSC::setData):

runtime/JSFunction.cpp:

(JSC::JSFunction::callerGetter):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

runtime/JSGenericTypedArrayView.h:
runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):
(JSC::constructGenericTypedArrayView):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):

runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::speciesConstruct):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::name const):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncProtoSetter):

runtime/JSGlobalObjectFunctions.h:
runtime/JSMap.cpp:

(JSC::JSMap::toStringName):

runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::put):

runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::put):
(JSC::JSModuleNamespaceObject::putByIndex):
(JSC::JSModuleNamespaceObject::defineOwnProperty):

runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

runtime/JSObject.cpp:

(JSC::getClassPropertyNames):
(JSC::JSObject::calculatedClassName):
(JSC::ordinarySetSlow):
(JSC::JSObject::putInlineSlow):
(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::callToPrimitiveFunction):
(JSC::JSObject::ordinaryToPrimitive const):
(JSC::JSObject::defaultHasInstance):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::validateAndApplyPropertyDescriptor):

runtime/JSObject.h:
runtime/JSObjectInlines.h:

(JSC::JSObject::putInlineForJSObject):

runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::finishCreation):

runtime/JSSet.cpp:

(JSC::JSSet::toStringName):

runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):

runtime/JSTypedArrayViewConstructor.cpp:

(JSC::constructTypedArrayView):

runtime/JSTypedArrayViewPrototype.cpp:

(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoGetterFuncBuffer):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewPrivateFuncSubarrayCreate):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::JSTypedArrayViewPrototype::finishCreation):

runtime/JSWeakMap.cpp:

(JSC::JSWeakMap::toStringName):

runtime/JSWeakSet.cpp:

(JSC::JSWeakSet::toStringName):

runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::Lexer::lexStringSlow):
(JSC::LiteralParser<CharType>::Lexer::lexNumber):
(JSC::LiteralParser<CharType>::parse):

runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):

runtime/Lookup.cpp:

(JSC::reifyStaticAccessor):

runtime/Lookup.h:

(JSC::putEntry):

runtime/MapPrototype.cpp:

(JSC::getMap):

runtime/NullSetterFunction.cpp:

(JSC::NullSetterFunctionInternal::callReturnUndefined):

runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::extractToStringRadixArgument):

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSetPrototypeOf):
(JSC::objectConstructorAssign):
(JSC::objectConstructorValues):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):

runtime/Operations.cpp:

(JSC::jsAddSlowCase):

runtime/Operations.h:

(JSC::jsSub):
(JSC::jsMul):

runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

runtime/ProxyConstructor.cpp:

(JSC::makeRevocableProxy):
(JSC::proxyRevocableConstructorThrowError):
(JSC::ProxyConstructor::finishCreation):
(JSC::constructProxyObject):

runtime/ProxyObject.cpp:

(JSC::ProxyObject::toStringName):
(JSC::ProxyObject::finishCreation):
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::performPut):
(JSC::performProxyCall):
(JSC::performProxyConstruct):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performPreventExtensions):
(JSC::ProxyObject::performIsExtensible):
(JSC::ProxyObject::performDefineOwnProperty):
(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):

runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):
(JSC::reflectObjectDefineProperty):
(JSC::reflectObjectGet):
(JSC::reflectObjectGetOwnPropertyDescriptor):
(JSC::reflectObjectGetPrototypeOf):
(JSC::reflectObjectIsExtensible):
(JSC::reflectObjectOwnKeys):
(JSC::reflectObjectPreventExtensions):
(JSC::reflectObjectSet):
(JSC::reflectObjectSetPrototypeOf):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):
(JSC::toFlags):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::defineOwnProperty):

runtime/RegExpObject.h:
runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoGetterGlobal):
(JSC::regExpProtoGetterIgnoreCase):
(JSC::regExpProtoGetterMultiline):
(JSC::regExpProtoGetterDotAll):
(JSC::regExpProtoGetterSticky):
(JSC::regExpProtoGetterUnicode):
(JSC::regExpProtoGetterFlags):
(JSC::regExpProtoGetterSourceInternal):
(JSC::regExpProtoGetterSource):

runtime/RuntimeType.cpp:

(JSC::runtimeTypeAsString):

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):

runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::prepareForExecutionImpl):

runtime/SetPrototype.cpp:

(JSC::getSet):

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayEntry::put):

runtime/StackFrame.cpp:

(JSC::StackFrame::sourceURL const):
(JSC::StackFrame::functionName const):

runtime/StringConstructor.cpp:

(JSC::stringFromCodePoint):

runtime/StringObject.cpp:

(JSC::StringObject::put):
(JSC::StringObject::putByIndex):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::toLocaleCase):
(JSC::stringProtoFuncNormalize):

runtime/Symbol.cpp:

(JSC::Symbol::toNumber const):

runtime/SymbolConstructor.cpp:

(JSC::symbolConstructorKeyFor):

runtime/SymbolObject.cpp:

(JSC::SymbolObject::toStringName):

runtime/SymbolPrototype.cpp:

(JSC::SymbolPrototype::finishCreation):

runtime/TypeSet.cpp:

(JSC::TypeSet::dumpTypes const):
(JSC::TypeSet::displayName const):
(JSC::StructureShape::leastCommonAncestor):

runtime/TypeSet.h:

(JSC::StructureShape::setConstructorName):

runtime/VM.cpp:

(JSC::VM::dumpTypeProfilerData):

runtime/WeakMapPrototype.cpp:

(JSC::getWeakMap):
(JSC::protoFuncWeakMapSet):

runtime/WeakSetPrototype.cpp:

(JSC::getWeakSet):
(JSC::protoFuncWeakSetAdd):

tools/JSDollarVM.cpp:

(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterComplex::customGetter):
(JSC::functionSetImpureGetterDelegate):
(JSC::functionCreateElement):
(JSC::functionGetHiddenValue):
(JSC::functionSetHiddenValue):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionLoadGetterFromGetterSetter):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::fail const):

wasm/WasmIndexOrName.cpp:

(JSC::Wasm::makeString):

wasm/WasmParser.h:

(JSC::Wasm::FailureHelper::makeString):
(JSC::Wasm::Parser::fail const):

wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::tryRemoveContextAndCancelIfLast):

wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::fail const):

wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):

wasm/js/JSWebAssemblyHelpers.h:

(JSC::toNonWrappingUint32):
(JSC::getWasmBufferFromValue):

wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::create):

wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::grow):

wasm/js/WasmToJS.cpp:

(JSC::Wasm::handleBadI64Use):

wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::WebAssemblyCompileErrorConstructor::finishCreation):

wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):
(JSC::WebAssemblyInstanceConstructor::finishCreation):

wasm/js/WebAssemblyInstancePrototype.cpp:

(JSC::getInstance):

wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::WebAssemblyLinkErrorConstructor::finishCreation):

wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::constructJSWebAssemblyMemory):
(JSC::WebAssemblyMemoryConstructor::finishCreation):

wasm/js/WebAssemblyMemoryPrototype.cpp:

(JSC::getMemory):

wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::webAssemblyModuleCustomSections):
(JSC::webAssemblyModuleImports):
(JSC::webAssemblyModuleExports):
(JSC::WebAssemblyModuleConstructor::finishCreation):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):
(JSC::dataSegmentFail):
(JSC::WebAssemblyModuleRecord::evaluate):

wasm/js/WebAssemblyPrototype.cpp:

(JSC::resolve):
(JSC::webAssemblyInstantiateFunc):
(JSC::webAssemblyInstantiateStreamingInternal):

wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::WebAssemblyRuntimeErrorConstructor::finishCreation):

wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::constructJSWebAssemblyTable):
(JSC::WebAssemblyTableConstructor::finishCreation):

wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::getTable):
(JSC::webAssemblyTableProtoFuncGrow):
(JSC::webAssemblyTableProtoFuncGet):
(JSC::webAssemblyTableProtoFuncSet):

Source/WebCore:

No behavior change.

Modules/applicationmanifest/ApplicationManifestParser.cpp:

(WebCore::ApplicationManifestParser::parseManifest):
(WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
(WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):
(WebCore::ApplicationManifestParser::logDeveloperWarning):
(WebCore::ApplicationManifestParser::parseStartURL):
(WebCore::ApplicationManifestParser::parseDisplay):
(WebCore::ApplicationManifestParser::parseName):
(WebCore::ApplicationManifestParser::parseDescription):
(WebCore::ApplicationManifestParser::parseShortName):
(WebCore::ApplicationManifestParser::parseScope):

Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::logError):
(WebCore::NavigatorBeacon::sendBeacon):

Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::requestFromInfo):
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::put):

Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::errorToException):

Modules/credentialmanagement/BasicCredential.cpp:

(WebCore::BasicCredential::type const):

Modules/credentialmanagement/CredentialsContainer.cpp:

(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::store):
(WebCore::CredentialsContainer::isCreate):
(WebCore::CredentialsContainer::preventSilentAccess const):

Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::root):
(WebCore::validatePathIsExpectedType):
(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::getEntry):

Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::getEntry):

Modules/entriesapi/FileSystemDirectoryReader.cpp:

(WebCore::FileSystemDirectoryReader::readEntries):

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consumeAsStream):

Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::loadingFailed):

Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::consumeOnceLoadingFinished):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
(WebCore::FetchBodyOwner::blobLoadingFailed):
(WebCore::FetchBodyOwner::consumeBodyAsStream):

Modules/fetch/FetchHeaders.cpp:

(WebCore::canWriteHeader):

Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::startLoadingBlobURL):
(WebCore::FetchLoader::start):

Modules/fetch/FetchRequest.cpp:

(WebCore::setMethod):
(WebCore::computeReferrer):
(WebCore::buildOptions):
(WebCore::FetchRequest::initializeOptions):
(WebCore::FetchRequest::initializeWith):
(WebCore::FetchRequest::setBody):
(WebCore::FetchRequest::referrer const):
(WebCore::FetchRequest::clone):

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::create):
(WebCore::FetchResponse::redirect):
(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::BodyLoader::didFail):

Modules/fetch/FetchResponse.h:
Modules/geolocation/GeoNotifier.cpp:

(WebCore::GeoNotifier::timerFired):

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::requestUsesCachedPosition):
(WebCore::Geolocation::makeCachedPositionCallbacks):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::cancelRequests):
(WebCore::Geolocation::handlePendingPermissionNotifiers):

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continuePrimaryKey):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::deleteObjectStore):

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
(WebCore::IDBFactory::cmp):

Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::setName):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::doCount):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::doGet):
(WebCore::IDBIndex::getKey):
(WebCore::IDBIndex::doGetKey):
(WebCore::IDBIndex::getAll):
(WebCore::IDBIndex::getAllKeys):

Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::loggingString const):

Modules/indexeddb/IDBKeyRangeData.cpp:

(WebCore::IDBKeyRangeData::loggingString const):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::setName):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::openKeyCursor):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::getKey):
(WebCore::IDBObjectStore::putOrAdd):
(WebCore::IDBObjectStore::doDelete):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::count):
(WebCore::IDBObjectStore::doCount):
(WebCore::IDBObjectStore::getAll):
(WebCore::IDBObjectStore::getAllKeys):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::result const):
(WebCore:: const):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::putOrAddOnServer):

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::performGetAllDatabaseNames):

Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::deleteRange):
(WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getAllRecords):
(WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getCount):
(WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
(WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromEncodedFilename):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteUnusedBlobFileRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):

Modules/indexeddb/server/SQLiteIDBTransaction.cpp:

(WebCore::IDBServer::SQLiteIDBTransaction::begin):
(WebCore::IDBServer::SQLiteIDBTransaction::commit):
(WebCore::IDBServer::SQLiteIDBTransaction::abort):

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):

Modules/indexeddb/shared/IDBError.h:

(WebCore::IDBError::userDeleteError):

Modules/indexeddb/shared/IDBTransactionInfo.cpp:

(WebCore::IDBTransactionInfo::loggingString const):

Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):

Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::addIceCandidate):

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::deny):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):

Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::checkAndCanonicalizeTotal):
(WebCore::PaymentRequest::create):

Modules/quota/DOMWindowQuota.cpp:

(WebCore::DOMWindowQuota::webkitStorageInfo const):

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::channelInterpretation):

Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::MediaStreamAudioSource):

Modules/webauthn/AuthenticatorManager.cpp:

(WebCore::AuthenticatorManagerInternal::produceClientDataJson):
(WebCore::AuthenticatorManagerInternal::initTimeoutTimer):
(WebCore::AuthenticatorManager::create const):
(WebCore::AuthenticatorManager::discoverFromExternalSource const):
(WebCore::AuthenticatorManager::isUserVerifyingPlatformAuthenticatorAvailable const):

Modules/webauthn/cocoa/LocalAuthenticator.mm:

(WebCore::LocalAuthenticator::makeCredential):
(WebCore::LocalAuthenticator::getAssertion):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::usage):

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::close):
(WebCore::WebSocket::binaryType const):

Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readStatusLine):
(WebCore::WebSocketHandshake::readHTTPHeaders):
(WebCore::WebSocketHandshake::checkResponseHeaders):

Modules/webvr/VRDisplay.cpp:

(WebCore::VRDisplay::requestPresent):
(WebCore::VRDisplay::exitPresent):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
(WebCore::AccessibilityObject::invalidStatus const):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement const):

bindings/js/JSCustomElementInterface.cpp:

(WebCore::constructCustomElementSynchronously):

bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::getCustomElementCallback):
(WebCore::validateCustomElementNameAndThrowIfNeeded):
(WebCore::JSCustomElementRegistry::define):

bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

bindings/js/JSDOMConstructorBase.cpp:

(WebCore::callThrowTypeError):

bindings/js/JSDOMConstructorBase.h:

(WebCore::JSDOMConstructorBase::className):

bindings/js/JSDOMConstructorNotConstructable.h:

(WebCore::JSDOMConstructorNotConstructable::callThrowTypeError):

bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):
(WebCore::throwSequenceTypeError):
(WebCore::throwNonFiniteTypeError):

bindings/js/JSDOMIterator.h:

(WebCore::iteratorForEach):
(WebCore::IteratorTraits>::next):

bindings/js/JSDOMWindowBase.cpp:

(WebCore::isResponseCorrect):
(WebCore::handleResponseOnStreamingAction):
(WebCore::JSDOMWindowBase::compileStreaming):
(WebCore::JSDOMWindowBase::instantiateStreaming):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::preventExtensions):
(WebCore::JSDOMWindow::toStringName):

bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::preventExtensions):
(WebCore::JSLocation::toStringName):

bindings/js/JSReadableStreamPrivateConstructors.cpp:

(WebCore::constructJSReadableStreamDefaultController):
(WebCore::constructJSReadableByteStreamController):
(WebCore::constructJSReadableStreamBYOBRequest):

bindings/js/JSRemoteDOMWindowCustom.cpp:

(WebCore::JSRemoteDOMWindow::preventExtensions):
(WebCore::JSRemoteDOMWindow::toStringName):

bindings/js/ReadableStreamDefaultController.cpp:

(WebCore::ReadableStreamDefaultController::invoke):

bindings/js/ScriptModuleLoader.cpp:

(WebCore::resolveModuleSpecifier):
(WebCore::ScriptModuleLoader::resolve):
(WebCore::ScriptModuleLoader::fetch):
(WebCore::ScriptModuleLoader::evaluate):
(WebCore::ScriptModuleLoader::importModule):
(WebCore::ScriptModuleLoader::notifyFinished):

bindings/js/SerializedScriptValue.cpp:

(WebCore::maybeThrowExceptionIfSerializationFailed):

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):
(GenerateConstructorHelperMethods):
(GenerateCallTracer):

bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::JSInterfaceNameConstructor::initializeProperties):

bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::JSMapLikeConstructor::initializeProperties):

bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::JSReadOnlyMapLikeConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::JSTestCEReactionsConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::JSTestCEReactionsStringifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::JSTestCallTracerConstructor::initializeProperties):
(WebCore::jsTestCallTracerTestAttributeInterfaceGetter):
(WebCore::setJSTestCallTracerTestAttributeInterfaceSetter):
(WebCore::jsTestCallTracerTestAttributeSpecifiedGetter):
(WebCore::setJSTestCallTracerTestAttributeSpecifiedSetter):
(WebCore::jsTestCallTracerTestAttributeWithVariantGetter):
(WebCore::setJSTestCallTracerTestAttributeWithVariantSetter):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):

bindings/scripts/test/JS/JSTestCallbackInterface.cpp:

(WebCore::JSTestCallbackInterfaceConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::JSTestClassWithJSBuiltinConstructorConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestDOMJIT.cpp:

(WebCore::JSTestDOMJITConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::JSTestGlobalObjectConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestIndexedSetterNoIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::JSTestIndexedSetterThrowingExceptionConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestIndexedSetterWithIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::JSTestInterfaceConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:

(WebCore::JSTestInterfaceLeadingUnderscoreConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::JSTestIterableConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterNoIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::JSTestNamedAndIndexedSetterThrowingExceptionConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterWithIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::initializeProperties):
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::JSTestNamedDeleterNoIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::JSTestNamedDeleterThrowingExceptionConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::JSTestNamedDeleterWithIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::JSTestNamedDeleterWithIndexedGetterConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::JSTestNamedGetterCallWithConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::JSTestNamedGetterNoIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::JSTestNamedGetterWithIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedSetterNoIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::JSTestNamedSetterThrowingExceptionConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedSetterWithIdentifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterAndSetterConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:

(WebCore::JSTestNamedSetterWithOverrideBuiltinsConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:

(WebCore::JSTestNamedSetterWithUnforgablePropertiesConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:

(WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::JSTestObjConstructor::initializeProperties):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValueBody):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::JSTestOverloadedConstructorsWithSequenceConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::JSTestPluginInterfaceConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::JSTestPromiseRejectionEventConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::JSTestSerializationConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:

(WebCore::JSTestSerializationIndirectInheritanceConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestSerializationInherit.cpp:

(WebCore::JSTestSerializationInheritConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:

(WebCore::JSTestSerializationInheritFinalConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::JSTestStringifierConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::JSTestStringifierAnonymousOperationConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::JSTestStringifierNamedOperationConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::JSTestStringifierOperationImplementedAsConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::JSTestStringifierOperationNamedToStringConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::JSTestStringifierReadOnlyAttributeConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::JSTestStringifierReadWriteAttributeConstructor::initializeProperties):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::initializeProperties):

bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::stringValue const):
(JSC::Bindings::CInstance::toJSPrimitive const):

bridge/objc/objc_instance.mm:

(ObjcInstance::invokeMethod):

bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcArray::setValueAt const):

contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):

crypto/SubtleCrypto.cpp:

(WebCore::rejectWithException):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::exportKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):

crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::algorithm const):

css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::customCSSText const):

css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::customCSSText const):

css/CSSKeyframesRule.cpp:

(WebCore::CSSKeyframesRule::insertRule):

css/CSSRevertValue.cpp:

(WebCore::CSSRevertValue::customCSSText const):

css/CSSStyleSheet.h:
css/CSSUnsetValue.cpp:

(WebCore::CSSUnsetValue::customCSSText const):

css/CSSValueList.cpp:

(WebCore::CSSValueList::customCSSText const):

css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::validateAndFixup):
(WebCore::DOMMatrixReadOnly::toFloat32Array const):
(WebCore::DOMMatrixReadOnly::toFloat64Array const):
(WebCore::DOMMatrixReadOnly::toString const):

css/DeprecatedCSSOMValueList.cpp:

(WebCore::DeprecatedCSSOMValueList::cssText const):

css/FontFace.cpp:

(WebCore::FontFace::create):
(WebCore::FontFace::unicodeRange const):
(WebCore::FontFace::featureSettings const):

css/MediaQuery.cpp:

(WebCore::MediaQuery::serialize const):

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):

css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::toString const):

css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::commitMediaQuery):

dom/CDATASection.cpp:

(WebCore::CDATASection::nodeName const):

dom/Comment.cpp:

(WebCore::Comment::nodeName const):

dom/DOMException.cpp:

(WebCore::DOMException::description const):
(WebCore::DOMException::create):

dom/DOMException.h:

(WebCore::DOMException::name):
(WebCore::DOMException::message):

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createHTMLDocument):

dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer):
(WebCore::DataTransfer::types const):
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::dropEffect const):
(WebCore::DataTransfer::effectAllowed const):

dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::kind const):

dom/Document.cpp:

(WebCore::Document::suggestedMIMEType const):
(WebCore::Document::contentType const):
(WebCore::Document::nodeName const):
(WebCore::Document::writeln):
(WebCore::Document::canNavigate):
(WebCore::Document::designMode const):
(WebCore::Document::requestFullScreenForElement):

dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::nodeName const):

dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEventQuirk):

dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestModuleScript):

dom/ScriptElementCachedScriptFetcher.cpp:

(WebCore::ScriptElementCachedScriptFetcher::requestModuleScript const):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::dispatchErrorEvent):

dom/ScriptedAnimationController.cpp:

(WebCore::throttlingReasonsToString):

dom/Text.cpp:

(WebCore::Text::nodeName const):

dom/TextEncoder.cpp:

(WebCore::TextEncoder::encoding const):

dom/Traversal.cpp:

(WebCore::NodeIteratorBase::acceptNode):

editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

editing/Editing.cpp:

(WebCore::createTabSpanElement):

editing/Editor.cpp:

(WebCore::createDataTransferForClipboardEvent):

editing/EditorCommand.cpp:

(WebCore::executeInsertBacktab):
(WebCore::executeInsertLineBreak):
(WebCore::executeInsertNewline):
(WebCore::executeInsertTab):
(WebCore::executeJustifyCenter):
(WebCore::executeJustifyFull):
(WebCore::executeJustifyLeft):
(WebCore::executeJustifyRight):
(WebCore::executeStrikethrough):
(WebCore::executeSubscript):
(WebCore::executeSuperscript):
(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):
(WebCore::executeUnderline):
(WebCore::executeUnscript):
(WebCore::stateBold):
(WebCore::stateItalic):
(WebCore::stateStrikethrough):
(WebCore::stateSubscript):
(WebCore::stateSuperscript):
(WebCore::stateUnderline):
(WebCore::stateJustifyCenter):
(WebCore::stateJustifyFull):
(WebCore::stateJustifyLeft):
(WebCore::stateJustifyRight):
(WebCore::Editor::Command::value const):

editing/SmartReplace.cpp:

(WebCore::getSmartSet):

fileapi/FileCocoa.mm:

(WebCore::File::computeNameAndContentTypeForReplacedFile):

html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState const):

html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):

html/ColorInputType.cpp:

(WebCore::ColorInputType::fallbackValue const):

html/DOMFormData.cpp:

(WebCore::DOMFormData::createFileEntry):

html/FTPDirectoryDocument.cpp:

(WebCore::processFilesizeString):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::relList const):
(WebCore::HTMLAnchorElement::isSystemPreviewLink const):

html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::updateWidget):

html/HTMLCanvasElement.cpp:

(WebCore::toEncodingMimeType):
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::captureStream):

html/HTMLElement.cpp:

(WebCore::HTMLElement::contentEditable const):

html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::keytype const):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType const):
(WebCore::stringForNetworkState):
(WebCore::HTMLMediaElement::preload const):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):

html/HTMLObjectElement.cpp:

(WebCore::mapDataParamToSrc):

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::setReplacement):

html/ImageData.cpp:

(WebCore::ImageData::create):

html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

html/ImageInputType.cpp:

(WebCore::ImageInputType::appendFormData const):

html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
(WebCore::WebGL2RenderingContext::getParameter):

html/canvas/WebGLCompressedTextureASTC.cpp:

(WebCore::WebGLCompressedTextureASTC::WebGLCompressedTextureASTC):
(WebCore::WebGLCompressedTextureASTC::getSupportedProfiles):
(WebCore::WebGLCompressedTextureASTC::supported):
(WebCore::m_isLDRSupported): Deleted.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getParameter):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::enableSupportedExtension):

html/canvas/WebGLRenderingContextBase.h:
html/canvas/WebGPUEnums.cpp:

(WebCore::web3DCompareFunctionName):

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseCORSSettingsAttribute):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::initiatorFor):

html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::resourceRequest):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::insertPhoneNumberLink):

html/track/DataCue.cpp:

(WebCore::DataCue::toJSONString const):

html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::updateCueFromCueData):

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::toJSON const):

html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::toJSONString const):

html/track/TrackBase.cpp:

(WebCore::TrackBase::setLanguage):

html/track/VTTCue.cpp:

(WebCore::VTTCue::toJSON const):

inspector/CommandLineAPIModule.cpp:

(WebCore::CommandLineAPIModule::CommandLineAPIModule):

inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):

inspector/InspectorFrontendClient.h:

(WebCore::InspectorFrontendClient::debuggableType):

inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::userInterfaceLayoutDirection):
(WebCore::InspectorFrontendHost::platform):
(WebCore::InspectorFrontendHost::port):

inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::setIndicating):
(WebCore::InspectorOverlay::drawPaintRects):
(WebCore::InspectorOverlay::drawRulers):
(WebCore::appendPathSegment):

inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId):

inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createConsoleProfileData):
(WebCore::TimelineRecordFactory::createProbeSampleData):
(WebCore::TimelineRecordFactory::createEventDispatchData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createTimeStampData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):

inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::subtype):
(WebCore::jsStringForPaymentRequestState):
(WebCore::WebInjectedScriptHost::getInternalProperties):

inspector/agents/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):

inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::createStyleSheet):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):

inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::requestNode):
(WebCore::InspectorCanvasAgent::requestContent):
(WebCore::InspectorCanvasAgent::resolveCanvasContext):
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::stopRecording):
(WebCore::InspectorCanvasAgent::requestShaderSource):
(WebCore::InspectorCanvasAgent::updateShader):
(WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
(WebCore::InspectorCanvasAgent::setShaderProgramHighlighted):
(WebCore::InspectorCanvasAgent::assertInspectorCanvas):
(WebCore::InspectorCanvasAgent::assertInspectorProgram):

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::assertNode):
(WebCore::InspectorDOMAgent::assertDocument):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::requestChildNodes):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::insertAdjacentHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::setEventListenerDisabled):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::highlightSelector):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightNodeList):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::focus):
(WebCore::InspectorDOMAgent::setInspectedNode):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):

inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::domTypeName):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

inspector/agents/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::findStorageArea):

inspector/agents/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::Inspector::idbKeyRangeFromKeyRange):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::requestData):

inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

inspector/agents/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
(WebCore::InspectorNetworkAgent::getResponseBody):
(WebCore::InspectorNetworkAgent::loadResource):
(WebCore::InspectorNetworkAgent::resolveWebSocket):
(WebCore::InspectorNetworkAgent::createTextDecoder):
(WebCore::InspectorNetworkAgent::searchInRequest):

inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::navigate):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
(WebCore::InspectorPageAgent::snapshotNode):
(WebCore::InspectorPageAgent::snapshotRect):
(WebCore::InspectorPageAgent::archive):

inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::setInstruments):
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::InspectorTimelineAgent::didCompleteRecordEntry):

inspector/agents/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::initialized):
(WebCore::InspectorWorkerAgent::sendMessageToWorker):

inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::setLoggingChannelLevel):

inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::injectedScriptForEval):

inspector/agents/page/PageNetworkAgent.cpp:

(WebCore::PageNetworkAgent::scriptExecutionContext):

inspector/agents/page/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::injectedScriptForEval):

inspector/agents/worker/ServiceWorkerAgent.cpp:

(WebCore::ServiceWorkerAgent::ServiceWorkerAgent):

inspector/agents/worker/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

inspector/agents/worker/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::injectedScriptForEval):

loader/ContentFilter.cpp:

(WebCore::ContentFilter::handleProvisionalLoadFailure):

loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):
(WebCore::validatePreflightResponse):

loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::notifyFinished):
(WebCore::CrossOriginPreflightChecker::doPreflight):

loader/DocumentLoader.cpp:

(WebCore::isRemoteWebArchive):
(WebCore::DocumentLoader::startIconLoading):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::reportRedirectionWithBadScheme):
(WebCore::DocumentThreadableLoader::reportContentSecurityPolicyError):
(WebCore::DocumentThreadableLoader::reportCrossOriginResourceSharingError):
(WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):

loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::parseEncodingType):

loader/FormSubmission.h:

(WebCore::FormSubmission::Attributes::methodString):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::initForSynthesizedDocument):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::defaultSubstituteDataForURL):
(WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded):
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):

loader/LinkLoader.cpp:

(WebCore::LinkLoader::preconnectIfNeeded):

loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::scheduleLocationChange):

loader/PingLoader.cpp:

(WebCore::PingLoader::sendViolationReport):

loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::primaryDomain):
(WebCore::ResourceLoadStatistics::areDomainsAssociated):

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::didBlockAuthenticationChallenge):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):

loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::logError):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::createFileURL):

loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

loader/archive/ArchiveFactory.cpp:

(WebCore::createArchiveMIMETypesMap):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

loader/cache/CachedResourceRequest.cpp:

(WebCore::acceptHeaderValueFromType):
(WebCore::CachedResourceRequest::updateAcceptEncodingHeader):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getOriginsWithCache):

loader/soup/ResourceLoaderSoup.cpp:

(WebCore::ResourceLoader::loadGResource):

page/DOMSelection.cpp:

(WebCore::DOMSelection::type const):

page/DOMWindow.cpp:

(WebCore::DOMWindow::close):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::createWindow):

page/DebugPageOverlays.cpp:

(WebCore::touchEventRegionColors):

page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::memoryCacheEntryDecisionKey):
(WebCore::DiagnosticLoggingKeys::memoryCacheUsageKey):
(WebCore::DiagnosticLoggingKeys::missingValidatorFieldsKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::postPageBackgroundingCPUUsageKey):
(WebCore::DiagnosticLoggingKeys::postPageBackgroundingMemoryUsageKey):
(WebCore::DiagnosticLoggingKeys::pageHandlesWebGLContextLossKey):
(WebCore::DiagnosticLoggingKeys::postPageLoadCPUUsageKey):
(WebCore::DiagnosticLoggingKeys::postPageLoadMemoryUsageKey):
(WebCore::DiagnosticLoggingKeys::provisionalLoadKey):
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageLoadedKey):
(WebCore::DiagnosticLoggingKeys::playedKey):
(WebCore::DiagnosticLoggingKeys::engineFailedToLoadKey):
(WebCore::DiagnosticLoggingKeys::entryRightlyNotWarmedUpKey):
(WebCore::DiagnosticLoggingKeys::entryWronglyNotWarmedUpKey):
(WebCore::DiagnosticLoggingKeys::navigationKey):
(WebCore::DiagnosticLoggingKeys::needsRevalidationKey):
(WebCore::DiagnosticLoggingKeys::networkCacheKey):
(WebCore::DiagnosticLoggingKeys::networkCacheFailureReasonKey):
(WebCore::DiagnosticLoggingKeys::networkCacheUnusedReasonKey):
(WebCore::DiagnosticLoggingKeys::networkCacheReuseFailureKey):
(WebCore::DiagnosticLoggingKeys::networkKey):
(WebCore::DiagnosticLoggingKeys::networkProcessCrashedKey):
(WebCore::DiagnosticLoggingKeys::neverSeenBeforeKey):
(WebCore::DiagnosticLoggingKeys::noKey):
(WebCore::DiagnosticLoggingKeys::noCacheKey):
(WebCore::DiagnosticLoggingKeys::noStoreKey):
(WebCore::DiagnosticLoggingKeys::nonVisibleStateKey):
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::pageCacheKey):
(WebCore::DiagnosticLoggingKeys::pageCacheFailureKey):
(WebCore::DiagnosticLoggingKeys::noDocumentLoaderKey):
(WebCore::DiagnosticLoggingKeys::noLongerInCacheKey):
(WebCore::DiagnosticLoggingKeys::otherKey):
(WebCore::DiagnosticLoggingKeys::mainDocumentErrorKey):
(WebCore::DiagnosticLoggingKeys::mainResourceKey):
(WebCore::DiagnosticLoggingKeys::isErrorPageKey):
(WebCore::DiagnosticLoggingKeys::isExpiredKey):
(WebCore::DiagnosticLoggingKeys::isReloadIgnoringCacheDataKey):
(WebCore::DiagnosticLoggingKeys::loadingKey):
(WebCore::DiagnosticLoggingKeys::hasPluginsKey):
(WebCore::DiagnosticLoggingKeys::httpsNoStoreKey):
(WebCore::DiagnosticLoggingKeys::imageKey):
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::inactiveKey):
(WebCore::DiagnosticLoggingKeys::internalErrorKey):
(WebCore::DiagnosticLoggingKeys::invalidSessionIDKey):
(WebCore::DiagnosticLoggingKeys::isAttachmentKey):
(WebCore::DiagnosticLoggingKeys::isConditionalRequestKey):
(WebCore::DiagnosticLoggingKeys::isDisabledKey):
(WebCore::DiagnosticLoggingKeys::noCurrentHistoryItemKey):
(WebCore::DiagnosticLoggingKeys::quirkRedirectComingKey):
(WebCore::DiagnosticLoggingKeys::rawKey):
(WebCore::DiagnosticLoggingKeys::redirectKey):
(WebCore::DiagnosticLoggingKeys::isLoadingKey):
(WebCore::DiagnosticLoggingKeys::documentLoaderStoppingKey):
(WebCore::DiagnosticLoggingKeys::domainCausingCrashKey):
(WebCore::DiagnosticLoggingKeys::domainCausingEnergyDrainKey):
(WebCore::DiagnosticLoggingKeys::domainCausingJetsamKey):
(WebCore::DiagnosticLoggingKeys::simulatedPageCrashKey):
(WebCore::DiagnosticLoggingKeys::exceededActiveMemoryLimitKey):
(WebCore::DiagnosticLoggingKeys::exceededInactiveMemoryLimitKey):
(WebCore::DiagnosticLoggingKeys::exceededBackgroundCPULimitKey):
(WebCore::DiagnosticLoggingKeys::domainVisitedKey):
(WebCore::DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey):
(WebCore::DiagnosticLoggingKeys::cpuUsageKey):
(WebCore::DiagnosticLoggingKeys::createSharedBufferFailedKey):
(WebCore::DiagnosticLoggingKeys::activeInForegroundTabKey):
(WebCore::DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey):
(WebCore::DiagnosticLoggingKeys::applicationCacheKey):
(WebCore::DiagnosticLoggingKeys::applicationManifestKey):
(WebCore::DiagnosticLoggingKeys::audioKey):
(WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey):
(WebCore::DiagnosticLoggingKeys::canCacheKey):
(WebCore::DiagnosticLoggingKeys::cacheControlNoStoreKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationReasonKey):
(WebCore::DiagnosticLoggingKeys::deniedByClientKey):
(WebCore::DiagnosticLoggingKeys::deviceMotionKey):
(WebCore::DiagnosticLoggingKeys::deviceOrientationKey):
(WebCore::DiagnosticLoggingKeys::diskCacheKey):
(WebCore::DiagnosticLoggingKeys::diskCacheAfterValidationKey):
(WebCore::DiagnosticLoggingKeys::reloadKey):
(WebCore::DiagnosticLoggingKeys::replaceKey):
(WebCore::DiagnosticLoggingKeys::retrievalRequestKey):
(WebCore::DiagnosticLoggingKeys::resourceLoadedKey):
(WebCore::DiagnosticLoggingKeys::resourceResponseSourceKey):
(WebCore::DiagnosticLoggingKeys::retrievalKey):
(WebCore::DiagnosticLoggingKeys::revalidatingKey):
(WebCore::DiagnosticLoggingKeys::reloadFromOriginKey):
(WebCore::DiagnosticLoggingKeys::reloadRevalidatingExpiredKey):
(WebCore::DiagnosticLoggingKeys::sameLoadKey):
(WebCore::DiagnosticLoggingKeys::scriptKey):
(WebCore::DiagnosticLoggingKeys::serviceWorkerKey):
(WebCore::DiagnosticLoggingKeys::streamingMedia):
(WebCore::DiagnosticLoggingKeys::styleSheetKey):
(WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithRevalidationKey):
(WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithoutRevalidationKey):
(WebCore::DiagnosticLoggingKeys::svgDocumentKey):
(WebCore::DiagnosticLoggingKeys::synchronousMessageFailedKey):
(WebCore::DiagnosticLoggingKeys::telemetryPageLoadKey):
(WebCore::DiagnosticLoggingKeys::timedOutKey):
(WebCore::DiagnosticLoggingKeys::canceledLessThan2SecondsKey):
(WebCore::DiagnosticLoggingKeys::canceledLessThan5SecondsKey):
(WebCore::DiagnosticLoggingKeys::canceledLessThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::canceledMoreThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedLessThan2SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedLessThan5SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedLessThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedMoreThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::occurredKey):
(WebCore::DiagnosticLoggingKeys::succeededLessThan2SecondsKey):
(WebCore::DiagnosticLoggingKeys::succeededLessThan5SecondsKey):
(WebCore::DiagnosticLoggingKeys::succeededLessThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::succeededMoreThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::uncacheableStatusCodeKey):
(WebCore::DiagnosticLoggingKeys::underMemoryPressureKey):
(WebCore::DiagnosticLoggingKeys::unknownEntryRequestKey):
(WebCore::DiagnosticLoggingKeys::unlikelyToReuseKey):
(WebCore::DiagnosticLoggingKeys::unsupportedHTTPMethodKey):
(WebCore::DiagnosticLoggingKeys::unsuspendableDOMObjectKey):
(WebCore::DiagnosticLoggingKeys::unusedKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
(WebCore::DiagnosticLoggingKeys::usedKey):
(WebCore::DiagnosticLoggingKeys::userZoomActionKey):
(WebCore::DiagnosticLoggingKeys::varyingHeaderMismatchKey):
(WebCore::DiagnosticLoggingKeys::videoKey):
(WebCore::DiagnosticLoggingKeys::visibleNonActiveStateKey):
(WebCore::DiagnosticLoggingKeys::visibleAndActiveStateKey):
(WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithRevalidationKey):
(WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithoutRevalidationKey):
(WebCore::DiagnosticLoggingKeys::webViewKey):
(WebCore::DiagnosticLoggingKeys::yesKey):
(WebCore::DiagnosticLoggingKeys::expiredKey):
(WebCore::DiagnosticLoggingKeys::fontKey):
(WebCore::DiagnosticLoggingKeys::prunedDueToMemoryPressureKey):
(WebCore::DiagnosticLoggingKeys::prunedDueToMaxSizeReached):
(WebCore::DiagnosticLoggingKeys::prunedDueToProcessSuspended):
(WebCore::WebCore::DiagnosticLoggingKeys::notHTTPFamilyKey):
(WebCore::WebCore::DiagnosticLoggingKeys::webGLStateKey):
(WebCore::DiagnosticLoggingKeys::memoryUsageToDiagnosticLoggingKey):
(WebCore::DiagnosticLoggingKeys::foregroundCPUUsageToDiagnosticLoggingKey):
(WebCore::DiagnosticLoggingKeys::backgroundCPUUsageToDiagnosticLoggingKey):
(WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey):

page/DisabledAdaptations.cpp:

(WebCore::watchAdaptationName):

page/EventHandler.cpp:

(WebCore::EventHandler::handlePasteGlobalSelection):
(WebCore::convertDragOperationToDropZoneOperation):

page/EventSource.cpp:

(WebCore::EventSource::EventSource):

page/History.cpp:

(WebCore::History::stateObjectAdded):

page/NavigatorBase.cpp:

(WebCore::NavigatorBase::appName):
(WebCore::NavigatorBase::appCodeName):

page/Page.cpp:

(WebCore::Page::logNavigation):

page/PageDebuggable.cpp:

(WebCore::PageDebuggable::url const):

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

page/PerformanceMark.h:
page/PerformanceMeasure.h:
page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::observe):

page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):

page/PerformanceUserTiming.cpp:

(WebCore::restrictedMarkFunction):

page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty):

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toString const):

page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::toString const):
(WebCore::SecurityOriginData::databaseIdentifier const):

page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::gcTimerString):

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective const):

page/linux/ResourceUsageOverlayLinux.cpp:

(WebCore::cpuUsageString):
(WebCore::gcTimerString):

platform/ContentType.cpp:

(WebCore::ContentType::codecsParameter):
(WebCore::ContentType::profilesParameter):

platform/Decimal.cpp:

(WebCore::Decimal::toString const):

platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::typesForCommonExtension):
(WebCore::initializeUnsupportedTextMIMETypes):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

platform/SchemeRegistry.cpp:

(WebCore::SchemeRegistry::canServiceWorkersHandleURLScheme):

platform/URL.cpp:

(WebCore::mimeTypeFromDataURL):

platform/UserAgentQuirks.cpp:

(WebCore::UserAgentQuirks::stringForQuirk):

platform/cocoa/KeyEventCocoa.mm:

(WebCore::keyForCharCode):

platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::unblockHandler const):

platform/cocoa/ParentalControlsContentFilter.mm:

(WebCore::ParentalControlsContentFilter::unblockHandler const):

platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::fileContentState):

platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::MacApplication::isSafari):
(WebCore::MacApplication::isAppleMail):
(WebCore::MacApplication::isIBooks):
(WebCore::MacApplication::isITunes):
(WebCore::MacApplication::isMicrosoftMessenger):
(WebCore::MacApplication::isAdobeInstaller):
(WebCore::MacApplication::isAOLInstantMessenger):
(WebCore::MacApplication::isMicrosoftMyDay):
(WebCore::MacApplication::isMicrosoftOutlook):
(WebCore::MacApplication::isQuickenEssentials):
(WebCore::MacApplication::isAperture):
(WebCore::MacApplication::isVersions):
(WebCore::MacApplication::isHRBlock):
(WebCore::MacApplication::isIAdProducer):
(WebCore::MacApplication::isSolidStateNetworksDownloader):
(WebCore::IOSApplication::isMobileMail):
(WebCore::IOSApplication::isMobileSafari):
(WebCore::IOSApplication::isWebBookmarksD):
(WebCore::IOSApplication::isDumpRenderTree):
(WebCore::IOSApplication::isMobileStore):
(WebCore::IOSApplication::isSpringBoard):
(WebCore::IOSApplication::isWebApp):
(WebCore::IOSApplication::isIBooks):
(WebCore::IOSApplication::isIBooksStorytime):
(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
(WebCore::IOSApplication::isCardiogram):
(WebCore::IOSApplication::isNike):

platform/cocoa/UserAgentCocoa.mm:

(WebCore::userAgentBundleVersion):

platform/gamepad/cocoa/GameControllerGamepad.mm:

(WebCore::GameControllerGamepad::setupAsExtendedGamepad):
(WebCore::GameControllerGamepad::setupAsGamepad):

platform/graphics/InbandTextTrackPrivateClient.h:

(WebCore::GenericCueData::toJSONString const):

platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::isEqual):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::keySystem const):

platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):

platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::generateKeyRequest):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::propertyIdToString):

platform/graphics/ca/TileController.cpp:

(WebCore::TileController::tileGridContainerLayerName):
(WebCore::TileController::zoomedOutTileGridContainerLayerName):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL const):
(WebCore::dataURL):

platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::initializeContextObjects):
(WebCore::VideoTextureCopierCV::initializeUVContextObjects):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):

platform/graphics/iso/ISOVTTCue.cpp:

(WebCore::ISOWebVTTCue::toJSONString const):

platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:

(Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):

platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):

platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getUnmangledInfoLog):

platform/graphics/texmap/TextureMapperContextAttributes.cpp:

(WebCore::TextureMapperContextAttributes::get):

platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::toDataURL const):
(WebCore::ImageDataToDataURL):

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::typesForLegacyUnsafeBindings):

platform/gtk/PasteboardHelper.cpp:
platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::keyValueForGdkKeyCode):
(WebCore::PlatformKeyboardEvent::keyCodeForHardwareKeyCode):

platform/image-decoders/bmp/BMPImageDecoder.h:
platform/image-decoders/gif/GIFImageDecoder.h:
platform/image-decoders/ico/ICOImageDecoder.h:
platform/image-decoders/jpeg/JPEGImageDecoder.h:
platform/image-decoders/png/PNGImageDecoder.h:
platform/image-decoders/webp/WEBPImageDecoder.h:
platform/ios/Device.cpp:

(WebCore::deviceName):

platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::keyForKeyEvent):
(WebCore::codeForKeyEvent):

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::read):
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyForKeyEvent):
(WebCore::codeForKeyEvent):

platform/mac/PlatformPasteboardMac.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):

platform/mediastream/MediaConstraints.cpp:

(WebCore::addDefaultVideoConstraints):

platform/mediastream/PeerMediaDescription.h:
platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::applyConstraints):

platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:

(WebCore::DisplayCaptureManagerCocoa::screenCaptureDeviceWithPersistentID):

platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::deviceMap):
(WebCore::MockRealtimeMediaSource::audioDevices):
(WebCore::MockRealtimeMediaSource::videoDevices):
(WebCore::MockRealtimeMediaSource::displayDevices):

platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::drawText):

platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):

platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::parseMediaType):

platform/network/FormData.cpp:

(WebCore::FormData::appendMultiPartFileValue):

platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPRequestLine):
(WebCore::parseHTTPHeader):
(WebCore::normalizeHTTPMethod):

platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::redirectedRequest const):

platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::handleDataURL):

platform/network/curl/SynchronousLoaderClientCurl.cpp:

(WebCore::SynchronousLoaderClient::platformBadResponseError):

platform/network/win/DownloadBundleWin.cpp:

(WebCore::DownloadBundle::fileExtension):

platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::setFullsync):
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::pageSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::clearAllTables):
(WebCore::SQLiteDatabase::runVacuumCommand):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::deleteDatabaseFile):

platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::dateFormat):
(WebCore::getFormatForSkeleton):

platform/text/LocaleNone.cpp:

(WebCore::LocaleNone::dateFormat):
(WebCore::LocaleNone::monthFormat):
(WebCore::LocaleNone::shortMonthFormat):
(WebCore::LocaleNone::timeFormat):
(WebCore::LocaleNone::shortTimeFormat):
(WebCore::LocaleNone::dateTimeFormatWithSeconds):
(WebCore::LocaleNone::dateTimeFormatWithoutSeconds):

platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

platform/text/TextEncodingRegistry.cpp:

(WebCore::defaultTextEncodingNameForSystemLanguage):

platform/win/FileSystemWin.cpp:

(WebCore::FileSystem::bundleName):

platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderThemeWPE::mediaControlsStyleSheet):

rendering/RenderMenuList.cpp:

(RenderMenuList::setText):

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::extraDefaultStyleSheet):

svg/SVGComponentTransferFunctionElement.h:

(WebCore::SVGPropertyTraits<ComponentTransferType>::toString):

svg/SVGFEColorMatrixElement.h:

(WebCore::SVGPropertyTraits<ColorMatrixType>::toString):

svg/SVGFECompositeElement.h:

(WebCore::SVGPropertyTraits<CompositeOperationType>::toString):

svg/SVGFEConvolveMatrixElement.h:

(WebCore::SVGPropertyTraits<EdgeModeType>::toString):

svg/SVGFEDisplacementMapElement.h:

(WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):

svg/SVGFEMorphologyElement.h:

(WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):

svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):

svg/SVGGradientElement.h:

(WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):

svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

svg/SVGMarkerTypes.h:

(WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):

svg/SVGMatrixValue.h:
svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::parseAttribute):

svg/SVGTextContentElement.h:

(WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):

svg/SVGTextPathElement.h:

(WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):

svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendCFFTable):

svg/SVGUnitTypes.h:

(WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::toClipPath):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::filenameExtension const):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::userInterfaceDirectionPolicy):
(WebCore::InternalSettings::systemLayoutDirection):

testing/Internals.cpp:

(WebCore::Internals::areSVGAnimationsPaused const):
(WebCore::Internals::accessKeyModifiers const):
(WebCore::Internals::setMediaDeviceState):
(WebCore::Internals::audioSessionCategory const):
(WebCore::Internals::systemPreviewRelType):

testing/MockCDMFactory.cpp:

(WebCore::MockCDM::sanitizeResponse const):
(WebCore::MockCDMInstance::updateLicense):

testing/MockContentFilter.cpp:

(WebCore::MockContentFilter::unblockRequestDeniedScript const):

testing/MockCredentialsMessenger.cpp:

(WebCore::MockCredentialsMessenger::~MockCredentialsMessenger):
(WebCore::MockCredentialsMessenger::makeCredential):
(WebCore::MockCredentialsMessenger::getAssertion):

testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::showPaymentUI):

workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::debuggerMode):

workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::createResourceRequest):
(WebCore::WorkerScriptLoader::didReceiveData):

workers/service/ExtendableEvent.cpp:

(WebCore::ExtendableEvent::waitUntil):

workers/service/FetchEvent.cpp:

(WebCore::FetchEvent::~FetchEvent):
(WebCore::FetchEvent::respondWith):
(WebCore::FetchEvent::promiseIsSettled):

workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::clearPendingJobs):

workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::openWindow):
(WebCore::ServiceWorkerClients::claim):

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):

workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):

workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):

workers/service/ServiceWorkerWindowClient.cpp:

(WebCore::ServiceWorkerWindowClient::focus):
(WebCore::ServiceWorkerWindowClient::navigate):

workers/service/context/ServiceWorkerDebuggable.h:
workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::doPushChanges):
(WebCore::RegistrationDatabase::importRecords):

workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::runRegisterJob):
(WebCore::SWServerJobQueue::runUnregisterJob):
(WebCore::SWServerJobQueue::runUpdateJob):

xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::responseMIMEType const):

xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

xml/XPathPredicate.cpp:

(WebCore::XPath::evaluatePredicate):

xml/XPathValue.cpp:

(WebCore::XPath::Value::toString const):

xml/parser/CharacterReferenceParserInlines.h:

(WebCore::consumeCharacterReference):

Source/WebCore/PAL:

pal/unix/LoggingUnix.cpp:

(PAL::logLevelString):

Source/WebDriver:

CommandResult.cpp:

(WebDriver::CommandResult::errorString const):

Session.cpp:

(WebDriver::Session::webElementIdentifier):
(WebDriver::Session::getTimeouts):
(WebDriver::Session::createTopLevelBrowsingContext):
(WebDriver::Session::handleUserPrompts):
(WebDriver::Session::reportUnexpectedAlertOpen):
(WebDriver::Session::go):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::getTitle):
(WebDriver::Session::getWindowHandle):
(WebDriver::Session::closeTopLevelBrowsingContext):
(WebDriver::Session::switchToWindow):
(WebDriver::Session::getWindowHandles):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::getToplevelBrowsingContextRect):
(WebDriver::Session::setWindowRect):
(WebDriver::Session::maximizeWindow):
(WebDriver::Session::minimizeWindow):
(WebDriver::Session::fullscreenWindow):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::getActiveElement):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::getElementProperty):
(WebDriver::Session::getElementCSSValue):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::selectOptionElement):
(WebDriver::Session::elementClear):
(WebDriver::Session::virtualKeyForKeySequence):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::executeScript):
(WebDriver::mouseButtonForAutomation):
(WebDriver::Session::performMouseInteraction):
(WebDriver::Session::performKeyboardInteractions):
(WebDriver::parseAutomationCookie):
(WebDriver::builtAutomationCookie):
(WebDriver::serializeCookie):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::performActions):
(WebDriver::Session::releaseActions):
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
(WebDriver::Session::takeScreenshot):

SessionHost.cpp:

(WebDriver::SessionHost::dispatchMessage):

WebDriverService.cpp:

(WebDriver::WebDriverService::sendResponse const):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::findSessionOrCompleteWithError):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):
(WebDriver::WebDriverService::createSession):
(WebDriver::WebDriverService::deleteSession):
(WebDriver::WebDriverService::status):
(WebDriver::WebDriverService::go):
(WebDriver::WebDriverService::setWindowRect):
(WebDriver::WebDriverService::switchToWindow):
(WebDriver::WebDriverService::switchToFrame):
(WebDriver::findElementOrCompleteWithError):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::WebDriverService::getElementAttribute):
(WebDriver::WebDriverService::getElementProperty):
(WebDriver::WebDriverService::getElementCSSValue):
(WebDriver::WebDriverService::elementSendKeys):
(WebDriver::findScriptAndArgumentsOrCompleteWithError):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::processPauseAction):
(WebDriver::processNullAction):
(WebDriver::processKeyAction):
(WebDriver::processPointerAction):
(WebDriver::processPointerParameters):
(WebDriver::processInputActionSequence):
(WebDriver::WebDriverService::performActions):
(WebDriver::WebDriverService::sendAlertText):
(WebDriver::WebDriverService::takeElementScreenshot):

glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::sendMessageToBackend):

gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

Source/WebKit:

NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):

NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::suggestedFilename const):

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::checkRequest):

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::continueWillSendRequest):

NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::timeoutTimerFired):

NetworkProcess/PreconnectTask.cpp:

(WebKit::PreconnectTask::PreconnectTask):

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::initialize):

NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::toRecordInformation):

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesListFilename):
(WebKit::CacheStorage::cachesOriginFilename):

NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::bootstrapFromNetworkCache):
(WebKit::NetworkCache::Statistics::queryWasEverRequested):
(WebKit::NetworkCache::Statistics::clear):
(WebKit::NetworkCache::Statistics::addHashesToDatabase):
(WebKit::NetworkCache::Statistics::addStoreDecisionsToDatabase):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):

Shared/Plugins/Netscape/PluginInformation.cpp:

(WebKit::pluginInformationBundleIdentifierKey):
(WebKit::pluginInformationBundleVersionKey):
(WebKit::pluginInformationBundleShortVersionKey):
(WebKit::pluginInformationPathKey):
(WebKit::pluginInformationDisplayNameKey):
(WebKit::pluginInformationDefaultLoadPolicyKey):
(WebKit::pluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WebKit::pluginInformationHasSandboxProfileKey):
(WebKit::pluginInformationFrameURLKey):
(WebKit::pluginInformationMIMETypeKey):
(WebKit::pluginInformationPageURLKey):
(WebKit::pluginInformationPluginspageAttributeURLKey):
(WebKit::pluginInformationPluginURLKey):
(WebKit::plugInInformationReplacementObscuredKey):

Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

Shared/linux/WebMemorySamplerLinux.cpp:

(WebKit::WebMemorySampler::sampleWebKit const):

UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(debuggableTypeString):

UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_preferred_languages):

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::performInteractionSequence):

UIProcess/Automation/WebAutomationSession.h:
UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::getLaunchOptions):

UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::didStart):

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::selectorExceptionMap):

UIProcess/CredentialManagement/WebCredentialsMessengerProxy.cpp:

(WebKit::WebCredentialsMessengerProxy::makeCredential):
(WebKit::WebCredentialsMessengerProxy::getAssertion):

UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::pluginsDirectories):

UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk):

UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::getLaunchOptions):
(WebKit::ServiceWorkerProcessProxy::didReceiveAuthenticationChallenge):

UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::willCreateMediaStream):
(WebKit::UserMediaProcessManager::endedCaptureSession):

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::goToItem):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):

UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):

UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::notifyPages):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView copyForWebView:]):
(-[WKContentView cutForWebView:]):
(-[WKContentView pasteForWebView:]):
(-[WKContentView selectAllForWebView:]):
(-[WKContentView deleteBackward]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):

UIProcess/ios/WKLegacyPDFView.mm:

(-[WKLegacyPDFView _URLForLinkAnnotation:]):

WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::elementForNodeHandle):
(WebKit::WebAutomationSessionProxy::didClearWindowObjectForFrame):
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::connectionToServerLost):

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:

(webkit_dom_document_get_ready_state):

WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::uniqueWorldName):

WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::WebMediaKeyStorageManager::getMediaKeyOrigins):

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::pluginInfo):

WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::validateResponse):
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::showPaintRect):

WebProcess/WebPage/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::initialize):
(WebKit::RemoteWebInspectorUI::didSave):
(WebKit::RemoteWebInspectorUI::didAppend):
(WebKit::RemoteWebInspectorUI::frontendLoaded):

WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::openInNewTab):

WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::setDockingUnavailable):
(WebKit::WebInspectorUI::setIsVisible):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showTimelines):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::startElementSelection):
(WebKit::WebInspectorUI::stopElementSelection):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadStringImpl):
(WebKit::WebPage::loadAlternateHTMLString):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::computeAutocorrectionContext):

WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::getWebCoreStatistics):

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeProcessName):

Source/WebKitLegacy:

Storage/StorageTracker.cpp:

(WebKit::StorageTracker::syncFileSystemAndTrackerDatabase):

WebCoreSupport/PingHandle.h:

Source/WebKitLegacy/mac:

DOM/ExceptionHandlers.mm:

(raiseDOMErrorException):

Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invokeMethod):

Storage/WebDatabaseProvider.mm:

(WebDatabaseProvider::indexedDatabaseDirectoryPath):

Source/WebKitLegacy/win:

Plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

Source/WTF:

This patch adds user-defined literal for ASCIILiteral. We can create ASCIILiteral in the form of "Hello World"_s.
And we remove public ASCIILiteral constructor. This change ensures that ASCIILiteral is created from literal.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Indenter.h:

(WTF::Indenter::Indenter):

wtf/Logger.h:

(WTF::LogArgument::toString):

wtf/MediaTime.cpp:

(WTF::toJSONStringInternal):
(WTF::MediaTimeRange::toJSONString const):

wtf/linux/MemoryFootprintLinux.cpp:

(WTF::memoryFootprint):

wtf/text/ASCIILiteral.cpp: Copied from Source/WebCore/css/CSSUnsetValue.cpp.

(WTF::ASCIILiteral::dump const):

wtf/text/ASCIILiteral.h: Copied from Source/WTF/wtf/Indenter.h.

(WTF::ASCIILiteral::operator const char* const):
(WTF::ASCIILiteral::fromLiteralUnsafe):
(WTF::ASCIILiteral::null):
(WTF::ASCIILiteral::characters const):
(WTF::ASCIILiteral::ASCIILiteral):
(WTF::StringLiterals::operator _s):

wtf/text/WTFString.cpp:

(asciiDebug):

wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):
(WTF::ASCIILiteral::ASCIILiteral): Deleted.
(WTF::ASCIILiteral::operator const char*): Deleted.

wtf/unix/LanguageUnix.cpp:

(WTF::platformLanguage):

Tools:

TestWebKitAPI/Tests/WTF/StringOperators.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/WorkerPool.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:

(TEST_F):

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/URL.cpp:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebCore/mac/GPUTest.h:
TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:

(-[MockContentFilterEnabler initWithCoder:]):

TestWebKitAPI/Tests/mac/ContentFiltering.mm:

(TestWebKitAPI::loadAlternateTest):

Jun 22, 2018:

10:27 PM Changeset in webkit [233121] by keith_miller@apple.com

4 edits
1 add in trunk

unshift should zero unused property storage
https://bugs.webkit.org/show_bug.cgi?id=186960

Reviewed by Saam Barati.

JSTests:

stress/array-unshift-zero-property-storage.js: Added.

(run):
(test):

Source/JavaScriptCore:

Also, this patch adds the zeroed unused property storage assertion
to one more place it was missing.

runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):

runtime/JSObjectInlines.h:

(JSC::JSObject::putDirectInternal):

9:18 PM Changeset in webkit [233120] by Darin Adler

5 edits
3 copies
1 move
1 add
1 delete in trunk/Source/WTF

[Cocoa] reduce unnecessary use of .mm source files in WTF, spruce up some implementation details
https://bugs.webkit.org/show_bug.cgi?id=186924

Reviewed by Anders Carlsson.

WTF.xcodeproj/project.pbxproj: Update for file and directory renames, file type changes,

and deletions.

wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::holdOff): Deleted empty placeholder; this one is not needed.

wtf/PlatformMac.cmake: Update for file and directory renames, file type changes,

and deletions.

wtf/cocoa/CPUTimeCocoa.cpp: Renamed from Source/WTF/wtf/cocoa/CPUTimeCocoa.mm.

Reworked math to make better use of the Seconds class.

wtf/text/WTFString.h: Added a new inline version of the constructor that takes an NSString.

This is identical to the one that takes a CFStringRef, so no need to keep both.

wtf/text/cocoa/StringImplCocoa.mm: Renamed from Source/WTF/wtf/text/mac/StringImplMac.mm.

Also removed an unneeded include.

wtf/text/cocoa/StringViewCocoa.mm: Renamed from Source/WTF/wtf/text/mac/StringViewObjC.mm.

wtf/text/cocoa/TextBreakIteratorInternalICUCocoa.cpp: Renamed from

Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm.

wtf/text/mac/StringMac.mm: Removed.

7:42 PM Changeset in webkit [233119] by youenn@apple.com

5 edits
2 adds in trunk

Disable WebSocket in WatchOS
https://bugs.webkit.org/show_bug.cgi?id=186931
<rdar://problem/39584458>

Reviewed by Wenson Hsieh.

Source/WebCore:

Add a runtime flag to enable/disable WebSocket.
By default, flag is on for all platforms except for WatchOS.

Test: fast/dom/Window/watchos/websocket/watchos/no-websocket-in-watchos.html

Modules/websockets/WebSocket.idl:
page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebSocketEnabled):
(WebCore::RuntimeEnabledFeatures::webSocketEnabled const):

LayoutTests:

TestExpectations:
fast/dom/Window/watchos/no-websocket-in-watchos-expected.txt: Added.
fast/dom/Window/watchos/no-websocket-in-watchos.html: Added.

6:31 PM Changeset in webkit [233118] by Chris Dumez

2 edits in trunk/Source/WebKit

Regression(r230211): Crash under WebInspectorClient::~WebInspectorClient()
https://bugs.webkit.org/show_bug.cgi?id=186950
<rdar://problem/40602069>

Reviewed by Darin Adler.

Re-introduce null-check that was accidentally dropped in r230211.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::~WebInspectorClient):

6:22 PM Changeset in webkit [233117] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

SubresourceLoader::didFail() should only log message if state is Initialized
https://bugs.webkit.org/show_bug.cgi?id=185124

Patch by Woodrow Wang <woodrow_wang@apple.com> on 2018-06-22
Reviewed by Daniel Bates.

Functionality does not change. Moved console logging to be
after checking state of subresource loader. We only need to
log if the state is initialized. This is consistent with other
functions in the file. We can also remove a null check for the
frame pointer (m_frame). The superclass ResourceLoader constructor
takes an lvalue reference and initializes m_frame, ensuring
m_frame cannot be null. It is only set to null by
ResourceLoader::releaseResources(), which is only called after the
resource finishes loading or fails to load. Thus, in didFail(),
m_frame must be non-null when we're logging and up until the end of the function.

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFail):

6:21 PM Changeset in webkit [233116] by timothy@apple.com

26 edits
2 copies in trunk/Source

Corner of two scroll bars is white with dark mode enabled.
https://bugs.webkit.org/show_bug.cgi?id=186819
rdar://problem/40434350

Reviewed by Tim Horton.

Source/WebCore:

Configurations/WebCore.xcconfig:
WebCore.xcodeproj/project.pbxproj:
inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::paint): Added LocalDefaultSystemAppearance.

page/Page.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::paintScrollCorner): Dropped ScrollView argument.

platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintScrollCorner): Ditto.

platform/ScrollbarThemeComposite.cpp:

(WebCore::ScrollbarThemeComposite::paintScrollCorner): Deleted. Default is the same.

platform/ScrollbarThemeComposite.h:
platform/mac/LocalDefaultSystemAppearance.h:
platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Added recursion early return.
(WebCore::LocalDefaultSystemAppearance::~LocalDefaultSystemAppearance): Ditto.

platform/mac/ScrollbarThemeMac.h:
platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paintScrollCorner): Added.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents): Added LocalDefaultSystemAppearance.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents): Added LocalDefaultSystemAppearance.

rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::paintScrollCorner): Call ScrollbarTheme::paintScrollCorner.

rendering/RenderScrollbarTheme.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw): Added LocalDefaultSystemAppearance.

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/spi/mac/CoreUISPI.h: Added.
pal/spi/mac/NSAppearanceSPI.h: Added.

Source/WebKit:

UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView drawRect:]): Added LocalDefaultSystemAppearance.

WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage): Ditto.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::paintControlForLayerInContext): Ditto. Dropped ScrollView argument.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawRect): Added LocalDefaultSystemAppearance.

5:52 PM Changeset in webkit [233115] by timothy_horton@apple.com

14 edits
4 adds in trunk

Make it possible to add a border around loading or failed-to-load images
https://bugs.webkit.org/show_bug.cgi?id=186614
<rdar://problem/39050152>

Reviewed by Zalan Bujtas.

Source/WebCore:

Tests: http/tests/images/loading-image-border.html

http/tests/images/loading-image-no-border.html

rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIncompleteImageOutline):
(WebCore::RenderImage::paintReplaced):

rendering/RenderImage.h:

Factor the missing-image outline out, and - if desired - paint it in
cases where the image is still loading or otherwise pending, not just
when the image fails to load.

page/Settings.yaml:
testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setIncompleteImageBorderEnabled):

testing/InternalSettings.h:
testing/InternalSettings.idl:

Add and expose a setting to enable the feature.

Source/WebKit:

Shared/WebPreferences.yaml:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setColorFilterEnabled:]):
(-[WKWebViewConfiguration _incompleteImageBorderEnabled]):
(-[WKWebViewConfiguration _setIncompleteImageBorderEnabled:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Plumb the setting to WebKit2.

LayoutTests:

http/tests/images/loading-image-border-expected.html: Added.
http/tests/images/loading-image-border.html: Added.
http/tests/images/loading-image-no-border-expected.html: Added.
http/tests/images/loading-image-no-border.html: Added.
platform/wk2/TestExpectations:

Add a test ensuring that the setting works correctly.
These and similar tests do not currently work in WebKitTestRunner, so they are skipped there.

5:45 PM Changeset in webkit [233114] by mark.lam@apple.com

4 edits
1 add in trunk

PropertyCondition::isValidValueForAttributes() should also consider deleted values.
https://bugs.webkit.org/show_bug.cgi?id=186943
<rdar://problem/41370337>

Reviewed by Saam Barati.

JSTests:

stress/regress-186943.js: Added.

Source/JavaScriptCore:

PropertyCondition::isValidValueForAttributes() should check if the passed in value
is a deleted one before it does a jsDynamicCast on it.

bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isValidValueForAttributes):

runtime/JSCJSValueInlines.h:
removed an unnecessary #if.

5:34 PM Changeset in webkit [233113] by beidson@apple.com

19 edits in trunk

WKURLSchemeHandler doesn't handle sync XHR.
<rdar://problem/40955884> and https://bugs.webkit.org/show_bug.cgi?id=186902

Reviewed by Chris Dumez.

Source/WebCore:

English.lproj/Localizable.strings:

Source/WebKit:

This patch allows WebProcesses to block on sync loads to a custom scheme,
and teaches WebURLSchemeTasks how to buffer up data and the response if
operating synchronously.

Shared/WebErrors.cpp:

(WebKit::failedCustomProtocolSyncLoad):

Shared/WebErrors.h:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::startURLSchemeTask):
(WebKit::WebPageProxy::loadSynchronousURLSchemeTask):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:

UIProcess/WebURLSchemeHandler.cpp:

(WebKit::WebURLSchemeHandler::startTask):

UIProcess/WebURLSchemeHandler.h:

UIProcess/WebURLSchemeTask.cpp:

(WebKit::WebURLSchemeTask::create):
(WebKit::WebURLSchemeTask::WebURLSchemeTask):
(WebKit::WebURLSchemeTask::didPerformRedirection):
(WebKit::WebURLSchemeTask::didReceiveResponse):
(WebKit::WebURLSchemeTask::didReceiveData):
(WebKit::WebURLSchemeTask::didComplete):
(WebKit::WebURLSchemeTask::pageDestroyed):
(WebKit::WebURLSchemeTask::stop):

UIProcess/WebURLSchemeTask.h:

(WebKit::WebURLSchemeTask::isSync const):

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::tryLoadingSynchronouslyUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):

WebProcess/Network/WebLoaderStrategy.h:

WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp:

(WebKit::WebURLSchemeHandlerProxy::loadSynchronously):

WebProcess/WebPage/WebURLSchemeHandlerProxy.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

(-[SyncScheme webView:startURLSchemeTask:]):
(-[SyncScheme webView:stopURLSchemeTask:]):
(-[SyncMessageHandler userContentController:didReceiveScriptMessage:]):
(catch):

5:15 PM Changeset in webkit [233112] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

[Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924
https://bugs.webkit.org/show_bug.cgi?id=186945
<rdar://problem/37277469>

Reviewed by Simon Fraser.

platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::exitFullscreen):
(VideoFullscreenInterfaceAVKit::exitFullscreenHandler):
(VideoFullscreenInterfaceAVKit::cleanupFullscreen):

5:09 PM Changeset in webkit [233111] by Chris Dumez

5 edits in trunk/Source/WebKit

Implement IPC throttling to keep the main thread responsive when a process misbehaves
https://bugs.webkit.org/show_bug.cgi?id=186607
<rdar://problem/41073205>

Reviewed by Geoff Garen and Brady Eidson.

Implement IPC throttling to keep the main thread responsive when a process misbehaves.
Instead of doing one main runloop dispatch per incoming message, we now do a single
runloop dispatch and process incoming messages in batch. We put a limit on the number
of messages to be processed in a batch (600). If the queue is larger that this limit,
we'll schedule a 0-timer to process remaining messages, giving the main runloop a chance
to process other events. Additionally, if an IPC connection keeps hitting this maximum
batch size limit, we implement back off and we'll further decrease the number of messages
we process in each batch (going as low as 60). This keeps Safari responsive enough to
allow the user to close the bad tab (even on older devices such as iPhone 5s).

Finally, if the incoming message queue becomes too large (50000), we go one step further
and kill the IPC connection in order to maintain performance / battery life.

Every time we apply throttling or terminate a connection due to throttling, we do a
RELEASE_LOG_ERROR() with useful information in order to help diagnose potential issues
in the future.

For now, incoming IPC messages throttling is only enabled on the UIProcess' connections
to the WebProcesses.

Platform/IPC/Connection.cpp:

(IPC::Connection::Connection):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::MessagesThrottler::MessagesThrottler):
(IPC::Connection::MessagesThrottler::scheduleMessagesDispatch):
(IPC::Connection::MessagesThrottler::numberOfMessagesToProcess):
(IPC::Connection::dispatchIncomingMessages):

Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::kill):

5:03 PM Changeset in webkit [233110] by keith_miller@apple.com

3 edits
1 add in trunk

performProxyCall should toThis the value passed to its handler
https://bugs.webkit.org/show_bug.cgi?id=186951

Reviewed by Mark Lam.

JSTests:

stress/proxy-call-apply-handler-to-this.js: Added.

(applyHandler):
(let.f.new.Proxy):
(withScope):
(lexicalScope):
(strictEvalScope):
(BigInt):

Source/JavaScriptCore:

runtime/ProxyObject.cpp:

(JSC::performProxyCall):

4:42 PM ASanWebKit edited by mmaxfield@apple.com

Remove pre-El-Cap instructions (diff)

4:32 PM Changeset in webkit [233109] by dbates@webkit.org

2 edits in trunk/Websites/bugs.webkit.org

EWS for security bugs
https://bugs.webkit.org/show_bug.cgi?id=186291
<rdar://problem/40829658>

Rubber-stamped by Lucas Forschler.

Substitute "review" for "r" as the name of the Bugzilla flag to look at to determine
if we should CC the feeder EWS on the associated bug.

extensions/EWS/Extension.pm:

(isReviewFlag):

4:22 PM Changeset in webkit [233108] by sihui_liu@apple.com

2 edits in trunk/Source/WebKit

REGRESSION (r231850): Cookie file cannot be read or written by network process
https://bugs.webkit.org/show_bug.cgi?id=186806
<rdar://problem/41113791>

Unreviewed. Fix failure after r233084 by adding missing initialization.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

4:05 PM Changeset in webkit [233107] by dbates@webkit.org

2 edits in trunk/Tools

Security EWS: bots fails with exception 'NoneType' object has no attribute 'is_closed'
https://bugs.webkit.org/show_bug.cgi?id=186923

Reviewed by Lucas Forschler.

Attachments downloaded from the status server (http://webkit-queues.webkit.org) do not
have an associated Bug object (i.e. Attachment.bug() is None) and reflect the state they
were in, including flags set, at the time they were uploaded to the status server. We
will add support for fetching up-to-date status info about the attachment and its bug
in <https://bugs.webkit.org/show_bug.cgi?id=186817>. For now, we only check if the
bug associated with the patch we are processing is closed if the attachment has a
non-None Bug object.

Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

(EarlyWarningSystemTask.validate):

4:05 PM Changeset in webkit [233106] by pvollan@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix on Windows.

testing/Internals.h:

3:48 PM Changeset in webkit [233105] by jer.noble@apple.com

3 edits in trunk/Source/WebKit

[Fullscreen] Home indicator should show and hide with status bar
https://bugs.webkit.org/show_bug.cgi?id=186942
<rdar://problem/41302190>

Reviewed by Tim Horton.

UIProcess/ios/fullscreen/WKFullScreenViewController.h:
UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController showUI]):
(-[WKFullScreenViewController hideUI]):
(-[WKFullScreenViewController setPrefersHomeIndicatorAutoHidden:]):

3:24 PM Changeset in webkit [233104] by jer.noble@apple.com

4 edits in trunk/Source/WebKit

[Fullscreen] Add a pinch-to-exit gesture
https://bugs.webkit.org/show_bug.cgi?id=186821

Reviewed by Tim Horton.

Add a pinch gesture recognizer that overrides the pan gesture recognizer when active. Hide the
WKFullscreenViewController's controls while a dismiss gesture is active.

UIProcess/ios/fullscreen/WKFullScreenViewController.h:
UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController setAnimating:]):
(-[WKFullScreenViewController prefersStatusBarHidden]):
(-[WKFullScreenViewController gestureRecognizer:shouldReceiveTouch:]):
(-[WKFullScreenViewController _touchDetected:]):

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullscreenAnimationController context]):
(-[WKFullscreenAnimationController updateWithProgress:scale:translation:anchor:]):
(-[WKFullScreenInteractiveTransition animator]):
(-[WKFullScreenInteractiveTransition updateInteractiveTransition:withScale:andTranslation:]):
(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController interactionControllerForDismissal:]):
(-[WKFullScreenWindowController _startToDismissFullscreenChanged:]):
(-[WKFullScreenWindowController _dismissFullscreenViewController]):
(-[WKFullScreenWindowController _interactiveDismissChanged:]):
(-[WKFullScreenWindowController _interactivePinchDismissChanged:]):

3:24 PM Changeset in webkit [233103] by Ross Kirsling

2 edits
2 adds in trunk/LayoutTests

[WinCairo] Unreviewed test gardening.

platform/wincairo/TestExpectations:
platform/wincairo/css3/selectors3/html/css3-modsel-175a-expected.png: Added.
platform/wincairo/editing/style/apply-style-iframe-crash-expected.txt: Added.

3:13 PM Changeset in webkit [233102] by Ross Kirsling

4 edits in trunk/Tools

[Win] ImageDiff should use DLLLauncher
https://bugs.webkit.org/show_bug.cgi?id=186927

ImageDiff should use DLLLauncher to find DLLs under WEBKIT_LIBRARIES, in the same way as DRT & TestWebKitAPI.

Reviewed by Per Arne Vollan.

ImageDiff/CMakeLists.txt:
ImageDiff/ImageDiff.cpp:

(dllLauncherEntryPoint):

ImageDiff/PlatformWin.cmake:

2:53 PM Changeset in webkit [233101] by Kocsen Chung

1 copy in tags/Safari-606.1.22.1

Tag Safari-606.1.22.1.

2:36 PM Changeset in webkit [233100] by youenn@apple.com

5 edits
2 adds in trunk

Incoming G722 doesn't work
https://bugs.webkit.org/show_bug.cgi?id=186307
<rdar://problem/40809745>

Reviewed by Eric Carlson.

Source/WebCore:

WebRTC backends usually does the following:

Initially call RealtimeIncomingAudioSource with 16KHz data
Switch to 48KHz when actual data is decoded.

We added a check that was discarding any 16KHz data, but in case of G722, the data remains as 16KHz and is then never read.
The solution is to remove the check that discards 16KHz information.
We then need to fix a bug in AudioTrackPrivateMediaStreamCocoa that was preventing proper handling of change of audio data configuration.

Test: webrtc/audio-peer-connection-g722.html

platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp:

(WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable):

platform/mediastream/mac/RealtimeIncomingAudioSourceCocoa.cpp:

(WebCore::RealtimeIncomingAudioSourceCocoa::OnData):

LayoutTests:

webrtc/audio-peer-connection-g722-expected.txt: Added.
webrtc/audio-peer-connection-g722.html: Added.
webrtc/routines.js:

2:20 PM Changeset in webkit [233099] by david_fenton@apple.com

2 edits in trunk/LayoutTests

LayoutTests imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.https.any.html and imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.https.any.html are flaky.
https://bugs.webkit.org/show_bug.cgi?id=186940

Unreviewed test gardening.

TestExpectations:

2:02 PM Changeset in webkit [233098] by sbarati@apple.com

4 edits in trunk/Source/JavaScriptCore

ensureWritableX should only convert away from CoW when it will succeed
https://bugs.webkit.org/show_bug.cgi?id=186898

Reviewed by Keith Miller.

Otherwise, when we OSR exit, we'll end up profiling the array after
it has been converted away from CoW. It's better for the ArrayProfile
to see the array as it's still in CoW mode.

This patch also renames ensureWritableX to tryMakeWritableX since these
were never really "ensure" operations -- they may fail and return null.

dfg/DFGOperations.cpp:
runtime/JSObject.cpp:

(JSC::JSObject::tryMakeWritableInt32Slow):
(JSC::JSObject::tryMakeWritableDoubleSlow):
(JSC::JSObject::tryMakeWritableContiguousSlow):
(JSC::JSObject::ensureWritableInt32Slow): Deleted.
(JSC::JSObject::ensureWritableDoubleSlow): Deleted.
(JSC::JSObject::ensureWritableContiguousSlow): Deleted.

runtime/JSObject.h:

(JSC::JSObject::tryMakeWritableInt32):
(JSC::JSObject::tryMakeWritableDouble):
(JSC::JSObject::tryMakeWritableContiguous):
(JSC::JSObject::ensureWritableInt32): Deleted.
(JSC::JSObject::ensureWritableDouble): Deleted.
(JSC::JSObject::ensureWritableContiguous): Deleted.

1:50 PM Changeset in webkit [233097] by Basuke Suzuki

3 edits in trunk/Tools

[style] Fix --git-index option for check-webkit-style command
https://bugs.webkit.org/show_bug.cgi?id=186810

When --git-index is specified, it should be compared with HEAD, not the origin/master.

Reviewed by Daniel Bates.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git.create_patch):

Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_create_patch_with_git_index): Added.

1:32 PM Changeset in webkit [233096] by BJ Burg

2 edits in trunk/Source/WebKit

[Cocoa] REGRESSION(W3C): actions for key equivalents are not respected
https://bugs.webkit.org/show_bug.cgi?id=186936

Reviewed by Timothy Hatcher.

UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::isSimulatingUserInteraction const):
This erroneously reported false unless there was both a mouse and key interaction
being dispatched, which is not possible in the current serial event simulation model.
As a result, Safari could not tell whether the action came from a simulated event
or the user, and thus rejected all key equivalents like Cmd-A,V,C,X.

1:24 PM Changeset in webkit [233095] by jer.noble@apple.com

2 edits in trunk/Source/WebKit

[Fullscreen] Exit fullscreen when opening a new tab
https://bugs.webkit.org/show_bug.cgi?id=186826
<rdar://problem/40853211>

Reviewed by Brent Fulgham.

Make the fullscreen placeholder view a custom UIView, and exit fullscreen when the
placeholder is removed from its superview.

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenPlaceholderView willMoveToSuperview:]):
(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController _completedExitFullScreen]):
(-[WKFullScreenWindowController placeholderWillMoveToSuperview:]):
(-[WKFullScreenWindowController _exitFullscreenImmediately]):

1:21 PM Changeset in webkit [233094] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Fix the build after r233089

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setColorFilterEnabled:]):
(-[WKPreferences _colorFilterEnabled]):

1:16 PM Changeset in webkit [233093] by Chris Dumez

2 edits in trunk/LayoutTests

performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938

Unreviewed, temporarily skip it while I investigate.

TestExpectations:

1:16 PM Changeset in webkit [233092] by Chris Dumez

5 edits in trunk/Source/WebKit

Crash under WebResourceLoadStatisticsStore::mergeStatistics(WTF::Vector<WebCore::ResourceLoadStatistics, 0ul, WTF::CrashOnOverflow, 16ul>&&)
https://bugs.webkit.org/show_bug.cgi?id=186905
<rdar://problem/41266775>

Reviewed by Brent Fulgham.

I believe the crash was caused by the WebResourceLoadStatisticsStore object being dead
when mergeStatistics() is called. In particular, the crash was happening when the
ResourceLoadStatisticsPersistentStorage's FileMonitor would detect a file change and
we would re-sync statistics from the disk. The FileMonitor's lambda function was
capturing |this| without ref'ing it, and the FileMonitor monitors the disk and
calls the lambda on the background queue, while it gets destroyed on the main thread.

To make lifetime management less complex, the following changes were made:

The ResourceLoadStatisticsPersistentStorage object is now always constructed / used and destroyed on the background queue. We no longer have to worry about being on the right thread in a given method.
Now that ResourceLoadStatisticsPersistentStorage is always used from the background queue and no longer needs to be thread-safe, drop its ref() / deref() methods and use weak pointers instead to make sure the ResourceLoadStatisticsPersistentStorage is still alive when a lamdba gets called on the background queue.
For write scheduling use WorkQueue::dispatchAfter() and a WeakPtr instead of a RunLoop::Timer. This is more convenient to use as the RunLoop::Timer has to be used on the main thread.

UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::~ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::startMonitoringDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::monitorDirectoryForNewStatistics):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):

UIProcess/ResourceLoadStatisticsPersistentStorage.h:
UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
(WebKit::WebResourceLoadStatisticsStore::processStatisticsAndDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::WebResourceLoadStatisticsStore::applicationWillTerminate):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):

UIProcess/WebResourceLoadStatisticsStore.h:

1:06 PM Changeset in webkit [233091] by jer.noble@apple.com

3 edits in trunk/Source/WebKit

CRASH in WebCore::VideoFullscreenInterfaceMac::~VideoFullscreenInterfaceMac()
https://bugs.webkit.org/show_bug.cgi?id=186892

Reviewed by Eric Carlson.

Protect against m_contentMap being mutated while its contents are being invalidated
by moving the map into a local variable and iterating over it instead.

UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionManagerProxy::invalidate):

UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::invalidate):

1:01 PM Changeset in webkit [233090] by Ryan Haddad

2 edits in trunk/Tools

Unreviewed, fix syntax error introduced by r233088.

BuildSlaveSupport/built-product-archive:

(extractBuiltProduct):

12:56 PM Changeset in webkit [233089] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Expose colorFilterEnabled SPI in WKPreferencesPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=186935
<rdar://problem/41109387>

Patch by Luming Yin <luming_yin@apple.com> on 2018-06-22
Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setColorFilterEnabled:]):
(-[WKPreferences _colorFilterEnabled]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:

12:08 PM Changeset in webkit [233088] by Ross Kirsling

4 edits
1 move in trunk/Tools

[WinCairo][Buildbot] Test bots should use same WinCairoRequirements version as the triggering build
https://bugs.webkit.org/show_bug.cgi?id=186857

Reviewed by Lucas Forschler.

BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):
Save and restore the WinCairoRequirements version using the build archive.

Scripts/download-github-release.py: Renamed from Tools/Scripts/download-latest-github-release.py.

Generalize download script -- get the latest version by default, but allow an arbitrary version to be specified.

Scripts/update-vswhere.py:

Consume renamed script.

Scripts/update-webkit-wincairo-libs.py:

Consume renamed script and specify a version to download when a config file is present.

11:32 AM Changeset in webkit [233087] by timothy@apple.com

8 edits in trunk/Source

Recalc styles every time defaultAppearance changes.
https://bugs.webkit.org/show_bug.cgi?id=186866
rdar://problem/41309805

Reviewed by Tim Horton.

Source/WebCore:

page/Page.cpp:

(WebCore::Page::setUseSystemAppearance): Added. Recalc styles and update system colors.
(WebCore::Page::setDefaultAppearance): Added. Ditto.

page/Page.h:

(WebCore::Page::setUseSystemAppearance): Deleted impl.
(WebCore::Page::setDefaultAppearance): Deleted impl.

Source/WebKit:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDefaultAppearance):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDefaultAppearance):

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _updateDefaultAppearance]):
(-[WebView _setUseSystemAppearance:]):
(-[WebView _useSystemAppearance]):

11:29 AM Changeset in webkit [233086] by Kocsen Chung

7 edits in branches/safari-606.1.22-branch/Source

Versioning.

11:26 AM Changeset in webkit [233085] by keith_miller@apple.com

22 edits in trunk/Source/JavaScriptCore

We should call visitChildren on Base not the exact typename
https://bugs.webkit.org/show_bug.cgi?id=186928

Reviewed by Mark Lam.

A lot of places were not properly calling visitChildren on their
superclass. For most of them it didn't matter because they had
immortal structures. If code changed in the future this might
break things however.

Also, block off more of the MethodTable for GetterSetter objects.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitChildren):

bytecode/ExecutableToCodeBlockEdge.cpp:

(JSC::ExecutableToCodeBlockEdge::visitChildren):

debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::visitChildren):

runtime/EvalExecutable.cpp:

(JSC::EvalExecutable::visitChildren):

runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::visitChildren):

runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::visitChildren):

runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::visitChildren):

runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

runtime/GetterSetter.h:
runtime/InferredType.cpp:

(JSC::InferredType::visitChildren):

runtime/InferredTypeTable.cpp:

(JSC::InferredTypeTable::visitChildren):

runtime/InferredValue.cpp:

(JSC::InferredValue::visitChildren):

runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::visitChildren):

runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren):

runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::visitChildren):

runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::visitChildren):

runtime/ScopedArguments.cpp:

(JSC::ScopedArguments::visitChildren):

runtime/ScopedArguments.h:
runtime/Structure.cpp:

(JSC::Structure::visitChildren):

runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):

runtime/SymbolTable.cpp:

(JSC::SymbolTable::visitChildren):

10:06 AM Changeset in webkit [233084] by sihui_liu@apple.com

7 edits in trunk/Source/WebKit

REGRESSION (r231850): Cookie file cannot be read or written by network process
https://bugs.webkit.org/show_bug.cgi?id=186806
<rdar://problem/41113791>

Reviewed by Geoffrey Garen.

Add defaultSessionPendingCookies to NetworkProcessCreationParameters, so pending cookies of default session
can be added right after default session is set. This improves the fix r231850 as it does not send additional
message and avoids the regression.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

9:54 AM Changeset in webkit [233083] by Brent Fulgham

3 edits in trunk/Source/WebKit

[iOS Debug] Multiple resourceLoadStatistics redirect tests are flaky timeouts
https://bugs.webkit.org/show_bug.cgi?id=183216
<rdar://problem/37992317>

Reviewed by Chris Dumez.

Improve consistency of test results by make sure that completion handlers written to run
on the main thread are only called on the main thread. Add additional assertions to help
catch any cases where this invariant is not being honored.

UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::hasStorageAccess): Use Completion handler and assert
we are on the right thread.
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess): Ditto.
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess): Ditto.
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction): Ditto.
(WebKit::WebResourceLoadStatisticsStore::logNonRecentUserInteraction): Ditto.
(WebKit::WebResourceLoadStatisticsStore::clearUserInteraction): Ditto.
(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setLastSeen): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isVeryPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubFrameUnder): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsRedirectingTo): Ditto.
(WebKit::WebResourceLoadStatisticsStore::clearPrevalentResource): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setGrandfathered): Ditto.
(WebKit::WebResourceLoadStatisticsStore::isGrandfathered): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameOrigin): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameOrigin): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo): Ditto.
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom): Ditto.
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningUpdate):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningUpdateForDomains):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearPartitioningStateForDomains):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningStateReset):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent): Update to perform callbacks
on the main thread (as intended). This function was doing them on a work queue.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning): Ditto.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains): Ditto.
(WebKit::WebResourceLoadStatisticsStore::clearPartitioningStateForDomains): Ditto.

UIProcess/WebResourceLoadStatisticsStore.h:

9:54 AM Changeset in webkit [233082] by bshafiei@apple.com

1 copy in branches/safari-606.1.22-branch

New branch.

9:38 AM Changeset in webkit [233081] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[GStreamer] Avoid sending SELECT_STREAM events when nothing changed
https://bugs.webkit.org/show_bug.cgi?id=186678

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-06-22
Reviewed by Philippe Normand.

This avoid extra work in decodebin3 and should work around a crash
in decodebin3 when we send spurious SELECT_STREAM in the mediastream
layout tests.

GStreamer was also missing safe guards in the GstStream APIs which have been
added in gstreamer core in 8833ca942ea21c58c0f63822f0e2b61695b39447
"stream: Add some missing API safe guards".

Should fix following flakes:

fast/mediastream/MediaStream-video-element-track-stop.html
fast/mediastream/change-tracks-media-stream-being-played.html

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::enableTrack):

8:45 AM WebKitGTK/2.20.x edited by Michael Catanzaro

(diff)

8:43 AM Changeset in webkit [233080] by Michael Catanzaro

7 edits in trunk

REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
https://bugs.webkit.org/show_bug.cgi?id=186206

Source/WebCore:

Unreviewed manual rollout of r230950

platform/graphics/texmap/TextureMapperLayer.h:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):

Source/WebKit:

Unreviewed manual rollout of r230950

Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::layerShouldHaveBackingStore):

LayoutTests:

Unreviewed, remove crash expectations for crashes introduced by r230950.

platform/gtk/TestExpectations:

8:03 AM Changeset in webkit [233079] by Darin Adler

21 edits in trunk

[Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity
https://bugs.webkit.org/show_bug.cgi?id=186875

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

API/tests/testapi.mm:

(testObjectiveCAPIMain): Use isDirectory:NO when creating a URL for a JavaScript file.

Source/WebCore:

platform/cocoa/ThemeCocoa.mm:

(WebCore::passKitBundle): Use isDirectory:YES when creating a URL pointing to a framework,
since frameworks are directories.

Source/WebKit:

UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::tempDirectoryFileSystemRepresentation): Use isDirectory:YES to create a URL
to the temporary directory.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::namesOfPromisedFilesDroppedAtDestination): Use isDirectory:NO to create a URL
pointing to the write location.

UIProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm:

(WebKit::LocalStorageDatabaseTracker::platformMaybeExcludeFromBackup const): Use isDirectory:YES to
create a URL for the local storage directory.

UIProcess/ios/ResourceLoadStatisticsPersistentStorageIOS.mm:

(WebKit::ResourceLoadStatisticsPersistentStorage::excludeFromBackup const): Use isDirectory:NO to
create a URL for the storage directory.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _prepareToDragPromisedBlob:]): Use isDirectory:NO to create a URL for the temporary
file location.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _uploadItemForImageData:imageName:successBlock:failureBlock:]): Use isDirectory:NO
to create a URL for the image file to upload.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorPageURL): Use isDirectory:NO to create a URL for the HTML file.
(WebKit::WebInspectorProxy::inspectorTestPageURL): Ditto.
(WebKit::WebInspectorProxy::inspectorBaseURL): Ditto.

WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::createIconForFiles): Use isDirectory:NO to create a URL for the image file.

WebProcess/WebPage/mac/WebInspectorUIMac.mm:

(WebKit::webInspectorUILocalizedStringsURL): Use isDirectory:NO to create a URL for the localized
strings file.

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm:

(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use isDirectory:NO for the URL of the location
to write te file to.

WebView/WebPreferences.mm:

(-[WebPreferences userStyleSheetLocation]): Use isDirectory:NO to create a URL for the user style sheet.

WebView/WebView.mm:

(-[WebView setMainFrameURL:]): Use isDirectory:NO to create a URL for a local webpage to load.

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(activateTestingFonts): Use isDirectory:NO to create a URL for a font file.

WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:

(WTR::activateFonts): Ditto.
(WTR::installFakeHelvetica): Ditto.

7:02 AM Changeset in webkit [233078] by magomez@igalia.com

9 edits in trunk/Source/WebCore

[WPE][ThreadedRendering] WPE crashes rendering SVG content when using ThreadedRendering
https://bugs.webkit.org/show_bug.cgi?id=186914

Reviewed by Carlos Garcia Campos.

Add GraphicsContextImpl::clipToImageBuffer() to the interface and the implementors. Forward
the call to GraphicsContext::clipToImageBuffer() to the implementation if possible in the
cairo case.

Covered by existent tests.

platform/graphics/GraphicsContextImpl.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clipToImageBuffer):

platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::clipToImageBuffer):

platform/graphics/cairo/GraphicsContextImplCairo.h:
platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::clipToImageBuffer):

platform/graphics/displaylists/DisplayListRecorder.h:
platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::clipToImageBuffer):

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:

6:23 AM Changeset in webkit [233077] by Carlos Garcia Campos

7 edits in trunk

[GTK] WebDriver: use a dictionary for session capabilities in StartAutomationSession message
https://bugs.webkit.org/show_bug.cgi?id=186915

Reviewed by Žan Doberšek.

Source/JavaScriptCore:

Update StartAutomationSession message handling to receive a dictionary of session capabilities.

inspector/remote/glib/RemoteInspectorServer.cpp:

(Inspector::processSessionCapabilities): Helper method to process the session capabilities.

Source/WebDriver:

Instead of growing the message signature every time we add a new capability, use a dictionary a{sv} and simply add
new entries when new capabilities are added. This way we won't need to change the message signature anymore.

SessionHost.h:
glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::buildSessionCapabilities const): Helper to build the session capabilities dictionary.
(WebDriver::SessionHost::startAutomationSession):

Tools:

Update /webkit/WebKitAutomationSession/request-session to use the new StartAutomationSession message signature.

TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:

6:22 AM Changeset in webkit [233076] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
https://bugs.webkit.org/show_bug.cgi?id=186911

Reviewed by Michael Catanzaro.

This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that
didn't start a clean build. The problem is that the CMake command to generate
SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on
SelectorPseudoClassAndCompatibilityElementMap.in.

CMakeLists.txt:

2:49 AM Changeset in webkit [233075] by magomez@igalia.com

7 edits in trunk/Source/WebCore

[WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering
https://bugs.webkit.org/show_bug.cgi?id=186886

Reviewed by Žan Doberšek.

Modify DisplayList DrawGlyphs element to use a GraphicsContext for replaying. To do so, modify
GraphicsContext::drawGlyphs() API so it doesn't require a FontCascade, and update all the calls
to it.

Covered by existent tests.

platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::drawGlyphBuffer const):

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawGlyphs):

platform/graphics/GraphicsContext.h:
platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::apply const):

rendering/mathml/MathOperator.cpp:

(WebCore::MathOperator::paintGlyph):
(WebCore::MathOperator::paint):

rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::paint):

2:32 AM Changeset in webkit [233074] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix GLib test /webkit/WebKitSecurityManager/file-xhr after r231000

We are now receiving two console messages instead of one. Simply update the test to check both messages.

TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:

(consoleMessageReceivedCallback):
(testWebContextSecurityFileXHR):

1:52 AM Changeset in webkit [233073] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed GLib gardening. Update expectations of TestSSL.

/webkit/WebKitWebView/tls-errors-policy and /webkit/WebKitWebView/load-failed-with-tls-errors are failing only
in the bots.

TestWebKitAPI/glib/TestExpectations.json:

12:05 AM Changeset in webkit [233072] by Michael Catanzaro

3 edits in trunk/Source/ThirdParty

[WPE][GTK] Update xdgmime
https://bugs.webkit.org/show_bug.cgi?id=186907

Reviewed by Carlos Garcia Campos.

Only one change, fixes https://bugs.freedesktop.org/show_bug.cgi?id=97372.

xdgmime/README.webkit:
xdgmime/src/xdgmimeint.c:

(_xdg_binary_or_text_fallback):

Jun 21, 2018:

11:41 PM Changeset in webkit [233071] by Carlos Garcia Campos

2 edits in trunk/Source/WTF

[GLIB] improve get_type() fast path in WEBKIT_DEFINE_TYPE
https://bugs.webkit.org/show_bug.cgi?id=186885

Reviewed by Anders Carlsson.

This is a backport of glib commit
https://gitlab.gnome.org/GNOME/glib/commit/e924f777369710221c3e0a9d7bf40392a27d1fa4

"The -fstack-protector-strong used in many distributions by default has a
rather drastic slowdown of the fast path in generated _get_type()
functions using G_DEFINE_* macros. The amount can vary by architecture,
GCC version, and compiler flags.

To work around this, and ensure a higher probability that our fast-path
will match what we had previously, we need to break out the slow-path
(registering the type) into a secondary function that is not a candidate
for inlining.

This ensures that the common case (type registered, return the GType id)
is the hot path and handled in the prologue of the generated assembly even
when -fstack-protector-strong is enabled."

wtf/glib/WTFGType.h:

8:01 PM Changeset in webkit [233070] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

WebKit (JavaScriptCore) compilation error with Clang ≥ 6.
https://bugs.webkit.org/show_bug.cgi?id=185947
<rdar://problem/40131933>

Reviewed by Saam Barati.

Newer Clang versions (due to C++17 support) is not happy with how I implemented
conversions between CodeLocation types. We'll fix this by adding a conversion
operator for converting between CodeLocation types.

assembler/CodeLocation.h:

(JSC::CodeLocationCommon::operator T):

5:21 PM Changeset in webkit [233069] by david_fenton@apple.com

2 edits in trunk/LayoutTests

Skip imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html.
https://bugs.webkit.org/show_bug.cgi?id=186901

Unreviewed test gardening.

TestExpectations:

4:30 PM Changeset in webkit [233068] by Chris Dumez

4 edits in trunk/Source/WebKit

Unreviewed, rolling out r232995.

Seems to have caused flakiness

Reverted changeset:

"Implement IPC throttling to keep the main thread responsive
when a process misbehaves"
https://bugs.webkit.org/show_bug.cgi?id=186607
https://trac.webkit.org/changeset/232995

4:30 PM Changeset in webkit [233067] by Ryan Haddad

2 edits in trunk/Source/WebCore/PAL

Unreviewed attempt to fix the build after r233052.

pal/spi/cocoa/AVKitSPI.h:

4:13 PM Changeset in webkit [233066] by jer.noble@apple.com

25 edits
2 adds
2 deletes in trunk

Address fullscreen api CSS env feedback
https://bugs.webkit.org/show_bug.cgi?id=186684

Reviewed by Simon Fraser.

Source/WebCore:

Test: fullscreen/fullscreen-env.html

+ Update the phishing alert text to be more explicit about the specific threats

phishing sites represent.

+ Make the top inset static, rather than dynamic.
+ Add bottom, left, and right insets for completeness.
+ Set the fullscreen animation duration as well as delay.
+ Notify the page when the controls show and hide.

English.lproj/Localizable.strings:
css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

css/CSSSelector.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

css/SelectorCheckerTestFunctions.h:

(WebCore::matchesFullScreenControlsHiddenPseudoClass):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

dom/ConstantPropertyMap.cpp:

(WebCore::ConstantPropertyMap::nameForProperty const):
(WebCore::ConstantPropertyMap::updateConstantsForFullscreenInsets):
(WebCore::ConstantPropertyMap::didChangeFullscreenInsets):
(WebCore::ConstantPropertyMap::setFullscreenAutoHideDuration):
(WebCore::ConstantPropertyMap::setFullscreenInsetTop): Deleted.

dom/ConstantPropertyMap.h:
dom/Document.cpp:

(WebCore::Document::areFullscreenControlsHidden const):
(WebCore::Document::setFullscreenControlsHidden):

dom/Document.h:
page/Page.cpp:

(WebCore::Page::setFullscreenInsets):
(WebCore::Page::setFullscreenAutoHideDuration):
(WebCore::Page::setFullscreenControlsHidden):
(WebCore::Page::setFullscreenInsetTop): Deleted.

page/Page.h:

(WebCore::Page::fullscreenInsets const):

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setFullscreenInsets):
(WebCore::Internals::setFullscreenAutoHideDuration):
(WebCore::Internals::setFullscreenControlsHidden):
(WebCore::Internals::setFullscreenInsetTop): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

+ Update the phishing alert text to be more explicit about the specific threats

phishing sites represent.

UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::setFullscreenInsets):
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideTiming):
(WebKit::WebFullScreenManagerProxy::setFullscreenControlsHidden):
(WebKit::WebFullScreenManagerProxy::setFullscreenInsetTop): Deleted.
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideDelay): Deleted.

UIProcess/WebFullScreenManagerProxy.h:
UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController showUI]):
(-[WKFullScreenViewController hideUI]):
(-[WKFullScreenViewController viewWillAppear:]):
(-[WKFullScreenViewController _effectiveFullscreenInsets]):
(-[WKFullScreenViewController _updateWebViewFullscreenInsets]):
(-[WKFullScreenViewController _showPhishingAlert]):
(-[WKFullScreenViewController _effectiveFullscreenInsetTop]): Deleted.

WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::didExitFullScreen):
(WebKit::WebFullScreenManager::setFullscreenInsets):
(WebKit::WebFullScreenManager::setFullscreenAutoHideTiming):
(WebKit::WebFullScreenManager::setFullscreenControlsHidden):
(WebKit::WebFullScreenManager::setFullscreenInsetTop): Deleted.
(WebKit::WebFullScreenManager::setFullscreenAutoHideDelay): Deleted.

WebProcess/FullScreen/WebFullScreenManager.h:
WebProcess/FullScreen/WebFullScreenManager.messages.in:

LayoutTests:

fullscreen/fullscreen-env-expected.txt: Added.
fullscreen/fullscreen-env.html: Added.
fullscreen/fullscreen-inset-top-expected.txt: Removed.
fullscreen/fullscreen-inset-top.html: Removed.

3:57 PM Changeset in webkit [233065] by sbarati@apple.com

4 edits in trunk/Source/JavaScriptCore

Do some CoW cleanup
https://bugs.webkit.org/show_bug.cgi?id=186896

Reviewed by Mark Lam.

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::decompressArrayAllocationProfile):
We don't need to WTFMove() ints

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
remove a TODO.

runtime/JSObject.cpp:

(JSC::JSObject::putByIndex):
We were checking for isCopyOnWrite even after we converted away
from CoW in above code.
(JSC::JSObject::ensureWritableInt32Slow):
Model this in the same way the other ensureWritableXSlow are modeled.

3:51 PM Changeset in webkit [233064] by dbates@webkit.org

2 edits in trunk/Tools

EWS for security bugs
https://bugs.webkit.org/show_bug.cgi?id=186291
<rdar://problem/40829658>

Substitute webkit.status-api-key for webkit.status_api_key as Git configuration variables can
only consist of alphanumeric characters and underscores (_) per the second paragraph of section
Configuration File of <https://git-scm.com/docs/git-config/2.18.0#_configuration_file>:

The variable names are case-insensitive, allow only alphanumeric characters and -, and must
start with an alphabetic character.

Scripts/webkitpy/tool/main.py:

(WebKitPatch._status_server_api_key_from_git):

3:32 PM Changeset in webkit [233063] by bshafiei@apple.com

7 edits in branches/safari-606.1.20.40-branch/Source

Versioning.

3:30 PM Changeset in webkit [233062] by bshafiei@apple.com

1 copy in tags/Safari-606.1.20.40.3

Tag Safari-606.1.20.40.3.

3:14 PM Changeset in webkit [233061] by dbates@webkit.org

2 edits in trunk/Tools

EWS for security bugs
https://bugs.webkit.org/show_bug.cgi?id=186291
<rdar://problem/40829658>

In r232979, I inadvertently removed a line of code in _parse_authorized_api_keys() to define a local called api_keys.
Add this code back.

QueueStatusServer/config/authorization.py:

(_parse_authorized_api_keys):

2:42 PM Changeset in webkit [233060] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Unreviewed, rolling out r232884.
https://bugs.webkit.org/show_bug.cgi?id=186891

"Introduced assertion failure in ~DisplayRefreshMonitorMac()."
(Requested by perarne on #webkit).

Reverted changeset:

"DisplayRefreshMonitorMac should hold a weak pointer to
WebPage."
https://bugs.webkit.org/show_bug.cgi?id=186683
https://trac.webkit.org/changeset/232884

2:23 PM Changeset in webkit [233059] by jer.noble@apple.com

13 edits in trunk/Source

[Fullscreen] Page sometimes ends up with an incorrect zoom level after entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=186822

Reviewed by Simon Fraser.

Source/WebCore:

dom/Document.cpp:

(WebCore::Document::setOverrideViewportArguments):
(WebCore::Document::updateViewportArguments):

dom/Document.h:

Source/WebKit:

Set the minimum zoom, maximum zoom, zoom bouncing, and user scalability settings of the
WKWebView's UIScrollView upon entering fullscreen, and restore those same settings upon
exit. Override the viewport arguments upon entering fullscreen, restore them upon exit.

Platform/IPC/ArgumentCoder.h:
Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ViewportArguments>::decode):

Shared/WebCoreArgumentCoders.h:
UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::forceAlwaysUserScalable const):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setOverrideViewportArguments):

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(WebKit::WKWebViewState::applyTo):
(WebKit::WKWebViewState::store):
(-[WKFullScreenWindowController enterFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::forceAlwaysUserScalable const):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setOverrideViewportArguments):

2:11 PM Changeset in webkit [233058] by dbates@webkit.org

3 edits in trunk/Tools

EWS should not try to post comments or upload result archives to security-sensitive
bugs unless it has access
https://bugs.webkit.org/show_bug.cgi?id=186831

Reviewed by Lucas Forschler.

Following r232979 security-sensitive patches are uploaded to the status server so
that they can be retrieved and processed by EWS bots without the need for Bugzilla
security bug access. Although the EWS machinery is robust against unexpected exceptions,
including exceptions raised when interacting with Bugzilla bugs/attachments with
insufficient credentials, we should not depend on such defenses as they cause webkit-
patch to log a message for the "unexpected" exception. We should reserve such logging
for truly unexpected exceptions that indicate a programming mistake that we need to fix.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem._post_reject_message_on_bug): Bail out early if we cannot
access the bug.

Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._can_access_bug): Added.
(PatchProcessingQueue._upload_results_archive_for_patch): Only add an attachment if we
can access the bug.
(CommitQueue.process_work_item): Only post a rejection comment (i.e. call CommitterValidatorreject_patch_from_commit_queue())
if we can access the bug.

1:58 PM Changeset in webkit [233057] by Lucas Forschler

2 edits in trunk/Tools

Fix for https://bugs.webkit.org/show_bug.cgi?id=185790

1:54 PM Changeset in webkit [233056] by Said Abou-Hallawa

3 edits
2 adds in trunk

RenderSVGInline has to be inline always regardless of its css display value
https://bugs.webkit.org/show_bug.cgi?id=186656

Reviewed by Zalan Bujtas.

Source/WebCore:

According to https://www.w3.org/TR/SVG2/text.html#TextLayout, the <text>
element has to be laid out as if it were a block element and any <tspan>,
<textPath>, <a> and <tref> descendants were inline elements.

If a css rule, which contains the property "display: block;", is applied
to any of children of a <text> element, this property has to be ignored.

We currently ignore this property in RenderSVGInline::updateFromStyle()
by forcing setInline(true). But we do not do the same thing in
RenderTreeBuilder::normalizeTreeAfterStyleChange(). In fact we allow
making the children of the <text> element to be non-inline. This puts
the render tree in weired state and causes many assertions to fire while
laying out RenderSVGText.

Test: svg/dom/svg-inline-text-display-block-crash.html

rendering/updating/RenderTreeBuilder.cpp:

(WebCore::RenderTreeBuilder::normalizeTreeAfterStyleChange):

LayoutTests:

svg/dom/svg-inline-text-display-block-crash-expected.txt: Added.
svg/dom/svg-inline-text-display-block-crash.html: Added.

1:34 PM Changeset in webkit [233055] by Alan Bujtas

3 edits
2 adds in trunk

Do not reuse generated inline renderer for the first letter.
https://bugs.webkit.org/show_bug.cgi?id=186657
<rdar://problem/41157892>

Reviewed by Simon Fraser.

Source/WebCore:

When the first letter pseudo element is present, we construct a dedicated subtree for its content like this:

<div><span>foobar</span></div> -> with ::first-letter on the <div>
DIV RenderBlock

SPAN RenderInline

RenderInline (generated wrapper for the first letter content)

RenderText (fist letter content)

RenderText (remaining text content)

"display: contents" on the <span> forces us not to construct a RenderInline for the <span> (or just come up with a wrapper at best).
FirstLetter::createRenderers logic needs to check for such cases and pick the correct parent for the first letter subtree accordingly.

Test: fast/text/first-letter-with-display-contents-crash.html

imported/w3c/web-platform-tests/css/css-display/display-contents-first-letter-002.html is not crashing anymore either.

rendering/updating/RenderTreeBuilderFirstLetter.cpp:

(WebCore::RenderTreeBuilder::FirstLetter::createRenderers):

LayoutTests:

fast/text/first-letter-with-display-contents-crash-expected.txt: Added.
fast/text/first-letter-with-display-contents-crash.html: Added.

1:10 PM Changeset in webkit [233054] by Keith Rollin

3 edits in trunk/Tools

check-webkit-style should warn about exported inline functions
https://bugs.webkit.org/show_bug.cgi?id=186861
<rdar://problem/41303668>

Reviewed by Brent Fulgham.

When checking binaries compiled with LTO enabled, WebKit's
check-for-weak-vtables-and-externals script can complain about
exported inline functions. For instance, in
Source/WebCore/page/scrolling/ScrollingTree.h, the following:

WEBCORE_EXPORT virtual void reportSynchronousScrollingReasonsChanged(MonotonicTime, SynchronousScrollingReasons) { }
WEBCORE_EXPORT virtual void reportExposedUnfilledArea(MonotonicTime, unsigned /* unfilledArea */) { }

Can result in the following error messages:

ERROR: WebCore has a weak external symbol in it (.../OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol ZN7WebCore13ScrollingTree25reportExposedUnfilledAreaEN3WTF13MonotonicTimeEj
ERROR: symbol ZN7WebCore13ScrollingTree40reportSynchronousScrollingReasonsChangedEN3WTF13MonotonicTimeEj

Unfortunately, these errors are only emitted when LTO is enabled,
meaning that a developer could check-in a file that will fail an LTO
build if they don't build with that option locally. Therefore, try to
head this off by updating check-webkit-style to identify and warn
about these cases (which includes when an export macro is applied
directly to an inline method as well as when an inline method is part
of an exported class).

Scripts/webkitpy/style/checkers/cpp.py:

(_FunctionState.begin):
(_FunctionState.export_macro):
(_ClassInfo.init):
(check_for_non_standard_constructs):
(check_function_definition):
(process_line):
(CppChecker):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(FunctionDetectionTest.perform_function_detection):
(FunctionDetectionTest.test_webcore_export):

12:04 PM Changeset in webkit [233053] by Chris Dumez

10 edits
6 adds in trunk

JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up
https://bugs.webkit.org/show_bug.cgi?id=186873
<rdar://problem/41271574>

Reviewed by Simon Fraser.

Source/WebCore:

Add [IsWeakCallback] to PerformanceObserverCallback interface so that the generated
JSPerformanceObserverCallback uses a JSC::Weak instead of a JSC::Strong to store the
js function. To keep the function alive, add [JSCustomMarkFunction] to PerformanceObserver
interface and have its visitAdditionalChildren() visit the callback's js function.
Finally, because we want the callback to still be called even if the JS does not keep
the PerformanceObserver wrapper alive, add [CustomIsReachable] to PerformanceObserver
interface and have its isReachableFromOpaqueRoots() return true if the observer is
registered (i.e. it may need to call the callback in the future).

I have confirmed locally, that the Performance / PerformanceObserver / Document
objects properly get destroyed if I navigate away from a page that had a performance
observer and trigger a memory pressure warning. Also,
notifyutil -p com.apple.WebKit.showAllDocuments no longer shows the old document.

Tests: performance-api/performance-observer-callback-after-gc.html

performance-api/performance-observer-no-document-leak.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSPerformanceObserverCustom.cpp: Added.

(WebCore::JSPerformanceObserver::visitAdditionalChildren):
(WebCore::JSPerformanceObserverOwner::isReachableFromOpaqueRoots):

bindings/js/ScriptController.cpp:
page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::disassociate):

page/PerformanceObserver.h:

(WebCore::PerformanceObserver::isRegistered const):
(WebCore::PerformanceObserver::callback):

page/PerformanceObserver.idl:
page/PerformanceObserverCallback.h:
page/PerformanceObserverCallback.idl:

LayoutTests:

performance-api/performance-observer-callback-after-gc-expected.txt: Added.
performance-api/performance-observer-callback-after-gc.html: Added.

Add layout test to make sure that a performance observer's callback still gets called, even if
the JS does not keep the performance observer alive.

performance-api/performance-observer-no-document-leak-expected.txt: Added.
performance-api/performance-observer-no-document-leak.html: Added.
performance-api/resources/performance-observer-no-document-leak-frame.html: Added.

Add layout test coverage to make sure the document does not leak if PerformanceObserver was
used.

11:59 AM Changeset in webkit [233052] by jer.noble@apple.com

6 edits in trunk/Source

[Fullscreen] Use secondary glyph style for fullscreen controls
https://bugs.webkit.org/show_bug.cgi?id=186862
<rdar://problem/41212210>

Reviewed by Tim Horton.

Source/WebCore/PAL:

pal/spi/cocoa/AVKitSPI.h:

Source/WebKit:

Adopt AVBackgroundView, and use its predefined enums to set the material and tint styles for
the fullscreen controls.

UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController loadView]):

UIProcess/ios/fullscreen/WKFullscreenStackView.h:
UIProcess/ios/fullscreen/WKFullscreenStackView.mm:

(-[WKFullscreenStackView init]):
(-[WKFullscreenStackView dealloc]):
(-[WKFullscreenStackView addArrangedSubview:applyingMaterialStyle:tintEffectStyle:]):
(-[WKFullscreenStackView layoutSubviews]):
(+[WKFullscreenStackView baseEffects]): Deleted.
(+[WKFullscreenStackView configureView:forTintEffectWithColor:filterType:]): Deleted.
(+[WKFullscreenStackView configureView:withBackgroundFillOfColor:opacity:filter:]): Deleted.
(+[WKFullscreenStackView secondaryMaterialOverlayView]): Deleted.
(+[WKFullscreenStackView applyPrimaryGlyphTintToView:]): Deleted.
(+[WKFullscreenStackView applySecondaryGlyphTintToView:]): Deleted.
(-[WKFullscreenStackView initWithArrangedSubviews:axis:]): Deleted.
(-[WKFullscreenStackView setTargetViewForSecondaryMaterialOverlay:]): Deleted.
(-[WKFullscreenStackView contentView]): Deleted.
(-[WKFullscreenStackView _setArrangedSubviews:axis:]): Deleted.
(-[WKFullscreenStackView setBounds:]): Deleted.
(-[WKFullscreenStackView updateConstraints]): Deleted.

11:54 AM Changeset in webkit [233051] by graouts@webkit.org

9 edits in trunk

[Web Animations] Make imported/mozilla/css-animations/test_animation-ready.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=183830
<rdar://problem/40997539>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions in the Mozilla CSS Animations tests.

css-animations/test_animation-ready-expected.txt:

Source/WebCore:

The CSS Animations Level 2 spec explains how the Web Animations API and CSS Animations interact and requires
pending styles changes on the target element of a CSS Animation to be flushed when using a Web Animations API
on it in order to ensure that any animation- CSS property is accounted for.

animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::bindingsStartTime const):
(WebCore::CSSAnimation::setBindingsStartTime):
(WebCore::CSSAnimation::bindingsCurrentTime const):
(WebCore::CSSAnimation::setBindingsCurrentTime):
(WebCore::CSSAnimation::bindingsPlayState const):
(WebCore::CSSAnimation::bindingsPending const):
(WebCore::CSSAnimation::bindingsReady):
(WebCore::CSSAnimation::bindingsFinished):
(WebCore::CSSAnimation::bindingsPlay):
(WebCore::CSSAnimation::bindingsPause):
(WebCore::CSSAnimation::flushPendingStyleChanges const):

animation/CSSAnimation.h:
animation/WebAnimation.h:

(WebCore::WebAnimation::bindingsPlayState const):
(WebCore::WebAnimation::bindingsPending const):
(WebCore::WebAnimation::bindingsReady):
(WebCore::WebAnimation::bindingsFinished):
(WebCore::WebAnimation::bindingsPlay):
(WebCore::WebAnimation::bindingsPause):

animation/WebAnimation.idl:

LayoutTests:

This test now passes reliably.

TestExpectations:

11:51 AM Changeset in webkit [233050] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] unit-tests fail when run from another directory
https://bugs.webkit.org/show_bug.cgi?id=186872

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/loadConfig.py:

(loadBuilderConfig): Add support for passing master_prefix_path.

BuildSlaveSupport/ews-build/loadConfig_unittest.py:

(ConfigDotJSONTest.test_configuration): Set master_prefix_path as current directory.

11:47 AM Changeset in webkit [233049] by jer.noble@apple.com

5 edits in trunk/Source

[Fullscreen] Suspend page (and pause video) while phishing warning is presented
https://bugs.webkit.org/show_bug.cgi?id=186856
<rdar://problem/41212444>

Reviewed by Tim Horton.

Source/WebCore:

Pause the media element when the page is suspended, and unpause when the page resumes.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):

html/HTMLMediaElement.h:

Source/WebKit:

UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _showPhishingAlert]):

11:44 AM Changeset in webkit [233048] by keith_miller@apple.com

5 edits
1 add in trunk

flattenDictionaryStruture needs to zero inline storage.
https://bugs.webkit.org/show_bug.cgi?id=186869

Reviewed by Saam Barati.

JSTests:

stress/flatten-object-zero-unused-inline-properties.js: Added.

Source/JavaScriptCore:

This patch also adds the assetion that unused property storage is
zero or JSValue() to putDirectInternal. Additionally, functions
have been added to $vm that flatten dictionary objects and return
the inline capacity of an object.

runtime/JSObjectInlines.h:

(JSC::JSObject::putDirectInternal):

runtime/Structure.cpp:

(JSC::Structure::flattenDictionaryStructure):

tools/JSDollarVM.cpp:

(JSC::functionInlineCapacity):
(JSC::functionFlattenDictionaryObject):
(JSC::JSDollarVM::finishCreation):

11:42 AM Changeset in webkit [233047] by aakash_jain@apple.com

3 edits in trunk/Tools

Add support for using localhost worker in OpenSource EWS Buildbot
https://bugs.webkit.org/show_bug.cgi?id=186871

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/loadConfig.py:

(loadBuilderConfig): Added a worker named 'local-worker' if use_localhost_worker option is used.

BuildSlaveSupport/ews-build/master.cfg: Check BUILDBOT_TESTING environment variable and use_localhost_worker if so.

11:35 AM Changeset in webkit [233046] by Kocsen Chung

17 edits in tags/Safari-606.1.22/Source/JavaScriptCore

Cherry-pick r233039. rdar://problem/40910419

Use IsoCellSets to track Executables with clearable code.
https://bugs.webkit.org/show_bug.cgi?id=186877

Reviewed by Filip Pizlo.

Here’s an example of the results that this fix may yield:

The workload: load cnn.com, wait for it to fully load, scroll down and up.
Statistics on memory touched and memory freed by VM::deleteAllCode():

Visiting Executables:

Old New

Number of objects visited: 70897 14264
Number of objects with deletable code: 14264 (20.1%) 14264 (100%)
Number of memory pages visited: 3224 1602
Number of memory pages with deletable code: 1602 (49.7%) 1602 (100%)

Visitng UnlinkedFunctionExecutables:

Old New

Number of objects visited: 105454 17231
Number of objects with deletable code: 42319 (20.1%) 17231 (100%)
Number of memory pages visited: 4796 1349
Number of memory pages with deletable code: 4013 (83.7%) 1349 (100%)

The number of objects differ because the old code only visit unlinked

executables indirectly via linked executables, whereas the new behavior visit
all unlinked executables with deletable code directly. This means:

we used to not visit unlinked executables that have not been linked yet i.e. deleteAllCode() may not delete all code (especially code that is not used).
we had to visit all linked executables to check if they of type FunctionExecutable, before going on to visit their unlinked executable, and this includes the ones that do not have deletable code. This means that we would touch more memory in the process.

Both of these these issues are now fixed with the new code.

This code was tested with manually inserted instrumentation to track the above
statistics. It is not feasible to write an automated test for this without
leaving a lot of invasive instrumentation in the code.

bytecode/UnlinkedFunctionExecutable.cpp: (JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):
bytecode/UnlinkedFunctionExecutable.h:
heap/CodeBlockSetInlines.h: (JSC::CodeBlockSet::iterateViaSubspaces):
heap/Heap.cpp: (JSC::Heap::deleteAllCodeBlocks): (JSC::Heap::deleteAllUnlinkedCodeBlocks): (JSC::Heap::deleteUnmarkedCompiledCode): (JSC::Heap::clearUnmarkedExecutables): Deleted. (JSC::Heap::addExecutable): Deleted.
heap/Heap.h:
runtime/DirectEvalExecutable.h:

runtime/ExecutableBase.cpp: (JSC::ExecutableBase::hasClearableCode const):
this is written based on the implementation of ExecutableBase::clearCode().

runtime/ExecutableBase.h:
runtime/FunctionExecutable.h:
runtime/IndirectEvalExecutable.h:
runtime/ModuleProgramExecutable.h:
runtime/ProgramExecutable.h:
runtime/ScriptExecutable.cpp: (JSC::ScriptExecutable::clearCode): (JSC::ScriptExecutable::installCode):
runtime/ScriptExecutable.h: (JSC::ScriptExecutable::finishCreation):
runtime/VM.cpp: (JSC::VM::VM):
runtime/VM.h: (JSC::VM::ScriptExecutableSpaceAndSet::ScriptExecutableSpaceAndSet): (JSC::VM::ScriptExecutableSpaceAndSet::clearableCodeSetFor): (JSC::VM::forEachScriptExecutableSpace): (JSC::VM::UnlinkedFunctionExecutableSpaceAndSet::UnlinkedFunctionExecutableSpaceAndSet): (JSC::VM::UnlinkedFunctionExecutableSpaceAndSet::clearableCodeSetFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:35 AM Changeset in webkit [233045] by aakash_jain@apple.com

2 edits in trunk/Tools

Add force schedulers to OpenSource EWS Buildbot
https://bugs.webkit.org/show_bug.cgi?id=186876

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/loadConfig.py:

(loadBuilderConfig): Added support for ForceScheduler.

11:24 AM Changeset in webkit [233044] by david_fenton@apple.com

6 edits in trunk/Source/WebKit

Unreviewed, rolling out r232989.

Causes API regressions on macOS

Reverted changeset:

"REGRESSION (r231850): Cookie file cannot be read or written
by network process"
https://bugs.webkit.org/show_bug.cgi?id=186806
https://trac.webkit.org/changeset/232989

11:11 AM Changeset in webkit [233043] by Kocsen Chung

1 copy in tags/Safari-606.1.22

Tag Safari-606.1.22.

10:59 AM Changeset in webkit [233042] by bshafiei@apple.com

2 edits in branches/safari-606.1.20.40-branch/Source/WebKit

Cherry-pick r232848. rdar://problem/41120462

Plug-in Process crashing on Mojave (affects Flash, others)
https://bugs.webkit.org/show_bug.cgi?id=186628
<rdar://problem/41120462>

Reviewed by Eric Carlson.

Add the missing “com.apple.security.cs.allow-unsigned-executable-memory” entitlement. Also alphabetize
the entitlements file to make it easier to read.

Configurations/PluginService.entitlements:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:44 AM Changeset in webkit [233041] by rmorisset@apple.com

1 edit
1 move
1 delete in trunk/Tools

[WSL] Merge WSL_type.ott and WSL_exec.ott
https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

I moved the execution rules into WSL_type.ott, that was renamed WSL.ott.
I also changed the execution judgements:

they now emit memory events instead of having an explicit store (so they can be connected later to a memory model)
the environment is now unchangeable (except inside blocks, which are the only place that variable declarations can appear)
various rules were simplified.

WebGPUShadingLanguageRI/SpecWork/WSL.ott: Copied from Tools/WebGPUShadingLanguageRI/SpecWork/WSL_type.ott.
WebGPUShadingLanguageRI/SpecWork/WSL_exec.ott: Removed.
WebGPUShadingLanguageRI/SpecWork/WSL_type.ott: Removed.

8:48 AM Changeset in webkit [233040] by Ryan Haddad

2 edits in trunk/LayoutTests

Update TestExpectations for http/wpt/service-workers/third-party-registration.html.
https://bugs.webkit.org/show_bug.cgi?id=183860

Unreviewed test gardening.

platform/ios-wk2/TestExpectations: Mark as a flaky timeout.

8:09 AM Changeset in webkit [233039] by mark.lam@apple.com

17 edits in trunk/Source/JavaScriptCore

Use IsoCellSets to track Executables with clearable code.
https://bugs.webkit.org/show_bug.cgi?id=186877

Reviewed by Filip Pizlo.

Here’s an example of the results that this fix may yield:

The workload: load cnn.com, wait for it to fully load, scroll down and up.
Statistics on memory touched and memory freed by VM::deleteAllCode():

Visiting Executables:

Old New

Number of objects visited: 70897 14264
Number of objects with deletable code: 14264 (20.1%) 14264 (100%)
Number of memory pages visited: 3224 1602
Number of memory pages with deletable code: 1602 (49.7%) 1602 (100%)

Visitng UnlinkedFunctionExecutables:

Old New

Number of objects visited: 105454 17231
Number of objects with deletable code: 42319 (20.1%) 17231 (100%)
Number of memory pages visited: 4796 1349
Number of memory pages with deletable code: 4013 (83.7%) 1349 (100%)

The number of objects differ because the old code only visit unlinked

executables indirectly via linked executables, whereas the new behavior visit
all unlinked executables with deletable code directly. This means:

we used to not visit unlinked executables that have not been linked yet i.e. deleteAllCode() may not delete all code (especially code that is not used).
we had to visit all linked executables to check if they of type FunctionExecutable, before going on to visit their unlinked executable, and this includes the ones that do not have deletable code. This means that we would touch more memory in the process.

Both of these these issues are now fixed with the new code.

This code was tested with manually inserted instrumentation to track the above
statistics. It is not feasible to write an automated test for this without
leaving a lot of invasive instrumentation in the code.

bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):

bytecode/UnlinkedFunctionExecutable.h:
heap/CodeBlockSetInlines.h:

(JSC::CodeBlockSet::iterateViaSubspaces):

heap/Heap.cpp:

(JSC::Heap::deleteAllCodeBlocks):
(JSC::Heap::deleteAllUnlinkedCodeBlocks):
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::clearUnmarkedExecutables): Deleted.
(JSC::Heap::addExecutable): Deleted.

heap/Heap.h:
runtime/DirectEvalExecutable.h:

runtime/ExecutableBase.cpp:

(JSC::ExecutableBase::hasClearableCode const):

this is written based on the implementation of ExecutableBase::clearCode().

runtime/ExecutableBase.h:
runtime/FunctionExecutable.h:
runtime/IndirectEvalExecutable.h:
runtime/ModuleProgramExecutable.h:
runtime/ProgramExecutable.h:
runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::clearCode):
(JSC::ScriptExecutable::installCode):

runtime/ScriptExecutable.h:

(JSC::ScriptExecutable::finishCreation):

runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:

(JSC::VM::ScriptExecutableSpaceAndSet::ScriptExecutableSpaceAndSet):
(JSC::VM::ScriptExecutableSpaceAndSet::clearableCodeSetFor):
(JSC::VM::forEachScriptExecutableSpace):
(JSC::VM::UnlinkedFunctionExecutableSpaceAndSet::UnlinkedFunctionExecutableSpaceAndSet):
(JSC::VM::UnlinkedFunctionExecutableSpaceAndSet::clearableCodeSetFor):

7:00 AM Changeset in webkit [233038] by commit-queue@webkit.org

2 edits in trunk/Tools

[test262-runner] Improve failures output
https://bugs.webkit.org/show_bug.cgi?id=186858

Patch by Leo Balter <Leo Balter> on 2018-06-21
Reviewed by Michael Saboff.

Scripts/test262/Runner.pm:

(main):
(processResult):

6:57 AM Changeset in webkit [233037] by caitp@igalia.com

2 edits in trunk/Tools

[Tools] add a --debug option to test262/Runner.pm for buildbots
https://bugs.webkit.org/show_bug.cgi?id=186113

Reviewed by Michael Saboff.

test262-runner runs Debug builds by default, but this allows us to be
explicit about it in buildbots.

Scripts/test262/Runner.pm:

(processCLI):

6:37 AM Changeset in webkit [233036] by Michael Catanzaro

2 edits in trunk/Source/WebCore

Bad optional access in WebCore::ContentSecurityPolicySource::portMatches
https://bugs.webkit.org/show_bug.cgi?id=186535

Reviewed by Daniel Bates.

Make sure the ports have explicit values before dereferencing them.

This is hard to test. If the layout test script-src-parsing-implicit-and-explicit-port-number
continues to pass for WebKitLegacy, then I have at least probably not broken anything. To
reproduce the crash in a layout test that I can run, I think I would need to implement
internals.registerDefaultPortForProtocol for modern WebKit, which is too much work for this
crash. Otherwise, we'd need to run the test server on port 80, which would be unfriendly.

page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::portMatches const):

4:03 AM Changeset in webkit [233035] by zandobersek@gmail.com

9 edits in trunk/Source

[GTK] WebDriver: allow applying host-specific TLS certificates for automated sessions
https://bugs.webkit.org/show_bug.cgi?id=186884

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

Add a tuple array input parameter to the StartAutomationSession DBus
message, representing a list of host-and-certificate pairs that have to
be allowed for a given session. This array is then unpacked and used to
fill out the certificates Vector object in the SessionCapabilities
struct.

inspector/remote/RemoteInspector.h: Add a GLib-specific Vector of

String pairs representing hosts and the certificate file paths.

inspector/remote/glib/RemoteInspectorServer.cpp:

Source/WebDriver:

Start handling the 'certificates' capability for the GTK+ port. This is
a list of host-certificate pairs that should be marked as allowed for a
given automation session. This object should be positioned inside the
'webkitgtk:browserOptions' dictionary in the capabilities JSON.

Capabilities.h:
glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::startAutomationSession): Include any
host-certificate pairs in the StartAutomationSession DBus message.

gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
Properly validate the 'certificates' value, if present.
(WebDriver::WebDriverService::platformParseCapabilities const):
Properly parse the 'certificates' value, if present, and extract the
host-certificate pairs.

Source/WebKit:

UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionCreate): Handle any host-certificate pair that's
been set for this session, creating a GTlsCertificate object through
loading from the specified certificate path and marking that certificate
as allowed for the specified host through the
webkit_web_context_allow_tls_certificate_for_host() API.

4:01 AM Changeset in webkit [233034] by Chris Dumez

2 edits in trunk/Source/WebKit

Regression(r226990) : Crash under WebCore::Page::applicationWillResignActive
https://bugs.webkit.org/show_bug.cgi?id=186850
<rdar://problem/37394469>

Reviewed by Eric Carlson.

Make sure m_page is not null before calling applicationWillResignActive(). m_page
gets nulled out when WebPage::close() is called. The crash trace seems to indicate
we're calling applicationWillResignActive() on a Page that is dead since we crash
accessing Page::mainFrame().

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationWillResignActive):

3:14 AM Changeset in webkit [233033] by Fujii Hironori

4 edits in trunk

[GStreamer] ASSERTION FAILED: end.isValid() in PlatformTimeRanges::add
https://bugs.webkit.org/show_bug.cgi?id=186880

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Bug 180253 has added assertions the arugments start and end is
valid MediaTime in PlatformTimeRanges::add. Since then, some
LayoutTests fail due to the assertion failure.

The invalid MediaTime is added into the PlatformTimeRanges in
MediaPlayerPrivateGStreamer::buffered. Before adding MediaTime,
original implementation checks MediaTime::operator bool() returns
true. But, this method returns true if the time value is invalid.
Then, PlatformTimeRanges::add is called with an invalid MediaTime.

No new tests (No behavior change).

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered const): Check
maxTimeLoaded() is valid before adding to timeRanges.

LayoutTests:

platform/gtk/TestExpectations: Removed Crash marks of

compositing/geometry/clipped-video-controller.html,
fast/canvas/webgl/oes-texture-half-float-with-video.html,
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html,
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba5551.html,
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html,
fast/events/media-focus-in-standalone-media-document.html,
fullscreen/video-controls-timeline.html,
http/tests/appcache/video.html, and compositing/video/poster.html.

2:54 AM Changeset in webkit [233032] by Fujii Hironori

4 edits in trunk

[GTK] http/tests/misc/bubble-drag-events.html crashes
https://bugs.webkit.org/show_bug.cgi?id=182352

Reviewed by Carlos Garcia Campos.

Source/WebKit:

PingLoad::didFinish was called twice if it is used with
NetworkDataTaskSoup. PingLoad is not a ref-counted object. It is
destructed when PingLoad::didFinish is called.

PingLoad::didReceiveChallenge calls the ChallengeCompletionHandler
with AuthenticationChallengeDisposition::Cancel to cancel the
challenge and calls PingLoad::didFinish.

NetworkDataTaskSoup::continueAuthenticate calls
didReceiveChallenge with a ChallengeCompletionHandler which calls
didCompleteWithError. PingLoad::didCompleteWithError calls
PingLoad::didFinish.

didCompleteWithError callback should not be called in the
ChallengeCompletionHandler.

NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::continueAuthenticate): Do not call
didFail() in the ChallengeCompletionHandler. Call
invalidateAndCancel() instead.

LayoutTests:

platform/gtk/TestExpectations:

Marked http/tests/misc/bubble-drag-events.html as [ Failure ] not
[ Failure Timeout Crash ].
Unmarked http/tests/misc/cached-scripts.html.

2:27 AM Changeset in webkit [233031] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed WPE gardening. Handle various timeouts by adjusting or
adding the appropriate test expectations.

platform/wpe/TestExpectations:

1:54 AM Changeset in webkit [233030] by Carlos Garcia Campos

4 edits in trunk/Tools

run-gtk-tests (glib/common.py) cannot determine build directory when webKitBranchBuild=true
https://bugs.webkit.org/show_bug.cgi?id=185643

Reviewed by Frédéric Wang.

Check if webKitBranchBuild is true in git config to add the branch name to the build path.

Scripts/webkitpy/common/checkout/scm/git.py:

(Git.read_git_config): Add output_type parameter.
(Git.read_config): Call read_git_config with cws and executive.
(Git._upstream_branch): Use read_config().
(Git._assert_can_squash): Ditto.
(Git.remote_branch_ref): Ditto.

Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(GitSVNTest.test_read_git_config):

glib/common.py:

(get_build_path):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed