Timeline
Jun 28, 2018:
- 10:45 PM Changeset in webkit [233349] by
-
- 8 edits4 adds in trunk
[Web Animations] Using a Web Animation leaks the Document
https://bugs.webkit.org/show_bug.cgi?id=187088
<rdar://problem/41392046>
Reviewed by Dean Jackson.
Source/WebCore:
Test: webanimations/leak-document-with-web-animation.html
We need to ensure that any remaining animation is cleared when the DocumentTimeline is detached from its Document.
We rename WebAnimation::prepareAnimationForRemoval() to WebAnimation::remove() since it really actively disassociates
the animation from its timeline.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::removeAnimationsForElement): We no longer need the call to removeAnimation()
since the new WebAnimation::remove() method will also set the timeline to null which will eventually call
removeAnimation() on the disassociated timeline.
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::remove):
(WebCore::DeclarativeAnimation::prepareAnimationForRemoval): Deleted.
- animation/DeclarativeAnimation.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::detachFromDocument): Call remove() on all known animations.
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::remove): Set the timeline to null to fully disassociate this animation from its timeline.
(WebCore::WebAnimation::setTimeline): Factor the internal timeline-association code out of this JS API method so
that we can call this code without any JS-facing implications.
(WebCore::WebAnimation::setTimelineInternal):
(WebCore::WebAnimation::prepareAnimationForRemoval): Deleted.
- animation/WebAnimation.h:
LayoutTests:
Add a new test that creates an Animation object in JS within an iframe and checks that removing
the iframe clears its Document.
- webanimations/leak-document-with-web-animation-expected.txt: Added.
- webanimations/leak-document-with-web-animation.html: Added.
- webanimations/resources/web-animation-leak-iframe.html: Added.
- 8:45 PM Changeset in webkit [233348] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Out-of-flow positioned height does not necessarily equal to "bottom - top".
https://bugs.webkit.org/show_bug.cgi?id=187168
Reviewed by Antti Koivisto.
According to the spec "For absolutely positioned elements, the used values of the vertical dimensions must satisfy this constraint:
'top' + 'margin-top' + 'border-top-width' + 'padding-top' + 'height' + 'padding-bottom' + 'border-bottom-width' + 'margin-bottom' + 'bottom' = height of containing block"
With a non-auto "height" value, the bottom - top does not necessarily compute to the height of the element.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
- 6:40 PM Changeset in webkit [233347] by
-
- 2 edits in trunk/Source/bmalloc
Disable IsoHeaps when Gigacage is off
https://bugs.webkit.org/show_bug.cgi?id=187160
Reviewed by Saam Barati.
If Gigacage is disabled, it may be due to lack of address space.
Therefore we should also turn off IsoHeaps since it uses more virtual
address space as well.
- bmalloc/IsoTLS.cpp:
(bmalloc::IsoTLS::determineMallocFallbackState):
- 6:37 PM Changeset in webkit [233346] by
-
- 4 edits in trunk/Source/JavaScriptCore
IsoCellSet::sweepToFreeList() not safe when Full GC in process
https://bugs.webkit.org/show_bug.cgi?id=187157
Reviewed by Mark Lam.
- heap/IsoCellSet.cpp:
(JSC::IsoCellSet::sweepToFreeList): Changed the "stale marks logic" to match what
is in MarkedBlock::Handle::specializedSweep where it takes into account whether
or not we are in the process of marking during a full GC.
- heap/MarkedBlock.h:
- heap/MarkedBlockInlines.h:
(JSC::MarkedBlock::Handle::areMarksStaleForSweep): New helper.
- 6:19 PM Changeset in webkit [233345] by
-
- 6 edits in trunk
Find in page for typographic quotes does not find low (German) quotes
https://bugs.webkit.org/show_bug.cgi?id=187164
<rdar://problem/29612785>
Source/WebCore:
Patch by Olivia Barnett <obarnett@apple.com> on 2018-06-28
Reviewed by Tim Horton.
Added additional quote test to LayoutTests/fast/text/find-quotes.html.
Added functionality to replace German quotes when matching.
- editing/TextIterator.cpp:
(WebCore::foldQuoteMark):
(WebCore::foldQuoteMarks):
Source/WTF:
Patch by Olivia Barnett <obarnett@apple.com> on 2018-06-28
Reviewed by Tim Horton.
Added Unicode definitions for German quotation marks.
- wtf/unicode/CharacterNames.h:
LayoutTests:
Patch by Olivia Barnett <obarnett@apple.com> on 2018-06-28
Reviewed by Tim Horton.
Added additional test for German quotes.
- fast/text/find-quotes.html:
- 6:00 PM Changeset in webkit [233344] by
-
- 2 edits in trunk/LayoutTests
[iOS] Unreviewed test gardening.
- platform/ios/TestExpectations:
- 5:53 PM Changeset in webkit [233343] by
-
- 1 edit111 adds in trunk/LayoutTests
[LFC] Add block formatting only test cases
https://bugs.webkit.org/show_bug.cgi?id=187162
Reviewed by Antti Koivisto.
These tests are expected to generate the same tree output on every platform (no text, strictly block only).
- fast/block/block-only/absolute-auto-with-sibling-margin-bottom-expected.txt: Added.
- fast/block/block-only/absolute-auto-with-sibling-margin-bottom.html: Added.
- fast/block/block-only/absolute-height-stretch-expected.txt: Added.
- fast/block/block-only/absolute-height-stretch.html: Added.
- fast/block/block-only/absolute-left-auto-expected.txt: Added.
- fast/block/block-only/absolute-left-auto.html: Added.
- fast/block/block-only/absolute-left-right-top-bottom-auto-expected.txt: Added.
- fast/block/block-only/absolute-left-right-top-bottom-auto.html: Added.
- fast/block/block-only/absolute-nested-expected.txt: Added.
- fast/block/block-only/absolute-nested.html: Added.
- fast/block/block-only/absolute-nested2-expected.txt: Added.
- fast/block/block-only/absolute-nested2.html: Added.
- fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context-expected.txt: Added.
- fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context.html: Added.
- fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context2-expected.txt: Added.
- fast/block/block-only/absolute-position-when-containing-block-is-not-in-the-formatting-context2.html: Added.
- fast/block/block-only/absolute-simple-expected.txt: Added.
- fast/block/block-only/absolute-simple.html: Added.
- fast/block/block-only/absolute-width-shrink-to-fit-expected.txt: Added.
- fast/block/block-only/absolute-width-shrink-to-fit.html: Added.
- fast/block/block-only/absolute-width-stretch-expected.txt: Added.
- fast/block/block-only/absolute-width-stretch.html: Added.
- fast/block/block-only/absolute-with-static-block-position-nested-expected.txt: Added.
- fast/block/block-only/absolute-with-static-block-position-nested.html: Added.
- fast/block/block-only/almost-intruding-left-float-simple-expected.txt: Added.
- fast/block/block-only/almost-intruding-left-float-simple.html: Added.
- fast/block/block-only/border-simple-expected.txt: Added.
- fast/block/block-only/border-simple.html: Added.
- fast/block/block-only/fixed-nested-expected.txt: Added.
- fast/block/block-only/fixed-nested.html: Added.
- fast/block/block-only/float-left-when-container-has-padding-margin-expected.txt: Added.
- fast/block/block-only/float-left-when-container-has-padding-margin.html: Added.
- fast/block/block-only/floating-box-clear-both-simple-expected.txt: Added.
- fast/block/block-only/floating-box-clear-both-simple.html: Added.
- fast/block/block-only/floating-box-clear-right-simple-expected.txt: Added.
- fast/block/block-only/floating-box-clear-right-simple.html: Added.
- fast/block/block-only/floating-box-left-and-right-multiple-expected.txt: Added.
- fast/block/block-only/floating-box-left-and-right-multiple-with-top-offset-expected.txt: Added.
- fast/block/block-only/floating-box-left-and-right-multiple-with-top-offset.html: Added.
- fast/block/block-only/floating-box-left-and-right-multiple.html: Added.
- fast/block/block-only/floating-box-right-simple-expected.txt: Added.
- fast/block/block-only/floating-box-right-simple.html: Added.
- fast/block/block-only/floating-box-with-clear-siblings-expected.txt: Added.
- fast/block/block-only/floating-box-with-clear-siblings.html: Added.
- fast/block/block-only/floating-box-with-clear-simple-expected.txt: Added.
- fast/block/block-only/floating-box-with-clear-simple.html: Added.
- fast/block/block-only/floating-box-with-new-formatting-context-expected.txt: Added.
- fast/block/block-only/floating-box-with-new-formatting-context.html: Added.
- fast/block/block-only/floating-box-with-relative-positioned-sibling-expected.txt: Added.
- fast/block/block-only/floating-box-with-relative-positioned-sibling.html: Added.
- fast/block/block-only/floating-left-right-simple-expected.txt: Added.
- fast/block/block-only/floating-left-right-simple.html: Added.
- fast/block/block-only/floating-left-right-with-all-margins-expected.txt: Added.
- fast/block/block-only/floating-left-right-with-all-margins.html: Added.
- fast/block/block-only/floating-lefts-and-rights-simple-expected.txt: Added.
- fast/block/block-only/floating-lefts-and-rights-simple.html: Added.
- fast/block/block-only/floating-multiple-lefts-expected.txt: Added.
- fast/block/block-only/floating-multiple-lefts-in-body-expected.txt: Added.
- fast/block/block-only/floating-multiple-lefts-in-body.html: Added.
- fast/block/block-only/floating-multiple-lefts-multiple-lines-expected.txt: Added.
- fast/block/block-only/floating-multiple-lefts-multiple-lines.html: Added.
- fast/block/block-only/floating-multiple-lefts.html: Added.
- fast/block/block-only/floating-with-new-block-formatting-context-expected.txt: Added.
- fast/block/block-only/floating-with-new-block-formatting-context.html: Added.
- fast/block/block-only/margin-collapse-bottom-bottom-expected.txt: Added.
- fast/block/block-only/margin-collapse-bottom-bottom.html: Added.
- fast/block/block-only/margin-collapse-bottom-nested-expected.txt: Added.
- fast/block/block-only/margin-collapse-bottom-nested.html: Added.
- fast/block/block-only/margin-collapse-first-last-are-floating-expected.txt: Added.
- fast/block/block-only/margin-collapse-first-last-are-floating.html: Added.
- fast/block/block-only/margin-collapse-simple-expected.txt: Added.
- fast/block/block-only/margin-collapse-simple.html: Added.
- fast/block/block-only/margin-collapse-top-nested-expected.txt: Added.
- fast/block/block-only/margin-collapse-top-nested.html: Added.
- fast/block/block-only/margin-collapse-when-child-has-padding-border-expected.txt: Added.
- fast/block/block-only/margin-collapse-when-child-has-padding-border.html: Added.
- fast/block/block-only/margin-collapse-with-block-formatting-context-expected.txt: Added.
- fast/block/block-only/margin-collapse-with-block-formatting-context.html: Added.
- fast/block/block-only/margin-collapse-with-block-formatting-context2-expected.txt: Added.
- fast/block/block-only/margin-collapse-with-block-formatting-context2.html: Added.
- fast/block/block-only/margin-left-right-sizing-expected.txt: Added.
- fast/block/block-only/margin-left-right-sizing-out-of-flow-expected.txt: Added.
- fast/block/block-only/margin-left-right-sizing-out-of-flow.html: Added.
- fast/block/block-only/margin-left-right-sizing.html: Added.
- fast/block/block-only/margin-propagation-simple-content-height-expected.txt: Added.
- fast/block/block-only/margin-propagation-simple-content-height.html: Added.
- fast/block/block-only/margin-sibling-collapse-propagated-expected.txt: Added.
- fast/block/block-only/margin-sibling-collapse-propagated.html: Added.
- fast/block/block-only/margin-simple-expected.txt: Added.
- fast/block/block-only/margin-simple.html: Added.
- fast/block/block-only/negative-margin-simple-expected.txt: Added.
- fast/block/block-only/negative-margin-simple.html: Added.
- fast/block/block-only/padding-nested-expected.txt: Added.
- fast/block/block-only/padding-nested.html: Added.
- fast/block/block-only/padding-simple-expected.txt: Added.
- fast/block/block-only/padding-simple.html: Added.
- fast/block/block-only/relative-auto-expected.txt: Added.
- fast/block/block-only/relative-auto-with-parent-offset-expected.txt: Added.
- fast/block/block-only/relative-auto-with-parent-offset.html: Added.
- fast/block/block-only/relative-auto.html: Added.
- fast/block/block-only/relative-bottom-expected.txt: Added.
- fast/block/block-only/relative-bottom.html: Added.
- fast/block/block-only/relative-position-when-containing-block-is-not-in-the-formatting-context-expected.txt: Added.
- fast/block/block-only/relative-position-when-containing-block-is-not-in-the-formatting-context.html: Added.
- fast/block/block-only/relative-right-expected.txt: Added.
- fast/block/block-only/relative-right.html: Added.
- fast/block/block-only/relative-siblings-expected.txt: Added.
- fast/block/block-only/relative-siblings.html: Added.
- fast/block/block-only/relative-simple-expected.txt: Added.
- fast/block/block-only/relative-simple.html: Added.
- 5:05 PM Changeset in webkit [233342] by
-
- 3 edits in trunk/Source/WebKit
Make sure the WebResourceLoadStatisticsStore gets destroyed on the main thread
https://bugs.webkit.org/show_bug.cgi?id=187143
Reviewed by Youenn Fablet.
Have WebResourceLoadStatisticsStore subclass ThreadSafeRefCounted<WebResourceLoadStatisticsStore, WTF::DestructionThread::Main>
instead of IPC::Connection::WorkQueueMessageReceiver. This makes sure that the WebResourceLoadStatisticsStore
objects get destroyed on the main thread, even if the last ref was held by a background thread.
Also, methods called by IPC are now called on the main thread instead of the background queue. I think it is clearer for all
of WebResourceLoadStatisticsStore usage to be on the main thread. Expensive work is still done on the background queue, inside
the persistent / memory store classes.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener):
(WebKit::WebResourceLoadStatisticsStore::processWillOpenConnection):
(WebKit::WebResourceLoadStatisticsStore::processDidCloseConnection):
- UIProcess/WebResourceLoadStatisticsStore.h:
- 4:57 PM Changeset in webkit [233341] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (233281): fast/dom/location-new-window-no-crash.html and some other tests are timing out
https://bugs.webkit.org/show_bug.cgi?id=187156
Reviewed by Zalan Bujtas.
We need still need to re-enable memory cache client calls even when not doing other post-resolution callbacks.
- style/StyleTreeResolver.cpp:
(WebCore::Style::memoryCacheClientCallsResumeQueue):
Add a separate queue for this.
(WebCore::Style::suspendMemoryCacheClientCalls):
(WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler):
- 4:57 PM Changeset in webkit [233340] by
-
- 2 edits in trunk/Source/WebKit
Add nullptr check for xpc_connection_t in AuthenticationManager::initializeConnection
https://bugs.webkit.org/show_bug.cgi?id=187110
<rdar://problem/41536815>
Reviewed by Brent Fulgham.
In some rare cases as shown by crash tracers that the passed xpc_connection_t object could be nullptr,
and xpc_connection_set_event_handler won't do the nullptr check on its parameters. Therefore, we should
do it by ourselves.
- Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
(WebKit::AuthenticationManager::initializeConnection):
- UIProcess/Authentication/cocoa/AuthenticationChallengeProxyCocoa.mm:
(WebKit::AuthenticationChallengeProxy::sendClientCertificateCredentialOverXpc const):
- 4:52 PM Changeset in webkit [233339] by
-
- 18 edits in trunk
[iOS] DataTransfer.getData always returns the empty string when dropping text
https://bugs.webkit.org/show_bug.cgi?id=187130
<rdar://problem/41014117>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Currently, DataTransfer.getData() always returns the empty string on drop. This is because all data on drop is
backed by local files in the temporary directory, so the number of files is never 0; this, combined with the
fact that WebKit will suppress access to the DataTransfer object if there is one or more file in the pasteboard,
means that getData() never works for drag and drop on iOS at the moment. To fix this, we need to know whether a
dropped item provider is a file.
Ideally, we'd have a flag to tell us whether or not an NSItemProvider being dropped is a file, or instead just
inline data - in fact, this flag already exists in the form of UIPreferredPresentationStyle. Unfortunately, not
all apps that vend draggable files specify this, so we can't simply ask the item provider whether it's intended
to be a file. As a workaround, we can use several heuristics to determine the "file content state" of the drag
pasteboard on iOS (see below for more details).
This patch adds some plumbing through the client layers to grab a list of item information describing each
dropped item provider on iOS. Using this information, we tweak the logic in Pasteboard::fileContentState to make
an educated guess at whether or not the pasteboard really contains files; if we determine that the pasteboard
probably contains no files, we'll allow DataTransfer.getData() to retrieve information from the pasteboard.
Otherwise, if the pasteboard may contain files, we'll fall back to our current behavior of including the "Files"
type in DataTransfer.types and allowing the page to grab file data using DataTransfer.files or
DataTransfer.items.
Tests: DataInteractionTests.DataTransferGetDataReadPlainAndRichText
DataInteractionTests.DataTransferSuppressGetDataDueToPresenceOfTextFile
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::filesFromPasteboardAndItemList const):
Check Pasteboard::fileContentState() to ensure that we don't expose files when DataTransfer.types does not
contain the "Files" type, and vice versa, and DataTranser.files is also empty in this case.
- dom/DataTransferItemList.cpp:
- platform/PasteboardItemInfo.h:
Add a couple of additional members to PasteboardItemInfo: suggestedFileName and hasDeclaredNonTextType, a flag
that indicates whether or not the pasteboard item has a type representation that is a declared type, but is not
a text type (i.e. does not conform to "public.text", "public.url", or rich text format with attachment types).
(WebCore::PasteboardItemInfo::encode const):
(WebCore::PasteboardItemInfo::decode):
- platform/PasteboardStrategy.h:
- platform/PlatformPasteboard.h:
- platform/cocoa/PasteboardCocoa.mm:
(WebCore::Pasteboard::fileContentState):
Instead of always considering a dropped item provider on iOS to represent a file, only do so if at least one of
the following conditions are met:
- The drop session contains multiple item providers (flocking text selections is a very rare use case).
- The item provider was explicitly marked as an attachment.
- The item provider has a suggested file name.
- The item provider has any other content that is not text.
In the case where none of the above conditions are met, the item provider (if it ends up being a file) is
essentially indistinguishable from inline data. An example of this is dropping a plain text file that is
unnamed, with no presentation style, and alongside no other items nor other known type representations. These
are cases in which whether the item is treated as a file or as inline data is (hopefully) irrelevant.
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::allPasteboardItemInfo):
(WebCore::PlatformPasteboard::informationForItemAtIndex):
Source/WebKit:
Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
- UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:
(WebKit::WebPasteboardProxy::allPasteboardItemInfo):
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::allPasteboardItemInfo):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Source/WebKitLegacy/mac:
Add plumbing to grab information for each item in the pasteboard. See WebCore ChangeLog for more detail.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::allPasteboardItemInfo):
Tools:
Add 2 new API tests to verify that:
- When dropping an item with text, markup, and URL representations, the page is allowed to get "text/html",
"text/plain" and "text/uri-list" data.
- Adding a suggested name to a plain text item causes WebKit to treat it as a file, and suppress access to
DataTransfer.getData().
Additionally tweaks a couple of existing API tests. Namely, in two API tests
(ExternalSourceOverrideDropFileUpload and ExternalSourceHTMLToUploadArea) only a markup string is dropped, and
we previously expected to handle the drop as a file. To allow this test to continue serving its purpose, tweak
them such that the registered items appear to be file-backed (i.e. by adding a suggested filename in one of the
tests, and specifying UIPreferredPresentationStyleAttachment in the other).
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- 4:23 PM Changeset in webkit [233338] by
-
- 2 edits in trunk/Source/WebCore
Don't force black text when TextIndicator draws backgrounds or all content.
https://bugs.webkit.org/show_bug.cgi?id=187161
rdar://problem/40434644
Reviewed by Tim Horton.
- page/TextIndicator.cpp:
(WebCore::snapshotOptionsForTextIndicatorOptions):
Only set SnapshotOptionsForceBlackText when TextIndicatorOptionRespectTextColor and
TextIndicatorOptionPaintBackgrounds are not set.
- 4:01 PM Changeset in webkit [233337] by
-
- 7 edits in tags/Safari-606.1.23.1/Source
Versioning.
- 3:58 PM Changeset in webkit [233336] by
-
- 1 copy in tags/Safari-606.1.23.1
New tag.
- 3:45 PM Changeset in webkit [233335] by
-
- 2 edits in trunk/Source/WebKit
Early return when handling fetch event in case service worker origin does not match origin of a subresource load
https://bugs.webkit.org/show_bug.cgi?id=187153
<rdar://problem/41329832>
Reviewed by Chris Dumez.
Stop crashing the service worker process in case a subresource load origin is not matching a service worker origin.
Instead, just return early so that the load will be handled by the network process.
Keep crashing in case a navigation load is not matching its service worker origin.
Add more logging to help with the debugging.
- WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::logValidFetchError):
(WebKit::isValidFetch):
(WebKit::WebSWContextManagerConnection::startFetch):
- 3:38 PM Changeset in webkit [233334] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r213000): copy from Search results content view broken
https://bugs.webkit.org/show_bug.cgi?id=187020
<rdar://problem/40928766>
Reviewed by Timothy Hatcher.
Since WI._copy listens for a copy event from the document, it is called
after CodeMirror handles the event and sets clipboard data. If WI._copy
finds a custom copy handler to call, that handler can determine whether
to overwrite the current clipboard data, or leave it alone.
SearchTabContentView's handleCopyEvent method should return early if the
content tree outline doesn't have the focus. This prevents the selection
in the TextEditor from being overwritten, without any special knowledge of
the content browser's current view.
- UserInterface/Views/SearchTabContentView.js:
(WI.SearchTabContentView.prototype.handleCopyEvent):
- 3:14 PM Changeset in webkit [233333] by
-
- 3 edits in trunk/Websites/perf.webkit.org
Fix a bug ComponentBase that wrong content template may be used.
https://bugs.webkit.org/show_bug.cgi?id=187159
Reviewed by Ryosuke Niwa.
ComponentBase uses '_parsed' to mark whether content and style templates of a class
is parsed. However, derived class parsing will be skipped as 'Derive._parsed' is available
via prototype chain whenever the base class is parsed.
- browser-tests/component-base-tests.js: Added unit tests.
- public/v3/components/base.js: Added 'hasOwnProperty' to make sure current class is parsed.
(ComponentBase.prototype._ensureShadowTree):
- 3:13 PM Changeset in webkit [233332] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r226652.
https://bugs.webkit.org/show_bug.cgi?id=180827
"PlatformInfo should never be instantiated in isolation. So, PlatformInfo should
not have default argument values. The preferred way to get a PlatformInfo object
is to instantiate a Host object." (Requested by dbates).
Reverted changeset:
"[webkitpy] PlatformInfo should have default argument for casual use"
https://bugs.webkit.org/show_bug.cgi?id=180827
- 2:55 PM Changeset in webkit [233331] by
-
- 2 edits in trunk/Source/WebKit
Fullscreen exits when placeholder is removed then added during a single runloop.
https://bugs.webkit.org/show_bug.cgi?id=187079
Patch by Jeremy Jones <jeremyj@apple.com> on 2018-06-28
Reviewed by Jer Noble.
Instead of closing fullscreen as soon as the placeholder is removed from the view hierarchy,
give the placeholder until the next runloop to be re-added to the view hierarchy.
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController placeholderWillMoveToSuperview:]):
- 2:54 PM Changeset in webkit [233330] by
-
- 2 edits in trunk/Tools
Try to address test failures on the bots.
Allow the test to distinguish between a failure to find the variable, and an error
reporting vector capacity.
- lldb/lldb_webkit_unittest.py:
(TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
(TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
- 2:48 PM Changeset in webkit [233329] by
-
- 7 edits in trunk
Find on page selection color isn't adapted for dark mode.
https://bugs.webkit.org/show_bug.cgi?id=187072
Source/WebCore:
Unreviewed, revert part of r233280.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Use pure yellow again.
LayoutTests:
rdar://problem/40354841
Unreviewed test gardening.
- fast/css/apple-system-control-colors-expected.txt: Use pure yellow for find.
- fast/text/mark-matches-broken-line-rendering-expected.html:
- fast/text/mark-matches-rendering-expected.html:
Use -apple-system-find-highlight-background to work on all macOS versions.
- platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt: Use pure yellow for find.
- 2:23 PM Changeset in webkit [233328] by
-
- 3 edits in trunk/Source/WebKit
Handle the case of registerMDNSNameCallback called several times
https://bugs.webkit.org/show_bug.cgi?id=187150
<rdar://problem/41329832>
Reviewed by Eric Carlson.
This is a speculative fix on the basis that registerMDNSNameCallback may be called several times.
In that case, we would have freed the context after the first call and would reuse it for the second call.
Instead, keep a map of pending requests and pass to registerMDNSNameCallback an identifier to that map.
If the map has no value for that identifier, return early.
- NetworkProcess/webrtc/NetworkMDNSRegister.cpp:
(WebKit::NetworkMDNSRegister::~NetworkMDNSRegister):
(WebKit::pendingRegistrationRequests):
(WebKit::registerMDNSNameCallback):
(WebKit::NetworkMDNSRegister::clearPendingRequests):
(WebKit::NetworkMDNSRegister::registerMDNSName):
- NetworkProcess/webrtc/NetworkMDNSRegister.h:
(): Deleted.
- 2:21 PM Changeset in webkit [233327] by
-
- 4 edits in trunk/Source/WebCore/PAL
Build fix (2) after r233266
https://bugs.webkit.org/show_bug.cgi?id=187024
<rdar://problem/39759057>
Unreviewed build fix.
- pal/cf/CoreMediaSoftLink.cpp: Distinguish between IOS and MINIMAL_SIMULATOR.
- pal/cf/CoreMediaSoftLink.h: Ditto.
- pal/spi/cocoa/LaunchServicesSPI.h: LSApplicationProxy should be conditionalized on HAVE(APP_LINKS).
- 2:15 PM Changeset in webkit [233326] by
-
- 3 edits in trunk/Websites/perf.webkit.org
MeasurementSetAnalyzer should check triggerable availability before creating confirming A/B tests.
https://bugs.webkit.org/show_bug.cgi?id=187028
Reviewed by Ryosuke Niwa.
If the triggerable is not available, MeasurmentSetAnalyzer should only create analysis task without
confirming A/B tests.
- tools/js/measurement-set-analyzer.js: Added logic to check triggerable availability.
(MeasurementSetAnalyzer.prototype.async._analyzeMeasurementSet):
(MeasurementSetAnalyzer):
- unit-tests/measurement-set-analyzer-tests.js: Updated unit tests and added a new unit test for this change.
- 2:13 PM Changeset in webkit [233325] by
-
- 10 edits in trunk
[Web Animations] Make imported/mozilla/css-animations/test_animation-starttime.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=183834
<rdar://problem/40997932>
Reviewed by Dean Jackson.
LayoutTests/imported/mozilla:
Mark progressions in the Mozilla CSS Animations tests.
- css-animations/test_animation-starttime-expected.txt:
Source/WebCore:
We need to run pending tasks in the "update animations" procedure to ensure that the start time has been set
to a different time than the timeline time at the time the animation was asked to play(). This ensure the
timeline current time has progressed and can be queried to a different value in a requestAnimationFrame()
callback.
When invalidating events, we need to make sure we disregard instances when an animation has and is still pending
so that we wait until we change the pending state to work out which events to enqueue.
- animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::updateAnimations):
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::updatePendingTasks):
(WebCore::WebAnimation::timeToNextRequiredTick const):
(WebCore::WebAnimation::runPendingTasks):
- animation/WebAnimation.h:
LayoutTests:
This test now passes reliably so we remove any specific expectation. Another test needed to be modified to account for
the pending state being updated at a different time, so we just wait a frame to ensure the animation is started.
- TestExpectations:
- compositing/visible-rect/animated.html:
- 2:00 PM Changeset in webkit [233324] by
-
- 4 edits in trunk/Source/WebCore
Release assert in ScriptController::canExecuteScripts via WebCore::SVGUseElement::insertedIntoAncestor
https://bugs.webkit.org/show_bug.cgi?id=187137
<rdar://problem/41081885>
Reviewed by Zalan Bujtas.
The bug was caused by SVGUseElement::notifyFinished firing a DOM event via SVGUseElement::updateExternalDocument
inside SVGUseElement::insertedIntoAncestor. Ideally, we make every call to notifyFinished asynchronous
but simply delay the call to updateExternalDocument() until didFinishInsertingNode() for now.
No new tests since the failure is caught with the newly added assertion in notifyFinished by existing SVG tests
such as svg/batik/filters/filterRegions.svg and svg/batik/text/smallFonts.svg. Unfortunately, I could not
construct a test case which hits this release assertion since the real crash happens when the cached resource
had an error but in the all cases I could find, the resource response with an error results in a reload or
an asynchronous failure callback.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::didAddClient): Added a FIXME.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::insertedIntoAncestor): Delay the call to updateExternalDocument.
(WebCore::SVGUseElement::didFinishInsertingNode): Invoke updateExternalDocument.
(WebCore::SVGUseElement::notifyFinished): Added an assertion.
- svg/SVGUseElement.h:
- 1:59 PM Changeset in webkit [233323] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed attempt to fix Win Cairo build after r233310.
- UIProcess/WebResourceLoadStatisticsStore.h:
- 1:58 PM Changeset in webkit [233322] by
-
- 2 edits in trunk/Tools
Teach Windows EWS bots to use WEBKIT_API_KEY.
- 1:52 PM Changeset in webkit [233321] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed attempt to fix Win Cairo build after r233310.
- UIProcess/WebResourceLoadStatisticsStore.h:
- 1:17 PM Changeset in webkit [233320] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r233309.
Invalidates previous database model without versioning
Reverted changeset:
"Fix encoding / decoding issues in ResourceLoadStatistics"
https://bugs.webkit.org/show_bug.cgi?id=186890
https://trac.webkit.org/changeset/233309
- 1:09 PM Changeset in webkit [233319] by
-
- 2 edits in trunk/Source/WebKit
Split memory store logic out of WebResourceLoadStatisticsStore to clarify threading model
https://bugs.webkit.org/show_bug.cgi?id=187055
<rdar://problem/41584026>
Unreviewed, temporarily disable main thread assertion added to flushAndDestroyPersistentStore()
in r233310, until Bug 187143 is fixed.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
- 12:52 PM Changeset in webkit [233318] by
-
- 5 edits in trunk/Tools
[ews-build] Add support for WebKitPy-Tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187148
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/factories.py: Added WebKitPyFactory.
- BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPyTests.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- BuildSlaveSupport/ews-build/config.json: Updated to use CamelCase.
- 12:42 PM Changeset in webkit [233317] by
-
- 2 edits1 add in trunk/Source/WebKit
Add sandbox to microdone plugin
https://bugs.webkit.org/show_bug.cgi?id=187149
rdar://problem/41538057
Reviewed by Brent Fulgham.
- Resources/PlugInSandboxProfiles/cn.microdone.cmb.safari: Added.
- WebKit.xcodeproj/project.pbxproj:
- 12:14 PM Changeset in webkit [233316] by
-
- 2 edits in trunk/Source/WebKit
Web Inspector: REGRESSION(r223770): "Open Link" context menu action on a linkified URL doesn't work
https://bugs.webkit.org/show_bug.cgi?id=187146
<rdar://problem/41369591>
Reviewed by Joseph Pecoraro.
When Web Inspector's page receives a navigation request, it's supposed to redirect any
non-Inspector navigations to be loaded in the inspected page. When I refactored to use
modern a policy delegate, the one line that redirects the loads was left out.
No new tests, because inspector tests can't navigate the inspector or inspected pages.
- UIProcess/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webView:decidePolicyForNavigationAction:decisionHandler:]):
- 11:51 AM Changeset in webkit [233315] by
-
- 6 edits in trunk/Source/WebCore
Focus ring color does not honor dark mode or system accent color.
https://bugs.webkit.org/show_bug.cgi?id=187144
rdar://problem/41105081
Reviewed by Tim Horton.
Pass the focus ring color through to the GraphicsContext methods that draw it.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::drawFocusRingAtTime):
(WebCore::drawFocusRing):
(WebCore::drawFocusRingToContext):
(WebCore::drawFocusRingToContextAtTime):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::focusRingColor): Deleted.
- platform/mac/ThemeMac.mm:
(WebCore::drawCellFocusRingWithFrameAtTime):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::paintFocusRing):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing):
- 11:36 AM Changeset in webkit [233314] by
-
- 2 edits in trunk/Source/WebKit
Crash when _topConstraint is null in element fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=187075
Patch by Jeremy Jones <jeremyj@apple.com> on 2018-06-28
Reviewed by Eric Carlson.
NSArray can't contain a null pointer, so check for null before creating an array from a pointer.
Use the recommended +deactivateConstraints: instead of -removeConstraints:.
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController showUI]):
(-[WKFullScreenViewController hideUI]):
- 10:35 AM Changeset in webkit [233313] by
-
- 2 edits in trunk/Tools
Fix the iOS build following r233299
(https://bugs.webkit.org/show_bug.cgi?id=183744)
Only build lldbWebKitTester on Mac as that is the only supported platform at the time of writing.
- Makefile:
- 10:24 AM Changeset in webkit [233312] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening; media/video-buffering-allowed.html is flakey due to not completing in time.
Remove the artificial early timeout (1s) in this test.
- media/video-buffering-allowed.html:
- 10:12 AM Changeset in webkit [233311] by
-
- 3 edits2 adds in trunk
REGRESSION (r232040): Cursor jumping in Safari text fields
https://bugs.webkit.org/show_bug.cgi?id=187142
<rdar://problem/41397577>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-06-28
Reviewed by Tim Horton.
Source/WebCore:
r232040 enabled click events to fire on nodes that are already being edited in
iOS. This resulted FrameSelection::setSelection being called twice. One call
originated from the UIWKTextInteractionAssistant, which snaps the caret to word
boundaries. The other call originates from handleMousePressEvent in EventHandler,
and uses character boundaries. Consequently, we see the caret jumping around.
To fix this issue, an early return was added in the handleMousePressEvent
codepath, which prevents FrameSelection::setSelection from being called when
clicking on a node that is already being edited. This ensures that the
UIWKTextInteractionAssistant codepath is the only influence on the caret position.
Test: fast/events/ios/click-selectionchange-once.html
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEventSingleClick):
LayoutTests:
Added test to ensure that the 'selectionchange' event is only fired once per
click in an editable node.
- fast/events/ios/click-selectionchange-once-expected.txt: Added.
- fast/events/ios/click-selectionchange-once.html: Added.
- 10:07 AM Changeset in webkit [233310] by
-
- 9 edits1 move2 adds in trunk/Source/WebKit
Split memory store logic out of WebResourceLoadStatisticsStore to clarify threading model
https://bugs.webkit.org/show_bug.cgi?id=187055
<rdar://problem/41584026>
Reviewed by Brent Fulgham.
Split memory store logic out of WebResourceLoadStatisticsStore and into a ResourceLoadStatisticsMemoryStore class
to clarify the threading model. Previously, some of the methods of the WebResourceLoadStatisticsStore had to be
called on the main thread and some of them on the background queue, which was confusing and error prone. Now,
all WebResourceLoadStatisticsStore methods (except for IPC ones which will be addressed in a follow-up) are called
on the main thread. The ResourceLoadStatisticsMemoryStore objects is constructed / used and destroyed on the
background queue, similarly to the ResourceLoadStatisticsPersistentStore. The WebResourceLoadStatisticsStore
objects merely proxies calls from WebKit to those persistent / memory stores and takes care of hopping back and
forth between the background thread and the work queue.
While spliting code code, I found several instances where we were calling completion handlers on the wrong thread.
I fixed those in this patch now that the model is clearer.
We can likely clean up (organize the code a bit better) in a follow-up). This patch takes care of splitting the
code as it was. Code that was called on the background queue was moved to ResourceLoadStatisticsMemoryStore class
and code that was called on the main thread stays in WebResourceLoadStatisticsStore.
- CMakeLists.txt:
- UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm: Renamed from Source/WebKit/UIProcess/Cocoa/WebResourceLoadStatisticsStoreCocoa.mm.
(WebKit::ResourceLoadStatisticsMemoryStore::registerUserDefaultsIfNeeded):
- UIProcess/ResourceLoadStatisticsMemoryStore.cpp: Added.
(WebKit::appendWithDelimiter):
(WebKit::OperatingDate::fromWallTime):
(WebKit::OperatingDate::today):
(WebKit::OperatingDate::secondsSinceEpoch const):
(WebKit::OperatingDate::operator== const):
(WebKit::OperatingDate::operator< const):
(WebKit::OperatingDate::operator<= const):
(WebKit::OperatingDate::OperatingDate):
(WebKit::mergeOperatingDates):
(WebKit::pruneResources):
(WebKit::computeImportance):
(WebKit::ResourceLoadStatisticsMemoryStore::ResourceLoadStatisticsMemoryStore):
(WebKit::ResourceLoadStatisticsMemoryStore::~ResourceLoadStatisticsMemoryStore):
(WebKit::ResourceLoadStatisticsMemoryStore::setPersistentStorage):
(WebKit::ResourceLoadStatisticsMemoryStore::calculateAndSubmitTelemetry):
(WebKit::ResourceLoadStatisticsMemoryStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::ResourceLoadStatisticsMemoryStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::ResourceLoadStatisticsMemoryStore::setShouldSubmitTelemetry):
(WebKit::ResourceLoadStatisticsMemoryStore::removeDataRecords):
(WebKit::ResourceLoadStatisticsMemoryStore::recursivelyGetAllDomainsThatHaveRedirectedToThisDomain):
(WebKit::ResourceLoadStatisticsMemoryStore::markAsPrevalentIfHasRedirectedToPrevalent):
(WebKit::ResourceLoadStatisticsMemoryStore::processStatisticsAndDataRecords):
(WebKit::ResourceLoadStatisticsMemoryStore::hasStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::requestStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::requestStorageAccessUnderOpener):
(WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsMemoryStore::grandfatherExistingWebsiteData):
(WebKit::ResourceLoadStatisticsMemoryStore::setResourceLoadStatisticsDebugMode):
(WebKit::ResourceLoadStatisticsMemoryStore::scheduleStatisticsProcessingRequestIfNecessary):
(WebKit::ResourceLoadStatisticsMemoryStore::cancelPendingStatisticsProcessingRequest):
(WebKit::ResourceLoadStatisticsMemoryStore::logFrameNavigation):
(WebKit::ResourceLoadStatisticsMemoryStore::logUserInteraction):
(WebKit::ResourceLoadStatisticsMemoryStore::logNonRecentUserInteraction):
(WebKit::ResourceLoadStatisticsMemoryStore::clearUserInteraction):
(WebKit::ResourceLoadStatisticsMemoryStore::hasHadUserInteraction):
(WebKit::ResourceLoadStatisticsMemoryStore::setPrevalentResource):
(WebKit::ResourceLoadStatisticsMemoryStore::isPrevalentResource const):
(WebKit::ResourceLoadStatisticsMemoryStore::isVeryPrevalentResource const):
(WebKit::ResourceLoadStatisticsMemoryStore::isRegisteredAsSubFrameUnder):
(WebKit::ResourceLoadStatisticsMemoryStore::isRegisteredAsRedirectingTo):
(WebKit::ResourceLoadStatisticsMemoryStore::clearPrevalentResource):
(WebKit::ResourceLoadStatisticsMemoryStore::setGrandfathered):
(WebKit::ResourceLoadStatisticsMemoryStore::isGrandfathered const):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubframeUnderTopFrameOrigin):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubresourceUnderTopFrameOrigin):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubresourceUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsMemoryStore::setSubresourceUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsMemoryStore::setTopFrameUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsMemoryStore::setTopFrameUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsMemoryStore::setTimeToLiveUserInteraction):
(WebKit::ResourceLoadStatisticsMemoryStore::setTimeToLiveCookiePartitionFree):
(WebKit::ResourceLoadStatisticsMemoryStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::ResourceLoadStatisticsMemoryStore::setGrandfatheringTime):
(WebKit::ResourceLoadStatisticsMemoryStore::shouldRemoveDataRecords const):
(WebKit::ResourceLoadStatisticsMemoryStore::setDataRecordsBeingRemoved):
(WebKit::ResourceLoadStatisticsMemoryStore::ensureResourceStatisticsForPrimaryDomain):
(WebKit::ResourceLoadStatisticsMemoryStore::createEncoderFromData const):
(WebKit::ResourceLoadStatisticsMemoryStore::mergeWithDataFromDecoder):
(WebKit::ResourceLoadStatisticsMemoryStore::clear):
(WebKit::ResourceLoadStatisticsMemoryStore::wasAccessedAsFirstPartyDueToUserInteraction):
(WebKit::ResourceLoadStatisticsMemoryStore::mergeStatistics):
(WebKit::ResourceLoadStatisticsMemoryStore::shouldPartitionCookies):
(WebKit::ResourceLoadStatisticsMemoryStore::shouldBlockCookies):
(WebKit::ResourceLoadStatisticsMemoryStore::hasUserGrantedStorageAccessThroughPrompt):
(WebKit::ResourceLoadStatisticsMemoryStore::updateCookiePartitioning):
(WebKit::ResourceLoadStatisticsMemoryStore::updateCookiePartitioningForDomains):
(WebKit::ResourceLoadStatisticsMemoryStore::clearPartitioningStateForDomains):
(WebKit::ResourceLoadStatisticsMemoryStore::resetCookiePartitioningState):
(WebKit::ResourceLoadStatisticsMemoryStore::processStatistics const):
(WebKit::ResourceLoadStatisticsMemoryStore::hasHadUnexpiredRecentUserInteraction const):
(WebKit::ResourceLoadStatisticsMemoryStore::topPrivatelyControlledDomainsToRemoveWebsiteDataFor):
(WebKit::ResourceLoadStatisticsMemoryStore::includeTodayAsOperatingDateIfNecessary):
(WebKit::ResourceLoadStatisticsMemoryStore::hasStatisticsExpired const):
(WebKit::ResourceLoadStatisticsMemoryStore::setMaxStatisticsEntries):
(WebKit::ResourceLoadStatisticsMemoryStore::setPruneEntriesDownTo):
(WebKit::ResourceLoadStatisticsMemoryStore::pruneStatisticsIfNeeded):
(WebKit::ResourceLoadStatisticsMemoryStore::resetParametersToDefaultValues):
(WebKit::ResourceLoadStatisticsMemoryStore::logTestingEvent):
(WebKit::ResourceLoadStatisticsMemoryStore::setLastSeen):
(WebKit::ResourceLoadStatisticsMemoryStore::setVeryPrevalentResource):
(WebKit::ResourceLoadStatisticsMemoryStore::removeAllStorageAccess):
- UIProcess/ResourceLoadStatisticsMemoryStore.h: Added.
(WebKit::ResourceLoadStatisticsMemoryStore::isEmpty const):
(WebKit::ResourceLoadStatisticsMemoryStore::setStorageAccessPromptsEnabled):
(WebKit::ResourceLoadStatisticsMemoryStore::setDebugLogggingEnabled):
- UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::startMonitoringDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::monitorDirectoryForNewStatistics):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):
- UIProcess/ResourceLoadStatisticsPersistentStorage.h:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebResourceLoadStatisticsStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsStore::setShouldSubmitTelemetry):
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
(WebKit::WebResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebResourceLoadStatisticsStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
(WebKit::WebResourceLoadStatisticsStore::hasStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::callGrantStorageAccessHandler):
(WebKit::WebResourceLoadStatisticsStore::removeAllStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
(WebKit::WebResourceLoadStatisticsStore::submitTelemetry):
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::logNonRecentUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::clearUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setLastSeen):
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubFrameUnder):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsRedirectingTo):
(WebKit::WebResourceLoadStatisticsStore::clearPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::isGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningUpdate):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningUpdateForDomains):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearPartitioningStateForDomains):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningStateReset):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemory):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebResourceLoadStatisticsStore::setTimeToLiveUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setTimeToLiveCookiePartitionFree):
(WebKit::WebResourceLoadStatisticsStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsStore::setGrandfatheringTime):
(WebKit::WebResourceLoadStatisticsStore::callUpdatePrevalentDomainsToPartitionOrBlockCookiesHandler):
(WebKit::WebResourceLoadStatisticsStore::callRemoveDomainsHandler):
(WebKit::WebResourceLoadStatisticsStore::setMaxStatisticsEntries):
(WebKit::WebResourceLoadStatisticsStore::setPruneEntriesDownTo):
(WebKit::WebResourceLoadStatisticsStore::resetParametersToDefaultValues):
(WebKit::WebResourceLoadStatisticsStore::logTestingEvent):
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/WebResourceLoadStatisticsTelemetry.cpp:
(WebKit::sortedPrevalentResourceTelemetry):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):
- UIProcess/WebResourceLoadStatisticsTelemetry.h:
- WebKit.xcodeproj/project.pbxproj:
- 10:07 AM Changeset in webkit [233309] by
-
- 2 edits in trunk/Source/WebCore
Fix encoding / decoding issues in ResourceLoadStatistics
https://bugs.webkit.org/show_bug.cgi?id=186890
Reviewed by Brent Fulgham.
- loader/ResourceLoadStatistics.cpp:
(WebCore::encodeHashCountedSet):
(WebCore::encodeHashSet):
Do not return early if the container we're trying to encode is empty. Instead,
have the encoder encode an empty array. This is important for encoding / decoding
to be fully symmetric. Otherwise, when trying to decode one of these empty containers,
the decoder would fail (silently since we were ignoring decoding errors). Worse, the
decoder might succeed but actually be decoding the *next* container in the file, since
we have several HashCountedSets / HashSets encoded one after another.
(WebCore::decodeHashCountedSet):
(WebCore::decodeHashSet):
Return a boolean to indicate if the decoding suceeded or not.
(WebCore::ResourceLoadStatistics::decode):
Check for container decoding errors and return false when decoding fails.
Otherwise, we would just silently keep going.
- 10:03 AM Changeset in webkit [233308] by
-
- 4 edits in trunk
Cookie API: cookie creation time is wrong
https://bugs.webkit.org/show_bug.cgi?id=187101
Reviewed by Geoffrey Garen.
Source/WebCore:
Covered by API test: WebKit.WKHTTPCookieStoreCreationTime.
- platform/network/cocoa/CookieCocoa.mm:
(WebCore::Cookie::operator NSHTTPCookie * _Nullable const):
Tools:
Add test coverage: make sure the cookie creation time returned is the same as set.
- TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
(TEST):
- 8:42 AM Changeset in webkit [233307] by
-
- 6 edits in trunk/Source/WebCore
[LFC] Add Display::Box::nonCollapsedMarginBox for verification purposes.
https://bugs.webkit.org/show_bug.cgi?id=187140
Reviewed by Antti Koivisto.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBoxInformationIfNeeded):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
- layout/displaytree/DisplayBox.cpp:
(WebCore::Display::Box::nonCollapsedMarginBox const):
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::setVerticalNonCollapsedMargin):
- 8:37 AM Changeset in webkit [233306] by
-
- 4 edits in trunk/Tools
The lldb vector summary provider always shows zero capacity
https://bugs.webkit.org/show_bug.cgi?id=187132
Reviewed by Daniel Bates.
WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
on the buffer instead of the valobj.
- lldb/lldbWebKitTester/main.cpp:
(testSummaryProviders):
- lldb/lldb_webkit.py:
(WTFVectorProvider.update):
- lldb/lldb_webkit_unittest.py:
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
(TestSummaryProviders):
(TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
(TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
- 8:35 AM Changeset in webkit [233305] by
-
- 2 edits in trunk/Source/WebKit
[GTK] ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when dragging file into webview
https://bugs.webkit.org/show_bug.cgi?id=175602
Reviewed by Carlos Garcia Campos.
We check using the GdkDragContext to ensure the DroppingContext is still alive (present in
m_droppingContexts), but access it via the pointer to the DroppingContext that could be
dangling. This happens on every drag. I can't actually reproduce the original assertion
since I'm currently working with an asan build, but I imagine it's probably the same issue
that I'm fixing here.
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::dragLeave):
- 7:35 AM Changeset in webkit [233304] by
-
- 4 edits in trunk/Source/WebCore
[LFC] The margin bottom of the document element does not collapse with its last inflow child's bottom margin.
https://bugs.webkit.org/show_bug.cgi?id=187135
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginBottom):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginBottomFromLastChild):
- 1:02 AM Changeset in webkit [233303] by
-
- 5 edits1 delete in trunk
Switch OS(FUCHSIA) to using JSCOnly
https://bugs.webkit.org/show_bug.cgi?id=187133
Reviewed by Yusuke Suzuki.
.:
Rather than creating a Fuchsia port, OS(FUCHSIA) now uses the JSCOnly
port.
- CMakeLists.txt: Set the WTF_OS_FUCHSIA flag
- Source/cmake/OptionsFuchsia.cmake: Removed.
- Source/cmake/OptionsJSCOnly.cmake: Temporarily disable ICU for
OS(FUCHSIA). We'll get ICU wired in, but I'd like to work through the
other compile errors first.
Tools:
Switch Fuchsia from being a port to just being an OS. We now use a
CMAKE_TOOLCHAIN_FILE to configure the toolchain and the target triple.
- Scripts/webkitdirs.pm: Remove isFuchsia() and clients. Turns out we
can do everything we need using a CMAKE_TOOLCHAIN_FILE via the
--cmakeargs flag.
- 12:55 AM Fuchsia edited by
- (diff)
- 12:37 AM Changeset in webkit [233302] by
-
- 16 edits6 copies2 adds in trunk
[css-masking] Update clip-path box mapping to unified box
https://bugs.webkit.org/show_bug.cgi?id=185797
Reviewed by Simon Fraser.
Source/WebCore:
The box mapping for fill-box, stroke-box, view-box on HTML elements
and content-box, padding-box, margin-box, border-box for SVG elements
was aligned with the transform-box CSS property.
Furthermore, the keywords fill changed to fill-box and stroke changed
to stroke-box.
https://drafts.fxtf.org/css-masking-1/#typedef-geometry-box
Update the -webkit-clip-path property.
Tests: svg/clip-path/clip-path-shape-border-box-expected.svg
svg/clip-path/clip-path-shape-border-box.svg
svg/clip-path/clip-path-shape-content-box-expected.svg
svg/clip-path/clip-path-shape-content-box.svg
svg/clip-path/clip-path-shape-margin-box-expected.svg
svg/clip-path/clip-path-shape-margin-box.svg
svg/clip-path/clip-path-shape-padding-box-expected.svg
svg/clip-path/clip-path-shape-padding-box.svg
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator CSSBoxType const):
- css/CSSValueKeywords.in:
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertClipPath):
- css/parser/CSSPropertyParser.cpp:
(WebCore::consumeBasicShapeOrBox):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderLayer.cpp:
(WebCore::computeReferenceBox):
- rendering/shapes/BoxShape.cpp:
(WebCore::computeRoundedRectForBoxShape):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::setReferenceBoxLogicalSize):
(WebCore::ShapeOutsideInfo::logicalTopOffset const):
(WebCore::ShapeOutsideInfo::logicalLeftOffset const):
- rendering/style/RenderStyleConstants.h:
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
LayoutTests:
Update existing tests and add new tests to check the slightly different behavior.
- fast/masking/parsing-clip-path-shape-expected.txt:
- fast/masking/parsing-clip-path-shape.html:
- svg/clip-path/clip-path-shape-border-box-expected.svg: Added.
- svg/clip-path/clip-path-shape-border-box.svg: Copied from LayoutTests/svg/clip-path/clip-path-shape-stroke.svg.
- svg/clip-path/clip-path-shape-content-box-expected.svg: Copied from LayoutTests/svg/clip-path/clip-path-shape-fill.svg.
- svg/clip-path/clip-path-shape-content-box.svg: Copied from LayoutTests/svg/clip-path/clip-path-shape-fill.svg.
- svg/clip-path/clip-path-shape-fill.svg:
- svg/clip-path/clip-path-shape-margin-box-expected.svg: Added.
- svg/clip-path/clip-path-shape-margin-box.svg: Copied from LayoutTests/svg/clip-path/clip-path-shape-stroke.svg.
- svg/clip-path/clip-path-shape-padding-box-expected.svg: Copied from LayoutTests/svg/clip-path/clip-path-shape-fill.svg.
- svg/clip-path/clip-path-shape-padding-box.svg: Copied from LayoutTests/svg/clip-path/clip-path-shape-fill.svg.
- svg/clip-path/clip-path-shape-stroke.svg:
- 12:27 AM Changeset in webkit [233301] by
-
- 2 edits in trunk/Tools
Make MotionMark's plan file more robust against code changes
https://bugs.webkit.org/show_bug.cgi?id=187116
<rdar://problem/41533956>
Reviewed by Saam Barati.
Moved the code to auto-start the test to the load event listener.
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
- 12:15 AM WikiStart edited by
- (diff)
Jun 27, 2018:
- 11:55 PM Fuchsia edited by
- (diff)
- 9:46 PM Fuchsia edited by
- (diff)
- 9:45 PM Fuchsia created by
- 9:25 PM Changeset in webkit [233300] by
-
- 5 edits in trunk/Source
Don't expose new semantic -apple-system color keywords on iOS.
https://bugs.webkit.org/show_bug.cgi?id=187080
rdar://problem/41505699
Reviewed by Tim Horton.
- DerivedSources.make: Use gnu++14, since gnu++17 is giving errors on macOS 10.12.
Source/WebCore:
- css/CSSValueKeywords.in: Define new semantic colors only on macOS.
- 9:19 PM Changeset in webkit [233299] by
-
- 6 edits11 adds in trunk/Tools
Add some tests for lldb_webkit.py
https://bugs.webkit.org/show_bug.cgi?id=183744
Reviewed by Alexey Proskuryakov.
Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
and WTF::String objects.
The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
on Mac.
- Makefile: Build the simple test tool lldbWebKitTester on Mac.
- Scripts/build-lldbwebkittester: Added.
(buildProjectOrDie):
- Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
the file and take advantage of Python's default error semantics to throw an exception
if the import fails instead of handling it ourself. This has the side effect that we
now always import the LLDB Python module even if this script is invoked with --help.
If this turns out to be a significant annoyance then we can look to dynamically import
the module as we did before this change.
(webkit_build_dir):
(main):
(developer_dir): Deleted.
(import_lldb): Deleted.
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
that fact that test-webkitpy does not support class and module fixtures. This is because
test-webkitpy currently implements parallelism by breaking down existing test classes
into individual test methods itself and having each worker run exactly one test method (via
unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
setUpModule()/setUpClass() are called for each test method as opposed to once per test
class/test module.
(remove_dir): Ditto.
- Scripts/webkitpy/common/system/systemhost.py:
(SystemHost):
(SystemHost.path_to_lldb_python_directory): Added.
- Scripts/webkitpy/test/main.py:
(_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
(_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
lldbWebKitTester on Mac.
(main): Add Tools/lldb to the test search path if the platform has lldb.py.
(Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
(Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
If we will run these tests then build lldbWebKitTester if it has not already been built as the
unit tests depend on this program.
- lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
- lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
- lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
- lldb/lldbWebKitTester/Makefile: Added.
- lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
- lldb/lldbWebKitTester/main.cpp: Added.
(breakForTestingSummaryProviders):
(utf16String):
(testSummaryProviders):
(main):
- lldb/lldb_webkit_unittest.py: Added.
(destroy_cached_debug_session):
(LLDBDebugSession):
(LLDBDebugSession.setup):
(LLDBDebugSession.tearDown):
(TestSummaryProviders):
(TestSummaryProviders.setUpClass):
(TestSummaryProviders._sbFrame):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
- 8:05 PM Changeset in webkit [233298] by
-
- 7 edits in trunk/Source/WebCore
[LFC] Compute both the collapsed and the non-collapsed margin values.
https://bugs.webkit.org/show_bug.cgi?id=187129
Reviewed by Antti Koivisto.
For validation purposes only at this point.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
- layout/FormattingContext.h:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):
- 6:57 PM Changeset in webkit [233297] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Align inFlowNonReplacedHeightAndMargin() style with the rest of the compute functions.
https://bugs.webkit.org/show_bug.cgi?id=187126
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- 6:29 PM Changeset in webkit [233296] by
-
- 7 edits in trunk/Source/WebKit
Fix IBeam issues with iPad apps on Mac
https://bugs.webkit.org/show_bug.cgi?id=186900
Reviewed by Wenson Hsieh.
- Shared/ios/InteractionInformationAtPosition.h:
- Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):
Add functionality to determine what a caret rect should be, but as it is
expensive, it should only be done for this platform.
- Shared/ios/InteractionInformationRequest.cpp:
(WebKit::InteractionInformationRequest::isApproximateForRequest):
- Shared/ios/InteractionInformationRequest.h:
As there is no way to premptively request information on hover, we need to use
the last cached information, but only if it is close to the point we are about
to request information for. So having a way to determine if a point is very close
to a previous point is a good idea.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _currentPositionInformationIsApproximateForRequest:]):
(-[WKContentView closestPositionToPoint:]):
UIKit is using this function to determine if we should show an Ibeam or not.
So we need to implement it, at least for this platform.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Pass up the calculated caret rect, but only for iPad apps on Mac.
- 6:10 PM Changeset in webkit [233295] by
-
- 4 edits in trunk/Source
[GTK][WPE] Use LazyNeverDestroyed<XErrorTrapper> to remove static initializers
https://bugs.webkit.org/show_bug.cgi?id=187089
Reviewed by Michael Catanzaro.
Source/WebCore:
Do not allow copying since XErrorTrapper's logic relies on the address of XErrorTrapper.
- platform/graphics/x11/XErrorTrapper.h:
Source/WebKit:
Use LazyNeverDestroyed<XErrorTrapper> instead of global std::unique_ptr<XErrorTrapper>.
Since this variable's exit time destructor is not important in this code, using
LazyNeverDestroyed<XErrorTrapper> is fine. This removes the last static initializer
of libwebkit2gtk.so.
- PluginProcess/unix/PluginProcessMainUnix.cpp:
- 6:04 PM Changeset in webkit [233294] by
-
- 4 edits1 add in trunk
Add Fuchsia support to build-jsc
https://bugs.webkit.org/show_bug.cgi?id=187086
Reviewed by Yusuke Suzuki.
.:
Add Fuchsia port to cmake build system. After this patch, the build
errors out due to a missing sysroot.
- CMakeLists.txt:
- Source/cmake/OptionsFuchsia.cmake: Added.
Tools:
Add Fuchsia port to webkitdirs.pm. This patch is sufficient to make
build-jsc kick off a cmake for Fuchsia.
- Scripts/webkitdirs.pm:
(determineSourceDir):
(argumentsForConfiguration):
(determineXcodeSDK):
(findMatchingArguments):
(determinePortName):
(isFuchsia):
(setupAppleWinEnv):
(wrapperPrefixIfNeeded):
(relaunchIOSSimulator):
(debugMiniBrowser):
- 5:32 PM Changeset in webkit [233293] by
-
- 2 edits in tags/Safari-606.1.23/Source/WebCore
Cherry-pick r233279. rdar://problem/41539197
Crash under SWServer::unregisterServiceWorkerClient()
https://bugs.webkit.org/show_bug.cgi?id=187115
<rdar://problem/41539197>
Reviewed by Youenn Fablet.
Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
for SWServers to get destroyed while they still have connections. When this happens, the connections
(which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
connection destructor tries to unregister its clients from the server that is currently being destroyed.
To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
other data members get destroyed.
- workers/service/server/SWServer.cpp: (WebCore::SWServer::~SWServer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:25 PM Changeset in webkit [233292] by
-
- 2 edits in trunk/LayoutTests
Mark imported/blink/storage/indexeddb/blob-delete-objectstore-db.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172864
Unreviewed test gardening.
- 5:18 PM Changeset in webkit [233291] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add some more register state information when we crash in repatchPutById
https://bugs.webkit.org/show_bug.cgi?id=187112
Reviewed by Mark Lam.
This will help us gather info when we end up seeing a ObjectPropertyConditionSet
with an offset that is different than what the put tells us.
- jit/Repatch.cpp:
(JSC::tryCachePutByID):
- 5:15 PM Changeset in webkit [233290] by
-
- 2 edits in trunk/LayoutTests
Rebase LayoutTests/http/tests/contentextensions/subresource-redirect-blocked-expected.txt after r233269
https://bugs.webkit.org/show_bug.cgi?id=187125
Unreviewed.
- http/tests/contentextensions/subresource-redirect-blocked-expected.txt:
- 4:46 PM Changeset in webkit [233289] by
-
- 2 edits in trunk/Source/WebCore
[LFC] Align inFlowNonReplacedWidthAndMargin() style with the rest of the compute functions.
https://bugs.webkit.org/show_bug.cgi?id=187124
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
- 4:43 PM Changeset in webkit [233288] by
-
- 4 edits in trunk/Tools
style-queue "AttributeError: 'NoneType' object has no attribute 'is_obsolete'" when processing security patch
https://bugs.webkit.org/show_bug.cgi?id=187120
Reviewed by David Kilzer.
Teach the style queue how to refetch a patch from the status server as we did for non-Style
EWS queues.
- Scripts/webkitpy/tool/bot/stylequeuetask.py:
(StyleQueueTask.validate): Similar to change made to EarlyWarningSystemTask.validate() in r233107,
only check if the bug associated with the patch we are processing is closed if the attachment has a
non-None Bug object.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.refetch_patch): Extract logic to refetch a patch from here...
- Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue._refetch_patch): ... to here.
(StyleQueue.refetch_patch): Turn around and call PatchProcessingQueue._refetch_patch().
- 4:28 PM Changeset in webkit [233287] by
-
- 5 edits2 adds in trunk
-webkit-clip-path wrong offset for clipPath references
https://bugs.webkit.org/show_bug.cgi?id=129246
Reviewed by Simon Fraser.
Source/WebCore:
Compute the correct offset for reference clip-paths by reusing
some of the logic from basic shapes.
Makes reference based clip-path interoperable and follows the
spec.
Test: css3/masking/clip-path-reference-2.html
- rendering/RenderLayer.cpp:
(WebCore::computeReferenceBox):
(WebCore::RenderLayer::computeClipPath const):
(WebCore::RenderLayer::setupClipPath):
LayoutTests:
Add test for reference clip-path offset. Correct a broken test.
All tests in the repo for references are interoperable between Gecko, Blink
and WebKit now.
- css3/masking/clip-path-reference-2-expected.html: Added.
- css3/masking/clip-path-reference-2.html: Added.
- css3/masking/clip-path-reference-userSpaceOnUse-expected.html:
- css3/masking/clip-path-reference-userSpaceOnUse.html:
- 4:22 PM Changeset in webkit [233286] by
-
- 2 edits in trunk/Tools
Unreviewed, add myself as a WebKit committer.
- Scripts/webkitpy/common/config/contributors.json:
- 4:13 PM Changeset in webkit [233285] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix a bug in $vm.callFrame() and apply previously requested renaming of $vm.println to print.
https://bugs.webkit.org/show_bug.cgi?id=187119
Reviewed by Keith Miller.
$vm.callFrame()'s JSDollarVMCallFrame::finishCreation()
should be checking for codeBlock instead of !codeBlock
before using the codeBlock.
I also renamed some other "print" functions to use "dump" instead
to match their underlying C++ code that they will call e.g.
CodeBlock::dumpSource().
- tools/JSDollarVM.cpp:
(WTF::JSDollarVMCallFrame::finishCreation):
(JSC::functionDumpSourceFor):
(JSC::functionDumpBytecodeFor):
(JSC::doPrint):
(JSC::functionDataLog):
(JSC::functionPrint):
(JSC::functionDumpCallFrame):
(JSC::functionDumpStack):
(JSC::JSDollarVM::finishCreation):
(JSC::functionPrintSourceFor): Deleted.
(JSC::functionPrintBytecodeFor): Deleted.
(JSC::doPrintln): Deleted.
(JSC::functionPrintln): Deleted.
(JSC::functionPrintCallFrame): Deleted.
(JSC::functionPrintStack): Deleted.
- tools/VMInspector.cpp:
(JSC::DumpFrameFunctor::DumpFrameFunctor):
(JSC::DumpFrameFunctor::operator() const):
(JSC::VMInspector::dumpCallFrame):
(JSC::VMInspector::dumpStack):
(JSC::VMInspector::dumpValue):
(JSC::PrintFrameFunctor::PrintFrameFunctor): Deleted.
(JSC::PrintFrameFunctor::operator() const): Deleted.
(JSC::VMInspector::printCallFrame): Deleted.
(JSC::VMInspector::printStack): Deleted.
(JSC::VMInspector::printValue): Deleted.
- tools/VMInspector.h:
- 3:53 PM Changeset in webkit [233284] by
-
- 2 edits8 adds in trunk/Source/WebKit
Add a sandbox profile for some additional bank plugins
https://bugs.webkit.org/show_bug.cgi?id=187105
Reviewed by Brent Fulgham.
- Resources/PlugInSandboxProfiles/cfca.com.npCryptoKit.CGB.MAC.sb: Added.
- Resources/PlugInSandboxProfiles/cfca.com.npP11CertEnroll.MAC.CGB.sb: Added.
- Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb: Added.
- Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb: Added.
- Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb: Added.
- Resources/PlugInSandboxProfiles/com.cfca.npSecEditCtl.MAC.BOC.plugin.sb: Added.
- Resources/PlugInSandboxProfiles/com.cmbchina.CMBSecurity.sb: Added.
- Resources/PlugInSandboxProfiles/com.ftsafe.NPAPI-Core-Safe-SoftKeybaord.plugin.rfc1034identifier.sb: Added.
- WebKit.xcodeproj/project.pbxproj:
- 3:49 PM Changeset in webkit [233283] by
-
- 3 edits in trunk/Source/WebCore/PAL
Build fix after r233266
https://bugs.webkit.org/show_bug.cgi?id=187024
<rdar://problem/39759057>
Unreviewed build fix.
- pal/cf/CoreMediaSoftLink.cpp: Do not soft-link CMSampleBufferCallForEachSample for
iOS 12 and up on iPhone device and simulator.
- pal/cf/CoreMediaSoftLink.h: Ditto.
- 3:43 PM Changeset in webkit [233282] by
-
- 7 edits in trunk/Source
Versioning.
- 3:25 PM Changeset in webkit [233281] by
-
- 6 edits2 adds in trunk
Don't invoke post resolution callbacks when resolving computed style
https://bugs.webkit.org/show_bug.cgi?id=187113
<rdar://problem/41365766>
Reviewed by Geoff Garen.
Source/WebCore:
Post-resolution callbacks should only be invoked when we resolve the full document style,
not when resolving computed style for a single element.
Tests: fast/dom/object-computed-style-event.html
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
- dom/Element.cpp:
(WebCore::Element::resolveComputedStyle):
Also ref the ancestor stack to be safe.
- style/StyleTreeResolver.cpp:
(WebCore::Style::PostResolutionCallbackDisabler::PostResolutionCallbackDisabler):
(WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler):
Add an option to not drain the callback queue on destruction. In this mode we
just block network loads.
- style/StyleTreeResolver.h:
LayoutTests:
- fast/dom/object-computed-style-event-expected.txt: Added.
- fast/dom/object-computed-style-event.html: Added.
- 3:14 PM Changeset in webkit [233280] by
-
- 13 edits in trunk
Find on page selection color isn't adapted for dark mode.
https://bugs.webkit.org/show_bug.cgi?id=187072
rdar://problem/40354841
Reviewed by Tim Horton.
Source/WebCore:
- page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Use [NSColor findHighlightColor].
- platform/mac/LocalDefaultSystemAppearance.h:
(WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): Added.
- platform/mac/LocalDefaultSystemAppearance.mm:
(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Set m_usingDarkAppearance.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Use TextPaintPhase::Decoration since this
matches step three of InlineTextBox::paint ("Paint fancy decorations"). This allows TextMatch to
paint a forground and not end up painting during this "fancy decorations" phase.
(WebCore::InlineTextBox::resolveStyleForMarkedText): Set the fillColor for TextMarker to force a
dark text color which will draw over the yellow highlight.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Added support for TextPaintPhase::Decoration.
Seperate DocumentMarker::TelephoneNumber and DocumentMarker::TextMatch. Have DocumentMarker::TextMatch
support Forground and Background phases.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::platformColorsDidChange):
(WebCore::RenderTheme::activeTextSearchHighlightColor const): Added. Call the platfrom version.
(WebCore::RenderTheme::inactiveTextSearchHighlightColor const): Added. Ditto.
(WebCore::RenderTheme::platformActiveTextSearchHighlightColor const): Added StyleColor::Options.
(WebCore::RenderTheme::platformInactiveTextSearchHighlightColor const): Ditto.
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Added.
(WebCore::RenderThemeMac::platformInactiveTextSearchHighlightColor const): Added.
(WebCore::RenderThemeMac::platformColorsDidChange): Clear new color caches.
(WebCore::RenderThemeMac::systemColor const): Cache system colors by light and dark mode.
LayoutTests:
- fast/css/apple-system-control-colors-expected.txt: Updated.
- fast/text/mark-matches-broken-line-rendering-expected.html: Ditto.
- fast/text/mark-matches-rendering-expected.html: Ditto.
- 2:43 PM Changeset in webkit [233279] by
-
- 2 edits in trunk/Source/WebCore
Crash under SWServer::unregisterServiceWorkerClient()
https://bugs.webkit.org/show_bug.cgi?id=187115
<rdar://problem/41539197>
Reviewed by Youenn Fablet.
Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
for SWServers to get destroyed while they still have connections. When this happens, the connections
(which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
connection destructor tries to unregister its clients from the server that is currently being destroyed.
To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
other data members get destroyed.
- workers/service/server/SWServer.cpp:
(WebCore::SWServer::~SWServer):
- 2:26 PM Changeset in webkit [233278] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add logging to try to diagnose where we get a null structure.
https://bugs.webkit.org/show_bug.cgi?id=187106
Reviewed by Mark Lam.
Add a logging to JSObject::toPrimitive to help diagnose a nullptr
structure crash.
This code should be removed when we fix <rdar://problem/33451840>
- runtime/JSObject.cpp:
(JSC::callToPrimitiveFunction):
- runtime/JSObject.h:
(JSC::JSObject::getPropertySlot):
- 2:15 PM Changeset in webkit [233277] by
-
- 9 edits in trunk/Source
NetworkLoadChecker should not need to hard ref NetworkConnectionToWebProcess
https://bugs.webkit.org/show_bug.cgi?id=186551
Reviewed by Daniel Bates.
Source/WebCore:
No change of behavior.
Add a way to set the client receiving any CSP warning/error notification.
- page/csp/ContentSecurityPolicy.h:
(WebCore::ContentSecurityPolicy::setClient):
Source/WebKit:
Removed the need for NetworkLoadChecker to reference a NetworkConnectionToWebProcess.
Instead a CSP client is given to NetworkLoadChecker when needed.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::loadPing):
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::check):
(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::checkRequest):
(WebKit::NetworkLoadChecker::contentSecurityPolicy):
(WebKit::NetworkLoadChecker::addConsoleMessage): Deleted.
(WebKit::NetworkLoadChecker::sendCSPViolationReport): Deleted.
(WebKit::NetworkLoadChecker::enqueueSecurityPolicyViolationEvent): Deleted.
- NetworkProcess/NetworkLoadChecker.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
- NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
- NetworkProcess/PingLoad.h:
- 2:10 PM Changeset in webkit [233276] by
-
- 3 edits in trunk/Tools
webkit-patch should ignore non-ASCII characters in the status server API key
https://bugs.webkit.org/show_bug.cgi?id=187107
Reviewed by Lucas Forschler.
The API key should only consists of ASCII characters. If it contains any
non-ASCII characters then log a warning and ignore them.
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer.set_api_key): Force conversion to ASCII.
- Scripts/webkitpy/tool/main.py:
(WebKitPatch._status_server_api_key): Convert to ASCII, ignoring non-ASCII
characters and logging a warning.
- 1:10 PM Changeset in webkit [233275] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Do not collapse margin with the parent when element has border/padding.
https://bugs.webkit.org/show_bug.cgi?id=187114
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):
- 1:01 PM Changeset in webkit [233274] by
-
- 3 edits in trunk/Source/WebCore
Fix Windows build after r233268.
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayerWin::hasContents const):
- platform/graphics/ca/win/PlatformCALayerWin.h:
- 12:59 PM Changeset in webkit [233273] by
-
- 1 edit1 move6 adds in trunk/LayoutTests/imported/w3c
Add Cross-Origin-Resource-Policy tests for workers and service workers
https://bugs.webkit.org/show_bug.cgi?id=187030
Reviewed by Chris Dumez.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/cross-origin-resource-policy/fetch.html.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker.html: Added.
- 12:23 PM Changeset in webkit [233272] by
-
- 7 edits in trunk/Source/WebCore
[LFC] Out-of-flow positioned element's height depends on its containing block's height.
https://bugs.webkit.org/show_bug.cgi?id=187082
Reviewed by Antti Koivisto.
We can't really compute the final height of an out-of-flow element until after its containing block's height is computed.
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
- layout/FormattingContext.h:
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::updateLayout):
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):
- layout/LayoutContext.h:
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
- layout/layouttree/LayoutContainer.h:
(WebCore::Layout::Container::outOfFlowDescendants const):
(WebCore::Layout::Container::outOfFlowDescendants): Deleted.
- 12:19 PM Changeset in webkit [233271] by
-
- 9 edits in trunk/Source/WebKit
[Wincairo] Add support for context menus to non-legacy minibrowser
https://bugs.webkit.org/show_bug.cgi?id=186815.
Patch by Stephan Szabo <stephan.szabo@sony.com> on 2018-06-27
Reviewed by Ryosuke Niwa.
- UIProcess/WebPageProxy.h:
- UIProcess/win/PageClientImpl.cpp:
(WebKit::PageClientImpl::viewWidget):
- UIProcess/win/PageClientImpl.h:
- UIProcess/win/WebContextMenuProxyWin.cpp:
(WebKit::WebContextMenuProxyWin::show):
(WebKit::createMenu):
(WebKit::createMenuItem):
(WebKit::populate):
(WebKit::WebContextMenuProxyWin::showContextMenuWithItems):
(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin):
(WebKit::WebContextMenuProxyWin::~WebContextMenuProxyWin):
- UIProcess/win/WebContextMenuProxyWin.h:
- UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::viewWidget):
- UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc):
(WebKit::WebView::onMenuCommand):
- UIProcess/win/WebView.h:
- 11:34 AM Changeset in webkit [233270] by
-
- 1 copy in tags/Safari-606.1.23
Tag Safari-606.1.23.
- 11:23 AM Changeset in webkit [233269] by
-
- 9 edits3 adds in trunk
Disable content blockers in NetworkLoadChecker except for ping loads
https://bugs.webkit.org/show_bug.cgi?id=187083
<rdar://problem/41440083>
Reviewed by Chris Dumez.
Source/WebCore:
Add internals API to reload a frame without content extensions.
Test: http/tests/contentextensions/reload-without-contentextensions.html
- testing/Internals.cpp:
(WebCore::Internals::reloadWithoutContentExtensions):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::processContentExtensionRulesForLoad):
- NetworkProcess/NetworkLoadChecker.h:
(WebKit::NetworkLoadChecker::enableContentExtensionsCheck):
- NetworkProcess/PingLoad.cpp:
LayoutTests:
- http/tests/contentextensions/reload-without-contentextensions-expected.txt: Added.
- http/tests/contentextensions/reload-without-contentextensions.html: Added.
- http/tests/contentextensions/reload-without-contentextensions.html.json: Added.
- 11:22 AM Changeset in webkit [233268] by
-
- 18 edits3 adds in trunk
https://hackernoon.com/ uses lots of layer backing store
https://bugs.webkit.org/show_bug.cgi?id=186909
rdar://problem/40257540
Reviewed by Tim Horton.
Source/bmalloc:
Drive-by typo fix.
- bmalloc/Scavenger.cpp:
(bmalloc::dumpStats):
Source/WebCore:
The existing "backing store detached" logic, which was used to eliminate backing store
for compositing layers outside the viewport, had a number of bugs that allowed layers
to have backing store when they should not.
Specifically, any code path that ended up in setNeedsDisplay{InRect}() in PlatformCALayer
could trigger backing store creation on layers that should have never had any.
Rather than monkeypatch all the GraphicsLayerCA call sites that call setNeedsDisplay{InRect}(),
just bail early from the PlatformCALayer* methods that trigger repaints.
Tests didn't catch this because they just dumped the state of the backingStoreAttached flag. To fix this,
create backingStoreAttachedForTesting() which also tests whether the layer has contents.
Test: compositing/backing/backing-store-attachment-outside-viewport.html
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties const):
(showGraphicsLayerTree):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::backingStoreAttachedForTesting const):
- platform/graphics/GraphicsLayerClient.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::backingStoreAttachedForTesting const):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayerCocoa::setNeedsDisplay):
(PlatformCALayerCocoa::setNeedsDisplayInRect):
(PlatformCALayerCocoa::hasContents const):
Source/WebKit:
PlatformCALayerRemote was actually holding onto backing stores for layers with
backing store detached, which could increase memory use. When told that backing stores
are not attached, explicitly throw away the backing, and re-create it (via setNeedsDisplay)
when attached. This is now similar to what PlatformLayerCACocoa does.
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemote::setNeedsDisplay):
(WebKit::PlatformCALayerRemote::hasContents const):
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:
LayoutTests:
New test.
- compositing/backing/backing-store-attachment-outside-viewport-expected.txt: Added.
- compositing/backing/backing-store-attachment-outside-viewport.html: Added.
- 11:07 AM Changeset in webkit [233267] by
-
- 10 edits in trunk/Source/WebCore
Fix clang static analyzer warnings: Branch condition evaluates to a garbage value
<https://webkit.org/b/186968>
Reviewed by Zalan Bujtas.
This patch changes two stack-allocated
boolvariables into
std::optional<bool>since the functions that set the variable
may return early without setting it. It also changes one
stack-allocated pointer to be initialized tonullptr.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):
Update for change to CSSPropertyAnimation::getPropertyAtIndex()
argument type.
- editing/ios/EditorIOS.mm:
(WebCore::Editor::writeImageToPasteboard): Initialize
cachedImagestack pointer to nullptr since getImage() has an
early return that doesn't setcachedImage.
- editing/mac/EditorMac.mm:
(WebCore::Editor::writeImageToPasteboard): Ditto.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimation::getPropertyAtIndex):
- page/animation/CSSPropertyAnimation.h:
(WebCore::CSSPropertyAnimation::getPropertyAtIndex):
- Change method to take
std::optional<bool>instead ofboolas second argument since the method may return early without settingisShorthand.
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions): Update for
change to CSSPropertyAnimation::getPropertyAtIndex() argument
type.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Also
rename localemphasisMarkIsOvertoemphasisMarkIsAboveto
match other call sites.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment const):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment const):
- Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove() argument type.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
- Change method to take
std::optional<bool>instead ofboolas second argument since the method may return early without settingabove.
(WebCore::InlineTextBox::paintMarkedTextForeground):
- Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove() argument type.
- rendering/InlineTextBox.h:
(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):
- Change method to take
std::optional<bool>instead ofbool.
- 11:02 AM Changeset in webkit [233266] by
-
- 17 edits1 copy19 adds in trunk
Enable WebKit iOS 12 build
https://bugs.webkit.org/show_bug.cgi?id=187024
<rdar://problem/39759057>
Reviewed by David Kilzer.
Source/WebCore/PAL:
- pal/cf/CoreMediaSoftLink.cpp: Condition some CoreMedia functions on version.
- pal/cf/CoreMediaSoftLink.h: Ditto.
- pal/spi/cocoa/NSXPCConnectionSPI.h: Use XPCSPI.h instead of xpc.h.
- pal/spi/ios/QuickLookSPI.h: QLItem adopts QLPreviewItem.
- pal/spi/ios/SystemPreviewSPI.h: Fix compiler errors.
Source/WebKit:
- Platform/spi/ios/PDFKitSPI.h: Added PDFKit SPI.
- Platform/spi/ios/UIKitSPI.h: Add new UIKit SPI and UICompositingMode enumeration.
- UIProcess/ios/WKPDFView.mm: Use PDFKitSPI header.
- UIProcess/ios/WKSystemPreviewView.mm: Use CoreGraphicsSPI.h.
- UIProcess/ios/fullscreen/WKFullscreenStackView.mm: Use QuartzCoreSPI.h.
Source/WTF:
- wtf/spi/darwin/XPCSPI.h: Add endpoint and connection declarations.
Tools:
- Scripts/configure-xcode-for-ios-development:
(copyMissingHeadersFromSDKToSDKIfNeeded): Copy launch.h into embedded SDKs.
WebKitLibraries:
- WebKitPrivateFrameworkStubs/iOS/12: Added.
- 10:59 AM Changeset in webkit [233265] by
-
- 2 edits in trunk/Source/WebKit
CSS Animation Triggers is not an experimental feature, should be globally off by default
Reviewed by Dean Jackson.
- Shared/WebPreferences.yaml:
- 10:41 AM Changeset in webkit [233264] by
-
- 2 edits in trunk/Source/WebKit
Promote the Secure Context API feature from experimental-yet-on-by-default to always-on
Reviewed by Dan Bates.
- Shared/WebPreferences.yaml:
Secure Context API is on by default, it's not experimental anymore.
- 10:38 AM Changeset in webkit [233263] by
-
- 2 edits in trunk/Source/WebKit
Make Link Preload an on-by-default feature
https://bugs.webkit.org/show_bug.cgi?id=187104
Reviewed by Ryosuke Niwa.
- Shared/WebPreferences.yaml:
This should be on, not experimental. It already shipped on in the past.
- 10:01 AM Changeset in webkit [233262] by
-
- 2 edits in trunk/Tools
[WSL] Add a control-flow stack to the execution rules in WSL.ott
https://bugs.webkit.org/show_bug.cgi?id=186310
Rubberstamped by Filip Pizlo.
The goal of this is to enable (future) rules about uniform control flow for barriers.
It required adding two new special construct: Join(s) and JoinExpr(e) whose only role is to pop the last element of the stack.
- 9:36 AM Changeset in webkit [233261] by
-
- 2 edits in trunk/Source/WebKit
Regression(r233208): Completion handler does not get called on GTK port
https://bugs.webkit.org/show_bug.cgi?id=187099
Reviewed by Antti Koivisto.
Make sure UpdatePrevalentDomainsToPartitionOrBlockCookiesHandler's completion handler
gets called on non-COCOA ports.
- UIProcess/WebResourceLoadStatisticsStore.h:
- 9:18 AM Changeset in webkit [233260] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Move formatting context root layout logic to a dedicated function.
https://bugs.webkit.org/show_bug.cgi?id=187097
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
- layout/blockformatting/BlockFormattingContext.h:
- 9:13 AM Changeset in webkit [233259] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Compute static position for out-of-flow elements only when required.
https://bugs.webkit.org/show_bug.cgi?id=187096
Reviewed by Antti Koivisto.
Computing static position for out-of-flow elements could be somewhat expensive, so let's not do it unless we actually need it.
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned): Deleted.
- 9:13 AM Changeset in webkit [233258] by
-
- 2 edits in trunk/WebDriverTests
[GTK][WPE] Update expectations for WebDriver tests.
https://bugs.webkit.org/show_bug.cgi?id=187098
Unreviewed gardening.
- TestExpectations.json:
- 9:10 AM Changeset in webkit [233257] by
-
- 3 edits2 adds2 deletes in trunk
AX: [iOS] Remove the ability to set keyboard focus when VoiceOver takes focus
https://bugs.webkit.org/show_bug.cgi?id=187076
Reviewed by Chris Fleizach.
Source/WebCore:
We shouldn't set keyboard focus when assistive technology takes focus since
this is causing website incompatibility issues by causing focus to be lost.
Test: accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):
LayoutTests:
- accessibility/ios-simulator/accessibility-focus-do-not-set-focus-expected.txt: Added.
- accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html: Added.
- accessibility/ios-simulator/dom-focus-fires-on-correct-element-expected.txt: Removed.
- accessibility/ios-simulator/dom-focus-fires-on-correct-element.html: Removed.
- 8:14 AM Changeset in webkit [233256] by
-
- 2 edits in trunk/Tools
[WSL] Fix minor formatting issues in the grammar section
https://bugs.webkit.org/show_bug.cgi?id=186310
Rubberstamped by Filip Pizlo.
- 8:07 AM Changeset in webkit [233255] by
-
- 4 edits in trunk/Source/ThirdParty
MIME type subclass check should guard against small strings
https://bugs.webkit.org/show_bug.cgi?id=186977
Reviewed by Carlos Garcia Campos.
Sadly, this code is duplicated between two different files because it is not good.
- xdgmime/README.webkit:
- xdgmime/src/xdgmime.c:
(ends_with):
(xdg_mime_is_super_type):
- xdgmime/src/xdgmimecache.c:
(ends_with):
(is_super_type):
- 8:04 AM Changeset in webkit [233254] by
-
- 3 edits in trunk/Tools
[WSL] Put the full grammar in the Sphinx document
https://bugs.webkit.org/show_bug.cgi?id=186310
Rubberstamped by Filip Pizlo.
Put the grammar's production rules in the Sphinx document, along with a few comments and the rules for desugaring.
Also includes a bit of clean-up of the antlr rules.
- 4:19 AM Changeset in webkit [233253] by
-
- 3 edits1 add in trunk
DFG's compileReallocatePropertyStorage() and compileAllocatePropertyStorage() slow paths should also clear unused properties.
https://bugs.webkit.org/show_bug.cgi?id=187091
<rdar://problem/41395624>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/regress-187091.js: Added.
Source/JavaScriptCore:
Previously, when compileReallocatePropertyStorage() and compileAllocatePropertyStorage()
take their slow paths, the slow path would jump back to the fast path right after
the emitted code which clears the unused property values. As a result, the
unused properties are not initialized. We've fixed this by adding the slow path
generators before we emit the code to clear the unused properties.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- 3:05 AM Changeset in webkit [233252] by
-
- 3 edits1 add in trunk
[JSC] ArrayPatternNode::emitDirectBinding does not return assignment target value if dst is nullptr
https://bugs.webkit.org/show_bug.cgi?id=185943
Reviewed by Mark Lam.
JSTests:
- stress/direct-binding-return-result.js: Added.
(shouldBe):
(test):
Source/JavaScriptCore:
ArrayPatternNode::emitDirectBinding should return a register with an assignment target instead of filling
the result with undefined ifdstis nullptr. Whiledst == ignoredResult()means we do not require
the result,dst == nullptrjust means "dst is required, but a register for dst is not allocated.".
This patch fixes emitDirectBinding to return an appropriate value with an allocated register for dst.
ArrayPatternNode::emitDirectBinding() should be removed later since it does not follow array spreading protocol,
but it should be done in a separate patch since it would be performance sensitive.
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayPatternNode::emitDirectBinding):
- 2:34 AM Changeset in webkit [233251] by
-
- 2 edits in trunk/Source/WebCore
Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
https://bugs.webkit.org/show_bug.cgi?id=186881
Reviewed by Antti Koivisto.
Every caller does this already.
No new tests, no change in behavior.
- style/StyleTreeResolver.cpp:
(WebCore::Style::resetStyleForNonRenderedDescendants):
(WebCore::Style::TreeResolver::resolveComposedTree):
- 1:27 AM Changeset in webkit [233250] by
-
- 2 edits in trunk/Source/WebKit
When trying to print a very long email on iOS, the print preview is blank
https://bugs.webkit.org/show_bug.cgi?id=187077
<rdar://problem/41107013>
Reviewed by Timothy Hatcher.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::computePagesForPrintingAndDrawToPDF):
ChildProcessProxy::sendSync has a (surprising) default timeout of 1 second,
(as opposed to Connection::sendSync's default timeout of ∞ seconds).
The printing path already waits ∞ seconds for the final PDF, but currently
uses the default 1 second timeout for page count computation. If page
count computation takes more than 1 second, the preview will be blank.
Since the print preview is generated asynchronously, we really want
to wait until it's done, and not give up after 1 second.
- 1:19 AM Changeset in webkit [233249] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
[GTK][WPE] Remove gflags from libwebrtc build
https://bugs.webkit.org/show_bug.cgi?id=187078
Reviewed by Alejandro G. Castro.
gflags is used only in libyuv unit tests. So the Apple ports do not build & link it.
GTK and WPE can do the same thing: not building gflags. By doing so, we can achieve
the following results.
- Remove static initializers defined for gflags.
- Reduce binary size.
- CMakeLists.txt:
- 1:16 AM Changeset in webkit [233248] by
-
- 4 edits in trunk/Source/WebCore
[GStreamer] Coverity scan issues
https://bugs.webkit.org/show_bug.cgi?id=187087
Reviewed by Xabier Rodriguez-Calvar.
Fix uninitialized members.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
- platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
- 1:13 AM Changeset in webkit [233247] by
-
- 3 edits1 add in trunk/Source/WebCore
[GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
https://bugs.webkit.org/show_bug.cgi?id=187033
Reviewed by Michael Catanzaro.
Move the GCryptUtilities helpers that operate on libgcrypt values and
constants into a separate source file. This limits a bit the amount of
inlining the compiler might feel compelled to do, and the resulting
shared library is 8kB smaller in size.
- crypto/gcrypt/GCryptUtilities.cpp: Copied from Source/WebCore/crypto/gcrypt/GCryptUtilities.h.
(WebCore::hmacAlgorithm):
(WebCore::digestAlgorithm):
(WebCore::hashCryptoDigestAlgorithm):
(WebCore::mpiLength):
(WebCore::mpiData):
(WebCore::mpiZeroPrefixedData):
(WebCore::mpiSignedData):
- crypto/gcrypt/GCryptUtilities.h:
(WebCore::hmacAlgorithm): Deleted.
(WebCore::digestAlgorithm): Deleted.
(WebCore::hashCryptoDigestAlgorithm): Deleted.
(WebCore::mpiLength): Deleted.
(WebCore::mpiData): Deleted.
(WebCore::mpiZeroPrefixedData): Deleted.
(WebCore::mpiSignedData): Deleted.
- platform/SourcesGCrypt.txt:
Jun 26, 2018:
- 10:06 PM Changeset in webkit [233246] by
-
- 4 edits in trunk/Source
[iPad apps on macOS] Unable to interact with video elements that have started playing
https://bugs.webkit.org/show_bug.cgi?id=187073
<rdar://problem/40591107>
Reviewed by Tim Horton.
Source/WebCore/PAL:
Define an SPI method on CALayer. See WebKit ChangeLog for more detail.
- pal/spi/cocoa/QuartzCoreSPI.h:
Source/WebKit:
On iOS, we currently force remote hosting contexts to be non-interactive by passing in
kCAContextIgnoresHitTest
when creating the CAContext. However, this flag is not respected by CoreAnimation when running iOS apps on macOS.
This means all HID events dispatched over a video that has been played (which causes WebKit to insert a
CALayerHost-backed WKRemoteView in the view hierarchy) will be routed to the context ID of the video's CAContext
rather than the context ID of the key window containing the WKWebView.
This subsequently causes all gesture recognizers (hover, touch, tap, long press) to fail recognition when
running iOS apps on macOS. To address this, we set a flag on WKRemoteView's CALayerHost to prevent hit-testing
to the remote layer. This allows us to avoid routing HID events to the wrong context, and instead target the
main UIWindow.
Manually verified that click, touch, and mouseenter/mouseleave events are dispatched when interacting over a
video element.
- UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
(-[WKRemoteView initWithFrame:contextID:]):
- 10:01 PM Changeset in webkit [233245] by
-
- 37 edits in trunk/Source
[JSC] Pass VM& to functions more
https://bugs.webkit.org/show_bug.cgi?id=186241
Reviewed by Mark Lam.
Source/JavaScriptCore:
This patch threads VM& to functions requiring VM& more.
- API/JSObjectRef.cpp:
(JSObjectIsConstructor):
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:
(JSC::AdaptiveInferredPropertyValueWatchpointBase::install):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::fireInternal):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::fireInternal):
- bytecode/AdaptiveInferredPropertyValueWatchpointBase.h:
- bytecode/CodeBlockJettisoningWatchpoint.cpp:
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/CodeBlockJettisoningWatchpoint.h:
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::install):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
- bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::fireInternal):
- bytecode/StructureStubClearingWatchpoint.h:
- bytecode/Watchpoint.cpp:
(JSC::Watchpoint::fire):
(JSC::WatchpointSet::fireAllWatchpoints):
- bytecode/Watchpoint.h:
- dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::handleFire):
- dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h:
- dfg/DFGAdaptiveStructureWatchpoint.cpp:
(JSC::DFG::AdaptiveStructureWatchpoint::install):
(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):
- dfg/DFGAdaptiveStructureWatchpoint.h:
- dfg/DFGDesiredWatchpoints.cpp:
(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setupGetByIdPrototypeCache):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::tryInitializeSpeciesWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
- runtime/ECMAScriptSpecInternalFunctions.cpp:
(JSC::esSpecIsConstructor):
- runtime/FunctionRareData.cpp:
(JSC::FunctionRareData::AllocationProfileClearingWatchpoint::fireInternal):
- runtime/FunctionRareData.h:
- runtime/InferredStructureWatchpoint.cpp:
(JSC::InferredStructureWatchpoint::fireInternal):
- runtime/InferredStructureWatchpoint.h:
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::createSubclassStructureSlow):
- runtime/InternalFunction.h:
(JSC::InternalFunction::createSubclassStructure):
- runtime/JSCJSValue.h:
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::isConstructor const):
- runtime/JSCell.h:
- runtime/JSCellInlines.h:
(JSC::JSCell::isConstructor):
(JSC::JSCell::methodTable const):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/ObjectPropertyChangeAdaptiveWatchpoint.h:
(JSC::ObjectPropertyChangeAdaptiveWatchpoint::ObjectPropertyChangeAdaptiveWatchpoint):
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::finishCreation):
- runtime/ReflectObject.cpp:
(JSC::reflectObjectConstruct):
- runtime/StructureRareData.cpp:
(JSC::StructureRareData::setObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):
Source/WebCore:
- bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::JSCustomElementRegistry::define):
- 9:45 PM Changeset in webkit [233244] by
-
- 6 edits in trunk/Source/WebKit
Unreviewed, rolling out r233232.
https://bugs.webkit.org/show_bug.cgi?id=187081
"This is breaking launching some plugins" (Requested by youenn
on #webkit).
Reverted changeset:
"Remove quarantine for Webex plugin"
https://bugs.webkit.org/show_bug.cgi?id=187050
https://trac.webkit.org/changeset/233232
- 9:36 PM Changeset in webkit [233243] by
-
- 2 edits in trunk/Source/WebKit
Rearrange some WebPreferences; move two experimental prefs into the experimental section
- Shared/WebPreferences.yaml:
- 8:10 PM Changeset in webkit [233242] by
-
- 3 edits1 add in trunk
eval() is wrong about the LiteralParser never throwing any exceptions.
https://bugs.webkit.org/show_bug.cgi?id=187074
<rdar://problem/41461099>
Reviewed by Saam Barati.
JSTests:
- stress/regress-187074.js: Added.
Source/JavaScriptCore:
Added the missing exception check, and removed an erroneous assertion.
- interpreter/Interpreter.cpp:
(JSC::eval):
- 8:03 PM Changeset in webkit [233241] by
-
- 3 edits in trunk/Source/WebCore
CSSGradientValue's color stops vector wastes 12KB on theverge.com
https://bugs.webkit.org/show_bug.cgi?id=186988
Reviewed by Sam Weinig.
Shrink the color stops vector when we're done parsing the stops.
- css/CSSGradientValue.h:
(WebCore::CSSGradientValue::doneAddingStops):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
(WebCore::CSSPropertyParserHelpers::consumeAngularGradientColorStops):
- 7:10 PM Changeset in webkit [233240] by
-
- 9 edits in trunk
Deal better with the network process crashing on startup
https://bugs.webkit.org/show_bug.cgi?id=187065
<rdar://problem/41451622>
Reviewed by Geoffrey Garen.
Source/WebKit:
When a network process crashes on startup, we would not attempt to relaunch it. If there were web
processes waiting for a connection to this network process, we would send them an invalid connection
identifier which would cause them to forcefully crash.
Instead, we now apply the same policy whether a network process crashes on startup or later:
- We attempt to relaunch the network process
- If there were pending connections from WebContent processes, we ask the new Network process instead.
As a result, WebContent processes no longer crash in this case. Instead, they wait for a valid
connection to the network process.
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _makeNextNetworkProcessLaunchFailForTesting]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getLaunchOptions):
(WebKit::NetworkProcessProxy::didFinishLaunching):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::networkProcessCrashed):
- UIProcess/WebProcessPool.h:
Tools:
Add layout test coverage.
- TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
(-[MonitorWebContentCrashNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
(-[MonitorWebContentCrashNavigationDelegate webView:didFinishNavigation:]):
(TestWebKitAPI::TEST):
- 6:58 PM Changeset in webkit [233239] by
-
- 11 edits1 delete in trunk
Remove static initializers more
https://bugs.webkit.org/show_bug.cgi?id=186969
Reviewed by Michael Catanzaro.
Source/WebCore:
This patch removes static initializers more. They typically exists in GTK port.
No behavior change.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- page/ResourceUsageData.cpp: Removed.
- page/ResourceUsageData.h:
Remove ResourceUsageData constructors since default constructors are enough.
(WebCore::MemoryCategoryInfo::MemoryCategoryInfo):
- platform/gtk/PasteboardHelper.cpp:
(WebCore::markupPrefix):
(WebCore::removeMarkupPrefix):
(WebCore::PasteboardHelper::fillSelectionData):
Use NeverDestroyed<> and static functions.
- platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:
(WebCore::defaultVolumeCapability):
(WebCore::GStreamerAudioCaptureSource::capabilities const):
CapabilityValueOrRange's constructor is not constexpr.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::initialAcceptLanguages):
(WebCore::proxySettings):
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setupProxy):
(WebCore::SoupNetworkSession::setProxySettings):
(WebCore::SoupNetworkSession::setInitialAcceptLanguages):
Use NeverDestroyed<> and static functions.
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::assignedUrlsCache):
(WTR::dumpResourceURL):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::stringAttributeValue):
Use NeverDestroyed<> and static functions.
- 6:29 PM Changeset in webkit [233238] by
-
- 6 edits32 adds in trunk/LayoutTests
Import wpt CORP tests
https://bugs.webkit.org/show_bug.cgi?id=187027
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/common/get-host-info.sub.js:
- web-platform-tests/fetch/cross-origin-resource-policy/fetch-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-iframe-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-iframe.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/fetch.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/iframe-loads-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/iframe-loads.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/image-loads-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/image-loads.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/resources/green.png: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/resources/hello.py: Added.
(main):
- web-platform-tests/fetch/cross-origin-resource-policy/resources/iframe.py: Added.
(main):
- web-platform-tests/fetch/cross-origin-resource-policy/resources/iframeFetch.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/resources/image.py: Added.
(main):
- web-platform-tests/fetch/cross-origin-resource-policy/resources/redirect.py: Added.
(main):
- web-platform-tests/fetch/cross-origin-resource-policy/resources/script.py: Added.
(main):
- web-platform-tests/fetch/cross-origin-resource-policy/resources/w3c-import.log: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.js: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.worker-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.worker.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.js: Added.
(promise_test.t.return.new.Promise):
(promise_test.t.finally):
- web-platform-tests/fetch/cross-origin-resource-policy/script-loads-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/script-loads.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/syntax.any-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.js: Added.
(string_appeared_here.forEach.incorrectHeaderValue.promise_test.t.return.fetch.crossOriginURL.encodeURIComponent):
- web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker-expected.txt: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker.html: Added.
- web-platform-tests/fetch/cross-origin-resource-policy/w3c-import.log: Added.
LayoutTests:
Skipping tests for WK1.
- platform/ios-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- 6:23 PM Changeset in webkit [233237] by
-
- 9 edits3 adds in trunk
REGRESSION (r231479): Unable to buy Odeon cinema tickets in STP (bogus 'X-Frame-Options' to 'SAMEORIGIN')
https://bugs.webkit.org/show_bug.cgi?id=186090
<rdar://problem/40692595>
Reviewed by Andy Estes.
Source/WebCore:
Fix up Content Security Policy logic for checking the frame ancestors now that we
exclude the frame that initiated the load request.
Test: http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowFrameAncestors const):
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::checkFrameAncestors):
Source/WebKit:
Fixes an issue where a page P delivered with "X-Frame-Options: SAMEORIGIN" loaded in a sub-
frame would be blocked if we were redirected to it in response to the cross-origin POST
request regardless of whether P is same-origin with its parent document.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::shouldInterruptLoadForXFrameOptions): Compare the origin
of the top frame's document as opposed to the source origin. The latter represents the
origin of the document that initiated the navigation, which can be cross-origin, and
should not be considered when applying "X-Frame-Options: SAMEORIGIN". This check exists
as a performance optimization to avoid traversing over all frame ancestors only to find
out that the innermost frame (the one that made this request) is cross-origin with the
top-most frame.
- NetworkProcess/NetworkResourceLoader.h:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): Exclude the origin of the
frame that is making the load request from the list of ancestor origins. This makes the
X-Frame-Options algorithm in WebKit2 match the logic we do in FrameLoader::shouldInterruptLoadForXFrameOptions().
LayoutTests:
Add a test to ensure that we allow a same-origin page with "X-Frame-Options: SAMEORIGIN" to
load as a result of a redirected cross-origin POST request.
- http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow-expected.txt: Added.
- http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html: Added.
- http/tests/security/XFrameOptions/resources/post-form-to-x-frame-options-parent-same-origin-allow.html: Added.
- http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-allow.cgi:
- 6:08 PM Changeset in webkit [233236] by
-
- 25 edits in trunk
JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary
https://bugs.webkit.org/show_bug.cgi?id=186878
<rdar://problem/40568659>
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This patch fixes a bug in our JSImmutableButterfly implementation uncovered by
our stress GC bots. Before this patch, JSImmutableButterfly was allocated
with HeapCell::Kind::Auxiliary. This is wrong. Things that are JSCells can't
be allocated from HeapCell::Kind::Auxiliary. This patch adds a new HeapCell::Kind
called JSCellWithInteriorPointers. It behaves like JSCell in all ways, except
conservative scan knows to treat it like a butterfly in when we we may be
pointing into the middle of it.
The way we were crashing on the stress GC bots is that our conservative marking
won't do cell visiting for things that are Auxiliary. This meant that if the
stack were the only thing pointing to a JSImmutableButterfly when a GC took place,
that JSImmutableButterfly would not be visited. This is now fixed.
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
- debugger/Debugger.cpp:
- heap/ConservativeRoots.cpp:
(JSC::ConservativeRoots::genericAddPointer):
- heap/Heap.cpp:
(JSC::GatherHeapSnapshotData::operator() const):
(JSC::RemoveDeadHeapSnapshotNodes::operator() const):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::deleteAllCodeBlocks):
- heap/HeapCell.cpp:
(WTF::printInternal):
- heap/HeapCell.h:
(JSC::isJSCellKind):
(JSC::hasInteriorPointers):
- heap/HeapUtil.h:
(JSC::HeapUtil::findGCObjectPointersForMarking):
(JSC::HeapUtil::isPointerGCObjectJSCell):
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::Handle::didAddToDirectory):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::appendJSCellOrAuxiliary):
- runtime/JSGlobalObject.cpp:
- runtime/JSImmutableButterfly.h:
(JSC::JSImmutableButterfly::subspaceFor):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- tools/CellProfile.h:
(JSC::CellProfile::CellProfile):
(JSC::CellProfile::isJSCell const):
- tools/HeapVerifier.cpp:
(JSC::HeapVerifier::validateCell):
LayoutTests:
Make these test not susceptible to conservative scan leaks by ensuring at least
one object gets collected when we allocate many of them. Before, these were just
testing that a fixed number of objects were collected.
- editing/selection/navigation-clears-editor-state-expected.txt:
- editing/selection/navigation-clears-editor-state.html:
- fast/dom/reference-cycle-leaks.html:
- fast/misc/resources/test-observegc.js:
- fast/misc/test-observegc-expected.txt:
- platform/mac-wk2/plugins/refcount-leaks-expected.txt:
- plugins/refcount-leaks-expected.txt:
- plugins/refcount-leaks.html:
- 6:07 PM Changeset in webkit [233235] by
-
- 7 edits in trunk/Tools
[ews-build] Add support for compiling WebKit
https://bugs.webkit.org/show_bug.cgi?id=187019
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/steps.py:
(CompileWebKit): Added, class to compile WebKit.
(CleanBuild): Added, class to clean up the build.
(KillOldProcesses): Added, class to kill old processes.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- BuildSlaveSupport/ews-build/config.json: Renamed ios-11-simulator to ios-simulator-11, to match with build.webkit.org code.
Added configuration, architecture which is required for compiling. Renamed Release to release as the tools expect lower-case release.
- BuildSlaveSupport/ews-build/factories.py: Added BuildFactory.
- BuildSlaveSupport/ews-build/loadConfig.py: Renamed configuraton value to lower-case as tools expect lower-case values.
- BuildSlaveSupport/ews-build/loadConfig_unittest.py: Ditto.
- 5:43 PM Changeset in webkit [233234] by
-
- 2 edits in trunk/Source/JavaScriptCore
Skip some unnecessary work in Interpreter::getStackTrace().
https://bugs.webkit.org/show_bug.cgi?id=187070
Reviewed by Michael Saboff.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):
- 5:41 PM Changeset in webkit [233233] by
-
- 2 edits2 adds in trunk/LayoutTests
[iOS] Rebaseline two webanimations tests after r233164
https://bugs.webkit.org/show_bug.cgi?id=187071
Unreviewed gardening
Patch by Truitt Savell <Truitt Savell> on 2018-06-26
- platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- platform/ios/webanimations/opacity-animation-yields-compositing-span-expected.txt: Added.
- 5:31 PM Changeset in webkit [233232] by
-
- 6 edits in trunk/Source/WebKit
Remove quarantine for Webex plugin
https://bugs.webkit.org/show_bug.cgi?id=187050
rdar://problem/41478189
Reviewed by Brent Fulgham.
Update the Plugin Info.plist to not do quarantine of downloaded files by default.
Update PluginProcess implementation to reenable quarantine for all plug-ins except cisco webex plug-in.
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::shouldOverrideQuarantine):
- Shared/ChildProcess.h:
(WebKit::ChildProcess::shouldOverrideQuarantine):
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::initializeSandbox):
- 5:25 PM Changeset in webkit [233231] by
-
- 2 edits in trunk/Source/WebKit
Ensure element fullscreen animation is always visible.
https://bugs.webkit.org/show_bug.cgi?id=187068
rdar://problem/36187369
Patch by Jeremy Jones <jeremyj@apple.com> on 2018-06-26
Reviewed by Eric Carlson.
The fullscreen animation is important for communicating to users that they are no longer in inline mode.
If fullscreen animation's inline rect is not visible, animate from a point in the middle of the screen.
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(WebKit::safeInlineRect):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
- 5:22 PM Changeset in webkit [233230] by
-
- 2 edits1 add in trunk/Source/WebKit
Add a sandbox profile for com.google.o1dbrowserplugin plugin
https://bugs.webkit.org/show_bug.cgi?id=187067
Reviewed by Brent Fulgham.
- Resources/PlugInSandboxProfiles/com.google.o1dbrowserplugin.sb: Added.
- WebKit.xcodeproj/project.pbxproj:
- 5:16 PM Changeset in webkit [233229] by
-
- 5 edits in trunk/Tools
[ews-build] Add support for WebKitPerl-Tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187023
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/config.json: Added WebKitPerl-tests-EWS.
- BuildSlaveSupport/ews-build/factories.py: Added WebKitPerlFactory.
- BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPerlTests.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
- 5:10 PM Changeset in webkit [233228] by
-
- 2 edits in trunk/Tools
[build.webkit.org] Rename badly named variable kls to schedulerType
https://bugs.webkit.org/show_bug.cgi?id=186926
Reviewed by Lucas Forschler.
- BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
(loadBuilderConfig): Renamed kls to schedulerType.
- 4:22 PM Changeset in webkit [233227] by
-
- 2 edits in trunk/Source/WebKit
Promote two more experimental features to traditional features
https://bugs.webkit.org/show_bug.cgi?id=187063
Reviewed by Dean Jackson.
- Shared/WebPreferences.yaml:
Promote some shipped/default-on features to non-experimental.
- 3:28 PM Changeset in webkit [233226] by
-
- 2 edits in trunk/Source/WebKit
Rollout macOS sandbox change in r232276
https://bugs.webkit.org/show_bug.cgi?id=186904
<rdar://problem/41350969>
Patch by Jiewen Tan <jiewen_tan@apple.com> on 2018-06-26
Reviewed by Brent Fulgham.
- NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
- 3:20 PM Changeset in webkit [233225] by
-
- 2 edits in trunk/Source/WebKit
Tap highlight displayed when tapping a field that is already focussed
https://bugs.webkit.org/show_bug.cgi?id=187004
<rdar://problem/41428008>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-06-26
Reviewed by Tim Horton.
In the case where fast-clicking is enabled, _singleTapCommited: could be invoked
before the tap highlight request, causing _potentialTapInProgress to be set to NO.
This results in the early return for preventing multiple tap highlights on an
assisted node to be skipped. Since a tap highlight should never be shown for an
input field that is already focussed, _potentialTapInProgress can be removed from
the early return condition.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
- 3:18 PM Changeset in webkit [233224] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r232314): Flaky Test: imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
https://bugs.webkit.org/show_bug.cgi?id=186161
Unreviewed gardening.
Patch by Truitt Savell <Truitt Savell> on 2018-06-26
- 2:45 PM Changeset in webkit [233223] by
-
- 1 copy in tags/Safari-606.1.22.2
Tag Safari-606.1.22.2.
- 2:42 PM Changeset in webkit [233222] by
-
- 2 edits in trunk/Source/WebCore
Simplify NetworkStorageSession::getAllStorageAccessEntries()
https://bugs.webkit.org/show_bug.cgi?id=187016
Reviewed by Youenn Fablet.
Iterate over the HashMaps' values instead of iterating over their keys and then looking them
up in the HashMap.
- platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::getAllStorageAccessEntries const):
- 2:15 PM Changeset in webkit [233221] by
-
- 7 edits in branches/safari-606.1.22-branch/Source
Versioning.
- 2:13 PM Changeset in webkit [233220] by
-
- 3 edits in trunk/Tools
EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
https://bugs.webkit.org/show_bug.cgi?id=187061
Reviewed by Per Arne Vollan.
When EWS invokes webkit-patch to perform an operation (e.g. apply an attachment)
it should pass the command line option --status-host-uses-http, if EWS was
started with this command line option, so that we query the status server over
HTTP in child "webkit-patch" processes as we do in the main EWS process.
- Scripts/webkitpy/common/net/statusserver_mock.py:
(MockStatusServer.init):
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractQueue.run_webkit_patch):
- 1:54 PM Changeset in webkit [233219] by
-
- 4 edits in trunk/Tools
webkit-patch: Make attachment commands work with status-server hosted attachments
https://bugs.webkit.org/show_bug.cgi?id=187056
Reviewed by Per Arne Vollan.
Allow the EWS bots to apply, build, test, check-style, and (in the future) land
attachments hosted on the status server. We only download an attachment from the
status server if we do not have sufficient permission to download it from Bugzilla
(e.g. security-sensitive patches).
A valid status server API key is required to run these commands by hand. Otherwise,
the status server will not provide attachment data.
- Scripts/webkitpy/common/net/statusserver_mock.py:
(MockStatusServer.fetch_attachment): Log a message for testing purposes.
- Scripts/webkitpy/tool/commands/download.py:
(ProcessAttachmentsMixin._fetch_list_of_patches_to_process): Fetch the attachment
from the status server if we do not have permission to fetch it from Bugzilla.
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSystemTest._default_expected_logs): Update expected result when
using a custom work item and when fetching an attachment from the status server.
(_test_ews): Modified to take use_security_sensitive_patch (defaults to False) as
to whether to use a security-sensitive patch when testing.
(test_ewses_with_security_sensitive_patch): Added.
- 1:38 PM Changeset in webkit [233218] by
-
- 2 edits in trunk/Source/WebKit
Rearrange some WebPreferences; move two non-experimental prefs out of the experimental section
- Shared/WebPreferences.yaml:
- 1:37 PM Changeset in webkit [233217] by
-
- 3 edits1 add in trunk
ASSERTION FAILED: length > butterfly->vectorLength() in JSObject::ensureLengthSlow().
https://bugs.webkit.org/show_bug.cgi?id=187060
<rdar://problem/41452767>
Reviewed by Keith Miller.
JSTests:
- stress/regress-187060.js: Added.
Source/JavaScriptCore:
JSObject::ensureLengthSlow() may be called only because it needs to do a copy on
write conversion. Hence, we can return early after the conversion if the vector
length is already sufficient to cover the requested length.
- runtime/JSObject.cpp:
(JSC::JSObject::ensureLengthSlow):
- 12:39 PM Changeset in webkit [233216] by
-
- 2 edits in trunk/Source/bmalloc
Unreviewed followup. Fix the watchos build after r233192.
This patch also correct the changelog entry below to have the correct
bug and title info.
- bmalloc/ProcessCheck.mm:
- 12:27 PM Changeset in webkit [233215] by
-
- 2 edits in trunk/Source/WebKit
Promote some experimental features to traditional features
https://bugs.webkit.org/show_bug.cgi?id=187047
Reviewed by Simon Fraser.
- Shared/WebPreferences.yaml:
Reindent.
Promote some shipped/default-on features to non-experimental.
- 12:14 PM Changeset in webkit [233214] by
-
- 13 edits in trunk/Source
[Mac] AirPlay picker uses incorrect theme in Dark mode
https://bugs.webkit.org/show_bug.cgi?id=187054
<rdar://problem/41291093>
Reviewed by Timothy Hatcher.
Source/WebCore:
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Add useDefaultAppearance parameter.
- Modules/mediasession/WebMediaSessionManager.h:
- platform/graphics/MediaPlaybackTargetPicker.cpp:
(WebCore::MediaPlaybackTargetPicker::showPlaybackTargetPicker): Ditto.
- platform/graphics/MediaPlaybackTargetPicker.h:
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
- platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Choose theme based on
useDefaultAppearance parameter.
- platform/mock/MediaPlaybackTargetPickerMock.cpp:
(WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker): Log parameter.
- platform/mock/MediaPlaybackTargetPickerMock.h:
Source/WebKit:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPlaybackTargetPicker): Pass m_defaultAppearance.
Source/WebKitLegacy/mac:
- WebView/WebMediaPlaybackTargetPicker.mm:
(WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().
- 12:14 PM Changeset in webkit [233213] by
-
- 13 edits in trunk
Unreviewed, rolling out r233184.
https://bugs.webkit.org/show_bug.cgi?id=187059
"It regressed JetStream between 5-8%" (Requested by saamyjoon
on #webkit).
Reverted changeset:
"JSImmutableButterfly can't be allocated from a subspace with
HeapCell::Kind::Auxiliary"
https://bugs.webkit.org/show_bug.cgi?id=186878
https://trac.webkit.org/changeset/233184
- 12:13 PM Changeset in webkit [233212] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=187048
Unreviewed gardening.
- platform/gtk/TestExpectations:
- 11:45 AM Changeset in webkit [233211] by
-
- 2 edits in trunk/Tools
contributors.json fails to parse after r233209
Removing trailing ',' that caused this file to be malformed. Also ran
"validate-committer-lists -c" to canonicalize the style of this file.
- Scripts/webkitpy/common/config/contributors.json:
- 11:40 AM Changeset in webkit [233210] by
-
- 7 edits in trunk/Source
Versioning.
- 11:28 AM Changeset in webkit [233209] by
-
- 2 edits in trunk/Tools
Add Aditya to contributors.json as a contributor
- Scripts/webkitpy/common/config/contributors.json:
- 11:26 AM Changeset in webkit [233208] by
-
- 2 edits in trunk/Source/WebKit
Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback
https://bugs.webkit.org/show_bug.cgi?id=186903
<rdar://problem/41350182>
Reviewed by Brady Eidson.
Follow-up fix after r233180 to address an API test crash. We need to keep the
NetworkProcessProxy alive during the async updatePrevalentDomainsToPartitionOrBlockCookies
request to make sure it completes.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::updatePrevalentDomainsToPartitionOrBlockCookies):
- 11:16 AM Changeset in webkit [233207] by
-
- 9 edits3 copies1 add in trunk
Provide a way for Injected Bundles to indicate classes approved for NSSecureCoding
https://bugs.webkit.org/show_bug.cgi?id=186788
<rdar://problem/41094167>
Reviewed by Chris Dumez.
Source/WebKit:
InjectedBundles support a mechanism to serialize data between the UIProcess and the
WebContent process hosting the bundle. In some cases, we want to be able to serialize
a custom data object that is not part of WebKit's native data types.
After switching to strict NSSecureCoding, WebKit clients attempting to serialize these
custom objects trigger a failure.
This patch makes it possible for the InjectedBundle author to specify one (or more) data
classes that are allowed to be serialized between the two processes.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleExtendClassesForParameterCoder): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
(createWKArray): Added.
(-[WKWebProcessPlugInController extendClassesForParameterCoder:]): Added.
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
(WebKit::InjectedBundle::extendClassesForParameterCoder): Added.
(WebKit::InjectedBundle::classesForCoder): New helper function.
(WebKit::InjectedBundle::setBundleParameter): Modified to use the new set of valid
classes for NSSecureCoding.
Tools:
Add a new test case to exercise the class check during NSSecureCoding.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h: Added.
- TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.mm: Added.
(-[CustomBundleObject initWithValue:]):
(+[CustomBundleObject supportsSecureCoding]):
(-[CustomBundleObject copyWithZone:]):
(-[CustomBundleObject initWithCoder:]):
(-[CustomBundleObject encodeWithCoder:]):
- TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm: Added.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
- TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm: Added.
(TestWebKitAPI::CustomBundleParameterTest::CustomBundleParameterTest):
(TestWebKitAPI::CustomBundleParameterTest::didCreatePage):
- 11:00 AM Changeset in webkit [233206] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r233065): Build broken with clang-3.8 and libstdc++-5
https://bugs.webkit.org/show_bug.cgi?id=187051
Reviewed by Mark Lam.
Revert r233065 changes over UnlinkedCodeBlock.h to allow
clang-3.8 to be able to compile this back (with libstdc++5)
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::decompressArrayAllocationProfile):
- 10:50 AM Changeset in webkit [233205] by
-
- 2 edits in trunk/LayoutTests
Layout Test http/tests/resourceLoadStatistics/prevalent-resource-without-user-interaction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187053
Unreviewed test gardening.
Patch by Truitt Savell <Truitt Savell> on 2018-06-26
- platform/wk2/TestExpectations:
- 10:38 AM Changeset in webkit [233204] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix testapi build when DFG_JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=187038
Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-06-26
Reviewed by Mark Lam.
r233158 added a new API and tests for configuring the number of JIT threads, but
the API is only available when DFG_JIT is enabled and so should the tests.
- API/tests/testapi.mm:
(runJITThreadLimitTests):
- 10:06 AM Changeset in webkit [233203] by
-
- 5 edits in trunk
Enable mock capture devices on the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=186846
<rdar://problem/41289134>
Reviewed by Youenn Fablet.
Source/WebKit:
- Shared/WebPreferences.yaml: Use DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED.
- Shared/WebPreferencesDefaultValues.h: Define DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED, set to
true in the iOS simulator only.
LayoutTests:
- platform/ios/TestExpectations: Unskip fast/mediastream/getUserMedia-default.html.
- 9:58 AM Changeset in webkit [233202] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Do not forget to set stream on track switching
https://bugs.webkit.org/show_bug.cgi?id=187049
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-06-26
Reviewed by Philippe Normand.
This was an overlooked issue introduced in Bug #186678
This is already tested, but we currently run only tests against playbin2
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::enableTrack):
- 9:45 AM Changeset in webkit [233201] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Fixed positioning is a subcategory of absolute positioning.
https://bugs.webkit.org/show_bug.cgi?id=187043
Reviewed by Antti Koivisto.
https://www.w3.org/TR/CSS22/visuren.html#absolute-positioning
References in this specification to an absolutely positioned element (or its box) imply that the element's 'position'
property has the value 'absolute' or 'fixed'.
- layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isAbsolutelyPositioned const):
- layout/layouttree/LayoutBox.h:
(WebCore::Layout::Box::isOutOfFlowPositioned const):
- 8:39 AM WebKitGTK/2.20.x edited by
- (diff)
- 8:27 AM Changeset in webkit [233200] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r233143.
https://bugs.webkit.org/show_bug.cgi?id=187046
broke media/video-ended-event-negative-playback.html
(Requested by philn on #webkit).
Reverted changeset:
"[GStreamer] Remove useless workaround"
https://bugs.webkit.org/show_bug.cgi?id=186921
https://trac.webkit.org/changeset/233143
- 7:23 AM Changeset in webkit [233199] by
-
- 2 edits in trunk/LayoutTests
Layout Test imported/mozilla/css-animations/test_animation-pausing.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=187041
Unreviewed test gardening.
- platform/win/TestExpectations:
- 6:36 AM Changeset in webkit [233198] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Computed height for in-flow non-replaced should not include padding and border.
https://bugs.webkit.org/show_bug.cgi?id=187031
Reviewed by Antti Koivisto.
In certain cases the height of a non-replaced in-flow box is computed using the bottom position of its last in-flow child.
The in-flow child's bottom position is in the coordinate system of the containing block's border box (border box's top left is 0, 0) ->
it includes both the (top) border and the padding of the containing block.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- 6:01 AM Changeset in webkit [233197] by
-
- 5 edits196 adds in trunk/LayoutTests
Import WPT tests for webmessaging
https://bugs.webkit.org/show_bug.cgi?id=187001
Patch by Frederic Wang <fwang@igalia.com> on 2018-06-26
Reviewed by Javier Fernandez.
LayoutTests/imported/w3c:
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/webmessaging/Channel_postMessage_Blob-expected.txt: Added.
- web-platform-tests/webmessaging/Channel_postMessage_Blob.htm: Added.
- web-platform-tests/webmessaging/Channel_postMessage_DataCloneErr-expected.txt: Added.
- web-platform-tests/webmessaging/Channel_postMessage_DataCloneErr.htm: Added.
- web-platform-tests/webmessaging/Channel_postMessage_clone_port-expected.txt: Added.
- web-platform-tests/webmessaging/Channel_postMessage_clone_port.htm: Added.
- web-platform-tests/webmessaging/Channel_postMessage_clone_port_error-expected.txt: Added.
- web-platform-tests/webmessaging/Channel_postMessage_clone_port_error.htm: Added.
- web-platform-tests/webmessaging/Channel_postMessage_event_properties-expected.txt: Added.
- web-platform-tests/webmessaging/Channel_postMessage_event_properties.htm: Added.
- web-platform-tests/webmessaging/Channel_postMessage_ports_readonly_array-expected.txt: Added.
- web-platform-tests/webmessaging/Channel_postMessage_ports_readonly_array.htm: Added.
- web-platform-tests/webmessaging/Channel_postMessage_target_source-expected.txt: Added.
- web-platform-tests/webmessaging/Channel_postMessage_target_source.htm: Added.
- web-platform-tests/webmessaging/META.yml: Added.
- web-platform-tests/webmessaging/MessageEvent-expected.txt: Added.
- web-platform-tests/webmessaging/MessageEvent-trusted-expected.txt: Added.
- web-platform-tests/webmessaging/MessageEvent-trusted-worker.js: Added.
- web-platform-tests/webmessaging/MessageEvent-trusted.html: Added.
- web-platform-tests/webmessaging/MessageEvent.html: Added.
- web-platform-tests/webmessaging/MessageEvent_onmessage_postMessage_infinite_loop.html: Added.
- web-platform-tests/webmessaging/MessageEvent_properties.htm: Added.
- web-platform-tests/webmessaging/MessagePort_initial_disabled-expected.txt: Added.
- web-platform-tests/webmessaging/MessagePort_initial_disabled.htm: Added.
- web-platform-tests/webmessaging/MessagePort_onmessage_start-expected.txt: Added.
- web-platform-tests/webmessaging/MessagePort_onmessage_start.htm: Added.
- web-platform-tests/webmessaging/README.md: Added.
- web-platform-tests/webmessaging/Transferred_objects_unusable.sub.htm: Added.
- web-platform-tests/webmessaging/broadcastchannel/basics-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/basics.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/blobs-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/blobs.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/interface-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/interface.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/origin.window.js: Added.
- web-platform-tests/webmessaging/broadcastchannel/resources/origin.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/resources/sandboxed.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/resources/w3c-import.log: Added.
- web-platform-tests/webmessaging/broadcastchannel/resources/worker.js: Added.
(handler):
- web-platform-tests/webmessaging/broadcastchannel/sandbox-expected.txt: Added.
- web-platform-tests/webmessaging/broadcastchannel/sandbox.html: Added.
- web-platform-tests/webmessaging/broadcastchannel/w3c-import.log: Added.
- web-platform-tests/webmessaging/broadcastchannel/workers.html: Added.
- web-platform-tests/webmessaging/event.data.sub.htm: Added.
- web-platform-tests/webmessaging/event.origin.sub.htm: Added.
- web-platform-tests/webmessaging/event.ports.sub.htm: Added.
- web-platform-tests/webmessaging/event.source.htm: Added.
- web-platform-tests/webmessaging/event.source.xorigin.sub.htm: Added.
- web-platform-tests/webmessaging/message-channels/001-expected.txt: Added.
- web-platform-tests/webmessaging/message-channels/001.html: Added.
- web-platform-tests/webmessaging/message-channels/002-expected.txt: Added.
- web-platform-tests/webmessaging/message-channels/002.html: Added.
- web-platform-tests/webmessaging/message-channels/003-expected.txt: Added.
- web-platform-tests/webmessaging/message-channels/003.html: Added.
- web-platform-tests/webmessaging/message-channels/004-1.html: Added.
- web-platform-tests/webmessaging/message-channels/004-2.html: Added.
- web-platform-tests/webmessaging/message-channels/004-expected.txt: Added.
- web-platform-tests/webmessaging/message-channels/004.html: Added.
- web-platform-tests/webmessaging/message-channels/close-expected.txt: Added.
- web-platform-tests/webmessaging/message-channels/close.html: Added.
- web-platform-tests/webmessaging/message-channels/w3c-import.log: Added.
- web-platform-tests/webmessaging/message-channels/worker-expected.txt: Added.
- web-platform-tests/webmessaging/message-channels/worker.html: Added.
- web-platform-tests/webmessaging/messageerror-expected.txt: Added.
- web-platform-tests/webmessaging/messageerror.html: Added.
- web-platform-tests/webmessaging/postMessage_ArrayBuffer.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_Date.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_Document-expected.txt: Added.
- web-platform-tests/webmessaging/postMessage_Document.htm: Added.
- web-platform-tests/webmessaging/postMessage_Function-expected.txt: Added.
- web-platform-tests/webmessaging/postMessage_Function.htm: Added.
- web-platform-tests/webmessaging/postMessage_MessagePorts_sorigin.htm: Added.
- web-platform-tests/webmessaging/postMessage_MessagePorts_xorigin.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_arrays.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_asterisk_xorigin.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_dup_transfer_objects-expected.txt: Added.
- web-platform-tests/webmessaging/postMessage_dup_transfer_objects.htm: Added.
- web-platform-tests/webmessaging/postMessage_invalid_targetOrigin-expected.txt: Added.
- web-platform-tests/webmessaging/postMessage_invalid_targetOrigin.htm: Added.
- web-platform-tests/webmessaging/postMessage_objects.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_origin_mismatch.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_origin_mismatch_xorigin.sub.htm: Added.
- web-platform-tests/webmessaging/postMessage_solidus_sorigin.htm: Added.
- web-platform-tests/webmessaging/postMessage_solidus_xorigin.sub.htm: Added.
- web-platform-tests/webmessaging/w3c-import.log: Added.
- web-platform-tests/webmessaging/with-ports/001-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/001.html: Added.
- web-platform-tests/webmessaging/with-ports/002-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/002.html: Added.
- web-platform-tests/webmessaging/with-ports/003-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/003.html: Added.
- web-platform-tests/webmessaging/with-ports/004-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/004.html: Added.
- web-platform-tests/webmessaging/with-ports/005-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/005.html: Added.
- web-platform-tests/webmessaging/with-ports/006-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/006.html: Added.
- web-platform-tests/webmessaging/with-ports/007-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/007.html: Added.
- web-platform-tests/webmessaging/with-ports/010-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/010.html: Added.
- web-platform-tests/webmessaging/with-ports/011-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/011.html: Added.
- web-platform-tests/webmessaging/with-ports/012-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/012.html: Added.
- web-platform-tests/webmessaging/with-ports/013-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/013.html: Added.
- web-platform-tests/webmessaging/with-ports/014-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/014.html: Added.
- web-platform-tests/webmessaging/with-ports/015-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/015.html: Added.
- web-platform-tests/webmessaging/with-ports/016-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/016.html: Added.
- web-platform-tests/webmessaging/with-ports/017-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/017.html: Added.
- web-platform-tests/webmessaging/with-ports/018-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/018.html: Added.
- web-platform-tests/webmessaging/with-ports/019-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/019.html: Added.
- web-platform-tests/webmessaging/with-ports/020.html: Added.
- web-platform-tests/webmessaging/with-ports/021.html: Added.
- web-platform-tests/webmessaging/with-ports/023-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/023.html: Added.
- web-platform-tests/webmessaging/with-ports/024-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/024.html: Added.
- web-platform-tests/webmessaging/with-ports/025-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/025.html: Added.
- web-platform-tests/webmessaging/with-ports/026-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/026.html: Added.
- web-platform-tests/webmessaging/with-ports/027-expected.txt: Added.
- web-platform-tests/webmessaging/with-ports/027.html: Added.
- web-platform-tests/webmessaging/with-ports/w3c-import.log: Added.
- web-platform-tests/webmessaging/without-ports/001-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/001.html: Added.
- web-platform-tests/webmessaging/without-ports/002-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/002.html: Added.
- web-platform-tests/webmessaging/without-ports/003-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/003.html: Added.
- web-platform-tests/webmessaging/without-ports/004-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/004.html: Added.
- web-platform-tests/webmessaging/without-ports/005-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/005.html: Added.
- web-platform-tests/webmessaging/without-ports/006-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/006.html: Added.
- web-platform-tests/webmessaging/without-ports/007-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/007.html: Added.
- web-platform-tests/webmessaging/without-ports/008-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/008.html: Added.
- web-platform-tests/webmessaging/without-ports/009-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/009.html: Added.
- web-platform-tests/webmessaging/without-ports/010-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/010.html: Added.
- web-platform-tests/webmessaging/without-ports/011-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/011.html: Added.
- web-platform-tests/webmessaging/without-ports/012-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/012.html: Added.
- web-platform-tests/webmessaging/without-ports/013-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/013.html: Added.
- web-platform-tests/webmessaging/without-ports/014-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/014.html: Added.
- web-platform-tests/webmessaging/without-ports/015-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/015.html: Added.
- web-platform-tests/webmessaging/without-ports/016-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/016.html: Added.
- web-platform-tests/webmessaging/without-ports/017-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/017.html: Added.
- web-platform-tests/webmessaging/without-ports/018-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/018.html: Added.
- web-platform-tests/webmessaging/without-ports/019-1.html: Added.
- web-platform-tests/webmessaging/without-ports/019-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/019.html: Added.
- web-platform-tests/webmessaging/without-ports/020-1.html: Added.
- web-platform-tests/webmessaging/without-ports/020.html: Added.
- web-platform-tests/webmessaging/without-ports/021.html: Added.
- web-platform-tests/webmessaging/without-ports/023-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/023.html: Added.
- web-platform-tests/webmessaging/without-ports/024-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/024.html: Added.
- web-platform-tests/webmessaging/without-ports/025-1.js: Added.
(test):
- web-platform-tests/webmessaging/without-ports/025-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/025.html: Added.
- web-platform-tests/webmessaging/without-ports/026-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/026.html: Added.
- web-platform-tests/webmessaging/without-ports/027-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/027.html: Added.
- web-platform-tests/webmessaging/without-ports/028-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/028.html: Added.
- web-platform-tests/webmessaging/without-ports/029-expected.txt: Added.
- web-platform-tests/webmessaging/without-ports/029.html: Added.
- web-platform-tests/webmessaging/without-ports/w3c-import.log: Added.
LayoutTests:
Skip some webmessaging tests timing out.
- 5:30 AM Changeset in webkit [233196] by
-
- 4 edits in trunk
Crash in WebAnimation::runPendingPlayTask
https://bugs.webkit.org/show_bug.cgi?id=186189
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Avoid crashes on nullopt std::optional dereference in the
runPendingPlayTask() and runPendingPauseTask() methods of the
WebAnimation class by defaulting to a Seconds(0) value.
In both cases the std::optional value is the current time retrieved from
the associated DocumentTimeline object. But there's no guarantee that
the timeline is active and the resulting time value is resolved (i.e.
not nullopt). Dereferencing the nullopt Seconds value doesn't cause a
problem on configurations still building as C++14 and the fallback
std::optional implementation provided by WTF -- no signal is raised, and
a 0 value is returned. Configurations building as C++17 on the other
hand use the stdlib-provided std::optional that does raise a signal on
invalid access, leading to crashes.
The default-to-Seconds(0) solution avoids crashes on configurations
that build with C++17 support enabled, and thus match configurations
that are still using WTF's std::optional. This still doesn't address the
underlying problem of retrieving current time from an inactive document
timeline and using it as ready time for the pending play/pause task
execution.
runPendingPlayTask() change addresses crashes in the following tests:
- fast/animation/css-animation-resuming-when-visible.html
- fast/animation/css-animation-resuming-when-visible-with-style-change.html
- imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html
- imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html
runPendingPauseTask() change addresses crashes in the following tests:
- animations/multiple-animations-timing-function.html
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::runPendingPauseTask):
LayoutTests:
- platform/wpe/TestExpectations: Remove crashing expectations for fixed tests.
- 2:50 AM Changeset in webkit [233195] by
-
- 2 edits in trunk/Source/WebKit
[Win] 'deref': is not a member of 'WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains::<lambda_9d761a6dc12d95db7fa2d6f3f5aa26fa>'
https://bugs.webkit.org/show_bug.cgi?id=187035
Unreviewed build fix.
MSVC can't compile the code using
thisin a generalized lambda
capture in another lambda.
In this case, there is no need to copy
protectedThisfor the
inner lambda. MoveprotectedThisof the outer lambda to the
inner as well ascompletionHandler.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
MovedprotectedThisfrom the outer lambda to the inner.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):
Ditto.
- 2:44 AM Changeset in webkit [233194] by
-
- 2 edits in trunk/Source/WebCore
[Web Animations] Show the feature as "Supported in Preview"
https://bugs.webkit.org/show_bug.cgi?id=187037
Patch by Antoine Quint <Antoine Quint> on 2018-06-26
Reviewed by Dean Jackson.
Web Animations are enabled by default in STP.
- features.json:
- 2:12 AM Changeset in webkit [233193] by
-
- 6 edits in trunk/Source
[GTK] Many webpages can crash the browser in WebCore::CoordinatedGraphicsLayer::transformedVisibleRect
https://bugs.webkit.org/show_bug.cgi?id=179304
Reviewed by Michael Catanzaro.
Source/WebCore:
When adding new CoordinatedGraphicsLayers to the tree, check that they have the appropriate
CompositingCoordinator. If that's not the case, set the appropriate one to the layer and its
children and set the state of those layers so they are rendered properly.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Source/WebKit:
Add a way to attach to the CompositingCoordinator layers that were not created by it.
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::attachLayer):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
- 12:38 AM Changeset in webkit [233192] by
-
- 5 edits in trunk/Source/bmalloc
Wasm: Any function argument of type Void should be a validation error
https://bugs.webkit.org/show_bug.cgi?id=186794
<rdar://problem/41140257>
Reviewed by Keith Miller.
We have evidence showing that processes with small heaps using the
JS API are more space efficient when using system malloc. Our main
hypothesis as to why this is, is that when dealing with small heaps,
one malloc can be more efficient at optimizing memory usage than
two mallocs.
- bmalloc/BPlatform.h:
- bmalloc/Environment.cpp:
(bmalloc::isNanoMallocEnabled):
(bmalloc::Environment::computeIsDebugHeapEnabled):
- bmalloc/ProcessCheck.h:
(bmalloc::shouldProcessUnconditionallyUseBmalloc):
- bmalloc/ProcessCheck.mm:
(bmalloc::shouldProcessUnconditionallyUseBmalloc):
Jun 25, 2018:
- 10:47 PM Changeset in webkit [233191] by
-
- 6 edits25 adds in trunk/LayoutTests
Import WPT fetch destination tests
https://bugs.webkit.org/show_bug.cgi?id=186984
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/request/destination/fetch-destination-iframe.https-expected.txt: Added.
- web-platform-tests/fetch/api/request/destination/fetch-destination-iframe.https.html: Added.
- web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html: Added.
- web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https-expected.txt: Added.
- web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html: Added.
- web-platform-tests/fetch/api/request/destination/fetch-destination.https.html: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy.es: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy.es.headers: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy.html: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy.png: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy.ttf: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy_audio.mp3: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy_audio.oga: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy_video.mp4: Added.
- web-platform-tests/fetch/api/request/destination/resources/dummy_video.ogv: Added.
- web-platform-tests/fetch/api/request/destination/resources/empty.https.html: Added.
- web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker-iframe.js: Added.
(event.request.url.includes.):
(event.request.url.includes):
- web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker-no-load-event.js: Added.
(event.request.url.includes):
- web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker.js: Added.
(event.request.url.includes):
- web-platform-tests/fetch/api/request/destination/resources/importer.js: Added.
- web-platform-tests/fetch/api/request/destination/resources/w3c-import.log: Added.
- web-platform-tests/fetch/api/request/destination/w3c-import.log: Added.
LayoutTests:
Skipping tests for WK1 since they use service worker.
- TestExpectations: Skipping timing out tests.
- platform/ios-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- 9:58 PM Changeset in webkit [233190] by
-
- 2 edits in trunk/Tools
Log a message when fetching attachment data from the status server
https://bugs.webkit.org/show_bug.cgi?id=187032
Reviewed by Zalan Bujtas.
Currently we silently fetch from the status server an attachment when fetching
the attachment from Bugzilla fails due to an access denied error. Instead we
should emit a message when fetching data from the status server to indicate
that webkit-patch/EWS is still processing the command/trying to obtain the
patch.
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._fetch_attachment_page):
- 7:05 PM Changeset in webkit [233189] by
-
- 18 edits in trunk/Source/WebCore
Adjust WEBCORE_EXPORT annotations for LTO
https://bugs.webkit.org/show_bug.cgi?id=186944
<rdar://problem/41384880>
Reviewed by David Kilzer.
Adjust a number of places that result in WebKit's
'check-for-weak-vtables-and-externals' script reporting weak external
symbols:
ERROR: WebCore has a weak external symbol in it (/Volumes/Data/dev/webkit/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
...
These cases are caused by inline methods being marked with WTF_EXPORT
(or related macro) or with an inline function being in a class marked
as such, and when enabling LTO builds.
For the most part, address these by removing the WEBCORE_EXPORT
annotation from inline methods. In some cases, move the implementation
out-of-line because it's the class that has the WEBCORE_EXPORT on it
and removing the annotation from the class would be too disruptive.
Finally, in other cases, move the implementation out-of-line because
check-for-weak-vtables-and-externals still complains when keeping the
implementation inline and removing the annotation; this seems to
typically (but not always) happen with destructors.
No new tests. There is no changed functionality. Only the annotation
and treatment of inline methods are altered.
- animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::pause):
- page/CacheStorageProvider.h:
(): Deleted.
- page/scrolling/ScrollingTree.h:
(WebCore::ScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ScrollingTree::reportExposedUnfilledArea):
- platform/audio/PlatformMediaSessionManager.h:
(WebCore::PlatformMediaSessionManager::hasActiveNowPlayingSession const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingTitle const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingDuration const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingElapsedTime const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingInfoUniqueIdentifier const):
(WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):
- platform/audio/mac/CARingBuffer.cpp:
(WebCore::CARingBuffer::~CARingBuffer):
- platform/audio/mac/CARingBuffer.h:
(WebCore::CARingBuffer::~CARingBuffer): Deleted.
- platform/cocoa/VideoFullscreenModelVideoElement.h:
- platform/gamepad/GamepadProvider.h:
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::displayListAsText const):
(WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayer::isTrackingDisplayListReplay const):
(WebCore::GraphicsLayer::replayDisplayListAsText const):
- platform/mac/PlaybackSessionInterfaceMac.h:
- platform/mediastream/RealtimeMediaSourceCenter.h:
(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::setActive):
(WebCore::LibWebRTCProvider::createDecoderFactory):
(WebCore::LibWebRTCProvider::createEncoderFactory):
(WebCore::LibWebRTCProvider::disableEnumeratingAllNetworkInterfaces):
(WebCore::LibWebRTCProvider::enableEnumeratingAllNetworkInterfaces):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
- platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::willCacheResponseAsync):
- testing/MockGamepadProvider.h:
- workers/service/server/SWServer.h:
(WebCore::SWServer::Connection::~Connection):
- 6:22 PM Changeset in webkit [233188] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Adjust static position for out-of-flow positioned boxes.
https://bugs.webkit.org/show_bug.cgi?id=187000
Reviewed by Antti Koivisto.
The static position of an out-of-flow positioned box is the the position where box would go
if it was in-flow positioned. This position needs to the resolved in the containing block's coordinate system.
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
- 5:43 PM Changeset in webkit [233187] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: Box Model section should have dark background
https://bugs.webkit.org/show_bug.cgi?id=186976
Reviewed by Brian Burg.
Replace all instances of black text on white background with the default text and background colors.
- UserInterface/Views/BoxModelDetailsSectionRow.css:
(@media (prefers-dark-interface)):
(.details-section .row.box-model):
(.details-section .row.box-model .label):
(.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
(.details-section .row.box-model:not(.hovered) :matches(.margin, .border, .padding, .content),):
(.details-section .row.box-model .margin):
(.details-section .row.box-model .border):
- 5:40 PM Changeset in webkit [233186] by
-
- 5 edits3 copies1 move2 adds1 delete in trunk/Source/WTF
Unreviewed, rolling out r233120.
caused regression in ios API tests
Reverted changeset:
"[Cocoa] reduce unnecessary use of .mm source files in WTF,
spruce up some implementation details"
https://bugs.webkit.org/show_bug.cgi?id=186924
https://trac.webkit.org/changeset/233120
- 5:38 PM Changeset in webkit [233185] by
-
- 2 edits in trunk/LayoutTests
LayoutTest imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.https.any.worker.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=187025
Unreviewed test gardening, update Test Expectations to [Pass Failure Slow]
- 4:56 PM Changeset in webkit [233184] by
-
- 13 edits in trunk
JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary
https://bugs.webkit.org/show_bug.cgi?id=186878
<rdar://problem/40568659>
Reviewed by Mark Lam.
Source/JavaScriptCore:
This patch fixes a bug in our JSImmutableButterfly implementation uncovered by
our stress GC bots. Before this patch, JSImmutableButterfly was allocated
with HeapCell::Kind::Auxiliary. This is wrong. Things that are JSCells must be
allocated from HeapCell::Kind::JSCell. The way this broke on the stress GC
bots is that our conservative marking won't do cell marking for things that
are Auxiliary. This means that if the stack is the only thing pointing to a
JSImmutableButterfly when a GC took place, that JSImmutableButterfly would
not be visited. This patch fixes this bug. This patch also extends our conservative
marking to understand that there may be interior pointers to things that are HeapCell::Kind::JSCell.
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayNode::emitBytecode):
- heap/HeapUtil.h:
(JSC::HeapUtil::findGCObjectPointersForMarking):
- runtime/JSImmutableButterfly.h:
(JSC::JSImmutableButterfly::subspaceFor):
LayoutTests:
Make these test not susceptible to conservative scan leaks by ensuring at least
one object gets collected when we allocate many of them. Before, these were just
testing that a fixed number of objects were collected.
- editing/selection/navigation-clears-editor-state-expected.txt:
- editing/selection/navigation-clears-editor-state.html:
- fast/dom/reference-cycle-leaks.html:
- fast/misc/resources/test-observegc.js:
- fast/misc/test-observegc-expected.txt:
- platform/mac-wk2/plugins/refcount-leaks-expected.txt:
- plugins/refcount-leaks-expected.txt:
- plugins/refcount-leaks.html:
- 4:56 PM Changeset in webkit [233183] by
-
- 2 edits in trunk/Source/WebCore
Remove RELEASE_ASSERT added in r230875.
<rdar://problem/40860061> and https://bugs.webkit.org/show_bug.cgi?id=187022
Reviewed by Brent Fulgham.
There's actually more than one way for a network session to be destroyed, and that can happen
asynchronously and unpredictably.
And the request to start up a WebSocket and do its handshake is also asynchronous and unpredictable
It's an expected race.
If the NetworkStorageSession cannot be found then the WebSocket handshake should just fail.
- platform/network/SocketStreamHandleImpl.cpp:
(WebCore::cookieDataForHandshake): If the NetworkStorageSession cannot be found, return std::nullopt.
(WebCore::SocketStreamHandleImpl::platformSendHandshake): If the cookieData is null, fail the handshake.
- 4:54 PM Changeset in webkit [233182] by
-
- 4 edits in trunk/Source/WebCore
[iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News
https://bugs.webkit.org/show_bug.cgi?id=187011
<rdar://problem/40906808>
Reviewed by Tim Horton.
Disable remote media commands when running iOS WebKit on macOS. The iOS flavor of RemoteCommandListener
currently throws an exception when attempting to soft-link the MediaPlayer framework, which prevents video from
being played altogether. For a followup tracking touch bar integration in iOS WebKit on macOS, see:
<rdar://problem/39164732>.
Manually tested by playing a YouTube video in News.
- platform/RemoteCommandListener.cpp:
- platform/ios/RemoteCommandListenerIOS.h:
- platform/ios/RemoteCommandListenerIOS.mm:
- 4:40 PM Changeset in webkit [233181] by
-
- 2 edits in trunk/Source/WebKit
WKThumbnailView fallback background is blindingly bright in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=187017
<rdar://problem/41036209>
Reviewed by Simon Fraser.
- UIProcess/API/Cocoa/_WKThumbnailView.mm:
(-[_WKThumbnailView initWithFrame:]):
(-[_WKThumbnailView wantsUpdateLayer]):
(-[_WKThumbnailView updateLayer]):
Use a semantic color for the WKThumbnailView background color
instead of flat white.
- 4:37 PM Changeset in webkit [233180] by
-
- 14 edits in trunk
Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback
https://bugs.webkit.org/show_bug.cgi?id=186903
<rdar://problem/41350182>
Reviewed by Chris Dumez.
Source/WebKit:
This patch stores the callback sent to
WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains(),
sets up a context ID, and sends that ID to the network process when
asking it to update cookie partitioning and blocking. The network
process then tells the UI process when it's done, at which point the
callback is called.
This change is meant to address layout test flakiness.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::updatePrevalentDomainsToPartitionOrBlockCookies):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::NetworkProcessProxy::didUpdatePartitionOrBlockCookies):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
- UIProcess/WebsiteData/WebsiteDataStore.h:
LayoutTests:
- http/tests/storageAccess/grant-storage-access-under-opener-expected.txt:
- http/tests/storageAccess/grant-storage-access-under-opener.html:
Moved the code block to the page's body instead of its head.
Added an initial console log statement. The reason for these
changes is that we're seeing flaky timeouts with no output.
- 4:07 PM Changeset in webkit [233179] by
-
- 2 edits in trunk/Source/WebKit
Allow access to APTDevice in iOS WebContent process
https://bugs.webkit.org/show_bug.cgi?id=187021
<rdar://problem/41339769>
Reviewed by Youenn Fablet.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 3:34 PM Changeset in webkit [233178] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r233087.
Causes 5% Mac PLT regression.
Reverted changeset:
"Recalc styles every time defaultAppearance changes."
https://bugs.webkit.org/show_bug.cgi?id=186866
https://trac.webkit.org/changeset/233087
- 3:29 PM Changeset in webkit [233177] by
-
- 2 edits1 add in trunk/Source/WebKit
Add a sandbox profile to Hangout plug-in
https://bugs.webkit.org/show_bug.cgi?id=187005
<rdar://problem/41428391>
Reviewed by Brent Fulgham.
Add a sandbox profile so that this plug-in can be run when UIProcess is sandboxed.
- Resources/PlugInSandboxProfiles/com.google.googletalkbrowserplugin.sb: Added.
- WebKit.xcodeproj/project.pbxproj:
- 2:29 PM Changeset in webkit [233176] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION(r229722): WebKitLegacy clients can crash when loading alternate page
https://bugs.webkit.org/show_bug.cgi?id=187008
Reviewed by Chris Dumez.
The new call to 'clearProvisionalLoadForPolicyCheck' added in r229722 broke loading
behavior in WebKitLegacy.
- We can now enter 'cancelPolicyCheckIfNeeded' without a Frame loader, in what appears to be a recursive call during the load cancellation (the 'm_waitingForContentPolicy' and 'm_waitingForNavigationPolicy' have already been nulled). It seems like we should return early here, or perhaps just move the RELEASE_ASSERT inside the case where we have an active policy check happening.
- We also enter FrameLoader::checkContentPolicy without an active document loader. We should recognize this case and handle it, rather than trying to dereference a nullptr document loader.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded): Move the RELEASE_ASSERT inside the
conditional where the frameLoader is actually used.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkContentPolicy): Recognize that the activeDocumentLoader may
be nullptr at this point, and take appropriate action (rather than crashing).
- 2:28 PM Changeset in webkit [233175] by
-
- 4 edits in trunk/Tools
[ews-build] Add support for Bindings-tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187014
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/factories.py:
(BindingsFactory): Added RunBindingsTests build step to BindingsFactory.
- BuildSlaveSupport/ews-build/steps.py:
(RunBindingsTests): Added build-step for running Bindings tests.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- 2:27 PM Changeset in webkit [233174] by
-
- 2 edits in trunk/LayoutTests
performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938
<rdar://problem/41379336>
Unreviewed, skip test again as it is apparently still flaky.
- 2:15 PM Changeset in webkit [233173] by
-
- 3 edits in trunk/Source/WebCore
MatchedPropertiesCacheItem wastes 388KB of vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186990
Reviewed by Antti Koivisto.
MatchedPropertiesCacheItem.matchedProperties was appended to, so it allocated capacity
in 16-size chunks. Instead, assign to it so it only allocates as much capacity as is needed.
Copy-constructing is more wasteful, since it copies the 64-chunk size from the right-hand side.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::addToMatchedPropertiesCache):
- css/StyleResolver.h:
(WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem):
- 2:14 PM Changeset in webkit [233172] by
-
- 3 edits3 adds in trunk
NetworkLoadChecker should not check CORS for 304 responses triggered by WebProcess revalidation
https://bugs.webkit.org/show_bug.cgi?id=186939
<rdar://problem/40941725>
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/cors/resources/cache-304.py: Added.
- web-platform-tests/cors/script-304-expected.txt: Added.
- web-platform-tests/cors/script-304.html: Added.
Source/WebKit:
- NetworkProcess/NetworkLoadChecker.cpp:
(WebKit::NetworkLoadChecker::validateResponse):
- 2:04 PM Changeset in webkit [233171] by
-
- 2 edits in trunk/Source/WebCore
Null dereference crash un ApplicationCacheGroup::startLoadingEntry()
https://bugs.webkit.org/show_bug.cgi?id=187012
<rdar://problem/40793716>
Reviewed by Youenn Fablet.
m_entryLoader can be null because ApplicationCacheResourceLoader::create() return null when
CachedResourceLoader::requestRawResource() fails synchronously. In such case, the completion
handler gets called with a ApplicationCacheResourceLoader::Error::CannotRequestResource error.
To address the issue, we capture the request's URL in the lambda and use it instead of trying
to get the URL from the loader's resource.
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::startLoadingEntry):
- 1:31 PM Changeset in webkit [233170] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r233140): Windows build failure due to incomplete FrameView and RenderBox types
https://bugs.webkit.org/show_bug.cgi?id=186997
- animation/KeyframeEffectReadOnly.cpp:
- 1:30 PM Changeset in webkit [233169] by
-
- 3 edits in trunk/LayoutTests
performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938
<rdar://problem/41379336>
Unreviewed, move the call to gc() inside the setInterval() so we keep
trying to gc() until the frame / document are destroyed (instead of
only doing a single garbage collection).
- TestExpectations:
- performance-api/performance-observer-no-document-leak.html:
- 1:16 PM Changeset in webkit [233168] by
-
- 2 edits in trunk/Source/WebKit
Adjust UNEXPORTED_SYMBOL_LDFLAGS for LTO
https://bugs.webkit.org/show_bug.cgi?id=186949
<rdar://problem/41386438>
Reviewed by David Kilzer.
When building with LTO, WebKit's
'check-for-weak-vtables-and-externals' script reports weak external
symbols:
ERROR: WebKit has a weak external symbol in it (.../OpenSource/WebKitBuild/Release/WebKit.framework/Versions/A/WebKit)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_14basic_iostreamIcS2_EE
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE16_NS_13basic_ostreamIcS2_EE
ERROR: symbol ZTTNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
ERROR: symbol ZTVNSt3115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEEE
ERROR: symbol ZTVNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
Command /bin/sh failed with exit code 1
Address these by adding those symbols to UNEXPORTED_SYMBOL_LDFLAGS in
WebKit.xcconfig.
- Configurations/WebKit.xcconfig:
- 1:12 PM Changeset in webkit [233167] by
-
- 3 edits1 add in trunk
constructArray() should set m_numValuesInVector to the specified length.
https://bugs.webkit.org/show_bug.cgi?id=187010
<rdar://problem/41392167>
Reviewed by Filip Pizlo.
JSTests:
- stress/regress-187010.js: Added.
Source/JavaScriptCore:
Its client will fill in the storage vector with some values using initializeIndex()
and expects m_numValuesInVector to be set to the length i.e. the number of values
to be initialized.
- runtime/JSArray.cpp:
(JSC::constructArray):
- 1:00 PM Changeset in webkit [233166] by
-
- 3 edits3 adds in trunk/Tools
[ews-build] Add support for Style-EWS
https://bugs.webkit.org/show_bug.cgi?id=186955
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/factories.py:
(Factory): Base class for all the factory.
- BuildSlaveSupport/ews-build/loadConfig.py: Initialize factory with required parameters.
- BuildSlaveSupport/ews-build/runUnittests.py: Added, script to run all the unit tests.
- BuildSlaveSupport/ews-build/steps.py: Added.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- 12:54 PM Changeset in webkit [233165] by
-
- 6 edits in trunk/Source/WebKit
Make sure API::IconLoadingClient::getLoadDecisionForIcon()'s completion handler gets called
https://bugs.webkit.org/show_bug.cgi?id=187007
<rdar://problem/41293989>
Reviewed by Brady Eidson.
Make sure API::IconLoadingClient::getLoadDecisionForIcon()'s completion handler gets called by
switching its type to WTF::CompletionHandler instead of WTF::Function. This also has the benefit
of destroying our captured objects when the completion handler gets called by the client on the
main thread instead of whatever thread the ObjC block gets released on.
- UIProcess/API/APIIconLoadingClient.h:
(API::IconLoadingClient::getLoadDecisionForIcon):
- UIProcess/API/glib/WebKitIconLoadingClient.cpp:
- UIProcess/API/mac/WKView.mm:
(-[WKView maybeInstallIconLoadingClient]):
- UIProcess/Cocoa/IconLoadingDelegate.h:
- UIProcess/Cocoa/IconLoadingDelegate.mm:
(WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon):
- 12:24 PM Changeset in webkit [233164] by
-
- 7 edits1 copy1 add in trunk
REGRESSION: hardware-accelerated animation fails on inline element
https://bugs.webkit.org/show_bug.cgi?id=186981
<rdar://problem/41418697>
Reviewed by Dean Jackson.
Source/WebCore:
Ensure we only queue accelerated actions when we have a renderer so we don't attempt
to start an accelerated animation too soon.
Test: webanimations/opacity-animation-yields-compositing-span.html
- animation/KeyframeEffectReadOnly.cpp:
(WebCore::KeyframeEffectReadOnly::updateAcceleratedAnimationState):
LayoutTests:
- platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
- webanimations/opacity-animation-yields-compositing-expected.txt:
- webanimations/opacity-animation-yields-compositing-span-expected.txt:
- webanimations/opacity-animation-yields-compositing-span.html: Added.
- webanimations/opacity-animation-yields-compositing.html:
- 12:23 PM Changeset in webkit [233163] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r233140): v2: Windows build failure due to incomplete DocumentAnimationScheduler type
<https://webkit.org/b/186997>
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
(WebCore::Document::windowScreenDidChange):
- dom/Document.h:
- DocumentAnimationScheduler is behind the USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) macro, which is disabled on Windows.
- This also reverts my fix in r233144 since it didn't work.
- 12:19 PM Changeset in webkit [233162] by
-
- 29 edits1 copy4 adds in trunk
Add API to control mock media devices
https://bugs.webkit.org/show_bug.cgi?id=186958
Reviewed by Eric Carlson.
Source/WebCore:
Refactor code to introduce a MockDevice structure that can be used in multiple processes.
Update mock sources and center to use MockDevice.
Add API to update mock media devices.
Make MediaDevices an ActiveDOMObject so that it does not get collected when ondevicechange is set.
Test: fast/mediastream/device-change-event-2.html
- Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::stop):
(WebCore::MediaDevices::scheduledEventTimerFired):
(WebCore::MediaDevices::hasPendingActivity const):
(WebCore::MediaDevices::activeDOMObjectName const):
(WebCore::MediaDevices::canSuspendForDocumentSuspension const):
- Modules/mediastream/MediaDevices.h:
- Modules/mediastream/MediaDevices.idl:
- WebCore.xcodeproj/project.pbxproj:
- platform/mediastream/RealtimeMediaSourceCenter.h:
- platform/mock/MockMediaDevice.h: Added.
(WebCore::MockMicrophoneProperties::encode const):
(WebCore::MockMicrophoneProperties::decode):
(WebCore::MockCameraProperties::encode const):
(WebCore::MockCameraProperties::decode):
(WebCore::MockDisplayProperties::encode const):
(WebCore::MockDisplayProperties::decode):
(WebCore::MockMediaDevice::isMicrophone const):
(WebCore::MockMediaDevice::isCamera const):
(WebCore::MockMediaDevice::isDisplay const):
(WebCore::MockMediaDevice::type const):
(WebCore::MockMediaDevice::encode const):
(WebCore::MockMediaDevice::decodeMockMediaDevice):
(WebCore::MockMediaDevice::decode):
- platform/mock/MockRealtimeAudioSource.cpp:
(WebCore::MockRealtimeAudioSource::startProducingData):
- platform/mock/MockRealtimeMediaSource.cpp:
(WebCore::defaultDevices):
(WebCore::devices):
(WebCore::deviceMap):
(WebCore::deviceListForDevice):
(WebCore::MockRealtimeMediaSource::createCaptureDevice):
(WebCore::MockRealtimeMediaSource::resetDevices):
(WebCore::MockRealtimeMediaSource::setDevices):
(WebCore::MockRealtimeMediaSource::addDevice):
(WebCore::MockRealtimeMediaSource::removeDevice):
(WebCore::MockRealtimeMediaSource::captureDeviceWithPersistentID):
(WebCore::MockRealtimeMediaSource::audioDevices):
(WebCore::MockRealtimeMediaSource::videoDevices):
(WebCore::MockRealtimeMediaSource::displayDevices):
(WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):
(WebCore::MockRealtimeMediaSource::initializeCapabilities):
(WebCore::MockRealtimeMediaSource::initializeSettings):
(WebCore::MockRealtimeMediaSource::settings const):
(WebCore::MockRealtimeMediaSource::supportedConstraints):
- platform/mock/MockRealtimeMediaSource.h:
(WebCore::MockRealtimeMediaSource::device const):
- platform/mock/MockRealtimeMediaSourceCenter.cpp:
(WebCore::MockRealtimeMediaSourceCenter::singleton):
(WebCore::MockRealtimeMediaSourceCenter::setMockRealtimeMediaSourceCenterEnabled):
(WebCore::MockRealtimeMediaSourceCenter::setDevices):
(WebCore::MockRealtimeMediaSourceCenter::addDevice):
(WebCore::MockRealtimeMediaSourceCenter::removeDevice):
- platform/mock/MockRealtimeMediaSourceCenter.h:
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::initializeCapabilities):
(WebCore::MockRealtimeVideoSource::drawText):
(WebCore::MockRealtimeVideoSource::generateFrame):
- platform/mock/MockRealtimeVideoSource.h:
(WebCore::MockRealtimeVideoSource::mockCamera const):
(WebCore::MockRealtimeVideoSource::mockScreen const):
Source/WebKit:
Add API to clear, set, remove and reset mock media devices.
The mock media center of UIProcess and all WebProcesses are updated.
- CMakeLists.txt:
- UIProcess/API/C/WKMockMediaDevice.cpp: Added.
(typeFromString):
(WKAddMockMediaDevice):
(WKClearMockMediaDevices):
(WKRemoveMockMediaDevice):
(WKResetMockMediaDevices):
- UIProcess/API/C/WKMockMediaDevice.h: Added.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::addMockMediaDevice):
(WebKit::WebProcessPool::clearMockMediaDevices):
(WebKit::WebProcessPool::removeMockMediaDevice):
(WebKit::WebProcessPool::resetMockMediaDevices):
- UIProcess/WebProcessPool.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addMockMediaDevice):
(WebKit::WebProcess::clearMockMediaDevices):
(WebKit::WebProcess::removeMockMediaDevice):
(WebKit::WebProcess::resetMockMediaDevices):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Tools:
Add test runner API to clear/add/remove/reset mock media devices.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::addMockMediaDevice):
(WTR::TestRunner::addMockCameraDevice):
(WTR::TestRunner::addMockMicrophoneDevice):
(WTR::TestRunner::addMockScreenDevice):
(WTR::TestRunner::clearMockMediaDevices):
(WTR::TestRunner::removeMockMediaDevice):
(WTR::TestRunner::resetMockMediaDevices):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::addMockMediaDevice):
(WTR::TestController::clearMockMediaDevices):
(WTR::TestController::removeMockMediaDevice):
(WTR::TestController::resetMockMediaDevices):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
LayoutTests:
- fast/mediastream/device-change-event-2-expected.txt: Added.
- fast/mediastream/device-change-event-2.html: Added.
- 11:53 AM Changeset in webkit [233161] by
-
- 3 edits1 add in trunk
Add missing exception check in RegExpObjectInlines.h's collectMatches.
https://bugs.webkit.org/show_bug.cgi?id=187006
<rdar://problem/41418412>
Reviewed by Keith Miller.
JSTests:
- stress/regress-187006.js: Added.
Source/JavaScriptCore:
- runtime/RegExpObjectInlines.h:
(JSC::collectMatches):
- 11:52 AM Changeset in webkit [233160] by
-
- 3 edits in trunk/Tools
[ews-build] Add support for try Buildbot try schedulers
https://bugs.webkit.org/show_bug.cgi?id=186948
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/config.json: Use Try_Userpass scheduler.
- BuildSlaveSupport/ews-build/loadConfig.py: Updated to use try scheduler.
- 11:43 AM Changeset in webkit [233159] by
-
- 2 edits in trunk/Source/WebKit
[iPad apps on macOS] Click events are broken in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=186964
<rdar://problem/41369145>
Reviewed by Tim Horton.
Tapping in WKWebView currently does not dispatch click events to the page. This is because the long press loupe
gesture (in the text interaction assistant) has a delay of 0 when running iOS apps on macOS, but on iOS, it's
0.5. The zero delay on macOS means that the loupe gesture will be recognized before the synthetic click gesture;
this, in turn, causes the synthetic click gesture to be excluded by the loupe gesture. To address this, we
simply allow the click and loupe gesture to recognize simultaneously.
Additionally, a new hover gesture was added recently to handle macOS cursor types when hovering over selectable
text. This patch also allows other gestures to recognize alongside hover gestures, which matches macOS behavior.
We don't have the capacity to write automated tests for this yet; I manually tested text selection, editing in
some text form controls, as well as clicking on links, buttons, and other elements with click event handlers.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
- 11:30 AM Changeset in webkit [233158] by
-
- 6 edits in trunk/Source/JavaScriptCore
Add API for configuring the number of threads used by DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=186859
<rdar://problem/41093519>
Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-06-25
Reviewed by Filip Pizlo.
Add new private APIs for limiting the number of threads to be used by
the DFG and FTL compilers. It was already possible to configure the
limit through JSC Options, but now it can be changed at runtime, even
in the case when the VM is already running.
Add a test for both cases: when trying to configure the limit before
and after the Worklist has been created, but in order to simulate the
first scenario, we must guarantee that the test runs at the very
beginning, so I also added a check for that.
- API/JSVirtualMachine.mm:
(+[JSVirtualMachine setNumberOfDFGCompilerThreads:]):
(+[JSVirtualMachine setNumberOfFTLCompilerThreads:]):
- API/JSVirtualMachinePrivate.h:
- API/tests/testapi.mm:
(runJITThreadLimitTests):
(testObjectiveCAPIMain):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::createNewThread):
(JSC::DFG::Worklist::setNumberOfThreads):
- dfg/DFGWorklist.h:
- 10:58 AM Changeset in webkit [233157] by
-
- 3 edits in trunk/Source/WTF
Fix ASAN_ENABLED in GCC
https://bugs.webkit.org/show_bug.cgi?id=186957
Reviewed by Michael Catanzaro.
ASAN_ENABLED used to rely on Clang-specific features for detection.
This patch enables ASAN_ENABLED to work on GCC too.
It also fixes compilation errors and warnings that were triggered when
compiling code guarded by ASAN_ENABLED in gcc.
- wtf/Compiler.h:
- wtf/Vector.h:
(WTF::VectorBuffer::endOfBuffer):
- 10:42 AM Changeset in webkit [233156] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: color outline is too dark
https://bugs.webkit.org/show_bug.cgi?id=186975
Reviewed by Brian Burg.
Make the outline lighter than the background.
- UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(.hover-menu > svg > :matches(path, rect)):
- 10:39 AM Changeset in webkit [233155] by
-
- 2 edits in trunk/Source/ThirdParty/libwebrtc
Adjust webrtc library for LTO
https://bugs.webkit.org/show_bug.cgi?id=186952
<rdar://problem/41387815>
Reviewed by Youenn Fablet.
There are a number of files in webrtc that have main() functions (in
particular, rtpcat.cc and click_annotate.cc). When compiling with LTO,
these symbols are exposed to each other, leading to the following
build failure:
Ld libwebrtc.dylib
duplicate symbol _main in:
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
BUILD FAILED
Address this by removing the indicated files from the build.
- libwebrtc.xcodeproj/project.pbxproj:
- 10:38 AM Changeset in webkit [233154] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: Media query names are unreadable
https://bugs.webkit.org/show_bug.cgi?id=186974
Reviewed by Brian Burg.
Change media query names from dark blue to light blue.
- UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(.CodeMirror .CodeMirror-lines .CodeMirror-matchingbracket):
(.cm-s-default .cm-attribute):
- 10:35 AM Changeset in webkit [233153] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: Network headers colors are too dim
https://bugs.webkit.org/show_bug.cgi?id=186985
Reviewed by Brian Burg.
Increasing the luminance of network header colors by increasing lightness and brightness.
- UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(:root):
- 10:34 AM Changeset in webkit [233152] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: Font guideline colors are too bright
https://bugs.webkit.org/show_bug.cgi?id=186986
Reviewed by Brian Burg.
Make the guidelines less distractive from the font glyphs.
- UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(.content-view.resource.font .preview > .line):
(.content-view.resource.font .metric.top):
(.content-view.resource.font .metric.baseline):
(.content-view.resource.font .metric.middle):
(.content-view.resource.font .metric.xheight):
(.content-view.resource.font .metric.bottom):
- 9:48 AM Changeset in webkit [233151] by
-
- 2 edits in trunk/Tools
[WinCairo] Unreviewed build fix for r233088.
- BuildSlaveSupport/built-product-archive:
(extractBuiltProduct):
"move" throws instead of overwriting, so just use "copy" instead.
- 9:31 AM Changeset in webkit [233150] by
-
- 2 edits in trunk/Tools
[test262-runner] Sort the list of failing files in the HTML report
https://bugs.webkit.org/show_bug.cgi?id=186998
Patch by Leo Balter <Leo Balter> on 2018-06-25
Reviewed by Michael Saboff.
- Scripts/test262/Runner.pm:
(printHTMLResults): The current list of failing files it not ordered and it's hard to read.
This small patch will sort the list.
- 9:22 AM Changeset in webkit [233149] by
-
- 2 edits in trunk/Source/WebKit
[Mac] Web Automation: include correct key code with synthesized NSEvents used for keystrokes
https://bugs.webkit.org/show_bug.cgi?id=186937
Reviewed by Timothy Hatcher.
In some cases, a missing keyCode for an ASCII letter/number can cause synthesized
NSEvents to not be converted into a key equivalent action like copy: or paste:.
- UIProcess/Automation/mac/WebAutomationSessionMac.mm:
Drive by, always initialize keyCode.
(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
(WebKit::keyCodeForCharKey): Compute the keyCode as defined by HLTB headers.
This only needs to be computed for characters with physical keys, excluding the
number pad and some traditional virtual keys that do not usually have glyphs.
- 8:57 AM Changeset in webkit [233148] by
-
- 3 edits in trunk/Source/WebCore
AutoTableLayout wastes 52KB of Vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186710
Reviewed by Zalan Bujtas.
Call resizeToFit() to only allocate enough capacity for the number of columns.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::insertSpanCell): Whitespace fix.
- rendering/AutoTableLayout.h:
- 8:38 AM Changeset in webkit [233147] by
-
- 10 edits in trunk/PerformanceTests
[MotionMark] Add support for version numbers
https://bugs.webkit.org/show_bug.cgi?id=186479
Reviewed by Said Abou-Hallawa.
Add support for displaying the version number as well as including it in the JSON results.
When loading the front page, script replaces any element with classname version with the
version number of the benchmark, which is stored in Strings.version.
The JSON structure for the results includes a new version property:
{
"version": "1.0",
"options": { ... },
"data": [ ... ]
}
When dragging a results file, the version listed will come from the JSON file. Older
results will not have had the version property, in which case it will default to "1.0".
- MotionMark/index.html: Update title to some other default. Script will update it.
Include the version number in the logo title.
- MotionMark/developer.html: Ditto.
- MotionMark/about.html: Ditto.
- MotionMark/resources/runner/motionmark.js:
(ResultsDashboard): Update constructor to include version. This is used when serializing
results out to JSON, and displaying the results panel in developer mode.
(ResultsDashboard._processData): When running the benchmark, include benchmark version string
in the results object.
(ResultsDashboard.version):
(window.benchmarkRunnerClient.willStartFirstIteration): When running the benchmark, pass the
benchmark version string to the dashboard, which holds the results.
(window.sectionsManager.setSectionVersion): Helper function to update the element in the
section with the class name version.
(window.benchmarkController.initialize): Populate all DOM elements with class name "version"
with the version string. Update the page title.
(window.benchmarkController.showResults): When showing results, update the version string
based on what is included in the JSON results, which would be the same as the benchmark version.
- MotionMark/resources/runner/motionmark.css: Include missing copyright. Wrap the SVG logo
in a div and include the version string.
- MotionMark/resources/strings.js: Add strings for the page title template, and the version.
- MotionMark/resources/debug-runner/motionmark.css:
- MotionMark/resources/debug-runner/motionmark.js:
(window.benchmarkRunnerClient.willStartFirstIteration): When running the benchmark, pass the
benchmark version string to the dashboard, which holds the results.
(window.benchmarkController.initialize): Populate all DOM elements with class name "version"
with the version string. Update the page title. When dragging in JSON results, look for
version to pass to the dashboard. If it doesn't exist, default to "1.0".
(window.benchmarkController.showResults): When showing results, update the version string
based on what is included in the JSON results, instead of the current benchmark version.
- MotionMark/resources/debug-runner/tests.js: Update page title template.
- 8:15 AM Changeset in webkit [233146] by
-
- 5 edits in trunk/Tools
[WSL] Start writing the Sphinx document
https://bugs.webkit.org/show_bug.cgi?id=186310
Rubberstamped by Filip Pizlo.
Very early work, just has the lexer and a few fragments of the parser so far.
Also fixing some minor mistake in the formal rules.
- 8:01 AM Changeset in webkit [233145] by
-
- 4 edits in trunk/Source/WebCore
[LFC] Adjust static position with containing block's content box top/left
https://bugs.webkit.org/show_bug.cgi?id=186999
Reviewed by Antti Koivisto.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
- layout/displaytree/DisplayBox.cpp:
(WebCore::Display::Box::contentBox const):
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::contentBoxTop const):
(WebCore::Display::Box::contentBoxLeft const):
- 5:43 AM Changeset in webkit [233144] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r233140): Windows build failure due to incomplete DocumentAnimationScheduler type
<https://webkit.org/b/186997>
- dom/Document.cpp:
- dom/Document.h:
- Attempt to fix Windows build failure by moving include of DocumentAnimationScheduler.h from Document.cpp to Document.h.
- 3:58 AM Changeset in webkit [233143] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Remove useless workaround
https://bugs.webkit.org/show_bug.cgi?id=186921
Reviewed by Xabier Rodriguez-Calvar.
In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
the media/video-reverse-play-duration.html test passes without any
workaround needed. The other test mentioned in that bug was
removed, it seems.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):
- 3:22 AM Changeset in webkit [233142] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, address Darin's comment
https://bugs.webkit.org/show_bug.cgi?id=186757
- page/linux/ResourceUsageThreadLinux.cpp:
(WebCore::cpuPeriod):
- 3:00 AM Changeset in webkit [233141] by
-
- 7 edits in trunk
[Web Animations] Make imported/mozilla/css-animations/test_animation-pausing.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=183826
<rdar://problem/40997412>
Reviewed by Dean Jackson.
LayoutTests/imported/mozilla:
Mark progressions in the Mozilla CSS Animations tests.
- css-animations/test_animation-pausing-expected.txt:
Source/WebCore:
The CSS Animations Level 2 specification defines that calling pause() on a CSSAnimation object is "sticky"
until a call to play() is made, meaning that any changes to the running state via the CSS animation-play-state
property is overridden by the stickiness of the pause() call. In this patch we add an m_stickyPaused flag which
is set in API calls to pause() and play(). While this flag is true, changes to the animation-play-state property
to the "running" value are ignored.
- animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
(WebCore::CSSAnimation::bindingsPlay):
(WebCore::CSSAnimation::bindingsPause):
- animation/CSSAnimation.h:
LayoutTests:
This test now passes reliably.
- 2:54 AM Changeset in webkit [233140] by
-
- 12 edits2 adds in trunk
[Web Animations] Ensure animations are updated prior to requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=186997
<rdar://problem/41419414>
Reviewed by Dean Jackson.
LayoutTests/imported/mozilla:
Mark progressions in the Mozilla CSS Animations tests.
- css-animations/test_animation-pausing-expected.txt:
Source/WebCore:
Some sub-tests of imported/mozilla/css-animations/test_animation-pausing.html clearly expect that animations
would be resolved prior to firing a requestAnimationFrame() callback, as the HTML5 event loop mandates. But until
now, both DocumentTimeline and ScriptedAnimationController would make calls to DisplayRefreshMonitorManager::scheduleAnimation()
that were not coordinated and so the order in which the DocumentTimeline and ScriptedAnimationController callbacks
were performed was not guaranteed.
In this patch we add a new DocumentAnimationScheduler class which is created by a Document to manage this specific
situation. Now DocumentTimeline and ScriptedAnimationController use this supporting object instead of being their
own DisplayRefreshMonitorClient and call scheduleWebAnimationsResolution() and scheduleScriptedAnimationResolution()
respectively to indicate the need to schedule an animation through the DisplayRefreshMonitorManager to serve the specific
needs of either, or both, classes. Then DocumentAnimationScheduler ensures that Web Animations resolution happens
prior to requestAnimationFrame callbacks when both are scheduled.
In the future we should be able to move more code from DocumentTimeline and ScriptedAnimationController over to
DocumentAnimationScheduler, such as support for throttling and using a timer-based fallback, but this patch provides
the minimal functionality required to provide a sounder foundation.
- Modules/webvr/VRDisplay.cpp:
(WebCore::VRDisplay::requestAnimationFrame):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- animation/DocumentAnimationScheduler.cpp: Added.
(WebCore::DocumentAnimationScheduler::create):
(WebCore::DocumentAnimationScheduler::DocumentAnimationScheduler):
(WebCore::DocumentAnimationScheduler::detachFromDocument):
(WebCore::DocumentAnimationScheduler::scheduleWebAnimationsResolution):
(WebCore::DocumentAnimationScheduler::scheduleScriptedAnimationResolution):
(WebCore::DocumentAnimationScheduler::displayRefreshFired):
(WebCore::DocumentAnimationScheduler::windowScreenDidChange):
(WebCore::DocumentAnimationScheduler::createDisplayRefreshMonitor const):
- animation/DocumentAnimationScheduler.h: Copied from Source/WebCore/animation/CSSAnimation.h.
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::create):
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::scheduleAnimationResolution):
(WebCore::DocumentTimeline::windowScreenDidChange): Deleted.
(WebCore::DocumentTimeline::createDisplayRefreshMonitor const): Deleted.
- animation/DocumentTimeline.h:
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
(WebCore::Document::windowScreenDidChange):
(WebCore::Document::requestAnimationFrame):
(WebCore::Document::animationScheduler):
(WebCore::Document::timeline):
- dom/Document.h:
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::documentAnimationSchedulerDidFire):
(WebCore::ScriptedAnimationController::windowScreenDidChange): Deleted.
(WebCore::ScriptedAnimationController::displayRefreshFired): Deleted.
(WebCore::ScriptedAnimationController::createDisplayRefreshMonitor const): Deleted.
- dom/ScriptedAnimationController.h:
(WebCore::ScriptedAnimationController::create):
- 2:26 AM Changeset in webkit [233139] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] Remove unnecessary PLATFORM guards
https://bugs.webkit.org/show_bug.cgi?id=186995
Reviewed by Mark Lam.
- assembler/AssemblerCommon.h:
(JSC::isIOS):
Add constexpr.
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
StackFrame works in all the platforms. If StackFrame::demangle failed,
it just returns std::nullopt. And it is correctly handled in this code.
- 12:05 AM Changeset in webkit [233138] by
-
- 10 edits in trunk
Source/WebCore:
[GCrypt] Zero-prefix (if necessary) output of RSA-based encryption and signing operations
https://bugs.webkit.org/show_bug.cgi?id=186967
Reviewed by Michael Catanzaro.
Output for RSA-based encryption and signing operations should match the
length of the RSA key. The way we retrieve the MPI data means libgcrypt
can ignore the high-bit zero values and leave us with a valid result
that's shorter in length compared to the RSA key. For instance, if the
output MPI fits into 2040 bits while a 2048-bit key was used we'll end
up with MPI data that will be fitted into a 255-byte Vector, one byte
short of the expected output length.
To avoid this, mpiZeroPrefixedData() is now used when retrieving output
of these RSA operations, and the value of the key size in bytes is
passed to it. This efficiently prepares the output Vector and then
copies the MPI data into it, respecting the MPI data length as well as
the desired length of the output.
No new tests -- relevant tests are now stable (i.e. not sporadically
failing anymore), associated expectations are removed.
- crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:
(WebCore::gcryptDerive): Also use mpiZeroPrefixedData().
- crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
(WebCore::gcryptEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
- crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
(WebCore::gcryptSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
- crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
(WebCore::gcryptEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
- crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:
(WebCore::gcryptSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
- crypto/gcrypt/GCryptUtilities.h:
(WebCore::mpiZeroPrefixedData):
LayoutTests:
[GCrypt] Zero-prefix (if necessary) RSA-OAEP encryption, RSA-PSS signing output
https://bugs.webkit.org/show_bug.cgi?id=186967
Reviewed by Michael Catanzaro.
- platform/gtk/TestExpectations: Remove flaky failures for RSA-OAEP and RSA-PSS tests.
- platform/wpe/TestExpectations: Ditto.
Jun 24, 2018:
- 11:31 PM Changeset in webkit [233137] by
-
- 3 edits in trunk/Source/WebDriver
Unreviewed. Fix WebDriver tests after r233077.
WebDriver process is crashing because GVariant doesn't allow to pass a nullptr array when using @ modifier.
- SessionHost.h:
- glib/SessionHostGlib.cpp:
(WebDriver::SessionHost::buildSessionCapabilities const): Receive a GVariantBuilder and return true if there are
session capabilities.
(WebDriver::SessionHost::startAutomationSession): Remove the @ modifier and use a GVariantBuilder instead, or
nullptr if there aren't session capabilities.
- 9:40 PM Changeset in webkit [233136] by
-
- 2 edits in trunk/Source/WebCore
Fix the DUMP_NODE_STATISTICS code so that it compiles
https://bugs.webkit.org/show_bug.cgi?id=186982
Reviewed by Anders Carlsson.
The DUMP_NODE_STATISTICS code had bitrotted. ENTITY_NODE no longer exists.
liveNodeSet needs to be a static function with a NeverDestroyed<>.
- dom/Node.cpp:
(WebCore::Node::dumpStatistics):
(WebCore::Node::trackForDebugging):
(WebCore::Node::~Node):
- 6:52 PM Changeset in webkit [233135] by
-
- 3 edits2 adds in trunk
Fix the composition underline to be transformed by -apple-color-filter
https://bugs.webkit.org/show_bug.cgi?id=186983
rdar://problem/40515558
Reviewed by Zalan Bujtas.
Source/WebCore:
Transform the composition underline color with the color filter.
Test: css3/color-filters/color-filter-composition-underline-color.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintCompositionUnderline const):
LayoutTests:
- css3/color-filters/color-filter-composition-underline-color-expected.html: Added.
- css3/color-filters/color-filter-composition-underline-color.html: Added.
- 12:01 PM Changeset in webkit [233134] by
-
- 2 edits in trunk/Source/bmalloc
[bmalloc][Linux] Remove static initializers for PerProcess<>::s_object
https://bugs.webkit.org/show_bug.cgi?id=186966
Reviewed by Anders Carlsson.
chrome/tools/linux/dump-static-initializers.py can dump static initializers
in the binary and we found that PerProcess<>::s_object initialization is done
by static initializers in GCC + Linux environments. The example is the following.
Scavenger.cpp (initializer offset 0x38c210 size 0x3e)
_GLOBALsub_I_Scavenger.cpp+0x1e
_GLOBALsub_I_Scavenger.cpp+0x2d
_GLOBALsub_I_Scavenger.cpp+0x3c
_GLOBALsub_I_Scavenger.cpp+0xf
guard variable for bmalloc::PerProcess<bmalloc::AllIsoHeaps>::s_object@@Base-0x3f0d8
guard variable for bmalloc::PerProcess<bmalloc::Environment>::s_object@@Base-0x3f0e8
guard variable for bmalloc::PerProcess<bmalloc::PerHeapKind<bmalloc::Heap> >::s_object@@Base-0x3c600
guard variable for bmalloc::PerProcess<bmalloc::Scavenger>::s_object@@Base-0x38ce8
We can remove this by initializing
nullptr, which leads to constexpr initialization.
After this change, Linux JSCOnly libJavaScriptCore.so has no static initializers.
- bmalloc/PerProcess.h:
- 9:59 AM Changeset in webkit [233133] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed, fix GTK debug build after r233131
https://bugs.webkit.org/show_bug.cgi?id=186899
<rdar://problem/38222248>
This assertion was intended to be removed.
- UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:
(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
