Context Navigation

← Previous Period
Next Period →

Timeline

Sep 10, 2018:

10:18 PM Changeset in webkit [235886] by Fujii Hironori

9 edits in trunk/Source

Remove unused needsDestruction class variables from HashTraits
https://bugs.webkit.org/show_bug.cgi?id=189490

Reviewed by Daniel Bates.

Source/WebCore:

needsDestruction has been obsoleted in Bug 121983.

No new tests (No behavior change).

css/makeprop.pl: Removed needsDestruction.
platform/graphics/FloatSizeHash.h: Ditto.
platform/graphics/IntPointHash.h: Ditto.
platform/graphics/IntRectHash.h: Ditto.
platform/graphics/IntSizeHash.h: Ditto.
platform/graphics/WidthCache.h: Ditto.

Source/WebKitLegacy/mac:

History/BinaryPropertyList.cpp: Removed needsDestruction.

10:07 PM Changeset in webkit [235885] by mitz@apple.com

8 copies
1 add in releases/Apple/iOS 11.4.1

Added a tag for iOS 11.4.1.

10:06 PM Changeset in webkit [235884] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari 11.1.2

Added a tag for Safari 11.1.2.

10:01 PM Changeset in webkit [235883] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview 65

Added a tag for Safari Technology Preview release 65.

9:53 PM Changeset in webkit [235882] by msaboff@apple.com

16 edits in trunk

Test262 failure with Named Capture Groups - using a reference before the group is defined
https://bugs.webkit.org/show_bug.cgi?id=189407

Reviewed by Alex Christensen.

JSTests:

Re-enabled previously failing test.

test262.yaml:
test262/expectations.yaml:

Source/JavaScriptCore:

Added code to save the named forward references we see during parsing and validating that
they are all present when parsing the RegExp is complete. If there are unnamed references,
we reparse with some variation of behavior. Just like for numeric references, the
behavior is different depending on whether or not the unicode (u flag) is present.
For non-unicode patterns, we treat the \k<...> as a literal pattern. For a unicode
pattern we throw an exception.

Did some refactoring, renaming YarrPattern::reset() and YarrPatternConstructor::reset()
resetForReparsing() as that is the only use for those methods. Also changed
all the delegate methods that take a String to take a const String& to eliminate
copy churn.

yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::atomNamedBackReference):
(JSC::Yarr::Parser::CharacterClassParserDelegate::isValidNamedForwardReference):
(JSC::Yarr::Parser::CharacterClassParserDelegate::atomNamedForwardReference):
(JSC::Yarr::Parser::parseEscape):

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::resetForReparsing):
(JSC::Yarr::YarrPatternConstructor::saveUnmatchedNamedForwardReferences):
(JSC::Yarr::YarrPatternConstructor::atomNamedBackReference):
(JSC::Yarr::YarrPatternConstructor::isValidNamedForwardReference):
(JSC::Yarr::YarrPatternConstructor::atomNamedForwardReference):
(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPatternConstructor::reset): Deleted.

yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::resetForReparsing):
(JSC::Yarr::YarrPattern::containsIllegalNamedForwardReferences):
(JSC::Yarr::YarrPattern::reset): Deleted.

yarr/YarrSyntaxChecker.cpp:

(JSC::Yarr::SyntaxChecker::atomNamedBackReference):
(JSC::Yarr::SyntaxChecker::isValidNamedForwardReference):
(JSC::Yarr::SyntaxChecker::atomNamedForwardReference):

Source/WebCore:

Created new delegate stubs for RegExp parsing. These are not needed for the URL filtering
use cases. Also changed all the delegate methods that take a String to take
const String& to eliminate copy churn.

Updated TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp.

contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::PatternParser::atomNamedBackReference):
(WebCore::ContentExtensions::PatternParser::isValidNamedForwardReference):
(WebCore::ContentExtensions::PatternParser::atomNamedForwardReference):
(WebCore::ContentExtensions::URLFilterParser::statusString):

contentextensions/URLFilterParser.h:

Tools:

Updated test.

TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

Updated tests.

js/regexp-named-capture-groups-expected.txt:
js/script-tests/regexp-named-capture-groups.js:

8:59 PM Changeset in webkit [235881] by rniwa@webkit.org

18 edits
20 adds
1 delete in trunk/LayoutTests

Update shadow DOM and custom elements tests
https://bugs.webkit.org/show_bug.cgi?id=189494

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-imported WPT tests for shadow DOM and custom elements.

resources/import-expectations.json:
web-platform-tests/custom-elements/range-and-constructors-expected.txt: Added.
web-platform-tests/custom-elements/range-and-constructors.html: Added.
web-platform-tests/custom-elements/w3c-import.log:
web-platform-tests/shadow-dom/Document-prototype-currentScript-expected.txt:
web-platform-tests/shadow-dom/Document-prototype-currentScript.html:
web-platform-tests/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint-expected.txt: Added.
web-platform-tests/shadow-dom/DocumentOrShadowRoot-prototype-elementFromPoint.html: Added.
web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element-expected.txt: Added.
web-platform-tests/shadow-dom/Element-interface-attachShadow-custom-element.html: Added.
web-platform-tests/shadow-dom/Element-interface-attachShadow-expected.txt:
web-platform-tests/shadow-dom/Element-interface-attachShadow.html:
web-platform-tests/shadow-dom/Extensions-to-Event-Interface-expected.txt:
web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html:
web-platform-tests/shadow-dom/OWNERS: Removed.
web-platform-tests/shadow-dom/directionality-001.tentative-expected.html: Added.
web-platform-tests/shadow-dom/directionality-001.tentative.html: Added.
web-platform-tests/shadow-dom/event-composed-path-after-dom-mutation-expected.txt: Added.
web-platform-tests/shadow-dom/event-composed-path-after-dom-mutation.html: Added.
web-platform-tests/shadow-dom/form-control-form-attribute-expected.txt: Added.
web-platform-tests/shadow-dom/form-control-form-attribute.html: Added.
web-platform-tests/shadow-dom/getElementById-dynamic-001-expected.txt: Added.
web-platform-tests/shadow-dom/getElementById-dynamic-001.html: Added.
web-platform-tests/shadow-dom/input-element-list-expected.txt: Added.
web-platform-tests/shadow-dom/input-element-list.html: Added.
web-platform-tests/shadow-dom/layout-slot-no-longer-assigned-expected.html: Added.
web-platform-tests/shadow-dom/layout-slot-no-longer-assigned.html: Added.
web-platform-tests/shadow-dom/layout-slot-no-longer-fallback-expected.html: Added.
web-platform-tests/shadow-dom/layout-slot-no-longer-fallback.html: Added.
web-platform-tests/shadow-dom/leaktests/get-elements-expected.txt:
web-platform-tests/shadow-dom/leaktests/get-elements.html:
web-platform-tests/shadow-dom/leaktests/w3c-import.log:
web-platform-tests/shadow-dom/resources/event-path-test-helpers.js:

(dispatchEventWithEventLog):

web-platform-tests/shadow-dom/resources/shadow-dom-utils.js:
web-platform-tests/shadow-dom/resources/w3c-import.log:
web-platform-tests/shadow-dom/w3c-import.log:

LayoutTests:

Skip the test hitting a debug assertion until the bug 189493 is fixed.

TestExpectations:

6:35 PM Changeset in webkit [235880] by Chris Dumez

2 edits in trunk/Source/WebKit

Unreviewed, fix ProcessSwap API tests after r235867.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::exitAcceleratedCompositingMode):
Add null-check for drawing area.

6:25 PM Changeset in webkit [235879] by commit-queue@webkit.org

10 edits
1 copy in trunk/Tools

[WHLSL] Inlining should be optional
https://bugs.webkit.org/show_bug.cgi?id=188641

Patch by Thomas Denney <tdenney@apple.com> on 2018-09-10
Reviewed by Myles C. Maxfield.

Inlining functions is now optional, and disabled by default. This patch
additionally resolves https://bugs.webkit.org/show_bug.cgi?id=189326 as
the code for calling functions was completely rewritten.

WebGPUShadingLanguageRI/All.js: Add LateCheckAndLayoutBuffers.js
WebGPUShadingLanguageRI/CallFunction.js:

(callFunction): Remove dependency on inlining.

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype._snapshot): Allow null srcPtr in the case of void
returns from functions.
(Evaluator.prototype._evaluateArguments): Abstract out argument
evaluation, ensuring that the order is right-to-left for
FunctionLikeBlocks (i.e. inlined functions) and regular calls.
(Evaluator.prototype._evaluateFunction): Abstracted out function body
evaluation for inlined and non-inlined functions.
(Evaluator.prototype.visitFunctionLikeBlock): Ditto.
(Evaluator.prototype.visitCallExpression): Ditto.

WebGPUShadingLanguageRI/Inline.js:

(_inlineFunction): Moved logic that is needed regardless of inlining
into LateCheckAndLayoutBuffers.js
(resolveInlinedFunction): Deleted.

WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js: Moved logic for

late checking.

WebGPUShadingLanguageRI/Prepare.js: Make inlining optional and off by

default.

WebGPUShadingLanguageRI/SPIRV.html: Update include.
WebGPUShadingLanguageRI/Test.html: Ditto.
WebGPUShadingLanguageRI/Test.js: Right-to-left argument evaluation,

and inlining tests.

WebGPUShadingLanguageRI/index.html: Update include.

6:18 PM Changeset in webkit [235878] by Wenson Hsieh

12 edits
1 add in trunk

[iOS] Unable to change the value of select elements while preserving focus state
https://bugs.webkit.org/show_bug.cgi?id=189475
<rdar://problem/41125764>

Reviewed by Tim Horton.

Source/WebKit:

With UITextInputMultiDocument support in WebKit (r226911), WKContentView may enter a state where the user is
able to interact with web content, but focus state is being preserved on WKWebView. This prevents keyboard and
input view dismissal from blurring the focused element (which, in turn, means that the value of certain form
controls, such as select elements, cannot be changed). This can happen in the following scenario:

Suppose we have a web view embedded inside of a view controller (let's call it A).
Another view controller (let's call this one B) is modally presented over A.
The web view is removed from A's view hierarchy and reparented under B's view.
The user taps a form control in the web view, interacts with the keyboard, and taps the Done button.

After step 2, WKContentView gets a call to -_preserveFocusWithToken:destructively:, which increments its focus
retain count to 1. Thus, in step 3, resigning first responder using the Done button fails to blur the element.
To fix this, we split the existing _activeFocusedStateRetainCount into two values: _focusPreservationCount,
which is safe to reset and resets to 0 when changing the focused element, and _activeFocusedStateRetainCount,
which always increments and decrements, and only does so when using -_retainActiveFocusedState.

This also fixes a bug wherein -_restoreFocusWithToken: is implemented as returning void in WebKit, even
though its declaration in UIKit returns a BOOL. UIKit currently calls this selector on WKContentView and
stores the result within a BOOL; this results in the return value of -_restoreFocusWithToken: effectively
becoming the last byte of the most recent value stored in $rax when exiting -_restoreFocusWithToken:. From
debugging a release build of WebKit, this turns out to just be 0x0, becoming NO, which is correct given that
WKContentView does not attempt to become first responder within _restoreFocusWithToken:.

Tests: FocusPreservationTests.PreserveAndRestoreFocus

FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState

Platform/spi/ios/UIKitSPI.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _incrementFocusPreservationCount]):
(-[WKWebView _decrementFocusPreservationCount]):
(-[WKWebView _resetFocusPreservationCount]):
(-[WKWebView _isRetainingActiveFocusedState]):

Active focus state is retained if either the focus preservation count or active focus state count is non-zero.
Splitting this into two variables ensures that SPI clients of -_retainActiveFocusedState won't have active
focus state reset from underneath them, and additionally prevents WKContentView from retaining active focus due
to UITextInputMultiDocument protocol methods while the user is still interacting with it.

UIProcess/API/Cocoa/WKWebViewInternal.h:

Move _activeFocusedStateRetainCount to the implementation of WKContentView; instead of directly manipulating the
variable, add helper methods to increment, decrement, or reset the focus preservation count.

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewFocused):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView resignFirstResponderForWebView]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

Reset the focus preservation count.

(-[WKContentView addFocusedFormControlOverlay]):
(-[WKContentView removeFocusedFormControlOverlay]):

Use -_retainActiveFocusedState instead of incrementing and decrementing the counter directly.

(-[WKContentView _restoreFocusWithToken:]):
(-[WKContentView _preserveFocusWithToken:destructively:]):

Use _incrementFocusPreservationCount and _decrementFocusPreservationCount instead of manipulating counter
variables directly.

Tools:

Adds a pair of new API tests to verify that (1) resigning first responder while preserving focus does not blur
the focused element, and (2) if another element is focused and presents an input view while preserving focus,
then we reset preservation state and allow first responder resignation to blur the focused element.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/FocusPreservationTests.mm: Added.

(webViewForTestingFocusPreservation):
(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView textInputContentView]):

TestWebKitAPI/ios/UIKitSPI.h:

5:51 PM Changeset in webkit [235877] by Megan Gardner

6 edits in trunk/Source/WebCore

Correctly interpret from angle for conic gradients
https://bugs.webkit.org/show_bug.cgi?id=189445

Reviewed by Simon Fraser

No new tests, no functionality is changing.

Just renaming angle to angleRadians to make the type more clear,
and hopefully avoid bugs in the future. Update patch to original bug
fix.

css/CSSGradientValue.cpp:

(WebCore::CSSConicGradientValue::createGradient):

inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildArrayForCanvasGradient):

platform/graphics/Gradient.cpp:

(WebCore::Gradient::hash const):

platform/graphics/Gradient.h:
platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::paint):

5:44 PM Changeset in webkit [235876] by rniwa@webkit.org

1 edit
1 copy in trunk/LayoutTests/imported/w3c

Revert the errornous change to the test in r235864.

web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html: Replaced with LayoutTests/imported/w3c/web-platform-tests/shadow-dom/Extensions-to-Event-Interface.html.

5:31 PM Changeset in webkit [235875] by commit-queue@webkit.org

4 edits in trunk/Tools

[WHLSL] Add the test shader type
https://bugs.webkit.org/show_bug.cgi?id=189484

Patch by Thomas Denney <tdenney@apple.com> on 2018-09-10
Reviewed by Myles C. Maxfield.

Tests are now precedeed by the 'test' keyword so that they are treated
as entry points, in the same way as vertex and fragment shaders.

WebGPUShadingLanguageRI/LateChecker.js:

(LateChecker.prototype._checkShaderType): Allow tests to return any
type, as some currently return void/pointer types.

WebGPUShadingLanguageRI/Parse.js:

(parseFuncDecl): Add the test keyword.

WebGPUShadingLanguageRI/Test.js: Prepend 'test' to every single test.

4:54 PM Changeset in webkit [235874] by Truitt Savell

2 edits in trunk/LayoutTests

Rebaseline test after https://trac.webkit.org/changeset/235866/webkit.
https://bugs.webkit.org/show_bug.cgi?id=189178.

Unreviewed Test Gardening.

platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt:

4:47 PM Changeset in webkit [235873] by Joseph Pecoraro

28 edits in trunk/Source/WebInspectorUI

Web Inspector: Address some ESLint warnings
https://bugs.webkit.org/show_bug.cgi?id=188824

Reviewed by Matt Baker.

.eslintrc:
UserInterface/Base/Platform.js:
UserInterface/Controllers/AuditManager.js:
UserInterface/Controllers/BasicBlockAnnotator.js:
UserInterface/Controllers/CallFrameTreeController.js:
UserInterface/Controllers/HARBuilder.js:
UserInterface/Models/AuditReport.js:
UserInterface/Models/AuditResult.js:
UserInterface/Models/AuditTestCase.js:
UserInterface/Models/AuditTestSuite.js:
UserInterface/Models/Cookie.js:
UserInterface/Models/SourceCodePosition.js:
UserInterface/Test/FrontendTestHarness.js:
UserInterface/Test/TestSuite.js:
UserInterface/Views/CanvasContentView.js:
UserInterface/Views/CollectionContentView.js:
UserInterface/Views/ContentBrowser.js:
UserInterface/Views/CookieStorageContentView.js:
UserInterface/Views/DataGrid.js:
UserInterface/Views/DatabaseTableContentView.js:
UserInterface/Views/FindBanner.js:
UserInterface/Views/JSONResourceContentView.js:
UserInterface/Views/LogContentView.js:
UserInterface/Views/ResourceSidebarPanel.js:
UserInterface/Views/SourceCodeTextEditor.js:
UserInterface/Views/SpreadsheetTextField.js:
UserInterface/Workers/Formatter/FormatterUtilities.js:

4:24 PM Changeset in webkit [235872] by timothy_horton@apple.com

4 edits in trunk

Make it easier to build for SDK_VARIANT=iosmac
https://bugs.webkit.org/show_bug.cgi?id=189488
<rdar://problem/38254840>

Reviewed by Wenson Hsieh.

Makefile:
Makefile.shared:
Source/Makefile:

Set a variety of build flags (disable libwebrtc, tools, and set
SDK_VARIANT and WK_ALTERNATE_FRAMEWORKS_DIR).

4:15 PM Changeset in webkit [235871] by Ryan Haddad

2 edits in trunk/LayoutTests

Unreviewed test gardening, rebaseline fast/events/ios/keyup.html after r235818.

fast/events/ios/keyup-expected.txt:

3:59 PM Changeset in webkit [235870] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit

Long press on picture/link show menu obscured by keyboard.
https://bugs.webkit.org/show_bug.cgi?id=189114.

Patch by James Savage <James Savage> on 2018-09-10
Reviewed by Megan Gardner.

Use the visible bounds of the window, not the full bounds, when deciding if
an element's rect takes up too much screen space to present from. This factors
in occlusion of the window by the keyboard, bars, and other overlapping content.

If possible, it would be nice to only account for overlapping geometry which a
popover would avoid, but that information is not available. This approach will
produce some false positives in favor of the "from touch" style, but those are
still better than getting an unusably small action sheet.

UIProcess/ios/WKActionSheetAssistant.h:
UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showImageSheet]): Use new helper method for style.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.
(-[WKActionSheetAssistant _presentationStyleForPositionInfo:elementInfo:]):
Query new delegate method to figure out the unobscured rect of the window. This
information only exists on WKScrollView, so we have to ask for it. If this method
is not implemented, fall back to the current approach of assuming the full window
bounds are available.
(presentationStyleForView): Deleted. Replaced by instance method.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView unoccludedWindowBoundsForActionSheetAssistant:]):
Calculate the unoccluded rect using -[UIScrollView adjustedContentInset], which
factors in client specified insets and system insets (such as the keyboard).

3:47 PM Changeset in webkit [235869] by youenn@apple.com

4 edits
1 copy
1 add in trunk

ontrack events should be fired even if an existing transceiver exists
https://bugs.webkit.org/show_bug.cgi?id=189477

Reviewed by Eric Carlson.

Source/WebCore:

In case of an OnTrack callback from libwebrtc, make sure the ontrack event is called even if a transceiver already exists for that track.

Covered by updated video-addTransceiver.html
New test video-addLegacyTransceiver.html keeps testing the old transceiver behavior.
Test: webrtc/video-addLegacyTransceiver.html

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::newTransceiver):

LayoutTests:

webrtc/video-addLegacyTransceiver-expected.txt: Added.
webrtc/video-addLegacyTransceiver.html: Copied from LayoutTests/webrtc/video-addTransceiver.html.
webrtc/video-addTransceiver.html:

3:23 PM Changeset in webkit [235868] by Megan Gardner

6 edits
2 adds in trunk

Correctly interpret from angle for conic gradients
https://bugs.webkit.org/show_bug.cgi?id=189445
<rdar://problem/44158271>

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/gradients/conic-from-angle.html

We were pulling the angle as degrees when we really need radians.

css/CSSGradientValue.cpp:

(WebCore::CSSConicGradientValue::createGradient):

LayoutTests:

Adding a test for a conic gradient that starts at an angle.
Cover the edges because triangles and conic gradients aren't rendered
exactly the same.

TestExpectations:
fast/gradients/conic-from-angle-expected.html: Added.
fast/gradients/conic-from-angle.html: Added.
platform/ios-12/TestExpectations:
platform/mac/TestExpectations:

3:17 PM Changeset in webkit [235867] by Chris Dumez

4 edits in trunk/Source/WebKit

Regression(PSON): WebView is blank when navigating back cross-process on iOS
https://bugs.webkit.org/show_bug.cgi?id=189481
<rdar://problem/44315010>

Reviewed by Tim Horton.

When process swapping on navigation, the WebPageProxy would detach from the old WebProcess and destroy
its RemoteLayerTreeDrawingAreaProxy. It would then create a new process and a new RemoteLayerTreeDrawingAreaProxy
to listen for IPC from this new process. When navigating back to the original process, we would do the
same in the opposite direction. However, the issue was that the old WebProcess's WebPage would not destroy its
drawing area and some state would persist and cause issues. For example, the DrawingArea would send a
CommitLayerTree IPC to the UIProcess and set m_waitingForBackingStoreSwap to true. It normally resets
m_waitingForBackingStoreSwap to false when getting the DidUpdate IPC from the UIProcess. However, when the
WebPage is detached from its WebPageProxy (i.e. suspended due to PSON), the UIProcess would not respond to
IPC from the old WebProcess and m_waitingForBackingStoreSwap would never get reset.

UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::~SuspendedPageProxy):
Make sure we send the SetIsSuspended IPC to the WebProcess with false value when
the SuspendedPageProxy gets destroyed, so that the WebProcess can update its
m_isSuspended flag. Previous, it was set to true when constructing the
SuspendedPageProxy but never reset to false.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsAndRootView):
(WebKit::WebChromeClient::invalidateContentsForSlowScroll):
Add null checks for the drawing area now that it can be null while suspended.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reinitializeWebPage):
When a WebPage gets reattached to a WebPageProxy, this method is called. Since we now
destroy the drawing area upon suspension (WebPage gets detached from WebPageProxy), we
need to make sure we recreate the drawing area when reattaching.

(WebKit::WebPage::setIsSuspended):
Destroy the drawing area when the WebPage is suspended, meaning that this WebPage
is no longer associated with a WebPageProxy.

3:16 PM Changeset in webkit [235866] by commit-queue@webkit.org

11 edits in trunk

Expose -apple-system-container-border color to internal web views.
https://bugs.webkit.org/show_bug.cgi?id=189178.

Patch by James Savage <James Savage> on 2018-09-10
Reviewed by Timothy Hatcher.

Source/WebCore:

Tests: LayoutTests/fast/css/apple-system-colors.html

css/CSSValueKeywords.in: Add new semantic color name.
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor const): Use system color on supported
systems, and fall back to approximation for older systems.

Source/WebCore/PAL:

pal/spi/cocoa/NSColorSPI.h: Declare SPI.

LayoutTests:

fast/css/apple-system-control-colors-expected.txt:
fast/css/apple-system-control-colors.html:
platform/mac-highsierra/fast/css/apple-system-control-colors-expected.txt:
platform/mac-sierra/fast/css/apple-system-control-colors-expected.txt:
platform/mac/fast/css/apple-system-control-colors-expected.txt:

2:54 PM Changeset in webkit [235865] by rniwa@webkit.org

5 edits
6 adds in trunk

mouseenter and mouseleave events don't get dispatched even when there is a capturing event listener for a slot ancestor
https://bugs.webkit.org/show_bug.cgi?id=188561

Reviewed by Darin Adler.

Source/WebCore:

This patch makes mouseenter and mouseleave events to work with shadow trees and slots therein, and makes them uncomposed
as discussed in https://github.com/w3c/uievents/issues/208.

This patch also makes these events dispatched on DOM tree ancestors of the currently hovered element instead of
render tree's hover ancestors to be consistent with the check in hierarchyHasCapturingEventListeners and other browsers.
In particular, using hover ancestors is problematic when there is an element with display: contents such as slot elements,
which do not have a render object.

Tests: fast/shadow-dom/mouseenter-mouseleave-across-shadow-boundary.html

fast/shadow-dom/mouseenter-mouseleave-inside-shadow-tree.html
fast/shadow-dom/mouseenter-mouseleave-on-slot-parent.html

dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):

page/EventHandler.cpp:

(WebCore::nearestCommonHoverAncestor): Deleted.
(WebCore::hierarchyHasCapturingEventListeners): Use parentInComposedTree. Else we would miss capturing event listeners
on inclusive ancestors of slots.
(WebCore::EventHandler::updateMouseEventTargetNode): Use the composed tree's ancestor chain to fire mouseenter and
mouseleave events. This is needed to dispatch mouseenter / mouseleave events on slot elements. Also removed comments
which just state what is self-evident from the code beneath them.

LayoutTests:

Added tests for listening to mouseenter and mouseleave events using capturing and bubbling event listeners
across shadow boundaries.

fast/shadow-dom/mouseenter-mouseleave-across-shadow-boundary-expected.txt: Added.
fast/shadow-dom/mouseenter-mouseleave-across-shadow-boundary.html: Added.
fast/shadow-dom/mouseenter-mouseleave-inside-shadow-tree-expected.txt: Added.
fast/shadow-dom/mouseenter-mouseleave-inside-shadow-tree.html: Added.
fast/shadow-dom/mouseenter-mouseleave-on-slot-parent-expected.txt: Added.
fast/shadow-dom/mouseenter-mouseleave-on-slot-parent.html: Added.
platform/ios/TestExpectations: Skip the new tests since mouse events aren't supported on iOS.

2:48 PM Changeset in webkit [235864] by rniwa@webkit.org

4 edits in trunk

Remove isOrphan check in ShadowRoot::setInnerHTML
https://bugs.webkit.org/show_bug.cgi?id=189449

Reviewed by Darin Adler.

Removed isOrphan() check in ShadowRoot::setInnerHTML needed for webkit.org/b/88834.

The only reason this check was kept in the code was because the fix for V8 couldn't be landed
due to a perf regression but V8 binding isn't even a thing in WebKit anymore.

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML):

dom/ShadowRoot.h:

2:42 PM Changeset in webkit [235863] by Simon Fraser

2 edits in trunk/Source/WebCore

Many textarea tests leak documents because Document::removeFocusNavigationNodeOfSubtree() can trigger a Document retain cycle
https://bugs.webkit.org/show_bug.cgi?id=188722

Reviewed by Ryosuke Niwa.

Fix a retain cycle created when Document::adjustFocusNavigationNodeOnNodeRemoval() sets
m_focusNavigationStartingNode to itself. m_focusNavigationStartingNode is a Node* (not sure why it's not an Element*),
making it possible to assign the Document to it, which creates a reference to the document which prevents
Document::removedLastRef() ever running and doing the necessary cleanup.

Fix by setting m_focusNavigationStartingNode to null if code tries to set it to the Document. This can happen
when an element is focused and the page calls document.write(), which removes all children.

Will be tested by future leak testing. Fixes the document leak in at least the following tests:

fast/forms/append-children-during-form-submission.html
fast/forms/empty-textarea-toggle-disabled.html
fast/forms/textarea-paste-newline.html
fast/forms/textarea-trailing-newline.html

dom/Document.cpp:

(WebCore::Document::setFocusNavigationStartingNode):
(WebCore::Document::adjustFocusNavigationNodeOnNodeRemoval):

2:19 PM Changeset in webkit [235862] by Simon Fraser

7 edits in trunk/Source/WebCore

svg/W3C-SVG-1.1/render-groups-03-t.svg and some other SVG tests leak documents
https://bugs.webkit.org/show_bug.cgi?id=189147

Reviewed by Dean Jackson.

Document::removedLastRef() needs to clean up m_fontSelector, because it can reference
CSSFontFaceSources that keep SVGFontFaceElements alive, and they in turn will keep
the Document alive.

Also add the beginnings of a Fonts log channel.

This will be tested by world leak testing (webkit.org/b/189332).

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::CSSFontSelector):
(WebCore::CSSFontSelector::~CSSFontSelector):

dom/Document.cpp:

(WebCore::Document::removedLastRef):

platform/Logging.h:
platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontDataIfNeeded):
(WebCore::FontCache::purgeInactiveFontData):

svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::~SVGFontFaceElement):

svg/SVGFontFaceElement.h:

2:11 PM Changeset in webkit [235861] by don.olmstead@sony.com

12 edits in trunk

CBOR coders should only be compiled if WebAuthN is enabled
https://bugs.webkit.org/show_bug.cgi?id=189425

Reviewed by Jiewen Tan.

Source/WebCore:

No new tests. No change in behavior.

Just places ENABLE(WEB_AUTHN) guards around all CBOR files.

Modules/webauthn/cbor/CBORBinary.h:
Modules/webauthn/cbor/CBORReader.cpp:
Modules/webauthn/cbor/CBORReader.h:
Modules/webauthn/cbor/CBORValue.cpp:
Modules/webauthn/cbor/CBORValue.h:
Modules/webauthn/cbor/CBORWriter.cpp:
Modules/webauthn/cbor/CBORWriter.h:

Tools:

Just places ENABLE(WEB_AUTHN) guards around CBOR test files.

TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:
TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:

2:02 PM Changeset in webkit [235860] by dbates@webkit.org

9 edits in trunk

[iOS] Arrow keys do not dispatch DOM events to non-editable elements
https://bugs.webkit.org/show_bug.cgi?id=189389

Reviewed by Simon Fraser.

Source/WebCore:

On iOS the arrow keys are identified by special multi character key strings: UIKeyInput{Up,
Down, Left, Right}Arrow as opposed to special key codes as on Mac. When converting the iOS-
specific WebEvent we need to take care to recognize when the key string for the event is
one of these special key strings when computing key code, character code, and key identifier
properties for the WebCore platform-specific event. These details will be included in
the corresponding DOM keyboard events that are dispatched when the arrow keys are pressed.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:

Mark file PlatformEventFactoryIOS as @no-unify as it is not compatible with the unified sources
build strategy given its use of wtf/cocoa/SoftLinking.h macros.

platform/ios/PlatformEventFactoryIOS.h:
platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::convertSpecialKeyToCharCode): Manufacture the appropriate character code for an
event that represents an arrow key. Otherwise, return std::nullopt to indicate that the
event is not for an arrow key.
(WebCore::keyCodeForEvent): Manufacture the appropriate Windows virtual key code for an
event that represents an arrow key. Otherwise, do what we do now and return the key code
associated with the WebEvent.
(WebCore::keyIdentifierForKeyEvent): Modified to test if the event is for an arrow key
and return the appropriate key identifier.
(WebCore::keyForKeyEvent): Modified to test if the event is for an arrow key
and return the appropriate character code.
(WebCore::codeForKeyEvent): Modified to call keyCodeForEvent(), which knows how to account
for events that represent arrow keys.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

Source/WebKit:

Use WebCore::keyCodeForEvent() to retrieve the key code for a WebEvent instead of querying
the key code from the WebEvent directly. The function WebCore::keyCodeForEvent() knows how
to compute the key code for an event that represents an arrow key.

Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

LayoutTests:

Update expected result now that we compute the correct keyIdentifier, keycode, and which properties
for DOM keyboard events dispatched when the arrow keys are pressed.

fast/events/ios/keydown-keyup-in-non-editable-content-expected.txt:

1:57 PM Changeset in webkit [235859] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit

Try to fix the iOSMac build
https://bugs.webkit.org/show_bug.cgi?id=189469

UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextSetPluginLoadClientPolicy):
(WKContextClearPluginClientPolicies):
(WKContextCopyPlugInInfoForBundleIdentifier):
(WKContextGetInfoForInstalledPlugIns):
(WKContextResetHSTSHosts):
(WKContextResetHSTSHostsAddedAfterDate):
(WKContextRegisterSchemeForCustomProtocol):
(WKContextUnregisterSchemeForCustomProtocol):

UIProcess/API/C/mac/WKPagePrivateMac.mm:

(-[WKObservablePageState initWithPage:]):
(WKPageCreateObservableState):
(WKPageGetObjectRegistry):
(WKPageIsURLKnownHSTSHost):
(WKPageLoadURLRequestReturningNavigation):
(WKPageLoadFileReturningNavigation):
(WKPageIsPlayingVideoInEnhancedFullscreen):
(WKPageSetFullscreenDelegate):
(WKPageGetFullscreenDelegate):

UIProcess/API/C/mac/WKProtectionSpaceNS.mm:

(WKProtectionSpaceCopyNSURLProtectionSpace):

1:55 PM Changeset in webkit [235858] by dbates@webkit.org

3 edits
2 adds in trunk

[iOS] Make WKWebView become the first responder to support testing key presses to non-editable elements
https://bugs.webkit.org/show_bug.cgi?id=189432

Reviewed by Simon Fraser.

Tools:

Make the WKWebView become the first responder immediately without the need to focus an editable
element. This allows us to test that DOM keyboard events are dispatched to non-editable elements.

WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::PlatformWebView):

LayoutTests:

Add a test that DOM keyboard events are dispatched to a non-editable <body> when simulating key
presses using a hardware keyboard.

fast/events/ios/keydown-keyup-in-non-editable-content-expected.txt: Added.
fast/events/ios/keydown-keyup-in-non-editable-content.html: Added.

1:39 PM Changeset in webkit [235857] by mitz@apple.com

3 edits in trunk/Source/WebCore

[macOS] Editor::readSelectionFromPasteboard’s MailBlockquoteHandling argument is effectively unused
https://bugs.webkit.org/show_bug.cgi?id=189480

Reviewed by Anders Carlsson.

No new tests, because this doesn’t change behavior.

editing/Editor.h: Removed the MailBlockquoteHandling argument from readSelectionFromPasteboard.
editing/mac/EditorMac.mm:

(WebCore::Editor::readSelectionFromPasteboard): Don’t pass mailBlockquoteHandling to

pasteWithPasteboard. It was always set to RespectBlockquote, which is the latter’s
default.

1:08 PM Changeset in webkit [235856] by aestes@apple.com

12 edits
1 copy
2 adds in trunk

[Payment Request] Use JSValueInWrappedObject for PaymentResponse's details attribute
https://bugs.webkit.org/show_bug.cgi?id=189458

Reviewed by Youenn Fablet.

Source/WebCore:

Test: http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html

Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::didAuthorizePayment):

Created a PaymentResponse::DetailsFunction that converts the ApplePayPayment into a JSValue.

Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::accept):

Passed detailsFunction into PaymentResponse::create().

Modules/paymentrequest/PaymentRequest.h:
Modules/paymentrequest/PaymentResponse.cpp:

(WebCore::PaymentResponse::PaymentResponse):

Modules/paymentrequest/PaymentResponse.h:
Modules/paymentrequest/PaymentResponse.idl:

Removed m_details and replaced it with a DetailsFunction and a cached JSValueInWrappedObject.
JSPaymentResponseCustom.cpp uses these values to implement the details attribute getter.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSPaymentResponseCustom.cpp: Added.

(WebCore::JSPaymentResponse::details const):

Called PaymentResponse::detailsFunction() to cache a JSValue for the details attribute.

(WebCore::JSPaymentResponse::visitAdditionalChildren):

Visited PaymentResponse::cachedDetails().

bindings/js/JSServiceWorkerClientCustom.cpp:

Fixed a missing include issue that cropped up due to unified source shuffling.

LayoutTests:

fast/dom/reference-cycle-leaks.html:
http/tests/paymentrequest/payment-response-reference-cycle-leak.https-expected.txt: Added.
http/tests/paymentrequest/payment-response-reference-cycle-leak.https.html: Added.

12:39 PM Changeset in webkit [235855] by fred.wang@free.fr

2 edits in trunk/LayoutTests

[CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
https://bugs.webkit.org/show_bug.cgi?id=182230

Follow-up patch replacing document.body with document.scrollingElement in
fast-scroll-iframe-latched-mainframe.html. This fixes flaky behavior.

Patch by Frederic Wang <fwang@igalia.com> on 2018-09-10
Reviewed by Antonio Gomes.

tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html: Replace document.body

with document.scrollingElement since this document is in standard mode.

12:05 PM Changeset in webkit [235854] by graouts@webkit.org

4 edits
2 adds in trunk

[Web Animations] Positive delays of accelerated animations are not respected
https://bugs.webkit.org/show_bug.cgi?id=189411
<rdar://problem/44151416>

Reviewed by Dean Jackson.

Source/WebCore:

Test: webanimations/accelerated-animation-with-delay-and-seek.html

We were only accounting for negative delays for accelerated actions. We also were misbehaving
when seeking an animation with a delay (positive or negative) since we wouldn't reset the animation
begin time to be the current time when adjusting its time offset, while the begin time set when
first creating the animation would be set accounting for the time offset.

animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::seekCAAnimationOnLayer):

LayoutTests:

Add a test that checks that positive delays are accounted for during accelerated actions, including a seek.

webanimations/accelerated-animation-with-delay-and-seek-expected.html: Added.
webanimations/accelerated-animation-with-delay-and-seek.html: Added.

11:30 AM Changeset in webkit [235853] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Try to fix the build after r235850

UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

11:19 AM Changeset in webkit [235852] by yusukesuzuki@slowstart.org

11 edits
2 adds in trunk

[WTF] Add Markable<T, Traits>
https://bugs.webkit.org/show_bug.cgi?id=189231

Reviewed by Sam Weinig.

Source/WebCore:

Use Markable<Seconds> and Markable<WallTime> in ResourceResponseBase.
Since these fields are parsed results from http header fields, Seconds::nan() and WallTime::nan()
can be used as an empty value for these fields. Thus we can use Markable because it uses
these nan values as an empty values (they are configured by Seconds::MarkableTraits and WallTime::MarkableTraits).
This reduces the size of ResourceResponseBase from 448 to 416.

platform/network/ResourceResponseBase.h:

Source/WTF:

We can represent a value with nullopt by using std::optional<T>. However, std::optional<T> has storage efficiency
problem. It always has a bool indicating that the value is nullopt or not. If we have a following class,

class A {

std::optional<WallTime> m_timeA;
std::optional<WallTime> m_timeB;
std::optional<WallTime> m_timeC;

};

This class has significant amount of padding between m_timeA / m_timeB, m_timeB / m_timeC due to the above bool.

If we know that WallTime has a value that represents invalid, we can use it instead and save the storage.
This is very similar problem to our HashTable implementation. In our HashTable implementation, we need Deleted
and Empty value, which can represent Deleted and Empty values without sacrificing storage efficiency.

We should have similar mechanism here. In this patch, we have WTF::Markable<T, Traits>. Traits offers
Traits::isEmptyValue(value) and Traits::emptyValue(). Then, we use this empty value instead of having bool
flag. This way, we can make sizeof(WTF::Markable<T>) == sizeof(T).

This idea is inspired from https://github.com/akrzemi1/markable. But we would like to have WTF::Markable<T>
here instead of importing it since we would like to have (1) integrated interfaces with std::optional<T> and (2)
aligned function names to HashTraits' isEmptyValue and emptyValue.

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/Markable.h: Added.

(WTF::std::underlying_type<EnumType>::type>::max): EnumMarkableTraits can be used as an MarkableTraits for enum
values. We can specify a constant value as an empty value.
(WTF::IntegralMarkableTraits::isEmptyValue):
(WTF::IntegralMarkableTraits::emptyValue): IntegralMarkableTraits can be used as an MarkableTraits for integral
types including int etc.
(WTF::Markable::Markable):
(WTF::Markable::operator bool const):
(WTF::Markable::reset):
(WTF::Markable::value const):
(WTF::Markable::value):
(WTF::Markable::operator-> const):
(WTF::Markable::operator->):
(WTF::Markable::operator* const):
(WTF::Markable::operator*):
(WTF::Markable::operator std::optional<T>):
(WTF::Markable::operator std::optional<T> const): This operator allows us to cast Markable<T> to
std::optional<T>.

wtf/MonotonicTime.h:

(WTF::MonotonicTime::MarkableTraits::isEmptyValue):
(WTF::MonotonicTime::MarkableTraits::emptyValue): MarkableTraits for MonotonicTime. MonotonicTime::nan() is used
as an empty value.

wtf/Seconds.h:

(WTF::Seconds::MarkableTraits::isEmptyValue):
(WTF::Seconds::MarkableTraits::emptyValue): MarkableTraits for Seconds. Seconds::nan() is used as an empty value.

wtf/WallTime.h:

(WTF::WallTime::nan):
(WTF::WallTime::MarkableTraits::isEmptyValue):
(WTF::WallTime::MarkableTraits::emptyValue): MarkableTraits for WallTime. WallTime::nan() is used as an empty value.

Tools:

Add tests for Markable.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WTF/Markable.cpp: Added.

(TestWebKitAPI::TEST):

11:16 AM Changeset in webkit [235851] by Simon Fraser

5 edits in trunk

Before tracking Document leaks, clear all caches
https://bugs.webkit.org/show_bug.cgi?id=189459

Reviewed by Sam Weinig.
Source/WebKit:

It's not enough to clear the page and memory caches; font caches can reference Documents (for SVG fonts),
so just call WebCore::releaseMemory(), which empties caches including the page and memory caches, and
does the GC that we need to happen.

WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleReleaseMemory):
(WKBundleClearPageCache): Deleted.
(WKBundleClearMemoryCache): Deleted.

WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:

Tools:

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

10:20 AM Changeset in webkit [235850] by mrajca@apple.com

22 edits
1 add in trunk

Source/WebCore:
Touch Bar displays an active PIP button for audio elements (and it doesn't do anything)
https://bugs.webkit.org/show_bug.cgi?id=189433
<rdar://problem/44186498> Touch Bar displays an active PIP button for audio elements (and it doesn't do anything)

Reviewed by Eric Carlson.

When playing an audio element, the media Touch Bar displays an active PIP button even though only
videos are PIP-able. Pressing it does not do anything. The issue is canTogglePictureInPicture is set
to YES unconditionally on the WebPlaybackControlsManager. It is then only updated based on whether or
not external playback is enabled.

This patch extends that logic such that the picture-in-picture Touch Bar button will be disabled for
audio elements. Since PlaybackSessionModelMediaElement today does not know whether we're dealing
with an audio or video element, a new isPictureInPictureSupported flag has been added (as well as
the plumbing necessary to get the state over from the web process).

An API test has been added that checks the value of the canTogglePictureInPicture and ensures it
is NO when audio elements are playing. To expose it to tests, a _canTogglePictureInPictureForTesting
property has been added to the WKTesting category.

platform/cocoa/PlaybackSessionModel.h:

(WebCore::PlaybackSessionModelClient::isPictureInPictureSupportedChanged):

platform/cocoa/PlaybackSessionModelMediaElement.h:
platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::setMediaElement):
(WebCore::PlaybackSessionModelMediaElement::isPictureInPictureSupported const):

platform/mac/PlaybackSessionInterfaceMac.h:
platform/mac/PlaybackSessionInterfaceMac.mm:

(WebCore::PlaybackSessionInterfaceMac::isPictureInPictureSupportedChanged):
(WebCore::PlaybackSessionInterfaceMac::externalPlaybackChanged):
(WebCore::PlaybackSessionInterfaceMac::updatePlaybackControlsManagerCanTogglePictureInPicture):

Source/WebKit:
Touch Bar displays an active PIP button for audio elements (and it doesn't do anything)
https://bugs.webkit.org/show_bug.cgi?id=189433
<rdar://problem/44186498> Touch Bar displays an active PIP button for audio elements (and it doesn't do anything)

Reviewed by Eric Carlson.

Source/WebKit:

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _canTogglePictureInPictureForTesting]):

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in:
UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::pictureInPictureSupportedChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureSupportedChanged):

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateMediaTouchBar):
(WebKit::WebViewImpl::canTogglePictureInPictureForTesting):

UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
WebProcess/cocoa/PlaybackSessionManager.h:
WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionInterfaceContext::isPictureInPictureSupportedChanged):
(WebKit::PlaybackSessionManager::isPictureInPictureSupportedChanged):

Tools:
https://bugs.webkit.org/show_bug.cgi?id=189433
<rdar://problem/44186498> Touch Bar displays an active PIP button for audio elements (and it doesn't do anything)

Reviewed by Eric Carlson.

An API test has been added that checks the value of the canTogglePictureInPicture and ensures it
is NO when audio elements are playing.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.html:
TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/audio-with-controls.html: Added.

7:35 AM Changeset in webkit [235849] by pvollan@apple.com

2 edits in trunk/LayoutTests

[Windows] Layout Test webanimations/accelerated-transition-interrupted-on-composited-element.html is failing
https://bugs.webkit.org/show_bug.cgi?id=189468

Unreviewed test gardening.

The test is timing out. Skip it on Windows.

platform/win/TestExpectations:

7:04 AM Changeset in webkit [235848] by aboya@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer] Fix overflow in buffered ranges
https://bugs.webkit.org/show_bug.cgi?id=189419

Reviewed by Philippe Normand.

Scale operations on big numbers (like media timestamps or durations)
should be made with GStreamer utility functions to avoid overflows.

This fixes an assertion when a 24 hour long fragmented MP4 file is
played.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered const):

5:00 AM Changeset in webkit [235847] by fred.wang@free.fr

2 edits in trunk/Source/WebCore

Refactor filter list checking code
https://bugs.webkit.org/show_bug.cgi?id=185087

Patch by Frederic Wang <fwang@igalia.com> on 2018-09-07
Reviewed by Yusuke Suzuki.

No new tests, behavior unchanged.

animation/KeyframeEffectReadOnly.h: Add missing forward-declaration FilterOperations.

2:10 AM Changeset in webkit [235846] by Philippe Normand

5 edits in trunk

[GStreamer] Several media related tests timing out around the same revision
https://bugs.webkit.org/show_bug.cgi?id=189349

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The timeouts were happening because the ended event was no
longer properly emitted. The change in playbackPosition also
ensures timeupdate event remains emitted in a... timely manner.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::playbackPosition const):
Reduce the position cache threshold to 200ms, which is a value
slightly lower than the 250ms defined in HTMLMediaElement.
(WebCore::MediaPlayerPrivateGStreamer::didEnd): Reset the cached
position value to ensure the following query will most likely
return the same value as reported by the duration query.

LayoutTests:

platform/gtk/TestExpectations: Unflag Timeout from now-unaffected tests.

1:57 AM Changeset in webkit [235845] by Fujii Hironori

3 edits in trunk/Source/WebKit

[MSVC] X86Assembler.h(108): error C2666: 'WebCore::operator -': 7 overloads have similar conversions
https://bugs.webkit.org/show_bug.cgi?id=189467

Unreviewed build fix for WinCairo port.

MSVC reports compilation errors if certain JSC header files are
included after "using namespace" statements.

Sources.txt: Added @no-unify to InjectedBundleNodeHandle.cpp and InjectedBundleRangeHandle.cpp temporarily.
WebKit.xcodeproj/project.pbxproj: Compile InjectedBundleNodeHandle.cpp and InjectedBundleRangeHandle.cpp.

1:28 AM Changeset in webkit [235844] by commit-queue@webkit.org

7 edits in trunk

XMLHttpRequest: overrideMimeType should not update the response's "Content-Type" header
https://bugs.webkit.org/show_bug.cgi?id=189465

Patch by Rob Buis <rbuis@igalia.com> on 2018-09-10
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

web-platform-tests/xhr/overridemimetype-invalid-mime-type-expected.txt:

Source/WebCore:

The xhr spec changed [1, 2] so that overrideMimeType should not update the
response's "Content-Type" header anymore.

Behavior matches Firefox and Chrome.

[1] https://xhr.spec.whatwg.org/#dom-xmlhttprequest-overridemimetype
[2] https://github.com/whatwg/xhr/issues/157

Tests: http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html

web-platform-tests/xhr/overridemimetype-invalid-mime-type.htm

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didReceiveResponse):

LayoutTests:

Change existing test to reflect new behavior.

http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header-expected.txt:
http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-content-type-header.html:

12:13 AM Changeset in webkit [235843] by graouts@webkit.org

4 edits
2 adds in trunk

[Web Animations] Interrupting an accelerated CSS transition on a composited element in flight fails
https://bugs.webkit.org/show_bug.cgi?id=189405
<rdar://problem/43342639>

Reviewed by Simon Fraser.

Source/WebCore:

Test: webanimations/accelerated-transition-interrupted-on-composited-element.html

If we interrupt an animation on an element that is composited also outside of the duration of the animation,
the "stop" accelerated action would fail to be performed because we no longer had a resolved current time and
the accelerated animation applied to the layer would never be removed.

However, having a resolved current time is not necessary to stop an animation, only for the other types of
actions (play, pause and seek). So we now simply default to a 0s time for an unresolved current time for a
simple fix to this issue.

animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):

LayoutTests:

Add a new test that checks that interrupting a CSS transition targeting an accelerated property for an element
that is composited outside the duration of the transition correctly interrupts the animation and jumps straight
to the target value.

platform/win/TestExpectations:
webanimations/accelerated-transition-interrupted-on-composited-element-expected.html: Added.
webanimations/accelerated-transition-interrupted-on-composited-element.html: Added.

Sep 9, 2018:

10:37 PM Changeset in webkit [235842] by Fujii Hironori

2 edits in trunk/Source/WebKit

Unreviewed, rolling out r235839.

Which breaks all Xcode based ports

Reverted changeset:

"[MSVC] X86Assembler.h(108): error C2666: 'WebCore::operator
-': 7 overloads have similar conversions"
https://bugs.webkit.org/show_bug.cgi?id=189467
https://trac.webkit.org/changeset/235839

10:20 PM Changeset in webkit [235841] by Fujii Hironori

21 edits in trunk/Source

Add specialized template declarations of HashTraits and DefaultHash to detect misuse
https://bugs.webkit.org/show_bug.cgi?id=189044

Reviewed by Yusuke Suzuki.

Source/WebCore:

Some classes have a separate header for specializations of
WTF::HashTraits and WTF::DefaultHash to reduce the number of
header files included. For example, ColorHash.h and Color.h.

If someone is mistakenly using HashSet or HashMap without
including the specialization header, unexpected template
instantiation can cause subtle bugs. For example, MSVC linker
would silently produce an broken executable (Bug 188893).

By applying this change, I found three misuse cases in
DebugPageOverlays.cpp, AVVideoCaptureSource.h and WebPage.h. As
far as I analyzed, I concluded that these misuses don't introduce
any bugs at the moment, and they are not testable (Bug 189044 Comment 9),
except the MSVC issue (Bug 188893).

No new tests (Covered by existing tests).

Modules/webdatabase/SQLResultSetRowList.h: Removed unused #include <wtf/HashTraits.h>.
bindings/js/SerializedScriptValue.cpp: Ditto.
page/DebugPageOverlays.cpp: Added #include "ColorHash.h" to instantiate HashMap<String, Color>.
platform/URLHash.h: Added DefaultHash<URL> specialization definition.
platform/URL.h: Added specialized template declarations.
platform/graphics/Color.h: Ditto.
platform/graphics/FloatSize.h: Ditto.
platform/graphics/IntPoint.h: Ditto.
platform/graphics/IntSize.h: Ditto.
platform/network/ProtectionSpace.h: Ditto.
platform/network/ProtectionSpaceHash.h: Removed unnecessary DefaultHash declaration.
platform/mediastream/mac/AVVideoCaptureSource.h:

Added #include "IntSizeHash.h" to instantiate HashMap<String, IntSize>.

Source/WebKit:

WebProcess/WebPage/WebPage.h: Added #include <WebCore/IntPointHash.h> to instantiate HashMap<std::pair<IntSize, double>, IntPoint>.

Source/WTF:

wtf/BitVector.h: Removed unnecessary HashTraits declaration.
wtf/MetaAllocatorPtr.h: Ditto.
wtf/IndexSparseSet.h: Removed unused #include <wtf/HashTraits.h>.
wtf/LoggingHashMap.h: Removed unused #include <wtf/LoggingHashTraits.h>.
wtf/StackShot.h: Added #include <wtf/HashTraits.h> because this header uses SimpleClassHashTraits.

Removed unnecessary HashTraits declaration.

10:12 PM Changeset in webkit [235840] by Fujii Hironori

3 edits in trunk/Source/WebCore

[Win][Clang] Add FloatRect(const RECT&) constructor
https://bugs.webkit.org/show_bug.cgi?id=189398

Reviewed by Alex Christensen.

While trying to build WebKit WinCairo port with the latest Clang
(Bug 171618), the following compilation errors were reported.

error: no viable conversion from returned value of type 'RECT' (aka 'tagRECT') to function return type 'WebCore::FloatRect'

No new tests (No behavior change).

platform/graphics/FloatRect.h:
platform/graphics/win/FloatRectDirect2D.cpp:

(WebCore::FloatRect::FloatRect): Added a new constructor taking a RECT as the argument.

9:54 PM Changeset in webkit [235839] by Fujii Hironori

2 edits in trunk/Source/WebKit

[MSVC] X86Assembler.h(108): error C2666: 'WebCore::operator -': 7 overloads have similar conversions
https://bugs.webkit.org/show_bug.cgi?id=189467

Unreviewed build fix for WinCairo port.

MSVC reports compilation errors if certain JSC header files are
included after "using namespace" statements.

Sources.txt: Added @no-unify to InjectedBundleNodeHandle.cpp and InjectedBundleRangeHandle.cpp temporarily.

4:04 PM Changeset in webkit [235838] by bshafiei@apple.com

1 copy in tags/Safari-606.2.100

Tag Safari-606.2.100.

10:55 AM Changeset in webkit [235837] by commit-queue@webkit.org

22 edits in trunk/Tools

Unreviewed, rolling out r235832.
https://bugs.webkit.org/show_bug.cgi?id=189464

Broke WebKit2 tests (Requested by ap on #webkit).

Reverted changeset:

"[Cocoa] Turn on ARC for WebKitTestRunner"
https://bugs.webkit.org/show_bug.cgi?id=189228
https://trac.webkit.org/changeset/235832

Sep 8, 2018:

10:02 PM Changeset in webkit [235836] by Simon Fraser

2 edits in trunk/Tools

accessibility/notification-listeners.html abandons a document
https://bugs.webkit.org/show_bug.cgi?id=188724

Reviewed by Darin Adler.

AccessibilityControllerMac leaked m_globalNotificationHandler, which leaks a JSValueProtect'd function,
which leaks a Document. Fix by using adoptNS().

WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::AccessibilityController::addNotificationListener):

9:24 PM Changeset in webkit [235835] by Wenson Hsieh

18 edits in trunk/Tools

[Cocoa] Use more bridging casts in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=189457

Reviewed by Darin Adler.

Adds some bridging casts to TestWebKitAPI, when converting betweeen several common types of objects, including:
CFStringRef <=> NSString
CFURLRef <=> NSURL
WKPreferences <=> WKPreferencesRef
CFDataRef <=> NSData

TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:

(readHTMLFromPasteboard):
(createWebViewWithCustomPasteboardDataEnabled):

TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:

(createWebViewWithCustomPasteboardDataEnabled):

TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:

(writeHTMLToPasteboard):
(createWebViewWithCustomPasteboardDataSetting):

TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:

(TEST):

TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:

(TestWebKitAPI::setUpWebView):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:

(writeRTFToPasteboard):
(writeRTFDToPasteboard):
(createWebViewWithCustomPasteboardDataEnabled):
(TEST):

TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:

(createWebViewWithCustomPasteboardDataEnabled):

TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(webViewForTestingAttachments):

TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:

(writeRTFDToPasteboard):
(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

(checkRichTextTypePrecedesPlainTextType):
(TestWebKitAPI::TEST):
(TestWebKitAPI::setUpTestWebViewForDataTransferItems):

TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::createInjectedBundlePath):
(TestWebKitAPI::Util::createURLForResource):
(TestWebKitAPI::Util::URLForNonExistentResource):
(TestWebKitAPI::Util::MIMETypeForWKURLResponse):

TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::loadURL):

9:16 PM Abandoned documents edited by Simon Fraser

(diff)

8:25 PM Changeset in webkit [235834] by Wenson Hsieh

3 edits
2 adds in trunk

REGRESSION (r235153): [iOS] Can't move selection start grabber when selecting text in a subframe
https://bugs.webkit.org/show_bug.cgi?id=189454
<rdar://problem/44265956>

Reviewed by Darin Adler.

Source/WebKit:

rangeForPointInRootViewCoordinates is responsible for taking a user gesture location representing the location
of the selection start or end handle (given in root view coordinates) and computing a Range representing an
updated selection. r235153 introduced a mechanism here to clamp the y offset of this user gesture location to
a max or min value determined by computing the bounds of the other selection handle, which more closely matches
platform behavior elsewhere in iOS.

However, this clamping logic would cause the user gesture location in root view coordinates to incorrectly clamp
in cases where the user selects text within an iframe that is offset from the top of the main document, since it
compares content coordinates (i.e. the caret bounds) against root view coordinates (i.e. the gesture location).
This makes it impossible to use selection handles to select text in some iframes.

We fix this by first converting the gesture location to document coordinates, and then clamping.

Test: editing/selection/ios/selection-handle-clamping-in-iframe.html

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPointInRootViewCoordinates):

Also reuse selectionStart and selectionEnd when computing absolute caret bounds, instead of creating new
VisiblePositions.

LayoutTests:

Adds a test that selects a word inside an iframe, moves the selection start handle down past the selection end,
and then moves the selection end handle up above the selection start. The test verifies that the entire word
remains selected.

editing/selection/ios/selection-handle-clamping-in-iframe-expected.txt: Added.
editing/selection/ios/selection-handle-clamping-in-iframe.html: Added.

7:03 PM Changeset in webkit [235833] by aestes@apple.com

15 edits
2 copies
1 move
2 adds
1 delete in trunk

[Apple Pay] Dispatch a paymentmethodchange event when the payment method changes
https://bugs.webkit.org/show_bug.cgi?id=189386

Reviewed by Darin Adler.

Source/WebCore:

Implemented the "payment method changed" algorithm as defined in the Payment Request API W3C
Editor's Draft of 05 September 2018.

Payment Request says that the user agent MAY run this algorithm when the payment method
changes. In our case, we only wish to dispatch this event when a listener is registered for
it. Since PassKit requires merchants to respond to this event by calling updateWith() within
30 seconds, firing the event unconditionally would break compatibility with existing
clients.

For merchants that do not listen for this event, they can continue to use modifiers to
update details based on the selected payment method type.

Also made PaymentMethodChangeEvent.methodDetails a cached attribute in a way that avoids
potential reference cycles from holding a JSC::Strong in the wrapped object.

Test: http/tests/ssl/applepay/ApplePayPaymentMethodChangeEvent.https.html

CMakeLists.txt:
DerivedSources.make:
Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::toJSDictionary):
(WebCore::ApplePayPaymentHandler::didAuthorizePayment):
(WebCore::ApplePayPaymentHandler::didSelectPaymentMethod):

Modules/paymentrequest/PaymentMethodChangeEvent.cpp:

(WebCore::PaymentMethodChangeEvent::PaymentMethodChangeEvent):

Modules/paymentrequest/PaymentMethodChangeEvent.h:
Modules/paymentrequest/PaymentMethodChangeEvent.idl:
Modules/paymentrequest/PaymentMethodChangeEventInit.idl: Removed.
Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::paymentMethodChanged):

Modules/paymentrequest/PaymentRequest.h:
Modules/paymentrequest/PaymentRequestUpdateEvent.cpp:

(WebCore::PaymentRequestUpdateEvent::updateWith):

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSPaymentMethodChangeEventCustom.cpp: Added.

(WebCore::JSPaymentMethodChangeEvent::methodDetails const):
(WebCore::JSPaymentMethodChangeEvent::visitAdditionalChildren):

LayoutTests:

fast/dom/reference-cycle-leaks-expected.txt:
fast/dom/reference-cycle-leaks.html:
http/tests/ssl/applepay/ApplePayPaymentMethodChangeEvent.https-expected.txt: Added.
http/tests/ssl/applepay/ApplePayPaymentMethodChangeEvent.https.html: Added.
platform/ios-wk2/fast/dom/reference-cycle-leaks-expected.txt: Added.
platform/mac-wk2/fast/dom/reference-cycle-leaks-expected.txt: Added.

2:29 PM Changeset in webkit [235832] by Darin Adler

22 edits in trunk/Tools

[Cocoa] Turn on ARC for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=189228

Reviewed by Sam Weinig.

TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:

(+[EventSerializer dictionaryForEvent:relativeToTime:]): Removed autorelease.

TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:

(-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Removed autorelease.

WebKitTestRunner/Configurations/Base.xcconfig: Added CLANG_ENABLE_OBJC_ARC.

WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:

(WTR::AccessibilityController::accessibleElementById): Use a bridge cast.

WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm:

(WTR::AccessibilityTextMarker::isEqual): Ditto.

WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::AccessibilityUIElement): Removed retain.
(WTR::AccessibilityUIElement::~AccessibilityUIElement): Removed release.
(WTR::AccessibilityUIElement::removeNotificationListener): Removed release.
(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use a bridge cast.
(WTR::AccessibilityUIElement::textMarkerRangeForElement): Ditto.
(WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
(WTR::AccessibilityUIElement::previousTextMarker): Ditto.
(WTR::AccessibilityUIElement::nextTextMarker): Ditto.
(WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
(WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers): Ditto.
(WTR::_CGPathEnumerationIteration): Ditto.
(WTR::AccessibilityUIElement::pathDescription const): Ditto.

WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler dealloc]): Removed [super dealloc].

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration): Removed release.
(WTR::TestController::cocoaPlatformInitialize): Removed release.
(WTR::TestController::platformCreateOtherPage): Removed autorelease.

WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView dealloc]): Removed [super dealloc] and also many
cases of setting properties to nil that were only present for memory
management reasons.

WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:

(-[GeneratedTouchesDebugWindow dealloc]): Removed release and [super dealloc].

WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator dealloc]): Deleted.
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Removed
Block_copy.
(-[HIDEventGenerator markerEventReceived:]): Removed Block_release.
(-[HIDEventGenerator interpolatedEvents:]): Removed release.
(-[HIDEventGenerator sendEventStream:completionBlock:]): Removed autorelease.

WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(-[WebKitTestRunnerWindow dealloc]): Removed [super dealloc].
(WTR::PlatformWebView::PlatformWebView): Removed release.
(WTR::PlatformWebView::~PlatformWebView): Removed release.
(WTR::PlatformWebView::addChromeInputField): Removed release.
(WTR::PlatformWebView::removeChromeInputField): Removed release.

WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::initializeInjectedBundlePath): Use bridge cast.
(WTR::TestController::initializeTestPluginDirectory): Ditto.

WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::accessibilitySpeakSelectionContent const):
Use bridge cast.
(WTR::UIScriptController::enterText): Ditto.
(WTR::UIScriptController::selectFormPopoverTitle const): Ditto.
(WTR::UIScriptController::textContentType const): Ditto.
(WTR::UIScriptController::formInputLabel const): Ditto.
(WTR::UIScriptController::scrollingTreeAsText const): Ditto.

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::~PlatformWebView): Removed release.
(WTR::PlatformWebView::addChromeInputField): Removed release.

WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::allowedFontFamilySet): Removed retain.
(WTR::systemHiddenFontFamilySet): Removed retain.

WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:

(-[WebKitTestRunnerDraggingInfo draggingDestinationWindow]): Removed retain.
(-[WebKitTestRunnerDraggingInfo dealloc]): Deleted.

WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:

(+[WebKitTestRunnerPasteboard _pasteboardWithName:]): Removed release.
(+[WebKitTestRunnerPasteboard releaseLocalPasteboards]): Removed release.
Method name is still OK because setting localPasteboards to nil will
still release them.
(+[NSPasteboard superAlloc]): Added. Helper so that LocalPasteboard can
bypass +[NSPasteboard alloc].
(+[NSPasteboard superAllocWithZone:]): Ditto.
(+[LocalPasteboard alloc]): Call superAlloc instead of class_createInstance.
This is a different way to achieve the "bypass NSPasteboard" behavior we need.
(+[LocalPasteboard allocWithZone:]): Added. Calls superAllocWithZone: for the
same reason as above. Needed because, at least at this time, +[NSObject alloc]
calls +allocWithZone: so we have to override both.
(-[LocalPasteboard dealloc]): Deleted.
(-[LocalPasteboard addTypes:owner:]): Removed release.

WebKitTestRunner/mac/WebKitTestRunnerWindow.mm:

(-[WebKitTestRunnerWindow dealloc]): Removed [super dealloc].

WebKitTestRunner/mac/main.mm:

(disableAppNapInUIProcess): Removed retain.

1:51 PM Changeset in webkit [235831] by yusukesuzuki@slowstart.org

8 edits in trunk

[JSC] Remove loadModule function in jsc.cpp
https://bugs.webkit.org/show_bug.cgi?id=184808

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2018-09-08
Reviewed by Darin Adler.

JSTests:

Use import expression instead.

modules/different-view.js:

(from.string_appeared_here.shouldThrow): Deleted.

modules/fallback-ambiguous.js:

(from.string_appeared_here.shouldThrow): Deleted.

modules/import-error.js:

(from.string_appeared_here.shouldThrow): Deleted.
(shouldThrow): Deleted.

modules/indirect-export-error.js:

(from.string_appeared_here.shouldThrow): Deleted.
(shouldThrow): Deleted.

modules/namespace-error.js:

(from.string_appeared_here.shouldThrow): Deleted.

Source/JavaScriptCore:

Since we have import, we do not need to have loadModule function for testing purpose.

jsc.cpp:

(GlobalObject::finishCreation):
(functionLoadModule): Deleted.

1:19 PM Changeset in webkit [235830] by Simon Fraser

5 edits in trunk/Source/WebCore

Clean up code related to Document node removal
https://bugs.webkit.org/show_bug.cgi?id=189452

Reviewed by Wenson Hsieh.

Replace the "amongChildrenOnly" boolean argument with an enum for clarity.

Rename the remove*OfSubtree functions, because that naming is very unclear.
Instead, use adjust*OnNodeRemoval which better describes what the code does.

dom/Document.cpp:

(WebCore::isNodeInSubtree):
(WebCore::Document::adjustFocusedNodeOnNodeRemoval):
(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):
(WebCore::Document::adjustFocusNavigationNodeOnNodeRemoval):
(WebCore::Document::adjustFullScreenElementOnNodeRemoval):
(WebCore::Document::removeFocusedNodeOfSubtree): Deleted.
(WebCore::Document::removeFocusNavigationNodeOfSubtree): Deleted.
(WebCore::Document::removeFullScreenElementOfSubtree): Deleted.

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::removeShadowRoot):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

12:25 PM Changeset in webkit [235829] by yusukesuzuki@slowstart.org

2 edits in trunk/Source/WebCore

[CSSJIT] Use lshiftPtr instead of mul32
https://bugs.webkit.org/show_bug.cgi?id=189451

Reviewed by Sam Weinig.

Use value << 4 instead of value * 16. In 64bit environment, sizeof(Style::Relation) is 16,
so that we can use value << 4 in CSS JIT.

No behavior change.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateAddStyleRelation):

10:59 AM Changeset in webkit [235828] by timothy_horton@apple.com

38 edits in trunk/Source/WebKit

Unify most of the WebKit Objective-C API sources
https://bugs.webkit.org/show_bug.cgi?id=189447

Reviewed by Andy Estes.

Unify and fix errors.

Shared/API/Cocoa/_WKFrameHandle.mm:
Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:
SourcesCocoa.txt:
UIProcess/API/Cocoa/APIContentRuleListStoreCocoa.mm:
UIProcess/API/Cocoa/WKBackForwardList.mm:
UIProcess/API/Cocoa/WKBackForwardListItem.mm:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:
UIProcess/API/Cocoa/WKBrowsingContextGroup.mm:
UIProcess/API/Cocoa/WKConnection.mm:
UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:
UIProcess/API/Cocoa/WKNavigationData.mm:
UIProcess/API/Cocoa/WKProcessGroup.mm:
UIProcess/API/Cocoa/WKURLSchemeTask.mm:
UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
UIProcess/API/Cocoa/_WKAttachment.mm:
UIProcess/API/Cocoa/_WKGeolocationPosition.mm:
UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:
UIProcess/API/Cocoa/_WKThumbnailView.mm:
UIProcess/API/mac/WKView.mm:
WebKit.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInHitTestResult.mm:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:
WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

Sep 7, 2018:

11:29 PM Changeset in webkit [235827] by mark.lam@apple.com

14 edits
2 adds in trunk

Ensure that handleIntrinsicCall() is only applied on op_call shaped instructions.
https://bugs.webkit.org/show_bug.cgi?id=189317
<rdar://problem/44152198>

Reviewed by Filip Pizlo.

JSTests:

stress/regress-189317.js: Added.

(testGetter):
(testSetter):

Source/JavaScriptCore:

handleIntrinsicCall() is normally used for checking if an op_call is a call to
an intrinsic function, and inlining it if it's a match.

However, getter and setter functions also does calls, and uses handleCall()
to implement the call. handleCall() eventually calls handleIntrinsicCall() to
check for intrinsics. This results in a bug because handleIntrinsicCall()
sometimes relies on the ArrayProfile* of the instruction, and is always assuming
that the instruction is op_call shaped. This turns out to be not true: getters
and setters can get there with op_get_by_val and op_put_by_val instead.

Since the intrinsic functions handled by handleIntrinsicCall() are never
intended to be used as getter / setter functions anyway, we can prevent this
whole class of bugs by having handleIntrinsicCall() fail early if the
instruction is not op_call shaped.

To implement this fix, we did the following:

Introduced the OpcodeShape enum.
Introduced isOpcodeShape<OpcodeShape>() for testing if a instruction of the shape of the specified OpcodeShape.
Introduced arrayProfileFor<OpcodeShape>() for fetching the ArrayProfile* from the instruction given the OpcodeShape.

Using this arrayProfileFor template has the following benefits:

Centralizes the definition of which instructions has an ArrayProfile* operand.
Centralizes the definition of which operand is the ArrayProfile*.
Asserts that the instruction is of the expected shape when retrieving the ArrayProfile*.

Added ArrayProfile::m_typeName and ArrayProfile::s_typeName which are used in ArrayProfile::isValid() as a sanity check that a retrieved ArrayProfile* indeed does point to an ArrayProfile.

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/ArrayProfile.cpp:
bytecode/ArrayProfile.h:

(JSC::ArrayProfile::isValid const):

bytecode/OpcodeInlines.h: Added.

(JSC::isOpcodeShape):
(JSC::arrayProfileFor):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::parseBlock):

jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_has_indexed_property):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_has_indexed_property):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::getByVal):

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

7:17 PM Changeset in webkit [235826] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit

Try to fix the build

Shared/mac/SandboxExtensionMac.mm:

5:41 PM Changeset in webkit [235825] by Fujii Hironori

2 edits in trunk/Source/WebCore

[Win][Clang] exceptionShouldTerminateProgram of StructuredExceptionHandlerSuppressor.cpp should take DWORD
https://bugs.webkit.org/show_bug.cgi?id=189402

Reviewed by Alex Christensen.

Clang reports compilation errors like following:

StructuredExceptionHandlerSuppressor.cpp(38,10): error: case value evaluates to 2147483650, which cannot be narrowed to type 'int' [-Wc++11-narrowing]

case EXCEPTION_DATATYPE_MISALIGNMENT:

No new tests (no behavioral change).

platform/win/StructuredExceptionHandlerSuppressor.cpp:

(exceptionShouldTerminateProgram): Changed the type of argument from int to DWORD.

5:37 PM Changeset in webkit [235824] by Fujii Hironori

3 edits in trunk/Tools

[WinCairo][MiniBrowser][WebKit] REGRESSION(r235398): ASSERTION FAILED: !m_client.didReceiveTitleForFrame
https://bugs.webkit.org/show_bug.cgi?id=189336

Reviewed by Alex Christensen.

WKPageSetPageLoaderClient is deprecated. Replaced it with
WKPageSetPageNavigationClient.

MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::WebKitBrowserWindow):
Call WKPageSetPageNavigationClient instead of WKPageSetPageLoaderClient.
(WebKitBrowserWindow::didFinishNavigation):
Copied from didReceiveTitleForFrame. Use WKPageCopyTitle to get the title.
(WebKitBrowserWindow::didCommitNavigation):
Copied from didCommitLoadForFrame. Use WKPageCopyCommittedURL to get the URL.
(WebKitBrowserWindow::didReceiveTitleForFrame): Deleted.
(WebKitBrowserWindow::didCommitLoadForFrame): Deleted.

MiniBrowser/win/WebKitBrowserWindow.h: Renamed the class methods.

5:36 PM Changeset in webkit [235823] by timothy_horton@apple.com

14 edits in trunk/Source/WebKit

Unify most of the WebKit C API sources
https://bugs.webkit.org/show_bug.cgi?id=189400

Reviewed by Alex Christensen.

Unify and fix errors (mostly API:String vs. WTF::String mismatches).

Shared/APIWebArchiveResource.h:
Sources.txt:
SourcesCocoa.txt:
UIProcess/API/APIContentRuleListStore.cpp:

(API::constructedPathPrefix):
(API::constructedPathFilter):
(API::constructedPath):
(API::encodeContentRuleListMetaData):
(API::decodeContentRuleListMetaData):
(API::openAndMapContentRuleList):
(API::writeDataToFile):
(API::compiledToFile):
(API::createExtension):
(API::ContentRuleListStore::lookupContentRuleList):
(API::ContentRuleListStore::getAvailableContentRuleListIdentifiers):
(API::ContentRuleListStore::compileContentRuleList):
(API::ContentRuleListStore::getContentRuleListSource):

UIProcess/API/APINavigation.cpp:

(API::Navigation::loggingString const):

UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::defaultMediaCacheDirectory):
(API::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):

UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultApplicationCacheDirectory):
(API::WebsiteDataStore::defaultCacheStorageDirectory):
(API::WebsiteDataStore::defaultNetworkCacheDirectory):
(API::WebsiteDataStore::defaultMediaCacheDirectory):
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(API::WebsiteDataStore::defaultLocalStorageDirectory):
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(API::WebsiteDataStore::defaultJavaScriptConfigurationDirectory):
(API::WebsiteDataStore::legacyDefaultApplicationCacheDirectory):
(API::WebsiteDataStore::legacyDefaultNetworkCacheDirectory):
(API::WebsiteDataStore::legacyDefaultWebSQLDatabaseDirectory):
(API::WebsiteDataStore::legacyDefaultIndexedDBDatabaseDirectory):
(API::WebsiteDataStore::legacyDefaultLocalStorageDirectory):
(API::WebsiteDataStore::legacyDefaultMediaCacheDirectory):
(API::WebsiteDataStore::legacyDefaultMediaKeysStorageDirectory):
(API::WebsiteDataStore::legacyDefaultJavaScriptConfigurationDirectory):
(API::WebsiteDataStore::tempDirectoryFileSystemRepresentation):
(API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):

UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:

(API::WebsiteDataStore::defaultApplicationCacheDirectory):
(API::WebsiteDataStore::defaultNetworkCacheDirectory):
(API::WebsiteDataStore::defaultCacheStorageDirectory):
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):
(API::WebsiteDataStore::defaultLocalStorageDirectory):
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):
(API::WebsiteDataStore::cacheDirectoryFileSystemRepresentation):
(API::WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation):
(API::WebsiteDataStore::legacyDefaultApplicationCacheDirectory):
(API::WebsiteDataStore::legacyDefaultNetworkCacheDirectory):
(API::WebsiteDataStore::legacyDefaultWebSQLDatabaseDirectory):
(API::WebsiteDataStore::legacyDefaultIndexedDBDatabaseDirectory):
(API::WebsiteDataStore::legacyDefaultLocalStorageDirectory):
(API::WebsiteDataStore::legacyDefaultMediaCacheDirectory):
(API::WebsiteDataStore::legacyDefaultMediaKeysStorageDirectory):
(API::WebsiteDataStore::legacyDefaultJavaScriptConfigurationDirectory):

WebKit.xcodeproj/project.pbxproj:

5:36 PM Changeset in webkit [235822] by Basuke Suzuki

1 edit
5 adds in trunk/LayoutTests

[LayoutTests] Add digest access authentication test.
https://bugs.webkit.org/show_bug.cgi?id=189286

Reviewed by Alex Christensen.

Add digest auth tests

http/tests/resources/digest-auth/authorize.php: Added.
http/tests/resources/digest-auth/digest.php: Added.
http/tests/xmlhttprequest/digest-auth-expected.txt: Added.
http/tests/xmlhttprequest/digest-auth.html: Added.

5:32 PM Changeset in webkit [235821] by Basuke Suzuki

5 edits
3 adds in trunk

[Curl] Stop sending request with credential if no authorization requested.
https://bugs.webkit.org/show_bug.cgi?id=189057

Reviewed by Alex Christensen.

Source/WebCore:

When 401 response returns without 'www-authenticate' header, suppress another request with credential.

Test: http/tests/xmlhttprequest/unauthorized-without-authenticate-header.html

platform/network/curl/CurlResourceHandleDelegate.cpp:

(WebCore::CurlResourceHandleDelegate::curlDidReceiveResponse):

Source/WebKit:

When 401 response returns without 'www-authenticate' header, suppress another request with credential.
Same fix for proxy authentication.

NetworkProcess/curl/NetworkDataTaskCurl.cpp:

(WebKit::NetworkDataTaskCurl::curlDidReceiveResponse):

LayoutTests:

http/tests/xmlhttprequest/resources/no-authenticate-header-401.php: Added.
http/tests/xmlhttprequest/unauthorized-without-authenticate-header-expected.txt: Added.
http/tests/xmlhttprequest/unauthorized-without-authenticate-header.html: Added.

4:47 PM Changeset in webkit [235820] by Fujii Hironori

2 edits in trunk/Source/WebCore

[Win][Clang] duplicated variable name advance in UniscribeController::shapeAndPlaceItem
https://bugs.webkit.org/show_bug.cgi?id=189399

Reviewed by Myles C. Maxfield.

Clang reports the following compilation error:

UniscribeController.cpp(372,56): error: invalid operands to binary expression ('float' and 'WebCore::GlyphBufferAdvance' (aka 'WebCore::FloatSize'))

GlyphBufferAdvance advance(-origin.width() + advance, -origin.height());

~ ^~

No new tests (No behavior change).

platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::shapeAndPlaceItem): Replaced the second variable named advance with glyphAdvance.

4:13 PM Changeset in webkit [235819] by youenn@apple.com

5 edits
1 copy
2 adds in trunk/LayoutTests

Tests checking document GC in case of ActiveDOMObjects are flaky
https://bugs.webkit.org/show_bug.cgi?id=189413

Reviewed by Eric Carlson.

Instead of calling parent.done() use postMessage.
The assumption is that GC might not always collect 'parent' as it is in the call stack.
With postMessage, no flakiness is observed locally.
Added a related MediaDevices test that was missing from r235438.

http/tests/IndexedDB/collect-IDB-objects.https.html:
http/tests/IndexedDB/resources/myidbframe.htm:
http/tests/media/clearkey/collect-webkit-media-session.html:
http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm:
http/tests/media/media-stream/collect-media-devices.https-expected.txt: Added.
http/tests/media/media-stream/collect-media-devices.https.html: Added.
http/tests/media/media-stream/resources/mymediadevicesframe.htm: Added.

4:08 PM Changeset in webkit [235818] by dbates@webkit.org

3 edits
2 adds in trunk

[iOS] uiController.typeCharacterUsingHardwareKeyboard("`", ...) dispatches DOM key events for ~
https://bugs.webkit.org/show_bug.cgi?id=189325

Reviewed by Wenson Hsieh.

Tools:

Fixes an issue where the test infrastructure would incorrectly synthesized a shift key press followed
by a key press (i.e. type '~') when instructed to simulate typing a grave accent (). Typing a
grave accent does not require holding the shift key.

WebKitTestRunner/ios/HIDEventGenerator.mm:

(shouldWrapWithShiftKeyEventForCharacter):

LayoutTests:

Add a test to ensure that we dispatch the correct DOM key events when using uiController.typeCharacterUsingHardwareKeyboard("`")
(by way of UIHelper.typeCharacter()).

fast/events/ios/keypress-grave-accent-expected.txt: Added.
fast/events/ios/keypress-grave-accent.html: Added.

4:07 PM Changeset in webkit [235817] by youenn@apple.com

10 edits
1 delete in trunk/Source/WebCore

RTCRtpReceiver::track should return a MediaStreamTrack reference
https://bugs.webkit.org/show_bug.cgi?id=189420

Reviewed by Eric Carlson.

As per spec, a receiver always has a track.
Remove unneeded RTCRtpSenderReceiverBase and make RTCRtpReceiver have a Ref<MediaStreamTrack>.
RTCRtpSender keeps having a RefPtr<MediaStreamTrack>.
Update call sites accordingly.
No change of behavior.

Modules/mediastream/RTCRtpReceiver.cpp:

(WebCore::RTCRtpReceiver::RTCRtpReceiver):
(WebCore::RTCRtpReceiver::stop):

Modules/mediastream/RTCRtpReceiver.h:

(WebCore::RTCRtpReceiver::track):

Modules/mediastream/RTCRtpReceiver.idl:
Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::RTCRtpSender):

Modules/mediastream/RTCRtpSender.h:

(WebCore::RTCRtpSender::track):

Modules/mediastream/RTCRtpSender.idl:
Modules/mediastream/RTCRtpSenderReceiverBase.h: Removed.
Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::videoReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::audioReceiver):

WebCore.xcodeproj/project.pbxproj:

4:00 PM Changeset in webkit [235816] by dbates@webkit.org

3 edits in trunk/Source/WebCore

Cleanup: Remove extraneous "using namespace" and scope WebCore::LogThreading
https://bugs.webkit.org/show_bug.cgi?id=189381

Reviewed by Simon Fraser.

platform/ios/wak/WKGraphics.mm:
platform/ios/wak/WebCoreThread.mm:

(WebThreadEnable):

3:56 PM Changeset in webkit [235815] by Kocsen Chung

1 copy in tags/Safari-606.2.10

Tag Safari-606.2.10.

3:53 PM Changeset in webkit [235814] by Wenson Hsieh

4 edits in trunk/Source/WebCore

Clean up FontAttributeChanges.cpp after r235748
https://bugs.webkit.org/show_bug.cgi?id=189394

Reviewed by Tim Horton.

Sources.txt: Move FontAttributeChanges.cpp into unified sources.
WebCore.xcodeproj/project.pbxproj:
editing/FontAttributeChanges.cpp: Replace #imports with #includes.

3:50 PM Changeset in webkit [235813] by Basuke Suzuki

3 edits
5 adds in trunk

[Curl][WebKitLegacy] Stop sending credential embedded in the url via XHR.
https://bugs.webkit.org/show_bug.cgi?id=189198

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Because sync XHR of Curl port uses passed request directly, the credential information in
url is not removed. Use ResourceHandleInternal's firstRequest because those are
already takne out.

Test: http/tests/xmlhttprequest/url-with-credentials.html

platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

LayoutTests:

http/tests/xmlhttprequest/resources/url-with-credentials/authenticate.php: Added.
http/tests/xmlhttprequest/resources/url-with-credentials/authorize.php: Added.
http/tests/xmlhttprequest/url-with-credentials-expected.txt: Added.
http/tests/xmlhttprequest/url-with-credentials.html: Added.

3:40 PM Changeset in webkit [235812] by Kocsen Chung

7 edits in branches/safari-606.1.36.10-branch/Source

Versioning.

3:36 PM Changeset in webkit [235811] by Kocsen Chung

7 edits in branches/safari-606-branch/Source

Versioning.

3:28 PM Changeset in webkit [235810] by youenn@apple.com

4 edits in trunk/Source/WebCore

RealtimeOutgoingVideoSourceCocoa should use VTImageRotationSession to rotate CVPixelBuffers
https://bugs.webkit.org/show_bug.cgi?id=189427

Reviewed by Eric Carlson.

Previously, we were relying on libwebrtc utils to do the rotation.
This is inefficient compared to VTImageRotateSession and also induces additional memory cost
since libwebrtc is rotating using its own buffers and the encoder will convert this buffer back to a CVPixelBuffer.

Instead use VTImageRotationSession when rotation must be done at sending side.
Covered by webrtc/video-rotation.html.

platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.cpp:

(WebCore::RealtimeOutgoingVideoSourceCocoa::sampleBufferUpdated):

platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.h:
platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:

(WebCore::computeRotatedWidthAndHeight):
(WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):

2:57 PM Changeset in webkit [235809] by youenn@apple.com

53 edits
1 copy
1 add in trunk

Add support for unified plan transceivers
https://bugs.webkit.org/show_bug.cgi?id=189390

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/RTCDTMFSender-insertDTMF.https-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-addTrack.https-expected.txt:

Regression comes from the fact that the sender was never used but transceiver direction is sendrecv.
This might need further clarification in the spec or implementation of libwebrtc.

web-platform-tests/webrtc/RTCPeerConnection-addTransceiver-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-removeTrack.https-expected.txt:
web-platform-tests/webrtc/RTCPeerConnection-setDescription-transceiver-expected.txt:
web-platform-tests/webrtc/RTCRtpTransceiver-setDirection-expected.txt:

Source/ThirdParty/libwebrtc:

Expose more symbols.

Configurations/libwebrtc.iOS.exp:
Configurations/libwebrtc.iOSsim.exp:
Configurations/libwebrtc.mac.exp:

Source/WebCore:

Keep previous transceiver behavior when unified plan flag is off.
Otherwise, use the libwebrtc transceiver API to create and use unified plan transceivers.
Fuel the implementation of transceivers through a dedicated backend.

Update transceiver IDL and make some smaller fixes at the same time:

Make sure remote sources have a proper name as per https://w3c.github.io/webrtc-pc/#dfn-create-an-rtcrtpreceiver.
Add support for transceiver.currentDirection.

Our mock peer connections are only supporting plan B APIs at the moment.
We therefore mandate plan B when using such mocks until we can upgrade mocks to support unified plan APIs.

Covered by modified and rebased tests.

Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::addTrack):

Modules/mediastream/PeerConnectionBackend.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::addTransceiver):

Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::RTCRtpSender):

Modules/mediastream/RTCRtpTransceiver.cpp:

(WebCore::RTCRtpTransceiver::mid const):
(WebCore::RTCRtpTransceiver::currentDirection const):

Modules/mediastream/RTCRtpTransceiver.h:

(WebCore::RTCRtpTransceiver::backend):

Modules/mediastream/RTCRtpTransceiver.idl:
Modules/mediastream/RTCRtpTransceiverBackend.h:
Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTrack):
(WebCore::LibWebRTCMediaEndpoint::newTransceiver):
(WebCore::LibWebRTCMediaEndpoint::addTransceiver):
(WebCore::LibWebRTCMediaEndpoint::transceiverBackendFromSender):
(WebCore::LibWebRTCMediaEndpoint::OnAddTrack):
(WebCore::LibWebRTCMediaEndpoint::OnTrack):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::createReceiverForSource):
(WebCore::LibWebRTCPeerConnectionBackend::createReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::videoReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::audioReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::addTrack):
(WebCore::LibWebRTCPeerConnectionBackend::addTransceiver):
(WebCore::backendFromRTPTransceiver):
(WebCore::LibWebRTCPeerConnectionBackend::existingTransceiver):
(WebCore::LibWebRTCPeerConnectionBackend::newTransceiver):

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:
Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.cpp: Added.

(WebCore::LibWebRTCRtpTransceiverBackend::createReceiverBackend):
(WebCore::LibWebRTCRtpTransceiverBackend::createSenderBackend):
(WebCore::LibWebRTCRtpTransceiverBackend::direction const):
(WebCore::LibWebRTCRtpTransceiverBackend::currentDirection const):
(WebCore::LibWebRTCRtpTransceiverBackend::setDirection):
(WebCore::LibWebRTCRtpTransceiverBackend::mid):
(WebCore::LibWebRTCRtpTransceiverBackend::stop):

Modules/mediastream/libwebrtc/LibWebRTCRtpTransceiverBackend.h: Added.
Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::toRTCRtpTransceiverDirection):
(WebCore::fromRTCRtpTransceiverDirection):
(WebCore::fromRtpTransceiverInit):

Modules/mediastream/libwebrtc/LibWebRTCUtils.h:
WebCore.xcodeproj/project.pbxproj:
platform/mediastream/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::RealtimeIncomingAudioSource):

platform/mediastream/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::RealtimeIncomingVideoSource):

platform/mediastream/RealtimeMediaSource.h:
testing/Internals.cpp:

(WebCore::Internals::useMockRTCPeerConnectionFactory):

LayoutTests:

Update tests using mock to enforce plan B for now until unified plan mocks are supported.

fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt:
fast/mediastream/RTCPeerConnection-icecandidate-event.html:
fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event.html:
fast/mediastream/RTCPeerConnection-inspect-answer.html:
fast/mediastream/RTCPeerConnection-inspect-offer.html:
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html:
fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:
fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:
fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html:
fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html:
webrtc/calling-peerconnection-once-closed.html:

Once closed, addTransceiver is expected to throw.

webrtc/libwebrtc/release-while-creating-offer.html:
webrtc/libwebrtc/release-while-getting-stats.html:
webrtc/libwebrtc/release-while-setting-local-description.html:
webrtc/video-getParameters.html: sender and receiver parameters are no longer the same.

Testing them individually.

webrtc/video-with-receiver.html:

Test is working only with legacy mode.

2:43 PM Changeset in webkit [235808] by commit-queue@webkit.org

5 edits in trunk

XMLHttpRequest: open() does not throw a SYNTAX_ERR exception if method is empty or url cannot be resolved
https://bugs.webkit.org/show_bug.cgi?id=46008

Patch by Rob Buis <rbuis@igalia.com> on 2018-09-07
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

web-platform-tests/xhr/open-url-bogus-expected.txt:
web-platform-tests/xhr/open-url-multi-window-6-expected.txt:

Source/WebCore:

Check if passed URL is valid as specified here [1].

Test: web-platform-tests/xhr/open-url-bogus.htm

[1] https://xhr.spec.whatwg.org/#the-open()-method Step 7

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):

2:29 PM Changeset in webkit [235807] by Brent Fulgham

3 edits in trunk/Source/WebKit

Allow WebContent access to AVCSupported IOKit property in sandbox
https://bugs.webkit.org/show_bug.cgi?id=189429
<rdar://problem/43612229>

Reviewed by Eric Carlson.

Allow access to the IOKit properties AVCSupported and HEVCSupported to allow the WebContent process
to check for efficient video codecs.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
WebProcess/com.apple.WebProcess.sb.in:

2:12 PM Changeset in webkit [235806] by commit-queue@webkit.org

41 edits
1 add
1 delete in trunk

[CSSOM View] Handle the scrollingElement in Element::scroll(Left/Top/Width/Height/To)
https://bugs.webkit.org/show_bug.cgi?id=182230

Patch by Frederic Wang <fwang@igalia.com> on 2018-09-07
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

This commit updates expectations for some WPT tests so that they have only PASS results.
Note that css/cssom-view/scrollingElement-quirks-dynamic-*.html still fail for now (bug 182292).

web-platform-tests/css/cssom-view/HTMLBody-ScrollArea_quirksmode-expected.txt:
web-platform-tests/css/cssom-view/scrolling-quirks-vs-nonquirks-expected.txt:
web-platform-tests/css/cssom-view/scrollingElement-expected.txt: Added.

Source/WebCore:

This commit moves the special logic for "scrolling element" body from the
HtmlBodyElement::scroll(Left/Top/Width/Height/To) functions to the Element class. The code
is executed when the element is the scrolling element which includes the case of body
in Quirks mode and of documentElement in standard mode. This makes the behavior closer to
the CSSOM View spec (bug 5991) while not deviating too much from the current implementation.
Finally, CSSOMViewScrollingAPI is now enabled for running tests and some adjustments are made
to existing tests. Further improvements will be performed in dependencies of bug 5991.

No new tests, already covered by existing tests.

dom/Document.cpp: Split scrollingElement into two functions so that one can be called

internally without updating the layout.
(WebCore::Document::scrollingElement):
(WebCore::Document::scrollingElementForAPI):

dom/Document.h: Ditto.
dom/Document.idl: Use the version updating the layout for API calls.
dom/Element.cpp: Add include to call DOMWindow::ScrollTo

(WebCore::Element::scrollTo): Moved some logic from HtmlBodyElement to handle the case of
the scrolling element. Also skip special handling of documentElement() when
CSSOMViewScrollingAPI is disabled.
(WebCore::adjustContentsScrollPositionOrSizeForZoom): Moved some logic from HtmlBodyElement
to handle the case of the scrolling element. Also add a FIXME for improving these kinds of
helper functions. Renamed to make more explicit the semantic of the value argument.
(WebCore::Element::scrollLeft): Moved some logic from HtmlBodyElement to handle the case of
the scrolling element. Use the new documentFrameWithNonNullView() helper function.
(WebCore::Element::scrollTop): Ditto.
(WebCore::Element::setScrollLeft): Ditto
(WebCore::Element::setScrollTop): Ditto.
(WebCore::Element::scrollWidth): Ditto.
(WebCore::Element::scrollHeight): Ditto.

dom/Element.h:

(WebCore::Document::documentFrameWithNonNullView): New helper function to retrieve the
frame and ensure a view is available.

html/HTMLBodyElement.cpp: Remove code that is now in Element.
html/HTMLBodyElement.h: Ditto.

Source/WebKit:

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:

(webkit_dom_document_get_scrolling_element): Use the new name.

Source/WebKitLegacy/mac:

DOM/DOMDocument.mm:

(-[DOMDocument scrollingElement]): Use the new name.

Tools:

This patch enables CSSOMViewScrollingAPI during test execution.

DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

LayoutTests:

This commit updates some tests to work when CSSOMViewScrollingAPI is enabled.

TestExpectations: Enable web-platform-tests/cssom-view/scrollingElement.html.
fast/dom/Document/scrollingElement-quirks-mode.html: Do not enable explictly enable

CSSOMViewScrollingAPI.

fast/dom/Document/scrollingElement-standards-mode.html: Ditto.
fast/dom/Element/body-scrollLeft-expected.txt: Updated to follow the CSSOMView spec.
fast/dom/Element/body-scrollLeft.html: Ditto.
fast/dom/Element/body-scrollTop-expected.txt: Ditto.
fast/dom/Element/body-scrollTop.html: Ditto.
fast/dom/Element/documentElement-scrollLeft-expected.txt: Ditto.
fast/dom/Element/documentElement-scrollLeft.html: Ditto.
fast/dom/Element/documentElement-scrollTop-expected.txt: Ditto.
fast/dom/Element/documentElement-scrollTop.html: Ditto.
fast/dom/Element/scrollLeft-expected.txt: Ditto.
fast/dom/Element/scrollLeft.html: Ditto.
fast/dom/Element/scrollTop-expected.txt: Ditto.
fast/dom/Element/scrollTop.html: Ditto.
fast/dom/Element/scrolling-funtions-on-body-expected.txt: Ditto.
fast/dom/Element/scrolling-funtions-on-body.html: Ditto.
platform/ios/TestExpectations: Add expectation for one WPT test that was already failing

on iOS.

platform/ios/ios/fast/coordinates/page-offsets-expected.txt: Use documentElement instead

of body for this test when running in standard mode.

platform/ios/ios/fast/coordinates/resources/helpers.js: Ditto.

(verifyScrollOffsets):

tiled-drawing/scrolling/fast-scroll-div-latched-mainframe.html: Use

document.scrollingElement instead of document.body to access viewport scroll offset.

1:58 PM Changeset in webkit [235805] by Simon Fraser

3 edits in trunk/Tools

resultsjsonparser needs to handle leak failures
https://bugs.webkit.org/show_bug.cgi?id=189430

Reviewed by Alexey Proskuryakov.

Teach resultsjsonparser how to handle LEAK failures, building a FailureDocumentLeak
with a list of the leaked URLs.

Scripts/webkitpy/common/net/resultsjsonparser.py:

(JSONTestResult._failure_types_from_actual_result):

Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:

(ParsedJSONResultsTest):
(test_basic):

1:44 PM Changeset in webkit [235804] by don.olmstead@sony.com

2 edits in trunk/Source/WebCore

[AX] Fix compile error in AXObjectCache constructor when !HAVE(ACCESSIBILITY)
https://bugs.webkit.org/show_bug.cgi?id=189423
<rdar://problem/44231775>

Reviewed by Yusuke Suzuki.

No new tests. Compilation fix.

accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::AXObjectCache):

1:08 PM Changeset in webkit [235803] by Kocsen Chung

2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r235506. rdar://problem/44169670

[macOS] Whitelist Network process features for VPN
https://bugs.webkit.org/show_bug.cgi?id=189023
<rdar://problem/43310000>

Reviewed by Eric Carlson.

CFNetwork needs access to some VPN preference files to configure networking, and
need to be allowed to communicate with the VPN process from the Network Process
sandbox.

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:08 PM Changeset in webkit [235802] by Kocsen Chung

10 edits in branches/safari-606-branch

Cherry-pick r235754. rdar://problem/44210305

[Apple Pay] Rename the -apple-pay-button-type value "checkout" to "check-out"
https://bugs.webkit.org/show_bug.cgi?id=189366
<rdar://problem/44193218>

Reviewed by Sam Weinig.

Source/WebCore:

The button title is "Check out with Apple Pay", so we should use the verb phrase "check out"
rather than the noun "checkout" for naming this value.

Updated http/tests/ssl/applepay/ApplePayButtonV4.html.

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ApplePayButtonType const):
css/CSSValueKeywords.in:
css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
rendering/RenderThemeCocoa.mm: (WebCore::toPKPaymentButtonType):
rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

http/tests/ssl/applepay/ApplePayButtonV4.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:08 PM Changeset in webkit [235801] by Kocsen Chung

2 edits in branches/safari-606-branch/Source/WebInspectorUI

Cherry-pick r235406. rdar://problem/44210305

Teach Web Inspector how to complete keywords for -apple-pay-button-style and -apple-pay-button-type
https://bugs.webkit.org/show_bug.cgi?id=189001

Reviewed by Devin Rousso.

UserInterface/Models/CSSKeywordCompletions.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:08 PM Changeset in webkit [235800] by Kocsen Chung

15 edits
2 copies
1 add in branches/safari-606-branch

Cherry-pick r235349. rdar://problem/44209834

[Apple Pay] Introduce new values for -apple-pay-button-type
https://bugs.webkit.org/show_bug.cgi?id=188949
<rdar://problem/39992228>

Reviewed by Anders Carlsson.

Source/WebCore:

Added "in-store", "checkout", "book", and "subscribe" keywords for -apple-pay-button-type,
and mapped those values to their equivalent PKPaymentButtonTypes.

Tests: http/tests/ssl/applepay/ApplePayButton.html

http/tests/ssl/applepay/ApplePayButtonV4.html

css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator ApplePayButtonType const):
css/CSSValueKeywords.in:
css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
rendering/RenderThemeCocoa.mm: (WebCore::toPKPaymentButtonType):
rendering/style/RenderStyleConstants.h:

Source/WebCore/PAL:

pal/spi/cocoa/PassKitSPI.h:

LayoutTests:

http/tests/ssl/applepay/ApplePayButton.html: Added.
http/tests/ssl/applepay/ApplePayButtonV4.html: Added.
platform/mac-highsierra/http/tests/ssl/applepay/ApplePayButton-expected.png:
platform/mac-highsierra/http/tests/ssl/applepay/ApplePayButton-expected.txt:
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.png: Added.
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.txt: Added.
platform/mac/http/tests/ssl/applepay/ApplePayButtonV4-expected.png: Added.
platform/mac/http/tests/ssl/applepay/ApplePayButtonV4-expected.txt: Added.
platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:08 PM Changeset in webkit [235799] by Kocsen Chung

1 edit
9 adds in branches/safari-606-branch/LayoutTests

Cherry-pick r235341. rdar://problem/44209834

[Apple Pay] Add a test for rendering Apple Pay buttons
https://bugs.webkit.org/show_bug.cgi?id=188947

Reviewed by Sam Weinig.

http/tests/ssl/applepay/ApplePayButton.html: Added.
platform/mac-sierra/http/tests/ssl/applepay/ApplePayButton-expected.png: Added.
platform/mac-sierra/http/tests/ssl/applepay/ApplePayButton-expected.txt: Added.
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.png: Added.
platform/mac/http/tests/ssl/applepay/ApplePayButton-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:08 PM Changeset in webkit [235798] by Kocsen Chung

11 edits
2 copies
2 moves in branches/safari-606-branch

Cherry-pick r235569. rdar://problem/44169479

Storage Access API: Maintain access through same-site navigations
https://bugs.webkit.org/show_bug.cgi?id=188564
<rdar://problem/43445160>

Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html

http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html

dom/Document.h:

Removed unused member variable m_hasFrameSpecificStorageAccess.

loader/DocumentLoader.cpp: (WebCore::DocumentLoader::willSendRequest):
loader/FrameLoaderClient.h:

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchWillChangeDocument):

Now takes the current URL and the new URL as parameters
and only clears out storage access if the navigation is
cross-site, i.e. with differing eTLD+1s.

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

LayoutTests:

http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-and-access-from-right-frame-expected.txt:
http/tests/storageAccess/request-and-grant-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-user-interaction-and-access-from-right-frame.html:

Added both a same-site and a cross-site navigation to the sub frame to test maintained and cleared access.

http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access-expected.txt: Copied from LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-should-not-have-access-expected.txt.
http/tests/storageAccess/request-and-grant-access-then-navigate-cross-site-should-not-have-access.html: Copied from LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-should-not-have-access.html.
http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access-expected.txt: Renamed from LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-should-not-have-access-expected.txt.
http/tests/storageAccess/request-and-grant-access-then-navigate-same-site-should-have-access.html: Renamed from LayoutTests/http/tests/storageAccess/request-and-grant-access-then-navigate-should-not-have-access.html.
http/tests/storageAccess/resources/get-cookies.php:

Support for the new test scenarios.

http/tests/storageAccess/resources/self-navigating-frame-after-granted-access.html:

Support for the new test scenarios.

platform/mac-wk2/TestExpectations:

Marked the new and the renamed tests as [ Pass ].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:07 PM Changeset in webkit [235797] by Kocsen Chung

11 edits in branches/safari-606-branch

Cherry-pick r235318. rdar://problem/44209848

[Apple Pay] Allow $0 totals
https://bugs.webkit.org/show_bug.cgi?id=185150
<rdar://problem/39212331>

Reviewed by Dan Bernstein.

Source/WebCore:

Relaxed payment request validation to allow $0 totals. This matches PassKit behavior.

Updated test cases in http/tests/ssl/applepay/.

Modules/applepay/PaymentRequestValidator.mm: (WebCore::PaymentRequestValidator::validateTotal):

LayoutTests:

http/tests/ssl/applepay/ApplePaySession-expected.txt:
http/tests/ssl/applepay/ApplePaySession.html:
http/tests/ssl/applepay/ApplePaySessionV3-expected.txt:
http/tests/ssl/applepay/ApplePaySessionV3.html:
http/tests/ssl/applepay/ApplePaySessionV4-expected.txt:
http/tests/ssl/applepay/ApplePaySessionV4.html:
http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
http/tests/ssl/applepay/PaymentRequest.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:07 PM Changeset in webkit [235796] by Kocsen Chung

20 edits
2 adds in branches/safari-606-branch

Cherry-pick r235251. rdar://problem/44209840

[Apple Pay] Introduce Apple Pay JS v4 on iOS 12 and macOS Mojave
https://bugs.webkit.org/show_bug.cgi?id=188829

Reviewed by Tim Horton.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Test: http/tests/ssl/applepay/ApplePaySessionV4.html

Configurations/FeatureDefines.xcconfig:
testing/MockPaymentCoordinator.cpp: (WebCore::MockPaymentCoordinator::supportsVersion):

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Configurations/FeatureDefines.xcconfig:
WebProcess/ApplePay/WebPaymentCoordinator.cpp: (WebKit::WebPaymentCoordinator::supportsVersion):

Source/WebKitLegacy/mac:

Configurations/FeatureDefines.xcconfig:

Tools:

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

http/tests/ssl/applepay/ApplePaySession-expected.txt:
http/tests/ssl/applepay/ApplePaySession.html:
http/tests/ssl/applepay/ApplePaySessionV3-expected.txt:
http/tests/ssl/applepay/ApplePaySessionV3.html:
http/tests/ssl/applepay/ApplePaySessionV4-expected.txt: Added.
http/tests/ssl/applepay/ApplePaySessionV4.html: Added.
platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:07 PM Changeset in webkit [235795] by Kocsen Chung

2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r235209. rdar://problem/44169451

The Storage Access API prompt should show the eTLD+1s, not the full host names
https://bugs.webkit.org/show_bug.cgi?id=188830
<rdar://problem/43380645>

Reviewed by Brent Fulgham.

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::requestStorageAccess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:07 PM Changeset in webkit [235794] by Kocsen Chung

2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r235145. rdar://problem/44169453

Storage Access API: The call to ResourceLoadStatisticsMemoryStore::grantStorageAccessInternal() should send eTLD+1s, not full host names
https://bugs.webkit.org/show_bug.cgi?id=188783
<rdar://problem/43559215>

Reviewed by Alex Christensen.

UIProcess/ResourceLoadStatisticsMemoryStore.cpp: (WebKit::ResourceLoadStatisticsMemoryStore::grantStorageAccess):

Now sends the eTLD+1 for the top frame and sub frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:07 PM Changeset in webkit [235793] by Kocsen Chung

2 edits in branches/safari-606-branch/Source/WebKit

Cherry-pick r234719. rdar://problem/44169456

Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:]
https://bugs.webkit.org/show_bug.cgi?id=188427
<rdar://problem/43064672>

Reviewed by Wenson Hsieh.

Speculatively fix more crashes seen under setSuggestions.

UIProcess/ios/WKContentViewInteraction.mm: (-[WKFormInputSession isValid]): (-[WKFormInputSession setSuggestions:]): (-[WKFormInputSession invalidate]): Belt-and-suspenders fix: use WeakObjCPtr for WKFormInputSession's WKContentView reference.

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
Invalidate the WKFormInputSession before replacing it; we theorize that
there is a path in which we get here without having previously called stopAssistingNode.
Most of the code is OK with this, but this leaves WKFormInputSession
with a raw reference to WKContentView which can later become stale.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:07 PM Changeset in webkit [235792] by Kocsen Chung

7 edits
3 adds in branches/safari-606-branch

Cherry-pick r234504. rdar://problem/44209851

[iOS] Keyboard becomes unresponsive after pressing delete while pressing down on a character key with accents
https://bugs.webkit.org/show_bug.cgi?id=188251
<rdar://problem/37842108>

Reviewed by Tim Horton.

Source/WebKit:

Fixes a bug in key event handling where invoking -handleKeyWebEvent:withCompletionHandler: from within the
completion callback of a previous call to -handleKeyWebEvent:withCompletionHandler: would cause the completion
callback to be cleared out prematurely. In some cases (as described in the title of this bug), UIKit exercises
this codepath and subsequently hangs due to their completion block never getting invoked by WebKit.

Test: KeyboardInputTests.CanHandleKeyEventInCompletionHandler

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView handleKeyWebEvent:withCompletionHandler:]): (-[WKContentView _didHandleKeyEvent:eventWasHandled:]):

Tools:

Adds a new API test to verify that clients (in this case, UIKit) is allowed to invoke
-handleKeyWebEvent:withCompletionHandler: within the completion block of a prior invocation.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm: Added. (TestWebKitAPI::TEST):
TestWebKitAPI/Tests/ios/TestInputDelegate.h: Added.

Pull some logic used to force an input session to start out from an existing API test file
(WKWebViewAutofillTests) and into a separate helper class that is used by both the existing API tests and the
new keyboard input test.

TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm: (-[AutofillTestView initWithFrame:]): (TestWebKitAPI::TEST): (-[TestInputDelegate init]): Deleted. (-[TestInputDelegate _webView:focusShouldStartInputSession:]): Deleted.
TestWebKitAPI/ios/UIKitSPI.h:

Add some UIKit SPI utilized by the new API test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:50 PM Changeset in webkit [235791] by Brent Fulgham

2 edits in trunk/Source/WebKit

[macOS] Remove unused XPC service from sandbox
https://bugs.webkit.org/show_bug.cgi?id=189406
<rdar://problem/43015423>

Reviewed by Youenn Fablet.

The API surface exposed by "com.apple.systemstats.analysis" is no longer used by the
WebContent process. Since there is no need for this sandbox opening, we should remove it.

WebProcess/com.apple.WebProcess.sb.in:

12:44 PM Changeset in webkit [235790] by yusukesuzuki@slowstart.org

21 edits
6 adds in trunk

[DFG] DFG should handle String#toString
https://bugs.webkit.org/show_bug.cgi?id=189151

Reviewed by Saam Barati.

JSTests:

The error message in String#toString and String#valueOf is poor, which will be
handled in a separate bug[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=189357

microbenchmarks/string-object-to-string.js: Added.

(test):

microbenchmarks/string-object-value-of.js: Added.

(test):

stress/string-to-string-error.js: Added.

(shouldThrow):
(test):

stress/string-to-string.js: Added.

(shouldBe):
(test1):
(test2):
(test3):

stress/string-value-of-error.js: Added.

(shouldThrow):
(test):

stress/string-value-of.js: Added.

(shouldBe):
(test1):
(test2):
(test3):

Source/JavaScriptCore:

We handle String#toString and String#valueOf in DFG by introducing StringValueOf node.
In the fixup phase, we attempt to lower StringValueOf to the existing ToString or Identity
nodes. If we fail to lower it, we have StringValueOf(UntypedUse), which may raise an error
if an argument is neither String nor StringObject. The error message in String#toString and
String#valueOf is poor, which will be handled in a separate bug[1].

It improves simple microbenchmarks by 53.4 - 67.6%.

baseline patched

string-object-to-string 21.7308+-3.3147 ^{12.9655+-0.0527} definitely 1.6760x faster
string-object-value-of 20.1122+-0.0691 ^{13.1134+-0.2482} definitely 1.5337x faster

[1]: https://bugs.webkit.org/show_bug.cgi?id=189357

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupStringValueOf):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToToString):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::DFG::SpeculativeJIT::compileToStringOrCallStringConstructor): Deleted.

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructorOrStringValueOf):
(JSC::FTL::DFG::LowerDFGToB3::compileToStringOrCallStringConstructor): Deleted.

11:49 AM Changeset in webkit [235789] by aakash_jain@apple.com

3 edits in trunk/Tools

[ews-build] API tests should output result summary in json
https://bugs.webkit.org/show_bug.cgi?id=189417

Reviewed by Lucas Forschler.

BuildSlaveSupport/ews-build/steps.py:

(RunAPITests): Passed --json-output parameter to run-api-tests.

BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.

11:15 AM Changeset in webkit [235788] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r235784.
https://bugs.webkit.org/show_bug.cgi?id=189421

RunLoopCF does not agree to the fix (Requested by yusukesuzuki
on #webkit).

Reverted changeset:

"[RunLoopGeneric] OneShotTimer should be inactive when fired."
https://bugs.webkit.org/show_bug.cgi?id=189335
https://trac.webkit.org/changeset/235784

10:50 AM Changeset in webkit [235787] by Alan Bujtas

7 edits in trunk/Source/WebCore

[LFC] Replace "computed" value with "used" value to match spec language
https://bugs.webkit.org/show_bug.cgi?id=189414

Reviewed by Antti Koivisto.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):

10:29 AM Changeset in webkit [235786] by yusukesuzuki@slowstart.org

19 edits
1 move in trunk/Source/JavaScriptCore

[WebAssembly] Optimize JS to Wasm call by using pointer of Signature as SignatureIndex
https://bugs.webkit.org/show_bug.cgi?id=189401

Reviewed by Mark Lam.

SignatureInformation is a global repository for Signature to make Signature atomic.
It takes Ref<Signature>&& and generates SignatureIndex. And we get const Signature&
by using this SignatureIndex. However, converting SignatureIndex to const Signature&
always looks up a hash table. This is costly since JS to Wasm calls always use
Signature& to check types of arguments.

Instead of using this hash table, this patch uses a pointer of Signature as SignatureIndex.
This allows us to convert SignatureIndex to Signature by just casting it.

We also optimize SignatureInformation::singleton by making an accessor function inlined.
And we move ProtoCallFrame::init to the header since it's just setting values.

This change significantly optimizes JS to wasm calls (1e7 times) from 600ms to 320ms.

In the future, we can remove SignatureIndex by directly handling Ref<Signature>: adding
deref() of Signature which unregisters itself from SignatureInformation carefully. Or we can
make SignatureIndex uint32_t by introducing a mechanism similar to StructureID.

JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::init):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addCallIndirect):

wasm/WasmBBQPlan.cpp:
wasm/WasmFormat.h:

(JSC::Wasm::WasmToWasmImportableFunction::offsetOfSignatureIndex):

wasm/WasmFunctionParser.h:
wasm/WasmModule.h:
wasm/WasmOMGPlan.cpp:
wasm/WasmSectionParser.cpp:

(JSC::Wasm::SectionParser::parseType):

wasm/WasmSignature.cpp:

(JSC::Wasm::SignatureInformation::adopt):
(JSC::Wasm::SignatureInformation::tryCleanup):
(JSC::Wasm::SignatureInformation::singleton): Deleted.
(JSC::Wasm::SignatureInformation::get): Deleted.

wasm/WasmSignature.h:

(JSC::Wasm::Signature::index const):
(JSC::Wasm::SignatureHash::SignatureHash):
(JSC::Wasm::SignatureHash::hash):
(JSC::Wasm::SignatureHash::isHashTableDeletedValue const):
(JSC::Wasm::SignatureHash::empty): Deleted.
(JSC::Wasm::SignatureHash::deleted): Deleted.

wasm/WasmSignatureInlines.h: Renamed from Source/JavaScriptCore/interpreter/ProtoCallFrame.cpp.

(JSC::Wasm::SignatureInformation::singleton):
(JSC::Wasm::SignatureInformation::get):

wasm/js/JSToWasm.cpp:
wasm/js/JSWebAssemblyModule.h:
wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

wasm/js/WebAssemblyFunction.cpp:
wasm/js/WebAssemblyModuleRecord.cpp:
wasm/js/WebAssemblyWrapperFunction.cpp:

9:57 AM Changeset in webkit [235785] by yusukesuzuki@slowstart.org

5 edits in trunk/Source/JavaScriptCore

[JSC] Put .throwStackOverflow code after the fast path in LLInt doVMEntry
https://bugs.webkit.org/show_bug.cgi?id=189410

Reviewed by Mark Lam.

Put .throwStackOverflow code after the fast path in LLInt doVMEntry to
make doVMEntry code tight.

llint/LLIntThunks.cpp:

(JSC::vmEntryToWasm): Deleted.

llint/LLIntThunks.h:

(JSC::vmEntryToWasm):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

9:27 AM Changeset in webkit [235784] by yoshiaki.jitsukawa@sony.com

4 edits in trunk

[RunLoopGeneric] OneShotTimer should be inactive when fired.
https://bugs.webkit.org/show_bug.cgi?id=189335

Reviewed by Yusuke Suzuki.

Source/WTF:

wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::ScheduledTask::fired):
(WTF::RunLoop::TimerBase::isActive const):

Deactivate one-shot timer before invoking its callback.

Tools:

TestWebKitAPI/Tests/WTF/RunLoop.cpp:

(TestWebKitAPI::TEST):

Add test expectations about timer's active state.

Add a new test to restart a one-shot timer within
its fired callback.

8:51 AM Changeset in webkit [235783] by Alan Bujtas

2 edits in trunk/LayoutTests

[iOS] Unreviewed test gardening.

platform/ios/TestExpectations:

8:38 AM Changeset in webkit [235782] by Brent Fulgham

4 edits in trunk/Source/WebKit

Unreviewed syntax fix after r235781

Don't use hash-quote syntax for these non-regex inputs.

Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.Storage.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

5:28 AM Changeset in webkit [235781] by Brent Fulgham

4 edits in trunk/Source/WebKit

[iOS] Move default mach-lookup deny to after common.sb is imported
https://bugs.webkit.org/show_bug.cgi?id=189385
<rdar://problem/43624193>

Reviewed by Eric Carlson.

Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Move the 'deny mach-lookup' call later in the file.
Resources/SandboxProfiles/ios/com.apple.WebKit.Storage.sb: Ditto.
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Ditto.

Sep 6, 2018:

10:55 PM Changeset in webkit [235780] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

ShadowRoot should have its own node flag
https://bugs.webkit.org/show_bug.cgi?id=189392

Reviewed by Antti Koivisto.

Added IsShadowRootFlag and IsDocumentNodeFlag, and removed IsDocumentFragmentFlag and IsStyledElementFlag.
Also re-ordered flags to group flags used by subclasses below ones directly used by Node in
accordinate with the comment.

No new tests since there should be no behavioral change.

dom/ContainerNode.h:

(WebCore::Node::isTreeScope const): Deleted.

dom/Node.h:

(WebCore::Node::isStyledElement const): Check if this is a HTML, SVG, or MathML element instead.
(WebCore::Node::isDocumentNode const): Simply check IsDocumentNodeFlag.
(WebCore::Node::isTreeScope const): Check if this is a document or a shadow root Instead of comparing
the tree scope to this.
(WebCore::Node::isDocumentFragment const): Check if this is a container node which is neither document,
element, nor shadow root.
(WebCore::Node::isShadowRoot const): Simply check IsShadowRootFlag. This is the change needed to fix
the blockign bug 166748.
(WebCore::Node::flagIsShadowRoot): Added. Will be used in the bug 166748.

10:54 PM Changeset in webkit [235779] by bshafiei@apple.com

7 edits
2 adds in branches/safari-606-branch

Cherry-pick r235721. rdar://problem/44212406

Source/WebCore:
The width of an empty or nullptr TextRun should be zero
https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

If a page has an empty TextRun and attempts to paint it we can crash with a nullptr.

This patch recognizes that an empty TextRun should always produce a zero width, rather than
attempt to compute this value from font data. It also prevents ListBox from attempting to
paint a null string.

Test: fast/text/null-string-textrun.html

platform/graphics/FontCascade.cpp: (WebCore::FontCascade::widthOfTextRange const): An empty TextRun has zero width. (WebCore::FontCascade::width const): Ditto.
platform/graphics/TextRun.h: (WebCore::TextRun::TextRun): ASSERT that the supplied String is non-null. (WebCore::TextRun::setText): Ditto.
rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Don't attempt to paint a null string.

Source/WTF:
The width of an empty or nullptr TextRun should be zero
https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

Most accessors in WTFString.cpp, such as isAllASCII(), hash(), etc., perform a nullptr check
before using m_impl, but is8Bit() does not.

This patch adds a check in the is8Bit() implementation to be consistent with other methods,
and to address a small number of crashes observed in testing.

wtf/text/WTFString.h: (WTF::String::is8Bit const):

LayoutTests:
The width of a nullptr TextRun should be zero
https://bugs.webkit.org/show_bug.cgi?id=189154
<rdar://problem/43685926>

Reviewed by Zalan Bujtas.

fast/text/null-string-textrun-expected.txt: Added.
fast/text/null-string-textrun.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:40 PM Changeset in webkit [235778] by yusukesuzuki@slowstart.org

3 edits in trunk/Source/JavaScriptCore

[WebAssembly] Optimize JS to Wasm call by removing Vector allocation
https://bugs.webkit.org/show_bug.cgi?id=189353

Reviewed by Mark Lam.

JS to Wasm call always allocates Vector for the arguments. This is really costly if the wasm function is small.
This patch adds an initial size parameter to the Vector to avoid allocations for small sized arguments.

runtime/ArgList.h:
wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

9:24 PM Changeset in webkit [235777] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] Inline replaced height calculation should use "used value"
https://bugs.webkit.org/show_bug.cgi?id=189395

Reviewed by Antti Koivisto.

Use the already assigned width value (aka used value) instead of the computed value when computing the inline's height.
see https://www.w3.org/TR/CSS22/cascade.html#value-stages for "used" and "computed" value.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

9:24 PM Changeset in webkit [235776] by yusukesuzuki@slowstart.org

3 edits in trunk/Source/JavaScriptCore

[JSC] Clean up StructureStubClearingWatchpoint
https://bugs.webkit.org/show_bug.cgi?id=189156

Reviewed by Saam Barati.

Cleaning up StructureStubClearingWatchpoint by holding StructureStubClearingWatchpoint in Bag
in WatchpointsOnStructureStubInfo. This removes hacky linked list code for StructureStubClearingWatchpoint.

bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::WatchpointsOnStructureStubInfo::addWatchpoint):
(JSC::StructureStubClearingWatchpoint::~StructureStubClearingWatchpoint): Deleted.
(JSC::StructureStubClearingWatchpoint::push): Deleted.
(JSC::WatchpointsOnStructureStubInfo::~WatchpointsOnStructureStubInfo): Deleted.

bytecode/StructureStubClearingWatchpoint.h:

(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):

8:04 PM Changeset in webkit [235775] by Wenson Hsieh

43 edits in trunk/Source

Refactor WebCore::EditAction to be an 8-bit enum class
https://bugs.webkit.org/show_bug.cgi?id=189383

Reviewed by Dan Bernstein.

Source/WebCore:

Currently, EditAction.h defines an EditAction as an enum. This patch changes EditAction to instead be an 8-bit-
wide enum class, and renames all EditAction values from EditAction(*) to EditAction::(*).

No change in behavior.

editing/ApplyStyleCommand.h:

(WebCore::ApplyStyleCommand::create):

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::apply):
(WebCore::deleteSelectionEditingActionForEditingAction):

editing/CompositeEditCommand.h:

(WebCore::EditCommandComposition::wasCreateLinkCommand const):

editing/CreateLinkCommand.h:
editing/DeleteFromTextNodeCommand.h:

(WebCore::DeleteFromTextNodeCommand::create):

editing/DeleteSelectionCommand.h:

(WebCore::DeleteSelectionCommand::create):

editing/DictationCommand.cpp:

(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):

editing/EditAction.h:

(): Deleted.

editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

editing/EditCommand.h:
editing/Editor.cpp:

(WebCore::inputEventDataForEditingStyleAndAction):
(WebCore::ClearTextCommand::editingAction const):
(WebCore::Editor::handleTextEvent):
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::transpose):

editing/Editor.h:
editing/EditorCommand.cpp:

(WebCore::applyCommandToFrame):
(WebCore::executeInsertFragment):
(WebCore::executeBackColor):
(WebCore::executeFontName):
(WebCore::executeFontSize):
(WebCore::executeFontSizeDelta):
(WebCore::executeForeColor):
(WebCore::executeJustifyCenter):
(WebCore::executeJustifyFull):
(WebCore::executeJustifyLeft):
(WebCore::executeJustifyRight):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):
(WebCore::executeStrikethrough):
(WebCore::executeSubscript):
(WebCore::executeSuperscript):
(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):
(WebCore::executeUnderline):
(WebCore::executeUnscript):

editing/FormatBlockCommand.h:
editing/IndentOutdentCommand.h:
editing/InsertIntoTextNodeCommand.h:

(WebCore::InsertIntoTextNodeCommand::create):

editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::editingAction const):

editing/InsertNodeBeforeCommand.h:

(WebCore::InsertNodeBeforeCommand::create):

editing/InsertParagraphSeparatorCommand.h:

(WebCore::InsertParagraphSeparatorCommand::create):

editing/InsertTextCommand.h:

(WebCore::InsertTextCommand::create):
(WebCore::InsertTextCommand::createWithMarkerSupplier):

editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):
(WebCore::MoveSelectionCommand::editingAction const):

editing/RemoveFormatCommand.h:
editing/RemoveNodeCommand.h:

(WebCore::RemoveNodeCommand::create):

editing/ReplaceRangeWithTextCommand.cpp:

(WebCore::ReplaceRangeWithTextCommand::ReplaceRangeWithTextCommand):
(WebCore::ReplaceRangeWithTextCommand::doApply):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):

editing/ReplaceSelectionCommand.h:

(WebCore::ReplaceSelectionCommand::create):

editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand):
(WebCore::SpellingCorrectionCommand::doApply):

editing/TextInsertionBaseCommand.h:
editing/TypingCommand.cpp:

(WebCore::editActionForTypingCommand):
(WebCore::editActionIsDeleteByTyping):
(WebCore::TypingCommand::isBeforeInputEventCancelable const):
(WebCore::TypingCommand::inputEventData const):
(WebCore::TypingCommand::inputEventDataTransfer const):
(WebCore::TypingCommand::insertTextRunWithoutNewlines):
(WebCore::TypingCommand::insertParagraphSeparator):

editing/UnlinkCommand.h:
editing/ios/DictationCommandIOS.cpp:

(WebCore::DictationCommandIOS::DictationCommandIOS):

editing/ios/EditorIOS.mm:

(WebCore::Editor::removeUnchangeableStyles):

page/DragController.cpp:

(WebCore::DragController::concludeEditDrag):

Source/WebKit:

UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::changeFontAttributes):
(WebKit::WebPage::changeFont):

Source/WebKitLegacy/mac:

WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

WebView/WebHTMLView.mm:

(-[WebHTMLView pasteFont:]):
(-[WebHTMLView changeFont:]):
(-[WebHTMLView changeAttributes:]):
(-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
(-[WebHTMLView changeColor:]):

WebView/WebView.mm:

(-[WebView setTypingStyle:]):

Source/WebKitLegacy/win:

WebCoreSupport/WebEditorClient.cpp:

(undoNameForEditAction):

7:36 PM Changeset in webkit [235774] by Simon Fraser

3 edits in trunk/Source/WebCore

Fix the build for non-Cocoa platforms after r235772.

platform/graphics/cairo/GradientCairo.cpp:

(WebCore::Gradient::createPlatformGradient):

platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::generateGradient):
(WebCore::Gradient::fill):

7:27 PM Changeset in webkit [235773] by Alan Bujtas

8 edits
2 adds in trunk

[LFC] Add support for min/max-height percentage values.
https://bugs.webkit.org/show_bug.cgi?id=189391

Reviewed by Antti Koivisto.

Source/WebCore:

The percentage is calculated with respect to the height of the generated box's containing block.
If the height of the containing block is not specified explicitly (i.e., it depends on content height), and this element
is not absolutely positioned, the percentage value is treated as '0' (for 'min-height') or 'none' (for 'max-height').

Test: fast/block/block-only/min-max-height-percentage.html

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedValueIfNotAuto):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/block/block-only/min-max-height-percentage-expected.txt: Added.
fast/block/block-only/min-max-height-percentage.html: Added.

6:36 PM Changeset in webkit [235772] by Megan Gardner

17 edits
10 adds in trunk

Add Support for Conic Gradients
https://bugs.webkit.org/show_bug.cgi?id=189329
<rdar://problem/21444701>

Reviewed by Simon Fraser.

Source/WebCore:

Add support for rendering CSS conic gradients.
The parsing work was already done, this just hooks up the data we have
with the CG functionality for conic gradients. Add the needed plumbing
to allow for this additional type and fill in the creation of
a conic gradient.

Tests: fast/gradients/conic-repeating.html

fast/gradients/conic.html

css/CSSGradientValue.cpp:

(WebCore::createGradient):
(WebCore::LinearGradientAdapter::gradientLength const):
(WebCore::RadialGradientAdapter::gradientLength const):
(WebCore::ConicGradientAdapter::ConicGradientAdapter):
(WebCore::ConicGradientAdapter::gradientLength const):
(WebCore::ConicGradientAdapter::maxExtent const):
(WebCore::ConicGradientAdapter::normalizeStopsAndEndpointsOutsideRange):

Compute what the color stops should be if they extend past 0-1

(WebCore::CSSGradientValue::computeStops):
(WebCore::CSSConicGradientValue::createGradient):
(WebCore::LinearGradientAdapter::startPoint const): Deleted.
(WebCore::LinearGradientAdapter::endPoint const): Deleted.
(WebCore::RadialGradientAdapter::startPoint const): Deleted.
(WebCore::RadialGradientAdapter::endPoint const): Deleted.

Start and End points weren't very universal. All we really need from these
gradientAdapters is their length, so just ask for that instead.

inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildArrayForCanvasGradient):

platform/graphics/Gradient.cpp:

(WebCore::Gradient::create):
(WebCore::Gradient::Gradient):
(WebCore::Gradient::type const):
(WebCore::Gradient::adjustParametersForTiledDrawing):
(WebCore::Gradient::isZeroSize const):
(WebCore::Gradient::hash const):

platform/graphics/Gradient.h:
platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::paint):

Source/WebCore/PAL:

Define the CG functionality for conic gradients.

pal/spi/cg/CoreGraphicsSPI.h:

Source/WebKit:

Connect up web preferences to allow conic gradients to be turned on in the
experimental features menu.

Shared/WebPreferences.yaml:

LayoutTests:

Simple tests to see if conic gradients are rendered properly.

fast/gradients/conic-expected.html: Added.
fast/gradients/conic-repeating-expected.html: Added.
fast/gradients/conic-repeating.html: Added.
fast/gradients/conic.html: Added.

5:24 PM Changeset in webkit [235771] by Simon Fraser

4 edits in trunk/Tools

Log when leak detection changes the test result
https://bugs.webkit.org/show_bug.cgi?id=189293

Reviewed by Jon Lee.

When you have an "Leak" expectation in TestExpectations, it's confusing to see a test unexpectedly pass,
but then show up as an expected fail at the end (because leak detection happens at the end of a shard).
So log when leak detection changes a test result.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._annotate_results_with_additional_failures):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

5:21 PM Changeset in webkit [235770] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.21.92

Release WPE WebKit 2.21.92

5:05 PM Changeset in webkit [235769] by Wenson Hsieh

17 edits
2 adds in trunk

[macOS] [WK2] Support changing attributes for selected text (text shadow, underline, strike-through)
https://bugs.webkit.org/show_bug.cgi?id=189356
<rdar://problem/44185674>

Reviewed by Tim Horton.

Source/WebCore:

Add support for encoding and decoding FontAttributeChanges, so that we can send FontAttributeChanges over IPC in
WebKit2. Also change m_verticalAlign to a new VerticalAlignChange enum type, so that it's no longer tied to the
CSS property values of "vertical-align", and can be encoded/decoded separately from VerticalAlign in
RenderStyleConstants.

Test: FontManagerTests.ChangeAttributesWithFontEffectsBox

editing/FontAttributeChanges.cpp:

(WebCore::FontAttributeChanges::createEditingStyle const):

editing/FontAttributeChanges.h:

(WebCore::FontAttributeChanges::setVerticalAlign):
(WebCore::FontShadow::encode const):
(WebCore::FontShadow::decode):
(WebCore::FontAttributeChanges::encode const):
(WebCore::FontAttributeChanges::decode):

platform/mac/WebCoreNSFontManagerExtras.mm:

(WebCore::computedFontAttributeChanges):

Source/WebKit:

Implement -[WKWebView changeAttributes:], so that WKWebView can carry out more types of font style changes via
NSFontPanel. This patch makes it possible to (1) change text shadow, (2) add or remove strike-through, and (3)
add or remove underlines from selected text using the font panel.

This builds on the mechanisms introduced in r235748 to compute font attribute changes in the UI process and
propagate this information to the web process, where we're able to create and apply an EditingStyle to the
current selection.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView changeAttributes:]):

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::changeFontAttributesFromSender):

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::changeFontAttributes):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Add boilerplate IPC support.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::changeFontAttributes):

Tools:

Adds a new API test to verify that some font attributes (text shadow, underline, and strike-through) can be
added and removed using NSFontPanel.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/FontManagerTests.mm:

Add the new API test.

(TestWebKitAPI::TEST):

TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/mac/NSFontPanelTesting.h: Added.
TestWebKitAPI/mac/NSFontPanelTesting.mm: Added.

Introduce a new file that extends NSFontPanel with some additional testing functionality. This includes the
ability to interact with the text shadow toggle button, choose the text shadow blur radius and opacity, and
change underline and strike-through styles.

(findSubviewOfClass):
(findMenuItemWithTitle):
(-[NSFontPanel fontEffectsBox]):

NSFontEffectsBox (an internal AppKit class) is the sender in the case where -changeAttributes: is invoked
through interaction with the font panel. To simulate this for testing, grab this font effects box and pass it
directory to -changeAttributes:.

(-[NSFontPanel chooseUnderlineMenuItemWithTitle:]):
(-[NSFontPanel chooseStrikeThroughMenuItemWithTitle:]):

The supported values for these menu items are "none" and "single", which adds a single underline or
strike-through to selected text. We grab these menu items by asking for the font panel's NSToolbar, and finding
the relevant menu items via toolbar item identifiers.

(-[NSFontPanel _didChangeAttributes]):
(-[NSFontPanel shadowBlurSlider]):
(-[NSFontPanel shadowOpacitySlider]):
(-[NSFontPanel shadowToggleButton]):
(-[NSFontPanel toggleShadow]):
(-[NSFontPanel shadowOpacity]):
(-[NSFontPanel setShadowOpacity:]):
(-[NSFontPanel shadowBlur]):
(-[NSFontPanel setShadowBlur:]):
(-[NSFontPanel _toolbarItemWithIdentifier:]):

4:52 PM Changeset in webkit [235768] by bshafiei@apple.com

7 edits in branches/safari-606-branch/Source

Versioning.

4:50 PM Changeset in webkit [235767] by bshafiei@apple.com

1 copy in tags/Safari-606.2.1

Tag Safari-606.2.1.

4:47 PM Changeset in webkit [235766] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.22

Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.92 release.

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.21.92.

4:44 PM Changeset in webkit [235765] by msaboff@apple.com

3 edits
1 add in trunk

Improper speculation type for Math.pow(NaN, 0) in Abstract Interpreter
https://bugs.webkit.org/show_bug.cgi?id=189380

Reviewed by Saam Barati.

JSTests:

New test.

stress/math-pow-nan-to-zero-spec-type.js: Added.

(func):
(test):

Source/JavaScriptCore:

Account for the case where in Math.pow(NaN, y) where y could be 0.

bytecode/SpeculatedType.cpp:

(JSC::typeOfDoublePow):

4:25 PM Changeset in webkit [235764] by Simon Fraser

10 edits in trunk/Tools

run-webkit-tests prints confusing messages when test expectations list results that are not compatible with the run options
https://bugs.webkit.org/show_bug.cgi?id=189219

Reviewed by Jon Lee.

If you call run-webkit-tests without --pixel-tests, and a non-ref test is marked as ImageOnlyFailure,
it will be reported as unexpectedly passing. This is more confusing if you run without --world-leaks, yet
tests are marked as [ Leak ] in TestExpectations.

Fix by filtering out expectations that don't apply given the run options. So without --pixel-tests,
a non-ref ImageOnlyFailure becomes a Pass, and without --world-leaks, a Leak becomes a Pass.

Add various unit tests to test the various combinations.

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner._update_summary_with_result):
(LayoutTestRunner._annotate_results_with_additional_failures):

Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests.test_update_summary_with_result):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationsModel.get_expectations_or_pass):
(TestExpectationsModel):
(TestExpectationsModel.expectations_to_string):
(TestExpectationsModel.get_expectations_string):
(TestExpectations.filtered_expectations_for_test):
(TestExpectations):
(TestExpectations.matches_an_expected_result):

Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:

(summarized_results):
(SummarizedResultsTest.setUp):
(SummarizedResultsTest.test_summarized_results_include_passes):
(SummarizedResultsTest):
(SummarizedResultsTest.test_summarized_results_world_leaks_disabled):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:

(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_unexpected_results_with_options):
(BuildBotPrinterTests.test_print_results):

Scripts/webkitpy/port/test.py:

(unit_test_list):

3:39 PM Changeset in webkit [235763] by Alan Bujtas

10 edits
6 adds in trunk

[LFC][BFC] Add support for min(max)-height
https://bugs.webkit.org/show_bug.cgi?id=189377

Reviewed by Antti Koivisto.

Source/WebCore:

See https://www.w3.org/TR/CSS22/visudet.html#min-max-heights for details.

Tests: fast/block/block-only/absolute-position-min-max-height.html

fast/block/block-only/float-min-max-height.html
fast/block/block-only/inflow-min-max-height.html

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/block/block-only/absolute-position-min-max-height-expected.txt: Added.
fast/block/block-only/absolute-position-min-max-height.html: Added.
fast/block/block-only/float-min-max-height-expected.txt: Added.
fast/block/block-only/float-min-max-height.html: Added.
fast/block/block-only/inflow-min-max-height-expected.txt: Added.
fast/block/block-only/inflow-min-max-height.html: Added.

3:32 PM Changeset in webkit [235762] by Dewei Zhu

3 edits in trunk/Tools

BenchmarkResults.format should support specifying depth of tests to show.
https://bugs.webkit.org/show_bug.cgi?id=189135

Reviewed by Ryosuke Niwa.

Added the option to specify the depth of tests to show.

Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults):
(BenchmarkResults.format): Added 'max_depth' option.
(BenchmarkResults._format_tests): Added unit tests for 'max_depth'.

3:25 PM Changeset in webkit [235761] by Simon Fraser

3 edits in trunk/Tools

An EWS run that has leak test failures does not correctly add bugzilla comments showing the failures
https://bugs.webkit.org/show_bug.cgi?id=189368

Reviewed by Alexey Proskuryakov.

Include FailureDocumentLeak in ALL_FAILURE_CLASSES (with a fairly redundant test),
which should fix EWS showing leaks in Bugzilla.

Scripts/webkitpy/layout_tests/models/test_failures.py:

(FailureDocumentLeak.init):

Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:

(TestFailuresTest.test_all_failure_classes):

3:10 PM Changeset in webkit [235760] by eric.carlson@apple.com

12 edits in trunk/Source/WebCore

[MediaStream] Include supported frame rates in video capture presets
https://bugs.webkit.org/show_bug.cgi?id=189351
<rdar://problem/44188917>

Reviewed by Youenn Fablet.

No new tests, no functionality changed.

Include frame rates as well as width/height in video capture presets, so the mock video
capture devices model real camera devices more closely.

platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::setSizeAndFrameRate): Renamed from applySizeAndFrameRate. Use
setSize instead of setWidth and setHeight.
(WebCore::RealtimeMediaSource::applyConstraints): applySizeAndFrameRate -> setSizeAndFrameRate.
(WebCore::RealtimeMediaSource::applySizeAndFrameRate): Deleted.
(WebCore::RealtimeMediaSource::setWidth): Deleted.
(WebCore::RealtimeMediaSource::setHeight): Deleted.

platform/mediastream/RealtimeMediaSource.h:

platform/mediastream/RealtimeVideoSource.cpp:

(WebCore::RealtimeVideoSource::setSupportedPresets): New.
(WebCore::updateMinMax):
(WebCore::RealtimeVideoSource::addSupportedCapabilities const): Calculate capabilities from
presets.
(WebCore::RealtimeVideoSource::supportsSizeAndFrameRate): Use bestSupportedSizeAndFrameRate.
(WebCore::RealtimeVideoSource::bestSupportedSizeAndFrameRate):
(WebCore::RealtimeVideoSource::setSizeAndFrameRate):
(WebCore::RealtimeVideoSource::setSupportedFrameRates): Deleted.
(WebCore::RealtimeVideoSource::bestSupportedCaptureSizeForWidthAndHeight): Deleted.
(WebCore::RealtimeVideoSource::applySizeAndFrameRate): Deleted.
(WebCore::RealtimeVideoSource::supportsFrameRate): Deleted.

platform/mediastream/RealtimeVideoSource.h:

(WebCore::RealtimeVideoSource::setSupportedCaptureSizes): Deleted.

platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:

(WebCore::GStreamerVideoCaptureSource::stopProducingData):

platform/mediastream/mac/AVVideoCaptureSource.h:
platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setSizeAndFrameRate):
(WebCore::AVVideoCaptureSource::applySizeAndFrameRate): Deleted.

platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:

(WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream):

platform/mock/MockMediaDevice.h:

(WebCore::MockCameraProperties::encode const):
(WebCore::MockCameraProperties::decode):
(WebCore::MockDisplayProperties::encode const):
(WebCore::MockDisplayProperties::decode):

platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::defaultDevices):

platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::capabilities const):
(WebCore::MockRealtimeVideoSource::settings const):

2:52 PM WebKitGTK/StableRelease edited by Adrian Perez de Castro

Add link to the 2.22.x releases wiki page (diff)

2:48 PM Changeset in webkit [235759] by dbates@webkit.org

2 edits
2 adds in trunk/LayoutTests

[iOS] Add a test to ensure that DOM keyup events have the correct details
https://bugs.webkit.org/show_bug.cgi?id=189327

Reviewed by Wenson Hsieh.

Until we fix <rdar://problem/35282761> DOM keyup events will have incorrect details on iOS
when dispatched in response to a hardware keyboard press. For now, land expected failure results.

fast/events/ios/keyup-expected.txt: Added.
fast/events/ios/keyup.html: Added.
resources/ui-helper.js:

(window.UIHelper.typeCharacter): Escape backslash characters in order to build up
a well-formed UI script to evaluate.

2:37 PM Changeset in webkit [235758] by Antti Koivisto

11 edits
2 adds in trunk/Source

Actively prewarm processes created for prewarm pool
https://bugs.webkit.org/show_bug.cgi?id=189364

Reviewed by Chris Dumez.

Source/WebCore:

Do some basic prewarming for newly created processes.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):

css/CSSDefaultStyleSheets.h:
page/Frame.cpp:

(WebCore::Frame::Frame):

page/ProcessWarming.cpp: Added.

(WebCore::ProcessWarming::initializeNames):

Factor name initialization into a function.

(WebCore::ProcessWarming::prewarm):

Prewarm

names
settings (system fonts)
user agent stylesheet
JavaScript VM
telephone number detection

page/ProcessWarming.h: Added.

Source/WebKit:

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::prewarm):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

2:14 PM Changeset in webkit [235757] by youenn@apple.com

9 edits in trunk/Source/WebCore

Move replaceTrack logic to RTCRtpSender backend
https://bugs.webkit.org/show_bug.cgi?id=189359

Reviewed by Eric Carlson.

Move replaceTrack handling from LibWebRTCPeerConnectionBackend to LibWebRTCRtpSenderBackend.
This will allow using SetTrack when fully implementing unified plan.
No change of behavior.

Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack):

Modules/mediastream/RTCRtpSender.h:
Modules/mediastream/RTCRtpSender.idl:
Modules/mediastream/RTCRtpSenderBackend.h:
Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::replaceTrack): Deleted.
(WebCore::LibWebRTCPeerConnectionBackend::enqueueReplaceTrackTask): Deleted.

Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

(WebCore::updateTrackSource):
(WebCore::LibWebRTCRtpSenderBackend::replaceTrack):

Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.h:

2:09 PM Changeset in webkit [235756] by commit-queue@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r235755.
https://bugs.webkit.org/show_bug.cgi?id=189367

Didn't address the review comment (Requested by rniwa on
#webkit).

Reverted changeset:

"BenchmarkResults.format should support specifying depth of
tests to show."
https://bugs.webkit.org/show_bug.cgi?id=189135
https://trac.webkit.org/changeset/235755

1:47 PM Changeset in webkit [235755] by Dewei Zhu

3 edits in trunk/Tools

BenchmarkResults.format should support specifying depth of tests to show.
https://bugs.webkit.org/show_bug.cgi?id=189135

Reviewed by Ryosuke Niwa.

Added the option to specify the depth of tests to show.

Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults):
(BenchmarkResults.format): Added 'max_depth' option.
(BenchmarkResults._format_tests): Added unit tests for 'max_depth'.

1:42 PM Changeset in webkit [235754] by aestes@apple.com

10 edits in trunk

[Apple Pay] Rename the -apple-pay-button-type value "checkout" to "check-out"
https://bugs.webkit.org/show_bug.cgi?id=189366
<rdar://problem/44193218>

Reviewed by Sam Weinig.

Source/WebCore:

The button title is "Check out with Apple Pay", so we should use the verb phrase "check out"
rather than the noun "checkout" for naming this value.

Updated http/tests/ssl/applepay/ApplePayButtonV4.html.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ApplePayButtonType const):

css/CSSValueKeywords.in:
css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

rendering/RenderThemeCocoa.mm:

(WebCore::toPKPaymentButtonType):

rendering/style/RenderStyleConstants.h:

Source/WebInspectorUI:

UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

http/tests/ssl/applepay/ApplePayButtonV4.html:

1:36 PM Changeset in webkit [235753] by commit-queue@webkit.org

3 edits in trunk/Tools

[WHLSL] Call arguments should be copied as soon as they are evaluated
https://bugs.webkit.org/show_bug.cgi?id=189360

Patch by Thomas Denney <tdenney@apple.com> on 2018-09-06
Reviewed by Myles C. Maxfield.

Previously all call arguments were evaluated and then their results were
copied into new buffers for the call. However, the results are not
necessarily independent, so the result should be copied immediately
after evaluation.

WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitCallExpression): Move location of copy.
(Evaluator):

WebGPUShadingLanguageRI/Test.js: Add new test to verify correct

behavior.

12:59 PM Changeset in webkit [235752] by jer.noble@apple.com

17 edits in trunk/Source

Don't pause playback when locking screen if video is being displayed on second screen.
https://bugs.webkit.org/show_bug.cgi?id=189321

Reviewed by Eric Carlson.

Source/WebCore:

Expand the existing behavior when AirPlaying to an external device to playing to a local
external screen. Don't pause when the screen locks, and don't stop buffering in that mode either.

Add a KVO-observer to the WebAVPlayerController's playingOnSecondScreen property, and pass
that observed value on to the media element.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setShouldPlayToPlaybackTarget):
(WebCore::HTMLMediaElement::setPlayingOnSecondScreen):
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const):
(WebCore::HTMLMediaElement::processingUserGestureForMedia const):
(WebCore::HTMLMediaElement::mediaState const):
(WebCore::HTMLMediaElement::purgeBufferedDataIfPossible):
(WebCore::HTMLMediaElement::shouldOverrideBackgroundLoadingRestriction const):
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless const): Deleted.
(WebCore::HTMLMediaElement::canPlayToWirelessPlaybackTarget const): Deleted.
(WebCore::HTMLMediaElement::isPlayingToWirelessPlaybackTarget const): Deleted.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless const):
(WebCore::HTMLMediaElement::isPlayingToExternalTarget const):

html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canPlayToWirelessPlaybackTarget const): Deleted.

html/MediaElementSession.h:
platform/audio/PlatformMediaSession.h:

(WebCore::PlatformMediaSessionClient::setWirelessPlaybackTarget):
(WebCore::PlatformMediaSessionClient::isPlayingOnSecondScreen const):
(WebCore::PlatformMediaSession::canPlayToWirelessPlaybackTarget const): Deleted.
(WebCore::PlatformMediaSessionClient::canPlayToWirelessPlaybackTarget const): Deleted.

platform/cocoa/PlaybackSessionModel.h:
platform/cocoa/PlaybackSessionModelMediaElement.h:
platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::setPlayingOnSecondScreen):

platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController init]):
(-[WebAVPlayerController dealloc]):
(-[WebAVPlayerController observeValueForKeyPath:ofObject:change:context:]):

platform/ios/WebVideoFullscreenControllerAVKit.mm:

(VideoFullscreenControllerContext::setPlayingOnSecondScreen):

Source/WebKit:

Pass the "isPlayingOnSecondScreen" value across the process boundary.

UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionModelContext::setPlayingOnSecondScreen):
(WebKit::PlaybackSessionManagerProxy::setPlayingOnSecondScreen):

WebProcess/cocoa/PlaybackSessionManager.h:
WebProcess/cocoa/PlaybackSessionManager.messages.in:
WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::setPlayingOnSecondScreen):

12:58 PM Changeset in webkit [235751] by mark.lam@apple.com

1 edit
1 move in trunk/JSTests

Gardening: Move regress-189185.js under JSTests/wasm.
https://bugs.webkit.org/show_bug.cgi?id=189347

Unreviewed.

stress/regress-189185.js: Removed.
wasm/regress/regress-189185.js: Copied from JSTests/stress/regress-189185.js.

12:58 PM Changeset in webkit [235750] by commit-queue@webkit.org

2 edits in trunk/Tools

[WHLSL] The test suite should log the compile time for the standard library
https://bugs.webkit.org/show_bug.cgi?id=189354

Patch by Thomas Denney <tdenney@apple.com> on 2018-09-06
Reviewed by Myles C. Maxfield.

The test suite previously only logged the time for test execution, and
not the compile time for the standard library.

WebGPUShadingLanguageRI/Test.js:

12:48 PM Changeset in webkit [235749] by commit-queue@webkit.org

11 edits in trunk/Source

Group options of scrollRectToVisible into a struct
https://bugs.webkit.org/show_bug.cgi?id=189352

Patch by Frederic Wang <fwang@igalia.com> on 2018-09-06
Reviewed by Simon Fraser.

Source/WebCore:

RenderLayer::scrollRectToVisible and RenderObject::scrollRectToVisible have several
parameters to configure the type of scrolling. This patch groups the const options into a
single struct to make easier to handle them in the future. For example, an #ifdefed scroll
behavior option will be added in bug 188043. This refactoring can maybe help too for other
scroll extensions (e.g. bug 176454 and bug 161611).

No new tests, behavior unchanged.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::scrollToMakeVisible const): Pass options via a struct.

dom/Element.cpp:

(WebCore::Element::scrollIntoView): Ditto.
(WebCore::Element::scrollIntoViewIfNeeded): Ditto.
(WebCore::Element::scrollIntoViewIfNotVisible): Ditto.

editing/FrameSelection.cpp: Include RenderLayer.h in all WebKit ports in order to define

ScrollRectToVisibleOptions.
(WebCore::FrameSelection::revealSelection): Pass options via a struct.

page/FrameView.cpp:

(WebCore::FrameView::scrollToFocusedElementInternal): Ditto.
(WebCore::FrameView::scrollToAnchor): Ditto.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible): Pass options via a struct. Note that
absoluteRect and insideFixed are modified in this function.
(WebCore::RenderLayer::autoscroll): Pass options via a struct.

rendering/RenderLayer.h: Add ScrollRectToVisibleOptions and use it in order to pass

scrollRectToVisible options.

rendering/RenderObject.cpp:

(WebCore::RenderObject::scrollRectToVisible): Pass options via a struct

rendering/RenderObject.h: Forward-declare ScrollRectToVisibleOptions and use in order to

pass scrollRectToVisible options.

Source/WebKitLegacy/mac:

WebView/WebFrame.mm: Add header to use ScrollRectToVisibleOptions.

(-[WebFrame _scrollDOMRangeToVisible:]): Pass options via a struct.
(-[WebFrame _scrollDOMRangeToVisible:withInset:]): Ditto.

12:46 PM Changeset in webkit [235748] by Wenson Hsieh

20 edits
6 adds in trunk

[macOS] Cannot change font size at selection until font panel is shown
https://bugs.webkit.org/show_bug.cgi?id=189295
<rdar://problem/35593389>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Currently, attempting to alter the font size of currently selected editable text in WKWebView via menu items
will fail if the font panel has never been shown. This is because WebViewImpl::changeFontFromFontPanel, which is
responsible for converting the current font at the selection to the new font using -[NSFontManager convertFont:]
bails as a result of NSFontManager's currently selected font always being nil.

WKWebView is responsible for keeping NSFontManager up-to-date with the currently selected font; in fact, this
was initially the case in r180465, which introduced NSFontManager support in WebKit2 by propagating EditorState
updates that contained font information for the current selection. However, this regressed performance due to
selected font computation triggering extra layout passes; r180768 addressed this by introducing a mechanism for
requesting the font at the current selection, and only updating NSFontManager with the new selected font when
the shared font panel is visible (determined by KVO on NSFontPanel). However, this again regressed WKWebView
launch performance, due to KVO registration always forcing the shared NSFontPanel to be created. r182037
addressed this by only registering for KVO on the font panel if the WKWebView has been made editable (SPI on
WKWebView).

This leads to two issues when attempting to alter font attributes using macOS UI: (1) in web views that have not
been made editable using SPI, showing the font panel and attempting to change the font fails due to the selected
font staying nil, because we've never begun registering for KVO notifications on the font panel so we don't try
to keep the font manager up to date. (2) Even if the web view is made editable, if the font panel is never
shown, then the font manager still won't be kept up to date with the current selection, so changing fonts using
menu items still does not work.

We fix both of these problems by refactoring font manager support on WebKit2 such that an up-to-date selected
font in the UI process is no longer necessary in order to alter the font at the current selection. To do this,
we figure out what changes the NSFontManager would've made to the currently selected font in the UI process, and
then propagate this information to the web process, where we convert this information into an EditingStyle which
we apply to the current selection.

The code to both determine the attributes changed by NSFontManager and to convert these attributes into editing
styles to be applied via Editor already exists in WebKitLegacy, in WebHTMLView.mm. This patch moves this
existing logic into WebCore and teases it apart into two portions: the first portion probes NSFontManager to
determine which aspects of the font changed and constructs FontChanges, which captures these differences. The
second portion maps FontChanges to an EditingStyle, which can then be applied to the current selection. In
WebKitLegacy, we construct FontChanges using the font manager, and then immediately use it to create and apply
an EditingStyle. In WebKit, we construct FontChanges in the UI process using the font manager, and then send
this over to the web process via WebPage::changeFont, which then creates and applies the EditingStyle.

Note that this patch also introduces FontAttributeChanges, which is similar in concept to FontChanges, but
captures a broader range of changes possible via NSFontPanel. This was done so that we can eliminate all of the
font manager probing code (along with the two specimen fonts) from WebHTMLView, but is also necessary in order
to allow changing font shadow, strikethrough, and underlines via the font panel to work in WebKit2. This will be
fixed in a followup, by making FontAttributeChanges IPC encodable and by making WKWebView/WKView respond to the
-changeAttributes: selector.

Changes in behavior to WebKit2 are covered by new API tests; legacy WebKit behavior should remain unchanged.

Tests: FontManagerTests.ChangeFontSizeWithMenuItems

FontManagerTests.ChangeFontWithPanel

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
editing/Editor.h:

Remove applyFontStyles.

editing/FontAttributeChanges.cpp: Added.

(WebCore::FontChanges::platformFontFamilyNameForCSS const):

Given a font family name and a font name, returns the string to use as the "font-family" style property value.
Originally from WebHTMLView.mm.

(WebCore::FontChanges::createEditingStyle const):

Converts font changes to an EditingStyle that can be used to apply these changes.

(WebCore::FontChanges::createStyleProperties const):

Introduce FontChanges, which encapsulates changes which are to be applied to the font in the current selection.

(WebCore::cssValueListForShadow):
(WebCore::FontAttributeChanges::createEditingStyle const):

Converts font attribute changes to an EditingStyle that can be used to apply these changes.

editing/FontAttributeChanges.h: Added.

Introduce FontAttributeChanges, which encapsulates changes which are to be applied to the font attributes in the
current selection. This includes a set of FontChanges, as well as additional attributes such as strike-through
and underlines.

(WebCore::FontChanges::setFontName):
(WebCore::FontChanges::setFontFamily):
(WebCore::FontChanges::setFontSize):
(WebCore::FontChanges::setFontSizeDelta):
(WebCore::FontChanges::setBold):
(WebCore::FontChanges::setItalic):
(WebCore::FontAttributeChanges::setVerticalAlign):
(WebCore::FontAttributeChanges::setBackgroundColor):
(WebCore::FontAttributeChanges::setForegroundColor):
(WebCore::FontAttributeChanges::setShadow):
(WebCore::FontAttributeChanges::setStrikeThrough):
(WebCore::FontAttributeChanges::setUnderline):
(WebCore::FontAttributeChanges::setFontChanges):

Setters for FontChanges and FontAttributeChanges. Initially, most of these values are optional, indicating that
there should be no change.

(WebCore::FontChanges::encode const):
(WebCore::FontChanges::decode):

Add encoding/decoding support to FontChanges, so that it can be sent over IPC for WebKit2.

editing/cocoa/FontAttributeChangesCocoa.mm: Added.

(WebCore::FontChanges::platformFontFamilyNameForCSS const):

Helper method to determine whether the font family or the font name should be used, by looking up the PostScript
font name using a FontDescriptor and comparing it against the result of -[NSFont fontName]. This logic was
originally in WebHTMLView.mm.

editing/mac/EditorMac.mm:

(WebCore::Editor::applyFontStyles): Deleted.

platform/mac/WebCoreNSFontManagerExtras.h: Added.
platform/mac/WebCoreNSFontManagerExtras.mm: Added.

Add helper functions to compute FontChanges and FontAttributeChanges from NSFontManager.

(WebCore::firstFontConversionSpecimen):
(WebCore::secondFontConversionSpecimen):

Two "specimen fonts" used to determine what changes NSFontManager or NSFontPanel makes when performing font or
font attribute conversion. Moved from WebHTMLView.mm.

(WebCore::computedFontChanges):
(WebCore::computedFontAttributeChanges):

Moved here from WebHTMLView.mm. Instead of converting font attributes to NSStrings and setting properties on
DOMCSSStyleDeclaration, we instead specify properties on MutableStyleProperties using CSSValues.

Source/WebKit:

Refactors NSFontManager support in WebKit2. See WebCore ChangeLog for more details.

Scripts/webkit/messages.py:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView changeFont:]):

UIProcess/API/mac/WKView.mm:

(-[WKView changeFont:]):

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::changeFontFromFontManager):
(WebKit::WebViewImpl::changeFontFromFontPanel): Deleted.

Renamed this from changeFontFromFontPanel to changeFontFromFontManager. This new name is more accurate in the
case where a menu item is used to alter the font, which doesn't involve NSFontPanel at all.

UIProcess/WebPageProxy.h:
UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::changeFont):
(WebKit::WebPageProxy::setFont): Deleted.

WebKit.xcodeproj/project.pbxproj:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::changeFont):
(WebKit::WebPage::setFont): Deleted.

Source/WebKitLegacy/mac:

Remove code in WebKitLegacy for diffing NSFonts to figure out which style properties need to be changed. See
WebCore ChangeLog for more details.

WebView/WebHTMLView.mm:

(-[WebHTMLView changeFont:]):
(-[WebHTMLView changeAttributes:]):
(-[WebHTMLView _originalFontA]): Deleted.
(-[WebHTMLView _originalFontB]): Deleted.
(fontNameForDescription): Deleted.
(-[WebHTMLView _addToStyle:fontA:fontB:]): Deleted.
(-[WebHTMLView _styleFromFontManagerOperation]): Deleted.
(-[WebHTMLView _styleForAttributeChange:]): Deleted.

Tools:

Add API tests to simulate using menu items to increase or decrease font size, and also simulate using
NSFontPanel to specify the font family, font size, and other traits.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/mac/FontManagerTests.mm: Added.

(-[TestWKWebView selectedText]):
(-[TestWKWebView selectNextWord]):
(-[TestWKWebView stylePropertyAtSelectionStart:]):
(-[TestWKWebView stylePropertyAtSelectionEnd:]):
(webViewForFontManagerTesting):
(menuItemCellForFontAction):
(TestWebKitAPI::TEST):

11:58 AM WebKitGTK/2.22.x edited by berto@igalia.com

(diff)

11:52 AM Changeset in webkit [235747] by bshafiei@apple.com

7 edits in tags/Safari-607.1.5.2/Source

Versioning.

11:49 AM Changeset in webkit [235746] by bshafiei@apple.com

1 copy in tags/Safari-607.1.5.2

Tag Safari-607.1.5.2.

11:07 AM Changeset in webkit [235745] by bshafiei@apple.com

2 edits in branches/safari-606-branch/Source/JavaScriptCore

Cherry-pick r235742. rdar://problem/44169344

Gardening: only visit m_cachedStructureID if it's not null.
https://bugs.webkit.org/show_bug.cgi?id=189124
<rdar://problem/43863605>

Not reviewed.

runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::visitChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:03 AM Changeset in webkit [235744] by Alan Bujtas

10 edits
6 adds in trunk

[LFC][BFC] Add support for min(max)-width
https://bugs.webkit.org/show_bug.cgi?id=189358

Reviewed by Antti Koivisto.

Source/WebCore:

See https://www.w3.org/TR/CSS22/visudet.html#min-max-widths for details.

Tests: fast/block/block-only/absolute-position-min-max-width.html

fast/block/block-only/float-min-max-width.html
fast/block/block-only/inflow-min-max-width.html

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):

layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::computedValueIfNotAuto):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/block/block-only/absolute-position-min-max-width-expected.txt: Added.
fast/block/block-only/absolute-position-min-max-width.html: Added.
fast/block/block-only/float-min-max-width-expected.txt: Added.
fast/block/block-only/float-min-max-width.html: Added.
fast/block/block-only/inflow-min-max-width-expected.txt: Added.
fast/block/block-only/inflow-min-max-width.html: Added.

10:59 AM Changeset in webkit [235743] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[MediaStream] Initialize AVVideoCapture video presets
https://bugs.webkit.org/show_bug.cgi?id=189355

Reviewed by Youenn Fablet.

No new tests, no functionality changed.

platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::AVVideoCaptureSource): Don't try to load symbols if they
aren't available.

10:46 AM Changeset in webkit [235742] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Gardening: only visit m_cachedStructureID if it's not null.
https://bugs.webkit.org/show_bug.cgi?id=189124
<rdar://problem/43863605>

Not reviewed.

runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::visitChildren):

9:56 AM Changeset in webkit [235741] by commit-queue@webkit.org

12 edits in trunk/Source/WebKit

Use more generic names than "overflow" for functions that can be used for subframes
https://bugs.webkit.org/show_bug.cgi?id=179125

Patch by Frederic Wang <fwang@igalia.com> on 2018-09-06
Reviewed by Simon Fraser..

Some functions will be used by subframes when iframe scrolling is implemented on iOS (see
bug 149264). Currently they are only used for "overflow" nodes. This patch renames them to
use a more generic "scrolling node" name.

UIProcess/PageClient.h:
UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll):

UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartPanGesture):
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeWillStartScroll):
(WebKit::RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidEndScroll):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::scrollingNodeScrollViewWillStartPanGesture):
(WebKit::PageClientImpl::scrollingNodeScrollViewDidScroll):
(WebKit::PageClientImpl::scrollingNodeScrollWillStartScroll):
(WebKit::PageClientImpl::scrollingNodeScrollDidEndScroll):
(WebKit::PageClientImpl::overflowScrollViewWillStartPanGesture): Deleted.
(WebKit::PageClientImpl::overflowScrollViewDidScroll): Deleted.
(WebKit::PageClientImpl::overflowScrollWillStartScroll): Deleted.
(WebKit::PageClientImpl::overflowScrollDidEndScroll): Deleted.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _scrollingNodeScrollingWillBegin]):
(-[WKContentView _scrollingNodeScrollingDidEnd]):
(-[WKContentView _overflowScrollingWillBegin]): Deleted.
(-[WKContentView _overflowScrollingDidEnd]): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::scrollingNodeScrollViewWillStartPanGesture):
(WebKit::WebPageProxy::scrollingNodeScrollViewDidScroll):
(WebKit::WebPageProxy::scrollingNodeScrollWillStartScroll):
(WebKit::WebPageProxy::scrollingNodeScrollDidEndScroll):
(WebKit::WebPageProxy::overflowScrollViewWillStartPanGesture): Deleted.
(WebKit::WebPageProxy::overflowScrollViewDidScroll): Deleted.
(WebKit::WebPageProxy::overflowScrollWillStartScroll): Deleted.
(WebKit::WebPageProxy::overflowScrollDidEndScroll): Deleted.

WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::didStartOverflowScroll):
(WebKit::WebChromeClient::didEndOverflowScroll):

9:41 AM Changeset in webkit [235740] by tpopela@redhat.com

2 edits in trunk/Source/JavaScriptCore

[JSC] Build broken after r234975 on s390x, ppc64le, armv7hl
https://bugs.webkit.org/show_bug.cgi?id=189078

Reviewed by Mark Lam.

Caused by the GCC bug - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70124.
Using the ternary operator instead of std::max() fixes it.

heap/RegisterState.h:

9:12 AM Changeset in webkit [235739] by Chris Dumez

3 edits in trunk/Source/WebKit

WebKit/Platform/IPC/mac/ConnectionMac.mm:222: _dispatch_bug_kevent_vanished
https://bugs.webkit.org/show_bug.cgi?id=189314
<rdar://problem/41248286>

Reviewed by Anders Carlsson.

There is a short period in time when m_isServer is true, after open() has been
called, but before we've receive the InitializeConnection IPC, where m_receiveSource
has been initialized but m_isConnected is still false. If platformInvalidate() gets
called during this period of time, we would fail to cancel / release m_receiveSource
and we would forcefully deallocate m_receivePort, leading to the libdispatch simulated
crashes.

To address the issue, platformInvalidate() now properly cancels / releases
m_receiveSource if present, and only deallocates m_receivePort manually if m_receiveSource
has not been initialized (i.e. open() has not been called yet).

Platform/IPC/Connection.h:
Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::platformInvalidate):
(IPC::Connection::clearReceiveSource):

9:01 AM Changeset in webkit [235738] by mmaxfield@apple.com

11 edits
1 copy in trunk/Tools

[WHLSL] The parser is too slow
https://bugs.webkit.org/show_bug.cgi?id=189014

Reviewed by Filip Pizlo.

This patch includes three changes:

Migrate from using try/catch to simply returning the WSyntaxError. This means that each parser call has to check for this sentinel value. The lexer still can throw if it encounters an unknown token or an unmatched "/*" token (which is rare).
After removing try/catch, making the sentinel values not inherit from Error (the Error constructor was taking lots of time)
Previously, every time the parser failed (which is many times per expression) it was running a regex over the entire source text to figure out where the error occurred. Instead, we can preprocess the text string to find these line numbers ahead of time.

Together, these make the parser 75x faster. Parsing the standard library goes from 2.5
hours down to 2 minutes. Because it's now a reasonable length, this patch uncomments
the bulk of the standard library.

WebGPUShadingLanguageRI/All.js:
WebGPUShadingLanguageRI/Lexer.js:

(Lexer):
(Lexer.prototype.lineNumberForIndex):

WebGPUShadingLanguageRI/Parse.js:

(fail):
(backtrackingScope):
(testScope):
(genericConsume):
(consumeEndOfTypeArgs):
(parseTerm):
(parseConstexpr):
(parseTypeArguments):
(parseType.getAddressSpace):
(parseType):
(parseTypeDef):
(genericParseLeft):
(parseCallExpression.let.parseArguments):
(isCallExpression):
(parseSuffixOperator):
(parsePossibleSuffix):
(parsePreIncrement):
(parsePossiblePrefix):
(parsePossibleTernaryConditional):
(parsePossibleAssignment):
(parsePostIncrement):
(parseEffectfulExpression):
(genericParseCommaExpression):
(parseEffectfulStatement):
(parseReturn):
(parseBreak):
(parseContinue):
(parseIfStatement):
(parseWhile):
(parseFor):
(parseDo):
(parseVariableDecls):
(parseSwitchCase):
(parseSwitchStatement):
(parseStatement):
(parseBlockBody):
(parseBlock):
(parseParameter):
(parseFuncName):
(parseFuncDecl):
(parseFuncDef):
(parseField):
(parseStructType):
(parseNativeFunc):
(parseNative):
(parseRestrictedFuncDef):
(parseEnumMember):
(parseEnumType):
(parse):

WebGPUShadingLanguageRI/SPIRV.html:
WebGPUShadingLanguageRI/StandardLibrary.js:

(let.standardLibrary):

WebGPUShadingLanguageRI/Test.html:
WebGPUShadingLanguageRI/Test.js:

(checkFail.doPrep): Deleted.

WebGPUShadingLanguageRI/WLexicalError.js: Added.

(WLexicalError):

WebGPUShadingLanguageRI/index.html:

8:00 AM Changeset in webkit [235737] by magomez@igalia.com

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening after r235732.

platform/gtk/TestExpectations:

6:51 AM Changeset in webkit [235736] by ajuma@chromium.org

8 edits
6 adds in trunk

IntersectionObserver leaks documents
https://bugs.webkit.org/show_bug.cgi?id=189128

Reviewed by Simon Fraser.

Source/WebCore:

Currently, Documents own IntersectionObservers while IntersectionObservers own callbacks
that have strong references to Documents. To break this cycle, make Documents only have
weak pointers to IntersectionObservers. Instead, manage the lifetime of an
IntersectionObserver as an ActiveDOMObject, overriding hasPendingActivity to keep
the observer alive while there are ongoing observations.

However, there is a still a potential reference cycle. The callback keeps global
references alive, so if there's a global reference to the observer in JavaScript,
we have an observer->callback->observer cycle, keeping the callback (and hence the Document)
alive. To break this cycle, make IntersectionObserver release the callback when its
Document is stopped.

With these changes, there are no longer any leaks reported with run-webkit-tests --world-leaks
on LayoutTests/intersection-observer and LayoutTests/imported/w3c/web-platform-tests/intersection-observer.

Tests: intersection-observer/no-document-leak.html

intersection-observer/observer-and-callback-without-js-references.html

dom/Document.cpp:

(WebCore::Document::addIntersectionObserver):
(WebCore::Document::removeIntersectionObserver):

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::didMoveToNewDocument):

page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::IntersectionObserver):
(WebCore::IntersectionObserver::~IntersectionObserver):
(WebCore::IntersectionObserver::observe):
(WebCore::IntersectionObserver::rootDestroyed):
(WebCore::IntersectionObserver::createTimestamp const):
(WebCore::IntersectionObserver::notify):
(WebCore::IntersectionObserver::hasPendingActivity const):
(WebCore::IntersectionObserver::activeDOMObjectName const):
(WebCore::IntersectionObserver::canSuspendForDocumentSuspension const):
(WebCore::IntersectionObserver::stop):

page/IntersectionObserver.h:

(WebCore::IntersectionObserver::trackingDocument const):
(WebCore::IntersectionObserver::trackingDocument): Deleted.

page/IntersectionObserver.idl:

LayoutTests:

intersection-observer/no-document-leak-expected.txt: Added.
intersection-observer/no-document-leak.html: Added.
intersection-observer/observer-and-callback-without-js-references-expected.txt: Added.
intersection-observer/observer-and-callback-without-js-references.html: Added.
intersection-observer/resources/no-document-leak-frame.html: Added.

6:40 AM Changeset in webkit [235735] by Alan Bujtas

11 edits in trunk/Source/WebCore

[LFC] Adapt to the new const WeakPtr<>
https://bugs.webkit.org/show_bug.cgi?id=189334

Reviewed by Antti Koivisto.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::FormattingContext):

layout/FormattingContext.h:
layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::initializeRoot):

layout/LayoutContext.h:
layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::FloatAvoider):

layout/floats/FloatAvoider.h:
layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::FloatItem::FloatItem):
(WebCore::Layout::FloatingState::FloatingState):

layout/floats/FloatingState.h:
layout/layouttree/LayoutContainer.cpp:

(WebCore::Layout::Container::addOutOfFlowDescendant):

layout/layouttree/LayoutContainer.h:

(WebCore::Layout::Container::outOfFlowDescendants const):

6:27 AM Changeset in webkit [235734] by commit-queue@webkit.org

2 edits in trunk/Tools

[test262] Do not call keys on a reference
https://bugs.webkit.org/show_bug.cgi?id=189301

Patch by Xan Lopez <Xan Lopez> on 2018-09-06
Reviewed by Keith Miller.

Scripts/test262/Runner.pm:

(UpdateResults):

5:38 AM Changeset in webkit [235733] by ddkilzer@apple.com

3 edits
1 add in trunk/Tools

svn-create-patch fails when svn mv is used on directory trees
<https://webkit.org/b/14590>

Reviewed by Daniel Bates.

Scripts/VCSUtils.pm: Export parseSvnDiffStartLine() for

svn-create-patch.
(parseDiffStartLine): Use parseSvnDiffStartLine().
(parseGitDiffStartLine): Document a prerequisite. Fix a bug
when parsing git patches using git diff --no-prefix non-native
line endings. Found by new tests written for
Scripts/webkitperl/VCSUtils_unittest/parseDiffStartLine.pl.
(parseSvnDiffStartLine): Add. Extract logic from
parseDiffStartLine() for use with svn-create-patch.

Scripts/svn-create-patch: Update copyright and license.

(generateDiff): Return early for moved directories since
individual files within the directory are handled separately.
(generateFileList): Keep track of moved directories in the
@additionWithHistoryDirectories array, then process this array
in reverse order to create delete/add patches for each file in
a moved directory. This also prevents duplicate patches.
(manufacturePatchForAdditionWithHistory): Fix a long-standing
bug where the path used to describe property changes contained
the original (moved-from) path instead of the new (moved-to)
path. This could cause svn-apply to fail mysteriously when
trying to apply an empty patch created by the property change
containing the moved-from path.

Scripts/webkitperl/VCSUtils_unittest/parseDiffStartLine.pl: Add.

Tests for parseDiffStartLine(), parseGitDiffStartLine() and
parseSvnDiffStartLine().

3:50 AM Changeset in webkit [235732] by calvaris@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer] Extra ASSERTs at MainThreadNotifier
https://bugs.webkit.org/show_bug.cgi?id=188786

Reviewed by Carlos Garcia Campos.

We add a couple of checks in debug mode: there is only one bit on
per notification and ensure a notifier was invalidated before
being destroyed.

platform/graphics/gstreamer/MainThreadNotifier.h:

2:36 AM Changeset in webkit [235731] by mark.lam@apple.com

57 edits
3 copies
2 deletes in branches/safari-606-branch

Cherry-pick r235254, r235419, r235666. rdar://problem/44169332

JSTests:

2018-08-27 Mark Lam <mark.lam@apple.com>

Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names.
https://bugs.webkit.org/show_bug.cgi?id=188577
<rdar://problem/42985684>

Reviewed by Saam Barati.

stress/regress-188577.js: Added.

Source/JavaScriptCore:

2018-08-23 Mark Lam <mark.lam@apple.com>

Move vmEntryGlobalObject() to VM from CallFrame.
https://bugs.webkit.org/show_bug.cgi?id=188900
<rdar://problem/43655753>

Reviewed by Michael Saboff.

Also introduced CallFrame::isGlobalExec() which makes use of one property of
GlobalExecs to identify them i.e. GlobalExecs have null callerFrame and returnPCs.
CallFrame::initGlobalExec() ensures this.

In contrast, normal CallFrames always have a callerFrame (because they must at
least be preceded by a VM EntryFrame) and a returnPC (at least return to the
VM entry glue).

API/APIUtils.h: (handleExceptionIfNeeded): (setException):
API/JSBase.cpp: (JSEvaluateScript): (JSCheckScriptSyntax):
API/JSContextRef.cpp: (JSGlobalContextRetain): (JSGlobalContextRelease): (JSGlobalContextCopyName): (JSGlobalContextSetName): (JSGlobalContextGetRemoteInspectionEnabled): (JSGlobalContextSetRemoteInspectionEnabled): (JSGlobalContextGetIncludesNativeCallStackWhenReportingExceptions): (JSGlobalContextSetIncludesNativeCallStackWhenReportingExceptions): (JSGlobalContextGetDebuggerRunLoop): (JSGlobalContextSetDebuggerRunLoop): (JSGlobalContextGetAugmentableInspectorController):
API/JSValue.mm: (reportExceptionToInspector):
API/glib/JSCClass.cpp: (jscContextForObject):
API/glib/JSCContext.cpp: (jsc_context_evaluate_in_object):
debugger/Debugger.cpp: (JSC::Debugger::pauseIfNeeded):
debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::vmEntryGlobalObject const): (JSC::DebuggerCallFrame::evaluateWithScopeExtension):
interpreter/CallFrame.cpp: (JSC::CallFrame::vmEntryGlobalObject): Deleted.
interpreter/CallFrame.h: (JSC::ExecState::scope const): (JSC::ExecState::noCaller): (JSC::ExecState::isGlobalExec const):
interpreter/Interpreter.cpp: (JSC::notifyDebuggerOfUnwinding): (JSC::Interpreter::notifyDebuggerOfExceptionToBeThrown): (JSC::Interpreter::debug):
runtime/CallData.cpp: (JSC::profiledCall):
runtime/Completion.cpp: (JSC::evaluate): (JSC::profiledEvaluate): (JSC::evaluateWithScopeExtension): (JSC::loadAndEvaluateModule): (JSC::loadModule): (JSC::linkAndEvaluateModule): (JSC::importModule):
runtime/ConstructData.cpp: (JSC::profiledConstruct):
runtime/Error.cpp: (JSC::getStackTrace):
runtime/VM.cpp: (JSC::VM::throwException): (JSC::VM::vmEntryGlobalObject const):
runtime/VM.h:

2018-08-27 Mark Lam <mark.lam@apple.com>

Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names.
https://bugs.webkit.org/show_bug.cgi?id=188577
<rdar://problem/42985684>

Reviewed by Saam Barati.

Introduced CallFrame::convertToStackOverflowFrame() which converts the current (top) CallFrame (which may not have a valid callee) into a StackOverflowFrame.

The StackOverflowFrame is a sentinel frame that the low level code (exception
throwing code, stack visitor, and stack unwinding code) will know to skip
over. The StackOverflowFrame will also have a valid JSCallee so that client
code can compute the globalObject or VM from this frame.

As a result, client code that throws StackOverflowErrors no longer need to
compute the caller frame to throw from: it just converts the top frame into
a StackOverflowFrame and everything should *Just Work*.

NativeCallFrameTracerWithRestore is now obsolete.

Instead, client code should always call convertToStackOverflowFrame() on the
frame before instantiating a NativeCallFrameTracer with it.

This means that topCallFrame will always point to the top CallFrame (which
may be a StackOverflowFrame), and topEntryFrame will always point to the top
EntryFrame. We'll never temporarily point them to the previous EntryFrame
(which we used to do with NativeCallFrameTracerWithRestore).

genericUnwind() and Interpreter::unwind() will now always unwind from the top CallFrame, and will know how to handle a StackOverflowFrame if they see one.

This obsoletes the UnwindStart flag.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Sources.txt:
debugger/Debugger.cpp: (JSC::Debugger::pauseIfNeeded):
interpreter/CallFrame.cpp: (JSC::CallFrame::callerFrame const): (JSC::CallFrame::unsafeCallerFrame const): (JSC::CallFrame::convertToStackOverflowFrame): (JSC::CallFrame::callerFrame): Deleted. (JSC::CallFrame::unsafeCallerFrame): Deleted.
interpreter/CallFrame.h: (JSC::ExecState::iterate):
interpreter/CallFrameInlines.h: Added. (JSC::CallFrame::isStackOverflowFrame const): (JSC::CallFrame::isWasmFrame const):
interpreter/EntryFrame.h: Added. (JSC::EntryFrame::vmEntryRecordOffset): (JSC::EntryFrame::calleeSaveRegistersBufferOffset):
interpreter/FrameTracers.h: (JSC::NativeCallFrameTracerWithRestore::NativeCallFrameTracerWithRestore): Deleted. (JSC::NativeCallFrameTracerWithRestore::~NativeCallFrameTracerWithRestore): Deleted.
interpreter/Interpreter.cpp: (JSC::Interpreter::unwind):
interpreter/Interpreter.h:
interpreter/StackVisitor.cpp: (JSC::StackVisitor::StackVisitor):
interpreter/StackVisitor.h: (JSC::StackVisitor::visit): (JSC::StackVisitor::topEntryFrameIsEmpty const):
interpreter/VMEntryRecord.h: (JSC::VMEntryRecord::callee const): (JSC::EntryFrame::vmEntryRecordOffset): Deleted. (JSC::EntryFrame::calleeSaveRegistersBufferOffset): Deleted.
jit/AssemblyHelpers.h:
jit/JITExceptions.cpp: (JSC::genericUnwind):
jit/JITExceptions.h:
jit/JITOperations.cpp:
llint/LLIntOffsetsExtractor.cpp:
llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL):
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/CallData.cpp:
runtime/CommonSlowPaths.cpp: (JSC::throwArityCheckStackOverflowError): (JSC::SLOW_PATH_DECL):
runtime/CommonSlowPathsExceptions.cpp: Removed.
runtime/CommonSlowPathsExceptions.h: Removed.
runtime/Completion.cpp: (JSC::evaluateWithScopeExtension):
runtime/JSGeneratorFunction.h:
runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::init): (JSC::JSGlobalObject::visitChildren):
runtime/JSGlobalObject.h: (JSC::JSGlobalObject::stackOverflowFrameCallee const):
runtime/VM.cpp: (JSC::VM::throwException):
runtime/VM.h:
runtime/VMInlines.h: (JSC::VM::topJSCallFrame const):

2018-09-05 David Kilzer <ddkilzer@apple.com>

REGRESSION (r235419): DFGCFG.h is missing from JavaScriptCore Xcode project

Found using tidy-Xcode-project-file --missing (see Bug
188754). Fix was made manually.

JavaScriptCore.xcodeproj/project.pbxproj: (dfg/DFGCFG.h): Revert accidental change in r235419 by restoring name and path values to file reference.

Source/WebCore:

2018-08-23 Mark Lam <mark.lam@apple.com>

Move vmEntryGlobalObject() to VM from CallFrame.
https://bugs.webkit.org/show_bug.cgi?id=188900
<rdar://problem/43655753>

Reviewed by Michael Saboff.

No new tests needed because this patch does not introduce new functionality.

bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
bindings/js/JSDOMGlobalObject.cpp: (WebCore::callerGlobalObject): (WebCore::toJSDOMGlobalObject): Deleted.
bindings/js/JSDOMWindowBase.cpp: (WebCore::firstDOMWindow):
bridge/c/c_utility.cpp: (JSC::Bindings::convertValueToNPVariant):
bridge/objc/WebScriptObject.mm: (WebCore::addExceptionToConsole):
bridge/objc/objc_instance.mm: (ObjcInstance::moveGlobalExceptionToExecState):
bridge/objc/objc_runtime.mm: (JSC::Bindings::convertValueToObjcObject):
bridge/objc/objc_utility.mm: (JSC::Bindings::convertValueToObjcValue):
testing/Internals.cpp: (WebCore::Internals::cloneArrayBuffer):

Source/WebKitLegacy/mac:

2018-08-23 Mark Lam <mark.lam@apple.com>

Move vmEntryGlobalObject() to VM from CallFrame.
https://bugs.webkit.org/show_bug.cgi?id=188900
<rdar://problem/43655753>

Reviewed by Michael Saboff.

WebView/WebScriptDebugger.mm: (WebScriptDebugger::sourceParsed):

LayoutTests:

2018-08-27 Mark Lam <mark.lam@apple.com>

Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names.
https://bugs.webkit.org/show_bug.cgi?id=188577
<rdar://problem/42985684>

Reviewed by Saam Barati.

http/tests/misc/large-js-program-expected.txt:

1:11 AM Changeset in webkit [235730] by bshafiei@apple.com

3 edits
1 add in branches/safari-606-branch

Cherry-pick r235715. rdar://problem/44169344

JSPropertyNameEnumerator::visitChildren() needs to visit its m_cachedStructureID.
https://bugs.webkit.org/show_bug.cgi?id=189124
<rdar://problem/43863605>

Reviewed by Filip Pizlo.

JSTests:

stress/regress-189124.js: Added.

Source/JavaScriptCore:

It is assumed that the Structure for the m_cachedStructureID will remain alive
while the m_cachedStructureID is in use. This prevents the structureID from being
re-used for a different Structure.

runtime/JSPropertyNameEnumerator.cpp: (JSC::JSPropertyNameEnumerator::visitChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235729] by bshafiei@apple.com

3 edits
2 adds in branches/safari-606-branch

Cherry-pick r235537. rdar://problem/44169516

CounterMaps should hold a unique_ptr of CounterMap.
https://bugs.webkit.org/show_bug.cgi?id=189174
<rdar://problem/43686458>

Reviewed by Ryosuke Niwa.

Source/WebCore:

In certain cases calls to CounterMaps might lead to unexpected deletion of the CounterMap object.

Test: fast/css/counters/crash-when-cloning-body.html

rendering/RenderCounter.cpp: (WebCore::makeCounterNode): (WebCore::destroyCounterNodeWithoutMapRemoval): (WebCore::RenderCounter::destroyCounterNodes): (WebCore::RenderCounter::destroyCounterNode): (WebCore::updateCounters): (showCounterRendererTree):

LayoutTests:

fast/css/counters/crash-when-cloning-body-expected.txt: Added.
fast/css/counters/crash-when-cloning-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235728] by bshafiei@apple.com

4 edits
1 add in branches/safari-606-branch

Cherry-pick r235177. rdar://problem/44169333

The DFG CFGSimplification phase shouldn’t jettison a block when it’s the target of both branch directions.
https://bugs.webkit.org/show_bug.cgi?id=188298
<rdar://problem/42888427>

Reviewed by Saam Barati.

JSTests:

stress/bug-188298.js: Added.

Source/JavaScriptCore:

In the event that both targets of a Branch is the same block, then even if we'll
always take one path of the branch, the other target is not unreachable because
it is the same target as the one in the taken path. Hence, it should not be
jettisoned.

JavaScriptCore.xcodeproj/project.pbxproj:
Added DFGCFG.h which is in use and should have been added to the project.
dfg/DFGCFGSimplificationPhase.cpp: (JSC::DFG::CFGSimplificationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235727] by bshafiei@apple.com

1 edit
2 adds in branches/safari-606-branch/LayoutTests

Cherry-pick r233902. rdar://problem/44168991

Rebaseline imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker.html for Sierra after r233898.

Unreviewed test gardening.

platform/mac-sierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Added.
platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.https.worker-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235726] by bshafiei@apple.com

6 edits in branches/safari-606-branch/LayoutTests

Cherry-pick r233900. rdar://problem/44168991

Unreviewed, test gardening after r233898.

TestExpectations:
platform/gtk/TestExpectations:
platform/ios/TestExpectations:
platform/mac/TestExpectations:
platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:11 AM Changeset in webkit [235725] by bshafiei@apple.com

62 edits
60 adds in branches/safari-606-branch

Cherry-pick r233898. rdar://problem/44168991

[WebCrypto] Crypto operations should copy their parameters before hoping to another thread
https://bugs.webkit.org/show_bug.cgi?id=187501
<rdar://problem/41438160>

Reviewed by Youenn Fablet.

Source/WebCore:

This patch aims at making all captured variables in all crypto lambdas that need to be passed
to a worker thread thread safe, which includes:
1) changing ref counted objects to thread safe ref counted object.
2) adding isolatedCopy methods to non ref counted classes, so they can be called by CrossThreadCopy().

In addition to above changes, this patch also does the following things:
1) change the name CryptoAlgorithm::dispatchOperation => CryptoAlgorithm::dispatchOperationInWorkQueue
to make it clear that lambdas will be passed to a secondary thread.
2) make CryptoAlgorithmParameters as const parameters for all methods.
3) add null checks on BufferSource.length() and .data().

Tests: crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html

http/wpt/crypto/aes-cbc-crash.any.html
http/wpt/crypto/aes-cbc-crash.any.worker.html
http/wpt/crypto/aes-ctr-crash.any.html
http/wpt/crypto/aes-ctr-crash.any.worker.html
http/wpt/crypto/aes-gcm-crash.any.html
http/wpt/crypto/aes-gcm-crash.any.worker.html
http/wpt/crypto/derive-hmac-key-crash.any.html
http/wpt/crypto/derive-hmac-key-crash.any.worker.html
http/wpt/crypto/ecdsa-crash.any.html
http/wpt/crypto/ecdsa-crash.any.worker.html
http/wpt/crypto/hkdf-crash.any.html
http/wpt/crypto/hkdf-crash.any.worker.html
http/wpt/crypto/pbkdf2-crash.any.html
http/wpt/crypto/pbkdf2-crash.any.worker.html
http/wpt/crypto/rsa-oaep-crash.any.html
http/wpt/crypto/rsa-oaep-crash.any.worker.html
http/wpt/crypto/rsa-pss-crash.any.html
http/wpt/crypto/rsa-pss-crash.any.worker.html
http/wpt/crypto/unwrap-ec-key-crash.any.html
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html
http/wpt/crypto/unwrap-rsa-key-crash.any.html
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html

bindings/js/BufferSource.h: (WebCore::BufferSource::data const): (WebCore::BufferSource::length const):
crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::encrypt): (WebCore::CryptoAlgorithm::decrypt): (WebCore::CryptoAlgorithm::sign): (WebCore::CryptoAlgorithm::verify): (WebCore::CryptoAlgorithm::deriveBits): (WebCore::CryptoAlgorithm::importKey): (WebCore::dispatchAlgorithmOperation): (WebCore::CryptoAlgorithm::dispatchOperationInWorkQueue): (WebCore::CryptoAlgorithm::dispatchOperation): Deleted.
crypto/CryptoAlgorithm.h:
crypto/SubtleCrypto.cpp: (WebCore::crossThreadCopyImportParams): (WebCore::SubtleCrypto::encrypt): (WebCore::SubtleCrypto::decrypt): (WebCore::SubtleCrypto::sign): (WebCore::SubtleCrypto::verify): (WebCore::SubtleCrypto::deriveKey): (WebCore::SubtleCrypto::deriveBits): (WebCore::SubtleCrypto::importKey): (WebCore::SubtleCrypto::wrapKey): (WebCore::SubtleCrypto::unwrapKey):
crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: (WebCore::CryptoAlgorithmAES_CBC::encrypt): (WebCore::CryptoAlgorithmAES_CBC::decrypt): (WebCore::CryptoAlgorithmAES_CBC::importKey):
crypto/algorithms/CryptoAlgorithmAES_CBC.h:
crypto/algorithms/CryptoAlgorithmAES_CFB.cpp: (WebCore::CryptoAlgorithmAES_CFB::encrypt): (WebCore::CryptoAlgorithmAES_CFB::decrypt): (WebCore::CryptoAlgorithmAES_CFB::importKey):
crypto/algorithms/CryptoAlgorithmAES_CFB.h:
crypto/algorithms/CryptoAlgorithmAES_CTR.cpp: (WebCore::parametersAreValid): (WebCore::CryptoAlgorithmAES_CTR::encrypt): (WebCore::CryptoAlgorithmAES_CTR::decrypt): (WebCore::CryptoAlgorithmAES_CTR::importKey):
crypto/algorithms/CryptoAlgorithmAES_CTR.h:
crypto/algorithms/CryptoAlgorithmAES_GCM.cpp: (WebCore::CryptoAlgorithmAES_GCM::encrypt): (WebCore::CryptoAlgorithmAES_GCM::decrypt): (WebCore::CryptoAlgorithmAES_GCM::importKey):
crypto/algorithms/CryptoAlgorithmAES_GCM.h:
crypto/algorithms/CryptoAlgorithmAES_KW.cpp: (WebCore::CryptoAlgorithmAES_KW::importKey):
crypto/algorithms/CryptoAlgorithmAES_KW.h:
crypto/algorithms/CryptoAlgorithmECDH.cpp: (WebCore::CryptoAlgorithmECDH::deriveBits): (WebCore::CryptoAlgorithmECDH::importKey):
crypto/algorithms/CryptoAlgorithmECDH.h:
crypto/algorithms/CryptoAlgorithmECDSA.cpp: (WebCore::CryptoAlgorithmECDSA::sign): (WebCore::CryptoAlgorithmECDSA::verify): (WebCore::CryptoAlgorithmECDSA::importKey):
crypto/algorithms/CryptoAlgorithmECDSA.h:
crypto/algorithms/CryptoAlgorithmHKDF.cpp: (WebCore::CryptoAlgorithmHKDF::deriveBits): (WebCore::CryptoAlgorithmHKDF::importKey):
crypto/algorithms/CryptoAlgorithmHKDF.h:
crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::sign): (WebCore::CryptoAlgorithmHMAC::verify): (WebCore::CryptoAlgorithmHMAC::importKey):
crypto/algorithms/CryptoAlgorithmHMAC.h:
crypto/algorithms/CryptoAlgorithmPBKDF2.cpp: (WebCore::CryptoAlgorithmPBKDF2::deriveBits): (WebCore::CryptoAlgorithmPBKDF2::importKey):
crypto/algorithms/CryptoAlgorithmPBKDF2.h:
crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey):
crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::encrypt): (WebCore::CryptoAlgorithmRSA_OAEP::decrypt): (WebCore::CryptoAlgorithmRSA_OAEP::importKey):
crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp: (WebCore::CryptoAlgorithmRSA_PSS::sign): (WebCore::CryptoAlgorithmRSA_PSS::verify): (WebCore::CryptoAlgorithmRSA_PSS::importKey):
crypto/algorithms/CryptoAlgorithmRSA_PSS.h:
crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt): (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
crypto/gcrypt/CryptoAlgorithmAES_CFBGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CFB::platformEncrypt): (WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
crypto/gcrypt/CryptoAlgorithmAES_CTRGCrypt.cpp: (WebCore::CryptoAlgorithmAES_CTR::platformEncrypt): (WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp: (WebCore::CryptoAlgorithmAES_GCM::platformEncrypt): (WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
crypto/gcrypt/CryptoAlgorithmHKDFGCrypt.cpp: (WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
crypto/gcrypt/CryptoAlgorithmPBKDF2GCrypt.cpp: (WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt): (WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp: (WebCore::CryptoAlgorithmRSA_PSS::platformSign): (WebCore::CryptoAlgorithmRSA_PSS::platformVerify):
crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt): (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):
crypto/mac/CryptoAlgorithmAES_CFBMac.cpp: (WebCore::CryptoAlgorithmAES_CFB::platformEncrypt): (WebCore::CryptoAlgorithmAES_CFB::platformDecrypt):
crypto/mac/CryptoAlgorithmAES_CTRMac.cpp: (WebCore::CryptoAlgorithmAES_CTR::platformEncrypt): (WebCore::CryptoAlgorithmAES_CTR::platformDecrypt):
crypto/mac/CryptoAlgorithmAES_GCMMac.cpp: (WebCore::CryptoAlgorithmAES_GCM::platformEncrypt): (WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):
crypto/mac/CryptoAlgorithmHKDFMac.cpp: (WebCore::CryptoAlgorithmHKDF::platformDeriveBits):
crypto/mac/CryptoAlgorithmPBKDF2Mac.cpp: (WebCore::CryptoAlgorithmPBKDF2::platformDeriveBits):
crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt): (WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):
crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp: (WebCore::CryptoAlgorithmRSA_PSS::platformSign): (WebCore::CryptoAlgorithmRSA_PSS::platformVerify):
crypto/parameters/CryptoAlgorithmAesCbcCfbParams.h:
crypto/parameters/CryptoAlgorithmAesCtrParams.h:
crypto/parameters/CryptoAlgorithmAesGcmParams.h:
crypto/parameters/CryptoAlgorithmEcKeyParams.h:
crypto/parameters/CryptoAlgorithmEcdsaParams.h:
crypto/parameters/CryptoAlgorithmHkdfParams.h:
crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
crypto/parameters/CryptoAlgorithmRsaPssParams.h:

LayoutTests:

crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html is an exception of this series of tests as
it only aims to test the correct behavoir of suggested algorithms. This patch aslo does some test
gardening.

TestExpectations:
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key-expected.txt: Added.
crypto/subtle/aes-gcm-import-key-unwrap-ec-raw-key.html: Added.
http/wpt/crypto/aes-cbc-crash.any-expected.txt: Added.
http/wpt/crypto/aes-cbc-crash.any.html: Added.
http/wpt/crypto/aes-cbc-crash.any.js: Added.
http/wpt/crypto/aes-cbc-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-cbc-crash.any.worker.html: Added.
http/wpt/crypto/aes-ctr-crash.any-expected.txt: Added.
http/wpt/crypto/aes-ctr-crash.any.html: Added.
http/wpt/crypto/aes-ctr-crash.any.js: Added.
http/wpt/crypto/aes-ctr-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-ctr-crash.any.worker.html: Added.
http/wpt/crypto/aes-gcm-crash.any-expected.txt: Added.
http/wpt/crypto/aes-gcm-crash.any.html: Added.
http/wpt/crypto/aes-gcm-crash.any.js: Added.
http/wpt/crypto/aes-gcm-crash.any.worker-expected.txt: Added.
http/wpt/crypto/aes-gcm-crash.any.worker.html: Added.
http/wpt/crypto/derive-hmac-key-crash.any-expected.txt: Added.
http/wpt/crypto/derive-hmac-key-crash.any.html: Added.
http/wpt/crypto/derive-hmac-key-crash.any.js: Added.
http/wpt/crypto/derive-hmac-key-crash.any.worker-expected.txt: Added.
http/wpt/crypto/derive-hmac-key-crash.any.worker.html: Added.
http/wpt/crypto/ecdsa-crash.any-expected.txt: Added.
http/wpt/crypto/ecdsa-crash.any.html: Added.
http/wpt/crypto/ecdsa-crash.any.js: Added.
http/wpt/crypto/ecdsa-crash.any.worker-expected.txt: Added.
http/wpt/crypto/ecdsa-crash.any.worker.html: Added.
http/wpt/crypto/hkdf-crash.any-expected.txt: Added.
http/wpt/crypto/hkdf-crash.any.html: Added.
http/wpt/crypto/hkdf-crash.any.js: Added.
http/wpt/crypto/hkdf-crash.any.worker-expected.txt: Added.
http/wpt/crypto/hkdf-crash.any.worker.html: Added.
http/wpt/crypto/pbkdf2-crash.any-expected.txt: Added.
http/wpt/crypto/pbkdf2-crash.any.html: Added.
http/wpt/crypto/pbkdf2-crash.any.js: Added.
http/wpt/crypto/pbkdf2-crash.any.worker-expected.txt: Added.
http/wpt/crypto/pbkdf2-crash.any.worker.html: Added.
http/wpt/crypto/resources/common.js: Added.
http/wpt/crypto/rsa-oaep-crash.any-expected.txt: Added.
http/wpt/crypto/rsa-oaep-crash.any.html: Added.
http/wpt/crypto/rsa-oaep-crash.any.js: Added.
http/wpt/crypto/rsa-oaep-crash.any.worker-expected.txt: Added.
http/wpt/crypto/rsa-oaep-crash.any.worker.html: Added.
http/wpt/crypto/rsa-pss-crash.any-expected.txt: Added.
http/wpt/crypto/rsa-pss-crash.any.html: Added.
http/wpt/crypto/rsa-pss-crash.any.js: Added.
http/wpt/crypto/rsa-pss-crash.any.worker-expected.txt: Added.
http/wpt/crypto/rsa-pss-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-ec-key-crash.any-expected.txt: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.html: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.js: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.worker-expected.txt: Added.
http/wpt/crypto/unwrap-ec-key-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any-expected.txt: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.js: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker.html: Added.
http/wpt/crypto/unwrap-rsa-key-crash.any.worker-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:28 AM Changeset in webkit [235724] by bshafiei@apple.com

7 edits in tags/Safari-607.1.5.1/Source

Versioning.

12:25 AM Changeset in webkit [235723] by bshafiei@apple.com

1 copy in tags/Safari-607.1.5.1

Tag Safari-607.1.5.1.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed